* lisp/files.el (file-auto-mode-skip): New var.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
71873e2b
SM
12012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2
3 * data.c (PUT_ERROR): New macro.
4 (syms_of_data): Use it. Add new error type `user-error'.
5 * undo.c (user_error): New function.
6 (Fprimitive_undo): Use it.
7 * print.c (print_error_message): Adjust print style for `user-error'.
8 * keyboard.c (user_error): New function.
9 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
10
ab0fa4e4
PE
112012-05-03 Paul Eggert <eggert@cs.ucla.edu>
12
13 Do not limit current-time-string to years 1000..9999.
14 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
15 (Fcurrent_time_string): Support any year that is supported by the
16 underlying localtime representation. Don't use asctime, as it
17 has undefined behavior for years outside the range -999..9999.
18
7ed806a7
PE
192012-05-02 Paul Eggert <eggert@cs.ucla.edu>
20
21 Fix race conditions involving setenv, gmtime, localtime, asctime.
22 Without this fix, interrupts could mess up code that uses these
23 nonreentrant functions, since setting TZ invalidates existing
24 tm_zone or tzname values, and since most of these functions return
25 pointers to static storage.
26 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
27 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
28 Grow the critical sections to include not just invoking
29 localtime/gmtime, but also accessing these functions' results
30 including their tm_zone values if any, and any related TZ setting.
31 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
32 so that the struct tm is saved in the critical section.
33 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
34 motivated by the fact that memory allocation needs to be outside
35 the critical section.
36
0c16dfed
DA
372012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
38
39 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
40 with RESET_INTERVAL.
41
42 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
43 Remove duplicated buffer name initialization.
44
3f83ace8
JM
452012-05-02 Jim Meyering <jim@meyering.net>
46
47 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
48
c7b8541e
JM
49 * xfns.c (x_window): Use xstrdup (Bug#11375).
50
90207a15 512012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
52
53 * xdisp.c (pos_visible_p): If already at a newline from the
54 display string before the 'while' loop, don't walk back the glyphs
55 from it3.glyph_row. Solves assertion violation when the display
56 string begins with a newline (egg.el). (Bug#11367)
57
b593d6a9
AH
582012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
59
60 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
61 Move to simple.el.
62
4737362e
GM
632012-05-01 Glenn Morris <rgm@gnu.org>
64
99cf43f9
GM
65 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
66 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
67 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
68 All were removed before 23.1.
69
9311dcff
GM
70 * dispnew.c: Remove HAVE_LIBNCURSES test;
71 it is always true on relevant platforms.
72
4d5c6349
GM
73 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
74 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
75
4737362e
GM
76 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
77
74dd3a6b
AS
782012-04-30 Andreas Schwab <schwab@linux-m68k.org>
79
80 * .gdbinit (xpr): Remove checks for no longer existing misc types.
81 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
82 Remove.
83
13c379ee
PE
842012-04-28 Paul Eggert <eggert@cs.ucla.edu>
85
86 Do not avoid creating empty evaporating overlays (Bug#9642).
87 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
88 That is, do not delete an evaporating overlay if it becomes
89 empty after its bounds are adjusted to fit within its buffer.
90 This fix caused other problems, and I'm reverting it until we get
91 to the bottom of them.
92
a8e7d6d7 932012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
94
95 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
96
a8e7d6d7 972012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
98
99 * xdisp.c (pos_visible_p): If the window start position is beyond
100 ZV, start the display from buffer beginning. Prevents assertion
101 violation in init_iterator when the minibuffer window is scrolled
102 via the scroll bar.
103
104 * window.c (window_scroll_pixel_based): Likewise.
105
a8e7d6d7 1062012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
107
108 * keymap.c (where_is_internal): Doc fix (Bug#10872).
109
a8e7d6d7 1102012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
111
112 * fileio.c (Fcopy_file, Fset_file_selinux_context):
113 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
114
a8e7d6d7 1152012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 116
b593d6a9
AH
117 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
118 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 119
1c6900d9
EZ
1202012-04-26 Eli Zaretskii <eliz@gnu.org>
121
4c3fa1d9
EZ
122 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
123 display element, check also the underlying string or buffer
124 character. (Bug#11341)
125
1c6900d9
EZ
126 * w32menu.c: Include w32heap.h.
127 (add_menu_item): If the call to AppendMenuW (via
128 unicode_append_menu) fails, disable Unicode menus only if we are
129 running on Windows 9X/Me.
130
42bf8205
AS
1312012-04-24 Andreas Schwab <schwab@linux-m68k.org>
132
133 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
134 (xgetint): Add missing shift for LSB tags.
135
b1bac16e
MR
1362012-04-24 Martin Rudalics <rudalics@gmx.at>
137
138 * keyboard.c (read_char): Don't wipe echo area for select window
139 events: These might get delayed via `mouse-autoselect-window'
140 (Bug#11304).
141
d69621cc
JB
1422012-04-24 Juanma Barranquero <lekktu@gmail.com>
143
144 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
145 manipulation of :loaded-from data.
146
02fd101b
JB
1472012-04-23 Juanma Barranquero <lekktu@gmail.com>
148
149 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
150 now a cons (bug#11311).
151
888bec30
PE
1522012-04-23 Paul Eggert <eggert@cs.ucla.edu>
153
89a438bd
PE
154 Do not create empty overlays with the evaporate property (Bug#9642).
155 * buffer.c (Fmove_overlay): Delete an evaporating overlay
156 if it becomes empty after its bounds are adjusted to fit within
157 its buffer. Without this fix, in a nonempty buffer (let ((o
158 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
159 yields an empty overlay that has the evaporate property, which is
160 not supposed to happen.
161
1068fe4d
PE
162 Fix minor GTK3 problems found by static checking.
163 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
164 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
165 (struct _EmacsFixedClass, emacs_fixed_get_type):
166 Move decls here from emacsgtkfixed.h, since they needn't be public.
167 (emacs_fixed_get_type): Now static.
168 (emacs_fixed_class_init): Omit unused local.
169 (emacs_fixed_child_type): Remove; unused.
170 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
171 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
172 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
173 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
174 (EMACS_FIXED_GET_CLASS): Remove; unused.
175 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
176
888bec30
PE
177 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
178 Problem reported by Juanma Barranquero for Windows -Wunused-function.
179
de85e130
PE
1802012-04-22 Paul Eggert <eggert@cs.ucla.edu>
181
d0baac98
PE
182 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
183 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
184 (__malloc_size_t, __malloc_ptrdiff_t):
185 Remove. All uses removed, replaced by the definiens if needed,
186 since we can assume C89 or better now.
187 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
188 (protect_malloc_state, align, get_contiguous_space)
189 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
190 (malloc_atfork_handler_child, malloc_enable_thread)
191 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
192 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
193 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
194 (special_realloc, _realloc_internal_nolock, _realloc_internal)
195 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
196 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
197 Define using prototypes, not old style.
198 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
199 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
200 (align): Don't assume that signed integer overflow wraps around.
201 Omit unused local var.
202 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
203 (_free_internal_nolock, memalign, mallochook, reallochook):
204 Omit no-longer-needed casts.
205 (valloc): Use getpagesize, not __getpagesize.
206 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
207 (struct hdr): The 'magic' member is now size_t, not unsigned long.
208
de85e130
PE
209 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
210
dcbf5805
MA
2112012-04-22 Michael Albinus <michael.albinus@gmx.de>
212
213 Move functions from C to Lisp. Make non-blocking method calls
214 the default. Implement further D-Bus standard interfaces.
215
216 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
217 (QCdbus_request_name_allow_replacement)
218 (QCdbus_request_name_replace_existing)
219 (QCdbus_request_name_do_not_queue)
220 (QCdbus_request_name_reply_primary_owner)
221 (QCdbus_request_name_reply_in_queue)
222 (QCdbus_request_name_reply_exists)
223 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
224 (QCdbus_registered_serial, QCdbus_registered_method)
225 (QCdbus_registered_signal): New Lisp objects.
226 (XD_DEBUG_MESSAGE): Use sizeof.
227 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
228 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
229 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
230 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
231 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
232 (xd_signature, xd_append_arg): Allow float for integer types.
233 (xd_get_connection_references): New function.
b593d6a9
AH
234 (xd_get_connection_address): Rename from xd_initialize.
235 Return cached address.
dcbf5805
MA
236 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
237 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
238 level.
239 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
240 Return number of recounts.
241 (Fdbus_get_unique_name): Make stronger parameter check.
242 (Fdbus_message_internal): New defun.
243 (Fdbus_call_method, Fdbus_call_method_asynchronously)
244 (Fdbus_method_return_internal, Fdbus_method_error_internal)
245 (Fdbus_send_signal, Fdbus_register_service)
246 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
247 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
248 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
249 (Vdbus_compiled_version, Vdbus_runtime_version)
250 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
251 (Vdbus_message_type_method_return, Vdbus_message_type_error)
252 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
253 (Vdbus_registered_buses, Vdbus_registered_objects_table):
254 Adapt docstring.
dcbf5805 255
52828e02
PE
2562012-04-22 Paul Eggert <eggert@cs.ucla.edu>
257
da05bc4c
PE
258 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
259 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
260 Do not assume ptrdiff_t is the same width as 'int'.
261
52828e02
PE
262 * alloc.c: Handle unusual debugging option combinations.
263 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
264 since the two debugging options are incompatible.
265 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
266 is defined.
267 (mem_init, mem_insert, mem_insert_fixup):
268 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
269 (NEED_MEM_INSERT): Remove; no longer needed.
270
f01769f9
LL
2712012-04-22 Leo Liu <sdl.web@gmail.com>
272
273 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
274
5790543d
PE
2752012-04-22 Paul Eggert <eggert@cs.ucla.edu>
276
277 * sysdep.c [__FreeBSD__]: Minor cleanups.
278 (list_system_processes, system_process_attributes) [__FreeBSD__]:
279 Use Emacs indenting style more consistently. Avoid some casts.
280 Use 'double' consistently rather than mixing 'float' and 'double'.
281
b91b7e4d
EW
2822012-04-21 Eduard Wiebe <usenet@pusto.de>
283
b593d6a9
AH
284 * sysdep.c (list_system_processes, system_process_attributes):
285 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 286
6114eb15
AS
2872012-04-21 Andreas Schwab <schwab@linux-m68k.org>
288
289 * lisp.mk (lisp): Update.
290
2f38dff7
PE
2912012-04-20 Paul Eggert <eggert@cs.ucla.edu>
292
293 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
294 It is never used otherwise.
295
4ae29f89
SM
2962012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
297
298 * print.c (print_preprocess): Only check print_depth if print-circle
299 is nil.
300 (print_object): Check for cycles even when print-circle is nil and
301 print-gensym is t, but only check print_depth if print-circle is nil.
302
f30d612a
CY
3032012-04-20 Chong Yidong <cyd@gnu.org>
304
305 * process.c (wait_reading_process_output): If EIO occurs on a pty,
306 set the status to "failed" and ensure that sentinel is run.
307
c07a4c0b 3082012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
309
310 * process.c (Fset_process_inherit_coding_system_flag)
311 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 312 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 313
c07a4c0b 3142012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
315
316 * xdisp.c (string_buffer_position_lim): Limit starting position to
317 BEGV.
318 (set_cursor_from_row): If called for a mode-line or header-line
319 row, return zero immediately.
320 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
321 farther than the first row after the header line, if any.
322 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
323 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
324
c07a4c0b 3252012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 326
4ae29f89
SM
327 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
328 (bug#11238).
ad3a2b41 329
c07a4c0b 3302012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 3312012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
332
333 configure: new option --enable-gcc-warnings (Bug#11207)
334 * Makefile.in (C_WARNINGS_SWITCH): Remove.
335 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
336 (ALL_CFLAGS): Use new macros rather than old.
337 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
338 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
339 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
340 -Wunused-result, -Wunused-variable. This should go away once
341 the Emacs and Gnulib regex code is merged.
342 (xmalloc, xrealloc): Now static.
343
aba027e8
PE
3442012-04-17 Paul Eggert <eggert@cs.ucla.edu>
345
346 * dired.c (Fsystem_groups): Remove unused local.
347
e5a36063
GM
3482012-04-17 Glenn Morris <rgm@gnu.org>
349
350 * dired.c (Fsystem_users): Doc fix.
351
316411f0
DA
3522012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
353
354 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
355 (syms_of_dired): Add them.
356
9426aba4
PE
3572012-04-16 Paul Eggert <eggert@cs.ucla.edu>
358
b62a57be
PE
359 Fix minor alloc.c problems found by static checking.
360 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
361 New extern decls, to avoid calling undeclared functions.
362 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
363 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
364 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
365 (NEED_MEM_INSERT): New macro.
366 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 367 Remove one incorrect comment and fix another.
b62a57be 368
3539f31f
PE
369 Fix minor ralloc.c problems found by static checking.
370 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
371 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
372 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
373 (r_alloc_sbrk): Now static.
374
a041960a
PE
375 Improve ralloc.c interface checking.
376 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
377 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
378 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
379 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
380 [REL_ALLOC]: ... to here, to check interface.
381 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
382 Remove decls. This fixes an "It stinks!".
383
9426aba4
PE
384 * alloc.c (which_symbols): Fix alignment issue / type clash.
385
d55c12ed
AS
3862012-04-15 Andreas Schwab <schwab@linux-m68k.org>
387
388 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
389 (struct Lisp_Misc_Any): Likewise.
390 (struct Lisp_Free): Likewise.
391 * alloc.c (union aligned_Lisp_Symbol): Define.
392 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
393 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
394 (union aligned_Lisp_Misc): Define.
395 (MARKER_BLOCK_SIZE, struct marker_block): Use union
396 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 397 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 398
b948ce8b
PE
3992012-04-14 Paul Eggert <eggert@cs.ucla.edu>
400
401 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
402 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
403 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
404 * s/netbsd.h, s/sol2-6.h:
405 Remove definition of GC_MARK_STACK, since the default now works.
406 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
407 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
408 no longer the default.
409 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
410
35dc09a1 4112012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 412
35dc09a1
GM
413 * lread.c (lisp_file_lexically_bound_p):
414 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 415
35dc09a1
GM
4162012-04-14 Eli Zaretskii <eliz@gnu.org>
417
418 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
419 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
420
4212012-04-14 Jan Djärv <jan.h.d@swipnet.se>
422
423 * nsterm.m (constrainFrameRect): Always constrain when there is only
424 one screen (Bug#10962).
425
bcd86815
KB
4262012-04-13 Ken Brown <kbrown@cornell.edu>
427
428 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
429
c25df26e
RT
4302012-04-13 Reuben Thomas <rrt@sc3d.org>
431
432 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
433
0fc59f1e
DC
4342012-04-11 Daniel Colascione <dancol@dancol.org>
435
436 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
437 against is gone. It's better to use vfork now so that when Cygwin
438 gains a new, working vfork, we use it automatically (bug#10398).
439
de8c03dc
SM
4402012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
441
442 * window.c (save_window_save): Obey window-point-insertion-type.
443
2f097256
GM
4442012-04-11 Glenn Morris <rgm@gnu.org>
445
446 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
447
453b951e
SM
4482012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
449
450 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
451
75f1671a 4522012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
453
454 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
455 (force_quit_count): New var.
456 (handle_interrupt): Use it.
457
2a8ce227
JB
4582012-04-10 Juanma Barranquero <lekktu@gmail.com>
459
460 * w32.c (w32_delayed_load): Record the full path of the library
461 being loaded (bug#10424).
462
935396c0
GM
4632012-04-09 Glenn Morris <rgm@gnu.org>
464
05920a43
GM
465 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
466 not just in the obarray, before snarfing them. (Bug#11036)
467
935396c0
GM
468 * Makefile.in ($(leimdir)/leim-list.el):
469 Pass EMACS rather than BUILT_EMACS.
470
a18ecafa
TZ
4712012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
472
473 * process.c (make_process):
474 * process.h: Add integer `gnutls_handshakes_tried' member to
475 process struct.
476
6bbef4e5
JC
477 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
478 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
479
480 * gnutls.c (gnutls_log_function2i): Convenience log function.
481 (emacs_gnutls_read): Use new log functions,
482 `gnutls_handshakes_tried' process member, and
483 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
484 attempts per process (connection).
485
b4d3bc10
CY
4862012-04-09 Chong Yidong <cyd@gnu.org>
487
488 * eval.c (Fuser_variable_p, user_variable_p_eh)
489 (lisp_indirect_variable): Functions deleted.
490 (Fdefvar): Caller changed.
491
492 * callint.c (Finteractive, Fcall_interactively):
493 * minibuf.c (Fread_variable): Callers changed.
494
70f4d973
EZ
4952012-04-09 Eli Zaretskii <eliz@gnu.org>
496
497 * xdisp.c (set_cursor_from_row): If the display string appears in
498 the buffer at position that is closer to point than the position
499 after the display string, display the cursor on the first glyph of
500 the display string. Fixes cursor display when a 'display' text
501 property immediately follows invisible text. (Bug#11094)
502
cb3c2e3e
PE
5032012-04-09 Paul Eggert <eggert@cs.ucla.edu>
504
505 composite.c: use 'double' consistently
506 * composite.c (get_composition_id): Use 'double' consistently
507 instead of converting 'float' to 'double' and vice versa; this is
508 easier to understand and avoids a GCC warning.
509
fd06db5d
GM
5102012-04-09 Glenn Morris <rgm@gnu.org>
511
50fe702a
GM
512 * Makefile.in: Generate leim-list with bootstrap-emacs, in
513 preparation for dumping it with emacs. (Bug#4789)
514 (leimdir): New variable.
515 ($(leimdir)/leim-list.el): New rule.
516 (emacs$(EXEEXT)): Depend on leim-list.el.
517
fd06db5d
GM
518 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
519 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
520 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
521
55c131ee
AS
5222012-04-08 Andreas Schwab <schwab@linux-m68k.org>
523
524 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
525 proper alignment.
526
9209588f
JB
5272012-04-07 Juanma Barranquero <lekktu@gmail.com>
528
529 * xml.c (init_libxml2_functions) [WINDOWSNT]:
530 Remove unused local variable.
531
e3fb2efb
PE
5322012-04-07 Paul Eggert <eggert@cs.ucla.edu>
533
534 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
535 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
536 (mark_memory): Mark Lisp_Objects only if pointers might hide in
537 objects, as mark_maybe_pointer will catch them otherwise.
538 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
539 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
540
b5385551
PE
5412012-04-07 Paul Eggert <eggert@cs.ucla.edu>
542
543 Fix typo that broke non-Windows builds.
544 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
545
9078ead6
EZ
5462012-04-07 Eli Zaretskii <eliz@gnu.org>
547
548 Support building on MS-Windows with libxml2.
549
550 * makefile.w32-in (OBJ2): Add xml.$(O).
551 (GLOBAL_SOURCES): Add xml.c.
552 ($(BLD)/xml.$(O)): New dependency list.
553
554 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
555 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
556 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
557 [!WINDOWSNT]: New macros.
558 (init_libxml2_functions, libxml2_loaded_p): New functions.
559 (parse_region): Call fn_xmlCheckVersion instead of using the macro
560 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
561 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
562 Calls xmlCleanupParser only if libxml2 was loaded (or statically
563 linked in).
6bbef4e5
JC
564 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
565 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
566 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
567
568 * emacs.c: Don't include libxml/parser.h.
569 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
570 xmlCleanupParser directly.
571
572 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
573
3811fdf3
EZ
5742012-04-07 Eli Zaretskii <eliz@gnu.org>
575
576 * indent.c (Fvertical_motion): If there is a display string at
577 point, use it.vpos to compute how many lines to backtrack after
578 move_it_to point. (Bug#11133)
579
2f8e16b2
EZ
5802012-04-06 Eli Zaretskii <eliz@gnu.org>
581
582 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
583 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
584 about subtle differences between FETCH_CHAR* and STRING_CHAR*
585 macros related to unification of CJK characters. For the details,
586 see the discussion following the message here:
587 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
588
3d439cd1
CY
5892012-04-04 Chong Yidong <cyd@gnu.org>
590
591 * keyboard.c (Vdelayed_warnings_list): Doc fix.
592
8bc53d00
EZ
5932012-04-01 Eli Zaretskii <eliz@gnu.org>
594
595 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
596 instead of alloca. (Bug#11138)
597
3b0512a3
AS
5982012-04-01 Andreas Schwab <schwab@linux-m68k.org>
599
600 * w32menu.c (is_simple_dialog): Properly check lisp types.
601 (Bug#11141)
602
8427ddd2
EZ
6032012-03-31 Eli Zaretskii <eliz@gnu.org>
604
979022ef
EZ
605 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
606 position we get to after a call to move_it_to fails the
607 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
608 only if we wind up in a string from display property. (Bug#11063)
609
a6b1c7cc
EZ
610 * window.c (Fdelete_other_windows_internal): Invalidate the row
611 and column information about mouse highlight, so that redisplay
612 restores it after reallocating the glyph matrices. (Bug#7464)
613
8427ddd2
EZ
614 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
615 string comes from a `display' text property, use the buffer
616 position of that property as if we actually saw that position in
617 the row's glyphs.
697ba24b
EZ
618 (move_it_by_lines): Remove the assertion that
619 "it->current_x == 0 && it->hpos == 0" which can be legitimately
620 violated when there's a before-string at the beginning of a line.
621 (Bug#11063)
8427ddd2 622
65a0a738
EZ
6232012-03-30 Eli Zaretskii <eliz@gnu.org>
624
625 * xdisp.c (append_space_for_newline): If the default face was
626 remapped, use the remapped face for the appended newline.
627 (extend_face_to_end_of_line): Use the remapped default face for
628 extending the face to the end of the line.
629 (display_line): Call extend_face_to_end_of_line when the default
630 face was remapped. (Bug#11068)
631
581355cc
EZ
6322012-03-29 Eli Zaretskii <eliz@gnu.org>
633
634 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
635
e8fc049f
SM
6362012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
637
638 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
639
4fb9a543
GM
6402012-03-27 Glenn Morris <rgm@gnu.org>
641
642 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
643 Doc fixes.
644
679910f1
KH
6452012-03-26 Kenichi Handa <handa@m17n.org>
646
647 * dispextern.h (struct glyph): Fix previous change. Change the
648 bit length of glyphless.ch to 25 (Bug#11082).
649
90d49b7f
CY
6502012-03-26 Chong Yidong <cyd@gnu.org>
651
652 * keyboard.c (Vselection_inhibit_update_commands): New variable.
653 (command_loop_1): Use it; inhibit selection update for
654 handle-select-window too (Bug#8996).
655
f514f6f0
FP
6562012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
657
e8fc049f 658 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 659
bf43fa51
KH
6602012-03-25 Kenichi Handa <handa@m17n.org>
661
662 * dispextern.h (struct glyph): Change the bit length of
663 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
664
8a0c01dd
EZ
6652012-03-24 Eli Zaretskii <eliz@gnu.org>
666
667 * s/ms-w32.h (tzname): Include time.h before redirecting to
668 _tzname. Fixes the MSVC build. (Bug#9960)
669
7d1c3a76
AS
6702012-03-24 Andreas Schwab <schwab@linux-m68k.org>
671
8ed79523
AS
672 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
673 characters.
674
7d1c3a76
AS
675 * xterm.c (XTread_socket): Only modify handling_signal if
676 !SYNC_INPUT. (Bug#11080)
677
e99a9b8b
EZ
6782012-03-23 Eli Zaretskii <eliz@gnu.org>
679
680 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
681 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
682 when fetching a multibyte character consumes more bytes than
683 CHAR_BYTES returns, due to unification of CJK characters in
684 string_char. (Bug#11073)
685
5063c0e1
TN
6862012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
687
688 * process.c (wait_reading_process_output): Handle pty disconnect
689 by refraining from sending oneself a SIGCHLD (bug#10933).
690
9f851fbd
CY
6912012-03-22 Chong Yidong <cyd@gnu.org>
692
693 * dispextern.h (struct it): New member string_from_prefix_prop_p.
694
5063c0e1 695 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
696 Mark string as coming from a prefix property.
697 (handle_face_prop): Use default face for prefix strings (Bug#4281).
698 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
699
fb5b8aca
CY
7002012-03-21 Chong Yidong <cyd@gnu.org>
701
702 * xfaces.c (Vface_remapping_alist): Doc fix.
703
62356a1b
EZ
7042012-03-20 Eli Zaretskii <eliz@gnu.org>
705
706 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
707 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
708 Doc fixes.
62356a1b 709
025de85b
CY
7102012-03-20 Chong Yidong <cyd@gnu.org>
711
712 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
713 to reflect default non-nil value of redisplay-dont-pause.
714
4827f94e
KH
7152012-03-19 Kenichi Handa <handa@m17n.org>
716
717 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
718 it fit in a valid range (Bug#11003).
719
e50a24a2
EZ
7202012-03-18 Eli Zaretskii <eliz@gnu.org>
721
722 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
723 that is not from display property, accept the row as a "cursor
724 row" if one of the string's character has a non-nil `cursor'
725 property. Fixes cursor positioning when there are newlines in
726 overlay strings, e.g. in icomplete.el. (Bug#11035)
727
9af5ed87
PE
7282012-03-12 Paul Eggert <eggert@cs.ucla.edu>
729
730 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
731
d1f55f16
CY
7322012-03-12 Chong Yidong <cyd@gnu.org>
733
734 * eval.c (inhibit_lisp_code): Rename from
735 inhibit_window_configuration_change_hook; move from window.c.
736
737 * xfns.c (unwind_create_frame_1, Fx_create_frame):
738 * window.c (run_window_configuration_change_hook)
739 (syms_of_window): Callers changed.
740
66c5eebd
CY
7412012-03-11 Chong Yidong <cyd@gnu.org>
742
413df973
CY
743 * keymap.c (Fkey_description): Doc fix (Bug#9700).
744
66c5eebd
CY
745 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
746
1de11f56
CY
7472012-03-10 Chong Yidong <cyd@gnu.org>
748
749 * frame.c (other_visible_frames): Don't assume the selected frame
750 is visible (Bug#10955).
751
cae07000
SM
7522012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
753
754 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
755
89c94350
JD
7562012-03-08 Jan Djärv <jan.h.d@swipnet.se>
757
758 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
759 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
760 zero (Bug#10954).
761
999dd333
GM
7622012-03-03 Glenn Morris <rgm@gnu.org>
763
01a6dcc8 764 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 765
de0100f2
EZ
7662012-03-02 Eli Zaretskii <eliz@gnu.org>
767
768 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
769 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
770 (redisplay_window, next_element_from_string): Fix typos in
771 comments.
3e441275
EZ
772 (redisplay_window): Pass to move_it_vertically the margin in
773 pixels, not in screen lines.
de0100f2 774
96a72ee9
GM
7752012-03-02 Glenn Morris <rgm@gnu.org>
776
777 * buffer.c (buffer-list-update-hook): Doc fix.
778
312508d7
EZ
7792012-02-29 Eli Zaretskii <eliz@gnu.org>
780
781 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
782 push_it before setting up the iterator for the first overlay
783 string, even if we have an empty string loaded.
784 (next_overlay_string): If there's an empty string on the iterator
785 stack, pop the stack. (Bug#10903)
786
27f3c637
PE
7872012-02-25 Paul Eggert <eggert@cs.ucla.edu>
788
789 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
790 Suggested by Stefan Monnier in
791 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
792 * alloc.c (widen_to_Lisp_Object): New static function.
793 (mark_memory): Also mark Lisp_Objects by fetching pointer words
794 and widening them to Lisp_Objects. This would work even if
795 USE_LSB_TAG is defined and wide integers are used, which might
796 happen in a future version of Emacs.
797
3c9dfce6
CY
7982012-02-25 Chong Yidong <cyd@gnu.org>
799
fa74b241
CY
800 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
801 Doc fix.
802
3c9dfce6
CY
803 * xselect.c (Fx_selection_exists_p): Doc fix.
804 (x_clipboard_manager_save_all): Print an informative message
805 before saving to clipboard manager.
806
9486df08
CY
8072012-02-24 Chong Yidong <cyd@gnu.org>
808
809 * keyboard.c (process_special_events): Handle all X selection
810 requests in kbd_buffer, not just the next one (Bug#8869).
811
f01d3321
CY
8122012-02-23 Chong Yidong <cyd@gnu.org>
813
814 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
815 call when setting menu-bar-lines and tool-bar-lines parameters.
816 (unwind_create_frame_1): New helper function.
817
818 * window.c (inhibit_window_configuration_change_hook): New var.
819 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 820 (syms_of_window): Initialize it.
f01d3321 821
86b847b6
CY
8222012-02-22 Chong Yidong <cyd@gnu.org>
823
824 * xterm.c (x_draw_image_relief): Add missing type check for
825 Vtool_bar_button_margin (Bug#10743).
826
a59225b1
CY
8272012-02-21 Chong Yidong <cyd@gnu.org>
828
829 * fileio.c (Vfile_name_handler_alist): Doc fix.
830
831 * buffer.c (Fget_file_buffer): Protect against invalid file
832 handler return value.
833
310f5bd4
PE
8342012-02-20 Paul Eggert <eggert@cs.ucla.edu>
835
cb3a28cc
PE
836 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
837 when computing $valmask.
838
310f5bd4
PE
839 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
840 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
841 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
842 It's useless in that case, and it can cause problems on hosts
843 that allocate halves of EMACS_INT values separately.
844 Reported by Dan Horák. Diagnosed by Andreas Schwab in
845 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
846 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
847 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
848 it avoids undefined behavior on hosts where shifting right by more
849 than the word width has undefined behavior.
850
2375c96a
CY
8512012-02-19 Chong Yidong <cyd@gnu.org>
852
853 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
854 (Funhandled_file_name_directory, Ffile_name_as_directory)
855 (Fdirectory_file_name, Fexpand_file_name)
856 (Fsubstitute_in_file_name): Protect against invalid file handler
857 return values (Bug#10845).
858
3eb49e71
EZ
8592012-02-18 Eli Zaretskii <eliz@gnu.org>
860
861 * .gdbinit (pitx): Fix incorrect references to fields of the
862 iterator stack.
863
7b926f3f
CY
8642012-02-17 Chong Yidong <cyd@gnu.org>
865
866 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
867
11273115
PE
8682012-02-15 Paul Eggert <eggert@cs.ucla.edu>
869
870 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
871 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
872
c3a70e2b
CY
8732012-02-15 Chong Yidong <cyd@gnu.org>
874
875 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
876 marked as special. Also, starting docstrings with * is obsolete.
877
0ca43699
AS
8782012-02-13 Andreas Schwab <schwab@linux-m68k.org>
879
880 * gnutls.c (emacs_gnutls_write): Fix last change.
881
2e8f3c56
LI
8822012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
883
884 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
885 send_process.
886
af70074f
SM
8872012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
888
889 * keymap.c (Fsingle_key_description): Handle char ranges.
890
95986d52
CY
8912012-02-12 Chong Yidong <cyd@gnu.org>
892
afd83bd1
CY
893 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
894 as that creates a dangerous corner case.
895
95986d52
CY
896 * window.c (Fdelete_window_internal): Invalidate the mouse
897 highlight (Bug#9904).
898
bd7da63e
GM
8992012-02-12 Glenn Morris <rgm@gnu.org>
900
901 * xselect.c (Fx_own_selection_internal)
902 (Fx_get_selection_internal, Fx_disown_selection_internal)
903 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
904 * nsselect.m (Fx_own_selection_internal)
905 (Fx_disown_selection_internal, Fx_selection_exists_p)
906 (Fx_selection_owner_p, Fx_get_selection_internal):
907 Sync docs and argument specs with the xselect.c versions.
908
77abcbc2
LI
9092012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
910
911 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
912
90b671e2
EZ
9132012-02-11 Eli Zaretskii <eliz@gnu.org>
914
1c0ca0b7
EZ
915 * w32select.c (Fx_selection_exists_p): Sync doc string and
916 argument list with xselect.c. (Bug#10783)
917
918 * w16select.c (Fx_selection_exists_p): Sync doc string and
919 argument list with xselect.c. (Bug#10783)
90b671e2 920
49241268
GM
9212012-02-10 Glenn Morris <rgm@gnu.org>
922
923 * fns.c (Fsecure_hash): Doc fix.
924
f998bbe7 9252012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
926
927 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
928
0992bd9c
CY
9292012-02-07 Chong Yidong <cyd@gnu.org>
930
931 * buffer.c (Fbuffer_local_variables)
932 (buffer_lisp_local_variables): Handle unbound vars correctly;
933 don't let Qunbound leak into Lisp.
934
af008560
GM
9352012-02-07 Glenn Morris <rgm@gnu.org>
936
dd605cc4
GM
937 * image.c (Fimagemagick_types): Doc fix.
938
af008560
GM
939 * image.c (imagemagick-render-type): Change it from a lisp object
940 to an integer. Move the doc here from the lisp manual.
941 Treat all values not equal to 0 the same.
942
1449fa1d
CY
9432012-02-06 Chong Yidong <cyd@gnu.org>
944
945 * doc.c (store_function_docstring): Avoid applying docstring of
946 alias to base function (Bug#2603).
947
3723ec07
AS
9482012-02-04 Andreas Schwab <schwab@linux-m68k.org>
949
950 * .gdbinit (pp1, pv1): Remove redundant defines.
951 (pr): Use pp.
952
79c1cc1e
CY
9532012-02-04 Chong Yidong <cyd@gnu.org>
954
955 * nsterm.m: Declare a global (Bug#10694).
956
d7f29f8e
EZ
9572012-02-04 Eli Zaretskii <eliz@gnu.org>
958
cae07000
SM
959 * w32.c (get_emacs_configuration_options):
960 Include --enable-checking, if specified, in the return value.
d7f29f8e 961
3b95a6f9
MR
9622012-02-04 Martin Rudalics <rudalics@gmx.at>
963
964 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
965 after rounding frame sizes. (Bug#9723)
966
d6fa96a6
EZ
9672012-02-04 Eli Zaretskii <eliz@gnu.org>
968
969 * keyboard.c (adjust_point_for_property): Don't position point
970 before BEGV. (Bug#10696)
971
df0b2940
PE
9722012-02-03 Paul Eggert <eggert@cs.ucla.edu>
973
974 Handle overflow when computing char display width (Bug#9496).
975 * character.c (char_width): Return EMACS_INT, not int.
976 (char_width, c_string_width): Check for overflow when
977 computing the width; this is possible now that individual
978 characters can have unbounded width. Problem introduced
979 by merge from Emacs 23 on 2012-01-19.
980
6bee44d6
MA
9812012-02-02 Michael Albinus <michael.albinus@gmx.de>
982
983 * dbusbind.c (Fdbus_register_method): Mention the return value
984 :ignore in the docstring.
985
44f92739
GM
9862012-02-02 Glenn Morris <rgm@gnu.org>
987
1b9f60cc
GM
988 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
989
44f92739
GM
990 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
991 Unconditionally set to t. (Bug#10673)
992 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
993 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
994 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
995
c5d3843c
KH
9962012-02-02 Kenichi Handa <handa@m17n.org>
997
998 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
999 0, do not call append_composite_glyph.
1000
159462d4 10012012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
1002
1003 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
1004 NULL (Bug#6988).
1005 (x_produce_glyphs): If the component of a composition is a null
1006 string, set it->pixel_width to 1 to avoid zero-width glyph.
1007
78cef877
EZ
10082012-02-01 Eli Zaretskii <eliz@gnu.org>
1009
1010 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
1011 first 2 arguments are identical. This makes inserting large
1012 output from a subprocess an order of magnitude faster on
1013 MS-Windows, where all sbrk'ed memory is always contiguous.
1014
97897668
GM
10152012-01-31 Glenn Morris <rgm@gnu.org>
1016
1017 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 1018 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
1019 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
1020
31fd3586
GM
10212012-01-29 Glenn Morris <rgm@gnu.org>
1022
1023 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
1024
0e24a8b2
CY
10252012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
1026
1027 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
1028
cc0adcb0
CY
10292012-01-28 Chong Yidong <cyd@gnu.org>
1030
1031 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
1032
acc28cb9
CY
10332012-01-26 Chong Yidong <cyd@gnu.org>
1034
9c69cfb7
CY
1035 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
1036
acc28cb9
CY
1037 * search.c (Fsearch_forward, Fsearch_backward): Document negative
1038 repeat counts (Bug#10507).
1039
48da7392
GM
10402012-01-26 Glenn Morris <rgm@gnu.org>
1041
1042 * lread.c (syms_of_lread): Doc fix.
1043
14af5f7f
CY
10442012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
1045
1046 * coding.c (encode_designation_at_bol): Change return value to
1047 EMACS_INT.
1048
0b21c100
CY
10492012-01-25 Chong Yidong <cyd@gnu.org>
1050
1051 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
1052
3c2907f7
CY
10532012-01-21 Chong Yidong <cyd@gnu.org>
1054
1055 * floatfns.c (Fcopysign): Make the second argument non-optional,
1056 since nil is not allowed anyway.
1057
959ad23f
AS
10582012-01-21 Andreas Schwab <schwab@linux-m68k.org>
1059
1060 * process.c (read_process_output): Use p instead of XPROCESS (proc).
1061 (send_process): Likewise.
1062
34a02f46
MR
10632012-01-19 Martin Rudalics <rudalics@gmx.at>
1064
1065 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
1066 (Vwindow_persistent_parameters): Do not use Qstate.
1067 Rewrite doc-strings.
34a02f46 1068
1259009a 10692012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
1070
1071 * character.c (char_width): New function.
70d4fdf6
GM
1072 (Fchar_width, c_string_width, lisp_string_width):
1073 Use char_width (Bug#9496).
25ed9e61 1074
6a6ee00d
MR
10752012-01-16 Martin Rudalics <rudalics@gmx.at>
1076
1077 * window.c (Vwindow_persistent_parameters): New variable.
1078 (Fset_window_configuration, save_window_save): Handle persistent
1079 window parameters.
1080
c85efaf7
EZ
10812012-01-14 Eli Zaretskii <eliz@gnu.org>
1082
1083 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1084 thrashing the stack of the thread. (Bug#9087)
1085
5944709e
PE
10862012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1087
1088 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1089
e71f5d99
EZ
10902012-01-11 Eli Zaretskii <eliz@gnu.org>
1091
1092 * xdisp.c (rows_from_pos_range): Handle the case where the
1093 highlight ends on a newline. (Bug#10464)
1094 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1095 he end column for display of highlight that ends on a newline
1096 before a R2L line.
1097
ce316182
GM
10982012-01-11 Glenn Morris <rgm@gnu.org>
1099
1100 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1101 from load-path also when installation-directory is nil. (Bug#10208)
1102
5b43da69
GM
11032012-01-10 Glenn Morris <rgm@gnu.org>
1104
74cc8ff9
GM
1105 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1106
7d8d6e4e
GM
1107 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1108 Update template values to be closer to their typical values these days.
5b43da69 1109
a0db8d43
EZ
11102012-01-09 Eli Zaretskii <eliz@gnu.org>
1111
1112 * xdisp.c (rows_from_pos_range): Accept additional argument
1113 DISP_STRING, and accept any glyph in a row whose object is that
1114 string as eligible for mouse highlight. Fixes mouse highlight of
1115 display strings from overlays. (Bug#10464)
1116
9a0115ab 11172012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 1118
b9110d6a 1119 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
1120 * fileio.c (auto_saving_dir_umask): New static var.
1121 (Fmake_directory_internal): Use it.
1122 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1123 creating the directory. The old code temporarily assigns
1124 too-generous permissions to the directory.
1125 (do_auto_save_eh): Clear it.
b9110d6a 1126 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
1127 that the var is always cleared.
1128
6c1bd3f3
EZ
11292012-01-07 Eli Zaretskii <eliz@gnu.org>
1130
1131 * search.c (scan_buffer): Pass character positions to
1132 know_region_cache, not byte positions. (Bug#6540)
1133
069d2b50
L
11342012-01-07 LynX <_LynX@bk.ru> (tiny change)
1135
1136 * w32.c (sys_rename): Report EXDEV when rename of a directory
1137 fails because the target is on another logical disk. (Bug#10284)
1138
75bf0d33
DB
11392012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1140
1141 * xterm.c (x_embed_request_focus): New function.
1142
1143 * xterm.h: Add prototype.
1144
1145 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1146
1c6e5a32
GM
11472012-01-05 Glenn Morris <rgm@gnu.org>
1148
1149 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1150
651e947e
EZ
11512012-01-01 Eli Zaretskii <eliz@gnu.org>
1152
1153 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1154 Load gnutls_transport_set_lowat only if GnuTLS version is below
1155 2.11.1.
1156 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1157 GnuTLS versions below 2.11.1.
1158
3778cdd8
AL
11592011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1160
1161 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1162 to the doc string advising against its use for altering the way
1163 windows are scrolled.
1164
0e5317f7
KH
11652011-12-28 Kenichi Handa <handa@m17n.org>
1166
1167 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1168 coding-system ASCII compatible only when it does not produce BOM
1169 on encoding (Bug#10383).
1170
93d5ca1f
JD
11712011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1172
1173 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1174 can scroll.
1175 (create_and_show_popup_menu): Always use menu_position_func for
1176 Gtk3 (Bug#10361).
1177
ca22b785
AS
11782011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1179
1180 * callint.c (Fcall_interactively): Don't truncate prompt string.
1181
d048e1e6
EZ
11822011-12-23 Eli Zaretskii <eliz@gnu.org>
1183
1184 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1185 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 1186 resumed from there (after widening). (Bug#10360)
d048e1e6 1187
5ccaba1f
JD
11882011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1189
1190 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1191
204ee57f
JD
11922011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1193
b81d40f0
JB
1194 * nsterm.m (x_free_frame_resources):
1195 Release f->output_data.ns->miniimage.
204ee57f
JD
1196 (ns_index_color): Fix indentation. Do not retain
1197 color_table->colors[i].
1198
1199 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1200 before returning.
1201
1202 * nsfns.m (x_set_background_color): Assign return value from
1203 ns_index_color to face-background instead of NSColor*.
1204 (ns_implicitly_set_icon_type): Fix indentation.
1205 Change assignment in for loop to comparison.
1206
1207 * emacs.c (ns_pool): New variable.
1208 (main): Assign ns_pool.
1209 (Fkill_emacs): Call ns_release_autorelease_pool.
1210
1211 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1212 autorelease fdesc, release fdAttrs and tdict.
1213 (ns_get_covering_families): Release charset.
1214 (ns_findfonts): Release NSFontDescriptor created with new.
1215 (ns_uni_to_glyphs): Fix indentation.
1216 (setString): Release attrStr before assigning new value.
1217
c803b2b7
JD
12182011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1219
678f4426
JD
1220 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1221 and NS_IMPL_COCOA.
1222 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1223 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1224
cd394be1 12252011-12-18 David Reitter <reitter@cmu.edu>
678f4426 1226
5fecd5fc
JD
1227 * nsterm.m (ns_term_init): Subscribe for notifications
1228 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1229 to method trackingNotification in EmacsMenu.
1230
1231 * nsmenu.m (trackingMenu): New variable.
3771cb17 1232 (trackingNotification): New method (from Aquamacs).
5fecd5fc 1233 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 1234 from Aquamacs (Bug#7030).
678f4426
JD
1235
12362011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 1237
c803b2b7
JD
1238 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1239 (symbol_to_nsstring): Fix indentation.
1240 (ns_symbol_to_pb): New function.
cae07000
SM
1241 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1242 (Fns_rotate_cut_buffers_internal): Remove.
1243 (Fns_store_selection_internal): Rename from
c803b2b7
JD
1244 Fns_store_cut_buffer_internal.
1245 (ns_get_foreign_selection, Fx_own_selection_internal)
1246 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
1247 (Fns_get_selection_internal, Fns_store_selection_internal):
1248 Use ns_symbol_to_pb and check if return value is nil.
1249 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1250 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
1251 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1252 renamed to Sns_store_selection_internal.
1253 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1254 and remove this function.
1255 (ns_handle_selection_clear): Remove, never used.
1256 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1257 here.
1258
e1b01a3a
KB
12592011-12-17 Ken Brown <kbrown@cornell.edu>
1260
1261 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1262 GID is unknown (Bug#10257).
1263
2adb6e85
PE
12642011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1265
1266 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1267 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1268 which caused a build failure on GNU/Linux IA-64. This problem was
1269 introduced by my 2011-10-07 patch.
1270
d1d7b339
JL
12712011-12-15 Juri Linkov <juri@jurta.org>
1272
1273 * image.c (imagemagick_error): New function. (Bug#10112)
1274 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1275 Use `imagemagick_error' where ImageMagick functions return
1276 `MagickFalse'.
1277 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1278 proper order.
1279
100d5755
KH
12802011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1281
1282 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1283 fill background (Bug#8992).
1284
454592a6
MR
12852011-12-13 Martin Rudalics <rudalics@gmx.at>
1286
1287 * window.c (Vwindow_combination_resize)
1288 (Vwindow_combination_limit): Use t instead of non-nil in
1289 doc-strings.
61d4b438
MR
1290 (Vrecenter_redisplay): Add first sentence of doc-string on
1291 separate line.
53524d93 1292 (Frecenter): Fix doc-string typo.
454592a6 1293
3633e3aa
KH
12942011-12-11 Kenichi Handa <handa@m17n.org>
1295
1296 * coding.c (Funencodable_char_position): Pay attention to the
1297 buffer text relocation (Bug#9389).
1298
7b9d523a
JD
12992011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1300
1301 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1302 gtk_init (Bug#10100).
1303
b73189c6
EZ
13042011-12-10 Eli Zaretskii <eliz@gnu.org>
1305
1306 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1307 IT->string is nil. (Bug#10263)
1308
f7dfe5d6
JD
13092011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1310
83faebb4
JD
1311 * nsterm.h (x_free_frame_resources): Declare.
1312
f7dfe5d6
JD
1313 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1314 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1315
1316 * nsterm.h (ns_get_defaults_value): Declare.
1317
1318 * nsterm.m (ns_default): Call ns_get_defaults_value.
1319
7cd4e72c
EZ
13202011-12-09 Eli Zaretskii <eliz@gnu.org>
1321
1322 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1323 (Bug#10170)
1324
b34d7317
YM
13252011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1326
1327 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1328 that where the value of an _OBJC_* symbol points to is in the .bss
1329 section (Bug#10240).
1330
76470ad1
KH
13312011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1332
1333 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 1334 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 1335
745fff94
KH
13362011-12-08 Kenichi Handa <handa@m17n.org>
1337
1338 * ftfont.c (get_adstyle_property): Fix previous change
1339 (Bug#10233).
1340
6e44397c
JB
13412011-12-07 Juanma Barranquero <lekktu@gmail.com>
1342
1343 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1344 dirs from the default value of EMACSLOADPATH (bug#10208).
1345
7efa6272
GM
13462011-12-07 Glenn Morris <rgm@gnu.org>
1347
1348 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1349 installation and source directories as well. (Bug#10208)
1350
f6fc4d87
CY
13512011-12-06 Chong Yidong <cyd@gnu.org>
1352
1353 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1354
2bf26180
GM
13552011-12-06 Glenn Morris <rgm@gnu.org>
1356
1357 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1358 as an error, not just -1. (Bug#10217)
1359
3a6ad4f0
CY
13602011-12-05 Chong Yidong <cyd@gnu.org>
1361
1362 * keyboard.c (process_special_events): New function.
1363 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1364
75a3b399
PE
13652011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1366
1367 * coding.c (encode_designation_at_bol): Don't use uninitialized
1368 local variable (Bug#9318).
1369
c3c9e25e
KH
13702011-12-05 Kenichi Handa <handa@m17n.org>
1371
1372 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1373 return Qnil (Bug#8046, Bug#10193).
1374
5eb05ea3
KH
13752011-12-05 Kenichi Handa <handa@m17n.org>
1376
1377 * coding.c (encode_designation_at_bol): New args charbuf_end and
1378 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
1379 (coding_set_source): Return how many bytes coding->source was
1380 relocated.
1381 (coding_set_destination): Return how many bytes
1382 coding->destination was relocated.
1383 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 1384 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
1385
13862011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1387
1388 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1389 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1390 macro (Bug#9318).
1391
13922011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1393
1394 The following changes are to fix Bug#9318.
1395
a79703f5 1396 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
1397 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1398 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 1399 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 1400
7dbda6df
JB
14012011-12-05 Juanma Barranquero <lekktu@gmail.com>
1402
1403 * lisp.h (process_quit_flag): Fix external declaration.
1404
6d5eb5b0
SM
14052011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1406
1407 Don't macro-inline non-performance-critical code.
1408 * eval.c (process_quit_flag): New function.
1409 * lisp.h (QUIT): Use it.
1410
a0c3fad0
JD
14112011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1412
1413 * nsfns.m (get_geometry_from_preferences): New function.
1414 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1415
6c07aac2
AS
14162011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1417
1418 * emacs.c (Qkill_emacs): Define.
1419 (syms_of_emacs): Initialize it.
1420 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1421 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1422 (quit_throw_to_read_char): Add parameter `from_signal'.
1423 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1424 * lisp.h (QUIT): Call Fkill_emacs if requested.
1425
c052ead4
JD
14262011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1427
1428 * widget.c (update_wm_hints): Return if wmshell is null.
1429 (widget_update_wm_size_hints): New function.
1430
1431 * widget.h (widget_update_wm_size_hints): Declare.
1432
1433 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1434 widget_update_wm_size_hints (Bug#10104).
1435
9e49252b
EZ
14362011-12-03 Eli Zaretskii <eliz@gnu.org>
1437
1438 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1439 before a newline, prepare the bidi iterator for consuming the
1440 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1441 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1442
02b16839
JL
14432011-12-02 Juri Linkov <juri@jurta.org>
1444
1445 * search.c (Fword_search_regexp): New Lisp function created from
1446 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1447 (Fword_search_backward, Fword_search_forward)
1448 (Fword_search_backward_lax, Fword_search_forward_lax):
1449 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1450 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1451
0068070e
SM
14522011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1453
1454 * fileio.c (Finsert_file_contents): Move after-change-function call
1455 to before the "handled:" label, since all "goto handled" appear in
1456 cases where the *-change-functions have already been properly called
1457 (bug#10117).
1458
3360a3fc
AS
14592011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1460
1461 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1462 waiting for input. (Bug#10169)
1463
73d6c093
EZ
14642011-11-30 Eli Zaretskii <eliz@gnu.org>
1465
1466 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1467 verifies glyph row's hash code--we have just reallocated the
1468 glyphs, so their contents can be complete garbage. (Bug#10164)
1469
febe6bea
JB
14702011-11-30 Juanma Barranquero <lekktu@gmail.com>
1471
1472 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1473
801a4313
EZ
14742011-11-30 Eli Zaretskii <eliz@gnu.org>
1475
1476 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1477 attributes are tested _before_ calling verify_row_hash, to protect
1478 against GCC re-ordering of the tests. (Bug#10164)
1479
2b56b87e
JD
14802011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1481
1482 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1483
1484 * xterm.c (handle_one_xevent): Only set async_visible and friends
1485 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1486 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1487 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1488
dbf31225
PE
14892011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1490
1491 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1492 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1493 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1494 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1495 All uses changed to use GCPRO1 etc.
1496 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1497 Revert to old implementation (i.e., before 2011-03-11).
1498
1305621b
YM
14992011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1500
1501 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1502 of scroll runs so as to avoid assigning disabled bogus rows and
1503 unnecessary graphics copy operations.
1504
8c9afb46
EZ
15052011-11-27 Eli Zaretskii <eliz@gnu.org>
1506
1507 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1508 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1509 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1510 (malloc, free, realloc, calloc): Redirect to e_* only when
1511 compiling Emacs.
1512
1513 * lisp.h (GCTYPEBITS): Move before first use.
1514 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1515 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1516 this macro definition.
1517
1518 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1519 _MSC_VER.
1520
54e9e3bf
JD
15212011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1522
6d5eb5b0
SM
1523 * gtkutil.c (xg_create_frame_widgets):
1524 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1525 present with Gtk+ 2.0.
1526
83aca1cb
PE
15272011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1528
1529 * fileio.c (Finsert_file_contents): Undo previous change; see
1530 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1531
5b76caa4
PE
15322011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1533
1534 Rename locals to avoid shadowing.
1535 * fileio.c (Finsert_file_contents):
1536 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1537 * process.c (wait_reading_process_output):
1538 Rename inner 'proc' to 'p' to avoid shadowing.
1539 Indent for consistency with usual Emacs style.
1540
8c535114
EZ
15412011-11-25 Eli Zaretskii <eliz@gnu.org>
1542
1543 * xdisp.c (redisplay_window): If cursor row is not fully visible
1544 after recentering, and scroll-conservatively is set to a large
1545 number, scroll window by a few more lines to make the cursor fully
1546 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1547 (start_display): Don't move to the next line if the display should
1548 start at a newline that is part of a display vector or an overlay
1549 string. (Bug#10119)
8c535114 1550
fa4fdb5c
JL
15512011-11-24 Juri Linkov <juri@jurta.org>
1552
1553 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1554 after the `MagickPingImage' call. (Bug#10112)
1555
90ec88df
CY
15562011-11-23 Chong Yidong <cyd@gnu.org>
1557
1558 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1559
56e2e794
MR
15602011-11-23 Martin Rudalics <rudalics@gmx.at>
1561
1562 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1563 making another buffer current. (Bug#10114)
1564
b6e64c41
GM
15652011-11-23 Glenn Morris <rgm@gnu.org>
1566
1567 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1568
6b21de18
CY
15692011-11-23 Chong Yidong <cyd@gnu.org>
1570
1571 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1572 using it (Bug#5984).
1573
b12cd789
EZ
15742011-11-22 Eli Zaretskii <eliz@gnu.org>
1575
1576 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1577 and header-lines, as they don't have one computed for them.
1578 (Bug#10098)
1579
1580 * .gdbinit (prow): Make displayed values more self-explaining.
1581 Add row's hash code.
1582
261b6fd4
LMI
15832011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1584
1585 * process.c (wait_reading_process_output): Fix asynchrounous
1586 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1587 (wait_reading_process_output): Add comment and URL.
261b6fd4 1588
e7cfd277
JD
15892011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1590
1591 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1592
a9b9b7f5
CY
15932011-11-21 Chong Yidong <cyd@gnu.org>
1594
1595 * window.c (Fnext_window, Fprevious_window): Doc fix.
1596
b0d15b4f
SM
15972011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1598
1599 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1600
fe7a3057
JB
16012011-11-20 Juanma Barranquero <lekktu@gmail.com>
1602
1603 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1604
d2999b1a
MR
16052011-11-20 Martin Rudalics <rudalics@gmx.at>
1606
1607 * window.c (Fset_window_combination_limit): Rename argument
1608 STATUS to LIMIT.
1609 (Vwindow_combination_limit): Remove "status" from doc-string.
1610
d5ff9cd0
AS
16112011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1612
1613 * m/ibms390.h: Remove.
1614 * m/ibms390x.h: Don't include "ibms390.h".
1615
a5bb9bd3
SM
16162011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1617
1618 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1619 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1620
cd1181db
JB
16212011-11-20 Juanma Barranquero <lekktu@gmail.com>
1622
1623 * casetab.c (Fset_case_table):
1624 * charset.c (Fcharset_after): Fix typos.
1625
615a3b8d 16262011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1627
17e845af
PE
1628 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1629 Otherwise, valgrind does not work on some platforms.
1630 Problem reported by Andreas Schwab in
6a0bf43d
PE
1631 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1632 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1633 is set, removing the need for VIRT_ADDRESS_VARIES.
1634 (PURE_P): Use a more-efficient implementation that needs just one
1635 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1636 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1637 to 4 (xorl, subq, cmpq, setbe).
1638 * alloc.c (pure): Always extern now, since that's the
1639 VIRT_ADDR_VARIES behavior.
1640 (PURE_POINTER_P): Use a single comparison, not two, for
1641 consistency with the new puresize.h.
1642 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1643 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1644 Remove VIRT_ADDR_VARIES no longer needed.
1645
f8fe6f96
EZ
16462011-11-19 Eli Zaretskii <eliz@gnu.org>
1647
1648 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1649 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1650 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1651 behave as if the cursor position were at the window margin.
1652
1653 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1654 and the cursor position is out of bounds, behave as if the cursor
1655 position were at the window margin. (Bug#10075)
1656
df05a53c
CY
16572011-11-18 Chong Yidong <cyd@gnu.org>
1658
1659 * window.c (Fwindow_combination_limit): Make first argument
1660 non-optional, since it is meaningless for live windows like the
1661 selected window.
1662
2071918e
DA
16632011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1664
1665 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1666
b50a28de
SM
16672011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1668
1669 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1670 (graft_intervals_into_buffer): Simplify.
1671
015137db
EZ
16722011-11-18 Eli Zaretskii <eliz@gnu.org>
1673
1674 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1675 hash values of the two rows.
1676 (copy_row_except_pointers): Preserve the used[] arrays and the
1677 hash values of the two rows. (Bug#10035)
68c95424 1678 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1679
1680 * xdisp.c (row_hash): New function, body extracted from
1681 compute_line_metrics.
1682 (compute_line_metrics): Call row_hash, instead of computing the
1683 hash code inline.
1684
1685 * dispnew.c (verify_row_hash): Call row_hash for computing the
1686 hash code of a row, instead of duplicating code from xdisp.c.
1687
1688 * dispextern.h (row_hash): Add prototype.
1689
a2addb04
TH
16902011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1691
1692 * frame.c (delete_frame): Don't delete the terminal when the last
1693 X frame is closed if emacs is built with GTK toolkit.
1694
df85d315
JB
16952011-11-17 Juanma Barranquero <lekktu@gmail.com>
1696
1697 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1698
a0c2d0ae
MR
16992011-11-17 Martin Rudalics <rudalics@gmx.at>
1700
1701 * window.c (Vwindow_splits): Rename to
1702 Vwindow_combination_resize. Suggested by Juri Linkov.
1703 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1704 of Vwindow_splits.
1705
58179cce
JB
17062011-11-16 Juanma Barranquero <lekktu@gmail.com>
1707
7877f373
JB
1708 * nsfns.m (Fns_font_name):
1709 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1710
b6f67890
MR
17112011-11-16 Martin Rudalics <rudalics@gmx.at>
1712
1713 * window.h (window): Rename slot "nest" to "combination_limit".
1714 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1715 (Fset_window_nest): Rename to Fset_window_combination_limit.
1716 (Vwindow_nest): Rename to Vwindow_combination_limit.
1717 (recombine_windows, make_parent_window, make_window)
1718 (Fsplit_window_internal, saved_window)
1719 (Fset_window_configuration, save_window_save): Rename all
1720 occurrences of window_nest to window_combination_limit.
1721
c7015153
JB
17222011-11-15 Juanma Barranquero <lekktu@gmail.com>
1723
1724 * image.c (imagemagick_load_image): Fix typo.
1725
322ad6ec
EZ
17262011-11-14 Eli Zaretskii <eliz@gnu.org>
1727
1728 * xdisp.c (display_line): Move the call to
1729 highlight_trailing_whitespace before the call to
1730 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1731 faces of all the glyphs to compute ROW's hash value.
1732 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1733
f067b8ec
JB
17342011-11-14 Juanma Barranquero <lekktu@gmail.com>
1735
1736 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1737 just return (bug#10044).
1738
1e5b2111
EZ
17392011-11-12 Eli Zaretskii <eliz@gnu.org>
1740
7ef3cbd5
EZ
1741 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1742 with user-defined heap size. Bump the default size of the temacs
1743 heap to 27MB, to avoid memory warning when running temacs.
1744 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1745
1e5b2111
EZ
1746 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1747 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1748 (verify_row_hash) [XASSERTS]: New function.
1749 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1750 that the hash value of glyph rows is correct.
1e5b2111 1751
89d61221
MR
17522011-11-12 Martin Rudalics <rudalics@gmx.at>
1753
1754 * window.h (window): Remove splits slot.
1755 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1756 (Fdelete_other_windows_internal, make_parent_window)
1757 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1758 (Fset_window_configuration, save_window_save): Don't deal with
1759 split status of windows.
1760 (saved_window): Remove splits slot.
1761 (Vwindow_splits): Rewrite doc-string.
1762
97f18cc8
JD
17632011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1764
1765 * xfns.c (unwind_create_frame):
1766 * nsfns.m (unwind_create_frame):
1767 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1768 Vframe_list (Bug#9999).
1769
22a648b4
DA
17702011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1771
0b381c7e 1772 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1773
659afede
KH
17742011-11-11 Kenichi Handa <handa@m17n.org>
1775
1776 * callproc.c (Fcall_process): Set the member dst_multibyte of
1777 process_coding.
1778
9ac0394b
KH
17792011-11-11 Johan Bockgård <bojohan@gnu.org>
1780
1781 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1782 avoid a crash (bug#9496).
1783
2fbdc249
CY
17842011-11-09 Chong Yidong <cyd@gnu.org>
1785
1786 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1787 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1788
ac6b1f81
PE
17892011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1790
1791 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1792
09db192c
PE
17932011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1794
1795 Avoid some portability problems by eschewing 'extern inline' functions.
1796 The trivial performance wins aren't worth the portability hassles; see
1797 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1798 et seq.
1799 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1800 (window_box_width, window_box_left, window_box_left_offset)
1801 (window_box_right, window_box_right_offset): Undo previous change,
1802 by removing the "extern"s.
1803 * intervals.c (adjust_intervals_for_insertion)
1804 (adjust_intervals_for_deletion): Undo previous change,
1805 making these static again.
1806 (offset_intervals, temp_set_point_both, temp_set_point)
1807 (copy_intervals_to_string): No longer inline.
1808 * xdisp.c (window_text_bottom_y, window_box_width)
1809 (window_box_height, window_box_left_offset)
1810 (window_box_right_offset, window_box_left, window_box_right)
1811 (window_box): No longer inline.
1812
105216ed
CY
18132011-11-08 Chong Yidong <cyd@gnu.org>
1814
1815 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1816 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1817 Signal an error if not a live window.
105216ed
CY
1818 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1819 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1820
ae9e237f
JB
18212011-11-07 Juanma Barranquero <lekktu@gmail.com>
1822
1823 * lisp.h (syms_of_abbrev): Remove declaration.
1824 Reported by CHENG Gao <chenggao@royau.me>.
1825
c7aa8333
EZ
18262011-11-07 Eli Zaretskii <eliz@gnu.org>
1827
1828 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1829 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1830 of temacs in GUI mode.
1831
be7f5545
MR
18322011-11-07 Martin Rudalics <rudalics@gmx.at>
1833
1834 * window.h: Declare delete_all_child_windows instead of
1835 delete_all_subwindows.
1836 * window.c (Fwindow_nest, Fset_window_nest)
1837 (Fset_window_new_total, Fset_window_new_normal)
1838 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1839 (delete_all_subwindows): Rename to delete_all_child_windows.
1840 (Fdelete_other_windows_internal, Fset_window_configuration):
1841 Call delete_all_child_windows instead of delete_all_subwindows.
1842 * frame.c (delete_frame): Call delete_all_child_windows instead
1843 of delete_all_subwindows.
1844
ca78dc43
PE
18452011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1846
1847 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1848 This is also needed for porting to any host where GC_MARK_STACK is
1849 not GC_MAKE_GCPROS_NOOPS.
1850 (which_symbols): Use it.
1851
a0241d01
KH
18522011-11-07 Kenichi Handa <handa@m17n.org>
1853
1854 * coding.c (coding_set_destination): Check coding->src_pos only
1855 when coding->src_object is a buffer (bug#9910).
1856
1857 * process.c (send_process): Set the member src_multibyte of coding
1858 to 0 (bug#9911) when sending a unibyte text.
1859
1860 * callproc.c (Fcall_process): Set the member src_multibyte of
1861 process_coding to 0 (bug#9912).
1862
a64bfdfa 18632011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1864
1865 * xmenu.c (cleanup_widget_value_tree): New function.
1866 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1867 calling free_menubar_widget_value_tree directly (Bug#9830).
1868
cb41b32a
PE
18692011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1870
1871 Fix some portability problems with 'inline'.
1872 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1873 (window_box_width, window_box_left, window_box_left_offset)
1874 (window_box_right, window_box_right_offset): Declare extern.
1875 Otherwise, these inline functions do not conform to C99 and
1876 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1877 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1878 * intervals.c (adjust_intervals_for_insertion)
1879 (adjust_intervals_for_deletion): Now extern, because otherwise the
1880 extern inline functions 'offset_intervals' couldn't refer to it.
1881 (static_offset_intervals): Remove.
1882 (offset_intervals): Rewrite using the old contents of
1883 static_offset_intervals. The old version didn't conform to C99
1884 because an extern inline function contained a reference to an
1885 identifier with static linkage.
1886
b7041366
AS
18872011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1888
1889 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1890 GC.
1891
88a37c4d
EZ
18922011-11-06 Eli Zaretskii <eliz@gnu.org>
1893
1894 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1895 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1896 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1897 return Qleft_to_right.
1898
49745b39
CY
18992011-11-06 Chong Yidong <cyd@gnu.org>
1900
1901 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1902 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1903 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1904 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1905 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1906 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1907 (Fwindow_vscroll): Doc fix.
1908 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1909 argument, since it makes no sense to pass a live window and for
1910 consistency with window-child.
1911
1f05cd82
CS
19122011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1913
1914 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1915 support MSVC.
1916
22610910
JR
19172011-11-05 Jason Rumney <jasonr@gnu.org>
1918
1919 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1920 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1921 fonts (Bug#6029).
1922 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1923 bitwise arithmetic preventing use of unicode-sip and non-truetype
1924 opentype fonts.
1925
a06776b2
EZ
19262011-11-05 Eli Zaretskii <eliz@gnu.org>
1927
3ad924ba
EZ
1928 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1929 "emacs"-only part.
1930
a06776b2
EZ
1931 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1932 initialization code to keep similarity to xfns.c after changes
1933 from 2011-11-05.
1934
c9e7db78
JD
19352011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1936
a97f8f3f
JD
1937 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1938 (unwind_create_frame): New function (Bug#9943).
1939 (Fx_create_frame): Restructure code to be more similar to the one in
1940 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1941 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1942 Move terminal->reference_count++ just before making the frame official
1943 (Bug#9943).
1944
1945 * nsterm.m (x_free_frame_resources): New function.
1946 (x_destroy_window): Move code to x_free_frame_resources.
1947
c9e7db78 1948 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1949 (Fx_create_frame, x_create_tip_frame):
1950 Move terminal->reference_count++ just before making the frame
75f1671a 1951 official. Move initialization of image_cache_refcount and
c9e7db78
JD
1952 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1953
a6fc3b5c
EZ
19542011-11-05 Eli Zaretskii <eliz@gnu.org>
1955
1956 Support MSVC build with newer versions of Visual Studio.
1957 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1958 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1959 nt/gmake.defs.
1960
1961 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1962 which are not supported by MSVC.
1963 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1964 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1965 bitfields.
1966 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1967 types in bitfields.
1968 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1969
1970 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1971
58179cce 19722011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1973
1974 Support MSVC build with newer versions of Visual Studio.
1975 * w32.c: Don't include w32api.h for MSVC.
1976 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1977
1978 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1979 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1980 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1981 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1982 e_* cousins.
1983 (alloca) [_MSC_VER]: Define to _alloca.
1984
1985 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1986
1987 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1988
a58c13ed
EZ
19892011-11-04 Eli Zaretskii <eliz@gnu.org>
1990
1991 * xdisp.c (note_mouse_highlight): If either of
1992 previous/next-single-property-change returns nil, treat that as
1993 the beginning or the end of the buffer. (Bug#9955)
1994
fe0b6370
JD
19952011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1996
a58c13ed 1997 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1998 label is not null (Bug#9951).
1999 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
2000 may be NULL.
2001
89bd5ee1
EZ
20022011-11-04 Eli Zaretskii <eliz@gnu.org>
2003
2004 * window.c (Fwindow_body_size): Mention in the doc string that the
2005 return value is in frame's canonical units. (Bug#9949)
2006
84c3edb9
EZ
20072011-11-03 Eli Zaretskii <eliz@gnu.org>
2008
4e2fb5c7
EZ
2009 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
2010
84c3edb9 2011 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 2012 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 2013 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 2014
bc17a887
EZ
20152011-11-01 Eli Zaretskii <eliz@gnu.org>
2016
2017 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
2018 Don't stop backward scan on the continuation glyph, even though
2019 its CHARPOS is positive.
6d5eb5b0
SM
2020 (mouse_face_from_buffer_pos, note_mouse_highlight):
2021 Rename cover_string to disp_string.
bc17a887 2022
4ee88440
MR
20232011-11-01 Martin Rudalics <rudalics@gmx.at>
2024
2025 * window.c (temp_output_buffer_show): Don't use
2026 Vtemp_buffer_show_specifiers.
2027 (Vtemp_buffer_show_specifiers): Remove unused variable.
2028
c2ff3c02
EZ
20292011-10-30 Eli Zaretskii <eliz@gnu.org>
2030
2031 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
2032 past the beginning of the current glyph matrix.
2033
58179cce 20342011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
2035
2036 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
2037 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
2038 HAVE_GTK3 (Bug#9869).
b77a6a7f 2039
3b574623
JD
2040 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
2041 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
2042
b77a6a7f
JD
2043 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
2044
2045 * xterm.c: Declare x_handle_net_wm_state to return int.
2046 (handle_one_xevent): Check if we are iconified but don't have
2047 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
2048 (get_current_wm_state): Return non-zero if not hidden,
2049 check for _NET_WM_STATE_HIDDEN (Bug#9893).
2050 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
2051 (x_handle_net_wm_state): Return what get_current_wm_state returns.
2052 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
2053
196e41e4
PE
20542011-10-29 Paul Eggert <eggert@cs.ucla.edu>
2055
2056 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
2057 so that this new function doesn't get optimized away by a
2058 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
2059
021f2e1a
AS
20602011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2061
2062 * frame.h (MOUSE_HL_INFO): Remove excess parens.
2063
8b058d44
EZ
20642011-10-29 Eli Zaretskii <eliz@gnu.org>
2065
2066 Fix the `xbytecode' command.
2067 * .gdbinit (xprintbytestr): New command.
b50a28de 2068 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
2069 (xbytecode): Print the byte-code string as well.
2070
4452fb80
EZ
20712011-10-29 Kim Storm <storm@cua.dk>
2072
8b058d44
EZ
2073 * alloc.c (which_symbols): New function.
2074
21b72067
AS
20752011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2076
2077 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2078 line. (Bug#9903)
2079
83ed7b5c
GM
20802011-10-29 Glenn Morris <rgm@gnu.org>
2081
2082 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2083 Not clear what it was for, and it causes various bugs. (Bug#9839)
2084
5a7a728b
EZ
20852011-10-28 Eli Zaretskii <eliz@gnu.org>
2086
2087 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2088 possible random value that matches one of those tested as
2089 condition to clear the mouse face.
2090
d3d0842f
CY
20912011-10-28 Chong Yidong <cyd@gnu.org>
2092
2093 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2094
31b39d13
DN
20952011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2096
2097 * window.c (make_window): Initialize phys_cursor_on_p.
2098
9aba6043
SM
20992011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2100
2101 * lisp.h (struct Lisp_Symbol): Update comments.
2102
c20992f4
JB
21032011-10-28 Juanma Barranquero <lekktu@gmail.com>
2104
2105 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2106
db4f02f2
EZ
21072011-10-28 Eli Zaretskii <eliz@gnu.org>
2108
2109 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2110 <oslsachem@gmail.com> for helping to debug this.
2111
2112 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2113 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2114 (g_b_init_get_glyph_outline_w): New static variables.
2115 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2116 (GetGlyphOutlineW_Proc): New typedefs.
2117 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
2118 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2119 New functions.
2120 (w32font_open_internal, compute_metrics):
2121 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
2122 instead of calling the "wide" APIs directly.
2123
2124 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2125
2126 * w32.h (syms_of_w32font): Add prototype.
2127
87e68db4
JB
21282011-10-27 Juanma Barranquero <lekktu@gmail.com>
2129
2130 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2131 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2132 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2133 (Fmove_to_window_line): Doc fix.
2134
435c1d67
CY
21352011-10-27 Chong Yidong <cyd@gnu.org>
2136
2137 * process.c (make_process): Set gnutls_state to NULL.
2138
2139 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2140 non-NULL, regardless of GNUTLS_INITSTAGE.
2141 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2142 an error. Set process slots as soon as we allocate them.
2143
2144 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2145
9c6c6f49
CY
21462011-10-27 Chong Yidong <cyd@gnu.org>
2147
9aba6043
SM
2148 * gnutls.c (emacs_gnutls_deinit): New function.
2149 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
2150 (Fgnutls_deinit, Fgnutls_boot): Use it.
2151
2152 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2153 (deactivate_process): Call emacs_gnutls_deinit.
2154
657d08d3
JB
21552011-10-27 Juanma Barranquero <lekktu@gmail.com>
2156
2157 * image.c (x_create_x_image_and_pixmap):
2158 * w32.c (sys_rename, w32_delayed_load):
2159 * w32font.c (fill_in_logfont):
2160 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2161
5430d399
JB
21622011-10-26 Juanma Barranquero <lekktu@gmail.com>
2163
2164 * w32fns.c (w32_default_color_map): New function,
2165 extracted from Fw32_default_color_map.
a7ef684b 2166 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 2167
fe0055fa
PE
21682011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2169
2170 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2171
e6346438
SM
21722011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2173
2174 * keyboard.c (test_undefined): New function (bug#9751).
2175 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2176
e112cc37
ET
21772011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2178
2179 * sysdep.c (init_sys_modes): Fix the check for the controlling
2180 terminal (Bug#6649).
2181
7b5d6677
EZ
21822011-10-20 Eli Zaretskii <eliz@gnu.org>
2183
2184 * dispextern.h (struct bidi_it): New member next_en_type.
2185
2186 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2187 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2188 current character, check also for next_en_type being WEAK_EN.
2189 (bidi_resolve_weak): Don't enter the expensive loop if the current
2190 position is before next_en_pos. Record the bidi type of the first
2191 non-ET, non-BN character we find, in addition to its position.
2192 (bidi_level_of_next_char): Invalidate next_en_type when
2193 next_en_pos is over-stepped.
2194
7da0b018
PE
21952011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2196
2197 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2198 * editfns.c: Rewrite current-time-zone so that it invokes
2199 the equivalent of (format-time-string "%Z") to get the time zone name.
2200 This fixes a bug when the time zone name contains characters that
2201 need converting from the system time locale to Emacs internal format.
2202 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2203 that patch fixed format-time-string to do the conversion, but
2204 I forgot to fix current-time-zone.
2205 (format_time_string): New function, containing most of
2206 what Fformat_time_string used to contain.
2207 (Fformat_time_string): Rewrite in terms of format_time_string.
2208 This doesn't change this function's behavior.
2209 (current-time-zone): Rewrite to use format_time_string.
2210 This fixes the bug reported by Michael Schierl in
2211 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2212 Jason Rumney's 2007-06-07 change worked around this bug, but
2213 didn't fix it.
2214 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2215
8547b010
EZ
22162011-10-19 Eli Zaretskii <eliz@gnu.org>
2217
2218 * xdisp.c (start_display): If the character at POS is displayed
2219 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
2220 (try_window_reusing_current_matrix): If a line ends in a display
2221 vector or the next line starts in a display vector, continue
2222 redrawing the window even though the character position of
2223 start_row was reached.
8547b010
EZ
2224 (Bug#9771, part 2)
2225
4e948d15
CY
22262011-10-18 Chong Yidong <cyd@gnu.org>
2227
2228 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2229 with nobreak-char-display too.
2230
4787455f
EZ
22312011-10-18 Eli Zaretskii <eliz@gnu.org>
2232
2233 Fix part 3 of bug#9771.
2234 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2235 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2236 non-neutral characters if the current character is a paragraph
2237 separator (a.k.a. Newline). This avoids running the same
2238 expensive loop twice, once when we consume the preceding newline
2239 and the other time when the line actually needs to be displayed.
2240 Avoid the loop when we see neutrals on the base embedding level
2241 following a character whose directionality is the same as the
2242 paragraph's. This avoids running the expensive loop when a line
2243 ends in a long sequence of neutrals, like control characters.
2244 Add assertion against STRONG_AL type. Slightly rearrange code
2245 that determines the type of a neutral given the first non-neutral
2246 that follows it.
2247 (bidi_level_of_next_char): Set next_en_pos to zero when
2248 invalidating its info.
2249
2c91f553
EZ
22502011-10-17 Eli Zaretskii <eliz@gnu.org>
2251
2252 * xdisp.c (push_display_prop): Determine whether to record string
2253 or buffer position by IT->string, not by IT->method. Allow
2254 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
2255 (move_it_vertically_backward): Don't look for character position
2256 immediately after the newline when in a continuation line.
2257 (Bug#9771, part 1)
2c91f553 2258
c7b08b0d
MR
22592011-10-15 Martin Rudalics <rudalics@gmx.at>
2260
2261 * window.c (coordinates_in_window): Rewrite and delabelize
2262 vertical border check. (Bug#5357) (Bug#9618)
2263
6b02f655
SM
22642011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2265
2266 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2267 errors in XSetWindowBorder (bug#9310).
2268
81d40c92
DA
22692011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2270
2271 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2272 avoid crash when xmalloc overrun checking is enabled.
2273
d4172c3b
EZ
22742011-10-13 Eli Zaretskii <eliz@gnu.org>
2275
2276 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2277 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2278 cursor motion with <left> and <right> arrow keys.
2279
2280 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2281 some callers set that themselves.
2282
b00eea75
EZ
22832011-10-12 Eli Zaretskii <eliz@gnu.org>
2284
2285 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2286 display string and the previous row comes from the same string and
2287 is empty. (Bug#9739) (Bug#9738)
2288
8fe012c4
SM
22892011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2290
2291 * doc.c (get_doc_string): Encode file name (bug#9735).
2292
0074aef2
EZ
22932011-10-12 Eli Zaretskii <eliz@gnu.org>
2294
79beb178
EZ
2295 * bidi.c (bidi_level_of_next_char):
2296 * xdisp.c (get_visually_first_element): Remove old incorrect
2297 comments regarding the Unicode Line Separator character.
2298
0074aef2
EZ
2299 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2300
6e4b3fbe
DA
23012011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2302
2303 * alloc.c (Fgc_status): Do not access beyond zombies array
2304 boundary if nzombies > MAX_ZOMBIES.
2305 * alloc.c (dump_zombies): Add missing format specifier.
2306
0324f3af
PE
23072011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2308
b5525cac
PE
2309 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2310 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2311
0324f3af
PE
2312 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2313 Some packages use them to denote characters with modifiers.
2314
e9b5f888
AS
23152011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2316
2317 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2318 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2319 matching a pp-number. Rename parameter var to var1.
2320
127827c0
SM
23212011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2322
2323 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2324
c8fd3bd0
GM
23252011-10-08 Glenn Morris <rgm@gnu.org>
2326
2327 * callint.c (Fcall_interactively): Give a more explicit error for the
2328 'c' case with a non-character input. (Bug#8479)
2329
352ec8ff
EZ
23302011-10-08 Eli Zaretskii <eliz@gnu.org>
2331
03669ccb
EZ
2332 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2333 lines.
7061c986
EZ
2334 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2335 lines that are hscrolled on the left.
03669ccb 2336
352ec8ff
EZ
2337 * dispnew.c (buffer_posn_from_coords): Account for a possible
2338 presence of header-line. (Bug#4426)
2339
a66cfb1c
SM
23402011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2341
6b02f655
SM
2342 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2343 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 2344
7c5ee88e
PE
23452011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2346
2347 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2348 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2349 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2350 this makes Emacs dump core during garbage collection on rare
2351 occasions. sizeof is obviously inferior to offsetof here, so
2352 stick with offsetof.
2353 (GC_POINTER_ALIGNMENT): New macro.
2354 (mark_memory): Omit 3rd (offset) arg; caller changed.
2355 Don't assume EMACS_INT alignment is the same as pointer alignment.
2356
df1bbe5b
SM
23572011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2358
2359 * keyboard.c (read_key_sequence_remapped): New var.
2360 (read_key_sequence): Compute remapping in the right buffer.
2361 (command_loop_1): Use read_key_sequence's remapping directly.
2362
51553db6
SM
23632011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2364
32c1fffd
SM
2365 * dired.c (file_name_completion): Don't expand file name.
2366 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2367 before checking file name handler.
2368
51553db6
SM
2369 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2370 they've been requested explicitly (bug#9591).
2371
b6bd1599 23722011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
2373
2374 * keymap.c (Fsingle_key_description): Use make_specified_string
2375 instead of build_string to build string from push_key_description.
2376 (Bug#5193)
2377
f701dc2a
PE
23782011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2379
4222c55d
PE
2380 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2381 This fixes a Y2038 bug on 64-bit hosts.
2382 * buffer.c (reset_buffer):
2383 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2384 (Fclear_buffer_auto_save_failure):
2385 Use 0, not -1, to represent an unset failure time, since time_t
2386 might not be signed.
2387
f701dc2a
PE
2388 Remove dependency on glibc malloc internals.
2389 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2390 Move back here from lisp.h, but with their new implementations.
2391 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2392 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2393 * charset.c (charset_table_init): New static var.
2394 (syms_of_charset): Use it instead of xmalloc. This removes a
2395 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2396 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2397 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2398 Move back to alloc.c.
2399 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2400 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2401
9ceebf39
JD
24022011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2403
2404 * nsterm.m (windowDidResize): Call x_set_window_size only when
2405 ns_in_resize is true. Otherwise set pixelwidth/height and
2406 call change_frame_size (Bug#9628).
2407
cb993c58
PE
24082011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2409
3930c88b
PE
2410 Port --enable-checking=all to Fedora 14 x86-64.
2411 * charset.c (syms_of_charset): Also account for glibc malloc's
2412 internal overhead when calculating the initial malloc maximum.
2413
cb993c58
PE
2414 Port --enable-checking=all to Fedora 14 x86.
2415 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2416 Move to lisp.h.
2417 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2418 (overrun_check_realloc, overrun_check_free):
2419 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2420 That way, xmalloc returns a properly-aligned pointer even if
2421 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2422 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2423 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2424 into account when calculating the initial malloc maximum.
2425 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2426 Move here from alloc.c, so that charset.c can use it too.
2427 Properly align; the old code wasn't right for common 32-bit hosts
2428 when configured with --enable-checking=all.
2429 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2430 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2431
31bed486
EZ
24322011-09-29 Eli Zaretskii <eliz@gnu.org>
2433
04c70788 2434 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2435 use EDOM.
2436
fbcaa2f3
EZ
24372011-09-28 Eli Zaretskii <eliz@gnu.org>
2438
2439 * xdisp.c (compute_display_string_end): If there's no display
2440 string at CHARPOS, return -1.
2441
2442 * bidi.c (bidi_fetch_char): When compute_display_string_end
2443 returns a negative value, treat the character as a normal
2444 character not covered by a display string. (Bug#9624)
2445
a239d4e9
JB
24462011-09-28 Juanma Barranquero <lekktu@gmail.com>
2447
2448 * lread.c (Fread_from_string): Fix typo in docstring.
2449
88652fd5
EZ
24502011-09-27 Eli Zaretskii <eliz@gnu.org>
2451
2452 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2453 newline, reseat the iterator instead of bidi-iterating there one
2454 character at a time. (Bug#9610)
32c1fffd
SM
2455 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2456 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2457
ed497dd4
AS
24582011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2459
2460 * lread.c (readevalloop): Use correct code for NBSP.
2461 (read1): Likewise. (Bug#9608)
2462
b2bf61aa
MA
24632011-09-25 Michael Albinus <michael.albinus@gmx.de>
2464
2465 * dbusbind.c (Fdbus_register_signal): When service is not
2466 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2467
32bbb17c
GM
24682011-09-25 Glenn Morris <rgm@gnu.org>
2469
2470 * buffer.c (truncate-lines): Doc fix.
2471
94e0933e
CY
24722011-09-24 Chong Yidong <cyd@stupidchicken.com>
2473
2474 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2475 (Fset_window_next_buffers): Doc fix.
2476
cddde921
GM
24772011-09-24 Glenn Morris <rgm@gnu.org>
2478
2479 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2480
1260aef1
PE
24812011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2482
25b4bfa0
PE
2483 Fix minor problems found by static checking.
2484 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2485 * indent.c (Fvertical_motion): Fix == vs = typo.
2486
e3cbd34b
EZ
24872011-09-24 Eli Zaretskii <eliz@gnu.org>
2488
a66cfb1c
SM
2489 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2490 Default value is now t. Doc fix.
6bf7006f 2491
e3cbd34b 2492 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2493 logic when moving up, not only when moving down. Fix the
e3cbd34b 2494 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2495 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2496
2497 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2498 CHARPOS is covered by a display string which includes newlines.
2499 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2500 is covered by a display string with embedded newlines.
2501
a3de0cbd
MA
25022011-09-24 Michael Albinus <michael.albinus@gmx.de>
2503
2504 * dbusbind.c (Fdbus_register_signal): Add match rule to
2505 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2506 (Fdbus_register_method, Vdbus_registered_objects_table):
2507 Fix docstring.
a3de0cbd 2508
b260039d
JM
25092011-09-24 Jim Meyering <meyering@redhat.com>
2510
32c1fffd 2511 do not ignore write error for any output size
b260039d
JM
2512 The previous change was incomplete.
2513 While it makes emacs --batch detect the vast majority of stdout
2514 write failures, errors were still ignored whenever the output size is
2515 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2516 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2517 && echo FAIL: ignored write error
2518 FAIL: ignored write error
2519 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2520 && echo FAIL: ignored write error
2521 FAIL: ignored write error
2522 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2523
8eca8a7c
AS
25242011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2525
2526 * emacs.c (Fkill_emacs): In noninteractive mode exit
2527 non-successfully if a write error occurred on stdout. (Bug#9574)
2528
3341db62
EZ
25292011-09-21 Eli Zaretskii <eliz@gnu.org>
2530
2531 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2532 the xassert test.
2533
2534 * dispextern.h (struct it): Update the comment documenting what
2535 can it->OBJECT be.
2536
8c203dbf
EZ
25372011-09-20 Eli Zaretskii <eliz@gnu.org>
2538
2539 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2540 a display string, extend search for cursor position to end of row.
2541 (find_row_edges): If the row ends in a newline from a display
2542 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2543 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2544 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2545 non-empty line. Fixes confusing cursor motion with arrow keys at
2546 the beginning of a line that starts with whitespace.
8c203dbf 2547
a4824228
LMI
25482011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2549
2550 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2551 (bug#9493).
2552
33ed493b
CY
25532011-09-18 Chong Yidong <cyd@stupidchicken.com>
2554
2555 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2556 boolean (Bug#9154).
2557
56cd55c8
EZ
25582011-09-18 Eli Zaretskii <eliz@gnu.org>
2559
2560 * xdisp.c (display_line): Record maximum and minimum buffer
2561 positions even if no glyphs were produced (e.g., by a zero-width
2562 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2563 buffer positions that will be removed from the glyph row because
2564 they don't fit.
c02dcedf
EZ
2565 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2566 column is beyond frame width: don't subtract 1 "pixel" when
2567 computing width of the stretch.
3e62b7e0
EZ
2568 (reseat_at_next_visible_line_start): Undo the change made on
2569 2011-09-17 that saved paragraph information and restored it after
2570 the call to `reseat'. (Bug#9545)
56cd55c8 2571
5ed99d36 25722011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2573
2574 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2575 and turn window cursor on if cleared (Bug#9415).
2576
5ed99d36 25772011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2578
2579 * search.c (boyer_moore): Take unibyte characters from pattern
2580 literally. (Bug#9458)
2581
9bade7b2
EZ
25822011-09-18 Eli Zaretskii <eliz@gnu.org>
2583
2584 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2585
e5e9d610
PE
25862011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2587
87e4427a
PE
2588 Fix minor problem found by static checking.
2589 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2590 initialized, to pacify gcc -Wuninitialized.
2591
e5e9d610
PE
2592 * fileio.c: Report proper errno when syscall falls.
2593 (Finsert_file_contents): Save and restore errno,
2594 so that report_file_error outputs the correct diagnostic.
2595 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2596
a1674f0b
EZ
25972011-09-18 Eli Zaretskii <eliz@gnu.org>
2598
2599 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2600
fbfb6dd4
EZ
26012011-09-17 Eli Zaretskii <eliz@gnu.org>
2602
2603 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2604 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2605
bb187662
EZ
26062011-09-17 Eli Zaretskii <eliz@gnu.org>
2607
1137e8b8 2608 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2609 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2610
2611 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2612 (bidi_find_paragraph_start): Search back for paragraph beginning
2613 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2614 (bidi_move_to_visually_next): Only trigger paragraph-related
2615 computations when the last character is a newline or at EOB, not
2616 just any NEUTRAL_B. (Bug#9470)
2617
bb187662
EZ
2618 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2619 truncated lines if point is covered by a display string. (Bug#9524)
2620
2e621251
PE
26212011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2622
2623 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2624 (cons_to_x_long): New function.
2625 (lisp_data_to_selection_data): Use it. Correct the test for
2626 short-versus-long data; it was negated. Break out of vector
2627 loop, for efficiency, when a long datum is discovered.
2628
91a15bc6
SM
26292011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2630
2631 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2632
b41c3a35
EZ
26332011-09-16 Eli Zaretskii <eliz@gnu.org>
2634
2635 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2636 GCC PR/17406) by declaring this function with external scope.
2637
7812ba2d
PE
26382011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2639
2640 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2641 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2642
cf7edc2a
AS
26432011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2644
2645 * editfns.c (Fformat): Correctly handle text properties on "%%".
2646
bd01620e
EZ
26472011-09-15 Eli Zaretskii <eliz@gnu.org>
2648
2649 * xterm.c (x_draw_composite_glyph_string_foreground):
2650 * w32term.c (x_draw_composite_glyph_string_foreground):
2651 * term.c (encode_terminal_code):
2652 * composite.c (composition_update_it, get_composition_id):
2653 * xdisp.c (get_next_display_element)
2654 (fill_composite_glyph_string): Add comments about special meaning
2655 of TAB characters in a composition.
2656
a02719a3
PE
26572011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2658
2659 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2660 This occurs when processing a multibyte format.
2661 Problem reported by Wolfgang Jenker.
a02719a3 2662
72589a3c
JB
26632011-09-15 Johan Bockgård <bojohan@gnu.org>
2664
2665 * xdisp.c (try_cursor_movement): Only check for exact match if
2666 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2667
1c14176c
PE
26682011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2669
2670 Remove unused external symbols.
2671 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2672 * xdisp.c (calc_pixel_width_or_height): Now static.
2673 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2674 * indent.c (check_display_width):
2675 * w32term.c: Fix comment to match code.
2676 * xterm.c, xterm.h (x_catching_errors): Remove.
2677
d2eea5b5
PE
26782011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2679
2680 * xselect.c: Use signed conversions more consistently (Bug#9498).
2681 (selection_data_to_lisp_data): Assume incoming selection data are
2682 signed integers, not unsigned. This is to be consistent with
2683 outgoing selection data, which was modified to use signed integers
2684 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2685 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2686 expects long, not unsigned long.
2687
46888499
EZ
26882011-09-14 Eli Zaretskii <eliz@gnu.org>
2689
2690 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2691 computation of loop end. Reported by Johan Bockgård
2692 <bojohan@gnu.org>.
2693
ef8ef9fb
CY
26942011-09-13 Chong Yidong <cyd@stupidchicken.com>
2695
2696 * frame.c (Fother_visible_frames_p): Function deleted.
2697
fa819fed
EZ
26982011-09-12 Eli Zaretskii <eliz@gnu.org>
2699
2700 * indent.c (compute_motion): Process display vector front to back
2701 rather than the other way around. (Bug#2496)
2702
2ba8e008
SM
27032011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2704
2705 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2706
20f53c69
CY
27072011-09-11 Chong Yidong <cyd@stupidchicken.com>
2708
2709 * minibuf.c (Fread_from_minibuffer): Doc fix.
2710
d562d7a4
EZ
27112011-09-11 Eli Zaretskii <eliz@gnu.org>
2712
2713 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2714 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2715
1c4d7f3d
LMI
27162011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2717
2718 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2719 value for non-existent files.
2720
b885bf36
EZ
27212011-09-11 Eli Zaretskii <eliz@gnu.org>
2722
2723 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2724 set its "size" to -1. This will set the modtime_size field of
2725 the corresponding buffer to -1, which is what
2726 verify-visited-file-modtime expects for files that do not exist.
2727 (Bug#9139)
2728
6612f0bf
PE
27292011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2730
2731 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2732 here ...
2733 * lisp.h: ... from here. push_key_description is no longer
2734 defined in keyboard.c, so its declaration should not be in
2735 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2736 logically belongs with push_key_description.
2737
dfb3f755
PE
27382011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2739
2740 * buffer.h: Include <sys/types.h> instead of <time.h>.
2741 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2742 Problem reported by Herbert J. Skuhra.
2743
3134906c
LMI
27442011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2745
2746 * xml.c (parse_region): Make the parsing work for
2747 non-comment-starting XML files again (bug#9144).
2748
8d903f4e
AS
27492011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2750
2751 * image.c (gif_load): Fix calculation of bottom and right corner.
2752 (Bug#9468)
2753
80ad64f4
EZ
27542011-09-10 Eli Zaretskii <eliz@gnu.org>
2755
2756 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2757 redisplay in small windows.
2758
208a048d
EZ
27592011-09-09 Eli Zaretskii <eliz@gnu.org>
2760
2761 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2762
9b1c252e
MR
27632011-09-08 Martin Rudalics <rudalics@gmx.at>
2764
2765 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2766 Operate on live windows only.
2767
2949f33b
JB
27682011-09-08 Juanma Barranquero <lekktu@gmail.com>
2769
2770 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2771
e08dcafd
EZ
27722011-09-07 Eli Zaretskii <eliz@gnu.org>
2773
2774 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2775 only under bidi iteration.
2776
115b96bd
JD
27772011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2778
2779 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2780
c8199d0f
PE
27812011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2782
2783 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2784 Without this fix, the command to link temacs failed due to an
2785 undefined symbol __builtin_isnan. This is because
2786 /usr/include/iso/math_c99.h #defines isnan(x) to
2787 __builtin_isnan(x), but the bundled gcc, which identifies itself
2788 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2789 a __builtin_isnan.
2790 * floatfns.c (isnan): #undef, and then #define to a clone of
2791 what's in data.c.
2792 (Fisnan): Always define, since it's always available now.
2793 (syms_of_floatfns): Always define isnan at the Lisp level.
2794
e39b275c 27952011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2796
2797 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2798
b2db44d9 27992011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2800
f4af5137 2801 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2802 The previous code assumed that file offsets (off_t values) fit in
2803 EMACS_INT variables, which is not true on typical 32-bit hosts.
2804 The code messed up by falsely reporting buffer overflow in cases
2805 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2806 when "big" contains more than 2**29 bytes, even though this
2807 inserts just one byte and does not overflow the buffer.
2808 (Finsert_file_contents): Store file offsets as off_t
2809 values, not as EMACS_INT values. Check for overflow when
2810 converting between EMACS_INT and off_t. When checking for
2811 buffer overflow or for overlap, take the offsets into account.
2812 Don't use EMACS_INT for small values where int suffices.
2813 When checking for overlap, fix a typo: ZV was used where
2814 ZV_BYTE was intended.
2815 (Fwrite_region): Don't assume off_t fits into 'long'.
2816 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2817
ecfc0a49
MA
28182011-09-05 Michael Albinus <michael.albinus@gmx.de>
2819
2820 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2821
6511acf2 28222011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2823
0999621a 2824 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2825
2826 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2827 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2828 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2829 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2830 (modify_event_symbol): Do not assume that the length of
2831 name_alist_or_stem is safe to alloca and fits in int.
2832 (Fexecute_extended_command): Likewise for function name and binding.
2833 (Frecursion_depth): Wrap around reliably on integer overflow.
2834 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2835 since some callers pass EMACS_INT values.
2836 (Fsingle_key_description): Don't crash if symbol name contains more
2837 than MAX_ALLOCA bytes.
2838 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2839 (get_minibuffer): Arg is now EMACS_INT, not int.
2840 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2841 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2842 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2843
2be7d702
PE
2844 * dbusbind.c (signature_cat): New function.
2845 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2846 Do not overrun buffer; instead, report string overflow.
2847
9d1df220
PE
2848 * dispnew.c (add_window_display_history): Don't overrun buffer.
2849 Truncate instead; this is OK since it's just a log.
2850
33ef5c64
PE
2851 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2852 even if the time zone offset is outlandishly large.
2853 Don't mishandle offset == INT_MIN.
2854
66c6fdd5
PE
2855 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2856 when creating daemon; the previous buffer-overflow check was incorrect.
2857
d749b01b
PE
2858 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2859 which has the guts of the old verror function.
2860
b5cd1905
PE
2861 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2862 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2863
6e1a67fb
PE
2864 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2865 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2866 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2867 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2868 length of string rather than counting it via multiple sprintfs;
2869 that's simpler and more reliable.
c21721cc
PE
2870 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2871 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2872 sprintf, in case result does not fit in int.
2873
c57b67fc
PE
2874 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2875 (fontset_from_font): Print it.
2876
8a401434
PE
2877 * frame.c (tty_frame_count): Now printmax_t, not int.
2878 (make_terminal_frame, set_term_frame_name): Print it.
2879 (x_report_frame_params): In X, window IDs are unsigned long,
2880 not signed long, so print them as unsigned.
2881 (validate_x_resource_name): Check for implausibly long names,
2882 and don't assume name length fits in 'int'.
2883 (x_get_resource_string): Don't blindly alloca invocation name;
2884 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2885 not fit in int.
2886
6e1a67fb
PE
2887 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2888 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2889 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2890
0df02bf3
PE
2891 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2892 Use esprintf, not sprintf, in case result does not fit in int.
2893
48e30793
PE
2894 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2895 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2896 it as a large positive number.
2897 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2898 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2899
a66ff6d8
PE
2900 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2901 in case result does not fit in int.
2902
aca216ff
PE
2903 * print.c (float_to_string): Detect width overflow more reliably.
2904 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2905 buffer overrun. Don't assume list length fits in 'int'. Treat
2906 print length of 0 as 0, not as infinity; to be consistent with other
2907 uses of print length in this function. Don't overflow print length
2908 index. Don't assume hash table size fits in 'long', or that
2909 vectorlike size fits in 'unsigned long'.
2910
31c286f7
PE
2911 * process.c (make_process): Use printmax_t, not int, to format
2912 process-name gensyms.
2913
55e5faa1
PE
2914 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2915
80f2e268
PE
2916 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2917 to avoid potential buffer overrun.
2918
670741ab
PE
2919 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2920 if X resource line is longer than 512 bytes.
2921
b7163a50
PE
2922 * xfns.c (x_window): Make sprintf buffer a bit bigger
2923 to avoid potential buffer overrun.
2924
ae58ff1f
PE
2925 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2926
c43c8a6a
PE
2927 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2928
3f8236f4
PE
29292011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2930
53e9fe90 2931 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2932 Without these, Emacs silently mishandles large integers sometimes.
2933 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2934 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2935
6511acf2
PE
2936 * xdisp.c (try_window_id): Check Emacs fixnum range before
2937 converting to 'int'.
806add1d 2938
6511acf2 2939 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2940 Check that an Emacs fixnum is in range before assigning it to 'int'.
2941 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2942 values converted from Emacs fixnums.
2943 (Frecenter): Don't wrap around a line count if it is out of 'int'
2944 range; instead, treat it as an extreme value.
2945 (Fset_window_configuration, compare_window_configurations):
2946 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2947
6511acf2
PE
2948 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2949 that can exceed INT_MAX. Check that EMACS_INT value is in range
2950 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2951 (match_limit): Don't assume that a fixnum can fit in 'int'.
2952
6511acf2 2953 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2954 exceed INT_MAX.
2955
6511acf2 2956 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2957 (Fvertical_motion): Don't wrap around LINES values that don't fit
2958 in 'int'. Instead, treat them as extreme values. This is good
2959 enough for windows, which can't have more than INT_MAX lines anyway.
2960
fcb901a7
LMI
29612011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2962
0f2f6b6d
LMI
2963 * Require libxml/parser.h to avoid compilation warning.
2964
fcb901a7
LMI
2965 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2966
2967 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2968 since this reportedly can destroy thread storage.
2969
6e20a0d4
CY
29702011-08-30 Chong Yidong <cyd@stupidchicken.com>
2971
2972 * syntax.c (find_defun_start): Update all cache variables if
2973 exiting early (Bug#9401).
2974
148ae00e
EZ
29752011-08-30 Eli Zaretskii <eliz@gnu.org>
2976
f6cfbd8f
EZ
2977 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2978
148ae00e
EZ
2979 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2980 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2981 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2982
2983 * term.c (tty_append_glyph): New function.
2984 (produce_stretch_glyph): Static function and its prototype deleted.
2985
a66cfb1c
SM
2986 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2987 Add prototypes.
148ae00e 2988
c4a07a4c
PE
29892011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2990
2991 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2992 when checking :margin (Bug#9390).
2993 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2994 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2995 so that the name doesn't mislead. All uses changed.
2996
6bc8cd65
JB
29972011-08-28 Johan Bockgård <bojohan@gnu.org>
2998
2999 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
3000 set_tty_hooks.
3001
dca4927e
EZ
30022011-08-27 Eli Zaretskii <eliz@gnu.org>
3003
3004 * xdisp.c (move_it_to): Don't bail out early when reaching
3005 position beyond to_charpos, if we are scanning backwards.
3006 (move_it_vertically_backward): When DY == 0, make sure we get to
3007 the first character in the line after the newline.
3008
f2cad773
PE
30092011-08-27 Paul Eggert <eggert@cs.ucla.edu>
3010
3011 * ccl.c: Improve and simplify overflow checking (Bug#9196).
3012 (ccl_driver): Do not generate an out-of-range pointer.
3013 (Fccl_execute_on_string): Remove unnecessary check for
3014 integer overflow, noted by Stefan Monnier in
3015 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
3016 Remove a FIXME that didn't need fixing.
3017 Simplify the newly-introduced buffer reallocation code.
3018
0cae2cdb
JB
30192011-08-27 Juanma Barranquero <lekktu@gmail.com>
3020
3021 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
3022
5fc295a4 30232011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 3024
70c60eb2 3025 Integer and memory overflow issues (Bug#9196).
726e0ab1 3026
d31850da
PE
3027 * doc.c (get_doc_string): Rework so that
3028 get_doc_string_buffer_size is the actual buffer size, rather than
3029 being 1 less than the actual buffer size; this makes xpalloc more
3030 convenient.
3031
a69fbedb
PE
3032 * image.c (x_allocate_bitmap_record, cache_image):
3033 * xselect.c (Fx_register_dnd_atom):
3034 Simplify previous changes by using xpalloc.
3035
fe5c5d37
PE
3036 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
3037 since either will do and ptrdiff_t is convenient with xpalloc.
3038
0065d054
PE
3039 * charset.c (charset_table_size)
3040 (struct charset_sort_data.priority): Now ptrdiff_t.
3041 (charset_compare): Don't overflow if priorities differ greatly.
3042 (Fsort_charsets): Don't assume list length fits in int.
3043 Check for size-calculation overflow when allocating sort data.
3044 (syms_of_charset): Allocate an initial charset table that is
3045 just under 64 KiB, to avoid problems with glibc malloc and mmap.
3046
3047 * cmds.c (internal_self_insert): Check for size-calculation overflow.
3048
3049 * composite.h (struct composition.glyph_len): Now int, not unsigned.
3050 The actual value is always <= INT_MAX, and leaving it unsigned made
3051 overflow checking harder.
3052
3053 * dispextern.h (struct glyph_matrix.rows_allocated)
3054 (struct face_cache.size): Now ptrdiff_t, for convenience in use
3055 with xpalloc. The values are still always <= INT_MAX.
3056
3057 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
3058
3059 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
3060 (SAFE_NALLOCA): New macro.
3061
3062 * region-cache.c (struct boundary.pos, find_cache_boundary)
3063 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
3064 (set_cache_region, invalidate_region_cache)
3065 (revalidate_region_cache, know_region_cache, region_cache_forward)
3066 (region_cache_backward, pp_cache):
3067 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
3068 so that ptrdiff_t * can be passed to xpalloc.
3069 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
3070 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
3071 (pp_cache): Don't assume cache_len fits in int.
3072 * region-cache.h: Adjust extern decls to match.
3073
3074 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3075 EMACS_INT, since either will do, for xpalloc.
3076
3077 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3078 (xnmalloc, xnrealloc, xpalloc): New functions.
3079
726e0ab1
PE
3080 * bidi.c (bidi_shelve_header_size): New constant.
3081 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3082 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3083
51f30bc5 3084 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
3085 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3086 (overlay_strings):
3087 Don't update size of array until after memory allocation succeeds,
3088 because xmalloc/xrealloc may not return.
0065d054
PE
3089 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3090 now that we have proper integer overflow checking.
3091 (record_overlay_string, overlay_strings): Catch overflows when
3092 calculating size of overlay_str_buf.
726e0ab1 3093
0065d054
PE
3094 * callproc.c (Fcall_process): Check for size overflow when
3095 calculating size of args2.
3096 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3097 Normally we prefer signed values, but sticking with ptrdiff_t would
3098 require adding more-complicated checks.
726e0ab1
PE
3099
3100 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3101 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3102 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 3103 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
3104
3105 * character.c (Fstring): Check for size-calculation overflow.
3106
3107 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3108 unnecessary integer overflow. Check for size overflow.
3109 (encode_coding_object): Don't update size until xmalloc succeeds.
3110
3111 * composite.c (get_composition_id): Check for overflow in glyph
3112 length calculations.
3113
3114 Integer and memory overflow fixes for display code.
3115 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3116 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3117 (scrolling_window): Check for overflow in size calculations.
3118 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3119 Don't assume glyph table len fits in int.
3120 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3121 (row_table_size): Now ptrdiff_t, not int.
3122 (scrolling_window): Avoid overflow in size calculations.
3123 Don't update size until allocation succeeds.
3124 * fns.c (concat): Check for overflow in size calculations.
3125 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3126 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3127 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3128
3129 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3130 (get_doc_string): Check for size calculation overflow.
3131 Don't update size until allocation succeeds.
3132 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3133 EMACS_INT, where ptrdiff_t will do.
3134 (Fsubstitute_command_keys): Check for string overflow.
3135
3136 * editfns.c (set_time_zone_rule): Don't assume environment length
3137 fits in int.
3138 (message_length): Now ptrdiff_t, not int.
3139 (Fmessage_box): Don't update size until allocation succeeds.
3140 Don't assume message length fits in int.
3141 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3142
0065d054
PE
3143 * emacs.c (main): Do not reallocate argv, since there is a null at
3144 the end that can be overwritten, and this way there's no need to
3145 worry about size-calculation overflow.
3146 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
3147
3148 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3149 alloc succeeds.
3150 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3151
3152 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3153 (x_set_scroll_bar_width, x_figure_window_size):
3154 Check for integer overflow.
3155 (x_set_alpha): Do not assume XINT fits in int.
3156
3157 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3158 This is for the members text_lines, text_cols, total_lines, total_cols,
3159 where the system imposes an 'int' limit.
3160
3161 * fringe.c (Fdefine_fringe_bitmap):
3162 Don't update size until alloc works.
3163
3164 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3165 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3166
3167 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3168 Check for size-calculation overflow.
3169 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3170 do, as we prefer signed integers.
3171 (id_to_widget.max_size, id_to_widget.used)
3172 (xg_store_widget_in_map, xg_remove_widget_from_map)
3173 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3174 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3175 Use and return ptrdiff_t, not int.
3176 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3177 * gtkutil.h: Change prototypes to match the above.
3178
3179 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3180 are duplicate now that they've been promoted to lisp.h.
3181 (x_allocate_bitmap_record, x_alloc_image_color)
3182 (make_image_cache, cache_image, xpm_load):
3183 Don't update size until alloc is done.
3184 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3185 (x_detect_edges):
3256efce 3186 Check for size calculation overflow.
726e0ab1
PE
3187 (ct_colors_allocated_max): New constant.
3188 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3189 overflow.
3256efce 3190
726e0ab1
PE
3191 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3192 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3193 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3194 Use ptrdiff_t, not int, to count maps.
3195 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
3196 calculations. Don't update size until allocation succeeds.
3197 Redo calculations to avoid overflow.
726e0ab1
PE
3198 * keyboard.h: Change prototypes to match the above.
3199
3200 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3201 to count maps.
3202 (current_minor_maps): Check for size calculation overflow.
3203 * keymap.h: Change prototypes to match the above.
3204
3205 * lread.c (read1, init_obarray): Don't update size until alloc done.
3206
3207 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3208 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3209
726e0ab1
PE
3210 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3211 Now ptrdiff_t, not int.
3212 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3213 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3214
3215 * process.c (Fnetwork_interface_list): Check for overflow
3216 in size calculation.
3217
3218 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3219
3220 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3221 overflow. Don't bother calling xmalloc when xrealloc will do.
3222
3223 * search.c (Freplace_match): Check for size calculation overflow.
3224 (Fset_match_data): Don't assume list lengths fit in 'int'.
3225
3226 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3227 for command line length. Do not attempt to address one before the
3228 beginning of an array, as that's not portable.
3229
3230 * term.c (max_frame_lines): Remove; unused.
3231 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3232 not int.
3233 (encode_terminal_code, calculate_costs): Check for size
3234 calculation overflow.
3235 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3236 table lengths and related sizes. Don't update size until alloc
3237 done. Redo calculations to avoid overflow.
3238 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3239
3240 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3241 subtracting pointers.
3242 (gobble_line): Check for overflow more carefully. Don't update size
3243 until alloc done.
3244
3245 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3246 Don't update size until alloc done.
3247 Redo size calculations to avoid overflow.
3248 Check for size calculation overflow.
0065d054 3249 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
3250
3251 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3252 Use ptrdiff_t, not int, for sizes.
3253 (store_mode_line_noprop_char): Don't update size until alloc done.
3254
0065d054
PE
3255 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3256 Use ptrdiff_t, not int, for sizes.
3257 (Finternal_make_lisp_face, cache_face):
3258 Check for size calculation overflow.
3259 (cache_face): Treat size calculation overflows as if they were
3260 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
3261
3262 * xfns.c (x_encode_text, x_set_name_internal)
3263 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3264 sizes, since they can exceed INT_MAX in size. Check for size
3265 calculation overflow.
3266
0065d054
PE
3267 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3268 (xg_select): Check for size calculation overflow.
726e0ab1
PE
3269 Don't update size until alloc done.
3270
0065d054 3271 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 3272 as sprintf is limited to int lengths.
1d526e2f 3273
252c5ee1
PE
3274 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3275 (X_LONG_MIN): New macros.
864d7ce7
PE
3276 Use them to make the following changes clearer.
3277 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3278 This change doesn't affect the value now, but it may help remind
3279 future maintainers not to raise the value too much later.
3280 (SELECTION_QUANTUM): Remove, replacing with ...
3281 (selection_quantum): ... new function, which avoids overflow.
3282 All uses changed.
3283 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3284 assumption that selection length fits in 'int'.
3285 (x_reply_selection_request, x_handle_selection_request)
3286 (x_get_window_property, receive_incremental_selection)
3287 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3288 (lisp_data_to_selection_data, clean_local_selection_data):
3289 Use ptrdiff_t, not int, to record length of selection.
3290 (x_reply_selection_request, x_get_window_property)
3291 (receive_incremental_selection, x_property_data_to_lisp):
3292 Redo calculations to avoid overflow.
3293 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 3294 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
3295 something.
3296 (x_get_window_property, receive_incremental_selection)
3297 (lisp_data_to_selection_data, x_property_data_to_lisp):
3298 Check for size-calculation overflow.
3299 (x_get_window_property, receive_incremental_selection)
3300 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3301 Don't store size until memory allocation succeeds.
3302 (x_get_window_property): Plug memory leak on memory exhaustion.
3303 Don't double-block input; malloc is safe here. Don't assume 2**34
3304 - 4 fits in unsigned long. Add an xassert to check
3305 XGetWindowProperty overflow. Be more careful about overflow
3306 calculations, and distinguish size from memory overflow better.
3307 (receive_incremental_selection): When tracing, don't assume
3308 unsigned int is less than INT_MAX.
3309 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3310 harmful) conversions of unsigned short to int.
3311 (lisp_data_to_selection_data): Don't assume that integers
3312 in the range -65535 through -1 fit in an X unsigned short.
3313 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3314 result parameters unless successful. Rely on cons_to_unsigned
3315 to report problems with elements; the old code wasn't right anyway.
3316 (x_check_property_data): Check for int overflow; we cannot use
3317 a wider type due to X limits.
3318 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3319
726e0ab1 3320 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 3321
0065d054
PE
3322 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3323 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
3324 (x_color_cells): Don't store size until memory allocation succeeds.
3325 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 3326 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
3327 (x_term_init): Don't assume length fits in int (sprintf is limited
3328 to int size).
bc18e09d 3329
ebfa62c0
PE
3330 Use ptrdiff_t for composition IDs.
3331 * character.c (lisp_string_width):
3332 * composite.c (composition_table_size, n_compositions)
3333 (get_composition_id, composition_gstring_from_id):
3334 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3335 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3336 * window.c (Frecenter):
3337 Use ptrdiff_t, not int, for composition IDs.
3338 * composite.c (get_composition_id): Check for integer overflow.
3339 * composite.h: Adjust prototypes to match the above changes.
3340
d3411f89
PE
3341 Use ptrdiff_t for hash table indexes.
3342 * category.c (hash_get_category_set):
3343 * ccl.c (ccl_driver):
3344 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3345 * coding.c (coding_system_charset_list, detect_coding_system):
3346 * coding.h (struct coding_system.id):
3347 * composite.c (get_composition_id, gstring_lookup_cache):
3348 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3349 * image.c (xpm_get_color_table_h):
3350 * lisp.h (hash_lookup, hash_put):
3351 * minibuf.c (Ftest_completion):
3352 Use ptrdiff_t for hash table indexes, not int (which is too
3353 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3354 32-bit --with-wide-int hosts).
3355
e097a6fa
PE
3356 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3357 Add a FIXME comment about memory leaks.
3358 (syms_of_charset): Don't assume xmalloc returns.
3359
5637687f
PE
3360 Don't assume that stated character widths fit in int.
3361 * character.c (Fchar_width, c_string_width, lisp_string_width):
3362 * character.h (CHAR_WIDTH):
3363 * indent.c (MULTIBYTE_BYTES_WIDTH):
3364 Use sanitize_char_width to avoid undefined and/or bad behavior
3365 with outlandish widths.
a66cfb1c 3366 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
3367 now that we have two such functions. All uses changed.
3368 (sanitize_char_width): New inline function.
3369
a2271ba2
PE
3370 Don't assume that tab-width fits in int.
3371 * character.h (sanitize_width): New inline function.
3372 (SANE_TAB_WIDTH): New macro.
3373 (ASCII_CHAR_WIDTH): Use it.
3374 * indent.c (sane_tab_width): Remove. All uses replaced by
3375 SANE_TAB_WIDTH (current_buffer).
3376 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3377
18c52557
PE
3378 * fileio.c: Integer overflow issues with file modes.
3379 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3380
caeeedc1
PE
3381 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3382 Remove unreachable code.
3383 (read_hex, load_charset_map_from_file): Check for integer overflow.
3384
6df6ae42 3385 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
3386 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3387 (x_send_scroll_bar_event): Likewise. Check that the size does not
3388 exceed limits imposed by XClientMessageEvent, as well as the usual
3389 ptrdiff_t and size_t limits.
3390
b13995db
PE
3391 * keyboard.c: Overflow, signedness and related fixes.
3392 (make_lispy_movement): Use same integer type in forward decl
3393 that is used in the definition.
3394 (read_key_sequence, keyremap_step):
3395 Change bufsize argument back to int, undoing my 2011-03-30 change.
3396 We prefer signed types, and int is wide enough here.
3397 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3398 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3399 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3400 length, not size_t. Use ptrdiff_t for index, not int.
3401 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3402 possibility of integer overflow.
3403
13464394
PE
3404 Overflow, signedness and related fixes for images.
3405
3406 * dispextern.h (struct it.stack[0].u.image.image_id)
3407 (struct_it.image_id, struct image.id, struct image_cache.size)
3408 (struct image_cache.used, struct image_cache.ref_count):
3409 * gtkutil.c (update_frame_tool_bar):
3410 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3411 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3412 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3413 * nsmenu.m (update_frame_tool_bar):
3414 * xdisp.c (calc_pixel_width_or_height):
3415 * xfns.c (image_cache_refcount):
3416 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3417 on typical 64-bit hosts.
3418
3419 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3420 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3421 Omit unnecessary casts to int.
3422 (parse_image_spec): Check that integers fall into 'int' range
3423 when the callers expect that.
3424 (image_ascent): Redo ascent calculation to avoid int overflow.
3425 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3426 (lookup_image): Remove unnecessary tests.
3427 (xbm_image_p): Locals are now of int, not EMACS_INT,
3428 since parse_image_check makes sure they fit into int.
3429 (png_load, gif_load, svg_load_image):
3430 Prefer int to unsigned where either will do.
3431 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3432 old tiff_error_handler and tiff_warning_handler.
3433 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3434 stack buffer overflows. It uses only the features of vsnprintf
3435 that are common to both POSIX and native Microsoft.
3436 (tiff_error_handler, tiff_warning_handler): Use it.
3437 (tiff_load, gif_load, imagemagick_load_image):
3438 Don't assume :index value fits in 'int'.
3439 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3440 (imagemagick_load_image): Check that crop parameters fit into
3441 the integer types that MagickCropImage accepts. Don't assume
3442 Vimagemagick_render_type has a nonnegative value. Don't assume
3443 size_t fits in 'long'.
3444 (gs_load): Use printmax_t to print the widest integers possible.
3445 Check for integer overflow when computing image height and width.
3446
c11821d4
EZ
34472011-08-26 Eli Zaretskii <eliz@gnu.org>
3448
3449 * xdisp.c (redisplay_window): Don't force window start if point
3450 will be invisible in the resulting window. (Bug#9324)
3451
0c95fcf7
EZ
34522011-08-25 Eli Zaretskii <eliz@gnu.org>
3453
3454 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3455 the display spec is of the form `(space ...)'.
3456 (handle_display_spec): Return the value returned by
3457 handle_single_display_spec, not just 1 or zero.
3458 (handle_single_display_spec): If the display spec is of the form
3459 `(space ...)', and specifies display in the text area, return 2
3460 rather than 1.
fee65a97 3461 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3462 accurately, and prefer exact match for point under bidi.
3463 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3464
3465 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3466 into disp_prop; all users changed.
3467
3468 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3469 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3470 for the text covered by the display property.
3471
e4ed06f1
CY
34722011-08-25 Chong Yidong <cyd@stupidchicken.com>
3473
3474 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3475 Change return value to nil.
3476 (Frecord_buffer): Delete unused function.
3477
f67cdd7f
EZ
34782011-08-24 Eli Zaretskii <eliz@gnu.org>
3479
5980d4c6
EZ
3480 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3481 buffers, return left-to-right.
8610fe8b
EZ
3482 (set_cursor_from_row): Consider candidate row a win if its glyph
3483 represents a newline and point is on that newline. Fixes cursor
3484 positioning on the newline at EOL of R2L text within L2R
3485 paragraph, and vice versa.
3486 (try_cursor_movement): Check continued rows, in addition to
3487 continuation rows. Fixes unwarranted scroll when point enters a
3488 continued line of R2L text within an L2R paragraph, or vice versa.
3489 (cursor_row_p): Consider the case of point being equal to
3490 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3491 from the end of a short line to the beginning of a continued line
3492 of R2L text within L2R paragraph.
3493 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3494 composed characters.
5980d4c6 3495
f67cdd7f
EZ
3496 * bidi.c (bidi_check_type): Use xassert.
3497 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3498 members.
3499
bca633fb
EZ
35002011-08-23 Eli Zaretskii <eliz@gnu.org>
3501
3502 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3503 a character.
3504
4a5885a7
CY
35052011-08-23 Chong Yidong <cyd@stupidchicken.com>
3506
3507 * nsfont.m (ns_otf_to_script): Fix typo.
3508
0902a04e
KH
35092011-08-22 Kenichi Handa <handa@m17n.org>
3510
3511 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3512 extra slot even if the purpose is char-code-property-table.
3513
1a2e6670
EZ
35142011-08-23 Eli Zaretskii <eliz@gnu.org>
3515
8ddde651
EZ
3516 * xdisp.c (redisplay_window): When computing centering_position,
3517 account for the height of the header line. (Bug#8874)
3518
425cc014
EZ
3519 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3520 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3521 candidate is selected by the mouse, and that candidate has a
3522 composed character under the mouse.
3523
1a2e6670
EZ
3524 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3525 coordinates reported by pos-visible-in-window-p for a composed
3526 character in column zero.
3527
8b76d6f8
SM
35282011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3529
3530 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3531
dac347dd
EZ
35322011-08-22 Eli Zaretskii <eliz@gnu.org>
3533
3534 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3535 consider it a hit if to_charpos is anywhere in the range of the
3536 composed buffer positions.
3537
e013fb34
CY
35382011-08-22 Chong Yidong <cyd@stupidchicken.com>
3539
3540 * image.c (gif_load): Don't assume that each subimage has the same
3541 dimensions as the base image. Handle disposal method that is
3542 "undefined" by the gif spec (Bug#9335).
3543
bd1ba3e8
CY
35442011-08-20 Chong Yidong <cyd@stupidchicken.com>
3545
3546 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3547 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3548
54a1215b
EZ
35492011-08-19 Eli Zaretskii <eliz@gnu.org>
3550
823564e5
EZ
3551 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3552 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3553 from an Org mode buffer to a Speedbar frame.
3554
54a1215b
EZ
3555 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3556 a composition, take its buffer position from IT->cmp_it.charpos.
3557 Fixes cursor positioning at the beginning of a line that begins
3558 with a composed character.
3559
9778ebcc
EZ
35602011-08-18 Eli Zaretskii <eliz@gnu.org>
3561
0be6ee06
EZ
3562 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3563 character bidirectional type, use STRONG_L instead. Fixes crashes
3564 in a buffer produced by `describe-categories'.
3565
9778ebcc
EZ
3566 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3567 members before the level stack, so they would be saved and
3568 restored when copying iterator state. Fixes incorrect reordering
3569 around TABs covered by display properties.
3570
156bffbe
AS
35712011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3572
6b02f655 3573 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3574
72ad093b
CY
35752011-08-17 Chong Yidong <cyd@stupidchicken.com>
3576
3577 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3578 (internal_condition_case_2, internal_condition_case_n):
3579 Remove unnecessary aborts (Bug#9081).
72ad093b 3580
35774242
EZ
35812011-08-17 Eli Zaretskii <eliz@gnu.org>
3582
3583 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3584 has no `load' handler, try opening the file locally. (Bug#9311)
3585
db76dd85
KB
35862011-08-16 Ken Brown <kbrown@cornell.edu>
3587
3588 * gmalloc.c: Expand comment.
3589
b215eee5
EZ
35902011-08-16 Eli Zaretskii <eliz@gnu.org>
3591
3592 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3593 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3594
a4579d33
KB
35952011-08-16 Ken Brown <kbrown@cornell.edu>
3596
3597 Fix memory allocation problems in Cygwin build (Bug#9273).
3598
3599 * unexcw.c ( __malloc_initialized): Declare external variable.
3600 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3601
8b76d6f8
SM
3602 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3603 New variables.
a4579d33
KB
3604 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3605 dumped emacs.
3606 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3607 in the static heap.
3608 [CYGWIN] (special_realloc): New function.
3609 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3610 requests to realloc storage in the static heap.
3611
3ebec551
PE
36122011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3613
3614 * bidi.c (bidi_initialize): Remove unused local.
3615
9fd8be00
EZ
36162011-08-15 Eli Zaretskii <eliz@gnu.org>
3617
6b02f655
SM
3618 * bidimirror.h:
3619 * biditype.h: Remove file.
3620 * makefile.w32-in ($(BLD)/bidi.$(O)):
3621 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3622
3623 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3624
3625 * chartab.c: Improve commentary for the uniprop_table API.
3626
32413314
EZ
3627 * bidi.c (bidi_paragraph_init): Support zero value of
3628 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3629 (bidi_initialize): Use uniprop_table instead of including
3630 biditype.h and bidimirror.h.
32413314 3631
9fd8be00
EZ
3632 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3633 coordinates of the iterator when restoring from ppos_it.
3634 (Bug#9296)
3635
5cf2b69b
KH
36362011-08-14 Kenichi Handa <handa@m17n.org>
3637
3638 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3639 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3640
daf17d00
EZ
36412011-08-14 Eli Zaretskii <eliz@gnu.org>
3642
3643 * xdisp.c (move_it_in_display_line_to): Don't invoke
3644 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3645 ppos_it. Fixes vertical cursor motion when line beginning is
3646 covered by an image. (Bug#9296)
3647
08e3161a
JD
36482011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3649
3650 * nsterm.h (ns_run_ascript): Declare.
3651 (NSAPP_DATA2_RUNASSCRIPT): Define.
3652
3653 * nsfns.m (as_script, as_result, as_status): New static variables.
3654 (ns_run_ascript): New function.
5e617bc2 3655 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3656 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3657 the event loop. Get status from as_status (Bug#7276).
3658
3659 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3660 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3661 the event loop (Bug#7276).
3662
a3720aa2
AS
36632011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3664
3665 * gnutls.c (QCgnutls_bootprop_priority)
3666 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3667 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3668 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3669 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3670 (QCgnutls_bootprop_verify_hostname_error)
3671 (QCgnutls_bootprop_callbacks_verify): Rename from
3672 Qgnutls_bootprop_..., all uses changed.
3673
3674 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3675 uses changed.
3676
0a0d27fb
PE
36772011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3678
19d5c50c
PE
3679 * xfaces.c (Qframe_set_background_mode): Now static.
3680 * dispextern.h (Qframe_set_background_mode): Remove decl.
3681
0a0d27fb
PE
3682 * process.c (Fnetwork_interface_info): Declare local only if needed.
3683
377538cb
JD
36842011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3685
3686 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3687 (Fnetwork_interface_list): Allocate in increments of bytes instead
3688 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3689 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3690 sockaddr.
3691 (struct ifflag_def): notrailers is smart on OSX.
3692 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3693 Get hardware address with getifaddrs if available.
3694
08fff70c
EZ
36952011-08-12 Eli Zaretskii <eliz@gnu.org>
3696
3697 * xdisp.c (iterate_out_of_display_property): xassert that
3698 IT->position is set to within IT->object's boundaries. Break from
3699 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3700 when IT->position is set up wrongly due to some bug.
3701 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3702 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3703 entry. Force push_it to save on the stack the current
3704 buffer/string position, to be restored by pop_it. Fix flags in
3705 the iterator structure wrt the object coming from a display
3706 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3707 properties. (Bug#9284)
3708
7be1c708 37092011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3710
7be1c708
CY
3711 * fontset.c (fontset_get_font_group): Add proper type checks.
3712 (Bug#9172)
aac0c6e3 3713
7be1c708 37142011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3715
7be1c708
CY
3716 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3717 and LC_VERSION_MIN_MACOSX.
3718 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3719 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3720
97bb72a6
EZ
37212011-08-08 Eli Zaretskii <eliz@gnu.org>
3722
3723 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3724 no-display-properties-and-no-overlays under bidi display.
3725 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3726 properties and overlays.
97bb72a6 3727
d5617611
CY
37282011-08-08 Chong Yidong <cyd@stupidchicken.com>
3729
37e11a63
CY
3730 * editfns.c (Fset_time_zone_rule): Document relationship with the
3731 setenv function.
3732
d5617611
CY
3733 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3734 the font entity extracted from the cache (Bug#8109).
3735
58872834
CY
37362011-08-07 Chong Yidong <cyd@stupidchicken.com>
3737
3738 * composite.c (autocmp_chars): Don't reset point. That is done by
3739 restore_point_unwind (Bug#5984).
3740
75bfc667
JL
37412011-08-07 Juri Linkov <juri@jurta.org>
3742
3743 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3744 to show the arg `TIME' instead of `TIMEVAL'.
3745
d1410150
EZ
37462011-08-06 Eli Zaretskii <eliz@gnu.org>
3747
3748 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3749 display property strides EOL and includes a newline, as in
3750 longlines-mode. (Bug#9254)
75b771e4
EZ
3751 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3752 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3753
3754 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3755 is non-zero, even if the data buffer is NULL. Fixes a crash in
3756 vertical-motion with longlines-mode. (Bug#9254)
3757
35928349
EZ
37582011-08-05 Eli Zaretskii <eliz@gnu.org>
3759
ec7cc85b
EZ
3760 * bidi.c <bidi_cache_total_alloc>: Now static.
3761 (bidi_initialize): Initialize bidi_cache_total_alloc.
3762
8b76d6f8 3763 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3764 cache. (Bug#9221)
3765
3766 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3767 amount allocated this far in `bidi_cache_total_alloc'.
3768 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3769 non-zero, only free the data buffer without restoring the cache
3770 contents. All callers changed.
3771
3772 * dispextern.h (bidi_unshelve_cache): Update prototype.
3773
3774 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3775 (move_it_in_display_line, move_it_to)
3776 (move_it_vertically_backward, move_it_by_lines): Replace the call
3777 to xfree to an equivalent call to bidi_unshelve_cache.
3778 (move_it_in_display_line_to): Fix logic of returning
412b6358 3779 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3780
e2e2423b
EZ
37812011-08-05 Eli Zaretskii <eliz@gnu.org>
3782
3783 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3784 came from a string character with a `cursor' property. (Bug#9229)
3785
ae9e757a
JD
37862011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3787
3788 * Makefile.in (LIB_PTHREAD): New variable.
3789 (LIBES): Add LIB_PTHREAD (Bug#9216).
3790
3791 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3792 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3793
213bd7f2
AS
37942011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3795
6b02f655 3796 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3797
99aaf75f
JD
37982011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3799
3800 * xterm.c (x_find_topmost_parent): New function.
3801 (x_set_frame_alpha): Find topmost parent window with
3802 x_find_topmost_parent and set the property there also (bug#9181).
3803 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3804
c74e9d86
PE
38052011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3806
3807 * callproc.c (Fcall_process): Avoid vfork clobbering
3808 the local vars buffer, coding_systems, current_dir.
3809
640c8776
SM
38102011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3811
3812 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3813
f26d0e4c
PE
38142011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3815
8a10d76c
PE
3816 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3817 so that it is not optimized away.
3818
f26d0e4c
PE
3819 * xdisp.c (compute_display_string_pos): Remove unused local.
3820
55439c61
EZ
38212011-08-02 Eli Zaretskii <eliz@gnu.org>
3822
3823 Fix slow cursor motion and scrolling in large buffers with
3824 selective display, like Org Mode buffers. (Bug#9218)
3825
3826 * dispextern.h (struct bidi_it): New member disp_prop_p.
3827
3828 * xdisp.c: Remove one-slot cache of display string positions.
3829 (compute_display_string_pos): Accept an additional argument
5e617bc2 3830 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3831 for a display string or property. If found, set DISP_PROP_P
3832 non-zero.
3833
3834 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3835 DISP_PROP_P, and pass it to compute_display_string_pos.
3836 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3837 non-zero. All callers of bidi_fetch_char changed.
3838
fb33fa43
SM
38392011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3840
3841 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3842
b099e063
DM
38432010-12-03 Don March <don@ohspite.net>
3844
3845 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3846 last character M-[char] is translated to ESC [char] (bug#7541).
3847
5cc7f7af
KH
38482011-08-02 Kenichi Handa <handa@m17n.org>
3849
d0fffa3f 3850 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3851
3852 * chartab.c (uniprop_table): Make it non-static.
3853
525d5e6e
EZ
38542011-08-01 Eli Zaretskii <eliz@gnu.org>
3855
3856 * xdisp.c (forward_to_next_line_start): Accept additional argument
3857 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3858 on the newline.
3859 (reseat_at_next_visible_line_start): Use the bidi iterator state
3860 returned by forward_to_next_line_start to restore the state of
3861 it->bidi_it after backing up to previous newline. (Bug#9212)
3862
31011111
AS
38632011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3864
3865 * regex.c (re_comp): Protoize.
3866 (re_exec): Fix return type.
3867 (regexec): Fix type of `ret'. (Bug#9203)
3868
476371c4
PE
38692011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3870
e5d76069
PE
3871 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3872 This is needed if max-image-size is a floating-point number.
3873
9a79b20c
AS
38742011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3875
3876 * print.c (print_object): Print empty symbol as ##.
3877
3878 * lread.c (read1): Read ## as empty symbol.
3879
d8c2fa78
AA
38802011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3881
3882 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3883 setting frame foreground color (Bug#9175).
3884 (x_set_background_color): Likewise.
3885
ffe57a7a
AA
3886 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3887 contents (Bug#9176).
3888 (EmacsTooltip -init): Remove bezels and add shadows to
3889 tooltip windows.
3890
bf3492a5
AA
3891 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3892 or scroll bar (Bug#8470).
3893
d55e9c53
AA
3894 * nsfont.m (nsfont_open): Remove assignment to voffset and
3895 unnecessary vars hshink, expand, hd, full_height, min_height.
3896 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3897
3898 * nsterm.h (nsfont_info): Remove voffset field.
3899
d8c2fa78 39002011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3901
3902 Implement strike-through and overline on NextStep (Bug#8863).
3903
3904 * nsfont.m (nsfont_open): Use underline position provided by font,
3905 instead of hard-coded value of 2.
3906 (nsfont_draw): Call ns_draw_text_decoration instead.
3907
3908 * nsterm.h: Add declaration for ns_draw_text_decoration.
3909
3910 * nsterm.m (ns_draw_text_decoration): New function for drawing
3911 underline, overline, and strike-through.
3912 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3913 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3914 accommodate underlining, etc.
4843aac3 3915
4cc60b9b
EZ
39162011-07-28 Eli Zaretskii <eliz@gnu.org>
3917
bc7ece87
EZ
3918 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3919 default.
4cc60b9b 3920
476371c4
PE
39212011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3922
66606eea
PE
3923 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3924 Without this fix, if a signal arrives just after memory fills up,
3925 'malloc' might be invoked reentrantly.
3926
476371c4
PE
3927 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3928 In other words, assume that every image size is allowed, on non-X
3929 hosts. This assumption is probably wrong, but it lets Emacs compile.
3930
f3fcc40d
AS
39312011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3932
3933 * regex.c (re_iswctype): Convert return values to boolean.
3934
350c992f
EZ
39352011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3936
3937 * xdisp.c (compute_display_string_pos): Don't use cached display
3938 string position if the buffer had its restriction changed.
3939 (Bug#9184)
3940
5266b4bb
PE
39412011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3942
3943 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3944
2573a837 39452011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3946
41f55ccd 3947 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3948
39e378da
PE
3949 * bidi.c: Integer size and overflow fixes.
3950 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3951 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3952 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3953 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3954 (bidi_find_other_level_edge):
3955 Use ptrdiff_t instead of EMACS_INT where either will do.
3956 This works better on 32-bit hosts configured --with-wide-int.
3957 (bidi_cache_ensure_space): Check for size-calculation overflow.
3958 Use % rather than repeated addition, for better worst-case speed.
3959 Don't set bidi_cache_size until after xrealloc returns, because it
3960 might not return.
3961 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3962 (bidi_cache_ensure_space): Also check that the bidi cache size
3963 does not exceed that of the largest Lisp string or buffer. See Eli
3964 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3965
5e927815
PE
3966 * alloc.c (__malloc_size_t): Remove.
3967 All uses replaced by size_t. See Andreas Schwab's note
3968 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3969
ca4aa935
PE
3970 * image.c: Improve checking for integer overflow.
3971 (check_image_size): Assume that f is nonnull, since
3972 it is always nonnull in practice. This is one less thing to
3973 worry about when checking for integer overflow later.
3974 (x_check_image_size): New function, which checks for integer
3975 overflow issues inside X.
3976 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3977 This removes the need for a memory_full check.
3978 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3979 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3980 (xbm_read_bitmap_data): Change locals back to 'int', since
3981 their values must fit in 'int'.
3982 (xpm_load_image, png_load, tiff_load):
3983 Invoke x_create_x_image_and_pixmap earlier,
3984 to avoid much needless work if the image is too large.
3985 (tiff_load): Treat overly large images as if
3986 x_create_x_image_and_pixmap failed, not as malloc failures.
3987 (gs_load): Use x_check_image_size.
3988
5f8f9cc2
PE
3989 * gtkutil.c: Omit integer casts.
3990 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3991 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3992
5adf60bc
PE
3993 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3994
c8907a93
PE
3995 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3996 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3997 would wrongly return t on a 64-bit host.
3998
e3c25c68
PE
3999 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
4000 The plain *_OVERFLOW macros run afoul of GCC bug 49705
4001 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
4002 and therefore cause GCC to emit a bogus diagnostic in some cases.
4003
3f791afe
PE
4004 * image.c: Integer signedness and overflow and related fixes.
4005 This is not an exhaustive set of fixes, but it's time to
4006 record what I've got.
4007 (lookup_pixel_color, check_image_size): Remove redundant decls.
4008 (check_image_size): Don't assume that arbitrary EMACS_INT values
4009 fit in 'int', or that arbitrary 'double' values fit in 'int'.
4010 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
4011 (tiff_load, imagemagick_load_image):
4012 Check for overflow in size calculations.
4013 (x_create_x_image_and_pixmap): Remove unnecessary test for
4014 xmalloc returning NULL; that can't happen.
4015 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
4016 (xpm_color_bucket): Use better integer hashing function.
4017 (xpm_cache_color): Don't possibly over-allocate memory.
4018 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
4019 (gif_memory_source):
4020 Use ptrdiff_t, not int or size_t, to record sizes.
4021 (png_load): Don't assume values greater than 2**31 fit in 'int'.
4022 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
4023 either works, as we prefer signed integers.
4024 (tiff_read_from_memory, tiff_write_from_memory):
4025 Return tsize_t, not size_t, since that's what the TIFF API wants.
4026 (tiff_read_from_memory): Don't fail simply because the read would
4027 go past EOF; instead, return a short read.
4028 (tiff_load): Omit no-longer-needed casts.
4029 (Fimagemagick_types): Don't assume size fits into 'int'.
4030
3cc5a532
PE
4031 Improve hashing quality when configured --with-wide-int.
4032 * fns.c (hash_string): New function, taken from sxhash_string.
4033 Do not discard information about ASCII character case; this
4034 discarding is no longer needed.
4035 (sxhash-string): Use it. Change sig to match it. Caller changed.
4036 * lisp.h: Declare it.
4037 * lread.c (hash_string): Remove, since we now use fns.c's version.
4038 The fns.c version returns a wider integer if --with-wide-int is
4039 specified, so this should help the quality of the hashing a bit.
4040
b312a492
PE
4041 * emacs.c: Integer overflow minor fix.
4042 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
4043 Define only if GNU_LINUX.
4044 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
4045
dfd153ae
PE
4046 * dispnew.c: Integer signedness and overflow fixes.
4047 Remove unnecessary forward decls, that were a maintenance hassle.
4048 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
4049 All uses changed.
4050 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
4051 (scrolling_window): Use ptrdiff_t, not int, for byte count.
4052 (prepare_desired_row, line_draw_cost):
4053 Use int, not unsigned, where either works.
4054 (save_current_matrix, restore_current_matrix):
4055 Use ptrdiff_t, not size_t, where either works.
4056 (init_display): Check for overflow more accurately, and without
4057 relying on undefined behavior.
4058
a81d11a3
PE
4059 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
4060 Remove, replacing with the new symbols in lisp.h. All uses changed.
4061 * fileio.c (make_temp_name):
4062 * filelock.c (lock_file_1, lock_file):
4063 * xdisp.c (message_dolog):
4064 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
4065 Use pMd etc. instead.
4066 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
4067 replacing the pWIDE etc. symbols removed from editfns.c.
4068
3300e6fd
PE
4069 * keyboard.h (num_input_events): Now uintmax_t.
4070 This is (very slightly) less likely to mess up due to wraparound.
4071 All uses changed.
4072
fd05c7e9
PE
4073 * buffer.c: Integer signedness fixes.
4074 (alloc_buffer_text, enlarge_buffer_text):
4075 Use ptrdiff_t rather than size_t when either will do, as we prefer
4076 signed integers.
4077
903fe15d
PE
4078 * alloc.c: Integer signedness and overflow fixes.
4079 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4080 (__malloc_size_t): Default to size_t, not to int.
4081 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4082 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4083 Prefer ptrdiff_t to size_t when either would do, as we prefer
4084 signed integers.
4085 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4086 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4087 Now const. Initialize with values that are in range even if char
4088 is signed.
4089 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4090 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4091 These functions do the right thing with sizes > 2**32.
4092 (check_depth): Now ptrdiff_t, not int.
4093 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4094 Adjust to new way of storing sizes. Check for size overflow bugs
4095 in rest of code.
4096 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4097 slightly wrong anyway, as it missed one instance of
4098 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4099 (refill_memory_reserve): Omit needless cast to size_t.
4100 (mark_object_loop_halt): Mark as externally visible.
4101
ac82cc6a
PE
4102 * xselect.c: Integer signedness and overflow fixes.
4103 (Fx_register_dnd_atom, x_handle_dnd_message):
4104 Use ptrdiff_t, not size_t, since we prefer signed.
4105 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4106 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4107 x_dnd_atoms_size and x_dnd_atoms_length.
4108
c2d1e36d
PE
4109 * doprnt.c: Prefer signed to unsigned when either works.
4110 * eval.c (verror):
4111 * doprnt.c (doprnt):
4112 * lisp.h (doprnt):
4113 * xdisp.c (vmessage):
4114 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4115 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4116 prefer signed arithmetic to avoid comparison confusion.
4117 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4118 but is a bit tricky.
4119
0e926e56
PE
4120 Assume freestanding C89 headers, string.h, stdlib.h.
4121 * data.c, doprnt.c, floatfns.c, print.c:
4122 Include float.h unconditionally.
4123 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4124 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4125 * regex.c: Likewise for stddef.h, string.h.
4126 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4127 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4128 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4129 (STDC_HEADERS): Remove obsolete defines.
4130 * sysdep.c: Include limits.h unconditionally.
4131
9cfdb3ec
PE
4132 Assume support for memcmp, memcpy, memmove, memset.
4133 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4134 * regex.c (memcmp, memcpy):
4135 Remove; we assume C89 now.
4136
4137 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4138 (__malloc_safe_bcopy): Remove; no longer needed.
4139
cf950e6b 4140 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
4141 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4142 well either way, and we prefer signed to unsigned.
4143
dbf38e02
LMI
41442011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4145
4146 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4147 closes the connection while we're reading (bug#9182).
4148
d6f0886c 41492011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 4150
d6f0886c
JD
4151 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4152 are specified (Bug#9168).
24e0f6b1 4153
2eb1f9e6
PE
41542011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4155
4156 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4157 Found by GCC static checking and --with-wide-int on a 32-bit host.
4158
22381272 41592011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
4160
4161 * xdisp.c (compute_display_string_pos): Fix logic of caching
4162 previous display string position. Initialize cached_prev_pos to
4163 -1. Fixes slow-down at the beginning of a buffer.
4164
f25e39b4
EZ
41652011-07-24 Eli Zaretskii <eliz@gnu.org>
4166
4167 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4168 for attrs[LFACE_FONTSET_INDEX].
4169
04c4b52e
PE
41702011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4171
4172 * xml.c (parse_region): Remove unused local
4173 that was recently introduced.
4174
c1734fbd
EZ
41752011-07-23 Eli Zaretskii <eliz@gnu.org>
4176
be18c5a5
EZ
4177 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4178 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4179
c1734fbd
EZ
4180 * xdisp.c (move_it_in_display_line_to): Record the best matching
4181 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
4182 exit if none of the characters scanned was an exact match.
4183 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
4184 when exact match is impossible due to invisible text, and the
4185 lines are truncated.
4186
a258d627
JD
41872011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4188
4189 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4190 for OSX >= 10.7.
4191
b6d5a689
EZ
41922011-07-22 Eli Zaretskii <eliz@gnu.org>
4193
0f74f785
EZ
4194 Fix a significant slow-down of cursor motion with C-n, C-p,
4195 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4196 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 4197 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
4198 (next_element_from_buffer): Call compute_stop_pos_backwards to
4199 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
4200 base_level_stop.
4201 (reseat): Don't look for prev_stop, as that could mean a very long
4202 run.
4203 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4204 <cached_disp_overlay_modiff>: Cache for last found display string
4205 position.
551918c1 4206 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
4207 about the same buffer in the same area of character positions, and
4208 the buffer wasn't changed since the time the display string
4209 position was cached.
551918c1 4210
b2d0c91a
EZ
42112011-07-22 Eli Zaretskii <eliz@gnu.org>
4212
4213 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4214 is an integer, which is important for empty lines. (Bug#9149)
4215
043604ee
CY
42162011-07-22 Chong Yidong <cyd@stupidchicken.com>
4217
4218 * frame.c (Fmodify_frame_parameters): In tty case, update the
4219 default face if necessary (Bug#4238).
4220
da4adb04
CY
42212011-07-21 Chong Yidong <cyd@stupidchicken.com>
4222
4223 * editfns.c (Fstring_to_char): No need to explain what a character
4224 is in the docstring (Bug#6576).
4225
9abd0532
LMI
42262011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4227
4228 * xml.c (parse_region): Make sure we always return a tree.
4229
36881d16
HK
42302011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4231
4232 * xml.c (parse_region): If a document contains only comments,
4233 return that, too.
4234
1e98674d
LMI
42352011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4236
4237 * xml.c (make_dom): Return comments, too.
4238
590bd467
PE
42392011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4240
4241 Port to OpenBSD.
4242 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4243 and the surrounding thread.
4244 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4245 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4246 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4247 timer goes off.
4248 * s/openbsd.h (BROKEN_SIGIO): Define.
4249 * unexelf.c (unexec) [__OpenBSD__]:
4250 Don't update the .mdebug section of the Alpha COFF symbol table.
4251
f41628b2
LMI
42522011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4253
4254 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4255 (bug#8460).
4256
b59b67c5
PE
42572011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4258
15e3a074
PE
4259 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4260 This fixes some race conditions on the permissions of any newly
4261 created file.
4262
41bed37d
PE
4263 * alloc.c (valid_pointer_p): Use pipe, not open.
4264 This fixes some permissions issues when debugging.
4265
b59b67c5
PE
4266 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4267 If fchown fails to set both uid and gid, try to set just gid,
4268 as that is sometimes allowed. Adjust the file's mode to eliminate
4269 setuid or setgid bits that are inappropriate if fchown fails.
4270
925a6be7
SM
42712011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4272
4273 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4274 to compare Lisp_Objects.
4275 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4276 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4277 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4278
52968808
AS
42792011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4280
0a6a104b
AS
4281 * lread.c (read_integer): Unread even EOF character.
4282 (read1): Likewise. Properly record start position of symbol.
4283
52968808
AS
4284 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4285 symbol character follows.
4286
9e381cdd
PE
42872011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4288
4289 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4290 This works around a problem with the previous change to Fcopy_file.
4291 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4292 and without this change, GCC might complain about discarding
4293 fchown's return value.
4294
b5641435
JB
42952011-07-16 Juanma Barranquero <lekktu@gmail.com>
4296
4297 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4298
a8031457
PE
42992011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4300
4301 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4302
dd889327
LMI
43032011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4304
750c33f7
LMI
4305 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4306 it's used from the C level.
4307
dd889327
LMI
4308 * process.c: Use the same condition for POLL_FOR_INPUT in both
4309 keyboard.c and process.c (bug#1858).
4310
87e86684
LM
43112011-07-09 Lawrence Mitchell <wence@gmx.li>
4312
4313 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4314 (Fgnutls_boot): Use it.
4315
64348f40
AS
43162011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4317
4318 * doc.c (Fsubstitute_command_keys): Revert last change.
4319
1d698799
LMI
43202011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4321
f863868c
LMI
4322 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4323 quotes the next character, and doesn't affect other longer
4324 sequences (bug#8935).
4325
1d698799
LMI
4326 * lread.c (syms_of_lread): Clarify that is isn't only
4327 `eval-buffer' and `eval-defun' that's affected by
4328 `lexical-binding' (bug#8460).
4329
aa4b6df6
EZ
43302011-07-15 Eli Zaretskii <eliz@gnu.org>
4331
4332 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 4333 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 4334
5d856da6
PE
43352011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4336
ad6042bb
PE
4337 Fix minor problems found by static checking.
4338 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4339 (elsz): Now a signed constant, not a size_t var. We prefer signed
4340 types to unsigned, to avoid integer comparison confusion. Without
4341 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4342 "cannot optimize loop, the loop counter may overflow", a symptom
4343 of the confusion.
f00bbb22 4344 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
4345 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4346
6468f31c
LMI
43472011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4348
49080b10
LMI
4349 * search.c (Fre_search_backward): Mention `case-fold-search' in
4350 all the re_search_* functions (bug#8138).
4351
6468f31c
LMI
4352 * keyboard.c (Fopen_dribble_file): Document when the file is
4353 closed (bug#8056).
4354
c965adc5
EZ
43552011-07-14 Eli Zaretskii <eliz@gnu.org>
4356
df9733bf
EZ
4357 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4358 bidi_cache_idx.
4359
0bb23927
EZ
4360 Support bidi reordering of display and overlay strings.
4361 * xdisp.c (compute_display_string_pos)
4362 (compute_display_string_end): Accept additional argument STRING.
4363 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4364 (reseat_to_string): Initialize bidi_it->string.s and
4365 bidi_it->string.schars.
4366 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
4367 NULL (avoids a crash in bidi_paragraph_init).
4368 Initialize itb.string.lstring.
0bb23927
EZ
4369 (init_iterator): Call bidi_init_it only of a valid
4370 buffer position was specified. Initialize paragraph_embedding to
4371 L2R.
4372 (reseat_to_string): Initialize the bidi iterator.
4373 (display_string): If we need to ignore text properties of
4374 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4375 original value of -1 will not work with bidi.)
4376 (compute_display_string_pos): First arg is now struct
4377 `text_pos *'; all callers changed. Support display properties on
4378 Lisp strings.
4379 (compute_display_string_end): Support display properties on Lisp
4380 strings.
4381 (init_iterator, reseat_1, reseat_to_string): Initialize the
4382 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4383 when iterating on a string not from display properties).
640c8776
SM
4384 (compute_display_string_pos, compute_display_string_end):
4385 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
4386 arrow keys.
4387 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
4388 base_level_stop; instead, set base_level_stop to BEGV.
4389 Fixes crashes in vertical-motion.
0bb23927
EZ
4390 (next_element_from_buffer): Improve commentary for when
4391 the iterator is before prev_stop.
4392 (init_iterator): Initialize bidi_p from the default value of
4393 bidi-display-reordering, not from buffer-local value. Use the
4394 buffer-local value only if initializing for buffer iteration.
4395 (handle_invisible_prop): Support invisible properties on strings
4396 that are being bidi-reordered.
4397 (set_iterator_to_next): Support bidi reordering of C strings and
4398 Lisp strings.
4399 (next_element_from_string): Support bidi reordering of Lisp
4400 strings.
4401 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
4402 (display_string): Support display of R2L glyph rows.
4403 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
4404 (init_iterator): Don't initialize it->bidi_p for strings
4405 here.
4406 (reseat_to_string): Initialize it->bidi_p for strings here.
4407 (next_element_from_string, next_element_from_c_string)
4408 (next_element_from_buffer): Add xassert's for correspondence
4409 between IT's object being iterated and it->bidi_it.string
4410 structure.
4411 (face_before_or_after_it_pos): Support bidi iteration.
4412 (next_element_from_c_string): Handle the case of the first string
4413 character that is not the first one in the visual order.
4414 (get_visually_first_element): New function, refactored from common
4415 parts of next_element_from_buffer, next_element_from_string, and
4416 next_element_from_c_string.
4417 (tool_bar_lines_needed, redisplay_tool_bar)
4418 (display_menu_bar): Force left-to-right direction. Add a FIXME
4419 comment for making that be controlled by a user option.
4420 (push_it, pop_it): Save and restore the state of the
4421 bidi iterator. Save and restore the bidi_p flag.
4422 (pop_it): Iterate out of display property for string iteration as
4423 well.
4424 (iterate_out_of_display_property): Support iteration over strings.
4425 (handle_single_display_spec): Set up it->bidi_it for iteration
4426 over a display string, and call bidi_init_it.
4427 (handle_single_display_spec, next_overlay_string)
4428 (get_overlay_strings_1, push_display_prop): Set up the bidi
4429 iterator for displaying display or overlay strings.
4430 (forward_to_next_line_start): Don't use the shortcut if
4431 bidi-iterating.
4432 (back_to_previous_visible_line_start): If handle_display_prop
4433 pushed the iterator stack, restore the internal state of the bidi
4434 iterator by calling bidi_pop_it same number of times.
4435 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4436 and we are bidi-iterating, don't decrement the iterator position;
4437 instead, set the first_elt flag in the bidi iterator, to produce
4438 the same effect.
4439 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4440 (push_display_prop): xassert that we are iterating a buffer.
4441 (push_it, pop_it): Save and restore paragraph_embedding member.
4442 (handle_single_display_spec, next_overlay_string)
4443 (get_overlay_strings_1, reseat_1, reseat_to_string)
4444 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4445 correctly. Don't assume unibyte strings are not bidi-reordered.
4446 (compute_display_string_pos)
4447 (compute_display_string_end): Fix handling the case of C string.
4448 (push_it, pop_it): Save and restore from_disp_prop_p.
4449 (handle_single_display_spec, push_display_prop): Set the
4450 from_disp_prop_p flag.
4451 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4452 (pop_it): Call iterate_out_of_display_property only if we are
4453 popping after iteration over a string that came from a display
4454 property. Fix a typo in popping stretch info. Add an assertion
4455 for verifying that the iterator position is in sync with the bidi
4456 iterator.
4457 (handle_single_display_spec, get_overlay_strings_1)
4458 (push_display_prop): Fix initialization of paragraph direction for
4459 string when that of the parent object is not yet determined.
4460 (reseat_1): Call bidi_init_it to resync the bidi
4461 iterator with IT's position. (Bug#7616)
4462 (find_row_edges): If ROW->start.pos gives position
4463 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4464 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4465 Reset the from_disp_prop_p flag.
4466 (SAVE_IT, RESTORE_IT): New macros.
4467 (pos_visible_p, face_before_or_after_it_pos)
4468 (back_to_previous_visible_line_start)
4469 (move_it_in_display_line_to, move_it_in_display_line)
4470 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4471 (try_scrolling, redisplay_window, display_line): Use them when
4472 saving a temporary copy of the iterator and restoring it back.
4473 (back_to_previous_visible_line_start, reseat_1)
4474 (init_iterator): Empty the bidi cache "stack".
4475 (move_it_in_display_line_to): If iterator ended up at
4476 EOL, but we never saw any buffer positions smaller than
4477 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4478 motion in bidi-reordered lines.
4479 (move_it_in_display_line_to): Record prev_method and prev_pos
4480 immediately before the call to set_iterator_to_next. Fixes cursor
4481 motion in bidi-reordered lines with stretch glyphs and strings
4482 displayed in margins. (Bug#8133) (Bug#8867)
4483 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4484 TO_CHARPOS.
640c8776
SM
4485 (pos_visible_p): Support positions in bidi-reordered lines.
4486 Save and restore bidi cache.
0bb23927
EZ
4487
4488 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4489 (bidi_paragraph_info): Delete unused struct.
4490 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4491 (bidi_cache_start): New variable.
4492 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4493 to zero.
4494 (bidi_cache_fetch_state, bidi_cache_search)
4495 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4496 (bidi_cache_find, bidi_peek_at_next_level)
4497 (bidi_level_of_next_char, bidi_find_other_level_edge)
4498 (bidi_move_to_visually_next): Compare cache index with
4499 bidi_cache_start rather than with zero.
4500 (bidi_fetch_char): Accept new argument STRING; all callers
4501 changed. Support iteration over a string. Support strings with
4502 display properties. Support unibyte strings. Fix the type of
4503 `len' according to what STRING_CHAR_AND_LENGTH expects.
4504 (bidi_paragraph_init, bidi_resolve_explicit_1)
4505 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4506 (bidi_level_of_next_char, bidi_move_to_visually_next):
4507 Support iteration over a string.
0bb23927
EZ
4508 (bidi_set_sor_type, bidi_resolve_explicit_1)
4509 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4510 can now be zero (for strings); special values 0 and -1 were
4511 changed to -1 and -2, respectively.
4512 (bidi_char_at_pos): New function.
4513 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4514 Call it instead of FETCH_MULTIBYTE_CHAR.
4515 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4516 initialized to valid values.
4517 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4518 values.
4519 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4520 the test for valid cached positions. Fix the logic for looking up
4521 the sentinel state in the cache. GCPRO the Lisp string we are
4522 iterating.
4523 (bidi_push_it, bidi_pop_it): New functions.
4524 (bidi_initialize): Initialize the bidi cache start stack pointer.
4525 (bidi_cache_ensure_space): New function, refactored from part of
4526 bidi_cache_iterator_state. Don't assume the required size is just
4527 one BIDI_CACHE_CHUNK away.
4528 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4529 (bidi_count_bytes, bidi_char_at_pos): New functions.
4530 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4531 always valid if bidi_cache_idx is valid.
4532 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4533 is valid if it's going to be used.
4534 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4535 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4536 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4537 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4538 (bidi_find_other_level_edge, bidi_cache_start_stack):
4539 All variables related to cache indices are now EMACS_INT.
c965adc5 4540
0bb23927
EZ
4541 * dispextern.h (struct bidi_string_data): New structure.
4542 (struct bidi_it): New member `string'. Make flag members be 1-bit
4543 fields, and put them last in the struct.
640c8776
SM
4544 (compute_display_string_pos, compute_display_string_end):
4545 Update prototypes.
0bb23927
EZ
4546 (bidi_push_it, bidi_pop_it): Add prototypes.
4547 (struct iterator_stack_entry): New members bidi_p,
4548 paragraph_embedding, and from_disp_prop_p.
4549 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4550 (bidi_shelve_cache, bidi_unshelve_cache):
4551 Declare prototypes.
0bb23927
EZ
4552
4553 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4554 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4555 and vector-like objects.
4556
4557 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4558 cache around display iteration.
4559
4560 * window.c (Fwindow_end, window_scroll_pixel_based)
4561 (displayed_window_lines, Frecenter): Save and restore the bidi
4562 cache around display iteration.
4563
3bbd2265
LMI
45642011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4565
4566 * editfns.c (Fdelete_region): Clarify the use of the named
4567 parameters (bug#6788).
4568
adc47434
MR
45692011-07-14 Martin Rudalics <rudalics@gmx.at>
4570
4571 * indent.c (Fvertical_motion): Set and restore w->pointm when
4572 saving and restoring the window's buffer (Bug#9006).
4573
837c31f8
LMI
45742011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4575
4576 * editfns.c (Fstring_to_char): Clarify just what is returned
4577 (bug#6576). Text by Eli Zaretskii.
4578
ac389d0c
JB
45792011-07-13 Juanma Barranquero <lekktu@gmail.com>
4580
4581 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4582
0be0ce47
EZ
45832011-07-13 Eli Zaretskii <eliz@gnu.org>
4584
4585 * buffer.c (mmap_find): Fix a typo.
4586
cd18e7e3
JB
45872011-07-13 Johan Bockgård <bojohan@gnu.org>
4588
4589 Fix execution of x selection hooks.
4590 * xselect.c (Qx_lost_selection_functions)
4591 (Qx_sent_selection_functions): New vars.
4592 (syms_of_xselect): DEFSYM them.
4593 (x_handle_selection_request): Pass Qx_sent_selection_functions
4594 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4595 (x_handle_selection_clear,x_clear_frame_selections):
4596 Pass Qx_lost_selection_functions rather than
4597 Vx_lost_selection_functions to Frun_hook_with_args.
4598
47ea7f44
PE
45992011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4600
ac389d0c 4601 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4602 The old code sometimes used this field without initializing it.
4603
47ea7f44
PE
4604 * alloc.c (gc_sweep): Don't read past end of array.
4605 In theory, the old code could also have corrupted Emacs internals,
4606 though it'd be very unlikely.
4607
bc985c87
AS
46082011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4609
4610 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4611 argument. (Bug#4026)
bc985c87 4612
0cf34688
LMI
46132011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4614
b3dadd76
LMI
4615 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4616 key" (bug#4257).
4617
0cf34688
LMI
4618 * window.c (Fset_window_start): Doc fix (bug#4199).
4619 (Fset_window_hscroll): Ditto.
4620
270768cd
PE
46212011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4622
077e3dda 4623 Fix minor new problems caught by GCC 4.6.1.
270768cd 4624 * term.c (init_tty): Remove unused local.
490011a6 4625 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4626 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4627 not used otherwise.
270768cd 4628
b1f58454
CY
46292011-07-12 Chong Yidong <cyd@stupidchicken.com>
4630
4631 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4632
22b9578d
LMI
46332011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4634
6e70ab07
LMI
4635 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4636 are the mini-buffer and the echo area (bug#3320).
4637
22b9578d
LMI
4638 * term.c (init_tty): Remove support for supdup, c10 and perq
4639 terminals, which are no longer supported (bug#1482).
4640
8974cc9f
JB
46412011-07-10 Johan Bockgård <bojohan@gnu.org>
4642
4643 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4644
a560d974
JD
46452011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4646
4647 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4648 for non-popups (Bug#3642).
4649
1dae0f0a
AS
46502011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4651
268c2c36 4652 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4653 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4654 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4655 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4656 * data.c (fmod): Likewise.
4657 * dispnew.c (swap_glyphs_in_rows): Likewise.
4658 * emacs.c (memory_warning_signal): Likewise.
4659 * floatfns.c (float_error): Likewise.
4660 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4661 (otf_open, font_otf_capability, generate_otf_features)
4662 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4663 Likewise.
4664 * image.c (pbm_read_file): Likewise.
4665 * indent.c (string_display_width): Likewise.
4666 * intervals.c (check_for_interval, search_for_interval)
4667 (inc_interval_count, count_intervals, root_interval)
4668 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4669 * lread.c (defalias): Likewise.
268c2c36 4670 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4671 * regex.c (set_image_of_range_1, set_image_of_range)
4672 (regex_grow_registers): Likewise.
4673 * sysdep.c (strerror): Likewise.
4674 * termcap.c (valid_filename_p, tprint, main): Likewise.
4675 * tparam.c (main): Likewise.
4676 * unexhp9k800.c (run_time_remap, save_data_space)
4677 (update_file_ptrs, read_header, write_header, calculate_checksum)
4678 (copy_file, copy_rest, display_header): Likewise.
4679 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4680 Likewise.
4681 * xdisp.c (check_it): Likewise.
4682 * xfaces.c (register_color, unregister_color, unregister_colors):
4683 Likewise.
4684 * xfns.c (print_fontset_result): Likewise.
4685 * xrdb.c (member, fatal, main): Likewise.
4686
99033785
PE
46872011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4688
4689 Fix minor problems found by static checking (Bug#9031).
4690 * chartab.c (char_table_set_range, map_sub_char_table):
4691 Remove unused locals.
4692 (uniprop_table): Now static.
4693 * composite.c (_work_char): Remove unused static var.
4694
9cb2ac56
JB
46952011-07-09 Juanma Barranquero <lekktu@gmail.com>
4696
4697 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4698
f25661f0
JD
46992011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4700
4701 * gtkutil.c (qttip_cb): Remove code without function.
4702
8278c4fe
EZ
47032011-07-09 Eli Zaretskii <eliz@gnu.org>
4704
4705 * w32.c (pthread_sigmask): New stub.
4706
1692ae2d 47072011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4708
8a6ebd58 4709 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4710 sigprocmask is portable only for single-threaded applications, and
4711 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4712 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4713 (LIBES): Use it.
4714 * callproc.c (Fcall_process):
4715 * process.c (create_process):
4716 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4717 Use pthread_sigmask, not sigprocmask.
123403e4 4718
1b854618
JD
47192011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4720
4721 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4722 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4723 wrong (Bug#8591).
4724
3fe4b549
JD
47252011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4726
0ce7e563
JD
4727 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4728 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4729 (xg_hide_tooltip): Fix comment.
4730
3fe4b549
JD
4731 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4732 in registerServicesMenuSendTypes.
4733 (validRequestorForSendType): Don't check ns_return_types.
4734
4735 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4736 ns_return_type.
4737
5df75e47
JR
47382011-07-08 Jason Rumney <jasonr@gnu.org>
4739
22610910
JR
4740 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4741 SH_SHOW for hidden windows (Bug#5482).
4742
5df75e47
JR
4743 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4744 frame struct members of non-existent frames (Bug#6284).
4745
699c10bd
JD
47462011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4747
4393663b
JD
4748 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4749 variable firstTime not needed on OSX >= 10.6.
4750 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4751 >= 10.5. Use setKnobProportion, setDoubleValue.
4752
4753 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4754 (MAC_OS_X_VERSION_10_5): Define if not defined.
4755 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4756 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4757 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4758
4759 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4760 cString and lossyCString on OSX >= 10.4
4761
58179cce 4762 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4763 sizeToFit on OSX >= 10.2.
4764
4765 * nsimage.m (allocInitFromFile): Don't use deprecated method
4766 bestRepresentationForDevice on OSX >= 10.6.
4767
4768 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4769 to avoid warning.
4770
4771 * emacs.c: Declare unexec_init_emacs_zone.
4772
a63e0781
JD
4773 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4774
699c10bd
JD
4775 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4776
4777 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4778 on svcsMenu (Bug#8842).
4779
4780 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4781 ns_return_types.
4782 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4783
4784 * nsterm.m (QUTF8_STRING): Declare.
4785 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4786 (validRequestorForSendType): Return type is (id).
4787 Change indexOfObjectIdenticalTo to indexOfObject.
4788 Check if we have local selection before returning self (Bug#8842).
4789 (writeSelectionToPasteboard): Put local selection into paste board
4790 if we have a local selection (Bug#8842).
4791 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4792
4793 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4794 (ns_get_local_selection): Declare.
4795
54e10184
LMI
47962011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4797
9888ff71
LMI
4798 * keymap.c (describe_map_tree): Don't insert a double newline at
4799 the end of the buffer (bug#1169) and return whether we inserted
4800 something.
4801
54e10184
LMI
4802 * callint.c (Fcall_interactively): Change "reading args" to
4803 "providing args" to try to clarify what it does (bug#1010).
4804
15fa4783
KH
48052011-07-07 Kenichi Handa <handa@m17n.org>
4806
4807 * composite.c (composition_compute_stop_pos): Ignore a static
4808 composition starting before CHARPOS (Bug#8915).
4809
4810 * xdisp.c (handle_composition_prop): Likewise.
4811
a8815b00
EZ
48122011-07-07 Eli Zaretskii <eliz@gnu.org>
4813
4814 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4815 (Bug#9015)
4816
ef7b981d 48172011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4818
4819 * character.h (unicode_category_t): New enum type.
4820
4821 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4822 (Qchar_code_property_table): New variable.
4823 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4824 (UNIPROP_COMPRESSED_FORM_P): New macros.
4825 (char_table_ascii): Uncompress the compressed values.
4826 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4827 Uncompress the compressed values.
ac389d0c 4828 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4829 (char_table_ref_and_range): Uncompress the compressed values.
4830 (sub_char_table_set): New arg is_uniprop. Callers changed.
4831 Uncompress the compressed values.
4832 (sub_char_table_set_range): Args changed. Callers changed.
4833 (char_table_set_range): Adjuted for the above change.
4834 (map_sub_char_table): Delete args default_val and parent. Add arg
4835 top. Give decoded values to a Lisp function.
640c8776 4836 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4837 values to a Lisp function. Gcpro more variables.
4838 (uniprop_table_uncompress)
4839 (uniprop_decode_value_run_length): New functions.
4840 (uniprop_decoder, uniprop_decoder_count): New variables.
4841 (uniprop_get_decoder, uniprop_encode_value_character)
4842 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4843 New functions.
4844 (uniprop_encoder, uniprop_encoder_count): New variables.
4845 (uniprop_get_encoder, uniprop_table)
4846 (Funicode_property_table_internal, Fget_unicode_property_internal)
4847 (Fput_unicode_property_internal): New functions.
4848 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4849 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4850 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4851 char-code-property-alist.
4852
640c8776 4853 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4854 Vunicode_category_table.
4855
640c8776 4856 * font.c (font_range): Adjust for the change of
c805dec0
KH
4857 Vunicode_category_table.
4858
76b397fb
DN
48592011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4860
4861 * m/iris4d.h: Remove file, move contents ...
4862 * s/irix6-5.h: ... here.
4863
22b4128e
PE
48642011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4865
4866 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4867 * alloc.c (mark_buffer):
4868 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4869 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4870 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4871 This isn't true in general, and it's particularly not true
4872 if Emacs is configured with --with-wide-int.
4873 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4874 New macros, used in the buffer.c change.
4875
869795d6
JD
48762011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4877
4878 * xsettings.c: Use both GConf and GSettings if both are available.
4879 (store_config_changed_event): Add comment.
4880 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4881 (store_tool_bar_style_changed): New functions.
5e617bc2 4882 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4883 (struct xsettings): Move font inside HAVE_XFT.
4884 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4885 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4886 Move inside HAVE_XFT.
640c8776 4887 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4888 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4889 also.
4890 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4891 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4892 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4893 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4894 (parse_settings): Move check for font inside HAVE_XFT.
4895 (read_settings, apply_xft_settings): Add comment.
4896 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4897 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4898 call store_font_name_changed.
4899 (xft_settings_event): Add comment.
4900 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4901 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4902 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4903 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4904 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4905 (xsettings_get_system_font, xsettings_get_system_normal_font):
4906 Add comment.
869795d6 4907
d8ed26bd
PE
49082011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4909
4910 Random fixes. E.g., (random) never returned negative values.
4911 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4912 subseconds part to the entropy, as that's a bit more random.
4913 Prefer signed to unsigned, since the signedness doesn't matter and
4914 in general we prefer signed. When given a limit, use a
4915 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4916 latter isn't right if USE_2_TAGS_FOR_INTS.
4917 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4918 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4919
cabf1cac
SM
49202011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4921
4922 * textprop.c (text_property_stickiness):
4923 Obey Vtext_property_default_nonsticky.
4924 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4925 * w32fns.c (syms_of_w32fns):
4926 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4927
6e9b2be9
PE
49282011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4929
4930 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4931 This is more efficient than Ffile_directory_p and avoids a minor race.
4932
90186c68
LMI
49332011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4934
7c301272
LMI
4935 * buffer.c (Foverlay_put): Say what the return value is
4936 (bug#7835).
4937
c4f2d8d4
LMI
4938 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4939 is a directory before asking whether to use the file name
4940 (bug#7564).
ad637907
LMI
4941 (barf_or_query_if_file_exists): Make the "File is a directory"
4942 error be more correct.
c4f2d8d4 4943
90186c68
LMI
4944 * fns.c (Frequire): Remove the mention of the .gz files, since
4945 that's installation-specific, but keep the mention of
4946 `get-load-suffixes'.
4947
da64016e
PE
49482011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4949
4950 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4951 Report string overflow if the output is too long.
4952
7d47b580
JB
49532011-07-04 Juanma Barranquero <lekktu@gmail.com>
4954
a555cb87
JB
4955 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4956 (syms_of_gnutls): Remove duplicate DEFSYM for
4957 Qgnutls_bootprop_verify_hostname_error, an error for
4958 Qgnutls_bootprop_verify_error (which is no longer used).
4959
7d47b580
JB
4960 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4961 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4962 Also (re)move comments that are misplaced or no longer relevant.
4963
1e49bfab
LMI
49642011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4965
4966 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4967
1485f4c0
CY
49682011-07-03 Chong Yidong <cyd@stupidchicken.com>
4969
4970 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4971 and background color parameters if they have been changed.
4972
a9ab721e
LMI
49732011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4974
4975 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4976
cf7cff57
PE
49772011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4978
2e13213d
PE
4979 * xsettings.c (SYSTEM_FONT): Define only when used.
4980 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4981
cf7cff57
PE
4982 * keymap.c (access_keymap_1): Now static.
4983
7a8e04f7
CY
49842011-07-02 Chong Yidong <cyd@stupidchicken.com>
4985
4986 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4987 leave any prefix arg for the up event (Bug#1586).
4988
61352f62
LMI
49892011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4990
69bb1ef7
LMI
4991 * lread.c (syms_of_lread): Mention single symbols defined by
4992 `defvar' or `defconst' (bug#7154).
4993
61352f62 4994 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4995 (Frequire): Mention get-load-suffixes.
61352f62 4996
28545e04
MR
49972011-07-02 Martin Rudalics <rudalics@gmx.at>
4998
4999 * window.h (window): Remove clone_number slot.
5000 * window.c (Fwindow_clone_number, Fset_window_clone_number):
5001 Remove.
5002 (make_parent_window, make_window, saved_window)
5003 (Fset_window_configuration, save_window_save): Don't deal with
5004 clone numbers.
5005 * buffer.c (Qclone_number): Remove declaration.
5006 (sort_overlays, overlay_strings): Don't deal with clone numbers.
5007
3349e122
SM
50082011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
5009
5010 Add multiple inheritance to keymaps.
5011 * keymap.c (Fmake_composed_keymap): New function.
5012 (Fset_keymap_parent): Simplify.
5013 (fix_submap_inheritance): Remove.
5014 (access_keymap_1): New function extracted from access_keymap to handle
5015 embedded parents and handle lists of maps.
5016 (access_keymap): Use it.
5017 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
5018 (Fcopy_keymap): Handle embedded parents.
5019 (Fcommand_remapping, define_as_prefix): Simplify.
5020 (Fkey_binding): Simplify.
5021 (syms_of_keymap): Move minibuffer-local-completion-map,
5022 minibuffer-local-filename-completion-map,
5023 minibuffer-local-must-match-map, and
5024 minibuffer-local-filename-must-match-map to Elisp.
5025 (syms_of_keymap): Defsubr make-composed-keymap.
5026 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
5027 (parse_menu_item): Trivial simplification.
5028
3279eb87
GM
50292011-07-01 Glenn Morris <rgm@gnu.org>
5030
5031 * Makefile.in (SETTINGS_LIBS): Fix typo.
5032
4550efdf
KI
50332011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
5034
5035 * coding.c (Fencode_coding_string): Record the last coding system
5036 used, as the function doc string says (bug#8738).
5037
0949d2b6
JD
50382011-07-01 Jan Djärv <jan.h.d@swipnet.se>
5039
5040 * xsettings.c (store_monospaced_changed): Take new font as arg and
5041 check for change against current_mono_font.
5042 (EMACS_TYPE_SETTINGS): Remove this and related defines.
5043 (emacs_settings_constructor, emacs_settings_get_property)
5044 (emacs_settings_set_property, emacs_settings_class_init)
5045 (emacs_settings_init, gsettings_obj): Remove.
5046 (something_changedCB): New function for HAVE_GSETTINGS.
5047 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
5048 with value as argument.
5049 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
5050 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 5051 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
5052 "changed".
5053
5054 * xgselect.c: Add defined (HAVE_GSETTINGS).
5055 (xgselect_initialize): Ditto.
5056
5057 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
5058 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
5059 xg_select.
5060
bbc6b304
PE
50612011-07-01 Paul Eggert <eggert@cs.ucla.edu>
5062
5063 * eval.c (struct backtrace): Simplify and port the data structure.
5064 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
5065 signed bit field, as this assumption is not portable and it makes
5066 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
5067 "char debug_on_exit : 1" as this is not portable either; instead,
5068 use the portable "unsigned int debug_on_exit : 1". Remove unused
5069 member evalargs. Remove obsolete comments about cc bombing out.
5070
9851bfc5
JD
50712011-06-30 Jan Djärv <jan.h.d@swipnet.se>
5072
51bb811f 5073 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
5074 Let HAVE_GSETTINGS override HAVE_GCONF.
5075 (store_monospaced_changed): New function.
5076 (EMACS_SETTINGS): A new type derived from GObject to handle
5077 GSettings notifications.
5078 (emacs_settings_constructor, emacs_settings_get_property)
5079 (emacs_settings_set_property, emacs_settings_class_init):
5080 New functions.
5081 (gsettings_client, gsettings_obj): New variables.
5082 (GSETTINGS_SCHEMA): New define.
5083 (something_changedCB): Call store_monospaced_changed.
5084 (init_gsettings): New function.
5085 (xsettings_initialize): Call init_gsettings.
5086 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5087 to NULL.
5088
640c8776 5089 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
5090 GCONF_CFLAGS/LIBS.
5091
5386012d
MR
50922011-06-29 Martin Rudalics <rudalics@gmx.at>
5093
5094 * window.c (resize_root_window, grow_mini_window)
5095 (shrink_mini_window): Rename Qresize_root_window to
5096 Qwindow_resize_root_window and Qresize_root_window_vertically to
5097 Qwindow_resize_root_window_vertically.
5098
f13e0b08
PE
50992011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5100
5101 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5102
94515237
JB
51032011-06-27 Juanma Barranquero <lekktu@gmail.com>
5104
5105 * makefile.w32-in: Redesign dependencies so they reflect more
5106 clearly which files are directly included by each source file,
5107 and not through other includes.
5108
e43b6e43
MR
51092011-06-27 Martin Rudalics <rudalics@gmx.at>
5110
5111 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5112 (sort_overlays, overlay_strings): When an overlay's clone number
5113 matches the window's clone number process the overlay even if
5114 the overlay's window property doesn't match the current window.
5115
d68443dc
MR
5116 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5117 (Fwindow_hchild): Rename to Fwindow_left_child.
5118 (Fwindow_next): Rename to Fwindow_next_sibling.
5119 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
5120 (resize_window_check): Rename to window_resize_check.
5121 (resize_window_apply): Rename to window_resize_apply.
5122 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5123 (Fdelete_other_windows_internal, resize_frame_windows)
5124 (Fsplit_window_internal, Fdelete_window_internal)
5125 (grow_mini_window, shrink_mini_window)
5126 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 5127
c7e73be5
JD
51282011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5129
5130 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5131 (emacs_fixed_set_min_size): Remove.
5132 (emacs_fixed_new): Take frame as argument.
5133
5134 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5135 (_EmacsFixedPrivate): Remove minwidth/height.
5136 Add struct frame *f.
5137 (emacs_fixed_init): Initialize priv->f.
5138 (get_parent_class, emacs_fixed_set_min_size): Remove.
5139 (emacs_fixed_new): Set priv->f to argument.
5140 (emacs_fixed_get_preferred_width)
5141 (emacs_fixed_get_preferred_height): Use min_width/height from
5142 frames size_hint to set minimum and natural (Bug#8919).
5143 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5144 and use min_width/height from frames size_hint to set
5145 min_width/height (Bug#8919).
5146
5147 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
5148 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5149 Fix indentation.
c7e73be5 5150
cf99dcf8
EZ
51512011-06-26 Eli Zaretskii <eliz@gnu.org>
5152
5153 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5154 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5155 called at ZV.
5156
029529ac
CY
51572011-06-26 Chong Yidong <cyd@stupidchicken.com>
5158
5159 * process.c (wait_reading_process_output): Bypass select if
5160 waiting for a cell while ignoring keyboard input, and input is
5161 pending. Suggested by Jan Djärv (Bug#8869).
5162
7a7ef429
PE
51632011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5164
5165 Use gnulib's dup2 module instead of rolling our own.
5166 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5167
11fdef7d 51682011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
5169
5170 * dispnew.c (scrolling_window): Before scrolling, turn off a
5171 mouse-highlight in the window being scrolled.
5172
cd3520a4
JB
51732011-06-24 Juanma Barranquero <lekktu@gmail.com>
5174
5175 Move DEFSYM to lisp.h and use everywhere.
5176
5177 * character.h (DEFSYM): Move declaration...
5178 * lisp.h (DEFSYM): ...here.
5179
5180 * gnutls.c:
5181 * minibuf.c:
5182 * w32menu.c:
5183 * w32proc.c:
5184 * w32select.c: Don't include character.h.
5185
5186 * alloc.c (syms_of_alloc):
5187 * buffer.c (syms_of_buffer):
5188 * bytecode.c (syms_of_bytecode):
5189 * callint.c (syms_of_callint):
5190 * casefiddle.c (syms_of_casefiddle):
5191 * casetab.c (init_casetab_once):
5192 * category.c (init_category_once, syms_of_category):
5193 * ccl.c (syms_of_ccl):
5194 * cmds.c (syms_of_cmds):
5195 * composite.c (syms_of_composite):
5196 * dbusbind.c (syms_of_dbusbind):
5197 * dired.c (syms_of_dired):
5198 * dispnew.c (syms_of_display):
5199 * doc.c (syms_of_doc):
5200 * editfns.c (syms_of_editfns):
5201 * emacs.c (syms_of_emacs):
5202 * eval.c (syms_of_eval):
5203 * fileio.c (syms_of_fileio):
5204 * fns.c (syms_of_fns):
5205 * frame.c (syms_of_frame):
5206 * fringe.c (syms_of_fringe):
5207 * insdel.c (syms_of_insdel):
5208 * keymap.c (syms_of_keymap):
5209 * lread.c (init_obarray, syms_of_lread):
5210 * macros.c (syms_of_macros):
5211 * msdos.c (syms_of_msdos):
5212 * print.c (syms_of_print):
5213 * process.c (syms_of_process):
5214 * search.c (syms_of_search):
5215 * sound.c (syms_of_sound):
5216 * syntax.c (init_syntax_once, syms_of_syntax):
5217 * terminal.c (syms_of_terminal):
5218 * textprop.c (syms_of_textprop):
5219 * undo.c (syms_of_undo):
5220 * w32.c (globals_of_w32):
5221 * window.c (syms_of_window):
5222 * xdisp.c (syms_of_xdisp):
5223 * xfaces.c (syms_of_xfaces):
5224 * xfns.c (syms_of_xfns):
5225 * xmenu.c (syms_of_xmenu):
5226 * xsettings.c (syms_of_xsettings):
5227 * xterm.c (syms_of_xterm): Use DEFSYM.
5228
4228cf16
TZ
52292011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5230
cd3520a4 5231 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 5232
7fcccf1e
PE
52332011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5234
7efb4e0e
PE
5235 Integer and buffer overflow fixes (Bug#8873).
5236
ff5844ad
PE
5237 * print.c (printchar, strout): Check for string overflow.
5238 (PRINTPREPARE, printchar, strout):
5239 Don't set size unless allocation succeeds.
5240
90532f02
PE
5241 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5242 for sizes. Check for string overflow more accurately.
5243 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5244
6d84508d
PE
5245 * macros.c: Integer and buffer overflow fixes.
5246 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5247 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5248 Use ptrdiff_t, not int, for sizes.
5249 Don't increment bufsize until after realloc succeeds.
5250 Check for size-calculation overflow.
5251 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5252
437b2cb4
PE
5253 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5254
8b9ac8b4
PE
5255 * lread.c: Integer overflow fixes.
5256 (read_integer): Radix is now EMACS_INT, not int,
5257 to improve quality of diagnostics for out-of-range radices.
5258 Calculate buffer size correctly for out-of-range radices.
5259 (read1): Check for integer overflow in radices, and in
5260 read-circle numbers.
82cb60d3
PE
5261 (read_escape): Avoid int overflow.
5262 (Fload, openp, read_buffer_size, read1)
5263 (substitute_object_recurse, read_vector, read_list, map_obarray):
5264 Use ptrdiff_t, not int, for sizes.
5265 (read1): Use EMACS_INT, not int, for sizes.
20270765 5266 Check for size overflow.
8b9ac8b4 5267
7fcccf1e
PE
5268 * image.c (cache_image): Check for size arithmetic overflow.
5269
bfbbd7e7
PE
5270 * lread.c: Integer overflow issues.
5271 (saved_doc_string_size, saved_doc_string_length)
5272 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5273 Now ptrdiff_t, not int.
5274 (read1): Don't assume doc string length fits in int. Check for
5275 out-of-range doc string lengths.
5276 (read_list): Don't assume file position fits in int.
39019e54 5277 (read_escape): Check for hex character overflow.
bfbbd7e7 5278
4e323265
LL
52792011-06-22 Leo Liu <sdl.web@gmail.com>
5280
5281 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5282 Move to minibuffer.el.
5283
85fece3e
PE
52842011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5285
20b84ce9 5286 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
5287 The following patches are for when GLYPH_DEBUG && !XASSERT.
5288 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5289 * dispnew.c (flush_stdout):
5290 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5291 Mark as externally visible.
5292 * dispnew.c (check_window_matrix_pointers): Now static.
5293 * dispnew.c (window_to_frame_vpos):
5294 * xfns.c (unwind_create_frame):
5295 * xterm.c (x_check_font): Remove unused local.
5296 * scroll.c (CHECK_BOUNDS):
5297 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5298 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5299 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5300 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5301 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5302 Now static.
5303 (debug_method_add): Use va_list and vsprintf rather than relying
5304 on undefined behavior with wrong number of arguments.
5305 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5306 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5307 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5308 since we're not interested in debugging glyphs with old libraries.
5309 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5310 GCC 4.6.0's static checking.
5311
0766b489
PE
53122011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5313
31fd4b32
PE
5314 Integer overflow and signedness fixes (Bug#8873).
5315 A few related buffer overrun fixes, too.
5316
b79e8648
PE
5317 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5318
0766b489
PE
5319 * dispextern.h (struct face.stipple):
5320 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5321 (x_bitmap_mask, x_allocate_bitmap_record)
5322 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5323 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5324 (x_create_bitmap_from_xpm_data):
5325 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5326 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5327 (.bitmaps_last):
5328 * xfaces.c (load_pixmap):
5329 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5330 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5331 (.bitmaps_last, struct x_output.icon_bitmap):
5332 Use ptrdiff_t, not int, for bitmap indexes.
5333 (x_allocate_bitmap_record): Check for size overflow.
5334 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5335
b081724f
PE
5336 Use ptrdiff_t, not int, for overlay counts.
5337 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5338 * editfns.c (overlays_around, get_pos_property):
5339 * textprop.c (get_char_property_and_overlay):
5340 * xdisp.c (next_overlay_change, note_mouse_highlight):
5341 * xfaces.c (face_at_buffer_position):
21514da7
PE
5342 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5343 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5344 (Fnext_overlay_change, Fprevious_overlay_change)
5345 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 5346 Use ptrdiff_t, not int, for sizes.
21514da7 5347 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 5348
3de73e5e
PE
5349 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5350
2606c57b
PE
5351 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5352 (x_session_initialize): Do not assume string length fits in int.
5353
aaafe47a
PE
5354 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5355 This is unlikely, but can occur if DPI is outlandish.
5356
2674ddc8 5357 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
5358 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5359
28154962
PE
5360 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5361 * xrdb.c (magic_file_p, search_magic_path):
5362 Omit last arg SUFFIX; it was always 0. All callers changed.
5363 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5364
7de51af5
PE
5365 * xfont.c (xfont_match): Avoid need for strlen.
5366
25ed6cc3
PE
5367 * xfns.c: Don't assume strlen fits in int.
5368 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5369
4eab31dd
PE
5370 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5371 not unsigned long, as we prefer signed integers. All callers changed.
5372 Detect integer overflow in repeat count.
5373 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 5374 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 5375
171e2a58
PE
5376 * termcap.c: Don't assume sizes fit in int and never overflow.
5377 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5378 (gobble_line): Check for size-calculation overflow.
5379
ad39faca 5380 * minibuf.c (Fread_buffer):
6e5bb2dc 5381 * lread.c (intern, intern_c_string):
74ca2eb3
PE
5382 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5383 Don't assume string length fits in int.
5384
52c61c22 5385 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
5386 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5387
b5b8c9e5
PE
5388 * font.c: Don't assume string length fits in int.
5389 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5390 Use ptrdiff_t, not int.
ccd6111c
PE
5391 (font_intern_prop): Don't assume string length fits in int.
5392 Don't assume integer property fits in fixnum.
5393 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 5394
882f0d81 5395 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 5396 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
5397 Reformulate so as not to need the command string.
5398 Invoke gzip -cd rather than gunzip, as it's more portable.
5399 (lock_info_type, lock_file_1, lock_file):
5400 Don't assume pid_t and time_t fit in unsigned long.
5401 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5402 (current_lock_owner): Prefer signed type for sizes.
5403 Use memcpy, not strncpy, where memcpy is what is really wanted.
5404 Don't assume (via atoi) that time_t and pid_t fit in int.
5405 Check for time_t and/or pid_t out of range, e.g., via a network share.
5406 Don't alloca where an auto var works fine.
5407
93f4cf88
PE
5408 * fileio.c: Fix some integer overflow issues.
5409 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5410 Don't assume string length fits in int.
5411 (directory_file_name): Don't assume string length fits in long.
5412 (make_temp_name): Don't assume pid fits in int, or that its print
5413 length is less than 20.
5414
f3e92b69
PE
5415 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5416
1bfdaf10
PE
5417 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5418
35016e9a
PE
5419 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5420
3d1e65a1
PE
5421 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5422 We prefer signed integers, even for size calculations.
5423
0b963a93
PE
5424 * emacs.c: Don't assume string length fits in 'int'.
5425 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5426 (main): Don't invoke strlen when not needed.
5427
573f4b54
PE
5428 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5429 (XD_DEBUG_MESSAGE): Don't waste a byte.
5430
989f33ba
PE
5431 * callproc.c (getenv_internal_1, getenv_internal)
5432 (Fgetenv_internal):
965d34eb
PE
5433 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5434
e4d29b33
PE
5435 * lread.c (invalid_syntax): Omit length argument.
5436 All uses changed. This doesn't fix a bug, but it simplifies the
5437 code away from its former Hollerith-constant appearance, and it's
5438 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5439 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5440
eb49b136
PE
5441 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5442 This didn't break anything, but it didn't help either.
5443 It's confusing to put a bogus integer in a place where the actual
5444 value does not matter.
9f62aeb1 5445 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5446 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5447
15375a22
PE
5448 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5449 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5450 implementation.
b61cc01c
PE
5451 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5452 We prefer signed types, and the value cannot exceed the EMACS_INT
5453 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5454 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5455 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5456 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5457
53b2623d
PE
5458 * indent.c (sane_tab_width): New function.
5459 (current_column, scan_for_column, Findent_to, position_indentation)
5460 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5461 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5462
51cab52b 5463 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5464
f2ed8a70
PE
5465 * lisp.h (lint_assume): New macro.
5466 * composite.c (composition_gstring_put_cache):
5467 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5468
abe80cc6
PE
5469 * editfns.c, insdel.c:
5470 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5471
b02c740e
PE
5472 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5473
ebc96716
PE
5474 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5475
b4e50fa0 5476 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5477 Use much-faster test for byte-length change.
311d5d7c 5478 Don't assume string byte-length fits in 'int'.
a4cf38e4 5479 Check that character arg fits in 'int'.
85461888 5480 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5481
c0c1ee9f
PE
5482 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5483
a498d7f4
PE
5484 * fns.c (concat): Catch string overflow earlier.
5485 Do not rely on integer wraparound.
5486
51cab52b
PE
5487 * dispextern.h (struct it.overlay_strings_charpos)
5488 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5489 * xdisp.c (forward_to_next_line_start)
5490 (back_to_previous_visible_line_start)
5491 (reseat_at_next_visible_line_start, next_element_from_buffer):
5492 Don't arbitrarily truncate the value of 'selective' to int.
5493
76031fad
PE
5494 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5495
5eb55db9
PE
5496 * composite.c: Don't truncate sizes to 'int'.
5497 (composition_gstring_p, composition_reseat_it)
5498 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5499 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5500 not EMACS_UINT, for indexes.
5eb55db9 5501
0703a717
PE
5502 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5503
d6202519
PE
5504 * buffer.c: Include <verify.h>.
5505 (struct sortvec.priority, struct sortstr.priority):
8961a454 5506 Now EMACS_INT, not int.
c20998a7 5507 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5508 (struct sortstr.size, record_overlay_string)
5509 (struct sortstrlist.size, struct sortlist.used):
5510 Don't truncate size to int.
5511 (record_overlay_string): Check for size-calculation overflow.
d6202519 5512 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5513
d5a19415
JM
55142011-06-22 Jim Meyering <meyering@redhat.com>
5515
029529ac 5516 Don't leak an XBM-image-sized buffer
d5a19415
JM
5517 * image.c (xbm_load): Free the image buffer after using it.
5518
a9041e6c
PE
55192011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5520
5521 Port to Sun C.
5522 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5523 that Sun C diagnosed.
5524 * fns.c (secure_hash): Fix pointer signedness issue.
5525 * intervals.c (static_offset_intervals): New function.
5526 (offset_intervals): Use it.
5527
7f3f739f
LL
55282011-06-21 Leo Liu <sdl.web@gmail.com>
5529
5530 * deps.mk (fns.o):
5531 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5532 sha512.h.
5533
5534 * fns.c (secure_hash): Rename from crypto_hash_function and change
5535 the first arg to accept symbols.
5b66d427 5536 (Fsecure_hash): New primitive.
7f3f739f
LL
5537 (syms_of_fns): New symbols.
5538
76147d94
DD
55392011-06-20 Deniz Dogan <deniz@dogan.se>
5540
5541 * process.c (Fset_process_buffer): Clarify return value in
5542 docstring.
5543
7d7d0045
CY
55442011-06-18 Chong Yidong <cyd@stupidchicken.com>
5545
5546 * dispnew.c (add_window_display_history): Use BVAR.
5547
5548 * xdisp.c (debug_method_add): Use BVAR.
5549 (check_window_end, dump_glyph_matrix, dump_glyph)
5550 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5551
5552 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5553 Likewise.
5554
5555 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5556 check till after the cache is created in init_frame_faces.
5557
ff2bc410
SM
55582011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5559
5560 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5561
28177add
PE
55622011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5563
dd3482fe
PE
5564 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5565 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5566 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5567
393d71f3 5568 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5569 * fileio.c (Finsert_file_contents):
5570 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5571 Remove the old (too-loose) buffer overflow checks.
5572 They weren't needed, since make_gap checks for buffer overflow.
5573 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5574 The old code merely checked for Emacs fixnum overflow, and relied
5575 on undefined (wraparound) behavior. The new code avoids undefined
5576 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5577
2e6813b0 5578 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5579 Tune. Don't use wider integers than needed. Don't use alloca.
5580 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5581
599a9e4f
PE
5582 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5583
99561444
PE
5584 * insdel.c, lisp.h (buffer_overflow): New function.
5585 (insert_from_buffer_1, replace_range, replace_range_2):
5586 * insdel.c (make_gap_larger):
5587 * editfns.c (Finsert_char):
5588 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5589
28177add
PE
5590 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5591
e69dafad
PE
55922011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5593
4baa020d 5594 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5595
b1c46f02
PE
5596 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5597 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5598
e69dafad
PE
5599 * fileio.c: Don't assume EMACS_INT fits in off_t.
5600 (emacs_lseek): New static function.
5601 (Finsert_file_contents, Fwrite_region): Use it.
5602 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5603
566684ea
PE
5604 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5605
e6966cd6
PE
5606 * fns.c: Don't overflow int when computing a list length.
5607 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5608 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5609 truncation on 64-bit hosts. Check for QUIT every
5610 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5611 faster and is responsive enough.
5612 (Flength): Report an error instead of overflowing an integer.
5613 (Fsafe_length): Return a float if the value is not representable
5614 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5615 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5616 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5617
dd0b0efb
PE
5618 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5619 (header_size, word_size): New constants.
5620 (allocate_vectorlike): Don't check size overflow here.
5621 (allocate_vector): Check it here instead, since this is the only
5622 caller of allocate_vectorlike that could cause overflow.
5623 Check that the new vector's length is representable as a fixnum.
5624
86fe5cfe
PE
5625 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5626 The previous code was bogus. For example, next_almost_prime (32)
5627 returned 39, which is undesirable as it is a multiple of 3; and
5628 next_almost_prime (24) returned 25, which is a multiple of 5 so
5629 why was the code bothering to check for multiples of 7?
5630
80e88859
PE
5631 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5632
4a2f0ad6
PE
5633 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5634
f66c7cf8
PE
5635 Variadic C functions now count arguments with ptrdiff_t.
5636 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5637 Back then I didn't know that the Emacs coding style prefers signed int.
5638 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5639 were being counted with int, which may truncate counts on 64-bit
5640 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5641 * lisp.h (struct Lisp_Subr.function.aMANY)
5642 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5643 Arg counts are now ptrdiff_t, not size_t.
5644 All variadic functions and their callers changed accordingly.
5645 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5646 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5647 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5648 * callint.c (Fcall_interactively): Check arg count for overflow,
5649 to avoid potential buffer overrun. Use signed char, not 'int',
5650 for 'varies' array, so that we needn't bother to check its size
5651 calculation for overflow.
5652 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5653 * eval.c (apply_lambda):
5654 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5655 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5656 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5657
a1759b76
PE
5658 * callint.c (Fcall_interactively): Don't use index var as event count.
5659
d96be9fc
PE
5660 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5661 * mem-limits.h (SIZE): Remove; no longer used.
5662
a690a978 5663 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5664
578c21e6
PE
5665 Remove unnecessary casts.
5666 * xterm.c (x_term_init):
5667 * xfns.c (x_set_border_pixel):
5668 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5669 These aren't needed now that we assume ANSI C.
5670
96f53c6c
PE
5671 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5672 It's more likely to cause problems (due to unsigned overflow)
5673 than to cure them.
5674
83c77d31
PE
5675 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5676
ee2079f1
PE
5677 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5678
6da65536
PE
5679 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5680
7147c4a4
PE
5681 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5682
193e32d9
PE
5683 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5684
e5533da6
PE
5685 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5686
9910e595
PE
5687 GLYPH_CODE_FACE returns EMACS_INT, not int.
5688 * dispextern.h (merge_faces):
5689 * xfaces.c (merge_faces):
01103c44
PE
5690 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5691 Don't assume EMACS_INT fits in int.
9910e595 5692
2638320e
PE
5693 * character.h (CHAR_VALID_P): Remove unused parameter.
5694 * fontset.c, lisp.h, xdisp.c: All uses changed.
5695
045eb8d9
PE
5696 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5697
c1f134b5
PE
5698 * fns.c (concat): Minor tuning based on overflow analysis.
5699 This doesn't fix any bugs. Use int to hold character, instead
5700 of constantly refetching from Emacs object. Use XFASTINT, not
5701 XINT, for value known to be a character. Don't bother comparing
5702 a single byte to 0400, as it's always less.
5703
395fcb93 5704 * floatfns.c (Fexpt):
327eeec8
PE
5705 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5706
abbd3d23
PE
5707 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5708 for characters.
5709
684a03ef
PE
5710 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5711
0fed43f3
PE
5712 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5713 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5714 incorrectly succeed when S was a string, because 4294967386 was
5715 truncated before it was used.
5716
8fd02eb7
PE
5717 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5718 Otherwise, an out-of-range integer could cause undefined behavior
5719 on a 64-bit host.
5720
f8c86b69
PE
5721 * composite.c: Use int, not EMACS_INT, for characters.
5722 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5723 EMACS_INT, for values that are known to be in character range.
5724 This doesn't fix any bugs but is the usual style inside Emacs and
5725 may generate better code on 32-bit machines.
5726
34206dd2
PE
5727 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5728 This is for reasons similar to the recent CHAR_STRING fix.
5729 * charset.c (Fencode_char): Check that character arg is actually
5730 a character. Pass an int to ENCODE_CHAR.
5731 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5732 wider than 'int', as a compile-time check to prevent future regressions
5733 in this area.
5734
c5958d4c 5735 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5736
5737 Make sure a 64-bit char is never passed to CHAR_STRING.
5738 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5739 by silently ignoring the top 32 bits, allowing some values
5740 that were far too large to be valid characters.
5741 * character.h: Include <verify.h>.
5742 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5743 arguments are no wider than unsigned, as a compile-time check
5744 to prevent future regressions in this area.
5745 * data.c (Faset):
01103c44 5746 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5747 (Fsubst_char_in_region):
5748 * fns.c (concat):
5749 * xdisp.c (decode_mode_spec_coding):
5750 Adjust to CHAR_STRING's new requirement.
5751 * editfns.c (Finsert_char, Fsubst_char_in_region):
5752 * fns.c (concat): Check that character args are actually
5753 characters. Without this test, these functions did the wrong
5754 thing with wildly out-of-range values on 64-bit hosts.
5755
d37ca623
PE
5756 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5757 These casts should not be needed on 32-bit hosts, either.
5758 * keyboard.c (read_char):
5759 * lread.c (Fload): Remove casts to unsigned.
5760
ea204efb
PE
5761 * lisp.h (UNSIGNED_CMP): New macro.
5762 This fixes comparison bugs on 64-bit hosts.
5763 (ASCII_CHAR_P): Use it.
5764 * casefiddle.c (casify_object):
01103c44 5765 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5766 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5767 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5768 * dispextern.h (FACE_FROM_ID):
5769 * keyboard.c (read_char): Use UNSIGNED_CMP.
5770
41cb286c
PE
5771 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5772 not to EMACS_INT, to avoid GCC warning.
5773
4a1b9832
PE
5774 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5775
55daad71
PE
5776 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5777 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5778 isn't needed on 32-bit machines.
8f95c75c 5779
01103c44
PE
5780 * buffer.c (Fgenerate_new_buffer_name):
5781 Use EMACS_INT for count, not int.
0ceccced 5782 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5783
5784 * data.c (Qcompiled_function): Now static.
5785
c6f072e7
PE
5786 * window.c (window_body_lines): Now static.
5787
20ce5912
PE
5788 * image.c (gif_load): Rename local to avoid shadowing.
5789
9c4c5f81
PE
5790 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5791 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5792 * alloc.c (make_save_value): Integer argument is now of type
5793 ptrdiff_t, not int.
5794 (mark_object): Use ptrdiff_t, not int.
5795 * lisp.h (pD): New macro.
5796 * print.c (print_object): Use it.
5797
c0c5c8ae
PE
5798 * alloc.c: Use EMACS_INT, not int, to count objects.
5799 (total_conses, total_markers, total_symbols, total_vector_size)
5800 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5801 (total_free_floats, total_floats, total_free_intervals)
5802 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5803 Now EMACS_INT, not int. All uses changed.
5804 (Fgarbage_collect): Compute overall total using a double, so that
5805 integer overflow is less likely to be a problem. Check for overflow
5806 when converting back to an integer.
5a25e253
PE
5807 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5808 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5809 These were 'int' variables that could overflow on 64-bit hosts;
5810 they were never used, so remove them instead of repairing them.
211a0b2a 5811 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5812 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5813 Previously, this ceilinged at INT_MAX, but that doesn't work on
5814 64-bit machines.
e46bb31a 5815 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5816
c78baabf 5817 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5818 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5819 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5820 when a (possibly-narrower) signed value would do just as well.
5821 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5822
c9d624c6
PE
5823 * alloc.c: Catch some string size overflows that we were missing.
5824 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5825 for convenience in STRING_BYTES_MAX.
5826 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5827 The definition here is exact; the one in lisp.h was approximate.
5828 (allocate_string_data): Check for string overflow. This catches
5829 some instances we weren't catching before. Also, it catches
5830 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5831 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5832 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5833
c9d624c6
PE
5834 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5835 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5836 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5837
353032ce
PE
5838 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5839
2bccce07
PE
5840 * alloc.c (Fmake_string): Check for out-of-range init.
5841
0ac30604
SM
58422011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5843
5844 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5845
c195f2de
JD
58462011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5847
5848 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5849 xg_get_default_scrollbar_width.
5850
5851 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5852 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5853 (style_changed_cb): Call update_theme_scrollbar_width and call
5854 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5855 all frames (Bug#8505).
5856 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5857 Call gtk_window_set_resizable if HAVE_GTK3.
5858 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5859 and height if HAVE_GTK3 (Bug#8505).
5860 (scroll_bar_width_for_theme): New variable.
5861 (update_theme_scrollbar_width): New function.
5862 (xg_get_default_scrollbar_width): Move code to
5863 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5864 (xg_initialize): Call update_theme_scrollbar_width.
5865
5866 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5867
5868 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5869
e10ac9f1
MR
58702011-06-12 Martin Rudalics <rudalics@gmx.at>
5871
5872 * frame.c (make_frame): Call other_buffer_safely instead of
5873 other_buffer.
5874
5875 * window.c (temp_output_buffer_show): Call display_buffer with
5876 second argument Vtemp_buffer_show_specifiers and reset latter
5877 immediately after the call.
5878 (Vtemp_buffer_show_specifiers): New variable.
5879 (auto_window_vscroll_p, next_screen_context_lines)
5880 (Vscroll_preserve_screen_position): Remove leading asterisks from
5881 doc-strings.
5882
2d3c217e 58832011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5884
7b7f97e8 5885 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5886 * buffer.c (Qclone_number): Remove for now, as it's unused.
5887 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5888 (record_buffer): Remove unused local.
5889 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5890 (set_frame_buffer_list): Remove; unused.
5891 * frame.h (other_visible_frames): Remove decl.
5892 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5893 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5894 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5895 if HAVE_GPM.
5896 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5897 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5898 Define only if HAVE_GPM.
5899 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5900 (update_hints_inhibit): Remove; never set. All uses removed.
5901 * widgetprv.h (emacsFrameClassRec): Remove decl.
5902 * window.c (delete_deletable_window): Now returns void, since it
5903 wasn't returning anything.
5904 (compare_window_configurations): Remove unused locals.
5905 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5906 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5907 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5908 the same widths as pointers. This follows up on the 2011-05-06 patch.
5909 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5910 * xterm.h: Likewise.
5911 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5912
1384b89e
JB
59132011-06-12 Juanma Barranquero <lekktu@gmail.com>
5914
5915 * makefile.w32-in: Update dependencies.
5916 (LISP_H): Add lib/intprops.h.
5917
1100a63c
CY
59182011-06-11 Chong Yidong <cyd@stupidchicken.com>
5919
5920 * image.c (gif_load): Add animation frame delay to the metadata.
5921 (syms_of_image): Use DEFSYM. New symbol `delay'.
5922
6198ccd0
MR
59232011-06-11 Martin Rudalics <rudalics@gmx.at>
5924
5925 * window.c (delete_deletable_window): Re-add.
5926 (Fset_window_configuration): Rewrite to handle dead buffers and
5927 consequently deletable windows.
5928 (window_tree, Fwindow_tree): Remove. Supply functionality in
5929 window.el.
5930 (compare_window_configurations): Simplify code.
5931
b6e3633c
AS
59322011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5933
1ab0dee5
AS
5934 * image.c (imagemagick_load_image): Fix type mismatch.
5935 (Fimagemagick_types): Likewise.
5936
b6e3633c
AS
5937 * window.h (replace_buffer_in_windows): Declare.
5938
9397e56f
MR
59392011-06-11 Martin Rudalics <rudalics@gmx.at>
5940
5941 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5942 Qclone_number. Remove external declaration of Qdelete_window.
5943 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5944 code.
640c8776
SM
5945 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5946 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5947 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5948 buffer list implementation.
5949 (other_buffer_safely): New function.
5950 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5951 calls to replace_buffer_in_windows and
5952 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5953 if allowed.
5954 (record_buffer): Inhibit quitting and rewrite using quittable
5955 functions. Run Qbuffer_list_update_hook if allowed.
5956 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5957 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5958 Move switch-to-buffer to window.el.
9397e56f
MR
5959 (bury-buffer): Move to window.el.
5960 (Vbuffer_list_update_hook): New variable.
5961
5962 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5963 section.
5964
5965 * window.h (resize_frame_windows): Move up in code.
5966 (Fwindow_frame): Remove EXFUN.
5967 (replace_buffer_in_all_windows): Remove prototype.
5968 (replace_buffer_in_windows_safely): Add prototype.
5969
5970 * window.c: Declare Qdelete_window static again. Move down
5971 declaration of select_count.
5972 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5973 (Fother_window): Move to window.el.
5974 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5975 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5976 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5977 window.el.
5978 (replace_buffer_in_windows): Implement by calling
5979 Qreplace_buffer_in_windows.
5980 (replace_buffer_in_all_windows): Remove with some functionality
5981 moved into replace_buffer_in_windows_safely.
5982 (replace_buffer_in_windows_safely): New function.
5983 (select_window_norecord, select_frame_norecord): Move in front
5984 of run_window_configuration_change_hook. Remove now obsolete
5985 declarations.
640c8776
SM
5986 (Fset_window_buffer): Rewrite doc-string.
5987 Call Qrecord_window_buffer.
9397e56f
MR
5988 (keys_of_window): Move binding for other-window to window.el.
5989
b50691aa
CY
59902011-06-11 Chong Yidong <cyd@stupidchicken.com>
5991
5992 * dispextern.h (struct image): Replace data member, whose int_val
5993 and ptr_val fields were not used by anything, with a single
5994 lisp_val object.
5995
5996 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5997 (gif_clear_image, gif_load, imagemagick_load_image)
5998 (gs_clear_image, gs_load): Callers changed.
5999
3f754b86
PE
60002011-06-10 Paul Eggert <eggert@cs.ucla.edu>
6001
cca69397
PE
6002 * buffer.h: Include <time.h>, for time_t.
6003 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
6004
109e28d0
PE
6005 Fix minor problems found by static checking.
6006
60737f02
PE
6007 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
6008
4b66faf3
PE
6009 Make identifiers static if they are not used in other modules.
6010 * data.c (Qcompiled_function, Qframe, Qvector):
6011 * image.c (QimageMagick, Qsvg):
6012 * minibuf.c (Qmetadata):
6013 * window.c (resize_window_check, resize_root_window): Now static.
6014 * window.h (resize_window_check, resize_root_window): Remove decls.
6015
109e28d0
PE
6016 * window.c (window_deletion_count, delete_deletable_window):
6017 Remove; unused.
46a4ce9e
PE
6018 (window_body_lines): Now static.
6019 (Fdelete_other_windows_internal): Mark vars as initialized.
6020 Make sure 'resize_failed' is initialized.
6021 (run_window_configuration_change_hook): Rename local to avoid shadowing.
6022 (resize_window_apply): Remove unused local.
6023 * window.h (delete_deletable_window): Remove decl.
6024
109e28d0 6025 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
6026 (imagemagick_load_image): Fix pointer signedness problem by changing
6027 last arg from unsigned char * to char *. All uses changed.
6028 Also, fix a local for similar reasons.
6029 Remove unused locals. Remove locals to avoid shadowing.
6030 (fn_rsvg_handle_free): Remove; unused.
6031 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 6032 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 6033
3f754b86
PE
6034 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
6035
2547adb1
CY
60362011-06-10 Chong Yidong <cyd@stupidchicken.com>
6037
6038 * image.c (gif_load): Fix omitted cast error introduced by
6039 2011-06-06 change.
6040
2c8e37d4
MR
60412011-06-10 Martin Rudalics <rudalics@gmx.at>
6042
6043 * window.h (resize_proportionally, orig_total_lines)
6044 (orig_top_line): Remove from window structure.
6045 (set_window_height, set_window_width, change_window_heights)
6046 (Fdelete_window): Remove prototypes.
6047 (resize_frame_windows): Remove duplicate declaration.
6048
440a42e3
EZ
60492011-06-10 Eli Zaretskii <eliz@gnu.org>
6050
6051 * window.h (resize_frame_windows, resize_window_check)
6052 (delete_deletable_window, resize_root_window)
6053 (resize_frame_windows): Declare prototypes.
6054
6055 * window.c (resize_window_apply): Make definition be "static" to
6056 match the prototype.
6057
562dd5e9
MR
60582011-06-10 Martin Rudalics <rudalics@gmx.at>
6059
6060 * window.c: Remove declarations of Qwindow_size_fixed,
6061 window_min_size_1, window_min_size_2, window_min_size,
6062 size_window, window_fixed_size_p, enlarge_window, delete_window.
6063 Remove static from declaration of Qdelete_window, it's
6064 temporarily needed by Fbury_buffer.
6065 (replace_window): Don't assign orig_top_line and
6066 orig_total_lines.
6067 (Fdelete_window, delete_window): Remove. Window deletion is
6068 handled by window.el.
640c8776
SM
6069 (window_loop): Remove DELETE_OTHER_WINDOWS case.
6070 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
6071 (Fdelete_other_windows): Remove. Deleting other windows is
6072 handled by window.el.
6073 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6074 handled in window.el.
6075 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6076 Window minimum sizes are handled in window.el.
6077 (shrink_windows, size_window, set_window_height)
6078 (set_window_width, change_window_heights, window_height)
6079 (window_width, CURBEG, CURSIZE, enlarge_window)
6080 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6081 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6082 handled in window.el.
6083 (make_dummy_parent): Rename to make_parent_window and give it a
6084 second argument horflag.
6085 (make_window): Don't set resize_proportionally any more.
6086 (Fsplit_window): Remove. Windows are split in window.el.
6087 (save_restore_action, save_restore_orig_size)
6088 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6089 Resize mini windows in window.el.
6090 (grow_mini_window, shrink_mini_window): Implement by calling
6091 Qresize_root_window_vertically, resize_window_check and
6092 resize_window_apply.
640c8776
SM
6093 (saved_window, Fset_window_configuration, save_window_save):
6094 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
6095 resize_proportionally.
6096 (window_min_height, window_min_width): Move to window.el.
6097 (keys_of_window): Move bindings for delete-other-windows,
6098 split-window, delete-window and enlarge-window to window.el.
6099
6100 * buffer.c: Temporarily extern Qdelete_window.
6101 (Fbury_buffer): Temporarily call Qdelete_window instead of
6102 Fdelete_window (Fbury_buffer will move to window.el soon).
6103
6104 * frame.c (set_menu_bar_lines_1): Remove code handling
6105 orig_top_line and orig_total_lines.
6106
6107 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6108 set_window_height but set heights directly.
6109 (change_frame_size_1): Use resize_frame_windows.
6110
6111 * xdisp.c (init_xdisp): Don't use set_window_height but set
6112 heights directly.
6113
640c8776
SM
6114 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6115 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
6116 run_window_configuration_change_hook.
6117
6118 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6119 instead of change_window_heights and run
6120 run_window_configuration_change_hook.
6121
1a13852e
MR
61222011-06-09 Martin Rudalics <rudalics@gmx.at>
6123
6124 * window.c (replace_window): Rename second argument REPLACEMENT to
6125 NEW. New third argument SETFLAG. Rewrite.
6126 (delete_window, make_dummy_parent): Call replace_window with
6127 third argument 1.
6128 (window_list_1): Move down in code.
6129 (run_window_configuration_change_hook): Move set_buffer part
6130 before select_frame_norecord part in order to unwind correctly.
6131 Rename count1 to count.
6132 (recombine_windows, delete_deletable_window, resize_root_window)
6133 (Fdelete_other_windows_internal)
6134 (Frun_window_configuration_change_hook, make_parent_window)
6135 (resize_window_check, resize_window_apply, Fresize_window_apply)
6136 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
6137 (Fdelete_window_internal, Fresize_mini_window_internal):
6138 New functions.
1a13852e
MR
6139 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6140
f3d1777e
MR
61412011-06-08 Martin Rudalics <rudalics@gmx.at>
6142
496e208e
MR
6143 * window.h (window): Add some new members to window structure -
6144 normal_lines, normal_cols, new_total, new_normal, clone_number,
6145 splits, nest, prev_buffers, next_buffers.
6146 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 6147 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 6148
f3d1777e
MR
6149 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6150 Remove.
496e208e
MR
6151 (make_dummy_parent): Set new members of windows structure.
6152 (make_window): Move down in code. Handle new members of window
6153 structure.
6154 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6155 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6156 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6157 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
6158 (Fset_window_next_buffers, Fset_window_clone_number):
6159 New functions.
496e208e
MR
6160 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6161 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6162 Doc-string fixes.
6163 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6164 Argument WINDOW can be now internal window too.
6165 (Fwindow_use_time): Move up in code.
6166 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6167 Rewrite doc-string.
6168 (Fset_window_configuration, saved_window)
6169 (Fcurrent_window_configuration, save_window_save): Handle new
6170 members of window structure.
b9e809c2
MR
6171 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6172 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6173 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6174 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6175 Qget_mru_window, Qresize_root_window,
6176 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6177 Qauto_buffer_name; staticpro them.
f3d1777e 6178
abde8f8c
MR
61792011-06-07 Martin Rudalics <rudalics@gmx.at>
6180
6181 * window.c (Fwindow_total_size, Fwindow_left_column)
6182 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6183 (Fwindow_list_1): New functions.
6184 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
6185 (Fwindow_width, Fscroll_left, Fscroll_right):
6186 Use window_body_cols instead of window_box_text_cols.
6187 (delete_window, Fset_window_configuration):
6188 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
6189 (delete_all_subwindows): Take a window as argument and not a
6190 structure. Rewrite.
190b47e6
MR
6191 (window_loop): Remove handling of GET_LRU_WINDOW and
6192 GET_LARGEST_WINDOW.
6193 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
6194
6195 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
6196 window_box_text_cols. delete_all_subwindows now takes a
6197 Lisp_Object as argument.
abde8f8c 6198
640c8776
SM
6199 * indent.c (compute_motion, Fcompute_motion):
6200 Use window_body_cols instead of window_box_text_cols.
abde8f8c 6201
fa8a67e6
MR
6202 * frame.c (delete_frame): Call delete_all_subwindows with root
6203 window as argument.
6204
a54e3482
DC
62052011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6206
6207 * fns.c (Fputhash): Document return value.
6208
60002bf5
CY
62092011-06-06 Chong Yidong <cyd@stupidchicken.com>
6210
6211 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6212
0c671da6 62132011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 6214
b862a52a 6215 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 6216
be44ca6c
PE
6217 Check for overflow when converting integer to cons and back.
6218 * charset.c (Fdefine_charset_internal, Fdecode_char):
6219 Use cons_to_unsigned to catch overflow.
6220 (Fencode_char): Use INTEGER_TO_CONS.
6221 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6222 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6223 * data.c (long_to_cons, cons_to_long): Remove.
6224 (cons_to_unsigned, cons_to_signed): New functions.
6225 These signal an error for invalid or out-of-range values.
6226 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6227 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6228 * font.c (Ffont_variation_glyphs):
6229 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6230 * lisp.h: Include <intprops.h>.
6231 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6232 (cons_to_signed, cons_to_unsigned): New decls.
6233 (long_to_cons, cons_to_long): Remove decls.
6234 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6235 (Fprimitive_undo): Use CONS_TO_INTEGER.
6236 * xfns.c (Fx_window_property): Likewise.
6237 * xselect.c: Include <limits.h>.
6238 (x_own_selection, selection_data_to_lisp_data):
6239 Use INTEGER_TO_CONS.
6240 (x_handle_selection_request, x_handle_selection_clear)
6241 (x_get_foreign_selection, Fx_disown_selection_internal)
6242 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6243 (lisp_data_to_selection_data): Use cons_to_unsigned.
6244 (x_fill_property_data): Use cons_to_signed.
6245 Report values out of range.
6246
d1f3d2af
PE
6247 Check for buffer and string overflow more precisely.
6248 * buffer.h (BUF_BYTES_MAX): New macro.
6249 * lisp.h (STRING_BYTES_MAX): New macro.
6250 * alloc.c (Fmake_string):
6251 * character.c (string_escape_byte8):
6252 * coding.c (coding_alloc_by_realloc):
6253 * doprnt.c (doprnt):
6254 * editfns.c (Fformat):
6255 * eval.c (verror):
6256 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6257 since they may not be the same number.
6258 * editfns.c (Finsert_char):
6259 * fileio.c (Finsert_file_contents):
6260 Likewise for BUF_BYTES_MAX.
6261
dd52fcea
PE
6262 * image.c: Use ptrdiff_t, not int, for sizes.
6263 (slurp_file): Switch from int to ptrdiff_t.
6264 All uses changed.
6265 (slurp_file): Check that file size fits in both size_t (for
6266 malloc) and ptrdiff_t (for sanity and safety).
6267
7f9bbdbb
PE
6268 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6269 if b->modtime has its maximal value.
6270
dfe18f82
PE
6271 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6272
84acfcf0
PE
6273 Don't assume time_t can fit into int.
6274 * buffer.h (struct buffer.modtime): Now time_t, not int.
6275 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6276 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6277
ccd9a01a
PE
6278 Minor fixes for signed vs unsigned integers.
6279 * character.h (MAYBE_UNIFY_CHAR):
6280 * charset.c (maybe_unify_char):
6281 * keyboard.c (read_char, reorder_modifiers):
6282 XINT -> XFASTINT, since the integer must be nonnegative.
6283 * ftfont.c (ftfont_spec_pattern):
6284 * keymap.c (access_keymap, silly_event_symbol_error):
6285 XUINT -> XFASTINT, since the integer must be nonnegative.
6286 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6287 since it makes no difference and we prefer signed.
6288 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6289 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6290 nonnegative.
6291
d6d100dd
SM
62922011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6293
6294 * window.h (Fwindow_frame): Declare.
6295
2b6148e4
PE
62962011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6297
6298 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6299 (SPARE_MEMORY): Always define.
6300 (LARGE_REQUEST): Remove.
6301 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6302
f230ecc9
MR
63032011-06-06 Martin Rudalics <rudalics@gmx.at>
6304
727e958e
MR
6305 * lisp.h: Move EXFUNS for Fframe_root_window,
6306 Fframe_first_window and Fset_frame_selected_window to window.h.
6307
6308 * window.h: Move EXFUNS for Fframe_root_window,
6309 Fframe_first_window and Fset_frame_selected_window here from
6310 lisp.h.
6311
6312 * frame.c (Fwindow_frame, Fframe_first_window)
6313 (Fframe_root_window, Fframe_selected_window)
6314 (Fset_frame_selected_window): Move to window.c.
6315 (Factive_minibuffer_window): Move to minibuf.c.
6316 (Fother_visible_frames_p): New function.
6317
6318 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6319
f230ecc9
MR
6320 * window.c (decode_window, decode_any_window): Move up in code.
6321 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6322 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
6323 (Fwindow_buffer): Move up and rewrite doc-string.
6324 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6325 (Fwindow_prev): New functions.
727e958e
MR
6326 (Fwindow_frame): Move here from frame.c. Accept any window as
6327 argument.
6328 (Fframe_root_window, Fframe_first_window)
6329 (Fframe_selected_window): Move here from frame.c. Accept frame
6330 or arbitrary window as argument. Update doc-strings.
6331 (Fminibuffer_window): Move up in code.
6332 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
6333 (Fset_frame_selected_window): Move here from frame.c.
6334 Marginal rewrite.
727e958e
MR
6335 (Fselected_window, select_window, Fselect_window): Move up in
6336 code. Minor doc-string fixes.
f230ecc9 6337
4d09bcf6
PE
63382011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6339
6340 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6341 Do not assume that spare memory exists; that assumption is valid
6342 only if SYSTEM_MALLOC.
6343 (LARGE_REQUEST): New macro, so that the issue of large requests
6344 is separated from the issue of spare memory.
6345
810928a2
AS
63462011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6347
172418ad
AS
6348 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6349 format. (Bug#8806)
6350
43f862f7
AS
6351 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6352
810928a2
AS
6353 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6354 before statements.
6355
a059fe24
JD
63562011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6357
6358 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6359
6360 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6361
6362 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6363 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6364
989bf368
JB
63652011-06-05 Juanma Barranquero <lekktu@gmail.com>
6366
6367 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6368
4b80f674
CY
63692011-06-04 Chong Yidong <cyd@stupidchicken.com>
6370
6371 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6372 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
6373 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6374 New error handlers.
4b80f674
CY
6375 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6376 Obey Vx_select_enable_clipboard_manager. Catch errors in
6377 x_clipboard_manager_save (Bug#8779).
6378 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 6379 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 6380
99a33b77 63812011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
6382
6383 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6384
99a33b77 63852011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
6386
6387 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6388 in the current matrix if keep_current_p is non-zero.
6389
8264569d
EZ
63902011-06-04 Eli Zaretskii <eliz@gnu.org>
6391
6392 * bidi.c (bidi_level_of_next_char): Fix last change.
6393
57f97249
EZ
63942011-06-03 Eli Zaretskii <eliz@gnu.org>
6395
fec2107c 6396 Support bidi reordering of text covered by display properties.
57f97249 6397
fec2107c
EZ
6398 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6399 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6400 (bidi_cache_search, bidi_cache_iterator_state)
6401 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
6402 (bidi_level_of_next_char, bidi_move_to_visually_next):
6403 Support character positions inside a run of characters covered by a
fec2107c
EZ
6404 display string.
6405 (bidi_paragraph_init, bidi_resolve_explicit_1)
6406 (bidi_level_of_next_char): Call bidi_fetch_char and
6407 bidi_fetch_char_advance instead of FETCH_CHAR and
6408 FETCH_CHAR_ADVANCE.
6409 (bidi_init_it): Initialize new members.
6410 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6411 definitions.
6412 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6413 instead of using explicit *_CHAR codes.
d6d100dd
SM
6414 (bidi_resolve_explicit, bidi_resolve_weak):
6415 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6416 bidirectional text is supported only in multibyte buffers.
6417 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6418 it to initialize the frame_window_p member of struct bidi_it.
6419 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6420 (bidi_resolve_explicit, bidi_resolve_weak)
6421 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6422 bidi_it->nchars is non-positive.
6423 (bidi_level_of_next_char): Don't try to lookup the cache for the
6424 next/previous character if nothing is cached there yet, or if we
6425 were just reseat()'ed to a new position.
c40e2fb2 6426
0e14fe90
EZ
6427 * xdisp.c (set_cursor_from_row): Set start and stop points
6428 according to the row's direction when priming the loop that looks
6429 for the glyph on which to display cursor.
6430 (single_display_spec_intangible_p): Function deleted.
6431 (display_prop_intangible_p): Reimplement to call
6432 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6433 Accept 3 additional arguments needed by handle_display_spec.
6434 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6435 values: lists, `(when COND...)' forms, etc.
6436 (single_display_spec_string_p): Support property values that are
6437 lists with the argument STRING its top-level element.
6438 (display_prop_string_p): Fix the condition for processing a
6439 property that is a list to be consistent with handle_display_spec.
fec2107c 6440 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6441 last portion of handle_display_prop.
6442 (compute_display_string_pos): Accept additional argument
6443 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6444 value of a `display' property is a "replacing spec".
6445 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6446 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6447 the display property, but just return a value indicating whether
6448 the display property will replace the characters it covers.
6449 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6450 frame_window_p members of struct bidi_it.
d6d100dd
SM
6451 (compute_display_string_pos, compute_display_string_end):
6452 New functions.
fec2107c
EZ
6453 (push_it): Accept second argument POSITION, where pop_it should
6454 jump to continue iteration.
6455 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6456
fec2107c
EZ
6457 * keyboard.c (adjust_point_for_property): Adjust the call to
6458 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6459
6460 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6461 (bidi_init_it): Update prototypes.
6462 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6463 (compute_display_string_pos, compute_display_string_end):
6464 Declare prototypes.
fec2107c
EZ
6465 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6466 EMACS_INT.
fc6f18ce 6467
40087514 64682011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6469
57f53182
PE
6470 Malloc failure behavior now depends on size of allocation.
6471 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6472 * lisp.h: Change signatures accordingly.
6473 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6474 All callers changed. (Bug#8762)
6475
6476 * gnutls.c: Use Emacs's memory allocators.
6477 Without this change, the gnutls library would invoke malloc etc.
6478 directly, which causes problems on non-SYNC_INPUT hosts, and which
6479 runs afoul of improving memory_full behavior. (Bug#8761)
6480 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6481 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6482 xfree instead of the default malloc, realloc, free.
6483 (Fgnutls_boot): No need to check for memory allocation failure,
6484 since xmalloc does that for us.
6485
ac32cd99 6486 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6487 * category.c (hash_get_category_set):
6488 * ccl.c (ccl_driver):
6489 * charset.c (Fdefine_charset_internal):
6490 * charset.h (struct charset.hash_index):
6491 * composite.c (get_composition_id, gstring_lookup_cache)
6492 (composition_gstring_put_cache):
6493 * composite.h (struct composition.hash_index):
6494 * dispextern.h (struct image.hash):
6495 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6496 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6497 (hashfn_equal, hashfn_user_defined, make_hash_table)
6498 (maybe_resize_hash_table, hash_lookup, hash_put)
6499 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6500 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6501 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6502 * image.c (make_image, search_image_cache, lookup_image)
6503 (xpm_put_color_table_h):
6504 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6505 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6506 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6507 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6508 * alloc.c (allocate_vectorlike):
6509 Check for overflow in vector size calculations.
6510 * ccl.c (ccl_driver):
6511 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6512 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6513 need to be updated by these changes.
40087514
PE
6514 * fns.c (make_hash_table, maybe_resize_hash_table):
6515 Check for integer overflow with large hash tables.
0de4bb68
PE
6516 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6517 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6518 (SXHASH_REDUCE): New macro.
6519 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6520 Use it instead of discarding useful hash info with large hash values.
6521 (sxhash_float): New function.
6522 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6523 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6524 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6525 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6526 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6527 Adjust signatures to match updated version of code.
6528 (consing_since_gc): Now EMACS_INT, since a single hash table can
6529 use more than INT_MAX bytes.
6530
698d32e2
DN
65312011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6532
6533 Make it possible to build with GCC-4.6+ -O2 -flto.
6534
6535 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6536
fd6fa53f
SM
65372011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6538
6539 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6540 Call minibuffer-inactive-mode.
6541
864db017
JB
65422011-05-31 Juanma Barranquero <lekktu@gmail.com>
6543
6544 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6545 Update dependencies.
6546
2ad0baf4
DN
65472011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6548
6549 * data.c (init_data): Remove code for UTS, this system is not
6550 supported anymore.
6551
4fcc2638
DN
65522011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6553
6554 Don't force ./temacs to start in terminal mode.
6555
6556 * frame.c (make_initial_frame): Initialize faces in all cases, not
6557 only when CANNOT_DUMP is defined.
6558 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6559
c56e0fd5
DN
65602011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6561
6562 * dispnew.c (add_window_display_history): Use const for the string
6563 pointer. Remove declaration, not needed.
6564
333d54da 65652011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6566
55d4c1b2 6567 Use 'inline', not 'INLINE'.
333d54da 6568 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6569 * alloc.c, fontset.c (INLINE): Remove.
6570 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6571 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6572 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6573 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6574 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6575
738db178
DN
65762011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6577
6578 Make it possible to run ./temacs.
6579
6580 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6581 syms_of_callproc does the same thing. Remove test for
6582 "initialized", do it in the caller.
6583 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6584
620c53a6
SM
65852011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6586
6587 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6588 (read_minibuf): Use get_minibuffer.
6589 (syms_of_minibuf): Use DEFSYM.
6590 (Qmetadata): New var.
6591 * data.c (Qbuffer): Don't make it static.
6592 (syms_of_data): Use DEFSYM.
6593
e003a292
PE
65942011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6595
6596 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6597 (CCL_CODE_MIN): New macro.
6598
ed008a6d
PE
65992011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6600
3687c2ef
PE
6601 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6602
ed008a6d
PE
6603 * eval.c (Qdebug): Now static.
6604 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6605 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6606 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6607
d66c4c7c
CY
66082011-05-29 Chong Yidong <cyd@stupidchicken.com>
6609
6610 * image.c: Various fixes to ImageMagick code comments.
6611 (Fimagemagick_types): Doc fix.
6612
5fbc2025
PE
66132011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6614
0196f88a
PE
6615 Minor fixes prompted by GCC 4.6.0 warnings.
6616
6617 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6618
5fbc2025
PE
6619 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6620 (x_clipboard_manager_save_all): Move extern decl to ...
6621 * xterm.h: ... here, so that it can be checked for consistency.
6622
1dd3c2d9
CY
66232011-05-29 Chong Yidong <cyd@stupidchicken.com>
6624
6625 * xselect.c (x_clipboard_manager_save_frame)
6626 (x_clipboard_manager_save_all): New functions.
6627 (Fx_clipboard_manager_save): Lisp function deleted.
6628
6629 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6630 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6631
6632 * xterm.h: Update prototype.
6633
5ba6571d
WX
66342011-05-28 William Xu <william.xwl@gmail.com>
6635
6636 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6637 exiting (Bug#8239).
6638
3eaff834
JM
66392011-05-28 Jim Meyering <meyering@redhat.com>
6640
e1900994 6641 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6642 * fns.c (to_uchar): Define.
6643 (crypto_hash_function): Use it to convert some newly-signed
6644 variables to unsigned, to avoid sign-extension bugs. For example,
6645 without this change, (md5 "truc") would evaluate to
6646 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6647 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6648 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6649
0f6990a7
PE
66502011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6651
6652 Integer overflow fixes.
c8a9ca5a 6653
08686060
PE
6654 * dbusbind.c: Serial number integer overflow fixes.
6655 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6656 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6657 to hold a serial number that is too large for a fixnum.
6658 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6659 Check for serial numbers out of range. Decode any serial number
59568bf0 6660 that was so large that it became a float. (Bug#8722)
08686060 6661
2d1fc3c7
PE
6662 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6663 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6664 Use XFASTINT rather than XUINT when numbers are nonnegative.
6665 (xd_append_arg, Fdbus_method_return_internal):
6666 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6667 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6668 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6669 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6670 (Bug#8722)
2d1fc3c7 6671
c8a9ca5a
PE
6672 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6673
519e1d69
PE
6674 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6675
6df6ae42 6676 ccl: Add integer overflow checks.
30569699
PE
6677 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6678 (IN_INT_RANGE): New macros.
6679 (ccl_driver): Use them to check for integer overflow when
6680 decoding a CCL program. Many of the new checks are whether XINT (x)
6681 fits in int; it doesn't always, on 64-bit hosts. The new version
6682 doesn't catch all possible integer overflows, but it's an
847044ea 6683 improvement. (Bug#8719)
30569699 6684
c11285dc
PE
6685 * alloc.c (make_event_array): Use XINT, not XUINT.
6686 There's no need for unsigned here.
6687
fdccd48e
PE
6688 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6689 This follows up to the 2011-05-06 change that substituted uintptr_t
6690 for EMACS_INT. This case wasn't caught back then.
6691
37910ab2
PE
6692 Rework Fformat to avoid integer overflow issues.
6693 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6694 now (part of C89). Include <verify.h>.
6695 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6696 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6697 (Fformat): Avoid the prepass trying to compute sizes; it was only
6698 approximate and thus did not catch overflow reliably. Instead, walk
6699 through the format just once, formatting and computing sizes as we go,
6700 checking for integer overflow at every step, and allocating a larger
6701 buffer as needed. Keep track separately whether the format is
6702 multibyte. Keep only the most-recently calculated precision, rather
6703 than them all. Record whether each argument has been converted to
6704 string. Use EMACS_INT, not int, for byte and char and arg counts.
6705 Support field widths and precisions larger than INT_MAX. Avoid
6706 sprintf's undefined behavior with conversion specifications such as %#d
6707 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6708 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6709 formatting out-of-range floating point numbers with int
9173deec 6710 formats. (Bug#8668)
37910ab2 6711
2e6578fb
PE
6712 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6713
0ae6bdee
PE
6714 * data.c: Avoid integer truncation in expressions involving floats.
6715 * data.c: Include <intprops.h>.
6716 (arith_driver): When there's an integer overflow in an expression
6717 involving floating point, convert the integers to floating point
6718 so that the resulting value does not suffer from catastrophic
6719 integer truncation. For example, on a 64-bit host (* 4
6720 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6721 Do not rely on undefined behavior after integer overflow.
6722
de883a70
PE
6723 merge count_size_as_multibyte, parse_str_to_multibyte
6724 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6725 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6726 Check for integer overflow.
6727 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6728 since it's now a duplicate of the other. This is more of
6729 a character than a buffer op, so better that it's in character.c.
6730 * fns.c, print.c: Adjust to above changes.
6731
2ff916cb
PE
67322011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6733
6734 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6735
f1b54466
PE
67362011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6737
fb1ac845
PE
6738 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6739 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6740 (x_clipboard_manager_save): Now static.
6741 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6742
f1b54466
PE
6743 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6744 (crypto_hash_function): Now static.
6745 Fix pointer signedness problems. Avoid unnecessary initializations.
6746
a9f737ee
CY
67472011-05-27 Chong Yidong <cyd@stupidchicken.com>
6748
6749 * termhooks.h (Vselection_alist): Make it terminal-local.
6750
6751 * terminal.c (create_terminal): Initialize it.
6752
6753 * xselect.c: Support for clipboard managers.
6754 (Vselection_alist): Move to termhooks.h as terminal-local var.
6755 (LOCAL_SELECTION): New macro.
6756 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6757 (symbol_to_x_atom): Remove gratuitous arg.
6758 (x_handle_selection_request, lisp_data_to_selection_data)
6759 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6760 (x_own_selection, x_get_local_selection, x_convert_selection):
6761 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6762 (some_frame_on_display): Delete unused function.
6763 (Fx_own_selection_internal, Fx_get_selection_internal)
6764 (Fx_disown_selection_internal, Fx_selection_owner_p)
6765 (Fx_selection_exists_p): New optional frame arg.
6766 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6767 (x_handle_selection_clear): Don't treat other terminals with the
6768 same keyboard specially. Use the terminal-local Vselection_alist.
6769 (x_clear_frame_selections): Use Frun_hook_with_args.
6770
6771 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6772
6773 * xterm.h: Add support for those atoms.
6774
e067f0c1
CY
67752011-05-26 Chong Yidong <cyd@stupidchicken.com>
6776
6777 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6778 (converted_selections, conversion_fail_tag): New global variables.
6779 (x_selection_request_lisp_error): Free the above.
6780 (x_get_local_selection): Remove unnecessary code.
6781 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6782 of converted selections stored in converted_selections.
6783 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6784 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6785 (x_convert_selection): New function.
6786 (x_handle_selection_event): Simplify.
6787 (x_get_foreign_selection): Don't ignore incoming requests while
6788 waiting for an answer; this will fail when we implement
6789 SAVE_TARGETS, and seems unnecessary anyway.
6790 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6791 (Vx_sent_selection_functions): Doc fix.
6792
0f4aebc0
LL
67932011-05-26 Leo Liu <sdl.web@gmail.com>
6794
6795 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6796
e61124cd
YM
67972011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6798
6799 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6800
6801 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6802 for fringe update if it has periodic bitmap.
ac389d0c 6803 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6804 and fringe_bitmap_periodic_p.
6805
6806 * fringe.c (get_fringe_bitmap_data): New function.
6807 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6808 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6809 row. Mark glyph row for fringe update if periodicity changed.
6810
6811 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6812 for fringe update unless it has periodic bitmap.
6813
f16d9837
KH
68142011-05-25 Kenichi Handa <handa@m17n.org>
6815
6816 * xdisp.c (get_next_display_element): Set correct it->face_id for
6817 a static composition.
6818
e1b90ef6
LL
68192011-05-24 Leo Liu <sdl.web@gmail.com>
6820
6821 * deps.mk (fns.o):
6822 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6823
6824 * fns.c (crypto_hash_function, Fsha1): New function.
6825 (Fmd5): Use crypto_hash_function.
6826 (syms_of_fns): Add Ssha1.
6827
7400048f
PE
68282011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6829
6830 * gnutls.c: Remove unused macros.
6831 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6832 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6833 Remove macros that are defined and never used.
6834 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6835
abb71cf4
CY
68362011-05-22 Chong Yidong <cyd@stupidchicken.com>
6837
6838 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6839 (Fx_get_selection_internal): Minor cleanup.
6840 (Fx_own_selection_internal): Rename arguments for consistency with
6841 select.el.
6842
6307db39
PE
68432011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6844
6845 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6846
f3d4e0a4
CY
68472011-05-22 Chong Yidong <cyd@stupidchicken.com>
6848
6849 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6850
4d8ade89
YM
68512011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6852
6853 * dispnew.c (scrolling_window): Don't exclude the case that the
6854 last enabled row in the desired matrix touches the bottom boundary.
6855
32078c8d
GM
68562011-05-21 Glenn Morris <rgm@gnu.org>
6857
6858 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6859 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6860 and add some more files.
32078c8d 6861
7285dc67
EZ
68622011-05-20 Eli Zaretskii <eliz@gnu.org>
6863
6864 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6865 report_file_error introduced by the change from 2011-05-07.
6866
89d1bd22
PE
68672011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6868
6869 * systime.h (Time): Define only if emacs is defined.
6870 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6871 where the include path doesn't have X11/X.h by default. See
6872 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6873
cd394be1 68742011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6875
6876 * composite.c (find_automatic_composition): Fix previous change.
6877
b9704ad9
GM
68782011-05-20 Glenn Morris <rgm@gnu.org>
6879
6880 * lisp.mk: New file, split from Makefile.in.
6881 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6882 (shortlisp): Remove.
6883 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6884
4a720484
GM
68852011-05-19 Glenn Morris <rgm@gnu.org>
6886
6887 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6888 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6889 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6890 (lisp): Set the order to that of loadup.el.
6891 (shortlisp): Make it a copy of $lisp.
6892 (SOME_MACHINE_LISP): Remove.
6893 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6894 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6895
a28d4396
KH
68962011-05-18 Kenichi Handa <handa@m17n.org>
6897
6898 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6899 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6900 (find_automatic_composition): Mostly rewrite for efficiency.
6901
a2b1fa8e
JB
69022011-05-18 Juanma Barranquero <lekktu@gmail.com>
6903
6904 * makefile.w32-in: Update dependencies.
6905
8e1f5610
CS
69062011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6907
6908 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6909 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6910
7025ee00 69112011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6912
cdfa6eab
PE
6913 Fix some integer overflow issues, such as string length overflow.
6914
06d6db33
PE
6915 * insdel.c (count_size_as_multibyte): Check for string overflow.
6916
2b4560a8
PE
6917 * character.c (lisp_string_width): Check for string overflow.
6918 Use EMACS_INT, not int, for string indexes and lengths; in
6919 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6920 the resulting string length overflows an EMACS_INT; instead,
6921 report a string overflow if no precision given. When checking for
6922 precision exhaustion, use a check that cannot possibly have
6923 integer overflow. (Bug#8675)
6924 * character.h (lisp_string_width): Adjust to new signature.
6925
cb93f9be
PE
6926 * alloc.c (string_overflow): New function.
6927 (Fmake_string): Use it. This doesn't change behavior, but saves
6928 a few bytes and will simplify future changes.
6929 * character.c (string_escape_byte8): Likewise.
6930 * lisp.h (string_overflow): New decl.
6931
1a1f3366
PE
6932 Fixups, following up to the user-interface timestamp change.
6933 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6934 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6935 * msdos.c (mouse_get_pos): Likewise.
6936 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6937 * w32gui.h (Time): Define by including "systime.h" rather than by
6938 declaring it ourselves. (Bug#8664)
6939
d4e3e4d3
PE
6940 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6941 * image.c (clear_image_cache): Likewise.
6942
f6a24d19
PE
6943 * term.c (term_mouse_position): Don't assume time_t wraparound.
6944
08dc5ae6
PE
6945 Be more systematic about user-interface timestamps.
6946 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6947 and sometimes 'EMACS_UINT', to represent these timestamps.
6948 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6949 This makes the code easier to follow, and makes it easier to catch
6950 integer overflow bugs such as Bug#8664.
6951 * frame.c (Fmouse_position, Fmouse_pixel_position):
6952 Use Time, not unsigned long, for user-interface timestamps.
6953 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6954 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6955 * keyboard.h (last_event_timestamp): Likewise.
6956 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6957 * menu.h (xmenu_show): Likewise.
6958 * term.c (term_mouse_position): Likewise.
6959 * termhooks.h (struct input_event.timestamp): Likewise.
6960 (struct terminal.mouse_position_hook): Likewise.
6961 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6962 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6963 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6964 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6965 what it was before.
6966 * menu.h, termhooks.h: Include "systime.h", for Time.
6967
8e55734a
PE
6968 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6969 Don't assume that the difference between two unsigned long values
6970 can fit into an integer. At this point, we know button_down_time
6971 <= event->timestamp, so the difference must be nonnegative, so
6972 there's no need to cast the result if double-click-time is
6973 nonnegative, as it should be; check that it's nonnegative, just in
6974 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6975 apart (about 25 days). (Bug#8664)
8e55734a 6976
841f1b75 6977 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6978 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6979
3e26f69c
PE
6980 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6981 that always fit in int. Use a sentinel instead of a counter, to
6982 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6983 * frame.h (struct frame): Use int for menu_bar_items_used
6984 instead of EMACS_INT, since it always fits in int.
3e26f69c 6985
5cc152c0
PE
6986 * menu.c (grow_menu_items): Check for int overflow.
6987
d89eb65e
PE
6988 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6989
5235bd3e
PE
6990 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6991 Before, the code was not consistent. These values cannot exceed
6992 2**31 - 1 so there's no need to make them unsigned.
6993 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6994 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6995 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6996 as modifiers.
6997 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6998
bc827e23
PE
6999 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
7000 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
7001 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
7002 presumably because the widths might not match.
7003
78eb494e
PE
7004 * window.c (size_window): Avoid needless test at loop start.
7005
04f2d78b
CB
70062011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
7007
7008 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
7009
d2fc7e3d 70102011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
7011
7012 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
7013
d2fc7e3d 70142011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
7015
7016 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
7017 `width' to `bar_area_x' and `bar_area_width', respectively.
7018 (x_scroll_run): Take account of fringe background extension.
7019
04f2d78b
CB
7020 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
7021 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
7022 `bar_area_width', respectively.
7023 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
7024 background extension.
7025
79b70037
GM
70262011-05-10 Jim Meyering <meyering@redhat.com>
7027
7028 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
7029
2f142cc5
JB
70302011-05-10 Juanma Barranquero <lekktu@gmail.com>
7031
7032 * image.c (Finit_image_library): Return t for built-in image types,
7033 like pbm and xbm. (Bug#8640)
7034
57679c86
AS
70352011-05-09 Andreas Schwab <schwab@linux-m68k.org>
7036
7037 * w32menu.c (set_frame_menubar): Fix submenu allocation.
7038
888c9e86
EZ
70392011-05-07 Eli Zaretskii <eliz@gnu.org>
7040
b0512a1d
EZ
7041 * w32console.c (Fset_screen_color): Doc fix.
7042 (Fget_screen_color): New function.
7043 (syms_of_ntterm): Defsubr it.
7044
7285dc67
EZ
7045 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
7046 unlink the temporary file if Fcall_process didn't create it in the
7047 first place.
7048 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
7049 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
7050 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
7051 cue to call_process_cleanup not to close that handle.
7052
4d3fcc8e
BK
70532011-05-07 Ben Key <bkey76@gmail.com>
7054
7055 * makefile.w32-in: The bootstrap-temacs rule now makes use of
7056 one of two shell specific rules, either bootstrap-temacs-CMD or
7057 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
7058 to the previous implementation of the bootstrap-temacs rule.
7059 The bootstrap-temacs-CMD rule is similar to the previous
7060 implementation of the bootstrap-temacs rule except that it
7061 makes use of the ESC_CFLAGS variable instead of the CFLAGS
7062 variable.
7063
7064 These changes, along with some changes to nt/configure.bat,
7065 nt/gmake.defs, and nt/nmake.defs, are required to extend my
7066 earlier fix to add support for --cflags and --ldflags options
7067 that include quotes so that it works whether make uses cmd or
7068 sh as the shell.
7069
b4289b64
MA
70702011-05-06 Michael Albinus <michael.albinus@gmx.de>
7071
7072 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7073 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7074 is a constant.
7075 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7076 a string. Handle both cases.
7077 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7078 (Fdbus_register_method): Use Qinvalid_function.
7079
af4c0e28
JB
70802011-05-06 Juanma Barranquero <lekktu@gmail.com>
7081
7082 * makefile.w32-in: Update dependencies.
7083 (LISP_H): Add inttypes.h and stdin.h.
7084 (PROCESS_H): Add unistd.h.
7085
c51453d9
EZ
70862011-05-06 Eli Zaretskii <eliz@gnu.org>
7087
7088 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7089 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7090
8ff0ac3c 70912011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 7092
4c4b566b
PE
7093 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7094
aab2b9b5
PE
7095 * term.c (vfatal): Remove stray call to va_end.
7096 It's not needed and the C Standard doesn't allow it here anyway.
7097
c378da0b
PE
7098 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7099 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7100
288b08c7
PE
7101 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7102 bytes.
7103
e3601888
PE
7104 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7105
db6c0e74
PE
7106 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7107
dd5963ea
PE
7108 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7109
88c9450f
PE
7110 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7111
2f9442b8
PE
7112 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7113
c032b5f8
PE
7114 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7115 * charset.c (Fdefine_charset_internal): Don't initialize
7116 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 7117 32-bit int (Bug#8600).
a108c10b
PE
7118
7119 * lread.c (read_integer): Be more consistent with string-to-number.
7120 Use string_to_number to do the actual conversion; this avoids
7121 rounding errors and fixes some other screwups. Without this fix,
7122 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7123 (digit_to_number): Move earlier, for benefit of read_integer.
7124 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 7125 not a digit in any supported base. (Bug#8602)
a108c10b 7126
ad5f9eea
PE
7127 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7128
aec1708a
PE
7129 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7130 to match comment at start of function. This also removes a
7131 GCC warning about overflow in a 32+64-bit port.
7132
47be4ab5
PE
7133 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7134
371cac43
PE
7135 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7136 Reported by Stefan Monnier in
7137 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
7138 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7139 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 7140
d01a7826
PE
7141 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7142 (EMACS_UINTPTR): Likewise, with uintptr_t.
7143
7fd47d5c
PE
7144 * lisp.h: Prefer 64-bit EMACS_INT if available.
7145 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7146 on 32-bit hosts that have 64-bit int, so that they can access
7147 large files.
122b0c86
PE
7148 However, temporarily disable this change unless the temporary
7149 symbol WIDE_EMACS_INT is defined.
7fd47d5c 7150
8727937b
PE
7151 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7152
8ac068ac
PE
7153 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7154 This removes an assumption that EMACS_INT and long are the same
7155 width as pointers. The assumption is true for Emacs porting targets
7156 now, but we want to make other targets possible.
7157 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7158 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7159 In the rest of the code, change types of integers that hold casted
7160 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7161 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7162 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7163 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7164 No need to cast type when ORing.
7165 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7166 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7167 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7168 assume EMACS_INT is the same width as char *.
7169 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7170 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7171 Remove no-longer-needed casts.
7172 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7173 (xg_tool_bar_help_callback, xg_make_tool_item):
7174 Use EMACS_INTPTR to hold an integer
7175 that will be cast to void *; this can avoid a GCC warning
7176 if EMACS_INT is not the same width as void *.
7177 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7178 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7179 (current_message_1, set_message_1):
7180 Use a local to convert to proper width without a cast.
7181 * xmenu.c (dialog_selection_callback): Likewise.
7182
ede49d71
PE
7183 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7184 Also, don't assume VALBITS / RAND_BITS is less than 5,
7185 and don't rely on undefined behavior when shifting a 1 left into
7186 the sign bit.
7187 * lisp.h (get_random): Change signature to match.
7188
2f30ecd0
PE
7189 * lread.c (hash_string): Use size_t, not int, for hash computation.
7190 Normally we prefer signed values; but hashing is special, because
7191 it's better to use unsigned division on hash table sizes so that
7192 the remainder is nonnegative. Also, size_t is the natural width
7193 for hashing into memory. The previous code used 'int', which doesn't
7194 retain enough info to hash well into very large tables.
7195 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7196
2a866e7b
PE
7197 * dbusbind.c: Don't possibly lose pointer info when converting.
7198 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7199 Use XPNTR rather than XHASH, so that the high-order bits of
7200 the pointer aren't lost when converting through void *.
7201
51639eac
PE
7202 * eval.c (Fautoload): Don't double-shift a pointer.
7203
92394119
PE
7204 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7205
dbdb9a7c
JB
72062011-05-06 Juanma Barranquero <lekktu@gmail.com>
7207
7208 * gnutls.c (DEF_GNUTLS_FN):
7209 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7210
db7a0b4f
AS
72112011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7212
7213 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7214 marker. (Bug#8610)
7215
cd394be1 72162011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
7217
7218 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7219 New version that can reserve upto 2GB of heap space.
7220
f7ff1b0f 72212011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
7222
7223 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7224
639c109b
TZ
72252011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7226
7227 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7228 `gnutls_certificate_set_x509_key_file'.
7229
d2127135
JB
72302011-05-05 Juanma Barranquero <lekktu@gmail.com>
7231
7232 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7233 Update dependencies.
7234
e968f4f3
JB
72352011-05-04 Juanma Barranquero <lekktu@gmail.com>
7236
7237 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7238 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7239 Remove unused parameter `fildes'.
7240 * process.c (read_process_output, send_process): Don't pass it.
7241
84d358f0
JB
72422011-05-04 Juanma Barranquero <lekktu@gmail.com>
7243
7244 Fix previous change: the library cache is defined in w32.c.
7245 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7246 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7247
0898ca10
JB
72482011-05-04 Juanma Barranquero <lekktu@gmail.com>
7249
7250 Implement dynamic loading of GnuTLS on Windows.
7251
7252 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7253 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7254 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7255 Declare.
7256
7257 * gnutls.c (Qgnutls_dll): Define.
7258 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7259 (gnutls_*): Declare function pointers.
7260 (init_gnutls_functions): New function to initialize function pointers.
7261 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7262 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7263 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7264 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7265 (emacs_gnutls_write, emacs_gnutls_read)
7266 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7267 (Fgnutls_available_p): New function.
7268 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7269 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7270 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7271
7272 * image.c: Include w32.h.
7273 (Vimage_type_cache): Delete.
7274 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7275 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7276 (w32_delayed_load): Move to w32.c.
7277
7278 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7279
7280 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7281 (w32_delayed_load): Move from image.c. When loading a library, record
7282 its filename in the :loaded-from property of the library id.
7283 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7284 Initialize and staticpro them.
7285 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7286
7287 * process.c: Include lisp.h before w32.h, not after.
7288 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7289 instead of gnutls_record_check_pending.
7290
7291 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7292
ff4de4aa
TZ
72932011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7294
7295 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7296 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7297 as passed in.
7298
abe95abb
JD
72992011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7300
7301 * xterm.c (x_set_frame_alpha): Do not set property on anything
7302 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7303
e16e55d4
JB
73042011-05-02 Juanma Barranquero <lekktu@gmail.com>
7305
7306 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7307
bafcf6a5
JB
73082011-05-02 Juanma Barranquero <lekktu@gmail.com>
7309
7310 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7311 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7312 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7313 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7314 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7315 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7316 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7317 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7318 (Qgnutls_bootprop_callbacks_verify): Make static.
7319
e7a6747f
AS
73202011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7321
19ed11ba
AS
7322 * callproc.c: Indentation fixup.
7323
e7a6747f 7324 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
7325 (wait_for_termination, interruptible_wait_for_termination):
7326 Move after wait_for_termination_1.
e7a6747f 7327
1ef14cb4
LMI
73282011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7329
7330 * sysdep.c (interruptible_wait_for_termination): New function
7331 which is like wait_for_termination, but allows keyboard
7332 interruptions.
7333
7334 * callproc.c (Fcall_process): Add (:file "file") as an option for
7335 the STDOUT buffer.
7336 (Fcall_process_region): Ditto.
7337
330d880c
EZ
73382011-04-30 Eli Zaretskii <eliz@gnu.org>
7339
8db90b73
EZ
7340 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7341 rather than `XVECTOR (FOO)->size'.
7342
330d880c
EZ
7343 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7344 inttypes.h, as a gnulib replacement is used if it not available in
7345 system headers.
7346
15cbd324
EZ
73472011-04-21 Eli Zaretskii <eliz@gnu.org>
7348
7349 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7350 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7351 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7352
7353 * coding.c (coding_alloc_by_realloc): Error out if destination
7354 will grow beyond MOST_POSITIVE_FIXNUM.
7355 (decode_coding_emacs_mule): Abort if there isn't enough place in
7356 charbuf for the composition carryover bytes. Reserve an extra
7357 space for up to 2 characters produced in a loop.
7358 (decode_coding_iso_2022): Abort if there isn't enough place in
7359 charbuf for the composition carryover bytes.
7360
73612011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 7362
ae940cca
EZ
7363 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7364 aborting when %lld or %lll format is passed.
7365 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7366 %llo or %llx format is passed. (Bug#8545)
7367
03ab8921
EZ
7368 * window.c (window_scroll_line_based): Use a marker instead of
7369 simple variables to record original value of point. (Bug#7952)
7370
afda1437
EZ
7371 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7372 produced by %s or %c overflows available buffer space. (Bug#8545)
7373
f76dee0c
PE
73742011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7375
7376 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 7377 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 7378
fdc5744d
JB
73792011-04-28 Juanma Barranquero <lekktu@gmail.com>
7380
7381 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7382
638f053a
JB
73832011-04-28 Juanma Barranquero <lekktu@gmail.com>
7384
7385 * keyboard.c (Qdelayed_warnings_hook): Define.
7386 (command_loop_1): Run `delayed-warnings-hook'
7387 if Vdelayed_warnings_list is non-nil.
7388 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7389 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7390
d178f871
EZ
73912011-04-28 Eli Zaretskii <eliz@gnu.org>
7392
7393 * doprnt.c (doprnt): Don't return value smaller than the buffer
7394 size if the message was truncated. (Bug#8545).
7395
b124fd93
JB
73962011-04-28 Juanma Barranquero <lekktu@gmail.com>
7397
7398 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7399 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7400
e810457d
PE
74012011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7402
7403 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7404
ea51cceb
JB
74052011-04-27 Juanma Barranquero <lekktu@gmail.com>
7406
7407 * makefile.w32-in: Update dependencies.
7408
94dcfacf
EZ
74092011-04-27 Eli Zaretskii <eliz@gnu.org>
7410
7411 Improve `doprnt' and its usage. (Bug#8545)
7412 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7413 `format_end'. Remove support for %l as a conversion specifier.
7414 Don't use xrealloc. Improve diagnostics when the %l size modifier
7415 is used. Update the commentary.
7416
7417 * eval.c (verror): Simplify calculation of size_t.
7418
7419 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7420 messages.
7421
f61f41d7
PE
74222011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7423
7424 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7425 change.
7426
96fb4434
PE
74272011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7428
7429 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7430 This makes this file independent of the recent pseudovector change.
7431
671875da 74322011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7433
69e9b5a3
PE
7434 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7435
b5f869a7 7436 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7437 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7438 Remove unused local.
c8926152 7439 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7440
841a1577 7441 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7442 GCC 4.6.0 optimizes based on type-based alias analysis.
7443 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7444 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7445 != &v->size, and therefore "v->size = 1; b->size = 2; return
7446 v->size;" must therefore return 1. This assumption is incorrect
7447 for Emacs, since it type-puns struct Lisp_Vector * with many other
7448 types. To fix this problem, this patch adds a new type struct
f904488f 7449 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7450 and pseudovectors, and helps optimizing compilers not get fooled
7451 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7452 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7453 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7454 the size member.
eab3844f
PE
7455 (XSETPVECTYPE): Rewrite in terms of new macro.
7456 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7457 This is a bit clearer, and further avoids the possibility of
7458 undesirable aliasing.
7459 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7460 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7461 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7462 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7463 (ASIZE): Now uses header.size rather than size.
7464 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7465 to avoid the hassle of writing XVECTOR (foo)->header.size.
7466 (struct vectorlike_header): New type.
eab3844f
PE
7467 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7468 object, to help avoid aliasing.
7469 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7470 (SUBRP): Likewise, since Lisp_Subr is a special case.
7471 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7472 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7473 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7474 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7475 changed to be "header.size" and "header.next".
7476 * buffer.h (struct buffer): Likewise.
7477 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7478 * frame.h (struct frame): Likewise.
7479 * process.h (struct Lisp_Process): Likewise.
7480 * termhooks.h (struct terminal): Likewise.
7481 * window.c (struct save_window_data, struct saved_window): Likewise.
7482 * window.h (struct window): Likewise.
7483 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7484 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7485 * buffer.c (init_buffer_once): Likewise.
7486 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7487 special case.
7488 * process.c (Fformat_network_address): Use local var for size,
7489 for brevity.
7490
0df1eac5
PE
7491 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7492
847ab9d1 7493 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7494 * data.c (atof): Remove decl; no longer used or needed.
7495 (digit_to_number): Move to lread.c.
7496 (Fstring_to_number): Use new string_to_number function, to be
7497 consistent with how the Lisp reader treats infinities and NaNs.
7498 Do not assume that floating-point numbers represent EMACS_INT
7499 without losing information; this is not true on most 64-bit hosts.
7500 Avoid double-rounding errors, by insisting on integers when
7501 parsing non-base-10 numbers, as the documentation specifies.
7502 * lisp.h (string_to_number): New decl, replacing ...
7503 (isfloat_string): Remove.
bc0a5c13 7504 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7505 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7506 appears to have been a coding error. Similarly, do not accept
7507 strings like +-1e0 as floating point numbers. Do not report
7508 overflow for integer overflows unless the base is not 10 which
7509 means we have no simple and reliable way to continue.
7510 Break out the floating-point parsing into a new
7511 function string_to_number, so that Fstring_to_number parses
7512 floating point numbers consistently with the Lisp reader.
04f2d78b 7513 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7514 (E_CHAR, EXP_INT): Remove, replacing with ...
7515 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7516 (string_to_number): New function, replacing isfloat_string.
7517 This function checks for valid syntax and produces the resulting
7518 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7519 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7520 so that overflow for non-base-10 numbers is reported only when
7521 there's no portable and simple way to convert to floating point.
452f4150 7522
67769ffc
PE
7523 * textprop.c (set_text_properties_1): Rewrite for clarity,
7524 and to avoid GCC warning about integer overflow.
7525
c20db43f
PE
7526 * intervals.h (struct interval): Use EMACS_INT for members
7527 where EMACS_UINT might cause problems. See
7528 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7529 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7530 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7531 All uses changed.
37aa2f85
PE
7532 (offset_intervals): Tell GCC not to worry about length overflow
7533 when negating a negative length.
c20db43f 7534
2538aa2f
PE
7535 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7536 (overrun_check_free): Likewise.
7537
f2d3008d
PE
7538 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7539 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7540 word size.
7541
ec8df744
PE
7542 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7543 (gnutls_make_error): Rename local to avoid shadowing.
7544 (gnutls_emacs_global_deinit): ifdef out; not used.
7545 (Fgnutls_boot): Use const for pointer to readonly storage.
7546 Comment out unused local. Fix pointer signedness problems.
7547
640ee02d
PE
7548 * lread.c (openp): Don't stuff size_t into an 'int'.
7549 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7550 about possible signed overflow.
7551
6048fb2a
PE
7552 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7553 (GDK_KEY_g): Don't define if already defined.
7554 (xg_prepare_tooltip): Avoid pointer signedness problem.
7555 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7556
fa3c87e1
PE
7557 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7558 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7559
2172544b
PE
7560 * xfns.c (Fx_window_property): Simplify a bit,
7561 to make a bit faster and to avoid GCC 4.6.0 warning.
7562 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7563
9b821a21
PE
7564 * fns.c (internal_equal): Don't assume size_t fits in int.
7565
3c616cfa
PE
7566 * alloc.c (compact_small_strings): Tighten assertion a little.
7567
c2982e87
PE
7568 Replace pEd with more-general pI, and fix some printf arg casts.
7569 * lisp.h (pI): New macro, generalizing old pEd macro to other
7570 conversion specifiers. For example, use "...%"pI"d..." rather
7571 than "...%"pEd"...".
7572 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7573 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7574 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7575 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7576 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7577 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7578 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7579 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7580 64-bit hosts.
7581 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7582 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7583 * print.c (safe_debug_print, print_object): Likewise.
7584 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7585 to int.
6f04d126
PE
7586 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7587 avoiding the 0 flag, which is not portable.
c2982e87
PE
7588 * process.c (Fmake_network_process): Use pI to avoid cast.
7589 * region-cache.c (pp_cache): Likewise.
7590 * xdisp.c (decode_mode_spec): Likewise.
7591 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7592 behavior on 64-bit hosts with printf arg.
6f04d126 7593 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7594 (x_stop_queuing_selection_requests): Likewise.
7595 (x_get_window_property): Don't truncate byte count to an 'int'
7596 when tracing.
0b432f21 7597
5e073ec7
PE
7598 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7599 here, since it parses constructs like leading '-' and spaces,
7600 which are not wanted; and it overflows with large numbers.
7601 Instead, simply match F[0-9]+, which is what is wanted anyway.
7602
36372bf9
PE
7603 * alloc.c: Remove unportable assumptions about struct layout.
7604 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7605 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7606 (allocate_vectorlike, make_pure_vector): Use the new macros,
7607 plus offsetof, to remove unportable assumptions about struct layout.
7608 These assumptions hold on all porting targets that I know of, but
7609 they are not guaranteed, they're easy to remove, and removing them
7610 makes further changes easier.
7611
0b432f21
PE
7612 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7613 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7614 (string_overrun_cookie): Now const. Use initializers that
7615 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7616 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7617 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7618 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7619 multiple of sizeof (EMACS_INT); it need not be, if
7620 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7621 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7622
895009e1
JB
76232011-04-26 Juanma Barranquero <lekktu@gmail.com>
7624
7625 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7626
6a7a1b0b
TZ
76272011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7628
7629 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7630 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7631 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7632
841a1577 76332011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7634
7635 * lisp.h (Qdebug): List symbol.
895009e1 7636 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7637 * keyboard.c (debug-on-event): New variable.
7638 (handle_user_signal): Break into debugger when debug-on-event
7639 matches the current signal symbol.
7640
f2d3ba6f
DN
76412011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7642
7643 * alloc.c (check_sblock, check_string_bytes)
7644 (check_string_free_list): Convert to standard C.
7645
42ce4c63
TZ
76462011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7647
7648 * w32.c (emacs_gnutls_push): Fix typo.
7649
825cd63c
EZ
76502011-04-25 Eli Zaretskii <eliz@gnu.org>
7651
fb11d64d
EZ
7652 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7653 "cast to pointer from integer of different size".
7654
825cd63c
EZ
7655 Improve doprnt and its use in verror. (Bug#8545)
7656 * doprnt.c (doprnt): Document the set of format control sequences
7657 supported by the function. Use SAFE_ALLOCA instead of always
7658 using `alloca'.
7659
7660 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7661 is one byte too soon. Don't use xrealloc; instead xfree and
7662 xmalloc anew.
7663
e061a11b
TZ
76642011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7665
7666 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7667 callbacks stage.
7668
7669 * gnutls.c: Renamed global_initialized to
7670 gnutls_global_initialized. Added internals for the
7671 :verify-hostname-error, :verify-error, and :verify-flags
7672 parameters of `gnutls-boot' and documented those parameters in the
7673 docstring. Start callback support.
9173deec
JB
7674 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7675 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7676 on error. Return error code.
e061a11b
TZ
7677 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7678 (emacs_gnutls_read): Likewise.
7679 (Fgnutls_boot): Return handshake error code.
7680 (emacs_gnutls_handle_error): New function.
7681 (wsaerror_to_errno): Likewise.
7682
7683 * w32.h (emacs_gnutls_pull): Add prototype.
7684 (emacs_gnutls_push): Likewise.
7685
7686 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7687 (emacs_gnutls_push): Likewise.
7688
76892011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7690
7691 * process.c (wait_reading_process_output): Check if GnuTLS
7692 buffered some data internally if no FDs are set for TLS
7693 connections.
7694
7695 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7696 (LIBS): Link to USER_LIBS.
7697 ($(BLD)/gnutls.$(0)): New target.
7698
fa6996bc
EZ
76992011-04-24 Eli Zaretskii <eliz@gnu.org>
7700
eb35682e
EZ
7701 * xdisp.c (handle_single_display_spec): Rename the
7702 display_replaced_before_p argument into display_replaced_p, to
7703 make it consistent with the commentary. Fix typos in the
7704 commentary.
7705
e2ad650c
EZ
7706 * textprop.c (syms_of_textprop): Remove dead code.
7707 (copy_text_properties): Delete obsolete commentary about an
7708 interface that was deleted long ago. Fix typos in the description
7709 of arguments.
7710
1b2de274
EZ
7711 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7712 to changes in oldXMenu/XMenu.h from 2011-04-16.
7713 <menu_help_message, prev_menu_help_message>: Constify.
7714 (IT_menu_make_room): menu->help_text is now `const char **';
7715 adjust.
7716
7717 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7718 to changes in oldXMenu/XMenu.h from 2011-04-16.
7719 (struct XMenu): Declare `help_text' `const char **'.
7720
7721 * xfaces.c <Qunspecified>: Make extern again.
7722
7723 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 7724 required by POSIX.
1b2de274 7725
762b15be
EZ
7726 * doc.c (get_doc_string): Improve the format passed to `error'.
7727
7728 * doprnt.c (doprnt): Improve commentary.
7729
7730 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7731
7732 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7733 them with etags.
7734
f1052e5d
EZ
7735 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7736 changes in globals.h immediately force recompilation.
762b15be
EZ
7737 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7738 $(CURDIR)/s/ms-w32.h.
7739 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7740
fa6996bc
EZ
7741 * character.c (Fchar_direction): Function deleted.
7742 (syms_of_character): Don't defsubr it.
7743 <char-direction-table>: Deleted.
7744
e6c3da20
EZ
77452011-04-23 Eli Zaretskii <eliz@gnu.org>
7746
7747 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7748 * doprnt.c: Include limits.h.
7749 (SIZE_MAX): New macro.
04f2d78b
CB
7750 (doprnt): Return a size_t value. 2nd arg is now size_t.
7751 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7752 Improve overflow protection. Support `l' modifier for integer
7753 conversions. Support %l conversion. Don't assume an EMACS_INT
7754 argument for integer conversions and for %c.
7755
7756 * lisp.h (doprnt): Restore prototype.
7757
7758 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7759 $(SRC)/character.h.
7760
7761 * Makefile.in (base_obj): Add back doprnt.o.
7762
7763 * deps.mk (doprnt.o): Add back prerequisites.
7764 (callint.o): Depend on character.h.
7765
7766 * eval.c (internal_lisp_condition_case): Include the handler
7767 representation in the error message.
7768 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7769 when breaking from the loop.
7770
7771 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7772
7773 * callint.c (Fcall_interactively): When displaying error message
7774 about invalid control letter, pass the character's codepoint, not
7775 a pointer to its multibyte form. Improve display of the character
7776 in octal and display also its hex code.
7777
7778 * character.c (char_string): Use %x to display the (unsigned)
7779 codepoint of an invalid character, to avoid displaying a bogus
7780 negative value.
7781
7782 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7783 `error', not SYMBOL_NAME itself.
7784
7785 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7786 character arguments to `error'.
7787
7788 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7789 to `error' in error message about FINAL_CHAR argument. Make sure
7790 FINAL_CHAR is a character, and use %c when it is passed as
7791 argument to `error'.
7792
4ffd0d6b 77932011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7794
7795 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7796
7797 * w32.c: Include <time.h>.
7798 (sys_localtime): New function.
7799
4ffd0d6b 78002011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7801
7802 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7803
4ffd0d6b 7804 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7805
4ffd0d6b 78062011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7807
4ffd0d6b
GM
7808 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7809 zombies (Bug#8467).
aac0c6e3 7810
04c56954
EZ
78112011-04-19 Eli Zaretskii <eliz@gnu.org>
7812
7813 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7814 gl_state.e_property when gl_state.object is Qt.
7815
7816 * insdel.c (make_gap_larger): Remove limitation of buffer size
7817 to <= INT_MAX.
7818
16a43933
CY
78192011-04-18 Chong Yidong <cyd@stupidchicken.com>
7820
7821 * xdisp.c (lookup_glyphless_char_display)
7822 (produce_glyphless_glyph): Handle cons cell entry in
7823 glyphless-char-display.
7824 (Vglyphless_char_display): Document it.
7825
7826 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7827 glyphless-char-display.
7828
4581706e
CY
78292011-04-17 Chong Yidong <cyd@stupidchicken.com>
7830
7831 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7832
7833 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7834
7835 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7836 definition for no-X builds.
7837
4887c6e2 78382011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7839
fd35b6f9
PE
7840 Static checks with GCC 4.6.0 and non-default toolkits.
7841
5c1ccb01
PE
7842 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7843
006c5daa
PE
7844 * process.c (keyboard_bit_set): Define only if SIGIO.
7845 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7846 (send_process): Repair possible setjmp clobbering.
7847
efc736d3
PE
7848 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7849
4e2fe2e6
PE
7850 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7851
f97334a2
PE
7852 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7853
4e75f29d
PE
7854 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7855 Define only if needed.
7856
90efadd1
PE
7857 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7858 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7859 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7860
3c647824
PE
7861 * dispextern.h (struct redisplay_interface): Rename param
7862 to avoid shadowing.
e264f262 7863 * termhooks.h (struct terminal): Likewise.
761383f4 7864 * xterm.c (xembed_send_message): Likewise.
3c647824 7865
b58c5c4a
PE
7866 * insdel.c (make_gap_smaller): Define only if
7867 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7868
cad59032
PE
7869 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7870 it.
7871
c339dc2e
PE
7872 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7873 so that we aren't warned about unused symbols.
7874
91a3e27b
PE
7875 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7876
399c71d3 7877 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7878
8ffc96f5
PE
7879 * xfns.c (x_real_positions): Mark locals as initialized.
7880
eef9bc79
PE
7881 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7882
098db9dd
PE
7883 * xterm.c: Fix problems found by static analysis with other toolkits.
7884 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7885 (x_dispatch_event): Declare static if USE_GTK, and
7886 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7887 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7888 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7889 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7890 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7891
eb18f6cc
PE
7892 * xmenu.c (menu_help_callback): Pointer type fixes.
7893 Use const pointers when pointing at readonly data. Avoid pointer
7894 signedness clashes.
7895 (FALSE): Remove unused macro.
7896 (update_frame_menubar): Remove unused decl.
7897
1fe72bf8
PE
7898 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7899
60d9e1db
PE
7900 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7901 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7902 (single_menu_item): Rename local to avoid shadowing.
7903
39261c26
PE
7904 * keyboard.c (make_lispy_event): Remove unused local var.
7905
018c5e19
PE
7906 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7907 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7908
63d2b86e
PE
7909 * bitmaps: Change bitmaps from unsigned char back to the X11
7910 compatible char. Avoid the old compiler warnings about
7911 out-of-range initializers by using, for example, '\xab' rather
7912 than 0xab.
7913
aefd87e1
PE
7914 * xgselect.c (xgselect_initialize): Check vs interface
7915 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7916
bf501fb9
PE
7917 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7918
e9829fdf
PE
7919 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7920 to read-only memory.
7921
1086c095
PE
7922 * fns.c (vector): Remove; this old hack is no longer needed.
7923
2baccd04 7924 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7925 Remove unused var.
dde42981 7926 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7927
72391843 7928 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7929
436c16df 7930 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7931 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7932 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7933
92bb796d 7934 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7935 (x_term_init): Remove local to avoid shadowing.
92bb796d 7936
764430a3 7937 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7938
7939 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7940 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7941
d1dfb56c
EZ
79422011-04-16 Eli Zaretskii <eliz@gnu.org>
7943
c4354cb4
EZ
7944 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7945
d1dfb56c
EZ
7946 Fix regex.c, syntax.c and friends for buffers > 2GB.
7947 * syntax.h (struct gl_state_s): Declare character position members
7948 EMACS_INT.
7949
7950 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7951
04f2d78b
CB
7952 * textprop.c (verify_interval_modification, interval_of):
7953 Declare arguments EMACS_INT.
d1dfb56c
EZ
7954
7955 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7956 EMACS_INT.
7957
7958 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7959
7960 * indent.c (Fvertical_motion): Local variable it_start is now
7961 EMACS_INT.
7962
7963 * regex.c (re_match, re_match_2, re_match_2_internal)
7964 (bcmp_translate, regcomp, regexec, print_double_string)
7965 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7966 (re_compile_pattern, re_exec): Declare arguments and local
7967 variables `size_t' and `ssize_t' and return values `regoff_t', as
7968 appropriate.
7969 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7970 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7971 <compile_stack_type>: `size' and `avail' are now `size_t'.
7972
7973 * regex.h <regoff_t>: Use ssize_t, not int.
7974 (re_search, re_search_2, re_match, re_match_2): Arguments that
7975 specify buffer/string position and length are now ssize_t and
7976 size_t. Return type is regoff_t.
7977
613052cd
BK
79782011-04-16 Ben Key <bkey76@gmail.com>
7979
7980 * nsfont.m: Fixed bugs in ns_get_family and
7981 ns_descriptor_to_entity that were caused by using free to
7982 deallocate memory blocks that were allocated by xmalloc (via
7983 xstrdup). This caused Emacs to crash when compiled with
7984 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7985 --enable-checking=xmallocoverrun). xfree is now used to
7986 deallocate these memory blocks.
7987
4170f62f 79882011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7989
71b41406
PE
7990 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7991
9587a89d
PE
7992 emacs_write: Accept and return EMACS_INT for sizes.
7993 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7994 et seq.
7995 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7996 Accept and return EMACS_INT.
7997 (emacs_gnutls_write): Return the number of bytes written on
7998 partial writes.
7999 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
8000 (emacs_read, emacs_write): Remove check for negative size, as the
8001 Emacs source code has been audited now.
9587a89d
PE
8002 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
8003 (emacs_read, emacs_write): Use it.
273a5f82
PE
8004 * process.c (send_process): Adjust to the new signatures of
8005 emacs_write and emacs_gnutls_write. Do not attempt to store
8006 a byte offset into an 'int'; it might overflow.
9587a89d 8007 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 8008
3e047f51
PE
8009 * sound.c: Don't assume sizes fit in 'int'.
8010 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 8011 Return EMACS_INT, not int.
3e047f51 8012 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
8013 Accept EMACS_INT, not int.
8014 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
8015 record read return values.
8016
cc39a9db
BK
80172011-04-15 Ben Key <bkey76@gmail.com>
8018
c9d0ec6d
JB
8019 * keyboard.c (Qundefined): Don't declare static since it is used
8020 in nsfns.m.
8021 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
8022 static since they are used in nsfont.m.
cc39a9db 8023
6c60eb9f
SM
80242011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
8025
8026 * process.c (Qprocessp): Don't declare static.
8027 * lisp.h (Qprocessp): Declare again.
8028
7990b61a
JB
80292011-04-15 Juanma Barranquero <lekktu@gmail.com>
8030
8031 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
8032
5d4cb038
PE
80332011-04-14 Paul Eggert <eggert@cs.ucla.edu>
8034
8bd7b830 8035 Improve C-level modularity by making more things 'static'.
cd64ea1d 8036
e3b27b31
PE
8037 Don't publish debugger-only interfaces to other modules.
8038 * lisp.h (safe_debug_print, debug_output_compilation_hack):
8039 (verify_bytepos, count_markers): Move decls to the only modules
8040 that need them.
8041 * region-cache.h (pp_cache): Likewise.
8042 * window.h (check_all_windows): Likewise.
8043 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
8044
5d4cb038
PE
8045 * sysdep.c (croak): Now static, if
8046 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
8047 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
8048
8049 * alloc.c (refill_memory_reserve): Now static if
8050 !defined REL_ALLOC || defined SYSTEM_MALLOC.
8051 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 8052
e87b6180
PE
8053 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
8054 Define only if USE_LUCID.
8055
ac64929e
PE
8056 * xrdb.c (x_customization_string, x_rm_string): Now static.
8057
6f37259d
PE
8058 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
8059 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
8060
1683e3ab
PE
8061 * xdisp.c (draw_row_with_mouse_face): Now static.
8062 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
8063
de9c2632
PE
8064 * window.h (check_all_windows): Mark externally visible.
8065
2b96acb7
PE
8066 * window.c (window_deletion_count): Now static.
8067
8068 * undo.c: Make symbols static if they're not exported.
8069 (last_undo_buffer, last_boundary_position, pending_boundary):
8070 Now static.
8071
50436f33
PE
8072 * textprop.c (interval_insert_behind_hooks): Now static.
8073 (interval_insert_in_front_hooks): Likewise.
8074
64520e5c
PE
8075 * term.c: Make symbols static if they're not exported.
8076 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8077 (max_frame_lines, tty_set_terminal_modes):
8078 (tty_reset_terminal_modes, tty_turn_off_highlight):
8079 (get_tty_terminal): Now static.
8080 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8081 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 8082 HAVE_WINDOW_SYSTEM.
64520e5c
PE
8083 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8084 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8085
1fa53021
PE
8086 * sysdep.c: Make symbols static if they're not exported.
8087 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8088 Now static.
8089 (sigprocmask_set, full_mask): Remove; unused.
8090 (wait_debugging): Mark as visible.
8091 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8092 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8093
d4b43b22
PE
8094 * syntax.c (syntax_temp): Define only if !__GNUC__.
8095
b7c513d0
PE
8096 * sound.c (current_sound_device, current_sound): Now static.
8097
989b29ad
PE
8098 * search.c (searchbufs, searchbuf_head): Now static.
8099
13a55a78
PE
8100 * scroll.c (scroll_cost): Remove; unused.
8101 * dispextern.h (scroll_cost): Remove decl.
8102
de68a1fc
PE
8103 * region-cache.h (pp_cache): Mark as externally visible.
8104
40ccffa6
PE
8105 * process.c: Make symbols static if they're not exported.
8106 (process_tick, update_tick, create_process, chan_process):
8107 (Vprocess_alist, proc_buffered_char, datagram_access):
8108 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8109 (deactivate_process): Mark defn as static, as well as decl.
8110 * lisp.h (create_process): Remove decl.
8111 * process.h (chan_process, Vprocess_alist): Remove decls.
8112
ad64fc97
PE
8113 * print.c: Make symbols static if they're not exported.
8114 (print_depth, new_backquote_output, being_printed, print_buffer):
8115 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8116 (print_interval, print_number_index, initial_stderr_stream):
8117 Now static.
8118 * lisp.h (Fprinc): Remove decl.
8119 (debug_output_compilation_hack): Mark as externally visible.
8120
adddb265
PE
8121 * sysdep.c (croak): Move decl from here to syssignal.h.
8122 * syssignal.h (croak): Put it here, so the API can be checked when
8123 'croak' is called from dissociate_if_controlling_tty.
8124
1717ede2
PE
8125 * minibuf.c: Make symbols static if they're not exported.
8126 (minibuf_save_list, choose_minibuf_frame): Now static.
8127 * lisp.h (choose_minibuf_frame): Remove decl.
8128
fa5fb2bc
PE
8129 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8130
1e3890d1
PE
8131 * lread.c: Make symbols static if they're not exported.
8132 (read_objects, initial_obarray, oblookup_last_bucket_number):
8133 Now static.
8134 (make_symbol): Remove; unused.
8135 * lisp.h (initial_obarray, make_symbol): Remove decls.
8136
8a1414fa
PE
8137 * keyboard.c: Make symbols static if they're not exported.
8138 (single_kboard, recent_keys_index, total_keys, recent_keys):
8139 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8140 (this_single_command_key_start, echoing, last_auto_save):
8141 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8142 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8143 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8144 (Vlispy_mouse_stem, double_click_count):
8145 Now static.
8146 (force_auto_save_soon): Define only if SIGDANGER.
8147 (ignore_mouse_drag_p): Now static if
8148 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8149 (print_help): Remove; unused.
8150 (stop_character, last_timer_event): Mark as externally visible.
8151 * keyboard.h (ignore_mouse_drag_p): Declare only if
8152 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8153 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8154 * lisp.h (echoing): Remove decl.
8155 (force_auto_save_soon): Declare only if SIGDANGER.
8156 * xdisp.c (redisplay_window): Simplify code, to make it more
8157 obvious that ignore_mouse_drag_p is not accessed if !defined
8158 USE_GTK && !defined HAVE_NS.
8159
93ea6e8f
PE
8160 * intervals.c: Make symbols static if they're not exported.
8161 (merge_properties_sticky, merge_interval_right, delete_interval):
8162 Now static.
8163 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8164
77382fcc
PE
8165 * insdel.c: Make symbols static if they're not exported.
8166 However, leave prepare_to_modify_buffer alone. It's never
8167 called from outside this function, but that appears to be a bug.
8168 (combine_after_change_list, combine_after_change_buffer):
4889fc82 8169 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
8170 (adjust_after_replace_noundo): Remove; unused.
8171 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 8172 (signal_before_change): Remove decls.
77382fcc 8173
9306c32e
PE
8174 * indent.c (val_compute_motion, val_vmotion): Now static.
8175
cd44d2eb
PE
8176 * image.c: Make symbols static if they're not exported.
8177 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8178 if USE_GTK.
8179 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8180 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8181
ad9a7a06
PE
8182 * fringe.c (standard_bitmaps): Now static.
8183 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8184
81626931
PE
8185 * frame.c: Make symbols static if they're not exported.
8186 (x_report_frame_params, make_terminal_frame): Now static.
8187 (get_frame_param): Now static, unless HAVE_NS.
8188 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8189 (x_get_resource_string): Remove; not used.
8190 * frame.h (make_terminal_frame, x_report_frame_params):
8191 (x_get_resource_string); Remove decls.
8192 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8193 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8194
239f9db9
PE
8195 * font.c, fontset.c: Make symbols static if they're not exported.
8196 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8197 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8198 * font.c (font_close_object): Now static.
8199 * font.h (font_close_object): Remove.
8200 * fontset.c (FONTSET_OBJLIST): Remove.
8201 (free_realized_fontset) #if-0 the body, which does nothing.
8202 (face_suitable_for_char_p): #if-0, as it's never called.
8203 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
8204 * xfaces.c (face_at_string_position):
8205 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
8206 since 0 is always ASCII.
8207
dfcf3579
PE
8208 * fns.c (weak_hash_tables): Now static.
8209
5045092b
PE
8210 * fileio.c: Make symbols static if they're not exported.
8211 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8212 (Vwrite_region_annotation_buffers): Now static.
8213
57a96f5c
PE
8214 * eval.c: Make symbols static if they're not exported.
8215 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8216 * lisp.h (backtrace_list): Remove decl.
8217
35f08c38
PE
8218 * emacs.c: Make symbols static if they're not exported.
8219 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8220 (fatal_error_code, fatal_error_signal_hook, standard_args):
8221 Now static.
8222 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8223 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8224 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8225 * lisp.h (fatal_error_signal_hook): Remove decl.
8226 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8227
f44bd759
PE
8228 * editfns.c: Move a (normally-unused) function to its only use.
8229 * editfns.c, lisp.h (get_operating_system_release): Remove.
8230 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8231 worth the hassle of breaking this out.
8232
b532497d
PE
8233 * xterm.c: Make symbols static if they're not exported.
8234 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8235 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8236 (x_destroy_window, x_delete_display):
8237 Now static.
8238 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8239 (x_mouse_leave): Remove; unused.
8240 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8241 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8242 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8243 Remove decls.
8244 (x_mouse_leave): Declare only if WINDOWSNT.
8245 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8246 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8247 USE_X_TOOLKIT.
8248
1675728f
PE
8249 * ftxfont.c: Make symbols static if they're not exported.
8250 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8251 HAVE_FREETYPE.
8252 * font.h (ftxfont_driver): Likewise.
8253
e4cebfca
PE
8254 * xfns.c: Make symbols static if they're not exported.
8255 (x_last_font_name, x_display_info_for_name):
8256 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8257 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8258 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8259 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8260 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8261 (last_show_tip_args): Now static.
8262 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8263 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8264 (x_screen_planes): Remove; unused.
8265 * dispextern.h (x_screen_planes): Remove decl.
8266
5bf46f05
PE
8267 * dispnew.c: Make symbols static if they're not exported.
8268 * dispextern.h (redraw_garbaged_frames, scrolling):
8269 (increment_row_positions): Remove.
8270 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8271 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8272 Now static.
8273 (redraw_garbaged_frames): Remove; unused.
8274
435f4c28
PE
8275 * xfaces.c: Make symbols static if they're not exported.
8276 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8277 Remove decls.
8278 * xterm.h (defined_color): Remove decls.
8279 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8280 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8281 (menu_face_changed_default, defined_color, free_realized_face):
8282 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8283 (ascii_face_of_lisp_face): Remove; unused.
8284
8524aef3
PE
8285 * xdisp.c: Make symbols static if they're not exported.
8286 * dispextern.h (scratch_glyph_row, window_box_edges):
8287 (glyph_to_pixel_coords, set_cursor_from_row):
8288 (get_next_display_element, set_iterator_to_next):
8289 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8290 (show_mouse_face): Remove decls
8291 * frame.h (message_buf_print): Likewise.
8292 * lisp.h (pop_message, set_message, check_point_in_composition):
8293 Likewise.
8294 * xterm.h (set_vertical_scroll_bar): Likewise.
8295 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8296 (message_buf_print, scratch_glyph_row, displayed_buffer):
8297 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8298 (get_next_display_element, show_mouse_face, window_box_edges):
8299 (frame_to_window_pixel_xy, check_point_in_composition):
8300 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8301 (glyph_to_pixel_coords): Remove; unused.
8302
16390cd2
PE
8303 * dired.c (file_name_completion): Now static.
8304
8305 * dbusbind.c (xd_in_read_queued_messages): Now static.
8306
a25f4dfa
PE
8307 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8308 * data.c (circular_list_error): Remove.
8309
14a9c8df
PE
8310 * commands.h (last_point_position, last_point_position_buffer):
8311 (last_point_position_window): Remove decls.
8312 * keyboard.c: Make these variables static.
8313
04f2d78b
CB
8314 * coding.h (coding, code_convert_region, encode_coding_gap):
8315 Remove decls.
74ab6df5
PE
8316 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8317 (iso_code_class, detect_coding, code_convert_region): Now static.
8318 (encode_coding_gap): Remove; unused.
8319
38dfbee1
PE
8320 * chartab.c (chartab_chars, chartab_bits): Now static.
8321
a2cb4e63
PE
8322 * charset.h (charset_iso_8859_1): Remove decl.
8323 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8324 Now static.
8325
127198fd
PE
8326 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8327 * ccl.c (Vccl_program_table): Now static.
8328 (check_ccl_update): Remove; unused.
8329
d85b608f
PE
8330 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8331 * category.h: ... from here.
8332 * category.c (check_category_table, set_category_set): Now static.
8333
31cd66f3
PE
8334 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8335 * lisp.h: Remove these decls.
8336
c358e587
PE
8337 * buffer.c (buffer_count): Remove unused var.
8338
e78aecca
PE
8339 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8340 so that it's not optimized away.
8341 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8342 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8343 exported only to the debugger.
8344
e192d7d3 8345 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 8346 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 8347
92470028
PE
8348 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8349 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8350 was inaccessible from Lisp.
8351 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8352 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8353
244ed907
PE
8354 alloc.c: Import and export fewer symbols, and remove unused items.
8355 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8356 is defined.
8357 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8358 it's not optimized away by whole-program optimization.
8359 (message_enable_multibyte, free_misc): Remove.
8360 (catchlist, handlerlist, mark_backtrace):
8361 Declare only if BYTE_MARK_STACK.
8362 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8363 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8364 (message_enable_multibyte): Remove decl.
8365 (free_misc, interval_free_list, float_block, float_block_index):
8366 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8367 (cons_free_list, last_marked_index):
8368 Now static.
8369 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8370 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8371 (mark_backtrace): Define only if BYTE_MARK_STACK.
8372 * xdisp.c (message_enable_multibyte): Now static.
8373
61c2b50e 8374 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
8375 This makes it easier for human readers (and static analyzers)
8376 to see whether these variables are used from other modules.
8377 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8378 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8379 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8380 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8381 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8382 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8383 * xmenu.c, xselect.c:
8384 Declare Q* vars static if they are not used in other modules.
8385 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8386 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8387 Remove decls of unexported vars.
8388 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8389
95c82688
PE
8390 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8391
16a97296
PE
8392 Make Emacs functions such as Fatom 'static' by default.
8393 This makes it easier for human readers (and static analyzers)
8394 to see whether these functions can be called from other modules.
8395 DEFUN now defines a static function. To make the function external
8396 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
8397 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8398 (Finit_image_library):
16a97296
PE
8399 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8400 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8401 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8402 Remove decls, since these functions are now static.
8403 (Funintern, Fget_internal_run_time): New decls, since these functions
8404 were already external.
95c82688 8405
16a97296
PE
8406 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8407 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8408 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8409 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8410 * keyboard.c, keymap.c, lread.c:
8411 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8412 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8413 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8414 Mark functions with DEFUE instead of DEFUN,
8415 if they are used in other modules.
8416 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8417 decls for now-static functions.
8418 * buffer.h (Fdelete_overlay): Remove decl.
8419 * callproc.c (Fgetenv_internal): Mark as internal.
8420 * composite.c (Fremove_list_of_text_properties): Remove decl.
8421 (Fcomposition_get_gstring): New forward static decl.
8422 * composite.h (Fcomposite_get_gstring): Remove decl.
8423 * dired.c (Ffile_attributes): New forward static decl.
8424 * doc.c (Fdocumntation_property): New forward static decl.
8425 * eval.c (Ffetch_bytecode): New forward static decl.
8426 (Funintern): Remove extern decl; now in .h file where it belongs.
8427 * fileio.c (Fmake_symbolic_link): New forward static decl.
8428 * image.c (Finit_image_library): New forward static decl.
8429 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8430 * intervals.h (Fprevious_property_change):
8431 (Fremove_list_of_text_properties): Remove decls.
8432 * keyboard.c (Fthis_command_keys): Remove decl.
8433 (Fcommand_execute): New forward static decl.
8434 * keymap.c (Flookup_key): New forward static decl.
8435 (Fcopy_keymap): Now static.
8436 * keymap.h (Flookup_key): Remove decl.
8437 * process.c (Fget_process): New forward static decl.
8438 (Fprocess_datagram_address): Mark as internal.
8439 * syntax.c (Fsyntax_table_p): New forward static decl.
8440 (skip_chars): Remove duplicate decl.
8441 * textprop.c (Fprevious_property_change): New forward static decl.
8442 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8443 Now internal.
8444 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8445 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8446
785bbd42
PE
8447 * editfns.c (Fformat): Remove unreachable code.
8448
8b913b57
AS
84492011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8450
8451 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8452 change. (Bug#8496)
8453
a6744a35
EZ
84542011-04-13 Eli Zaretskii <eliz@gnu.org>
8455
8456 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8457 when at ZV. (Bug#8487)
8458
e7974947
AS
84592011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8460
baad03f0
AS
8461 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8462 (Bug#8437)
8463 * keyboard.c (parse_tool_bar_item): Likewise.
8464 * sound.c (sound_cleanup, alsa_close): Likewise.
8465 * termcap.c (tgetent): Likewise.
8466 * xfns.c (x_default_font_parameter): Likewise.
8467 * xsettings.c (read_and_apply_settings): Likewise.
8468
e7974947
AS
8469 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8470 (overrun_check_free): Protoize.
8471
28272684
PE
84722011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8473
8474 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8475 since callers should never pass a negative size.
8476 Change the signature to match that of plain 'read' and 'write'; see
8477 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8478 * lisp.h: Update prototypes of emacs_write and emacs_read.
8479
11997c76
EZ
84802011-04-11 Eli Zaretskii <eliz@gnu.org>
8481
8482 * xdisp.c (redisplay_window): Don't try to determine the character
8483 position of the scroll margin if the window start point w->startp
e896f03c 8484 is outside the buffer's accessible region. (Bug#8468)
11997c76 8485
8a2cbd72
EZ
84862011-04-10 Eli Zaretskii <eliz@gnu.org>
8487
8488 Fix write-region and its subroutines for buffers > 2GB.
8489 * fileio.c (a_write, e_write): Modify declaration of arguments and
8490 local variables to support buffers larger than 2GB.
8491 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8492
8493 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8494 argument, local variables, and return value.
8495
8496 * lisp.h: Update prototypes of emacs_write and emacs_read.
8497
8498 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8499
4073e537 85002011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8501
1ebfdcb6
PE
8502 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8503
b2ded58d
PE
8504 Fix more problems found by GCC 4.6.0's static checks.
8505
7d66342c
PE
8506 * xdisp.c (vmessage): Use a better test for character truncation.
8507
bbf47d44
PE
8508 * charset.c (load_charset_map): <, not <=, for optimization,
8509 and to avoid potential problems with integer overflow.
9248994d 8510 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8511 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8512 * editfns.c (Fformat): Likewise.
1e69125e 8513 * syntax.c (skip_chars): Likewise.
3befa583 8514
e3019616
PE
8515 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8516 This also lets GCC 4.6.0 generate slightly better loop code.
8517
becfa255
PE
8518 * callint.c (Fcall_interactively): <, not <=, for optimization.
8519 (Fcall_interactively): Count the number of arguments produced,
8520 not the number of arguments given. This is simpler and lets GCC
8521 4.6.0 generate slightly better code.
8522
dae0cd48
PE
8523 * ftfont.c: Distingish more carefully between FcChar8 and char.
8524 The previous code passed unsigned char * to a functions like
8525 strlen and xstrcasecmp that expect char *, which does not
8526 conform to the C standard.
8527 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8528 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8529 char * when the C standard requires it.
8530
76032d70
PE
8531 * keyboard.c (read_char): Remove unused var.
8532
eb3f1cc8
PE
8533 * eval.c: Port to Windows vsnprintf (Bug#8435).
8534 Include <limits.h>.
8535 (SIZE_MAX): Define if the headers do not.
8536 (verror): Do not give up if vsnprintf returns a negative count.
8537 Instead, grow the buffer. This ports to Windows vsnprintf, which
8538 does not conform to C99. Problem reported by Eli Zaretskii.
8539 Also, simplify the allocation scheme, by avoiding the need for
8540 calling realloc, and removing the ALLOCATED variable.
8541
70476b54
PE
8542 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8543
12020a9e
PE
8544 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8545 But keep the doprint source code for now, as we might revamp it
8546 and use it again (Bug#8435).
ea6c7ae6
PE
8547 * lisp.h (doprnt): Remove.
8548 * Makefile.in (base_obj): Remove doprnt.o.
8549 * deps.mk (doprnt.o): Remove.
8550
5fdb398c
PE
8551 error: Print 32- and 64-bit integers portably (Bug#8435).
8552 Without this change, on typical 64-bit hosts error ("...%d...", N)
8553 was used to print both 32- and 64-bit integers N, which relied on
8554 undefined behavior.
61bdb816 8555 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8556 * lisp.h (error, verror): Mark as printf-like functions.
8557 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8558 Report overflow in size calculations when allocating printf buffer.
8559 Do not truncate output string at its first null byte.
8560 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8561 Truncate the output at a character boundary, since vsnprintf does not
8562 do that.
8563 * charset.c (check_iso_charset_parameter): Convert internal
8564 character to string before calling 'error', since %c now has the
8565 printf meaning.
8566 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8567 overflow when computing char to be passed to 'error'. Do not
8568 pass Lisp_Object to 'error'; pass the integer instead.
8569 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8570 formatted with plain %d.
8571
b189fa66
PE
8572 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8573
bff87ef0
PE
8574 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8575
7e2cac20
PE
8576 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8577
ce4d90b5
PE
8578 * xterm.c (x_catch_errors): Remove duplicate declaration.
8579
266c9547
PE
8580 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8581
79c49ad2
PE
8582 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8583
368f4090
JM
85842011-04-10 Jim Meyering <meyering@redhat.com>
8585
8586 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8587 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8588 return ssize_t not "int", and use size_t as the buffer length.
8589 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8590 * gnutls.h: Update declarations.
8591 * process.c (read_process_output): Use ssize_t, to match.
8592 (send_process): Likewise.
8593
a32d4040
CY
85942011-04-09 Chong Yidong <cyd@stupidchicken.com>
8595
8596 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8597
8546720e 85982011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8599
04f2d78b
CB
8600 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8601 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8602
8546720e
GM
8603 * xterm.c (handle_one_xevent):
8604 * xmenu.c (create_and_show_popup_menu):
8605 * xselect.c (x_decline_selection_request)
8606 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8607
0a2f5c1a 86082011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8609
8610 Fix some uses of `int' instead of EMACS_INT.
8611 * search.c (string_match_1, fast_string_match)
8612 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8613 (scan_buffer, find_next_newline_no_quit)
8614 (find_before_next_newline, search_command, Freplace_match)
8615 (Fmatch_data): Make some `int' variables be EMACS_INT.
8616
8617 * xdisp.c (display_count_lines): 3rd argument and return value now
8618 EMACS_INT. All callers changed.
8619 (pint2hrstr): Last argument is now EMACS_INT.
8620
8621 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8622 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8623 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8624 (decode_coding_utf_16, decode_coding_emacs_mule)
8625 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8626 (decode_coding_ccl, decode_coding_charset)
8627 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8628 (decode_coding_iso_2022, decode_coding_emacs_mule)
8629 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8630 <char_offset, last_offset>: Declare EMACS_INT.
8631 (encode_coding_utf_8, encode_coding_utf_16)
8632 (encode_coding_emacs_mule, encode_invocation_designation)
8633 (encode_designation_at_bol, encode_coding_iso_2022)
8634 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8635 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8636 Declare EMACS_INT.
8637 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8638 (encode_invocation_designation): Last argument P_NCHARS is now
8639 EMACS_INT.
8640 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8641 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8642
8643 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8644 All users changed.
8645
8646 * ccl.c (Fccl_execute_on_string): Declare some variables
8647 EMACS_INT.
8648
8546720e 86492011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8650
8651 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8652
4e19a977
CS
86532011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8654
8655 * process.c (Fformat_network_address): Doc fix.
8656
87302331
R
86572011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8658
ee7683eb 8659 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8660
cbb59342
CY
86612011-04-08 Chong Yidong <cyd@stupidchicken.com>
8662
8663 * keyboard.c (read_char): Call Lisp function help-form-show,
8664 instead of using internal_with_output_to_temp_buffer.
8665 (Qhelp_form_show): New var.
e0d38eeb 8666 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8667
8668 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8669
8670 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8671
e67a13ab
CY
86722011-04-06 Chong Yidong <cyd@stupidchicken.com>
8673
04f2d78b
CB
8674 * process.c (Flist_processes): Remove to Lisp.
8675 (list_processes_1): Delete.
e67a13ab 8676
973f782d
EZ
86772011-04-06 Eli Zaretskii <eliz@gnu.org>
8678
7c106b1e
EZ
8679 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8680
973f782d
EZ
8681 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8682
41cf7d1a 86832011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8684
ca23cc88
PE
8685 Fix more problems found by GCC 4.6.0's static checks.
8686
f390e2d5
PE
8687 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8688
42eea0d0
PE
8689 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8690
b69769da 8691 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8692
f9541e84
PE
8693 * xdisp.c (vmessage): Mark as a printf-like function.
8694
13841b55
PE
8695 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8696
c136c10f
PE
8697 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8698
5e2d4a30
PE
8699 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8700 printf-like functions.
8701 (tiff_load): Add casts to remove these marks before passing them
8702 to system-supplied API.
8703
583f48b9
PE
8704 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8705
b25d760e
PE
8706 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8707 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8708 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8709 directly, rather than having caller test rule sign. This avoids
8710 some unnecessary tests.
8711 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8712 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8713 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8714
bc7b6697 8715 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8716 (xfont_open): Avoid unnecessary tests.
bc7b6697 8717
27ccc379
PE
8718 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8719
dcd5c89a
PE
8720 * composite.h, composite.c (composition_gstring_put_cache):
8721 Use EMACS_INT, not int, for length.
8722
b13a45c6
PE
8723 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8724 breaking out part of COMPOSITION_DECODE_RULE.
8725 (COMPOSITION_DECODE_RULE): Use it.
8726 * composite.c (get_composition_id): Remove unused local vars,
8727 by using the new macro.
8728
1e792e4d
PE
8729 * textprop.c (set_text_properties_1): Change while to do-while,
8730 since the condition is always true at first.
8731
dc6c6455 8732 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8733 (interval_deletion_adjustment): Return unsigned value.
8734 All uses changed.
dc6c6455 8735
aba7731a
PE
8736 * process.c (list_processes_1, create_pty, read_process_output):
8737 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8738 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8739 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8740 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8741 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8742
fdfc4bf3
PE
8743 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8744
fca8fe46 8745 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8746 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8747
06a0259a 8748 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8749 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8750 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8751
e7b9e80f
PE
8752 * print.c (print_error_message): Avoid int overflow.
8753
56201685
PE
8754 * font.c (font_list_entities): Redo for clarity,
8755 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8756
78834453 8757 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8758 (font_score): Avoid potential overflow in diff calculation.
78834453 8759
0bc0b309 8760 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8761 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8762
e610eaca
PE
8763 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8764
b895abce
PE
8765 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8766 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8767 can always succeed if overflow has undefined behavior.
8768
1f1d9321 8769 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8770 (wordify): Omit three unnecessary tests.
1f1d9321 8771
c59478bc
PE
8772 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8773 All callers changed. This avoids the need for an unused var.
8774
79b73827
PE
8775 * casefiddle.c (casify_region): Remove var that is set but not used.
8776
a4db5dfe
PE
8777 * dired.c (file_name_completion): Remove var that is set but not used.
8778
43aae36e
PE
8779 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8780
2a47c44d 8781 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8782 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8783
a37c69bf
PE
8784 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8785 Check for integer overflow on size calculations.
8786
328ab8e7
PE
8787 * buffer.c (Fprevious_overlay_change): Remove var that is set
8788 but not used.
8789
e5a2a5cb
PE
8790 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8791 Remove vars that are set but not used.
8d84a6eb 8792 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8793 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8794
a60e5f68
PE
8795 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8796
f661cb61 8797 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8798 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8799
f0397f5a
PE
8800 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8801 that are set but not used.
8802
8664db06 8803 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8804 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8805
6abdaa4a
PE
8806 * xselect.c (x_get_local_selection, x_handle_property_notify):
8807 Remove vars that are set but not used.
8808
0ce7538d 8809 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8810 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8811
9ae848fc
PE
8812 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8813 Remove var that is set but not used.
0b918413
PE
8814 (scroll_bar_windows_size): Now size_t, not int.
8815 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8816 Check for overflow.
9ae848fc 8817
a5a62657
PE
8818 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8819 (map_tty_color) [!defined MSDOS]: Likewise.
8820
5c5cdd39
PE
8821 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8822
66ebf983
PE
8823 * coding.c: Remove vars that are set but not used.
8824 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8825 All callers changed.
8826 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8827 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8828 (decode_coding_charset): Remove vars that are set but not used.
8829
1be4d761
PE
8830 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8831 that is set but not used.
8832
47553fa8
PE
8833 * print.c (print_object): Remove var that is set but not used.
8834
1f7196bf 8835 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8836 The gnulib version avoids calling malloc in the usual case,
8837 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8838 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8839 * filelock.c (current_lock_owner): Likewise.
8840 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8841 * sysdep.c: Include allocator.h, careadlinkat.h.
8842 (emacs_no_realloc_allocator): New static constant.
8843 (emacs_readlink): New function.
fdb61804
PE
8844 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8845 ../lib/careadlinkat.h.
d1fdcab7 8846
f84c17c7
SM
88472011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8848
8849 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8850 first non-nil return value).
8851
ef3862ad
JD
88522011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8853
8854 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8855 if not defined (Bug#8403).
8856
376a7006
JB
88572011-04-02 Juanma Barranquero <lekktu@gmail.com>
8858
8859 * xdisp.c (display_count_lines): Remove parameter `start',
8860 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8861 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8862 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8863 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8864 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8865 and thereabouts. All callers changed.
8866 (get_per_char_metric): Remove parameter `f', unused since
8867 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8868
6ca3801d
JM
88692011-04-02 Jim Meyering <meyering@redhat.com>
8870
8871 do not dereference NULL upon failed strdup
8872 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8873 (ns_get_family): Likewise.
8874
d8e2b5ba
JB
88752011-04-02 Juanma Barranquero <lekktu@gmail.com>
8876
8877 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8878
8c74fcbd
JD
88792011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8880
8881 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8882 later (Bug#8403).
8883
7200d79c
SM
88842011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8885
03408648 8886 Add lexical binding.
7200d79c 8887
03408648
SM
8888 * window.c (Ftemp_output_buffer_show): New fun.
8889 (Fsave_window_excursion):
8890 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8891
8892 * lread.c (lisp_file_lexically_bound_p): New function.
8893 (Fload): Bind Qlexical_binding.
8894 (readevalloop): Remove `evalfun' arg.
8895 Bind Qinternal_interpreter_environment.
8896 (Feval_buffer): Bind Qlexical_binding.
8897 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8898 Mark as dynamic.
8899 (syms_of_lread): Declare `lexical-binding'.
8900
8901 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8902
8903 * keyboard.c (eval_dyn): New fun.
8904 (menu_item_eval_property): Use it.
ca105506
SM
8905
8906 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8907
03408648
SM
8908 * fns.c (concat, mapcar1): Accept byte-code-functions.
8909
8910 * eval.c (Fsetq): Handle lexical vars.
8911 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8912 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8913 (FletX, Flet): Obey lexical binding.
8914 (Fcommandp): Handle closures.
8915 (Feval): New `lexical' arg.
8916 (eval_sub): New function extracted from Feval. Use it almost
8917 everywhere where Feval was used. Look up vars in lexical env.
8918 Handle closures.
8919 (Ffunctionp): Move from subr.el.
8920 (Ffuncall): Handle closures.
8921 (apply_lambda): Remove `eval_flags'.
8922 (funcall_lambda): Handle closures and new byte-code-functions.
8923 (Fspecial_variable_p): New function.
8924 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8925 but without exporting it to Lisp.
23aba0ea 8926
23aba0ea 8927 * doc.c (Fdocumentation, store_function_docstring):
03408648 8928 * data.c (Finteractive_form): Handle closures.
23aba0ea 8929
03408648
SM
8930 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8931 interactive spec.
ba83908c 8932
04f2d78b
CB
8933 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8934 New byte-codes.
03408648
SM
8935 (exec_byte_code): New function extracted from Fbyte_code to handle new
8936 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8937
03408648 8938 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8939
03408648 8940 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8941
e2abce01
JB
89422011-03-31 Juanma Barranquero <lekktu@gmail.com>
8943
8944 * xdisp.c (redisplay_internal): Fix prototype.
8945
63696a73 89462011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8947
63696a73 8948 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8949 (try_scrolling): Use it when setting scroll_limit.
8950 Limit scrolling to 100 screen lines.
63696a73
EZ
8951 (redisplay_window): Even when falling back on "recentering",
8952 position point in the window according to scroll-conservatively,
8953 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8954
8955 (try_scrolling): When point is above the window, allow searching
8956 as far as scroll_max, or one screenful, to compute vertical
8957 distance from PT to the scroll margin position. This prevents
8958 try_scrolling from unnecessarily failing when
8959 scroll-conservatively is set to a value slightly larger than the
8960 window height. Clean up the case of PT below the margin at bottom
8961 of window: scroll_max can no longer be INT_MAX. When aggressive
8962 scrolling is in use, don't let point enter the opposite scroll
8963 margin as result of the scroll.
8964 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8965 threshold of 100 lines for never-recentering scrolling.
8966
e4cc2dfc
JB
89672011-03-31 Juanma Barranquero <lekktu@gmail.com>
8968
8969 * dispextern.h (move_it_by_lines):
8970 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8971 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8972 (message_log_check_duplicate): Remove parameters `prev_bol' and
8973 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8974 (redisplay_internal): Remove parameter `preserve_echo_area',
8975 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8976
8977 * indent.c (Fvertical_motion):
8978 * window.c (window_scroll_pixel_based, Frecenter):
8979 Don't pass `need_y_p' to `move_it_by_lines'.
8980
1c470562
SM
89812011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8982
44f230aa
SM
8983 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8984 steal a few bits to be more compact.
8985 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8986 Remove unneeded casts.
8987
1c470562
SM
8988 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8989
888adce9
ZK
89902011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8991
8992 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8993 binding" message (bug#7967).
8994
f838ed7b
PE
89952011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8996
77861b95
PE
8997 Fix more problems found by GCC 4.6.0's static checks.
8998
de6dbc14
PE
8999 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
9000 Remove unused local var.
9001
f838ed7b
PE
9002 * editfns.c (Fmessage_box): Remove unused local var.
9003
792c7b2b
PE
9004 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
9005 (note_mode_line_or_margin_highlight, note_mouse_highlight):
9006 Omit unused local vars.
c499e557 9007 * window.c (shrink_windows): Omit unused local var.
b01a1c29 9008 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
9009 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
9010 Omit unused local var.
9011
ba0165e1
PE
9012 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
9013 Don't assume string length fits in int.
32ad8845 9014 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 9015 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 9016
3c59b4c9
PE
9017 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
9018 instead of alloca (Bug#8344).
9019
a3eed478 9020 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 9021 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 9022
eb4d412d
PE
9023 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
9024
1658b401
PE
9025 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
9026 concerns.
9027
9028 * term.c (produce_glyphless_glyph): Remove unnecessary test.
9029
9030 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 9031
9a2c6e05
PE
9032 * keyboard.c (syms_of_keyboard): Use the same style as later
9033 in this function when indexing through an array. This also
9034 works around GCC bug 48267.
9035
03d0a109
PE
9036 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
9037
44f730c8
PE
9038 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
9039
fe75f926
PE
9040 * chartab.c (sub_char_table_ref_and_range): Redo for slight
9041 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
9042
ffa8c828
PE
9043 * keyboard.c, keyboard.h (num_input_events): Now size_t.
9044 This avoids undefined behavior on integer overflow, and is a bit
9045 more convenient anyway since it is compared to a size_t variable.
9046
c5101a77
PE
9047 Variadic C functions now count arguments with size_t, not int.
9048 This avoids an unnecessary limitation on 64-bit machines, which
9049 caused (substring ...) to crash on large vectors (Bug#8344).
9050 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
9051 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 9052 All variadic functions and their callers changed accordingly.
c5101a77
PE
9053 (struct gcpro.nvars): Now size_t, not int. All uses changed.
9054 * data.c (arith_driver, float_arith_driver): Likewise.
9055 * editfns.c (general_insert_function): Likewise.
9056 * eval.c (struct backtrace.nargs, interactive_p)
9057 (internal_condition_case_n, run_hook_with_args, apply_lambda)
9058 (funcall_lambda, mark_backtrace): Likewise.
9059 * fns.c (concat): Likewise.
9060 * frame.c (x_set_frame_parameters): Likewise.
9061 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
9062 0 if not found, not -1. All callers changed.
9063
dd3f25f7
PE
9064 * alloc.c (garbage_collect): Don't assume stack size fits in int.
9065 (stack_copy_size): Now size_t, not int.
9066 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
9067
461c2ab9
JB
90682011-03-28 Juanma Barranquero <lekktu@gmail.com>
9069
9070 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
9071 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9072 All callers changed.
9073
9074 * lisp.h (multibyte_char_to_unibyte):
9075 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9076 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9077 * character.h (CHAR_TO_BYTE8):
9078 * cmds.c (internal_self_insert):
9079 * editfns.c (general_insert_function):
9080 * keymap.c (push_key_description):
9081 * search.c (Freplace_match):
9082 * xdisp.c (message_dolog, set_message_1): All callers changed.
9083
f6d62986
SM
90842011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9085
9086 * keyboard.c (safe_run_hook_funcall): New function.
9087 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9088 don't set the hook to nil, but remove the offending function instead.
9089 (Qcommand_hook_internal): Remove, unused.
9090 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9091 Vcommand_hook_internal.
9092
9093 * eval.c (enum run_hooks_condition): Remove.
9094 (funcall_nil, funcall_not): New functions.
9095 (run_hook_with_args): Call each function through a `funcall' argument.
9096 Remove `cond' argument, now redundant.
9097 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9098 (Frun_hook_with_args_until_failure): Adjust accordingly.
9099 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9100
1db5b1ad
JB
91012011-03-28 Juanma Barranquero <lekktu@gmail.com>
9102
9103 * dispextern.h (string_buffer_position): Remove declaration.
9104
9105 * print.c (strout): Remove parameter `multibyte', unused since
9106 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9107
9108 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9109 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9110 All callers changed.
9111
9112 * w32.c (_wsa_errlist): Use braces for struct initializers.
9113
9114 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9115 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9116 All callers changed.
9117 (string_buffer_position): Likewise. Also, make static (it's never
9118 used outside xdisp.c).
9119 (cursor_row_p): Remove parameter `w', unused since
9120 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9121 (decode_mode_spec): Remove parameter `precision', introduced during
9122 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9123 All callers changed.
9124
5ffb62aa
JD
91252011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9126
9127 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9128
461c2ab9 91292011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
9130
9131 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9132 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9133 (ns_update_auto_hide_menu_bar): New functions.
9134 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9135 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9136 ns_constrain_all_frames.
9137 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9138 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9139
5c380ffb
JD
91402011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9141
9142 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9143
9af30bdf
GM
91442011-03-27 Glenn Morris <rgm@gnu.org>
9145
9146 * syssignal.h: Replace RETSIGTYPE with void.
9147 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9148 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9149 Replace SIGTYPE with void everywhere.
9150 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9151 * s/template.h (SIGTYPE): Remove commented out definition.
9152
e2abce01
JB
91532011-03-26 Eli Zaretskii <eliz@gnu.org>
9154
9155 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9156 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9157
f868cd8a
JB
91582011-03-26 Juanma Barranquero <lekktu@gmail.com>
9159
59eb0929
JB
9160 * w32.c (read_unc_volume): Use parameter `henum', instead of
9161 global variable `wget_enum_handle'.
9162
9163 * keymap.c (describe_vector): Remove parameters `indices' and
9164 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9165 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9166
f868cd8a
JB
9167 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9168
9169 * keyboard.c (timer_check): Remove parameter `do_it_now',
9170 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9171 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9172 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9173
9174 * keyboard.c (read_char):
9175 * w32menu.c (w32_menu_display_help):
9176 * xmenu.c (show_help_event, menu_help_callback):
9177 Adjust calls to `show_help_echo'.
9178
9179 * gtkutil.c (xg_maybe_add_timer):
9180 * keyboard.c (readable_events):
9181 * process.c (wait_reading_process_output):
9182 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9183
9184 * insdel.c (adjust_markers_gap_motion):
9185 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9186 (gap_left, gap_right): Don't call it.
9187
2ecf6fdb
CY
91882011-03-25 Chong Yidong <cyd@stupidchicken.com>
9189
9190 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9191 incurred during fontification.
9192
6b1f9ba4
JB
91932011-03-25 Juanma Barranquero <lekktu@gmail.com>
9194
9195 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9196 (DEFVAR_PER_BUFFER): Don't pass it.
9197
9198 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9199 (scrolling_window): Don't pass it.
9200
0f4a96b5
JB
92012011-03-25 Juanma Barranquero <lekktu@gmail.com>
9202
9203 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9204
9205 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9206 and `suffix'.
9207 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9208 of variables specific to SELinux and computation of `encoded_absname'.
9209
9210 * image.c (XPutPixel): Remove unused variable `height'.
9211
9212 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9213
9214 * unexw32.c (get_section_info): Remove unused variable `section'.
9215
9216 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9217 (system_process_attributes): Remove unused variable `sess'.
9218 (sys_read): Remove unused variable `err'.
9219
9220 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9221 (w32_wnd_proc): Remove unused variable `isdead'.
9222 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9223 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9224 (x_create_tip_frame): Remove unused variable `tem'.
9225
9226 * w32inevt.c (w32_console_read_socket):
9227 Remove unused variable `no_events'.
9228
9229 * w32term.c (x_draw_composite_glyph_string_foreground):
9230 Remove unused variable `width'.
9231
1149507c
JB
92322011-03-24 Juanma Barranquero <lekktu@gmail.com>
9233
9234 * w32term.c (x_set_glyph_string_clipping):
9235 Don't pass uninitialized region to CombineRgn.
9236
9c88f339
JB
92372011-03-23 Juanma Barranquero <lekktu@gmail.com>
9238
9239 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9240 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9241 (Fx_close_connection): Remove unused variable `i'.
9242
9243 * w32font.c (w32font_draw): Return number of glyphs.
9244 (w32font_open_internal): Remove unused variable `i'.
9245 (w32font_driver): Add missing initializer.
9246
9247 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9248 (fill_in_menu): Remove unused variable `items_added'.
9249
9250 * w32term.c (last_mouse_press_frame): Remove static global variable.
9251 (w32_clip_to_row): Remove unused variable `f'.
9252 (x_delete_terminal): Remove unused variable `i'.
9253
9254 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9255 (NOTHING): Remove unused static global variable.
9256 (uniscribe_check_otf): Remove unused variable `table'.
9257 (uniscribe_font_driver): Add missing initializers.
9258
dee091a3
JD
92592011-03-23 Julien Danjou <julien@danjou.info>
9260
9261 * term.c (Fsuspend_tty, Fresume_tty):
9262 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9263 * window.c (temp_output_buffer_show):
9264 * insdel.c (signal_before_change):
9265 * frame.c (Fhandle_switch_frame):
9266 * fileio.c (Fdo_auto_save):
9267 * emacs.c (Fkill_emacs):
9268 * editfns.c (save_excursion_restore):
9269 * cmds.c (internal_self_insert):
9270 * callint.c (Fcall_interactively):
9271 * buffer.c (Fkill_all_local_variables):
9272 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9273 Use Frun_hooks.
0f4a96b5 9274 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 9275 unconditionally since it does the check itself.
dee091a3 9276
2c520ab5 92772011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 9278
c9c49752
PE
9279 Fix more problems found by GCC 4.5.2's static checks.
9280
8abc3f12
PE
9281 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9282 the first time through the loop, since we know p0 < p1 then.
9283 This also avoids a gcc -Wstrict-overflow warning.
9284
a2d26660
PE
9285 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9286 leading to a memory leak, possible in functions like
9287 load_charset_map_from_file that can allocate an unbounded number
b12ef411 9288 of objects (Bug#8318).
a2d26660 9289
916c72e9
PE
9290 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9291 that could (at least in theory) be that large.
9292
19ab8a18
PE
9293 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9294 This is less likely to overflow, and avoids undefined behavior if
9295 overflow does occur. All callers changed. Use strtoul to scan
9296 for the unsigned long integer.
b7cbbd6f
PE
9297 (pint2hrstr): Simplify and tune code slightly.
9298 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 9299
f0641eff
PE
9300 * scroll.c (do_scrolling): Work around GCC bug 48228.
9301 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9302
7f650bb9
PE
9303 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9304 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
9305 (validate_x_resource_name): Simplify count usage.
9306 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 9307
37dd57d1
PE
9308 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9309 fail (Bug#8306).
81e56e61 9310
699979fc 9311 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 9312
401bf9b4
PE
9313 * process.c (Fmake_network_process): Use socklen_t, not int,
9314 where POSIX says socklen_t is required in portable programs.
9315 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 9316 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
9317 (Fmake_network_process, server_accept_connection):
9318 (wait_reading_process_output, read_process_output):
9319 Likewise.
9320
b93aacde
PE
9321 * process.c: Rename or move locals to avoid shadowing.
9322 (list_processes_1, Fmake_network_process):
9323 (read_process_output_error_handler, exec_sentinel_error_handler):
9324 Rename or move locals.
4dc343ee 9325 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 9326 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 9327 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 9328 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 9329 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 9330
af8a867c 9331 Make tparam.h and terminfo.c consistent.
44f230aa
SM
9332 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9333 Include tparam.h instead, since it declares them.
af8a867c
PE
9334 * cm.h (PC): Remove extern decl; tparam.h now does this.
9335 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9336 * terminfo.c: Include tparam.h, to check interfaces.
9337 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9338 (tparam): Adjust signature to match interface in tparam.h;
9339 this removes some undefined behavior. Check that outstring and len
9340 are zero, which they always are with Emacs.
9341 * tparam.h (PC, BC, UP): New extern decls.
9342
0248044d 9343 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 9344 (xftfont_open): Rename locals to avoid shadowing.
0248044d 9345
8ff096c1 9346 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
9347 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9348 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 9349 (ftfont_list): Remove unused local.
49eaafba
PE
9350 (get_adstyle_property, ftfont_pattern_entity):
9351 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9352 Rename locals to avoid shadowing.
8ff096c1 9353
e2be39f6
PE
9354 * xfont.c (xfont_list_family): Mark var as initialized.
9355
c9735e30
PE
9356 * xml.c (make_dom): Now static.
9357
8f5201ae
PE
9358 * composite.c (composition_compute_stop_pos): Rename local to
9359 avoid shadowing.
b246f932
PE
9360 (composition_reseat_it): Remove unused locals.
9361 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 9362 (composition_update_it): Mark var as initialized.
11b61122
PE
9363 (find_automatic_composition): Mark vars as initialized,
9364 with a FIXME (Bug#8290).
8f5201ae 9365
760fbc2c
PE
9366 character.h: Rename locals to avoid shadowing.
9367 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9368 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9369 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9370 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9371 to avoid shadowing.
9372
ff08eb85
PE
9373 * textprop.c (property_change_between_p): Remove; unused.
9374
fc7bf025
PE
9375 * intervals.c (interval_start_pos): Now static.
9376
235d7abc
PE
9377 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9378
44f230aa
SM
9379 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9380 Rename locals to avoid shadowing.
3e7d6594 9381
50060332
PE
9382 * sound.c (wav_play, au_play, Fplay_sound_internal):
9383 Fix pointer signedness.
d01f234b 9384 (alsa_choose_format): Remove unused local var.
c83b8872
PE
9385 (wav_play): Initialize a variable to 0, to prevent undefined
9386 behavior (Bug#8278).
50060332 9387
c4fc4e30
PE
9388 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9389
918436ed
PE
9390 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9391
c939f91b
PE
9392 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9393 clobbering (Bug#8298).
b9c7f648
PE
9394 * sysdep.c (sys_subshell): Likewise.
9395 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 9396
6bd8c144
PE
9397 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9398 This should get cleaned up, so that child_setup has the
9399 same signature on all platforms.
9400
7710357c 9401 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 9402 (relocate_fd): Rename locals to avoid shadowing.
7710357c 9403
c59da222
CY
94042011-03-22 Chong Yidong <cyd@stupidchicken.com>
9405
9406 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9407 not to be necessary, and produces flickering.
9408
66b87493
GM
94092011-03-20 Glenn Morris <rgm@gnu.org>
9410
9411 * config.in: Remove file.
9412
45b6f6d5
JB
94132011-03-20 Juanma Barranquero <lekktu@gmail.com>
9414
9415 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9416 are now in src/globals.h.
9417 (syms_of_minibuf): Remove spurious & from previous change.
9418
cd394be1 94192011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9420
9421 * minibuf.c (completing-read-function): New variable.
9422 (completing-read-default): Rename from completing-read.
9423 (completing-read): Call completing-read-function.
9424
b14e3e21
CY
94252011-03-19 Juanma Barranquero <lekktu@gmail.com>
9426
9427 * xfaces.c (Fx_load_color_file):
9428 Read color file from absolute filename (bug#8250).
9429
f2b726e6
JB
94302011-03-19 Juanma Barranquero <lekktu@gmail.com>
9431
9432 * makefile.w32-in: Update dependencies.
9433
09f6ff02
EZ
94342011-03-17 Eli Zaretskii <eliz@gnu.org>
9435
9436 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9437
29a6015a
PE
94382011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9439
a3a6c54e
PE
9440 Fix more problems found by GCC 4.5.2's static checks.
9441
b766f867
PE
9442 * process.c (make_serial_process_unwind, send_process_trap):
9443 (sigchld_handler): Now static.
9444
be02381c
PE
9445 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9446 That way, the code declares only the vars that it needs.
9447 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9448 * s/cygwin.h (PTY_ITERATION): Likewise.
9449 * s/darwin.h (PTY_ITERATION): Likewise.
9450 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9451
57048744
PE
9452 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9453 * process.c (allocate_pty): Don't declare stb unless it's needed.
9454
7914961c 9455 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9456 (CONSTANTLIM): Remove; unused.
9457 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9458 Define only if needed.
7914961c 9459
b3967b18
PE
9460 * unexelf.c (unexec): Name an expression,
9461 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9462 Use a different way to cause a compilation error if anyone uses
9463 n rather than nn, a way that does not involve shadowing.
73366a00 9464 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9465
29a6015a
PE
9466 * deps.mk (unexalpha.o): Remove; unused.
9467
43cfc33e 9468 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9469 * unexec.h: New file.
ce701a33
PE
9470 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9471 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9472 Depend on unexec.h.
9473 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9474 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9475 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9476 Change as necessary to match prototype in unexec.h.
ce701a33 9477
01f44d5a
PE
9478 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9479 shadowing.
4f63c6bb 9480 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9481
a6670b0b
PE
9482 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9483 Rename locals to avoid shadowing.
9484
cef2010d 9485 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9486 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9487
d4d7173a
PE
9488 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9489
f08b802a
PE
9490 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9491 warning when compiling print.c.
9492
3ddb0639
PE
9493 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9494 instead of using an uninitialized var.
5ad03b97 9495 (font_sort_entities): Mark var as initialized.
3ddb0639 9496
170a2692
PE
9497 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9498
e663c700
PE
9499 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9500 pointers to constants.
89bc529a 9501 (font_parse_fcname): Remove unused vars.
7b81e2d0 9502 (font_delete_unmatched): Now static.
ea838e10 9503 (font_get_spec): Remove; unused.
13a547c6
PE
9504 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9505 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9506 Rename or move locals to avoid shadowing.
e663c700 9507
2a80c887 9508 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9509 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9510
1384fa33 9511 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9512 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9513
8b2c52e9
PE
9514 * alloc.c (mark_backtrace): Move decl from here ...
9515 * lisp.h: ... to here, so that it can be checked.
9516
475545b5 9517 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9518 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9519 (lisp_indirect_variable): Name an expression,
9520 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9521 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9522
b1349114 9523 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9524 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9525 Use const pointer when appropriate.
b1349114 9526
a2928364
PE
9527 * lisp.h (get_system_name, get_operating_system_release):
9528 Move decls here, to check interfaces.
9529 * process.c (get_operating_system_release): Move decl to lisp.h.
9530 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9531 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9532 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9533 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9534 (Fformat_time_string, Fencode_time, Finsert_char):
9535 (Ftranslate_region_internal, Fformat):
9536 Rename or remove local vars to avoid shadowing.
9710023e 9537 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9538
a415e694
PE
9539 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9540 avoid shadowing.
9541
8ef4622d
PE
9542 * lisp.h (eassert): Check that the argument compiles, even if
9543 ENABLE_CHECKING is not defined.
9544
946f9a5b
PE
9545 * data.c (Findirect_variable): Name an expression, to avoid
9546 gcc -Wbad-function-cast warning.
112396d6 9547 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9548 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9549 (Fmake_variable_buffer_local, Fmake_local_variable):
9550 Mark variables as initialized.
52746918 9551 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9552
e5aab7e7 9553 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9554 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9555 Rename locals to avoid shadowing.
dff45157
PE
9556 (mark_stack): Move local variables into the #ifdef region where
9557 they're used.
7bc26fdb
PE
9558 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9559 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9560 needed otherwise.
9561 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9562 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9563 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9564
e5aab7e7
PE
9565 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9566 avoids undefined behavior in theory.
9567
4da60324
PE
9568 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9569
88043301
PE
9570 Use functions, not macros, for up- and down-casing (Bug#8254).
9571 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9572 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9573 to use the following functions instead of these macros.
9574 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9575 EMACS_INT, since callers assume the returned value fits in int.
9576 (upcase1): Likewise, for UPCASE_TABLE.
9577 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9578 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9579 the race-condition problem in the old DOWNCASE.
88043301 9580
19ed5445
PE
9581 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9582 Rename locals to avoid shadowing.
9583 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9584 (regex_compile, re_search_2, re_match_2_internal):
9585 Remove unused local vars.
952db0d7
PE
9586 (FREE_VAR): Rewrite so as not to use empty "else",
9587 which gcc can warn about.
da053e48 9588 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9589 (RETALLOC_IF): Define only if needed.
9590 (WORDCHAR_P): Likewise. This one is never needed, but is used
9591 only in a comment talking about a compiler bug, so put inside
9592 the #if 0 of that comment.
9593 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9594 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9595 Remove; unused.
19ed5445 9596
1f3561e4 9597 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9598 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9599 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9600
ded6f8f7
PE
9601 * search.c (simple_search): Remove unused var.
9602
dbd37a95
PE
9603 * dired.c (compile_pattern): Move decl from here ...
9604 * lisp.h: ... to here, so that it can be checked.
9605 (struct re_registers): New forward decl.
9606
7e47afad
PE
9607 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9608
85f24f61
PE
9609 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9610 All uses changed.
9611 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9612 Rename locals to avoid shadowing.
5671df8f 9613 (Fvertical_motion): Mark locals as initialized.
85f24f61 9614
181aa2be 9615 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9616 (casify_region): Mark local as initialized.
181aa2be 9617
930d429c
PE
9618 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9619
7082eac6
PE
9620 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9621 New macros, so that the caller can use some names other than
9622 gcpro1, gcpro2, etc.
9623 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9624 of the new macros.
9625 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9626 argument, for consistency with GCPRO2_VAR, etc: it is now the
9627 prefix of the variable, not the variable itself. All uses
9628 changed.
38b2c076
PE
9629 * dired.c (directory_files_internal, file_name_completion):
9630 Rename locals to avoid shadowing.
9631
15206ed9
PE
9632 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9633 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9634 dired.c's scmp function, had undefined behavior.
9635 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9636 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9637 * buffer.h: ... to here, because these macros use current_buffer,
9638 and the new implementation with inline functions needs to have
9639 current_buffer in scope now, rather than later when the macros
9640 are used.
9641 (downcase, upcase1): New static inline functions.
9642 (DOWNCASE, UPCASE1): Reimplement using these functions.
9643 This avoids undefined behavior in expressions like
9644 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9645 from race conditions in accessing the global variables
9646 case_temp1 and case_temp2.
9647 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9648 * lisp.h (case_temp1, case_temp2): Remove their decls.
9649 * character.h (ASCII_CHAR_P): Move from here ...
9650 * lisp.h: ... to here, so that the inline functions mentioned
9651 above can use them.
9652
4a6bea26
PE
9653 * dired.c (directory_files_internal_unwind): Now static.
9654
f14b7e14
PE
9655 * fileio.c (file_name_as_directory, directory_file_name):
9656 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9657 Now static.
2893f146
PE
9658 (file_name_as_directory): Use const pointers when appropriate.
9659 (Fexpand_file_name): Likewise. In particular, newdir might
9660 point at constant storage, so make it a const pointer.
fd4ead52 9661 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9662 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9663 signedness issues.
f839df0c
PE
9664 (Fset_file_times, Finsert_file_contents, auto_save_error):
9665 Rename locals to avoid shadowing.
f14b7e14 9666
5716756e 9667 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9668 (Ftry_completion, Fall_completions): Rename or remove locals
9669 to avoid shadowing.
5716756e 9670
b4c3046a
PE
9671 * marker.c (bytepos_to_charpos): Remove; unused.
9672
b45db522
PE
9673 * lisp.h (verify_bytepos, count_markers): New decls,
9674 so that gcc does not warn that these functions aren't declared.
9675
85876d07
PE
9676 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9677 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9678 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9679 (copy_text): Remove unused local var.
85876d07 9680
03d78a21 9681 * filelock.c (within_one_second): Now static.
b3dd38ab 9682 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9683
5df8f01b
PE
9684 * buffer.c (fix_overlays_before): Mark locals as initialized.
9685 (fix_start_end_in_overlays): Likewise. This function should be
9686 simplified by using pointers-to-pointers, but that's a different
9687 matter.
b1d876f1 9688 (switch_to_buffer_1): Now static.
8f54f30a
PE
9689 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9690 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9691
a70072c9 9692 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9693 Fix pointer signedness issue.
edced198
PE
9694 (sys_subshell): Mark local as volatile if checking for lint,
9695 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9696 (MAXPATHLEN): Define only if needed.
a70072c9 9697
a0977c44
PE
9698 * process.c (serial_open, serial_configure): Move decls from here ...
9699 * systty.h: ... to here, so that they can be checked.
9700
a884fdcc
PE
9701 * fns.c (get_random, seed_random): Move extern decls from here ...
9702 * lisp.h: ... to here, so that they can be checked.
9703
604efe86 9704 * sysdep.c (reset_io): Now static.
b8950c94 9705 (wait_for_termination_signal): Remove; unused.
604efe86 9706
38fc62d9
PE
9707 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9708 (copy_keymap_item, append_key, push_text_char_description):
9709 Now static.
1004a21a 9710 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9711 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9712 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9713 (describe_map_tree):
9714 Rename locals to avoid shadowing.
38fc62d9 9715
2f2650da
PE
9716 * keyboard.c: Declare functions static if they are not used elsewhere.
9717 (echo_char, echo_dash, cmd_error, top_level_2):
9718 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9719 (read_char, kbd_buffer_get_event, make_lispy_position):
9720 (make_lispy_event, make_lispy_movement, apply_modifiers):
9721 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9722 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9723 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9724 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9725 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9726
a053e86c 9727 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9728 (mark_kboards): Move decl here ...
9729 * alloc.c (mark_kboards): ... from here.
a053e86c 9730
4752793e
PE
9731 * lisp.h (force_auto_save_soon): New decl.
9732
74f10ca7 9733 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9734 (DEFINE_DUMMY_FUNCTION): New macro.
9735 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9736 Use it.
c03cd23f
PE
9737 (main): Add casts to avoid warnings
9738 if GCC considers string literals to be constants.
74f10ca7 9739
022e70d4
PE
9740 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9741
59d6fe83
PE
9742 * dbusbind.c: Pointer signedness fixes.
9743 (xd_signature, xd_append_arg, xd_initialize):
9744 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9745 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9746 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9747 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9748
78320123
PE
9749 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9750 if GCC considers string literals to be constants.
49cebcca 9751 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9752
35ac2a97
SM
97532011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9754
fb103ca9
SM
9755 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9756 (print_preprocess, print_object): New macro to fix last change.
9757
35ac2a97
SM
9758 * print.c (print_preprocess): Don't forget font objects.
9759
62973b41
JB
97602011-03-16 Juanma Barranquero <lekktu@gmail.com>
9761
9762 * emacs.c (USAGE3): Doc fixes.
9763
0e48bb22
AS
97642011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9765
9766 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9767 structure.
9768
7684e57b
JB
97692011-03-14 Juanma Barranquero <lekktu@gmail.com>
9770
9771 * lisp.h (VWindow_system, Qfile_name_history):
9772 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9773 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9774 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9775
9776 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9777 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9778
9779 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9780 * w32console.c (detect_input_pending, read_input_pending)
9781 (encode_terminal_code):
9782 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9783 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9784 (w32_system_caret_y, Qfile_name_history):
9785 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9786 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9787 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9788 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9789 * w32proc.c (Qlocal, report_file_error):
9790 * w32term.c (Vwindow_system, updating_frame):
9791 * w32uniscribe.c (initialized, uniscribe_font_driver):
9792 Remove unneeded extern declarations.
9793
2aa46d6c
CY
97942011-03-14 Chong Yidong <cyd@stupidchicken.com>
9795
c96bbc66 9796 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9797
cffc6f3b
CY
97982011-03-13 Chong Yidong <cyd@stupidchicken.com>
9799
9800 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9801 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9802 These macros can no longer be used for assignment.
9803
44f230aa
SM
9804 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9805 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9806 (record_buffer_markers, fetch_buffer_markers): New functions for
9807 recording and fetching special buffer markers.
9808 (set_buffer_internal_1, set_buffer_temp): Use them.
9809
9810 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9811
9812 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9813
9814 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9815 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9816
9817 * xdisp.c (hscroll_window_tree):
9818 (reconsider_clip_changes): Use PT instead of BUF_PT.
9819
d251f04b
EZ
98202011-03-13 Eli Zaretskii <eliz@gnu.org>
9821
9822 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9823 $(EMACS_ROOT)/lib/intprops.h.
9824
f0c77cd1
PE
98252011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9826
3eca4629
PE
9827 Fix more problems found by GCC 4.5.2's static checks.
9828
7c86ee98
PE
9829 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9830 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9831 (xg_free_frame_widgets): Make it clear that a local variable is
9832 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9833 (gdk_window_get_screen): Make it clear that this macro is needed
9834 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9835 (int_gtk_range_get_value): New function, which avoids a diagnostic
9836 from gcc -Wbad-function-cast.
9837 (xg_set_toolkit_scroll_bar_thumb): Use it.
9838 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9839 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9840 (get_utf8_string, xg_get_file_with_chooser):
9841 Rename locals to avoid shadowing.
9842 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9843
41729b81
PE
9844 * xgselect.c (xg_select): Remove unused var.
9845
f0c77cd1
PE
9846 * image.c (four_corners_best): Mark locals as initialized.
9847 (gif_load): Initialize transparent_p to zero (Bug#8238).
9848 Mark another local as initialized.
ec6cf4c6 9849 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9850
ce0ad53d 9851 * image.c (clear_image_cache): Now static.
d5d5a617 9852 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9853 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9854 (x_edge_detection): Remove unnecessary cast that
9855 gcc -Wbad-function-cast diagnoses.
2037898d 9856 (gif_load): Fix pointer signedness.
6ae141d6
PE
9857 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9858 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9859
33383987 98602011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9861
d32df629
PE
9862 Improve quality of tests for time stamp overflow.
9863 For example, without this patch (encode-time 0 0 0 1 1
9864 1152921504606846976) returns the obviously-bogus value (-948597
9865 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9866 reports time overflow. See
9867 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9868 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9869 * editfns.c: Include limits.h and intprops.h.
9870 (TIME_T_MIN, TIME_T_MAX): New macros.
9871 (time_overflow): Move earlier, to before first use.
9872 (hi_time, lo_time): New functions, for an accurate test for
9873 out-of-range times.
9874 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9875 (Fget_internal_run_time): Don't assume time_t fits in int.
9876 (make_time): Use list2 instead of Fcons twice.
9877 (Fdecode_time): More accurate test for out-of-range times.
9878 (check_tm_member): New function.
9879 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9880 (lisp_time_argument): Don't rely on undefined left-shift and
9881 right-shift behavior when checking for time stamp overflow.
8be6f318 9882
fe31d94c
PE
9883 * editfns.c (time_overflow): New function, refactoring common code.
9884 (Fformat_time_string, Fdecode_time, Fencode_time):
9885 (Fcurrent_time_string): Use it.
9886
8be6f318
PE
9887 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9888 * dired.c (make_time): Move to ...
9889 * editfns.c (make_time): ... here.
9890 * systime.h: Note the move.
9891
09d9db2c 98922011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9893
126bc0dc
YM
9894 * fringe.c (update_window_fringes): Remove unused variables.
9895
c47cbdfd
YM
9896 * unexmacosx.c (copy_data_segment): Also copy __got section.
9897 (Bug#8223)
9898
7ac80be9
EZ
98992011-03-12 Eli Zaretskii <eliz@gnu.org>
9900
c96bbc66 9901 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9902 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9903 Constify `char *' arguments and their references according to
9904 prototypes in tparam.h.
9905
ecb0f94d 9906 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9907
7ac80be9
EZ
9908 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9909 Adapt all references accordingly.
9910
9911 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9912
ef1fd07e
TT
99132011-03-11 Tom Tromey <tromey@redhat.com>
9914
9915 * buffer.c (syms_of_buffer): Remove obsolete comment.
9916
7ef4b50c
EZ
99172011-03-11 Eli Zaretskii <eliz@gnu.org>
9918
9919 * termhooks.h (encode_terminal_code): Declare prototype.
9920
9921 * msdos.c (encode_terminal_code): Don't declare prototype.
9922
9923 * term.c (encode_terminal_code): Now external again, used by
9924 w32console.c and msdos.c.
9925
44f230aa
SM
9926 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9927 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9928
4b1ec863 99292011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9930
1714f52b 9931 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9932
4b1ec863
PE
9933 * fringe.c (update_window_fringes): Mark locals as initialized
9934 (Bug#8227).
9935 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9936
524c7aa6
PE
9937 * alloc.c (mark_fringe_data): Move decl from here ...
9938 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9939 to check its interface.
9940 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9941
a5c0af81 9942 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9943 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9944 (fontset_font): Mark local as initialized.
a9a06e0b 9945 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9946
b4716021
PE
9947 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9948
811e9bac 9949 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9950 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9951 (x_own_selection, Fx_disown_selection_internal): Rename locals
9952 to avoid shadowing.
9953 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9954
7e3ab302
PE
9955 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9956 so that the caller can use some name other than gcpro1.
9957 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9958 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9959 (Fx_backspace_delete_keys_p):
9960 Use them to avoid shadowing, and rename vars to avoid shadowing.
9961 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9962 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9963 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9964 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9965 Remove unused locals.
7e3ab302
PE
9966 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9967 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9968 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9969 macros.
f78faa98 9970
e2b13473
PE
9971 * xterm.h (x_mouse_leave): New decl.
9972
77f23912
PE
9973 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9974 Remove unused functions.
cdf4ba58
PE
9975 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9976 (x_calc_absolute_position): Now static.
7411c686 9977 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9978 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9979 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9980 unless they are used.
38d0b34a
PE
9981 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9982 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9983 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9984 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9985 (x_error_catcher, x_connection_closed, x_error_handler):
9986 (x_error_quitter, xembed_send_message, x_iconify_frame):
9987 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9988 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9989 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9990
44f230aa
SM
9991 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9992 Rename or move locals to avoid shadowing.
6b463e58 9993 (tty_defined_color, merge_face_heights): Now static.
5967d051 9994 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9995 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9996 does not deduce is never used uninitialized.
73719eba
PE
9997 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9998 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9999
426994c3 10000 * terminal.c (store_terminal_param): Now static.
5489860b 10001
032f1620 10002 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 10003 (set_frame_menubar): Remove unused local.
d4323972 10004 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
10005 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
10006 since they might point to immutable storage.
281585b0
PE
10007 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
10008 since it's unused otherwise.
032f1620 10009
367c19e5 10010 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 10011 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
10012 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
10013 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 10014 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
10015 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
10016 does not deduce are never used uninitialized.
70739cbe 10017
07b48fa9
PE
10018 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
10019
8868a238 10020 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
10021 * window.c (window_loop, size_window):
10022 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 10023
7e5cf297 10024 * window.c (display_buffer): Now static.
d6550a9f
PE
10025 (size_window): Mark variables that gcc -Wuninitialized
10026 does not deduce are never used uninitialized.
a586633d
PE
10027 * window.h (check_all_windows): New decl, to forestall
10028 gcc -Wmissing-prototypes diagnostic.
5b555da1 10029 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 10030
f6095868
PE
10031 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
10032 shadowing.
10033 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
10034 Include <limits.h>.
10035 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
10036 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
10037 (load_charset_map): Mark variables that gcc -Wuninitialized
10038 does not deduce are never used uninitialized.
53df7c11 10039 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 10040
f38b440c
PE
10041 * coding.c (coding_set_source, coding_set_destination):
10042 Use "else { /* comment */ }" rather than "else /* comment */;"
10043 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
10044 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
10045 a block, when the outer 'i' will do.
10046 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
10047 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
10048 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
10049 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
10050 (Fdecode_sjis_char, Fdefine_coding_system_internal):
10051 Rename locals to avoid shadowing.
10052 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
10053 * coding.c (emacs_mule_char, encode_invocation_designation):
10054 Now static, since they're not used elsewhere.
413bb2db 10055 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 10056 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
10057 (decode_coding_emacs_mule): Mark variables that gcc
10058 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
10059 (detect_coding_iso_2022): Initialize a local variable that might
10060 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 10061 this initialization is needed. (Bug#8211)
5f58e762
PE
10062 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
10063 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
10064 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
10065 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
10066 Remove unused macros.
f38b440c 10067
232b38b9 10068 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 10069 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 10070 * character.c (string_count_byte8): Likewise.
232b38b9 10071
fb90da1b
PE
10072 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10073 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10074
fb93dbc2
PE
10075 * chartab.c (copy_sub_char_table): Now static, since it's not used
10076 elsewhere.
5c156ace
PE
10077 (sub_char_table_ref_and_range, char_table_ref_and_range):
10078 Rename locals to avoid shadowing.
bbcd0949 10079 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 10080
7d3b3862 10081 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 10082 (BIDI_BOB): Remove unused macro.
7d3b3862 10083
6be7d3da
PE
10084 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10085 deduce are never used uninitialized.
c2ed9c8b 10086 * term.c (encode_terminal_code): Likewise.
6be7d3da 10087
75f8807f 10088 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 10089
50938595
PE
10090 * tparam.h: New file.
10091 * term.c, tparam.h: Include it.
10092 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10093 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10094 Move these decls to tparam.h, and make them agree with what
10095 is actually in tparam.c. The previous trick of using incompatible
10096 decls in different modules does not conform to the C standard.
10097 All callers of tparam changed to use tparam's actual API.
10098 * tparam.c (tparam1, tparam, tgoto):
10099 Use const pointers where appropriate.
10100
fbceeba2
PE
10101 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10102 * cm.h (struct cm): Likewise.
10103 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10104 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10105 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10106 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10107 (turn_on_face, init_tty): Likewise.
10108 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 10109
7f3f1250
PE
10110 * term.c (term_mouse_position): Rename local to avoid shadowing.
10111
e6ca6543
PE
10112 * alloc.c (mark_ttys): Move decl from here ...
10113 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10114
c40f8d15
AS
101152011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10116
10117 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10118
cfe0661d
JB
101192011-03-09 Juanma Barranquero <lekktu@gmail.com>
10120
10121 * search.c (compile_pattern_1): Remove argument regp, unused since
10122 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10123 (compile_pattern): Don't pass it.
10124
0afb4571
J
101252011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10126
10127 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10128 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10129 for ! HAVE_GTK3.
10130 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10131
10132 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10133
10134 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10135 gdk_window_get_screen, gdk_window_get_geometry,
10136 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10137 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10138 (xg_get_pixbuf_from_pixmap): New function.
10139 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10140 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10141 Call xg_get_pixbuf_from_pixmap instead of
10142 gdk_pixbuf_get_from_drawable.
10143 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10144 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10145 (xg_check_special_colors): Use GtkStyleContext and its functions
10146 for HAVE_GTK3.
10147 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10148 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10149 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
10150 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10151 Call gtk_widget_get_preferred_size.
0afb4571
J
10152 (xg_frame_resized): gdk_window_get_geometry only takes 5
10153 parameters.
44f230aa
SM
10154 (xg_win_to_widget, xg_event_is_for_menubar):
10155 Call gdk_x11_window_lookup_for_display.
0afb4571
J
10156 (xg_set_widget_bg): New function.
10157 (delete_cb): New function.
895009e1 10158 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 10159 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
10160 (xg_set_background_color): Call xg_set_widget_bg.
10161 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10162 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10163 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10164 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10165 if ! HAVE_GTK3.
10166 (update_frame_tool_bar): Call gtk_widget_hide.
10167 (xg_initialize): Use GDK_KEY_g.
10168
10169 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10170 if ! HAVE_GTK3
10171 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10172
10173 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10174 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10175 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10176
1c2cc4ef
JB
101772011-03-08 Juanma Barranquero <lekktu@gmail.com>
10178
10179 * w32xfns.c (select_palette): Check success of RealizePalette against
10180 GDI_ERROR, not zero.
10181
33383987 10182See ChangeLog.11 for earlier changes.
aac0c6e3
MR
10183
10184;; Local Variables:
10185;; coding: utf-8
aac0c6e3
MR
10186;; End:
10187
2f097256 10188 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
10189
10190 This file is part of GNU Emacs.
10191
10192 GNU Emacs is free software: you can redistribute it and/or modify
10193 it under the terms of the GNU General Public License as published by
10194 the Free Software Foundation, either version 3 of the License, or
10195 (at your option) any later version.
10196
10197 GNU Emacs is distributed in the hope that it will be useful,
10198 but WITHOUT ANY WARRANTY; without even the implied warranty of
10199 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10200 GNU General Public License for more details.
10201
10202 You should have received a copy of the GNU General Public License
10203 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.