* lisp/progmodes/make-mode.el: Bring it up to date with makepp V2.0.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
3633e3aa
KH
12011-12-11 Kenichi Handa <handa@m17n.org>
2
3 * coding.c (Funencodable_char_position): Pay attention to the
4 buffer text relocation (Bug#9389).
5
7b9d523a
JD
62011-12-10 Jan Djärv <jan.h.d@swipnet.se>
7
8 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
9 gtk_init (Bug#10100).
10
b73189c6
EZ
112011-12-10 Eli Zaretskii <eliz@gnu.org>
12
13 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
14 IT->string is nil. (Bug#10263)
15
f7dfe5d6
JD
162011-12-10 Jan Djärv <jan.h.d@swipnet.se>
17
83faebb4
JD
18 * nsterm.h (x_free_frame_resources): Declare.
19
f7dfe5d6
JD
20 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
21 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
22
23 * nsterm.h (ns_get_defaults_value): Declare.
24
25 * nsterm.m (ns_default): Call ns_get_defaults_value.
26
7cd4e72c
EZ
272011-12-09 Eli Zaretskii <eliz@gnu.org>
28
29 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
30 (Bug#10170)
31
b34d7317
YM
322011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
33
34 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
35 that where the value of an _OBJC_* symbol points to is in the .bss
36 section (Bug#10240).
37
76470ad1
KH
382011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
39
40 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 41 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 42
745fff94
KH
432011-12-08 Kenichi Handa <handa@m17n.org>
44
45 * ftfont.c (get_adstyle_property): Fix previous change
46 (Bug#10233).
47
6e44397c
JB
482011-12-07 Juanma Barranquero <lekktu@gmail.com>
49
50 * w32.c (init_environment): If no_site_lisp, remove site-lisp
51 dirs from the default value of EMACSLOADPATH (bug#10208).
52
7efa6272
GM
532011-12-07 Glenn Morris <rgm@gnu.org>
54
55 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
56 installation and source directories as well. (Bug#10208)
57
f6fc4d87
CY
582011-12-06 Chong Yidong <cyd@gnu.org>
59
60 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
61
2bf26180
GM
622011-12-06 Glenn Morris <rgm@gnu.org>
63
64 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
65 as an error, not just -1. (Bug#10217)
66
3a6ad4f0
CY
672011-12-05 Chong Yidong <cyd@gnu.org>
68
69 * keyboard.c (process_special_events): New function.
70 (swallow_events, Finput_pending_p): Use it (Bug#10195).
71
75a3b399
PE
722011-12-05 Paul Eggert <eggert@cs.ucla.edu>
73
74 * coding.c (encode_designation_at_bol): Don't use uninitialized
75 local variable (Bug#9318).
76
c3c9e25e
KH
772011-12-05 Kenichi Handa <handa@m17n.org>
78
79 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
80 return Qnil (Bug#8046, Bug#10193).
81
5eb05ea3
KH
822011-12-05 Kenichi Handa <handa@m17n.org>
83
84 * coding.c (encode_designation_at_bol): New args charbuf_end and
85 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
86 (coding_set_source): Return how many bytes coding->source was
87 relocated.
88 (coding_set_destination): Return how many bytes
89 coding->destination was relocated.
90 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
91 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
92
932011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
94
95 * coding.c (CODING_CHAR_CHARSET_P): New macro.
96 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
97 macro (Bug#9318).
98
992011-12-05 Andreas Schwab <schwab@linux-m68k.org>
100
101 The following changes are to fix Bug#9318.
102
a79703f5 103 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
104 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
105 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 106 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 107
7dbda6df
JB
1082011-12-05 Juanma Barranquero <lekktu@gmail.com>
109
110 * lisp.h (process_quit_flag): Fix external declaration.
111
6d5eb5b0
SM
1122011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
113
114 Don't macro-inline non-performance-critical code.
115 * eval.c (process_quit_flag): New function.
116 * lisp.h (QUIT): Use it.
117
a0c3fad0
JD
1182011-12-04 Jan Djärv <jan.h.d@swipnet.se>
119
120 * nsfns.m (get_geometry_from_preferences): New function.
121 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
122
6c07aac2
AS
1232011-12-04 Andreas Schwab <schwab@linux-m68k.org>
124
125 * emacs.c (Qkill_emacs): Define.
126 (syms_of_emacs): Initialize it.
127 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
128 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
129 (quit_throw_to_read_char): Add parameter `from_signal'.
130 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
131 * lisp.h (QUIT): Call Fkill_emacs if requested.
132
c052ead4
JD
1332011-12-03 Jan Djärv <jan.h.d@swipnet.se>
134
135 * widget.c (update_wm_hints): Return if wmshell is null.
136 (widget_update_wm_size_hints): New function.
137
138 * widget.h (widget_update_wm_size_hints): Declare.
139
140 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
141 widget_update_wm_size_hints (Bug#10104).
142
9e49252b
EZ
1432011-12-03 Eli Zaretskii <eliz@gnu.org>
144
145 * xdisp.c (handle_invisible_prop): If the invisible text ends just
146 before a newline, prepare the bidi iterator for consuming the
147 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 148 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 149
02b16839
JL
1502011-12-02 Juri Linkov <juri@jurta.org>
151
152 * search.c (Fword_search_regexp): New Lisp function created from
153 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
154 (Fword_search_backward, Fword_search_forward)
155 (Fword_search_backward_lax, Fword_search_forward_lax):
156 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
157 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
158
0068070e
SM
1592011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
160
161 * fileio.c (Finsert_file_contents): Move after-change-function call
162 to before the "handled:" label, since all "goto handled" appear in
163 cases where the *-change-functions have already been properly called
164 (bug#10117).
165
3360a3fc
AS
1662011-12-01 Andreas Schwab <schwab@linux-m68k.org>
167
168 * keyboard.c (interrupt_signal): Don't call kill-emacs when
169 waiting for input. (Bug#10169)
170
73d6c093
EZ
1712011-11-30 Eli Zaretskii <eliz@gnu.org>
172
173 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
174 verifies glyph row's hash code--we have just reallocated the
175 glyphs, so their contents can be complete garbage. (Bug#10164)
176
febe6bea
JB
1772011-11-30 Juanma Barranquero <lekktu@gmail.com>
178
179 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
180
801a4313
EZ
1812011-11-30 Eli Zaretskii <eliz@gnu.org>
182
183 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
184 attributes are tested _before_ calling verify_row_hash, to protect
185 against GCC re-ordering of the tests. (Bug#10164)
186
2b56b87e
JD
1872011-11-29 Jan Djärv <jan.h.d@swipnet.se>
188
189 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
190
191 * xterm.c (handle_one_xevent): Only set async_visible and friends
192 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 193 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
194 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
195
dbf31225
PE
1962011-11-28 Paul Eggert <eggert@cs.ucla.edu>
197
198 Remove GCPRO-related macros that exist only to avoid shadowing locals.
199 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
200 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
201 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
202 All uses changed to use GCPRO1 etc.
203 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
204 Revert to old implementation (i.e., before 2011-03-11).
205
1305621b
YM
2062011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
207
208 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
209 of scroll runs so as to avoid assigning disabled bogus rows and
210 unnecessary graphics copy operations.
211
8c9afb46
EZ
2122011-11-27 Eli Zaretskii <eliz@gnu.org>
213
214 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
215 (snprintf) [_MSC_VER]: Redirect to _snprintf.
216 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
217 (malloc, free, realloc, calloc): Redirect to e_* only when
218 compiling Emacs.
219
220 * lisp.h (GCTYPEBITS): Move before first use.
221 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
222 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
223 this macro definition.
224
225 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
226 _MSC_VER.
227
54e9e3bf
JD
2282011-11-27 Jan Djärv <jan.h.d@swipnet.se>
229
6d5eb5b0
SM
230 * gtkutil.c (xg_create_frame_widgets):
231 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
232 present with Gtk+ 2.0.
233
83aca1cb
PE
2342011-11-26 Paul Eggert <eggert@cs.ucla.edu>
235
236 * fileio.c (Finsert_file_contents): Undo previous change; see
237 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
238
5b76caa4
PE
2392011-11-26 Paul Eggert <eggert@cs.ucla.edu>
240
241 Rename locals to avoid shadowing.
242 * fileio.c (Finsert_file_contents):
243 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
244 * process.c (wait_reading_process_output):
245 Rename inner 'proc' to 'p' to avoid shadowing.
246 Indent for consistency with usual Emacs style.
247
8c535114
EZ
2482011-11-25 Eli Zaretskii <eliz@gnu.org>
249
250 * xdisp.c (redisplay_window): If cursor row is not fully visible
251 after recentering, and scroll-conservatively is set to a large
252 number, scroll window by a few more lines to make the cursor fully
253 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
254 (start_display): Don't move to the next line if the display should
255 start at a newline that is part of a display vector or an overlay
256 string. (Bug#10119)
8c535114 257
fa4fdb5c
JL
2582011-11-24 Juri Linkov <juri@jurta.org>
259
260 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
261 after the `MagickPingImage' call. (Bug#10112)
262
90ec88df
CY
2632011-11-23 Chong Yidong <cyd@gnu.org>
264
265 * window.c (Fcoordinates_in_window_p): Accept only live windows.
266
56e2e794
MR
2672011-11-23 Martin Rudalics <rudalics@gmx.at>
268
269 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
270 making another buffer current. (Bug#10114)
271
b6e64c41
GM
2722011-11-23 Glenn Morris <rgm@gnu.org>
273
274 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
275
6b21de18
CY
2762011-11-23 Chong Yidong <cyd@gnu.org>
277
278 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
279 using it (Bug#5984).
280
b12cd789
EZ
2812011-11-22 Eli Zaretskii <eliz@gnu.org>
282
283 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
284 and header-lines, as they don't have one computed for them.
285 (Bug#10098)
286
287 * .gdbinit (prow): Make displayed values more self-explaining.
288 Add row's hash code.
289
261b6fd4
LMI
2902011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
291
292 * process.c (wait_reading_process_output): Fix asynchrounous
293 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 294 (wait_reading_process_output): Add comment and URL.
261b6fd4 295
e7cfd277
JD
2962011-11-21 Jan Djärv <jan.h.d@swipnet.se>
297
298 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
299
a9b9b7f5
CY
3002011-11-21 Chong Yidong <cyd@gnu.org>
301
302 * window.c (Fnext_window, Fprevious_window): Doc fix.
303
b0d15b4f
SM
3042011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
305
306 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
307
fe7a3057
JB
3082011-11-20 Juanma Barranquero <lekktu@gmail.com>
309
310 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
311
d2999b1a
MR
3122011-11-20 Martin Rudalics <rudalics@gmx.at>
313
314 * window.c (Fset_window_combination_limit): Rename argument
315 STATUS to LIMIT.
316 (Vwindow_combination_limit): Remove "status" from doc-string.
317
d5ff9cd0
AS
3182011-11-20 Andreas Schwab <schwab@linux-m68k.org>
319
320 * m/ibms390.h: Remove.
321 * m/ibms390x.h: Don't include "ibms390.h".
322
a5bb9bd3
SM
3232011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
324
325 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
326 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
327
cd1181db
JB
3282011-11-20 Juanma Barranquero <lekktu@gmail.com>
329
330 * casetab.c (Fset_case_table):
331 * charset.c (Fcharset_after): Fix typos.
332
615a3b8d 3332011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 334
17e845af
PE
335 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
336 Otherwise, valgrind does not work on some platforms.
337 Problem reported by Andreas Schwab in
6a0bf43d
PE
338 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
339 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
340 is set, removing the need for VIRT_ADDRESS_VARIES.
341 (PURE_P): Use a more-efficient implementation that needs just one
342 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
343 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
344 to 4 (xorl, subq, cmpq, setbe).
345 * alloc.c (pure): Always extern now, since that's the
346 VIRT_ADDR_VARIES behavior.
347 (PURE_POINTER_P): Use a single comparison, not two, for
348 consistency with the new puresize.h.
349 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
350 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
351 Remove VIRT_ADDR_VARIES no longer needed.
352
f8fe6f96
EZ
3532011-11-19 Eli Zaretskii <eliz@gnu.org>
354
355 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
356 (erase_phys_cursor, update_window_cursor, show_mouse_face)
357 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
358 behave as if the cursor position were at the window margin.
359
360 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
361 and the cursor position is out of bounds, behave as if the cursor
362 position were at the window margin. (Bug#10075)
363
df05a53c
CY
3642011-11-18 Chong Yidong <cyd@gnu.org>
365
366 * window.c (Fwindow_combination_limit): Make first argument
367 non-optional, since it is meaningless for live windows like the
368 selected window.
369
2071918e
DA
3702011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
371
372 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
373
b50a28de
SM
3742011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
375
376 * intervals.c: Fix grafting over the whole buffer (bug#10071).
377 (graft_intervals_into_buffer): Simplify.
378
015137db
EZ
3792011-11-18 Eli Zaretskii <eliz@gnu.org>
380
381 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
382 hash values of the two rows.
383 (copy_row_except_pointers): Preserve the used[] arrays and the
384 hash values of the two rows. (Bug#10035)
68c95424 385 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
386
387 * xdisp.c (row_hash): New function, body extracted from
388 compute_line_metrics.
389 (compute_line_metrics): Call row_hash, instead of computing the
390 hash code inline.
391
392 * dispnew.c (verify_row_hash): Call row_hash for computing the
393 hash code of a row, instead of duplicating code from xdisp.c.
394
395 * dispextern.h (row_hash): Add prototype.
396
a2addb04
TH
3972011-11-18 Tassilo Horn <tassilo@member.fsf.org>
398
399 * frame.c (delete_frame): Don't delete the terminal when the last
400 X frame is closed if emacs is built with GTK toolkit.
401
df85d315
JB
4022011-11-17 Juanma Barranquero <lekktu@gmail.com>
403
404 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
405
a0c2d0ae
MR
4062011-11-17 Martin Rudalics <rudalics@gmx.at>
407
408 * window.c (Vwindow_splits): Rename to
409 Vwindow_combination_resize. Suggested by Juri Linkov.
410 (Fsplit_window_internal): Use Vwindow_combination_resize instead
411 of Vwindow_splits.
412
58179cce
JB
4132011-11-16 Juanma Barranquero <lekktu@gmail.com>
414
7877f373
JB
415 * nsfns.m (Fns_font_name):
416 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 417
b6f67890
MR
4182011-11-16 Martin Rudalics <rudalics@gmx.at>
419
420 * window.h (window): Rename slot "nest" to "combination_limit".
421 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
422 (Fset_window_nest): Rename to Fset_window_combination_limit.
423 (Vwindow_nest): Rename to Vwindow_combination_limit.
424 (recombine_windows, make_parent_window, make_window)
425 (Fsplit_window_internal, saved_window)
426 (Fset_window_configuration, save_window_save): Rename all
427 occurrences of window_nest to window_combination_limit.
428
c7015153
JB
4292011-11-15 Juanma Barranquero <lekktu@gmail.com>
430
431 * image.c (imagemagick_load_image): Fix typo.
432
322ad6ec
EZ
4332011-11-14 Eli Zaretskii <eliz@gnu.org>
434
435 * xdisp.c (display_line): Move the call to
436 highlight_trailing_whitespace before the call to
437 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
438 faces of all the glyphs to compute ROW's hash value.
439 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 440
f067b8ec
JB
4412011-11-14 Juanma Barranquero <lekktu@gmail.com>
442
443 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
444 just return (bug#10044).
445
1e5b2111
EZ
4462011-11-12 Eli Zaretskii <eliz@gnu.org>
447
7ef3cbd5
EZ
448 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
449 with user-defined heap size. Bump the default size of the temacs
450 heap to 27MB, to avoid memory warning when running temacs.
451 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
452
1e5b2111
EZ
453 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
454 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
455 (verify_row_hash) [XASSERTS]: New function.
456 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
457 that the hash value of glyph rows is correct.
1e5b2111 458
89d61221
MR
4592011-11-12 Martin Rudalics <rudalics@gmx.at>
460
461 * window.h (window): Remove splits slot.
462 * window.c (Fwindow_splits, Fset_window_splits): Remove.
463 (Fdelete_other_windows_internal, make_parent_window)
464 (make_window, Fsplit_window_internal, Fdelete_window_internal)
465 (Fset_window_configuration, save_window_save): Don't deal with
466 split status of windows.
467 (saved_window): Remove splits slot.
468 (Vwindow_splits): Rewrite doc-string.
469
97f18cc8
JD
4702011-11-11 Jan Djärv <jan.h.d@swipnet.se>
471
472 * xfns.c (unwind_create_frame):
473 * nsfns.m (unwind_create_frame):
474 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
475 Vframe_list (Bug#9999).
476
22a648b4
DA
4772011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
478
0b381c7e 479 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 480
659afede
KH
4812011-11-11 Kenichi Handa <handa@m17n.org>
482
483 * callproc.c (Fcall_process): Set the member dst_multibyte of
484 process_coding.
485
9ac0394b
KH
4862011-11-11 Johan Bockgård <bojohan@gnu.org>
487
488 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
489 avoid a crash (bug#9496).
490
2fbdc249
CY
4912011-11-09 Chong Yidong <cyd@gnu.org>
492
493 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
494 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
495
ac6b1f81
PE
4962011-11-08 Paul Eggert <eggert@cs.ucla.edu>
497
498 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
499
09db192c
PE
5002011-11-08 Paul Eggert <eggert@cs.ucla.edu>
501
502 Avoid some portability problems by eschewing 'extern inline' functions.
503 The trivial performance wins aren't worth the portability hassles; see
504 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
505 et seq.
506 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
507 (window_box_width, window_box_left, window_box_left_offset)
508 (window_box_right, window_box_right_offset): Undo previous change,
509 by removing the "extern"s.
510 * intervals.c (adjust_intervals_for_insertion)
511 (adjust_intervals_for_deletion): Undo previous change,
512 making these static again.
513 (offset_intervals, temp_set_point_both, temp_set_point)
514 (copy_intervals_to_string): No longer inline.
515 * xdisp.c (window_text_bottom_y, window_box_width)
516 (window_box_height, window_box_left_offset)
517 (window_box_right_offset, window_box_left, window_box_right)
518 (window_box): No longer inline.
519
105216ed
CY
5202011-11-08 Chong Yidong <cyd@gnu.org>
521
522 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
523 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
524 Signal an error if not a live window.
105216ed
CY
525 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
526 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
527
ae9e237f
JB
5282011-11-07 Juanma Barranquero <lekktu@gmail.com>
529
530 * lisp.h (syms_of_abbrev): Remove declaration.
531 Reported by CHENG Gao <chenggao@royau.me>.
532
c7aa8333
EZ
5332011-11-07 Eli Zaretskii <eliz@gnu.org>
534
535 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
536 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
537 of temacs in GUI mode.
538
be7f5545
MR
5392011-11-07 Martin Rudalics <rudalics@gmx.at>
540
541 * window.h: Declare delete_all_child_windows instead of
542 delete_all_subwindows.
543 * window.c (Fwindow_nest, Fset_window_nest)
544 (Fset_window_new_total, Fset_window_new_normal)
545 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
546 (delete_all_subwindows): Rename to delete_all_child_windows.
547 (Fdelete_other_windows_internal, Fset_window_configuration):
548 Call delete_all_child_windows instead of delete_all_subwindows.
549 * frame.c (delete_frame): Call delete_all_child_windows instead
550 of delete_all_subwindows.
551
ca78dc43
PE
5522011-11-07 Paul Eggert <eggert@cs.ucla.edu>
553
554 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
555 This is also needed for porting to any host where GC_MARK_STACK is
556 not GC_MAKE_GCPROS_NOOPS.
557 (which_symbols): Use it.
558
a0241d01
KH
5592011-11-07 Kenichi Handa <handa@m17n.org>
560
561 * coding.c (coding_set_destination): Check coding->src_pos only
562 when coding->src_object is a buffer (bug#9910).
563
564 * process.c (send_process): Set the member src_multibyte of coding
565 to 0 (bug#9911) when sending a unibyte text.
566
567 * callproc.c (Fcall_process): Set the member src_multibyte of
568 process_coding to 0 (bug#9912).
569
a64bfdfa 5702011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
571
572 * xmenu.c (cleanup_widget_value_tree): New function.
573 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
574 calling free_menubar_widget_value_tree directly (Bug#9830).
575
cb41b32a
PE
5762011-11-06 Paul Eggert <eggert@cs.ucla.edu>
577
578 Fix some portability problems with 'inline'.
579 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
580 (window_box_width, window_box_left, window_box_left_offset)
581 (window_box_right, window_box_right_offset): Declare extern.
582 Otherwise, these inline functions do not conform to C99 and
583 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
584 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
585 * intervals.c (adjust_intervals_for_insertion)
586 (adjust_intervals_for_deletion): Now extern, because otherwise the
587 extern inline functions 'offset_intervals' couldn't refer to it.
588 (static_offset_intervals): Remove.
589 (offset_intervals): Rewrite using the old contents of
590 static_offset_intervals. The old version didn't conform to C99
591 because an extern inline function contained a reference to an
592 identifier with static linkage.
593
b7041366
AS
5942011-11-06 Andreas Schwab <schwab@linux-m68k.org>
595
596 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
597 GC.
598
88a37c4d
EZ
5992011-11-06 Eli Zaretskii <eliz@gnu.org>
600
601 * xdisp.c (init_iterator, reseat_to_string): Don't set the
602 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
603 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
604 return Qleft_to_right.
605
49745b39
CY
6062011-11-06 Chong Yidong <cyd@gnu.org>
607
608 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
609 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
610 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
611 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
612 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
613 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
614 (Fwindow_vscroll): Doc fix.
615 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
616 argument, since it makes no sense to pass a live window and for
617 consistency with window-child.
618
1f05cd82
CS
6192011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
620
621 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
622 support MSVC.
623
22610910
JR
6242011-11-05 Jason Rumney <jasonr@gnu.org>
625
626 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
627 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
628 fonts (Bug#6029).
629 (add_font_entity_to_list): Fix logic errors in mixed boolean and
630 bitwise arithmetic preventing use of unicode-sip and non-truetype
631 opentype fonts.
632
a06776b2
EZ
6332011-11-05 Eli Zaretskii <eliz@gnu.org>
634
3ad924ba
EZ
635 * s/ms-w32.h (fstat, stat, utime): Move redirections to
636 "emacs"-only part.
637
a06776b2
EZ
638 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
639 initialization code to keep similarity to xfns.c after changes
640 from 2011-11-05.
641
c9e7db78
JD
6422011-11-05 Jan Djärv <jan.h.d@swipnet.se>
643
a97f8f3f
JD
644 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
645 (unwind_create_frame): New function (Bug#9943).
646 (Fx_create_frame): Restructure code to be more similar to the one in
647 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
648 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
649 Move terminal->reference_count++ just before making the frame official
650 (Bug#9943).
651
652 * nsterm.m (x_free_frame_resources): New function.
653 (x_destroy_window): Move code to x_free_frame_resources.
654
c9e7db78 655 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
656 (Fx_create_frame, x_create_tip_frame):
657 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
658 official. Move initialization of image_cache_refcount and
659 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
660
a6fc3b5c
EZ
6612011-11-05 Eli Zaretskii <eliz@gnu.org>
662
663 Support MSVC build with newer versions of Visual Studio.
664 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
665 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
666 nt/gmake.defs.
667
668 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
669 which are not supported by MSVC.
670 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
671 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
672 bitfields.
673 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
674 types in bitfields.
675 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
676
677 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
678
58179cce 6792011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
680
681 Support MSVC build with newer versions of Visual Studio.
682 * w32.c: Don't include w32api.h for MSVC.
683 (init_environment) [_MSC_VER]: Call sys_access, not _access.
684
685 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
686 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
687 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
688 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
689 e_* cousins.
690 (alloca) [_MSC_VER]: Define to _alloca.
691
692 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
693
694 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
695
a58c13ed
EZ
6962011-11-04 Eli Zaretskii <eliz@gnu.org>
697
698 * xdisp.c (note_mouse_highlight): If either of
699 previous/next-single-property-change returns nil, treat that as
700 the beginning or the end of the buffer. (Bug#9955)
701
fe0b6370
JD
7022011-11-04 Jan Djärv <jan.h.d@swipnet.se>
703
a58c13ed 704 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
705 label is not null (Bug#9951).
706 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
707 may be NULL.
708
89bd5ee1
EZ
7092011-11-04 Eli Zaretskii <eliz@gnu.org>
710
711 * window.c (Fwindow_body_size): Mention in the doc string that the
712 return value is in frame's canonical units. (Bug#9949)
713
84c3edb9
EZ
7142011-11-03 Eli Zaretskii <eliz@gnu.org>
715
4e2fb5c7
EZ
716 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
717
84c3edb9 718 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 719 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 720 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 721
bc17a887
EZ
7222011-11-01 Eli Zaretskii <eliz@gnu.org>
723
724 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
725 Don't stop backward scan on the continuation glyph, even though
726 its CHARPOS is positive.
6d5eb5b0
SM
727 (mouse_face_from_buffer_pos, note_mouse_highlight):
728 Rename cover_string to disp_string.
bc17a887 729
4ee88440
MR
7302011-11-01 Martin Rudalics <rudalics@gmx.at>
731
732 * window.c (temp_output_buffer_show): Don't use
733 Vtemp_buffer_show_specifiers.
734 (Vtemp_buffer_show_specifiers): Remove unused variable.
735
c2ff3c02
EZ
7362011-10-30 Eli Zaretskii <eliz@gnu.org>
737
738 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
739 past the beginning of the current glyph matrix.
740
58179cce 7412011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
742
743 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
744 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
745 HAVE_GTK3 (Bug#9869).
b77a6a7f 746
3b574623
JD
747 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
748 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
749
b77a6a7f
JD
750 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
751
752 * xterm.c: Declare x_handle_net_wm_state to return int.
753 (handle_one_xevent): Check if we are iconified but don't have
754 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
755 (get_current_wm_state): Return non-zero if not hidden,
756 check for _NET_WM_STATE_HIDDEN (Bug#9893).
757 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
758 (x_handle_net_wm_state): Return what get_current_wm_state returns.
759 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
760
196e41e4
PE
7612011-10-29 Paul Eggert <eggert@cs.ucla.edu>
762
763 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
764 so that this new function doesn't get optimized away by a
765 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
766
021f2e1a
AS
7672011-10-29 Andreas Schwab <schwab@linux-m68k.org>
768
769 * frame.h (MOUSE_HL_INFO): Remove excess parens.
770
8b058d44
EZ
7712011-10-29 Eli Zaretskii <eliz@gnu.org>
772
773 Fix the `xbytecode' command.
774 * .gdbinit (xprintbytestr): New command.
b50a28de 775 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
776 (xbytecode): Print the byte-code string as well.
777
4452fb80
EZ
7782011-10-29 Kim Storm <storm@cua.dk>
779
8b058d44
EZ
780 * alloc.c (which_symbols): New function.
781
21b72067
AS
7822011-10-29 Andreas Schwab <schwab@linux-m68k.org>
783
784 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
785 line. (Bug#9903)
786
83ed7b5c
GM
7872011-10-29 Glenn Morris <rgm@gnu.org>
788
789 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
790 Not clear what it was for, and it causes various bugs. (Bug#9839)
791
5a7a728b
EZ
7922011-10-28 Eli Zaretskii <eliz@gnu.org>
793
794 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
795 possible random value that matches one of those tested as
796 condition to clear the mouse face.
797
d3d0842f
CY
7982011-10-28 Chong Yidong <cyd@gnu.org>
799
800 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
801
31b39d13
DN
8022011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
803
804 * window.c (make_window): Initialize phys_cursor_on_p.
805
9aba6043
SM
8062011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
807
808 * lisp.h (struct Lisp_Symbol): Update comments.
809
c20992f4
JB
8102011-10-28 Juanma Barranquero <lekktu@gmail.com>
811
812 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
813
db4f02f2
EZ
8142011-10-28 Eli Zaretskii <eliz@gnu.org>
815
816 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
817 <oslsachem@gmail.com> for helping to debug this.
818
819 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
820 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
821 (g_b_init_get_glyph_outline_w): New static variables.
822 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
823 (GetGlyphOutlineW_Proc): New typedefs.
824 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
825 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
826 New functions.
827 (w32font_open_internal, compute_metrics):
828 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
829 instead of calling the "wide" APIs directly.
830
831 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
832
833 * w32.h (syms_of_w32font): Add prototype.
834
87e68db4
JB
8352011-10-27 Juanma Barranquero <lekktu@gmail.com>
836
837 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
838 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
839 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
840 (Fmove_to_window_line): Doc fix.
841
435c1d67
CY
8422011-10-27 Chong Yidong <cyd@gnu.org>
843
844 * process.c (make_process): Set gnutls_state to NULL.
845
846 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
847 non-NULL, regardless of GNUTLS_INITSTAGE.
848 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
849 an error. Set process slots as soon as we allocate them.
850
851 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
852
9c6c6f49
CY
8532011-10-27 Chong Yidong <cyd@gnu.org>
854
9aba6043
SM
855 * gnutls.c (emacs_gnutls_deinit): New function.
856 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
857 (Fgnutls_deinit, Fgnutls_boot): Use it.
858
859 * process.c (make_process): Initialize GnuTLS credentials to NULL.
860 (deactivate_process): Call emacs_gnutls_deinit.
861
657d08d3
JB
8622011-10-27 Juanma Barranquero <lekktu@gmail.com>
863
864 * image.c (x_create_x_image_and_pixmap):
865 * w32.c (sys_rename, w32_delayed_load):
866 * w32font.c (fill_in_logfont):
867 * w32reg.c (x_get_string_resource): Silence compiler warnings.
868
5430d399
JB
8692011-10-26 Juanma Barranquero <lekktu@gmail.com>
870
871 * w32fns.c (w32_default_color_map): New function,
872 extracted from Fw32_default_color_map.
a7ef684b 873 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 874
fe0055fa
PE
8752011-10-25 Paul Eggert <eggert@cs.ucla.edu>
876
877 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
878
e6346438
SM
8792011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
880
881 * keyboard.c (test_undefined): New function (bug#9751).
882 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
883
e112cc37
ET
8842011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
885
886 * sysdep.c (init_sys_modes): Fix the check for the controlling
887 terminal (Bug#6649).
888
7b5d6677
EZ
8892011-10-20 Eli Zaretskii <eliz@gnu.org>
890
891 * dispextern.h (struct bidi_it): New member next_en_type.
892
893 * bidi.c (bidi_line_init): Initialize the next_en_type member.
894 (bidi_resolve_explicit_1): When next_en_pos is valid for the
895 current character, check also for next_en_type being WEAK_EN.
896 (bidi_resolve_weak): Don't enter the expensive loop if the current
897 position is before next_en_pos. Record the bidi type of the first
898 non-ET, non-BN character we find, in addition to its position.
899 (bidi_level_of_next_char): Invalidate next_en_type when
900 next_en_pos is over-stepped.
901
7da0b018
PE
9022011-10-20 Paul Eggert <eggert@cs.ucla.edu>
903
904 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
905 * editfns.c: Rewrite current-time-zone so that it invokes
906 the equivalent of (format-time-string "%Z") to get the time zone name.
907 This fixes a bug when the time zone name contains characters that
908 need converting from the system time locale to Emacs internal format.
909 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
910 that patch fixed format-time-string to do the conversion, but
911 I forgot to fix current-time-zone.
912 (format_time_string): New function, containing most of
913 what Fformat_time_string used to contain.
914 (Fformat_time_string): Rewrite in terms of format_time_string.
915 This doesn't change this function's behavior.
916 (current-time-zone): Rewrite to use format_time_string.
917 This fixes the bug reported by Michael Schierl in
918 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
919 Jason Rumney's 2007-06-07 change worked around this bug, but
920 didn't fix it.
921 * systime.h (tzname, timezone): Remove no-longer-used declarations.
922
8547b010
EZ
9232011-10-19 Eli Zaretskii <eliz@gnu.org>
924
925 * xdisp.c (start_display): If the character at POS is displayed
926 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
927 (try_window_reusing_current_matrix): If a line ends in a display
928 vector or the next line starts in a display vector, continue
929 redrawing the window even though the character position of
930 start_row was reached.
8547b010
EZ
931 (Bug#9771, part 2)
932
4e948d15
CY
9332011-10-18 Chong Yidong <cyd@gnu.org>
934
935 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
936 with nobreak-char-display too.
937
4787455f
EZ
9382011-10-18 Eli Zaretskii <eliz@gnu.org>
939
940 Fix part 3 of bug#9771.
941 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
942 (bidi_resolve_neutral): Don't enter the expensive loop looking for
943 non-neutral characters if the current character is a paragraph
944 separator (a.k.a. Newline). This avoids running the same
945 expensive loop twice, once when we consume the preceding newline
946 and the other time when the line actually needs to be displayed.
947 Avoid the loop when we see neutrals on the base embedding level
948 following a character whose directionality is the same as the
949 paragraph's. This avoids running the expensive loop when a line
950 ends in a long sequence of neutrals, like control characters.
951 Add assertion against STRONG_AL type. Slightly rearrange code
952 that determines the type of a neutral given the first non-neutral
953 that follows it.
954 (bidi_level_of_next_char): Set next_en_pos to zero when
955 invalidating its info.
956
2c91f553
EZ
9572011-10-17 Eli Zaretskii <eliz@gnu.org>
958
959 * xdisp.c (push_display_prop): Determine whether to record string
960 or buffer position by IT->string, not by IT->method. Allow
961 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
962 (move_it_vertically_backward): Don't look for character position
963 immediately after the newline when in a continuation line.
964 (Bug#9771, part 1)
2c91f553 965
c7b08b0d
MR
9662011-10-15 Martin Rudalics <rudalics@gmx.at>
967
968 * window.c (coordinates_in_window): Rewrite and delabelize
969 vertical border check. (Bug#5357) (Bug#9618)
970
6b02f655
SM
9712011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
972
973 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
974 errors in XSetWindowBorder (bug#9310).
975
81d40c92
DA
9762011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
977
978 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
979 avoid crash when xmalloc overrun checking is enabled.
980
d4172c3b
EZ
9812011-10-13 Eli Zaretskii <eliz@gnu.org>
982
983 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
984 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
985 cursor motion with <left> and <right> arrow keys.
986
987 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
988 some callers set that themselves.
989
b00eea75
EZ
9902011-10-12 Eli Zaretskii <eliz@gnu.org>
991
992 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
993 display string and the previous row comes from the same string and
994 is empty. (Bug#9739) (Bug#9738)
995
8fe012c4
SM
9962011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
997
998 * doc.c (get_doc_string): Encode file name (bug#9735).
999
0074aef2
EZ
10002011-10-12 Eli Zaretskii <eliz@gnu.org>
1001
79beb178
EZ
1002 * bidi.c (bidi_level_of_next_char):
1003 * xdisp.c (get_visually_first_element): Remove old incorrect
1004 comments regarding the Unicode Line Separator character.
1005
0074aef2
EZ
1006 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1007
6e4b3fbe
DA
10082011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1009
1010 * alloc.c (Fgc_status): Do not access beyond zombies array
1011 boundary if nzombies > MAX_ZOMBIES.
1012 * alloc.c (dump_zombies): Add missing format specifier.
1013
0324f3af
PE
10142011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1015
b5525cac
PE
1016 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1017 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1018
0324f3af
PE
1019 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1020 Some packages use them to denote characters with modifiers.
1021
e9b5f888
AS
10222011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1023
1024 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1025 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1026 matching a pp-number. Rename parameter var to var1.
1027
127827c0
SM
10282011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1029
1030 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1031
c8fd3bd0
GM
10322011-10-08 Glenn Morris <rgm@gnu.org>
1033
1034 * callint.c (Fcall_interactively): Give a more explicit error for the
1035 'c' case with a non-character input. (Bug#8479)
1036
352ec8ff
EZ
10372011-10-08 Eli Zaretskii <eliz@gnu.org>
1038
03669ccb
EZ
1039 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1040 lines.
7061c986
EZ
1041 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1042 lines that are hscrolled on the left.
03669ccb 1043
352ec8ff
EZ
1044 * dispnew.c (buffer_posn_from_coords): Account for a possible
1045 presence of header-line. (Bug#4426)
1046
a66cfb1c
SM
10472011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1048
6b02f655
SM
1049 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1050 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1051
7c5ee88e
PE
10522011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1053
1054 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1055 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1056 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1057 this makes Emacs dump core during garbage collection on rare
1058 occasions. sizeof is obviously inferior to offsetof here, so
1059 stick with offsetof.
1060 (GC_POINTER_ALIGNMENT): New macro.
1061 (mark_memory): Omit 3rd (offset) arg; caller changed.
1062 Don't assume EMACS_INT alignment is the same as pointer alignment.
1063
df1bbe5b
SM
10642011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1065
1066 * keyboard.c (read_key_sequence_remapped): New var.
1067 (read_key_sequence): Compute remapping in the right buffer.
1068 (command_loop_1): Use read_key_sequence's remapping directly.
1069
51553db6
SM
10702011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1071
32c1fffd
SM
1072 * dired.c (file_name_completion): Don't expand file name.
1073 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1074 before checking file name handler.
1075
51553db6
SM
1076 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1077 they've been requested explicitly (bug#9591).
1078
b6bd1599 10792011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1080
1081 * keymap.c (Fsingle_key_description): Use make_specified_string
1082 instead of build_string to build string from push_key_description.
1083 (Bug#5193)
1084
f701dc2a
PE
10852011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1086
4222c55d
PE
1087 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1088 This fixes a Y2038 bug on 64-bit hosts.
1089 * buffer.c (reset_buffer):
1090 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1091 (Fclear_buffer_auto_save_failure):
1092 Use 0, not -1, to represent an unset failure time, since time_t
1093 might not be signed.
1094
f701dc2a
PE
1095 Remove dependency on glibc malloc internals.
1096 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1097 Move back here from lisp.h, but with their new implementations.
1098 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1099 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1100 * charset.c (charset_table_init): New static var.
1101 (syms_of_charset): Use it instead of xmalloc. This removes a
1102 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1103 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1104 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1105 Move back to alloc.c.
1106 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1107 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1108
9ceebf39
JD
11092011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1110
1111 * nsterm.m (windowDidResize): Call x_set_window_size only when
1112 ns_in_resize is true. Otherwise set pixelwidth/height and
1113 call change_frame_size (Bug#9628).
1114
cb993c58
PE
11152011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1116
3930c88b
PE
1117 Port --enable-checking=all to Fedora 14 x86-64.
1118 * charset.c (syms_of_charset): Also account for glibc malloc's
1119 internal overhead when calculating the initial malloc maximum.
1120
cb993c58
PE
1121 Port --enable-checking=all to Fedora 14 x86.
1122 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1123 Move to lisp.h.
1124 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1125 (overrun_check_realloc, overrun_check_free):
1126 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1127 That way, xmalloc returns a properly-aligned pointer even if
1128 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1129 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1130 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1131 into account when calculating the initial malloc maximum.
1132 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1133 Move here from alloc.c, so that charset.c can use it too.
1134 Properly align; the old code wasn't right for common 32-bit hosts
1135 when configured with --enable-checking=all.
1136 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1137 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1138
31bed486
EZ
11392011-09-29 Eli Zaretskii <eliz@gnu.org>
1140
04c70788 1141 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1142 use EDOM.
1143
fbcaa2f3
EZ
11442011-09-28 Eli Zaretskii <eliz@gnu.org>
1145
1146 * xdisp.c (compute_display_string_end): If there's no display
1147 string at CHARPOS, return -1.
1148
1149 * bidi.c (bidi_fetch_char): When compute_display_string_end
1150 returns a negative value, treat the character as a normal
1151 character not covered by a display string. (Bug#9624)
1152
a239d4e9
JB
11532011-09-28 Juanma Barranquero <lekktu@gmail.com>
1154
1155 * lread.c (Fread_from_string): Fix typo in docstring.
1156
88652fd5
EZ
11572011-09-27 Eli Zaretskii <eliz@gnu.org>
1158
1159 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1160 newline, reseat the iterator instead of bidi-iterating there one
1161 character at a time. (Bug#9610)
32c1fffd
SM
1162 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1163 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1164
ed497dd4
AS
11652011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1166
1167 * lread.c (readevalloop): Use correct code for NBSP.
1168 (read1): Likewise. (Bug#9608)
1169
b2bf61aa
MA
11702011-09-25 Michael Albinus <michael.albinus@gmx.de>
1171
1172 * dbusbind.c (Fdbus_register_signal): When service is not
1173 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1174
32bbb17c
GM
11752011-09-25 Glenn Morris <rgm@gnu.org>
1176
1177 * buffer.c (truncate-lines): Doc fix.
1178
94e0933e
CY
11792011-09-24 Chong Yidong <cyd@stupidchicken.com>
1180
1181 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1182 (Fset_window_next_buffers): Doc fix.
1183
cddde921
GM
11842011-09-24 Glenn Morris <rgm@gnu.org>
1185
1186 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1187
1260aef1
PE
11882011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1189
25b4bfa0
PE
1190 Fix minor problems found by static checking.
1191 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1192 * indent.c (Fvertical_motion): Fix == vs = typo.
1193
e3cbd34b
EZ
11942011-09-24 Eli Zaretskii <eliz@gnu.org>
1195
a66cfb1c
SM
1196 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1197 Default value is now t. Doc fix.
6bf7006f 1198
e3cbd34b 1199 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1200 logic when moving up, not only when moving down. Fix the
e3cbd34b 1201 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1202 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1203
1204 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1205 CHARPOS is covered by a display string which includes newlines.
1206 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1207 is covered by a display string with embedded newlines.
1208
a3de0cbd
MA
12092011-09-24 Michael Albinus <michael.albinus@gmx.de>
1210
1211 * dbusbind.c (Fdbus_register_signal): Add match rule to
1212 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1213 (Fdbus_register_method, Vdbus_registered_objects_table):
1214 Fix docstring.
a3de0cbd 1215
b260039d
JM
12162011-09-24 Jim Meyering <meyering@redhat.com>
1217
32c1fffd 1218 do not ignore write error for any output size
b260039d
JM
1219 The previous change was incomplete.
1220 While it makes emacs --batch detect the vast majority of stdout
1221 write failures, errors were still ignored whenever the output size is
1222 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1223 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1224 && echo FAIL: ignored write error
1225 FAIL: ignored write error
1226 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1227 && echo FAIL: ignored write error
1228 FAIL: ignored write error
1229 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1230
8eca8a7c
AS
12312011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1232
1233 * emacs.c (Fkill_emacs): In noninteractive mode exit
1234 non-successfully if a write error occurred on stdout. (Bug#9574)
1235
3341db62
EZ
12362011-09-21 Eli Zaretskii <eliz@gnu.org>
1237
1238 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1239 the xassert test.
1240
1241 * dispextern.h (struct it): Update the comment documenting what
1242 can it->OBJECT be.
1243
8c203dbf
EZ
12442011-09-20 Eli Zaretskii <eliz@gnu.org>
1245
1246 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1247 a display string, extend search for cursor position to end of row.
1248 (find_row_edges): If the row ends in a newline from a display
1249 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1250 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1251 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1252 non-empty line. Fixes confusing cursor motion with arrow keys at
1253 the beginning of a line that starts with whitespace.
8c203dbf 1254
a4824228
LMI
12552011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1256
1257 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1258 (bug#9493).
1259
33ed493b
CY
12602011-09-18 Chong Yidong <cyd@stupidchicken.com>
1261
1262 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1263 boolean (Bug#9154).
1264
56cd55c8
EZ
12652011-09-18 Eli Zaretskii <eliz@gnu.org>
1266
1267 * xdisp.c (display_line): Record maximum and minimum buffer
1268 positions even if no glyphs were produced (e.g., by a zero-width
1269 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1270 buffer positions that will be removed from the glyph row because
1271 they don't fit.
c02dcedf
EZ
1272 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1273 column is beyond frame width: don't subtract 1 "pixel" when
1274 computing width of the stretch.
3e62b7e0
EZ
1275 (reseat_at_next_visible_line_start): Undo the change made on
1276 2011-09-17 that saved paragraph information and restored it after
1277 the call to `reseat'. (Bug#9545)
56cd55c8 1278
5ed99d36 12792011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1280
1281 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1282 and turn window cursor on if cleared (Bug#9415).
1283
5ed99d36 12842011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1285
1286 * search.c (boyer_moore): Take unibyte characters from pattern
1287 literally. (Bug#9458)
1288
9bade7b2
EZ
12892011-09-18 Eli Zaretskii <eliz@gnu.org>
1290
1291 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1292
e5e9d610
PE
12932011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1294
87e4427a
PE
1295 Fix minor problem found by static checking.
1296 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1297 initialized, to pacify gcc -Wuninitialized.
1298
e5e9d610
PE
1299 * fileio.c: Report proper errno when syscall falls.
1300 (Finsert_file_contents): Save and restore errno,
1301 so that report_file_error outputs the correct diagnostic.
1302 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1303
a1674f0b
EZ
13042011-09-18 Eli Zaretskii <eliz@gnu.org>
1305
1306 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1307
fbfb6dd4
EZ
13082011-09-17 Eli Zaretskii <eliz@gnu.org>
1309
1310 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1311 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1312
bb187662
EZ
13132011-09-17 Eli Zaretskii <eliz@gnu.org>
1314
1137e8b8 1315 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1316 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1317
1318 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1319 (bidi_find_paragraph_start): Search back for paragraph beginning
1320 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1321 (bidi_move_to_visually_next): Only trigger paragraph-related
1322 computations when the last character is a newline or at EOB, not
1323 just any NEUTRAL_B. (Bug#9470)
1324
bb187662
EZ
1325 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1326 truncated lines if point is covered by a display string. (Bug#9524)
1327
2e621251
PE
13282011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1329
1330 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1331 (cons_to_x_long): New function.
1332 (lisp_data_to_selection_data): Use it. Correct the test for
1333 short-versus-long data; it was negated. Break out of vector
1334 loop, for efficiency, when a long datum is discovered.
1335
91a15bc6
SM
13362011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1337
1338 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1339
b41c3a35
EZ
13402011-09-16 Eli Zaretskii <eliz@gnu.org>
1341
1342 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1343 GCC PR/17406) by declaring this function with external scope.
1344
7812ba2d
PE
13452011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1346
1347 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1348 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1349
cf7edc2a
AS
13502011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1351
1352 * editfns.c (Fformat): Correctly handle text properties on "%%".
1353
bd01620e
EZ
13542011-09-15 Eli Zaretskii <eliz@gnu.org>
1355
1356 * xterm.c (x_draw_composite_glyph_string_foreground):
1357 * w32term.c (x_draw_composite_glyph_string_foreground):
1358 * term.c (encode_terminal_code):
1359 * composite.c (composition_update_it, get_composition_id):
1360 * xdisp.c (get_next_display_element)
1361 (fill_composite_glyph_string): Add comments about special meaning
1362 of TAB characters in a composition.
1363
a02719a3
PE
13642011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1365
1366 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1367 This occurs when processing a multibyte format.
1368 Problem reported by Wolfgang Jenker.
a02719a3 1369
72589a3c
JB
13702011-09-15 Johan Bockgård <bojohan@gnu.org>
1371
1372 * xdisp.c (try_cursor_movement): Only check for exact match if
1373 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1374
1c14176c
PE
13752011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1376
1377 Remove unused external symbols.
1378 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1379 * xdisp.c (calc_pixel_width_or_height): Now static.
1380 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1381 * indent.c (check_display_width):
1382 * w32term.c: Fix comment to match code.
1383 * xterm.c, xterm.h (x_catching_errors): Remove.
1384
d2eea5b5
PE
13852011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1386
1387 * xselect.c: Use signed conversions more consistently (Bug#9498).
1388 (selection_data_to_lisp_data): Assume incoming selection data are
1389 signed integers, not unsigned. This is to be consistent with
1390 outgoing selection data, which was modified to use signed integers
1391 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1392 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1393 expects long, not unsigned long.
1394
46888499
EZ
13952011-09-14 Eli Zaretskii <eliz@gnu.org>
1396
1397 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1398 computation of loop end. Reported by Johan Bockgård
1399 <bojohan@gnu.org>.
1400
ef8ef9fb
CY
14012011-09-13 Chong Yidong <cyd@stupidchicken.com>
1402
1403 * frame.c (Fother_visible_frames_p): Function deleted.
1404
fa819fed
EZ
14052011-09-12 Eli Zaretskii <eliz@gnu.org>
1406
1407 * indent.c (compute_motion): Process display vector front to back
1408 rather than the other way around. (Bug#2496)
1409
2ba8e008
SM
14102011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1411
1412 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1413
20f53c69
CY
14142011-09-11 Chong Yidong <cyd@stupidchicken.com>
1415
1416 * minibuf.c (Fread_from_minibuffer): Doc fix.
1417
d562d7a4
EZ
14182011-09-11 Eli Zaretskii <eliz@gnu.org>
1419
1420 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1421 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1422
1c4d7f3d
LMI
14232011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1424
1425 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1426 value for non-existent files.
1427
b885bf36
EZ
14282011-09-11 Eli Zaretskii <eliz@gnu.org>
1429
1430 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1431 set its "size" to -1. This will set the modtime_size field of
1432 the corresponding buffer to -1, which is what
1433 verify-visited-file-modtime expects for files that do not exist.
1434 (Bug#9139)
1435
6612f0bf
PE
14362011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1437
1438 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1439 here ...
1440 * lisp.h: ... from here. push_key_description is no longer
1441 defined in keyboard.c, so its declaration should not be in
1442 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1443 logically belongs with push_key_description.
1444
dfb3f755
PE
14452011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1446
1447 * buffer.h: Include <sys/types.h> instead of <time.h>.
1448 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1449 Problem reported by Herbert J. Skuhra.
1450
3134906c
LMI
14512011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1452
1453 * xml.c (parse_region): Make the parsing work for
1454 non-comment-starting XML files again (bug#9144).
1455
8d903f4e
AS
14562011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1457
1458 * image.c (gif_load): Fix calculation of bottom and right corner.
1459 (Bug#9468)
1460
80ad64f4
EZ
14612011-09-10 Eli Zaretskii <eliz@gnu.org>
1462
1463 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1464 redisplay in small windows.
1465
208a048d
EZ
14662011-09-09 Eli Zaretskii <eliz@gnu.org>
1467
1468 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1469
9b1c252e
MR
14702011-09-08 Martin Rudalics <rudalics@gmx.at>
1471
1472 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1473 Operate on live windows only.
1474
2949f33b
JB
14752011-09-08 Juanma Barranquero <lekktu@gmail.com>
1476
1477 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1478
e08dcafd
EZ
14792011-09-07 Eli Zaretskii <eliz@gnu.org>
1480
1481 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1482 only under bidi iteration.
1483
115b96bd
JD
14842011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1485
1486 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1487
c8199d0f
PE
14882011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1489
1490 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1491 Without this fix, the command to link temacs failed due to an
1492 undefined symbol __builtin_isnan. This is because
1493 /usr/include/iso/math_c99.h #defines isnan(x) to
1494 __builtin_isnan(x), but the bundled gcc, which identifies itself
1495 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1496 a __builtin_isnan.
1497 * floatfns.c (isnan): #undef, and then #define to a clone of
1498 what's in data.c.
1499 (Fisnan): Always define, since it's always available now.
1500 (syms_of_floatfns): Always define isnan at the Lisp level.
1501
e39b275c 15022011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1503
1504 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1505
b2db44d9 15062011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1507
f4af5137 1508 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1509 The previous code assumed that file offsets (off_t values) fit in
1510 EMACS_INT variables, which is not true on typical 32-bit hosts.
1511 The code messed up by falsely reporting buffer overflow in cases
1512 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1513 when "big" contains more than 2**29 bytes, even though this
1514 inserts just one byte and does not overflow the buffer.
1515 (Finsert_file_contents): Store file offsets as off_t
1516 values, not as EMACS_INT values. Check for overflow when
1517 converting between EMACS_INT and off_t. When checking for
1518 buffer overflow or for overlap, take the offsets into account.
1519 Don't use EMACS_INT for small values where int suffices.
1520 When checking for overlap, fix a typo: ZV was used where
1521 ZV_BYTE was intended.
1522 (Fwrite_region): Don't assume off_t fits into 'long'.
1523 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1524
ecfc0a49
MA
15252011-09-05 Michael Albinus <michael.albinus@gmx.de>
1526
1527 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1528
6511acf2 15292011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1530
0999621a 1531 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1532
1533 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1534 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1535 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1536 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1537 (modify_event_symbol): Do not assume that the length of
1538 name_alist_or_stem is safe to alloca and fits in int.
1539 (Fexecute_extended_command): Likewise for function name and binding.
1540 (Frecursion_depth): Wrap around reliably on integer overflow.
1541 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1542 since some callers pass EMACS_INT values.
1543 (Fsingle_key_description): Don't crash if symbol name contains more
1544 than MAX_ALLOCA bytes.
1545 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1546 (get_minibuffer): Arg is now EMACS_INT, not int.
1547 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1548 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1549 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1550
2be7d702
PE
1551 * dbusbind.c (signature_cat): New function.
1552 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1553 Do not overrun buffer; instead, report string overflow.
1554
9d1df220
PE
1555 * dispnew.c (add_window_display_history): Don't overrun buffer.
1556 Truncate instead; this is OK since it's just a log.
1557
33ef5c64
PE
1558 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1559 even if the time zone offset is outlandishly large.
1560 Don't mishandle offset == INT_MIN.
1561
66c6fdd5
PE
1562 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1563 when creating daemon; the previous buffer-overflow check was incorrect.
1564
d749b01b
PE
1565 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1566 which has the guts of the old verror function.
1567
b5cd1905
PE
1568 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1569 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1570
6e1a67fb
PE
1571 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1572 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1573 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1574 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1575 length of string rather than counting it via multiple sprintfs;
1576 that's simpler and more reliable.
c21721cc
PE
1577 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1578 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1579 sprintf, in case result does not fit in int.
1580
c57b67fc
PE
1581 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1582 (fontset_from_font): Print it.
1583
8a401434
PE
1584 * frame.c (tty_frame_count): Now printmax_t, not int.
1585 (make_terminal_frame, set_term_frame_name): Print it.
1586 (x_report_frame_params): In X, window IDs are unsigned long,
1587 not signed long, so print them as unsigned.
1588 (validate_x_resource_name): Check for implausibly long names,
1589 and don't assume name length fits in 'int'.
1590 (x_get_resource_string): Don't blindly alloca invocation name;
1591 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1592 not fit in int.
1593
6e1a67fb
PE
1594 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1595 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1596 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1597
0df02bf3
PE
1598 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1599 Use esprintf, not sprintf, in case result does not fit in int.
1600
48e30793
PE
1601 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1602 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1603 it as a large positive number.
1604 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1605 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1606
a66ff6d8
PE
1607 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1608 in case result does not fit in int.
1609
aca216ff
PE
1610 * print.c (float_to_string): Detect width overflow more reliably.
1611 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1612 buffer overrun. Don't assume list length fits in 'int'. Treat
1613 print length of 0 as 0, not as infinity; to be consistent with other
1614 uses of print length in this function. Don't overflow print length
1615 index. Don't assume hash table size fits in 'long', or that
1616 vectorlike size fits in 'unsigned long'.
1617
31c286f7
PE
1618 * process.c (make_process): Use printmax_t, not int, to format
1619 process-name gensyms.
1620
55e5faa1
PE
1621 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1622
80f2e268
PE
1623 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1624 to avoid potential buffer overrun.
1625
670741ab
PE
1626 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1627 if X resource line is longer than 512 bytes.
1628
b7163a50
PE
1629 * xfns.c (x_window): Make sprintf buffer a bit bigger
1630 to avoid potential buffer overrun.
1631
ae58ff1f
PE
1632 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1633
c43c8a6a
PE
1634 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1635
3f8236f4
PE
16362011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1637
53e9fe90 1638 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1639 Without these, Emacs silently mishandles large integers sometimes.
1640 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1641 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1642
6511acf2
PE
1643 * xdisp.c (try_window_id): Check Emacs fixnum range before
1644 converting to 'int'.
806add1d 1645
6511acf2 1646 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1647 Check that an Emacs fixnum is in range before assigning it to 'int'.
1648 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1649 values converted from Emacs fixnums.
1650 (Frecenter): Don't wrap around a line count if it is out of 'int'
1651 range; instead, treat it as an extreme value.
1652 (Fset_window_configuration, compare_window_configurations):
1653 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1654
6511acf2
PE
1655 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1656 that can exceed INT_MAX. Check that EMACS_INT value is in range
1657 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1658 (match_limit): Don't assume that a fixnum can fit in 'int'.
1659
6511acf2 1660 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1661 exceed INT_MAX.
1662
6511acf2 1663 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1664 (Fvertical_motion): Don't wrap around LINES values that don't fit
1665 in 'int'. Instead, treat them as extreme values. This is good
1666 enough for windows, which can't have more than INT_MAX lines anyway.
1667
fcb901a7
LMI
16682011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1669
0f2f6b6d
LMI
1670 * Require libxml/parser.h to avoid compilation warning.
1671
fcb901a7
LMI
1672 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1673
1674 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1675 since this reportedly can destroy thread storage.
1676
6e20a0d4
CY
16772011-08-30 Chong Yidong <cyd@stupidchicken.com>
1678
1679 * syntax.c (find_defun_start): Update all cache variables if
1680 exiting early (Bug#9401).
1681
148ae00e
EZ
16822011-08-30 Eli Zaretskii <eliz@gnu.org>
1683
f6cfbd8f
EZ
1684 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1685
148ae00e
EZ
1686 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1687 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1688 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1689
1690 * term.c (tty_append_glyph): New function.
1691 (produce_stretch_glyph): Static function and its prototype deleted.
1692
a66cfb1c
SM
1693 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1694 Add prototypes.
148ae00e 1695
c4a07a4c
PE
16962011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1697
1698 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1699 when checking :margin (Bug#9390).
1700 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1701 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1702 so that the name doesn't mislead. All uses changed.
1703
6bc8cd65
JB
17042011-08-28 Johan Bockgård <bojohan@gnu.org>
1705
1706 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1707 set_tty_hooks.
1708
dca4927e
EZ
17092011-08-27 Eli Zaretskii <eliz@gnu.org>
1710
1711 * xdisp.c (move_it_to): Don't bail out early when reaching
1712 position beyond to_charpos, if we are scanning backwards.
1713 (move_it_vertically_backward): When DY == 0, make sure we get to
1714 the first character in the line after the newline.
1715
f2cad773
PE
17162011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1717
1718 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1719 (ccl_driver): Do not generate an out-of-range pointer.
1720 (Fccl_execute_on_string): Remove unnecessary check for
1721 integer overflow, noted by Stefan Monnier in
1722 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1723 Remove a FIXME that didn't need fixing.
1724 Simplify the newly-introduced buffer reallocation code.
1725
0cae2cdb
JB
17262011-08-27 Juanma Barranquero <lekktu@gmail.com>
1727
1728 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1729
5fc295a4 17302011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1731
70c60eb2 1732 Integer and memory overflow issues (Bug#9196).
726e0ab1 1733
d31850da
PE
1734 * doc.c (get_doc_string): Rework so that
1735 get_doc_string_buffer_size is the actual buffer size, rather than
1736 being 1 less than the actual buffer size; this makes xpalloc more
1737 convenient.
1738
a69fbedb
PE
1739 * image.c (x_allocate_bitmap_record, cache_image):
1740 * xselect.c (Fx_register_dnd_atom):
1741 Simplify previous changes by using xpalloc.
1742
fe5c5d37
PE
1743 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1744 since either will do and ptrdiff_t is convenient with xpalloc.
1745
0065d054
PE
1746 * charset.c (charset_table_size)
1747 (struct charset_sort_data.priority): Now ptrdiff_t.
1748 (charset_compare): Don't overflow if priorities differ greatly.
1749 (Fsort_charsets): Don't assume list length fits in int.
1750 Check for size-calculation overflow when allocating sort data.
1751 (syms_of_charset): Allocate an initial charset table that is
1752 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1753
1754 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1755
1756 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1757 The actual value is always <= INT_MAX, and leaving it unsigned made
1758 overflow checking harder.
1759
1760 * dispextern.h (struct glyph_matrix.rows_allocated)
1761 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1762 with xpalloc. The values are still always <= INT_MAX.
1763
1764 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1765
1766 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1767 (SAFE_NALLOCA): New macro.
1768
1769 * region-cache.c (struct boundary.pos, find_cache_boundary)
1770 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1771 (set_cache_region, invalidate_region_cache)
1772 (revalidate_region_cache, know_region_cache, region_cache_forward)
1773 (region_cache_backward, pp_cache):
1774 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1775 so that ptrdiff_t * can be passed to xpalloc.
1776 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1777 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1778 (pp_cache): Don't assume cache_len fits in int.
1779 * region-cache.h: Adjust extern decls to match.
1780
1781 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1782 EMACS_INT, since either will do, for xpalloc.
1783
1784 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1785 (xnmalloc, xnrealloc, xpalloc): New functions.
1786
726e0ab1
PE
1787 * bidi.c (bidi_shelve_header_size): New constant.
1788 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1789 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1790
51f30bc5 1791 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1792 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1793 (overlay_strings):
1794 Don't update size of array until after memory allocation succeeds,
1795 because xmalloc/xrealloc may not return.
0065d054
PE
1796 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1797 now that we have proper integer overflow checking.
1798 (record_overlay_string, overlay_strings): Catch overflows when
1799 calculating size of overlay_str_buf.
726e0ab1 1800
0065d054
PE
1801 * callproc.c (Fcall_process): Check for size overflow when
1802 calculating size of args2.
1803 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1804 Normally we prefer signed values, but sticking with ptrdiff_t would
1805 require adding more-complicated checks.
726e0ab1
PE
1806
1807 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1808 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1809 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1810 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1811
1812 * character.c (Fstring): Check for size-calculation overflow.
1813
1814 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1815 unnecessary integer overflow. Check for size overflow.
1816 (encode_coding_object): Don't update size until xmalloc succeeds.
1817
1818 * composite.c (get_composition_id): Check for overflow in glyph
1819 length calculations.
1820
1821 Integer and memory overflow fixes for display code.
1822 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1823 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1824 (scrolling_window): Check for overflow in size calculations.
1825 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1826 Don't assume glyph table len fits in int.
1827 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1828 (row_table_size): Now ptrdiff_t, not int.
1829 (scrolling_window): Avoid overflow in size calculations.
1830 Don't update size until allocation succeeds.
1831 * fns.c (concat): Check for overflow in size calculations.
1832 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1833 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1834 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1835
1836 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1837 (get_doc_string): Check for size calculation overflow.
1838 Don't update size until allocation succeeds.
1839 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1840 EMACS_INT, where ptrdiff_t will do.
1841 (Fsubstitute_command_keys): Check for string overflow.
1842
1843 * editfns.c (set_time_zone_rule): Don't assume environment length
1844 fits in int.
1845 (message_length): Now ptrdiff_t, not int.
1846 (Fmessage_box): Don't update size until allocation succeeds.
1847 Don't assume message length fits in int.
1848 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1849
0065d054
PE
1850 * emacs.c (main): Do not reallocate argv, since there is a null at
1851 the end that can be overwritten, and this way there's no need to
1852 worry about size-calculation overflow.
1853 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1854
1855 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1856 alloc succeeds.
1857 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1858
1859 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1860 (x_set_scroll_bar_width, x_figure_window_size):
1861 Check for integer overflow.
1862 (x_set_alpha): Do not assume XINT fits in int.
1863
1864 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1865 This is for the members text_lines, text_cols, total_lines, total_cols,
1866 where the system imposes an 'int' limit.
1867
1868 * fringe.c (Fdefine_fringe_bitmap):
1869 Don't update size until alloc works.
1870
1871 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1872 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1873
1874 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1875 Check for size-calculation overflow.
1876 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1877 do, as we prefer signed integers.
1878 (id_to_widget.max_size, id_to_widget.used)
1879 (xg_store_widget_in_map, xg_remove_widget_from_map)
1880 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1881 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1882 Use and return ptrdiff_t, not int.
1883 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1884 * gtkutil.h: Change prototypes to match the above.
1885
1886 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1887 are duplicate now that they've been promoted to lisp.h.
1888 (x_allocate_bitmap_record, x_alloc_image_color)
1889 (make_image_cache, cache_image, xpm_load):
1890 Don't update size until alloc is done.
1891 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1892 (x_detect_edges):
3256efce 1893 Check for size calculation overflow.
726e0ab1
PE
1894 (ct_colors_allocated_max): New constant.
1895 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1896 overflow.
3256efce 1897
726e0ab1
PE
1898 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1899 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1900 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1901 Use ptrdiff_t, not int, to count maps.
1902 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1903 calculations. Don't update size until allocation succeeds.
1904 Redo calculations to avoid overflow.
726e0ab1
PE
1905 * keyboard.h: Change prototypes to match the above.
1906
1907 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1908 to count maps.
1909 (current_minor_maps): Check for size calculation overflow.
1910 * keymap.h: Change prototypes to match the above.
1911
1912 * lread.c (read1, init_obarray): Don't update size until alloc done.
1913
1914 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1915 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1916
726e0ab1
PE
1917 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1918 Now ptrdiff_t, not int.
1919 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1920 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1921
1922 * process.c (Fnetwork_interface_list): Check for overflow
1923 in size calculation.
1924
1925 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1926
1927 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1928 overflow. Don't bother calling xmalloc when xrealloc will do.
1929
1930 * search.c (Freplace_match): Check for size calculation overflow.
1931 (Fset_match_data): Don't assume list lengths fit in 'int'.
1932
1933 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1934 for command line length. Do not attempt to address one before the
1935 beginning of an array, as that's not portable.
1936
1937 * term.c (max_frame_lines): Remove; unused.
1938 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1939 not int.
1940 (encode_terminal_code, calculate_costs): Check for size
1941 calculation overflow.
1942 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1943 table lengths and related sizes. Don't update size until alloc
1944 done. Redo calculations to avoid overflow.
1945 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1946
1947 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1948 subtracting pointers.
1949 (gobble_line): Check for overflow more carefully. Don't update size
1950 until alloc done.
1951
1952 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1953 Don't update size until alloc done.
1954 Redo size calculations to avoid overflow.
1955 Check for size calculation overflow.
0065d054 1956 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1957
1958 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1959 Use ptrdiff_t, not int, for sizes.
1960 (store_mode_line_noprop_char): Don't update size until alloc done.
1961
0065d054
PE
1962 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1963 Use ptrdiff_t, not int, for sizes.
1964 (Finternal_make_lisp_face, cache_face):
1965 Check for size calculation overflow.
1966 (cache_face): Treat size calculation overflows as if they were
1967 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1968
1969 * xfns.c (x_encode_text, x_set_name_internal)
1970 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1971 sizes, since they can exceed INT_MAX in size. Check for size
1972 calculation overflow.
1973
0065d054
PE
1974 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1975 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1976 Don't update size until alloc done.
1977
0065d054 1978 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1979 as sprintf is limited to int lengths.
1d526e2f 1980
252c5ee1
PE
1981 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1982 (X_LONG_MIN): New macros.
864d7ce7
PE
1983 Use them to make the following changes clearer.
1984 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1985 This change doesn't affect the value now, but it may help remind
1986 future maintainers not to raise the value too much later.
1987 (SELECTION_QUANTUM): Remove, replacing with ...
1988 (selection_quantum): ... new function, which avoids overflow.
1989 All uses changed.
1990 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1991 assumption that selection length fits in 'int'.
1992 (x_reply_selection_request, x_handle_selection_request)
1993 (x_get_window_property, receive_incremental_selection)
1994 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1995 (lisp_data_to_selection_data, clean_local_selection_data):
1996 Use ptrdiff_t, not int, to record length of selection.
1997 (x_reply_selection_request, x_get_window_property)
1998 (receive_incremental_selection, x_property_data_to_lisp):
1999 Redo calculations to avoid overflow.
2000 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2001 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2002 something.
2003 (x_get_window_property, receive_incremental_selection)
2004 (lisp_data_to_selection_data, x_property_data_to_lisp):
2005 Check for size-calculation overflow.
2006 (x_get_window_property, receive_incremental_selection)
2007 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2008 Don't store size until memory allocation succeeds.
2009 (x_get_window_property): Plug memory leak on memory exhaustion.
2010 Don't double-block input; malloc is safe here. Don't assume 2**34
2011 - 4 fits in unsigned long. Add an xassert to check
2012 XGetWindowProperty overflow. Be more careful about overflow
2013 calculations, and distinguish size from memory overflow better.
2014 (receive_incremental_selection): When tracing, don't assume
2015 unsigned int is less than INT_MAX.
2016 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2017 harmful) conversions of unsigned short to int.
2018 (lisp_data_to_selection_data): Don't assume that integers
2019 in the range -65535 through -1 fit in an X unsigned short.
2020 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2021 result parameters unless successful. Rely on cons_to_unsigned
2022 to report problems with elements; the old code wasn't right anyway.
2023 (x_check_property_data): Check for int overflow; we cannot use
2024 a wider type due to X limits.
2025 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2026
726e0ab1 2027 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2028
0065d054
PE
2029 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2030 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2031 (x_color_cells): Don't store size until memory allocation succeeds.
2032 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2033 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2034 (x_term_init): Don't assume length fits in int (sprintf is limited
2035 to int size).
bc18e09d 2036
ebfa62c0
PE
2037 Use ptrdiff_t for composition IDs.
2038 * character.c (lisp_string_width):
2039 * composite.c (composition_table_size, n_compositions)
2040 (get_composition_id, composition_gstring_from_id):
2041 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2042 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2043 * window.c (Frecenter):
2044 Use ptrdiff_t, not int, for composition IDs.
2045 * composite.c (get_composition_id): Check for integer overflow.
2046 * composite.h: Adjust prototypes to match the above changes.
2047
d3411f89
PE
2048 Use ptrdiff_t for hash table indexes.
2049 * category.c (hash_get_category_set):
2050 * ccl.c (ccl_driver):
2051 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2052 * coding.c (coding_system_charset_list, detect_coding_system):
2053 * coding.h (struct coding_system.id):
2054 * composite.c (get_composition_id, gstring_lookup_cache):
2055 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2056 * image.c (xpm_get_color_table_h):
2057 * lisp.h (hash_lookup, hash_put):
2058 * minibuf.c (Ftest_completion):
2059 Use ptrdiff_t for hash table indexes, not int (which is too
2060 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2061 32-bit --with-wide-int hosts).
2062
e097a6fa
PE
2063 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2064 Add a FIXME comment about memory leaks.
2065 (syms_of_charset): Don't assume xmalloc returns.
2066
5637687f
PE
2067 Don't assume that stated character widths fit in int.
2068 * character.c (Fchar_width, c_string_width, lisp_string_width):
2069 * character.h (CHAR_WIDTH):
2070 * indent.c (MULTIBYTE_BYTES_WIDTH):
2071 Use sanitize_char_width to avoid undefined and/or bad behavior
2072 with outlandish widths.
a66cfb1c 2073 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2074 now that we have two such functions. All uses changed.
2075 (sanitize_char_width): New inline function.
2076
a2271ba2
PE
2077 Don't assume that tab-width fits in int.
2078 * character.h (sanitize_width): New inline function.
2079 (SANE_TAB_WIDTH): New macro.
2080 (ASCII_CHAR_WIDTH): Use it.
2081 * indent.c (sane_tab_width): Remove. All uses replaced by
2082 SANE_TAB_WIDTH (current_buffer).
2083 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2084
18c52557
PE
2085 * fileio.c: Integer overflow issues with file modes.
2086 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2087
caeeedc1
PE
2088 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2089 Remove unreachable code.
2090 (read_hex, load_charset_map_from_file): Check for integer overflow.
2091
50849c52
PE
2092 * xterm.c: don't go over XClientMessageEvent limit
2093 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2094 (x_send_scroll_bar_event): Likewise. Check that the size does not
2095 exceed limits imposed by XClientMessageEvent, as well as the usual
2096 ptrdiff_t and size_t limits.
2097
b13995db
PE
2098 * keyboard.c: Overflow, signedness and related fixes.
2099 (make_lispy_movement): Use same integer type in forward decl
2100 that is used in the definition.
2101 (read_key_sequence, keyremap_step):
2102 Change bufsize argument back to int, undoing my 2011-03-30 change.
2103 We prefer signed types, and int is wide enough here.
2104 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2105 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2106 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2107 length, not size_t. Use ptrdiff_t for index, not int.
2108 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2109 possibility of integer overflow.
2110
13464394
PE
2111 Overflow, signedness and related fixes for images.
2112
2113 * dispextern.h (struct it.stack[0].u.image.image_id)
2114 (struct_it.image_id, struct image.id, struct image_cache.size)
2115 (struct image_cache.used, struct image_cache.ref_count):
2116 * gtkutil.c (update_frame_tool_bar):
2117 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2118 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2119 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2120 * nsmenu.m (update_frame_tool_bar):
2121 * xdisp.c (calc_pixel_width_or_height):
2122 * xfns.c (image_cache_refcount):
2123 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2124 on typical 64-bit hosts.
2125
2126 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2127 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2128 Omit unnecessary casts to int.
2129 (parse_image_spec): Check that integers fall into 'int' range
2130 when the callers expect that.
2131 (image_ascent): Redo ascent calculation to avoid int overflow.
2132 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2133 (lookup_image): Remove unnecessary tests.
2134 (xbm_image_p): Locals are now of int, not EMACS_INT,
2135 since parse_image_check makes sure they fit into int.
2136 (png_load, gif_load, svg_load_image):
2137 Prefer int to unsigned where either will do.
2138 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2139 old tiff_error_handler and tiff_warning_handler.
2140 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2141 stack buffer overflows. It uses only the features of vsnprintf
2142 that are common to both POSIX and native Microsoft.
2143 (tiff_error_handler, tiff_warning_handler): Use it.
2144 (tiff_load, gif_load, imagemagick_load_image):
2145 Don't assume :index value fits in 'int'.
2146 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2147 (imagemagick_load_image): Check that crop parameters fit into
2148 the integer types that MagickCropImage accepts. Don't assume
2149 Vimagemagick_render_type has a nonnegative value. Don't assume
2150 size_t fits in 'long'.
2151 (gs_load): Use printmax_t to print the widest integers possible.
2152 Check for integer overflow when computing image height and width.
2153
c11821d4
EZ
21542011-08-26 Eli Zaretskii <eliz@gnu.org>
2155
2156 * xdisp.c (redisplay_window): Don't force window start if point
2157 will be invisible in the resulting window. (Bug#9324)
2158
0c95fcf7
EZ
21592011-08-25 Eli Zaretskii <eliz@gnu.org>
2160
2161 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2162 the display spec is of the form `(space ...)'.
2163 (handle_display_spec): Return the value returned by
2164 handle_single_display_spec, not just 1 or zero.
2165 (handle_single_display_spec): If the display spec is of the form
2166 `(space ...)', and specifies display in the text area, return 2
2167 rather than 1.
fee65a97 2168 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2169 accurately, and prefer exact match for point under bidi.
2170 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2171
2172 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2173 into disp_prop; all users changed.
2174
2175 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2176 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2177 for the text covered by the display property.
2178
e4ed06f1
CY
21792011-08-25 Chong Yidong <cyd@stupidchicken.com>
2180
2181 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2182 Change return value to nil.
2183 (Frecord_buffer): Delete unused function.
2184
f67cdd7f
EZ
21852011-08-24 Eli Zaretskii <eliz@gnu.org>
2186
5980d4c6
EZ
2187 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2188 buffers, return left-to-right.
8610fe8b
EZ
2189 (set_cursor_from_row): Consider candidate row a win if its glyph
2190 represents a newline and point is on that newline. Fixes cursor
2191 positioning on the newline at EOL of R2L text within L2R
2192 paragraph, and vice versa.
2193 (try_cursor_movement): Check continued rows, in addition to
2194 continuation rows. Fixes unwarranted scroll when point enters a
2195 continued line of R2L text within an L2R paragraph, or vice versa.
2196 (cursor_row_p): Consider the case of point being equal to
2197 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2198 from the end of a short line to the beginning of a continued line
2199 of R2L text within L2R paragraph.
2200 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2201 composed characters.
5980d4c6 2202
f67cdd7f
EZ
2203 * bidi.c (bidi_check_type): Use xassert.
2204 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2205 members.
2206
bca633fb
EZ
22072011-08-23 Eli Zaretskii <eliz@gnu.org>
2208
2209 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2210 a character.
2211
4a5885a7
CY
22122011-08-23 Chong Yidong <cyd@stupidchicken.com>
2213
2214 * nsfont.m (ns_otf_to_script): Fix typo.
2215
0902a04e
KH
22162011-08-22 Kenichi Handa <handa@m17n.org>
2217
2218 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2219 extra slot even if the purpose is char-code-property-table.
2220
1a2e6670
EZ
22212011-08-23 Eli Zaretskii <eliz@gnu.org>
2222
8ddde651
EZ
2223 * xdisp.c (redisplay_window): When computing centering_position,
2224 account for the height of the header line. (Bug#8874)
2225
425cc014
EZ
2226 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2227 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2228 candidate is selected by the mouse, and that candidate has a
2229 composed character under the mouse.
2230
1a2e6670
EZ
2231 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2232 coordinates reported by pos-visible-in-window-p for a composed
2233 character in column zero.
2234
8b76d6f8
SM
22352011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2236
2237 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2238
dac347dd
EZ
22392011-08-22 Eli Zaretskii <eliz@gnu.org>
2240
2241 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2242 consider it a hit if to_charpos is anywhere in the range of the
2243 composed buffer positions.
2244
e013fb34
CY
22452011-08-22 Chong Yidong <cyd@stupidchicken.com>
2246
2247 * image.c (gif_load): Don't assume that each subimage has the same
2248 dimensions as the base image. Handle disposal method that is
2249 "undefined" by the gif spec (Bug#9335).
2250
bd1ba3e8
CY
22512011-08-20 Chong Yidong <cyd@stupidchicken.com>
2252
2253 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2254 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2255
54a1215b
EZ
22562011-08-19 Eli Zaretskii <eliz@gnu.org>
2257
823564e5
EZ
2258 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2259 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2260 from an Org mode buffer to a Speedbar frame.
2261
54a1215b
EZ
2262 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2263 a composition, take its buffer position from IT->cmp_it.charpos.
2264 Fixes cursor positioning at the beginning of a line that begins
2265 with a composed character.
2266
9778ebcc
EZ
22672011-08-18 Eli Zaretskii <eliz@gnu.org>
2268
0be6ee06
EZ
2269 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2270 character bidirectional type, use STRONG_L instead. Fixes crashes
2271 in a buffer produced by `describe-categories'.
2272
9778ebcc
EZ
2273 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2274 members before the level stack, so they would be saved and
2275 restored when copying iterator state. Fixes incorrect reordering
2276 around TABs covered by display properties.
2277
156bffbe
AS
22782011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2279
6b02f655 2280 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2281
72ad093b
CY
22822011-08-17 Chong Yidong <cyd@stupidchicken.com>
2283
2284 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2285 (internal_condition_case_2, internal_condition_case_n):
2286 Remove unnecessary aborts (Bug#9081).
72ad093b 2287
35774242
EZ
22882011-08-17 Eli Zaretskii <eliz@gnu.org>
2289
2290 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2291 has no `load' handler, try opening the file locally. (Bug#9311)
2292
db76dd85
KB
22932011-08-16 Ken Brown <kbrown@cornell.edu>
2294
2295 * gmalloc.c: Expand comment.
2296
b215eee5
EZ
22972011-08-16 Eli Zaretskii <eliz@gnu.org>
2298
2299 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2300 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2301
a4579d33
KB
23022011-08-16 Ken Brown <kbrown@cornell.edu>
2303
2304 Fix memory allocation problems in Cygwin build (Bug#9273).
2305
2306 * unexcw.c ( __malloc_initialized): Declare external variable.
2307 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2308
8b76d6f8
SM
2309 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2310 New variables.
a4579d33
KB
2311 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2312 dumped emacs.
2313 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2314 in the static heap.
2315 [CYGWIN] (special_realloc): New function.
2316 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2317 requests to realloc storage in the static heap.
2318
3ebec551
PE
23192011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2320
2321 * bidi.c (bidi_initialize): Remove unused local.
2322
9fd8be00
EZ
23232011-08-15 Eli Zaretskii <eliz@gnu.org>
2324
6b02f655
SM
2325 * bidimirror.h:
2326 * biditype.h: Remove file.
2327 * makefile.w32-in ($(BLD)/bidi.$(O)):
2328 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2329
2330 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2331
2332 * chartab.c: Improve commentary for the uniprop_table API.
2333
32413314
EZ
2334 * bidi.c (bidi_paragraph_init): Support zero value of
2335 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2336 (bidi_initialize): Use uniprop_table instead of including
2337 biditype.h and bidimirror.h.
32413314 2338
9fd8be00
EZ
2339 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2340 coordinates of the iterator when restoring from ppos_it.
2341 (Bug#9296)
2342
5cf2b69b
KH
23432011-08-14 Kenichi Handa <handa@m17n.org>
2344
2345 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2346 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2347
daf17d00
EZ
23482011-08-14 Eli Zaretskii <eliz@gnu.org>
2349
2350 * xdisp.c (move_it_in_display_line_to): Don't invoke
2351 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2352 ppos_it. Fixes vertical cursor motion when line beginning is
2353 covered by an image. (Bug#9296)
2354
08e3161a
JD
23552011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2356
2357 * nsterm.h (ns_run_ascript): Declare.
2358 (NSAPP_DATA2_RUNASSCRIPT): Define.
2359
2360 * nsfns.m (as_script, as_result, as_status): New static variables.
2361 (ns_run_ascript): New function.
5e617bc2 2362 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2363 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2364 the event loop. Get status from as_status (Bug#7276).
2365
2366 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2367 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2368 the event loop (Bug#7276).
2369
a3720aa2
AS
23702011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2371
2372 * gnutls.c (QCgnutls_bootprop_priority)
2373 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2374 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2375 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2376 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2377 (QCgnutls_bootprop_verify_hostname_error)
2378 (QCgnutls_bootprop_callbacks_verify): Rename from
2379 Qgnutls_bootprop_..., all uses changed.
2380
2381 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2382 uses changed.
2383
0a0d27fb
PE
23842011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2385
19d5c50c
PE
2386 * xfaces.c (Qframe_set_background_mode): Now static.
2387 * dispextern.h (Qframe_set_background_mode): Remove decl.
2388
0a0d27fb
PE
2389 * process.c (Fnetwork_interface_info): Declare local only if needed.
2390
377538cb
JD
23912011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2392
2393 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2394 (Fnetwork_interface_list): Allocate in increments of bytes instead
2395 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2396 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2397 sockaddr.
2398 (struct ifflag_def): notrailers is smart on OSX.
2399 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2400 Get hardware address with getifaddrs if available.
2401
08fff70c
EZ
24022011-08-12 Eli Zaretskii <eliz@gnu.org>
2403
2404 * xdisp.c (iterate_out_of_display_property): xassert that
2405 IT->position is set to within IT->object's boundaries. Break from
2406 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2407 when IT->position is set up wrongly due to some bug.
2408 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2409 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2410 entry. Force push_it to save on the stack the current
2411 buffer/string position, to be restored by pop_it. Fix flags in
2412 the iterator structure wrt the object coming from a display
2413 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2414 properties. (Bug#9284)
2415
7be1c708 24162011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2417
7be1c708
CY
2418 * fontset.c (fontset_get_font_group): Add proper type checks.
2419 (Bug#9172)
aac0c6e3 2420
7be1c708 24212011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2422
7be1c708
CY
2423 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2424 and LC_VERSION_MIN_MACOSX.
2425 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2426 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2427
97bb72a6
EZ
24282011-08-08 Eli Zaretskii <eliz@gnu.org>
2429
2430 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2431 no-display-properties-and-no-overlays under bidi display.
2432 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2433 properties and overlays.
97bb72a6 2434
d5617611
CY
24352011-08-08 Chong Yidong <cyd@stupidchicken.com>
2436
37e11a63
CY
2437 * editfns.c (Fset_time_zone_rule): Document relationship with the
2438 setenv function.
2439
d5617611
CY
2440 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2441 the font entity extracted from the cache (Bug#8109).
2442
58872834
CY
24432011-08-07 Chong Yidong <cyd@stupidchicken.com>
2444
2445 * composite.c (autocmp_chars): Don't reset point. That is done by
2446 restore_point_unwind (Bug#5984).
2447
75bfc667
JL
24482011-08-07 Juri Linkov <juri@jurta.org>
2449
2450 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2451 to show the arg `TIME' instead of `TIMEVAL'.
2452
d1410150
EZ
24532011-08-06 Eli Zaretskii <eliz@gnu.org>
2454
2455 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2456 display property strides EOL and includes a newline, as in
2457 longlines-mode. (Bug#9254)
75b771e4
EZ
2458 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2459 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2460
2461 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2462 is non-zero, even if the data buffer is NULL. Fixes a crash in
2463 vertical-motion with longlines-mode. (Bug#9254)
2464
35928349
EZ
24652011-08-05 Eli Zaretskii <eliz@gnu.org>
2466
ec7cc85b
EZ
2467 * bidi.c <bidi_cache_total_alloc>: Now static.
2468 (bidi_initialize): Initialize bidi_cache_total_alloc.
2469
8b76d6f8 2470 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2471 cache. (Bug#9221)
2472
2473 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2474 amount allocated this far in `bidi_cache_total_alloc'.
2475 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2476 non-zero, only free the data buffer without restoring the cache
2477 contents. All callers changed.
2478
2479 * dispextern.h (bidi_unshelve_cache): Update prototype.
2480
2481 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2482 (move_it_in_display_line, move_it_to)
2483 (move_it_vertically_backward, move_it_by_lines): Replace the call
2484 to xfree to an equivalent call to bidi_unshelve_cache.
2485 (move_it_in_display_line_to): Fix logic of returning
412b6358 2486 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2487
e2e2423b
EZ
24882011-08-05 Eli Zaretskii <eliz@gnu.org>
2489
2490 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2491 came from a string character with a `cursor' property. (Bug#9229)
2492
ae9e757a
JD
24932011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2494
2495 * Makefile.in (LIB_PTHREAD): New variable.
2496 (LIBES): Add LIB_PTHREAD (Bug#9216).
2497
2498 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2499 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2500
213bd7f2
AS
25012011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2502
6b02f655 2503 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2504
99aaf75f
JD
25052011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2506
2507 * xterm.c (x_find_topmost_parent): New function.
2508 (x_set_frame_alpha): Find topmost parent window with
2509 x_find_topmost_parent and set the property there also (bug#9181).
2510 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2511
c74e9d86
PE
25122011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2513
2514 * callproc.c (Fcall_process): Avoid vfork clobbering
2515 the local vars buffer, coding_systems, current_dir.
2516
640c8776
SM
25172011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2518
2519 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2520
f26d0e4c
PE
25212011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2522
8a10d76c
PE
2523 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2524 so that it is not optimized away.
2525
f26d0e4c
PE
2526 * xdisp.c (compute_display_string_pos): Remove unused local.
2527
55439c61
EZ
25282011-08-02 Eli Zaretskii <eliz@gnu.org>
2529
2530 Fix slow cursor motion and scrolling in large buffers with
2531 selective display, like Org Mode buffers. (Bug#9218)
2532
2533 * dispextern.h (struct bidi_it): New member disp_prop_p.
2534
2535 * xdisp.c: Remove one-slot cache of display string positions.
2536 (compute_display_string_pos): Accept an additional argument
5e617bc2 2537 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2538 for a display string or property. If found, set DISP_PROP_P
2539 non-zero.
2540
2541 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2542 DISP_PROP_P, and pass it to compute_display_string_pos.
2543 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2544 non-zero. All callers of bidi_fetch_char changed.
2545
fb33fa43
SM
25462011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2547
2548 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2549
b099e063
DM
25502010-12-03 Don March <don@ohspite.net>
2551
2552 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2553 last character M-[char] is translated to ESC [char] (bug#7541).
2554
5cc7f7af
KH
25552011-08-02 Kenichi Handa <handa@m17n.org>
2556
d0fffa3f 2557 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2558
2559 * chartab.c (uniprop_table): Make it non-static.
2560
525d5e6e
EZ
25612011-08-01 Eli Zaretskii <eliz@gnu.org>
2562
2563 * xdisp.c (forward_to_next_line_start): Accept additional argument
2564 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2565 on the newline.
2566 (reseat_at_next_visible_line_start): Use the bidi iterator state
2567 returned by forward_to_next_line_start to restore the state of
2568 it->bidi_it after backing up to previous newline. (Bug#9212)
2569
31011111
AS
25702011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2571
2572 * regex.c (re_comp): Protoize.
2573 (re_exec): Fix return type.
2574 (regexec): Fix type of `ret'. (Bug#9203)
2575
476371c4
PE
25762011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2577
e5d76069
PE
2578 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2579 This is needed if max-image-size is a floating-point number.
2580
9a79b20c
AS
25812011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2582
2583 * print.c (print_object): Print empty symbol as ##.
2584
2585 * lread.c (read1): Read ## as empty symbol.
2586
d8c2fa78
AA
25872011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2588
2589 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2590 setting frame foreground color (Bug#9175).
2591 (x_set_background_color): Likewise.
2592
ffe57a7a
AA
2593 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2594 contents (Bug#9176).
2595 (EmacsTooltip -init): Remove bezels and add shadows to
2596 tooltip windows.
2597
bf3492a5
AA
2598 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2599 or scroll bar (Bug#8470).
2600
d55e9c53
AA
2601 * nsfont.m (nsfont_open): Remove assignment to voffset and
2602 unnecessary vars hshink, expand, hd, full_height, min_height.
2603 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2604
2605 * nsterm.h (nsfont_info): Remove voffset field.
2606
d8c2fa78 26072011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2608
2609 Implement strike-through and overline on NextStep (Bug#8863).
2610
2611 * nsfont.m (nsfont_open): Use underline position provided by font,
2612 instead of hard-coded value of 2.
2613 (nsfont_draw): Call ns_draw_text_decoration instead.
2614
2615 * nsterm.h: Add declaration for ns_draw_text_decoration.
2616
2617 * nsterm.m (ns_draw_text_decoration): New function for drawing
2618 underline, overline, and strike-through.
2619 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2620 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2621 accommodate underlining, etc.
4843aac3 2622
4cc60b9b
EZ
26232011-07-28 Eli Zaretskii <eliz@gnu.org>
2624
bc7ece87
EZ
2625 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2626 default.
4cc60b9b 2627
476371c4
PE
26282011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2629
66606eea
PE
2630 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2631 Without this fix, if a signal arrives just after memory fills up,
2632 'malloc' might be invoked reentrantly.
2633
476371c4
PE
2634 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2635 In other words, assume that every image size is allowed, on non-X
2636 hosts. This assumption is probably wrong, but it lets Emacs compile.
2637
f3fcc40d
AS
26382011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2639
2640 * regex.c (re_iswctype): Convert return values to boolean.
2641
350c992f
EZ
26422011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2643
2644 * xdisp.c (compute_display_string_pos): Don't use cached display
2645 string position if the buffer had its restriction changed.
2646 (Bug#9184)
2647
5266b4bb
PE
26482011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2649
2650 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2651
2573a837 26522011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2653
41f55ccd 2654 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2655
39e378da
PE
2656 * bidi.c: Integer size and overflow fixes.
2657 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2658 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2659 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2660 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2661 (bidi_find_other_level_edge):
2662 Use ptrdiff_t instead of EMACS_INT where either will do.
2663 This works better on 32-bit hosts configured --with-wide-int.
2664 (bidi_cache_ensure_space): Check for size-calculation overflow.
2665 Use % rather than repeated addition, for better worst-case speed.
2666 Don't set bidi_cache_size until after xrealloc returns, because it
2667 might not return.
2668 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2669 (bidi_cache_ensure_space): Also check that the bidi cache size
2670 does not exceed that of the largest Lisp string or buffer. See Eli
2671 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2672
5e927815
PE
2673 * alloc.c (__malloc_size_t): Remove.
2674 All uses replaced by size_t. See Andreas Schwab's note
2675 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2676
ca4aa935
PE
2677 * image.c: Improve checking for integer overflow.
2678 (check_image_size): Assume that f is nonnull, since
2679 it is always nonnull in practice. This is one less thing to
2680 worry about when checking for integer overflow later.
2681 (x_check_image_size): New function, which checks for integer
2682 overflow issues inside X.
2683 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2684 This removes the need for a memory_full check.
2685 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2686 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2687 (xbm_read_bitmap_data): Change locals back to 'int', since
2688 their values must fit in 'int'.
2689 (xpm_load_image, png_load, tiff_load):
2690 Invoke x_create_x_image_and_pixmap earlier,
2691 to avoid much needless work if the image is too large.
2692 (tiff_load): Treat overly large images as if
2693 x_create_x_image_and_pixmap failed, not as malloc failures.
2694 (gs_load): Use x_check_image_size.
2695
5f8f9cc2
PE
2696 * gtkutil.c: Omit integer casts.
2697 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2698 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2699
5adf60bc
PE
2700 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2701
c8907a93
PE
2702 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2703 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2704 would wrongly return t on a 64-bit host.
2705
e3c25c68
PE
2706 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2707 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2708 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2709 and therefore cause GCC to emit a bogus diagnostic in some cases.
2710
3f791afe
PE
2711 * image.c: Integer signedness and overflow and related fixes.
2712 This is not an exhaustive set of fixes, but it's time to
2713 record what I've got.
2714 (lookup_pixel_color, check_image_size): Remove redundant decls.
2715 (check_image_size): Don't assume that arbitrary EMACS_INT values
2716 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2717 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2718 (tiff_load, imagemagick_load_image):
2719 Check for overflow in size calculations.
2720 (x_create_x_image_and_pixmap): Remove unnecessary test for
2721 xmalloc returning NULL; that can't happen.
2722 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2723 (xpm_color_bucket): Use better integer hashing function.
2724 (xpm_cache_color): Don't possibly over-allocate memory.
2725 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2726 (gif_memory_source):
2727 Use ptrdiff_t, not int or size_t, to record sizes.
2728 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2729 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2730 either works, as we prefer signed integers.
2731 (tiff_read_from_memory, tiff_write_from_memory):
2732 Return tsize_t, not size_t, since that's what the TIFF API wants.
2733 (tiff_read_from_memory): Don't fail simply because the read would
2734 go past EOF; instead, return a short read.
2735 (tiff_load): Omit no-longer-needed casts.
2736 (Fimagemagick_types): Don't assume size fits into 'int'.
2737
3cc5a532
PE
2738 Improve hashing quality when configured --with-wide-int.
2739 * fns.c (hash_string): New function, taken from sxhash_string.
2740 Do not discard information about ASCII character case; this
2741 discarding is no longer needed.
2742 (sxhash-string): Use it. Change sig to match it. Caller changed.
2743 * lisp.h: Declare it.
2744 * lread.c (hash_string): Remove, since we now use fns.c's version.
2745 The fns.c version returns a wider integer if --with-wide-int is
2746 specified, so this should help the quality of the hashing a bit.
2747
b312a492
PE
2748 * emacs.c: Integer overflow minor fix.
2749 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2750 Define only if GNU_LINUX.
2751 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2752
dfd153ae
PE
2753 * dispnew.c: Integer signedness and overflow fixes.
2754 Remove unnecessary forward decls, that were a maintenance hassle.
2755 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2756 All uses changed.
2757 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2758 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2759 (prepare_desired_row, line_draw_cost):
2760 Use int, not unsigned, where either works.
2761 (save_current_matrix, restore_current_matrix):
2762 Use ptrdiff_t, not size_t, where either works.
2763 (init_display): Check for overflow more accurately, and without
2764 relying on undefined behavior.
2765
a81d11a3
PE
2766 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2767 Remove, replacing with the new symbols in lisp.h. All uses changed.
2768 * fileio.c (make_temp_name):
2769 * filelock.c (lock_file_1, lock_file):
2770 * xdisp.c (message_dolog):
2771 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2772 Use pMd etc. instead.
2773 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2774 replacing the pWIDE etc. symbols removed from editfns.c.
2775
3300e6fd
PE
2776 * keyboard.h (num_input_events): Now uintmax_t.
2777 This is (very slightly) less likely to mess up due to wraparound.
2778 All uses changed.
2779
fd05c7e9
PE
2780 * buffer.c: Integer signedness fixes.
2781 (alloc_buffer_text, enlarge_buffer_text):
2782 Use ptrdiff_t rather than size_t when either will do, as we prefer
2783 signed integers.
2784
903fe15d
PE
2785 * alloc.c: Integer signedness and overflow fixes.
2786 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2787 (__malloc_size_t): Default to size_t, not to int.
2788 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2789 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2790 Prefer ptrdiff_t to size_t when either would do, as we prefer
2791 signed integers.
2792 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2793 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2794 Now const. Initialize with values that are in range even if char
2795 is signed.
2796 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2797 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2798 These functions do the right thing with sizes > 2**32.
2799 (check_depth): Now ptrdiff_t, not int.
2800 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2801 Adjust to new way of storing sizes. Check for size overflow bugs
2802 in rest of code.
2803 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2804 slightly wrong anyway, as it missed one instance of
2805 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2806 (refill_memory_reserve): Omit needless cast to size_t.
2807 (mark_object_loop_halt): Mark as externally visible.
2808
ac82cc6a
PE
2809 * xselect.c: Integer signedness and overflow fixes.
2810 (Fx_register_dnd_atom, x_handle_dnd_message):
2811 Use ptrdiff_t, not size_t, since we prefer signed.
2812 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2813 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2814 x_dnd_atoms_size and x_dnd_atoms_length.
2815
c2d1e36d
PE
2816 * doprnt.c: Prefer signed to unsigned when either works.
2817 * eval.c (verror):
2818 * doprnt.c (doprnt):
2819 * lisp.h (doprnt):
2820 * xdisp.c (vmessage):
2821 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2822 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2823 prefer signed arithmetic to avoid comparison confusion.
2824 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2825 but is a bit tricky.
2826
0e926e56
PE
2827 Assume freestanding C89 headers, string.h, stdlib.h.
2828 * data.c, doprnt.c, floatfns.c, print.c:
2829 Include float.h unconditionally.
2830 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2831 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2832 * regex.c: Likewise for stddef.h, string.h.
2833 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2834 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2835 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2836 (STDC_HEADERS): Remove obsolete defines.
2837 * sysdep.c: Include limits.h unconditionally.
2838
9cfdb3ec
PE
2839 Assume support for memcmp, memcpy, memmove, memset.
2840 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2841 * regex.c (memcmp, memcpy):
2842 Remove; we assume C89 now.
2843
2844 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2845 (__malloc_safe_bcopy): Remove; no longer needed.
2846
cf950e6b 2847 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2848 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2849 well either way, and we prefer signed to unsigned.
2850
dbf38e02
LMI
28512011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2852
2853 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2854 closes the connection while we're reading (bug#9182).
2855
d6f0886c 28562011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2857
d6f0886c
JD
2858 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2859 are specified (Bug#9168).
24e0f6b1 2860
2eb1f9e6
PE
28612011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2862
2863 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2864 Found by GCC static checking and --with-wide-int on a 32-bit host.
2865
22381272 28662011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2867
2868 * xdisp.c (compute_display_string_pos): Fix logic of caching
2869 previous display string position. Initialize cached_prev_pos to
2870 -1. Fixes slow-down at the beginning of a buffer.
2871
f25e39b4
EZ
28722011-07-24 Eli Zaretskii <eliz@gnu.org>
2873
2874 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2875 for attrs[LFACE_FONTSET_INDEX].
2876
04c4b52e
PE
28772011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2878
2879 * xml.c (parse_region): Remove unused local
2880 that was recently introduced.
2881
c1734fbd
EZ
28822011-07-23 Eli Zaretskii <eliz@gnu.org>
2883
be18c5a5
EZ
2884 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2885 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2886
c1734fbd
EZ
2887 * xdisp.c (move_it_in_display_line_to): Record the best matching
2888 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2889 exit if none of the characters scanned was an exact match.
2890 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2891 when exact match is impossible due to invisible text, and the
2892 lines are truncated.
2893
a258d627
JD
28942011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2895
2896 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2897 for OSX >= 10.7.
2898
b6d5a689
EZ
28992011-07-22 Eli Zaretskii <eliz@gnu.org>
2900
0f74f785
EZ
2901 Fix a significant slow-down of cursor motion with C-n, C-p,
2902 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2903 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2904 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2905 (next_element_from_buffer): Call compute_stop_pos_backwards to
2906 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2907 base_level_stop.
2908 (reseat): Don't look for prev_stop, as that could mean a very long
2909 run.
2910 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2911 <cached_disp_overlay_modiff>: Cache for last found display string
2912 position.
551918c1 2913 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2914 about the same buffer in the same area of character positions, and
2915 the buffer wasn't changed since the time the display string
2916 position was cached.
551918c1 2917
b2d0c91a
EZ
29182011-07-22 Eli Zaretskii <eliz@gnu.org>
2919
2920 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2921 is an integer, which is important for empty lines. (Bug#9149)
2922
043604ee
CY
29232011-07-22 Chong Yidong <cyd@stupidchicken.com>
2924
2925 * frame.c (Fmodify_frame_parameters): In tty case, update the
2926 default face if necessary (Bug#4238).
2927
da4adb04
CY
29282011-07-21 Chong Yidong <cyd@stupidchicken.com>
2929
2930 * editfns.c (Fstring_to_char): No need to explain what a character
2931 is in the docstring (Bug#6576).
2932
9abd0532
LMI
29332011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2934
2935 * xml.c (parse_region): Make sure we always return a tree.
2936
36881d16
HK
29372011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2938
2939 * xml.c (parse_region): If a document contains only comments,
2940 return that, too.
2941
1e98674d
LMI
29422011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2943
2944 * xml.c (make_dom): Return comments, too.
2945
590bd467
PE
29462011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2947
2948 Port to OpenBSD.
2949 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2950 and the surrounding thread.
2951 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2952 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2953 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2954 timer goes off.
2955 * s/openbsd.h (BROKEN_SIGIO): Define.
2956 * unexelf.c (unexec) [__OpenBSD__]:
2957 Don't update the .mdebug section of the Alpha COFF symbol table.
2958
f41628b2
LMI
29592011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2960
2961 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2962 (bug#8460).
2963
b59b67c5
PE
29642011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2965
15e3a074
PE
2966 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2967 This fixes some race conditions on the permissions of any newly
2968 created file.
2969
41bed37d
PE
2970 * alloc.c (valid_pointer_p): Use pipe, not open.
2971 This fixes some permissions issues when debugging.
2972
b59b67c5
PE
2973 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2974 If fchown fails to set both uid and gid, try to set just gid,
2975 as that is sometimes allowed. Adjust the file's mode to eliminate
2976 setuid or setgid bits that are inappropriate if fchown fails.
2977
925a6be7
SM
29782011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2979
2980 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2981 to compare Lisp_Objects.
2982 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2983 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2984 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2985
52968808
AS
29862011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2987
0a6a104b
AS
2988 * lread.c (read_integer): Unread even EOF character.
2989 (read1): Likewise. Properly record start position of symbol.
2990
52968808
AS
2991 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2992 symbol character follows.
2993
9e381cdd
PE
29942011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2995
2996 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2997 This works around a problem with the previous change to Fcopy_file.
2998 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2999 and without this change, GCC might complain about discarding
3000 fchown's return value.
3001
b5641435
JB
30022011-07-16 Juanma Barranquero <lekktu@gmail.com>
3003
3004 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3005
a8031457
PE
30062011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3007
3008 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3009
dd889327
LMI
30102011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3011
750c33f7
LMI
3012 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3013 it's used from the C level.
3014
dd889327
LMI
3015 * process.c: Use the same condition for POLL_FOR_INPUT in both
3016 keyboard.c and process.c (bug#1858).
3017
87e86684
LM
30182011-07-09 Lawrence Mitchell <wence@gmx.li>
3019
3020 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3021 (Fgnutls_boot): Use it.
3022
64348f40
AS
30232011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3024
3025 * doc.c (Fsubstitute_command_keys): Revert last change.
3026
1d698799
LMI
30272011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3028
f863868c
LMI
3029 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3030 quotes the next character, and doesn't affect other longer
3031 sequences (bug#8935).
3032
1d698799
LMI
3033 * lread.c (syms_of_lread): Clarify that is isn't only
3034 `eval-buffer' and `eval-defun' that's affected by
3035 `lexical-binding' (bug#8460).
3036
aa4b6df6
EZ
30372011-07-15 Eli Zaretskii <eliz@gnu.org>
3038
3039 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3040 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3041
5d856da6
PE
30422011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3043
ad6042bb
PE
3044 Fix minor problems found by static checking.
3045 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3046 (elsz): Now a signed constant, not a size_t var. We prefer signed
3047 types to unsigned, to avoid integer comparison confusion. Without
3048 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3049 "cannot optimize loop, the loop counter may overflow", a symptom
3050 of the confusion.
f00bbb22 3051 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3052 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3053
6468f31c
LMI
30542011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3055
49080b10
LMI
3056 * search.c (Fre_search_backward): Mention `case-fold-search' in
3057 all the re_search_* functions (bug#8138).
3058
6468f31c
LMI
3059 * keyboard.c (Fopen_dribble_file): Document when the file is
3060 closed (bug#8056).
3061
c965adc5
EZ
30622011-07-14 Eli Zaretskii <eliz@gnu.org>
3063
df9733bf
EZ
3064 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3065 bidi_cache_idx.
3066
0bb23927
EZ
3067 Support bidi reordering of display and overlay strings.
3068 * xdisp.c (compute_display_string_pos)
3069 (compute_display_string_end): Accept additional argument STRING.
3070 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3071 (reseat_to_string): Initialize bidi_it->string.s and
3072 bidi_it->string.schars.
3073 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3074 NULL (avoids a crash in bidi_paragraph_init).
3075 Initialize itb.string.lstring.
0bb23927
EZ
3076 (init_iterator): Call bidi_init_it only of a valid
3077 buffer position was specified. Initialize paragraph_embedding to
3078 L2R.
3079 (reseat_to_string): Initialize the bidi iterator.
3080 (display_string): If we need to ignore text properties of
3081 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3082 original value of -1 will not work with bidi.)
3083 (compute_display_string_pos): First arg is now struct
3084 `text_pos *'; all callers changed. Support display properties on
3085 Lisp strings.
3086 (compute_display_string_end): Support display properties on Lisp
3087 strings.
3088 (init_iterator, reseat_1, reseat_to_string): Initialize the
3089 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3090 when iterating on a string not from display properties).
640c8776
SM
3091 (compute_display_string_pos, compute_display_string_end):
3092 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3093 arrow keys.
3094 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3095 base_level_stop; instead, set base_level_stop to BEGV.
3096 Fixes crashes in vertical-motion.
0bb23927
EZ
3097 (next_element_from_buffer): Improve commentary for when
3098 the iterator is before prev_stop.
3099 (init_iterator): Initialize bidi_p from the default value of
3100 bidi-display-reordering, not from buffer-local value. Use the
3101 buffer-local value only if initializing for buffer iteration.
3102 (handle_invisible_prop): Support invisible properties on strings
3103 that are being bidi-reordered.
3104 (set_iterator_to_next): Support bidi reordering of C strings and
3105 Lisp strings.
3106 (next_element_from_string): Support bidi reordering of Lisp
3107 strings.
3108 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3109 (display_string): Support display of R2L glyph rows.
3110 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3111 (init_iterator): Don't initialize it->bidi_p for strings
3112 here.
3113 (reseat_to_string): Initialize it->bidi_p for strings here.
3114 (next_element_from_string, next_element_from_c_string)
3115 (next_element_from_buffer): Add xassert's for correspondence
3116 between IT's object being iterated and it->bidi_it.string
3117 structure.
3118 (face_before_or_after_it_pos): Support bidi iteration.
3119 (next_element_from_c_string): Handle the case of the first string
3120 character that is not the first one in the visual order.
3121 (get_visually_first_element): New function, refactored from common
3122 parts of next_element_from_buffer, next_element_from_string, and
3123 next_element_from_c_string.
3124 (tool_bar_lines_needed, redisplay_tool_bar)
3125 (display_menu_bar): Force left-to-right direction. Add a FIXME
3126 comment for making that be controlled by a user option.
3127 (push_it, pop_it): Save and restore the state of the
3128 bidi iterator. Save and restore the bidi_p flag.
3129 (pop_it): Iterate out of display property for string iteration as
3130 well.
3131 (iterate_out_of_display_property): Support iteration over strings.
3132 (handle_single_display_spec): Set up it->bidi_it for iteration
3133 over a display string, and call bidi_init_it.
3134 (handle_single_display_spec, next_overlay_string)
3135 (get_overlay_strings_1, push_display_prop): Set up the bidi
3136 iterator for displaying display or overlay strings.
3137 (forward_to_next_line_start): Don't use the shortcut if
3138 bidi-iterating.
3139 (back_to_previous_visible_line_start): If handle_display_prop
3140 pushed the iterator stack, restore the internal state of the bidi
3141 iterator by calling bidi_pop_it same number of times.
3142 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3143 and we are bidi-iterating, don't decrement the iterator position;
3144 instead, set the first_elt flag in the bidi iterator, to produce
3145 the same effect.
3146 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3147 (push_display_prop): xassert that we are iterating a buffer.
3148 (push_it, pop_it): Save and restore paragraph_embedding member.
3149 (handle_single_display_spec, next_overlay_string)
3150 (get_overlay_strings_1, reseat_1, reseat_to_string)
3151 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3152 correctly. Don't assume unibyte strings are not bidi-reordered.
3153 (compute_display_string_pos)
3154 (compute_display_string_end): Fix handling the case of C string.
3155 (push_it, pop_it): Save and restore from_disp_prop_p.
3156 (handle_single_display_spec, push_display_prop): Set the
3157 from_disp_prop_p flag.
3158 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3159 (pop_it): Call iterate_out_of_display_property only if we are
3160 popping after iteration over a string that came from a display
3161 property. Fix a typo in popping stretch info. Add an assertion
3162 for verifying that the iterator position is in sync with the bidi
3163 iterator.
3164 (handle_single_display_spec, get_overlay_strings_1)
3165 (push_display_prop): Fix initialization of paragraph direction for
3166 string when that of the parent object is not yet determined.
3167 (reseat_1): Call bidi_init_it to resync the bidi
3168 iterator with IT's position. (Bug#7616)
3169 (find_row_edges): If ROW->start.pos gives position
3170 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3171 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3172 Reset the from_disp_prop_p flag.
3173 (SAVE_IT, RESTORE_IT): New macros.
3174 (pos_visible_p, face_before_or_after_it_pos)
3175 (back_to_previous_visible_line_start)
3176 (move_it_in_display_line_to, move_it_in_display_line)
3177 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3178 (try_scrolling, redisplay_window, display_line): Use them when
3179 saving a temporary copy of the iterator and restoring it back.
3180 (back_to_previous_visible_line_start, reseat_1)
3181 (init_iterator): Empty the bidi cache "stack".
3182 (move_it_in_display_line_to): If iterator ended up at
3183 EOL, but we never saw any buffer positions smaller than
3184 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3185 motion in bidi-reordered lines.
3186 (move_it_in_display_line_to): Record prev_method and prev_pos
3187 immediately before the call to set_iterator_to_next. Fixes cursor
3188 motion in bidi-reordered lines with stretch glyphs and strings
3189 displayed in margins. (Bug#8133) (Bug#8867)
3190 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3191 TO_CHARPOS.
640c8776
SM
3192 (pos_visible_p): Support positions in bidi-reordered lines.
3193 Save and restore bidi cache.
0bb23927
EZ
3194
3195 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3196 (bidi_paragraph_info): Delete unused struct.
3197 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3198 (bidi_cache_start): New variable.
3199 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3200 to zero.
3201 (bidi_cache_fetch_state, bidi_cache_search)
3202 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3203 (bidi_cache_find, bidi_peek_at_next_level)
3204 (bidi_level_of_next_char, bidi_find_other_level_edge)
3205 (bidi_move_to_visually_next): Compare cache index with
3206 bidi_cache_start rather than with zero.
3207 (bidi_fetch_char): Accept new argument STRING; all callers
3208 changed. Support iteration over a string. Support strings with
3209 display properties. Support unibyte strings. Fix the type of
3210 `len' according to what STRING_CHAR_AND_LENGTH expects.
3211 (bidi_paragraph_init, bidi_resolve_explicit_1)
3212 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3213 (bidi_level_of_next_char, bidi_move_to_visually_next):
3214 Support iteration over a string.
0bb23927
EZ
3215 (bidi_set_sor_type, bidi_resolve_explicit_1)
3216 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3217 can now be zero (for strings); special values 0 and -1 were
3218 changed to -1 and -2, respectively.
3219 (bidi_char_at_pos): New function.
3220 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3221 Call it instead of FETCH_MULTIBYTE_CHAR.
3222 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3223 initialized to valid values.
3224 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3225 values.
3226 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3227 the test for valid cached positions. Fix the logic for looking up
3228 the sentinel state in the cache. GCPRO the Lisp string we are
3229 iterating.
3230 (bidi_push_it, bidi_pop_it): New functions.
3231 (bidi_initialize): Initialize the bidi cache start stack pointer.
3232 (bidi_cache_ensure_space): New function, refactored from part of
3233 bidi_cache_iterator_state. Don't assume the required size is just
3234 one BIDI_CACHE_CHUNK away.
3235 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3236 (bidi_count_bytes, bidi_char_at_pos): New functions.
3237 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3238 always valid if bidi_cache_idx is valid.
3239 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3240 is valid if it's going to be used.
3241 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3242 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3243 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3244 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3245 (bidi_find_other_level_edge, bidi_cache_start_stack):
3246 All variables related to cache indices are now EMACS_INT.
c965adc5 3247
0bb23927
EZ
3248 * dispextern.h (struct bidi_string_data): New structure.
3249 (struct bidi_it): New member `string'. Make flag members be 1-bit
3250 fields, and put them last in the struct.
640c8776
SM
3251 (compute_display_string_pos, compute_display_string_end):
3252 Update prototypes.
0bb23927
EZ
3253 (bidi_push_it, bidi_pop_it): Add prototypes.
3254 (struct iterator_stack_entry): New members bidi_p,
3255 paragraph_embedding, and from_disp_prop_p.
3256 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3257 (bidi_shelve_cache, bidi_unshelve_cache):
3258 Declare prototypes.
0bb23927
EZ
3259
3260 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3261 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3262 and vector-like objects.
3263
3264 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3265 cache around display iteration.
3266
3267 * window.c (Fwindow_end, window_scroll_pixel_based)
3268 (displayed_window_lines, Frecenter): Save and restore the bidi
3269 cache around display iteration.
3270
3bbd2265
LMI
32712011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3272
3273 * editfns.c (Fdelete_region): Clarify the use of the named
3274 parameters (bug#6788).
3275
adc47434
MR
32762011-07-14 Martin Rudalics <rudalics@gmx.at>
3277
3278 * indent.c (Fvertical_motion): Set and restore w->pointm when
3279 saving and restoring the window's buffer (Bug#9006).
3280
837c31f8
LMI
32812011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3282
3283 * editfns.c (Fstring_to_char): Clarify just what is returned
3284 (bug#6576). Text by Eli Zaretskii.
3285
ac389d0c
JB
32862011-07-13 Juanma Barranquero <lekktu@gmail.com>
3287
3288 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3289
0be0ce47
EZ
32902011-07-13 Eli Zaretskii <eliz@gnu.org>
3291
3292 * buffer.c (mmap_find): Fix a typo.
3293
cd18e7e3
JB
32942011-07-13 Johan Bockgård <bojohan@gnu.org>
3295
3296 Fix execution of x selection hooks.
3297 * xselect.c (Qx_lost_selection_functions)
3298 (Qx_sent_selection_functions): New vars.
3299 (syms_of_xselect): DEFSYM them.
3300 (x_handle_selection_request): Pass Qx_sent_selection_functions
3301 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3302 (x_handle_selection_clear,x_clear_frame_selections):
3303 Pass Qx_lost_selection_functions rather than
3304 Vx_lost_selection_functions to Frun_hook_with_args.
3305
47ea7f44
PE
33062011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3307
ac389d0c 3308 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3309 The old code sometimes used this field without initializing it.
3310
47ea7f44
PE
3311 * alloc.c (gc_sweep): Don't read past end of array.
3312 In theory, the old code could also have corrupted Emacs internals,
3313 though it'd be very unlikely.
3314
bc985c87
AS
33152011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3316
3317 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3318 argument. (Bug#4026)
bc985c87 3319
0cf34688
LMI
33202011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3321
b3dadd76
LMI
3322 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3323 key" (bug#4257).
3324
0cf34688
LMI
3325 * window.c (Fset_window_start): Doc fix (bug#4199).
3326 (Fset_window_hscroll): Ditto.
3327
270768cd
PE
33282011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3329
077e3dda 3330 Fix minor new problems caught by GCC 4.6.1.
270768cd 3331 * term.c (init_tty): Remove unused local.
490011a6 3332 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3333 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3334 not used otherwise.
270768cd 3335
b1f58454
CY
33362011-07-12 Chong Yidong <cyd@stupidchicken.com>
3337
3338 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3339
22b9578d
LMI
33402011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3341
6e70ab07
LMI
3342 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3343 are the mini-buffer and the echo area (bug#3320).
3344
22b9578d
LMI
3345 * term.c (init_tty): Remove support for supdup, c10 and perq
3346 terminals, which are no longer supported (bug#1482).
3347
8974cc9f
JB
33482011-07-10 Johan Bockgård <bojohan@gnu.org>
3349
3350 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3351
a560d974
JD
33522011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3353
3354 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3355 for non-popups (Bug#3642).
3356
1dae0f0a
AS
33572011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3358
268c2c36 3359 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3360 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3361 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3362 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3363 * data.c (fmod): Likewise.
3364 * dispnew.c (swap_glyphs_in_rows): Likewise.
3365 * emacs.c (memory_warning_signal): Likewise.
3366 * floatfns.c (float_error): Likewise.
3367 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3368 (otf_open, font_otf_capability, generate_otf_features)
3369 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3370 Likewise.
3371 * image.c (pbm_read_file): Likewise.
3372 * indent.c (string_display_width): Likewise.
3373 * intervals.c (check_for_interval, search_for_interval)
3374 (inc_interval_count, count_intervals, root_interval)
3375 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3376 * lread.c (defalias): Likewise.
268c2c36 3377 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3378 * regex.c (set_image_of_range_1, set_image_of_range)
3379 (regex_grow_registers): Likewise.
3380 * sysdep.c (strerror): Likewise.
3381 * termcap.c (valid_filename_p, tprint, main): Likewise.
3382 * tparam.c (main): Likewise.
3383 * unexhp9k800.c (run_time_remap, save_data_space)
3384 (update_file_ptrs, read_header, write_header, calculate_checksum)
3385 (copy_file, copy_rest, display_header): Likewise.
3386 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3387 Likewise.
3388 * xdisp.c (check_it): Likewise.
3389 * xfaces.c (register_color, unregister_color, unregister_colors):
3390 Likewise.
3391 * xfns.c (print_fontset_result): Likewise.
3392 * xrdb.c (member, fatal, main): Likewise.
3393
99033785
PE
33942011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3395
3396 Fix minor problems found by static checking (Bug#9031).
3397 * chartab.c (char_table_set_range, map_sub_char_table):
3398 Remove unused locals.
3399 (uniprop_table): Now static.
3400 * composite.c (_work_char): Remove unused static var.
3401
9cb2ac56
JB
34022011-07-09 Juanma Barranquero <lekktu@gmail.com>
3403
3404 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3405
f25661f0
JD
34062011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3407
3408 * gtkutil.c (qttip_cb): Remove code without function.
3409
8278c4fe
EZ
34102011-07-09 Eli Zaretskii <eliz@gnu.org>
3411
3412 * w32.c (pthread_sigmask): New stub.
3413
1692ae2d 34142011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3415
8a6ebd58 3416 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3417 sigprocmask is portable only for single-threaded applications, and
3418 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3419 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3420 (LIBES): Use it.
3421 * callproc.c (Fcall_process):
3422 * process.c (create_process):
3423 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3424 Use pthread_sigmask, not sigprocmask.
123403e4 3425
1b854618
JD
34262011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3427
3428 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3429 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3430 wrong (Bug#8591).
3431
3fe4b549
JD
34322011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3433
0ce7e563
JD
3434 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3435 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3436 (xg_hide_tooltip): Fix comment.
3437
3fe4b549
JD
3438 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3439 in registerServicesMenuSendTypes.
3440 (validRequestorForSendType): Don't check ns_return_types.
3441
3442 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3443 ns_return_type.
3444
5df75e47
JR
34452011-07-08 Jason Rumney <jasonr@gnu.org>
3446
22610910
JR
3447 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3448 SH_SHOW for hidden windows (Bug#5482).
3449
5df75e47
JR
3450 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3451 frame struct members of non-existent frames (Bug#6284).
3452
699c10bd
JD
34532011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3454
4393663b
JD
3455 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3456 variable firstTime not needed on OSX >= 10.6.
3457 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3458 >= 10.5. Use setKnobProportion, setDoubleValue.
3459
3460 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3461 (MAC_OS_X_VERSION_10_5): Define if not defined.
3462 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3463 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3464 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3465
3466 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3467 cString and lossyCString on OSX >= 10.4
3468
58179cce 3469 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3470 sizeToFit on OSX >= 10.2.
3471
3472 * nsimage.m (allocInitFromFile): Don't use deprecated method
3473 bestRepresentationForDevice on OSX >= 10.6.
3474
3475 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3476 to avoid warning.
3477
3478 * emacs.c: Declare unexec_init_emacs_zone.
3479
a63e0781
JD
3480 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3481
699c10bd
JD
3482 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3483
3484 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3485 on svcsMenu (Bug#8842).
3486
3487 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3488 ns_return_types.
3489 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3490
3491 * nsterm.m (QUTF8_STRING): Declare.
3492 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3493 (validRequestorForSendType): Return type is (id).
3494 Change indexOfObjectIdenticalTo to indexOfObject.
3495 Check if we have local selection before returning self (Bug#8842).
3496 (writeSelectionToPasteboard): Put local selection into paste board
3497 if we have a local selection (Bug#8842).
3498 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3499
3500 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3501 (ns_get_local_selection): Declare.
3502
54e10184
LMI
35032011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3504
9888ff71
LMI
3505 * keymap.c (describe_map_tree): Don't insert a double newline at
3506 the end of the buffer (bug#1169) and return whether we inserted
3507 something.
3508
54e10184
LMI
3509 * callint.c (Fcall_interactively): Change "reading args" to
3510 "providing args" to try to clarify what it does (bug#1010).
3511
15fa4783
KH
35122011-07-07 Kenichi Handa <handa@m17n.org>
3513
3514 * composite.c (composition_compute_stop_pos): Ignore a static
3515 composition starting before CHARPOS (Bug#8915).
3516
3517 * xdisp.c (handle_composition_prop): Likewise.
3518
a8815b00
EZ
35192011-07-07 Eli Zaretskii <eliz@gnu.org>
3520
3521 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3522 (Bug#9015)
3523
ef7b981d 35242011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3525
3526 * character.h (unicode_category_t): New enum type.
3527
3528 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3529 (Qchar_code_property_table): New variable.
3530 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3531 (UNIPROP_COMPRESSED_FORM_P): New macros.
3532 (char_table_ascii): Uncompress the compressed values.
3533 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3534 Uncompress the compressed values.
ac389d0c 3535 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3536 (char_table_ref_and_range): Uncompress the compressed values.
3537 (sub_char_table_set): New arg is_uniprop. Callers changed.
3538 Uncompress the compressed values.
3539 (sub_char_table_set_range): Args changed. Callers changed.
3540 (char_table_set_range): Adjuted for the above change.
3541 (map_sub_char_table): Delete args default_val and parent. Add arg
3542 top. Give decoded values to a Lisp function.
640c8776 3543 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3544 values to a Lisp function. Gcpro more variables.
3545 (uniprop_table_uncompress)
3546 (uniprop_decode_value_run_length): New functions.
3547 (uniprop_decoder, uniprop_decoder_count): New variables.
3548 (uniprop_get_decoder, uniprop_encode_value_character)
3549 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3550 New functions.
3551 (uniprop_encoder, uniprop_encoder_count): New variables.
3552 (uniprop_get_encoder, uniprop_table)
3553 (Funicode_property_table_internal, Fget_unicode_property_internal)
3554 (Fput_unicode_property_internal): New functions.
3555 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3556 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3557 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3558 char-code-property-alist.
3559
640c8776 3560 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3561 Vunicode_category_table.
3562
640c8776 3563 * font.c (font_range): Adjust for the change of
c805dec0
KH
3564 Vunicode_category_table.
3565
76b397fb
DN
35662011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3567
3568 * m/iris4d.h: Remove file, move contents ...
3569 * s/irix6-5.h: ... here.
3570
22b4128e
PE
35712011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3572
3573 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3574 * alloc.c (mark_buffer):
3575 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3576 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3577 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3578 This isn't true in general, and it's particularly not true
3579 if Emacs is configured with --with-wide-int.
3580 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3581 New macros, used in the buffer.c change.
3582
869795d6
JD
35832011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3584
3585 * xsettings.c: Use both GConf and GSettings if both are available.
3586 (store_config_changed_event): Add comment.
3587 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3588 (store_tool_bar_style_changed): New functions.
5e617bc2 3589 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3590 (struct xsettings): Move font inside HAVE_XFT.
3591 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3592 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3593 Move inside HAVE_XFT.
640c8776 3594 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3595 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3596 also.
3597 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3598 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3599 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3600 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3601 (parse_settings): Move check for font inside HAVE_XFT.
3602 (read_settings, apply_xft_settings): Add comment.
3603 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3604 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3605 call store_font_name_changed.
3606 (xft_settings_event): Add comment.
3607 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3608 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3609 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3610 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3611 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3612 (xsettings_get_system_font, xsettings_get_system_normal_font):
3613 Add comment.
869795d6 3614
d8ed26bd
PE
36152011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3616
3617 Random fixes. E.g., (random) never returned negative values.
3618 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3619 subseconds part to the entropy, as that's a bit more random.
3620 Prefer signed to unsigned, since the signedness doesn't matter and
3621 in general we prefer signed. When given a limit, use a
3622 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3623 latter isn't right if USE_2_TAGS_FOR_INTS.
3624 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3625 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3626
cabf1cac
SM
36272011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3628
3629 * textprop.c (text_property_stickiness):
3630 Obey Vtext_property_default_nonsticky.
3631 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3632 * w32fns.c (syms_of_w32fns):
3633 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3634
6e9b2be9
PE
36352011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3636
3637 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3638 This is more efficient than Ffile_directory_p and avoids a minor race.
3639
90186c68
LMI
36402011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3641
7c301272
LMI
3642 * buffer.c (Foverlay_put): Say what the return value is
3643 (bug#7835).
3644
c4f2d8d4
LMI
3645 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3646 is a directory before asking whether to use the file name
3647 (bug#7564).
ad637907
LMI
3648 (barf_or_query_if_file_exists): Make the "File is a directory"
3649 error be more correct.
c4f2d8d4 3650
90186c68
LMI
3651 * fns.c (Frequire): Remove the mention of the .gz files, since
3652 that's installation-specific, but keep the mention of
3653 `get-load-suffixes'.
3654
da64016e
PE
36552011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3656
3657 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3658 Report string overflow if the output is too long.
3659
7d47b580
JB
36602011-07-04 Juanma Barranquero <lekktu@gmail.com>
3661
a555cb87
JB
3662 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3663 (syms_of_gnutls): Remove duplicate DEFSYM for
3664 Qgnutls_bootprop_verify_hostname_error, an error for
3665 Qgnutls_bootprop_verify_error (which is no longer used).
3666
7d47b580
JB
3667 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3668 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3669 Also (re)move comments that are misplaced or no longer relevant.
3670
1e49bfab
LMI
36712011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3672
3673 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3674
1485f4c0
CY
36752011-07-03 Chong Yidong <cyd@stupidchicken.com>
3676
3677 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3678 and background color parameters if they have been changed.
3679
a9ab721e
LMI
36802011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3681
3682 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3683
cf7cff57
PE
36842011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3685
2e13213d
PE
3686 * xsettings.c (SYSTEM_FONT): Define only when used.
3687 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3688
cf7cff57
PE
3689 * keymap.c (access_keymap_1): Now static.
3690
7a8e04f7
CY
36912011-07-02 Chong Yidong <cyd@stupidchicken.com>
3692
3693 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3694 leave any prefix arg for the up event (Bug#1586).
3695
61352f62
LMI
36962011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3697
69bb1ef7
LMI
3698 * lread.c (syms_of_lread): Mention single symbols defined by
3699 `defvar' or `defconst' (bug#7154).
3700
61352f62 3701 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3702 (Frequire): Mention get-load-suffixes.
61352f62 3703
28545e04
MR
37042011-07-02 Martin Rudalics <rudalics@gmx.at>
3705
3706 * window.h (window): Remove clone_number slot.
3707 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3708 Remove.
3709 (make_parent_window, make_window, saved_window)
3710 (Fset_window_configuration, save_window_save): Don't deal with
3711 clone numbers.
3712 * buffer.c (Qclone_number): Remove declaration.
3713 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3714
3349e122
SM
37152011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3716
3717 Add multiple inheritance to keymaps.
3718 * keymap.c (Fmake_composed_keymap): New function.
3719 (Fset_keymap_parent): Simplify.
3720 (fix_submap_inheritance): Remove.
3721 (access_keymap_1): New function extracted from access_keymap to handle
3722 embedded parents and handle lists of maps.
3723 (access_keymap): Use it.
3724 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3725 (Fcopy_keymap): Handle embedded parents.
3726 (Fcommand_remapping, define_as_prefix): Simplify.
3727 (Fkey_binding): Simplify.
3728 (syms_of_keymap): Move minibuffer-local-completion-map,
3729 minibuffer-local-filename-completion-map,
3730 minibuffer-local-must-match-map, and
3731 minibuffer-local-filename-must-match-map to Elisp.
3732 (syms_of_keymap): Defsubr make-composed-keymap.
3733 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3734 (parse_menu_item): Trivial simplification.
3735
3279eb87
GM
37362011-07-01 Glenn Morris <rgm@gnu.org>
3737
3738 * Makefile.in (SETTINGS_LIBS): Fix typo.
3739
4550efdf
KI
37402011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3741
3742 * coding.c (Fencode_coding_string): Record the last coding system
3743 used, as the function doc string says (bug#8738).
3744
0949d2b6
JD
37452011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3746
3747 * xsettings.c (store_monospaced_changed): Take new font as arg and
3748 check for change against current_mono_font.
3749 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3750 (emacs_settings_constructor, emacs_settings_get_property)
3751 (emacs_settings_set_property, emacs_settings_class_init)
3752 (emacs_settings_init, gsettings_obj): Remove.
3753 (something_changedCB): New function for HAVE_GSETTINGS.
3754 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3755 with value as argument.
3756 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3757 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3758 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3759 "changed".
3760
3761 * xgselect.c: Add defined (HAVE_GSETTINGS).
3762 (xgselect_initialize): Ditto.
3763
3764 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3765 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3766 xg_select.
3767
bbc6b304
PE
37682011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3769
3770 * eval.c (struct backtrace): Simplify and port the data structure.
3771 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3772 signed bit field, as this assumption is not portable and it makes
3773 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3774 "char debug_on_exit : 1" as this is not portable either; instead,
3775 use the portable "unsigned int debug_on_exit : 1". Remove unused
3776 member evalargs. Remove obsolete comments about cc bombing out.
3777
9851bfc5
JD
37782011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3779
51bb811f 3780 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3781 Let HAVE_GSETTINGS override HAVE_GCONF.
3782 (store_monospaced_changed): New function.
3783 (EMACS_SETTINGS): A new type derived from GObject to handle
3784 GSettings notifications.
3785 (emacs_settings_constructor, emacs_settings_get_property)
3786 (emacs_settings_set_property, emacs_settings_class_init):
3787 New functions.
3788 (gsettings_client, gsettings_obj): New variables.
3789 (GSETTINGS_SCHEMA): New define.
3790 (something_changedCB): Call store_monospaced_changed.
3791 (init_gsettings): New function.
3792 (xsettings_initialize): Call init_gsettings.
3793 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3794 to NULL.
3795
640c8776 3796 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3797 GCONF_CFLAGS/LIBS.
3798
5386012d
MR
37992011-06-29 Martin Rudalics <rudalics@gmx.at>
3800
3801 * window.c (resize_root_window, grow_mini_window)
3802 (shrink_mini_window): Rename Qresize_root_window to
3803 Qwindow_resize_root_window and Qresize_root_window_vertically to
3804 Qwindow_resize_root_window_vertically.
3805
f13e0b08
PE
38062011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3807
3808 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3809
94515237
JB
38102011-06-27 Juanma Barranquero <lekktu@gmail.com>
3811
3812 * makefile.w32-in: Redesign dependencies so they reflect more
3813 clearly which files are directly included by each source file,
3814 and not through other includes.
3815
e43b6e43
MR
38162011-06-27 Martin Rudalics <rudalics@gmx.at>
3817
3818 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3819 (sort_overlays, overlay_strings): When an overlay's clone number
3820 matches the window's clone number process the overlay even if
3821 the overlay's window property doesn't match the current window.
3822
d68443dc
MR
3823 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3824 (Fwindow_hchild): Rename to Fwindow_left_child.
3825 (Fwindow_next): Rename to Fwindow_next_sibling.
3826 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3827 (resize_window_check): Rename to window_resize_check.
3828 (resize_window_apply): Rename to window_resize_apply.
3829 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3830 (Fdelete_other_windows_internal, resize_frame_windows)
3831 (Fsplit_window_internal, Fdelete_window_internal)
3832 (grow_mini_window, shrink_mini_window)
3833 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3834
c7e73be5
JD
38352011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3836
3837 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3838 (emacs_fixed_set_min_size): Remove.
3839 (emacs_fixed_new): Take frame as argument.
3840
3841 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3842 (_EmacsFixedPrivate): Remove minwidth/height.
3843 Add struct frame *f.
3844 (emacs_fixed_init): Initialize priv->f.
3845 (get_parent_class, emacs_fixed_set_min_size): Remove.
3846 (emacs_fixed_new): Set priv->f to argument.
3847 (emacs_fixed_get_preferred_width)
3848 (emacs_fixed_get_preferred_height): Use min_width/height from
3849 frames size_hint to set minimum and natural (Bug#8919).
3850 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3851 and use min_width/height from frames size_hint to set
3852 min_width/height (Bug#8919).
3853
3854 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3855 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3856 Fix indentation.
c7e73be5 3857
cf99dcf8
EZ
38582011-06-26 Eli Zaretskii <eliz@gnu.org>
3859
3860 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3861 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3862 called at ZV.
3863
029529ac
CY
38642011-06-26 Chong Yidong <cyd@stupidchicken.com>
3865
3866 * process.c (wait_reading_process_output): Bypass select if
3867 waiting for a cell while ignoring keyboard input, and input is
3868 pending. Suggested by Jan Djärv (Bug#8869).
3869
7a7ef429
PE
38702011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3871
3872 Use gnulib's dup2 module instead of rolling our own.
3873 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3874
11fdef7d 38752011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3876
3877 * dispnew.c (scrolling_window): Before scrolling, turn off a
3878 mouse-highlight in the window being scrolled.
3879
cd3520a4
JB
38802011-06-24 Juanma Barranquero <lekktu@gmail.com>
3881
3882 Move DEFSYM to lisp.h and use everywhere.
3883
3884 * character.h (DEFSYM): Move declaration...
3885 * lisp.h (DEFSYM): ...here.
3886
3887 * gnutls.c:
3888 * minibuf.c:
3889 * w32menu.c:
3890 * w32proc.c:
3891 * w32select.c: Don't include character.h.
3892
3893 * alloc.c (syms_of_alloc):
3894 * buffer.c (syms_of_buffer):
3895 * bytecode.c (syms_of_bytecode):
3896 * callint.c (syms_of_callint):
3897 * casefiddle.c (syms_of_casefiddle):
3898 * casetab.c (init_casetab_once):
3899 * category.c (init_category_once, syms_of_category):
3900 * ccl.c (syms_of_ccl):
3901 * cmds.c (syms_of_cmds):
3902 * composite.c (syms_of_composite):
3903 * dbusbind.c (syms_of_dbusbind):
3904 * dired.c (syms_of_dired):
3905 * dispnew.c (syms_of_display):
3906 * doc.c (syms_of_doc):
3907 * editfns.c (syms_of_editfns):
3908 * emacs.c (syms_of_emacs):
3909 * eval.c (syms_of_eval):
3910 * fileio.c (syms_of_fileio):
3911 * fns.c (syms_of_fns):
3912 * frame.c (syms_of_frame):
3913 * fringe.c (syms_of_fringe):
3914 * insdel.c (syms_of_insdel):
3915 * keymap.c (syms_of_keymap):
3916 * lread.c (init_obarray, syms_of_lread):
3917 * macros.c (syms_of_macros):
3918 * msdos.c (syms_of_msdos):
3919 * print.c (syms_of_print):
3920 * process.c (syms_of_process):
3921 * search.c (syms_of_search):
3922 * sound.c (syms_of_sound):
3923 * syntax.c (init_syntax_once, syms_of_syntax):
3924 * terminal.c (syms_of_terminal):
3925 * textprop.c (syms_of_textprop):
3926 * undo.c (syms_of_undo):
3927 * w32.c (globals_of_w32):
3928 * window.c (syms_of_window):
3929 * xdisp.c (syms_of_xdisp):
3930 * xfaces.c (syms_of_xfaces):
3931 * xfns.c (syms_of_xfns):
3932 * xmenu.c (syms_of_xmenu):
3933 * xsettings.c (syms_of_xsettings):
3934 * xterm.c (syms_of_xterm): Use DEFSYM.
3935
4228cf16
TZ
39362011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3937
cd3520a4 3938 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3939
7fcccf1e
PE
39402011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3941
7efb4e0e
PE
3942 Integer and buffer overflow fixes (Bug#8873).
3943
ff5844ad
PE
3944 * print.c (printchar, strout): Check for string overflow.
3945 (PRINTPREPARE, printchar, strout):
3946 Don't set size unless allocation succeeds.
3947
90532f02
PE
3948 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3949 for sizes. Check for string overflow more accurately.
3950 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3951
6d84508d
PE
3952 * macros.c: Integer and buffer overflow fixes.
3953 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3954 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3955 Use ptrdiff_t, not int, for sizes.
3956 Don't increment bufsize until after realloc succeeds.
3957 Check for size-calculation overflow.
3958 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3959
437b2cb4
PE
3960 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3961
8b9ac8b4
PE
3962 * lread.c: Integer overflow fixes.
3963 (read_integer): Radix is now EMACS_INT, not int,
3964 to improve quality of diagnostics for out-of-range radices.
3965 Calculate buffer size correctly for out-of-range radices.
3966 (read1): Check for integer overflow in radices, and in
3967 read-circle numbers.
82cb60d3
PE
3968 (read_escape): Avoid int overflow.
3969 (Fload, openp, read_buffer_size, read1)
3970 (substitute_object_recurse, read_vector, read_list, map_obarray):
3971 Use ptrdiff_t, not int, for sizes.
3972 (read1): Use EMACS_INT, not int, for sizes.
20270765 3973 Check for size overflow.
8b9ac8b4 3974
7fcccf1e
PE
3975 * image.c (cache_image): Check for size arithmetic overflow.
3976
bfbbd7e7
PE
3977 * lread.c: Integer overflow issues.
3978 (saved_doc_string_size, saved_doc_string_length)
3979 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3980 Now ptrdiff_t, not int.
3981 (read1): Don't assume doc string length fits in int. Check for
3982 out-of-range doc string lengths.
3983 (read_list): Don't assume file position fits in int.
39019e54 3984 (read_escape): Check for hex character overflow.
bfbbd7e7 3985
4e323265
LL
39862011-06-22 Leo Liu <sdl.web@gmail.com>
3987
3988 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3989 Move to minibuffer.el.
3990
85fece3e
PE
39912011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3992
20b84ce9 3993 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3994 The following patches are for when GLYPH_DEBUG && !XASSERT.
3995 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3996 * dispnew.c (flush_stdout):
3997 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3998 Mark as externally visible.
3999 * dispnew.c (check_window_matrix_pointers): Now static.
4000 * dispnew.c (window_to_frame_vpos):
4001 * xfns.c (unwind_create_frame):
4002 * xterm.c (x_check_font): Remove unused local.
4003 * scroll.c (CHECK_BOUNDS):
4004 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4005 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4006 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4007 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4008 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4009 Now static.
4010 (debug_method_add): Use va_list and vsprintf rather than relying
4011 on undefined behavior with wrong number of arguments.
4012 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4013 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4014 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4015 since we're not interested in debugging glyphs with old libraries.
4016 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4017 GCC 4.6.0's static checking.
4018
0766b489
PE
40192011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4020
31fd4b32
PE
4021 Integer overflow and signedness fixes (Bug#8873).
4022 A few related buffer overrun fixes, too.
4023
b79e8648
PE
4024 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4025
0766b489
PE
4026 * dispextern.h (struct face.stipple):
4027 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4028 (x_bitmap_mask, x_allocate_bitmap_record)
4029 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4030 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4031 (x_create_bitmap_from_xpm_data):
4032 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4033 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4034 (.bitmaps_last):
4035 * xfaces.c (load_pixmap):
4036 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4037 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4038 (.bitmaps_last, struct x_output.icon_bitmap):
4039 Use ptrdiff_t, not int, for bitmap indexes.
4040 (x_allocate_bitmap_record): Check for size overflow.
4041 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4042
b081724f
PE
4043 Use ptrdiff_t, not int, for overlay counts.
4044 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4045 * editfns.c (overlays_around, get_pos_property):
4046 * textprop.c (get_char_property_and_overlay):
4047 * xdisp.c (next_overlay_change, note_mouse_highlight):
4048 * xfaces.c (face_at_buffer_position):
21514da7
PE
4049 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4050 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4051 (Fnext_overlay_change, Fprevious_overlay_change)
4052 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4053 Use ptrdiff_t, not int, for sizes.
21514da7 4054 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4055
3de73e5e
PE
4056 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4057
2606c57b
PE
4058 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4059 (x_session_initialize): Do not assume string length fits in int.
4060
aaafe47a
PE
4061 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4062 This is unlikely, but can occur if DPI is outlandish.
4063
2674ddc8 4064 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4065 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4066
28154962
PE
4067 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4068 * xrdb.c (magic_file_p, search_magic_path):
4069 Omit last arg SUFFIX; it was always 0. All callers changed.
4070 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4071
7de51af5
PE
4072 * xfont.c (xfont_match): Avoid need for strlen.
4073
25ed6cc3
PE
4074 * xfns.c: Don't assume strlen fits in int.
4075 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4076
4eab31dd
PE
4077 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4078 not unsigned long, as we prefer signed integers. All callers changed.
4079 Detect integer overflow in repeat count.
4080 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4081 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4082
171e2a58
PE
4083 * termcap.c: Don't assume sizes fit in int and never overflow.
4084 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4085 (gobble_line): Check for size-calculation overflow.
4086
ad39faca 4087 * minibuf.c (Fread_buffer):
6e5bb2dc 4088 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4089 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4090 Don't assume string length fits in int.
4091
52c61c22 4092 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4093 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4094
b5b8c9e5
PE
4095 * font.c: Don't assume string length fits in int.
4096 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4097 Use ptrdiff_t, not int.
ccd6111c
PE
4098 (font_intern_prop): Don't assume string length fits in int.
4099 Don't assume integer property fits in fixnum.
4100 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4101
882f0d81 4102 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4103 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4104 Reformulate so as not to need the command string.
4105 Invoke gzip -cd rather than gunzip, as it's more portable.
4106 (lock_info_type, lock_file_1, lock_file):
4107 Don't assume pid_t and time_t fit in unsigned long.
4108 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4109 (current_lock_owner): Prefer signed type for sizes.
4110 Use memcpy, not strncpy, where memcpy is what is really wanted.
4111 Don't assume (via atoi) that time_t and pid_t fit in int.
4112 Check for time_t and/or pid_t out of range, e.g., via a network share.
4113 Don't alloca where an auto var works fine.
4114
93f4cf88
PE
4115 * fileio.c: Fix some integer overflow issues.
4116 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4117 Don't assume string length fits in int.
4118 (directory_file_name): Don't assume string length fits in long.
4119 (make_temp_name): Don't assume pid fits in int, or that its print
4120 length is less than 20.
4121
f3e92b69
PE
4122 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4123
1bfdaf10
PE
4124 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4125
35016e9a
PE
4126 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4127
3d1e65a1
PE
4128 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4129 We prefer signed integers, even for size calculations.
4130
0b963a93
PE
4131 * emacs.c: Don't assume string length fits in 'int'.
4132 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4133 (main): Don't invoke strlen when not needed.
4134
573f4b54
PE
4135 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4136 (XD_DEBUG_MESSAGE): Don't waste a byte.
4137
989f33ba
PE
4138 * callproc.c (getenv_internal_1, getenv_internal)
4139 (Fgetenv_internal):
965d34eb
PE
4140 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4141
e4d29b33
PE
4142 * lread.c (invalid_syntax): Omit length argument.
4143 All uses changed. This doesn't fix a bug, but it simplifies the
4144 code away from its former Hollerith-constant appearance, and it's
4145 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4146 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4147
eb49b136
PE
4148 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4149 This didn't break anything, but it didn't help either.
4150 It's confusing to put a bogus integer in a place where the actual
4151 value does not matter.
9f62aeb1 4152 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4153 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4154
15375a22
PE
4155 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4156 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4157 implementation.
b61cc01c
PE
4158 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4159 We prefer signed types, and the value cannot exceed the EMACS_INT
4160 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4161 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4162 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4163 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4164
53b2623d
PE
4165 * indent.c (sane_tab_width): New function.
4166 (current_column, scan_for_column, Findent_to, position_indentation)
4167 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4168 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4169
51cab52b 4170 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4171
f2ed8a70
PE
4172 * lisp.h (lint_assume): New macro.
4173 * composite.c (composition_gstring_put_cache):
4174 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4175
abe80cc6
PE
4176 * editfns.c, insdel.c:
4177 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4178
b02c740e
PE
4179 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4180
ebc96716
PE
4181 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4182
b4e50fa0 4183 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4184 Use much-faster test for byte-length change.
311d5d7c 4185 Don't assume string byte-length fits in 'int'.
a4cf38e4 4186 Check that character arg fits in 'int'.
85461888 4187 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4188
c0c1ee9f
PE
4189 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4190
a498d7f4
PE
4191 * fns.c (concat): Catch string overflow earlier.
4192 Do not rely on integer wraparound.
4193
51cab52b
PE
4194 * dispextern.h (struct it.overlay_strings_charpos)
4195 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4196 * xdisp.c (forward_to_next_line_start)
4197 (back_to_previous_visible_line_start)
4198 (reseat_at_next_visible_line_start, next_element_from_buffer):
4199 Don't arbitrarily truncate the value of 'selective' to int.
4200
76031fad
PE
4201 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4202
5eb55db9
PE
4203 * composite.c: Don't truncate sizes to 'int'.
4204 (composition_gstring_p, composition_reseat_it)
4205 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4206 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4207 not EMACS_UINT, for indexes.
5eb55db9 4208
0703a717
PE
4209 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4210
d6202519
PE
4211 * buffer.c: Include <verify.h>.
4212 (struct sortvec.priority, struct sortstr.priority):
8961a454 4213 Now EMACS_INT, not int.
c20998a7 4214 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4215 (struct sortstr.size, record_overlay_string)
4216 (struct sortstrlist.size, struct sortlist.used):
4217 Don't truncate size to int.
4218 (record_overlay_string): Check for size-calculation overflow.
d6202519 4219 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4220
d5a19415
JM
42212011-06-22 Jim Meyering <meyering@redhat.com>
4222
029529ac 4223 Don't leak an XBM-image-sized buffer
d5a19415
JM
4224 * image.c (xbm_load): Free the image buffer after using it.
4225
a9041e6c
PE
42262011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4227
4228 Port to Sun C.
4229 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4230 that Sun C diagnosed.
4231 * fns.c (secure_hash): Fix pointer signedness issue.
4232 * intervals.c (static_offset_intervals): New function.
4233 (offset_intervals): Use it.
4234
7f3f739f
LL
42352011-06-21 Leo Liu <sdl.web@gmail.com>
4236
4237 * deps.mk (fns.o):
4238 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4239 sha512.h.
4240
4241 * fns.c (secure_hash): Rename from crypto_hash_function and change
4242 the first arg to accept symbols.
5b66d427 4243 (Fsecure_hash): New primitive.
7f3f739f
LL
4244 (syms_of_fns): New symbols.
4245
76147d94
DD
42462011-06-20 Deniz Dogan <deniz@dogan.se>
4247
4248 * process.c (Fset_process_buffer): Clarify return value in
4249 docstring.
4250
7d7d0045
CY
42512011-06-18 Chong Yidong <cyd@stupidchicken.com>
4252
4253 * dispnew.c (add_window_display_history): Use BVAR.
4254
4255 * xdisp.c (debug_method_add): Use BVAR.
4256 (check_window_end, dump_glyph_matrix, dump_glyph)
4257 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4258
4259 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4260 Likewise.
4261
4262 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4263 check till after the cache is created in init_frame_faces.
4264
ff2bc410
SM
42652011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4266
4267 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4268
28177add
PE
42692011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4270
dd3482fe
PE
4271 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4272 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4273 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4274
393d71f3 4275 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4276 * fileio.c (Finsert_file_contents):
4277 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4278 Remove the old (too-loose) buffer overflow checks.
4279 They weren't needed, since make_gap checks for buffer overflow.
4280 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4281 The old code merely checked for Emacs fixnum overflow, and relied
4282 on undefined (wraparound) behavior. The new code avoids undefined
4283 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4284
2e6813b0 4285 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4286 Tune. Don't use wider integers than needed. Don't use alloca.
4287 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4288
599a9e4f
PE
4289 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4290
99561444
PE
4291 * insdel.c, lisp.h (buffer_overflow): New function.
4292 (insert_from_buffer_1, replace_range, replace_range_2):
4293 * insdel.c (make_gap_larger):
4294 * editfns.c (Finsert_char):
4295 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4296
28177add
PE
4297 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4298
e69dafad
PE
42992011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4300
a7af7fde 4301 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4302
b1c46f02
PE
4303 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4304 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4305
e69dafad
PE
4306 * fileio.c: Don't assume EMACS_INT fits in off_t.
4307 (emacs_lseek): New static function.
4308 (Finsert_file_contents, Fwrite_region): Use it.
4309 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4310
566684ea
PE
4311 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4312
e6966cd6
PE
4313 * fns.c: Don't overflow int when computing a list length.
4314 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4315 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4316 truncation on 64-bit hosts. Check for QUIT every
4317 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4318 faster and is responsive enough.
4319 (Flength): Report an error instead of overflowing an integer.
4320 (Fsafe_length): Return a float if the value is not representable
4321 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4322 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4323 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4324
dd0b0efb
PE
4325 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4326 (header_size, word_size): New constants.
4327 (allocate_vectorlike): Don't check size overflow here.
4328 (allocate_vector): Check it here instead, since this is the only
4329 caller of allocate_vectorlike that could cause overflow.
4330 Check that the new vector's length is representable as a fixnum.
4331
86fe5cfe
PE
4332 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4333 The previous code was bogus. For example, next_almost_prime (32)
4334 returned 39, which is undesirable as it is a multiple of 3; and
4335 next_almost_prime (24) returned 25, which is a multiple of 5 so
4336 why was the code bothering to check for multiples of 7?
4337
80e88859
PE
4338 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4339
4a2f0ad6
PE
4340 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4341
f66c7cf8
PE
4342 Variadic C functions now count arguments with ptrdiff_t.
4343 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4344 Back then I didn't know that the Emacs coding style prefers signed int.
4345 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4346 were being counted with int, which may truncate counts on 64-bit
4347 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4348 * lisp.h (struct Lisp_Subr.function.aMANY)
4349 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4350 Arg counts are now ptrdiff_t, not size_t.
4351 All variadic functions and their callers changed accordingly.
4352 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4353 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4354 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4355 * callint.c (Fcall_interactively): Check arg count for overflow,
4356 to avoid potential buffer overrun. Use signed char, not 'int',
4357 for 'varies' array, so that we needn't bother to check its size
4358 calculation for overflow.
4359 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4360 * eval.c (apply_lambda):
4361 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4362 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4363 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4364
a1759b76
PE
4365 * callint.c (Fcall_interactively): Don't use index var as event count.
4366
d96be9fc
PE
4367 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4368 * mem-limits.h (SIZE): Remove; no longer used.
4369
a690a978 4370 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4371
578c21e6
PE
4372 Remove unnecessary casts.
4373 * xterm.c (x_term_init):
4374 * xfns.c (x_set_border_pixel):
4375 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4376 These aren't needed now that we assume ANSI C.
4377
96f53c6c
PE
4378 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4379 It's more likely to cause problems (due to unsigned overflow)
4380 than to cure them.
4381
83c77d31
PE
4382 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4383
ee2079f1
PE
4384 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4385
6da65536
PE
4386 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4387
7147c4a4
PE
4388 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4389
193e32d9
PE
4390 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4391
e5533da6
PE
4392 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4393
9910e595
PE
4394 GLYPH_CODE_FACE returns EMACS_INT, not int.
4395 * dispextern.h (merge_faces):
4396 * xfaces.c (merge_faces):
01103c44
PE
4397 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4398 Don't assume EMACS_INT fits in int.
9910e595 4399
2638320e
PE
4400 * character.h (CHAR_VALID_P): Remove unused parameter.
4401 * fontset.c, lisp.h, xdisp.c: All uses changed.
4402
045eb8d9
PE
4403 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4404
c1f134b5
PE
4405 * fns.c (concat): Minor tuning based on overflow analysis.
4406 This doesn't fix any bugs. Use int to hold character, instead
4407 of constantly refetching from Emacs object. Use XFASTINT, not
4408 XINT, for value known to be a character. Don't bother comparing
4409 a single byte to 0400, as it's always less.
4410
395fcb93 4411 * floatfns.c (Fexpt):
327eeec8
PE
4412 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4413
abbd3d23
PE
4414 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4415 for characters.
4416
684a03ef
PE
4417 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4418
0fed43f3
PE
4419 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4420 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4421 incorrectly succeed when S was a string, because 4294967386 was
4422 truncated before it was used.
4423
8fd02eb7
PE
4424 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4425 Otherwise, an out-of-range integer could cause undefined behavior
4426 on a 64-bit host.
4427
f8c86b69
PE
4428 * composite.c: Use int, not EMACS_INT, for characters.
4429 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4430 EMACS_INT, for values that are known to be in character range.
4431 This doesn't fix any bugs but is the usual style inside Emacs and
4432 may generate better code on 32-bit machines.
4433
34206dd2
PE
4434 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4435 This is for reasons similar to the recent CHAR_STRING fix.
4436 * charset.c (Fencode_char): Check that character arg is actually
4437 a character. Pass an int to ENCODE_CHAR.
4438 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4439 wider than 'int', as a compile-time check to prevent future regressions
4440 in this area.
4441
c5958d4c 4442 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4443
4444 Make sure a 64-bit char is never passed to CHAR_STRING.
4445 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4446 by silently ignoring the top 32 bits, allowing some values
4447 that were far too large to be valid characters.
4448 * character.h: Include <verify.h>.
4449 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4450 arguments are no wider than unsigned, as a compile-time check
4451 to prevent future regressions in this area.
4452 * data.c (Faset):
01103c44 4453 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4454 (Fsubst_char_in_region):
4455 * fns.c (concat):
4456 * xdisp.c (decode_mode_spec_coding):
4457 Adjust to CHAR_STRING's new requirement.
4458 * editfns.c (Finsert_char, Fsubst_char_in_region):
4459 * fns.c (concat): Check that character args are actually
4460 characters. Without this test, these functions did the wrong
4461 thing with wildly out-of-range values on 64-bit hosts.
4462
d37ca623
PE
4463 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4464 These casts should not be needed on 32-bit hosts, either.
4465 * keyboard.c (read_char):
4466 * lread.c (Fload): Remove casts to unsigned.
4467
ea204efb
PE
4468 * lisp.h (UNSIGNED_CMP): New macro.
4469 This fixes comparison bugs on 64-bit hosts.
4470 (ASCII_CHAR_P): Use it.
4471 * casefiddle.c (casify_object):
01103c44 4472 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4473 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4474 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4475 * dispextern.h (FACE_FROM_ID):
4476 * keyboard.c (read_char): Use UNSIGNED_CMP.
4477
41cb286c
PE
4478 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4479 not to EMACS_INT, to avoid GCC warning.
4480
4a1b9832
PE
4481 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4482
55daad71
PE
4483 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4484 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4485 isn't needed on 32-bit machines.
8f95c75c 4486
01103c44
PE
4487 * buffer.c (Fgenerate_new_buffer_name):
4488 Use EMACS_INT for count, not int.
0ceccced 4489 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4490
4491 * data.c (Qcompiled_function): Now static.
4492
c6f072e7
PE
4493 * window.c (window_body_lines): Now static.
4494
20ce5912
PE
4495 * image.c (gif_load): Rename local to avoid shadowing.
4496
9c4c5f81
PE
4497 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4498 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4499 * alloc.c (make_save_value): Integer argument is now of type
4500 ptrdiff_t, not int.
4501 (mark_object): Use ptrdiff_t, not int.
4502 * lisp.h (pD): New macro.
4503 * print.c (print_object): Use it.
4504
c0c5c8ae
PE
4505 * alloc.c: Use EMACS_INT, not int, to count objects.
4506 (total_conses, total_markers, total_symbols, total_vector_size)
4507 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4508 (total_free_floats, total_floats, total_free_intervals)
4509 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4510 Now EMACS_INT, not int. All uses changed.
4511 (Fgarbage_collect): Compute overall total using a double, so that
4512 integer overflow is less likely to be a problem. Check for overflow
4513 when converting back to an integer.
5a25e253
PE
4514 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4515 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4516 These were 'int' variables that could overflow on 64-bit hosts;
4517 they were never used, so remove them instead of repairing them.
211a0b2a 4518 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4519 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4520 Previously, this ceilinged at INT_MAX, but that doesn't work on
4521 64-bit machines.
e46bb31a 4522 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4523
c78baabf 4524 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4525 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4526 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4527 when a (possibly-narrower) signed value would do just as well.
4528 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4529
c9d624c6
PE
4530 * alloc.c: Catch some string size overflows that we were missing.
4531 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4532 for convenience in STRING_BYTES_MAX.
4533 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4534 The definition here is exact; the one in lisp.h was approximate.
4535 (allocate_string_data): Check for string overflow. This catches
4536 some instances we weren't catching before. Also, it catches
4537 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4538 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4539 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4540
c9d624c6
PE
4541 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4542 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4543 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4544
353032ce
PE
4545 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4546
2bccce07
PE
4547 * alloc.c (Fmake_string): Check for out-of-range init.
4548
0ac30604
SM
45492011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4550
4551 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4552
c195f2de
JD
45532011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4554
4555 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4556 xg_get_default_scrollbar_width.
4557
4558 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4559 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4560 (style_changed_cb): Call update_theme_scrollbar_width and call
4561 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4562 all frames (Bug#8505).
4563 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4564 Call gtk_window_set_resizable if HAVE_GTK3.
4565 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4566 and height if HAVE_GTK3 (Bug#8505).
4567 (scroll_bar_width_for_theme): New variable.
4568 (update_theme_scrollbar_width): New function.
4569 (xg_get_default_scrollbar_width): Move code to
4570 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4571 (xg_initialize): Call update_theme_scrollbar_width.
4572
4573 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4574
4575 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4576
e10ac9f1
MR
45772011-06-12 Martin Rudalics <rudalics@gmx.at>
4578
4579 * frame.c (make_frame): Call other_buffer_safely instead of
4580 other_buffer.
4581
4582 * window.c (temp_output_buffer_show): Call display_buffer with
4583 second argument Vtemp_buffer_show_specifiers and reset latter
4584 immediately after the call.
4585 (Vtemp_buffer_show_specifiers): New variable.
4586 (auto_window_vscroll_p, next_screen_context_lines)
4587 (Vscroll_preserve_screen_position): Remove leading asterisks from
4588 doc-strings.
4589
2d3c217e 45902011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4591
7b7f97e8 4592 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4593 * buffer.c (Qclone_number): Remove for now, as it's unused.
4594 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4595 (record_buffer): Remove unused local.
4596 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4597 (set_frame_buffer_list): Remove; unused.
4598 * frame.h (other_visible_frames): Remove decl.
4599 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4600 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4601 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4602 if HAVE_GPM.
4603 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4604 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4605 Define only if HAVE_GPM.
4606 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4607 (update_hints_inhibit): Remove; never set. All uses removed.
4608 * widgetprv.h (emacsFrameClassRec): Remove decl.
4609 * window.c (delete_deletable_window): Now returns void, since it
4610 wasn't returning anything.
4611 (compare_window_configurations): Remove unused locals.
4612 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4613 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4614 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4615 the same widths as pointers. This follows up on the 2011-05-06 patch.
4616 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4617 * xterm.h: Likewise.
4618 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4619
1384b89e
JB
46202011-06-12 Juanma Barranquero <lekktu@gmail.com>
4621
4622 * makefile.w32-in: Update dependencies.
4623 (LISP_H): Add lib/intprops.h.
4624
1100a63c
CY
46252011-06-11 Chong Yidong <cyd@stupidchicken.com>
4626
4627 * image.c (gif_load): Add animation frame delay to the metadata.
4628 (syms_of_image): Use DEFSYM. New symbol `delay'.
4629
6198ccd0
MR
46302011-06-11 Martin Rudalics <rudalics@gmx.at>
4631
4632 * window.c (delete_deletable_window): Re-add.
4633 (Fset_window_configuration): Rewrite to handle dead buffers and
4634 consequently deletable windows.
4635 (window_tree, Fwindow_tree): Remove. Supply functionality in
4636 window.el.
4637 (compare_window_configurations): Simplify code.
4638
b6e3633c
AS
46392011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4640
1ab0dee5
AS
4641 * image.c (imagemagick_load_image): Fix type mismatch.
4642 (Fimagemagick_types): Likewise.
4643
b6e3633c
AS
4644 * window.h (replace_buffer_in_windows): Declare.
4645
9397e56f
MR
46462011-06-11 Martin Rudalics <rudalics@gmx.at>
4647
4648 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4649 Qclone_number. Remove external declaration of Qdelete_window.
4650 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4651 code.
640c8776
SM
4652 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4653 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4654 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4655 buffer list implementation.
4656 (other_buffer_safely): New function.
4657 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4658 calls to replace_buffer_in_windows and
4659 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4660 if allowed.
4661 (record_buffer): Inhibit quitting and rewrite using quittable
4662 functions. Run Qbuffer_list_update_hook if allowed.
4663 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4664 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4665 Move switch-to-buffer to window.el.
9397e56f
MR
4666 (bury-buffer): Move to window.el.
4667 (Vbuffer_list_update_hook): New variable.
4668
4669 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4670 section.
4671
4672 * window.h (resize_frame_windows): Move up in code.
4673 (Fwindow_frame): Remove EXFUN.
4674 (replace_buffer_in_all_windows): Remove prototype.
4675 (replace_buffer_in_windows_safely): Add prototype.
4676
4677 * window.c: Declare Qdelete_window static again. Move down
4678 declaration of select_count.
4679 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4680 (Fother_window): Move to window.el.
4681 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4682 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4683 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4684 window.el.
4685 (replace_buffer_in_windows): Implement by calling
4686 Qreplace_buffer_in_windows.
4687 (replace_buffer_in_all_windows): Remove with some functionality
4688 moved into replace_buffer_in_windows_safely.
4689 (replace_buffer_in_windows_safely): New function.
4690 (select_window_norecord, select_frame_norecord): Move in front
4691 of run_window_configuration_change_hook. Remove now obsolete
4692 declarations.
640c8776
SM
4693 (Fset_window_buffer): Rewrite doc-string.
4694 Call Qrecord_window_buffer.
9397e56f
MR
4695 (keys_of_window): Move binding for other-window to window.el.
4696
b50691aa
CY
46972011-06-11 Chong Yidong <cyd@stupidchicken.com>
4698
4699 * dispextern.h (struct image): Replace data member, whose int_val
4700 and ptr_val fields were not used by anything, with a single
4701 lisp_val object.
4702
4703 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4704 (gif_clear_image, gif_load, imagemagick_load_image)
4705 (gs_clear_image, gs_load): Callers changed.
4706
3f754b86
PE
47072011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4708
cca69397
PE
4709 * buffer.h: Include <time.h>, for time_t.
4710 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4711
109e28d0
PE
4712 Fix minor problems found by static checking.
4713
60737f02
PE
4714 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4715
4b66faf3
PE
4716 Make identifiers static if they are not used in other modules.
4717 * data.c (Qcompiled_function, Qframe, Qvector):
4718 * image.c (QimageMagick, Qsvg):
4719 * minibuf.c (Qmetadata):
4720 * window.c (resize_window_check, resize_root_window): Now static.
4721 * window.h (resize_window_check, resize_root_window): Remove decls.
4722
109e28d0
PE
4723 * window.c (window_deletion_count, delete_deletable_window):
4724 Remove; unused.
46a4ce9e
PE
4725 (window_body_lines): Now static.
4726 (Fdelete_other_windows_internal): Mark vars as initialized.
4727 Make sure 'resize_failed' is initialized.
4728 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4729 (resize_window_apply): Remove unused local.
4730 * window.h (delete_deletable_window): Remove decl.
4731
109e28d0 4732 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4733 (imagemagick_load_image): Fix pointer signedness problem by changing
4734 last arg from unsigned char * to char *. All uses changed.
4735 Also, fix a local for similar reasons.
4736 Remove unused locals. Remove locals to avoid shadowing.
4737 (fn_rsvg_handle_free): Remove; unused.
4738 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4739 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4740
3f754b86
PE
4741 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4742
2547adb1
CY
47432011-06-10 Chong Yidong <cyd@stupidchicken.com>
4744
4745 * image.c (gif_load): Fix omitted cast error introduced by
4746 2011-06-06 change.
4747
2c8e37d4
MR
47482011-06-10 Martin Rudalics <rudalics@gmx.at>
4749
4750 * window.h (resize_proportionally, orig_total_lines)
4751 (orig_top_line): Remove from window structure.
4752 (set_window_height, set_window_width, change_window_heights)
4753 (Fdelete_window): Remove prototypes.
4754 (resize_frame_windows): Remove duplicate declaration.
4755
440a42e3
EZ
47562011-06-10 Eli Zaretskii <eliz@gnu.org>
4757
4758 * window.h (resize_frame_windows, resize_window_check)
4759 (delete_deletable_window, resize_root_window)
4760 (resize_frame_windows): Declare prototypes.
4761
4762 * window.c (resize_window_apply): Make definition be "static" to
4763 match the prototype.
4764
562dd5e9
MR
47652011-06-10 Martin Rudalics <rudalics@gmx.at>
4766
4767 * window.c: Remove declarations of Qwindow_size_fixed,
4768 window_min_size_1, window_min_size_2, window_min_size,
4769 size_window, window_fixed_size_p, enlarge_window, delete_window.
4770 Remove static from declaration of Qdelete_window, it's
4771 temporarily needed by Fbury_buffer.
4772 (replace_window): Don't assign orig_top_line and
4773 orig_total_lines.
4774 (Fdelete_window, delete_window): Remove. Window deletion is
4775 handled by window.el.
640c8776
SM
4776 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4777 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4778 (Fdelete_other_windows): Remove. Deleting other windows is
4779 handled by window.el.
4780 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4781 handled in window.el.
4782 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4783 Window minimum sizes are handled in window.el.
4784 (shrink_windows, size_window, set_window_height)
4785 (set_window_width, change_window_heights, window_height)
4786 (window_width, CURBEG, CURSIZE, enlarge_window)
4787 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4788 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4789 handled in window.el.
4790 (make_dummy_parent): Rename to make_parent_window and give it a
4791 second argument horflag.
4792 (make_window): Don't set resize_proportionally any more.
4793 (Fsplit_window): Remove. Windows are split in window.el.
4794 (save_restore_action, save_restore_orig_size)
4795 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4796 Resize mini windows in window.el.
4797 (grow_mini_window, shrink_mini_window): Implement by calling
4798 Qresize_root_window_vertically, resize_window_check and
4799 resize_window_apply.
640c8776
SM
4800 (saved_window, Fset_window_configuration, save_window_save):
4801 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4802 resize_proportionally.
4803 (window_min_height, window_min_width): Move to window.el.
4804 (keys_of_window): Move bindings for delete-other-windows,
4805 split-window, delete-window and enlarge-window to window.el.
4806
4807 * buffer.c: Temporarily extern Qdelete_window.
4808 (Fbury_buffer): Temporarily call Qdelete_window instead of
4809 Fdelete_window (Fbury_buffer will move to window.el soon).
4810
4811 * frame.c (set_menu_bar_lines_1): Remove code handling
4812 orig_top_line and orig_total_lines.
4813
4814 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4815 set_window_height but set heights directly.
4816 (change_frame_size_1): Use resize_frame_windows.
4817
4818 * xdisp.c (init_xdisp): Don't use set_window_height but set
4819 heights directly.
4820
640c8776
SM
4821 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4822 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4823 run_window_configuration_change_hook.
4824
4825 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4826 instead of change_window_heights and run
4827 run_window_configuration_change_hook.
4828
1a13852e
MR
48292011-06-09 Martin Rudalics <rudalics@gmx.at>
4830
4831 * window.c (replace_window): Rename second argument REPLACEMENT to
4832 NEW. New third argument SETFLAG. Rewrite.
4833 (delete_window, make_dummy_parent): Call replace_window with
4834 third argument 1.
4835 (window_list_1): Move down in code.
4836 (run_window_configuration_change_hook): Move set_buffer part
4837 before select_frame_norecord part in order to unwind correctly.
4838 Rename count1 to count.
4839 (recombine_windows, delete_deletable_window, resize_root_window)
4840 (Fdelete_other_windows_internal)
4841 (Frun_window_configuration_change_hook, make_parent_window)
4842 (resize_window_check, resize_window_apply, Fresize_window_apply)
4843 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4844 (Fdelete_window_internal, Fresize_mini_window_internal):
4845 New functions.
1a13852e
MR
4846 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4847
f3d1777e
MR
48482011-06-08 Martin Rudalics <rudalics@gmx.at>
4849
496e208e
MR
4850 * window.h (window): Add some new members to window structure -
4851 normal_lines, normal_cols, new_total, new_normal, clone_number,
4852 splits, nest, prev_buffers, next_buffers.
4853 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4854 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4855
f3d1777e
MR
4856 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4857 Remove.
496e208e
MR
4858 (make_dummy_parent): Set new members of windows structure.
4859 (make_window): Move down in code. Handle new members of window
4860 structure.
4861 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4862 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4863 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4864 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4865 (Fset_window_next_buffers, Fset_window_clone_number):
4866 New functions.
496e208e
MR
4867 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4868 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4869 Doc-string fixes.
4870 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4871 Argument WINDOW can be now internal window too.
4872 (Fwindow_use_time): Move up in code.
4873 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4874 Rewrite doc-string.
4875 (Fset_window_configuration, saved_window)
4876 (Fcurrent_window_configuration, save_window_save): Handle new
4877 members of window structure.
b9e809c2
MR
4878 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4879 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4880 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4881 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4882 Qget_mru_window, Qresize_root_window,
4883 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4884 Qauto_buffer_name; staticpro them.
f3d1777e 4885
abde8f8c
MR
48862011-06-07 Martin Rudalics <rudalics@gmx.at>
4887
4888 * window.c (Fwindow_total_size, Fwindow_left_column)
4889 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4890 (Fwindow_list_1): New functions.
4891 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4892 (Fwindow_width, Fscroll_left, Fscroll_right):
4893 Use window_body_cols instead of window_box_text_cols.
4894 (delete_window, Fset_window_configuration):
4895 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4896 (delete_all_subwindows): Take a window as argument and not a
4897 structure. Rewrite.
190b47e6
MR
4898 (window_loop): Remove handling of GET_LRU_WINDOW and
4899 GET_LARGEST_WINDOW.
4900 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4901
4902 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4903 window_box_text_cols. delete_all_subwindows now takes a
4904 Lisp_Object as argument.
abde8f8c 4905
640c8776
SM
4906 * indent.c (compute_motion, Fcompute_motion):
4907 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4908
fa8a67e6
MR
4909 * frame.c (delete_frame): Call delete_all_subwindows with root
4910 window as argument.
4911
a54e3482
DC
49122011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4913
4914 * fns.c (Fputhash): Document return value.
4915
60002bf5
CY
49162011-06-06 Chong Yidong <cyd@stupidchicken.com>
4917
4918 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4919
0c671da6 49202011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4921
b862a52a 4922 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4923
be44ca6c
PE
4924 Check for overflow when converting integer to cons and back.
4925 * charset.c (Fdefine_charset_internal, Fdecode_char):
4926 Use cons_to_unsigned to catch overflow.
4927 (Fencode_char): Use INTEGER_TO_CONS.
4928 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4929 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4930 * data.c (long_to_cons, cons_to_long): Remove.
4931 (cons_to_unsigned, cons_to_signed): New functions.
4932 These signal an error for invalid or out-of-range values.
4933 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4934 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4935 * font.c (Ffont_variation_glyphs):
4936 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4937 * lisp.h: Include <intprops.h>.
4938 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4939 (cons_to_signed, cons_to_unsigned): New decls.
4940 (long_to_cons, cons_to_long): Remove decls.
4941 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4942 (Fprimitive_undo): Use CONS_TO_INTEGER.
4943 * xfns.c (Fx_window_property): Likewise.
4944 * xselect.c: Include <limits.h>.
4945 (x_own_selection, selection_data_to_lisp_data):
4946 Use INTEGER_TO_CONS.
4947 (x_handle_selection_request, x_handle_selection_clear)
4948 (x_get_foreign_selection, Fx_disown_selection_internal)
4949 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4950 (lisp_data_to_selection_data): Use cons_to_unsigned.
4951 (x_fill_property_data): Use cons_to_signed.
4952 Report values out of range.
4953
d1f3d2af
PE
4954 Check for buffer and string overflow more precisely.
4955 * buffer.h (BUF_BYTES_MAX): New macro.
4956 * lisp.h (STRING_BYTES_MAX): New macro.
4957 * alloc.c (Fmake_string):
4958 * character.c (string_escape_byte8):
4959 * coding.c (coding_alloc_by_realloc):
4960 * doprnt.c (doprnt):
4961 * editfns.c (Fformat):
4962 * eval.c (verror):
4963 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4964 since they may not be the same number.
4965 * editfns.c (Finsert_char):
4966 * fileio.c (Finsert_file_contents):
4967 Likewise for BUF_BYTES_MAX.
4968
dd52fcea
PE
4969 * image.c: Use ptrdiff_t, not int, for sizes.
4970 (slurp_file): Switch from int to ptrdiff_t.
4971 All uses changed.
4972 (slurp_file): Check that file size fits in both size_t (for
4973 malloc) and ptrdiff_t (for sanity and safety).
4974
7f9bbdbb
PE
4975 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4976 if b->modtime has its maximal value.
4977
dfe18f82
PE
4978 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4979
84acfcf0
PE
4980 Don't assume time_t can fit into int.
4981 * buffer.h (struct buffer.modtime): Now time_t, not int.
4982 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4983 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4984
ccd9a01a
PE
4985 Minor fixes for signed vs unsigned integers.
4986 * character.h (MAYBE_UNIFY_CHAR):
4987 * charset.c (maybe_unify_char):
4988 * keyboard.c (read_char, reorder_modifiers):
4989 XINT -> XFASTINT, since the integer must be nonnegative.
4990 * ftfont.c (ftfont_spec_pattern):
4991 * keymap.c (access_keymap, silly_event_symbol_error):
4992 XUINT -> XFASTINT, since the integer must be nonnegative.
4993 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4994 since it makes no difference and we prefer signed.
4995 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4996 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4997 nonnegative.
4998
d6d100dd
SM
49992011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5000
5001 * window.h (Fwindow_frame): Declare.
5002
2b6148e4
PE
50032011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5004
5005 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5006 (SPARE_MEMORY): Always define.
5007 (LARGE_REQUEST): Remove.
5008 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5009
f230ecc9
MR
50102011-06-06 Martin Rudalics <rudalics@gmx.at>
5011
727e958e
MR
5012 * lisp.h: Move EXFUNS for Fframe_root_window,
5013 Fframe_first_window and Fset_frame_selected_window to window.h.
5014
5015 * window.h: Move EXFUNS for Fframe_root_window,
5016 Fframe_first_window and Fset_frame_selected_window here from
5017 lisp.h.
5018
5019 * frame.c (Fwindow_frame, Fframe_first_window)
5020 (Fframe_root_window, Fframe_selected_window)
5021 (Fset_frame_selected_window): Move to window.c.
5022 (Factive_minibuffer_window): Move to minibuf.c.
5023 (Fother_visible_frames_p): New function.
5024
5025 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5026
f230ecc9
MR
5027 * window.c (decode_window, decode_any_window): Move up in code.
5028 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5029 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5030 (Fwindow_buffer): Move up and rewrite doc-string.
5031 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5032 (Fwindow_prev): New functions.
727e958e
MR
5033 (Fwindow_frame): Move here from frame.c. Accept any window as
5034 argument.
5035 (Fframe_root_window, Fframe_first_window)
5036 (Fframe_selected_window): Move here from frame.c. Accept frame
5037 or arbitrary window as argument. Update doc-strings.
5038 (Fminibuffer_window): Move up in code.
5039 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5040 (Fset_frame_selected_window): Move here from frame.c.
5041 Marginal rewrite.
727e958e
MR
5042 (Fselected_window, select_window, Fselect_window): Move up in
5043 code. Minor doc-string fixes.
f230ecc9 5044
4d09bcf6
PE
50452011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5046
5047 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5048 Do not assume that spare memory exists; that assumption is valid
5049 only if SYSTEM_MALLOC.
5050 (LARGE_REQUEST): New macro, so that the issue of large requests
5051 is separated from the issue of spare memory.
5052
810928a2
AS
50532011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5054
172418ad
AS
5055 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5056 format. (Bug#8806)
5057
43f862f7
AS
5058 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5059
810928a2
AS
5060 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5061 before statements.
5062
a059fe24
JD
50632011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5064
5065 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5066
5067 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5068
5069 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5070 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5071
989bf368
JB
50722011-06-05 Juanma Barranquero <lekktu@gmail.com>
5073
5074 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5075
4b80f674
CY
50762011-06-04 Chong Yidong <cyd@stupidchicken.com>
5077
5078 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5079 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5080 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5081 New error handlers.
4b80f674
CY
5082 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5083 Obey Vx_select_enable_clipboard_manager. Catch errors in
5084 x_clipboard_manager_save (Bug#8779).
5085 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5086 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5087
99a33b77 50882011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5089
5090 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5091
99a33b77 50922011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5093
5094 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5095 in the current matrix if keep_current_p is non-zero.
5096
8264569d
EZ
50972011-06-04 Eli Zaretskii <eliz@gnu.org>
5098
5099 * bidi.c (bidi_level_of_next_char): Fix last change.
5100
57f97249
EZ
51012011-06-03 Eli Zaretskii <eliz@gnu.org>
5102
fec2107c 5103 Support bidi reordering of text covered by display properties.
57f97249 5104
fec2107c
EZ
5105 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5106 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5107 (bidi_cache_search, bidi_cache_iterator_state)
5108 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5109 (bidi_level_of_next_char, bidi_move_to_visually_next):
5110 Support character positions inside a run of characters covered by a
fec2107c
EZ
5111 display string.
5112 (bidi_paragraph_init, bidi_resolve_explicit_1)
5113 (bidi_level_of_next_char): Call bidi_fetch_char and
5114 bidi_fetch_char_advance instead of FETCH_CHAR and
5115 FETCH_CHAR_ADVANCE.
5116 (bidi_init_it): Initialize new members.
5117 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5118 definitions.
5119 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5120 instead of using explicit *_CHAR codes.
d6d100dd
SM
5121 (bidi_resolve_explicit, bidi_resolve_weak):
5122 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5123 bidirectional text is supported only in multibyte buffers.
5124 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5125 it to initialize the frame_window_p member of struct bidi_it.
5126 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5127 (bidi_resolve_explicit, bidi_resolve_weak)
5128 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5129 bidi_it->nchars is non-positive.
5130 (bidi_level_of_next_char): Don't try to lookup the cache for the
5131 next/previous character if nothing is cached there yet, or if we
5132 were just reseat()'ed to a new position.
c40e2fb2 5133
0e14fe90
EZ
5134 * xdisp.c (set_cursor_from_row): Set start and stop points
5135 according to the row's direction when priming the loop that looks
5136 for the glyph on which to display cursor.
5137 (single_display_spec_intangible_p): Function deleted.
5138 (display_prop_intangible_p): Reimplement to call
5139 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5140 Accept 3 additional arguments needed by handle_display_spec.
5141 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5142 values: lists, `(when COND...)' forms, etc.
5143 (single_display_spec_string_p): Support property values that are
5144 lists with the argument STRING its top-level element.
5145 (display_prop_string_p): Fix the condition for processing a
5146 property that is a list to be consistent with handle_display_spec.
fec2107c 5147 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5148 last portion of handle_display_prop.
5149 (compute_display_string_pos): Accept additional argument
5150 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5151 value of a `display' property is a "replacing spec".
5152 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5153 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5154 the display property, but just return a value indicating whether
5155 the display property will replace the characters it covers.
5156 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5157 frame_window_p members of struct bidi_it.
d6d100dd
SM
5158 (compute_display_string_pos, compute_display_string_end):
5159 New functions.
fec2107c
EZ
5160 (push_it): Accept second argument POSITION, where pop_it should
5161 jump to continue iteration.
5162 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5163
fec2107c
EZ
5164 * keyboard.c (adjust_point_for_property): Adjust the call to
5165 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5166
5167 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5168 (bidi_init_it): Update prototypes.
5169 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5170 (compute_display_string_pos, compute_display_string_end):
5171 Declare prototypes.
fec2107c
EZ
5172 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5173 EMACS_INT.
fc6f18ce 5174
40087514 51752011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5176
57f53182
PE
5177 Malloc failure behavior now depends on size of allocation.
5178 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5179 * lisp.h: Change signatures accordingly.
5180 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5181 All callers changed. (Bug#8762)
5182
5183 * gnutls.c: Use Emacs's memory allocators.
5184 Without this change, the gnutls library would invoke malloc etc.
5185 directly, which causes problems on non-SYNC_INPUT hosts, and which
5186 runs afoul of improving memory_full behavior. (Bug#8761)
5187 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5188 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5189 xfree instead of the default malloc, realloc, free.
5190 (Fgnutls_boot): No need to check for memory allocation failure,
5191 since xmalloc does that for us.
5192
ac32cd99 5193 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5194 * category.c (hash_get_category_set):
5195 * ccl.c (ccl_driver):
5196 * charset.c (Fdefine_charset_internal):
5197 * charset.h (struct charset.hash_index):
5198 * composite.c (get_composition_id, gstring_lookup_cache)
5199 (composition_gstring_put_cache):
5200 * composite.h (struct composition.hash_index):
5201 * dispextern.h (struct image.hash):
5202 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5203 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5204 (hashfn_equal, hashfn_user_defined, make_hash_table)
5205 (maybe_resize_hash_table, hash_lookup, hash_put)
5206 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5207 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5208 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5209 * image.c (make_image, search_image_cache, lookup_image)
5210 (xpm_put_color_table_h):
5211 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5212 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5213 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5214 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5215 * alloc.c (allocate_vectorlike):
5216 Check for overflow in vector size calculations.
5217 * ccl.c (ccl_driver):
5218 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5219 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5220 need to be updated by these changes.
40087514
PE
5221 * fns.c (make_hash_table, maybe_resize_hash_table):
5222 Check for integer overflow with large hash tables.
0de4bb68
PE
5223 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5224 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5225 (SXHASH_REDUCE): New macro.
5226 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5227 Use it instead of discarding useful hash info with large hash values.
5228 (sxhash_float): New function.
5229 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5230 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5231 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5232 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5233 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5234 Adjust signatures to match updated version of code.
5235 (consing_since_gc): Now EMACS_INT, since a single hash table can
5236 use more than INT_MAX bytes.
5237
698d32e2
DN
52382011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5239
5240 Make it possible to build with GCC-4.6+ -O2 -flto.
5241
5242 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5243
fd6fa53f
SM
52442011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5245
5246 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5247 Call minibuffer-inactive-mode.
5248
864db017
JB
52492011-05-31 Juanma Barranquero <lekktu@gmail.com>
5250
5251 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5252 Update dependencies.
5253
2ad0baf4
DN
52542011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5255
5256 * data.c (init_data): Remove code for UTS, this system is not
5257 supported anymore.
5258
4fcc2638
DN
52592011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5260
5261 Don't force ./temacs to start in terminal mode.
5262
5263 * frame.c (make_initial_frame): Initialize faces in all cases, not
5264 only when CANNOT_DUMP is defined.
5265 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5266
c56e0fd5
DN
52672011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5268
5269 * dispnew.c (add_window_display_history): Use const for the string
5270 pointer. Remove declaration, not needed.
5271
333d54da 52722011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5273
55d4c1b2 5274 Use 'inline', not 'INLINE'.
333d54da 5275 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5276 * alloc.c, fontset.c (INLINE): Remove.
5277 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5278 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5279 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5280 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5281 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5282
738db178
DN
52832011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5284
5285 Make it possible to run ./temacs.
5286
5287 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5288 syms_of_callproc does the same thing. Remove test for
5289 "initialized", do it in the caller.
5290 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5291
620c53a6
SM
52922011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5293
5294 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5295 (read_minibuf): Use get_minibuffer.
5296 (syms_of_minibuf): Use DEFSYM.
5297 (Qmetadata): New var.
5298 * data.c (Qbuffer): Don't make it static.
5299 (syms_of_data): Use DEFSYM.
5300
e003a292
PE
53012011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5302
5303 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5304 (CCL_CODE_MIN): New macro.
5305
ed008a6d
PE
53062011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5307
3687c2ef
PE
5308 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5309
ed008a6d
PE
5310 * eval.c (Qdebug): Now static.
5311 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5312 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5313 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5314
d66c4c7c
CY
53152011-05-29 Chong Yidong <cyd@stupidchicken.com>
5316
5317 * image.c: Various fixes to ImageMagick code comments.
5318 (Fimagemagick_types): Doc fix.
5319
5fbc2025
PE
53202011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5321
0196f88a
PE
5322 Minor fixes prompted by GCC 4.6.0 warnings.
5323
5324 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5325
5fbc2025
PE
5326 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5327 (x_clipboard_manager_save_all): Move extern decl to ...
5328 * xterm.h: ... here, so that it can be checked for consistency.
5329
1dd3c2d9
CY
53302011-05-29 Chong Yidong <cyd@stupidchicken.com>
5331
5332 * xselect.c (x_clipboard_manager_save_frame)
5333 (x_clipboard_manager_save_all): New functions.
5334 (Fx_clipboard_manager_save): Lisp function deleted.
5335
5336 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5337 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5338
5339 * xterm.h: Update prototype.
5340
5ba6571d
WX
53412011-05-28 William Xu <william.xwl@gmail.com>
5342
5343 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5344 exiting (Bug#8239).
5345
3eaff834
JM
53462011-05-28 Jim Meyering <meyering@redhat.com>
5347
e1900994 5348 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5349 * fns.c (to_uchar): Define.
5350 (crypto_hash_function): Use it to convert some newly-signed
5351 variables to unsigned, to avoid sign-extension bugs. For example,
5352 without this change, (md5 "truc") would evaluate to
5353 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5354 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5355 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5356
0f6990a7
PE
53572011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5358
5359 Integer overflow fixes.
c8a9ca5a 5360
08686060
PE
5361 * dbusbind.c: Serial number integer overflow fixes.
5362 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5363 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5364 to hold a serial number that is too large for a fixnum.
5365 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5366 Check for serial numbers out of range. Decode any serial number
59568bf0 5367 that was so large that it became a float. (Bug#8722)
08686060 5368
2d1fc3c7
PE
5369 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5370 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5371 Use XFASTINT rather than XUINT when numbers are nonnegative.
5372 (xd_append_arg, Fdbus_method_return_internal):
5373 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5374 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5375 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5376 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5377 (Bug#8722)
2d1fc3c7 5378
c8a9ca5a
PE
5379 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5380
519e1d69
PE
5381 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5382
30569699
PE
5383 ccl: add integer overflow checks
5384 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5385 (IN_INT_RANGE): New macros.
5386 (ccl_driver): Use them to check for integer overflow when
5387 decoding a CCL program. Many of the new checks are whether XINT (x)
5388 fits in int; it doesn't always, on 64-bit hosts. The new version
5389 doesn't catch all possible integer overflows, but it's an
847044ea 5390 improvement. (Bug#8719)
30569699 5391
c11285dc
PE
5392 * alloc.c (make_event_array): Use XINT, not XUINT.
5393 There's no need for unsigned here.
5394
fdccd48e
PE
5395 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5396 This follows up to the 2011-05-06 change that substituted uintptr_t
5397 for EMACS_INT. This case wasn't caught back then.
5398
37910ab2
PE
5399 Rework Fformat to avoid integer overflow issues.
5400 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5401 now (part of C89). Include <verify.h>.
5402 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5403 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5404 (Fformat): Avoid the prepass trying to compute sizes; it was only
5405 approximate and thus did not catch overflow reliably. Instead, walk
5406 through the format just once, formatting and computing sizes as we go,
5407 checking for integer overflow at every step, and allocating a larger
5408 buffer as needed. Keep track separately whether the format is
5409 multibyte. Keep only the most-recently calculated precision, rather
5410 than them all. Record whether each argument has been converted to
5411 string. Use EMACS_INT, not int, for byte and char and arg counts.
5412 Support field widths and precisions larger than INT_MAX. Avoid
5413 sprintf's undefined behavior with conversion specifications such as %#d
5414 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5415 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5416 formatting out-of-range floating point numbers with int
9173deec 5417 formats. (Bug#8668)
37910ab2 5418
2e6578fb
PE
5419 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5420
0ae6bdee
PE
5421 * data.c: Avoid integer truncation in expressions involving floats.
5422 * data.c: Include <intprops.h>.
5423 (arith_driver): When there's an integer overflow in an expression
5424 involving floating point, convert the integers to floating point
5425 so that the resulting value does not suffer from catastrophic
5426 integer truncation. For example, on a 64-bit host (* 4
5427 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5428 Do not rely on undefined behavior after integer overflow.
5429
de883a70
PE
5430 merge count_size_as_multibyte, parse_str_to_multibyte
5431 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5432 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5433 Check for integer overflow.
5434 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5435 since it's now a duplicate of the other. This is more of
5436 a character than a buffer op, so better that it's in character.c.
5437 * fns.c, print.c: Adjust to above changes.
5438
2ff916cb
PE
54392011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5440
5441 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5442
f1b54466
PE
54432011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5444
fb1ac845
PE
5445 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5446 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5447 (x_clipboard_manager_save): Now static.
5448 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5449
f1b54466
PE
5450 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5451 (crypto_hash_function): Now static.
5452 Fix pointer signedness problems. Avoid unnecessary initializations.
5453
a9f737ee
CY
54542011-05-27 Chong Yidong <cyd@stupidchicken.com>
5455
5456 * termhooks.h (Vselection_alist): Make it terminal-local.
5457
5458 * terminal.c (create_terminal): Initialize it.
5459
5460 * xselect.c: Support for clipboard managers.
5461 (Vselection_alist): Move to termhooks.h as terminal-local var.
5462 (LOCAL_SELECTION): New macro.
5463 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5464 (symbol_to_x_atom): Remove gratuitous arg.
5465 (x_handle_selection_request, lisp_data_to_selection_data)
5466 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5467 (x_own_selection, x_get_local_selection, x_convert_selection):
5468 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5469 (some_frame_on_display): Delete unused function.
5470 (Fx_own_selection_internal, Fx_get_selection_internal)
5471 (Fx_disown_selection_internal, Fx_selection_owner_p)
5472 (Fx_selection_exists_p): New optional frame arg.
5473 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5474 (x_handle_selection_clear): Don't treat other terminals with the
5475 same keyboard specially. Use the terminal-local Vselection_alist.
5476 (x_clear_frame_selections): Use Frun_hook_with_args.
5477
5478 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5479
5480 * xterm.h: Add support for those atoms.
5481
e067f0c1
CY
54822011-05-26 Chong Yidong <cyd@stupidchicken.com>
5483
5484 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5485 (converted_selections, conversion_fail_tag): New global variables.
5486 (x_selection_request_lisp_error): Free the above.
5487 (x_get_local_selection): Remove unnecessary code.
5488 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5489 of converted selections stored in converted_selections.
5490 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5491 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5492 (x_convert_selection): New function.
5493 (x_handle_selection_event): Simplify.
5494 (x_get_foreign_selection): Don't ignore incoming requests while
5495 waiting for an answer; this will fail when we implement
5496 SAVE_TARGETS, and seems unnecessary anyway.
5497 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5498 (Vx_sent_selection_functions): Doc fix.
5499
0f4aebc0
LL
55002011-05-26 Leo Liu <sdl.web@gmail.com>
5501
5502 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5503
e61124cd
YM
55042011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5505
5506 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5507
5508 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5509 for fringe update if it has periodic bitmap.
ac389d0c 5510 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5511 and fringe_bitmap_periodic_p.
5512
5513 * fringe.c (get_fringe_bitmap_data): New function.
5514 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5515 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5516 row. Mark glyph row for fringe update if periodicity changed.
5517
5518 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5519 for fringe update unless it has periodic bitmap.
5520
f16d9837
KH
55212011-05-25 Kenichi Handa <handa@m17n.org>
5522
5523 * xdisp.c (get_next_display_element): Set correct it->face_id for
5524 a static composition.
5525
e1b90ef6
LL
55262011-05-24 Leo Liu <sdl.web@gmail.com>
5527
5528 * deps.mk (fns.o):
5529 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5530
5531 * fns.c (crypto_hash_function, Fsha1): New function.
5532 (Fmd5): Use crypto_hash_function.
5533 (syms_of_fns): Add Ssha1.
5534
7400048f
PE
55352011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5536
5537 * gnutls.c: Remove unused macros.
5538 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5539 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5540 Remove macros that are defined and never used.
5541 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5542
abb71cf4
CY
55432011-05-22 Chong Yidong <cyd@stupidchicken.com>
5544
5545 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5546 (Fx_get_selection_internal): Minor cleanup.
5547 (Fx_own_selection_internal): Rename arguments for consistency with
5548 select.el.
5549
6307db39
PE
55502011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5551
5552 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5553
f3d4e0a4
CY
55542011-05-22 Chong Yidong <cyd@stupidchicken.com>
5555
5556 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5557
4d8ade89
YM
55582011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5559
5560 * dispnew.c (scrolling_window): Don't exclude the case that the
5561 last enabled row in the desired matrix touches the bottom boundary.
5562
32078c8d
GM
55632011-05-21 Glenn Morris <rgm@gnu.org>
5564
5565 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5566 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5567 and add some more files.
32078c8d 5568
7285dc67
EZ
55692011-05-20 Eli Zaretskii <eliz@gnu.org>
5570
5571 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5572 report_file_error introduced by the change from 2011-05-07.
5573
89d1bd22
PE
55742011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5575
5576 * systime.h (Time): Define only if emacs is defined.
5577 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5578 where the include path doesn't have X11/X.h by default. See
5579 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5580
e23640bb 55812011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5582
5583 * composite.c (find_automatic_composition): Fix previous change.
5584
b9704ad9
GM
55852011-05-20 Glenn Morris <rgm@gnu.org>
5586
5587 * lisp.mk: New file, split from Makefile.in.
5588 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5589 (shortlisp): Remove.
5590 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5591
4a720484
GM
55922011-05-19 Glenn Morris <rgm@gnu.org>
5593
5594 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5595 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5596 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5597 (lisp): Set the order to that of loadup.el.
5598 (shortlisp): Make it a copy of $lisp.
5599 (SOME_MACHINE_LISP): Remove.
5600 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5601 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5602
a28d4396
KH
56032011-05-18 Kenichi Handa <handa@m17n.org>
5604
5605 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5606 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5607 (find_automatic_composition): Mostly rewrite for efficiency.
5608
a2b1fa8e
JB
56092011-05-18 Juanma Barranquero <lekktu@gmail.com>
5610
5611 * makefile.w32-in: Update dependencies.
5612
8e1f5610
CS
56132011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5614
5615 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5616 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5617
7025ee00 56182011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5619
cdfa6eab
PE
5620 Fix some integer overflow issues, such as string length overflow.
5621
06d6db33
PE
5622 * insdel.c (count_size_as_multibyte): Check for string overflow.
5623
2b4560a8
PE
5624 * character.c (lisp_string_width): Check for string overflow.
5625 Use EMACS_INT, not int, for string indexes and lengths; in
5626 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5627 the resulting string length overflows an EMACS_INT; instead,
5628 report a string overflow if no precision given. When checking for
5629 precision exhaustion, use a check that cannot possibly have
5630 integer overflow. (Bug#8675)
5631 * character.h (lisp_string_width): Adjust to new signature.
5632
cb93f9be
PE
5633 * alloc.c (string_overflow): New function.
5634 (Fmake_string): Use it. This doesn't change behavior, but saves
5635 a few bytes and will simplify future changes.
5636 * character.c (string_escape_byte8): Likewise.
5637 * lisp.h (string_overflow): New decl.
5638
1a1f3366
PE
5639 Fixups, following up to the user-interface timestamp change.
5640 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5641 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5642 * msdos.c (mouse_get_pos): Likewise.
5643 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5644 * w32gui.h (Time): Define by including "systime.h" rather than by
5645 declaring it ourselves. (Bug#8664)
5646
d4e3e4d3
PE
5647 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5648 * image.c (clear_image_cache): Likewise.
5649
f6a24d19
PE
5650 * term.c (term_mouse_position): Don't assume time_t wraparound.
5651
08dc5ae6
PE
5652 Be more systematic about user-interface timestamps.
5653 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5654 and sometimes 'EMACS_UINT', to represent these timestamps.
5655 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5656 This makes the code easier to follow, and makes it easier to catch
5657 integer overflow bugs such as Bug#8664.
5658 * frame.c (Fmouse_position, Fmouse_pixel_position):
5659 Use Time, not unsigned long, for user-interface timestamps.
5660 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5661 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5662 * keyboard.h (last_event_timestamp): Likewise.
5663 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5664 * menu.h (xmenu_show): Likewise.
5665 * term.c (term_mouse_position): Likewise.
5666 * termhooks.h (struct input_event.timestamp): Likewise.
5667 (struct terminal.mouse_position_hook): Likewise.
5668 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5669 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5670 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5671 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5672 what it was before.
5673 * menu.h, termhooks.h: Include "systime.h", for Time.
5674
8e55734a
PE
5675 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5676 Don't assume that the difference between two unsigned long values
5677 can fit into an integer. At this point, we know button_down_time
5678 <= event->timestamp, so the difference must be nonnegative, so
5679 there's no need to cast the result if double-click-time is
5680 nonnegative, as it should be; check that it's nonnegative, just in
5681 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5682 apart (about 25 days). (Bug#8664)
8e55734a 5683
841f1b75 5684 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5685 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5686
3e26f69c
PE
5687 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5688 that always fit in int. Use a sentinel instead of a counter, to
5689 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5690 * frame.h (struct frame): Use int for menu_bar_items_used
5691 instead of EMACS_INT, since it always fits in int.
3e26f69c 5692
5cc152c0
PE
5693 * menu.c (grow_menu_items): Check for int overflow.
5694
d89eb65e
PE
5695 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5696
5235bd3e
PE
5697 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5698 Before, the code was not consistent. These values cannot exceed
5699 2**31 - 1 so there's no need to make them unsigned.
5700 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5701 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5702 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5703 as modifiers.
5704 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5705
bc827e23
PE
5706 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5707 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5708 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5709 presumably because the widths might not match.
5710
78eb494e
PE
5711 * window.c (size_window): Avoid needless test at loop start.
5712
04f2d78b
CB
57132011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5714
5715 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5716
d2fc7e3d 57172011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5718
5719 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5720
d2fc7e3d 57212011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5722
5723 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5724 `width' to `bar_area_x' and `bar_area_width', respectively.
5725 (x_scroll_run): Take account of fringe background extension.
5726
04f2d78b
CB
5727 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5728 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5729 `bar_area_width', respectively.
5730 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5731 background extension.
5732
79b70037
GM
57332011-05-10 Jim Meyering <meyering@redhat.com>
5734
5735 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5736
2f142cc5
JB
57372011-05-10 Juanma Barranquero <lekktu@gmail.com>
5738
5739 * image.c (Finit_image_library): Return t for built-in image types,
5740 like pbm and xbm. (Bug#8640)
5741
57679c86
AS
57422011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5743
5744 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5745
888c9e86
EZ
57462011-05-07 Eli Zaretskii <eliz@gnu.org>
5747
b0512a1d
EZ
5748 * w32console.c (Fset_screen_color): Doc fix.
5749 (Fget_screen_color): New function.
5750 (syms_of_ntterm): Defsubr it.
5751
7285dc67
EZ
5752 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5753 unlink the temporary file if Fcall_process didn't create it in the
5754 first place.
5755 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5756 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5757 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5758 cue to call_process_cleanup not to close that handle.
5759
4d3fcc8e
BK
57602011-05-07 Ben Key <bkey76@gmail.com>
5761
5762 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5763 one of two shell specific rules, either bootstrap-temacs-CMD or
5764 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5765 to the previous implementation of the bootstrap-temacs rule.
5766 The bootstrap-temacs-CMD rule is similar to the previous
5767 implementation of the bootstrap-temacs rule except that it
5768 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5769 variable.
5770
5771 These changes, along with some changes to nt/configure.bat,
5772 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5773 earlier fix to add support for --cflags and --ldflags options
5774 that include quotes so that it works whether make uses cmd or
5775 sh as the shell.
5776
b4289b64
MA
57772011-05-06 Michael Albinus <michael.albinus@gmx.de>
5778
5779 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5780 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5781 is a constant.
5782 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5783 a string. Handle both cases.
5784 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5785 (Fdbus_register_method): Use Qinvalid_function.
5786
af4c0e28
JB
57872011-05-06 Juanma Barranquero <lekktu@gmail.com>
5788
5789 * makefile.w32-in: Update dependencies.
5790 (LISP_H): Add inttypes.h and stdin.h.
5791 (PROCESS_H): Add unistd.h.
5792
c51453d9
EZ
57932011-05-06 Eli Zaretskii <eliz@gnu.org>
5794
5795 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5796 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5797
8ff0ac3c 57982011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5799
4c4b566b
PE
5800 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5801
aab2b9b5
PE
5802 * term.c (vfatal): Remove stray call to va_end.
5803 It's not needed and the C Standard doesn't allow it here anyway.
5804
c378da0b
PE
5805 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5806 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5807
288b08c7
PE
5808 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5809 bytes.
5810
e3601888
PE
5811 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5812
db6c0e74
PE
5813 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5814
dd5963ea
PE
5815 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5816
88c9450f
PE
5817 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5818
2f9442b8
PE
5819 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5820
c032b5f8
PE
5821 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5822 * charset.c (Fdefine_charset_internal): Don't initialize
5823 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5824 32-bit int (Bug#8600).
a108c10b
PE
5825
5826 * lread.c (read_integer): Be more consistent with string-to-number.
5827 Use string_to_number to do the actual conversion; this avoids
5828 rounding errors and fixes some other screwups. Without this fix,
5829 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5830 (digit_to_number): Move earlier, for benefit of read_integer.
5831 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5832 not a digit in any supported base. (Bug#8602)
a108c10b 5833
ad5f9eea
PE
5834 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5835
aec1708a
PE
5836 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5837 to match comment at start of function. This also removes a
5838 GCC warning about overflow in a 32+64-bit port.
5839
47be4ab5
PE
5840 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5841
371cac43
PE
5842 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5843 Reported by Stefan Monnier in
5844 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5845 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5846 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5847
d01a7826
PE
5848 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5849 (EMACS_UINTPTR): Likewise, with uintptr_t.
5850
7fd47d5c
PE
5851 * lisp.h: Prefer 64-bit EMACS_INT if available.
5852 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5853 on 32-bit hosts that have 64-bit int, so that they can access
5854 large files.
122b0c86
PE
5855 However, temporarily disable this change unless the temporary
5856 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5857
8727937b
PE
5858 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5859
8ac068ac
PE
5860 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5861 This removes an assumption that EMACS_INT and long are the same
5862 width as pointers. The assumption is true for Emacs porting targets
5863 now, but we want to make other targets possible.
5864 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5865 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5866 In the rest of the code, change types of integers that hold casted
5867 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5868 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5869 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5870 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5871 No need to cast type when ORing.
5872 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5873 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5874 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5875 assume EMACS_INT is the same width as char *.
5876 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5877 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5878 Remove no-longer-needed casts.
5879 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5880 (xg_tool_bar_help_callback, xg_make_tool_item):
5881 Use EMACS_INTPTR to hold an integer
5882 that will be cast to void *; this can avoid a GCC warning
5883 if EMACS_INT is not the same width as void *.
5884 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5885 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5886 (current_message_1, set_message_1):
5887 Use a local to convert to proper width without a cast.
5888 * xmenu.c (dialog_selection_callback): Likewise.
5889
ede49d71
PE
5890 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5891 Also, don't assume VALBITS / RAND_BITS is less than 5,
5892 and don't rely on undefined behavior when shifting a 1 left into
5893 the sign bit.
5894 * lisp.h (get_random): Change signature to match.
5895
2f30ecd0
PE
5896 * lread.c (hash_string): Use size_t, not int, for hash computation.
5897 Normally we prefer signed values; but hashing is special, because
5898 it's better to use unsigned division on hash table sizes so that
5899 the remainder is nonnegative. Also, size_t is the natural width
5900 for hashing into memory. The previous code used 'int', which doesn't
5901 retain enough info to hash well into very large tables.
5902 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5903
2a866e7b
PE
5904 * dbusbind.c: Don't possibly lose pointer info when converting.
5905 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5906 Use XPNTR rather than XHASH, so that the high-order bits of
5907 the pointer aren't lost when converting through void *.
5908
51639eac
PE
5909 * eval.c (Fautoload): Don't double-shift a pointer.
5910
92394119
PE
5911 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5912
dbdb9a7c
JB
59132011-05-06 Juanma Barranquero <lekktu@gmail.com>
5914
5915 * gnutls.c (DEF_GNUTLS_FN):
5916 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5917
db7a0b4f
AS
59182011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5919
5920 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5921 marker. (Bug#8610)
5922
f7ff1b0f 59232011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5924
5925 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5926 New version that can reserve upto 2GB of heap space.
5927
f7ff1b0f 59282011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5929
5930 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5931
639c109b
TZ
59322011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5933
5934 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5935 `gnutls_certificate_set_x509_key_file'.
5936
d2127135
JB
59372011-05-05 Juanma Barranquero <lekktu@gmail.com>
5938
5939 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5940 Update dependencies.
5941
e968f4f3
JB
59422011-05-04 Juanma Barranquero <lekktu@gmail.com>
5943
5944 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5945 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5946 Remove unused parameter `fildes'.
5947 * process.c (read_process_output, send_process): Don't pass it.
5948
84d358f0
JB
59492011-05-04 Juanma Barranquero <lekktu@gmail.com>
5950
5951 Fix previous change: the library cache is defined in w32.c.
5952 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5953 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5954
0898ca10
JB
59552011-05-04 Juanma Barranquero <lekktu@gmail.com>
5956
5957 Implement dynamic loading of GnuTLS on Windows.
5958
5959 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5960 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5961 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5962 Declare.
5963
5964 * gnutls.c (Qgnutls_dll): Define.
5965 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5966 (gnutls_*): Declare function pointers.
5967 (init_gnutls_functions): New function to initialize function pointers.
5968 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5969 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5970 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5971 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5972 (emacs_gnutls_write, emacs_gnutls_read)
5973 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5974 (Fgnutls_available_p): New function.
5975 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5976 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5977 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5978
5979 * image.c: Include w32.h.
5980 (Vimage_type_cache): Delete.
5981 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5982 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5983 (w32_delayed_load): Move to w32.c.
5984
5985 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5986
5987 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5988 (w32_delayed_load): Move from image.c. When loading a library, record
5989 its filename in the :loaded-from property of the library id.
5990 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5991 Initialize and staticpro them.
5992 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5993
5994 * process.c: Include lisp.h before w32.h, not after.
5995 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5996 instead of gnutls_record_check_pending.
5997
5998 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5999
ff4de4aa
TZ
60002011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6001
6002 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6003 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6004 as passed in.
6005
abe95abb
JD
60062011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6007
6008 * xterm.c (x_set_frame_alpha): Do not set property on anything
6009 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6010
e16e55d4
JB
60112011-05-02 Juanma Barranquero <lekktu@gmail.com>
6012
6013 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6014
bafcf6a5
JB
60152011-05-02 Juanma Barranquero <lekktu@gmail.com>
6016
6017 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6018 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6019 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6020 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6021 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6022 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6023 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6024 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6025 (Qgnutls_bootprop_callbacks_verify): Make static.
6026
e7a6747f
AS
60272011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6028
19ed11ba
AS
6029 * callproc.c: Indentation fixup.
6030
e7a6747f 6031 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6032 (wait_for_termination, interruptible_wait_for_termination):
6033 Move after wait_for_termination_1.
e7a6747f 6034
1ef14cb4
LMI
60352011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6036
6037 * sysdep.c (interruptible_wait_for_termination): New function
6038 which is like wait_for_termination, but allows keyboard
6039 interruptions.
6040
6041 * callproc.c (Fcall_process): Add (:file "file") as an option for
6042 the STDOUT buffer.
6043 (Fcall_process_region): Ditto.
6044
330d880c
EZ
60452011-04-30 Eli Zaretskii <eliz@gnu.org>
6046
8db90b73
EZ
6047 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6048 rather than `XVECTOR (FOO)->size'.
6049
330d880c
EZ
6050 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6051 inttypes.h, as a gnulib replacement is used if it not available in
6052 system headers.
6053
15cbd324
EZ
60542011-04-21 Eli Zaretskii <eliz@gnu.org>
6055
6056 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6057 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6058 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6059
6060 * coding.c (coding_alloc_by_realloc): Error out if destination
6061 will grow beyond MOST_POSITIVE_FIXNUM.
6062 (decode_coding_emacs_mule): Abort if there isn't enough place in
6063 charbuf for the composition carryover bytes. Reserve an extra
6064 space for up to 2 characters produced in a loop.
6065 (decode_coding_iso_2022): Abort if there isn't enough place in
6066 charbuf for the composition carryover bytes.
6067
60682011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6069
ae940cca
EZ
6070 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6071 aborting when %lld or %lll format is passed.
6072 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6073 %llo or %llx format is passed. (Bug#8545)
6074
03ab8921
EZ
6075 * window.c (window_scroll_line_based): Use a marker instead of
6076 simple variables to record original value of point. (Bug#7952)
6077
afda1437
EZ
6078 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6079 produced by %s or %c overflows available buffer space. (Bug#8545)
6080
f76dee0c
PE
60812011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6082
6083 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6084 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6085
fdc5744d
JB
60862011-04-28 Juanma Barranquero <lekktu@gmail.com>
6087
6088 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6089
638f053a
JB
60902011-04-28 Juanma Barranquero <lekktu@gmail.com>
6091
6092 * keyboard.c (Qdelayed_warnings_hook): Define.
6093 (command_loop_1): Run `delayed-warnings-hook'
6094 if Vdelayed_warnings_list is non-nil.
6095 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6096 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6097
d178f871
EZ
60982011-04-28 Eli Zaretskii <eliz@gnu.org>
6099
6100 * doprnt.c (doprnt): Don't return value smaller than the buffer
6101 size if the message was truncated. (Bug#8545).
6102
b124fd93
JB
61032011-04-28 Juanma Barranquero <lekktu@gmail.com>
6104
6105 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6106 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6107
e810457d
PE
61082011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6109
6110 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6111
ea51cceb
JB
61122011-04-27 Juanma Barranquero <lekktu@gmail.com>
6113
6114 * makefile.w32-in: Update dependencies.
6115
94dcfacf
EZ
61162011-04-27 Eli Zaretskii <eliz@gnu.org>
6117
6118 Improve `doprnt' and its usage. (Bug#8545)
6119 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6120 `format_end'. Remove support for %l as a conversion specifier.
6121 Don't use xrealloc. Improve diagnostics when the %l size modifier
6122 is used. Update the commentary.
6123
6124 * eval.c (verror): Simplify calculation of size_t.
6125
6126 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6127 messages.
6128
f61f41d7
PE
61292011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6130
6131 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6132 change.
6133
96fb4434
PE
61342011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6135
6136 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6137 This makes this file independent of the recent pseudovector change.
6138
671875da 61392011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6140
69e9b5a3
PE
6141 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6142
b5f869a7 6143 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6144 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6145 Remove unused local.
c8926152 6146 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6147
841a1577 6148 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6149 GCC 4.6.0 optimizes based on type-based alias analysis.
6150 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6151 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6152 != &v->size, and therefore "v->size = 1; b->size = 2; return
6153 v->size;" must therefore return 1. This assumption is incorrect
6154 for Emacs, since it type-puns struct Lisp_Vector * with many other
6155 types. To fix this problem, this patch adds a new type struct
f904488f 6156 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6157 and pseudovectors, and helps optimizing compilers not get fooled
6158 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6159 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6160 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6161 the size member.
eab3844f
PE
6162 (XSETPVECTYPE): Rewrite in terms of new macro.
6163 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6164 This is a bit clearer, and further avoids the possibility of
6165 undesirable aliasing.
6166 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6167 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6168 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6169 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6170 (ASIZE): Now uses header.size rather than size.
6171 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6172 to avoid the hassle of writing XVECTOR (foo)->header.size.
6173 (struct vectorlike_header): New type.
eab3844f
PE
6174 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6175 object, to help avoid aliasing.
6176 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6177 (SUBRP): Likewise, since Lisp_Subr is a special case.
6178 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6179 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6180 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6181 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6182 changed to be "header.size" and "header.next".
6183 * buffer.h (struct buffer): Likewise.
6184 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6185 * frame.h (struct frame): Likewise.
6186 * process.h (struct Lisp_Process): Likewise.
6187 * termhooks.h (struct terminal): Likewise.
6188 * window.c (struct save_window_data, struct saved_window): Likewise.
6189 * window.h (struct window): Likewise.
6190 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6191 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6192 * buffer.c (init_buffer_once): Likewise.
6193 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6194 special case.
6195 * process.c (Fformat_network_address): Use local var for size,
6196 for brevity.
6197
0df1eac5
PE
6198 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6199
847ab9d1 6200 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6201 * data.c (atof): Remove decl; no longer used or needed.
6202 (digit_to_number): Move to lread.c.
6203 (Fstring_to_number): Use new string_to_number function, to be
6204 consistent with how the Lisp reader treats infinities and NaNs.
6205 Do not assume that floating-point numbers represent EMACS_INT
6206 without losing information; this is not true on most 64-bit hosts.
6207 Avoid double-rounding errors, by insisting on integers when
6208 parsing non-base-10 numbers, as the documentation specifies.
6209 * lisp.h (string_to_number): New decl, replacing ...
6210 (isfloat_string): Remove.
bc0a5c13 6211 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6212 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6213 appears to have been a coding error. Similarly, do not accept
6214 strings like +-1e0 as floating point numbers. Do not report
6215 overflow for integer overflows unless the base is not 10 which
6216 means we have no simple and reliable way to continue.
6217 Break out the floating-point parsing into a new
6218 function string_to_number, so that Fstring_to_number parses
6219 floating point numbers consistently with the Lisp reader.
04f2d78b 6220 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6221 (E_CHAR, EXP_INT): Remove, replacing with ...
6222 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6223 (string_to_number): New function, replacing isfloat_string.
6224 This function checks for valid syntax and produces the resulting
6225 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6226 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6227 so that overflow for non-base-10 numbers is reported only when
6228 there's no portable and simple way to convert to floating point.
452f4150 6229
67769ffc
PE
6230 * textprop.c (set_text_properties_1): Rewrite for clarity,
6231 and to avoid GCC warning about integer overflow.
6232
c20db43f
PE
6233 * intervals.h (struct interval): Use EMACS_INT for members
6234 where EMACS_UINT might cause problems. See
6235 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6236 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6237 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6238 All uses changed.
37aa2f85
PE
6239 (offset_intervals): Tell GCC not to worry about length overflow
6240 when negating a negative length.
c20db43f 6241
2538aa2f
PE
6242 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6243 (overrun_check_free): Likewise.
6244
f2d3008d
PE
6245 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6246 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6247 word size.
6248
ec8df744
PE
6249 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6250 (gnutls_make_error): Rename local to avoid shadowing.
6251 (gnutls_emacs_global_deinit): ifdef out; not used.
6252 (Fgnutls_boot): Use const for pointer to readonly storage.
6253 Comment out unused local. Fix pointer signedness problems.
6254
640ee02d
PE
6255 * lread.c (openp): Don't stuff size_t into an 'int'.
6256 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6257 about possible signed overflow.
6258
6048fb2a
PE
6259 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6260 (GDK_KEY_g): Don't define if already defined.
6261 (xg_prepare_tooltip): Avoid pointer signedness problem.
6262 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6263
fa3c87e1
PE
6264 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6265 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6266
2172544b
PE
6267 * xfns.c (Fx_window_property): Simplify a bit,
6268 to make a bit faster and to avoid GCC 4.6.0 warning.
6269 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6270
9b821a21
PE
6271 * fns.c (internal_equal): Don't assume size_t fits in int.
6272
3c616cfa
PE
6273 * alloc.c (compact_small_strings): Tighten assertion a little.
6274
c2982e87
PE
6275 Replace pEd with more-general pI, and fix some printf arg casts.
6276 * lisp.h (pI): New macro, generalizing old pEd macro to other
6277 conversion specifiers. For example, use "...%"pI"d..." rather
6278 than "...%"pEd"...".
6279 (pEd): Remove. All uses replaced with similar uses of pI.
6280 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6281 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6282 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6283 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6284 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6285 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6286 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6287 64-bit hosts.
6288 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6289 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6290 * print.c (safe_debug_print, print_object): Likewise.
6291 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6292 to int.
6f04d126
PE
6293 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6294 avoiding the 0 flag, which is not portable.
c2982e87
PE
6295 * process.c (Fmake_network_process): Use pI to avoid cast.
6296 * region-cache.c (pp_cache): Likewise.
6297 * xdisp.c (decode_mode_spec): Likewise.
6298 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6299 behavior on 64-bit hosts with printf arg.
6f04d126 6300 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6301 (x_stop_queuing_selection_requests): Likewise.
6302 (x_get_window_property): Don't truncate byte count to an 'int'
6303 when tracing.
0b432f21 6304
5e073ec7
PE
6305 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6306 here, since it parses constructs like leading '-' and spaces,
6307 which are not wanted; and it overflows with large numbers.
6308 Instead, simply match F[0-9]+, which is what is wanted anyway.
6309
36372bf9
PE
6310 * alloc.c: Remove unportable assumptions about struct layout.
6311 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6312 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6313 (allocate_vectorlike, make_pure_vector): Use the new macros,
6314 plus offsetof, to remove unportable assumptions about struct layout.
6315 These assumptions hold on all porting targets that I know of, but
6316 they are not guaranteed, they're easy to remove, and removing them
6317 makes further changes easier.
6318
0b432f21
PE
6319 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6320 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6321 (string_overrun_cookie): Now const. Use initializers that
6322 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6323 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6324 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6325 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6326 multiple of sizeof (EMACS_INT); it need not be, if
6327 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6328 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6329
895009e1
JB
63302011-04-26 Juanma Barranquero <lekktu@gmail.com>
6331
6332 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6333
6a7a1b0b
TZ
63342011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6335
6336 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6337 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6338 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6339
841a1577 63402011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6341
6342 * lisp.h (Qdebug): List symbol.
895009e1 6343 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6344 * keyboard.c (debug-on-event): New variable.
6345 (handle_user_signal): Break into debugger when debug-on-event
6346 matches the current signal symbol.
6347
f2d3ba6f
DN
63482011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6349
6350 * alloc.c (check_sblock, check_string_bytes)
6351 (check_string_free_list): Convert to standard C.
6352
42ce4c63
TZ
63532011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6354
6355 * w32.c (emacs_gnutls_push): Fix typo.
6356
825cd63c
EZ
63572011-04-25 Eli Zaretskii <eliz@gnu.org>
6358
fb11d64d
EZ
6359 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6360 "cast to pointer from integer of different size".
6361
825cd63c
EZ
6362 Improve doprnt and its use in verror. (Bug#8545)
6363 * doprnt.c (doprnt): Document the set of format control sequences
6364 supported by the function. Use SAFE_ALLOCA instead of always
6365 using `alloca'.
6366
6367 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6368 is one byte too soon. Don't use xrealloc; instead xfree and
6369 xmalloc anew.
6370
e061a11b
TZ
63712011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6372
6373 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6374 callbacks stage.
6375
6376 * gnutls.c: Renamed global_initialized to
6377 gnutls_global_initialized. Added internals for the
6378 :verify-hostname-error, :verify-error, and :verify-flags
6379 parameters of `gnutls-boot' and documented those parameters in the
6380 docstring. Start callback support.
9173deec
JB
6381 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6382 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6383 on error. Return error code.
e061a11b
TZ
6384 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6385 (emacs_gnutls_read): Likewise.
6386 (Fgnutls_boot): Return handshake error code.
6387 (emacs_gnutls_handle_error): New function.
6388 (wsaerror_to_errno): Likewise.
6389
6390 * w32.h (emacs_gnutls_pull): Add prototype.
6391 (emacs_gnutls_push): Likewise.
6392
6393 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6394 (emacs_gnutls_push): Likewise.
6395
63962011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6397
6398 * process.c (wait_reading_process_output): Check if GnuTLS
6399 buffered some data internally if no FDs are set for TLS
6400 connections.
6401
6402 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6403 (LIBS): Link to USER_LIBS.
6404 ($(BLD)/gnutls.$(0)): New target.
6405
fa6996bc
EZ
64062011-04-24 Eli Zaretskii <eliz@gnu.org>
6407
eb35682e
EZ
6408 * xdisp.c (handle_single_display_spec): Rename the
6409 display_replaced_before_p argument into display_replaced_p, to
6410 make it consistent with the commentary. Fix typos in the
6411 commentary.
6412
e2ad650c
EZ
6413 * textprop.c (syms_of_textprop): Remove dead code.
6414 (copy_text_properties): Delete obsolete commentary about an
6415 interface that was deleted long ago. Fix typos in the description
6416 of arguments.
6417
1b2de274
EZ
6418 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6419 to changes in oldXMenu/XMenu.h from 2011-04-16.
6420 <menu_help_message, prev_menu_help_message>: Constify.
6421 (IT_menu_make_room): menu->help_text is now `const char **';
6422 adjust.
6423
6424 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6425 to changes in oldXMenu/XMenu.h from 2011-04-16.
6426 (struct XMenu): Declare `help_text' `const char **'.
6427
6428 * xfaces.c <Qunspecified>: Make extern again.
6429
6430 * syntax.c: Include sys/types.h before including regex.h, as
6431 required by Posix.
6432
762b15be
EZ
6433 * doc.c (get_doc_string): Improve the format passed to `error'.
6434
6435 * doprnt.c (doprnt): Improve commentary.
6436
6437 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6438
6439 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6440 them with etags.
6441
f1052e5d
EZ
6442 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6443 changes in globals.h immediately force recompilation.
762b15be
EZ
6444 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6445 $(CURDIR)/s/ms-w32.h.
6446 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6447
fa6996bc
EZ
6448 * character.c (Fchar_direction): Function deleted.
6449 (syms_of_character): Don't defsubr it.
6450 <char-direction-table>: Deleted.
6451
e6c3da20
EZ
64522011-04-23 Eli Zaretskii <eliz@gnu.org>
6453
6454 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6455 * doprnt.c: Include limits.h.
6456 (SIZE_MAX): New macro.
04f2d78b
CB
6457 (doprnt): Return a size_t value. 2nd arg is now size_t.
6458 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6459 Improve overflow protection. Support `l' modifier for integer
6460 conversions. Support %l conversion. Don't assume an EMACS_INT
6461 argument for integer conversions and for %c.
6462
6463 * lisp.h (doprnt): Restore prototype.
6464
6465 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6466 $(SRC)/character.h.
6467
6468 * Makefile.in (base_obj): Add back doprnt.o.
6469
6470 * deps.mk (doprnt.o): Add back prerequisites.
6471 (callint.o): Depend on character.h.
6472
6473 * eval.c (internal_lisp_condition_case): Include the handler
6474 representation in the error message.
6475 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6476 when breaking from the loop.
6477
6478 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6479
6480 * callint.c (Fcall_interactively): When displaying error message
6481 about invalid control letter, pass the character's codepoint, not
6482 a pointer to its multibyte form. Improve display of the character
6483 in octal and display also its hex code.
6484
6485 * character.c (char_string): Use %x to display the (unsigned)
6486 codepoint of an invalid character, to avoid displaying a bogus
6487 negative value.
6488
6489 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6490 `error', not SYMBOL_NAME itself.
6491
6492 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6493 character arguments to `error'.
6494
6495 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6496 to `error' in error message about FINAL_CHAR argument. Make sure
6497 FINAL_CHAR is a character, and use %c when it is passed as
6498 argument to `error'.
6499
4ffd0d6b 65002011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6501
6502 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6503
6504 * w32.c: Include <time.h>.
6505 (sys_localtime): New function.
6506
4ffd0d6b 65072011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6508
6509 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6510
4ffd0d6b 6511 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6512
4ffd0d6b 65132011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6514
4ffd0d6b
GM
6515 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6516 zombies (Bug#8467).
aac0c6e3 6517
04c56954
EZ
65182011-04-19 Eli Zaretskii <eliz@gnu.org>
6519
6520 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6521 gl_state.e_property when gl_state.object is Qt.
6522
6523 * insdel.c (make_gap_larger): Remove limitation of buffer size
6524 to <= INT_MAX.
6525
16a43933
CY
65262011-04-18 Chong Yidong <cyd@stupidchicken.com>
6527
6528 * xdisp.c (lookup_glyphless_char_display)
6529 (produce_glyphless_glyph): Handle cons cell entry in
6530 glyphless-char-display.
6531 (Vglyphless_char_display): Document it.
6532
6533 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6534 glyphless-char-display.
6535
4581706e
CY
65362011-04-17 Chong Yidong <cyd@stupidchicken.com>
6537
6538 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6539
6540 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6541
6542 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6543 definition for no-X builds.
6544
4887c6e2 65452011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6546
fd35b6f9
PE
6547 Static checks with GCC 4.6.0 and non-default toolkits.
6548
5c1ccb01
PE
6549 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6550
006c5daa
PE
6551 * process.c (keyboard_bit_set): Define only if SIGIO.
6552 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6553 (send_process): Repair possible setjmp clobbering.
6554
efc736d3
PE
6555 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6556
4e2fe2e6
PE
6557 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6558
f97334a2
PE
6559 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6560
4e75f29d
PE
6561 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6562 Define only if needed.
6563
90efadd1
PE
6564 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6565 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6566 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6567
3c647824
PE
6568 * dispextern.h (struct redisplay_interface): Rename param
6569 to avoid shadowing.
e264f262 6570 * termhooks.h (struct terminal): Likewise.
761383f4 6571 * xterm.c (xembed_send_message): Likewise.
3c647824 6572
b58c5c4a
PE
6573 * insdel.c (make_gap_smaller): Define only if
6574 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6575
cad59032
PE
6576 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6577 it.
6578
c339dc2e
PE
6579 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6580 so that we aren't warned about unused symbols.
6581
91a3e27b
PE
6582 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6583
399c71d3 6584 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6585
8ffc96f5
PE
6586 * xfns.c (x_real_positions): Mark locals as initialized.
6587
eef9bc79
PE
6588 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6589
098db9dd
PE
6590 * xterm.c: Fix problems found by static analysis with other toolkits.
6591 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6592 (x_dispatch_event): Declare static if USE_GTK, and
6593 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6594 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6595 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6596 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6597 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6598
eb18f6cc
PE
6599 * xmenu.c (menu_help_callback): Pointer type fixes.
6600 Use const pointers when pointing at readonly data. Avoid pointer
6601 signedness clashes.
6602 (FALSE): Remove unused macro.
6603 (update_frame_menubar): Remove unused decl.
6604
1fe72bf8
PE
6605 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6606
60d9e1db
PE
6607 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6608 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6609 (single_menu_item): Rename local to avoid shadowing.
6610
39261c26
PE
6611 * keyboard.c (make_lispy_event): Remove unused local var.
6612
018c5e19
PE
6613 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6614 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6615
63d2b86e
PE
6616 * bitmaps: Change bitmaps from unsigned char back to the X11
6617 compatible char. Avoid the old compiler warnings about
6618 out-of-range initializers by using, for example, '\xab' rather
6619 than 0xab.
6620
aefd87e1
PE
6621 * xgselect.c (xgselect_initialize): Check vs interface
6622 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6623
bf501fb9
PE
6624 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6625
e9829fdf
PE
6626 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6627 to read-only memory.
6628
1086c095
PE
6629 * fns.c (vector): Remove; this old hack is no longer needed.
6630
2baccd04 6631 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6632 Remove unused var.
dde42981 6633 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6634
72391843 6635 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6636
436c16df 6637 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6638 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6639 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6640
92bb796d 6641 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6642 (x_term_init): Remove local to avoid shadowing.
92bb796d 6643
764430a3 6644 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6645
6646 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6647 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6648
d1dfb56c
EZ
66492011-04-16 Eli Zaretskii <eliz@gnu.org>
6650
c4354cb4
EZ
6651 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6652
d1dfb56c
EZ
6653 Fix regex.c, syntax.c and friends for buffers > 2GB.
6654 * syntax.h (struct gl_state_s): Declare character position members
6655 EMACS_INT.
6656
6657 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6658
04f2d78b
CB
6659 * textprop.c (verify_interval_modification, interval_of):
6660 Declare arguments EMACS_INT.
d1dfb56c
EZ
6661
6662 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6663 EMACS_INT.
6664
6665 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6666
6667 * indent.c (Fvertical_motion): Local variable it_start is now
6668 EMACS_INT.
6669
6670 * regex.c (re_match, re_match_2, re_match_2_internal)
6671 (bcmp_translate, regcomp, regexec, print_double_string)
6672 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6673 (re_compile_pattern, re_exec): Declare arguments and local
6674 variables `size_t' and `ssize_t' and return values `regoff_t', as
6675 appropriate.
6676 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6677 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6678 <compile_stack_type>: `size' and `avail' are now `size_t'.
6679
6680 * regex.h <regoff_t>: Use ssize_t, not int.
6681 (re_search, re_search_2, re_match, re_match_2): Arguments that
6682 specify buffer/string position and length are now ssize_t and
6683 size_t. Return type is regoff_t.
6684
613052cd
BK
66852011-04-16 Ben Key <bkey76@gmail.com>
6686
6687 * nsfont.m: Fixed bugs in ns_get_family and
6688 ns_descriptor_to_entity that were caused by using free to
6689 deallocate memory blocks that were allocated by xmalloc (via
6690 xstrdup). This caused Emacs to crash when compiled with
6691 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6692 --enable-checking=xmallocoverrun). xfree is now used to
6693 deallocate these memory blocks.
6694
4170f62f 66952011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6696
71b41406
PE
6697 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6698
9587a89d
PE
6699 emacs_write: Accept and return EMACS_INT for sizes.
6700 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6701 et seq.
6702 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6703 Accept and return EMACS_INT.
6704 (emacs_gnutls_write): Return the number of bytes written on
6705 partial writes.
6706 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6707 (emacs_read, emacs_write): Remove check for negative size, as the
6708 Emacs source code has been audited now.
9587a89d
PE
6709 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6710 (emacs_read, emacs_write): Use it.
273a5f82
PE
6711 * process.c (send_process): Adjust to the new signatures of
6712 emacs_write and emacs_gnutls_write. Do not attempt to store
6713 a byte offset into an 'int'; it might overflow.
9587a89d 6714 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6715
3e047f51
PE
6716 * sound.c: Don't assume sizes fit in 'int'.
6717 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6718 Return EMACS_INT, not int.
3e047f51 6719 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6720 Accept EMACS_INT, not int.
6721 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6722 record read return values.
6723
cc39a9db
BK
67242011-04-15 Ben Key <bkey76@gmail.com>
6725
c9d0ec6d
JB
6726 * keyboard.c (Qundefined): Don't declare static since it is used
6727 in nsfns.m.
6728 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6729 static since they are used in nsfont.m.
cc39a9db 6730
6c60eb9f
SM
67312011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6732
6733 * process.c (Qprocessp): Don't declare static.
6734 * lisp.h (Qprocessp): Declare again.
6735
7990b61a
JB
67362011-04-15 Juanma Barranquero <lekktu@gmail.com>
6737
6738 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6739
5d4cb038
PE
67402011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6741
8bd7b830 6742 Improve C-level modularity by making more things 'static'.
cd64ea1d 6743
e3b27b31
PE
6744 Don't publish debugger-only interfaces to other modules.
6745 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6746 (verify_bytepos, count_markers): Move decls to the only modules
6747 that need them.
6748 * region-cache.h (pp_cache): Likewise.
6749 * window.h (check_all_windows): Likewise.
6750 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6751
5d4cb038
PE
6752 * sysdep.c (croak): Now static, if
6753 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6754 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6755
6756 * alloc.c (refill_memory_reserve): Now static if
6757 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6758 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6759
e87b6180
PE
6760 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6761 Define only if USE_LUCID.
6762
ac64929e
PE
6763 * xrdb.c (x_customization_string, x_rm_string): Now static.
6764
6f37259d
PE
6765 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6766 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6767
1683e3ab
PE
6768 * xdisp.c (draw_row_with_mouse_face): Now static.
6769 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6770
de9c2632
PE
6771 * window.h (check_all_windows): Mark externally visible.
6772
2b96acb7
PE
6773 * window.c (window_deletion_count): Now static.
6774
6775 * undo.c: Make symbols static if they're not exported.
6776 (last_undo_buffer, last_boundary_position, pending_boundary):
6777 Now static.
6778
50436f33
PE
6779 * textprop.c (interval_insert_behind_hooks): Now static.
6780 (interval_insert_in_front_hooks): Likewise.
6781
64520e5c
PE
6782 * term.c: Make symbols static if they're not exported.
6783 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6784 (max_frame_lines, tty_set_terminal_modes):
6785 (tty_reset_terminal_modes, tty_turn_off_highlight):
6786 (get_tty_terminal): Now static.
6787 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6788 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6789 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6790 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6791 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6792
1fa53021
PE
6793 * sysdep.c: Make symbols static if they're not exported.
6794 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6795 Now static.
6796 (sigprocmask_set, full_mask): Remove; unused.
6797 (wait_debugging): Mark as visible.
6798 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6799 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6800
d4b43b22
PE
6801 * syntax.c (syntax_temp): Define only if !__GNUC__.
6802
b7c513d0
PE
6803 * sound.c (current_sound_device, current_sound): Now static.
6804
989b29ad
PE
6805 * search.c (searchbufs, searchbuf_head): Now static.
6806
13a55a78
PE
6807 * scroll.c (scroll_cost): Remove; unused.
6808 * dispextern.h (scroll_cost): Remove decl.
6809
de68a1fc
PE
6810 * region-cache.h (pp_cache): Mark as externally visible.
6811
40ccffa6
PE
6812 * process.c: Make symbols static if they're not exported.
6813 (process_tick, update_tick, create_process, chan_process):
6814 (Vprocess_alist, proc_buffered_char, datagram_access):
6815 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6816 (deactivate_process): Mark defn as static, as well as decl.
6817 * lisp.h (create_process): Remove decl.
6818 * process.h (chan_process, Vprocess_alist): Remove decls.
6819
ad64fc97
PE
6820 * print.c: Make symbols static if they're not exported.
6821 (print_depth, new_backquote_output, being_printed, print_buffer):
6822 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6823 (print_interval, print_number_index, initial_stderr_stream):
6824 Now static.
6825 * lisp.h (Fprinc): Remove decl.
6826 (debug_output_compilation_hack): Mark as externally visible.
6827
adddb265
PE
6828 * sysdep.c (croak): Move decl from here to syssignal.h.
6829 * syssignal.h (croak): Put it here, so the API can be checked when
6830 'croak' is called from dissociate_if_controlling_tty.
6831
1717ede2
PE
6832 * minibuf.c: Make symbols static if they're not exported.
6833 (minibuf_save_list, choose_minibuf_frame): Now static.
6834 * lisp.h (choose_minibuf_frame): Remove decl.
6835
fa5fb2bc
PE
6836 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6837
1e3890d1
PE
6838 * lread.c: Make symbols static if they're not exported.
6839 (read_objects, initial_obarray, oblookup_last_bucket_number):
6840 Now static.
6841 (make_symbol): Remove; unused.
6842 * lisp.h (initial_obarray, make_symbol): Remove decls.
6843
8a1414fa
PE
6844 * keyboard.c: Make symbols static if they're not exported.
6845 (single_kboard, recent_keys_index, total_keys, recent_keys):
6846 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6847 (this_single_command_key_start, echoing, last_auto_save):
6848 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6849 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6850 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6851 (Vlispy_mouse_stem, double_click_count):
6852 Now static.
6853 (force_auto_save_soon): Define only if SIGDANGER.
6854 (ignore_mouse_drag_p): Now static if
6855 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6856 (print_help): Remove; unused.
6857 (stop_character, last_timer_event): Mark as externally visible.
6858 * keyboard.h (ignore_mouse_drag_p): Declare only if
6859 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6860 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6861 * lisp.h (echoing): Remove decl.
6862 (force_auto_save_soon): Declare only if SIGDANGER.
6863 * xdisp.c (redisplay_window): Simplify code, to make it more
6864 obvious that ignore_mouse_drag_p is not accessed if !defined
6865 USE_GTK && !defined HAVE_NS.
6866
93ea6e8f
PE
6867 * intervals.c: Make symbols static if they're not exported.
6868 (merge_properties_sticky, merge_interval_right, delete_interval):
6869 Now static.
6870 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6871
77382fcc
PE
6872 * insdel.c: Make symbols static if they're not exported.
6873 However, leave prepare_to_modify_buffer alone. It's never
6874 called from outside this function, but that appears to be a bug.
6875 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6876 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6877 (adjust_after_replace_noundo): Remove; unused.
6878 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6879 (signal_before_change): Remove decls.
77382fcc 6880
9306c32e
PE
6881 * indent.c (val_compute_motion, val_vmotion): Now static.
6882
cd44d2eb
PE
6883 * image.c: Make symbols static if they're not exported.
6884 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6885 if USE_GTK.
6886 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6887 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6888
ad9a7a06
PE
6889 * fringe.c (standard_bitmaps): Now static.
6890 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6891
81626931
PE
6892 * frame.c: Make symbols static if they're not exported.
6893 (x_report_frame_params, make_terminal_frame): Now static.
6894 (get_frame_param): Now static, unless HAVE_NS.
6895 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6896 (x_get_resource_string): Remove; not used.
6897 * frame.h (make_terminal_frame, x_report_frame_params):
6898 (x_get_resource_string); Remove decls.
6899 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6900 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6901
239f9db9
PE
6902 * font.c, fontset.c: Make symbols static if they're not exported.
6903 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6904 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6905 * font.c (font_close_object): Now static.
6906 * font.h (font_close_object): Remove.
6907 * fontset.c (FONTSET_OBJLIST): Remove.
6908 (free_realized_fontset) #if-0 the body, which does nothing.
6909 (face_suitable_for_char_p): #if-0, as it's never called.
6910 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6911 * xfaces.c (face_at_string_position):
6912 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6913 since 0 is always ASCII.
6914
dfcf3579
PE
6915 * fns.c (weak_hash_tables): Now static.
6916
5045092b
PE
6917 * fileio.c: Make symbols static if they're not exported.
6918 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6919 (Vwrite_region_annotation_buffers): Now static.
6920
57a96f5c
PE
6921 * eval.c: Make symbols static if they're not exported.
6922 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6923 * lisp.h (backtrace_list): Remove decl.
6924
35f08c38
PE
6925 * emacs.c: Make symbols static if they're not exported.
6926 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6927 (fatal_error_code, fatal_error_signal_hook, standard_args):
6928 Now static.
6929 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6930 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6931 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6932 * lisp.h (fatal_error_signal_hook): Remove decl.
6933 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6934
f44bd759
PE
6935 * editfns.c: Move a (normally-unused) function to its only use.
6936 * editfns.c, lisp.h (get_operating_system_release): Remove.
6937 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6938 worth the hassle of breaking this out.
6939
b532497d
PE
6940 * xterm.c: Make symbols static if they're not exported.
6941 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6942 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6943 (x_destroy_window, x_delete_display):
6944 Now static.
6945 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6946 (x_mouse_leave): Remove; unused.
6947 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6948 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6949 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6950 Remove decls.
6951 (x_mouse_leave): Declare only if WINDOWSNT.
6952 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6953 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6954 USE_X_TOOLKIT.
6955
1675728f
PE
6956 * ftxfont.c: Make symbols static if they're not exported.
6957 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6958 HAVE_FREETYPE.
6959 * font.h (ftxfont_driver): Likewise.
6960
e4cebfca
PE
6961 * xfns.c: Make symbols static if they're not exported.
6962 (x_last_font_name, x_display_info_for_name):
6963 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6964 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6965 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6966 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6967 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6968 (last_show_tip_args): Now static.
6969 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6970 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6971 (x_screen_planes): Remove; unused.
6972 * dispextern.h (x_screen_planes): Remove decl.
6973
5bf46f05
PE
6974 * dispnew.c: Make symbols static if they're not exported.
6975 * dispextern.h (redraw_garbaged_frames, scrolling):
6976 (increment_row_positions): Remove.
6977 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6978 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6979 Now static.
6980 (redraw_garbaged_frames): Remove; unused.
6981
435f4c28
PE
6982 * xfaces.c: Make symbols static if they're not exported.
6983 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6984 Remove decls.
6985 * xterm.h (defined_color): Remove decls.
6986 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6987 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6988 (menu_face_changed_default, defined_color, free_realized_face):
6989 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6990 (ascii_face_of_lisp_face): Remove; unused.
6991
8524aef3
PE
6992 * xdisp.c: Make symbols static if they're not exported.
6993 * dispextern.h (scratch_glyph_row, window_box_edges):
6994 (glyph_to_pixel_coords, set_cursor_from_row):
6995 (get_next_display_element, set_iterator_to_next):
6996 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6997 (show_mouse_face): Remove decls
6998 * frame.h (message_buf_print): Likewise.
6999 * lisp.h (pop_message, set_message, check_point_in_composition):
7000 Likewise.
7001 * xterm.h (set_vertical_scroll_bar): Likewise.
7002 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7003 (message_buf_print, scratch_glyph_row, displayed_buffer):
7004 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7005 (get_next_display_element, show_mouse_face, window_box_edges):
7006 (frame_to_window_pixel_xy, check_point_in_composition):
7007 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7008 (glyph_to_pixel_coords): Remove; unused.
7009
16390cd2
PE
7010 * dired.c (file_name_completion): Now static.
7011
7012 * dbusbind.c (xd_in_read_queued_messages): Now static.
7013
a25f4dfa
PE
7014 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7015 * data.c (circular_list_error): Remove.
7016
14a9c8df
PE
7017 * commands.h (last_point_position, last_point_position_buffer):
7018 (last_point_position_window): Remove decls.
7019 * keyboard.c: Make these variables static.
7020
04f2d78b
CB
7021 * coding.h (coding, code_convert_region, encode_coding_gap):
7022 Remove decls.
74ab6df5
PE
7023 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7024 (iso_code_class, detect_coding, code_convert_region): Now static.
7025 (encode_coding_gap): Remove; unused.
7026
38dfbee1
PE
7027 * chartab.c (chartab_chars, chartab_bits): Now static.
7028
a2cb4e63
PE
7029 * charset.h (charset_iso_8859_1): Remove decl.
7030 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7031 Now static.
7032
127198fd
PE
7033 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7034 * ccl.c (Vccl_program_table): Now static.
7035 (check_ccl_update): Remove; unused.
7036
d85b608f
PE
7037 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7038 * category.h: ... from here.
7039 * category.c (check_category_table, set_category_set): Now static.
7040
31cd66f3
PE
7041 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7042 * lisp.h: Remove these decls.
7043
c358e587
PE
7044 * buffer.c (buffer_count): Remove unused var.
7045
e78aecca
PE
7046 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7047 so that it's not optimized away.
7048 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7049 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7050 exported only to the debugger.
7051
e192d7d3 7052 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7053 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7054
92470028
PE
7055 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7056 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7057 was inaccessible from Lisp.
7058 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7059 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7060
244ed907
PE
7061 alloc.c: Import and export fewer symbols, and remove unused items.
7062 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7063 is defined.
7064 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7065 it's not optimized away by whole-program optimization.
7066 (message_enable_multibyte, free_misc): Remove.
7067 (catchlist, handlerlist, mark_backtrace):
7068 Declare only if BYTE_MARK_STACK.
7069 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7070 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7071 (message_enable_multibyte): Remove decl.
7072 (free_misc, interval_free_list, float_block, float_block_index):
7073 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7074 (cons_free_list, last_marked_index):
7075 Now static.
7076 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7077 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7078 (mark_backtrace): Define only if BYTE_MARK_STACK.
7079 * xdisp.c (message_enable_multibyte): Now static.
7080
61c2b50e 7081 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7082 This makes it easier for human readers (and static analyzers)
7083 to see whether these variables are used from other modules.
7084 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7085 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7086 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7087 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7088 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7089 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7090 * xmenu.c, xselect.c:
7091 Declare Q* vars static if they are not used in other modules.
7092 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7093 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7094 Remove decls of unexported vars.
7095 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7096
95c82688
PE
7097 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7098
16a97296
PE
7099 Make Emacs functions such as Fatom 'static' by default.
7100 This makes it easier for human readers (and static analyzers)
7101 to see whether these functions can be called from other modules.
7102 DEFUN now defines a static function. To make the function external
7103 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7104 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7105 (Finit_image_library):
16a97296
PE
7106 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7107 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7108 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7109 Remove decls, since these functions are now static.
7110 (Funintern, Fget_internal_run_time): New decls, since these functions
7111 were already external.
95c82688 7112
16a97296
PE
7113 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7114 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7115 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7116 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7117 * keyboard.c, keymap.c, lread.c:
7118 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7119 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7120 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7121 Mark functions with DEFUE instead of DEFUN,
7122 if they are used in other modules.
7123 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7124 decls for now-static functions.
7125 * buffer.h (Fdelete_overlay): Remove decl.
7126 * callproc.c (Fgetenv_internal): Mark as internal.
7127 * composite.c (Fremove_list_of_text_properties): Remove decl.
7128 (Fcomposition_get_gstring): New forward static decl.
7129 * composite.h (Fcomposite_get_gstring): Remove decl.
7130 * dired.c (Ffile_attributes): New forward static decl.
7131 * doc.c (Fdocumntation_property): New forward static decl.
7132 * eval.c (Ffetch_bytecode): New forward static decl.
7133 (Funintern): Remove extern decl; now in .h file where it belongs.
7134 * fileio.c (Fmake_symbolic_link): New forward static decl.
7135 * image.c (Finit_image_library): New forward static decl.
7136 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7137 * intervals.h (Fprevious_property_change):
7138 (Fremove_list_of_text_properties): Remove decls.
7139 * keyboard.c (Fthis_command_keys): Remove decl.
7140 (Fcommand_execute): New forward static decl.
7141 * keymap.c (Flookup_key): New forward static decl.
7142 (Fcopy_keymap): Now static.
7143 * keymap.h (Flookup_key): Remove decl.
7144 * process.c (Fget_process): New forward static decl.
7145 (Fprocess_datagram_address): Mark as internal.
7146 * syntax.c (Fsyntax_table_p): New forward static decl.
7147 (skip_chars): Remove duplicate decl.
7148 * textprop.c (Fprevious_property_change): New forward static decl.
7149 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7150 Now internal.
7151 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7152 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7153
785bbd42
PE
7154 * editfns.c (Fformat): Remove unreachable code.
7155
8b913b57
AS
71562011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7157
7158 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7159 change. (Bug#8496)
7160
a6744a35
EZ
71612011-04-13 Eli Zaretskii <eliz@gnu.org>
7162
7163 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7164 when at ZV. (Bug#8487)
7165
e7974947
AS
71662011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7167
baad03f0
AS
7168 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7169 (Bug#8437)
7170 * keyboard.c (parse_tool_bar_item): Likewise.
7171 * sound.c (sound_cleanup, alsa_close): Likewise.
7172 * termcap.c (tgetent): Likewise.
7173 * xfns.c (x_default_font_parameter): Likewise.
7174 * xsettings.c (read_and_apply_settings): Likewise.
7175
e7974947
AS
7176 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7177 (overrun_check_free): Protoize.
7178
28272684
PE
71792011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7180
7181 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7182 since callers should never pass a negative size.
7183 Change the signature to match that of plain 'read' and 'write'; see
7184 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7185 * lisp.h: Update prototypes of emacs_write and emacs_read.
7186
11997c76
EZ
71872011-04-11 Eli Zaretskii <eliz@gnu.org>
7188
7189 * xdisp.c (redisplay_window): Don't try to determine the character
7190 position of the scroll margin if the window start point w->startp
e896f03c 7191 is outside the buffer's accessible region. (Bug#8468)
11997c76 7192
8a2cbd72
EZ
71932011-04-10 Eli Zaretskii <eliz@gnu.org>
7194
7195 Fix write-region and its subroutines for buffers > 2GB.
7196 * fileio.c (a_write, e_write): Modify declaration of arguments and
7197 local variables to support buffers larger than 2GB.
7198 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7199
7200 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7201 argument, local variables, and return value.
7202
7203 * lisp.h: Update prototypes of emacs_write and emacs_read.
7204
7205 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7206
4073e537 72072011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7208
1ebfdcb6
PE
7209 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7210
b2ded58d
PE
7211 Fix more problems found by GCC 4.6.0's static checks.
7212
7d66342c
PE
7213 * xdisp.c (vmessage): Use a better test for character truncation.
7214
bbf47d44
PE
7215 * charset.c (load_charset_map): <, not <=, for optimization,
7216 and to avoid potential problems with integer overflow.
9248994d 7217 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7218 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7219 * editfns.c (Fformat): Likewise.
1e69125e 7220 * syntax.c (skip_chars): Likewise.
3befa583 7221
e3019616
PE
7222 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7223 This also lets GCC 4.6.0 generate slightly better loop code.
7224
becfa255
PE
7225 * callint.c (Fcall_interactively): <, not <=, for optimization.
7226 (Fcall_interactively): Count the number of arguments produced,
7227 not the number of arguments given. This is simpler and lets GCC
7228 4.6.0 generate slightly better code.
7229
dae0cd48
PE
7230 * ftfont.c: Distingish more carefully between FcChar8 and char.
7231 The previous code passed unsigned char * to a functions like
7232 strlen and xstrcasecmp that expect char *, which does not
7233 conform to the C standard.
7234 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7235 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7236 char * when the C standard requires it.
7237
76032d70
PE
7238 * keyboard.c (read_char): Remove unused var.
7239
eb3f1cc8
PE
7240 * eval.c: Port to Windows vsnprintf (Bug#8435).
7241 Include <limits.h>.
7242 (SIZE_MAX): Define if the headers do not.
7243 (verror): Do not give up if vsnprintf returns a negative count.
7244 Instead, grow the buffer. This ports to Windows vsnprintf, which
7245 does not conform to C99. Problem reported by Eli Zaretskii.
7246 Also, simplify the allocation scheme, by avoiding the need for
7247 calling realloc, and removing the ALLOCATED variable.
7248
70476b54
PE
7249 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7250
12020a9e
PE
7251 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7252 But keep the doprint source code for now, as we might revamp it
7253 and use it again (Bug#8435).
ea6c7ae6
PE
7254 * lisp.h (doprnt): Remove.
7255 * Makefile.in (base_obj): Remove doprnt.o.
7256 * deps.mk (doprnt.o): Remove.
7257
5fdb398c
PE
7258 error: Print 32- and 64-bit integers portably (Bug#8435).
7259 Without this change, on typical 64-bit hosts error ("...%d...", N)
7260 was used to print both 32- and 64-bit integers N, which relied on
7261 undefined behavior.
7262 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7263 New macro.
7264 * lisp.h (error, verror): Mark as printf-like functions.
7265 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7266 Report overflow in size calculations when allocating printf buffer.
7267 Do not truncate output string at its first null byte.
7268 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7269 Truncate the output at a character boundary, since vsnprintf does not
7270 do that.
7271 * charset.c (check_iso_charset_parameter): Convert internal
7272 character to string before calling 'error', since %c now has the
7273 printf meaning.
7274 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7275 overflow when computing char to be passed to 'error'. Do not
7276 pass Lisp_Object to 'error'; pass the integer instead.
7277 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7278 formatted with plain %d.
7279
b189fa66
PE
7280 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7281
bff87ef0
PE
7282 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7283
7e2cac20
PE
7284 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7285
ce4d90b5
PE
7286 * xterm.c (x_catch_errors): Remove duplicate declaration.
7287
266c9547
PE
7288 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7289
79c49ad2
PE
7290 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7291
368f4090
JM
72922011-04-10 Jim Meyering <meyering@redhat.com>
7293
7294 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7295 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7296 return ssize_t not "int", and use size_t as the buffer length.
7297 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7298 * gnutls.h: Update declarations.
7299 * process.c (read_process_output): Use ssize_t, to match.
7300 (send_process): Likewise.
7301
a32d4040
CY
73022011-04-09 Chong Yidong <cyd@stupidchicken.com>
7303
7304 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7305
8546720e 73062011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7307
04f2d78b
CB
7308 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7309 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7310
8546720e
GM
7311 * xterm.c (handle_one_xevent):
7312 * xmenu.c (create_and_show_popup_menu):
7313 * xselect.c (x_decline_selection_request)
7314 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7315
0a2f5c1a 73162011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7317
7318 Fix some uses of `int' instead of EMACS_INT.
7319 * search.c (string_match_1, fast_string_match)
7320 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7321 (scan_buffer, find_next_newline_no_quit)
7322 (find_before_next_newline, search_command, Freplace_match)
7323 (Fmatch_data): Make some `int' variables be EMACS_INT.
7324
7325 * xdisp.c (display_count_lines): 3rd argument and return value now
7326 EMACS_INT. All callers changed.
7327 (pint2hrstr): Last argument is now EMACS_INT.
7328
7329 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7330 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7331 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7332 (decode_coding_utf_16, decode_coding_emacs_mule)
7333 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7334 (decode_coding_ccl, decode_coding_charset)
7335 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7336 (decode_coding_iso_2022, decode_coding_emacs_mule)
7337 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7338 <char_offset, last_offset>: Declare EMACS_INT.
7339 (encode_coding_utf_8, encode_coding_utf_16)
7340 (encode_coding_emacs_mule, encode_invocation_designation)
7341 (encode_designation_at_bol, encode_coding_iso_2022)
7342 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7343 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7344 Declare EMACS_INT.
7345 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7346 (encode_invocation_designation): Last argument P_NCHARS is now
7347 EMACS_INT.
7348 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7349 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7350
7351 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7352 All users changed.
7353
7354 * ccl.c (Fccl_execute_on_string): Declare some variables
7355 EMACS_INT.
7356
8546720e 73572011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7358
7359 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7360
4e19a977
CS
73612011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7362
7363 * process.c (Fformat_network_address): Doc fix.
7364
87302331
R
73652011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7366
ee7683eb 7367 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7368
cbb59342
CY
73692011-04-08 Chong Yidong <cyd@stupidchicken.com>
7370
7371 * keyboard.c (read_char): Call Lisp function help-form-show,
7372 instead of using internal_with_output_to_temp_buffer.
7373 (Qhelp_form_show): New var.
e0d38eeb 7374 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7375
7376 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7377
7378 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7379
e67a13ab
CY
73802011-04-06 Chong Yidong <cyd@stupidchicken.com>
7381
04f2d78b
CB
7382 * process.c (Flist_processes): Remove to Lisp.
7383 (list_processes_1): Delete.
e67a13ab 7384
973f782d
EZ
73852011-04-06 Eli Zaretskii <eliz@gnu.org>
7386
7c106b1e
EZ
7387 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7388
973f782d
EZ
7389 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7390
41cf7d1a 73912011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7392
ca23cc88
PE
7393 Fix more problems found by GCC 4.6.0's static checks.
7394
f390e2d5
PE
7395 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7396
42eea0d0
PE
7397 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7398
b69769da 7399 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7400
f9541e84
PE
7401 * xdisp.c (vmessage): Mark as a printf-like function.
7402
13841b55
PE
7403 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7404
c136c10f
PE
7405 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7406
5e2d4a30
PE
7407 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7408 printf-like functions.
7409 (tiff_load): Add casts to remove these marks before passing them
7410 to system-supplied API.
7411
583f48b9
PE
7412 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7413
b25d760e
PE
7414 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7415 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7416 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7417 directly, rather than having caller test rule sign. This avoids
7418 some unnecessary tests.
7419 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7420 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7421 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7422
bc7b6697 7423 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7424 (xfont_open): Avoid unnecessary tests.
bc7b6697 7425
27ccc379
PE
7426 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7427
dcd5c89a
PE
7428 * composite.h, composite.c (composition_gstring_put_cache):
7429 Use EMACS_INT, not int, for length.
7430
b13a45c6
PE
7431 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7432 breaking out part of COMPOSITION_DECODE_RULE.
7433 (COMPOSITION_DECODE_RULE): Use it.
7434 * composite.c (get_composition_id): Remove unused local vars,
7435 by using the new macro.
7436
1e792e4d
PE
7437 * textprop.c (set_text_properties_1): Change while to do-while,
7438 since the condition is always true at first.
7439
dc6c6455 7440 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7441 (interval_deletion_adjustment): Return unsigned value.
7442 All uses changed.
dc6c6455 7443
aba7731a
PE
7444 * process.c (list_processes_1, create_pty, read_process_output):
7445 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7446 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7447 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7448 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7449 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7450
fdfc4bf3
PE
7451 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7452
fca8fe46 7453 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7454 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7455
06a0259a 7456 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7457 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7458 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7459
e7b9e80f
PE
7460 * print.c (print_error_message): Avoid int overflow.
7461
56201685
PE
7462 * font.c (font_list_entities): Redo for clarity,
7463 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7464
78834453 7465 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7466 (font_score): Avoid potential overflow in diff calculation.
78834453 7467
0bc0b309 7468 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7469 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7470
e610eaca
PE
7471 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7472
b895abce
PE
7473 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7474 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7475 can always succeed if overflow has undefined behavior.
7476
1f1d9321 7477 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7478 (wordify): Omit three unnecessary tests.
1f1d9321 7479
c59478bc
PE
7480 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7481 All callers changed. This avoids the need for an unused var.
7482
79b73827
PE
7483 * casefiddle.c (casify_region): Remove var that is set but not used.
7484
a4db5dfe
PE
7485 * dired.c (file_name_completion): Remove var that is set but not used.
7486
43aae36e
PE
7487 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7488
2a47c44d 7489 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7490 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7491
a37c69bf
PE
7492 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7493 Check for integer overflow on size calculations.
7494
328ab8e7
PE
7495 * buffer.c (Fprevious_overlay_change): Remove var that is set
7496 but not used.
7497
e5a2a5cb
PE
7498 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7499 Remove vars that are set but not used.
8d84a6eb 7500 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7501 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7502
a60e5f68
PE
7503 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7504
f661cb61 7505 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7506 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7507
f0397f5a
PE
7508 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7509 that are set but not used.
7510
8664db06 7511 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7512 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7513
6abdaa4a
PE
7514 * xselect.c (x_get_local_selection, x_handle_property_notify):
7515 Remove vars that are set but not used.
7516
0ce7538d 7517 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7518 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7519
9ae848fc
PE
7520 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7521 Remove var that is set but not used.
0b918413
PE
7522 (scroll_bar_windows_size): Now size_t, not int.
7523 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7524 Check for overflow.
9ae848fc 7525
a5a62657
PE
7526 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7527 (map_tty_color) [!defined MSDOS]: Likewise.
7528
5c5cdd39
PE
7529 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7530
66ebf983
PE
7531 * coding.c: Remove vars that are set but not used.
7532 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7533 All callers changed.
7534 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7535 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7536 (decode_coding_charset): Remove vars that are set but not used.
7537
1be4d761
PE
7538 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7539 that is set but not used.
7540
47553fa8
PE
7541 * print.c (print_object): Remove var that is set but not used.
7542
1f7196bf 7543 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7544 The gnulib version avoids calling malloc in the usual case,
7545 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7546 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7547 * filelock.c (current_lock_owner): Likewise.
7548 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7549 * sysdep.c: Include allocator.h, careadlinkat.h.
7550 (emacs_no_realloc_allocator): New static constant.
7551 (emacs_readlink): New function.
fdb61804
PE
7552 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7553 ../lib/careadlinkat.h.
d1fdcab7 7554
f84c17c7
SM
75552011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7556
7557 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7558 first non-nil return value).
7559
ef3862ad
JD
75602011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7561
7562 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7563 if not defined (Bug#8403).
7564
376a7006
JB
75652011-04-02 Juanma Barranquero <lekktu@gmail.com>
7566
7567 * xdisp.c (display_count_lines): Remove parameter `start',
7568 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7569 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7570 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7571 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7572 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7573 and thereabouts. All callers changed.
7574 (get_per_char_metric): Remove parameter `f', unused since
7575 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7576
6ca3801d
JM
75772011-04-02 Jim Meyering <meyering@redhat.com>
7578
7579 do not dereference NULL upon failed strdup
7580 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7581 (ns_get_family): Likewise.
7582
d8e2b5ba
JB
75832011-04-02 Juanma Barranquero <lekktu@gmail.com>
7584
7585 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7586
8c74fcbd
JD
75872011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7588
7589 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7590 later (Bug#8403).
7591
7200d79c
SM
75922011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7593
03408648 7594 Add lexical binding.
7200d79c 7595
03408648
SM
7596 * window.c (Ftemp_output_buffer_show): New fun.
7597 (Fsave_window_excursion):
7598 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7599
7600 * lread.c (lisp_file_lexically_bound_p): New function.
7601 (Fload): Bind Qlexical_binding.
7602 (readevalloop): Remove `evalfun' arg.
7603 Bind Qinternal_interpreter_environment.
7604 (Feval_buffer): Bind Qlexical_binding.
7605 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7606 Mark as dynamic.
7607 (syms_of_lread): Declare `lexical-binding'.
7608
7609 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7610
7611 * keyboard.c (eval_dyn): New fun.
7612 (menu_item_eval_property): Use it.
ca105506
SM
7613
7614 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7615
03408648
SM
7616 * fns.c (concat, mapcar1): Accept byte-code-functions.
7617
7618 * eval.c (Fsetq): Handle lexical vars.
7619 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7620 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7621 (FletX, Flet): Obey lexical binding.
7622 (Fcommandp): Handle closures.
7623 (Feval): New `lexical' arg.
7624 (eval_sub): New function extracted from Feval. Use it almost
7625 everywhere where Feval was used. Look up vars in lexical env.
7626 Handle closures.
7627 (Ffunctionp): Move from subr.el.
7628 (Ffuncall): Handle closures.
7629 (apply_lambda): Remove `eval_flags'.
7630 (funcall_lambda): Handle closures and new byte-code-functions.
7631 (Fspecial_variable_p): New function.
7632 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7633 but without exporting it to Lisp.
23aba0ea 7634
23aba0ea 7635 * doc.c (Fdocumentation, store_function_docstring):
03408648 7636 * data.c (Finteractive_form): Handle closures.
23aba0ea 7637
03408648
SM
7638 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7639 interactive spec.
ba83908c 7640
04f2d78b
CB
7641 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7642 New byte-codes.
03408648
SM
7643 (exec_byte_code): New function extracted from Fbyte_code to handle new
7644 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7645
03408648 7646 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7647
03408648 7648 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7649
e2abce01
JB
76502011-03-31 Juanma Barranquero <lekktu@gmail.com>
7651
7652 * xdisp.c (redisplay_internal): Fix prototype.
7653
63696a73 76542011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7655
63696a73 7656 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7657 (try_scrolling): Use it when setting scroll_limit.
7658 Limit scrolling to 100 screen lines.
63696a73
EZ
7659 (redisplay_window): Even when falling back on "recentering",
7660 position point in the window according to scroll-conservatively,
7661 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7662
7663 (try_scrolling): When point is above the window, allow searching
7664 as far as scroll_max, or one screenful, to compute vertical
7665 distance from PT to the scroll margin position. This prevents
7666 try_scrolling from unnecessarily failing when
7667 scroll-conservatively is set to a value slightly larger than the
7668 window height. Clean up the case of PT below the margin at bottom
7669 of window: scroll_max can no longer be INT_MAX. When aggressive
7670 scrolling is in use, don't let point enter the opposite scroll
7671 margin as result of the scroll.
7672 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7673 threshold of 100 lines for never-recentering scrolling.
7674
e4cc2dfc
JB
76752011-03-31 Juanma Barranquero <lekktu@gmail.com>
7676
7677 * dispextern.h (move_it_by_lines):
7678 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7679 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7680 (message_log_check_duplicate): Remove parameters `prev_bol' and
7681 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7682 (redisplay_internal): Remove parameter `preserve_echo_area',
7683 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7684
7685 * indent.c (Fvertical_motion):
7686 * window.c (window_scroll_pixel_based, Frecenter):
7687 Don't pass `need_y_p' to `move_it_by_lines'.
7688
1c470562
SM
76892011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7690
44f230aa
SM
7691 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7692 steal a few bits to be more compact.
7693 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7694 Remove unneeded casts.
7695
1c470562
SM
7696 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7697
888adce9
ZK
76982011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7699
7700 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7701 binding" message (bug#7967).
7702
f838ed7b
PE
77032011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7704
77861b95
PE
7705 Fix more problems found by GCC 4.6.0's static checks.
7706
de6dbc14
PE
7707 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7708 Remove unused local var.
7709
f838ed7b
PE
7710 * editfns.c (Fmessage_box): Remove unused local var.
7711
792c7b2b
PE
7712 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7713 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7714 Omit unused local vars.
c499e557 7715 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7716 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7717 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7718 Omit unused local var.
7719
ba0165e1
PE
7720 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7721 Don't assume string length fits in int.
32ad8845 7722 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7723 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7724
3c59b4c9
PE
7725 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7726 instead of alloca (Bug#8344).
7727
a3eed478 7728 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7729 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7730
eb4d412d
PE
7731 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7732
1658b401
PE
7733 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7734 concerns.
7735
7736 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7737
7738 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7739
9a2c6e05
PE
7740 * keyboard.c (syms_of_keyboard): Use the same style as later
7741 in this function when indexing through an array. This also
7742 works around GCC bug 48267.
7743
03d0a109
PE
7744 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7745
44f730c8
PE
7746 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7747
fe75f926
PE
7748 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7749 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7750
ffa8c828
PE
7751 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7752 This avoids undefined behavior on integer overflow, and is a bit
7753 more convenient anyway since it is compared to a size_t variable.
7754
c5101a77
PE
7755 Variadic C functions now count arguments with size_t, not int.
7756 This avoids an unnecessary limitation on 64-bit machines, which
7757 caused (substring ...) to crash on large vectors (Bug#8344).
7758 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7759 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7760 All variadic functions and their callers changed accordingly.
c5101a77
PE
7761 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7762 * data.c (arith_driver, float_arith_driver): Likewise.
7763 * editfns.c (general_insert_function): Likewise.
7764 * eval.c (struct backtrace.nargs, interactive_p)
7765 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7766 (funcall_lambda, mark_backtrace): Likewise.
7767 * fns.c (concat): Likewise.
7768 * frame.c (x_set_frame_parameters): Likewise.
7769 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7770 0 if not found, not -1. All callers changed.
7771
dd3f25f7
PE
7772 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7773 (stack_copy_size): Now size_t, not int.
7774 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7775
461c2ab9
JB
77762011-03-28 Juanma Barranquero <lekktu@gmail.com>
7777
7778 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7779 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7780 All callers changed.
7781
7782 * lisp.h (multibyte_char_to_unibyte):
7783 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7784 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7785 * character.h (CHAR_TO_BYTE8):
7786 * cmds.c (internal_self_insert):
7787 * editfns.c (general_insert_function):
7788 * keymap.c (push_key_description):
7789 * search.c (Freplace_match):
7790 * xdisp.c (message_dolog, set_message_1): All callers changed.
7791
f6d62986
SM
77922011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7793
7794 * keyboard.c (safe_run_hook_funcall): New function.
7795 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7796 don't set the hook to nil, but remove the offending function instead.
7797 (Qcommand_hook_internal): Remove, unused.
7798 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7799 Vcommand_hook_internal.
7800
7801 * eval.c (enum run_hooks_condition): Remove.
7802 (funcall_nil, funcall_not): New functions.
7803 (run_hook_with_args): Call each function through a `funcall' argument.
7804 Remove `cond' argument, now redundant.
7805 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7806 (Frun_hook_with_args_until_failure): Adjust accordingly.
7807 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7808
1db5b1ad
JB
78092011-03-28 Juanma Barranquero <lekktu@gmail.com>
7810
7811 * dispextern.h (string_buffer_position): Remove declaration.
7812
7813 * print.c (strout): Remove parameter `multibyte', unused since
7814 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7815
7816 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7817 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7818 All callers changed.
7819
7820 * w32.c (_wsa_errlist): Use braces for struct initializers.
7821
7822 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7823 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7824 All callers changed.
7825 (string_buffer_position): Likewise. Also, make static (it's never
7826 used outside xdisp.c).
7827 (cursor_row_p): Remove parameter `w', unused since
7828 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7829 (decode_mode_spec): Remove parameter `precision', introduced during
7830 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7831 All callers changed.
7832
5ffb62aa
JD
78332011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7834
7835 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7836
461c2ab9 78372011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7838
7839 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7840 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7841 (ns_update_auto_hide_menu_bar): New functions.
7842 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7843 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7844 ns_constrain_all_frames.
7845 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7846 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7847
5c380ffb
JD
78482011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7849
7850 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7851
9af30bdf
GM
78522011-03-27 Glenn Morris <rgm@gnu.org>
7853
7854 * syssignal.h: Replace RETSIGTYPE with void.
7855 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7856 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7857 Replace SIGTYPE with void everywhere.
7858 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7859 * s/template.h (SIGTYPE): Remove commented out definition.
7860
e2abce01
JB
78612011-03-26 Eli Zaretskii <eliz@gnu.org>
7862
7863 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7864 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7865
f868cd8a
JB
78662011-03-26 Juanma Barranquero <lekktu@gmail.com>
7867
59eb0929
JB
7868 * w32.c (read_unc_volume): Use parameter `henum', instead of
7869 global variable `wget_enum_handle'.
7870
7871 * keymap.c (describe_vector): Remove parameters `indices' and
7872 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7873 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7874
f868cd8a
JB
7875 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7876
7877 * keyboard.c (timer_check): Remove parameter `do_it_now',
7878 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7879 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7880 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7881
7882 * keyboard.c (read_char):
7883 * w32menu.c (w32_menu_display_help):
7884 * xmenu.c (show_help_event, menu_help_callback):
7885 Adjust calls to `show_help_echo'.
7886
7887 * gtkutil.c (xg_maybe_add_timer):
7888 * keyboard.c (readable_events):
7889 * process.c (wait_reading_process_output):
7890 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7891
7892 * insdel.c (adjust_markers_gap_motion):
7893 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7894 (gap_left, gap_right): Don't call it.
7895
2ecf6fdb
CY
78962011-03-25 Chong Yidong <cyd@stupidchicken.com>
7897
7898 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7899 incurred during fontification.
7900
6b1f9ba4
JB
79012011-03-25 Juanma Barranquero <lekktu@gmail.com>
7902
7903 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7904 (DEFVAR_PER_BUFFER): Don't pass it.
7905
7906 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7907 (scrolling_window): Don't pass it.
7908
0f4a96b5
JB
79092011-03-25 Juanma Barranquero <lekktu@gmail.com>
7910
7911 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7912
7913 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7914 and `suffix'.
7915 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7916 of variables specific to SELinux and computation of `encoded_absname'.
7917
7918 * image.c (XPutPixel): Remove unused variable `height'.
7919
7920 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7921
7922 * unexw32.c (get_section_info): Remove unused variable `section'.
7923
7924 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7925 (system_process_attributes): Remove unused variable `sess'.
7926 (sys_read): Remove unused variable `err'.
7927
7928 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7929 (w32_wnd_proc): Remove unused variable `isdead'.
7930 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7931 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7932 (x_create_tip_frame): Remove unused variable `tem'.
7933
7934 * w32inevt.c (w32_console_read_socket):
7935 Remove unused variable `no_events'.
7936
7937 * w32term.c (x_draw_composite_glyph_string_foreground):
7938 Remove unused variable `width'.
7939
1149507c
JB
79402011-03-24 Juanma Barranquero <lekktu@gmail.com>
7941
7942 * w32term.c (x_set_glyph_string_clipping):
7943 Don't pass uninitialized region to CombineRgn.
7944
9c88f339
JB
79452011-03-23 Juanma Barranquero <lekktu@gmail.com>
7946
7947 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7948 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7949 (Fx_close_connection): Remove unused variable `i'.
7950
7951 * w32font.c (w32font_draw): Return number of glyphs.
7952 (w32font_open_internal): Remove unused variable `i'.
7953 (w32font_driver): Add missing initializer.
7954
7955 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7956 (fill_in_menu): Remove unused variable `items_added'.
7957
7958 * w32term.c (last_mouse_press_frame): Remove static global variable.
7959 (w32_clip_to_row): Remove unused variable `f'.
7960 (x_delete_terminal): Remove unused variable `i'.
7961
7962 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7963 (NOTHING): Remove unused static global variable.
7964 (uniscribe_check_otf): Remove unused variable `table'.
7965 (uniscribe_font_driver): Add missing initializers.
7966
dee091a3
JD
79672011-03-23 Julien Danjou <julien@danjou.info>
7968
7969 * term.c (Fsuspend_tty, Fresume_tty):
7970 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7971 * window.c (temp_output_buffer_show):
7972 * insdel.c (signal_before_change):
7973 * frame.c (Fhandle_switch_frame):
7974 * fileio.c (Fdo_auto_save):
7975 * emacs.c (Fkill_emacs):
7976 * editfns.c (save_excursion_restore):
7977 * cmds.c (internal_self_insert):
7978 * callint.c (Fcall_interactively):
7979 * buffer.c (Fkill_all_local_variables):
7980 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7981 Use Frun_hooks.
0f4a96b5 7982 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 7983 unconditionally since it does the check itself.
dee091a3 7984
2c520ab5 79852011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7986
c9c49752
PE
7987 Fix more problems found by GCC 4.5.2's static checks.
7988
8abc3f12
PE
7989 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7990 the first time through the loop, since we know p0 < p1 then.
7991 This also avoids a gcc -Wstrict-overflow warning.
7992
a2d26660
PE
7993 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7994 leading to a memory leak, possible in functions like
7995 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7996 of objects (Bug#8318).
a2d26660 7997
916c72e9
PE
7998 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7999 that could (at least in theory) be that large.
8000
19ab8a18
PE
8001 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8002 This is less likely to overflow, and avoids undefined behavior if
8003 overflow does occur. All callers changed. Use strtoul to scan
8004 for the unsigned long integer.
b7cbbd6f
PE
8005 (pint2hrstr): Simplify and tune code slightly.
8006 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8007
f0641eff
PE
8008 * scroll.c (do_scrolling): Work around GCC bug 48228.
8009 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8010
7f650bb9
PE
8011 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8012 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8013 (validate_x_resource_name): Simplify count usage.
8014 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8015
37dd57d1
PE
8016 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8017 fail (Bug#8306).
81e56e61 8018
699979fc 8019 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8020
401bf9b4
PE
8021 * process.c (Fmake_network_process): Use socklen_t, not int,
8022 where POSIX says socklen_t is required in portable programs.
8023 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8024 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8025 (Fmake_network_process, server_accept_connection):
8026 (wait_reading_process_output, read_process_output):
8027 Likewise.
8028
b93aacde
PE
8029 * process.c: Rename or move locals to avoid shadowing.
8030 (list_processes_1, Fmake_network_process):
8031 (read_process_output_error_handler, exec_sentinel_error_handler):
8032 Rename or move locals.
4dc343ee 8033 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8034 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8035 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8036 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8037 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8038
af8a867c 8039 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8040 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8041 Include tparam.h instead, since it declares them.
af8a867c
PE
8042 * cm.h (PC): Remove extern decl; tparam.h now does this.
8043 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8044 * terminfo.c: Include tparam.h, to check interfaces.
8045 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8046 (tparam): Adjust signature to match interface in tparam.h;
8047 this removes some undefined behavior. Check that outstring and len
8048 are zero, which they always are with Emacs.
8049 * tparam.h (PC, BC, UP): New extern decls.
8050
0248044d 8051 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8052 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8053
8ff096c1 8054 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8055 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8056 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8057 (ftfont_list): Remove unused local.
49eaafba
PE
8058 (get_adstyle_property, ftfont_pattern_entity):
8059 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8060 Rename locals to avoid shadowing.
8ff096c1 8061
e2be39f6
PE
8062 * xfont.c (xfont_list_family): Mark var as initialized.
8063
c9735e30
PE
8064 * xml.c (make_dom): Now static.
8065
8f5201ae
PE
8066 * composite.c (composition_compute_stop_pos): Rename local to
8067 avoid shadowing.
b246f932
PE
8068 (composition_reseat_it): Remove unused locals.
8069 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8070 (composition_update_it): Mark var as initialized.
11b61122
PE
8071 (find_automatic_composition): Mark vars as initialized,
8072 with a FIXME (Bug#8290).
8f5201ae 8073
760fbc2c
PE
8074 character.h: Rename locals to avoid shadowing.
8075 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8076 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8077 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8078 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8079 to avoid shadowing.
8080
ff08eb85
PE
8081 * textprop.c (property_change_between_p): Remove; unused.
8082
fc7bf025
PE
8083 * intervals.c (interval_start_pos): Now static.
8084
235d7abc
PE
8085 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8086
44f230aa
SM
8087 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8088 Rename locals to avoid shadowing.
3e7d6594 8089
50060332
PE
8090 * sound.c (wav_play, au_play, Fplay_sound_internal):
8091 Fix pointer signedness.
d01f234b 8092 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8093 (wav_play): Initialize a variable to 0, to prevent undefined
8094 behavior (Bug#8278).
50060332 8095
c4fc4e30
PE
8096 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8097
918436ed
PE
8098 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8099
c939f91b
PE
8100 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8101 clobbering (Bug#8298).
b9c7f648
PE
8102 * sysdep.c (sys_subshell): Likewise.
8103 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8104
6bd8c144
PE
8105 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8106 This should get cleaned up, so that child_setup has the
8107 same signature on all platforms.
8108
7710357c 8109 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8110 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8111
c59da222
CY
81122011-03-22 Chong Yidong <cyd@stupidchicken.com>
8113
8114 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8115 not to be necessary, and produces flickering.
8116
66b87493
GM
81172011-03-20 Glenn Morris <rgm@gnu.org>
8118
8119 * config.in: Remove file.
8120
45b6f6d5
JB
81212011-03-20 Juanma Barranquero <lekktu@gmail.com>
8122
8123 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8124 are now in src/globals.h.
8125 (syms_of_minibuf): Remove spurious & from previous change.
8126
3ec03f7e
LL
81272011-03-20 Leo <sdl.web@gmail.com>
8128
8129 * minibuf.c (completing-read-function): New variable.
8130 (completing-read-default): Rename from completing-read.
8131 (completing-read): Call completing-read-function.
8132
b14e3e21
CY
81332011-03-19 Juanma Barranquero <lekktu@gmail.com>
8134
8135 * xfaces.c (Fx_load_color_file):
8136 Read color file from absolute filename (bug#8250).
8137
f2b726e6
JB
81382011-03-19 Juanma Barranquero <lekktu@gmail.com>
8139
8140 * makefile.w32-in: Update dependencies.
8141
09f6ff02
EZ
81422011-03-17 Eli Zaretskii <eliz@gnu.org>
8143
8144 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8145
29a6015a
PE
81462011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8147
a3a6c54e
PE
8148 Fix more problems found by GCC 4.5.2's static checks.
8149
b766f867
PE
8150 * process.c (make_serial_process_unwind, send_process_trap):
8151 (sigchld_handler): Now static.
8152
be02381c
PE
8153 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8154 That way, the code declares only the vars that it needs.
8155 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8156 * s/cygwin.h (PTY_ITERATION): Likewise.
8157 * s/darwin.h (PTY_ITERATION): Likewise.
8158 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8159
57048744
PE
8160 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8161 * process.c (allocate_pty): Don't declare stb unless it's needed.
8162
7914961c 8163 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8164 (CONSTANTLIM): Remove; unused.
8165 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8166 Define only if needed.
7914961c 8167
b3967b18
PE
8168 * unexelf.c (unexec): Name an expression,
8169 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8170 Use a different way to cause a compilation error if anyone uses
8171 n rather than nn, a way that does not involve shadowing.
73366a00 8172 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8173
29a6015a
PE
8174 * deps.mk (unexalpha.o): Remove; unused.
8175
43cfc33e 8176 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8177 * unexec.h: New file.
ce701a33
PE
8178 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8179 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8180 Depend on unexec.h.
8181 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8182 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8183 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8184 Change as necessary to match prototype in unexec.h.
ce701a33 8185
01f44d5a
PE
8186 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8187 shadowing.
4f63c6bb 8188 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8189
a6670b0b
PE
8190 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8191 Rename locals to avoid shadowing.
8192
cef2010d 8193 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8194 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8195
d4d7173a
PE
8196 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8197
f08b802a
PE
8198 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8199 warning when compiling print.c.
8200
3ddb0639
PE
8201 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8202 instead of using an uninitialized var.
5ad03b97 8203 (font_sort_entities): Mark var as initialized.
3ddb0639 8204
170a2692
PE
8205 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8206
e663c700
PE
8207 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8208 pointers to constants.
89bc529a 8209 (font_parse_fcname): Remove unused vars.
7b81e2d0 8210 (font_delete_unmatched): Now static.
ea838e10 8211 (font_get_spec): Remove; unused.
13a547c6
PE
8212 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8213 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8214 Rename or move locals to avoid shadowing.
e663c700 8215
2a80c887 8216 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8217 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8218
1384fa33 8219 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8220 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8221
8b2c52e9
PE
8222 * alloc.c (mark_backtrace): Move decl from here ...
8223 * lisp.h: ... to here, so that it can be checked.
8224
475545b5 8225 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8226 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8227 (lisp_indirect_variable): Name an expression,
8228 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8229 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8230
b1349114 8231 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8232 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8233 Use const pointer when appropriate.
b1349114 8234
a2928364
PE
8235 * lisp.h (get_system_name, get_operating_system_release):
8236 Move decls here, to check interfaces.
8237 * process.c (get_operating_system_release): Move decl to lisp.h.
8238 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8239 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8240 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8241 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8242 (Fformat_time_string, Fencode_time, Finsert_char):
8243 (Ftranslate_region_internal, Fformat):
8244 Rename or remove local vars to avoid shadowing.
9710023e 8245 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8246
a415e694
PE
8247 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8248 avoid shadowing.
8249
8ef4622d
PE
8250 * lisp.h (eassert): Check that the argument compiles, even if
8251 ENABLE_CHECKING is not defined.
8252
946f9a5b
PE
8253 * data.c (Findirect_variable): Name an expression, to avoid
8254 gcc -Wbad-function-cast warning.
112396d6 8255 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8256 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8257 (Fmake_variable_buffer_local, Fmake_local_variable):
8258 Mark variables as initialized.
52746918 8259 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8260
e5aab7e7 8261 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8262 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8263 Rename locals to avoid shadowing.
dff45157
PE
8264 (mark_stack): Move local variables into the #ifdef region where
8265 they're used.
7bc26fdb
PE
8266 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8267 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8268 needed otherwise.
8269 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8270 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8271 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8272
e5aab7e7
PE
8273 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8274 avoids undefined behavior in theory.
8275
4da60324
PE
8276 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8277
88043301
PE
8278 Use functions, not macros, for up- and down-casing (Bug#8254).
8279 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8280 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8281 to use the following functions instead of these macros.
8282 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8283 EMACS_INT, since callers assume the returned value fits in int.
8284 (upcase1): Likewise, for UPCASE_TABLE.
8285 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8286 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8287 the race-condition problem in the old DOWNCASE.
88043301 8288
19ed5445
PE
8289 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8290 Rename locals to avoid shadowing.
8291 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8292 (regex_compile, re_search_2, re_match_2_internal):
8293 Remove unused local vars.
952db0d7
PE
8294 (FREE_VAR): Rewrite so as not to use empty "else",
8295 which gcc can warn about.
da053e48 8296 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8297 (RETALLOC_IF): Define only if needed.
8298 (WORDCHAR_P): Likewise. This one is never needed, but is used
8299 only in a comment talking about a compiler bug, so put inside
8300 the #if 0 of that comment.
8301 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8302 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8303 Remove; unused.
19ed5445 8304
1f3561e4 8305 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8306 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8307 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8308
ded6f8f7
PE
8309 * search.c (simple_search): Remove unused var.
8310
dbd37a95
PE
8311 * dired.c (compile_pattern): Move decl from here ...
8312 * lisp.h: ... to here, so that it can be checked.
8313 (struct re_registers): New forward decl.
8314
7e47afad
PE
8315 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8316
85f24f61
PE
8317 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8318 All uses changed.
8319 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8320 Rename locals to avoid shadowing.
5671df8f 8321 (Fvertical_motion): Mark locals as initialized.
85f24f61 8322
181aa2be 8323 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8324 (casify_region): Mark local as initialized.
181aa2be 8325
930d429c
PE
8326 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8327
7082eac6
PE
8328 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8329 New macros, so that the caller can use some names other than
8330 gcpro1, gcpro2, etc.
8331 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8332 of the new macros.
8333 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8334 argument, for consistency with GCPRO2_VAR, etc: it is now the
8335 prefix of the variable, not the variable itself. All uses
8336 changed.
38b2c076
PE
8337 * dired.c (directory_files_internal, file_name_completion):
8338 Rename locals to avoid shadowing.
8339
15206ed9
PE
8340 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8341 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8342 dired.c's scmp function, had undefined behavior.
8343 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8344 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8345 * buffer.h: ... to here, because these macros use current_buffer,
8346 and the new implementation with inline functions needs to have
8347 current_buffer in scope now, rather than later when the macros
8348 are used.
8349 (downcase, upcase1): New static inline functions.
8350 (DOWNCASE, UPCASE1): Reimplement using these functions.
8351 This avoids undefined behavior in expressions like
8352 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8353 from race conditions in accessing the global variables
8354 case_temp1 and case_temp2.
8355 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8356 * lisp.h (case_temp1, case_temp2): Remove their decls.
8357 * character.h (ASCII_CHAR_P): Move from here ...
8358 * lisp.h: ... to here, so that the inline functions mentioned
8359 above can use them.
8360
4a6bea26
PE
8361 * dired.c (directory_files_internal_unwind): Now static.
8362
f14b7e14
PE
8363 * fileio.c (file_name_as_directory, directory_file_name):
8364 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8365 Now static.
2893f146
PE
8366 (file_name_as_directory): Use const pointers when appropriate.
8367 (Fexpand_file_name): Likewise. In particular, newdir might
8368 point at constant storage, so make it a const pointer.
fd4ead52 8369 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8370 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8371 signedness issues.
f839df0c
PE
8372 (Fset_file_times, Finsert_file_contents, auto_save_error):
8373 Rename locals to avoid shadowing.
f14b7e14 8374
5716756e 8375 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8376 (Ftry_completion, Fall_completions): Rename or remove locals
8377 to avoid shadowing.
5716756e 8378
b4c3046a
PE
8379 * marker.c (bytepos_to_charpos): Remove; unused.
8380
b45db522
PE
8381 * lisp.h (verify_bytepos, count_markers): New decls,
8382 so that gcc does not warn that these functions aren't declared.
8383
85876d07
PE
8384 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8385 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8386 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8387 (copy_text): Remove unused local var.
85876d07 8388
03d78a21 8389 * filelock.c (within_one_second): Now static.
b3dd38ab 8390 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8391
5df8f01b
PE
8392 * buffer.c (fix_overlays_before): Mark locals as initialized.
8393 (fix_start_end_in_overlays): Likewise. This function should be
8394 simplified by using pointers-to-pointers, but that's a different
8395 matter.
b1d876f1 8396 (switch_to_buffer_1): Now static.
8f54f30a
PE
8397 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8398 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8399
a70072c9 8400 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8401 Fix pointer signedness issue.
edced198
PE
8402 (sys_subshell): Mark local as volatile if checking for lint,
8403 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8404 (MAXPATHLEN): Define only if needed.
a70072c9 8405
a0977c44
PE
8406 * process.c (serial_open, serial_configure): Move decls from here ...
8407 * systty.h: ... to here, so that they can be checked.
8408
a884fdcc
PE
8409 * fns.c (get_random, seed_random): Move extern decls from here ...
8410 * lisp.h: ... to here, so that they can be checked.
8411
604efe86 8412 * sysdep.c (reset_io): Now static.
b8950c94 8413 (wait_for_termination_signal): Remove; unused.
604efe86 8414
38fc62d9
PE
8415 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8416 (copy_keymap_item, append_key, push_text_char_description):
8417 Now static.
1004a21a 8418 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8419 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8420 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8421 (describe_map_tree):
8422 Rename locals to avoid shadowing.
38fc62d9 8423
2f2650da
PE
8424 * keyboard.c: Declare functions static if they are not used elsewhere.
8425 (echo_char, echo_dash, cmd_error, top_level_2):
8426 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8427 (read_char, kbd_buffer_get_event, make_lispy_position):
8428 (make_lispy_event, make_lispy_movement, apply_modifiers):
8429 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8430 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8431 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8432 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8433 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8434
a053e86c 8435 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8436 (mark_kboards): Move decl here ...
8437 * alloc.c (mark_kboards): ... from here.
a053e86c 8438
4752793e
PE
8439 * lisp.h (force_auto_save_soon): New decl.
8440
74f10ca7 8441 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8442 (DEFINE_DUMMY_FUNCTION): New macro.
8443 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8444 Use it.
c03cd23f
PE
8445 (main): Add casts to avoid warnings
8446 if GCC considers string literals to be constants.
74f10ca7 8447
022e70d4
PE
8448 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8449
59d6fe83
PE
8450 * dbusbind.c: Pointer signedness fixes.
8451 (xd_signature, xd_append_arg, xd_initialize):
8452 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8453 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8454 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8455 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8456
78320123
PE
8457 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8458 if GCC considers string literals to be constants.
49cebcca 8459 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8460
35ac2a97
SM
84612011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8462
fb103ca9
SM
8463 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8464 (print_preprocess, print_object): New macro to fix last change.
8465
35ac2a97
SM
8466 * print.c (print_preprocess): Don't forget font objects.
8467
62973b41
JB
84682011-03-16 Juanma Barranquero <lekktu@gmail.com>
8469
8470 * emacs.c (USAGE3): Doc fixes.
8471
0e48bb22
AS
84722011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8473
8474 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8475 structure.
8476
7684e57b
JB
84772011-03-14 Juanma Barranquero <lekktu@gmail.com>
8478
8479 * lisp.h (VWindow_system, Qfile_name_history):
8480 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8481 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8482 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8483
8484 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8485 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8486
8487 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8488 * w32console.c (detect_input_pending, read_input_pending)
8489 (encode_terminal_code):
8490 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8491 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8492 (w32_system_caret_y, Qfile_name_history):
8493 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8494 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8495 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8496 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8497 * w32proc.c (Qlocal, report_file_error):
8498 * w32term.c (Vwindow_system, updating_frame):
8499 * w32uniscribe.c (initialized, uniscribe_font_driver):
8500 Remove unneeded extern declarations.
8501
2aa46d6c
CY
85022011-03-14 Chong Yidong <cyd@stupidchicken.com>
8503
c96bbc66 8504 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8505
cffc6f3b
CY
85062011-03-13 Chong Yidong <cyd@stupidchicken.com>
8507
8508 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8509 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8510 These macros can no longer be used for assignment.
8511
44f230aa
SM
8512 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8513 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8514 (record_buffer_markers, fetch_buffer_markers): New functions for
8515 recording and fetching special buffer markers.
8516 (set_buffer_internal_1, set_buffer_temp): Use them.
8517
8518 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8519
8520 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8521
8522 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8523 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8524
8525 * xdisp.c (hscroll_window_tree):
8526 (reconsider_clip_changes): Use PT instead of BUF_PT.
8527
d251f04b
EZ
85282011-03-13 Eli Zaretskii <eliz@gnu.org>
8529
8530 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8531 $(EMACS_ROOT)/lib/intprops.h.
8532
f0c77cd1
PE
85332011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8534
3eca4629
PE
8535 Fix more problems found by GCC 4.5.2's static checks.
8536
7c86ee98
PE
8537 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8538 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8539 (xg_free_frame_widgets): Make it clear that a local variable is
8540 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8541 (gdk_window_get_screen): Make it clear that this macro is needed
8542 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8543 (int_gtk_range_get_value): New function, which avoids a diagnostic
8544 from gcc -Wbad-function-cast.
8545 (xg_set_toolkit_scroll_bar_thumb): Use it.
8546 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8547 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8548 (get_utf8_string, xg_get_file_with_chooser):
8549 Rename locals to avoid shadowing.
8550 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8551
41729b81
PE
8552 * xgselect.c (xg_select): Remove unused var.
8553
f0c77cd1
PE
8554 * image.c (four_corners_best): Mark locals as initialized.
8555 (gif_load): Initialize transparent_p to zero (Bug#8238).
8556 Mark another local as initialized.
ec6cf4c6 8557 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8558
ce0ad53d 8559 * image.c (clear_image_cache): Now static.
d5d5a617 8560 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8561 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8562 (x_edge_detection): Remove unnecessary cast that
8563 gcc -Wbad-function-cast diagnoses.
2037898d 8564 (gif_load): Fix pointer signedness.
6ae141d6
PE
8565 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8566 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8567
33383987 85682011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8569
d32df629
PE
8570 Improve quality of tests for time stamp overflow.
8571 For example, without this patch (encode-time 0 0 0 1 1
8572 1152921504606846976) returns the obviously-bogus value (-948597
8573 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8574 reports time overflow. See
8575 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8576 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8577 * editfns.c: Include limits.h and intprops.h.
8578 (TIME_T_MIN, TIME_T_MAX): New macros.
8579 (time_overflow): Move earlier, to before first use.
8580 (hi_time, lo_time): New functions, for an accurate test for
8581 out-of-range times.
8582 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8583 (Fget_internal_run_time): Don't assume time_t fits in int.
8584 (make_time): Use list2 instead of Fcons twice.
8585 (Fdecode_time): More accurate test for out-of-range times.
8586 (check_tm_member): New function.
8587 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8588 (lisp_time_argument): Don't rely on undefined left-shift and
8589 right-shift behavior when checking for time stamp overflow.
8be6f318 8590
fe31d94c
PE
8591 * editfns.c (time_overflow): New function, refactoring common code.
8592 (Fformat_time_string, Fdecode_time, Fencode_time):
8593 (Fcurrent_time_string): Use it.
8594
8be6f318
PE
8595 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8596 * dired.c (make_time): Move to ...
8597 * editfns.c (make_time): ... here.
8598 * systime.h: Note the move.
8599
09d9db2c 86002011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8601
126bc0dc
YM
8602 * fringe.c (update_window_fringes): Remove unused variables.
8603
c47cbdfd
YM
8604 * unexmacosx.c (copy_data_segment): Also copy __got section.
8605 (Bug#8223)
8606
7ac80be9
EZ
86072011-03-12 Eli Zaretskii <eliz@gnu.org>
8608
c96bbc66 8609 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8610 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8611 Constify `char *' arguments and their references according to
8612 prototypes in tparam.h.
8613
ecb0f94d 8614 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8615
7ac80be9
EZ
8616 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8617 Adapt all references accordingly.
8618
8619 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8620
ef1fd07e
TT
86212011-03-11 Tom Tromey <tromey@redhat.com>
8622
8623 * buffer.c (syms_of_buffer): Remove obsolete comment.
8624
7ef4b50c
EZ
86252011-03-11 Eli Zaretskii <eliz@gnu.org>
8626
8627 * termhooks.h (encode_terminal_code): Declare prototype.
8628
8629 * msdos.c (encode_terminal_code): Don't declare prototype.
8630
8631 * term.c (encode_terminal_code): Now external again, used by
8632 w32console.c and msdos.c.
8633
44f230aa
SM
8634 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8635 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8636
4b1ec863 86372011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8638
1714f52b 8639 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8640
4b1ec863
PE
8641 * fringe.c (update_window_fringes): Mark locals as initialized
8642 (Bug#8227).
8643 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8644
524c7aa6
PE
8645 * alloc.c (mark_fringe_data): Move decl from here ...
8646 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8647 to check its interface.
8648 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8649
a5c0af81 8650 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8651 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8652 (fontset_font): Mark local as initialized.
a9a06e0b 8653 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8654
b4716021
PE
8655 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8656
811e9bac 8657 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8658 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8659 (x_own_selection, Fx_disown_selection_internal): Rename locals
8660 to avoid shadowing.
8661 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8662
7e3ab302
PE
8663 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8664 so that the caller can use some name other than gcpro1.
8665 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8666 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8667 (Fx_backspace_delete_keys_p):
8668 Use them to avoid shadowing, and rename vars to avoid shadowing.
8669 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8670 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8671 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8672 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8673 Remove unused locals.
7e3ab302
PE
8674 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8675 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8676 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8677 macros.
f78faa98 8678
e2b13473
PE
8679 * xterm.h (x_mouse_leave): New decl.
8680
77f23912
PE
8681 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8682 Remove unused functions.
cdf4ba58
PE
8683 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8684 (x_calc_absolute_position): Now static.
7411c686 8685 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8686 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8687 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8688 unless they are used.
38d0b34a
PE
8689 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8690 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8691 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8692 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8693 (x_error_catcher, x_connection_closed, x_error_handler):
8694 (x_error_quitter, xembed_send_message, x_iconify_frame):
8695 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8696 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8697 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8698
44f230aa
SM
8699 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8700 Rename or move locals to avoid shadowing.
6b463e58 8701 (tty_defined_color, merge_face_heights): Now static.
5967d051 8702 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8703 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8704 does not deduce is never used uninitialized.
73719eba
PE
8705 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8706 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8707
426994c3 8708 * terminal.c (store_terminal_param): Now static.
5489860b 8709
032f1620 8710 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8711 (set_frame_menubar): Remove unused local.
d4323972 8712 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8713 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8714 since they might point to immutable storage.
281585b0
PE
8715 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8716 since it's unused otherwise.
032f1620 8717
367c19e5 8718 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8719 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8720 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8721 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8722 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8723 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8724 does not deduce are never used uninitialized.
70739cbe 8725
07b48fa9
PE
8726 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8727
8868a238 8728 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8729 * window.c (window_loop, size_window):
8730 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8731
7e5cf297 8732 * window.c (display_buffer): Now static.
d6550a9f
PE
8733 (size_window): Mark variables that gcc -Wuninitialized
8734 does not deduce are never used uninitialized.
a586633d
PE
8735 * window.h (check_all_windows): New decl, to forestall
8736 gcc -Wmissing-prototypes diagnostic.
5b555da1 8737 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8738
f6095868
PE
8739 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8740 shadowing.
8741 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8742 Include <limits.h>.
8743 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8744 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8745 (load_charset_map): Mark variables that gcc -Wuninitialized
8746 does not deduce are never used uninitialized.
53df7c11 8747 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8748
f38b440c
PE
8749 * coding.c (coding_set_source, coding_set_destination):
8750 Use "else { /* comment */ }" rather than "else /* comment */;"
8751 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8752 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8753 a block, when the outer 'i' will do.
8754 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8755 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8756 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8757 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8758 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8759 Rename locals to avoid shadowing.
8760 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8761 * coding.c (emacs_mule_char, encode_invocation_designation):
8762 Now static, since they're not used elsewhere.
413bb2db 8763 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8764 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8765 (decode_coding_emacs_mule): Mark variables that gcc
8766 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8767 (detect_coding_iso_2022): Initialize a local variable that might
8768 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8769 this initialization is needed. (Bug#8211)
5f58e762
PE
8770 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8771 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8772 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8773 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8774 Remove unused macros.
f38b440c 8775
232b38b9 8776 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8777 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8778 * character.c (string_count_byte8): Likewise.
232b38b9 8779
fb90da1b
PE
8780 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8781 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8782
fb93dbc2
PE
8783 * chartab.c (copy_sub_char_table): Now static, since it's not used
8784 elsewhere.
5c156ace
PE
8785 (sub_char_table_ref_and_range, char_table_ref_and_range):
8786 Rename locals to avoid shadowing.
bbcd0949 8787 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8788
7d3b3862 8789 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8790 (BIDI_BOB): Remove unused macro.
7d3b3862 8791
6be7d3da
PE
8792 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8793 deduce are never used uninitialized.
c2ed9c8b 8794 * term.c (encode_terminal_code): Likewise.
6be7d3da 8795
75f8807f 8796 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8797
50938595
PE
8798 * tparam.h: New file.
8799 * term.c, tparam.h: Include it.
8800 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8801 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8802 Move these decls to tparam.h, and make them agree with what
8803 is actually in tparam.c. The previous trick of using incompatible
8804 decls in different modules does not conform to the C standard.
8805 All callers of tparam changed to use tparam's actual API.
8806 * tparam.c (tparam1, tparam, tgoto):
8807 Use const pointers where appropriate.
8808
fbceeba2
PE
8809 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8810 * cm.h (struct cm): Likewise.
8811 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8812 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8813 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8814 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8815 (turn_on_face, init_tty): Likewise.
8816 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8817
7f3f1250
PE
8818 * term.c (term_mouse_position): Rename local to avoid shadowing.
8819
e6ca6543
PE
8820 * alloc.c (mark_ttys): Move decl from here ...
8821 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8822
c40f8d15
AS
88232011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8824
8825 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8826
cfe0661d
JB
88272011-03-09 Juanma Barranquero <lekktu@gmail.com>
8828
8829 * search.c (compile_pattern_1): Remove argument regp, unused since
8830 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8831 (compile_pattern): Don't pass it.
8832
0afb4571
J
88332011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8834
8835 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8836 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8837 for ! HAVE_GTK3.
8838 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8839
8840 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8841
8842 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8843 gdk_window_get_screen, gdk_window_get_geometry,
8844 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8845 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8846 (xg_get_pixbuf_from_pixmap): New function.
8847 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8848 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8849 Call xg_get_pixbuf_from_pixmap instead of
8850 gdk_pixbuf_get_from_drawable.
8851 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8852 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8853 (xg_check_special_colors): Use GtkStyleContext and its functions
8854 for HAVE_GTK3.
8855 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8856 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8857 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8858 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8859 Call gtk_widget_get_preferred_size.
0afb4571
J
8860 (xg_frame_resized): gdk_window_get_geometry only takes 5
8861 parameters.
44f230aa
SM
8862 (xg_win_to_widget, xg_event_is_for_menubar):
8863 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8864 (xg_set_widget_bg): New function.
8865 (delete_cb): New function.
895009e1 8866 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 8867 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
8868 (xg_set_background_color): Call xg_set_widget_bg.
8869 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8870 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8871 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8872 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8873 if ! HAVE_GTK3.
8874 (update_frame_tool_bar): Call gtk_widget_hide.
8875 (xg_initialize): Use GDK_KEY_g.
8876
8877 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8878 if ! HAVE_GTK3
8879 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8880
8881 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8882 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8883 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8884
1c2cc4ef
JB
88852011-03-08 Juanma Barranquero <lekktu@gmail.com>
8886
8887 * w32xfns.c (select_palette): Check success of RealizePalette against
8888 GDI_ERROR, not zero.
8889
33383987 8890See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8891
8892;; Local Variables:
8893;; coding: utf-8
aac0c6e3
MR
8894;; End:
8895
33383987 8896 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8897
8898 This file is part of GNU Emacs.
8899
8900 GNU Emacs is free software: you can redistribute it and/or modify
8901 it under the terms of the GNU General Public License as published by
8902 the Free Software Foundation, either version 3 of the License, or
8903 (at your option) any later version.
8904
8905 GNU Emacs is distributed in the hope that it will be useful,
8906 but WITHOUT ANY WARRANTY; without even the implied warranty of
8907 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8908 GNU General Public License for more details.
8909
8910 You should have received a copy of the GNU General Public License
8911 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.