(view-buffer): Allow running in `special' modes if we're visiting a file.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
b59b67c5
PE
12011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2
15e3a074
PE
3 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4 This fixes some race conditions on the permissions of any newly
5 created file.
6
41bed37d
PE
7 * alloc.c (valid_pointer_p): Use pipe, not open.
8 This fixes some permissions issues when debugging.
9
b59b67c5
PE
10 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
11 If fchown fails to set both uid and gid, try to set just gid,
12 as that is sometimes allowed. Adjust the file's mode to eliminate
13 setuid or setgid bits that are inappropriate if fchown fails.
14
925a6be7
SM
152011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
16
17 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
18 to compare Lisp_Objects.
19 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
20 global_gnutls_log_level, don't mistake it for a Lisp_Object.
21 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
22
52968808
AS
232011-07-17 Andreas Schwab <schwab@linux-m68k.org>
24
0a6a104b
AS
25 * lread.c (read_integer): Unread even EOF character.
26 (read1): Likewise. Properly record start position of symbol.
27
52968808
AS
28 * lread.c (read1): Read `#:' as empty uninterned symbol if no
29 symbol character follows.
30
9e381cdd
PE
312011-07-17 Paul Eggert <eggert@cs.ucla.edu>
32
33 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
34 This works around a problem with the previous change to Fcopy_file.
35 Recent glibc declares fchown with __attribute__((warn_unused_result)),
36 and without this change, GCC might complain about discarding
37 fchown's return value.
38
b5641435
JB
392011-07-16 Juanma Barranquero <lekktu@gmail.com>
40
41 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
42
a8031457
PE
432011-07-16 Paul Eggert <eggert@cs.ucla.edu>
44
45 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
46
dd889327
LMI
472011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
48
750c33f7
LMI
49 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
50 it's used from the C level.
51
dd889327
LMI
52 * process.c: Use the same condition for POLL_FOR_INPUT in both
53 keyboard.c and process.c (bug#1858).
54
87e86684
LM
552011-07-09 Lawrence Mitchell <wence@gmx.li>
56
57 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
58 (Fgnutls_boot): Use it.
59
64348f40
AS
602011-07-15 Andreas Schwab <schwab@linux-m68k.org>
61
62 * doc.c (Fsubstitute_command_keys): Revert last change.
63
1d698799
LMI
642011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
65
f863868c
LMI
66 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
67 quotes the next character, and doesn't affect other longer
68 sequences (bug#8935).
69
1d698799
LMI
70 * lread.c (syms_of_lread): Clarify that is isn't only
71 `eval-buffer' and `eval-defun' that's affected by
72 `lexical-binding' (bug#8460).
73
aa4b6df6
EZ
742011-07-15 Eli Zaretskii <eliz@gnu.org>
75
76 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
77 bidi redisplay when a line includes both an image and is
78 truncated.
79
5d856da6
PE
802011-07-14 Paul Eggert <eggert@cs.ucla.edu>
81
ad6042bb
PE
82 Fix minor problems found by static checking.
83 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
84 (elsz): Now a signed constant, not a size_t var. We prefer signed
85 types to unsigned, to avoid integer comparison confusion. Without
86 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
87 "cannot optimize loop, the loop counter may overflow", a symptom
88 of the confusion.
f00bbb22 89 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
90 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
91
6468f31c
LMI
922011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
93
49080b10
LMI
94 * search.c (Fre_search_backward): Mention `case-fold-search' in
95 all the re_search_* functions (bug#8138).
96
6468f31c
LMI
97 * keyboard.c (Fopen_dribble_file): Document when the file is
98 closed (bug#8056).
99
c965adc5
EZ
1002011-07-14 Eli Zaretskii <eliz@gnu.org>
101
df9733bf
EZ
102 * bidi.c (bidi_dump_cached_states): Fix format of displaying
103 bidi_cache_idx.
104
0bb23927
EZ
105 Support bidi reordering of display and overlay strings.
106 * xdisp.c (compute_display_string_pos)
107 (compute_display_string_end): Accept additional argument STRING.
108 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
109 (reseat_to_string): Initialize bidi_it->string.s and
110 bidi_it->string.schars.
111 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
112 NULL (avoids a crash in bidi_paragraph_init). Initialize
113 itb.string.lstring.
114 (init_iterator): Call bidi_init_it only of a valid
115 buffer position was specified. Initialize paragraph_embedding to
116 L2R.
117 (reseat_to_string): Initialize the bidi iterator.
118 (display_string): If we need to ignore text properties of
119 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
120 original value of -1 will not work with bidi.)
121 (compute_display_string_pos): First arg is now struct
122 `text_pos *'; all callers changed. Support display properties on
123 Lisp strings.
124 (compute_display_string_end): Support display properties on Lisp
125 strings.
126 (init_iterator, reseat_1, reseat_to_string): Initialize the
127 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
128 when iterating on a string not from display properties).
129 (compute_display_string_pos, compute_display_string_end): Fix
130 calculation of the object to scan. Fixes an error when using
131 arrow keys.
132 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
133 base_level_stop; instead, set base_level_stop to BEGV. Fixes
134 crashes in vertical-motion.
135 (next_element_from_buffer): Improve commentary for when
136 the iterator is before prev_stop.
137 (init_iterator): Initialize bidi_p from the default value of
138 bidi-display-reordering, not from buffer-local value. Use the
139 buffer-local value only if initializing for buffer iteration.
140 (handle_invisible_prop): Support invisible properties on strings
141 that are being bidi-reordered.
142 (set_iterator_to_next): Support bidi reordering of C strings and
143 Lisp strings.
144 (next_element_from_string): Support bidi reordering of Lisp
145 strings.
146 (handle_stop_backwards): Support Lisp strings as well.
147 (display_string): Support display of R2L glyph rows. Use
148 IT_STRING_CHARPOS when displaying from a Lisp string.
149 (init_iterator): Don't initialize it->bidi_p for strings
150 here.
151 (reseat_to_string): Initialize it->bidi_p for strings here.
152 (next_element_from_string, next_element_from_c_string)
153 (next_element_from_buffer): Add xassert's for correspondence
154 between IT's object being iterated and it->bidi_it.string
155 structure.
156 (face_before_or_after_it_pos): Support bidi iteration.
157 (next_element_from_c_string): Handle the case of the first string
158 character that is not the first one in the visual order.
159 (get_visually_first_element): New function, refactored from common
160 parts of next_element_from_buffer, next_element_from_string, and
161 next_element_from_c_string.
162 (tool_bar_lines_needed, redisplay_tool_bar)
163 (display_menu_bar): Force left-to-right direction. Add a FIXME
164 comment for making that be controlled by a user option.
165 (push_it, pop_it): Save and restore the state of the
166 bidi iterator. Save and restore the bidi_p flag.
167 (pop_it): Iterate out of display property for string iteration as
168 well.
169 (iterate_out_of_display_property): Support iteration over strings.
170 (handle_single_display_spec): Set up it->bidi_it for iteration
171 over a display string, and call bidi_init_it.
172 (handle_single_display_spec, next_overlay_string)
173 (get_overlay_strings_1, push_display_prop): Set up the bidi
174 iterator for displaying display or overlay strings.
175 (forward_to_next_line_start): Don't use the shortcut if
176 bidi-iterating.
177 (back_to_previous_visible_line_start): If handle_display_prop
178 pushed the iterator stack, restore the internal state of the bidi
179 iterator by calling bidi_pop_it same number of times.
180 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
181 and we are bidi-iterating, don't decrement the iterator position;
182 instead, set the first_elt flag in the bidi iterator, to produce
183 the same effect.
184 (reseat_1): Remove redundant setting of string_from_display_prop_p.
185 (push_display_prop): xassert that we are iterating a buffer.
186 (push_it, pop_it): Save and restore paragraph_embedding member.
187 (handle_single_display_spec, next_overlay_string)
188 (get_overlay_strings_1, reseat_1, reseat_to_string)
189 (push_display_prop): Set up the `unibyte' member of bidi_it.string
190 correctly. Don't assume unibyte strings are not bidi-reordered.
191 (compute_display_string_pos)
192 (compute_display_string_end): Fix handling the case of C string.
193 (push_it, pop_it): Save and restore from_disp_prop_p.
194 (handle_single_display_spec, push_display_prop): Set the
195 from_disp_prop_p flag.
196 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
197 (pop_it): Call iterate_out_of_display_property only if we are
198 popping after iteration over a string that came from a display
199 property. Fix a typo in popping stretch info. Add an assertion
200 for verifying that the iterator position is in sync with the bidi
201 iterator.
202 (handle_single_display_spec, get_overlay_strings_1)
203 (push_display_prop): Fix initialization of paragraph direction for
204 string when that of the parent object is not yet determined.
205 (reseat_1): Call bidi_init_it to resync the bidi
206 iterator with IT's position. (Bug#7616)
207 (find_row_edges): If ROW->start.pos gives position
208 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
209 (handle_stop, back_to_previous_visible_line_start, reseat_1):
210 Reset the from_disp_prop_p flag.
211 (SAVE_IT, RESTORE_IT): New macros.
212 (pos_visible_p, face_before_or_after_it_pos)
213 (back_to_previous_visible_line_start)
214 (move_it_in_display_line_to, move_it_in_display_line)
215 (move_it_to, move_it_vertically_backward, move_it_by_lines)
216 (try_scrolling, redisplay_window, display_line): Use them when
217 saving a temporary copy of the iterator and restoring it back.
218 (back_to_previous_visible_line_start, reseat_1)
219 (init_iterator): Empty the bidi cache "stack".
220 (move_it_in_display_line_to): If iterator ended up at
221 EOL, but we never saw any buffer positions smaller than
222 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
223 motion in bidi-reordered lines.
224 (move_it_in_display_line_to): Record prev_method and prev_pos
225 immediately before the call to set_iterator_to_next. Fixes cursor
226 motion in bidi-reordered lines with stretch glyphs and strings
227 displayed in margins. (Bug#8133) (Bug#8867)
228 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
229 TO_CHARPOS.
230 (pos_visible_p): Support positions in bidi-reordered lines. Save
231 and restore bidi cache.
232
233 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
234 (bidi_paragraph_info): Delete unused struct.
235 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
236 (bidi_cache_start): New variable.
237 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
238 to zero.
239 (bidi_cache_fetch_state, bidi_cache_search)
240 (bidi_cache_find_level_change, bidi_cache_iterator_state)
241 (bidi_cache_find, bidi_peek_at_next_level)
242 (bidi_level_of_next_char, bidi_find_other_level_edge)
243 (bidi_move_to_visually_next): Compare cache index with
244 bidi_cache_start rather than with zero.
245 (bidi_fetch_char): Accept new argument STRING; all callers
246 changed. Support iteration over a string. Support strings with
247 display properties. Support unibyte strings. Fix the type of
248 `len' according to what STRING_CHAR_AND_LENGTH expects.
249 (bidi_paragraph_init, bidi_resolve_explicit_1)
250 (bidi_resolve_explicit, bidi_resolve_weak)
251 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
252 iteration over a string.
253 (bidi_set_sor_type, bidi_resolve_explicit_1)
254 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
255 can now be zero (for strings); special values 0 and -1 were
256 changed to -1 and -2, respectively.
257 (bidi_char_at_pos): New function.
258 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
259 Call it instead of FETCH_MULTIBYTE_CHAR.
260 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
261 initialized to valid values.
262 (bidi_init_it): Don't initialize charpos and bytepos with invalid
263 values.
264 (bidi_level_of_next_char): Allow the sentinel "position" to pass
265 the test for valid cached positions. Fix the logic for looking up
266 the sentinel state in the cache. GCPRO the Lisp string we are
267 iterating.
268 (bidi_push_it, bidi_pop_it): New functions.
269 (bidi_initialize): Initialize the bidi cache start stack pointer.
270 (bidi_cache_ensure_space): New function, refactored from part of
271 bidi_cache_iterator_state. Don't assume the required size is just
272 one BIDI_CACHE_CHUNK away.
273 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
274 (bidi_count_bytes, bidi_char_at_pos): New functions.
275 (bidi_cache_search): Don't assume bidi_cache_last_idx is
276 always valid if bidi_cache_idx is valid.
277 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
278 is valid if it's going to be used.
279 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
280 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
281 (bidi_cache_find_level_change, bidi_cache_ensure_space)
282 (bidi_cache_iterator_state, bidi_cache_find)
283 (bidi_find_other_level_edge, bidi_cache_start_stack): All
284 variables related to cache indices are now EMACS_INT.
285
0bb23927
EZ
286 * dispextern.h (struct bidi_string_data): New structure.
287 (struct bidi_it): New member `string'. Make flag members be 1-bit
288 fields, and put them last in the struct.
289 (compute_display_string_pos, compute_display_string_end): Update
290 prototypes.
291 (bidi_push_it, bidi_pop_it): Add prototypes.
292 (struct iterator_stack_entry): New members bidi_p,
293 paragraph_embedding, and from_disp_prop_p.
294 (struct it): Member bidi_p is now a bit field 1 bit wide.
295 (bidi_shelve_cache, bidi_unshelve_cache): Declare
296 prototypes.
297
298 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
299 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
300 and vector-like objects.
301
302 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
303 cache around display iteration.
304
305 * window.c (Fwindow_end, window_scroll_pixel_based)
306 (displayed_window_lines, Frecenter): Save and restore the bidi
307 cache around display iteration.
308
3bbd2265
LMI
3092011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
310
311 * editfns.c (Fdelete_region): Clarify the use of the named
312 parameters (bug#6788).
313
adc47434
MR
3142011-07-14 Martin Rudalics <rudalics@gmx.at>
315
316 * indent.c (Fvertical_motion): Set and restore w->pointm when
317 saving and restoring the window's buffer (Bug#9006).
318
837c31f8
LMI
3192011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
320
321 * editfns.c (Fstring_to_char): Clarify just what is returned
322 (bug#6576). Text by Eli Zaretskii.
323
ac389d0c
JB
3242011-07-13 Juanma Barranquero <lekktu@gmail.com>
325
326 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
327
0be0ce47
EZ
3282011-07-13 Eli Zaretskii <eliz@gnu.org>
329
330 * buffer.c (mmap_find): Fix a typo.
331
cd18e7e3
JB
3322011-07-13 Johan Bockgård <bojohan@gnu.org>
333
334 Fix execution of x selection hooks.
335 * xselect.c (Qx_lost_selection_functions)
336 (Qx_sent_selection_functions): New vars.
337 (syms_of_xselect): DEFSYM them.
338 (x_handle_selection_request): Pass Qx_sent_selection_functions
339 rather than Vx_sent_selection_functions to Frun_hook_with_args.
340 (x_handle_selection_clear,x_clear_frame_selections):
341 Pass Qx_lost_selection_functions rather than
342 Vx_lost_selection_functions to Frun_hook_with_args.
343
47ea7f44
PE
3442011-07-13 Paul Eggert <eggert@cs.ucla.edu>
345
ac389d0c 346 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
347 The old code sometimes used this field without initializing it.
348
47ea7f44
PE
349 * alloc.c (gc_sweep): Don't read past end of array.
350 In theory, the old code could also have corrupted Emacs internals,
351 though it'd be very unlikely.
352
bc985c87
AS
3532011-07-12 Andreas Schwab <schwab@linux-m68k.org>
354
355 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 356 argument. (Bug#4026)
bc985c87 357
0cf34688
LMI
3582011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
359
b3dadd76
LMI
360 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
361 key" (bug#4257).
362
0cf34688
LMI
363 * window.c (Fset_window_start): Doc fix (bug#4199).
364 (Fset_window_hscroll): Ditto.
365
270768cd
PE
3662011-07-12 Paul Eggert <eggert@cs.ucla.edu>
367
077e3dda 368 Fix minor new problems caught by GCC 4.6.1.
270768cd 369 * term.c (init_tty): Remove unused local.
490011a6 370 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 371 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 372 not used otherwise.
270768cd 373
b1f58454
CY
3742011-07-12 Chong Yidong <cyd@stupidchicken.com>
375
376 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
377
22b9578d
LMI
3782011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
379
6e70ab07
LMI
380 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
381 are the mini-buffer and the echo area (bug#3320).
382
22b9578d
LMI
383 * term.c (init_tty): Remove support for supdup, c10 and perq
384 terminals, which are no longer supported (bug#1482).
385
8974cc9f
JB
3862011-07-10 Johan Bockgård <bojohan@gnu.org>
387
388 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
389
a560d974
JD
3902011-07-10 Jan Djärv <jan.h.d@swipnet.se>
391
392 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
393 for non-popups (Bug#3642).
394
1dae0f0a
AS
3952011-07-10 Andreas Schwab <schwab@linux-m68k.org>
396
268c2c36 397 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 398 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
399 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
400 * cm.c (losecursor): Likewise.
1dae0f0a
AS
401 * data.c (fmod): Likewise.
402 * dispnew.c (swap_glyphs_in_rows): Likewise.
403 * emacs.c (memory_warning_signal): Likewise.
404 * floatfns.c (float_error): Likewise.
405 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
406 (otf_open, font_otf_capability, generate_otf_features)
407 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
408 Likewise.
409 * image.c (pbm_read_file): Likewise.
410 * indent.c (string_display_width): Likewise.
411 * intervals.c (check_for_interval, search_for_interval)
412 (inc_interval_count, count_intervals, root_interval)
413 (adjust_intervals_for_insertion, make_new_interval): Likewise.
414 * lread.c (defalias): Likewise.
268c2c36 415 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
416 * regex.c (set_image_of_range_1, set_image_of_range)
417 (regex_grow_registers): Likewise.
418 * sysdep.c (strerror): Likewise.
419 * termcap.c (valid_filename_p, tprint, main): Likewise.
420 * tparam.c (main): Likewise.
421 * unexhp9k800.c (run_time_remap, save_data_space)
422 (update_file_ptrs, read_header, write_header, calculate_checksum)
423 (copy_file, copy_rest, display_header): Likewise.
424 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
425 Likewise.
426 * xdisp.c (check_it): Likewise.
427 * xfaces.c (register_color, unregister_color, unregister_colors):
428 Likewise.
429 * xfns.c (print_fontset_result): Likewise.
430 * xrdb.c (member, fatal, main): Likewise.
431
99033785
PE
4322011-07-10 Paul Eggert <eggert@cs.ucla.edu>
433
434 Fix minor problems found by static checking (Bug#9031).
435 * chartab.c (char_table_set_range, map_sub_char_table):
436 Remove unused locals.
437 (uniprop_table): Now static.
438 * composite.c (_work_char): Remove unused static var.
439
9cb2ac56
JB
4402011-07-09 Juanma Barranquero <lekktu@gmail.com>
441
442 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
443
f25661f0
JD
4442011-07-09 Jan Djärv <jan.h.d@swipnet.se>
445
446 * gtkutil.c (qttip_cb): Remove code without function.
447
8278c4fe
EZ
4482011-07-09 Eli Zaretskii <eliz@gnu.org>
449
450 * w32.c (pthread_sigmask): New stub.
451
1692ae2d 4522011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 453
8a6ebd58 454 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
455 sigprocmask is portable only for single-threaded applications, and
456 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
457 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
458 (LIBES): Use it.
459 * callproc.c (Fcall_process):
460 * process.c (create_process):
461 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
462 Use pthread_sigmask, not sigprocmask.
123403e4 463
1b854618
JD
4642011-07-08 Jan Djärv <jan.h.d@swipnet.se>
465
466 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
467 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
468 wrong (Bug#8591).
469
3fe4b549
JD
4702011-07-08 Jan Djärv <jan.h.d@swipnet.se>
471
0ce7e563
JD
472 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
473 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
474 (xg_hide_tooltip): Fix comment.
475
3fe4b549
JD
476 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
477 in registerServicesMenuSendTypes.
478 (validRequestorForSendType): Don't check ns_return_types.
479
480 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
481 ns_return_type.
482
5df75e47
JR
4832011-07-08 Jason Rumney <jasonr@gnu.org>
484
485 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
486 frame struct members of non-existent frames (Bug#6284).
487
699c10bd
JD
4882011-07-08 Jan Djärv <jan.h.d@swipnet.se>
489
4393663b
JD
490 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
491 variable firstTime not needed on OSX >= 10.6.
492 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
493 >= 10.5. Use setKnobProportion, setDoubleValue.
494
495 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
496 (MAC_OS_X_VERSION_10_5): Define if not defined.
497 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
498 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
499 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
500
501 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
502 cString and lossyCString on OSX >= 10.4
503
504 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
505 sizeToFit on OSX >= 10.2.
506
507 * nsimage.m (allocInitFromFile): Don't use deprecated method
508 bestRepresentationForDevice on OSX >= 10.6.
509
510 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
511 to avoid warning.
512
513 * emacs.c: Declare unexec_init_emacs_zone.
514
a63e0781
JD
515 * nsgui.h: Fix compiler warning about gnulib redefining verify.
516
699c10bd
JD
517 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
518
519 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
520 on svcsMenu (Bug#8842).
521
522 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
523 ns_return_types.
524 (Fns_list_services): Just return Qnil on 10.6, code not working there.
525
526 * nsterm.m (QUTF8_STRING): Declare.
527 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
528 (validRequestorForSendType): Return type is (id).
529 Change indexOfObjectIdenticalTo to indexOfObject.
530 Check if we have local selection before returning self (Bug#8842).
531 (writeSelectionToPasteboard): Put local selection into paste board
532 if we have a local selection (Bug#8842).
533 (syms_of_nsterm): DEFSYM QUTF8_STRING.
534
535 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
536 (ns_get_local_selection): Declare.
537
54e10184
LMI
5382011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
539
9888ff71
LMI
540 * keymap.c (describe_map_tree): Don't insert a double newline at
541 the end of the buffer (bug#1169) and return whether we inserted
542 something.
543
54e10184
LMI
544 * callint.c (Fcall_interactively): Change "reading args" to
545 "providing args" to try to clarify what it does (bug#1010).
546
15fa4783
KH
5472011-07-07 Kenichi Handa <handa@m17n.org>
548
549 * composite.c (composition_compute_stop_pos): Ignore a static
550 composition starting before CHARPOS (Bug#8915).
551
552 * xdisp.c (handle_composition_prop): Likewise.
553
a8815b00
EZ
5542011-07-07 Eli Zaretskii <eliz@gnu.org>
555
556 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
557 (Bug#9015)
558
ef7b981d 5592011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
560
561 * character.h (unicode_category_t): New enum type.
562
563 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
564 (Qchar_code_property_table): New variable.
565 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
566 (UNIPROP_COMPRESSED_FORM_P): New macros.
567 (char_table_ascii): Uncompress the compressed values.
568 (sub_char_table_ref): New arg is_uniprop. Callers changed.
569 Uncompress the compressed values.
ac389d0c 570 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
571 (char_table_ref_and_range): Uncompress the compressed values.
572 (sub_char_table_set): New arg is_uniprop. Callers changed.
573 Uncompress the compressed values.
574 (sub_char_table_set_range): Args changed. Callers changed.
575 (char_table_set_range): Adjuted for the above change.
576 (map_sub_char_table): Delete args default_val and parent. Add arg
577 top. Give decoded values to a Lisp function.
578 (map_char_table): Adjusted for the above change. Give decoded
579 values to a Lisp function. Gcpro more variables.
580 (uniprop_table_uncompress)
581 (uniprop_decode_value_run_length): New functions.
582 (uniprop_decoder, uniprop_decoder_count): New variables.
583 (uniprop_get_decoder, uniprop_encode_value_character)
584 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
585 New functions.
586 (uniprop_encoder, uniprop_encoder_count): New variables.
587 (uniprop_get_encoder, uniprop_table)
588 (Funicode_property_table_internal, Fget_unicode_property_internal)
589 (Fput_unicode_property_internal): New functions.
590 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
591 Sunicode_property_table_internal, Sget_unicode_property_internal,
592 and Sput_unicode_property_internal. Defvar_lisp
593 char-code-property-alist.
594
595 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
596 Vunicode_category_table.
597
598 * font.c (font_range): Adjusted for the change of
599 Vunicode_category_table.
600
76b397fb
DN
6012011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
602
603 * m/iris4d.h: Remove file, move contents ...
604 * s/irix6-5.h: ... here.
605
22b4128e
PE
6062011-07-06 Paul Eggert <eggert@cs.ucla.edu>
607
608 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
609 * alloc.c (mark_buffer):
610 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
611 (clone_per_buffer_values): Don't assume that
22b4128e
PE
612 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
613 This isn't true in general, and it's particularly not true
614 if Emacs is configured with --with-wide-int.
615 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
616 New macros, used in the buffer.c change.
617
869795d6
JD
6182011-07-05 Jan Djärv <jan.h.d@swipnet.se>
619
620 * xsettings.c: Use both GConf and GSettings if both are available.
621 (store_config_changed_event): Add comment.
622 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
623 (store_tool_bar_style_changed): New functions.
624 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
625 (struct xsettings): Move font inside HAVE_XFT.
626 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
627 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
628 Move inside HAVE_XFT.
629 (something_changed_gsettingsCB): Renamed from something_changedCB.
630 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
631 also.
632 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
633 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
634 (something_changed_gconfCB): Renamed from something_changedCB.
635 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
636 (parse_settings): Move check for font inside HAVE_XFT.
637 (read_settings, apply_xft_settings): Add comment.
638 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
639 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
640 call store_font_name_changed.
641 (xft_settings_event): Add comment.
642 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
643 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
644 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
645 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
646 (xsettings_initialize): Call init_gsettings last.
647 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
648 comment.
649
d8ed26bd
PE
6502011-07-05 Paul Eggert <eggert@cs.ucla.edu>
651
652 Random fixes. E.g., (random) never returned negative values.
653 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
654 subseconds part to the entropy, as that's a bit more random.
655 Prefer signed to unsigned, since the signedness doesn't matter and
656 in general we prefer signed. When given a limit, use a
657 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
658 latter isn't right if USE_2_TAGS_FOR_INTS.
659 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
660 not 0..VALMASK. Don't discard "excess" bits that random () returns.
661
cabf1cac
SM
6622011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
663
664 * textprop.c (text_property_stickiness):
665 Obey Vtext_property_default_nonsticky.
666 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
667 * w32fns.c (syms_of_w32fns):
668 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
669
6e9b2be9
PE
6702011-07-04 Paul Eggert <eggert@cs.ucla.edu>
671
672 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
673 This is more efficient than Ffile_directory_p and avoids a minor race.
674
90186c68
LMI
6752011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
676
7c301272
LMI
677 * buffer.c (Foverlay_put): Say what the return value is
678 (bug#7835).
679
c4f2d8d4
LMI
680 * fileio.c (barf_or_query_if_file_exists): Check first if the file
681 is a directory before asking whether to use the file name
682 (bug#7564).
ad637907
LMI
683 (barf_or_query_if_file_exists): Make the "File is a directory"
684 error be more correct.
c4f2d8d4 685
90186c68
LMI
686 * fns.c (Frequire): Remove the mention of the .gz files, since
687 that's installation-specific, but keep the mention of
688 `get-load-suffixes'.
689
da64016e
PE
6902011-07-04 Paul Eggert <eggert@cs.ucla.edu>
691
692 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
693 Report string overflow if the output is too long.
694
7d47b580
JB
6952011-07-04 Juanma Barranquero <lekktu@gmail.com>
696
a555cb87
JB
697 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
698 (syms_of_gnutls): Remove duplicate DEFSYM for
699 Qgnutls_bootprop_verify_hostname_error, an error for
700 Qgnutls_bootprop_verify_error (which is no longer used).
701
7d47b580
JB
702 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
703 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
704 Also (re)move comments that are misplaced or no longer relevant.
705
1e49bfab
LMI
7062011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
707
708 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
709
1485f4c0
CY
7102011-07-03 Chong Yidong <cyd@stupidchicken.com>
711
712 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
713 and background color parameters if they have been changed.
714
a9ab721e
LMI
7152011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
716
717 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
718
cf7cff57
PE
7192011-07-03 Paul Eggert <eggert@cs.ucla.edu>
720
2e13213d
PE
721 * xsettings.c (SYSTEM_FONT): Define only when used.
722 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
723
cf7cff57
PE
724 * keymap.c (access_keymap_1): Now static.
725
7a8e04f7
CY
7262011-07-02 Chong Yidong <cyd@stupidchicken.com>
727
728 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
729 leave any prefix arg for the up event (Bug#1586).
730
61352f62
LMI
7312011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
732
69bb1ef7
LMI
733 * lread.c (syms_of_lread): Mention single symbols defined by
734 `defvar' or `defconst' (bug#7154).
735
61352f62 736 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 737 (Frequire): Mention get-load-suffixes.
61352f62 738
28545e04
MR
7392011-07-02 Martin Rudalics <rudalics@gmx.at>
740
741 * window.h (window): Remove clone_number slot.
742 * window.c (Fwindow_clone_number, Fset_window_clone_number):
743 Remove.
744 (make_parent_window, make_window, saved_window)
745 (Fset_window_configuration, save_window_save): Don't deal with
746 clone numbers.
747 * buffer.c (Qclone_number): Remove declaration.
748 (sort_overlays, overlay_strings): Don't deal with clone numbers.
749
3349e122
SM
7502011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
751
752 Add multiple inheritance to keymaps.
753 * keymap.c (Fmake_composed_keymap): New function.
754 (Fset_keymap_parent): Simplify.
755 (fix_submap_inheritance): Remove.
756 (access_keymap_1): New function extracted from access_keymap to handle
757 embedded parents and handle lists of maps.
758 (access_keymap): Use it.
759 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
760 (Fcopy_keymap): Handle embedded parents.
761 (Fcommand_remapping, define_as_prefix): Simplify.
762 (Fkey_binding): Simplify.
763 (syms_of_keymap): Move minibuffer-local-completion-map,
764 minibuffer-local-filename-completion-map,
765 minibuffer-local-must-match-map, and
766 minibuffer-local-filename-must-match-map to Elisp.
767 (syms_of_keymap): Defsubr make-composed-keymap.
768 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
769 (parse_menu_item): Trivial simplification.
770
3279eb87
GM
7712011-07-01 Glenn Morris <rgm@gnu.org>
772
773 * Makefile.in (SETTINGS_LIBS): Fix typo.
774
4550efdf
KI
7752011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
776
777 * coding.c (Fencode_coding_string): Record the last coding system
778 used, as the function doc string says (bug#8738).
779
0949d2b6
JD
7802011-07-01 Jan Djärv <jan.h.d@swipnet.se>
781
782 * xsettings.c (store_monospaced_changed): Take new font as arg and
783 check for change against current_mono_font.
784 (EMACS_TYPE_SETTINGS): Remove this and related defines.
785 (emacs_settings_constructor, emacs_settings_get_property)
786 (emacs_settings_set_property, emacs_settings_class_init)
787 (emacs_settings_init, gsettings_obj): Remove.
788 (something_changedCB): New function for HAVE_GSETTINGS.
789 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
790 with value as argument.
791 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
792 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 793 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
794 "changed".
795
796 * xgselect.c: Add defined (HAVE_GSETTINGS).
797 (xgselect_initialize): Ditto.
798
799 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
800 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
801 xg_select.
802
bbc6b304
PE
8032011-07-01 Paul Eggert <eggert@cs.ucla.edu>
804
805 * eval.c (struct backtrace): Simplify and port the data structure.
806 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
807 signed bit field, as this assumption is not portable and it makes
808 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
809 "char debug_on_exit : 1" as this is not portable either; instead,
810 use the portable "unsigned int debug_on_exit : 1". Remove unused
811 member evalargs. Remove obsolete comments about cc bombing out.
812
9851bfc5
JD
8132011-06-30 Jan Djärv <jan.h.d@swipnet.se>
814
51bb811f 815 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
816 Let HAVE_GSETTINGS override HAVE_GCONF.
817 (store_monospaced_changed): New function.
818 (EMACS_SETTINGS): A new type derived from GObject to handle
819 GSettings notifications.
820 (emacs_settings_constructor, emacs_settings_get_property)
821 (emacs_settings_set_property, emacs_settings_class_init):
822 New functions.
823 (gsettings_client, gsettings_obj): New variables.
824 (GSETTINGS_SCHEMA): New define.
825 (something_changedCB): Call store_monospaced_changed.
826 (init_gsettings): New function.
827 (xsettings_initialize): Call init_gsettings.
828 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
829 to NULL.
830
831 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
832 GCONF_CFLAGS/LIBS.
833
5386012d
MR
8342011-06-29 Martin Rudalics <rudalics@gmx.at>
835
836 * window.c (resize_root_window, grow_mini_window)
837 (shrink_mini_window): Rename Qresize_root_window to
838 Qwindow_resize_root_window and Qresize_root_window_vertically to
839 Qwindow_resize_root_window_vertically.
840
f13e0b08
PE
8412011-06-28 Paul Eggert <eggert@cs.ucla.edu>
842
843 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
844
94515237
JB
8452011-06-27 Juanma Barranquero <lekktu@gmail.com>
846
847 * makefile.w32-in: Redesign dependencies so they reflect more
848 clearly which files are directly included by each source file,
849 and not through other includes.
850
e43b6e43
MR
8512011-06-27 Martin Rudalics <rudalics@gmx.at>
852
853 * buffer.c (Qclone_number): Declare static and DEFSYM it.
854 (sort_overlays, overlay_strings): When an overlay's clone number
855 matches the window's clone number process the overlay even if
856 the overlay's window property doesn't match the current window.
857
d68443dc
MR
858 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
859 (Fwindow_hchild): Rename to Fwindow_left_child.
860 (Fwindow_next): Rename to Fwindow_next_sibling.
861 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
862 (resize_window_check): Rename to window_resize_check.
863 (resize_window_apply): Rename to window_resize_apply.
864 (Fresize_window_apply): Rename to Fwindow_resize_apply.
865 (Fdelete_other_windows_internal, resize_frame_windows)
866 (Fsplit_window_internal, Fdelete_window_internal)
867 (grow_mini_window, shrink_mini_window)
868 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 869
c7e73be5
JD
8702011-06-26 Jan Djärv <jan.h.d@swipnet.se>
871
872 * emacsgtkfixed.h: State that this is only used with Gtk+3.
873 (emacs_fixed_set_min_size): Remove.
874 (emacs_fixed_new): Take frame as argument.
875
876 * emacsgtkfixed.c: State that this is only used with Gtk+3.
877 (_EmacsFixedPrivate): Remove minwidth/height.
878 Add struct frame *f.
879 (emacs_fixed_init): Initialize priv->f.
880 (get_parent_class, emacs_fixed_set_min_size): Remove.
881 (emacs_fixed_new): Set priv->f to argument.
882 (emacs_fixed_get_preferred_width)
883 (emacs_fixed_get_preferred_height): Use min_width/height from
884 frames size_hint to set minimum and natural (Bug#8919).
885 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
886 and use min_width/height from frames size_hint to set
887 min_width/height (Bug#8919).
888
889 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
890 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
891 Fix indentation.
c7e73be5 892
cf99dcf8
EZ
8932011-06-26 Eli Zaretskii <eliz@gnu.org>
894
895 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
896 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
897 called at ZV.
898
029529ac
CY
8992011-06-26 Chong Yidong <cyd@stupidchicken.com>
900
901 * process.c (wait_reading_process_output): Bypass select if
902 waiting for a cell while ignoring keyboard input, and input is
903 pending. Suggested by Jan Djärv (Bug#8869).
904
7a7ef429
PE
9052011-06-25 Paul Eggert <eggert@cs.ucla.edu>
906
907 Use gnulib's dup2 module instead of rolling our own.
908 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
909
11fdef7d 9102011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
911
912 * dispnew.c (scrolling_window): Before scrolling, turn off a
913 mouse-highlight in the window being scrolled.
914
cd3520a4
JB
9152011-06-24 Juanma Barranquero <lekktu@gmail.com>
916
917 Move DEFSYM to lisp.h and use everywhere.
918
919 * character.h (DEFSYM): Move declaration...
920 * lisp.h (DEFSYM): ...here.
921
922 * gnutls.c:
923 * minibuf.c:
924 * w32menu.c:
925 * w32proc.c:
926 * w32select.c: Don't include character.h.
927
928 * alloc.c (syms_of_alloc):
929 * buffer.c (syms_of_buffer):
930 * bytecode.c (syms_of_bytecode):
931 * callint.c (syms_of_callint):
932 * casefiddle.c (syms_of_casefiddle):
933 * casetab.c (init_casetab_once):
934 * category.c (init_category_once, syms_of_category):
935 * ccl.c (syms_of_ccl):
936 * cmds.c (syms_of_cmds):
937 * composite.c (syms_of_composite):
938 * dbusbind.c (syms_of_dbusbind):
939 * dired.c (syms_of_dired):
940 * dispnew.c (syms_of_display):
941 * doc.c (syms_of_doc):
942 * editfns.c (syms_of_editfns):
943 * emacs.c (syms_of_emacs):
944 * eval.c (syms_of_eval):
945 * fileio.c (syms_of_fileio):
946 * fns.c (syms_of_fns):
947 * frame.c (syms_of_frame):
948 * fringe.c (syms_of_fringe):
949 * insdel.c (syms_of_insdel):
950 * keymap.c (syms_of_keymap):
951 * lread.c (init_obarray, syms_of_lread):
952 * macros.c (syms_of_macros):
953 * msdos.c (syms_of_msdos):
954 * print.c (syms_of_print):
955 * process.c (syms_of_process):
956 * search.c (syms_of_search):
957 * sound.c (syms_of_sound):
958 * syntax.c (init_syntax_once, syms_of_syntax):
959 * terminal.c (syms_of_terminal):
960 * textprop.c (syms_of_textprop):
961 * undo.c (syms_of_undo):
962 * w32.c (globals_of_w32):
963 * window.c (syms_of_window):
964 * xdisp.c (syms_of_xdisp):
965 * xfaces.c (syms_of_xfaces):
966 * xfns.c (syms_of_xfns):
967 * xmenu.c (syms_of_xmenu):
968 * xsettings.c (syms_of_xsettings):
969 * xterm.c (syms_of_xterm): Use DEFSYM.
970
4228cf16
TZ
9712011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
972
cd3520a4 973 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 974
7fcccf1e
PE
9752011-06-23 Paul Eggert <eggert@cs.ucla.edu>
976
7efb4e0e
PE
977 Integer and buffer overflow fixes (Bug#8873).
978
ff5844ad
PE
979 * print.c (printchar, strout): Check for string overflow.
980 (PRINTPREPARE, printchar, strout):
981 Don't set size unless allocation succeeds.
982
90532f02
PE
983 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
984 for sizes. Check for string overflow more accurately.
985 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
986
6d84508d
PE
987 * macros.c: Integer and buffer overflow fixes.
988 * keyboard.h (struct keyboard.kbd_macro_bufsize):
989 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
990 Use ptrdiff_t, not int, for sizes.
991 Don't increment bufsize until after realloc succeeds.
992 Check for size-calculation overflow.
993 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
994
437b2cb4
PE
995 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
996
8b9ac8b4
PE
997 * lread.c: Integer overflow fixes.
998 (read_integer): Radix is now EMACS_INT, not int,
999 to improve quality of diagnostics for out-of-range radices.
1000 Calculate buffer size correctly for out-of-range radices.
1001 (read1): Check for integer overflow in radices, and in
1002 read-circle numbers.
82cb60d3
PE
1003 (read_escape): Avoid int overflow.
1004 (Fload, openp, read_buffer_size, read1)
1005 (substitute_object_recurse, read_vector, read_list, map_obarray):
1006 Use ptrdiff_t, not int, for sizes.
1007 (read1): Use EMACS_INT, not int, for sizes.
20270765 1008 Check for size overflow.
8b9ac8b4 1009
7fcccf1e
PE
1010 * image.c (cache_image): Check for size arithmetic overflow.
1011
bfbbd7e7
PE
1012 * lread.c: Integer overflow issues.
1013 (saved_doc_string_size, saved_doc_string_length)
1014 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1015 Now ptrdiff_t, not int.
1016 (read1): Don't assume doc string length fits in int. Check for
1017 out-of-range doc string lengths.
1018 (read_list): Don't assume file position fits in int.
39019e54 1019 (read_escape): Check for hex character overflow.
bfbbd7e7 1020
4e323265
LL
10212011-06-22 Leo Liu <sdl.web@gmail.com>
1022
1023 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1024 Move to minibuffer.el.
1025
85fece3e
PE
10262011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1027
20b84ce9 1028 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1029 The following patches are for when GLYPH_DEBUG && !XASSERT.
1030 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1031 * dispnew.c (flush_stdout):
1032 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1033 Mark as externally visible.
1034 * dispnew.c (check_window_matrix_pointers): Now static.
1035 * dispnew.c (window_to_frame_vpos):
1036 * xfns.c (unwind_create_frame):
1037 * xterm.c (x_check_font): Remove unused local.
1038 * scroll.c (CHECK_BOUNDS):
1039 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1040 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1041 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1042 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1043 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1044 Now static.
1045 (debug_method_add): Use va_list and vsprintf rather than relying
1046 on undefined behavior with wrong number of arguments.
1047 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1048 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1049 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1050 since we're not interested in debugging glyphs with old libraries.
1051 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1052 GCC 4.6.0's static checking.
1053
0766b489
PE
10542011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1055
31fd4b32
PE
1056 Integer overflow and signedness fixes (Bug#8873).
1057 A few related buffer overrun fixes, too.
1058
b79e8648
PE
1059 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1060
0766b489
PE
1061 * dispextern.h (struct face.stipple):
1062 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1063 (x_bitmap_mask, x_allocate_bitmap_record)
1064 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1065 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1066 (x_create_bitmap_from_xpm_data):
1067 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1068 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1069 (.bitmaps_last):
1070 * xfaces.c (load_pixmap):
1071 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1072 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1073 (.bitmaps_last, struct x_output.icon_bitmap):
1074 Use ptrdiff_t, not int, for bitmap indexes.
1075 (x_allocate_bitmap_record): Check for size overflow.
1076 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1077
b081724f
PE
1078 Use ptrdiff_t, not int, for overlay counts.
1079 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1080 * editfns.c (overlays_around, get_pos_property):
1081 * textprop.c (get_char_property_and_overlay):
1082 * xdisp.c (next_overlay_change, note_mouse_highlight):
1083 * xfaces.c (face_at_buffer_position):
21514da7
PE
1084 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1085 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1086 (Fnext_overlay_change, Fprevious_overlay_change)
1087 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1088 Use ptrdiff_t, not int, for sizes.
21514da7 1089 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1090
3de73e5e
PE
1091 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1092
2606c57b
PE
1093 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1094 (x_session_initialize): Do not assume string length fits in int.
1095
aaafe47a
PE
1096 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1097 This is unlikely, but can occur if DPI is outlandish.
1098
2674ddc8 1099 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1100 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1101
28154962
PE
1102 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1103 * xrdb.c (magic_file_p, search_magic_path):
1104 Omit last arg SUFFIX; it was always 0. All callers changed.
1105 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1106
7de51af5
PE
1107 * xfont.c (xfont_match): Avoid need for strlen.
1108
25ed6cc3
PE
1109 * xfns.c: Don't assume strlen fits in int.
1110 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1111
4eab31dd
PE
1112 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1113 not unsigned long, as we prefer signed integers. All callers changed.
1114 Detect integer overflow in repeat count.
1115 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1116 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1117
171e2a58
PE
1118 * termcap.c: Don't assume sizes fit in int and never overflow.
1119 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1120 (gobble_line): Check for size-calculation overflow.
1121
ad39faca 1122 * minibuf.c (Fread_buffer):
6e5bb2dc 1123 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1124 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1125 Don't assume string length fits in int.
1126
52c61c22 1127 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1128 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1129
b5b8c9e5
PE
1130 * font.c: Don't assume string length fits in int.
1131 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1132 Use ptrdiff_t, not int.
ccd6111c
PE
1133 (font_intern_prop): Don't assume string length fits in int.
1134 Don't assume integer property fits in fixnum.
1135 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1136
882f0d81 1137 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1138 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1139 Reformulate so as not to need the command string.
1140 Invoke gzip -cd rather than gunzip, as it's more portable.
1141 (lock_info_type, lock_file_1, lock_file):
1142 Don't assume pid_t and time_t fit in unsigned long.
1143 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1144 (current_lock_owner): Prefer signed type for sizes.
1145 Use memcpy, not strncpy, where memcpy is what is really wanted.
1146 Don't assume (via atoi) that time_t and pid_t fit in int.
1147 Check for time_t and/or pid_t out of range, e.g., via a network share.
1148 Don't alloca where an auto var works fine.
1149
93f4cf88
PE
1150 * fileio.c: Fix some integer overflow issues.
1151 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1152 Don't assume string length fits in int.
1153 (directory_file_name): Don't assume string length fits in long.
1154 (make_temp_name): Don't assume pid fits in int, or that its print
1155 length is less than 20.
1156
f3e92b69
PE
1157 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1158
1bfdaf10
PE
1159 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1160
35016e9a
PE
1161 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1162
3d1e65a1
PE
1163 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1164 We prefer signed integers, even for size calculations.
1165
0b963a93
PE
1166 * emacs.c: Don't assume string length fits in 'int'.
1167 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1168 (main): Don't invoke strlen when not needed.
1169
573f4b54
PE
1170 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1171 (XD_DEBUG_MESSAGE): Don't waste a byte.
1172
989f33ba
PE
1173 * callproc.c (getenv_internal_1, getenv_internal)
1174 (Fgetenv_internal):
965d34eb
PE
1175 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1176
e4d29b33
PE
1177 * lread.c (invalid_syntax): Omit length argument.
1178 All uses changed. This doesn't fix a bug, but it simplifies the
1179 code away from its former Hollerith-constant appearance, and it's
1180 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1181 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1182
eb49b136
PE
1183 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1184 This didn't break anything, but it didn't help either.
1185 It's confusing to put a bogus integer in a place where the actual
1186 value does not matter.
9f62aeb1 1187 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1188 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1189
15375a22
PE
1190 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1191 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1192 implementation.
b61cc01c
PE
1193 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1194 We prefer signed types, and the value cannot exceed the EMACS_INT
1195 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1196 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1197 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1198 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1199
53b2623d
PE
1200 * indent.c (sane_tab_width): New function.
1201 (current_column, scan_for_column, Findent_to, position_indentation)
1202 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1203 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1204
51cab52b 1205 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1206
f2ed8a70
PE
1207 * lisp.h (lint_assume): New macro.
1208 * composite.c (composition_gstring_put_cache):
1209 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1210
abe80cc6
PE
1211 * editfns.c, insdel.c:
1212 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1213
b02c740e
PE
1214 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1215
ebc96716
PE
1216 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1217
b4e50fa0 1218 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1219 Use much-faster test for byte-length change.
311d5d7c 1220 Don't assume string byte-length fits in 'int'.
a4cf38e4 1221 Check that character arg fits in 'int'.
85461888 1222 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1223
c0c1ee9f
PE
1224 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1225
a498d7f4
PE
1226 * fns.c (concat): Catch string overflow earlier.
1227 Do not rely on integer wraparound.
1228
51cab52b
PE
1229 * dispextern.h (struct it.overlay_strings_charpos)
1230 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1231 * xdisp.c (forward_to_next_line_start)
1232 (back_to_previous_visible_line_start)
1233 (reseat_at_next_visible_line_start, next_element_from_buffer):
1234 Don't arbitrarily truncate the value of 'selective' to int.
1235
76031fad
PE
1236 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1237
5eb55db9
PE
1238 * composite.c: Don't truncate sizes to 'int'.
1239 (composition_gstring_p, composition_reseat_it)
1240 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1241 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1242 not EMACS_UINT, for indexes.
5eb55db9 1243
0703a717
PE
1244 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1245
d6202519
PE
1246 * buffer.c: Include <verify.h>.
1247 (struct sortvec.priority, struct sortstr.priority):
8961a454 1248 Now EMACS_INT, not int.
c20998a7 1249 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1250 (struct sortstr.size, record_overlay_string)
1251 (struct sortstrlist.size, struct sortlist.used):
1252 Don't truncate size to int.
1253 (record_overlay_string): Check for size-calculation overflow.
d6202519 1254 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1255
d5a19415
JM
12562011-06-22 Jim Meyering <meyering@redhat.com>
1257
029529ac 1258 Don't leak an XBM-image-sized buffer
d5a19415
JM
1259 * image.c (xbm_load): Free the image buffer after using it.
1260
a9041e6c
PE
12612011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1262
1263 Port to Sun C.
1264 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1265 that Sun C diagnosed.
1266 * fns.c (secure_hash): Fix pointer signedness issue.
1267 * intervals.c (static_offset_intervals): New function.
1268 (offset_intervals): Use it.
1269
7f3f739f
LL
12702011-06-21 Leo Liu <sdl.web@gmail.com>
1271
1272 * deps.mk (fns.o):
1273 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1274 sha512.h.
1275
1276 * fns.c (secure_hash): Rename from crypto_hash_function and change
1277 the first arg to accept symbols.
5b66d427 1278 (Fsecure_hash): New primitive.
7f3f739f
LL
1279 (syms_of_fns): New symbols.
1280
76147d94
DD
12812011-06-20 Deniz Dogan <deniz@dogan.se>
1282
1283 * process.c (Fset_process_buffer): Clarify return value in
1284 docstring.
1285
7d7d0045
CY
12862011-06-18 Chong Yidong <cyd@stupidchicken.com>
1287
1288 * dispnew.c (add_window_display_history): Use BVAR.
1289
1290 * xdisp.c (debug_method_add): Use BVAR.
1291 (check_window_end, dump_glyph_matrix, dump_glyph)
1292 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1293
1294 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1295 Likewise.
1296
1297 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1298 check till after the cache is created in init_frame_faces.
1299
ff2bc410
SM
13002011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1301
1302 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1303
28177add
PE
13042011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1305
dd3482fe
PE
1306 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1307 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1308 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1309
393d71f3 1310 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1311 * fileio.c (Finsert_file_contents):
1312 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1313 Remove the old (too-loose) buffer overflow checks.
1314 They weren't needed, since make_gap checks for buffer overflow.
1315 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1316 The old code merely checked for Emacs fixnum overflow, and relied
1317 on undefined (wraparound) behavior. The new code avoids undefined
1318 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1319
2e6813b0 1320 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1321 Tune. Don't use wider integers than needed. Don't use alloca.
1322 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1323
599a9e4f
PE
1324 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1325
99561444
PE
1326 * insdel.c, lisp.h (buffer_overflow): New function.
1327 (insert_from_buffer_1, replace_range, replace_range_2):
1328 * insdel.c (make_gap_larger):
1329 * editfns.c (Finsert_char):
1330 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1331
28177add
PE
1332 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1333
e69dafad
PE
13342011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1335
a7af7fde 1336 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1337
b1c46f02
PE
1338 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1339 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1340
e69dafad
PE
1341 * fileio.c: Don't assume EMACS_INT fits in off_t.
1342 (emacs_lseek): New static function.
1343 (Finsert_file_contents, Fwrite_region): Use it.
1344 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1345
566684ea
PE
1346 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1347
e6966cd6
PE
1348 * fns.c: Don't overflow int when computing a list length.
1349 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1350 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1351 truncation on 64-bit hosts. Check for QUIT every
1352 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1353 faster and is responsive enough.
1354 (Flength): Report an error instead of overflowing an integer.
1355 (Fsafe_length): Return a float if the value is not representable
1356 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1357 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1358 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1359
dd0b0efb
PE
1360 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1361 (header_size, word_size): New constants.
1362 (allocate_vectorlike): Don't check size overflow here.
1363 (allocate_vector): Check it here instead, since this is the only
1364 caller of allocate_vectorlike that could cause overflow.
1365 Check that the new vector's length is representable as a fixnum.
1366
86fe5cfe
PE
1367 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1368 The previous code was bogus. For example, next_almost_prime (32)
1369 returned 39, which is undesirable as it is a multiple of 3; and
1370 next_almost_prime (24) returned 25, which is a multiple of 5 so
1371 why was the code bothering to check for multiples of 7?
1372
80e88859
PE
1373 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1374
4a2f0ad6
PE
1375 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1376
f66c7cf8
PE
1377 Variadic C functions now count arguments with ptrdiff_t.
1378 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1379 Back then I didn't know that the Emacs coding style prefers signed int.
1380 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1381 were being counted with int, which may truncate counts on 64-bit
1382 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1383 * lisp.h (struct Lisp_Subr.function.aMANY)
1384 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1385 Arg counts are now ptrdiff_t, not size_t.
1386 All variadic functions and their callers changed accordingly.
1387 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1388 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1389 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1390 * callint.c (Fcall_interactively): Check arg count for overflow,
1391 to avoid potential buffer overrun. Use signed char, not 'int',
1392 for 'varies' array, so that we needn't bother to check its size
1393 calculation for overflow.
1394 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1395 * eval.c (apply_lambda):
1396 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1397 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1398 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1399
a1759b76
PE
1400 * callint.c (Fcall_interactively): Don't use index var as event count.
1401
d96be9fc
PE
1402 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1403 * mem-limits.h (SIZE): Remove; no longer used.
1404
a690a978 1405 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1406
578c21e6
PE
1407 Remove unnecessary casts.
1408 * xterm.c (x_term_init):
1409 * xfns.c (x_set_border_pixel):
1410 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1411 These aren't needed now that we assume ANSI C.
1412
96f53c6c
PE
1413 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1414 It's more likely to cause problems (due to unsigned overflow)
1415 than to cure them.
1416
83c77d31
PE
1417 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1418
ee2079f1
PE
1419 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1420
6da65536
PE
1421 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1422
7147c4a4
PE
1423 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1424
193e32d9
PE
1425 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1426
e5533da6
PE
1427 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1428
9910e595
PE
1429 GLYPH_CODE_FACE returns EMACS_INT, not int.
1430 * dispextern.h (merge_faces):
1431 * xfaces.c (merge_faces):
01103c44
PE
1432 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1433 Don't assume EMACS_INT fits in int.
9910e595 1434
2638320e
PE
1435 * character.h (CHAR_VALID_P): Remove unused parameter.
1436 * fontset.c, lisp.h, xdisp.c: All uses changed.
1437
045eb8d9
PE
1438 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1439
c1f134b5
PE
1440 * fns.c (concat): Minor tuning based on overflow analysis.
1441 This doesn't fix any bugs. Use int to hold character, instead
1442 of constantly refetching from Emacs object. Use XFASTINT, not
1443 XINT, for value known to be a character. Don't bother comparing
1444 a single byte to 0400, as it's always less.
1445
395fcb93 1446 * floatfns.c (Fexpt):
327eeec8
PE
1447 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1448
abbd3d23
PE
1449 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1450 for characters.
1451
684a03ef
PE
1452 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1453
0fed43f3
PE
1454 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1455 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1456 incorrectly succeed when S was a string, because 4294967386 was
1457 truncated before it was used.
1458
8fd02eb7
PE
1459 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1460 Otherwise, an out-of-range integer could cause undefined behavior
1461 on a 64-bit host.
1462
f8c86b69
PE
1463 * composite.c: Use int, not EMACS_INT, for characters.
1464 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1465 EMACS_INT, for values that are known to be in character range.
1466 This doesn't fix any bugs but is the usual style inside Emacs and
1467 may generate better code on 32-bit machines.
1468
34206dd2
PE
1469 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1470 This is for reasons similar to the recent CHAR_STRING fix.
1471 * charset.c (Fencode_char): Check that character arg is actually
1472 a character. Pass an int to ENCODE_CHAR.
1473 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1474 wider than 'int', as a compile-time check to prevent future regressions
1475 in this area.
1476
c5958d4c 1477 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1478
1479 Make sure a 64-bit char is never passed to CHAR_STRING.
1480 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1481 by silently ignoring the top 32 bits, allowing some values
1482 that were far too large to be valid characters.
1483 * character.h: Include <verify.h>.
1484 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1485 arguments are no wider than unsigned, as a compile-time check
1486 to prevent future regressions in this area.
1487 * data.c (Faset):
01103c44 1488 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1489 (Fsubst_char_in_region):
1490 * fns.c (concat):
1491 * xdisp.c (decode_mode_spec_coding):
1492 Adjust to CHAR_STRING's new requirement.
1493 * editfns.c (Finsert_char, Fsubst_char_in_region):
1494 * fns.c (concat): Check that character args are actually
1495 characters. Without this test, these functions did the wrong
1496 thing with wildly out-of-range values on 64-bit hosts.
1497
d37ca623
PE
1498 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1499 These casts should not be needed on 32-bit hosts, either.
1500 * keyboard.c (read_char):
1501 * lread.c (Fload): Remove casts to unsigned.
1502
ea204efb
PE
1503 * lisp.h (UNSIGNED_CMP): New macro.
1504 This fixes comparison bugs on 64-bit hosts.
1505 (ASCII_CHAR_P): Use it.
1506 * casefiddle.c (casify_object):
01103c44 1507 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1508 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1509 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1510 * dispextern.h (FACE_FROM_ID):
1511 * keyboard.c (read_char): Use UNSIGNED_CMP.
1512
41cb286c
PE
1513 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1514 not to EMACS_INT, to avoid GCC warning.
1515
4a1b9832
PE
1516 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1517
55daad71
PE
1518 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1519 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1520 isn't needed on 32-bit machines.
8f95c75c 1521
01103c44
PE
1522 * buffer.c (Fgenerate_new_buffer_name):
1523 Use EMACS_INT for count, not int.
0ceccced 1524 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1525
1526 * data.c (Qcompiled_function): Now static.
1527
c6f072e7
PE
1528 * window.c (window_body_lines): Now static.
1529
20ce5912
PE
1530 * image.c (gif_load): Rename local to avoid shadowing.
1531
9c4c5f81
PE
1532 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1533 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1534 * alloc.c (make_save_value): Integer argument is now of type
1535 ptrdiff_t, not int.
1536 (mark_object): Use ptrdiff_t, not int.
1537 * lisp.h (pD): New macro.
1538 * print.c (print_object): Use it.
1539
c0c5c8ae
PE
1540 * alloc.c: Use EMACS_INT, not int, to count objects.
1541 (total_conses, total_markers, total_symbols, total_vector_size)
1542 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1543 (total_free_floats, total_floats, total_free_intervals)
1544 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1545 Now EMACS_INT, not int. All uses changed.
1546 (Fgarbage_collect): Compute overall total using a double, so that
1547 integer overflow is less likely to be a problem. Check for overflow
1548 when converting back to an integer.
5a25e253
PE
1549 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1550 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1551 These were 'int' variables that could overflow on 64-bit hosts;
1552 they were never used, so remove them instead of repairing them.
211a0b2a 1553 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1554 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1555 Previously, this ceilinged at INT_MAX, but that doesn't work on
1556 64-bit machines.
e46bb31a 1557 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1558
c78baabf 1559 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1560 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1561 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1562 when a (possibly-narrower) signed value would do just as well.
1563 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1564
c9d624c6
PE
1565 * alloc.c: Catch some string size overflows that we were missing.
1566 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1567 for convenience in STRING_BYTES_MAX.
1568 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1569 The definition here is exact; the one in lisp.h was approximate.
1570 (allocate_string_data): Check for string overflow. This catches
1571 some instances we weren't catching before. Also, it catches
1572 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1573 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1574 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1575
c9d624c6
PE
1576 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1577 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1578 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1579
353032ce
PE
1580 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1581
2bccce07
PE
1582 * alloc.c (Fmake_string): Check for out-of-range init.
1583
0ac30604
SM
15842011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1585
1586 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1587
c195f2de
JD
15882011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1589
1590 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1591 xg_get_default_scrollbar_width.
1592
1593 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1594 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1595 (style_changed_cb): Call update_theme_scrollbar_width and call
1596 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1597 all frames (Bug#8505).
1598 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1599 Call gtk_window_set_resizable if HAVE_GTK3.
1600 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1601 and height if HAVE_GTK3 (Bug#8505).
1602 (scroll_bar_width_for_theme): New variable.
1603 (update_theme_scrollbar_width): New function.
1604 (xg_get_default_scrollbar_width): Move code to
1605 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1606 (xg_initialize): Call update_theme_scrollbar_width.
1607
1608 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1609
1610 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1611
e10ac9f1
MR
16122011-06-12 Martin Rudalics <rudalics@gmx.at>
1613
1614 * frame.c (make_frame): Call other_buffer_safely instead of
1615 other_buffer.
1616
1617 * window.c (temp_output_buffer_show): Call display_buffer with
1618 second argument Vtemp_buffer_show_specifiers and reset latter
1619 immediately after the call.
1620 (Vtemp_buffer_show_specifiers): New variable.
1621 (auto_window_vscroll_p, next_screen_context_lines)
1622 (Vscroll_preserve_screen_position): Remove leading asterisks from
1623 doc-strings.
1624
2d3c217e 16252011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1626
7b7f97e8 1627 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1628 * buffer.c (Qclone_number): Remove for now, as it's unused.
1629 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1630 (record_buffer): Remove unused local.
1631 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1632 (set_frame_buffer_list): Remove; unused.
1633 * frame.h (other_visible_frames): Remove decl.
1634 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1635 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1636 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1637 if HAVE_GPM.
1638 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1639 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1640 Define only if HAVE_GPM.
1641 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1642 (update_hints_inhibit): Remove; never set. All uses removed.
1643 * widgetprv.h (emacsFrameClassRec): Remove decl.
1644 * window.c (delete_deletable_window): Now returns void, since it
1645 wasn't returning anything.
1646 (compare_window_configurations): Remove unused locals.
1647 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1648 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1649 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1650 the same widths as pointers. This follows up on the 2011-05-06 patch.
1651 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1652 * xterm.h: Likewise.
1653 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1654
1384b89e
JB
16552011-06-12 Juanma Barranquero <lekktu@gmail.com>
1656
1657 * makefile.w32-in: Update dependencies.
1658 (LISP_H): Add lib/intprops.h.
1659
1100a63c
CY
16602011-06-11 Chong Yidong <cyd@stupidchicken.com>
1661
1662 * image.c (gif_load): Add animation frame delay to the metadata.
1663 (syms_of_image): Use DEFSYM. New symbol `delay'.
1664
6198ccd0
MR
16652011-06-11 Martin Rudalics <rudalics@gmx.at>
1666
1667 * window.c (delete_deletable_window): Re-add.
1668 (Fset_window_configuration): Rewrite to handle dead buffers and
1669 consequently deletable windows.
1670 (window_tree, Fwindow_tree): Remove. Supply functionality in
1671 window.el.
1672 (compare_window_configurations): Simplify code.
1673
b6e3633c
AS
16742011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1675
1ab0dee5
AS
1676 * image.c (imagemagick_load_image): Fix type mismatch.
1677 (Fimagemagick_types): Likewise.
1678
b6e3633c
AS
1679 * window.h (replace_buffer_in_windows): Declare.
1680
9397e56f
MR
16812011-06-11 Martin Rudalics <rudalics@gmx.at>
1682
1683 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1684 Qclone_number. Remove external declaration of Qdelete_window.
1685 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1686 code.
1687 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1688 Qbuffer_list_update_hook if allowed.
1689 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1690 buffer list implementation.
1691 (other_buffer_safely): New function.
1692 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1693 calls to replace_buffer_in_windows and
1694 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1695 if allowed.
1696 (record_buffer): Inhibit quitting and rewrite using quittable
1697 functions. Run Qbuffer_list_update_hook if allowed.
1698 (Frecord_buffer, Funrecord_buffer): New functions.
1699 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1700 switch-to-buffer to window.el.
1701 (bury-buffer): Move to window.el.
1702 (Vbuffer_list_update_hook): New variable.
1703
1704 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1705 section.
1706
1707 * window.h (resize_frame_windows): Move up in code.
1708 (Fwindow_frame): Remove EXFUN.
1709 (replace_buffer_in_all_windows): Remove prototype.
1710 (replace_buffer_in_windows_safely): Add prototype.
1711
1712 * window.c: Declare Qdelete_window static again. Move down
1713 declaration of select_count.
1714 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1715 (Fother_window): Move to window.el.
1716 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1717 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1718 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1719 window.el.
1720 (replace_buffer_in_windows): Implement by calling
1721 Qreplace_buffer_in_windows.
1722 (replace_buffer_in_all_windows): Remove with some functionality
1723 moved into replace_buffer_in_windows_safely.
1724 (replace_buffer_in_windows_safely): New function.
1725 (select_window_norecord, select_frame_norecord): Move in front
1726 of run_window_configuration_change_hook. Remove now obsolete
1727 declarations.
1728 (Fset_window_buffer): Rewrite doc-string. Call
1729 Qrecord_window_buffer.
1730 (keys_of_window): Move binding for other-window to window.el.
1731
b50691aa
CY
17322011-06-11 Chong Yidong <cyd@stupidchicken.com>
1733
1734 * dispextern.h (struct image): Replace data member, whose int_val
1735 and ptr_val fields were not used by anything, with a single
1736 lisp_val object.
1737
1738 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1739 (gif_clear_image, gif_load, imagemagick_load_image)
1740 (gs_clear_image, gs_load): Callers changed.
1741
3f754b86
PE
17422011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1743
cca69397
PE
1744 * buffer.h: Include <time.h>, for time_t.
1745 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1746
109e28d0
PE
1747 Fix minor problems found by static checking.
1748
60737f02
PE
1749 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1750
4b66faf3
PE
1751 Make identifiers static if they are not used in other modules.
1752 * data.c (Qcompiled_function, Qframe, Qvector):
1753 * image.c (QimageMagick, Qsvg):
1754 * minibuf.c (Qmetadata):
1755 * window.c (resize_window_check, resize_root_window): Now static.
1756 * window.h (resize_window_check, resize_root_window): Remove decls.
1757
109e28d0
PE
1758 * window.c (window_deletion_count, delete_deletable_window):
1759 Remove; unused.
46a4ce9e
PE
1760 (window_body_lines): Now static.
1761 (Fdelete_other_windows_internal): Mark vars as initialized.
1762 Make sure 'resize_failed' is initialized.
1763 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1764 (resize_window_apply): Remove unused local.
1765 * window.h (delete_deletable_window): Remove decl.
1766
109e28d0 1767 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1768 (imagemagick_load_image): Fix pointer signedness problem by changing
1769 last arg from unsigned char * to char *. All uses changed.
1770 Also, fix a local for similar reasons.
1771 Remove unused locals. Remove locals to avoid shadowing.
1772 (fn_rsvg_handle_free): Remove; unused.
1773 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1774 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1775
3f754b86
PE
1776 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1777
2547adb1
CY
17782011-06-10 Chong Yidong <cyd@stupidchicken.com>
1779
1780 * image.c (gif_load): Fix omitted cast error introduced by
1781 2011-06-06 change.
1782
2c8e37d4
MR
17832011-06-10 Martin Rudalics <rudalics@gmx.at>
1784
1785 * window.h (resize_proportionally, orig_total_lines)
1786 (orig_top_line): Remove from window structure.
1787 (set_window_height, set_window_width, change_window_heights)
1788 (Fdelete_window): Remove prototypes.
1789 (resize_frame_windows): Remove duplicate declaration.
1790
440a42e3
EZ
17912011-06-10 Eli Zaretskii <eliz@gnu.org>
1792
1793 * window.h (resize_frame_windows, resize_window_check)
1794 (delete_deletable_window, resize_root_window)
1795 (resize_frame_windows): Declare prototypes.
1796
1797 * window.c (resize_window_apply): Make definition be "static" to
1798 match the prototype.
1799
562dd5e9
MR
18002011-06-10 Martin Rudalics <rudalics@gmx.at>
1801
1802 * window.c: Remove declarations of Qwindow_size_fixed,
1803 window_min_size_1, window_min_size_2, window_min_size,
1804 size_window, window_fixed_size_p, enlarge_window, delete_window.
1805 Remove static from declaration of Qdelete_window, it's
1806 temporarily needed by Fbury_buffer.
1807 (replace_window): Don't assign orig_top_line and
1808 orig_total_lines.
1809 (Fdelete_window, delete_window): Remove. Window deletion is
1810 handled by window.el.
1811 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1812 Fdelete_window calls with calls to Qdelete_window.
1813 (Fdelete_other_windows): Remove. Deleting other windows is
1814 handled by window.el.
1815 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1816 handled in window.el.
1817 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1818 Window minimum sizes are handled in window.el.
1819 (shrink_windows, size_window, set_window_height)
1820 (set_window_width, change_window_heights, window_height)
1821 (window_width, CURBEG, CURSIZE, enlarge_window)
1822 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1823 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1824 handled in window.el.
1825 (make_dummy_parent): Rename to make_parent_window and give it a
1826 second argument horflag.
1827 (make_window): Don't set resize_proportionally any more.
1828 (Fsplit_window): Remove. Windows are split in window.el.
1829 (save_restore_action, save_restore_orig_size)
1830 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1831 Resize mini windows in window.el.
1832 (grow_mini_window, shrink_mini_window): Implement by calling
1833 Qresize_root_window_vertically, resize_window_check and
1834 resize_window_apply.
1835 (saved_window, Fset_window_configuration, save_window_save): Do
1836 not handle orig_top_line, orig_total_lines, and
1837 resize_proportionally.
1838 (window_min_height, window_min_width): Move to window.el.
1839 (keys_of_window): Move bindings for delete-other-windows,
1840 split-window, delete-window and enlarge-window to window.el.
1841
1842 * buffer.c: Temporarily extern Qdelete_window.
1843 (Fbury_buffer): Temporarily call Qdelete_window instead of
1844 Fdelete_window (Fbury_buffer will move to window.el soon).
1845
1846 * frame.c (set_menu_bar_lines_1): Remove code handling
1847 orig_top_line and orig_total_lines.
1848
1849 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1850 set_window_height but set heights directly.
1851 (change_frame_size_1): Use resize_frame_windows.
1852
1853 * xdisp.c (init_xdisp): Don't use set_window_height but set
1854 heights directly.
1855
1856 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1857 resize_frame_windows instead of change_window_heights and run
1858 run_window_configuration_change_hook.
1859
1860 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1861 instead of change_window_heights and run
1862 run_window_configuration_change_hook.
1863
1a13852e
MR
18642011-06-09 Martin Rudalics <rudalics@gmx.at>
1865
1866 * window.c (replace_window): Rename second argument REPLACEMENT to
1867 NEW. New third argument SETFLAG. Rewrite.
1868 (delete_window, make_dummy_parent): Call replace_window with
1869 third argument 1.
1870 (window_list_1): Move down in code.
1871 (run_window_configuration_change_hook): Move set_buffer part
1872 before select_frame_norecord part in order to unwind correctly.
1873 Rename count1 to count.
1874 (recombine_windows, delete_deletable_window, resize_root_window)
1875 (Fdelete_other_windows_internal)
1876 (Frun_window_configuration_change_hook, make_parent_window)
1877 (resize_window_check, resize_window_apply, Fresize_window_apply)
1878 (resize_frame_windows, Fsplit_window_internal)
1879 (Fdelete_window_internal, Fresize_mini_window_internal): New
1880 functions.
1881 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1882
f3d1777e
MR
18832011-06-08 Martin Rudalics <rudalics@gmx.at>
1884
496e208e
MR
1885 * window.h (window): Add some new members to window structure -
1886 normal_lines, normal_cols, new_total, new_normal, clone_number,
1887 splits, nest, prev_buffers, next_buffers.
1888 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1889 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1890
f3d1777e
MR
1891 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1892 Remove.
496e208e
MR
1893 (make_dummy_parent): Set new members of windows structure.
1894 (make_window): Move down in code. Handle new members of window
1895 structure.
1896 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1897 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1898 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1899 (Fset_window_prev_buffers, Fwindow_next_buffers)
1900 (Fset_window_next_buffers, Fset_window_clone_number): New
1901 functions.
1902 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1903 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1904 Doc-string fixes.
1905 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1906 Argument WINDOW can be now internal window too.
1907 (Fwindow_use_time): Move up in code.
1908 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1909 Rewrite doc-string.
1910 (Fset_window_configuration, saved_window)
1911 (Fcurrent_window_configuration, save_window_save): Handle new
1912 members of window structure.
b9e809c2
MR
1913 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1914 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1915 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1916 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1917 Qget_mru_window, Qresize_root_window,
1918 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1919 Qauto_buffer_name; staticpro them.
f3d1777e 1920
abde8f8c
MR
19212011-06-07 Martin Rudalics <rudalics@gmx.at>
1922
1923 * window.c (Fwindow_total_size, Fwindow_left_column)
1924 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1925 (Fwindow_list_1): New functions.
1926 (window_box_text_cols): Replace with window_body_cols.
1927 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1928 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1929 (delete_window, Fset_window_configuration): Call
1930 delete_all_subwindows with window as argument.
1931 (delete_all_subwindows): Take a window as argument and not a
1932 structure. Rewrite.
190b47e6
MR
1933 (window_loop): Remove handling of GET_LRU_WINDOW and
1934 GET_LARGEST_WINDOW.
1935 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1936
1937 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1938 window_box_text_cols. delete_all_subwindows now takes a
1939 Lisp_Object as argument.
abde8f8c
MR
1940
1941 * indent.c (compute_motion, Fcompute_motion): Use
1942 window_body_cols instead of window_box_text_cols.
1943
fa8a67e6
MR
1944 * frame.c (delete_frame): Call delete_all_subwindows with root
1945 window as argument.
1946
a54e3482
DC
19472011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1948
1949 * fns.c (Fputhash): Document return value.
1950
60002bf5
CY
19512011-06-06 Chong Yidong <cyd@stupidchicken.com>
1952
1953 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1954
0c671da6 19552011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1956
b862a52a 1957 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1958
be44ca6c
PE
1959 Check for overflow when converting integer to cons and back.
1960 * charset.c (Fdefine_charset_internal, Fdecode_char):
1961 Use cons_to_unsigned to catch overflow.
1962 (Fencode_char): Use INTEGER_TO_CONS.
1963 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1964 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1965 * data.c (long_to_cons, cons_to_long): Remove.
1966 (cons_to_unsigned, cons_to_signed): New functions.
1967 These signal an error for invalid or out-of-range values.
1968 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1969 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1970 * font.c (Ffont_variation_glyphs):
1971 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1972 * lisp.h: Include <intprops.h>.
1973 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1974 (cons_to_signed, cons_to_unsigned): New decls.
1975 (long_to_cons, cons_to_long): Remove decls.
1976 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1977 (Fprimitive_undo): Use CONS_TO_INTEGER.
1978 * xfns.c (Fx_window_property): Likewise.
1979 * xselect.c: Include <limits.h>.
1980 (x_own_selection, selection_data_to_lisp_data):
1981 Use INTEGER_TO_CONS.
1982 (x_handle_selection_request, x_handle_selection_clear)
1983 (x_get_foreign_selection, Fx_disown_selection_internal)
1984 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1985 (lisp_data_to_selection_data): Use cons_to_unsigned.
1986 (x_fill_property_data): Use cons_to_signed.
1987 Report values out of range.
1988
d1f3d2af
PE
1989 Check for buffer and string overflow more precisely.
1990 * buffer.h (BUF_BYTES_MAX): New macro.
1991 * lisp.h (STRING_BYTES_MAX): New macro.
1992 * alloc.c (Fmake_string):
1993 * character.c (string_escape_byte8):
1994 * coding.c (coding_alloc_by_realloc):
1995 * doprnt.c (doprnt):
1996 * editfns.c (Fformat):
1997 * eval.c (verror):
1998 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1999 since they may not be the same number.
2000 * editfns.c (Finsert_char):
2001 * fileio.c (Finsert_file_contents):
2002 Likewise for BUF_BYTES_MAX.
2003
dd52fcea
PE
2004 * image.c: Use ptrdiff_t, not int, for sizes.
2005 (slurp_file): Switch from int to ptrdiff_t.
2006 All uses changed.
2007 (slurp_file): Check that file size fits in both size_t (for
2008 malloc) and ptrdiff_t (for sanity and safety).
2009
7f9bbdbb
PE
2010 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2011 if b->modtime has its maximal value.
2012
dfe18f82
PE
2013 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2014
84acfcf0
PE
2015 Don't assume time_t can fit into int.
2016 * buffer.h (struct buffer.modtime): Now time_t, not int.
2017 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2018 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2019
ccd9a01a
PE
2020 Minor fixes for signed vs unsigned integers.
2021 * character.h (MAYBE_UNIFY_CHAR):
2022 * charset.c (maybe_unify_char):
2023 * keyboard.c (read_char, reorder_modifiers):
2024 XINT -> XFASTINT, since the integer must be nonnegative.
2025 * ftfont.c (ftfont_spec_pattern):
2026 * keymap.c (access_keymap, silly_event_symbol_error):
2027 XUINT -> XFASTINT, since the integer must be nonnegative.
2028 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2029 since it makes no difference and we prefer signed.
2030 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2031 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2032 nonnegative.
2033
d6d100dd
SM
20342011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2035
2036 * window.h (Fwindow_frame): Declare.
2037
2b6148e4
PE
20382011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2039
2040 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2041 (SPARE_MEMORY): Always define.
2042 (LARGE_REQUEST): Remove.
2043 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2044
f230ecc9
MR
20452011-06-06 Martin Rudalics <rudalics@gmx.at>
2046
727e958e
MR
2047 * lisp.h: Move EXFUNS for Fframe_root_window,
2048 Fframe_first_window and Fset_frame_selected_window to window.h.
2049
2050 * window.h: Move EXFUNS for Fframe_root_window,
2051 Fframe_first_window and Fset_frame_selected_window here from
2052 lisp.h.
2053
2054 * frame.c (Fwindow_frame, Fframe_first_window)
2055 (Fframe_root_window, Fframe_selected_window)
2056 (Fset_frame_selected_window): Move to window.c.
2057 (Factive_minibuffer_window): Move to minibuf.c.
2058 (Fother_visible_frames_p): New function.
2059
2060 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2061
f230ecc9
MR
2062 * window.c (decode_window, decode_any_window): Move up in code.
2063 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2064 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2065 (Fwindow_buffer): Move up and rewrite doc-string.
2066 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2067 (Fwindow_prev): New functions.
727e958e
MR
2068 (Fwindow_frame): Move here from frame.c. Accept any window as
2069 argument.
2070 (Fframe_root_window, Fframe_first_window)
2071 (Fframe_selected_window): Move here from frame.c. Accept frame
2072 or arbitrary window as argument. Update doc-strings.
2073 (Fminibuffer_window): Move up in code.
2074 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2075 (Fset_frame_selected_window): Move here from frame.c.
2076 Marginal rewrite.
727e958e
MR
2077 (Fselected_window, select_window, Fselect_window): Move up in
2078 code. Minor doc-string fixes.
f230ecc9 2079
4d09bcf6
PE
20802011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2081
2082 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2083 Do not assume that spare memory exists; that assumption is valid
2084 only if SYSTEM_MALLOC.
2085 (LARGE_REQUEST): New macro, so that the issue of large requests
2086 is separated from the issue of spare memory.
2087
810928a2
AS
20882011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2089
172418ad
AS
2090 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2091 format. (Bug#8806)
2092
43f862f7
AS
2093 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2094
810928a2
AS
2095 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2096 before statements.
2097
a059fe24
JD
20982011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2099
2100 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2101
2102 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2103
2104 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2105 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2106
989bf368
JB
21072011-06-05 Juanma Barranquero <lekktu@gmail.com>
2108
2109 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2110
4b80f674
CY
21112011-06-04 Chong Yidong <cyd@stupidchicken.com>
2112
2113 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2114 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2115 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2116 New error handlers.
4b80f674
CY
2117 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2118 Obey Vx_select_enable_clipboard_manager. Catch errors in
2119 x_clipboard_manager_save (Bug#8779).
2120 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2121 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2122
99a33b77 21232011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2124
2125 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2126
99a33b77 21272011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2128
2129 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2130 in the current matrix if keep_current_p is non-zero.
2131
8264569d
EZ
21322011-06-04 Eli Zaretskii <eliz@gnu.org>
2133
2134 * bidi.c (bidi_level_of_next_char): Fix last change.
2135
57f97249
EZ
21362011-06-03 Eli Zaretskii <eliz@gnu.org>
2137
fec2107c 2138 Support bidi reordering of text covered by display properties.
57f97249 2139
fec2107c
EZ
2140 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2141 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2142 (bidi_cache_search, bidi_cache_iterator_state)
2143 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2144 (bidi_level_of_next_char, bidi_move_to_visually_next):
2145 Support character positions inside a run of characters covered by a
fec2107c
EZ
2146 display string.
2147 (bidi_paragraph_init, bidi_resolve_explicit_1)
2148 (bidi_level_of_next_char): Call bidi_fetch_char and
2149 bidi_fetch_char_advance instead of FETCH_CHAR and
2150 FETCH_CHAR_ADVANCE.
2151 (bidi_init_it): Initialize new members.
2152 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2153 definitions.
2154 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2155 instead of using explicit *_CHAR codes.
d6d100dd
SM
2156 (bidi_resolve_explicit, bidi_resolve_weak):
2157 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2158 bidirectional text is supported only in multibyte buffers.
2159 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2160 it to initialize the frame_window_p member of struct bidi_it.
2161 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2162 (bidi_resolve_explicit, bidi_resolve_weak)
2163 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2164 bidi_it->nchars is non-positive.
2165 (bidi_level_of_next_char): Don't try to lookup the cache for the
2166 next/previous character if nothing is cached there yet, or if we
2167 were just reseat()'ed to a new position.
c40e2fb2 2168
0e14fe90
EZ
2169 * xdisp.c (set_cursor_from_row): Set start and stop points
2170 according to the row's direction when priming the loop that looks
2171 for the glyph on which to display cursor.
2172 (single_display_spec_intangible_p): Function deleted.
2173 (display_prop_intangible_p): Reimplement to call
2174 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2175 Accept 3 additional arguments needed by handle_display_spec.
2176 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2177 values: lists, `(when COND...)' forms, etc.
2178 (single_display_spec_string_p): Support property values that are
2179 lists with the argument STRING its top-level element.
2180 (display_prop_string_p): Fix the condition for processing a
2181 property that is a list to be consistent with handle_display_spec.
fec2107c 2182 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2183 last portion of handle_display_prop.
2184 (compute_display_string_pos): Accept additional argument
2185 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2186 value of a `display' property is a "replacing spec".
2187 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2188 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2189 the display property, but just return a value indicating whether
2190 the display property will replace the characters it covers.
2191 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2192 frame_window_p members of struct bidi_it.
d6d100dd
SM
2193 (compute_display_string_pos, compute_display_string_end):
2194 New functions.
fec2107c
EZ
2195 (push_it): Accept second argument POSITION, where pop_it should
2196 jump to continue iteration.
2197 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2198
fec2107c
EZ
2199 * keyboard.c (adjust_point_for_property): Adjust the call to
2200 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2201
2202 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2203 (bidi_init_it): Update prototypes.
2204 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2205 (compute_display_string_pos, compute_display_string_end):
2206 Declare prototypes.
fec2107c
EZ
2207 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2208 EMACS_INT.
fc6f18ce 2209
40087514 22102011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2211
57f53182
PE
2212 Malloc failure behavior now depends on size of allocation.
2213 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2214 * lisp.h: Change signatures accordingly.
2215 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2216 All callers changed. (Bug#8762)
2217
2218 * gnutls.c: Use Emacs's memory allocators.
2219 Without this change, the gnutls library would invoke malloc etc.
2220 directly, which causes problems on non-SYNC_INPUT hosts, and which
2221 runs afoul of improving memory_full behavior. (Bug#8761)
2222 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2223 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2224 xfree instead of the default malloc, realloc, free.
2225 (Fgnutls_boot): No need to check for memory allocation failure,
2226 since xmalloc does that for us.
2227
ac32cd99 2228 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2229 * category.c (hash_get_category_set):
2230 * ccl.c (ccl_driver):
2231 * charset.c (Fdefine_charset_internal):
2232 * charset.h (struct charset.hash_index):
2233 * composite.c (get_composition_id, gstring_lookup_cache)
2234 (composition_gstring_put_cache):
2235 * composite.h (struct composition.hash_index):
2236 * dispextern.h (struct image.hash):
2237 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2238 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2239 (hashfn_equal, hashfn_user_defined, make_hash_table)
2240 (maybe_resize_hash_table, hash_lookup, hash_put)
2241 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2242 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2243 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2244 * image.c (make_image, search_image_cache, lookup_image)
2245 (xpm_put_color_table_h):
2246 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2247 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2248 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2249 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2250 * alloc.c (allocate_vectorlike):
2251 Check for overflow in vector size calculations.
2252 * ccl.c (ccl_driver):
2253 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2254 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2255 need to be updated by these changes.
40087514
PE
2256 * fns.c (make_hash_table, maybe_resize_hash_table):
2257 Check for integer overflow with large hash tables.
0de4bb68
PE
2258 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2259 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2260 (SXHASH_REDUCE): New macro.
2261 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2262 Use it instead of discarding useful hash info with large hash values.
2263 (sxhash_float): New function.
2264 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2265 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2266 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2267 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2268 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2269 Adjust signatures to match updated version of code.
2270 (consing_since_gc): Now EMACS_INT, since a single hash table can
2271 use more than INT_MAX bytes.
2272
698d32e2
DN
22732011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2274
2275 Make it possible to build with GCC-4.6+ -O2 -flto.
2276
2277 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2278
fd6fa53f
SM
22792011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2280
2281 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2282 Call minibuffer-inactive-mode.
2283
864db017
JB
22842011-05-31 Juanma Barranquero <lekktu@gmail.com>
2285
2286 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2287 Update dependencies.
2288
2ad0baf4
DN
22892011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2290
2291 * data.c (init_data): Remove code for UTS, this system is not
2292 supported anymore.
2293
4fcc2638
DN
22942011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2295
2296 Don't force ./temacs to start in terminal mode.
2297
2298 * frame.c (make_initial_frame): Initialize faces in all cases, not
2299 only when CANNOT_DUMP is defined.
2300 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2301
c56e0fd5
DN
23022011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2303
2304 * dispnew.c (add_window_display_history): Use const for the string
2305 pointer. Remove declaration, not needed.
2306
333d54da 23072011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2308
55d4c1b2 2309 Use 'inline', not 'INLINE'.
333d54da 2310 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2311 * alloc.c, fontset.c (INLINE): Remove.
2312 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2313 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2314 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2315 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2316 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2317
738db178
DN
23182011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2319
2320 Make it possible to run ./temacs.
2321
2322 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2323 syms_of_callproc does the same thing. Remove test for
2324 "initialized", do it in the caller.
2325 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2326
620c53a6
SM
23272011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2328
2329 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2330 (read_minibuf): Use get_minibuffer.
2331 (syms_of_minibuf): Use DEFSYM.
2332 (Qmetadata): New var.
2333 * data.c (Qbuffer): Don't make it static.
2334 (syms_of_data): Use DEFSYM.
2335
e003a292
PE
23362011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2337
2338 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2339 (CCL_CODE_MIN): New macro.
2340
ed008a6d
PE
23412011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2342
3687c2ef
PE
2343 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2344
ed008a6d
PE
2345 * eval.c (Qdebug): Now static.
2346 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2347 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2348 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2349
d66c4c7c
CY
23502011-05-29 Chong Yidong <cyd@stupidchicken.com>
2351
2352 * image.c: Various fixes to ImageMagick code comments.
2353 (Fimagemagick_types): Doc fix.
2354
5fbc2025
PE
23552011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2356
0196f88a
PE
2357 Minor fixes prompted by GCC 4.6.0 warnings.
2358
2359 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2360
5fbc2025
PE
2361 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2362 (x_clipboard_manager_save_all): Move extern decl to ...
2363 * xterm.h: ... here, so that it can be checked for consistency.
2364
1dd3c2d9
CY
23652011-05-29 Chong Yidong <cyd@stupidchicken.com>
2366
2367 * xselect.c (x_clipboard_manager_save_frame)
2368 (x_clipboard_manager_save_all): New functions.
2369 (Fx_clipboard_manager_save): Lisp function deleted.
2370
2371 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2372 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2373
2374 * xterm.h: Update prototype.
2375
5ba6571d
WX
23762011-05-28 William Xu <william.xwl@gmail.com>
2377
2378 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2379 exiting (Bug#8239).
2380
3eaff834
JM
23812011-05-28 Jim Meyering <meyering@redhat.com>
2382
e1900994 2383 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2384 * fns.c (to_uchar): Define.
2385 (crypto_hash_function): Use it to convert some newly-signed
2386 variables to unsigned, to avoid sign-extension bugs. For example,
2387 without this change, (md5 "truc") would evaluate to
2388 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2389 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2390 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2391
0f6990a7
PE
23922011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2393
2394 Integer overflow fixes.
c8a9ca5a 2395
08686060
PE
2396 * dbusbind.c: Serial number integer overflow fixes.
2397 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2398 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2399 to hold a serial number that is too large for a fixnum.
2400 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2401 Check for serial numbers out of range. Decode any serial number
59568bf0 2402 that was so large that it became a float. (Bug#8722)
08686060 2403
2d1fc3c7
PE
2404 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2405 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2406 Use XFASTINT rather than XUINT when numbers are nonnegative.
2407 (xd_append_arg, Fdbus_method_return_internal):
2408 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2409 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2410 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2411 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2412 (Bug#8722)
2d1fc3c7 2413
c8a9ca5a
PE
2414 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2415
519e1d69
PE
2416 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2417
30569699
PE
2418 ccl: add integer overflow checks
2419 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2420 (IN_INT_RANGE): New macros.
2421 (ccl_driver): Use them to check for integer overflow when
2422 decoding a CCL program. Many of the new checks are whether XINT (x)
2423 fits in int; it doesn't always, on 64-bit hosts. The new version
2424 doesn't catch all possible integer overflows, but it's an
847044ea 2425 improvement. (Bug#8719)
30569699 2426
c11285dc
PE
2427 * alloc.c (make_event_array): Use XINT, not XUINT.
2428 There's no need for unsigned here.
2429
fdccd48e
PE
2430 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2431 This follows up to the 2011-05-06 change that substituted uintptr_t
2432 for EMACS_INT. This case wasn't caught back then.
2433
37910ab2
PE
2434 Rework Fformat to avoid integer overflow issues.
2435 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2436 now (part of C89). Include <verify.h>.
2437 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2438 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2439 (Fformat): Avoid the prepass trying to compute sizes; it was only
2440 approximate and thus did not catch overflow reliably. Instead, walk
2441 through the format just once, formatting and computing sizes as we go,
2442 checking for integer overflow at every step, and allocating a larger
2443 buffer as needed. Keep track separately whether the format is
2444 multibyte. Keep only the most-recently calculated precision, rather
2445 than them all. Record whether each argument has been converted to
2446 string. Use EMACS_INT, not int, for byte and char and arg counts.
2447 Support field widths and precisions larger than INT_MAX. Avoid
2448 sprintf's undefined behavior with conversion specifications such as %#d
2449 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2450 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2451 formatting out-of-range floating point numbers with int
9173deec 2452 formats. (Bug#8668)
37910ab2 2453
2e6578fb
PE
2454 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2455
0ae6bdee
PE
2456 * data.c: Avoid integer truncation in expressions involving floats.
2457 * data.c: Include <intprops.h>.
2458 (arith_driver): When there's an integer overflow in an expression
2459 involving floating point, convert the integers to floating point
2460 so that the resulting value does not suffer from catastrophic
2461 integer truncation. For example, on a 64-bit host (* 4
2462 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2463 Do not rely on undefined behavior after integer overflow.
2464
de883a70
PE
2465 merge count_size_as_multibyte, parse_str_to_multibyte
2466 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2467 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2468 Check for integer overflow.
2469 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2470 since it's now a duplicate of the other. This is more of
2471 a character than a buffer op, so better that it's in character.c.
2472 * fns.c, print.c: Adjust to above changes.
2473
2ff916cb
PE
24742011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2475
2476 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2477
f1b54466
PE
24782011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2479
fb1ac845
PE
2480 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2481 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2482 (x_clipboard_manager_save): Now static.
2483 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2484
f1b54466
PE
2485 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2486 (crypto_hash_function): Now static.
2487 Fix pointer signedness problems. Avoid unnecessary initializations.
2488
a9f737ee
CY
24892011-05-27 Chong Yidong <cyd@stupidchicken.com>
2490
2491 * termhooks.h (Vselection_alist): Make it terminal-local.
2492
2493 * terminal.c (create_terminal): Initialize it.
2494
2495 * xselect.c: Support for clipboard managers.
2496 (Vselection_alist): Move to termhooks.h as terminal-local var.
2497 (LOCAL_SELECTION): New macro.
2498 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2499 (symbol_to_x_atom): Remove gratuitous arg.
2500 (x_handle_selection_request, lisp_data_to_selection_data)
2501 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2502 (x_own_selection, x_get_local_selection, x_convert_selection):
2503 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2504 (some_frame_on_display): Delete unused function.
2505 (Fx_own_selection_internal, Fx_get_selection_internal)
2506 (Fx_disown_selection_internal, Fx_selection_owner_p)
2507 (Fx_selection_exists_p): New optional frame arg.
2508 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2509 (x_handle_selection_clear): Don't treat other terminals with the
2510 same keyboard specially. Use the terminal-local Vselection_alist.
2511 (x_clear_frame_selections): Use Frun_hook_with_args.
2512
2513 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2514
2515 * xterm.h: Add support for those atoms.
2516
e067f0c1
CY
25172011-05-26 Chong Yidong <cyd@stupidchicken.com>
2518
2519 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2520 (converted_selections, conversion_fail_tag): New global variables.
2521 (x_selection_request_lisp_error): Free the above.
2522 (x_get_local_selection): Remove unnecessary code.
2523 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2524 of converted selections stored in converted_selections.
2525 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2526 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2527 (x_convert_selection): New function.
2528 (x_handle_selection_event): Simplify.
2529 (x_get_foreign_selection): Don't ignore incoming requests while
2530 waiting for an answer; this will fail when we implement
2531 SAVE_TARGETS, and seems unnecessary anyway.
2532 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2533 (Vx_sent_selection_functions): Doc fix.
2534
0f4aebc0
LL
25352011-05-26 Leo Liu <sdl.web@gmail.com>
2536
2537 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2538
e61124cd
YM
25392011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2540
2541 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2542
2543 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2544 for fringe update if it has periodic bitmap.
ac389d0c 2545 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
2546 and fringe_bitmap_periodic_p.
2547
2548 * fringe.c (get_fringe_bitmap_data): New function.
2549 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2550 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2551 row. Mark glyph row for fringe update if periodicity changed.
2552
2553 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2554 for fringe update unless it has periodic bitmap.
2555
f16d9837
KH
25562011-05-25 Kenichi Handa <handa@m17n.org>
2557
2558 * xdisp.c (get_next_display_element): Set correct it->face_id for
2559 a static composition.
2560
e1b90ef6
LL
25612011-05-24 Leo Liu <sdl.web@gmail.com>
2562
2563 * deps.mk (fns.o):
2564 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2565
2566 * fns.c (crypto_hash_function, Fsha1): New function.
2567 (Fmd5): Use crypto_hash_function.
2568 (syms_of_fns): Add Ssha1.
2569
7400048f
PE
25702011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2571
2572 * gnutls.c: Remove unused macros.
2573 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2574 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2575 Remove macros that are defined and never used.
2576 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2577
abb71cf4
CY
25782011-05-22 Chong Yidong <cyd@stupidchicken.com>
2579
2580 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2581 (Fx_get_selection_internal): Minor cleanup.
2582 (Fx_own_selection_internal): Rename arguments for consistency with
2583 select.el.
2584
6307db39
PE
25852011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2586
2587 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2588
f3d4e0a4
CY
25892011-05-22 Chong Yidong <cyd@stupidchicken.com>
2590
2591 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2592
4d8ade89
YM
25932011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2594
2595 * dispnew.c (scrolling_window): Don't exclude the case that the
2596 last enabled row in the desired matrix touches the bottom boundary.
2597
32078c8d
GM
25982011-05-21 Glenn Morris <rgm@gnu.org>
2599
2600 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2601 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2602 and add some more files.
32078c8d 2603
7285dc67
EZ
26042011-05-20 Eli Zaretskii <eliz@gnu.org>
2605
2606 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2607 report_file_error introduced by the change from 2011-05-07.
2608
89d1bd22
PE
26092011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2610
2611 * systime.h (Time): Define only if emacs is defined.
2612 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2613 where the include path doesn't have X11/X.h by default. See
2614 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2615
e23640bb 26162011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2617
2618 * composite.c (find_automatic_composition): Fix previous change.
2619
b9704ad9
GM
26202011-05-20 Glenn Morris <rgm@gnu.org>
2621
2622 * lisp.mk: New file, split from Makefile.in.
2623 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2624 (shortlisp): Remove.
2625 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2626
4a720484
GM
26272011-05-19 Glenn Morris <rgm@gnu.org>
2628
2629 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2630 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2631 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2632 (lisp): Set the order to that of loadup.el.
2633 (shortlisp): Make it a copy of $lisp.
2634 (SOME_MACHINE_LISP): Remove.
2635 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2636 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2637
a28d4396
KH
26382011-05-18 Kenichi Handa <handa@m17n.org>
2639
2640 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2641 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2642 (find_automatic_composition): Mostly rewrite for efficiency.
2643
a2b1fa8e
JB
26442011-05-18 Juanma Barranquero <lekktu@gmail.com>
2645
2646 * makefile.w32-in: Update dependencies.
2647
8e1f5610
CS
26482011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2649
2650 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2651 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2652
7025ee00 26532011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2654
cdfa6eab
PE
2655 Fix some integer overflow issues, such as string length overflow.
2656
06d6db33
PE
2657 * insdel.c (count_size_as_multibyte): Check for string overflow.
2658
2b4560a8
PE
2659 * character.c (lisp_string_width): Check for string overflow.
2660 Use EMACS_INT, not int, for string indexes and lengths; in
2661 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2662 the resulting string length overflows an EMACS_INT; instead,
2663 report a string overflow if no precision given. When checking for
2664 precision exhaustion, use a check that cannot possibly have
2665 integer overflow. (Bug#8675)
2666 * character.h (lisp_string_width): Adjust to new signature.
2667
cb93f9be
PE
2668 * alloc.c (string_overflow): New function.
2669 (Fmake_string): Use it. This doesn't change behavior, but saves
2670 a few bytes and will simplify future changes.
2671 * character.c (string_escape_byte8): Likewise.
2672 * lisp.h (string_overflow): New decl.
2673
1a1f3366
PE
2674 Fixups, following up to the user-interface timestamp change.
2675 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2676 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2677 * msdos.c (mouse_get_pos): Likewise.
2678 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2679 * w32gui.h (Time): Define by including "systime.h" rather than by
2680 declaring it ourselves. (Bug#8664)
2681
d4e3e4d3
PE
2682 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2683 * image.c (clear_image_cache): Likewise.
2684
f6a24d19
PE
2685 * term.c (term_mouse_position): Don't assume time_t wraparound.
2686
08dc5ae6
PE
2687 Be more systematic about user-interface timestamps.
2688 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2689 and sometimes 'EMACS_UINT', to represent these timestamps.
2690 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2691 This makes the code easier to follow, and makes it easier to catch
2692 integer overflow bugs such as Bug#8664.
2693 * frame.c (Fmouse_position, Fmouse_pixel_position):
2694 Use Time, not unsigned long, for user-interface timestamps.
2695 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2696 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2697 * keyboard.h (last_event_timestamp): Likewise.
2698 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2699 * menu.h (xmenu_show): Likewise.
2700 * term.c (term_mouse_position): Likewise.
2701 * termhooks.h (struct input_event.timestamp): Likewise.
2702 (struct terminal.mouse_position_hook): Likewise.
2703 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2704 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2705 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2706 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2707 what it was before.
2708 * menu.h, termhooks.h: Include "systime.h", for Time.
2709
8e55734a
PE
2710 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2711 Don't assume that the difference between two unsigned long values
2712 can fit into an integer. At this point, we know button_down_time
2713 <= event->timestamp, so the difference must be nonnegative, so
2714 there's no need to cast the result if double-click-time is
2715 nonnegative, as it should be; check that it's nonnegative, just in
2716 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2717 apart (about 25 days). (Bug#8664)
8e55734a 2718
841f1b75 2719 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2720 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2721
3e26f69c
PE
2722 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2723 that always fit in int. Use a sentinel instead of a counter, to
2724 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2725 * frame.h (struct frame): Use int for menu_bar_items_used
2726 instead of EMACS_INT, since it always fits in int.
3e26f69c 2727
5cc152c0
PE
2728 * menu.c (grow_menu_items): Check for int overflow.
2729
d89eb65e
PE
2730 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2731
5235bd3e
PE
2732 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2733 Before, the code was not consistent. These values cannot exceed
2734 2**31 - 1 so there's no need to make them unsigned.
2735 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2736 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2737 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2738 as modifiers.
2739 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2740
bc827e23
PE
2741 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2742 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2743 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2744 presumably because the widths might not match.
2745
78eb494e
PE
2746 * window.c (size_window): Avoid needless test at loop start.
2747
04f2d78b
CB
27482011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2749
2750 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2751
d2fc7e3d 27522011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2753
2754 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2755
d2fc7e3d 27562011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2757
2758 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2759 `width' to `bar_area_x' and `bar_area_width', respectively.
2760 (x_scroll_run): Take account of fringe background extension.
2761
04f2d78b
CB
2762 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2763 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2764 `bar_area_width', respectively.
2765 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2766 background extension.
2767
79b70037
GM
27682011-05-10 Jim Meyering <meyering@redhat.com>
2769
2770 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2771
2f142cc5
JB
27722011-05-10 Juanma Barranquero <lekktu@gmail.com>
2773
2774 * image.c (Finit_image_library): Return t for built-in image types,
2775 like pbm and xbm. (Bug#8640)
2776
57679c86
AS
27772011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2778
2779 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2780
888c9e86
EZ
27812011-05-07 Eli Zaretskii <eliz@gnu.org>
2782
b0512a1d
EZ
2783 * w32console.c (Fset_screen_color): Doc fix.
2784 (Fget_screen_color): New function.
2785 (syms_of_ntterm): Defsubr it.
2786
7285dc67
EZ
2787 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2788 unlink the temporary file if Fcall_process didn't create it in the
2789 first place.
2790 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2791 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2792 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2793 cue to call_process_cleanup not to close that handle.
2794
4d3fcc8e
BK
27952011-05-07 Ben Key <bkey76@gmail.com>
2796
2797 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2798 one of two shell specific rules, either bootstrap-temacs-CMD or
2799 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2800 to the previous implementation of the bootstrap-temacs rule.
2801 The bootstrap-temacs-CMD rule is similar to the previous
2802 implementation of the bootstrap-temacs rule except that it
2803 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2804 variable.
2805
2806 These changes, along with some changes to nt/configure.bat,
2807 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2808 earlier fix to add support for --cflags and --ldflags options
2809 that include quotes so that it works whether make uses cmd or
2810 sh as the shell.
2811
b4289b64
MA
28122011-05-06 Michael Albinus <michael.albinus@gmx.de>
2813
2814 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2815 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2816 is a constant.
2817 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2818 a string. Handle both cases.
2819 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2820 (Fdbus_register_method): Use Qinvalid_function.
2821
af4c0e28
JB
28222011-05-06 Juanma Barranquero <lekktu@gmail.com>
2823
2824 * makefile.w32-in: Update dependencies.
2825 (LISP_H): Add inttypes.h and stdin.h.
2826 (PROCESS_H): Add unistd.h.
2827
c51453d9
EZ
28282011-05-06 Eli Zaretskii <eliz@gnu.org>
2829
2830 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2831 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2832
8ff0ac3c 28332011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2834
4c4b566b
PE
2835 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2836
aab2b9b5
PE
2837 * term.c (vfatal): Remove stray call to va_end.
2838 It's not needed and the C Standard doesn't allow it here anyway.
2839
c378da0b
PE
2840 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2841 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2842
288b08c7
PE
2843 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2844 bytes.
2845
e3601888
PE
2846 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2847
db6c0e74
PE
2848 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2849
dd5963ea
PE
2850 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2851
88c9450f
PE
2852 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2853
2f9442b8
PE
2854 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2855
c032b5f8
PE
2856 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2857 * charset.c (Fdefine_charset_internal): Don't initialize
2858 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2859 32-bit int (Bug#8600).
a108c10b
PE
2860
2861 * lread.c (read_integer): Be more consistent with string-to-number.
2862 Use string_to_number to do the actual conversion; this avoids
2863 rounding errors and fixes some other screwups. Without this fix,
2864 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2865 (digit_to_number): Move earlier, for benefit of read_integer.
2866 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2867 not a digit in any supported base. (Bug#8602)
a108c10b 2868
ad5f9eea
PE
2869 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2870
aec1708a
PE
2871 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2872 to match comment at start of function. This also removes a
2873 GCC warning about overflow in a 32+64-bit port.
2874
47be4ab5
PE
2875 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2876
371cac43
PE
2877 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2878 Reported by Stefan Monnier in
2879 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2880 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2881 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2882
d01a7826
PE
2883 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2884 (EMACS_UINTPTR): Likewise, with uintptr_t.
2885
7fd47d5c
PE
2886 * lisp.h: Prefer 64-bit EMACS_INT if available.
2887 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2888 on 32-bit hosts that have 64-bit int, so that they can access
2889 large files.
122b0c86
PE
2890 However, temporarily disable this change unless the temporary
2891 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2892
8727937b
PE
2893 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2894
8ac068ac
PE
2895 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2896 This removes an assumption that EMACS_INT and long are the same
2897 width as pointers. The assumption is true for Emacs porting targets
2898 now, but we want to make other targets possible.
2899 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2900 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2901 In the rest of the code, change types of integers that hold casted
2902 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2903 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2904 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2905 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2906 No need to cast type when ORing.
2907 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2908 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2909 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2910 assume EMACS_INT is the same width as char *.
2911 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2912 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2913 Remove no-longer-needed casts.
2914 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2915 (xg_tool_bar_help_callback, xg_make_tool_item):
2916 Use EMACS_INTPTR to hold an integer
2917 that will be cast to void *; this can avoid a GCC warning
2918 if EMACS_INT is not the same width as void *.
2919 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2920 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2921 (current_message_1, set_message_1):
2922 Use a local to convert to proper width without a cast.
2923 * xmenu.c (dialog_selection_callback): Likewise.
2924
ede49d71
PE
2925 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2926 Also, don't assume VALBITS / RAND_BITS is less than 5,
2927 and don't rely on undefined behavior when shifting a 1 left into
2928 the sign bit.
2929 * lisp.h (get_random): Change signature to match.
2930
2f30ecd0
PE
2931 * lread.c (hash_string): Use size_t, not int, for hash computation.
2932 Normally we prefer signed values; but hashing is special, because
2933 it's better to use unsigned division on hash table sizes so that
2934 the remainder is nonnegative. Also, size_t is the natural width
2935 for hashing into memory. The previous code used 'int', which doesn't
2936 retain enough info to hash well into very large tables.
2937 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2938
2a866e7b
PE
2939 * dbusbind.c: Don't possibly lose pointer info when converting.
2940 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2941 Use XPNTR rather than XHASH, so that the high-order bits of
2942 the pointer aren't lost when converting through void *.
2943
51639eac
PE
2944 * eval.c (Fautoload): Don't double-shift a pointer.
2945
92394119
PE
2946 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2947
dbdb9a7c
JB
29482011-05-06 Juanma Barranquero <lekktu@gmail.com>
2949
2950 * gnutls.c (DEF_GNUTLS_FN):
2951 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2952
db7a0b4f
AS
29532011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2954
2955 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2956 marker. (Bug#8610)
2957
f7ff1b0f 29582011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2959
2960 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2961 New version that can reserve upto 2GB of heap space.
2962
f7ff1b0f 29632011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2964
2965 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2966
639c109b
TZ
29672011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2968
2969 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2970 `gnutls_certificate_set_x509_key_file'.
2971
d2127135
JB
29722011-05-05 Juanma Barranquero <lekktu@gmail.com>
2973
2974 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2975 Update dependencies.
2976
e968f4f3
JB
29772011-05-04 Juanma Barranquero <lekktu@gmail.com>
2978
2979 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2980 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2981 Remove unused parameter `fildes'.
2982 * process.c (read_process_output, send_process): Don't pass it.
2983
84d358f0
JB
29842011-05-04 Juanma Barranquero <lekktu@gmail.com>
2985
2986 Fix previous change: the library cache is defined in w32.c.
2987 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2988 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2989
0898ca10
JB
29902011-05-04 Juanma Barranquero <lekktu@gmail.com>
2991
2992 Implement dynamic loading of GnuTLS on Windows.
2993
2994 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2995 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2996 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2997 Declare.
2998
2999 * gnutls.c (Qgnutls_dll): Define.
3000 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3001 (gnutls_*): Declare function pointers.
3002 (init_gnutls_functions): New function to initialize function pointers.
3003 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3004 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3005 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3006 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3007 (emacs_gnutls_write, emacs_gnutls_read)
3008 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3009 (Fgnutls_available_p): New function.
3010 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3011 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3012 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3013
3014 * image.c: Include w32.h.
3015 (Vimage_type_cache): Delete.
3016 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3017 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3018 (w32_delayed_load): Move to w32.c.
3019
3020 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3021
3022 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3023 (w32_delayed_load): Move from image.c. When loading a library, record
3024 its filename in the :loaded-from property of the library id.
3025 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3026 Initialize and staticpro them.
3027 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3028
3029 * process.c: Include lisp.h before w32.h, not after.
3030 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3031 instead of gnutls_record_check_pending.
3032
3033 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3034
ff4de4aa
TZ
30352011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3036
3037 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3038 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3039 as passed in.
3040
abe95abb
JD
30412011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3042
3043 * xterm.c (x_set_frame_alpha): Do not set property on anything
3044 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3045
e16e55d4
JB
30462011-05-02 Juanma Barranquero <lekktu@gmail.com>
3047
3048 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3049
bafcf6a5
JB
30502011-05-02 Juanma Barranquero <lekktu@gmail.com>
3051
3052 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3053 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3054 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3055 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3056 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3057 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3058 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3059 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3060 (Qgnutls_bootprop_callbacks_verify): Make static.
3061
e7a6747f
AS
30622011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3063
19ed11ba
AS
3064 * callproc.c: Indentation fixup.
3065
e7a6747f 3066 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3067 (wait_for_termination, interruptible_wait_for_termination):
3068 Move after wait_for_termination_1.
e7a6747f 3069
1ef14cb4
LMI
30702011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3071
3072 * sysdep.c (interruptible_wait_for_termination): New function
3073 which is like wait_for_termination, but allows keyboard
3074 interruptions.
3075
3076 * callproc.c (Fcall_process): Add (:file "file") as an option for
3077 the STDOUT buffer.
3078 (Fcall_process_region): Ditto.
3079
330d880c
EZ
30802011-04-30 Eli Zaretskii <eliz@gnu.org>
3081
8db90b73
EZ
3082 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3083 rather than `XVECTOR (FOO)->size'.
3084
330d880c
EZ
3085 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3086 inttypes.h, as a gnulib replacement is used if it not available in
3087 system headers.
3088
15cbd324
EZ
30892011-04-21 Eli Zaretskii <eliz@gnu.org>
3090
3091 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3092 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3093 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3094
3095 * coding.c (coding_alloc_by_realloc): Error out if destination
3096 will grow beyond MOST_POSITIVE_FIXNUM.
3097 (decode_coding_emacs_mule): Abort if there isn't enough place in
3098 charbuf for the composition carryover bytes. Reserve an extra
3099 space for up to 2 characters produced in a loop.
3100 (decode_coding_iso_2022): Abort if there isn't enough place in
3101 charbuf for the composition carryover bytes.
3102
31032011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3104
ae940cca
EZ
3105 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3106 aborting when %lld or %lll format is passed.
3107 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3108 %llo or %llx format is passed. (Bug#8545)
3109
03ab8921
EZ
3110 * window.c (window_scroll_line_based): Use a marker instead of
3111 simple variables to record original value of point. (Bug#7952)
3112
afda1437
EZ
3113 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3114 produced by %s or %c overflows available buffer space. (Bug#8545)
3115
f76dee0c
PE
31162011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3117
3118 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3119 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3120
fdc5744d
JB
31212011-04-28 Juanma Barranquero <lekktu@gmail.com>
3122
3123 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3124
638f053a
JB
31252011-04-28 Juanma Barranquero <lekktu@gmail.com>
3126
3127 * keyboard.c (Qdelayed_warnings_hook): Define.
3128 (command_loop_1): Run `delayed-warnings-hook'
3129 if Vdelayed_warnings_list is non-nil.
3130 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3131 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3132
d178f871
EZ
31332011-04-28 Eli Zaretskii <eliz@gnu.org>
3134
3135 * doprnt.c (doprnt): Don't return value smaller than the buffer
3136 size if the message was truncated. (Bug#8545).
3137
b124fd93
JB
31382011-04-28 Juanma Barranquero <lekktu@gmail.com>
3139
3140 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3141 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3142
e810457d
PE
31432011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3144
3145 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3146
ea51cceb
JB
31472011-04-27 Juanma Barranquero <lekktu@gmail.com>
3148
3149 * makefile.w32-in: Update dependencies.
3150
94dcfacf
EZ
31512011-04-27 Eli Zaretskii <eliz@gnu.org>
3152
3153 Improve `doprnt' and its usage. (Bug#8545)
3154 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3155 `format_end'. Remove support for %l as a conversion specifier.
3156 Don't use xrealloc. Improve diagnostics when the %l size modifier
3157 is used. Update the commentary.
3158
3159 * eval.c (verror): Simplify calculation of size_t.
3160
3161 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3162 messages.
3163
f61f41d7
PE
31642011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3165
3166 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3167 change.
3168
96fb4434
PE
31692011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3170
3171 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3172 This makes this file independent of the recent pseudovector change.
3173
671875da 31742011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3175
69e9b5a3
PE
3176 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3177
b5f869a7 3178 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3179 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3180 Remove unused local.
c8926152 3181 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3182
841a1577 3183 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3184 GCC 4.6.0 optimizes based on type-based alias analysis.
3185 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3186 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3187 != &v->size, and therefore "v->size = 1; b->size = 2; return
3188 v->size;" must therefore return 1. This assumption is incorrect
3189 for Emacs, since it type-puns struct Lisp_Vector * with many other
3190 types. To fix this problem, this patch adds a new type struct
f904488f 3191 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3192 and pseudovectors, and helps optimizing compilers not get fooled
3193 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3194 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3195 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3196 the size member.
eab3844f
PE
3197 (XSETPVECTYPE): Rewrite in terms of new macro.
3198 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3199 This is a bit clearer, and further avoids the possibility of
3200 undesirable aliasing.
3201 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3202 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3203 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3204 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3205 (ASIZE): Now uses header.size rather than size.
3206 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3207 to avoid the hassle of writing XVECTOR (foo)->header.size.
3208 (struct vectorlike_header): New type.
eab3844f
PE
3209 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3210 object, to help avoid aliasing.
3211 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3212 (SUBRP): Likewise, since Lisp_Subr is a special case.
3213 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3214 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3215 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3216 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3217 changed to be "header.size" and "header.next".
3218 * buffer.h (struct buffer): Likewise.
3219 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3220 * frame.h (struct frame): Likewise.
3221 * process.h (struct Lisp_Process): Likewise.
3222 * termhooks.h (struct terminal): Likewise.
3223 * window.c (struct save_window_data, struct saved_window): Likewise.
3224 * window.h (struct window): Likewise.
3225 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3226 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3227 * buffer.c (init_buffer_once): Likewise.
3228 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3229 special case.
3230 * process.c (Fformat_network_address): Use local var for size,
3231 for brevity.
3232
0df1eac5
PE
3233 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3234
847ab9d1 3235 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3236 * data.c (atof): Remove decl; no longer used or needed.
3237 (digit_to_number): Move to lread.c.
3238 (Fstring_to_number): Use new string_to_number function, to be
3239 consistent with how the Lisp reader treats infinities and NaNs.
3240 Do not assume that floating-point numbers represent EMACS_INT
3241 without losing information; this is not true on most 64-bit hosts.
3242 Avoid double-rounding errors, by insisting on integers when
3243 parsing non-base-10 numbers, as the documentation specifies.
3244 * lisp.h (string_to_number): New decl, replacing ...
3245 (isfloat_string): Remove.
bc0a5c13 3246 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3247 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3248 appears to have been a coding error. Similarly, do not accept
3249 strings like +-1e0 as floating point numbers. Do not report
3250 overflow for integer overflows unless the base is not 10 which
3251 means we have no simple and reliable way to continue.
3252 Break out the floating-point parsing into a new
3253 function string_to_number, so that Fstring_to_number parses
3254 floating point numbers consistently with the Lisp reader.
04f2d78b 3255 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3256 (E_CHAR, EXP_INT): Remove, replacing with ...
3257 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3258 (string_to_number): New function, replacing isfloat_string.
3259 This function checks for valid syntax and produces the resulting
3260 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3261 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3262 so that overflow for non-base-10 numbers is reported only when
3263 there's no portable and simple way to convert to floating point.
452f4150 3264
67769ffc
PE
3265 * textprop.c (set_text_properties_1): Rewrite for clarity,
3266 and to avoid GCC warning about integer overflow.
3267
c20db43f
PE
3268 * intervals.h (struct interval): Use EMACS_INT for members
3269 where EMACS_UINT might cause problems. See
3270 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3271 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3272 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3273 All uses changed.
37aa2f85
PE
3274 (offset_intervals): Tell GCC not to worry about length overflow
3275 when negating a negative length.
c20db43f 3276
2538aa2f
PE
3277 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3278 (overrun_check_free): Likewise.
3279
f2d3008d
PE
3280 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3281 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3282 word size.
3283
ec8df744
PE
3284 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3285 (gnutls_make_error): Rename local to avoid shadowing.
3286 (gnutls_emacs_global_deinit): ifdef out; not used.
3287 (Fgnutls_boot): Use const for pointer to readonly storage.
3288 Comment out unused local. Fix pointer signedness problems.
3289
640ee02d
PE
3290 * lread.c (openp): Don't stuff size_t into an 'int'.
3291 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3292 about possible signed overflow.
3293
6048fb2a
PE
3294 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3295 (GDK_KEY_g): Don't define if already defined.
3296 (xg_prepare_tooltip): Avoid pointer signedness problem.
3297 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3298
fa3c87e1
PE
3299 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3300 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3301
2172544b
PE
3302 * xfns.c (Fx_window_property): Simplify a bit,
3303 to make a bit faster and to avoid GCC 4.6.0 warning.
3304 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3305
9b821a21
PE
3306 * fns.c (internal_equal): Don't assume size_t fits in int.
3307
3c616cfa
PE
3308 * alloc.c (compact_small_strings): Tighten assertion a little.
3309
c2982e87
PE
3310 Replace pEd with more-general pI, and fix some printf arg casts.
3311 * lisp.h (pI): New macro, generalizing old pEd macro to other
3312 conversion specifiers. For example, use "...%"pI"d..." rather
3313 than "...%"pEd"...".
3314 (pEd): Remove. All uses replaced with similar uses of pI.
3315 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3316 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3317 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3318 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3319 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3320 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3321 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3322 64-bit hosts.
3323 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3324 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3325 * print.c (safe_debug_print, print_object): Likewise.
3326 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3327 to int.
6f04d126
PE
3328 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3329 avoiding the 0 flag, which is not portable.
c2982e87
PE
3330 * process.c (Fmake_network_process): Use pI to avoid cast.
3331 * region-cache.c (pp_cache): Likewise.
3332 * xdisp.c (decode_mode_spec): Likewise.
3333 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3334 behavior on 64-bit hosts with printf arg.
6f04d126 3335 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3336 (x_stop_queuing_selection_requests): Likewise.
3337 (x_get_window_property): Don't truncate byte count to an 'int'
3338 when tracing.
0b432f21 3339
5e073ec7
PE
3340 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3341 here, since it parses constructs like leading '-' and spaces,
3342 which are not wanted; and it overflows with large numbers.
3343 Instead, simply match F[0-9]+, which is what is wanted anyway.
3344
36372bf9
PE
3345 * alloc.c: Remove unportable assumptions about struct layout.
3346 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3347 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3348 (allocate_vectorlike, make_pure_vector): Use the new macros,
3349 plus offsetof, to remove unportable assumptions about struct layout.
3350 These assumptions hold on all porting targets that I know of, but
3351 they are not guaranteed, they're easy to remove, and removing them
3352 makes further changes easier.
3353
0b432f21
PE
3354 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3355 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3356 (string_overrun_cookie): Now const. Use initializers that
3357 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3358 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3359 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3360 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3361 multiple of sizeof (EMACS_INT); it need not be, if
3362 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3363 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3364
895009e1
JB
33652011-04-26 Juanma Barranquero <lekktu@gmail.com>
3366
3367 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3368
6a7a1b0b
TZ
33692011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3370
3371 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3372 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3373 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3374
841a1577 33752011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3376
3377 * lisp.h (Qdebug): List symbol.
895009e1 3378 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3379 * keyboard.c (debug-on-event): New variable.
3380 (handle_user_signal): Break into debugger when debug-on-event
3381 matches the current signal symbol.
3382
f2d3ba6f
DN
33832011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3384
3385 * alloc.c (check_sblock, check_string_bytes)
3386 (check_string_free_list): Convert to standard C.
3387
42ce4c63
TZ
33882011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3389
3390 * w32.c (emacs_gnutls_push): Fix typo.
3391
825cd63c
EZ
33922011-04-25 Eli Zaretskii <eliz@gnu.org>
3393
fb11d64d
EZ
3394 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3395 "cast to pointer from integer of different size".
3396
825cd63c
EZ
3397 Improve doprnt and its use in verror. (Bug#8545)
3398 * doprnt.c (doprnt): Document the set of format control sequences
3399 supported by the function. Use SAFE_ALLOCA instead of always
3400 using `alloca'.
3401
3402 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3403 is one byte too soon. Don't use xrealloc; instead xfree and
3404 xmalloc anew.
3405
e061a11b
TZ
34062011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3407
3408 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3409 callbacks stage.
3410
3411 * gnutls.c: Renamed global_initialized to
3412 gnutls_global_initialized. Added internals for the
3413 :verify-hostname-error, :verify-error, and :verify-flags
3414 parameters of `gnutls-boot' and documented those parameters in the
3415 docstring. Start callback support.
9173deec
JB
3416 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3417 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3418 on error. Return error code.
e061a11b
TZ
3419 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3420 (emacs_gnutls_read): Likewise.
3421 (Fgnutls_boot): Return handshake error code.
3422 (emacs_gnutls_handle_error): New function.
3423 (wsaerror_to_errno): Likewise.
3424
3425 * w32.h (emacs_gnutls_pull): Add prototype.
3426 (emacs_gnutls_push): Likewise.
3427
3428 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3429 (emacs_gnutls_push): Likewise.
3430
34312011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3432
3433 * process.c (wait_reading_process_output): Check if GnuTLS
3434 buffered some data internally if no FDs are set for TLS
3435 connections.
3436
3437 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3438 (LIBS): Link to USER_LIBS.
3439 ($(BLD)/gnutls.$(0)): New target.
3440
fa6996bc
EZ
34412011-04-24 Eli Zaretskii <eliz@gnu.org>
3442
eb35682e
EZ
3443 * xdisp.c (handle_single_display_spec): Rename the
3444 display_replaced_before_p argument into display_replaced_p, to
3445 make it consistent with the commentary. Fix typos in the
3446 commentary.
3447
e2ad650c
EZ
3448 * textprop.c (syms_of_textprop): Remove dead code.
3449 (copy_text_properties): Delete obsolete commentary about an
3450 interface that was deleted long ago. Fix typos in the description
3451 of arguments.
3452
1b2de274
EZ
3453 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3454 to changes in oldXMenu/XMenu.h from 2011-04-16.
3455 <menu_help_message, prev_menu_help_message>: Constify.
3456 (IT_menu_make_room): menu->help_text is now `const char **';
3457 adjust.
3458
3459 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3460 to changes in oldXMenu/XMenu.h from 2011-04-16.
3461 (struct XMenu): Declare `help_text' `const char **'.
3462
3463 * xfaces.c <Qunspecified>: Make extern again.
3464
3465 * syntax.c: Include sys/types.h before including regex.h, as
3466 required by Posix.
3467
762b15be
EZ
3468 * doc.c (get_doc_string): Improve the format passed to `error'.
3469
3470 * doprnt.c (doprnt): Improve commentary.
3471
3472 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3473
3474 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3475 them with etags.
3476
f1052e5d
EZ
3477 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3478 changes in globals.h immediately force recompilation.
762b15be
EZ
3479 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3480 $(CURDIR)/s/ms-w32.h.
3481 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3482
fa6996bc
EZ
3483 * character.c (Fchar_direction): Function deleted.
3484 (syms_of_character): Don't defsubr it.
3485 <char-direction-table>: Deleted.
3486
e6c3da20
EZ
34872011-04-23 Eli Zaretskii <eliz@gnu.org>
3488
3489 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3490 * doprnt.c: Include limits.h.
3491 (SIZE_MAX): New macro.
04f2d78b
CB
3492 (doprnt): Return a size_t value. 2nd arg is now size_t.
3493 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3494 Improve overflow protection. Support `l' modifier for integer
3495 conversions. Support %l conversion. Don't assume an EMACS_INT
3496 argument for integer conversions and for %c.
3497
3498 * lisp.h (doprnt): Restore prototype.
3499
3500 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3501 $(SRC)/character.h.
3502
3503 * Makefile.in (base_obj): Add back doprnt.o.
3504
3505 * deps.mk (doprnt.o): Add back prerequisites.
3506 (callint.o): Depend on character.h.
3507
3508 * eval.c (internal_lisp_condition_case): Include the handler
3509 representation in the error message.
3510 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3511 when breaking from the loop.
3512
3513 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3514
3515 * callint.c (Fcall_interactively): When displaying error message
3516 about invalid control letter, pass the character's codepoint, not
3517 a pointer to its multibyte form. Improve display of the character
3518 in octal and display also its hex code.
3519
3520 * character.c (char_string): Use %x to display the (unsigned)
3521 codepoint of an invalid character, to avoid displaying a bogus
3522 negative value.
3523
3524 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3525 `error', not SYMBOL_NAME itself.
3526
3527 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3528 character arguments to `error'.
3529
3530 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3531 to `error' in error message about FINAL_CHAR argument. Make sure
3532 FINAL_CHAR is a character, and use %c when it is passed as
3533 argument to `error'.
3534
4ffd0d6b 35352011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3536
3537 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3538
3539 * w32.c: Include <time.h>.
3540 (sys_localtime): New function.
3541
4ffd0d6b 35422011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3543
3544 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3545
4ffd0d6b 3546 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3547
4ffd0d6b 35482011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3549
4ffd0d6b
GM
3550 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3551 zombies (Bug#8467).
aac0c6e3 3552
04c56954
EZ
35532011-04-19 Eli Zaretskii <eliz@gnu.org>
3554
3555 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3556 gl_state.e_property when gl_state.object is Qt.
3557
3558 * insdel.c (make_gap_larger): Remove limitation of buffer size
3559 to <= INT_MAX.
3560
16a43933
CY
35612011-04-18 Chong Yidong <cyd@stupidchicken.com>
3562
3563 * xdisp.c (lookup_glyphless_char_display)
3564 (produce_glyphless_glyph): Handle cons cell entry in
3565 glyphless-char-display.
3566 (Vglyphless_char_display): Document it.
3567
3568 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3569 glyphless-char-display.
3570
4581706e
CY
35712011-04-17 Chong Yidong <cyd@stupidchicken.com>
3572
3573 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3574
3575 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3576
3577 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3578 definition for no-X builds.
3579
4887c6e2 35802011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3581
fd35b6f9
PE
3582 Static checks with GCC 4.6.0 and non-default toolkits.
3583
5c1ccb01
PE
3584 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3585
006c5daa
PE
3586 * process.c (keyboard_bit_set): Define only if SIGIO.
3587 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3588 (send_process): Repair possible setjmp clobbering.
3589
efc736d3
PE
3590 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3591
4e2fe2e6
PE
3592 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3593
f97334a2
PE
3594 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3595
4e75f29d
PE
3596 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3597 Define only if needed.
3598
90efadd1
PE
3599 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3600 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3601 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3602
3c647824
PE
3603 * dispextern.h (struct redisplay_interface): Rename param
3604 to avoid shadowing.
e264f262 3605 * termhooks.h (struct terminal): Likewise.
761383f4 3606 * xterm.c (xembed_send_message): Likewise.
3c647824 3607
b58c5c4a
PE
3608 * insdel.c (make_gap_smaller): Define only if
3609 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3610
cad59032
PE
3611 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3612 it.
3613
c339dc2e
PE
3614 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3615 so that we aren't warned about unused symbols.
3616
91a3e27b
PE
3617 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3618
399c71d3 3619 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3620
8ffc96f5
PE
3621 * xfns.c (x_real_positions): Mark locals as initialized.
3622
eef9bc79
PE
3623 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3624
098db9dd
PE
3625 * xterm.c: Fix problems found by static analysis with other toolkits.
3626 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3627 (x_dispatch_event): Declare static if USE_GTK, and
3628 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3629 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3630 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3631 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3632 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3633
eb18f6cc
PE
3634 * xmenu.c (menu_help_callback): Pointer type fixes.
3635 Use const pointers when pointing at readonly data. Avoid pointer
3636 signedness clashes.
3637 (FALSE): Remove unused macro.
3638 (update_frame_menubar): Remove unused decl.
3639
1fe72bf8
PE
3640 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3641
60d9e1db
PE
3642 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3643 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3644 (single_menu_item): Rename local to avoid shadowing.
3645
39261c26
PE
3646 * keyboard.c (make_lispy_event): Remove unused local var.
3647
018c5e19
PE
3648 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3649 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3650
63d2b86e
PE
3651 * bitmaps: Change bitmaps from unsigned char back to the X11
3652 compatible char. Avoid the old compiler warnings about
3653 out-of-range initializers by using, for example, '\xab' rather
3654 than 0xab.
3655
aefd87e1
PE
3656 * xgselect.c (xgselect_initialize): Check vs interface
3657 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3658
bf501fb9
PE
3659 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3660
e9829fdf
PE
3661 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3662 to read-only memory.
3663
1086c095
PE
3664 * fns.c (vector): Remove; this old hack is no longer needed.
3665
2baccd04 3666 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3667 Remove unused var.
dde42981 3668 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3669
72391843 3670 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3671
436c16df 3672 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3673 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3674 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3675
92bb796d 3676 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3677 (x_term_init): Remove local to avoid shadowing.
92bb796d 3678
764430a3 3679 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3680
3681 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3682 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3683
d1dfb56c
EZ
36842011-04-16 Eli Zaretskii <eliz@gnu.org>
3685
c4354cb4
EZ
3686 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3687
d1dfb56c
EZ
3688 Fix regex.c, syntax.c and friends for buffers > 2GB.
3689 * syntax.h (struct gl_state_s): Declare character position members
3690 EMACS_INT.
3691
3692 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3693
04f2d78b
CB
3694 * textprop.c (verify_interval_modification, interval_of):
3695 Declare arguments EMACS_INT.
d1dfb56c
EZ
3696
3697 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3698 EMACS_INT.
3699
3700 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3701
3702 * indent.c (Fvertical_motion): Local variable it_start is now
3703 EMACS_INT.
3704
3705 * regex.c (re_match, re_match_2, re_match_2_internal)
3706 (bcmp_translate, regcomp, regexec, print_double_string)
3707 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3708 (re_compile_pattern, re_exec): Declare arguments and local
3709 variables `size_t' and `ssize_t' and return values `regoff_t', as
3710 appropriate.
3711 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3712 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3713 <compile_stack_type>: `size' and `avail' are now `size_t'.
3714
3715 * regex.h <regoff_t>: Use ssize_t, not int.
3716 (re_search, re_search_2, re_match, re_match_2): Arguments that
3717 specify buffer/string position and length are now ssize_t and
3718 size_t. Return type is regoff_t.
3719
613052cd
BK
37202011-04-16 Ben Key <bkey76@gmail.com>
3721
3722 * nsfont.m: Fixed bugs in ns_get_family and
3723 ns_descriptor_to_entity that were caused by using free to
3724 deallocate memory blocks that were allocated by xmalloc (via
3725 xstrdup). This caused Emacs to crash when compiled with
3726 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3727 --enable-checking=xmallocoverrun). xfree is now used to
3728 deallocate these memory blocks.
3729
4170f62f 37302011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3731
71b41406
PE
3732 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3733
9587a89d
PE
3734 emacs_write: Accept and return EMACS_INT for sizes.
3735 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3736 et seq.
3737 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3738 Accept and return EMACS_INT.
3739 (emacs_gnutls_write): Return the number of bytes written on
3740 partial writes.
3741 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3742 (emacs_read, emacs_write): Remove check for negative size, as the
3743 Emacs source code has been audited now.
9587a89d
PE
3744 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3745 (emacs_read, emacs_write): Use it.
273a5f82
PE
3746 * process.c (send_process): Adjust to the new signatures of
3747 emacs_write and emacs_gnutls_write. Do not attempt to store
3748 a byte offset into an 'int'; it might overflow.
9587a89d 3749 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3750
3e047f51
PE
3751 * sound.c: Don't assume sizes fit in 'int'.
3752 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3753 Return EMACS_INT, not int.
3e047f51 3754 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3755 Accept EMACS_INT, not int.
3756 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3757 record read return values.
3758
cc39a9db
BK
37592011-04-15 Ben Key <bkey76@gmail.com>
3760
c9d0ec6d
JB
3761 * keyboard.c (Qundefined): Don't declare static since it is used
3762 in nsfns.m.
3763 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3764 static since they are used in nsfont.m.
cc39a9db 3765
6c60eb9f
SM
37662011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3767
3768 * process.c (Qprocessp): Don't declare static.
3769 * lisp.h (Qprocessp): Declare again.
3770
7990b61a
JB
37712011-04-15 Juanma Barranquero <lekktu@gmail.com>
3772
3773 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3774
5d4cb038
PE
37752011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3776
8bd7b830 3777 Improve C-level modularity by making more things 'static'.
cd64ea1d 3778
e3b27b31
PE
3779 Don't publish debugger-only interfaces to other modules.
3780 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3781 (verify_bytepos, count_markers): Move decls to the only modules
3782 that need them.
3783 * region-cache.h (pp_cache): Likewise.
3784 * window.h (check_all_windows): Likewise.
3785 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3786
5d4cb038
PE
3787 * sysdep.c (croak): Now static, if
3788 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3789 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3790
3791 * alloc.c (refill_memory_reserve): Now static if
3792 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3793 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3794
e87b6180
PE
3795 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3796 Define only if USE_LUCID.
3797
ac64929e
PE
3798 * xrdb.c (x_customization_string, x_rm_string): Now static.
3799
6f37259d
PE
3800 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3801 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3802
1683e3ab
PE
3803 * xdisp.c (draw_row_with_mouse_face): Now static.
3804 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3805
de9c2632
PE
3806 * window.h (check_all_windows): Mark externally visible.
3807
2b96acb7
PE
3808 * window.c (window_deletion_count): Now static.
3809
3810 * undo.c: Make symbols static if they're not exported.
3811 (last_undo_buffer, last_boundary_position, pending_boundary):
3812 Now static.
3813
50436f33
PE
3814 * textprop.c (interval_insert_behind_hooks): Now static.
3815 (interval_insert_in_front_hooks): Likewise.
3816
64520e5c
PE
3817 * term.c: Make symbols static if they're not exported.
3818 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3819 (max_frame_lines, tty_set_terminal_modes):
3820 (tty_reset_terminal_modes, tty_turn_off_highlight):
3821 (get_tty_terminal): Now static.
3822 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3823 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3824 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3825 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3826 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3827
1fa53021
PE
3828 * sysdep.c: Make symbols static if they're not exported.
3829 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3830 Now static.
3831 (sigprocmask_set, full_mask): Remove; unused.
3832 (wait_debugging): Mark as visible.
3833 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3834 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3835
d4b43b22
PE
3836 * syntax.c (syntax_temp): Define only if !__GNUC__.
3837
b7c513d0
PE
3838 * sound.c (current_sound_device, current_sound): Now static.
3839
989b29ad
PE
3840 * search.c (searchbufs, searchbuf_head): Now static.
3841
13a55a78
PE
3842 * scroll.c (scroll_cost): Remove; unused.
3843 * dispextern.h (scroll_cost): Remove decl.
3844
de68a1fc
PE
3845 * region-cache.h (pp_cache): Mark as externally visible.
3846
40ccffa6
PE
3847 * process.c: Make symbols static if they're not exported.
3848 (process_tick, update_tick, create_process, chan_process):
3849 (Vprocess_alist, proc_buffered_char, datagram_access):
3850 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3851 (deactivate_process): Mark defn as static, as well as decl.
3852 * lisp.h (create_process): Remove decl.
3853 * process.h (chan_process, Vprocess_alist): Remove decls.
3854
ad64fc97
PE
3855 * print.c: Make symbols static if they're not exported.
3856 (print_depth, new_backquote_output, being_printed, print_buffer):
3857 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3858 (print_interval, print_number_index, initial_stderr_stream):
3859 Now static.
3860 * lisp.h (Fprinc): Remove decl.
3861 (debug_output_compilation_hack): Mark as externally visible.
3862
adddb265
PE
3863 * sysdep.c (croak): Move decl from here to syssignal.h.
3864 * syssignal.h (croak): Put it here, so the API can be checked when
3865 'croak' is called from dissociate_if_controlling_tty.
3866
1717ede2
PE
3867 * minibuf.c: Make symbols static if they're not exported.
3868 (minibuf_save_list, choose_minibuf_frame): Now static.
3869 * lisp.h (choose_minibuf_frame): Remove decl.
3870
fa5fb2bc
PE
3871 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3872
1e3890d1
PE
3873 * lread.c: Make symbols static if they're not exported.
3874 (read_objects, initial_obarray, oblookup_last_bucket_number):
3875 Now static.
3876 (make_symbol): Remove; unused.
3877 * lisp.h (initial_obarray, make_symbol): Remove decls.
3878
8a1414fa
PE
3879 * keyboard.c: Make symbols static if they're not exported.
3880 (single_kboard, recent_keys_index, total_keys, recent_keys):
3881 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3882 (this_single_command_key_start, echoing, last_auto_save):
3883 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3884 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3885 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3886 (Vlispy_mouse_stem, double_click_count):
3887 Now static.
3888 (force_auto_save_soon): Define only if SIGDANGER.
3889 (ignore_mouse_drag_p): Now static if
3890 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3891 (print_help): Remove; unused.
3892 (stop_character, last_timer_event): Mark as externally visible.
3893 * keyboard.h (ignore_mouse_drag_p): Declare only if
3894 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3895 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3896 * lisp.h (echoing): Remove decl.
3897 (force_auto_save_soon): Declare only if SIGDANGER.
3898 * xdisp.c (redisplay_window): Simplify code, to make it more
3899 obvious that ignore_mouse_drag_p is not accessed if !defined
3900 USE_GTK && !defined HAVE_NS.
3901
93ea6e8f
PE
3902 * intervals.c: Make symbols static if they're not exported.
3903 (merge_properties_sticky, merge_interval_right, delete_interval):
3904 Now static.
3905 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3906
77382fcc
PE
3907 * insdel.c: Make symbols static if they're not exported.
3908 However, leave prepare_to_modify_buffer alone. It's never
3909 called from outside this function, but that appears to be a bug.
3910 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3911 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3912 (adjust_after_replace_noundo): Remove; unused.
3913 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3914 (signal_before_change): Remove decls.
77382fcc 3915
9306c32e
PE
3916 * indent.c (val_compute_motion, val_vmotion): Now static.
3917
cd44d2eb
PE
3918 * image.c: Make symbols static if they're not exported.
3919 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3920 if USE_GTK.
3921 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3922 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3923
ad9a7a06
PE
3924 * fringe.c (standard_bitmaps): Now static.
3925 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3926
81626931
PE
3927 * frame.c: Make symbols static if they're not exported.
3928 (x_report_frame_params, make_terminal_frame): Now static.
3929 (get_frame_param): Now static, unless HAVE_NS.
3930 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3931 (x_get_resource_string): Remove; not used.
3932 * frame.h (make_terminal_frame, x_report_frame_params):
3933 (x_get_resource_string); Remove decls.
3934 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3935 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3936
239f9db9
PE
3937 * font.c, fontset.c: Make symbols static if they're not exported.
3938 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3939 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3940 * font.c (font_close_object): Now static.
3941 * font.h (font_close_object): Remove.
3942 * fontset.c (FONTSET_OBJLIST): Remove.
3943 (free_realized_fontset) #if-0 the body, which does nothing.
3944 (face_suitable_for_char_p): #if-0, as it's never called.
3945 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3946 * xfaces.c (face_at_string_position):
3947 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3948 since 0 is always ASCII.
3949
dfcf3579
PE
3950 * fns.c (weak_hash_tables): Now static.
3951
5045092b
PE
3952 * fileio.c: Make symbols static if they're not exported.
3953 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3954 (Vwrite_region_annotation_buffers): Now static.
3955
57a96f5c
PE
3956 * eval.c: Make symbols static if they're not exported.
3957 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3958 * lisp.h (backtrace_list): Remove decl.
3959
35f08c38
PE
3960 * emacs.c: Make symbols static if they're not exported.
3961 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3962 (fatal_error_code, fatal_error_signal_hook, standard_args):
3963 Now static.
3964 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3965 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3966 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3967 * lisp.h (fatal_error_signal_hook): Remove decl.
3968 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3969
f44bd759
PE
3970 * editfns.c: Move a (normally-unused) function to its only use.
3971 * editfns.c, lisp.h (get_operating_system_release): Remove.
3972 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3973 worth the hassle of breaking this out.
3974
b532497d
PE
3975 * xterm.c: Make symbols static if they're not exported.
3976 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3977 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3978 (x_destroy_window, x_delete_display):
3979 Now static.
3980 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3981 (x_mouse_leave): Remove; unused.
3982 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3983 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3984 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3985 Remove decls.
3986 (x_mouse_leave): Declare only if WINDOWSNT.
3987 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3988 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3989 USE_X_TOOLKIT.
3990
1675728f
PE
3991 * ftxfont.c: Make symbols static if they're not exported.
3992 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3993 HAVE_FREETYPE.
3994 * font.h (ftxfont_driver): Likewise.
3995
e4cebfca
PE
3996 * xfns.c: Make symbols static if they're not exported.
3997 (x_last_font_name, x_display_info_for_name):
3998 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3999 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4000 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4001 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4002 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4003 (last_show_tip_args): Now static.
4004 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4005 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4006 (x_screen_planes): Remove; unused.
4007 * dispextern.h (x_screen_planes): Remove decl.
4008
5bf46f05
PE
4009 * dispnew.c: Make symbols static if they're not exported.
4010 * dispextern.h (redraw_garbaged_frames, scrolling):
4011 (increment_row_positions): Remove.
4012 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4013 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4014 Now static.
4015 (redraw_garbaged_frames): Remove; unused.
4016
435f4c28
PE
4017 * xfaces.c: Make symbols static if they're not exported.
4018 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4019 Remove decls.
4020 * xterm.h (defined_color): Remove decls.
4021 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4022 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4023 (menu_face_changed_default, defined_color, free_realized_face):
4024 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4025 (ascii_face_of_lisp_face): Remove; unused.
4026
8524aef3
PE
4027 * xdisp.c: Make symbols static if they're not exported.
4028 * dispextern.h (scratch_glyph_row, window_box_edges):
4029 (glyph_to_pixel_coords, set_cursor_from_row):
4030 (get_next_display_element, set_iterator_to_next):
4031 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4032 (show_mouse_face): Remove decls
4033 * frame.h (message_buf_print): Likewise.
4034 * lisp.h (pop_message, set_message, check_point_in_composition):
4035 Likewise.
4036 * xterm.h (set_vertical_scroll_bar): Likewise.
4037 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4038 (message_buf_print, scratch_glyph_row, displayed_buffer):
4039 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4040 (get_next_display_element, show_mouse_face, window_box_edges):
4041 (frame_to_window_pixel_xy, check_point_in_composition):
4042 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4043 (glyph_to_pixel_coords): Remove; unused.
4044
16390cd2
PE
4045 * dired.c (file_name_completion): Now static.
4046
4047 * dbusbind.c (xd_in_read_queued_messages): Now static.
4048
a25f4dfa
PE
4049 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4050 * data.c (circular_list_error): Remove.
4051
14a9c8df
PE
4052 * commands.h (last_point_position, last_point_position_buffer):
4053 (last_point_position_window): Remove decls.
4054 * keyboard.c: Make these variables static.
4055
04f2d78b
CB
4056 * coding.h (coding, code_convert_region, encode_coding_gap):
4057 Remove decls.
74ab6df5
PE
4058 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4059 (iso_code_class, detect_coding, code_convert_region): Now static.
4060 (encode_coding_gap): Remove; unused.
4061
38dfbee1
PE
4062 * chartab.c (chartab_chars, chartab_bits): Now static.
4063
a2cb4e63
PE
4064 * charset.h (charset_iso_8859_1): Remove decl.
4065 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4066 Now static.
4067
127198fd
PE
4068 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4069 * ccl.c (Vccl_program_table): Now static.
4070 (check_ccl_update): Remove; unused.
4071
d85b608f
PE
4072 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4073 * category.h: ... from here.
4074 * category.c (check_category_table, set_category_set): Now static.
4075
31cd66f3
PE
4076 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4077 * lisp.h: Remove these decls.
4078
c358e587
PE
4079 * buffer.c (buffer_count): Remove unused var.
4080
e78aecca
PE
4081 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4082 so that it's not optimized away.
4083 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4084 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4085 exported only to the debugger.
4086
e192d7d3 4087 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4088 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4089
92470028
PE
4090 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4091 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4092 was inaccessible from Lisp.
4093 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4094 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4095
244ed907
PE
4096 alloc.c: Import and export fewer symbols, and remove unused items.
4097 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4098 is defined.
4099 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4100 it's not optimized away by whole-program optimization.
4101 (message_enable_multibyte, free_misc): Remove.
4102 (catchlist, handlerlist, mark_backtrace):
4103 Declare only if BYTE_MARK_STACK.
4104 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4105 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4106 (message_enable_multibyte): Remove decl.
4107 (free_misc, interval_free_list, float_block, float_block_index):
4108 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4109 (cons_free_list, last_marked_index):
4110 Now static.
4111 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4112 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4113 (mark_backtrace): Define only if BYTE_MARK_STACK.
4114 * xdisp.c (message_enable_multibyte): Now static.
4115
61c2b50e 4116 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4117 This makes it easier for human readers (and static analyzers)
4118 to see whether these variables are used from other modules.
4119 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4120 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4121 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4122 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4123 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4124 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4125 * xmenu.c, xselect.c:
4126 Declare Q* vars static if they are not used in other modules.
4127 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4128 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4129 Remove decls of unexported vars.
4130 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4131
95c82688
PE
4132 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4133
16a97296
PE
4134 Make Emacs functions such as Fatom 'static' by default.
4135 This makes it easier for human readers (and static analyzers)
4136 to see whether these functions can be called from other modules.
4137 DEFUN now defines a static function. To make the function external
4138 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4139 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4140 (Finit_image_library):
16a97296
PE
4141 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4142 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4143 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4144 Remove decls, since these functions are now static.
4145 (Funintern, Fget_internal_run_time): New decls, since these functions
4146 were already external.
95c82688 4147
16a97296
PE
4148 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4149 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4150 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4151 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4152 * keyboard.c, keymap.c, lread.c:
4153 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4154 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4155 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4156 Mark functions with DEFUE instead of DEFUN,
4157 if they are used in other modules.
4158 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4159 decls for now-static functions.
4160 * buffer.h (Fdelete_overlay): Remove decl.
4161 * callproc.c (Fgetenv_internal): Mark as internal.
4162 * composite.c (Fremove_list_of_text_properties): Remove decl.
4163 (Fcomposition_get_gstring): New forward static decl.
4164 * composite.h (Fcomposite_get_gstring): Remove decl.
4165 * dired.c (Ffile_attributes): New forward static decl.
4166 * doc.c (Fdocumntation_property): New forward static decl.
4167 * eval.c (Ffetch_bytecode): New forward static decl.
4168 (Funintern): Remove extern decl; now in .h file where it belongs.
4169 * fileio.c (Fmake_symbolic_link): New forward static decl.
4170 * image.c (Finit_image_library): New forward static decl.
4171 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4172 * intervals.h (Fprevious_property_change):
4173 (Fremove_list_of_text_properties): Remove decls.
4174 * keyboard.c (Fthis_command_keys): Remove decl.
4175 (Fcommand_execute): New forward static decl.
4176 * keymap.c (Flookup_key): New forward static decl.
4177 (Fcopy_keymap): Now static.
4178 * keymap.h (Flookup_key): Remove decl.
4179 * process.c (Fget_process): New forward static decl.
4180 (Fprocess_datagram_address): Mark as internal.
4181 * syntax.c (Fsyntax_table_p): New forward static decl.
4182 (skip_chars): Remove duplicate decl.
4183 * textprop.c (Fprevious_property_change): New forward static decl.
4184 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4185 Now internal.
4186 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4187 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4188
785bbd42
PE
4189 * editfns.c (Fformat): Remove unreachable code.
4190
8b913b57
AS
41912011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4192
4193 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4194 change. (Bug#8496)
4195
a6744a35
EZ
41962011-04-13 Eli Zaretskii <eliz@gnu.org>
4197
4198 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4199 when at ZV. (Bug#8487)
4200
e7974947
AS
42012011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4202
baad03f0
AS
4203 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4204 (Bug#8437)
4205 * keyboard.c (parse_tool_bar_item): Likewise.
4206 * sound.c (sound_cleanup, alsa_close): Likewise.
4207 * termcap.c (tgetent): Likewise.
4208 * xfns.c (x_default_font_parameter): Likewise.
4209 * xsettings.c (read_and_apply_settings): Likewise.
4210
e7974947
AS
4211 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4212 (overrun_check_free): Protoize.
4213
28272684
PE
42142011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4215
4216 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4217 since callers should never pass a negative size.
4218 Change the signature to match that of plain 'read' and 'write'; see
4219 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4220 * lisp.h: Update prototypes of emacs_write and emacs_read.
4221
11997c76
EZ
42222011-04-11 Eli Zaretskii <eliz@gnu.org>
4223
4224 * xdisp.c (redisplay_window): Don't try to determine the character
4225 position of the scroll margin if the window start point w->startp
e896f03c 4226 is outside the buffer's accessible region. (Bug#8468)
11997c76 4227
8a2cbd72
EZ
42282011-04-10 Eli Zaretskii <eliz@gnu.org>
4229
4230 Fix write-region and its subroutines for buffers > 2GB.
4231 * fileio.c (a_write, e_write): Modify declaration of arguments and
4232 local variables to support buffers larger than 2GB.
4233 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4234
4235 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4236 argument, local variables, and return value.
4237
4238 * lisp.h: Update prototypes of emacs_write and emacs_read.
4239
4240 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4241
4073e537 42422011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4243
1ebfdcb6
PE
4244 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4245
b2ded58d
PE
4246 Fix more problems found by GCC 4.6.0's static checks.
4247
7d66342c
PE
4248 * xdisp.c (vmessage): Use a better test for character truncation.
4249
bbf47d44
PE
4250 * charset.c (load_charset_map): <, not <=, for optimization,
4251 and to avoid potential problems with integer overflow.
9248994d 4252 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4253 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4254 * editfns.c (Fformat): Likewise.
1e69125e 4255 * syntax.c (skip_chars): Likewise.
3befa583 4256
e3019616
PE
4257 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4258 This also lets GCC 4.6.0 generate slightly better loop code.
4259
becfa255
PE
4260 * callint.c (Fcall_interactively): <, not <=, for optimization.
4261 (Fcall_interactively): Count the number of arguments produced,
4262 not the number of arguments given. This is simpler and lets GCC
4263 4.6.0 generate slightly better code.
4264
dae0cd48
PE
4265 * ftfont.c: Distingish more carefully between FcChar8 and char.
4266 The previous code passed unsigned char * to a functions like
4267 strlen and xstrcasecmp that expect char *, which does not
4268 conform to the C standard.
4269 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4270 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4271 char * when the C standard requires it.
4272
76032d70
PE
4273 * keyboard.c (read_char): Remove unused var.
4274
eb3f1cc8
PE
4275 * eval.c: Port to Windows vsnprintf (Bug#8435).
4276 Include <limits.h>.
4277 (SIZE_MAX): Define if the headers do not.
4278 (verror): Do not give up if vsnprintf returns a negative count.
4279 Instead, grow the buffer. This ports to Windows vsnprintf, which
4280 does not conform to C99. Problem reported by Eli Zaretskii.
4281 Also, simplify the allocation scheme, by avoiding the need for
4282 calling realloc, and removing the ALLOCATED variable.
4283
70476b54
PE
4284 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4285
12020a9e
PE
4286 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4287 But keep the doprint source code for now, as we might revamp it
4288 and use it again (Bug#8435).
ea6c7ae6
PE
4289 * lisp.h (doprnt): Remove.
4290 * Makefile.in (base_obj): Remove doprnt.o.
4291 * deps.mk (doprnt.o): Remove.
4292
5fdb398c
PE
4293 error: Print 32- and 64-bit integers portably (Bug#8435).
4294 Without this change, on typical 64-bit hosts error ("...%d...", N)
4295 was used to print both 32- and 64-bit integers N, which relied on
4296 undefined behavior.
4297 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4298 New macro.
4299 * lisp.h (error, verror): Mark as printf-like functions.
4300 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4301 Report overflow in size calculations when allocating printf buffer.
4302 Do not truncate output string at its first null byte.
4303 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4304 Truncate the output at a character boundary, since vsnprintf does not
4305 do that.
4306 * charset.c (check_iso_charset_parameter): Convert internal
4307 character to string before calling 'error', since %c now has the
4308 printf meaning.
4309 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4310 overflow when computing char to be passed to 'error'. Do not
4311 pass Lisp_Object to 'error'; pass the integer instead.
4312 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4313 formatted with plain %d.
4314
b189fa66
PE
4315 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4316
bff87ef0
PE
4317 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4318
7e2cac20
PE
4319 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4320
ce4d90b5
PE
4321 * xterm.c (x_catch_errors): Remove duplicate declaration.
4322
266c9547
PE
4323 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4324
79c49ad2
PE
4325 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4326
368f4090
JM
43272011-04-10 Jim Meyering <meyering@redhat.com>
4328
4329 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4330 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4331 return ssize_t not "int", and use size_t as the buffer length.
4332 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4333 * gnutls.h: Update declarations.
4334 * process.c (read_process_output): Use ssize_t, to match.
4335 (send_process): Likewise.
4336
a32d4040
CY
43372011-04-09 Chong Yidong <cyd@stupidchicken.com>
4338
4339 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4340
8546720e 43412011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4342
04f2d78b
CB
4343 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4344 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4345
8546720e
GM
4346 * xterm.c (handle_one_xevent):
4347 * xmenu.c (create_and_show_popup_menu):
4348 * xselect.c (x_decline_selection_request)
4349 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4350
0a2f5c1a 43512011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4352
4353 Fix some uses of `int' instead of EMACS_INT.
4354 * search.c (string_match_1, fast_string_match)
4355 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4356 (scan_buffer, find_next_newline_no_quit)
4357 (find_before_next_newline, search_command, Freplace_match)
4358 (Fmatch_data): Make some `int' variables be EMACS_INT.
4359
4360 * xdisp.c (display_count_lines): 3rd argument and return value now
4361 EMACS_INT. All callers changed.
4362 (pint2hrstr): Last argument is now EMACS_INT.
4363
4364 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4365 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4366 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4367 (decode_coding_utf_16, decode_coding_emacs_mule)
4368 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4369 (decode_coding_ccl, decode_coding_charset)
4370 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4371 (decode_coding_iso_2022, decode_coding_emacs_mule)
4372 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4373 <char_offset, last_offset>: Declare EMACS_INT.
4374 (encode_coding_utf_8, encode_coding_utf_16)
4375 (encode_coding_emacs_mule, encode_invocation_designation)
4376 (encode_designation_at_bol, encode_coding_iso_2022)
4377 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4378 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4379 Declare EMACS_INT.
4380 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4381 (encode_invocation_designation): Last argument P_NCHARS is now
4382 EMACS_INT.
4383 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4384 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4385
4386 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4387 All users changed.
4388
4389 * ccl.c (Fccl_execute_on_string): Declare some variables
4390 EMACS_INT.
4391
8546720e 43922011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4393
4394 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4395
4e19a977
CS
43962011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4397
4398 * process.c (Fformat_network_address): Doc fix.
4399
87302331
R
44002011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4401
4402 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4403
cbb59342
CY
44042011-04-08 Chong Yidong <cyd@stupidchicken.com>
4405
4406 * keyboard.c (read_char): Call Lisp function help-form-show,
4407 instead of using internal_with_output_to_temp_buffer.
4408 (Qhelp_form_show): New var.
e0d38eeb 4409 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4410
4411 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4412
4413 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4414
e67a13ab
CY
44152011-04-06 Chong Yidong <cyd@stupidchicken.com>
4416
04f2d78b
CB
4417 * process.c (Flist_processes): Remove to Lisp.
4418 (list_processes_1): Delete.
e67a13ab 4419
973f782d
EZ
44202011-04-06 Eli Zaretskii <eliz@gnu.org>
4421
7c106b1e
EZ
4422 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4423
973f782d
EZ
4424 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4425
41cf7d1a 44262011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4427
ca23cc88
PE
4428 Fix more problems found by GCC 4.6.0's static checks.
4429
f390e2d5
PE
4430 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4431
42eea0d0
PE
4432 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4433
b69769da 4434 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4435
f9541e84
PE
4436 * xdisp.c (vmessage): Mark as a printf-like function.
4437
13841b55
PE
4438 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4439
c136c10f
PE
4440 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4441
5e2d4a30
PE
4442 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4443 printf-like functions.
4444 (tiff_load): Add casts to remove these marks before passing them
4445 to system-supplied API.
4446
583f48b9
PE
4447 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4448
b25d760e
PE
4449 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4450 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4451 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4452 directly, rather than having caller test rule sign. This avoids
4453 some unnecessary tests.
4454 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4455 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4456 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4457
bc7b6697 4458 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4459 (xfont_open): Avoid unnecessary tests.
bc7b6697 4460
27ccc379
PE
4461 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4462
dcd5c89a
PE
4463 * composite.h, composite.c (composition_gstring_put_cache):
4464 Use EMACS_INT, not int, for length.
4465
b13a45c6
PE
4466 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4467 breaking out part of COMPOSITION_DECODE_RULE.
4468 (COMPOSITION_DECODE_RULE): Use it.
4469 * composite.c (get_composition_id): Remove unused local vars,
4470 by using the new macro.
4471
1e792e4d
PE
4472 * textprop.c (set_text_properties_1): Change while to do-while,
4473 since the condition is always true at first.
4474
dc6c6455 4475 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4476 (interval_deletion_adjustment): Return unsigned value.
4477 All uses changed.
dc6c6455 4478
aba7731a
PE
4479 * process.c (list_processes_1, create_pty, read_process_output):
4480 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4481 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4482 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4483 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4484 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4485
fdfc4bf3
PE
4486 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4487
fca8fe46 4488 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4489 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4490
06a0259a 4491 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4492 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4493 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4494
e7b9e80f
PE
4495 * print.c (print_error_message): Avoid int overflow.
4496
56201685
PE
4497 * font.c (font_list_entities): Redo for clarity,
4498 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4499
78834453 4500 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4501 (font_score): Avoid potential overflow in diff calculation.
78834453 4502
0bc0b309 4503 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4504 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4505
e610eaca
PE
4506 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4507
b895abce
PE
4508 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4509 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4510 can always succeed if overflow has undefined behavior.
4511
1f1d9321 4512 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4513 (wordify): Omit three unnecessary tests.
1f1d9321 4514
c59478bc
PE
4515 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4516 All callers changed. This avoids the need for an unused var.
4517
79b73827
PE
4518 * casefiddle.c (casify_region): Remove var that is set but not used.
4519
a4db5dfe
PE
4520 * dired.c (file_name_completion): Remove var that is set but not used.
4521
43aae36e
PE
4522 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4523
2a47c44d 4524 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4525 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4526
a37c69bf
PE
4527 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4528 Check for integer overflow on size calculations.
4529
328ab8e7
PE
4530 * buffer.c (Fprevious_overlay_change): Remove var that is set
4531 but not used.
4532
e5a2a5cb
PE
4533 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4534 Remove vars that are set but not used.
8d84a6eb 4535 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4536 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4537
a60e5f68
PE
4538 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4539
f661cb61 4540 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4541 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4542
f0397f5a
PE
4543 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4544 that are set but not used.
4545
8664db06 4546 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4547 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4548
6abdaa4a
PE
4549 * xselect.c (x_get_local_selection, x_handle_property_notify):
4550 Remove vars that are set but not used.
4551
0ce7538d 4552 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4553 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4554
9ae848fc
PE
4555 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4556 Remove var that is set but not used.
0b918413
PE
4557 (scroll_bar_windows_size): Now size_t, not int.
4558 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4559 Check for overflow.
9ae848fc 4560
a5a62657
PE
4561 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4562 (map_tty_color) [!defined MSDOS]: Likewise.
4563
5c5cdd39
PE
4564 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4565
66ebf983
PE
4566 * coding.c: Remove vars that are set but not used.
4567 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4568 All callers changed.
4569 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4570 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4571 (decode_coding_charset): Remove vars that are set but not used.
4572
1be4d761
PE
4573 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4574 that is set but not used.
4575
47553fa8
PE
4576 * print.c (print_object): Remove var that is set but not used.
4577
1f7196bf 4578 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4579 The gnulib version avoids calling malloc in the usual case,
4580 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4581 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4582 * filelock.c (current_lock_owner): Likewise.
4583 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4584 * sysdep.c: Include allocator.h, careadlinkat.h.
4585 (emacs_no_realloc_allocator): New static constant.
4586 (emacs_readlink): New function.
fdb61804
PE
4587 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4588 ../lib/careadlinkat.h.
d1fdcab7 4589
f84c17c7
SM
45902011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4591
4592 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4593 first non-nil return value).
4594
ef3862ad
JD
45952011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4596
4597 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4598 if not defined (Bug#8403).
4599
376a7006
JB
46002011-04-02 Juanma Barranquero <lekktu@gmail.com>
4601
4602 * xdisp.c (display_count_lines): Remove parameter `start',
4603 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4604 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4605 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4606 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4607 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4608 and thereabouts. All callers changed.
4609 (get_per_char_metric): Remove parameter `f', unused since
4610 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4611
6ca3801d
JM
46122011-04-02 Jim Meyering <meyering@redhat.com>
4613
4614 do not dereference NULL upon failed strdup
4615 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4616 (ns_get_family): Likewise.
4617
d8e2b5ba
JB
46182011-04-02 Juanma Barranquero <lekktu@gmail.com>
4619
4620 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4621
8c74fcbd
JD
46222011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4623
4624 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4625 later (Bug#8403).
4626
7200d79c
SM
46272011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4628
03408648 4629 Add lexical binding.
7200d79c 4630
03408648
SM
4631 * window.c (Ftemp_output_buffer_show): New fun.
4632 (Fsave_window_excursion):
4633 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4634
4635 * lread.c (lisp_file_lexically_bound_p): New function.
4636 (Fload): Bind Qlexical_binding.
4637 (readevalloop): Remove `evalfun' arg.
4638 Bind Qinternal_interpreter_environment.
4639 (Feval_buffer): Bind Qlexical_binding.
4640 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4641 Mark as dynamic.
4642 (syms_of_lread): Declare `lexical-binding'.
4643
4644 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4645
4646 * keyboard.c (eval_dyn): New fun.
4647 (menu_item_eval_property): Use it.
ca105506
SM
4648
4649 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4650
03408648
SM
4651 * fns.c (concat, mapcar1): Accept byte-code-functions.
4652
4653 * eval.c (Fsetq): Handle lexical vars.
4654 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4655 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4656 (FletX, Flet): Obey lexical binding.
4657 (Fcommandp): Handle closures.
4658 (Feval): New `lexical' arg.
4659 (eval_sub): New function extracted from Feval. Use it almost
4660 everywhere where Feval was used. Look up vars in lexical env.
4661 Handle closures.
4662 (Ffunctionp): Move from subr.el.
4663 (Ffuncall): Handle closures.
4664 (apply_lambda): Remove `eval_flags'.
4665 (funcall_lambda): Handle closures and new byte-code-functions.
4666 (Fspecial_variable_p): New function.
4667 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4668 but without exporting it to Lisp.
23aba0ea 4669
23aba0ea 4670 * doc.c (Fdocumentation, store_function_docstring):
03408648 4671 * data.c (Finteractive_form): Handle closures.
23aba0ea 4672
03408648
SM
4673 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4674 interactive spec.
ba83908c 4675
04f2d78b
CB
4676 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4677 New byte-codes.
03408648
SM
4678 (exec_byte_code): New function extracted from Fbyte_code to handle new
4679 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4680
03408648 4681 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4682
03408648 4683 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4684
e2abce01
JB
46852011-03-31 Juanma Barranquero <lekktu@gmail.com>
4686
4687 * xdisp.c (redisplay_internal): Fix prototype.
4688
63696a73 46892011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4690
63696a73 4691 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4692 (try_scrolling): Use it when setting scroll_limit.
4693 Limit scrolling to 100 screen lines.
63696a73
EZ
4694 (redisplay_window): Even when falling back on "recentering",
4695 position point in the window according to scroll-conservatively,
4696 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4697
4698 (try_scrolling): When point is above the window, allow searching
4699 as far as scroll_max, or one screenful, to compute vertical
4700 distance from PT to the scroll margin position. This prevents
4701 try_scrolling from unnecessarily failing when
4702 scroll-conservatively is set to a value slightly larger than the
4703 window height. Clean up the case of PT below the margin at bottom
4704 of window: scroll_max can no longer be INT_MAX. When aggressive
4705 scrolling is in use, don't let point enter the opposite scroll
4706 margin as result of the scroll.
4707 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4708 threshold of 100 lines for never-recentering scrolling.
4709
e4cc2dfc
JB
47102011-03-31 Juanma Barranquero <lekktu@gmail.com>
4711
4712 * dispextern.h (move_it_by_lines):
4713 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4714 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4715 (message_log_check_duplicate): Remove parameters `prev_bol' and
4716 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4717 (redisplay_internal): Remove parameter `preserve_echo_area',
4718 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4719
4720 * indent.c (Fvertical_motion):
4721 * window.c (window_scroll_pixel_based, Frecenter):
4722 Don't pass `need_y_p' to `move_it_by_lines'.
4723
1c470562
SM
47242011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4725
44f230aa
SM
4726 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4727 steal a few bits to be more compact.
4728 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4729 Remove unneeded casts.
4730
1c470562
SM
4731 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4732
888adce9
ZK
47332011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4734
4735 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4736 binding" message (bug#7967).
4737
f838ed7b
PE
47382011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4739
77861b95
PE
4740 Fix more problems found by GCC 4.6.0's static checks.
4741
de6dbc14
PE
4742 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4743 Remove unused local var.
4744
f838ed7b
PE
4745 * editfns.c (Fmessage_box): Remove unused local var.
4746
792c7b2b
PE
4747 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4748 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4749 Omit unused local vars.
c499e557 4750 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4751 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4752 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4753 Omit unused local var.
4754
ba0165e1
PE
4755 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4756 Don't assume string length fits in int.
32ad8845 4757 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4758 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4759
3c59b4c9
PE
4760 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4761 instead of alloca (Bug#8344).
4762
a3eed478 4763 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4764 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4765
eb4d412d
PE
4766 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4767
1658b401
PE
4768 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4769 concerns.
4770
4771 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4772
4773 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4774
9a2c6e05
PE
4775 * keyboard.c (syms_of_keyboard): Use the same style as later
4776 in this function when indexing through an array. This also
4777 works around GCC bug 48267.
4778
03d0a109
PE
4779 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4780
44f730c8
PE
4781 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4782
fe75f926
PE
4783 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4784 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4785
ffa8c828
PE
4786 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4787 This avoids undefined behavior on integer overflow, and is a bit
4788 more convenient anyway since it is compared to a size_t variable.
4789
c5101a77
PE
4790 Variadic C functions now count arguments with size_t, not int.
4791 This avoids an unnecessary limitation on 64-bit machines, which
4792 caused (substring ...) to crash on large vectors (Bug#8344).
4793 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4794 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4795 All variadic functions and their callers changed accordingly.
c5101a77
PE
4796 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4797 * data.c (arith_driver, float_arith_driver): Likewise.
4798 * editfns.c (general_insert_function): Likewise.
4799 * eval.c (struct backtrace.nargs, interactive_p)
4800 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4801 (funcall_lambda, mark_backtrace): Likewise.
4802 * fns.c (concat): Likewise.
4803 * frame.c (x_set_frame_parameters): Likewise.
4804 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4805 0 if not found, not -1. All callers changed.
4806
dd3f25f7
PE
4807 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4808 (stack_copy_size): Now size_t, not int.
4809 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4810
461c2ab9
JB
48112011-03-28 Juanma Barranquero <lekktu@gmail.com>
4812
4813 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4814 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4815 All callers changed.
4816
4817 * lisp.h (multibyte_char_to_unibyte):
4818 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4819 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4820 * character.h (CHAR_TO_BYTE8):
4821 * cmds.c (internal_self_insert):
4822 * editfns.c (general_insert_function):
4823 * keymap.c (push_key_description):
4824 * search.c (Freplace_match):
4825 * xdisp.c (message_dolog, set_message_1): All callers changed.
4826
f6d62986
SM
48272011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4828
4829 * keyboard.c (safe_run_hook_funcall): New function.
4830 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4831 don't set the hook to nil, but remove the offending function instead.
4832 (Qcommand_hook_internal): Remove, unused.
4833 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4834 Vcommand_hook_internal.
4835
4836 * eval.c (enum run_hooks_condition): Remove.
4837 (funcall_nil, funcall_not): New functions.
4838 (run_hook_with_args): Call each function through a `funcall' argument.
4839 Remove `cond' argument, now redundant.
4840 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4841 (Frun_hook_with_args_until_failure): Adjust accordingly.
4842 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4843
1db5b1ad
JB
48442011-03-28 Juanma Barranquero <lekktu@gmail.com>
4845
4846 * dispextern.h (string_buffer_position): Remove declaration.
4847
4848 * print.c (strout): Remove parameter `multibyte', unused since
4849 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4850
4851 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4852 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4853 All callers changed.
4854
4855 * w32.c (_wsa_errlist): Use braces for struct initializers.
4856
4857 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4858 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4859 All callers changed.
4860 (string_buffer_position): Likewise. Also, make static (it's never
4861 used outside xdisp.c).
4862 (cursor_row_p): Remove parameter `w', unused since
4863 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4864 (decode_mode_spec): Remove parameter `precision', introduced during
4865 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4866 All callers changed.
4867
5ffb62aa
JD
48682011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4869
4870 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4871
461c2ab9 48722011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4873
4874 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4875 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4876 (ns_update_auto_hide_menu_bar): New functions.
4877 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4878 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4879 ns_constrain_all_frames.
4880 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4881 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4882
5c380ffb
JD
48832011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4884
4885 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4886
9af30bdf
GM
48872011-03-27 Glenn Morris <rgm@gnu.org>
4888
4889 * syssignal.h: Replace RETSIGTYPE with void.
4890 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4891 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4892 Replace SIGTYPE with void everywhere.
4893 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4894 * s/template.h (SIGTYPE): Remove commented out definition.
4895
e2abce01
JB
48962011-03-26 Eli Zaretskii <eliz@gnu.org>
4897
4898 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4899 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4900
f868cd8a
JB
49012011-03-26 Juanma Barranquero <lekktu@gmail.com>
4902
59eb0929
JB
4903 * w32.c (read_unc_volume): Use parameter `henum', instead of
4904 global variable `wget_enum_handle'.
4905
4906 * keymap.c (describe_vector): Remove parameters `indices' and
4907 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4908 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4909
f868cd8a
JB
4910 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4911
4912 * keyboard.c (timer_check): Remove parameter `do_it_now',
4913 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4914 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4915 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4916
4917 * keyboard.c (read_char):
4918 * w32menu.c (w32_menu_display_help):
4919 * xmenu.c (show_help_event, menu_help_callback):
4920 Adjust calls to `show_help_echo'.
4921
4922 * gtkutil.c (xg_maybe_add_timer):
4923 * keyboard.c (readable_events):
4924 * process.c (wait_reading_process_output):
4925 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4926
4927 * insdel.c (adjust_markers_gap_motion):
4928 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4929 (gap_left, gap_right): Don't call it.
4930
2ecf6fdb
CY
49312011-03-25 Chong Yidong <cyd@stupidchicken.com>
4932
4933 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4934 incurred during fontification.
4935
6b1f9ba4
JB
49362011-03-25 Juanma Barranquero <lekktu@gmail.com>
4937
4938 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4939 (DEFVAR_PER_BUFFER): Don't pass it.
4940
4941 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4942 (scrolling_window): Don't pass it.
4943
0f4a96b5
JB
49442011-03-25 Juanma Barranquero <lekktu@gmail.com>
4945
4946 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4947
4948 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4949 and `suffix'.
4950 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4951 of variables specific to SELinux and computation of `encoded_absname'.
4952
4953 * image.c (XPutPixel): Remove unused variable `height'.
4954
4955 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4956
4957 * unexw32.c (get_section_info): Remove unused variable `section'.
4958
4959 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4960 (system_process_attributes): Remove unused variable `sess'.
4961 (sys_read): Remove unused variable `err'.
4962
4963 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4964 (w32_wnd_proc): Remove unused variable `isdead'.
4965 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4966 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4967 (x_create_tip_frame): Remove unused variable `tem'.
4968
4969 * w32inevt.c (w32_console_read_socket):
4970 Remove unused variable `no_events'.
4971
4972 * w32term.c (x_draw_composite_glyph_string_foreground):
4973 Remove unused variable `width'.
4974
1149507c
JB
49752011-03-24 Juanma Barranquero <lekktu@gmail.com>
4976
4977 * w32term.c (x_set_glyph_string_clipping):
4978 Don't pass uninitialized region to CombineRgn.
4979
9c88f339
JB
49802011-03-23 Juanma Barranquero <lekktu@gmail.com>
4981
4982 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4983 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4984 (Fx_close_connection): Remove unused variable `i'.
4985
4986 * w32font.c (w32font_draw): Return number of glyphs.
4987 (w32font_open_internal): Remove unused variable `i'.
4988 (w32font_driver): Add missing initializer.
4989
4990 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4991 (fill_in_menu): Remove unused variable `items_added'.
4992
4993 * w32term.c (last_mouse_press_frame): Remove static global variable.
4994 (w32_clip_to_row): Remove unused variable `f'.
4995 (x_delete_terminal): Remove unused variable `i'.
4996
4997 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4998 (NOTHING): Remove unused static global variable.
4999 (uniscribe_check_otf): Remove unused variable `table'.
5000 (uniscribe_font_driver): Add missing initializers.
5001
dee091a3
JD
50022011-03-23 Julien Danjou <julien@danjou.info>
5003
5004 * term.c (Fsuspend_tty, Fresume_tty):
5005 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5006 * window.c (temp_output_buffer_show):
5007 * insdel.c (signal_before_change):
5008 * frame.c (Fhandle_switch_frame):
5009 * fileio.c (Fdo_auto_save):
5010 * emacs.c (Fkill_emacs):
5011 * editfns.c (save_excursion_restore):
5012 * cmds.c (internal_self_insert):
5013 * callint.c (Fcall_interactively):
5014 * buffer.c (Fkill_all_local_variables):
5015 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5016 Use Frun_hooks.
0f4a96b5 5017 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5018 unconditionnaly since it does the check itself.
5019
2c520ab5 50202011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5021
c9c49752
PE
5022 Fix more problems found by GCC 4.5.2's static checks.
5023
8abc3f12
PE
5024 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5025 the first time through the loop, since we know p0 < p1 then.
5026 This also avoids a gcc -Wstrict-overflow warning.
5027
a2d26660
PE
5028 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5029 leading to a memory leak, possible in functions like
5030 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5031 of objects (Bug#8318).
a2d26660 5032
916c72e9
PE
5033 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5034 that could (at least in theory) be that large.
5035
19ab8a18
PE
5036 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5037 This is less likely to overflow, and avoids undefined behavior if
5038 overflow does occur. All callers changed. Use strtoul to scan
5039 for the unsigned long integer.
b7cbbd6f
PE
5040 (pint2hrstr): Simplify and tune code slightly.
5041 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5042
f0641eff
PE
5043 * scroll.c (do_scrolling): Work around GCC bug 48228.
5044 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5045
7f650bb9
PE
5046 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5047 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5048 (validate_x_resource_name): Simplify count usage.
5049 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5050
37dd57d1
PE
5051 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5052 fail (Bug#8306).
81e56e61 5053
699979fc 5054 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5055
401bf9b4
PE
5056 * process.c (Fmake_network_process): Use socklen_t, not int,
5057 where POSIX says socklen_t is required in portable programs.
5058 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5059 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5060 (Fmake_network_process, server_accept_connection):
5061 (wait_reading_process_output, read_process_output):
5062 Likewise.
5063
b93aacde
PE
5064 * process.c: Rename or move locals to avoid shadowing.
5065 (list_processes_1, Fmake_network_process):
5066 (read_process_output_error_handler, exec_sentinel_error_handler):
5067 Rename or move locals.
4dc343ee 5068 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5069 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5070 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5071 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5072 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5073
af8a867c 5074 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5075 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5076 Include tparam.h instead, since it declares them.
af8a867c
PE
5077 * cm.h (PC): Remove extern decl; tparam.h now does this.
5078 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5079 * terminfo.c: Include tparam.h, to check interfaces.
5080 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5081 (tparam): Adjust signature to match interface in tparam.h;
5082 this removes some undefined behavior. Check that outstring and len
5083 are zero, which they always are with Emacs.
5084 * tparam.h (PC, BC, UP): New extern decls.
5085
0248044d 5086 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5087 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5088
8ff096c1 5089 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5090 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5091 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5092 (ftfont_list): Remove unused local.
49eaafba
PE
5093 (get_adstyle_property, ftfont_pattern_entity):
5094 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5095 Rename locals to avoid shadowing.
8ff096c1 5096
e2be39f6
PE
5097 * xfont.c (xfont_list_family): Mark var as initialized.
5098
c9735e30
PE
5099 * xml.c (make_dom): Now static.
5100
8f5201ae
PE
5101 * composite.c (composition_compute_stop_pos): Rename local to
5102 avoid shadowing.
b246f932
PE
5103 (composition_reseat_it): Remove unused locals.
5104 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5105 (composition_update_it): Mark var as initialized.
11b61122
PE
5106 (find_automatic_composition): Mark vars as initialized,
5107 with a FIXME (Bug#8290).
8f5201ae 5108
760fbc2c
PE
5109 character.h: Rename locals to avoid shadowing.
5110 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5111 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5112 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5113 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5114 to avoid shadowing.
5115
ff08eb85
PE
5116 * textprop.c (property_change_between_p): Remove; unused.
5117
fc7bf025
PE
5118 * intervals.c (interval_start_pos): Now static.
5119
235d7abc
PE
5120 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5121
44f230aa
SM
5122 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5123 Rename locals to avoid shadowing.
3e7d6594 5124
50060332
PE
5125 * sound.c (wav_play, au_play, Fplay_sound_internal):
5126 Fix pointer signedness.
d01f234b 5127 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5128 (wav_play): Initialize a variable to 0, to prevent undefined
5129 behavior (Bug#8278).
50060332 5130
c4fc4e30
PE
5131 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5132
918436ed
PE
5133 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5134
c939f91b
PE
5135 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5136 clobbering (Bug#8298).
b9c7f648
PE
5137 * sysdep.c (sys_subshell): Likewise.
5138 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5139
6bd8c144
PE
5140 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5141 This should get cleaned up, so that child_setup has the
5142 same signature on all platforms.
5143
7710357c 5144 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5145 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5146
c59da222
CY
51472011-03-22 Chong Yidong <cyd@stupidchicken.com>
5148
5149 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5150 not to be necessary, and produces flickering.
5151
66b87493
GM
51522011-03-20 Glenn Morris <rgm@gnu.org>
5153
5154 * config.in: Remove file.
5155
45b6f6d5
JB
51562011-03-20 Juanma Barranquero <lekktu@gmail.com>
5157
5158 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5159 are now in src/globals.h.
5160 (syms_of_minibuf): Remove spurious & from previous change.
5161
3ec03f7e
LL
51622011-03-20 Leo <sdl.web@gmail.com>
5163
5164 * minibuf.c (completing-read-function): New variable.
5165 (completing-read-default): Rename from completing-read.
5166 (completing-read): Call completing-read-function.
5167
b14e3e21
CY
51682011-03-19 Juanma Barranquero <lekktu@gmail.com>
5169
5170 * xfaces.c (Fx_load_color_file):
5171 Read color file from absolute filename (bug#8250).
5172
f2b726e6
JB
51732011-03-19 Juanma Barranquero <lekktu@gmail.com>
5174
5175 * makefile.w32-in: Update dependencies.
5176
09f6ff02
EZ
51772011-03-17 Eli Zaretskii <eliz@gnu.org>
5178
5179 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5180
29a6015a
PE
51812011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5182
a3a6c54e
PE
5183 Fix more problems found by GCC 4.5.2's static checks.
5184
b766f867
PE
5185 * process.c (make_serial_process_unwind, send_process_trap):
5186 (sigchld_handler): Now static.
5187
be02381c
PE
5188 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5189 That way, the code declares only the vars that it needs.
5190 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5191 * s/cygwin.h (PTY_ITERATION): Likewise.
5192 * s/darwin.h (PTY_ITERATION): Likewise.
5193 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5194
57048744
PE
5195 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5196 * process.c (allocate_pty): Don't declare stb unless it's needed.
5197
7914961c 5198 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5199 (CONSTANTLIM): Remove; unused.
5200 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5201 Define only if needed.
7914961c 5202
b3967b18
PE
5203 * unexelf.c (unexec): Name an expression,
5204 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5205 Use a different way to cause a compilation error if anyone uses
5206 n rather than nn, a way that does not involve shadowing.
73366a00 5207 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5208
29a6015a
PE
5209 * deps.mk (unexalpha.o): Remove; unused.
5210
43cfc33e 5211 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5212 * unexec.h: New file.
ce701a33
PE
5213 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5214 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5215 Depend on unexec.h.
5216 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5217 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5218 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5219 Change as necessary to match prototype in unexec.h.
ce701a33 5220
01f44d5a
PE
5221 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5222 shadowing.
4f63c6bb 5223 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5224
a6670b0b
PE
5225 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5226 Rename locals to avoid shadowing.
5227
cef2010d 5228 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5229 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5230
d4d7173a
PE
5231 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5232
f08b802a
PE
5233 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5234 warning when compiling print.c.
5235
3ddb0639
PE
5236 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5237 instead of using an uninitialized var.
5ad03b97 5238 (font_sort_entities): Mark var as initialized.
3ddb0639 5239
170a2692
PE
5240 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5241
e663c700
PE
5242 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5243 pointers to constants.
89bc529a 5244 (font_parse_fcname): Remove unused vars.
7b81e2d0 5245 (font_delete_unmatched): Now static.
ea838e10 5246 (font_get_spec): Remove; unused.
13a547c6
PE
5247 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5248 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5249 Rename or move locals to avoid shadowing.
e663c700 5250
2a80c887 5251 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5252 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5253
1384fa33 5254 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5255 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5256
8b2c52e9
PE
5257 * alloc.c (mark_backtrace): Move decl from here ...
5258 * lisp.h: ... to here, so that it can be checked.
5259
475545b5 5260 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5261 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5262 (lisp_indirect_variable): Name an expression,
5263 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5264 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5265
b1349114 5266 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5267 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5268 Use const pointer when appropriate.
b1349114 5269
a2928364
PE
5270 * lisp.h (get_system_name, get_operating_system_release):
5271 Move decls here, to check interfaces.
5272 * process.c (get_operating_system_release): Move decl to lisp.h.
5273 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5274 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5275 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5276 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5277 (Fformat_time_string, Fencode_time, Finsert_char):
5278 (Ftranslate_region_internal, Fformat):
5279 Rename or remove local vars to avoid shadowing.
9710023e 5280 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5281
a415e694
PE
5282 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5283 avoid shadowing.
5284
8ef4622d
PE
5285 * lisp.h (eassert): Check that the argument compiles, even if
5286 ENABLE_CHECKING is not defined.
5287
946f9a5b
PE
5288 * data.c (Findirect_variable): Name an expression, to avoid
5289 gcc -Wbad-function-cast warning.
112396d6 5290 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5291 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5292 (Fmake_variable_buffer_local, Fmake_local_variable):
5293 Mark variables as initialized.
52746918 5294 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5295
e5aab7e7 5296 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5297 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5298 Rename locals to avoid shadowing.
dff45157
PE
5299 (mark_stack): Move local variables into the #ifdef region where
5300 they're used.
7bc26fdb
PE
5301 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5302 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5303 needed otherwise.
5304 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5305 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5306 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5307
e5aab7e7
PE
5308 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5309 avoids undefined behavior in theory.
5310
4da60324
PE
5311 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5312
88043301
PE
5313 Use functions, not macros, for up- and down-casing (Bug#8254).
5314 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5315 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5316 to use the following functions instead of these macros.
5317 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5318 EMACS_INT, since callers assume the returned value fits in int.
5319 (upcase1): Likewise, for UPCASE_TABLE.
5320 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5321 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5322 the race-condition problem in the old DOWNCASE.
88043301 5323
19ed5445
PE
5324 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5325 Rename locals to avoid shadowing.
5326 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5327 (regex_compile, re_search_2, re_match_2_internal):
5328 Remove unused local vars.
952db0d7
PE
5329 (FREE_VAR): Rewrite so as not to use empty "else",
5330 which gcc can warn about.
da053e48 5331 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5332 (RETALLOC_IF): Define only if needed.
5333 (WORDCHAR_P): Likewise. This one is never needed, but is used
5334 only in a comment talking about a compiler bug, so put inside
5335 the #if 0 of that comment.
5336 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5337 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5338 Remove; unused.
19ed5445 5339
1f3561e4 5340 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5341 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5342 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5343
ded6f8f7
PE
5344 * search.c (simple_search): Remove unused var.
5345
dbd37a95
PE
5346 * dired.c (compile_pattern): Move decl from here ...
5347 * lisp.h: ... to here, so that it can be checked.
5348 (struct re_registers): New forward decl.
5349
7e47afad
PE
5350 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5351
85f24f61
PE
5352 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5353 All uses changed.
5354 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5355 Rename locals to avoid shadowing.
5671df8f 5356 (Fvertical_motion): Mark locals as initialized.
85f24f61 5357
181aa2be 5358 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5359 (casify_region): Mark local as initialized.
181aa2be 5360
930d429c
PE
5361 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5362
7082eac6
PE
5363 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5364 New macros, so that the caller can use some names other than
5365 gcpro1, gcpro2, etc.
5366 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5367 of the new macros.
5368 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5369 argument, for consistency with GCPRO2_VAR, etc: it is now the
5370 prefix of the variable, not the variable itself. All uses
5371 changed.
38b2c076
PE
5372 * dired.c (directory_files_internal, file_name_completion):
5373 Rename locals to avoid shadowing.
5374
15206ed9
PE
5375 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5376 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5377 dired.c's scmp function, had undefined behavior.
5378 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5379 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5380 * buffer.h: ... to here, because these macros use current_buffer,
5381 and the new implementation with inline functions needs to have
5382 current_buffer in scope now, rather than later when the macros
5383 are used.
5384 (downcase, upcase1): New static inline functions.
5385 (DOWNCASE, UPCASE1): Reimplement using these functions.
5386 This avoids undefined behavior in expressions like
5387 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5388 from race conditions in accessing the global variables
5389 case_temp1 and case_temp2.
5390 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5391 * lisp.h (case_temp1, case_temp2): Remove their decls.
5392 * character.h (ASCII_CHAR_P): Move from here ...
5393 * lisp.h: ... to here, so that the inline functions mentioned
5394 above can use them.
5395
4a6bea26
PE
5396 * dired.c (directory_files_internal_unwind): Now static.
5397
f14b7e14
PE
5398 * fileio.c (file_name_as_directory, directory_file_name):
5399 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5400 Now static.
2893f146
PE
5401 (file_name_as_directory): Use const pointers when appropriate.
5402 (Fexpand_file_name): Likewise. In particular, newdir might
5403 point at constant storage, so make it a const pointer.
fd4ead52 5404 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5405 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5406 signedness issues.
f839df0c
PE
5407 (Fset_file_times, Finsert_file_contents, auto_save_error):
5408 Rename locals to avoid shadowing.
f14b7e14 5409
5716756e 5410 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5411 (Ftry_completion, Fall_completions): Rename or remove locals
5412 to avoid shadowing.
5716756e 5413
b4c3046a
PE
5414 * marker.c (bytepos_to_charpos): Remove; unused.
5415
b45db522
PE
5416 * lisp.h (verify_bytepos, count_markers): New decls,
5417 so that gcc does not warn that these functions aren't declared.
5418
85876d07
PE
5419 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5420 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5421 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5422 (copy_text): Remove unused local var.
85876d07 5423
03d78a21 5424 * filelock.c (within_one_second): Now static.
b3dd38ab 5425 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5426
5df8f01b
PE
5427 * buffer.c (fix_overlays_before): Mark locals as initialized.
5428 (fix_start_end_in_overlays): Likewise. This function should be
5429 simplified by using pointers-to-pointers, but that's a different
5430 matter.
b1d876f1 5431 (switch_to_buffer_1): Now static.
8f54f30a
PE
5432 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5433 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5434
a70072c9 5435 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5436 Fix pointer signedness issue.
edced198
PE
5437 (sys_subshell): Mark local as volatile if checking for lint,
5438 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5439 (MAXPATHLEN): Define only if needed.
a70072c9 5440
a0977c44
PE
5441 * process.c (serial_open, serial_configure): Move decls from here ...
5442 * systty.h: ... to here, so that they can be checked.
5443
a884fdcc
PE
5444 * fns.c (get_random, seed_random): Move extern decls from here ...
5445 * lisp.h: ... to here, so that they can be checked.
5446
604efe86 5447 * sysdep.c (reset_io): Now static.
b8950c94 5448 (wait_for_termination_signal): Remove; unused.
604efe86 5449
38fc62d9
PE
5450 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5451 (copy_keymap_item, append_key, push_text_char_description):
5452 Now static.
1004a21a 5453 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5454 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5455 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5456 (describe_map_tree):
5457 Rename locals to avoid shadowing.
38fc62d9 5458
2f2650da
PE
5459 * keyboard.c: Declare functions static if they are not used elsewhere.
5460 (echo_char, echo_dash, cmd_error, top_level_2):
5461 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5462 (read_char, kbd_buffer_get_event, make_lispy_position):
5463 (make_lispy_event, make_lispy_movement, apply_modifiers):
5464 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5465 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5466 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5467 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5468 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5469
a053e86c 5470 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5471 (mark_kboards): Move decl here ...
5472 * alloc.c (mark_kboards): ... from here.
a053e86c 5473
4752793e
PE
5474 * lisp.h (force_auto_save_soon): New decl.
5475
74f10ca7 5476 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5477 (DEFINE_DUMMY_FUNCTION): New macro.
5478 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5479 Use it.
c03cd23f
PE
5480 (main): Add casts to avoid warnings
5481 if GCC considers string literals to be constants.
74f10ca7 5482
022e70d4
PE
5483 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5484
59d6fe83
PE
5485 * dbusbind.c: Pointer signedness fixes.
5486 (xd_signature, xd_append_arg, xd_initialize):
5487 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5488 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5489 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5490 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5491
78320123
PE
5492 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5493 if GCC considers string literals to be constants.
49cebcca 5494 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5495
35ac2a97
SM
54962011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5497
fb103ca9
SM
5498 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5499 (print_preprocess, print_object): New macro to fix last change.
5500
35ac2a97
SM
5501 * print.c (print_preprocess): Don't forget font objects.
5502
62973b41
JB
55032011-03-16 Juanma Barranquero <lekktu@gmail.com>
5504
5505 * emacs.c (USAGE3): Doc fixes.
5506
0e48bb22
AS
55072011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5508
5509 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5510 structure.
5511
7684e57b
JB
55122011-03-14 Juanma Barranquero <lekktu@gmail.com>
5513
5514 * lisp.h (VWindow_system, Qfile_name_history):
5515 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5516 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5517 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5518
5519 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5520 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5521
5522 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5523 * w32console.c (detect_input_pending, read_input_pending)
5524 (encode_terminal_code):
5525 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5526 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5527 (w32_system_caret_y, Qfile_name_history):
5528 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5529 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5530 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5531 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5532 * w32proc.c (Qlocal, report_file_error):
5533 * w32term.c (Vwindow_system, updating_frame):
5534 * w32uniscribe.c (initialized, uniscribe_font_driver):
5535 Remove unneeded extern declarations.
5536
2aa46d6c
CY
55372011-03-14 Chong Yidong <cyd@stupidchicken.com>
5538
c96bbc66 5539 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5540
cffc6f3b
CY
55412011-03-13 Chong Yidong <cyd@stupidchicken.com>
5542
5543 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5544 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5545 These macros can no longer be used for assignment.
5546
44f230aa
SM
5547 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5548 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5549 (record_buffer_markers, fetch_buffer_markers): New functions for
5550 recording and fetching special buffer markers.
5551 (set_buffer_internal_1, set_buffer_temp): Use them.
5552
5553 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5554
5555 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5556
5557 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5558 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5559
5560 * xdisp.c (hscroll_window_tree):
5561 (reconsider_clip_changes): Use PT instead of BUF_PT.
5562
d251f04b
EZ
55632011-03-13 Eli Zaretskii <eliz@gnu.org>
5564
5565 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5566 $(EMACS_ROOT)/lib/intprops.h.
5567
f0c77cd1
PE
55682011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5569
3eca4629
PE
5570 Fix more problems found by GCC 4.5.2's static checks.
5571
7c86ee98
PE
5572 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5573 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5574 (xg_free_frame_widgets): Make it clear that a local variable is
5575 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5576 (gdk_window_get_screen): Make it clear that this macro is needed
5577 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5578 (int_gtk_range_get_value): New function, which avoids a diagnostic
5579 from gcc -Wbad-function-cast.
5580 (xg_set_toolkit_scroll_bar_thumb): Use it.
5581 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5582 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5583 (get_utf8_string, xg_get_file_with_chooser):
5584 Rename locals to avoid shadowing.
5585 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5586
41729b81
PE
5587 * xgselect.c (xg_select): Remove unused var.
5588
f0c77cd1
PE
5589 * image.c (four_corners_best): Mark locals as initialized.
5590 (gif_load): Initialize transparent_p to zero (Bug#8238).
5591 Mark another local as initialized.
ec6cf4c6 5592 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5593
ce0ad53d 5594 * image.c (clear_image_cache): Now static.
d5d5a617 5595 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5596 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5597 (x_edge_detection): Remove unnecessary cast that
5598 gcc -Wbad-function-cast diagnoses.
2037898d 5599 (gif_load): Fix pointer signedness.
6ae141d6
PE
5600 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5601 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5602
33383987 56032011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5604
d32df629
PE
5605 Improve quality of tests for time stamp overflow.
5606 For example, without this patch (encode-time 0 0 0 1 1
5607 1152921504606846976) returns the obviously-bogus value (-948597
5608 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5609 reports time overflow. See
5610 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5611 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5612 * editfns.c: Include limits.h and intprops.h.
5613 (TIME_T_MIN, TIME_T_MAX): New macros.
5614 (time_overflow): Move earlier, to before first use.
5615 (hi_time, lo_time): New functions, for an accurate test for
5616 out-of-range times.
5617 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5618 (Fget_internal_run_time): Don't assume time_t fits in int.
5619 (make_time): Use list2 instead of Fcons twice.
5620 (Fdecode_time): More accurate test for out-of-range times.
5621 (check_tm_member): New function.
5622 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5623 (lisp_time_argument): Don't rely on undefined left-shift and
5624 right-shift behavior when checking for time stamp overflow.
8be6f318 5625
fe31d94c
PE
5626 * editfns.c (time_overflow): New function, refactoring common code.
5627 (Fformat_time_string, Fdecode_time, Fencode_time):
5628 (Fcurrent_time_string): Use it.
5629
8be6f318
PE
5630 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5631 * dired.c (make_time): Move to ...
5632 * editfns.c (make_time): ... here.
5633 * systime.h: Note the move.
5634
09d9db2c 56352011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5636
126bc0dc
YM
5637 * fringe.c (update_window_fringes): Remove unused variables.
5638
c47cbdfd
YM
5639 * unexmacosx.c (copy_data_segment): Also copy __got section.
5640 (Bug#8223)
5641
7ac80be9
EZ
56422011-03-12 Eli Zaretskii <eliz@gnu.org>
5643
c96bbc66 5644 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5645 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5646 Constify `char *' arguments and their references according to
5647 prototypes in tparam.h.
5648
ecb0f94d 5649 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5650
7ac80be9
EZ
5651 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5652 Adapt all references accordingly.
5653
5654 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5655
ef1fd07e
TT
56562011-03-11 Tom Tromey <tromey@redhat.com>
5657
5658 * buffer.c (syms_of_buffer): Remove obsolete comment.
5659
7ef4b50c
EZ
56602011-03-11 Eli Zaretskii <eliz@gnu.org>
5661
5662 * termhooks.h (encode_terminal_code): Declare prototype.
5663
5664 * msdos.c (encode_terminal_code): Don't declare prototype.
5665
5666 * term.c (encode_terminal_code): Now external again, used by
5667 w32console.c and msdos.c.
5668
44f230aa
SM
5669 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5670 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5671
4b1ec863 56722011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5673
1714f52b 5674 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5675
4b1ec863
PE
5676 * fringe.c (update_window_fringes): Mark locals as initialized
5677 (Bug#8227).
5678 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5679
524c7aa6
PE
5680 * alloc.c (mark_fringe_data): Move decl from here ...
5681 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5682 to check its interface.
5683 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5684
a5c0af81 5685 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5686 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5687 (fontset_font): Mark local as initialized.
a9a06e0b 5688 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5689
b4716021
PE
5690 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5691
811e9bac 5692 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5693 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5694 (x_own_selection, Fx_disown_selection_internal): Rename locals
5695 to avoid shadowing.
5696 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5697
7e3ab302
PE
5698 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5699 so that the caller can use some name other than gcpro1.
5700 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5701 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5702 (Fx_backspace_delete_keys_p):
5703 Use them to avoid shadowing, and rename vars to avoid shadowing.
5704 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5705 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5706 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5707 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5708 Remove unused locals.
7e3ab302
PE
5709 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5710 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5711 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5712 macros.
f78faa98 5713
e2b13473
PE
5714 * xterm.h (x_mouse_leave): New decl.
5715
77f23912
PE
5716 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5717 Remove unused functions.
cdf4ba58
PE
5718 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5719 (x_calc_absolute_position): Now static.
7411c686 5720 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5721 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5722 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5723 unless they are used.
38d0b34a
PE
5724 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5725 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5726 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5727 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5728 (x_error_catcher, x_connection_closed, x_error_handler):
5729 (x_error_quitter, xembed_send_message, x_iconify_frame):
5730 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5731 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5732 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5733
44f230aa
SM
5734 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5735 Rename or move locals to avoid shadowing.
6b463e58 5736 (tty_defined_color, merge_face_heights): Now static.
5967d051 5737 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5738 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5739 does not deduce is never used uninitialized.
73719eba
PE
5740 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5741 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5742
426994c3 5743 * terminal.c (store_terminal_param): Now static.
5489860b 5744
032f1620 5745 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5746 (set_frame_menubar): Remove unused local.
d4323972 5747 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5748 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5749 since they might point to immutable storage.
281585b0
PE
5750 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5751 since it's unused otherwise.
032f1620 5752
367c19e5 5753 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5754 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5755 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5756 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5757 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5758 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5759 does not deduce are never used uninitialized.
70739cbe 5760
07b48fa9
PE
5761 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5762
8868a238 5763 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5764 * window.c (window_loop, size_window):
5765 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5766
7e5cf297 5767 * window.c (display_buffer): Now static.
d6550a9f
PE
5768 (size_window): Mark variables that gcc -Wuninitialized
5769 does not deduce are never used uninitialized.
a586633d
PE
5770 * window.h (check_all_windows): New decl, to forestall
5771 gcc -Wmissing-prototypes diagnostic.
5b555da1 5772 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5773
f6095868
PE
5774 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5775 shadowing.
5776 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5777 Include <limits.h>.
5778 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5779 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5780 (load_charset_map): Mark variables that gcc -Wuninitialized
5781 does not deduce are never used uninitialized.
53df7c11 5782 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5783
f38b440c
PE
5784 * coding.c (coding_set_source, coding_set_destination):
5785 Use "else { /* comment */ }" rather than "else /* comment */;"
5786 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5787 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5788 a block, when the outer 'i' will do.
5789 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5790 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5791 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5792 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5793 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5794 Rename locals to avoid shadowing.
5795 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5796 * coding.c (emacs_mule_char, encode_invocation_designation):
5797 Now static, since they're not used elsewhere.
413bb2db 5798 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5799 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5800 (decode_coding_emacs_mule): Mark variables that gcc
5801 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5802 (detect_coding_iso_2022): Initialize a local variable that might
5803 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5804 this initialization is needed. (Bug#8211)
5f58e762
PE
5805 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5806 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5807 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5808 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5809 Remove unused macros.
f38b440c 5810
232b38b9 5811 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5812 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5813 * character.c (string_count_byte8): Likewise.
232b38b9 5814
fb90da1b
PE
5815 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5816 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5817
fb93dbc2
PE
5818 * chartab.c (copy_sub_char_table): Now static, since it's not used
5819 elsewhere.
5c156ace
PE
5820 (sub_char_table_ref_and_range, char_table_ref_and_range):
5821 Rename locals to avoid shadowing.
bbcd0949 5822 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5823
7d3b3862 5824 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5825 (BIDI_BOB): Remove unused macro.
7d3b3862 5826
6be7d3da
PE
5827 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5828 deduce are never used uninitialized.
c2ed9c8b 5829 * term.c (encode_terminal_code): Likewise.
6be7d3da 5830
75f8807f 5831 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5832
50938595
PE
5833 * tparam.h: New file.
5834 * term.c, tparam.h: Include it.
5835 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5836 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5837 Move these decls to tparam.h, and make them agree with what
5838 is actually in tparam.c. The previous trick of using incompatible
5839 decls in different modules does not conform to the C standard.
5840 All callers of tparam changed to use tparam's actual API.
5841 * tparam.c (tparam1, tparam, tgoto):
5842 Use const pointers where appropriate.
5843
fbceeba2
PE
5844 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5845 * cm.h (struct cm): Likewise.
5846 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5847 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5848 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5849 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5850 (turn_on_face, init_tty): Likewise.
5851 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5852
7f3f1250
PE
5853 * term.c (term_mouse_position): Rename local to avoid shadowing.
5854
e6ca6543
PE
5855 * alloc.c (mark_ttys): Move decl from here ...
5856 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5857
c40f8d15
AS
58582011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5859
5860 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5861
cfe0661d
JB
58622011-03-09 Juanma Barranquero <lekktu@gmail.com>
5863
5864 * search.c (compile_pattern_1): Remove argument regp, unused since
5865 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5866 (compile_pattern): Don't pass it.
5867
0afb4571
J
58682011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5869
5870 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5871 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5872 for ! HAVE_GTK3.
5873 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5874
5875 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5876
5877 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5878 gdk_window_get_screen, gdk_window_get_geometry,
5879 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5880 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5881 (xg_get_pixbuf_from_pixmap): New function.
5882 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5883 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5884 Call xg_get_pixbuf_from_pixmap instead of
5885 gdk_pixbuf_get_from_drawable.
5886 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5887 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5888 (xg_check_special_colors): Use GtkStyleContext and its functions
5889 for HAVE_GTK3.
5890 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5891 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5892 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5893 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5894 Call gtk_widget_get_preferred_size.
0afb4571
J
5895 (xg_frame_resized): gdk_window_get_geometry only takes 5
5896 parameters.
44f230aa
SM
5897 (xg_win_to_widget, xg_event_is_for_menubar):
5898 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5899 (xg_set_widget_bg): New function.
5900 (delete_cb): New function.
895009e1 5901 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5902 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5903 (xg_set_background_color): Call xg_set_widget_bg.
5904 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5905 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5906 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5907 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5908 if ! HAVE_GTK3.
5909 (update_frame_tool_bar): Call gtk_widget_hide.
5910 (xg_initialize): Use GDK_KEY_g.
5911
5912 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5913 if ! HAVE_GTK3
5914 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5915
5916 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5917 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5918 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5919
1c2cc4ef
JB
59202011-03-08 Juanma Barranquero <lekktu@gmail.com>
5921
5922 * w32xfns.c (select_palette): Check success of RealizePalette against
5923 GDI_ERROR, not zero.
5924
33383987 5925See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5926
5927;; Local Variables:
5928;; coding: utf-8
aac0c6e3
MR
5929;; End:
5930
33383987 5931 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5932
5933 This file is part of GNU Emacs.
5934
5935 GNU Emacs is free software: you can redistribute it and/or modify
5936 it under the terms of the GNU General Public License as published by
5937 the Free Software Foundation, either version 3 of the License, or
5938 (at your option) any later version.
5939
5940 GNU Emacs is distributed in the hope that it will be useful,
5941 but WITHOUT ANY WARRANTY; without even the implied warranty of
5942 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5943 GNU General Public License for more details.
5944
5945 You should have received a copy of the GNU General Public License
5946 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.