Fix bug #9470 with slow redisplay in huge single-paragraph buffers.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
bb187662
EZ
12011-09-17 Eli Zaretskii <eliz@gnu.org>
2
1137e8b8
EZ
3 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4 about the current paragraph and restore it after the call to
5 reseat.
6
7 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
8 (bidi_find_paragraph_start): Search back for paragraph beginning
9 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
10 (bidi_move_to_visually_next): Only trigger paragraph-related
11 computations when the last character is a newline or at EOB, not
12 just any NEUTRAL_B. (Bug#9470)
13
bb187662
EZ
14 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
15 truncated lines if point is covered by a display string. (Bug#9524)
16
2e621251
PE
172011-09-16 Paul Eggert <eggert@cs.ucla.edu>
18
19 * xselect.c: Relax test for outgoing X longs (Bug#9498).
20 (cons_to_x_long): New function.
21 (lisp_data_to_selection_data): Use it. Correct the test for
22 short-versus-long data; it was negated. Break out of vector
23 loop, for efficiency, when a long datum is discovered.
24
91a15bc6
SM
252011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
26
27 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
28
b41c3a35
EZ
292011-09-16 Eli Zaretskii <eliz@gnu.org>
30
31 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
32 GCC PR/17406) by declaring this function with external scope.
33
7812ba2d
PE
342011-09-15 Paul Eggert <eggert@cs.ucla.edu>
35
36 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
37 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
38
cf7edc2a
AS
392011-09-15 Andreas Schwab <schwab@linux-m68k.org>
40
41 * editfns.c (Fformat): Correctly handle text properties on "%%".
42
bd01620e
EZ
432011-09-15 Eli Zaretskii <eliz@gnu.org>
44
45 * xterm.c (x_draw_composite_glyph_string_foreground):
46 * w32term.c (x_draw_composite_glyph_string_foreground):
47 * term.c (encode_terminal_code):
48 * composite.c (composition_update_it, get_composition_id):
49 * xdisp.c (get_next_display_element)
50 (fill_composite_glyph_string): Add comments about special meaning
51 of TAB characters in a composition.
52
a02719a3
PE
532011-09-15 Paul Eggert <eggert@cs.ucla.edu>
54
55 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
56 This occurs when processing a multibyte format.
57 Problem reported by Wolfgang Jenker.
a02719a3 58
72589a3c
JB
592011-09-15 Johan Bockgård <bojohan@gnu.org>
60
61 * xdisp.c (try_cursor_movement): Only check for exact match if
62 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
63
1c14176c
PE
642011-09-14 Paul Eggert <eggert@cs.ucla.edu>
65
66 Remove unused external symbols.
67 * dispextern.h (calc_pixel_width_or_height): Remove decl.
68 * xdisp.c (calc_pixel_width_or_height): Now static.
69 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
70 * indent.c (check_display_width):
71 * w32term.c: Fix comment to match code.
72 * xterm.c, xterm.h (x_catching_errors): Remove.
73
d2eea5b5
PE
742011-09-14 Paul Eggert <eggert@cs.ucla.edu>
75
76 * xselect.c: Use signed conversions more consistently (Bug#9498).
77 (selection_data_to_lisp_data): Assume incoming selection data are
78 signed integers, not unsigned. This is to be consistent with
79 outgoing selection data, which was modified to use signed integers
80 in as part of the fix to Bug#9196 in response to Jan D.'s comment
81 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
82 expects long, not unsigned long.
83
46888499
EZ
842011-09-14 Eli Zaretskii <eliz@gnu.org>
85
86 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
87 computation of loop end. Reported by Johan Bockgård
88 <bojohan@gnu.org>.
89
ef8ef9fb
CY
902011-09-13 Chong Yidong <cyd@stupidchicken.com>
91
92 * frame.c (Fother_visible_frames_p): Function deleted.
93
fa819fed
EZ
942011-09-12 Eli Zaretskii <eliz@gnu.org>
95
96 * indent.c (compute_motion): Process display vector front to back
97 rather than the other way around. (Bug#2496)
98
2ba8e008
SM
992011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
100
101 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
102
20f53c69
CY
1032011-09-11 Chong Yidong <cyd@stupidchicken.com>
104
105 * minibuf.c (Fread_from_minibuffer): Doc fix.
106
d562d7a4
EZ
1072011-09-11 Eli Zaretskii <eliz@gnu.org>
108
109 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
110 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
111
1c4d7f3d
LMI
1122011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
113
114 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
115 value for non-existent files.
116
b885bf36
EZ
1172011-09-11 Eli Zaretskii <eliz@gnu.org>
118
119 * fileio.c (Finsert_file_contents): If the file cannot be opened,
120 set its "size" to -1. This will set the modtime_size field of
121 the corresponding buffer to -1, which is what
122 verify-visited-file-modtime expects for files that do not exist.
123 (Bug#9139)
124
6612f0bf
PE
1252011-09-11 Paul Eggert <eggert@cs.ucla.edu>
126
127 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
128 here ...
129 * lisp.h: ... from here. push_key_description is no longer
130 defined in keyboard.c, so its declaration should not be in
131 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
132 logically belongs with push_key_description.
133
dfb3f755
PE
1342011-09-10 Paul Eggert <eggert@cs.ucla.edu>
135
136 * buffer.h: Include <sys/types.h> instead of <time.h>.
137 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
138 Problem reported by Herbert J. Skuhra.
139
3134906c
LMI
1402011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
141
142 * xml.c (parse_region): Make the parsing work for
143 non-comment-starting XML files again (bug#9144).
144
8d903f4e
AS
1452011-09-10 Andreas Schwab <schwab@linux-m68k.org>
146
147 * image.c (gif_load): Fix calculation of bottom and right corner.
148 (Bug#9468)
149
80ad64f4
EZ
1502011-09-10 Eli Zaretskii <eliz@gnu.org>
151
152 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
153 redisplay in small windows.
154
208a048d
EZ
1552011-09-09 Eli Zaretskii <eliz@gnu.org>
156
157 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
158
9b1c252e
MR
1592011-09-08 Martin Rudalics <rudalics@gmx.at>
160
161 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
162 Operate on live windows only.
163
2949f33b
JB
1642011-09-08 Juanma Barranquero <lekktu@gmail.com>
165
166 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
167
e08dcafd
EZ
1682011-09-07 Eli Zaretskii <eliz@gnu.org>
169
170 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
171 only under bidi iteration.
172
115b96bd
JD
1732011-09-07 Jan Djärv <jan.h.d@swipnet.se>
174
175 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
176
c8199d0f
PE
1772011-09-06 Paul Eggert <eggert@cs.ucla.edu>
178
179 isnan: Fix porting problem to Solaris 10 with bundled gcc.
180 Without this fix, the command to link temacs failed due to an
181 undefined symbol __builtin_isnan. This is because
182 /usr/include/iso/math_c99.h #defines isnan(x) to
183 __builtin_isnan(x), but the bundled gcc, which identifies itself
184 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
185 a __builtin_isnan.
186 * floatfns.c (isnan): #undef, and then #define to a clone of
187 what's in data.c.
188 (Fisnan): Always define, since it's always available now.
189 (syms_of_floatfns): Always define isnan at the Lisp level.
190
e39b275c 1912011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
192
193 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
194
b2db44d9 1952011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 196
f4af5137 197 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
198 The previous code assumed that file offsets (off_t values) fit in
199 EMACS_INT variables, which is not true on typical 32-bit hosts.
200 The code messed up by falsely reporting buffer overflow in cases
201 such as (insert-file-contents "big" nil 1 2) into an empty buffer
202 when "big" contains more than 2**29 bytes, even though this
203 inserts just one byte and does not overflow the buffer.
204 (Finsert_file_contents): Store file offsets as off_t
205 values, not as EMACS_INT values. Check for overflow when
206 converting between EMACS_INT and off_t. When checking for
207 buffer overflow or for overlap, take the offsets into account.
208 Don't use EMACS_INT for small values where int suffices.
209 When checking for overlap, fix a typo: ZV was used where
210 ZV_BYTE was intended.
211 (Fwrite_region): Don't assume off_t fits into 'long'.
212 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
213
ecfc0a49
MA
2142011-09-05 Michael Albinus <michael.albinus@gmx.de>
215
216 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
217
6511acf2 2182011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 219
0999621a 220 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
221
222 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 223 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
224 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
225 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
226 (modify_event_symbol): Do not assume that the length of
227 name_alist_or_stem is safe to alloca and fits in int.
228 (Fexecute_extended_command): Likewise for function name and binding.
229 (Frecursion_depth): Wrap around reliably on integer overflow.
230 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
231 since some callers pass EMACS_INT values.
232 (Fsingle_key_description): Don't crash if symbol name contains more
233 than MAX_ALLOCA bytes.
234 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
235 (get_minibuffer): Arg is now EMACS_INT, not int.
236 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 237 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
238 * window.h (command_loop_level, minibuf_level): Reflect API changes.
239
2be7d702
PE
240 * dbusbind.c (signature_cat): New function.
241 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
242 Do not overrun buffer; instead, report string overflow.
243
9d1df220
PE
244 * dispnew.c (add_window_display_history): Don't overrun buffer.
245 Truncate instead; this is OK since it's just a log.
246
33ef5c64
PE
247 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
248 even if the time zone offset is outlandishly large.
249 Don't mishandle offset == INT_MIN.
250
66c6fdd5
PE
251 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
252 when creating daemon; the previous buffer-overflow check was incorrect.
253
d749b01b
PE
254 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
255 which has the guts of the old verror function.
256
b5cd1905
PE
257 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
258 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
259
6e1a67fb
PE
260 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
261 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 262 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 263 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
264 length of string rather than counting it via multiple sprintfs;
265 that's simpler and more reliable.
c21721cc
PE
266 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
267 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
268 sprintf, in case result does not fit in int.
269
c57b67fc
PE
270 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
271 (fontset_from_font): Print it.
272
8a401434
PE
273 * frame.c (tty_frame_count): Now printmax_t, not int.
274 (make_terminal_frame, set_term_frame_name): Print it.
275 (x_report_frame_params): In X, window IDs are unsigned long,
276 not signed long, so print them as unsigned.
277 (validate_x_resource_name): Check for implausibly long names,
278 and don't assume name length fits in 'int'.
279 (x_get_resource_string): Don't blindly alloca invocation name;
280 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
281 not fit in int.
282
6e1a67fb
PE
283 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
284 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
285 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
286
0df02bf3
PE
287 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
288 Use esprintf, not sprintf, in case result does not fit in int.
289
48e30793
PE
290 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
291 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
292 it as a large positive number.
293 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
294 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
295
a66ff6d8
PE
296 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
297 in case result does not fit in int.
298
aca216ff
PE
299 * print.c (float_to_string): Detect width overflow more reliably.
300 (print_object): Make sprintf buffer a bit bigger, to avoid potential
301 buffer overrun. Don't assume list length fits in 'int'. Treat
302 print length of 0 as 0, not as infinity; to be consistent with other
303 uses of print length in this function. Don't overflow print length
304 index. Don't assume hash table size fits in 'long', or that
305 vectorlike size fits in 'unsigned long'.
306
31c286f7
PE
307 * process.c (make_process): Use printmax_t, not int, to format
308 process-name gensyms.
309
55e5faa1
PE
310 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
311
80f2e268
PE
312 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
313 to avoid potential buffer overrun.
314
670741ab
PE
315 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
316 if X resource line is longer than 512 bytes.
317
b7163a50
PE
318 * xfns.c (x_window): Make sprintf buffer a bit bigger
319 to avoid potential buffer overrun.
320
ae58ff1f
PE
321 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
322
c43c8a6a
PE
323 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
324
3f8236f4
PE
3252011-09-04 Paul Eggert <eggert@cs.ucla.edu>
326
53e9fe90 327 Integer overflow fixes for scrolling, etc.
6511acf2
PE
328 Without these, Emacs silently mishandles large integers sometimes.
329 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
330 it were "C-u 1 M-x recenter" on a typical 64-bit host.
331
6511acf2
PE
332 * xdisp.c (try_window_id): Check Emacs fixnum range before
333 converting to 'int'.
806add1d 334
6511acf2 335 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
336 Check that an Emacs fixnum is in range before assigning it to 'int'.
337 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
338 values converted from Emacs fixnums.
339 (Frecenter): Don't wrap around a line count if it is out of 'int'
340 range; instead, treat it as an extreme value.
341 (Fset_window_configuration, compare_window_configurations):
342 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
343
6511acf2
PE
344 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
345 that can exceed INT_MAX. Check that EMACS_INT value is in range
346 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
347 (match_limit): Don't assume that a fixnum can fit in 'int'.
348
6511acf2 349 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
350 exceed INT_MAX.
351
6511acf2 352 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
353 (Fvertical_motion): Don't wrap around LINES values that don't fit
354 in 'int'. Instead, treat them as extreme values. This is good
355 enough for windows, which can't have more than INT_MAX lines anyway.
356
fcb901a7
LMI
3572011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
358
0f2f6b6d
LMI
359 * Require libxml/parser.h to avoid compilation warning.
360
fcb901a7
LMI
361 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
362
363 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
364 since this reportedly can destroy thread storage.
365
6e20a0d4
CY
3662011-08-30 Chong Yidong <cyd@stupidchicken.com>
367
368 * syntax.c (find_defun_start): Update all cache variables if
369 exiting early (Bug#9401).
370
148ae00e
EZ
3712011-08-30 Eli Zaretskii <eliz@gnu.org>
372
f6cfbd8f
EZ
373 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
374
148ae00e
EZ
375 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
376 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
377 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
378
379 * term.c (tty_append_glyph): New function.
380 (produce_stretch_glyph): Static function and its prototype deleted.
381
382 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
383 prototypes.
384
c4a07a4c
PE
3852011-08-29 Paul Eggert <eggert@cs.ucla.edu>
386
387 * image.c (parse_image_spec): Check for nonnegative, not for positive,
388 when checking :margin (Bug#9390).
389 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
390 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
391 so that the name doesn't mislead. All uses changed.
392
6bc8cd65
JB
3932011-08-28 Johan Bockgård <bojohan@gnu.org>
394
395 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
396 set_tty_hooks.
397
dca4927e
EZ
3982011-08-27 Eli Zaretskii <eliz@gnu.org>
399
400 * xdisp.c (move_it_to): Don't bail out early when reaching
401 position beyond to_charpos, if we are scanning backwards.
402 (move_it_vertically_backward): When DY == 0, make sure we get to
403 the first character in the line after the newline.
404
f2cad773
PE
4052011-08-27 Paul Eggert <eggert@cs.ucla.edu>
406
407 * ccl.c: Improve and simplify overflow checking (Bug#9196).
408 (ccl_driver): Do not generate an out-of-range pointer.
409 (Fccl_execute_on_string): Remove unnecessary check for
410 integer overflow, noted by Stefan Monnier in
411 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
412 Remove a FIXME that didn't need fixing.
413 Simplify the newly-introduced buffer reallocation code.
414
0cae2cdb
JB
4152011-08-27 Juanma Barranquero <lekktu@gmail.com>
416
417 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
418
5fc295a4 4192011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 420
70c60eb2 421 Integer and memory overflow issues (Bug#9196).
726e0ab1 422
d31850da
PE
423 * doc.c (get_doc_string): Rework so that
424 get_doc_string_buffer_size is the actual buffer size, rather than
425 being 1 less than the actual buffer size; this makes xpalloc more
426 convenient.
427
a69fbedb
PE
428 * image.c (x_allocate_bitmap_record, cache_image):
429 * xselect.c (Fx_register_dnd_atom):
430 Simplify previous changes by using xpalloc.
431
fe5c5d37
PE
432 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
433 since either will do and ptrdiff_t is convenient with xpalloc.
434
0065d054
PE
435 * charset.c (charset_table_size)
436 (struct charset_sort_data.priority): Now ptrdiff_t.
437 (charset_compare): Don't overflow if priorities differ greatly.
438 (Fsort_charsets): Don't assume list length fits in int.
439 Check for size-calculation overflow when allocating sort data.
440 (syms_of_charset): Allocate an initial charset table that is
441 just under 64 KiB, to avoid problems with glibc malloc and mmap.
442
443 * cmds.c (internal_self_insert): Check for size-calculation overflow.
444
445 * composite.h (struct composition.glyph_len): Now int, not unsigned.
446 The actual value is always <= INT_MAX, and leaving it unsigned made
447 overflow checking harder.
448
449 * dispextern.h (struct glyph_matrix.rows_allocated)
450 (struct face_cache.size): Now ptrdiff_t, for convenience in use
451 with xpalloc. The values are still always <= INT_MAX.
452
453 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
454
455 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
456 (SAFE_NALLOCA): New macro.
457
458 * region-cache.c (struct boundary.pos, find_cache_boundary)
459 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
460 (set_cache_region, invalidate_region_cache)
461 (revalidate_region_cache, know_region_cache, region_cache_forward)
462 (region_cache_backward, pp_cache):
463 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
464 so that ptrdiff_t * can be passed to xpalloc.
465 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
466 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
467 (pp_cache): Don't assume cache_len fits in int.
468 * region-cache.h: Adjust extern decls to match.
469
470 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
471 EMACS_INT, since either will do, for xpalloc.
472
473 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
474 (xnmalloc, xnrealloc, xpalloc): New functions.
475
726e0ab1
PE
476 * bidi.c (bidi_shelve_header_size): New constant.
477 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
478 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
479
51f30bc5 480 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
481 * buffer.c (overlays_at, overlays_in, record_overlay_string)
482 (overlay_strings):
483 Don't update size of array until after memory allocation succeeds,
484 because xmalloc/xrealloc may not return.
0065d054
PE
485 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
486 now that we have proper integer overflow checking.
487 (record_overlay_string, overlay_strings): Catch overflows when
488 calculating size of overlay_str_buf.
726e0ab1 489
0065d054
PE
490 * callproc.c (Fcall_process): Check for size overflow when
491 calculating size of args2.
492 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
493 Normally we prefer signed values, but sticking with ptrdiff_t would
494 require adding more-complicated checks.
726e0ab1
PE
495
496 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
497 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
498 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 499 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
500
501 * character.c (Fstring): Check for size-calculation overflow.
502
503 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
504 unnecessary integer overflow. Check for size overflow.
505 (encode_coding_object): Don't update size until xmalloc succeeds.
506
507 * composite.c (get_composition_id): Check for overflow in glyph
508 length calculations.
509
510 Integer and memory overflow fixes for display code.
511 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
512 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
513 (scrolling_window): Check for overflow in size calculations.
514 (line_draw_cost, realloc_glyph_pool, add_row_entry):
515 Don't assume glyph table len fits in int.
516 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
517 (row_table_size): Now ptrdiff_t, not int.
518 (scrolling_window): Avoid overflow in size calculations.
519 Don't update size until allocation succeeds.
520 * fns.c (concat): Check for overflow in size calculations.
521 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
522 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
523 (NEXT_ALMOST_PRIME_LIMIT): New constant.
524
525 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
526 (get_doc_string): Check for size calculation overflow.
527 Don't update size until allocation succeeds.
528 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
529 EMACS_INT, where ptrdiff_t will do.
530 (Fsubstitute_command_keys): Check for string overflow.
531
532 * editfns.c (set_time_zone_rule): Don't assume environment length
533 fits in int.
534 (message_length): Now ptrdiff_t, not int.
535 (Fmessage_box): Don't update size until allocation succeeds.
536 Don't assume message length fits in int.
537 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
538
0065d054
PE
539 * emacs.c (main): Do not reallocate argv, since there is a null at
540 the end that can be overwritten, and this way there's no need to
541 worry about size-calculation overflow.
542 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
543
544 * eval.c (init_eval_once, grow_specpdl): Don't update size until
545 alloc succeeds.
546 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
547
548 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
549 (x_set_scroll_bar_width, x_figure_window_size):
550 Check for integer overflow.
551 (x_set_alpha): Do not assume XINT fits in int.
552
553 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
554 This is for the members text_lines, text_cols, total_lines, total_cols,
555 where the system imposes an 'int' limit.
556
557 * fringe.c (Fdefine_fringe_bitmap):
558 Don't update size until alloc works.
559
560 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
561 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
562
563 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
564 Check for size-calculation overflow.
565 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
566 do, as we prefer signed integers.
567 (id_to_widget.max_size, id_to_widget.used)
568 (xg_store_widget_in_map, xg_remove_widget_from_map)
569 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
570 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
571 Use and return ptrdiff_t, not int.
572 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
573 * gtkutil.h: Change prototypes to match the above.
574
575 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
576 are duplicate now that they've been promoted to lisp.h.
577 (x_allocate_bitmap_record, x_alloc_image_color)
578 (make_image_cache, cache_image, xpm_load):
579 Don't update size until alloc is done.
580 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
581 (x_detect_edges):
3256efce 582 Check for size calculation overflow.
726e0ab1
PE
583 (ct_colors_allocated_max): New constant.
584 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
585 overflow.
3256efce 586
726e0ab1
PE
587 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
588 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
589 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
590 Use ptrdiff_t, not int, to count maps.
591 (read_char_minibuf_menu_prompt): Check for overflow in size
592 calculations. Don't update size until allocation succeeds. Redo
593 calculations to avoid overflow.
594 * keyboard.h: Change prototypes to match the above.
595
596 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
597 to count maps.
598 (current_minor_maps): Check for size calculation overflow.
599 * keymap.h: Change prototypes to match the above.
600
601 * lread.c (read1, init_obarray): Don't update size until alloc done.
602
603 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
604 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
605
726e0ab1
PE
606 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
607 Now ptrdiff_t, not int.
608 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
609 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
610
611 * process.c (Fnetwork_interface_list): Check for overflow
612 in size calculation.
613
614 * region-cache.c (move_cache_gap): Check for size calculation overflow.
615
616 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
617 overflow. Don't bother calling xmalloc when xrealloc will do.
618
619 * search.c (Freplace_match): Check for size calculation overflow.
620 (Fset_match_data): Don't assume list lengths fit in 'int'.
621
622 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
623 for command line length. Do not attempt to address one before the
624 beginning of an array, as that's not portable.
625
626 * term.c (max_frame_lines): Remove; unused.
627 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
628 not int.
629 (encode_terminal_code, calculate_costs): Check for size
630 calculation overflow.
631 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
632 table lengths and related sizes. Don't update size until alloc
633 done. Redo calculations to avoid overflow.
634 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
635
636 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
637 subtracting pointers.
638 (gobble_line): Check for overflow more carefully. Don't update size
639 until alloc done.
640
641 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
642 Don't update size until alloc done.
643 Redo size calculations to avoid overflow.
644 Check for size calculation overflow.
0065d054 645 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
646
647 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
648 Use ptrdiff_t, not int, for sizes.
649 (store_mode_line_noprop_char): Don't update size until alloc done.
650
0065d054
PE
651 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
652 Use ptrdiff_t, not int, for sizes.
653 (Finternal_make_lisp_face, cache_face):
654 Check for size calculation overflow.
655 (cache_face): Treat size calculation overflows as if they were
656 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
657
658 * xfns.c (x_encode_text, x_set_name_internal)
659 (Fx_change_window_property): Use ptrdiff_t, not int, to count
660 sizes, since they can exceed INT_MAX in size. Check for size
661 calculation overflow.
662
0065d054
PE
663 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
664 (xg_select): Check for size calculation overflow.
726e0ab1
PE
665 Don't update size until alloc done.
666
0065d054 667 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 668 as sprintf is limited to int lengths.
1d526e2f 669
252c5ee1
PE
670 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
671 (X_LONG_MIN): New macros.
864d7ce7
PE
672 Use them to make the following changes clearer.
673 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
674 This change doesn't affect the value now, but it may help remind
675 future maintainers not to raise the value too much later.
676 (SELECTION_QUANTUM): Remove, replacing with ...
677 (selection_quantum): ... new function, which avoids overflow.
678 All uses changed.
679 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
680 assumption that selection length fits in 'int'.
681 (x_reply_selection_request, x_handle_selection_request)
682 (x_get_window_property, receive_incremental_selection)
683 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
684 (lisp_data_to_selection_data, clean_local_selection_data):
685 Use ptrdiff_t, not int, to record length of selection.
686 (x_reply_selection_request, x_get_window_property)
687 (receive_incremental_selection, x_property_data_to_lisp):
688 Redo calculations to avoid overflow.
689 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 690 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
691 something.
692 (x_get_window_property, receive_incremental_selection)
693 (lisp_data_to_selection_data, x_property_data_to_lisp):
694 Check for size-calculation overflow.
695 (x_get_window_property, receive_incremental_selection)
696 (lisp_data_to_selection_data, Fx_register_dnd_atom):
697 Don't store size until memory allocation succeeds.
698 (x_get_window_property): Plug memory leak on memory exhaustion.
699 Don't double-block input; malloc is safe here. Don't assume 2**34
700 - 4 fits in unsigned long. Add an xassert to check
701 XGetWindowProperty overflow. Be more careful about overflow
702 calculations, and distinguish size from memory overflow better.
703 (receive_incremental_selection): When tracing, don't assume
704 unsigned int is less than INT_MAX.
705 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
706 harmful) conversions of unsigned short to int.
707 (lisp_data_to_selection_data): Don't assume that integers
708 in the range -65535 through -1 fit in an X unsigned short.
709 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
710 result parameters unless successful. Rely on cons_to_unsigned
711 to report problems with elements; the old code wasn't right anyway.
712 (x_check_property_data): Check for int overflow; we cannot use
713 a wider type due to X limits.
714 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
715
726e0ab1 716 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 717
0065d054
PE
718 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
719 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
720 (x_color_cells): Don't store size until memory allocation succeeds.
721 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 722 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
723 (x_term_init): Don't assume length fits in int (sprintf is limited
724 to int size).
bc18e09d 725
ebfa62c0
PE
726 Use ptrdiff_t for composition IDs.
727 * character.c (lisp_string_width):
728 * composite.c (composition_table_size, n_compositions)
729 (get_composition_id, composition_gstring_from_id):
730 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
731 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
732 * window.c (Frecenter):
733 Use ptrdiff_t, not int, for composition IDs.
734 * composite.c (get_composition_id): Check for integer overflow.
735 * composite.h: Adjust prototypes to match the above changes.
736
d3411f89
PE
737 Use ptrdiff_t for hash table indexes.
738 * category.c (hash_get_category_set):
739 * ccl.c (ccl_driver):
740 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
741 * coding.c (coding_system_charset_list, detect_coding_system):
742 * coding.h (struct coding_system.id):
743 * composite.c (get_composition_id, gstring_lookup_cache):
744 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
745 * image.c (xpm_get_color_table_h):
746 * lisp.h (hash_lookup, hash_put):
747 * minibuf.c (Ftest_completion):
748 Use ptrdiff_t for hash table indexes, not int (which is too
749 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
750 32-bit --with-wide-int hosts).
751
e097a6fa
PE
752 * charset.c (Fdefine_charset_internal): Check for integer overflow.
753 Add a FIXME comment about memory leaks.
754 (syms_of_charset): Don't assume xmalloc returns.
755
5637687f
PE
756 Don't assume that stated character widths fit in int.
757 * character.c (Fchar_width, c_string_width, lisp_string_width):
758 * character.h (CHAR_WIDTH):
759 * indent.c (MULTIBYTE_BYTES_WIDTH):
760 Use sanitize_char_width to avoid undefined and/or bad behavior
761 with outlandish widths.
762 * character.h (sanitize_tab_width): Renamed from sanitize_width,
763 now that we have two such functions. All uses changed.
764 (sanitize_char_width): New inline function.
765
a2271ba2
PE
766 Don't assume that tab-width fits in int.
767 * character.h (sanitize_width): New inline function.
768 (SANE_TAB_WIDTH): New macro.
769 (ASCII_CHAR_WIDTH): Use it.
770 * indent.c (sane_tab_width): Remove. All uses replaced by
771 SANE_TAB_WIDTH (current_buffer).
772 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
773
18c52557
PE
774 * fileio.c: Integer overflow issues with file modes.
775 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
776
caeeedc1
PE
777 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
778 Remove unreachable code.
779 (read_hex, load_charset_map_from_file): Check for integer overflow.
780
50849c52
PE
781 * xterm.c: don't go over XClientMessageEvent limit
782 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
783 (x_send_scroll_bar_event): Likewise. Check that the size does not
784 exceed limits imposed by XClientMessageEvent, as well as the usual
785 ptrdiff_t and size_t limits.
786
b13995db
PE
787 * keyboard.c: Overflow, signedness and related fixes.
788 (make_lispy_movement): Use same integer type in forward decl
789 that is used in the definition.
790 (read_key_sequence, keyremap_step):
791 Change bufsize argument back to int, undoing my 2011-03-30 change.
792 We prefer signed types, and int is wide enough here.
793 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
794 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
795 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
796 length, not size_t. Use ptrdiff_t for index, not int.
797 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
798 possibility of integer overflow.
799
13464394
PE
800 Overflow, signedness and related fixes for images.
801
802 * dispextern.h (struct it.stack[0].u.image.image_id)
803 (struct_it.image_id, struct image.id, struct image_cache.size)
804 (struct image_cache.used, struct image_cache.ref_count):
805 * gtkutil.c (update_frame_tool_bar):
806 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
807 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
808 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
809 * nsmenu.m (update_frame_tool_bar):
810 * xdisp.c (calc_pixel_width_or_height):
811 * xfns.c (image_cache_refcount):
812 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
813 on typical 64-bit hosts.
814
815 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
816 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
817 Omit unnecessary casts to int.
818 (parse_image_spec): Check that integers fall into 'int' range
819 when the callers expect that.
820 (image_ascent): Redo ascent calculation to avoid int overflow.
821 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
822 (lookup_image): Remove unnecessary tests.
823 (xbm_image_p): Locals are now of int, not EMACS_INT,
824 since parse_image_check makes sure they fit into int.
825 (png_load, gif_load, svg_load_image):
826 Prefer int to unsigned where either will do.
827 (tiff_handler): New function, combining the cores of the
828 old tiff_error_handler and tiff_warning_handler. This
829 function is rewritten to use vsnprintf and thereby avoid
830 stack buffer overflows. It uses only the features of vsnprintf
831 that are common to both POSIX and native Microsoft.
832 (tiff_error_handler, tiff_warning_handler): Use it.
833 (tiff_load, gif_load, imagemagick_load_image):
834 Don't assume :index value fits in 'int'.
835 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
836 (imagemagick_load_image): Check that crop parameters fit into
837 the integer types that MagickCropImage accepts. Don't assume
838 Vimagemagick_render_type has a nonnegative value. Don't assume
839 size_t fits in 'long'.
840 (gs_load): Use printmax_t to print the widest integers possible.
841 Check for integer overflow when computing image height and width.
842
c11821d4
EZ
8432011-08-26 Eli Zaretskii <eliz@gnu.org>
844
845 * xdisp.c (redisplay_window): Don't force window start if point
846 will be invisible in the resulting window. (Bug#9324)
847
0c95fcf7
EZ
8482011-08-25 Eli Zaretskii <eliz@gnu.org>
849
850 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
851 the display spec is of the form `(space ...)'.
852 (handle_display_spec): Return the value returned by
853 handle_single_display_spec, not just 1 or zero.
854 (handle_single_display_spec): If the display spec is of the form
855 `(space ...)', and specifies display in the text area, return 2
856 rather than 1.
fee65a97 857 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
858 accurately, and prefer exact match for point under bidi. Don't
859 advance `row' beyond the last row of the window.
0c95fcf7
EZ
860
861 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
862 into disp_prop; all users changed.
863
864 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
865 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
866 for the text covered by the display property.
867
e4ed06f1
CY
8682011-08-25 Chong Yidong <cyd@stupidchicken.com>
869
870 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
871 Change return value to nil.
872 (Frecord_buffer): Delete unused function.
873
f67cdd7f
EZ
8742011-08-24 Eli Zaretskii <eliz@gnu.org>
875
5980d4c6
EZ
876 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
877 buffers, return left-to-right.
8610fe8b
EZ
878 (set_cursor_from_row): Consider candidate row a win if its glyph
879 represents a newline and point is on that newline. Fixes cursor
880 positioning on the newline at EOL of R2L text within L2R
881 paragraph, and vice versa.
882 (try_cursor_movement): Check continued rows, in addition to
883 continuation rows. Fixes unwarranted scroll when point enters a
884 continued line of R2L text within an L2R paragraph, or vice versa.
885 (cursor_row_p): Consider the case of point being equal to
886 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
887 from the end of a short line to the beginning of a continued line
888 of R2L text within L2R paragraph.
889 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
890 composed characters.
5980d4c6 891
f67cdd7f
EZ
892 * bidi.c (bidi_check_type): Use xassert.
893 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
894 members.
895
bca633fb
EZ
8962011-08-23 Eli Zaretskii <eliz@gnu.org>
897
898 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
899 a character.
900
4a5885a7
CY
9012011-08-23 Chong Yidong <cyd@stupidchicken.com>
902
903 * nsfont.m (ns_otf_to_script): Fix typo.
904
0902a04e
KH
9052011-08-22 Kenichi Handa <handa@m17n.org>
906
907 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
908 extra slot even if the purpose is char-code-property-table.
909
1a2e6670
EZ
9102011-08-23 Eli Zaretskii <eliz@gnu.org>
911
8ddde651
EZ
912 * xdisp.c (redisplay_window): When computing centering_position,
913 account for the height of the header line. (Bug#8874)
914
425cc014
EZ
915 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
916 instead of CHAR_TO_BYTE. Fixes a crash when a completion
917 candidate is selected by the mouse, and that candidate has a
918 composed character under the mouse.
919
1a2e6670
EZ
920 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
921 coordinates reported by pos-visible-in-window-p for a composed
922 character in column zero.
923
8b76d6f8
SM
9242011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
925
926 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
927
dac347dd
EZ
9282011-08-22 Eli Zaretskii <eliz@gnu.org>
929
930 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
931 consider it a hit if to_charpos is anywhere in the range of the
932 composed buffer positions.
933
e013fb34
CY
9342011-08-22 Chong Yidong <cyd@stupidchicken.com>
935
936 * image.c (gif_load): Don't assume that each subimage has the same
937 dimensions as the base image. Handle disposal method that is
938 "undefined" by the gif spec (Bug#9335).
939
bd1ba3e8
CY
9402011-08-20 Chong Yidong <cyd@stupidchicken.com>
941
942 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 943 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 944
54a1215b
EZ
9452011-08-19 Eli Zaretskii <eliz@gnu.org>
946
823564e5
EZ
947 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
948 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
949 from an Org mode buffer to a Speedbar frame.
950
54a1215b
EZ
951 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
952 a composition, take its buffer position from IT->cmp_it.charpos.
953 Fixes cursor positioning at the beginning of a line that begins
954 with a composed character.
955
9778ebcc
EZ
9562011-08-18 Eli Zaretskii <eliz@gnu.org>
957
0be6ee06
EZ
958 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
959 character bidirectional type, use STRONG_L instead. Fixes crashes
960 in a buffer produced by `describe-categories'.
961
9778ebcc
EZ
962 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
963 members before the level stack, so they would be saved and
964 restored when copying iterator state. Fixes incorrect reordering
965 around TABs covered by display properties.
966
156bffbe
AS
9672011-08-18 Andreas Schwab <schwab@linux-m68k.org>
968
969 * process.c (Fnetwork_interface_list): Correctly determine buffer
970 size.
971
72ad093b
CY
9722011-08-17 Chong Yidong <cyd@stupidchicken.com>
973
974 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
975 (internal_condition_case_2, internal_condition_case_n):
976 Remove unnecessary aborts (Bug#9081).
72ad093b 977
35774242
EZ
9782011-08-17 Eli Zaretskii <eliz@gnu.org>
979
980 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
981 has no `load' handler, try opening the file locally. (Bug#9311)
982
db76dd85
KB
9832011-08-16 Ken Brown <kbrown@cornell.edu>
984
985 * gmalloc.c: Expand comment.
986
b215eee5
EZ
9872011-08-16 Eli Zaretskii <eliz@gnu.org>
988
989 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
990 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
991
a4579d33
KB
9922011-08-16 Ken Brown <kbrown@cornell.edu>
993
994 Fix memory allocation problems in Cygwin build (Bug#9273).
995
996 * unexcw.c ( __malloc_initialized): Declare external variable.
997 (fixup_executable): Force the dumped emacs to reinitialize malloc.
998
8b76d6f8
SM
999 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1000 New variables.
a4579d33
KB
1001 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1002 dumped emacs.
1003 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1004 in the static heap.
1005 [CYGWIN] (special_realloc): New function.
1006 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1007 requests to realloc storage in the static heap.
1008
3ebec551
PE
10092011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1010
1011 * bidi.c (bidi_initialize): Remove unused local.
1012
9fd8be00
EZ
10132011-08-15 Eli Zaretskii <eliz@gnu.org>
1014
474a8465
EZ
1015 * biditype.h: File removed.
1016
1017 * bidimirror.h: File removed.
1018
1019 * deps.mk (bidi.o): Remove biditype.h and
1020 bidimirror.h.
1021
1022 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1023 bidimirror.h.
1024
1025 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1026
1027 * chartab.c: Improve commentary for the uniprop_table API.
1028
32413314
EZ
1029 * bidi.c (bidi_paragraph_init): Support zero value of
1030 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1031 (bidi_initialize): Use uniprop_table instead of including
1032 biditype.h and bidimirror.h.
32413314 1033
9fd8be00
EZ
1034 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1035 coordinates of the iterator when restoring from ppos_it.
1036 (Bug#9296)
1037
5cf2b69b
KH
10382011-08-14 Kenichi Handa <handa@m17n.org>
1039
1040 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1041 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1042
daf17d00
EZ
10432011-08-14 Eli Zaretskii <eliz@gnu.org>
1044
1045 * xdisp.c (move_it_in_display_line_to): Don't invoke
1046 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1047 ppos_it. Fixes vertical cursor motion when line beginning is
1048 covered by an image. (Bug#9296)
1049
08e3161a
JD
10502011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1051
1052 * nsterm.h (ns_run_ascript): Declare.
1053 (NSAPP_DATA2_RUNASSCRIPT): Define.
1054
1055 * nsfns.m (as_script, as_result, as_status): New static variables.
1056 (ns_run_ascript): New function.
5e617bc2 1057 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1058 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1059 the event loop. Get status from as_status (Bug#7276).
1060
1061 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1062 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1063 the event loop (Bug#7276).
1064
a3720aa2
AS
10652011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1066
1067 * gnutls.c (QCgnutls_bootprop_priority)
1068 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1069 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1070 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1071 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1072 (QCgnutls_bootprop_verify_hostname_error)
1073 (QCgnutls_bootprop_callbacks_verify): Rename from
1074 Qgnutls_bootprop_..., all uses changed.
1075
1076 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1077 uses changed.
1078
0a0d27fb
PE
10792011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1080
19d5c50c
PE
1081 * xfaces.c (Qframe_set_background_mode): Now static.
1082 * dispextern.h (Qframe_set_background_mode): Remove decl.
1083
0a0d27fb
PE
1084 * process.c (Fnetwork_interface_info): Declare local only if needed.
1085
377538cb
JD
10862011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1087
1088 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1089 (Fnetwork_interface_list): Allocate in increments of bytes instead
1090 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1091 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1092 sockaddr.
1093 (struct ifflag_def): notrailers is smart on OSX.
1094 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1095 Get hardware address with getifaddrs if available.
1096
08fff70c
EZ
10972011-08-12 Eli Zaretskii <eliz@gnu.org>
1098
1099 * xdisp.c (iterate_out_of_display_property): xassert that
1100 IT->position is set to within IT->object's boundaries. Break from
1101 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1102 when IT->position is set up wrongly due to some bug.
1103 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1104 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1105 entry. Force push_it to save on the stack the current
1106 buffer/string position, to be restored by pop_it. Fix flags in
1107 the iterator structure wrt the object coming from a display
1108 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1109 properties. (Bug#9284)
1110
7be1c708 11112011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1112
7be1c708
CY
1113 * fontset.c (fontset_get_font_group): Add proper type checks.
1114 (Bug#9172)
aac0c6e3 1115
7be1c708 11162011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1117
7be1c708
CY
1118 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1119 and LC_VERSION_MIN_MACOSX.
1120 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1121 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1122
97bb72a6
EZ
11232011-08-08 Eli Zaretskii <eliz@gnu.org>
1124
1125 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1126 no-display-properties-and-no-overlays under bidi display.
1127 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1128 properties and overlays.
97bb72a6 1129
d5617611
CY
11302011-08-08 Chong Yidong <cyd@stupidchicken.com>
1131
37e11a63
CY
1132 * editfns.c (Fset_time_zone_rule): Document relationship with the
1133 setenv function.
1134
d5617611
CY
1135 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1136 the font entity extracted from the cache (Bug#8109).
1137
58872834
CY
11382011-08-07 Chong Yidong <cyd@stupidchicken.com>
1139
1140 * composite.c (autocmp_chars): Don't reset point. That is done by
1141 restore_point_unwind (Bug#5984).
1142
75bfc667
JL
11432011-08-07 Juri Linkov <juri@jurta.org>
1144
1145 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1146 to show the arg `TIME' instead of `TIMEVAL'.
1147
d1410150
EZ
11482011-08-06 Eli Zaretskii <eliz@gnu.org>
1149
1150 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1151 display property strides EOL and includes a newline, as in
1152 longlines-mode. (Bug#9254)
75b771e4
EZ
1153 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1154 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1155
1156 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1157 is non-zero, even if the data buffer is NULL. Fixes a crash in
1158 vertical-motion with longlines-mode. (Bug#9254)
1159
35928349
EZ
11602011-08-05 Eli Zaretskii <eliz@gnu.org>
1161
ec7cc85b
EZ
1162 * bidi.c <bidi_cache_total_alloc>: Now static.
1163 (bidi_initialize): Initialize bidi_cache_total_alloc.
1164
8b76d6f8 1165 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1166 cache. (Bug#9221)
1167
1168 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1169 amount allocated this far in `bidi_cache_total_alloc'.
1170 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1171 non-zero, only free the data buffer without restoring the cache
1172 contents. All callers changed.
1173
1174 * dispextern.h (bidi_unshelve_cache): Update prototype.
1175
1176 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1177 (move_it_in_display_line, move_it_to)
1178 (move_it_vertically_backward, move_it_by_lines): Replace the call
1179 to xfree to an equivalent call to bidi_unshelve_cache.
1180 (move_it_in_display_line_to): Fix logic of returning
412b6358 1181 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1182
e2e2423b
EZ
11832011-08-05 Eli Zaretskii <eliz@gnu.org>
1184
1185 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1186 came from a string character with a `cursor' property. (Bug#9229)
1187
ae9e757a
JD
11882011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1189
1190 * Makefile.in (LIB_PTHREAD): New variable.
1191 (LIBES): Add LIB_PTHREAD (Bug#9216).
1192
1193 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1194 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1195
213bd7f2
AS
11962011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1197
1198 * regex.c (re_iswctype): Remove some redundant boolean
1199 conversions.
1200
99aaf75f
JD
12012011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1202
1203 * xterm.c (x_find_topmost_parent): New function.
1204 (x_set_frame_alpha): Find topmost parent window with
1205 x_find_topmost_parent and set the property there also (bug#9181).
1206 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1207
c74e9d86
PE
12082011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1209
1210 * callproc.c (Fcall_process): Avoid vfork clobbering
1211 the local vars buffer, coding_systems, current_dir.
1212
640c8776
SM
12132011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1214
1215 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1216
f26d0e4c
PE
12172011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1218
8a10d76c
PE
1219 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1220 so that it is not optimized away.
1221
f26d0e4c
PE
1222 * xdisp.c (compute_display_string_pos): Remove unused local.
1223
55439c61
EZ
12242011-08-02 Eli Zaretskii <eliz@gnu.org>
1225
1226 Fix slow cursor motion and scrolling in large buffers with
1227 selective display, like Org Mode buffers. (Bug#9218)
1228
1229 * dispextern.h (struct bidi_it): New member disp_prop_p.
1230
1231 * xdisp.c: Remove one-slot cache of display string positions.
1232 (compute_display_string_pos): Accept an additional argument
5e617bc2 1233 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1234 for a display string or property. If found, set DISP_PROP_P
1235 non-zero.
1236
1237 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1238 DISP_PROP_P, and pass it to compute_display_string_pos.
1239 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1240 non-zero. All callers of bidi_fetch_char changed.
1241
fb33fa43
SM
12422011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1243
1244 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1245
b099e063
DM
12462010-12-03 Don March <don@ohspite.net>
1247
1248 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1249 last character M-[char] is translated to ESC [char] (bug#7541).
1250
5cc7f7af
KH
12512011-08-02 Kenichi Handa <handa@m17n.org>
1252
d0fffa3f 1253 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1254
1255 * chartab.c (uniprop_table): Make it non-static.
1256
525d5e6e
EZ
12572011-08-01 Eli Zaretskii <eliz@gnu.org>
1258
1259 * xdisp.c (forward_to_next_line_start): Accept additional argument
1260 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1261 on the newline.
1262 (reseat_at_next_visible_line_start): Use the bidi iterator state
1263 returned by forward_to_next_line_start to restore the state of
1264 it->bidi_it after backing up to previous newline. (Bug#9212)
1265
31011111
AS
12662011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1267
1268 * regex.c (re_comp): Protoize.
1269 (re_exec): Fix return type.
1270 (regexec): Fix type of `ret'. (Bug#9203)
1271
476371c4
PE
12722011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1273
e5d76069
PE
1274 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1275 This is needed if max-image-size is a floating-point number.
1276
9a79b20c
AS
12772011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1278
1279 * print.c (print_object): Print empty symbol as ##.
1280
1281 * lread.c (read1): Read ## as empty symbol.
1282
d8c2fa78
AA
12832011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1284
1285 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1286 setting frame foreground color (Bug#9175).
1287 (x_set_background_color): Likewise.
1288
ffe57a7a
AA
1289 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1290 contents (Bug#9176).
1291 (EmacsTooltip -init): Remove bezels and add shadows to
1292 tooltip windows.
1293
bf3492a5
AA
1294 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1295 or scroll bar (Bug#8470).
1296
d55e9c53
AA
1297 * nsfont.m (nsfont_open): Remove assignment to voffset and
1298 unnecessary vars hshink, expand, hd, full_height, min_height.
1299 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1300
1301 * nsterm.h (nsfont_info): Remove voffset field.
1302
d8c2fa78 13032011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1304
1305 Implement strike-through and overline on NextStep (Bug#8863).
1306
1307 * nsfont.m (nsfont_open): Use underline position provided by font,
1308 instead of hard-coded value of 2.
1309 (nsfont_draw): Call ns_draw_text_decoration instead.
1310
1311 * nsterm.h: Add declaration for ns_draw_text_decoration.
1312
1313 * nsterm.m (ns_draw_text_decoration): New function for drawing
1314 underline, overline, and strike-through.
1315 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1316 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1317 accommodate underlining, etc.
4843aac3 1318
4cc60b9b
EZ
13192011-07-28 Eli Zaretskii <eliz@gnu.org>
1320
bc7ece87
EZ
1321 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1322 default.
4cc60b9b 1323
476371c4
PE
13242011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1325
66606eea
PE
1326 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1327 Without this fix, if a signal arrives just after memory fills up,
1328 'malloc' might be invoked reentrantly.
1329
476371c4
PE
1330 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1331 In other words, assume that every image size is allowed, on non-X
1332 hosts. This assumption is probably wrong, but it lets Emacs compile.
1333
f3fcc40d
AS
13342011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1335
1336 * regex.c (re_iswctype): Convert return values to boolean.
1337
350c992f
EZ
13382011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1339
1340 * xdisp.c (compute_display_string_pos): Don't use cached display
1341 string position if the buffer had its restriction changed.
1342 (Bug#9184)
1343
5266b4bb
PE
13442011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1345
1346 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1347
2573a837 13482011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1349
41f55ccd 1350 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1351
39e378da
PE
1352 * bidi.c: Integer size and overflow fixes.
1353 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1354 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1355 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1356 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1357 (bidi_find_other_level_edge):
1358 Use ptrdiff_t instead of EMACS_INT where either will do.
1359 This works better on 32-bit hosts configured --with-wide-int.
1360 (bidi_cache_ensure_space): Check for size-calculation overflow.
1361 Use % rather than repeated addition, for better worst-case speed.
1362 Don't set bidi_cache_size until after xrealloc returns, because it
1363 might not return.
1364 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1365 (bidi_cache_ensure_space): Also check that the bidi cache size
1366 does not exceed that of the largest Lisp string or buffer. See Eli
1367 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1368
5e927815
PE
1369 * alloc.c (__malloc_size_t): Remove.
1370 All uses replaced by size_t. See Andreas Schwab's note
1371 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1372
ca4aa935
PE
1373 * image.c: Improve checking for integer overflow.
1374 (check_image_size): Assume that f is nonnull, since
1375 it is always nonnull in practice. This is one less thing to
1376 worry about when checking for integer overflow later.
1377 (x_check_image_size): New function, which checks for integer
1378 overflow issues inside X.
1379 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1380 This removes the need for a memory_full check.
1381 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1382 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1383 (xbm_read_bitmap_data): Change locals back to 'int', since
1384 their values must fit in 'int'.
1385 (xpm_load_image, png_load, tiff_load):
1386 Invoke x_create_x_image_and_pixmap earlier,
1387 to avoid much needless work if the image is too large.
1388 (tiff_load): Treat overly large images as if
1389 x_create_x_image_and_pixmap failed, not as malloc failures.
1390 (gs_load): Use x_check_image_size.
1391
5f8f9cc2
PE
1392 * gtkutil.c: Omit integer casts.
1393 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1394 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1395
5adf60bc
PE
1396 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1397
c8907a93
PE
1398 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1399 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1400 would wrongly return t on a 64-bit host.
1401
e3c25c68
PE
1402 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1403 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1404 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1405 and therefore cause GCC to emit a bogus diagnostic in some cases.
1406
3f791afe
PE
1407 * image.c: Integer signedness and overflow and related fixes.
1408 This is not an exhaustive set of fixes, but it's time to
1409 record what I've got.
1410 (lookup_pixel_color, check_image_size): Remove redundant decls.
1411 (check_image_size): Don't assume that arbitrary EMACS_INT values
1412 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1413 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1414 (tiff_load, imagemagick_load_image):
1415 Check for overflow in size calculations.
1416 (x_create_x_image_and_pixmap): Remove unnecessary test for
1417 xmalloc returning NULL; that can't happen.
1418 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1419 (xpm_color_bucket): Use better integer hashing function.
1420 (xpm_cache_color): Don't possibly over-allocate memory.
1421 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1422 (gif_memory_source):
1423 Use ptrdiff_t, not int or size_t, to record sizes.
1424 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1425 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1426 either works, as we prefer signed integers.
1427 (tiff_read_from_memory, tiff_write_from_memory):
1428 Return tsize_t, not size_t, since that's what the TIFF API wants.
1429 (tiff_read_from_memory): Don't fail simply because the read would
1430 go past EOF; instead, return a short read.
1431 (tiff_load): Omit no-longer-needed casts.
1432 (Fimagemagick_types): Don't assume size fits into 'int'.
1433
3cc5a532
PE
1434 Improve hashing quality when configured --with-wide-int.
1435 * fns.c (hash_string): New function, taken from sxhash_string.
1436 Do not discard information about ASCII character case; this
1437 discarding is no longer needed.
1438 (sxhash-string): Use it. Change sig to match it. Caller changed.
1439 * lisp.h: Declare it.
1440 * lread.c (hash_string): Remove, since we now use fns.c's version.
1441 The fns.c version returns a wider integer if --with-wide-int is
1442 specified, so this should help the quality of the hashing a bit.
1443
b312a492
PE
1444 * emacs.c: Integer overflow minor fix.
1445 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1446 Define only if GNU_LINUX.
1447 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1448
dfd153ae
PE
1449 * dispnew.c: Integer signedness and overflow fixes.
1450 Remove unnecessary forward decls, that were a maintenance hassle.
1451 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1452 All uses changed.
1453 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1454 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1455 (prepare_desired_row, line_draw_cost):
1456 Use int, not unsigned, where either works.
1457 (save_current_matrix, restore_current_matrix):
1458 Use ptrdiff_t, not size_t, where either works.
1459 (init_display): Check for overflow more accurately, and without
1460 relying on undefined behavior.
1461
a81d11a3
PE
1462 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1463 Remove, replacing with the new symbols in lisp.h. All uses changed.
1464 * fileio.c (make_temp_name):
1465 * filelock.c (lock_file_1, lock_file):
1466 * xdisp.c (message_dolog):
1467 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1468 Use pMd etc. instead.
1469 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1470 replacing the pWIDE etc. symbols removed from editfns.c.
1471
3300e6fd
PE
1472 * keyboard.h (num_input_events): Now uintmax_t.
1473 This is (very slightly) less likely to mess up due to wraparound.
1474 All uses changed.
1475
fd05c7e9
PE
1476 * buffer.c: Integer signedness fixes.
1477 (alloc_buffer_text, enlarge_buffer_text):
1478 Use ptrdiff_t rather than size_t when either will do, as we prefer
1479 signed integers.
1480
903fe15d
PE
1481 * alloc.c: Integer signedness and overflow fixes.
1482 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1483 (__malloc_size_t): Default to size_t, not to int.
1484 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1485 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1486 Prefer ptrdiff_t to size_t when either would do, as we prefer
1487 signed integers.
1488 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1489 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1490 Now const. Initialize with values that are in range even if char
1491 is signed.
1492 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1493 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1494 These functions do the right thing with sizes > 2**32.
1495 (check_depth): Now ptrdiff_t, not int.
1496 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1497 Adjust to new way of storing sizes. Check for size overflow bugs
1498 in rest of code.
1499 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1500 slightly wrong anyway, as it missed one instance of
1501 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1502 (refill_memory_reserve): Omit needless cast to size_t.
1503 (mark_object_loop_halt): Mark as externally visible.
1504
ac82cc6a
PE
1505 * xselect.c: Integer signedness and overflow fixes.
1506 (Fx_register_dnd_atom, x_handle_dnd_message):
1507 Use ptrdiff_t, not size_t, since we prefer signed.
1508 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1509 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1510 x_dnd_atoms_size and x_dnd_atoms_length.
1511
c2d1e36d
PE
1512 * doprnt.c: Prefer signed to unsigned when either works.
1513 * eval.c (verror):
1514 * doprnt.c (doprnt):
1515 * lisp.h (doprnt):
1516 * xdisp.c (vmessage):
1517 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1518 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1519 prefer signed arithmetic to avoid comparison confusion.
1520 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1521 but is a bit tricky.
1522
0e926e56
PE
1523 Assume freestanding C89 headers, string.h, stdlib.h.
1524 * data.c, doprnt.c, floatfns.c, print.c:
1525 Include float.h unconditionally.
1526 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1527 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1528 * regex.c: Likewise for stddef.h, string.h.
1529 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1530 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1531 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1532 (STDC_HEADERS): Remove obsolete defines.
1533 * sysdep.c: Include limits.h unconditionally.
1534
9cfdb3ec
PE
1535 Assume support for memcmp, memcpy, memmove, memset.
1536 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1537 * regex.c (memcmp, memcpy):
1538 Remove; we assume C89 now.
1539
1540 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1541 (__malloc_safe_bcopy): Remove; no longer needed.
1542
cf950e6b 1543 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1544 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1545 well either way, and we prefer signed to unsigned.
1546
dbf38e02
LMI
15472011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1548
1549 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1550 closes the connection while we're reading (bug#9182).
1551
d6f0886c 15522011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 1553
d6f0886c
JD
1554 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1555 are specified (Bug#9168).
24e0f6b1 1556
2eb1f9e6
PE
15572011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1558
1559 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1560 Found by GCC static checking and --with-wide-int on a 32-bit host.
1561
22381272 15622011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1563
1564 * xdisp.c (compute_display_string_pos): Fix logic of caching
1565 previous display string position. Initialize cached_prev_pos to
1566 -1. Fixes slow-down at the beginning of a buffer.
1567
f25e39b4
EZ
15682011-07-24 Eli Zaretskii <eliz@gnu.org>
1569
1570 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1571 for attrs[LFACE_FONTSET_INDEX].
1572
04c4b52e
PE
15732011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1574
1575 * xml.c (parse_region): Remove unused local
1576 that was recently introduced.
1577
c1734fbd
EZ
15782011-07-23 Eli Zaretskii <eliz@gnu.org>
1579
be18c5a5
EZ
1580 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1581 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1582
c1734fbd
EZ
1583 * xdisp.c (move_it_in_display_line_to): Record the best matching
1584 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1585 exit if none of the characters scanned was an exact match.
1586 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1587 when exact match is impossible due to invisible text, and the
1588 lines are truncated.
1589
a258d627
JD
15902011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1591
1592 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1593 for OSX >= 10.7.
1594
b6d5a689
EZ
15952011-07-22 Eli Zaretskii <eliz@gnu.org>
1596
0f74f785
EZ
1597 Fix a significant slow-down of cursor motion with C-n, C-p,
1598 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1599 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1600 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1601 (next_element_from_buffer): Call compute_stop_pos_backwards to
1602 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1603 base_level_stop.
1604 (reseat): Don't look for prev_stop, as that could mean a very long
1605 run.
1606 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1607 <cached_disp_overlay_modiff>: Cache for last found display string
1608 position.
551918c1 1609 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1610 about the same buffer in the same area of character positions, and
1611 the buffer wasn't changed since the time the display string
1612 position was cached.
551918c1 1613
b2d0c91a
EZ
16142011-07-22 Eli Zaretskii <eliz@gnu.org>
1615
1616 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1617 is an integer, which is important for empty lines. (Bug#9149)
1618
043604ee
CY
16192011-07-22 Chong Yidong <cyd@stupidchicken.com>
1620
1621 * frame.c (Fmodify_frame_parameters): In tty case, update the
1622 default face if necessary (Bug#4238).
1623
da4adb04
CY
16242011-07-21 Chong Yidong <cyd@stupidchicken.com>
1625
1626 * editfns.c (Fstring_to_char): No need to explain what a character
1627 is in the docstring (Bug#6576).
1628
9abd0532
LMI
16292011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1630
1631 * xml.c (parse_region): Make sure we always return a tree.
1632
36881d16
HK
16332011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1634
1635 * xml.c (parse_region): If a document contains only comments,
1636 return that, too.
1637
1e98674d
LMI
16382011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1639
1640 * xml.c (make_dom): Return comments, too.
1641
590bd467
PE
16422011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1643
1644 Port to OpenBSD.
1645 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1646 and the surrounding thread.
1647 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1648 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1649 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1650 timer goes off.
1651 * s/openbsd.h (BROKEN_SIGIO): Define.
1652 * unexelf.c (unexec) [__OpenBSD__]:
1653 Don't update the .mdebug section of the Alpha COFF symbol table.
1654
f41628b2
LMI
16552011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1656
1657 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1658 (bug#8460).
1659
b59b67c5
PE
16602011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1661
15e3a074
PE
1662 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1663 This fixes some race conditions on the permissions of any newly
1664 created file.
1665
41bed37d
PE
1666 * alloc.c (valid_pointer_p): Use pipe, not open.
1667 This fixes some permissions issues when debugging.
1668
b59b67c5
PE
1669 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1670 If fchown fails to set both uid and gid, try to set just gid,
1671 as that is sometimes allowed. Adjust the file's mode to eliminate
1672 setuid or setgid bits that are inappropriate if fchown fails.
1673
925a6be7
SM
16742011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1675
1676 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1677 to compare Lisp_Objects.
1678 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1679 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1680 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1681
52968808
AS
16822011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1683
0a6a104b
AS
1684 * lread.c (read_integer): Unread even EOF character.
1685 (read1): Likewise. Properly record start position of symbol.
1686
52968808
AS
1687 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1688 symbol character follows.
1689
9e381cdd
PE
16902011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1691
1692 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1693 This works around a problem with the previous change to Fcopy_file.
1694 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1695 and without this change, GCC might complain about discarding
1696 fchown's return value.
1697
b5641435
JB
16982011-07-16 Juanma Barranquero <lekktu@gmail.com>
1699
1700 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1701
a8031457
PE
17022011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1703
1704 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1705
dd889327
LMI
17062011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1707
750c33f7
LMI
1708 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1709 it's used from the C level.
1710
dd889327
LMI
1711 * process.c: Use the same condition for POLL_FOR_INPUT in both
1712 keyboard.c and process.c (bug#1858).
1713
87e86684
LM
17142011-07-09 Lawrence Mitchell <wence@gmx.li>
1715
1716 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1717 (Fgnutls_boot): Use it.
1718
64348f40
AS
17192011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1720
1721 * doc.c (Fsubstitute_command_keys): Revert last change.
1722
1d698799
LMI
17232011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1724
f863868c
LMI
1725 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1726 quotes the next character, and doesn't affect other longer
1727 sequences (bug#8935).
1728
1d698799
LMI
1729 * lread.c (syms_of_lread): Clarify that is isn't only
1730 `eval-buffer' and `eval-defun' that's affected by
1731 `lexical-binding' (bug#8460).
1732
aa4b6df6
EZ
17332011-07-15 Eli Zaretskii <eliz@gnu.org>
1734
1735 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1736 bidi redisplay when a line includes both an image and is
1737 truncated.
1738
5d856da6
PE
17392011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1740
ad6042bb
PE
1741 Fix minor problems found by static checking.
1742 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1743 (elsz): Now a signed constant, not a size_t var. We prefer signed
1744 types to unsigned, to avoid integer comparison confusion. Without
1745 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1746 "cannot optimize loop, the loop counter may overflow", a symptom
1747 of the confusion.
f00bbb22 1748 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1749 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1750
6468f31c
LMI
17512011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1752
49080b10
LMI
1753 * search.c (Fre_search_backward): Mention `case-fold-search' in
1754 all the re_search_* functions (bug#8138).
1755
6468f31c
LMI
1756 * keyboard.c (Fopen_dribble_file): Document when the file is
1757 closed (bug#8056).
1758
c965adc5
EZ
17592011-07-14 Eli Zaretskii <eliz@gnu.org>
1760
df9733bf
EZ
1761 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1762 bidi_cache_idx.
1763
0bb23927
EZ
1764 Support bidi reordering of display and overlay strings.
1765 * xdisp.c (compute_display_string_pos)
1766 (compute_display_string_end): Accept additional argument STRING.
1767 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1768 (reseat_to_string): Initialize bidi_it->string.s and
1769 bidi_it->string.schars.
1770 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1771 NULL (avoids a crash in bidi_paragraph_init).
1772 Initialize itb.string.lstring.
0bb23927
EZ
1773 (init_iterator): Call bidi_init_it only of a valid
1774 buffer position was specified. Initialize paragraph_embedding to
1775 L2R.
1776 (reseat_to_string): Initialize the bidi iterator.
1777 (display_string): If we need to ignore text properties of
1778 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1779 original value of -1 will not work with bidi.)
1780 (compute_display_string_pos): First arg is now struct
1781 `text_pos *'; all callers changed. Support display properties on
1782 Lisp strings.
1783 (compute_display_string_end): Support display properties on Lisp
1784 strings.
1785 (init_iterator, reseat_1, reseat_to_string): Initialize the
1786 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1787 when iterating on a string not from display properties).
640c8776
SM
1788 (compute_display_string_pos, compute_display_string_end):
1789 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1790 arrow keys.
1791 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1792 base_level_stop; instead, set base_level_stop to BEGV.
1793 Fixes crashes in vertical-motion.
0bb23927
EZ
1794 (next_element_from_buffer): Improve commentary for when
1795 the iterator is before prev_stop.
1796 (init_iterator): Initialize bidi_p from the default value of
1797 bidi-display-reordering, not from buffer-local value. Use the
1798 buffer-local value only if initializing for buffer iteration.
1799 (handle_invisible_prop): Support invisible properties on strings
1800 that are being bidi-reordered.
1801 (set_iterator_to_next): Support bidi reordering of C strings and
1802 Lisp strings.
1803 (next_element_from_string): Support bidi reordering of Lisp
1804 strings.
1805 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1806 (display_string): Support display of R2L glyph rows.
1807 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1808 (init_iterator): Don't initialize it->bidi_p for strings
1809 here.
1810 (reseat_to_string): Initialize it->bidi_p for strings here.
1811 (next_element_from_string, next_element_from_c_string)
1812 (next_element_from_buffer): Add xassert's for correspondence
1813 between IT's object being iterated and it->bidi_it.string
1814 structure.
1815 (face_before_or_after_it_pos): Support bidi iteration.
1816 (next_element_from_c_string): Handle the case of the first string
1817 character that is not the first one in the visual order.
1818 (get_visually_first_element): New function, refactored from common
1819 parts of next_element_from_buffer, next_element_from_string, and
1820 next_element_from_c_string.
1821 (tool_bar_lines_needed, redisplay_tool_bar)
1822 (display_menu_bar): Force left-to-right direction. Add a FIXME
1823 comment for making that be controlled by a user option.
1824 (push_it, pop_it): Save and restore the state of the
1825 bidi iterator. Save and restore the bidi_p flag.
1826 (pop_it): Iterate out of display property for string iteration as
1827 well.
1828 (iterate_out_of_display_property): Support iteration over strings.
1829 (handle_single_display_spec): Set up it->bidi_it for iteration
1830 over a display string, and call bidi_init_it.
1831 (handle_single_display_spec, next_overlay_string)
1832 (get_overlay_strings_1, push_display_prop): Set up the bidi
1833 iterator for displaying display or overlay strings.
1834 (forward_to_next_line_start): Don't use the shortcut if
1835 bidi-iterating.
1836 (back_to_previous_visible_line_start): If handle_display_prop
1837 pushed the iterator stack, restore the internal state of the bidi
1838 iterator by calling bidi_pop_it same number of times.
1839 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1840 and we are bidi-iterating, don't decrement the iterator position;
1841 instead, set the first_elt flag in the bidi iterator, to produce
1842 the same effect.
1843 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1844 (push_display_prop): xassert that we are iterating a buffer.
1845 (push_it, pop_it): Save and restore paragraph_embedding member.
1846 (handle_single_display_spec, next_overlay_string)
1847 (get_overlay_strings_1, reseat_1, reseat_to_string)
1848 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1849 correctly. Don't assume unibyte strings are not bidi-reordered.
1850 (compute_display_string_pos)
1851 (compute_display_string_end): Fix handling the case of C string.
1852 (push_it, pop_it): Save and restore from_disp_prop_p.
1853 (handle_single_display_spec, push_display_prop): Set the
1854 from_disp_prop_p flag.
1855 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1856 (pop_it): Call iterate_out_of_display_property only if we are
1857 popping after iteration over a string that came from a display
1858 property. Fix a typo in popping stretch info. Add an assertion
1859 for verifying that the iterator position is in sync with the bidi
1860 iterator.
1861 (handle_single_display_spec, get_overlay_strings_1)
1862 (push_display_prop): Fix initialization of paragraph direction for
1863 string when that of the parent object is not yet determined.
1864 (reseat_1): Call bidi_init_it to resync the bidi
1865 iterator with IT's position. (Bug#7616)
1866 (find_row_edges): If ROW->start.pos gives position
1867 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1868 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1869 Reset the from_disp_prop_p flag.
1870 (SAVE_IT, RESTORE_IT): New macros.
1871 (pos_visible_p, face_before_or_after_it_pos)
1872 (back_to_previous_visible_line_start)
1873 (move_it_in_display_line_to, move_it_in_display_line)
1874 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1875 (try_scrolling, redisplay_window, display_line): Use them when
1876 saving a temporary copy of the iterator and restoring it back.
1877 (back_to_previous_visible_line_start, reseat_1)
1878 (init_iterator): Empty the bidi cache "stack".
1879 (move_it_in_display_line_to): If iterator ended up at
1880 EOL, but we never saw any buffer positions smaller than
1881 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1882 motion in bidi-reordered lines.
1883 (move_it_in_display_line_to): Record prev_method and prev_pos
1884 immediately before the call to set_iterator_to_next. Fixes cursor
1885 motion in bidi-reordered lines with stretch glyphs and strings
1886 displayed in margins. (Bug#8133) (Bug#8867)
1887 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1888 TO_CHARPOS.
640c8776
SM
1889 (pos_visible_p): Support positions in bidi-reordered lines.
1890 Save and restore bidi cache.
0bb23927
EZ
1891
1892 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1893 (bidi_paragraph_info): Delete unused struct.
1894 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1895 (bidi_cache_start): New variable.
1896 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1897 to zero.
1898 (bidi_cache_fetch_state, bidi_cache_search)
1899 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1900 (bidi_cache_find, bidi_peek_at_next_level)
1901 (bidi_level_of_next_char, bidi_find_other_level_edge)
1902 (bidi_move_to_visually_next): Compare cache index with
1903 bidi_cache_start rather than with zero.
1904 (bidi_fetch_char): Accept new argument STRING; all callers
1905 changed. Support iteration over a string. Support strings with
1906 display properties. Support unibyte strings. Fix the type of
1907 `len' according to what STRING_CHAR_AND_LENGTH expects.
1908 (bidi_paragraph_init, bidi_resolve_explicit_1)
1909 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1910 (bidi_level_of_next_char, bidi_move_to_visually_next):
1911 Support iteration over a string.
0bb23927
EZ
1912 (bidi_set_sor_type, bidi_resolve_explicit_1)
1913 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1914 can now be zero (for strings); special values 0 and -1 were
1915 changed to -1 and -2, respectively.
1916 (bidi_char_at_pos): New function.
1917 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1918 Call it instead of FETCH_MULTIBYTE_CHAR.
1919 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1920 initialized to valid values.
1921 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1922 values.
1923 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1924 the test for valid cached positions. Fix the logic for looking up
1925 the sentinel state in the cache. GCPRO the Lisp string we are
1926 iterating.
1927 (bidi_push_it, bidi_pop_it): New functions.
1928 (bidi_initialize): Initialize the bidi cache start stack pointer.
1929 (bidi_cache_ensure_space): New function, refactored from part of
1930 bidi_cache_iterator_state. Don't assume the required size is just
1931 one BIDI_CACHE_CHUNK away.
1932 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1933 (bidi_count_bytes, bidi_char_at_pos): New functions.
1934 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1935 always valid if bidi_cache_idx is valid.
1936 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1937 is valid if it's going to be used.
1938 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1939 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1940 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1941 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1942 (bidi_find_other_level_edge, bidi_cache_start_stack):
1943 All variables related to cache indices are now EMACS_INT.
c965adc5 1944
0bb23927
EZ
1945 * dispextern.h (struct bidi_string_data): New structure.
1946 (struct bidi_it): New member `string'. Make flag members be 1-bit
1947 fields, and put them last in the struct.
640c8776
SM
1948 (compute_display_string_pos, compute_display_string_end):
1949 Update prototypes.
0bb23927
EZ
1950 (bidi_push_it, bidi_pop_it): Add prototypes.
1951 (struct iterator_stack_entry): New members bidi_p,
1952 paragraph_embedding, and from_disp_prop_p.
1953 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1954 (bidi_shelve_cache, bidi_unshelve_cache):
1955 Declare prototypes.
0bb23927
EZ
1956
1957 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1958 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1959 and vector-like objects.
1960
1961 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1962 cache around display iteration.
1963
1964 * window.c (Fwindow_end, window_scroll_pixel_based)
1965 (displayed_window_lines, Frecenter): Save and restore the bidi
1966 cache around display iteration.
1967
3bbd2265
LMI
19682011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1969
1970 * editfns.c (Fdelete_region): Clarify the use of the named
1971 parameters (bug#6788).
1972
adc47434
MR
19732011-07-14 Martin Rudalics <rudalics@gmx.at>
1974
1975 * indent.c (Fvertical_motion): Set and restore w->pointm when
1976 saving and restoring the window's buffer (Bug#9006).
1977
837c31f8
LMI
19782011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1979
1980 * editfns.c (Fstring_to_char): Clarify just what is returned
1981 (bug#6576). Text by Eli Zaretskii.
1982
ac389d0c
JB
19832011-07-13 Juanma Barranquero <lekktu@gmail.com>
1984
1985 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1986
0be0ce47
EZ
19872011-07-13 Eli Zaretskii <eliz@gnu.org>
1988
1989 * buffer.c (mmap_find): Fix a typo.
1990
cd18e7e3
JB
19912011-07-13 Johan Bockgård <bojohan@gnu.org>
1992
1993 Fix execution of x selection hooks.
1994 * xselect.c (Qx_lost_selection_functions)
1995 (Qx_sent_selection_functions): New vars.
1996 (syms_of_xselect): DEFSYM them.
1997 (x_handle_selection_request): Pass Qx_sent_selection_functions
1998 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1999 (x_handle_selection_clear,x_clear_frame_selections):
2000 Pass Qx_lost_selection_functions rather than
2001 Vx_lost_selection_functions to Frun_hook_with_args.
2002
47ea7f44
PE
20032011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2004
ac389d0c 2005 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2006 The old code sometimes used this field without initializing it.
2007
47ea7f44
PE
2008 * alloc.c (gc_sweep): Don't read past end of array.
2009 In theory, the old code could also have corrupted Emacs internals,
2010 though it'd be very unlikely.
2011
bc985c87
AS
20122011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2013
2014 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2015 argument. (Bug#4026)
bc985c87 2016
0cf34688
LMI
20172011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2018
b3dadd76
LMI
2019 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2020 key" (bug#4257).
2021
0cf34688
LMI
2022 * window.c (Fset_window_start): Doc fix (bug#4199).
2023 (Fset_window_hscroll): Ditto.
2024
270768cd
PE
20252011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2026
077e3dda 2027 Fix minor new problems caught by GCC 4.6.1.
270768cd 2028 * term.c (init_tty): Remove unused local.
490011a6 2029 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2030 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2031 not used otherwise.
270768cd 2032
b1f58454
CY
20332011-07-12 Chong Yidong <cyd@stupidchicken.com>
2034
2035 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2036
22b9578d
LMI
20372011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2038
6e70ab07
LMI
2039 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2040 are the mini-buffer and the echo area (bug#3320).
2041
22b9578d
LMI
2042 * term.c (init_tty): Remove support for supdup, c10 and perq
2043 terminals, which are no longer supported (bug#1482).
2044
8974cc9f
JB
20452011-07-10 Johan Bockgård <bojohan@gnu.org>
2046
2047 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2048
a560d974
JD
20492011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2050
2051 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2052 for non-popups (Bug#3642).
2053
1dae0f0a
AS
20542011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2055
268c2c36 2056 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2057 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2058 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2059 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2060 * data.c (fmod): Likewise.
2061 * dispnew.c (swap_glyphs_in_rows): Likewise.
2062 * emacs.c (memory_warning_signal): Likewise.
2063 * floatfns.c (float_error): Likewise.
2064 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2065 (otf_open, font_otf_capability, generate_otf_features)
2066 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2067 Likewise.
2068 * image.c (pbm_read_file): Likewise.
2069 * indent.c (string_display_width): Likewise.
2070 * intervals.c (check_for_interval, search_for_interval)
2071 (inc_interval_count, count_intervals, root_interval)
2072 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2073 * lread.c (defalias): Likewise.
268c2c36 2074 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2075 * regex.c (set_image_of_range_1, set_image_of_range)
2076 (regex_grow_registers): Likewise.
2077 * sysdep.c (strerror): Likewise.
2078 * termcap.c (valid_filename_p, tprint, main): Likewise.
2079 * tparam.c (main): Likewise.
2080 * unexhp9k800.c (run_time_remap, save_data_space)
2081 (update_file_ptrs, read_header, write_header, calculate_checksum)
2082 (copy_file, copy_rest, display_header): Likewise.
2083 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2084 Likewise.
2085 * xdisp.c (check_it): Likewise.
2086 * xfaces.c (register_color, unregister_color, unregister_colors):
2087 Likewise.
2088 * xfns.c (print_fontset_result): Likewise.
2089 * xrdb.c (member, fatal, main): Likewise.
2090
99033785
PE
20912011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2092
2093 Fix minor problems found by static checking (Bug#9031).
2094 * chartab.c (char_table_set_range, map_sub_char_table):
2095 Remove unused locals.
2096 (uniprop_table): Now static.
2097 * composite.c (_work_char): Remove unused static var.
2098
9cb2ac56
JB
20992011-07-09 Juanma Barranquero <lekktu@gmail.com>
2100
2101 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2102
f25661f0
JD
21032011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2104
2105 * gtkutil.c (qttip_cb): Remove code without function.
2106
8278c4fe
EZ
21072011-07-09 Eli Zaretskii <eliz@gnu.org>
2108
2109 * w32.c (pthread_sigmask): New stub.
2110
1692ae2d 21112011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2112
8a6ebd58 2113 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2114 sigprocmask is portable only for single-threaded applications, and
2115 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2116 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2117 (LIBES): Use it.
2118 * callproc.c (Fcall_process):
2119 * process.c (create_process):
2120 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2121 Use pthread_sigmask, not sigprocmask.
123403e4 2122
1b854618
JD
21232011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2124
2125 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2126 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2127 wrong (Bug#8591).
2128
3fe4b549
JD
21292011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2130
0ce7e563
JD
2131 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2132 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2133 (xg_hide_tooltip): Fix comment.
2134
3fe4b549
JD
2135 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2136 in registerServicesMenuSendTypes.
2137 (validRequestorForSendType): Don't check ns_return_types.
2138
2139 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2140 ns_return_type.
2141
5df75e47
JR
21422011-07-08 Jason Rumney <jasonr@gnu.org>
2143
2144 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2145 frame struct members of non-existent frames (Bug#6284).
2146
699c10bd
JD
21472011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2148
4393663b
JD
2149 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2150 variable firstTime not needed on OSX >= 10.6.
2151 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2152 >= 10.5. Use setKnobProportion, setDoubleValue.
2153
2154 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2155 (MAC_OS_X_VERSION_10_5): Define if not defined.
2156 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2157 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2158 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2159
2160 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2161 cString and lossyCString on OSX >= 10.4
2162
2163 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2164 sizeToFit on OSX >= 10.2.
2165
2166 * nsimage.m (allocInitFromFile): Don't use deprecated method
2167 bestRepresentationForDevice on OSX >= 10.6.
2168
2169 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2170 to avoid warning.
2171
2172 * emacs.c: Declare unexec_init_emacs_zone.
2173
a63e0781
JD
2174 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2175
699c10bd
JD
2176 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2177
2178 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2179 on svcsMenu (Bug#8842).
2180
2181 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2182 ns_return_types.
2183 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2184
2185 * nsterm.m (QUTF8_STRING): Declare.
2186 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2187 (validRequestorForSendType): Return type is (id).
2188 Change indexOfObjectIdenticalTo to indexOfObject.
2189 Check if we have local selection before returning self (Bug#8842).
2190 (writeSelectionToPasteboard): Put local selection into paste board
2191 if we have a local selection (Bug#8842).
2192 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2193
2194 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2195 (ns_get_local_selection): Declare.
2196
54e10184
LMI
21972011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2198
9888ff71
LMI
2199 * keymap.c (describe_map_tree): Don't insert a double newline at
2200 the end of the buffer (bug#1169) and return whether we inserted
2201 something.
2202
54e10184
LMI
2203 * callint.c (Fcall_interactively): Change "reading args" to
2204 "providing args" to try to clarify what it does (bug#1010).
2205
15fa4783
KH
22062011-07-07 Kenichi Handa <handa@m17n.org>
2207
2208 * composite.c (composition_compute_stop_pos): Ignore a static
2209 composition starting before CHARPOS (Bug#8915).
2210
2211 * xdisp.c (handle_composition_prop): Likewise.
2212
a8815b00
EZ
22132011-07-07 Eli Zaretskii <eliz@gnu.org>
2214
2215 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2216 (Bug#9015)
2217
ef7b981d 22182011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2219
2220 * character.h (unicode_category_t): New enum type.
2221
2222 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2223 (Qchar_code_property_table): New variable.
2224 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2225 (UNIPROP_COMPRESSED_FORM_P): New macros.
2226 (char_table_ascii): Uncompress the compressed values.
2227 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2228 Uncompress the compressed values.
ac389d0c 2229 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2230 (char_table_ref_and_range): Uncompress the compressed values.
2231 (sub_char_table_set): New arg is_uniprop. Callers changed.
2232 Uncompress the compressed values.
2233 (sub_char_table_set_range): Args changed. Callers changed.
2234 (char_table_set_range): Adjuted for the above change.
2235 (map_sub_char_table): Delete args default_val and parent. Add arg
2236 top. Give decoded values to a Lisp function.
640c8776 2237 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2238 values to a Lisp function. Gcpro more variables.
2239 (uniprop_table_uncompress)
2240 (uniprop_decode_value_run_length): New functions.
2241 (uniprop_decoder, uniprop_decoder_count): New variables.
2242 (uniprop_get_decoder, uniprop_encode_value_character)
2243 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2244 New functions.
2245 (uniprop_encoder, uniprop_encoder_count): New variables.
2246 (uniprop_get_encoder, uniprop_table)
2247 (Funicode_property_table_internal, Fget_unicode_property_internal)
2248 (Fput_unicode_property_internal): New functions.
2249 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2250 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2251 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2252 char-code-property-alist.
2253
640c8776 2254 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2255 Vunicode_category_table.
2256
640c8776 2257 * font.c (font_range): Adjust for the change of
c805dec0
KH
2258 Vunicode_category_table.
2259
76b397fb
DN
22602011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2261
2262 * m/iris4d.h: Remove file, move contents ...
2263 * s/irix6-5.h: ... here.
2264
22b4128e
PE
22652011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2266
2267 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2268 * alloc.c (mark_buffer):
2269 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2270 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2271 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2272 This isn't true in general, and it's particularly not true
2273 if Emacs is configured with --with-wide-int.
2274 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2275 New macros, used in the buffer.c change.
2276
869795d6
JD
22772011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2278
2279 * xsettings.c: Use both GConf and GSettings if both are available.
2280 (store_config_changed_event): Add comment.
2281 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2282 (store_tool_bar_style_changed): New functions.
5e617bc2 2283 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2284 (struct xsettings): Move font inside HAVE_XFT.
2285 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2286 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2287 Move inside HAVE_XFT.
640c8776 2288 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2289 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2290 also.
2291 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2292 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2293 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2294 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2295 (parse_settings): Move check for font inside HAVE_XFT.
2296 (read_settings, apply_xft_settings): Add comment.
2297 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2298 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2299 call store_font_name_changed.
2300 (xft_settings_event): Add comment.
2301 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2302 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2303 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2304 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2305 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2306 (xsettings_get_system_font, xsettings_get_system_normal_font):
2307 Add comment.
869795d6 2308
d8ed26bd
PE
23092011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2310
2311 Random fixes. E.g., (random) never returned negative values.
2312 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2313 subseconds part to the entropy, as that's a bit more random.
2314 Prefer signed to unsigned, since the signedness doesn't matter and
2315 in general we prefer signed. When given a limit, use a
2316 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2317 latter isn't right if USE_2_TAGS_FOR_INTS.
2318 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2319 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2320
cabf1cac
SM
23212011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2322
2323 * textprop.c (text_property_stickiness):
2324 Obey Vtext_property_default_nonsticky.
2325 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2326 * w32fns.c (syms_of_w32fns):
2327 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2328
6e9b2be9
PE
23292011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2330
2331 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2332 This is more efficient than Ffile_directory_p and avoids a minor race.
2333
90186c68
LMI
23342011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2335
7c301272
LMI
2336 * buffer.c (Foverlay_put): Say what the return value is
2337 (bug#7835).
2338
c4f2d8d4
LMI
2339 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2340 is a directory before asking whether to use the file name
2341 (bug#7564).
ad637907
LMI
2342 (barf_or_query_if_file_exists): Make the "File is a directory"
2343 error be more correct.
c4f2d8d4 2344
90186c68
LMI
2345 * fns.c (Frequire): Remove the mention of the .gz files, since
2346 that's installation-specific, but keep the mention of
2347 `get-load-suffixes'.
2348
da64016e
PE
23492011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2350
2351 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2352 Report string overflow if the output is too long.
2353
7d47b580
JB
23542011-07-04 Juanma Barranquero <lekktu@gmail.com>
2355
a555cb87
JB
2356 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2357 (syms_of_gnutls): Remove duplicate DEFSYM for
2358 Qgnutls_bootprop_verify_hostname_error, an error for
2359 Qgnutls_bootprop_verify_error (which is no longer used).
2360
7d47b580
JB
2361 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2362 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2363 Also (re)move comments that are misplaced or no longer relevant.
2364
1e49bfab
LMI
23652011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2366
2367 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2368
1485f4c0
CY
23692011-07-03 Chong Yidong <cyd@stupidchicken.com>
2370
2371 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2372 and background color parameters if they have been changed.
2373
a9ab721e
LMI
23742011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2375
2376 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2377
cf7cff57
PE
23782011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2379
2e13213d
PE
2380 * xsettings.c (SYSTEM_FONT): Define only when used.
2381 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2382
cf7cff57
PE
2383 * keymap.c (access_keymap_1): Now static.
2384
7a8e04f7
CY
23852011-07-02 Chong Yidong <cyd@stupidchicken.com>
2386
2387 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2388 leave any prefix arg for the up event (Bug#1586).
2389
61352f62
LMI
23902011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2391
69bb1ef7
LMI
2392 * lread.c (syms_of_lread): Mention single symbols defined by
2393 `defvar' or `defconst' (bug#7154).
2394
61352f62 2395 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2396 (Frequire): Mention get-load-suffixes.
61352f62 2397
28545e04
MR
23982011-07-02 Martin Rudalics <rudalics@gmx.at>
2399
2400 * window.h (window): Remove clone_number slot.
2401 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2402 Remove.
2403 (make_parent_window, make_window, saved_window)
2404 (Fset_window_configuration, save_window_save): Don't deal with
2405 clone numbers.
2406 * buffer.c (Qclone_number): Remove declaration.
2407 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2408
3349e122
SM
24092011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2410
2411 Add multiple inheritance to keymaps.
2412 * keymap.c (Fmake_composed_keymap): New function.
2413 (Fset_keymap_parent): Simplify.
2414 (fix_submap_inheritance): Remove.
2415 (access_keymap_1): New function extracted from access_keymap to handle
2416 embedded parents and handle lists of maps.
2417 (access_keymap): Use it.
2418 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2419 (Fcopy_keymap): Handle embedded parents.
2420 (Fcommand_remapping, define_as_prefix): Simplify.
2421 (Fkey_binding): Simplify.
2422 (syms_of_keymap): Move minibuffer-local-completion-map,
2423 minibuffer-local-filename-completion-map,
2424 minibuffer-local-must-match-map, and
2425 minibuffer-local-filename-must-match-map to Elisp.
2426 (syms_of_keymap): Defsubr make-composed-keymap.
2427 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2428 (parse_menu_item): Trivial simplification.
2429
3279eb87
GM
24302011-07-01 Glenn Morris <rgm@gnu.org>
2431
2432 * Makefile.in (SETTINGS_LIBS): Fix typo.
2433
4550efdf
KI
24342011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2435
2436 * coding.c (Fencode_coding_string): Record the last coding system
2437 used, as the function doc string says (bug#8738).
2438
0949d2b6
JD
24392011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2440
2441 * xsettings.c (store_monospaced_changed): Take new font as arg and
2442 check for change against current_mono_font.
2443 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2444 (emacs_settings_constructor, emacs_settings_get_property)
2445 (emacs_settings_set_property, emacs_settings_class_init)
2446 (emacs_settings_init, gsettings_obj): Remove.
2447 (something_changedCB): New function for HAVE_GSETTINGS.
2448 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2449 with value as argument.
2450 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2451 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2452 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2453 "changed".
2454
2455 * xgselect.c: Add defined (HAVE_GSETTINGS).
2456 (xgselect_initialize): Ditto.
2457
2458 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2459 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2460 xg_select.
2461
bbc6b304
PE
24622011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2463
2464 * eval.c (struct backtrace): Simplify and port the data structure.
2465 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2466 signed bit field, as this assumption is not portable and it makes
2467 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2468 "char debug_on_exit : 1" as this is not portable either; instead,
2469 use the portable "unsigned int debug_on_exit : 1". Remove unused
2470 member evalargs. Remove obsolete comments about cc bombing out.
2471
9851bfc5
JD
24722011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2473
51bb811f 2474 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2475 Let HAVE_GSETTINGS override HAVE_GCONF.
2476 (store_monospaced_changed): New function.
2477 (EMACS_SETTINGS): A new type derived from GObject to handle
2478 GSettings notifications.
2479 (emacs_settings_constructor, emacs_settings_get_property)
2480 (emacs_settings_set_property, emacs_settings_class_init):
2481 New functions.
2482 (gsettings_client, gsettings_obj): New variables.
2483 (GSETTINGS_SCHEMA): New define.
2484 (something_changedCB): Call store_monospaced_changed.
2485 (init_gsettings): New function.
2486 (xsettings_initialize): Call init_gsettings.
2487 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2488 to NULL.
2489
640c8776 2490 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2491 GCONF_CFLAGS/LIBS.
2492
5386012d
MR
24932011-06-29 Martin Rudalics <rudalics@gmx.at>
2494
2495 * window.c (resize_root_window, grow_mini_window)
2496 (shrink_mini_window): Rename Qresize_root_window to
2497 Qwindow_resize_root_window and Qresize_root_window_vertically to
2498 Qwindow_resize_root_window_vertically.
2499
f13e0b08
PE
25002011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2501
2502 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2503
94515237
JB
25042011-06-27 Juanma Barranquero <lekktu@gmail.com>
2505
2506 * makefile.w32-in: Redesign dependencies so they reflect more
2507 clearly which files are directly included by each source file,
2508 and not through other includes.
2509
e43b6e43
MR
25102011-06-27 Martin Rudalics <rudalics@gmx.at>
2511
2512 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2513 (sort_overlays, overlay_strings): When an overlay's clone number
2514 matches the window's clone number process the overlay even if
2515 the overlay's window property doesn't match the current window.
2516
d68443dc
MR
2517 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2518 (Fwindow_hchild): Rename to Fwindow_left_child.
2519 (Fwindow_next): Rename to Fwindow_next_sibling.
2520 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2521 (resize_window_check): Rename to window_resize_check.
2522 (resize_window_apply): Rename to window_resize_apply.
2523 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2524 (Fdelete_other_windows_internal, resize_frame_windows)
2525 (Fsplit_window_internal, Fdelete_window_internal)
2526 (grow_mini_window, shrink_mini_window)
2527 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2528
c7e73be5
JD
25292011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2530
2531 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2532 (emacs_fixed_set_min_size): Remove.
2533 (emacs_fixed_new): Take frame as argument.
2534
2535 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2536 (_EmacsFixedPrivate): Remove minwidth/height.
2537 Add struct frame *f.
2538 (emacs_fixed_init): Initialize priv->f.
2539 (get_parent_class, emacs_fixed_set_min_size): Remove.
2540 (emacs_fixed_new): Set priv->f to argument.
2541 (emacs_fixed_get_preferred_width)
2542 (emacs_fixed_get_preferred_height): Use min_width/height from
2543 frames size_hint to set minimum and natural (Bug#8919).
2544 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2545 and use min_width/height from frames size_hint to set
2546 min_width/height (Bug#8919).
2547
2548 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2549 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2550 Fix indentation.
c7e73be5 2551
cf99dcf8
EZ
25522011-06-26 Eli Zaretskii <eliz@gnu.org>
2553
2554 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2555 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2556 called at ZV.
2557
029529ac
CY
25582011-06-26 Chong Yidong <cyd@stupidchicken.com>
2559
2560 * process.c (wait_reading_process_output): Bypass select if
2561 waiting for a cell while ignoring keyboard input, and input is
2562 pending. Suggested by Jan Djärv (Bug#8869).
2563
7a7ef429
PE
25642011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2565
2566 Use gnulib's dup2 module instead of rolling our own.
2567 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2568
11fdef7d 25692011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2570
2571 * dispnew.c (scrolling_window): Before scrolling, turn off a
2572 mouse-highlight in the window being scrolled.
2573
cd3520a4
JB
25742011-06-24 Juanma Barranquero <lekktu@gmail.com>
2575
2576 Move DEFSYM to lisp.h and use everywhere.
2577
2578 * character.h (DEFSYM): Move declaration...
2579 * lisp.h (DEFSYM): ...here.
2580
2581 * gnutls.c:
2582 * minibuf.c:
2583 * w32menu.c:
2584 * w32proc.c:
2585 * w32select.c: Don't include character.h.
2586
2587 * alloc.c (syms_of_alloc):
2588 * buffer.c (syms_of_buffer):
2589 * bytecode.c (syms_of_bytecode):
2590 * callint.c (syms_of_callint):
2591 * casefiddle.c (syms_of_casefiddle):
2592 * casetab.c (init_casetab_once):
2593 * category.c (init_category_once, syms_of_category):
2594 * ccl.c (syms_of_ccl):
2595 * cmds.c (syms_of_cmds):
2596 * composite.c (syms_of_composite):
2597 * dbusbind.c (syms_of_dbusbind):
2598 * dired.c (syms_of_dired):
2599 * dispnew.c (syms_of_display):
2600 * doc.c (syms_of_doc):
2601 * editfns.c (syms_of_editfns):
2602 * emacs.c (syms_of_emacs):
2603 * eval.c (syms_of_eval):
2604 * fileio.c (syms_of_fileio):
2605 * fns.c (syms_of_fns):
2606 * frame.c (syms_of_frame):
2607 * fringe.c (syms_of_fringe):
2608 * insdel.c (syms_of_insdel):
2609 * keymap.c (syms_of_keymap):
2610 * lread.c (init_obarray, syms_of_lread):
2611 * macros.c (syms_of_macros):
2612 * msdos.c (syms_of_msdos):
2613 * print.c (syms_of_print):
2614 * process.c (syms_of_process):
2615 * search.c (syms_of_search):
2616 * sound.c (syms_of_sound):
2617 * syntax.c (init_syntax_once, syms_of_syntax):
2618 * terminal.c (syms_of_terminal):
2619 * textprop.c (syms_of_textprop):
2620 * undo.c (syms_of_undo):
2621 * w32.c (globals_of_w32):
2622 * window.c (syms_of_window):
2623 * xdisp.c (syms_of_xdisp):
2624 * xfaces.c (syms_of_xfaces):
2625 * xfns.c (syms_of_xfns):
2626 * xmenu.c (syms_of_xmenu):
2627 * xsettings.c (syms_of_xsettings):
2628 * xterm.c (syms_of_xterm): Use DEFSYM.
2629
4228cf16
TZ
26302011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2631
cd3520a4 2632 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2633
7fcccf1e
PE
26342011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2635
7efb4e0e
PE
2636 Integer and buffer overflow fixes (Bug#8873).
2637
ff5844ad
PE
2638 * print.c (printchar, strout): Check for string overflow.
2639 (PRINTPREPARE, printchar, strout):
2640 Don't set size unless allocation succeeds.
2641
90532f02
PE
2642 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2643 for sizes. Check for string overflow more accurately.
2644 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2645
6d84508d
PE
2646 * macros.c: Integer and buffer overflow fixes.
2647 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2648 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2649 Use ptrdiff_t, not int, for sizes.
2650 Don't increment bufsize until after realloc succeeds.
2651 Check for size-calculation overflow.
2652 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2653
437b2cb4
PE
2654 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2655
8b9ac8b4
PE
2656 * lread.c: Integer overflow fixes.
2657 (read_integer): Radix is now EMACS_INT, not int,
2658 to improve quality of diagnostics for out-of-range radices.
2659 Calculate buffer size correctly for out-of-range radices.
2660 (read1): Check for integer overflow in radices, and in
2661 read-circle numbers.
82cb60d3
PE
2662 (read_escape): Avoid int overflow.
2663 (Fload, openp, read_buffer_size, read1)
2664 (substitute_object_recurse, read_vector, read_list, map_obarray):
2665 Use ptrdiff_t, not int, for sizes.
2666 (read1): Use EMACS_INT, not int, for sizes.
20270765 2667 Check for size overflow.
8b9ac8b4 2668
7fcccf1e
PE
2669 * image.c (cache_image): Check for size arithmetic overflow.
2670
bfbbd7e7
PE
2671 * lread.c: Integer overflow issues.
2672 (saved_doc_string_size, saved_doc_string_length)
2673 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2674 Now ptrdiff_t, not int.
2675 (read1): Don't assume doc string length fits in int. Check for
2676 out-of-range doc string lengths.
2677 (read_list): Don't assume file position fits in int.
39019e54 2678 (read_escape): Check for hex character overflow.
bfbbd7e7 2679
4e323265
LL
26802011-06-22 Leo Liu <sdl.web@gmail.com>
2681
2682 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2683 Move to minibuffer.el.
2684
85fece3e
PE
26852011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2686
20b84ce9 2687 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2688 The following patches are for when GLYPH_DEBUG && !XASSERT.
2689 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2690 * dispnew.c (flush_stdout):
2691 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2692 Mark as externally visible.
2693 * dispnew.c (check_window_matrix_pointers): Now static.
2694 * dispnew.c (window_to_frame_vpos):
2695 * xfns.c (unwind_create_frame):
2696 * xterm.c (x_check_font): Remove unused local.
2697 * scroll.c (CHECK_BOUNDS):
2698 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2699 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2700 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2701 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2702 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2703 Now static.
2704 (debug_method_add): Use va_list and vsprintf rather than relying
2705 on undefined behavior with wrong number of arguments.
2706 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2707 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2708 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2709 since we're not interested in debugging glyphs with old libraries.
2710 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2711 GCC 4.6.0's static checking.
2712
0766b489
PE
27132011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2714
31fd4b32
PE
2715 Integer overflow and signedness fixes (Bug#8873).
2716 A few related buffer overrun fixes, too.
2717
b79e8648
PE
2718 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2719
0766b489
PE
2720 * dispextern.h (struct face.stipple):
2721 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2722 (x_bitmap_mask, x_allocate_bitmap_record)
2723 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2724 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2725 (x_create_bitmap_from_xpm_data):
2726 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2727 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2728 (.bitmaps_last):
2729 * xfaces.c (load_pixmap):
2730 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2731 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2732 (.bitmaps_last, struct x_output.icon_bitmap):
2733 Use ptrdiff_t, not int, for bitmap indexes.
2734 (x_allocate_bitmap_record): Check for size overflow.
2735 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2736
b081724f
PE
2737 Use ptrdiff_t, not int, for overlay counts.
2738 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2739 * editfns.c (overlays_around, get_pos_property):
2740 * textprop.c (get_char_property_and_overlay):
2741 * xdisp.c (next_overlay_change, note_mouse_highlight):
2742 * xfaces.c (face_at_buffer_position):
21514da7
PE
2743 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2744 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2745 (Fnext_overlay_change, Fprevious_overlay_change)
2746 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2747 Use ptrdiff_t, not int, for sizes.
21514da7 2748 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2749
3de73e5e
PE
2750 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2751
2606c57b
PE
2752 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2753 (x_session_initialize): Do not assume string length fits in int.
2754
aaafe47a
PE
2755 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2756 This is unlikely, but can occur if DPI is outlandish.
2757
2674ddc8 2758 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2759 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2760
28154962
PE
2761 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2762 * xrdb.c (magic_file_p, search_magic_path):
2763 Omit last arg SUFFIX; it was always 0. All callers changed.
2764 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2765
7de51af5
PE
2766 * xfont.c (xfont_match): Avoid need for strlen.
2767
25ed6cc3
PE
2768 * xfns.c: Don't assume strlen fits in int.
2769 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2770
4eab31dd
PE
2771 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2772 not unsigned long, as we prefer signed integers. All callers changed.
2773 Detect integer overflow in repeat count.
2774 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2775 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2776
171e2a58
PE
2777 * termcap.c: Don't assume sizes fit in int and never overflow.
2778 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2779 (gobble_line): Check for size-calculation overflow.
2780
ad39faca 2781 * minibuf.c (Fread_buffer):
6e5bb2dc 2782 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2783 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2784 Don't assume string length fits in int.
2785
52c61c22 2786 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2787 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2788
b5b8c9e5
PE
2789 * font.c: Don't assume string length fits in int.
2790 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2791 Use ptrdiff_t, not int.
ccd6111c
PE
2792 (font_intern_prop): Don't assume string length fits in int.
2793 Don't assume integer property fits in fixnum.
2794 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2795
882f0d81 2796 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2797 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2798 Reformulate so as not to need the command string.
2799 Invoke gzip -cd rather than gunzip, as it's more portable.
2800 (lock_info_type, lock_file_1, lock_file):
2801 Don't assume pid_t and time_t fit in unsigned long.
2802 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2803 (current_lock_owner): Prefer signed type for sizes.
2804 Use memcpy, not strncpy, where memcpy is what is really wanted.
2805 Don't assume (via atoi) that time_t and pid_t fit in int.
2806 Check for time_t and/or pid_t out of range, e.g., via a network share.
2807 Don't alloca where an auto var works fine.
2808
93f4cf88
PE
2809 * fileio.c: Fix some integer overflow issues.
2810 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2811 Don't assume string length fits in int.
2812 (directory_file_name): Don't assume string length fits in long.
2813 (make_temp_name): Don't assume pid fits in int, or that its print
2814 length is less than 20.
2815
f3e92b69
PE
2816 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2817
1bfdaf10
PE
2818 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2819
35016e9a
PE
2820 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2821
3d1e65a1
PE
2822 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2823 We prefer signed integers, even for size calculations.
2824
0b963a93
PE
2825 * emacs.c: Don't assume string length fits in 'int'.
2826 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2827 (main): Don't invoke strlen when not needed.
2828
573f4b54
PE
2829 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2830 (XD_DEBUG_MESSAGE): Don't waste a byte.
2831
989f33ba
PE
2832 * callproc.c (getenv_internal_1, getenv_internal)
2833 (Fgetenv_internal):
965d34eb
PE
2834 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2835
e4d29b33
PE
2836 * lread.c (invalid_syntax): Omit length argument.
2837 All uses changed. This doesn't fix a bug, but it simplifies the
2838 code away from its former Hollerith-constant appearance, and it's
2839 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2840 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2841
eb49b136
PE
2842 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2843 This didn't break anything, but it didn't help either.
2844 It's confusing to put a bogus integer in a place where the actual
2845 value does not matter.
9f62aeb1 2846 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2847 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2848
15375a22
PE
2849 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2850 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2851 implementation.
b61cc01c
PE
2852 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2853 We prefer signed types, and the value cannot exceed the EMACS_INT
2854 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2855 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2856 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2857 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2858
53b2623d
PE
2859 * indent.c (sane_tab_width): New function.
2860 (current_column, scan_for_column, Findent_to, position_indentation)
2861 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2862 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2863
51cab52b 2864 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2865
f2ed8a70
PE
2866 * lisp.h (lint_assume): New macro.
2867 * composite.c (composition_gstring_put_cache):
2868 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2869
abe80cc6
PE
2870 * editfns.c, insdel.c:
2871 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2872
b02c740e
PE
2873 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2874
ebc96716
PE
2875 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2876
b4e50fa0 2877 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2878 Use much-faster test for byte-length change.
311d5d7c 2879 Don't assume string byte-length fits in 'int'.
a4cf38e4 2880 Check that character arg fits in 'int'.
85461888 2881 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2882
c0c1ee9f
PE
2883 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2884
a498d7f4
PE
2885 * fns.c (concat): Catch string overflow earlier.
2886 Do not rely on integer wraparound.
2887
51cab52b
PE
2888 * dispextern.h (struct it.overlay_strings_charpos)
2889 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2890 * xdisp.c (forward_to_next_line_start)
2891 (back_to_previous_visible_line_start)
2892 (reseat_at_next_visible_line_start, next_element_from_buffer):
2893 Don't arbitrarily truncate the value of 'selective' to int.
2894
76031fad
PE
2895 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2896
5eb55db9
PE
2897 * composite.c: Don't truncate sizes to 'int'.
2898 (composition_gstring_p, composition_reseat_it)
2899 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2900 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2901 not EMACS_UINT, for indexes.
5eb55db9 2902
0703a717
PE
2903 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2904
d6202519
PE
2905 * buffer.c: Include <verify.h>.
2906 (struct sortvec.priority, struct sortstr.priority):
8961a454 2907 Now EMACS_INT, not int.
c20998a7 2908 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2909 (struct sortstr.size, record_overlay_string)
2910 (struct sortstrlist.size, struct sortlist.used):
2911 Don't truncate size to int.
2912 (record_overlay_string): Check for size-calculation overflow.
d6202519 2913 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2914
d5a19415
JM
29152011-06-22 Jim Meyering <meyering@redhat.com>
2916
029529ac 2917 Don't leak an XBM-image-sized buffer
d5a19415
JM
2918 * image.c (xbm_load): Free the image buffer after using it.
2919
a9041e6c
PE
29202011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2921
2922 Port to Sun C.
2923 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2924 that Sun C diagnosed.
2925 * fns.c (secure_hash): Fix pointer signedness issue.
2926 * intervals.c (static_offset_intervals): New function.
2927 (offset_intervals): Use it.
2928
7f3f739f
LL
29292011-06-21 Leo Liu <sdl.web@gmail.com>
2930
2931 * deps.mk (fns.o):
2932 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2933 sha512.h.
2934
2935 * fns.c (secure_hash): Rename from crypto_hash_function and change
2936 the first arg to accept symbols.
5b66d427 2937 (Fsecure_hash): New primitive.
7f3f739f
LL
2938 (syms_of_fns): New symbols.
2939
76147d94
DD
29402011-06-20 Deniz Dogan <deniz@dogan.se>
2941
2942 * process.c (Fset_process_buffer): Clarify return value in
2943 docstring.
2944
7d7d0045
CY
29452011-06-18 Chong Yidong <cyd@stupidchicken.com>
2946
2947 * dispnew.c (add_window_display_history): Use BVAR.
2948
2949 * xdisp.c (debug_method_add): Use BVAR.
2950 (check_window_end, dump_glyph_matrix, dump_glyph)
2951 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2952
2953 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2954 Likewise.
2955
2956 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2957 check till after the cache is created in init_frame_faces.
2958
ff2bc410
SM
29592011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2960
2961 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2962
28177add
PE
29632011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2964
dd3482fe
PE
2965 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2966 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2967 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2968
393d71f3 2969 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2970 * fileio.c (Finsert_file_contents):
2971 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2972 Remove the old (too-loose) buffer overflow checks.
2973 They weren't needed, since make_gap checks for buffer overflow.
2974 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2975 The old code merely checked for Emacs fixnum overflow, and relied
2976 on undefined (wraparound) behavior. The new code avoids undefined
2977 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2978
2e6813b0 2979 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2980 Tune. Don't use wider integers than needed. Don't use alloca.
2981 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2982
599a9e4f
PE
2983 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2984
99561444
PE
2985 * insdel.c, lisp.h (buffer_overflow): New function.
2986 (insert_from_buffer_1, replace_range, replace_range_2):
2987 * insdel.c (make_gap_larger):
2988 * editfns.c (Finsert_char):
2989 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2990
28177add
PE
2991 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2992
e69dafad
PE
29932011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2994
a7af7fde 2995 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2996
b1c46f02
PE
2997 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2998 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2999
e69dafad
PE
3000 * fileio.c: Don't assume EMACS_INT fits in off_t.
3001 (emacs_lseek): New static function.
3002 (Finsert_file_contents, Fwrite_region): Use it.
3003 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3004
566684ea
PE
3005 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3006
e6966cd6
PE
3007 * fns.c: Don't overflow int when computing a list length.
3008 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3009 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3010 truncation on 64-bit hosts. Check for QUIT every
3011 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3012 faster and is responsive enough.
3013 (Flength): Report an error instead of overflowing an integer.
3014 (Fsafe_length): Return a float if the value is not representable
3015 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3016 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3017 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3018
dd0b0efb
PE
3019 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3020 (header_size, word_size): New constants.
3021 (allocate_vectorlike): Don't check size overflow here.
3022 (allocate_vector): Check it here instead, since this is the only
3023 caller of allocate_vectorlike that could cause overflow.
3024 Check that the new vector's length is representable as a fixnum.
3025
86fe5cfe
PE
3026 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3027 The previous code was bogus. For example, next_almost_prime (32)
3028 returned 39, which is undesirable as it is a multiple of 3; and
3029 next_almost_prime (24) returned 25, which is a multiple of 5 so
3030 why was the code bothering to check for multiples of 7?
3031
80e88859
PE
3032 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3033
4a2f0ad6
PE
3034 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3035
f66c7cf8
PE
3036 Variadic C functions now count arguments with ptrdiff_t.
3037 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3038 Back then I didn't know that the Emacs coding style prefers signed int.
3039 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3040 were being counted with int, which may truncate counts on 64-bit
3041 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3042 * lisp.h (struct Lisp_Subr.function.aMANY)
3043 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3044 Arg counts are now ptrdiff_t, not size_t.
3045 All variadic functions and their callers changed accordingly.
3046 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3047 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3048 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3049 * callint.c (Fcall_interactively): Check arg count for overflow,
3050 to avoid potential buffer overrun. Use signed char, not 'int',
3051 for 'varies' array, so that we needn't bother to check its size
3052 calculation for overflow.
3053 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3054 * eval.c (apply_lambda):
3055 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3056 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3057 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3058
a1759b76
PE
3059 * callint.c (Fcall_interactively): Don't use index var as event count.
3060
d96be9fc
PE
3061 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3062 * mem-limits.h (SIZE): Remove; no longer used.
3063
a690a978 3064 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3065
578c21e6
PE
3066 Remove unnecessary casts.
3067 * xterm.c (x_term_init):
3068 * xfns.c (x_set_border_pixel):
3069 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3070 These aren't needed now that we assume ANSI C.
3071
96f53c6c
PE
3072 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3073 It's more likely to cause problems (due to unsigned overflow)
3074 than to cure them.
3075
83c77d31
PE
3076 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3077
ee2079f1
PE
3078 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3079
6da65536
PE
3080 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3081
7147c4a4
PE
3082 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3083
193e32d9
PE
3084 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3085
e5533da6
PE
3086 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3087
9910e595
PE
3088 GLYPH_CODE_FACE returns EMACS_INT, not int.
3089 * dispextern.h (merge_faces):
3090 * xfaces.c (merge_faces):
01103c44
PE
3091 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3092 Don't assume EMACS_INT fits in int.
9910e595 3093
2638320e
PE
3094 * character.h (CHAR_VALID_P): Remove unused parameter.
3095 * fontset.c, lisp.h, xdisp.c: All uses changed.
3096
045eb8d9
PE
3097 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3098
c1f134b5
PE
3099 * fns.c (concat): Minor tuning based on overflow analysis.
3100 This doesn't fix any bugs. Use int to hold character, instead
3101 of constantly refetching from Emacs object. Use XFASTINT, not
3102 XINT, for value known to be a character. Don't bother comparing
3103 a single byte to 0400, as it's always less.
3104
395fcb93 3105 * floatfns.c (Fexpt):
327eeec8
PE
3106 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3107
abbd3d23
PE
3108 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3109 for characters.
3110
684a03ef
PE
3111 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3112
0fed43f3
PE
3113 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3114 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3115 incorrectly succeed when S was a string, because 4294967386 was
3116 truncated before it was used.
3117
8fd02eb7
PE
3118 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3119 Otherwise, an out-of-range integer could cause undefined behavior
3120 on a 64-bit host.
3121
f8c86b69
PE
3122 * composite.c: Use int, not EMACS_INT, for characters.
3123 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3124 EMACS_INT, for values that are known to be in character range.
3125 This doesn't fix any bugs but is the usual style inside Emacs and
3126 may generate better code on 32-bit machines.
3127
34206dd2
PE
3128 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3129 This is for reasons similar to the recent CHAR_STRING fix.
3130 * charset.c (Fencode_char): Check that character arg is actually
3131 a character. Pass an int to ENCODE_CHAR.
3132 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3133 wider than 'int', as a compile-time check to prevent future regressions
3134 in this area.
3135
c5958d4c 3136 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3137
3138 Make sure a 64-bit char is never passed to CHAR_STRING.
3139 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3140 by silently ignoring the top 32 bits, allowing some values
3141 that were far too large to be valid characters.
3142 * character.h: Include <verify.h>.
3143 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3144 arguments are no wider than unsigned, as a compile-time check
3145 to prevent future regressions in this area.
3146 * data.c (Faset):
01103c44 3147 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3148 (Fsubst_char_in_region):
3149 * fns.c (concat):
3150 * xdisp.c (decode_mode_spec_coding):
3151 Adjust to CHAR_STRING's new requirement.
3152 * editfns.c (Finsert_char, Fsubst_char_in_region):
3153 * fns.c (concat): Check that character args are actually
3154 characters. Without this test, these functions did the wrong
3155 thing with wildly out-of-range values on 64-bit hosts.
3156
d37ca623
PE
3157 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3158 These casts should not be needed on 32-bit hosts, either.
3159 * keyboard.c (read_char):
3160 * lread.c (Fload): Remove casts to unsigned.
3161
ea204efb
PE
3162 * lisp.h (UNSIGNED_CMP): New macro.
3163 This fixes comparison bugs on 64-bit hosts.
3164 (ASCII_CHAR_P): Use it.
3165 * casefiddle.c (casify_object):
01103c44 3166 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3167 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3168 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3169 * dispextern.h (FACE_FROM_ID):
3170 * keyboard.c (read_char): Use UNSIGNED_CMP.
3171
41cb286c
PE
3172 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3173 not to EMACS_INT, to avoid GCC warning.
3174
4a1b9832
PE
3175 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3176
55daad71
PE
3177 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3178 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3179 isn't needed on 32-bit machines.
8f95c75c 3180
01103c44
PE
3181 * buffer.c (Fgenerate_new_buffer_name):
3182 Use EMACS_INT for count, not int.
0ceccced 3183 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3184
3185 * data.c (Qcompiled_function): Now static.
3186
c6f072e7
PE
3187 * window.c (window_body_lines): Now static.
3188
20ce5912
PE
3189 * image.c (gif_load): Rename local to avoid shadowing.
3190
9c4c5f81
PE
3191 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3192 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3193 * alloc.c (make_save_value): Integer argument is now of type
3194 ptrdiff_t, not int.
3195 (mark_object): Use ptrdiff_t, not int.
3196 * lisp.h (pD): New macro.
3197 * print.c (print_object): Use it.
3198
c0c5c8ae
PE
3199 * alloc.c: Use EMACS_INT, not int, to count objects.
3200 (total_conses, total_markers, total_symbols, total_vector_size)
3201 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3202 (total_free_floats, total_floats, total_free_intervals)
3203 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3204 Now EMACS_INT, not int. All uses changed.
3205 (Fgarbage_collect): Compute overall total using a double, so that
3206 integer overflow is less likely to be a problem. Check for overflow
3207 when converting back to an integer.
5a25e253
PE
3208 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3209 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3210 These were 'int' variables that could overflow on 64-bit hosts;
3211 they were never used, so remove them instead of repairing them.
211a0b2a 3212 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3213 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3214 Previously, this ceilinged at INT_MAX, but that doesn't work on
3215 64-bit machines.
e46bb31a 3216 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3217
c78baabf 3218 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3219 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3220 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3221 when a (possibly-narrower) signed value would do just as well.
3222 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3223
c9d624c6
PE
3224 * alloc.c: Catch some string size overflows that we were missing.
3225 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3226 for convenience in STRING_BYTES_MAX.
3227 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3228 The definition here is exact; the one in lisp.h was approximate.
3229 (allocate_string_data): Check for string overflow. This catches
3230 some instances we weren't catching before. Also, it catches
3231 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3232 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3233 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3234
c9d624c6
PE
3235 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3236 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3237 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3238
353032ce
PE
3239 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3240
2bccce07
PE
3241 * alloc.c (Fmake_string): Check for out-of-range init.
3242
0ac30604
SM
32432011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3244
3245 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3246
c195f2de
JD
32472011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3248
3249 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3250 xg_get_default_scrollbar_width.
3251
3252 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3253 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3254 (style_changed_cb): Call update_theme_scrollbar_width and call
3255 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3256 all frames (Bug#8505).
3257 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3258 Call gtk_window_set_resizable if HAVE_GTK3.
3259 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3260 and height if HAVE_GTK3 (Bug#8505).
3261 (scroll_bar_width_for_theme): New variable.
3262 (update_theme_scrollbar_width): New function.
3263 (xg_get_default_scrollbar_width): Move code to
3264 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3265 (xg_initialize): Call update_theme_scrollbar_width.
3266
3267 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3268
3269 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3270
e10ac9f1
MR
32712011-06-12 Martin Rudalics <rudalics@gmx.at>
3272
3273 * frame.c (make_frame): Call other_buffer_safely instead of
3274 other_buffer.
3275
3276 * window.c (temp_output_buffer_show): Call display_buffer with
3277 second argument Vtemp_buffer_show_specifiers and reset latter
3278 immediately after the call.
3279 (Vtemp_buffer_show_specifiers): New variable.
3280 (auto_window_vscroll_p, next_screen_context_lines)
3281 (Vscroll_preserve_screen_position): Remove leading asterisks from
3282 doc-strings.
3283
2d3c217e 32842011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3285
7b7f97e8 3286 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3287 * buffer.c (Qclone_number): Remove for now, as it's unused.
3288 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3289 (record_buffer): Remove unused local.
3290 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3291 (set_frame_buffer_list): Remove; unused.
3292 * frame.h (other_visible_frames): Remove decl.
3293 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3294 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3295 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3296 if HAVE_GPM.
3297 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3298 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3299 Define only if HAVE_GPM.
3300 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3301 (update_hints_inhibit): Remove; never set. All uses removed.
3302 * widgetprv.h (emacsFrameClassRec): Remove decl.
3303 * window.c (delete_deletable_window): Now returns void, since it
3304 wasn't returning anything.
3305 (compare_window_configurations): Remove unused locals.
3306 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3307 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3308 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3309 the same widths as pointers. This follows up on the 2011-05-06 patch.
3310 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3311 * xterm.h: Likewise.
3312 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3313
1384b89e
JB
33142011-06-12 Juanma Barranquero <lekktu@gmail.com>
3315
3316 * makefile.w32-in: Update dependencies.
3317 (LISP_H): Add lib/intprops.h.
3318
1100a63c
CY
33192011-06-11 Chong Yidong <cyd@stupidchicken.com>
3320
3321 * image.c (gif_load): Add animation frame delay to the metadata.
3322 (syms_of_image): Use DEFSYM. New symbol `delay'.
3323
6198ccd0
MR
33242011-06-11 Martin Rudalics <rudalics@gmx.at>
3325
3326 * window.c (delete_deletable_window): Re-add.
3327 (Fset_window_configuration): Rewrite to handle dead buffers and
3328 consequently deletable windows.
3329 (window_tree, Fwindow_tree): Remove. Supply functionality in
3330 window.el.
3331 (compare_window_configurations): Simplify code.
3332
b6e3633c
AS
33332011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3334
1ab0dee5
AS
3335 * image.c (imagemagick_load_image): Fix type mismatch.
3336 (Fimagemagick_types): Likewise.
3337
b6e3633c
AS
3338 * window.h (replace_buffer_in_windows): Declare.
3339
9397e56f
MR
33402011-06-11 Martin Rudalics <rudalics@gmx.at>
3341
3342 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3343 Qclone_number. Remove external declaration of Qdelete_window.
3344 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3345 code.
640c8776
SM
3346 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3347 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3348 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3349 buffer list implementation.
3350 (other_buffer_safely): New function.
3351 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3352 calls to replace_buffer_in_windows and
3353 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3354 if allowed.
3355 (record_buffer): Inhibit quitting and rewrite using quittable
3356 functions. Run Qbuffer_list_update_hook if allowed.
3357 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3358 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3359 Move switch-to-buffer to window.el.
9397e56f
MR
3360 (bury-buffer): Move to window.el.
3361 (Vbuffer_list_update_hook): New variable.
3362
3363 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3364 section.
3365
3366 * window.h (resize_frame_windows): Move up in code.
3367 (Fwindow_frame): Remove EXFUN.
3368 (replace_buffer_in_all_windows): Remove prototype.
3369 (replace_buffer_in_windows_safely): Add prototype.
3370
3371 * window.c: Declare Qdelete_window static again. Move down
3372 declaration of select_count.
3373 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3374 (Fother_window): Move to window.el.
3375 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3376 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3377 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3378 window.el.
3379 (replace_buffer_in_windows): Implement by calling
3380 Qreplace_buffer_in_windows.
3381 (replace_buffer_in_all_windows): Remove with some functionality
3382 moved into replace_buffer_in_windows_safely.
3383 (replace_buffer_in_windows_safely): New function.
3384 (select_window_norecord, select_frame_norecord): Move in front
3385 of run_window_configuration_change_hook. Remove now obsolete
3386 declarations.
640c8776
SM
3387 (Fset_window_buffer): Rewrite doc-string.
3388 Call Qrecord_window_buffer.
9397e56f
MR
3389 (keys_of_window): Move binding for other-window to window.el.
3390
b50691aa
CY
33912011-06-11 Chong Yidong <cyd@stupidchicken.com>
3392
3393 * dispextern.h (struct image): Replace data member, whose int_val
3394 and ptr_val fields were not used by anything, with a single
3395 lisp_val object.
3396
3397 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3398 (gif_clear_image, gif_load, imagemagick_load_image)
3399 (gs_clear_image, gs_load): Callers changed.
3400
3f754b86
PE
34012011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3402
cca69397
PE
3403 * buffer.h: Include <time.h>, for time_t.
3404 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3405
109e28d0
PE
3406 Fix minor problems found by static checking.
3407
60737f02
PE
3408 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3409
4b66faf3
PE
3410 Make identifiers static if they are not used in other modules.
3411 * data.c (Qcompiled_function, Qframe, Qvector):
3412 * image.c (QimageMagick, Qsvg):
3413 * minibuf.c (Qmetadata):
3414 * window.c (resize_window_check, resize_root_window): Now static.
3415 * window.h (resize_window_check, resize_root_window): Remove decls.
3416
109e28d0
PE
3417 * window.c (window_deletion_count, delete_deletable_window):
3418 Remove; unused.
46a4ce9e
PE
3419 (window_body_lines): Now static.
3420 (Fdelete_other_windows_internal): Mark vars as initialized.
3421 Make sure 'resize_failed' is initialized.
3422 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3423 (resize_window_apply): Remove unused local.
3424 * window.h (delete_deletable_window): Remove decl.
3425
109e28d0 3426 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3427 (imagemagick_load_image): Fix pointer signedness problem by changing
3428 last arg from unsigned char * to char *. All uses changed.
3429 Also, fix a local for similar reasons.
3430 Remove unused locals. Remove locals to avoid shadowing.
3431 (fn_rsvg_handle_free): Remove; unused.
3432 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3433 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3434
3f754b86
PE
3435 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3436
2547adb1
CY
34372011-06-10 Chong Yidong <cyd@stupidchicken.com>
3438
3439 * image.c (gif_load): Fix omitted cast error introduced by
3440 2011-06-06 change.
3441
2c8e37d4
MR
34422011-06-10 Martin Rudalics <rudalics@gmx.at>
3443
3444 * window.h (resize_proportionally, orig_total_lines)
3445 (orig_top_line): Remove from window structure.
3446 (set_window_height, set_window_width, change_window_heights)
3447 (Fdelete_window): Remove prototypes.
3448 (resize_frame_windows): Remove duplicate declaration.
3449
440a42e3
EZ
34502011-06-10 Eli Zaretskii <eliz@gnu.org>
3451
3452 * window.h (resize_frame_windows, resize_window_check)
3453 (delete_deletable_window, resize_root_window)
3454 (resize_frame_windows): Declare prototypes.
3455
3456 * window.c (resize_window_apply): Make definition be "static" to
3457 match the prototype.
3458
562dd5e9
MR
34592011-06-10 Martin Rudalics <rudalics@gmx.at>
3460
3461 * window.c: Remove declarations of Qwindow_size_fixed,
3462 window_min_size_1, window_min_size_2, window_min_size,
3463 size_window, window_fixed_size_p, enlarge_window, delete_window.
3464 Remove static from declaration of Qdelete_window, it's
3465 temporarily needed by Fbury_buffer.
3466 (replace_window): Don't assign orig_top_line and
3467 orig_total_lines.
3468 (Fdelete_window, delete_window): Remove. Window deletion is
3469 handled by window.el.
640c8776
SM
3470 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3471 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3472 (Fdelete_other_windows): Remove. Deleting other windows is
3473 handled by window.el.
3474 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3475 handled in window.el.
3476 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3477 Window minimum sizes are handled in window.el.
3478 (shrink_windows, size_window, set_window_height)
3479 (set_window_width, change_window_heights, window_height)
3480 (window_width, CURBEG, CURSIZE, enlarge_window)
3481 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3482 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3483 handled in window.el.
3484 (make_dummy_parent): Rename to make_parent_window and give it a
3485 second argument horflag.
3486 (make_window): Don't set resize_proportionally any more.
3487 (Fsplit_window): Remove. Windows are split in window.el.
3488 (save_restore_action, save_restore_orig_size)
3489 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3490 Resize mini windows in window.el.
3491 (grow_mini_window, shrink_mini_window): Implement by calling
3492 Qresize_root_window_vertically, resize_window_check and
3493 resize_window_apply.
640c8776
SM
3494 (saved_window, Fset_window_configuration, save_window_save):
3495 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3496 resize_proportionally.
3497 (window_min_height, window_min_width): Move to window.el.
3498 (keys_of_window): Move bindings for delete-other-windows,
3499 split-window, delete-window and enlarge-window to window.el.
3500
3501 * buffer.c: Temporarily extern Qdelete_window.
3502 (Fbury_buffer): Temporarily call Qdelete_window instead of
3503 Fdelete_window (Fbury_buffer will move to window.el soon).
3504
3505 * frame.c (set_menu_bar_lines_1): Remove code handling
3506 orig_top_line and orig_total_lines.
3507
3508 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3509 set_window_height but set heights directly.
3510 (change_frame_size_1): Use resize_frame_windows.
3511
3512 * xdisp.c (init_xdisp): Don't use set_window_height but set
3513 heights directly.
3514
640c8776
SM
3515 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3516 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3517 run_window_configuration_change_hook.
3518
3519 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3520 instead of change_window_heights and run
3521 run_window_configuration_change_hook.
3522
1a13852e
MR
35232011-06-09 Martin Rudalics <rudalics@gmx.at>
3524
3525 * window.c (replace_window): Rename second argument REPLACEMENT to
3526 NEW. New third argument SETFLAG. Rewrite.
3527 (delete_window, make_dummy_parent): Call replace_window with
3528 third argument 1.
3529 (window_list_1): Move down in code.
3530 (run_window_configuration_change_hook): Move set_buffer part
3531 before select_frame_norecord part in order to unwind correctly.
3532 Rename count1 to count.
3533 (recombine_windows, delete_deletable_window, resize_root_window)
3534 (Fdelete_other_windows_internal)
3535 (Frun_window_configuration_change_hook, make_parent_window)
3536 (resize_window_check, resize_window_apply, Fresize_window_apply)
3537 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3538 (Fdelete_window_internal, Fresize_mini_window_internal):
3539 New functions.
1a13852e
MR
3540 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3541
f3d1777e
MR
35422011-06-08 Martin Rudalics <rudalics@gmx.at>
3543
496e208e
MR
3544 * window.h (window): Add some new members to window structure -
3545 normal_lines, normal_cols, new_total, new_normal, clone_number,
3546 splits, nest, prev_buffers, next_buffers.
3547 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3548 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3549
f3d1777e
MR
3550 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3551 Remove.
496e208e
MR
3552 (make_dummy_parent): Set new members of windows structure.
3553 (make_window): Move down in code. Handle new members of window
3554 structure.
3555 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3556 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3557 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3558 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3559 (Fset_window_next_buffers, Fset_window_clone_number):
3560 New functions.
496e208e
MR
3561 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3562 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3563 Doc-string fixes.
3564 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3565 Argument WINDOW can be now internal window too.
3566 (Fwindow_use_time): Move up in code.
3567 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3568 Rewrite doc-string.
3569 (Fset_window_configuration, saved_window)
3570 (Fcurrent_window_configuration, save_window_save): Handle new
3571 members of window structure.
b9e809c2
MR
3572 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3573 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3574 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3575 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3576 Qget_mru_window, Qresize_root_window,
3577 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3578 Qauto_buffer_name; staticpro them.
f3d1777e 3579
abde8f8c
MR
35802011-06-07 Martin Rudalics <rudalics@gmx.at>
3581
3582 * window.c (Fwindow_total_size, Fwindow_left_column)
3583 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3584 (Fwindow_list_1): New functions.
3585 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3586 (Fwindow_width, Fscroll_left, Fscroll_right):
3587 Use window_body_cols instead of window_box_text_cols.
3588 (delete_window, Fset_window_configuration):
3589 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3590 (delete_all_subwindows): Take a window as argument and not a
3591 structure. Rewrite.
190b47e6
MR
3592 (window_loop): Remove handling of GET_LRU_WINDOW and
3593 GET_LARGEST_WINDOW.
3594 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3595
3596 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3597 window_box_text_cols. delete_all_subwindows now takes a
3598 Lisp_Object as argument.
abde8f8c 3599
640c8776
SM
3600 * indent.c (compute_motion, Fcompute_motion):
3601 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3602
fa8a67e6
MR
3603 * frame.c (delete_frame): Call delete_all_subwindows with root
3604 window as argument.
3605
a54e3482
DC
36062011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3607
3608 * fns.c (Fputhash): Document return value.
3609
60002bf5
CY
36102011-06-06 Chong Yidong <cyd@stupidchicken.com>
3611
3612 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3613
0c671da6 36142011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3615
b862a52a 3616 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3617
be44ca6c
PE
3618 Check for overflow when converting integer to cons and back.
3619 * charset.c (Fdefine_charset_internal, Fdecode_char):
3620 Use cons_to_unsigned to catch overflow.
3621 (Fencode_char): Use INTEGER_TO_CONS.
3622 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3623 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3624 * data.c (long_to_cons, cons_to_long): Remove.
3625 (cons_to_unsigned, cons_to_signed): New functions.
3626 These signal an error for invalid or out-of-range values.
3627 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3628 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3629 * font.c (Ffont_variation_glyphs):
3630 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3631 * lisp.h: Include <intprops.h>.
3632 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3633 (cons_to_signed, cons_to_unsigned): New decls.
3634 (long_to_cons, cons_to_long): Remove decls.
3635 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3636 (Fprimitive_undo): Use CONS_TO_INTEGER.
3637 * xfns.c (Fx_window_property): Likewise.
3638 * xselect.c: Include <limits.h>.
3639 (x_own_selection, selection_data_to_lisp_data):
3640 Use INTEGER_TO_CONS.
3641 (x_handle_selection_request, x_handle_selection_clear)
3642 (x_get_foreign_selection, Fx_disown_selection_internal)
3643 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3644 (lisp_data_to_selection_data): Use cons_to_unsigned.
3645 (x_fill_property_data): Use cons_to_signed.
3646 Report values out of range.
3647
d1f3d2af
PE
3648 Check for buffer and string overflow more precisely.
3649 * buffer.h (BUF_BYTES_MAX): New macro.
3650 * lisp.h (STRING_BYTES_MAX): New macro.
3651 * alloc.c (Fmake_string):
3652 * character.c (string_escape_byte8):
3653 * coding.c (coding_alloc_by_realloc):
3654 * doprnt.c (doprnt):
3655 * editfns.c (Fformat):
3656 * eval.c (verror):
3657 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3658 since they may not be the same number.
3659 * editfns.c (Finsert_char):
3660 * fileio.c (Finsert_file_contents):
3661 Likewise for BUF_BYTES_MAX.
3662
dd52fcea
PE
3663 * image.c: Use ptrdiff_t, not int, for sizes.
3664 (slurp_file): Switch from int to ptrdiff_t.
3665 All uses changed.
3666 (slurp_file): Check that file size fits in both size_t (for
3667 malloc) and ptrdiff_t (for sanity and safety).
3668
7f9bbdbb
PE
3669 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3670 if b->modtime has its maximal value.
3671
dfe18f82
PE
3672 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3673
84acfcf0
PE
3674 Don't assume time_t can fit into int.
3675 * buffer.h (struct buffer.modtime): Now time_t, not int.
3676 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3677 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3678
ccd9a01a
PE
3679 Minor fixes for signed vs unsigned integers.
3680 * character.h (MAYBE_UNIFY_CHAR):
3681 * charset.c (maybe_unify_char):
3682 * keyboard.c (read_char, reorder_modifiers):
3683 XINT -> XFASTINT, since the integer must be nonnegative.
3684 * ftfont.c (ftfont_spec_pattern):
3685 * keymap.c (access_keymap, silly_event_symbol_error):
3686 XUINT -> XFASTINT, since the integer must be nonnegative.
3687 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3688 since it makes no difference and we prefer signed.
3689 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3690 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3691 nonnegative.
3692
d6d100dd
SM
36932011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3694
3695 * window.h (Fwindow_frame): Declare.
3696
2b6148e4
PE
36972011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3698
3699 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3700 (SPARE_MEMORY): Always define.
3701 (LARGE_REQUEST): Remove.
3702 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3703
f230ecc9
MR
37042011-06-06 Martin Rudalics <rudalics@gmx.at>
3705
727e958e
MR
3706 * lisp.h: Move EXFUNS for Fframe_root_window,
3707 Fframe_first_window and Fset_frame_selected_window to window.h.
3708
3709 * window.h: Move EXFUNS for Fframe_root_window,
3710 Fframe_first_window and Fset_frame_selected_window here from
3711 lisp.h.
3712
3713 * frame.c (Fwindow_frame, Fframe_first_window)
3714 (Fframe_root_window, Fframe_selected_window)
3715 (Fset_frame_selected_window): Move to window.c.
3716 (Factive_minibuffer_window): Move to minibuf.c.
3717 (Fother_visible_frames_p): New function.
3718
3719 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3720
f230ecc9
MR
3721 * window.c (decode_window, decode_any_window): Move up in code.
3722 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3723 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3724 (Fwindow_buffer): Move up and rewrite doc-string.
3725 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3726 (Fwindow_prev): New functions.
727e958e
MR
3727 (Fwindow_frame): Move here from frame.c. Accept any window as
3728 argument.
3729 (Fframe_root_window, Fframe_first_window)
3730 (Fframe_selected_window): Move here from frame.c. Accept frame
3731 or arbitrary window as argument. Update doc-strings.
3732 (Fminibuffer_window): Move up in code.
3733 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3734 (Fset_frame_selected_window): Move here from frame.c.
3735 Marginal rewrite.
727e958e
MR
3736 (Fselected_window, select_window, Fselect_window): Move up in
3737 code. Minor doc-string fixes.
f230ecc9 3738
4d09bcf6
PE
37392011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3740
3741 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3742 Do not assume that spare memory exists; that assumption is valid
3743 only if SYSTEM_MALLOC.
3744 (LARGE_REQUEST): New macro, so that the issue of large requests
3745 is separated from the issue of spare memory.
3746
810928a2
AS
37472011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3748
172418ad
AS
3749 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3750 format. (Bug#8806)
3751
43f862f7
AS
3752 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3753
810928a2
AS
3754 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3755 before statements.
3756
a059fe24
JD
37572011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3758
3759 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3760
3761 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3762
3763 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3764 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3765
989bf368
JB
37662011-06-05 Juanma Barranquero <lekktu@gmail.com>
3767
3768 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3769
4b80f674
CY
37702011-06-04 Chong Yidong <cyd@stupidchicken.com>
3771
3772 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3773 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3774 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3775 New error handlers.
4b80f674
CY
3776 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3777 Obey Vx_select_enable_clipboard_manager. Catch errors in
3778 x_clipboard_manager_save (Bug#8779).
3779 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3780 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3781
99a33b77 37822011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3783
3784 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3785
99a33b77 37862011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3787
3788 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3789 in the current matrix if keep_current_p is non-zero.
3790
8264569d
EZ
37912011-06-04 Eli Zaretskii <eliz@gnu.org>
3792
3793 * bidi.c (bidi_level_of_next_char): Fix last change.
3794
57f97249
EZ
37952011-06-03 Eli Zaretskii <eliz@gnu.org>
3796
fec2107c 3797 Support bidi reordering of text covered by display properties.
57f97249 3798
fec2107c
EZ
3799 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3800 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3801 (bidi_cache_search, bidi_cache_iterator_state)
3802 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3803 (bidi_level_of_next_char, bidi_move_to_visually_next):
3804 Support character positions inside a run of characters covered by a
fec2107c
EZ
3805 display string.
3806 (bidi_paragraph_init, bidi_resolve_explicit_1)
3807 (bidi_level_of_next_char): Call bidi_fetch_char and
3808 bidi_fetch_char_advance instead of FETCH_CHAR and
3809 FETCH_CHAR_ADVANCE.
3810 (bidi_init_it): Initialize new members.
3811 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3812 definitions.
3813 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3814 instead of using explicit *_CHAR codes.
d6d100dd
SM
3815 (bidi_resolve_explicit, bidi_resolve_weak):
3816 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3817 bidirectional text is supported only in multibyte buffers.
3818 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3819 it to initialize the frame_window_p member of struct bidi_it.
3820 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3821 (bidi_resolve_explicit, bidi_resolve_weak)
3822 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3823 bidi_it->nchars is non-positive.
3824 (bidi_level_of_next_char): Don't try to lookup the cache for the
3825 next/previous character if nothing is cached there yet, or if we
3826 were just reseat()'ed to a new position.
c40e2fb2 3827
0e14fe90
EZ
3828 * xdisp.c (set_cursor_from_row): Set start and stop points
3829 according to the row's direction when priming the loop that looks
3830 for the glyph on which to display cursor.
3831 (single_display_spec_intangible_p): Function deleted.
3832 (display_prop_intangible_p): Reimplement to call
3833 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3834 Accept 3 additional arguments needed by handle_display_spec.
3835 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3836 values: lists, `(when COND...)' forms, etc.
3837 (single_display_spec_string_p): Support property values that are
3838 lists with the argument STRING its top-level element.
3839 (display_prop_string_p): Fix the condition for processing a
3840 property that is a list to be consistent with handle_display_spec.
fec2107c 3841 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3842 last portion of handle_display_prop.
3843 (compute_display_string_pos): Accept additional argument
3844 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3845 value of a `display' property is a "replacing spec".
3846 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3847 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3848 the display property, but just return a value indicating whether
3849 the display property will replace the characters it covers.
3850 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3851 frame_window_p members of struct bidi_it.
d6d100dd
SM
3852 (compute_display_string_pos, compute_display_string_end):
3853 New functions.
fec2107c
EZ
3854 (push_it): Accept second argument POSITION, where pop_it should
3855 jump to continue iteration.
3856 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3857
fec2107c
EZ
3858 * keyboard.c (adjust_point_for_property): Adjust the call to
3859 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3860
3861 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3862 (bidi_init_it): Update prototypes.
3863 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3864 (compute_display_string_pos, compute_display_string_end):
3865 Declare prototypes.
fec2107c
EZ
3866 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3867 EMACS_INT.
fc6f18ce 3868
40087514 38692011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3870
57f53182
PE
3871 Malloc failure behavior now depends on size of allocation.
3872 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3873 * lisp.h: Change signatures accordingly.
3874 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3875 All callers changed. (Bug#8762)
3876
3877 * gnutls.c: Use Emacs's memory allocators.
3878 Without this change, the gnutls library would invoke malloc etc.
3879 directly, which causes problems on non-SYNC_INPUT hosts, and which
3880 runs afoul of improving memory_full behavior. (Bug#8761)
3881 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3882 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3883 xfree instead of the default malloc, realloc, free.
3884 (Fgnutls_boot): No need to check for memory allocation failure,
3885 since xmalloc does that for us.
3886
ac32cd99 3887 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3888 * category.c (hash_get_category_set):
3889 * ccl.c (ccl_driver):
3890 * charset.c (Fdefine_charset_internal):
3891 * charset.h (struct charset.hash_index):
3892 * composite.c (get_composition_id, gstring_lookup_cache)
3893 (composition_gstring_put_cache):
3894 * composite.h (struct composition.hash_index):
3895 * dispextern.h (struct image.hash):
3896 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3897 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3898 (hashfn_equal, hashfn_user_defined, make_hash_table)
3899 (maybe_resize_hash_table, hash_lookup, hash_put)
3900 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3901 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3902 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3903 * image.c (make_image, search_image_cache, lookup_image)
3904 (xpm_put_color_table_h):
3905 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3906 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3907 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3908 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3909 * alloc.c (allocate_vectorlike):
3910 Check for overflow in vector size calculations.
3911 * ccl.c (ccl_driver):
3912 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3913 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3914 need to be updated by these changes.
40087514
PE
3915 * fns.c (make_hash_table, maybe_resize_hash_table):
3916 Check for integer overflow with large hash tables.
0de4bb68
PE
3917 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3918 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3919 (SXHASH_REDUCE): New macro.
3920 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3921 Use it instead of discarding useful hash info with large hash values.
3922 (sxhash_float): New function.
3923 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3924 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3925 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3926 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3927 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3928 Adjust signatures to match updated version of code.
3929 (consing_since_gc): Now EMACS_INT, since a single hash table can
3930 use more than INT_MAX bytes.
3931
698d32e2
DN
39322011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3933
3934 Make it possible to build with GCC-4.6+ -O2 -flto.
3935
3936 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3937
fd6fa53f
SM
39382011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3939
3940 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3941 Call minibuffer-inactive-mode.
3942
864db017
JB
39432011-05-31 Juanma Barranquero <lekktu@gmail.com>
3944
3945 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3946 Update dependencies.
3947
2ad0baf4
DN
39482011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3949
3950 * data.c (init_data): Remove code for UTS, this system is not
3951 supported anymore.
3952
4fcc2638
DN
39532011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3954
3955 Don't force ./temacs to start in terminal mode.
3956
3957 * frame.c (make_initial_frame): Initialize faces in all cases, not
3958 only when CANNOT_DUMP is defined.
3959 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3960
c56e0fd5
DN
39612011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3962
3963 * dispnew.c (add_window_display_history): Use const for the string
3964 pointer. Remove declaration, not needed.
3965
333d54da 39662011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3967
55d4c1b2 3968 Use 'inline', not 'INLINE'.
333d54da 3969 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3970 * alloc.c, fontset.c (INLINE): Remove.
3971 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3972 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3973 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3974 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3975 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3976
738db178
DN
39772011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3978
3979 Make it possible to run ./temacs.
3980
3981 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3982 syms_of_callproc does the same thing. Remove test for
3983 "initialized", do it in the caller.
3984 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3985
620c53a6
SM
39862011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3987
3988 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3989 (read_minibuf): Use get_minibuffer.
3990 (syms_of_minibuf): Use DEFSYM.
3991 (Qmetadata): New var.
3992 * data.c (Qbuffer): Don't make it static.
3993 (syms_of_data): Use DEFSYM.
3994
e003a292
PE
39952011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3996
3997 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3998 (CCL_CODE_MIN): New macro.
3999
ed008a6d
PE
40002011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4001
3687c2ef
PE
4002 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4003
ed008a6d
PE
4004 * eval.c (Qdebug): Now static.
4005 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4006 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4007 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4008
d66c4c7c
CY
40092011-05-29 Chong Yidong <cyd@stupidchicken.com>
4010
4011 * image.c: Various fixes to ImageMagick code comments.
4012 (Fimagemagick_types): Doc fix.
4013
5fbc2025
PE
40142011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4015
0196f88a
PE
4016 Minor fixes prompted by GCC 4.6.0 warnings.
4017
4018 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4019
5fbc2025
PE
4020 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4021 (x_clipboard_manager_save_all): Move extern decl to ...
4022 * xterm.h: ... here, so that it can be checked for consistency.
4023
1dd3c2d9
CY
40242011-05-29 Chong Yidong <cyd@stupidchicken.com>
4025
4026 * xselect.c (x_clipboard_manager_save_frame)
4027 (x_clipboard_manager_save_all): New functions.
4028 (Fx_clipboard_manager_save): Lisp function deleted.
4029
4030 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4031 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4032
4033 * xterm.h: Update prototype.
4034
5ba6571d
WX
40352011-05-28 William Xu <william.xwl@gmail.com>
4036
4037 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4038 exiting (Bug#8239).
4039
3eaff834
JM
40402011-05-28 Jim Meyering <meyering@redhat.com>
4041
e1900994 4042 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4043 * fns.c (to_uchar): Define.
4044 (crypto_hash_function): Use it to convert some newly-signed
4045 variables to unsigned, to avoid sign-extension bugs. For example,
4046 without this change, (md5 "truc") would evaluate to
4047 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4048 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4049 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4050
0f6990a7
PE
40512011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4052
4053 Integer overflow fixes.
c8a9ca5a 4054
08686060
PE
4055 * dbusbind.c: Serial number integer overflow fixes.
4056 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4057 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4058 to hold a serial number that is too large for a fixnum.
4059 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4060 Check for serial numbers out of range. Decode any serial number
59568bf0 4061 that was so large that it became a float. (Bug#8722)
08686060 4062
2d1fc3c7
PE
4063 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4064 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4065 Use XFASTINT rather than XUINT when numbers are nonnegative.
4066 (xd_append_arg, Fdbus_method_return_internal):
4067 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4068 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4069 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4070 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4071 (Bug#8722)
2d1fc3c7 4072
c8a9ca5a
PE
4073 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4074
519e1d69
PE
4075 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4076
30569699
PE
4077 ccl: add integer overflow checks
4078 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4079 (IN_INT_RANGE): New macros.
4080 (ccl_driver): Use them to check for integer overflow when
4081 decoding a CCL program. Many of the new checks are whether XINT (x)
4082 fits in int; it doesn't always, on 64-bit hosts. The new version
4083 doesn't catch all possible integer overflows, but it's an
847044ea 4084 improvement. (Bug#8719)
30569699 4085
c11285dc
PE
4086 * alloc.c (make_event_array): Use XINT, not XUINT.
4087 There's no need for unsigned here.
4088
fdccd48e
PE
4089 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4090 This follows up to the 2011-05-06 change that substituted uintptr_t
4091 for EMACS_INT. This case wasn't caught back then.
4092
37910ab2
PE
4093 Rework Fformat to avoid integer overflow issues.
4094 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4095 now (part of C89). Include <verify.h>.
4096 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4097 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4098 (Fformat): Avoid the prepass trying to compute sizes; it was only
4099 approximate and thus did not catch overflow reliably. Instead, walk
4100 through the format just once, formatting and computing sizes as we go,
4101 checking for integer overflow at every step, and allocating a larger
4102 buffer as needed. Keep track separately whether the format is
4103 multibyte. Keep only the most-recently calculated precision, rather
4104 than them all. Record whether each argument has been converted to
4105 string. Use EMACS_INT, not int, for byte and char and arg counts.
4106 Support field widths and precisions larger than INT_MAX. Avoid
4107 sprintf's undefined behavior with conversion specifications such as %#d
4108 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4109 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4110 formatting out-of-range floating point numbers with int
9173deec 4111 formats. (Bug#8668)
37910ab2 4112
2e6578fb
PE
4113 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4114
0ae6bdee
PE
4115 * data.c: Avoid integer truncation in expressions involving floats.
4116 * data.c: Include <intprops.h>.
4117 (arith_driver): When there's an integer overflow in an expression
4118 involving floating point, convert the integers to floating point
4119 so that the resulting value does not suffer from catastrophic
4120 integer truncation. For example, on a 64-bit host (* 4
4121 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4122 Do not rely on undefined behavior after integer overflow.
4123
de883a70
PE
4124 merge count_size_as_multibyte, parse_str_to_multibyte
4125 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4126 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4127 Check for integer overflow.
4128 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4129 since it's now a duplicate of the other. This is more of
4130 a character than a buffer op, so better that it's in character.c.
4131 * fns.c, print.c: Adjust to above changes.
4132
2ff916cb
PE
41332011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4134
4135 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4136
f1b54466
PE
41372011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4138
fb1ac845
PE
4139 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4140 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4141 (x_clipboard_manager_save): Now static.
4142 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4143
f1b54466
PE
4144 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4145 (crypto_hash_function): Now static.
4146 Fix pointer signedness problems. Avoid unnecessary initializations.
4147
a9f737ee
CY
41482011-05-27 Chong Yidong <cyd@stupidchicken.com>
4149
4150 * termhooks.h (Vselection_alist): Make it terminal-local.
4151
4152 * terminal.c (create_terminal): Initialize it.
4153
4154 * xselect.c: Support for clipboard managers.
4155 (Vselection_alist): Move to termhooks.h as terminal-local var.
4156 (LOCAL_SELECTION): New macro.
4157 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4158 (symbol_to_x_atom): Remove gratuitous arg.
4159 (x_handle_selection_request, lisp_data_to_selection_data)
4160 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4161 (x_own_selection, x_get_local_selection, x_convert_selection):
4162 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4163 (some_frame_on_display): Delete unused function.
4164 (Fx_own_selection_internal, Fx_get_selection_internal)
4165 (Fx_disown_selection_internal, Fx_selection_owner_p)
4166 (Fx_selection_exists_p): New optional frame arg.
4167 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4168 (x_handle_selection_clear): Don't treat other terminals with the
4169 same keyboard specially. Use the terminal-local Vselection_alist.
4170 (x_clear_frame_selections): Use Frun_hook_with_args.
4171
4172 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4173
4174 * xterm.h: Add support for those atoms.
4175
e067f0c1
CY
41762011-05-26 Chong Yidong <cyd@stupidchicken.com>
4177
4178 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4179 (converted_selections, conversion_fail_tag): New global variables.
4180 (x_selection_request_lisp_error): Free the above.
4181 (x_get_local_selection): Remove unnecessary code.
4182 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4183 of converted selections stored in converted_selections.
4184 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4185 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4186 (x_convert_selection): New function.
4187 (x_handle_selection_event): Simplify.
4188 (x_get_foreign_selection): Don't ignore incoming requests while
4189 waiting for an answer; this will fail when we implement
4190 SAVE_TARGETS, and seems unnecessary anyway.
4191 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4192 (Vx_sent_selection_functions): Doc fix.
4193
0f4aebc0
LL
41942011-05-26 Leo Liu <sdl.web@gmail.com>
4195
4196 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4197
e61124cd
YM
41982011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4199
4200 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4201
4202 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4203 for fringe update if it has periodic bitmap.
ac389d0c 4204 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4205 and fringe_bitmap_periodic_p.
4206
4207 * fringe.c (get_fringe_bitmap_data): New function.
4208 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4209 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4210 row. Mark glyph row for fringe update if periodicity changed.
4211
4212 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4213 for fringe update unless it has periodic bitmap.
4214
f16d9837
KH
42152011-05-25 Kenichi Handa <handa@m17n.org>
4216
4217 * xdisp.c (get_next_display_element): Set correct it->face_id for
4218 a static composition.
4219
e1b90ef6
LL
42202011-05-24 Leo Liu <sdl.web@gmail.com>
4221
4222 * deps.mk (fns.o):
4223 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4224
4225 * fns.c (crypto_hash_function, Fsha1): New function.
4226 (Fmd5): Use crypto_hash_function.
4227 (syms_of_fns): Add Ssha1.
4228
7400048f
PE
42292011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4230
4231 * gnutls.c: Remove unused macros.
4232 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4233 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4234 Remove macros that are defined and never used.
4235 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4236
abb71cf4
CY
42372011-05-22 Chong Yidong <cyd@stupidchicken.com>
4238
4239 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4240 (Fx_get_selection_internal): Minor cleanup.
4241 (Fx_own_selection_internal): Rename arguments for consistency with
4242 select.el.
4243
6307db39
PE
42442011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4245
4246 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4247
f3d4e0a4
CY
42482011-05-22 Chong Yidong <cyd@stupidchicken.com>
4249
4250 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4251
4d8ade89
YM
42522011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4253
4254 * dispnew.c (scrolling_window): Don't exclude the case that the
4255 last enabled row in the desired matrix touches the bottom boundary.
4256
32078c8d
GM
42572011-05-21 Glenn Morris <rgm@gnu.org>
4258
4259 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4260 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4261 and add some more files.
32078c8d 4262
7285dc67
EZ
42632011-05-20 Eli Zaretskii <eliz@gnu.org>
4264
4265 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4266 report_file_error introduced by the change from 2011-05-07.
4267
89d1bd22
PE
42682011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4269
4270 * systime.h (Time): Define only if emacs is defined.
4271 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4272 where the include path doesn't have X11/X.h by default. See
4273 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4274
e23640bb 42752011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4276
4277 * composite.c (find_automatic_composition): Fix previous change.
4278
b9704ad9
GM
42792011-05-20 Glenn Morris <rgm@gnu.org>
4280
4281 * lisp.mk: New file, split from Makefile.in.
4282 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4283 (shortlisp): Remove.
4284 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4285
4a720484
GM
42862011-05-19 Glenn Morris <rgm@gnu.org>
4287
4288 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4289 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4290 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4291 (lisp): Set the order to that of loadup.el.
4292 (shortlisp): Make it a copy of $lisp.
4293 (SOME_MACHINE_LISP): Remove.
4294 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4295 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4296
a28d4396
KH
42972011-05-18 Kenichi Handa <handa@m17n.org>
4298
4299 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4300 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4301 (find_automatic_composition): Mostly rewrite for efficiency.
4302
a2b1fa8e
JB
43032011-05-18 Juanma Barranquero <lekktu@gmail.com>
4304
4305 * makefile.w32-in: Update dependencies.
4306
8e1f5610
CS
43072011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4308
4309 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4310 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4311
7025ee00 43122011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4313
cdfa6eab
PE
4314 Fix some integer overflow issues, such as string length overflow.
4315
06d6db33
PE
4316 * insdel.c (count_size_as_multibyte): Check for string overflow.
4317
2b4560a8
PE
4318 * character.c (lisp_string_width): Check for string overflow.
4319 Use EMACS_INT, not int, for string indexes and lengths; in
4320 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4321 the resulting string length overflows an EMACS_INT; instead,
4322 report a string overflow if no precision given. When checking for
4323 precision exhaustion, use a check that cannot possibly have
4324 integer overflow. (Bug#8675)
4325 * character.h (lisp_string_width): Adjust to new signature.
4326
cb93f9be
PE
4327 * alloc.c (string_overflow): New function.
4328 (Fmake_string): Use it. This doesn't change behavior, but saves
4329 a few bytes and will simplify future changes.
4330 * character.c (string_escape_byte8): Likewise.
4331 * lisp.h (string_overflow): New decl.
4332
1a1f3366
PE
4333 Fixups, following up to the user-interface timestamp change.
4334 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4335 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4336 * msdos.c (mouse_get_pos): Likewise.
4337 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4338 * w32gui.h (Time): Define by including "systime.h" rather than by
4339 declaring it ourselves. (Bug#8664)
4340
d4e3e4d3
PE
4341 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4342 * image.c (clear_image_cache): Likewise.
4343
f6a24d19
PE
4344 * term.c (term_mouse_position): Don't assume time_t wraparound.
4345
08dc5ae6
PE
4346 Be more systematic about user-interface timestamps.
4347 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4348 and sometimes 'EMACS_UINT', to represent these timestamps.
4349 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4350 This makes the code easier to follow, and makes it easier to catch
4351 integer overflow bugs such as Bug#8664.
4352 * frame.c (Fmouse_position, Fmouse_pixel_position):
4353 Use Time, not unsigned long, for user-interface timestamps.
4354 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4355 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4356 * keyboard.h (last_event_timestamp): Likewise.
4357 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4358 * menu.h (xmenu_show): Likewise.
4359 * term.c (term_mouse_position): Likewise.
4360 * termhooks.h (struct input_event.timestamp): Likewise.
4361 (struct terminal.mouse_position_hook): Likewise.
4362 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4363 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4364 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4365 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4366 what it was before.
4367 * menu.h, termhooks.h: Include "systime.h", for Time.
4368
8e55734a
PE
4369 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4370 Don't assume that the difference between two unsigned long values
4371 can fit into an integer. At this point, we know button_down_time
4372 <= event->timestamp, so the difference must be nonnegative, so
4373 there's no need to cast the result if double-click-time is
4374 nonnegative, as it should be; check that it's nonnegative, just in
4375 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4376 apart (about 25 days). (Bug#8664)
8e55734a 4377
841f1b75 4378 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4379 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4380
3e26f69c
PE
4381 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4382 that always fit in int. Use a sentinel instead of a counter, to
4383 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4384 * frame.h (struct frame): Use int for menu_bar_items_used
4385 instead of EMACS_INT, since it always fits in int.
3e26f69c 4386
5cc152c0
PE
4387 * menu.c (grow_menu_items): Check for int overflow.
4388
d89eb65e
PE
4389 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4390
5235bd3e
PE
4391 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4392 Before, the code was not consistent. These values cannot exceed
4393 2**31 - 1 so there's no need to make them unsigned.
4394 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4395 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4396 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4397 as modifiers.
4398 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4399
bc827e23
PE
4400 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4401 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4402 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4403 presumably because the widths might not match.
4404
78eb494e
PE
4405 * window.c (size_window): Avoid needless test at loop start.
4406
04f2d78b
CB
44072011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4408
4409 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4410
d2fc7e3d 44112011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4412
4413 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4414
d2fc7e3d 44152011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4416
4417 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4418 `width' to `bar_area_x' and `bar_area_width', respectively.
4419 (x_scroll_run): Take account of fringe background extension.
4420
04f2d78b
CB
4421 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4422 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4423 `bar_area_width', respectively.
4424 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4425 background extension.
4426
79b70037
GM
44272011-05-10 Jim Meyering <meyering@redhat.com>
4428
4429 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4430
2f142cc5
JB
44312011-05-10 Juanma Barranquero <lekktu@gmail.com>
4432
4433 * image.c (Finit_image_library): Return t for built-in image types,
4434 like pbm and xbm. (Bug#8640)
4435
57679c86
AS
44362011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4437
4438 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4439
888c9e86
EZ
44402011-05-07 Eli Zaretskii <eliz@gnu.org>
4441
b0512a1d
EZ
4442 * w32console.c (Fset_screen_color): Doc fix.
4443 (Fget_screen_color): New function.
4444 (syms_of_ntterm): Defsubr it.
4445
7285dc67
EZ
4446 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4447 unlink the temporary file if Fcall_process didn't create it in the
4448 first place.
4449 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4450 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4451 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4452 cue to call_process_cleanup not to close that handle.
4453
4d3fcc8e
BK
44542011-05-07 Ben Key <bkey76@gmail.com>
4455
4456 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4457 one of two shell specific rules, either bootstrap-temacs-CMD or
4458 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4459 to the previous implementation of the bootstrap-temacs rule.
4460 The bootstrap-temacs-CMD rule is similar to the previous
4461 implementation of the bootstrap-temacs rule except that it
4462 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4463 variable.
4464
4465 These changes, along with some changes to nt/configure.bat,
4466 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4467 earlier fix to add support for --cflags and --ldflags options
4468 that include quotes so that it works whether make uses cmd or
4469 sh as the shell.
4470
b4289b64
MA
44712011-05-06 Michael Albinus <michael.albinus@gmx.de>
4472
4473 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4474 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4475 is a constant.
4476 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4477 a string. Handle both cases.
4478 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4479 (Fdbus_register_method): Use Qinvalid_function.
4480
af4c0e28
JB
44812011-05-06 Juanma Barranquero <lekktu@gmail.com>
4482
4483 * makefile.w32-in: Update dependencies.
4484 (LISP_H): Add inttypes.h and stdin.h.
4485 (PROCESS_H): Add unistd.h.
4486
c51453d9
EZ
44872011-05-06 Eli Zaretskii <eliz@gnu.org>
4488
4489 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4490 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4491
8ff0ac3c 44922011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4493
4c4b566b
PE
4494 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4495
aab2b9b5
PE
4496 * term.c (vfatal): Remove stray call to va_end.
4497 It's not needed and the C Standard doesn't allow it here anyway.
4498
c378da0b
PE
4499 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4500 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4501
288b08c7
PE
4502 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4503 bytes.
4504
e3601888
PE
4505 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4506
db6c0e74
PE
4507 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4508
dd5963ea
PE
4509 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4510
88c9450f
PE
4511 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4512
2f9442b8
PE
4513 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4514
c032b5f8
PE
4515 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4516 * charset.c (Fdefine_charset_internal): Don't initialize
4517 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4518 32-bit int (Bug#8600).
a108c10b
PE
4519
4520 * lread.c (read_integer): Be more consistent with string-to-number.
4521 Use string_to_number to do the actual conversion; this avoids
4522 rounding errors and fixes some other screwups. Without this fix,
4523 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4524 (digit_to_number): Move earlier, for benefit of read_integer.
4525 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4526 not a digit in any supported base. (Bug#8602)
a108c10b 4527
ad5f9eea
PE
4528 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4529
aec1708a
PE
4530 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4531 to match comment at start of function. This also removes a
4532 GCC warning about overflow in a 32+64-bit port.
4533
47be4ab5
PE
4534 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4535
371cac43
PE
4536 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4537 Reported by Stefan Monnier in
4538 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4539 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4540 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4541
d01a7826
PE
4542 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4543 (EMACS_UINTPTR): Likewise, with uintptr_t.
4544
7fd47d5c
PE
4545 * lisp.h: Prefer 64-bit EMACS_INT if available.
4546 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4547 on 32-bit hosts that have 64-bit int, so that they can access
4548 large files.
122b0c86
PE
4549 However, temporarily disable this change unless the temporary
4550 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4551
8727937b
PE
4552 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4553
8ac068ac
PE
4554 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4555 This removes an assumption that EMACS_INT and long are the same
4556 width as pointers. The assumption is true for Emacs porting targets
4557 now, but we want to make other targets possible.
4558 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4559 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4560 In the rest of the code, change types of integers that hold casted
4561 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4562 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4563 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4564 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4565 No need to cast type when ORing.
4566 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4567 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4568 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4569 assume EMACS_INT is the same width as char *.
4570 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4571 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4572 Remove no-longer-needed casts.
4573 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4574 (xg_tool_bar_help_callback, xg_make_tool_item):
4575 Use EMACS_INTPTR to hold an integer
4576 that will be cast to void *; this can avoid a GCC warning
4577 if EMACS_INT is not the same width as void *.
4578 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4579 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4580 (current_message_1, set_message_1):
4581 Use a local to convert to proper width without a cast.
4582 * xmenu.c (dialog_selection_callback): Likewise.
4583
ede49d71
PE
4584 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4585 Also, don't assume VALBITS / RAND_BITS is less than 5,
4586 and don't rely on undefined behavior when shifting a 1 left into
4587 the sign bit.
4588 * lisp.h (get_random): Change signature to match.
4589
2f30ecd0
PE
4590 * lread.c (hash_string): Use size_t, not int, for hash computation.
4591 Normally we prefer signed values; but hashing is special, because
4592 it's better to use unsigned division on hash table sizes so that
4593 the remainder is nonnegative. Also, size_t is the natural width
4594 for hashing into memory. The previous code used 'int', which doesn't
4595 retain enough info to hash well into very large tables.
4596 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4597
2a866e7b
PE
4598 * dbusbind.c: Don't possibly lose pointer info when converting.
4599 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4600 Use XPNTR rather than XHASH, so that the high-order bits of
4601 the pointer aren't lost when converting through void *.
4602
51639eac
PE
4603 * eval.c (Fautoload): Don't double-shift a pointer.
4604
92394119
PE
4605 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4606
dbdb9a7c
JB
46072011-05-06 Juanma Barranquero <lekktu@gmail.com>
4608
4609 * gnutls.c (DEF_GNUTLS_FN):
4610 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4611
db7a0b4f
AS
46122011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4613
4614 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4615 marker. (Bug#8610)
4616
f7ff1b0f 46172011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4618
4619 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4620 New version that can reserve upto 2GB of heap space.
4621
f7ff1b0f 46222011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4623
4624 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4625
639c109b
TZ
46262011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4627
4628 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4629 `gnutls_certificate_set_x509_key_file'.
4630
d2127135
JB
46312011-05-05 Juanma Barranquero <lekktu@gmail.com>
4632
4633 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4634 Update dependencies.
4635
e968f4f3
JB
46362011-05-04 Juanma Barranquero <lekktu@gmail.com>
4637
4638 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4639 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4640 Remove unused parameter `fildes'.
4641 * process.c (read_process_output, send_process): Don't pass it.
4642
84d358f0
JB
46432011-05-04 Juanma Barranquero <lekktu@gmail.com>
4644
4645 Fix previous change: the library cache is defined in w32.c.
4646 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4647 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4648
0898ca10
JB
46492011-05-04 Juanma Barranquero <lekktu@gmail.com>
4650
4651 Implement dynamic loading of GnuTLS on Windows.
4652
4653 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4654 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4655 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4656 Declare.
4657
4658 * gnutls.c (Qgnutls_dll): Define.
4659 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4660 (gnutls_*): Declare function pointers.
4661 (init_gnutls_functions): New function to initialize function pointers.
4662 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4663 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4664 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4665 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4666 (emacs_gnutls_write, emacs_gnutls_read)
4667 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4668 (Fgnutls_available_p): New function.
4669 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4670 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4671 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4672
4673 * image.c: Include w32.h.
4674 (Vimage_type_cache): Delete.
4675 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4676 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4677 (w32_delayed_load): Move to w32.c.
4678
4679 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4680
4681 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4682 (w32_delayed_load): Move from image.c. When loading a library, record
4683 its filename in the :loaded-from property of the library id.
4684 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4685 Initialize and staticpro them.
4686 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4687
4688 * process.c: Include lisp.h before w32.h, not after.
4689 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4690 instead of gnutls_record_check_pending.
4691
4692 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4693
ff4de4aa
TZ
46942011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4695
4696 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4697 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4698 as passed in.
4699
abe95abb
JD
47002011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4701
4702 * xterm.c (x_set_frame_alpha): Do not set property on anything
4703 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4704
e16e55d4
JB
47052011-05-02 Juanma Barranquero <lekktu@gmail.com>
4706
4707 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4708
bafcf6a5
JB
47092011-05-02 Juanma Barranquero <lekktu@gmail.com>
4710
4711 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4712 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4713 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4714 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4715 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4716 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4717 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4718 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4719 (Qgnutls_bootprop_callbacks_verify): Make static.
4720
e7a6747f
AS
47212011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4722
19ed11ba
AS
4723 * callproc.c: Indentation fixup.
4724
e7a6747f 4725 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4726 (wait_for_termination, interruptible_wait_for_termination):
4727 Move after wait_for_termination_1.
e7a6747f 4728
1ef14cb4
LMI
47292011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4730
4731 * sysdep.c (interruptible_wait_for_termination): New function
4732 which is like wait_for_termination, but allows keyboard
4733 interruptions.
4734
4735 * callproc.c (Fcall_process): Add (:file "file") as an option for
4736 the STDOUT buffer.
4737 (Fcall_process_region): Ditto.
4738
330d880c
EZ
47392011-04-30 Eli Zaretskii <eliz@gnu.org>
4740
8db90b73
EZ
4741 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4742 rather than `XVECTOR (FOO)->size'.
4743
330d880c
EZ
4744 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4745 inttypes.h, as a gnulib replacement is used if it not available in
4746 system headers.
4747
15cbd324
EZ
47482011-04-21 Eli Zaretskii <eliz@gnu.org>
4749
4750 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4751 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4752 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4753
4754 * coding.c (coding_alloc_by_realloc): Error out if destination
4755 will grow beyond MOST_POSITIVE_FIXNUM.
4756 (decode_coding_emacs_mule): Abort if there isn't enough place in
4757 charbuf for the composition carryover bytes. Reserve an extra
4758 space for up to 2 characters produced in a loop.
4759 (decode_coding_iso_2022): Abort if there isn't enough place in
4760 charbuf for the composition carryover bytes.
4761
47622011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4763
ae940cca
EZ
4764 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4765 aborting when %lld or %lll format is passed.
4766 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4767 %llo or %llx format is passed. (Bug#8545)
4768
03ab8921
EZ
4769 * window.c (window_scroll_line_based): Use a marker instead of
4770 simple variables to record original value of point. (Bug#7952)
4771
afda1437
EZ
4772 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4773 produced by %s or %c overflows available buffer space. (Bug#8545)
4774
f76dee0c
PE
47752011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4776
4777 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4778 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4779
fdc5744d
JB
47802011-04-28 Juanma Barranquero <lekktu@gmail.com>
4781
4782 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4783
638f053a
JB
47842011-04-28 Juanma Barranquero <lekktu@gmail.com>
4785
4786 * keyboard.c (Qdelayed_warnings_hook): Define.
4787 (command_loop_1): Run `delayed-warnings-hook'
4788 if Vdelayed_warnings_list is non-nil.
4789 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4790 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4791
d178f871
EZ
47922011-04-28 Eli Zaretskii <eliz@gnu.org>
4793
4794 * doprnt.c (doprnt): Don't return value smaller than the buffer
4795 size if the message was truncated. (Bug#8545).
4796
b124fd93
JB
47972011-04-28 Juanma Barranquero <lekktu@gmail.com>
4798
4799 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4800 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4801
e810457d
PE
48022011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4803
4804 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4805
ea51cceb
JB
48062011-04-27 Juanma Barranquero <lekktu@gmail.com>
4807
4808 * makefile.w32-in: Update dependencies.
4809
94dcfacf
EZ
48102011-04-27 Eli Zaretskii <eliz@gnu.org>
4811
4812 Improve `doprnt' and its usage. (Bug#8545)
4813 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4814 `format_end'. Remove support for %l as a conversion specifier.
4815 Don't use xrealloc. Improve diagnostics when the %l size modifier
4816 is used. Update the commentary.
4817
4818 * eval.c (verror): Simplify calculation of size_t.
4819
4820 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4821 messages.
4822
f61f41d7
PE
48232011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4824
4825 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4826 change.
4827
96fb4434
PE
48282011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4829
4830 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4831 This makes this file independent of the recent pseudovector change.
4832
671875da 48332011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4834
69e9b5a3
PE
4835 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4836
b5f869a7 4837 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4838 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4839 Remove unused local.
c8926152 4840 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4841
841a1577 4842 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4843 GCC 4.6.0 optimizes based on type-based alias analysis.
4844 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4845 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4846 != &v->size, and therefore "v->size = 1; b->size = 2; return
4847 v->size;" must therefore return 1. This assumption is incorrect
4848 for Emacs, since it type-puns struct Lisp_Vector * with many other
4849 types. To fix this problem, this patch adds a new type struct
f904488f 4850 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4851 and pseudovectors, and helps optimizing compilers not get fooled
4852 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4853 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4854 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4855 the size member.
eab3844f
PE
4856 (XSETPVECTYPE): Rewrite in terms of new macro.
4857 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4858 This is a bit clearer, and further avoids the possibility of
4859 undesirable aliasing.
4860 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4861 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4862 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4863 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4864 (ASIZE): Now uses header.size rather than size.
4865 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4866 to avoid the hassle of writing XVECTOR (foo)->header.size.
4867 (struct vectorlike_header): New type.
eab3844f
PE
4868 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4869 object, to help avoid aliasing.
4870 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4871 (SUBRP): Likewise, since Lisp_Subr is a special case.
4872 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4873 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4874 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4875 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4876 changed to be "header.size" and "header.next".
4877 * buffer.h (struct buffer): Likewise.
4878 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4879 * frame.h (struct frame): Likewise.
4880 * process.h (struct Lisp_Process): Likewise.
4881 * termhooks.h (struct terminal): Likewise.
4882 * window.c (struct save_window_data, struct saved_window): Likewise.
4883 * window.h (struct window): Likewise.
4884 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4885 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4886 * buffer.c (init_buffer_once): Likewise.
4887 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4888 special case.
4889 * process.c (Fformat_network_address): Use local var for size,
4890 for brevity.
4891
0df1eac5
PE
4892 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4893
847ab9d1 4894 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4895 * data.c (atof): Remove decl; no longer used or needed.
4896 (digit_to_number): Move to lread.c.
4897 (Fstring_to_number): Use new string_to_number function, to be
4898 consistent with how the Lisp reader treats infinities and NaNs.
4899 Do not assume that floating-point numbers represent EMACS_INT
4900 without losing information; this is not true on most 64-bit hosts.
4901 Avoid double-rounding errors, by insisting on integers when
4902 parsing non-base-10 numbers, as the documentation specifies.
4903 * lisp.h (string_to_number): New decl, replacing ...
4904 (isfloat_string): Remove.
bc0a5c13 4905 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4906 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4907 appears to have been a coding error. Similarly, do not accept
4908 strings like +-1e0 as floating point numbers. Do not report
4909 overflow for integer overflows unless the base is not 10 which
4910 means we have no simple and reliable way to continue.
4911 Break out the floating-point parsing into a new
4912 function string_to_number, so that Fstring_to_number parses
4913 floating point numbers consistently with the Lisp reader.
04f2d78b 4914 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4915 (E_CHAR, EXP_INT): Remove, replacing with ...
4916 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4917 (string_to_number): New function, replacing isfloat_string.
4918 This function checks for valid syntax and produces the resulting
4919 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4920 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4921 so that overflow for non-base-10 numbers is reported only when
4922 there's no portable and simple way to convert to floating point.
452f4150 4923
67769ffc
PE
4924 * textprop.c (set_text_properties_1): Rewrite for clarity,
4925 and to avoid GCC warning about integer overflow.
4926
c20db43f
PE
4927 * intervals.h (struct interval): Use EMACS_INT for members
4928 where EMACS_UINT might cause problems. See
4929 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4930 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4931 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4932 All uses changed.
37aa2f85
PE
4933 (offset_intervals): Tell GCC not to worry about length overflow
4934 when negating a negative length.
c20db43f 4935
2538aa2f
PE
4936 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4937 (overrun_check_free): Likewise.
4938
f2d3008d
PE
4939 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4940 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4941 word size.
4942
ec8df744
PE
4943 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4944 (gnutls_make_error): Rename local to avoid shadowing.
4945 (gnutls_emacs_global_deinit): ifdef out; not used.
4946 (Fgnutls_boot): Use const for pointer to readonly storage.
4947 Comment out unused local. Fix pointer signedness problems.
4948
640ee02d
PE
4949 * lread.c (openp): Don't stuff size_t into an 'int'.
4950 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4951 about possible signed overflow.
4952
6048fb2a
PE
4953 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4954 (GDK_KEY_g): Don't define if already defined.
4955 (xg_prepare_tooltip): Avoid pointer signedness problem.
4956 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4957
fa3c87e1
PE
4958 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4959 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4960
2172544b
PE
4961 * xfns.c (Fx_window_property): Simplify a bit,
4962 to make a bit faster and to avoid GCC 4.6.0 warning.
4963 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4964
9b821a21
PE
4965 * fns.c (internal_equal): Don't assume size_t fits in int.
4966
3c616cfa
PE
4967 * alloc.c (compact_small_strings): Tighten assertion a little.
4968
c2982e87
PE
4969 Replace pEd with more-general pI, and fix some printf arg casts.
4970 * lisp.h (pI): New macro, generalizing old pEd macro to other
4971 conversion specifiers. For example, use "...%"pI"d..." rather
4972 than "...%"pEd"...".
4973 (pEd): Remove. All uses replaced with similar uses of pI.
4974 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4975 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4976 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4977 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4978 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4979 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4980 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4981 64-bit hosts.
4982 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4983 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4984 * print.c (safe_debug_print, print_object): Likewise.
4985 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4986 to int.
6f04d126
PE
4987 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4988 avoiding the 0 flag, which is not portable.
c2982e87
PE
4989 * process.c (Fmake_network_process): Use pI to avoid cast.
4990 * region-cache.c (pp_cache): Likewise.
4991 * xdisp.c (decode_mode_spec): Likewise.
4992 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4993 behavior on 64-bit hosts with printf arg.
6f04d126 4994 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4995 (x_stop_queuing_selection_requests): Likewise.
4996 (x_get_window_property): Don't truncate byte count to an 'int'
4997 when tracing.
0b432f21 4998
5e073ec7
PE
4999 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5000 here, since it parses constructs like leading '-' and spaces,
5001 which are not wanted; and it overflows with large numbers.
5002 Instead, simply match F[0-9]+, which is what is wanted anyway.
5003
36372bf9
PE
5004 * alloc.c: Remove unportable assumptions about struct layout.
5005 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5006 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5007 (allocate_vectorlike, make_pure_vector): Use the new macros,
5008 plus offsetof, to remove unportable assumptions about struct layout.
5009 These assumptions hold on all porting targets that I know of, but
5010 they are not guaranteed, they're easy to remove, and removing them
5011 makes further changes easier.
5012
0b432f21
PE
5013 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5014 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5015 (string_overrun_cookie): Now const. Use initializers that
5016 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5017 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5018 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5019 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5020 multiple of sizeof (EMACS_INT); it need not be, if
5021 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5022 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5023
895009e1
JB
50242011-04-26 Juanma Barranquero <lekktu@gmail.com>
5025
5026 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5027
6a7a1b0b
TZ
50282011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5029
5030 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5031 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5032 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5033
841a1577 50342011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5035
5036 * lisp.h (Qdebug): List symbol.
895009e1 5037 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5038 * keyboard.c (debug-on-event): New variable.
5039 (handle_user_signal): Break into debugger when debug-on-event
5040 matches the current signal symbol.
5041
f2d3ba6f
DN
50422011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5043
5044 * alloc.c (check_sblock, check_string_bytes)
5045 (check_string_free_list): Convert to standard C.
5046
42ce4c63
TZ
50472011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5048
5049 * w32.c (emacs_gnutls_push): Fix typo.
5050
825cd63c
EZ
50512011-04-25 Eli Zaretskii <eliz@gnu.org>
5052
fb11d64d
EZ
5053 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5054 "cast to pointer from integer of different size".
5055
825cd63c
EZ
5056 Improve doprnt and its use in verror. (Bug#8545)
5057 * doprnt.c (doprnt): Document the set of format control sequences
5058 supported by the function. Use SAFE_ALLOCA instead of always
5059 using `alloca'.
5060
5061 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5062 is one byte too soon. Don't use xrealloc; instead xfree and
5063 xmalloc anew.
5064
e061a11b
TZ
50652011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5066
5067 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5068 callbacks stage.
5069
5070 * gnutls.c: Renamed global_initialized to
5071 gnutls_global_initialized. Added internals for the
5072 :verify-hostname-error, :verify-error, and :verify-flags
5073 parameters of `gnutls-boot' and documented those parameters in the
5074 docstring. Start callback support.
9173deec
JB
5075 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5076 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5077 on error. Return error code.
e061a11b
TZ
5078 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5079 (emacs_gnutls_read): Likewise.
5080 (Fgnutls_boot): Return handshake error code.
5081 (emacs_gnutls_handle_error): New function.
5082 (wsaerror_to_errno): Likewise.
5083
5084 * w32.h (emacs_gnutls_pull): Add prototype.
5085 (emacs_gnutls_push): Likewise.
5086
5087 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5088 (emacs_gnutls_push): Likewise.
5089
50902011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5091
5092 * process.c (wait_reading_process_output): Check if GnuTLS
5093 buffered some data internally if no FDs are set for TLS
5094 connections.
5095
5096 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5097 (LIBS): Link to USER_LIBS.
5098 ($(BLD)/gnutls.$(0)): New target.
5099
fa6996bc
EZ
51002011-04-24 Eli Zaretskii <eliz@gnu.org>
5101
eb35682e
EZ
5102 * xdisp.c (handle_single_display_spec): Rename the
5103 display_replaced_before_p argument into display_replaced_p, to
5104 make it consistent with the commentary. Fix typos in the
5105 commentary.
5106
e2ad650c
EZ
5107 * textprop.c (syms_of_textprop): Remove dead code.
5108 (copy_text_properties): Delete obsolete commentary about an
5109 interface that was deleted long ago. Fix typos in the description
5110 of arguments.
5111
1b2de274
EZ
5112 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5113 to changes in oldXMenu/XMenu.h from 2011-04-16.
5114 <menu_help_message, prev_menu_help_message>: Constify.
5115 (IT_menu_make_room): menu->help_text is now `const char **';
5116 adjust.
5117
5118 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5119 to changes in oldXMenu/XMenu.h from 2011-04-16.
5120 (struct XMenu): Declare `help_text' `const char **'.
5121
5122 * xfaces.c <Qunspecified>: Make extern again.
5123
5124 * syntax.c: Include sys/types.h before including regex.h, as
5125 required by Posix.
5126
762b15be
EZ
5127 * doc.c (get_doc_string): Improve the format passed to `error'.
5128
5129 * doprnt.c (doprnt): Improve commentary.
5130
5131 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5132
5133 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5134 them with etags.
5135
f1052e5d
EZ
5136 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5137 changes in globals.h immediately force recompilation.
762b15be
EZ
5138 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5139 $(CURDIR)/s/ms-w32.h.
5140 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5141
fa6996bc
EZ
5142 * character.c (Fchar_direction): Function deleted.
5143 (syms_of_character): Don't defsubr it.
5144 <char-direction-table>: Deleted.
5145
e6c3da20
EZ
51462011-04-23 Eli Zaretskii <eliz@gnu.org>
5147
5148 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5149 * doprnt.c: Include limits.h.
5150 (SIZE_MAX): New macro.
04f2d78b
CB
5151 (doprnt): Return a size_t value. 2nd arg is now size_t.
5152 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5153 Improve overflow protection. Support `l' modifier for integer
5154 conversions. Support %l conversion. Don't assume an EMACS_INT
5155 argument for integer conversions and for %c.
5156
5157 * lisp.h (doprnt): Restore prototype.
5158
5159 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5160 $(SRC)/character.h.
5161
5162 * Makefile.in (base_obj): Add back doprnt.o.
5163
5164 * deps.mk (doprnt.o): Add back prerequisites.
5165 (callint.o): Depend on character.h.
5166
5167 * eval.c (internal_lisp_condition_case): Include the handler
5168 representation in the error message.
5169 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5170 when breaking from the loop.
5171
5172 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5173
5174 * callint.c (Fcall_interactively): When displaying error message
5175 about invalid control letter, pass the character's codepoint, not
5176 a pointer to its multibyte form. Improve display of the character
5177 in octal and display also its hex code.
5178
5179 * character.c (char_string): Use %x to display the (unsigned)
5180 codepoint of an invalid character, to avoid displaying a bogus
5181 negative value.
5182
5183 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5184 `error', not SYMBOL_NAME itself.
5185
5186 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5187 character arguments to `error'.
5188
5189 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5190 to `error' in error message about FINAL_CHAR argument. Make sure
5191 FINAL_CHAR is a character, and use %c when it is passed as
5192 argument to `error'.
5193
4ffd0d6b 51942011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5195
5196 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5197
5198 * w32.c: Include <time.h>.
5199 (sys_localtime): New function.
5200
4ffd0d6b 52012011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5202
5203 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5204
4ffd0d6b 5205 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5206
4ffd0d6b 52072011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5208
4ffd0d6b
GM
5209 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5210 zombies (Bug#8467).
aac0c6e3 5211
04c56954
EZ
52122011-04-19 Eli Zaretskii <eliz@gnu.org>
5213
5214 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5215 gl_state.e_property when gl_state.object is Qt.
5216
5217 * insdel.c (make_gap_larger): Remove limitation of buffer size
5218 to <= INT_MAX.
5219
16a43933
CY
52202011-04-18 Chong Yidong <cyd@stupidchicken.com>
5221
5222 * xdisp.c (lookup_glyphless_char_display)
5223 (produce_glyphless_glyph): Handle cons cell entry in
5224 glyphless-char-display.
5225 (Vglyphless_char_display): Document it.
5226
5227 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5228 glyphless-char-display.
5229
4581706e
CY
52302011-04-17 Chong Yidong <cyd@stupidchicken.com>
5231
5232 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5233
5234 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5235
5236 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5237 definition for no-X builds.
5238
4887c6e2 52392011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5240
fd35b6f9
PE
5241 Static checks with GCC 4.6.0 and non-default toolkits.
5242
5c1ccb01
PE
5243 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5244
006c5daa
PE
5245 * process.c (keyboard_bit_set): Define only if SIGIO.
5246 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5247 (send_process): Repair possible setjmp clobbering.
5248
efc736d3
PE
5249 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5250
4e2fe2e6
PE
5251 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5252
f97334a2
PE
5253 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5254
4e75f29d
PE
5255 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5256 Define only if needed.
5257
90efadd1
PE
5258 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5259 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5260 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5261
3c647824
PE
5262 * dispextern.h (struct redisplay_interface): Rename param
5263 to avoid shadowing.
e264f262 5264 * termhooks.h (struct terminal): Likewise.
761383f4 5265 * xterm.c (xembed_send_message): Likewise.
3c647824 5266
b58c5c4a
PE
5267 * insdel.c (make_gap_smaller): Define only if
5268 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5269
cad59032
PE
5270 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5271 it.
5272
c339dc2e
PE
5273 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5274 so that we aren't warned about unused symbols.
5275
91a3e27b
PE
5276 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5277
399c71d3 5278 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5279
8ffc96f5
PE
5280 * xfns.c (x_real_positions): Mark locals as initialized.
5281
eef9bc79
PE
5282 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5283
098db9dd
PE
5284 * xterm.c: Fix problems found by static analysis with other toolkits.
5285 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5286 (x_dispatch_event): Declare static if USE_GTK, and
5287 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5288 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5289 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5290 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5291 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5292
eb18f6cc
PE
5293 * xmenu.c (menu_help_callback): Pointer type fixes.
5294 Use const pointers when pointing at readonly data. Avoid pointer
5295 signedness clashes.
5296 (FALSE): Remove unused macro.
5297 (update_frame_menubar): Remove unused decl.
5298
1fe72bf8
PE
5299 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5300
60d9e1db
PE
5301 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5302 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5303 (single_menu_item): Rename local to avoid shadowing.
5304
39261c26
PE
5305 * keyboard.c (make_lispy_event): Remove unused local var.
5306
018c5e19
PE
5307 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5308 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5309
63d2b86e
PE
5310 * bitmaps: Change bitmaps from unsigned char back to the X11
5311 compatible char. Avoid the old compiler warnings about
5312 out-of-range initializers by using, for example, '\xab' rather
5313 than 0xab.
5314
aefd87e1
PE
5315 * xgselect.c (xgselect_initialize): Check vs interface
5316 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5317
bf501fb9
PE
5318 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5319
e9829fdf
PE
5320 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5321 to read-only memory.
5322
1086c095
PE
5323 * fns.c (vector): Remove; this old hack is no longer needed.
5324
2baccd04 5325 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5326 Remove unused var.
dde42981 5327 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5328
72391843 5329 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5330
436c16df 5331 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5332 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5333 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5334
92bb796d 5335 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5336 (x_term_init): Remove local to avoid shadowing.
92bb796d 5337
764430a3 5338 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5339
5340 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5341 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5342
d1dfb56c
EZ
53432011-04-16 Eli Zaretskii <eliz@gnu.org>
5344
c4354cb4
EZ
5345 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5346
d1dfb56c
EZ
5347 Fix regex.c, syntax.c and friends for buffers > 2GB.
5348 * syntax.h (struct gl_state_s): Declare character position members
5349 EMACS_INT.
5350
5351 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5352
04f2d78b
CB
5353 * textprop.c (verify_interval_modification, interval_of):
5354 Declare arguments EMACS_INT.
d1dfb56c
EZ
5355
5356 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5357 EMACS_INT.
5358
5359 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5360
5361 * indent.c (Fvertical_motion): Local variable it_start is now
5362 EMACS_INT.
5363
5364 * regex.c (re_match, re_match_2, re_match_2_internal)
5365 (bcmp_translate, regcomp, regexec, print_double_string)
5366 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5367 (re_compile_pattern, re_exec): Declare arguments and local
5368 variables `size_t' and `ssize_t' and return values `regoff_t', as
5369 appropriate.
5370 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5371 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5372 <compile_stack_type>: `size' and `avail' are now `size_t'.
5373
5374 * regex.h <regoff_t>: Use ssize_t, not int.
5375 (re_search, re_search_2, re_match, re_match_2): Arguments that
5376 specify buffer/string position and length are now ssize_t and
5377 size_t. Return type is regoff_t.
5378
613052cd
BK
53792011-04-16 Ben Key <bkey76@gmail.com>
5380
5381 * nsfont.m: Fixed bugs in ns_get_family and
5382 ns_descriptor_to_entity that were caused by using free to
5383 deallocate memory blocks that were allocated by xmalloc (via
5384 xstrdup). This caused Emacs to crash when compiled with
5385 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5386 --enable-checking=xmallocoverrun). xfree is now used to
5387 deallocate these memory blocks.
5388
4170f62f 53892011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5390
71b41406
PE
5391 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5392
9587a89d
PE
5393 emacs_write: Accept and return EMACS_INT for sizes.
5394 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5395 et seq.
5396 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5397 Accept and return EMACS_INT.
5398 (emacs_gnutls_write): Return the number of bytes written on
5399 partial writes.
5400 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5401 (emacs_read, emacs_write): Remove check for negative size, as the
5402 Emacs source code has been audited now.
9587a89d
PE
5403 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5404 (emacs_read, emacs_write): Use it.
273a5f82
PE
5405 * process.c (send_process): Adjust to the new signatures of
5406 emacs_write and emacs_gnutls_write. Do not attempt to store
5407 a byte offset into an 'int'; it might overflow.
9587a89d 5408 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5409
3e047f51
PE
5410 * sound.c: Don't assume sizes fit in 'int'.
5411 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5412 Return EMACS_INT, not int.
3e047f51 5413 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5414 Accept EMACS_INT, not int.
5415 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5416 record read return values.
5417
cc39a9db
BK
54182011-04-15 Ben Key <bkey76@gmail.com>
5419
c9d0ec6d
JB
5420 * keyboard.c (Qundefined): Don't declare static since it is used
5421 in nsfns.m.
5422 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5423 static since they are used in nsfont.m.
cc39a9db 5424
6c60eb9f
SM
54252011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5426
5427 * process.c (Qprocessp): Don't declare static.
5428 * lisp.h (Qprocessp): Declare again.
5429
7990b61a
JB
54302011-04-15 Juanma Barranquero <lekktu@gmail.com>
5431
5432 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5433
5d4cb038
PE
54342011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5435
8bd7b830 5436 Improve C-level modularity by making more things 'static'.
cd64ea1d 5437
e3b27b31
PE
5438 Don't publish debugger-only interfaces to other modules.
5439 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5440 (verify_bytepos, count_markers): Move decls to the only modules
5441 that need them.
5442 * region-cache.h (pp_cache): Likewise.
5443 * window.h (check_all_windows): Likewise.
5444 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5445
5d4cb038
PE
5446 * sysdep.c (croak): Now static, if
5447 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5448 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5449
5450 * alloc.c (refill_memory_reserve): Now static if
5451 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5452 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5453
e87b6180
PE
5454 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5455 Define only if USE_LUCID.
5456
ac64929e
PE
5457 * xrdb.c (x_customization_string, x_rm_string): Now static.
5458
6f37259d
PE
5459 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5460 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5461
1683e3ab
PE
5462 * xdisp.c (draw_row_with_mouse_face): Now static.
5463 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5464
de9c2632
PE
5465 * window.h (check_all_windows): Mark externally visible.
5466
2b96acb7
PE
5467 * window.c (window_deletion_count): Now static.
5468
5469 * undo.c: Make symbols static if they're not exported.
5470 (last_undo_buffer, last_boundary_position, pending_boundary):
5471 Now static.
5472
50436f33
PE
5473 * textprop.c (interval_insert_behind_hooks): Now static.
5474 (interval_insert_in_front_hooks): Likewise.
5475
64520e5c
PE
5476 * term.c: Make symbols static if they're not exported.
5477 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5478 (max_frame_lines, tty_set_terminal_modes):
5479 (tty_reset_terminal_modes, tty_turn_off_highlight):
5480 (get_tty_terminal): Now static.
5481 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5482 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5483 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5484 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5485 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5486
1fa53021
PE
5487 * sysdep.c: Make symbols static if they're not exported.
5488 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5489 Now static.
5490 (sigprocmask_set, full_mask): Remove; unused.
5491 (wait_debugging): Mark as visible.
5492 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5493 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5494
d4b43b22
PE
5495 * syntax.c (syntax_temp): Define only if !__GNUC__.
5496
b7c513d0
PE
5497 * sound.c (current_sound_device, current_sound): Now static.
5498
989b29ad
PE
5499 * search.c (searchbufs, searchbuf_head): Now static.
5500
13a55a78
PE
5501 * scroll.c (scroll_cost): Remove; unused.
5502 * dispextern.h (scroll_cost): Remove decl.
5503
de68a1fc
PE
5504 * region-cache.h (pp_cache): Mark as externally visible.
5505
40ccffa6
PE
5506 * process.c: Make symbols static if they're not exported.
5507 (process_tick, update_tick, create_process, chan_process):
5508 (Vprocess_alist, proc_buffered_char, datagram_access):
5509 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5510 (deactivate_process): Mark defn as static, as well as decl.
5511 * lisp.h (create_process): Remove decl.
5512 * process.h (chan_process, Vprocess_alist): Remove decls.
5513
ad64fc97
PE
5514 * print.c: Make symbols static if they're not exported.
5515 (print_depth, new_backquote_output, being_printed, print_buffer):
5516 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5517 (print_interval, print_number_index, initial_stderr_stream):
5518 Now static.
5519 * lisp.h (Fprinc): Remove decl.
5520 (debug_output_compilation_hack): Mark as externally visible.
5521
adddb265
PE
5522 * sysdep.c (croak): Move decl from here to syssignal.h.
5523 * syssignal.h (croak): Put it here, so the API can be checked when
5524 'croak' is called from dissociate_if_controlling_tty.
5525
1717ede2
PE
5526 * minibuf.c: Make symbols static if they're not exported.
5527 (minibuf_save_list, choose_minibuf_frame): Now static.
5528 * lisp.h (choose_minibuf_frame): Remove decl.
5529
fa5fb2bc
PE
5530 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5531
1e3890d1
PE
5532 * lread.c: Make symbols static if they're not exported.
5533 (read_objects, initial_obarray, oblookup_last_bucket_number):
5534 Now static.
5535 (make_symbol): Remove; unused.
5536 * lisp.h (initial_obarray, make_symbol): Remove decls.
5537
8a1414fa
PE
5538 * keyboard.c: Make symbols static if they're not exported.
5539 (single_kboard, recent_keys_index, total_keys, recent_keys):
5540 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5541 (this_single_command_key_start, echoing, last_auto_save):
5542 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5543 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5544 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5545 (Vlispy_mouse_stem, double_click_count):
5546 Now static.
5547 (force_auto_save_soon): Define only if SIGDANGER.
5548 (ignore_mouse_drag_p): Now static if
5549 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5550 (print_help): Remove; unused.
5551 (stop_character, last_timer_event): Mark as externally visible.
5552 * keyboard.h (ignore_mouse_drag_p): Declare only if
5553 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5554 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5555 * lisp.h (echoing): Remove decl.
5556 (force_auto_save_soon): Declare only if SIGDANGER.
5557 * xdisp.c (redisplay_window): Simplify code, to make it more
5558 obvious that ignore_mouse_drag_p is not accessed if !defined
5559 USE_GTK && !defined HAVE_NS.
5560
93ea6e8f
PE
5561 * intervals.c: Make symbols static if they're not exported.
5562 (merge_properties_sticky, merge_interval_right, delete_interval):
5563 Now static.
5564 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5565
77382fcc
PE
5566 * insdel.c: Make symbols static if they're not exported.
5567 However, leave prepare_to_modify_buffer alone. It's never
5568 called from outside this function, but that appears to be a bug.
5569 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5570 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5571 (adjust_after_replace_noundo): Remove; unused.
5572 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5573 (signal_before_change): Remove decls.
77382fcc 5574
9306c32e
PE
5575 * indent.c (val_compute_motion, val_vmotion): Now static.
5576
cd44d2eb
PE
5577 * image.c: Make symbols static if they're not exported.
5578 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5579 if USE_GTK.
5580 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5581 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5582
ad9a7a06
PE
5583 * fringe.c (standard_bitmaps): Now static.
5584 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5585
81626931
PE
5586 * frame.c: Make symbols static if they're not exported.
5587 (x_report_frame_params, make_terminal_frame): Now static.
5588 (get_frame_param): Now static, unless HAVE_NS.
5589 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5590 (x_get_resource_string): Remove; not used.
5591 * frame.h (make_terminal_frame, x_report_frame_params):
5592 (x_get_resource_string); Remove decls.
5593 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5594 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5595
239f9db9
PE
5596 * font.c, fontset.c: Make symbols static if they're not exported.
5597 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5598 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5599 * font.c (font_close_object): Now static.
5600 * font.h (font_close_object): Remove.
5601 * fontset.c (FONTSET_OBJLIST): Remove.
5602 (free_realized_fontset) #if-0 the body, which does nothing.
5603 (face_suitable_for_char_p): #if-0, as it's never called.
5604 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5605 * xfaces.c (face_at_string_position):
5606 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5607 since 0 is always ASCII.
5608
dfcf3579
PE
5609 * fns.c (weak_hash_tables): Now static.
5610
5045092b
PE
5611 * fileio.c: Make symbols static if they're not exported.
5612 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5613 (Vwrite_region_annotation_buffers): Now static.
5614
57a96f5c
PE
5615 * eval.c: Make symbols static if they're not exported.
5616 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5617 * lisp.h (backtrace_list): Remove decl.
5618
35f08c38
PE
5619 * emacs.c: Make symbols static if they're not exported.
5620 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5621 (fatal_error_code, fatal_error_signal_hook, standard_args):
5622 Now static.
5623 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5624 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5625 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5626 * lisp.h (fatal_error_signal_hook): Remove decl.
5627 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5628
f44bd759
PE
5629 * editfns.c: Move a (normally-unused) function to its only use.
5630 * editfns.c, lisp.h (get_operating_system_release): Remove.
5631 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5632 worth the hassle of breaking this out.
5633
b532497d
PE
5634 * xterm.c: Make symbols static if they're not exported.
5635 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5636 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5637 (x_destroy_window, x_delete_display):
5638 Now static.
5639 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5640 (x_mouse_leave): Remove; unused.
5641 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5642 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5643 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5644 Remove decls.
5645 (x_mouse_leave): Declare only if WINDOWSNT.
5646 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5647 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5648 USE_X_TOOLKIT.
5649
1675728f
PE
5650 * ftxfont.c: Make symbols static if they're not exported.
5651 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5652 HAVE_FREETYPE.
5653 * font.h (ftxfont_driver): Likewise.
5654
e4cebfca
PE
5655 * xfns.c: Make symbols static if they're not exported.
5656 (x_last_font_name, x_display_info_for_name):
5657 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5658 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5659 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5660 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5661 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5662 (last_show_tip_args): Now static.
5663 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5664 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5665 (x_screen_planes): Remove; unused.
5666 * dispextern.h (x_screen_planes): Remove decl.
5667
5bf46f05
PE
5668 * dispnew.c: Make symbols static if they're not exported.
5669 * dispextern.h (redraw_garbaged_frames, scrolling):
5670 (increment_row_positions): Remove.
5671 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5672 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5673 Now static.
5674 (redraw_garbaged_frames): Remove; unused.
5675
435f4c28
PE
5676 * xfaces.c: Make symbols static if they're not exported.
5677 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5678 Remove decls.
5679 * xterm.h (defined_color): Remove decls.
5680 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5681 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5682 (menu_face_changed_default, defined_color, free_realized_face):
5683 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5684 (ascii_face_of_lisp_face): Remove; unused.
5685
8524aef3
PE
5686 * xdisp.c: Make symbols static if they're not exported.
5687 * dispextern.h (scratch_glyph_row, window_box_edges):
5688 (glyph_to_pixel_coords, set_cursor_from_row):
5689 (get_next_display_element, set_iterator_to_next):
5690 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5691 (show_mouse_face): Remove decls
5692 * frame.h (message_buf_print): Likewise.
5693 * lisp.h (pop_message, set_message, check_point_in_composition):
5694 Likewise.
5695 * xterm.h (set_vertical_scroll_bar): Likewise.
5696 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5697 (message_buf_print, scratch_glyph_row, displayed_buffer):
5698 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5699 (get_next_display_element, show_mouse_face, window_box_edges):
5700 (frame_to_window_pixel_xy, check_point_in_composition):
5701 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5702 (glyph_to_pixel_coords): Remove; unused.
5703
16390cd2
PE
5704 * dired.c (file_name_completion): Now static.
5705
5706 * dbusbind.c (xd_in_read_queued_messages): Now static.
5707
a25f4dfa
PE
5708 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5709 * data.c (circular_list_error): Remove.
5710
14a9c8df
PE
5711 * commands.h (last_point_position, last_point_position_buffer):
5712 (last_point_position_window): Remove decls.
5713 * keyboard.c: Make these variables static.
5714
04f2d78b
CB
5715 * coding.h (coding, code_convert_region, encode_coding_gap):
5716 Remove decls.
74ab6df5
PE
5717 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5718 (iso_code_class, detect_coding, code_convert_region): Now static.
5719 (encode_coding_gap): Remove; unused.
5720
38dfbee1
PE
5721 * chartab.c (chartab_chars, chartab_bits): Now static.
5722
a2cb4e63
PE
5723 * charset.h (charset_iso_8859_1): Remove decl.
5724 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5725 Now static.
5726
127198fd
PE
5727 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5728 * ccl.c (Vccl_program_table): Now static.
5729 (check_ccl_update): Remove; unused.
5730
d85b608f
PE
5731 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5732 * category.h: ... from here.
5733 * category.c (check_category_table, set_category_set): Now static.
5734
31cd66f3
PE
5735 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5736 * lisp.h: Remove these decls.
5737
c358e587
PE
5738 * buffer.c (buffer_count): Remove unused var.
5739
e78aecca
PE
5740 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5741 so that it's not optimized away.
5742 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5743 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5744 exported only to the debugger.
5745
e192d7d3 5746 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5747 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5748
92470028
PE
5749 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5750 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5751 was inaccessible from Lisp.
5752 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5753 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5754
244ed907
PE
5755 alloc.c: Import and export fewer symbols, and remove unused items.
5756 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5757 is defined.
5758 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5759 it's not optimized away by whole-program optimization.
5760 (message_enable_multibyte, free_misc): Remove.
5761 (catchlist, handlerlist, mark_backtrace):
5762 Declare only if BYTE_MARK_STACK.
5763 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5764 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5765 (message_enable_multibyte): Remove decl.
5766 (free_misc, interval_free_list, float_block, float_block_index):
5767 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5768 (cons_free_list, last_marked_index):
5769 Now static.
5770 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5771 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5772 (mark_backtrace): Define only if BYTE_MARK_STACK.
5773 * xdisp.c (message_enable_multibyte): Now static.
5774
61c2b50e 5775 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5776 This makes it easier for human readers (and static analyzers)
5777 to see whether these variables are used from other modules.
5778 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5779 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5780 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5781 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5782 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5783 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5784 * xmenu.c, xselect.c:
5785 Declare Q* vars static if they are not used in other modules.
5786 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5787 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5788 Remove decls of unexported vars.
5789 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5790
95c82688
PE
5791 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5792
16a97296
PE
5793 Make Emacs functions such as Fatom 'static' by default.
5794 This makes it easier for human readers (and static analyzers)
5795 to see whether these functions can be called from other modules.
5796 DEFUN now defines a static function. To make the function external
5797 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5798 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5799 (Finit_image_library):
16a97296
PE
5800 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5801 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5802 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5803 Remove decls, since these functions are now static.
5804 (Funintern, Fget_internal_run_time): New decls, since these functions
5805 were already external.
95c82688 5806
16a97296
PE
5807 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5808 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5809 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5810 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5811 * keyboard.c, keymap.c, lread.c:
5812 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5813 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5814 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5815 Mark functions with DEFUE instead of DEFUN,
5816 if they are used in other modules.
5817 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5818 decls for now-static functions.
5819 * buffer.h (Fdelete_overlay): Remove decl.
5820 * callproc.c (Fgetenv_internal): Mark as internal.
5821 * composite.c (Fremove_list_of_text_properties): Remove decl.
5822 (Fcomposition_get_gstring): New forward static decl.
5823 * composite.h (Fcomposite_get_gstring): Remove decl.
5824 * dired.c (Ffile_attributes): New forward static decl.
5825 * doc.c (Fdocumntation_property): New forward static decl.
5826 * eval.c (Ffetch_bytecode): New forward static decl.
5827 (Funintern): Remove extern decl; now in .h file where it belongs.
5828 * fileio.c (Fmake_symbolic_link): New forward static decl.
5829 * image.c (Finit_image_library): New forward static decl.
5830 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5831 * intervals.h (Fprevious_property_change):
5832 (Fremove_list_of_text_properties): Remove decls.
5833 * keyboard.c (Fthis_command_keys): Remove decl.
5834 (Fcommand_execute): New forward static decl.
5835 * keymap.c (Flookup_key): New forward static decl.
5836 (Fcopy_keymap): Now static.
5837 * keymap.h (Flookup_key): Remove decl.
5838 * process.c (Fget_process): New forward static decl.
5839 (Fprocess_datagram_address): Mark as internal.
5840 * syntax.c (Fsyntax_table_p): New forward static decl.
5841 (skip_chars): Remove duplicate decl.
5842 * textprop.c (Fprevious_property_change): New forward static decl.
5843 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5844 Now internal.
5845 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5846 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5847
785bbd42
PE
5848 * editfns.c (Fformat): Remove unreachable code.
5849
8b913b57
AS
58502011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5851
5852 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5853 change. (Bug#8496)
5854
a6744a35
EZ
58552011-04-13 Eli Zaretskii <eliz@gnu.org>
5856
5857 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5858 when at ZV. (Bug#8487)
5859
e7974947
AS
58602011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5861
baad03f0
AS
5862 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5863 (Bug#8437)
5864 * keyboard.c (parse_tool_bar_item): Likewise.
5865 * sound.c (sound_cleanup, alsa_close): Likewise.
5866 * termcap.c (tgetent): Likewise.
5867 * xfns.c (x_default_font_parameter): Likewise.
5868 * xsettings.c (read_and_apply_settings): Likewise.
5869
e7974947
AS
5870 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5871 (overrun_check_free): Protoize.
5872
28272684
PE
58732011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5874
5875 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5876 since callers should never pass a negative size.
5877 Change the signature to match that of plain 'read' and 'write'; see
5878 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5879 * lisp.h: Update prototypes of emacs_write and emacs_read.
5880
11997c76
EZ
58812011-04-11 Eli Zaretskii <eliz@gnu.org>
5882
5883 * xdisp.c (redisplay_window): Don't try to determine the character
5884 position of the scroll margin if the window start point w->startp
e896f03c 5885 is outside the buffer's accessible region. (Bug#8468)
11997c76 5886
8a2cbd72
EZ
58872011-04-10 Eli Zaretskii <eliz@gnu.org>
5888
5889 Fix write-region and its subroutines for buffers > 2GB.
5890 * fileio.c (a_write, e_write): Modify declaration of arguments and
5891 local variables to support buffers larger than 2GB.
5892 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5893
5894 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5895 argument, local variables, and return value.
5896
5897 * lisp.h: Update prototypes of emacs_write and emacs_read.
5898
5899 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5900
4073e537 59012011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5902
1ebfdcb6
PE
5903 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5904
b2ded58d
PE
5905 Fix more problems found by GCC 4.6.0's static checks.
5906
7d66342c
PE
5907 * xdisp.c (vmessage): Use a better test for character truncation.
5908
bbf47d44
PE
5909 * charset.c (load_charset_map): <, not <=, for optimization,
5910 and to avoid potential problems with integer overflow.
9248994d 5911 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5912 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5913 * editfns.c (Fformat): Likewise.
1e69125e 5914 * syntax.c (skip_chars): Likewise.
3befa583 5915
e3019616
PE
5916 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5917 This also lets GCC 4.6.0 generate slightly better loop code.
5918
becfa255
PE
5919 * callint.c (Fcall_interactively): <, not <=, for optimization.
5920 (Fcall_interactively): Count the number of arguments produced,
5921 not the number of arguments given. This is simpler and lets GCC
5922 4.6.0 generate slightly better code.
5923
dae0cd48
PE
5924 * ftfont.c: Distingish more carefully between FcChar8 and char.
5925 The previous code passed unsigned char * to a functions like
5926 strlen and xstrcasecmp that expect char *, which does not
5927 conform to the C standard.
5928 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5929 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5930 char * when the C standard requires it.
5931
76032d70
PE
5932 * keyboard.c (read_char): Remove unused var.
5933
eb3f1cc8
PE
5934 * eval.c: Port to Windows vsnprintf (Bug#8435).
5935 Include <limits.h>.
5936 (SIZE_MAX): Define if the headers do not.
5937 (verror): Do not give up if vsnprintf returns a negative count.
5938 Instead, grow the buffer. This ports to Windows vsnprintf, which
5939 does not conform to C99. Problem reported by Eli Zaretskii.
5940 Also, simplify the allocation scheme, by avoiding the need for
5941 calling realloc, and removing the ALLOCATED variable.
5942
70476b54
PE
5943 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5944
12020a9e
PE
5945 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5946 But keep the doprint source code for now, as we might revamp it
5947 and use it again (Bug#8435).
ea6c7ae6
PE
5948 * lisp.h (doprnt): Remove.
5949 * Makefile.in (base_obj): Remove doprnt.o.
5950 * deps.mk (doprnt.o): Remove.
5951
5fdb398c
PE
5952 error: Print 32- and 64-bit integers portably (Bug#8435).
5953 Without this change, on typical 64-bit hosts error ("...%d...", N)
5954 was used to print both 32- and 64-bit integers N, which relied on
5955 undefined behavior.
5956 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5957 New macro.
5958 * lisp.h (error, verror): Mark as printf-like functions.
5959 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5960 Report overflow in size calculations when allocating printf buffer.
5961 Do not truncate output string at its first null byte.
5962 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5963 Truncate the output at a character boundary, since vsnprintf does not
5964 do that.
5965 * charset.c (check_iso_charset_parameter): Convert internal
5966 character to string before calling 'error', since %c now has the
5967 printf meaning.
5968 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5969 overflow when computing char to be passed to 'error'. Do not
5970 pass Lisp_Object to 'error'; pass the integer instead.
5971 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5972 formatted with plain %d.
5973
b189fa66
PE
5974 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5975
bff87ef0
PE
5976 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5977
7e2cac20
PE
5978 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5979
ce4d90b5
PE
5980 * xterm.c (x_catch_errors): Remove duplicate declaration.
5981
266c9547
PE
5982 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5983
79c49ad2
PE
5984 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5985
368f4090
JM
59862011-04-10 Jim Meyering <meyering@redhat.com>
5987
5988 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5989 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5990 return ssize_t not "int", and use size_t as the buffer length.
5991 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5992 * gnutls.h: Update declarations.
5993 * process.c (read_process_output): Use ssize_t, to match.
5994 (send_process): Likewise.
5995
a32d4040
CY
59962011-04-09 Chong Yidong <cyd@stupidchicken.com>
5997
5998 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5999
8546720e 60002011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6001
04f2d78b
CB
6002 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6003 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6004
8546720e
GM
6005 * xterm.c (handle_one_xevent):
6006 * xmenu.c (create_and_show_popup_menu):
6007 * xselect.c (x_decline_selection_request)
6008 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6009
0a2f5c1a 60102011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6011
6012 Fix some uses of `int' instead of EMACS_INT.
6013 * search.c (string_match_1, fast_string_match)
6014 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6015 (scan_buffer, find_next_newline_no_quit)
6016 (find_before_next_newline, search_command, Freplace_match)
6017 (Fmatch_data): Make some `int' variables be EMACS_INT.
6018
6019 * xdisp.c (display_count_lines): 3rd argument and return value now
6020 EMACS_INT. All callers changed.
6021 (pint2hrstr): Last argument is now EMACS_INT.
6022
6023 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6024 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6025 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6026 (decode_coding_utf_16, decode_coding_emacs_mule)
6027 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6028 (decode_coding_ccl, decode_coding_charset)
6029 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6030 (decode_coding_iso_2022, decode_coding_emacs_mule)
6031 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6032 <char_offset, last_offset>: Declare EMACS_INT.
6033 (encode_coding_utf_8, encode_coding_utf_16)
6034 (encode_coding_emacs_mule, encode_invocation_designation)
6035 (encode_designation_at_bol, encode_coding_iso_2022)
6036 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6037 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6038 Declare EMACS_INT.
6039 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6040 (encode_invocation_designation): Last argument P_NCHARS is now
6041 EMACS_INT.
6042 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6043 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6044
6045 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6046 All users changed.
6047
6048 * ccl.c (Fccl_execute_on_string): Declare some variables
6049 EMACS_INT.
6050
8546720e 60512011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6052
6053 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6054
4e19a977
CS
60552011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6056
6057 * process.c (Fformat_network_address): Doc fix.
6058
87302331
R
60592011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6060
6061 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6062
cbb59342
CY
60632011-04-08 Chong Yidong <cyd@stupidchicken.com>
6064
6065 * keyboard.c (read_char): Call Lisp function help-form-show,
6066 instead of using internal_with_output_to_temp_buffer.
6067 (Qhelp_form_show): New var.
e0d38eeb 6068 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6069
6070 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6071
6072 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6073
e67a13ab
CY
60742011-04-06 Chong Yidong <cyd@stupidchicken.com>
6075
04f2d78b
CB
6076 * process.c (Flist_processes): Remove to Lisp.
6077 (list_processes_1): Delete.
e67a13ab 6078
973f782d
EZ
60792011-04-06 Eli Zaretskii <eliz@gnu.org>
6080
7c106b1e
EZ
6081 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6082
973f782d
EZ
6083 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6084
41cf7d1a 60852011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6086
ca23cc88
PE
6087 Fix more problems found by GCC 4.6.0's static checks.
6088
f390e2d5
PE
6089 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6090
42eea0d0
PE
6091 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6092
b69769da 6093 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6094
f9541e84
PE
6095 * xdisp.c (vmessage): Mark as a printf-like function.
6096
13841b55
PE
6097 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6098
c136c10f
PE
6099 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6100
5e2d4a30
PE
6101 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6102 printf-like functions.
6103 (tiff_load): Add casts to remove these marks before passing them
6104 to system-supplied API.
6105
583f48b9
PE
6106 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6107
b25d760e
PE
6108 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6109 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6110 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6111 directly, rather than having caller test rule sign. This avoids
6112 some unnecessary tests.
6113 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6114 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6115 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6116
bc7b6697 6117 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6118 (xfont_open): Avoid unnecessary tests.
bc7b6697 6119
27ccc379
PE
6120 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6121
dcd5c89a
PE
6122 * composite.h, composite.c (composition_gstring_put_cache):
6123 Use EMACS_INT, not int, for length.
6124
b13a45c6
PE
6125 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6126 breaking out part of COMPOSITION_DECODE_RULE.
6127 (COMPOSITION_DECODE_RULE): Use it.
6128 * composite.c (get_composition_id): Remove unused local vars,
6129 by using the new macro.
6130
1e792e4d
PE
6131 * textprop.c (set_text_properties_1): Change while to do-while,
6132 since the condition is always true at first.
6133
dc6c6455 6134 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6135 (interval_deletion_adjustment): Return unsigned value.
6136 All uses changed.
dc6c6455 6137
aba7731a
PE
6138 * process.c (list_processes_1, create_pty, read_process_output):
6139 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6140 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6141 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6142 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6143 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6144
fdfc4bf3
PE
6145 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6146
fca8fe46 6147 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6148 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6149
06a0259a 6150 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6151 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6152 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6153
e7b9e80f
PE
6154 * print.c (print_error_message): Avoid int overflow.
6155
56201685
PE
6156 * font.c (font_list_entities): Redo for clarity,
6157 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6158
78834453 6159 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6160 (font_score): Avoid potential overflow in diff calculation.
78834453 6161
0bc0b309 6162 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6163 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6164
e610eaca
PE
6165 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6166
b895abce
PE
6167 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6168 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6169 can always succeed if overflow has undefined behavior.
6170
1f1d9321 6171 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6172 (wordify): Omit three unnecessary tests.
1f1d9321 6173
c59478bc
PE
6174 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6175 All callers changed. This avoids the need for an unused var.
6176
79b73827
PE
6177 * casefiddle.c (casify_region): Remove var that is set but not used.
6178
a4db5dfe
PE
6179 * dired.c (file_name_completion): Remove var that is set but not used.
6180
43aae36e
PE
6181 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6182
2a47c44d 6183 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6184 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6185
a37c69bf
PE
6186 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6187 Check for integer overflow on size calculations.
6188
328ab8e7
PE
6189 * buffer.c (Fprevious_overlay_change): Remove var that is set
6190 but not used.
6191
e5a2a5cb
PE
6192 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6193 Remove vars that are set but not used.
8d84a6eb 6194 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6195 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6196
a60e5f68
PE
6197 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6198
f661cb61 6199 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6200 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6201
f0397f5a
PE
6202 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6203 that are set but not used.
6204
8664db06 6205 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6206 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6207
6abdaa4a
PE
6208 * xselect.c (x_get_local_selection, x_handle_property_notify):
6209 Remove vars that are set but not used.
6210
0ce7538d 6211 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6212 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6213
9ae848fc
PE
6214 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6215 Remove var that is set but not used.
0b918413
PE
6216 (scroll_bar_windows_size): Now size_t, not int.
6217 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6218 Check for overflow.
9ae848fc 6219
a5a62657
PE
6220 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6221 (map_tty_color) [!defined MSDOS]: Likewise.
6222
5c5cdd39
PE
6223 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6224
66ebf983
PE
6225 * coding.c: Remove vars that are set but not used.
6226 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6227 All callers changed.
6228 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6229 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6230 (decode_coding_charset): Remove vars that are set but not used.
6231
1be4d761
PE
6232 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6233 that is set but not used.
6234
47553fa8
PE
6235 * print.c (print_object): Remove var that is set but not used.
6236
1f7196bf 6237 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6238 The gnulib version avoids calling malloc in the usual case,
6239 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6240 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6241 * filelock.c (current_lock_owner): Likewise.
6242 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6243 * sysdep.c: Include allocator.h, careadlinkat.h.
6244 (emacs_no_realloc_allocator): New static constant.
6245 (emacs_readlink): New function.
fdb61804
PE
6246 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6247 ../lib/careadlinkat.h.
d1fdcab7 6248
f84c17c7
SM
62492011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6250
6251 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6252 first non-nil return value).
6253
ef3862ad
JD
62542011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6255
6256 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6257 if not defined (Bug#8403).
6258
376a7006
JB
62592011-04-02 Juanma Barranquero <lekktu@gmail.com>
6260
6261 * xdisp.c (display_count_lines): Remove parameter `start',
6262 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6263 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6264 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6265 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6266 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6267 and thereabouts. All callers changed.
6268 (get_per_char_metric): Remove parameter `f', unused since
6269 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6270
6ca3801d
JM
62712011-04-02 Jim Meyering <meyering@redhat.com>
6272
6273 do not dereference NULL upon failed strdup
6274 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6275 (ns_get_family): Likewise.
6276
d8e2b5ba
JB
62772011-04-02 Juanma Barranquero <lekktu@gmail.com>
6278
6279 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6280
8c74fcbd
JD
62812011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6282
6283 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6284 later (Bug#8403).
6285
7200d79c
SM
62862011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6287
03408648 6288 Add lexical binding.
7200d79c 6289
03408648
SM
6290 * window.c (Ftemp_output_buffer_show): New fun.
6291 (Fsave_window_excursion):
6292 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6293
6294 * lread.c (lisp_file_lexically_bound_p): New function.
6295 (Fload): Bind Qlexical_binding.
6296 (readevalloop): Remove `evalfun' arg.
6297 Bind Qinternal_interpreter_environment.
6298 (Feval_buffer): Bind Qlexical_binding.
6299 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6300 Mark as dynamic.
6301 (syms_of_lread): Declare `lexical-binding'.
6302
6303 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6304
6305 * keyboard.c (eval_dyn): New fun.
6306 (menu_item_eval_property): Use it.
ca105506
SM
6307
6308 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6309
03408648
SM
6310 * fns.c (concat, mapcar1): Accept byte-code-functions.
6311
6312 * eval.c (Fsetq): Handle lexical vars.
6313 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6314 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6315 (FletX, Flet): Obey lexical binding.
6316 (Fcommandp): Handle closures.
6317 (Feval): New `lexical' arg.
6318 (eval_sub): New function extracted from Feval. Use it almost
6319 everywhere where Feval was used. Look up vars in lexical env.
6320 Handle closures.
6321 (Ffunctionp): Move from subr.el.
6322 (Ffuncall): Handle closures.
6323 (apply_lambda): Remove `eval_flags'.
6324 (funcall_lambda): Handle closures and new byte-code-functions.
6325 (Fspecial_variable_p): New function.
6326 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6327 but without exporting it to Lisp.
23aba0ea 6328
23aba0ea 6329 * doc.c (Fdocumentation, store_function_docstring):
03408648 6330 * data.c (Finteractive_form): Handle closures.
23aba0ea 6331
03408648
SM
6332 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6333 interactive spec.
ba83908c 6334
04f2d78b
CB
6335 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6336 New byte-codes.
03408648
SM
6337 (exec_byte_code): New function extracted from Fbyte_code to handle new
6338 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6339
03408648 6340 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6341
03408648 6342 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6343
e2abce01
JB
63442011-03-31 Juanma Barranquero <lekktu@gmail.com>
6345
6346 * xdisp.c (redisplay_internal): Fix prototype.
6347
63696a73 63482011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6349
63696a73 6350 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6351 (try_scrolling): Use it when setting scroll_limit.
6352 Limit scrolling to 100 screen lines.
63696a73
EZ
6353 (redisplay_window): Even when falling back on "recentering",
6354 position point in the window according to scroll-conservatively,
6355 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6356
6357 (try_scrolling): When point is above the window, allow searching
6358 as far as scroll_max, or one screenful, to compute vertical
6359 distance from PT to the scroll margin position. This prevents
6360 try_scrolling from unnecessarily failing when
6361 scroll-conservatively is set to a value slightly larger than the
6362 window height. Clean up the case of PT below the margin at bottom
6363 of window: scroll_max can no longer be INT_MAX. When aggressive
6364 scrolling is in use, don't let point enter the opposite scroll
6365 margin as result of the scroll.
6366 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6367 threshold of 100 lines for never-recentering scrolling.
6368
e4cc2dfc
JB
63692011-03-31 Juanma Barranquero <lekktu@gmail.com>
6370
6371 * dispextern.h (move_it_by_lines):
6372 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6373 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6374 (message_log_check_duplicate): Remove parameters `prev_bol' and
6375 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6376 (redisplay_internal): Remove parameter `preserve_echo_area',
6377 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6378
6379 * indent.c (Fvertical_motion):
6380 * window.c (window_scroll_pixel_based, Frecenter):
6381 Don't pass `need_y_p' to `move_it_by_lines'.
6382
1c470562
SM
63832011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6384
44f230aa
SM
6385 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6386 steal a few bits to be more compact.
6387 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6388 Remove unneeded casts.
6389
1c470562
SM
6390 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6391
888adce9
ZK
63922011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6393
6394 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6395 binding" message (bug#7967).
6396
f838ed7b
PE
63972011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6398
77861b95
PE
6399 Fix more problems found by GCC 4.6.0's static checks.
6400
de6dbc14
PE
6401 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6402 Remove unused local var.
6403
f838ed7b
PE
6404 * editfns.c (Fmessage_box): Remove unused local var.
6405
792c7b2b
PE
6406 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6407 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6408 Omit unused local vars.
c499e557 6409 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6410 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6411 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6412 Omit unused local var.
6413
ba0165e1
PE
6414 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6415 Don't assume string length fits in int.
32ad8845 6416 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6417 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6418
3c59b4c9
PE
6419 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6420 instead of alloca (Bug#8344).
6421
a3eed478 6422 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6423 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6424
eb4d412d
PE
6425 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6426
1658b401
PE
6427 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6428 concerns.
6429
6430 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6431
6432 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6433
9a2c6e05
PE
6434 * keyboard.c (syms_of_keyboard): Use the same style as later
6435 in this function when indexing through an array. This also
6436 works around GCC bug 48267.
6437
03d0a109
PE
6438 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6439
44f730c8
PE
6440 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6441
fe75f926
PE
6442 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6443 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6444
ffa8c828
PE
6445 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6446 This avoids undefined behavior on integer overflow, and is a bit
6447 more convenient anyway since it is compared to a size_t variable.
6448
c5101a77
PE
6449 Variadic C functions now count arguments with size_t, not int.
6450 This avoids an unnecessary limitation on 64-bit machines, which
6451 caused (substring ...) to crash on large vectors (Bug#8344).
6452 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6453 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6454 All variadic functions and their callers changed accordingly.
c5101a77
PE
6455 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6456 * data.c (arith_driver, float_arith_driver): Likewise.
6457 * editfns.c (general_insert_function): Likewise.
6458 * eval.c (struct backtrace.nargs, interactive_p)
6459 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6460 (funcall_lambda, mark_backtrace): Likewise.
6461 * fns.c (concat): Likewise.
6462 * frame.c (x_set_frame_parameters): Likewise.
6463 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6464 0 if not found, not -1. All callers changed.
6465
dd3f25f7
PE
6466 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6467 (stack_copy_size): Now size_t, not int.
6468 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6469
461c2ab9
JB
64702011-03-28 Juanma Barranquero <lekktu@gmail.com>
6471
6472 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6473 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6474 All callers changed.
6475
6476 * lisp.h (multibyte_char_to_unibyte):
6477 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6478 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6479 * character.h (CHAR_TO_BYTE8):
6480 * cmds.c (internal_self_insert):
6481 * editfns.c (general_insert_function):
6482 * keymap.c (push_key_description):
6483 * search.c (Freplace_match):
6484 * xdisp.c (message_dolog, set_message_1): All callers changed.
6485
f6d62986
SM
64862011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6487
6488 * keyboard.c (safe_run_hook_funcall): New function.
6489 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6490 don't set the hook to nil, but remove the offending function instead.
6491 (Qcommand_hook_internal): Remove, unused.
6492 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6493 Vcommand_hook_internal.
6494
6495 * eval.c (enum run_hooks_condition): Remove.
6496 (funcall_nil, funcall_not): New functions.
6497 (run_hook_with_args): Call each function through a `funcall' argument.
6498 Remove `cond' argument, now redundant.
6499 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6500 (Frun_hook_with_args_until_failure): Adjust accordingly.
6501 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6502
1db5b1ad
JB
65032011-03-28 Juanma Barranquero <lekktu@gmail.com>
6504
6505 * dispextern.h (string_buffer_position): Remove declaration.
6506
6507 * print.c (strout): Remove parameter `multibyte', unused since
6508 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6509
6510 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6511 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6512 All callers changed.
6513
6514 * w32.c (_wsa_errlist): Use braces for struct initializers.
6515
6516 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6517 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6518 All callers changed.
6519 (string_buffer_position): Likewise. Also, make static (it's never
6520 used outside xdisp.c).
6521 (cursor_row_p): Remove parameter `w', unused since
6522 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6523 (decode_mode_spec): Remove parameter `precision', introduced during
6524 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6525 All callers changed.
6526
5ffb62aa
JD
65272011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6528
6529 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6530
461c2ab9 65312011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6532
6533 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6534 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6535 (ns_update_auto_hide_menu_bar): New functions.
6536 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6537 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6538 ns_constrain_all_frames.
6539 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6540 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6541
5c380ffb
JD
65422011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6543
6544 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6545
9af30bdf
GM
65462011-03-27 Glenn Morris <rgm@gnu.org>
6547
6548 * syssignal.h: Replace RETSIGTYPE with void.
6549 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6550 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6551 Replace SIGTYPE with void everywhere.
6552 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6553 * s/template.h (SIGTYPE): Remove commented out definition.
6554
e2abce01
JB
65552011-03-26 Eli Zaretskii <eliz@gnu.org>
6556
6557 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6558 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6559
f868cd8a
JB
65602011-03-26 Juanma Barranquero <lekktu@gmail.com>
6561
59eb0929
JB
6562 * w32.c (read_unc_volume): Use parameter `henum', instead of
6563 global variable `wget_enum_handle'.
6564
6565 * keymap.c (describe_vector): Remove parameters `indices' and
6566 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6567 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6568
f868cd8a
JB
6569 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6570
6571 * keyboard.c (timer_check): Remove parameter `do_it_now',
6572 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6573 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6574 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6575
6576 * keyboard.c (read_char):
6577 * w32menu.c (w32_menu_display_help):
6578 * xmenu.c (show_help_event, menu_help_callback):
6579 Adjust calls to `show_help_echo'.
6580
6581 * gtkutil.c (xg_maybe_add_timer):
6582 * keyboard.c (readable_events):
6583 * process.c (wait_reading_process_output):
6584 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6585
6586 * insdel.c (adjust_markers_gap_motion):
6587 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6588 (gap_left, gap_right): Don't call it.
6589
2ecf6fdb
CY
65902011-03-25 Chong Yidong <cyd@stupidchicken.com>
6591
6592 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6593 incurred during fontification.
6594
6b1f9ba4
JB
65952011-03-25 Juanma Barranquero <lekktu@gmail.com>
6596
6597 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6598 (DEFVAR_PER_BUFFER): Don't pass it.
6599
6600 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6601 (scrolling_window): Don't pass it.
6602
0f4a96b5
JB
66032011-03-25 Juanma Barranquero <lekktu@gmail.com>
6604
6605 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6606
6607 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6608 and `suffix'.
6609 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6610 of variables specific to SELinux and computation of `encoded_absname'.
6611
6612 * image.c (XPutPixel): Remove unused variable `height'.
6613
6614 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6615
6616 * unexw32.c (get_section_info): Remove unused variable `section'.
6617
6618 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6619 (system_process_attributes): Remove unused variable `sess'.
6620 (sys_read): Remove unused variable `err'.
6621
6622 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6623 (w32_wnd_proc): Remove unused variable `isdead'.
6624 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6625 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6626 (x_create_tip_frame): Remove unused variable `tem'.
6627
6628 * w32inevt.c (w32_console_read_socket):
6629 Remove unused variable `no_events'.
6630
6631 * w32term.c (x_draw_composite_glyph_string_foreground):
6632 Remove unused variable `width'.
6633
1149507c
JB
66342011-03-24 Juanma Barranquero <lekktu@gmail.com>
6635
6636 * w32term.c (x_set_glyph_string_clipping):
6637 Don't pass uninitialized region to CombineRgn.
6638
9c88f339
JB
66392011-03-23 Juanma Barranquero <lekktu@gmail.com>
6640
6641 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6642 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6643 (Fx_close_connection): Remove unused variable `i'.
6644
6645 * w32font.c (w32font_draw): Return number of glyphs.
6646 (w32font_open_internal): Remove unused variable `i'.
6647 (w32font_driver): Add missing initializer.
6648
6649 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6650 (fill_in_menu): Remove unused variable `items_added'.
6651
6652 * w32term.c (last_mouse_press_frame): Remove static global variable.
6653 (w32_clip_to_row): Remove unused variable `f'.
6654 (x_delete_terminal): Remove unused variable `i'.
6655
6656 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6657 (NOTHING): Remove unused static global variable.
6658 (uniscribe_check_otf): Remove unused variable `table'.
6659 (uniscribe_font_driver): Add missing initializers.
6660
dee091a3
JD
66612011-03-23 Julien Danjou <julien@danjou.info>
6662
6663 * term.c (Fsuspend_tty, Fresume_tty):
6664 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6665 * window.c (temp_output_buffer_show):
6666 * insdel.c (signal_before_change):
6667 * frame.c (Fhandle_switch_frame):
6668 * fileio.c (Fdo_auto_save):
6669 * emacs.c (Fkill_emacs):
6670 * editfns.c (save_excursion_restore):
6671 * cmds.c (internal_self_insert):
6672 * callint.c (Fcall_interactively):
6673 * buffer.c (Fkill_all_local_variables):
6674 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6675 Use Frun_hooks.
0f4a96b5 6676 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6677 unconditionnaly since it does the check itself.
6678
2c520ab5 66792011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6680
c9c49752
PE
6681 Fix more problems found by GCC 4.5.2's static checks.
6682
8abc3f12
PE
6683 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6684 the first time through the loop, since we know p0 < p1 then.
6685 This also avoids a gcc -Wstrict-overflow warning.
6686
a2d26660
PE
6687 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6688 leading to a memory leak, possible in functions like
6689 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6690 of objects (Bug#8318).
a2d26660 6691
916c72e9
PE
6692 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6693 that could (at least in theory) be that large.
6694
19ab8a18
PE
6695 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6696 This is less likely to overflow, and avoids undefined behavior if
6697 overflow does occur. All callers changed. Use strtoul to scan
6698 for the unsigned long integer.
b7cbbd6f
PE
6699 (pint2hrstr): Simplify and tune code slightly.
6700 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6701
f0641eff
PE
6702 * scroll.c (do_scrolling): Work around GCC bug 48228.
6703 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6704
7f650bb9
PE
6705 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6706 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6707 (validate_x_resource_name): Simplify count usage.
6708 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6709
37dd57d1
PE
6710 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6711 fail (Bug#8306).
81e56e61 6712
699979fc 6713 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6714
401bf9b4
PE
6715 * process.c (Fmake_network_process): Use socklen_t, not int,
6716 where POSIX says socklen_t is required in portable programs.
6717 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6718 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6719 (Fmake_network_process, server_accept_connection):
6720 (wait_reading_process_output, read_process_output):
6721 Likewise.
6722
b93aacde
PE
6723 * process.c: Rename or move locals to avoid shadowing.
6724 (list_processes_1, Fmake_network_process):
6725 (read_process_output_error_handler, exec_sentinel_error_handler):
6726 Rename or move locals.
4dc343ee 6727 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6728 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6729 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6730 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6731 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6732
af8a867c 6733 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6734 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6735 Include tparam.h instead, since it declares them.
af8a867c
PE
6736 * cm.h (PC): Remove extern decl; tparam.h now does this.
6737 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6738 * terminfo.c: Include tparam.h, to check interfaces.
6739 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6740 (tparam): Adjust signature to match interface in tparam.h;
6741 this removes some undefined behavior. Check that outstring and len
6742 are zero, which they always are with Emacs.
6743 * tparam.h (PC, BC, UP): New extern decls.
6744
0248044d 6745 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6746 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6747
8ff096c1 6748 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6749 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6750 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6751 (ftfont_list): Remove unused local.
49eaafba
PE
6752 (get_adstyle_property, ftfont_pattern_entity):
6753 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6754 Rename locals to avoid shadowing.
8ff096c1 6755
e2be39f6
PE
6756 * xfont.c (xfont_list_family): Mark var as initialized.
6757
c9735e30
PE
6758 * xml.c (make_dom): Now static.
6759
8f5201ae
PE
6760 * composite.c (composition_compute_stop_pos): Rename local to
6761 avoid shadowing.
b246f932
PE
6762 (composition_reseat_it): Remove unused locals.
6763 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6764 (composition_update_it): Mark var as initialized.
11b61122
PE
6765 (find_automatic_composition): Mark vars as initialized,
6766 with a FIXME (Bug#8290).
8f5201ae 6767
760fbc2c
PE
6768 character.h: Rename locals to avoid shadowing.
6769 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6770 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6771 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6772 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6773 to avoid shadowing.
6774
ff08eb85
PE
6775 * textprop.c (property_change_between_p): Remove; unused.
6776
fc7bf025
PE
6777 * intervals.c (interval_start_pos): Now static.
6778
235d7abc
PE
6779 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6780
44f230aa
SM
6781 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6782 Rename locals to avoid shadowing.
3e7d6594 6783
50060332
PE
6784 * sound.c (wav_play, au_play, Fplay_sound_internal):
6785 Fix pointer signedness.
d01f234b 6786 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6787 (wav_play): Initialize a variable to 0, to prevent undefined
6788 behavior (Bug#8278).
50060332 6789
c4fc4e30
PE
6790 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6791
918436ed
PE
6792 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6793
c939f91b
PE
6794 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6795 clobbering (Bug#8298).
b9c7f648
PE
6796 * sysdep.c (sys_subshell): Likewise.
6797 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6798
6bd8c144
PE
6799 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6800 This should get cleaned up, so that child_setup has the
6801 same signature on all platforms.
6802
7710357c 6803 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6804 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6805
c59da222
CY
68062011-03-22 Chong Yidong <cyd@stupidchicken.com>
6807
6808 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6809 not to be necessary, and produces flickering.
6810
66b87493
GM
68112011-03-20 Glenn Morris <rgm@gnu.org>
6812
6813 * config.in: Remove file.
6814
45b6f6d5
JB
68152011-03-20 Juanma Barranquero <lekktu@gmail.com>
6816
6817 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6818 are now in src/globals.h.
6819 (syms_of_minibuf): Remove spurious & from previous change.
6820
3ec03f7e
LL
68212011-03-20 Leo <sdl.web@gmail.com>
6822
6823 * minibuf.c (completing-read-function): New variable.
6824 (completing-read-default): Rename from completing-read.
6825 (completing-read): Call completing-read-function.
6826
b14e3e21
CY
68272011-03-19 Juanma Barranquero <lekktu@gmail.com>
6828
6829 * xfaces.c (Fx_load_color_file):
6830 Read color file from absolute filename (bug#8250).
6831
f2b726e6
JB
68322011-03-19 Juanma Barranquero <lekktu@gmail.com>
6833
6834 * makefile.w32-in: Update dependencies.
6835
09f6ff02
EZ
68362011-03-17 Eli Zaretskii <eliz@gnu.org>
6837
6838 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6839
29a6015a
PE
68402011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6841
a3a6c54e
PE
6842 Fix more problems found by GCC 4.5.2's static checks.
6843
b766f867
PE
6844 * process.c (make_serial_process_unwind, send_process_trap):
6845 (sigchld_handler): Now static.
6846
be02381c
PE
6847 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6848 That way, the code declares only the vars that it needs.
6849 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6850 * s/cygwin.h (PTY_ITERATION): Likewise.
6851 * s/darwin.h (PTY_ITERATION): Likewise.
6852 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6853
57048744
PE
6854 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6855 * process.c (allocate_pty): Don't declare stb unless it's needed.
6856
7914961c 6857 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6858 (CONSTANTLIM): Remove; unused.
6859 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6860 Define only if needed.
7914961c 6861
b3967b18
PE
6862 * unexelf.c (unexec): Name an expression,
6863 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6864 Use a different way to cause a compilation error if anyone uses
6865 n rather than nn, a way that does not involve shadowing.
73366a00 6866 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6867
29a6015a
PE
6868 * deps.mk (unexalpha.o): Remove; unused.
6869
43cfc33e 6870 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6871 * unexec.h: New file.
ce701a33
PE
6872 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6873 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6874 Depend on unexec.h.
6875 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6876 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6877 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6878 Change as necessary to match prototype in unexec.h.
ce701a33 6879
01f44d5a
PE
6880 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6881 shadowing.
4f63c6bb 6882 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6883
a6670b0b
PE
6884 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6885 Rename locals to avoid shadowing.
6886
cef2010d 6887 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6888 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6889
d4d7173a
PE
6890 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6891
f08b802a
PE
6892 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6893 warning when compiling print.c.
6894
3ddb0639
PE
6895 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6896 instead of using an uninitialized var.
5ad03b97 6897 (font_sort_entities): Mark var as initialized.
3ddb0639 6898
170a2692
PE
6899 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6900
e663c700
PE
6901 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6902 pointers to constants.
89bc529a 6903 (font_parse_fcname): Remove unused vars.
7b81e2d0 6904 (font_delete_unmatched): Now static.
ea838e10 6905 (font_get_spec): Remove; unused.
13a547c6
PE
6906 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6907 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6908 Rename or move locals to avoid shadowing.
e663c700 6909
2a80c887 6910 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6911 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6912
1384fa33 6913 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6914 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6915
8b2c52e9
PE
6916 * alloc.c (mark_backtrace): Move decl from here ...
6917 * lisp.h: ... to here, so that it can be checked.
6918
475545b5 6919 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6920 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6921 (lisp_indirect_variable): Name an expression,
6922 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6923 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6924
b1349114 6925 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6926 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6927 Use const pointer when appropriate.
b1349114 6928
a2928364
PE
6929 * lisp.h (get_system_name, get_operating_system_release):
6930 Move decls here, to check interfaces.
6931 * process.c (get_operating_system_release): Move decl to lisp.h.
6932 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6933 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6934 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6935 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6936 (Fformat_time_string, Fencode_time, Finsert_char):
6937 (Ftranslate_region_internal, Fformat):
6938 Rename or remove local vars to avoid shadowing.
9710023e 6939 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6940
a415e694
PE
6941 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6942 avoid shadowing.
6943
8ef4622d
PE
6944 * lisp.h (eassert): Check that the argument compiles, even if
6945 ENABLE_CHECKING is not defined.
6946
946f9a5b
PE
6947 * data.c (Findirect_variable): Name an expression, to avoid
6948 gcc -Wbad-function-cast warning.
112396d6 6949 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6950 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6951 (Fmake_variable_buffer_local, Fmake_local_variable):
6952 Mark variables as initialized.
52746918 6953 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6954
e5aab7e7 6955 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6956 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6957 Rename locals to avoid shadowing.
dff45157
PE
6958 (mark_stack): Move local variables into the #ifdef region where
6959 they're used.
7bc26fdb
PE
6960 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6961 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6962 needed otherwise.
6963 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6964 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6965 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6966
e5aab7e7
PE
6967 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6968 avoids undefined behavior in theory.
6969
4da60324
PE
6970 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6971
88043301
PE
6972 Use functions, not macros, for up- and down-casing (Bug#8254).
6973 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6974 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6975 to use the following functions instead of these macros.
6976 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6977 EMACS_INT, since callers assume the returned value fits in int.
6978 (upcase1): Likewise, for UPCASE_TABLE.
6979 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6980 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6981 the race-condition problem in the old DOWNCASE.
88043301 6982
19ed5445
PE
6983 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6984 Rename locals to avoid shadowing.
6985 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6986 (regex_compile, re_search_2, re_match_2_internal):
6987 Remove unused local vars.
952db0d7
PE
6988 (FREE_VAR): Rewrite so as not to use empty "else",
6989 which gcc can warn about.
da053e48 6990 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6991 (RETALLOC_IF): Define only if needed.
6992 (WORDCHAR_P): Likewise. This one is never needed, but is used
6993 only in a comment talking about a compiler bug, so put inside
6994 the #if 0 of that comment.
6995 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6996 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6997 Remove; unused.
19ed5445 6998
1f3561e4 6999 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7000 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7001 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7002
ded6f8f7
PE
7003 * search.c (simple_search): Remove unused var.
7004
dbd37a95
PE
7005 * dired.c (compile_pattern): Move decl from here ...
7006 * lisp.h: ... to here, so that it can be checked.
7007 (struct re_registers): New forward decl.
7008
7e47afad
PE
7009 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7010
85f24f61
PE
7011 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7012 All uses changed.
7013 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7014 Rename locals to avoid shadowing.
5671df8f 7015 (Fvertical_motion): Mark locals as initialized.
85f24f61 7016
181aa2be 7017 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7018 (casify_region): Mark local as initialized.
181aa2be 7019
930d429c
PE
7020 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7021
7082eac6
PE
7022 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7023 New macros, so that the caller can use some names other than
7024 gcpro1, gcpro2, etc.
7025 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7026 of the new macros.
7027 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7028 argument, for consistency with GCPRO2_VAR, etc: it is now the
7029 prefix of the variable, not the variable itself. All uses
7030 changed.
38b2c076
PE
7031 * dired.c (directory_files_internal, file_name_completion):
7032 Rename locals to avoid shadowing.
7033
15206ed9
PE
7034 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7035 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7036 dired.c's scmp function, had undefined behavior.
7037 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7038 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7039 * buffer.h: ... to here, because these macros use current_buffer,
7040 and the new implementation with inline functions needs to have
7041 current_buffer in scope now, rather than later when the macros
7042 are used.
7043 (downcase, upcase1): New static inline functions.
7044 (DOWNCASE, UPCASE1): Reimplement using these functions.
7045 This avoids undefined behavior in expressions like
7046 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7047 from race conditions in accessing the global variables
7048 case_temp1 and case_temp2.
7049 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7050 * lisp.h (case_temp1, case_temp2): Remove their decls.
7051 * character.h (ASCII_CHAR_P): Move from here ...
7052 * lisp.h: ... to here, so that the inline functions mentioned
7053 above can use them.
7054
4a6bea26
PE
7055 * dired.c (directory_files_internal_unwind): Now static.
7056
f14b7e14
PE
7057 * fileio.c (file_name_as_directory, directory_file_name):
7058 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7059 Now static.
2893f146
PE
7060 (file_name_as_directory): Use const pointers when appropriate.
7061 (Fexpand_file_name): Likewise. In particular, newdir might
7062 point at constant storage, so make it a const pointer.
fd4ead52 7063 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7064 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7065 signedness issues.
f839df0c
PE
7066 (Fset_file_times, Finsert_file_contents, auto_save_error):
7067 Rename locals to avoid shadowing.
f14b7e14 7068
5716756e 7069 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7070 (Ftry_completion, Fall_completions): Rename or remove locals
7071 to avoid shadowing.
5716756e 7072
b4c3046a
PE
7073 * marker.c (bytepos_to_charpos): Remove; unused.
7074
b45db522
PE
7075 * lisp.h (verify_bytepos, count_markers): New decls,
7076 so that gcc does not warn that these functions aren't declared.
7077
85876d07
PE
7078 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7079 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7080 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7081 (copy_text): Remove unused local var.
85876d07 7082
03d78a21 7083 * filelock.c (within_one_second): Now static.
b3dd38ab 7084 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7085
5df8f01b
PE
7086 * buffer.c (fix_overlays_before): Mark locals as initialized.
7087 (fix_start_end_in_overlays): Likewise. This function should be
7088 simplified by using pointers-to-pointers, but that's a different
7089 matter.
b1d876f1 7090 (switch_to_buffer_1): Now static.
8f54f30a
PE
7091 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7092 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7093
a70072c9 7094 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7095 Fix pointer signedness issue.
edced198
PE
7096 (sys_subshell): Mark local as volatile if checking for lint,
7097 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7098 (MAXPATHLEN): Define only if needed.
a70072c9 7099
a0977c44
PE
7100 * process.c (serial_open, serial_configure): Move decls from here ...
7101 * systty.h: ... to here, so that they can be checked.
7102
a884fdcc
PE
7103 * fns.c (get_random, seed_random): Move extern decls from here ...
7104 * lisp.h: ... to here, so that they can be checked.
7105
604efe86 7106 * sysdep.c (reset_io): Now static.
b8950c94 7107 (wait_for_termination_signal): Remove; unused.
604efe86 7108
38fc62d9
PE
7109 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7110 (copy_keymap_item, append_key, push_text_char_description):
7111 Now static.
1004a21a 7112 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7113 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7114 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7115 (describe_map_tree):
7116 Rename locals to avoid shadowing.
38fc62d9 7117
2f2650da
PE
7118 * keyboard.c: Declare functions static if they are not used elsewhere.
7119 (echo_char, echo_dash, cmd_error, top_level_2):
7120 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7121 (read_char, kbd_buffer_get_event, make_lispy_position):
7122 (make_lispy_event, make_lispy_movement, apply_modifiers):
7123 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7124 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7125 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7126 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7127 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7128
a053e86c 7129 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7130 (mark_kboards): Move decl here ...
7131 * alloc.c (mark_kboards): ... from here.
a053e86c 7132
4752793e
PE
7133 * lisp.h (force_auto_save_soon): New decl.
7134
74f10ca7 7135 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7136 (DEFINE_DUMMY_FUNCTION): New macro.
7137 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7138 Use it.
c03cd23f
PE
7139 (main): Add casts to avoid warnings
7140 if GCC considers string literals to be constants.
74f10ca7 7141
022e70d4
PE
7142 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7143
59d6fe83
PE
7144 * dbusbind.c: Pointer signedness fixes.
7145 (xd_signature, xd_append_arg, xd_initialize):
7146 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7147 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7148 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7149 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7150
78320123
PE
7151 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7152 if GCC considers string literals to be constants.
49cebcca 7153 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7154
35ac2a97
SM
71552011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7156
fb103ca9
SM
7157 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7158 (print_preprocess, print_object): New macro to fix last change.
7159
35ac2a97
SM
7160 * print.c (print_preprocess): Don't forget font objects.
7161
62973b41
JB
71622011-03-16 Juanma Barranquero <lekktu@gmail.com>
7163
7164 * emacs.c (USAGE3): Doc fixes.
7165
0e48bb22
AS
71662011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7167
7168 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7169 structure.
7170
7684e57b
JB
71712011-03-14 Juanma Barranquero <lekktu@gmail.com>
7172
7173 * lisp.h (VWindow_system, Qfile_name_history):
7174 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7175 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7176 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7177
7178 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7179 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7180
7181 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7182 * w32console.c (detect_input_pending, read_input_pending)
7183 (encode_terminal_code):
7184 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7185 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7186 (w32_system_caret_y, Qfile_name_history):
7187 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7188 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7189 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7190 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7191 * w32proc.c (Qlocal, report_file_error):
7192 * w32term.c (Vwindow_system, updating_frame):
7193 * w32uniscribe.c (initialized, uniscribe_font_driver):
7194 Remove unneeded extern declarations.
7195
2aa46d6c
CY
71962011-03-14 Chong Yidong <cyd@stupidchicken.com>
7197
c96bbc66 7198 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7199
cffc6f3b
CY
72002011-03-13 Chong Yidong <cyd@stupidchicken.com>
7201
7202 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7203 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7204 These macros can no longer be used for assignment.
7205
44f230aa
SM
7206 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7207 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7208 (record_buffer_markers, fetch_buffer_markers): New functions for
7209 recording and fetching special buffer markers.
7210 (set_buffer_internal_1, set_buffer_temp): Use them.
7211
7212 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7213
7214 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7215
7216 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7217 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7218
7219 * xdisp.c (hscroll_window_tree):
7220 (reconsider_clip_changes): Use PT instead of BUF_PT.
7221
d251f04b
EZ
72222011-03-13 Eli Zaretskii <eliz@gnu.org>
7223
7224 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7225 $(EMACS_ROOT)/lib/intprops.h.
7226
f0c77cd1
PE
72272011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7228
3eca4629
PE
7229 Fix more problems found by GCC 4.5.2's static checks.
7230
7c86ee98
PE
7231 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7232 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7233 (xg_free_frame_widgets): Make it clear that a local variable is
7234 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7235 (gdk_window_get_screen): Make it clear that this macro is needed
7236 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7237 (int_gtk_range_get_value): New function, which avoids a diagnostic
7238 from gcc -Wbad-function-cast.
7239 (xg_set_toolkit_scroll_bar_thumb): Use it.
7240 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7241 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7242 (get_utf8_string, xg_get_file_with_chooser):
7243 Rename locals to avoid shadowing.
7244 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7245
41729b81
PE
7246 * xgselect.c (xg_select): Remove unused var.
7247
f0c77cd1
PE
7248 * image.c (four_corners_best): Mark locals as initialized.
7249 (gif_load): Initialize transparent_p to zero (Bug#8238).
7250 Mark another local as initialized.
ec6cf4c6 7251 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7252
ce0ad53d 7253 * image.c (clear_image_cache): Now static.
d5d5a617 7254 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7255 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7256 (x_edge_detection): Remove unnecessary cast that
7257 gcc -Wbad-function-cast diagnoses.
2037898d 7258 (gif_load): Fix pointer signedness.
6ae141d6
PE
7259 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7260 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7261
33383987 72622011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7263
d32df629
PE
7264 Improve quality of tests for time stamp overflow.
7265 For example, without this patch (encode-time 0 0 0 1 1
7266 1152921504606846976) returns the obviously-bogus value (-948597
7267 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7268 reports time overflow. See
7269 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7270 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7271 * editfns.c: Include limits.h and intprops.h.
7272 (TIME_T_MIN, TIME_T_MAX): New macros.
7273 (time_overflow): Move earlier, to before first use.
7274 (hi_time, lo_time): New functions, for an accurate test for
7275 out-of-range times.
7276 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7277 (Fget_internal_run_time): Don't assume time_t fits in int.
7278 (make_time): Use list2 instead of Fcons twice.
7279 (Fdecode_time): More accurate test for out-of-range times.
7280 (check_tm_member): New function.
7281 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7282 (lisp_time_argument): Don't rely on undefined left-shift and
7283 right-shift behavior when checking for time stamp overflow.
8be6f318 7284
fe31d94c
PE
7285 * editfns.c (time_overflow): New function, refactoring common code.
7286 (Fformat_time_string, Fdecode_time, Fencode_time):
7287 (Fcurrent_time_string): Use it.
7288
8be6f318
PE
7289 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7290 * dired.c (make_time): Move to ...
7291 * editfns.c (make_time): ... here.
7292 * systime.h: Note the move.
7293
09d9db2c 72942011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7295
126bc0dc
YM
7296 * fringe.c (update_window_fringes): Remove unused variables.
7297
c47cbdfd
YM
7298 * unexmacosx.c (copy_data_segment): Also copy __got section.
7299 (Bug#8223)
7300
7ac80be9
EZ
73012011-03-12 Eli Zaretskii <eliz@gnu.org>
7302
c96bbc66 7303 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7304 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7305 Constify `char *' arguments and their references according to
7306 prototypes in tparam.h.
7307
ecb0f94d 7308 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7309
7ac80be9
EZ
7310 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7311 Adapt all references accordingly.
7312
7313 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7314
ef1fd07e
TT
73152011-03-11 Tom Tromey <tromey@redhat.com>
7316
7317 * buffer.c (syms_of_buffer): Remove obsolete comment.
7318
7ef4b50c
EZ
73192011-03-11 Eli Zaretskii <eliz@gnu.org>
7320
7321 * termhooks.h (encode_terminal_code): Declare prototype.
7322
7323 * msdos.c (encode_terminal_code): Don't declare prototype.
7324
7325 * term.c (encode_terminal_code): Now external again, used by
7326 w32console.c and msdos.c.
7327
44f230aa
SM
7328 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7329 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7330
4b1ec863 73312011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7332
1714f52b 7333 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7334
4b1ec863
PE
7335 * fringe.c (update_window_fringes): Mark locals as initialized
7336 (Bug#8227).
7337 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7338
524c7aa6
PE
7339 * alloc.c (mark_fringe_data): Move decl from here ...
7340 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7341 to check its interface.
7342 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7343
a5c0af81 7344 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7345 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7346 (fontset_font): Mark local as initialized.
a9a06e0b 7347 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7348
b4716021
PE
7349 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7350
811e9bac 7351 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7352 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7353 (x_own_selection, Fx_disown_selection_internal): Rename locals
7354 to avoid shadowing.
7355 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7356
7e3ab302
PE
7357 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7358 so that the caller can use some name other than gcpro1.
7359 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7360 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7361 (Fx_backspace_delete_keys_p):
7362 Use them to avoid shadowing, and rename vars to avoid shadowing.
7363 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7364 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7365 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7366 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7367 Remove unused locals.
7e3ab302
PE
7368 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7369 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7370 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7371 macros.
f78faa98 7372
e2b13473
PE
7373 * xterm.h (x_mouse_leave): New decl.
7374
77f23912
PE
7375 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7376 Remove unused functions.
cdf4ba58
PE
7377 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7378 (x_calc_absolute_position): Now static.
7411c686 7379 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7380 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7381 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7382 unless they are used.
38d0b34a
PE
7383 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7384 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7385 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7386 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7387 (x_error_catcher, x_connection_closed, x_error_handler):
7388 (x_error_quitter, xembed_send_message, x_iconify_frame):
7389 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7390 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7391 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7392
44f230aa
SM
7393 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7394 Rename or move locals to avoid shadowing.
6b463e58 7395 (tty_defined_color, merge_face_heights): Now static.
5967d051 7396 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7397 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7398 does not deduce is never used uninitialized.
73719eba
PE
7399 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7400 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7401
426994c3 7402 * terminal.c (store_terminal_param): Now static.
5489860b 7403
032f1620 7404 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7405 (set_frame_menubar): Remove unused local.
d4323972 7406 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7407 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7408 since they might point to immutable storage.
281585b0
PE
7409 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7410 since it's unused otherwise.
032f1620 7411
367c19e5 7412 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7413 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7414 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7415 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7416 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7417 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7418 does not deduce are never used uninitialized.
70739cbe 7419
07b48fa9
PE
7420 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7421
8868a238 7422 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7423 * window.c (window_loop, size_window):
7424 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7425
7e5cf297 7426 * window.c (display_buffer): Now static.
d6550a9f
PE
7427 (size_window): Mark variables that gcc -Wuninitialized
7428 does not deduce are never used uninitialized.
a586633d
PE
7429 * window.h (check_all_windows): New decl, to forestall
7430 gcc -Wmissing-prototypes diagnostic.
5b555da1 7431 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7432
f6095868
PE
7433 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7434 shadowing.
7435 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7436 Include <limits.h>.
7437 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7438 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7439 (load_charset_map): Mark variables that gcc -Wuninitialized
7440 does not deduce are never used uninitialized.
53df7c11 7441 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7442
f38b440c
PE
7443 * coding.c (coding_set_source, coding_set_destination):
7444 Use "else { /* comment */ }" rather than "else /* comment */;"
7445 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7446 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7447 a block, when the outer 'i' will do.
7448 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7449 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7450 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7451 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7452 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7453 Rename locals to avoid shadowing.
7454 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7455 * coding.c (emacs_mule_char, encode_invocation_designation):
7456 Now static, since they're not used elsewhere.
413bb2db 7457 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7458 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7459 (decode_coding_emacs_mule): Mark variables that gcc
7460 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7461 (detect_coding_iso_2022): Initialize a local variable that might
7462 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7463 this initialization is needed. (Bug#8211)
5f58e762
PE
7464 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7465 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7466 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7467 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7468 Remove unused macros.
f38b440c 7469
232b38b9 7470 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7471 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7472 * character.c (string_count_byte8): Likewise.
232b38b9 7473
fb90da1b
PE
7474 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7475 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7476
fb93dbc2
PE
7477 * chartab.c (copy_sub_char_table): Now static, since it's not used
7478 elsewhere.
5c156ace
PE
7479 (sub_char_table_ref_and_range, char_table_ref_and_range):
7480 Rename locals to avoid shadowing.
bbcd0949 7481 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7482
7d3b3862 7483 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7484 (BIDI_BOB): Remove unused macro.
7d3b3862 7485
6be7d3da
PE
7486 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7487 deduce are never used uninitialized.
c2ed9c8b 7488 * term.c (encode_terminal_code): Likewise.
6be7d3da 7489
75f8807f 7490 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7491
50938595
PE
7492 * tparam.h: New file.
7493 * term.c, tparam.h: Include it.
7494 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7495 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7496 Move these decls to tparam.h, and make them agree with what
7497 is actually in tparam.c. The previous trick of using incompatible
7498 decls in different modules does not conform to the C standard.
7499 All callers of tparam changed to use tparam's actual API.
7500 * tparam.c (tparam1, tparam, tgoto):
7501 Use const pointers where appropriate.
7502
fbceeba2
PE
7503 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7504 * cm.h (struct cm): Likewise.
7505 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7506 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7507 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7508 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7509 (turn_on_face, init_tty): Likewise.
7510 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7511
7f3f1250
PE
7512 * term.c (term_mouse_position): Rename local to avoid shadowing.
7513
e6ca6543
PE
7514 * alloc.c (mark_ttys): Move decl from here ...
7515 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7516
c40f8d15
AS
75172011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7518
7519 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7520
cfe0661d
JB
75212011-03-09 Juanma Barranquero <lekktu@gmail.com>
7522
7523 * search.c (compile_pattern_1): Remove argument regp, unused since
7524 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7525 (compile_pattern): Don't pass it.
7526
0afb4571
J
75272011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7528
7529 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7530 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7531 for ! HAVE_GTK3.
7532 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7533
7534 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7535
7536 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7537 gdk_window_get_screen, gdk_window_get_geometry,
7538 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7539 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7540 (xg_get_pixbuf_from_pixmap): New function.
7541 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7542 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7543 Call xg_get_pixbuf_from_pixmap instead of
7544 gdk_pixbuf_get_from_drawable.
7545 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7546 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7547 (xg_check_special_colors): Use GtkStyleContext and its functions
7548 for HAVE_GTK3.
7549 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7550 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7551 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7552 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7553 Call gtk_widget_get_preferred_size.
0afb4571
J
7554 (xg_frame_resized): gdk_window_get_geometry only takes 5
7555 parameters.
44f230aa
SM
7556 (xg_win_to_widget, xg_event_is_for_menubar):
7557 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7558 (xg_set_widget_bg): New function.
7559 (delete_cb): New function.
895009e1 7560 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7561 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7562 (xg_set_background_color): Call xg_set_widget_bg.
7563 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7564 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7565 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7566 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7567 if ! HAVE_GTK3.
7568 (update_frame_tool_bar): Call gtk_widget_hide.
7569 (xg_initialize): Use GDK_KEY_g.
7570
7571 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7572 if ! HAVE_GTK3
7573 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7574
7575 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7576 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7577 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7578
1c2cc4ef
JB
75792011-03-08 Juanma Barranquero <lekktu@gmail.com>
7580
7581 * w32xfns.c (select_palette): Check success of RealizePalette against
7582 GDI_ERROR, not zero.
7583
33383987 7584See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7585
7586;; Local Variables:
7587;; coding: utf-8
aac0c6e3
MR
7588;; End:
7589
33383987 7590 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7591
7592 This file is part of GNU Emacs.
7593
7594 GNU Emacs is free software: you can redistribute it and/or modify
7595 it under the terms of the GNU General Public License as published by
7596 the Free Software Foundation, either version 3 of the License, or
7597 (at your option) any later version.
7598
7599 GNU Emacs is distributed in the hope that it will be useful,
7600 but WITHOUT ANY WARRANTY; without even the implied warranty of
7601 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7602 GNU General Public License for more details.
7603
7604 You should have received a copy of the GNU General Public License
7605 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.