Better workaround for GNOME bug when --enable-gcc-warnings.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
5f0cb45a
PE
12012-09-13 Paul Eggert <eggert@cs.ucla.edu>
2
8ea47e3a
PE
3 Better workaround for GNOME bug when --enable-gcc-warnings.
4 * emacsgtkfixed.c (G_STATIC_ASSERT): Remove, undoing last change.
5 Instead, disable -Wunused-local-typedefs. See Dmitry Antipov in
6 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00335.html>.
7
4a4bbad2
PE
8 Simplify SIGIO usage (Bug#12408).
9 The code that dealt with SIGIO was crufty and confusing, e.g., it
10 played tricks like "#undef SIGIO" but these tricks were not used
11 consistently. Simplify mostly by not #undeffing standard symbols,
12 e.g., use "defined USABLE_SIGIO" (our symbol, which we can define
13 or not as we please) rather than "defined SIGIO" (standard symbol
14 that we probably shouldn't #undef).
15 * conf_post.h [USG5_4]: Do not include <sys/wait.h> here.
16 Modules that need it can include it.
17 [USG5_4 && emacs]: Likewise, do not include the streams stuff here.
18 * dispextern.h (ignore_sigio): New decl.
19 * emacs.c (shut_down_emacs): Invoke unrequest_sigio
20 unconditionally, since it's now a no-op if !USABLE_SIGIO.
21 * emacs.c (shut_down_emacs):
22 * keyboard.c (kbd_buffer_store_event_hold):
23 Use ignore_sigio rather than invoking 'signal' directly.
24 * keyboard.c (USABLE_FIONREAD && USG5_4): Include <sys/filio.h>,
25 for FIONREAD.
26 (FIONREAD, SIGIO): Do not #undef.
27 (tty_read_avail_input): Use #error rather than a syntax error.
28 * process.c [USG5_4]: Include <sys/stream.h> and <sys/stropts.h>,
29 for I_PIPE, used by SETUP_SLAVE_PTY.
30 (DATAGRAM_SOCKETS): Simplify defn, based on USABLE_FIONREAD.
31 * sysdep.c (croak): Remove; no longer needed. This bit of
32 temporary code, with Fred N. Fish's comment that it's temporary,
33 has been in Emacs since at least 1992!
34 (init_sigio, reset_sigio, request_sigio, unrequest_sigio):
35 Arrange for them to be no-ops in all cases when ! USABLE_SIGIO.
36 * syssignal.h (croak): Remove decl.
37 (SIGIO, SIGPOO, SIGAIO, SIGPTY): Do not #undef; that's too fragile.
38 * systty.h [!NO_TERMIO]: Do not include <termio.h>; no longer needed
39 now that we're termios-only.
40 (FIONREAD, ASYNC) [BROKEN_FIONREAD]: Do not #undef.
41 * term.c (dissociate_if_controlling_tty): Use #error rather than
42 a run-time error.
43
5f0cb45a
PE
44 Work around GCC and GNOME bugs when --enable-gcc-warnings.
45 * emacsgtkfixed.c (G_STATIC_ASSERT): Redefine to use 'verify',
46 to work around GNOME bug 683906.
47 * image.c (jpeg_load_body) [HAVE_JPEG && lint]: Pacify gcc -Wclobber.
48 (struct my_jpeg_error_mgr) [HAVE_JPEG && lint]: New member fp.
49 This works around GCC bug 54561.
50
40bce90b
PE
512012-09-12 Paul Eggert <eggert@cs.ucla.edu>
52
53 More fixes for 'volatile' and setjmp/longjmp.
54 * eval.c (Fdefvar, Fcondition_case): Remove unnecessary 'volatile's.
55 * image.c (struct png_load_context) [HAVE_PNG]: New type.
56 (png_load_body) [HAVE_PNG]:
57 (jpeg_load_body) [HAVE_JPEG]:
58 New function, with most of the old parent function's body.
59 (png_load) [HAVE_PNG]:
60 (jpeg_load) [HAVE_JPEG]:
61 Invoke the new function, to avoid longjmp munging our locals.
62 (struct my_jpeg_error_mgr) [HAVE_JPEG]: New members cinfo, failure_code.
63 (my_error_exit) [HAVE_JPEG]: Don't trust 'setjmp' to return 2 when
64 longjmp is passed 2, as the C standard doesn't guarantee this.
65 Instead, store the failure code into mgr->failure_code.
66
bfeae2cf
SM
672012-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
68
69 * keyboard.c (read_char, requeued_events_pending_p, Finput_pending_p)
70 (Fdiscard_input, quit_throw_to_read_char, init_keyboard)
71 (syms_of_keyboard): Remove support for unread-command-char.
72
8099e36b
EZ
732012-09-12 Eli Zaretskii <eliz@gnu.org>
74
75 * w32proc.c (sys_kill): If PID is our process ID and the signal is
76 SIGABRT, call emacs_abort. Avoids silently exiting upon assertion
77 violation. (Bug#12426)
78
92547ff9
PE
792012-09-12 Paul Eggert <eggert@cs.ucla.edu>
80
81 * image.c (jpeg_memory_src): Don't assume string len fits in unsigned.
82
45b82ad0
SM
832012-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
84
85 * eval.c: Add `inhibit-debugger'.
86 (Qinhibit_debugger): New symbol.
87 (call_debugger): Bind it instead of Qdebug_on_error.
88 (maybe_call_debugger): Test Vinhibit_debugger.
89 (syms_of_eval): Define inhibit-debugger.
90 * xdisp.c (set_message): Don't bind Qinhibit_debug_on_message.
91 (syms_of_xdisp): Remove inhibit-debug-on-message.
92
5779a1dc
PE
932012-09-11 Paul Eggert <eggert@cs.ucla.edu>
94
50f2e553
PE
95 Avoid _setjmp/_longjmp problems with local nonvolatile variables.
96 If a nonvolatile local variable is written before a _longjmp to
97 the frame containing the variable, and is read after the _longjmp,
98 the value read is indeterminate. Some local variables of type
99 'struct handler' and 'struct catchtag' are used in this way, so
100 mark each of their slots as volatile if the slot can be set before
101 _longjmp and read afterwards.
102 * lisp.h (struct handler): var and chosen_clause are now volatile.
103 (struct catchtag): val, next, and pdlcount are now volatile.
104
ae1d87e2
PE
105 * bidi.c (bidi_push_it, bidi_pop_it):
106 * fns.c (copy_hash_table):
107 * image.c (define_image_type):
108 * keyboard.c (kbd_buffer_store_event_hold):
109 * process.c (Fprocess_send_eof):
110 * xfaces.c (x_create_gc) [HAVE_NS]:
111 * xgselect.c (xg_select):
112 Prefer assignment to memcpy when either will do.
113
5779a1dc
PE
114 * alloc.c (discard_killed_buffers): Tune and simplify a bit.
115 Use pointer-to-a-pointer to simplify and avoid a NILP check each
116 time an item is removed. No need to mark this function 'inline';
117 the compiler knows better than we do.
118
c4c9756b
JD
1192012-09-11 Jan Djärv <jan.h.d@swipnet.se>
120
121 * nsterm.m (ns_judge_scroll_bars): Pass NO to updateFrameSize.
122 (updateFrameSize:): Add delay parameter to updateFrameSize, send it
123 to change_frame_size (Bug#12388).
124 (windowDidResize:): Pass YES to updateFrameSize.
125
126 * nsterm.h: Add delay parameter to updateFrameSize.
127
d73e321c
DA
1282012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
129
130 Discard killed buffers from deleted window and frame objects.
131 This reduces an amount of references to killed buffers and
132 helps GC to reclaim them faster.
133 * alloc.c (discard_killed_buffers): New function.
134 (mark_object): Use it for deleted windows and frames.
135 (mark_object): If symbol's value is set up for a killed buffer
136 or deleted frame, restore it's global binding.
137 * data.c (swap_in_global_binding): Add GC notice.
138 (swap_in_symval_forwarding): Use convenient set_blv_where.
139 * window.c (wset_next_buffers, wset_prev_buffers): Move ...
140 * window.h: ... to here.
141
e578f381
DA
1422012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
143
144 Convenient macro to check whether the buffer is live.
145 * buffer.h (BUFFER_LIVE_P): New macro.
146 * alloc.c, buffer.c, editfns.c, insdel.c, lread.c, marker.c:
147 * minibuf.c, print.c, process.c, window.c, xdisp.c: Use it.
148
3057e615
YM
1492012-09-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
150
151 * xdisp.c (right_overwritten, right_overwriting): Also handle gstring
152 composition cases (Bug#12364).
153
154 * xterm.c (x_draw_glyph_string): Avoid overwriting inverted left
155 overhang of succeeding glyphs overlapping box cursor.
156
157 * w32term.c (x_draw_glyph_string): Likewise.
158
6fda35f2
PE
1592012-09-11 Paul Eggert <eggert@cs.ucla.edu>
160
c990426a
PE
161 Simplify, document, and port floating-point (Bug#12381).
162 The porting part of this patch fixes bugs on non-IEEE platforms
163 with frexp, ldexp, logb.
164 * data.c, lisp.h (Qdomain_error, Qsingularity_error, Qunderflow_error):
165 Now static.
166 * floatfns.c: Simplify discussion of functions that Emacs doesn't
167 support, by removing commented-out code and briefly listing the
168 C89 functions excluded. The commented-out stuff was confusing
169 maintenance, e.g., we thought we needed cbrt but it was commented out.
170 (logb): Remove decl; no longer needed.
171 (isfinite): New macro, if not already supplied.
172 (isnan): Don't replace any existing macro.
173 (Ffrexp, Fldexp): Define even if !HAVE_COPYSIGN, as frexp and ldexp
174 are present on all C89 platforms.
175 (Ffrexp): Do not special-case zero, as frexp does the right thing
176 for that case.
177 (Flogb): Do not use logb, as it doesn't have the desired meaning
178 on hosts that use non-base-2 floating point. Instead, stick with
179 frexp, which is C89 anyway. Do not pass an infinity or a NaN to
180 frexp, to avoid getting an unspecified result.
181
6fda35f2
PE
182 * xdisp.c (Qinhibit_debug_on_message): Now static.
183
16130a58
JD
1842012-09-10 Jan Djärv <jan.h.d@swipnet.se>
185
186 * nsterm.m (ns_update_begin): Set clip path to whole view by using
187 NSBezierPath (Bug#12131).
188
d105a573
CY
1892012-09-10 Chong Yidong <cyd@gnu.org>
190
191 * fns.c (Fdelq, Fdelete): Doc fix.
192
ff55dfe8
PE
1932012-09-10 Paul Eggert <eggert@cs.ucla.edu>
194
195 * lisp.h (XSETINT, XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL)
196 (XSETFLOAT, XSETMISC): Parenthesize macro bodies.
197
e7032e7c
SM
1982012-09-09 Stefan Monnier <monnier@iro.umontreal.ca>
199
200 * lisp.h (make_lisp_ptr): New macro to replace XSET.
201 (XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL, XSETFLOAT, XSETMISC):
202 Use it.
203
e9957956
EZ
2042012-09-09 Eli Zaretskii <eliz@gnu.org>
205
aba05ce9
EZ
206 * fringe.c (draw_fringe_bitmap_1): Don't reduce the width of the
207 left fringe if the window has a left margin. This avoids leaving
208 traces of the cursor because its leftmost pixel is not drawn over.
209
e9957956
EZ
210 * dispnew.c (update_window_line): When the left margin area of a
211 screen line is updated, set the redraw_fringe_bitmaps_p flag of
212 that screen line. (Bug#12277)
213
f6196b87
PE
2142012-09-09 Paul Eggert <eggert@cs.ucla.edu>
215
216 Assume C89 or later for math functions (Bug#12381).
217 This simplifies the code, and makes it a bit smaller and faster,
218 and (most important) makes it easier to clean up signal handling
219 since we can stop worring about floating-point exceptions in
220 library code. That was a problem before C89, but the problem
221 went away many years ago on all practical Emacs targets.
222 * data.c, image.c, lread.c, print.c:
223 Don't include <math.h>; no longer needed.
224 * data.c, floatfns.c (IEEE_FLOATING_POINT): Don't worry that it
225 might be autoconfigured, as that never happens.
226 * data.c (fmod):
227 * doprnt.c (DBL_MAX_10_EXP):
228 * print.c (DBL_DIG):
229 Remove. C89 or later always defines these.
230 * floatfns.c (HAVE_MATHERR, FLOAT_CHECK_ERRNO, FLOAT_CHECK_DOMAIN)
231 (in_float, float_error_arg, float_error_arg2, float_error_fn_name)
232 (arith_error, domain_error, domain_error2):
233 Remove all this pre-C89 cruft. Do not include <errno.h> as that's
234 no longer needed -- we simply return what C returns. All uses removed.
235 (IN_FLOAT, IN_FLOAT2): Remove. All uses replaced with
236 the wrapped code.
237 (FLOAT_TO_INT, FLOAT_TO_INT2, range_error, range_error2):
238 Remove. All uses expanded, as these macros are no longer used
239 more than once and are now more trouble than they're worth.
240 (Ftan): Use tan, not sin / cos.
241 (Flogb): Assume C89 frexp.
242 (fmod_float): Assume C89 fmod.
243 (matherr) [HAVE_MATHERR]: Remove; no longer needed.
244 (init_floatfns): Remove. All uses removed.
245
9d7f1863
JD
2462012-09-08 Jan Djärv <jan.h.d@swipnet.se>
247
248 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Take back
249 compositeToPoint for OSX < 10.6 (Bug#12390).
250
eabf0404
PE
2512012-09-08 Paul Eggert <eggert@cs.ucla.edu>
252
253 * floatfns.c (Ftan): Use tan (x), not (sin (x) / cos (x)).
254 This produces more-accurate results.
255
0b3b1d23
JD
2562012-09-08 Jan Djärv <jan.h.d@swipnet.se>
257
258 * nsterm.m (updateFrameSize): Call setFrame: on the view when size
259 changes (Bug#12088).
260
6dcef6ec
CY
2612012-09-08 Chong Yidong <cyd@gnu.org>
262
263 * syntax.c (Fstring_to_syntax): Doc fix.
264
aa7d57c5
JD
2652012-09-08 Jan Djärv <jan.h.d@swipnet.se>
266
267 * nsterm.m (ns_clip_to_row): Remove code that deals with drawing fringe
268 in the internal border.
269 (x_set_window_size): Remove static variables and their usage.
270 (ns_redraw_scroll_bars): Fix NSTRACE arg.
271 (ns_after_update_window_line, ns_draw_fringe_bitmap): Remove
272 fringe/internal border adjustment (Bug#11052).
273 (ns_draw_fringe_bitmap): Make code more like other terms (xterm.c).
274 (ns_draw_window_cursor): Remove fringe/internal border adjustment.
275 (ns_fix_rect_ibw): Remove.
276 (ns_get_glyph_string_clip_rect): Remove call to ns_fix_rect_ibw.
277 (ns_dumpglyphs_box_or_relief): Ditto.
278 (ns_maybe_dumpglyphs_background): Remove fringe/internal border
279 adjustment.
280 (ns_dumpglyphs_image): Ditto.
281 (ns_dumpglyphs_stretch): Fix coding style. Remove fringe/internal
282 border adjustment.
283 (ns_set_vertical_scroll_bar): Remove variables barOnVeryLeft/Right and
284 their usage. Add fringe_extended_p and its use as in other terms.
285 (ns_judge_scroll_bars): Code style fix. Call updateFrameSize if
286 scroll bar was removed.
287 (updateFrameSize): New function.
288 (windowDidResize): Move code to updateFrameSize and call it.
289
290 * nsterm.h (EmacsView): Add updateFrameSize.
291
1a5432bc
CY
2922012-09-07 Chong Yidong <cyd@gnu.org>
293
b4f5313e
CY
294 * textprop.c (Fget_text_property): Minor doc fix (Bug#12323).
295
1a5432bc
CY
296 * data.c (Flocal_variable_if_set_p): Doc fix (Bug#10713).
297
1a4f1e9b
PE
2982012-09-07 Paul Eggert <eggert@cs.ucla.edu>
299
300 More signal-handler cleanup (Bug#12327).
eddb36a7
PE
301 * emacs.c (main): Convert three 'signal' calls to 'sigaction' calls.
302 Problem introduced when merging patches. Noted by Eli Zaretskii in
303 <http://bugs.gnu.org/12327#67>.
1a4f1e9b
PE
304 * floatfns.c: Comment fix.
305 * lisp.h (force_auto_save_soon): Declare regardless of SIGDANGER.
306 SIGDANGER might not be in scope so "#ifdef SIGDANGER" is not right,
307 and anyway the declaration is harmless even if SIGDANGER is not defined.
308 * syssignal.h (SIGIO): Also #undef if (! defined FIONREAD ||
309 defined BROKEN_FIONREAD). systty.h formerly did this, but other
310 source files not surprisingly expected syssignal.h to define, or
311 not define, SIGIO, and it's cleaner to do it that way, for consistency.
312 Include <sys/ioctl.h>, for FIONREAD.
313 * systty.h (SIGIO): Do not #undef here; it's now syssignal.h's job.
314 This eliminates a problem whereby other files mysteriously had
315 to include "syssignal.h" before including "systty.h" if they
316 wanted to use "#ifdef SIGIO".
317
bc8000ff
EZ
3182012-09-07 Eli Zaretskii <eliz@gnu.org>
319
3e6d6928
EZ
320 * w32proc.c (sigaction): New function, emulates Posix 'sigaction'.
321
322 * w32.c (sigemptyset): Empty the set.
323 (sigsetmask, sigmask, sigblock, sigunblock): Remove unused functions.
324
bc8000ff
EZ
325 * alloc.c [ENABLE_CHECKING]: Include signal.h, since we need SIGABRT.
326
b4fa72f2
DA
3272012-09-07 Dmitry Antipov <dmantipov@yandex.ru>
328
329 * alloc.c (mark_buffer): Revert unsafe marking optimization.
330 (mark_object): Likewise for frame objects.
331
30730c93
PE
3322012-09-07 Paul Eggert <eggert@cs.ucla.edu>
333
334 * syssignal.h (handle_on_main_thread): Always declare,
335 even if FORWARD_SIGNAL_TO_MAIN_THREAD is not defined.
336 This ports to platforms without HAVE_PTHREAD.
337
2fe28299
PE
3382012-09-06 Paul Eggert <eggert@cs.ucla.edu>
339
340 Signal-handler cleanup (Bug#12327).
341 Emacs's signal handlers were written in the old 4.2BSD style with
342 sigblock and sigmask and so forth, and this led to some
343 inefficiencies and confusion. Rewrite these to use
344 pthread_sigmask etc. without copying signal sets around. Also,
345 get rid of the confusing macros 'SIGNAL_THREAD_CHECK' and
346 'signal', and instead use functions that do not attempt to take
347 over the system name space. This patch causes Emacs's text
348 segment to shrink by 0.7% on my platform, Fedora 17 x86-64.
349 * alloc.c, emacsgtkfixed.c, nsfns.m, widget.c, xmenu.c:
350 Do not include <signal.h> or "syssignal.h", as these
351 modules do not use signals.
352 * atimer.c, callproc.c, data.c, dispnew.c, emacs.c, floatfns.c:
353 * gtkutil.c, keyboard.c, process.c, sound.c, sysdep.c, term.c, xterm.c:
354 Do not include <signal.h>, as "syssignal.h" does that for us now.
355 * atimer.c (sigmask_atimers): New function.
356 (block_atimers, unblock_atimers): New functions,
357 replacing the old macros BLOCK_ATIMERS and UNBLOCK_ATIMERS.
358 All uses replaced.
359 * conf_post.h [SIGNAL_H_AHB]: Do not include <signal.h>;
360 no longer needed here.
361 * emacs.c (main): Inspect existing signal handler with sigaction,
362 so that there's no need to block and unblock SIGHUP.
363 * sysdep.c (struct save_signal): New member 'action', replacing
364 old member 'handler'.
365 (save_signal_handlers, restore_signal_handlers):
366 Use sigaction instead of 'signal' to save and restore.
367 (get_set_sighandler, set_sighandler) [!WINDOWSNT]:
368 New function. All users of 'signal' modified to use set_sighandler
369 if they're writeonly, and to use sys_signal if they're read+write.
370 (emacs_sigaction_init, forwarded_signal): New functions.
371 (sys_signal): Remove. All uses replaced by calls to sigaction
372 and emacs_sigaction_init, or by direct calls to 'signal'.
373 (sys_sigmask) [!__GNUC__]: Remove; no longer needed.
374 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove;
375 all uses replaced by pthread_sigmask etc. calls.
376 * syssignal.h: Include <signal.h>.
377 (emacs_sigaction_init, forwarded_signal): New decls.
378 (SIGMASKTYPE): Remove. All uses replaced by its definiens, sigset_t.
379 (SIGEMPTYMASK): Remove; all uses replaced by its definiens, empty_mask.
380 (sigmask, sys_sigmask): Remove; no longer needed.
381 (sigpause): Remove. All uses replaced by its definiens, sigsuspend.
382 (sigblock, sigunblock, sigfree):
383 (sigsetmask) [!defined sigsetmask]:
384 Remove. All uses replaced by pthread_sigmask.
385 (signal): Remove. Its remaining uses (with SIG_DFL and SIG_IGN)
386 no longer need to be replaced, and its typical old uses
387 are now done via emacs_sigaction_init and sigaction.
388 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove decls.
389 (sys_sigdel): Remove; unused.
390 (NSIG): Remove a FIXME; the code's fine. Remove an unnecessary ifdef.
391
0216c128
EZ
3922012-09-06 Eli Zaretskii <eliz@gnu.org>
393
394 * process.c (CAN_HANDLE_MULTIPLE_CHILDREN): Fix a typo that broke
395 SIGCHLD handling on systems that don't have WNOHANG. (Bug#12327)
396
c752cfa9
DA
3972012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
398
399 Explicitly mark buffer_defaults and buffer_local_symbols.
400 * alloc.c (Fgarbage_collect): Mark buffer_defaults and
401 mark_local_symbols here.
402 (mark_object): If GC_CHECK_MARKED_OBJECTS, simplify checking
403 since special buffers aren't marked here any more.
404 (allocate_buffer): Chain new buffer with all_buffers here...
405 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer): ...and
406 not here.
407 (Vbuffer_defaults, Vbuffer_local_symbols): Remove.
408 (syms_of_buffer): Remove staticpro of the above.
409 (init_buffer_once): Set names for buffer_defaults and
410 buffer_local_symbols.
411
a864ef14
PE
4122012-09-06 Paul Eggert <eggert@cs.ucla.edu>
413
414 Use bool for booleans in font-related modules.
415 * font.c (font_intern_prop, font_style_to_value)
416 (font_style_symbolic, font_parse_xlfd, font_parse_fcname)
417 (generate_otf_features, font_check_otf_features, font_check_otf)
418 (font_match_p, font_list_entities, font_at):
419 * fontset.c (fontset_id_valid_p, reorder_font_vector
420 (fontset_find_font, Fset_fontset_font)
421 (face_suitable_for_char_p) [0]:
422 * ftfont.c (fc_initialized, ftfont_get_open_type_spec)
423 (ftfont_open, ftfont_text_extents, ftfont_check_otf):
424 (m17n_flt_initialized, ftfont_shape_by_flt):
425 * ftxfont.c (ftxfont_draw_bitmap, ftxfont_draw):
426 * nsfont.m (nsfont_draw):
427 * w32font.c (w32font_draw):
428 * w32term.c (x_draw_glyphless_glyph_string_foreground):
429 Use bool for booleans.
430 * font.h: Adjust to above API changes.
431 (struct font, struct font_driver, struct font_driver_list):
432 Use bool for booleans.
433 (struct font): Remove useless member encoding_type.
434 All users removed.
435 * fontset.c, xftfont.c: Omit unnecessary static decls.
436
0699fc18
DA
4372012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
438
439 * alloc.c (mark_object): Revert window marking code
440 since it's unsafe for the Fset_window_configuration.
441
20ef56db
PE
4422012-09-05 Paul Eggert <eggert@cs.ucla.edu>
443
2fe28299 444 Fix race conditions with signal handlers and errno (Bug#12327).
20ef56db
PE
445 Be more systematic about preserving errno whenever a signal
446 handler returns, even if it's not in the main thread. Do this by
447 renaming signal handlers to distinguish between signal delivery
448 and signal handling. All uses changed.
449 * atimer.c (deliver_alarm_signal): Rename from alarm_signal_handler.
450 * data.c (deliver_arith_signal): Rename from arith_error.
451 * dispnew.c (deliver_window_change_signal): Rename from
452 window_change_signal.
453 * emacs.c (deliver_error_signal): Rename from fatal_error_signal.
454 (deliver_danger_signal) [SIGDANGER]: Rename from memory_warning_signal.
455 * keyboard.c (deliver_input_available_signal): Rename from
456 input_available_signal.
457 (deliver_user_signal): Rename from handle_user_signal.
458 (deliver_interrupt_signal): Rename from interrupt_signal.
459 * process.c (deliver_pipe_signal): Rename from send_process_trap.
460 (deliver_child_signal): Rename from sigchld_handler.
461 * atimer.c (handle_alarm_signal):
462 * data.c (handle_arith_signal):
463 * dispnew.c (handle_window_change_signal):
464 * emacs.c (handle_fatal_signal, handle_danger_signal):
465 * keyboard.c (handle_input_available_signal):
466 * keyboard.c (handle_user_signal, handle_interrupt_signal):
467 * process.c (handle_pipe_signal, handle_child_signal):
468 New functions, with the actual signal-handling code taken from the
469 original respective signal handlers, sans the sporadic attempts to
470 preserve errno, since that's now done by handle_on_main_thread.
471 * atimer.c (alarm_signal_handler): Remove unnecessary decl.
472 * emacs.c, floatfns.c, lisp.h: Remove unused FLOAT_CATCH_SIGKILL cruft.
473 * emacs.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
474 Move to sysdep.c.
475 (main) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
476 Move initialization of main_thread to sysdep.c's init_signals.
477 * process.c (waitpid) [!WNOHANG]: #define to wait; that's good enough for
478 our usage, and simplifies the mainline code.
479 (record_child_status_change): New static function, as a helper
480 for handle_child_signal, and with most of the old child handler's
481 contents.
482 (CAN_HANDLE_MULTIPLE_CHILDREN): New constant.
483 (handle_child_signal): Use the above.
484 * sysdep.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
485 Moved here from emacs.c.
486 (init_signals) [FORWARD_SIGNAL_TO_MAIN_THREAD]: Initialize it;
487 code moved here from emacs.c's main function.
488 * sysdep.c, syssignal.h (handle_on_main_thread): New function,
489 replacing the old SIGNAL_THREAD_CHECK. All uses changed. This
490 lets callers save and restore errno properly.
491
e3ccf108
DA
4922012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
493
494 Remove redundant or unused things here and there.
495 * lisp.h (CYCLE_CHECK, CHAR_TABLE_TRANSLATE): Remove.
496 * conf_post.h (RE_TRANSLATE): Use char_table_translate.
497 * editfns.c (Fcompare_buffer_substrings): Likewise.
498 * frame.h (struct terminal, struct font_driver_list):
499 Remove redundant declarations.
500 * window.h (Qleft, Qright): Likewise.
501
697e1e39
DA
5022012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
503
504 Do not mark objects from deleted buffers, windows and frames.
505 * alloc.c (mark_buffer): Mark just the buffer if it is dead.
506 (mark_object): Likewise for windows and frames.
507
c1ca42ca
DA
5082012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
509
510 * alloc.c (valid_lisp_object_p): Treat killed buffers,
511 buffer_defaults and buffer_local_symbols as valid objects.
512 Return special value to denote them.
513
014d93be
PE
5142012-09-05 Paul Eggert <eggert@cs.ucla.edu>
515
f75d7a91
PE
516 * fileio.c, filelock.c, floatfns.c, fns.c: Use bool for boolean.
517 * fileio.c (auto_saving, auto_save_error_occurred, make_temp_name)
518 (Fexpand_file_name, barf_or_query_if_file_exists, Fcopy_file)
519 (file_name_absolute_p, Fsubstitute_in_file_name):
520 (check_executable, check_writable, Ffile_accessible_directory_p)
521 (Fset_file_selinux_context, Fdefault_file_modes)
522 (Finsert_file_contents, choose_write_coding_system)
523 (Fwrite_region, build_annotations, a_write, e_write)
524 (Fdo_auto_save):
525 * filelock.c (boot_time_initialized, get_boot_time)
526 (get_boot_time_1, lock_file_1, within_one_second):
527 * floatfns.c (in_float):
528 * fns.c (concat, internal_equal, Frequire, base64_encode_1)
529 (base64_decode_1, cmpfn_eql, cmpfn_user_defined)
530 (sweep_weak_table, sweep_weak_hash_tables, secure_hash):
531 * lisp.h (struct Lisp_Hash_Table.cmpfn):
532 * window.c (compare_window_configurations):
533 Use bool for booleans.
534 * fileio.c (auto_saving_dir_umask, auto_saving_mode_bits)
535 (Fdefault_file_modes): Now mode_t, not int, for modes.
536 (Fdo_auto_save): Set a boolean to 1 rather than using ++.
537 (internal_delete_file): Now returns void, not a (boolean) int,
538 since nobody was looking at the return value.
539 * lisp.h, window.h: Adjust to above API changes.
540
014d93be
PE
541 * xdisp.c (set_message): Simplify and reindent last change.
542
776f29e1
JB
5432012-09-05 Juanma Barranquero <lekktu@gmail.com>
544
545 * makefile.w32-in ($(BLD)/sysdep.$(O)): Update dependencies.
546
7f7e0167
LI
5472012-09-04 Lars Ingebrigtsen <larsi@gnus.org>
548
549 * eval.c (call_debugger): Make the function non-static so that we
550 can call it from set_message.
551
552 * xdisp.c (set_message): Implement the new variable `debug-on-message'.
553 (syms_of_xdisp): Defvar it and `inhibit-debug-on-message'.
554
cf29dd84
PE
5552012-09-04 Paul Eggert <eggert@cs.ucla.edu>
556
557 Give more-useful info on a fatal error (Bug#12328).
558 * alloc.c [ENABLE_CHECKING]: Do not include <execinfo.h>.
559 (die) [ENABLE_CHECKING]: Call fatal_error_backtrace instead
560 of doing the work ourselves.
561 * emacs.c (fatal_error_signal): Let fatal_error_backtrace
562 do most of the work.
563 (fatal_error_backtrace): New function, taken from the guts
564 of the old fatal_error_signal, but with a new option to output
565 a backtrace.
566 (shut_down_emacs) [!DOS_NT]: Use strsignal to give more-useful
567 info about the signal than just its number.
568 * lisp.h (fatal_error_backtrace, emacs_backtrace): New decls.
569 * sysdep.c: Include <execinfo.h>
570 (emacs_backtrace): New function, taken partly from the previous
571 code of the 'die' function.
572 (emacs_abort): Call fatal_error_backtrace rather than abort.
573
972debf2
SM
5742012-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
575
576 * lread.c (readevalloop): Call internal-macroexpand-for-load to perform
577 eager (load-time) macro-expansion.
578 * lisp.mk (lisp): Add macroexp.
579
1088b922
PE
5802012-09-04 Paul Eggert <eggert@cs.ucla.edu>
581
582 Simplify redefinition of 'abort' (Bug#12316).
583 Do not try to redefine the 'abort' function. Instead, redo
584 the code so that it calls 'emacs_abort' rather than 'abort'.
585 This removes the need for the NO_ABORT configure-time macro
586 and makes it easier to change the abort code to do a backtrace.
587 * .gdbinit: Just stop at emacs_abort, not at w32_abort or abort.
588 * emacs.c (abort) [!DOS_NT && !NO_ABORT]:
589 Remove; sysdep.c's emacs_abort now takes its place.
590 * lisp.h (emacs_abort): New decl. All calls from Emacs code to
591 'abort' changed to use 'emacs_abort'.
592 * msdos.c (dos_abort) [defined abort]: Remove; not used.
593 (abort) [!defined abort]: Rename to ...
594 (emacs_abort): ... new name.
595 * sysdep.c (emacs_abort) [!HAVE_NTGUI]: New function, taking
596 the place of the old 'abort' in emacs.c.
597 * w32.c, w32fns.c (abort): Do not #undef.
598 * w32.c (emacs_abort): Rename from w32_abort.
599
30934d33
EZ
6002012-09-04 Eli Zaretskii <eliz@gnu.org>
601
602 * w32uniscribe.c (uniscribe_shape): Reverse the sign of
603 offsets[j].dv, since the y axis of the screen coordinates points
604 down, while the y axis of the font definition coordinates points
605 up. This fixes display of Arabic diacritics such as KASRA and
606 KASRATAN. (Bug#11860)
607
af26b72c
PE
6082012-09-04 Paul Eggert <eggert@cs.ucla.edu>
609
610 Be more systematic about _setjmp vs setjmp.
611 * alloc.c (test_setjmp, mark_stack):
612 * image.c (PNG_LONGJMP) [PNG_LIBPNG_VER < 10500]:
613 (PNG_JMPBUF) [! (PNG_LIBPNG_VER < 10500)]:
614 (png_load, my_error_exit, jpeg_load):
615 * process.c (send_process_trap, send_process):
616 Uniformly prefer _setjmp and _longjmp to setjmp and longjmp.
617 The underscored versions are up to 30x faster on some hosts.
618 Formerly, the code used setjmp+longjmp sometimes and
619 _setjmp+_longjmp at other times, with no particular reason to
620 prefer setjmp+longjmp.
621
26d4541d
PE
6222012-09-03 Paul Eggert <eggert@cs.ucla.edu>
623
d42f4f0f 624 Fix minor problem found by static checking.
26d4541d 625 * buffer.c (Fdelete_all_overlays): Return nil.
26d4541d 626
c5e28e39
MR
6272012-09-03 Martin Rudalics <rudalics@gmx.at>
628
629 * buffer.c (Fdelete_all_overlays): New function.
630
3eab3ca9
CY
6312012-09-03 Chong Yidong <cyd@gnu.org>
632
633 * gtkutil.c: Add extern decl for Qxft.
634
c04889f8
PE
6352012-09-02 Paul Eggert <eggert@cs.ucla.edu>
636
1882aa38
PE
637 * emacs.c, eval.c: Use bool for boolean.
638 * emacs.c (initialized, inhibit_window_system, running_asynch_code):
639 (malloc_using_checking) [DOUG_LEA_MALLOC]:
640 (display_arg) [HAVE_X_WINDOWS || HAVE_NS]:
641 (noninteractive, no_site_lisp, fatal_error_in_progress, argmatch)
642 (main, decode_env_path, Fdaemon_initialized):
643 * eval.c (call_debugger, Finteractive_p, interactive_p):
644 (unwind_to_catch, Fsignal, wants_debugger, skip_debugger)
645 (maybe_call_debugger, Fbacktrace):
646 * process.c (read_process_output, exec_sentinel):
647 Use bool for booleans.
648 * emacs.c (shut_down_emacs): Omit unused boolean argument NO_X.
649 All callers changed.
650 * eval.c (interactive_p): Omit always-true boolean argument
651 EXCLUDE_SUBRS_P. All callers changed.
652 * dispextern.h, lisp.h: Reflect above API changes.
653 * firstfile.c (dummy): Use the address of 'main', whose signature
654 won't change, instead of the address of 'initialize', whose
655 signature just changed from int to bool.
656 * lisp.h (fatal_error_in_progress): New decl of boolean, moved here ...
657 * msdos.c (fatal_error_in_progress): ... from here.
658 * xdisp.c (redisplaying_p): Now a boolean. Set it to 1 instead
659 of incrementing it.
660 (redisplay_internal, unwind_redisplay): Simply clear
661 REDISPLAYING_P when unwinding, instead of saving its previous,
662 always-false value and then restoring it.
663
a411ac43
PE
664 Clean up some extern decls.
665 Mostly, this hoists extern decls out of .c files and into .h files.
666 That way, we're more likely to catch errors if the interfaces change.
667 * alloc.c [USE_GTK]: Include "gtkutil.h" so that we need not
668 declare xg_mark_data.
669 * dispextern.h (x_frame_parm_handlers):
670 * font.h (Qxft):
671 * lisp.h (Qlexical_binding, Qinternal_interpreter_environment)
672 (Qextra_light, Qlight, Qsemi_light, Qsemi_bold, Qbold, Qextra_bold)
673 (Qultra_bold, Qoblique, Qitalic):
674 Move extern decl here from .c file.
675 * alloc.c (xg_mark_data) [USE_GTK]:
676 * doc.c (Qclosure):
677 * eval.c (Qlexical_binding):
678 * fns.c (time) [!HAVE_UNISTD_H]:
679 * gtkutil.c (Qxft, Qnormal, Qextra_light, Qlight, Qsemi_light)
680 (Qsemi_bold, Qbold, Qextra_bold, Qultra_bold, Qoblique, Qitalic):
681 * image.c (Vlibrary_cache, QCloaded_from) [HAVE_NTGUI]:
682 * lread.c (Qinternal_interpreter_environment):
683 * minibuf.c (Qbuffer):
684 * process.c (QCfamily, QCfilter):
685 * widget.c (free_frame_faces):
686 * xfaces.c (free_frame_menubar) [USE_X_TOOLKIT]:
687 * xfont.c (x_clear_errors):
688 * xterm.c (x_frame_parm_handlers):
689 Remove now-redundant extern decls.
690 * keyboard.c, keyboard.h (ignore_mouse_drag_p) [USE_GTK || HAVE_NS]:
691 * xfaces.c (Qultra_light, Qreverse_oblique, Qreverse_italic):
692 Now static.
693 * xfaces.c: Remove unnecessary static decls.
694 * xterm.c (updating_frame): Remove decl of nonexistent object.
695
c04889f8
PE
696 * Makefile.in (gl-stamp): Don't scan $(SOME_MACHINE_OBJECTS)
697 when building globals.h, as the objects that are not built on
698 this host are not needed to compile C files on this host.
699
8b339673
JD
7002012-09-02 Jan Djärv <jan.h.d@swipnet.se>
701
702 * gtkutil.h: Remove prototype for x_wm_set_size_hint.
703
704 * frame.h: Add missing prototype for x_wm_set_size_hint.
705
a08d4ba7
PE
7062012-09-02 Paul Eggert <eggert@cs.ucla.edu>
707
708 * doc.c, editfns.c, insdel.c, intervals.c: Use bool for boolean.
709 * doc.c (read_bytecode_char, get_doc_string, reread_doc_file)
710 (Fdocumentation, Fdocumentation_property, Fsnarf_documentation)
711 (Fsubstitute_command_keys):
712 * editfns.c (region_limit, find_field, Fconstrain_to_field)
713 (save_excursion_save, save_excursion_restore)
714 (disassemble_lisp_time, decode_time_components, emacs_nmemftime)
715 (format_time_string, general_insert_function)
716 (make_buffer_string, make_buffer_string_both)
717 (Fsubst_char_in_region, Ftranslate_region_internal, Fformat):
718 * insdel.c (check_markers, gap_left, adjust_markers_for_insert)
719 (copy_text, insert_1, insert_1_both, insert_from_string)
720 (insert_from_string_before_markers, insert_from_string_1)
721 (insert_from_buffer, insert_from_buffer_1, replace_range)
722 (replace_range_2, del_range_1, del_range_byte, del_range_both)
723 (del_range_2, modify_region):
724 * intervals.c (intervals_equal, balance_possible_root_interval)
725 (adjust_intervals_for_insertion, merge_properties_sticky)
726 (graft_intervals_into_buffer, lookup_char_property)
727 (adjust_for_invis_intang, set_point_both)
728 (get_property_and_range, compare_string_intervals)
729 (set_intervals_multibyte_1, set_intervals_multibyte):
730 * keyboard.c (decode_timer):
731 Use bool for boolean.
732 * intervals.h, lisp.h, systime.h: Reflect above API changes.
733 * editfns.c (struct info): Use 1-bit unsigned bitfields for booleans.
734
48c948de
CY
7352012-09-02 Chong Yidong <cyd@gnu.org>
736
737 * keymap.c (push_key_description): Print M-TAB as C-M-i
738 (Bug#11758).
739
6c49a40b
JB
7402012-09-02 Juanma Barranquero <lekktu@gmail.com>
741
742 * makefile.w32-in (CCL_H, W32FONT_H): New macros.
743 (ATIMER_H, FONT_H, $(BLD)/alloc.$(O), $(BLD)/callproc.$(O))
744 ($(BLD)/editfns.$(O), $(BLD)/ccl.$(O), $(BLD)/chartab.$(O))
745 ($(BLD)/coding.$(O), $(BLD)/sysdep.$(O), $(BLD)/fontset.$(O))
746 ($(BLD)/sysdep.$(O), $(BLD)/w32fns.$(O), $(BLD)/keyboard.$(O))
747 ($(BLD)/w32term.$(O), $(BLD)/w32menu.$(O), $(BLD)/process.$(O))
748 ($(BLD)/w32font.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
749
4dfbd238
EZ
7502012-09-01 Eli Zaretskii <eliz@gnu.org>
751
7e510e28
EZ
752 * w32uniscribe.c (uniscribe_shape): Handle correctly the case of
753 more than one grapheme cluster passed to the shaper: compute the
754 offset adjustment values separately for each cluster. (Bug#11860)
755
4dfbd238
EZ
756 * image.c: Restore mistakenly removed inclusion of w32.h. Without
757 it, GCC doesn't see prototypes of w32_delayed_load, and complains
758 about implicit conversions from integer to pointer.
759
86571ae0
DC
7602012-09-01 Daniel Colascione <dancol@dancol.org>
761
762 * w32fns.c (x_display_info_for_name): Prevent crash if w32 window
763 system used too early.
764
0e23ef9d
PE
7652012-09-01 Paul Eggert <eggert@cs.ucla.edu>
766
767 Better seed support for (random).
768 * emacs.c (main): Call init_random.
769 * fns.c (Frandom): Set the seed from a string argument, if given.
770 Remove long-obsolete Gentzel cruft.
771 * lisp.h, sysdep.c (seed_random): Now takes address and size, not long.
772 (init_random): New function.
773
17a2cbbd
DC
7742012-09-01 Daniel Colascione <dancol@dancol.org>
775
776 * xterm.h: Add header guards. Declare x_menubar_window_to_frame.
777 Remove x_set_frame_alpha, x_bitmap_icon, x_make_frame_visible,
778 x_make_frame_invisible, x_iconify_frame, x_free_frame_resources,
779 x_wm_set_size_hint, x_query_colors, x_real_positions,
780 x_set_menu_bar_lines, x_char_width, x_char_height, x_sync,
781 x_set_tool_bar_lines, x_activate_menubar, and free_frame_menubar,
782 all of which have been moved to common code.
783
784 * xfaces.c: Include TERM_HEADER instead of listing all possible
785 window-system headers.
786
787 * w32xfns.c (x_sync): Correct definition of x_sync (a no-op here)
788 to match header.
789
790 * w32term.h (FRAME_X_WINDOW): Use FRAME_W32_WINDOW instead of
791 directly accessing frame internals.
792
f18cbb28 793 * w32font.h: Include font.h. Define syms_of_w32font and
17a2cbbd
DC
794 globals_of_w32font.
795
796 * process.c: Include TERM_HEADER instead of listing all possible
797 window-system headers.
798
799 * nsterm.h: Remove declarations now in frame.h. Define
800 FRAME_X_SCREEN, FRAME_X_VISUAL.
801
802 * menu.c: Include TERM_HEADER instead of listing all possible
803 window-system headers.
804
805 * keyboard.h: Declare ignore_mouse_drag_p whenever we have a
806 window system.
807
808 * keyboard.c: Include TERM_HEADER instead of listing all possible
809 window-system headers.
810
811 * image.c: Include TERM_HEADER instead of listing all possible
812 window-system headers. Declare Vlibrary_cache when compiling for
813 Windows.
814
815 * gtkutil.h (xg_list_node_): Include xterm.h to pick up needed
816 window system declarations.
817
818 * frame.h: Move common functions here: set_frame_menubar,
819 x_set_window_size, x_sync, x_get_focus_frame,
820 x_set_mouse_position, x_set_mouse_pixel_position,
821 x_make_frame_visible, x_make_frame_invisible, x_iconify_frame,
822 x_char_width, x_char_height, x_pixel_width, x_pixel_height,
823 x_set_frame_alpha, x_set_menu_bar_lines, x_set_tool_bar_lines,
824 x_activate_menubar, x_real_positions, x_bitmap_icon,
825 x_set_menu_bar_lines, free_frame_menubar, x_free_frame_resources,
826 and x_query_colors.
827
828 * frame.c: Include TERM_HEADER instead of listing all possible
829 window-system headers.
830
831 * font.c: Include TERM_HEADER instead of listing all possible
832 window-system headers.
833
834 * emacs.c: Include TERM_HEADER.
835
f18cbb28
EZ
836 * dispnew.c: Include TERM_HEADER instead of listing all possible
837 window-system headers.
17a2cbbd 838
f18cbb28 839 * ccl.h: Include character.h.
17a2cbbd
DC
840
841 * Makefile.in: Define WINDOW_SYSTEM_OBJ to hold objects needed for
842 the current window system; include in list of objects to link into
843 Emacs.
844
c650a5de
DA
8452012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
846
847 Remove mark_ttys function and fix tty_display_info initialization.
848 * lisp.h (mark_ttys): Remove prototype.
849 * alloc.c (Fgarbage_collect): Remove redundant (and the only) call
850 to mark_ttys because all possible values of 'top_frame' slot are
851 the frames which are reachable from Vframe_list.
852 * term.c (mark_ttys): Remove.
853 (init_tty): Safely initialize 'top_frame' slot with Qnil.
854
4e0f6479
DA
8552012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
856
857 Change struct frame bitfields from unsigned char to unsigned.
858 * frame.h (struct frame): Change type of 'display_preempted',
859 'visible', 'iconified', 'has_minibuffer', 'wants_modeline',
860 'auto_raise', 'auto_lower', 'no_split', 'explicit_name',
861 'window_sizes_changed', 'mouse_moved' and 'pointer_invisible'
862 bitfields from unsigned char to unsigned.
863
8b96a52c
DA
8642012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
865
866 Remove unused member of struct x_output and struct w32_output.
867 * xterm.h (struct x_output): Remove unused field 'needs_exposure'.
868 * w32term.h (struct w32_output): Likewise.
869
b4444c8a
JD
8702012-08-30 Jan Djärv <jan.h.d@swipnet.se>
871
872 * gtkutil.c (x_wm_set_size_hint): Use 1 col for base_width so it
873 does not become zero (Bug#12234).
874
b98521db
PE
8752012-08-30 Paul Eggert <eggert@cs.ucla.edu>
876
877 * dispnew.c (update_frame_1): Pacify gcc -Wstrict-overflow
878 for GCC 4.7.1 x86-64.
879
31d02438
GM
8802012-08-30 Glenn Morris <rgm@gnu.org>
881
882 * lread.c (init_lread): For out-of-tree builds, only add the
883 source directory's site-lisp dir to the load-path if it exists,
884 consistent with in-tree builds. (Bug#12302)
885
7f8941d8
JD
8862012-08-28 Jan Djärv <jan.h.d@swipnet.se>
887
888 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
889 button_values to NULL. Call setStykeMask so dialogs get a close button.
890 (windowShouldClose:): Set window_closed.
891 (dealloc): New member, free button_values.
892 (process_dialog:): Make member function. Remove window argument,
893 replace window with self. Count buttons and allocate and store values
894 in button_values.
895 (addButton:value:row:): value is int with the name tag. Call setTag
896 with tag. Remove return self, declare return value as void.
897 (addString:row:): Remove return self, declare return value as void.
898 (addSplit): Remove return self, declare return value as void.
899 (clicked:): Remove return self, declare return value as void.
900 Set dialog_return to button_values[seltag]. Code formatting change.
901 (initFromContents:isQuestion:): Adjust call to process_dialog.
902 Code formatting change.
903 (timeout_handler:): Set timer_fired to YES.
904 (runDialogAt:): Set timer_fired to NO.
905 Handle click on close button as quit.
906
907 * nsterm.h (EmacsDialogPanel): Make timer_fired BOOL.
908 Add window_closed and button_values. Add void as return value for
909 add(Button|String|Split). addButton takes int instead of Lisp_Object.
910 Add process_dialog as new member.
911
eada0861 9122012-08-28 Eli Zaretskii <eliz@gnu.org>
19c17fc1 913
eada0861
GM
914 * ralloc.c (free_bloc): Don't dereference a 'heap' structure if it
915 is not one of the heaps we manage. (Bug#12242)
916
9172012-08-28 Glenn Morris <rgm@gnu.org>
918
919 * eval.c (Fcalled_interactively_p): Doc fix. (Bug#11747)
920
457294dd
MR
9212012-08-28 Martin Rudalics <rudalics@gmx.at>
922
923 * window.c (Fset_window_configuration): Remove handling of
37b9743e
MR
924 auto-buffer-name window parameter. Install revision of reverted
925 fix.
457294dd 926
4f2daf31
DA
9272012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
928
929 Do not allow to set major mode for a dead buffer.
930 * buffer.c (Fset_buffer_major_mode): Signal an error
931 if the buffer is dead.
932 (Fother_buffer, other_buffer_safely): Remove redundant
933 nested declaration.
934
66322887
DA
9352012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
936
937 Always use set_buffer_if_live to restore original buffer at unwind.
938 * buffer.h (record_unwind_current_buffer): New function.
939 * bytecode.c, dispnew.c, editfns.c, fileio.c, fns.c, insdel.c:
940 * keyboard.c, keymap.c, minibuf.c, print.c, process.c, textprop.c:
941 * undo.c, window.c: Adjust users.
942 * buffer.c (set_buffer_if_live): Fix comment.
943
a3d794a1
DA
9442012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
945
946 Fix usage of set_buffer_internal.
947 * buffer.h (set_buffer_internal): Make it BUFFER_INLINE.
948 * buffer.c (set_buffer_if_live): Use set_buffer_internal.
949 * coding.c (decode_coding): Omit redundant test.
950 * fileio.c (decide_coding_unwind): Likewise.
951 * fns.c (secure_hash): Likewise.
952 * insdel.c (modify_region): Likewise.
953 * keyboard.c (command_loop_1): Likewise.
954 * print.c (PRINTFINISH): Likewise.
955 * xdisp.c (run_window_scroll_functions): Use set_buffer_internal.
956
59ea14cd
PE
9572012-08-27 Paul Eggert <eggert@cs.ucla.edu>
958
959 * dispnew.c: Use bool for boolean.
960 (frame_garbaged, display_completed, delayed_size_change)
961 (fonts_changed_p, add_window_display_history)
962 (add_frame_display_history, verify_row_hash)
963 (adjust_glyph_matrix, clear_window_matrices, glyph_row_slice_p)
964 (row_equal_p, realloc_glyph_pool)
965 (allocate_matrices_for_frame_redisplay)
966 (showing_window_margins_p)
967 (adjust_frame_glyphs_for_frame_redisplay)
968 (build_frame_matrix_from_leaf_window, make_current)
969 (mirrored_line_dance, mirror_line_dance, update_frame)
970 (update_window_tree, update_single_window)
971 (check_current_matrix_flags, update_window, update_text_area)
972 (update_window_line, set_window_update_flags, scrolling_window)
973 (update_frame_1, scrolling, buffer_posn_from_coords)
974 (do_pending_window_change, change_frame_size)
975 (change_frame_size_1, sit_for):
976 Use bool for boolean.
977 (clear_glyph_matrix_rows): Rename from enable_glyph_matrix_rows,
978 and remove last int (actually boolean) argument, which was always 0.
979 All callers changed.
980 * dispextern.h, frame.h, lisp.h: Reflect above API changes.
981 * dispextern.h (struct composition_it): Use bool for boolean.
982 (struct glyph_matrix): Don't assume buffer sizes can fit in 'int'.
983 (struct bidi_it): Use unsigned:1, not int, for boolean prev_was_pdf.
984 * dired.c (file_name_completion):
985 Use bool for boolean. (This was missed in an earlier change.)
986
95072a94
MR
9872012-08-27 Martin Rudalics <rudalics@gmx.at>
988
989 * window.c (Fset_window_configuration): Revert first part of
990 last change.
991
0f19feff
JD
9922012-08-27 Jan Djärv <jan.h.d@swipnet.se>
993
994 * nsterm.h (NSPanel): New class variable dialog_return.
995
996 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
997 dialog_return.
998 (windowShouldClose:): Use stop instead of stopModalWithCode.
999 (clicked:): Ditto, and also set dialog_return (Bug#12258).
1000 (timeout_handler:): Use stop instead of abortModal. Send a dummy
1001 event.
1002 (runDialogAt:): Make ret Lisp_Object. Set it from dialog_return when
1003 modal loop returns.
1004
f10fe38f
PE
10052012-08-27 Paul Eggert <eggert@cs.ucla.edu>
1006
de1339b0
PE
1007 * composite.c, data.c, dbusbind.c, dired.c: Use bool for booleans.
1008 * composite.c (find_composition, composition_gstring_p)
1009 (composition_reseat_it, find_automatic_composition):
1010 * data.c (let_shadows_buffer_binding_p)
1011 (let_shadows_global_binding_p, set_internal, make_blv)
1012 (Fmake_variable_buffer_local, Fmake_local_variable)
1013 (Fmake_variable_frame_local, arithcompare, cons_to_unsigned)
1014 (cons_to_signed, arith_driver):
1015 * dbusbind.c (xd_in_read_queued_messages):
1016 * dired.c (directory_files_internal, file_name_completion):
1017 Use bool for booleans.
1018 * dired.c (file_name_completion):
1019 * process.h (fd_callback):
1020 Omit int (actually boolean) argument. It wasn't being used.
1021 All uses changed.
1022 * composite.h, lisp.h: Reflect above API changes.
1023
f10fe38f
PE
1024 * cmds.c, coding.c: Use bool for booleans.
1025 * cmds.c (move_point, Fself_insert_command):
1026 * coding.h (struct composition status, struct coding_system):
1027 * coding.c (detect_coding_utf_8, encode_coding_utf_8)
1028 (detect_coding_utf_16, encode_coding_utf_16, detect_coding_emacs_mule)
1029 (emacs_mule_char, decode_coding_emacs_mule)
1030 (encode_coding_emacs_mule, detect_coding_iso_2022)
1031 (decode_coding_iso_2022, encode_invocation_designation)
1032 (encode_designation_at_bol, encode_coding_iso_2022)
1033 (detect_coding_sjis, detect_coding_big5, decode_coding_sjis)
1034 (decode_coding_big5, encode_coding_sjis, encode_coding_big5)
1035 (detect_coding_ccl, encode_coding_ccl, decode_coding_raw_text)
1036 (encode_coding_raw_text, detect_coding_charset)
1037 (decode_coding_charset, encode_coding_charset, detect_eol)
1038 (detect_coding, get_translation_table, produce_chars)
1039 (consume_chars, reused_workbuf_in_use)
1040 (make_conversion_work_buffer, code_conversion_save)
1041 (decode_coding_object, encode_coding_object)
1042 (detect_coding_system, char_encodable_p)
1043 (Funencodable_char_position, code_convert_region)
1044 (code_convert_string, code_convert_string_norecord)
1045 (Fset_coding_system_priority):
1046 * fileio.c (Finsert_file_contents):
1047 Use bool for booleans.
1048 * coding.h, lisp.h: Reflect above API changes.
1049 * coding.c: Remove unnecessary static function decls.
1050 (detect_coding): Use unsigned, not signed, to copy an unsigned field.
1051 (decode_coding, encode_coding, decode_coding_gap): Return 'void',
1052 not a boolean 'int', since callers never look at the return value.
1053 (ALLOC_CONVERSION_WORK_AREA): Assume caller returns 'void', not 'int'.
1054 * coding.h (decoding_buffer_size, encoding_buffer_size)
1055 (emacs_mule_string_char): Remove unused extern decls.
1056 (struct iso_2022_spec, struct coding_system):
1057 Use 'unsigned int : 1' for boolean fields, since there's more than one.
1058 (struct emacs_mule_spec): Remove unused field 'full_support'.
1059 All initializations removed.
1060 * cmds.c (internal_self_insert): Don't assume EMACS_INT fits in 'int'.
1061
5474c384
DA
10622012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1063
f10fe38f 1064 Fix spare memory change (Bug#12286).
5474c384
DA
1065 * alloc.c (mark_maybe_pointer): Handle MEM_TYPE_SPARE.
1066 (valid_lisp_object_p): Likewise.
1067
c4b6914d
MR
10682012-08-27 Martin Rudalics <rudalics@gmx.at>
1069
1070 * window.c (Fset_window_configuration): Record any window's old
1071 buffer if it's replaced (see Bug#8789). If the new current
1072 buffer doesn't appear in the selected window, go to its old
1073 point (Bug#12208).
1074
35aaa1ea
DA
10752012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1076
1077 Special MEM_TYPE_SPARE to denote reserved memory.
1078 * alloc.c (enum mem_type): New memory type.
1079 (refill_memory_reserve): Use new type for spare memory.
1080 This prevents live_cons_p and live_string_p from incorrect
1081 detection of uninitialized objects from spare memory as live.
1082
6af64513
PE
10832012-08-26 Paul Eggert <eggert@cs.ucla.edu>
1084
8b2e00a3
PE
1085 Spelling fixes.
1086 * Makefile.in (.PHONY): versioclean -> versionclean.
1087
b52d6985
PE
1088 Remove unused external symbols.
1089 * data.c (Qcons, Qfloat, Qmisc, Qstring, Qvector):
1090 * window.c (Qwindow_valid_p, decode_valid_window):
1091 Now static, not extern.
1092 * data.c (Qinterval): Remove; unused.
1093 (syms_of_data): Do not define 'interval'.
1094 * lisp.h (Qinteger, Qstring, Qmisc, Qvector, Qfloat, Qcons):
1095 * window.h (decode_valid_window):
1096 Remove decls.
1097
d5172d4f
PE
1098 * character.c, charset.c, chartab.c: Use bool for booleans.
1099 * character.c (lisp_string_width, string_count_byte8)
1100 (string_escape_byte8):
1101 * charset.c (charset_map_loaded, load_charset_map, read_hex):
1102 (load_charset_map_from_file, map_charset_chars)
1103 (Fdefine_charset_internal, define_charset_internal)
1104 (Fdeclare_equiv_charset, find_charsets_in_text)
1105 (Ffind_charset_region, char_charset, Fiso_charset):
1106 * chartab.c (sub_char_table_ref, sub_char_table_ref_and_range)
1107 (sub_char_table_set, sub_char_table_set_range)
1108 (char_table_set_range, optimize_sub_char_table)
1109 (map_sub_char_table):
1110 Use bool for boolean.
1111 * character.c (str_to_unibyte): Omit last boolean argument; it was
1112 always 0. All callers changed.
1113 * character.h, charset.h: Adjust to match previous changes.
1114 * character.h (char_printable_p): Remove decl of nonexistent function.
1115 * charset.h (struct charset): Members code_linear_p, iso_chars_96,
1116 ascii_compatible_p, supplementary_p, compact_codes_p, unified_p
1117 are all boolean, so make them single-bit bitfields.
1118
6af64513
PE
1119 * lisp.h (ASET): Remove attempt to detect side effects.
1120 It was meant to be temporary and it often doesn't work,
1121 because when IDX has side effects the behavior of IDX==IDX
1122 is undefined. See Stefan Monnier in
1123 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00762.html>.
1124
e1f29348
BR
11252012-08-26 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
1126
1127 * lisp.h (functionp): New function (extracted from Ffunctionp).
1128 (FUNCTIONP): Use it.
1129 * eval.c (Ffunctionp): Use it.
1130
17c05d74
PE
11312012-08-25 Paul Eggert <eggert@cs.ucla.edu>
1132
0f46bc75
PE
1133 * xgselect.c (xg_select): Use auto storage for the GPollFD buffer
1134 as that's faster and simpler than static storage. Don't bother
1135 with the g_main_context_query overhead if g_main_context_pending
1136 says no events are pending.
1137 (gfds, gfds_size): Remove these static vars.
1138 (xgselect_initialize): Remove; no longer needed.
1139 All uses and decls removed.
1140
ee4c0f69
PE
1141 * emacs.c (fatal_error_signal_hook): Remove.
1142 All uses removed. This leftover from old code was always 0.
1143
17c05d74
PE
1144 * casefiddle.c, casetab.c, category.c: Use bool for boolean.
1145 * casefiddle.c (casify_object, casify_region):
1146 * casetab.c (set_case_table):
1147 * category.c, category.h (word_boundary_p):
1148 * category.h (CHAR_HAS_CATEGORY):
1149 Use bool for booleans, instead of int.
1150
391ceac5
EZ
11512012-08-25 Eli Zaretskii <eliz@gnu.org>
1152
1153 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on $(GNU_LIB)/execinfo.h.
1154
2f221583
PE
11552012-08-25 Paul Eggert <eggert@cs.ucla.edu>
1156
f4a681b0
PE
1157 On assertion failure, print backtrace if available.
1158 * alloc.c [ENABLE_CHECKING]: Include <execinfo.h>.
1159 (die) [ENABLE_CHECKING]: Print a backtrace if available.
1160 * Makefile.in (LIB_EXECINFO): New macro.
1161 (LIBES): Use it.
1162
2f221583
PE
1163 * bytecode.c, callint.c, callproc.c: Use bool for boolean.
1164 * bytecode.c (exec_byte_code):
1165 * callint.c (check_mark, Fcall_interactively):
1166 * callproc.c (Fcall_process, add_env, child_setup, getenv_internal_1)
1167 (getenv_internal, sync_process_alive, call_process_exited):
1168 * lisp.h (USE_SAFE_ALLOCA):
1169 Use bool for booleans, instead of int.
1170 * lisp.h, process.h: Adjust prototypes to match above changes.
1171 * callint.c (Fcall_interactively): Don't assume the mark's
1172 offset fits in 'int'.
1173
37ef52bb
PE
11742012-08-24 Paul Eggert <eggert@cs.ucla.edu>
1175
1176 * buffer.c, buffer.h: Use bool for boolean.
1177 * buffer.c (reset_buffer_local_variables)
1178 (buffer_lisp_local_variables, Fset_buffer_modified_p)
1179 (Frestore_buffer_modified_p, Fset_buffer_multibyte):
1180 (overlays_at, overlays_in, mouse_face_overlay_overlaps)
1181 (overlay_touches_p, overlay_strings, Foverlay_put)
1182 (report_overlay_modification, call_overlay_mod_hooks):
1183 (mmap_enlarge, mmap_set_vars):
1184 * buffer.h (buffer_has_overlays, uppercasep, lowercasep):
1185 Use bool for booleans, instead of int.
1186 * buffer.c (compact_buffer, mmap_free_1): Return void, not int,
1187 since the 1-or-0 return value is always ignored anyway.
1188 (mmap_initialized_p):
1189 * buffer.h (struct buffer_text.inhibit_shrinking): Now bool, not int.
1190 * buffer.h, lisp.h: Adjust prototypes to match above changes.
1191
2cc21167
PE
11922012-08-23 Paul Eggert <eggert@cs.ucla.edu>
1193
1194 * bidi.c: Use bool for boolean.
1195 This is a bit more readable, and makes the text segment of bidi.o
1196 0.4% smaller on my platform (GCC 4.7.1 x86-64, Fedora 15).
1197 Presumably it's faster too.
1198 (bidi_initialized, bidi_ignore_explicit_marks_for_paragraph_level):
1199 Now bool.
1200 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1201 (bidi_unshelve_cache, bidi_init_it, bidi_count_bytes)
1202 (bidi_char_at_pos, bidi_fetch_char, bidi_paragraph_init)
1203 (bidi_explicit_dir_char, bidi_level_of_next_char)
1204 (bidi_find_other_level_edge, bidi_move_to_visually_next):
1205 Use bool for booleans, instead of int.
1206 * dispextern.h (bidi_init_it, bidi_paragraph_init)
1207 (bidi_unshelve_cache): Adjust decls to match code.
1208
7db4ddf4
MR
12092012-08-23 Martin Rudalics <rudalics@gmx.at>
1210
1211 * keyboard.c (Fposn_at_x_y): Do not allow internal window as
1212 argument.
1213
b1bb8011
PE
12142012-08-23 Paul Eggert <eggert@cs.ucla.edu>
1215
1216 * atimer.c, atimer.h (turn_on_atimers): Use bool for boolean.
1217 * atimer.h: Include <stdbool.h>.
1218
ff687885
DN
12192012-08-22 Dan Nicolaescu <dann@gnu.org>
1220
1221 * frame.h (FRAME_W32_P, FRAME_MSDOS_P, FRAME_NS_P): Change to
1222 compile time tests instead of run time tests on systems that do
1223 not use them.
1224 (FRAME_MAC_P): Remove leftover from deleted code.
1225 * frame.c (syms_of_frame): Remove leftover from deleted code.
1226
4ce7a138
JD
12272012-08-22 Jan Djärv <jan.h.d@swipnet.se>
1228
1229 * nsterm.m (insertText:): Don't clear modifiers if code is space.
1230
d733ec6d
PE
12312012-08-22 Paul Eggert <eggert@cs.ucla.edu>
1232
1233 * fontset.c (FONTSET_ADD): Return void, not Lisp_Object.
1234 Otherwise, the compiler complains about (A?B:C) where B is void
1235 and C is Lisp_Object. This fixes an incompatibility with Sun C 5.12.
1236 (fontset_add): Return void, for FONTSET_ADD.
1237
d0d2d26f
PE
12382012-08-21 Paul Eggert <eggert@cs.ucla.edu>
1239
fce31d69
PE
1240 * alloc.c: Use bool for booleans.
1241 (gc_in_progress, abort_on_gc)
1242 (setjmp_tested_p) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
1243 (dont_register_blocks) [GC_MALLOC_CHECK]:
1244 (suppress_checking) [ENABLE_CHECKING]: Now bool, not int.
1245 (check_string_bytes, make_specified_string, memory_full)
1246 (live_string_p, live_cons_p, live_symbol_p, live_float_p)
1247 (live_misc_p, live_vector_p, live_buffer_p, mark_maybe_object)
1248 (mark_stack, valid_pointer_p, make_pure_string)
1249 (Fgarbage_collect, survives_gc_p, gc_sweep):
1250 Use bool for booleans, instead of int.
1251 (test_setjmp) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
1252 Remove unused local.
1253 * alloc.c (PURE_POINTER_P):
1254 * lisp.h (STRING_MULTIBYTE): Document that it returns a boolean.
1255 * editfns.c (Fformat):
1256 * fileio.c (Fexpand_file_name, Fsubstitute_in_file_name)
1257 (Fdo_auto_save):
1258 * fns.c (sweep_weak_table):
1259 * lisp.h (suppress_checking, push_message, survives_gc_p)
1260 (make_pure_string, gc_in_progress, abort_on_gc):
1261 * lread.c (readchar, read1):
1262 * print.c (Fprin1_to_string):
1263 * xdisp.c (push_message):
1264 Use bool for booleans affected directly or indirectly by
1265 alloc.c's changes.
1266
d0d2d26f
PE
1267 Make recently-introduced setters macros.
1268 * fontset.c (set_fontset_id, set_fontset_name, set_fontset_ascii)
1269 (set_fontset_base, set_fontset_frame, set_fontset_nofont_face)
1270 (set_fontset_default, set_fontset_fallback): Rename from their
1271 upper-case counterparts, and make them functions rather than macros.
1272 This is more consistent with the other recently-introduced setters.
1273 These don't need to be inline, since they're local.
1274
d18e2bb6
JD
12752012-08-21 Jan Djärv <jan.h.d@swipnet.se>
1276
1277 * nsterm.m (fd_handler:): Alloc and release a NSAutoreleasePool in
1278 the loop (Bug#12247).
1279
1b9d9d16
PE
12802012-08-21 Paul Eggert <eggert@cs.ucla.edu>
1281
1282 * lisp.h (vcopy): Use memcpy rather than our own loop.
1283 This fixes a performance regression introduced by the recent
1284 addition of vcopy. This means 'vcopy' will need to be modified
1285 for a copying collector, but that's OK. Also, tighten the
1286 checking in the assertion.
1287
b2f09701
EZ
12882012-08-21 Eli Zaretskii <eliz@gnu.org>
1289
1290 * w32uniscribe.c (uniscribe_shape): Fix producing gstring
1291 components for RTL text (Bug#11860). Adjust X-OFFSET of each
1292 non-base glyph for the width of the base character, according to
e1f29348
BR
1293 what x_draw_composite_glyph_string_foreground expects.
1294 Generate WADJUST value according to composition_gstring_width's
b2f09701
EZ
1295 expectations, to produce correct width of the composed character.
1296 Reverse the sign of the DU offset produced by ScriptPlace.
1297
9b994fed
PE
12982012-08-21 Paul Eggert <eggert@cs.ucla.edu>
1299
1300 * dbusbind.c (xd_remove_watch): Do not assume C99 comments.
1301
086ca913
DA
13022012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
1303
1304 Avoid direct writes to contents member of struct Lisp_Vector.
1305 * lisp.h (vcopy): New function to copy data into vector.
1306 * dispnew.c (Fframe_or_buffer_changed_p): Use AREF and ASET.
1307 * fns.c (Ffillarray): Use ASET.
1308 * keyboard.c (timer_check_2): Use AREF and ASET.
1309 (append_tool_bar_item, Frecent_keys): Use vcopy.
1310 * lread.c (read_vector): Use ASET.
1311 * msdos.c (Frecent_doskeys): Use vcopy.
1312 * xface.c (Finternal_copy_lisp_face): Use vcopy.
1313 (Finternal_merge_in_global_face): Use ASET and vcopy.
1314 * xfont.c (xfont_list_pattern): Likewise.
1315
5481664a
MR
13162012-08-21 Martin Rudalics <rudalics@gmx.at>
1317
1318 * window.c (Fwindow_point): For the selected window always return
1319 the position of its buffer's point.
1320 (Fset_window_point): For the selected window always go in its
1321 buffer to the specified position.
1322
6d470bdd
DA
13232012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
1324
1325 Setter macros for fontsets.
1326 * fontset.c (SET_FONTSET_ID, SET_FONTSET_NAME, SET_FONTSET_ASCII)
1327 (SET_FONTSET_BASE, SET_FONTSET_FRAME, SET_FONTSET_NOFONT_FACE)
1328 (SET_FONTSET_DEFAULT, SET_FONTSET_FALLBACK): New macros.
1329 Adjust users.
1330
24564fe1
GM
13312012-08-20 Glenn Morris <rgm@gnu.org>
1332
1333 * Makefile.in (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1334 Don't assume that `ln -f' works.
1335
0a05a035
EZ
13362012-08-20 Eli Zaretskii <eliz@gnu.org>
1337
1338 * .gdbinit: Use "set $dummy = ..." to avoid warnings from GDB 7.5
1339 and later about non-assignments with no effect. See discussion at
1340 http://sourceware.org/ml/gdb-patches/2012-08/msg00518.html for
1341 details.
1342
e46f2325
DA
13432012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
1344
1345 Inline setter functions for Lisp_Objects slots of struct specbinding.
1346 * eval.c (set_specpdl_symbol, set_specpdl_old_value): New functions.
1347 Adjust users.
1348
734fbd86
MR
13492012-08-20 Martin Rudalics <rudalics@gmx.at>
1350
1351 * window.c (select_window): Always make selected window's buffer
1352 current.
1353
f1a95992
DA
13542012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
1355
1356 Use AREF and ASET for docstrings of category tables.
1357 * category.h (CATEGORY_DOCSTRING): Use AREF.
1358 (SET_CATEGORY_DOCSTRING): Use ASET.
1359 * category.c (Fdefine_category): Use SET_CATEGORY_DOCSTRING.
1360
e83064be
DA
13612012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
1362
1363 Inline setter functions for hash table members.
1364 * lisp.h (set_hash_key, set_hash_value, set_hash_next)
1365 (set_hash_hash, set_hash_index): Rename with _slot suffix.
1366 (set_hash_key_and_value, set_hash_index, set_hash_next)
1367 (set_hash_hash): New functions.
1368 * charset.c, fns.c: Adjust users.
1369
4ce60d2e
DA
13702012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
1371
1372 Inline getter and setter functions for per-buffer values.
1373 * buffer.h (per_buffer_default, set_per_buffer_default)
1374 (per_buffer_value, set_per_buffer_value): New functions.
1375 (PER_BUFFER_VALUE, PER_BUFFER_DEFAULT): Remove.
1376 * buffer.c, data.c: Adjust users.
1377
c06c9690
JB
13782012-08-20 Juanma Barranquero <lekktu@gmail.com>
1379
1380 * makefile.w32-in ($(BLD)/vm-limit.$(O)): Update dependencies.
1381
32bd4250
PE
13822012-08-19 Paul Eggert <eggert@cs.ucla.edu>
1383
bad03192 1384 Rely on <config.h> + <unistd.h> to declare 'environ',
b69a6d22
PE
1385 as gnulib does this if the system doesn't.
1386 * callproc.c, editfns.c, process.c (environ) [!USE_CRT_DLL]:
72279493
EZ
1387 Remove declaration. MS-Windows declares it on stdlib.h which is
1388 included by conf_post.h.
b69a6d22
PE
1389 * emacs.c (environ) [DOUG_LEA_MALLOC]:
1390 * vm-limit.c (environ) [ORDINARY_LINK]: Remove decl.
1391 * vm-limit.c: Include <unistd.h>, for 'environ'.
1392
22d7feb2
PE
1393 * unexaix.c, unexcoff.c: Include "mem-limits.h".
1394 (start_of_data): Remove decl; mem-limits.h provides it.
1395
32bd4250
PE
1396 * xdisp.c (handle_invisible_prop): Make it a bit faster
1397 and avoid a gcc -Wmaybe-uninitialized diagnostic.
1398
450809af
CY
13992012-08-19 Chong Yidong <cyd@gnu.org>
1400
1401 * xdisp.c (handle_invisible_prop): Fix ellipses at overlay string
1402 ends (Bug#3874).
1403
9e677988
AS
14042012-08-19 Andreas Schwab <schwab@linux-m68k.org>
1405
6b1319ce
AS
1406 * .gdbinit: Use call instead of set when calling a function in the
1407 inferior.
1408
9e677988
AS
1409 * data.c (set_internal): Don't use set_blv_found.
1410 (Fkill_local_variable): Likewise.
1411
d7191076
AA
14122012-08-18 Alp Aker <alp.tekin.aker@gmail.com>
1413
1414 * nsfont.m (ns_ascii_average_width): Ensure the string
1415 ascii_printable is initialized with a null-terminated character
1416 array. Otherwise, it can contain undesired extra characters.
1417
e757f1c6
PE
14182012-08-18 Paul Eggert <eggert@cs.ucla.edu>
1419
1420 port new setting code to Sun C 5.8 2005/10/13
1421 * chartab.c, lisp.h (char_table_set, char_table_set_range):
1422 Return void, not Lisp_Object. Otherwise, the compiler
1423 complains about (A?B:C) where B is void and C is Lisp_Object
1424 when compiling CHAR_TABLE_SET, due to the recent change to
1425 the API of sub_char_table_set_contents.
1426
a999ce26
CY
14272012-08-18 Chong Yidong <cyd@gnu.org>
1428
1429 * xdisp.c (handle_invisible_prop): Obey TEXT_PROP_MEANS_INVISIBLE
1430 for the string case (Bug#3874).
1431
3f22b86f
PE
14322012-08-18 Paul Eggert <eggert@cs.ucla.edu>
1433
39eb03f1
PE
1434 * buffer.h (BSET): Remove (Bug#12215).
1435 Replace all uses with calls to new setter functions.
1436 (bset_bidi_paragraph_direction, bset_case_canon_table)
1437 (bset_case_eqv_table, bset_directory, bset_display_count)
1438 (bset_display_time, bset_downcase_table)
1439 (bset_enable_multibyte_characters, bset_filename, bset_keymap)
1440 (bset_last_selected_window, bset_local_var_alist)
1441 (bset_mark_active, bset_point_before_scroll, bset_read_only)
1442 (bset_truncate_lines, bset_undo_list, bset_upcase_table)
1443 (bset_width_table):
1444 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
1445 (bset_auto_fill_function, bset_auto_save_file_format)
1446 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
1447 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
1448 (bset_cache_long_line_scans, bset_case_fold_search)
1449 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
1450 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
1451 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
1452 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
1453 (bset_header_line_format, bset_indicate_buffer_boundaries)
1454 (bset_indicate_empty_lines, bset_invisibility_spec)
1455 (bset_left_fringe_width, bset_major_mode, bset_mark)
1456 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
1457 (bset_name, bset_overwrite_mode, bset_pt_marker)
1458 (bset_right_fringe_width, bset_save_length)
1459 (bset_scroll_bar_width, bset_scroll_down_aggressively)
1460 (bset_scroll_up_aggressively, bset_selective_display)
1461 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
1462 (bset_word_wrap, bset_zv_marker):
1463 * category.c (bset_category_table):
1464 * syntax.c (bset_syntax_table):
1465 New setter functions.
1466
6a09a33b
PE
1467 * process.h (PSET): Remove (Bug#12215).
1468 Replace all uses with calls to new setter functions.
1469 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1470 (PROCESS_INLINE): New macro.
1471 (pset_childp): New setter function.
1472 (pset_gnutls_cred_type) [HAVE_GNUTLS]: New setter function.
1473 * process.c (PROCESS_INLINE):
1474 Define to EXTERN_INLINE, so that the corresponding functions
1475 are compiled into code.
1476 (pset_buffer, pset_command, pset_decode_coding_system)
1477 (pset_decoding_buf, pset_encode_coding_system)
1478 (pset_encoding_buf, pset_filter, pset_log, pset_mark, pset_name)
1479 (pset_plist, pset_sentinel, pset_status, pset_tty_name)
1480 (pset_type, pset_write_queue): New setter functions.
1481
e8c17b81
PE
1482 * window.h (WSET): Remove (Bug#12215).
1483 Replace all uses with calls to new setter functions.
1484 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1485 (WINDOW_INLINE): New macro.
1486 (wset_buffer, wset_frame, wset_left_col, wset_next, wset_prev)
1487 (wset_redisplay_end_trigger, wset_top_line, wset_total_cols)
1488 (wset_total_lines, wset_vertical_scroll_bar)
1489 (wset_window_end_pos, wset_window_end_valid)
1490 (wset_window_end_vpos): New setter functions.
1491 * window.c (WINDOW_INLINE):
1492 Define to EXTERN_INLINE, so that the corresponding functions
1493 are compiled into code.
1494 (wset_combination_limit, wset_dedicated, wset_display_table)
1495 (wset_hchild, wset_left_fringe_width, wset_left_margin_cols)
1496 (wset_new_normal, wset_new_total, wset_next_buffers)
1497 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
1498 (wset_prev_buffers, wset_right_fringe_width)
1499 (wset_right_margin_cols, wset_scroll_bar_width, wset_start)
1500 (wset_temslot, wset_vchild, wset_vertical_scroll_bar_type)
1501 (wset_window_parameters):
1502 * xdisp.c (wset_base_line_number, wset_base_line_pos)
1503 (wset_column_number_displayed, wset_region_showing):
1504 New setter functions.
1505
3f22b86f
PE
1506 * termhooks.h (TSET): Remove (Bug#12215).
1507 Replace all uses with calls to new setter functions.
1508 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1509 (TERMHOOKS_INLINE): New macro.
1510 (tset_charset_list, tset_selection_alist): New setter functions.
1511 * terminal.c (TERMHOOKS_INLINE):
1512 Define to EXTERN_INLINE, so that the corresponding functions
1513 are compiled into code.
1514 (tset_param_alist): New setter function.
1515
742af32f
PE
15162012-08-17 Paul Eggert <eggert@cs.ucla.edu>
1517
15dbb4d6
PE
1518 * keyboard.h (KSET): Remove (Bug#12215).
1519 Replace all uses with calls to new setter functions.
1520 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1521 (KEYBOARD_INLINE): New macro.
1522 (kset_default_minibuffer_frame, kset_defining_kbd_macro)
1523 (kset_input_decode_map, kset_last_command, kset_last_kbd_macro)
1524 (kset_prefix_arg, kset_system_key_alist, kset_window_system):
1525 New setter functions.
1526 * keyboard.c (KEYBOARD_INLINE):
1527 Define to EXTERN_INLINE, so that the corresponding functions
1528 are compiled into code.
1529 (kset_echo_string, kset_kbd_queue)
1530 (kset_keyboard_translate_table, kset_last_prefix_arg)
1531 (kset_last_repeatable_command, kset_local_function_key_map)
1532 (kset_overriding_terminal_local_map, kset_real_last_command)
1533 (kset_system_key_syms): New setter functions.
1534
f00af5b1
PE
1535 * frame.h (FSET): Remove (Bug#12215).
1536 Replace all uses with calls to new setter functions.
1537 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1538 (FRAME_INLINE): New macro.
1539 (fset_buffer_list, fset_buried_buffer_list, fset_condemned_scroll_bars)
1540 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
1541 (fset_face_alist, fset_focus_frame, fset_icon_name, fset_menu_bar_items)
1542 (fset_menu_bar_vector, fset_menu_bar_window, fset_name)
1543 (fset_param_alist, fset_root_window, fset_scroll_bars)
1544 (fset_selected_window, fset_title, fset_tool_bar_items)
1545 (fset_tool_bar_position, fset_tool_bar_window): New functions.
1546 * frame.c (FRAME_INLINE):
1547 Define to EXTERN_INLINE, so that the corresponding functions
1548 are compiled into code.
1549 (fset_buffer_predicate, fset_minibuffer_window): New setter functions.
1550
0c94c8d6
PE
1551 A few more naming-convention fixes for getters and setters.
1552 * buffer.c (set_buffer_overlays_before): Move here from buffer.h,
1553 and rename from buffer_overlays_set_before.
1554 (set_buffer_overlays_after): Move here from buffer.h, and rename
1555 from buffer_overlays_set_after.
1556 * buffer.h (buffer_intervals): Rename from buffer_get_intervals.
1557 All uses changed.
1558 (set_buffer_intervals): Rename from buffer_set_intervals.
1559 * intervals.c (set_interval_object): Move here from intervals.h,
1560 and rename from interval_set_object.
1561 (set_interval_left): Move here from intervals.h, and rename from
1562 interval_set_left.
1563 (set_interval_right): Move here from intervals.h, and rename from
1564 interval_set_right.
1565 (copy_interval_parent): Move here from intervals.h, and rename from
1566 interval_copy_parent.
1567 * intervals.h (set_interval_parent): Rename from interval_set_parent.
1568 (set_interval_plist): Rename from interval_set_plist.
1569 Return void, not Lisp_Object, since no caller uses the result.
1570 * lisp.h (string_intervals): Rename from string_get_intervals.
1571 (set_string_intervals): Rename from string_set_intervals.
1572
34dabdb7
PE
1573 * lisp.h (set_char_table_extras): Rename from char_table_set_extras.
1574 (set_char_table_contents): Rename from char_table_set_contents.
0b390a9d 1575 (set_sub_char_table_contents): Rename from sub_char_table_set_contents.
34dabdb7
PE
1576 All uses changed. See the end of
1577 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00549.html>.
1578
742af32f
PE
1579 * lisp.h (CSET): Remove (Bug#12215).
1580 (set_char_table_ascii, set_char_table_defalt, set_char_table_parent)
1581 (set_char_table_purpose): New functions,
1582 replacing CSET. All uses changed. For example, replace
1583 "CSET (XCHAR_TABLE (char_table), parent, parent);" with
c24eb18a 1584 "set_char_table_parent (char_table, parent);".
742af32f
PE
1585 The old version was confusing because it used the same name
1586 'parent' for two different things.
1587
a04e2c62
DA
15882012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
1589
1590 Functions to get and set Lisp_Object fields of buffer-local variables.
1591 * lisp.h (blv_found, set_blv_found, blv_value, set_blv_value)
1592 (set_blv_where, set_blv_defcell, set_blv_valcell): New functions.
1593 (BLV_FOUND, SET_BLV_FOUND, BLV_VALUE, SET_BLV_VALUE): Remove.
1594 * data.c, eval.c, frame.c: Adjust users.
1595
383dcbf9
CY
15962012-08-17 Chong Yidong <cyd@gnu.org>
1597
1598 * xfaces.c (merge_face_vectors): If the target font specfies a
1599 font spec, make the font's attributes take precedence over
1600 directly-specified attributes.
1601 (merge_face_ref): Recognize :font.
1602
44386687
DA
16032012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
1604
1605 Do not use memcpy for copying intervals.
1606 * intervals.c (reproduce_interval): New function.
1607 (reproduce_tree, reproduce_tree_obj): Use it.
1608 (reproduce_tree_obj): Remove prototype.
1609
927c7216
PE
16102012-08-17 Paul Eggert <eggert@cs.ucla.edu>
1611
1612 * lisp.h (duration_to_sec_usec): Remove unused decl.
1613
93044f7b
AA
16142012-08-17 Alp Aker <alp.tekin.aker@gmail.com>
1615
1616 * nsfont.m (ns_ascii_average_width): Send initWithFormat selector
1617 to an allocated instance of NSString, not to the class itself.
1618
9851e4a5
JB
16192012-08-17 Juanma Barranquero <lekktu@gmail.com>
1620
1621 * makefile.w32-in (C_CTYPE_H): New macro.
1622 (LISP_H, $(BLD)/ccl.$(O), $(BLD)/doc.$(O), $(BLD)/w32console.$(O)):
1623 ($(BLD)/fontset.$(O), $(BLD)/frame.$(O), $(BLD)/composite.$(O)):
1624 ($(BLD)/sysdep.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
1625
620f13b0
PE
16262012-08-16 Paul Eggert <eggert@cs.ucla.edu>
1627
1628 Use ASCII tests for character types.
1629 * category.c, dispnew.c, doprnt.c, editfns.c, syntax.c, term.c:
1630 * xfns.c, xterm.c:
1631 Don't include <ctype.h>; was not needed.
1632 * charset.c, doc.c, fileio.c, font.c, frame.c, gtkutil.c, image.c:
1633 * sysdep.c, xfaces.c:
1634 Include <c-ctype.h> instead of <ctype.h>.
1635 * nsterm.m: Include <c-ctype.h>.
1636 * charset.c (read_hex):
1637 * doc.c (Fsnarf_documentation):
1638 * fileio.c (IS_DRIVE) [WINDOWSNT]:
1639 (DRIVE_LETTER) [DOS_NT]:
1640 (Ffile_name_directory, Fexpand_file_name)
1641 (Fsubstitute_in_file_name):
1642 * font.c (font_parse_xlfd, font_parse_fcname):
1643 * frame.c (x_set_font_backend):
1644 * gtkutil.c (xg_get_font):
1645 * image.c (xbm_scan, xpm_scan, pbm_scan_number):
1646 * nsimage.m (hexchar):
1647 * nsterm.m (ns_xlfd_to_fontname):
1648 * sysdep.c (system_process_attributes):
1649 * xfaces.c (hash_string_case_insensitive):
1650 Use C-locale tests instead of locale-specific tests for character
1651 types, since we want the ASCII interpretation here, not the
1652 interpretation suitable for whatever happens to be the current locale.
1653
52162052
MR
16542012-08-16 Martin Rudalics <rudalics@gmx.at>
1655
1656 Consistently check windows for validity/liveness
1657 (Bug#11984, Bug#12025, Bug#12026).
1658 * lisp.h (CHECK_VALID_WINDOW): New macro.
1659 * window.c (decode_window): Rename to decode_live_window.
1660 (decode_valid_window, Fwindow_valid_p): New functions.
1661 (Fwindow_frame, Fframe_root_window, Fwindow_minibuffer_p)
1662 (Fframe_first_window, Fframe_selected_window, Fwindow_parent)
1663 (Fwindow_top_child, Fwindow_left_child, Fwindow_next_sibling)
1664 (Fwindow_prev_sibling, Fwindow_combination_limit)
1665 (Fset_window_combination_limit, Fwindow_use_time)
1666 (Fwindow_total_height, Fwindow_total_width, Fwindow_new_total)
1667 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_left_column)
1668 (Fwindow_top_line, Fwindow_body_height, Fwindow_body_width)
1669 (Fwindow_hscroll, Fset_window_hscroll)
1670 (Fwindow_redisplay_end_trigger)
1671 (Fset_window_redisplay_end_trigger, Fwindow_edges)
1672 (Fwindow_pixel_edges, Fwindow_absolute_pixel_edges)
1673 (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1674 (Fcoordinates_in_window_p, Fwindow_point, Fwindow_start)
1675 (Fwindow_end, Fset_window_point, Fset_window_start)
1676 (Fpos_visible_in_window_p, Fwindow_line_height)
1677 (Fwindow_dedicated_p, Fset_window_dedicated_p)
1678 (Fwindow_prev_buffers, Fset_window_prev_buffers)
1679 (Fwindow_next_buffers, Fwindow_parameters, Fwindow_parameter)
1680 (Fset_window_parameter, Fwindow_display_table)
1681 (Fset_window_display_table, Fdelete_other_windows_internal)
1682 (Fset_window_buffer, Fset_window_new_total)
1683 (Fset_window_new_normal, Fdelete_window_internal)
1684 (Fwindow_text_height, Fset_window_margins, Fwindow_margins)
1685 (Fset_window_fringes, Fwindow_fringes, Fset_window_scroll_bars)
1686 (Fwindow_scroll_bars): Check whether argument window is a valid or
1687 live window. Update doc-strings.
1688 (syms_of_window): New symbol Qwindow_valid_p.
1689 * keyboard.c (Fposn_at_x_y): Check whether argument
1690 frame_or_window denotes a valid window.
1691
2751c80f
DA
16922012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
1693
1694 Fix previous char table change.
1695 * lisp.h (CHAR_TABLE_SET): Use sub_char_table_set_contents.
1696 * chartab.c (optimize_sub_char_table): Likewise.
1697
032a42c8
CY
16982012-08-16 Chong Yidong <cyd@gnu.org>
1699
a2d19368
CY
1700 * gtkutil.c (xg_get_font): Demand an Xft font (Bug#3228).
1701
032a42c8
CY
1702 * xfont.c (xfont_open):
1703 * xftfont.c (xftfont_open): Set the font's max_width field.
1704
1705 * nsfont.m (nsfont_open): Similar to the Xft backend, set
1706 min_width to space_width and average_width to the average over
1707 printable ASCII characters.
1708 (ns_char_width): Code cleanup.
1709 (ns_ascii_average_width): New utility function.
1710
1711 * font.h (struct font): Update comments.
1712
a098c930
DA
17132012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
1714
032a42c8 1715 Simple interface to set Lisp_Object fields of character tables.
a098c930
DA
1716 * lisp.h (CSET): New macro.
1717 (char_table_set_extras, char_table_set_contents)
1718 (sub_char_table_set_contents): New function.
1719 * casetab.c, category.c, chartab.c, fns.c, fontset.c, search.c:
1720 * syntax.c: Adjust users.
1721
8be3a09c
SM
17222012-08-16 Stefan Monnier <monnier@iro.umontreal.ca>
1723
1724 * eval.c (eval_sub): Bind lexical-binding.
1725 * lread.c (Qlexical_binding): Make non-static.
1726
ac4845a6
JD
17272012-08-15 Jan Djärv <jan.h.d@swipnet.se>
1728
ddee6515
JD
1729 * nsmenu.m (popupSession): Remove.
1730 (pop_down_menu): Remove endModalSession.
1731 (timeout_handler:): New method.
1732 (runDialogAt:): Get next timeout. Start a NSTimer with that timeout.
1733 Call runModalForWindow. Check timer_fired when it returns.
1734 If not set, cancel timer and break out of loop.
1735 Otherwise loop again, with a new timeout.
1736
1737 * nsterm.m: Include fcntl.h if present.
1738 (fd_entry, t_readfds, inNsSelect): Remove.
1739 (select_writefds, select_valid, select_timeout, selfds)
1740 (select_mutex, apploopnr): Add.
1741 (EV_TRAILER): Call kbd_buffer_store_event_hold only if q_event_ptr.
1742 Otherwise call kbd_buffer_store_event.
1743 (ns_send_appdefined): Remove release of fd_entry.
1744 (ns_read_socket): Always send appdefined. Remove inNsSelect check.
1745 Increment and decrement apploopnr.
1746 (ns_select): If no file descriptors, just do a NSTimer.
1747 Otherwise copy read/write masks and start select thread (fd_handler).
1748 Start main loop and wait for application defined event.
1749 Inform select thread to stop selecting after main loop is exited.
1750 (ns_term_init): Create selfds pipe and set non-blocking.
1751 Initialize select_mutex. Start the select thread (fd_handler).
1752 (fd_handler:): Loop forever, wait for info from the main thread
1753 to either start or stop selecting. When select returns, send
1754 and appdefined event.
1755 (sendScrollEventAtLoc:fromEvent:): Check if q_event_ptr is set.
1756 If not call kbd_buffer_store_event.
1757
1758 * nsterm.h (EmacsApp): fd_handler takes id argument.
1759 (EmacsDialogPanel): Add timer_fired and timeout_handler.
1760
ac4845a6
JD
1761 * gtkutil.c (xg_mark_data): Use FRAME_X_P.
1762
eb424fe3
EZ
17632012-08-15 Eli Zaretskii <eliz@gnu.org>
1764
1765 * region-cache.c (move_cache_gap): Update gap_len using the actual
1766 growth of the boundaries array. Do not change cache_len.
1767 (Bug#12196)
1768
4e6a86c6
DA
17692012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1770
1771 Generalize and cleanup font subsystem checks.
1772 * font.h (FONT_DEBUG, font_assert): Remove.
8be3a09c
SM
1773 * font.c, fontset.c, w32font.c, xfont.c, xftfont.c:
1774 Change font_assert to eassert. Use eassert where appropriate.
4e6a86c6 1775
5bf192ca
DA
17762012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1777
1778 * gtkutil.c (xg_get_font): Use pango_units_to_double.
1779
f2045622
CY
17802012-08-15 Chong Yidong <cyd@gnu.org>
1781
8be3a09c
SM
1782 * gtkutil.c (xg_get_font): Rename from xg_get_font_name.
1783 When using the new font chooser, use gtk_font_chooser_get_font_desc to
1784 extract the font descriptor instead of just the font name.
1785 In that case, return a font spec instead of a string.
f2045622
CY
1786 (x_last_font_name): Move to this file from xfns.c.
1787
1788 * xfns.c (Fx_select_font): The return value can also be a font
1789 spec. Move x_last_font_name management to gtkutil.c.
1790
1791 * xfaces.c: Make font weight and style symbols non-static.
1792
7f6feb56
SM
17932012-08-15 Stefan Monnier <monnier@iro.umontreal.ca>
1794
1795 * minibuf.c (read_minibuf): Ignore caller's inhibit-read-only
1796 (bug#12117).
1797
fecbd8ff
SM
17982012-08-14 Stefan Monnier <monnier@iro.umontreal.ca>
1799
1800 * alloc.c (Fgarbage_collect): Use plural form consistently.
1801
9b8d5165
EZ
18022012-08-14 Eli Zaretskii <eliz@gnu.org>
1803
1804 * keyboard.c (command_loop_1): Reset ignore_mouse_drag_p flag each
1805 iteration through the command loop. Fixes a problem whereby mouse
1806 movements are ignored until the first mouse click.
1807
f5d9e83a
PE
18082012-08-14 Paul Eggert <eggert@cs.ucla.edu>
1809
1810 Use bool, not int, for Lisp booleans.
1811 This is more natural, and on my platform (GCC 4.7.1 x86-64) it
1812 makes Emacs a bit smaller and presumably a bit faster.
1813 * lisp.h: Include <stdbool.h>.
1814 (struct Lisp_Boolfwd, defvar_bool):
1815 * lread.c (defvar_bool): Use bool, not int, for Lisp booleans.
1816 * regex.c [!emacs]: Include <stdbool.h>.
1817 (false, true): Remove; <stdbool.h> does this for us now.
1818
55802e4a
CY
18192012-08-14 Chong Yidong <cyd@gnu.org>
1820
4abcdac8
CY
1821 * character.c (Fcharacterp): Doc fix (Bug#12076).
1822
1823 * data.c (Findirect_variable): Doc fix (Bug#11040).
1824
55802e4a
CY
1825 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
1826
1827 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 1828 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 1829
8e99d072
BR
18302012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
1831
1832 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
1833 (bug#12022).
1834
08908aca
MR
18352012-08-14 Martin Rudalics <rudalics@gmx.at>
1836
1837 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
1838 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
1839 * minibuf.c (choose_minibuf_frame, read_minibuf):
1840 * w32fns.c (x_create_tip_frame):
1841 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
1842 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
1843
56120d6f
PE
18442012-08-14 Paul Eggert <eggert@cs.ucla.edu>
1845
1846 * intervals.c (offset_intervals): Remove obsolete comment.
1847
67b77c0b
AS
18482012-08-14 Andreas Schwab <schwab@linux-m68k.org>
1849
1850 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
1851
f48b82fd
GR
18522012-08-14 Gergely Risko <gergely@risko.hu>
1853
1854 * coding.c (decode_coding): Record buffer modification before
1855 disabling undo_list (Bug#11773).
1856
fd318b54
DA
18572012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1858
1859 Revert and cleanup some recent overlay changes.
1860 * buffer.h (enum overlay_type): Remove.
1861 (buffer_get_overlays, buffer_set_overlays): Likewise.
1862 (buffer_set_overlays_before, buffer_set_overlays_after):
1863 New function. Adjust users.
1864 (unchain_both): Add eassert.
1865
41a62dd9
DA
18662012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1867
1868 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
1869
5884c324
PE
18702012-08-14 Paul Eggert <eggert@cs.ucla.edu>
1871
1872 * gtkutil.c (xg_mark_data): Don't assume C99.
1873
ca06f160
JD
18742012-08-13 Jan Djärv <jan.h.d@swipnet.se>
1875
1876 * gtkutil.c (xg_frame_tb_info): New struct.
1877 (TB_INFO_KEY): New define.
1878 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
1879 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
1880 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
1881 if not present.
1882 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
1883 is up to date. Otherwise store new data.
1884 (free_frame_tool_bar): Free xg_frame_tb_info if present.
1885
7864a3f7
DA
18862012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1887
1888 Use KSET for write access to Lisp_Object members of struct kboard.
1889 * keyboard.h (KSET): New macro.
1890 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
1891 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
1892 * xterm.c: Adjust users.
1893
4c31be61
DA
18942012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1895
1896 Use BSET for write access to Lisp_Object members of struct buffer.
1897 * buffer.h (BSET): New macro.
1898 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
1899 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
1900 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
1901 * window.c, xdisp.c, xfns.c: Adjust users.
1902
14ae4239
BT
19032012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
1904
1905 * lread.c (syms_of_lread): Initialize Vlexical_binding.
1906
32bcadb4
JD
19072012-08-11 Jan Djärv <jan.h.d@swipnet.se>
1908
3d29b2ce
JD
1909 * nsterm.m (not_in_argv): New function.
1910 (application:openFile, application:openTempFile:):
1911 (application:openFileWithoutUI:, application:openFiles:): Open file
1912 if not_in_argv returns non-zero (bug#12171).
1913
32bcadb4 1914 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
1915 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
1916 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
1917 (xg_get_font_name): Use those functions/macros here.
1918 Reported by Frans Oilinki <moilinki@gmail.com>.
1919
9ff9402d 19202012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
1921
1922 * unexmacosx.c (copy_data_segment): Copy initialized data in
1923 statically linked libraries from input file rather than memory.
1924
db74a5fc
YM
1925 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
1926 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
1927 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
1928
25e65510
GM
19292012-08-10 Glenn Morris <rgm@gnu.org>
1930
1931 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
1932 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
1933
7961135c
DA
19342012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1935
1936 Fix last change to allow compilation with low optimization levels.
1937 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
1938 Reported by Jan Djärv <jan.h.d@swipnet.se>.
1939
42b3a444
DA
19402012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1941
1942 Use common inline syntax in intervals.h.
1943 * intervals.h (INTERVALS_INLINE): New macro.
1944 Change all users from LISP_INLINE.
1945
9fb0c957
DA
19462012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1947
1948 Define Qnone once for all platforms.
1949 * frame.c (Qnone): Define here.
1950 (syms_of_frame): DEFSYM it.
1951 * lisp.h (Qnone): New declaration.
1952 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
1953 * xfns.c: Remove duplication. Adjust users.
1954
65e8ee52
DA
19552012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1956
1957 Remove unused macros from intervals.h.
1958 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
1959 * intervals.c: Adjust comment.
1960
9b855fd6
EZ
19612012-08-10 Eli Zaretskii <eliz@gnu.org>
1962
1963 * w32fns.c <w32_unicode_gui>: New static variable.
1964 (globals_of_w32fns): Initialize it according to os_subtype.
1965 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
1966 testing os_subtype.
1967
39cb9e56 19682012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
1969 Eli Zaretskii <eliz@gnu.org>
1970
1971 Fix bug #10299 with Unicode characters sent by customized
1972 keyboards created by MSKLC.
1973 * w32fns.c (INIT_WINDOW_CLASS): New macro.
1974 (w32_init_class): Use it to initialize the Emacs class with either
1975 ANSI or Unicode API calls.
1976 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
1977 later.
1978 (w32_wnd_proc): If the character code sent by WM_CHAR or
1979 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
1980 original message. Call DefWindowProcW on NT and later.
1981
9374581a
GM
19822012-08-10 Glenn Morris <rgm@gnu.org>
1983
4b94e8cf
GM
1984 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
1985
9374581a
GM
1986 * lisp.h (DIRECTORY_SEP): Let configure set it.
1987
a2752828
DA
19882012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
1989
1990 Use TSET for write access to Lisp_Object slots of struct terminal.
1991 * termhooks.h (TSET): New macro.
1992 * coding.c, terminal.c, xselect.c: Adjust users.
1993
cc92c454
SM
19942012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
1995
1996 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
1997 the failing expression, include them in the error message.
1998 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
1999 * lisp.h (internal_condition_case_n): Update declaration.
2000
4cb3e6b3
DA
20012012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2002
2003 Inline functions to examine and change buffer overlays.
2004 * buffer.c (unchain_both): New function.
2005 * buffer.h (buffer_get_overlays, buffer_set_overlays):
2006 (buffer_has_overlays): New function.
2007 (enum overlay_type): New enum.
2008 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
2009 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
2010
8707c1e5
DA
20112012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2012
2013 Inline functions to examine and change buffer intervals.
2014 * alloc.c (mark_interval_tree): Remove.
2015 (MARK_INTERVAL_TREE): Simplify.
2016 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
2017 * intervals.c (buffer_balance_intervals): New function.
2018 (graft_intervals_into_buffer): Adjust indentation.
2019 (set_intervals_multibyte): Simplify.
2020 * buffer.h (BUF_INTERVALS): Remove.
2021 (buffer_get_intervals, buffer_set_intervals): New function.
2022 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
2023 * intervals.c, textprop.c: Adjust users.
2024
ad8c997f
DA
20252012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2026
2027 Inline functions to examine and change string intervals.
2028 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
2029 (string_get_intervals, string_set_intervals): New function.
2030 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
2031 * lread.c, print.c, textprop.c: Adjust users.
2032
32ac3a6b
GM
20332012-08-08 Glenn Morris <rgm@gnu.org>
2034
2035 * lisp.mk (lisp): Remove language/persian.elc.
2036
77c7bcb1
DA
20372012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2038
2039 Cleanup intervals.
2040 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
2041 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
2042 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
2043 Adjust comment. Move under #if 0.
77c7bcb1
DA
2044 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
2045 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
2046
9c08a8d4
DA
20472012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2048
2049 Check total length of intervals with eassert.
2050 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
2051 * intervals.c: Change all users to eassert.
2052
26d16b35
EZ
20532012-08-07 Eli Zaretskii <eliz@gnu.org>
2054
14ae4239
BT
2055 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
2056 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
2057 INTERNAL_FIELD in Lisp_Cons.
2058
c644523b
DA
20592012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2060
2061 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
2062 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
2063 name since all xname users are fixed long time ago. Do not
2064 use INTERNAL_FIELD.
2065 (set_symbol_name, set_symbol_function, set_symbol_plist):
2066 (set_symbol_next, set_overlay_plist): New function.
2067 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
2068 (struct Lisp_Overlay): Likewise.
2069 (CVAR, MVAR, SVAR): Remove.
2070 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
2071 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
2072 * xterm.c: Adjust users.
2073 * .gdbinit: Change to use name field of struct Lisp_Symbol
2074 where appropriate.
2075
6a3d20cc
DA
20762012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2077
2078 Basic functions to set Lisp_Object and pointer slots of intervals.
2079 * intervals.h (interval_set_parent, interval_set_object):
2080 (interval_set_left, interval_set_right, interval_set_plist):
2081 (interval_copy_parent): New function.
2082 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
2083 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
2084 Adjust indentation.
6a3d20cc
DA
2085 (INTERVAL_SIZE): Remove. Adjust users.
2086 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
2087
4d2b044c
DA
20882012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2089
2090 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
2091 * process.h (PGET): Remove.
2092 (struct Lisp_Process): Do not use INTERNAL_FIELD.
2093 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
2094
d3d50620
DA
20952012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2096
2097 Drop WGET and revert read access to Lisp_Objects slots of struct window.
2098 * window.h (WGET): Remove.
2099 (struct window): Do not use INTERNAL_FIELD.
2100 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
2101 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
2102 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
2103 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
2104 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
2105 Adjust users.
2106
d10a51dc
CY
21072012-08-07 Chong Yidong <cyd@gnu.org>
2108
2109 * window.c (Fwindow_edges, Fwindow_pixel_edges)
2110 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
2111 (Fdelete_window_internal): Signal an error if the window is not on
2112 a live frame (Bug#12025).
2113
e69b0960
DA
21142012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2115
2116 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
2117 * frame.h (FGET): Remove.
2118 (struct frame): Do not use INTERNAL_FIELD.
2119 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
2120 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
2121 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
2122 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
2123
25a20a3a
JB
21242012-08-06 Juanma Barranquero <lekktu@gmail.com>
2125
2126 * w32.c: Silence compiler warnings.
2127 (map_w32_filename): Remove unused variable `is_fat'.
2128 (chase_symlinks): Add parentheses around expression.
2129
1c6f11f4
GM
21302012-08-06 Glenn Morris <rgm@gnu.org>
2131
1db4583a
GM
2132 * sysdep.c: Respect BROKEN_GETWD.
2133
1c6f11f4
GM
2134 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
2135 Let configure handle it.
2136 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
2137
2b90362b
DA
21382012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2139
2140 Use GCALIGNMENT where appropriate.
2141 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
2142 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
2143 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
2144
5f50daf2
EZ
21452012-08-06 Eli Zaretskii <eliz@gnu.org>
2146
14ae4239
BT
2147 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
2148 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 2149
cbcc7007
SM
21502012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
2151
2152 * buffer.h (struct buffer): Revert `indirections' to a simple int;
2153 that should be sufficient for everyone.
2154
4d365fa4
JD
21552012-08-06 Jan Djärv <jan.h.d@swipnet.se>
2156
2157 * keyboard.c (timer_check_2): Add break so timer_check returns next
2158 timeout.
2159
dd86bd82
DA
21602012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2161
2162 Fix Windows build errors introduced after converting to WGET and WSET.
2163 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
2164 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
2165
054e1668
JD
21662012-08-06 Jan Djärv <jan.h.d@swipnet.se>
2167
2168 * nsterm.m (ns_frame_rehighlight): Use FSET.
2169
2170 * nsmenu.m (ns_update_menubar): Use FSET.
2171
21238f11
DA
21722012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2173
2174 Separate read and write access to Lisp_Object slots of Lisp_Process.
2175 * process.h (PGET, PSET): New macros similar to AREF and ASET.
2176 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
2177
077288cf
DA
21782012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2179
2180 Separate read and write access to Lisp_Object slots of struct window.
2181 * window.h (WGET, WSET): New macros similar to AREF and ASET.
2182 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
2183 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
2184 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
2185 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
2186 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
2187 Adjust users.
2188
71688bd7
DA
21892012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2190
2191 Fix Windows build errors introduced after converting to FGET and FSET.
2192 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
2193 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
2194 (w32_judge_scroll_bars): Change to use FSET.
2195 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
2196
f99bac93
DA
21972012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2198
2199 Fix replacement typo.
2200 * window.c (replace_window): Set root_window instead of
2201 selected_window. This fixes a total window subsystem
2202 malfunction reported by Bastien Guerry <bzg@gnu.org>.
2203
8c2a0f2d
GM
22042012-08-06 Glenn Morris <rgm@gnu.org>
2205
2206 * lisp.mk (lisp): Add language/persian.elc.
2207
edd74c35
DA
22082012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2209
2210 Separate read and write access to Lisp_Object slots of struct frame.
2211 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
2212 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
2213 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
2214 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
2215 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
2216
8671676c
AS
22172012-08-05 Andreas Schwab <schwab@linux-m68k.org>
2218
2219 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
2220
663e2b3f
DA
22212012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
2222
2223 Generalize common compile-time constants.
2224 * lisp.h (header_size, bool_header_size, word_size): Now here.
2225 (struct Lisp_Vector): Add comment.
2226 (struct Lisp_Bool_Vector): Move up to define handy constants.
2227 (VECSIZE, PSEUDOVECSIZE): Simplify.
2228 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
2229 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
2230 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
2231 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
2232 * xfont.c, xmenu.c: Use word_size where appropriate.
2233
d32e47af
LM
22342012-08-05 Lawrence Mitchell <wence@gmx.li>
2235
2236 * search.c (Freplace_match): Treat \? in the replacement text
2237 literally (Bug#8161).
2238
e5d9c0d1
CY
22392012-08-05 Chong Yidong <cyd@gnu.org>
2240
2241 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
2242 * frame.c (Vdelete_frame_functions):
2243 * emacs.c (Vkill_emacs_hook): Doc fix.
2244
8da0576b
EZ
22452012-08-04 Eli Zaretskii <eliz@gnu.org>
2246
2247 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
2248 --with-x-toolkit=no builds.
2249 Reported by Carsten Mattner <carstenmattner@gmail.com>.
2250
02676e5d
CY
22512012-08-04 Chong Yidong <cyd@gnu.org>
2252
2253 * syntax.c (Fmodify_syntax_entry): Doc fix.
2254
97147da9
EZ
22552012-08-04 Eli Zaretskii <eliz@gnu.org>
2256
76151e2c
EZ
2257 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
2258 * w32.c (init_environment): Change the default values of many
2259 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
2260 them into environment when they were not already defined.
2261 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 2262 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
2263 (check_windows_init_file): Now external, not static.
2264 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
2265 called when Vload_path is already set up.
2266
2267 * w32.h (check_windows_init_file): Add prototype.
2268
2269 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
2270 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
2271 compatibility with Posix platforms.
2272 (main): Move the call to check_windows_init_file to here from
2273 w32.c.
2274 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
2275 any, in the DEFALT argument into the root of the Emacs build or
2276 installation tree, as appropriate.
2277
2278 * callproc.c (init_callproc_1): Call decode_env_path instead of
2279 doing its equivalent by hand.
2280 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
2281 the code that sets Vexec_path run on MS-Windows.
2282
2283 * lread.c (init_lread): Add comments to #ifdef's.
2284
97147da9
EZ
2285 * msdos.c (dos_set_window_size, IT_update_begin)
2286 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
2287 instead of direct references.
2288
185ee146
PE
22892012-08-04 Paul Eggert <eggert@cs.ucla.edu>
2290
2291 Export DEFAULT_REHASH_* to GDB.
2292 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
2293 Now constants, not macros.
2294
8834c57a
PE
22952012-08-03 Paul Eggert <eggert@cs.ucla.edu>
2296
98c6f1e3
PE
2297 Remove unnecessary casts involving pointers.
2298 These casts are no longer needed now that we assume C89 or later,
2299 since they involve casting to or from void *.
2300 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
2301 (make_pure_float, make_pure_vector):
2302 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
2303 * macros.c (Fstart_kbd_macro):
2304 * menu.c (find_and_return_menu_selection):
2305 * minibuf.c (read_minibuf_noninteractive):
2306 * sysdep.c (closedir):
2307 * xdisp.c (x_produce_glyphs):
2308 * xfaces.c (compare_fonts_by_sort_order):
2309 * xfns.c (x_real_positions, select_visual):
2310 * xselect.c (x_stop_queuing_selection_requests)
2311 (x_get_window_property, x_get_window_property_as_lisp_data):
2312 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
2313 Remove unnecessary pointer casts.
2314 * alloc.c (record_xmalloc): New function.
2315 * lisp.h (record_xmalloc): New decl.
2316 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
2317 more like a function. This is because the pointer cast is not
2318 needed. All uses changed.
2319 * print.c (print_string, print_error_message): Avoid length recalc.
2320
8834c57a
PE
2321 Improve fix for macroexp crash with debugging (Bug#12118).
2322 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
2323 ARRAY_MARK_FLAG when checking subscripts, because ASET is
2324 not supposed to be invoked from the garbage collector.
2325 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
2326 (gc_aset): New function, which is like ASET but can be
2327 used in the garbage collector.
2328 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
2329 (set_hash_index): Use it instead of ASET.
2330
6dad7178
EZ
23312012-08-03 Eli Zaretskii <eliz@gnu.org>
2332
2333 Support symlinks on latest versions of MS-Windows.
2334 * w32.c: Include winioctl.h and aclapi.h.
2335 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
2336 (revert_to_self): Forward declarations of static functions.
2337 <static BOOL g_b_init_get_security_info>:
2338 <g_b_init_create_symbolic_link>: New static flags.
2339 (globals_of_w32): Initialize them to zero.
2340 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
2341 (map_w32_filename): Improve commentary. Simplify switch.
2342 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
2343 headers (most versions of MinGW w32api don't).
2344 (get_security_info, create_symbolic_link)
2345 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
2346 New functions.
2347 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
2348 in the argument file name.
2349 (sys_access): Call unc_volume_file_attributes only if
2350 GetFileAttributes fails with network-related error codes.
2351 (sys_rename): Diagnose renaming of a symlink when the user doesn't
2352 have the required privileges.
14ae4239 2353 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
2354 get_file_security_desc.
2355 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
2356 with addition of handling of symlinks and support for 'lstat'.
2357 If possible, get file's attributes and security information by
6dad7178
EZ
2358 handle, not by name. Produce S_IFLNK bit for symlinks, when
2359 called from 'lstat'.
2360 (stat, lstat): New functions, call 'stat_worker'.
2361 (symlink, readlink, careadlinkat): Rewritten to create and resolve
2362 symlinks when the underlying filesystem supports them.
2363
f162bcc3
PE
23642012-08-02 Paul Eggert <eggert@cs.ucla.edu>
2365
79ea6c20
PE
2366 Fix macroexp crash on Windows with debugging (Bug#12118).
2367 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
2368 checking subscripts; problem introduced with the recent
2369 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
2370 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
2371 since it's used in non-static inline functions now.
2372
c0ce93fd
PE
2373 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
2374 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 2375
f162bcc3
PE
2376 Use C99-style 'extern inline' if available.
2377 * buffer.h (BUFFER_INLINE):
2378 * category.h (CATEGORY_INLINE):
2379 * character.h (CHARACTER_INLINE):
2380 * charset.h (CHARSET_INLINE):
2381 * composite.h (COMPOSITE_INLINE):
2382 * dispextern.h (DISPEXTERN_INLINE):
2383 * lisp.h (LISP_INLINE):
2384 * systime.h (SYSTIME_INLINE):
2385 New macro, replacing 'static inline' in this header.
2386 * buffer.h, category.h, character.h, charset.h, composite.h:
2387 * dispextern.h, lisp.h, systime.h:
2388 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2389 * alloc.c (LISP_INLINE):
2390 * buffer.c (BUFFER_INLINE):
2391 * category.c (CATEGORY_INLINE):
2392 * character.c (CHARACTER_INLINE):
2393 * charset.c (CHARSET_INLINE):
2394 * composite.c (COMPOSITE_INLINE):
2395 * dispnew.c (DISPEXTERN_INLINE):
2396 * sysdep.c (SYSTIME_INLINE):
2397 Define to EXTERN_INLINE, so that the corresponding functions
2398 are compiled into code.
2399 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
2400 (INLINE_HEADER_END): New macros.
2401 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
2402 since it's used in non-static inline functions now.
a8333d03 2403 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 2404
837b365b
GM
24052012-08-02 Glenn Morris <rgm@gnu.org>
2406
d66b744d
GM
2407 * s/: Remove empty directory.
2408
837b365b
GM
2409 * s/ms-w32.h: Move to ../nt/inc.
2410 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
2411 Update for new ms-w32.h location.
2412
13294f95
PE
24132012-08-02 Paul Eggert <eggert@cs.ucla.edu>
2414
2415 Port to Solaris 8.
2416 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
2417
90df0db3
GM
24182012-08-02 Glenn Morris <rgm@gnu.org>
2419
2420 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
2421 hard-coding the path separator.
2422
4939150c
PE
24232012-08-01 Paul Eggert <eggert@cs.ucla.edu>
2424
2425 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
2426 This how ASET and AREF are supposed to work, and makes
2427 it easier to think about future improvements. See
2428 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
2429 * charset.h (set_charset_attr): New function.
2430 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
2431 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
2432 (aref_addr): New function. All uses of &AREF(...) changed.
2433 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
2434 (set_hash_index): New functions. All lvalue-style uses of
2435 HASH_KEY etc. changed.
2436 * keyboard.c (set_prop): New function. All lvalue-style uses
2437 of PROP changed.
2438
947b2afd
AA
24392012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
2440
2441 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
2442 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
2443 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
2444 * nsfns.m (ns_set_name_as_filename): Likewise.
2445 * nsmenu.m (ns_update_menubar): Likewise.
2446 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
2447
4f5d0325
EZ
24482012-08-01 Eli Zaretskii <eliz@gnu.org>
2449
2008beae
EZ
2450 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
2451 Adapt to latest changes in field names of the corresponding Lisp
288479f6 2452 objects.
2008beae 2453
4f5d0325
EZ
2454 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
2455
fe3cc771
GM
24562012-08-01 Glenn Morris <rgm@gnu.org>
2457
2458 * s/msdos.h: Remove file.
2459 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
2460 * Makefile.in (S_FILE): Remove.
2461 (config_h): Remove S_FILE.
2462
c90acc54
JB
24632012-08-01 Juanma Barranquero <lekktu@gmail.com>
2464
2465 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
2466 Remove; moved to nt/config.nt.
2467
d8a05828
DA
24682012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2469
2470 Use INTERNAL_FIELD for conses and overlays.
2471 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
2472 Remove obsolete comment.
2473 (MVAR): New macro.
2474 (struct Lisp_Overlay): Use INTERNAL_FIELD.
2475 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
2476
8271d590
DA
24772012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2478
2479 Use INTERNAL_FIELD for symbols.
2480 * lisp.h (SVAR): New macro. Adjust users.
2481 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
2482 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
2483
3193acd2
DA
24842012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2485
2486 Use INTERNAL_FIELD for processes.
2487 * process.h (PVAR): New macro. Adjust style.
2488 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
2489 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
2490
3a45383a
DA
24912012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2492
2493 Use INTERNAL_FIELD for windows.
2494 * window.h (WVAR): New macro.
2495 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
2496 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
2497 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
2498 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
2499 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
2500 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
2501
c1dbc63c
PE
25022012-08-01 Paul Eggert <eggert@cs.ucla.edu>
2503
2504 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
2505
5c0c0e8a
GM
25062012-08-01 Glenn Morris <rgm@gnu.org>
2507
2508 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
2509 Move to configure.ac.
2510
552a99b4
JB
25112012-08-01 Juanma Barranquero <lekktu@gmail.com>
2512
2513 * makefile.w32-in (CONFIG_H): Update dependencies.
2514 (CONF_POST_H): New macro.
2515
2516 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
2517
8d8e2dfe
GM
25182012-07-31 Glenn Morris <rgm@gnu.org>
2519
bc96620a
GM
2520 * Makefile.in (S_FILE): No longer set by configure.
2521
476b1b2d
GM
2522 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
2523 is available.
2524 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
2525
b2c7a106
GM
2526 * process.h (NULL_DEVICE):
2527 * emacs.c (SEPCHAR):
2528 * editfns.c (USER_FULL_NAME): Let configure set them.
2529
d53d062a
GM
2530 * s/README, s/template.h: Remove files.
2531
4515017f
GM
2532 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
2533
8d8e2dfe
GM
2534 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
2535 Move to configure.ac.
2536
5b20b3cc
EZ
25372012-07-31 Eli Zaretskii <eliz@gnu.org>
2538
1e0afd9a
EZ
2539 * .gdbinit (xframe): Adapt to introduction of FVAR and the
2540 resulting renaming of 'struct frame' members.
2541
5b20b3cc
EZ
2542 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
2543
2544 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
2545 after introduction of FVAR.
2546
f1310128
JD
25472012-07-31 Jan Djärv <jan.h.d@swipnet.se>
2548
79e721e0
JD
2549 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
2550
2551 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
2552 instead of compositeToPoint.
2553 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
2554
8d7c7eed 2555 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 2556
e34f7f79
DA
25572012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2558
2559 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
2560 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 2561 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
2562 (BVAR): Change to use INTERNAL_FIELD.
2563 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
2564 (KVAR): Change to use INTERNAL_FIELD.
2565 * frame.h (FVAR): New macro.
2566 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
2567 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
2568 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
2569 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
2570 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
2571
c09bfb2f
DA
25722012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2573
2574 Miscellaneous fixes for non-default X toolkits.
2575 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
2576 * xterm.c (x_frame_of_widget): Remove redundant prototype.
2577 Move under #ifdef USE_LUCID.
2578 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
2579 definition and usage to avoid warnings.
2580
14c114ae
JD
25812012-07-31 Jan Djärv <jan.h.d@swipnet.se>
2582
2583 * nsterm.m (openFiles): Fix previous checkin.
2584
3bd21e82
PE
25852012-07-31 Paul Eggert <eggert@cs.ucla.edu>
2586
2587 * indent.c (compute_motion): Remove unused local.
2588
c1529ded
GM
25892012-07-31 Glenn Morris <rgm@gnu.org>
2590
400d5621
GM
2591 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
2592
268e2432
GM
2593 * conf_post.h [USG5_4]:
2594 Move remaining contents of s/usg5-4-common.h here.
2595 * s/usg5-4-common.h: Remove file.
2596
7552f3ee
GM
2597 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
2598 * s/irix6-5.h: Remove file.
2599
6a381852
GM
2600 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
2601 * s/darwin.h: Remove file.
2602
c1529ded
GM
2603 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
2604 * s/hpux10-20.h: Remove file, which is now empty.
2605
b429a4ee
GM
26062012-07-30 Glenn Morris <rgm@gnu.org>
2607
2608 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
2609 * Makefile.in (config_h): Add conf_post.h.
2610 * makefile.w32-in (CONFIG_H): Add conf_post.h.
2611
adff3182
JD
26122012-07-30 Jan Djärv <jan.h.d@swipnet.se>
2613
2614 * nsterm.m (ns_do_open_file): New variable.
b9031d69 2615 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
2616 (openFile, openTempFile, openFileWithoutUI, openFiles):
2617 Open files only if ns_do_open_file.
adff3182 2618
c32af1e4
PE
26192012-07-30 Paul Eggert <eggert@cs.ucla.edu>
2620
7393bcbb
PE
2621 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
2622 This no-op macro hasn't been needed for many years.
2623 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
2624
c32af1e4
PE
2625 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
2626 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
2627 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
2628 gdb_make_enums_visible.
2629 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
2630 (DIRECTORY_SEP): Now a constant, not a macro.
2631
302fc036
EZ
26322012-07-30 Eli Zaretskii <eliz@gnu.org>
2633
2634 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
2635 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
2636
2637 * w32term.c <w32_keyboard_codepage>: Renamed from
2638 keyboard_codepage and now external. All users changed.
2639
2640 * w32term.h: Add declaration of w32_keyboard_codepage.
2641
2642 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
2643 the codepage to translate keys to Unicode. If this argument is
2644 -1, use the value returned by GetConsoleCP. All callers changed.
2645
88fb40b4
PE
26462012-07-30 Paul Eggert <eggert@cs.ucla.edu>
2647
0aee6912
PE
2648 Update .PHONY listings in makefiles.
2649 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
2650 bootstrap-clean, distclean, maintainer-clean, versioclean,
2651 extraclean, frc.
2652
88fb40b4
PE
2653 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
2654 This is a bit clearer. Fix some commentary typos.
2655
0a763bd1
GM
26562012-07-30 Glenn Morris <rgm@gnu.org>
2657
32bac6d6
GM
2658 * s/netbsd.h: Let configure include signal.h if needed.
2659 Remove file, which is now empty.
2660
b65e7c46
GM
2661 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
2662 Let configure set them.
2663 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
2664 No more need to undefine.
0a763bd1 2665
169304bd
AS
26662012-07-30 Andreas Schwab <schwab@linux-m68k.org>
2667
2668 * keymap.c (Fkey_description): Don't remove 0x80 bit from
2669 non-single-byte char when adding meta modifier. (Bug#12090)
2670
6cd7a139
DA
26712012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2672
2673 Convert safe_call to use variable number of arguments.
2674 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
2675 (safe_call2): Fix comment.
2676 * lisp.h (safe_call): Adjust prototype.
2677 * coding.c (encode_coding_object): Change to use safe_call2.
2678 * xfaces.c (merge_face_heights): Change to use safe_call1.
2679
d34d6ffc
GM
26802012-07-30 Glenn Morris <rgm@gnu.org>
2681
7b8a48e4 2682 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 2683 does that unconditionally. Remove file, which is now empty.
7b8a48e4 2684
d34d6ffc
GM
2685 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
2686 Remove empty files.
2687
03a660a6
PE
26882012-07-30 Paul Eggert <eggert@cs.ucla.edu>
2689
2690 Export to GDB most of lisp.h's remaining object-like macros.
2691 * lisp.h (min, max): Move earlier, because they're used earlier now.
2692 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
2693 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
2694 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
2695 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
2696 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
2697 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
2698 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
2699 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
2700 Now constants, for GDB. They need not be macros.
2701 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
2702 Now constants, for GDB, as well as macros, for static initializers.
2703 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
2704 Move to after the definition of struct Lisp_Char_Table,
2705 since the former now needs that type defined.
2706 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
2707 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
2708 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
2709 New enums, for gdb_make_enums_visible.
2710 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 2711 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
2712 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
2713 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
2714 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
2715 enum maxargs, enum MAX_ALLOCA.
2716 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
2717 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
2718 no longer needed, now that they are done in lisp.h.
2719
e499d0ee
DA
27202012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2721
2722 Cleanup string bytes checking.
2723 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
2724 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
2725 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
2726 (check_sblock, compact_small_strings): Simplify.
2727
d5040d2d
PE
27282012-07-29 Paul Eggert <eggert@cs.ucla.edu>
2729
2730 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
2731 These macros are confusing and no longer need to be defined, as
2732 the enum values now suffice. All uses replaced with definiens.
2733 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
2734
7f259ae6
JB
27352012-07-29 Juanma Barranquero <lekktu@gmail.com>
2736
2737 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
2738 ($(BLD)/w32console.$(O)): Update dependencies.
2739
7e63e0c3
DA
27402012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2741
2742 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
2743 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
2744 time. Adjust users.
2745 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
2746
ffd817eb
JD
27472012-07-29 Jan Djärv <jan.h.d@swipnet.se>
2748
2749 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
2750 setting sitelisp (Bug#12010).
2751
417a7a0e
EZ
27522012-07-29 Eli Zaretskii <eliz@gnu.org>
2753
14ae4239 2754 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
2755
2756 * w32heap.c (cache_system_info):
2757 * w32.c (sys_rename):
2758 * w32proc.c (find_child_console, sys_kill): All users changed.
2759
387d4d92
PE
27602012-07-29 Paul Eggert <eggert@cs.ucla.edu>
2761
2762 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
2763
55a6cca6
EZ
27642012-07-29 Eli Zaretskii <eliz@gnu.org>
2765
2766 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
2767
dbcf001c
DA
27682012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2769
2770 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
2771 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
2772 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 2773
e2688e4a
DA
27742012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2775
2776 Generalize marker debugging code under MARKER_DEBUG and use eassert.
2777 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
2778 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
2779 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
2780 (replace_range, replace_range_2, del_range_2): Change to eassert.
2781 * marker.c (byte_char_debug_check): Adjust style.
2782
b46a6a83
PE
27832012-07-29 Paul Eggert <eggert@cs.ucla.edu>
2784
2785 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
2786 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
2787 long-ago-commented-out code that talks about "WIN32".
2788 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
2789 All uses changed.
2790
e32a5799
PE
27912012-07-28 Paul Eggert <eggert@cs.ucla.edu>
2792
2793 Use Gnulib stdalign module (Bug#9772, Bug#9960).
2794 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
2795 Simplify by using alignof.
2796 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
2797 * lisp.h: Include <stdalign.h>.
2798 (GCALIGNMENT): New macro and constant.
2799 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
2800 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
2801 (stdalign): New macro, if not already defined.
2802
df81cd29
EZ
28032012-07-28 Eli Zaretskii <eliz@gnu.org>
2804
01bd1b0d
EZ
2805 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
2806 * w32inevt.c: Include w32inevt.h.
2807 (w32_read_console_input): New inline function, calls either
2808 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
2809 w32_console_unicode_input.
2810 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
2811 (w32_kbd_patch_key, key_event): Use the codepage returned by
2812 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
2813 (key_event): use uChar.UnicodeChar only if
2814 w32_console_unicode_input is non-zero.
2815
2816 * w32console.c: Include w32heap.h.
2817 <w32_console_unicode_input>: New global variable.
2818 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
2819 family of Windows, zero otherwise.
2820
2821 * w32inevt.h: Declare w32_console_unicode_input.
2822
df81cd29
EZ
2823 * xdisp.c (init_iterator): Don't reference tip_frame in a build
2824 --without-x. (Bug#11742)
2825
c20fdd9e
PE
28262012-07-27 Paul Eggert <eggert@cs.ucla.edu>
2827
2828 Adjust GDB to reflect pvec_type changes (Bug#12036).
2829 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
2830 2012-07-04 changes to pseudovector representation.
2831 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 2832
32770973 28332012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
2834
2835 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
2836 bus address.
2837 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
2838
3438fe21
EZ
28392012-07-27 Eli Zaretskii <eliz@gnu.org>
2840
bcfbc9de
EZ
2841 * alloc.c (listn): Fix the order the arguments are consed onto the
2842 list.
2843
3438fe21
EZ
2844 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
2845 enumeration constants, as PURE and HEAP are too general, and clash
2846 with other headers and sources, such as gmalloc.c and the
2847 MS-Windows system headers. All users changed.
2848
eeaea515
DA
28492012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2850
2851 Revert last save_excursion_save and save_excursion_restore changes.
2852 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
2853 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
2854
073c88c2
DA
28552012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2856
2857 Fix recently-introduced typos in Windows port.
2858 Reported by Martin Rudalics <rudalics@gmx.at>.
2859 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 2860 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 2861
4706125e
PE
28622012-07-27 Paul Eggert <eggert@cs.ucla.edu>
2863
2864 Improve GDB symbol export (Bug#12036).
2865 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
2866 arms of an 'if', not using conditional expressions; otherwise GDB
2867 complains about the types in the unevaluated arm when the argument
2868 is an integer literal.
2869 (xgetint): Simplify expression.
2870 * alloc.c (gdb_make_enums_visible): New constant. This ports to
2871 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
2872 Zaretskii in <http://bugs.gnu.org/12036#13>.
2873 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
2874 needed now that we have gdb_make_enums_visible.
2875 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
2876 (enum enum_USE_LSB_TAG):
2877 New enum types, packaging up enums that need to be exported to GDB.
2878
694b6c97
DA
28792012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2880
2881 Utility function to make a list from specified amount of objects.
2882 * lisp.h (enum constype): New datatype.
2883 (listn): New prototype.
2884 * alloc.c (listn): New function.
2885 (Fmemory_use_count, syms_of_alloc): Use it.
2886 * buffer.c (syms_of_buffer): Likewise.
2887 * callint.c (syms_of_callint): Likewise.
2888 * charset.c (define_charset_internal): Likewise.
2889 * coding.c (syms_of_coding): Likewise.
2890 * keymap.c (syms_of_keymap): Likewise.
2891 * search.c (syms_of_search): Likewise.
2892 * syntax.c (syms_of_syntax): Likewise.
2893 * w32.c (init_environment): Likewise.
2894 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
2895 * xdisp.c (syms_of_xdisp): Likewise.
2896 * xfns.c (syms_of_xfns): Likewise.
2897
6195f384
DA
28982012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2899
2900 Fast save_excursion_save and save_excursion_restore.
2901 * lisp.h (struct Lisp_Excursion): New data type.
2902 (PVEC_EXCURSION): New pseudovector type.
2903 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
2904 to deal with it. Adjust comments.
2905 (init_marker, attach_marker): New prototype.
2906 (unchain_marker): Adjust prototype.
2907 * marker.c (attach_marker): Change to global.
2908 (init_marker): New function.
2909 * alloc.c (Fmake_marker, build_marker): Use it.
2910 (build_marker): More easserts.
2911 (mark_object): Handle struct Lisp_Excursion.
2912 * editfns.c (save_excursion_save, save_excursion_restore):
2913 Reimplement to use struct Lisp_Excursion. Add comments.
2914
5eceb8fb
PE
29152012-07-26 Paul Eggert <eggert@cs.ucla.edu>
2916
2917 Fix export of symbols to GDB (Bug#12036).
2918 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
2919 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
2920 emacs.c, as this is a more-suitable home. Had this been done earlier
2921 the fix for 12036 would have avoided some of the problems noted in
2922 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
2923 would have been more obvious.
562157c8
PE
2924 * emacs.c: Do not include <verify.h>; no longer needed.
2925 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
2926 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
2927 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
2928 Remove; now done in lisp.h.
2929 * lisp.h (PUBLISH_TO_GDB): New macro.
2930 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
2931 (DATA_SEG_BITS): Use it.
2932 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
2933 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
2934 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
2935 not be usable in #if. This simplifies things.
2936
d6749401
JB
29372012-07-26 Juanma Barranquero <lekktu@gmail.com>
2938
2939 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
2940
1781b9e9
PE
29412012-07-26 Paul Eggert <eggert@cs.ucla.edu>
2942
d89518db 2943 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
2944 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
2945 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
2946 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
2947 Adjust to changes in lisp.h and emacs.c, by using
2948 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
2949 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
2950 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
2951 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
2952 instead of gdb_valbits.
2953 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
2954 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
2955 instead of gdb_array_mark_flag.
2956 (xboolvector): Get size from $->size, not $->header.size.
2957 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
2958 (xreload, hook-run, hookpost-run): Remove.
2959 * emacs.c: Include <verify.h>.
2960 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
2961 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
2962 Remove.
2963 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
2964 (gdb_USE_LSB_TAG): New enum constants.
2965 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
2966 Also define these as enum constants, so they're visible to GDB.
2967 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
2968 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
2969 as constants, so they're visible to GDB.
2970 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
2971 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
2972 Now enum constants, not macros, so they're visible to GDB.
2973 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
2974 more convenient now. All uses changed.
2975 (VALMASK) [USE_LSB_TAG]: Also define in this case.
2976 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
2977
3628596a
DA
29782012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
2979
2980 Explicitly free restriction data that are not needed anymore.
2981 * editfns.c (save_restriction_restore): Free restriction data.
2982
7abaf5cc
SM
29832012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
2984
2985 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
2986 add argument, tune behavior, and adjust all callers.
2987
71f88e00
PE
29882012-07-25 Paul Eggert <eggert@cs.ucla.edu>
2989
2990 Use typedef for EMACS_INT, EMACS_UINT.
2991 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
2992 than macros. This simplifies debugging in the usual case, since
2993 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
2994 and it allows expressions involving EMACS_INT casts.
2995 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
2996
57ec3034
JD
29972012-07-25 Jan Djärv <jan.h.d@swipnet.se>
2998
2999 * nsterm.m (ns_read_socket): Return early if there is a modal
3000 window (Bug#12043).
3001
8137e7b3
MR
30022012-07-25 Martin Rudalics <rudalics@gmx.at>
3003
3004 * frame.c (Fredirect_frame_focus): In doc-string don't mention
3005 that FOCUS-FRAME can be omitted.
3006
04e9897c
DA
30072012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
3008
3009 Adjust buffer text indirection counters at the end of Fkill_buffer.
3010 * buffer.c (Fkill_buffer): Adjust indirection counters when the
3011 buffer is definitely dead. This should really fix an issue reported
3012 by Christoph Scholtes again. (Bug#12007).
3013 (init_buffer_once): Initialize indirection counters of
3014 buffer_defaults and buffer_local_symbols (for sanity and safety).
3015
8a0484e1
EZ
30162012-07-24 Eli Zaretskii <eliz@gnu.org>
3017
3018 * xdisp.c (init_iterator): Don't compute dimensions of truncation
3019 and continuation glyphs on tooltip frames, leave them at zero.
3020 Avoids continued lines in tooltips. (Bug#11832)
3021
fa691a83
DA
30222012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
3023
3024 Simplify copy_overlay.
04e9897c 3025 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
3026 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
3027
436bc8e0
EZ
30282012-07-23 Eli Zaretskii <eliz@gnu.org>
3029
3030 * print.c (print_object): Don't crash when a frame's name is nil
3031 or invalid. (Bug#12025)
3032
3033 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
3034 it signals an error when a tooltip frame is being created.
3035
d7a7fda3
DA
30362012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
3037
3038 Cleanup miscellaneous objects allocation and initialization.
3039 * alloc.c (allocate_misc): Change to static. Add argument to
3040 specify the subtype. Adjust comment and users.
3041 (build_overlay): New function.
3042 * buffer.c (copy_overlays, Fmake_overlay): Use it.
3043 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
3044 (allocate_misc): Remove prototype.
3045 (build_overlay): Add prototype.
3046
30472012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
3048
3049 Swap buffer text indirection counters in Fbuffer_swap_text.
3050 * buffer.c (Fbuffer_swap_text): Swap indirections too.
3051 This avoids crash reported by Christoph Scholtes at
3052 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
3053
9d7fa573
JD
30542012-07-22 Jan Djärv <jan.h.d@swipnet.se>
3055
3056 * nsmenu.m (Popdown_data): New struct.
3057 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
3058 free Popdown_data.
3059 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
3060 (initWithContentRect): Make imgView and contentView non-static
3061 and autorelease them. Also autorelease img and matrix (Bug#12005).
3062 (dealloc): Remove (Bug#12005).
3063
0dd6d66d
DA
30642012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
3065
3066 Adjust consing_since_gc when objects are explicitly freed.
3067 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
3068 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
3069 (free_cons, free_misc): Subtract object size from consing_since_gc.
3070
d36d71df
DA
30712012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
3072
3073 Simplify and cleanup markers positioning code.
3074 * marker.c (attach_marker): More useful eassert.
3075 (live_buffer, set_marker_internal): New function.
3076 (Fset_marker, set_marker_restricted): Use set_marker_internal.
3077 (set_marker_both, set_marker_restricted_both): Use live_buffer.
3078
fb9ea40f
PE
30792012-07-22 Paul Eggert <eggert@cs.ucla.edu>
3080
3081 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
3082 as it's limited by the amount of memory, not by INT_MAX.
3083
2d5c5f7d
EZ
30842012-07-21 Eli Zaretskii <eliz@gnu.org>
3085
07fb592e
EZ
3086 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
3087 in special-event-map. See the discussion at
3088 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
3089 for the reasons.
3090
37a9eac8 3091 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
3092 info.dwItemData. Fixes crashes on 64-bit Windows.
3093 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 3094
c4328746
JD
30952012-07-21 Jan Djärv <jan.h.d@swipnet.se>
3096
3097 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 3098 (conversationIdentifier): Return value is NSInteger.
784051c4 3099 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 3100
6e5d1c12
CY
31012012-07-21 Chong Yidong <cyd@gnu.org>
3102
3103 * window.c (decode_any_window): Signal an error if the window is
3104 on a dead frame (Bug#11984).
3105
9928463d
DA
31062012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3107
3108 Add indirection counting to speed up Fkill_buffer.
3109 * buffer.h (struct buffer): New member.
3110 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
3111 (Fmake_indirect_buffer): Set indirection counter to -1, increment
3112 base buffer indirection counter.
3113 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
3114 (Fkill_buffer): Adjust indirection counters as needed, don't walk
3115 through buffer list if indirection counter is 0.
3116
f8643a6b
DA
31172012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3118
3119 Extend the value returned by Fgarbage_collect with heap statistics.
3120 * alloc.c (Qheap): New symbol.
3121 (syms_of_alloc): DEFSYM it.
3122 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
3123 (Fmemory_free): Remove.
3124 (syms_of_alloc): Don't defsubr it.
3125 * buffer.c (Fcompact_buffer): Remove.
3126 (syms_of_buffer): Don't defsubr it.
3127
dac616ff
DA
31282012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3129
3130 Make maybe_gc inline.
3131 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
3132 * lisp.h (consing_since_gc, gc_relative_threshold)
3133 (memory_full_cons_threshold): Revert declaration.
3134 (maybe_gc): Remove prototype, define as inline.
3135 * alloc.c: Remove old commented-out code.
3136 (consing_since_gc, gc_relative_threshold)
3137 (memory_full_cons_threshold): Revert to global.
3138 (maybe_gc): Remove.
3139
d7ea76b4
DA
31402012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3141
3142 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
3143 * lisp.h (build_unibyte_string): New function.
3144 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
3145 * sysdep.c, w32fns.c, xfns.c: Use it.
3146 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
3147 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
3148 Adjust users accordingly.
3149 * font.h (font_open_by_name): Adjust prototype.
3150
765e61e3
DA
31512012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3152
3153 Cleanup calls to Fgarbage_collect.
3154 * lisp.h (maybe_gc): New prototype.
3155 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
3156 Remove declarations.
3157 * alloc.c (maybe_gc): New function.
3158 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
3159 Make them static.
3160 * bytecode.c (MAYBE_GC): Use maybe_gc.
3161 * eval.c (eval_sub, Ffuncall): Likewise.
3162 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
3163 to avoid dependency from auto-save feature.
3164
52b852c7
PE
31652012-07-19 Paul Eggert <eggert@cs.ucla.edu>
3166
3167 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
3168 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
3169 'for_each_per_buffer_object_at'.
3170 All uses changed. It's better to use upper-case for macros that
3171 cannot be implemented as functions, to give the reader a clue
3172 that they're special.
3173
5db81e33
SM
31742012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
3175
3176 * alloc.c (Fgarbage_collect): Tweak docstring.
3177
5b835e1d
DA
31782012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
3179
3180 Tweak the value returned from Fgarbage_collect again.
3181 * alloc.c (Fgarbage_collect): New return value, as confirmed in
3182 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
3183 Adjust documentation.
3184 (total_vector_bytes): Rename to total_vector_slots, adjust
3185 accounting.
3186 (total_free_vector_bytes): Rename to total_free_vector_slots,
3187 adjust accounting.
3188 (Qstring_bytes, Qvector_slots): New symbols.
3189 (syms_of_alloc): DEFSYM them.
3190
9cd47b72
DA
31912012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
3192
3193 Buffer compaction primitive which may be used from Lisp.
3194 * buffer.c (compact_buffer, Fcompact_buffer): New function.
3195 (syms_of_buffer): Register Fcompact_buffer.
3196 * alloc.c (Fgarbage_collect): Use compact_buffer.
3197 * buffer.h (compact_buffer): New prototype.
3198 (struct buffer_text): New member.
3199
d17337e5
DA
32002012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
3201
3202 New macro to iterate over all buffers, miscellaneous cleanups.
3203 * lisp.h (all_buffers): Remove declaration.
3204 * buffer.h (all_buffers): Add declaration, with comment.
3205 (for_each_buffer): New macro.
3206 * alloc.c (Fgarbage_collect, mark_object): Use it.
3207 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
3208 (init_buffer): Likewise.
3209 * data.c (Fset_default): Likewise.
3210 * coding.c (code_conversion_restore): Remove redundant check
3211 for dead buffer.
3212 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
3213
60cfd278
AS
32142012-07-18 Andreas Schwab <schwab@linux-m68k.org>
3215
3216 Fix bug that created negative-length intervals.
3217 * intervals.c (merge_interval_right, merge_interval_left):
3218 Do not zero out this interval if it is absorbed by its children,
3219 as this interval's total length doesn't change in that case. See
3220 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
3221
d06714cb
PE
32222012-07-18 Paul Eggert <eggert@cs.ucla.edu>
3223
83713154
PE
3224 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
3225 when invoking (make-bool-vector N t) and N is a positive
3226 multiple of 8 -- the last 8 bits were mistakenly cleared.
3227
d06714cb
PE
3228 Remove some struct layout assumptions in bool vectors.
3229 * alloc.c (bool_header_size): New constant.
3230 (header_size, word_size): Move earlier, as they're now used earlier.
3231 Use 'word_size' in a few more places, where it's appropriate.
3232 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
3233 padding before the data member of a bool vector.
3234 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
3235 than doing the check by hand with an abort ().
3236
464d5a5e
SM
32372012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3238
5fbc0409
SM
3239 * eval.c (Fdefvar): Don't check constants since we only set the var if
3240 it's not yet defined anyway (bug#11904).
3241
464d5a5e
SM
3242 * lisp.h (last_undo_boundary): Declare new var.
3243 * keyboard.c (command_loop_1): Set it.
3244 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
3245 were auto-added by the command loop (bug#11774).
3246
8dc2e44a
AS
32472012-07-18 Andreas Schwab <schwab@linux-m68k.org>
3248
3249 * w32font.c (Qsymbol): Remove local definition.
3250 (syms_of_w32font): Don't DEFSYM it.
3251
169925ec
DA
32522012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
3253
3254 Fix sweep_vectors to handle large bool vectors correctly.
3255 * alloc.c (sweep_vectors): Account total_vector_bytes for
3256 bool vectors larger than VBLOCK_BYTES_MAX.
3257
5fbfb018
CY
32582012-07-18 Chong Yidong <cyd@gnu.org>
3259
3260 * frame.c (x_set_frame_parameters): Revert bogus change introduced
3261 in 2012-05-25 commit by Paul Eggert (Bug#11738).
3262
3ab6e069
DA
32632012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
3264
3265 Return more descriptive data from Fgarbage_collect.
3266 Suggested by Stefan Monnier in
3267 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
3268 * alloc.c (bounded_number): New function.
3269 (total_buffers, total_vectors): New variable.
3270 (total_string_size): Rename to total_string_bytes, adjust users.
3271 (total_vector_size): Rename to total_vector_bytes, adjust users.
3272 (sweep_vectors): Account total_vectors and total_vector_bytes.
3273 (Fgarbage_collect): New return value. Adjust documentation.
3274 (gc_sweep): Account total_buffers.
3275 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
3276 (VECTOR_SIZE): Remove.
3277 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
3278 (Qinterval, Qmisc): New symbols.
3279 (syms_of_data): Initialize them.
3280 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
3281 (Qcons, Qbuffer): New declarations.
3282
6d02fe5b
PE
32832012-07-17 Paul Eggert <eggert@cs.ucla.edu>
3284
3285 * alloc.c (Fmemory_free): Account for memory-free's own storage.
3286 Round up, not down. Improve doc.
3287
b7ffe040
DA
32882012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
3289
3290 Restore old code in allocate_string_data to avoid Faset breakage.
3291 Reported by Julien Danjou <julien@danjou.info> in
3292 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
3293 * alloc.c (allocate_string_data): Restore old code with minor
3294 adjustments, fix comment to explain this subtle issue.
3295
4dc7c8d5
SM
32962012-07-17 Eli Zaretskii <eliz@gnu.org>
3297
3298 Remove FILE_SYSTEM_CASE.
3299 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
3300
3301 * fileio.c (FILE_SYSTEM_CASE): Don't define.
3302 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
3303 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
3304 call-process-region passes it through expand-file-name.
3305
3306 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
3307
33082012-07-17 Andreas Schwab <schwab@linux-m68k.org>
3309
3310 Fix crash when creating indirect buffer (Bug#11917)
3311 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
3312 Don't handle unbound variables specially if non-zero.
3313 (Fbuffer_local_variables): Pass zero.
3314 (clone_per_buffer_values): Pass non-zero.
3315
33162012-07-17 Andreas Schwab <schwab@linux-m68k.org>
3317
3318 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
3319 to make the loop interruptible.
3320
33212012-07-17 Andreas Schwab <schwab@linux-m68k.org>
3322
3323 * gnutls.c (emacs_gnutls_handshake): Only retry if
3324 GNUTLS_E_INTERRUPTED.
3325
cce7fefc
DA
33262012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
3327
3328 Cleanup and convert miscellaneous checks to eassert.
3329 * alloc.c (mark_interval): Fix comment, partially rephrase
3330 old comment from intervals.h (see below).
3331 * intervals.c (find_interval, adjust_intervals_for_insertion)
3332 (delete_interval, adjust_intervals_for_deletion)
3333 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
3334 Convert to eassert.
3335 (adjust_intervals_for_insertion, make_new_interval):
3336 Remove obsolete and unused code.
3337 * intervals.h (struct interval): Remove obsolete comment.
3338 * textprotp.c (erase_properties): Remove unused code.
3339 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
3340 (Fremove_list_of_text_properties): Convert to eassert.
3341
9ea10cc3
CY
33422012-07-17 Chong Yidong <cyd@gnu.org>
3343
3344 * editfns.c (Finsert_char): Doc fix.
3345
3900d5de
DA
33462012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
3347
3348 Fix previous change to make Fmemory_free always accurate.
3349 * alloc.c (make_interval): Update total_free_intervals.
3350 (make_float): Likewise for total_free_floats.
3351 (free_cons, Fcons): Likewise for total_free_conses.
3352 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
3353 Likewise for total_free_vector_bytes.
3354 (Fmake_symbol): Likewise for total_free_symbols.
3355 (bytes_free): Remove.
3356
7098646f
DA
33572012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
3358
3359 Simple free memory accounting feature.
3360 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
3361 (sweep_vectors): Accumulate size of free vectors.
3362 (Fgarbage_collect): Setup bytes_free.
3363 (Fmemory_free): New function.
3364 (syms_of_alloc): Register it.
3365
22657b40
DA
33662012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
3367
3368 Cleanup overlays checking.
3369 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
3370 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
3371 eassert and OVERLAYP.
3372 (sort_overlays): Change to use OVERLAYP.
3373
ddfc8813
RK
33742012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
3375
3376 * editfns.c (Finsert_char): Make it interactive, and make the
3377 second arg optional. Copy interactive spec and docstring from
3378 ucs-insert.
3379
7c26cf3c
PE
33802012-07-17 Paul Eggert <eggert@cs.ucla.edu>
3381
3382 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
3383 Unlike the other wrapped functions, fabs has an unspecified
3384 effect on errno.
3385
5d127af9
JD
33862012-07-16 Jan Djärv <jan.h.d@swipnet.se>
3387
3388 * nsterm.m (keyDown): Interpret flags without left/right bits
3389 as the left key (Bug#11670).
3390
6a0dd1d7
DA
33912012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
3392
3393 Remove empty and useless init functions.
3394 * lisp.h (init_character_once, init_fns, init_image)
3395 (init_filelock, init_sound): Remove prototype.
3396 * character.c (init_character_once): Remove.
3397 * filelock.c (init_filelock): Likewise.
3398 * fns.c (init_fns): Likewise.
3399 * image.c (init_image): Likewise.
3400 * sound.c (init_sound): Likewise.
3401 * emacs.c (main): Adjust accordingly.
3402
7a6136fd
DA
34032012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
3404
3405 * gtkutil.h: Tiny cleanups.
3406 (use_old_gtk_file_dialog): Remove useless declaration.
3407 (xg_uses_old_file_dialog): Add suggested const attribute.
3408
ce811ad9
EZ
34092012-07-15 Eli Zaretskii <eliz@gnu.org>
3410
3411 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
3412 (bidi_paragraph_init): Use it to limit search forward for a strong
3413 directional character in abnormally large paragraphs full of
3414 neutral or weak characters. (Bug#11943)
3415
c9adfeaa
SF
34162012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
3417
3418 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
3419 the toolbar (Bug#9451).
3420 (xg_make_tool_item): Give the widget event box a transparent
3421 background.
3422
fff62aa9
DA
34232012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
3424
3425 Cleanup basic allocation variables and functions.
3426 * alloc.c (ignore_warnings, init_intervals, init_float)
3427 (init_cons, init_symbol, init_marker): Remove.
3428 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
3429 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
3430 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
3431 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
3432 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
3433 (staticidx, init_alloc_once, init_strings, free_ablock):
3434 Remove redundant initialization.
3435 * fns.c (init_weak_hash_tables): Remove.
3436 * lisp.h (init_weak_hash_tables): Remove prototype.
3437
9730daca
DA
34382012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
3439
3440 Use zero_vector where appropriate.
3441 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
3442 accordingly.
3443 * lisp.h (zero_vector): New declaration.
3444 * font.c (null_vector): Remove.
3445 (syms_of_font): Remove initialization and staticpro.
3446 (font_list_entities, font_find_for_lface): Change to use zero_vector.
3447 * keymap.c (Faccessible_keymaps): Likewise.
3448
2e2d2a13
LL
34492012-07-15 Leo Liu <sdl.web@gmail.com>
3450
3451 * fringe.c: Fix typo in comments.
3452
cd276f6e
LL
34532012-07-14 Leo Liu <sdl.web@gmail.com>
3454
3455 * fringe.c: Add a new bitmap exclamation-mark.
3456
5a1131d9
EZ
34572012-07-14 Eli Zaretskii <eliz@gnu.org>
3458
3459 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
3460
3461 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
3462 (HAVE_MENUS): Don't define, defined by editing config.in with
3463 msdos/sed2v2.inp.
3464 (GMALLOC_INHIBIT_VALLOC): Don't define.
3465 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
3466
22e983b7
JB
34672012-07-14 Juanma Barranquero <lekktu@gmail.com>
3468
3469 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
3470
5b3f250f
GM
34712012-07-14 Glenn Morris <rgm@gnu.org>
3472
3473 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
3474 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
3475 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
3476
33d63ff4
GM
34772012-07-13 Glenn Morris <rgm@gnu.org>
3478
5b633342
GM
3479 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
3480
33d63ff4
GM
3481 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
3482 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
3483
b55b9f85
JD
34842012-07-13 Jan Djärv <jan.h.d@swipnet.se>
3485
0dc8cf50
JD
3486 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
3487 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
3488 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
3489 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
3490 where appropriate.
3491 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
3492 as boolean expression.
3493 (x_set_window_size): Remove unused variable toolbar.
3494 (ns_get_color_default, ns_mod_to_lisp): Remove.
3495 (ns_mouse_position): Remove unused variables xchar and ychar.
3496 (ns_compute_glyph_string_overhangs): Remove unused variable face.
3497 (ns_set_vertical_scroll_bar): Remove unused variable count.
3498 (ns_delete_terminal): Remove unused variable i.
3499 (ns_term_init): Remove unused variables r, g and b.
3500 (mouseDown): Remove unused variable window.
3501 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
3502 (initFrameFromEmacs): Remove unused variable vbextra.
3503 (mouseEntered): Remove unused variables p and dpyinfo.
3504 (mouseExited): Remove unused variables p and r.
3505 (ns_define_frame_cursor, ns_clear_frame_area)
3506 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
3507 (menuDown): Assign [sender tag] to variable and cast the variable.
3508
3509 * nsterm.h (menuDown): Add id as type to argument sender.
3510 (ns_display_info_for_name): Add Lisp_Object argument.
3511 (ns_term_init): Add Lisp_Object argument.
3512 (ns_map_event_to_object): Add void argument.
3513 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
3514 prototype with arguments and only declare if __OBJC__.
3515 (nxatoms_of_nsselect): Add void argument.
3516 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
3517 (ns_alloc_autorelease_pool): Add void argument.
3518 (ns_release_autorelease_pool): Add void* argument.
3519 (ns_get_defaults_value): Add const char* argument.
3520
3521 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
3522 (initFromContents): Use SSDATA where appropriate.
3523 (ns_update_menubar): Add braces to ambigous if-else.
3524 (initWithTitle): Put () around assignment in if statement.
3525 (ns_menu_show): Remove unused variables window and keymap.
3526 (update_frame_tool_bar): Remove unused variable selected_p.
3527 (initWithContentRect): Remove unused variable this_cmd_name.
3528
3529 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
3530 appropriate.
3531 (setXBMColor): Remove unused variable len.
3532 (setPixmapData): Put () around assignment in loop statement.
3533
3534 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
3535 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
3536 where appropriate.
3537 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
3538 around assignment in loop statement.
3539 (nsfont_open): Remove unused variable i.
3540 (nsfont_open): Remove unused variable len.
3541 (nsfont_draw): Remove unused variable cs.
3542
3543 * nsfns.m (x_set_icon_name, ns_set_name_internal)
3544 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
3545 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
3546 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
3547 (Fns_font_name, Fns_perform_service)
3548 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
3549 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
3550 (ns_set_name): Remove unused variable view.
3551 (x_set_menu_bar_lines): Remove unused variable olines.
3552 (x_set_tool_bar_lines): Remove unused variable root_window.
3553 (Fns_list_colors): Put () around assignment in while statement.
3554 (Fns_perform_service): Remove unused variable len.
3555 (Fns_display_usable_bounds): Remove unused variable top.
3556 (syms_of_nsfns): Remove unused variable i.
3557
b55b9f85
JD
3558 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
3559 memcpy (Bug#11907).
3560
ed9265fc 35612012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
3562
3563 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
3564 and free it with DestroyExceptionInfo (Bug#11558).
3565
ef099b57
JB
35662012-07-13 Juanma Barranquero <lekktu@gmail.com>
3567
3568 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
3569 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
3570 Set here, not in nt/config.nt.
3571
ea814a5d
EZ
35722012-07-13 Eli Zaretskii <eliz@gnu.org>
3573
3574 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
3575 cursor overflow into the last glyph on display line when the right
3576 fringe is off. (Bug#11832)
3577
1a952767
PE
35782012-07-13 Paul Eggert <eggert@cs.ucla.edu>
3579
3580 * xdisp.c (produce_special_glyphs): Now static.
3581 * dispextern.h (produce_special_glyphs): Remove decl.
3582
983188fd
GM
35832012-07-13 Glenn Morris <rgm@gnu.org>
3584
8d7c7eed 3585 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
3586 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
3587
983188fd
GM
3588 * s/usg5-4-common.h (USG, USG5):
3589 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
3590 * s/sol2-6.h (SOLARIS2):
3591 * s/irix6-5.h (IRIX6_5):
3592 * s/hpux10-20.h (USG, USG5, HPUX):
3593 * s/gnu-linux.h (USG, GNU_LINUX):
3594 * s/freebsd.h (BSD_SYSTEM):
3595 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
3596 * s/cygwin.h (CYGWIN):
3597 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
3598 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
3599
d1e68667 36002012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
3601
3602 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 3603
6de0e799
GM
36042012-07-13 Glenn Morris <rgm@gnu.org>
3605
739ae010
GM
3606 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
3607
dbee5793
GM
3608 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
3609
6de0e799
GM
3610 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
3611 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
3612
b82da769
GM
36132012-07-12 Glenn Morris <rgm@gnu.org>
3614
4fae5a7a 3615 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
3616
3617 * process.c (init_process_emacs): Rename from init_process.
3618 The old name is also the name of a Mach system call.
3619 * lisp.h, emacs.c: Update for this name change.
3620 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
3621 longer needed.
3622
5a979817
EZ
36232012-07-12 Eli Zaretskii <eliz@gnu.org>
3624
3625 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
3626 memmove call that removes glyphs covered by the left truncation
3627 glyph. Improve commentary.
3628 (display_line): Fix display of continuation glyphs on GUI frames
3629 when the right fringe is turned off and variable-size fonts are
3630 used in the window. Move the code that appends a stretch glyph to
3631 produce_special_glyphs, so that it could be used for truncation
3632 and continuation glyphs alike.
3633 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
3634 glyph of a suitably computed width, to align the special glyphs at
3635 the window margin. Code moved from display_line. (Bug#11832)
3636
3e91a053
GM
36372012-07-12 Glenn Morris <rgm@gnu.org>
3638
ba9e4b84
GM
3639 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
3640
3641 * s/gnu-linux.h, s/hpux10-20.h:
3642 Do not unconditionally define HAVE_XRMSETDATABASE.
3643
3e91a053
GM
3644 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
3645
b300b1f4
PE
36462012-07-12 Paul Eggert <eggert@cs.ucla.edu>
3647
3648 Fix typos that broke OS X build.
3649 Reported by Randal L. Schwartz in
3650 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
3651 * nsterm.m (ns_timeout): Add missing local decl.
3652 (ns_get_color): snprintf -> sprintf, to fix typo.
3653
6e777848
GM
36542012-07-12 Glenn Morris <rgm@gnu.org>
3655
3f922c37
GM
3656 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
3657 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
3658 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
3659 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
3660
0ab7b23a
GM
3661 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
3662 Move PTY_OPEN to configure.
3663
6e777848
GM
3664 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3665 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
3666 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
3667
4a7edc24
DA
36682012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
3669
3670 Use empty_unibyte_string where applicable.
3671 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
3672 * lread.c (read1): Likewise.
3673 * xsettings.c (syms_of_xsettings): Likewise.
3674
308aab79
GM
36752012-07-12 Glenn Morris <rgm@gnu.org>
3676
42bd1719
GM
3677 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
3678 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
3679 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
3680 * s/hpux10-20.h (RUN_TIME_REMAP):
3681 * s/bsd-common.h (TABDLY): Move to configure.
3682
3683 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
3684
3685 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
3686
ea0bbd17 3687 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 3688 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
3689
3690 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 3691
308aab79
GM
3692 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
3693 * s/template.h: Move NARROWPROTO to configure.
3694
ee1cf5cf
GM
36952012-07-11 Glenn Morris <rgm@gnu.org>
3696
30fe9bf4
GM
3697 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
3698 unused since 2011-01-17 change to systty.h.
3699
ee1cf5cf
GM
3700 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
3701 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
3702 Move HAVE_PTYS and HAVE_SOCKETS to configure.
3703
63e47e07
PE
37042012-07-11 Paul Eggert <eggert@cs.ucla.edu>
3705
3706 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
3707
c43fb4c3
GM
37082012-07-11 Glenn Morris <rgm@gnu.org>
3709
3710 * s/darwin.h, s/gnu-linux.h, s/template.h:
3711 Move INTERRUPT_INPUT to configure.
3712
e8df9267
DA
37132012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
3714
3715 Minor adjustments to interning code.
3716 * lisp.h (intern, intern_c_string): Redefine as static inline
3717 wrappers for intern_1 and intern_c_string_1, respectively.
3718 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
3719 * lread.c (intern_1, intern_c_string_1, oblookup):
3720 Simplify Vobarray checking.
e8df9267
DA
3721 * font.c (font_intern_prop): Likewise. Adjust comment.
3722 * w32font.c (intern_font_name): Likewise.
3723
34348bd4
AS
37242012-07-11 Andreas Schwab <schwab@linux-m68k.org>
3725
d96a1e0c
AS
3726 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
3727
34348bd4
AS
3728 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
3729 of Fcar/Fcdr if possible.
3730 * font.c (check_otf_features): Likewise.
3731 * fontset.c (Fnew_fontset): Likewise.
3732 * gnutls.c (Fgnutls_boot): Likewise.
3733 * minibuf.c (read_minibuf): Likewise.
3734 * msdos.c (IT_set_frame_parameters): Likewise.
3735 * xmenu.c (Fx_popup_dialog): Likewise.
3736 * w32menu.c (Fx_popup_dialog): Likewise.
3737
c8add24e
GM
37382012-07-11 Glenn Morris <rgm@gnu.org>
3739
4b575b3c
GM
3740 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
3741 since nothing has defined it on these platforms.
3742
09f4e3b0
GM
3743 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
3744 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
3745
172bedef
GM
3746 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3747 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
3748 Move CLASH_DETECTION to configure.
3749
249685df
GM
3750 * s/gnu.h: Remove file, which is now empty.
3751
c8add24e
GM
3752 * s/gnu.h, s/gnu-linux.h:
3753 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
3754
b41253a3
JW
37552012-07-11 John Wiegley <johnw@newartisans.com>
3756
3757 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
3758 function attribute, so we only use it if it exists in the
3759 compiler.
3760
d923b542
DA
37612012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
3762
3763 Avoid call to strlen in fast_c_string_match_ignore_case.
3764 * search.c (fast_c_string_match_ignore_case): Change to use
3765 length argument. Adjust users accordingly.
3766 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
3767
5ebbef1d
PE
37682012-07-11 Paul Eggert <eggert@cs.ucla.edu>
3769
bb352260
PE
3770 Assume mkdir, rmdir.
3771 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
3772 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
3773
57054ddd
PE
3774 Assume rename.
3775 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
3776
b747d3f7
PE
3777 Assume perror.
3778 * s/hpux10-20.h (HAVE_PERROR): Remove.
3779 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
3780 Remove dummy definition, as this problem was obsolete long ago.
3781
5ebbef1d
PE
3782 Assume strerror.
3783 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
3784
984e7f30
DA
37852012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
3786
3787 Avoid calls to strlen in font processing functions.
3788 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
3789 (font_open_by_name): Change to use length argument.
3790 Adjust users accordingly.
d923b542
DA
3791 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
3792 Adjust prototypes.
3793 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
3794 Change to return ptrdiff_t.
984e7f30
DA
3795 (xfont_list_pattern, xfont_match): Use length returned by
3796 xfont_decode_coding_xlfd.
3797 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
3798
20e94fdd
GM
37992012-07-11 Glenn Morris <rgm@gnu.org>
3800
9d596af3
GM
3801 * s/darwin.h, s/freebsd.h, s/netbsd.h:
3802 Move DONT_REOPEN_PTY to configure.
3803
20e94fdd
GM
3804 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
3805 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
3806
e99a530f
PE
38072012-07-10 Paul Eggert <eggert@cs.ucla.edu>
3808
22ffb973
PE
3809 Remove "#define unix" that is no longer needed (Bug#11905).
3810 * s/aix4-2.h (unix): Remove; no longer needed.
3811
e9a9ae03
PE
3812 EMACS_TIME simplification (Bug#11875).
3813 This replaces macros (which typically do not work in GDB)
3814 with functions, typedefs and enums, making the code easier to debug.
3815 The functional style also makes code easier to read and maintain.
3816 * systime.h: Include <sys/time.h> on all hosts, not just if
3817 WINDOWSNT, since 'struct timeval' is needed in general.
3818 (EMACS_TIME): Now a typedef, not a macro.
3819 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
3820 not macros.
3821 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
3822 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
3823 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
3824 (EMACS_TIME_LE): Now functions, not macros.
3825 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
3826 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
3827 which are not functions. All uses rewritten to use:
3828 (make_emacs_time): New function.
3829 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
3830 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
3831 not functions. All uses rewritten to use the following, respectively:
3832 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
3833 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 3834 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
3835 * fileio.c (Fcopy_file):
3836 * xterm.c (XTflash): Get the current time closer to when it's used.
3837 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
3838
ffacb126
PE
3839 * bytecode.c (targets): Suppress -Woverride-init warnings.
3840
e99a530f
PE
3841 Simplify by avoiding confusing use of strncpy etc.
3842 * doc.c (Fsnarf_documentation):
3843 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
3844 * frame.c (Fmake_terminal_frame):
3845 * gtkutil.c (get_utf8_string):
3846 * lread.c (openp):
3847 * nsmenu.m (ns_update_menubar):
3848 * regex.c (regerror):
3849 Prefer memcpy to strncpy and strncat when either will do.
3850 * fileio.c (Fsubstitute_in_file_name):
3851 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
3852 (menu_separator_name_p):
3853 * nsmenu.m (ns_update_menubar):
3854 Prefer memcmp to strncmp when either will do.
3855 * nsterm.m: Include <ftoastr.h>.
3856 (ns_get_color):
3857 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
3858 Prefer snprintf to strncpy.
3859 * nsterm.m (ns_term_init):
3860 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
3861 * nsterm.m (ns_term_init):
3862 Avoid the need for strncpy, by using build_string or
3863 make_unibyte_string directly. Use dtoastr, not snprintf.
3864 * process.c (Fmake_network_process): Diagnose service names that
3865 are too long, rather than silently truncating them or creating
3866 non-null-terminated names.
3867 (Fnetwork_interface_info): Likewise, for interface names.
3868 * sysdep.c (system_process_attributes) [GNU_LINUX]:
3869 Prefer sprintf to strncat.
3870 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
3871 Prefer vsnprintf to vsprintf + strncpy.
3872
c59592b3
GM
38732012-07-10 Glenn Morris <rgm@gnu.org>
3874
3875 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
3876 Clarify fallback case.
3877
7d7bbefd
DA
38782012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3879
3880 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
3881 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
3882 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 3883 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
3884 where argument type is known to be a Lisp_Cons.
3885
3a4c8000
TT
38862012-07-10 Tom Tromey <tromey@redhat.com>
3887
3888 * bytecode.c (BYTE_CODE_THREADED): New macro.
3889 (BYTE_CODES): New macro. Replaces all old byte-code defines.
3890 (enum byte_code_op): New type.
3891 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
3892 (exec_byte_code): Use them. Use token threading when applicable.
3893
2a0213a6
DA
38942012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3895
3896 Optimize pure C strings initialization.
3897 * lisp.h (make_pure_string): Fix prototype.
3898 (build_pure_c_string): New function, defined as static inline. This
3899 provides a better opportunity to optimize away calls to strlen when
3900 the function is called with compile-time constant argument.
3901 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
3902 argument, adjust users accordingly. Use build_pure_c_string where
3903 appropriate.
3904 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
3905 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
3906 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
3907
cb1caeaf
DA
39082012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3909
3910 Avoid calls to strlen in miscellaneous functions.
3911 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
3912 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
3913 * lread.c (openp): Likewise.
3914
c293e30c
DA
39152012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3916
3917 Avoid calls to strlen in path processing functions.
3918 * fileio.c (file_name_as_directory): Add comment. Change to add
3919 srclen argument and return the length of result. Adjust users
3920 accordingly.
3921 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
3922 swap 1st and 2nd arguments to obey the common convention.
3923 Adjust users accordingly.
c293e30c
DA
3924 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
3925
9e059e3f
GM
39262012-07-10 Glenn Morris <rgm@gnu.org>
3927
d02eb359
GM
3928 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
3929 Move PENDING_OUTPUT_COUNT definition to configure.
3930
882cf227
GM
3931 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
3932 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
3933 * s/gnu.h (DATA_START): Move definitions to configure.
3934
af6e839f
GM
3935 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
3936 We include usg5-4-common.h, which defines them both.
3937
40289a12
GM
3938 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
3939 O_RDONLY already includes it).
3940
9e059e3f
GM
3941 Stop ns builds setting the EMACSLOADPATH environment variable.
3942 * nsterm.m (ns_load_path): Rename from ns_init_paths.
3943 Now it does not set EMACSLOADPATH, just returns the load-path string.
3944 * nsterm.h: Update accordingly.
3945 * lread.c [HAVE_NS]: Include nsterm.h.
3946 (init_lread) [HAVE_NS]: Use ns_load_path.
3947 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
3948
7c4e8ec0
GM
39492012-07-09 Glenn Morris <rgm@gnu.org>
3950
d4f600ff
GM
3951 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
3952 since the included bsd-common.h does so.
3953
cbb31951
GM
3954 Stop ns builds setting the EMACSPATH environment variable.
3955 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
3956 (ns_init_paths): Do not set EMACSPATH.
3957 * nsterm.h (ns_exec_path): Add it.
3958 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
3959 Use ns_exec_path.
3960
7c4e8ec0
GM
3961 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
3962
26bccfae
PE
39632012-07-09 Paul Eggert <eggert@cs.ucla.edu>
3964
a0bee46f
PE
3965 * process.c (wait_reading_process_output): 'waitchannels' was unset
3966 when read_kbd || !NILP (wait_for_cell); fix this.
3967
5994c183
PE
3968 Add GCC-style 'const' attribute to functions that can use it.
3969 * character.h (char_resolve_modifier_mask):
3970 * keyboard.h (make_ctrl_char):
3971 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
3972 (init_character_once, next_almost_prime, init_fns, init_image)
3973 (flush_pending_output, init_sound):
3974 * mem-limits.h (start_of_data):
3975 * menu.h (finish_menu_items):
3976 Add ATTRIBUTE_CONST.
3977 * emacs.c (DEFINE_DUMMY_FUNCTION):
3978 Declare the dummy function with ATTRIBUTE_CONST.
3979 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
3980 Add decls with ATTRIBUTE_CONST.
3981
26bccfae
PE
3982 Minor improvements to make_formatted_string.
3983 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
3984 where int is good enough, as vsprintf returns an int.
3985 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
3986
a8290ec3
DA
39872012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
3988
3989 Use make_formatted_string to avoid double length calculation.
3990 * lisp.h (make_formatted_string): New prototype.
3991 * alloc.c (make_formatted_string): New function.
3992 * buffer.c (Fgenerate_new_buffer_name): Use it.
3993 * dbus.c (syms_of_dbusbind): Likewise.
3994 * editfns.c (Fcurrent_time_zone): Likewise.
3995 * filelock.c (get_boot_time): Likewise.
3996 * frame.c (make_terminal_frame, set_term_frame_name)
3997 (x_report_frame_params): Likewise.
3998 * image.c (gs_load): Likewise.
3999 * minibuf.c (get_minibuffer): Likewise.
4000 * msdos.c (dos_set_window_size): Likewise.
4001 * process.c (make_process): Likewise.
4002 * xdisp.c (ensure_echo_area_buffers): Likewise.
4003 * xsettings.c (apply_xft_settings): Likewise.
4004
d01ba2f1
GM
40052012-07-09 Glenn Morris <rgm@gnu.org>
4006
4007 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
4008 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
4009 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
4010 * nsterm.h (ns_etc_directory): Add it.
4011 * callproc.c [HAVE_NS]: Include nsterm.h.
4012 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
4013
f1f924b6
DA
40142012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
4015
4016 Move marker debugging code under MARKER_DEBUG.
4017 * marker.c (MARKER_DEBUG): Move marker debugging code under
4018 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
4019 for bootstrap with --enable-checking (~3x slowdown reported
4020 by Juanma Barranquero <lekktu@gmail.com>).
4021 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
4022
ab531b66
PE
40232012-07-08 Paul Eggert <eggert@cs.ucla.edu>
4024
4025 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
4026 See <http://bugs.gnu.org/11825#29>.
4027
c4b3bc8a
EZ
40282012-07-08 Eli Zaretskii <eliz@gnu.org>
4029
4030 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
4031 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
4032 (display_line): Add commentary about displaying truncation glyphs
4033 on GUI frames.
4034 (produce_special_glyphs): Move here from term.c.
4035
4036 * term.c (produce_special_glyphs): Move to xdisp.c.
4037
4038 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
4039 section.
c4b3bc8a 4040
b676b881
AS
40412012-07-07 Andreas Schwab <schwab@linux-m68k.org>
4042
f17c5273
AS
4043 * xdisp.c (display_line): Avoid warning about implicit declaration
4044 of FRAME_FONT.
4045
298819b9
AS
4046 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
4047
b676b881
AS
4048 * lisp.h: Remove empty conditional.
4049
6045c4fd
PE
40502012-07-07 Paul Eggert <eggert@cs.ucla.edu>
4051
b3350bf9
PE
4052 * lread.c (load_path_check): Now static.
4053
6045c4fd
PE
4054 Fix some minor --with-ns problems found by static checking.
4055 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
4056 (x_set_font) [!HAVE_X_WINDOWS]:
4057 * image.c (xpm_load_image) [HAVE_NS]:
4058 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
4059 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
4060 Remove unused local.
4061 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
4062 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
4063 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
4064 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
4065 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
4066 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
4067 Fix pointer signedness problem.
4068 * xfaces.c (FRAME_X_FONT_TABLE):
4069 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
4070
929e7845
GM
40712012-07-07 Glenn Morris <rgm@gnu.org>
4072
4073 * lread.c (load_path_check): New function, split from init_lread.
4074 (init_lread): Reorganize. Motivation:
4075 If EMACSLOADPATH is set, check/warn about that rather than the
4076 defaults, which we are not going to use. Hence we can remove
4077 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
4078 Don't warn if site-lisp directories are missing.
4079 If not installed, start from a blank load-path, since
4080 PATH_LOADSEARCH refers to the eventual installation directories.
4081
58dd0aa4
EZ
40822012-07-07 Eli Zaretskii <eliz@gnu.org>
4083
4084 Support truncation and continuation glyphs on GUI frames, when
4085 fringes are disabled. (Bug#11832)
4086 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
4087 continuation glyphs even if on GUI frames.
4088 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
4089 or both, are absent.
4090 (start_display, move_it_in_display_line_to): Handle the case of a
4091 GUI frame without a fringe to display continuation or truncation
4092 glyphs.
4093 (insert_left_trunc_glyphs): Support GUI frames: make sure
4094 truncation glyphs overwrite enough glyphs from the current line to
4095 have sufficient space in pixels.
4096 (display_line): Support truncation and continuation glyphs on GUI
4097 frames. If some spare pixels are left on the line after inserting
4098 the truncation glyphs, fill that space with a stretch glyph of a
4099 suitably computed width.
4100
4101 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
4102 produce_glyphs, to support GUI sessions.
4103
31571fd7
PE
41042012-07-07 Paul Eggert <eggert@cs.ucla.edu>
4105
5a16b9bc
PE
4106 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
4107
f3047c75
PE
4108 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
4109
31571fd7
PE
4110 Do not require float-time's arg to fit in time_t (Bug#11825).
4111 This works better on hosts where time_t is unsigned, and where
4112 float-time is applied to the (negative) difference between two times.
4113 * editfns.c (decode_time_components): Last arg is now double *,
4114 not int *, and means to store all the result as a double, without
4115 worrying about whether the seconds part fits in time_t.
4116 All callers changed.
4117 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
4118 All callers changed.
4119 (Ffloat_time): Do not fail merely because the specified time falls
4120 outside of time_t range.
4121
4516fbef
GM
41222012-07-07 Glenn Morris <rgm@gnu.org>
4123
4124 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
4125 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
4126 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
4127
07adc2c6
JB
41282012-07-07 Juanma Barranquero <lekktu@gmail.com>
4129
4130 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
4131 Update dependencies.
4132
4133 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
4134
fd573f31
PE
41352012-07-06 Paul Eggert <eggert@cs.ucla.edu>
4136
fee5959d
PE
4137 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
4138 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
4139 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
4140 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
4141 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
4142 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
4143
fd573f31
PE
4144 * xfont.c (compare_font_names): Redo to omit the need for casts.
4145
ddadbc0e
AS
41462012-07-06 Andreas Schwab <schwab@linux-m68k.org>
4147
fca8d6b6
AS
4148 * xfns.c (Fx_change_window_property): Doc fix.
4149 * w32fns.c (Fx_change_window_property): Doc fix.
4150
ddadbc0e
AS
4151 * w32fns.c (Fx_window_property): Accept the same arguments as the
4152 X Windows version. Doc fix.
4153 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
4154
ed9265fc 41552012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
4156 Eli Zaretskii <eliz@gnu.org>
4157
4158 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
4159 Windows-specific code from nt/config.nt moved here.
4160 Obsolete settings removed.
4161
216ee680
PE
41622012-07-06 Paul Eggert <eggert@cs.ucla.edu>
4163
4164 * process.c: Avoid unnecessary calls to gettime.
4165 (wait_reading_process_output): Don't get the time of day
4166 when gobbling data immediately and not waiting, as there's no need
4167 for it in that case. This removes a FIXME.
4168
bdd091e4
JD
41692012-07-06 Jan Djärv <jan.h.d@swipnet.se>
4170
4171 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
4172 is defined (Bug#11768).
4173
9d44f8ce
DA
41742012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4175
4176 Fix marker debugging code.
4177 * marker.c (byte_char_debug_check): Do not perform the check
4178 if buffer is not multibyte.
090bd7cb
JB
4179 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
4180 Call byte_char_debug_check with correct arguments.
9d44f8ce 4181
90fc4786
DA
41822012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4183
4184 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
4185 * marker.c (byte_char_debug_check, count_markers):
4186 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
4187 (byte_debug_flag): Remove.
4188 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
4189 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
4190
7b7ae965
DA
41912012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4192
4e57b342
DA
4193 Avoid code repetition in marker-related functions.
4194 * marker.c (attach_marker): New function.
4195 (Fset_marker, set_marker_restricted, set_marker_both)
4196 (set_marker_restricted_both): Use it.
4197 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
4198 Consistently rename charno to charpos.
4199 (marker_position): Add eassert.
4200 (marker_byte_position): Convert to eassert.
4201
42022012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4203
4204 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 4205 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 4206 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 4207
657924ff
DA
42082012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4209
4210 Introduce fast path for the widely used marker operation.
4211 * alloc.c (build_marker): New function.
4212 * lisp.h (build_marker): New prototype.
4213 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
4214 * composite.c (autocmp_chars): Likewise.
4215 * editfns.c (buildmark): Remove.
4216 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
4217 (save_restriction_save): Use build_marker.
4218 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
4219 * window.c (save_window_save): Likewise.
4220
041a49a6
DA
42212012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4222
4223 Do not use Fdelete_overlay in delete_all_overlays
4224 to avoid redundant calls to unchain_overlay.
4225 * buffer.c (drop_overlay): New function.
4226 (delete_all_overlays, Fdelete_overlay): Use it.
4227 * minibuf.c (get_minibuffer): Fix comment.
4228
7dca65a4
PE
42292012-07-06 Paul Eggert <eggert@cs.ucla.edu>
4230
4231 Port to OpenBSD 5.1 amd64.
4232 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
4233 This is needed for OpenBSD, and should be harmless on all BSD systems.
4234 Also, include <sys/sysctl.h>, as it should be available on all
4235 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
4236 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
4237 use p_pid member, not kp_proc.pid.
4238
8eb876e2
GM
42392012-07-06 Glenn Morris <rgm@gnu.org>
4240
4241 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
4242
38182d90
PE
42432012-07-05 Paul Eggert <eggert@cs.ucla.edu>
4244
4245 More xmalloc and related cleanup.
4246 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
4247 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
4248 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
4249 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
4250 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
4251 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
4252 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
4253 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
4254 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
4255 * xterm.c:
4256 Omit needless casts involving void * pointers and allocation.
4257 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
4258 as the former is more robust if P's type is changed.
4259 Prefer xzalloc to xmalloc + memset 0.
4260 Simplify malloc-or-realloc to realloc.
4261 Don't worry about xmalloc returning a null pointer.
4262 Prefer xstrdup to xmalloc + strcpy.
4263 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
4264 growing it.
4265 * keyboard.c (apply_modifiers_uncached): Prefer local array to
4266 alloca of a constant.
4267
6dd5a677
EZ
42682012-07-05 Eli Zaretskii <eliz@gnu.org>
4269
4270 * xdisp.c (display_line): Fix horizontal pixel coordinates when
4271 hscroll is larger than the line width. Fixes long and futile
4272 looping inside extend_face_to_end_of_line (on a TTY) producing
4273 glyphs that are not needed and thrown away.
4274
6b312f0f
DA
42752012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
4276
4277 * marker.c (set_marker_restricted_both): Simplify by using
4278 clip_to_bounds.
4279
f520ef9b
PE
42802012-07-05 Paul Eggert <eggert@cs.ucla.edu>
4281
4282 * editfns.c (region_limit): Simplify by using clip_to_bounds.
4283
383b7c95
JD
42842012-07-05 Jan Djärv <jan.h.d@swipnet.se>
4285
4286 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
4287 not defined (Bug#11768).
4288 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
4289 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
4290 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
4291 followed by gtk_box_set_homogeneous (Bug#11768).
4292 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
4293 (update_theme_scrollbar_width, xg_create_scroll_bar):
4294 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
4295 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
4296 (is_box_type): New function (Bug#11768).
4297 (xg_tool_item_stale_p): Call is_box_type.
5293d758 4298 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
4299 with default display (Bug#11768).
4300
d6e7bf45
EZ
43012012-07-05 Eli Zaretskii <eliz@gnu.org>
4302
4303 * xdisp.c (window_hscroll_limited): New function.
4304 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
4305 coordinates when window's hscroll is set to insanely large
4306 values. (Bug#11857)
4307
431391ec
JB
43082012-07-05 Juanma Barranquero <lekktu@gmail.com>
4309
4310 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
4311 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
4312
23f86fce
DA
43132012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
4314
4315 Cleanup xmalloc.
4316 * lisp.h (xzalloc): New prototype. Omit needless casts.
4317 * alloc.c (xzalloc): New function. Omit needless casts.
4318 * charset.c: Omit needless casts. Convert all calls to
4319 xmalloc with following memset to xzalloc.
4320 * dispnew.c: Likewise.
4321 * fringe.c: Likewise.
4322 * image.c: Likewise.
4323 * sound.c: Likewise.
4324 * term.c: Likewise.
4325 * w32fns.c: Likewise.
4326 * w32font.c: Likewise.
4327 * w32term.c: Likewise.
4328 * xfaces.c: Likewise.
4329 * xfns.c: Likewise.
4330 * xterm.c: Likewise.
4331 * atimer.c: Omit needless casts.
4332 * buffer.c: Likewise.
4333 * callproc.c: Likewise.
4334 * ccl.c: Likewise.
4335 * coding.c: Likewise.
4336 * composite.c: Likewise.
4337 * doc.c: Likewise.
4338 * doprnt.c: Likewise.
4339 * editfns.c: Likewise.
4340 * emacs.c: Likewise.
4341 * eval.c: Likewise.
4342 * filelock.c: Likewise.
4343 * fns.c: Likewise.
4344 * gtkutil.c: Likewise.
4345 * keyboard.c: Likewise.
4346 * lisp.h: Likewise.
4347 * lread.c: Likewise.
4348 * minibuf.c: Likewise.
4349 * msdos.c: Likewise.
4350 * print.c: Likewise.
4351 * process.c: Likewise.
4352 * region-cache.c: Likewise.
4353 * search.c: Likewise.
4354 * sysdep.c: Likewise.
4355 * termcap.c: Likewise.
4356 * terminal.c: Likewise.
4357 * tparam.c: Likewise.
4358 * w16select.c: Likewise.
4359 * w32.c: Likewise.
4360 * w32reg.c: Likewise.
4361 * w32select.c: Likewise.
4362 * w32uniscribe.c: Likewise.
4363 * widget.c: Likewise.
4364 * xdisp.c: Likewise.
4365 * xmenu.c: Likewise.
4366 * xrdb.c: Likewise.
4367 * xselect.c: Likewise.
4368
0497dc44
PE
43692012-07-05 Paul Eggert <eggert@cs.ucla.edu>
4370
4371 * fileio.c (time_error_value): Check the right error number.
4372 Problem reported by Troels Nielsen in
4373 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
4374
356e7178
PE
43752012-07-04 Paul Eggert <eggert@cs.ucla.edu>
4376
4e71fd89
PE
4377 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
4378 This should be fixed in a better way; see Eli Zaretskii in
4379 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
4380 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
4381
f0941253
PE
4382 * fileio.c (time_error_value): Rename from special_mtime.
4383 The old name's problems were noted by Eli Zaretskii in
4384 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
4385
065c9eb4
PE
4386 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
4387 This variable's comment says Emacs needs at least one GDB-visible
4388 symbol of type enum pvec_type, to work around GDB problems.
4389 The symbol's value doesn't matter.
4390
356e7178
PE
4391 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
4392 that causes compilation to fail on pre-C99 compilers.
4393
ed9265fc 43942012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
4395
4396 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
4397 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
4398
3884d954
DA
43992012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
4400
d209e2fb 4401 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
4402 headers for buffer_defaults and buffer_local_symbols.
4403 Reported by Juanma Barranquero <lekktu@gmail.com>.
4404
ee28be33
SM
44052012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4406
4407 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
4408 * lisp.h (enum pvec_type): Use fewer bits.
4409 (PSEUDOVECTOR_SIZE_BITS): New constant.
4410 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
4411 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
4412 change in pvec_type.
4413 (PSEUDOVECTOR_TYPEP): New macro.
4414 (TYPED_PSEUDOVECTORP): Use it.
4415 * fns.c (internal_equal): Adapt code to extract pvectype.
4416 * emacs.c (gdb_pvec_type): Update type.
4417 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
4418 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
4419 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
4420 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
4421 (sweep_vectors): Use it. Use local var `total_bytes' instead of
4422 abusing vector->header.next.nbytes.
4423 (live_vector_p): Use PVEC_TYPE.
4424 (mark_object): Adapt code to extract pvectype. Use switch.
4425
c7f2cd7f
PE
44262012-07-04 Paul Eggert <eggert@cs.ucla.edu>
4427
4428 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
4429 Tighten new eassert a bit.
4430
8ce70ed2
DA
44312012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
4432
4433 Fix compilation with --enable-gcc-warnings and -O1
4434 optimization level.
4435 * doprnt.c (doprnt): Change type of tem to int, initialize
4436 to avoid compiler warning. Add eassert.
4437 * search.c (simple_search): Initialize match_byte to avoid
4438 compiler warning. Add eassert.
4439
dea7f1e5
PE
44402012-07-04 Paul Eggert <eggert@cs.ucla.edu>
4441
24a212eb
PE
4442 Avoid weird behavior with large horizontal scrolls.
4443 Without this change, for example, large hscroll values would
4444 mess up Emacs's display on Fedora 15 x86, presumably due to
4445 overflows in int calculations in the display code.
4446 Also, if buffers had long lines, Emacs would freeze.
4447 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
4448 (set_window_hscroll): New function, containing the old guts of
4449 Fset_window_hscroll. Return the clipped value.
4450 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
4451 This avoids the need to check against PTRDIFF_MAX.
4452
dea7f1e5
PE
4453 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
4454
76046526
DA
44552012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
4456
4457 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
4458
39adff0d
PE
44592012-07-04 Paul Eggert <eggert@cs.ucla.edu>
4460
63807d47
PE
4461 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
4462 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
4463 since GCC 4.4.6 issues a bogus warning for them.
4464
39adff0d
PE
4465 Fix bugs in file timestamp newness comparisons.
4466 * fileio.c (Ffile_newer_than_file_p):
4467 * lread.c (Fload): Use full timestamp resolution of files,
4468 not just the 1-second resolution, so that files that are only
4469 slightly newer still count as newer.
4470 * fileio.c (Ffile_newer_than_file_p): Don't assume file
4471 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
4472
dbeed9a6
PE
44732012-07-03 Paul Eggert <eggert@cs.ucla.edu>
4474
4475 * fileio.c: Improve handling of file time marker. (Bug#11852)
4476 (special_mtime): New function.
4477 (Finsert_file_contents, Fverify_visited_file_modtime):
4478 Use it to set special mtime values consistently.
4479
636334d6
AS
44802012-07-03 Andreas Schwab <schwab@linux-m68k.org>
4481
4482 * fileio.c (Finsert_file_contents): Properly handle st_mtime
4483 marker for non-existing file. (Bug#11852)
4484
e2017fe2
GM
44852012-07-03 Glenn Morris <rgm@gnu.org>
4486
4487 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
4488 and did not make it into globals.h).
4489
404dbd37
TT
44902012-07-03 Tom Tromey <tromey@redhat.com>
4491
4492 * window.c (Fset_window_margins, Fset_window_fringes)
4493 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
4494 * textprop.c (Fprevious_property_change): No longer static.
4495 * syntax.c (Fsyntax_table_p): No longer static.
4496 * process.c (Fget_process, Fprocess_datagram_address): No longer
4497 static.
4498 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
4499 * keyboard.c (Fcommand_execute): No longer static.
4500 Remove EXFUN.
4501 * insdel.c (Fcombine_after_change_execute): No longer static.
4502 * image.c (Finit_image_library): No longer static.
4503 * fileio.c (Fmake_symbolic_link): No longer static.
4504 * eval.c (Ffetch_bytecode): No longer static.
4505 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
4506 * doc.c (Fdocumentation_property, Fsnarf_documentation):
4507 No longer static.
404dbd37
TT
4508 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
4509 static.
4510 * dired.c (Ffile_attributes): No longer static.
4511 * composite.c (Fcomposition_get_gstring): No longer static.
4512 * callproc.c (Fgetenv_internal): No longer static.
4513
4514 * ccl.h: Remove EXFUNs.
4515 * buffer.h: Remove EXFUNs.
4516 * dispextern.h: Remove EXFUNs.
4517 * intervals.h: Remove EXFUNs.
4518 * fontset.h: Remove EXFUN.
4519 * font.h: Remove EXFUNs.
4520 * dosfns.c (system_process_attributes): Remove EXFUN.
4521 * keymap.h: Remove EXFUNs.
4522 * lisp.h: Remove EXFUNs.
4523 * w32term.h: Remove EXFUNs.
4524 * window.h: Remove EXFUNs.
4525 * xsettings.h: Remove EXFUN.
4526 * xterm.h: Remove EXFUN.
4527
8e4fd1e1
GM
45282012-07-03 Glenn Morris <rgm@gnu.org>
4529
4530 * lisp.h (Frandom): Make it visible to C.
4531 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
4532 buffer for invisible buffers. (Bug#1229)
4533
ca95b3eb
DA
45342012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
4535
4536 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
4537 values which aren't power of 2.
14ae4239
BT
4538 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
4539 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
4540 accordingly.
4541
7555c33f
SM
45422012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
4543
4544 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
4545
4546 * alloc.c (mark_object): Revert part of last patch to use `switch'.
4547
d12e8f5a
DA
45482012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
4549
4550 * alloc.c (allocate_vector_block): Remove redundant
4551 calls to mallopt if DOUG_LEA_MALLOC is defined.
4552 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
4553 avoid calls to mallopt if zero_vector is returned.
4554
296094c3
DA
45552012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
4556
4557 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
4558 is enabled, avoid dereferencing NULL current_sblock if
4559 running undumped.
4560
36429c89
DA
45612012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
4562
4563 Cleanup basic buffer management.
4564 * buffer.h (struct buffer): Change layout to use generic vector
4565 marking code. Fix some comments. Change type of 'clip_changed'
4566 to bitfield. Remove unused #ifndef old.
4567 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
4568 (GET_OVERLAYS_AT): Fix indentation.
4569 (for_each_per_buffer_object_at): New macro.
4570 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
4571 (Fbuffer_local_variables): Use it.
4572 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
4573 * alloc.c (allocate_buffer): Adjust to match new layout of
4574 struct buffer. Fix comment.
4575 (mark_overlay): New function.
4576 (mark_buffer): Use it. Use mark_vectorlike to mark normal
4577 Lisp area of struct buffer.
4578 (mark_object): Use it. Adjust marking of misc objects
4579 and related comments.
4580
3b3e4cac
PE
45812012-07-02 Paul Eggert <eggert@cs.ucla.edu>
4582
4583 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
4584 wrapper that is not needed because the wrapped code is a no-op (zero
4585 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
4586 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
4587
cf5c0175
DA
45882012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
4589
4590 * alloc.c (mark_buffer): Simplify. Remove prototype.
4591 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 4592 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
4593 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
4594 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 4595
ca26824c
GM
45962012-06-30 Glenn Morris <rgm@gnu.org>
4597
2e4c5312
GM
4598 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
4599
ca26824c
GM
4600 * epaths.in (PATH_SITELOADSEARCH): New.
4601 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
4602 This is rather than relying on --enable-locallisppath elements
4603 having "site-lisp" in their names. (Bug#10208#25, 11658)
4604
0d23c240
EZ
46052012-06-30 Eli Zaretskii <eliz@gnu.org>
4606
c9240d7a
EZ
4607 * w32proc.c (sys_select): Accept and ignore one more argument.
4608
4609 * w32.c (emacs_gnutls_pull): Call select with one more argument.
4610
0d23c240 4611 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 4612 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
4613
4614 * sysdep.c: Don't include dos.h and dosfns.h.
4615
4616 * process.c (sys_select):
4617 * msdos.c (sys_select): Accept one more argument and ignore it.
4618
4619 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
4620 adapt data types and code to that.
4621
4622 * dosfns.c:
4623 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
4624 which clashes with the gnulib function of the same name.
4625
af5a5a98
AS
46262012-06-30 Andreas Schwab <schwab@linux-m68k.org>
4627
c5e4379c
AS
4628 * font.c (font_style_to_value, font_style_symbolic)
4629 (font_prop_validate_style): Add type checks for values in
4630 font_style_table.
4631
af5a5a98
AS
4632 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
4633 argument.
4634 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
4635 uses.
4636
8d38f461
EZ
46372012-06-29 Eli Zaretskii <eliz@gnu.org>
4638
2e5a6631
EZ
4639 * xdisp.c (try_window_id): Undo last change.
4640
8d38f461
EZ
4641 * w32.c (getwd): Adjust commentary about startup_dir.
4642 (init_environment): Always call sys_access, even in non-MSVC
4643 builds. Don't chdir to the directory of the Emacs executable.
4644 This undoes code from 1997 which was justified by the need to
4645 "avoid conflicts when removing and renaming directories". But its
4646 downside was that every relative file name was being interpreted
4647 relative to the directory of the Emacs executable, which can never
4648 be TRT. In particular, it broke sys_access when called with
4649 relative file names.
4650 (sys_access): Map GetLastError to errno.
4651
2af3565e
DA
46522012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
4653
4654 * window.h (struct window): Change type of 'fringes_outside_margins'
4655 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 4656 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
4657 Adjust comment.
4658 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
4659 to ptrdiff_t.
4660
c8d3a25c 46612012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 4662
c8d3a25c
GM
4663 * gnutls.c (emacs_gnutls_handshake):
4664 Add QUIT to make the loop interruptible.
57570cd3 4665
c8d3a25c 46662012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 4667
c8d3a25c
GM
4668 * charset.c (init_charset): Make lack of etc/charsets fatal.
4669
3e984ee8
DA
46702012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
4671
4672 * editfns.c (region_limit): Fix type mismatch.
4673
ef884f23
DA
46742012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
4675
4676 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
4677 undefined. Convert from xassert to eassert.
4678 * nsmenu.m: Convert from xassert to eassert.
4679 * nsterm.m: Likewise.
4680
7d7e0027
SM
46812012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
4682
4683 * editfns.c (region_limit): Clip to narrowing (bug#11770).
4684
aa754e6a
PE
46852012-06-28 Paul Eggert <eggert@cs.ucla.edu>
4686
4687 Avoid integer overflow on scroll-left and scroll-right.
4688 * window.c (HSCROLL_MAX): New macro.
4689 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
4690 overflow when requested scroll falls outside ptrdiff_t range.
4691
80b00b08
DA
46922012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
4693
4694 * window.h (struct window): Change type of 'hscroll',
4695 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
4696 'last_modified' and 'last_overlay_modified' to EMACS_INT.
4697 Adjust users accordingly.
4698 * xdisp.c (try_cursor_movement): Replace type check with eassert.
4699 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
4700 from EMACS_INT to ptrdiff_t.
4701 (make_window): Omit redundant initialization.
4702
62b2bcf6
JB
47032012-06-28 Juanma Barranquero <lekktu@gmail.com>
4704
4705 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
4706
45942c7d
DA
47072012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
4708
4709 * window.h (struct window): Change type of 'use_time' and
4710 'sequence_number' from Lisp_Object to int.
4711 * frame.c (make_frame): Adjust users accordingly.
4712 * print.c (print_object): Likewise.
4713 * window.c (select_window, Fwindow_use_time, make_parent_window)
4714 (make_window): Likewise.
4715
e509cfa6
DA
47162012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
4717
4718 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
4719 enabled with --enable-checking=[all,glyphs] configure option.
4720 Fix GLYPH_DEBUG usage assuming that it may be undefined,
4721 adjust comments accordingly.
4722 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
4723 undefined, adjust comments accordingly.
4724 * image.c: Likewise.
4725 * scroll.c: Likewise.
4726 * w32fns.c: Likewise.
4727 * w32term.c: Likewise.
4728 * xdisp.c: Likewise.
4729 * xfaces.c: Likewise.
4730 * xfns.c: Likewise.
4731 * xterm.c: Likewise.
4732
a54e2c05
DA
47332012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
4734
4735 Generalize run-time debugging checks.
4736 * dispextern.h (XASSERTS): Remove.
4737 * fontset.c (xassert): Remove.
4738 Convert from xassert to eassert.
4739 * alloc.c: Convert from xassert to eassert.
4740 * bidi.c: Likewise.
4741 * dispnew.c: Likewise.
4742 * fns.c: Likewise.
4743 * fringe.c: Likewise.
4744 * ftfont.c: Likewise.
4745 * gtkutil.c: Likewise.
4746 * image.c: Likewise.
4747 * keyboard.c: Likewise.
4748 * menu.c: Likewise.
4749 * process.c: Likewise.
4750 * scroll.c: Likewise.
4751 * sound.c: Likewise.
4752 * term.c: Likewise.
4753 * w32console.c: Likewise.
4754 * w32fns.c: Likewise.
4755 * w32term.c: Likewise.
4756 * window.c: Likewise.
4757 * xdisp.c: Likewise.
4758 * xfaces.c: Likewise.
4759 * xfns.c: Likewise.
4760 * xselect.c: Likewise.
4761 * xterm.c: Likewise.
4762
1ec4b7b2
SM
47632012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
4764
4765 * fns.c (maybe_resize_hash_table): Output message when growing the
4766 purify-hashtable.
4767
2014308a
DA
47682012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
4769
4770 * alloc.c (allocate_string_data): Remove dead code.
4771 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
4772 avoid GCC warning about unused macro.
4773
246155eb
DA
47742012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
4775
4776 * alloc.c (allocate_string): Omit intervals initialization.
4777 * alloc.c (make_uninit_multibyte_string): Initialize intervals
4778 as in make_pure_string and make_pure_c_string.
4779
43184b7b
DA
47802012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
4781
d209e2fb 4782 * alloc.c (allocate_string): Fix last change.
43184b7b 4783
3fe6dd74
DA
47842012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
4785
d209e2fb 4786 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
4787 to memset, add explicit initialization where appropriate.
4788
1ba6038a
GM
47892012-06-27 Glenn Morris <rgm@gnu.org>
4790
4791 * lisp.mk (lisp): Remove paths.elc.
4792
c89926a5
CY
47932012-06-27 Chong Yidong <cyd@gnu.org>
4794
4795 * doc.c (Fsubstitute_command_keys): Fix punctuation.
4796
ed6b3510
JW
47972012-06-26 John Wiegley <johnw@newartisans.com>
4798
1ec4b7b2 4799 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
4800 on Mac OS X Lion: __mod_init_func and __mod_term_func.
4801
ed6b3510
JW
4802 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
4803 when building with Clang.
4804
8edd4a2b
SM
48052012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
4806
4807 * eval.c (Fapply): Allow calling it with a single argument.
4808
f6f62d1b
EZ
48092012-06-26 Eli Zaretskii <eliz@gnu.org>
4810
4811 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
4812 _stricmp and _strnicmp.
4813 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
4814
62efea5e
DA
48152012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
4816
4817 * alloc.c (allocate_window): Zero out non-Lisp part of newly
4818 allocated window.
4819 (allocate_process): Likewise for new process.
8edd4a2b 4820 (allocate_terminal): Change to use offsetof.
62efea5e
DA
4821 (allocate_frame): Likewise.
4822 * frame.c (make_frame): Omit redundant initialization.
4823 * window.c (make_parent_window): Use memset.
4824 (make_window): Omit redundant initialization.
4825 * process.c (make_process): Omit redundant initialization.
4826 * terminal.c (create_terminal): Likewise.
4827
42997f4d
DA
48282012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
4829
4830 * term.c (delete_tty): Remove redundant call to memset.
4831
1130ecfc
DA
48322012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
4833
4834 * alloc.c: Remove build_string.
4835 * lisp.h: Define build_string as static inline. This provides
4836 a better opportunity to optimize away calls to strlen when the
4837 function is called with compile-time constant argument.
4838 * image.c (imagemagick_error): Convert to build_string.
4839 * w32proc.c (sys_spawnve): Likewise.
4840 * xterm.c (x_term_init): Likewise.
4841
cf38a720
PE
48422012-06-26 Paul Eggert <eggert@cs.ucla.edu>
4843
99027bdd
PE
4844 Use sprintf return value instead of invoking strlen on result.
4845 In the old days this wasn't portable, since some sprintf
4846 implementations returned char *. But they died out years ago and
4847 Emacs already assumes sprintf returns int.
4848 Similarly for float_to_string.
4849 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
4850 * ccl.c (ccl_driver):
4851 * character.c (string_escape_byte8):
4852 * data.c (Fnumber_to_string):
4853 * doprnt.c (doprnt):
4854 * print.c (print_object):
4855 * xdisp.c (message_dolog):
4856 * xfns.c (syms_of_xfns):
4857 Use sprintf or float_to_string result to avoid need to call strlen.
4858 * data.c (Fnumber_to_string):
4859 Use make_unibyte_string, since the string must be ASCII.
4860 * lisp.h, print.c (float_to_string): Now returns int length.
4861 * term.c (produce_glyphless_glyph):
4862 Use sprintf result rather than recomputing it.
4863
cf38a720
PE
4864 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
4865 * Makefile.in (ALL_CFLAGS):
4866 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
4867 * gmalloc.c, regex.c: Include <config.h> unconditionally.
4868
3511c784
DA
48692012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
4870
0a08eb21 4871 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
4872 strcasecmp if available.
4873 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
4874
fb7da12e
AS
48752012-06-25 Andreas Schwab <schwab@linux-m68k.org>
4876
4877 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
4878 Avoid comma operator.
4879 * menu.c (push_submenu_start, push_submenu_end)
4880 (push_left_right_boundary, push_menu_pane): Likewise.
4881 * msdos.c (dos_rawgetc): Likewise.
4882
afa2ffd8
DA
48832012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
4884
4885 * xfns.c (xic_create_fontsetname): Remove redundant calls
4886 to memset.
4887
b3b4476b
PE
48882012-06-25 Paul Eggert <eggert@cs.ucla.edu>
4889
4495ff38
PE
4890 * gtkutil.c (get_utf8_string): Remove redundant assignment.
4891 sprintf already null-terminates its output.
4892
b3b4476b
PE
4893 * xfns.c (x_window): Remove redundant cast.
4894
b00876c9
DA
48952012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
4896
4897 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
4898 `const char *' to `char *' to avoid compiler warning.
4899
d188e26b
PE
49002012-06-24 Paul Eggert <eggert@cs.ucla.edu>
4901
885d1d74
PE
4902 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
4903 instead of truncating it to 63 (admittedly a generous limit).
4904
d188e26b
PE
4905 * process.c: Fix spelling and caps in comments.
4906
e2f560b1
DN
49072012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
4908
e86db54b 4909 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
4910 * sysdep.c (setpgrp): Remove definition, not used in this file.
4911
7583a3a1
JB
49122012-06-24 Juanma Barranquero <lekktu@gmail.com>
4913
4914 * makefile.w32-in: Update dependencies.
4915
696056c2
EZ
49162012-06-24 Eli Zaretskii <eliz@gnu.org>
4917
4918 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
4919 (SYSTIME_H): Add nt/inc/sys/time.h.
4920
4921 * systime.h [WINDOWSNT]: Include sys/time.h.
4922
4923 * s/ms-w32.h (struct timespec): Definition moved from
4924 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
4925
845ca893
PE
49262012-06-24 Paul Eggert <eggert@cs.ucla.edu>
4927
4928 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
4929 * buffer.h (buffer_slot_type_mismatch):
4930 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
4931 * eval.c (unwind_to_catch):
4932 * image.c (my_png_error, my_error_exit):
4933 * keyboard.c (quit_throw_to_read_char, user_error)
4934 (Fexit_recursive_edit, Fabort_recursive_edit):
4935 * lisp.h (die, args_out_of_range, args_out_of_range_3)
4936 (wrong_type_argument, buffer_overflow, __executable_start)
4937 (memory_full, buffer_memory_full, string_overflow, Fthrow)
4938 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
4939 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
4940 (fatal):
4941 (child_setup) [!DOS_NT]:
4942 * lread.c (end_of_file_error, invalid_syntax):
4943 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
4944 * puresize.h (pure_write_error):
4945 * search.c (matcher_overflow):
4946 * sound.c (sound_perror, alsa_sound_perror):
4947 * sysdep.c, syssignal.h (croak):
4948 * term.c (maybe_fatal, vfatal):
4949 * textprop.c (text_read_only):
4950 * undo.c (user_error):
4951 * unexmacosx.c (unexec_error):
4952 * xterm.c (x_ins_del_lines, x_delete_glyphs):
4953 Use _Noreturn rather than NO_RETURN.
4954 No need for separate decl merely because of _Noreturn.
4955 * sound.c (sound_warning, parse_sound):
4956 Remove unnecessary forward decls.
4957
f1dd8073
PE
49582012-06-24 Paul Eggert <eggert@cs.ucla.edu>
4959
4960 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
4961 * lisp.h (WAIT_READING_MAX): New macro.
4962 * dispnew.c (Fsleep_for, sit_for):
4963 * keyboard.c (kbd_buffer_get_event):
4964 * process.c (Faccept_process_output):
4965 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
4966 This improves on the previous patch, which introduced a bug
4967 when time_t is unsigned and as wide as intmax_t.
4968 See <http://bugs.gnu.org/9000#51>.
4969
b82c1755
EZ
49702012-06-23 Eli Zaretskii <eliz@gnu.org>
4971
4972 * dispnew.c (sit_for, Fsleep_for):
4973 * keyboard.c (kbd_buffer_get_event):
4974 * process.c (Faccept_process_output): Avoid compiler warnings when
4975 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
4976
ca300656
JB
49772012-06-23 Juanma Barranquero <lekktu@gmail.com>
4978
049ec95b
JB
4979 * makefile.w32-in: Update dependencies.
4980
ca300656
JB
4981 * w32.c (ltime): Add return type and declare static.
4982 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
4983
db7b8d06
PE
49842012-06-23 Paul Eggert <eggert@cs.ucla.edu>
4985
4986 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
4987 Privately reported by Herbert J. Skuhra.
4988 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
4989 All uses changed.
4990 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
4991 not make_lisp_timeval, when the argument is of type EMACS_TIME.
4992
0bd8297f
EZ
49932012-06-23 Eli Zaretskii <eliz@gnu.org>
4994
96512555
EZ
4995 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
4996 last argument of make_unibyte_string.
4997
0bd8297f
EZ
4998 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
4999 language ID in the event parameters.
5000
5001 * w32term.c (w32_read_socket): Put the new keyboard codepage into
5002 event.code, not the obscure "character set ID".
5003
63def6b6
CY
50042012-06-23 Chong Yidong <cyd@gnu.org>
5005
5006 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
5007
e8a02204
EZ
50082012-06-23 Eli Zaretskii <eliz@gnu.org>
5009
388cdec0
EZ
5010 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
5011 * w32.c (fdutimens): New function.
5012
5013 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
5014
5015 * s/ms-w32.h (pselect): Redirect to sys_select.
5016
5017 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
5018
e8a02204
EZ
5019 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
5020 in the logic of incrementing and decrementing the value of
5021 use_relocatable_buffers.
5022
d054f3fb
PE
50232012-06-23 Paul Eggert <eggert@cs.ucla.edu>
5024
5025 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
5026 Privately reported by Herbert J. Skuhra.
5027 [__FreeBSD__]: Remove "*/" typo after "#include".
5028 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
5029 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
5030 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
5031 Don't assume EMACS_TIME and struct timeval are the same type.
5032
d35af63c
PE
50332012-06-22 Paul Eggert <eggert@cs.ucla.edu>
5034
5035 Support higher-resolution time stamps (Bug#9000).
5036 The time stamps are only nanosecond-resolution at the C level,
5037 since that's the best that any real-world system supports now.
5038 But they are picosecond-resolution at the Lisp level, as that's
5039 easy, and leaves room for future OS improvements.
5040
5041 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
5042 (LIBES): Use it.
5043
5044 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
5045 Don't get current time unless it's needed.
5046
5047 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
5048 now provides it if it's absent.
5049 (start_atimer): Port to higher-res time stamps.
5050 Check for time stamp overflow. Don't get current time more
5051 often than is needed.
5052
5053 * buffer.h (struct buffer): Buffer modtime now has high resolution.
5054 Include systime.h, not time.h.
5055 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
5056
5057 * dired.c: Include stat-time.h.
5058 (Ffile-attributes): File times now have higher resolution.
5059
5060 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
5061 (struct image): Timestamp now has higher resolution.
5062
5063 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
5064 has at least microseconds now. All uses removed.
5065 (update_frame, update_single_window, update_window, update_frame_1)
5066 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
927c7216 5067 (duration_to_sec_usec): Remove; no longer needed.
d35af63c
PE
5068
5069 * editfns.c (time_overflow): Now extern.
5070 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
5071 (float-time, Fformat_time_string, Fcurrent_time_string)
5072 (Fcurrent_time_zone): Accept and generate higher-resolution
5073 time stamps.
5074 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
5075 (decode_time_components, lisp_seconds_argument): New functions.
5076 (make_time): Now static.
5077 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
5078 Report an error if the time is invalid, rather than having the caller
5079 do that.
5080
5081 * fileio.c: Include <stat-time.h>
5082 (Fcopy_file): Copy higher-resolution time stamps.
5083 Prefer to set the time stamp via a file descriptor if that works.
5084 (Fset_file_times, Finsert_file_contents, Fwrite_region)
5085 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
5086 (Fvisited_file_modtime, Fset_visited_file_modtime):
5087 Support higher-resolution time stamps.
5088
5089 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
5090
5091 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
5092
5093 * image.c (prepare_image_for_display, clear_image_cache)
5094 (lookup_image): Port to higer-resolution time stamps.
5095
5096 * keyboard.c (start_polling, bind_polling_period):
5097 Check for time stamp overflow.
5098 (read_char, kbd_buffer_get_event, timer_start_idle)
5099 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
5100 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
5101 Port to higher-resolution time stamps. Do not assume time_t is signed.
5102 (decode_timer): New function. Timers are now vectors of length 9,
5103 not 8, to accommodate the picosecond component.
5104 (timer_check_2): Use it.
5105
5106 * nsterm.m (select_timeout, timeval_subtract): Remove.
5107 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
5108 as they're a bit more accurate and handle overflow better.
5109 (ns_select): Change prototype to be compatible with pselect.
5110 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
5111 * nsterm.h (ns_select): Adjust prototype.
5112
5113 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
5114 us-resolution time stamps.
5115 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
5116
5117 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
5118
5119 * lisp.h (time_overflow): New decl.
5120 (wait_reading_process_output): First arg is now intmax_t, not int,
5121 to accommodate larger waits.
5122
5123 * process.h (struct Lisp_Process.read_output_delay):
5124 Now counts nanoseconds, not microseconds.
5125 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
5126 EMACS_HAS_USECS.
5127 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
5128 (wait_reading_process_output):
5129 Port to ns-resolution time stamps.
5130 (Faccept_process_output, wait_reading_process_output):
5131 Check for time stamp overflow. Do not assume time_t is signed.
5132 (select_wrapper): Remove; we now use pselect.
5133 (Fprocess_attributes): Now generates ns-resolution time stamps.
5134
5135 * sysdep.c: Include utimens.h. Don't include utime.h
5136 or worry about struct utimbuf; gnulib does that for us now.
5137 (gettimeofday): Remove; gnulib provides a substitute.
5138 (make_timeval): New function.
5139 (set_file_times): Now sets ns-resolution time stamps.
5140 New arg FD; all uses changed.
5141 (time_from_jiffies, ltime_from_jiffies, get_up_time)
5142 (system_process_attributes):
5143 Now returns ns-resolution time stamp. All uses changed.
5144 Check for time stamp overflow.
5145
5146 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
5147 provides a substitute now.
5148
5149 * systime.h: Include timespec.h rather than sys/time.h and time.h,
5150 since it guarantees struct timespec.
5151 (EMACS_TIME): Now struct timespec, so that we can support
5152 ns-resolution time stamps.
5153 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
5154 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
5155 (EMACS_USECS): Remove.
5156 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
5157 so multiply the arg by 1000 before storing it.
5158 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
5159 New macros.
5160 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
5161 Port to ns-resolution time stamps.
5162 (EMACS_TIME_NEG_P): Remove; replaced by....
5163 (EMACS_TIME_SIGN): New macro.
5164 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
5165 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
5166 (set_file_times, make_time, lisp_time_argument): Adjust signature.
5167 (make_timeval, make_lisp_time, decode_time_components): New decls.
5168 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
5169 that it mishandled time_t overflow. You can't compare by subtracting!
5170 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
5171 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
5172
5173 * term.c: Include <sys/time.h>.
5174 (timeval_to_Time): New function, for proper overflow wraparound.
5175 (term_mouse_position, term_mouse_click): Use it.
5176
5177 * undo.c (record_first_change): Support higher-resolution time stamps
5178 in the undo buffer.
5179 (Fprimitive_undo): Use them when restoring time stamps.
5180
5181 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
5182 (w32_get_internal_run_time):
5183 Port to higher-resolution Emacs time stamps.
5184 (ltime): Now accepts single 64-bit integer, as that's more convenient
5185 for callers.
5186
5187 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
5188
5189 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
5190 for compatibility with pselect. Support ns-resolution time stamps.
5191
5192 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
5193
5194 * xselect.c (wait_for_property_change, x_get_foreign_selection):
5195 Check for time stamp overflow, and support ns-resolution time stamps.
5196
5197 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
5198 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
5199 (timeval_subtract): Remove; no longer needed.
5200 (XTflash, XTring_bell, x_wait_for_event):
5201 Port to ns-resolution time stamps. Don't assume time_t is signed.
5202
b6a92dfe
CY
52032012-06-22 Chong Yidong <cyd@gnu.org>
5204
5205 * xdisp.c (x_consider_frame_title): Revert last change.
5206
d251c37c
EZ
52072012-06-22 Eli Zaretskii <eliz@gnu.org>
5208
5209 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
5210 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
5211 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
5212 staticidx goes up to 1597 out of 1600 = 0x640.)
5213
f10deafb
PE
52142012-06-20 Paul Eggert <eggert@cs.ucla.edu>
5215
5216 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
5217 Otherwise, the umask might be mistakenly 0 while handling input signals.
5218
ec6de1e2
SM
52192012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
5220
5221 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
5222
28be1ada
DA
52232012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
5224
5225 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
5226 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
5227 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
5228 access to `contents' member of Lisp_Vector objects with AREF and ASET
5229 where appropriate.
5230
c6bf3022
CY
52312012-06-19 Chong Yidong <cyd@gnu.org>
5232
5233 * frame.c (delete_frame): When selecting a frame on a different
5234 text terminal, do not alter the terminal's top-frame.
5235
5236 * xdisp.c (format_mode_line_unwind_data): Record the target
5237 frame's selected window and its terminal's top-frame.
5238 (unwind_format_mode_line): Restore them.
5239 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
5240 Callers changed.
5241 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
5242 since tty frames can be explicitly named.
5243 (prepare_menu_bars): Likewise.
5244
5245 * term.c (Ftty_top_frame): New function.
5246
defd4196
PE
52472012-06-18 Paul Eggert <eggert@cs.ucla.edu>
5248
5249 Port byte-code-meter to modern targets.
5250 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
5251 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 5252 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
5253 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
5254 (METER_1, METER_2): Simplify.
5255
1053a871
SM
52562012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
5257
5258 * data.c (Fdefalias): Return `symbol' (bug#11686).
5259
b7e8d081
MR
52602012-06-18 Martin Rudalics <rudalics@gmx.at>
5261
5262 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
5263 gets killed during executing of this function (Bug#11665).
5264 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
5265 (Vkill_buffer_query_functions): In doc-string say that functions
5266 run by this hook should not change the current buffer.
5267
7ea2b339
PE
52682012-06-18 Paul Eggert <eggert@cs.ucla.edu>
5269
5270 Fix recently-introduced process.c problems found by static checking.
5271 * process.c (write_queue_push, write_queue_pop, send_process):
5272 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
5273 (write_queue_pop): Fix pointer signedness problem.
5274 (send_process): Remove unused local.
5275
96a313a1
CY
52762012-06-17 Chong Yidong <cyd@gnu.org>
5277
5278 * xdisp.c (redisplay_internal): No need to redisplay terminal
5279 frames that are not on top.
5280
20ca2e94
TN
52812012-06-17 Troels Nielsen <bn.troels@gmail.com>
5282
5283 * process.c (make_process): Initialize write_queue.
5284 (write_queue_push, write_queue_pop): New functions.
5285 (send_process): Use them to maintain correct ordering of process
5286 writes (Bug#10815).
5287
9a900ca9
PE
52882012-06-17 Paul Eggert <eggert@cs.ucla.edu>
5289
310fbfa8
PE
5290 * lisp.h (eassert): Assume C89 or later.
5291 This removes the need for CHECK.
5292 (CHECK): Remove. Its comments about always evaluating its
5293 argument were confusing, as 'eassert' typically does not evaluate
5294 its argument.
5295
27bb1ca4
PE
5296 * coding.c (produce_chars): Use ptrdiff_t, not int.
5297
9a900ca9
PE
5298 * xterm.c (x_draw_underwave): Check for integer overflow.
5299 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
5300
41b7f8bc 53012012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
5302
5303 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
5304 referenced (Bug#11583).
5305
9b0e3eba
AA
53062012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
5307
5308 Implement wave-style variant of underlining.
5309 * dispextern.h (face_underline_type): New enum.
5310 (face): Add field for underline type.
5311 * nsterm.m (ns_draw_underwave): New function.
5312 (ns_draw_text_decoration): Use it.
5313 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
5314 New functions.
5315 (x_draw_glyph_string): Use them.
5316 * xfaces.c (Qline, Qwave): New Lisp objects.
5317 (check_lface_attrs, merge_face_ref)
1053a871
SM
5318 (Finternal_set_lisp_face_attribute, realize_x_face):
5319 Handle wave-style underline face attributes.
9b0e3eba
AA
5320 * xterm.c (x_draw_underwave): New function.
5321 (x_draw_glyph_string): Use it.
5322
0fb52f11
JB
53232012-06-16 Juanma Barranquero <lekktu@gmail.com>
5324
5325 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
5326 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
5327 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
5328 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
5329 ($(BLD)/w32select.$(O)): Update dependencies.
5330
e5560ff7
AS
53312012-06-16 Andreas Schwab <schwab@linux-m68k.org>
5332
5333 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
5334 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
5335 * character.c (_fetch_multibyte_char_p): Remove.
5336 * alloc.c: Include "character.h" before "buffer.h".
5337 * bidi.c: Likewise.
5338 * buffer.c: Likewise.
5339 * bytecode.c: Likewise.
5340 * callint.c: Likewise.
5341 * callproc.c: Likewise.
5342 * casefiddle.c: Likewise.
5343 * casetab.c: Likewise.
5344 * category.c: Likewise.
5345 * cmds.c: Likewise.
5346 * coding.c: Likewise.
5347 * composite.c: Likewise.
5348 * dired.c: Likewise.
5349 * dispnew.c: Likewise.
5350 * doc.c: Likewise.
5351 * dosfns.c: Likewise.
5352 * editfns.c: Likewise.
5353 * emacs.c: Likewise.
5354 * fileio.c: Likewise.
5355 * filelock.c: Likewise.
5356 * font.c: Likewise.
5357 * fontset.c: Likewise.
5358 * fringe.c: Likewise.
5359 * indent.c: Likewise.
5360 * insdel.c: Likewise.
5361 * intervals.c: Likewise.
5362 * keyboard.c: Likewise.
5363 * keymap.c: Likewise.
5364 * lread.c: Likewise.
5365 * macros.c: Likewise.
5366 * marker.c: Likewise.
5367 * minibuf.c: Likewise.
5368 * nsfns.m: Likewise.
5369 * nsmenu.m: Likewise.
5370 * print.c: Likewise.
5371 * process.c: Likewise.
5372 * regex.c: Likewise.
5373 * region-cache.c: Likewise.
5374 * search.c: Likewise.
5375 * syntax.c: Likewise.
5376 * term.c: Likewise.
5377 * textprop.c: Likewise.
5378 * undo.c: Likewise.
5379 * unexsol.c: Likewise.
5380 * w16select.c: Likewise.
5381 * w32fns.c: Likewise.
5382 * w32menu.c: Likewise.
5383 * window.c: Likewise.
5384 * xdisp.c: Likewise.
5385 * xfns.c: Likewise.
5386 * xmenu.c: Likewise.
5387 * xml.c: Likewise.
5388 * xselect.c: Likewise.
5389
2f07e6af
EZ
53902012-06-16 Eli Zaretskii <eliz@gnu.org>
5391
1053a871
SM
5392 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
5393 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 5394 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
5395 row.
5396 (handle_face_prop): Use chunk-relative overlay string index when
5397 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
5398 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
5399 the rightmost. (Bug#11720)
2f07e6af 5400
29b83cec
AS
54012012-06-16 Andreas Schwab <schwab@linux-m68k.org>
5402
5403 * category.h (CHAR_HAS_CATEGORY): Define as inline.
5404 (CATEGORY_MEMBER): Enforce 1/0 value.
5405 * category.c (_temp_category_set): Remove.
5406
4c5501e9
EZ
54072012-06-16 Eli Zaretskii <eliz@gnu.org>
5408
5409 * window.c (Fdelete_other_windows_internal)
5410 (Fdelete_window_internal): Don't access frame's mouse highlight
5411 info of the initial frame. (Bug#11677)
5412
2b570124
PE
54132012-06-14 Paul Eggert <eggert@cs.ucla.edu>
5414
e93864f9
PE
5415 * .gdbinit (xgetint): Fix recently-introduced paren typo.
5416 Assume USE_2_TAGS_FOR_INTS.
5417 (xreload): Adjust $tagmask width to match recent lisp.h change.
5418
2b570124
PE
5419 Simplify lisp.h in minor ways that should not affect code.
5420 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
5421 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
5422 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
5423 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
5424 (INTTYPEBITS): New macro, for clarity.
5425 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
5426 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
5427 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
5428 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
5429 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
5430
81755f69
JB
54312012-06-13 Juanma Barranquero <lekktu@gmail.com>
5432
5433 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
5434
16192a57
GM
54352012-06-13 Glenn Morris <rgm@gnu.org>
5436
5437 * s/bsd-common.h (BSD4_3):
5438 * s/usg5-4-common.h (USG5_4): No longer define; unused.
5439
646b5f55
AS
54402012-06-13 Andreas Schwab <schwab@linux-m68k.org>
5441
5442 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
5443 instead of union.
5444 (XLI, XIL): Define.
1053a871
SM
5445 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
5446 Use them.
5447 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 5448 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 5449 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
5450 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
5451 * frame.c (delete_frame): Remove outdated comment.
5452 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
5453 USE_LISP_UNION_TYPE.
5454 (Fw32_unregister_hot_key): Likewise.
5455 (Fw32_toggle_lock_key): Likewise.
5456 * w32menu.c (add_menu_item): Likewise.
5457 (w32_menu_display_help): Use XIL instead of checking
5458 USE_LISP_UNION_TYPE.
5459 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
5460 (init_heap): Likewise.
5461 * w32term.c (w32_read_socket): Update comment.
5462
1d3823c9
GM
54632012-06-13 Glenn Morris <rgm@gnu.org>
5464
c62ff706
GM
5465 * s/usg5-4-common.h, src/s/unixware.h:
5466 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
5467
1d3823c9
GM
5468 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
5469
bfe3e0a2
PE
54702012-06-13 Paul Eggert <eggert@cs.ucla.edu>
5471
5472 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
5473 * alloc.c (make_number) [!defined make_number]:
5474 Remove, as lisp.h always defines this now.
5475 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
5476 (roundup_size): Verify that it is a power of 2.
5477 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
5478 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
5479 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
5480 -DUSE_LSB_TAG=0, to override the automatically-selected default.
5481 USE_LSB_TAG now is always defined to be either 0 or 1.
5482 All uses changed.
5483 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
5484 code works fine either way, and efficiency is not a concern here,
5485 as the union type is for debugging, not for production.
5486 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
5487 Use an inline function on all platforms when using the union type,
5488 since this is simpler and 'static inline' can be used portably
5489 within Emacs now.
5490 (LISP_INITIALLY_ZERO): New macro.
5491 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
5492 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
5493
45fa9c0f
GM
54942012-06-12 Glenn Morris <rgm@gnu.org>
5495
b4492cba
GM
5496 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
5497
5498 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 5499
45fa9c0f
GM
5500 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
5501 Move BROKEN_SIGIO to configure.
5502
5503 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
5504 Move NO_TERMIO to configure.
5505
0e25d334
CY
55062012-06-12 Chong Yidong <cyd@gnu.org>
5507
5508 * image.c (imagemagick_load_image): Use MagickFlattenImage if
5509 MagickMergeImageLayers is undefined. Use pixel pusher loop if
5510 MagickExportImagePixels is undefined.
5511
43682bb6
PE
55122012-06-12 Paul Eggert <eggert@cs.ucla.edu>
5513
5514 * image.c (imagemagick_load_image): Remove unused label.
5515
a9be7d2b
GM
55162012-06-11 Glenn Morris <rgm@gnu.org>
5517
5518 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
5519 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
5520 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
5521 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
5522
3017f87f
SM
55232012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
5524
5525 * alloc.c (make_byte_code): New function.
5526 (Fmake_byte_code): Use it. Don't purify here.
5527 * lread.c (read1): Use it as well to avoid extra allocation.
5528
1b9b4cf4
CY
55292012-06-11 Chong Yidong <cyd@gnu.org>
5530
5531 * image.c (imagemagick_load_image): Implement transparency.
5532
95988fcf
AS
55332012-06-10 Andreas Schwab <schwab@linux-m68k.org>
5534
5535 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
5536 account for preceding backslashes. (Bug#11663)
5537
cd4eb164
CY
55382012-06-09 Chong Yidong <cyd@gnu.org>
5539
5540 * term.c: Support italics in capable terminals (Bug#9652).
5541 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
5542 (turn_on_face): Output using TS_enter_italic_mode if available.
5543 Don't handle unused blinking and alt-charset cases.
5544 (turn_off_face): Handle italic case; discard unused tty_blinking_p
5545 and tty_alt_charset_p cases.
5546 (tty_capable_p, init_tty): Support italics.
5547
5548 * termchar.h (struct tty_display_info): Add field for italics.
5549 Remove unused blink field.
5550
5551 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
5552 Handle slant.
5553
5554 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
5555 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
5556 tty_alt_charset_p. Add tty_italic_p.
5557
ff88beb8
MA
55582012-06-09 Michael Albinus <michael.albinus@gmx.de>
5559
5560 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
5561 dbus_type_is_basic if available.
5562 (xd_extract_signed, xd_extract_unsigned): Rename from
5563 extract_signed and extract_unsigned, respectively. Adapt callers.
5564
44286096
CY
55652012-06-09 Chong Yidong <cyd@gnu.org>
5566
1682701f
CY
5567 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
5568
44286096
CY
5569 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
5570 case (Bug#9752).
5571
d86feb17
PE
55722012-06-08 Paul Eggert <eggert@cs.ucla.edu>
5573
5574 * xdisp.c (vmessage): Treat frame message as multibyte.
5575 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
5576 would generate the diagnostic "Making \302\247 buffer-local while
5577 let-bound!".
5578
d5c20fe8
EZ
55792012-06-08 Eli Zaretskii <eliz@gnu.org>
5580
5581 * dispnew.c (showing_window_margins_p): Undo last change, which
5582 was done due to an inadvertent commit.
5583 (adjust_frame_glyphs_for_frame_redisplay): Do call
5584 showing_window_margins_p.
5585
513749ee
SM
55862012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
5587
5588 * eval.c (Fmake_var_non_special): New primitive.
5589 (syms_of_eval): Defsubr it.
5590 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
5591
d4a8f5c1
JB
55922012-06-08 Juanma Barranquero <lekktu@gmail.com>
5593
5594 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
5595 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
5596
8bbbc977
EZ
55972012-06-08 Eli Zaretskii <eliz@gnu.org>
5598
5599 * alloc.c (allocate_vectorlike): Fix last change.
5600
f3372c87
DA
56012012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
5602
5603 Block-based vector allocation of small vectors.
5604 * lisp.h (struct vectorlike_header): New field `nbytes',
5605 adjust comment accordingly.
5606 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
5607 to denote vector blocks. Adjust users (live_vector_p,
5608 mark_maybe_pointer, valid_lisp_object_p) accordingly.
5609 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
5610 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
5611 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
5612 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
5613 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
5614 (roundup_size): New constant.
5615 (struct vector_block): New data type.
5616 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 5617 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
5618 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
5619 (sweep_vectors): New functions.
5620 (allocate_vectorlike): Return `zero_vector' as the only vector of
5621 0 items. Allocate new vector from block if vector size is less than
5622 or equal to VBLOCK_BYTES_MAX.
5623 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
5624 (init_alloc_once): Add call to init_vectors.
5625
4f18a4ed
SM
56262012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
5627
5628 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
5629
86f158bc
PE
56302012-06-07 Paul Eggert <eggert@cs.ucla.edu>
5631
5632 * doprnt.c (doprnt): Truncate multibyte char correctly.
5633 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
5634 would mishandle a string argument "Xc" if X was a multibyte
5635 character of length 2: it would truncate after X's first byte
5636 rather than including all of X.
5637
c5cfcbe0
CY
56382012-06-06 Chong Yidong <cyd@gnu.org>
5639
5640 * buffer.c (word_wrap): Doc fix.
5641
c05cf390
PE
56422012-06-04 Paul Eggert <eggert@cs.ucla.edu>
5643
5644 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
5645
0c3461de
GM
56462012-06-03 Glenn Morris <rgm@gnu.org>
5647
5648 * xdisp.c (tool-bar-style): Doc fix.
5649
c71232db
UM
56502012-06-03 Ulrich Müller <ulm@gentoo.org>
5651
5652 * Makefile.in (PAXCTL): Define.
5653 (temacs$(EXEEXT)): Disable memory randomization for the temacs
5654 binary via PaX flags if the paxctl utility is available.
5655 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
5656 Restore PaX flags to their default. (Bug#11398)
5657
383f7350
CY
56582012-06-03 Chong Yidong <cyd@gnu.org>
5659
5660 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
5661 buffer (Bug#11226).
5662
5f2c76c6
CY
56632012-06-03 Chong Yidong <cyd@gnu.org>
5664
5665 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
5666 (note_mode_line_or_margin_highlight): If there is no help echo,
5667 use mode-line-default-help-echo. Handle the case where the mouse
5668 position is past the end of the mode line string.
5669
5670 * buffer.c (buffer_local_value_1): New function, split from
5671 Fbuffer_local_value; can return Qunbound.
5672 (Fbuffer_local_value): Use it.
5673 (Vmode_line_format): Docstring tweaks.
5674
773d47f6
PE
56752012-06-02 Paul Eggert <eggert@cs.ucla.edu>
5676
5677 * sysdep.c (system_process_attributes): Improve comment.
5678
f2d6a3df
SM
56792012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
5680
5681 * keyboard.c: Export real-this-command to Elisp.
5682 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
5683 and DEFVAR it. Update all users.
5684
63810350
PE
56852012-06-02 Paul Eggert <eggert@cs.ucla.edu>
5686
7bd5c1f4
PE
5687 * minibuf.c (Fassoc_string): Remove duplicate declaration.
5688
63810350
PE
5689 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
5690 Convert pctcpu and pctmem to Lisp float properly.
5691 Let the compiler fold better, as 100.0/0x8000 is exact.
5692
a2821611
AS
56932012-06-02 Andreas Schwab <schwab@linux-m68k.org>
5694
5695 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
5696 cons_block.
5697
5fceba1d
PE
56982012-06-01 Paul Eggert <eggert@cs.ucla.edu>
5699
5700 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
5701
c98ff5dd
DA
57022012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
5703
5704 For a 'struct window', replace some Lisp_Object fields to
5705 bitfields where appropriate, remove unused fields.
5706 * window.h (struct window): Remove unused 'last_mark_x' and
5707 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
5708 change it's type from Lisp_Object to bitfield.
5709 Change type of 'force_start', 'optional_new_start',
5710 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
5711 fields from Lisp_Object to bitfield. Adjust users accordingly.
5712
ca34e0be
PE
57132012-05-31 Paul Eggert <eggert@cs.ucla.edu>
5714
5715 Pacify gcc -Wdouble-precision when using Xaw.
5716 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
5717 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
5718 Use 'float' consistently, rather than 'float' in most places
5719 and 'double' in a couple of places.
5720
efc00ab1 57212012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
5722
5723 * xdisp.c (handle_stop): Detect whether we have overlay strings
5724 loaded by testing it->current.overlay_string_index to be
5725 non-negative, instead of checking whether n_overlay_strings is
5726 positive. (Bug#11587)
5727
efc00ab1 57282012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
5729
5730 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
5731
5732 * doc.c (Fsubstitute_command_keys): Doc fix.
5733
efc00ab1 57342012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
5735
5736 * search.c (search_buffer): Remove calls to
5737 r_alloc_inhibit_buffer_relocation, as it is now called by
5738 maybe_unify_char, which was the cause of relocation of buffer text
5739 in bug#11519.
5740
efc00ab1 57412012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
5742
5743 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
5744 for the duration of call to load_charset, to avoid problems with
5745 callers of maybe_unify_char that access buffer text through C
5746 pointers.
5747
5748 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
5749 decrement the inhibition flag, instead of just setting or
5750 resetting it.
5751
ba93a187
PE
57522012-05-31 Paul Eggert <eggert@cs.ucla.edu>
5753
5754 Remove obsolete '#define static' cruft.
5755 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
5756 This #undef was "temporary" in 2000; it is no longer needed
5757 now that '#define static' has gone away.
5758 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
5759 (gray_bitmap_bits): Remove; no longer needed.
5760 All uses replaced with definiens.
5761 * xterm.c: Include "bitmaps/gray.xbm".
5762
9e4bf381
PE
57632012-05-30 Paul Eggert <eggert@cs.ucla.edu>
5764
5765 Clean up __executable_start, monstartup when --enable-profiling.
5766 The following changes affect the code only when profiling.
5767 * dispnew.c (__executable_start): Rename from safe_bcopy.
5768 Define only on platforms that need it.
5769 * emacs.c: Include <sys/gmon.h> when profiling.
5770 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
5771 (__executable_start): Remove decl, since lisp.h does it now.
5772 (safe_bcopy): Remove decl; no longer has that name.
5773 (main): Coalesce #if into single bit of code, for simplicity.
5774 Cast pointers to uintptr_t, since standard libraries want integers
5775 and not pointers.
5776 * lisp.h (__executable_start): New decl.
5777
32d72c2f
GM
57782012-05-31 Glenn Morris <rgm@gnu.org>
5779
5780 * image.c (Fimagemagick_types): Doc fix.
5781
baac5bc7
JM
57822012-05-30 Jim Meyering <meyering@redhat.com>
5783
5784 * callproc.c (Fcall_process_region): Include directory component
5785 in mkstemp error message (Bug#11586).
5786
72cb32cf
PE
57872012-05-30 Paul Eggert <eggert@cs.ucla.edu>
5788
5789 * alloc.c, lisp.h (make_pure_vector): Now static.
5790
61b108cc
SM
57912012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
5792
5793 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
5794 Move to byte-run.el.
5795 (Fautoload): Do the hash-doc more carefully.
5796 * data.c (Fdefalias): Purify definition, except for keymaps.
5797 (Qdefun): Move from eval.c.
5798 * lisp.h (Qdefun): Remove.
5799 * lread.c (read1): Tiny simplification.
5800
471fe23d
TN
58012012-05-29 Troels Nielsen <bn.troels@gmail.com>
5802
934f3f58 5803 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
5804 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
5805 Bug#9642, but explicitly check that the buffer the overlay would
5806 be moved to is live and rearrange lines to make sure that errors
5807 will not put the overlay in an inconsistent state.
5808 (Fdelete_overlay): Cosmetics.
5809
85d0efd1
EZ
58102012-05-28 Eli Zaretskii <eliz@gnu.org>
5811
5812 * w32term.c (my_bring_window_to_top): New function.
5813 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
5814 could be different from the original one.
5815 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
5816 (Bug#11513)
5817
5818 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
5819 by calling BringWindowToTop.
5820
5821 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
5822 (WM_EMACS_END): Increase by one.
5823
da92a98c
PE
58242012-05-28 Paul Eggert <eggert@cs.ucla.edu>
5825
5826 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
5827 This avoids undefined behavior that might cause the eassert
5828 to not catch an out-of-range value.
5829
74d1f848
JB
58302012-05-28 Juanma Barranquero <lekktu@gmail.com>
5831
5832 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
5833 Update dependencies.
5834
9e1a06fc
EZ
58352012-05-27 Eli Zaretskii <eliz@gnu.org>
5836
5837 * bidi.c (bidi_mirror_char): Fix last change.
5838
f3dd7312
AS
58392012-05-27 Andreas Schwab <schwab@linux-m68k.org>
5840
5841 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
5842 when referring to sectname field in printf format.
5843
81899c91
PE
58442012-05-27 Paul Eggert <eggert@cs.ucla.edu>
5845
57b81a9f
PE
5846 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
5847 Only r_alloc_inhibit_buffer_relocation needed to be added;
5848 the others were already declared.
5849
81899c91
PE
5850 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
5851 before checking whether it's out of range. Put the check inside
5852 eassert. See
5853 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
5854
33017faf 58552012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
5856
5857 * callproc.c (Fcall_process): Restore a line that was accidentally
5858 commented out in the 2011-02-13 change (bug#11547).
5859
33017faf 58602012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
5861
5862 * lisp.h [REL_ALLOC]: Add prototypes for external functions
5863 defined on ralloc.c.
5864
5865 * buffer.c [REL_ALLOC]: Remove prototypes of
5866 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
5867 they are now on lisp.h.
5868
5869 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
5870
5871 * search.c (search_buffer): Use it to inhibit relocation of buffer
5872 text while re_search_2 is doing its job, because re_search_2 is
5873 passed C pointers to buffer text. (Bug#11519)
5874
23415acf
EZ
5875 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
5876 Update value to 24.
5877
44e27368
EZ
5878 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
5879 state after an additional call to move_it_in_display_line_to, keep
5880 the values of it->max_ascent and it->max_descent found for the
5881 entire line.
5882 (pos_visible_p): Revert the comparison against bottom_y to what it
5883 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
5884 (Bug#11464)
5885
c1892f11
PE
58862012-05-26 Paul Eggert <eggert@cs.ucla.edu>
5887
5888 Fix coding-related core dumps with gcc -ftrapv.
5889 The code was computing A - B, where A and B are pointers, and B is
5890 random garbage. This can lead to core dumps on platforms that
5891 have special pointer registers, and it also leads to core dumps on
5892 x86-64 when compiled with gcc -ftrapv. The fix is to compute
5893 A - B only when B is initialized properly.
5894 * coding.c (coding_set_source, coding_set_destination): Return void.
5895 (coding_change_source, coding_change_destinations): New functions,
5896 with the old behaviors of coding_set_source and coding_set_destination.
5897 All callers that need an offset changed to use these new functions.
5898
eb7afdad
GM
58992012-05-26 Glenn Morris <rgm@gnu.org>
5900
5901 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
5902
f12fdf02
EZ
59032012-05-26 Eli Zaretskii <eliz@gnu.org>
5904
53a63be6 5905 Extend mouse support on W32 text-mode console.
61b108cc
SM
5906 * xdisp.c (draw_row_with_mouse_face):
5907 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 5908
eb3f6f01 5909 * w32console.c: Include window.h.
61b108cc
SM
5910 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
5911 New functions.
eb3f6f01
EZ
5912 (initialize_w32_display): Initialize mouse-highlight data.
5913
53a63be6
EZ
5914 * w32inevt.c: Include termchar.h and window.h.
5915 (do_mouse_event): Support mouse-autoselect-window. When the mouse
5916 moves, call note_mouse_highlight. If help_echo changed, call
5917 gen_help_event to produce help-echo message in the echo area.
5918 Call clear_mouse_face if mouse_face_hidden is set in the mouse
5919 highlight info.
5920
4cfd81f6
PE
59212012-05-26 Paul Eggert <eggert@cs.ucla.edu>
5922
5923 * lread.c (read1): Simplify slightly to avoid an overflow warning
5924 with GCC 4.7.0 on x86-64.
5925
4446092a
EZ
59262012-05-26 Eli Zaretskii <eliz@gnu.org>
5927
5928 * bidi.c (bidi_mirror_char): Revert last change: an int is
5929 definitely wide enough here.
5930
42b2a986 59312012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 5932
42b2a986 5933 Fix integer width and related bugs (Bug#9874).
eb106a49 5934 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
5935 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
5936 (string_bytes, check_sblock, allocate_string_data):
5937 (compact_small_strings, Fmake_bool_vector, make_string)
5938 (make_unibyte_string, make_multibyte_string)
5939 (make_string_from_bytes, make_specified_string)
5940 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
5941 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
5942 (mark_vectorlike):
5943 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5944 (allocate_pseudovector):
5945 Use int, not EMACS_INT, where int is wide enough.
5946 (inhibit_garbage_collection, Fgarbage_collect):
5947 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5948 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
5949 int might not be wide enough.
5950 (bidi_cache_search, bidi_cache_find, bidi_init_it)
5951 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
5952 (bidi_at_paragraph_end, bidi_find_paragraph_start)
5953 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5954 (bidi_level_of_next_char, bidi_move_to_visually_next):
5955 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5956 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
5957 (Fkill_buffer, Fset_buffer_major_mode)
5958 (advance_to_char_boundary, Fbuffer_swap_text)
5959 (Fset_buffer_multibyte, overlays_at, overlays_in)
5960 (overlay_touches_p, struct sortvec, record_overlay_string)
5961 (overlay_strings, recenter_overlay_lists)
5962 (adjust_overlays_for_insert, adjust_overlays_for_delete)
5963 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
5964 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
5965 (Foverlay_recenter, last_overlay_modification_hooks_used)
5966 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
5967 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
5968 (validate_region): Omit unnecessary test for b <= e,
5969 since that's guaranteed by the previous test.
d311d28c
PE
5970 (adjust_overlays_for_delete): Avoid pos + length overflow.
5971 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
5972 (report_overlay_modification):
5973 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5974 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
5975 Omit pointer cast, which isn't needed anyway, and doesn't work
5976 after the EMACS_INT -> ptrdiff_t change.
02481186 5977 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
5978 * buffer.h: Adjust decls to match defn changes elsewhere.
5979 (struct buffer_text, struct buffer):
5980 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5981 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
5982 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
5983 not int, to avoid needless 32-bit limit on 64-bit hosts.
5984 (exec_byte_code): Use tighter memory-full test, one that checks
5985 for alloca overflow. Don't compute the address of the object just
5986 before an array, as that's not portable. Use EMACS_INT, not
5987 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
5988 * callint.c (Fcall_interactively):
5989 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5990 * callproc.c (call_process_kill, Fcall_process):
5991 Don't assume pid_t fits into an Emacs fixnum.
5992 (call_process_cleanup, Fcall_process, child_setup):
5993 Don't assume pid_t fits into int.
5994 (call_process_cleanup, Fcall_process, delete_temp_file)
5995 (Fcall_process_region):
5996 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5997 (Fcall_process): Simplify handling of volatile integers.
5998 Use int, not EMACS_INT, where int will do.
5999 * casefiddle.c (casify_object, casify_region, operate_on_word)
6000 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
6001 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6002 (casify_object): Avoid integer overflow when overallocating buffer.
6003 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 6004 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
6005 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
6006 * category.h (CATEGORYP): Don't assume arg is nonnegative.
6007 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
6008 integers are now checked earlier. All uses replaced with XINT.
6009 (ccl_driver):
6010 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6011 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
6012 (ccl_driver, Fregister_code_conversion_map):
6013 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
6014 (resolve_symbol_ccl_program): Check that vector header is in range.
6015 Always copy the vector, so that we can check its contents reliably
6016 now rather than having to recheck each instruction as it's being
6017 executed. Check that vector words fit in 'int'.
6018 (ccl_get_compiled_code, Fregister_ccl_program)
6019 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
6020 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
6021 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
6022 contents are in range.
6023 (Fccl_execute_on_string): Check that status is in range.
6024 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
6025 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
6026 Accept and return EMACS_INT, not int, because callers can pass values
6027 out of 'int' range.
6028 (c_string_width, strwidth, lisp_string_width, chars_in_text)
6029 (multibyte_chars_in_text, parse_str_as_multibyte)
6030 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
6031 (str_as_unibyte, str_to_unibyte, string_count_byte8)
6032 (string_escape_byte8, Fget_byte):
6033 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 6034 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
6035 avoid mishandling large integers.
6036 * character.h: Adjust decls to match defn changes elsewhere.
6037 * charset.c (load_charset_map_from_file, find_charsets_in_text)
6038 (Ffind_charset_region):
6039 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6040 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
6041 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 6042 Don't assume fixnum fits in int.
d311d28c
PE
6043 (load_charset_map_from_vector, Fmap_charset_chars):
6044 Remove now-unnecessary CHECK_NATNUMs.
6045 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
6046 Don't rely on undefined behavior with signed left shift overflow.
6047 Don't assume unsigned int fits into fixnum, or that fixnum fits
6048 into unsigned int. Don't require max_code to be a valid fixnum;
6049 that's not true for gb10830 4-byte on a 32-bit host. Allow
6050 invalid_code to be a cons, for the same reason. Require code_offset
6051 to be a character. Avoid int overflow if max_char is close
6052 to INT_MAX.
6053 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
6054 this is intended anyway and avoids some undefined behavior.
6055 (load_charset_map): Pass unsigned, not int, as 2nd arg of
6056 INDEX_TO_CODE_POINT, as that's what it expects.
6057 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
6058 * charset.h (DECODE_CHAR): Return int, not unsigned;
6059 this is what was intended anyway, and it avoids undefined behavior.
6060 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
6061 integer-overflow issues.
6062 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
6063 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
6064 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
6065 * chartab.c (Fmake_char_table, Fset_char_table_range)
6066 (uniprop_get_decoder, uniprop_get_encoder):
6067 Don't assume fixnum fits in int.
6068 * cmds.c (move_point): New function, that does the gist of
6069 Fforward_char and Fbackward_char, but does so while checking
6070 for integer overflow more accurately.
c96e5d6a 6071 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
6072 (Fforward_line, Fend_of_line, internal_self_insert)
6073 (internal_self_insert):
6074 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6075 Fix a FIXME, by checking for integer overflow when calculating
6076 target_clm and actual_clm.
6077 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 6078 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
6079 (ASSURE_DESTINATION, coding_alloc_by_realloc)
6080 (coding_alloc_by_making_gap, alloc_destination)
6081 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
6082 (encode_coding_utf_16, detect_coding_emacs_mule)
6083 (decode_coding_emacs_mule, encode_coding_emacs_mule)
6084 (detect_coding_iso_2022, decode_coding_iso_2022)
6085 (encode_invocation_designation, encode_designation_at_bol)
6086 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6087 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
6088 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
6089 (encode_coding_ccl, encode_coding_raw_text)
6090 (detect_coding_charset, decode_coding_charset)
6091 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
6092 (produce_composition, produce_charset, produce_annotation)
6093 (decode_coding, handle_composition_annotation)
6094 (handle_charset_annotation, consume_chars, decode_coding_gap)
6095 (decode_coding_object, encode_coding_object, detect_coding_system)
6096 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
6097 (code_convert_region, code_convert_string)
8f50130c
PE
6098 (Fdefine_coding_system_internal)
6099 (coding_set_source, coding_set_destination):
d311d28c
PE
6100 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6101 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
6102 (Fdefine_coding_system_internal):
6103 Don't assume fixnums fit in int.
6104 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 6105 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
6106 (Funencodable_char_position, Fcheck_coding_systems_region)
6107 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 6108 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 6109 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 6110 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 6111 Don't access memory outside of the args array.
d311d28c 6112 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
6113 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
6114 result of ENCODE_CHAR.
d311d28c
PE
6115 * coding.h: Adjust decls to match defn changes elsewhere.
6116 (struct coding_system):
6117 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6118 * composite.c (get_composition_id, find_composition)
6119 (run_composition_function, update_compositions)
6120 (compose_text, composition_gstring_put_cache)
6121 (composition_gstring_p, composition_gstring_width)
6122 (fill_gstring_header, fill_gstring_body, autocmp_chars)
6123 (composition_compute_stop_pos, composition_reseat_it)
6124 (composition_update_it, struct position_record)
6125 (find_automatic_composition, composition_adjust_point)
6126 (Fcomposition_get_gstring, Ffind_composition_internal):
6127 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6128 (update_compositions):
6129 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6130 * composite.h: Adjust decls to match defn changes elsewhere.
6131 (struct composition):
6132 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6133 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
6134 Do not attempt to compute the address of the object just before a
6135 buffer; this is not portable.
6136 (Faref, Faset):
6137 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6138 (Faset): Use int, not EMACS_INT, where int is wide enough.
6139 (Fstring_to_number): Don't assume fixnums fit in int.
6140 (Frem): Don't assume arg is nonnegative.
6141 * dbusbind.c (xd_append_arg): Check for integers out of range.
6142 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 6143 (extract_signed, extract_unsigned): New functions.
243e0530
PE
6144 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
6145 (xd_get_connection_references): Return ptrdiff_t, not int.
6146 All uses changed.
6147 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
6148 (xd_read_message_1):
6149 Use int, not unsigned, where the dbus API uses int.
6150 (Fdbus_message_internal): Don't overflow mtype.
6151 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
6152 * dired.c (directory_files_internal, file_name_completion, scmp)
6153 (file_name_completion_stat):
6154 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6155 (file_name_completion): Don't overflow matchcount.
6156 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
6157 * dispextern.h: Adjust decls to match defn changes elsewhere.
6158 (struct text_pos, struct glyph, struct bidi_saved_info)
6159 (struct bidi_string_data, struct bidi_it, struct composition_it)
6160 (struct it):
6161 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6162 (struct display_pos, struct composition_it, struct it):
6163 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6164 * dispnew.c (increment_matrix_positions)
6165 (increment_row_positions, mode_line_string)
6166 (marginal_area_string):
6167 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 6168 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
6169 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6170 (duration_to_sec_usec): New function, to check for overflow better.
6171 (Fsleep_for, sit_for): Use it.
6172 * doc.c (get_doc_string, store_function_docstring):
6173 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6174 (get_doc_string, Fsnarf_documentation):
6175 Use int, not EMACS_INT, where int is wide enough.
6176 (get_doc_string):
6177 Use SAFE_ALLOCA, not alloca.
6178 Check for overflow when converting EMACS_INT to off_t.
6179 * doprnt.c (doprnt):
6180 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6181 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
6182 Don't assume uid_t fits into fixnum.
6183 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
6184 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
6185 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
6186 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
6187 (general_insert_function)
6188 (Finsert_char, make_buffer_string, make_buffer_string_both)
6189 (update_buffer_properties, Fbuffer_substring)
6190 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
6191 (Fsubst_char_in_region, check_translation)
6192 (Ftranslate_region_internal, save_restriction_restore, Fformat)
6193 (transpose_markers, Ftranspose_regions):
6194 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6195 (clip_to_bounds): Move to lisp.h as an inline function).
6196 (Fconstrain_to_field): Don't assume integers are nonnegative.
6197 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
6198 (Fsubst_char_in_region, Fsave_restriction):
6199 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6200 (Femacs_pid): Don't assume pid_t fits into fixnum.
6201 (lo_time): Use int, not EMACS_INT, when int suffices.
6202 (lisp_time_argument): Check for usec out of range.
6203 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
6204 (Fuser_login_name, Fuser_full_name): Signal an error
6205 if a uid argument is out of range, rather than relying on
6206 undefined behavior.
c8d5c857
PE
6207 (Fformat_time_string): Remove now-unnecessary check.
6208 lisp_time_argument checks for out-of-range usec now.
243e0530 6209 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
6210 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
6211 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
6212 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
6213 (init_cmdargs, Fdump_emacs):
6214 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6215 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
6216 the bottom (typically) 32 bits of the fixnum.
6217 * eval.c (specpdl_size, call_debugger):
6218 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6219 (when_entered_debugger, Fbacktrace_debug):
6220 Don't assume fixnum can fit in int.
6221 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
6222 the object just before a buffer; this is not portable.
6223 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
6224 (grow_specpdl, unbind_to):
6225 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6226 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
6227 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 6228 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
6229 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
6230 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
6231 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6232 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
6233 (a_write, e_write):
6234 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6235 (Fcopy_file, non_regular_nbytes, read_non_regular)
6236 (Finsert_file_contents):
6237 Use int, not EMACS_INT, where int is wide enough.
6238 (READ_BUF_SIZE): Verify that it fits in int.
6239 (Finsert_file_contents): Check that counts are in proper range,
6240 rather than assuming fixnums fit into ptrdiff_t etc.
6241 Don't assume fixnums fit into int.
125b3835 6242 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
6243 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
6244 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
6245 (string_char_to_byte, string_byte_to_char)
6246 (string_make_multibyte, string_to_multibyte)
6247 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
6248 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
6249 (substring_both, Fdelete, internal_equal, Ffillarray)
6250 (Fclear_string, mapcar1)
6251 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
6252 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
6253 (larger_vector, make_hash_table, maybe_resize_hash_table)
6254 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
6255 (Fmaphash, secure_hash):
6256 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6257 (concat): Check for string index and length overflow.
6258 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
6259 (Frequire):
6260 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6261 (larger_vector): New API (vec, incr_min, size_max) replaces old
6262 one (vec, new_size, init). This catches size overflow.
6263 INIT was removed because it was always Qnil.
6264 All callers changed.
6265 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
6266 the upper bound on a hash table index size.
6267 (make_hash_table, maybe_resize_hash_table): Use it.
6268 (secure_hash): Computer start_byte and end_byte only after
6269 they're known to be in ptrdiff_t range.
6270 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
6271 (Ffont_get_glyphs, Ffont_at):
6272 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6273 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
6274 (Flist_fonts, Fopen_font):
6275 Don't assume fixnum can fit in int.
6276 (check_gstring): Don't assume index can fit in int.
6277 (font_match_p): Check that fixnum is a character, not a nonnegative
6278 fixnum, since the later code needs to stuff it into an int.
6279 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
6280 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
6281 conversion overflow issues.
6282 (Fopen_font): Check for integer out of range.
6283 (Ffont_get_glyphs): Don't assume index can fit in int.
6284 * font.h: Adjust decls to match defn changes elsewhere.
6285 * fontset.c (reorder_font_vector): Redo score calculation to avoid
6286 integer overflow.
6287 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
6288 printmax_t, where ptrdiff_t is wide enough.
6289 (Finternal_char_font):
6290 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6291 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
6292 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
6293 (Fset_frame_position, x_set_frame_parameters)
6294 (x_set_line_spacing, x_set_border_width)
6295 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
6296 Check that fixnums are in proper range for system types.
6297 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
6298 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6299 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
6300 Use SAFE_ALLOCA_LISP, not alloca.
6301 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
6302 intptr_t is wide enough.
6303 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
6304 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
6305 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
6306 Check for fixnum out of range.
6307 * ftfont.c (ftfont_list): Don't assume index fits in int.
6308 Check that fixnums are in proper range for system types.
6309 (ftfont_shape_by_flt):
6310 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
6311 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6312 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6313 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
6314 Check that fixnums are in proper range for system types.
6315 * gnutls.h: Adjust decls to match defn changes elsewhere.
6316 * gtkutil.c (xg_dialog_run):
6317 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6318 (update_frame_tool_bar):
6319 Check that fixnums are in proper range for system types.
6320 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 6321 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
6322 * indent.c (last_known_column, last_known_column_point):
6323 (current_column_bol_cache):
6324 (skip_invisible, current_column, check_display_width):
6325 (check_display_width, scan_for_column, current_column_1)
6326 (Findent_to, Fcurrent_indentation, position_indentation)
6327 (indented_beyond_p, Fmove_to_column, compute_motion):
6328 (Fcompute_motion, Fvertical_motion):
6329 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6330 (last_known_column_modified): Use EMACS_INT, not int.
6331 (check_display_width):
6332 (Fcompute_motion):
6333 Check that fixnums and floats are in proper range for system types.
6334 (compute_motion): Don't assume index or fixnum fits in int.
6335 (compute_motion, Fcompute_motion):
6336 Use int, not EMACS_INT, when it is wide enough.
6337 (vmotion): Omit local var start_hpos that is always 0; that way
6338 we don't need to worry about overflow in expressions involving it.
6339 * indent.h: Adjust decls to match defn changes elsewhere.
6340 (struct position):
6341 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6342 Use int, not EMACS_INT, where int is wide enough.
6343 Remove unused members ovstring_chars_done and tab_offset;
6344 all uses removed.
6345 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
6346 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
6347 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
6348 (make_gap, copy_text, insert, insert_and_inherit)
6349 (insert_before_markers, insert_before_markers_and_inherit)
6350 (insert_1, count_combining_before, count_combining_after)
6351 (insert_1_both, insert_from_string)
6352 (insert_from_string_before_markers, insert_from_string_1)
6353 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
6354 (adjust_after_replace, adjust_after_insert, replace_range)
6355 (replace_range_2, del_range, del_range_1, del_range_byte)
6356 (del_range_both, del_range_2, modify_region)
6357 (prepare_to_modify_buffer, signal_before_change)
6358 (signal_after_change, Fcombine_after_change_execute):
6359 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6360 * intervals.c (traverse_intervals, rotate_right, rotate_left)
6361 (balance_an_interval, split_interval_right, split_interval_left)
6362 (find_interval, next_interval, update_interval)
6363 (adjust_intervals_for_insertion, delete_node, delete_interval)
6364 (interval_deletion_adjustment, adjust_intervals_for_deletion)
6365 (static_offset_intervals, offset_intervals)
6366 (merge_interval_right, merge_interval_left, make_new_interval)
6367 (graft_intervals_into_buffer, temp_set_point_both)
6368 (temp_set_point, set_point, adjust_for_invis_intang)
6369 (set_point_both, move_if_not_intangible, get_property_and_range)
6370 (get_local_map, copy_intervals, copy_intervals_to_string)
6371 (compare_string_intervals, set_intervals_multibyte_1):
6372 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6373 * intervals.h: Adjust decls to match defn changes elsewhere.
6374 (struct interval):
6375 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6376 * keyboard.c (this_command_key_count, this_single_command_key_start)
6377 (before_command_key_count, before_command_echo_length, echo_now)
6378 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
6379 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
6380 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
6381 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
6382 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6383 (last_non_minibuf_size, last_point_position, echo_truncate)
6384 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
6385 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
6386 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
6387 (stuff_buffered_input):
6388 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6389 (last_auto_save, command_loop_1, read_char):
6390 Use EMACS_INT, not int, to avoid integer overflow.
6391 (record_char): Avoid overflow in total_keys computation.
6392 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
6393 * keyboard.h: Adjust decls to match defn changes elsewhere.
6394 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
6395 (Fkey_description, Fdescribe_vector, Flookup_key):
6396 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6397 (click_position): New function, to check that positions are in range.
6398 (Fcurrent_active_maps):
6399 (describe_command):
6400 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6401 (Faccessible_keymaps, Fkey_description):
6402 (preferred_sequence_p):
6403 Don't assume fixnum can fit into int.
6404 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
6405 Check for integer overflow in size calculations.
6406 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
6407 avoid mishandling large integers.
6408 * lisp.h: Adjust decls to match defn changes elsewhere.
6409 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
6410 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
6411 (struct Lisp_Marker):
6412 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6413 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
6414 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
6415 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
6416 All callers changed.
6417 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
6418 Assume the arg has valid form, since it always does.
6419 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
6420 unsigned integer system type.
6421 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
6422 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
6423 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6424 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
6425 (duration_to_sec_usec): New decl.
6426 * lread.c (read_from_string_index, read_from_string_index_byte)
6427 (read_from_string_limit, readchar, unreadchar, openp)
6428 (read_internal_start, read1, oblookup):
6429 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6430 (Fload, readevalloop, Feval_buffer, Feval_region):
6431 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6432 (openp): Check for out-of-range argument to 'access'.
6433 (read1): Use int, not EMACS_INT, where int is wide enough.
6434 Don't assume fixnum fits into int.
6efdadfd 6435 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
6436 (read_filtered_event): Use duration_to_sec_usec
6437 to do proper overflow checking on durations.
d311d28c
PE
6438 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
6439 in size calculation.
6440 (Fexecute_kbd_macro):
6441 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6442 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
6443 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
6444 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
6445 (set_marker_both, set_marker_restricted_both, marker_position)
6446 (marker_byte_position, Fbuffer_has_markers_at):
6447 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6448 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 6449 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
6450 It now merely ensures that the menu is large enough, without
6451 necessarily growing it, as this avoids some integer overflow issues.
6452 All callers changed.
6453 (keymap_panes, parse_single_submenu, Fx_popup_menu):
6454 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6455 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
6456 Use SAFE_ALLOCA_LISP, not alloca.
6457 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
6458 to EMACS_INT. Check that fixnums are in proper range for system types.
6459 * minibuf.c (minibuf_prompt_width, string_to_object)
6460 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
6461 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
6462 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6463 (get_minibuffer, read_minibuf_unwind):
6464 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6465 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
6466 this simplifies overflow checking. All callers changed.
6467 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
6468 (Ftest_completion):
6469 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6470 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
6471 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
6472 Check that fixnums are in proper range for system types.
6473 (Fx_create_frame, Fx_show_tip):
6474 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6475 * nsfont.m (ns_findfonts, nsfont_list_family):
6476 Don't assume fixnum fits in long.
6477 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
6478 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6479 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
6480 wide enough.
17fdb222 6481 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
6482 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6483 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
6484 (PRINTDECLARE, PRINTPREPARE):
6485 (strout, print_string):
6486 (print, print_preprocess, print_check_string_charset_prop)
6487 (print_object):
6488 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6489 (PRINTDECLARE):
6490 (temp_output_buffer_setup, Fprin1_to_string, print_object):
6491 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6492 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 6493 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 6494 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
6495 (print_error_message): Use SAFE_ALLOCA, not alloca.
6496 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
6497 (print_depth, new_backquote_output, print_number_index):
6498 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
6499 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
6500 (Fset_process_window_size, Fformat_network_address)
6501 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 6502 (sigchld_handler):
d311d28c 6503 Check that fixnums are in proper range for system types.
d44287d4 6504 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
6505 Check for process-ids out of pid_t range rather than relying on
6506 undefined behavior.
e4d81efc 6507 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
6508 (Fformat_network_address, read_process_output, send_process)
6509 (Fprocess_send_region, status_notify):
6510 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6511 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
6512 (wait_reading_process_output, read_process_output, exec_sentinel):
6513 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6514 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
6515 (Faccept_process_output): Use duration_to_sec_usec to do proper
6516 overflow checking on durations.
dde14581
PE
6517 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
6518 Don't assume pid_t fits in int.
02481186
PE
6519 * process.h (struct Lisp_Process): Members tick and update_tick
6520 are now of type EMACS_INT, not int.
b62b53e8
PE
6521 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
6522 configured --with-wide-int.
d311d28c
PE
6523 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
6524 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
6525 * search.c (looking_at_1, string_match_1):
6526 (fast_string_match, fast_c_string_match_ignore_case)
6527 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
6528 (scan_newline, find_before_next_newline, search_command)
6529 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
6530 (set_search_regs, wordify):
6531 (Freplace_match):
6532 (Fmatch_data):
6533 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6534 (string_match_1, search_buffer, set_search_regs):
6535 (Fmatch_data):
6536 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6537 (wordify): Check for overflow in size calculation.
6538 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
6539 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
6540 Check that fixnums are in proper range for system types.
6541 * sound.c (struct sound_device)
6542 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
6543 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6544 (Fplay_sound_internal):
6545 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 6546 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
6547 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
6548 (Fparse_partial_sexp):
6549 Don't assume fixnums can fit in int.
6550 (struct lisp_parse_state, find_start_pos, find_start_value)
6551 (find_start_value_byte, find_start_begv)
6552 (update_syntax_table, char_quoted, dec_bytepos)
6553 (find_defun_start, prev_char_comend_first, back_comment):
6554 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
6555 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
6556 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6557 (Finternal_describe_syntax_value): Check that match_lisp is a
6558 character, not an integer, since the code stuffs it into int.
6559 (scan_words, scan_sexps_forward):
6560 Check that fixnums are in proper range for system types.
6561 (Fforward_word):
6562 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6563 (scan_sexps_forward):
6564 Use CHARACTERP, not INTEGERP, since the value must fit into int.
6565 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
6566 * syntax.h: Adjust decls to match defn changes elsewhere.
6567 (struct gl_state_s):
6568 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
6569 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
6570 MOST_POSITIVE_FIXNUM.
d311d28c
PE
6571 * sysdep.c (wait_for_termination_1, wait_for_termination)
6572 (interruptible_wait_for_termination, mkdir):
6573 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
6574 (emacs_read, emacs_write):
6575 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
6576 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
6577 and double all fit in int.
d311d28c
PE
6578 * term.c (set_tty_color_mode):
6579 Check that fixnums are in proper range for system types.
6580 * termhooks.h (struct input_event):
6581 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6582 * textprop.c (validate_interval_range, interval_of)
6583 (Fadd_text_properties, set_text_properties_1)
6584 (Fremove_text_properties, Fremove_list_of_text_properties)
6585 (Ftext_property_any, Ftext_property_not_all)
6586 (copy_text_properties, text_property_list, extend_property_ranges)
6587 (verify_interval_modification):
6588 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6589 (Fnext_single_char_property_change)
6590 (Fprevious_single_char_property_change):
6591 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
6592 (copy_text_properties):
6593 Check for integer overflow in index calculation.
d311d28c
PE
6594 * undo.c (last_boundary_position, record_point, record_insert)
6595 (record_delete, record_marker_adjustment, record_change)
6596 (record_property_change):
6597 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6598 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
6599 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6600 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
6601 (Fx_hide_tip, Fx_file_dialog):
6602 * w32menu.c (set_frame_menubar):
6603 Use ptrdiff_t, not int, for consistency with rest of code.
6604 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
6605 (select_window, Fdelete_other_windows_internal)
6606 (window_scroll_pixel_based, window_scroll_line_based)
6607 (Frecenter, Fset_window_configuration):
6608 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6609 (Fset_window_hscroll, run_window_configuration_change_hook)
6610 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 6611 (Fscroll_other_window, Frecenter):
d311d28c
PE
6612 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6613 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
6614 Don't assume fixnum fits in int.
6615 (Fset_window_scroll_bars):
6616 Check that fixnums are in proper range for system types.
6617 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
6618 (string_pos, c_string_pos, number_of_chars, init_iterator)
6619 (in_ellipses_for_invisible_text_p, init_from_display_pos)
6620 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
6621 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
6622 (face_before_or_after_it_pos, handle_invisible_prop)
6623 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
6624 (display_prop_intangible_p, string_buffer_position_lim)
6625 (string_buffer_position, handle_composition_prop, load_overlay_strings)
6626 (get_overlay_strings_1, get_overlay_strings)
6627 (iterate_out_of_display_property, forward_to_next_line_start)
6628 (back_to_previous_visible_line_start, reseat, reseat_to_string)
6629 (get_next_display_element, set_iterator_to_next)
6630 (get_visually_first_element, compute_stop_pos_backwards)
6631 (handle_stop_backwards, next_element_from_buffer)
6632 (move_it_in_display_line_to, move_it_in_display_line)
6633 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6634 (add_to_log, message_dolog, message_log_check_duplicate)
6635 (message2, message2_nolog, message3, message3_nolog
6636 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
6637 (current_message_1, truncate_echo_area, truncate_message_1)
6638 (set_message, set_message_1, store_mode_line_noprop)
6639 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
6640 (text_outside_line_unchanged_p, check_point_in_composition)
6641 (reconsider_clip_changes)
6642 (redisplay_internal, set_cursor_from_row, try_scrolling)
6643 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
6644 (redisplay_window, find_last_unchanged_at_beg_row)
6645 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
6646 (trailing_whitespace_p, find_row_edges, display_line)
6647 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
6648 (display_mode_element, store_mode_line_string)
6649 (pint2str, pint2hrstr, decode_mode_spec)
6650 (display_count_lines, display_string, draw_glyphs)
6651 (x_produce_glyphs, x_insert_glyphs)
6652 (rows_from_pos_range, mouse_face_from_buffer_pos)
6653 (fast_find_string_pos, mouse_face_from_string_pos)
6654 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6655 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6656 (safe_call, init_from_display_pos, handle_fontified_prop)
6657 (handle_single_display_spec, load_overlay_strings)
6658 (with_echo_area_buffer, setup_echo_area_for_printing)
6659 (display_echo_area, echo_area_display)
6660 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
6661 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
6662 (redisplay_window, dump_glyph_row, display_mode_line)
6663 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 6664 (handle_display_spec, display_prop_string_p):
d311d28c
PE
6665 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6666 (handle_single_display_spec, build_desired_tool_bar_string)
6667 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
6668 (get_specified_cursor_type):
6669 Check that fixnums are in proper range for system types.
6670 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
6671 (Flookup_image_map):
6672 Don't assume fixnums fit in int.
6673 (compare_overlay_entries):
6674 Avoid mishandling comparisons due to subtraction overflow.
6675 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
6676 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
6677 (handle_tool_bar_click):
6678 Use int, not unsigned, since we prefer signed and the signedness
6679 doesn't matter here.
6680 (get_next_display_element, next_element_from_display_vector):
6681 Use int, not EMACS_INT, when int is wide enough.
6682 (start_hourglass): Use duration_to_sec_usec to do proper
6683 overflow checking on durations.
6684 * xfaces.c (Fbitmap_spec_p):
6685 Check that fixnums are in proper range for system types.
6686 (compare_fonts_by_sort_order):
6687 Avoid mishandling comparisons due to subtraction overflow.
6688 (Fx_family_fonts, realize_basic_faces):
6689 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6690 (Fx_family_fonts):
6691 Don't assume fixnum fits in int.
6692 Use SAFE_ALLOCA_LISP, not alloca.
6693 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
6694 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
6695 (face_at_buffer_position, face_for_overlay_string)
6696 (face_at_string_position):
6697 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6698 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
6699 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
6700 (Fx_show_tip):
6701 Check that fixnums are in proper range for system types.
6702 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
6703 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
6704 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6705 (Fx_change_window_property): Don't assume fixnums fit in int.
6706 * xfont.c (xfont_chars_supported):
6707 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6708 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
6709 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
6710 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6711 * xml.c (parse_region):
6712 * xrdb.c (magic_file_p):
6713 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6714 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
6715 (x_get_local_selection, x_reply_selection_request)
6716 (x_handle_selection_request, wait_for_property_change):
6717 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6718 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
6719 short is wide enough.
6720 (x_send_client_event): Don't assume fixnum fits in int.
6721 * xterm.c (x_x_to_emacs_modifiers):
6722 Don't assume EMACS_INT overflows nicely into int.
6723 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
6724 may come from Lisp.
6725 (handle_one_xevent): NATNUMP can eval its arg twice.
6726 (x_connection_closed):
6727 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6728 * xterm.h: Adjust decls to match defn changes elsewhere.
6729 (struct scroll_bar): Use struct vectorlike_header
6730 rather than rolling our own approximation.
6731 (SCROLL_BAR_VEC_SIZE): Remove; not used.
6732
c6574eb5
GM
67332012-05-25 Glenn Morris <rgm@gnu.org>
6734
6735 * lisp.mk (lisp): Update for more files being compiled now.
6736
e8d32c7e
SM
67372012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
6738
48def666
SM
6739 * lread.c: Remove `read_pure' which makes no difference.
6740 (read_pure): Remove var.
6741 (unreadpure): Remove function.
6742 (readevalloop): Don't call read_list with -1 flag.
6743 (read1, read_vector): Don't test read_pure any more.
6744 (read_list): Simplify.
6745
e8d32c7e
SM
6746 * fileio.c, character.h: Minor style tweaks.
6747
4b2addb7
DA
67482012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
6749
6750 * window.h (clip_changed): Remove useless declaration.
6751
584461b2
JB
67522012-05-22 Juanma Barranquero <lekktu@gmail.com>
6753
6754 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
6755 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
6756
34374650
PE
67572012-05-22 Paul Eggert <eggert@cs.ucla.edu>
6758
6759 Remove src/m/*.
6760 This directory predates autoconf and is no longer needed nowadays.
6761 Move its few remaining bits of functionality to where they're needed.
6762 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
6763 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
6764 * m/template.h: Remove.
6765 * Makefile.in (M_FILE): Remove. All uses removed.
6766 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
6767 * lisp.h (USE_LSB_TAG):
6768 * mem-limits.h (EXCEEDS_LISP_PTR):
6769 Use VAL_MAX, not VALBITS, in #if.
6770 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
6771 (EMACS_UINT): Define unconditionally now.
6772 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
6773 (BITS_PER_EMACS_INT): New constants, replacing
6774 what used to be in config.h, but not useful in #if.
6775 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
6776 define them any more.
6777 (VAL_MAX): New macro.
6778 (VALMASK): Use it.
6779 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
6780 BITS_PER_EMACS_INT, in #if.
6781 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
6782 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
6783 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
6784 * s/ms-w32.h (DATA_START):
6785 Move here from removed file m/intel386.h.
6786 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
6787 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
6788
261cb4bb
PE
67892012-05-21 Paul Eggert <eggert@cs.ucla.edu>
6790
6791 Assume C89 or later.
6792 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
6793 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
6794 (xrealloc):
6795 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
6796 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
6797 * textprop.c, tparam.c (NULL): Remove.
6798 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
6799 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
6800 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
6801 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
6802 * xterm.c (input_signal_count): Assume volatile works.
6803
ff23cd9f
KB
68042012-05-21 Ken Brown <kbrown@cornell.edu>
6805
6806 * xgselect.c (xg_select): Fix first argument in call to 'select'
6807 (bug#11508).
6808
1b170bc6
KB
68092012-05-20 Ken Brown <kbrown@cornell.edu>
6810
6811 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 6812 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 6813
b2f4d39f
KB
68142012-05-19 Ken Brown <kbrown@cornell.edu>
6815
6816 * xfns.c (x_in_use): Remove `static' qualifier.
6817 * xterm.h (x_in_use): Declare.
6818 * xgselect.c: Include xterm.h.
6819 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
6820 and `display_arg' (bug#9754).
6821
003fdae2
PE
68222012-05-19 Paul Eggert <eggert@cs.ucla.edu>
6823
9232a6d9
PE
6824 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
6825
003fdae2
PE
6826 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
6827 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
6828
784b56e2
EZ
68292012-05-18 Eli Zaretskii <eliz@gnu.org>
6830
6831 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
6832
6833 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 6834 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
6835
6836 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
6837 reference to image_cache->refcount.
6838 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
6839
a0a79cde
JL
68402012-05-17 Juri Linkov <juri@jurta.org>
6841
6842 * search.c (Fword_search_regexp, Fword_search_backward)
6843 (Fword_search_forward, Fword_search_backward_lax)
6844 (Fword_search_forward_lax): Move functions to isearch.el
6845 (bug#10145, bug#11381).
6846
b0572523
PE
68472012-05-16 Paul Eggert <eggert@cs.ucla.edu>
6848
6849 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
6850
9660f5fc
SM
68512012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
6852
6853 * lread.c (init_obarray): Declare Qt and Qnil as special.
6854
4374de83
GM
68552012-05-14 Glenn Morris <rgm@gnu.org>
6856
6857 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 6858 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 6859
dc44c39a
PE
68602012-05-14 Paul Eggert <eggert@cs.ucla.edu>
6861
078c97cb
PE
6862 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
6863
dc44c39a
PE
6864 * unexaix.c: Port to more-recent AIX compilers.
6865 (report_error, report_error_1, make_hdr, copy_sym)
6866 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
6867 Make arguments const char *, not char *, to avoid violations of C
6868 standard and to fix some AIX warnings reported by Gilles Pion.
6869
e18afed7 68702012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
6871
6872 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
6873 already have overlays loaded.
6874 (handle_single_display_spec): Before returning without displaying
6875 fringe bitmap, synchronize the bidi iterator with the main display
6876 iterator, by calling iterate_out_of_display_property.
6877 (iterate_out_of_display_property): Detect buffer iteration by
6878 testing that it->string is a Lisp string.
6879 (get_next_display_element): When the current object is exhausted,
6880 and there's something on it->stack, call set_iterator_to_next to
6881 proceed with what's on the stack, instead of returning zero.
6882 (set_iterator_to_next): If called at the end of a Lisp string,
6883 proceed to consider_string_end without incrementing string
6884 position. Don't increment display vector index past the end of
6885 the display vector. (Bug#11417)
c8fb9dc6
EZ
6886 (pos_visible_p): Don't report a position visible when move_it_to
6887 stopped at the last line of window, which happens to be scanned
6888 backwards by the bidi iteration. (Bug#11464)
ac268e67 6889
e18afed7 68902012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
6891
6892 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
6893 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
6894 are on a TTY, and thus unable to display on the fringes.
6895 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
6896 so we need to signal to the caller that this is a "replacing"
6897 display spec. This fixes display when the spec is invalid or we
6898 are on a TTY.
6899
e18afed7 69002012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
6901
6902 * unexaix.c (make_hdr): Fix typo in prototype.
6903 This bug broke the build on AIX. Problem reported by Gilles Pion.
6904
9d0a235a
MA
69052012-05-14 Michael Albinus <michael.albinus@gmx.de>
6906
6907 * keyboard.c (kbd_buffer_get_event): Read special events also in
6908 batch mode. (Bug#11415)
6909
9e6b06ed
GM
69102012-05-12 Glenn Morris <rgm@gnu.org>
6911
6912 * ns.mk: Update for ns_appbindir no longer having trailing "/".
6913
c1a1d7a3
EZ
69142012-05-12 Eli Zaretskii <eliz@gnu.org>
6915
6916 * lisp.mk (lisp): Add newcomment.elc.
6917
3fe7cdc8
GM
69182012-05-12 Glenn Morris <rgm@gnu.org>
6919
6920 * Makefile.in (MKDIR_P): New, set by configure.
6921 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
6922
53f7d2c0
PE
69232012-05-11 Paul Eggert <eggert@cs.ucla.edu>
6924
6925 Remove unused function hourglass_started.
6926 * dispextern.h (hourglass_started):
6927 * w32fns.c (hourglass_started):
6928 * xdisp.c (hourglass_started): Remove.
6929
75aafb17
JB
69302012-05-10 Juanma Barranquero <lekktu@gmail.com>
6931
6932 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
6933 Update dependencies.
6934
12959e8e
PE
69352012-05-10 Paul Eggert <eggert@cs.ucla.edu>
6936
97107e2e
PE
6937 * xgselect.c (xg_select): Put maxfds+1 into a var.
6938 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
6939
12959e8e
PE
6940 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
6941
836d29b3
DA
69422012-05-10 Dave Abrahams <dave@boostpro.com>
6943
6944 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
6945 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
6946
5cb67954
MA
69472012-05-09 Michael Albinus <michael.albinus@gmx.de>
6948
6949 * dbusbind.c (xd_registered_buses): New internal Lisp object.
6950 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
6951 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
6952 Initialize xd_registered_buses.
6953
3478ec45
PE
69542012-05-09 Paul Eggert <eggert@cs.ucla.edu>
6955
b263a6b0
PE
6956 Untag more efficiently if USE_LSB_TAG.
6957 This is based on a proposal by YAMAMOTO Mitsuharu in
6958 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
6959 For an admittedly artificial (nth 8000 longlist) benchmark on
6960 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
6961 Emacs's overall text size by 1%.
6962 * lisp.h (XUNTAG): New macro.
6963 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
6964 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
6965 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
6966 * eval.c (Fautoload):
6967 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
6968 * frame.h (XFRAME): Use XUNTAG.
6969
3478ec45
PE
6970 Port recent dbusbind.c changes to 32-bit --with-wide-int.
6971 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
6972 Remove unportable assumptions about print widths of types like
6973 dbus_uint32_t.
6974 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
6975 intptr_t when converting between pointer and integer, to avoid GCC
6976 warnings about wrong width.
6977
666b903b 69782012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
6979
6980 * w32proc.c (new_child): Force Windows to reserve only 64KB of
6981 stack for each reader_thread, instead of defaulting to 8MB
6982 determined by the linker. This avoids failures in creating
6983 subprocesses on Windows 7, see the discussion in this thread:
6984 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
6985
b120cc17
JC
69862012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
6987
6988 Fix up display of the *Minibuf-0* buffer in the mini window.
6989 * keyboard.c (read_char): Don't clear the echo area if there's no
6990 message to clear.
6991 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 6992 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 6993
9a4b36f8
MA
69942012-05-07 Michael Albinus <michael.albinus@gmx.de>
6995
6996 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
6997 batch mode.
6998
e5f9458f
CY
69992012-05-06 Chong Yidong <cyd@gnu.org>
7000
7001 * lisp.mk (lisp): Update.
7002
eceeb5fc 70032012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
7004
7005 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
7006
71873e2b
SM
70072012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
7008
7009 * data.c (PUT_ERROR): New macro.
7010 (syms_of_data): Use it. Add new error type `user-error'.
7011 * undo.c (user_error): New function.
7012 (Fprimitive_undo): Use it.
7013 * print.c (print_error_message): Adjust print style for `user-error'.
7014 * keyboard.c (user_error): New function.
7015 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
7016
ab0fa4e4
PE
70172012-05-03 Paul Eggert <eggert@cs.ucla.edu>
7018
7019 Do not limit current-time-string to years 1000..9999.
7020 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
7021 (Fcurrent_time_string): Support any year that is supported by the
7022 underlying localtime representation. Don't use asctime, as it
7023 has undefined behavior for years outside the range -999..9999.
7024
7ed806a7
PE
70252012-05-02 Paul Eggert <eggert@cs.ucla.edu>
7026
7027 Fix race conditions involving setenv, gmtime, localtime, asctime.
7028 Without this fix, interrupts could mess up code that uses these
7029 nonreentrant functions, since setting TZ invalidates existing
7030 tm_zone or tzname values, and since most of these functions return
7031 pointers to static storage.
7032 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
7033 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
7034 Grow the critical sections to include not just invoking
7035 localtime/gmtime, but also accessing these functions' results
7036 including their tm_zone values if any, and any related TZ setting.
7037 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
7038 so that the struct tm is saved in the critical section.
7039 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
7040 motivated by the fact that memory allocation needs to be outside
7041 the critical section.
7042
0c16dfed
DA
70432012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
7044
7045 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
7046 with RESET_INTERVAL.
7047
7048 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7049 Remove duplicated buffer name initialization.
7050
3f83ace8
JM
70512012-05-02 Jim Meyering <jim@meyering.net>
7052
7053 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
7054
c7b8541e
JM
7055 * xfns.c (x_window): Use xstrdup (Bug#11375).
7056
90207a15 70572012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
7058
7059 * xdisp.c (pos_visible_p): If already at a newline from the
7060 display string before the 'while' loop, don't walk back the glyphs
7061 from it3.glyph_row. Solves assertion violation when the display
7062 string begins with a newline (egg.el). (Bug#11367)
7063
b593d6a9
AH
70642012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
7065
7066 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
7067 Move to simple.el.
7068
4737362e
GM
70692012-05-01 Glenn Morris <rgm@gnu.org>
7070
99cf43f9
GM
7071 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
7072 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
7073 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
7074 All were removed before 23.1.
7075
9311dcff
GM
7076 * dispnew.c: Remove HAVE_LIBNCURSES test;
7077 it is always true on relevant platforms.
7078
4d5c6349
GM
7079 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
7080 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
7081
4737362e
GM
7082 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
7083
74dd3a6b
AS
70842012-04-30 Andreas Schwab <schwab@linux-m68k.org>
7085
7086 * .gdbinit (xpr): Remove checks for no longer existing misc types.
7087 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
7088 Remove.
7089
13c379ee
PE
70902012-04-28 Paul Eggert <eggert@cs.ucla.edu>
7091
7092 Do not avoid creating empty evaporating overlays (Bug#9642).
7093 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
7094 That is, do not delete an evaporating overlay if it becomes
7095 empty after its bounds are adjusted to fit within its buffer.
7096 This fix caused other problems, and I'm reverting it until we get
7097 to the bottom of them.
7098
a8e7d6d7 70992012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
7100
7101 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
7102
a8e7d6d7 71032012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
7104
7105 * xdisp.c (pos_visible_p): If the window start position is beyond
7106 ZV, start the display from buffer beginning. Prevents assertion
7107 violation in init_iterator when the minibuffer window is scrolled
7108 via the scroll bar.
7109
7110 * window.c (window_scroll_pixel_based): Likewise.
7111
a8e7d6d7 71122012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
7113
7114 * keymap.c (where_is_internal): Doc fix (Bug#10872).
7115
a8e7d6d7 71162012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
7117
7118 * fileio.c (Fcopy_file, Fset_file_selinux_context):
7119 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
7120
a8e7d6d7 71212012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 7122
b593d6a9
AH
7123 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
7124 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 7125
1c6900d9
EZ
71262012-04-26 Eli Zaretskii <eliz@gnu.org>
7127
4c3fa1d9
EZ
7128 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
7129 display element, check also the underlying string or buffer
7130 character. (Bug#11341)
7131
1c6900d9
EZ
7132 * w32menu.c: Include w32heap.h.
7133 (add_menu_item): If the call to AppendMenuW (via
7134 unicode_append_menu) fails, disable Unicode menus only if we are
7135 running on Windows 9X/Me.
7136
42bf8205
AS
71372012-04-24 Andreas Schwab <schwab@linux-m68k.org>
7138
7139 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
7140 (xgetint): Add missing shift for LSB tags.
7141
b1bac16e
MR
71422012-04-24 Martin Rudalics <rudalics@gmx.at>
7143
7144 * keyboard.c (read_char): Don't wipe echo area for select window
7145 events: These might get delayed via `mouse-autoselect-window'
7146 (Bug#11304).
7147
d69621cc
JB
71482012-04-24 Juanma Barranquero <lekktu@gmail.com>
7149
7150 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
7151 manipulation of :loaded-from data.
7152
02fd101b
JB
71532012-04-23 Juanma Barranquero <lekktu@gmail.com>
7154
7155 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
7156 now a cons (bug#11311).
7157
888bec30
PE
71582012-04-23 Paul Eggert <eggert@cs.ucla.edu>
7159
89a438bd
PE
7160 Do not create empty overlays with the evaporate property (Bug#9642).
7161 * buffer.c (Fmove_overlay): Delete an evaporating overlay
7162 if it becomes empty after its bounds are adjusted to fit within
7163 its buffer. Without this fix, in a nonempty buffer (let ((o
7164 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
7165 yields an empty overlay that has the evaporate property, which is
7166 not supposed to happen.
7167
1068fe4d
PE
7168 Fix minor GTK3 problems found by static checking.
7169 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
7170 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
7171 (struct _EmacsFixedClass, emacs_fixed_get_type):
7172 Move decls here from emacsgtkfixed.h, since they needn't be public.
7173 (emacs_fixed_get_type): Now static.
7174 (emacs_fixed_class_init): Omit unused local.
7175 (emacs_fixed_child_type): Remove; unused.
7176 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
7177 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
7178 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
7179 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
7180 (EMACS_FIXED_GET_CLASS): Remove; unused.
7181 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
7182
888bec30
PE
7183 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
7184 Problem reported by Juanma Barranquero for Windows -Wunused-function.
7185
de85e130
PE
71862012-04-22 Paul Eggert <eggert@cs.ucla.edu>
7187
d0baac98 7188 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 7189 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
7190 (__malloc_size_t, __malloc_ptrdiff_t):
7191 Remove. All uses removed, replaced by the definiens if needed,
7192 since we can assume C89 or better now.
7193 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
7194 (protect_malloc_state, align, get_contiguous_space)
7195 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
7196 (malloc_atfork_handler_child, malloc_enable_thread)
7197 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
7198 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
7199 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
7200 (special_realloc, _realloc_internal_nolock, _realloc_internal)
7201 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
7202 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
7203 Define using prototypes, not old style.
7204 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
7205 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
7206 (align): Don't assume that signed integer overflow wraps around.
7207 Omit unused local var.
7208 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
7209 (_free_internal_nolock, memalign, mallochook, reallochook):
7210 Omit no-longer-needed casts.
7211 (valloc): Use getpagesize, not __getpagesize.
7212 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
7213 (struct hdr): The 'magic' member is now size_t, not unsigned long.
7214
de85e130
PE
7215 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
7216
dcbf5805
MA
72172012-04-22 Michael Albinus <michael.albinus@gmx.de>
7218
7219 Move functions from C to Lisp. Make non-blocking method calls
7220 the default. Implement further D-Bus standard interfaces.
7221
7222 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
7223 (QCdbus_request_name_allow_replacement)
7224 (QCdbus_request_name_replace_existing)
7225 (QCdbus_request_name_do_not_queue)
7226 (QCdbus_request_name_reply_primary_owner)
7227 (QCdbus_request_name_reply_in_queue)
7228 (QCdbus_request_name_reply_exists)
7229 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
7230 (QCdbus_registered_serial, QCdbus_registered_method)
7231 (QCdbus_registered_signal): New Lisp objects.
7232 (XD_DEBUG_MESSAGE): Use sizeof.
7233 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
7234 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
7235 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
7236 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
7237 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
7238 (xd_signature, xd_append_arg): Allow float for integer types.
7239 (xd_get_connection_references): New function.
b593d6a9
AH
7240 (xd_get_connection_address): Rename from xd_initialize.
7241 Return cached address.
dcbf5805
MA
7242 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
7243 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
7244 level.
7245 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 7246 Return number of refcounts.
dcbf5805
MA
7247 (Fdbus_get_unique_name): Make stronger parameter check.
7248 (Fdbus_message_internal): New defun.
7249 (Fdbus_call_method, Fdbus_call_method_asynchronously)
7250 (Fdbus_method_return_internal, Fdbus_method_error_internal)
7251 (Fdbus_send_signal, Fdbus_register_service)
7252 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
7253 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
7254 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
7255 (Vdbus_compiled_version, Vdbus_runtime_version)
7256 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
7257 (Vdbus_message_type_method_return, Vdbus_message_type_error)
7258 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
7259 (Vdbus_registered_buses, Vdbus_registered_objects_table):
7260 Adapt docstring.
dcbf5805 7261
52828e02
PE
72622012-04-22 Paul Eggert <eggert@cs.ucla.edu>
7263
da05bc4c
PE
7264 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
7265 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
7266 Do not assume ptrdiff_t is the same width as 'int'.
7267
52828e02
PE
7268 * alloc.c: Handle unusual debugging option combinations.
7269 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
7270 since the two debugging options are incompatible.
7271 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
7272 is defined.
7273 (mem_init, mem_insert, mem_insert_fixup):
7274 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
7275 (NEED_MEM_INSERT): Remove; no longer needed.
7276
f01769f9
LL
72772012-04-22 Leo Liu <sdl.web@gmail.com>
7278
7279 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
7280
5790543d
PE
72812012-04-22 Paul Eggert <eggert@cs.ucla.edu>
7282
7283 * sysdep.c [__FreeBSD__]: Minor cleanups.
7284 (list_system_processes, system_process_attributes) [__FreeBSD__]:
7285 Use Emacs indenting style more consistently. Avoid some casts.
7286 Use 'double' consistently rather than mixing 'float' and 'double'.
7287
b91b7e4d
EW
72882012-04-21 Eduard Wiebe <usenet@pusto.de>
7289
b593d6a9
AH
7290 * sysdep.c (list_system_processes, system_process_attributes):
7291 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 7292
6114eb15
AS
72932012-04-21 Andreas Schwab <schwab@linux-m68k.org>
7294
7295 * lisp.mk (lisp): Update.
7296
2f38dff7
PE
72972012-04-20 Paul Eggert <eggert@cs.ucla.edu>
7298
7299 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
7300 It is never used otherwise.
7301
4ae29f89
SM
73022012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
7303
7304 * print.c (print_preprocess): Only check print_depth if print-circle
7305 is nil.
7306 (print_object): Check for cycles even when print-circle is nil and
7307 print-gensym is t, but only check print_depth if print-circle is nil.
7308
f30d612a
CY
73092012-04-20 Chong Yidong <cyd@gnu.org>
7310
7311 * process.c (wait_reading_process_output): If EIO occurs on a pty,
7312 set the status to "failed" and ensure that sentinel is run.
7313
c07a4c0b 73142012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
7315
7316 * process.c (Fset_process_inherit_coding_system_flag)
7317 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 7318 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 7319
c07a4c0b 73202012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
7321
7322 * xdisp.c (string_buffer_position_lim): Limit starting position to
7323 BEGV.
7324 (set_cursor_from_row): If called for a mode-line or header-line
7325 row, return zero immediately.
7326 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
7327 farther than the first row after the header line, if any.
7328 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
7329 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
7330
c07a4c0b 73312012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 7332
4ae29f89
SM
7333 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
7334 (bug#11238).
ad3a2b41 7335
c07a4c0b 73362012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 73372012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
7338
7339 configure: new option --enable-gcc-warnings (Bug#11207)
7340 * Makefile.in (C_WARNINGS_SWITCH): Remove.
7341 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
7342 (ALL_CFLAGS): Use new macros rather than old.
7343 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
7344 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
7345 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
7346 -Wunused-result, -Wunused-variable. This should go away once
7347 the Emacs and Gnulib regex code is merged.
7348 (xmalloc, xrealloc): Now static.
7349
aba027e8
PE
73502012-04-17 Paul Eggert <eggert@cs.ucla.edu>
7351
7352 * dired.c (Fsystem_groups): Remove unused local.
7353
e5a36063
GM
73542012-04-17 Glenn Morris <rgm@gnu.org>
7355
7356 * dired.c (Fsystem_users): Doc fix.
7357
316411f0
DA
73582012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
7359
7360 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
7361 (syms_of_dired): Add them.
7362
9426aba4
PE
73632012-04-16 Paul Eggert <eggert@cs.ucla.edu>
7364
b62a57be
PE
7365 Fix minor alloc.c problems found by static checking.
7366 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
7367 New extern decls, to avoid calling undeclared functions.
7368 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
7369 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
7370 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
7371 (NEED_MEM_INSERT): New macro.
7372 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 7373 Remove one incorrect comment and fix another.
b62a57be 7374
3539f31f
PE
7375 Fix minor ralloc.c problems found by static checking.
7376 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
7377 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
7378 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
7379 (r_alloc_sbrk): Now static.
7380
a041960a
PE
7381 Improve ralloc.c interface checking.
7382 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
7383 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
7384 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
7385 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
7386 [REL_ALLOC]: ... to here, to check interface.
7387 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
7388 Remove decls. This fixes an "It stinks!".
7389
9426aba4
PE
7390 * alloc.c (which_symbols): Fix alignment issue / type clash.
7391
d55c12ed
AS
73922012-04-15 Andreas Schwab <schwab@linux-m68k.org>
7393
7394 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
7395 (struct Lisp_Misc_Any): Likewise.
7396 (struct Lisp_Free): Likewise.
7397 * alloc.c (union aligned_Lisp_Symbol): Define.
7398 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
7399 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
7400 (union aligned_Lisp_Misc): Define.
7401 (MARKER_BLOCK_SIZE, struct marker_block): Use union
7402 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 7403 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 7404
b948ce8b
PE
74052012-04-14 Paul Eggert <eggert@cs.ucla.edu>
7406
7407 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
7408 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
7409 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
7410 * s/netbsd.h, s/sol2-6.h:
7411 Remove definition of GC_MARK_STACK, since the default now works.
7412 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
7413 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
7414 no longer the default.
7415 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
7416
35dc09a1 74172012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 7418
35dc09a1
GM
7419 * lread.c (lisp_file_lexically_bound_p):
7420 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 7421
35dc09a1
GM
74222012-04-14 Eli Zaretskii <eliz@gnu.org>
7423
7424 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
7425 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
7426
74272012-04-14 Jan Djärv <jan.h.d@swipnet.se>
7428
7429 * nsterm.m (constrainFrameRect): Always constrain when there is only
7430 one screen (Bug#10962).
7431
bcd86815
KB
74322012-04-13 Ken Brown <kbrown@cornell.edu>
7433
7434 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
7435
c25df26e
RT
74362012-04-13 Reuben Thomas <rrt@sc3d.org>
7437
7438 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
7439
0fc59f1e
DC
74402012-04-11 Daniel Colascione <dancol@dancol.org>
7441
7442 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
7443 against is gone. It's better to use vfork now so that when Cygwin
7444 gains a new, working vfork, we use it automatically (bug#10398).
7445
de8c03dc
SM
74462012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
7447
7448 * window.c (save_window_save): Obey window-point-insertion-type.
7449
2f097256
GM
74502012-04-11 Glenn Morris <rgm@gnu.org>
7451
7452 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
7453
453b951e
SM
74542012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
7455
7456 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
7457
75f1671a 74582012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
7459
7460 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
7461 (force_quit_count): New var.
7462 (handle_interrupt): Use it.
7463
2a8ce227
JB
74642012-04-10 Juanma Barranquero <lekktu@gmail.com>
7465
7466 * w32.c (w32_delayed_load): Record the full path of the library
7467 being loaded (bug#10424).
7468
935396c0
GM
74692012-04-09 Glenn Morris <rgm@gnu.org>
7470
05920a43
GM
7471 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
7472 not just in the obarray, before snarfing them. (Bug#11036)
7473
935396c0
GM
7474 * Makefile.in ($(leimdir)/leim-list.el):
7475 Pass EMACS rather than BUILT_EMACS.
7476
a18ecafa
TZ
74772012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
7478
7479 * process.c (make_process):
7480 * process.h: Add integer `gnutls_handshakes_tried' member to
7481 process struct.
7482
6bbef4e5
JC
7483 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
7484 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
7485
7486 * gnutls.c (gnutls_log_function2i): Convenience log function.
7487 (emacs_gnutls_read): Use new log functions,
7488 `gnutls_handshakes_tried' process member, and
7489 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
7490 attempts per process (connection).
7491
b4d3bc10
CY
74922012-04-09 Chong Yidong <cyd@gnu.org>
7493
7494 * eval.c (Fuser_variable_p, user_variable_p_eh)
7495 (lisp_indirect_variable): Functions deleted.
7496 (Fdefvar): Caller changed.
7497
7498 * callint.c (Finteractive, Fcall_interactively):
7499 * minibuf.c (Fread_variable): Callers changed.
7500
70f4d973
EZ
75012012-04-09 Eli Zaretskii <eliz@gnu.org>
7502
7503 * xdisp.c (set_cursor_from_row): If the display string appears in
7504 the buffer at position that is closer to point than the position
7505 after the display string, display the cursor on the first glyph of
7506 the display string. Fixes cursor display when a 'display' text
7507 property immediately follows invisible text. (Bug#11094)
7508
cb3c2e3e
PE
75092012-04-09 Paul Eggert <eggert@cs.ucla.edu>
7510
7511 composite.c: use 'double' consistently
7512 * composite.c (get_composition_id): Use 'double' consistently
7513 instead of converting 'float' to 'double' and vice versa; this is
7514 easier to understand and avoids a GCC warning.
7515
fd06db5d
GM
75162012-04-09 Glenn Morris <rgm@gnu.org>
7517
50fe702a
GM
7518 * Makefile.in: Generate leim-list with bootstrap-emacs, in
7519 preparation for dumping it with emacs. (Bug#4789)
7520 (leimdir): New variable.
7521 ($(leimdir)/leim-list.el): New rule.
7522 (emacs$(EXEEXT)): Depend on leim-list.el.
7523
fd06db5d
GM
7524 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
7525 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
7526 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
7527
55c131ee
AS
75282012-04-08 Andreas Schwab <schwab@linux-m68k.org>
7529
7530 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
7531 proper alignment.
7532
9209588f
JB
75332012-04-07 Juanma Barranquero <lekktu@gmail.com>
7534
7535 * xml.c (init_libxml2_functions) [WINDOWSNT]:
7536 Remove unused local variable.
7537
e3fb2efb
PE
75382012-04-07 Paul Eggert <eggert@cs.ucla.edu>
7539
7540 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
7541 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
7542 (mark_memory): Mark Lisp_Objects only if pointers might hide in
7543 objects, as mark_maybe_pointer will catch them otherwise.
7544 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
7545 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
7546
b5385551
PE
75472012-04-07 Paul Eggert <eggert@cs.ucla.edu>
7548
7549 Fix typo that broke non-Windows builds.
7550 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
7551
9078ead6
EZ
75522012-04-07 Eli Zaretskii <eliz@gnu.org>
7553
7554 Support building on MS-Windows with libxml2.
7555
7556 * makefile.w32-in (OBJ2): Add xml.$(O).
7557 (GLOBAL_SOURCES): Add xml.c.
7558 ($(BLD)/xml.$(O)): New dependency list.
7559
7560 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
7561 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
7562 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
7563 [!WINDOWSNT]: New macros.
7564 (init_libxml2_functions, libxml2_loaded_p): New functions.
7565 (parse_region): Call fn_xmlCheckVersion instead of using the macro
7566 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
7567 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
7568 Calls xmlCleanupParser only if libxml2 was loaded (or statically
7569 linked in).
6bbef4e5
JC
7570 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
7571 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
7572 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
7573
7574 * emacs.c: Don't include libxml/parser.h.
7575 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
7576 xmlCleanupParser directly.
7577
7578 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
7579
3811fdf3
EZ
75802012-04-07 Eli Zaretskii <eliz@gnu.org>
7581
7582 * indent.c (Fvertical_motion): If there is a display string at
7583 point, use it.vpos to compute how many lines to backtrack after
7584 move_it_to point. (Bug#11133)
7585
2f8e16b2
EZ
75862012-04-06 Eli Zaretskii <eliz@gnu.org>
7587
7588 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
7589 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
7590 about subtle differences between FETCH_CHAR* and STRING_CHAR*
7591 macros related to unification of CJK characters. For the details,
7592 see the discussion following the message here:
7593 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
7594
3d439cd1
CY
75952012-04-04 Chong Yidong <cyd@gnu.org>
7596
7597 * keyboard.c (Vdelayed_warnings_list): Doc fix.
7598
8bc53d00
EZ
75992012-04-01 Eli Zaretskii <eliz@gnu.org>
7600
7601 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
7602 instead of alloca. (Bug#11138)
7603
3b0512a3
AS
76042012-04-01 Andreas Schwab <schwab@linux-m68k.org>
7605
7606 * w32menu.c (is_simple_dialog): Properly check lisp types.
7607 (Bug#11141)
7608
8427ddd2
EZ
76092012-03-31 Eli Zaretskii <eliz@gnu.org>
7610
979022ef
EZ
7611 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
7612 position we get to after a call to move_it_to fails the
7613 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
7614 only if we wind up in a string from display property. (Bug#11063)
7615
a6b1c7cc
EZ
7616 * window.c (Fdelete_other_windows_internal): Invalidate the row
7617 and column information about mouse highlight, so that redisplay
7618 restores it after reallocating the glyph matrices. (Bug#7464)
7619
8427ddd2
EZ
7620 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
7621 string comes from a `display' text property, use the buffer
7622 position of that property as if we actually saw that position in
7623 the row's glyphs.
697ba24b
EZ
7624 (move_it_by_lines): Remove the assertion that
7625 "it->current_x == 0 && it->hpos == 0" which can be legitimately
7626 violated when there's a before-string at the beginning of a line.
7627 (Bug#11063)
8427ddd2 7628
65a0a738
EZ
76292012-03-30 Eli Zaretskii <eliz@gnu.org>
7630
7631 * xdisp.c (append_space_for_newline): If the default face was
7632 remapped, use the remapped face for the appended newline.
7633 (extend_face_to_end_of_line): Use the remapped default face for
7634 extending the face to the end of the line.
7635 (display_line): Call extend_face_to_end_of_line when the default
7636 face was remapped. (Bug#11068)
7637
581355cc
EZ
76382012-03-29 Eli Zaretskii <eliz@gnu.org>
7639
7640 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
7641
e8fc049f
SM
76422012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7643
7644 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
7645
4fb9a543
GM
76462012-03-27 Glenn Morris <rgm@gnu.org>
7647
7648 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
7649 Doc fixes.
7650
679910f1
KH
76512012-03-26 Kenichi Handa <handa@m17n.org>
7652
7653 * dispextern.h (struct glyph): Fix previous change. Change the
7654 bit length of glyphless.ch to 25 (Bug#11082).
7655
90d49b7f
CY
76562012-03-26 Chong Yidong <cyd@gnu.org>
7657
7658 * keyboard.c (Vselection_inhibit_update_commands): New variable.
7659 (command_loop_1): Use it; inhibit selection update for
7660 handle-select-window too (Bug#8996).
7661
f514f6f0
FP
76622012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
7663
e8fc049f 7664 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 7665
bf43fa51
KH
76662012-03-25 Kenichi Handa <handa@m17n.org>
7667
7668 * dispextern.h (struct glyph): Change the bit length of
7669 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
7670
8a0c01dd
EZ
76712012-03-24 Eli Zaretskii <eliz@gnu.org>
7672
7673 * s/ms-w32.h (tzname): Include time.h before redirecting to
7674 _tzname. Fixes the MSVC build. (Bug#9960)
7675
7d1c3a76
AS
76762012-03-24 Andreas Schwab <schwab@linux-m68k.org>
7677
8ed79523
AS
7678 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
7679 characters.
7680
7d1c3a76
AS
7681 * xterm.c (XTread_socket): Only modify handling_signal if
7682 !SYNC_INPUT. (Bug#11080)
7683
e99a9b8b
EZ
76842012-03-23 Eli Zaretskii <eliz@gnu.org>
7685
7686 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
7687 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
7688 when fetching a multibyte character consumes more bytes than
7689 CHAR_BYTES returns, due to unification of CJK characters in
7690 string_char. (Bug#11073)
7691
5063c0e1
TN
76922012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
7693
7694 * process.c (wait_reading_process_output): Handle pty disconnect
7695 by refraining from sending oneself a SIGCHLD (bug#10933).
7696
9f851fbd
CY
76972012-03-22 Chong Yidong <cyd@gnu.org>
7698
7699 * dispextern.h (struct it): New member string_from_prefix_prop_p.
7700
5063c0e1 7701 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
7702 Mark string as coming from a prefix property.
7703 (handle_face_prop): Use default face for prefix strings (Bug#4281).
7704 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
7705
fb5b8aca
CY
77062012-03-21 Chong Yidong <cyd@gnu.org>
7707
7708 * xfaces.c (Vface_remapping_alist): Doc fix.
7709
62356a1b
EZ
77102012-03-20 Eli Zaretskii <eliz@gnu.org>
7711
7712 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
7713 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
7714 Doc fixes.
62356a1b 7715
025de85b
CY
77162012-03-20 Chong Yidong <cyd@gnu.org>
7717
7718 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
7719 to reflect default non-nil value of redisplay-dont-pause.
7720
4827f94e
KH
77212012-03-19 Kenichi Handa <handa@m17n.org>
7722
7723 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
7724 it fit in a valid range (Bug#11003).
7725
e50a24a2
EZ
77262012-03-18 Eli Zaretskii <eliz@gnu.org>
7727
7728 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
7729 that is not from display property, accept the row as a "cursor
7730 row" if one of the string's character has a non-nil `cursor'
7731 property. Fixes cursor positioning when there are newlines in
7732 overlay strings, e.g. in icomplete.el. (Bug#11035)
7733
9af5ed87
PE
77342012-03-12 Paul Eggert <eggert@cs.ucla.edu>
7735
7736 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
7737
d1f55f16
CY
77382012-03-12 Chong Yidong <cyd@gnu.org>
7739
7740 * eval.c (inhibit_lisp_code): Rename from
7741 inhibit_window_configuration_change_hook; move from window.c.
7742
7743 * xfns.c (unwind_create_frame_1, Fx_create_frame):
7744 * window.c (run_window_configuration_change_hook)
7745 (syms_of_window): Callers changed.
7746
66c5eebd
CY
77472012-03-11 Chong Yidong <cyd@gnu.org>
7748
413df973
CY
7749 * keymap.c (Fkey_description): Doc fix (Bug#9700).
7750
66c5eebd
CY
7751 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
7752
1de11f56
CY
77532012-03-10 Chong Yidong <cyd@gnu.org>
7754
7755 * frame.c (other_visible_frames): Don't assume the selected frame
7756 is visible (Bug#10955).
7757
cae07000
SM
77582012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
7759
7760 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
7761
89c94350
JD
77622012-03-08 Jan Djärv <jan.h.d@swipnet.se>
7763
7764 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
7765 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
7766 zero (Bug#10954).
7767
999dd333
GM
77682012-03-03 Glenn Morris <rgm@gnu.org>
7769
01a6dcc8 7770 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 7771
de0100f2
EZ
77722012-03-02 Eli Zaretskii <eliz@gnu.org>
7773
7774 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
7775 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
7776 (redisplay_window, next_element_from_string): Fix typos in
7777 comments.
3e441275
EZ
7778 (redisplay_window): Pass to move_it_vertically the margin in
7779 pixels, not in screen lines.
de0100f2 7780
96a72ee9
GM
77812012-03-02 Glenn Morris <rgm@gnu.org>
7782
7783 * buffer.c (buffer-list-update-hook): Doc fix.
7784
312508d7
EZ
77852012-02-29 Eli Zaretskii <eliz@gnu.org>
7786
7787 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
7788 push_it before setting up the iterator for the first overlay
7789 string, even if we have an empty string loaded.
7790 (next_overlay_string): If there's an empty string on the iterator
7791 stack, pop the stack. (Bug#10903)
7792
27f3c637
PE
77932012-02-25 Paul Eggert <eggert@cs.ucla.edu>
7794
7795 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
7796 Suggested by Stefan Monnier in
7797 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
7798 * alloc.c (widen_to_Lisp_Object): New static function.
7799 (mark_memory): Also mark Lisp_Objects by fetching pointer words
7800 and widening them to Lisp_Objects. This would work even if
7801 USE_LSB_TAG is defined and wide integers are used, which might
7802 happen in a future version of Emacs.
7803
3c9dfce6
CY
78042012-02-25 Chong Yidong <cyd@gnu.org>
7805
fa74b241
CY
7806 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
7807 Doc fix.
7808
3c9dfce6
CY
7809 * xselect.c (Fx_selection_exists_p): Doc fix.
7810 (x_clipboard_manager_save_all): Print an informative message
7811 before saving to clipboard manager.
7812
9486df08
CY
78132012-02-24 Chong Yidong <cyd@gnu.org>
7814
7815 * keyboard.c (process_special_events): Handle all X selection
7816 requests in kbd_buffer, not just the next one (Bug#8869).
7817
f01d3321
CY
78182012-02-23 Chong Yidong <cyd@gnu.org>
7819
7820 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
7821 call when setting menu-bar-lines and tool-bar-lines parameters.
7822 (unwind_create_frame_1): New helper function.
7823
7824 * window.c (inhibit_window_configuration_change_hook): New var.
7825 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 7826 (syms_of_window): Initialize it.
f01d3321 7827
86b847b6
CY
78282012-02-22 Chong Yidong <cyd@gnu.org>
7829
7830 * xterm.c (x_draw_image_relief): Add missing type check for
7831 Vtool_bar_button_margin (Bug#10743).
7832
a59225b1
CY
78332012-02-21 Chong Yidong <cyd@gnu.org>
7834
7835 * fileio.c (Vfile_name_handler_alist): Doc fix.
7836
7837 * buffer.c (Fget_file_buffer): Protect against invalid file
7838 handler return value.
7839
310f5bd4
PE
78402012-02-20 Paul Eggert <eggert@cs.ucla.edu>
7841
cb3a28cc
PE
7842 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
7843 when computing $valmask.
7844
310f5bd4
PE
7845 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
7846 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
7847 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
7848 It's useless in that case, and it can cause problems on hosts
7849 that allocate halves of EMACS_INT values separately.
7850 Reported by Dan Horák. Diagnosed by Andreas Schwab in
7851 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
7852 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
7853 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
7854 it avoids undefined behavior on hosts where shifting right by more
7855 than the word width has undefined behavior.
7856
2375c96a
CY
78572012-02-19 Chong Yidong <cyd@gnu.org>
7858
7859 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
7860 (Funhandled_file_name_directory, Ffile_name_as_directory)
7861 (Fdirectory_file_name, Fexpand_file_name)
7862 (Fsubstitute_in_file_name): Protect against invalid file handler
7863 return values (Bug#10845).
7864
3eb49e71
EZ
78652012-02-18 Eli Zaretskii <eliz@gnu.org>
7866
7867 * .gdbinit (pitx): Fix incorrect references to fields of the
7868 iterator stack.
7869
7b926f3f
CY
78702012-02-17 Chong Yidong <cyd@gnu.org>
7871
7872 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
7873
11273115
PE
78742012-02-15 Paul Eggert <eggert@cs.ucla.edu>
7875
7876 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
7877 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
7878
c3a70e2b
CY
78792012-02-15 Chong Yidong <cyd@gnu.org>
7880
7881 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
7882 marked as special. Also, starting docstrings with * is obsolete.
7883
0ca43699
AS
78842012-02-13 Andreas Schwab <schwab@linux-m68k.org>
7885
7886 * gnutls.c (emacs_gnutls_write): Fix last change.
7887
2e8f3c56
LI
78882012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
7889
7890 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
7891 send_process.
7892
af70074f
SM
78932012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
7894
7895 * keymap.c (Fsingle_key_description): Handle char ranges.
7896
95986d52
CY
78972012-02-12 Chong Yidong <cyd@gnu.org>
7898
afd83bd1
CY
7899 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
7900 as that creates a dangerous corner case.
7901
95986d52
CY
7902 * window.c (Fdelete_window_internal): Invalidate the mouse
7903 highlight (Bug#9904).
7904
bd7da63e
GM
79052012-02-12 Glenn Morris <rgm@gnu.org>
7906
7907 * xselect.c (Fx_own_selection_internal)
7908 (Fx_get_selection_internal, Fx_disown_selection_internal)
7909 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
7910 * nsselect.m (Fx_own_selection_internal)
7911 (Fx_disown_selection_internal, Fx_selection_exists_p)
7912 (Fx_selection_owner_p, Fx_get_selection_internal):
7913 Sync docs and argument specs with the xselect.c versions.
7914
77abcbc2
LI
79152012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
7916
7917 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
7918
90b671e2
EZ
79192012-02-11 Eli Zaretskii <eliz@gnu.org>
7920
1c0ca0b7
EZ
7921 * w32select.c (Fx_selection_exists_p): Sync doc string and
7922 argument list with xselect.c. (Bug#10783)
7923
7924 * w16select.c (Fx_selection_exists_p): Sync doc string and
7925 argument list with xselect.c. (Bug#10783)
90b671e2 7926
49241268
GM
79272012-02-10 Glenn Morris <rgm@gnu.org>
7928
7929 * fns.c (Fsecure_hash): Doc fix.
7930
f998bbe7 79312012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
7932
7933 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
7934
0992bd9c
CY
79352012-02-07 Chong Yidong <cyd@gnu.org>
7936
7937 * buffer.c (Fbuffer_local_variables)
7938 (buffer_lisp_local_variables): Handle unbound vars correctly;
7939 don't let Qunbound leak into Lisp.
7940
af008560
GM
79412012-02-07 Glenn Morris <rgm@gnu.org>
7942
dd605cc4
GM
7943 * image.c (Fimagemagick_types): Doc fix.
7944
af008560
GM
7945 * image.c (imagemagick-render-type): Change it from a lisp object
7946 to an integer. Move the doc here from the lisp manual.
7947 Treat all values not equal to 0 the same.
7948
1449fa1d
CY
79492012-02-06 Chong Yidong <cyd@gnu.org>
7950
7951 * doc.c (store_function_docstring): Avoid applying docstring of
7952 alias to base function (Bug#2603).
7953
3723ec07
AS
79542012-02-04 Andreas Schwab <schwab@linux-m68k.org>
7955
7956 * .gdbinit (pp1, pv1): Remove redundant defines.
7957 (pr): Use pp.
7958
79c1cc1e
CY
79592012-02-04 Chong Yidong <cyd@gnu.org>
7960
7961 * nsterm.m: Declare a global (Bug#10694).
7962
d7f29f8e
EZ
79632012-02-04 Eli Zaretskii <eliz@gnu.org>
7964
cae07000
SM
7965 * w32.c (get_emacs_configuration_options):
7966 Include --enable-checking, if specified, in the return value.
d7f29f8e 7967
3b95a6f9
MR
79682012-02-04 Martin Rudalics <rudalics@gmx.at>
7969
7970 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
7971 after rounding frame sizes. (Bug#9723)
7972
d6fa96a6
EZ
79732012-02-04 Eli Zaretskii <eliz@gnu.org>
7974
7975 * keyboard.c (adjust_point_for_property): Don't position point
7976 before BEGV. (Bug#10696)
7977
df0b2940
PE
79782012-02-03 Paul Eggert <eggert@cs.ucla.edu>
7979
7980 Handle overflow when computing char display width (Bug#9496).
7981 * character.c (char_width): Return EMACS_INT, not int.
7982 (char_width, c_string_width): Check for overflow when
7983 computing the width; this is possible now that individual
7984 characters can have unbounded width. Problem introduced
7985 by merge from Emacs 23 on 2012-01-19.
7986
6bee44d6
MA
79872012-02-02 Michael Albinus <michael.albinus@gmx.de>
7988
7989 * dbusbind.c (Fdbus_register_method): Mention the return value
7990 :ignore in the docstring.
7991
44f92739
GM
79922012-02-02 Glenn Morris <rgm@gnu.org>
7993
1b9f60cc
GM
7994 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
7995
44f92739
GM
7996 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
7997 Unconditionally set to t. (Bug#10673)
7998 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
7999 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
8000 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
8001
c5d3843c
KH
80022012-02-02 Kenichi Handa <handa@m17n.org>
8003
8004 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
8005 0, do not call append_composite_glyph.
8006
159462d4 80072012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
8008
8009 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
8010 NULL (Bug#6988).
8011 (x_produce_glyphs): If the component of a composition is a null
8012 string, set it->pixel_width to 1 to avoid zero-width glyph.
8013
78cef877
EZ
80142012-02-01 Eli Zaretskii <eliz@gnu.org>
8015
8016 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
8017 first 2 arguments are identical. This makes inserting large
8018 output from a subprocess an order of magnitude faster on
8019 MS-Windows, where all sbrk'ed memory is always contiguous.
8020
97897668
GM
80212012-01-31 Glenn Morris <rgm@gnu.org>
8022
8023 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 8024 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
8025 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
8026
31fd3586
GM
80272012-01-29 Glenn Morris <rgm@gnu.org>
8028
8029 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
8030
0e24a8b2
CY
80312012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
8032
8033 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
8034
cc0adcb0
CY
80352012-01-28 Chong Yidong <cyd@gnu.org>
8036
8037 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
8038
acc28cb9
CY
80392012-01-26 Chong Yidong <cyd@gnu.org>
8040
9c69cfb7
CY
8041 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
8042
acc28cb9
CY
8043 * search.c (Fsearch_forward, Fsearch_backward): Document negative
8044 repeat counts (Bug#10507).
8045
48da7392
GM
80462012-01-26 Glenn Morris <rgm@gnu.org>
8047
8048 * lread.c (syms_of_lread): Doc fix.
8049
14af5f7f
CY
80502012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
8051
8052 * coding.c (encode_designation_at_bol): Change return value to
8053 EMACS_INT.
8054
0b21c100
CY
80552012-01-25 Chong Yidong <cyd@gnu.org>
8056
8057 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
8058
3c2907f7
CY
80592012-01-21 Chong Yidong <cyd@gnu.org>
8060
8061 * floatfns.c (Fcopysign): Make the second argument non-optional,
8062 since nil is not allowed anyway.
8063
959ad23f
AS
80642012-01-21 Andreas Schwab <schwab@linux-m68k.org>
8065
8066 * process.c (read_process_output): Use p instead of XPROCESS (proc).
8067 (send_process): Likewise.
8068
34a02f46
MR
80692012-01-19 Martin Rudalics <rudalics@gmx.at>
8070
8071 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
8072 (Vwindow_persistent_parameters): Do not use Qstate.
8073 Rewrite doc-strings.
34a02f46 8074
1259009a 80752012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
8076
8077 * character.c (char_width): New function.
70d4fdf6
GM
8078 (Fchar_width, c_string_width, lisp_string_width):
8079 Use char_width (Bug#9496).
25ed9e61 8080
6a6ee00d
MR
80812012-01-16 Martin Rudalics <rudalics@gmx.at>
8082
8083 * window.c (Vwindow_persistent_parameters): New variable.
8084 (Fset_window_configuration, save_window_save): Handle persistent
8085 window parameters.
8086
c85efaf7
EZ
80872012-01-14 Eli Zaretskii <eliz@gnu.org>
8088
8089 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
8090 thrashing the stack of the thread. (Bug#9087)
8091
5944709e
PE
80922012-01-12 Paul Eggert <eggert@cs.ucla.edu>
8093
8094 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
8095
e71f5d99
EZ
80962012-01-11 Eli Zaretskii <eliz@gnu.org>
8097
8098 * xdisp.c (rows_from_pos_range): Handle the case where the
8099 highlight ends on a newline. (Bug#10464)
8100 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
8101 he end column for display of highlight that ends on a newline
8102 before a R2L line.
8103
ce316182
GM
81042012-01-11 Glenn Morris <rgm@gnu.org>
8105
8106 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
8107 from load-path also when installation-directory is nil. (Bug#10208)
8108
5b43da69
GM
81092012-01-10 Glenn Morris <rgm@gnu.org>
8110
74cc8ff9
GM
8111 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
8112
7d8d6e4e
GM
8113 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
8114 Update template values to be closer to their typical values these days.
5b43da69 8115
a0db8d43
EZ
81162012-01-09 Eli Zaretskii <eliz@gnu.org>
8117
8118 * xdisp.c (rows_from_pos_range): Accept additional argument
8119 DISP_STRING, and accept any glyph in a row whose object is that
8120 string as eligible for mouse highlight. Fixes mouse highlight of
8121 display strings from overlays. (Bug#10464)
8122
9a0115ab 81232012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 8124
b9110d6a 8125 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
8126 * fileio.c (auto_saving_dir_umask): New static var.
8127 (Fmake_directory_internal): Use it.
8128 (do_auto_save_make_dir): Set it, instead of invoking chmod after
8129 creating the directory. The old code temporarily assigns
8130 too-generous permissions to the directory.
8131 (do_auto_save_eh): Clear it.
b9110d6a 8132 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
8133 that the var is always cleared.
8134
6c1bd3f3
EZ
81352012-01-07 Eli Zaretskii <eliz@gnu.org>
8136
8137 * search.c (scan_buffer): Pass character positions to
8138 know_region_cache, not byte positions. (Bug#6540)
8139
069d2b50
L
81402012-01-07 LynX <_LynX@bk.ru> (tiny change)
8141
8142 * w32.c (sys_rename): Report EXDEV when rename of a directory
8143 fails because the target is on another logical disk. (Bug#10284)
8144
75bf0d33
DB
81452012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
8146
8147 * xterm.c (x_embed_request_focus): New function.
8148
8149 * xterm.h: Add prototype.
8150
8151 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
8152
1c6e5a32
GM
81532012-01-05 Glenn Morris <rgm@gnu.org>
8154
8155 * emacs.c (emacs_copyright): Update short copyright year to 2012.
8156
651e947e
EZ
81572012-01-01 Eli Zaretskii <eliz@gnu.org>
8158
8159 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
8160 Load gnutls_transport_set_lowat only if GnuTLS version is below
8161 2.11.1.
8162 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
8163 GnuTLS versions below 2.11.1.
8164
3778cdd8
AL
81652011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
8166
8167 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
8168 to the doc string advising against its use for altering the way
8169 windows are scrolled.
8170
0e5317f7
KH
81712011-12-28 Kenichi Handa <handa@m17n.org>
8172
8173 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
8174 coding-system ASCII compatible only when it does not produce BOM
8175 on encoding (Bug#10383).
8176
93d5ca1f
JD
81772011-12-26 Jan Djärv <jan.h.d@swipnet.se>
8178
8179 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
8180 can scroll.
8181 (create_and_show_popup_menu): Always use menu_position_func for
8182 Gtk3 (Bug#10361).
8183
ca22b785
AS
81842011-12-24 Andreas Schwab <schwab@linux-m68k.org>
8185
8186 * callint.c (Fcall_interactively): Don't truncate prompt string.
8187
d048e1e6
EZ
81882011-12-23 Eli Zaretskii <eliz@gnu.org>
8189
8190 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
8191 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 8192 resumed from there (after widening). (Bug#10360)
d048e1e6 8193
5ccaba1f
JD
81942011-12-22 Jan Djärv <jan.h.d@swipnet.se>
8195
8196 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
8197
204ee57f
JD
81982011-12-21 Jan Djärv <jan.h.d@swipnet.se>
8199
b81d40f0
JB
8200 * nsterm.m (x_free_frame_resources):
8201 Release f->output_data.ns->miniimage.
204ee57f
JD
8202 (ns_index_color): Fix indentation. Do not retain
8203 color_table->colors[i].
8204
8205 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
8206 before returning.
8207
8208 * nsfns.m (x_set_background_color): Assign return value from
8209 ns_index_color to face-background instead of NSColor*.
8210 (ns_implicitly_set_icon_type): Fix indentation.
8211 Change assignment in for loop to comparison.
8212
8213 * emacs.c (ns_pool): New variable.
8214 (main): Assign ns_pool.
8215 (Fkill_emacs): Call ns_release_autorelease_pool.
8216
8217 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
8218 autorelease fdesc, release fdAttrs and tdict.
8219 (ns_get_covering_families): Release charset.
8220 (ns_findfonts): Release NSFontDescriptor created with new.
8221 (ns_uni_to_glyphs): Fix indentation.
8222 (setString): Release attrStr before assigning new value.
8223
c803b2b7
JD
82242011-12-18 Jan Djärv <jan.h.d@swipnet.se>
8225
678f4426
JD
8226 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
8227 and NS_IMPL_COCOA.
8228 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
8229 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
8230
cd394be1 82312011-12-18 David Reitter <reitter@cmu.edu>
678f4426 8232
5fecd5fc
JD
8233 * nsterm.m (ns_term_init): Subscribe for notifications
8234 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
8235 to method trackingNotification in EmacsMenu.
8236
8237 * nsmenu.m (trackingMenu): New variable.
3771cb17 8238 (trackingNotification): New method (from Aquamacs).
5fecd5fc 8239 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 8240 from Aquamacs (Bug#7030).
678f4426
JD
8241
82422011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 8243
c803b2b7
JD
8244 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
8245 (symbol_to_nsstring): Fix indentation.
8246 (ns_symbol_to_pb): New function.
cae07000
SM
8247 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
8248 (Fns_rotate_cut_buffers_internal): Remove.
8249 (Fns_store_selection_internal): Rename from
c803b2b7
JD
8250 Fns_store_cut_buffer_internal.
8251 (ns_get_foreign_selection, Fx_own_selection_internal)
8252 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
8253 (Fns_get_selection_internal, Fns_store_selection_internal):
8254 Use ns_symbol_to_pb and check if return value is nil.
8255 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
8256 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
8257 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
8258 renamed to Sns_store_selection_internal.
8259 (ns_handle_selection_request): Move code to Fx_own_selection_internal
8260 and remove this function.
8261 (ns_handle_selection_clear): Remove, never used.
8262 (Fx_own_selection_internal): Move code from ns_handle_selection_request
8263 here.
8264
e1b01a3a
KB
82652011-12-17 Ken Brown <kbrown@cornell.edu>
8266
8267 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
8268 GID is unknown (Bug#10257).
8269
2adb6e85
PE
82702011-12-17 Paul Eggert <eggert@cs.ucla.edu>
8271
8272 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
8273 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
8274 which caused a build failure on GNU/Linux IA-64. This problem was
8275 introduced by my 2011-10-07 patch.
8276
d1d7b339
JL
82772011-12-15 Juri Linkov <juri@jurta.org>
8278
8279 * image.c (imagemagick_error): New function. (Bug#10112)
8280 (imagemagick_load_image): Comment out `MagickSetResolution' call.
8281 Use `imagemagick_error' where ImageMagick functions return
8282 `MagickFalse'.
8283 (Fimagemagick_types): Add `Fnreverse' to return the list in the
8284 proper order.
8285
100d5755
KH
82862011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8287
8288 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
8289 fill background (Bug#8992).
8290
454592a6
MR
82912011-12-13 Martin Rudalics <rudalics@gmx.at>
8292
8293 * window.c (Vwindow_combination_resize)
8294 (Vwindow_combination_limit): Use t instead of non-nil in
8295 doc-strings.
61d4b438
MR
8296 (Vrecenter_redisplay): Add first sentence of doc-string on
8297 separate line.
53524d93 8298 (Frecenter): Fix doc-string typo.
454592a6 8299
3633e3aa
KH
83002011-12-11 Kenichi Handa <handa@m17n.org>
8301
8302 * coding.c (Funencodable_char_position): Pay attention to the
8303 buffer text relocation (Bug#9389).
8304
7b9d523a 83052011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 8306
7b9d523a
JD
8307 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
8308 gtk_init (Bug#10100).
8309
b73189c6
EZ
83102011-12-10 Eli Zaretskii <eliz@gnu.org>
8311
8312 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
8313 IT->string is nil. (Bug#10263)
8314
f7dfe5d6
JD
83152011-12-10 Jan Djärv <jan.h.d@swipnet.se>
8316
83faebb4
JD
8317 * nsterm.h (x_free_frame_resources): Declare.
8318
f7dfe5d6
JD
8319 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
8320 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
8321
8322 * nsterm.h (ns_get_defaults_value): Declare.
8323
8324 * nsterm.m (ns_default): Call ns_get_defaults_value.
8325
7cd4e72c
EZ
83262011-12-09 Eli Zaretskii <eliz@gnu.org>
8327
8328 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
8329 (Bug#10170)
8330
b34d7317
YM
83312011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8332
8333 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
8334 that where the value of an _OBJC_* symbol points to is in the .bss
8335 section (Bug#10240).
8336
76470ad1
KH
83372011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
8338
8339 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 8340 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 8341
745fff94
KH
83422011-12-08 Kenichi Handa <handa@m17n.org>
8343
8344 * ftfont.c (get_adstyle_property): Fix previous change
8345 (Bug#10233).
8346
6e44397c
JB
83472011-12-07 Juanma Barranquero <lekktu@gmail.com>
8348
8349 * w32.c (init_environment): If no_site_lisp, remove site-lisp
8350 dirs from the default value of EMACSLOADPATH (bug#10208).
8351
7efa6272
GM
83522011-12-07 Glenn Morris <rgm@gnu.org>
8353
8354 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
8355 installation and source directories as well. (Bug#10208)
8356
f6fc4d87
CY
83572011-12-06 Chong Yidong <cyd@gnu.org>
8358
8359 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
8360
2bf26180
GM
83612011-12-06 Glenn Morris <rgm@gnu.org>
8362
8363 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
8364 as an error, not just -1. (Bug#10217)
8365
3a6ad4f0
CY
83662011-12-05 Chong Yidong <cyd@gnu.org>
8367
8368 * keyboard.c (process_special_events): New function.
8369 (swallow_events, Finput_pending_p): Use it (Bug#10195).
8370
75a3b399
PE
83712011-12-05 Paul Eggert <eggert@cs.ucla.edu>
8372
8373 * coding.c (encode_designation_at_bol): Don't use uninitialized
8374 local variable (Bug#9318).
8375
c3c9e25e
KH
83762011-12-05 Kenichi Handa <handa@m17n.org>
8377
8378 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
8379 return Qnil (Bug#8046, Bug#10193).
8380
5eb05ea3
KH
83812011-12-05 Kenichi Handa <handa@m17n.org>
8382
8383 * coding.c (encode_designation_at_bol): New args charbuf_end and
8384 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
8385 (coding_set_source): Return how many bytes coding->source was
8386 relocated.
8387 (coding_set_destination): Return how many bytes
8388 coding->destination was relocated.
8389 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 8390 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
8391
83922011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
8393
8394 * coding.c (CODING_CHAR_CHARSET_P): New macro.
8395 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
8396 macro (Bug#9318).
8397
83982011-12-05 Andreas Schwab <schwab@linux-m68k.org>
8399
8400 The following changes are to fix Bug#9318.
8401
a79703f5 8402 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
8403 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
8404 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 8405 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 8406
7dbda6df
JB
84072011-12-05 Juanma Barranquero <lekktu@gmail.com>
8408
8409 * lisp.h (process_quit_flag): Fix external declaration.
8410
6d5eb5b0
SM
84112011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
8412
8413 Don't macro-inline non-performance-critical code.
8414 * eval.c (process_quit_flag): New function.
8415 * lisp.h (QUIT): Use it.
8416
a0c3fad0
JD
84172011-12-04 Jan Djärv <jan.h.d@swipnet.se>
8418
8419 * nsfns.m (get_geometry_from_preferences): New function.
8420 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
8421
6c07aac2
AS
84222011-12-04 Andreas Schwab <schwab@linux-m68k.org>
8423
8424 * emacs.c (Qkill_emacs): Define.
8425 (syms_of_emacs): Initialize it.
8426 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
8427 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
8428 (quit_throw_to_read_char): Add parameter `from_signal'.
8429 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
8430 * lisp.h (QUIT): Call Fkill_emacs if requested.
8431
c052ead4
JD
84322011-12-03 Jan Djärv <jan.h.d@swipnet.se>
8433
8434 * widget.c (update_wm_hints): Return if wmshell is null.
8435 (widget_update_wm_size_hints): New function.
8436
8437 * widget.h (widget_update_wm_size_hints): Declare.
8438
8439 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
8440 widget_update_wm_size_hints (Bug#10104).
8441
9e49252b
EZ
84422011-12-03 Eli Zaretskii <eliz@gnu.org>
8443
8444 * xdisp.c (handle_invisible_prop): If the invisible text ends just
8445 before a newline, prepare the bidi iterator for consuming the
8446 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 8447 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 8448
02b16839
JL
84492011-12-02 Juri Linkov <juri@jurta.org>
8450
8451 * search.c (Fword_search_regexp): New Lisp function created from
8452 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
8453 (Fword_search_backward, Fword_search_forward)
8454 (Fword_search_backward_lax, Fword_search_forward_lax):
8455 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
8456 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
8457
0068070e
SM
84582011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
8459
8460 * fileio.c (Finsert_file_contents): Move after-change-function call
8461 to before the "handled:" label, since all "goto handled" appear in
8462 cases where the *-change-functions have already been properly called
8463 (bug#10117).
8464
3360a3fc
AS
84652011-12-01 Andreas Schwab <schwab@linux-m68k.org>
8466
8467 * keyboard.c (interrupt_signal): Don't call kill-emacs when
8468 waiting for input. (Bug#10169)
8469
73d6c093
EZ
84702011-11-30 Eli Zaretskii <eliz@gnu.org>
8471
8472 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
8473 verifies glyph row's hash code--we have just reallocated the
8474 glyphs, so their contents can be complete garbage. (Bug#10164)
8475
febe6bea
JB
84762011-11-30 Juanma Barranquero <lekktu@gmail.com>
8477
8478 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
8479
801a4313
EZ
84802011-11-30 Eli Zaretskii <eliz@gnu.org>
8481
8482 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
8483 attributes are tested _before_ calling verify_row_hash, to protect
8484 against GCC re-ordering of the tests. (Bug#10164)
8485
2b56b87e
JD
84862011-11-29 Jan Djärv <jan.h.d@swipnet.se>
8487
8488 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
8489
8490 * xterm.c (handle_one_xevent): Only set async_visible and friends
8491 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 8492 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
8493 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
8494
dbf31225
PE
84952011-11-28 Paul Eggert <eggert@cs.ucla.edu>
8496
8497 Remove GCPRO-related macros that exist only to avoid shadowing locals.
8498 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
8499 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
8500 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
8501 All uses changed to use GCPRO1 etc.
8502 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
8503 Revert to old implementation (i.e., before 2011-03-11).
8504
1305621b
YM
85052011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8506
8507 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
8508 of scroll runs so as to avoid assigning disabled bogus rows and
8509 unnecessary graphics copy operations.
8510
8c9afb46
EZ
85112011-11-27 Eli Zaretskii <eliz@gnu.org>
8512
8513 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
8514 (snprintf) [_MSC_VER]: Redirect to _snprintf.
8515 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
8516 (malloc, free, realloc, calloc): Redirect to e_* only when
8517 compiling Emacs.
8518
8519 * lisp.h (GCTYPEBITS): Move before first use.
8520 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
8521 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
8522 this macro definition.
8523
8524 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
8525 _MSC_VER.
8526
54e9e3bf
JD
85272011-11-27 Jan Djärv <jan.h.d@swipnet.se>
8528
6d5eb5b0
SM
8529 * gtkutil.c (xg_create_frame_widgets):
8530 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
8531 present with Gtk+ 2.0.
8532
83aca1cb
PE
85332011-11-26 Paul Eggert <eggert@cs.ucla.edu>
8534
8535 * fileio.c (Finsert_file_contents): Undo previous change; see
8536 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
8537
5b76caa4
PE
85382011-11-26 Paul Eggert <eggert@cs.ucla.edu>
8539
8540 Rename locals to avoid shadowing.
8541 * fileio.c (Finsert_file_contents):
8542 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
8543 * process.c (wait_reading_process_output):
8544 Rename inner 'proc' to 'p' to avoid shadowing.
8545 Indent for consistency with usual Emacs style.
8546
8c535114
EZ
85472011-11-25 Eli Zaretskii <eliz@gnu.org>
8548
8549 * xdisp.c (redisplay_window): If cursor row is not fully visible
8550 after recentering, and scroll-conservatively is set to a large
8551 number, scroll window by a few more lines to make the cursor fully
8552 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
8553 (start_display): Don't move to the next line if the display should
8554 start at a newline that is part of a display vector or an overlay
8555 string. (Bug#10119)
8c535114 8556
fa4fdb5c
JL
85572011-11-24 Juri Linkov <juri@jurta.org>
8558
8559 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
8560 after the `MagickPingImage' call. (Bug#10112)
8561
90ec88df
CY
85622011-11-23 Chong Yidong <cyd@gnu.org>
8563
8564 * window.c (Fcoordinates_in_window_p): Accept only live windows.
8565
56e2e794
MR
85662011-11-23 Martin Rudalics <rudalics@gmx.at>
8567
8568 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
8569 making another buffer current. (Bug#10114)
8570
b6e64c41
GM
85712011-11-23 Glenn Morris <rgm@gnu.org>
8572
8573 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
8574
6b21de18
CY
85752011-11-23 Chong Yidong <cyd@gnu.org>
8576
8577 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
8578 using it (Bug#5984).
8579
b12cd789
EZ
85802011-11-22 Eli Zaretskii <eliz@gnu.org>
8581
8582 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
8583 and header-lines, as they don't have one computed for them.
8584 (Bug#10098)
8585
8586 * .gdbinit (prow): Make displayed values more self-explaining.
8587 Add row's hash code.
8588
261b6fd4
LMI
85892011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
8590
8591 * process.c (wait_reading_process_output): Fix asynchrounous
8592 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 8593 (wait_reading_process_output): Add comment and URL.
261b6fd4 8594
e7cfd277
JD
85952011-11-21 Jan Djärv <jan.h.d@swipnet.se>
8596
8597 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
8598
a9b9b7f5
CY
85992011-11-21 Chong Yidong <cyd@gnu.org>
8600
8601 * window.c (Fnext_window, Fprevious_window): Doc fix.
8602
b0d15b4f
SM
86032011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
8604
8605 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
8606
fe7a3057
JB
86072011-11-20 Juanma Barranquero <lekktu@gmail.com>
8608
8609 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
8610
d2999b1a
MR
86112011-11-20 Martin Rudalics <rudalics@gmx.at>
8612
8613 * window.c (Fset_window_combination_limit): Rename argument
8614 STATUS to LIMIT.
8615 (Vwindow_combination_limit): Remove "status" from doc-string.
8616
d5ff9cd0
AS
86172011-11-20 Andreas Schwab <schwab@linux-m68k.org>
8618
8619 * m/ibms390.h: Remove.
8620 * m/ibms390x.h: Don't include "ibms390.h".
8621
a5bb9bd3
SM
86222011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
8623
8624 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
8625 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
8626
cd1181db
JB
86272011-11-20 Juanma Barranquero <lekktu@gmail.com>
8628
8629 * casetab.c (Fset_case_table):
8630 * charset.c (Fcharset_after): Fix typos.
8631
615a3b8d 86322011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 8633
17e845af
PE
8634 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
8635 Otherwise, valgrind does not work on some platforms.
8636 Problem reported by Andreas Schwab in
6a0bf43d
PE
8637 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
8638 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
8639 is set, removing the need for VIRT_ADDRESS_VARIES.
8640 (PURE_P): Use a more-efficient implementation that needs just one
8641 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
8642 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
8643 to 4 (xorl, subq, cmpq, setbe).
8644 * alloc.c (pure): Always extern now, since that's the
8645 VIRT_ADDR_VARIES behavior.
8646 (PURE_POINTER_P): Use a single comparison, not two, for
8647 consistency with the new puresize.h.
8648 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
8649 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
8650 Remove VIRT_ADDR_VARIES no longer needed.
8651
f8fe6f96
EZ
86522011-11-19 Eli Zaretskii <eliz@gnu.org>
8653
8654 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
8655 (erase_phys_cursor, update_window_cursor, show_mouse_face)
8656 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
8657 behave as if the cursor position were at the window margin.
8658
8659 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
8660 and the cursor position is out of bounds, behave as if the cursor
8661 position were at the window margin. (Bug#10075)
8662
df05a53c
CY
86632011-11-18 Chong Yidong <cyd@gnu.org>
8664
8665 * window.c (Fwindow_combination_limit): Make first argument
8666 non-optional, since it is meaningless for live windows like the
8667 selected window.
61ccba97 8668
2071918e
DA
86692011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
8670
8671 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
8672
b50a28de
SM
86732011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
8674
8675 * intervals.c: Fix grafting over the whole buffer (bug#10071).
8676 (graft_intervals_into_buffer): Simplify.
8677
015137db
EZ
86782011-11-18 Eli Zaretskii <eliz@gnu.org>
8679
8680 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
8681 hash values of the two rows.
8682 (copy_row_except_pointers): Preserve the used[] arrays and the
8683 hash values of the two rows. (Bug#10035)
68c95424 8684 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
8685
8686 * xdisp.c (row_hash): New function, body extracted from
8687 compute_line_metrics.
8688 (compute_line_metrics): Call row_hash, instead of computing the
8689 hash code inline.
8690
8691 * dispnew.c (verify_row_hash): Call row_hash for computing the
8692 hash code of a row, instead of duplicating code from xdisp.c.
8693
8694 * dispextern.h (row_hash): Add prototype.
8695
a2addb04
TH
86962011-11-18 Tassilo Horn <tassilo@member.fsf.org>
8697
8698 * frame.c (delete_frame): Don't delete the terminal when the last
8699 X frame is closed if emacs is built with GTK toolkit.
8700
df85d315
JB
87012011-11-17 Juanma Barranquero <lekktu@gmail.com>
8702
8703 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
8704
a0c2d0ae
MR
87052011-11-17 Martin Rudalics <rudalics@gmx.at>
8706
8707 * window.c (Vwindow_splits): Rename to
8708 Vwindow_combination_resize. Suggested by Juri Linkov.
8709 (Fsplit_window_internal): Use Vwindow_combination_resize instead
8710 of Vwindow_splits.
8711
58179cce
JB
87122011-11-16 Juanma Barranquero <lekktu@gmail.com>
8713
7877f373
JB
8714 * nsfns.m (Fns_font_name):
8715 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 8716
b6f67890
MR
87172011-11-16 Martin Rudalics <rudalics@gmx.at>
8718
8719 * window.h (window): Rename slot "nest" to "combination_limit".
8720 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
8721 (Fset_window_nest): Rename to Fset_window_combination_limit.
8722 (Vwindow_nest): Rename to Vwindow_combination_limit.
8723 (recombine_windows, make_parent_window, make_window)
8724 (Fsplit_window_internal, saved_window)
8725 (Fset_window_configuration, save_window_save): Rename all
8726 occurrences of window_nest to window_combination_limit.
8727
c7015153
JB
87282011-11-15 Juanma Barranquero <lekktu@gmail.com>
8729
8730 * image.c (imagemagick_load_image): Fix typo.
8731
322ad6ec
EZ
87322011-11-14 Eli Zaretskii <eliz@gnu.org>
8733
8734 * xdisp.c (display_line): Move the call to
8735 highlight_trailing_whitespace before the call to
8736 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
8737 faces of all the glyphs to compute ROW's hash value.
8738 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 8739
f067b8ec
JB
87402011-11-14 Juanma Barranquero <lekktu@gmail.com>
8741
8742 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
8743 just return (bug#10044).
8744
1e5b2111
EZ
87452011-11-12 Eli Zaretskii <eliz@gnu.org>
8746
7ef3cbd5
EZ
8747 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
8748 with user-defined heap size. Bump the default size of the temacs
8749 heap to 27MB, to avoid memory warning when running temacs.
8750 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
8751
1e5b2111
EZ
8752 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
8753 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
8754 (verify_row_hash) [XASSERTS]: New function.
8755 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
8756 that the hash value of glyph rows is correct.
1e5b2111 8757
89d61221
MR
87582011-11-12 Martin Rudalics <rudalics@gmx.at>
8759
8760 * window.h (window): Remove splits slot.
8761 * window.c (Fwindow_splits, Fset_window_splits): Remove.
8762 (Fdelete_other_windows_internal, make_parent_window)
8763 (make_window, Fsplit_window_internal, Fdelete_window_internal)
8764 (Fset_window_configuration, save_window_save): Don't deal with
8765 split status of windows.
8766 (saved_window): Remove splits slot.
8767 (Vwindow_splits): Rewrite doc-string.
8768
97f18cc8
JD
87692011-11-11 Jan Djärv <jan.h.d@swipnet.se>
8770
8771 * xfns.c (unwind_create_frame):
8772 * nsfns.m (unwind_create_frame):
8773 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
8774 Vframe_list (Bug#9999).
8775
22a648b4
DA
87762011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
8777
0b381c7e 8778 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 8779
659afede
KH
87802011-11-11 Kenichi Handa <handa@m17n.org>
8781
8782 * callproc.c (Fcall_process): Set the member dst_multibyte of
8783 process_coding.
8784
9ac0394b
KH
87852011-11-11 Johan Bockgård <bojohan@gnu.org>
8786
8787 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
8788 avoid a crash (bug#9496).
8789
2fbdc249
CY
87902011-11-09 Chong Yidong <cyd@gnu.org>
8791
8792 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
8793 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
8794
ac6b1f81
PE
87952011-11-08 Paul Eggert <eggert@cs.ucla.edu>
8796
8797 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
8798
09db192c
PE
87992011-11-08 Paul Eggert <eggert@cs.ucla.edu>
8800
8801 Avoid some portability problems by eschewing 'extern inline' functions.
8802 The trivial performance wins aren't worth the portability hassles; see
8803 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
8804 et seq.
8805 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
8806 (window_box_width, window_box_left, window_box_left_offset)
8807 (window_box_right, window_box_right_offset): Undo previous change,
8808 by removing the "extern"s.
8809 * intervals.c (adjust_intervals_for_insertion)
8810 (adjust_intervals_for_deletion): Undo previous change,
8811 making these static again.
8812 (offset_intervals, temp_set_point_both, temp_set_point)
8813 (copy_intervals_to_string): No longer inline.
8814 * xdisp.c (window_text_bottom_y, window_box_width)
8815 (window_box_height, window_box_left_offset)
8816 (window_box_right_offset, window_box_left, window_box_right)
8817 (window_box): No longer inline.
8818
105216ed
CY
88192011-11-08 Chong Yidong <cyd@gnu.org>
8820
8821 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
8822 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
8823 Signal an error if not a live window.
105216ed
CY
8824 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
8825 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
8826
ae9e237f
JB
88272011-11-07 Juanma Barranquero <lekktu@gmail.com>
8828
8829 * lisp.h (syms_of_abbrev): Remove declaration.
8830 Reported by CHENG Gao <chenggao@royau.me>.
8831
c7aa8333
EZ
88322011-11-07 Eli Zaretskii <eliz@gnu.org>
8833
8834 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
8835 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
8836 of temacs in GUI mode.
8837
be7f5545
MR
88382011-11-07 Martin Rudalics <rudalics@gmx.at>
8839
8840 * window.h: Declare delete_all_child_windows instead of
8841 delete_all_subwindows.
8842 * window.c (Fwindow_nest, Fset_window_nest)
8843 (Fset_window_new_total, Fset_window_new_normal)
8844 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
8845 (delete_all_subwindows): Rename to delete_all_child_windows.
8846 (Fdelete_other_windows_internal, Fset_window_configuration):
8847 Call delete_all_child_windows instead of delete_all_subwindows.
8848 * frame.c (delete_frame): Call delete_all_child_windows instead
8849 of delete_all_subwindows.
8850
ca78dc43
PE
88512011-11-07 Paul Eggert <eggert@cs.ucla.edu>
8852
8853 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
8854 This is also needed for porting to any host where GC_MARK_STACK is
8855 not GC_MAKE_GCPROS_NOOPS.
8856 (which_symbols): Use it.
8857
a0241d01
KH
88582011-11-07 Kenichi Handa <handa@m17n.org>
8859
8860 * coding.c (coding_set_destination): Check coding->src_pos only
8861 when coding->src_object is a buffer (bug#9910).
8862
8863 * process.c (send_process): Set the member src_multibyte of coding
8864 to 0 (bug#9911) when sending a unibyte text.
8865
8866 * callproc.c (Fcall_process): Set the member src_multibyte of
8867 process_coding to 0 (bug#9912).
8868
a64bfdfa 88692011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
8870
8871 * xmenu.c (cleanup_widget_value_tree): New function.
8872 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
8873 calling free_menubar_widget_value_tree directly (Bug#9830).
8874
cb41b32a
PE
88752011-11-06 Paul Eggert <eggert@cs.ucla.edu>
8876
8877 Fix some portability problems with 'inline'.
8878 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
8879 (window_box_width, window_box_left, window_box_left_offset)
8880 (window_box_right, window_box_right_offset): Declare extern.
8881 Otherwise, these inline functions do not conform to C99 and
8882 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
8883 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
8884 * intervals.c (adjust_intervals_for_insertion)
8885 (adjust_intervals_for_deletion): Now extern, because otherwise the
8886 extern inline functions 'offset_intervals' couldn't refer to it.
8887 (static_offset_intervals): Remove.
8888 (offset_intervals): Rewrite using the old contents of
8889 static_offset_intervals. The old version didn't conform to C99
8890 because an extern inline function contained a reference to an
8891 identifier with static linkage.
8892
b7041366
AS
88932011-11-06 Andreas Schwab <schwab@linux-m68k.org>
8894
8895 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
8896 GC.
8897
88a37c4d
EZ
88982011-11-06 Eli Zaretskii <eliz@gnu.org>
8899
8900 * xdisp.c (init_iterator, reseat_to_string): Don't set the
8901 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
8902 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
8903 return Qleft_to_right.
8904
49745b39
CY
89052011-11-06 Chong Yidong <cyd@gnu.org>
8906
8907 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
8908 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
8909 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
8910 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
8911 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
8912 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
8913 (Fwindow_vscroll): Doc fix.
8914 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
8915 argument, since it makes no sense to pass a live window and for
8916 consistency with window-child.
8917
1f05cd82
CS
89182011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
8919
8920 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
8921 support MSVC.
8922
22610910
JR
89232011-11-05 Jason Rumney <jasonr@gnu.org>
8924
8925 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
8926 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
8927 fonts (Bug#6029).
8928 (add_font_entity_to_list): Fix logic errors in mixed boolean and
8929 bitwise arithmetic preventing use of unicode-sip and non-truetype
8930 opentype fonts.
8931
a06776b2
EZ
89322011-11-05 Eli Zaretskii <eliz@gnu.org>
8933
3ad924ba
EZ
8934 * s/ms-w32.h (fstat, stat, utime): Move redirections to
8935 "emacs"-only part.
8936
a06776b2
EZ
8937 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
8938 initialization code to keep similarity to xfns.c after changes
8939 from 2011-11-05.
8940
c9e7db78
JD
89412011-11-05 Jan Djärv <jan.h.d@swipnet.se>
8942
a97f8f3f
JD
8943 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
8944 (unwind_create_frame): New function (Bug#9943).
8945 (Fx_create_frame): Restructure code to be more similar to the one in
8946 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
8947 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
8948 Move terminal->reference_count++ just before making the frame official
8949 (Bug#9943).
8950
8951 * nsterm.m (x_free_frame_resources): New function.
8952 (x_destroy_window): Move code to x_free_frame_resources.
8953
c9e7db78 8954 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
8955 (Fx_create_frame, x_create_tip_frame):
8956 Move terminal->reference_count++ just before making the frame
75f1671a 8957 official. Move initialization of image_cache_refcount and
c9e7db78
JD
8958 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
8959
a6fc3b5c
EZ
89602011-11-05 Eli Zaretskii <eliz@gnu.org>
8961
8962 Support MSVC build with newer versions of Visual Studio.
8963 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
8964 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
8965 nt/gmake.defs.
8966
8967 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
8968 which are not supported by MSVC.
8969 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
8970 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
8971 bitfields.
8972 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
8973 types in bitfields.
8974 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
8975
8976 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
8977
58179cce 89782011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
8979
8980 Support MSVC build with newer versions of Visual Studio.
8981 * w32.c: Don't include w32api.h for MSVC.
8982 (init_environment) [_MSC_VER]: Call sys_access, not _access.
8983
8984 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
8985 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
8986 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
8987 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
8988 e_* cousins.
8989 (alloca) [_MSC_VER]: Define to _alloca.
8990
8991 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
8992
8993 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
8994
a58c13ed
EZ
89952011-11-04 Eli Zaretskii <eliz@gnu.org>
8996
8997 * xdisp.c (note_mouse_highlight): If either of
8998 previous/next-single-property-change returns nil, treat that as
8999 the beginning or the end of the buffer. (Bug#9955)
9000
fe0b6370
JD
90012011-11-04 Jan Djärv <jan.h.d@swipnet.se>
9002
a58c13ed 9003 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
9004 label is not null (Bug#9951).
9005 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
9006 may be NULL.
9007
89bd5ee1
EZ
90082011-11-04 Eli Zaretskii <eliz@gnu.org>
9009
9010 * window.c (Fwindow_body_size): Mention in the doc string that the
9011 return value is in frame's canonical units. (Bug#9949)
9012
84c3edb9
EZ
90132011-11-03 Eli Zaretskii <eliz@gnu.org>
9014
4e2fb5c7
EZ
9015 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
9016
84c3edb9 9017 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 9018 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 9019 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 9020
bc17a887
EZ
90212011-11-01 Eli Zaretskii <eliz@gnu.org>
9022
9023 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
9024 Don't stop backward scan on the continuation glyph, even though
9025 its CHARPOS is positive.
6d5eb5b0
SM
9026 (mouse_face_from_buffer_pos, note_mouse_highlight):
9027 Rename cover_string to disp_string.
bc17a887 9028
4ee88440
MR
90292011-11-01 Martin Rudalics <rudalics@gmx.at>
9030
9031 * window.c (temp_output_buffer_show): Don't use
9032 Vtemp_buffer_show_specifiers.
9033 (Vtemp_buffer_show_specifiers): Remove unused variable.
9034
c2ff3c02
EZ
90352011-10-30 Eli Zaretskii <eliz@gnu.org>
9036
9037 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
9038 past the beginning of the current glyph matrix.
9039
58179cce 90402011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
9041
9042 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
9043 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
9044 HAVE_GTK3 (Bug#9869).
b77a6a7f 9045
3b574623
JD
9046 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
9047 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
9048
b77a6a7f
JD
9049 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
9050
9051 * xterm.c: Declare x_handle_net_wm_state to return int.
9052 (handle_one_xevent): Check if we are iconified but don't have
9053 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
9054 (get_current_wm_state): Return non-zero if not hidden,
9055 check for _NET_WM_STATE_HIDDEN (Bug#9893).
9056 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
9057 (x_handle_net_wm_state): Return what get_current_wm_state returns.
9058 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
9059
196e41e4
PE
90602011-10-29 Paul Eggert <eggert@cs.ucla.edu>
9061
9062 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
9063 so that this new function doesn't get optimized away by a
9064 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
9065
021f2e1a
AS
90662011-10-29 Andreas Schwab <schwab@linux-m68k.org>
9067
9068 * frame.h (MOUSE_HL_INFO): Remove excess parens.
9069
8b058d44
EZ
90702011-10-29 Eli Zaretskii <eliz@gnu.org>
9071
9072 Fix the `xbytecode' command.
9073 * .gdbinit (xprintbytestr): New command.
b50a28de 9074 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
9075 (xbytecode): Print the byte-code string as well.
9076
4452fb80
EZ
90772011-10-29 Kim Storm <storm@cua.dk>
9078
8b058d44
EZ
9079 * alloc.c (which_symbols): New function.
9080
21b72067
AS
90812011-10-29 Andreas Schwab <schwab@linux-m68k.org>
9082
9083 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
9084 line. (Bug#9903)
9085
83ed7b5c
GM
90862011-10-29 Glenn Morris <rgm@gnu.org>
9087
9088 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
9089 Not clear what it was for, and it causes various bugs. (Bug#9839)
9090
5a7a728b
EZ
90912011-10-28 Eli Zaretskii <eliz@gnu.org>
9092
9093 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
9094 possible random value that matches one of those tested as
9095 condition to clear the mouse face.
9096
d3d0842f
CY
90972011-10-28 Chong Yidong <cyd@gnu.org>
9098
9099 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
9100
31b39d13
DN
91012011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
9102
9103 * window.c (make_window): Initialize phys_cursor_on_p.
9104
9aba6043
SM
91052011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
9106
9107 * lisp.h (struct Lisp_Symbol): Update comments.
9108
c20992f4
JB
91092011-10-28 Juanma Barranquero <lekktu@gmail.com>
9110
9111 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
9112
db4f02f2
EZ
91132011-10-28 Eli Zaretskii <eliz@gnu.org>
9114
9115 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
9116 <oslsachem@gmail.com> for helping to debug this.
9117
9118 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
9119 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
9120 (g_b_init_get_glyph_outline_w): New static variables.
9121 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
9122 (GetGlyphOutlineW_Proc): New typedefs.
9123 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
9124 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
9125 New functions.
9126 (w32font_open_internal, compute_metrics):
9127 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
9128 instead of calling the "wide" APIs directly.
9129
9130 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
9131
9132 * w32.h (syms_of_w32font): Add prototype.
9133
87e68db4
JB
91342011-10-27 Juanma Barranquero <lekktu@gmail.com>
9135
9136 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
9137 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
9138 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
9139 (Fmove_to_window_line): Doc fix.
9140
435c1d67
CY
91412011-10-27 Chong Yidong <cyd@gnu.org>
9142
9143 * process.c (make_process): Set gnutls_state to NULL.
9144
9145 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
9146 non-NULL, regardless of GNUTLS_INITSTAGE.
9147 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
9148 an error. Set process slots as soon as we allocate them.
9149
9150 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
9151
9c6c6f49
CY
91522011-10-27 Chong Yidong <cyd@gnu.org>
9153
9aba6043
SM
9154 * gnutls.c (emacs_gnutls_deinit): New function.
9155 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
9156 (Fgnutls_deinit, Fgnutls_boot): Use it.
9157
9158 * process.c (make_process): Initialize GnuTLS credentials to NULL.
9159 (deactivate_process): Call emacs_gnutls_deinit.
9160
657d08d3
JB
91612011-10-27 Juanma Barranquero <lekktu@gmail.com>
9162
9163 * image.c (x_create_x_image_and_pixmap):
9164 * w32.c (sys_rename, w32_delayed_load):
9165 * w32font.c (fill_in_logfont):
9166 * w32reg.c (x_get_string_resource): Silence compiler warnings.
9167
5430d399
JB
91682011-10-26 Juanma Barranquero <lekktu@gmail.com>
9169
9170 * w32fns.c (w32_default_color_map): New function,
9171 extracted from Fw32_default_color_map.
a7ef684b 9172 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 9173
fe0055fa
PE
91742011-10-25 Paul Eggert <eggert@cs.ucla.edu>
9175
9176 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
9177
e6346438
SM
91782011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
9179
9180 * keyboard.c (test_undefined): New function (bug#9751).
9181 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
9182
e112cc37
ET
91832011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
9184
9185 * sysdep.c (init_sys_modes): Fix the check for the controlling
9186 terminal (Bug#6649).
9187
7b5d6677
EZ
91882011-10-20 Eli Zaretskii <eliz@gnu.org>
9189
9190 * dispextern.h (struct bidi_it): New member next_en_type.
9191
9192 * bidi.c (bidi_line_init): Initialize the next_en_type member.
9193 (bidi_resolve_explicit_1): When next_en_pos is valid for the
9194 current character, check also for next_en_type being WEAK_EN.
9195 (bidi_resolve_weak): Don't enter the expensive loop if the current
9196 position is before next_en_pos. Record the bidi type of the first
9197 non-ET, non-BN character we find, in addition to its position.
9198 (bidi_level_of_next_char): Invalidate next_en_type when
9199 next_en_pos is over-stepped.
9200
7da0b018
PE
92012011-10-20 Paul Eggert <eggert@cs.ucla.edu>
9202
9203 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
9204 * editfns.c: Rewrite current-time-zone so that it invokes
9205 the equivalent of (format-time-string "%Z") to get the time zone name.
9206 This fixes a bug when the time zone name contains characters that
9207 need converting from the system time locale to Emacs internal format.
9208 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
9209 that patch fixed format-time-string to do the conversion, but
9210 I forgot to fix current-time-zone.
9211 (format_time_string): New function, containing most of
9212 what Fformat_time_string used to contain.
9213 (Fformat_time_string): Rewrite in terms of format_time_string.
9214 This doesn't change this function's behavior.
9215 (current-time-zone): Rewrite to use format_time_string.
9216 This fixes the bug reported by Michael Schierl in
9217 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
9218 Jason Rumney's 2007-06-07 change worked around this bug, but
9219 didn't fix it.
9220 * systime.h (tzname, timezone): Remove no-longer-used declarations.
9221
8547b010
EZ
92222011-10-19 Eli Zaretskii <eliz@gnu.org>
9223
9224 * xdisp.c (start_display): If the character at POS is displayed
9225 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
9226 (try_window_reusing_current_matrix): If a line ends in a display
9227 vector or the next line starts in a display vector, continue
9228 redrawing the window even though the character position of
9229 start_row was reached.
8547b010
EZ
9230 (Bug#9771, part 2)
9231
4e948d15
CY
92322011-10-18 Chong Yidong <cyd@gnu.org>
9233
9234 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
9235 with nobreak-char-display too.
9236
4787455f
EZ
92372011-10-18 Eli Zaretskii <eliz@gnu.org>
9238
9239 Fix part 3 of bug#9771.
9240 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
9241 (bidi_resolve_neutral): Don't enter the expensive loop looking for
9242 non-neutral characters if the current character is a paragraph
9243 separator (a.k.a. Newline). This avoids running the same
9244 expensive loop twice, once when we consume the preceding newline
9245 and the other time when the line actually needs to be displayed.
9246 Avoid the loop when we see neutrals on the base embedding level
9247 following a character whose directionality is the same as the
9248 paragraph's. This avoids running the expensive loop when a line
9249 ends in a long sequence of neutrals, like control characters.
9250 Add assertion against STRONG_AL type. Slightly rearrange code
9251 that determines the type of a neutral given the first non-neutral
9252 that follows it.
9253 (bidi_level_of_next_char): Set next_en_pos to zero when
9254 invalidating its info.
9255
2c91f553
EZ
92562011-10-17 Eli Zaretskii <eliz@gnu.org>
9257
9258 * xdisp.c (push_display_prop): Determine whether to record string
9259 or buffer position by IT->string, not by IT->method. Allow
9260 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
9261 (move_it_vertically_backward): Don't look for character position
9262 immediately after the newline when in a continuation line.
9263 (Bug#9771, part 1)
2c91f553 9264
c7b08b0d
MR
92652011-10-15 Martin Rudalics <rudalics@gmx.at>
9266
9267 * window.c (coordinates_in_window): Rewrite and delabelize
9268 vertical border check. (Bug#5357) (Bug#9618)
9269
6b02f655
SM
92702011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
9271
9272 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
9273 errors in XSetWindowBorder (bug#9310).
9274
81d40c92
DA
92752011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
9276
9277 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
9278 avoid crash when xmalloc overrun checking is enabled.
9279
d4172c3b
EZ
92802011-10-13 Eli Zaretskii <eliz@gnu.org>
9281
9282 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
9283 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
9284 cursor motion with <left> and <right> arrow keys.
9285
9286 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
9287 some callers set that themselves.
9288
b00eea75
EZ
92892011-10-12 Eli Zaretskii <eliz@gnu.org>
9290
9291 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
9292 display string and the previous row comes from the same string and
9293 is empty. (Bug#9739) (Bug#9738)
9294
8fe012c4
SM
92952011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
9296
9297 * doc.c (get_doc_string): Encode file name (bug#9735).
9298
0074aef2
EZ
92992011-10-12 Eli Zaretskii <eliz@gnu.org>
9300
79beb178
EZ
9301 * bidi.c (bidi_level_of_next_char):
9302 * xdisp.c (get_visually_first_element): Remove old incorrect
9303 comments regarding the Unicode Line Separator character.
9304
0074aef2
EZ
9305 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
9306
6e4b3fbe
DA
93072011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
9308
9309 * alloc.c (Fgc_status): Do not access beyond zombies array
9310 boundary if nzombies > MAX_ZOMBIES.
9311 * alloc.c (dump_zombies): Add missing format specifier.
9312
0324f3af
PE
93132011-10-12 Paul Eggert <eggert@cs.ucla.edu>
9314
b5525cac
PE
9315 * xdisp.c (set_cursor_from_row): Simplify conditionals,
9316 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
9317
0324f3af
PE
9318 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
9319 Some packages use them to denote characters with modifiers.
9320
e9b5f888
AS
93212011-10-11 Andreas Schwab <schwab@linux-m68k.org>
9322
9323 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
9324 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
9325 matching a pp-number. Rename parameter var to var1.
9326
127827c0
SM
93272011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
9328
9329 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
9330
c8fd3bd0
GM
93312011-10-08 Glenn Morris <rgm@gnu.org>
9332
9333 * callint.c (Fcall_interactively): Give a more explicit error for the
9334 'c' case with a non-character input. (Bug#8479)
9335
352ec8ff
EZ
93362011-10-08 Eli Zaretskii <eliz@gnu.org>
9337
03669ccb
EZ
9338 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
9339 lines.
7061c986
EZ
9340 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
9341 lines that are hscrolled on the left.
03669ccb 9342
352ec8ff
EZ
9343 * dispnew.c (buffer_posn_from_coords): Account for a possible
9344 presence of header-line. (Bug#4426)
9345
a66cfb1c
SM
93462011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
9347
6b02f655
SM
9348 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
9349 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 9350
7c5ee88e
PE
93512011-10-07 Paul Eggert <eggert@cs.ucla.edu>
9352
9353 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
9354 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
9355 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
9356 this makes Emacs dump core during garbage collection on rare
9357 occasions. sizeof is obviously inferior to offsetof here, so
9358 stick with offsetof.
9359 (GC_POINTER_ALIGNMENT): New macro.
9360 (mark_memory): Omit 3rd (offset) arg; caller changed.
9361 Don't assume EMACS_INT alignment is the same as pointer alignment.
9362
df1bbe5b
SM
93632011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
9364
9365 * keyboard.c (read_key_sequence_remapped): New var.
9366 (read_key_sequence): Compute remapping in the right buffer.
9367 (command_loop_1): Use read_key_sequence's remapping directly.
9368
51553db6
SM
93692011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
9370
32c1fffd
SM
9371 * dired.c (file_name_completion): Don't expand file name.
9372 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
9373 before checking file name handler.
9374
51553db6
SM
9375 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
9376 they've been requested explicitly (bug#9591).
9377
b6bd1599 93782011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
9379
9380 * keymap.c (Fsingle_key_description): Use make_specified_string
9381 instead of build_string to build string from push_key_description.
9382 (Bug#5193)
9383
f701dc2a
PE
93842011-09-30 Paul Eggert <eggert@cs.ucla.edu>
9385
4222c55d
PE
9386 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
9387 This fixes a Y2038 bug on 64-bit hosts.
9388 * buffer.c (reset_buffer):
9389 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
9390 (Fclear_buffer_auto_save_failure):
9391 Use 0, not -1, to represent an unset failure time, since time_t
9392 might not be signed.
9393
f701dc2a
PE
9394 Remove dependency on glibc malloc internals.
9395 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
9396 Move back here from lisp.h, but with their new implementations.
9397 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
9398 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
9399 * charset.c (charset_table_init): New static var.
9400 (syms_of_charset): Use it instead of xmalloc. This removes a
9401 dependency on glibc malloc internals. See Eli Zaretskii's comment in
9402 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
9403 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
9404 Move back to alloc.c.
9405 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
9406 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
9407
9ceebf39
JD
94082011-09-30 Jan Djärv <jan.h.d@swipnet.se>
9409
9410 * nsterm.m (windowDidResize): Call x_set_window_size only when
9411 ns_in_resize is true. Otherwise set pixelwidth/height and
9412 call change_frame_size (Bug#9628).
9413
cb993c58
PE
94142011-09-30 Paul Eggert <eggert@cs.ucla.edu>
9415
3930c88b
PE
9416 Port --enable-checking=all to Fedora 14 x86-64.
9417 * charset.c (syms_of_charset): Also account for glibc malloc's
9418 internal overhead when calculating the initial malloc maximum.
9419
cb993c58
PE
9420 Port --enable-checking=all to Fedora 14 x86.
9421 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
9422 Move to lisp.h.
9423 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
9424 (overrun_check_realloc, overrun_check_free):
9425 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
9426 That way, xmalloc returns a properly-aligned pointer even if
9427 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
9428 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
9429 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
9430 into account when calculating the initial malloc maximum.
9431 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
9432 Move here from alloc.c, so that charset.c can use it too.
9433 Properly align; the old code wasn't right for common 32-bit hosts
9434 when configured with --enable-checking=all.
9435 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
9436 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
9437
31bed486
EZ
94382011-09-29 Eli Zaretskii <eliz@gnu.org>
9439
04c70788 9440 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
9441 use EDOM.
9442
fbcaa2f3
EZ
94432011-09-28 Eli Zaretskii <eliz@gnu.org>
9444
9445 * xdisp.c (compute_display_string_end): If there's no display
9446 string at CHARPOS, return -1.
9447
9448 * bidi.c (bidi_fetch_char): When compute_display_string_end
9449 returns a negative value, treat the character as a normal
9450 character not covered by a display string. (Bug#9624)
9451
a239d4e9
JB
94522011-09-28 Juanma Barranquero <lekktu@gmail.com>
9453
9454 * lread.c (Fread_from_string): Fix typo in docstring.
9455
88652fd5
EZ
94562011-09-27 Eli Zaretskii <eliz@gnu.org>
9457
9458 * xdisp.c (handle_invisible_prop): If invisible text ends on a
9459 newline, reseat the iterator instead of bidi-iterating there one
9460 character at a time. (Bug#9610)
32c1fffd
SM
9461 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
9462 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 9463
ed497dd4
AS
94642011-09-27 Andreas Schwab <schwab@linux-m68k.org>
9465
9466 * lread.c (readevalloop): Use correct code for NBSP.
9467 (read1): Likewise. (Bug#9608)
9468
b2bf61aa
MA
94692011-09-25 Michael Albinus <michael.albinus@gmx.de>
9470
9471 * dbusbind.c (Fdbus_register_signal): When service is not
9472 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
9473
32bbb17c
GM
94742011-09-25 Glenn Morris <rgm@gnu.org>
9475
9476 * buffer.c (truncate-lines): Doc fix.
9477
94e0933e
CY
94782011-09-24 Chong Yidong <cyd@stupidchicken.com>
9479
9480 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
9481 (Fset_window_next_buffers): Doc fix.
9482
cddde921
GM
94832011-09-24 Glenn Morris <rgm@gnu.org>
9484
9485 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
9486
1260aef1
PE
94872011-09-24 Paul Eggert <eggert@cs.ucla.edu>
9488
25b4bfa0
PE
9489 Fix minor problems found by static checking.
9490 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
9491 * indent.c (Fvertical_motion): Fix == vs = typo.
9492
e3cbd34b
EZ
94932011-09-24 Eli Zaretskii <eliz@gnu.org>
9494
a66cfb1c
SM
9495 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
9496 Default value is now t. Doc fix.
6bf7006f 9497
e3cbd34b 9498 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 9499 logic when moving up, not only when moving down. Fix the
e3cbd34b 9500 confusing name and values of the it_overshoot_expected variable;
32c1fffd 9501 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
9502
9503 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
9504 CHARPOS is covered by a display string which includes newlines.
9505 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
9506 is covered by a display string with embedded newlines.
9507
a3de0cbd
MA
95082011-09-24 Michael Albinus <michael.albinus@gmx.de>
9509
9510 * dbusbind.c (Fdbus_register_signal): Add match rule to
9511 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
9512 (Fdbus_register_method, Vdbus_registered_objects_table):
9513 Fix docstring.
a3de0cbd 9514
b260039d
JM
95152011-09-24 Jim Meyering <meyering@redhat.com>
9516
32c1fffd 9517 do not ignore write error for any output size
b260039d
JM
9518 The previous change was incomplete.
9519 While it makes emacs --batch detect the vast majority of stdout
9520 write failures, errors were still ignored whenever the output size is
9521 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
9522 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
9523 && echo FAIL: ignored write error
9524 FAIL: ignored write error
9525 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
9526 && echo FAIL: ignored write error
9527 FAIL: ignored write error
9528 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
9529
8eca8a7c
AS
95302011-09-23 Andreas Schwab <schwab@linux-m68k.org>
9531
9532 * emacs.c (Fkill_emacs): In noninteractive mode exit
9533 non-successfully if a write error occurred on stdout. (Bug#9574)
9534
3341db62
EZ
95352011-09-21 Eli Zaretskii <eliz@gnu.org>
9536
9537 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
9538 the xassert test.
9539
9540 * dispextern.h (struct it): Update the comment documenting what
9541 can it->OBJECT be.
9542
8c203dbf
EZ
95432011-09-20 Eli Zaretskii <eliz@gnu.org>
9544
9545 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
9546 a display string, extend search for cursor position to end of row.
9547 (find_row_edges): If the row ends in a newline from a display
9548 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
9549 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
9550 (Fcurrent_bidi_paragraph_direction): Fix search for previous
9551 non-empty line. Fixes confusing cursor motion with arrow keys at
9552 the beginning of a line that starts with whitespace.
8c203dbf 9553
a4824228
LMI
95542011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9555
9556 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
9557 (bug#9493).
9558
33ed493b
CY
95592011-09-18 Chong Yidong <cyd@stupidchicken.com>
9560
9561 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
9562 boolean (Bug#9154).
9563
56cd55c8
EZ
95642011-09-18 Eli Zaretskii <eliz@gnu.org>
9565
9566 * xdisp.c (display_line): Record maximum and minimum buffer
9567 positions even if no glyphs were produced (e.g., by a zero-width
9568 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
9569 buffer positions that will be removed from the glyph row because
9570 they don't fit.
c02dcedf
EZ
9571 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
9572 column is beyond frame width: don't subtract 1 "pixel" when
9573 computing width of the stretch.
3e62b7e0
EZ
9574 (reseat_at_next_visible_line_start): Undo the change made on
9575 2011-09-17 that saved paragraph information and restored it after
9576 the call to `reseat'. (Bug#9545)
56cd55c8 9577
5ed99d36 95782011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
9579
9580 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
9581 and turn window cursor on if cleared (Bug#9415).
9582
5ed99d36 95832011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
9584
9585 * search.c (boyer_moore): Take unibyte characters from pattern
9586 literally. (Bug#9458)
9587
9bade7b2
EZ
95882011-09-18 Eli Zaretskii <eliz@gnu.org>
9589
9590 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
9591
e5e9d610
PE
95922011-09-18 Paul Eggert <eggert@cs.ucla.edu>
9593
87e4427a
PE
9594 Fix minor problem found by static checking.
9595 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
9596 initialized, to pacify gcc -Wuninitialized.
9597
e5e9d610
PE
9598 * fileio.c: Report proper errno when syscall falls.
9599 (Finsert_file_contents): Save and restore errno,
9600 so that report_file_error outputs the correct diagnostic.
9601 (Fwrite_region) [CLASH_DETECTION]: Likewise.
9602
a1674f0b
EZ
96032011-09-18 Eli Zaretskii <eliz@gnu.org>
9604
9605 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
9606
fbfb6dd4
EZ
96072011-09-17 Eli Zaretskii <eliz@gnu.org>
9608
9609 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
9610 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
9611
bb187662
EZ
96122011-09-17 Eli Zaretskii <eliz@gnu.org>
9613
1137e8b8 9614 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 9615 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
9616
9617 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
9618 (bidi_find_paragraph_start): Search back for paragraph beginning
9619 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
9620 (bidi_move_to_visually_next): Only trigger paragraph-related
9621 computations when the last character is a newline or at EOB, not
9622 just any NEUTRAL_B. (Bug#9470)
9623
bb187662
EZ
9624 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
9625 truncated lines if point is covered by a display string. (Bug#9524)
9626
2e621251
PE
96272011-09-16 Paul Eggert <eggert@cs.ucla.edu>
9628
9629 * xselect.c: Relax test for outgoing X longs (Bug#9498).
9630 (cons_to_x_long): New function.
9631 (lisp_data_to_selection_data): Use it. Correct the test for
9632 short-versus-long data; it was negated. Break out of vector
9633 loop, for efficiency, when a long datum is discovered.
9634
91a15bc6
SM
96352011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
9636
9637 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
9638
b41c3a35
EZ
96392011-09-16 Eli Zaretskii <eliz@gnu.org>
9640
9641 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
9642 GCC PR/17406) by declaring this function with external scope.
9643
7812ba2d
PE
96442011-09-15 Paul Eggert <eggert@cs.ucla.edu>
9645
9646 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
9647 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
9648
cf7edc2a
AS
96492011-09-15 Andreas Schwab <schwab@linux-m68k.org>
9650
9651 * editfns.c (Fformat): Correctly handle text properties on "%%".
9652
bd01620e
EZ
96532011-09-15 Eli Zaretskii <eliz@gnu.org>
9654
9655 * xterm.c (x_draw_composite_glyph_string_foreground):
9656 * w32term.c (x_draw_composite_glyph_string_foreground):
9657 * term.c (encode_terminal_code):
9658 * composite.c (composition_update_it, get_composition_id):
9659 * xdisp.c (get_next_display_element)
9660 (fill_composite_glyph_string): Add comments about special meaning
9661 of TAB characters in a composition.
9662
a02719a3
PE
96632011-09-15 Paul Eggert <eggert@cs.ucla.edu>
9664
9665 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
9666 This occurs when processing a multibyte format.
9667 Problem reported by Wolfgang Jenker.
a02719a3 9668
72589a3c
JB
96692011-09-15 Johan Bockgård <bojohan@gnu.org>
9670
9671 * xdisp.c (try_cursor_movement): Only check for exact match if
9672 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
9673
1c14176c
PE
96742011-09-14 Paul Eggert <eggert@cs.ucla.edu>
9675
9676 Remove unused external symbols.
9677 * dispextern.h (calc_pixel_width_or_height): Remove decl.
9678 * xdisp.c (calc_pixel_width_or_height): Now static.
9679 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
9680 * indent.c (check_display_width):
9681 * w32term.c: Fix comment to match code.
9682 * xterm.c, xterm.h (x_catching_errors): Remove.
9683
d2eea5b5
PE
96842011-09-14 Paul Eggert <eggert@cs.ucla.edu>
9685
9686 * xselect.c: Use signed conversions more consistently (Bug#9498).
9687 (selection_data_to_lisp_data): Assume incoming selection data are
9688 signed integers, not unsigned. This is to be consistent with
9689 outgoing selection data, which was modified to use signed integers
9690 in as part of the fix to Bug#9196 in response to Jan D.'s comment
9691 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
9692 expects long, not unsigned long.
9693
46888499
EZ
96942011-09-14 Eli Zaretskii <eliz@gnu.org>
9695
9696 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
9697 computation of loop end. Reported by Johan Bockgård
9698 <bojohan@gnu.org>.
9699
ef8ef9fb
CY
97002011-09-13 Chong Yidong <cyd@stupidchicken.com>
9701
9702 * frame.c (Fother_visible_frames_p): Function deleted.
9703
fa819fed
EZ
97042011-09-12 Eli Zaretskii <eliz@gnu.org>
9705
9706 * indent.c (compute_motion): Process display vector front to back
9707 rather than the other way around. (Bug#2496)
9708
2ba8e008
SM
97092011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
9710
9711 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
9712
20f53c69
CY
97132011-09-11 Chong Yidong <cyd@stupidchicken.com>
9714
9715 * minibuf.c (Fread_from_minibuffer): Doc fix.
9716
d562d7a4
EZ
97172011-09-11 Eli Zaretskii <eliz@gnu.org>
9718
9719 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
9720 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
9721
1c4d7f3d
LMI
97222011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9723
9724 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
9725 value for non-existent files.
9726
b885bf36
EZ
97272011-09-11 Eli Zaretskii <eliz@gnu.org>
9728
9729 * fileio.c (Finsert_file_contents): If the file cannot be opened,
9730 set its "size" to -1. This will set the modtime_size field of
9731 the corresponding buffer to -1, which is what
9732 verify-visited-file-modtime expects for files that do not exist.
9733 (Bug#9139)
9734
6612f0bf
PE
97352011-09-11 Paul Eggert <eggert@cs.ucla.edu>
9736
9737 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
9738 here ...
9739 * lisp.h: ... from here. push_key_description is no longer
9740 defined in keyboard.c, so its declaration should not be in
9741 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
9742 logically belongs with push_key_description.
9743
dfb3f755
PE
97442011-09-10 Paul Eggert <eggert@cs.ucla.edu>
9745
9746 * buffer.h: Include <sys/types.h> instead of <time.h>.
9747 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
9748 Problem reported by Herbert J. Skuhra.
9749
3134906c
LMI
97502011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
9751
9752 * xml.c (parse_region): Make the parsing work for
9753 non-comment-starting XML files again (bug#9144).
9754
8d903f4e
AS
97552011-09-10 Andreas Schwab <schwab@linux-m68k.org>
9756
9757 * image.c (gif_load): Fix calculation of bottom and right corner.
9758 (Bug#9468)
9759
80ad64f4
EZ
97602011-09-10 Eli Zaretskii <eliz@gnu.org>
9761
9762 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
9763 redisplay in small windows.
9764
208a048d
EZ
97652011-09-09 Eli Zaretskii <eliz@gnu.org>
9766
9767 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
9768
9b1c252e
MR
97692011-09-08 Martin Rudalics <rudalics@gmx.at>
9770
9771 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
9772 Operate on live windows only.
9773
2949f33b
JB
97742011-09-08 Juanma Barranquero <lekktu@gmail.com>
9775
9776 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
9777
e08dcafd
EZ
97782011-09-07 Eli Zaretskii <eliz@gnu.org>
9779
9780 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
9781 only under bidi iteration.
9782
115b96bd
JD
97832011-09-07 Jan Djärv <jan.h.d@swipnet.se>
9784
9785 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
9786
c8199d0f
PE
97872011-09-06 Paul Eggert <eggert@cs.ucla.edu>
9788
9789 isnan: Fix porting problem to Solaris 10 with bundled gcc.
9790 Without this fix, the command to link temacs failed due to an
9791 undefined symbol __builtin_isnan. This is because
9792 /usr/include/iso/math_c99.h #defines isnan(x) to
9793 __builtin_isnan(x), but the bundled gcc, which identifies itself
9794 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
9795 a __builtin_isnan.
9796 * floatfns.c (isnan): #undef, and then #define to a clone of
9797 what's in data.c.
9798 (Fisnan): Always define, since it's always available now.
9799 (syms_of_floatfns): Always define isnan at the Lisp level.
9800
e39b275c 98012011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
9802
9803 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
9804
b2db44d9 98052011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 9806
f4af5137 9807 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
9808 The previous code assumed that file offsets (off_t values) fit in
9809 EMACS_INT variables, which is not true on typical 32-bit hosts.
9810 The code messed up by falsely reporting buffer overflow in cases
9811 such as (insert-file-contents "big" nil 1 2) into an empty buffer
9812 when "big" contains more than 2**29 bytes, even though this
9813 inserts just one byte and does not overflow the buffer.
9814 (Finsert_file_contents): Store file offsets as off_t
9815 values, not as EMACS_INT values. Check for overflow when
9816 converting between EMACS_INT and off_t. When checking for
9817 buffer overflow or for overlap, take the offsets into account.
9818 Don't use EMACS_INT for small values where int suffices.
9819 When checking for overlap, fix a typo: ZV was used where
9820 ZV_BYTE was intended.
9821 (Fwrite_region): Don't assume off_t fits into 'long'.
9822 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
9823
ecfc0a49
MA
98242011-09-05 Michael Albinus <michael.albinus@gmx.de>
9825
9826 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
9827
6511acf2 98282011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 9829
0999621a 9830 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
9831
9832 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 9833 (esprintf, exprintf, evxprintf): New functions.
62f19c19 9834 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 9835 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
9836 (modify_event_symbol): Do not assume that the length of
9837 name_alist_or_stem is safe to alloca and fits in int.
9838 (Fexecute_extended_command): Likewise for function name and binding.
9839 (Frecursion_depth): Wrap around reliably on integer overflow.
9840 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
9841 since some callers pass EMACS_INT values.
9842 (Fsingle_key_description): Don't crash if symbol name contains more
9843 than MAX_ALLOCA bytes.
9844 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
9845 (get_minibuffer): Arg is now EMACS_INT, not int.
9846 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 9847 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
9848 * window.h (command_loop_level, minibuf_level): Reflect API changes.
9849
2be7d702
PE
9850 * dbusbind.c (signature_cat): New function.
9851 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
9852 Do not overrun buffer; instead, report string overflow.
9853
9d1df220
PE
9854 * dispnew.c (add_window_display_history): Don't overrun buffer.
9855 Truncate instead; this is OK since it's just a log.
9856
33ef5c64
PE
9857 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
9858 even if the time zone offset is outlandishly large.
9859 Don't mishandle offset == INT_MIN.
9860
66c6fdd5
PE
9861 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
9862 when creating daemon; the previous buffer-overflow check was incorrect.
9863
d749b01b
PE
9864 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
9865 which has the guts of the old verror function.
9866
b5cd1905
PE
9867 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
9868 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
9869
6e1a67fb
PE
9870 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
9871 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 9872 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 9873 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
9874 length of string rather than counting it via multiple sprintfs;
9875 that's simpler and more reliable.
c21721cc
PE
9876 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
9877 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
9878 sprintf, in case result does not fit in int.
9879
c57b67fc
PE
9880 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
9881 (fontset_from_font): Print it.
9882
8a401434
PE
9883 * frame.c (tty_frame_count): Now printmax_t, not int.
9884 (make_terminal_frame, set_term_frame_name): Print it.
9885 (x_report_frame_params): In X, window IDs are unsigned long,
9886 not signed long, so print them as unsigned.
9887 (validate_x_resource_name): Check for implausibly long names,
9888 and don't assume name length fits in 'int'.
9889 (x_get_resource_string): Don't blindly alloca invocation name;
9890 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
9891 not fit in int.
9892
6e1a67fb
PE
9893 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
9894 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
9895 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
9896
0df02bf3
PE
9897 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
9898 Use esprintf, not sprintf, in case result does not fit in int.
9899
48e30793
PE
9900 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
9901 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
9902 it as a large positive number.
9903 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
9904 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
9905
a66ff6d8
PE
9906 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
9907 in case result does not fit in int.
9908
aca216ff
PE
9909 * print.c (float_to_string): Detect width overflow more reliably.
9910 (print_object): Make sprintf buffer a bit bigger, to avoid potential
9911 buffer overrun. Don't assume list length fits in 'int'. Treat
9912 print length of 0 as 0, not as infinity; to be consistent with other
9913 uses of print length in this function. Don't overflow print length
9914 index. Don't assume hash table size fits in 'long', or that
9915 vectorlike size fits in 'unsigned long'.
9916
31c286f7
PE
9917 * process.c (make_process): Use printmax_t, not int, to format
9918 process-name gensyms.
9919
55e5faa1
PE
9920 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
9921
80f2e268
PE
9922 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
9923 to avoid potential buffer overrun.
9924
670741ab
PE
9925 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
9926 if X resource line is longer than 512 bytes.
9927
b7163a50
PE
9928 * xfns.c (x_window): Make sprintf buffer a bit bigger
9929 to avoid potential buffer overrun.
9930
ae58ff1f
PE
9931 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
9932
c43c8a6a
PE
9933 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
9934
3f8236f4
PE
99352011-09-04 Paul Eggert <eggert@cs.ucla.edu>
9936
53e9fe90 9937 Integer overflow fixes for scrolling, etc.
6511acf2
PE
9938 Without these, Emacs silently mishandles large integers sometimes.
9939 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
9940 it were "C-u 1 M-x recenter" on a typical 64-bit host.
9941
6511acf2
PE
9942 * xdisp.c (try_window_id): Check Emacs fixnum range before
9943 converting to 'int'.
806add1d 9944
6511acf2 9945 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
9946 Check that an Emacs fixnum is in range before assigning it to 'int'.
9947 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
9948 values converted from Emacs fixnums.
9949 (Frecenter): Don't wrap around a line count if it is out of 'int'
9950 range; instead, treat it as an extreme value.
9951 (Fset_window_configuration, compare_window_configurations):
9952 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
9953
6511acf2
PE
9954 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
9955 that can exceed INT_MAX. Check that EMACS_INT value is in range
9956 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
9957 (match_limit): Don't assume that a fixnum can fit in 'int'.
9958
6511acf2 9959 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
9960 exceed INT_MAX.
9961
6511acf2 9962 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
9963 (Fvertical_motion): Don't wrap around LINES values that don't fit
9964 in 'int'. Instead, treat them as extreme values. This is good
9965 enough for windows, which can't have more than INT_MAX lines anyway.
9966
fcb901a7
LMI
99672011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9968
0f2f6b6d
LMI
9969 * Require libxml/parser.h to avoid compilation warning.
9970
fcb901a7
LMI
9971 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
9972
9973 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
9974 since this reportedly can destroy thread storage.
9975
6e20a0d4
CY
99762011-08-30 Chong Yidong <cyd@stupidchicken.com>
9977
9978 * syntax.c (find_defun_start): Update all cache variables if
9979 exiting early (Bug#9401).
9980
148ae00e
EZ
99812011-08-30 Eli Zaretskii <eliz@gnu.org>
9982
f6cfbd8f
EZ
9983 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
9984
148ae00e
EZ
9985 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
9986 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
9987 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
9988
9989 * term.c (tty_append_glyph): New function.
9990 (produce_stretch_glyph): Static function and its prototype deleted.
9991
a66cfb1c
SM
9992 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
9993 Add prototypes.
148ae00e 9994
c4a07a4c
PE
99952011-08-29 Paul Eggert <eggert@cs.ucla.edu>
9996
9997 * image.c (parse_image_spec): Check for nonnegative, not for positive,
9998 when checking :margin (Bug#9390).
9999 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 10000 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
10001 so that the name doesn't mislead. All uses changed.
10002
6bc8cd65
JB
100032011-08-28 Johan Bockgård <bojohan@gnu.org>
10004
10005 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
10006 set_tty_hooks.
10007
dca4927e
EZ
100082011-08-27 Eli Zaretskii <eliz@gnu.org>
10009
10010 * xdisp.c (move_it_to): Don't bail out early when reaching
10011 position beyond to_charpos, if we are scanning backwards.
10012 (move_it_vertically_backward): When DY == 0, make sure we get to
10013 the first character in the line after the newline.
10014
f2cad773
PE
100152011-08-27 Paul Eggert <eggert@cs.ucla.edu>
10016
10017 * ccl.c: Improve and simplify overflow checking (Bug#9196).
10018 (ccl_driver): Do not generate an out-of-range pointer.
10019 (Fccl_execute_on_string): Remove unnecessary check for
10020 integer overflow, noted by Stefan Monnier in
10021 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
10022 Remove a FIXME that didn't need fixing.
10023 Simplify the newly-introduced buffer reallocation code.
10024
0cae2cdb
JB
100252011-08-27 Juanma Barranquero <lekktu@gmail.com>
10026
10027 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
10028
5fc295a4 100292011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 10030
70c60eb2 10031 Integer and memory overflow issues (Bug#9196).
726e0ab1 10032
d31850da
PE
10033 * doc.c (get_doc_string): Rework so that
10034 get_doc_string_buffer_size is the actual buffer size, rather than
10035 being 1 less than the actual buffer size; this makes xpalloc more
10036 convenient.
10037
a69fbedb
PE
10038 * image.c (x_allocate_bitmap_record, cache_image):
10039 * xselect.c (Fx_register_dnd_atom):
10040 Simplify previous changes by using xpalloc.
10041
fe5c5d37
PE
10042 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
10043 since either will do and ptrdiff_t is convenient with xpalloc.
10044
0065d054
PE
10045 * charset.c (charset_table_size)
10046 (struct charset_sort_data.priority): Now ptrdiff_t.
10047 (charset_compare): Don't overflow if priorities differ greatly.
10048 (Fsort_charsets): Don't assume list length fits in int.
10049 Check for size-calculation overflow when allocating sort data.
10050 (syms_of_charset): Allocate an initial charset table that is
10051 just under 64 KiB, to avoid problems with glibc malloc and mmap.
10052
10053 * cmds.c (internal_self_insert): Check for size-calculation overflow.
10054
10055 * composite.h (struct composition.glyph_len): Now int, not unsigned.
10056 The actual value is always <= INT_MAX, and leaving it unsigned made
10057 overflow checking harder.
10058
10059 * dispextern.h (struct glyph_matrix.rows_allocated)
10060 (struct face_cache.size): Now ptrdiff_t, for convenience in use
10061 with xpalloc. The values are still always <= INT_MAX.
10062
10063 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
10064
10065 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
10066 (SAFE_NALLOCA): New macro.
10067
10068 * region-cache.c (struct boundary.pos, find_cache_boundary)
10069 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
10070 (set_cache_region, invalidate_region_cache)
10071 (revalidate_region_cache, know_region_cache, region_cache_forward)
10072 (region_cache_backward, pp_cache):
10073 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
10074 so that ptrdiff_t * can be passed to xpalloc.
10075 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
10076 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
10077 (pp_cache): Don't assume cache_len fits in int.
10078 * region-cache.h: Adjust extern decls to match.
10079
10080 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
10081 EMACS_INT, since either will do, for xpalloc.
10082
10083 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
10084 (xnmalloc, xnrealloc, xpalloc): New functions.
10085
726e0ab1
PE
10086 * bidi.c (bidi_shelve_header_size): New constant.
10087 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
10088 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
10089
51f30bc5 10090 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
10091 * buffer.c (overlays_at, overlays_in, record_overlay_string)
10092 (overlay_strings):
10093 Don't update size of array until after memory allocation succeeds,
10094 because xmalloc/xrealloc may not return.
0065d054
PE
10095 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
10096 now that we have proper integer overflow checking.
10097 (record_overlay_string, overlay_strings): Catch overflows when
10098 calculating size of overlay_str_buf.
726e0ab1 10099
0065d054
PE
10100 * callproc.c (Fcall_process): Check for size overflow when
10101 calculating size of args2.
10102 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
10103 Normally we prefer signed values, but sticking with ptrdiff_t would
10104 require adding more-complicated checks.
726e0ab1
PE
10105
10106 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
10107 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
10108 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 10109 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
10110
10111 * character.c (Fstring): Check for size-calculation overflow.
10112
10113 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
10114 unnecessary integer overflow. Check for size overflow.
10115 (encode_coding_object): Don't update size until xmalloc succeeds.
10116
10117 * composite.c (get_composition_id): Check for overflow in glyph
10118 length calculations.
10119
10120 Integer and memory overflow fixes for display code.
10121 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
10122 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
10123 (scrolling_window): Check for overflow in size calculations.
10124 (line_draw_cost, realloc_glyph_pool, add_row_entry):
10125 Don't assume glyph table len fits in int.
10126 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
10127 (row_table_size): Now ptrdiff_t, not int.
10128 (scrolling_window): Avoid overflow in size calculations.
10129 Don't update size until allocation succeeds.
10130 * fns.c (concat): Check for overflow in size calculations.
10131 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
10132 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
10133 (NEXT_ALMOST_PRIME_LIMIT): New constant.
10134
10135 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
10136 (get_doc_string): Check for size calculation overflow.
10137 Don't update size until allocation succeeds.
10138 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
10139 EMACS_INT, where ptrdiff_t will do.
10140 (Fsubstitute_command_keys): Check for string overflow.
10141
10142 * editfns.c (set_time_zone_rule): Don't assume environment length
10143 fits in int.
10144 (message_length): Now ptrdiff_t, not int.
10145 (Fmessage_box): Don't update size until allocation succeeds.
10146 Don't assume message length fits in int.
10147 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
10148
0065d054
PE
10149 * emacs.c (main): Do not reallocate argv, since there is a null at
10150 the end that can be overwritten, and this way there's no need to
10151 worry about size-calculation overflow.
10152 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
10153
10154 * eval.c (init_eval_once, grow_specpdl): Don't update size until
10155 alloc succeeds.
10156 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
10157
10158 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
10159 (x_set_scroll_bar_width, x_figure_window_size):
10160 Check for integer overflow.
10161 (x_set_alpha): Do not assume XINT fits in int.
10162
10163 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
10164 This is for the members text_lines, text_cols, total_lines, total_cols,
10165 where the system imposes an 'int' limit.
10166
10167 * fringe.c (Fdefine_fringe_bitmap):
10168 Don't update size until alloc works.
10169
10170 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
10171 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
10172
10173 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
10174 Check for size-calculation overflow.
10175 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
10176 do, as we prefer signed integers.
10177 (id_to_widget.max_size, id_to_widget.used)
10178 (xg_store_widget_in_map, xg_remove_widget_from_map)
10179 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
10180 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
10181 Use and return ptrdiff_t, not int.
10182 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
10183 * gtkutil.h: Change prototypes to match the above.
10184
10185 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
10186 are duplicate now that they've been promoted to lisp.h.
10187 (x_allocate_bitmap_record, x_alloc_image_color)
10188 (make_image_cache, cache_image, xpm_load):
10189 Don't update size until alloc is done.
10190 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
10191 (x_detect_edges):
3256efce 10192 Check for size calculation overflow.
726e0ab1
PE
10193 (ct_colors_allocated_max): New constant.
10194 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
10195 overflow.
3256efce 10196
726e0ab1
PE
10197 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
10198 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
10199 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
10200 Use ptrdiff_t, not int, to count maps.
10201 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
10202 calculations. Don't update size until allocation succeeds.
10203 Redo calculations to avoid overflow.
726e0ab1
PE
10204 * keyboard.h: Change prototypes to match the above.
10205
10206 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
10207 to count maps.
10208 (current_minor_maps): Check for size calculation overflow.
10209 * keymap.h: Change prototypes to match the above.
10210
10211 * lread.c (read1, init_obarray): Don't update size until alloc done.
10212
10213 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
10214 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
10215
726e0ab1
PE
10216 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
10217 Now ptrdiff_t, not int.
10218 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
10219 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
10220
10221 * process.c (Fnetwork_interface_list): Check for overflow
10222 in size calculation.
10223
10224 * region-cache.c (move_cache_gap): Check for size calculation overflow.
10225
10226 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
10227 overflow. Don't bother calling xmalloc when xrealloc will do.
10228
10229 * search.c (Freplace_match): Check for size calculation overflow.
10230 (Fset_match_data): Don't assume list lengths fit in 'int'.
10231
10232 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
10233 for command line length. Do not attempt to address one before the
10234 beginning of an array, as that's not portable.
10235
10236 * term.c (max_frame_lines): Remove; unused.
10237 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
10238 not int.
10239 (encode_terminal_code, calculate_costs): Check for size
10240 calculation overflow.
10241 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
10242 table lengths and related sizes. Don't update size until alloc
10243 done. Redo calculations to avoid overflow.
10244 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
10245
10246 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
10247 subtracting pointers.
10248 (gobble_line): Check for overflow more carefully. Don't update size
10249 until alloc done.
10250
10251 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
10252 Don't update size until alloc done.
10253 Redo size calculations to avoid overflow.
10254 Check for size calculation overflow.
0065d054 10255 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
10256
10257 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
10258 Use ptrdiff_t, not int, for sizes.
10259 (store_mode_line_noprop_char): Don't update size until alloc done.
10260
0065d054
PE
10261 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
10262 Use ptrdiff_t, not int, for sizes.
10263 (Finternal_make_lisp_face, cache_face):
10264 Check for size calculation overflow.
10265 (cache_face): Treat size calculation overflows as if they were
10266 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
10267
10268 * xfns.c (x_encode_text, x_set_name_internal)
10269 (Fx_change_window_property): Use ptrdiff_t, not int, to count
10270 sizes, since they can exceed INT_MAX in size. Check for size
10271 calculation overflow.
10272
0065d054
PE
10273 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
10274 (xg_select): Check for size calculation overflow.
726e0ab1
PE
10275 Don't update size until alloc done.
10276
0065d054 10277 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 10278 as sprintf is limited to int lengths.
1d526e2f 10279
252c5ee1
PE
10280 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
10281 (X_LONG_MIN): New macros.
864d7ce7
PE
10282 Use them to make the following changes clearer.
10283 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
10284 This change doesn't affect the value now, but it may help remind
10285 future maintainers not to raise the value too much later.
10286 (SELECTION_QUANTUM): Remove, replacing with ...
10287 (selection_quantum): ... new function, which avoids overflow.
10288 All uses changed.
10289 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
10290 assumption that selection length fits in 'int'.
10291 (x_reply_selection_request, x_handle_selection_request)
10292 (x_get_window_property, receive_incremental_selection)
10293 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
10294 (lisp_data_to_selection_data, clean_local_selection_data):
10295 Use ptrdiff_t, not int, to record length of selection.
10296 (x_reply_selection_request, x_get_window_property)
10297 (receive_incremental_selection, x_property_data_to_lisp):
10298 Redo calculations to avoid overflow.
10299 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 10300 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
10301 something.
10302 (x_get_window_property, receive_incremental_selection)
10303 (lisp_data_to_selection_data, x_property_data_to_lisp):
10304 Check for size-calculation overflow.
10305 (x_get_window_property, receive_incremental_selection)
10306 (lisp_data_to_selection_data, Fx_register_dnd_atom):
10307 Don't store size until memory allocation succeeds.
10308 (x_get_window_property): Plug memory leak on memory exhaustion.
10309 Don't double-block input; malloc is safe here. Don't assume 2**34
10310 - 4 fits in unsigned long. Add an xassert to check
10311 XGetWindowProperty overflow. Be more careful about overflow
10312 calculations, and distinguish size from memory overflow better.
10313 (receive_incremental_selection): When tracing, don't assume
10314 unsigned int is less than INT_MAX.
10315 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
10316 harmful) conversions of unsigned short to int.
10317 (lisp_data_to_selection_data): Don't assume that integers
10318 in the range -65535 through -1 fit in an X unsigned short.
10319 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
10320 result parameters unless successful. Rely on cons_to_unsigned
10321 to report problems with elements; the old code wasn't right anyway.
10322 (x_check_property_data): Check for int overflow; we cannot use
10323 a wider type due to X limits.
10324 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
10325
726e0ab1 10326 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 10327
0065d054
PE
10328 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
10329 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
10330 (x_color_cells): Don't store size until memory allocation succeeds.
10331 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 10332 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
10333 (x_term_init): Don't assume length fits in int (sprintf is limited
10334 to int size).
bc18e09d 10335
ebfa62c0
PE
10336 Use ptrdiff_t for composition IDs.
10337 * character.c (lisp_string_width):
10338 * composite.c (composition_table_size, n_compositions)
10339 (get_composition_id, composition_gstring_from_id):
10340 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
10341 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
10342 * window.c (Frecenter):
10343 Use ptrdiff_t, not int, for composition IDs.
10344 * composite.c (get_composition_id): Check for integer overflow.
10345 * composite.h: Adjust prototypes to match the above changes.
10346
d3411f89
PE
10347 Use ptrdiff_t for hash table indexes.
10348 * category.c (hash_get_category_set):
10349 * ccl.c (ccl_driver):
10350 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
10351 * coding.c (coding_system_charset_list, detect_coding_system):
10352 * coding.h (struct coding_system.id):
10353 * composite.c (get_composition_id, gstring_lookup_cache):
10354 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
10355 * image.c (xpm_get_color_table_h):
10356 * lisp.h (hash_lookup, hash_put):
10357 * minibuf.c (Ftest_completion):
10358 Use ptrdiff_t for hash table indexes, not int (which is too
10359 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
10360 32-bit --with-wide-int hosts).
10361
e097a6fa
PE
10362 * charset.c (Fdefine_charset_internal): Check for integer overflow.
10363 Add a FIXME comment about memory leaks.
10364 (syms_of_charset): Don't assume xmalloc returns.
10365
5637687f
PE
10366 Don't assume that stated character widths fit in int.
10367 * character.c (Fchar_width, c_string_width, lisp_string_width):
10368 * character.h (CHAR_WIDTH):
10369 * indent.c (MULTIBYTE_BYTES_WIDTH):
10370 Use sanitize_char_width to avoid undefined and/or bad behavior
10371 with outlandish widths.
a66cfb1c 10372 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
10373 now that we have two such functions. All uses changed.
10374 (sanitize_char_width): New inline function.
10375
a2271ba2
PE
10376 Don't assume that tab-width fits in int.
10377 * character.h (sanitize_width): New inline function.
10378 (SANE_TAB_WIDTH): New macro.
10379 (ASCII_CHAR_WIDTH): Use it.
10380 * indent.c (sane_tab_width): Remove. All uses replaced by
10381 SANE_TAB_WIDTH (current_buffer).
10382 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
10383
18c52557
PE
10384 * fileio.c: Integer overflow issues with file modes.
10385 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
10386
caeeedc1
PE
10387 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
10388 Remove unreachable code.
10389 (read_hex, load_charset_map_from_file): Check for integer overflow.
10390
6df6ae42 10391 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
10392 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
10393 (x_send_scroll_bar_event): Likewise. Check that the size does not
10394 exceed limits imposed by XClientMessageEvent, as well as the usual
10395 ptrdiff_t and size_t limits.
10396
b13995db
PE
10397 * keyboard.c: Overflow, signedness and related fixes.
10398 (make_lispy_movement): Use same integer type in forward decl
10399 that is used in the definition.
10400 (read_key_sequence, keyremap_step):
10401 Change bufsize argument back to int, undoing my 2011-03-30 change.
10402 We prefer signed types, and int is wide enough here.
10403 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
10404 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
10405 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
10406 length, not size_t. Use ptrdiff_t for index, not int.
10407 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
10408 possibility of integer overflow.
10409
13464394
PE
10410 Overflow, signedness and related fixes for images.
10411
10412 * dispextern.h (struct it.stack[0].u.image.image_id)
10413 (struct_it.image_id, struct image.id, struct image_cache.size)
10414 (struct image_cache.used, struct image_cache.ref_count):
10415 * gtkutil.c (update_frame_tool_bar):
10416 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
10417 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
10418 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
10419 * nsmenu.m (update_frame_tool_bar):
10420 * xdisp.c (calc_pixel_width_or_height):
10421 * xfns.c (image_cache_refcount):
10422 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
10423 on typical 64-bit hosts.
10424
10425 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
10426 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
10427 Omit unnecessary casts to int.
10428 (parse_image_spec): Check that integers fall into 'int' range
10429 when the callers expect that.
10430 (image_ascent): Redo ascent calculation to avoid int overflow.
10431 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
10432 (lookup_image): Remove unnecessary tests.
10433 (xbm_image_p): Locals are now of int, not EMACS_INT,
10434 since parse_image_check makes sure they fit into int.
10435 (png_load, gif_load, svg_load_image):
10436 Prefer int to unsigned where either will do.
10437 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
10438 old tiff_error_handler and tiff_warning_handler.
10439 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
10440 stack buffer overflows. It uses only the features of vsnprintf
10441 that are common to both POSIX and native Microsoft.
10442 (tiff_error_handler, tiff_warning_handler): Use it.
10443 (tiff_load, gif_load, imagemagick_load_image):
10444 Don't assume :index value fits in 'int'.
10445 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
10446 (imagemagick_load_image): Check that crop parameters fit into
10447 the integer types that MagickCropImage accepts. Don't assume
10448 Vimagemagick_render_type has a nonnegative value. Don't assume
10449 size_t fits in 'long'.
10450 (gs_load): Use printmax_t to print the widest integers possible.
10451 Check for integer overflow when computing image height and width.
10452
c11821d4
EZ
104532011-08-26 Eli Zaretskii <eliz@gnu.org>
10454
10455 * xdisp.c (redisplay_window): Don't force window start if point
10456 will be invisible in the resulting window. (Bug#9324)
10457
0c95fcf7
EZ
104582011-08-25 Eli Zaretskii <eliz@gnu.org>
10459
10460 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
10461 the display spec is of the form `(space ...)'.
10462 (handle_display_spec): Return the value returned by
10463 handle_single_display_spec, not just 1 or zero.
10464 (handle_single_display_spec): If the display spec is of the form
10465 `(space ...)', and specifies display in the text area, return 2
10466 rather than 1.
fee65a97 10467 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
10468 accurately, and prefer exact match for point under bidi.
10469 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
10470
10471 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
10472 into disp_prop; all users changed.
10473
10474 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
10475 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
10476 for the text covered by the display property.
10477
e4ed06f1
CY
104782011-08-25 Chong Yidong <cyd@stupidchicken.com>
10479
10480 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
10481 Change return value to nil.
10482 (Frecord_buffer): Delete unused function.
10483
f67cdd7f
EZ
104842011-08-24 Eli Zaretskii <eliz@gnu.org>
10485
5980d4c6
EZ
10486 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
10487 buffers, return left-to-right.
8610fe8b
EZ
10488 (set_cursor_from_row): Consider candidate row a win if its glyph
10489 represents a newline and point is on that newline. Fixes cursor
10490 positioning on the newline at EOL of R2L text within L2R
10491 paragraph, and vice versa.
10492 (try_cursor_movement): Check continued rows, in addition to
10493 continuation rows. Fixes unwarranted scroll when point enters a
10494 continued line of R2L text within an L2R paragraph, or vice versa.
10495 (cursor_row_p): Consider the case of point being equal to
10496 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
10497 from the end of a short line to the beginning of a continued line
10498 of R2L text within L2R paragraph.
10499 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
10500 composed characters.
5980d4c6 10501
f67cdd7f
EZ
10502 * bidi.c (bidi_check_type): Use xassert.
10503 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
10504 members.
10505
bca633fb
EZ
105062011-08-23 Eli Zaretskii <eliz@gnu.org>
10507
10508 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
10509 a character.
10510
4a5885a7
CY
105112011-08-23 Chong Yidong <cyd@stupidchicken.com>
10512
10513 * nsfont.m (ns_otf_to_script): Fix typo.
10514
0902a04e
KH
105152011-08-22 Kenichi Handa <handa@m17n.org>
10516
10517 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
10518 extra slot even if the purpose is char-code-property-table.
10519
1a2e6670
EZ
105202011-08-23 Eli Zaretskii <eliz@gnu.org>
10521
8ddde651
EZ
10522 * xdisp.c (redisplay_window): When computing centering_position,
10523 account for the height of the header line. (Bug#8874)
10524
425cc014
EZ
10525 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
10526 instead of CHAR_TO_BYTE. Fixes a crash when a completion
10527 candidate is selected by the mouse, and that candidate has a
10528 composed character under the mouse.
10529
1a2e6670
EZ
10530 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
10531 coordinates reported by pos-visible-in-window-p for a composed
10532 character in column zero.
10533
8b76d6f8
SM
105342011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
10535
10536 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
10537
dac347dd
EZ
105382011-08-22 Eli Zaretskii <eliz@gnu.org>
10539
10540 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
10541 consider it a hit if to_charpos is anywhere in the range of the
10542 composed buffer positions.
10543
e013fb34
CY
105442011-08-22 Chong Yidong <cyd@stupidchicken.com>
10545
10546 * image.c (gif_load): Don't assume that each subimage has the same
10547 dimensions as the base image. Handle disposal method that is
10548 "undefined" by the gif spec (Bug#9335).
10549
bd1ba3e8
CY
105502011-08-20 Chong Yidong <cyd@stupidchicken.com>
10551
10552 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 10553 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 10554
54a1215b
EZ
105552011-08-19 Eli Zaretskii <eliz@gnu.org>
10556
823564e5
EZ
10557 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
10558 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
10559 from an Org mode buffer to a Speedbar frame.
10560
54a1215b
EZ
10561 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
10562 a composition, take its buffer position from IT->cmp_it.charpos.
10563 Fixes cursor positioning at the beginning of a line that begins
10564 with a composed character.
10565
9778ebcc
EZ
105662011-08-18 Eli Zaretskii <eliz@gnu.org>
10567
0be6ee06
EZ
10568 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
10569 character bidirectional type, use STRONG_L instead. Fixes crashes
10570 in a buffer produced by `describe-categories'.
10571
9778ebcc
EZ
10572 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
10573 members before the level stack, so they would be saved and
10574 restored when copying iterator state. Fixes incorrect reordering
10575 around TABs covered by display properties.
10576
156bffbe
AS
105772011-08-18 Andreas Schwab <schwab@linux-m68k.org>
10578
6b02f655 10579 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 10580
72ad093b
CY
105812011-08-17 Chong Yidong <cyd@stupidchicken.com>
10582
10583 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
10584 (internal_condition_case_2, internal_condition_case_n):
10585 Remove unnecessary aborts (Bug#9081).
72ad093b 10586
35774242
EZ
105872011-08-17 Eli Zaretskii <eliz@gnu.org>
10588
10589 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
10590 has no `load' handler, try opening the file locally. (Bug#9311)
10591
db76dd85
KB
105922011-08-16 Ken Brown <kbrown@cornell.edu>
10593
10594 * gmalloc.c: Expand comment.
10595
b215eee5
EZ
105962011-08-16 Eli Zaretskii <eliz@gnu.org>
10597
10598 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
10599 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
10600
a4579d33
KB
106012011-08-16 Ken Brown <kbrown@cornell.edu>
10602
10603 Fix memory allocation problems in Cygwin build (Bug#9273).
10604
10605 * unexcw.c ( __malloc_initialized): Declare external variable.
10606 (fixup_executable): Force the dumped emacs to reinitialize malloc.
10607
8b76d6f8
SM
10608 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
10609 New variables.
a4579d33
KB
10610 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
10611 dumped emacs.
10612 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
10613 in the static heap.
10614 [CYGWIN] (special_realloc): New function.
10615 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
10616 requests to realloc storage in the static heap.
10617
3ebec551
PE
106182011-08-15 Paul Eggert <eggert@cs.ucla.edu>
10619
10620 * bidi.c (bidi_initialize): Remove unused local.
10621
9fd8be00
EZ
106222011-08-15 Eli Zaretskii <eliz@gnu.org>
10623
6b02f655
SM
10624 * bidimirror.h:
10625 * biditype.h: Remove file.
10626 * makefile.w32-in ($(BLD)/bidi.$(O)):
10627 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
10628
10629 * dispextern.h: Fix a typo in the comment to bidi_type_t.
10630
10631 * chartab.c: Improve commentary for the uniprop_table API.
10632
32413314
EZ
10633 * bidi.c (bidi_paragraph_init): Support zero value of
10634 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
10635 (bidi_initialize): Use uniprop_table instead of including
10636 biditype.h and bidimirror.h.
32413314 10637
9fd8be00
EZ
10638 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
10639 coordinates of the iterator when restoring from ppos_it.
10640 (Bug#9296)
10641
5cf2b69b
KH
106422011-08-14 Kenichi Handa <handa@m17n.org>
10643
10644 * process.c (create_process): Call setup_process_coding_systems
72ad093b 10645 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 10646
daf17d00
EZ
106472011-08-14 Eli Zaretskii <eliz@gnu.org>
10648
10649 * xdisp.c (move_it_in_display_line_to): Don't invoke
10650 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
10651 ppos_it. Fixes vertical cursor motion when line beginning is
10652 covered by an image. (Bug#9296)
10653
08e3161a
JD
106542011-08-14 Jan Djärv <jan.h.d@swipnet.se>
10655
10656 * nsterm.h (ns_run_ascript): Declare.
10657 (NSAPP_DATA2_RUNASSCRIPT): Define.
10658
10659 * nsfns.m (as_script, as_result, as_status): New static variables.
10660 (ns_run_ascript): New function.
5e617bc2 10661 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
10662 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
10663 the event loop. Get status from as_status (Bug#7276).
10664
10665 * nsterm.m (sendEvent): If event is NSApplicationDefined and
10666 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
10667 the event loop (Bug#7276).
10668
a3720aa2
AS
106692011-08-14 Andreas Schwab <schwab@linux-m68k.org>
10670
10671 * gnutls.c (QCgnutls_bootprop_priority)
10672 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
10673 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
10674 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
10675 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
10676 (QCgnutls_bootprop_verify_hostname_error)
10677 (QCgnutls_bootprop_callbacks_verify): Rename from
10678 Qgnutls_bootprop_..., all uses changed.
10679
10680 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
10681 uses changed.
10682
0a0d27fb
PE
106832011-08-14 Paul Eggert <eggert@cs.ucla.edu>
10684
19d5c50c
PE
10685 * xfaces.c (Qframe_set_background_mode): Now static.
10686 * dispextern.h (Qframe_set_background_mode): Remove decl.
10687
0a0d27fb
PE
10688 * process.c (Fnetwork_interface_info): Declare local only if needed.
10689
377538cb
JD
106902011-08-13 Jan Djärv <jan.h.d@swipnet.se>
10691
10692 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
10693 (Fnetwork_interface_list): Allocate in increments of bytes instead
10694 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
10695 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
10696 sockaddr.
10697 (struct ifflag_def): notrailers is smart on OSX.
10698 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
10699 Get hardware address with getifaddrs if available.
10700
08fff70c
EZ
107012011-08-12 Eli Zaretskii <eliz@gnu.org>
10702
10703 * xdisp.c (iterate_out_of_display_property): xassert that
10704 IT->position is set to within IT->object's boundaries. Break from
10705 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
10706 when IT->position is set up wrongly due to some bug.
10707 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
10708 (push_display_prop): Allow GET_FROM_STRING as IT->method on
10709 entry. Force push_it to save on the stack the current
10710 buffer/string position, to be restored by pop_it. Fix flags in
10711 the iterator structure wrt the object coming from a display
10712 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
10713 properties. (Bug#9284)
10714
7be1c708 107152011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 10716
7be1c708
CY
10717 * fontset.c (fontset_get_font_group): Add proper type checks.
10718 (Bug#9172)
aac0c6e3 10719
7be1c708 107202011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 10721
7be1c708
CY
10722 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
10723 and LC_VERSION_MIN_MACOSX.
10724 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
10725 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 10726
97bb72a6
EZ
107272011-08-08 Eli Zaretskii <eliz@gnu.org>
10728
10729 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
10730 no-display-properties-and-no-overlays under bidi display.
10731 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 10732 properties and overlays.
97bb72a6 10733
d5617611
CY
107342011-08-08 Chong Yidong <cyd@stupidchicken.com>
10735
37e11a63
CY
10736 * editfns.c (Fset_time_zone_rule): Document relationship with the
10737 setenv function.
10738
d5617611
CY
10739 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
10740 the font entity extracted from the cache (Bug#8109).
10741
58872834
CY
107422011-08-07 Chong Yidong <cyd@stupidchicken.com>
10743
10744 * composite.c (autocmp_chars): Don't reset point. That is done by
10745 restore_point_unwind (Bug#5984).
10746
75bfc667
JL
107472011-08-07 Juri Linkov <juri@jurta.org>
10748
10749 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
10750 to show the arg `TIME' instead of `TIMEVAL'.
10751
d1410150
EZ
107522011-08-06 Eli Zaretskii <eliz@gnu.org>
10753
10754 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
10755 display property strides EOL and includes a newline, as in
10756 longlines-mode. (Bug#9254)
75b771e4
EZ
10757 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
10758 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
10759
10760 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
10761 is non-zero, even if the data buffer is NULL. Fixes a crash in
10762 vertical-motion with longlines-mode. (Bug#9254)
10763
35928349
EZ
107642011-08-05 Eli Zaretskii <eliz@gnu.org>
10765
ec7cc85b
EZ
10766 * bidi.c <bidi_cache_total_alloc>: Now static.
10767 (bidi_initialize): Initialize bidi_cache_total_alloc.
10768
8b76d6f8 10769 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
10770 cache. (Bug#9221)
10771
10772 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
10773 amount allocated this far in `bidi_cache_total_alloc'.
10774 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
10775 non-zero, only free the data buffer without restoring the cache
10776 contents. All callers changed.
10777
10778 * dispextern.h (bidi_unshelve_cache): Update prototype.
10779
10780 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
10781 (move_it_in_display_line, move_it_to)
10782 (move_it_vertically_backward, move_it_by_lines): Replace the call
10783 to xfree to an equivalent call to bidi_unshelve_cache.
10784 (move_it_in_display_line_to): Fix logic of returning
412b6358 10785 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 10786
e2e2423b
EZ
107872011-08-05 Eli Zaretskii <eliz@gnu.org>
10788
10789 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
10790 came from a string character with a `cursor' property. (Bug#9229)
10791
ae9e757a
JD
107922011-08-04 Jan Djärv <jan.h.d@swipnet.se>
10793
10794 * Makefile.in (LIB_PTHREAD): New variable.
10795 (LIBES): Add LIB_PTHREAD (Bug#9216).
10796
10797 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
10798 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
10799
213bd7f2
AS
108002011-08-04 Andreas Schwab <schwab@linux-m68k.org>
10801
6b02f655 10802 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 10803
99aaf75f
JD
108042011-08-04 Jan Djärv <jan.h.d@swipnet.se>
10805
10806 * xterm.c (x_find_topmost_parent): New function.
10807 (x_set_frame_alpha): Find topmost parent window with
10808 x_find_topmost_parent and set the property there also (bug#9181).
10809 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
10810
c74e9d86
PE
108112011-08-04 Paul Eggert <eggert@cs.ucla.edu>
10812
10813 * callproc.c (Fcall_process): Avoid vfork clobbering
10814 the local vars buffer, coding_systems, current_dir.
10815
640c8776
SM
108162011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
10817
10818 * keymap.c (Fmake_composed_keymap): Move to subr.el.
10819
f26d0e4c
PE
108202011-08-03 Paul Eggert <eggert@cs.ucla.edu>
10821
8a10d76c
PE
10822 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
10823 so that it is not optimized away.
10824
f26d0e4c
PE
10825 * xdisp.c (compute_display_string_pos): Remove unused local.
10826
55439c61
EZ
108272011-08-02 Eli Zaretskii <eliz@gnu.org>
10828
10829 Fix slow cursor motion and scrolling in large buffers with
10830 selective display, like Org Mode buffers. (Bug#9218)
10831
10832 * dispextern.h (struct bidi_it): New member disp_prop_p.
10833
10834 * xdisp.c: Remove one-slot cache of display string positions.
10835 (compute_display_string_pos): Accept an additional argument
5e617bc2 10836 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
10837 for a display string or property. If found, set DISP_PROP_P
10838 non-zero.
10839
10840 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
10841 DISP_PROP_P, and pass it to compute_display_string_pos.
10842 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
10843 non-zero. All callers of bidi_fetch_char changed.
10844
fb33fa43
SM
108452011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
10846
10847 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
10848
b099e063
DM
108492010-12-03 Don March <don@ohspite.net>
10850
10851 * keymap.c (Fdefine_key): Fix non-prefix key error message when
10852 last character M-[char] is translated to ESC [char] (bug#7541).
10853
5cc7f7af
KH
108542011-08-02 Kenichi Handa <handa@m17n.org>
10855
d0fffa3f 10856 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
10857
10858 * chartab.c (uniprop_table): Make it non-static.
10859
525d5e6e
EZ
108602011-08-01 Eli Zaretskii <eliz@gnu.org>
10861
10862 * xdisp.c (forward_to_next_line_start): Accept additional argument
10863 BIDI_IT_PREV, and store into it the state of the bidi iterator had
10864 on the newline.
10865 (reseat_at_next_visible_line_start): Use the bidi iterator state
10866 returned by forward_to_next_line_start to restore the state of
10867 it->bidi_it after backing up to previous newline. (Bug#9212)
10868
31011111
AS
108692011-07-30 Andreas Schwab <schwab@linux-m68k.org>
10870
10871 * regex.c (re_comp): Protoize.
10872 (re_exec): Fix return type.
10873 (regexec): Fix type of `ret'. (Bug#9203)
10874
476371c4
PE
108752011-07-28 Paul Eggert <eggert@cs.ucla.edu>
10876
e5d76069
PE
10877 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
10878 This is needed if max-image-size is a floating-point number.
10879
9a79b20c
AS
108802011-07-28 Andreas Schwab <schwab@linux-m68k.org>
10881
10882 * print.c (print_object): Print empty symbol as ##.
10883
10884 * lread.c (read1): Read ## as empty symbol.
10885
d8c2fa78
AA
108862011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
10887
10888 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
10889 setting frame foreground color (Bug#9175).
10890 (x_set_background_color): Likewise.
10891
ffe57a7a
AA
10892 * nsmenu.m (-setText): Size tooltip dimensions precisely to
10893 contents (Bug#9176).
10894 (EmacsTooltip -init): Remove bezels and add shadows to
10895 tooltip windows.
10896
bf3492a5
AA
10897 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
10898 or scroll bar (Bug#8470).
10899
d55e9c53
AA
10900 * nsfont.m (nsfont_open): Remove assignment to voffset and
10901 unnecessary vars hshink, expand, hd, full_height, min_height.
10902 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
10903
10904 * nsterm.h (nsfont_info): Remove voffset field.
10905
d8c2fa78 109062011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
10907
10908 Implement strike-through and overline on NextStep (Bug#8863).
10909
10910 * nsfont.m (nsfont_open): Use underline position provided by font,
10911 instead of hard-coded value of 2.
10912 (nsfont_draw): Call ns_draw_text_decoration instead.
10913
10914 * nsterm.h: Add declaration for ns_draw_text_decoration.
10915
10916 * nsterm.m (ns_draw_text_decoration): New function for drawing
10917 underline, overline, and strike-through.
10918 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
10919 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 10920 accommodate underlining, etc.
4843aac3 10921
4cc60b9b
EZ
109222011-07-28 Eli Zaretskii <eliz@gnu.org>
10923
bc7ece87
EZ
10924 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
10925 default.
4cc60b9b 10926
476371c4
PE
109272011-07-28 Paul Eggert <eggert@cs.ucla.edu>
10928
66606eea
PE
10929 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
10930 Without this fix, if a signal arrives just after memory fills up,
10931 'malloc' might be invoked reentrantly.
10932
476371c4
PE
10933 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
10934 In other words, assume that every image size is allowed, on non-X
10935 hosts. This assumption is probably wrong, but it lets Emacs compile.
10936
f3fcc40d
AS
109372011-07-28 Andreas Schwab <schwab@linux-m68k.org>
10938
10939 * regex.c (re_iswctype): Convert return values to boolean.
10940
350c992f
EZ
109412011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
10942
10943 * xdisp.c (compute_display_string_pos): Don't use cached display
10944 string position if the buffer had its restriction changed.
10945 (Bug#9184)
10946
5266b4bb
PE
109472011-07-28 Paul Eggert <eggert@cs.ucla.edu>
10948
10949 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10950
2573a837 109512011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 10952
41f55ccd 10953 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 10954
39e378da
PE
10955 * bidi.c: Integer size and overflow fixes.
10956 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
10957 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
10958 (bidi_cache_find_level_change, bidi_cache_ensure_space)
10959 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
10960 (bidi_find_other_level_edge):
10961 Use ptrdiff_t instead of EMACS_INT where either will do.
10962 This works better on 32-bit hosts configured --with-wide-int.
10963 (bidi_cache_ensure_space): Check for size-calculation overflow.
10964 Use % rather than repeated addition, for better worst-case speed.
10965 Don't set bidi_cache_size until after xrealloc returns, because it
10966 might not return.
10967 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
10968 (bidi_cache_ensure_space): Also check that the bidi cache size
10969 does not exceed that of the largest Lisp string or buffer. See Eli
10970 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 10971
5e927815
PE
10972 * alloc.c (__malloc_size_t): Remove.
10973 All uses replaced by size_t. See Andreas Schwab's note
10974 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
10975
ca4aa935
PE
10976 * image.c: Improve checking for integer overflow.
10977 (check_image_size): Assume that f is nonnull, since
10978 it is always nonnull in practice. This is one less thing to
10979 worry about when checking for integer overflow later.
10980 (x_check_image_size): New function, which checks for integer
10981 overflow issues inside X.
10982 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
10983 This removes the need for a memory_full check.
10984 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
10985 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
10986 (xbm_read_bitmap_data): Change locals back to 'int', since
10987 their values must fit in 'int'.
10988 (xpm_load_image, png_load, tiff_load):
10989 Invoke x_create_x_image_and_pixmap earlier,
10990 to avoid much needless work if the image is too large.
10991 (tiff_load): Treat overly large images as if
10992 x_create_x_image_and_pixmap failed, not as malloc failures.
10993 (gs_load): Use x_check_image_size.
10994
5f8f9cc2
PE
10995 * gtkutil.c: Omit integer casts.
10996 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
10997 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
10998
5adf60bc
PE
10999 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
11000
c8907a93
PE
11001 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
11002 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
11003 would wrongly return t on a 64-bit host.
11004
e3c25c68
PE
11005 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
11006 The plain *_OVERFLOW macros run afoul of GCC bug 49705
11007 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
11008 and therefore cause GCC to emit a bogus diagnostic in some cases.
11009
3f791afe
PE
11010 * image.c: Integer signedness and overflow and related fixes.
11011 This is not an exhaustive set of fixes, but it's time to
11012 record what I've got.
11013 (lookup_pixel_color, check_image_size): Remove redundant decls.
11014 (check_image_size): Don't assume that arbitrary EMACS_INT values
11015 fit in 'int', or that arbitrary 'double' values fit in 'int'.
11016 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
11017 (tiff_load, imagemagick_load_image):
11018 Check for overflow in size calculations.
11019 (x_create_x_image_and_pixmap): Remove unnecessary test for
11020 xmalloc returning NULL; that can't happen.
11021 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
11022 (xpm_color_bucket): Use better integer hashing function.
11023 (xpm_cache_color): Don't possibly over-allocate memory.
11024 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
11025 (gif_memory_source):
11026 Use ptrdiff_t, not int or size_t, to record sizes.
11027 (png_load): Don't assume values greater than 2**31 fit in 'int'.
11028 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
11029 either works, as we prefer signed integers.
11030 (tiff_read_from_memory, tiff_write_from_memory):
11031 Return tsize_t, not size_t, since that's what the TIFF API wants.
11032 (tiff_read_from_memory): Don't fail simply because the read would
11033 go past EOF; instead, return a short read.
11034 (tiff_load): Omit no-longer-needed casts.
11035 (Fimagemagick_types): Don't assume size fits into 'int'.
11036
3cc5a532
PE
11037 Improve hashing quality when configured --with-wide-int.
11038 * fns.c (hash_string): New function, taken from sxhash_string.
11039 Do not discard information about ASCII character case; this
11040 discarding is no longer needed.
11041 (sxhash-string): Use it. Change sig to match it. Caller changed.
11042 * lisp.h: Declare it.
11043 * lread.c (hash_string): Remove, since we now use fns.c's version.
11044 The fns.c version returns a wider integer if --with-wide-int is
11045 specified, so this should help the quality of the hashing a bit.
11046
b312a492
PE
11047 * emacs.c: Integer overflow minor fix.
11048 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
11049 Define only if GNU_LINUX.
11050 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
11051
dfd153ae
PE
11052 * dispnew.c: Integer signedness and overflow fixes.
11053 Remove unnecessary forward decls, that were a maintenance hassle.
11054 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
11055 All uses changed.
11056 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
11057 (scrolling_window): Use ptrdiff_t, not int, for byte count.
11058 (prepare_desired_row, line_draw_cost):
11059 Use int, not unsigned, where either works.
11060 (save_current_matrix, restore_current_matrix):
11061 Use ptrdiff_t, not size_t, where either works.
11062 (init_display): Check for overflow more accurately, and without
11063 relying on undefined behavior.
11064
a81d11a3
PE
11065 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
11066 Remove, replacing with the new symbols in lisp.h. All uses changed.
11067 * fileio.c (make_temp_name):
11068 * filelock.c (lock_file_1, lock_file):
11069 * xdisp.c (message_dolog):
11070 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
11071 Use pMd etc. instead.
11072 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
11073 replacing the pWIDE etc. symbols removed from editfns.c.
11074
3300e6fd
PE
11075 * keyboard.h (num_input_events): Now uintmax_t.
11076 This is (very slightly) less likely to mess up due to wraparound.
11077 All uses changed.
11078
fd05c7e9
PE
11079 * buffer.c: Integer signedness fixes.
11080 (alloc_buffer_text, enlarge_buffer_text):
11081 Use ptrdiff_t rather than size_t when either will do, as we prefer
11082 signed integers.
11083
903fe15d
PE
11084 * alloc.c: Integer signedness and overflow fixes.
11085 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
11086 (__malloc_size_t): Default to size_t, not to int.
11087 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
11088 (Fgarbage_collect, mark_object_loop_halt, mark_object):
11089 Prefer ptrdiff_t to size_t when either would do, as we prefer
11090 signed integers.
11091 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
11092 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
11093 Now const. Initialize with values that are in range even if char
11094 is signed.
11095 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
11096 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
11097 These functions do the right thing with sizes > 2**32.
11098 (check_depth): Now ptrdiff_t, not int.
11099 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
11100 Adjust to new way of storing sizes. Check for size overflow bugs
11101 in rest of code.
11102 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
11103 slightly wrong anyway, as it missed one instance of
11104 XMALLOC_OVERRUN_CHECK_OVERHEAD.
11105 (refill_memory_reserve): Omit needless cast to size_t.
11106 (mark_object_loop_halt): Mark as externally visible.
11107
ac82cc6a
PE
11108 * xselect.c: Integer signedness and overflow fixes.
11109 (Fx_register_dnd_atom, x_handle_dnd_message):
11110 Use ptrdiff_t, not size_t, since we prefer signed.
11111 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
11112 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
11113 x_dnd_atoms_size and x_dnd_atoms_length.
11114
c2d1e36d
PE
11115 * doprnt.c: Prefer signed to unsigned when either works.
11116 * eval.c (verror):
11117 * doprnt.c (doprnt):
11118 * lisp.h (doprnt):
11119 * xdisp.c (vmessage):
11120 Use ptrdiff_t, not size_t, when using or implementing doprnt,
11121 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
11122 prefer signed arithmetic to avoid comparison confusion.
11123 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
11124 but is a bit tricky.
11125
0e926e56
PE
11126 Assume freestanding C89 headers, string.h, stdlib.h.
11127 * data.c, doprnt.c, floatfns.c, print.c:
11128 Include float.h unconditionally.
11129 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
11130 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
11131 * regex.c: Likewise for stddef.h, string.h.
11132 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
11133 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
11134 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
11135 (STDC_HEADERS): Remove obsolete defines.
11136 * sysdep.c: Include limits.h unconditionally.
11137
9cfdb3ec
PE
11138 Assume support for memcmp, memcpy, memmove, memset.
11139 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
11140 * regex.c (memcmp, memcpy):
11141 Remove; we assume C89 now.
11142
11143 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
11144 (__malloc_safe_bcopy): Remove; no longer needed.
11145
cf950e6b 11146 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
11147 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
11148 well either way, and we prefer signed to unsigned.
11149
dbf38e02
LMI
111502011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
11151
11152 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
11153 closes the connection while we're reading (bug#9182).
11154
d6f0886c 111552011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 11156
d6f0886c
JD
11157 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
11158 are specified (Bug#9168).
24e0f6b1 11159
2eb1f9e6
PE
111602011-07-25 Paul Eggert <eggert@cs.ucla.edu>
11161
11162 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
11163 Found by GCC static checking and --with-wide-int on a 32-bit host.
11164
22381272 111652011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
11166
11167 * xdisp.c (compute_display_string_pos): Fix logic of caching
11168 previous display string position. Initialize cached_prev_pos to
11169 -1. Fixes slow-down at the beginning of a buffer.
11170
f25e39b4
EZ
111712011-07-24 Eli Zaretskii <eliz@gnu.org>
11172
11173 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
11174 for attrs[LFACE_FONTSET_INDEX].
11175
04c4b52e
PE
111762011-07-23 Paul Eggert <eggert@cs.ucla.edu>
11177
11178 * xml.c (parse_region): Remove unused local
11179 that was recently introduced.
11180
c1734fbd
EZ
111812011-07-23 Eli Zaretskii <eliz@gnu.org>
11182
be18c5a5
EZ
11183 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
11184 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
11185
c1734fbd
EZ
11186 * xdisp.c (move_it_in_display_line_to): Record the best matching
11187 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
11188 exit if none of the characters scanned was an exact match.
11189 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
11190 when exact match is impossible due to invisible text, and the
11191 lines are truncated.
11192
a258d627
JD
111932011-07-23 Jan Djärv <jan.h.d@swipnet.se>
11194
11195 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
11196 for OSX >= 10.7.
11197
b6d5a689
EZ
111982011-07-22 Eli Zaretskii <eliz@gnu.org>
11199
0f74f785
EZ
11200 Fix a significant slow-down of cursor motion with C-n, C-p,
11201 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
11202 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 11203 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
11204 (next_element_from_buffer): Call compute_stop_pos_backwards to
11205 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
11206 base_level_stop.
11207 (reseat): Don't look for prev_stop, as that could mean a very long
11208 run.
11209 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
11210 <cached_disp_overlay_modiff>: Cache for last found display string
11211 position.
551918c1 11212 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
11213 about the same buffer in the same area of character positions, and
11214 the buffer wasn't changed since the time the display string
11215 position was cached.
551918c1 11216
b2d0c91a
EZ
112172011-07-22 Eli Zaretskii <eliz@gnu.org>
11218
11219 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
11220 is an integer, which is important for empty lines. (Bug#9149)
11221
043604ee
CY
112222011-07-22 Chong Yidong <cyd@stupidchicken.com>
11223
11224 * frame.c (Fmodify_frame_parameters): In tty case, update the
11225 default face if necessary (Bug#4238).
11226
da4adb04
CY
112272011-07-21 Chong Yidong <cyd@stupidchicken.com>
11228
11229 * editfns.c (Fstring_to_char): No need to explain what a character
11230 is in the docstring (Bug#6576).
11231
9abd0532
LMI
112322011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
11233
11234 * xml.c (parse_region): Make sure we always return a tree.
11235
36881d16
HK
112362011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
11237
11238 * xml.c (parse_region): If a document contains only comments,
11239 return that, too.
11240
1e98674d
LMI
112412011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
11242
11243 * xml.c (make_dom): Return comments, too.
11244
590bd467
PE
112452011-07-19 Paul Eggert <eggert@cs.ucla.edu>
11246
11247 Port to OpenBSD.
11248 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
11249 and the surrounding thread.
11250 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
11251 rather than fgets, and retry after EINTR. Otherwise, 'emacs
11252 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
11253 timer goes off.
11254 * s/openbsd.h (BROKEN_SIGIO): Define.
11255 * unexelf.c (unexec) [__OpenBSD__]:
11256 Don't update the .mdebug section of the Alpha COFF symbol table.
11257
f41628b2
LMI
112582011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
11259
11260 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
11261 (bug#8460).
11262
b59b67c5
PE
112632011-07-18 Paul Eggert <eggert@cs.ucla.edu>
11264
15e3a074
PE
11265 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
11266 This fixes some race conditions on the permissions of any newly
11267 created file.
11268
41bed37d
PE
11269 * alloc.c (valid_pointer_p): Use pipe, not open.
11270 This fixes some permissions issues when debugging.
11271
b59b67c5
PE
11272 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
11273 If fchown fails to set both uid and gid, try to set just gid,
11274 as that is sometimes allowed. Adjust the file's mode to eliminate
11275 setuid or setgid bits that are inappropriate if fchown fails.
11276
925a6be7
SM
112772011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
11278
11279 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
11280 to compare Lisp_Objects.
11281 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
11282 global_gnutls_log_level, don't mistake it for a Lisp_Object.
11283 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
11284
52968808
AS
112852011-07-17 Andreas Schwab <schwab@linux-m68k.org>
11286
0a6a104b
AS
11287 * lread.c (read_integer): Unread even EOF character.
11288 (read1): Likewise. Properly record start position of symbol.
11289
52968808
AS
11290 * lread.c (read1): Read `#:' as empty uninterned symbol if no
11291 symbol character follows.
11292
9e381cdd
PE
112932011-07-17 Paul Eggert <eggert@cs.ucla.edu>
11294
11295 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
11296 This works around a problem with the previous change to Fcopy_file.
11297 Recent glibc declares fchown with __attribute__((warn_unused_result)),
11298 and without this change, GCC might complain about discarding
11299 fchown's return value.
11300
b5641435
JB
113012011-07-16 Juanma Barranquero <lekktu@gmail.com>
11302
11303 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
11304
a8031457
PE
113052011-07-16 Paul Eggert <eggert@cs.ucla.edu>
11306
11307 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
11308
dd889327
LMI
113092011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
11310
750c33f7
LMI
11311 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
11312 it's used from the C level.
11313
dd889327
LMI
11314 * process.c: Use the same condition for POLL_FOR_INPUT in both
11315 keyboard.c and process.c (bug#1858).
11316
87e86684
LM
113172011-07-09 Lawrence Mitchell <wence@gmx.li>
11318
11319 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
11320 (Fgnutls_boot): Use it.
11321
64348f40
AS
113222011-07-15 Andreas Schwab <schwab@linux-m68k.org>
11323
11324 * doc.c (Fsubstitute_command_keys): Revert last change.
11325
1d698799
LMI
113262011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
11327
f863868c
LMI
11328 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
11329 quotes the next character, and doesn't affect other longer
11330 sequences (bug#8935).
11331
1d698799
LMI
11332 * lread.c (syms_of_lread): Clarify that is isn't only
11333 `eval-buffer' and `eval-defun' that's affected by
11334 `lexical-binding' (bug#8460).
11335
aa4b6df6
EZ
113362011-07-15 Eli Zaretskii <eliz@gnu.org>
11337
11338 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 11339 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 11340
5d856da6
PE
113412011-07-14 Paul Eggert <eggert@cs.ucla.edu>
11342
ad6042bb
PE
11343 Fix minor problems found by static checking.
11344 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
11345 (elsz): Now a signed constant, not a size_t var. We prefer signed
11346 types to unsigned, to avoid integer comparison confusion. Without
11347 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
11348 "cannot optimize loop, the loop counter may overflow", a symptom
11349 of the confusion.
f00bbb22 11350 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
11351 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
11352
6468f31c
LMI
113532011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
11354
49080b10
LMI
11355 * search.c (Fre_search_backward): Mention `case-fold-search' in
11356 all the re_search_* functions (bug#8138).
11357
6468f31c
LMI
11358 * keyboard.c (Fopen_dribble_file): Document when the file is
11359 closed (bug#8056).
11360
c965adc5
EZ
113612011-07-14 Eli Zaretskii <eliz@gnu.org>
11362
df9733bf
EZ
11363 * bidi.c (bidi_dump_cached_states): Fix format of displaying
11364 bidi_cache_idx.
11365
0bb23927
EZ
11366 Support bidi reordering of display and overlay strings.
11367 * xdisp.c (compute_display_string_pos)
11368 (compute_display_string_end): Accept additional argument STRING.
11369 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
11370 (reseat_to_string): Initialize bidi_it->string.s and
11371 bidi_it->string.schars.
11372 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
11373 NULL (avoids a crash in bidi_paragraph_init).
11374 Initialize itb.string.lstring.
0bb23927
EZ
11375 (init_iterator): Call bidi_init_it only of a valid
11376 buffer position was specified. Initialize paragraph_embedding to
11377 L2R.
11378 (reseat_to_string): Initialize the bidi iterator.
11379 (display_string): If we need to ignore text properties of
11380 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
11381 original value of -1 will not work with bidi.)
11382 (compute_display_string_pos): First arg is now struct
11383 `text_pos *'; all callers changed. Support display properties on
11384 Lisp strings.
11385 (compute_display_string_end): Support display properties on Lisp
11386 strings.
11387 (init_iterator, reseat_1, reseat_to_string): Initialize the
11388 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
11389 when iterating on a string not from display properties).
640c8776
SM
11390 (compute_display_string_pos, compute_display_string_end):
11391 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
11392 arrow keys.
11393 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
11394 base_level_stop; instead, set base_level_stop to BEGV.
11395 Fixes crashes in vertical-motion.
0bb23927
EZ
11396 (next_element_from_buffer): Improve commentary for when
11397 the iterator is before prev_stop.
11398 (init_iterator): Initialize bidi_p from the default value of
11399 bidi-display-reordering, not from buffer-local value. Use the
11400 buffer-local value only if initializing for buffer iteration.
11401 (handle_invisible_prop): Support invisible properties on strings
11402 that are being bidi-reordered.
11403 (set_iterator_to_next): Support bidi reordering of C strings and
11404 Lisp strings.
11405 (next_element_from_string): Support bidi reordering of Lisp
11406 strings.
11407 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
11408 (display_string): Support display of R2L glyph rows.
11409 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
11410 (init_iterator): Don't initialize it->bidi_p for strings
11411 here.
11412 (reseat_to_string): Initialize it->bidi_p for strings here.
11413 (next_element_from_string, next_element_from_c_string)
11414 (next_element_from_buffer): Add xassert's for correspondence
11415 between IT's object being iterated and it->bidi_it.string
11416 structure.
11417 (face_before_or_after_it_pos): Support bidi iteration.
11418 (next_element_from_c_string): Handle the case of the first string
11419 character that is not the first one in the visual order.
11420 (get_visually_first_element): New function, refactored from common
11421 parts of next_element_from_buffer, next_element_from_string, and
11422 next_element_from_c_string.
11423 (tool_bar_lines_needed, redisplay_tool_bar)
11424 (display_menu_bar): Force left-to-right direction. Add a FIXME
11425 comment for making that be controlled by a user option.
11426 (push_it, pop_it): Save and restore the state of the
11427 bidi iterator. Save and restore the bidi_p flag.
11428 (pop_it): Iterate out of display property for string iteration as
11429 well.
11430 (iterate_out_of_display_property): Support iteration over strings.
11431 (handle_single_display_spec): Set up it->bidi_it for iteration
11432 over a display string, and call bidi_init_it.
11433 (handle_single_display_spec, next_overlay_string)
11434 (get_overlay_strings_1, push_display_prop): Set up the bidi
11435 iterator for displaying display or overlay strings.
11436 (forward_to_next_line_start): Don't use the shortcut if
11437 bidi-iterating.
11438 (back_to_previous_visible_line_start): If handle_display_prop
11439 pushed the iterator stack, restore the internal state of the bidi
11440 iterator by calling bidi_pop_it same number of times.
11441 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
11442 and we are bidi-iterating, don't decrement the iterator position;
11443 instead, set the first_elt flag in the bidi iterator, to produce
11444 the same effect.
11445 (reseat_1): Remove redundant setting of string_from_display_prop_p.
11446 (push_display_prop): xassert that we are iterating a buffer.
11447 (push_it, pop_it): Save and restore paragraph_embedding member.
11448 (handle_single_display_spec, next_overlay_string)
11449 (get_overlay_strings_1, reseat_1, reseat_to_string)
11450 (push_display_prop): Set up the `unibyte' member of bidi_it.string
11451 correctly. Don't assume unibyte strings are not bidi-reordered.
11452 (compute_display_string_pos)
11453 (compute_display_string_end): Fix handling the case of C string.
11454 (push_it, pop_it): Save and restore from_disp_prop_p.
11455 (handle_single_display_spec, push_display_prop): Set the
11456 from_disp_prop_p flag.
11457 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
11458 (pop_it): Call iterate_out_of_display_property only if we are
11459 popping after iteration over a string that came from a display
11460 property. Fix a typo in popping stretch info. Add an assertion
11461 for verifying that the iterator position is in sync with the bidi
11462 iterator.
11463 (handle_single_display_spec, get_overlay_strings_1)
11464 (push_display_prop): Fix initialization of paragraph direction for
11465 string when that of the parent object is not yet determined.
11466 (reseat_1): Call bidi_init_it to resync the bidi
11467 iterator with IT's position. (Bug#7616)
11468 (find_row_edges): If ROW->start.pos gives position
11469 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
11470 (handle_stop, back_to_previous_visible_line_start, reseat_1):
11471 Reset the from_disp_prop_p flag.
11472 (SAVE_IT, RESTORE_IT): New macros.
11473 (pos_visible_p, face_before_or_after_it_pos)
11474 (back_to_previous_visible_line_start)
11475 (move_it_in_display_line_to, move_it_in_display_line)
11476 (move_it_to, move_it_vertically_backward, move_it_by_lines)
11477 (try_scrolling, redisplay_window, display_line): Use them when
11478 saving a temporary copy of the iterator and restoring it back.
11479 (back_to_previous_visible_line_start, reseat_1)
11480 (init_iterator): Empty the bidi cache "stack".
11481 (move_it_in_display_line_to): If iterator ended up at
11482 EOL, but we never saw any buffer positions smaller than
11483 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
11484 motion in bidi-reordered lines.
11485 (move_it_in_display_line_to): Record prev_method and prev_pos
11486 immediately before the call to set_iterator_to_next. Fixes cursor
11487 motion in bidi-reordered lines with stretch glyphs and strings
11488 displayed in margins. (Bug#8133) (Bug#8867)
11489 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
11490 TO_CHARPOS.
640c8776
SM
11491 (pos_visible_p): Support positions in bidi-reordered lines.
11492 Save and restore bidi cache.
0bb23927
EZ
11493
11494 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
11495 (bidi_paragraph_info): Delete unused struct.
11496 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
11497 (bidi_cache_start): New variable.
11498 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
11499 to zero.
11500 (bidi_cache_fetch_state, bidi_cache_search)
11501 (bidi_cache_find_level_change, bidi_cache_iterator_state)
11502 (bidi_cache_find, bidi_peek_at_next_level)
11503 (bidi_level_of_next_char, bidi_find_other_level_edge)
11504 (bidi_move_to_visually_next): Compare cache index with
11505 bidi_cache_start rather than with zero.
11506 (bidi_fetch_char): Accept new argument STRING; all callers
11507 changed. Support iteration over a string. Support strings with
11508 display properties. Support unibyte strings. Fix the type of
11509 `len' according to what STRING_CHAR_AND_LENGTH expects.
11510 (bidi_paragraph_init, bidi_resolve_explicit_1)
11511 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
11512 (bidi_level_of_next_char, bidi_move_to_visually_next):
11513 Support iteration over a string.
0bb23927
EZ
11514 (bidi_set_sor_type, bidi_resolve_explicit_1)
11515 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
11516 can now be zero (for strings); special values 0 and -1 were
11517 changed to -1 and -2, respectively.
11518 (bidi_char_at_pos): New function.
11519 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
11520 Call it instead of FETCH_MULTIBYTE_CHAR.
11521 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
11522 initialized to valid values.
11523 (bidi_init_it): Don't initialize charpos and bytepos with invalid
11524 values.
11525 (bidi_level_of_next_char): Allow the sentinel "position" to pass
11526 the test for valid cached positions. Fix the logic for looking up
11527 the sentinel state in the cache. GCPRO the Lisp string we are
11528 iterating.
11529 (bidi_push_it, bidi_pop_it): New functions.
11530 (bidi_initialize): Initialize the bidi cache start stack pointer.
11531 (bidi_cache_ensure_space): New function, refactored from part of
11532 bidi_cache_iterator_state. Don't assume the required size is just
11533 one BIDI_CACHE_CHUNK away.
11534 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
11535 (bidi_count_bytes, bidi_char_at_pos): New functions.
11536 (bidi_cache_search): Don't assume bidi_cache_last_idx is
11537 always valid if bidi_cache_idx is valid.
11538 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
11539 is valid if it's going to be used.
11540 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
11541 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
11542 (bidi_cache_find_level_change, bidi_cache_ensure_space)
11543 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
11544 (bidi_find_other_level_edge, bidi_cache_start_stack):
11545 All variables related to cache indices are now EMACS_INT.
c965adc5 11546
0bb23927
EZ
11547 * dispextern.h (struct bidi_string_data): New structure.
11548 (struct bidi_it): New member `string'. Make flag members be 1-bit
11549 fields, and put them last in the struct.
640c8776
SM
11550 (compute_display_string_pos, compute_display_string_end):
11551 Update prototypes.
0bb23927
EZ
11552 (bidi_push_it, bidi_pop_it): Add prototypes.
11553 (struct iterator_stack_entry): New members bidi_p,
11554 paragraph_embedding, and from_disp_prop_p.
11555 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
11556 (bidi_shelve_cache, bidi_unshelve_cache):
11557 Declare prototypes.
0bb23927
EZ
11558
11559 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
11560 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
11561 and vector-like objects.
11562
11563 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
11564 cache around display iteration.
11565
11566 * window.c (Fwindow_end, window_scroll_pixel_based)
11567 (displayed_window_lines, Frecenter): Save and restore the bidi
11568 cache around display iteration.
11569
3bbd2265
LMI
115702011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
11571
11572 * editfns.c (Fdelete_region): Clarify the use of the named
11573 parameters (bug#6788).
11574
adc47434
MR
115752011-07-14 Martin Rudalics <rudalics@gmx.at>
11576
11577 * indent.c (Fvertical_motion): Set and restore w->pointm when
11578 saving and restoring the window's buffer (Bug#9006).
11579
837c31f8
LMI
115802011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
11581
11582 * editfns.c (Fstring_to_char): Clarify just what is returned
11583 (bug#6576). Text by Eli Zaretskii.
11584
ac389d0c
JB
115852011-07-13 Juanma Barranquero <lekktu@gmail.com>
11586
11587 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
11588
0be0ce47
EZ
115892011-07-13 Eli Zaretskii <eliz@gnu.org>
11590
11591 * buffer.c (mmap_find): Fix a typo.
11592
cd18e7e3
JB
115932011-07-13 Johan Bockgård <bojohan@gnu.org>
11594
11595 Fix execution of x selection hooks.
11596 * xselect.c (Qx_lost_selection_functions)
11597 (Qx_sent_selection_functions): New vars.
11598 (syms_of_xselect): DEFSYM them.
11599 (x_handle_selection_request): Pass Qx_sent_selection_functions
11600 rather than Vx_sent_selection_functions to Frun_hook_with_args.
11601 (x_handle_selection_clear,x_clear_frame_selections):
11602 Pass Qx_lost_selection_functions rather than
11603 Vx_lost_selection_functions to Frun_hook_with_args.
11604
47ea7f44
PE
116052011-07-13 Paul Eggert <eggert@cs.ucla.edu>
11606
ac389d0c 11607 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
11608 The old code sometimes used this field without initializing it.
11609
47ea7f44
PE
11610 * alloc.c (gc_sweep): Don't read past end of array.
11611 In theory, the old code could also have corrupted Emacs internals,
11612 though it'd be very unlikely.
11613
bc985c87
AS
116142011-07-12 Andreas Schwab <schwab@linux-m68k.org>
11615
11616 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 11617 argument. (Bug#4026)
bc985c87 11618
0cf34688
LMI
116192011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
11620
b3dadd76
LMI
11621 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
11622 key" (bug#4257).
11623
0cf34688
LMI
11624 * window.c (Fset_window_start): Doc fix (bug#4199).
11625 (Fset_window_hscroll): Ditto.
11626
270768cd
PE
116272011-07-12 Paul Eggert <eggert@cs.ucla.edu>
11628
077e3dda 11629 Fix minor new problems caught by GCC 4.6.1.
270768cd 11630 * term.c (init_tty): Remove unused local.
490011a6 11631 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 11632 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 11633 not used otherwise.
270768cd 11634
b1f58454
CY
116352011-07-12 Chong Yidong <cyd@stupidchicken.com>
11636
11637 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
11638
22b9578d
LMI
116392011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
11640
6e70ab07
LMI
11641 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
11642 are the mini-buffer and the echo area (bug#3320).
11643
22b9578d
LMI
11644 * term.c (init_tty): Remove support for supdup, c10 and perq
11645 terminals, which are no longer supported (bug#1482).
11646
8974cc9f
JB
116472011-07-10 Johan Bockgård <bojohan@gnu.org>
11648
11649 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
11650
a560d974
JD
116512011-07-10 Jan Djärv <jan.h.d@swipnet.se>
11652
11653 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
11654 for non-popups (Bug#3642).
11655
1dae0f0a
AS
116562011-07-10 Andreas Schwab <schwab@linux-m68k.org>
11657
268c2c36 11658 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 11659 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
11660 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
11661 * cm.c (losecursor): Likewise.
1dae0f0a
AS
11662 * data.c (fmod): Likewise.
11663 * dispnew.c (swap_glyphs_in_rows): Likewise.
11664 * emacs.c (memory_warning_signal): Likewise.
11665 * floatfns.c (float_error): Likewise.
11666 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
11667 (otf_open, font_otf_capability, generate_otf_features)
11668 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
11669 Likewise.
11670 * image.c (pbm_read_file): Likewise.
11671 * indent.c (string_display_width): Likewise.
11672 * intervals.c (check_for_interval, search_for_interval)
11673 (inc_interval_count, count_intervals, root_interval)
11674 (adjust_intervals_for_insertion, make_new_interval): Likewise.
11675 * lread.c (defalias): Likewise.
268c2c36 11676 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
11677 * regex.c (set_image_of_range_1, set_image_of_range)
11678 (regex_grow_registers): Likewise.
11679 * sysdep.c (strerror): Likewise.
11680 * termcap.c (valid_filename_p, tprint, main): Likewise.
11681 * tparam.c (main): Likewise.
11682 * unexhp9k800.c (run_time_remap, save_data_space)
11683 (update_file_ptrs, read_header, write_header, calculate_checksum)
11684 (copy_file, copy_rest, display_header): Likewise.
11685 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
11686 Likewise.
11687 * xdisp.c (check_it): Likewise.
11688 * xfaces.c (register_color, unregister_color, unregister_colors):
11689 Likewise.
11690 * xfns.c (print_fontset_result): Likewise.
11691 * xrdb.c (member, fatal, main): Likewise.
11692
99033785
PE
116932011-07-10 Paul Eggert <eggert@cs.ucla.edu>
11694
11695 Fix minor problems found by static checking (Bug#9031).
11696 * chartab.c (char_table_set_range, map_sub_char_table):
11697 Remove unused locals.
11698 (uniprop_table): Now static.
11699 * composite.c (_work_char): Remove unused static var.
11700
9cb2ac56
JB
117012011-07-09 Juanma Barranquero <lekktu@gmail.com>
11702
11703 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
11704
f25661f0
JD
117052011-07-09 Jan Djärv <jan.h.d@swipnet.se>
11706
11707 * gtkutil.c (qttip_cb): Remove code without function.
11708
8278c4fe
EZ
117092011-07-09 Eli Zaretskii <eliz@gnu.org>
11710
11711 * w32.c (pthread_sigmask): New stub.
11712
1692ae2d 117132011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 11714
8a6ebd58 11715 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
11716 sigprocmask is portable only for single-threaded applications, and
11717 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
11718 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
11719 (LIBES): Use it.
11720 * callproc.c (Fcall_process):
11721 * process.c (create_process):
11722 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
11723 Use pthread_sigmask, not sigprocmask.
123403e4 11724
1b854618
JD
117252011-07-08 Jan Djärv <jan.h.d@swipnet.se>
11726
11727 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
11728 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
11729 wrong (Bug#8591).
11730
3fe4b549
JD
117312011-07-08 Jan Djärv <jan.h.d@swipnet.se>
11732
0ce7e563
JD
11733 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
11734 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
11735 (xg_hide_tooltip): Fix comment.
11736
3fe4b549
JD
11737 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
11738 in registerServicesMenuSendTypes.
11739 (validRequestorForSendType): Don't check ns_return_types.
11740
11741 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
11742 ns_return_type.
11743
5df75e47
JR
117442011-07-08 Jason Rumney <jasonr@gnu.org>
11745
22610910
JR
11746 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
11747 SH_SHOW for hidden windows (Bug#5482).
11748
5df75e47
JR
11749 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
11750 frame struct members of non-existent frames (Bug#6284).
11751
699c10bd
JD
117522011-07-08 Jan Djärv <jan.h.d@swipnet.se>
11753
4393663b
JD
11754 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
11755 variable firstTime not needed on OSX >= 10.6.
11756 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
11757 >= 10.5. Use setKnobProportion, setDoubleValue.
11758
11759 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
11760 (MAC_OS_X_VERSION_10_5): Define if not defined.
11761 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
11762 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
11763 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
11764
11765 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 11766 cString and lossyCString on OSX >= 10.4.
4393663b 11767
58179cce 11768 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
11769 sizeToFit on OSX >= 10.2.
11770
11771 * nsimage.m (allocInitFromFile): Don't use deprecated method
11772 bestRepresentationForDevice on OSX >= 10.6.
11773
11774 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
11775 to avoid warning.
11776
11777 * emacs.c: Declare unexec_init_emacs_zone.
11778
a63e0781
JD
11779 * nsgui.h: Fix compiler warning about gnulib redefining verify.
11780
699c10bd
JD
11781 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
11782
11783 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
11784 on svcsMenu (Bug#8842).
11785
11786 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
11787 ns_return_types.
11788 (Fns_list_services): Just return Qnil on 10.6, code not working there.
11789
11790 * nsterm.m (QUTF8_STRING): Declare.
11791 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
11792 (validRequestorForSendType): Return type is (id).
11793 Change indexOfObjectIdenticalTo to indexOfObject.
11794 Check if we have local selection before returning self (Bug#8842).
11795 (writeSelectionToPasteboard): Put local selection into paste board
11796 if we have a local selection (Bug#8842).
11797 (syms_of_nsterm): DEFSYM QUTF8_STRING.
11798
11799 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
11800 (ns_get_local_selection): Declare.
11801
54e10184
LMI
118022011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
11803
9888ff71
LMI
11804 * keymap.c (describe_map_tree): Don't insert a double newline at
11805 the end of the buffer (bug#1169) and return whether we inserted
11806 something.
11807
54e10184
LMI
11808 * callint.c (Fcall_interactively): Change "reading args" to
11809 "providing args" to try to clarify what it does (bug#1010).
11810
15fa4783
KH
118112011-07-07 Kenichi Handa <handa@m17n.org>
11812
11813 * composite.c (composition_compute_stop_pos): Ignore a static
11814 composition starting before CHARPOS (Bug#8915).
11815
11816 * xdisp.c (handle_composition_prop): Likewise.
11817
a8815b00
EZ
118182011-07-07 Eli Zaretskii <eliz@gnu.org>
11819
11820 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
11821 (Bug#9015)
11822
ef7b981d 118232011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
11824
11825 * character.h (unicode_category_t): New enum type.
11826
11827 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
11828 (Qchar_code_property_table): New variable.
11829 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
11830 (UNIPROP_COMPRESSED_FORM_P): New macros.
11831 (char_table_ascii): Uncompress the compressed values.
11832 (sub_char_table_ref): New arg is_uniprop. Callers changed.
11833 Uncompress the compressed values.
ac389d0c 11834 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
11835 (char_table_ref_and_range): Uncompress the compressed values.
11836 (sub_char_table_set): New arg is_uniprop. Callers changed.
11837 Uncompress the compressed values.
11838 (sub_char_table_set_range): Args changed. Callers changed.
11839 (char_table_set_range): Adjuted for the above change.
11840 (map_sub_char_table): Delete args default_val and parent. Add arg
11841 top. Give decoded values to a Lisp function.
640c8776 11842 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
11843 values to a Lisp function. Gcpro more variables.
11844 (uniprop_table_uncompress)
11845 (uniprop_decode_value_run_length): New functions.
11846 (uniprop_decoder, uniprop_decoder_count): New variables.
11847 (uniprop_get_decoder, uniprop_encode_value_character)
11848 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
11849 New functions.
11850 (uniprop_encoder, uniprop_encoder_count): New variables.
11851 (uniprop_get_encoder, uniprop_table)
11852 (Funicode_property_table_internal, Fget_unicode_property_internal)
11853 (Fput_unicode_property_internal): New functions.
11854 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
11855 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 11856 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
11857 char-code-property-alist.
11858
640c8776 11859 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
11860 Vunicode_category_table.
11861
640c8776 11862 * font.c (font_range): Adjust for the change of
c805dec0
KH
11863 Vunicode_category_table.
11864
76b397fb
DN
118652011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
11866
11867 * m/iris4d.h: Remove file, move contents ...
11868 * s/irix6-5.h: ... here.
11869
22b4128e
PE
118702011-07-06 Paul Eggert <eggert@cs.ucla.edu>
11871
11872 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
11873 * alloc.c (mark_buffer):
11874 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
11875 (clone_per_buffer_values): Don't assume that
22b4128e
PE
11876 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
11877 This isn't true in general, and it's particularly not true
11878 if Emacs is configured with --with-wide-int.
11879 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
11880 New macros, used in the buffer.c change.
11881
869795d6
JD
118822011-07-05 Jan Djärv <jan.h.d@swipnet.se>
11883
11884 * xsettings.c: Use both GConf and GSettings if both are available.
11885 (store_config_changed_event): Add comment.
11886 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
11887 (store_tool_bar_style_changed): New functions.
5e617bc2 11888 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
11889 (struct xsettings): Move font inside HAVE_XFT.
11890 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 11891 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 11892 Move inside HAVE_XFT.
640c8776 11893 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
11894 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
11895 also.
11896 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 11897 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 11898 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
11899 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
11900 (parse_settings): Move check for font inside HAVE_XFT.
11901 (read_settings, apply_xft_settings): Add comment.
11902 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
11903 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
11904 call store_font_name_changed.
11905 (xft_settings_event): Add comment.
11906 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
11907 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
11908 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
11909 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
11910 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
11911 (xsettings_get_system_font, xsettings_get_system_normal_font):
11912 Add comment.
869795d6 11913
d8ed26bd
PE
119142011-07-05 Paul Eggert <eggert@cs.ucla.edu>
11915
11916 Random fixes. E.g., (random) never returned negative values.
11917 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
11918 subseconds part to the entropy, as that's a bit more random.
11919 Prefer signed to unsigned, since the signedness doesn't matter and
11920 in general we prefer signed. When given a limit, use a
11921 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
11922 latter isn't right if USE_2_TAGS_FOR_INTS.
11923 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
11924 not 0..VALMASK. Don't discard "excess" bits that random () returns.
11925
cabf1cac
SM
119262011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
11927
11928 * textprop.c (text_property_stickiness):
11929 Obey Vtext_property_default_nonsticky.
11930 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
11931 * w32fns.c (syms_of_w32fns):
11932 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
11933
6e9b2be9
PE
119342011-07-04 Paul Eggert <eggert@cs.ucla.edu>
11935
11936 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
11937 This is more efficient than Ffile_directory_p and avoids a minor race.
11938
90186c68
LMI
119392011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
11940
7c301272
LMI
11941 * buffer.c (Foverlay_put): Say what the return value is
11942 (bug#7835).
11943
c4f2d8d4
LMI
11944 * fileio.c (barf_or_query_if_file_exists): Check first if the file
11945 is a directory before asking whether to use the file name
11946 (bug#7564).
ad637907
LMI
11947 (barf_or_query_if_file_exists): Make the "File is a directory"
11948 error be more correct.
c4f2d8d4 11949
90186c68
LMI
11950 * fns.c (Frequire): Remove the mention of the .gz files, since
11951 that's installation-specific, but keep the mention of
11952 `get-load-suffixes'.
11953
da64016e
PE
119542011-07-04 Paul Eggert <eggert@cs.ucla.edu>
11955
11956 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
11957 Report string overflow if the output is too long.
11958
7d47b580
JB
119592011-07-04 Juanma Barranquero <lekktu@gmail.com>
11960
a555cb87
JB
11961 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
11962 (syms_of_gnutls): Remove duplicate DEFSYM for
11963 Qgnutls_bootprop_verify_hostname_error, an error for
11964 Qgnutls_bootprop_verify_error (which is no longer used).
11965
7d47b580
JB
11966 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
11967 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
11968 Also (re)move comments that are misplaced or no longer relevant.
11969
1e49bfab
LMI
119702011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
11971
11972 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
11973
1485f4c0
CY
119742011-07-03 Chong Yidong <cyd@stupidchicken.com>
11975
11976 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
11977 and background color parameters if they have been changed.
11978
a9ab721e
LMI
119792011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
11980
11981 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
11982
cf7cff57
PE
119832011-07-03 Paul Eggert <eggert@cs.ucla.edu>
11984
2e13213d
PE
11985 * xsettings.c (SYSTEM_FONT): Define only when used.
11986 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
11987
cf7cff57
PE
11988 * keymap.c (access_keymap_1): Now static.
11989
7a8e04f7
CY
119902011-07-02 Chong Yidong <cyd@stupidchicken.com>
11991
11992 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
11993 leave any prefix arg for the up event (Bug#1586).
11994
61352f62
LMI
119952011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
11996
69bb1ef7
LMI
11997 * lread.c (syms_of_lread): Mention single symbols defined by
11998 `defvar' or `defconst' (bug#7154).
11999
61352f62 12000 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 12001 (Frequire): Mention get-load-suffixes.
61352f62 12002
28545e04
MR
120032011-07-02 Martin Rudalics <rudalics@gmx.at>
12004
12005 * window.h (window): Remove clone_number slot.
12006 * window.c (Fwindow_clone_number, Fset_window_clone_number):
12007 Remove.
12008 (make_parent_window, make_window, saved_window)
12009 (Fset_window_configuration, save_window_save): Don't deal with
12010 clone numbers.
12011 * buffer.c (Qclone_number): Remove declaration.
12012 (sort_overlays, overlay_strings): Don't deal with clone numbers.
12013
3349e122
SM
120142011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
12015
12016 Add multiple inheritance to keymaps.
12017 * keymap.c (Fmake_composed_keymap): New function.
12018 (Fset_keymap_parent): Simplify.
12019 (fix_submap_inheritance): Remove.
12020 (access_keymap_1): New function extracted from access_keymap to handle
12021 embedded parents and handle lists of maps.
12022 (access_keymap): Use it.
12023 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
12024 (Fcopy_keymap): Handle embedded parents.
12025 (Fcommand_remapping, define_as_prefix): Simplify.
12026 (Fkey_binding): Simplify.
12027 (syms_of_keymap): Move minibuffer-local-completion-map,
12028 minibuffer-local-filename-completion-map,
12029 minibuffer-local-must-match-map, and
12030 minibuffer-local-filename-must-match-map to Elisp.
12031 (syms_of_keymap): Defsubr make-composed-keymap.
12032 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
12033 (parse_menu_item): Trivial simplification.
12034
3279eb87
GM
120352011-07-01 Glenn Morris <rgm@gnu.org>
12036
12037 * Makefile.in (SETTINGS_LIBS): Fix typo.
12038
39cb9e56 120392011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
12040
12041 * coding.c (Fencode_coding_string): Record the last coding system
12042 used, as the function doc string says (bug#8738).
12043
0949d2b6
JD
120442011-07-01 Jan Djärv <jan.h.d@swipnet.se>
12045
12046 * xsettings.c (store_monospaced_changed): Take new font as arg and
12047 check for change against current_mono_font.
12048 (EMACS_TYPE_SETTINGS): Remove this and related defines.
12049 (emacs_settings_constructor, emacs_settings_get_property)
12050 (emacs_settings_set_property, emacs_settings_class_init)
12051 (emacs_settings_init, gsettings_obj): Remove.
12052 (something_changedCB): New function for HAVE_GSETTINGS.
12053 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
12054 with value as argument.
12055 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
12056 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 12057 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
12058 "changed".
12059
12060 * xgselect.c: Add defined (HAVE_GSETTINGS).
12061 (xgselect_initialize): Ditto.
12062
12063 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
12064 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
12065 xg_select.
12066
bbc6b304
PE
120672011-07-01 Paul Eggert <eggert@cs.ucla.edu>
12068
12069 * eval.c (struct backtrace): Simplify and port the data structure.
12070 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
12071 signed bit field, as this assumption is not portable and it makes
12072 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
12073 "char debug_on_exit : 1" as this is not portable either; instead,
12074 use the portable "unsigned int debug_on_exit : 1". Remove unused
12075 member evalargs. Remove obsolete comments about cc bombing out.
12076
9851bfc5
JD
120772011-06-30 Jan Djärv <jan.h.d@swipnet.se>
12078
51bb811f 12079 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
12080 Let HAVE_GSETTINGS override HAVE_GCONF.
12081 (store_monospaced_changed): New function.
12082 (EMACS_SETTINGS): A new type derived from GObject to handle
12083 GSettings notifications.
12084 (emacs_settings_constructor, emacs_settings_get_property)
12085 (emacs_settings_set_property, emacs_settings_class_init):
12086 New functions.
12087 (gsettings_client, gsettings_obj): New variables.
12088 (GSETTINGS_SCHEMA): New define.
12089 (something_changedCB): Call store_monospaced_changed.
12090 (init_gsettings): New function.
12091 (xsettings_initialize): Call init_gsettings.
12092 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
12093 to NULL.
12094
640c8776 12095 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
12096 GCONF_CFLAGS/LIBS.
12097
5386012d
MR
120982011-06-29 Martin Rudalics <rudalics@gmx.at>
12099
12100 * window.c (resize_root_window, grow_mini_window)
12101 (shrink_mini_window): Rename Qresize_root_window to
12102 Qwindow_resize_root_window and Qresize_root_window_vertically to
12103 Qwindow_resize_root_window_vertically.
12104
f13e0b08
PE
121052011-06-28 Paul Eggert <eggert@cs.ucla.edu>
12106
12107 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
12108
94515237
JB
121092011-06-27 Juanma Barranquero <lekktu@gmail.com>
12110
12111 * makefile.w32-in: Redesign dependencies so they reflect more
12112 clearly which files are directly included by each source file,
12113 and not through other includes.
12114
e43b6e43
MR
121152011-06-27 Martin Rudalics <rudalics@gmx.at>
12116
12117 * buffer.c (Qclone_number): Declare static and DEFSYM it.
12118 (sort_overlays, overlay_strings): When an overlay's clone number
12119 matches the window's clone number process the overlay even if
12120 the overlay's window property doesn't match the current window.
12121
d68443dc
MR
12122 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
12123 (Fwindow_hchild): Rename to Fwindow_left_child.
12124 (Fwindow_next): Rename to Fwindow_next_sibling.
12125 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
12126 (resize_window_check): Rename to window_resize_check.
12127 (resize_window_apply): Rename to window_resize_apply.
12128 (Fresize_window_apply): Rename to Fwindow_resize_apply.
12129 (Fdelete_other_windows_internal, resize_frame_windows)
12130 (Fsplit_window_internal, Fdelete_window_internal)
12131 (grow_mini_window, shrink_mini_window)
12132 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 12133
c7e73be5
JD
121342011-06-26 Jan Djärv <jan.h.d@swipnet.se>
12135
12136 * emacsgtkfixed.h: State that this is only used with Gtk+3.
12137 (emacs_fixed_set_min_size): Remove.
12138 (emacs_fixed_new): Take frame as argument.
12139
12140 * emacsgtkfixed.c: State that this is only used with Gtk+3.
12141 (_EmacsFixedPrivate): Remove minwidth/height.
12142 Add struct frame *f.
12143 (emacs_fixed_init): Initialize priv->f.
12144 (get_parent_class, emacs_fixed_set_min_size): Remove.
12145 (emacs_fixed_new): Set priv->f to argument.
12146 (emacs_fixed_get_preferred_width)
12147 (emacs_fixed_get_preferred_height): Use min_width/height from
12148 frames size_hint to set minimum and natural (Bug#8919).
12149 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
12150 and use min_width/height from frames size_hint to set
12151 min_width/height (Bug#8919).
12152
12153 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
12154 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
12155 Fix indentation.
c7e73be5 12156
cf99dcf8
EZ
121572011-06-26 Eli Zaretskii <eliz@gnu.org>
12158
12159 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
12160 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
12161 called at ZV.
12162
029529ac
CY
121632011-06-26 Chong Yidong <cyd@stupidchicken.com>
12164
12165 * process.c (wait_reading_process_output): Bypass select if
12166 waiting for a cell while ignoring keyboard input, and input is
12167 pending. Suggested by Jan Djärv (Bug#8869).
12168
7a7ef429
PE
121692011-06-25 Paul Eggert <eggert@cs.ucla.edu>
12170
12171 Use gnulib's dup2 module instead of rolling our own.
12172 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
12173
11fdef7d 121742011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
12175
12176 * dispnew.c (scrolling_window): Before scrolling, turn off a
12177 mouse-highlight in the window being scrolled.
12178
cd3520a4
JB
121792011-06-24 Juanma Barranquero <lekktu@gmail.com>
12180
12181 Move DEFSYM to lisp.h and use everywhere.
12182
12183 * character.h (DEFSYM): Move declaration...
12184 * lisp.h (DEFSYM): ...here.
12185
12186 * gnutls.c:
12187 * minibuf.c:
12188 * w32menu.c:
12189 * w32proc.c:
12190 * w32select.c: Don't include character.h.
12191
12192 * alloc.c (syms_of_alloc):
12193 * buffer.c (syms_of_buffer):
12194 * bytecode.c (syms_of_bytecode):
12195 * callint.c (syms_of_callint):
12196 * casefiddle.c (syms_of_casefiddle):
12197 * casetab.c (init_casetab_once):
12198 * category.c (init_category_once, syms_of_category):
12199 * ccl.c (syms_of_ccl):
12200 * cmds.c (syms_of_cmds):
12201 * composite.c (syms_of_composite):
12202 * dbusbind.c (syms_of_dbusbind):
12203 * dired.c (syms_of_dired):
12204 * dispnew.c (syms_of_display):
12205 * doc.c (syms_of_doc):
12206 * editfns.c (syms_of_editfns):
12207 * emacs.c (syms_of_emacs):
12208 * eval.c (syms_of_eval):
12209 * fileio.c (syms_of_fileio):
12210 * fns.c (syms_of_fns):
12211 * frame.c (syms_of_frame):
12212 * fringe.c (syms_of_fringe):
12213 * insdel.c (syms_of_insdel):
12214 * keymap.c (syms_of_keymap):
12215 * lread.c (init_obarray, syms_of_lread):
12216 * macros.c (syms_of_macros):
12217 * msdos.c (syms_of_msdos):
12218 * print.c (syms_of_print):
12219 * process.c (syms_of_process):
12220 * search.c (syms_of_search):
12221 * sound.c (syms_of_sound):
12222 * syntax.c (init_syntax_once, syms_of_syntax):
12223 * terminal.c (syms_of_terminal):
12224 * textprop.c (syms_of_textprop):
12225 * undo.c (syms_of_undo):
12226 * w32.c (globals_of_w32):
12227 * window.c (syms_of_window):
12228 * xdisp.c (syms_of_xdisp):
12229 * xfaces.c (syms_of_xfaces):
12230 * xfns.c (syms_of_xfns):
12231 * xmenu.c (syms_of_xmenu):
12232 * xsettings.c (syms_of_xsettings):
12233 * xterm.c (syms_of_xterm): Use DEFSYM.
12234
4228cf16
TZ
122352011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
12236
cd3520a4 12237 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 12238
7fcccf1e
PE
122392011-06-23 Paul Eggert <eggert@cs.ucla.edu>
12240
7efb4e0e
PE
12241 Integer and buffer overflow fixes (Bug#8873).
12242
ff5844ad
PE
12243 * print.c (printchar, strout): Check for string overflow.
12244 (PRINTPREPARE, printchar, strout):
12245 Don't set size unless allocation succeeds.
12246
90532f02
PE
12247 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
12248 for sizes. Check for string overflow more accurately.
12249 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
12250
6d84508d
PE
12251 * macros.c: Integer and buffer overflow fixes.
12252 * keyboard.h (struct keyboard.kbd_macro_bufsize):
12253 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
12254 Use ptrdiff_t, not int, for sizes.
12255 Don't increment bufsize until after realloc succeeds.
12256 Check for size-calculation overflow.
12257 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
12258
437b2cb4
PE
12259 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
12260
8b9ac8b4
PE
12261 * lread.c: Integer overflow fixes.
12262 (read_integer): Radix is now EMACS_INT, not int,
12263 to improve quality of diagnostics for out-of-range radices.
12264 Calculate buffer size correctly for out-of-range radices.
12265 (read1): Check for integer overflow in radices, and in
12266 read-circle numbers.
82cb60d3
PE
12267 (read_escape): Avoid int overflow.
12268 (Fload, openp, read_buffer_size, read1)
12269 (substitute_object_recurse, read_vector, read_list, map_obarray):
12270 Use ptrdiff_t, not int, for sizes.
12271 (read1): Use EMACS_INT, not int, for sizes.
20270765 12272 Check for size overflow.
8b9ac8b4 12273
7fcccf1e
PE
12274 * image.c (cache_image): Check for size arithmetic overflow.
12275
bfbbd7e7
PE
12276 * lread.c: Integer overflow issues.
12277 (saved_doc_string_size, saved_doc_string_length)
12278 (prev_saved_doc_string_size, prev_saved_doc_string_length):
12279 Now ptrdiff_t, not int.
12280 (read1): Don't assume doc string length fits in int. Check for
12281 out-of-range doc string lengths.
12282 (read_list): Don't assume file position fits in int.
39019e54 12283 (read_escape): Check for hex character overflow.
bfbbd7e7 12284
4e323265
LL
122852011-06-22 Leo Liu <sdl.web@gmail.com>
12286
12287 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
12288 Move to minibuffer.el.
12289
85fece3e
PE
122902011-06-22 Paul Eggert <eggert@cs.ucla.edu>
12291
20b84ce9 12292 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
12293 The following patches are for when GLYPH_DEBUG && !XASSERT.
12294 * dispextern.h (trace_redisplay_p, dump_glyph_string):
12295 * dispnew.c (flush_stdout):
12296 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
12297 Mark as externally visible.
12298 * dispnew.c (check_window_matrix_pointers): Now static.
12299 * dispnew.c (window_to_frame_vpos):
12300 * xfns.c (unwind_create_frame):
12301 * xterm.c (x_check_font): Remove unused local.
12302 * scroll.c (CHECK_BOUNDS):
12303 * xfaces.c (cache_fache): Rename local to avoid shadowing.
12304 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
12305 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
12306 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
12307 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
12308 Now static.
12309 (debug_method_add): Use va_list and vsprintf rather than relying
12310 on undefined behavior with wrong number of arguments.
12311 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
12312 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
12313 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
12314 since we're not interested in debugging glyphs with old libraries.
12315 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
12316 GCC 4.6.0's static checking.
12317
0766b489
PE
123182011-06-22 Paul Eggert <eggert@cs.ucla.edu>
12319
31fd4b32
PE
12320 Integer overflow and signedness fixes (Bug#8873).
12321 A few related buffer overrun fixes, too.
12322
b79e8648
PE
12323 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
12324
0766b489
PE
12325 * dispextern.h (struct face.stipple):
12326 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
12327 (x_bitmap_mask, x_allocate_bitmap_record)
12328 (x_create_bitmap_from_data, x_create_bitmap_from_file)
12329 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
12330 (x_create_bitmap_from_xpm_data):
12331 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
12332 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
12333 (.bitmaps_last):
12334 * xfaces.c (load_pixmap):
12335 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
12336 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
12337 (.bitmaps_last, struct x_output.icon_bitmap):
12338 Use ptrdiff_t, not int, for bitmap indexes.
12339 (x_allocate_bitmap_record): Check for size overflow.
12340 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
12341
b081724f
PE
12342 Use ptrdiff_t, not int, for overlay counts.
12343 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
12344 * editfns.c (overlays_around, get_pos_property):
12345 * textprop.c (get_char_property_and_overlay):
12346 * xdisp.c (next_overlay_change, note_mouse_highlight):
12347 * xfaces.c (face_at_buffer_position):
21514da7
PE
12348 * buffer.c (OVERLAY_COUNT_MAX): New macro.
12349 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
12350 (Fnext_overlay_change, Fprevious_overlay_change)
12351 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 12352 Use ptrdiff_t, not int, for sizes.
21514da7 12353 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 12354
3de73e5e
PE
12355 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
12356
2606c57b
PE
12357 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
12358 (x_session_initialize): Do not assume string length fits in int.
12359
aaafe47a
PE
12360 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
12361 This is unlikely, but can occur if DPI is outlandish.
12362
2674ddc8 12363 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
12364 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
12365
28154962
PE
12366 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
12367 * xrdb.c (magic_file_p, search_magic_path):
12368 Omit last arg SUFFIX; it was always 0. All callers changed.
12369 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
12370
7de51af5
PE
12371 * xfont.c (xfont_match): Avoid need for strlen.
12372
25ed6cc3
PE
12373 * xfns.c: Don't assume strlen fits in int.
12374 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
12375
4eab31dd
PE
12376 * xdisp.c (message_log_check_duplicate): Return intmax_t,
12377 not unsigned long, as we prefer signed integers. All callers changed.
12378 Detect integer overflow in repeat count.
12379 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 12380 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 12381
171e2a58
PE
12382 * termcap.c: Don't assume sizes fit in int and never overflow.
12383 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
12384 (gobble_line): Check for size-calculation overflow.
12385
ad39faca 12386 * minibuf.c (Fread_buffer):
6e5bb2dc 12387 * lread.c (intern, intern_c_string):
74ca2eb3
PE
12388 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
12389 Don't assume string length fits in int.
12390
52c61c22 12391 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
12392 * gtkutil.c (style_changed_cb): Avoid need for strlen.
12393
b5b8c9e5
PE
12394 * font.c: Don't assume string length fits in int.
12395 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
12396 Use ptrdiff_t, not int.
ccd6111c
PE
12397 (font_intern_prop): Don't assume string length fits in int.
12398 Don't assume integer property fits in fixnum.
12399 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 12400
882f0d81 12401 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 12402 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
12403 Reformulate so as not to need the command string.
12404 Invoke gzip -cd rather than gunzip, as it's more portable.
12405 (lock_info_type, lock_file_1, lock_file):
12406 Don't assume pid_t and time_t fit in unsigned long.
12407 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
12408 (current_lock_owner): Prefer signed type for sizes.
12409 Use memcpy, not strncpy, where memcpy is what is really wanted.
12410 Don't assume (via atoi) that time_t and pid_t fit in int.
12411 Check for time_t and/or pid_t out of range, e.g., via a network share.
12412 Don't alloca where an auto var works fine.
12413
93f4cf88
PE
12414 * fileio.c: Fix some integer overflow issues.
12415 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
12416 Don't assume string length fits in int.
12417 (directory_file_name): Don't assume string length fits in long.
12418 (make_temp_name): Don't assume pid fits in int, or that its print
12419 length is less than 20.
12420
f3e92b69
PE
12421 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
12422
1bfdaf10
PE
12423 * coding.c (make_subsidiaries): Don't assume string length fits in int.
12424
35016e9a
PE
12425 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
12426
3d1e65a1
PE
12427 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
12428 We prefer signed integers, even for size calculations.
12429
0b963a93
PE
12430 * emacs.c: Don't assume string length fits in 'int'.
12431 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
12432 (main): Don't invoke strlen when not needed.
12433
573f4b54
PE
12434 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
12435 (XD_DEBUG_MESSAGE): Don't waste a byte.
12436
989f33ba
PE
12437 * callproc.c (getenv_internal_1, getenv_internal)
12438 (Fgetenv_internal):
965d34eb
PE
12439 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
12440
e4d29b33
PE
12441 * lread.c (invalid_syntax): Omit length argument.
12442 All uses changed. This doesn't fix a bug, but it simplifies the
12443 code away from its former Hollerith-constant appearance, and it's
12444 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 12445 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 12446
eb49b136
PE
12447 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
12448 This didn't break anything, but it didn't help either.
12449 It's confusing to put a bogus integer in a place where the actual
12450 value does not matter.
9f62aeb1 12451 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 12452 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 12453
15375a22
PE
12454 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
12455 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
12456 implementation.
b61cc01c
PE
12457 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
12458 We prefer signed types, and the value cannot exceed the EMACS_INT
12459 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
12460 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
12461 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
12462 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 12463
53b2623d
PE
12464 * indent.c (sane_tab_width): New function.
12465 (current_column, scan_for_column, Findent_to, position_indentation)
12466 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 12467 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 12468
51cab52b 12469 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 12470
f2ed8a70
PE
12471 * lisp.h (lint_assume): New macro.
12472 * composite.c (composition_gstring_put_cache):
12473 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
12474
abe80cc6
PE
12475 * editfns.c, insdel.c:
12476 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 12477
b02c740e
PE
12478 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
12479
ebc96716
PE
12480 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
12481
b4e50fa0 12482 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 12483 Use much-faster test for byte-length change.
311d5d7c 12484 Don't assume string byte-length fits in 'int'.
a4cf38e4 12485 Check that character arg fits in 'int'.
85461888 12486 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 12487
c0c1ee9f
PE
12488 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
12489
a498d7f4
PE
12490 * fns.c (concat): Catch string overflow earlier.
12491 Do not rely on integer wraparound.
12492
51cab52b
PE
12493 * dispextern.h (struct it.overlay_strings_charpos)
12494 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
12495 * xdisp.c (forward_to_next_line_start)
12496 (back_to_previous_visible_line_start)
12497 (reseat_at_next_visible_line_start, next_element_from_buffer):
12498 Don't arbitrarily truncate the value of 'selective' to int.
12499
76031fad
PE
12500 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
12501
5eb55db9
PE
12502 * composite.c: Don't truncate sizes to 'int'.
12503 (composition_gstring_p, composition_reseat_it)
12504 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
12505 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
12506 not EMACS_UINT, for indexes.
5eb55db9 12507
0703a717
PE
12508 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
12509
d6202519
PE
12510 * buffer.c: Include <verify.h>.
12511 (struct sortvec.priority, struct sortstr.priority):
8961a454 12512 Now EMACS_INT, not int.
c20998a7 12513 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
12514 (struct sortstr.size, record_overlay_string)
12515 (struct sortstrlist.size, struct sortlist.used):
12516 Don't truncate size to int.
12517 (record_overlay_string): Check for size-calculation overflow.
d6202519 12518 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 12519
d5a19415
JM
125202011-06-22 Jim Meyering <meyering@redhat.com>
12521
029529ac 12522 Don't leak an XBM-image-sized buffer
d5a19415
JM
12523 * image.c (xbm_load): Free the image buffer after using it.
12524
a9041e6c
PE
125252011-06-21 Paul Eggert <eggert@cs.ucla.edu>
12526
12527 Port to Sun C.
12528 * composite.c (find_automatic_composition): Omit needless 'return 0;'
12529 that Sun C diagnosed.
12530 * fns.c (secure_hash): Fix pointer signedness issue.
12531 * intervals.c (static_offset_intervals): New function.
12532 (offset_intervals): Use it.
12533
7f3f739f
LL
125342011-06-21 Leo Liu <sdl.web@gmail.com>
12535
12536 * deps.mk (fns.o):
12537 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
12538 sha512.h.
12539
12540 * fns.c (secure_hash): Rename from crypto_hash_function and change
12541 the first arg to accept symbols.
5b66d427 12542 (Fsecure_hash): New primitive.
7f3f739f
LL
12543 (syms_of_fns): New symbols.
12544
76147d94
DD
125452011-06-20 Deniz Dogan <deniz@dogan.se>
12546
12547 * process.c (Fset_process_buffer): Clarify return value in
12548 docstring.
12549
7d7d0045
CY
125502011-06-18 Chong Yidong <cyd@stupidchicken.com>
12551
12552 * dispnew.c (add_window_display_history): Use BVAR.
12553
12554 * xdisp.c (debug_method_add): Use BVAR.
12555 (check_window_end, dump_glyph_matrix, dump_glyph)
12556 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
12557
12558 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
12559 Likewise.
12560
12561 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
12562 check till after the cache is created in init_frame_faces.
12563
ff2bc410
SM
125642011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
12565
12566 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
12567
28177add
PE
125682011-06-16 Paul Eggert <eggert@cs.ucla.edu>
12569
dd3482fe
PE
12570 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
12571 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
12572 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
12573
393d71f3 12574 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
12575 * fileio.c (Finsert_file_contents):
12576 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
12577 Remove the old (too-loose) buffer overflow checks.
12578 They weren't needed, since make_gap checks for buffer overflow.
12579 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
12580 The old code merely checked for Emacs fixnum overflow, and relied
12581 on undefined (wraparound) behavior. The new code avoids undefined
12582 behavior, and also checks for ptrdiff_t and/or size_t overflow.
12583
2e6813b0 12584 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
12585 Tune. Don't use wider integers than needed. Don't use alloca.
12586 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 12587
599a9e4f
PE
12588 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
12589
99561444
PE
12590 * insdel.c, lisp.h (buffer_overflow): New function.
12591 (insert_from_buffer_1, replace_range, replace_range_2):
12592 * insdel.c (make_gap_larger):
12593 * editfns.c (Finsert_char):
12594 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
12595
28177add
PE
12596 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
12597
e69dafad
PE
125982011-06-15 Paul Eggert <eggert@cs.ucla.edu>
12599
4baa020d 12600 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 12601
b1c46f02
PE
12602 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
12603 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
12604
e69dafad
PE
12605 * fileio.c: Don't assume EMACS_INT fits in off_t.
12606 (emacs_lseek): New static function.
12607 (Finsert_file_contents, Fwrite_region): Use it.
12608 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
12609
566684ea
PE
12610 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
12611
e6966cd6
PE
12612 * fns.c: Don't overflow int when computing a list length.
12613 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
12614 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
12615 truncation on 64-bit hosts. Check for QUIT every
12616 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
12617 faster and is responsive enough.
12618 (Flength): Report an error instead of overflowing an integer.
12619 (Fsafe_length): Return a float if the value is not representable
12620 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 12621 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 12622 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 12623
dd0b0efb
PE
12624 * alloc.c: Check that resized vectors' lengths fit in fixnums.
12625 (header_size, word_size): New constants.
12626 (allocate_vectorlike): Don't check size overflow here.
12627 (allocate_vector): Check it here instead, since this is the only
12628 caller of allocate_vectorlike that could cause overflow.
12629 Check that the new vector's length is representable as a fixnum.
12630
86fe5cfe
PE
12631 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
12632 The previous code was bogus. For example, next_almost_prime (32)
12633 returned 39, which is undesirable as it is a multiple of 3; and
12634 next_almost_prime (24) returned 25, which is a multiple of 5 so
12635 why was the code bothering to check for multiples of 7?
12636
80e88859
PE
12637 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
12638
4a2f0ad6
PE
12639 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
12640
f66c7cf8
PE
12641 Variadic C functions now count arguments with ptrdiff_t.
12642 This partly undoes my 2011-03-30 change, which replaced int with size_t.
12643 Back then I didn't know that the Emacs coding style prefers signed int.
12644 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
12645 were being counted with int, which may truncate counts on 64-bit
12646 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
12647 * lisp.h (struct Lisp_Subr.function.aMANY)
12648 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
12649 Arg counts are now ptrdiff_t, not size_t.
12650 All variadic functions and their callers changed accordingly.
12651 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
12652 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
12653 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
12654 * callint.c (Fcall_interactively): Check arg count for overflow,
12655 to avoid potential buffer overrun. Use signed char, not 'int',
12656 for 'varies' array, so that we needn't bother to check its size
12657 calculation for overflow.
12658 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
12659 * eval.c (apply_lambda):
12660 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
12661 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
12662 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
12663
a1759b76
PE
12664 * callint.c (Fcall_interactively): Don't use index var as event count.
12665
d96be9fc
PE
12666 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
12667 * mem-limits.h (SIZE): Remove; no longer used.
12668
a690a978 12669 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 12670
578c21e6
PE
12671 Remove unnecessary casts.
12672 * xterm.c (x_term_init):
12673 * xfns.c (x_set_border_pixel):
12674 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
12675 These aren't needed now that we assume ANSI C.
12676
96f53c6c
PE
12677 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
12678 It's more likely to cause problems (due to unsigned overflow)
12679 than to cure them.
12680
83c77d31
PE
12681 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
12682
ee2079f1
PE
12683 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
12684
6da65536
PE
12685 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
12686
7147c4a4
PE
12687 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
12688
193e32d9
PE
12689 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
12690
e5533da6
PE
12691 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
12692
9910e595
PE
12693 GLYPH_CODE_FACE returns EMACS_INT, not int.
12694 * dispextern.h (merge_faces):
12695 * xfaces.c (merge_faces):
01103c44
PE
12696 * xdisp.c (get_next_display_element, next_element_from_display_vector):
12697 Don't assume EMACS_INT fits in int.
9910e595 12698
2638320e
PE
12699 * character.h (CHAR_VALID_P): Remove unused parameter.
12700 * fontset.c, lisp.h, xdisp.c: All uses changed.
12701
045eb8d9
PE
12702 * editfns.c (Ftranslate_region_internal): Omit redundant test.
12703
c1f134b5
PE
12704 * fns.c (concat): Minor tuning based on overflow analysis.
12705 This doesn't fix any bugs. Use int to hold character, instead
12706 of constantly refetching from Emacs object. Use XFASTINT, not
12707 XINT, for value known to be a character. Don't bother comparing
12708 a single byte to 0400, as it's always less.
12709
395fcb93 12710 * floatfns.c (Fexpt):
327eeec8
PE
12711 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
12712
abbd3d23
PE
12713 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
12714 for characters.
12715
684a03ef
PE
12716 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
12717
0fed43f3
PE
12718 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
12719 Without this fix, on a 64-bit host (aset S 0 4294967386) would
12720 incorrectly succeed when S was a string, because 4294967386 was
12721 truncated before it was used.
12722
8fd02eb7
PE
12723 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
12724 Otherwise, an out-of-range integer could cause undefined behavior
12725 on a 64-bit host.
12726
f8c86b69
PE
12727 * composite.c: Use int, not EMACS_INT, for characters.
12728 (fill_gstring_body, composition_compute_stop_pos): Use int, not
12729 EMACS_INT, for values that are known to be in character range.
12730 This doesn't fix any bugs but is the usual style inside Emacs and
12731 may generate better code on 32-bit machines.
12732
34206dd2
PE
12733 Make sure a 64-bit char is never passed to ENCODE_CHAR.
12734 This is for reasons similar to the recent CHAR_STRING fix.
12735 * charset.c (Fencode_char): Check that character arg is actually
12736 a character. Pass an int to ENCODE_CHAR.
12737 * charset.h (ENCODE_CHAR): Verify that the character argument is no
12738 wider than 'int', as a compile-time check to prevent future regressions
12739 in this area.
12740
c5958d4c 12741 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
12742
12743 Make sure a 64-bit char is never passed to CHAR_STRING.
12744 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
12745 by silently ignoring the top 32 bits, allowing some values
12746 that were far too large to be valid characters.
12747 * character.h: Include <verify.h>.
12748 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
12749 arguments are no wider than unsigned, as a compile-time check
12750 to prevent future regressions in this area.
12751 * data.c (Faset):
01103c44 12752 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
12753 (Fsubst_char_in_region):
12754 * fns.c (concat):
12755 * xdisp.c (decode_mode_spec_coding):
12756 Adjust to CHAR_STRING's new requirement.
12757 * editfns.c (Finsert_char, Fsubst_char_in_region):
12758 * fns.c (concat): Check that character args are actually
12759 characters. Without this test, these functions did the wrong
12760 thing with wildly out-of-range values on 64-bit hosts.
12761
d37ca623
PE
12762 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
12763 These casts should not be needed on 32-bit hosts, either.
12764 * keyboard.c (read_char):
12765 * lread.c (Fload): Remove casts to unsigned.
12766
ea204efb
PE
12767 * lisp.h (UNSIGNED_CMP): New macro.
12768 This fixes comparison bugs on 64-bit hosts.
12769 (ASCII_CHAR_P): Use it.
12770 * casefiddle.c (casify_object):
01103c44 12771 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
12772 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
12773 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
12774 * dispextern.h (FACE_FROM_ID):
12775 * keyboard.c (read_char): Use UNSIGNED_CMP.
12776
41cb286c
PE
12777 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
12778 not to EMACS_INT, to avoid GCC warning.
12779
4a1b9832
PE
12780 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
12781
55daad71
PE
12782 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
12783 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
12784 isn't needed on 32-bit machines.
8f95c75c 12785
01103c44
PE
12786 * buffer.c (Fgenerate_new_buffer_name):
12787 Use EMACS_INT for count, not int.
0ceccced 12788 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
12789
12790 * data.c (Qcompiled_function): Now static.
12791
c6f072e7
PE
12792 * window.c (window_body_lines): Now static.
12793
20ce5912
PE
12794 * image.c (gif_load): Rename local to avoid shadowing.
12795
9c4c5f81
PE
12796 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
12797 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
12798 * alloc.c (make_save_value): Integer argument is now of type
12799 ptrdiff_t, not int.
12800 (mark_object): Use ptrdiff_t, not int.
12801 * lisp.h (pD): New macro.
12802 * print.c (print_object): Use it.
12803
c0c5c8ae
PE
12804 * alloc.c: Use EMACS_INT, not int, to count objects.
12805 (total_conses, total_markers, total_symbols, total_vector_size)
12806 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
12807 (total_free_floats, total_floats, total_free_intervals)
12808 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
12809 Now EMACS_INT, not int. All uses changed.
12810 (Fgarbage_collect): Compute overall total using a double, so that
12811 integer overflow is less likely to be a problem. Check for overflow
12812 when converting back to an integer.
5a25e253
PE
12813 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
12814 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
12815 These were 'int' variables that could overflow on 64-bit hosts;
12816 they were never used, so remove them instead of repairing them.
211a0b2a 12817 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
12818 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
12819 Previously, this ceilinged at INT_MAX, but that doesn't work on
12820 64-bit machines.
e46bb31a 12821 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 12822
c78baabf 12823 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 12824 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
12825 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
12826 when a (possibly-narrower) signed value would do just as well.
12827 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 12828
c9d624c6
PE
12829 * alloc.c: Catch some string size overflows that we were missing.
12830 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
12831 for convenience in STRING_BYTES_MAX.
12832 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
12833 The definition here is exact; the one in lisp.h was approximate.
12834 (allocate_string_data): Check for string overflow. This catches
12835 some instances we weren't catching before. Also, it catches
12836 size_t overflow on (unusual) hosts where SIZE_MAX <= min
12837 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
12838 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 12839
c9d624c6
PE
12840 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
12841 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 12842 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 12843
353032ce
PE
12844 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
12845
2bccce07
PE
12846 * alloc.c (Fmake_string): Check for out-of-range init.
12847
0ac30604
SM
128482011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
12849
12850 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
12851
c195f2de
JD
128522011-06-14 Jan Djärv <jan.h.d@swipnet.se>
12853
12854 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
12855 xg_get_default_scrollbar_width.
12856
12857 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
12858 (int_gtk_range_get_value): Move to the scroll bar part of the file.
12859 (style_changed_cb): Call update_theme_scrollbar_width and call
12860 x_set_scroll_bar_default_width and xg_frame_set_char_size for
12861 all frames (Bug#8505).
12862 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
12863 Call gtk_window_set_resizable if HAVE_GTK3.
12864 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
12865 and height if HAVE_GTK3 (Bug#8505).
12866 (scroll_bar_width_for_theme): New variable.
12867 (update_theme_scrollbar_width): New function.
12868 (xg_get_default_scrollbar_width): Move code to
12869 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
12870 (xg_initialize): Call update_theme_scrollbar_width.
12871
12872 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
12873
12874 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
12875
e10ac9f1
MR
128762011-06-12 Martin Rudalics <rudalics@gmx.at>
12877
12878 * frame.c (make_frame): Call other_buffer_safely instead of
12879 other_buffer.
12880
12881 * window.c (temp_output_buffer_show): Call display_buffer with
12882 second argument Vtemp_buffer_show_specifiers and reset latter
12883 immediately after the call.
12884 (Vtemp_buffer_show_specifiers): New variable.
12885 (auto_window_vscroll_p, next_screen_context_lines)
12886 (Vscroll_preserve_screen_position): Remove leading asterisks from
12887 doc-strings.
12888
2d3c217e 128892011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 12890
7b7f97e8 12891 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
12892 * buffer.c (Qclone_number): Remove for now, as it's unused.
12893 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
12894 (record_buffer): Remove unused local.
12895 * frame.c (other_visible_frames, frame_buffer_list): Now static.
12896 (set_frame_buffer_list): Remove; unused.
12897 * frame.h (other_visible_frames): Remove decl.
12898 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
12899 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
12900 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
12901 if HAVE_GPM.
12902 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
12903 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
12904 Define only if HAVE_GPM.
12905 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
12906 (update_hints_inhibit): Remove; never set. All uses removed.
12907 * widgetprv.h (emacsFrameClassRec): Remove decl.
12908 * window.c (delete_deletable_window): Now returns void, since it
12909 wasn't returning anything.
12910 (compare_window_configurations): Remove unused locals.
12911 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
12912 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
12913 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
12914 the same widths as pointers. This follows up on the 2011-05-06 patch.
12915 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
12916 * xterm.h: Likewise.
12917 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
12918
1384b89e
JB
129192011-06-12 Juanma Barranquero <lekktu@gmail.com>
12920
12921 * makefile.w32-in: Update dependencies.
12922 (LISP_H): Add lib/intprops.h.
12923
1100a63c
CY
129242011-06-11 Chong Yidong <cyd@stupidchicken.com>
12925
12926 * image.c (gif_load): Add animation frame delay to the metadata.
12927 (syms_of_image): Use DEFSYM. New symbol `delay'.
12928
6198ccd0
MR
129292011-06-11 Martin Rudalics <rudalics@gmx.at>
12930
12931 * window.c (delete_deletable_window): Re-add.
12932 (Fset_window_configuration): Rewrite to handle dead buffers and
12933 consequently deletable windows.
12934 (window_tree, Fwindow_tree): Remove. Supply functionality in
12935 window.el.
12936 (compare_window_configurations): Simplify code.
12937
b6e3633c
AS
129382011-06-11 Andreas Schwab <schwab@linux-m68k.org>
12939
1ab0dee5
AS
12940 * image.c (imagemagick_load_image): Fix type mismatch.
12941 (Fimagemagick_types): Likewise.
12942
b6e3633c
AS
12943 * window.h (replace_buffer_in_windows): Declare.
12944
9397e56f
MR
129452011-06-11 Martin Rudalics <rudalics@gmx.at>
12946
12947 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
12948 Qclone_number. Remove external declaration of Qdelete_window.
12949 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
12950 code.
640c8776
SM
12951 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
12952 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
12953 (Fother_buffer): Rewrite doc-string. Major rewrite for new
12954 buffer list implementation.
12955 (other_buffer_safely): New function.
12956 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
12957 calls to replace_buffer_in_windows and
12958 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
12959 if allowed.
12960 (record_buffer): Inhibit quitting and rewrite using quittable
12961 functions. Run Qbuffer_list_update_hook if allowed.
12962 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
12963 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
12964 Move switch-to-buffer to window.el.
9397e56f
MR
12965 (bury-buffer): Move to window.el.
12966 (Vbuffer_list_update_hook): New variable.
12967
12968 * lisp.h (other_buffer_safely): Add prototype in buffer.c
12969 section.
12970
12971 * window.h (resize_frame_windows): Move up in code.
12972 (Fwindow_frame): Remove EXFUN.
12973 (replace_buffer_in_all_windows): Remove prototype.
12974 (replace_buffer_in_windows_safely): Add prototype.
12975
12976 * window.c: Declare Qdelete_window static again. Move down
12977 declaration of select_count.
12978 (Fnext_window, Fprevious_window): Rewrite doc-strings.
12979 (Fother_window): Move to window.el.
12980 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
12981 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
12982 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
12983 window.el.
12984 (replace_buffer_in_windows): Implement by calling
12985 Qreplace_buffer_in_windows.
12986 (replace_buffer_in_all_windows): Remove with some functionality
12987 moved into replace_buffer_in_windows_safely.
12988 (replace_buffer_in_windows_safely): New function.
12989 (select_window_norecord, select_frame_norecord): Move in front
12990 of run_window_configuration_change_hook. Remove now obsolete
12991 declarations.
640c8776
SM
12992 (Fset_window_buffer): Rewrite doc-string.
12993 Call Qrecord_window_buffer.
9397e56f
MR
12994 (keys_of_window): Move binding for other-window to window.el.
12995
b50691aa
CY
129962011-06-11 Chong Yidong <cyd@stupidchicken.com>
12997
12998 * dispextern.h (struct image): Replace data member, whose int_val
12999 and ptr_val fields were not used by anything, with a single
13000 lisp_val object.
13001
13002 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
13003 (gif_clear_image, gif_load, imagemagick_load_image)
13004 (gs_clear_image, gs_load): Callers changed.
13005
3f754b86
PE
130062011-06-10 Paul Eggert <eggert@cs.ucla.edu>
13007
cca69397
PE
13008 * buffer.h: Include <time.h>, for time_t.
13009 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
13010
109e28d0
PE
13011 Fix minor problems found by static checking.
13012
60737f02
PE
13013 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
13014
4b66faf3
PE
13015 Make identifiers static if they are not used in other modules.
13016 * data.c (Qcompiled_function, Qframe, Qvector):
13017 * image.c (QimageMagick, Qsvg):
13018 * minibuf.c (Qmetadata):
13019 * window.c (resize_window_check, resize_root_window): Now static.
13020 * window.h (resize_window_check, resize_root_window): Remove decls.
13021
109e28d0
PE
13022 * window.c (window_deletion_count, delete_deletable_window):
13023 Remove; unused.
46a4ce9e
PE
13024 (window_body_lines): Now static.
13025 (Fdelete_other_windows_internal): Mark vars as initialized.
13026 Make sure 'resize_failed' is initialized.
13027 (run_window_configuration_change_hook): Rename local to avoid shadowing.
13028 (resize_window_apply): Remove unused local.
13029 * window.h (delete_deletable_window): Remove decl.
13030
109e28d0 13031 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
13032 (imagemagick_load_image): Fix pointer signedness problem by changing
13033 last arg from unsigned char * to char *. All uses changed.
13034 Also, fix a local for similar reasons.
13035 Remove unused locals. Remove locals to avoid shadowing.
13036 (fn_rsvg_handle_free): Remove; unused.
13037 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 13038 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 13039
3f754b86
PE
13040 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
13041
2547adb1
CY
130422011-06-10 Chong Yidong <cyd@stupidchicken.com>
13043
13044 * image.c (gif_load): Fix omitted cast error introduced by
13045 2011-06-06 change.
13046
2c8e37d4
MR
130472011-06-10 Martin Rudalics <rudalics@gmx.at>
13048
13049 * window.h (resize_proportionally, orig_total_lines)
13050 (orig_top_line): Remove from window structure.
13051 (set_window_height, set_window_width, change_window_heights)
13052 (Fdelete_window): Remove prototypes.
13053 (resize_frame_windows): Remove duplicate declaration.
13054
440a42e3
EZ
130552011-06-10 Eli Zaretskii <eliz@gnu.org>
13056
13057 * window.h (resize_frame_windows, resize_window_check)
13058 (delete_deletable_window, resize_root_window)
13059 (resize_frame_windows): Declare prototypes.
13060
13061 * window.c (resize_window_apply): Make definition be "static" to
13062 match the prototype.
13063
562dd5e9
MR
130642011-06-10 Martin Rudalics <rudalics@gmx.at>
13065
13066 * window.c: Remove declarations of Qwindow_size_fixed,
13067 window_min_size_1, window_min_size_2, window_min_size,
13068 size_window, window_fixed_size_p, enlarge_window, delete_window.
13069 Remove static from declaration of Qdelete_window, it's
13070 temporarily needed by Fbury_buffer.
13071 (replace_window): Don't assign orig_top_line and
13072 orig_total_lines.
13073 (Fdelete_window, delete_window): Remove. Window deletion is
13074 handled by window.el.
640c8776
SM
13075 (window_loop): Remove DELETE_OTHER_WINDOWS case.
13076 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
13077 (Fdelete_other_windows): Remove. Deleting other windows is
13078 handled by window.el.
13079 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
13080 handled in window.el.
13081 (window_min_size_2, window_min_size_1, window_min_size): Remove.
13082 Window minimum sizes are handled in window.el.
13083 (shrink_windows, size_window, set_window_height)
13084 (set_window_width, change_window_heights, window_height)
13085 (window_width, CURBEG, CURSIZE, enlarge_window)
13086 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
13087 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
13088 handled in window.el.
13089 (make_dummy_parent): Rename to make_parent_window and give it a
13090 second argument horflag.
13091 (make_window): Don't set resize_proportionally any more.
13092 (Fsplit_window): Remove. Windows are split in window.el.
13093 (save_restore_action, save_restore_orig_size)
13094 (shrink_window_lowest_first, save_restore_orig_size): Remove.
13095 Resize mini windows in window.el.
13096 (grow_mini_window, shrink_mini_window): Implement by calling
13097 Qresize_root_window_vertically, resize_window_check and
13098 resize_window_apply.
640c8776
SM
13099 (saved_window, Fset_window_configuration, save_window_save):
13100 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
13101 resize_proportionally.
13102 (window_min_height, window_min_width): Move to window.el.
13103 (keys_of_window): Move bindings for delete-other-windows,
13104 split-window, delete-window and enlarge-window to window.el.
13105
13106 * buffer.c: Temporarily extern Qdelete_window.
13107 (Fbury_buffer): Temporarily call Qdelete_window instead of
13108 Fdelete_window (Fbury_buffer will move to window.el soon).
13109
13110 * frame.c (set_menu_bar_lines_1): Remove code handling
13111 orig_top_line and orig_total_lines.
13112
13113 * dispnew.c (adjust_frame_glyphs_initially): Don't use
13114 set_window_height but set heights directly.
13115 (change_frame_size_1): Use resize_frame_windows.
13116
13117 * xdisp.c (init_xdisp): Don't use set_window_height but set
13118 heights directly.
13119
640c8776
SM
13120 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
13121 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
13122 run_window_configuration_change_hook.
13123
13124 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
13125 instead of change_window_heights and run
13126 run_window_configuration_change_hook.
13127
1a13852e
MR
131282011-06-09 Martin Rudalics <rudalics@gmx.at>
13129
13130 * window.c (replace_window): Rename second argument REPLACEMENT to
13131 NEW. New third argument SETFLAG. Rewrite.
13132 (delete_window, make_dummy_parent): Call replace_window with
13133 third argument 1.
13134 (window_list_1): Move down in code.
13135 (run_window_configuration_change_hook): Move set_buffer part
13136 before select_frame_norecord part in order to unwind correctly.
13137 Rename count1 to count.
13138 (recombine_windows, delete_deletable_window, resize_root_window)
13139 (Fdelete_other_windows_internal)
13140 (Frun_window_configuration_change_hook, make_parent_window)
13141 (resize_window_check, resize_window_apply, Fresize_window_apply)
13142 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
13143 (Fdelete_window_internal, Fresize_mini_window_internal):
13144 New functions.
1a13852e
MR
13145 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
13146
f3d1777e
MR
131472011-06-08 Martin Rudalics <rudalics@gmx.at>
13148
496e208e
MR
13149 * window.h (window): Add some new members to window structure -
13150 normal_lines, normal_cols, new_total, new_normal, clone_number,
13151 splits, nest, prev_buffers, next_buffers.
13152 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 13153 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 13154
f3d1777e
MR
13155 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
13156 Remove.
496e208e
MR
13157 (make_dummy_parent): Set new members of windows structure.
13158 (make_window): Move down in code. Handle new members of window
13159 structure.
13160 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
13161 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
13162 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
13163 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
13164 (Fset_window_next_buffers, Fset_window_clone_number):
13165 New functions.
496e208e
MR
13166 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
13167 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
13168 Doc-string fixes.
13169 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
13170 Argument WINDOW can be now internal window too.
13171 (Fwindow_use_time): Move up in code.
13172 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
13173 Rewrite doc-string.
13174 (Fset_window_configuration, saved_window)
13175 (Fcurrent_window_configuration, save_window_save): Handle new
13176 members of window structure.
b9e809c2
MR
13177 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
13178 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
13179 (syms_of_window): New Lisp objects Qrecord_window_buffer,
13180 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
13181 Qget_mru_window, Qresize_root_window,
13182 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
13183 Qauto_buffer_name; staticpro them.
f3d1777e 13184
abde8f8c
MR
131852011-06-07 Martin Rudalics <rudalics@gmx.at>
13186
13187 * window.c (Fwindow_total_size, Fwindow_left_column)
13188 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
13189 (Fwindow_list_1): New functions.
13190 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
13191 (Fwindow_width, Fscroll_left, Fscroll_right):
13192 Use window_body_cols instead of window_box_text_cols.
13193 (delete_window, Fset_window_configuration):
13194 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
13195 (delete_all_subwindows): Take a window as argument and not a
13196 structure. Rewrite.
190b47e6
MR
13197 (window_loop): Remove handling of GET_LRU_WINDOW and
13198 GET_LARGEST_WINDOW.
13199 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
13200
13201 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
13202 window_box_text_cols. delete_all_subwindows now takes a
13203 Lisp_Object as argument.
abde8f8c 13204
640c8776
SM
13205 * indent.c (compute_motion, Fcompute_motion):
13206 Use window_body_cols instead of window_box_text_cols.
abde8f8c 13207
fa8a67e6
MR
13208 * frame.c (delete_frame): Call delete_all_subwindows with root
13209 window as argument.
13210
a54e3482
DC
132112011-06-07 Daniel Colascione <dan.colascione@gmail.com>
13212
13213 * fns.c (Fputhash): Document return value.
13214
60002bf5
CY
132152011-06-06 Chong Yidong <cyd@stupidchicken.com>
13216
13217 * image.c (gif_load): Implement gif89a spec "no disposal" method.
13218
0c671da6 132192011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 13220
b862a52a 13221 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 13222
be44ca6c
PE
13223 Check for overflow when converting integer to cons and back.
13224 * charset.c (Fdefine_charset_internal, Fdecode_char):
13225 Use cons_to_unsigned to catch overflow.
13226 (Fencode_char): Use INTEGER_TO_CONS.
13227 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
13228 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
13229 * data.c (long_to_cons, cons_to_long): Remove.
13230 (cons_to_unsigned, cons_to_signed): New functions.
13231 These signal an error for invalid or out-of-range values.
13232 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
13233 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
13234 * font.c (Ffont_variation_glyphs):
13235 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
13236 * lisp.h: Include <intprops.h>.
13237 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
13238 (cons_to_signed, cons_to_unsigned): New decls.
13239 (long_to_cons, cons_to_long): Remove decls.
13240 * undo.c (record_first_change): Use INTEGER_TO_CONS.
13241 (Fprimitive_undo): Use CONS_TO_INTEGER.
13242 * xfns.c (Fx_window_property): Likewise.
13243 * xselect.c: Include <limits.h>.
13244 (x_own_selection, selection_data_to_lisp_data):
13245 Use INTEGER_TO_CONS.
13246 (x_handle_selection_request, x_handle_selection_clear)
13247 (x_get_foreign_selection, Fx_disown_selection_internal)
13248 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
13249 (lisp_data_to_selection_data): Use cons_to_unsigned.
13250 (x_fill_property_data): Use cons_to_signed.
13251 Report values out of range.
13252
d1f3d2af
PE
13253 Check for buffer and string overflow more precisely.
13254 * buffer.h (BUF_BYTES_MAX): New macro.
13255 * lisp.h (STRING_BYTES_MAX): New macro.
13256 * alloc.c (Fmake_string):
13257 * character.c (string_escape_byte8):
13258 * coding.c (coding_alloc_by_realloc):
13259 * doprnt.c (doprnt):
13260 * editfns.c (Fformat):
13261 * eval.c (verror):
13262 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
13263 since they may not be the same number.
13264 * editfns.c (Finsert_char):
13265 * fileio.c (Finsert_file_contents):
13266 Likewise for BUF_BYTES_MAX.
13267
dd52fcea
PE
13268 * image.c: Use ptrdiff_t, not int, for sizes.
13269 (slurp_file): Switch from int to ptrdiff_t.
13270 All uses changed.
13271 (slurp_file): Check that file size fits in both size_t (for
13272 malloc) and ptrdiff_t (for sanity and safety).
13273
7f9bbdbb
PE
13274 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
13275 if b->modtime has its maximal value.
13276
dfe18f82
PE
13277 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
13278
84acfcf0
PE
13279 Don't assume time_t can fit into int.
13280 * buffer.h (struct buffer.modtime): Now time_t, not int.
13281 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
13282 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
13283
ccd9a01a
PE
13284 Minor fixes for signed vs unsigned integers.
13285 * character.h (MAYBE_UNIFY_CHAR):
13286 * charset.c (maybe_unify_char):
13287 * keyboard.c (read_char, reorder_modifiers):
13288 XINT -> XFASTINT, since the integer must be nonnegative.
13289 * ftfont.c (ftfont_spec_pattern):
13290 * keymap.c (access_keymap, silly_event_symbol_error):
13291 XUINT -> XFASTINT, since the integer must be nonnegative.
13292 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
13293 since it makes no difference and we prefer signed.
13294 * keyboard.c (record_char): Use XUINT when all the neighbors do.
13295 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
13296 nonnegative.
13297
d6d100dd
SM
132982011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
13299
13300 * window.h (Fwindow_frame): Declare.
13301
2b6148e4
PE
133022011-06-06 Paul Eggert <eggert@cs.ucla.edu>
13303
13304 * alloc.c: Simplify handling of large-request failures (Bug#8800).
13305 (SPARE_MEMORY): Always define.
13306 (LARGE_REQUEST): Remove.
13307 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
13308
f230ecc9
MR
133092011-06-06 Martin Rudalics <rudalics@gmx.at>
13310
727e958e
MR
13311 * lisp.h: Move EXFUNS for Fframe_root_window,
13312 Fframe_first_window and Fset_frame_selected_window to window.h.
13313
13314 * window.h: Move EXFUNS for Fframe_root_window,
13315 Fframe_first_window and Fset_frame_selected_window here from
13316 lisp.h.
13317
13318 * frame.c (Fwindow_frame, Fframe_first_window)
13319 (Fframe_root_window, Fframe_selected_window)
13320 (Fset_frame_selected_window): Move to window.c.
13321 (Factive_minibuffer_window): Move to minibuf.c.
13322 (Fother_visible_frames_p): New function.
13323
13324 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
13325
f230ecc9
MR
13326 * window.c (decode_window, decode_any_window): Move up in code.
13327 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
13328 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
13329 (Fwindow_buffer): Move up and rewrite doc-string.
13330 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
13331 (Fwindow_prev): New functions.
727e958e
MR
13332 (Fwindow_frame): Move here from frame.c. Accept any window as
13333 argument.
13334 (Fframe_root_window, Fframe_first_window)
13335 (Fframe_selected_window): Move here from frame.c. Accept frame
13336 or arbitrary window as argument. Update doc-strings.
13337 (Fminibuffer_window): Move up in code.
13338 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
13339 (Fset_frame_selected_window): Move here from frame.c.
13340 Marginal rewrite.
727e958e
MR
13341 (Fselected_window, select_window, Fselect_window): Move up in
13342 code. Minor doc-string fixes.
f230ecc9 13343
4d09bcf6
PE
133442011-06-06 Paul Eggert <eggert@cs.ucla.edu>
13345
13346 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
13347 Do not assume that spare memory exists; that assumption is valid
13348 only if SYSTEM_MALLOC.
13349 (LARGE_REQUEST): New macro, so that the issue of large requests
13350 is separated from the issue of spare memory.
13351
810928a2
AS
133522011-06-05 Andreas Schwab <schwab@linux-m68k.org>
13353
172418ad
AS
13354 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
13355 format. (Bug#8806)
13356
43f862f7
AS
13357 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
13358
810928a2
AS
13359 * xfns.c (x_set_scroll_bar_default_width): Move declarations
13360 before statements.
13361
a059fe24
JD
133622011-06-05 Jan Djärv <jan.h.d@swipnet.se>
13363
13364 * gtkutil.c (xg_get_default_scrollbar_width): New function.
13365
13366 * gtkutil.h: Declare xg_get_default_scrollbar_width.
13367
13368 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
13369 min width by calling x_set_scroll_bar_default_width (Bug#8505).
13370
989bf368
JB
133712011-06-05 Juanma Barranquero <lekktu@gmail.com>
13372
13373 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
13374
4b80f674
CY
133752011-06-04 Chong Yidong <cyd@stupidchicken.com>
13376
13377 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
13378 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
13379 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
13380 New error handlers.
4b80f674
CY
13381 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
13382 Obey Vx_select_enable_clipboard_manager. Catch errors in
13383 x_clipboard_manager_save (Bug#8779).
13384 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 13385 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 13386
99a33b77 133872011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
13388
13389 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
13390
99a33b77 133912011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
13392
13393 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
13394 in the current matrix if keep_current_p is non-zero.
13395
8264569d
EZ
133962011-06-04 Eli Zaretskii <eliz@gnu.org>
13397
13398 * bidi.c (bidi_level_of_next_char): Fix last change.
13399
57f97249
EZ
134002011-06-03 Eli Zaretskii <eliz@gnu.org>
13401
fec2107c 13402 Support bidi reordering of text covered by display properties.
57f97249 13403
fec2107c
EZ
13404 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
13405 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
13406 (bidi_cache_search, bidi_cache_iterator_state)
13407 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
13408 (bidi_level_of_next_char, bidi_move_to_visually_next):
13409 Support character positions inside a run of characters covered by a
fec2107c
EZ
13410 display string.
13411 (bidi_paragraph_init, bidi_resolve_explicit_1)
13412 (bidi_level_of_next_char): Call bidi_fetch_char and
13413 bidi_fetch_char_advance instead of FETCH_CHAR and
13414 FETCH_CHAR_ADVANCE.
13415 (bidi_init_it): Initialize new members.
13416 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
13417 definitions.
13418 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
13419 instead of using explicit *_CHAR codes.
d6d100dd
SM
13420 (bidi_resolve_explicit, bidi_resolve_weak):
13421 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
13422 bidirectional text is supported only in multibyte buffers.
13423 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
13424 it to initialize the frame_window_p member of struct bidi_it.
13425 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
13426 (bidi_resolve_explicit, bidi_resolve_weak)
13427 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
13428 bidi_it->nchars is non-positive.
13429 (bidi_level_of_next_char): Don't try to lookup the cache for the
13430 next/previous character if nothing is cached there yet, or if we
13431 were just reseat()'ed to a new position.
c40e2fb2 13432
0e14fe90
EZ
13433 * xdisp.c (set_cursor_from_row): Set start and stop points
13434 according to the row's direction when priming the loop that looks
13435 for the glyph on which to display cursor.
13436 (single_display_spec_intangible_p): Function deleted.
13437 (display_prop_intangible_p): Reimplement to call
13438 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
13439 Accept 3 additional arguments needed by handle_display_spec.
13440 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
13441 values: lists, `(when COND...)' forms, etc.
13442 (single_display_spec_string_p): Support property values that are
13443 lists with the argument STRING its top-level element.
13444 (display_prop_string_p): Fix the condition for processing a
13445 property that is a list to be consistent with handle_display_spec.
fec2107c 13446 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
13447 last portion of handle_display_prop.
13448 (compute_display_string_pos): Accept additional argument
13449 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
13450 value of a `display' property is a "replacing spec".
13451 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
13452 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
13453 the display property, but just return a value indicating whether
13454 the display property will replace the characters it covers.
13455 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
13456 frame_window_p members of struct bidi_it.
d6d100dd
SM
13457 (compute_display_string_pos, compute_display_string_end):
13458 New functions.
fec2107c
EZ
13459 (push_it): Accept second argument POSITION, where pop_it should
13460 jump to continue iteration.
13461 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 13462
fec2107c
EZ
13463 * keyboard.c (adjust_point_for_property): Adjust the call to
13464 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
13465
13466 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
13467 (bidi_init_it): Update prototypes.
13468 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
13469 (compute_display_string_pos, compute_display_string_end):
13470 Declare prototypes.
fec2107c
EZ
13471 (struct bidi_it): New members nchars and disp_pos. ch_len is now
13472 EMACS_INT.
fc6f18ce 13473
40087514 134742011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 13475
57f53182
PE
13476 Malloc failure behavior now depends on size of allocation.
13477 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
13478 * lisp.h: Change signatures accordingly.
13479 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
13480 All callers changed. (Bug#8762)
13481
13482 * gnutls.c: Use Emacs's memory allocators.
13483 Without this change, the gnutls library would invoke malloc etc.
13484 directly, which causes problems on non-SYNC_INPUT hosts, and which
13485 runs afoul of improving memory_full behavior. (Bug#8761)
13486 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
13487 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
13488 xfree instead of the default malloc, realloc, free.
13489 (Fgnutls_boot): No need to check for memory allocation failure,
13490 since xmalloc does that for us.
13491
ac32cd99 13492 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
13493 * category.c (hash_get_category_set):
13494 * ccl.c (ccl_driver):
13495 * charset.c (Fdefine_charset_internal):
13496 * charset.h (struct charset.hash_index):
13497 * composite.c (get_composition_id, gstring_lookup_cache)
13498 (composition_gstring_put_cache):
13499 * composite.h (struct composition.hash_index):
13500 * dispextern.h (struct image.hash):
13501 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
13502 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
13503 (hashfn_equal, hashfn_user_defined, make_hash_table)
13504 (maybe_resize_hash_table, hash_lookup, hash_put)
13505 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
13506 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
13507 (Fsxhash, Fgethash, Fputhash, Fmaphash):
13508 * image.c (make_image, search_image_cache, lookup_image)
13509 (xpm_put_color_table_h):
13510 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 13511 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 13512 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 13513 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
13514 * alloc.c (allocate_vectorlike):
13515 Check for overflow in vector size calculations.
13516 * ccl.c (ccl_driver):
13517 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
13518 * fns.c, image.c: Remove unnecessary static decls that would otherwise
13519 need to be updated by these changes.
40087514
PE
13520 * fns.c (make_hash_table, maybe_resize_hash_table):
13521 Check for integer overflow with large hash tables.
0de4bb68
PE
13522 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
13523 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
13524 (SXHASH_REDUCE): New macro.
13525 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
13526 Use it instead of discarding useful hash info with large hash values.
13527 (sxhash_float): New function.
13528 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
13529 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
13530 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
13531 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
13532 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
13533 Adjust signatures to match updated version of code.
13534 (consing_since_gc): Now EMACS_INT, since a single hash table can
13535 use more than INT_MAX bytes.
13536
698d32e2
DN
135372011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
13538
13539 Make it possible to build with GCC-4.6+ -O2 -flto.
13540
13541 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
13542
fd6fa53f
SM
135432011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
13544
13545 * minibuf.c (get_minibuffer, read_minibuf_unwind):
13546 Call minibuffer-inactive-mode.
13547
864db017
JB
135482011-05-31 Juanma Barranquero <lekktu@gmail.com>
13549
13550 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
13551 Update dependencies.
13552
2ad0baf4
DN
135532011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
13554
13555 * data.c (init_data): Remove code for UTS, this system is not
13556 supported anymore.
13557
4fcc2638
DN
135582011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
13559
13560 Don't force ./temacs to start in terminal mode.
13561
13562 * frame.c (make_initial_frame): Initialize faces in all cases, not
13563 only when CANNOT_DUMP is defined.
13564 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
13565
c56e0fd5
DN
135662011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
13567
13568 * dispnew.c (add_window_display_history): Use const for the string
13569 pointer. Remove declaration, not needed.
13570
333d54da 135712011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 13572
55d4c1b2 13573 Use 'inline', not 'INLINE'.
333d54da 13574 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
13575 * alloc.c, fontset.c (INLINE): Remove.
13576 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
13577 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
13578 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
13579 * gmalloc.c (register_heapinfo): Use inline unconditionally.
13580 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
13581
738db178
DN
135822011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
13583
13584 Make it possible to run ./temacs.
13585
13586 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
13587 syms_of_callproc does the same thing. Remove test for
13588 "initialized", do it in the caller.
13589 * emacs.c (main): Avoid calling set_initial_environment when dumping.
13590
620c53a6
SM
135912011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
13592
13593 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
13594 (read_minibuf): Use get_minibuffer.
13595 (syms_of_minibuf): Use DEFSYM.
13596 (Qmetadata): New var.
13597 * data.c (Qbuffer): Don't make it static.
13598 (syms_of_data): Use DEFSYM.
13599
e003a292
PE
136002011-05-31 Paul Eggert <eggert@cs.ucla.edu>
13601
13602 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
13603 (CCL_CODE_MIN): New macro.
13604
ed008a6d
PE
136052011-05-30 Paul Eggert <eggert@cs.ucla.edu>
13606
3687c2ef
PE
13607 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
13608
ed008a6d
PE
13609 * eval.c (Qdebug): Now static.
13610 * lisp.h (Qdebug): Remove decl. This reverts a part of the
13611 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
13612 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
13613
d66c4c7c
CY
136142011-05-29 Chong Yidong <cyd@stupidchicken.com>
13615
13616 * image.c: Various fixes to ImageMagick code comments.
13617 (Fimagemagick_types): Doc fix.
13618
5fbc2025
PE
136192011-05-29 Paul Eggert <eggert@cs.ucla.edu>
13620
0196f88a
PE
13621 Minor fixes prompted by GCC 4.6.0 warnings.
13622
13623 * xselect.c (converted_selections, conversion_fail_tag): Now static.
13624
5fbc2025
PE
13625 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
13626 (x_clipboard_manager_save_all): Move extern decl to ...
13627 * xterm.h: ... here, so that it can be checked for consistency.
13628
1dd3c2d9
CY
136292011-05-29 Chong Yidong <cyd@stupidchicken.com>
13630
13631 * xselect.c (x_clipboard_manager_save_frame)
13632 (x_clipboard_manager_save_all): New functions.
13633 (Fx_clipboard_manager_save): Lisp function deleted.
13634
13635 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
13636 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
13637
13638 * xterm.h: Update prototype.
13639
5ba6571d
WX
136402011-05-28 William Xu <william.xwl@gmail.com>
13641
13642 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
13643 exiting (Bug#8239).
13644
3eaff834
JM
136452011-05-28 Jim Meyering <meyering@redhat.com>
13646
e1900994 13647 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
13648 * fns.c (to_uchar): Define.
13649 (crypto_hash_function): Use it to convert some newly-signed
13650 variables to unsigned, to avoid sign-extension bugs. For example,
13651 without this change, (md5 "truc") would evaluate to
13652 45723a2aff78ff4fff7fff1114760e62 rather than the expected
13653 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 13654 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 13655
0f6990a7
PE
136562011-05-27 Paul Eggert <eggert@cs.ucla.edu>
13657
13658 Integer overflow fixes.
c8a9ca5a 13659
08686060
PE
13660 * dbusbind.c: Serial number integer overflow fixes.
13661 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
13662 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
13663 to hold a serial number that is too large for a fixnum.
13664 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13665 Check for serial numbers out of range. Decode any serial number
59568bf0 13666 that was so large that it became a float. (Bug#8722)
08686060 13667
2d1fc3c7
PE
13668 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
13669 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13670 Use XFASTINT rather than XUINT when numbers are nonnegative.
13671 (xd_append_arg, Fdbus_method_return_internal):
13672 (Fdbus_method_error_internal): Likewise. Also, for unsigned
13673 arguments, check that Lisp number is nonnegative, rather than
59568bf0 13674 silently wrapping negative numbers around. (Bug#8722)
30217ff0 13675 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 13676 (Bug#8722)
2d1fc3c7 13677
c8a9ca5a
PE
13678 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
13679
519e1d69
PE
13680 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
13681
6df6ae42 13682 ccl: Add integer overflow checks.
30569699
PE
13683 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
13684 (IN_INT_RANGE): New macros.
13685 (ccl_driver): Use them to check for integer overflow when
13686 decoding a CCL program. Many of the new checks are whether XINT (x)
13687 fits in int; it doesn't always, on 64-bit hosts. The new version
13688 doesn't catch all possible integer overflows, but it's an
847044ea 13689 improvement. (Bug#8719)
30569699 13690
c11285dc
PE
13691 * alloc.c (make_event_array): Use XINT, not XUINT.
13692 There's no need for unsigned here.
13693
fdccd48e
PE
13694 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
13695 This follows up to the 2011-05-06 change that substituted uintptr_t
13696 for EMACS_INT. This case wasn't caught back then.
13697
37910ab2
PE
13698 Rework Fformat to avoid integer overflow issues.
13699 * editfns.c: Include <float.h> unconditionally, as it's everywhere
13700 now (part of C89). Include <verify.h>.
13701 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
13702 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
13703 (Fformat): Avoid the prepass trying to compute sizes; it was only
13704 approximate and thus did not catch overflow reliably. Instead, walk
13705 through the format just once, formatting and computing sizes as we go,
13706 checking for integer overflow at every step, and allocating a larger
13707 buffer as needed. Keep track separately whether the format is
13708 multibyte. Keep only the most-recently calculated precision, rather
13709 than them all. Record whether each argument has been converted to
13710 string. Use EMACS_INT, not int, for byte and char and arg counts.
13711 Support field widths and precisions larger than INT_MAX. Avoid
13712 sprintf's undefined behavior with conversion specifications such as %#d
13713 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
13714 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
13715 formatting out-of-range floating point numbers with int
9173deec 13716 formats. (Bug#8668)
37910ab2 13717
2e6578fb
PE
13718 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
13719
0ae6bdee
PE
13720 * data.c: Avoid integer truncation in expressions involving floats.
13721 * data.c: Include <intprops.h>.
13722 (arith_driver): When there's an integer overflow in an expression
13723 involving floating point, convert the integers to floating point
13724 so that the resulting value does not suffer from catastrophic
13725 integer truncation. For example, on a 64-bit host (* 4
13726 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
13727 Do not rely on undefined behavior after integer overflow.
13728
de883a70
PE
13729 merge count_size_as_multibyte, parse_str_to_multibyte
13730 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 13731 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
13732 Check for integer overflow.
13733 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
13734 since it's now a duplicate of the other. This is more of
13735 a character than a buffer op, so better that it's in character.c.
13736 * fns.c, print.c: Adjust to above changes.
13737
2ff916cb
PE
137382011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
13739
13740 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
13741
f1b54466
PE
137422011-05-27 Paul Eggert <eggert@cs.ucla.edu>
13743
fb1ac845
PE
13744 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
13745 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
13746 (x_clipboard_manager_save): Now static.
13747 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
13748
f1b54466
PE
13749 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
13750 (crypto_hash_function): Now static.
13751 Fix pointer signedness problems. Avoid unnecessary initializations.
13752
a9f737ee
CY
137532011-05-27 Chong Yidong <cyd@stupidchicken.com>
13754
13755 * termhooks.h (Vselection_alist): Make it terminal-local.
13756
13757 * terminal.c (create_terminal): Initialize it.
13758
13759 * xselect.c: Support for clipboard managers.
13760 (Vselection_alist): Move to termhooks.h as terminal-local var.
13761 (LOCAL_SELECTION): New macro.
13762 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
13763 (symbol_to_x_atom): Remove gratuitous arg.
13764 (x_handle_selection_request, lisp_data_to_selection_data)
13765 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
13766 (x_own_selection, x_get_local_selection, x_convert_selection):
13767 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
13768 (some_frame_on_display): Delete unused function.
13769 (Fx_own_selection_internal, Fx_get_selection_internal)
13770 (Fx_disown_selection_internal, Fx_selection_owner_p)
13771 (Fx_selection_exists_p): New optional frame arg.
13772 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
13773 (x_handle_selection_clear): Don't treat other terminals with the
13774 same keyboard specially. Use the terminal-local Vselection_alist.
13775 (x_clear_frame_selections): Use Frun_hook_with_args.
13776
13777 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
13778
13779 * xterm.h: Add support for those atoms.
13780
e067f0c1
CY
137812011-05-26 Chong Yidong <cyd@stupidchicken.com>
13782
13783 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
13784 (converted_selections, conversion_fail_tag): New global variables.
13785 (x_selection_request_lisp_error): Free the above.
13786 (x_get_local_selection): Remove unnecessary code.
13787 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
13788 of converted selections stored in converted_selections.
13789 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
13790 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
13791 (x_convert_selection): New function.
13792 (x_handle_selection_event): Simplify.
13793 (x_get_foreign_selection): Don't ignore incoming requests while
13794 waiting for an answer; this will fail when we implement
13795 SAVE_TARGETS, and seems unnecessary anyway.
13796 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
13797 (Vx_sent_selection_functions): Doc fix.
13798
0f4aebc0
LL
137992011-05-26 Leo Liu <sdl.web@gmail.com>
13800
13801 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
13802
e61124cd
YM
138032011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13804
13805 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
13806
13807 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
13808 for fringe update if it has periodic bitmap.
ac389d0c 13809 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
13810 and fringe_bitmap_periodic_p.
13811
13812 * fringe.c (get_fringe_bitmap_data): New function.
13813 (draw_fringe_bitmap_1, update_window_fringes): Use it.
13814 (update_window_fringes): Record periodicity of fringe bitmap in glyph
13815 row. Mark glyph row for fringe update if periodicity changed.
13816
13817 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
13818 for fringe update unless it has periodic bitmap.
13819
f16d9837
KH
138202011-05-25 Kenichi Handa <handa@m17n.org>
13821
13822 * xdisp.c (get_next_display_element): Set correct it->face_id for
13823 a static composition.
13824
e1b90ef6
LL
138252011-05-24 Leo Liu <sdl.web@gmail.com>
13826
13827 * deps.mk (fns.o):
13828 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
13829
13830 * fns.c (crypto_hash_function, Fsha1): New function.
13831 (Fmd5): Use crypto_hash_function.
13832 (syms_of_fns): Add Ssha1.
13833
7400048f
PE
138342011-05-22 Paul Eggert <eggert@cs.ucla.edu>
13835
13836 * gnutls.c: Remove unused macros.
13837 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
13838 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
13839 Remove macros that are defined and never used.
13840 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
13841
abb71cf4
CY
138422011-05-22 Chong Yidong <cyd@stupidchicken.com>
13843
13844 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
13845 (Fx_get_selection_internal): Minor cleanup.
13846 (Fx_own_selection_internal): Rename arguments for consistency with
13847 select.el.
13848
6307db39
PE
138492011-05-22 Paul Eggert <eggert@cs.ucla.edu>
13850
13851 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
13852
f3d4e0a4
CY
138532011-05-22 Chong Yidong <cyd@stupidchicken.com>
13854
13855 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
13856
4d8ade89
YM
138572011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13858
13859 * dispnew.c (scrolling_window): Don't exclude the case that the
13860 last enabled row in the desired matrix touches the bottom boundary.
13861
32078c8d
GM
138622011-05-21 Glenn Morris <rgm@gnu.org>
13863
13864 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
13865 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
13866 and add some more files.
32078c8d 13867
7285dc67
EZ
138682011-05-20 Eli Zaretskii <eliz@gnu.org>
13869
13870 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
13871 report_file_error introduced by the change from 2011-05-07.
13872
89d1bd22
PE
138732011-05-20 Paul Eggert <eggert@cs.ucla.edu>
13874
13875 * systime.h (Time): Define only if emacs is defined.
13876 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
13877 where the include path doesn't have X11/X.h by default. See
13878 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
13879
cd394be1 138802011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
13881
13882 * composite.c (find_automatic_composition): Fix previous change.
13883
b9704ad9
GM
138842011-05-20 Glenn Morris <rgm@gnu.org>
13885
13886 * lisp.mk: New file, split from Makefile.in.
13887 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
13888 (shortlisp): Remove.
13889 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
13890
4a720484
GM
138912011-05-19 Glenn Morris <rgm@gnu.org>
13892
13893 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
13894 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
13895 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
13896 (lisp): Set the order to that of loadup.el.
13897 (shortlisp): Make it a copy of $lisp.
13898 (SOME_MACHINE_LISP): Remove.
13899 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
13900 Use just $shortlisp, not $SOME_MACHINE_LISP too.
13901
a28d4396
KH
139022011-05-18 Kenichi Handa <handa@m17n.org>
13903
13904 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
13905 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
13906 (find_automatic_composition): Mostly rewrite for efficiency.
13907
a2b1fa8e
JB
139082011-05-18 Juanma Barranquero <lekktu@gmail.com>
13909
13910 * makefile.w32-in: Update dependencies.
13911
8e1f5610
CS
139122011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
13913
13914 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 13915 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 13916
7025ee00 139172011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 13918
cdfa6eab
PE
13919 Fix some integer overflow issues, such as string length overflow.
13920
06d6db33
PE
13921 * insdel.c (count_size_as_multibyte): Check for string overflow.
13922
2b4560a8
PE
13923 * character.c (lisp_string_width): Check for string overflow.
13924 Use EMACS_INT, not int, for string indexes and lengths; in
13925 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
13926 the resulting string length overflows an EMACS_INT; instead,
13927 report a string overflow if no precision given. When checking for
13928 precision exhaustion, use a check that cannot possibly have
13929 integer overflow. (Bug#8675)
13930 * character.h (lisp_string_width): Adjust to new signature.
13931
cb93f9be
PE
13932 * alloc.c (string_overflow): New function.
13933 (Fmake_string): Use it. This doesn't change behavior, but saves
13934 a few bytes and will simplify future changes.
13935 * character.c (string_escape_byte8): Likewise.
13936 * lisp.h (string_overflow): New decl.
13937
1a1f3366
PE
13938 Fixups, following up to the user-interface timestamp change.
13939 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
13940 for UI timestamps, instead of unsigned long.
9fbd6841
PE
13941 * msdos.c (mouse_get_pos): Likewise.
13942 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
13943 * w32gui.h (Time): Define by including "systime.h" rather than by
13944 declaring it ourselves. (Bug#8664)
13945
d4e3e4d3
PE
13946 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
13947 * image.c (clear_image_cache): Likewise.
13948
f6a24d19
PE
13949 * term.c (term_mouse_position): Don't assume time_t wraparound.
13950
08dc5ae6
PE
13951 Be more systematic about user-interface timestamps.
13952 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
13953 and sometimes 'EMACS_UINT', to represent these timestamps.
13954 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
13955 This makes the code easier to follow, and makes it easier to catch
13956 integer overflow bugs such as Bug#8664.
13957 * frame.c (Fmouse_position, Fmouse_pixel_position):
13958 Use Time, not unsigned long, for user-interface timestamps.
13959 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
13960 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
13961 * keyboard.h (last_event_timestamp): Likewise.
13962 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
13963 * menu.h (xmenu_show): Likewise.
13964 * term.c (term_mouse_position): Likewise.
13965 * termhooks.h (struct input_event.timestamp): Likewise.
13966 (struct terminal.mouse_position_hook): Likewise.
13967 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
13968 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
13969 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
13970 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
13971 what it was before.
13972 * menu.h, termhooks.h: Include "systime.h", for Time.
13973
8e55734a
PE
13974 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
13975 Don't assume that the difference between two unsigned long values
13976 can fit into an integer. At this point, we know button_down_time
13977 <= event->timestamp, so the difference must be nonnegative, so
13978 there's no need to cast the result if double-click-time is
13979 nonnegative, as it should be; check that it's nonnegative, just in
13980 case. This bug is triggered when events are more than 2**31 ms
86db42d2 13981 apart (about 25 days). (Bug#8664)
8e55734a 13982
841f1b75 13983 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 13984 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 13985
3e26f69c
PE
13986 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
13987 that always fit in int. Use a sentinel instead of a counter, to
13988 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
13989 * frame.h (struct frame): Use int for menu_bar_items_used
13990 instead of EMACS_INT, since it always fits in int.
3e26f69c 13991
5cc152c0
PE
13992 * menu.c (grow_menu_items): Check for int overflow.
13993
d89eb65e
PE
13994 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
13995
5235bd3e
PE
13996 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
13997 Before, the code was not consistent. These values cannot exceed
13998 2**31 - 1 so there's no need to make them unsigned.
13999 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
14000 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
14001 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
14002 as modifiers.
14003 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
14004
bc827e23
PE
14005 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
14006 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
14007 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
14008 presumably because the widths might not match.
14009
78eb494e
PE
14010 * window.c (size_window): Avoid needless test at loop start.
14011
04f2d78b
CB
140122011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
14013
14014 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
14015
d2fc7e3d 140162011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
14017
14018 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
14019
d2fc7e3d 140202011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
14021
14022 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
14023 `width' to `bar_area_x' and `bar_area_width', respectively.
14024 (x_scroll_run): Take account of fringe background extension.
14025
04f2d78b
CB
14026 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
14027 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
14028 `bar_area_width', respectively.
14029 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
14030 background extension.
14031
79b70037
GM
140322011-05-10 Jim Meyering <meyering@redhat.com>
14033
14034 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
14035
2f142cc5
JB
140362011-05-10 Juanma Barranquero <lekktu@gmail.com>
14037
14038 * image.c (Finit_image_library): Return t for built-in image types,
14039 like pbm and xbm. (Bug#8640)
14040
57679c86
AS
140412011-05-09 Andreas Schwab <schwab@linux-m68k.org>
14042
14043 * w32menu.c (set_frame_menubar): Fix submenu allocation.
14044
888c9e86
EZ
140452011-05-07 Eli Zaretskii <eliz@gnu.org>
14046
b0512a1d
EZ
14047 * w32console.c (Fset_screen_color): Doc fix.
14048 (Fget_screen_color): New function.
14049 (syms_of_ntterm): Defsubr it.
14050
7285dc67
EZ
14051 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
14052 unlink the temporary file if Fcall_process didn't create it in the
14053 first place.
14054 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
14055 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
14056 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
14057 cue to call_process_cleanup not to close that handle.
14058
4d3fcc8e
BK
140592011-05-07 Ben Key <bkey76@gmail.com>
14060
14061 * makefile.w32-in: The bootstrap-temacs rule now makes use of
14062 one of two shell specific rules, either bootstrap-temacs-CMD or
14063 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
14064 to the previous implementation of the bootstrap-temacs rule.
14065 The bootstrap-temacs-CMD rule is similar to the previous
14066 implementation of the bootstrap-temacs rule except that it
14067 makes use of the ESC_CFLAGS variable instead of the CFLAGS
14068 variable.
14069
14070 These changes, along with some changes to nt/configure.bat,
14071 nt/gmake.defs, and nt/nmake.defs, are required to extend my
14072 earlier fix to add support for --cflags and --ldflags options
14073 that include quotes so that it works whether make uses cmd or
14074 sh as the shell.
14075
b4289b64
MA
140762011-05-06 Michael Albinus <michael.albinus@gmx.de>
14077
14078 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
14079 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
14080 is a constant.
14081 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
14082 a string. Handle both cases.
14083 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
14084 (Fdbus_register_method): Use Qinvalid_function.
14085
af4c0e28
JB
140862011-05-06 Juanma Barranquero <lekktu@gmail.com>
14087
14088 * makefile.w32-in: Update dependencies.
14089 (LISP_H): Add inttypes.h and stdin.h.
14090 (PROCESS_H): Add unistd.h.
14091
c51453d9
EZ
140922011-05-06 Eli Zaretskii <eliz@gnu.org>
14093
14094 * lread.c: Include limits.h (fixes the MS-Windows build broken by
14095 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
14096
8ff0ac3c 140972011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 14098
4c4b566b
PE
14099 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
14100
aab2b9b5
PE
14101 * term.c (vfatal): Remove stray call to va_end.
14102 It's not needed and the C Standard doesn't allow it here anyway.
14103
c378da0b
PE
14104 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
14105 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
14106
288b08c7
PE
14107 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
14108 bytes.
14109
e3601888
PE
14110 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
14111
db6c0e74
PE
14112 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
14113
dd5963ea
PE
14114 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
14115
88c9450f
PE
14116 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
14117
2f9442b8
PE
14118 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
14119
c032b5f8
PE
14120 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
14121 * charset.c (Fdefine_charset_internal): Don't initialize
14122 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 14123 32-bit int (Bug#8600).
a108c10b
PE
14124
14125 * lread.c (read_integer): Be more consistent with string-to-number.
14126 Use string_to_number to do the actual conversion; this avoids
14127 rounding errors and fixes some other screwups. Without this fix,
14128 for example, #x1fffffffffffffff was misread as -2305843009213693952.
14129 (digit_to_number): Move earlier, for benefit of read_integer.
14130 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 14131 not a digit in any supported base. (Bug#8602)
a108c10b 14132
ad5f9eea
PE
14133 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
14134
aec1708a
PE
14135 * dispnew.c (scrolling_window): Return 1 if we scrolled,
14136 to match comment at start of function. This also removes a
14137 GCC warning about overflow in a 32+64-bit port.
14138
47be4ab5
PE
14139 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
14140
371cac43
PE
14141 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
14142 Reported by Stefan Monnier in
14143 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
14144 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
14145 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 14146
d01a7826
PE
14147 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
14148 (EMACS_UINTPTR): Likewise, with uintptr_t.
14149
7fd47d5c
PE
14150 * lisp.h: Prefer 64-bit EMACS_INT if available.
14151 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
14152 on 32-bit hosts that have 64-bit int, so that they can access
14153 large files.
122b0c86
PE
14154 However, temporarily disable this change unless the temporary
14155 symbol WIDE_EMACS_INT is defined.
7fd47d5c 14156
8727937b
PE
14157 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
14158
8ac068ac
PE
14159 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
14160 This removes an assumption that EMACS_INT and long are the same
14161 width as pointers. The assumption is true for Emacs porting targets
14162 now, but we want to make other targets possible.
14163 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
14164 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
14165 In the rest of the code, change types of integers that hold casted
14166 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
14167 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
14168 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
14169 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
14170 No need to cast type when ORing.
14171 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
14172 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
14173 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
14174 assume EMACS_INT is the same width as char *.
14175 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
14176 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
14177 Remove no-longer-needed casts.
14178 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
14179 (xg_tool_bar_help_callback, xg_make_tool_item):
14180 Use EMACS_INTPTR to hold an integer
14181 that will be cast to void *; this can avoid a GCC warning
14182 if EMACS_INT is not the same width as void *.
14183 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
14184 * xdisp.c (display_echo_area_1, resize_mini_window_1):
14185 (current_message_1, set_message_1):
14186 Use a local to convert to proper width without a cast.
14187 * xmenu.c (dialog_selection_callback): Likewise.
14188
ede49d71
PE
14189 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
14190 Also, don't assume VALBITS / RAND_BITS is less than 5,
14191 and don't rely on undefined behavior when shifting a 1 left into
14192 the sign bit.
14193 * lisp.h (get_random): Change signature to match.
14194
2f30ecd0
PE
14195 * lread.c (hash_string): Use size_t, not int, for hash computation.
14196 Normally we prefer signed values; but hashing is special, because
14197 it's better to use unsigned division on hash table sizes so that
14198 the remainder is nonnegative. Also, size_t is the natural width
14199 for hashing into memory. The previous code used 'int', which doesn't
14200 retain enough info to hash well into very large tables.
14201 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
14202
2a866e7b
PE
14203 * dbusbind.c: Don't possibly lose pointer info when converting.
14204 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
14205 Use XPNTR rather than XHASH, so that the high-order bits of
14206 the pointer aren't lost when converting through void *.
14207
51639eac
PE
14208 * eval.c (Fautoload): Don't double-shift a pointer.
14209
92394119
PE
14210 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
14211
dbdb9a7c
JB
142122011-05-06 Juanma Barranquero <lekktu@gmail.com>
14213
14214 * gnutls.c (DEF_GNUTLS_FN):
14215 * image.c (DEF_IMGLIB_FN): Make function pointers static.
14216
db7a0b4f
AS
142172011-05-05 Andreas Schwab <schwab@linux-m68k.org>
14218
14219 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
14220 marker. (Bug#8610)
14221
cd394be1 142222011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
14223
14224 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
14225 New version that can reserve upto 2GB of heap space.
14226
f7ff1b0f 142272011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
14228
14229 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
14230
639c109b
TZ
142312011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
14232
14233 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
14234 `gnutls_certificate_set_x509_key_file'.
14235
d2127135
JB
142362011-05-05 Juanma Barranquero <lekktu@gmail.com>
14237
14238 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
14239 Update dependencies.
14240
e968f4f3
JB
142412011-05-04 Juanma Barranquero <lekktu@gmail.com>
14242
14243 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
14244 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
14245 Remove unused parameter `fildes'.
14246 * process.c (read_process_output, send_process): Don't pass it.
14247
84d358f0
JB
142482011-05-04 Juanma Barranquero <lekktu@gmail.com>
14249
14250 Fix previous change: the library cache is defined in w32.c.
14251 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
14252 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
14253
0898ca10
JB
142542011-05-04 Juanma Barranquero <lekktu@gmail.com>
14255
14256 Implement dynamic loading of GnuTLS on Windows.
14257
14258 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
14259 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
14260 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
14261 Declare.
14262
14263 * gnutls.c (Qgnutls_dll): Define.
14264 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
14265 (gnutls_*): Declare function pointers.
14266 (init_gnutls_functions): New function to initialize function pointers.
14267 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
14268 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
14269 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
14270 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
14271 (emacs_gnutls_write, emacs_gnutls_read)
14272 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
14273 (Fgnutls_available_p): New function.
14274 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
14275 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
14276 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
14277
14278 * image.c: Include w32.h.
14279 (Vimage_type_cache): Delete.
14280 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
14281 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
14282 (w32_delayed_load): Move to w32.c.
14283
14284 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
14285
14286 * w32.c (QCloaded_from, Vlibrary_cache): Define.
14287 (w32_delayed_load): Move from image.c. When loading a library, record
14288 its filename in the :loaded-from property of the library id.
14289 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
14290 Initialize and staticpro them.
14291 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
14292
14293 * process.c: Include lisp.h before w32.h, not after.
14294 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
14295 instead of gnutls_record_check_pending.
14296
14297 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
14298
ff4de4aa
TZ
142992011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
14300
14301 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
14302 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
14303 as passed in.
14304
abe95abb
JD
143052011-05-03 Jan Djärv <jan.h.d@swipnet.se>
14306
14307 * xterm.c (x_set_frame_alpha): Do not set property on anything
14308 else than FRAME_X_OUTER_WINDOW (Bug#8608).
14309
e16e55d4
JB
143102011-05-02 Juanma Barranquero <lekktu@gmail.com>
14311
14312 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
14313
bafcf6a5
JB
143142011-05-02 Juanma Barranquero <lekktu@gmail.com>
14315
14316 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
14317 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
14318 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
14319 (gnutls_global_initialized, Qgnutls_bootprop_priority)
14320 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
14321 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
14322 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
14323 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
14324 (Qgnutls_bootprop_callbacks_verify): Make static.
14325
e7a6747f
AS
143262011-05-01 Andreas Schwab <schwab@linux-m68k.org>
14327
19ed11ba
AS
14328 * callproc.c: Indentation fixup.
14329
e7a6747f 14330 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
14331 (wait_for_termination, interruptible_wait_for_termination):
14332 Move after wait_for_termination_1.
e7a6747f 14333
1ef14cb4
LMI
143342011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
14335
14336 * sysdep.c (interruptible_wait_for_termination): New function
14337 which is like wait_for_termination, but allows keyboard
14338 interruptions.
14339
14340 * callproc.c (Fcall_process): Add (:file "file") as an option for
14341 the STDOUT buffer.
14342 (Fcall_process_region): Ditto.
14343
330d880c
EZ
143442011-04-30 Eli Zaretskii <eliz@gnu.org>
14345
8db90b73
EZ
14346 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
14347 rather than `XVECTOR (FOO)->size'.
14348
330d880c
EZ
14349 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
14350 inttypes.h, as a gnulib replacement is used if it not available in
14351 system headers.
14352
15cbd324
EZ
143532011-04-21 Eli Zaretskii <eliz@gnu.org>
14354
14355 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
14356 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
14357 of MOST_POSITIVE_FIXNUM. (Bug#8528)
14358
14359 * coding.c (coding_alloc_by_realloc): Error out if destination
14360 will grow beyond MOST_POSITIVE_FIXNUM.
14361 (decode_coding_emacs_mule): Abort if there isn't enough place in
14362 charbuf for the composition carryover bytes. Reserve an extra
14363 space for up to 2 characters produced in a loop.
14364 (decode_coding_iso_2022): Abort if there isn't enough place in
14365 charbuf for the composition carryover bytes.
14366
143672011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 14368
ae940cca
EZ
14369 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
14370 aborting when %lld or %lll format is passed.
14371 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
14372 %llo or %llx format is passed. (Bug#8545)
14373
03ab8921
EZ
14374 * window.c (window_scroll_line_based): Use a marker instead of
14375 simple variables to record original value of point. (Bug#7952)
14376
afda1437
EZ
14377 * doprnt.c (doprnt): Fix the case where a multibyte sequence
14378 produced by %s or %c overflows available buffer space. (Bug#8545)
14379
f76dee0c
PE
143802011-04-28 Paul Eggert <eggert@cs.ucla.edu>
14381
14382 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 14383 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 14384
fdc5744d
JB
143852011-04-28 Juanma Barranquero <lekktu@gmail.com>
14386
14387 * w32.c (init_environment): Warn about defaulting HOME to C:\.
14388
638f053a
JB
143892011-04-28 Juanma Barranquero <lekktu@gmail.com>
14390
14391 * keyboard.c (Qdelayed_warnings_hook): Define.
14392 (command_loop_1): Run `delayed-warnings-hook'
14393 if Vdelayed_warnings_list is non-nil.
14394 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
14395 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
14396
d178f871
EZ
143972011-04-28 Eli Zaretskii <eliz@gnu.org>
14398
14399 * doprnt.c (doprnt): Don't return value smaller than the buffer
14400 size if the message was truncated. (Bug#8545).
14401
b124fd93
JB
144022011-04-28 Juanma Barranquero <lekktu@gmail.com>
14403
14404 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
14405 (Fx_window_property): #if-0 the whole functions, not just the bodies.
14406
e810457d
PE
144072011-04-27 Paul Eggert <eggert@cs.ucla.edu>
14408
14409 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
14410
ea51cceb
JB
144112011-04-27 Juanma Barranquero <lekktu@gmail.com>
14412
14413 * makefile.w32-in: Update dependencies.
14414
94dcfacf
EZ
144152011-04-27 Eli Zaretskii <eliz@gnu.org>
14416
14417 Improve `doprnt' and its usage. (Bug#8545)
14418 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
14419 `format_end'. Remove support for %l as a conversion specifier.
14420 Don't use xrealloc. Improve diagnostics when the %l size modifier
14421 is used. Update the commentary.
14422
14423 * eval.c (verror): Simplify calculation of size_t.
14424
14425 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
14426 messages.
14427
f61f41d7
PE
144282011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
14429
14430 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
14431 change.
14432
96fb4434
PE
144332011-04-27 Paul Eggert <eggert@cs.ucla.edu>
14434
14435 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
14436 This makes this file independent of the recent pseudovector change.
14437
671875da 144382011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 14439
69e9b5a3
PE
14440 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
14441
b5f869a7 14442 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 14443 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 14444 Remove unused local.
c8926152 14445 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 14446
841a1577 14447 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
14448 GCC 4.6.0 optimizes based on type-based alias analysis.
14449 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
14450 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
14451 != &v->size, and therefore "v->size = 1; b->size = 2; return
14452 v->size;" must therefore return 1. This assumption is incorrect
14453 for Emacs, since it type-puns struct Lisp_Vector * with many other
14454 types. To fix this problem, this patch adds a new type struct
f904488f 14455 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
14456 and pseudovectors, and helps optimizing compilers not get fooled
14457 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
14458 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
14459 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
14460 the size member.
eab3844f
PE
14461 (XSETPVECTYPE): Rewrite in terms of new macro.
14462 (XSETPVECTYPESIZE): New macro, specifying both type and size.
14463 This is a bit clearer, and further avoids the possibility of
14464 undesirable aliasing.
14465 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 14466 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
14467 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
14468 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
14469 (ASIZE): Now uses header.size rather than size.
14470 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
14471 to avoid the hassle of writing XVECTOR (foo)->header.size.
14472 (struct vectorlike_header): New type.
eab3844f
PE
14473 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
14474 object, to help avoid aliasing.
14475 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
14476 (SUBRP): Likewise, since Lisp_Subr is a special case.
14477 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
14478 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
14479 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 14480 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
14481 changed to be "header.size" and "header.next".
14482 * buffer.h (struct buffer): Likewise.
14483 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
14484 * frame.h (struct frame): Likewise.
14485 * process.h (struct Lisp_Process): Likewise.
14486 * termhooks.h (struct terminal): Likewise.
14487 * window.c (struct save_window_data, struct saved_window): Likewise.
14488 * window.h (struct window): Likewise.
14489 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
14490 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
14491 * buffer.c (init_buffer_once): Likewise.
14492 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
14493 special case.
14494 * process.c (Fformat_network_address): Use local var for size,
14495 for brevity.
14496
0df1eac5
PE
14497 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
14498
847ab9d1 14499 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
14500 * data.c (atof): Remove decl; no longer used or needed.
14501 (digit_to_number): Move to lread.c.
14502 (Fstring_to_number): Use new string_to_number function, to be
14503 consistent with how the Lisp reader treats infinities and NaNs.
14504 Do not assume that floating-point numbers represent EMACS_INT
14505 without losing information; this is not true on most 64-bit hosts.
14506 Avoid double-rounding errors, by insisting on integers when
14507 parsing non-base-10 numbers, as the documentation specifies.
14508 * lisp.h (string_to_number): New decl, replacing ...
14509 (isfloat_string): Remove.
bc0a5c13 14510 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 14511 (read1): Do not accept +. and -. as integers; this
452f4150
PE
14512 appears to have been a coding error. Similarly, do not accept
14513 strings like +-1e0 as floating point numbers. Do not report
14514 overflow for integer overflows unless the base is not 10 which
14515 means we have no simple and reliable way to continue.
14516 Break out the floating-point parsing into a new
14517 function string_to_number, so that Fstring_to_number parses
14518 floating point numbers consistently with the Lisp reader.
04f2d78b 14519 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
14520 (E_CHAR, EXP_INT): Remove, replacing with ...
14521 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
14522 (string_to_number): New function, replacing isfloat_string.
14523 This function checks for valid syntax and produces the resulting
14524 Lisp float number too. Rework it so that string-to-number
bc0a5c13 14525 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
14526 so that overflow for non-base-10 numbers is reported only when
14527 there's no portable and simple way to convert to floating point.
452f4150 14528
67769ffc
PE
14529 * textprop.c (set_text_properties_1): Rewrite for clarity,
14530 and to avoid GCC warning about integer overflow.
14531
c20db43f
PE
14532 * intervals.h (struct interval): Use EMACS_INT for members
14533 where EMACS_UINT might cause problems. See
14534 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
14535 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
14536 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
14537 All uses changed.
37aa2f85
PE
14538 (offset_intervals): Tell GCC not to worry about length overflow
14539 when negating a negative length.
c20db43f 14540
2538aa2f
PE
14541 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
14542 (overrun_check_free): Likewise.
14543
f2d3008d
PE
14544 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
14545 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
14546 word size.
14547
ec8df744
PE
14548 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
14549 (gnutls_make_error): Rename local to avoid shadowing.
14550 (gnutls_emacs_global_deinit): ifdef out; not used.
14551 (Fgnutls_boot): Use const for pointer to readonly storage.
14552 Comment out unused local. Fix pointer signedness problems.
14553
640ee02d
PE
14554 * lread.c (openp): Don't stuff size_t into an 'int'.
14555 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
14556 about possible signed overflow.
14557
6048fb2a
PE
14558 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
14559 (GDK_KEY_g): Don't define if already defined.
14560 (xg_prepare_tooltip): Avoid pointer signedness problem.
14561 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
14562
fa3c87e1
PE
14563 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
14564 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
14565
2172544b
PE
14566 * xfns.c (Fx_window_property): Simplify a bit,
14567 to make a bit faster and to avoid GCC 4.6.0 warning.
14568 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
14569
9b821a21
PE
14570 * fns.c (internal_equal): Don't assume size_t fits in int.
14571
3c616cfa
PE
14572 * alloc.c (compact_small_strings): Tighten assertion a little.
14573
c2982e87
PE
14574 Replace pEd with more-general pI, and fix some printf arg casts.
14575 * lisp.h (pI): New macro, generalizing old pEd macro to other
14576 conversion specifiers. For example, use "...%"pI"d..." rather
14577 than "...%"pEd"...".
14578 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 14579 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
14580 * alloc.c (check_pure_size): Don't overflow by converting size to int.
14581 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
14582 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
14583 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
14584 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
14585 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
14586 64-bit hosts.
14587 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
14588 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
14589 * print.c (safe_debug_print, print_object): Likewise.
14590 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
14591 to int.
6f04d126
PE
14592 Use pI instead of if-then-else-abort. Use %p to avoid casts,
14593 avoiding the 0 flag, which is not portable.
c2982e87
PE
14594 * process.c (Fmake_network_process): Use pI to avoid cast.
14595 * region-cache.c (pp_cache): Likewise.
14596 * xdisp.c (decode_mode_spec): Likewise.
14597 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
14598 behavior on 64-bit hosts with printf arg.
6f04d126 14599 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
14600 (x_stop_queuing_selection_requests): Likewise.
14601 (x_get_window_property): Don't truncate byte count to an 'int'
14602 when tracing.
0b432f21 14603
5e073ec7
PE
14604 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
14605 here, since it parses constructs like leading '-' and spaces,
14606 which are not wanted; and it overflows with large numbers.
14607 Instead, simply match F[0-9]+, which is what is wanted anyway.
14608
36372bf9
PE
14609 * alloc.c: Remove unportable assumptions about struct layout.
14610 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
14611 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
14612 (allocate_vectorlike, make_pure_vector): Use the new macros,
14613 plus offsetof, to remove unportable assumptions about struct layout.
14614 These assumptions hold on all porting targets that I know of, but
14615 they are not guaranteed, they're easy to remove, and removing them
14616 makes further changes easier.
14617
0b432f21
PE
14618 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
14619 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
14620 (string_overrun_cookie): Now const. Use initializers that
14621 don't formally overflow signed char, to avoid warnings.
000098c1
PE
14622 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
14623 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
14624 (allocate_buffer): Don't assume sizeof (struct buffer) is a
14625 multiple of sizeof (EMACS_INT); it need not be, if
14626 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 14627 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 14628
895009e1
JB
146292011-04-26 Juanma Barranquero <lekktu@gmail.com>
14630
14631 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
14632
6a7a1b0b
TZ
146332011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
14634
14635 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 14636 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
14637 Reported by Paul Eggert <eggert@cs.ucla.edu>.
14638
841a1577 146392011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
14640
14641 * lisp.h (Qdebug): List symbol.
895009e1 14642 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
14643 * keyboard.c (debug-on-event): New variable.
14644 (handle_user_signal): Break into debugger when debug-on-event
14645 matches the current signal symbol.
14646
f2d3ba6f
DN
146472011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
14648
14649 * alloc.c (check_sblock, check_string_bytes)
14650 (check_string_free_list): Convert to standard C.
14651
42ce4c63
TZ
146522011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
14653
14654 * w32.c (emacs_gnutls_push): Fix typo.
14655
825cd63c
EZ
146562011-04-25 Eli Zaretskii <eliz@gnu.org>
14657
fb11d64d
EZ
14658 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
14659 "cast to pointer from integer of different size".
14660
825cd63c
EZ
14661 Improve doprnt and its use in verror. (Bug#8545)
14662 * doprnt.c (doprnt): Document the set of format control sequences
14663 supported by the function. Use SAFE_ALLOCA instead of always
14664 using `alloca'.
14665
14666 * eval.c (verror): Don't limit the buffer size at size_max-1, that
14667 is one byte too soon. Don't use xrealloc; instead xfree and
14668 xmalloc anew.
14669
e061a11b
TZ
146702011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
14671
14672 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
14673 callbacks stage.
14674
14675 * gnutls.c: Renamed global_initialized to
14676 gnutls_global_initialized. Added internals for the
14677 :verify-hostname-error, :verify-error, and :verify-flags
14678 parameters of `gnutls-boot' and documented those parameters in the
14679 docstring. Start callback support.
9173deec
JB
14680 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
14681 unless a fatal error occurred. Call gnutls_alert_send_appropriate
14682 on error. Return error code.
e061a11b
TZ
14683 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
14684 (emacs_gnutls_read): Likewise.
14685 (Fgnutls_boot): Return handshake error code.
14686 (emacs_gnutls_handle_error): New function.
14687 (wsaerror_to_errno): Likewise.
14688
14689 * w32.h (emacs_gnutls_pull): Add prototype.
14690 (emacs_gnutls_push): Likewise.
14691
14692 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
14693 (emacs_gnutls_push): Likewise.
14694
146952011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
14696
14697 * process.c (wait_reading_process_output): Check if GnuTLS
14698 buffered some data internally if no FDs are set for TLS
14699 connections.
14700
14701 * makefile.w32-in (OBJ2): Add gnutls.$(O).
14702 (LIBS): Link to USER_LIBS.
14703 ($(BLD)/gnutls.$(0)): New target.
14704
fa6996bc
EZ
147052011-04-24 Eli Zaretskii <eliz@gnu.org>
14706
eb35682e
EZ
14707 * xdisp.c (handle_single_display_spec): Rename the
14708 display_replaced_before_p argument into display_replaced_p, to
14709 make it consistent with the commentary. Fix typos in the
14710 commentary.
14711
e2ad650c
EZ
14712 * textprop.c (syms_of_textprop): Remove dead code.
14713 (copy_text_properties): Delete obsolete commentary about an
14714 interface that was deleted long ago. Fix typos in the description
14715 of arguments.
14716
1b2de274
EZ
14717 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
14718 to changes in oldXMenu/XMenu.h from 2011-04-16.
14719 <menu_help_message, prev_menu_help_message>: Constify.
14720 (IT_menu_make_room): menu->help_text is now `const char **';
14721 adjust.
14722
14723 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
14724 to changes in oldXMenu/XMenu.h from 2011-04-16.
14725 (struct XMenu): Declare `help_text' `const char **'.
14726
14727 * xfaces.c <Qunspecified>: Make extern again.
14728
14729 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 14730 required by POSIX.
1b2de274 14731
762b15be
EZ
14732 * doc.c (get_doc_string): Improve the format passed to `error'.
14733
14734 * doprnt.c (doprnt): Improve commentary.
14735
14736 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
14737
14738 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
14739 them with etags.
14740
f1052e5d
EZ
14741 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
14742 changes in globals.h immediately force recompilation.
762b15be
EZ
14743 (TAGS): Depend on $(CURDIR)/m/intel386.h and
14744 $(CURDIR)/s/ms-w32.h.
14745 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 14746
fa6996bc
EZ
14747 * character.c (Fchar_direction): Function deleted.
14748 (syms_of_character): Don't defsubr it.
14749 <char-direction-table>: Deleted.
14750
e6c3da20
EZ
147512011-04-23 Eli Zaretskii <eliz@gnu.org>
14752
14753 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
14754 * doprnt.c: Include limits.h.
14755 (SIZE_MAX): New macro.
04f2d78b
CB
14756 (doprnt): Return a size_t value. 2nd arg is now size_t.
14757 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
14758 Improve overflow protection. Support `l' modifier for integer
14759 conversions. Support %l conversion. Don't assume an EMACS_INT
14760 argument for integer conversions and for %c.
14761
14762 * lisp.h (doprnt): Restore prototype.
14763
14764 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
14765 $(SRC)/character.h.
14766
14767 * Makefile.in (base_obj): Add back doprnt.o.
14768
14769 * deps.mk (doprnt.o): Add back prerequisites.
14770 (callint.o): Depend on character.h.
14771
14772 * eval.c (internal_lisp_condition_case): Include the handler
14773 representation in the error message.
14774 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
14775 when breaking from the loop.
14776
14777 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
14778
14779 * callint.c (Fcall_interactively): When displaying error message
14780 about invalid control letter, pass the character's codepoint, not
14781 a pointer to its multibyte form. Improve display of the character
14782 in octal and display also its hex code.
14783
14784 * character.c (char_string): Use %x to display the (unsigned)
14785 codepoint of an invalid character, to avoid displaying a bogus
14786 negative value.
14787
14788 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
14789 `error', not SYMBOL_NAME itself.
14790
14791 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
14792 character arguments to `error'.
14793
14794 * charset.c (check_iso_charset_parameter): Fix incorrect argument
14795 to `error' in error message about FINAL_CHAR argument. Make sure
14796 FINAL_CHAR is a character, and use %c when it is passed as
14797 argument to `error'.
14798
4ffd0d6b 147992011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
14800
14801 * s/ms-w32.h (localtime): Redirect to sys_localtime.
14802
14803 * w32.c: Include <time.h>.
14804 (sys_localtime): New function.
14805
4ffd0d6b 148062011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
14807
14808 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
14809
4ffd0d6b 14810 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 14811
4ffd0d6b 148122011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 14813
4ffd0d6b
GM
14814 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
14815 zombies (Bug#8467).
aac0c6e3 14816
04c56954
EZ
148172011-04-19 Eli Zaretskii <eliz@gnu.org>
14818
14819 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
14820 gl_state.e_property when gl_state.object is Qt.
14821
14822 * insdel.c (make_gap_larger): Remove limitation of buffer size
14823 to <= INT_MAX.
14824
16a43933
CY
148252011-04-18 Chong Yidong <cyd@stupidchicken.com>
14826
14827 * xdisp.c (lookup_glyphless_char_display)
14828 (produce_glyphless_glyph): Handle cons cell entry in
14829 glyphless-char-display.
14830 (Vglyphless_char_display): Document it.
14831
14832 * term.c (produce_glyphless_glyph): Handle cons cell entry in
14833 glyphless-char-display.
14834
4581706e
CY
148352011-04-17 Chong Yidong <cyd@stupidchicken.com>
14836
14837 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
14838
14839 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
14840
14841 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
14842 definition for no-X builds.
14843
4887c6e2 148442011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 14845
fd35b6f9
PE
14846 Static checks with GCC 4.6.0 and non-default toolkits.
14847
5c1ccb01
PE
14848 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
14849
006c5daa
PE
14850 * process.c (keyboard_bit_set): Define only if SIGIO.
14851 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
14852 (send_process): Repair possible setjmp clobbering.
14853
efc736d3
PE
14854 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
14855
4e2fe2e6
PE
14856 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
14857
f97334a2
PE
14858 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
14859
4e75f29d
PE
14860 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
14861 Define only if needed.
14862
90efadd1
PE
14863 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
14864 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 14865 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 14866
3c647824
PE
14867 * dispextern.h (struct redisplay_interface): Rename param
14868 to avoid shadowing.
e264f262 14869 * termhooks.h (struct terminal): Likewise.
761383f4 14870 * xterm.c (xembed_send_message): Likewise.
3c647824 14871
b58c5c4a
PE
14872 * insdel.c (make_gap_smaller): Define only if
14873 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
14874
cad59032
PE
14875 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
14876 it.
14877
c339dc2e
PE
14878 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
14879 so that we aren't warned about unused symbols.
14880
91a3e27b
PE
14881 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
14882
399c71d3 14883 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 14884
8ffc96f5
PE
14885 * xfns.c (x_real_positions): Mark locals as initialized.
14886
eef9bc79
PE
14887 * xmenu.c (xmenu_show): Don't use uninitialized vars.
14888
098db9dd
PE
14889 * xterm.c: Fix problems found by static analysis with other toolkits.
14890 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
14891 (x_dispatch_event): Declare static if USE_GTK, and
14892 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 14893 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 14894 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
14895 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
14896 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 14897
eb18f6cc
PE
14898 * xmenu.c (menu_help_callback): Pointer type fixes.
14899 Use const pointers when pointing at readonly data. Avoid pointer
14900 signedness clashes.
14901 (FALSE): Remove unused macro.
14902 (update_frame_menubar): Remove unused decl.
14903
1fe72bf8
PE
14904 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
14905
60d9e1db
PE
14906 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
14907 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
14908 (single_menu_item): Rename local to avoid shadowing.
14909
39261c26
PE
14910 * keyboard.c (make_lispy_event): Remove unused local var.
14911
018c5e19
PE
14912 * frame.c, frame.h (x_get_resource_string): Bring this back, but
14913 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
14914
63d2b86e
PE
14915 * bitmaps: Change bitmaps from unsigned char back to the X11
14916 compatible char. Avoid the old compiler warnings about
14917 out-of-range initializers by using, for example, '\xab' rather
14918 than 0xab.
14919
aefd87e1
PE
14920 * xgselect.c (xgselect_initialize): Check vs interface
14921 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
14922
bf501fb9
PE
14923 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
14924
e9829fdf
PE
14925 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
14926 to read-only memory.
14927
1086c095
PE
14928 * fns.c (vector): Remove; this old hack is no longer needed.
14929
2baccd04 14930 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 14931 Remove unused var.
dde42981 14932 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 14933
72391843 14934 * xrdb.c (x_load_resources): Omit unused local.
3565b346 14935
436c16df 14936 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 14937 (x_window): Rename locals to avoid shadowing.
dc5ddd85 14938 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 14939
92bb796d 14940 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 14941 (x_term_init): Remove local to avoid shadowing.
92bb796d 14942
764430a3 14943 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
14944
14945 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
14946 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
14947
d1dfb56c
EZ
149482011-04-16 Eli Zaretskii <eliz@gnu.org>
14949
c4354cb4
EZ
14950 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
14951
d1dfb56c
EZ
14952 Fix regex.c, syntax.c and friends for buffers > 2GB.
14953 * syntax.h (struct gl_state_s): Declare character position members
14954 EMACS_INT.
14955
14956 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
14957
04f2d78b
CB
14958 * textprop.c (verify_interval_modification, interval_of):
14959 Declare arguments EMACS_INT.
d1dfb56c
EZ
14960
14961 * intervals.c (adjust_intervals_for_insertion): Declare arguments
14962 EMACS_INT.
14963
14964 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
14965
14966 * indent.c (Fvertical_motion): Local variable it_start is now
14967 EMACS_INT.
14968
14969 * regex.c (re_match, re_match_2, re_match_2_internal)
14970 (bcmp_translate, regcomp, regexec, print_double_string)
14971 (group_in_compile_stack, re_search, re_search_2, regex_compile)
14972 (re_compile_pattern, re_exec): Declare arguments and local
14973 variables `size_t' and `ssize_t' and return values `regoff_t', as
14974 appropriate.
14975 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
14976 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
14977 <compile_stack_type>: `size' and `avail' are now `size_t'.
14978
14979 * regex.h <regoff_t>: Use ssize_t, not int.
14980 (re_search, re_search_2, re_match, re_match_2): Arguments that
14981 specify buffer/string position and length are now ssize_t and
14982 size_t. Return type is regoff_t.
14983
613052cd
BK
149842011-04-16 Ben Key <bkey76@gmail.com>
14985
14986 * nsfont.m: Fixed bugs in ns_get_family and
14987 ns_descriptor_to_entity that were caused by using free to
14988 deallocate memory blocks that were allocated by xmalloc (via
14989 xstrdup). This caused Emacs to crash when compiled with
14990 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
14991 --enable-checking=xmallocoverrun). xfree is now used to
14992 deallocate these memory blocks.
14993
4170f62f 149942011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 14995
71b41406
PE
14996 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
14997
9587a89d
PE
14998 emacs_write: Accept and return EMACS_INT for sizes.
14999 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
15000 et seq.
15001 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
15002 Accept and return EMACS_INT.
15003 (emacs_gnutls_write): Return the number of bytes written on
15004 partial writes.
15005 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
15006 (emacs_read, emacs_write): Remove check for negative size, as the
15007 Emacs source code has been audited now.
9587a89d
PE
15008 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
15009 (emacs_read, emacs_write): Use it.
273a5f82
PE
15010 * process.c (send_process): Adjust to the new signatures of
15011 emacs_write and emacs_gnutls_write. Do not attempt to store
15012 a byte offset into an 'int'; it might overflow.
9587a89d 15013 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 15014
3e047f51
PE
15015 * sound.c: Don't assume sizes fit in 'int'.
15016 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 15017 Return EMACS_INT, not int.
3e047f51 15018 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
15019 Accept EMACS_INT, not int.
15020 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
15021 record read return values.
15022
cc39a9db
BK
150232011-04-15 Ben Key <bkey76@gmail.com>
15024
c9d0ec6d
JB
15025 * keyboard.c (Qundefined): Don't declare static since it is used
15026 in nsfns.m.
15027 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
15028 static since they are used in nsfont.m.
cc39a9db 15029
6c60eb9f
SM
150302011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
15031
15032 * process.c (Qprocessp): Don't declare static.
15033 * lisp.h (Qprocessp): Declare again.
15034
7990b61a
JB
150352011-04-15 Juanma Barranquero <lekktu@gmail.com>
15036
15037 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
15038
5d4cb038
PE
150392011-04-14 Paul Eggert <eggert@cs.ucla.edu>
15040
8bd7b830 15041 Improve C-level modularity by making more things 'static'.
cd64ea1d 15042
e3b27b31
PE
15043 Don't publish debugger-only interfaces to other modules.
15044 * lisp.h (safe_debug_print, debug_output_compilation_hack):
15045 (verify_bytepos, count_markers): Move decls to the only modules
15046 that need them.
15047 * region-cache.h (pp_cache): Likewise.
15048 * window.h (check_all_windows): Likewise.
15049 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
15050
5d4cb038
PE
15051 * sysdep.c (croak): Now static, if
15052 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
15053 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
15054
15055 * alloc.c (refill_memory_reserve): Now static if
15056 !defined REL_ALLOC || defined SYSTEM_MALLOC.
15057 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 15058
e87b6180
PE
15059 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
15060 Define only if USE_LUCID.
15061
ac64929e
PE
15062 * xrdb.c (x_customization_string, x_rm_string): Now static.
15063
6f37259d
PE
15064 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
15065 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
15066
1683e3ab
PE
15067 * xdisp.c (draw_row_with_mouse_face): Now static.
15068 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
15069
de9c2632
PE
15070 * window.h (check_all_windows): Mark externally visible.
15071
2b96acb7
PE
15072 * window.c (window_deletion_count): Now static.
15073
15074 * undo.c: Make symbols static if they're not exported.
15075 (last_undo_buffer, last_boundary_position, pending_boundary):
15076 Now static.
15077
50436f33
PE
15078 * textprop.c (interval_insert_behind_hooks): Now static.
15079 (interval_insert_in_front_hooks): Likewise.
15080
64520e5c
PE
15081 * term.c: Make symbols static if they're not exported.
15082 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
15083 (max_frame_lines, tty_set_terminal_modes):
15084 (tty_reset_terminal_modes, tty_turn_off_highlight):
15085 (get_tty_terminal): Now static.
15086 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
15087 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 15088 HAVE_WINDOW_SYSTEM.
64520e5c
PE
15089 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
15090 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
15091
1fa53021
PE
15092 * sysdep.c: Make symbols static if they're not exported.
15093 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
15094 Now static.
15095 (sigprocmask_set, full_mask): Remove; unused.
15096 (wait_debugging): Mark as visible.
15097 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
15098 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
15099
d4b43b22
PE
15100 * syntax.c (syntax_temp): Define only if !__GNUC__.
15101
b7c513d0
PE
15102 * sound.c (current_sound_device, current_sound): Now static.
15103
989b29ad
PE
15104 * search.c (searchbufs, searchbuf_head): Now static.
15105
13a55a78
PE
15106 * scroll.c (scroll_cost): Remove; unused.
15107 * dispextern.h (scroll_cost): Remove decl.
15108
de68a1fc
PE
15109 * region-cache.h (pp_cache): Mark as externally visible.
15110
40ccffa6
PE
15111 * process.c: Make symbols static if they're not exported.
15112 (process_tick, update_tick, create_process, chan_process):
15113 (Vprocess_alist, proc_buffered_char, datagram_access):
15114 (fd_callback_data, send_process_frame, process_sent_to): Now static.
15115 (deactivate_process): Mark defn as static, as well as decl.
15116 * lisp.h (create_process): Remove decl.
15117 * process.h (chan_process, Vprocess_alist): Remove decls.
15118
ad64fc97
PE
15119 * print.c: Make symbols static if they're not exported.
15120 (print_depth, new_backquote_output, being_printed, print_buffer):
15121 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
15122 (print_interval, print_number_index, initial_stderr_stream):
15123 Now static.
15124 * lisp.h (Fprinc): Remove decl.
15125 (debug_output_compilation_hack): Mark as externally visible.
15126
adddb265
PE
15127 * sysdep.c (croak): Move decl from here to syssignal.h.
15128 * syssignal.h (croak): Put it here, so the API can be checked when
15129 'croak' is called from dissociate_if_controlling_tty.
15130
1717ede2
PE
15131 * minibuf.c: Make symbols static if they're not exported.
15132 (minibuf_save_list, choose_minibuf_frame): Now static.
15133 * lisp.h (choose_minibuf_frame): Remove decl.
15134
fa5fb2bc
PE
15135 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
15136
1e3890d1
PE
15137 * lread.c: Make symbols static if they're not exported.
15138 (read_objects, initial_obarray, oblookup_last_bucket_number):
15139 Now static.
15140 (make_symbol): Remove; unused.
15141 * lisp.h (initial_obarray, make_symbol): Remove decls.
15142
8a1414fa
PE
15143 * keyboard.c: Make symbols static if they're not exported.
15144 (single_kboard, recent_keys_index, total_keys, recent_keys):
15145 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
15146 (this_single_command_key_start, echoing, last_auto_save):
15147 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
15148 (command_loop, echo_now, keyboard_init_hook, help_char_p):
15149 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
15150 (Vlispy_mouse_stem, double_click_count):
15151 Now static.
15152 (force_auto_save_soon): Define only if SIGDANGER.
15153 (ignore_mouse_drag_p): Now static if
15154 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
15155 (print_help): Remove; unused.
15156 (stop_character, last_timer_event): Mark as externally visible.
15157 * keyboard.h (ignore_mouse_drag_p): Declare only if
15158 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
15159 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
15160 * lisp.h (echoing): Remove decl.
15161 (force_auto_save_soon): Declare only if SIGDANGER.
15162 * xdisp.c (redisplay_window): Simplify code, to make it more
15163 obvious that ignore_mouse_drag_p is not accessed if !defined
15164 USE_GTK && !defined HAVE_NS.
15165
93ea6e8f
PE
15166 * intervals.c: Make symbols static if they're not exported.
15167 (merge_properties_sticky, merge_interval_right, delete_interval):
15168 Now static.
15169 * intervals.h (merge_interval_right, delete_interval): Remove decls.
15170
77382fcc
PE
15171 * insdel.c: Make symbols static if they're not exported.
15172 However, leave prepare_to_modify_buffer alone. It's never
15173 called from outside this function, but that appears to be a bug.
15174 (combine_after_change_list, combine_after_change_buffer):
4889fc82 15175 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
15176 (adjust_after_replace_noundo): Remove; unused.
15177 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 15178 (signal_before_change): Remove decls.
77382fcc 15179
9306c32e
PE
15180 * indent.c (val_compute_motion, val_vmotion): Now static.
15181
cd44d2eb
PE
15182 * image.c: Make symbols static if they're not exported.
15183 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
15184 if USE_GTK.
15185 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
15186 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
15187
ad9a7a06
PE
15188 * fringe.c (standard_bitmaps): Now static.
15189 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
15190
81626931
PE
15191 * frame.c: Make symbols static if they're not exported.
15192 (x_report_frame_params, make_terminal_frame): Now static.
15193 (get_frame_param): Now static, unless HAVE_NS.
15194 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
15195 (x_get_resource_string): Remove; not used.
15196 * frame.h (make_terminal_frame, x_report_frame_params):
15197 (x_get_resource_string); Remove decls.
15198 (x_fullscreen_adjust): Declare only if WINDOWSNT.
15199 * lisp.h (get_frame_param): Declare only if HAVE_NS.
15200
239f9db9
PE
15201 * font.c, fontset.c: Make symbols static if they're not exported.
15202 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
15203 (FACE_SUITABLE_FOR_CHAR_P): Use it.
15204 * font.c (font_close_object): Now static.
15205 * font.h (font_close_object): Remove.
15206 * fontset.c (FONTSET_OBJLIST): Remove.
15207 (free_realized_fontset) #if-0 the body, which does nothing.
15208 (face_suitable_for_char_p): #if-0, as it's never called.
15209 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
15210 * xfaces.c (face_at_string_position):
15211 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
15212 since 0 is always ASCII.
15213
dfcf3579
PE
15214 * fns.c (weak_hash_tables): Now static.
15215
5045092b
PE
15216 * fileio.c: Make symbols static if they're not exported.
15217 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
15218 (Vwrite_region_annotation_buffers): Now static.
15219
57a96f5c
PE
15220 * eval.c: Make symbols static if they're not exported.
15221 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
15222 * lisp.h (backtrace_list): Remove decl.
15223
35f08c38
PE
15224 * emacs.c: Make symbols static if they're not exported.
15225 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
15226 (fatal_error_code, fatal_error_signal_hook, standard_args):
15227 Now static.
15228 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
15229 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
15230 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
15231 * lisp.h (fatal_error_signal_hook): Remove decl.
15232 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
15233
f44bd759
PE
15234 * editfns.c: Move a (normally-unused) function to its only use.
15235 * editfns.c, lisp.h (get_operating_system_release): Remove.
15236 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
15237 worth the hassle of breaking this out.
15238
b532497d
PE
15239 * xterm.c: Make symbols static if they're not exported.
15240 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
15241 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
15242 (x_destroy_window, x_delete_display):
15243 Now static.
15244 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
15245 (x_mouse_leave): Remove; unused.
15246 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
15247 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
15248 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
15249 Remove decls.
15250 (x_mouse_leave): Declare only if WINDOWSNT.
15251 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
15252 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
15253 USE_X_TOOLKIT.
15254
1675728f
PE
15255 * ftxfont.c: Make symbols static if they're not exported.
15256 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
15257 HAVE_FREETYPE.
15258 * font.h (ftxfont_driver): Likewise.
15259
e4cebfca
PE
15260 * xfns.c: Make symbols static if they're not exported.
15261 (x_last_font_name, x_display_info_for_name):
15262 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
15263 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
15264 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
15265 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
15266 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
15267 (last_show_tip_args): Now static.
15268 (xic_defaut_fontset, xic_create_fontsetname): Define only if
15269 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
15270 (x_screen_planes): Remove; unused.
15271 * dispextern.h (x_screen_planes): Remove decl.
15272
5bf46f05
PE
15273 * dispnew.c: Make symbols static if they're not exported.
15274 * dispextern.h (redraw_garbaged_frames, scrolling):
15275 (increment_row_positions): Remove.
15276 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
15277 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
15278 Now static.
15279 (redraw_garbaged_frames): Remove; unused.
15280
435f4c28
PE
15281 * xfaces.c: Make symbols static if they're not exported.
15282 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
15283 Remove decls.
15284 * xterm.h (defined_color): Remove decls.
15285 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
15286 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
15287 (menu_face_changed_default, defined_color, free_realized_face):
15288 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
15289 (ascii_face_of_lisp_face): Remove; unused.
15290
8524aef3
PE
15291 * xdisp.c: Make symbols static if they're not exported.
15292 * dispextern.h (scratch_glyph_row, window_box_edges):
15293 (glyph_to_pixel_coords, set_cursor_from_row):
15294 (get_next_display_element, set_iterator_to_next):
15295 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
15296 (show_mouse_face): Remove decls
15297 * frame.h (message_buf_print): Likewise.
15298 * lisp.h (pop_message, set_message, check_point_in_composition):
15299 Likewise.
15300 * xterm.h (set_vertical_scroll_bar): Likewise.
15301 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
15302 (message_buf_print, scratch_glyph_row, displayed_buffer):
15303 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
15304 (get_next_display_element, show_mouse_face, window_box_edges):
15305 (frame_to_window_pixel_xy, check_point_in_composition):
15306 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
15307 (glyph_to_pixel_coords): Remove; unused.
15308
16390cd2
PE
15309 * dired.c (file_name_completion): Now static.
15310
15311 * dbusbind.c (xd_in_read_queued_messages): Now static.
15312
a25f4dfa
PE
15313 * lisp.h (circular_list_error, FOREACH): Remove; unused.
15314 * data.c (circular_list_error): Remove.
15315
14a9c8df
PE
15316 * commands.h (last_point_position, last_point_position_buffer):
15317 (last_point_position_window): Remove decls.
15318 * keyboard.c: Make these variables static.
15319
04f2d78b
CB
15320 * coding.h (coding, code_convert_region, encode_coding_gap):
15321 Remove decls.
74ab6df5
PE
15322 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
15323 (iso_code_class, detect_coding, code_convert_region): Now static.
15324 (encode_coding_gap): Remove; unused.
15325
38dfbee1
PE
15326 * chartab.c (chartab_chars, chartab_bits): Now static.
15327
a2cb4e63
PE
15328 * charset.h (charset_iso_8859_1): Remove decl.
15329 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
15330 Now static.
15331
127198fd
PE
15332 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
15333 * ccl.c (Vccl_program_table): Now static.
15334 (check_ccl_update): Remove; unused.
15335
d85b608f
PE
15336 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
15337 * category.h: ... from here.
15338 * category.c (check_category_table, set_category_set): Now static.
15339
31cd66f3
PE
15340 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
15341 * lisp.h: Remove these decls.
15342
c358e587
PE
15343 * buffer.c (buffer_count): Remove unused var.
15344
e78aecca
PE
15345 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
15346 so that it's not optimized away.
15347 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
15348 * dispextern.h (bidi_dump_cached_states): Remove, since it's
15349 exported only to the debugger.
15350
e192d7d3 15351 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 15352 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 15353
92470028
PE
15354 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
15355 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
15356 was inaccessible from Lisp.
15357 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
15358 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
15359
244ed907
PE
15360 alloc.c: Import and export fewer symbols, and remove unused items.
15361 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
15362 is defined.
15363 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
15364 it's not optimized away by whole-program optimization.
15365 (message_enable_multibyte, free_misc): Remove.
15366 (catchlist, handlerlist, mark_backtrace):
15367 Declare only if BYTE_MARK_STACK.
15368 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
15369 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
15370 (message_enable_multibyte): Remove decl.
15371 (free_misc, interval_free_list, float_block, float_block_index):
15372 (n_float_blocks, float_free_list, cons_block, cons_block_index):
15373 (cons_free_list, last_marked_index):
15374 Now static.
15375 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
15376 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
15377 (mark_backtrace): Define only if BYTE_MARK_STACK.
15378 * xdisp.c (message_enable_multibyte): Now static.
15379
61c2b50e 15380 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
15381 This makes it easier for human readers (and static analyzers)
15382 to see whether these variables are used from other modules.
15383 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
15384 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
15385 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
15386 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
15387 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
15388 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
15389 * xmenu.c, xselect.c:
15390 Declare Q* vars static if they are not used in other modules.
15391 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
15392 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
15393 Remove decls of unexported vars.
15394 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
15395
95c82688
PE
15396 * lisp.h (DEFINE_FUNC): Make sname 'static'.
15397
16a97296
PE
15398 Make Emacs functions such as Fatom 'static' by default.
15399 This makes it easier for human readers (and static analyzers)
15400 to see whether these functions can be called from other modules.
15401 DEFUN now defines a static function. To make the function external
15402 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
15403 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
15404 (Finit_image_library):
16a97296
PE
15405 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
15406 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
15407 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
15408 Remove decls, since these functions are now static.
15409 (Funintern, Fget_internal_run_time): New decls, since these functions
15410 were already external.
95c82688 15411
16a97296
PE
15412 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
15413 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
15414 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
15415 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
15416 * keyboard.c, keymap.c, lread.c:
15417 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
15418 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
15419 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
15420 Mark functions with DEFUE instead of DEFUN,
15421 if they are used in other modules.
15422 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
15423 decls for now-static functions.
15424 * buffer.h (Fdelete_overlay): Remove decl.
15425 * callproc.c (Fgetenv_internal): Mark as internal.
15426 * composite.c (Fremove_list_of_text_properties): Remove decl.
15427 (Fcomposition_get_gstring): New forward static decl.
15428 * composite.h (Fcomposite_get_gstring): Remove decl.
15429 * dired.c (Ffile_attributes): New forward static decl.
15430 * doc.c (Fdocumntation_property): New forward static decl.
15431 * eval.c (Ffetch_bytecode): New forward static decl.
15432 (Funintern): Remove extern decl; now in .h file where it belongs.
15433 * fileio.c (Fmake_symbolic_link): New forward static decl.
15434 * image.c (Finit_image_library): New forward static decl.
15435 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
15436 * intervals.h (Fprevious_property_change):
15437 (Fremove_list_of_text_properties): Remove decls.
15438 * keyboard.c (Fthis_command_keys): Remove decl.
15439 (Fcommand_execute): New forward static decl.
15440 * keymap.c (Flookup_key): New forward static decl.
15441 (Fcopy_keymap): Now static.
15442 * keymap.h (Flookup_key): Remove decl.
15443 * process.c (Fget_process): New forward static decl.
15444 (Fprocess_datagram_address): Mark as internal.
15445 * syntax.c (Fsyntax_table_p): New forward static decl.
15446 (skip_chars): Remove duplicate decl.
15447 * textprop.c (Fprevious_property_change): New forward static decl.
15448 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
15449 Now internal.
15450 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
15451 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
15452
785bbd42
PE
15453 * editfns.c (Fformat): Remove unreachable code.
15454
8b913b57
AS
154552011-04-14 Andreas Schwab <schwab@linux-m68k.org>
15456
15457 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
15458 change. (Bug#8496)
15459
a6744a35
EZ
154602011-04-13 Eli Zaretskii <eliz@gnu.org>
15461
15462 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
15463 when at ZV. (Bug#8487)
15464
e7974947
AS
154652011-04-12 Andreas Schwab <schwab@linux-m68k.org>
15466
baad03f0
AS
15467 * charset.c (Fclear_charset_maps): Use xfree instead of free.
15468 (Bug#8437)
15469 * keyboard.c (parse_tool_bar_item): Likewise.
15470 * sound.c (sound_cleanup, alsa_close): Likewise.
15471 * termcap.c (tgetent): Likewise.
15472 * xfns.c (x_default_font_parameter): Likewise.
15473 * xsettings.c (read_and_apply_settings): Likewise.
15474
e7974947
AS
15475 * alloc.c (overrun_check_malloc, overrun_check_realloc)
15476 (overrun_check_free): Protoize.
15477
28272684
PE
154782011-04-12 Paul Eggert <eggert@cs.ucla.edu>
15479
15480 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
15481 since callers should never pass a negative size.
15482 Change the signature to match that of plain 'read' and 'write'; see
15483 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
15484 * lisp.h: Update prototypes of emacs_write and emacs_read.
15485
11997c76
EZ
154862011-04-11 Eli Zaretskii <eliz@gnu.org>
15487
15488 * xdisp.c (redisplay_window): Don't try to determine the character
15489 position of the scroll margin if the window start point w->startp
e896f03c 15490 is outside the buffer's accessible region. (Bug#8468)
11997c76 15491
8a2cbd72
EZ
154922011-04-10 Eli Zaretskii <eliz@gnu.org>
15493
15494 Fix write-region and its subroutines for buffers > 2GB.
15495 * fileio.c (a_write, e_write): Modify declaration of arguments and
15496 local variables to support buffers larger than 2GB.
15497 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
15498
15499 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
15500 argument, local variables, and return value.
15501
15502 * lisp.h: Update prototypes of emacs_write and emacs_read.
15503
15504 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
15505
4073e537 155062011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 15507
1ebfdcb6
PE
15508 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
15509
b2ded58d
PE
15510 Fix more problems found by GCC 4.6.0's static checks.
15511
7d66342c
PE
15512 * xdisp.c (vmessage): Use a better test for character truncation.
15513
bbf47d44
PE
15514 * charset.c (load_charset_map): <, not <=, for optimization,
15515 and to avoid potential problems with integer overflow.
9248994d 15516 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 15517 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 15518 * editfns.c (Fformat): Likewise.
1e69125e 15519 * syntax.c (skip_chars): Likewise.
3befa583 15520
e3019616
PE
15521 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
15522 This also lets GCC 4.6.0 generate slightly better loop code.
15523
becfa255
PE
15524 * callint.c (Fcall_interactively): <, not <=, for optimization.
15525 (Fcall_interactively): Count the number of arguments produced,
15526 not the number of arguments given. This is simpler and lets GCC
15527 4.6.0 generate slightly better code.
15528
dae0cd48
PE
15529 * ftfont.c: Distingish more carefully between FcChar8 and char.
15530 The previous code passed unsigned char * to a functions like
15531 strlen and xstrcasecmp that expect char *, which does not
15532 conform to the C standard.
15533 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
15534 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
15535 char * when the C standard requires it.
15536
76032d70
PE
15537 * keyboard.c (read_char): Remove unused var.
15538
eb3f1cc8
PE
15539 * eval.c: Port to Windows vsnprintf (Bug#8435).
15540 Include <limits.h>.
15541 (SIZE_MAX): Define if the headers do not.
15542 (verror): Do not give up if vsnprintf returns a negative count.
15543 Instead, grow the buffer. This ports to Windows vsnprintf, which
15544 does not conform to C99. Problem reported by Eli Zaretskii.
15545 Also, simplify the allocation scheme, by avoiding the need for
15546 calling realloc, and removing the ALLOCATED variable.
15547
70476b54
PE
15548 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
15549
12020a9e
PE
15550 Remove invocations of doprnt, as Emacs now uses vsnprintf.
15551 But keep the doprint source code for now, as we might revamp it
15552 and use it again (Bug#8435).
ea6c7ae6
PE
15553 * lisp.h (doprnt): Remove.
15554 * Makefile.in (base_obj): Remove doprnt.o.
15555 * deps.mk (doprnt.o): Remove.
15556
5fdb398c
PE
15557 error: Print 32- and 64-bit integers portably (Bug#8435).
15558 Without this change, on typical 64-bit hosts error ("...%d...", N)
15559 was used to print both 32- and 64-bit integers N, which relied on
15560 undefined behavior.
61bdb816 15561 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
15562 * lisp.h (error, verror): Mark as printf-like functions.
15563 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
15564 Report overflow in size calculations when allocating printf buffer.
15565 Do not truncate output string at its first null byte.
15566 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
15567 Truncate the output at a character boundary, since vsnprintf does not
15568 do that.
15569 * charset.c (check_iso_charset_parameter): Convert internal
15570 character to string before calling 'error', since %c now has the
15571 printf meaning.
15572 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
15573 overflow when computing char to be passed to 'error'. Do not
15574 pass Lisp_Object to 'error'; pass the integer instead.
15575 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
15576 formatted with plain %d.
15577
b189fa66
PE
15578 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
15579
bff87ef0
PE
15580 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
15581
7e2cac20
PE
15582 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
15583
ce4d90b5
PE
15584 * xterm.c (x_catch_errors): Remove duplicate declaration.
15585
266c9547
PE
15586 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
15587
79c49ad2
PE
15588 * xdisp.c, lisp.h (message_nolog): Remove; unused.
15589
368f4090
JM
155902011-04-10 Jim Meyering <meyering@redhat.com>
15591
15592 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
15593 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
15594 return ssize_t not "int", and use size_t as the buffer length.
15595 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
15596 * gnutls.h: Update declarations.
15597 * process.c (read_process_output): Use ssize_t, to match.
15598 (send_process): Likewise.
15599
a32d4040
CY
156002011-04-09 Chong Yidong <cyd@stupidchicken.com>
15601
15602 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
15603
8546720e 156042011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 15605
04f2d78b
CB
15606 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
15607 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 15608
8546720e
GM
15609 * xterm.c (handle_one_xevent):
15610 * xmenu.c (create_and_show_popup_menu):
15611 * xselect.c (x_decline_selection_request)
15612 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 15613
0a2f5c1a 156142011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
15615
15616 Fix some uses of `int' instead of EMACS_INT.
15617 * search.c (string_match_1, fast_string_match)
15618 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
15619 (scan_buffer, find_next_newline_no_quit)
15620 (find_before_next_newline, search_command, Freplace_match)
15621 (Fmatch_data): Make some `int' variables be EMACS_INT.
15622
15623 * xdisp.c (display_count_lines): 3rd argument and return value now
15624 EMACS_INT. All callers changed.
15625 (pint2hrstr): Last argument is now EMACS_INT.
15626
15627 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
15628 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
15629 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
15630 (decode_coding_utf_16, decode_coding_emacs_mule)
15631 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
15632 (decode_coding_ccl, decode_coding_charset)
15633 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
15634 (decode_coding_iso_2022, decode_coding_emacs_mule)
15635 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
15636 <char_offset, last_offset>: Declare EMACS_INT.
15637 (encode_coding_utf_8, encode_coding_utf_16)
15638 (encode_coding_emacs_mule, encode_invocation_designation)
15639 (encode_designation_at_bol, encode_coding_iso_2022)
15640 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
15641 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
15642 Declare EMACS_INT.
15643 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
15644 (encode_invocation_designation): Last argument P_NCHARS is now
15645 EMACS_INT.
15646 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
15647 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
15648
15649 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
15650 All users changed.
15651
15652 * ccl.c (Fccl_execute_on_string): Declare some variables
15653 EMACS_INT.
15654
8546720e 156552011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
15656
15657 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
15658
4e19a977
CS
156592011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
15660
15661 * process.c (Fformat_network_address): Doc fix.
15662
87302331
R
156632011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
15664
ee7683eb 15665 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 15666
cbb59342
CY
156672011-04-08 Chong Yidong <cyd@stupidchicken.com>
15668
15669 * keyboard.c (read_char): Call Lisp function help-form-show,
15670 instead of using internal_with_output_to_temp_buffer.
15671 (Qhelp_form_show): New var.
e0d38eeb 15672 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
15673
15674 * print.c (internal_with_output_to_temp_buffer): Function deleted.
15675
15676 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
15677
e67a13ab
CY
156782011-04-06 Chong Yidong <cyd@stupidchicken.com>
15679
04f2d78b
CB
15680 * process.c (Flist_processes): Remove to Lisp.
15681 (list_processes_1): Delete.
e67a13ab 15682
973f782d
EZ
156832011-04-06 Eli Zaretskii <eliz@gnu.org>
15684
7c106b1e
EZ
15685 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
15686
973f782d
EZ
15687 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
15688
41cf7d1a 156892011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 15690
ca23cc88
PE
15691 Fix more problems found by GCC 4.6.0's static checks.
15692
f390e2d5
PE
15693 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
15694
42eea0d0
PE
15695 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
15696
b69769da 15697 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 15698
f9541e84
PE
15699 * xdisp.c (vmessage): Mark as a printf-like function.
15700
13841b55
PE
15701 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
15702
c136c10f
PE
15703 * sound.c (sound_warning): Don't crash if arg contains a printf format.
15704
5e2d4a30
PE
15705 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
15706 printf-like functions.
15707 (tiff_load): Add casts to remove these marks before passing them
15708 to system-supplied API.
15709
583f48b9
PE
15710 * eval.c (Fsignal): Remove excess argument to 'fatal'.
15711
b25d760e
PE
15712 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
15713 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
15714 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
15715 directly, rather than having caller test rule sign. This avoids
15716 some unnecessary tests.
15717 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
15718 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
15719 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 15720
bc7b6697 15721 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 15722 (xfont_open): Avoid unnecessary tests.
bc7b6697 15723
27ccc379
PE
15724 * composite.c (composition_gstring_put_cache): Use unsigned integer.
15725
dcd5c89a
PE
15726 * composite.h, composite.c (composition_gstring_put_cache):
15727 Use EMACS_INT, not int, for length.
15728
b13a45c6
PE
15729 * composite.h (COMPOSITION_DECODE_REFS): New macro,
15730 breaking out part of COMPOSITION_DECODE_RULE.
15731 (COMPOSITION_DECODE_RULE): Use it.
15732 * composite.c (get_composition_id): Remove unused local vars,
15733 by using the new macro.
15734
1e792e4d
PE
15735 * textprop.c (set_text_properties_1): Change while to do-while,
15736 since the condition is always true at first.
15737
dc6c6455 15738 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
15739 (interval_deletion_adjustment): Return unsigned value.
15740 All uses changed.
dc6c6455 15741
aba7731a
PE
15742 * process.c (list_processes_1, create_pty, read_process_output):
15743 (exec_sentinel): Remove vars that were set but not used.
afd4052b 15744 (create_pty): Remove unnecessary "volatile"s.
bc57d757 15745 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 15746 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 15747 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 15748
fdfc4bf3
PE
15749 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
15750
fca8fe46 15751 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 15752 (update_syntax_table): Use unsigned instead of int.
fca8fe46 15753
06a0259a 15754 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 15755 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 15756 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 15757
e7b9e80f
PE
15758 * print.c (print_error_message): Avoid int overflow.
15759
56201685
PE
15760 * font.c (font_list_entities): Redo for clarity,
15761 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
15762
78834453 15763 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 15764 (font_score): Avoid potential overflow in diff calculation.
78834453 15765
0bc0b309 15766 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 15767 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 15768
e610eaca
PE
15769 * eval.c (funcall_lambda): Rename local to avoid shadowing.
15770
b895abce
PE
15771 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
15772 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
15773 can always succeed if overflow has undefined behavior.
15774
1f1d9321 15775 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 15776 (wordify): Omit three unnecessary tests.
1f1d9321 15777
c59478bc
PE
15778 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
15779 All callers changed. This avoids the need for an unused var.
15780
79b73827
PE
15781 * casefiddle.c (casify_region): Remove var that is set but not used.
15782
a4db5dfe
PE
15783 * dired.c (file_name_completion): Remove var that is set but not used.
15784
43aae36e
PE
15785 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
15786
2a47c44d 15787 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 15788 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 15789
a37c69bf
PE
15790 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
15791 Check for integer overflow on size calculations.
15792
328ab8e7
PE
15793 * buffer.c (Fprevious_overlay_change): Remove var that is set
15794 but not used.
15795
e5a2a5cb
PE
15796 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
15797 Remove vars that are set but not used.
8d84a6eb 15798 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 15799 (timer_check_2): Mark vars as initialized.
e5a2a5cb 15800
a60e5f68
PE
15801 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
15802
f661cb61 15803 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 15804 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 15805
f0397f5a
PE
15806 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
15807 that are set but not used.
15808
8664db06 15809 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 15810 if XCreateBitmapFromData fails (Bug#8410).
8664db06 15811
6abdaa4a
PE
15812 * xselect.c (x_get_local_selection, x_handle_property_notify):
15813 Remove vars that are set but not used.
15814
0ce7538d 15815 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 15816 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 15817
9ae848fc
PE
15818 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
15819 Remove var that is set but not used.
0b918413
PE
15820 (scroll_bar_windows_size): Now size_t, not int.
15821 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
15822 Check for overflow.
9ae848fc 15823
a5a62657
PE
15824 * xfaces.c (realize_named_face): Remove vars that are set but not used.
15825 (map_tty_color) [!defined MSDOS]: Likewise.
15826
5c5cdd39
PE
15827 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
15828
66ebf983
PE
15829 * coding.c: Remove vars that are set but not used.
15830 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
15831 All callers changed.
15832 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
15833 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
15834 (decode_coding_charset): Remove vars that are set but not used.
15835
1be4d761
PE
15836 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
15837 that is set but not used.
15838
47553fa8
PE
15839 * print.c (print_object): Remove var that is set but not used.
15840
1f7196bf 15841 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
15842 The gnulib version avoids calling malloc in the usual case,
15843 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
15844 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
15845 * filelock.c (current_lock_owner): Likewise.
15846 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
15847 * sysdep.c: Include allocator.h, careadlinkat.h.
15848 (emacs_no_realloc_allocator): New static constant.
15849 (emacs_readlink): New function.
fdb61804
PE
15850 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
15851 ../lib/careadlinkat.h.
d1fdcab7 15852
f84c17c7
SM
158532011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
15854
15855 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
15856 first non-nil return value).
15857
ef3862ad
JD
158582011-04-03 Jan Djärv <jan.h.d@swipnet.se>
15859
15860 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
15861 if not defined (Bug#8403).
15862
376a7006
JB
158632011-04-02 Juanma Barranquero <lekktu@gmail.com>
15864
15865 * xdisp.c (display_count_lines): Remove parameter `start',
15866 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
15867 (get_char_face_and_encoding): Remove parameter `multibyte_p',
15868 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
15869 (fill_stretch_glyph_string): Remove parameters `row' and `area',
15870 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
15871 and thereabouts. All callers changed.
15872 (get_per_char_metric): Remove parameter `f', unused since
15873 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
15874
6ca3801d
JM
158752011-04-02 Jim Meyering <meyering@redhat.com>
15876
15877 do not dereference NULL upon failed strdup
15878 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
15879 (ns_get_family): Likewise.
15880
d8e2b5ba
JB
158812011-04-02 Juanma Barranquero <lekktu@gmail.com>
15882
15883 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
15884
8c74fcbd
JD
158852011-04-02 Jan Djärv <jan.h.d@swipnet.se>
15886
15887 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
15888 later (Bug#8403).
15889
7200d79c
SM
158902011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
15891
03408648 15892 Add lexical binding.
7200d79c 15893
03408648
SM
15894 * window.c (Ftemp_output_buffer_show): New fun.
15895 (Fsave_window_excursion):
15896 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
15897
15898 * lread.c (lisp_file_lexically_bound_p): New function.
15899 (Fload): Bind Qlexical_binding.
15900 (readevalloop): Remove `evalfun' arg.
15901 Bind Qinternal_interpreter_environment.
15902 (Feval_buffer): Bind Qlexical_binding.
15903 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
15904 Mark as dynamic.
15905 (syms_of_lread): Declare `lexical-binding'.
15906
15907 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
15908
15909 * keyboard.c (eval_dyn): New fun.
15910 (menu_item_eval_property): Use it.
ca105506
SM
15911
15912 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 15913
03408648
SM
15914 * fns.c (concat, mapcar1): Accept byte-code-functions.
15915
15916 * eval.c (Fsetq): Handle lexical vars.
15917 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
15918 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
15919 (FletX, Flet): Obey lexical binding.
15920 (Fcommandp): Handle closures.
15921 (Feval): New `lexical' arg.
15922 (eval_sub): New function extracted from Feval. Use it almost
15923 everywhere where Feval was used. Look up vars in lexical env.
15924 Handle closures.
15925 (Ffunctionp): Move from subr.el.
15926 (Ffuncall): Handle closures.
15927 (apply_lambda): Remove `eval_flags'.
15928 (funcall_lambda): Handle closures and new byte-code-functions.
15929 (Fspecial_variable_p): New function.
15930 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
15931 but without exporting it to Lisp.
23aba0ea 15932
23aba0ea 15933 * doc.c (Fdocumentation, store_function_docstring):
03408648 15934 * data.c (Finteractive_form): Handle closures.
23aba0ea 15935
03408648
SM
15936 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
15937 interactive spec.
ba83908c 15938
04f2d78b
CB
15939 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
15940 New byte-codes.
03408648
SM
15941 (exec_byte_code): New function extracted from Fbyte_code to handle new
15942 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 15943
03408648 15944 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 15945
03408648 15946 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 15947
e2abce01
JB
159482011-03-31 Juanma Barranquero <lekktu@gmail.com>
15949
15950 * xdisp.c (redisplay_internal): Fix prototype.
15951
63696a73 159522011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 15953
63696a73 15954 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
15955 (try_scrolling): Use it when setting scroll_limit.
15956 Limit scrolling to 100 screen lines.
63696a73
EZ
15957 (redisplay_window): Even when falling back on "recentering",
15958 position point in the window according to scroll-conservatively,
15959 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
15960
15961 (try_scrolling): When point is above the window, allow searching
15962 as far as scroll_max, or one screenful, to compute vertical
15963 distance from PT to the scroll margin position. This prevents
15964 try_scrolling from unnecessarily failing when
15965 scroll-conservatively is set to a value slightly larger than the
15966 window height. Clean up the case of PT below the margin at bottom
15967 of window: scroll_max can no longer be INT_MAX. When aggressive
15968 scrolling is in use, don't let point enter the opposite scroll
15969 margin as result of the scroll.
15970 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
15971 threshold of 100 lines for never-recentering scrolling.
15972
e4cc2dfc
JB
159732011-03-31 Juanma Barranquero <lekktu@gmail.com>
15974
15975 * dispextern.h (move_it_by_lines):
15976 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
15977 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
15978 (message_log_check_duplicate): Remove parameters `prev_bol' and
15979 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
15980 (redisplay_internal): Remove parameter `preserve_echo_area',
15981 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
15982
15983 * indent.c (Fvertical_motion):
15984 * window.c (window_scroll_pixel_based, Frecenter):
15985 Don't pass `need_y_p' to `move_it_by_lines'.
15986
1c470562
SM
159872011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
15988
44f230aa
SM
15989 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
15990 steal a few bits to be more compact.
15991 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
15992 Remove unneeded casts.
15993
1c470562
SM
15994 * bytecode.c (Fbyte_code): CAR and CDR can GC.
15995
888adce9
ZK
159962011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
15997
15998 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
15999 binding" message (bug#7967).
16000
f838ed7b
PE
160012011-03-30 Paul Eggert <eggert@cs.ucla.edu>
16002
77861b95
PE
16003 Fix more problems found by GCC 4.6.0's static checks.
16004
de6dbc14
PE
16005 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
16006 Remove unused local var.
16007
f838ed7b
PE
16008 * editfns.c (Fmessage_box): Remove unused local var.
16009
792c7b2b
PE
16010 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
16011 (note_mode_line_or_margin_highlight, note_mouse_highlight):
16012 Omit unused local vars.
c499e557 16013 * window.c (shrink_windows): Omit unused local var.
b01a1c29 16014 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
16015 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
16016 Omit unused local var.
16017
ba0165e1
PE
16018 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
16019 Don't assume string length fits in int.
32ad8845 16020 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 16021 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 16022
3c59b4c9
PE
16023 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
16024 instead of alloca (Bug#8344).
16025
a3eed478 16026 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 16027 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 16028
eb4d412d
PE
16029 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
16030
1658b401
PE
16031 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
16032 concerns.
16033
16034 * term.c (produce_glyphless_glyph): Remove unnecessary test.
16035
16036 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 16037
9a2c6e05
PE
16038 * keyboard.c (syms_of_keyboard): Use the same style as later
16039 in this function when indexing through an array. This also
16040 works around GCC bug 48267.
16041
03d0a109
PE
16042 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
16043
44f730c8
PE
16044 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
16045
fe75f926
PE
16046 * chartab.c (sub_char_table_ref_and_range): Redo for slight
16047 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
16048
ffa8c828
PE
16049 * keyboard.c, keyboard.h (num_input_events): Now size_t.
16050 This avoids undefined behavior on integer overflow, and is a bit
16051 more convenient anyway since it is compared to a size_t variable.
16052
c5101a77
PE
16053 Variadic C functions now count arguments with size_t, not int.
16054 This avoids an unnecessary limitation on 64-bit machines, which
16055 caused (substring ...) to crash on large vectors (Bug#8344).
16056 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
16057 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 16058 All variadic functions and their callers changed accordingly.
c5101a77
PE
16059 (struct gcpro.nvars): Now size_t, not int. All uses changed.
16060 * data.c (arith_driver, float_arith_driver): Likewise.
16061 * editfns.c (general_insert_function): Likewise.
16062 * eval.c (struct backtrace.nargs, interactive_p)
16063 (internal_condition_case_n, run_hook_with_args, apply_lambda)
16064 (funcall_lambda, mark_backtrace): Likewise.
16065 * fns.c (concat): Likewise.
16066 * frame.c (x_set_frame_parameters): Likewise.
16067 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
16068 0 if not found, not -1. All callers changed.
16069
dd3f25f7
PE
16070 * alloc.c (garbage_collect): Don't assume stack size fits in int.
16071 (stack_copy_size): Now size_t, not int.
16072 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
16073
461c2ab9
JB
160742011-03-28 Juanma Barranquero <lekktu@gmail.com>
16075
16076 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
16077 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
16078 All callers changed.
16079
16080 * lisp.h (multibyte_char_to_unibyte):
16081 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
16082 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
16083 * character.h (CHAR_TO_BYTE8):
16084 * cmds.c (internal_self_insert):
16085 * editfns.c (general_insert_function):
16086 * keymap.c (push_key_description):
16087 * search.c (Freplace_match):
16088 * xdisp.c (message_dolog, set_message_1): All callers changed.
16089
f6d62986
SM
160902011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
16091
16092 * keyboard.c (safe_run_hook_funcall): New function.
16093 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
16094 don't set the hook to nil, but remove the offending function instead.
16095 (Qcommand_hook_internal): Remove, unused.
16096 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
16097 Vcommand_hook_internal.
16098
16099 * eval.c (enum run_hooks_condition): Remove.
16100 (funcall_nil, funcall_not): New functions.
16101 (run_hook_with_args): Call each function through a `funcall' argument.
16102 Remove `cond' argument, now redundant.
16103 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
16104 (Frun_hook_with_args_until_failure): Adjust accordingly.
16105 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
16106
1db5b1ad
JB
161072011-03-28 Juanma Barranquero <lekktu@gmail.com>
16108
16109 * dispextern.h (string_buffer_position): Remove declaration.
16110
16111 * print.c (strout): Remove parameter `multibyte', unused since
16112 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
16113
16114 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
16115 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
16116 All callers changed.
16117
16118 * w32.c (_wsa_errlist): Use braces for struct initializers.
16119
16120 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
16121 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
16122 All callers changed.
16123 (string_buffer_position): Likewise. Also, make static (it's never
16124 used outside xdisp.c).
16125 (cursor_row_p): Remove parameter `w', unused since
16126 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
16127 (decode_mode_spec): Remove parameter `precision', introduced during
16128 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
16129 All callers changed.
16130
5ffb62aa
JD
161312011-03-27 Jan Djärv <jan.h.d@swipnet.se>
16132
16133 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
16134
461c2ab9 161352011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
16136
16137 * nsterm.m (ns_menu_bar_is_hidden): New variable.
16138 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
16139 (ns_update_auto_hide_menu_bar): New functions.
16140 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
16141 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
16142 ns_constrain_all_frames.
16143 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
16144 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
16145
5c380ffb
JD
161462011-03-27 Jan Djärv <jan.h.d@swipnet.se>
16147
16148 * nsmenu.m (runDialogAt): Remove argument to timer_check.
16149
9af30bdf
GM
161502011-03-27 Glenn Morris <rgm@gnu.org>
16151
16152 * syssignal.h: Replace RETSIGTYPE with void.
16153 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
16154 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
16155 Replace SIGTYPE with void everywhere.
16156 * s/usg5-4-common.h (SIGTYPE): Remove definition.
16157 * s/template.h (SIGTYPE): Remove commented out definition.
16158
e2abce01
JB
161592011-03-26 Eli Zaretskii <eliz@gnu.org>
16160
16161 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
16162 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
16163
f868cd8a
JB
161642011-03-26 Juanma Barranquero <lekktu@gmail.com>
16165
59eb0929
JB
16166 * w32.c (read_unc_volume): Use parameter `henum', instead of
16167 global variable `wget_enum_handle'.
16168
16169 * keymap.c (describe_vector): Remove parameters `indices' and
16170 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
16171 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
16172
f868cd8a
JB
16173 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
16174
16175 * keyboard.c (timer_check): Remove parameter `do_it_now',
16176 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
16177 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
16178 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
16179
16180 * keyboard.c (read_char):
16181 * w32menu.c (w32_menu_display_help):
16182 * xmenu.c (show_help_event, menu_help_callback):
16183 Adjust calls to `show_help_echo'.
16184
16185 * gtkutil.c (xg_maybe_add_timer):
16186 * keyboard.c (readable_events):
16187 * process.c (wait_reading_process_output):
16188 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
16189
16190 * insdel.c (adjust_markers_gap_motion):
16191 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
16192 (gap_left, gap_right): Don't call it.
16193
2ecf6fdb
CY
161942011-03-25 Chong Yidong <cyd@stupidchicken.com>
16195
16196 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
16197 incurred during fontification.
16198
6b1f9ba4
JB
161992011-03-25 Juanma Barranquero <lekktu@gmail.com>
16200
16201 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
16202 (DEFVAR_PER_BUFFER): Don't pass it.
16203
16204 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
16205 (scrolling_window): Don't pass it.
16206
0f4a96b5
JB
162072011-03-25 Juanma Barranquero <lekktu@gmail.com>
16208
16209 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
16210
16211 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
16212 and `suffix'.
16213 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
16214 of variables specific to SELinux and computation of `encoded_absname'.
16215
16216 * image.c (XPutPixel): Remove unused variable `height'.
16217
16218 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
16219
16220 * unexw32.c (get_section_info): Remove unused variable `section'.
16221
16222 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
16223 (system_process_attributes): Remove unused variable `sess'.
16224 (sys_read): Remove unused variable `err'.
16225
16226 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
16227 (w32_wnd_proc): Remove unused variable `isdead'.
16228 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
16229 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
16230 (x_create_tip_frame): Remove unused variable `tem'.
16231
16232 * w32inevt.c (w32_console_read_socket):
16233 Remove unused variable `no_events'.
16234
16235 * w32term.c (x_draw_composite_glyph_string_foreground):
16236 Remove unused variable `width'.
16237
1149507c
JB
162382011-03-24 Juanma Barranquero <lekktu@gmail.com>
16239
16240 * w32term.c (x_set_glyph_string_clipping):
16241 Don't pass uninitialized region to CombineRgn.
16242
9c88f339
JB
162432011-03-23 Juanma Barranquero <lekktu@gmail.com>
16244
16245 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
16246 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
16247 (Fx_close_connection): Remove unused variable `i'.
16248
16249 * w32font.c (w32font_draw): Return number of glyphs.
16250 (w32font_open_internal): Remove unused variable `i'.
16251 (w32font_driver): Add missing initializer.
16252
16253 * w32menu.c (utf8to16): Remove unused variable `utf16'.
16254 (fill_in_menu): Remove unused variable `items_added'.
16255
16256 * w32term.c (last_mouse_press_frame): Remove static global variable.
16257 (w32_clip_to_row): Remove unused variable `f'.
16258 (x_delete_terminal): Remove unused variable `i'.
16259
16260 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
16261 (NOTHING): Remove unused static global variable.
16262 (uniscribe_check_otf): Remove unused variable `table'.
16263 (uniscribe_font_driver): Add missing initializers.
16264
dee091a3
JD
162652011-03-23 Julien Danjou <julien@danjou.info>
16266
16267 * term.c (Fsuspend_tty, Fresume_tty):
16268 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
16269 * window.c (temp_output_buffer_show):
16270 * insdel.c (signal_before_change):
16271 * frame.c (Fhandle_switch_frame):
16272 * fileio.c (Fdo_auto_save):
16273 * emacs.c (Fkill_emacs):
16274 * editfns.c (save_excursion_restore):
16275 * cmds.c (internal_self_insert):
16276 * callint.c (Fcall_interactively):
16277 * buffer.c (Fkill_all_local_variables):
16278 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
16279 Use Frun_hooks.
0f4a96b5 16280 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 16281 unconditionally since it does the check itself.
dee091a3 16282
2c520ab5 162832011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 16284
c9c49752
PE
16285 Fix more problems found by GCC 4.5.2's static checks.
16286
8abc3f12
PE
16287 * coding.c (encode_coding_raw_text): Avoid unnecessary test
16288 the first time through the loop, since we know p0 < p1 then.
16289 This also avoids a gcc -Wstrict-overflow warning.
16290
a2d26660
PE
16291 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
16292 leading to a memory leak, possible in functions like
16293 load_charset_map_from_file that can allocate an unbounded number
b12ef411 16294 of objects (Bug#8318).
a2d26660 16295
916c72e9
PE
16296 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
16297 that could (at least in theory) be that large.
16298
19ab8a18
PE
16299 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
16300 This is less likely to overflow, and avoids undefined behavior if
16301 overflow does occur. All callers changed. Use strtoul to scan
16302 for the unsigned long integer.
b7cbbd6f
PE
16303 (pint2hrstr): Simplify and tune code slightly.
16304 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 16305
f0641eff
PE
16306 * scroll.c (do_scrolling): Work around GCC bug 48228.
16307 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
16308
7f650bb9
PE
16309 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
16310 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
16311 (validate_x_resource_name): Simplify count usage.
16312 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 16313
37dd57d1
PE
16314 * fileio.c (Fcopy_file): Report error if fchown or fchmod
16315 fail (Bug#8306).
81e56e61 16316
699979fc 16317 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 16318
401bf9b4
PE
16319 * process.c (Fmake_network_process): Use socklen_t, not int,
16320 where POSIX says socklen_t is required in portable programs.
16321 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 16322 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
16323 (Fmake_network_process, server_accept_connection):
16324 (wait_reading_process_output, read_process_output):
16325 Likewise.
16326
b93aacde
PE
16327 * process.c: Rename or move locals to avoid shadowing.
16328 (list_processes_1, Fmake_network_process):
16329 (read_process_output_error_handler, exec_sentinel_error_handler):
16330 Rename or move locals.
4dc343ee 16331 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 16332 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 16333 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 16334 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 16335 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 16336
af8a867c 16337 Make tparam.h and terminfo.c consistent.
44f230aa
SM
16338 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
16339 Include tparam.h instead, since it declares them.
af8a867c
PE
16340 * cm.h (PC): Remove extern decl; tparam.h now does this.
16341 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
16342 * terminfo.c: Include tparam.h, to check interfaces.
16343 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
16344 (tparam): Adjust signature to match interface in tparam.h;
16345 this removes some undefined behavior. Check that outstring and len
16346 are zero, which they always are with Emacs.
16347 * tparam.h (PC, BC, UP): New extern decls.
16348
0248044d 16349 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 16350 (xftfont_open): Rename locals to avoid shadowing.
0248044d 16351
8ff096c1 16352 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
16353 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
16354 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 16355 (ftfont_list): Remove unused local.
49eaafba
PE
16356 (get_adstyle_property, ftfont_pattern_entity):
16357 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
16358 Rename locals to avoid shadowing.
8ff096c1 16359
e2be39f6
PE
16360 * xfont.c (xfont_list_family): Mark var as initialized.
16361
c9735e30
PE
16362 * xml.c (make_dom): Now static.
16363
8f5201ae
PE
16364 * composite.c (composition_compute_stop_pos): Rename local to
16365 avoid shadowing.
b246f932
PE
16366 (composition_reseat_it): Remove unused locals.
16367 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 16368 (composition_update_it): Mark var as initialized.
11b61122
PE
16369 (find_automatic_composition): Mark vars as initialized,
16370 with a FIXME (Bug#8290).
8f5201ae 16371
760fbc2c
PE
16372 character.h: Rename locals to avoid shadowing.
16373 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
16374 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
16375 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
16376 (BUF_DEC_POS): Be more systematic about renaming local temporaries
16377 to avoid shadowing.
16378
ff08eb85
PE
16379 * textprop.c (property_change_between_p): Remove; unused.
16380
fc7bf025
PE
16381 * intervals.c (interval_start_pos): Now static.
16382
235d7abc
PE
16383 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
16384
44f230aa
SM
16385 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
16386 Rename locals to avoid shadowing.
3e7d6594 16387
50060332
PE
16388 * sound.c (wav_play, au_play, Fplay_sound_internal):
16389 Fix pointer signedness.
d01f234b 16390 (alsa_choose_format): Remove unused local var.
c83b8872
PE
16391 (wav_play): Initialize a variable to 0, to prevent undefined
16392 behavior (Bug#8278).
50060332 16393
c4fc4e30
PE
16394 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
16395
918436ed
PE
16396 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
16397
c939f91b
PE
16398 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
16399 clobbering (Bug#8298).
b9c7f648
PE
16400 * sysdep.c (sys_subshell): Likewise.
16401 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 16402
6bd8c144
PE
16403 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
16404 This should get cleaned up, so that child_setup has the
16405 same signature on all platforms.
16406
7710357c 16407 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 16408 (relocate_fd): Rename locals to avoid shadowing.
7710357c 16409
c59da222
CY
164102011-03-22 Chong Yidong <cyd@stupidchicken.com>
16411
16412 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
16413 not to be necessary, and produces flickering.
16414
66b87493
GM
164152011-03-20 Glenn Morris <rgm@gnu.org>
16416
16417 * config.in: Remove file.
16418
45b6f6d5
JB
164192011-03-20 Juanma Barranquero <lekktu@gmail.com>
16420
16421 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
16422 are now in src/globals.h.
16423 (syms_of_minibuf): Remove spurious & from previous change.
16424
cd394be1 164252011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
16426
16427 * minibuf.c (completing-read-function): New variable.
16428 (completing-read-default): Rename from completing-read.
16429 (completing-read): Call completing-read-function.
16430
b14e3e21
CY
164312011-03-19 Juanma Barranquero <lekktu@gmail.com>
16432
16433 * xfaces.c (Fx_load_color_file):
16434 Read color file from absolute filename (bug#8250).
16435
f2b726e6
JB
164362011-03-19 Juanma Barranquero <lekktu@gmail.com>
16437
16438 * makefile.w32-in: Update dependencies.
16439
09f6ff02
EZ
164402011-03-17 Eli Zaretskii <eliz@gnu.org>
16441
16442 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
16443
29a6015a
PE
164442011-03-17 Paul Eggert <eggert@cs.ucla.edu>
16445
a3a6c54e
PE
16446 Fix more problems found by GCC 4.5.2's static checks.
16447
b766f867
PE
16448 * process.c (make_serial_process_unwind, send_process_trap):
16449 (sigchld_handler): Now static.
16450
be02381c
PE
16451 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
16452 That way, the code declares only the vars that it needs.
16453 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
16454 * s/cygwin.h (PTY_ITERATION): Likewise.
16455 * s/darwin.h (PTY_ITERATION): Likewise.
16456 * s/gnu-linux.h (PTY_ITERATION): Likewise.
16457
57048744
PE
16458 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
16459 * process.c (allocate_pty): Don't declare stb unless it's needed.
16460
7914961c 16461 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
16462 (CONSTANTLIM): Remove; unused.
16463 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
16464 Define only if needed.
7914961c 16465
b3967b18
PE
16466 * unexelf.c (unexec): Name an expression,
16467 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
16468 Use a different way to cause a compilation error if anyone uses
16469 n rather than nn, a way that does not involve shadowing.
73366a00 16470 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 16471
29a6015a
PE
16472 * deps.mk (unexalpha.o): Remove; unused.
16473
43cfc33e 16474 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 16475 * unexec.h: New file.
ce701a33
PE
16476 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
16477 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
16478 Depend on unexec.h.
16479 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
16480 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
16481 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 16482 Change as necessary to match prototype in unexec.h.
ce701a33 16483
01f44d5a
PE
16484 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
16485 shadowing.
4f63c6bb 16486 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 16487
a6670b0b
PE
16488 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
16489 Rename locals to avoid shadowing.
16490
cef2010d 16491 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 16492 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 16493
d4d7173a
PE
16494 * print.c (Fredirect_debugging_output): Fix pointer signedess.
16495
f08b802a
PE
16496 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
16497 warning when compiling print.c.
16498
3ddb0639
PE
16499 * font.c (font_unparse_fcname): Abort in an "impossible" situation
16500 instead of using an uninitialized var.
5ad03b97 16501 (font_sort_entities): Mark var as initialized.
3ddb0639 16502
170a2692
PE
16503 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
16504
e663c700
PE
16505 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
16506 pointers to constants.
89bc529a 16507 (font_parse_fcname): Remove unused vars.
7b81e2d0 16508 (font_delete_unmatched): Now static.
ea838e10 16509 (font_get_spec): Remove; unused.
13a547c6
PE
16510 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
16511 (font_update_drivers, Ffont_get_glyphs, font_add_log):
16512 Rename or move locals to avoid shadowing.
e663c700 16513
2a80c887 16514 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 16515 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 16516
1384fa33 16517 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 16518 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 16519
8b2c52e9
PE
16520 * alloc.c (mark_backtrace): Move decl from here ...
16521 * lisp.h: ... to here, so that it can be checked.
16522
475545b5 16523 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 16524 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
16525 (lisp_indirect_variable): Name an expression,
16526 to avoid gcc -Wbad-function-cast warning.
1faed8ae 16527 (Fdefvar): Rename locals to avoid shadowing.
475545b5 16528
b1349114 16529 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 16530 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 16531 Use const pointer when appropriate.
b1349114 16532
a2928364
PE
16533 * lisp.h (get_system_name, get_operating_system_release):
16534 Move decls here, to check interfaces.
16535 * process.c (get_operating_system_release): Move decl to lisp.h.
16536 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
16537 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
16538 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
16539 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
16540 (Fformat_time_string, Fencode_time, Finsert_char):
16541 (Ftranslate_region_internal, Fformat):
16542 Rename or remove local vars to avoid shadowing.
9710023e 16543 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 16544
a415e694
PE
16545 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
16546 avoid shadowing.
16547
8ef4622d
PE
16548 * lisp.h (eassert): Check that the argument compiles, even if
16549 ENABLE_CHECKING is not defined.
16550
946f9a5b
PE
16551 * data.c (Findirect_variable): Name an expression, to avoid
16552 gcc -Wbad-function-cast warning.
112396d6 16553 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 16554 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
16555 (Fmake_variable_buffer_local, Fmake_local_variable):
16556 Mark variables as initialized.
52746918 16557 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 16558
e5aab7e7 16559 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
16560 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
16561 Rename locals to avoid shadowing.
dff45157
PE
16562 (mark_stack): Move local variables into the #ifdef region where
16563 they're used.
7bc26fdb
PE
16564 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
16565 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
16566 needed otherwise.
16567 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
16568 (GC_STRING_CHARS): Remove; not used.
d40d4be1 16569 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 16570
e5aab7e7
PE
16571 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
16572 avoids undefined behavior in theory.
16573
4da60324
PE
16574 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
16575
88043301
PE
16576 Use functions, not macros, for up- and down-casing (Bug#8254).
16577 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
16578 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
16579 to use the following functions instead of these macros.
16580 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
16581 EMACS_INT, since callers assume the returned value fits in int.
16582 (upcase1): Likewise, for UPCASE_TABLE.
16583 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 16584 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 16585 the race-condition problem in the old DOWNCASE.
88043301 16586
19ed5445
PE
16587 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
16588 Rename locals to avoid shadowing.
16589 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
16590 (regex_compile, re_search_2, re_match_2_internal):
16591 Remove unused local vars.
952db0d7
PE
16592 (FREE_VAR): Rewrite so as not to use empty "else",
16593 which gcc can warn about.
da053e48 16594 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
16595 (RETALLOC_IF): Define only if needed.
16596 (WORDCHAR_P): Likewise. This one is never needed, but is used
16597 only in a comment talking about a compiler bug, so put inside
16598 the #if 0 of that comment.
16599 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
16600 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
16601 Remove; unused.
19ed5445 16602
1f3561e4 16603 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
16604 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
16605 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 16606
ded6f8f7
PE
16607 * search.c (simple_search): Remove unused var.
16608
dbd37a95
PE
16609 * dired.c (compile_pattern): Move decl from here ...
16610 * lisp.h: ... to here, so that it can be checked.
16611 (struct re_registers): New forward decl.
16612
7e47afad
PE
16613 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
16614
85f24f61
PE
16615 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
16616 All uses changed.
16617 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
16618 Rename locals to avoid shadowing.
5671df8f 16619 (Fvertical_motion): Mark locals as initialized.
85f24f61 16620
181aa2be 16621 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 16622 (casify_region): Mark local as initialized.
181aa2be 16623
930d429c
PE
16624 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
16625
7082eac6
PE
16626 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
16627 New macros, so that the caller can use some names other than
16628 gcpro1, gcpro2, etc.
16629 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
16630 of the new macros.
16631 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
16632 argument, for consistency with GCPRO2_VAR, etc: it is now the
16633 prefix of the variable, not the variable itself. All uses
16634 changed.
38b2c076
PE
16635 * dired.c (directory_files_internal, file_name_completion):
16636 Rename locals to avoid shadowing.
16637
15206ed9
PE
16638 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
16639 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
16640 dired.c's scmp function, had undefined behavior.
16641 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
16642 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
16643 * buffer.h: ... to here, because these macros use current_buffer,
16644 and the new implementation with inline functions needs to have
16645 current_buffer in scope now, rather than later when the macros
16646 are used.
16647 (downcase, upcase1): New static inline functions.
16648 (DOWNCASE, UPCASE1): Reimplement using these functions.
16649 This avoids undefined behavior in expressions like
16650 DOWNCASE (x) == DOWNCASE (y), which previously suffered
16651 from race conditions in accessing the global variables
16652 case_temp1 and case_temp2.
16653 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
16654 * lisp.h (case_temp1, case_temp2): Remove their decls.
16655 * character.h (ASCII_CHAR_P): Move from here ...
16656 * lisp.h: ... to here, so that the inline functions mentioned
16657 above can use them.
16658
4a6bea26
PE
16659 * dired.c (directory_files_internal_unwind): Now static.
16660
f14b7e14
PE
16661 * fileio.c (file_name_as_directory, directory_file_name):
16662 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
16663 Now static.
2893f146
PE
16664 (file_name_as_directory): Use const pointers when appropriate.
16665 (Fexpand_file_name): Likewise. In particular, newdir might
16666 point at constant storage, so make it a const pointer.
fd4ead52 16667 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
16668 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
16669 signedness issues.
f839df0c
PE
16670 (Fset_file_times, Finsert_file_contents, auto_save_error):
16671 Rename locals to avoid shadowing.
f14b7e14 16672
5716756e 16673 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
16674 (Ftry_completion, Fall_completions): Rename or remove locals
16675 to avoid shadowing.
5716756e 16676
b4c3046a
PE
16677 * marker.c (bytepos_to_charpos): Remove; unused.
16678
b45db522
PE
16679 * lisp.h (verify_bytepos, count_markers): New decls,
16680 so that gcc does not warn that these functions aren't declared.
16681
85876d07
PE
16682 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
16683 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 16684 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 16685 (copy_text): Remove unused local var.
85876d07 16686
03d78a21 16687 * filelock.c (within_one_second): Now static.
b3dd38ab 16688 (lock_file_1): Rename local to avoid shadowing.
03d78a21 16689
5df8f01b
PE
16690 * buffer.c (fix_overlays_before): Mark locals as initialized.
16691 (fix_start_end_in_overlays): Likewise. This function should be
16692 simplified by using pointers-to-pointers, but that's a different
16693 matter.
b1d876f1 16694 (switch_to_buffer_1): Now static.
8f54f30a
PE
16695 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
16696 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 16697
a70072c9 16698 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 16699 Fix pointer signedness issue.
edced198
PE
16700 (sys_subshell): Mark local as volatile if checking for lint,
16701 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 16702 (MAXPATHLEN): Define only if needed.
a70072c9 16703
a0977c44
PE
16704 * process.c (serial_open, serial_configure): Move decls from here ...
16705 * systty.h: ... to here, so that they can be checked.
16706
a884fdcc
PE
16707 * fns.c (get_random, seed_random): Move extern decls from here ...
16708 * lisp.h: ... to here, so that they can be checked.
16709
604efe86 16710 * sysdep.c (reset_io): Now static.
b8950c94 16711 (wait_for_termination_signal): Remove; unused.
604efe86 16712
38fc62d9
PE
16713 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
16714 (copy_keymap_item, append_key, push_text_char_description):
16715 Now static.
1004a21a 16716 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 16717 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
16718 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
16719 (describe_map_tree):
16720 Rename locals to avoid shadowing.
38fc62d9 16721
2f2650da
PE
16722 * keyboard.c: Declare functions static if they are not used elsewhere.
16723 (echo_char, echo_dash, cmd_error, top_level_2):
16724 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
16725 (read_char, kbd_buffer_get_event, make_lispy_position):
16726 (make_lispy_event, make_lispy_movement, apply_modifiers):
16727 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
16728 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
16729 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 16730 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 16731 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 16732
a053e86c 16733 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
16734 (mark_kboards): Move decl here ...
16735 * alloc.c (mark_kboards): ... from here.
a053e86c 16736
4752793e
PE
16737 * lisp.h (force_auto_save_soon): New decl.
16738
74f10ca7 16739 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
16740 (DEFINE_DUMMY_FUNCTION): New macro.
16741 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
16742 Use it.
c03cd23f
PE
16743 (main): Add casts to avoid warnings
16744 if GCC considers string literals to be constants.
74f10ca7 16745
022e70d4
PE
16746 * lisp.h (fatal_error_signal): Add decl, since it's exported.
16747
59d6fe83
PE
16748 * dbusbind.c: Pointer signedness fixes.
16749 (xd_signature, xd_append_arg, xd_initialize):
16750 (Fdbus_call_method, Fdbus_call_method_asynchronously):
16751 (Fdbus_method_return_internal, Fdbus_method_error_internal):
16752 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
16753 (Fdbus_register_signal): Use SSDATA when the context wants char *.
16754
78320123
PE
16755 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
16756 if GCC considers string literals to be constants.
49cebcca 16757 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 16758
35ac2a97
SM
167592011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
16760
fb103ca9
SM
16761 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
16762 (print_preprocess, print_object): New macro to fix last change.
16763
35ac2a97
SM
16764 * print.c (print_preprocess): Don't forget font objects.
16765
62973b41
JB
167662011-03-16 Juanma Barranquero <lekktu@gmail.com>
16767
16768 * emacs.c (USAGE3): Doc fixes.
16769
0e48bb22
AS
167702011-03-15 Andreas Schwab <schwab@linux-m68k.org>
16771
16772 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
16773 structure.
16774
7684e57b
JB
167752011-03-14 Juanma Barranquero <lekktu@gmail.com>
16776
16777 * lisp.h (VWindow_system, Qfile_name_history):
16778 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
16779 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
16780 (w32_system_caret_x, w32_system_caret_y): Declare extern.
16781
16782 * w32select.c: Don't #include "keyboard.h".
c96bbc66 16783 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
16784
16785 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
16786 * w32console.c (detect_input_pending, read_input_pending)
16787 (encode_terminal_code):
16788 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
16789 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
16790 (w32_system_caret_y, Qfile_name_history):
16791 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
16792 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
16793 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
16794 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
16795 * w32proc.c (Qlocal, report_file_error):
16796 * w32term.c (Vwindow_system, updating_frame):
16797 * w32uniscribe.c (initialized, uniscribe_font_driver):
16798 Remove unneeded extern declarations.
16799
2aa46d6c
CY
168002011-03-14 Chong Yidong <cyd@stupidchicken.com>
16801
c96bbc66 16802 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 16803
cffc6f3b
CY
168042011-03-13 Chong Yidong <cyd@stupidchicken.com>
16805
16806 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
16807 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
16808 These macros can no longer be used for assignment.
16809
44f230aa
SM
16810 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
16811 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
16812 (record_buffer_markers, fetch_buffer_markers): New functions for
16813 recording and fetching special buffer markers.
16814 (set_buffer_internal_1, set_buffer_temp): Use them.
16815
16816 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
16817
16818 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
16819
16820 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
16821 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
16822
16823 * xdisp.c (hscroll_window_tree):
16824 (reconsider_clip_changes): Use PT instead of BUF_PT.
16825
d251f04b
EZ
168262011-03-13 Eli Zaretskii <eliz@gnu.org>
16827
16828 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
16829 $(EMACS_ROOT)/lib/intprops.h.
16830
f0c77cd1
PE
168312011-03-13 Paul Eggert <eggert@cs.ucla.edu>
16832
3eca4629
PE
16833 Fix more problems found by GCC 4.5.2's static checks.
16834
7c86ee98
PE
16835 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
16836 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
16837 (xg_free_frame_widgets): Make it clear that a local variable is
16838 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
16839 (gdk_window_get_screen): Make it clear that this macro is needed
16840 only if USE_GTK_TOOLTIP.
1e5524e7
PE
16841 (int_gtk_range_get_value): New function, which avoids a diagnostic
16842 from gcc -Wbad-function-cast.
16843 (xg_set_toolkit_scroll_bar_thumb): Use it.
16844 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
16845 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
16846 (get_utf8_string, xg_get_file_with_chooser):
16847 Rename locals to avoid shadowing.
16848 (create_dialog): Move locals to avoid shadowing.
7c86ee98 16849
41729b81
PE
16850 * xgselect.c (xg_select): Remove unused var.
16851
f0c77cd1
PE
16852 * image.c (four_corners_best): Mark locals as initialized.
16853 (gif_load): Initialize transparent_p to zero (Bug#8238).
16854 Mark another local as initialized.
ec6cf4c6 16855 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 16856
ce0ad53d 16857 * image.c (clear_image_cache): Now static.
d5d5a617 16858 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 16859 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
16860 (x_edge_detection): Remove unnecessary cast that
16861 gcc -Wbad-function-cast diagnoses.
2037898d 16862 (gif_load): Fix pointer signedness.
6ae141d6
PE
16863 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
16864 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 16865
33383987 168662011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 16867
d32df629
PE
16868 Improve quality of tests for time stamp overflow.
16869 For example, without this patch (encode-time 0 0 0 1 1
16870 1152921504606846976) returns the obviously-bogus value (-948597
16871 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
16872 reports time overflow. See
16873 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
16874 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
16875 * editfns.c: Include limits.h and intprops.h.
16876 (TIME_T_MIN, TIME_T_MAX): New macros.
16877 (time_overflow): Move earlier, to before first use.
16878 (hi_time, lo_time): New functions, for an accurate test for
16879 out-of-range times.
16880 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
16881 (Fget_internal_run_time): Don't assume time_t fits in int.
16882 (make_time): Use list2 instead of Fcons twice.
16883 (Fdecode_time): More accurate test for out-of-range times.
16884 (check_tm_member): New function.
16885 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
16886 (lisp_time_argument): Don't rely on undefined left-shift and
16887 right-shift behavior when checking for time stamp overflow.
8be6f318 16888
fe31d94c
PE
16889 * editfns.c (time_overflow): New function, refactoring common code.
16890 (Fformat_time_string, Fdecode_time, Fencode_time):
16891 (Fcurrent_time_string): Use it.
16892
8be6f318
PE
16893 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
16894 * dired.c (make_time): Move to ...
16895 * editfns.c (make_time): ... here.
16896 * systime.h: Note the move.
16897
09d9db2c 168982011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 16899
126bc0dc
YM
16900 * fringe.c (update_window_fringes): Remove unused variables.
16901
c47cbdfd
YM
16902 * unexmacosx.c (copy_data_segment): Also copy __got section.
16903 (Bug#8223)
16904
7ac80be9
EZ
169052011-03-12 Eli Zaretskii <eliz@gnu.org>
16906
c96bbc66 16907 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
16908 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
16909 Constify `char *' arguments and their references according to
16910 prototypes in tparam.h.
16911
ecb0f94d 16912 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 16913
7ac80be9
EZ
16914 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
16915 Adapt all references accordingly.
16916
16917 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
16918
ef1fd07e
TT
169192011-03-11 Tom Tromey <tromey@redhat.com>
16920
16921 * buffer.c (syms_of_buffer): Remove obsolete comment.
16922
7ef4b50c
EZ
169232011-03-11 Eli Zaretskii <eliz@gnu.org>
16924
16925 * termhooks.h (encode_terminal_code): Declare prototype.
16926
16927 * msdos.c (encode_terminal_code): Don't declare prototype.
16928
16929 * term.c (encode_terminal_code): Now external again, used by
16930 w32console.c and msdos.c.
16931
44f230aa
SM
16932 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
16933 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 16934
4b1ec863 169352011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 16936
1714f52b 16937 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 16938
4b1ec863
PE
16939 * fringe.c (update_window_fringes): Mark locals as initialized
16940 (Bug#8227).
16941 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 16942
524c7aa6
PE
16943 * alloc.c (mark_fringe_data): Move decl from here ...
16944 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
16945 to check its interface.
16946 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
16947
a5c0af81 16948 * fontset.c (free_realized_fontset): Now static.
7519b8cd 16949 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 16950 (fontset_font): Mark local as initialized.
a9a06e0b 16951 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 16952
b4716021
PE
16953 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
16954
811e9bac 16955 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 16956 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
16957 (x_own_selection, Fx_disown_selection_internal): Rename locals
16958 to avoid shadowing.
16959 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 16960
7e3ab302
PE
16961 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
16962 so that the caller can use some name other than gcpro1.
16963 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
16964 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
16965 (Fx_backspace_delete_keys_p):
16966 Use them to avoid shadowing, and rename vars to avoid shadowing.
16967 (x_decode_color, x_set_name, x_window): Now static.
6b437900 16968 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 16969 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
16970 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
16971 Remove unused locals.
7e3ab302
PE
16972 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
16973 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
16974 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
16975 macros.
f78faa98 16976
e2b13473
PE
16977 * xterm.h (x_mouse_leave): New decl.
16978
77f23912
PE
16979 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
16980 Remove unused functions.
cdf4ba58
PE
16981 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
16982 (x_calc_absolute_position): Now static.
7411c686 16983 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 16984 Don't declare local "event" unless it's used.
ed7bf3a5
PE
16985 (x_iconify_frame, x_free_frame_resources): Don't declare locals
16986 unless they are used.
38d0b34a
PE
16987 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
16988 (x_fatal_error_signal): Remove; not used.
a6067996
PE
16989 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
16990 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
16991 (x_error_catcher, x_connection_closed, x_error_handler):
16992 (x_error_quitter, xembed_send_message, x_iconify_frame):
16993 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 16994 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 16995 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 16996
44f230aa
SM
16997 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
16998 Rename or move locals to avoid shadowing.
6b463e58 16999 (tty_defined_color, merge_face_heights): Now static.
5967d051 17000 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
17001 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
17002 does not deduce is never used uninitialized.
73719eba
PE
17003 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
17004 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 17005
426994c3 17006 * terminal.c (store_terminal_param): Now static.
5489860b 17007
032f1620 17008 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 17009 (set_frame_menubar): Remove unused local.
d4323972 17010 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
17011 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
17012 since they might point to immutable storage.
281585b0
PE
17013 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
17014 since it's unused otherwise.
032f1620 17015
367c19e5 17016 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 17017 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
17018 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
17019 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 17020 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
17021 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
17022 does not deduce are never used uninitialized.
70739cbe 17023
07b48fa9
PE
17024 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
17025
8868a238 17026 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
17027 * window.c (window_loop, size_window):
17028 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 17029
7e5cf297 17030 * window.c (display_buffer): Now static.
d6550a9f
PE
17031 (size_window): Mark variables that gcc -Wuninitialized
17032 does not deduce are never used uninitialized.
a586633d
PE
17033 * window.h (check_all_windows): New decl, to forestall
17034 gcc -Wmissing-prototypes diagnostic.
5b555da1 17035 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 17036
f6095868
PE
17037 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
17038 shadowing.
17039 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
17040 Include <limits.h>.
17041 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
17042 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
17043 (load_charset_map): Mark variables that gcc -Wuninitialized
17044 does not deduce are never used uninitialized.
53df7c11 17045 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 17046
f38b440c
PE
17047 * coding.c (coding_set_source, coding_set_destination):
17048 Use "else { /* comment */ }" rather than "else /* comment */;"
17049 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
17050 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
17051 a block, when the outer 'i' will do.
17052 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
17053 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
17054 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
17055 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
17056 (Fdecode_sjis_char, Fdefine_coding_system_internal):
17057 Rename locals to avoid shadowing.
17058 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
17059 * coding.c (emacs_mule_char, encode_invocation_designation):
17060 Now static, since they're not used elsewhere.
413bb2db 17061 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 17062 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
17063 (decode_coding_emacs_mule): Mark variables that gcc
17064 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
17065 (detect_coding_iso_2022): Initialize a local variable that might
17066 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 17067 this initialization is needed. (Bug#8211)
5f58e762
PE
17068 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
17069 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
17070 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
17071 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
17072 Remove unused macros.
f38b440c 17073
232b38b9 17074 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 17075 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 17076 * character.c (string_count_byte8): Likewise.
232b38b9 17077
fb90da1b
PE
17078 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
17079 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
17080
fb93dbc2
PE
17081 * chartab.c (copy_sub_char_table): Now static, since it's not used
17082 elsewhere.
5c156ace
PE
17083 (sub_char_table_ref_and_range, char_table_ref_and_range):
17084 Rename locals to avoid shadowing.
bbcd0949 17085 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 17086
7d3b3862 17087 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 17088 (BIDI_BOB): Remove unused macro.
7d3b3862 17089
6be7d3da
PE
17090 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
17091 deduce are never used uninitialized.
c2ed9c8b 17092 * term.c (encode_terminal_code): Likewise.
6be7d3da 17093
75f8807f 17094 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 17095
50938595
PE
17096 * tparam.h: New file.
17097 * term.c, tparam.h: Include it.
17098 * deps.mk (term.o, tparam.o): Depend on tparam.h.
17099 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
17100 Move these decls to tparam.h, and make them agree with what
17101 is actually in tparam.c. The previous trick of using incompatible
17102 decls in different modules does not conform to the C standard.
17103 All callers of tparam changed to use tparam's actual API.
17104 * tparam.c (tparam1, tparam, tgoto):
17105 Use const pointers where appropriate.
17106
fbceeba2
PE
17107 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
17108 * cm.h (struct cm): Likewise.
17109 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
17110 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
17111 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
17112 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
17113 (turn_on_face, init_tty): Likewise.
17114 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 17115
7f3f1250
PE
17116 * term.c (term_mouse_position): Rename local to avoid shadowing.
17117
e6ca6543
PE
17118 * alloc.c (mark_ttys): Move decl from here ...
17119 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
17120
c40f8d15
AS
171212011-03-11 Andreas Schwab <schwab@linux-m68k.org>
17122
17123 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
17124
cfe0661d
JB
171252011-03-09 Juanma Barranquero <lekktu@gmail.com>
17126
17127 * search.c (compile_pattern_1): Remove argument regp, unused since
17128 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
17129 (compile_pattern): Don't pass it.
17130
0afb4571
J
171312011-03-08 Jan Djärv <jan.h.d@swipnet.se>
17132
17133 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
17134 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
17135 for ! HAVE_GTK3.
17136 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
17137
17138 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
17139
17140 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
17141 gdk_window_get_screen, gdk_window_get_geometry,
17142 gdk_x11_window_lookup_for_display and GDK_KEY_g.
17143 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
17144 (xg_get_pixbuf_from_pixmap): New function.
17145 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
17146 to Pixmap, take frame as parameter, remove GdkColormap parameter.
17147 Call xg_get_pixbuf_from_pixmap instead of
17148 gdk_pixbuf_get_from_drawable.
17149 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
17150 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
17151 (xg_check_special_colors): Use GtkStyleContext and its functions
17152 for HAVE_GTK3.
17153 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
17154 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
17155 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
17156 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
17157 Call gtk_widget_get_preferred_size.
0afb4571
J
17158 (xg_frame_resized): gdk_window_get_geometry only takes 5
17159 parameters.
44f230aa
SM
17160 (xg_win_to_widget, xg_event_is_for_menubar):
17161 Call gdk_x11_window_lookup_for_display.
0afb4571
J
17162 (xg_set_widget_bg): New function.
17163 (delete_cb): New function.
895009e1 17164 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 17165 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
17166 (xg_set_background_color): Call xg_set_widget_bg.
17167 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
17168 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
17169 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
17170 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
17171 if ! HAVE_GTK3.
17172 (update_frame_tool_bar): Call gtk_widget_hide.
17173 (xg_initialize): Use GDK_KEY_g.
17174
17175 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
17176 if ! HAVE_GTK3
17177 (x_session_initialize): Call gdk_x11_set_sm_client_id.
17178
17179 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
17180 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
17181 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
17182
1c2cc4ef
JB
171832011-03-08 Juanma Barranquero <lekktu@gmail.com>
17184
17185 * w32xfns.c (select_palette): Check success of RealizePalette against
17186 GDI_ERROR, not zero.
17187
33383987 17188See ChangeLog.11 for earlier changes.
aac0c6e3
MR
17189
17190;; Local Variables:
17191;; coding: utf-8
aac0c6e3
MR
17192;; End:
17193
2f097256 17194 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
17195
17196 This file is part of GNU Emacs.
17197
17198 GNU Emacs is free software: you can redistribute it and/or modify
17199 it under the terms of the GNU General Public License as published by
17200 the Free Software Foundation, either version 3 of the License, or
17201 (at your option) any later version.
17202
17203 GNU Emacs is distributed in the hope that it will be useful,
17204 but WITHOUT ANY WARRANTY; without even the implied warranty of
17205 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17206 GNU General Public License for more details.
17207
17208 You should have received a copy of the GNU General Public License
17209 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.