gnus-draft.el (gnus-draft-clear-marks): Mark deleted articles as read.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
9851bfc5
JD
12011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2
51bb811f 3 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4 Let HAVE_GSETTINGS override HAVE_GCONF.
5 (store_monospaced_changed): New function.
6 (EMACS_SETTINGS): A new type derived from GObject to handle
7 GSettings notifications.
8 (emacs_settings_constructor, emacs_settings_get_property)
9 (emacs_settings_set_property, emacs_settings_class_init):
10 New functions.
11 (gsettings_client, gsettings_obj): New variables.
12 (GSETTINGS_SCHEMA): New define.
13 (something_changedCB): Call store_monospaced_changed.
14 (init_gsettings): New function.
15 (xsettings_initialize): Call init_gsettings.
16 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
17 to NULL.
18
19 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
20 GCONF_CFLAGS/LIBS.
21
5386012d
MR
222011-06-29 Martin Rudalics <rudalics@gmx.at>
23
24 * window.c (resize_root_window, grow_mini_window)
25 (shrink_mini_window): Rename Qresize_root_window to
26 Qwindow_resize_root_window and Qresize_root_window_vertically to
27 Qwindow_resize_root_window_vertically.
28
f13e0b08
PE
292011-06-28 Paul Eggert <eggert@cs.ucla.edu>
30
31 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
32
94515237
JB
332011-06-27 Juanma Barranquero <lekktu@gmail.com>
34
35 * makefile.w32-in: Redesign dependencies so they reflect more
36 clearly which files are directly included by each source file,
37 and not through other includes.
38
e43b6e43
MR
392011-06-27 Martin Rudalics <rudalics@gmx.at>
40
41 * buffer.c (Qclone_number): Declare static and DEFSYM it.
42 (sort_overlays, overlay_strings): When an overlay's clone number
43 matches the window's clone number process the overlay even if
44 the overlay's window property doesn't match the current window.
45
d68443dc
MR
46 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
47 (Fwindow_hchild): Rename to Fwindow_left_child.
48 (Fwindow_next): Rename to Fwindow_next_sibling.
49 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
50 (resize_window_check): Rename to window_resize_check.
51 (resize_window_apply): Rename to window_resize_apply.
52 (Fresize_window_apply): Rename to Fwindow_resize_apply.
53 (Fdelete_other_windows_internal, resize_frame_windows)
54 (Fsplit_window_internal, Fdelete_window_internal)
55 (grow_mini_window, shrink_mini_window)
56 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 57
c7e73be5
JD
582011-06-26 Jan Djärv <jan.h.d@swipnet.se>
59
60 * emacsgtkfixed.h: State that this is only used with Gtk+3.
61 (emacs_fixed_set_min_size): Remove.
62 (emacs_fixed_new): Take frame as argument.
63
64 * emacsgtkfixed.c: State that this is only used with Gtk+3.
65 (_EmacsFixedPrivate): Remove minwidth/height.
66 Add struct frame *f.
67 (emacs_fixed_init): Initialize priv->f.
68 (get_parent_class, emacs_fixed_set_min_size): Remove.
69 (emacs_fixed_new): Set priv->f to argument.
70 (emacs_fixed_get_preferred_width)
71 (emacs_fixed_get_preferred_height): Use min_width/height from
72 frames size_hint to set minimum and natural (Bug#8919).
73 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
74 and use min_width/height from frames size_hint to set
75 min_width/height (Bug#8919).
76
77 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
78 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size. Fix
79 indentation.
80
cf99dcf8
EZ
812011-06-26 Eli Zaretskii <eliz@gnu.org>
82
83 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
84 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
85 called at ZV.
86
029529ac
CY
872011-06-26 Chong Yidong <cyd@stupidchicken.com>
88
89 * process.c (wait_reading_process_output): Bypass select if
90 waiting for a cell while ignoring keyboard input, and input is
91 pending. Suggested by Jan Djärv (Bug#8869).
92
7a7ef429
PE
932011-06-25 Paul Eggert <eggert@cs.ucla.edu>
94
95 Use gnulib's dup2 module instead of rolling our own.
96 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
97
11fdef7d 982011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
99
100 * dispnew.c (scrolling_window): Before scrolling, turn off a
101 mouse-highlight in the window being scrolled.
102
cd3520a4
JB
1032011-06-24 Juanma Barranquero <lekktu@gmail.com>
104
105 Move DEFSYM to lisp.h and use everywhere.
106
107 * character.h (DEFSYM): Move declaration...
108 * lisp.h (DEFSYM): ...here.
109
110 * gnutls.c:
111 * minibuf.c:
112 * w32menu.c:
113 * w32proc.c:
114 * w32select.c: Don't include character.h.
115
116 * alloc.c (syms_of_alloc):
117 * buffer.c (syms_of_buffer):
118 * bytecode.c (syms_of_bytecode):
119 * callint.c (syms_of_callint):
120 * casefiddle.c (syms_of_casefiddle):
121 * casetab.c (init_casetab_once):
122 * category.c (init_category_once, syms_of_category):
123 * ccl.c (syms_of_ccl):
124 * cmds.c (syms_of_cmds):
125 * composite.c (syms_of_composite):
126 * dbusbind.c (syms_of_dbusbind):
127 * dired.c (syms_of_dired):
128 * dispnew.c (syms_of_display):
129 * doc.c (syms_of_doc):
130 * editfns.c (syms_of_editfns):
131 * emacs.c (syms_of_emacs):
132 * eval.c (syms_of_eval):
133 * fileio.c (syms_of_fileio):
134 * fns.c (syms_of_fns):
135 * frame.c (syms_of_frame):
136 * fringe.c (syms_of_fringe):
137 * insdel.c (syms_of_insdel):
138 * keymap.c (syms_of_keymap):
139 * lread.c (init_obarray, syms_of_lread):
140 * macros.c (syms_of_macros):
141 * msdos.c (syms_of_msdos):
142 * print.c (syms_of_print):
143 * process.c (syms_of_process):
144 * search.c (syms_of_search):
145 * sound.c (syms_of_sound):
146 * syntax.c (init_syntax_once, syms_of_syntax):
147 * terminal.c (syms_of_terminal):
148 * textprop.c (syms_of_textprop):
149 * undo.c (syms_of_undo):
150 * w32.c (globals_of_w32):
151 * window.c (syms_of_window):
152 * xdisp.c (syms_of_xdisp):
153 * xfaces.c (syms_of_xfaces):
154 * xfns.c (syms_of_xfns):
155 * xmenu.c (syms_of_xmenu):
156 * xsettings.c (syms_of_xsettings):
157 * xterm.c (syms_of_xterm): Use DEFSYM.
158
4228cf16
TZ
1592011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
160
cd3520a4 161 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 162
7fcccf1e
PE
1632011-06-23 Paul Eggert <eggert@cs.ucla.edu>
164
7efb4e0e
PE
165 Integer and buffer overflow fixes (Bug#8873).
166
ff5844ad
PE
167 * print.c (printchar, strout): Check for string overflow.
168 (PRINTPREPARE, printchar, strout):
169 Don't set size unless allocation succeeds.
170
90532f02
PE
171 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
172 for sizes. Check for string overflow more accurately.
173 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
174
6d84508d
PE
175 * macros.c: Integer and buffer overflow fixes.
176 * keyboard.h (struct keyboard.kbd_macro_bufsize):
177 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
178 Use ptrdiff_t, not int, for sizes.
179 Don't increment bufsize until after realloc succeeds.
180 Check for size-calculation overflow.
181 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
182
437b2cb4
PE
183 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
184
8b9ac8b4
PE
185 * lread.c: Integer overflow fixes.
186 (read_integer): Radix is now EMACS_INT, not int,
187 to improve quality of diagnostics for out-of-range radices.
188 Calculate buffer size correctly for out-of-range radices.
189 (read1): Check for integer overflow in radices, and in
190 read-circle numbers.
82cb60d3
PE
191 (read_escape): Avoid int overflow.
192 (Fload, openp, read_buffer_size, read1)
193 (substitute_object_recurse, read_vector, read_list, map_obarray):
194 Use ptrdiff_t, not int, for sizes.
195 (read1): Use EMACS_INT, not int, for sizes.
20270765 196 Check for size overflow.
8b9ac8b4 197
7fcccf1e
PE
198 * image.c (cache_image): Check for size arithmetic overflow.
199
bfbbd7e7
PE
200 * lread.c: Integer overflow issues.
201 (saved_doc_string_size, saved_doc_string_length)
202 (prev_saved_doc_string_size, prev_saved_doc_string_length):
203 Now ptrdiff_t, not int.
204 (read1): Don't assume doc string length fits in int. Check for
205 out-of-range doc string lengths.
206 (read_list): Don't assume file position fits in int.
39019e54 207 (read_escape): Check for hex character overflow.
bfbbd7e7 208
4e323265
LL
2092011-06-22 Leo Liu <sdl.web@gmail.com>
210
211 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
212 Move to minibuffer.el.
213
85fece3e
PE
2142011-06-22 Paul Eggert <eggert@cs.ucla.edu>
215
20b84ce9 216 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
217 The following patches are for when GLYPH_DEBUG && !XASSERT.
218 * dispextern.h (trace_redisplay_p, dump_glyph_string):
219 * dispnew.c (flush_stdout):
220 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
221 Mark as externally visible.
222 * dispnew.c (check_window_matrix_pointers): Now static.
223 * dispnew.c (window_to_frame_vpos):
224 * xfns.c (unwind_create_frame):
225 * xterm.c (x_check_font): Remove unused local.
226 * scroll.c (CHECK_BOUNDS):
227 * xfaces.c (cache_fache): Rename local to avoid shadowing.
228 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
229 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
230 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
231 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
232 Now static.
233 (debug_method_add): Use va_list and vsprintf rather than relying
234 on undefined behavior with wrong number of arguments.
235 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
236 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
237 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
238 since we're not interested in debugging glyphs with old libraries.
239 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
240 GCC 4.6.0's static checking.
241
0766b489
PE
2422011-06-22 Paul Eggert <eggert@cs.ucla.edu>
243
31fd4b32
PE
244 Integer overflow and signedness fixes (Bug#8873).
245 A few related buffer overrun fixes, too.
246
b79e8648
PE
247 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
248
0766b489
PE
249 * dispextern.h (struct face.stipple):
250 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
251 (x_bitmap_mask, x_allocate_bitmap_record)
252 (x_create_bitmap_from_data, x_create_bitmap_from_file)
253 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
254 (x_create_bitmap_from_xpm_data):
255 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
256 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
257 (.bitmaps_last):
258 * xfaces.c (load_pixmap):
259 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
260 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
261 (.bitmaps_last, struct x_output.icon_bitmap):
262 Use ptrdiff_t, not int, for bitmap indexes.
263 (x_allocate_bitmap_record): Check for size overflow.
264 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
265
b081724f
PE
266 Use ptrdiff_t, not int, for overlay counts.
267 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
268 * editfns.c (overlays_around, get_pos_property):
269 * textprop.c (get_char_property_and_overlay):
270 * xdisp.c (next_overlay_change, note_mouse_highlight):
271 * xfaces.c (face_at_buffer_position):
21514da7
PE
272 * buffer.c (OVERLAY_COUNT_MAX): New macro.
273 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
274 (Fnext_overlay_change, Fprevious_overlay_change)
275 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 276 Use ptrdiff_t, not int, for sizes.
21514da7 277 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 278
3de73e5e
PE
279 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
280
2606c57b
PE
281 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
282 (x_session_initialize): Do not assume string length fits in int.
283
aaafe47a
PE
284 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
285 This is unlikely, but can occur if DPI is outlandish.
286
2674ddc8 287 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
288 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
289
28154962
PE
290 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
291 * xrdb.c (magic_file_p, search_magic_path):
292 Omit last arg SUFFIX; it was always 0. All callers changed.
293 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
294
7de51af5
PE
295 * xfont.c (xfont_match): Avoid need for strlen.
296
25ed6cc3
PE
297 * xfns.c: Don't assume strlen fits in int.
298 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
299
4eab31dd
PE
300 * xdisp.c (message_log_check_duplicate): Return intmax_t,
301 not unsigned long, as we prefer signed integers. All callers changed.
302 Detect integer overflow in repeat count.
303 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 304 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 305
171e2a58
PE
306 * termcap.c: Don't assume sizes fit in int and never overflow.
307 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
308 (gobble_line): Check for size-calculation overflow.
309
ad39faca 310 * minibuf.c (Fread_buffer):
6e5bb2dc 311 * lread.c (intern, intern_c_string):
74ca2eb3
PE
312 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
313 Don't assume string length fits in int.
314
52c61c22 315 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
316 * gtkutil.c (style_changed_cb): Avoid need for strlen.
317
b5b8c9e5
PE
318 * font.c: Don't assume string length fits in int.
319 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
320 Use ptrdiff_t, not int.
ccd6111c
PE
321 (font_intern_prop): Don't assume string length fits in int.
322 Don't assume integer property fits in fixnum.
323 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 324
882f0d81 325 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 326 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
327 Reformulate so as not to need the command string.
328 Invoke gzip -cd rather than gunzip, as it's more portable.
329 (lock_info_type, lock_file_1, lock_file):
330 Don't assume pid_t and time_t fit in unsigned long.
331 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
332 (current_lock_owner): Prefer signed type for sizes.
333 Use memcpy, not strncpy, where memcpy is what is really wanted.
334 Don't assume (via atoi) that time_t and pid_t fit in int.
335 Check for time_t and/or pid_t out of range, e.g., via a network share.
336 Don't alloca where an auto var works fine.
337
93f4cf88
PE
338 * fileio.c: Fix some integer overflow issues.
339 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
340 Don't assume string length fits in int.
341 (directory_file_name): Don't assume string length fits in long.
342 (make_temp_name): Don't assume pid fits in int, or that its print
343 length is less than 20.
344
f3e92b69
PE
345 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
346
1bfdaf10
PE
347 * coding.c (make_subsidiaries): Don't assume string length fits in int.
348
35016e9a
PE
349 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
350
3d1e65a1
PE
351 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
352 We prefer signed integers, even for size calculations.
353
0b963a93
PE
354 * emacs.c: Don't assume string length fits in 'int'.
355 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
356 (main): Don't invoke strlen when not needed.
357
573f4b54
PE
358 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
359 (XD_DEBUG_MESSAGE): Don't waste a byte.
360
989f33ba
PE
361 * callproc.c (getenv_internal_1, getenv_internal)
362 (Fgetenv_internal):
965d34eb
PE
363 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
364
e4d29b33
PE
365 * lread.c (invalid_syntax): Omit length argument.
366 All uses changed. This doesn't fix a bug, but it simplifies the
367 code away from its former Hollerith-constant appearance, and it's
368 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 369 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 370
eb49b136
PE
371 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
372 This didn't break anything, but it didn't help either.
373 It's confusing to put a bogus integer in a place where the actual
374 value does not matter.
9f62aeb1 375 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 376 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 377
15375a22
PE
378 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
379 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
380 implementation.
b61cc01c
PE
381 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
382 We prefer signed types, and the value cannot exceed the EMACS_INT
383 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
384 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
385 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
386 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 387
53b2623d
PE
388 * indent.c (sane_tab_width): New function.
389 (current_column, scan_for_column, Findent_to, position_indentation)
390 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 391 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 392
51cab52b 393 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 394
f2ed8a70
PE
395 * lisp.h (lint_assume): New macro.
396 * composite.c (composition_gstring_put_cache):
397 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
398
abe80cc6
PE
399 * editfns.c, insdel.c:
400 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 401
b02c740e
PE
402 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
403
ebc96716
PE
404 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
405
b4e50fa0 406 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 407 Use much-faster test for byte-length change.
311d5d7c 408 Don't assume string byte-length fits in 'int'.
a4cf38e4 409 Check that character arg fits in 'int'.
85461888 410 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 411
c0c1ee9f
PE
412 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
413
a498d7f4
PE
414 * fns.c (concat): Catch string overflow earlier.
415 Do not rely on integer wraparound.
416
51cab52b
PE
417 * dispextern.h (struct it.overlay_strings_charpos)
418 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
419 * xdisp.c (forward_to_next_line_start)
420 (back_to_previous_visible_line_start)
421 (reseat_at_next_visible_line_start, next_element_from_buffer):
422 Don't arbitrarily truncate the value of 'selective' to int.
423
76031fad
PE
424 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
425
5eb55db9
PE
426 * composite.c: Don't truncate sizes to 'int'.
427 (composition_gstring_p, composition_reseat_it)
428 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
429 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
430 not EMACS_UINT, for indexes.
5eb55db9 431
0703a717
PE
432 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
433
d6202519
PE
434 * buffer.c: Include <verify.h>.
435 (struct sortvec.priority, struct sortstr.priority):
8961a454 436 Now EMACS_INT, not int.
c20998a7 437 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
438 (struct sortstr.size, record_overlay_string)
439 (struct sortstrlist.size, struct sortlist.used):
440 Don't truncate size to int.
441 (record_overlay_string): Check for size-calculation overflow.
d6202519 442 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 443
d5a19415
JM
4442011-06-22 Jim Meyering <meyering@redhat.com>
445
029529ac 446 Don't leak an XBM-image-sized buffer
d5a19415
JM
447 * image.c (xbm_load): Free the image buffer after using it.
448
a9041e6c
PE
4492011-06-21 Paul Eggert <eggert@cs.ucla.edu>
450
451 Port to Sun C.
452 * composite.c (find_automatic_composition): Omit needless 'return 0;'
453 that Sun C diagnosed.
454 * fns.c (secure_hash): Fix pointer signedness issue.
455 * intervals.c (static_offset_intervals): New function.
456 (offset_intervals): Use it.
457
7f3f739f
LL
4582011-06-21 Leo Liu <sdl.web@gmail.com>
459
460 * deps.mk (fns.o):
461 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
462 sha512.h.
463
464 * fns.c (secure_hash): Rename from crypto_hash_function and change
465 the first arg to accept symbols.
5b66d427 466 (Fsecure_hash): New primitive.
7f3f739f
LL
467 (syms_of_fns): New symbols.
468
76147d94
DD
4692011-06-20 Deniz Dogan <deniz@dogan.se>
470
471 * process.c (Fset_process_buffer): Clarify return value in
472 docstring.
473
7d7d0045
CY
4742011-06-18 Chong Yidong <cyd@stupidchicken.com>
475
476 * dispnew.c (add_window_display_history): Use BVAR.
477
478 * xdisp.c (debug_method_add): Use BVAR.
479 (check_window_end, dump_glyph_matrix, dump_glyph)
480 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
481
482 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
483 Likewise.
484
485 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
486 check till after the cache is created in init_frame_faces.
487
ff2bc410
SM
4882011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
489
490 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
491
28177add
PE
4922011-06-16 Paul Eggert <eggert@cs.ucla.edu>
493
dd3482fe
PE
494 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
495 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
496 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
497
393d71f3 498 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
499 * fileio.c (Finsert_file_contents):
500 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
501 Remove the old (too-loose) buffer overflow checks.
502 They weren't needed, since make_gap checks for buffer overflow.
503 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
504 The old code merely checked for Emacs fixnum overflow, and relied
505 on undefined (wraparound) behavior. The new code avoids undefined
506 behavior, and also checks for ptrdiff_t and/or size_t overflow.
507
2e6813b0 508 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
509 Tune. Don't use wider integers than needed. Don't use alloca.
510 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 511
599a9e4f
PE
512 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
513
99561444
PE
514 * insdel.c, lisp.h (buffer_overflow): New function.
515 (insert_from_buffer_1, replace_range, replace_range_2):
516 * insdel.c (make_gap_larger):
517 * editfns.c (Finsert_char):
518 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
519
28177add
PE
520 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
521
e69dafad
PE
5222011-06-15 Paul Eggert <eggert@cs.ucla.edu>
523
a7af7fde 524 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 525
b1c46f02
PE
526 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
527 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
528
e69dafad
PE
529 * fileio.c: Don't assume EMACS_INT fits in off_t.
530 (emacs_lseek): New static function.
531 (Finsert_file_contents, Fwrite_region): Use it.
532 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
533
566684ea
PE
534 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
535
e6966cd6
PE
536 * fns.c: Don't overflow int when computing a list length.
537 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
538 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
539 truncation on 64-bit hosts. Check for QUIT every
540 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
541 faster and is responsive enough.
542 (Flength): Report an error instead of overflowing an integer.
543 (Fsafe_length): Return a float if the value is not representable
544 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 545 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 546 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 547
dd0b0efb
PE
548 * alloc.c: Check that resized vectors' lengths fit in fixnums.
549 (header_size, word_size): New constants.
550 (allocate_vectorlike): Don't check size overflow here.
551 (allocate_vector): Check it here instead, since this is the only
552 caller of allocate_vectorlike that could cause overflow.
553 Check that the new vector's length is representable as a fixnum.
554
86fe5cfe
PE
555 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
556 The previous code was bogus. For example, next_almost_prime (32)
557 returned 39, which is undesirable as it is a multiple of 3; and
558 next_almost_prime (24) returned 25, which is a multiple of 5 so
559 why was the code bothering to check for multiples of 7?
560
80e88859
PE
561 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
562
4a2f0ad6
PE
563 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
564
f66c7cf8
PE
565 Variadic C functions now count arguments with ptrdiff_t.
566 This partly undoes my 2011-03-30 change, which replaced int with size_t.
567 Back then I didn't know that the Emacs coding style prefers signed int.
568 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
569 were being counted with int, which may truncate counts on 64-bit
570 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
571 * lisp.h (struct Lisp_Subr.function.aMANY)
572 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
573 Arg counts are now ptrdiff_t, not size_t.
574 All variadic functions and their callers changed accordingly.
575 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
576 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
577 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
578 * callint.c (Fcall_interactively): Check arg count for overflow,
579 to avoid potential buffer overrun. Use signed char, not 'int',
580 for 'varies' array, so that we needn't bother to check its size
581 calculation for overflow.
582 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
583 * eval.c (apply_lambda):
584 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
585 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
586 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
587
a1759b76
PE
588 * callint.c (Fcall_interactively): Don't use index var as event count.
589
d96be9fc
PE
590 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
591 * mem-limits.h (SIZE): Remove; no longer used.
592
a690a978 593 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 594
578c21e6
PE
595 Remove unnecessary casts.
596 * xterm.c (x_term_init):
597 * xfns.c (x_set_border_pixel):
598 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
599 These aren't needed now that we assume ANSI C.
600
96f53c6c
PE
601 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
602 It's more likely to cause problems (due to unsigned overflow)
603 than to cure them.
604
83c77d31
PE
605 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
606
ee2079f1
PE
607 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
608
6da65536
PE
609 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
610
7147c4a4
PE
611 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
612
193e32d9
PE
613 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
614
e5533da6
PE
615 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
616
9910e595
PE
617 GLYPH_CODE_FACE returns EMACS_INT, not int.
618 * dispextern.h (merge_faces):
619 * xfaces.c (merge_faces):
01103c44
PE
620 * xdisp.c (get_next_display_element, next_element_from_display_vector):
621 Don't assume EMACS_INT fits in int.
9910e595 622
2638320e
PE
623 * character.h (CHAR_VALID_P): Remove unused parameter.
624 * fontset.c, lisp.h, xdisp.c: All uses changed.
625
045eb8d9
PE
626 * editfns.c (Ftranslate_region_internal): Omit redundant test.
627
c1f134b5
PE
628 * fns.c (concat): Minor tuning based on overflow analysis.
629 This doesn't fix any bugs. Use int to hold character, instead
630 of constantly refetching from Emacs object. Use XFASTINT, not
631 XINT, for value known to be a character. Don't bother comparing
632 a single byte to 0400, as it's always less.
633
395fcb93 634 * floatfns.c (Fexpt):
327eeec8
PE
635 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
636
abbd3d23
PE
637 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
638 for characters.
639
684a03ef
PE
640 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
641
0fed43f3
PE
642 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
643 Without this fix, on a 64-bit host (aset S 0 4294967386) would
644 incorrectly succeed when S was a string, because 4294967386 was
645 truncated before it was used.
646
8fd02eb7
PE
647 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
648 Otherwise, an out-of-range integer could cause undefined behavior
649 on a 64-bit host.
650
f8c86b69
PE
651 * composite.c: Use int, not EMACS_INT, for characters.
652 (fill_gstring_body, composition_compute_stop_pos): Use int, not
653 EMACS_INT, for values that are known to be in character range.
654 This doesn't fix any bugs but is the usual style inside Emacs and
655 may generate better code on 32-bit machines.
656
34206dd2
PE
657 Make sure a 64-bit char is never passed to ENCODE_CHAR.
658 This is for reasons similar to the recent CHAR_STRING fix.
659 * charset.c (Fencode_char): Check that character arg is actually
660 a character. Pass an int to ENCODE_CHAR.
661 * charset.h (ENCODE_CHAR): Verify that the character argument is no
662 wider than 'int', as a compile-time check to prevent future regressions
663 in this area.
664
c5958d4c 665 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
666
667 Make sure a 64-bit char is never passed to CHAR_STRING.
668 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
669 by silently ignoring the top 32 bits, allowing some values
670 that were far too large to be valid characters.
671 * character.h: Include <verify.h>.
672 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
673 arguments are no wider than unsigned, as a compile-time check
674 to prevent future regressions in this area.
675 * data.c (Faset):
01103c44 676 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
677 (Fsubst_char_in_region):
678 * fns.c (concat):
679 * xdisp.c (decode_mode_spec_coding):
680 Adjust to CHAR_STRING's new requirement.
681 * editfns.c (Finsert_char, Fsubst_char_in_region):
682 * fns.c (concat): Check that character args are actually
683 characters. Without this test, these functions did the wrong
684 thing with wildly out-of-range values on 64-bit hosts.
685
d37ca623
PE
686 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
687 These casts should not be needed on 32-bit hosts, either.
688 * keyboard.c (read_char):
689 * lread.c (Fload): Remove casts to unsigned.
690
ea204efb
PE
691 * lisp.h (UNSIGNED_CMP): New macro.
692 This fixes comparison bugs on 64-bit hosts.
693 (ASCII_CHAR_P): Use it.
694 * casefiddle.c (casify_object):
01103c44 695 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
696 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
697 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
698 * dispextern.h (FACE_FROM_ID):
699 * keyboard.c (read_char): Use UNSIGNED_CMP.
700
41cb286c
PE
701 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
702 not to EMACS_INT, to avoid GCC warning.
703
4a1b9832
PE
704 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
705
55daad71
PE
706 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
707 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
708 isn't needed on 32-bit machines.
8f95c75c 709
01103c44
PE
710 * buffer.c (Fgenerate_new_buffer_name):
711 Use EMACS_INT for count, not int.
0ceccced 712 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
713
714 * data.c (Qcompiled_function): Now static.
715
c6f072e7
PE
716 * window.c (window_body_lines): Now static.
717
20ce5912
PE
718 * image.c (gif_load): Rename local to avoid shadowing.
719
9c4c5f81
PE
720 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
721 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
722 * alloc.c (make_save_value): Integer argument is now of type
723 ptrdiff_t, not int.
724 (mark_object): Use ptrdiff_t, not int.
725 * lisp.h (pD): New macro.
726 * print.c (print_object): Use it.
727
c0c5c8ae
PE
728 * alloc.c: Use EMACS_INT, not int, to count objects.
729 (total_conses, total_markers, total_symbols, total_vector_size)
730 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
731 (total_free_floats, total_floats, total_free_intervals)
732 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
733 Now EMACS_INT, not int. All uses changed.
734 (Fgarbage_collect): Compute overall total using a double, so that
735 integer overflow is less likely to be a problem. Check for overflow
736 when converting back to an integer.
5a25e253
PE
737 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
738 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
739 These were 'int' variables that could overflow on 64-bit hosts;
740 they were never used, so remove them instead of repairing them.
211a0b2a 741 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
742 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
743 Previously, this ceilinged at INT_MAX, but that doesn't work on
744 64-bit machines.
e46bb31a 745 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 746
c78baabf 747 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 748 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
749 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
750 when a (possibly-narrower) signed value would do just as well.
751 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 752
c9d624c6
PE
753 * alloc.c: Catch some string size overflows that we were missing.
754 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
755 for convenience in STRING_BYTES_MAX.
756 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
757 The definition here is exact; the one in lisp.h was approximate.
758 (allocate_string_data): Check for string overflow. This catches
759 some instances we weren't catching before. Also, it catches
760 size_t overflow on (unusual) hosts where SIZE_MAX <= min
761 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
762 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 763
c9d624c6
PE
764 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
765 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
766 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
767
353032ce
PE
768 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
769
2bccce07
PE
770 * alloc.c (Fmake_string): Check for out-of-range init.
771
0ac30604
SM
7722011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
773
774 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
775
c195f2de
JD
7762011-06-14 Jan Djärv <jan.h.d@swipnet.se>
777
778 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
779 xg_get_default_scrollbar_width.
780
781 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
782 (int_gtk_range_get_value): Move to the scroll bar part of the file.
783 (style_changed_cb): Call update_theme_scrollbar_width and call
784 x_set_scroll_bar_default_width and xg_frame_set_char_size for
785 all frames (Bug#8505).
786 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
787 Call gtk_window_set_resizable if HAVE_GTK3.
788 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
789 and height if HAVE_GTK3 (Bug#8505).
790 (scroll_bar_width_for_theme): New variable.
791 (update_theme_scrollbar_width): New function.
792 (xg_get_default_scrollbar_width): Move code to
793 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
794 (xg_initialize): Call update_theme_scrollbar_width.
795
796 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
797
798 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
799
e10ac9f1
MR
8002011-06-12 Martin Rudalics <rudalics@gmx.at>
801
802 * frame.c (make_frame): Call other_buffer_safely instead of
803 other_buffer.
804
805 * window.c (temp_output_buffer_show): Call display_buffer with
806 second argument Vtemp_buffer_show_specifiers and reset latter
807 immediately after the call.
808 (Vtemp_buffer_show_specifiers): New variable.
809 (auto_window_vscroll_p, next_screen_context_lines)
810 (Vscroll_preserve_screen_position): Remove leading asterisks from
811 doc-strings.
812
2d3c217e 8132011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 814
7b7f97e8 815 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
816 * buffer.c (Qclone_number): Remove for now, as it's unused.
817 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
818 (record_buffer): Remove unused local.
819 * frame.c (other_visible_frames, frame_buffer_list): Now static.
820 (set_frame_buffer_list): Remove; unused.
821 * frame.h (other_visible_frames): Remove decl.
822 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
823 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
824 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
825 if HAVE_GPM.
826 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
827 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
828 Define only if HAVE_GPM.
829 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
830 (update_hints_inhibit): Remove; never set. All uses removed.
831 * widgetprv.h (emacsFrameClassRec): Remove decl.
832 * window.c (delete_deletable_window): Now returns void, since it
833 wasn't returning anything.
834 (compare_window_configurations): Remove unused locals.
835 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
836 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
837 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
838 the same widths as pointers. This follows up on the 2011-05-06 patch.
839 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
840 * xterm.h: Likewise.
841 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
842
1384b89e
JB
8432011-06-12 Juanma Barranquero <lekktu@gmail.com>
844
845 * makefile.w32-in: Update dependencies.
846 (LISP_H): Add lib/intprops.h.
847
1100a63c
CY
8482011-06-11 Chong Yidong <cyd@stupidchicken.com>
849
850 * image.c (gif_load): Add animation frame delay to the metadata.
851 (syms_of_image): Use DEFSYM. New symbol `delay'.
852
6198ccd0
MR
8532011-06-11 Martin Rudalics <rudalics@gmx.at>
854
855 * window.c (delete_deletable_window): Re-add.
856 (Fset_window_configuration): Rewrite to handle dead buffers and
857 consequently deletable windows.
858 (window_tree, Fwindow_tree): Remove. Supply functionality in
859 window.el.
860 (compare_window_configurations): Simplify code.
861
b6e3633c
AS
8622011-06-11 Andreas Schwab <schwab@linux-m68k.org>
863
1ab0dee5
AS
864 * image.c (imagemagick_load_image): Fix type mismatch.
865 (Fimagemagick_types): Likewise.
866
b6e3633c
AS
867 * window.h (replace_buffer_in_windows): Declare.
868
9397e56f
MR
8692011-06-11 Martin Rudalics <rudalics@gmx.at>
870
871 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
872 Qclone_number. Remove external declaration of Qdelete_window.
873 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
874 code.
875 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
876 Qbuffer_list_update_hook if allowed.
877 (Fother_buffer): Rewrite doc-string. Major rewrite for new
878 buffer list implementation.
879 (other_buffer_safely): New function.
880 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
881 calls to replace_buffer_in_windows and
882 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
883 if allowed.
884 (record_buffer): Inhibit quitting and rewrite using quittable
885 functions. Run Qbuffer_list_update_hook if allowed.
886 (Frecord_buffer, Funrecord_buffer): New functions.
887 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
888 switch-to-buffer to window.el.
889 (bury-buffer): Move to window.el.
890 (Vbuffer_list_update_hook): New variable.
891
892 * lisp.h (other_buffer_safely): Add prototype in buffer.c
893 section.
894
895 * window.h (resize_frame_windows): Move up in code.
896 (Fwindow_frame): Remove EXFUN.
897 (replace_buffer_in_all_windows): Remove prototype.
898 (replace_buffer_in_windows_safely): Add prototype.
899
900 * window.c: Declare Qdelete_window static again. Move down
901 declaration of select_count.
902 (Fnext_window, Fprevious_window): Rewrite doc-strings.
903 (Fother_window): Move to window.el.
904 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
905 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
906 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
907 window.el.
908 (replace_buffer_in_windows): Implement by calling
909 Qreplace_buffer_in_windows.
910 (replace_buffer_in_all_windows): Remove with some functionality
911 moved into replace_buffer_in_windows_safely.
912 (replace_buffer_in_windows_safely): New function.
913 (select_window_norecord, select_frame_norecord): Move in front
914 of run_window_configuration_change_hook. Remove now obsolete
915 declarations.
916 (Fset_window_buffer): Rewrite doc-string. Call
917 Qrecord_window_buffer.
918 (keys_of_window): Move binding for other-window to window.el.
919
b50691aa
CY
9202011-06-11 Chong Yidong <cyd@stupidchicken.com>
921
922 * dispextern.h (struct image): Replace data member, whose int_val
923 and ptr_val fields were not used by anything, with a single
924 lisp_val object.
925
926 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
927 (gif_clear_image, gif_load, imagemagick_load_image)
928 (gs_clear_image, gs_load): Callers changed.
929
3f754b86
PE
9302011-06-10 Paul Eggert <eggert@cs.ucla.edu>
931
cca69397
PE
932 * buffer.h: Include <time.h>, for time_t.
933 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
934
109e28d0
PE
935 Fix minor problems found by static checking.
936
60737f02
PE
937 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
938
4b66faf3
PE
939 Make identifiers static if they are not used in other modules.
940 * data.c (Qcompiled_function, Qframe, Qvector):
941 * image.c (QimageMagick, Qsvg):
942 * minibuf.c (Qmetadata):
943 * window.c (resize_window_check, resize_root_window): Now static.
944 * window.h (resize_window_check, resize_root_window): Remove decls.
945
109e28d0
PE
946 * window.c (window_deletion_count, delete_deletable_window):
947 Remove; unused.
46a4ce9e
PE
948 (window_body_lines): Now static.
949 (Fdelete_other_windows_internal): Mark vars as initialized.
950 Make sure 'resize_failed' is initialized.
951 (run_window_configuration_change_hook): Rename local to avoid shadowing.
952 (resize_window_apply): Remove unused local.
953 * window.h (delete_deletable_window): Remove decl.
954
109e28d0 955 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
956 (imagemagick_load_image): Fix pointer signedness problem by changing
957 last arg from unsigned char * to char *. All uses changed.
958 Also, fix a local for similar reasons.
959 Remove unused locals. Remove locals to avoid shadowing.
960 (fn_rsvg_handle_free): Remove; unused.
961 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 962 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 963
3f754b86
PE
964 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
965
2547adb1
CY
9662011-06-10 Chong Yidong <cyd@stupidchicken.com>
967
968 * image.c (gif_load): Fix omitted cast error introduced by
969 2011-06-06 change.
970
2c8e37d4
MR
9712011-06-10 Martin Rudalics <rudalics@gmx.at>
972
973 * window.h (resize_proportionally, orig_total_lines)
974 (orig_top_line): Remove from window structure.
975 (set_window_height, set_window_width, change_window_heights)
976 (Fdelete_window): Remove prototypes.
977 (resize_frame_windows): Remove duplicate declaration.
978
440a42e3
EZ
9792011-06-10 Eli Zaretskii <eliz@gnu.org>
980
981 * window.h (resize_frame_windows, resize_window_check)
982 (delete_deletable_window, resize_root_window)
983 (resize_frame_windows): Declare prototypes.
984
985 * window.c (resize_window_apply): Make definition be "static" to
986 match the prototype.
987
562dd5e9
MR
9882011-06-10 Martin Rudalics <rudalics@gmx.at>
989
990 * window.c: Remove declarations of Qwindow_size_fixed,
991 window_min_size_1, window_min_size_2, window_min_size,
992 size_window, window_fixed_size_p, enlarge_window, delete_window.
993 Remove static from declaration of Qdelete_window, it's
994 temporarily needed by Fbury_buffer.
995 (replace_window): Don't assign orig_top_line and
996 orig_total_lines.
997 (Fdelete_window, delete_window): Remove. Window deletion is
998 handled by window.el.
999 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1000 Fdelete_window calls with calls to Qdelete_window.
1001 (Fdelete_other_windows): Remove. Deleting other windows is
1002 handled by window.el.
1003 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1004 handled in window.el.
1005 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1006 Window minimum sizes are handled in window.el.
1007 (shrink_windows, size_window, set_window_height)
1008 (set_window_width, change_window_heights, window_height)
1009 (window_width, CURBEG, CURSIZE, enlarge_window)
1010 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1011 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1012 handled in window.el.
1013 (make_dummy_parent): Rename to make_parent_window and give it a
1014 second argument horflag.
1015 (make_window): Don't set resize_proportionally any more.
1016 (Fsplit_window): Remove. Windows are split in window.el.
1017 (save_restore_action, save_restore_orig_size)
1018 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1019 Resize mini windows in window.el.
1020 (grow_mini_window, shrink_mini_window): Implement by calling
1021 Qresize_root_window_vertically, resize_window_check and
1022 resize_window_apply.
1023 (saved_window, Fset_window_configuration, save_window_save): Do
1024 not handle orig_top_line, orig_total_lines, and
1025 resize_proportionally.
1026 (window_min_height, window_min_width): Move to window.el.
1027 (keys_of_window): Move bindings for delete-other-windows,
1028 split-window, delete-window and enlarge-window to window.el.
1029
1030 * buffer.c: Temporarily extern Qdelete_window.
1031 (Fbury_buffer): Temporarily call Qdelete_window instead of
1032 Fdelete_window (Fbury_buffer will move to window.el soon).
1033
1034 * frame.c (set_menu_bar_lines_1): Remove code handling
1035 orig_top_line and orig_total_lines.
1036
1037 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1038 set_window_height but set heights directly.
1039 (change_frame_size_1): Use resize_frame_windows.
1040
1041 * xdisp.c (init_xdisp): Don't use set_window_height but set
1042 heights directly.
1043
1044 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1045 resize_frame_windows instead of change_window_heights and run
1046 run_window_configuration_change_hook.
1047
1048 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1049 instead of change_window_heights and run
1050 run_window_configuration_change_hook.
1051
1a13852e
MR
10522011-06-09 Martin Rudalics <rudalics@gmx.at>
1053
1054 * window.c (replace_window): Rename second argument REPLACEMENT to
1055 NEW. New third argument SETFLAG. Rewrite.
1056 (delete_window, make_dummy_parent): Call replace_window with
1057 third argument 1.
1058 (window_list_1): Move down in code.
1059 (run_window_configuration_change_hook): Move set_buffer part
1060 before select_frame_norecord part in order to unwind correctly.
1061 Rename count1 to count.
1062 (recombine_windows, delete_deletable_window, resize_root_window)
1063 (Fdelete_other_windows_internal)
1064 (Frun_window_configuration_change_hook, make_parent_window)
1065 (resize_window_check, resize_window_apply, Fresize_window_apply)
1066 (resize_frame_windows, Fsplit_window_internal)
1067 (Fdelete_window_internal, Fresize_mini_window_internal): New
1068 functions.
1069 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1070
f3d1777e
MR
10712011-06-08 Martin Rudalics <rudalics@gmx.at>
1072
496e208e
MR
1073 * window.h (window): Add some new members to window structure -
1074 normal_lines, normal_cols, new_total, new_normal, clone_number,
1075 splits, nest, prev_buffers, next_buffers.
1076 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1077 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1078
f3d1777e
MR
1079 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1080 Remove.
496e208e
MR
1081 (make_dummy_parent): Set new members of windows structure.
1082 (make_window): Move down in code. Handle new members of window
1083 structure.
1084 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1085 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1086 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1087 (Fset_window_prev_buffers, Fwindow_next_buffers)
1088 (Fset_window_next_buffers, Fset_window_clone_number): New
1089 functions.
1090 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1091 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1092 Doc-string fixes.
1093 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1094 Argument WINDOW can be now internal window too.
1095 (Fwindow_use_time): Move up in code.
1096 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1097 Rewrite doc-string.
1098 (Fset_window_configuration, saved_window)
1099 (Fcurrent_window_configuration, save_window_save): Handle new
1100 members of window structure.
b9e809c2
MR
1101 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1102 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1103 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1104 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1105 Qget_mru_window, Qresize_root_window,
1106 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1107 Qauto_buffer_name; staticpro them.
f3d1777e 1108
abde8f8c
MR
11092011-06-07 Martin Rudalics <rudalics@gmx.at>
1110
1111 * window.c (Fwindow_total_size, Fwindow_left_column)
1112 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1113 (Fwindow_list_1): New functions.
1114 (window_box_text_cols): Replace with window_body_cols.
1115 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1116 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1117 (delete_window, Fset_window_configuration): Call
1118 delete_all_subwindows with window as argument.
1119 (delete_all_subwindows): Take a window as argument and not a
1120 structure. Rewrite.
190b47e6
MR
1121 (window_loop): Remove handling of GET_LRU_WINDOW and
1122 GET_LARGEST_WINDOW.
1123 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1124
1125 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1126 window_box_text_cols. delete_all_subwindows now takes a
1127 Lisp_Object as argument.
abde8f8c
MR
1128
1129 * indent.c (compute_motion, Fcompute_motion): Use
1130 window_body_cols instead of window_box_text_cols.
1131
fa8a67e6
MR
1132 * frame.c (delete_frame): Call delete_all_subwindows with root
1133 window as argument.
1134
a54e3482
DC
11352011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1136
1137 * fns.c (Fputhash): Document return value.
1138
60002bf5
CY
11392011-06-06 Chong Yidong <cyd@stupidchicken.com>
1140
1141 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1142
0c671da6 11432011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1144
b862a52a 1145 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1146
be44ca6c
PE
1147 Check for overflow when converting integer to cons and back.
1148 * charset.c (Fdefine_charset_internal, Fdecode_char):
1149 Use cons_to_unsigned to catch overflow.
1150 (Fencode_char): Use INTEGER_TO_CONS.
1151 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1152 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1153 * data.c (long_to_cons, cons_to_long): Remove.
1154 (cons_to_unsigned, cons_to_signed): New functions.
1155 These signal an error for invalid or out-of-range values.
1156 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1157 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1158 * font.c (Ffont_variation_glyphs):
1159 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1160 * lisp.h: Include <intprops.h>.
1161 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1162 (cons_to_signed, cons_to_unsigned): New decls.
1163 (long_to_cons, cons_to_long): Remove decls.
1164 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1165 (Fprimitive_undo): Use CONS_TO_INTEGER.
1166 * xfns.c (Fx_window_property): Likewise.
1167 * xselect.c: Include <limits.h>.
1168 (x_own_selection, selection_data_to_lisp_data):
1169 Use INTEGER_TO_CONS.
1170 (x_handle_selection_request, x_handle_selection_clear)
1171 (x_get_foreign_selection, Fx_disown_selection_internal)
1172 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1173 (lisp_data_to_selection_data): Use cons_to_unsigned.
1174 (x_fill_property_data): Use cons_to_signed.
1175 Report values out of range.
1176
d1f3d2af
PE
1177 Check for buffer and string overflow more precisely.
1178 * buffer.h (BUF_BYTES_MAX): New macro.
1179 * lisp.h (STRING_BYTES_MAX): New macro.
1180 * alloc.c (Fmake_string):
1181 * character.c (string_escape_byte8):
1182 * coding.c (coding_alloc_by_realloc):
1183 * doprnt.c (doprnt):
1184 * editfns.c (Fformat):
1185 * eval.c (verror):
1186 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1187 since they may not be the same number.
1188 * editfns.c (Finsert_char):
1189 * fileio.c (Finsert_file_contents):
1190 Likewise for BUF_BYTES_MAX.
1191
dd52fcea
PE
1192 * image.c: Use ptrdiff_t, not int, for sizes.
1193 (slurp_file): Switch from int to ptrdiff_t.
1194 All uses changed.
1195 (slurp_file): Check that file size fits in both size_t (for
1196 malloc) and ptrdiff_t (for sanity and safety).
1197
7f9bbdbb
PE
1198 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1199 if b->modtime has its maximal value.
1200
dfe18f82
PE
1201 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1202
84acfcf0
PE
1203 Don't assume time_t can fit into int.
1204 * buffer.h (struct buffer.modtime): Now time_t, not int.
1205 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1206 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1207
ccd9a01a
PE
1208 Minor fixes for signed vs unsigned integers.
1209 * character.h (MAYBE_UNIFY_CHAR):
1210 * charset.c (maybe_unify_char):
1211 * keyboard.c (read_char, reorder_modifiers):
1212 XINT -> XFASTINT, since the integer must be nonnegative.
1213 * ftfont.c (ftfont_spec_pattern):
1214 * keymap.c (access_keymap, silly_event_symbol_error):
1215 XUINT -> XFASTINT, since the integer must be nonnegative.
1216 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1217 since it makes no difference and we prefer signed.
1218 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1219 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1220 nonnegative.
1221
d6d100dd
SM
12222011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1223
1224 * window.h (Fwindow_frame): Declare.
1225
2b6148e4
PE
12262011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1227
1228 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1229 (SPARE_MEMORY): Always define.
1230 (LARGE_REQUEST): Remove.
1231 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1232
f230ecc9
MR
12332011-06-06 Martin Rudalics <rudalics@gmx.at>
1234
727e958e
MR
1235 * lisp.h: Move EXFUNS for Fframe_root_window,
1236 Fframe_first_window and Fset_frame_selected_window to window.h.
1237
1238 * window.h: Move EXFUNS for Fframe_root_window,
1239 Fframe_first_window and Fset_frame_selected_window here from
1240 lisp.h.
1241
1242 * frame.c (Fwindow_frame, Fframe_first_window)
1243 (Fframe_root_window, Fframe_selected_window)
1244 (Fset_frame_selected_window): Move to window.c.
1245 (Factive_minibuffer_window): Move to minibuf.c.
1246 (Fother_visible_frames_p): New function.
1247
1248 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1249
f230ecc9
MR
1250 * window.c (decode_window, decode_any_window): Move up in code.
1251 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1252 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1253 (Fwindow_buffer): Move up and rewrite doc-string.
1254 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1255 (Fwindow_prev): New functions.
727e958e
MR
1256 (Fwindow_frame): Move here from frame.c. Accept any window as
1257 argument.
1258 (Fframe_root_window, Fframe_first_window)
1259 (Fframe_selected_window): Move here from frame.c. Accept frame
1260 or arbitrary window as argument. Update doc-strings.
1261 (Fminibuffer_window): Move up in code.
1262 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1263 (Fset_frame_selected_window): Move here from frame.c.
1264 Marginal rewrite.
727e958e
MR
1265 (Fselected_window, select_window, Fselect_window): Move up in
1266 code. Minor doc-string fixes.
f230ecc9 1267
4d09bcf6
PE
12682011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1269
1270 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1271 Do not assume that spare memory exists; that assumption is valid
1272 only if SYSTEM_MALLOC.
1273 (LARGE_REQUEST): New macro, so that the issue of large requests
1274 is separated from the issue of spare memory.
1275
810928a2
AS
12762011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1277
172418ad
AS
1278 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1279 format. (Bug#8806)
1280
43f862f7
AS
1281 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1282
810928a2
AS
1283 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1284 before statements.
1285
a059fe24
JD
12862011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1287
1288 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1289
1290 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1291
1292 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1293 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1294
989bf368
JB
12952011-06-05 Juanma Barranquero <lekktu@gmail.com>
1296
1297 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1298
4b80f674
CY
12992011-06-04 Chong Yidong <cyd@stupidchicken.com>
1300
1301 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1302 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1303 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1304 New error handlers.
4b80f674
CY
1305 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1306 Obey Vx_select_enable_clipboard_manager. Catch errors in
1307 x_clipboard_manager_save (Bug#8779).
1308 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1309 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1310
99a33b77 13112011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1312
1313 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1314
99a33b77 13152011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1316
1317 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1318 in the current matrix if keep_current_p is non-zero.
1319
8264569d
EZ
13202011-06-04 Eli Zaretskii <eliz@gnu.org>
1321
1322 * bidi.c (bidi_level_of_next_char): Fix last change.
1323
57f97249
EZ
13242011-06-03 Eli Zaretskii <eliz@gnu.org>
1325
fec2107c 1326 Support bidi reordering of text covered by display properties.
57f97249 1327
fec2107c
EZ
1328 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1329 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1330 (bidi_cache_search, bidi_cache_iterator_state)
1331 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1332 (bidi_level_of_next_char, bidi_move_to_visually_next):
1333 Support character positions inside a run of characters covered by a
fec2107c
EZ
1334 display string.
1335 (bidi_paragraph_init, bidi_resolve_explicit_1)
1336 (bidi_level_of_next_char): Call bidi_fetch_char and
1337 bidi_fetch_char_advance instead of FETCH_CHAR and
1338 FETCH_CHAR_ADVANCE.
1339 (bidi_init_it): Initialize new members.
1340 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1341 definitions.
1342 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1343 instead of using explicit *_CHAR codes.
d6d100dd
SM
1344 (bidi_resolve_explicit, bidi_resolve_weak):
1345 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1346 bidirectional text is supported only in multibyte buffers.
1347 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1348 it to initialize the frame_window_p member of struct bidi_it.
1349 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1350 (bidi_resolve_explicit, bidi_resolve_weak)
1351 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1352 bidi_it->nchars is non-positive.
1353 (bidi_level_of_next_char): Don't try to lookup the cache for the
1354 next/previous character if nothing is cached there yet, or if we
1355 were just reseat()'ed to a new position.
c40e2fb2 1356
0e14fe90
EZ
1357 * xdisp.c (set_cursor_from_row): Set start and stop points
1358 according to the row's direction when priming the loop that looks
1359 for the glyph on which to display cursor.
1360 (single_display_spec_intangible_p): Function deleted.
1361 (display_prop_intangible_p): Reimplement to call
1362 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1363 Accept 3 additional arguments needed by handle_display_spec.
1364 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1365 values: lists, `(when COND...)' forms, etc.
1366 (single_display_spec_string_p): Support property values that are
1367 lists with the argument STRING its top-level element.
1368 (display_prop_string_p): Fix the condition for processing a
1369 property that is a list to be consistent with handle_display_spec.
fec2107c 1370 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1371 last portion of handle_display_prop.
1372 (compute_display_string_pos): Accept additional argument
1373 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1374 value of a `display' property is a "replacing spec".
1375 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1376 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1377 the display property, but just return a value indicating whether
1378 the display property will replace the characters it covers.
1379 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1380 frame_window_p members of struct bidi_it.
d6d100dd
SM
1381 (compute_display_string_pos, compute_display_string_end):
1382 New functions.
fec2107c
EZ
1383 (push_it): Accept second argument POSITION, where pop_it should
1384 jump to continue iteration.
1385 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1386
fec2107c
EZ
1387 * keyboard.c (adjust_point_for_property): Adjust the call to
1388 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1389
1390 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1391 (bidi_init_it): Update prototypes.
1392 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1393 (compute_display_string_pos, compute_display_string_end):
1394 Declare prototypes.
fec2107c
EZ
1395 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1396 EMACS_INT.
fc6f18ce 1397
40087514 13982011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1399
57f53182
PE
1400 Malloc failure behavior now depends on size of allocation.
1401 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1402 * lisp.h: Change signatures accordingly.
1403 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1404 All callers changed. (Bug#8762)
1405
1406 * gnutls.c: Use Emacs's memory allocators.
1407 Without this change, the gnutls library would invoke malloc etc.
1408 directly, which causes problems on non-SYNC_INPUT hosts, and which
1409 runs afoul of improving memory_full behavior. (Bug#8761)
1410 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1411 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1412 xfree instead of the default malloc, realloc, free.
1413 (Fgnutls_boot): No need to check for memory allocation failure,
1414 since xmalloc does that for us.
1415
ac32cd99 1416 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1417 * category.c (hash_get_category_set):
1418 * ccl.c (ccl_driver):
1419 * charset.c (Fdefine_charset_internal):
1420 * charset.h (struct charset.hash_index):
1421 * composite.c (get_composition_id, gstring_lookup_cache)
1422 (composition_gstring_put_cache):
1423 * composite.h (struct composition.hash_index):
1424 * dispextern.h (struct image.hash):
1425 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1426 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1427 (hashfn_equal, hashfn_user_defined, make_hash_table)
1428 (maybe_resize_hash_table, hash_lookup, hash_put)
1429 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1430 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1431 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1432 * image.c (make_image, search_image_cache, lookup_image)
1433 (xpm_put_color_table_h):
1434 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1435 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1436 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1437 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1438 * alloc.c (allocate_vectorlike):
1439 Check for overflow in vector size calculations.
1440 * ccl.c (ccl_driver):
1441 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1442 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1443 need to be updated by these changes.
40087514
PE
1444 * fns.c (make_hash_table, maybe_resize_hash_table):
1445 Check for integer overflow with large hash tables.
0de4bb68
PE
1446 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1447 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1448 (SXHASH_REDUCE): New macro.
1449 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1450 Use it instead of discarding useful hash info with large hash values.
1451 (sxhash_float): New function.
1452 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1453 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1454 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1455 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1456 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1457 Adjust signatures to match updated version of code.
1458 (consing_since_gc): Now EMACS_INT, since a single hash table can
1459 use more than INT_MAX bytes.
1460
698d32e2
DN
14612011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1462
1463 Make it possible to build with GCC-4.6+ -O2 -flto.
1464
1465 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1466
fd6fa53f
SM
14672011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1468
1469 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1470 Call minibuffer-inactive-mode.
1471
864db017
JB
14722011-05-31 Juanma Barranquero <lekktu@gmail.com>
1473
1474 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1475 Update dependencies.
1476
2ad0baf4
DN
14772011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1478
1479 * data.c (init_data): Remove code for UTS, this system is not
1480 supported anymore.
1481
4fcc2638
DN
14822011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1483
1484 Don't force ./temacs to start in terminal mode.
1485
1486 * frame.c (make_initial_frame): Initialize faces in all cases, not
1487 only when CANNOT_DUMP is defined.
1488 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1489
c56e0fd5
DN
14902011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1491
1492 * dispnew.c (add_window_display_history): Use const for the string
1493 pointer. Remove declaration, not needed.
1494
333d54da 14952011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1496
55d4c1b2 1497 Use 'inline', not 'INLINE'.
333d54da 1498 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1499 * alloc.c, fontset.c (INLINE): Remove.
1500 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1501 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1502 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1503 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1504 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1505
738db178
DN
15062011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1507
1508 Make it possible to run ./temacs.
1509
1510 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1511 syms_of_callproc does the same thing. Remove test for
1512 "initialized", do it in the caller.
1513 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1514
620c53a6
SM
15152011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1516
1517 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1518 (read_minibuf): Use get_minibuffer.
1519 (syms_of_minibuf): Use DEFSYM.
1520 (Qmetadata): New var.
1521 * data.c (Qbuffer): Don't make it static.
1522 (syms_of_data): Use DEFSYM.
1523
e003a292
PE
15242011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1525
1526 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1527 (CCL_CODE_MIN): New macro.
1528
ed008a6d
PE
15292011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1530
3687c2ef
PE
1531 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1532
ed008a6d
PE
1533 * eval.c (Qdebug): Now static.
1534 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1535 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1536 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1537
d66c4c7c
CY
15382011-05-29 Chong Yidong <cyd@stupidchicken.com>
1539
1540 * image.c: Various fixes to ImageMagick code comments.
1541 (Fimagemagick_types): Doc fix.
1542
5fbc2025
PE
15432011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1544
0196f88a
PE
1545 Minor fixes prompted by GCC 4.6.0 warnings.
1546
1547 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1548
5fbc2025
PE
1549 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1550 (x_clipboard_manager_save_all): Move extern decl to ...
1551 * xterm.h: ... here, so that it can be checked for consistency.
1552
1dd3c2d9
CY
15532011-05-29 Chong Yidong <cyd@stupidchicken.com>
1554
1555 * xselect.c (x_clipboard_manager_save_frame)
1556 (x_clipboard_manager_save_all): New functions.
1557 (Fx_clipboard_manager_save): Lisp function deleted.
1558
1559 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1560 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1561
1562 * xterm.h: Update prototype.
1563
5ba6571d
WX
15642011-05-28 William Xu <william.xwl@gmail.com>
1565
1566 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1567 exiting (Bug#8239).
1568
3eaff834
JM
15692011-05-28 Jim Meyering <meyering@redhat.com>
1570
e1900994 1571 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1572 * fns.c (to_uchar): Define.
1573 (crypto_hash_function): Use it to convert some newly-signed
1574 variables to unsigned, to avoid sign-extension bugs. For example,
1575 without this change, (md5 "truc") would evaluate to
1576 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1577 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1578 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1579
0f6990a7
PE
15802011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1581
1582 Integer overflow fixes.
c8a9ca5a 1583
08686060
PE
1584 * dbusbind.c: Serial number integer overflow fixes.
1585 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1586 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1587 to hold a serial number that is too large for a fixnum.
1588 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1589 Check for serial numbers out of range. Decode any serial number
59568bf0 1590 that was so large that it became a float. (Bug#8722)
08686060 1591
2d1fc3c7
PE
1592 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1593 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1594 Use XFASTINT rather than XUINT when numbers are nonnegative.
1595 (xd_append_arg, Fdbus_method_return_internal):
1596 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1597 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1598 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1599 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1600 (Bug#8722)
2d1fc3c7 1601
c8a9ca5a
PE
1602 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1603
519e1d69
PE
1604 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1605
30569699
PE
1606 ccl: add integer overflow checks
1607 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1608 (IN_INT_RANGE): New macros.
1609 (ccl_driver): Use them to check for integer overflow when
1610 decoding a CCL program. Many of the new checks are whether XINT (x)
1611 fits in int; it doesn't always, on 64-bit hosts. The new version
1612 doesn't catch all possible integer overflows, but it's an
847044ea 1613 improvement. (Bug#8719)
30569699 1614
c11285dc
PE
1615 * alloc.c (make_event_array): Use XINT, not XUINT.
1616 There's no need for unsigned here.
1617
fdccd48e
PE
1618 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1619 This follows up to the 2011-05-06 change that substituted uintptr_t
1620 for EMACS_INT. This case wasn't caught back then.
1621
37910ab2
PE
1622 Rework Fformat to avoid integer overflow issues.
1623 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1624 now (part of C89). Include <verify.h>.
1625 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1626 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1627 (Fformat): Avoid the prepass trying to compute sizes; it was only
1628 approximate and thus did not catch overflow reliably. Instead, walk
1629 through the format just once, formatting and computing sizes as we go,
1630 checking for integer overflow at every step, and allocating a larger
1631 buffer as needed. Keep track separately whether the format is
1632 multibyte. Keep only the most-recently calculated precision, rather
1633 than them all. Record whether each argument has been converted to
1634 string. Use EMACS_INT, not int, for byte and char and arg counts.
1635 Support field widths and precisions larger than INT_MAX. Avoid
1636 sprintf's undefined behavior with conversion specifications such as %#d
1637 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1638 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1639 formatting out-of-range floating point numbers with int
1640 formats. (Bug#8668)
1641
2e6578fb
PE
1642 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1643
0ae6bdee
PE
1644 * data.c: Avoid integer truncation in expressions involving floats.
1645 * data.c: Include <intprops.h>.
1646 (arith_driver): When there's an integer overflow in an expression
1647 involving floating point, convert the integers to floating point
1648 so that the resulting value does not suffer from catastrophic
1649 integer truncation. For example, on a 64-bit host (* 4
1650 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1651 Do not rely on undefined behavior after integer overflow.
1652
de883a70
PE
1653 merge count_size_as_multibyte, parse_str_to_multibyte
1654 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1655 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1656 Check for integer overflow.
1657 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1658 since it's now a duplicate of the other. This is more of
1659 a character than a buffer op, so better that it's in character.c.
1660 * fns.c, print.c: Adjust to above changes.
1661
2ff916cb
PE
16622011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1663
1664 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1665
f1b54466
PE
16662011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1667
fb1ac845
PE
1668 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1669 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1670 (x_clipboard_manager_save): Now static.
1671 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1672
f1b54466
PE
1673 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1674 (crypto_hash_function): Now static.
1675 Fix pointer signedness problems. Avoid unnecessary initializations.
1676
a9f737ee
CY
16772011-05-27 Chong Yidong <cyd@stupidchicken.com>
1678
1679 * termhooks.h (Vselection_alist): Make it terminal-local.
1680
1681 * terminal.c (create_terminal): Initialize it.
1682
1683 * xselect.c: Support for clipboard managers.
1684 (Vselection_alist): Move to termhooks.h as terminal-local var.
1685 (LOCAL_SELECTION): New macro.
1686 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1687 (symbol_to_x_atom): Remove gratuitous arg.
1688 (x_handle_selection_request, lisp_data_to_selection_data)
1689 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1690 (x_own_selection, x_get_local_selection, x_convert_selection):
1691 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1692 (some_frame_on_display): Delete unused function.
1693 (Fx_own_selection_internal, Fx_get_selection_internal)
1694 (Fx_disown_selection_internal, Fx_selection_owner_p)
1695 (Fx_selection_exists_p): New optional frame arg.
1696 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1697 (x_handle_selection_clear): Don't treat other terminals with the
1698 same keyboard specially. Use the terminal-local Vselection_alist.
1699 (x_clear_frame_selections): Use Frun_hook_with_args.
1700
1701 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1702
1703 * xterm.h: Add support for those atoms.
1704
e067f0c1
CY
17052011-05-26 Chong Yidong <cyd@stupidchicken.com>
1706
1707 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1708 (converted_selections, conversion_fail_tag): New global variables.
1709 (x_selection_request_lisp_error): Free the above.
1710 (x_get_local_selection): Remove unnecessary code.
1711 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1712 of converted selections stored in converted_selections.
1713 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1714 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1715 (x_convert_selection): New function.
1716 (x_handle_selection_event): Simplify.
1717 (x_get_foreign_selection): Don't ignore incoming requests while
1718 waiting for an answer; this will fail when we implement
1719 SAVE_TARGETS, and seems unnecessary anyway.
1720 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1721 (Vx_sent_selection_functions): Doc fix.
1722
0f4aebc0
LL
17232011-05-26 Leo Liu <sdl.web@gmail.com>
1724
1725 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1726
e61124cd
YM
17272011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1728
1729 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1730
1731 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1732 for fringe update if it has periodic bitmap.
1733 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1734 and fringe_bitmap_periodic_p.
1735
1736 * fringe.c (get_fringe_bitmap_data): New function.
1737 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1738 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1739 row. Mark glyph row for fringe update if periodicity changed.
1740
1741 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1742 for fringe update unless it has periodic bitmap.
1743
f16d9837
KH
17442011-05-25 Kenichi Handa <handa@m17n.org>
1745
1746 * xdisp.c (get_next_display_element): Set correct it->face_id for
1747 a static composition.
1748
e1b90ef6
LL
17492011-05-24 Leo Liu <sdl.web@gmail.com>
1750
1751 * deps.mk (fns.o):
1752 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1753
1754 * fns.c (crypto_hash_function, Fsha1): New function.
1755 (Fmd5): Use crypto_hash_function.
1756 (syms_of_fns): Add Ssha1.
1757
7400048f
PE
17582011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1759
1760 * gnutls.c: Remove unused macros.
1761 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1762 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1763 Remove macros that are defined and never used.
1764 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1765
abb71cf4
CY
17662011-05-22 Chong Yidong <cyd@stupidchicken.com>
1767
1768 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1769 (Fx_get_selection_internal): Minor cleanup.
1770 (Fx_own_selection_internal): Rename arguments for consistency with
1771 select.el.
1772
6307db39
PE
17732011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1774
1775 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1776
f3d4e0a4
CY
17772011-05-22 Chong Yidong <cyd@stupidchicken.com>
1778
1779 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1780
4d8ade89
YM
17812011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1782
1783 * dispnew.c (scrolling_window): Don't exclude the case that the
1784 last enabled row in the desired matrix touches the bottom boundary.
1785
32078c8d
GM
17862011-05-21 Glenn Morris <rgm@gnu.org>
1787
1788 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1789 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1790 and add some more files.
32078c8d 1791
7285dc67
EZ
17922011-05-20 Eli Zaretskii <eliz@gnu.org>
1793
1794 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1795 report_file_error introduced by the change from 2011-05-07.
1796
89d1bd22
PE
17972011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1798
1799 * systime.h (Time): Define only if emacs is defined.
1800 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1801 where the include path doesn't have X11/X.h by default. See
1802 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1803
e23640bb 18042011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1805
1806 * composite.c (find_automatic_composition): Fix previous change.
1807
b9704ad9
GM
18082011-05-20 Glenn Morris <rgm@gnu.org>
1809
1810 * lisp.mk: New file, split from Makefile.in.
1811 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1812 (shortlisp): Remove.
1813 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1814
4a720484
GM
18152011-05-19 Glenn Morris <rgm@gnu.org>
1816
1817 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1818 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1819 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1820 (lisp): Set the order to that of loadup.el.
1821 (shortlisp): Make it a copy of $lisp.
1822 (SOME_MACHINE_LISP): Remove.
1823 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1824 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1825
a28d4396
KH
18262011-05-18 Kenichi Handa <handa@m17n.org>
1827
1828 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1829 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1830 (find_automatic_composition): Mostly rewrite for efficiency.
1831
a2b1fa8e
JB
18322011-05-18 Juanma Barranquero <lekktu@gmail.com>
1833
1834 * makefile.w32-in: Update dependencies.
1835
8e1f5610
CS
18362011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1837
1838 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 1839 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1840
7025ee00 18412011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1842
cdfa6eab
PE
1843 Fix some integer overflow issues, such as string length overflow.
1844
06d6db33
PE
1845 * insdel.c (count_size_as_multibyte): Check for string overflow.
1846
2b4560a8
PE
1847 * character.c (lisp_string_width): Check for string overflow.
1848 Use EMACS_INT, not int, for string indexes and lengths; in
1849 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1850 the resulting string length overflows an EMACS_INT; instead,
1851 report a string overflow if no precision given. When checking for
1852 precision exhaustion, use a check that cannot possibly have
1853 integer overflow. (Bug#8675)
1854 * character.h (lisp_string_width): Adjust to new signature.
1855
cb93f9be
PE
1856 * alloc.c (string_overflow): New function.
1857 (Fmake_string): Use it. This doesn't change behavior, but saves
1858 a few bytes and will simplify future changes.
1859 * character.c (string_escape_byte8): Likewise.
1860 * lisp.h (string_overflow): New decl.
1861
1a1f3366
PE
1862 Fixups, following up to the user-interface timestamp change.
1863 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1864 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1865 * msdos.c (mouse_get_pos): Likewise.
1866 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1867 * w32gui.h (Time): Define by including "systime.h" rather than by
1868 declaring it ourselves. (Bug#8664)
1869
d4e3e4d3
PE
1870 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1871 * image.c (clear_image_cache): Likewise.
1872
f6a24d19
PE
1873 * term.c (term_mouse_position): Don't assume time_t wraparound.
1874
08dc5ae6
PE
1875 Be more systematic about user-interface timestamps.
1876 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1877 and sometimes 'EMACS_UINT', to represent these timestamps.
1878 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1879 This makes the code easier to follow, and makes it easier to catch
1880 integer overflow bugs such as Bug#8664.
1881 * frame.c (Fmouse_position, Fmouse_pixel_position):
1882 Use Time, not unsigned long, for user-interface timestamps.
1883 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1884 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1885 * keyboard.h (last_event_timestamp): Likewise.
1886 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1887 * menu.h (xmenu_show): Likewise.
1888 * term.c (term_mouse_position): Likewise.
1889 * termhooks.h (struct input_event.timestamp): Likewise.
1890 (struct terminal.mouse_position_hook): Likewise.
1891 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1892 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1893 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1894 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1895 what it was before.
1896 * menu.h, termhooks.h: Include "systime.h", for Time.
1897
8e55734a
PE
1898 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1899 Don't assume that the difference between two unsigned long values
1900 can fit into an integer. At this point, we know button_down_time
1901 <= event->timestamp, so the difference must be nonnegative, so
1902 there's no need to cast the result if double-click-time is
1903 nonnegative, as it should be; check that it's nonnegative, just in
1904 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1905 apart (about 25 days). (Bug#8664)
8e55734a 1906
841f1b75 1907 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1908 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1909
3e26f69c
PE
1910 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1911 that always fit in int. Use a sentinel instead of a counter, to
1912 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1913 * frame.h (struct frame): Use int for menu_bar_items_used
1914 instead of EMACS_INT, since it always fits in int.
3e26f69c 1915
5cc152c0
PE
1916 * menu.c (grow_menu_items): Check for int overflow.
1917
d89eb65e
PE
1918 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1919
5235bd3e
PE
1920 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1921 Before, the code was not consistent. These values cannot exceed
1922 2**31 - 1 so there's no need to make them unsigned.
1923 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1924 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1925 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1926 as modifiers.
1927 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1928
bc827e23
PE
1929 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1930 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1931 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1932 presumably because the widths might not match.
1933
78eb494e
PE
1934 * window.c (size_window): Avoid needless test at loop start.
1935
04f2d78b
CB
19362011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1937
1938 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1939
d2fc7e3d 19402011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1941
1942 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1943
d2fc7e3d 19442011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1945
1946 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1947 `width' to `bar_area_x' and `bar_area_width', respectively.
1948 (x_scroll_run): Take account of fringe background extension.
1949
04f2d78b
CB
1950 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1951 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1952 `bar_area_width', respectively.
1953 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1954 background extension.
1955
79b70037
GM
19562011-05-10 Jim Meyering <meyering@redhat.com>
1957
1958 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1959
2f142cc5
JB
19602011-05-10 Juanma Barranquero <lekktu@gmail.com>
1961
1962 * image.c (Finit_image_library): Return t for built-in image types,
1963 like pbm and xbm. (Bug#8640)
1964
57679c86
AS
19652011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1966
1967 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1968
888c9e86
EZ
19692011-05-07 Eli Zaretskii <eliz@gnu.org>
1970
b0512a1d
EZ
1971 * w32console.c (Fset_screen_color): Doc fix.
1972 (Fget_screen_color): New function.
1973 (syms_of_ntterm): Defsubr it.
1974
7285dc67
EZ
1975 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1976 unlink the temporary file if Fcall_process didn't create it in the
1977 first place.
1978 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1979 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1980 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1981 cue to call_process_cleanup not to close that handle.
1982
4d3fcc8e
BK
19832011-05-07 Ben Key <bkey76@gmail.com>
1984
1985 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1986 one of two shell specific rules, either bootstrap-temacs-CMD or
1987 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1988 to the previous implementation of the bootstrap-temacs rule.
1989 The bootstrap-temacs-CMD rule is similar to the previous
1990 implementation of the bootstrap-temacs rule except that it
1991 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1992 variable.
1993
1994 These changes, along with some changes to nt/configure.bat,
1995 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1996 earlier fix to add support for --cflags and --ldflags options
1997 that include quotes so that it works whether make uses cmd or
1998 sh as the shell.
1999
b4289b64
MA
20002011-05-06 Michael Albinus <michael.albinus@gmx.de>
2001
2002 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2003 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2004 is a constant.
2005 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2006 a string. Handle both cases.
2007 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2008 (Fdbus_register_method): Use Qinvalid_function.
2009
af4c0e28
JB
20102011-05-06 Juanma Barranquero <lekktu@gmail.com>
2011
2012 * makefile.w32-in: Update dependencies.
2013 (LISP_H): Add inttypes.h and stdin.h.
2014 (PROCESS_H): Add unistd.h.
2015
c51453d9
EZ
20162011-05-06 Eli Zaretskii <eliz@gnu.org>
2017
2018 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2019 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2020
8ff0ac3c 20212011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2022
4c4b566b
PE
2023 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2024
aab2b9b5
PE
2025 * term.c (vfatal): Remove stray call to va_end.
2026 It's not needed and the C Standard doesn't allow it here anyway.
2027
c378da0b
PE
2028 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2029 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2030
288b08c7
PE
2031 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2032 bytes.
2033
e3601888
PE
2034 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2035
db6c0e74
PE
2036 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2037
dd5963ea
PE
2038 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2039
88c9450f
PE
2040 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2041
2f9442b8
PE
2042 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2043
c032b5f8
PE
2044 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2045 * charset.c (Fdefine_charset_internal): Don't initialize
2046 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2047 32-bit int (Bug#8600).
a108c10b
PE
2048
2049 * lread.c (read_integer): Be more consistent with string-to-number.
2050 Use string_to_number to do the actual conversion; this avoids
2051 rounding errors and fixes some other screwups. Without this fix,
2052 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2053 (digit_to_number): Move earlier, for benefit of read_integer.
2054 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2055 not a digit in any supported base. (Bug#8602)
a108c10b 2056
ad5f9eea
PE
2057 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2058
aec1708a
PE
2059 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2060 to match comment at start of function. This also removes a
2061 GCC warning about overflow in a 32+64-bit port.
2062
47be4ab5
PE
2063 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2064
371cac43
PE
2065 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2066 Reported by Stefan Monnier in
2067 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2068 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2069 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2070
d01a7826
PE
2071 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2072 (EMACS_UINTPTR): Likewise, with uintptr_t.
2073
7fd47d5c
PE
2074 * lisp.h: Prefer 64-bit EMACS_INT if available.
2075 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2076 on 32-bit hosts that have 64-bit int, so that they can access
2077 large files.
122b0c86
PE
2078 However, temporarily disable this change unless the temporary
2079 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2080
8727937b
PE
2081 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2082
8ac068ac
PE
2083 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2084 This removes an assumption that EMACS_INT and long are the same
2085 width as pointers. The assumption is true for Emacs porting targets
2086 now, but we want to make other targets possible.
2087 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2088 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2089 In the rest of the code, change types of integers that hold casted
2090 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2091 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2092 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2093 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2094 No need to cast type when ORing.
2095 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2096 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2097 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2098 assume EMACS_INT is the same width as char *.
2099 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2100 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2101 Remove no-longer-needed casts.
2102 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2103 (xg_tool_bar_help_callback, xg_make_tool_item):
2104 Use EMACS_INTPTR to hold an integer
2105 that will be cast to void *; this can avoid a GCC warning
2106 if EMACS_INT is not the same width as void *.
2107 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2108 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2109 (current_message_1, set_message_1):
2110 Use a local to convert to proper width without a cast.
2111 * xmenu.c (dialog_selection_callback): Likewise.
2112
ede49d71
PE
2113 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2114 Also, don't assume VALBITS / RAND_BITS is less than 5,
2115 and don't rely on undefined behavior when shifting a 1 left into
2116 the sign bit.
2117 * lisp.h (get_random): Change signature to match.
2118
2f30ecd0
PE
2119 * lread.c (hash_string): Use size_t, not int, for hash computation.
2120 Normally we prefer signed values; but hashing is special, because
2121 it's better to use unsigned division on hash table sizes so that
2122 the remainder is nonnegative. Also, size_t is the natural width
2123 for hashing into memory. The previous code used 'int', which doesn't
2124 retain enough info to hash well into very large tables.
2125 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2126
2a866e7b
PE
2127 * dbusbind.c: Don't possibly lose pointer info when converting.
2128 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2129 Use XPNTR rather than XHASH, so that the high-order bits of
2130 the pointer aren't lost when converting through void *.
2131
51639eac
PE
2132 * eval.c (Fautoload): Don't double-shift a pointer.
2133
92394119
PE
2134 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2135
dbdb9a7c
JB
21362011-05-06 Juanma Barranquero <lekktu@gmail.com>
2137
2138 * gnutls.c (DEF_GNUTLS_FN):
2139 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2140
db7a0b4f
AS
21412011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2142
2143 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2144 marker. (Bug#8610)
2145
f7ff1b0f 21462011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2147
2148 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2149 New version that can reserve upto 2GB of heap space.
2150
f7ff1b0f 21512011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2152
2153 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2154
639c109b
TZ
21552011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2156
2157 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2158 `gnutls_certificate_set_x509_key_file'.
2159
d2127135
JB
21602011-05-05 Juanma Barranquero <lekktu@gmail.com>
2161
2162 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2163 Update dependencies.
2164
e968f4f3
JB
21652011-05-04 Juanma Barranquero <lekktu@gmail.com>
2166
2167 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2168 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2169 Remove unused parameter `fildes'.
2170 * process.c (read_process_output, send_process): Don't pass it.
2171
84d358f0
JB
21722011-05-04 Juanma Barranquero <lekktu@gmail.com>
2173
2174 Fix previous change: the library cache is defined in w32.c.
2175 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2176 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2177
0898ca10
JB
21782011-05-04 Juanma Barranquero <lekktu@gmail.com>
2179
2180 Implement dynamic loading of GnuTLS on Windows.
2181
2182 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2183 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2184 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2185 Declare.
2186
2187 * gnutls.c (Qgnutls_dll): Define.
2188 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2189 (gnutls_*): Declare function pointers.
2190 (init_gnutls_functions): New function to initialize function pointers.
2191 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2192 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2193 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2194 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2195 (emacs_gnutls_write, emacs_gnutls_read)
2196 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2197 (Fgnutls_available_p): New function.
2198 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2199 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2200 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2201
2202 * image.c: Include w32.h.
2203 (Vimage_type_cache): Delete.
2204 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2205 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2206 (w32_delayed_load): Move to w32.c.
2207
2208 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2209
2210 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2211 (w32_delayed_load): Move from image.c. When loading a library, record
2212 its filename in the :loaded-from property of the library id.
2213 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2214 Initialize and staticpro them.
2215 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2216
2217 * process.c: Include lisp.h before w32.h, not after.
2218 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2219 instead of gnutls_record_check_pending.
2220
2221 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2222
ff4de4aa
TZ
22232011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2224
2225 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2226 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2227 as passed in.
2228
abe95abb
JD
22292011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2230
2231 * xterm.c (x_set_frame_alpha): Do not set property on anything
2232 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2233
e16e55d4
JB
22342011-05-02 Juanma Barranquero <lekktu@gmail.com>
2235
2236 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2237
bafcf6a5
JB
22382011-05-02 Juanma Barranquero <lekktu@gmail.com>
2239
2240 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2241 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2242 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2243 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2244 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2245 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2246 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2247 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2248 (Qgnutls_bootprop_callbacks_verify): Make static.
2249
e7a6747f
AS
22502011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2251
19ed11ba
AS
2252 * callproc.c: Indentation fixup.
2253
e7a6747f 2254 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2255 (wait_for_termination, interruptible_wait_for_termination):
2256 Move after wait_for_termination_1.
e7a6747f 2257
1ef14cb4
LMI
22582011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2259
2260 * sysdep.c (interruptible_wait_for_termination): New function
2261 which is like wait_for_termination, but allows keyboard
2262 interruptions.
2263
2264 * callproc.c (Fcall_process): Add (:file "file") as an option for
2265 the STDOUT buffer.
2266 (Fcall_process_region): Ditto.
2267
330d880c
EZ
22682011-04-30 Eli Zaretskii <eliz@gnu.org>
2269
8db90b73
EZ
2270 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2271 rather than `XVECTOR (FOO)->size'.
2272
330d880c
EZ
2273 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2274 inttypes.h, as a gnulib replacement is used if it not available in
2275 system headers.
2276
15cbd324
EZ
22772011-04-21 Eli Zaretskii <eliz@gnu.org>
2278
2279 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2280 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2281 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2282
2283 * coding.c (coding_alloc_by_realloc): Error out if destination
2284 will grow beyond MOST_POSITIVE_FIXNUM.
2285 (decode_coding_emacs_mule): Abort if there isn't enough place in
2286 charbuf for the composition carryover bytes. Reserve an extra
2287 space for up to 2 characters produced in a loop.
2288 (decode_coding_iso_2022): Abort if there isn't enough place in
2289 charbuf for the composition carryover bytes.
2290
22912011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2292
ae940cca
EZ
2293 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2294 aborting when %lld or %lll format is passed.
2295 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2296 %llo or %llx format is passed. (Bug#8545)
2297
03ab8921
EZ
2298 * window.c (window_scroll_line_based): Use a marker instead of
2299 simple variables to record original value of point. (Bug#7952)
2300
afda1437
EZ
2301 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2302 produced by %s or %c overflows available buffer space. (Bug#8545)
2303
f76dee0c
PE
23042011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2305
2306 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2307 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2308
fdc5744d
JB
23092011-04-28 Juanma Barranquero <lekktu@gmail.com>
2310
2311 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2312
638f053a
JB
23132011-04-28 Juanma Barranquero <lekktu@gmail.com>
2314
2315 * keyboard.c (Qdelayed_warnings_hook): Define.
2316 (command_loop_1): Run `delayed-warnings-hook'
2317 if Vdelayed_warnings_list is non-nil.
2318 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2319 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2320
d178f871
EZ
23212011-04-28 Eli Zaretskii <eliz@gnu.org>
2322
2323 * doprnt.c (doprnt): Don't return value smaller than the buffer
2324 size if the message was truncated. (Bug#8545).
2325
b124fd93
JB
23262011-04-28 Juanma Barranquero <lekktu@gmail.com>
2327
2328 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2329 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2330
e810457d
PE
23312011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2332
2333 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2334
ea51cceb
JB
23352011-04-27 Juanma Barranquero <lekktu@gmail.com>
2336
2337 * makefile.w32-in: Update dependencies.
2338
94dcfacf
EZ
23392011-04-27 Eli Zaretskii <eliz@gnu.org>
2340
2341 Improve `doprnt' and its usage. (Bug#8545)
2342 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2343 `format_end'. Remove support for %l as a conversion specifier.
2344 Don't use xrealloc. Improve diagnostics when the %l size modifier
2345 is used. Update the commentary.
2346
2347 * eval.c (verror): Simplify calculation of size_t.
2348
2349 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2350 messages.
2351
f61f41d7
PE
23522011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2353
2354 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2355 change.
2356
96fb4434
PE
23572011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2358
2359 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2360 This makes this file independent of the recent pseudovector change.
2361
671875da 23622011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2363
69e9b5a3
PE
2364 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2365
b5f869a7 2366 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2367 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2368 Remove unused local.
c8926152 2369 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2370
841a1577 2371 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2372 GCC 4.6.0 optimizes based on type-based alias analysis.
2373 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2374 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2375 != &v->size, and therefore "v->size = 1; b->size = 2; return
2376 v->size;" must therefore return 1. This assumption is incorrect
2377 for Emacs, since it type-puns struct Lisp_Vector * with many other
2378 types. To fix this problem, this patch adds a new type struct
f904488f 2379 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2380 and pseudovectors, and helps optimizing compilers not get fooled
2381 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2382 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2383 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2384 the size member.
eab3844f
PE
2385 (XSETPVECTYPE): Rewrite in terms of new macro.
2386 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2387 This is a bit clearer, and further avoids the possibility of
2388 undesirable aliasing.
2389 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2390 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2391 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2392 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2393 (ASIZE): Now uses header.size rather than size.
2394 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2395 to avoid the hassle of writing XVECTOR (foo)->header.size.
2396 (struct vectorlike_header): New type.
eab3844f
PE
2397 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2398 object, to help avoid aliasing.
2399 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2400 (SUBRP): Likewise, since Lisp_Subr is a special case.
2401 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2402 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2403 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2404 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2405 changed to be "header.size" and "header.next".
2406 * buffer.h (struct buffer): Likewise.
2407 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2408 * frame.h (struct frame): Likewise.
2409 * process.h (struct Lisp_Process): Likewise.
2410 * termhooks.h (struct terminal): Likewise.
2411 * window.c (struct save_window_data, struct saved_window): Likewise.
2412 * window.h (struct window): Likewise.
2413 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2414 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2415 * buffer.c (init_buffer_once): Likewise.
2416 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2417 special case.
2418 * process.c (Fformat_network_address): Use local var for size,
2419 for brevity.
2420
0df1eac5
PE
2421 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2422
847ab9d1 2423 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2424 * data.c (atof): Remove decl; no longer used or needed.
2425 (digit_to_number): Move to lread.c.
2426 (Fstring_to_number): Use new string_to_number function, to be
2427 consistent with how the Lisp reader treats infinities and NaNs.
2428 Do not assume that floating-point numbers represent EMACS_INT
2429 without losing information; this is not true on most 64-bit hosts.
2430 Avoid double-rounding errors, by insisting on integers when
2431 parsing non-base-10 numbers, as the documentation specifies.
2432 * lisp.h (string_to_number): New decl, replacing ...
2433 (isfloat_string): Remove.
bc0a5c13 2434 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2435 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2436 appears to have been a coding error. Similarly, do not accept
2437 strings like +-1e0 as floating point numbers. Do not report
2438 overflow for integer overflows unless the base is not 10 which
2439 means we have no simple and reliable way to continue.
2440 Break out the floating-point parsing into a new
2441 function string_to_number, so that Fstring_to_number parses
2442 floating point numbers consistently with the Lisp reader.
04f2d78b 2443 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2444 (E_CHAR, EXP_INT): Remove, replacing with ...
2445 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2446 (string_to_number): New function, replacing isfloat_string.
2447 This function checks for valid syntax and produces the resulting
2448 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2449 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2450 so that overflow for non-base-10 numbers is reported only when
2451 there's no portable and simple way to convert to floating point.
452f4150 2452
67769ffc
PE
2453 * textprop.c (set_text_properties_1): Rewrite for clarity,
2454 and to avoid GCC warning about integer overflow.
2455
c20db43f
PE
2456 * intervals.h (struct interval): Use EMACS_INT for members
2457 where EMACS_UINT might cause problems. See
2458 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2459 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2460 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2461 All uses changed.
37aa2f85
PE
2462 (offset_intervals): Tell GCC not to worry about length overflow
2463 when negating a negative length.
c20db43f 2464
2538aa2f
PE
2465 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2466 (overrun_check_free): Likewise.
2467
f2d3008d
PE
2468 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2469 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2470 word size.
2471
ec8df744
PE
2472 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2473 (gnutls_make_error): Rename local to avoid shadowing.
2474 (gnutls_emacs_global_deinit): ifdef out; not used.
2475 (Fgnutls_boot): Use const for pointer to readonly storage.
2476 Comment out unused local. Fix pointer signedness problems.
2477
640ee02d
PE
2478 * lread.c (openp): Don't stuff size_t into an 'int'.
2479 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2480 about possible signed overflow.
2481
6048fb2a
PE
2482 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2483 (GDK_KEY_g): Don't define if already defined.
2484 (xg_prepare_tooltip): Avoid pointer signedness problem.
2485 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2486
fa3c87e1
PE
2487 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2488 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2489
2172544b
PE
2490 * xfns.c (Fx_window_property): Simplify a bit,
2491 to make a bit faster and to avoid GCC 4.6.0 warning.
2492 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2493
9b821a21
PE
2494 * fns.c (internal_equal): Don't assume size_t fits in int.
2495
3c616cfa
PE
2496 * alloc.c (compact_small_strings): Tighten assertion a little.
2497
c2982e87
PE
2498 Replace pEd with more-general pI, and fix some printf arg casts.
2499 * lisp.h (pI): New macro, generalizing old pEd macro to other
2500 conversion specifiers. For example, use "...%"pI"d..." rather
2501 than "...%"pEd"...".
2502 (pEd): Remove. All uses replaced with similar uses of pI.
2503 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2504 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2505 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2506 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2507 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2508 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2509 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2510 64-bit hosts.
2511 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2512 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2513 * print.c (safe_debug_print, print_object): Likewise.
2514 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2515 to int.
6f04d126
PE
2516 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2517 avoiding the 0 flag, which is not portable.
c2982e87
PE
2518 * process.c (Fmake_network_process): Use pI to avoid cast.
2519 * region-cache.c (pp_cache): Likewise.
2520 * xdisp.c (decode_mode_spec): Likewise.
2521 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2522 behavior on 64-bit hosts with printf arg.
6f04d126 2523 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2524 (x_stop_queuing_selection_requests): Likewise.
2525 (x_get_window_property): Don't truncate byte count to an 'int'
2526 when tracing.
0b432f21 2527
5e073ec7
PE
2528 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2529 here, since it parses constructs like leading '-' and spaces,
2530 which are not wanted; and it overflows with large numbers.
2531 Instead, simply match F[0-9]+, which is what is wanted anyway.
2532
36372bf9
PE
2533 * alloc.c: Remove unportable assumptions about struct layout.
2534 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2535 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2536 (allocate_vectorlike, make_pure_vector): Use the new macros,
2537 plus offsetof, to remove unportable assumptions about struct layout.
2538 These assumptions hold on all porting targets that I know of, but
2539 they are not guaranteed, they're easy to remove, and removing them
2540 makes further changes easier.
2541
0b432f21
PE
2542 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2543 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2544 (string_overrun_cookie): Now const. Use initializers that
2545 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2546 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2547 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2548 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2549 multiple of sizeof (EMACS_INT); it need not be, if
2550 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2551 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2552
895009e1
JB
25532011-04-26 Juanma Barranquero <lekktu@gmail.com>
2554
2555 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2556
6a7a1b0b
TZ
25572011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2558
2559 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2560 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2561 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2562
841a1577 25632011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2564
2565 * lisp.h (Qdebug): List symbol.
895009e1 2566 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2567 * keyboard.c (debug-on-event): New variable.
2568 (handle_user_signal): Break into debugger when debug-on-event
2569 matches the current signal symbol.
2570
f2d3ba6f
DN
25712011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2572
2573 * alloc.c (check_sblock, check_string_bytes)
2574 (check_string_free_list): Convert to standard C.
2575
42ce4c63
TZ
25762011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2577
2578 * w32.c (emacs_gnutls_push): Fix typo.
2579
825cd63c
EZ
25802011-04-25 Eli Zaretskii <eliz@gnu.org>
2581
fb11d64d
EZ
2582 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2583 "cast to pointer from integer of different size".
2584
825cd63c
EZ
2585 Improve doprnt and its use in verror. (Bug#8545)
2586 * doprnt.c (doprnt): Document the set of format control sequences
2587 supported by the function. Use SAFE_ALLOCA instead of always
2588 using `alloca'.
2589
2590 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2591 is one byte too soon. Don't use xrealloc; instead xfree and
2592 xmalloc anew.
2593
e061a11b
TZ
25942011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2595
2596 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2597 callbacks stage.
2598
2599 * gnutls.c: Renamed global_initialized to
2600 gnutls_global_initialized. Added internals for the
2601 :verify-hostname-error, :verify-error, and :verify-flags
2602 parameters of `gnutls-boot' and documented those parameters in the
2603 docstring. Start callback support.
2604 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2605 unless a fatal error occured. Call gnutls_alert_send_appropriate
2606 on error. Return error code.
2607 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2608 (emacs_gnutls_read): Likewise.
2609 (Fgnutls_boot): Return handshake error code.
2610 (emacs_gnutls_handle_error): New function.
2611 (wsaerror_to_errno): Likewise.
2612
2613 * w32.h (emacs_gnutls_pull): Add prototype.
2614 (emacs_gnutls_push): Likewise.
2615
2616 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2617 (emacs_gnutls_push): Likewise.
2618
26192011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2620
2621 * process.c (wait_reading_process_output): Check if GnuTLS
2622 buffered some data internally if no FDs are set for TLS
2623 connections.
2624
2625 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2626 (LIBS): Link to USER_LIBS.
2627 ($(BLD)/gnutls.$(0)): New target.
2628
fa6996bc
EZ
26292011-04-24 Eli Zaretskii <eliz@gnu.org>
2630
eb35682e
EZ
2631 * xdisp.c (handle_single_display_spec): Rename the
2632 display_replaced_before_p argument into display_replaced_p, to
2633 make it consistent with the commentary. Fix typos in the
2634 commentary.
2635
e2ad650c
EZ
2636 * textprop.c (syms_of_textprop): Remove dead code.
2637 (copy_text_properties): Delete obsolete commentary about an
2638 interface that was deleted long ago. Fix typos in the description
2639 of arguments.
2640
1b2de274
EZ
2641 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2642 to changes in oldXMenu/XMenu.h from 2011-04-16.
2643 <menu_help_message, prev_menu_help_message>: Constify.
2644 (IT_menu_make_room): menu->help_text is now `const char **';
2645 adjust.
2646
2647 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2648 to changes in oldXMenu/XMenu.h from 2011-04-16.
2649 (struct XMenu): Declare `help_text' `const char **'.
2650
2651 * xfaces.c <Qunspecified>: Make extern again.
2652
2653 * syntax.c: Include sys/types.h before including regex.h, as
2654 required by Posix.
2655
762b15be
EZ
2656 * doc.c (get_doc_string): Improve the format passed to `error'.
2657
2658 * doprnt.c (doprnt): Improve commentary.
2659
2660 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2661
2662 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2663 them with etags.
2664
f1052e5d
EZ
2665 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2666 changes in globals.h immediately force recompilation.
762b15be
EZ
2667 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2668 $(CURDIR)/s/ms-w32.h.
2669 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2670
fa6996bc
EZ
2671 * character.c (Fchar_direction): Function deleted.
2672 (syms_of_character): Don't defsubr it.
2673 <char-direction-table>: Deleted.
2674
e6c3da20
EZ
26752011-04-23 Eli Zaretskii <eliz@gnu.org>
2676
2677 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2678 * doprnt.c: Include limits.h.
2679 (SIZE_MAX): New macro.
04f2d78b
CB
2680 (doprnt): Return a size_t value. 2nd arg is now size_t.
2681 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2682 Improve overflow protection. Support `l' modifier for integer
2683 conversions. Support %l conversion. Don't assume an EMACS_INT
2684 argument for integer conversions and for %c.
2685
2686 * lisp.h (doprnt): Restore prototype.
2687
2688 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2689 $(SRC)/character.h.
2690
2691 * Makefile.in (base_obj): Add back doprnt.o.
2692
2693 * deps.mk (doprnt.o): Add back prerequisites.
2694 (callint.o): Depend on character.h.
2695
2696 * eval.c (internal_lisp_condition_case): Include the handler
2697 representation in the error message.
2698 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2699 when breaking from the loop.
2700
2701 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2702
2703 * callint.c (Fcall_interactively): When displaying error message
2704 about invalid control letter, pass the character's codepoint, not
2705 a pointer to its multibyte form. Improve display of the character
2706 in octal and display also its hex code.
2707
2708 * character.c (char_string): Use %x to display the (unsigned)
2709 codepoint of an invalid character, to avoid displaying a bogus
2710 negative value.
2711
2712 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2713 `error', not SYMBOL_NAME itself.
2714
2715 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2716 character arguments to `error'.
2717
2718 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2719 to `error' in error message about FINAL_CHAR argument. Make sure
2720 FINAL_CHAR is a character, and use %c when it is passed as
2721 argument to `error'.
2722
4ffd0d6b 27232011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2724
2725 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2726
2727 * w32.c: Include <time.h>.
2728 (sys_localtime): New function.
2729
4ffd0d6b 27302011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2731
2732 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2733
4ffd0d6b 2734 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2735
4ffd0d6b 27362011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2737
4ffd0d6b
GM
2738 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2739 zombies (Bug#8467).
aac0c6e3 2740
04c56954
EZ
27412011-04-19 Eli Zaretskii <eliz@gnu.org>
2742
2743 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2744 gl_state.e_property when gl_state.object is Qt.
2745
2746 * insdel.c (make_gap_larger): Remove limitation of buffer size
2747 to <= INT_MAX.
2748
16a43933
CY
27492011-04-18 Chong Yidong <cyd@stupidchicken.com>
2750
2751 * xdisp.c (lookup_glyphless_char_display)
2752 (produce_glyphless_glyph): Handle cons cell entry in
2753 glyphless-char-display.
2754 (Vglyphless_char_display): Document it.
2755
2756 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2757 glyphless-char-display.
2758
4581706e
CY
27592011-04-17 Chong Yidong <cyd@stupidchicken.com>
2760
2761 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2762
2763 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2764
2765 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2766 definition for no-X builds.
2767
4887c6e2 27682011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2769
fd35b6f9
PE
2770 Static checks with GCC 4.6.0 and non-default toolkits.
2771
5c1ccb01
PE
2772 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2773
006c5daa
PE
2774 * process.c (keyboard_bit_set): Define only if SIGIO.
2775 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2776 (send_process): Repair possible setjmp clobbering.
2777
efc736d3
PE
2778 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2779
4e2fe2e6
PE
2780 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2781
f97334a2
PE
2782 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2783
4e75f29d
PE
2784 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2785 Define only if needed.
2786
90efadd1
PE
2787 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2788 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2789 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2790
3c647824
PE
2791 * dispextern.h (struct redisplay_interface): Rename param
2792 to avoid shadowing.
e264f262 2793 * termhooks.h (struct terminal): Likewise.
761383f4 2794 * xterm.c (xembed_send_message): Likewise.
3c647824 2795
b58c5c4a
PE
2796 * insdel.c (make_gap_smaller): Define only if
2797 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2798
cad59032
PE
2799 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2800 it.
2801
c339dc2e
PE
2802 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2803 so that we aren't warned about unused symbols.
2804
91a3e27b
PE
2805 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2806
399c71d3 2807 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2808
8ffc96f5
PE
2809 * xfns.c (x_real_positions): Mark locals as initialized.
2810
eef9bc79
PE
2811 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2812
098db9dd
PE
2813 * xterm.c: Fix problems found by static analysis with other toolkits.
2814 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2815 (x_dispatch_event): Declare static if USE_GTK, and
2816 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2817 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2818 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2819 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2820 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2821
eb18f6cc
PE
2822 * xmenu.c (menu_help_callback): Pointer type fixes.
2823 Use const pointers when pointing at readonly data. Avoid pointer
2824 signedness clashes.
2825 (FALSE): Remove unused macro.
2826 (update_frame_menubar): Remove unused decl.
2827
1fe72bf8
PE
2828 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2829
60d9e1db
PE
2830 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2831 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2832 (single_menu_item): Rename local to avoid shadowing.
2833
39261c26
PE
2834 * keyboard.c (make_lispy_event): Remove unused local var.
2835
018c5e19
PE
2836 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2837 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2838
63d2b86e
PE
2839 * bitmaps: Change bitmaps from unsigned char back to the X11
2840 compatible char. Avoid the old compiler warnings about
2841 out-of-range initializers by using, for example, '\xab' rather
2842 than 0xab.
2843
aefd87e1
PE
2844 * xgselect.c (xgselect_initialize): Check vs interface
2845 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2846
bf501fb9
PE
2847 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2848
e9829fdf
PE
2849 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2850 to read-only memory.
2851
1086c095
PE
2852 * fns.c (vector): Remove; this old hack is no longer needed.
2853
2baccd04 2854 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2855 Remove unused var.
dde42981 2856 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2857
72391843 2858 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2859
436c16df 2860 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2861 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2862 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2863
92bb796d 2864 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2865 (x_term_init): Remove local to avoid shadowing.
92bb796d 2866
764430a3 2867 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2868
2869 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2870 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2871
d1dfb56c
EZ
28722011-04-16 Eli Zaretskii <eliz@gnu.org>
2873
c4354cb4
EZ
2874 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2875
d1dfb56c
EZ
2876 Fix regex.c, syntax.c and friends for buffers > 2GB.
2877 * syntax.h (struct gl_state_s): Declare character position members
2878 EMACS_INT.
2879
2880 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2881
04f2d78b
CB
2882 * textprop.c (verify_interval_modification, interval_of):
2883 Declare arguments EMACS_INT.
d1dfb56c
EZ
2884
2885 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2886 EMACS_INT.
2887
2888 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2889
2890 * indent.c (Fvertical_motion): Local variable it_start is now
2891 EMACS_INT.
2892
2893 * regex.c (re_match, re_match_2, re_match_2_internal)
2894 (bcmp_translate, regcomp, regexec, print_double_string)
2895 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2896 (re_compile_pattern, re_exec): Declare arguments and local
2897 variables `size_t' and `ssize_t' and return values `regoff_t', as
2898 appropriate.
2899 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2900 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2901 <compile_stack_type>: `size' and `avail' are now `size_t'.
2902
2903 * regex.h <regoff_t>: Use ssize_t, not int.
2904 (re_search, re_search_2, re_match, re_match_2): Arguments that
2905 specify buffer/string position and length are now ssize_t and
2906 size_t. Return type is regoff_t.
2907
613052cd
BK
29082011-04-16 Ben Key <bkey76@gmail.com>
2909
2910 * nsfont.m: Fixed bugs in ns_get_family and
2911 ns_descriptor_to_entity that were caused by using free to
2912 deallocate memory blocks that were allocated by xmalloc (via
2913 xstrdup). This caused Emacs to crash when compiled with
2914 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2915 --enable-checking=xmallocoverrun). xfree is now used to
2916 deallocate these memory blocks.
2917
4170f62f 29182011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2919
71b41406
PE
2920 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2921
9587a89d
PE
2922 emacs_write: Accept and return EMACS_INT for sizes.
2923 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2924 et seq.
2925 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2926 Accept and return EMACS_INT.
2927 (emacs_gnutls_write): Return the number of bytes written on
2928 partial writes.
2929 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2930 (emacs_read, emacs_write): Remove check for negative size, as the
2931 Emacs source code has been audited now.
9587a89d
PE
2932 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2933 (emacs_read, emacs_write): Use it.
273a5f82
PE
2934 * process.c (send_process): Adjust to the new signatures of
2935 emacs_write and emacs_gnutls_write. Do not attempt to store
2936 a byte offset into an 'int'; it might overflow.
9587a89d 2937 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2938
3e047f51
PE
2939 * sound.c: Don't assume sizes fit in 'int'.
2940 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2941 Return EMACS_INT, not int.
3e047f51 2942 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2943 Accept EMACS_INT, not int.
2944 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2945 record read return values.
2946
cc39a9db
BK
29472011-04-15 Ben Key <bkey76@gmail.com>
2948
c9d0ec6d
JB
2949 * keyboard.c (Qundefined): Don't declare static since it is used
2950 in nsfns.m.
2951 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2952 static since they are used in nsfont.m.
cc39a9db 2953
6c60eb9f
SM
29542011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2955
2956 * process.c (Qprocessp): Don't declare static.
2957 * lisp.h (Qprocessp): Declare again.
2958
7990b61a
JB
29592011-04-15 Juanma Barranquero <lekktu@gmail.com>
2960
2961 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2962
5d4cb038
PE
29632011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2964
8bd7b830 2965 Improve C-level modularity by making more things 'static'.
cd64ea1d 2966
e3b27b31
PE
2967 Don't publish debugger-only interfaces to other modules.
2968 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2969 (verify_bytepos, count_markers): Move decls to the only modules
2970 that need them.
2971 * region-cache.h (pp_cache): Likewise.
2972 * window.h (check_all_windows): Likewise.
2973 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2974
5d4cb038
PE
2975 * sysdep.c (croak): Now static, if
2976 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2977 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2978
2979 * alloc.c (refill_memory_reserve): Now static if
2980 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2981 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2982
e87b6180
PE
2983 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2984 Define only if USE_LUCID.
2985
ac64929e
PE
2986 * xrdb.c (x_customization_string, x_rm_string): Now static.
2987
6f37259d
PE
2988 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2989 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2990
1683e3ab
PE
2991 * xdisp.c (draw_row_with_mouse_face): Now static.
2992 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2993
de9c2632
PE
2994 * window.h (check_all_windows): Mark externally visible.
2995
2b96acb7
PE
2996 * window.c (window_deletion_count): Now static.
2997
2998 * undo.c: Make symbols static if they're not exported.
2999 (last_undo_buffer, last_boundary_position, pending_boundary):
3000 Now static.
3001
50436f33
PE
3002 * textprop.c (interval_insert_behind_hooks): Now static.
3003 (interval_insert_in_front_hooks): Likewise.
3004
64520e5c
PE
3005 * term.c: Make symbols static if they're not exported.
3006 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3007 (max_frame_lines, tty_set_terminal_modes):
3008 (tty_reset_terminal_modes, tty_turn_off_highlight):
3009 (get_tty_terminal): Now static.
3010 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3011 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3012 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3013 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3014 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3015
1fa53021
PE
3016 * sysdep.c: Make symbols static if they're not exported.
3017 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3018 Now static.
3019 (sigprocmask_set, full_mask): Remove; unused.
3020 (wait_debugging): Mark as visible.
3021 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3022 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3023
d4b43b22
PE
3024 * syntax.c (syntax_temp): Define only if !__GNUC__.
3025
b7c513d0
PE
3026 * sound.c (current_sound_device, current_sound): Now static.
3027
989b29ad
PE
3028 * search.c (searchbufs, searchbuf_head): Now static.
3029
13a55a78
PE
3030 * scroll.c (scroll_cost): Remove; unused.
3031 * dispextern.h (scroll_cost): Remove decl.
3032
de68a1fc
PE
3033 * region-cache.h (pp_cache): Mark as externally visible.
3034
40ccffa6
PE
3035 * process.c: Make symbols static if they're not exported.
3036 (process_tick, update_tick, create_process, chan_process):
3037 (Vprocess_alist, proc_buffered_char, datagram_access):
3038 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3039 (deactivate_process): Mark defn as static, as well as decl.
3040 * lisp.h (create_process): Remove decl.
3041 * process.h (chan_process, Vprocess_alist): Remove decls.
3042
ad64fc97
PE
3043 * print.c: Make symbols static if they're not exported.
3044 (print_depth, new_backquote_output, being_printed, print_buffer):
3045 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3046 (print_interval, print_number_index, initial_stderr_stream):
3047 Now static.
3048 * lisp.h (Fprinc): Remove decl.
3049 (debug_output_compilation_hack): Mark as externally visible.
3050
adddb265
PE
3051 * sysdep.c (croak): Move decl from here to syssignal.h.
3052 * syssignal.h (croak): Put it here, so the API can be checked when
3053 'croak' is called from dissociate_if_controlling_tty.
3054
1717ede2
PE
3055 * minibuf.c: Make symbols static if they're not exported.
3056 (minibuf_save_list, choose_minibuf_frame): Now static.
3057 * lisp.h (choose_minibuf_frame): Remove decl.
3058
fa5fb2bc
PE
3059 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3060
1e3890d1
PE
3061 * lread.c: Make symbols static if they're not exported.
3062 (read_objects, initial_obarray, oblookup_last_bucket_number):
3063 Now static.
3064 (make_symbol): Remove; unused.
3065 * lisp.h (initial_obarray, make_symbol): Remove decls.
3066
8a1414fa
PE
3067 * keyboard.c: Make symbols static if they're not exported.
3068 (single_kboard, recent_keys_index, total_keys, recent_keys):
3069 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3070 (this_single_command_key_start, echoing, last_auto_save):
3071 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3072 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3073 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3074 (Vlispy_mouse_stem, double_click_count):
3075 Now static.
3076 (force_auto_save_soon): Define only if SIGDANGER.
3077 (ignore_mouse_drag_p): Now static if
3078 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3079 (print_help): Remove; unused.
3080 (stop_character, last_timer_event): Mark as externally visible.
3081 * keyboard.h (ignore_mouse_drag_p): Declare only if
3082 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3083 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3084 * lisp.h (echoing): Remove decl.
3085 (force_auto_save_soon): Declare only if SIGDANGER.
3086 * xdisp.c (redisplay_window): Simplify code, to make it more
3087 obvious that ignore_mouse_drag_p is not accessed if !defined
3088 USE_GTK && !defined HAVE_NS.
3089
93ea6e8f
PE
3090 * intervals.c: Make symbols static if they're not exported.
3091 (merge_properties_sticky, merge_interval_right, delete_interval):
3092 Now static.
3093 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3094
77382fcc
PE
3095 * insdel.c: Make symbols static if they're not exported.
3096 However, leave prepare_to_modify_buffer alone. It's never
3097 called from outside this function, but that appears to be a bug.
3098 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3099 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3100 (adjust_after_replace_noundo): Remove; unused.
3101 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3102 (signal_before_change): Remove decls.
77382fcc 3103
9306c32e
PE
3104 * indent.c (val_compute_motion, val_vmotion): Now static.
3105
cd44d2eb
PE
3106 * image.c: Make symbols static if they're not exported.
3107 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3108 if USE_GTK.
3109 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3110 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3111
ad9a7a06
PE
3112 * fringe.c (standard_bitmaps): Now static.
3113 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3114
81626931
PE
3115 * frame.c: Make symbols static if they're not exported.
3116 (x_report_frame_params, make_terminal_frame): Now static.
3117 (get_frame_param): Now static, unless HAVE_NS.
3118 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3119 (x_get_resource_string): Remove; not used.
3120 * frame.h (make_terminal_frame, x_report_frame_params):
3121 (x_get_resource_string); Remove decls.
3122 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3123 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3124
239f9db9
PE
3125 * font.c, fontset.c: Make symbols static if they're not exported.
3126 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3127 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3128 * font.c (font_close_object): Now static.
3129 * font.h (font_close_object): Remove.
3130 * fontset.c (FONTSET_OBJLIST): Remove.
3131 (free_realized_fontset) #if-0 the body, which does nothing.
3132 (face_suitable_for_char_p): #if-0, as it's never called.
3133 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3134 * xfaces.c (face_at_string_position):
3135 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3136 since 0 is always ASCII.
3137
dfcf3579
PE
3138 * fns.c (weak_hash_tables): Now static.
3139
5045092b
PE
3140 * fileio.c: Make symbols static if they're not exported.
3141 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3142 (Vwrite_region_annotation_buffers): Now static.
3143
57a96f5c
PE
3144 * eval.c: Make symbols static if they're not exported.
3145 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3146 * lisp.h (backtrace_list): Remove decl.
3147
35f08c38
PE
3148 * emacs.c: Make symbols static if they're not exported.
3149 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3150 (fatal_error_code, fatal_error_signal_hook, standard_args):
3151 Now static.
3152 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3153 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3154 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3155 * lisp.h (fatal_error_signal_hook): Remove decl.
3156 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3157
f44bd759
PE
3158 * editfns.c: Move a (normally-unused) function to its only use.
3159 * editfns.c, lisp.h (get_operating_system_release): Remove.
3160 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3161 worth the hassle of breaking this out.
3162
b532497d
PE
3163 * xterm.c: Make symbols static if they're not exported.
3164 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3165 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3166 (x_destroy_window, x_delete_display):
3167 Now static.
3168 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3169 (x_mouse_leave): Remove; unused.
3170 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3171 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3172 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3173 Remove decls.
3174 (x_mouse_leave): Declare only if WINDOWSNT.
3175 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3176 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3177 USE_X_TOOLKIT.
3178
1675728f
PE
3179 * ftxfont.c: Make symbols static if they're not exported.
3180 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3181 HAVE_FREETYPE.
3182 * font.h (ftxfont_driver): Likewise.
3183
e4cebfca
PE
3184 * xfns.c: Make symbols static if they're not exported.
3185 (x_last_font_name, x_display_info_for_name):
3186 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3187 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3188 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3189 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3190 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3191 (last_show_tip_args): Now static.
3192 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3193 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3194 (x_screen_planes): Remove; unused.
3195 * dispextern.h (x_screen_planes): Remove decl.
3196
5bf46f05
PE
3197 * dispnew.c: Make symbols static if they're not exported.
3198 * dispextern.h (redraw_garbaged_frames, scrolling):
3199 (increment_row_positions): Remove.
3200 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3201 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3202 Now static.
3203 (redraw_garbaged_frames): Remove; unused.
3204
435f4c28
PE
3205 * xfaces.c: Make symbols static if they're not exported.
3206 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3207 Remove decls.
3208 * xterm.h (defined_color): Remove decls.
3209 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3210 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3211 (menu_face_changed_default, defined_color, free_realized_face):
3212 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3213 (ascii_face_of_lisp_face): Remove; unused.
3214
8524aef3
PE
3215 * xdisp.c: Make symbols static if they're not exported.
3216 * dispextern.h (scratch_glyph_row, window_box_edges):
3217 (glyph_to_pixel_coords, set_cursor_from_row):
3218 (get_next_display_element, set_iterator_to_next):
3219 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3220 (show_mouse_face): Remove decls
3221 * frame.h (message_buf_print): Likewise.
3222 * lisp.h (pop_message, set_message, check_point_in_composition):
3223 Likewise.
3224 * xterm.h (set_vertical_scroll_bar): Likewise.
3225 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3226 (message_buf_print, scratch_glyph_row, displayed_buffer):
3227 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3228 (get_next_display_element, show_mouse_face, window_box_edges):
3229 (frame_to_window_pixel_xy, check_point_in_composition):
3230 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3231 (glyph_to_pixel_coords): Remove; unused.
3232
16390cd2
PE
3233 * dired.c (file_name_completion): Now static.
3234
3235 * dbusbind.c (xd_in_read_queued_messages): Now static.
3236
a25f4dfa
PE
3237 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3238 * data.c (circular_list_error): Remove.
3239
14a9c8df
PE
3240 * commands.h (last_point_position, last_point_position_buffer):
3241 (last_point_position_window): Remove decls.
3242 * keyboard.c: Make these variables static.
3243
04f2d78b
CB
3244 * coding.h (coding, code_convert_region, encode_coding_gap):
3245 Remove decls.
74ab6df5
PE
3246 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3247 (iso_code_class, detect_coding, code_convert_region): Now static.
3248 (encode_coding_gap): Remove; unused.
3249
38dfbee1
PE
3250 * chartab.c (chartab_chars, chartab_bits): Now static.
3251
a2cb4e63
PE
3252 * charset.h (charset_iso_8859_1): Remove decl.
3253 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3254 Now static.
3255
127198fd
PE
3256 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3257 * ccl.c (Vccl_program_table): Now static.
3258 (check_ccl_update): Remove; unused.
3259
d85b608f
PE
3260 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3261 * category.h: ... from here.
3262 * category.c (check_category_table, set_category_set): Now static.
3263
31cd66f3
PE
3264 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3265 * lisp.h: Remove these decls.
3266
c358e587
PE
3267 * buffer.c (buffer_count): Remove unused var.
3268
e78aecca
PE
3269 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3270 so that it's not optimized away.
3271 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3272 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3273 exported only to the debugger.
3274
e192d7d3 3275 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3276 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3277
92470028
PE
3278 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3279 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3280 was inaccessible from Lisp.
3281 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3282 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3283
244ed907
PE
3284 alloc.c: Import and export fewer symbols, and remove unused items.
3285 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3286 is defined.
3287 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3288 it's not optimized away by whole-program optimization.
3289 (message_enable_multibyte, free_misc): Remove.
3290 (catchlist, handlerlist, mark_backtrace):
3291 Declare only if BYTE_MARK_STACK.
3292 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3293 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3294 (message_enable_multibyte): Remove decl.
3295 (free_misc, interval_free_list, float_block, float_block_index):
3296 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3297 (cons_free_list, last_marked_index):
3298 Now static.
3299 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3300 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3301 (mark_backtrace): Define only if BYTE_MARK_STACK.
3302 * xdisp.c (message_enable_multibyte): Now static.
3303
61c2b50e 3304 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3305 This makes it easier for human readers (and static analyzers)
3306 to see whether these variables are used from other modules.
3307 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3308 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3309 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3310 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3311 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3312 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3313 * xmenu.c, xselect.c:
3314 Declare Q* vars static if they are not used in other modules.
3315 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3316 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3317 Remove decls of unexported vars.
3318 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3319
95c82688
PE
3320 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3321
16a97296
PE
3322 Make Emacs functions such as Fatom 'static' by default.
3323 This makes it easier for human readers (and static analyzers)
3324 to see whether these functions can be called from other modules.
3325 DEFUN now defines a static function. To make the function external
3326 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3327 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3328 (Finit_image_library):
16a97296
PE
3329 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3330 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3331 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3332 Remove decls, since these functions are now static.
3333 (Funintern, Fget_internal_run_time): New decls, since these functions
3334 were already external.
95c82688 3335
16a97296
PE
3336 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3337 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3338 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3339 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3340 * keyboard.c, keymap.c, lread.c:
3341 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3342 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3343 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3344 Mark functions with DEFUE instead of DEFUN,
3345 if they are used in other modules.
3346 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3347 decls for now-static functions.
3348 * buffer.h (Fdelete_overlay): Remove decl.
3349 * callproc.c (Fgetenv_internal): Mark as internal.
3350 * composite.c (Fremove_list_of_text_properties): Remove decl.
3351 (Fcomposition_get_gstring): New forward static decl.
3352 * composite.h (Fcomposite_get_gstring): Remove decl.
3353 * dired.c (Ffile_attributes): New forward static decl.
3354 * doc.c (Fdocumntation_property): New forward static decl.
3355 * eval.c (Ffetch_bytecode): New forward static decl.
3356 (Funintern): Remove extern decl; now in .h file where it belongs.
3357 * fileio.c (Fmake_symbolic_link): New forward static decl.
3358 * image.c (Finit_image_library): New forward static decl.
3359 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3360 * intervals.h (Fprevious_property_change):
3361 (Fremove_list_of_text_properties): Remove decls.
3362 * keyboard.c (Fthis_command_keys): Remove decl.
3363 (Fcommand_execute): New forward static decl.
3364 * keymap.c (Flookup_key): New forward static decl.
3365 (Fcopy_keymap): Now static.
3366 * keymap.h (Flookup_key): Remove decl.
3367 * process.c (Fget_process): New forward static decl.
3368 (Fprocess_datagram_address): Mark as internal.
3369 * syntax.c (Fsyntax_table_p): New forward static decl.
3370 (skip_chars): Remove duplicate decl.
3371 * textprop.c (Fprevious_property_change): New forward static decl.
3372 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3373 Now internal.
3374 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3375 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3376
785bbd42
PE
3377 * editfns.c (Fformat): Remove unreachable code.
3378
8b913b57
AS
33792011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3380
3381 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3382 change. (Bug#8496)
3383
a6744a35
EZ
33842011-04-13 Eli Zaretskii <eliz@gnu.org>
3385
3386 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3387 when at ZV. (Bug#8487)
3388
e7974947
AS
33892011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3390
baad03f0
AS
3391 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3392 (Bug#8437)
3393 * keyboard.c (parse_tool_bar_item): Likewise.
3394 * sound.c (sound_cleanup, alsa_close): Likewise.
3395 * termcap.c (tgetent): Likewise.
3396 * xfns.c (x_default_font_parameter): Likewise.
3397 * xsettings.c (read_and_apply_settings): Likewise.
3398
e7974947
AS
3399 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3400 (overrun_check_free): Protoize.
3401
28272684
PE
34022011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3403
3404 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3405 since callers should never pass a negative size.
3406 Change the signature to match that of plain 'read' and 'write'; see
3407 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3408 * lisp.h: Update prototypes of emacs_write and emacs_read.
3409
11997c76
EZ
34102011-04-11 Eli Zaretskii <eliz@gnu.org>
3411
3412 * xdisp.c (redisplay_window): Don't try to determine the character
3413 position of the scroll margin if the window start point w->startp
e896f03c 3414 is outside the buffer's accessible region. (Bug#8468)
11997c76 3415
8a2cbd72
EZ
34162011-04-10 Eli Zaretskii <eliz@gnu.org>
3417
3418 Fix write-region and its subroutines for buffers > 2GB.
3419 * fileio.c (a_write, e_write): Modify declaration of arguments and
3420 local variables to support buffers larger than 2GB.
3421 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3422
3423 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3424 argument, local variables, and return value.
3425
3426 * lisp.h: Update prototypes of emacs_write and emacs_read.
3427
3428 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3429
4073e537 34302011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3431
1ebfdcb6
PE
3432 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3433
b2ded58d
PE
3434 Fix more problems found by GCC 4.6.0's static checks.
3435
7d66342c
PE
3436 * xdisp.c (vmessage): Use a better test for character truncation.
3437
bbf47d44
PE
3438 * charset.c (load_charset_map): <, not <=, for optimization,
3439 and to avoid potential problems with integer overflow.
9248994d 3440 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3441 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3442 * editfns.c (Fformat): Likewise.
1e69125e 3443 * syntax.c (skip_chars): Likewise.
3befa583 3444
e3019616
PE
3445 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3446 This also lets GCC 4.6.0 generate slightly better loop code.
3447
becfa255
PE
3448 * callint.c (Fcall_interactively): <, not <=, for optimization.
3449 (Fcall_interactively): Count the number of arguments produced,
3450 not the number of arguments given. This is simpler and lets GCC
3451 4.6.0 generate slightly better code.
3452
dae0cd48
PE
3453 * ftfont.c: Distingish more carefully between FcChar8 and char.
3454 The previous code passed unsigned char * to a functions like
3455 strlen and xstrcasecmp that expect char *, which does not
3456 conform to the C standard.
3457 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3458 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3459 char * when the C standard requires it.
3460
76032d70
PE
3461 * keyboard.c (read_char): Remove unused var.
3462
eb3f1cc8
PE
3463 * eval.c: Port to Windows vsnprintf (Bug#8435).
3464 Include <limits.h>.
3465 (SIZE_MAX): Define if the headers do not.
3466 (verror): Do not give up if vsnprintf returns a negative count.
3467 Instead, grow the buffer. This ports to Windows vsnprintf, which
3468 does not conform to C99. Problem reported by Eli Zaretskii.
3469 Also, simplify the allocation scheme, by avoiding the need for
3470 calling realloc, and removing the ALLOCATED variable.
3471
70476b54
PE
3472 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3473
12020a9e
PE
3474 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3475 But keep the doprint source code for now, as we might revamp it
3476 and use it again (Bug#8435).
ea6c7ae6
PE
3477 * lisp.h (doprnt): Remove.
3478 * Makefile.in (base_obj): Remove doprnt.o.
3479 * deps.mk (doprnt.o): Remove.
3480
5fdb398c
PE
3481 error: Print 32- and 64-bit integers portably (Bug#8435).
3482 Without this change, on typical 64-bit hosts error ("...%d...", N)
3483 was used to print both 32- and 64-bit integers N, which relied on
3484 undefined behavior.
3485 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3486 New macro.
3487 * lisp.h (error, verror): Mark as printf-like functions.
3488 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3489 Report overflow in size calculations when allocating printf buffer.
3490 Do not truncate output string at its first null byte.
3491 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3492 Truncate the output at a character boundary, since vsnprintf does not
3493 do that.
3494 * charset.c (check_iso_charset_parameter): Convert internal
3495 character to string before calling 'error', since %c now has the
3496 printf meaning.
3497 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3498 overflow when computing char to be passed to 'error'. Do not
3499 pass Lisp_Object to 'error'; pass the integer instead.
3500 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3501 formatted with plain %d.
3502
b189fa66
PE
3503 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3504
bff87ef0
PE
3505 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3506
7e2cac20
PE
3507 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3508
ce4d90b5
PE
3509 * xterm.c (x_catch_errors): Remove duplicate declaration.
3510
266c9547
PE
3511 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3512
79c49ad2
PE
3513 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3514
368f4090
JM
35152011-04-10 Jim Meyering <meyering@redhat.com>
3516
3517 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3518 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3519 return ssize_t not "int", and use size_t as the buffer length.
3520 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3521 * gnutls.h: Update declarations.
3522 * process.c (read_process_output): Use ssize_t, to match.
3523 (send_process): Likewise.
3524
a32d4040
CY
35252011-04-09 Chong Yidong <cyd@stupidchicken.com>
3526
3527 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3528
8546720e 35292011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3530
04f2d78b
CB
3531 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3532 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3533
8546720e
GM
3534 * xterm.c (handle_one_xevent):
3535 * xmenu.c (create_and_show_popup_menu):
3536 * xselect.c (x_decline_selection_request)
3537 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3538
0a2f5c1a 35392011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3540
3541 Fix some uses of `int' instead of EMACS_INT.
3542 * search.c (string_match_1, fast_string_match)
3543 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3544 (scan_buffer, find_next_newline_no_quit)
3545 (find_before_next_newline, search_command, Freplace_match)
3546 (Fmatch_data): Make some `int' variables be EMACS_INT.
3547
3548 * xdisp.c (display_count_lines): 3rd argument and return value now
3549 EMACS_INT. All callers changed.
3550 (pint2hrstr): Last argument is now EMACS_INT.
3551
3552 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3553 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3554 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3555 (decode_coding_utf_16, decode_coding_emacs_mule)
3556 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3557 (decode_coding_ccl, decode_coding_charset)
3558 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3559 (decode_coding_iso_2022, decode_coding_emacs_mule)
3560 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3561 <char_offset, last_offset>: Declare EMACS_INT.
3562 (encode_coding_utf_8, encode_coding_utf_16)
3563 (encode_coding_emacs_mule, encode_invocation_designation)
3564 (encode_designation_at_bol, encode_coding_iso_2022)
3565 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3566 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3567 Declare EMACS_INT.
3568 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3569 (encode_invocation_designation): Last argument P_NCHARS is now
3570 EMACS_INT.
3571 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3572 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3573
3574 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3575 All users changed.
3576
3577 * ccl.c (Fccl_execute_on_string): Declare some variables
3578 EMACS_INT.
3579
8546720e 35802011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3581
3582 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3583
4e19a977
CS
35842011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3585
3586 * process.c (Fformat_network_address): Doc fix.
3587
87302331
R
35882011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3589
3590 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3591
cbb59342
CY
35922011-04-08 Chong Yidong <cyd@stupidchicken.com>
3593
3594 * keyboard.c (read_char): Call Lisp function help-form-show,
3595 instead of using internal_with_output_to_temp_buffer.
3596 (Qhelp_form_show): New var.
e0d38eeb 3597 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3598
3599 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3600
3601 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3602
e67a13ab
CY
36032011-04-06 Chong Yidong <cyd@stupidchicken.com>
3604
04f2d78b
CB
3605 * process.c (Flist_processes): Remove to Lisp.
3606 (list_processes_1): Delete.
e67a13ab 3607
973f782d
EZ
36082011-04-06 Eli Zaretskii <eliz@gnu.org>
3609
7c106b1e
EZ
3610 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3611
973f782d
EZ
3612 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3613
41cf7d1a 36142011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3615
ca23cc88
PE
3616 Fix more problems found by GCC 4.6.0's static checks.
3617
f390e2d5
PE
3618 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3619
42eea0d0
PE
3620 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3621
b69769da 3622 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3623
f9541e84
PE
3624 * xdisp.c (vmessage): Mark as a printf-like function.
3625
13841b55
PE
3626 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3627
c136c10f
PE
3628 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3629
5e2d4a30
PE
3630 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3631 printf-like functions.
3632 (tiff_load): Add casts to remove these marks before passing them
3633 to system-supplied API.
3634
583f48b9
PE
3635 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3636
b25d760e
PE
3637 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3638 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3639 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3640 directly, rather than having caller test rule sign. This avoids
3641 some unnecessary tests.
3642 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3643 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3644 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3645
bc7b6697 3646 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3647 (xfont_open): Avoid unnecessary tests.
bc7b6697 3648
27ccc379
PE
3649 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3650
dcd5c89a
PE
3651 * composite.h, composite.c (composition_gstring_put_cache):
3652 Use EMACS_INT, not int, for length.
3653
b13a45c6
PE
3654 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3655 breaking out part of COMPOSITION_DECODE_RULE.
3656 (COMPOSITION_DECODE_RULE): Use it.
3657 * composite.c (get_composition_id): Remove unused local vars,
3658 by using the new macro.
3659
1e792e4d
PE
3660 * textprop.c (set_text_properties_1): Change while to do-while,
3661 since the condition is always true at first.
3662
dc6c6455 3663 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3664 (interval_deletion_adjustment): Return unsigned value.
3665 All uses changed.
dc6c6455 3666
aba7731a
PE
3667 * process.c (list_processes_1, create_pty, read_process_output):
3668 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3669 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3670 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3671 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3672 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3673
fdfc4bf3
PE
3674 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3675
fca8fe46 3676 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3677 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3678
06a0259a 3679 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3680 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3681 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3682
e7b9e80f
PE
3683 * print.c (print_error_message): Avoid int overflow.
3684
56201685
PE
3685 * font.c (font_list_entities): Redo for clarity,
3686 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3687
78834453 3688 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3689 (font_score): Avoid potential overflow in diff calculation.
78834453 3690
0bc0b309 3691 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3692 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3693
e610eaca
PE
3694 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3695
b895abce
PE
3696 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3697 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3698 can always succeed if overflow has undefined behavior.
3699
1f1d9321 3700 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3701 (wordify): Omit three unnecessary tests.
1f1d9321 3702
c59478bc
PE
3703 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3704 All callers changed. This avoids the need for an unused var.
3705
79b73827
PE
3706 * casefiddle.c (casify_region): Remove var that is set but not used.
3707
a4db5dfe
PE
3708 * dired.c (file_name_completion): Remove var that is set but not used.
3709
43aae36e
PE
3710 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3711
2a47c44d 3712 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3713 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3714
a37c69bf
PE
3715 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3716 Check for integer overflow on size calculations.
3717
328ab8e7
PE
3718 * buffer.c (Fprevious_overlay_change): Remove var that is set
3719 but not used.
3720
e5a2a5cb
PE
3721 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3722 Remove vars that are set but not used.
8d84a6eb 3723 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3724 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3725
a60e5f68
PE
3726 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3727
f661cb61 3728 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3729 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3730
f0397f5a
PE
3731 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3732 that are set but not used.
3733
8664db06 3734 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3735 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3736
6abdaa4a
PE
3737 * xselect.c (x_get_local_selection, x_handle_property_notify):
3738 Remove vars that are set but not used.
3739
0ce7538d 3740 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3741 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3742
9ae848fc
PE
3743 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3744 Remove var that is set but not used.
0b918413
PE
3745 (scroll_bar_windows_size): Now size_t, not int.
3746 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3747 Check for overflow.
9ae848fc 3748
a5a62657
PE
3749 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3750 (map_tty_color) [!defined MSDOS]: Likewise.
3751
5c5cdd39
PE
3752 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3753
66ebf983
PE
3754 * coding.c: Remove vars that are set but not used.
3755 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3756 All callers changed.
3757 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3758 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3759 (decode_coding_charset): Remove vars that are set but not used.
3760
1be4d761
PE
3761 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3762 that is set but not used.
3763
47553fa8
PE
3764 * print.c (print_object): Remove var that is set but not used.
3765
1f7196bf 3766 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3767 The gnulib version avoids calling malloc in the usual case,
3768 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3769 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3770 * filelock.c (current_lock_owner): Likewise.
3771 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3772 * sysdep.c: Include allocator.h, careadlinkat.h.
3773 (emacs_no_realloc_allocator): New static constant.
3774 (emacs_readlink): New function.
fdb61804
PE
3775 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3776 ../lib/careadlinkat.h.
d1fdcab7 3777
f84c17c7
SM
37782011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3779
3780 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3781 first non-nil return value).
3782
ef3862ad
JD
37832011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3784
3785 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3786 if not defined (Bug#8403).
3787
376a7006
JB
37882011-04-02 Juanma Barranquero <lekktu@gmail.com>
3789
3790 * xdisp.c (display_count_lines): Remove parameter `start',
3791 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3792 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3793 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3794 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3795 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3796 and thereabouts. All callers changed.
3797 (get_per_char_metric): Remove parameter `f', unused since
3798 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3799
6ca3801d
JM
38002011-04-02 Jim Meyering <meyering@redhat.com>
3801
3802 do not dereference NULL upon failed strdup
3803 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3804 (ns_get_family): Likewise.
3805
d8e2b5ba
JB
38062011-04-02 Juanma Barranquero <lekktu@gmail.com>
3807
3808 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3809
8c74fcbd
JD
38102011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3811
3812 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3813 later (Bug#8403).
3814
7200d79c
SM
38152011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3816
03408648 3817 Add lexical binding.
7200d79c 3818
03408648
SM
3819 * window.c (Ftemp_output_buffer_show): New fun.
3820 (Fsave_window_excursion):
3821 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3822
3823 * lread.c (lisp_file_lexically_bound_p): New function.
3824 (Fload): Bind Qlexical_binding.
3825 (readevalloop): Remove `evalfun' arg.
3826 Bind Qinternal_interpreter_environment.
3827 (Feval_buffer): Bind Qlexical_binding.
3828 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3829 Mark as dynamic.
3830 (syms_of_lread): Declare `lexical-binding'.
3831
3832 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3833
3834 * keyboard.c (eval_dyn): New fun.
3835 (menu_item_eval_property): Use it.
ca105506
SM
3836
3837 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3838
03408648
SM
3839 * fns.c (concat, mapcar1): Accept byte-code-functions.
3840
3841 * eval.c (Fsetq): Handle lexical vars.
3842 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3843 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3844 (FletX, Flet): Obey lexical binding.
3845 (Fcommandp): Handle closures.
3846 (Feval): New `lexical' arg.
3847 (eval_sub): New function extracted from Feval. Use it almost
3848 everywhere where Feval was used. Look up vars in lexical env.
3849 Handle closures.
3850 (Ffunctionp): Move from subr.el.
3851 (Ffuncall): Handle closures.
3852 (apply_lambda): Remove `eval_flags'.
3853 (funcall_lambda): Handle closures and new byte-code-functions.
3854 (Fspecial_variable_p): New function.
3855 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3856 but without exporting it to Lisp.
23aba0ea 3857
23aba0ea 3858 * doc.c (Fdocumentation, store_function_docstring):
03408648 3859 * data.c (Finteractive_form): Handle closures.
23aba0ea 3860
03408648
SM
3861 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3862 interactive spec.
ba83908c 3863
04f2d78b
CB
3864 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3865 New byte-codes.
03408648
SM
3866 (exec_byte_code): New function extracted from Fbyte_code to handle new
3867 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3868
03408648 3869 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3870
03408648 3871 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3872
e2abce01
JB
38732011-03-31 Juanma Barranquero <lekktu@gmail.com>
3874
3875 * xdisp.c (redisplay_internal): Fix prototype.
3876
63696a73 38772011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3878
63696a73 3879 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3880 (try_scrolling): Use it when setting scroll_limit.
3881 Limit scrolling to 100 screen lines.
63696a73
EZ
3882 (redisplay_window): Even when falling back on "recentering",
3883 position point in the window according to scroll-conservatively,
3884 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3885
3886 (try_scrolling): When point is above the window, allow searching
3887 as far as scroll_max, or one screenful, to compute vertical
3888 distance from PT to the scroll margin position. This prevents
3889 try_scrolling from unnecessarily failing when
3890 scroll-conservatively is set to a value slightly larger than the
3891 window height. Clean up the case of PT below the margin at bottom
3892 of window: scroll_max can no longer be INT_MAX. When aggressive
3893 scrolling is in use, don't let point enter the opposite scroll
3894 margin as result of the scroll.
3895 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3896 threshold of 100 lines for never-recentering scrolling.
3897
e4cc2dfc
JB
38982011-03-31 Juanma Barranquero <lekktu@gmail.com>
3899
3900 * dispextern.h (move_it_by_lines):
3901 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3902 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3903 (message_log_check_duplicate): Remove parameters `prev_bol' and
3904 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3905 (redisplay_internal): Remove parameter `preserve_echo_area',
3906 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3907
3908 * indent.c (Fvertical_motion):
3909 * window.c (window_scroll_pixel_based, Frecenter):
3910 Don't pass `need_y_p' to `move_it_by_lines'.
3911
1c470562
SM
39122011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3913
44f230aa
SM
3914 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3915 steal a few bits to be more compact.
3916 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3917 Remove unneeded casts.
3918
1c470562
SM
3919 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3920
888adce9
ZK
39212011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3922
3923 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3924 binding" message (bug#7967).
3925
f838ed7b
PE
39262011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3927
77861b95
PE
3928 Fix more problems found by GCC 4.6.0's static checks.
3929
de6dbc14
PE
3930 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3931 Remove unused local var.
3932
f838ed7b
PE
3933 * editfns.c (Fmessage_box): Remove unused local var.
3934
792c7b2b
PE
3935 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3936 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3937 Omit unused local vars.
c499e557 3938 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3939 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3940 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3941 Omit unused local var.
3942
ba0165e1
PE
3943 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3944 Don't assume string length fits in int.
32ad8845 3945 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3946 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3947
3c59b4c9
PE
3948 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3949 instead of alloca (Bug#8344).
3950
a3eed478 3951 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3952 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3953
eb4d412d
PE
3954 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3955
1658b401
PE
3956 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3957 concerns.
3958
3959 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3960
3961 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3962
9a2c6e05
PE
3963 * keyboard.c (syms_of_keyboard): Use the same style as later
3964 in this function when indexing through an array. This also
3965 works around GCC bug 48267.
3966
03d0a109
PE
3967 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3968
44f730c8
PE
3969 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3970
fe75f926
PE
3971 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3972 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3973
ffa8c828
PE
3974 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3975 This avoids undefined behavior on integer overflow, and is a bit
3976 more convenient anyway since it is compared to a size_t variable.
3977
c5101a77
PE
3978 Variadic C functions now count arguments with size_t, not int.
3979 This avoids an unnecessary limitation on 64-bit machines, which
3980 caused (substring ...) to crash on large vectors (Bug#8344).
3981 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3982 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3983 All variadic functions and their callers changed accordingly.
c5101a77
PE
3984 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3985 * data.c (arith_driver, float_arith_driver): Likewise.
3986 * editfns.c (general_insert_function): Likewise.
3987 * eval.c (struct backtrace.nargs, interactive_p)
3988 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3989 (funcall_lambda, mark_backtrace): Likewise.
3990 * fns.c (concat): Likewise.
3991 * frame.c (x_set_frame_parameters): Likewise.
3992 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3993 0 if not found, not -1. All callers changed.
3994
dd3f25f7
PE
3995 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3996 (stack_copy_size): Now size_t, not int.
3997 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3998
461c2ab9
JB
39992011-03-28 Juanma Barranquero <lekktu@gmail.com>
4000
4001 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4002 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4003 All callers changed.
4004
4005 * lisp.h (multibyte_char_to_unibyte):
4006 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4007 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4008 * character.h (CHAR_TO_BYTE8):
4009 * cmds.c (internal_self_insert):
4010 * editfns.c (general_insert_function):
4011 * keymap.c (push_key_description):
4012 * search.c (Freplace_match):
4013 * xdisp.c (message_dolog, set_message_1): All callers changed.
4014
f6d62986
SM
40152011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4016
4017 * keyboard.c (safe_run_hook_funcall): New function.
4018 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4019 don't set the hook to nil, but remove the offending function instead.
4020 (Qcommand_hook_internal): Remove, unused.
4021 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4022 Vcommand_hook_internal.
4023
4024 * eval.c (enum run_hooks_condition): Remove.
4025 (funcall_nil, funcall_not): New functions.
4026 (run_hook_with_args): Call each function through a `funcall' argument.
4027 Remove `cond' argument, now redundant.
4028 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4029 (Frun_hook_with_args_until_failure): Adjust accordingly.
4030 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4031
1db5b1ad
JB
40322011-03-28 Juanma Barranquero <lekktu@gmail.com>
4033
4034 * dispextern.h (string_buffer_position): Remove declaration.
4035
4036 * print.c (strout): Remove parameter `multibyte', unused since
4037 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4038
4039 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4040 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4041 All callers changed.
4042
4043 * w32.c (_wsa_errlist): Use braces for struct initializers.
4044
4045 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4046 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4047 All callers changed.
4048 (string_buffer_position): Likewise. Also, make static (it's never
4049 used outside xdisp.c).
4050 (cursor_row_p): Remove parameter `w', unused since
4051 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4052 (decode_mode_spec): Remove parameter `precision', introduced during
4053 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4054 All callers changed.
4055
5ffb62aa
JD
40562011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4057
4058 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4059
461c2ab9 40602011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4061
4062 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4063 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4064 (ns_update_auto_hide_menu_bar): New functions.
4065 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4066 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4067 ns_constrain_all_frames.
4068 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4069 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4070
5c380ffb
JD
40712011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4072
4073 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4074
9af30bdf
GM
40752011-03-27 Glenn Morris <rgm@gnu.org>
4076
4077 * syssignal.h: Replace RETSIGTYPE with void.
4078 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4079 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4080 Replace SIGTYPE with void everywhere.
4081 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4082 * s/template.h (SIGTYPE): Remove commented out definition.
4083
e2abce01
JB
40842011-03-26 Eli Zaretskii <eliz@gnu.org>
4085
4086 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4087 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4088
f868cd8a
JB
40892011-03-26 Juanma Barranquero <lekktu@gmail.com>
4090
59eb0929
JB
4091 * w32.c (read_unc_volume): Use parameter `henum', instead of
4092 global variable `wget_enum_handle'.
4093
4094 * keymap.c (describe_vector): Remove parameters `indices' and
4095 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4096 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4097
f868cd8a
JB
4098 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4099
4100 * keyboard.c (timer_check): Remove parameter `do_it_now',
4101 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4102 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4103 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4104
4105 * keyboard.c (read_char):
4106 * w32menu.c (w32_menu_display_help):
4107 * xmenu.c (show_help_event, menu_help_callback):
4108 Adjust calls to `show_help_echo'.
4109
4110 * gtkutil.c (xg_maybe_add_timer):
4111 * keyboard.c (readable_events):
4112 * process.c (wait_reading_process_output):
4113 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4114
4115 * insdel.c (adjust_markers_gap_motion):
4116 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4117 (gap_left, gap_right): Don't call it.
4118
2ecf6fdb
CY
41192011-03-25 Chong Yidong <cyd@stupidchicken.com>
4120
4121 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4122 incurred during fontification.
4123
6b1f9ba4
JB
41242011-03-25 Juanma Barranquero <lekktu@gmail.com>
4125
4126 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4127 (DEFVAR_PER_BUFFER): Don't pass it.
4128
4129 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4130 (scrolling_window): Don't pass it.
4131
0f4a96b5
JB
41322011-03-25 Juanma Barranquero <lekktu@gmail.com>
4133
4134 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4135
4136 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4137 and `suffix'.
4138 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4139 of variables specific to SELinux and computation of `encoded_absname'.
4140
4141 * image.c (XPutPixel): Remove unused variable `height'.
4142
4143 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4144
4145 * unexw32.c (get_section_info): Remove unused variable `section'.
4146
4147 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4148 (system_process_attributes): Remove unused variable `sess'.
4149 (sys_read): Remove unused variable `err'.
4150
4151 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4152 (w32_wnd_proc): Remove unused variable `isdead'.
4153 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4154 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4155 (x_create_tip_frame): Remove unused variable `tem'.
4156
4157 * w32inevt.c (w32_console_read_socket):
4158 Remove unused variable `no_events'.
4159
4160 * w32term.c (x_draw_composite_glyph_string_foreground):
4161 Remove unused variable `width'.
4162
1149507c
JB
41632011-03-24 Juanma Barranquero <lekktu@gmail.com>
4164
4165 * w32term.c (x_set_glyph_string_clipping):
4166 Don't pass uninitialized region to CombineRgn.
4167
9c88f339
JB
41682011-03-23 Juanma Barranquero <lekktu@gmail.com>
4169
4170 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4171 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4172 (Fx_close_connection): Remove unused variable `i'.
4173
4174 * w32font.c (w32font_draw): Return number of glyphs.
4175 (w32font_open_internal): Remove unused variable `i'.
4176 (w32font_driver): Add missing initializer.
4177
4178 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4179 (fill_in_menu): Remove unused variable `items_added'.
4180
4181 * w32term.c (last_mouse_press_frame): Remove static global variable.
4182 (w32_clip_to_row): Remove unused variable `f'.
4183 (x_delete_terminal): Remove unused variable `i'.
4184
4185 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4186 (NOTHING): Remove unused static global variable.
4187 (uniscribe_check_otf): Remove unused variable `table'.
4188 (uniscribe_font_driver): Add missing initializers.
4189
dee091a3
JD
41902011-03-23 Julien Danjou <julien@danjou.info>
4191
4192 * term.c (Fsuspend_tty, Fresume_tty):
4193 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4194 * window.c (temp_output_buffer_show):
4195 * insdel.c (signal_before_change):
4196 * frame.c (Fhandle_switch_frame):
4197 * fileio.c (Fdo_auto_save):
4198 * emacs.c (Fkill_emacs):
4199 * editfns.c (save_excursion_restore):
4200 * cmds.c (internal_self_insert):
4201 * callint.c (Fcall_interactively):
4202 * buffer.c (Fkill_all_local_variables):
4203 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4204 Use Frun_hooks.
0f4a96b5 4205 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4206 unconditionnaly since it does the check itself.
4207
2c520ab5 42082011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4209
c9c49752
PE
4210 Fix more problems found by GCC 4.5.2's static checks.
4211
8abc3f12
PE
4212 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4213 the first time through the loop, since we know p0 < p1 then.
4214 This also avoids a gcc -Wstrict-overflow warning.
4215
a2d26660
PE
4216 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4217 leading to a memory leak, possible in functions like
4218 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4219 of objects (Bug#8318).
a2d26660 4220
916c72e9
PE
4221 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4222 that could (at least in theory) be that large.
4223
19ab8a18
PE
4224 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4225 This is less likely to overflow, and avoids undefined behavior if
4226 overflow does occur. All callers changed. Use strtoul to scan
4227 for the unsigned long integer.
b7cbbd6f
PE
4228 (pint2hrstr): Simplify and tune code slightly.
4229 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4230
f0641eff
PE
4231 * scroll.c (do_scrolling): Work around GCC bug 48228.
4232 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4233
7f650bb9
PE
4234 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4235 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4236 (validate_x_resource_name): Simplify count usage.
4237 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4238
37dd57d1
PE
4239 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4240 fail (Bug#8306).
81e56e61 4241
699979fc 4242 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4243
401bf9b4
PE
4244 * process.c (Fmake_network_process): Use socklen_t, not int,
4245 where POSIX says socklen_t is required in portable programs.
4246 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4247 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4248 (Fmake_network_process, server_accept_connection):
4249 (wait_reading_process_output, read_process_output):
4250 Likewise.
4251
b93aacde
PE
4252 * process.c: Rename or move locals to avoid shadowing.
4253 (list_processes_1, Fmake_network_process):
4254 (read_process_output_error_handler, exec_sentinel_error_handler):
4255 Rename or move locals.
4dc343ee 4256 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4257 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4258 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4259 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4260 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4261
af8a867c 4262 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4263 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4264 Include tparam.h instead, since it declares them.
af8a867c
PE
4265 * cm.h (PC): Remove extern decl; tparam.h now does this.
4266 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4267 * terminfo.c: Include tparam.h, to check interfaces.
4268 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4269 (tparam): Adjust signature to match interface in tparam.h;
4270 this removes some undefined behavior. Check that outstring and len
4271 are zero, which they always are with Emacs.
4272 * tparam.h (PC, BC, UP): New extern decls.
4273
0248044d 4274 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4275 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4276
8ff096c1 4277 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4278 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4279 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4280 (ftfont_list): Remove unused local.
49eaafba
PE
4281 (get_adstyle_property, ftfont_pattern_entity):
4282 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4283 Rename locals to avoid shadowing.
8ff096c1 4284
e2be39f6
PE
4285 * xfont.c (xfont_list_family): Mark var as initialized.
4286
c9735e30
PE
4287 * xml.c (make_dom): Now static.
4288
8f5201ae
PE
4289 * composite.c (composition_compute_stop_pos): Rename local to
4290 avoid shadowing.
b246f932
PE
4291 (composition_reseat_it): Remove unused locals.
4292 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4293 (composition_update_it): Mark var as initialized.
11b61122
PE
4294 (find_automatic_composition): Mark vars as initialized,
4295 with a FIXME (Bug#8290).
8f5201ae 4296
760fbc2c
PE
4297 character.h: Rename locals to avoid shadowing.
4298 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4299 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4300 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4301 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4302 to avoid shadowing.
4303
ff08eb85
PE
4304 * textprop.c (property_change_between_p): Remove; unused.
4305
fc7bf025
PE
4306 * intervals.c (interval_start_pos): Now static.
4307
235d7abc
PE
4308 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4309
44f230aa
SM
4310 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4311 Rename locals to avoid shadowing.
3e7d6594 4312
50060332
PE
4313 * sound.c (wav_play, au_play, Fplay_sound_internal):
4314 Fix pointer signedness.
d01f234b 4315 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4316 (wav_play): Initialize a variable to 0, to prevent undefined
4317 behavior (Bug#8278).
50060332 4318
c4fc4e30
PE
4319 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4320
918436ed
PE
4321 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4322
c939f91b
PE
4323 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4324 clobbering (Bug#8298).
b9c7f648
PE
4325 * sysdep.c (sys_subshell): Likewise.
4326 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4327
6bd8c144
PE
4328 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4329 This should get cleaned up, so that child_setup has the
4330 same signature on all platforms.
4331
7710357c 4332 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4333 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4334
c59da222
CY
43352011-03-22 Chong Yidong <cyd@stupidchicken.com>
4336
4337 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4338 not to be necessary, and produces flickering.
4339
66b87493
GM
43402011-03-20 Glenn Morris <rgm@gnu.org>
4341
4342 * config.in: Remove file.
4343
45b6f6d5
JB
43442011-03-20 Juanma Barranquero <lekktu@gmail.com>
4345
4346 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4347 are now in src/globals.h.
4348 (syms_of_minibuf): Remove spurious & from previous change.
4349
3ec03f7e
LL
43502011-03-20 Leo <sdl.web@gmail.com>
4351
4352 * minibuf.c (completing-read-function): New variable.
4353 (completing-read-default): Rename from completing-read.
4354 (completing-read): Call completing-read-function.
4355
b14e3e21
CY
43562011-03-19 Juanma Barranquero <lekktu@gmail.com>
4357
4358 * xfaces.c (Fx_load_color_file):
4359 Read color file from absolute filename (bug#8250).
4360
f2b726e6
JB
43612011-03-19 Juanma Barranquero <lekktu@gmail.com>
4362
4363 * makefile.w32-in: Update dependencies.
4364
09f6ff02
EZ
43652011-03-17 Eli Zaretskii <eliz@gnu.org>
4366
4367 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4368
29a6015a
PE
43692011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4370
a3a6c54e
PE
4371 Fix more problems found by GCC 4.5.2's static checks.
4372
b766f867
PE
4373 * process.c (make_serial_process_unwind, send_process_trap):
4374 (sigchld_handler): Now static.
4375
be02381c
PE
4376 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4377 That way, the code declares only the vars that it needs.
4378 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4379 * s/cygwin.h (PTY_ITERATION): Likewise.
4380 * s/darwin.h (PTY_ITERATION): Likewise.
4381 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4382
57048744
PE
4383 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4384 * process.c (allocate_pty): Don't declare stb unless it's needed.
4385
7914961c 4386 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4387 (CONSTANTLIM): Remove; unused.
4388 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4389 Define only if needed.
7914961c 4390
b3967b18
PE
4391 * unexelf.c (unexec): Name an expression,
4392 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4393 Use a different way to cause a compilation error if anyone uses
4394 n rather than nn, a way that does not involve shadowing.
73366a00 4395 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4396
29a6015a
PE
4397 * deps.mk (unexalpha.o): Remove; unused.
4398
43cfc33e 4399 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4400 * unexec.h: New file.
ce701a33
PE
4401 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4402 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4403 Depend on unexec.h.
4404 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4405 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4406 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4407 Change as necessary to match prototype in unexec.h.
ce701a33 4408
01f44d5a
PE
4409 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4410 shadowing.
4f63c6bb 4411 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4412
a6670b0b
PE
4413 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4414 Rename locals to avoid shadowing.
4415
cef2010d 4416 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4417 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4418
d4d7173a
PE
4419 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4420
f08b802a
PE
4421 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4422 warning when compiling print.c.
4423
3ddb0639
PE
4424 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4425 instead of using an uninitialized var.
5ad03b97 4426 (font_sort_entities): Mark var as initialized.
3ddb0639 4427
170a2692
PE
4428 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4429
e663c700
PE
4430 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4431 pointers to constants.
89bc529a 4432 (font_parse_fcname): Remove unused vars.
7b81e2d0 4433 (font_delete_unmatched): Now static.
ea838e10 4434 (font_get_spec): Remove; unused.
13a547c6
PE
4435 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4436 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4437 Rename or move locals to avoid shadowing.
e663c700 4438
2a80c887 4439 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4440 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4441
1384fa33 4442 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4443 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4444
8b2c52e9
PE
4445 * alloc.c (mark_backtrace): Move decl from here ...
4446 * lisp.h: ... to here, so that it can be checked.
4447
475545b5 4448 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4449 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4450 (lisp_indirect_variable): Name an expression,
4451 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4452 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4453
b1349114 4454 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4455 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4456 Use const pointer when appropriate.
b1349114 4457
a2928364
PE
4458 * lisp.h (get_system_name, get_operating_system_release):
4459 Move decls here, to check interfaces.
4460 * process.c (get_operating_system_release): Move decl to lisp.h.
4461 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4462 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4463 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4464 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4465 (Fformat_time_string, Fencode_time, Finsert_char):
4466 (Ftranslate_region_internal, Fformat):
4467 Rename or remove local vars to avoid shadowing.
9710023e 4468 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4469
a415e694
PE
4470 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4471 avoid shadowing.
4472
8ef4622d
PE
4473 * lisp.h (eassert): Check that the argument compiles, even if
4474 ENABLE_CHECKING is not defined.
4475
946f9a5b
PE
4476 * data.c (Findirect_variable): Name an expression, to avoid
4477 gcc -Wbad-function-cast warning.
112396d6 4478 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4479 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4480 (Fmake_variable_buffer_local, Fmake_local_variable):
4481 Mark variables as initialized.
52746918 4482 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4483
e5aab7e7 4484 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4485 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4486 Rename locals to avoid shadowing.
dff45157
PE
4487 (mark_stack): Move local variables into the #ifdef region where
4488 they're used.
7bc26fdb
PE
4489 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4490 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4491 needed otherwise.
4492 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4493 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4494 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4495
e5aab7e7
PE
4496 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4497 avoids undefined behavior in theory.
4498
4da60324
PE
4499 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4500
88043301
PE
4501 Use functions, not macros, for up- and down-casing (Bug#8254).
4502 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4503 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4504 to use the following functions instead of these macros.
4505 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4506 EMACS_INT, since callers assume the returned value fits in int.
4507 (upcase1): Likewise, for UPCASE_TABLE.
4508 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4509 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4510 the race-condition problem in the old DOWNCASE.
88043301 4511
19ed5445
PE
4512 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4513 Rename locals to avoid shadowing.
4514 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4515 (regex_compile, re_search_2, re_match_2_internal):
4516 Remove unused local vars.
952db0d7
PE
4517 (FREE_VAR): Rewrite so as not to use empty "else",
4518 which gcc can warn about.
da053e48 4519 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4520 (RETALLOC_IF): Define only if needed.
4521 (WORDCHAR_P): Likewise. This one is never needed, but is used
4522 only in a comment talking about a compiler bug, so put inside
4523 the #if 0 of that comment.
4524 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4525 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4526 Remove; unused.
19ed5445 4527
1f3561e4 4528 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4529 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4530 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4531
ded6f8f7
PE
4532 * search.c (simple_search): Remove unused var.
4533
dbd37a95
PE
4534 * dired.c (compile_pattern): Move decl from here ...
4535 * lisp.h: ... to here, so that it can be checked.
4536 (struct re_registers): New forward decl.
4537
7e47afad
PE
4538 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4539
85f24f61
PE
4540 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4541 All uses changed.
4542 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4543 Rename locals to avoid shadowing.
5671df8f 4544 (Fvertical_motion): Mark locals as initialized.
85f24f61 4545
181aa2be 4546 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4547 (casify_region): Mark local as initialized.
181aa2be 4548
930d429c
PE
4549 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4550
7082eac6
PE
4551 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4552 New macros, so that the caller can use some names other than
4553 gcpro1, gcpro2, etc.
4554 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4555 of the new macros.
4556 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4557 argument, for consistency with GCPRO2_VAR, etc: it is now the
4558 prefix of the variable, not the variable itself. All uses
4559 changed.
38b2c076
PE
4560 * dired.c (directory_files_internal, file_name_completion):
4561 Rename locals to avoid shadowing.
4562
15206ed9
PE
4563 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4564 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4565 dired.c's scmp function, had undefined behavior.
4566 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4567 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4568 * buffer.h: ... to here, because these macros use current_buffer,
4569 and the new implementation with inline functions needs to have
4570 current_buffer in scope now, rather than later when the macros
4571 are used.
4572 (downcase, upcase1): New static inline functions.
4573 (DOWNCASE, UPCASE1): Reimplement using these functions.
4574 This avoids undefined behavior in expressions like
4575 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4576 from race conditions in accessing the global variables
4577 case_temp1 and case_temp2.
4578 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4579 * lisp.h (case_temp1, case_temp2): Remove their decls.
4580 * character.h (ASCII_CHAR_P): Move from here ...
4581 * lisp.h: ... to here, so that the inline functions mentioned
4582 above can use them.
4583
4a6bea26
PE
4584 * dired.c (directory_files_internal_unwind): Now static.
4585
f14b7e14
PE
4586 * fileio.c (file_name_as_directory, directory_file_name):
4587 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4588 Now static.
2893f146
PE
4589 (file_name_as_directory): Use const pointers when appropriate.
4590 (Fexpand_file_name): Likewise. In particular, newdir might
4591 point at constant storage, so make it a const pointer.
fd4ead52 4592 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4593 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4594 signedness issues.
f839df0c
PE
4595 (Fset_file_times, Finsert_file_contents, auto_save_error):
4596 Rename locals to avoid shadowing.
f14b7e14 4597
5716756e 4598 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4599 (Ftry_completion, Fall_completions): Rename or remove locals
4600 to avoid shadowing.
5716756e 4601
b4c3046a
PE
4602 * marker.c (bytepos_to_charpos): Remove; unused.
4603
b45db522
PE
4604 * lisp.h (verify_bytepos, count_markers): New decls,
4605 so that gcc does not warn that these functions aren't declared.
4606
85876d07
PE
4607 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4608 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4609 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4610 (copy_text): Remove unused local var.
85876d07 4611
03d78a21 4612 * filelock.c (within_one_second): Now static.
b3dd38ab 4613 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4614
5df8f01b
PE
4615 * buffer.c (fix_overlays_before): Mark locals as initialized.
4616 (fix_start_end_in_overlays): Likewise. This function should be
4617 simplified by using pointers-to-pointers, but that's a different
4618 matter.
b1d876f1 4619 (switch_to_buffer_1): Now static.
8f54f30a
PE
4620 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4621 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4622
a70072c9 4623 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4624 Fix pointer signedness issue.
edced198
PE
4625 (sys_subshell): Mark local as volatile if checking for lint,
4626 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4627 (MAXPATHLEN): Define only if needed.
a70072c9 4628
a0977c44
PE
4629 * process.c (serial_open, serial_configure): Move decls from here ...
4630 * systty.h: ... to here, so that they can be checked.
4631
a884fdcc
PE
4632 * fns.c (get_random, seed_random): Move extern decls from here ...
4633 * lisp.h: ... to here, so that they can be checked.
4634
604efe86 4635 * sysdep.c (reset_io): Now static.
b8950c94 4636 (wait_for_termination_signal): Remove; unused.
604efe86 4637
38fc62d9
PE
4638 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4639 (copy_keymap_item, append_key, push_text_char_description):
4640 Now static.
1004a21a 4641 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4642 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4643 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4644 (describe_map_tree):
4645 Rename locals to avoid shadowing.
38fc62d9 4646
2f2650da
PE
4647 * keyboard.c: Declare functions static if they are not used elsewhere.
4648 (echo_char, echo_dash, cmd_error, top_level_2):
4649 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4650 (read_char, kbd_buffer_get_event, make_lispy_position):
4651 (make_lispy_event, make_lispy_movement, apply_modifiers):
4652 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4653 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4654 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4655 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4656 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4657
a053e86c 4658 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4659 (mark_kboards): Move decl here ...
4660 * alloc.c (mark_kboards): ... from here.
a053e86c 4661
4752793e
PE
4662 * lisp.h (force_auto_save_soon): New decl.
4663
74f10ca7 4664 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4665 (DEFINE_DUMMY_FUNCTION): New macro.
4666 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4667 Use it.
c03cd23f
PE
4668 (main): Add casts to avoid warnings
4669 if GCC considers string literals to be constants.
74f10ca7 4670
022e70d4
PE
4671 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4672
59d6fe83
PE
4673 * dbusbind.c: Pointer signedness fixes.
4674 (xd_signature, xd_append_arg, xd_initialize):
4675 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4676 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4677 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4678 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4679
78320123
PE
4680 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4681 if GCC considers string literals to be constants.
49cebcca 4682 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4683
35ac2a97
SM
46842011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4685
fb103ca9
SM
4686 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4687 (print_preprocess, print_object): New macro to fix last change.
4688
35ac2a97
SM
4689 * print.c (print_preprocess): Don't forget font objects.
4690
62973b41
JB
46912011-03-16 Juanma Barranquero <lekktu@gmail.com>
4692
4693 * emacs.c (USAGE3): Doc fixes.
4694
0e48bb22
AS
46952011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4696
4697 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4698 structure.
4699
7684e57b
JB
47002011-03-14 Juanma Barranquero <lekktu@gmail.com>
4701
4702 * lisp.h (VWindow_system, Qfile_name_history):
4703 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4704 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4705 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4706
4707 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4708 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4709
4710 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4711 * w32console.c (detect_input_pending, read_input_pending)
4712 (encode_terminal_code):
4713 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4714 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4715 (w32_system_caret_y, Qfile_name_history):
4716 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4717 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4718 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4719 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4720 * w32proc.c (Qlocal, report_file_error):
4721 * w32term.c (Vwindow_system, updating_frame):
4722 * w32uniscribe.c (initialized, uniscribe_font_driver):
4723 Remove unneeded extern declarations.
4724
2aa46d6c
CY
47252011-03-14 Chong Yidong <cyd@stupidchicken.com>
4726
c96bbc66 4727 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4728
cffc6f3b
CY
47292011-03-13 Chong Yidong <cyd@stupidchicken.com>
4730
4731 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4732 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4733 These macros can no longer be used for assignment.
4734
44f230aa
SM
4735 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4736 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4737 (record_buffer_markers, fetch_buffer_markers): New functions for
4738 recording and fetching special buffer markers.
4739 (set_buffer_internal_1, set_buffer_temp): Use them.
4740
4741 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4742
4743 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4744
4745 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4746 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4747
4748 * xdisp.c (hscroll_window_tree):
4749 (reconsider_clip_changes): Use PT instead of BUF_PT.
4750
d251f04b
EZ
47512011-03-13 Eli Zaretskii <eliz@gnu.org>
4752
4753 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4754 $(EMACS_ROOT)/lib/intprops.h.
4755
f0c77cd1
PE
47562011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4757
3eca4629
PE
4758 Fix more problems found by GCC 4.5.2's static checks.
4759
7c86ee98
PE
4760 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4761 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4762 (xg_free_frame_widgets): Make it clear that a local variable is
4763 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4764 (gdk_window_get_screen): Make it clear that this macro is needed
4765 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4766 (int_gtk_range_get_value): New function, which avoids a diagnostic
4767 from gcc -Wbad-function-cast.
4768 (xg_set_toolkit_scroll_bar_thumb): Use it.
4769 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4770 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4771 (get_utf8_string, xg_get_file_with_chooser):
4772 Rename locals to avoid shadowing.
4773 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4774
41729b81
PE
4775 * xgselect.c (xg_select): Remove unused var.
4776
f0c77cd1
PE
4777 * image.c (four_corners_best): Mark locals as initialized.
4778 (gif_load): Initialize transparent_p to zero (Bug#8238).
4779 Mark another local as initialized.
ec6cf4c6 4780 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4781
ce0ad53d 4782 * image.c (clear_image_cache): Now static.
d5d5a617 4783 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4784 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4785 (x_edge_detection): Remove unnecessary cast that
4786 gcc -Wbad-function-cast diagnoses.
2037898d 4787 (gif_load): Fix pointer signedness.
6ae141d6
PE
4788 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4789 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4790
33383987 47912011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4792
d32df629
PE
4793 Improve quality of tests for time stamp overflow.
4794 For example, without this patch (encode-time 0 0 0 1 1
4795 1152921504606846976) returns the obviously-bogus value (-948597
4796 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4797 reports time overflow. See
4798 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4799 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4800 * editfns.c: Include limits.h and intprops.h.
4801 (TIME_T_MIN, TIME_T_MAX): New macros.
4802 (time_overflow): Move earlier, to before first use.
4803 (hi_time, lo_time): New functions, for an accurate test for
4804 out-of-range times.
4805 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4806 (Fget_internal_run_time): Don't assume time_t fits in int.
4807 (make_time): Use list2 instead of Fcons twice.
4808 (Fdecode_time): More accurate test for out-of-range times.
4809 (check_tm_member): New function.
4810 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4811 (lisp_time_argument): Don't rely on undefined left-shift and
4812 right-shift behavior when checking for time stamp overflow.
8be6f318 4813
fe31d94c
PE
4814 * editfns.c (time_overflow): New function, refactoring common code.
4815 (Fformat_time_string, Fdecode_time, Fencode_time):
4816 (Fcurrent_time_string): Use it.
4817
8be6f318
PE
4818 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4819 * dired.c (make_time): Move to ...
4820 * editfns.c (make_time): ... here.
4821 * systime.h: Note the move.
4822
09d9db2c 48232011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4824
126bc0dc
YM
4825 * fringe.c (update_window_fringes): Remove unused variables.
4826
c47cbdfd
YM
4827 * unexmacosx.c (copy_data_segment): Also copy __got section.
4828 (Bug#8223)
4829
7ac80be9
EZ
48302011-03-12 Eli Zaretskii <eliz@gnu.org>
4831
c96bbc66 4832 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4833 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4834 Constify `char *' arguments and their references according to
4835 prototypes in tparam.h.
4836
ecb0f94d 4837 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4838
7ac80be9
EZ
4839 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4840 Adapt all references accordingly.
4841
4842 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4843
ef1fd07e
TT
48442011-03-11 Tom Tromey <tromey@redhat.com>
4845
4846 * buffer.c (syms_of_buffer): Remove obsolete comment.
4847
7ef4b50c
EZ
48482011-03-11 Eli Zaretskii <eliz@gnu.org>
4849
4850 * termhooks.h (encode_terminal_code): Declare prototype.
4851
4852 * msdos.c (encode_terminal_code): Don't declare prototype.
4853
4854 * term.c (encode_terminal_code): Now external again, used by
4855 w32console.c and msdos.c.
4856
44f230aa
SM
4857 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4858 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4859
4b1ec863 48602011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4861
1714f52b 4862 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4863
4b1ec863
PE
4864 * fringe.c (update_window_fringes): Mark locals as initialized
4865 (Bug#8227).
4866 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4867
524c7aa6
PE
4868 * alloc.c (mark_fringe_data): Move decl from here ...
4869 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4870 to check its interface.
4871 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4872
a5c0af81 4873 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4874 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4875 (fontset_font): Mark local as initialized.
a9a06e0b 4876 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4877
b4716021
PE
4878 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4879
811e9bac 4880 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4881 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4882 (x_own_selection, Fx_disown_selection_internal): Rename locals
4883 to avoid shadowing.
4884 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4885
7e3ab302
PE
4886 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4887 so that the caller can use some name other than gcpro1.
4888 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4889 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4890 (Fx_backspace_delete_keys_p):
4891 Use them to avoid shadowing, and rename vars to avoid shadowing.
4892 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4893 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4894 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4895 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4896 Remove unused locals.
7e3ab302
PE
4897 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4898 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4899 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4900 macros.
f78faa98 4901
e2b13473
PE
4902 * xterm.h (x_mouse_leave): New decl.
4903
77f23912
PE
4904 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4905 Remove unused functions.
cdf4ba58
PE
4906 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4907 (x_calc_absolute_position): Now static.
7411c686 4908 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4909 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4910 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4911 unless they are used.
38d0b34a
PE
4912 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4913 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4914 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4915 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4916 (x_error_catcher, x_connection_closed, x_error_handler):
4917 (x_error_quitter, xembed_send_message, x_iconify_frame):
4918 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4919 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4920 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4921
44f230aa
SM
4922 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4923 Rename or move locals to avoid shadowing.
6b463e58 4924 (tty_defined_color, merge_face_heights): Now static.
5967d051 4925 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4926 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4927 does not deduce is never used uninitialized.
73719eba
PE
4928 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4929 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4930
426994c3 4931 * terminal.c (store_terminal_param): Now static.
5489860b 4932
032f1620 4933 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4934 (set_frame_menubar): Remove unused local.
d4323972 4935 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4936 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4937 since they might point to immutable storage.
281585b0
PE
4938 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4939 since it's unused otherwise.
032f1620 4940
367c19e5 4941 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4942 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4943 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4944 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4945 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4946 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4947 does not deduce are never used uninitialized.
70739cbe 4948
07b48fa9
PE
4949 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4950
8868a238 4951 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4952 * window.c (window_loop, size_window):
4953 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4954
7e5cf297 4955 * window.c (display_buffer): Now static.
d6550a9f
PE
4956 (size_window): Mark variables that gcc -Wuninitialized
4957 does not deduce are never used uninitialized.
a586633d
PE
4958 * window.h (check_all_windows): New decl, to forestall
4959 gcc -Wmissing-prototypes diagnostic.
5b555da1 4960 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4961
f6095868
PE
4962 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4963 shadowing.
4964 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4965 Include <limits.h>.
4966 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4967 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4968 (load_charset_map): Mark variables that gcc -Wuninitialized
4969 does not deduce are never used uninitialized.
53df7c11 4970 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4971
f38b440c
PE
4972 * coding.c (coding_set_source, coding_set_destination):
4973 Use "else { /* comment */ }" rather than "else /* comment */;"
4974 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4975 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4976 a block, when the outer 'i' will do.
4977 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4978 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4979 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4980 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4981 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4982 Rename locals to avoid shadowing.
4983 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4984 * coding.c (emacs_mule_char, encode_invocation_designation):
4985 Now static, since they're not used elsewhere.
413bb2db 4986 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4987 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4988 (decode_coding_emacs_mule): Mark variables that gcc
4989 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4990 (detect_coding_iso_2022): Initialize a local variable that might
4991 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4992 this initialization is needed. (Bug#8211)
5f58e762
PE
4993 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4994 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4995 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4996 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4997 Remove unused macros.
f38b440c 4998
232b38b9 4999 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5000 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5001 * character.c (string_count_byte8): Likewise.
232b38b9 5002
fb90da1b
PE
5003 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5004 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5005
fb93dbc2
PE
5006 * chartab.c (copy_sub_char_table): Now static, since it's not used
5007 elsewhere.
5c156ace
PE
5008 (sub_char_table_ref_and_range, char_table_ref_and_range):
5009 Rename locals to avoid shadowing.
bbcd0949 5010 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5011
7d3b3862 5012 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5013 (BIDI_BOB): Remove unused macro.
7d3b3862 5014
6be7d3da
PE
5015 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5016 deduce are never used uninitialized.
c2ed9c8b 5017 * term.c (encode_terminal_code): Likewise.
6be7d3da 5018
75f8807f 5019 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5020
50938595
PE
5021 * tparam.h: New file.
5022 * term.c, tparam.h: Include it.
5023 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5024 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5025 Move these decls to tparam.h, and make them agree with what
5026 is actually in tparam.c. The previous trick of using incompatible
5027 decls in different modules does not conform to the C standard.
5028 All callers of tparam changed to use tparam's actual API.
5029 * tparam.c (tparam1, tparam, tgoto):
5030 Use const pointers where appropriate.
5031
fbceeba2
PE
5032 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5033 * cm.h (struct cm): Likewise.
5034 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5035 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5036 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5037 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5038 (turn_on_face, init_tty): Likewise.
5039 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5040
7f3f1250
PE
5041 * term.c (term_mouse_position): Rename local to avoid shadowing.
5042
e6ca6543
PE
5043 * alloc.c (mark_ttys): Move decl from here ...
5044 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5045
c40f8d15
AS
50462011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5047
5048 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5049
cfe0661d
JB
50502011-03-09 Juanma Barranquero <lekktu@gmail.com>
5051
5052 * search.c (compile_pattern_1): Remove argument regp, unused since
5053 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5054 (compile_pattern): Don't pass it.
5055
0afb4571
J
50562011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5057
5058 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5059 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5060 for ! HAVE_GTK3.
5061 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5062
5063 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5064
5065 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5066 gdk_window_get_screen, gdk_window_get_geometry,
5067 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5068 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5069 (xg_get_pixbuf_from_pixmap): New function.
5070 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5071 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5072 Call xg_get_pixbuf_from_pixmap instead of
5073 gdk_pixbuf_get_from_drawable.
5074 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5075 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5076 (xg_check_special_colors): Use GtkStyleContext and its functions
5077 for HAVE_GTK3.
5078 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5079 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5080 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5081 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5082 Call gtk_widget_get_preferred_size.
0afb4571
J
5083 (xg_frame_resized): gdk_window_get_geometry only takes 5
5084 parameters.
44f230aa
SM
5085 (xg_win_to_widget, xg_event_is_for_menubar):
5086 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5087 (xg_set_widget_bg): New function.
5088 (delete_cb): New function.
895009e1 5089 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5090 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5091 (xg_set_background_color): Call xg_set_widget_bg.
5092 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5093 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5094 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5095 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5096 if ! HAVE_GTK3.
5097 (update_frame_tool_bar): Call gtk_widget_hide.
5098 (xg_initialize): Use GDK_KEY_g.
5099
5100 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5101 if ! HAVE_GTK3
5102 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5103
5104 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5105 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5106 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5107
1c2cc4ef
JB
51082011-03-08 Juanma Barranquero <lekktu@gmail.com>
5109
5110 * w32xfns.c (select_palette): Check success of RealizePalette against
5111 GDI_ERROR, not zero.
5112
33383987 5113See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5114
5115;; Local Variables:
5116;; coding: utf-8
aac0c6e3
MR
5117;; End:
5118
33383987 5119 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5120
5121 This file is part of GNU Emacs.
5122
5123 GNU Emacs is free software: you can redistribute it and/or modify
5124 it under the terms of the GNU General Public License as published by
5125 the Free Software Foundation, either version 3 of the License, or
5126 (at your option) any later version.
5127
5128 GNU Emacs is distributed in the hope that it will be useful,
5129 but WITHOUT ANY WARRANTY; without even the implied warranty of
5130 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5131 GNU General Public License for more details.
5132
5133 You should have received a copy of the GNU General Public License
5134 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.