* print.c (float_to_string): Detect width overflow more reliably.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
62f19c19
PE
12011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2
3 sprintf-related integer and memory overflow issues.
4
5 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6 (esprintf, esnprintf, exprintf, evxprintf): New functions.
7 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
8 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
9 (modify_event_symbol): Do not assume that the length of
10 name_alist_or_stem is safe to alloca and fits in int.
11 (Fexecute_extended_command): Likewise for function name and binding.
12 (Frecursion_depth): Wrap around reliably on integer overflow.
13 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
14 since some callers pass EMACS_INT values.
15 (Fsingle_key_description): Don't crash if symbol name contains more
16 than MAX_ALLOCA bytes.
17 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
18 (get_minibuffer): Arg is now EMACS_INT, not int.
19 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
20 (esprintf, esnprintf, exprintf, evxprintf): New decls.
21 * window.h (command_loop_level, minibuf_level): Reflect API changes.
22
2ea16b89
PE
23 * dbusbind.c (xd_signature, Fdbus_register_signal):
24 Do not overrun buffer; instead, report string overflow.
25
9d1df220
PE
26 * dispnew.c (add_window_display_history): Don't overrun buffer.
27 Truncate instead; this is OK since it's just a log.
28
33ef5c64
PE
29 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
30 even if the time zone offset is outlandishly large.
31 Don't mishandle offset == INT_MIN.
32
66c6fdd5
PE
33 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
34 when creating daemon; the previous buffer-overflow check was incorrect.
35
d749b01b
PE
36 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
37 which has the guts of the old verror function.
38
b5cd1905
PE
39 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
40 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
41
c21721cc
PE
42 * font.c (font_unparse_xlfd): Don't blindly alloca long strings.
43 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
44 fits in int, when using sprintf. Use single snprintf to count
45 length of string rather than counting it via multiple sprintfs;
46 that's simpler and more reliable.
47 (APPEND_SPRINTF): New macro.
48 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
49 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
50 sprintf, in case result does not fit in int.
51
c57b67fc
PE
52 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
53 (fontset_from_font): Print it.
54
8a401434
PE
55 * frame.c (tty_frame_count): Now printmax_t, not int.
56 (make_terminal_frame, set_term_frame_name): Print it.
57 (x_report_frame_params): In X, window IDs are unsigned long,
58 not signed long, so print them as unsigned.
59 (validate_x_resource_name): Check for implausibly long names,
60 and don't assume name length fits in 'int'.
61 (x_get_resource_string): Don't blindly alloca invocation name;
62 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
63 not fit in int.
64
84722b3d
PE
65 * gtkutil.c (xg_check_special_colors, xg_set_geometry):
66 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
67
0df02bf3
PE
68 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
69 Use esprintf, not sprintf, in case result does not fit in int.
70
48e30793
PE
71 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
72 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
73 it as a large positive number.
74 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
75 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
76
a66ff6d8
PE
77 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
78 in case result does not fit in int.
79
aca216ff
PE
80 * print.c (float_to_string): Detect width overflow more reliably.
81 (print_object): Make sprintf buffer a bit bigger, to avoid potential
82 buffer overrun. Don't assume list length fits in 'int'. Treat
83 print length of 0 as 0, not as infinity; to be consistent with other
84 uses of print length in this function. Don't overflow print length
85 index. Don't assume hash table size fits in 'long', or that
86 vectorlike size fits in 'unsigned long'.
87
5fc295a4 882011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 89
70c60eb2 90 Integer and memory overflow issues (Bug#9196).
726e0ab1 91
d31850da
PE
92 * doc.c (get_doc_string): Rework so that
93 get_doc_string_buffer_size is the actual buffer size, rather than
94 being 1 less than the actual buffer size; this makes xpalloc more
95 convenient.
96
a69fbedb
PE
97 * image.c (x_allocate_bitmap_record, cache_image):
98 * xselect.c (Fx_register_dnd_atom):
99 Simplify previous changes by using xpalloc.
100
fe5c5d37
PE
101 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
102 since either will do and ptrdiff_t is convenient with xpalloc.
103
0065d054
PE
104 * charset.c (charset_table_size)
105 (struct charset_sort_data.priority): Now ptrdiff_t.
106 (charset_compare): Don't overflow if priorities differ greatly.
107 (Fsort_charsets): Don't assume list length fits in int.
108 Check for size-calculation overflow when allocating sort data.
109 (syms_of_charset): Allocate an initial charset table that is
110 just under 64 KiB, to avoid problems with glibc malloc and mmap.
111
112 * cmds.c (internal_self_insert): Check for size-calculation overflow.
113
114 * composite.h (struct composition.glyph_len): Now int, not unsigned.
115 The actual value is always <= INT_MAX, and leaving it unsigned made
116 overflow checking harder.
117
118 * dispextern.h (struct glyph_matrix.rows_allocated)
119 (struct face_cache.size): Now ptrdiff_t, for convenience in use
120 with xpalloc. The values are still always <= INT_MAX.
121
122 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
123
124 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
125 (SAFE_NALLOCA): New macro.
126
127 * region-cache.c (struct boundary.pos, find_cache_boundary)
128 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
129 (set_cache_region, invalidate_region_cache)
130 (revalidate_region_cache, know_region_cache, region_cache_forward)
131 (region_cache_backward, pp_cache):
132 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
133 so that ptrdiff_t * can be passed to xpalloc.
134 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
135 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
136 (pp_cache): Don't assume cache_len fits in int.
137 * region-cache.h: Adjust extern decls to match.
138
139 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
140 EMACS_INT, since either will do, for xpalloc.
141
142 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
143 (xnmalloc, xnrealloc, xpalloc): New functions.
144
726e0ab1
PE
145 * bidi.c (bidi_shelve_header_size): New constant.
146 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
147 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
148
51f30bc5 149 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
150 * buffer.c (overlays_at, overlays_in, record_overlay_string)
151 (overlay_strings):
152 Don't update size of array until after memory allocation succeeds,
153 because xmalloc/xrealloc may not return.
0065d054
PE
154 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
155 now that we have proper integer overflow checking.
156 (record_overlay_string, overlay_strings): Catch overflows when
157 calculating size of overlay_str_buf.
726e0ab1 158
0065d054
PE
159 * callproc.c (Fcall_process): Check for size overflow when
160 calculating size of args2.
161 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
162 Normally we prefer signed values, but sticking with ptrdiff_t would
163 require adding more-complicated checks.
726e0ab1
PE
164
165 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
166 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
167 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 168 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
169
170 * character.c (Fstring): Check for size-calculation overflow.
171
172 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
173 unnecessary integer overflow. Check for size overflow.
174 (encode_coding_object): Don't update size until xmalloc succeeds.
175
176 * composite.c (get_composition_id): Check for overflow in glyph
177 length calculations.
178
179 Integer and memory overflow fixes for display code.
180 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
181 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
182 (scrolling_window): Check for overflow in size calculations.
183 (line_draw_cost, realloc_glyph_pool, add_row_entry):
184 Don't assume glyph table len fits in int.
185 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
186 (row_table_size): Now ptrdiff_t, not int.
187 (scrolling_window): Avoid overflow in size calculations.
188 Don't update size until allocation succeeds.
189 * fns.c (concat): Check for overflow in size calculations.
190 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
191 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
192 (NEXT_ALMOST_PRIME_LIMIT): New constant.
193
194 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
195 (get_doc_string): Check for size calculation overflow.
196 Don't update size until allocation succeeds.
197 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
198 EMACS_INT, where ptrdiff_t will do.
199 (Fsubstitute_command_keys): Check for string overflow.
200
201 * editfns.c (set_time_zone_rule): Don't assume environment length
202 fits in int.
203 (message_length): Now ptrdiff_t, not int.
204 (Fmessage_box): Don't update size until allocation succeeds.
205 Don't assume message length fits in int.
206 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
207
0065d054
PE
208 * emacs.c (main): Do not reallocate argv, since there is a null at
209 the end that can be overwritten, and this way there's no need to
210 worry about size-calculation overflow.
211 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
212
213 * eval.c (init_eval_once, grow_specpdl): Don't update size until
214 alloc succeeds.
215 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
216
217 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
218 (x_set_scroll_bar_width, x_figure_window_size):
219 Check for integer overflow.
220 (x_set_alpha): Do not assume XINT fits in int.
221
222 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
223 This is for the members text_lines, text_cols, total_lines, total_cols,
224 where the system imposes an 'int' limit.
225
226 * fringe.c (Fdefine_fringe_bitmap):
227 Don't update size until alloc works.
228
229 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
230 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
231
232 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
233 Check for size-calculation overflow.
234 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
235 do, as we prefer signed integers.
236 (id_to_widget.max_size, id_to_widget.used)
237 (xg_store_widget_in_map, xg_remove_widget_from_map)
238 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
239 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
240 Use and return ptrdiff_t, not int.
241 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
242 * gtkutil.h: Change prototypes to match the above.
243
244 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
245 are duplicate now that they've been promoted to lisp.h.
246 (x_allocate_bitmap_record, x_alloc_image_color)
247 (make_image_cache, cache_image, xpm_load):
248 Don't update size until alloc is done.
249 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
250 (x_detect_edges):
3256efce 251 Check for size calculation overflow.
726e0ab1
PE
252 (ct_colors_allocated_max): New constant.
253 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
254 overflow.
3256efce 255
726e0ab1
PE
256 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
257 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
258 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
259 Use ptrdiff_t, not int, to count maps.
260 (read_char_minibuf_menu_prompt): Check for overflow in size
261 calculations. Don't update size until allocation succeeds. Redo
262 calculations to avoid overflow.
263 * keyboard.h: Change prototypes to match the above.
264
265 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
266 to count maps.
267 (current_minor_maps): Check for size calculation overflow.
268 * keymap.h: Change prototypes to match the above.
269
270 * lread.c (read1, init_obarray): Don't update size until alloc done.
271
272 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
273 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
274
726e0ab1
PE
275 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
276 Now ptrdiff_t, not int.
277 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
278 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
279
280 * process.c (Fnetwork_interface_list): Check for overflow
281 in size calculation.
282
283 * region-cache.c (move_cache_gap): Check for size calculation overflow.
284
285 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
286 overflow. Don't bother calling xmalloc when xrealloc will do.
287
288 * search.c (Freplace_match): Check for size calculation overflow.
289 (Fset_match_data): Don't assume list lengths fit in 'int'.
290
291 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
292 for command line length. Do not attempt to address one before the
293 beginning of an array, as that's not portable.
294
295 * term.c (max_frame_lines): Remove; unused.
296 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
297 not int.
298 (encode_terminal_code, calculate_costs): Check for size
299 calculation overflow.
300 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
301 table lengths and related sizes. Don't update size until alloc
302 done. Redo calculations to avoid overflow.
303 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
304
305 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
306 subtracting pointers.
307 (gobble_line): Check for overflow more carefully. Don't update size
308 until alloc done.
309
310 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
311 Don't update size until alloc done.
312 Redo size calculations to avoid overflow.
313 Check for size calculation overflow.
0065d054 314 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
315
316 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
317 Use ptrdiff_t, not int, for sizes.
318 (store_mode_line_noprop_char): Don't update size until alloc done.
319
0065d054
PE
320 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
321 Use ptrdiff_t, not int, for sizes.
322 (Finternal_make_lisp_face, cache_face):
323 Check for size calculation overflow.
324 (cache_face): Treat size calculation overflows as if they were
325 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
326
327 * xfns.c (x_encode_text, x_set_name_internal)
328 (Fx_change_window_property): Use ptrdiff_t, not int, to count
329 sizes, since they can exceed INT_MAX in size. Check for size
330 calculation overflow.
331
0065d054
PE
332 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
333 (xg_select): Check for size calculation overflow.
726e0ab1
PE
334 Don't update size until alloc done.
335
0065d054 336 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 337 as sprintf is limited to int lengths.
1d526e2f 338
252c5ee1
PE
339 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
340 (X_LONG_MIN): New macros.
864d7ce7
PE
341 Use them to make the following changes clearer.
342 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
343 This change doesn't affect the value now, but it may help remind
344 future maintainers not to raise the value too much later.
345 (SELECTION_QUANTUM): Remove, replacing with ...
346 (selection_quantum): ... new function, which avoids overflow.
347 All uses changed.
348 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
349 assumption that selection length fits in 'int'.
350 (x_reply_selection_request, x_handle_selection_request)
351 (x_get_window_property, receive_incremental_selection)
352 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
353 (lisp_data_to_selection_data, clean_local_selection_data):
354 Use ptrdiff_t, not int, to record length of selection.
355 (x_reply_selection_request, x_get_window_property)
356 (receive_incremental_selection, x_property_data_to_lisp):
357 Redo calculations to avoid overflow.
358 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 359 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
360 something.
361 (x_get_window_property, receive_incremental_selection)
362 (lisp_data_to_selection_data, x_property_data_to_lisp):
363 Check for size-calculation overflow.
364 (x_get_window_property, receive_incremental_selection)
365 (lisp_data_to_selection_data, Fx_register_dnd_atom):
366 Don't store size until memory allocation succeeds.
367 (x_get_window_property): Plug memory leak on memory exhaustion.
368 Don't double-block input; malloc is safe here. Don't assume 2**34
369 - 4 fits in unsigned long. Add an xassert to check
370 XGetWindowProperty overflow. Be more careful about overflow
371 calculations, and distinguish size from memory overflow better.
372 (receive_incremental_selection): When tracing, don't assume
373 unsigned int is less than INT_MAX.
374 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
375 harmful) conversions of unsigned short to int.
376 (lisp_data_to_selection_data): Don't assume that integers
377 in the range -65535 through -1 fit in an X unsigned short.
378 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
379 result parameters unless successful. Rely on cons_to_unsigned
380 to report problems with elements; the old code wasn't right anyway.
381 (x_check_property_data): Check for int overflow; we cannot use
382 a wider type due to X limits.
383 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
384
726e0ab1 385 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 386
0065d054
PE
387 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
388 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
389 (x_color_cells): Don't store size until memory allocation succeeds.
390 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 391 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
392 (x_term_init): Don't assume length fits in int (sprintf is limited
393 to int size).
bc18e09d 394
ebfa62c0
PE
395 Use ptrdiff_t for composition IDs.
396 * character.c (lisp_string_width):
397 * composite.c (composition_table_size, n_compositions)
398 (get_composition_id, composition_gstring_from_id):
399 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
400 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
401 * window.c (Frecenter):
402 Use ptrdiff_t, not int, for composition IDs.
403 * composite.c (get_composition_id): Check for integer overflow.
404 * composite.h: Adjust prototypes to match the above changes.
405
d3411f89
PE
406 Use ptrdiff_t for hash table indexes.
407 * category.c (hash_get_category_set):
408 * ccl.c (ccl_driver):
409 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
410 * coding.c (coding_system_charset_list, detect_coding_system):
411 * coding.h (struct coding_system.id):
412 * composite.c (get_composition_id, gstring_lookup_cache):
413 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
414 * image.c (xpm_get_color_table_h):
415 * lisp.h (hash_lookup, hash_put):
416 * minibuf.c (Ftest_completion):
417 Use ptrdiff_t for hash table indexes, not int (which is too
418 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
419 32-bit --with-wide-int hosts).
420
e097a6fa
PE
421 * charset.c (Fdefine_charset_internal): Check for integer overflow.
422 Add a FIXME comment about memory leaks.
423 (syms_of_charset): Don't assume xmalloc returns.
424
5637687f
PE
425 Don't assume that stated character widths fit in int.
426 * character.c (Fchar_width, c_string_width, lisp_string_width):
427 * character.h (CHAR_WIDTH):
428 * indent.c (MULTIBYTE_BYTES_WIDTH):
429 Use sanitize_char_width to avoid undefined and/or bad behavior
430 with outlandish widths.
431 * character.h (sanitize_tab_width): Renamed from sanitize_width,
432 now that we have two such functions. All uses changed.
433 (sanitize_char_width): New inline function.
434
a2271ba2
PE
435 Don't assume that tab-width fits in int.
436 * character.h (sanitize_width): New inline function.
437 (SANE_TAB_WIDTH): New macro.
438 (ASCII_CHAR_WIDTH): Use it.
439 * indent.c (sane_tab_width): Remove. All uses replaced by
440 SANE_TAB_WIDTH (current_buffer).
441 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
442
18c52557
PE
443 * fileio.c: Integer overflow issues with file modes.
444 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
445
caeeedc1
PE
446 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
447 Remove unreachable code.
448 (read_hex, load_charset_map_from_file): Check for integer overflow.
449
50849c52
PE
450 * xterm.c: don't go over XClientMessageEvent limit
451 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
452 (x_send_scroll_bar_event): Likewise. Check that the size does not
453 exceed limits imposed by XClientMessageEvent, as well as the usual
454 ptrdiff_t and size_t limits.
455
b13995db
PE
456 * keyboard.c: Overflow, signedness and related fixes.
457 (make_lispy_movement): Use same integer type in forward decl
458 that is used in the definition.
459 (read_key_sequence, keyremap_step):
460 Change bufsize argument back to int, undoing my 2011-03-30 change.
461 We prefer signed types, and int is wide enough here.
462 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
463 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
464 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
465 length, not size_t. Use ptrdiff_t for index, not int.
466 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
467 possibility of integer overflow.
468
13464394
PE
469 Overflow, signedness and related fixes for images.
470
471 * dispextern.h (struct it.stack[0].u.image.image_id)
472 (struct_it.image_id, struct image.id, struct image_cache.size)
473 (struct image_cache.used, struct image_cache.ref_count):
474 * gtkutil.c (update_frame_tool_bar):
475 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
476 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
477 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
478 * nsmenu.m (update_frame_tool_bar):
479 * xdisp.c (calc_pixel_width_or_height):
480 * xfns.c (image_cache_refcount):
481 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
482 on typical 64-bit hosts.
483
484 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
485 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
486 Omit unnecessary casts to int.
487 (parse_image_spec): Check that integers fall into 'int' range
488 when the callers expect that.
489 (image_ascent): Redo ascent calculation to avoid int overflow.
490 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
491 (lookup_image): Remove unnecessary tests.
492 (xbm_image_p): Locals are now of int, not EMACS_INT,
493 since parse_image_check makes sure they fit into int.
494 (png_load, gif_load, svg_load_image):
495 Prefer int to unsigned where either will do.
496 (tiff_handler): New function, combining the cores of the
497 old tiff_error_handler and tiff_warning_handler. This
498 function is rewritten to use vsnprintf and thereby avoid
499 stack buffer overflows. It uses only the features of vsnprintf
500 that are common to both POSIX and native Microsoft.
501 (tiff_error_handler, tiff_warning_handler): Use it.
502 (tiff_load, gif_load, imagemagick_load_image):
503 Don't assume :index value fits in 'int'.
504 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
505 (imagemagick_load_image): Check that crop parameters fit into
506 the integer types that MagickCropImage accepts. Don't assume
507 Vimagemagick_render_type has a nonnegative value. Don't assume
508 size_t fits in 'long'.
509 (gs_load): Use printmax_t to print the widest integers possible.
510 Check for integer overflow when computing image height and width.
511
c11821d4
EZ
5122011-08-26 Eli Zaretskii <eliz@gnu.org>
513
514 * xdisp.c (redisplay_window): Don't force window start if point
515 will be invisible in the resulting window. (Bug#9324)
516
0c95fcf7
EZ
5172011-08-25 Eli Zaretskii <eliz@gnu.org>
518
519 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
520 the display spec is of the form `(space ...)'.
521 (handle_display_spec): Return the value returned by
522 handle_single_display_spec, not just 1 or zero.
523 (handle_single_display_spec): If the display spec is of the form
524 `(space ...)', and specifies display in the text area, return 2
525 rather than 1.
fee65a97 526 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
527 accurately, and prefer exact match for point under bidi. Don't
528 advance `row' beyond the last row of the window.
0c95fcf7
EZ
529
530 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
531 into disp_prop; all users changed.
532
533 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
534 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
535 for the text covered by the display property.
536
e4ed06f1
CY
5372011-08-25 Chong Yidong <cyd@stupidchicken.com>
538
539 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
540 Change return value to nil.
541 (Frecord_buffer): Delete unused function.
542
f67cdd7f
EZ
5432011-08-24 Eli Zaretskii <eliz@gnu.org>
544
5980d4c6
EZ
545 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
546 buffers, return left-to-right.
8610fe8b
EZ
547 (set_cursor_from_row): Consider candidate row a win if its glyph
548 represents a newline and point is on that newline. Fixes cursor
549 positioning on the newline at EOL of R2L text within L2R
550 paragraph, and vice versa.
551 (try_cursor_movement): Check continued rows, in addition to
552 continuation rows. Fixes unwarranted scroll when point enters a
553 continued line of R2L text within an L2R paragraph, or vice versa.
554 (cursor_row_p): Consider the case of point being equal to
555 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
556 from the end of a short line to the beginning of a continued line
557 of R2L text within L2R paragraph.
558 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
559 composed characters.
5980d4c6 560
f67cdd7f
EZ
561 * bidi.c (bidi_check_type): Use xassert.
562 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
563 members.
564
bca633fb
EZ
5652011-08-23 Eli Zaretskii <eliz@gnu.org>
566
567 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
568 a character.
569
4a5885a7
CY
5702011-08-23 Chong Yidong <cyd@stupidchicken.com>
571
572 * nsfont.m (ns_otf_to_script): Fix typo.
573
0902a04e
KH
5742011-08-22 Kenichi Handa <handa@m17n.org>
575
576 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
577 extra slot even if the purpose is char-code-property-table.
578
1a2e6670
EZ
5792011-08-23 Eli Zaretskii <eliz@gnu.org>
580
8ddde651
EZ
581 * xdisp.c (redisplay_window): When computing centering_position,
582 account for the height of the header line. (Bug#8874)
583
425cc014
EZ
584 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
585 instead of CHAR_TO_BYTE. Fixes a crash when a completion
586 candidate is selected by the mouse, and that candidate has a
587 composed character under the mouse.
588
1a2e6670
EZ
589 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
590 coordinates reported by pos-visible-in-window-p for a composed
591 character in column zero.
592
8b76d6f8
SM
5932011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
594
595 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
596
dac347dd
EZ
5972011-08-22 Eli Zaretskii <eliz@gnu.org>
598
599 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
600 consider it a hit if to_charpos is anywhere in the range of the
601 composed buffer positions.
602
e013fb34
CY
6032011-08-22 Chong Yidong <cyd@stupidchicken.com>
604
605 * image.c (gif_load): Don't assume that each subimage has the same
606 dimensions as the base image. Handle disposal method that is
607 "undefined" by the gif spec (Bug#9335).
608
bd1ba3e8
CY
6092011-08-20 Chong Yidong <cyd@stupidchicken.com>
610
611 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 612 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 613
54a1215b
EZ
6142011-08-19 Eli Zaretskii <eliz@gnu.org>
615
823564e5
EZ
616 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
617 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
618 from an Org mode buffer to a Speedbar frame.
619
54a1215b
EZ
620 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
621 a composition, take its buffer position from IT->cmp_it.charpos.
622 Fixes cursor positioning at the beginning of a line that begins
623 with a composed character.
624
9778ebcc
EZ
6252011-08-18 Eli Zaretskii <eliz@gnu.org>
626
0be6ee06
EZ
627 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
628 character bidirectional type, use STRONG_L instead. Fixes crashes
629 in a buffer produced by `describe-categories'.
630
9778ebcc
EZ
631 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
632 members before the level stack, so they would be saved and
633 restored when copying iterator state. Fixes incorrect reordering
634 around TABs covered by display properties.
635
156bffbe
AS
6362011-08-18 Andreas Schwab <schwab@linux-m68k.org>
637
638 * process.c (Fnetwork_interface_list): Correctly determine buffer
639 size.
640
72ad093b
CY
6412011-08-17 Chong Yidong <cyd@stupidchicken.com>
642
643 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
644 (internal_condition_case_2, internal_condition_case_n):
645 Remove unnecessary aborts (Bug#9081).
72ad093b 646
35774242
EZ
6472011-08-17 Eli Zaretskii <eliz@gnu.org>
648
649 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
650 has no `load' handler, try opening the file locally. (Bug#9311)
651
db76dd85
KB
6522011-08-16 Ken Brown <kbrown@cornell.edu>
653
654 * gmalloc.c: Expand comment.
655
b215eee5
EZ
6562011-08-16 Eli Zaretskii <eliz@gnu.org>
657
658 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
659 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
660
a4579d33
KB
6612011-08-16 Ken Brown <kbrown@cornell.edu>
662
663 Fix memory allocation problems in Cygwin build (Bug#9273).
664
665 * unexcw.c ( __malloc_initialized): Declare external variable.
666 (fixup_executable): Force the dumped emacs to reinitialize malloc.
667
8b76d6f8
SM
668 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
669 New variables.
a4579d33
KB
670 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
671 dumped emacs.
672 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
673 in the static heap.
674 [CYGWIN] (special_realloc): New function.
675 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
676 requests to realloc storage in the static heap.
677
3ebec551
PE
6782011-08-15 Paul Eggert <eggert@cs.ucla.edu>
679
680 * bidi.c (bidi_initialize): Remove unused local.
681
9fd8be00
EZ
6822011-08-15 Eli Zaretskii <eliz@gnu.org>
683
474a8465
EZ
684 * biditype.h: File removed.
685
686 * bidimirror.h: File removed.
687
688 * deps.mk (bidi.o): Remove biditype.h and
689 bidimirror.h.
690
691 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
692 bidimirror.h.
693
694 * dispextern.h: Fix a typo in the comment to bidi_type_t.
695
696 * chartab.c: Improve commentary for the uniprop_table API.
697
32413314
EZ
698 * bidi.c (bidi_paragraph_init): Support zero value of
699 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
700 (bidi_initialize): Use uniprop_table instead of including
701 biditype.h and bidimirror.h.
32413314 702
9fd8be00
EZ
703 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
704 coordinates of the iterator when restoring from ppos_it.
705 (Bug#9296)
706
5cf2b69b
KH
7072011-08-14 Kenichi Handa <handa@m17n.org>
708
709 * process.c (create_process): Call setup_process_coding_systems
72ad093b 710 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 711
daf17d00
EZ
7122011-08-14 Eli Zaretskii <eliz@gnu.org>
713
714 * xdisp.c (move_it_in_display_line_to): Don't invoke
715 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
716 ppos_it. Fixes vertical cursor motion when line beginning is
717 covered by an image. (Bug#9296)
718
08e3161a
JD
7192011-08-14 Jan Djärv <jan.h.d@swipnet.se>
720
721 * nsterm.h (ns_run_ascript): Declare.
722 (NSAPP_DATA2_RUNASSCRIPT): Define.
723
724 * nsfns.m (as_script, as_result, as_status): New static variables.
725 (ns_run_ascript): New function.
726 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
727 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
728 the event loop. Get status from as_status (Bug#7276).
729
730 * nsterm.m (sendEvent): If event is NSApplicationDefined and
731 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
732 the event loop (Bug#7276).
733
a3720aa2
AS
7342011-08-14 Andreas Schwab <schwab@linux-m68k.org>
735
736 * gnutls.c (QCgnutls_bootprop_priority)
737 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
738 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
739 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
740 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
741 (QCgnutls_bootprop_verify_hostname_error)
742 (QCgnutls_bootprop_callbacks_verify): Rename from
743 Qgnutls_bootprop_..., all uses changed.
744
745 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
746 uses changed.
747
0a0d27fb
PE
7482011-08-14 Paul Eggert <eggert@cs.ucla.edu>
749
19d5c50c
PE
750 * xfaces.c (Qframe_set_background_mode): Now static.
751 * dispextern.h (Qframe_set_background_mode): Remove decl.
752
0a0d27fb
PE
753 * process.c (Fnetwork_interface_info): Declare local only if needed.
754
377538cb
JD
7552011-08-13 Jan Djärv <jan.h.d@swipnet.se>
756
757 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
758 (Fnetwork_interface_list): Allocate in increments of bytes instead
759 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
760 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
761 sockaddr.
762 (struct ifflag_def): notrailers is smart on OSX.
763 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
764 Get hardware address with getifaddrs if available.
765
08fff70c
EZ
7662011-08-12 Eli Zaretskii <eliz@gnu.org>
767
768 * xdisp.c (iterate_out_of_display_property): xassert that
769 IT->position is set to within IT->object's boundaries. Break from
770 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
771 when IT->position is set up wrongly due to some bug.
772 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
773 (push_display_prop): Allow GET_FROM_STRING as IT->method on
774 entry. Force push_it to save on the stack the current
775 buffer/string position, to be restored by pop_it. Fix flags in
776 the iterator structure wrt the object coming from a display
777 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
778 properties. (Bug#9284)
779
7be1c708 7802011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 781
7be1c708
CY
782 * fontset.c (fontset_get_font_group): Add proper type checks.
783 (Bug#9172)
aac0c6e3 784
7be1c708 7852011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 786
7be1c708
CY
787 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
788 and LC_VERSION_MIN_MACOSX.
789 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
790 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 791
97bb72a6
EZ
7922011-08-08 Eli Zaretskii <eliz@gnu.org>
793
794 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
795 no-display-properties-and-no-overlays under bidi display.
796 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 797 properties and overlays.
97bb72a6 798
d5617611
CY
7992011-08-08 Chong Yidong <cyd@stupidchicken.com>
800
37e11a63
CY
801 * editfns.c (Fset_time_zone_rule): Document relationship with the
802 setenv function.
803
d5617611
CY
804 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
805 the font entity extracted from the cache (Bug#8109).
806
58872834
CY
8072011-08-07 Chong Yidong <cyd@stupidchicken.com>
808
809 * composite.c (autocmp_chars): Don't reset point. That is done by
810 restore_point_unwind (Bug#5984).
811
75bfc667
JL
8122011-08-07 Juri Linkov <juri@jurta.org>
813
814 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
815 to show the arg `TIME' instead of `TIMEVAL'.
816
d1410150
EZ
8172011-08-06 Eli Zaretskii <eliz@gnu.org>
818
819 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
820 display property strides EOL and includes a newline, as in
821 longlines-mode. (Bug#9254)
75b771e4
EZ
822 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
823 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
824
825 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
826 is non-zero, even if the data buffer is NULL. Fixes a crash in
827 vertical-motion with longlines-mode. (Bug#9254)
828
35928349
EZ
8292011-08-05 Eli Zaretskii <eliz@gnu.org>
830
ec7cc85b
EZ
831 * bidi.c <bidi_cache_total_alloc>: Now static.
832 (bidi_initialize): Initialize bidi_cache_total_alloc.
833
8b76d6f8 834 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
835 cache. (Bug#9221)
836
837 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
838 amount allocated this far in `bidi_cache_total_alloc'.
839 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
840 non-zero, only free the data buffer without restoring the cache
841 contents. All callers changed.
842
843 * dispextern.h (bidi_unshelve_cache): Update prototype.
844
845 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
846 (move_it_in_display_line, move_it_to)
847 (move_it_vertically_backward, move_it_by_lines): Replace the call
848 to xfree to an equivalent call to bidi_unshelve_cache.
849 (move_it_in_display_line_to): Fix logic of returning
412b6358 850 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 851
e2e2423b
EZ
8522011-08-05 Eli Zaretskii <eliz@gnu.org>
853
854 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
855 came from a string character with a `cursor' property. (Bug#9229)
856
ae9e757a
JD
8572011-08-04 Jan Djärv <jan.h.d@swipnet.se>
858
859 * Makefile.in (LIB_PTHREAD): New variable.
860 (LIBES): Add LIB_PTHREAD (Bug#9216).
861
862 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
863 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
864
213bd7f2
AS
8652011-08-04 Andreas Schwab <schwab@linux-m68k.org>
866
867 * regex.c (re_iswctype): Remove some redundant boolean
868 conversions.
869
99aaf75f
JD
8702011-08-04 Jan Djärv <jan.h.d@swipnet.se>
871
872 * xterm.c (x_find_topmost_parent): New function.
873 (x_set_frame_alpha): Find topmost parent window with
874 x_find_topmost_parent and set the property there also (bug#9181).
875 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
876
c74e9d86
PE
8772011-08-04 Paul Eggert <eggert@cs.ucla.edu>
878
879 * callproc.c (Fcall_process): Avoid vfork clobbering
880 the local vars buffer, coding_systems, current_dir.
881
640c8776
SM
8822011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
883
884 * keymap.c (Fmake_composed_keymap): Move to subr.el.
885
f26d0e4c
PE
8862011-08-03 Paul Eggert <eggert@cs.ucla.edu>
887
8a10d76c
PE
888 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
889 so that it is not optimized away.
890
f26d0e4c
PE
891 * xdisp.c (compute_display_string_pos): Remove unused local.
892
55439c61
EZ
8932011-08-02 Eli Zaretskii <eliz@gnu.org>
894
895 Fix slow cursor motion and scrolling in large buffers with
896 selective display, like Org Mode buffers. (Bug#9218)
897
898 * dispextern.h (struct bidi_it): New member disp_prop_p.
899
900 * xdisp.c: Remove one-slot cache of display string positions.
901 (compute_display_string_pos): Accept an additional argument
902 DISP_PROP_P; callers changed. Scan at most 5K characters forward
903 for a display string or property. If found, set DISP_PROP_P
904 non-zero.
905
906 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
907 DISP_PROP_P, and pass it to compute_display_string_pos.
908 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
909 non-zero. All callers of bidi_fetch_char changed.
910
fb33fa43
SM
9112011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
912
913 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
914
b099e063
DM
9152010-12-03 Don March <don@ohspite.net>
916
917 * keymap.c (Fdefine_key): Fix non-prefix key error message when
918 last character M-[char] is translated to ESC [char] (bug#7541).
919
5cc7f7af
KH
9202011-08-02 Kenichi Handa <handa@m17n.org>
921
d0fffa3f 922 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
923
924 * chartab.c (uniprop_table): Make it non-static.
925
525d5e6e
EZ
9262011-08-01 Eli Zaretskii <eliz@gnu.org>
927
928 * xdisp.c (forward_to_next_line_start): Accept additional argument
929 BIDI_IT_PREV, and store into it the state of the bidi iterator had
930 on the newline.
931 (reseat_at_next_visible_line_start): Use the bidi iterator state
932 returned by forward_to_next_line_start to restore the state of
933 it->bidi_it after backing up to previous newline. (Bug#9212)
934
31011111
AS
9352011-07-30 Andreas Schwab <schwab@linux-m68k.org>
936
937 * regex.c (re_comp): Protoize.
938 (re_exec): Fix return type.
939 (regexec): Fix type of `ret'. (Bug#9203)
940
e5d76069
PE
9412011-07-29 Paul Eggert <eggert@cs.ucla.edu>
942
943 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
944 This is needed if max-image-size is a floating-point number.
945
9a79b20c
AS
9462011-07-28 Andreas Schwab <schwab@linux-m68k.org>
947
948 * print.c (print_object): Print empty symbol as ##.
949
950 * lread.c (read1): Read ## as empty symbol.
951
d8c2fa78
AA
9522011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
953
954 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
955 setting frame foreground color (Bug#9175).
956 (x_set_background_color): Likewise.
957
ffe57a7a
AA
958 * nsmenu.m (-setText): Size tooltip dimensions precisely to
959 contents (Bug#9176).
960 (EmacsTooltip -init): Remove bezels and add shadows to
961 tooltip windows.
962
bf3492a5
AA
963 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
964 or scroll bar (Bug#8470).
965
d55e9c53
AA
966 * nsfont.m (nsfont_open): Remove assignment to voffset and
967 unnecessary vars hshink, expand, hd, full_height, min_height.
968 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
969
970 * nsterm.h (nsfont_info): Remove voffset field.
971
d8c2fa78 9722011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
973
974 Implement strike-through and overline on NextStep (Bug#8863).
975
976 * nsfont.m (nsfont_open): Use underline position provided by font,
977 instead of hard-coded value of 2.
978 (nsfont_draw): Call ns_draw_text_decoration instead.
979
980 * nsterm.h: Add declaration for ns_draw_text_decoration.
981
982 * nsterm.m (ns_draw_text_decoration): New function for drawing
983 underline, overline, and strike-through.
984 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
985 ns_draw_text_decoration. Change treatment of cursor drawing to
986 accomodate underlining, etc.
987
4cc60b9b
EZ
9882011-07-28 Eli Zaretskii <eliz@gnu.org>
989
bc7ece87
EZ
990 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
991 default.
4cc60b9b 992
476371c4
PE
9932011-07-28 Paul Eggert <eggert@cs.ucla.edu>
994
66606eea
PE
995 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
996 Without this fix, if a signal arrives just after memory fills up,
997 'malloc' might be invoked reentrantly.
998
476371c4
PE
999 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1000 In other words, assume that every image size is allowed, on non-X
1001 hosts. This assumption is probably wrong, but it lets Emacs compile.
1002
f3fcc40d
AS
10032011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1004
1005 * regex.c (re_iswctype): Convert return values to boolean.
1006
350c992f
EZ
10072011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1008
1009 * xdisp.c (compute_display_string_pos): Don't use cached display
1010 string position if the buffer had its restriction changed.
1011 (Bug#9184)
1012
5266b4bb
PE
10132011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1014
1015 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1016
2573a837 10172011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1018
41f55ccd 1019 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1020
39e378da
PE
1021 * bidi.c: Integer size and overflow fixes.
1022 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1023 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1024 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1025 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1026 (bidi_find_other_level_edge):
1027 Use ptrdiff_t instead of EMACS_INT where either will do.
1028 This works better on 32-bit hosts configured --with-wide-int.
1029 (bidi_cache_ensure_space): Check for size-calculation overflow.
1030 Use % rather than repeated addition, for better worst-case speed.
1031 Don't set bidi_cache_size until after xrealloc returns, because it
1032 might not return.
1033 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1034 (bidi_cache_ensure_space): Also check that the bidi cache size
1035 does not exceed that of the largest Lisp string or buffer. See Eli
1036 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1037
5e927815
PE
1038 * alloc.c (__malloc_size_t): Remove.
1039 All uses replaced by size_t. See Andreas Schwab's note
1040 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1041
ca4aa935
PE
1042 * image.c: Improve checking for integer overflow.
1043 (check_image_size): Assume that f is nonnull, since
1044 it is always nonnull in practice. This is one less thing to
1045 worry about when checking for integer overflow later.
1046 (x_check_image_size): New function, which checks for integer
1047 overflow issues inside X.
1048 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1049 This removes the need for a memory_full check.
1050 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1051 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1052 (xbm_read_bitmap_data): Change locals back to 'int', since
1053 their values must fit in 'int'.
1054 (xpm_load_image, png_load, tiff_load):
1055 Invoke x_create_x_image_and_pixmap earlier,
1056 to avoid much needless work if the image is too large.
1057 (tiff_load): Treat overly large images as if
1058 x_create_x_image_and_pixmap failed, not as malloc failures.
1059 (gs_load): Use x_check_image_size.
1060
5f8f9cc2
PE
1061 * gtkutil.c: Omit integer casts.
1062 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1063 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1064
5adf60bc
PE
1065 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1066
c8907a93
PE
1067 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1068 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1069 would wrongly return t on a 64-bit host.
1070
e3c25c68
PE
1071 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1072 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1073 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1074 and therefore cause GCC to emit a bogus diagnostic in some cases.
1075
3f791afe
PE
1076 * image.c: Integer signedness and overflow and related fixes.
1077 This is not an exhaustive set of fixes, but it's time to
1078 record what I've got.
1079 (lookup_pixel_color, check_image_size): Remove redundant decls.
1080 (check_image_size): Don't assume that arbitrary EMACS_INT values
1081 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1082 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1083 (tiff_load, imagemagick_load_image):
1084 Check for overflow in size calculations.
1085 (x_create_x_image_and_pixmap): Remove unnecessary test for
1086 xmalloc returning NULL; that can't happen.
1087 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1088 (xpm_color_bucket): Use better integer hashing function.
1089 (xpm_cache_color): Don't possibly over-allocate memory.
1090 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1091 (gif_memory_source):
1092 Use ptrdiff_t, not int or size_t, to record sizes.
1093 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1094 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1095 either works, as we prefer signed integers.
1096 (tiff_read_from_memory, tiff_write_from_memory):
1097 Return tsize_t, not size_t, since that's what the TIFF API wants.
1098 (tiff_read_from_memory): Don't fail simply because the read would
1099 go past EOF; instead, return a short read.
1100 (tiff_load): Omit no-longer-needed casts.
1101 (Fimagemagick_types): Don't assume size fits into 'int'.
1102
3cc5a532
PE
1103 Improve hashing quality when configured --with-wide-int.
1104 * fns.c (hash_string): New function, taken from sxhash_string.
1105 Do not discard information about ASCII character case; this
1106 discarding is no longer needed.
1107 (sxhash-string): Use it. Change sig to match it. Caller changed.
1108 * lisp.h: Declare it.
1109 * lread.c (hash_string): Remove, since we now use fns.c's version.
1110 The fns.c version returns a wider integer if --with-wide-int is
1111 specified, so this should help the quality of the hashing a bit.
1112
b312a492
PE
1113 * emacs.c: Integer overflow minor fix.
1114 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1115 Define only if GNU_LINUX.
1116 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1117
dfd153ae
PE
1118 * dispnew.c: Integer signedness and overflow fixes.
1119 Remove unnecessary forward decls, that were a maintenance hassle.
1120 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1121 All uses changed.
1122 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1123 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1124 (prepare_desired_row, line_draw_cost):
1125 Use int, not unsigned, where either works.
1126 (save_current_matrix, restore_current_matrix):
1127 Use ptrdiff_t, not size_t, where either works.
1128 (init_display): Check for overflow more accurately, and without
1129 relying on undefined behavior.
1130
a81d11a3
PE
1131 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1132 Remove, replacing with the new symbols in lisp.h. All uses changed.
1133 * fileio.c (make_temp_name):
1134 * filelock.c (lock_file_1, lock_file):
1135 * xdisp.c (message_dolog):
1136 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1137 Use pMd etc. instead.
1138 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1139 replacing the pWIDE etc. symbols removed from editfns.c.
1140
3300e6fd
PE
1141 * keyboard.h (num_input_events): Now uintmax_t.
1142 This is (very slightly) less likely to mess up due to wraparound.
1143 All uses changed.
1144
fd05c7e9
PE
1145 * buffer.c: Integer signedness fixes.
1146 (alloc_buffer_text, enlarge_buffer_text):
1147 Use ptrdiff_t rather than size_t when either will do, as we prefer
1148 signed integers.
1149
903fe15d
PE
1150 * alloc.c: Integer signedness and overflow fixes.
1151 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1152 (__malloc_size_t): Default to size_t, not to int.
1153 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1154 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1155 Prefer ptrdiff_t to size_t when either would do, as we prefer
1156 signed integers.
1157 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1158 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1159 Now const. Initialize with values that are in range even if char
1160 is signed.
1161 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1162 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1163 These functions do the right thing with sizes > 2**32.
1164 (check_depth): Now ptrdiff_t, not int.
1165 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1166 Adjust to new way of storing sizes. Check for size overflow bugs
1167 in rest of code.
1168 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1169 slightly wrong anyway, as it missed one instance of
1170 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1171 (refill_memory_reserve): Omit needless cast to size_t.
1172 (mark_object_loop_halt): Mark as externally visible.
1173
ac82cc6a
PE
1174 * xselect.c: Integer signedness and overflow fixes.
1175 (Fx_register_dnd_atom, x_handle_dnd_message):
1176 Use ptrdiff_t, not size_t, since we prefer signed.
1177 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1178 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1179 x_dnd_atoms_size and x_dnd_atoms_length.
1180
c2d1e36d
PE
1181 * doprnt.c: Prefer signed to unsigned when either works.
1182 * eval.c (verror):
1183 * doprnt.c (doprnt):
1184 * lisp.h (doprnt):
1185 * xdisp.c (vmessage):
1186 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1187 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1188 prefer signed arithmetic to avoid comparison confusion.
1189 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1190 but is a bit tricky.
1191
0e926e56
PE
1192 Assume freestanding C89 headers, string.h, stdlib.h.
1193 * data.c, doprnt.c, floatfns.c, print.c:
1194 Include float.h unconditionally.
1195 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1196 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1197 * regex.c: Likewise for stddef.h, string.h.
1198 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1199 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1200 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1201 (STDC_HEADERS): Remove obsolete defines.
1202 * sysdep.c: Include limits.h unconditionally.
1203
9cfdb3ec
PE
1204 Assume support for memcmp, memcpy, memmove, memset.
1205 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1206 * regex.c (memcmp, memcpy):
1207 Remove; we assume C89 now.
1208
1209 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1210 (__malloc_safe_bcopy): Remove; no longer needed.
1211
cf950e6b 1212 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1213 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1214 well either way, and we prefer signed to unsigned.
1215
dbf38e02
LMI
12162011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1217
1218 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1219 closes the connection while we're reading (bug#9182).
1220
d6f0886c
JD
12212011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1222
1223 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1224 are specified (Bug#9168).
1225
2eb1f9e6
PE
12262011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1227
1228 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1229 Found by GCC static checking and --with-wide-int on a 32-bit host.
1230
22381272 12312011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1232
1233 * xdisp.c (compute_display_string_pos): Fix logic of caching
1234 previous display string position. Initialize cached_prev_pos to
1235 -1. Fixes slow-down at the beginning of a buffer.
1236
f25e39b4
EZ
12372011-07-24 Eli Zaretskii <eliz@gnu.org>
1238
1239 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1240 for attrs[LFACE_FONTSET_INDEX].
1241
04c4b52e
PE
12422011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1243
1244 * xml.c (parse_region): Remove unused local
1245 that was recently introduced.
1246
c1734fbd
EZ
12472011-07-23 Eli Zaretskii <eliz@gnu.org>
1248
be18c5a5
EZ
1249 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1250 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1251
c1734fbd
EZ
1252 * xdisp.c (move_it_in_display_line_to): Record the best matching
1253 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1254 exit if none of the characters scanned was an exact match.
1255 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1256 when exact match is impossible due to invisible text, and the
1257 lines are truncated.
1258
a258d627
JD
12592011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1260
1261 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1262 for OSX >= 10.7.
1263
b6d5a689
EZ
12642011-07-22 Eli Zaretskii <eliz@gnu.org>
1265
0f74f785
EZ
1266 Fix a significant slow-down of cursor motion with C-n, C-p,
1267 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1268 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1269 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1270 (next_element_from_buffer): Call compute_stop_pos_backwards to
1271 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1272 base_level_stop.
1273 (reseat): Don't look for prev_stop, as that could mean a very long
1274 run.
1275 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1276 <cached_disp_overlay_modiff>: Cache for last found display string
1277 position.
551918c1 1278 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1279 about the same buffer in the same area of character positions, and
1280 the buffer wasn't changed since the time the display string
1281 position was cached.
551918c1 1282
b2d0c91a
EZ
12832011-07-22 Eli Zaretskii <eliz@gnu.org>
1284
1285 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1286 is an integer, which is important for empty lines. (Bug#9149)
1287
043604ee
CY
12882011-07-22 Chong Yidong <cyd@stupidchicken.com>
1289
1290 * frame.c (Fmodify_frame_parameters): In tty case, update the
1291 default face if necessary (Bug#4238).
1292
da4adb04
CY
12932011-07-21 Chong Yidong <cyd@stupidchicken.com>
1294
1295 * editfns.c (Fstring_to_char): No need to explain what a character
1296 is in the docstring (Bug#6576).
1297
9abd0532
LMI
12982011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1299
1300 * xml.c (parse_region): Make sure we always return a tree.
1301
36881d16
HK
13022011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1303
1304 * xml.c (parse_region): If a document contains only comments,
1305 return that, too.
1306
1e98674d
LMI
13072011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1308
1309 * xml.c (make_dom): Return comments, too.
1310
590bd467
PE
13112011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1312
1313 Port to OpenBSD.
1314 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1315 and the surrounding thread.
1316 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1317 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1318 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1319 timer goes off.
1320 * s/openbsd.h (BROKEN_SIGIO): Define.
1321 * unexelf.c (unexec) [__OpenBSD__]:
1322 Don't update the .mdebug section of the Alpha COFF symbol table.
1323
f41628b2
LMI
13242011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1325
1326 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1327 (bug#8460).
1328
b59b67c5
PE
13292011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1330
15e3a074
PE
1331 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1332 This fixes some race conditions on the permissions of any newly
1333 created file.
1334
41bed37d
PE
1335 * alloc.c (valid_pointer_p): Use pipe, not open.
1336 This fixes some permissions issues when debugging.
1337
b59b67c5
PE
1338 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1339 If fchown fails to set both uid and gid, try to set just gid,
1340 as that is sometimes allowed. Adjust the file's mode to eliminate
1341 setuid or setgid bits that are inappropriate if fchown fails.
1342
925a6be7
SM
13432011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1344
1345 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1346 to compare Lisp_Objects.
1347 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1348 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1349 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1350
52968808
AS
13512011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1352
0a6a104b
AS
1353 * lread.c (read_integer): Unread even EOF character.
1354 (read1): Likewise. Properly record start position of symbol.
1355
52968808
AS
1356 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1357 symbol character follows.
1358
9e381cdd
PE
13592011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1360
1361 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1362 This works around a problem with the previous change to Fcopy_file.
1363 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1364 and without this change, GCC might complain about discarding
1365 fchown's return value.
1366
b5641435
JB
13672011-07-16 Juanma Barranquero <lekktu@gmail.com>
1368
1369 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1370
a8031457
PE
13712011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1372
1373 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1374
dd889327
LMI
13752011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1376
750c33f7
LMI
1377 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1378 it's used from the C level.
1379
dd889327
LMI
1380 * process.c: Use the same condition for POLL_FOR_INPUT in both
1381 keyboard.c and process.c (bug#1858).
1382
87e86684
LM
13832011-07-09 Lawrence Mitchell <wence@gmx.li>
1384
1385 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1386 (Fgnutls_boot): Use it.
1387
64348f40
AS
13882011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1389
1390 * doc.c (Fsubstitute_command_keys): Revert last change.
1391
1d698799
LMI
13922011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1393
f863868c
LMI
1394 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1395 quotes the next character, and doesn't affect other longer
1396 sequences (bug#8935).
1397
1d698799
LMI
1398 * lread.c (syms_of_lread): Clarify that is isn't only
1399 `eval-buffer' and `eval-defun' that's affected by
1400 `lexical-binding' (bug#8460).
1401
aa4b6df6
EZ
14022011-07-15 Eli Zaretskii <eliz@gnu.org>
1403
1404 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1405 bidi redisplay when a line includes both an image and is
1406 truncated.
1407
5d856da6
PE
14082011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1409
ad6042bb
PE
1410 Fix minor problems found by static checking.
1411 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1412 (elsz): Now a signed constant, not a size_t var. We prefer signed
1413 types to unsigned, to avoid integer comparison confusion. Without
1414 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1415 "cannot optimize loop, the loop counter may overflow", a symptom
1416 of the confusion.
f00bbb22 1417 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1418 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1419
6468f31c
LMI
14202011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1421
49080b10
LMI
1422 * search.c (Fre_search_backward): Mention `case-fold-search' in
1423 all the re_search_* functions (bug#8138).
1424
6468f31c
LMI
1425 * keyboard.c (Fopen_dribble_file): Document when the file is
1426 closed (bug#8056).
1427
c965adc5
EZ
14282011-07-14 Eli Zaretskii <eliz@gnu.org>
1429
df9733bf
EZ
1430 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1431 bidi_cache_idx.
1432
0bb23927
EZ
1433 Support bidi reordering of display and overlay strings.
1434 * xdisp.c (compute_display_string_pos)
1435 (compute_display_string_end): Accept additional argument STRING.
1436 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1437 (reseat_to_string): Initialize bidi_it->string.s and
1438 bidi_it->string.schars.
1439 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1440 NULL (avoids a crash in bidi_paragraph_init).
1441 Initialize itb.string.lstring.
0bb23927
EZ
1442 (init_iterator): Call bidi_init_it only of a valid
1443 buffer position was specified. Initialize paragraph_embedding to
1444 L2R.
1445 (reseat_to_string): Initialize the bidi iterator.
1446 (display_string): If we need to ignore text properties of
1447 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1448 original value of -1 will not work with bidi.)
1449 (compute_display_string_pos): First arg is now struct
1450 `text_pos *'; all callers changed. Support display properties on
1451 Lisp strings.
1452 (compute_display_string_end): Support display properties on Lisp
1453 strings.
1454 (init_iterator, reseat_1, reseat_to_string): Initialize the
1455 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1456 when iterating on a string not from display properties).
640c8776
SM
1457 (compute_display_string_pos, compute_display_string_end):
1458 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1459 arrow keys.
1460 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1461 base_level_stop; instead, set base_level_stop to BEGV.
1462 Fixes crashes in vertical-motion.
0bb23927
EZ
1463 (next_element_from_buffer): Improve commentary for when
1464 the iterator is before prev_stop.
1465 (init_iterator): Initialize bidi_p from the default value of
1466 bidi-display-reordering, not from buffer-local value. Use the
1467 buffer-local value only if initializing for buffer iteration.
1468 (handle_invisible_prop): Support invisible properties on strings
1469 that are being bidi-reordered.
1470 (set_iterator_to_next): Support bidi reordering of C strings and
1471 Lisp strings.
1472 (next_element_from_string): Support bidi reordering of Lisp
1473 strings.
1474 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1475 (display_string): Support display of R2L glyph rows.
1476 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1477 (init_iterator): Don't initialize it->bidi_p for strings
1478 here.
1479 (reseat_to_string): Initialize it->bidi_p for strings here.
1480 (next_element_from_string, next_element_from_c_string)
1481 (next_element_from_buffer): Add xassert's for correspondence
1482 between IT's object being iterated and it->bidi_it.string
1483 structure.
1484 (face_before_or_after_it_pos): Support bidi iteration.
1485 (next_element_from_c_string): Handle the case of the first string
1486 character that is not the first one in the visual order.
1487 (get_visually_first_element): New function, refactored from common
1488 parts of next_element_from_buffer, next_element_from_string, and
1489 next_element_from_c_string.
1490 (tool_bar_lines_needed, redisplay_tool_bar)
1491 (display_menu_bar): Force left-to-right direction. Add a FIXME
1492 comment for making that be controlled by a user option.
1493 (push_it, pop_it): Save and restore the state of the
1494 bidi iterator. Save and restore the bidi_p flag.
1495 (pop_it): Iterate out of display property for string iteration as
1496 well.
1497 (iterate_out_of_display_property): Support iteration over strings.
1498 (handle_single_display_spec): Set up it->bidi_it for iteration
1499 over a display string, and call bidi_init_it.
1500 (handle_single_display_spec, next_overlay_string)
1501 (get_overlay_strings_1, push_display_prop): Set up the bidi
1502 iterator for displaying display or overlay strings.
1503 (forward_to_next_line_start): Don't use the shortcut if
1504 bidi-iterating.
1505 (back_to_previous_visible_line_start): If handle_display_prop
1506 pushed the iterator stack, restore the internal state of the bidi
1507 iterator by calling bidi_pop_it same number of times.
1508 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1509 and we are bidi-iterating, don't decrement the iterator position;
1510 instead, set the first_elt flag in the bidi iterator, to produce
1511 the same effect.
1512 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1513 (push_display_prop): xassert that we are iterating a buffer.
1514 (push_it, pop_it): Save and restore paragraph_embedding member.
1515 (handle_single_display_spec, next_overlay_string)
1516 (get_overlay_strings_1, reseat_1, reseat_to_string)
1517 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1518 correctly. Don't assume unibyte strings are not bidi-reordered.
1519 (compute_display_string_pos)
1520 (compute_display_string_end): Fix handling the case of C string.
1521 (push_it, pop_it): Save and restore from_disp_prop_p.
1522 (handle_single_display_spec, push_display_prop): Set the
1523 from_disp_prop_p flag.
1524 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1525 (pop_it): Call iterate_out_of_display_property only if we are
1526 popping after iteration over a string that came from a display
1527 property. Fix a typo in popping stretch info. Add an assertion
1528 for verifying that the iterator position is in sync with the bidi
1529 iterator.
1530 (handle_single_display_spec, get_overlay_strings_1)
1531 (push_display_prop): Fix initialization of paragraph direction for
1532 string when that of the parent object is not yet determined.
1533 (reseat_1): Call bidi_init_it to resync the bidi
1534 iterator with IT's position. (Bug#7616)
1535 (find_row_edges): If ROW->start.pos gives position
1536 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1537 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1538 Reset the from_disp_prop_p flag.
1539 (SAVE_IT, RESTORE_IT): New macros.
1540 (pos_visible_p, face_before_or_after_it_pos)
1541 (back_to_previous_visible_line_start)
1542 (move_it_in_display_line_to, move_it_in_display_line)
1543 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1544 (try_scrolling, redisplay_window, display_line): Use them when
1545 saving a temporary copy of the iterator and restoring it back.
1546 (back_to_previous_visible_line_start, reseat_1)
1547 (init_iterator): Empty the bidi cache "stack".
1548 (move_it_in_display_line_to): If iterator ended up at
1549 EOL, but we never saw any buffer positions smaller than
1550 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1551 motion in bidi-reordered lines.
1552 (move_it_in_display_line_to): Record prev_method and prev_pos
1553 immediately before the call to set_iterator_to_next. Fixes cursor
1554 motion in bidi-reordered lines with stretch glyphs and strings
1555 displayed in margins. (Bug#8133) (Bug#8867)
1556 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1557 TO_CHARPOS.
640c8776
SM
1558 (pos_visible_p): Support positions in bidi-reordered lines.
1559 Save and restore bidi cache.
0bb23927
EZ
1560
1561 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1562 (bidi_paragraph_info): Delete unused struct.
1563 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1564 (bidi_cache_start): New variable.
1565 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1566 to zero.
1567 (bidi_cache_fetch_state, bidi_cache_search)
1568 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1569 (bidi_cache_find, bidi_peek_at_next_level)
1570 (bidi_level_of_next_char, bidi_find_other_level_edge)
1571 (bidi_move_to_visually_next): Compare cache index with
1572 bidi_cache_start rather than with zero.
1573 (bidi_fetch_char): Accept new argument STRING; all callers
1574 changed. Support iteration over a string. Support strings with
1575 display properties. Support unibyte strings. Fix the type of
1576 `len' according to what STRING_CHAR_AND_LENGTH expects.
1577 (bidi_paragraph_init, bidi_resolve_explicit_1)
1578 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1579 (bidi_level_of_next_char, bidi_move_to_visually_next):
1580 Support iteration over a string.
0bb23927
EZ
1581 (bidi_set_sor_type, bidi_resolve_explicit_1)
1582 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1583 can now be zero (for strings); special values 0 and -1 were
1584 changed to -1 and -2, respectively.
1585 (bidi_char_at_pos): New function.
1586 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1587 Call it instead of FETCH_MULTIBYTE_CHAR.
1588 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1589 initialized to valid values.
1590 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1591 values.
1592 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1593 the test for valid cached positions. Fix the logic for looking up
1594 the sentinel state in the cache. GCPRO the Lisp string we are
1595 iterating.
1596 (bidi_push_it, bidi_pop_it): New functions.
1597 (bidi_initialize): Initialize the bidi cache start stack pointer.
1598 (bidi_cache_ensure_space): New function, refactored from part of
1599 bidi_cache_iterator_state. Don't assume the required size is just
1600 one BIDI_CACHE_CHUNK away.
1601 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1602 (bidi_count_bytes, bidi_char_at_pos): New functions.
1603 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1604 always valid if bidi_cache_idx is valid.
1605 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1606 is valid if it's going to be used.
1607 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1608 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1609 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1610 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1611 (bidi_find_other_level_edge, bidi_cache_start_stack):
1612 All variables related to cache indices are now EMACS_INT.
c965adc5 1613
0bb23927
EZ
1614 * dispextern.h (struct bidi_string_data): New structure.
1615 (struct bidi_it): New member `string'. Make flag members be 1-bit
1616 fields, and put them last in the struct.
640c8776
SM
1617 (compute_display_string_pos, compute_display_string_end):
1618 Update prototypes.
0bb23927
EZ
1619 (bidi_push_it, bidi_pop_it): Add prototypes.
1620 (struct iterator_stack_entry): New members bidi_p,
1621 paragraph_embedding, and from_disp_prop_p.
1622 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1623 (bidi_shelve_cache, bidi_unshelve_cache):
1624 Declare prototypes.
0bb23927
EZ
1625
1626 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1627 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1628 and vector-like objects.
1629
1630 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1631 cache around display iteration.
1632
1633 * window.c (Fwindow_end, window_scroll_pixel_based)
1634 (displayed_window_lines, Frecenter): Save and restore the bidi
1635 cache around display iteration.
1636
3bbd2265
LMI
16372011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1638
1639 * editfns.c (Fdelete_region): Clarify the use of the named
1640 parameters (bug#6788).
1641
adc47434
MR
16422011-07-14 Martin Rudalics <rudalics@gmx.at>
1643
1644 * indent.c (Fvertical_motion): Set and restore w->pointm when
1645 saving and restoring the window's buffer (Bug#9006).
1646
837c31f8
LMI
16472011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1648
1649 * editfns.c (Fstring_to_char): Clarify just what is returned
1650 (bug#6576). Text by Eli Zaretskii.
1651
ac389d0c
JB
16522011-07-13 Juanma Barranquero <lekktu@gmail.com>
1653
1654 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1655
0be0ce47
EZ
16562011-07-13 Eli Zaretskii <eliz@gnu.org>
1657
1658 * buffer.c (mmap_find): Fix a typo.
1659
cd18e7e3
JB
16602011-07-13 Johan Bockgård <bojohan@gnu.org>
1661
1662 Fix execution of x selection hooks.
1663 * xselect.c (Qx_lost_selection_functions)
1664 (Qx_sent_selection_functions): New vars.
1665 (syms_of_xselect): DEFSYM them.
1666 (x_handle_selection_request): Pass Qx_sent_selection_functions
1667 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1668 (x_handle_selection_clear,x_clear_frame_selections):
1669 Pass Qx_lost_selection_functions rather than
1670 Vx_lost_selection_functions to Frun_hook_with_args.
1671
47ea7f44
PE
16722011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1673
ac389d0c 1674 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1675 The old code sometimes used this field without initializing it.
1676
47ea7f44
PE
1677 * alloc.c (gc_sweep): Don't read past end of array.
1678 In theory, the old code could also have corrupted Emacs internals,
1679 though it'd be very unlikely.
1680
bc985c87
AS
16812011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1682
1683 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1684 argument. (Bug#4026)
bc985c87 1685
0cf34688
LMI
16862011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1687
b3dadd76
LMI
1688 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1689 key" (bug#4257).
1690
0cf34688
LMI
1691 * window.c (Fset_window_start): Doc fix (bug#4199).
1692 (Fset_window_hscroll): Ditto.
1693
270768cd
PE
16942011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1695
077e3dda 1696 Fix minor new problems caught by GCC 4.6.1.
270768cd 1697 * term.c (init_tty): Remove unused local.
490011a6 1698 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1699 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1700 not used otherwise.
270768cd 1701
b1f58454
CY
17022011-07-12 Chong Yidong <cyd@stupidchicken.com>
1703
1704 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1705
22b9578d
LMI
17062011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1707
6e70ab07
LMI
1708 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1709 are the mini-buffer and the echo area (bug#3320).
1710
22b9578d
LMI
1711 * term.c (init_tty): Remove support for supdup, c10 and perq
1712 terminals, which are no longer supported (bug#1482).
1713
8974cc9f
JB
17142011-07-10 Johan Bockgård <bojohan@gnu.org>
1715
1716 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1717
a560d974
JD
17182011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1719
1720 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1721 for non-popups (Bug#3642).
1722
1dae0f0a
AS
17232011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1724
268c2c36 1725 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1726 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1727 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1728 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1729 * data.c (fmod): Likewise.
1730 * dispnew.c (swap_glyphs_in_rows): Likewise.
1731 * emacs.c (memory_warning_signal): Likewise.
1732 * floatfns.c (float_error): Likewise.
1733 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1734 (otf_open, font_otf_capability, generate_otf_features)
1735 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1736 Likewise.
1737 * image.c (pbm_read_file): Likewise.
1738 * indent.c (string_display_width): Likewise.
1739 * intervals.c (check_for_interval, search_for_interval)
1740 (inc_interval_count, count_intervals, root_interval)
1741 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1742 * lread.c (defalias): Likewise.
268c2c36 1743 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1744 * regex.c (set_image_of_range_1, set_image_of_range)
1745 (regex_grow_registers): Likewise.
1746 * sysdep.c (strerror): Likewise.
1747 * termcap.c (valid_filename_p, tprint, main): Likewise.
1748 * tparam.c (main): Likewise.
1749 * unexhp9k800.c (run_time_remap, save_data_space)
1750 (update_file_ptrs, read_header, write_header, calculate_checksum)
1751 (copy_file, copy_rest, display_header): Likewise.
1752 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1753 Likewise.
1754 * xdisp.c (check_it): Likewise.
1755 * xfaces.c (register_color, unregister_color, unregister_colors):
1756 Likewise.
1757 * xfns.c (print_fontset_result): Likewise.
1758 * xrdb.c (member, fatal, main): Likewise.
1759
99033785
PE
17602011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1761
1762 Fix minor problems found by static checking (Bug#9031).
1763 * chartab.c (char_table_set_range, map_sub_char_table):
1764 Remove unused locals.
1765 (uniprop_table): Now static.
1766 * composite.c (_work_char): Remove unused static var.
1767
9cb2ac56
JB
17682011-07-09 Juanma Barranquero <lekktu@gmail.com>
1769
1770 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1771
f25661f0
JD
17722011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1773
1774 * gtkutil.c (qttip_cb): Remove code without function.
1775
8278c4fe
EZ
17762011-07-09 Eli Zaretskii <eliz@gnu.org>
1777
1778 * w32.c (pthread_sigmask): New stub.
1779
1692ae2d 17802011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1781
8a6ebd58 1782 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1783 sigprocmask is portable only for single-threaded applications, and
1784 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1785 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1786 (LIBES): Use it.
1787 * callproc.c (Fcall_process):
1788 * process.c (create_process):
1789 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1790 Use pthread_sigmask, not sigprocmask.
123403e4 1791
1b854618
JD
17922011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1793
1794 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1795 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1796 wrong (Bug#8591).
1797
3fe4b549
JD
17982011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1799
0ce7e563
JD
1800 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1801 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1802 (xg_hide_tooltip): Fix comment.
1803
3fe4b549
JD
1804 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1805 in registerServicesMenuSendTypes.
1806 (validRequestorForSendType): Don't check ns_return_types.
1807
1808 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1809 ns_return_type.
1810
5df75e47
JR
18112011-07-08 Jason Rumney <jasonr@gnu.org>
1812
1813 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1814 frame struct members of non-existent frames (Bug#6284).
1815
699c10bd
JD
18162011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1817
4393663b
JD
1818 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1819 variable firstTime not needed on OSX >= 10.6.
1820 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1821 >= 10.5. Use setKnobProportion, setDoubleValue.
1822
1823 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1824 (MAC_OS_X_VERSION_10_5): Define if not defined.
1825 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1826 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1827 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1828
1829 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1830 cString and lossyCString on OSX >= 10.4
1831
1832 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1833 sizeToFit on OSX >= 10.2.
1834
1835 * nsimage.m (allocInitFromFile): Don't use deprecated method
1836 bestRepresentationForDevice on OSX >= 10.6.
1837
1838 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1839 to avoid warning.
1840
1841 * emacs.c: Declare unexec_init_emacs_zone.
1842
a63e0781
JD
1843 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1844
699c10bd
JD
1845 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1846
1847 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1848 on svcsMenu (Bug#8842).
1849
1850 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1851 ns_return_types.
1852 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1853
1854 * nsterm.m (QUTF8_STRING): Declare.
1855 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1856 (validRequestorForSendType): Return type is (id).
1857 Change indexOfObjectIdenticalTo to indexOfObject.
1858 Check if we have local selection before returning self (Bug#8842).
1859 (writeSelectionToPasteboard): Put local selection into paste board
1860 if we have a local selection (Bug#8842).
1861 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1862
1863 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1864 (ns_get_local_selection): Declare.
1865
54e10184
LMI
18662011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1867
9888ff71
LMI
1868 * keymap.c (describe_map_tree): Don't insert a double newline at
1869 the end of the buffer (bug#1169) and return whether we inserted
1870 something.
1871
54e10184
LMI
1872 * callint.c (Fcall_interactively): Change "reading args" to
1873 "providing args" to try to clarify what it does (bug#1010).
1874
15fa4783
KH
18752011-07-07 Kenichi Handa <handa@m17n.org>
1876
1877 * composite.c (composition_compute_stop_pos): Ignore a static
1878 composition starting before CHARPOS (Bug#8915).
1879
1880 * xdisp.c (handle_composition_prop): Likewise.
1881
a8815b00
EZ
18822011-07-07 Eli Zaretskii <eliz@gnu.org>
1883
1884 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1885 (Bug#9015)
1886
ef7b981d 18872011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1888
1889 * character.h (unicode_category_t): New enum type.
1890
1891 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1892 (Qchar_code_property_table): New variable.
1893 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1894 (UNIPROP_COMPRESSED_FORM_P): New macros.
1895 (char_table_ascii): Uncompress the compressed values.
1896 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1897 Uncompress the compressed values.
ac389d0c 1898 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1899 (char_table_ref_and_range): Uncompress the compressed values.
1900 (sub_char_table_set): New arg is_uniprop. Callers changed.
1901 Uncompress the compressed values.
1902 (sub_char_table_set_range): Args changed. Callers changed.
1903 (char_table_set_range): Adjuted for the above change.
1904 (map_sub_char_table): Delete args default_val and parent. Add arg
1905 top. Give decoded values to a Lisp function.
640c8776 1906 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1907 values to a Lisp function. Gcpro more variables.
1908 (uniprop_table_uncompress)
1909 (uniprop_decode_value_run_length): New functions.
1910 (uniprop_decoder, uniprop_decoder_count): New variables.
1911 (uniprop_get_decoder, uniprop_encode_value_character)
1912 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1913 New functions.
1914 (uniprop_encoder, uniprop_encoder_count): New variables.
1915 (uniprop_get_encoder, uniprop_table)
1916 (Funicode_property_table_internal, Fget_unicode_property_internal)
1917 (Fput_unicode_property_internal): New functions.
1918 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1919 Sunicode_property_table_internal, Sget_unicode_property_internal,
1920 and Sput_unicode_property_internal. Defvar_lisp
1921 char-code-property-alist.
1922
640c8776 1923 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1924 Vunicode_category_table.
1925
640c8776 1926 * font.c (font_range): Adjust for the change of
c805dec0
KH
1927 Vunicode_category_table.
1928
76b397fb
DN
19292011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1930
1931 * m/iris4d.h: Remove file, move contents ...
1932 * s/irix6-5.h: ... here.
1933
22b4128e
PE
19342011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1935
1936 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1937 * alloc.c (mark_buffer):
1938 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1939 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1940 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1941 This isn't true in general, and it's particularly not true
1942 if Emacs is configured with --with-wide-int.
1943 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1944 New macros, used in the buffer.c change.
1945
869795d6
JD
19462011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1947
1948 * xsettings.c: Use both GConf and GSettings if both are available.
1949 (store_config_changed_event): Add comment.
1950 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1951 (store_tool_bar_style_changed): New functions.
1952 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1953 (struct xsettings): Move font inside HAVE_XFT.
1954 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 1955 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 1956 Move inside HAVE_XFT.
640c8776 1957 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
1958 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1959 also.
1960 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
1961 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1962 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
1963 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1964 (parse_settings): Move check for font inside HAVE_XFT.
1965 (read_settings, apply_xft_settings): Add comment.
1966 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1967 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1968 call store_font_name_changed.
1969 (xft_settings_event): Add comment.
1970 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1971 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1972 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1973 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1974 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
1975 (xsettings_get_system_font, xsettings_get_system_normal_font):
1976 Add comment.
869795d6 1977
d8ed26bd
PE
19782011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1979
1980 Random fixes. E.g., (random) never returned negative values.
1981 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1982 subseconds part to the entropy, as that's a bit more random.
1983 Prefer signed to unsigned, since the signedness doesn't matter and
1984 in general we prefer signed. When given a limit, use a
1985 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1986 latter isn't right if USE_2_TAGS_FOR_INTS.
1987 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1988 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1989
cabf1cac
SM
19902011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1991
1992 * textprop.c (text_property_stickiness):
1993 Obey Vtext_property_default_nonsticky.
1994 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1995 * w32fns.c (syms_of_w32fns):
1996 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1997
6e9b2be9
PE
19982011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1999
2000 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2001 This is more efficient than Ffile_directory_p and avoids a minor race.
2002
90186c68
LMI
20032011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2004
7c301272
LMI
2005 * buffer.c (Foverlay_put): Say what the return value is
2006 (bug#7835).
2007
c4f2d8d4
LMI
2008 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2009 is a directory before asking whether to use the file name
2010 (bug#7564).
ad637907
LMI
2011 (barf_or_query_if_file_exists): Make the "File is a directory"
2012 error be more correct.
c4f2d8d4 2013
90186c68
LMI
2014 * fns.c (Frequire): Remove the mention of the .gz files, since
2015 that's installation-specific, but keep the mention of
2016 `get-load-suffixes'.
2017
da64016e
PE
20182011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2019
2020 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2021 Report string overflow if the output is too long.
2022
7d47b580
JB
20232011-07-04 Juanma Barranquero <lekktu@gmail.com>
2024
a555cb87
JB
2025 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2026 (syms_of_gnutls): Remove duplicate DEFSYM for
2027 Qgnutls_bootprop_verify_hostname_error, an error for
2028 Qgnutls_bootprop_verify_error (which is no longer used).
2029
7d47b580
JB
2030 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2031 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2032 Also (re)move comments that are misplaced or no longer relevant.
2033
1e49bfab
LMI
20342011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2035
2036 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2037
1485f4c0
CY
20382011-07-03 Chong Yidong <cyd@stupidchicken.com>
2039
2040 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2041 and background color parameters if they have been changed.
2042
a9ab721e
LMI
20432011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2044
2045 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2046
cf7cff57
PE
20472011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2048
2e13213d
PE
2049 * xsettings.c (SYSTEM_FONT): Define only when used.
2050 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2051
cf7cff57
PE
2052 * keymap.c (access_keymap_1): Now static.
2053
7a8e04f7
CY
20542011-07-02 Chong Yidong <cyd@stupidchicken.com>
2055
2056 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2057 leave any prefix arg for the up event (Bug#1586).
2058
61352f62
LMI
20592011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2060
69bb1ef7
LMI
2061 * lread.c (syms_of_lread): Mention single symbols defined by
2062 `defvar' or `defconst' (bug#7154).
2063
61352f62 2064 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2065 (Frequire): Mention get-load-suffixes.
61352f62 2066
28545e04
MR
20672011-07-02 Martin Rudalics <rudalics@gmx.at>
2068
2069 * window.h (window): Remove clone_number slot.
2070 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2071 Remove.
2072 (make_parent_window, make_window, saved_window)
2073 (Fset_window_configuration, save_window_save): Don't deal with
2074 clone numbers.
2075 * buffer.c (Qclone_number): Remove declaration.
2076 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2077
3349e122
SM
20782011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2079
2080 Add multiple inheritance to keymaps.
2081 * keymap.c (Fmake_composed_keymap): New function.
2082 (Fset_keymap_parent): Simplify.
2083 (fix_submap_inheritance): Remove.
2084 (access_keymap_1): New function extracted from access_keymap to handle
2085 embedded parents and handle lists of maps.
2086 (access_keymap): Use it.
2087 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2088 (Fcopy_keymap): Handle embedded parents.
2089 (Fcommand_remapping, define_as_prefix): Simplify.
2090 (Fkey_binding): Simplify.
2091 (syms_of_keymap): Move minibuffer-local-completion-map,
2092 minibuffer-local-filename-completion-map,
2093 minibuffer-local-must-match-map, and
2094 minibuffer-local-filename-must-match-map to Elisp.
2095 (syms_of_keymap): Defsubr make-composed-keymap.
2096 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2097 (parse_menu_item): Trivial simplification.
2098
3279eb87
GM
20992011-07-01 Glenn Morris <rgm@gnu.org>
2100
2101 * Makefile.in (SETTINGS_LIBS): Fix typo.
2102
4550efdf
KI
21032011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2104
2105 * coding.c (Fencode_coding_string): Record the last coding system
2106 used, as the function doc string says (bug#8738).
2107
0949d2b6
JD
21082011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2109
2110 * xsettings.c (store_monospaced_changed): Take new font as arg and
2111 check for change against current_mono_font.
2112 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2113 (emacs_settings_constructor, emacs_settings_get_property)
2114 (emacs_settings_set_property, emacs_settings_class_init)
2115 (emacs_settings_init, gsettings_obj): Remove.
2116 (something_changedCB): New function for HAVE_GSETTINGS.
2117 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2118 with value as argument.
2119 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2120 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2121 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2122 "changed".
2123
2124 * xgselect.c: Add defined (HAVE_GSETTINGS).
2125 (xgselect_initialize): Ditto.
2126
2127 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2128 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2129 xg_select.
2130
bbc6b304
PE
21312011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2132
2133 * eval.c (struct backtrace): Simplify and port the data structure.
2134 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2135 signed bit field, as this assumption is not portable and it makes
2136 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2137 "char debug_on_exit : 1" as this is not portable either; instead,
2138 use the portable "unsigned int debug_on_exit : 1". Remove unused
2139 member evalargs. Remove obsolete comments about cc bombing out.
2140
9851bfc5
JD
21412011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2142
51bb811f 2143 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2144 Let HAVE_GSETTINGS override HAVE_GCONF.
2145 (store_monospaced_changed): New function.
2146 (EMACS_SETTINGS): A new type derived from GObject to handle
2147 GSettings notifications.
2148 (emacs_settings_constructor, emacs_settings_get_property)
2149 (emacs_settings_set_property, emacs_settings_class_init):
2150 New functions.
2151 (gsettings_client, gsettings_obj): New variables.
2152 (GSETTINGS_SCHEMA): New define.
2153 (something_changedCB): Call store_monospaced_changed.
2154 (init_gsettings): New function.
2155 (xsettings_initialize): Call init_gsettings.
2156 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2157 to NULL.
2158
640c8776 2159 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2160 GCONF_CFLAGS/LIBS.
2161
5386012d
MR
21622011-06-29 Martin Rudalics <rudalics@gmx.at>
2163
2164 * window.c (resize_root_window, grow_mini_window)
2165 (shrink_mini_window): Rename Qresize_root_window to
2166 Qwindow_resize_root_window and Qresize_root_window_vertically to
2167 Qwindow_resize_root_window_vertically.
2168
f13e0b08
PE
21692011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2170
2171 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2172
94515237
JB
21732011-06-27 Juanma Barranquero <lekktu@gmail.com>
2174
2175 * makefile.w32-in: Redesign dependencies so they reflect more
2176 clearly which files are directly included by each source file,
2177 and not through other includes.
2178
e43b6e43
MR
21792011-06-27 Martin Rudalics <rudalics@gmx.at>
2180
2181 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2182 (sort_overlays, overlay_strings): When an overlay's clone number
2183 matches the window's clone number process the overlay even if
2184 the overlay's window property doesn't match the current window.
2185
d68443dc
MR
2186 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2187 (Fwindow_hchild): Rename to Fwindow_left_child.
2188 (Fwindow_next): Rename to Fwindow_next_sibling.
2189 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2190 (resize_window_check): Rename to window_resize_check.
2191 (resize_window_apply): Rename to window_resize_apply.
2192 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2193 (Fdelete_other_windows_internal, resize_frame_windows)
2194 (Fsplit_window_internal, Fdelete_window_internal)
2195 (grow_mini_window, shrink_mini_window)
2196 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2197
c7e73be5
JD
21982011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2199
2200 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2201 (emacs_fixed_set_min_size): Remove.
2202 (emacs_fixed_new): Take frame as argument.
2203
2204 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2205 (_EmacsFixedPrivate): Remove minwidth/height.
2206 Add struct frame *f.
2207 (emacs_fixed_init): Initialize priv->f.
2208 (get_parent_class, emacs_fixed_set_min_size): Remove.
2209 (emacs_fixed_new): Set priv->f to argument.
2210 (emacs_fixed_get_preferred_width)
2211 (emacs_fixed_get_preferred_height): Use min_width/height from
2212 frames size_hint to set minimum and natural (Bug#8919).
2213 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2214 and use min_width/height from frames size_hint to set
2215 min_width/height (Bug#8919).
2216
2217 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2218 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2219 Fix indentation.
c7e73be5 2220
cf99dcf8
EZ
22212011-06-26 Eli Zaretskii <eliz@gnu.org>
2222
2223 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2224 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2225 called at ZV.
2226
029529ac
CY
22272011-06-26 Chong Yidong <cyd@stupidchicken.com>
2228
2229 * process.c (wait_reading_process_output): Bypass select if
2230 waiting for a cell while ignoring keyboard input, and input is
2231 pending. Suggested by Jan Djärv (Bug#8869).
2232
7a7ef429
PE
22332011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2234
2235 Use gnulib's dup2 module instead of rolling our own.
2236 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2237
11fdef7d 22382011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2239
2240 * dispnew.c (scrolling_window): Before scrolling, turn off a
2241 mouse-highlight in the window being scrolled.
2242
cd3520a4
JB
22432011-06-24 Juanma Barranquero <lekktu@gmail.com>
2244
2245 Move DEFSYM to lisp.h and use everywhere.
2246
2247 * character.h (DEFSYM): Move declaration...
2248 * lisp.h (DEFSYM): ...here.
2249
2250 * gnutls.c:
2251 * minibuf.c:
2252 * w32menu.c:
2253 * w32proc.c:
2254 * w32select.c: Don't include character.h.
2255
2256 * alloc.c (syms_of_alloc):
2257 * buffer.c (syms_of_buffer):
2258 * bytecode.c (syms_of_bytecode):
2259 * callint.c (syms_of_callint):
2260 * casefiddle.c (syms_of_casefiddle):
2261 * casetab.c (init_casetab_once):
2262 * category.c (init_category_once, syms_of_category):
2263 * ccl.c (syms_of_ccl):
2264 * cmds.c (syms_of_cmds):
2265 * composite.c (syms_of_composite):
2266 * dbusbind.c (syms_of_dbusbind):
2267 * dired.c (syms_of_dired):
2268 * dispnew.c (syms_of_display):
2269 * doc.c (syms_of_doc):
2270 * editfns.c (syms_of_editfns):
2271 * emacs.c (syms_of_emacs):
2272 * eval.c (syms_of_eval):
2273 * fileio.c (syms_of_fileio):
2274 * fns.c (syms_of_fns):
2275 * frame.c (syms_of_frame):
2276 * fringe.c (syms_of_fringe):
2277 * insdel.c (syms_of_insdel):
2278 * keymap.c (syms_of_keymap):
2279 * lread.c (init_obarray, syms_of_lread):
2280 * macros.c (syms_of_macros):
2281 * msdos.c (syms_of_msdos):
2282 * print.c (syms_of_print):
2283 * process.c (syms_of_process):
2284 * search.c (syms_of_search):
2285 * sound.c (syms_of_sound):
2286 * syntax.c (init_syntax_once, syms_of_syntax):
2287 * terminal.c (syms_of_terminal):
2288 * textprop.c (syms_of_textprop):
2289 * undo.c (syms_of_undo):
2290 * w32.c (globals_of_w32):
2291 * window.c (syms_of_window):
2292 * xdisp.c (syms_of_xdisp):
2293 * xfaces.c (syms_of_xfaces):
2294 * xfns.c (syms_of_xfns):
2295 * xmenu.c (syms_of_xmenu):
2296 * xsettings.c (syms_of_xsettings):
2297 * xterm.c (syms_of_xterm): Use DEFSYM.
2298
4228cf16
TZ
22992011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2300
cd3520a4 2301 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2302
7fcccf1e
PE
23032011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2304
7efb4e0e
PE
2305 Integer and buffer overflow fixes (Bug#8873).
2306
ff5844ad
PE
2307 * print.c (printchar, strout): Check for string overflow.
2308 (PRINTPREPARE, printchar, strout):
2309 Don't set size unless allocation succeeds.
2310
90532f02
PE
2311 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2312 for sizes. Check for string overflow more accurately.
2313 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2314
6d84508d
PE
2315 * macros.c: Integer and buffer overflow fixes.
2316 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2317 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2318 Use ptrdiff_t, not int, for sizes.
2319 Don't increment bufsize until after realloc succeeds.
2320 Check for size-calculation overflow.
2321 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2322
437b2cb4
PE
2323 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2324
8b9ac8b4
PE
2325 * lread.c: Integer overflow fixes.
2326 (read_integer): Radix is now EMACS_INT, not int,
2327 to improve quality of diagnostics for out-of-range radices.
2328 Calculate buffer size correctly for out-of-range radices.
2329 (read1): Check for integer overflow in radices, and in
2330 read-circle numbers.
82cb60d3
PE
2331 (read_escape): Avoid int overflow.
2332 (Fload, openp, read_buffer_size, read1)
2333 (substitute_object_recurse, read_vector, read_list, map_obarray):
2334 Use ptrdiff_t, not int, for sizes.
2335 (read1): Use EMACS_INT, not int, for sizes.
20270765 2336 Check for size overflow.
8b9ac8b4 2337
7fcccf1e
PE
2338 * image.c (cache_image): Check for size arithmetic overflow.
2339
bfbbd7e7
PE
2340 * lread.c: Integer overflow issues.
2341 (saved_doc_string_size, saved_doc_string_length)
2342 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2343 Now ptrdiff_t, not int.
2344 (read1): Don't assume doc string length fits in int. Check for
2345 out-of-range doc string lengths.
2346 (read_list): Don't assume file position fits in int.
39019e54 2347 (read_escape): Check for hex character overflow.
bfbbd7e7 2348
4e323265
LL
23492011-06-22 Leo Liu <sdl.web@gmail.com>
2350
2351 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2352 Move to minibuffer.el.
2353
85fece3e
PE
23542011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2355
20b84ce9 2356 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2357 The following patches are for when GLYPH_DEBUG && !XASSERT.
2358 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2359 * dispnew.c (flush_stdout):
2360 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2361 Mark as externally visible.
2362 * dispnew.c (check_window_matrix_pointers): Now static.
2363 * dispnew.c (window_to_frame_vpos):
2364 * xfns.c (unwind_create_frame):
2365 * xterm.c (x_check_font): Remove unused local.
2366 * scroll.c (CHECK_BOUNDS):
2367 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2368 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2369 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2370 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2371 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2372 Now static.
2373 (debug_method_add): Use va_list and vsprintf rather than relying
2374 on undefined behavior with wrong number of arguments.
2375 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2376 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2377 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2378 since we're not interested in debugging glyphs with old libraries.
2379 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2380 GCC 4.6.0's static checking.
2381
0766b489
PE
23822011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2383
31fd4b32
PE
2384 Integer overflow and signedness fixes (Bug#8873).
2385 A few related buffer overrun fixes, too.
2386
b79e8648
PE
2387 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2388
0766b489
PE
2389 * dispextern.h (struct face.stipple):
2390 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2391 (x_bitmap_mask, x_allocate_bitmap_record)
2392 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2393 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2394 (x_create_bitmap_from_xpm_data):
2395 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2396 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2397 (.bitmaps_last):
2398 * xfaces.c (load_pixmap):
2399 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2400 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2401 (.bitmaps_last, struct x_output.icon_bitmap):
2402 Use ptrdiff_t, not int, for bitmap indexes.
2403 (x_allocate_bitmap_record): Check for size overflow.
2404 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2405
b081724f
PE
2406 Use ptrdiff_t, not int, for overlay counts.
2407 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2408 * editfns.c (overlays_around, get_pos_property):
2409 * textprop.c (get_char_property_and_overlay):
2410 * xdisp.c (next_overlay_change, note_mouse_highlight):
2411 * xfaces.c (face_at_buffer_position):
21514da7
PE
2412 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2413 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2414 (Fnext_overlay_change, Fprevious_overlay_change)
2415 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2416 Use ptrdiff_t, not int, for sizes.
21514da7 2417 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2418
3de73e5e
PE
2419 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2420
2606c57b
PE
2421 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2422 (x_session_initialize): Do not assume string length fits in int.
2423
aaafe47a
PE
2424 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2425 This is unlikely, but can occur if DPI is outlandish.
2426
2674ddc8 2427 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2428 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2429
28154962
PE
2430 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2431 * xrdb.c (magic_file_p, search_magic_path):
2432 Omit last arg SUFFIX; it was always 0. All callers changed.
2433 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2434
7de51af5
PE
2435 * xfont.c (xfont_match): Avoid need for strlen.
2436
25ed6cc3
PE
2437 * xfns.c: Don't assume strlen fits in int.
2438 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2439
4eab31dd
PE
2440 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2441 not unsigned long, as we prefer signed integers. All callers changed.
2442 Detect integer overflow in repeat count.
2443 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2444 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2445
171e2a58
PE
2446 * termcap.c: Don't assume sizes fit in int and never overflow.
2447 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2448 (gobble_line): Check for size-calculation overflow.
2449
ad39faca 2450 * minibuf.c (Fread_buffer):
6e5bb2dc 2451 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2452 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2453 Don't assume string length fits in int.
2454
52c61c22 2455 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2456 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2457
b5b8c9e5
PE
2458 * font.c: Don't assume string length fits in int.
2459 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2460 Use ptrdiff_t, not int.
ccd6111c
PE
2461 (font_intern_prop): Don't assume string length fits in int.
2462 Don't assume integer property fits in fixnum.
2463 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2464
882f0d81 2465 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2466 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2467 Reformulate so as not to need the command string.
2468 Invoke gzip -cd rather than gunzip, as it's more portable.
2469 (lock_info_type, lock_file_1, lock_file):
2470 Don't assume pid_t and time_t fit in unsigned long.
2471 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2472 (current_lock_owner): Prefer signed type for sizes.
2473 Use memcpy, not strncpy, where memcpy is what is really wanted.
2474 Don't assume (via atoi) that time_t and pid_t fit in int.
2475 Check for time_t and/or pid_t out of range, e.g., via a network share.
2476 Don't alloca where an auto var works fine.
2477
93f4cf88
PE
2478 * fileio.c: Fix some integer overflow issues.
2479 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2480 Don't assume string length fits in int.
2481 (directory_file_name): Don't assume string length fits in long.
2482 (make_temp_name): Don't assume pid fits in int, or that its print
2483 length is less than 20.
2484
f3e92b69
PE
2485 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2486
1bfdaf10
PE
2487 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2488
35016e9a
PE
2489 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2490
3d1e65a1
PE
2491 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2492 We prefer signed integers, even for size calculations.
2493
0b963a93
PE
2494 * emacs.c: Don't assume string length fits in 'int'.
2495 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2496 (main): Don't invoke strlen when not needed.
2497
573f4b54
PE
2498 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2499 (XD_DEBUG_MESSAGE): Don't waste a byte.
2500
989f33ba
PE
2501 * callproc.c (getenv_internal_1, getenv_internal)
2502 (Fgetenv_internal):
965d34eb
PE
2503 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2504
e4d29b33
PE
2505 * lread.c (invalid_syntax): Omit length argument.
2506 All uses changed. This doesn't fix a bug, but it simplifies the
2507 code away from its former Hollerith-constant appearance, and it's
2508 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2509 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2510
eb49b136
PE
2511 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2512 This didn't break anything, but it didn't help either.
2513 It's confusing to put a bogus integer in a place where the actual
2514 value does not matter.
9f62aeb1 2515 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2516 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2517
15375a22
PE
2518 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2519 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2520 implementation.
b61cc01c
PE
2521 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2522 We prefer signed types, and the value cannot exceed the EMACS_INT
2523 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2524 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2525 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2526 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2527
53b2623d
PE
2528 * indent.c (sane_tab_width): New function.
2529 (current_column, scan_for_column, Findent_to, position_indentation)
2530 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2531 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2532
51cab52b 2533 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2534
f2ed8a70
PE
2535 * lisp.h (lint_assume): New macro.
2536 * composite.c (composition_gstring_put_cache):
2537 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2538
abe80cc6
PE
2539 * editfns.c, insdel.c:
2540 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2541
b02c740e
PE
2542 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2543
ebc96716
PE
2544 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2545
b4e50fa0 2546 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2547 Use much-faster test for byte-length change.
311d5d7c 2548 Don't assume string byte-length fits in 'int'.
a4cf38e4 2549 Check that character arg fits in 'int'.
85461888 2550 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2551
c0c1ee9f
PE
2552 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2553
a498d7f4
PE
2554 * fns.c (concat): Catch string overflow earlier.
2555 Do not rely on integer wraparound.
2556
51cab52b
PE
2557 * dispextern.h (struct it.overlay_strings_charpos)
2558 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2559 * xdisp.c (forward_to_next_line_start)
2560 (back_to_previous_visible_line_start)
2561 (reseat_at_next_visible_line_start, next_element_from_buffer):
2562 Don't arbitrarily truncate the value of 'selective' to int.
2563
76031fad
PE
2564 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2565
5eb55db9
PE
2566 * composite.c: Don't truncate sizes to 'int'.
2567 (composition_gstring_p, composition_reseat_it)
2568 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2569 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2570 not EMACS_UINT, for indexes.
5eb55db9 2571
0703a717
PE
2572 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2573
d6202519
PE
2574 * buffer.c: Include <verify.h>.
2575 (struct sortvec.priority, struct sortstr.priority):
8961a454 2576 Now EMACS_INT, not int.
c20998a7 2577 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2578 (struct sortstr.size, record_overlay_string)
2579 (struct sortstrlist.size, struct sortlist.used):
2580 Don't truncate size to int.
2581 (record_overlay_string): Check for size-calculation overflow.
d6202519 2582 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2583
d5a19415
JM
25842011-06-22 Jim Meyering <meyering@redhat.com>
2585
029529ac 2586 Don't leak an XBM-image-sized buffer
d5a19415
JM
2587 * image.c (xbm_load): Free the image buffer after using it.
2588
a9041e6c
PE
25892011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2590
2591 Port to Sun C.
2592 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2593 that Sun C diagnosed.
2594 * fns.c (secure_hash): Fix pointer signedness issue.
2595 * intervals.c (static_offset_intervals): New function.
2596 (offset_intervals): Use it.
2597
7f3f739f
LL
25982011-06-21 Leo Liu <sdl.web@gmail.com>
2599
2600 * deps.mk (fns.o):
2601 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2602 sha512.h.
2603
2604 * fns.c (secure_hash): Rename from crypto_hash_function and change
2605 the first arg to accept symbols.
5b66d427 2606 (Fsecure_hash): New primitive.
7f3f739f
LL
2607 (syms_of_fns): New symbols.
2608
76147d94
DD
26092011-06-20 Deniz Dogan <deniz@dogan.se>
2610
2611 * process.c (Fset_process_buffer): Clarify return value in
2612 docstring.
2613
7d7d0045
CY
26142011-06-18 Chong Yidong <cyd@stupidchicken.com>
2615
2616 * dispnew.c (add_window_display_history): Use BVAR.
2617
2618 * xdisp.c (debug_method_add): Use BVAR.
2619 (check_window_end, dump_glyph_matrix, dump_glyph)
2620 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2621
2622 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2623 Likewise.
2624
2625 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2626 check till after the cache is created in init_frame_faces.
2627
ff2bc410
SM
26282011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2629
2630 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2631
28177add
PE
26322011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2633
dd3482fe
PE
2634 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2635 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2636 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2637
393d71f3 2638 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2639 * fileio.c (Finsert_file_contents):
2640 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2641 Remove the old (too-loose) buffer overflow checks.
2642 They weren't needed, since make_gap checks for buffer overflow.
2643 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2644 The old code merely checked for Emacs fixnum overflow, and relied
2645 on undefined (wraparound) behavior. The new code avoids undefined
2646 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2647
2e6813b0 2648 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2649 Tune. Don't use wider integers than needed. Don't use alloca.
2650 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2651
599a9e4f
PE
2652 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2653
99561444
PE
2654 * insdel.c, lisp.h (buffer_overflow): New function.
2655 (insert_from_buffer_1, replace_range, replace_range_2):
2656 * insdel.c (make_gap_larger):
2657 * editfns.c (Finsert_char):
2658 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2659
28177add
PE
2660 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2661
e69dafad
PE
26622011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2663
a7af7fde 2664 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2665
b1c46f02
PE
2666 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2667 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2668
e69dafad
PE
2669 * fileio.c: Don't assume EMACS_INT fits in off_t.
2670 (emacs_lseek): New static function.
2671 (Finsert_file_contents, Fwrite_region): Use it.
2672 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2673
566684ea
PE
2674 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2675
e6966cd6
PE
2676 * fns.c: Don't overflow int when computing a list length.
2677 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2678 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2679 truncation on 64-bit hosts. Check for QUIT every
2680 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2681 faster and is responsive enough.
2682 (Flength): Report an error instead of overflowing an integer.
2683 (Fsafe_length): Return a float if the value is not representable
2684 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2685 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2686 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2687
dd0b0efb
PE
2688 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2689 (header_size, word_size): New constants.
2690 (allocate_vectorlike): Don't check size overflow here.
2691 (allocate_vector): Check it here instead, since this is the only
2692 caller of allocate_vectorlike that could cause overflow.
2693 Check that the new vector's length is representable as a fixnum.
2694
86fe5cfe
PE
2695 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2696 The previous code was bogus. For example, next_almost_prime (32)
2697 returned 39, which is undesirable as it is a multiple of 3; and
2698 next_almost_prime (24) returned 25, which is a multiple of 5 so
2699 why was the code bothering to check for multiples of 7?
2700
80e88859
PE
2701 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2702
4a2f0ad6
PE
2703 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2704
f66c7cf8
PE
2705 Variadic C functions now count arguments with ptrdiff_t.
2706 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2707 Back then I didn't know that the Emacs coding style prefers signed int.
2708 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2709 were being counted with int, which may truncate counts on 64-bit
2710 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2711 * lisp.h (struct Lisp_Subr.function.aMANY)
2712 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2713 Arg counts are now ptrdiff_t, not size_t.
2714 All variadic functions and their callers changed accordingly.
2715 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2716 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2717 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2718 * callint.c (Fcall_interactively): Check arg count for overflow,
2719 to avoid potential buffer overrun. Use signed char, not 'int',
2720 for 'varies' array, so that we needn't bother to check its size
2721 calculation for overflow.
2722 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2723 * eval.c (apply_lambda):
2724 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2725 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2726 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2727
a1759b76
PE
2728 * callint.c (Fcall_interactively): Don't use index var as event count.
2729
d96be9fc
PE
2730 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2731 * mem-limits.h (SIZE): Remove; no longer used.
2732
a690a978 2733 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2734
578c21e6
PE
2735 Remove unnecessary casts.
2736 * xterm.c (x_term_init):
2737 * xfns.c (x_set_border_pixel):
2738 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2739 These aren't needed now that we assume ANSI C.
2740
96f53c6c
PE
2741 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2742 It's more likely to cause problems (due to unsigned overflow)
2743 than to cure them.
2744
83c77d31
PE
2745 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2746
ee2079f1
PE
2747 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2748
6da65536
PE
2749 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2750
7147c4a4
PE
2751 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2752
193e32d9
PE
2753 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2754
e5533da6
PE
2755 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2756
9910e595
PE
2757 GLYPH_CODE_FACE returns EMACS_INT, not int.
2758 * dispextern.h (merge_faces):
2759 * xfaces.c (merge_faces):
01103c44
PE
2760 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2761 Don't assume EMACS_INT fits in int.
9910e595 2762
2638320e
PE
2763 * character.h (CHAR_VALID_P): Remove unused parameter.
2764 * fontset.c, lisp.h, xdisp.c: All uses changed.
2765
045eb8d9
PE
2766 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2767
c1f134b5
PE
2768 * fns.c (concat): Minor tuning based on overflow analysis.
2769 This doesn't fix any bugs. Use int to hold character, instead
2770 of constantly refetching from Emacs object. Use XFASTINT, not
2771 XINT, for value known to be a character. Don't bother comparing
2772 a single byte to 0400, as it's always less.
2773
395fcb93 2774 * floatfns.c (Fexpt):
327eeec8
PE
2775 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2776
abbd3d23
PE
2777 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2778 for characters.
2779
684a03ef
PE
2780 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2781
0fed43f3
PE
2782 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2783 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2784 incorrectly succeed when S was a string, because 4294967386 was
2785 truncated before it was used.
2786
8fd02eb7
PE
2787 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2788 Otherwise, an out-of-range integer could cause undefined behavior
2789 on a 64-bit host.
2790
f8c86b69
PE
2791 * composite.c: Use int, not EMACS_INT, for characters.
2792 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2793 EMACS_INT, for values that are known to be in character range.
2794 This doesn't fix any bugs but is the usual style inside Emacs and
2795 may generate better code on 32-bit machines.
2796
34206dd2
PE
2797 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2798 This is for reasons similar to the recent CHAR_STRING fix.
2799 * charset.c (Fencode_char): Check that character arg is actually
2800 a character. Pass an int to ENCODE_CHAR.
2801 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2802 wider than 'int', as a compile-time check to prevent future regressions
2803 in this area.
2804
c5958d4c 2805 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2806
2807 Make sure a 64-bit char is never passed to CHAR_STRING.
2808 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2809 by silently ignoring the top 32 bits, allowing some values
2810 that were far too large to be valid characters.
2811 * character.h: Include <verify.h>.
2812 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2813 arguments are no wider than unsigned, as a compile-time check
2814 to prevent future regressions in this area.
2815 * data.c (Faset):
01103c44 2816 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2817 (Fsubst_char_in_region):
2818 * fns.c (concat):
2819 * xdisp.c (decode_mode_spec_coding):
2820 Adjust to CHAR_STRING's new requirement.
2821 * editfns.c (Finsert_char, Fsubst_char_in_region):
2822 * fns.c (concat): Check that character args are actually
2823 characters. Without this test, these functions did the wrong
2824 thing with wildly out-of-range values on 64-bit hosts.
2825
d37ca623
PE
2826 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2827 These casts should not be needed on 32-bit hosts, either.
2828 * keyboard.c (read_char):
2829 * lread.c (Fload): Remove casts to unsigned.
2830
ea204efb
PE
2831 * lisp.h (UNSIGNED_CMP): New macro.
2832 This fixes comparison bugs on 64-bit hosts.
2833 (ASCII_CHAR_P): Use it.
2834 * casefiddle.c (casify_object):
01103c44 2835 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2836 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2837 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2838 * dispextern.h (FACE_FROM_ID):
2839 * keyboard.c (read_char): Use UNSIGNED_CMP.
2840
41cb286c
PE
2841 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2842 not to EMACS_INT, to avoid GCC warning.
2843
4a1b9832
PE
2844 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2845
55daad71
PE
2846 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2847 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2848 isn't needed on 32-bit machines.
8f95c75c 2849
01103c44
PE
2850 * buffer.c (Fgenerate_new_buffer_name):
2851 Use EMACS_INT for count, not int.
0ceccced 2852 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2853
2854 * data.c (Qcompiled_function): Now static.
2855
c6f072e7
PE
2856 * window.c (window_body_lines): Now static.
2857
20ce5912
PE
2858 * image.c (gif_load): Rename local to avoid shadowing.
2859
9c4c5f81
PE
2860 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2861 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2862 * alloc.c (make_save_value): Integer argument is now of type
2863 ptrdiff_t, not int.
2864 (mark_object): Use ptrdiff_t, not int.
2865 * lisp.h (pD): New macro.
2866 * print.c (print_object): Use it.
2867
c0c5c8ae
PE
2868 * alloc.c: Use EMACS_INT, not int, to count objects.
2869 (total_conses, total_markers, total_symbols, total_vector_size)
2870 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2871 (total_free_floats, total_floats, total_free_intervals)
2872 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2873 Now EMACS_INT, not int. All uses changed.
2874 (Fgarbage_collect): Compute overall total using a double, so that
2875 integer overflow is less likely to be a problem. Check for overflow
2876 when converting back to an integer.
5a25e253
PE
2877 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2878 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2879 These were 'int' variables that could overflow on 64-bit hosts;
2880 they were never used, so remove them instead of repairing them.
211a0b2a 2881 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2882 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2883 Previously, this ceilinged at INT_MAX, but that doesn't work on
2884 64-bit machines.
e46bb31a 2885 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2886
c78baabf 2887 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2888 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2889 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2890 when a (possibly-narrower) signed value would do just as well.
2891 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2892
c9d624c6
PE
2893 * alloc.c: Catch some string size overflows that we were missing.
2894 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2895 for convenience in STRING_BYTES_MAX.
2896 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2897 The definition here is exact; the one in lisp.h was approximate.
2898 (allocate_string_data): Check for string overflow. This catches
2899 some instances we weren't catching before. Also, it catches
2900 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2901 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2902 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2903
c9d624c6
PE
2904 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2905 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2906 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2907
353032ce
PE
2908 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2909
2bccce07
PE
2910 * alloc.c (Fmake_string): Check for out-of-range init.
2911
0ac30604
SM
29122011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2913
2914 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2915
c195f2de
JD
29162011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2917
2918 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2919 xg_get_default_scrollbar_width.
2920
2921 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2922 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2923 (style_changed_cb): Call update_theme_scrollbar_width and call
2924 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2925 all frames (Bug#8505).
2926 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2927 Call gtk_window_set_resizable if HAVE_GTK3.
2928 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2929 and height if HAVE_GTK3 (Bug#8505).
2930 (scroll_bar_width_for_theme): New variable.
2931 (update_theme_scrollbar_width): New function.
2932 (xg_get_default_scrollbar_width): Move code to
2933 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2934 (xg_initialize): Call update_theme_scrollbar_width.
2935
2936 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2937
2938 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2939
e10ac9f1
MR
29402011-06-12 Martin Rudalics <rudalics@gmx.at>
2941
2942 * frame.c (make_frame): Call other_buffer_safely instead of
2943 other_buffer.
2944
2945 * window.c (temp_output_buffer_show): Call display_buffer with
2946 second argument Vtemp_buffer_show_specifiers and reset latter
2947 immediately after the call.
2948 (Vtemp_buffer_show_specifiers): New variable.
2949 (auto_window_vscroll_p, next_screen_context_lines)
2950 (Vscroll_preserve_screen_position): Remove leading asterisks from
2951 doc-strings.
2952
2d3c217e 29532011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2954
7b7f97e8 2955 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2956 * buffer.c (Qclone_number): Remove for now, as it's unused.
2957 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2958 (record_buffer): Remove unused local.
2959 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2960 (set_frame_buffer_list): Remove; unused.
2961 * frame.h (other_visible_frames): Remove decl.
2962 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2963 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2964 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2965 if HAVE_GPM.
2966 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2967 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2968 Define only if HAVE_GPM.
2969 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2970 (update_hints_inhibit): Remove; never set. All uses removed.
2971 * widgetprv.h (emacsFrameClassRec): Remove decl.
2972 * window.c (delete_deletable_window): Now returns void, since it
2973 wasn't returning anything.
2974 (compare_window_configurations): Remove unused locals.
2975 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2976 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2977 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2978 the same widths as pointers. This follows up on the 2011-05-06 patch.
2979 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2980 * xterm.h: Likewise.
2981 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2982
1384b89e
JB
29832011-06-12 Juanma Barranquero <lekktu@gmail.com>
2984
2985 * makefile.w32-in: Update dependencies.
2986 (LISP_H): Add lib/intprops.h.
2987
1100a63c
CY
29882011-06-11 Chong Yidong <cyd@stupidchicken.com>
2989
2990 * image.c (gif_load): Add animation frame delay to the metadata.
2991 (syms_of_image): Use DEFSYM. New symbol `delay'.
2992
6198ccd0
MR
29932011-06-11 Martin Rudalics <rudalics@gmx.at>
2994
2995 * window.c (delete_deletable_window): Re-add.
2996 (Fset_window_configuration): Rewrite to handle dead buffers and
2997 consequently deletable windows.
2998 (window_tree, Fwindow_tree): Remove. Supply functionality in
2999 window.el.
3000 (compare_window_configurations): Simplify code.
3001
b6e3633c
AS
30022011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3003
1ab0dee5
AS
3004 * image.c (imagemagick_load_image): Fix type mismatch.
3005 (Fimagemagick_types): Likewise.
3006
b6e3633c
AS
3007 * window.h (replace_buffer_in_windows): Declare.
3008
9397e56f
MR
30092011-06-11 Martin Rudalics <rudalics@gmx.at>
3010
3011 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3012 Qclone_number. Remove external declaration of Qdelete_window.
3013 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3014 code.
640c8776
SM
3015 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3016 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3017 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3018 buffer list implementation.
3019 (other_buffer_safely): New function.
3020 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3021 calls to replace_buffer_in_windows and
3022 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3023 if allowed.
3024 (record_buffer): Inhibit quitting and rewrite using quittable
3025 functions. Run Qbuffer_list_update_hook if allowed.
3026 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3027 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3028 Move switch-to-buffer to window.el.
9397e56f
MR
3029 (bury-buffer): Move to window.el.
3030 (Vbuffer_list_update_hook): New variable.
3031
3032 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3033 section.
3034
3035 * window.h (resize_frame_windows): Move up in code.
3036 (Fwindow_frame): Remove EXFUN.
3037 (replace_buffer_in_all_windows): Remove prototype.
3038 (replace_buffer_in_windows_safely): Add prototype.
3039
3040 * window.c: Declare Qdelete_window static again. Move down
3041 declaration of select_count.
3042 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3043 (Fother_window): Move to window.el.
3044 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3045 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3046 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3047 window.el.
3048 (replace_buffer_in_windows): Implement by calling
3049 Qreplace_buffer_in_windows.
3050 (replace_buffer_in_all_windows): Remove with some functionality
3051 moved into replace_buffer_in_windows_safely.
3052 (replace_buffer_in_windows_safely): New function.
3053 (select_window_norecord, select_frame_norecord): Move in front
3054 of run_window_configuration_change_hook. Remove now obsolete
3055 declarations.
640c8776
SM
3056 (Fset_window_buffer): Rewrite doc-string.
3057 Call Qrecord_window_buffer.
9397e56f
MR
3058 (keys_of_window): Move binding for other-window to window.el.
3059
b50691aa
CY
30602011-06-11 Chong Yidong <cyd@stupidchicken.com>
3061
3062 * dispextern.h (struct image): Replace data member, whose int_val
3063 and ptr_val fields were not used by anything, with a single
3064 lisp_val object.
3065
3066 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3067 (gif_clear_image, gif_load, imagemagick_load_image)
3068 (gs_clear_image, gs_load): Callers changed.
3069
3f754b86
PE
30702011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3071
cca69397
PE
3072 * buffer.h: Include <time.h>, for time_t.
3073 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3074
109e28d0
PE
3075 Fix minor problems found by static checking.
3076
60737f02
PE
3077 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3078
4b66faf3
PE
3079 Make identifiers static if they are not used in other modules.
3080 * data.c (Qcompiled_function, Qframe, Qvector):
3081 * image.c (QimageMagick, Qsvg):
3082 * minibuf.c (Qmetadata):
3083 * window.c (resize_window_check, resize_root_window): Now static.
3084 * window.h (resize_window_check, resize_root_window): Remove decls.
3085
109e28d0
PE
3086 * window.c (window_deletion_count, delete_deletable_window):
3087 Remove; unused.
46a4ce9e
PE
3088 (window_body_lines): Now static.
3089 (Fdelete_other_windows_internal): Mark vars as initialized.
3090 Make sure 'resize_failed' is initialized.
3091 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3092 (resize_window_apply): Remove unused local.
3093 * window.h (delete_deletable_window): Remove decl.
3094
109e28d0 3095 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3096 (imagemagick_load_image): Fix pointer signedness problem by changing
3097 last arg from unsigned char * to char *. All uses changed.
3098 Also, fix a local for similar reasons.
3099 Remove unused locals. Remove locals to avoid shadowing.
3100 (fn_rsvg_handle_free): Remove; unused.
3101 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3102 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3103
3f754b86
PE
3104 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3105
2547adb1
CY
31062011-06-10 Chong Yidong <cyd@stupidchicken.com>
3107
3108 * image.c (gif_load): Fix omitted cast error introduced by
3109 2011-06-06 change.
3110
2c8e37d4
MR
31112011-06-10 Martin Rudalics <rudalics@gmx.at>
3112
3113 * window.h (resize_proportionally, orig_total_lines)
3114 (orig_top_line): Remove from window structure.
3115 (set_window_height, set_window_width, change_window_heights)
3116 (Fdelete_window): Remove prototypes.
3117 (resize_frame_windows): Remove duplicate declaration.
3118
440a42e3
EZ
31192011-06-10 Eli Zaretskii <eliz@gnu.org>
3120
3121 * window.h (resize_frame_windows, resize_window_check)
3122 (delete_deletable_window, resize_root_window)
3123 (resize_frame_windows): Declare prototypes.
3124
3125 * window.c (resize_window_apply): Make definition be "static" to
3126 match the prototype.
3127
562dd5e9
MR
31282011-06-10 Martin Rudalics <rudalics@gmx.at>
3129
3130 * window.c: Remove declarations of Qwindow_size_fixed,
3131 window_min_size_1, window_min_size_2, window_min_size,
3132 size_window, window_fixed_size_p, enlarge_window, delete_window.
3133 Remove static from declaration of Qdelete_window, it's
3134 temporarily needed by Fbury_buffer.
3135 (replace_window): Don't assign orig_top_line and
3136 orig_total_lines.
3137 (Fdelete_window, delete_window): Remove. Window deletion is
3138 handled by window.el.
640c8776
SM
3139 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3140 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3141 (Fdelete_other_windows): Remove. Deleting other windows is
3142 handled by window.el.
3143 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3144 handled in window.el.
3145 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3146 Window minimum sizes are handled in window.el.
3147 (shrink_windows, size_window, set_window_height)
3148 (set_window_width, change_window_heights, window_height)
3149 (window_width, CURBEG, CURSIZE, enlarge_window)
3150 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3151 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3152 handled in window.el.
3153 (make_dummy_parent): Rename to make_parent_window and give it a
3154 second argument horflag.
3155 (make_window): Don't set resize_proportionally any more.
3156 (Fsplit_window): Remove. Windows are split in window.el.
3157 (save_restore_action, save_restore_orig_size)
3158 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3159 Resize mini windows in window.el.
3160 (grow_mini_window, shrink_mini_window): Implement by calling
3161 Qresize_root_window_vertically, resize_window_check and
3162 resize_window_apply.
640c8776
SM
3163 (saved_window, Fset_window_configuration, save_window_save):
3164 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3165 resize_proportionally.
3166 (window_min_height, window_min_width): Move to window.el.
3167 (keys_of_window): Move bindings for delete-other-windows,
3168 split-window, delete-window and enlarge-window to window.el.
3169
3170 * buffer.c: Temporarily extern Qdelete_window.
3171 (Fbury_buffer): Temporarily call Qdelete_window instead of
3172 Fdelete_window (Fbury_buffer will move to window.el soon).
3173
3174 * frame.c (set_menu_bar_lines_1): Remove code handling
3175 orig_top_line and orig_total_lines.
3176
3177 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3178 set_window_height but set heights directly.
3179 (change_frame_size_1): Use resize_frame_windows.
3180
3181 * xdisp.c (init_xdisp): Don't use set_window_height but set
3182 heights directly.
3183
640c8776
SM
3184 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3185 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3186 run_window_configuration_change_hook.
3187
3188 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3189 instead of change_window_heights and run
3190 run_window_configuration_change_hook.
3191
1a13852e
MR
31922011-06-09 Martin Rudalics <rudalics@gmx.at>
3193
3194 * window.c (replace_window): Rename second argument REPLACEMENT to
3195 NEW. New third argument SETFLAG. Rewrite.
3196 (delete_window, make_dummy_parent): Call replace_window with
3197 third argument 1.
3198 (window_list_1): Move down in code.
3199 (run_window_configuration_change_hook): Move set_buffer part
3200 before select_frame_norecord part in order to unwind correctly.
3201 Rename count1 to count.
3202 (recombine_windows, delete_deletable_window, resize_root_window)
3203 (Fdelete_other_windows_internal)
3204 (Frun_window_configuration_change_hook, make_parent_window)
3205 (resize_window_check, resize_window_apply, Fresize_window_apply)
3206 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3207 (Fdelete_window_internal, Fresize_mini_window_internal):
3208 New functions.
1a13852e
MR
3209 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3210
f3d1777e
MR
32112011-06-08 Martin Rudalics <rudalics@gmx.at>
3212
496e208e
MR
3213 * window.h (window): Add some new members to window structure -
3214 normal_lines, normal_cols, new_total, new_normal, clone_number,
3215 splits, nest, prev_buffers, next_buffers.
3216 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3217 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3218
f3d1777e
MR
3219 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3220 Remove.
496e208e
MR
3221 (make_dummy_parent): Set new members of windows structure.
3222 (make_window): Move down in code. Handle new members of window
3223 structure.
3224 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3225 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3226 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3227 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3228 (Fset_window_next_buffers, Fset_window_clone_number):
3229 New functions.
496e208e
MR
3230 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3231 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3232 Doc-string fixes.
3233 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3234 Argument WINDOW can be now internal window too.
3235 (Fwindow_use_time): Move up in code.
3236 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3237 Rewrite doc-string.
3238 (Fset_window_configuration, saved_window)
3239 (Fcurrent_window_configuration, save_window_save): Handle new
3240 members of window structure.
b9e809c2
MR
3241 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3242 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3243 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3244 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3245 Qget_mru_window, Qresize_root_window,
3246 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3247 Qauto_buffer_name; staticpro them.
f3d1777e 3248
abde8f8c
MR
32492011-06-07 Martin Rudalics <rudalics@gmx.at>
3250
3251 * window.c (Fwindow_total_size, Fwindow_left_column)
3252 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3253 (Fwindow_list_1): New functions.
3254 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3255 (Fwindow_width, Fscroll_left, Fscroll_right):
3256 Use window_body_cols instead of window_box_text_cols.
3257 (delete_window, Fset_window_configuration):
3258 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3259 (delete_all_subwindows): Take a window as argument and not a
3260 structure. Rewrite.
190b47e6
MR
3261 (window_loop): Remove handling of GET_LRU_WINDOW and
3262 GET_LARGEST_WINDOW.
3263 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3264
3265 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3266 window_box_text_cols. delete_all_subwindows now takes a
3267 Lisp_Object as argument.
abde8f8c 3268
640c8776
SM
3269 * indent.c (compute_motion, Fcompute_motion):
3270 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3271
fa8a67e6
MR
3272 * frame.c (delete_frame): Call delete_all_subwindows with root
3273 window as argument.
3274
a54e3482
DC
32752011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3276
3277 * fns.c (Fputhash): Document return value.
3278
60002bf5
CY
32792011-06-06 Chong Yidong <cyd@stupidchicken.com>
3280
3281 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3282
0c671da6 32832011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3284
b862a52a 3285 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3286
be44ca6c
PE
3287 Check for overflow when converting integer to cons and back.
3288 * charset.c (Fdefine_charset_internal, Fdecode_char):
3289 Use cons_to_unsigned to catch overflow.
3290 (Fencode_char): Use INTEGER_TO_CONS.
3291 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3292 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3293 * data.c (long_to_cons, cons_to_long): Remove.
3294 (cons_to_unsigned, cons_to_signed): New functions.
3295 These signal an error for invalid or out-of-range values.
3296 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3297 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3298 * font.c (Ffont_variation_glyphs):
3299 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3300 * lisp.h: Include <intprops.h>.
3301 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3302 (cons_to_signed, cons_to_unsigned): New decls.
3303 (long_to_cons, cons_to_long): Remove decls.
3304 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3305 (Fprimitive_undo): Use CONS_TO_INTEGER.
3306 * xfns.c (Fx_window_property): Likewise.
3307 * xselect.c: Include <limits.h>.
3308 (x_own_selection, selection_data_to_lisp_data):
3309 Use INTEGER_TO_CONS.
3310 (x_handle_selection_request, x_handle_selection_clear)
3311 (x_get_foreign_selection, Fx_disown_selection_internal)
3312 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3313 (lisp_data_to_selection_data): Use cons_to_unsigned.
3314 (x_fill_property_data): Use cons_to_signed.
3315 Report values out of range.
3316
d1f3d2af
PE
3317 Check for buffer and string overflow more precisely.
3318 * buffer.h (BUF_BYTES_MAX): New macro.
3319 * lisp.h (STRING_BYTES_MAX): New macro.
3320 * alloc.c (Fmake_string):
3321 * character.c (string_escape_byte8):
3322 * coding.c (coding_alloc_by_realloc):
3323 * doprnt.c (doprnt):
3324 * editfns.c (Fformat):
3325 * eval.c (verror):
3326 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3327 since they may not be the same number.
3328 * editfns.c (Finsert_char):
3329 * fileio.c (Finsert_file_contents):
3330 Likewise for BUF_BYTES_MAX.
3331
dd52fcea
PE
3332 * image.c: Use ptrdiff_t, not int, for sizes.
3333 (slurp_file): Switch from int to ptrdiff_t.
3334 All uses changed.
3335 (slurp_file): Check that file size fits in both size_t (for
3336 malloc) and ptrdiff_t (for sanity and safety).
3337
7f9bbdbb
PE
3338 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3339 if b->modtime has its maximal value.
3340
dfe18f82
PE
3341 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3342
84acfcf0
PE
3343 Don't assume time_t can fit into int.
3344 * buffer.h (struct buffer.modtime): Now time_t, not int.
3345 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3346 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3347
ccd9a01a
PE
3348 Minor fixes for signed vs unsigned integers.
3349 * character.h (MAYBE_UNIFY_CHAR):
3350 * charset.c (maybe_unify_char):
3351 * keyboard.c (read_char, reorder_modifiers):
3352 XINT -> XFASTINT, since the integer must be nonnegative.
3353 * ftfont.c (ftfont_spec_pattern):
3354 * keymap.c (access_keymap, silly_event_symbol_error):
3355 XUINT -> XFASTINT, since the integer must be nonnegative.
3356 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3357 since it makes no difference and we prefer signed.
3358 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3359 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3360 nonnegative.
3361
d6d100dd
SM
33622011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3363
3364 * window.h (Fwindow_frame): Declare.
3365
2b6148e4
PE
33662011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3367
3368 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3369 (SPARE_MEMORY): Always define.
3370 (LARGE_REQUEST): Remove.
3371 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3372
f230ecc9
MR
33732011-06-06 Martin Rudalics <rudalics@gmx.at>
3374
727e958e
MR
3375 * lisp.h: Move EXFUNS for Fframe_root_window,
3376 Fframe_first_window and Fset_frame_selected_window to window.h.
3377
3378 * window.h: Move EXFUNS for Fframe_root_window,
3379 Fframe_first_window and Fset_frame_selected_window here from
3380 lisp.h.
3381
3382 * frame.c (Fwindow_frame, Fframe_first_window)
3383 (Fframe_root_window, Fframe_selected_window)
3384 (Fset_frame_selected_window): Move to window.c.
3385 (Factive_minibuffer_window): Move to minibuf.c.
3386 (Fother_visible_frames_p): New function.
3387
3388 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3389
f230ecc9
MR
3390 * window.c (decode_window, decode_any_window): Move up in code.
3391 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3392 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3393 (Fwindow_buffer): Move up and rewrite doc-string.
3394 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3395 (Fwindow_prev): New functions.
727e958e
MR
3396 (Fwindow_frame): Move here from frame.c. Accept any window as
3397 argument.
3398 (Fframe_root_window, Fframe_first_window)
3399 (Fframe_selected_window): Move here from frame.c. Accept frame
3400 or arbitrary window as argument. Update doc-strings.
3401 (Fminibuffer_window): Move up in code.
3402 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3403 (Fset_frame_selected_window): Move here from frame.c.
3404 Marginal rewrite.
727e958e
MR
3405 (Fselected_window, select_window, Fselect_window): Move up in
3406 code. Minor doc-string fixes.
f230ecc9 3407
4d09bcf6
PE
34082011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3409
3410 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3411 Do not assume that spare memory exists; that assumption is valid
3412 only if SYSTEM_MALLOC.
3413 (LARGE_REQUEST): New macro, so that the issue of large requests
3414 is separated from the issue of spare memory.
3415
810928a2
AS
34162011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3417
172418ad
AS
3418 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3419 format. (Bug#8806)
3420
43f862f7
AS
3421 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3422
810928a2
AS
3423 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3424 before statements.
3425
a059fe24
JD
34262011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3427
3428 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3429
3430 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3431
3432 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3433 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3434
989bf368
JB
34352011-06-05 Juanma Barranquero <lekktu@gmail.com>
3436
3437 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3438
4b80f674
CY
34392011-06-04 Chong Yidong <cyd@stupidchicken.com>
3440
3441 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3442 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3443 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3444 New error handlers.
4b80f674
CY
3445 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3446 Obey Vx_select_enable_clipboard_manager. Catch errors in
3447 x_clipboard_manager_save (Bug#8779).
3448 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3449 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3450
99a33b77 34512011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3452
3453 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3454
99a33b77 34552011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3456
3457 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3458 in the current matrix if keep_current_p is non-zero.
3459
8264569d
EZ
34602011-06-04 Eli Zaretskii <eliz@gnu.org>
3461
3462 * bidi.c (bidi_level_of_next_char): Fix last change.
3463
57f97249
EZ
34642011-06-03 Eli Zaretskii <eliz@gnu.org>
3465
fec2107c 3466 Support bidi reordering of text covered by display properties.
57f97249 3467
fec2107c
EZ
3468 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3469 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3470 (bidi_cache_search, bidi_cache_iterator_state)
3471 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3472 (bidi_level_of_next_char, bidi_move_to_visually_next):
3473 Support character positions inside a run of characters covered by a
fec2107c
EZ
3474 display string.
3475 (bidi_paragraph_init, bidi_resolve_explicit_1)
3476 (bidi_level_of_next_char): Call bidi_fetch_char and
3477 bidi_fetch_char_advance instead of FETCH_CHAR and
3478 FETCH_CHAR_ADVANCE.
3479 (bidi_init_it): Initialize new members.
3480 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3481 definitions.
3482 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3483 instead of using explicit *_CHAR codes.
d6d100dd
SM
3484 (bidi_resolve_explicit, bidi_resolve_weak):
3485 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3486 bidirectional text is supported only in multibyte buffers.
3487 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3488 it to initialize the frame_window_p member of struct bidi_it.
3489 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3490 (bidi_resolve_explicit, bidi_resolve_weak)
3491 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3492 bidi_it->nchars is non-positive.
3493 (bidi_level_of_next_char): Don't try to lookup the cache for the
3494 next/previous character if nothing is cached there yet, or if we
3495 were just reseat()'ed to a new position.
c40e2fb2 3496
0e14fe90
EZ
3497 * xdisp.c (set_cursor_from_row): Set start and stop points
3498 according to the row's direction when priming the loop that looks
3499 for the glyph on which to display cursor.
3500 (single_display_spec_intangible_p): Function deleted.
3501 (display_prop_intangible_p): Reimplement to call
3502 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3503 Accept 3 additional arguments needed by handle_display_spec.
3504 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3505 values: lists, `(when COND...)' forms, etc.
3506 (single_display_spec_string_p): Support property values that are
3507 lists with the argument STRING its top-level element.
3508 (display_prop_string_p): Fix the condition for processing a
3509 property that is a list to be consistent with handle_display_spec.
fec2107c 3510 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3511 last portion of handle_display_prop.
3512 (compute_display_string_pos): Accept additional argument
3513 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3514 value of a `display' property is a "replacing spec".
3515 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3516 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3517 the display property, but just return a value indicating whether
3518 the display property will replace the characters it covers.
3519 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3520 frame_window_p members of struct bidi_it.
d6d100dd
SM
3521 (compute_display_string_pos, compute_display_string_end):
3522 New functions.
fec2107c
EZ
3523 (push_it): Accept second argument POSITION, where pop_it should
3524 jump to continue iteration.
3525 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3526
fec2107c
EZ
3527 * keyboard.c (adjust_point_for_property): Adjust the call to
3528 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3529
3530 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3531 (bidi_init_it): Update prototypes.
3532 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3533 (compute_display_string_pos, compute_display_string_end):
3534 Declare prototypes.
fec2107c
EZ
3535 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3536 EMACS_INT.
fc6f18ce 3537
40087514 35382011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3539
57f53182
PE
3540 Malloc failure behavior now depends on size of allocation.
3541 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3542 * lisp.h: Change signatures accordingly.
3543 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3544 All callers changed. (Bug#8762)
3545
3546 * gnutls.c: Use Emacs's memory allocators.
3547 Without this change, the gnutls library would invoke malloc etc.
3548 directly, which causes problems on non-SYNC_INPUT hosts, and which
3549 runs afoul of improving memory_full behavior. (Bug#8761)
3550 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3551 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3552 xfree instead of the default malloc, realloc, free.
3553 (Fgnutls_boot): No need to check for memory allocation failure,
3554 since xmalloc does that for us.
3555
ac32cd99 3556 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3557 * category.c (hash_get_category_set):
3558 * ccl.c (ccl_driver):
3559 * charset.c (Fdefine_charset_internal):
3560 * charset.h (struct charset.hash_index):
3561 * composite.c (get_composition_id, gstring_lookup_cache)
3562 (composition_gstring_put_cache):
3563 * composite.h (struct composition.hash_index):
3564 * dispextern.h (struct image.hash):
3565 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3566 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3567 (hashfn_equal, hashfn_user_defined, make_hash_table)
3568 (maybe_resize_hash_table, hash_lookup, hash_put)
3569 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3570 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3571 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3572 * image.c (make_image, search_image_cache, lookup_image)
3573 (xpm_put_color_table_h):
3574 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3575 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3576 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3577 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3578 * alloc.c (allocate_vectorlike):
3579 Check for overflow in vector size calculations.
3580 * ccl.c (ccl_driver):
3581 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3582 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3583 need to be updated by these changes.
40087514
PE
3584 * fns.c (make_hash_table, maybe_resize_hash_table):
3585 Check for integer overflow with large hash tables.
0de4bb68
PE
3586 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3587 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3588 (SXHASH_REDUCE): New macro.
3589 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3590 Use it instead of discarding useful hash info with large hash values.
3591 (sxhash_float): New function.
3592 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3593 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3594 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3595 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3596 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3597 Adjust signatures to match updated version of code.
3598 (consing_since_gc): Now EMACS_INT, since a single hash table can
3599 use more than INT_MAX bytes.
3600
698d32e2
DN
36012011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3602
3603 Make it possible to build with GCC-4.6+ -O2 -flto.
3604
3605 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3606
fd6fa53f
SM
36072011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3608
3609 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3610 Call minibuffer-inactive-mode.
3611
864db017
JB
36122011-05-31 Juanma Barranquero <lekktu@gmail.com>
3613
3614 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3615 Update dependencies.
3616
2ad0baf4
DN
36172011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3618
3619 * data.c (init_data): Remove code for UTS, this system is not
3620 supported anymore.
3621
4fcc2638
DN
36222011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3623
3624 Don't force ./temacs to start in terminal mode.
3625
3626 * frame.c (make_initial_frame): Initialize faces in all cases, not
3627 only when CANNOT_DUMP is defined.
3628 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3629
c56e0fd5
DN
36302011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3631
3632 * dispnew.c (add_window_display_history): Use const for the string
3633 pointer. Remove declaration, not needed.
3634
333d54da 36352011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3636
55d4c1b2 3637 Use 'inline', not 'INLINE'.
333d54da 3638 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3639 * alloc.c, fontset.c (INLINE): Remove.
3640 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3641 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3642 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3643 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3644 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3645
738db178
DN
36462011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3647
3648 Make it possible to run ./temacs.
3649
3650 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3651 syms_of_callproc does the same thing. Remove test for
3652 "initialized", do it in the caller.
3653 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3654
620c53a6
SM
36552011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3656
3657 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3658 (read_minibuf): Use get_minibuffer.
3659 (syms_of_minibuf): Use DEFSYM.
3660 (Qmetadata): New var.
3661 * data.c (Qbuffer): Don't make it static.
3662 (syms_of_data): Use DEFSYM.
3663
e003a292
PE
36642011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3665
3666 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3667 (CCL_CODE_MIN): New macro.
3668
ed008a6d
PE
36692011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3670
3687c2ef
PE
3671 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3672
ed008a6d
PE
3673 * eval.c (Qdebug): Now static.
3674 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3675 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3676 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3677
d66c4c7c
CY
36782011-05-29 Chong Yidong <cyd@stupidchicken.com>
3679
3680 * image.c: Various fixes to ImageMagick code comments.
3681 (Fimagemagick_types): Doc fix.
3682
5fbc2025
PE
36832011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3684
0196f88a
PE
3685 Minor fixes prompted by GCC 4.6.0 warnings.
3686
3687 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3688
5fbc2025
PE
3689 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3690 (x_clipboard_manager_save_all): Move extern decl to ...
3691 * xterm.h: ... here, so that it can be checked for consistency.
3692
1dd3c2d9
CY
36932011-05-29 Chong Yidong <cyd@stupidchicken.com>
3694
3695 * xselect.c (x_clipboard_manager_save_frame)
3696 (x_clipboard_manager_save_all): New functions.
3697 (Fx_clipboard_manager_save): Lisp function deleted.
3698
3699 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3700 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3701
3702 * xterm.h: Update prototype.
3703
5ba6571d
WX
37042011-05-28 William Xu <william.xwl@gmail.com>
3705
3706 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3707 exiting (Bug#8239).
3708
3eaff834
JM
37092011-05-28 Jim Meyering <meyering@redhat.com>
3710
e1900994 3711 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3712 * fns.c (to_uchar): Define.
3713 (crypto_hash_function): Use it to convert some newly-signed
3714 variables to unsigned, to avoid sign-extension bugs. For example,
3715 without this change, (md5 "truc") would evaluate to
3716 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3717 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3718 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3719
0f6990a7
PE
37202011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3721
3722 Integer overflow fixes.
c8a9ca5a 3723
08686060
PE
3724 * dbusbind.c: Serial number integer overflow fixes.
3725 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3726 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3727 to hold a serial number that is too large for a fixnum.
3728 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3729 Check for serial numbers out of range. Decode any serial number
59568bf0 3730 that was so large that it became a float. (Bug#8722)
08686060 3731
2d1fc3c7
PE
3732 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3733 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3734 Use XFASTINT rather than XUINT when numbers are nonnegative.
3735 (xd_append_arg, Fdbus_method_return_internal):
3736 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3737 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3738 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3739 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3740 (Bug#8722)
2d1fc3c7 3741
c8a9ca5a
PE
3742 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3743
519e1d69
PE
3744 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3745
30569699
PE
3746 ccl: add integer overflow checks
3747 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3748 (IN_INT_RANGE): New macros.
3749 (ccl_driver): Use them to check for integer overflow when
3750 decoding a CCL program. Many of the new checks are whether XINT (x)
3751 fits in int; it doesn't always, on 64-bit hosts. The new version
3752 doesn't catch all possible integer overflows, but it's an
847044ea 3753 improvement. (Bug#8719)
30569699 3754
c11285dc
PE
3755 * alloc.c (make_event_array): Use XINT, not XUINT.
3756 There's no need for unsigned here.
3757
fdccd48e
PE
3758 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3759 This follows up to the 2011-05-06 change that substituted uintptr_t
3760 for EMACS_INT. This case wasn't caught back then.
3761
37910ab2
PE
3762 Rework Fformat to avoid integer overflow issues.
3763 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3764 now (part of C89). Include <verify.h>.
3765 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3766 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3767 (Fformat): Avoid the prepass trying to compute sizes; it was only
3768 approximate and thus did not catch overflow reliably. Instead, walk
3769 through the format just once, formatting and computing sizes as we go,
3770 checking for integer overflow at every step, and allocating a larger
3771 buffer as needed. Keep track separately whether the format is
3772 multibyte. Keep only the most-recently calculated precision, rather
3773 than them all. Record whether each argument has been converted to
3774 string. Use EMACS_INT, not int, for byte and char and arg counts.
3775 Support field widths and precisions larger than INT_MAX. Avoid
3776 sprintf's undefined behavior with conversion specifications such as %#d
3777 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3778 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3779 formatting out-of-range floating point numbers with int
9173deec 3780 formats. (Bug#8668)
37910ab2 3781
2e6578fb
PE
3782 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3783
0ae6bdee
PE
3784 * data.c: Avoid integer truncation in expressions involving floats.
3785 * data.c: Include <intprops.h>.
3786 (arith_driver): When there's an integer overflow in an expression
3787 involving floating point, convert the integers to floating point
3788 so that the resulting value does not suffer from catastrophic
3789 integer truncation. For example, on a 64-bit host (* 4
3790 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3791 Do not rely on undefined behavior after integer overflow.
3792
de883a70
PE
3793 merge count_size_as_multibyte, parse_str_to_multibyte
3794 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3795 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3796 Check for integer overflow.
3797 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3798 since it's now a duplicate of the other. This is more of
3799 a character than a buffer op, so better that it's in character.c.
3800 * fns.c, print.c: Adjust to above changes.
3801
2ff916cb
PE
38022011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3803
3804 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3805
f1b54466
PE
38062011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3807
fb1ac845
PE
3808 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3809 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3810 (x_clipboard_manager_save): Now static.
3811 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3812
f1b54466
PE
3813 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3814 (crypto_hash_function): Now static.
3815 Fix pointer signedness problems. Avoid unnecessary initializations.
3816
a9f737ee
CY
38172011-05-27 Chong Yidong <cyd@stupidchicken.com>
3818
3819 * termhooks.h (Vselection_alist): Make it terminal-local.
3820
3821 * terminal.c (create_terminal): Initialize it.
3822
3823 * xselect.c: Support for clipboard managers.
3824 (Vselection_alist): Move to termhooks.h as terminal-local var.
3825 (LOCAL_SELECTION): New macro.
3826 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3827 (symbol_to_x_atom): Remove gratuitous arg.
3828 (x_handle_selection_request, lisp_data_to_selection_data)
3829 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3830 (x_own_selection, x_get_local_selection, x_convert_selection):
3831 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3832 (some_frame_on_display): Delete unused function.
3833 (Fx_own_selection_internal, Fx_get_selection_internal)
3834 (Fx_disown_selection_internal, Fx_selection_owner_p)
3835 (Fx_selection_exists_p): New optional frame arg.
3836 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3837 (x_handle_selection_clear): Don't treat other terminals with the
3838 same keyboard specially. Use the terminal-local Vselection_alist.
3839 (x_clear_frame_selections): Use Frun_hook_with_args.
3840
3841 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3842
3843 * xterm.h: Add support for those atoms.
3844
e067f0c1
CY
38452011-05-26 Chong Yidong <cyd@stupidchicken.com>
3846
3847 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3848 (converted_selections, conversion_fail_tag): New global variables.
3849 (x_selection_request_lisp_error): Free the above.
3850 (x_get_local_selection): Remove unnecessary code.
3851 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3852 of converted selections stored in converted_selections.
3853 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3854 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3855 (x_convert_selection): New function.
3856 (x_handle_selection_event): Simplify.
3857 (x_get_foreign_selection): Don't ignore incoming requests while
3858 waiting for an answer; this will fail when we implement
3859 SAVE_TARGETS, and seems unnecessary anyway.
3860 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3861 (Vx_sent_selection_functions): Doc fix.
3862
0f4aebc0
LL
38632011-05-26 Leo Liu <sdl.web@gmail.com>
3864
3865 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3866
e61124cd
YM
38672011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3868
3869 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3870
3871 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3872 for fringe update if it has periodic bitmap.
ac389d0c 3873 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3874 and fringe_bitmap_periodic_p.
3875
3876 * fringe.c (get_fringe_bitmap_data): New function.
3877 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3878 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3879 row. Mark glyph row for fringe update if periodicity changed.
3880
3881 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3882 for fringe update unless it has periodic bitmap.
3883
f16d9837
KH
38842011-05-25 Kenichi Handa <handa@m17n.org>
3885
3886 * xdisp.c (get_next_display_element): Set correct it->face_id for
3887 a static composition.
3888
e1b90ef6
LL
38892011-05-24 Leo Liu <sdl.web@gmail.com>
3890
3891 * deps.mk (fns.o):
3892 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3893
3894 * fns.c (crypto_hash_function, Fsha1): New function.
3895 (Fmd5): Use crypto_hash_function.
3896 (syms_of_fns): Add Ssha1.
3897
7400048f
PE
38982011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3899
3900 * gnutls.c: Remove unused macros.
3901 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3902 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3903 Remove macros that are defined and never used.
3904 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3905
abb71cf4
CY
39062011-05-22 Chong Yidong <cyd@stupidchicken.com>
3907
3908 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3909 (Fx_get_selection_internal): Minor cleanup.
3910 (Fx_own_selection_internal): Rename arguments for consistency with
3911 select.el.
3912
6307db39
PE
39132011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3914
3915 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3916
f3d4e0a4
CY
39172011-05-22 Chong Yidong <cyd@stupidchicken.com>
3918
3919 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3920
4d8ade89
YM
39212011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3922
3923 * dispnew.c (scrolling_window): Don't exclude the case that the
3924 last enabled row in the desired matrix touches the bottom boundary.
3925
32078c8d
GM
39262011-05-21 Glenn Morris <rgm@gnu.org>
3927
3928 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3929 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3930 and add some more files.
32078c8d 3931
7285dc67
EZ
39322011-05-20 Eli Zaretskii <eliz@gnu.org>
3933
3934 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3935 report_file_error introduced by the change from 2011-05-07.
3936
89d1bd22
PE
39372011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3938
3939 * systime.h (Time): Define only if emacs is defined.
3940 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3941 where the include path doesn't have X11/X.h by default. See
3942 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3943
e23640bb 39442011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3945
3946 * composite.c (find_automatic_composition): Fix previous change.
3947
b9704ad9
GM
39482011-05-20 Glenn Morris <rgm@gnu.org>
3949
3950 * lisp.mk: New file, split from Makefile.in.
3951 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3952 (shortlisp): Remove.
3953 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3954
4a720484
GM
39552011-05-19 Glenn Morris <rgm@gnu.org>
3956
3957 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3958 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3959 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3960 (lisp): Set the order to that of loadup.el.
3961 (shortlisp): Make it a copy of $lisp.
3962 (SOME_MACHINE_LISP): Remove.
3963 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3964 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3965
a28d4396
KH
39662011-05-18 Kenichi Handa <handa@m17n.org>
3967
3968 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3969 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3970 (find_automatic_composition): Mostly rewrite for efficiency.
3971
a2b1fa8e
JB
39722011-05-18 Juanma Barranquero <lekktu@gmail.com>
3973
3974 * makefile.w32-in: Update dependencies.
3975
8e1f5610
CS
39762011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3977
3978 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3979 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3980
7025ee00 39812011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3982
cdfa6eab
PE
3983 Fix some integer overflow issues, such as string length overflow.
3984
06d6db33
PE
3985 * insdel.c (count_size_as_multibyte): Check for string overflow.
3986
2b4560a8
PE
3987 * character.c (lisp_string_width): Check for string overflow.
3988 Use EMACS_INT, not int, for string indexes and lengths; in
3989 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3990 the resulting string length overflows an EMACS_INT; instead,
3991 report a string overflow if no precision given. When checking for
3992 precision exhaustion, use a check that cannot possibly have
3993 integer overflow. (Bug#8675)
3994 * character.h (lisp_string_width): Adjust to new signature.
3995
cb93f9be
PE
3996 * alloc.c (string_overflow): New function.
3997 (Fmake_string): Use it. This doesn't change behavior, but saves
3998 a few bytes and will simplify future changes.
3999 * character.c (string_escape_byte8): Likewise.
4000 * lisp.h (string_overflow): New decl.
4001
1a1f3366
PE
4002 Fixups, following up to the user-interface timestamp change.
4003 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4004 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4005 * msdos.c (mouse_get_pos): Likewise.
4006 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4007 * w32gui.h (Time): Define by including "systime.h" rather than by
4008 declaring it ourselves. (Bug#8664)
4009
d4e3e4d3
PE
4010 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4011 * image.c (clear_image_cache): Likewise.
4012
f6a24d19
PE
4013 * term.c (term_mouse_position): Don't assume time_t wraparound.
4014
08dc5ae6
PE
4015 Be more systematic about user-interface timestamps.
4016 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4017 and sometimes 'EMACS_UINT', to represent these timestamps.
4018 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4019 This makes the code easier to follow, and makes it easier to catch
4020 integer overflow bugs such as Bug#8664.
4021 * frame.c (Fmouse_position, Fmouse_pixel_position):
4022 Use Time, not unsigned long, for user-interface timestamps.
4023 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4024 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4025 * keyboard.h (last_event_timestamp): Likewise.
4026 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4027 * menu.h (xmenu_show): Likewise.
4028 * term.c (term_mouse_position): Likewise.
4029 * termhooks.h (struct input_event.timestamp): Likewise.
4030 (struct terminal.mouse_position_hook): Likewise.
4031 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4032 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4033 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4034 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4035 what it was before.
4036 * menu.h, termhooks.h: Include "systime.h", for Time.
4037
8e55734a
PE
4038 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4039 Don't assume that the difference between two unsigned long values
4040 can fit into an integer. At this point, we know button_down_time
4041 <= event->timestamp, so the difference must be nonnegative, so
4042 there's no need to cast the result if double-click-time is
4043 nonnegative, as it should be; check that it's nonnegative, just in
4044 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4045 apart (about 25 days). (Bug#8664)
8e55734a 4046
841f1b75 4047 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4048 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4049
3e26f69c
PE
4050 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4051 that always fit in int. Use a sentinel instead of a counter, to
4052 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4053 * frame.h (struct frame): Use int for menu_bar_items_used
4054 instead of EMACS_INT, since it always fits in int.
3e26f69c 4055
5cc152c0
PE
4056 * menu.c (grow_menu_items): Check for int overflow.
4057
d89eb65e
PE
4058 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4059
5235bd3e
PE
4060 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4061 Before, the code was not consistent. These values cannot exceed
4062 2**31 - 1 so there's no need to make them unsigned.
4063 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4064 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4065 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4066 as modifiers.
4067 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4068
bc827e23
PE
4069 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4070 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4071 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4072 presumably because the widths might not match.
4073
78eb494e
PE
4074 * window.c (size_window): Avoid needless test at loop start.
4075
04f2d78b
CB
40762011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4077
4078 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4079
d2fc7e3d 40802011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4081
4082 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4083
d2fc7e3d 40842011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4085
4086 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4087 `width' to `bar_area_x' and `bar_area_width', respectively.
4088 (x_scroll_run): Take account of fringe background extension.
4089
04f2d78b
CB
4090 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4091 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4092 `bar_area_width', respectively.
4093 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4094 background extension.
4095
79b70037
GM
40962011-05-10 Jim Meyering <meyering@redhat.com>
4097
4098 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4099
2f142cc5
JB
41002011-05-10 Juanma Barranquero <lekktu@gmail.com>
4101
4102 * image.c (Finit_image_library): Return t for built-in image types,
4103 like pbm and xbm. (Bug#8640)
4104
57679c86
AS
41052011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4106
4107 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4108
888c9e86
EZ
41092011-05-07 Eli Zaretskii <eliz@gnu.org>
4110
b0512a1d
EZ
4111 * w32console.c (Fset_screen_color): Doc fix.
4112 (Fget_screen_color): New function.
4113 (syms_of_ntterm): Defsubr it.
4114
7285dc67
EZ
4115 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4116 unlink the temporary file if Fcall_process didn't create it in the
4117 first place.
4118 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4119 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4120 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4121 cue to call_process_cleanup not to close that handle.
4122
4d3fcc8e
BK
41232011-05-07 Ben Key <bkey76@gmail.com>
4124
4125 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4126 one of two shell specific rules, either bootstrap-temacs-CMD or
4127 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4128 to the previous implementation of the bootstrap-temacs rule.
4129 The bootstrap-temacs-CMD rule is similar to the previous
4130 implementation of the bootstrap-temacs rule except that it
4131 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4132 variable.
4133
4134 These changes, along with some changes to nt/configure.bat,
4135 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4136 earlier fix to add support for --cflags and --ldflags options
4137 that include quotes so that it works whether make uses cmd or
4138 sh as the shell.
4139
b4289b64
MA
41402011-05-06 Michael Albinus <michael.albinus@gmx.de>
4141
4142 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4143 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4144 is a constant.
4145 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4146 a string. Handle both cases.
4147 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4148 (Fdbus_register_method): Use Qinvalid_function.
4149
af4c0e28
JB
41502011-05-06 Juanma Barranquero <lekktu@gmail.com>
4151
4152 * makefile.w32-in: Update dependencies.
4153 (LISP_H): Add inttypes.h and stdin.h.
4154 (PROCESS_H): Add unistd.h.
4155
c51453d9
EZ
41562011-05-06 Eli Zaretskii <eliz@gnu.org>
4157
4158 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4159 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4160
8ff0ac3c 41612011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4162
4c4b566b
PE
4163 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4164
aab2b9b5
PE
4165 * term.c (vfatal): Remove stray call to va_end.
4166 It's not needed and the C Standard doesn't allow it here anyway.
4167
c378da0b
PE
4168 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4169 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4170
288b08c7
PE
4171 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4172 bytes.
4173
e3601888
PE
4174 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4175
db6c0e74
PE
4176 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4177
dd5963ea
PE
4178 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4179
88c9450f
PE
4180 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4181
2f9442b8
PE
4182 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4183
c032b5f8
PE
4184 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4185 * charset.c (Fdefine_charset_internal): Don't initialize
4186 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4187 32-bit int (Bug#8600).
a108c10b
PE
4188
4189 * lread.c (read_integer): Be more consistent with string-to-number.
4190 Use string_to_number to do the actual conversion; this avoids
4191 rounding errors and fixes some other screwups. Without this fix,
4192 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4193 (digit_to_number): Move earlier, for benefit of read_integer.
4194 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4195 not a digit in any supported base. (Bug#8602)
a108c10b 4196
ad5f9eea
PE
4197 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4198
aec1708a
PE
4199 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4200 to match comment at start of function. This also removes a
4201 GCC warning about overflow in a 32+64-bit port.
4202
47be4ab5
PE
4203 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4204
371cac43
PE
4205 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4206 Reported by Stefan Monnier in
4207 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4208 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4209 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4210
d01a7826
PE
4211 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4212 (EMACS_UINTPTR): Likewise, with uintptr_t.
4213
7fd47d5c
PE
4214 * lisp.h: Prefer 64-bit EMACS_INT if available.
4215 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4216 on 32-bit hosts that have 64-bit int, so that they can access
4217 large files.
122b0c86
PE
4218 However, temporarily disable this change unless the temporary
4219 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4220
8727937b
PE
4221 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4222
8ac068ac
PE
4223 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4224 This removes an assumption that EMACS_INT and long are the same
4225 width as pointers. The assumption is true for Emacs porting targets
4226 now, but we want to make other targets possible.
4227 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4228 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4229 In the rest of the code, change types of integers that hold casted
4230 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4231 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4232 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4233 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4234 No need to cast type when ORing.
4235 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4236 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4237 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4238 assume EMACS_INT is the same width as char *.
4239 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4240 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4241 Remove no-longer-needed casts.
4242 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4243 (xg_tool_bar_help_callback, xg_make_tool_item):
4244 Use EMACS_INTPTR to hold an integer
4245 that will be cast to void *; this can avoid a GCC warning
4246 if EMACS_INT is not the same width as void *.
4247 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4248 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4249 (current_message_1, set_message_1):
4250 Use a local to convert to proper width without a cast.
4251 * xmenu.c (dialog_selection_callback): Likewise.
4252
ede49d71
PE
4253 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4254 Also, don't assume VALBITS / RAND_BITS is less than 5,
4255 and don't rely on undefined behavior when shifting a 1 left into
4256 the sign bit.
4257 * lisp.h (get_random): Change signature to match.
4258
2f30ecd0
PE
4259 * lread.c (hash_string): Use size_t, not int, for hash computation.
4260 Normally we prefer signed values; but hashing is special, because
4261 it's better to use unsigned division on hash table sizes so that
4262 the remainder is nonnegative. Also, size_t is the natural width
4263 for hashing into memory. The previous code used 'int', which doesn't
4264 retain enough info to hash well into very large tables.
4265 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4266
2a866e7b
PE
4267 * dbusbind.c: Don't possibly lose pointer info when converting.
4268 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4269 Use XPNTR rather than XHASH, so that the high-order bits of
4270 the pointer aren't lost when converting through void *.
4271
51639eac
PE
4272 * eval.c (Fautoload): Don't double-shift a pointer.
4273
92394119
PE
4274 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4275
dbdb9a7c
JB
42762011-05-06 Juanma Barranquero <lekktu@gmail.com>
4277
4278 * gnutls.c (DEF_GNUTLS_FN):
4279 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4280
db7a0b4f
AS
42812011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4282
4283 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4284 marker. (Bug#8610)
4285
f7ff1b0f 42862011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4287
4288 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4289 New version that can reserve upto 2GB of heap space.
4290
f7ff1b0f 42912011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4292
4293 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4294
639c109b
TZ
42952011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4296
4297 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4298 `gnutls_certificate_set_x509_key_file'.
4299
d2127135
JB
43002011-05-05 Juanma Barranquero <lekktu@gmail.com>
4301
4302 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4303 Update dependencies.
4304
e968f4f3
JB
43052011-05-04 Juanma Barranquero <lekktu@gmail.com>
4306
4307 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4308 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4309 Remove unused parameter `fildes'.
4310 * process.c (read_process_output, send_process): Don't pass it.
4311
84d358f0
JB
43122011-05-04 Juanma Barranquero <lekktu@gmail.com>
4313
4314 Fix previous change: the library cache is defined in w32.c.
4315 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4316 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4317
0898ca10
JB
43182011-05-04 Juanma Barranquero <lekktu@gmail.com>
4319
4320 Implement dynamic loading of GnuTLS on Windows.
4321
4322 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4323 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4324 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4325 Declare.
4326
4327 * gnutls.c (Qgnutls_dll): Define.
4328 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4329 (gnutls_*): Declare function pointers.
4330 (init_gnutls_functions): New function to initialize function pointers.
4331 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4332 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4333 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4334 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4335 (emacs_gnutls_write, emacs_gnutls_read)
4336 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4337 (Fgnutls_available_p): New function.
4338 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4339 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4340 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4341
4342 * image.c: Include w32.h.
4343 (Vimage_type_cache): Delete.
4344 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4345 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4346 (w32_delayed_load): Move to w32.c.
4347
4348 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4349
4350 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4351 (w32_delayed_load): Move from image.c. When loading a library, record
4352 its filename in the :loaded-from property of the library id.
4353 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4354 Initialize and staticpro them.
4355 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4356
4357 * process.c: Include lisp.h before w32.h, not after.
4358 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4359 instead of gnutls_record_check_pending.
4360
4361 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4362
ff4de4aa
TZ
43632011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4364
4365 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4366 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4367 as passed in.
4368
abe95abb
JD
43692011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4370
4371 * xterm.c (x_set_frame_alpha): Do not set property on anything
4372 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4373
e16e55d4
JB
43742011-05-02 Juanma Barranquero <lekktu@gmail.com>
4375
4376 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4377
bafcf6a5
JB
43782011-05-02 Juanma Barranquero <lekktu@gmail.com>
4379
4380 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4381 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4382 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4383 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4384 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4385 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4386 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4387 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4388 (Qgnutls_bootprop_callbacks_verify): Make static.
4389
e7a6747f
AS
43902011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4391
19ed11ba
AS
4392 * callproc.c: Indentation fixup.
4393
e7a6747f 4394 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4395 (wait_for_termination, interruptible_wait_for_termination):
4396 Move after wait_for_termination_1.
e7a6747f 4397
1ef14cb4
LMI
43982011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4399
4400 * sysdep.c (interruptible_wait_for_termination): New function
4401 which is like wait_for_termination, but allows keyboard
4402 interruptions.
4403
4404 * callproc.c (Fcall_process): Add (:file "file") as an option for
4405 the STDOUT buffer.
4406 (Fcall_process_region): Ditto.
4407
330d880c
EZ
44082011-04-30 Eli Zaretskii <eliz@gnu.org>
4409
8db90b73
EZ
4410 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4411 rather than `XVECTOR (FOO)->size'.
4412
330d880c
EZ
4413 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4414 inttypes.h, as a gnulib replacement is used if it not available in
4415 system headers.
4416
15cbd324
EZ
44172011-04-21 Eli Zaretskii <eliz@gnu.org>
4418
4419 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4420 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4421 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4422
4423 * coding.c (coding_alloc_by_realloc): Error out if destination
4424 will grow beyond MOST_POSITIVE_FIXNUM.
4425 (decode_coding_emacs_mule): Abort if there isn't enough place in
4426 charbuf for the composition carryover bytes. Reserve an extra
4427 space for up to 2 characters produced in a loop.
4428 (decode_coding_iso_2022): Abort if there isn't enough place in
4429 charbuf for the composition carryover bytes.
4430
44312011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4432
ae940cca
EZ
4433 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4434 aborting when %lld or %lll format is passed.
4435 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4436 %llo or %llx format is passed. (Bug#8545)
4437
03ab8921
EZ
4438 * window.c (window_scroll_line_based): Use a marker instead of
4439 simple variables to record original value of point. (Bug#7952)
4440
afda1437
EZ
4441 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4442 produced by %s or %c overflows available buffer space. (Bug#8545)
4443
f76dee0c
PE
44442011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4445
4446 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4447 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4448
fdc5744d
JB
44492011-04-28 Juanma Barranquero <lekktu@gmail.com>
4450
4451 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4452
638f053a
JB
44532011-04-28 Juanma Barranquero <lekktu@gmail.com>
4454
4455 * keyboard.c (Qdelayed_warnings_hook): Define.
4456 (command_loop_1): Run `delayed-warnings-hook'
4457 if Vdelayed_warnings_list is non-nil.
4458 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4459 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4460
d178f871
EZ
44612011-04-28 Eli Zaretskii <eliz@gnu.org>
4462
4463 * doprnt.c (doprnt): Don't return value smaller than the buffer
4464 size if the message was truncated. (Bug#8545).
4465
b124fd93
JB
44662011-04-28 Juanma Barranquero <lekktu@gmail.com>
4467
4468 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4469 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4470
e810457d
PE
44712011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4472
4473 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4474
ea51cceb
JB
44752011-04-27 Juanma Barranquero <lekktu@gmail.com>
4476
4477 * makefile.w32-in: Update dependencies.
4478
94dcfacf
EZ
44792011-04-27 Eli Zaretskii <eliz@gnu.org>
4480
4481 Improve `doprnt' and its usage. (Bug#8545)
4482 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4483 `format_end'. Remove support for %l as a conversion specifier.
4484 Don't use xrealloc. Improve diagnostics when the %l size modifier
4485 is used. Update the commentary.
4486
4487 * eval.c (verror): Simplify calculation of size_t.
4488
4489 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4490 messages.
4491
f61f41d7
PE
44922011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4493
4494 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4495 change.
4496
96fb4434
PE
44972011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4498
4499 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4500 This makes this file independent of the recent pseudovector change.
4501
671875da 45022011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4503
69e9b5a3
PE
4504 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4505
b5f869a7 4506 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4507 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4508 Remove unused local.
c8926152 4509 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4510
841a1577 4511 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4512 GCC 4.6.0 optimizes based on type-based alias analysis.
4513 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4514 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4515 != &v->size, and therefore "v->size = 1; b->size = 2; return
4516 v->size;" must therefore return 1. This assumption is incorrect
4517 for Emacs, since it type-puns struct Lisp_Vector * with many other
4518 types. To fix this problem, this patch adds a new type struct
f904488f 4519 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4520 and pseudovectors, and helps optimizing compilers not get fooled
4521 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4522 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4523 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4524 the size member.
eab3844f
PE
4525 (XSETPVECTYPE): Rewrite in terms of new macro.
4526 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4527 This is a bit clearer, and further avoids the possibility of
4528 undesirable aliasing.
4529 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4530 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4531 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4532 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4533 (ASIZE): Now uses header.size rather than size.
4534 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4535 to avoid the hassle of writing XVECTOR (foo)->header.size.
4536 (struct vectorlike_header): New type.
eab3844f
PE
4537 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4538 object, to help avoid aliasing.
4539 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4540 (SUBRP): Likewise, since Lisp_Subr is a special case.
4541 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4542 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4543 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4544 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4545 changed to be "header.size" and "header.next".
4546 * buffer.h (struct buffer): Likewise.
4547 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4548 * frame.h (struct frame): Likewise.
4549 * process.h (struct Lisp_Process): Likewise.
4550 * termhooks.h (struct terminal): Likewise.
4551 * window.c (struct save_window_data, struct saved_window): Likewise.
4552 * window.h (struct window): Likewise.
4553 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4554 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4555 * buffer.c (init_buffer_once): Likewise.
4556 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4557 special case.
4558 * process.c (Fformat_network_address): Use local var for size,
4559 for brevity.
4560
0df1eac5
PE
4561 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4562
847ab9d1 4563 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4564 * data.c (atof): Remove decl; no longer used or needed.
4565 (digit_to_number): Move to lread.c.
4566 (Fstring_to_number): Use new string_to_number function, to be
4567 consistent with how the Lisp reader treats infinities and NaNs.
4568 Do not assume that floating-point numbers represent EMACS_INT
4569 without losing information; this is not true on most 64-bit hosts.
4570 Avoid double-rounding errors, by insisting on integers when
4571 parsing non-base-10 numbers, as the documentation specifies.
4572 * lisp.h (string_to_number): New decl, replacing ...
4573 (isfloat_string): Remove.
bc0a5c13 4574 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4575 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4576 appears to have been a coding error. Similarly, do not accept
4577 strings like +-1e0 as floating point numbers. Do not report
4578 overflow for integer overflows unless the base is not 10 which
4579 means we have no simple and reliable way to continue.
4580 Break out the floating-point parsing into a new
4581 function string_to_number, so that Fstring_to_number parses
4582 floating point numbers consistently with the Lisp reader.
04f2d78b 4583 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4584 (E_CHAR, EXP_INT): Remove, replacing with ...
4585 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4586 (string_to_number): New function, replacing isfloat_string.
4587 This function checks for valid syntax and produces the resulting
4588 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4589 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4590 so that overflow for non-base-10 numbers is reported only when
4591 there's no portable and simple way to convert to floating point.
452f4150 4592
67769ffc
PE
4593 * textprop.c (set_text_properties_1): Rewrite for clarity,
4594 and to avoid GCC warning about integer overflow.
4595
c20db43f
PE
4596 * intervals.h (struct interval): Use EMACS_INT for members
4597 where EMACS_UINT might cause problems. See
4598 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4599 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4600 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4601 All uses changed.
37aa2f85
PE
4602 (offset_intervals): Tell GCC not to worry about length overflow
4603 when negating a negative length.
c20db43f 4604
2538aa2f
PE
4605 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4606 (overrun_check_free): Likewise.
4607
f2d3008d
PE
4608 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4609 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4610 word size.
4611
ec8df744
PE
4612 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4613 (gnutls_make_error): Rename local to avoid shadowing.
4614 (gnutls_emacs_global_deinit): ifdef out; not used.
4615 (Fgnutls_boot): Use const for pointer to readonly storage.
4616 Comment out unused local. Fix pointer signedness problems.
4617
640ee02d
PE
4618 * lread.c (openp): Don't stuff size_t into an 'int'.
4619 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4620 about possible signed overflow.
4621
6048fb2a
PE
4622 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4623 (GDK_KEY_g): Don't define if already defined.
4624 (xg_prepare_tooltip): Avoid pointer signedness problem.
4625 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4626
fa3c87e1
PE
4627 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4628 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4629
2172544b
PE
4630 * xfns.c (Fx_window_property): Simplify a bit,
4631 to make a bit faster and to avoid GCC 4.6.0 warning.
4632 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4633
9b821a21
PE
4634 * fns.c (internal_equal): Don't assume size_t fits in int.
4635
3c616cfa
PE
4636 * alloc.c (compact_small_strings): Tighten assertion a little.
4637
c2982e87
PE
4638 Replace pEd with more-general pI, and fix some printf arg casts.
4639 * lisp.h (pI): New macro, generalizing old pEd macro to other
4640 conversion specifiers. For example, use "...%"pI"d..." rather
4641 than "...%"pEd"...".
4642 (pEd): Remove. All uses replaced with similar uses of pI.
4643 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4644 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4645 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4646 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4647 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4648 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4649 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4650 64-bit hosts.
4651 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4652 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4653 * print.c (safe_debug_print, print_object): Likewise.
4654 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4655 to int.
6f04d126
PE
4656 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4657 avoiding the 0 flag, which is not portable.
c2982e87
PE
4658 * process.c (Fmake_network_process): Use pI to avoid cast.
4659 * region-cache.c (pp_cache): Likewise.
4660 * xdisp.c (decode_mode_spec): Likewise.
4661 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4662 behavior on 64-bit hosts with printf arg.
6f04d126 4663 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4664 (x_stop_queuing_selection_requests): Likewise.
4665 (x_get_window_property): Don't truncate byte count to an 'int'
4666 when tracing.
0b432f21 4667
5e073ec7
PE
4668 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4669 here, since it parses constructs like leading '-' and spaces,
4670 which are not wanted; and it overflows with large numbers.
4671 Instead, simply match F[0-9]+, which is what is wanted anyway.
4672
36372bf9
PE
4673 * alloc.c: Remove unportable assumptions about struct layout.
4674 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4675 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4676 (allocate_vectorlike, make_pure_vector): Use the new macros,
4677 plus offsetof, to remove unportable assumptions about struct layout.
4678 These assumptions hold on all porting targets that I know of, but
4679 they are not guaranteed, they're easy to remove, and removing them
4680 makes further changes easier.
4681
0b432f21
PE
4682 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4683 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4684 (string_overrun_cookie): Now const. Use initializers that
4685 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4686 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4687 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4688 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4689 multiple of sizeof (EMACS_INT); it need not be, if
4690 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4691 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4692
895009e1
JB
46932011-04-26 Juanma Barranquero <lekktu@gmail.com>
4694
4695 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4696
6a7a1b0b
TZ
46972011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4698
4699 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4700 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4701 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4702
841a1577 47032011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4704
4705 * lisp.h (Qdebug): List symbol.
895009e1 4706 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4707 * keyboard.c (debug-on-event): New variable.
4708 (handle_user_signal): Break into debugger when debug-on-event
4709 matches the current signal symbol.
4710
f2d3ba6f
DN
47112011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4712
4713 * alloc.c (check_sblock, check_string_bytes)
4714 (check_string_free_list): Convert to standard C.
4715
42ce4c63
TZ
47162011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4717
4718 * w32.c (emacs_gnutls_push): Fix typo.
4719
825cd63c
EZ
47202011-04-25 Eli Zaretskii <eliz@gnu.org>
4721
fb11d64d
EZ
4722 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4723 "cast to pointer from integer of different size".
4724
825cd63c
EZ
4725 Improve doprnt and its use in verror. (Bug#8545)
4726 * doprnt.c (doprnt): Document the set of format control sequences
4727 supported by the function. Use SAFE_ALLOCA instead of always
4728 using `alloca'.
4729
4730 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4731 is one byte too soon. Don't use xrealloc; instead xfree and
4732 xmalloc anew.
4733
e061a11b
TZ
47342011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4735
4736 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4737 callbacks stage.
4738
4739 * gnutls.c: Renamed global_initialized to
4740 gnutls_global_initialized. Added internals for the
4741 :verify-hostname-error, :verify-error, and :verify-flags
4742 parameters of `gnutls-boot' and documented those parameters in the
4743 docstring. Start callback support.
9173deec
JB
4744 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4745 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4746 on error. Return error code.
e061a11b
TZ
4747 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4748 (emacs_gnutls_read): Likewise.
4749 (Fgnutls_boot): Return handshake error code.
4750 (emacs_gnutls_handle_error): New function.
4751 (wsaerror_to_errno): Likewise.
4752
4753 * w32.h (emacs_gnutls_pull): Add prototype.
4754 (emacs_gnutls_push): Likewise.
4755
4756 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4757 (emacs_gnutls_push): Likewise.
4758
47592011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4760
4761 * process.c (wait_reading_process_output): Check if GnuTLS
4762 buffered some data internally if no FDs are set for TLS
4763 connections.
4764
4765 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4766 (LIBS): Link to USER_LIBS.
4767 ($(BLD)/gnutls.$(0)): New target.
4768
fa6996bc
EZ
47692011-04-24 Eli Zaretskii <eliz@gnu.org>
4770
eb35682e
EZ
4771 * xdisp.c (handle_single_display_spec): Rename the
4772 display_replaced_before_p argument into display_replaced_p, to
4773 make it consistent with the commentary. Fix typos in the
4774 commentary.
4775
e2ad650c
EZ
4776 * textprop.c (syms_of_textprop): Remove dead code.
4777 (copy_text_properties): Delete obsolete commentary about an
4778 interface that was deleted long ago. Fix typos in the description
4779 of arguments.
4780
1b2de274
EZ
4781 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4782 to changes in oldXMenu/XMenu.h from 2011-04-16.
4783 <menu_help_message, prev_menu_help_message>: Constify.
4784 (IT_menu_make_room): menu->help_text is now `const char **';
4785 adjust.
4786
4787 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4788 to changes in oldXMenu/XMenu.h from 2011-04-16.
4789 (struct XMenu): Declare `help_text' `const char **'.
4790
4791 * xfaces.c <Qunspecified>: Make extern again.
4792
4793 * syntax.c: Include sys/types.h before including regex.h, as
4794 required by Posix.
4795
762b15be
EZ
4796 * doc.c (get_doc_string): Improve the format passed to `error'.
4797
4798 * doprnt.c (doprnt): Improve commentary.
4799
4800 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4801
4802 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4803 them with etags.
4804
f1052e5d
EZ
4805 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4806 changes in globals.h immediately force recompilation.
762b15be
EZ
4807 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4808 $(CURDIR)/s/ms-w32.h.
4809 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4810
fa6996bc
EZ
4811 * character.c (Fchar_direction): Function deleted.
4812 (syms_of_character): Don't defsubr it.
4813 <char-direction-table>: Deleted.
4814
e6c3da20
EZ
48152011-04-23 Eli Zaretskii <eliz@gnu.org>
4816
4817 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4818 * doprnt.c: Include limits.h.
4819 (SIZE_MAX): New macro.
04f2d78b
CB
4820 (doprnt): Return a size_t value. 2nd arg is now size_t.
4821 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4822 Improve overflow protection. Support `l' modifier for integer
4823 conversions. Support %l conversion. Don't assume an EMACS_INT
4824 argument for integer conversions and for %c.
4825
4826 * lisp.h (doprnt): Restore prototype.
4827
4828 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4829 $(SRC)/character.h.
4830
4831 * Makefile.in (base_obj): Add back doprnt.o.
4832
4833 * deps.mk (doprnt.o): Add back prerequisites.
4834 (callint.o): Depend on character.h.
4835
4836 * eval.c (internal_lisp_condition_case): Include the handler
4837 representation in the error message.
4838 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4839 when breaking from the loop.
4840
4841 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4842
4843 * callint.c (Fcall_interactively): When displaying error message
4844 about invalid control letter, pass the character's codepoint, not
4845 a pointer to its multibyte form. Improve display of the character
4846 in octal and display also its hex code.
4847
4848 * character.c (char_string): Use %x to display the (unsigned)
4849 codepoint of an invalid character, to avoid displaying a bogus
4850 negative value.
4851
4852 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4853 `error', not SYMBOL_NAME itself.
4854
4855 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4856 character arguments to `error'.
4857
4858 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4859 to `error' in error message about FINAL_CHAR argument. Make sure
4860 FINAL_CHAR is a character, and use %c when it is passed as
4861 argument to `error'.
4862
4ffd0d6b 48632011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4864
4865 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4866
4867 * w32.c: Include <time.h>.
4868 (sys_localtime): New function.
4869
4ffd0d6b 48702011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4871
4872 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4873
4ffd0d6b 4874 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4875
4ffd0d6b 48762011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4877
4ffd0d6b
GM
4878 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4879 zombies (Bug#8467).
aac0c6e3 4880
04c56954
EZ
48812011-04-19 Eli Zaretskii <eliz@gnu.org>
4882
4883 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4884 gl_state.e_property when gl_state.object is Qt.
4885
4886 * insdel.c (make_gap_larger): Remove limitation of buffer size
4887 to <= INT_MAX.
4888
16a43933
CY
48892011-04-18 Chong Yidong <cyd@stupidchicken.com>
4890
4891 * xdisp.c (lookup_glyphless_char_display)
4892 (produce_glyphless_glyph): Handle cons cell entry in
4893 glyphless-char-display.
4894 (Vglyphless_char_display): Document it.
4895
4896 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4897 glyphless-char-display.
4898
4581706e
CY
48992011-04-17 Chong Yidong <cyd@stupidchicken.com>
4900
4901 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4902
4903 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4904
4905 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4906 definition for no-X builds.
4907
4887c6e2 49082011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4909
fd35b6f9
PE
4910 Static checks with GCC 4.6.0 and non-default toolkits.
4911
5c1ccb01
PE
4912 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4913
006c5daa
PE
4914 * process.c (keyboard_bit_set): Define only if SIGIO.
4915 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4916 (send_process): Repair possible setjmp clobbering.
4917
efc736d3
PE
4918 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4919
4e2fe2e6
PE
4920 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4921
f97334a2
PE
4922 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4923
4e75f29d
PE
4924 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4925 Define only if needed.
4926
90efadd1
PE
4927 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4928 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4929 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4930
3c647824
PE
4931 * dispextern.h (struct redisplay_interface): Rename param
4932 to avoid shadowing.
e264f262 4933 * termhooks.h (struct terminal): Likewise.
761383f4 4934 * xterm.c (xembed_send_message): Likewise.
3c647824 4935
b58c5c4a
PE
4936 * insdel.c (make_gap_smaller): Define only if
4937 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4938
cad59032
PE
4939 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4940 it.
4941
c339dc2e
PE
4942 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4943 so that we aren't warned about unused symbols.
4944
91a3e27b
PE
4945 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4946
399c71d3 4947 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4948
8ffc96f5
PE
4949 * xfns.c (x_real_positions): Mark locals as initialized.
4950
eef9bc79
PE
4951 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4952
098db9dd
PE
4953 * xterm.c: Fix problems found by static analysis with other toolkits.
4954 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4955 (x_dispatch_event): Declare static if USE_GTK, and
4956 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4957 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4958 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4959 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4960 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4961
eb18f6cc
PE
4962 * xmenu.c (menu_help_callback): Pointer type fixes.
4963 Use const pointers when pointing at readonly data. Avoid pointer
4964 signedness clashes.
4965 (FALSE): Remove unused macro.
4966 (update_frame_menubar): Remove unused decl.
4967
1fe72bf8
PE
4968 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4969
60d9e1db
PE
4970 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4971 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4972 (single_menu_item): Rename local to avoid shadowing.
4973
39261c26
PE
4974 * keyboard.c (make_lispy_event): Remove unused local var.
4975
018c5e19
PE
4976 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4977 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4978
63d2b86e
PE
4979 * bitmaps: Change bitmaps from unsigned char back to the X11
4980 compatible char. Avoid the old compiler warnings about
4981 out-of-range initializers by using, for example, '\xab' rather
4982 than 0xab.
4983
aefd87e1
PE
4984 * xgselect.c (xgselect_initialize): Check vs interface
4985 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4986
bf501fb9
PE
4987 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4988
e9829fdf
PE
4989 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4990 to read-only memory.
4991
1086c095
PE
4992 * fns.c (vector): Remove; this old hack is no longer needed.
4993
2baccd04 4994 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4995 Remove unused var.
dde42981 4996 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4997
72391843 4998 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4999
436c16df 5000 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5001 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5002 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5003
92bb796d 5004 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5005 (x_term_init): Remove local to avoid shadowing.
92bb796d 5006
764430a3 5007 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5008
5009 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5010 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5011
d1dfb56c
EZ
50122011-04-16 Eli Zaretskii <eliz@gnu.org>
5013
c4354cb4
EZ
5014 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5015
d1dfb56c
EZ
5016 Fix regex.c, syntax.c and friends for buffers > 2GB.
5017 * syntax.h (struct gl_state_s): Declare character position members
5018 EMACS_INT.
5019
5020 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5021
04f2d78b
CB
5022 * textprop.c (verify_interval_modification, interval_of):
5023 Declare arguments EMACS_INT.
d1dfb56c
EZ
5024
5025 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5026 EMACS_INT.
5027
5028 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5029
5030 * indent.c (Fvertical_motion): Local variable it_start is now
5031 EMACS_INT.
5032
5033 * regex.c (re_match, re_match_2, re_match_2_internal)
5034 (bcmp_translate, regcomp, regexec, print_double_string)
5035 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5036 (re_compile_pattern, re_exec): Declare arguments and local
5037 variables `size_t' and `ssize_t' and return values `regoff_t', as
5038 appropriate.
5039 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5040 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5041 <compile_stack_type>: `size' and `avail' are now `size_t'.
5042
5043 * regex.h <regoff_t>: Use ssize_t, not int.
5044 (re_search, re_search_2, re_match, re_match_2): Arguments that
5045 specify buffer/string position and length are now ssize_t and
5046 size_t. Return type is regoff_t.
5047
613052cd
BK
50482011-04-16 Ben Key <bkey76@gmail.com>
5049
5050 * nsfont.m: Fixed bugs in ns_get_family and
5051 ns_descriptor_to_entity that were caused by using free to
5052 deallocate memory blocks that were allocated by xmalloc (via
5053 xstrdup). This caused Emacs to crash when compiled with
5054 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5055 --enable-checking=xmallocoverrun). xfree is now used to
5056 deallocate these memory blocks.
5057
4170f62f 50582011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5059
71b41406
PE
5060 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5061
9587a89d
PE
5062 emacs_write: Accept and return EMACS_INT for sizes.
5063 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5064 et seq.
5065 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5066 Accept and return EMACS_INT.
5067 (emacs_gnutls_write): Return the number of bytes written on
5068 partial writes.
5069 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5070 (emacs_read, emacs_write): Remove check for negative size, as the
5071 Emacs source code has been audited now.
9587a89d
PE
5072 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5073 (emacs_read, emacs_write): Use it.
273a5f82
PE
5074 * process.c (send_process): Adjust to the new signatures of
5075 emacs_write and emacs_gnutls_write. Do not attempt to store
5076 a byte offset into an 'int'; it might overflow.
9587a89d 5077 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5078
3e047f51
PE
5079 * sound.c: Don't assume sizes fit in 'int'.
5080 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5081 Return EMACS_INT, not int.
3e047f51 5082 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5083 Accept EMACS_INT, not int.
5084 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5085 record read return values.
5086
cc39a9db
BK
50872011-04-15 Ben Key <bkey76@gmail.com>
5088
c9d0ec6d
JB
5089 * keyboard.c (Qundefined): Don't declare static since it is used
5090 in nsfns.m.
5091 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5092 static since they are used in nsfont.m.
cc39a9db 5093
6c60eb9f
SM
50942011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5095
5096 * process.c (Qprocessp): Don't declare static.
5097 * lisp.h (Qprocessp): Declare again.
5098
7990b61a
JB
50992011-04-15 Juanma Barranquero <lekktu@gmail.com>
5100
5101 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5102
5d4cb038
PE
51032011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5104
8bd7b830 5105 Improve C-level modularity by making more things 'static'.
cd64ea1d 5106
e3b27b31
PE
5107 Don't publish debugger-only interfaces to other modules.
5108 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5109 (verify_bytepos, count_markers): Move decls to the only modules
5110 that need them.
5111 * region-cache.h (pp_cache): Likewise.
5112 * window.h (check_all_windows): Likewise.
5113 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5114
5d4cb038
PE
5115 * sysdep.c (croak): Now static, if
5116 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5117 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5118
5119 * alloc.c (refill_memory_reserve): Now static if
5120 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5121 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5122
e87b6180
PE
5123 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5124 Define only if USE_LUCID.
5125
ac64929e
PE
5126 * xrdb.c (x_customization_string, x_rm_string): Now static.
5127
6f37259d
PE
5128 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5129 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5130
1683e3ab
PE
5131 * xdisp.c (draw_row_with_mouse_face): Now static.
5132 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5133
de9c2632
PE
5134 * window.h (check_all_windows): Mark externally visible.
5135
2b96acb7
PE
5136 * window.c (window_deletion_count): Now static.
5137
5138 * undo.c: Make symbols static if they're not exported.
5139 (last_undo_buffer, last_boundary_position, pending_boundary):
5140 Now static.
5141
50436f33
PE
5142 * textprop.c (interval_insert_behind_hooks): Now static.
5143 (interval_insert_in_front_hooks): Likewise.
5144
64520e5c
PE
5145 * term.c: Make symbols static if they're not exported.
5146 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5147 (max_frame_lines, tty_set_terminal_modes):
5148 (tty_reset_terminal_modes, tty_turn_off_highlight):
5149 (get_tty_terminal): Now static.
5150 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5151 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5152 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5153 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5154 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5155
1fa53021
PE
5156 * sysdep.c: Make symbols static if they're not exported.
5157 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5158 Now static.
5159 (sigprocmask_set, full_mask): Remove; unused.
5160 (wait_debugging): Mark as visible.
5161 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5162 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5163
d4b43b22
PE
5164 * syntax.c (syntax_temp): Define only if !__GNUC__.
5165
b7c513d0
PE
5166 * sound.c (current_sound_device, current_sound): Now static.
5167
989b29ad
PE
5168 * search.c (searchbufs, searchbuf_head): Now static.
5169
13a55a78
PE
5170 * scroll.c (scroll_cost): Remove; unused.
5171 * dispextern.h (scroll_cost): Remove decl.
5172
de68a1fc
PE
5173 * region-cache.h (pp_cache): Mark as externally visible.
5174
40ccffa6
PE
5175 * process.c: Make symbols static if they're not exported.
5176 (process_tick, update_tick, create_process, chan_process):
5177 (Vprocess_alist, proc_buffered_char, datagram_access):
5178 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5179 (deactivate_process): Mark defn as static, as well as decl.
5180 * lisp.h (create_process): Remove decl.
5181 * process.h (chan_process, Vprocess_alist): Remove decls.
5182
ad64fc97
PE
5183 * print.c: Make symbols static if they're not exported.
5184 (print_depth, new_backquote_output, being_printed, print_buffer):
5185 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5186 (print_interval, print_number_index, initial_stderr_stream):
5187 Now static.
5188 * lisp.h (Fprinc): Remove decl.
5189 (debug_output_compilation_hack): Mark as externally visible.
5190
adddb265
PE
5191 * sysdep.c (croak): Move decl from here to syssignal.h.
5192 * syssignal.h (croak): Put it here, so the API can be checked when
5193 'croak' is called from dissociate_if_controlling_tty.
5194
1717ede2
PE
5195 * minibuf.c: Make symbols static if they're not exported.
5196 (minibuf_save_list, choose_minibuf_frame): Now static.
5197 * lisp.h (choose_minibuf_frame): Remove decl.
5198
fa5fb2bc
PE
5199 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5200
1e3890d1
PE
5201 * lread.c: Make symbols static if they're not exported.
5202 (read_objects, initial_obarray, oblookup_last_bucket_number):
5203 Now static.
5204 (make_symbol): Remove; unused.
5205 * lisp.h (initial_obarray, make_symbol): Remove decls.
5206
8a1414fa
PE
5207 * keyboard.c: Make symbols static if they're not exported.
5208 (single_kboard, recent_keys_index, total_keys, recent_keys):
5209 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5210 (this_single_command_key_start, echoing, last_auto_save):
5211 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5212 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5213 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5214 (Vlispy_mouse_stem, double_click_count):
5215 Now static.
5216 (force_auto_save_soon): Define only if SIGDANGER.
5217 (ignore_mouse_drag_p): Now static if
5218 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5219 (print_help): Remove; unused.
5220 (stop_character, last_timer_event): Mark as externally visible.
5221 * keyboard.h (ignore_mouse_drag_p): Declare only if
5222 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5223 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5224 * lisp.h (echoing): Remove decl.
5225 (force_auto_save_soon): Declare only if SIGDANGER.
5226 * xdisp.c (redisplay_window): Simplify code, to make it more
5227 obvious that ignore_mouse_drag_p is not accessed if !defined
5228 USE_GTK && !defined HAVE_NS.
5229
93ea6e8f
PE
5230 * intervals.c: Make symbols static if they're not exported.
5231 (merge_properties_sticky, merge_interval_right, delete_interval):
5232 Now static.
5233 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5234
77382fcc
PE
5235 * insdel.c: Make symbols static if they're not exported.
5236 However, leave prepare_to_modify_buffer alone. It's never
5237 called from outside this function, but that appears to be a bug.
5238 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5239 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5240 (adjust_after_replace_noundo): Remove; unused.
5241 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5242 (signal_before_change): Remove decls.
77382fcc 5243
9306c32e
PE
5244 * indent.c (val_compute_motion, val_vmotion): Now static.
5245
cd44d2eb
PE
5246 * image.c: Make symbols static if they're not exported.
5247 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5248 if USE_GTK.
5249 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5250 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5251
ad9a7a06
PE
5252 * fringe.c (standard_bitmaps): Now static.
5253 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5254
81626931
PE
5255 * frame.c: Make symbols static if they're not exported.
5256 (x_report_frame_params, make_terminal_frame): Now static.
5257 (get_frame_param): Now static, unless HAVE_NS.
5258 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5259 (x_get_resource_string): Remove; not used.
5260 * frame.h (make_terminal_frame, x_report_frame_params):
5261 (x_get_resource_string); Remove decls.
5262 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5263 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5264
239f9db9
PE
5265 * font.c, fontset.c: Make symbols static if they're not exported.
5266 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5267 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5268 * font.c (font_close_object): Now static.
5269 * font.h (font_close_object): Remove.
5270 * fontset.c (FONTSET_OBJLIST): Remove.
5271 (free_realized_fontset) #if-0 the body, which does nothing.
5272 (face_suitable_for_char_p): #if-0, as it's never called.
5273 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5274 * xfaces.c (face_at_string_position):
5275 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5276 since 0 is always ASCII.
5277
dfcf3579
PE
5278 * fns.c (weak_hash_tables): Now static.
5279
5045092b
PE
5280 * fileio.c: Make symbols static if they're not exported.
5281 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5282 (Vwrite_region_annotation_buffers): Now static.
5283
57a96f5c
PE
5284 * eval.c: Make symbols static if they're not exported.
5285 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5286 * lisp.h (backtrace_list): Remove decl.
5287
35f08c38
PE
5288 * emacs.c: Make symbols static if they're not exported.
5289 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5290 (fatal_error_code, fatal_error_signal_hook, standard_args):
5291 Now static.
5292 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5293 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5294 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5295 * lisp.h (fatal_error_signal_hook): Remove decl.
5296 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5297
f44bd759
PE
5298 * editfns.c: Move a (normally-unused) function to its only use.
5299 * editfns.c, lisp.h (get_operating_system_release): Remove.
5300 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5301 worth the hassle of breaking this out.
5302
b532497d
PE
5303 * xterm.c: Make symbols static if they're not exported.
5304 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5305 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5306 (x_destroy_window, x_delete_display):
5307 Now static.
5308 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5309 (x_mouse_leave): Remove; unused.
5310 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5311 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5312 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5313 Remove decls.
5314 (x_mouse_leave): Declare only if WINDOWSNT.
5315 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5316 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5317 USE_X_TOOLKIT.
5318
1675728f
PE
5319 * ftxfont.c: Make symbols static if they're not exported.
5320 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5321 HAVE_FREETYPE.
5322 * font.h (ftxfont_driver): Likewise.
5323
e4cebfca
PE
5324 * xfns.c: Make symbols static if they're not exported.
5325 (x_last_font_name, x_display_info_for_name):
5326 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5327 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5328 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5329 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5330 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5331 (last_show_tip_args): Now static.
5332 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5333 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5334 (x_screen_planes): Remove; unused.
5335 * dispextern.h (x_screen_planes): Remove decl.
5336
5bf46f05
PE
5337 * dispnew.c: Make symbols static if they're not exported.
5338 * dispextern.h (redraw_garbaged_frames, scrolling):
5339 (increment_row_positions): Remove.
5340 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5341 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5342 Now static.
5343 (redraw_garbaged_frames): Remove; unused.
5344
435f4c28
PE
5345 * xfaces.c: Make symbols static if they're not exported.
5346 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5347 Remove decls.
5348 * xterm.h (defined_color): Remove decls.
5349 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5350 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5351 (menu_face_changed_default, defined_color, free_realized_face):
5352 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5353 (ascii_face_of_lisp_face): Remove; unused.
5354
8524aef3
PE
5355 * xdisp.c: Make symbols static if they're not exported.
5356 * dispextern.h (scratch_glyph_row, window_box_edges):
5357 (glyph_to_pixel_coords, set_cursor_from_row):
5358 (get_next_display_element, set_iterator_to_next):
5359 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5360 (show_mouse_face): Remove decls
5361 * frame.h (message_buf_print): Likewise.
5362 * lisp.h (pop_message, set_message, check_point_in_composition):
5363 Likewise.
5364 * xterm.h (set_vertical_scroll_bar): Likewise.
5365 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5366 (message_buf_print, scratch_glyph_row, displayed_buffer):
5367 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5368 (get_next_display_element, show_mouse_face, window_box_edges):
5369 (frame_to_window_pixel_xy, check_point_in_composition):
5370 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5371 (glyph_to_pixel_coords): Remove; unused.
5372
16390cd2
PE
5373 * dired.c (file_name_completion): Now static.
5374
5375 * dbusbind.c (xd_in_read_queued_messages): Now static.
5376
a25f4dfa
PE
5377 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5378 * data.c (circular_list_error): Remove.
5379
14a9c8df
PE
5380 * commands.h (last_point_position, last_point_position_buffer):
5381 (last_point_position_window): Remove decls.
5382 * keyboard.c: Make these variables static.
5383
04f2d78b
CB
5384 * coding.h (coding, code_convert_region, encode_coding_gap):
5385 Remove decls.
74ab6df5
PE
5386 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5387 (iso_code_class, detect_coding, code_convert_region): Now static.
5388 (encode_coding_gap): Remove; unused.
5389
38dfbee1
PE
5390 * chartab.c (chartab_chars, chartab_bits): Now static.
5391
a2cb4e63
PE
5392 * charset.h (charset_iso_8859_1): Remove decl.
5393 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5394 Now static.
5395
127198fd
PE
5396 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5397 * ccl.c (Vccl_program_table): Now static.
5398 (check_ccl_update): Remove; unused.
5399
d85b608f
PE
5400 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5401 * category.h: ... from here.
5402 * category.c (check_category_table, set_category_set): Now static.
5403
31cd66f3
PE
5404 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5405 * lisp.h: Remove these decls.
5406
c358e587
PE
5407 * buffer.c (buffer_count): Remove unused var.
5408
e78aecca
PE
5409 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5410 so that it's not optimized away.
5411 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5412 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5413 exported only to the debugger.
5414
e192d7d3 5415 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5416 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5417
92470028
PE
5418 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5419 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5420 was inaccessible from Lisp.
5421 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5422 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5423
244ed907
PE
5424 alloc.c: Import and export fewer symbols, and remove unused items.
5425 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5426 is defined.
5427 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5428 it's not optimized away by whole-program optimization.
5429 (message_enable_multibyte, free_misc): Remove.
5430 (catchlist, handlerlist, mark_backtrace):
5431 Declare only if BYTE_MARK_STACK.
5432 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5433 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5434 (message_enable_multibyte): Remove decl.
5435 (free_misc, interval_free_list, float_block, float_block_index):
5436 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5437 (cons_free_list, last_marked_index):
5438 Now static.
5439 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5440 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5441 (mark_backtrace): Define only if BYTE_MARK_STACK.
5442 * xdisp.c (message_enable_multibyte): Now static.
5443
61c2b50e 5444 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5445 This makes it easier for human readers (and static analyzers)
5446 to see whether these variables are used from other modules.
5447 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5448 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5449 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5450 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5451 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5452 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5453 * xmenu.c, xselect.c:
5454 Declare Q* vars static if they are not used in other modules.
5455 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5456 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5457 Remove decls of unexported vars.
5458 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5459
95c82688
PE
5460 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5461
16a97296
PE
5462 Make Emacs functions such as Fatom 'static' by default.
5463 This makes it easier for human readers (and static analyzers)
5464 to see whether these functions can be called from other modules.
5465 DEFUN now defines a static function. To make the function external
5466 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5467 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5468 (Finit_image_library):
16a97296
PE
5469 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5470 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5471 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5472 Remove decls, since these functions are now static.
5473 (Funintern, Fget_internal_run_time): New decls, since these functions
5474 were already external.
95c82688 5475
16a97296
PE
5476 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5477 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5478 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5479 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5480 * keyboard.c, keymap.c, lread.c:
5481 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5482 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5483 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5484 Mark functions with DEFUE instead of DEFUN,
5485 if they are used in other modules.
5486 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5487 decls for now-static functions.
5488 * buffer.h (Fdelete_overlay): Remove decl.
5489 * callproc.c (Fgetenv_internal): Mark as internal.
5490 * composite.c (Fremove_list_of_text_properties): Remove decl.
5491 (Fcomposition_get_gstring): New forward static decl.
5492 * composite.h (Fcomposite_get_gstring): Remove decl.
5493 * dired.c (Ffile_attributes): New forward static decl.
5494 * doc.c (Fdocumntation_property): New forward static decl.
5495 * eval.c (Ffetch_bytecode): New forward static decl.
5496 (Funintern): Remove extern decl; now in .h file where it belongs.
5497 * fileio.c (Fmake_symbolic_link): New forward static decl.
5498 * image.c (Finit_image_library): New forward static decl.
5499 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5500 * intervals.h (Fprevious_property_change):
5501 (Fremove_list_of_text_properties): Remove decls.
5502 * keyboard.c (Fthis_command_keys): Remove decl.
5503 (Fcommand_execute): New forward static decl.
5504 * keymap.c (Flookup_key): New forward static decl.
5505 (Fcopy_keymap): Now static.
5506 * keymap.h (Flookup_key): Remove decl.
5507 * process.c (Fget_process): New forward static decl.
5508 (Fprocess_datagram_address): Mark as internal.
5509 * syntax.c (Fsyntax_table_p): New forward static decl.
5510 (skip_chars): Remove duplicate decl.
5511 * textprop.c (Fprevious_property_change): New forward static decl.
5512 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5513 Now internal.
5514 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5515 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5516
785bbd42
PE
5517 * editfns.c (Fformat): Remove unreachable code.
5518
8b913b57
AS
55192011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5520
5521 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5522 change. (Bug#8496)
5523
a6744a35
EZ
55242011-04-13 Eli Zaretskii <eliz@gnu.org>
5525
5526 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5527 when at ZV. (Bug#8487)
5528
e7974947
AS
55292011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5530
baad03f0
AS
5531 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5532 (Bug#8437)
5533 * keyboard.c (parse_tool_bar_item): Likewise.
5534 * sound.c (sound_cleanup, alsa_close): Likewise.
5535 * termcap.c (tgetent): Likewise.
5536 * xfns.c (x_default_font_parameter): Likewise.
5537 * xsettings.c (read_and_apply_settings): Likewise.
5538
e7974947
AS
5539 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5540 (overrun_check_free): Protoize.
5541
28272684
PE
55422011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5543
5544 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5545 since callers should never pass a negative size.
5546 Change the signature to match that of plain 'read' and 'write'; see
5547 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5548 * lisp.h: Update prototypes of emacs_write and emacs_read.
5549
11997c76
EZ
55502011-04-11 Eli Zaretskii <eliz@gnu.org>
5551
5552 * xdisp.c (redisplay_window): Don't try to determine the character
5553 position of the scroll margin if the window start point w->startp
e896f03c 5554 is outside the buffer's accessible region. (Bug#8468)
11997c76 5555
8a2cbd72
EZ
55562011-04-10 Eli Zaretskii <eliz@gnu.org>
5557
5558 Fix write-region and its subroutines for buffers > 2GB.
5559 * fileio.c (a_write, e_write): Modify declaration of arguments and
5560 local variables to support buffers larger than 2GB.
5561 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5562
5563 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5564 argument, local variables, and return value.
5565
5566 * lisp.h: Update prototypes of emacs_write and emacs_read.
5567
5568 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5569
4073e537 55702011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5571
1ebfdcb6
PE
5572 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5573
b2ded58d
PE
5574 Fix more problems found by GCC 4.6.0's static checks.
5575
7d66342c
PE
5576 * xdisp.c (vmessage): Use a better test for character truncation.
5577
bbf47d44
PE
5578 * charset.c (load_charset_map): <, not <=, for optimization,
5579 and to avoid potential problems with integer overflow.
9248994d 5580 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5581 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5582 * editfns.c (Fformat): Likewise.
1e69125e 5583 * syntax.c (skip_chars): Likewise.
3befa583 5584
e3019616
PE
5585 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5586 This also lets GCC 4.6.0 generate slightly better loop code.
5587
becfa255
PE
5588 * callint.c (Fcall_interactively): <, not <=, for optimization.
5589 (Fcall_interactively): Count the number of arguments produced,
5590 not the number of arguments given. This is simpler and lets GCC
5591 4.6.0 generate slightly better code.
5592
dae0cd48
PE
5593 * ftfont.c: Distingish more carefully between FcChar8 and char.
5594 The previous code passed unsigned char * to a functions like
5595 strlen and xstrcasecmp that expect char *, which does not
5596 conform to the C standard.
5597 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5598 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5599 char * when the C standard requires it.
5600
76032d70
PE
5601 * keyboard.c (read_char): Remove unused var.
5602
eb3f1cc8
PE
5603 * eval.c: Port to Windows vsnprintf (Bug#8435).
5604 Include <limits.h>.
5605 (SIZE_MAX): Define if the headers do not.
5606 (verror): Do not give up if vsnprintf returns a negative count.
5607 Instead, grow the buffer. This ports to Windows vsnprintf, which
5608 does not conform to C99. Problem reported by Eli Zaretskii.
5609 Also, simplify the allocation scheme, by avoiding the need for
5610 calling realloc, and removing the ALLOCATED variable.
5611
70476b54
PE
5612 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5613
12020a9e
PE
5614 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5615 But keep the doprint source code for now, as we might revamp it
5616 and use it again (Bug#8435).
ea6c7ae6
PE
5617 * lisp.h (doprnt): Remove.
5618 * Makefile.in (base_obj): Remove doprnt.o.
5619 * deps.mk (doprnt.o): Remove.
5620
5fdb398c
PE
5621 error: Print 32- and 64-bit integers portably (Bug#8435).
5622 Without this change, on typical 64-bit hosts error ("...%d...", N)
5623 was used to print both 32- and 64-bit integers N, which relied on
5624 undefined behavior.
5625 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5626 New macro.
5627 * lisp.h (error, verror): Mark as printf-like functions.
5628 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5629 Report overflow in size calculations when allocating printf buffer.
5630 Do not truncate output string at its first null byte.
5631 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5632 Truncate the output at a character boundary, since vsnprintf does not
5633 do that.
5634 * charset.c (check_iso_charset_parameter): Convert internal
5635 character to string before calling 'error', since %c now has the
5636 printf meaning.
5637 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5638 overflow when computing char to be passed to 'error'. Do not
5639 pass Lisp_Object to 'error'; pass the integer instead.
5640 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5641 formatted with plain %d.
5642
b189fa66
PE
5643 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5644
bff87ef0
PE
5645 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5646
7e2cac20
PE
5647 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5648
ce4d90b5
PE
5649 * xterm.c (x_catch_errors): Remove duplicate declaration.
5650
266c9547
PE
5651 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5652
79c49ad2
PE
5653 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5654
368f4090
JM
56552011-04-10 Jim Meyering <meyering@redhat.com>
5656
5657 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5658 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5659 return ssize_t not "int", and use size_t as the buffer length.
5660 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5661 * gnutls.h: Update declarations.
5662 * process.c (read_process_output): Use ssize_t, to match.
5663 (send_process): Likewise.
5664
a32d4040
CY
56652011-04-09 Chong Yidong <cyd@stupidchicken.com>
5666
5667 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5668
8546720e 56692011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5670
04f2d78b
CB
5671 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5672 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5673
8546720e
GM
5674 * xterm.c (handle_one_xevent):
5675 * xmenu.c (create_and_show_popup_menu):
5676 * xselect.c (x_decline_selection_request)
5677 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5678
0a2f5c1a 56792011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5680
5681 Fix some uses of `int' instead of EMACS_INT.
5682 * search.c (string_match_1, fast_string_match)
5683 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5684 (scan_buffer, find_next_newline_no_quit)
5685 (find_before_next_newline, search_command, Freplace_match)
5686 (Fmatch_data): Make some `int' variables be EMACS_INT.
5687
5688 * xdisp.c (display_count_lines): 3rd argument and return value now
5689 EMACS_INT. All callers changed.
5690 (pint2hrstr): Last argument is now EMACS_INT.
5691
5692 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5693 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5694 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5695 (decode_coding_utf_16, decode_coding_emacs_mule)
5696 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5697 (decode_coding_ccl, decode_coding_charset)
5698 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5699 (decode_coding_iso_2022, decode_coding_emacs_mule)
5700 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5701 <char_offset, last_offset>: Declare EMACS_INT.
5702 (encode_coding_utf_8, encode_coding_utf_16)
5703 (encode_coding_emacs_mule, encode_invocation_designation)
5704 (encode_designation_at_bol, encode_coding_iso_2022)
5705 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5706 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5707 Declare EMACS_INT.
5708 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5709 (encode_invocation_designation): Last argument P_NCHARS is now
5710 EMACS_INT.
5711 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5712 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5713
5714 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5715 All users changed.
5716
5717 * ccl.c (Fccl_execute_on_string): Declare some variables
5718 EMACS_INT.
5719
8546720e 57202011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5721
5722 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5723
4e19a977
CS
57242011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5725
5726 * process.c (Fformat_network_address): Doc fix.
5727
87302331
R
57282011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5729
5730 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5731
cbb59342
CY
57322011-04-08 Chong Yidong <cyd@stupidchicken.com>
5733
5734 * keyboard.c (read_char): Call Lisp function help-form-show,
5735 instead of using internal_with_output_to_temp_buffer.
5736 (Qhelp_form_show): New var.
e0d38eeb 5737 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5738
5739 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5740
5741 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5742
e67a13ab
CY
57432011-04-06 Chong Yidong <cyd@stupidchicken.com>
5744
04f2d78b
CB
5745 * process.c (Flist_processes): Remove to Lisp.
5746 (list_processes_1): Delete.
e67a13ab 5747
973f782d
EZ
57482011-04-06 Eli Zaretskii <eliz@gnu.org>
5749
7c106b1e
EZ
5750 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5751
973f782d
EZ
5752 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5753
41cf7d1a 57542011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5755
ca23cc88
PE
5756 Fix more problems found by GCC 4.6.0's static checks.
5757
f390e2d5
PE
5758 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5759
42eea0d0
PE
5760 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5761
b69769da 5762 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5763
f9541e84
PE
5764 * xdisp.c (vmessage): Mark as a printf-like function.
5765
13841b55
PE
5766 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5767
c136c10f
PE
5768 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5769
5e2d4a30
PE
5770 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5771 printf-like functions.
5772 (tiff_load): Add casts to remove these marks before passing them
5773 to system-supplied API.
5774
583f48b9
PE
5775 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5776
b25d760e
PE
5777 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5778 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5779 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5780 directly, rather than having caller test rule sign. This avoids
5781 some unnecessary tests.
5782 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5783 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5784 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5785
bc7b6697 5786 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5787 (xfont_open): Avoid unnecessary tests.
bc7b6697 5788
27ccc379
PE
5789 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5790
dcd5c89a
PE
5791 * composite.h, composite.c (composition_gstring_put_cache):
5792 Use EMACS_INT, not int, for length.
5793
b13a45c6
PE
5794 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5795 breaking out part of COMPOSITION_DECODE_RULE.
5796 (COMPOSITION_DECODE_RULE): Use it.
5797 * composite.c (get_composition_id): Remove unused local vars,
5798 by using the new macro.
5799
1e792e4d
PE
5800 * textprop.c (set_text_properties_1): Change while to do-while,
5801 since the condition is always true at first.
5802
dc6c6455 5803 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5804 (interval_deletion_adjustment): Return unsigned value.
5805 All uses changed.
dc6c6455 5806
aba7731a
PE
5807 * process.c (list_processes_1, create_pty, read_process_output):
5808 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5809 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5810 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5811 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5812 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5813
fdfc4bf3
PE
5814 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5815
fca8fe46 5816 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5817 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5818
06a0259a 5819 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5820 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5821 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5822
e7b9e80f
PE
5823 * print.c (print_error_message): Avoid int overflow.
5824
56201685
PE
5825 * font.c (font_list_entities): Redo for clarity,
5826 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5827
78834453 5828 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5829 (font_score): Avoid potential overflow in diff calculation.
78834453 5830
0bc0b309 5831 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5832 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5833
e610eaca
PE
5834 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5835
b895abce
PE
5836 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5837 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5838 can always succeed if overflow has undefined behavior.
5839
1f1d9321 5840 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5841 (wordify): Omit three unnecessary tests.
1f1d9321 5842
c59478bc
PE
5843 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5844 All callers changed. This avoids the need for an unused var.
5845
79b73827
PE
5846 * casefiddle.c (casify_region): Remove var that is set but not used.
5847
a4db5dfe
PE
5848 * dired.c (file_name_completion): Remove var that is set but not used.
5849
43aae36e
PE
5850 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5851
2a47c44d 5852 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5853 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5854
a37c69bf
PE
5855 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5856 Check for integer overflow on size calculations.
5857
328ab8e7
PE
5858 * buffer.c (Fprevious_overlay_change): Remove var that is set
5859 but not used.
5860
e5a2a5cb
PE
5861 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5862 Remove vars that are set but not used.
8d84a6eb 5863 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5864 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5865
a60e5f68
PE
5866 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5867
f661cb61 5868 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5869 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5870
f0397f5a
PE
5871 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5872 that are set but not used.
5873
8664db06 5874 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5875 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5876
6abdaa4a
PE
5877 * xselect.c (x_get_local_selection, x_handle_property_notify):
5878 Remove vars that are set but not used.
5879
0ce7538d 5880 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5881 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5882
9ae848fc
PE
5883 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5884 Remove var that is set but not used.
0b918413
PE
5885 (scroll_bar_windows_size): Now size_t, not int.
5886 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5887 Check for overflow.
9ae848fc 5888
a5a62657
PE
5889 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5890 (map_tty_color) [!defined MSDOS]: Likewise.
5891
5c5cdd39
PE
5892 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5893
66ebf983
PE
5894 * coding.c: Remove vars that are set but not used.
5895 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5896 All callers changed.
5897 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5898 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5899 (decode_coding_charset): Remove vars that are set but not used.
5900
1be4d761
PE
5901 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5902 that is set but not used.
5903
47553fa8
PE
5904 * print.c (print_object): Remove var that is set but not used.
5905
1f7196bf 5906 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5907 The gnulib version avoids calling malloc in the usual case,
5908 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5909 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5910 * filelock.c (current_lock_owner): Likewise.
5911 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5912 * sysdep.c: Include allocator.h, careadlinkat.h.
5913 (emacs_no_realloc_allocator): New static constant.
5914 (emacs_readlink): New function.
fdb61804
PE
5915 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5916 ../lib/careadlinkat.h.
d1fdcab7 5917
f84c17c7
SM
59182011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5919
5920 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5921 first non-nil return value).
5922
ef3862ad
JD
59232011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5924
5925 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5926 if not defined (Bug#8403).
5927
376a7006
JB
59282011-04-02 Juanma Barranquero <lekktu@gmail.com>
5929
5930 * xdisp.c (display_count_lines): Remove parameter `start',
5931 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5932 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5933 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5934 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5935 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5936 and thereabouts. All callers changed.
5937 (get_per_char_metric): Remove parameter `f', unused since
5938 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5939
6ca3801d
JM
59402011-04-02 Jim Meyering <meyering@redhat.com>
5941
5942 do not dereference NULL upon failed strdup
5943 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5944 (ns_get_family): Likewise.
5945
d8e2b5ba
JB
59462011-04-02 Juanma Barranquero <lekktu@gmail.com>
5947
5948 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5949
8c74fcbd
JD
59502011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5951
5952 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5953 later (Bug#8403).
5954
7200d79c
SM
59552011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5956
03408648 5957 Add lexical binding.
7200d79c 5958
03408648
SM
5959 * window.c (Ftemp_output_buffer_show): New fun.
5960 (Fsave_window_excursion):
5961 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5962
5963 * lread.c (lisp_file_lexically_bound_p): New function.
5964 (Fload): Bind Qlexical_binding.
5965 (readevalloop): Remove `evalfun' arg.
5966 Bind Qinternal_interpreter_environment.
5967 (Feval_buffer): Bind Qlexical_binding.
5968 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5969 Mark as dynamic.
5970 (syms_of_lread): Declare `lexical-binding'.
5971
5972 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5973
5974 * keyboard.c (eval_dyn): New fun.
5975 (menu_item_eval_property): Use it.
ca105506
SM
5976
5977 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5978
03408648
SM
5979 * fns.c (concat, mapcar1): Accept byte-code-functions.
5980
5981 * eval.c (Fsetq): Handle lexical vars.
5982 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5983 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5984 (FletX, Flet): Obey lexical binding.
5985 (Fcommandp): Handle closures.
5986 (Feval): New `lexical' arg.
5987 (eval_sub): New function extracted from Feval. Use it almost
5988 everywhere where Feval was used. Look up vars in lexical env.
5989 Handle closures.
5990 (Ffunctionp): Move from subr.el.
5991 (Ffuncall): Handle closures.
5992 (apply_lambda): Remove `eval_flags'.
5993 (funcall_lambda): Handle closures and new byte-code-functions.
5994 (Fspecial_variable_p): New function.
5995 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5996 but without exporting it to Lisp.
23aba0ea 5997
23aba0ea 5998 * doc.c (Fdocumentation, store_function_docstring):
03408648 5999 * data.c (Finteractive_form): Handle closures.
23aba0ea 6000
03408648
SM
6001 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6002 interactive spec.
ba83908c 6003
04f2d78b
CB
6004 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6005 New byte-codes.
03408648
SM
6006 (exec_byte_code): New function extracted from Fbyte_code to handle new
6007 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6008
03408648 6009 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6010
03408648 6011 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6012
e2abce01
JB
60132011-03-31 Juanma Barranquero <lekktu@gmail.com>
6014
6015 * xdisp.c (redisplay_internal): Fix prototype.
6016
63696a73 60172011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6018
63696a73 6019 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6020 (try_scrolling): Use it when setting scroll_limit.
6021 Limit scrolling to 100 screen lines.
63696a73
EZ
6022 (redisplay_window): Even when falling back on "recentering",
6023 position point in the window according to scroll-conservatively,
6024 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6025
6026 (try_scrolling): When point is above the window, allow searching
6027 as far as scroll_max, or one screenful, to compute vertical
6028 distance from PT to the scroll margin position. This prevents
6029 try_scrolling from unnecessarily failing when
6030 scroll-conservatively is set to a value slightly larger than the
6031 window height. Clean up the case of PT below the margin at bottom
6032 of window: scroll_max can no longer be INT_MAX. When aggressive
6033 scrolling is in use, don't let point enter the opposite scroll
6034 margin as result of the scroll.
6035 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6036 threshold of 100 lines for never-recentering scrolling.
6037
e4cc2dfc
JB
60382011-03-31 Juanma Barranquero <lekktu@gmail.com>
6039
6040 * dispextern.h (move_it_by_lines):
6041 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6042 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6043 (message_log_check_duplicate): Remove parameters `prev_bol' and
6044 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6045 (redisplay_internal): Remove parameter `preserve_echo_area',
6046 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6047
6048 * indent.c (Fvertical_motion):
6049 * window.c (window_scroll_pixel_based, Frecenter):
6050 Don't pass `need_y_p' to `move_it_by_lines'.
6051
1c470562
SM
60522011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6053
44f230aa
SM
6054 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6055 steal a few bits to be more compact.
6056 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6057 Remove unneeded casts.
6058
1c470562
SM
6059 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6060
888adce9
ZK
60612011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6062
6063 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6064 binding" message (bug#7967).
6065
f838ed7b
PE
60662011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6067
77861b95
PE
6068 Fix more problems found by GCC 4.6.0's static checks.
6069
de6dbc14
PE
6070 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6071 Remove unused local var.
6072
f838ed7b
PE
6073 * editfns.c (Fmessage_box): Remove unused local var.
6074
792c7b2b
PE
6075 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6076 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6077 Omit unused local vars.
c499e557 6078 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6079 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6080 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6081 Omit unused local var.
6082
ba0165e1
PE
6083 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6084 Don't assume string length fits in int.
32ad8845 6085 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6086 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6087
3c59b4c9
PE
6088 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6089 instead of alloca (Bug#8344).
6090
a3eed478 6091 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6092 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6093
eb4d412d
PE
6094 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6095
1658b401
PE
6096 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6097 concerns.
6098
6099 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6100
6101 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6102
9a2c6e05
PE
6103 * keyboard.c (syms_of_keyboard): Use the same style as later
6104 in this function when indexing through an array. This also
6105 works around GCC bug 48267.
6106
03d0a109
PE
6107 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6108
44f730c8
PE
6109 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6110
fe75f926
PE
6111 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6112 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6113
ffa8c828
PE
6114 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6115 This avoids undefined behavior on integer overflow, and is a bit
6116 more convenient anyway since it is compared to a size_t variable.
6117
c5101a77
PE
6118 Variadic C functions now count arguments with size_t, not int.
6119 This avoids an unnecessary limitation on 64-bit machines, which
6120 caused (substring ...) to crash on large vectors (Bug#8344).
6121 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6122 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6123 All variadic functions and their callers changed accordingly.
c5101a77
PE
6124 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6125 * data.c (arith_driver, float_arith_driver): Likewise.
6126 * editfns.c (general_insert_function): Likewise.
6127 * eval.c (struct backtrace.nargs, interactive_p)
6128 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6129 (funcall_lambda, mark_backtrace): Likewise.
6130 * fns.c (concat): Likewise.
6131 * frame.c (x_set_frame_parameters): Likewise.
6132 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6133 0 if not found, not -1. All callers changed.
6134
dd3f25f7
PE
6135 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6136 (stack_copy_size): Now size_t, not int.
6137 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6138
461c2ab9
JB
61392011-03-28 Juanma Barranquero <lekktu@gmail.com>
6140
6141 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6142 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6143 All callers changed.
6144
6145 * lisp.h (multibyte_char_to_unibyte):
6146 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6147 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6148 * character.h (CHAR_TO_BYTE8):
6149 * cmds.c (internal_self_insert):
6150 * editfns.c (general_insert_function):
6151 * keymap.c (push_key_description):
6152 * search.c (Freplace_match):
6153 * xdisp.c (message_dolog, set_message_1): All callers changed.
6154
f6d62986
SM
61552011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6156
6157 * keyboard.c (safe_run_hook_funcall): New function.
6158 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6159 don't set the hook to nil, but remove the offending function instead.
6160 (Qcommand_hook_internal): Remove, unused.
6161 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6162 Vcommand_hook_internal.
6163
6164 * eval.c (enum run_hooks_condition): Remove.
6165 (funcall_nil, funcall_not): New functions.
6166 (run_hook_with_args): Call each function through a `funcall' argument.
6167 Remove `cond' argument, now redundant.
6168 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6169 (Frun_hook_with_args_until_failure): Adjust accordingly.
6170 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6171
1db5b1ad
JB
61722011-03-28 Juanma Barranquero <lekktu@gmail.com>
6173
6174 * dispextern.h (string_buffer_position): Remove declaration.
6175
6176 * print.c (strout): Remove parameter `multibyte', unused since
6177 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6178
6179 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6180 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6181 All callers changed.
6182
6183 * w32.c (_wsa_errlist): Use braces for struct initializers.
6184
6185 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6186 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6187 All callers changed.
6188 (string_buffer_position): Likewise. Also, make static (it's never
6189 used outside xdisp.c).
6190 (cursor_row_p): Remove parameter `w', unused since
6191 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6192 (decode_mode_spec): Remove parameter `precision', introduced during
6193 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6194 All callers changed.
6195
5ffb62aa
JD
61962011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6197
6198 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6199
461c2ab9 62002011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6201
6202 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6203 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6204 (ns_update_auto_hide_menu_bar): New functions.
6205 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6206 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6207 ns_constrain_all_frames.
6208 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6209 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6210
5c380ffb
JD
62112011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6212
6213 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6214
9af30bdf
GM
62152011-03-27 Glenn Morris <rgm@gnu.org>
6216
6217 * syssignal.h: Replace RETSIGTYPE with void.
6218 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6219 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6220 Replace SIGTYPE with void everywhere.
6221 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6222 * s/template.h (SIGTYPE): Remove commented out definition.
6223
e2abce01
JB
62242011-03-26 Eli Zaretskii <eliz@gnu.org>
6225
6226 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6227 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6228
f868cd8a
JB
62292011-03-26 Juanma Barranquero <lekktu@gmail.com>
6230
59eb0929
JB
6231 * w32.c (read_unc_volume): Use parameter `henum', instead of
6232 global variable `wget_enum_handle'.
6233
6234 * keymap.c (describe_vector): Remove parameters `indices' and
6235 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6236 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6237
f868cd8a
JB
6238 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6239
6240 * keyboard.c (timer_check): Remove parameter `do_it_now',
6241 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6242 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6243 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6244
6245 * keyboard.c (read_char):
6246 * w32menu.c (w32_menu_display_help):
6247 * xmenu.c (show_help_event, menu_help_callback):
6248 Adjust calls to `show_help_echo'.
6249
6250 * gtkutil.c (xg_maybe_add_timer):
6251 * keyboard.c (readable_events):
6252 * process.c (wait_reading_process_output):
6253 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6254
6255 * insdel.c (adjust_markers_gap_motion):
6256 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6257 (gap_left, gap_right): Don't call it.
6258
2ecf6fdb
CY
62592011-03-25 Chong Yidong <cyd@stupidchicken.com>
6260
6261 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6262 incurred during fontification.
6263
6b1f9ba4
JB
62642011-03-25 Juanma Barranquero <lekktu@gmail.com>
6265
6266 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6267 (DEFVAR_PER_BUFFER): Don't pass it.
6268
6269 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6270 (scrolling_window): Don't pass it.
6271
0f4a96b5
JB
62722011-03-25 Juanma Barranquero <lekktu@gmail.com>
6273
6274 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6275
6276 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6277 and `suffix'.
6278 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6279 of variables specific to SELinux and computation of `encoded_absname'.
6280
6281 * image.c (XPutPixel): Remove unused variable `height'.
6282
6283 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6284
6285 * unexw32.c (get_section_info): Remove unused variable `section'.
6286
6287 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6288 (system_process_attributes): Remove unused variable `sess'.
6289 (sys_read): Remove unused variable `err'.
6290
6291 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6292 (w32_wnd_proc): Remove unused variable `isdead'.
6293 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6294 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6295 (x_create_tip_frame): Remove unused variable `tem'.
6296
6297 * w32inevt.c (w32_console_read_socket):
6298 Remove unused variable `no_events'.
6299
6300 * w32term.c (x_draw_composite_glyph_string_foreground):
6301 Remove unused variable `width'.
6302
1149507c
JB
63032011-03-24 Juanma Barranquero <lekktu@gmail.com>
6304
6305 * w32term.c (x_set_glyph_string_clipping):
6306 Don't pass uninitialized region to CombineRgn.
6307
9c88f339
JB
63082011-03-23 Juanma Barranquero <lekktu@gmail.com>
6309
6310 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6311 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6312 (Fx_close_connection): Remove unused variable `i'.
6313
6314 * w32font.c (w32font_draw): Return number of glyphs.
6315 (w32font_open_internal): Remove unused variable `i'.
6316 (w32font_driver): Add missing initializer.
6317
6318 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6319 (fill_in_menu): Remove unused variable `items_added'.
6320
6321 * w32term.c (last_mouse_press_frame): Remove static global variable.
6322 (w32_clip_to_row): Remove unused variable `f'.
6323 (x_delete_terminal): Remove unused variable `i'.
6324
6325 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6326 (NOTHING): Remove unused static global variable.
6327 (uniscribe_check_otf): Remove unused variable `table'.
6328 (uniscribe_font_driver): Add missing initializers.
6329
dee091a3
JD
63302011-03-23 Julien Danjou <julien@danjou.info>
6331
6332 * term.c (Fsuspend_tty, Fresume_tty):
6333 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6334 * window.c (temp_output_buffer_show):
6335 * insdel.c (signal_before_change):
6336 * frame.c (Fhandle_switch_frame):
6337 * fileio.c (Fdo_auto_save):
6338 * emacs.c (Fkill_emacs):
6339 * editfns.c (save_excursion_restore):
6340 * cmds.c (internal_self_insert):
6341 * callint.c (Fcall_interactively):
6342 * buffer.c (Fkill_all_local_variables):
6343 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6344 Use Frun_hooks.
0f4a96b5 6345 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6346 unconditionnaly since it does the check itself.
6347
2c520ab5 63482011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6349
c9c49752
PE
6350 Fix more problems found by GCC 4.5.2's static checks.
6351
8abc3f12
PE
6352 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6353 the first time through the loop, since we know p0 < p1 then.
6354 This also avoids a gcc -Wstrict-overflow warning.
6355
a2d26660
PE
6356 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6357 leading to a memory leak, possible in functions like
6358 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6359 of objects (Bug#8318).
a2d26660 6360
916c72e9
PE
6361 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6362 that could (at least in theory) be that large.
6363
19ab8a18
PE
6364 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6365 This is less likely to overflow, and avoids undefined behavior if
6366 overflow does occur. All callers changed. Use strtoul to scan
6367 for the unsigned long integer.
b7cbbd6f
PE
6368 (pint2hrstr): Simplify and tune code slightly.
6369 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6370
f0641eff
PE
6371 * scroll.c (do_scrolling): Work around GCC bug 48228.
6372 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6373
7f650bb9
PE
6374 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6375 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6376 (validate_x_resource_name): Simplify count usage.
6377 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6378
37dd57d1
PE
6379 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6380 fail (Bug#8306).
81e56e61 6381
699979fc 6382 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6383
401bf9b4
PE
6384 * process.c (Fmake_network_process): Use socklen_t, not int,
6385 where POSIX says socklen_t is required in portable programs.
6386 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6387 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6388 (Fmake_network_process, server_accept_connection):
6389 (wait_reading_process_output, read_process_output):
6390 Likewise.
6391
b93aacde
PE
6392 * process.c: Rename or move locals to avoid shadowing.
6393 (list_processes_1, Fmake_network_process):
6394 (read_process_output_error_handler, exec_sentinel_error_handler):
6395 Rename or move locals.
4dc343ee 6396 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6397 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6398 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6399 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6400 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6401
af8a867c 6402 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6403 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6404 Include tparam.h instead, since it declares them.
af8a867c
PE
6405 * cm.h (PC): Remove extern decl; tparam.h now does this.
6406 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6407 * terminfo.c: Include tparam.h, to check interfaces.
6408 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6409 (tparam): Adjust signature to match interface in tparam.h;
6410 this removes some undefined behavior. Check that outstring and len
6411 are zero, which they always are with Emacs.
6412 * tparam.h (PC, BC, UP): New extern decls.
6413
0248044d 6414 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6415 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6416
8ff096c1 6417 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6418 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6419 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6420 (ftfont_list): Remove unused local.
49eaafba
PE
6421 (get_adstyle_property, ftfont_pattern_entity):
6422 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6423 Rename locals to avoid shadowing.
8ff096c1 6424
e2be39f6
PE
6425 * xfont.c (xfont_list_family): Mark var as initialized.
6426
c9735e30
PE
6427 * xml.c (make_dom): Now static.
6428
8f5201ae
PE
6429 * composite.c (composition_compute_stop_pos): Rename local to
6430 avoid shadowing.
b246f932
PE
6431 (composition_reseat_it): Remove unused locals.
6432 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6433 (composition_update_it): Mark var as initialized.
11b61122
PE
6434 (find_automatic_composition): Mark vars as initialized,
6435 with a FIXME (Bug#8290).
8f5201ae 6436
760fbc2c
PE
6437 character.h: Rename locals to avoid shadowing.
6438 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6439 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6440 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6441 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6442 to avoid shadowing.
6443
ff08eb85
PE
6444 * textprop.c (property_change_between_p): Remove; unused.
6445
fc7bf025
PE
6446 * intervals.c (interval_start_pos): Now static.
6447
235d7abc
PE
6448 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6449
44f230aa
SM
6450 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6451 Rename locals to avoid shadowing.
3e7d6594 6452
50060332
PE
6453 * sound.c (wav_play, au_play, Fplay_sound_internal):
6454 Fix pointer signedness.
d01f234b 6455 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6456 (wav_play): Initialize a variable to 0, to prevent undefined
6457 behavior (Bug#8278).
50060332 6458
c4fc4e30
PE
6459 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6460
918436ed
PE
6461 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6462
c939f91b
PE
6463 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6464 clobbering (Bug#8298).
b9c7f648
PE
6465 * sysdep.c (sys_subshell): Likewise.
6466 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6467
6bd8c144
PE
6468 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6469 This should get cleaned up, so that child_setup has the
6470 same signature on all platforms.
6471
7710357c 6472 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6473 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6474
c59da222
CY
64752011-03-22 Chong Yidong <cyd@stupidchicken.com>
6476
6477 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6478 not to be necessary, and produces flickering.
6479
66b87493
GM
64802011-03-20 Glenn Morris <rgm@gnu.org>
6481
6482 * config.in: Remove file.
6483
45b6f6d5
JB
64842011-03-20 Juanma Barranquero <lekktu@gmail.com>
6485
6486 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6487 are now in src/globals.h.
6488 (syms_of_minibuf): Remove spurious & from previous change.
6489
3ec03f7e
LL
64902011-03-20 Leo <sdl.web@gmail.com>
6491
6492 * minibuf.c (completing-read-function): New variable.
6493 (completing-read-default): Rename from completing-read.
6494 (completing-read): Call completing-read-function.
6495
b14e3e21
CY
64962011-03-19 Juanma Barranquero <lekktu@gmail.com>
6497
6498 * xfaces.c (Fx_load_color_file):
6499 Read color file from absolute filename (bug#8250).
6500
f2b726e6
JB
65012011-03-19 Juanma Barranquero <lekktu@gmail.com>
6502
6503 * makefile.w32-in: Update dependencies.
6504
09f6ff02
EZ
65052011-03-17 Eli Zaretskii <eliz@gnu.org>
6506
6507 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6508
29a6015a
PE
65092011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6510
a3a6c54e
PE
6511 Fix more problems found by GCC 4.5.2's static checks.
6512
b766f867
PE
6513 * process.c (make_serial_process_unwind, send_process_trap):
6514 (sigchld_handler): Now static.
6515
be02381c
PE
6516 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6517 That way, the code declares only the vars that it needs.
6518 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6519 * s/cygwin.h (PTY_ITERATION): Likewise.
6520 * s/darwin.h (PTY_ITERATION): Likewise.
6521 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6522
57048744
PE
6523 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6524 * process.c (allocate_pty): Don't declare stb unless it's needed.
6525
7914961c 6526 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6527 (CONSTANTLIM): Remove; unused.
6528 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6529 Define only if needed.
7914961c 6530
b3967b18
PE
6531 * unexelf.c (unexec): Name an expression,
6532 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6533 Use a different way to cause a compilation error if anyone uses
6534 n rather than nn, a way that does not involve shadowing.
73366a00 6535 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6536
29a6015a
PE
6537 * deps.mk (unexalpha.o): Remove; unused.
6538
43cfc33e 6539 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6540 * unexec.h: New file.
ce701a33
PE
6541 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6542 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6543 Depend on unexec.h.
6544 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6545 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6546 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6547 Change as necessary to match prototype in unexec.h.
ce701a33 6548
01f44d5a
PE
6549 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6550 shadowing.
4f63c6bb 6551 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6552
a6670b0b
PE
6553 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6554 Rename locals to avoid shadowing.
6555
cef2010d 6556 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6557 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6558
d4d7173a
PE
6559 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6560
f08b802a
PE
6561 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6562 warning when compiling print.c.
6563
3ddb0639
PE
6564 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6565 instead of using an uninitialized var.
5ad03b97 6566 (font_sort_entities): Mark var as initialized.
3ddb0639 6567
170a2692
PE
6568 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6569
e663c700
PE
6570 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6571 pointers to constants.
89bc529a 6572 (font_parse_fcname): Remove unused vars.
7b81e2d0 6573 (font_delete_unmatched): Now static.
ea838e10 6574 (font_get_spec): Remove; unused.
13a547c6
PE
6575 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6576 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6577 Rename or move locals to avoid shadowing.
e663c700 6578
2a80c887 6579 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6580 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6581
1384fa33 6582 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6583 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6584
8b2c52e9
PE
6585 * alloc.c (mark_backtrace): Move decl from here ...
6586 * lisp.h: ... to here, so that it can be checked.
6587
475545b5 6588 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6589 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6590 (lisp_indirect_variable): Name an expression,
6591 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6592 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6593
b1349114 6594 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6595 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6596 Use const pointer when appropriate.
b1349114 6597
a2928364
PE
6598 * lisp.h (get_system_name, get_operating_system_release):
6599 Move decls here, to check interfaces.
6600 * process.c (get_operating_system_release): Move decl to lisp.h.
6601 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6602 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6603 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6604 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6605 (Fformat_time_string, Fencode_time, Finsert_char):
6606 (Ftranslate_region_internal, Fformat):
6607 Rename or remove local vars to avoid shadowing.
9710023e 6608 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6609
a415e694
PE
6610 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6611 avoid shadowing.
6612
8ef4622d
PE
6613 * lisp.h (eassert): Check that the argument compiles, even if
6614 ENABLE_CHECKING is not defined.
6615
946f9a5b
PE
6616 * data.c (Findirect_variable): Name an expression, to avoid
6617 gcc -Wbad-function-cast warning.
112396d6 6618 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6619 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6620 (Fmake_variable_buffer_local, Fmake_local_variable):
6621 Mark variables as initialized.
52746918 6622 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6623
e5aab7e7 6624 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6625 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6626 Rename locals to avoid shadowing.
dff45157
PE
6627 (mark_stack): Move local variables into the #ifdef region where
6628 they're used.
7bc26fdb
PE
6629 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6630 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6631 needed otherwise.
6632 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6633 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6634 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6635
e5aab7e7
PE
6636 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6637 avoids undefined behavior in theory.
6638
4da60324
PE
6639 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6640
88043301
PE
6641 Use functions, not macros, for up- and down-casing (Bug#8254).
6642 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6643 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6644 to use the following functions instead of these macros.
6645 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6646 EMACS_INT, since callers assume the returned value fits in int.
6647 (upcase1): Likewise, for UPCASE_TABLE.
6648 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6649 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6650 the race-condition problem in the old DOWNCASE.
88043301 6651
19ed5445
PE
6652 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6653 Rename locals to avoid shadowing.
6654 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6655 (regex_compile, re_search_2, re_match_2_internal):
6656 Remove unused local vars.
952db0d7
PE
6657 (FREE_VAR): Rewrite so as not to use empty "else",
6658 which gcc can warn about.
da053e48 6659 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6660 (RETALLOC_IF): Define only if needed.
6661 (WORDCHAR_P): Likewise. This one is never needed, but is used
6662 only in a comment talking about a compiler bug, so put inside
6663 the #if 0 of that comment.
6664 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6665 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6666 Remove; unused.
19ed5445 6667
1f3561e4 6668 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6669 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6670 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6671
ded6f8f7
PE
6672 * search.c (simple_search): Remove unused var.
6673
dbd37a95
PE
6674 * dired.c (compile_pattern): Move decl from here ...
6675 * lisp.h: ... to here, so that it can be checked.
6676 (struct re_registers): New forward decl.
6677
7e47afad
PE
6678 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6679
85f24f61
PE
6680 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6681 All uses changed.
6682 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6683 Rename locals to avoid shadowing.
5671df8f 6684 (Fvertical_motion): Mark locals as initialized.
85f24f61 6685
181aa2be 6686 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6687 (casify_region): Mark local as initialized.
181aa2be 6688
930d429c
PE
6689 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6690
7082eac6
PE
6691 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6692 New macros, so that the caller can use some names other than
6693 gcpro1, gcpro2, etc.
6694 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6695 of the new macros.
6696 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6697 argument, for consistency with GCPRO2_VAR, etc: it is now the
6698 prefix of the variable, not the variable itself. All uses
6699 changed.
38b2c076
PE
6700 * dired.c (directory_files_internal, file_name_completion):
6701 Rename locals to avoid shadowing.
6702
15206ed9
PE
6703 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6704 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6705 dired.c's scmp function, had undefined behavior.
6706 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6707 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6708 * buffer.h: ... to here, because these macros use current_buffer,
6709 and the new implementation with inline functions needs to have
6710 current_buffer in scope now, rather than later when the macros
6711 are used.
6712 (downcase, upcase1): New static inline functions.
6713 (DOWNCASE, UPCASE1): Reimplement using these functions.
6714 This avoids undefined behavior in expressions like
6715 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6716 from race conditions in accessing the global variables
6717 case_temp1 and case_temp2.
6718 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6719 * lisp.h (case_temp1, case_temp2): Remove their decls.
6720 * character.h (ASCII_CHAR_P): Move from here ...
6721 * lisp.h: ... to here, so that the inline functions mentioned
6722 above can use them.
6723
4a6bea26
PE
6724 * dired.c (directory_files_internal_unwind): Now static.
6725
f14b7e14
PE
6726 * fileio.c (file_name_as_directory, directory_file_name):
6727 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6728 Now static.
2893f146
PE
6729 (file_name_as_directory): Use const pointers when appropriate.
6730 (Fexpand_file_name): Likewise. In particular, newdir might
6731 point at constant storage, so make it a const pointer.
fd4ead52 6732 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6733 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6734 signedness issues.
f839df0c
PE
6735 (Fset_file_times, Finsert_file_contents, auto_save_error):
6736 Rename locals to avoid shadowing.
f14b7e14 6737
5716756e 6738 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6739 (Ftry_completion, Fall_completions): Rename or remove locals
6740 to avoid shadowing.
5716756e 6741
b4c3046a
PE
6742 * marker.c (bytepos_to_charpos): Remove; unused.
6743
b45db522
PE
6744 * lisp.h (verify_bytepos, count_markers): New decls,
6745 so that gcc does not warn that these functions aren't declared.
6746
85876d07
PE
6747 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6748 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6749 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6750 (copy_text): Remove unused local var.
85876d07 6751
03d78a21 6752 * filelock.c (within_one_second): Now static.
b3dd38ab 6753 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6754
5df8f01b
PE
6755 * buffer.c (fix_overlays_before): Mark locals as initialized.
6756 (fix_start_end_in_overlays): Likewise. This function should be
6757 simplified by using pointers-to-pointers, but that's a different
6758 matter.
b1d876f1 6759 (switch_to_buffer_1): Now static.
8f54f30a
PE
6760 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6761 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6762
a70072c9 6763 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6764 Fix pointer signedness issue.
edced198
PE
6765 (sys_subshell): Mark local as volatile if checking for lint,
6766 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6767 (MAXPATHLEN): Define only if needed.
a70072c9 6768
a0977c44
PE
6769 * process.c (serial_open, serial_configure): Move decls from here ...
6770 * systty.h: ... to here, so that they can be checked.
6771
a884fdcc
PE
6772 * fns.c (get_random, seed_random): Move extern decls from here ...
6773 * lisp.h: ... to here, so that they can be checked.
6774
604efe86 6775 * sysdep.c (reset_io): Now static.
b8950c94 6776 (wait_for_termination_signal): Remove; unused.
604efe86 6777
38fc62d9
PE
6778 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6779 (copy_keymap_item, append_key, push_text_char_description):
6780 Now static.
1004a21a 6781 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6782 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6783 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6784 (describe_map_tree):
6785 Rename locals to avoid shadowing.
38fc62d9 6786
2f2650da
PE
6787 * keyboard.c: Declare functions static if they are not used elsewhere.
6788 (echo_char, echo_dash, cmd_error, top_level_2):
6789 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6790 (read_char, kbd_buffer_get_event, make_lispy_position):
6791 (make_lispy_event, make_lispy_movement, apply_modifiers):
6792 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6793 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6794 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6795 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6796 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6797
a053e86c 6798 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6799 (mark_kboards): Move decl here ...
6800 * alloc.c (mark_kboards): ... from here.
a053e86c 6801
4752793e
PE
6802 * lisp.h (force_auto_save_soon): New decl.
6803
74f10ca7 6804 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6805 (DEFINE_DUMMY_FUNCTION): New macro.
6806 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6807 Use it.
c03cd23f
PE
6808 (main): Add casts to avoid warnings
6809 if GCC considers string literals to be constants.
74f10ca7 6810
022e70d4
PE
6811 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6812
59d6fe83
PE
6813 * dbusbind.c: Pointer signedness fixes.
6814 (xd_signature, xd_append_arg, xd_initialize):
6815 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6816 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6817 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6818 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6819
78320123
PE
6820 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6821 if GCC considers string literals to be constants.
49cebcca 6822 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6823
35ac2a97
SM
68242011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6825
fb103ca9
SM
6826 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6827 (print_preprocess, print_object): New macro to fix last change.
6828
35ac2a97
SM
6829 * print.c (print_preprocess): Don't forget font objects.
6830
62973b41
JB
68312011-03-16 Juanma Barranquero <lekktu@gmail.com>
6832
6833 * emacs.c (USAGE3): Doc fixes.
6834
0e48bb22
AS
68352011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6836
6837 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6838 structure.
6839
7684e57b
JB
68402011-03-14 Juanma Barranquero <lekktu@gmail.com>
6841
6842 * lisp.h (VWindow_system, Qfile_name_history):
6843 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6844 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6845 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6846
6847 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6848 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6849
6850 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6851 * w32console.c (detect_input_pending, read_input_pending)
6852 (encode_terminal_code):
6853 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6854 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6855 (w32_system_caret_y, Qfile_name_history):
6856 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6857 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6858 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6859 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6860 * w32proc.c (Qlocal, report_file_error):
6861 * w32term.c (Vwindow_system, updating_frame):
6862 * w32uniscribe.c (initialized, uniscribe_font_driver):
6863 Remove unneeded extern declarations.
6864
2aa46d6c
CY
68652011-03-14 Chong Yidong <cyd@stupidchicken.com>
6866
c96bbc66 6867 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6868
cffc6f3b
CY
68692011-03-13 Chong Yidong <cyd@stupidchicken.com>
6870
6871 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6872 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6873 These macros can no longer be used for assignment.
6874
44f230aa
SM
6875 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6876 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6877 (record_buffer_markers, fetch_buffer_markers): New functions for
6878 recording and fetching special buffer markers.
6879 (set_buffer_internal_1, set_buffer_temp): Use them.
6880
6881 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6882
6883 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6884
6885 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6886 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6887
6888 * xdisp.c (hscroll_window_tree):
6889 (reconsider_clip_changes): Use PT instead of BUF_PT.
6890
d251f04b
EZ
68912011-03-13 Eli Zaretskii <eliz@gnu.org>
6892
6893 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6894 $(EMACS_ROOT)/lib/intprops.h.
6895
f0c77cd1
PE
68962011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6897
3eca4629
PE
6898 Fix more problems found by GCC 4.5.2's static checks.
6899
7c86ee98
PE
6900 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6901 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6902 (xg_free_frame_widgets): Make it clear that a local variable is
6903 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6904 (gdk_window_get_screen): Make it clear that this macro is needed
6905 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6906 (int_gtk_range_get_value): New function, which avoids a diagnostic
6907 from gcc -Wbad-function-cast.
6908 (xg_set_toolkit_scroll_bar_thumb): Use it.
6909 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6910 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6911 (get_utf8_string, xg_get_file_with_chooser):
6912 Rename locals to avoid shadowing.
6913 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6914
41729b81
PE
6915 * xgselect.c (xg_select): Remove unused var.
6916
f0c77cd1
PE
6917 * image.c (four_corners_best): Mark locals as initialized.
6918 (gif_load): Initialize transparent_p to zero (Bug#8238).
6919 Mark another local as initialized.
ec6cf4c6 6920 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6921
ce0ad53d 6922 * image.c (clear_image_cache): Now static.
d5d5a617 6923 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6924 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6925 (x_edge_detection): Remove unnecessary cast that
6926 gcc -Wbad-function-cast diagnoses.
2037898d 6927 (gif_load): Fix pointer signedness.
6ae141d6
PE
6928 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6929 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6930
33383987 69312011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6932
d32df629
PE
6933 Improve quality of tests for time stamp overflow.
6934 For example, without this patch (encode-time 0 0 0 1 1
6935 1152921504606846976) returns the obviously-bogus value (-948597
6936 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6937 reports time overflow. See
6938 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6939 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6940 * editfns.c: Include limits.h and intprops.h.
6941 (TIME_T_MIN, TIME_T_MAX): New macros.
6942 (time_overflow): Move earlier, to before first use.
6943 (hi_time, lo_time): New functions, for an accurate test for
6944 out-of-range times.
6945 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6946 (Fget_internal_run_time): Don't assume time_t fits in int.
6947 (make_time): Use list2 instead of Fcons twice.
6948 (Fdecode_time): More accurate test for out-of-range times.
6949 (check_tm_member): New function.
6950 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6951 (lisp_time_argument): Don't rely on undefined left-shift and
6952 right-shift behavior when checking for time stamp overflow.
8be6f318 6953
fe31d94c
PE
6954 * editfns.c (time_overflow): New function, refactoring common code.
6955 (Fformat_time_string, Fdecode_time, Fencode_time):
6956 (Fcurrent_time_string): Use it.
6957
8be6f318
PE
6958 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6959 * dired.c (make_time): Move to ...
6960 * editfns.c (make_time): ... here.
6961 * systime.h: Note the move.
6962
09d9db2c 69632011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6964
126bc0dc
YM
6965 * fringe.c (update_window_fringes): Remove unused variables.
6966
c47cbdfd
YM
6967 * unexmacosx.c (copy_data_segment): Also copy __got section.
6968 (Bug#8223)
6969
7ac80be9
EZ
69702011-03-12 Eli Zaretskii <eliz@gnu.org>
6971
c96bbc66 6972 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6973 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6974 Constify `char *' arguments and their references according to
6975 prototypes in tparam.h.
6976
ecb0f94d 6977 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6978
7ac80be9
EZ
6979 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6980 Adapt all references accordingly.
6981
6982 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6983
ef1fd07e
TT
69842011-03-11 Tom Tromey <tromey@redhat.com>
6985
6986 * buffer.c (syms_of_buffer): Remove obsolete comment.
6987
7ef4b50c
EZ
69882011-03-11 Eli Zaretskii <eliz@gnu.org>
6989
6990 * termhooks.h (encode_terminal_code): Declare prototype.
6991
6992 * msdos.c (encode_terminal_code): Don't declare prototype.
6993
6994 * term.c (encode_terminal_code): Now external again, used by
6995 w32console.c and msdos.c.
6996
44f230aa
SM
6997 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6998 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6999
4b1ec863 70002011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7001
1714f52b 7002 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7003
4b1ec863
PE
7004 * fringe.c (update_window_fringes): Mark locals as initialized
7005 (Bug#8227).
7006 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7007
524c7aa6
PE
7008 * alloc.c (mark_fringe_data): Move decl from here ...
7009 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7010 to check its interface.
7011 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7012
a5c0af81 7013 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7014 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7015 (fontset_font): Mark local as initialized.
a9a06e0b 7016 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7017
b4716021
PE
7018 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7019
811e9bac 7020 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7021 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7022 (x_own_selection, Fx_disown_selection_internal): Rename locals
7023 to avoid shadowing.
7024 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7025
7e3ab302
PE
7026 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7027 so that the caller can use some name other than gcpro1.
7028 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7029 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7030 (Fx_backspace_delete_keys_p):
7031 Use them to avoid shadowing, and rename vars to avoid shadowing.
7032 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7033 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7034 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7035 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7036 Remove unused locals.
7e3ab302
PE
7037 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7038 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7039 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7040 macros.
f78faa98 7041
e2b13473
PE
7042 * xterm.h (x_mouse_leave): New decl.
7043
77f23912
PE
7044 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7045 Remove unused functions.
cdf4ba58
PE
7046 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7047 (x_calc_absolute_position): Now static.
7411c686 7048 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7049 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7050 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7051 unless they are used.
38d0b34a
PE
7052 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7053 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7054 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7055 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7056 (x_error_catcher, x_connection_closed, x_error_handler):
7057 (x_error_quitter, xembed_send_message, x_iconify_frame):
7058 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7059 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7060 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7061
44f230aa
SM
7062 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7063 Rename or move locals to avoid shadowing.
6b463e58 7064 (tty_defined_color, merge_face_heights): Now static.
5967d051 7065 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7066 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7067 does not deduce is never used uninitialized.
73719eba
PE
7068 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7069 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7070
426994c3 7071 * terminal.c (store_terminal_param): Now static.
5489860b 7072
032f1620 7073 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7074 (set_frame_menubar): Remove unused local.
d4323972 7075 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7076 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7077 since they might point to immutable storage.
281585b0
PE
7078 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7079 since it's unused otherwise.
032f1620 7080
367c19e5 7081 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7082 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7083 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7084 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7085 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7086 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7087 does not deduce are never used uninitialized.
70739cbe 7088
07b48fa9
PE
7089 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7090
8868a238 7091 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7092 * window.c (window_loop, size_window):
7093 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7094
7e5cf297 7095 * window.c (display_buffer): Now static.
d6550a9f
PE
7096 (size_window): Mark variables that gcc -Wuninitialized
7097 does not deduce are never used uninitialized.
a586633d
PE
7098 * window.h (check_all_windows): New decl, to forestall
7099 gcc -Wmissing-prototypes diagnostic.
5b555da1 7100 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7101
f6095868
PE
7102 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7103 shadowing.
7104 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7105 Include <limits.h>.
7106 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7107 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7108 (load_charset_map): Mark variables that gcc -Wuninitialized
7109 does not deduce are never used uninitialized.
53df7c11 7110 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7111
f38b440c
PE
7112 * coding.c (coding_set_source, coding_set_destination):
7113 Use "else { /* comment */ }" rather than "else /* comment */;"
7114 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7115 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7116 a block, when the outer 'i' will do.
7117 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7118 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7119 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7120 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7121 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7122 Rename locals to avoid shadowing.
7123 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7124 * coding.c (emacs_mule_char, encode_invocation_designation):
7125 Now static, since they're not used elsewhere.
413bb2db 7126 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7127 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7128 (decode_coding_emacs_mule): Mark variables that gcc
7129 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7130 (detect_coding_iso_2022): Initialize a local variable that might
7131 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7132 this initialization is needed. (Bug#8211)
5f58e762
PE
7133 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7134 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7135 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7136 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7137 Remove unused macros.
f38b440c 7138
232b38b9 7139 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7140 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7141 * character.c (string_count_byte8): Likewise.
232b38b9 7142
fb90da1b
PE
7143 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7144 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7145
fb93dbc2
PE
7146 * chartab.c (copy_sub_char_table): Now static, since it's not used
7147 elsewhere.
5c156ace
PE
7148 (sub_char_table_ref_and_range, char_table_ref_and_range):
7149 Rename locals to avoid shadowing.
bbcd0949 7150 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7151
7d3b3862 7152 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7153 (BIDI_BOB): Remove unused macro.
7d3b3862 7154
6be7d3da
PE
7155 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7156 deduce are never used uninitialized.
c2ed9c8b 7157 * term.c (encode_terminal_code): Likewise.
6be7d3da 7158
75f8807f 7159 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7160
50938595
PE
7161 * tparam.h: New file.
7162 * term.c, tparam.h: Include it.
7163 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7164 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7165 Move these decls to tparam.h, and make them agree with what
7166 is actually in tparam.c. The previous trick of using incompatible
7167 decls in different modules does not conform to the C standard.
7168 All callers of tparam changed to use tparam's actual API.
7169 * tparam.c (tparam1, tparam, tgoto):
7170 Use const pointers where appropriate.
7171
fbceeba2
PE
7172 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7173 * cm.h (struct cm): Likewise.
7174 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7175 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7176 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7177 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7178 (turn_on_face, init_tty): Likewise.
7179 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7180
7f3f1250
PE
7181 * term.c (term_mouse_position): Rename local to avoid shadowing.
7182
e6ca6543
PE
7183 * alloc.c (mark_ttys): Move decl from here ...
7184 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7185
c40f8d15
AS
71862011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7187
7188 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7189
cfe0661d
JB
71902011-03-09 Juanma Barranquero <lekktu@gmail.com>
7191
7192 * search.c (compile_pattern_1): Remove argument regp, unused since
7193 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7194 (compile_pattern): Don't pass it.
7195
0afb4571
J
71962011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7197
7198 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7199 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7200 for ! HAVE_GTK3.
7201 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7202
7203 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7204
7205 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7206 gdk_window_get_screen, gdk_window_get_geometry,
7207 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7208 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7209 (xg_get_pixbuf_from_pixmap): New function.
7210 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7211 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7212 Call xg_get_pixbuf_from_pixmap instead of
7213 gdk_pixbuf_get_from_drawable.
7214 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7215 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7216 (xg_check_special_colors): Use GtkStyleContext and its functions
7217 for HAVE_GTK3.
7218 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7219 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7220 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7221 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7222 Call gtk_widget_get_preferred_size.
0afb4571
J
7223 (xg_frame_resized): gdk_window_get_geometry only takes 5
7224 parameters.
44f230aa
SM
7225 (xg_win_to_widget, xg_event_is_for_menubar):
7226 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7227 (xg_set_widget_bg): New function.
7228 (delete_cb): New function.
895009e1 7229 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7230 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7231 (xg_set_background_color): Call xg_set_widget_bg.
7232 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7233 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7234 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7235 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7236 if ! HAVE_GTK3.
7237 (update_frame_tool_bar): Call gtk_widget_hide.
7238 (xg_initialize): Use GDK_KEY_g.
7239
7240 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7241 if ! HAVE_GTK3
7242 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7243
7244 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7245 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7246 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7247
1c2cc4ef
JB
72482011-03-08 Juanma Barranquero <lekktu@gmail.com>
7249
7250 * w32xfns.c (select_palette): Check success of RealizePalette against
7251 GDI_ERROR, not zero.
7252
33383987 7253See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7254
7255;; Local Variables:
7256;; coding: utf-8
aac0c6e3
MR
7257;; End:
7258
33383987 7259 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7260
7261 This file is part of GNU Emacs.
7262
7263 GNU Emacs is free software: you can redistribute it and/or modify
7264 it under the terms of the GNU General Public License as published by
7265 the Free Software Foundation, either version 3 of the License, or
7266 (at your option) any later version.
7267
7268 GNU Emacs is distributed in the hope that it will be useful,
7269 but WITHOUT ANY WARRANTY; without even the implied warranty of
7270 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7271 GNU General Public License for more details.
7272
7273 You should have received a copy of the GNU General Public License
7274 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.