Remove HAVE_SYSINFO from nt/config.nt, followup to 2012-05-28T00:46:33Z!eggert@cs...
[bpt/emacs.git] / src / ChangeLog
CommitLineData
da92a98c
PE
12012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2
3 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
4 This avoids undefined behavior that might cause the eassert
5 to not catch an out-of-range value.
6
74d1f848
JB
72012-05-28 Juanma Barranquero <lekktu@gmail.com>
8
9 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
10 Update dependencies.
11
9e1a06fc
EZ
122012-05-27 Eli Zaretskii <eliz@gnu.org>
13
14 * bidi.c (bidi_mirror_char): Fix last change.
15
f3dd7312
AS
162012-05-27 Andreas Schwab <schwab@linux-m68k.org>
17
18 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
19 when referring to sectname field in printf format.
20
81899c91
PE
212012-05-27 Paul Eggert <eggert@cs.ucla.edu>
22
57b81a9f
PE
23 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
24 Only r_alloc_inhibit_buffer_relocation needed to be added;
25 the others were already declared.
26
81899c91
PE
27 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
28 before checking whether it's out of range. Put the check inside
29 eassert. See
30 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
31
33017faf 322012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
33
34 * callproc.c (Fcall_process): Restore a line that was accidentally
35 commented out in the 2011-02-13 change (bug#11547).
36
33017faf 372012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
38
39 * lisp.h [REL_ALLOC]: Add prototypes for external functions
40 defined on ralloc.c.
41
42 * buffer.c [REL_ALLOC]: Remove prototypes of
43 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
44 they are now on lisp.h.
45
46 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
47
48 * search.c (search_buffer): Use it to inhibit relocation of buffer
49 text while re_search_2 is doing its job, because re_search_2 is
50 passed C pointers to buffer text. (Bug#11519)
51
23415acf
EZ
52 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
53 Update value to 24.
54
44e27368
EZ
55 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
56 state after an additional call to move_it_in_display_line_to, keep
57 the values of it->max_ascent and it->max_descent found for the
58 entire line.
59 (pos_visible_p): Revert the comparison against bottom_y to what it
60 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
61 (Bug#11464)
62
c1892f11
PE
632012-05-26 Paul Eggert <eggert@cs.ucla.edu>
64
65 Fix coding-related core dumps with gcc -ftrapv.
66 The code was computing A - B, where A and B are pointers, and B is
67 random garbage. This can lead to core dumps on platforms that
68 have special pointer registers, and it also leads to core dumps on
69 x86-64 when compiled with gcc -ftrapv. The fix is to compute
70 A - B only when B is initialized properly.
71 * coding.c (coding_set_source, coding_set_destination): Return void.
72 (coding_change_source, coding_change_destinations): New functions,
73 with the old behaviors of coding_set_source and coding_set_destination.
74 All callers that need an offset changed to use these new functions.
75
eb7afdad
GM
762012-05-26 Glenn Morris <rgm@gnu.org>
77
78 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
79
f12fdf02
EZ
802012-05-26 Eli Zaretskii <eliz@gnu.org>
81
53a63be6 82 Extend mouse support on W32 text-mode console.
eb3f6f01
EZ
83 * xdisp.c (draw_row_with_mouse_face): Call
84 tty_draw_row_with_mouse_face for WINDOWSNT as well.
85
eb3f6f01
EZ
86 * w32console.c: Include window.h.
87 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face): New
88 functions.
89 (initialize_w32_display): Initialize mouse-highlight data.
90
53a63be6
EZ
91 * w32inevt.c: Include termchar.h and window.h.
92 (do_mouse_event): Support mouse-autoselect-window. When the mouse
93 moves, call note_mouse_highlight. If help_echo changed, call
94 gen_help_event to produce help-echo message in the echo area.
95 Call clear_mouse_face if mouse_face_hidden is set in the mouse
96 highlight info.
97
4cfd81f6
PE
982012-05-26 Paul Eggert <eggert@cs.ucla.edu>
99
100 * lread.c (read1): Simplify slightly to avoid an overflow warning
101 with GCC 4.7.0 on x86-64.
102
4446092a
EZ
1032012-05-26 Eli Zaretskii <eliz@gnu.org>
104
105 * bidi.c (bidi_mirror_char): Revert last change: an int is
106 definitely wide enough here.
107
42b2a986 1082012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 109
42b2a986 110 Fix integer width and related bugs (Bug#9874).
eb106a49 111 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
112 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
113 (string_bytes, check_sblock, allocate_string_data):
114 (compact_small_strings, Fmake_bool_vector, make_string)
115 (make_unibyte_string, make_multibyte_string)
116 (make_string_from_bytes, make_specified_string)
117 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
118 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
119 (mark_vectorlike):
120 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
121 (allocate_pseudovector):
122 Use int, not EMACS_INT, where int is wide enough.
123 (inhibit_garbage_collection, Fgarbage_collect):
124 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
125 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
126 int might not be wide enough.
127 (bidi_cache_search, bidi_cache_find, bidi_init_it)
128 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
129 (bidi_at_paragraph_end, bidi_find_paragraph_start)
130 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
131 (bidi_level_of_next_char, bidi_move_to_visually_next):
132 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
133 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
134 (Fkill_buffer, Fset_buffer_major_mode)
135 (advance_to_char_boundary, Fbuffer_swap_text)
136 (Fset_buffer_multibyte, overlays_at, overlays_in)
137 (overlay_touches_p, struct sortvec, record_overlay_string)
138 (overlay_strings, recenter_overlay_lists)
139 (adjust_overlays_for_insert, adjust_overlays_for_delete)
140 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
141 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
142 (Foverlay_recenter, last_overlay_modification_hooks_used)
143 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
144 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
145 (validate_region): Omit unnecessary test for b <= e,
146 since that's guaranteed by the previous test.
d311d28c
PE
147 (adjust_overlays_for_delete): Avoid pos + length overflow.
148 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
149 (report_overlay_modification):
150 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
151 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
152 Omit pointer cast, which isn't needed anyway, and doesn't work
153 after the EMACS_INT -> ptrdiff_t change.
02481186 154 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
155 * buffer.h: Adjust decls to match defn changes elsewhere.
156 (struct buffer_text, struct buffer):
157 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
158 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
159 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
160 not int, to avoid needless 32-bit limit on 64-bit hosts.
161 (exec_byte_code): Use tighter memory-full test, one that checks
162 for alloca overflow. Don't compute the address of the object just
163 before an array, as that's not portable. Use EMACS_INT, not
164 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
165 * callint.c (Fcall_interactively):
166 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
167 * callproc.c (call_process_kill, Fcall_process):
168 Don't assume pid_t fits into an Emacs fixnum.
169 (call_process_cleanup, Fcall_process, child_setup):
170 Don't assume pid_t fits into int.
171 (call_process_cleanup, Fcall_process, delete_temp_file)
172 (Fcall_process_region):
173 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
174 (Fcall_process): Simplify handling of volatile integers.
175 Use int, not EMACS_INT, where int will do.
176 * casefiddle.c (casify_object, casify_region, operate_on_word)
177 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
178 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
179 (casify_object): Avoid integer overflow when overallocating buffer.
180 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 181 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
182 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
183 * category.h (CATEGORYP): Don't assume arg is nonnegative.
184 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
185 integers are now checked earlier. All uses replaced with XINT.
186 (ccl_driver):
187 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
188 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
189 (ccl_driver, Fregister_code_conversion_map):
190 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
191 (resolve_symbol_ccl_program): Check that vector header is in range.
192 Always copy the vector, so that we can check its contents reliably
193 now rather than having to recheck each instruction as it's being
194 executed. Check that vector words fit in 'int'.
195 (ccl_get_compiled_code, Fregister_ccl_program)
196 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
197 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
198 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
199 contents are in range.
200 (Fccl_execute_on_string): Check that status is in range.
201 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
202 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
203 Accept and return EMACS_INT, not int, because callers can pass values
204 out of 'int' range.
205 (c_string_width, strwidth, lisp_string_width, chars_in_text)
206 (multibyte_chars_in_text, parse_str_as_multibyte)
207 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
208 (str_as_unibyte, str_to_unibyte, string_count_byte8)
209 (string_escape_byte8, Fget_byte):
210 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 211 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
212 avoid mishandling large integers.
213 * character.h: Adjust decls to match defn changes elsewhere.
214 * charset.c (load_charset_map_from_file, find_charsets_in_text)
215 (Ffind_charset_region):
216 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
217 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
218 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 219 Don't assume fixnum fits in int.
d311d28c
PE
220 (load_charset_map_from_vector, Fmap_charset_chars):
221 Remove now-unnecessary CHECK_NATNUMs.
222 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
223 Don't rely on undefined behavior with signed left shift overflow.
224 Don't assume unsigned int fits into fixnum, or that fixnum fits
225 into unsigned int. Don't require max_code to be a valid fixnum;
226 that's not true for gb10830 4-byte on a 32-bit host. Allow
227 invalid_code to be a cons, for the same reason. Require code_offset
228 to be a character. Avoid int overflow if max_char is close
229 to INT_MAX.
230 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
231 this is intended anyway and avoids some undefined behavior.
232 (load_charset_map): Pass unsigned, not int, as 2nd arg of
233 INDEX_TO_CODE_POINT, as that's what it expects.
234 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
235 * charset.h (DECODE_CHAR): Return int, not unsigned;
236 this is what was intended anyway, and it avoids undefined behavior.
237 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
238 integer-overflow issues.
239 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
240 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
241 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
242 * chartab.c (Fmake_char_table, Fset_char_table_range)
243 (uniprop_get_decoder, uniprop_get_encoder):
244 Don't assume fixnum fits in int.
245 * cmds.c (move_point): New function, that does the gist of
246 Fforward_char and Fbackward_char, but does so while checking
247 for integer overflow more accurately.
c96e5d6a 248 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
249 (Fforward_line, Fend_of_line, internal_self_insert)
250 (internal_self_insert):
251 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
252 Fix a FIXME, by checking for integer overflow when calculating
253 target_clm and actual_clm.
254 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 255 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
256 (ASSURE_DESTINATION, coding_alloc_by_realloc)
257 (coding_alloc_by_making_gap, alloc_destination)
258 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
259 (encode_coding_utf_16, detect_coding_emacs_mule)
260 (decode_coding_emacs_mule, encode_coding_emacs_mule)
261 (detect_coding_iso_2022, decode_coding_iso_2022)
262 (encode_invocation_designation, encode_designation_at_bol)
263 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
264 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
265 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
266 (encode_coding_ccl, encode_coding_raw_text)
267 (detect_coding_charset, decode_coding_charset)
268 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
269 (produce_composition, produce_charset, produce_annotation)
270 (decode_coding, handle_composition_annotation)
271 (handle_charset_annotation, consume_chars, decode_coding_gap)
272 (decode_coding_object, encode_coding_object, detect_coding_system)
273 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
274 (code_convert_region, code_convert_string)
8f50130c
PE
275 (Fdefine_coding_system_internal)
276 (coding_set_source, coding_set_destination):
d311d28c
PE
277 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
278 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
279 (Fdefine_coding_system_internal):
280 Don't assume fixnums fit in int.
281 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 282 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
283 (Funencodable_char_position, Fcheck_coding_systems_region)
284 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 285 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 286 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 287 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 288 Don't access memory outside of the args array.
d311d28c 289 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
290 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
291 result of ENCODE_CHAR.
d311d28c
PE
292 * coding.h: Adjust decls to match defn changes elsewhere.
293 (struct coding_system):
294 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
295 * composite.c (get_composition_id, find_composition)
296 (run_composition_function, update_compositions)
297 (compose_text, composition_gstring_put_cache)
298 (composition_gstring_p, composition_gstring_width)
299 (fill_gstring_header, fill_gstring_body, autocmp_chars)
300 (composition_compute_stop_pos, composition_reseat_it)
301 (composition_update_it, struct position_record)
302 (find_automatic_composition, composition_adjust_point)
303 (Fcomposition_get_gstring, Ffind_composition_internal):
304 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
305 (update_compositions):
306 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
307 * composite.h: Adjust decls to match defn changes elsewhere.
308 (struct composition):
309 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
310 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
311 Do not attempt to compute the address of the object just before a
312 buffer; this is not portable.
313 (Faref, Faset):
314 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
315 (Faset): Use int, not EMACS_INT, where int is wide enough.
316 (Fstring_to_number): Don't assume fixnums fit in int.
317 (Frem): Don't assume arg is nonnegative.
318 * dbusbind.c (xd_append_arg): Check for integers out of range.
319 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 320 (extract_signed, extract_unsigned): New functions.
243e0530
PE
321 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
322 (xd_get_connection_references): Return ptrdiff_t, not int.
323 All uses changed.
324 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
325 (xd_read_message_1):
326 Use int, not unsigned, where the dbus API uses int.
327 (Fdbus_message_internal): Don't overflow mtype.
328 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
329 * dired.c (directory_files_internal, file_name_completion, scmp)
330 (file_name_completion_stat):
331 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
332 (file_name_completion): Don't overflow matchcount.
333 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
334 * dispextern.h: Adjust decls to match defn changes elsewhere.
335 (struct text_pos, struct glyph, struct bidi_saved_info)
336 (struct bidi_string_data, struct bidi_it, struct composition_it)
337 (struct it):
338 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
339 (struct display_pos, struct composition_it, struct it):
340 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
341 * dispnew.c (increment_matrix_positions)
342 (increment_row_positions, mode_line_string)
343 (marginal_area_string):
344 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 345 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
346 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
347 (duration_to_sec_usec): New function, to check for overflow better.
348 (Fsleep_for, sit_for): Use it.
349 * doc.c (get_doc_string, store_function_docstring):
350 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
351 (get_doc_string, Fsnarf_documentation):
352 Use int, not EMACS_INT, where int is wide enough.
353 (get_doc_string):
354 Use SAFE_ALLOCA, not alloca.
355 Check for overflow when converting EMACS_INT to off_t.
356 * doprnt.c (doprnt):
357 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
358 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
359 Don't assume uid_t fits into fixnum.
360 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
361 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
362 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
363 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
364 (general_insert_function)
365 (Finsert_char, make_buffer_string, make_buffer_string_both)
366 (update_buffer_properties, Fbuffer_substring)
367 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
368 (Fsubst_char_in_region, check_translation)
369 (Ftranslate_region_internal, save_restriction_restore, Fformat)
370 (transpose_markers, Ftranspose_regions):
371 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
372 (clip_to_bounds): Move to lisp.h as an inline function).
373 (Fconstrain_to_field): Don't assume integers are nonnegative.
374 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
375 (Fsubst_char_in_region, Fsave_restriction):
376 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
377 (Femacs_pid): Don't assume pid_t fits into fixnum.
378 (lo_time): Use int, not EMACS_INT, when int suffices.
379 (lisp_time_argument): Check for usec out of range.
380 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
381 (Fuser_login_name, Fuser_full_name): Signal an error
382 if a uid argument is out of range, rather than relying on
383 undefined behavior.
c8d5c857
PE
384 (Fformat_time_string): Remove now-unnecessary check.
385 lisp_time_argument checks for out-of-range usec now.
243e0530 386 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
387 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
388 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
389 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
390 (init_cmdargs, Fdump_emacs):
391 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
392 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
393 the bottom (typically) 32 bits of the fixnum.
394 * eval.c (specpdl_size, call_debugger):
395 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
396 (when_entered_debugger, Fbacktrace_debug):
397 Don't assume fixnum can fit in int.
398 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
399 the object just before a buffer; this is not portable.
400 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
401 (grow_specpdl, unbind_to):
402 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
403 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
404 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 405 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
406 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
407 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
408 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
409 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
410 (a_write, e_write):
411 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
412 (Fcopy_file, non_regular_nbytes, read_non_regular)
413 (Finsert_file_contents):
414 Use int, not EMACS_INT, where int is wide enough.
415 (READ_BUF_SIZE): Verify that it fits in int.
416 (Finsert_file_contents): Check that counts are in proper range,
417 rather than assuming fixnums fit into ptrdiff_t etc.
418 Don't assume fixnums fit into int.
125b3835 419 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
420 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
421 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
422 (string_char_to_byte, string_byte_to_char)
423 (string_make_multibyte, string_to_multibyte)
424 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
425 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
426 (substring_both, Fdelete, internal_equal, Ffillarray)
427 (Fclear_string, mapcar1)
428 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
429 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
430 (larger_vector, make_hash_table, maybe_resize_hash_table)
431 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
432 (Fmaphash, secure_hash):
433 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
434 (concat): Check for string index and length overflow.
435 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
436 (Frequire):
437 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
438 (larger_vector): New API (vec, incr_min, size_max) replaces old
439 one (vec, new_size, init). This catches size overflow.
440 INIT was removed because it was always Qnil.
441 All callers changed.
442 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
443 the upper bound on a hash table index size.
444 (make_hash_table, maybe_resize_hash_table): Use it.
445 (secure_hash): Computer start_byte and end_byte only after
446 they're known to be in ptrdiff_t range.
447 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
448 (Ffont_get_glyphs, Ffont_at):
449 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
450 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
451 (Flist_fonts, Fopen_font):
452 Don't assume fixnum can fit in int.
453 (check_gstring): Don't assume index can fit in int.
454 (font_match_p): Check that fixnum is a character, not a nonnegative
455 fixnum, since the later code needs to stuff it into an int.
456 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
457 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
458 conversion overflow issues.
459 (Fopen_font): Check for integer out of range.
460 (Ffont_get_glyphs): Don't assume index can fit in int.
461 * font.h: Adjust decls to match defn changes elsewhere.
462 * fontset.c (reorder_font_vector): Redo score calculation to avoid
463 integer overflow.
464 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
465 printmax_t, where ptrdiff_t is wide enough.
466 (Finternal_char_font):
467 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
468 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
469 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
470 (Fset_frame_position, x_set_frame_parameters)
471 (x_set_line_spacing, x_set_border_width)
472 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
473 Check that fixnums are in proper range for system types.
474 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
475 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
476 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
477 Use SAFE_ALLOCA_LISP, not alloca.
478 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
479 intptr_t is wide enough.
480 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
481 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
482 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
483 Check for fixnum out of range.
484 * ftfont.c (ftfont_list): Don't assume index fits in int.
485 Check that fixnums are in proper range for system types.
486 (ftfont_shape_by_flt):
487 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
488 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
489 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
490 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
491 Check that fixnums are in proper range for system types.
492 * gnutls.h: Adjust decls to match defn changes elsewhere.
493 * gtkutil.c (xg_dialog_run):
494 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
495 (update_frame_tool_bar):
496 Check that fixnums are in proper range for system types.
497 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 498 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
499 * indent.c (last_known_column, last_known_column_point):
500 (current_column_bol_cache):
501 (skip_invisible, current_column, check_display_width):
502 (check_display_width, scan_for_column, current_column_1)
503 (Findent_to, Fcurrent_indentation, position_indentation)
504 (indented_beyond_p, Fmove_to_column, compute_motion):
505 (Fcompute_motion, Fvertical_motion):
506 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
507 (last_known_column_modified): Use EMACS_INT, not int.
508 (check_display_width):
509 (Fcompute_motion):
510 Check that fixnums and floats are in proper range for system types.
511 (compute_motion): Don't assume index or fixnum fits in int.
512 (compute_motion, Fcompute_motion):
513 Use int, not EMACS_INT, when it is wide enough.
514 (vmotion): Omit local var start_hpos that is always 0; that way
515 we don't need to worry about overflow in expressions involving it.
516 * indent.h: Adjust decls to match defn changes elsewhere.
517 (struct position):
518 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
519 Use int, not EMACS_INT, where int is wide enough.
520 Remove unused members ovstring_chars_done and tab_offset;
521 all uses removed.
522 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
523 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
524 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
525 (make_gap, copy_text, insert, insert_and_inherit)
526 (insert_before_markers, insert_before_markers_and_inherit)
527 (insert_1, count_combining_before, count_combining_after)
528 (insert_1_both, insert_from_string)
529 (insert_from_string_before_markers, insert_from_string_1)
530 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
531 (adjust_after_replace, adjust_after_insert, replace_range)
532 (replace_range_2, del_range, del_range_1, del_range_byte)
533 (del_range_both, del_range_2, modify_region)
534 (prepare_to_modify_buffer, signal_before_change)
535 (signal_after_change, Fcombine_after_change_execute):
536 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
537 * intervals.c (traverse_intervals, rotate_right, rotate_left)
538 (balance_an_interval, split_interval_right, split_interval_left)
539 (find_interval, next_interval, update_interval)
540 (adjust_intervals_for_insertion, delete_node, delete_interval)
541 (interval_deletion_adjustment, adjust_intervals_for_deletion)
542 (static_offset_intervals, offset_intervals)
543 (merge_interval_right, merge_interval_left, make_new_interval)
544 (graft_intervals_into_buffer, temp_set_point_both)
545 (temp_set_point, set_point, adjust_for_invis_intang)
546 (set_point_both, move_if_not_intangible, get_property_and_range)
547 (get_local_map, copy_intervals, copy_intervals_to_string)
548 (compare_string_intervals, set_intervals_multibyte_1):
549 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
550 * intervals.h: Adjust decls to match defn changes elsewhere.
551 (struct interval):
552 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
553 * keyboard.c (this_command_key_count, this_single_command_key_start)
554 (before_command_key_count, before_command_echo_length, echo_now)
555 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
556 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
557 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
558 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
559 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
560 (last_non_minibuf_size, last_point_position, echo_truncate)
561 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
562 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
563 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
564 (stuff_buffered_input):
565 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
566 (last_auto_save, command_loop_1, read_char):
567 Use EMACS_INT, not int, to avoid integer overflow.
568 (record_char): Avoid overflow in total_keys computation.
569 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
570 * keyboard.h: Adjust decls to match defn changes elsewhere.
571 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
572 (Fkey_description, Fdescribe_vector, Flookup_key):
573 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
574 (click_position): New function, to check that positions are in range.
575 (Fcurrent_active_maps):
576 (describe_command):
577 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
578 (Faccessible_keymaps, Fkey_description):
579 (preferred_sequence_p):
580 Don't assume fixnum can fit into int.
581 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
582 Check for integer overflow in size calculations.
583 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
584 avoid mishandling large integers.
585 * lisp.h: Adjust decls to match defn changes elsewhere.
586 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
587 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
588 (struct Lisp_Marker):
589 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
590 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
591 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
592 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
593 All callers changed.
594 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
595 Assume the arg has valid form, since it always does.
596 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
597 unsigned integer system type.
598 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
599 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
600 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
601 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
602 (duration_to_sec_usec): New decl.
603 * lread.c (read_from_string_index, read_from_string_index_byte)
604 (read_from_string_limit, readchar, unreadchar, openp)
605 (read_internal_start, read1, oblookup):
606 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
607 (Fload, readevalloop, Feval_buffer, Feval_region):
608 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
609 (openp): Check for out-of-range argument to 'access'.
610 (read1): Use int, not EMACS_INT, where int is wide enough.
611 Don't assume fixnum fits into int.
6efdadfd 612 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
613 (read_filtered_event): Use duration_to_sec_usec
614 to do proper overflow checking on durations.
d311d28c
PE
615 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
616 in size calculation.
617 (Fexecute_kbd_macro):
618 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
619 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
620 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
621 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
622 (set_marker_both, set_marker_restricted_both, marker_position)
623 (marker_byte_position, Fbuffer_has_markers_at):
624 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
625 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
626 * menu.c (ensure_menu_items): Renamed from grow_menu_items.
627 It now merely ensures that the menu is large enough, without
628 necessarily growing it, as this avoids some integer overflow issues.
629 All callers changed.
630 (keymap_panes, parse_single_submenu, Fx_popup_menu):
631 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
632 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
633 Use SAFE_ALLOCA_LISP, not alloca.
634 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
635 to EMACS_INT. Check that fixnums are in proper range for system types.
636 * minibuf.c (minibuf_prompt_width, string_to_object)
637 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
638 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
639 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
640 (get_minibuffer, read_minibuf_unwind):
641 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
642 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
643 this simplifies overflow checking. All callers changed.
644 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
645 (Ftest_completion):
646 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
647 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
648 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
649 Check that fixnums are in proper range for system types.
650 (Fx_create_frame, Fx_show_tip):
651 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
652 * nsfont.m (ns_findfonts, nsfont_list_family):
653 Don't assume fixnum fits in long.
654 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
655 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
656 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
657 wide enough.
17fdb222 658 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
659 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
660 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
661 (PRINTDECLARE, PRINTPREPARE):
662 (strout, print_string):
663 (print, print_preprocess, print_check_string_charset_prop)
664 (print_object):
665 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
666 (PRINTDECLARE):
667 (temp_output_buffer_setup, Fprin1_to_string, print_object):
668 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
669 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 670 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 671 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
672 (print_error_message): Use SAFE_ALLOCA, not alloca.
673 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
674 (print_depth, new_backquote_output, print_number_index):
675 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
676 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
677 (Fset_process_window_size, Fformat_network_address)
678 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 679 (sigchld_handler):
d311d28c 680 Check that fixnums are in proper range for system types.
d44287d4 681 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
682 Check for process-ids out of pid_t range rather than relying on
683 undefined behavior.
e4d81efc 684 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
685 (Fformat_network_address, read_process_output, send_process)
686 (Fprocess_send_region, status_notify):
687 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
688 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
689 (wait_reading_process_output, read_process_output, exec_sentinel):
690 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
691 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
692 (Faccept_process_output): Use duration_to_sec_usec to do proper
693 overflow checking on durations.
dde14581
PE
694 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
695 Don't assume pid_t fits in int.
02481186
PE
696 * process.h (struct Lisp_Process): Members tick and update_tick
697 are now of type EMACS_INT, not int.
b62b53e8
PE
698 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
699 configured --with-wide-int.
d311d28c
PE
700 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
701 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
702 * search.c (looking_at_1, string_match_1):
703 (fast_string_match, fast_c_string_match_ignore_case)
704 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
705 (scan_newline, find_before_next_newline, search_command)
706 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
707 (set_search_regs, wordify):
708 (Freplace_match):
709 (Fmatch_data):
710 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
711 (string_match_1, search_buffer, set_search_regs):
712 (Fmatch_data):
713 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
714 (wordify): Check for overflow in size calculation.
715 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
716 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
717 Check that fixnums are in proper range for system types.
718 * sound.c (struct sound_device)
719 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
720 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
721 (Fplay_sound_internal):
722 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 723 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
724 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
725 (Fparse_partial_sexp):
726 Don't assume fixnums can fit in int.
727 (struct lisp_parse_state, find_start_pos, find_start_value)
728 (find_start_value_byte, find_start_begv)
729 (update_syntax_table, char_quoted, dec_bytepos)
730 (find_defun_start, prev_char_comend_first, back_comment):
731 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
732 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
733 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
734 (Finternal_describe_syntax_value): Check that match_lisp is a
735 character, not an integer, since the code stuffs it into int.
736 (scan_words, scan_sexps_forward):
737 Check that fixnums are in proper range for system types.
738 (Fforward_word):
739 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
740 (scan_sexps_forward):
741 Use CHARACTERP, not INTEGERP, since the value must fit into int.
742 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
743 * syntax.h: Adjust decls to match defn changes elsewhere.
744 (struct gl_state_s):
745 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
746 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
747 MOST_POSITIVE_FIXNUM.
d311d28c
PE
748 * sysdep.c (wait_for_termination_1, wait_for_termination)
749 (interruptible_wait_for_termination, mkdir):
750 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
751 (emacs_read, emacs_write):
752 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
753 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
754 and double all fit in int.
d311d28c
PE
755 * term.c (set_tty_color_mode):
756 Check that fixnums are in proper range for system types.
757 * termhooks.h (struct input_event):
758 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
759 * textprop.c (validate_interval_range, interval_of)
760 (Fadd_text_properties, set_text_properties_1)
761 (Fremove_text_properties, Fremove_list_of_text_properties)
762 (Ftext_property_any, Ftext_property_not_all)
763 (copy_text_properties, text_property_list, extend_property_ranges)
764 (verify_interval_modification):
765 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
766 (Fnext_single_char_property_change)
767 (Fprevious_single_char_property_change):
768 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
769 (copy_text_properties):
770 Check for integer overflow in index calculation.
d311d28c
PE
771 * undo.c (last_boundary_position, record_point, record_insert)
772 (record_delete, record_marker_adjustment, record_change)
773 (record_property_change):
774 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
775 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
776 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
777 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
778 (Fx_hide_tip, Fx_file_dialog):
779 * w32menu.c (set_frame_menubar):
780 Use ptrdiff_t, not int, for consistency with rest of code.
781 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
782 (select_window, Fdelete_other_windows_internal)
783 (window_scroll_pixel_based, window_scroll_line_based)
784 (Frecenter, Fset_window_configuration):
785 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
786 (Fset_window_hscroll, run_window_configuration_change_hook)
787 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 788 (Fscroll_other_window, Frecenter):
d311d28c
PE
789 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
790 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
791 Don't assume fixnum fits in int.
792 (Fset_window_scroll_bars):
793 Check that fixnums are in proper range for system types.
794 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
795 (string_pos, c_string_pos, number_of_chars, init_iterator)
796 (in_ellipses_for_invisible_text_p, init_from_display_pos)
797 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
798 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
799 (face_before_or_after_it_pos, handle_invisible_prop)
800 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
801 (display_prop_intangible_p, string_buffer_position_lim)
802 (string_buffer_position, handle_composition_prop, load_overlay_strings)
803 (get_overlay_strings_1, get_overlay_strings)
804 (iterate_out_of_display_property, forward_to_next_line_start)
805 (back_to_previous_visible_line_start, reseat, reseat_to_string)
806 (get_next_display_element, set_iterator_to_next)
807 (get_visually_first_element, compute_stop_pos_backwards)
808 (handle_stop_backwards, next_element_from_buffer)
809 (move_it_in_display_line_to, move_it_in_display_line)
810 (move_it_to, move_it_vertically_backward, move_it_by_lines)
811 (add_to_log, message_dolog, message_log_check_duplicate)
812 (message2, message2_nolog, message3, message3_nolog
813 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
814 (current_message_1, truncate_echo_area, truncate_message_1)
815 (set_message, set_message_1, store_mode_line_noprop)
816 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
817 (text_outside_line_unchanged_p, check_point_in_composition)
818 (reconsider_clip_changes)
819 (redisplay_internal, set_cursor_from_row, try_scrolling)
820 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
821 (redisplay_window, find_last_unchanged_at_beg_row)
822 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
823 (trailing_whitespace_p, find_row_edges, display_line)
824 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
825 (display_mode_element, store_mode_line_string)
826 (pint2str, pint2hrstr, decode_mode_spec)
827 (display_count_lines, display_string, draw_glyphs)
828 (x_produce_glyphs, x_insert_glyphs)
829 (rows_from_pos_range, mouse_face_from_buffer_pos)
830 (fast_find_string_pos, mouse_face_from_string_pos)
831 (note_mode_line_or_margin_highlight, note_mouse_highlight):
832 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
833 (safe_call, init_from_display_pos, handle_fontified_prop)
834 (handle_single_display_spec, load_overlay_strings)
835 (with_echo_area_buffer, setup_echo_area_for_printing)
836 (display_echo_area, echo_area_display)
837 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
838 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
839 (redisplay_window, dump_glyph_row, display_mode_line)
840 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 841 (handle_display_spec, display_prop_string_p):
d311d28c
PE
842 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
843 (handle_single_display_spec, build_desired_tool_bar_string)
844 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
845 (get_specified_cursor_type):
846 Check that fixnums are in proper range for system types.
847 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
848 (Flookup_image_map):
849 Don't assume fixnums fit in int.
850 (compare_overlay_entries):
851 Avoid mishandling comparisons due to subtraction overflow.
852 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
853 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
854 (handle_tool_bar_click):
855 Use int, not unsigned, since we prefer signed and the signedness
856 doesn't matter here.
857 (get_next_display_element, next_element_from_display_vector):
858 Use int, not EMACS_INT, when int is wide enough.
859 (start_hourglass): Use duration_to_sec_usec to do proper
860 overflow checking on durations.
861 * xfaces.c (Fbitmap_spec_p):
862 Check that fixnums are in proper range for system types.
863 (compare_fonts_by_sort_order):
864 Avoid mishandling comparisons due to subtraction overflow.
865 (Fx_family_fonts, realize_basic_faces):
866 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
867 (Fx_family_fonts):
868 Don't assume fixnum fits in int.
869 Use SAFE_ALLOCA_LISP, not alloca.
870 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
871 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
872 (face_at_buffer_position, face_for_overlay_string)
873 (face_at_string_position):
874 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
875 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
876 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
877 (Fx_show_tip):
878 Check that fixnums are in proper range for system types.
879 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
880 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
881 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
882 (Fx_change_window_property): Don't assume fixnums fit in int.
883 * xfont.c (xfont_chars_supported):
884 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
885 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
886 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
887 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
888 * xml.c (parse_region):
889 * xrdb.c (magic_file_p):
890 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
891 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
892 (x_get_local_selection, x_reply_selection_request)
893 (x_handle_selection_request, wait_for_property_change):
894 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
895 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
896 short is wide enough.
897 (x_send_client_event): Don't assume fixnum fits in int.
898 * xterm.c (x_x_to_emacs_modifiers):
899 Don't assume EMACS_INT overflows nicely into int.
900 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
901 may come from Lisp.
902 (handle_one_xevent): NATNUMP can eval its arg twice.
903 (x_connection_closed):
904 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
905 * xterm.h: Adjust decls to match defn changes elsewhere.
906 (struct scroll_bar): Use struct vectorlike_header
907 rather than rolling our own approximation.
908 (SCROLL_BAR_VEC_SIZE): Remove; not used.
909
c6574eb5
GM
9102012-05-25 Glenn Morris <rgm@gnu.org>
911
912 * lisp.mk (lisp): Update for more files being compiled now.
913
e8d32c7e
SM
9142012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
915
48def666
SM
916 * lread.c: Remove `read_pure' which makes no difference.
917 (read_pure): Remove var.
918 (unreadpure): Remove function.
919 (readevalloop): Don't call read_list with -1 flag.
920 (read1, read_vector): Don't test read_pure any more.
921 (read_list): Simplify.
922
e8d32c7e
SM
923 * fileio.c, character.h: Minor style tweaks.
924
4b2addb7
DA
9252012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
926
927 * window.h (clip_changed): Remove useless declaration.
928
584461b2
JB
9292012-05-22 Juanma Barranquero <lekktu@gmail.com>
930
931 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
932 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
933
34374650
PE
9342012-05-22 Paul Eggert <eggert@cs.ucla.edu>
935
936 Remove src/m/*.
937 This directory predates autoconf and is no longer needed nowadays.
938 Move its few remaining bits of functionality to where they're needed.
939 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
940 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
941 * m/template.h: Remove.
942 * Makefile.in (M_FILE): Remove. All uses removed.
943 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
944 * lisp.h (USE_LSB_TAG):
945 * mem-limits.h (EXCEEDS_LISP_PTR):
946 Use VAL_MAX, not VALBITS, in #if.
947 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
948 (EMACS_UINT): Define unconditionally now.
949 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
950 (BITS_PER_EMACS_INT): New constants, replacing
951 what used to be in config.h, but not useful in #if.
952 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
953 define them any more.
954 (VAL_MAX): New macro.
955 (VALMASK): Use it.
956 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
957 BITS_PER_EMACS_INT, in #if.
958 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
959 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
960 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
961 * s/ms-w32.h (DATA_START):
962 Move here from removed file m/intel386.h.
963 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
964 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
965
261cb4bb
PE
9662012-05-21 Paul Eggert <eggert@cs.ucla.edu>
967
968 Assume C89 or later.
969 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
970 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
971 (xrealloc):
972 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
973 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
974 * textprop.c, tparam.c (NULL): Remove.
975 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
976 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
977 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
978 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
979 * xterm.c (input_signal_count): Assume volatile works.
980
ff23cd9f
KB
9812012-05-21 Ken Brown <kbrown@cornell.edu>
982
983 * xgselect.c (xg_select): Fix first argument in call to 'select'
984 (bug#11508).
985
1b170bc6
KB
9862012-05-20 Ken Brown <kbrown@cornell.edu>
987
988 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 989 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 990
b2f4d39f
KB
9912012-05-19 Ken Brown <kbrown@cornell.edu>
992
993 * xfns.c (x_in_use): Remove `static' qualifier.
994 * xterm.h (x_in_use): Declare.
995 * xgselect.c: Include xterm.h.
996 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
997 and `display_arg' (bug#9754).
998
003fdae2
PE
9992012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1000
9232a6d9
PE
1001 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1002
003fdae2
PE
1003 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1004 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1005
784b56e2
EZ
10062012-05-18 Eli Zaretskii <eliz@gnu.org>
1007
1008 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1009
1010 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1011 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1012
1013 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1014 reference to image_cache->refcount.
1015 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1016
a0a79cde
JL
10172012-05-17 Juri Linkov <juri@jurta.org>
1018
1019 * search.c (Fword_search_regexp, Fword_search_backward)
1020 (Fword_search_forward, Fword_search_backward_lax)
1021 (Fword_search_forward_lax): Move functions to isearch.el
1022 (bug#10145, bug#11381).
1023
b0572523
PE
10242012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1025
1026 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1027
9660f5fc
SM
10282012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1029
1030 * lread.c (init_obarray): Declare Qt and Qnil as special.
1031
4374de83
GM
10322012-05-14 Glenn Morris <rgm@gnu.org>
1033
1034 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1035 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1036
dc44c39a
PE
10372012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1038
078c97cb
PE
1039 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1040
dc44c39a
PE
1041 * unexaix.c: Port to more-recent AIX compilers.
1042 (report_error, report_error_1, make_hdr, copy_sym)
1043 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1044 Make arguments const char *, not char *, to avoid violations of C
1045 standard and to fix some AIX warnings reported by Gilles Pion.
1046
e18afed7 10472012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1048
1049 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1050 already have overlays loaded.
1051 (handle_single_display_spec): Before returning without displaying
1052 fringe bitmap, synchronize the bidi iterator with the main display
1053 iterator, by calling iterate_out_of_display_property.
1054 (iterate_out_of_display_property): Detect buffer iteration by
1055 testing that it->string is a Lisp string.
1056 (get_next_display_element): When the current object is exhausted,
1057 and there's something on it->stack, call set_iterator_to_next to
1058 proceed with what's on the stack, instead of returning zero.
1059 (set_iterator_to_next): If called at the end of a Lisp string,
1060 proceed to consider_string_end without incrementing string
1061 position. Don't increment display vector index past the end of
1062 the display vector. (Bug#11417)
c8fb9dc6
EZ
1063 (pos_visible_p): Don't report a position visible when move_it_to
1064 stopped at the last line of window, which happens to be scanned
1065 backwards by the bidi iteration. (Bug#11464)
ac268e67 1066
e18afed7 10672012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1068
1069 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1070 and right-margin display specs even if the spec is invalid or we
1071 are on a TTY, and thus unable to display on the fringes. That's
1072 because the text with the property will not be displayed anyway,
1073 so we need to signal to the caller that this is a "replacing"
1074 display spec. This fixes display when the spec is invalid or we
1075 are on a TTY.
1076
e18afed7 10772012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1078
1079 * unexaix.c (make_hdr): Fix typo in prototype.
1080 This bug broke the build on AIX. Problem reported by Gilles Pion.
1081
9d0a235a
MA
10822012-05-14 Michael Albinus <michael.albinus@gmx.de>
1083
1084 * keyboard.c (kbd_buffer_get_event): Read special events also in
1085 batch mode. (Bug#11415)
1086
9e6b06ed
GM
10872012-05-12 Glenn Morris <rgm@gnu.org>
1088
1089 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1090
c1a1d7a3
EZ
10912012-05-12 Eli Zaretskii <eliz@gnu.org>
1092
1093 * lisp.mk (lisp): Add newcomment.elc.
1094
3fe7cdc8
GM
10952012-05-12 Glenn Morris <rgm@gnu.org>
1096
1097 * Makefile.in (MKDIR_P): New, set by configure.
1098 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1099
53f7d2c0
PE
11002012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1101
1102 Remove unused function hourglass_started.
1103 * dispextern.h (hourglass_started):
1104 * w32fns.c (hourglass_started):
1105 * xdisp.c (hourglass_started): Remove.
1106
75aafb17
JB
11072012-05-10 Juanma Barranquero <lekktu@gmail.com>
1108
1109 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1110 Update dependencies.
1111
12959e8e
PE
11122012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1113
97107e2e
PE
1114 * xgselect.c (xg_select): Put maxfds+1 into a var.
1115 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1116
12959e8e
PE
1117 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1118
836d29b3
DA
11192012-05-10 Dave Abrahams <dave@boostpro.com>
1120
1121 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1122 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1123
5cb67954
MA
11242012-05-09 Michael Albinus <michael.albinus@gmx.de>
1125
1126 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1127 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1128 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1129 Initialize xd_registered_buses.
1130
3478ec45
PE
11312012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1132
b263a6b0
PE
1133 Untag more efficiently if USE_LSB_TAG.
1134 This is based on a proposal by YAMAMOTO Mitsuharu in
1135 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1136 For an admittedly artificial (nth 8000 longlist) benchmark on
1137 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1138 Emacs's overall text size by 1%.
1139 * lisp.h (XUNTAG): New macro.
1140 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1141 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1142 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1143 * eval.c (Fautoload):
1144 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1145 * frame.h (XFRAME): Use XUNTAG.
1146
3478ec45
PE
1147 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1148 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1149 Remove unportable assumptions about print widths of types like
1150 dbus_uint32_t.
1151 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1152 intptr_t when converting between pointer and integer, to avoid GCC
1153 warnings about wrong width.
1154
666b903b 11552012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1156
1157 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1158 stack for each reader_thread, instead of defaulting to 8MB
1159 determined by the linker. This avoids failures in creating
1160 subprocesses on Windows 7, see the discussion in this thread:
1161 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1162
b120cc17
JC
11632012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1164
1165 Fix up display of the *Minibuf-0* buffer in the mini window.
1166 * keyboard.c (read_char): Don't clear the echo area if there's no
1167 message to clear.
1168 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1169 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 1170
9a4b36f8
MA
11712012-05-07 Michael Albinus <michael.albinus@gmx.de>
1172
1173 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1174 batch mode.
1175
e5f9458f
CY
11762012-05-06 Chong Yidong <cyd@gnu.org>
1177
1178 * lisp.mk (lisp): Update.
1179
eceeb5fc 11802012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
1181
1182 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1183
71873e2b
SM
11842012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1185
1186 * data.c (PUT_ERROR): New macro.
1187 (syms_of_data): Use it. Add new error type `user-error'.
1188 * undo.c (user_error): New function.
1189 (Fprimitive_undo): Use it.
1190 * print.c (print_error_message): Adjust print style for `user-error'.
1191 * keyboard.c (user_error): New function.
1192 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1193
ab0fa4e4
PE
11942012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1195
1196 Do not limit current-time-string to years 1000..9999.
1197 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1198 (Fcurrent_time_string): Support any year that is supported by the
1199 underlying localtime representation. Don't use asctime, as it
1200 has undefined behavior for years outside the range -999..9999.
1201
7ed806a7
PE
12022012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1203
1204 Fix race conditions involving setenv, gmtime, localtime, asctime.
1205 Without this fix, interrupts could mess up code that uses these
1206 nonreentrant functions, since setting TZ invalidates existing
1207 tm_zone or tzname values, and since most of these functions return
1208 pointers to static storage.
1209 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1210 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1211 Grow the critical sections to include not just invoking
1212 localtime/gmtime, but also accessing these functions' results
1213 including their tm_zone values if any, and any related TZ setting.
1214 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
1215 so that the struct tm is saved in the critical section.
1216 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
1217 motivated by the fact that memory allocation needs to be outside
1218 the critical section.
1219
0c16dfed
DA
12202012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1221
1222 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1223 with RESET_INTERVAL.
1224
1225 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1226 Remove duplicated buffer name initialization.
1227
3f83ace8
JM
12282012-05-02 Jim Meyering <jim@meyering.net>
1229
1230 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1231
c7b8541e
JM
1232 * xfns.c (x_window): Use xstrdup (Bug#11375).
1233
90207a15 12342012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
1235
1236 * xdisp.c (pos_visible_p): If already at a newline from the
1237 display string before the 'while' loop, don't walk back the glyphs
1238 from it3.glyph_row. Solves assertion violation when the display
1239 string begins with a newline (egg.el). (Bug#11367)
1240
b593d6a9
AH
12412012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1242
1243 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1244 Move to simple.el.
1245
4737362e
GM
12462012-05-01 Glenn Morris <rgm@gnu.org>
1247
99cf43f9
GM
1248 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1249 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1250 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1251 All were removed before 23.1.
1252
9311dcff
GM
1253 * dispnew.c: Remove HAVE_LIBNCURSES test;
1254 it is always true on relevant platforms.
1255
4d5c6349
GM
1256 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1257 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1258
4737362e
GM
1259 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1260
74dd3a6b
AS
12612012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1262
1263 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1264 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1265 Remove.
1266
13c379ee
PE
12672012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1268
1269 Do not avoid creating empty evaporating overlays (Bug#9642).
1270 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1271 That is, do not delete an evaporating overlay if it becomes
1272 empty after its bounds are adjusted to fit within its buffer.
1273 This fix caused other problems, and I'm reverting it until we get
1274 to the bottom of them.
1275
a8e7d6d7 12762012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
1277
1278 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1279
a8e7d6d7 12802012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
1281
1282 * xdisp.c (pos_visible_p): If the window start position is beyond
1283 ZV, start the display from buffer beginning. Prevents assertion
1284 violation in init_iterator when the minibuffer window is scrolled
1285 via the scroll bar.
1286
1287 * window.c (window_scroll_pixel_based): Likewise.
1288
a8e7d6d7 12892012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
1290
1291 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1292
a8e7d6d7 12932012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
1294
1295 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1296 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1297
a8e7d6d7 12982012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 1299
b593d6a9
AH
1300 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1301 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 1302
1c6900d9
EZ
13032012-04-26 Eli Zaretskii <eliz@gnu.org>
1304
4c3fa1d9
EZ
1305 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1306 display element, check also the underlying string or buffer
1307 character. (Bug#11341)
1308
1c6900d9
EZ
1309 * w32menu.c: Include w32heap.h.
1310 (add_menu_item): If the call to AppendMenuW (via
1311 unicode_append_menu) fails, disable Unicode menus only if we are
1312 running on Windows 9X/Me.
1313
42bf8205
AS
13142012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1315
1316 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1317 (xgetint): Add missing shift for LSB tags.
1318
b1bac16e
MR
13192012-04-24 Martin Rudalics <rudalics@gmx.at>
1320
1321 * keyboard.c (read_char): Don't wipe echo area for select window
1322 events: These might get delayed via `mouse-autoselect-window'
1323 (Bug#11304).
1324
d69621cc
JB
13252012-04-24 Juanma Barranquero <lekktu@gmail.com>
1326
1327 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1328 manipulation of :loaded-from data.
1329
02fd101b
JB
13302012-04-23 Juanma Barranquero <lekktu@gmail.com>
1331
1332 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1333 now a cons (bug#11311).
1334
888bec30
PE
13352012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1336
89a438bd
PE
1337 Do not create empty overlays with the evaporate property (Bug#9642).
1338 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1339 if it becomes empty after its bounds are adjusted to fit within
1340 its buffer. Without this fix, in a nonempty buffer (let ((o
1341 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1342 yields an empty overlay that has the evaporate property, which is
1343 not supposed to happen.
1344
1068fe4d
PE
1345 Fix minor GTK3 problems found by static checking.
1346 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1347 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1348 (struct _EmacsFixedClass, emacs_fixed_get_type):
1349 Move decls here from emacsgtkfixed.h, since they needn't be public.
1350 (emacs_fixed_get_type): Now static.
1351 (emacs_fixed_class_init): Omit unused local.
1352 (emacs_fixed_child_type): Remove; unused.
1353 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1354 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1355 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1356 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1357 (EMACS_FIXED_GET_CLASS): Remove; unused.
1358 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1359
888bec30
PE
1360 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1361 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1362
de85e130
PE
13632012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1364
d0baac98 1365 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 1366 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
1367 (__malloc_size_t, __malloc_ptrdiff_t):
1368 Remove. All uses removed, replaced by the definiens if needed,
1369 since we can assume C89 or better now.
1370 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1371 (protect_malloc_state, align, get_contiguous_space)
1372 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1373 (malloc_atfork_handler_child, malloc_enable_thread)
1374 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1375 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1376 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1377 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1378 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1379 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1380 Define using prototypes, not old style.
1381 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1382 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1383 (align): Don't assume that signed integer overflow wraps around.
1384 Omit unused local var.
1385 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1386 (_free_internal_nolock, memalign, mallochook, reallochook):
1387 Omit no-longer-needed casts.
1388 (valloc): Use getpagesize, not __getpagesize.
1389 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1390 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1391
de85e130
PE
1392 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1393
dcbf5805
MA
13942012-04-22 Michael Albinus <michael.albinus@gmx.de>
1395
1396 Move functions from C to Lisp. Make non-blocking method calls
1397 the default. Implement further D-Bus standard interfaces.
1398
1399 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1400 (QCdbus_request_name_allow_replacement)
1401 (QCdbus_request_name_replace_existing)
1402 (QCdbus_request_name_do_not_queue)
1403 (QCdbus_request_name_reply_primary_owner)
1404 (QCdbus_request_name_reply_in_queue)
1405 (QCdbus_request_name_reply_exists)
1406 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1407 (QCdbus_registered_serial, QCdbus_registered_method)
1408 (QCdbus_registered_signal): New Lisp objects.
1409 (XD_DEBUG_MESSAGE): Use sizeof.
1410 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1411 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1412 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1413 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1414 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1415 (xd_signature, xd_append_arg): Allow float for integer types.
1416 (xd_get_connection_references): New function.
b593d6a9
AH
1417 (xd_get_connection_address): Rename from xd_initialize.
1418 Return cached address.
dcbf5805
MA
1419 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1420 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1421 level.
1422 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 1423 Return number of refcounts.
dcbf5805
MA
1424 (Fdbus_get_unique_name): Make stronger parameter check.
1425 (Fdbus_message_internal): New defun.
1426 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1427 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1428 (Fdbus_send_signal, Fdbus_register_service)
1429 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1430 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1431 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1432 (Vdbus_compiled_version, Vdbus_runtime_version)
1433 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1434 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1435 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
1436 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1437 Adapt docstring.
dcbf5805 1438
52828e02
PE
14392012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1440
da05bc4c
PE
1441 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1442 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1443 Do not assume ptrdiff_t is the same width as 'int'.
1444
52828e02
PE
1445 * alloc.c: Handle unusual debugging option combinations.
1446 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1447 since the two debugging options are incompatible.
1448 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1449 is defined.
1450 (mem_init, mem_insert, mem_insert_fixup):
1451 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1452 (NEED_MEM_INSERT): Remove; no longer needed.
1453
f01769f9
LL
14542012-04-22 Leo Liu <sdl.web@gmail.com>
1455
1456 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1457
5790543d
PE
14582012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1459
1460 * sysdep.c [__FreeBSD__]: Minor cleanups.
1461 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1462 Use Emacs indenting style more consistently. Avoid some casts.
1463 Use 'double' consistently rather than mixing 'float' and 'double'.
1464
b91b7e4d
EW
14652012-04-21 Eduard Wiebe <usenet@pusto.de>
1466
b593d6a9
AH
1467 * sysdep.c (list_system_processes, system_process_attributes):
1468 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 1469
6114eb15
AS
14702012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1471
1472 * lisp.mk (lisp): Update.
1473
2f38dff7
PE
14742012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1475
1476 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1477 It is never used otherwise.
1478
4ae29f89
SM
14792012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1480
1481 * print.c (print_preprocess): Only check print_depth if print-circle
1482 is nil.
1483 (print_object): Check for cycles even when print-circle is nil and
1484 print-gensym is t, but only check print_depth if print-circle is nil.
1485
f30d612a
CY
14862012-04-20 Chong Yidong <cyd@gnu.org>
1487
1488 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1489 set the status to "failed" and ensure that sentinel is run.
1490
c07a4c0b 14912012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
1492
1493 * process.c (Fset_process_inherit_coding_system_flag)
1494 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 1495 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 1496
c07a4c0b 14972012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
1498
1499 * xdisp.c (string_buffer_position_lim): Limit starting position to
1500 BEGV.
1501 (set_cursor_from_row): If called for a mode-line or header-line
1502 row, return zero immediately.
1503 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
1504 farther than the first row after the header line, if any.
1505 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
1506 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1507
c07a4c0b 15082012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1509
4ae29f89
SM
1510 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1511 (bug#11238).
ad3a2b41 1512
c07a4c0b 15132012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 15142012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
1515
1516 configure: new option --enable-gcc-warnings (Bug#11207)
1517 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1518 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1519 (ALL_CFLAGS): Use new macros rather than old.
1520 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1521 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1522 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1523 -Wunused-result, -Wunused-variable. This should go away once
1524 the Emacs and Gnulib regex code is merged.
1525 (xmalloc, xrealloc): Now static.
1526
aba027e8
PE
15272012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1528
1529 * dired.c (Fsystem_groups): Remove unused local.
1530
e5a36063
GM
15312012-04-17 Glenn Morris <rgm@gnu.org>
1532
1533 * dired.c (Fsystem_users): Doc fix.
1534
316411f0
DA
15352012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1536
1537 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1538 (syms_of_dired): Add them.
1539
9426aba4
PE
15402012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1541
b62a57be
PE
1542 Fix minor alloc.c problems found by static checking.
1543 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1544 New extern decls, to avoid calling undeclared functions.
1545 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1546 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1547 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1548 (NEED_MEM_INSERT): New macro.
1549 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 1550 Remove one incorrect comment and fix another.
b62a57be 1551
3539f31f
PE
1552 Fix minor ralloc.c problems found by static checking.
1553 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1554 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1555 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1556 (r_alloc_sbrk): Now static.
1557
a041960a
PE
1558 Improve ralloc.c interface checking.
1559 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1560 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1561 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1562 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1563 [REL_ALLOC]: ... to here, to check interface.
1564 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1565 Remove decls. This fixes an "It stinks!".
1566
9426aba4
PE
1567 * alloc.c (which_symbols): Fix alignment issue / type clash.
1568
d55c12ed
AS
15692012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1570
1571 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1572 (struct Lisp_Misc_Any): Likewise.
1573 (struct Lisp_Free): Likewise.
1574 * alloc.c (union aligned_Lisp_Symbol): Define.
1575 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1576 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1577 (union aligned_Lisp_Misc): Define.
1578 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1579 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 1580 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 1581
b948ce8b
PE
15822012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1583
1584 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1585 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1586 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1587 * s/netbsd.h, s/sol2-6.h:
1588 Remove definition of GC_MARK_STACK, since the default now works.
1589 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1590 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1591 no longer the default.
1592 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1593
35dc09a1 15942012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1595
35dc09a1
GM
1596 * lread.c (lisp_file_lexically_bound_p):
1597 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 1598
35dc09a1
GM
15992012-04-14 Eli Zaretskii <eliz@gnu.org>
1600
1601 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1602 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1603
16042012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1605
1606 * nsterm.m (constrainFrameRect): Always constrain when there is only
1607 one screen (Bug#10962).
1608
bcd86815
KB
16092012-04-13 Ken Brown <kbrown@cornell.edu>
1610
1611 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1612
c25df26e
RT
16132012-04-13 Reuben Thomas <rrt@sc3d.org>
1614
1615 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1616
0fc59f1e
DC
16172012-04-11 Daniel Colascione <dancol@dancol.org>
1618
1619 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1620 against is gone. It's better to use vfork now so that when Cygwin
1621 gains a new, working vfork, we use it automatically (bug#10398).
1622
de8c03dc
SM
16232012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1624
1625 * window.c (save_window_save): Obey window-point-insertion-type.
1626
2f097256
GM
16272012-04-11 Glenn Morris <rgm@gnu.org>
1628
1629 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1630
453b951e
SM
16312012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1632
1633 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1634
75f1671a 16352012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
1636
1637 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1638 (force_quit_count): New var.
1639 (handle_interrupt): Use it.
1640
2a8ce227
JB
16412012-04-10 Juanma Barranquero <lekktu@gmail.com>
1642
1643 * w32.c (w32_delayed_load): Record the full path of the library
1644 being loaded (bug#10424).
1645
935396c0
GM
16462012-04-09 Glenn Morris <rgm@gnu.org>
1647
05920a43
GM
1648 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1649 not just in the obarray, before snarfing them. (Bug#11036)
1650
935396c0
GM
1651 * Makefile.in ($(leimdir)/leim-list.el):
1652 Pass EMACS rather than BUILT_EMACS.
1653
a18ecafa
TZ
16542012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1655
1656 * process.c (make_process):
1657 * process.h: Add integer `gnutls_handshakes_tried' member to
1658 process struct.
1659
6bbef4e5
JC
1660 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1661 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
1662
1663 * gnutls.c (gnutls_log_function2i): Convenience log function.
1664 (emacs_gnutls_read): Use new log functions,
1665 `gnutls_handshakes_tried' process member, and
1666 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1667 attempts per process (connection).
1668
b4d3bc10
CY
16692012-04-09 Chong Yidong <cyd@gnu.org>
1670
1671 * eval.c (Fuser_variable_p, user_variable_p_eh)
1672 (lisp_indirect_variable): Functions deleted.
1673 (Fdefvar): Caller changed.
1674
1675 * callint.c (Finteractive, Fcall_interactively):
1676 * minibuf.c (Fread_variable): Callers changed.
1677
70f4d973
EZ
16782012-04-09 Eli Zaretskii <eliz@gnu.org>
1679
1680 * xdisp.c (set_cursor_from_row): If the display string appears in
1681 the buffer at position that is closer to point than the position
1682 after the display string, display the cursor on the first glyph of
1683 the display string. Fixes cursor display when a 'display' text
1684 property immediately follows invisible text. (Bug#11094)
1685
cb3c2e3e
PE
16862012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1687
1688 composite.c: use 'double' consistently
1689 * composite.c (get_composition_id): Use 'double' consistently
1690 instead of converting 'float' to 'double' and vice versa; this is
1691 easier to understand and avoids a GCC warning.
1692
fd06db5d
GM
16932012-04-09 Glenn Morris <rgm@gnu.org>
1694
50fe702a
GM
1695 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1696 preparation for dumping it with emacs. (Bug#4789)
1697 (leimdir): New variable.
1698 ($(leimdir)/leim-list.el): New rule.
1699 (emacs$(EXEEXT)): Depend on leim-list.el.
1700
fd06db5d
GM
1701 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1702 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1703 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1704
55c131ee
AS
17052012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1706
1707 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1708 proper alignment.
1709
9209588f
JB
17102012-04-07 Juanma Barranquero <lekktu@gmail.com>
1711
1712 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1713 Remove unused local variable.
1714
e3fb2efb
PE
17152012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1716
1717 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1718 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1719 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1720 objects, as mark_maybe_pointer will catch them otherwise.
1721 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1722 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1723
b5385551
PE
17242012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1725
1726 Fix typo that broke non-Windows builds.
1727 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1728
9078ead6
EZ
17292012-04-07 Eli Zaretskii <eliz@gnu.org>
1730
1731 Support building on MS-Windows with libxml2.
1732
1733 * makefile.w32-in (OBJ2): Add xml.$(O).
1734 (GLOBAL_SOURCES): Add xml.c.
1735 ($(BLD)/xml.$(O)): New dependency list.
1736
1737 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1738 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1739 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1740 [!WINDOWSNT]: New macros.
1741 (init_libxml2_functions, libxml2_loaded_p): New functions.
1742 (parse_region): Call fn_xmlCheckVersion instead of using the macro
1743 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
1744 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
1745 Calls xmlCleanupParser only if libxml2 was loaded (or statically
1746 linked in).
6bbef4e5
JC
1747 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
1748 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
1749 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
1750
1751 * emacs.c: Don't include libxml/parser.h.
1752 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
1753 xmlCleanupParser directly.
1754
1755 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
1756
3811fdf3
EZ
17572012-04-07 Eli Zaretskii <eliz@gnu.org>
1758
1759 * indent.c (Fvertical_motion): If there is a display string at
1760 point, use it.vpos to compute how many lines to backtrack after
1761 move_it_to point. (Bug#11133)
1762
2f8e16b2
EZ
17632012-04-06 Eli Zaretskii <eliz@gnu.org>
1764
1765 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
1766 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
1767 about subtle differences between FETCH_CHAR* and STRING_CHAR*
1768 macros related to unification of CJK characters. For the details,
1769 see the discussion following the message here:
1770 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
1771
3d439cd1
CY
17722012-04-04 Chong Yidong <cyd@gnu.org>
1773
1774 * keyboard.c (Vdelayed_warnings_list): Doc fix.
1775
8bc53d00
EZ
17762012-04-01 Eli Zaretskii <eliz@gnu.org>
1777
1778 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
1779 instead of alloca. (Bug#11138)
1780
3b0512a3
AS
17812012-04-01 Andreas Schwab <schwab@linux-m68k.org>
1782
1783 * w32menu.c (is_simple_dialog): Properly check lisp types.
1784 (Bug#11141)
1785
8427ddd2
EZ
17862012-03-31 Eli Zaretskii <eliz@gnu.org>
1787
979022ef
EZ
1788 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
1789 position we get to after a call to move_it_to fails the
1790 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
1791 only if we wind up in a string from display property. (Bug#11063)
1792
a6b1c7cc
EZ
1793 * window.c (Fdelete_other_windows_internal): Invalidate the row
1794 and column information about mouse highlight, so that redisplay
1795 restores it after reallocating the glyph matrices. (Bug#7464)
1796
8427ddd2
EZ
1797 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
1798 string comes from a `display' text property, use the buffer
1799 position of that property as if we actually saw that position in
1800 the row's glyphs.
697ba24b
EZ
1801 (move_it_by_lines): Remove the assertion that
1802 "it->current_x == 0 && it->hpos == 0" which can be legitimately
1803 violated when there's a before-string at the beginning of a line.
1804 (Bug#11063)
8427ddd2 1805
65a0a738
EZ
18062012-03-30 Eli Zaretskii <eliz@gnu.org>
1807
1808 * xdisp.c (append_space_for_newline): If the default face was
1809 remapped, use the remapped face for the appended newline.
1810 (extend_face_to_end_of_line): Use the remapped default face for
1811 extending the face to the end of the line.
1812 (display_line): Call extend_face_to_end_of_line when the default
1813 face was remapped. (Bug#11068)
1814
581355cc
EZ
18152012-03-29 Eli Zaretskii <eliz@gnu.org>
1816
1817 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
1818
e8fc049f
SM
18192012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1820
1821 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
1822
4fb9a543
GM
18232012-03-27 Glenn Morris <rgm@gnu.org>
1824
1825 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
1826 Doc fixes.
1827
679910f1
KH
18282012-03-26 Kenichi Handa <handa@m17n.org>
1829
1830 * dispextern.h (struct glyph): Fix previous change. Change the
1831 bit length of glyphless.ch to 25 (Bug#11082).
1832
90d49b7f
CY
18332012-03-26 Chong Yidong <cyd@gnu.org>
1834
1835 * keyboard.c (Vselection_inhibit_update_commands): New variable.
1836 (command_loop_1): Use it; inhibit selection update for
1837 handle-select-window too (Bug#8996).
1838
f514f6f0
FP
18392012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
1840
e8fc049f 1841 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 1842
bf43fa51
KH
18432012-03-25 Kenichi Handa <handa@m17n.org>
1844
1845 * dispextern.h (struct glyph): Change the bit length of
1846 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
1847
8a0c01dd
EZ
18482012-03-24 Eli Zaretskii <eliz@gnu.org>
1849
1850 * s/ms-w32.h (tzname): Include time.h before redirecting to
1851 _tzname. Fixes the MSVC build. (Bug#9960)
1852
7d1c3a76
AS
18532012-03-24 Andreas Schwab <schwab@linux-m68k.org>
1854
8ed79523
AS
1855 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
1856 characters.
1857
7d1c3a76
AS
1858 * xterm.c (XTread_socket): Only modify handling_signal if
1859 !SYNC_INPUT. (Bug#11080)
1860
e99a9b8b
EZ
18612012-03-23 Eli Zaretskii <eliz@gnu.org>
1862
1863 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
1864 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
1865 when fetching a multibyte character consumes more bytes than
1866 CHAR_BYTES returns, due to unification of CJK characters in
1867 string_char. (Bug#11073)
1868
5063c0e1
TN
18692012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
1870
1871 * process.c (wait_reading_process_output): Handle pty disconnect
1872 by refraining from sending oneself a SIGCHLD (bug#10933).
1873
9f851fbd
CY
18742012-03-22 Chong Yidong <cyd@gnu.org>
1875
1876 * dispextern.h (struct it): New member string_from_prefix_prop_p.
1877
5063c0e1 1878 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
1879 Mark string as coming from a prefix property.
1880 (handle_face_prop): Use default face for prefix strings (Bug#4281).
1881 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
1882
fb5b8aca
CY
18832012-03-21 Chong Yidong <cyd@gnu.org>
1884
1885 * xfaces.c (Vface_remapping_alist): Doc fix.
1886
62356a1b
EZ
18872012-03-20 Eli Zaretskii <eliz@gnu.org>
1888
1889 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
1890 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
1891 Doc fixes.
62356a1b 1892
025de85b
CY
18932012-03-20 Chong Yidong <cyd@gnu.org>
1894
1895 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
1896 to reflect default non-nil value of redisplay-dont-pause.
1897
4827f94e
KH
18982012-03-19 Kenichi Handa <handa@m17n.org>
1899
1900 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
1901 it fit in a valid range (Bug#11003).
1902
e50a24a2
EZ
19032012-03-18 Eli Zaretskii <eliz@gnu.org>
1904
1905 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
1906 that is not from display property, accept the row as a "cursor
1907 row" if one of the string's character has a non-nil `cursor'
1908 property. Fixes cursor positioning when there are newlines in
1909 overlay strings, e.g. in icomplete.el. (Bug#11035)
1910
9af5ed87
PE
19112012-03-12 Paul Eggert <eggert@cs.ucla.edu>
1912
1913 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
1914
d1f55f16
CY
19152012-03-12 Chong Yidong <cyd@gnu.org>
1916
1917 * eval.c (inhibit_lisp_code): Rename from
1918 inhibit_window_configuration_change_hook; move from window.c.
1919
1920 * xfns.c (unwind_create_frame_1, Fx_create_frame):
1921 * window.c (run_window_configuration_change_hook)
1922 (syms_of_window): Callers changed.
1923
66c5eebd
CY
19242012-03-11 Chong Yidong <cyd@gnu.org>
1925
413df973
CY
1926 * keymap.c (Fkey_description): Doc fix (Bug#9700).
1927
66c5eebd
CY
1928 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
1929
1de11f56
CY
19302012-03-10 Chong Yidong <cyd@gnu.org>
1931
1932 * frame.c (other_visible_frames): Don't assume the selected frame
1933 is visible (Bug#10955).
1934
cae07000
SM
19352012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
1936
1937 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
1938
89c94350
JD
19392012-03-08 Jan Djärv <jan.h.d@swipnet.se>
1940
1941 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
1942 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
1943 zero (Bug#10954).
1944
999dd333
GM
19452012-03-03 Glenn Morris <rgm@gnu.org>
1946
01a6dcc8 1947 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 1948
de0100f2
EZ
19492012-03-02 Eli Zaretskii <eliz@gnu.org>
1950
1951 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
1952 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
1953 (redisplay_window, next_element_from_string): Fix typos in
1954 comments.
3e441275
EZ
1955 (redisplay_window): Pass to move_it_vertically the margin in
1956 pixels, not in screen lines.
de0100f2 1957
96a72ee9
GM
19582012-03-02 Glenn Morris <rgm@gnu.org>
1959
1960 * buffer.c (buffer-list-update-hook): Doc fix.
1961
312508d7
EZ
19622012-02-29 Eli Zaretskii <eliz@gnu.org>
1963
1964 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
1965 push_it before setting up the iterator for the first overlay
1966 string, even if we have an empty string loaded.
1967 (next_overlay_string): If there's an empty string on the iterator
1968 stack, pop the stack. (Bug#10903)
1969
27f3c637
PE
19702012-02-25 Paul Eggert <eggert@cs.ucla.edu>
1971
1972 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
1973 Suggested by Stefan Monnier in
1974 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
1975 * alloc.c (widen_to_Lisp_Object): New static function.
1976 (mark_memory): Also mark Lisp_Objects by fetching pointer words
1977 and widening them to Lisp_Objects. This would work even if
1978 USE_LSB_TAG is defined and wide integers are used, which might
1979 happen in a future version of Emacs.
1980
3c9dfce6
CY
19812012-02-25 Chong Yidong <cyd@gnu.org>
1982
fa74b241
CY
1983 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
1984 Doc fix.
1985
3c9dfce6
CY
1986 * xselect.c (Fx_selection_exists_p): Doc fix.
1987 (x_clipboard_manager_save_all): Print an informative message
1988 before saving to clipboard manager.
1989
9486df08
CY
19902012-02-24 Chong Yidong <cyd@gnu.org>
1991
1992 * keyboard.c (process_special_events): Handle all X selection
1993 requests in kbd_buffer, not just the next one (Bug#8869).
1994
f01d3321
CY
19952012-02-23 Chong Yidong <cyd@gnu.org>
1996
1997 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
1998 call when setting menu-bar-lines and tool-bar-lines parameters.
1999 (unwind_create_frame_1): New helper function.
2000
2001 * window.c (inhibit_window_configuration_change_hook): New var.
2002 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2003 (syms_of_window): Initialize it.
f01d3321 2004
86b847b6
CY
20052012-02-22 Chong Yidong <cyd@gnu.org>
2006
2007 * xterm.c (x_draw_image_relief): Add missing type check for
2008 Vtool_bar_button_margin (Bug#10743).
2009
a59225b1
CY
20102012-02-21 Chong Yidong <cyd@gnu.org>
2011
2012 * fileio.c (Vfile_name_handler_alist): Doc fix.
2013
2014 * buffer.c (Fget_file_buffer): Protect against invalid file
2015 handler return value.
2016
310f5bd4
PE
20172012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2018
cb3a28cc
PE
2019 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2020 when computing $valmask.
2021
310f5bd4
PE
2022 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2023 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2024 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2025 It's useless in that case, and it can cause problems on hosts
2026 that allocate halves of EMACS_INT values separately.
2027 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2028 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2029 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2030 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2031 it avoids undefined behavior on hosts where shifting right by more
2032 than the word width has undefined behavior.
2033
2375c96a
CY
20342012-02-19 Chong Yidong <cyd@gnu.org>
2035
2036 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2037 (Funhandled_file_name_directory, Ffile_name_as_directory)
2038 (Fdirectory_file_name, Fexpand_file_name)
2039 (Fsubstitute_in_file_name): Protect against invalid file handler
2040 return values (Bug#10845).
2041
3eb49e71
EZ
20422012-02-18 Eli Zaretskii <eliz@gnu.org>
2043
2044 * .gdbinit (pitx): Fix incorrect references to fields of the
2045 iterator stack.
2046
7b926f3f
CY
20472012-02-17 Chong Yidong <cyd@gnu.org>
2048
2049 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2050
11273115
PE
20512012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2052
2053 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2054 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2055
c3a70e2b
CY
20562012-02-15 Chong Yidong <cyd@gnu.org>
2057
2058 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2059 marked as special. Also, starting docstrings with * is obsolete.
2060
0ca43699
AS
20612012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2062
2063 * gnutls.c (emacs_gnutls_write): Fix last change.
2064
2e8f3c56
LI
20652012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2066
2067 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2068 send_process.
2069
af70074f
SM
20702012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2071
2072 * keymap.c (Fsingle_key_description): Handle char ranges.
2073
95986d52
CY
20742012-02-12 Chong Yidong <cyd@gnu.org>
2075
afd83bd1
CY
2076 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2077 as that creates a dangerous corner case.
2078
95986d52
CY
2079 * window.c (Fdelete_window_internal): Invalidate the mouse
2080 highlight (Bug#9904).
2081
bd7da63e
GM
20822012-02-12 Glenn Morris <rgm@gnu.org>
2083
2084 * xselect.c (Fx_own_selection_internal)
2085 (Fx_get_selection_internal, Fx_disown_selection_internal)
2086 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2087 * nsselect.m (Fx_own_selection_internal)
2088 (Fx_disown_selection_internal, Fx_selection_exists_p)
2089 (Fx_selection_owner_p, Fx_get_selection_internal):
2090 Sync docs and argument specs with the xselect.c versions.
2091
77abcbc2
LI
20922012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2093
2094 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2095
90b671e2
EZ
20962012-02-11 Eli Zaretskii <eliz@gnu.org>
2097
1c0ca0b7
EZ
2098 * w32select.c (Fx_selection_exists_p): Sync doc string and
2099 argument list with xselect.c. (Bug#10783)
2100
2101 * w16select.c (Fx_selection_exists_p): Sync doc string and
2102 argument list with xselect.c. (Bug#10783)
90b671e2 2103
49241268
GM
21042012-02-10 Glenn Morris <rgm@gnu.org>
2105
2106 * fns.c (Fsecure_hash): Doc fix.
2107
f998bbe7 21082012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2109
2110 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2111
0992bd9c
CY
21122012-02-07 Chong Yidong <cyd@gnu.org>
2113
2114 * buffer.c (Fbuffer_local_variables)
2115 (buffer_lisp_local_variables): Handle unbound vars correctly;
2116 don't let Qunbound leak into Lisp.
2117
af008560
GM
21182012-02-07 Glenn Morris <rgm@gnu.org>
2119
dd605cc4
GM
2120 * image.c (Fimagemagick_types): Doc fix.
2121
af008560
GM
2122 * image.c (imagemagick-render-type): Change it from a lisp object
2123 to an integer. Move the doc here from the lisp manual.
2124 Treat all values not equal to 0 the same.
2125
1449fa1d
CY
21262012-02-06 Chong Yidong <cyd@gnu.org>
2127
2128 * doc.c (store_function_docstring): Avoid applying docstring of
2129 alias to base function (Bug#2603).
2130
3723ec07
AS
21312012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2132
2133 * .gdbinit (pp1, pv1): Remove redundant defines.
2134 (pr): Use pp.
2135
79c1cc1e
CY
21362012-02-04 Chong Yidong <cyd@gnu.org>
2137
2138 * nsterm.m: Declare a global (Bug#10694).
2139
d7f29f8e
EZ
21402012-02-04 Eli Zaretskii <eliz@gnu.org>
2141
cae07000
SM
2142 * w32.c (get_emacs_configuration_options):
2143 Include --enable-checking, if specified, in the return value.
d7f29f8e 2144
3b95a6f9
MR
21452012-02-04 Martin Rudalics <rudalics@gmx.at>
2146
2147 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2148 after rounding frame sizes. (Bug#9723)
2149
d6fa96a6
EZ
21502012-02-04 Eli Zaretskii <eliz@gnu.org>
2151
2152 * keyboard.c (adjust_point_for_property): Don't position point
2153 before BEGV. (Bug#10696)
2154
df0b2940
PE
21552012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2156
2157 Handle overflow when computing char display width (Bug#9496).
2158 * character.c (char_width): Return EMACS_INT, not int.
2159 (char_width, c_string_width): Check for overflow when
2160 computing the width; this is possible now that individual
2161 characters can have unbounded width. Problem introduced
2162 by merge from Emacs 23 on 2012-01-19.
2163
6bee44d6
MA
21642012-02-02 Michael Albinus <michael.albinus@gmx.de>
2165
2166 * dbusbind.c (Fdbus_register_method): Mention the return value
2167 :ignore in the docstring.
2168
44f92739
GM
21692012-02-02 Glenn Morris <rgm@gnu.org>
2170
1b9f60cc
GM
2171 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2172
44f92739
GM
2173 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2174 Unconditionally set to t. (Bug#10673)
2175 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2176 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2177 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2178
c5d3843c
KH
21792012-02-02 Kenichi Handa <handa@m17n.org>
2180
2181 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2182 0, do not call append_composite_glyph.
2183
159462d4 21842012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
2185
2186 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2187 NULL (Bug#6988).
2188 (x_produce_glyphs): If the component of a composition is a null
2189 string, set it->pixel_width to 1 to avoid zero-width glyph.
2190
78cef877
EZ
21912012-02-01 Eli Zaretskii <eliz@gnu.org>
2192
2193 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2194 first 2 arguments are identical. This makes inserting large
2195 output from a subprocess an order of magnitude faster on
2196 MS-Windows, where all sbrk'ed memory is always contiguous.
2197
97897668
GM
21982012-01-31 Glenn Morris <rgm@gnu.org>
2199
2200 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 2201 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
2202 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2203
31fd3586
GM
22042012-01-29 Glenn Morris <rgm@gnu.org>
2205
2206 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2207
0e24a8b2
CY
22082012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2209
2210 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2211
cc0adcb0
CY
22122012-01-28 Chong Yidong <cyd@gnu.org>
2213
2214 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2215
acc28cb9
CY
22162012-01-26 Chong Yidong <cyd@gnu.org>
2217
9c69cfb7
CY
2218 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2219
acc28cb9
CY
2220 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2221 repeat counts (Bug#10507).
2222
48da7392
GM
22232012-01-26 Glenn Morris <rgm@gnu.org>
2224
2225 * lread.c (syms_of_lread): Doc fix.
2226
14af5f7f
CY
22272012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2228
2229 * coding.c (encode_designation_at_bol): Change return value to
2230 EMACS_INT.
2231
0b21c100
CY
22322012-01-25 Chong Yidong <cyd@gnu.org>
2233
2234 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2235
3c2907f7
CY
22362012-01-21 Chong Yidong <cyd@gnu.org>
2237
2238 * floatfns.c (Fcopysign): Make the second argument non-optional,
2239 since nil is not allowed anyway.
2240
959ad23f
AS
22412012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2242
2243 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2244 (send_process): Likewise.
2245
34a02f46
MR
22462012-01-19 Martin Rudalics <rudalics@gmx.at>
2247
2248 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
2249 (Vwindow_persistent_parameters): Do not use Qstate.
2250 Rewrite doc-strings.
34a02f46 2251
1259009a 22522012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
2253
2254 * character.c (char_width): New function.
70d4fdf6
GM
2255 (Fchar_width, c_string_width, lisp_string_width):
2256 Use char_width (Bug#9496).
25ed9e61 2257
6a6ee00d
MR
22582012-01-16 Martin Rudalics <rudalics@gmx.at>
2259
2260 * window.c (Vwindow_persistent_parameters): New variable.
2261 (Fset_window_configuration, save_window_save): Handle persistent
2262 window parameters.
2263
c85efaf7
EZ
22642012-01-14 Eli Zaretskii <eliz@gnu.org>
2265
2266 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2267 thrashing the stack of the thread. (Bug#9087)
2268
5944709e
PE
22692012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2270
2271 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2272
e71f5d99
EZ
22732012-01-11 Eli Zaretskii <eliz@gnu.org>
2274
2275 * xdisp.c (rows_from_pos_range): Handle the case where the
2276 highlight ends on a newline. (Bug#10464)
2277 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2278 he end column for display of highlight that ends on a newline
2279 before a R2L line.
2280
ce316182
GM
22812012-01-11 Glenn Morris <rgm@gnu.org>
2282
2283 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2284 from load-path also when installation-directory is nil. (Bug#10208)
2285
5b43da69
GM
22862012-01-10 Glenn Morris <rgm@gnu.org>
2287
74cc8ff9
GM
2288 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2289
7d8d6e4e
GM
2290 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2291 Update template values to be closer to their typical values these days.
5b43da69 2292
a0db8d43
EZ
22932012-01-09 Eli Zaretskii <eliz@gnu.org>
2294
2295 * xdisp.c (rows_from_pos_range): Accept additional argument
2296 DISP_STRING, and accept any glyph in a row whose object is that
2297 string as eligible for mouse highlight. Fixes mouse highlight of
2298 display strings from overlays. (Bug#10464)
2299
9a0115ab 23002012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 2301
b9110d6a 2302 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
2303 * fileio.c (auto_saving_dir_umask): New static var.
2304 (Fmake_directory_internal): Use it.
2305 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2306 creating the directory. The old code temporarily assigns
2307 too-generous permissions to the directory.
2308 (do_auto_save_eh): Clear it.
b9110d6a 2309 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
2310 that the var is always cleared.
2311
6c1bd3f3
EZ
23122012-01-07 Eli Zaretskii <eliz@gnu.org>
2313
2314 * search.c (scan_buffer): Pass character positions to
2315 know_region_cache, not byte positions. (Bug#6540)
2316
069d2b50
L
23172012-01-07 LynX <_LynX@bk.ru> (tiny change)
2318
2319 * w32.c (sys_rename): Report EXDEV when rename of a directory
2320 fails because the target is on another logical disk. (Bug#10284)
2321
75bf0d33
DB
23222012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2323
2324 * xterm.c (x_embed_request_focus): New function.
2325
2326 * xterm.h: Add prototype.
2327
2328 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2329
1c6e5a32
GM
23302012-01-05 Glenn Morris <rgm@gnu.org>
2331
2332 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2333
651e947e
EZ
23342012-01-01 Eli Zaretskii <eliz@gnu.org>
2335
2336 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2337 Load gnutls_transport_set_lowat only if GnuTLS version is below
2338 2.11.1.
2339 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2340 GnuTLS versions below 2.11.1.
2341
3778cdd8
AL
23422011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2343
2344 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2345 to the doc string advising against its use for altering the way
2346 windows are scrolled.
2347
0e5317f7
KH
23482011-12-28 Kenichi Handa <handa@m17n.org>
2349
2350 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2351 coding-system ASCII compatible only when it does not produce BOM
2352 on encoding (Bug#10383).
2353
93d5ca1f
JD
23542011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2355
2356 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2357 can scroll.
2358 (create_and_show_popup_menu): Always use menu_position_func for
2359 Gtk3 (Bug#10361).
2360
ca22b785
AS
23612011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2362
2363 * callint.c (Fcall_interactively): Don't truncate prompt string.
2364
d048e1e6
EZ
23652011-12-23 Eli Zaretskii <eliz@gnu.org>
2366
2367 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2368 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 2369 resumed from there (after widening). (Bug#10360)
d048e1e6 2370
5ccaba1f
JD
23712011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2372
2373 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2374
204ee57f
JD
23752011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2376
b81d40f0
JB
2377 * nsterm.m (x_free_frame_resources):
2378 Release f->output_data.ns->miniimage.
204ee57f
JD
2379 (ns_index_color): Fix indentation. Do not retain
2380 color_table->colors[i].
2381
2382 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2383 before returning.
2384
2385 * nsfns.m (x_set_background_color): Assign return value from
2386 ns_index_color to face-background instead of NSColor*.
2387 (ns_implicitly_set_icon_type): Fix indentation.
2388 Change assignment in for loop to comparison.
2389
2390 * emacs.c (ns_pool): New variable.
2391 (main): Assign ns_pool.
2392 (Fkill_emacs): Call ns_release_autorelease_pool.
2393
2394 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2395 autorelease fdesc, release fdAttrs and tdict.
2396 (ns_get_covering_families): Release charset.
2397 (ns_findfonts): Release NSFontDescriptor created with new.
2398 (ns_uni_to_glyphs): Fix indentation.
2399 (setString): Release attrStr before assigning new value.
2400
c803b2b7
JD
24012011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2402
678f4426
JD
2403 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2404 and NS_IMPL_COCOA.
2405 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2406 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2407
cd394be1 24082011-12-18 David Reitter <reitter@cmu.edu>
678f4426 2409
5fecd5fc
JD
2410 * nsterm.m (ns_term_init): Subscribe for notifications
2411 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2412 to method trackingNotification in EmacsMenu.
2413
2414 * nsmenu.m (trackingMenu): New variable.
3771cb17 2415 (trackingNotification): New method (from Aquamacs).
5fecd5fc 2416 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 2417 from Aquamacs (Bug#7030).
678f4426
JD
2418
24192011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 2420
c803b2b7
JD
2421 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2422 (symbol_to_nsstring): Fix indentation.
2423 (ns_symbol_to_pb): New function.
cae07000
SM
2424 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2425 (Fns_rotate_cut_buffers_internal): Remove.
2426 (Fns_store_selection_internal): Rename from
c803b2b7
JD
2427 Fns_store_cut_buffer_internal.
2428 (ns_get_foreign_selection, Fx_own_selection_internal)
2429 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
2430 (Fns_get_selection_internal, Fns_store_selection_internal):
2431 Use ns_symbol_to_pb and check if return value is nil.
2432 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2433 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
2434 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2435 renamed to Sns_store_selection_internal.
2436 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2437 and remove this function.
2438 (ns_handle_selection_clear): Remove, never used.
2439 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2440 here.
2441
e1b01a3a
KB
24422011-12-17 Ken Brown <kbrown@cornell.edu>
2443
2444 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2445 GID is unknown (Bug#10257).
2446
2adb6e85
PE
24472011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2448
2449 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2450 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2451 which caused a build failure on GNU/Linux IA-64. This problem was
2452 introduced by my 2011-10-07 patch.
2453
d1d7b339
JL
24542011-12-15 Juri Linkov <juri@jurta.org>
2455
2456 * image.c (imagemagick_error): New function. (Bug#10112)
2457 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2458 Use `imagemagick_error' where ImageMagick functions return
2459 `MagickFalse'.
2460 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2461 proper order.
2462
100d5755
KH
24632011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2464
2465 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2466 fill background (Bug#8992).
2467
454592a6
MR
24682011-12-13 Martin Rudalics <rudalics@gmx.at>
2469
2470 * window.c (Vwindow_combination_resize)
2471 (Vwindow_combination_limit): Use t instead of non-nil in
2472 doc-strings.
61d4b438
MR
2473 (Vrecenter_redisplay): Add first sentence of doc-string on
2474 separate line.
53524d93 2475 (Frecenter): Fix doc-string typo.
454592a6 2476
3633e3aa
KH
24772011-12-11 Kenichi Handa <handa@m17n.org>
2478
2479 * coding.c (Funencodable_char_position): Pay attention to the
2480 buffer text relocation (Bug#9389).
2481
7b9d523a 24822011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 2483
7b9d523a
JD
2484 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2485 gtk_init (Bug#10100).
2486
b73189c6
EZ
24872011-12-10 Eli Zaretskii <eliz@gnu.org>
2488
2489 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2490 IT->string is nil. (Bug#10263)
2491
f7dfe5d6
JD
24922011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2493
83faebb4
JD
2494 * nsterm.h (x_free_frame_resources): Declare.
2495
f7dfe5d6
JD
2496 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2497 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2498
2499 * nsterm.h (ns_get_defaults_value): Declare.
2500
2501 * nsterm.m (ns_default): Call ns_get_defaults_value.
2502
7cd4e72c
EZ
25032011-12-09 Eli Zaretskii <eliz@gnu.org>
2504
2505 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2506 (Bug#10170)
2507
b34d7317
YM
25082011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2509
2510 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2511 that where the value of an _OBJC_* symbol points to is in the .bss
2512 section (Bug#10240).
2513
76470ad1
KH
25142011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2515
2516 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 2517 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 2518
745fff94
KH
25192011-12-08 Kenichi Handa <handa@m17n.org>
2520
2521 * ftfont.c (get_adstyle_property): Fix previous change
2522 (Bug#10233).
2523
6e44397c
JB
25242011-12-07 Juanma Barranquero <lekktu@gmail.com>
2525
2526 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2527 dirs from the default value of EMACSLOADPATH (bug#10208).
2528
7efa6272
GM
25292011-12-07 Glenn Morris <rgm@gnu.org>
2530
2531 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2532 installation and source directories as well. (Bug#10208)
2533
f6fc4d87
CY
25342011-12-06 Chong Yidong <cyd@gnu.org>
2535
2536 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2537
2bf26180
GM
25382011-12-06 Glenn Morris <rgm@gnu.org>
2539
2540 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2541 as an error, not just -1. (Bug#10217)
2542
3a6ad4f0
CY
25432011-12-05 Chong Yidong <cyd@gnu.org>
2544
2545 * keyboard.c (process_special_events): New function.
2546 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2547
75a3b399
PE
25482011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2549
2550 * coding.c (encode_designation_at_bol): Don't use uninitialized
2551 local variable (Bug#9318).
2552
c3c9e25e
KH
25532011-12-05 Kenichi Handa <handa@m17n.org>
2554
2555 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2556 return Qnil (Bug#8046, Bug#10193).
2557
5eb05ea3
KH
25582011-12-05 Kenichi Handa <handa@m17n.org>
2559
2560 * coding.c (encode_designation_at_bol): New args charbuf_end and
2561 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
2562 (coding_set_source): Return how many bytes coding->source was
2563 relocated.
2564 (coding_set_destination): Return how many bytes
2565 coding->destination was relocated.
2566 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 2567 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
2568
25692011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2570
2571 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2572 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2573 macro (Bug#9318).
2574
25752011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2576
2577 The following changes are to fix Bug#9318.
2578
a79703f5 2579 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
2580 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2581 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 2582 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 2583
7dbda6df
JB
25842011-12-05 Juanma Barranquero <lekktu@gmail.com>
2585
2586 * lisp.h (process_quit_flag): Fix external declaration.
2587
6d5eb5b0
SM
25882011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2589
2590 Don't macro-inline non-performance-critical code.
2591 * eval.c (process_quit_flag): New function.
2592 * lisp.h (QUIT): Use it.
2593
a0c3fad0
JD
25942011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2595
2596 * nsfns.m (get_geometry_from_preferences): New function.
2597 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2598
6c07aac2
AS
25992011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2600
2601 * emacs.c (Qkill_emacs): Define.
2602 (syms_of_emacs): Initialize it.
2603 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2604 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
2605 (quit_throw_to_read_char): Add parameter `from_signal'.
2606 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
2607 * lisp.h (QUIT): Call Fkill_emacs if requested.
2608
c052ead4
JD
26092011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2610
2611 * widget.c (update_wm_hints): Return if wmshell is null.
2612 (widget_update_wm_size_hints): New function.
2613
2614 * widget.h (widget_update_wm_size_hints): Declare.
2615
2616 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2617 widget_update_wm_size_hints (Bug#10104).
2618
9e49252b
EZ
26192011-12-03 Eli Zaretskii <eliz@gnu.org>
2620
2621 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2622 before a newline, prepare the bidi iterator for consuming the
2623 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 2624 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 2625
02b16839
JL
26262011-12-02 Juri Linkov <juri@jurta.org>
2627
2628 * search.c (Fword_search_regexp): New Lisp function created from
2629 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2630 (Fword_search_backward, Fword_search_forward)
2631 (Fword_search_backward_lax, Fword_search_forward_lax):
2632 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2633 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2634
0068070e
SM
26352011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2636
2637 * fileio.c (Finsert_file_contents): Move after-change-function call
2638 to before the "handled:" label, since all "goto handled" appear in
2639 cases where the *-change-functions have already been properly called
2640 (bug#10117).
2641
3360a3fc
AS
26422011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2643
2644 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2645 waiting for input. (Bug#10169)
2646
73d6c093
EZ
26472011-11-30 Eli Zaretskii <eliz@gnu.org>
2648
2649 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2650 verifies glyph row's hash code--we have just reallocated the
2651 glyphs, so their contents can be complete garbage. (Bug#10164)
2652
febe6bea
JB
26532011-11-30 Juanma Barranquero <lekktu@gmail.com>
2654
2655 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2656
801a4313
EZ
26572011-11-30 Eli Zaretskii <eliz@gnu.org>
2658
2659 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2660 attributes are tested _before_ calling verify_row_hash, to protect
2661 against GCC re-ordering of the tests. (Bug#10164)
2662
2b56b87e
JD
26632011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2664
2665 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2666
2667 * xterm.c (handle_one_xevent): Only set async_visible and friends
2668 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 2669 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
2670 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2671
dbf31225
PE
26722011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2673
2674 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2675 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2676 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2677 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2678 All uses changed to use GCPRO1 etc.
2679 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2680 Revert to old implementation (i.e., before 2011-03-11).
2681
1305621b
YM
26822011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2683
2684 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2685 of scroll runs so as to avoid assigning disabled bogus rows and
2686 unnecessary graphics copy operations.
2687
8c9afb46
EZ
26882011-11-27 Eli Zaretskii <eliz@gnu.org>
2689
2690 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2691 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2692 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2693 (malloc, free, realloc, calloc): Redirect to e_* only when
2694 compiling Emacs.
2695
2696 * lisp.h (GCTYPEBITS): Move before first use.
2697 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2698 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2699 this macro definition.
2700
2701 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2702 _MSC_VER.
2703
54e9e3bf
JD
27042011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2705
6d5eb5b0
SM
2706 * gtkutil.c (xg_create_frame_widgets):
2707 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
2708 present with Gtk+ 2.0.
2709
83aca1cb
PE
27102011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2711
2712 * fileio.c (Finsert_file_contents): Undo previous change; see
2713 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2714
5b76caa4
PE
27152011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2716
2717 Rename locals to avoid shadowing.
2718 * fileio.c (Finsert_file_contents):
2719 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2720 * process.c (wait_reading_process_output):
2721 Rename inner 'proc' to 'p' to avoid shadowing.
2722 Indent for consistency with usual Emacs style.
2723
8c535114
EZ
27242011-11-25 Eli Zaretskii <eliz@gnu.org>
2725
2726 * xdisp.c (redisplay_window): If cursor row is not fully visible
2727 after recentering, and scroll-conservatively is set to a large
2728 number, scroll window by a few more lines to make the cursor fully
2729 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
2730 (start_display): Don't move to the next line if the display should
2731 start at a newline that is part of a display vector or an overlay
2732 string. (Bug#10119)
8c535114 2733
fa4fdb5c
JL
27342011-11-24 Juri Linkov <juri@jurta.org>
2735
2736 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2737 after the `MagickPingImage' call. (Bug#10112)
2738
90ec88df
CY
27392011-11-23 Chong Yidong <cyd@gnu.org>
2740
2741 * window.c (Fcoordinates_in_window_p): Accept only live windows.
2742
56e2e794
MR
27432011-11-23 Martin Rudalics <rudalics@gmx.at>
2744
2745 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
2746 making another buffer current. (Bug#10114)
2747
b6e64c41
GM
27482011-11-23 Glenn Morris <rgm@gnu.org>
2749
2750 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
2751
6b21de18
CY
27522011-11-23 Chong Yidong <cyd@gnu.org>
2753
2754 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
2755 using it (Bug#5984).
2756
b12cd789
EZ
27572011-11-22 Eli Zaretskii <eliz@gnu.org>
2758
2759 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
2760 and header-lines, as they don't have one computed for them.
2761 (Bug#10098)
2762
2763 * .gdbinit (prow): Make displayed values more self-explaining.
2764 Add row's hash code.
2765
261b6fd4
LMI
27662011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
2767
2768 * process.c (wait_reading_process_output): Fix asynchrounous
2769 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 2770 (wait_reading_process_output): Add comment and URL.
261b6fd4 2771
e7cfd277
JD
27722011-11-21 Jan Djärv <jan.h.d@swipnet.se>
2773
2774 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
2775
a9b9b7f5
CY
27762011-11-21 Chong Yidong <cyd@gnu.org>
2777
2778 * window.c (Fnext_window, Fprevious_window): Doc fix.
2779
b0d15b4f
SM
27802011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2781
2782 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
2783
fe7a3057
JB
27842011-11-20 Juanma Barranquero <lekktu@gmail.com>
2785
2786 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
2787
d2999b1a
MR
27882011-11-20 Martin Rudalics <rudalics@gmx.at>
2789
2790 * window.c (Fset_window_combination_limit): Rename argument
2791 STATUS to LIMIT.
2792 (Vwindow_combination_limit): Remove "status" from doc-string.
2793
d5ff9cd0
AS
27942011-11-20 Andreas Schwab <schwab@linux-m68k.org>
2795
2796 * m/ibms390.h: Remove.
2797 * m/ibms390x.h: Don't include "ibms390.h".
2798
a5bb9bd3
SM
27992011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2800
2801 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
2802 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
2803
cd1181db
JB
28042011-11-20 Juanma Barranquero <lekktu@gmail.com>
2805
2806 * casetab.c (Fset_case_table):
2807 * charset.c (Fcharset_after): Fix typos.
2808
615a3b8d 28092011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 2810
17e845af
PE
2811 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
2812 Otherwise, valgrind does not work on some platforms.
2813 Problem reported by Andreas Schwab in
6a0bf43d
PE
2814 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
2815 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
2816 is set, removing the need for VIRT_ADDRESS_VARIES.
2817 (PURE_P): Use a more-efficient implementation that needs just one
2818 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
2819 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
2820 to 4 (xorl, subq, cmpq, setbe).
2821 * alloc.c (pure): Always extern now, since that's the
2822 VIRT_ADDR_VARIES behavior.
2823 (PURE_POINTER_P): Use a single comparison, not two, for
2824 consistency with the new puresize.h.
2825 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
2826 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
2827 Remove VIRT_ADDR_VARIES no longer needed.
2828
f8fe6f96
EZ
28292011-11-19 Eli Zaretskii <eliz@gnu.org>
2830
2831 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
2832 (erase_phys_cursor, update_window_cursor, show_mouse_face)
2833 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
2834 behave as if the cursor position were at the window margin.
2835
2836 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
2837 and the cursor position is out of bounds, behave as if the cursor
2838 position were at the window margin. (Bug#10075)
2839
df05a53c
CY
28402011-11-18 Chong Yidong <cyd@gnu.org>
2841
2842 * window.c (Fwindow_combination_limit): Make first argument
2843 non-optional, since it is meaningless for live windows like the
2844 selected window.
61ccba97 2845
2071918e
DA
28462011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
2847
2848 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
2849
b50a28de
SM
28502011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
2851
2852 * intervals.c: Fix grafting over the whole buffer (bug#10071).
2853 (graft_intervals_into_buffer): Simplify.
2854
015137db
EZ
28552011-11-18 Eli Zaretskii <eliz@gnu.org>
2856
2857 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
2858 hash values of the two rows.
2859 (copy_row_except_pointers): Preserve the used[] arrays and the
2860 hash values of the two rows. (Bug#10035)
68c95424 2861 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
2862
2863 * xdisp.c (row_hash): New function, body extracted from
2864 compute_line_metrics.
2865 (compute_line_metrics): Call row_hash, instead of computing the
2866 hash code inline.
2867
2868 * dispnew.c (verify_row_hash): Call row_hash for computing the
2869 hash code of a row, instead of duplicating code from xdisp.c.
2870
2871 * dispextern.h (row_hash): Add prototype.
2872
a2addb04
TH
28732011-11-18 Tassilo Horn <tassilo@member.fsf.org>
2874
2875 * frame.c (delete_frame): Don't delete the terminal when the last
2876 X frame is closed if emacs is built with GTK toolkit.
2877
df85d315
JB
28782011-11-17 Juanma Barranquero <lekktu@gmail.com>
2879
2880 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
2881
a0c2d0ae
MR
28822011-11-17 Martin Rudalics <rudalics@gmx.at>
2883
2884 * window.c (Vwindow_splits): Rename to
2885 Vwindow_combination_resize. Suggested by Juri Linkov.
2886 (Fsplit_window_internal): Use Vwindow_combination_resize instead
2887 of Vwindow_splits.
2888
58179cce
JB
28892011-11-16 Juanma Barranquero <lekktu@gmail.com>
2890
7877f373
JB
2891 * nsfns.m (Fns_font_name):
2892 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 2893
b6f67890
MR
28942011-11-16 Martin Rudalics <rudalics@gmx.at>
2895
2896 * window.h (window): Rename slot "nest" to "combination_limit".
2897 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
2898 (Fset_window_nest): Rename to Fset_window_combination_limit.
2899 (Vwindow_nest): Rename to Vwindow_combination_limit.
2900 (recombine_windows, make_parent_window, make_window)
2901 (Fsplit_window_internal, saved_window)
2902 (Fset_window_configuration, save_window_save): Rename all
2903 occurrences of window_nest to window_combination_limit.
2904
c7015153
JB
29052011-11-15 Juanma Barranquero <lekktu@gmail.com>
2906
2907 * image.c (imagemagick_load_image): Fix typo.
2908
322ad6ec
EZ
29092011-11-14 Eli Zaretskii <eliz@gnu.org>
2910
2911 * xdisp.c (display_line): Move the call to
2912 highlight_trailing_whitespace before the call to
2913 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
2914 faces of all the glyphs to compute ROW's hash value.
2915 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 2916
f067b8ec
JB
29172011-11-14 Juanma Barranquero <lekktu@gmail.com>
2918
2919 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
2920 just return (bug#10044).
2921
1e5b2111
EZ
29222011-11-12 Eli Zaretskii <eliz@gnu.org>
2923
7ef3cbd5
EZ
2924 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
2925 with user-defined heap size. Bump the default size of the temacs
2926 heap to 27MB, to avoid memory warning when running temacs.
2927 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
2928
1e5b2111
EZ
2929 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
2930 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
2931 (verify_row_hash) [XASSERTS]: New function.
2932 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
2933 that the hash value of glyph rows is correct.
1e5b2111 2934
89d61221
MR
29352011-11-12 Martin Rudalics <rudalics@gmx.at>
2936
2937 * window.h (window): Remove splits slot.
2938 * window.c (Fwindow_splits, Fset_window_splits): Remove.
2939 (Fdelete_other_windows_internal, make_parent_window)
2940 (make_window, Fsplit_window_internal, Fdelete_window_internal)
2941 (Fset_window_configuration, save_window_save): Don't deal with
2942 split status of windows.
2943 (saved_window): Remove splits slot.
2944 (Vwindow_splits): Rewrite doc-string.
2945
97f18cc8
JD
29462011-11-11 Jan Djärv <jan.h.d@swipnet.se>
2947
2948 * xfns.c (unwind_create_frame):
2949 * nsfns.m (unwind_create_frame):
2950 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
2951 Vframe_list (Bug#9999).
2952
22a648b4
DA
29532011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
2954
0b381c7e 2955 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 2956
659afede
KH
29572011-11-11 Kenichi Handa <handa@m17n.org>
2958
2959 * callproc.c (Fcall_process): Set the member dst_multibyte of
2960 process_coding.
2961
9ac0394b
KH
29622011-11-11 Johan Bockgård <bojohan@gnu.org>
2963
2964 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
2965 avoid a crash (bug#9496).
2966
2fbdc249
CY
29672011-11-09 Chong Yidong <cyd@gnu.org>
2968
2969 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
2970 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
2971
ac6b1f81
PE
29722011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2973
2974 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
2975
09db192c
PE
29762011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2977
2978 Avoid some portability problems by eschewing 'extern inline' functions.
2979 The trivial performance wins aren't worth the portability hassles; see
2980 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
2981 et seq.
2982 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2983 (window_box_width, window_box_left, window_box_left_offset)
2984 (window_box_right, window_box_right_offset): Undo previous change,
2985 by removing the "extern"s.
2986 * intervals.c (adjust_intervals_for_insertion)
2987 (adjust_intervals_for_deletion): Undo previous change,
2988 making these static again.
2989 (offset_intervals, temp_set_point_both, temp_set_point)
2990 (copy_intervals_to_string): No longer inline.
2991 * xdisp.c (window_text_bottom_y, window_box_width)
2992 (window_box_height, window_box_left_offset)
2993 (window_box_right_offset, window_box_left, window_box_right)
2994 (window_box): No longer inline.
2995
105216ed
CY
29962011-11-08 Chong Yidong <cyd@gnu.org>
2997
2998 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
2999 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3000 Signal an error if not a live window.
105216ed
CY
3001 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3002 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3003
ae9e237f
JB
30042011-11-07 Juanma Barranquero <lekktu@gmail.com>
3005
3006 * lisp.h (syms_of_abbrev): Remove declaration.
3007 Reported by CHENG Gao <chenggao@royau.me>.
3008
c7aa8333
EZ
30092011-11-07 Eli Zaretskii <eliz@gnu.org>
3010
3011 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3012 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3013 of temacs in GUI mode.
3014
be7f5545
MR
30152011-11-07 Martin Rudalics <rudalics@gmx.at>
3016
3017 * window.h: Declare delete_all_child_windows instead of
3018 delete_all_subwindows.
3019 * window.c (Fwindow_nest, Fset_window_nest)
3020 (Fset_window_new_total, Fset_window_new_normal)
3021 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3022 (delete_all_subwindows): Rename to delete_all_child_windows.
3023 (Fdelete_other_windows_internal, Fset_window_configuration):
3024 Call delete_all_child_windows instead of delete_all_subwindows.
3025 * frame.c (delete_frame): Call delete_all_child_windows instead
3026 of delete_all_subwindows.
3027
ca78dc43
PE
30282011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3029
3030 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3031 This is also needed for porting to any host where GC_MARK_STACK is
3032 not GC_MAKE_GCPROS_NOOPS.
3033 (which_symbols): Use it.
3034
a0241d01
KH
30352011-11-07 Kenichi Handa <handa@m17n.org>
3036
3037 * coding.c (coding_set_destination): Check coding->src_pos only
3038 when coding->src_object is a buffer (bug#9910).
3039
3040 * process.c (send_process): Set the member src_multibyte of coding
3041 to 0 (bug#9911) when sending a unibyte text.
3042
3043 * callproc.c (Fcall_process): Set the member src_multibyte of
3044 process_coding to 0 (bug#9912).
3045
a64bfdfa 30462011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3047
3048 * xmenu.c (cleanup_widget_value_tree): New function.
3049 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3050 calling free_menubar_widget_value_tree directly (Bug#9830).
3051
cb41b32a
PE
30522011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3053
3054 Fix some portability problems with 'inline'.
3055 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3056 (window_box_width, window_box_left, window_box_left_offset)
3057 (window_box_right, window_box_right_offset): Declare extern.
3058 Otherwise, these inline functions do not conform to C99 and
3059 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3060 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3061 * intervals.c (adjust_intervals_for_insertion)
3062 (adjust_intervals_for_deletion): Now extern, because otherwise the
3063 extern inline functions 'offset_intervals' couldn't refer to it.
3064 (static_offset_intervals): Remove.
3065 (offset_intervals): Rewrite using the old contents of
3066 static_offset_intervals. The old version didn't conform to C99
3067 because an extern inline function contained a reference to an
3068 identifier with static linkage.
3069
b7041366
AS
30702011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3071
3072 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3073 GC.
3074
88a37c4d
EZ
30752011-11-06 Eli Zaretskii <eliz@gnu.org>
3076
3077 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3078 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3079 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3080 return Qleft_to_right.
3081
49745b39
CY
30822011-11-06 Chong Yidong <cyd@gnu.org>
3083
3084 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3085 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3086 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3087 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3088 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3089 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3090 (Fwindow_vscroll): Doc fix.
3091 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3092 argument, since it makes no sense to pass a live window and for
3093 consistency with window-child.
3094
1f05cd82
CS
30952011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3096
3097 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3098 support MSVC.
3099
22610910
JR
31002011-11-05 Jason Rumney <jasonr@gnu.org>
3101
3102 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3103 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3104 fonts (Bug#6029).
3105 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3106 bitwise arithmetic preventing use of unicode-sip and non-truetype
3107 opentype fonts.
3108
a06776b2
EZ
31092011-11-05 Eli Zaretskii <eliz@gnu.org>
3110
3ad924ba
EZ
3111 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3112 "emacs"-only part.
3113
a06776b2
EZ
3114 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3115 initialization code to keep similarity to xfns.c after changes
3116 from 2011-11-05.
3117
c9e7db78
JD
31182011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3119
a97f8f3f
JD
3120 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3121 (unwind_create_frame): New function (Bug#9943).
3122 (Fx_create_frame): Restructure code to be more similar to the one in
3123 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3124 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3125 Move terminal->reference_count++ just before making the frame official
3126 (Bug#9943).
3127
3128 * nsterm.m (x_free_frame_resources): New function.
3129 (x_destroy_window): Move code to x_free_frame_resources.
3130
c9e7db78 3131 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3132 (Fx_create_frame, x_create_tip_frame):
3133 Move terminal->reference_count++ just before making the frame
75f1671a 3134 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3135 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3136
a6fc3b5c
EZ
31372011-11-05 Eli Zaretskii <eliz@gnu.org>
3138
3139 Support MSVC build with newer versions of Visual Studio.
3140 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3141 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3142 nt/gmake.defs.
3143
3144 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3145 which are not supported by MSVC.
3146 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3147 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3148 bitfields.
3149 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3150 types in bitfields.
3151 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3152
3153 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3154
58179cce 31552011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3156
3157 Support MSVC build with newer versions of Visual Studio.
3158 * w32.c: Don't include w32api.h for MSVC.
3159 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3160
3161 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3162 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3163 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3164 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3165 e_* cousins.
3166 (alloca) [_MSC_VER]: Define to _alloca.
3167
3168 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3169
3170 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3171
a58c13ed
EZ
31722011-11-04 Eli Zaretskii <eliz@gnu.org>
3173
3174 * xdisp.c (note_mouse_highlight): If either of
3175 previous/next-single-property-change returns nil, treat that as
3176 the beginning or the end of the buffer. (Bug#9955)
3177
fe0b6370
JD
31782011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3179
a58c13ed 3180 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
3181 label is not null (Bug#9951).
3182 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3183 may be NULL.
3184
89bd5ee1
EZ
31852011-11-04 Eli Zaretskii <eliz@gnu.org>
3186
3187 * window.c (Fwindow_body_size): Mention in the doc string that the
3188 return value is in frame's canonical units. (Bug#9949)
3189
84c3edb9
EZ
31902011-11-03 Eli Zaretskii <eliz@gnu.org>
3191
4e2fb5c7
EZ
3192 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3193
84c3edb9 3194 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 3195 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 3196 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 3197
bc17a887
EZ
31982011-11-01 Eli Zaretskii <eliz@gnu.org>
3199
3200 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3201 Don't stop backward scan on the continuation glyph, even though
3202 its CHARPOS is positive.
6d5eb5b0
SM
3203 (mouse_face_from_buffer_pos, note_mouse_highlight):
3204 Rename cover_string to disp_string.
bc17a887 3205
4ee88440
MR
32062011-11-01 Martin Rudalics <rudalics@gmx.at>
3207
3208 * window.c (temp_output_buffer_show): Don't use
3209 Vtemp_buffer_show_specifiers.
3210 (Vtemp_buffer_show_specifiers): Remove unused variable.
3211
c2ff3c02
EZ
32122011-10-30 Eli Zaretskii <eliz@gnu.org>
3213
3214 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3215 past the beginning of the current glyph matrix.
3216
58179cce 32172011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
3218
3219 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3220 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3221 HAVE_GTK3 (Bug#9869).
b77a6a7f 3222
3b574623
JD
3223 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3224 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3225
b77a6a7f
JD
3226 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3227
3228 * xterm.c: Declare x_handle_net_wm_state to return int.
3229 (handle_one_xevent): Check if we are iconified but don't have
3230 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3231 (get_current_wm_state): Return non-zero if not hidden,
3232 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3233 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3234 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3235 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3236
196e41e4
PE
32372011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3238
3239 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3240 so that this new function doesn't get optimized away by a
3241 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3242
021f2e1a
AS
32432011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3244
3245 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3246
8b058d44
EZ
32472011-10-29 Eli Zaretskii <eliz@gnu.org>
3248
3249 Fix the `xbytecode' command.
3250 * .gdbinit (xprintbytestr): New command.
b50a28de 3251 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
3252 (xbytecode): Print the byte-code string as well.
3253
4452fb80
EZ
32542011-10-29 Kim Storm <storm@cua.dk>
3255
8b058d44
EZ
3256 * alloc.c (which_symbols): New function.
3257
21b72067
AS
32582011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3259
3260 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3261 line. (Bug#9903)
3262
83ed7b5c
GM
32632011-10-29 Glenn Morris <rgm@gnu.org>
3264
3265 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3266 Not clear what it was for, and it causes various bugs. (Bug#9839)
3267
5a7a728b
EZ
32682011-10-28 Eli Zaretskii <eliz@gnu.org>
3269
3270 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3271 possible random value that matches one of those tested as
3272 condition to clear the mouse face.
3273
d3d0842f
CY
32742011-10-28 Chong Yidong <cyd@gnu.org>
3275
3276 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3277
31b39d13
DN
32782011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3279
3280 * window.c (make_window): Initialize phys_cursor_on_p.
3281
9aba6043
SM
32822011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3283
3284 * lisp.h (struct Lisp_Symbol): Update comments.
3285
c20992f4
JB
32862011-10-28 Juanma Barranquero <lekktu@gmail.com>
3287
3288 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3289
db4f02f2
EZ
32902011-10-28 Eli Zaretskii <eliz@gnu.org>
3291
3292 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3293 <oslsachem@gmail.com> for helping to debug this.
3294
3295 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3296 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3297 (g_b_init_get_glyph_outline_w): New static variables.
3298 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3299 (GetGlyphOutlineW_Proc): New typedefs.
3300 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
3301 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3302 New functions.
3303 (w32font_open_internal, compute_metrics):
3304 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
3305 instead of calling the "wide" APIs directly.
3306
3307 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3308
3309 * w32.h (syms_of_w32font): Add prototype.
3310
87e68db4
JB
33112011-10-27 Juanma Barranquero <lekktu@gmail.com>
3312
3313 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3314 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3315 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3316 (Fmove_to_window_line): Doc fix.
3317
435c1d67
CY
33182011-10-27 Chong Yidong <cyd@gnu.org>
3319
3320 * process.c (make_process): Set gnutls_state to NULL.
3321
3322 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3323 non-NULL, regardless of GNUTLS_INITSTAGE.
3324 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3325 an error. Set process slots as soon as we allocate them.
3326
3327 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3328
9c6c6f49
CY
33292011-10-27 Chong Yidong <cyd@gnu.org>
3330
9aba6043
SM
3331 * gnutls.c (emacs_gnutls_deinit): New function.
3332 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
3333 (Fgnutls_deinit, Fgnutls_boot): Use it.
3334
3335 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3336 (deactivate_process): Call emacs_gnutls_deinit.
3337
657d08d3
JB
33382011-10-27 Juanma Barranquero <lekktu@gmail.com>
3339
3340 * image.c (x_create_x_image_and_pixmap):
3341 * w32.c (sys_rename, w32_delayed_load):
3342 * w32font.c (fill_in_logfont):
3343 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3344
5430d399
JB
33452011-10-26 Juanma Barranquero <lekktu@gmail.com>
3346
3347 * w32fns.c (w32_default_color_map): New function,
3348 extracted from Fw32_default_color_map.
a7ef684b 3349 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 3350
fe0055fa
PE
33512011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3352
3353 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3354
e6346438
SM
33552011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3356
3357 * keyboard.c (test_undefined): New function (bug#9751).
3358 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3359
e112cc37
ET
33602011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3361
3362 * sysdep.c (init_sys_modes): Fix the check for the controlling
3363 terminal (Bug#6649).
3364
7b5d6677
EZ
33652011-10-20 Eli Zaretskii <eliz@gnu.org>
3366
3367 * dispextern.h (struct bidi_it): New member next_en_type.
3368
3369 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3370 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3371 current character, check also for next_en_type being WEAK_EN.
3372 (bidi_resolve_weak): Don't enter the expensive loop if the current
3373 position is before next_en_pos. Record the bidi type of the first
3374 non-ET, non-BN character we find, in addition to its position.
3375 (bidi_level_of_next_char): Invalidate next_en_type when
3376 next_en_pos is over-stepped.
3377
7da0b018
PE
33782011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3379
3380 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3381 * editfns.c: Rewrite current-time-zone so that it invokes
3382 the equivalent of (format-time-string "%Z") to get the time zone name.
3383 This fixes a bug when the time zone name contains characters that
3384 need converting from the system time locale to Emacs internal format.
3385 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3386 that patch fixed format-time-string to do the conversion, but
3387 I forgot to fix current-time-zone.
3388 (format_time_string): New function, containing most of
3389 what Fformat_time_string used to contain.
3390 (Fformat_time_string): Rewrite in terms of format_time_string.
3391 This doesn't change this function's behavior.
3392 (current-time-zone): Rewrite to use format_time_string.
3393 This fixes the bug reported by Michael Schierl in
3394 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3395 Jason Rumney's 2007-06-07 change worked around this bug, but
3396 didn't fix it.
3397 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3398
8547b010
EZ
33992011-10-19 Eli Zaretskii <eliz@gnu.org>
3400
3401 * xdisp.c (start_display): If the character at POS is displayed
3402 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
3403 (try_window_reusing_current_matrix): If a line ends in a display
3404 vector or the next line starts in a display vector, continue
3405 redrawing the window even though the character position of
3406 start_row was reached.
8547b010
EZ
3407 (Bug#9771, part 2)
3408
4e948d15
CY
34092011-10-18 Chong Yidong <cyd@gnu.org>
3410
3411 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3412 with nobreak-char-display too.
3413
4787455f
EZ
34142011-10-18 Eli Zaretskii <eliz@gnu.org>
3415
3416 Fix part 3 of bug#9771.
3417 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3418 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3419 non-neutral characters if the current character is a paragraph
3420 separator (a.k.a. Newline). This avoids running the same
3421 expensive loop twice, once when we consume the preceding newline
3422 and the other time when the line actually needs to be displayed.
3423 Avoid the loop when we see neutrals on the base embedding level
3424 following a character whose directionality is the same as the
3425 paragraph's. This avoids running the expensive loop when a line
3426 ends in a long sequence of neutrals, like control characters.
3427 Add assertion against STRONG_AL type. Slightly rearrange code
3428 that determines the type of a neutral given the first non-neutral
3429 that follows it.
3430 (bidi_level_of_next_char): Set next_en_pos to zero when
3431 invalidating its info.
3432
2c91f553
EZ
34332011-10-17 Eli Zaretskii <eliz@gnu.org>
3434
3435 * xdisp.c (push_display_prop): Determine whether to record string
3436 or buffer position by IT->string, not by IT->method. Allow
3437 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
3438 (move_it_vertically_backward): Don't look for character position
3439 immediately after the newline when in a continuation line.
3440 (Bug#9771, part 1)
2c91f553 3441
c7b08b0d
MR
34422011-10-15 Martin Rudalics <rudalics@gmx.at>
3443
3444 * window.c (coordinates_in_window): Rewrite and delabelize
3445 vertical border check. (Bug#5357) (Bug#9618)
3446
6b02f655
SM
34472011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3448
3449 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3450 errors in XSetWindowBorder (bug#9310).
3451
81d40c92
DA
34522011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3453
3454 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3455 avoid crash when xmalloc overrun checking is enabled.
3456
d4172c3b
EZ
34572011-10-13 Eli Zaretskii <eliz@gnu.org>
3458
3459 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3460 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3461 cursor motion with <left> and <right> arrow keys.
3462
3463 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3464 some callers set that themselves.
3465
b00eea75
EZ
34662011-10-12 Eli Zaretskii <eliz@gnu.org>
3467
3468 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3469 display string and the previous row comes from the same string and
3470 is empty. (Bug#9739) (Bug#9738)
3471
8fe012c4
SM
34722011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3473
3474 * doc.c (get_doc_string): Encode file name (bug#9735).
3475
0074aef2
EZ
34762011-10-12 Eli Zaretskii <eliz@gnu.org>
3477
79beb178
EZ
3478 * bidi.c (bidi_level_of_next_char):
3479 * xdisp.c (get_visually_first_element): Remove old incorrect
3480 comments regarding the Unicode Line Separator character.
3481
0074aef2
EZ
3482 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3483
6e4b3fbe
DA
34842011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3485
3486 * alloc.c (Fgc_status): Do not access beyond zombies array
3487 boundary if nzombies > MAX_ZOMBIES.
3488 * alloc.c (dump_zombies): Add missing format specifier.
3489
0324f3af
PE
34902011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3491
b5525cac
PE
3492 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3493 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3494
0324f3af
PE
3495 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3496 Some packages use them to denote characters with modifiers.
3497
e9b5f888
AS
34982011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3499
3500 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3501 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3502 matching a pp-number. Rename parameter var to var1.
3503
127827c0
SM
35042011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3505
3506 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3507
c8fd3bd0
GM
35082011-10-08 Glenn Morris <rgm@gnu.org>
3509
3510 * callint.c (Fcall_interactively): Give a more explicit error for the
3511 'c' case with a non-character input. (Bug#8479)
3512
352ec8ff
EZ
35132011-10-08 Eli Zaretskii <eliz@gnu.org>
3514
03669ccb
EZ
3515 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3516 lines.
7061c986
EZ
3517 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3518 lines that are hscrolled on the left.
03669ccb 3519
352ec8ff
EZ
3520 * dispnew.c (buffer_posn_from_coords): Account for a possible
3521 presence of header-line. (Bug#4426)
3522
a66cfb1c
SM
35232011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3524
6b02f655
SM
3525 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3526 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 3527
7c5ee88e
PE
35282011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3529
3530 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3531 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3532 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3533 this makes Emacs dump core during garbage collection on rare
3534 occasions. sizeof is obviously inferior to offsetof here, so
3535 stick with offsetof.
3536 (GC_POINTER_ALIGNMENT): New macro.
3537 (mark_memory): Omit 3rd (offset) arg; caller changed.
3538 Don't assume EMACS_INT alignment is the same as pointer alignment.
3539
df1bbe5b
SM
35402011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3541
3542 * keyboard.c (read_key_sequence_remapped): New var.
3543 (read_key_sequence): Compute remapping in the right buffer.
3544 (command_loop_1): Use read_key_sequence's remapping directly.
3545
51553db6
SM
35462011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3547
32c1fffd
SM
3548 * dired.c (file_name_completion): Don't expand file name.
3549 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3550 before checking file name handler.
3551
51553db6
SM
3552 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3553 they've been requested explicitly (bug#9591).
3554
b6bd1599 35552011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
3556
3557 * keymap.c (Fsingle_key_description): Use make_specified_string
3558 instead of build_string to build string from push_key_description.
3559 (Bug#5193)
3560
f701dc2a
PE
35612011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3562
4222c55d
PE
3563 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3564 This fixes a Y2038 bug on 64-bit hosts.
3565 * buffer.c (reset_buffer):
3566 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3567 (Fclear_buffer_auto_save_failure):
3568 Use 0, not -1, to represent an unset failure time, since time_t
3569 might not be signed.
3570
f701dc2a
PE
3571 Remove dependency on glibc malloc internals.
3572 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3573 Move back here from lisp.h, but with their new implementations.
3574 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3575 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3576 * charset.c (charset_table_init): New static var.
3577 (syms_of_charset): Use it instead of xmalloc. This removes a
3578 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3579 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3580 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3581 Move back to alloc.c.
3582 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3583 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3584
9ceebf39
JD
35852011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3586
3587 * nsterm.m (windowDidResize): Call x_set_window_size only when
3588 ns_in_resize is true. Otherwise set pixelwidth/height and
3589 call change_frame_size (Bug#9628).
3590
cb993c58
PE
35912011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3592
3930c88b
PE
3593 Port --enable-checking=all to Fedora 14 x86-64.
3594 * charset.c (syms_of_charset): Also account for glibc malloc's
3595 internal overhead when calculating the initial malloc maximum.
3596
cb993c58
PE
3597 Port --enable-checking=all to Fedora 14 x86.
3598 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3599 Move to lisp.h.
3600 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3601 (overrun_check_realloc, overrun_check_free):
3602 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3603 That way, xmalloc returns a properly-aligned pointer even if
3604 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3605 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3606 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3607 into account when calculating the initial malloc maximum.
3608 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3609 Move here from alloc.c, so that charset.c can use it too.
3610 Properly align; the old code wasn't right for common 32-bit hosts
3611 when configured with --enable-checking=all.
3612 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3613 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3614
31bed486
EZ
36152011-09-29 Eli Zaretskii <eliz@gnu.org>
3616
04c70788 3617 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
3618 use EDOM.
3619
fbcaa2f3
EZ
36202011-09-28 Eli Zaretskii <eliz@gnu.org>
3621
3622 * xdisp.c (compute_display_string_end): If there's no display
3623 string at CHARPOS, return -1.
3624
3625 * bidi.c (bidi_fetch_char): When compute_display_string_end
3626 returns a negative value, treat the character as a normal
3627 character not covered by a display string. (Bug#9624)
3628
a239d4e9
JB
36292011-09-28 Juanma Barranquero <lekktu@gmail.com>
3630
3631 * lread.c (Fread_from_string): Fix typo in docstring.
3632
88652fd5
EZ
36332011-09-27 Eli Zaretskii <eliz@gnu.org>
3634
3635 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3636 newline, reseat the iterator instead of bidi-iterating there one
3637 character at a time. (Bug#9610)
32c1fffd
SM
3638 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3639 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 3640
ed497dd4
AS
36412011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3642
3643 * lread.c (readevalloop): Use correct code for NBSP.
3644 (read1): Likewise. (Bug#9608)
3645
b2bf61aa
MA
36462011-09-25 Michael Albinus <michael.albinus@gmx.de>
3647
3648 * dbusbind.c (Fdbus_register_signal): When service is not
3649 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3650
32bbb17c
GM
36512011-09-25 Glenn Morris <rgm@gnu.org>
3652
3653 * buffer.c (truncate-lines): Doc fix.
3654
94e0933e
CY
36552011-09-24 Chong Yidong <cyd@stupidchicken.com>
3656
3657 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3658 (Fset_window_next_buffers): Doc fix.
3659
cddde921
GM
36602011-09-24 Glenn Morris <rgm@gnu.org>
3661
3662 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3663
1260aef1
PE
36642011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3665
25b4bfa0
PE
3666 Fix minor problems found by static checking.
3667 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
3668 * indent.c (Fvertical_motion): Fix == vs = typo.
3669
e3cbd34b
EZ
36702011-09-24 Eli Zaretskii <eliz@gnu.org>
3671
a66cfb1c
SM
3672 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3673 Default value is now t. Doc fix.
6bf7006f 3674
e3cbd34b 3675 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 3676 logic when moving up, not only when moving down. Fix the
e3cbd34b 3677 confusing name and values of the it_overshoot_expected variable;
32c1fffd 3678 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
3679
3680 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3681 CHARPOS is covered by a display string which includes newlines.
3682 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3683 is covered by a display string with embedded newlines.
3684
a3de0cbd
MA
36852011-09-24 Michael Albinus <michael.albinus@gmx.de>
3686
3687 * dbusbind.c (Fdbus_register_signal): Add match rule to
3688 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
3689 (Fdbus_register_method, Vdbus_registered_objects_table):
3690 Fix docstring.
a3de0cbd 3691
b260039d
JM
36922011-09-24 Jim Meyering <meyering@redhat.com>
3693
32c1fffd 3694 do not ignore write error for any output size
b260039d
JM
3695 The previous change was incomplete.
3696 While it makes emacs --batch detect the vast majority of stdout
3697 write failures, errors were still ignored whenever the output size is
3698 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3699 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3700 && echo FAIL: ignored write error
3701 FAIL: ignored write error
3702 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3703 && echo FAIL: ignored write error
3704 FAIL: ignored write error
3705 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3706
8eca8a7c
AS
37072011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3708
3709 * emacs.c (Fkill_emacs): In noninteractive mode exit
3710 non-successfully if a write error occurred on stdout. (Bug#9574)
3711
3341db62
EZ
37122011-09-21 Eli Zaretskii <eliz@gnu.org>
3713
3714 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3715 the xassert test.
3716
3717 * dispextern.h (struct it): Update the comment documenting what
3718 can it->OBJECT be.
3719
8c203dbf
EZ
37202011-09-20 Eli Zaretskii <eliz@gnu.org>
3721
3722 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3723 a display string, extend search for cursor position to end of row.
3724 (find_row_edges): If the row ends in a newline from a display
3725 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3726 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
3727 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3728 non-empty line. Fixes confusing cursor motion with arrow keys at
3729 the beginning of a line that starts with whitespace.
8c203dbf 3730
a4824228
LMI
37312011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3732
3733 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3734 (bug#9493).
3735
33ed493b
CY
37362011-09-18 Chong Yidong <cyd@stupidchicken.com>
3737
3738 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3739 boolean (Bug#9154).
3740
56cd55c8
EZ
37412011-09-18 Eli Zaretskii <eliz@gnu.org>
3742
3743 * xdisp.c (display_line): Record maximum and minimum buffer
3744 positions even if no glyphs were produced (e.g., by a zero-width
3745 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
3746 buffer positions that will be removed from the glyph row because
3747 they don't fit.
c02dcedf
EZ
3748 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
3749 column is beyond frame width: don't subtract 1 "pixel" when
3750 computing width of the stretch.
3e62b7e0
EZ
3751 (reseat_at_next_visible_line_start): Undo the change made on
3752 2011-09-17 that saved paragraph information and restored it after
3753 the call to `reseat'. (Bug#9545)
56cd55c8 3754
5ed99d36 37552011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
3756
3757 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
3758 and turn window cursor on if cleared (Bug#9415).
3759
5ed99d36 37602011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
3761
3762 * search.c (boyer_moore): Take unibyte characters from pattern
3763 literally. (Bug#9458)
3764
9bade7b2
EZ
37652011-09-18 Eli Zaretskii <eliz@gnu.org>
3766
3767 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
3768
e5e9d610
PE
37692011-09-18 Paul Eggert <eggert@cs.ucla.edu>
3770
87e4427a
PE
3771 Fix minor problem found by static checking.
3772 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
3773 initialized, to pacify gcc -Wuninitialized.
3774
e5e9d610
PE
3775 * fileio.c: Report proper errno when syscall falls.
3776 (Finsert_file_contents): Save and restore errno,
3777 so that report_file_error outputs the correct diagnostic.
3778 (Fwrite_region) [CLASH_DETECTION]: Likewise.
3779
a1674f0b
EZ
37802011-09-18 Eli Zaretskii <eliz@gnu.org>
3781
3782 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
3783
fbfb6dd4
EZ
37842011-09-17 Eli Zaretskii <eliz@gnu.org>
3785
3786 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
3787 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
3788
bb187662
EZ
37892011-09-17 Eli Zaretskii <eliz@gnu.org>
3790
1137e8b8 3791 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 3792 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
3793
3794 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
3795 (bidi_find_paragraph_start): Search back for paragraph beginning
3796 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
3797 (bidi_move_to_visually_next): Only trigger paragraph-related
3798 computations when the last character is a newline or at EOB, not
3799 just any NEUTRAL_B. (Bug#9470)
3800
bb187662
EZ
3801 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
3802 truncated lines if point is covered by a display string. (Bug#9524)
3803
2e621251
PE
38042011-09-16 Paul Eggert <eggert@cs.ucla.edu>
3805
3806 * xselect.c: Relax test for outgoing X longs (Bug#9498).
3807 (cons_to_x_long): New function.
3808 (lisp_data_to_selection_data): Use it. Correct the test for
3809 short-versus-long data; it was negated. Break out of vector
3810 loop, for efficiency, when a long datum is discovered.
3811
91a15bc6
SM
38122011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
3813
3814 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
3815
b41c3a35
EZ
38162011-09-16 Eli Zaretskii <eliz@gnu.org>
3817
3818 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
3819 GCC PR/17406) by declaring this function with external scope.
3820
7812ba2d
PE
38212011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3822
3823 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
3824 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
3825
cf7edc2a
AS
38262011-09-15 Andreas Schwab <schwab@linux-m68k.org>
3827
3828 * editfns.c (Fformat): Correctly handle text properties on "%%".
3829
bd01620e
EZ
38302011-09-15 Eli Zaretskii <eliz@gnu.org>
3831
3832 * xterm.c (x_draw_composite_glyph_string_foreground):
3833 * w32term.c (x_draw_composite_glyph_string_foreground):
3834 * term.c (encode_terminal_code):
3835 * composite.c (composition_update_it, get_composition_id):
3836 * xdisp.c (get_next_display_element)
3837 (fill_composite_glyph_string): Add comments about special meaning
3838 of TAB characters in a composition.
3839
a02719a3
PE
38402011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3841
3842 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
3843 This occurs when processing a multibyte format.
3844 Problem reported by Wolfgang Jenker.
a02719a3 3845
72589a3c
JB
38462011-09-15 Johan Bockgård <bojohan@gnu.org>
3847
3848 * xdisp.c (try_cursor_movement): Only check for exact match if
3849 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
3850
1c14176c
PE
38512011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3852
3853 Remove unused external symbols.
3854 * dispextern.h (calc_pixel_width_or_height): Remove decl.
3855 * xdisp.c (calc_pixel_width_or_height): Now static.
3856 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
3857 * indent.c (check_display_width):
3858 * w32term.c: Fix comment to match code.
3859 * xterm.c, xterm.h (x_catching_errors): Remove.
3860
d2eea5b5
PE
38612011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3862
3863 * xselect.c: Use signed conversions more consistently (Bug#9498).
3864 (selection_data_to_lisp_data): Assume incoming selection data are
3865 signed integers, not unsigned. This is to be consistent with
3866 outgoing selection data, which was modified to use signed integers
3867 in as part of the fix to Bug#9196 in response to Jan D.'s comment
3868 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
3869 expects long, not unsigned long.
3870
46888499
EZ
38712011-09-14 Eli Zaretskii <eliz@gnu.org>
3872
3873 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
3874 computation of loop end. Reported by Johan Bockgård
3875 <bojohan@gnu.org>.
3876
ef8ef9fb
CY
38772011-09-13 Chong Yidong <cyd@stupidchicken.com>
3878
3879 * frame.c (Fother_visible_frames_p): Function deleted.
3880
fa819fed
EZ
38812011-09-12 Eli Zaretskii <eliz@gnu.org>
3882
3883 * indent.c (compute_motion): Process display vector front to back
3884 rather than the other way around. (Bug#2496)
3885
2ba8e008
SM
38862011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
3887
3888 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
3889
20f53c69
CY
38902011-09-11 Chong Yidong <cyd@stupidchicken.com>
3891
3892 * minibuf.c (Fread_from_minibuffer): Doc fix.
3893
d562d7a4
EZ
38942011-09-11 Eli Zaretskii <eliz@gnu.org>
3895
3896 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
3897 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
3898
1c4d7f3d
LMI
38992011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3900
3901 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
3902 value for non-existent files.
3903
b885bf36
EZ
39042011-09-11 Eli Zaretskii <eliz@gnu.org>
3905
3906 * fileio.c (Finsert_file_contents): If the file cannot be opened,
3907 set its "size" to -1. This will set the modtime_size field of
3908 the corresponding buffer to -1, which is what
3909 verify-visited-file-modtime expects for files that do not exist.
3910 (Bug#9139)
3911
6612f0bf
PE
39122011-09-11 Paul Eggert <eggert@cs.ucla.edu>
3913
3914 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
3915 here ...
3916 * lisp.h: ... from here. push_key_description is no longer
3917 defined in keyboard.c, so its declaration should not be in
3918 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
3919 logically belongs with push_key_description.
3920
dfb3f755
PE
39212011-09-10 Paul Eggert <eggert@cs.ucla.edu>
3922
3923 * buffer.h: Include <sys/types.h> instead of <time.h>.
3924 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
3925 Problem reported by Herbert J. Skuhra.
3926
3134906c
LMI
39272011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
3928
3929 * xml.c (parse_region): Make the parsing work for
3930 non-comment-starting XML files again (bug#9144).
3931
8d903f4e
AS
39322011-09-10 Andreas Schwab <schwab@linux-m68k.org>
3933
3934 * image.c (gif_load): Fix calculation of bottom and right corner.
3935 (Bug#9468)
3936
80ad64f4
EZ
39372011-09-10 Eli Zaretskii <eliz@gnu.org>
3938
3939 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
3940 redisplay in small windows.
3941
208a048d
EZ
39422011-09-09 Eli Zaretskii <eliz@gnu.org>
3943
3944 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
3945
9b1c252e
MR
39462011-09-08 Martin Rudalics <rudalics@gmx.at>
3947
3948 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
3949 Operate on live windows only.
3950
2949f33b
JB
39512011-09-08 Juanma Barranquero <lekktu@gmail.com>
3952
3953 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
3954
e08dcafd
EZ
39552011-09-07 Eli Zaretskii <eliz@gnu.org>
3956
3957 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
3958 only under bidi iteration.
3959
115b96bd
JD
39602011-09-07 Jan Djärv <jan.h.d@swipnet.se>
3961
3962 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
3963
c8199d0f
PE
39642011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3965
3966 isnan: Fix porting problem to Solaris 10 with bundled gcc.
3967 Without this fix, the command to link temacs failed due to an
3968 undefined symbol __builtin_isnan. This is because
3969 /usr/include/iso/math_c99.h #defines isnan(x) to
3970 __builtin_isnan(x), but the bundled gcc, which identifies itself
3971 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
3972 a __builtin_isnan.
3973 * floatfns.c (isnan): #undef, and then #define to a clone of
3974 what's in data.c.
3975 (Fisnan): Always define, since it's always available now.
3976 (syms_of_floatfns): Always define isnan at the Lisp level.
3977
e39b275c 39782011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
3979
3980 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
3981
b2db44d9 39822011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 3983
f4af5137 3984 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
3985 The previous code assumed that file offsets (off_t values) fit in
3986 EMACS_INT variables, which is not true on typical 32-bit hosts.
3987 The code messed up by falsely reporting buffer overflow in cases
3988 such as (insert-file-contents "big" nil 1 2) into an empty buffer
3989 when "big" contains more than 2**29 bytes, even though this
3990 inserts just one byte and does not overflow the buffer.
3991 (Finsert_file_contents): Store file offsets as off_t
3992 values, not as EMACS_INT values. Check for overflow when
3993 converting between EMACS_INT and off_t. When checking for
3994 buffer overflow or for overlap, take the offsets into account.
3995 Don't use EMACS_INT for small values where int suffices.
3996 When checking for overlap, fix a typo: ZV was used where
3997 ZV_BYTE was intended.
3998 (Fwrite_region): Don't assume off_t fits into 'long'.
3999 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4000
ecfc0a49
MA
40012011-09-05 Michael Albinus <michael.albinus@gmx.de>
4002
4003 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4004
6511acf2 40052011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4006
0999621a 4007 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4008
4009 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4010 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4011 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4012 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4013 (modify_event_symbol): Do not assume that the length of
4014 name_alist_or_stem is safe to alloca and fits in int.
4015 (Fexecute_extended_command): Likewise for function name and binding.
4016 (Frecursion_depth): Wrap around reliably on integer overflow.
4017 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4018 since some callers pass EMACS_INT values.
4019 (Fsingle_key_description): Don't crash if symbol name contains more
4020 than MAX_ALLOCA bytes.
4021 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4022 (get_minibuffer): Arg is now EMACS_INT, not int.
4023 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4024 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4025 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4026
2be7d702
PE
4027 * dbusbind.c (signature_cat): New function.
4028 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4029 Do not overrun buffer; instead, report string overflow.
4030
9d1df220
PE
4031 * dispnew.c (add_window_display_history): Don't overrun buffer.
4032 Truncate instead; this is OK since it's just a log.
4033
33ef5c64
PE
4034 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4035 even if the time zone offset is outlandishly large.
4036 Don't mishandle offset == INT_MIN.
4037
66c6fdd5
PE
4038 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4039 when creating daemon; the previous buffer-overflow check was incorrect.
4040
d749b01b
PE
4041 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4042 which has the guts of the old verror function.
4043
b5cd1905
PE
4044 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4045 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4046
6e1a67fb
PE
4047 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4048 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4049 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4050 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4051 length of string rather than counting it via multiple sprintfs;
4052 that's simpler and more reliable.
c21721cc
PE
4053 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4054 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4055 sprintf, in case result does not fit in int.
4056
c57b67fc
PE
4057 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4058 (fontset_from_font): Print it.
4059
8a401434
PE
4060 * frame.c (tty_frame_count): Now printmax_t, not int.
4061 (make_terminal_frame, set_term_frame_name): Print it.
4062 (x_report_frame_params): In X, window IDs are unsigned long,
4063 not signed long, so print them as unsigned.
4064 (validate_x_resource_name): Check for implausibly long names,
4065 and don't assume name length fits in 'int'.
4066 (x_get_resource_string): Don't blindly alloca invocation name;
4067 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4068 not fit in int.
4069
6e1a67fb
PE
4070 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4071 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4072 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4073
0df02bf3
PE
4074 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4075 Use esprintf, not sprintf, in case result does not fit in int.
4076
48e30793
PE
4077 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4078 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4079 it as a large positive number.
4080 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4081 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4082
a66ff6d8
PE
4083 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4084 in case result does not fit in int.
4085
aca216ff
PE
4086 * print.c (float_to_string): Detect width overflow more reliably.
4087 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4088 buffer overrun. Don't assume list length fits in 'int'. Treat
4089 print length of 0 as 0, not as infinity; to be consistent with other
4090 uses of print length in this function. Don't overflow print length
4091 index. Don't assume hash table size fits in 'long', or that
4092 vectorlike size fits in 'unsigned long'.
4093
31c286f7
PE
4094 * process.c (make_process): Use printmax_t, not int, to format
4095 process-name gensyms.
4096
55e5faa1
PE
4097 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4098
80f2e268
PE
4099 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4100 to avoid potential buffer overrun.
4101
670741ab
PE
4102 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4103 if X resource line is longer than 512 bytes.
4104
b7163a50
PE
4105 * xfns.c (x_window): Make sprintf buffer a bit bigger
4106 to avoid potential buffer overrun.
4107
ae58ff1f
PE
4108 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4109
c43c8a6a
PE
4110 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4111
3f8236f4
PE
41122011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4113
53e9fe90 4114 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4115 Without these, Emacs silently mishandles large integers sometimes.
4116 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4117 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4118
6511acf2
PE
4119 * xdisp.c (try_window_id): Check Emacs fixnum range before
4120 converting to 'int'.
806add1d 4121
6511acf2 4122 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4123 Check that an Emacs fixnum is in range before assigning it to 'int'.
4124 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4125 values converted from Emacs fixnums.
4126 (Frecenter): Don't wrap around a line count if it is out of 'int'
4127 range; instead, treat it as an extreme value.
4128 (Fset_window_configuration, compare_window_configurations):
4129 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4130
6511acf2
PE
4131 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4132 that can exceed INT_MAX. Check that EMACS_INT value is in range
4133 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4134 (match_limit): Don't assume that a fixnum can fit in 'int'.
4135
6511acf2 4136 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4137 exceed INT_MAX.
4138
6511acf2 4139 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4140 (Fvertical_motion): Don't wrap around LINES values that don't fit
4141 in 'int'. Instead, treat them as extreme values. This is good
4142 enough for windows, which can't have more than INT_MAX lines anyway.
4143
fcb901a7
LMI
41442011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4145
0f2f6b6d
LMI
4146 * Require libxml/parser.h to avoid compilation warning.
4147
fcb901a7
LMI
4148 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4149
4150 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4151 since this reportedly can destroy thread storage.
4152
6e20a0d4
CY
41532011-08-30 Chong Yidong <cyd@stupidchicken.com>
4154
4155 * syntax.c (find_defun_start): Update all cache variables if
4156 exiting early (Bug#9401).
4157
148ae00e
EZ
41582011-08-30 Eli Zaretskii <eliz@gnu.org>
4159
f6cfbd8f
EZ
4160 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4161
148ae00e
EZ
4162 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4163 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4164 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4165
4166 * term.c (tty_append_glyph): New function.
4167 (produce_stretch_glyph): Static function and its prototype deleted.
4168
a66cfb1c
SM
4169 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4170 Add prototypes.
148ae00e 4171
c4a07a4c
PE
41722011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4173
4174 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4175 when checking :margin (Bug#9390).
4176 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 4177 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
4178 so that the name doesn't mislead. All uses changed.
4179
6bc8cd65
JB
41802011-08-28 Johan Bockgård <bojohan@gnu.org>
4181
4182 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4183 set_tty_hooks.
4184
dca4927e
EZ
41852011-08-27 Eli Zaretskii <eliz@gnu.org>
4186
4187 * xdisp.c (move_it_to): Don't bail out early when reaching
4188 position beyond to_charpos, if we are scanning backwards.
4189 (move_it_vertically_backward): When DY == 0, make sure we get to
4190 the first character in the line after the newline.
4191
f2cad773
PE
41922011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4193
4194 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4195 (ccl_driver): Do not generate an out-of-range pointer.
4196 (Fccl_execute_on_string): Remove unnecessary check for
4197 integer overflow, noted by Stefan Monnier in
4198 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4199 Remove a FIXME that didn't need fixing.
4200 Simplify the newly-introduced buffer reallocation code.
4201
0cae2cdb
JB
42022011-08-27 Juanma Barranquero <lekktu@gmail.com>
4203
4204 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4205
5fc295a4 42062011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 4207
70c60eb2 4208 Integer and memory overflow issues (Bug#9196).
726e0ab1 4209
d31850da
PE
4210 * doc.c (get_doc_string): Rework so that
4211 get_doc_string_buffer_size is the actual buffer size, rather than
4212 being 1 less than the actual buffer size; this makes xpalloc more
4213 convenient.
4214
a69fbedb
PE
4215 * image.c (x_allocate_bitmap_record, cache_image):
4216 * xselect.c (Fx_register_dnd_atom):
4217 Simplify previous changes by using xpalloc.
4218
fe5c5d37
PE
4219 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4220 since either will do and ptrdiff_t is convenient with xpalloc.
4221
0065d054
PE
4222 * charset.c (charset_table_size)
4223 (struct charset_sort_data.priority): Now ptrdiff_t.
4224 (charset_compare): Don't overflow if priorities differ greatly.
4225 (Fsort_charsets): Don't assume list length fits in int.
4226 Check for size-calculation overflow when allocating sort data.
4227 (syms_of_charset): Allocate an initial charset table that is
4228 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4229
4230 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4231
4232 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4233 The actual value is always <= INT_MAX, and leaving it unsigned made
4234 overflow checking harder.
4235
4236 * dispextern.h (struct glyph_matrix.rows_allocated)
4237 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4238 with xpalloc. The values are still always <= INT_MAX.
4239
4240 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4241
4242 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4243 (SAFE_NALLOCA): New macro.
4244
4245 * region-cache.c (struct boundary.pos, find_cache_boundary)
4246 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4247 (set_cache_region, invalidate_region_cache)
4248 (revalidate_region_cache, know_region_cache, region_cache_forward)
4249 (region_cache_backward, pp_cache):
4250 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4251 so that ptrdiff_t * can be passed to xpalloc.
4252 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4253 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4254 (pp_cache): Don't assume cache_len fits in int.
4255 * region-cache.h: Adjust extern decls to match.
4256
4257 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4258 EMACS_INT, since either will do, for xpalloc.
4259
4260 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4261 (xnmalloc, xnrealloc, xpalloc): New functions.
4262
726e0ab1
PE
4263 * bidi.c (bidi_shelve_header_size): New constant.
4264 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4265 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4266
51f30bc5 4267 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
4268 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4269 (overlay_strings):
4270 Don't update size of array until after memory allocation succeeds,
4271 because xmalloc/xrealloc may not return.
0065d054
PE
4272 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4273 now that we have proper integer overflow checking.
4274 (record_overlay_string, overlay_strings): Catch overflows when
4275 calculating size of overlay_str_buf.
726e0ab1 4276
0065d054
PE
4277 * callproc.c (Fcall_process): Check for size overflow when
4278 calculating size of args2.
4279 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4280 Normally we prefer signed values, but sticking with ptrdiff_t would
4281 require adding more-complicated checks.
726e0ab1
PE
4282
4283 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4284 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4285 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 4286 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
4287
4288 * character.c (Fstring): Check for size-calculation overflow.
4289
4290 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4291 unnecessary integer overflow. Check for size overflow.
4292 (encode_coding_object): Don't update size until xmalloc succeeds.
4293
4294 * composite.c (get_composition_id): Check for overflow in glyph
4295 length calculations.
4296
4297 Integer and memory overflow fixes for display code.
4298 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4299 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4300 (scrolling_window): Check for overflow in size calculations.
4301 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4302 Don't assume glyph table len fits in int.
4303 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4304 (row_table_size): Now ptrdiff_t, not int.
4305 (scrolling_window): Avoid overflow in size calculations.
4306 Don't update size until allocation succeeds.
4307 * fns.c (concat): Check for overflow in size calculations.
4308 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4309 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4310 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4311
4312 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4313 (get_doc_string): Check for size calculation overflow.
4314 Don't update size until allocation succeeds.
4315 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4316 EMACS_INT, where ptrdiff_t will do.
4317 (Fsubstitute_command_keys): Check for string overflow.
4318
4319 * editfns.c (set_time_zone_rule): Don't assume environment length
4320 fits in int.
4321 (message_length): Now ptrdiff_t, not int.
4322 (Fmessage_box): Don't update size until allocation succeeds.
4323 Don't assume message length fits in int.
4324 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4325
0065d054
PE
4326 * emacs.c (main): Do not reallocate argv, since there is a null at
4327 the end that can be overwritten, and this way there's no need to
4328 worry about size-calculation overflow.
4329 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
4330
4331 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4332 alloc succeeds.
4333 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4334
4335 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4336 (x_set_scroll_bar_width, x_figure_window_size):
4337 Check for integer overflow.
4338 (x_set_alpha): Do not assume XINT fits in int.
4339
4340 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4341 This is for the members text_lines, text_cols, total_lines, total_cols,
4342 where the system imposes an 'int' limit.
4343
4344 * fringe.c (Fdefine_fringe_bitmap):
4345 Don't update size until alloc works.
4346
4347 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4348 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4349
4350 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4351 Check for size-calculation overflow.
4352 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4353 do, as we prefer signed integers.
4354 (id_to_widget.max_size, id_to_widget.used)
4355 (xg_store_widget_in_map, xg_remove_widget_from_map)
4356 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4357 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4358 Use and return ptrdiff_t, not int.
4359 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4360 * gtkutil.h: Change prototypes to match the above.
4361
4362 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4363 are duplicate now that they've been promoted to lisp.h.
4364 (x_allocate_bitmap_record, x_alloc_image_color)
4365 (make_image_cache, cache_image, xpm_load):
4366 Don't update size until alloc is done.
4367 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4368 (x_detect_edges):
3256efce 4369 Check for size calculation overflow.
726e0ab1
PE
4370 (ct_colors_allocated_max): New constant.
4371 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4372 overflow.
3256efce 4373
726e0ab1
PE
4374 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4375 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4376 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4377 Use ptrdiff_t, not int, to count maps.
4378 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
4379 calculations. Don't update size until allocation succeeds.
4380 Redo calculations to avoid overflow.
726e0ab1
PE
4381 * keyboard.h: Change prototypes to match the above.
4382
4383 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4384 to count maps.
4385 (current_minor_maps): Check for size calculation overflow.
4386 * keymap.h: Change prototypes to match the above.
4387
4388 * lread.c (read1, init_obarray): Don't update size until alloc done.
4389
4390 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4391 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4392
726e0ab1
PE
4393 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4394 Now ptrdiff_t, not int.
4395 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4396 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4397
4398 * process.c (Fnetwork_interface_list): Check for overflow
4399 in size calculation.
4400
4401 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4402
4403 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4404 overflow. Don't bother calling xmalloc when xrealloc will do.
4405
4406 * search.c (Freplace_match): Check for size calculation overflow.
4407 (Fset_match_data): Don't assume list lengths fit in 'int'.
4408
4409 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4410 for command line length. Do not attempt to address one before the
4411 beginning of an array, as that's not portable.
4412
4413 * term.c (max_frame_lines): Remove; unused.
4414 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4415 not int.
4416 (encode_terminal_code, calculate_costs): Check for size
4417 calculation overflow.
4418 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4419 table lengths and related sizes. Don't update size until alloc
4420 done. Redo calculations to avoid overflow.
4421 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4422
4423 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4424 subtracting pointers.
4425 (gobble_line): Check for overflow more carefully. Don't update size
4426 until alloc done.
4427
4428 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4429 Don't update size until alloc done.
4430 Redo size calculations to avoid overflow.
4431 Check for size calculation overflow.
0065d054 4432 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
4433
4434 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4435 Use ptrdiff_t, not int, for sizes.
4436 (store_mode_line_noprop_char): Don't update size until alloc done.
4437
0065d054
PE
4438 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4439 Use ptrdiff_t, not int, for sizes.
4440 (Finternal_make_lisp_face, cache_face):
4441 Check for size calculation overflow.
4442 (cache_face): Treat size calculation overflows as if they were
4443 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
4444
4445 * xfns.c (x_encode_text, x_set_name_internal)
4446 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4447 sizes, since they can exceed INT_MAX in size. Check for size
4448 calculation overflow.
4449
0065d054
PE
4450 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4451 (xg_select): Check for size calculation overflow.
726e0ab1
PE
4452 Don't update size until alloc done.
4453
0065d054 4454 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 4455 as sprintf is limited to int lengths.
1d526e2f 4456
252c5ee1
PE
4457 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4458 (X_LONG_MIN): New macros.
864d7ce7
PE
4459 Use them to make the following changes clearer.
4460 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4461 This change doesn't affect the value now, but it may help remind
4462 future maintainers not to raise the value too much later.
4463 (SELECTION_QUANTUM): Remove, replacing with ...
4464 (selection_quantum): ... new function, which avoids overflow.
4465 All uses changed.
4466 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4467 assumption that selection length fits in 'int'.
4468 (x_reply_selection_request, x_handle_selection_request)
4469 (x_get_window_property, receive_incremental_selection)
4470 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4471 (lisp_data_to_selection_data, clean_local_selection_data):
4472 Use ptrdiff_t, not int, to record length of selection.
4473 (x_reply_selection_request, x_get_window_property)
4474 (receive_incremental_selection, x_property_data_to_lisp):
4475 Redo calculations to avoid overflow.
4476 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 4477 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
4478 something.
4479 (x_get_window_property, receive_incremental_selection)
4480 (lisp_data_to_selection_data, x_property_data_to_lisp):
4481 Check for size-calculation overflow.
4482 (x_get_window_property, receive_incremental_selection)
4483 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4484 Don't store size until memory allocation succeeds.
4485 (x_get_window_property): Plug memory leak on memory exhaustion.
4486 Don't double-block input; malloc is safe here. Don't assume 2**34
4487 - 4 fits in unsigned long. Add an xassert to check
4488 XGetWindowProperty overflow. Be more careful about overflow
4489 calculations, and distinguish size from memory overflow better.
4490 (receive_incremental_selection): When tracing, don't assume
4491 unsigned int is less than INT_MAX.
4492 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4493 harmful) conversions of unsigned short to int.
4494 (lisp_data_to_selection_data): Don't assume that integers
4495 in the range -65535 through -1 fit in an X unsigned short.
4496 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4497 result parameters unless successful. Rely on cons_to_unsigned
4498 to report problems with elements; the old code wasn't right anyway.
4499 (x_check_property_data): Check for int overflow; we cannot use
4500 a wider type due to X limits.
4501 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4502
726e0ab1 4503 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 4504
0065d054
PE
4505 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4506 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
4507 (x_color_cells): Don't store size until memory allocation succeeds.
4508 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 4509 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
4510 (x_term_init): Don't assume length fits in int (sprintf is limited
4511 to int size).
bc18e09d 4512
ebfa62c0
PE
4513 Use ptrdiff_t for composition IDs.
4514 * character.c (lisp_string_width):
4515 * composite.c (composition_table_size, n_compositions)
4516 (get_composition_id, composition_gstring_from_id):
4517 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4518 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4519 * window.c (Frecenter):
4520 Use ptrdiff_t, not int, for composition IDs.
4521 * composite.c (get_composition_id): Check for integer overflow.
4522 * composite.h: Adjust prototypes to match the above changes.
4523
d3411f89
PE
4524 Use ptrdiff_t for hash table indexes.
4525 * category.c (hash_get_category_set):
4526 * ccl.c (ccl_driver):
4527 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4528 * coding.c (coding_system_charset_list, detect_coding_system):
4529 * coding.h (struct coding_system.id):
4530 * composite.c (get_composition_id, gstring_lookup_cache):
4531 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4532 * image.c (xpm_get_color_table_h):
4533 * lisp.h (hash_lookup, hash_put):
4534 * minibuf.c (Ftest_completion):
4535 Use ptrdiff_t for hash table indexes, not int (which is too
4536 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4537 32-bit --with-wide-int hosts).
4538
e097a6fa
PE
4539 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4540 Add a FIXME comment about memory leaks.
4541 (syms_of_charset): Don't assume xmalloc returns.
4542
5637687f
PE
4543 Don't assume that stated character widths fit in int.
4544 * character.c (Fchar_width, c_string_width, lisp_string_width):
4545 * character.h (CHAR_WIDTH):
4546 * indent.c (MULTIBYTE_BYTES_WIDTH):
4547 Use sanitize_char_width to avoid undefined and/or bad behavior
4548 with outlandish widths.
a66cfb1c 4549 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
4550 now that we have two such functions. All uses changed.
4551 (sanitize_char_width): New inline function.
4552
a2271ba2
PE
4553 Don't assume that tab-width fits in int.
4554 * character.h (sanitize_width): New inline function.
4555 (SANE_TAB_WIDTH): New macro.
4556 (ASCII_CHAR_WIDTH): Use it.
4557 * indent.c (sane_tab_width): Remove. All uses replaced by
4558 SANE_TAB_WIDTH (current_buffer).
4559 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4560
18c52557
PE
4561 * fileio.c: Integer overflow issues with file modes.
4562 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4563
caeeedc1
PE
4564 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4565 Remove unreachable code.
4566 (read_hex, load_charset_map_from_file): Check for integer overflow.
4567
6df6ae42 4568 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
4569 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4570 (x_send_scroll_bar_event): Likewise. Check that the size does not
4571 exceed limits imposed by XClientMessageEvent, as well as the usual
4572 ptrdiff_t and size_t limits.
4573
b13995db
PE
4574 * keyboard.c: Overflow, signedness and related fixes.
4575 (make_lispy_movement): Use same integer type in forward decl
4576 that is used in the definition.
4577 (read_key_sequence, keyremap_step):
4578 Change bufsize argument back to int, undoing my 2011-03-30 change.
4579 We prefer signed types, and int is wide enough here.
4580 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4581 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4582 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4583 length, not size_t. Use ptrdiff_t for index, not int.
4584 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4585 possibility of integer overflow.
4586
13464394
PE
4587 Overflow, signedness and related fixes for images.
4588
4589 * dispextern.h (struct it.stack[0].u.image.image_id)
4590 (struct_it.image_id, struct image.id, struct image_cache.size)
4591 (struct image_cache.used, struct image_cache.ref_count):
4592 * gtkutil.c (update_frame_tool_bar):
4593 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4594 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4595 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4596 * nsmenu.m (update_frame_tool_bar):
4597 * xdisp.c (calc_pixel_width_or_height):
4598 * xfns.c (image_cache_refcount):
4599 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4600 on typical 64-bit hosts.
4601
4602 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4603 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4604 Omit unnecessary casts to int.
4605 (parse_image_spec): Check that integers fall into 'int' range
4606 when the callers expect that.
4607 (image_ascent): Redo ascent calculation to avoid int overflow.
4608 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4609 (lookup_image): Remove unnecessary tests.
4610 (xbm_image_p): Locals are now of int, not EMACS_INT,
4611 since parse_image_check makes sure they fit into int.
4612 (png_load, gif_load, svg_load_image):
4613 Prefer int to unsigned where either will do.
4614 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
4615 old tiff_error_handler and tiff_warning_handler.
4616 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
4617 stack buffer overflows. It uses only the features of vsnprintf
4618 that are common to both POSIX and native Microsoft.
4619 (tiff_error_handler, tiff_warning_handler): Use it.
4620 (tiff_load, gif_load, imagemagick_load_image):
4621 Don't assume :index value fits in 'int'.
4622 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4623 (imagemagick_load_image): Check that crop parameters fit into
4624 the integer types that MagickCropImage accepts. Don't assume
4625 Vimagemagick_render_type has a nonnegative value. Don't assume
4626 size_t fits in 'long'.
4627 (gs_load): Use printmax_t to print the widest integers possible.
4628 Check for integer overflow when computing image height and width.
4629
c11821d4
EZ
46302011-08-26 Eli Zaretskii <eliz@gnu.org>
4631
4632 * xdisp.c (redisplay_window): Don't force window start if point
4633 will be invisible in the resulting window. (Bug#9324)
4634
0c95fcf7
EZ
46352011-08-25 Eli Zaretskii <eliz@gnu.org>
4636
4637 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4638 the display spec is of the form `(space ...)'.
4639 (handle_display_spec): Return the value returned by
4640 handle_single_display_spec, not just 1 or zero.
4641 (handle_single_display_spec): If the display spec is of the form
4642 `(space ...)', and specifies display in the text area, return 2
4643 rather than 1.
fee65a97 4644 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
4645 accurately, and prefer exact match for point under bidi.
4646 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
4647
4648 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4649 into disp_prop; all users changed.
4650
4651 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4652 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4653 for the text covered by the display property.
4654
e4ed06f1
CY
46552011-08-25 Chong Yidong <cyd@stupidchicken.com>
4656
4657 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4658 Change return value to nil.
4659 (Frecord_buffer): Delete unused function.
4660
f67cdd7f
EZ
46612011-08-24 Eli Zaretskii <eliz@gnu.org>
4662
5980d4c6
EZ
4663 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4664 buffers, return left-to-right.
8610fe8b
EZ
4665 (set_cursor_from_row): Consider candidate row a win if its glyph
4666 represents a newline and point is on that newline. Fixes cursor
4667 positioning on the newline at EOL of R2L text within L2R
4668 paragraph, and vice versa.
4669 (try_cursor_movement): Check continued rows, in addition to
4670 continuation rows. Fixes unwarranted scroll when point enters a
4671 continued line of R2L text within an L2R paragraph, or vice versa.
4672 (cursor_row_p): Consider the case of point being equal to
4673 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4674 from the end of a short line to the beginning of a continued line
4675 of R2L text within L2R paragraph.
4676 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4677 composed characters.
5980d4c6 4678
f67cdd7f
EZ
4679 * bidi.c (bidi_check_type): Use xassert.
4680 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4681 members.
4682
bca633fb
EZ
46832011-08-23 Eli Zaretskii <eliz@gnu.org>
4684
4685 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4686 a character.
4687
4a5885a7
CY
46882011-08-23 Chong Yidong <cyd@stupidchicken.com>
4689
4690 * nsfont.m (ns_otf_to_script): Fix typo.
4691
0902a04e
KH
46922011-08-22 Kenichi Handa <handa@m17n.org>
4693
4694 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4695 extra slot even if the purpose is char-code-property-table.
4696
1a2e6670
EZ
46972011-08-23 Eli Zaretskii <eliz@gnu.org>
4698
8ddde651
EZ
4699 * xdisp.c (redisplay_window): When computing centering_position,
4700 account for the height of the header line. (Bug#8874)
4701
425cc014
EZ
4702 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4703 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4704 candidate is selected by the mouse, and that candidate has a
4705 composed character under the mouse.
4706
1a2e6670
EZ
4707 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4708 coordinates reported by pos-visible-in-window-p for a composed
4709 character in column zero.
4710
8b76d6f8
SM
47112011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4712
4713 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4714
dac347dd
EZ
47152011-08-22 Eli Zaretskii <eliz@gnu.org>
4716
4717 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4718 consider it a hit if to_charpos is anywhere in the range of the
4719 composed buffer positions.
4720
e013fb34
CY
47212011-08-22 Chong Yidong <cyd@stupidchicken.com>
4722
4723 * image.c (gif_load): Don't assume that each subimage has the same
4724 dimensions as the base image. Handle disposal method that is
4725 "undefined" by the gif spec (Bug#9335).
4726
bd1ba3e8
CY
47272011-08-20 Chong Yidong <cyd@stupidchicken.com>
4728
4729 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 4730 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 4731
54a1215b
EZ
47322011-08-19 Eli Zaretskii <eliz@gnu.org>
4733
823564e5
EZ
4734 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4735 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4736 from an Org mode buffer to a Speedbar frame.
4737
54a1215b
EZ
4738 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4739 a composition, take its buffer position from IT->cmp_it.charpos.
4740 Fixes cursor positioning at the beginning of a line that begins
4741 with a composed character.
4742
9778ebcc
EZ
47432011-08-18 Eli Zaretskii <eliz@gnu.org>
4744
0be6ee06
EZ
4745 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4746 character bidirectional type, use STRONG_L instead. Fixes crashes
4747 in a buffer produced by `describe-categories'.
4748
9778ebcc
EZ
4749 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4750 members before the level stack, so they would be saved and
4751 restored when copying iterator state. Fixes incorrect reordering
4752 around TABs covered by display properties.
4753
156bffbe
AS
47542011-08-18 Andreas Schwab <schwab@linux-m68k.org>
4755
6b02f655 4756 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 4757
72ad093b
CY
47582011-08-17 Chong Yidong <cyd@stupidchicken.com>
4759
4760 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
4761 (internal_condition_case_2, internal_condition_case_n):
4762 Remove unnecessary aborts (Bug#9081).
72ad093b 4763
35774242
EZ
47642011-08-17 Eli Zaretskii <eliz@gnu.org>
4765
4766 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
4767 has no `load' handler, try opening the file locally. (Bug#9311)
4768
db76dd85
KB
47692011-08-16 Ken Brown <kbrown@cornell.edu>
4770
4771 * gmalloc.c: Expand comment.
4772
b215eee5
EZ
47732011-08-16 Eli Zaretskii <eliz@gnu.org>
4774
4775 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
4776 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
4777
a4579d33
KB
47782011-08-16 Ken Brown <kbrown@cornell.edu>
4779
4780 Fix memory allocation problems in Cygwin build (Bug#9273).
4781
4782 * unexcw.c ( __malloc_initialized): Declare external variable.
4783 (fixup_executable): Force the dumped emacs to reinitialize malloc.
4784
8b76d6f8
SM
4785 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
4786 New variables.
a4579d33
KB
4787 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
4788 dumped emacs.
4789 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
4790 in the static heap.
4791 [CYGWIN] (special_realloc): New function.
4792 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
4793 requests to realloc storage in the static heap.
4794
3ebec551
PE
47952011-08-15 Paul Eggert <eggert@cs.ucla.edu>
4796
4797 * bidi.c (bidi_initialize): Remove unused local.
4798
9fd8be00
EZ
47992011-08-15 Eli Zaretskii <eliz@gnu.org>
4800
6b02f655
SM
4801 * bidimirror.h:
4802 * biditype.h: Remove file.
4803 * makefile.w32-in ($(BLD)/bidi.$(O)):
4804 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
4805
4806 * dispextern.h: Fix a typo in the comment to bidi_type_t.
4807
4808 * chartab.c: Improve commentary for the uniprop_table API.
4809
32413314
EZ
4810 * bidi.c (bidi_paragraph_init): Support zero value of
4811 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
4812 (bidi_initialize): Use uniprop_table instead of including
4813 biditype.h and bidimirror.h.
32413314 4814
9fd8be00
EZ
4815 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
4816 coordinates of the iterator when restoring from ppos_it.
4817 (Bug#9296)
4818
5cf2b69b
KH
48192011-08-14 Kenichi Handa <handa@m17n.org>
4820
4821 * process.c (create_process): Call setup_process_coding_systems
72ad093b 4822 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 4823
daf17d00
EZ
48242011-08-14 Eli Zaretskii <eliz@gnu.org>
4825
4826 * xdisp.c (move_it_in_display_line_to): Don't invoke
4827 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
4828 ppos_it. Fixes vertical cursor motion when line beginning is
4829 covered by an image. (Bug#9296)
4830
08e3161a
JD
48312011-08-14 Jan Djärv <jan.h.d@swipnet.se>
4832
4833 * nsterm.h (ns_run_ascript): Declare.
4834 (NSAPP_DATA2_RUNASSCRIPT): Define.
4835
4836 * nsfns.m (as_script, as_result, as_status): New static variables.
4837 (ns_run_ascript): New function.
5e617bc2 4838 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
4839 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
4840 the event loop. Get status from as_status (Bug#7276).
4841
4842 * nsterm.m (sendEvent): If event is NSApplicationDefined and
4843 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
4844 the event loop (Bug#7276).
4845
a3720aa2
AS
48462011-08-14 Andreas Schwab <schwab@linux-m68k.org>
4847
4848 * gnutls.c (QCgnutls_bootprop_priority)
4849 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
4850 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
4851 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
4852 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
4853 (QCgnutls_bootprop_verify_hostname_error)
4854 (QCgnutls_bootprop_callbacks_verify): Rename from
4855 Qgnutls_bootprop_..., all uses changed.
4856
4857 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
4858 uses changed.
4859
0a0d27fb
PE
48602011-08-14 Paul Eggert <eggert@cs.ucla.edu>
4861
19d5c50c
PE
4862 * xfaces.c (Qframe_set_background_mode): Now static.
4863 * dispextern.h (Qframe_set_background_mode): Remove decl.
4864
0a0d27fb
PE
4865 * process.c (Fnetwork_interface_info): Declare local only if needed.
4866
377538cb
JD
48672011-08-13 Jan Djärv <jan.h.d@swipnet.se>
4868
4869 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
4870 (Fnetwork_interface_list): Allocate in increments of bytes instead
4871 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
4872 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
4873 sockaddr.
4874 (struct ifflag_def): notrailers is smart on OSX.
4875 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
4876 Get hardware address with getifaddrs if available.
4877
08fff70c
EZ
48782011-08-12 Eli Zaretskii <eliz@gnu.org>
4879
4880 * xdisp.c (iterate_out_of_display_property): xassert that
4881 IT->position is set to within IT->object's boundaries. Break from
4882 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
4883 when IT->position is set up wrongly due to some bug.
4884 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
4885 (push_display_prop): Allow GET_FROM_STRING as IT->method on
4886 entry. Force push_it to save on the stack the current
4887 buffer/string position, to be restored by pop_it. Fix flags in
4888 the iterator structure wrt the object coming from a display
4889 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
4890 properties. (Bug#9284)
4891
7be1c708 48922011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 4893
7be1c708
CY
4894 * fontset.c (fontset_get_font_group): Add proper type checks.
4895 (Bug#9172)
aac0c6e3 4896
7be1c708 48972011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 4898
7be1c708
CY
4899 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
4900 and LC_VERSION_MIN_MACOSX.
4901 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
4902 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 4903
97bb72a6
EZ
49042011-08-08 Eli Zaretskii <eliz@gnu.org>
4905
4906 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
4907 no-display-properties-and-no-overlays under bidi display.
4908 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 4909 properties and overlays.
97bb72a6 4910
d5617611
CY
49112011-08-08 Chong Yidong <cyd@stupidchicken.com>
4912
37e11a63
CY
4913 * editfns.c (Fset_time_zone_rule): Document relationship with the
4914 setenv function.
4915
d5617611
CY
4916 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
4917 the font entity extracted from the cache (Bug#8109).
4918
58872834
CY
49192011-08-07 Chong Yidong <cyd@stupidchicken.com>
4920
4921 * composite.c (autocmp_chars): Don't reset point. That is done by
4922 restore_point_unwind (Bug#5984).
4923
75bfc667
JL
49242011-08-07 Juri Linkov <juri@jurta.org>
4925
4926 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
4927 to show the arg `TIME' instead of `TIMEVAL'.
4928
d1410150
EZ
49292011-08-06 Eli Zaretskii <eliz@gnu.org>
4930
4931 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
4932 display property strides EOL and includes a newline, as in
4933 longlines-mode. (Bug#9254)
75b771e4
EZ
4934 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
4935 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
4936
4937 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
4938 is non-zero, even if the data buffer is NULL. Fixes a crash in
4939 vertical-motion with longlines-mode. (Bug#9254)
4940
35928349
EZ
49412011-08-05 Eli Zaretskii <eliz@gnu.org>
4942
ec7cc85b
EZ
4943 * bidi.c <bidi_cache_total_alloc>: Now static.
4944 (bidi_initialize): Initialize bidi_cache_total_alloc.
4945
8b76d6f8 4946 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
4947 cache. (Bug#9221)
4948
4949 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
4950 amount allocated this far in `bidi_cache_total_alloc'.
4951 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
4952 non-zero, only free the data buffer without restoring the cache
4953 contents. All callers changed.
4954
4955 * dispextern.h (bidi_unshelve_cache): Update prototype.
4956
4957 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
4958 (move_it_in_display_line, move_it_to)
4959 (move_it_vertically_backward, move_it_by_lines): Replace the call
4960 to xfree to an equivalent call to bidi_unshelve_cache.
4961 (move_it_in_display_line_to): Fix logic of returning
412b6358 4962 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 4963
e2e2423b
EZ
49642011-08-05 Eli Zaretskii <eliz@gnu.org>
4965
4966 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
4967 came from a string character with a `cursor' property. (Bug#9229)
4968
ae9e757a
JD
49692011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4970
4971 * Makefile.in (LIB_PTHREAD): New variable.
4972 (LIBES): Add LIB_PTHREAD (Bug#9216).
4973
4974 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
4975 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
4976
213bd7f2
AS
49772011-08-04 Andreas Schwab <schwab@linux-m68k.org>
4978
6b02f655 4979 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 4980
99aaf75f
JD
49812011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4982
4983 * xterm.c (x_find_topmost_parent): New function.
4984 (x_set_frame_alpha): Find topmost parent window with
4985 x_find_topmost_parent and set the property there also (bug#9181).
4986 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
4987
c74e9d86
PE
49882011-08-04 Paul Eggert <eggert@cs.ucla.edu>
4989
4990 * callproc.c (Fcall_process): Avoid vfork clobbering
4991 the local vars buffer, coding_systems, current_dir.
4992
640c8776
SM
49932011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
4994
4995 * keymap.c (Fmake_composed_keymap): Move to subr.el.
4996
f26d0e4c
PE
49972011-08-03 Paul Eggert <eggert@cs.ucla.edu>
4998
8a10d76c
PE
4999 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5000 so that it is not optimized away.
5001
f26d0e4c
PE
5002 * xdisp.c (compute_display_string_pos): Remove unused local.
5003
55439c61
EZ
50042011-08-02 Eli Zaretskii <eliz@gnu.org>
5005
5006 Fix slow cursor motion and scrolling in large buffers with
5007 selective display, like Org Mode buffers. (Bug#9218)
5008
5009 * dispextern.h (struct bidi_it): New member disp_prop_p.
5010
5011 * xdisp.c: Remove one-slot cache of display string positions.
5012 (compute_display_string_pos): Accept an additional argument
5e617bc2 5013 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5014 for a display string or property. If found, set DISP_PROP_P
5015 non-zero.
5016
5017 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5018 DISP_PROP_P, and pass it to compute_display_string_pos.
5019 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5020 non-zero. All callers of bidi_fetch_char changed.
5021
fb33fa43
SM
50222011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5023
5024 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5025
b099e063
DM
50262010-12-03 Don March <don@ohspite.net>
5027
5028 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5029 last character M-[char] is translated to ESC [char] (bug#7541).
5030
5cc7f7af
KH
50312011-08-02 Kenichi Handa <handa@m17n.org>
5032
d0fffa3f 5033 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5034
5035 * chartab.c (uniprop_table): Make it non-static.
5036
525d5e6e
EZ
50372011-08-01 Eli Zaretskii <eliz@gnu.org>
5038
5039 * xdisp.c (forward_to_next_line_start): Accept additional argument
5040 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5041 on the newline.
5042 (reseat_at_next_visible_line_start): Use the bidi iterator state
5043 returned by forward_to_next_line_start to restore the state of
5044 it->bidi_it after backing up to previous newline. (Bug#9212)
5045
31011111
AS
50462011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5047
5048 * regex.c (re_comp): Protoize.
5049 (re_exec): Fix return type.
5050 (regexec): Fix type of `ret'. (Bug#9203)
5051
476371c4
PE
50522011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5053
e5d76069
PE
5054 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5055 This is needed if max-image-size is a floating-point number.
5056
9a79b20c
AS
50572011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5058
5059 * print.c (print_object): Print empty symbol as ##.
5060
5061 * lread.c (read1): Read ## as empty symbol.
5062
d8c2fa78
AA
50632011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5064
5065 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5066 setting frame foreground color (Bug#9175).
5067 (x_set_background_color): Likewise.
5068
ffe57a7a
AA
5069 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5070 contents (Bug#9176).
5071 (EmacsTooltip -init): Remove bezels and add shadows to
5072 tooltip windows.
5073
bf3492a5
AA
5074 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5075 or scroll bar (Bug#8470).
5076
d55e9c53
AA
5077 * nsfont.m (nsfont_open): Remove assignment to voffset and
5078 unnecessary vars hshink, expand, hd, full_height, min_height.
5079 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5080
5081 * nsterm.h (nsfont_info): Remove voffset field.
5082
d8c2fa78 50832011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5084
5085 Implement strike-through and overline on NextStep (Bug#8863).
5086
5087 * nsfont.m (nsfont_open): Use underline position provided by font,
5088 instead of hard-coded value of 2.
5089 (nsfont_draw): Call ns_draw_text_decoration instead.
5090
5091 * nsterm.h: Add declaration for ns_draw_text_decoration.
5092
5093 * nsterm.m (ns_draw_text_decoration): New function for drawing
5094 underline, overline, and strike-through.
5095 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5096 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5097 accommodate underlining, etc.
4843aac3 5098
4cc60b9b
EZ
50992011-07-28 Eli Zaretskii <eliz@gnu.org>
5100
bc7ece87
EZ
5101 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5102 default.
4cc60b9b 5103
476371c4
PE
51042011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5105
66606eea
PE
5106 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5107 Without this fix, if a signal arrives just after memory fills up,
5108 'malloc' might be invoked reentrantly.
5109
476371c4
PE
5110 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5111 In other words, assume that every image size is allowed, on non-X
5112 hosts. This assumption is probably wrong, but it lets Emacs compile.
5113
f3fcc40d
AS
51142011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5115
5116 * regex.c (re_iswctype): Convert return values to boolean.
5117
350c992f
EZ
51182011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5119
5120 * xdisp.c (compute_display_string_pos): Don't use cached display
5121 string position if the buffer had its restriction changed.
5122 (Bug#9184)
5123
5266b4bb
PE
51242011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5125
5126 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5127
2573a837 51282011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5129
41f55ccd 5130 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5131
39e378da
PE
5132 * bidi.c: Integer size and overflow fixes.
5133 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5134 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5135 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5136 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5137 (bidi_find_other_level_edge):
5138 Use ptrdiff_t instead of EMACS_INT where either will do.
5139 This works better on 32-bit hosts configured --with-wide-int.
5140 (bidi_cache_ensure_space): Check for size-calculation overflow.
5141 Use % rather than repeated addition, for better worst-case speed.
5142 Don't set bidi_cache_size until after xrealloc returns, because it
5143 might not return.
5144 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5145 (bidi_cache_ensure_space): Also check that the bidi cache size
5146 does not exceed that of the largest Lisp string or buffer. See Eli
5147 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5148
5e927815
PE
5149 * alloc.c (__malloc_size_t): Remove.
5150 All uses replaced by size_t. See Andreas Schwab's note
5151 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5152
ca4aa935
PE
5153 * image.c: Improve checking for integer overflow.
5154 (check_image_size): Assume that f is nonnull, since
5155 it is always nonnull in practice. This is one less thing to
5156 worry about when checking for integer overflow later.
5157 (x_check_image_size): New function, which checks for integer
5158 overflow issues inside X.
5159 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5160 This removes the need for a memory_full check.
5161 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5162 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5163 (xbm_read_bitmap_data): Change locals back to 'int', since
5164 their values must fit in 'int'.
5165 (xpm_load_image, png_load, tiff_load):
5166 Invoke x_create_x_image_and_pixmap earlier,
5167 to avoid much needless work if the image is too large.
5168 (tiff_load): Treat overly large images as if
5169 x_create_x_image_and_pixmap failed, not as malloc failures.
5170 (gs_load): Use x_check_image_size.
5171
5f8f9cc2
PE
5172 * gtkutil.c: Omit integer casts.
5173 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5174 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5175
5adf60bc
PE
5176 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5177
c8907a93
PE
5178 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5179 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5180 would wrongly return t on a 64-bit host.
5181
e3c25c68
PE
5182 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5183 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5184 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5185 and therefore cause GCC to emit a bogus diagnostic in some cases.
5186
3f791afe
PE
5187 * image.c: Integer signedness and overflow and related fixes.
5188 This is not an exhaustive set of fixes, but it's time to
5189 record what I've got.
5190 (lookup_pixel_color, check_image_size): Remove redundant decls.
5191 (check_image_size): Don't assume that arbitrary EMACS_INT values
5192 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5193 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5194 (tiff_load, imagemagick_load_image):
5195 Check for overflow in size calculations.
5196 (x_create_x_image_and_pixmap): Remove unnecessary test for
5197 xmalloc returning NULL; that can't happen.
5198 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5199 (xpm_color_bucket): Use better integer hashing function.
5200 (xpm_cache_color): Don't possibly over-allocate memory.
5201 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5202 (gif_memory_source):
5203 Use ptrdiff_t, not int or size_t, to record sizes.
5204 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5205 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5206 either works, as we prefer signed integers.
5207 (tiff_read_from_memory, tiff_write_from_memory):
5208 Return tsize_t, not size_t, since that's what the TIFF API wants.
5209 (tiff_read_from_memory): Don't fail simply because the read would
5210 go past EOF; instead, return a short read.
5211 (tiff_load): Omit no-longer-needed casts.
5212 (Fimagemagick_types): Don't assume size fits into 'int'.
5213
3cc5a532
PE
5214 Improve hashing quality when configured --with-wide-int.
5215 * fns.c (hash_string): New function, taken from sxhash_string.
5216 Do not discard information about ASCII character case; this
5217 discarding is no longer needed.
5218 (sxhash-string): Use it. Change sig to match it. Caller changed.
5219 * lisp.h: Declare it.
5220 * lread.c (hash_string): Remove, since we now use fns.c's version.
5221 The fns.c version returns a wider integer if --with-wide-int is
5222 specified, so this should help the quality of the hashing a bit.
5223
b312a492
PE
5224 * emacs.c: Integer overflow minor fix.
5225 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5226 Define only if GNU_LINUX.
5227 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5228
dfd153ae
PE
5229 * dispnew.c: Integer signedness and overflow fixes.
5230 Remove unnecessary forward decls, that were a maintenance hassle.
5231 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5232 All uses changed.
5233 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5234 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5235 (prepare_desired_row, line_draw_cost):
5236 Use int, not unsigned, where either works.
5237 (save_current_matrix, restore_current_matrix):
5238 Use ptrdiff_t, not size_t, where either works.
5239 (init_display): Check for overflow more accurately, and without
5240 relying on undefined behavior.
5241
a81d11a3
PE
5242 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5243 Remove, replacing with the new symbols in lisp.h. All uses changed.
5244 * fileio.c (make_temp_name):
5245 * filelock.c (lock_file_1, lock_file):
5246 * xdisp.c (message_dolog):
5247 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5248 Use pMd etc. instead.
5249 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5250 replacing the pWIDE etc. symbols removed from editfns.c.
5251
3300e6fd
PE
5252 * keyboard.h (num_input_events): Now uintmax_t.
5253 This is (very slightly) less likely to mess up due to wraparound.
5254 All uses changed.
5255
fd05c7e9
PE
5256 * buffer.c: Integer signedness fixes.
5257 (alloc_buffer_text, enlarge_buffer_text):
5258 Use ptrdiff_t rather than size_t when either will do, as we prefer
5259 signed integers.
5260
903fe15d
PE
5261 * alloc.c: Integer signedness and overflow fixes.
5262 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5263 (__malloc_size_t): Default to size_t, not to int.
5264 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5265 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5266 Prefer ptrdiff_t to size_t when either would do, as we prefer
5267 signed integers.
5268 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5269 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5270 Now const. Initialize with values that are in range even if char
5271 is signed.
5272 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5273 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5274 These functions do the right thing with sizes > 2**32.
5275 (check_depth): Now ptrdiff_t, not int.
5276 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5277 Adjust to new way of storing sizes. Check for size overflow bugs
5278 in rest of code.
5279 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5280 slightly wrong anyway, as it missed one instance of
5281 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5282 (refill_memory_reserve): Omit needless cast to size_t.
5283 (mark_object_loop_halt): Mark as externally visible.
5284
ac82cc6a
PE
5285 * xselect.c: Integer signedness and overflow fixes.
5286 (Fx_register_dnd_atom, x_handle_dnd_message):
5287 Use ptrdiff_t, not size_t, since we prefer signed.
5288 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5289 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5290 x_dnd_atoms_size and x_dnd_atoms_length.
5291
c2d1e36d
PE
5292 * doprnt.c: Prefer signed to unsigned when either works.
5293 * eval.c (verror):
5294 * doprnt.c (doprnt):
5295 * lisp.h (doprnt):
5296 * xdisp.c (vmessage):
5297 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5298 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5299 prefer signed arithmetic to avoid comparison confusion.
5300 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5301 but is a bit tricky.
5302
0e926e56
PE
5303 Assume freestanding C89 headers, string.h, stdlib.h.
5304 * data.c, doprnt.c, floatfns.c, print.c:
5305 Include float.h unconditionally.
5306 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5307 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5308 * regex.c: Likewise for stddef.h, string.h.
5309 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5310 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5311 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5312 (STDC_HEADERS): Remove obsolete defines.
5313 * sysdep.c: Include limits.h unconditionally.
5314
9cfdb3ec
PE
5315 Assume support for memcmp, memcpy, memmove, memset.
5316 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5317 * regex.c (memcmp, memcpy):
5318 Remove; we assume C89 now.
5319
5320 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5321 (__malloc_safe_bcopy): Remove; no longer needed.
5322
cf950e6b 5323 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
5324 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5325 well either way, and we prefer signed to unsigned.
5326
dbf38e02
LMI
53272011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5328
5329 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5330 closes the connection while we're reading (bug#9182).
5331
d6f0886c 53322011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 5333
d6f0886c
JD
5334 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5335 are specified (Bug#9168).
24e0f6b1 5336
2eb1f9e6
PE
53372011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5338
5339 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5340 Found by GCC static checking and --with-wide-int on a 32-bit host.
5341
22381272 53422011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
5343
5344 * xdisp.c (compute_display_string_pos): Fix logic of caching
5345 previous display string position. Initialize cached_prev_pos to
5346 -1. Fixes slow-down at the beginning of a buffer.
5347
f25e39b4
EZ
53482011-07-24 Eli Zaretskii <eliz@gnu.org>
5349
5350 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5351 for attrs[LFACE_FONTSET_INDEX].
5352
04c4b52e
PE
53532011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5354
5355 * xml.c (parse_region): Remove unused local
5356 that was recently introduced.
5357
c1734fbd
EZ
53582011-07-23 Eli Zaretskii <eliz@gnu.org>
5359
be18c5a5
EZ
5360 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5361 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5362
c1734fbd
EZ
5363 * xdisp.c (move_it_in_display_line_to): Record the best matching
5364 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
5365 exit if none of the characters scanned was an exact match.
5366 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
5367 when exact match is impossible due to invisible text, and the
5368 lines are truncated.
5369
a258d627
JD
53702011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5371
5372 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5373 for OSX >= 10.7.
5374
b6d5a689
EZ
53752011-07-22 Eli Zaretskii <eliz@gnu.org>
5376
0f74f785
EZ
5377 Fix a significant slow-down of cursor motion with C-n, C-p,
5378 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5379 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 5380 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
5381 (next_element_from_buffer): Call compute_stop_pos_backwards to
5382 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
5383 base_level_stop.
5384 (reseat): Don't look for prev_stop, as that could mean a very long
5385 run.
5386 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5387 <cached_disp_overlay_modiff>: Cache for last found display string
5388 position.
551918c1 5389 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
5390 about the same buffer in the same area of character positions, and
5391 the buffer wasn't changed since the time the display string
5392 position was cached.
551918c1 5393
b2d0c91a
EZ
53942011-07-22 Eli Zaretskii <eliz@gnu.org>
5395
5396 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5397 is an integer, which is important for empty lines. (Bug#9149)
5398
043604ee
CY
53992011-07-22 Chong Yidong <cyd@stupidchicken.com>
5400
5401 * frame.c (Fmodify_frame_parameters): In tty case, update the
5402 default face if necessary (Bug#4238).
5403
da4adb04
CY
54042011-07-21 Chong Yidong <cyd@stupidchicken.com>
5405
5406 * editfns.c (Fstring_to_char): No need to explain what a character
5407 is in the docstring (Bug#6576).
5408
9abd0532
LMI
54092011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5410
5411 * xml.c (parse_region): Make sure we always return a tree.
5412
36881d16
HK
54132011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5414
5415 * xml.c (parse_region): If a document contains only comments,
5416 return that, too.
5417
1e98674d
LMI
54182011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5419
5420 * xml.c (make_dom): Return comments, too.
5421
590bd467
PE
54222011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5423
5424 Port to OpenBSD.
5425 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5426 and the surrounding thread.
5427 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5428 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5429 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5430 timer goes off.
5431 * s/openbsd.h (BROKEN_SIGIO): Define.
5432 * unexelf.c (unexec) [__OpenBSD__]:
5433 Don't update the .mdebug section of the Alpha COFF symbol table.
5434
f41628b2
LMI
54352011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5436
5437 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5438 (bug#8460).
5439
b59b67c5
PE
54402011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5441
15e3a074
PE
5442 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5443 This fixes some race conditions on the permissions of any newly
5444 created file.
5445
41bed37d
PE
5446 * alloc.c (valid_pointer_p): Use pipe, not open.
5447 This fixes some permissions issues when debugging.
5448
b59b67c5
PE
5449 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5450 If fchown fails to set both uid and gid, try to set just gid,
5451 as that is sometimes allowed. Adjust the file's mode to eliminate
5452 setuid or setgid bits that are inappropriate if fchown fails.
5453
925a6be7
SM
54542011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5455
5456 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5457 to compare Lisp_Objects.
5458 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5459 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5460 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5461
52968808
AS
54622011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5463
0a6a104b
AS
5464 * lread.c (read_integer): Unread even EOF character.
5465 (read1): Likewise. Properly record start position of symbol.
5466
52968808
AS
5467 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5468 symbol character follows.
5469
9e381cdd
PE
54702011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5471
5472 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5473 This works around a problem with the previous change to Fcopy_file.
5474 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5475 and without this change, GCC might complain about discarding
5476 fchown's return value.
5477
b5641435
JB
54782011-07-16 Juanma Barranquero <lekktu@gmail.com>
5479
5480 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5481
a8031457
PE
54822011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5483
5484 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5485
dd889327
LMI
54862011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5487
750c33f7
LMI
5488 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5489 it's used from the C level.
5490
dd889327
LMI
5491 * process.c: Use the same condition for POLL_FOR_INPUT in both
5492 keyboard.c and process.c (bug#1858).
5493
87e86684
LM
54942011-07-09 Lawrence Mitchell <wence@gmx.li>
5495
5496 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5497 (Fgnutls_boot): Use it.
5498
64348f40
AS
54992011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5500
5501 * doc.c (Fsubstitute_command_keys): Revert last change.
5502
1d698799
LMI
55032011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5504
f863868c
LMI
5505 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5506 quotes the next character, and doesn't affect other longer
5507 sequences (bug#8935).
5508
1d698799
LMI
5509 * lread.c (syms_of_lread): Clarify that is isn't only
5510 `eval-buffer' and `eval-defun' that's affected by
5511 `lexical-binding' (bug#8460).
5512
aa4b6df6
EZ
55132011-07-15 Eli Zaretskii <eliz@gnu.org>
5514
5515 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 5516 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 5517
5d856da6
PE
55182011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5519
ad6042bb
PE
5520 Fix minor problems found by static checking.
5521 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5522 (elsz): Now a signed constant, not a size_t var. We prefer signed
5523 types to unsigned, to avoid integer comparison confusion. Without
5524 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5525 "cannot optimize loop, the loop counter may overflow", a symptom
5526 of the confusion.
f00bbb22 5527 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
5528 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5529
6468f31c
LMI
55302011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5531
49080b10
LMI
5532 * search.c (Fre_search_backward): Mention `case-fold-search' in
5533 all the re_search_* functions (bug#8138).
5534
6468f31c
LMI
5535 * keyboard.c (Fopen_dribble_file): Document when the file is
5536 closed (bug#8056).
5537
c965adc5
EZ
55382011-07-14 Eli Zaretskii <eliz@gnu.org>
5539
df9733bf
EZ
5540 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5541 bidi_cache_idx.
5542
0bb23927
EZ
5543 Support bidi reordering of display and overlay strings.
5544 * xdisp.c (compute_display_string_pos)
5545 (compute_display_string_end): Accept additional argument STRING.
5546 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5547 (reseat_to_string): Initialize bidi_it->string.s and
5548 bidi_it->string.schars.
5549 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
5550 NULL (avoids a crash in bidi_paragraph_init).
5551 Initialize itb.string.lstring.
0bb23927
EZ
5552 (init_iterator): Call bidi_init_it only of a valid
5553 buffer position was specified. Initialize paragraph_embedding to
5554 L2R.
5555 (reseat_to_string): Initialize the bidi iterator.
5556 (display_string): If we need to ignore text properties of
5557 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5558 original value of -1 will not work with bidi.)
5559 (compute_display_string_pos): First arg is now struct
5560 `text_pos *'; all callers changed. Support display properties on
5561 Lisp strings.
5562 (compute_display_string_end): Support display properties on Lisp
5563 strings.
5564 (init_iterator, reseat_1, reseat_to_string): Initialize the
5565 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5566 when iterating on a string not from display properties).
640c8776
SM
5567 (compute_display_string_pos, compute_display_string_end):
5568 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
5569 arrow keys.
5570 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
5571 base_level_stop; instead, set base_level_stop to BEGV.
5572 Fixes crashes in vertical-motion.
0bb23927
EZ
5573 (next_element_from_buffer): Improve commentary for when
5574 the iterator is before prev_stop.
5575 (init_iterator): Initialize bidi_p from the default value of
5576 bidi-display-reordering, not from buffer-local value. Use the
5577 buffer-local value only if initializing for buffer iteration.
5578 (handle_invisible_prop): Support invisible properties on strings
5579 that are being bidi-reordered.
5580 (set_iterator_to_next): Support bidi reordering of C strings and
5581 Lisp strings.
5582 (next_element_from_string): Support bidi reordering of Lisp
5583 strings.
5584 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
5585 (display_string): Support display of R2L glyph rows.
5586 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
5587 (init_iterator): Don't initialize it->bidi_p for strings
5588 here.
5589 (reseat_to_string): Initialize it->bidi_p for strings here.
5590 (next_element_from_string, next_element_from_c_string)
5591 (next_element_from_buffer): Add xassert's for correspondence
5592 between IT's object being iterated and it->bidi_it.string
5593 structure.
5594 (face_before_or_after_it_pos): Support bidi iteration.
5595 (next_element_from_c_string): Handle the case of the first string
5596 character that is not the first one in the visual order.
5597 (get_visually_first_element): New function, refactored from common
5598 parts of next_element_from_buffer, next_element_from_string, and
5599 next_element_from_c_string.
5600 (tool_bar_lines_needed, redisplay_tool_bar)
5601 (display_menu_bar): Force left-to-right direction. Add a FIXME
5602 comment for making that be controlled by a user option.
5603 (push_it, pop_it): Save and restore the state of the
5604 bidi iterator. Save and restore the bidi_p flag.
5605 (pop_it): Iterate out of display property for string iteration as
5606 well.
5607 (iterate_out_of_display_property): Support iteration over strings.
5608 (handle_single_display_spec): Set up it->bidi_it for iteration
5609 over a display string, and call bidi_init_it.
5610 (handle_single_display_spec, next_overlay_string)
5611 (get_overlay_strings_1, push_display_prop): Set up the bidi
5612 iterator for displaying display or overlay strings.
5613 (forward_to_next_line_start): Don't use the shortcut if
5614 bidi-iterating.
5615 (back_to_previous_visible_line_start): If handle_display_prop
5616 pushed the iterator stack, restore the internal state of the bidi
5617 iterator by calling bidi_pop_it same number of times.
5618 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5619 and we are bidi-iterating, don't decrement the iterator position;
5620 instead, set the first_elt flag in the bidi iterator, to produce
5621 the same effect.
5622 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5623 (push_display_prop): xassert that we are iterating a buffer.
5624 (push_it, pop_it): Save and restore paragraph_embedding member.
5625 (handle_single_display_spec, next_overlay_string)
5626 (get_overlay_strings_1, reseat_1, reseat_to_string)
5627 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5628 correctly. Don't assume unibyte strings are not bidi-reordered.
5629 (compute_display_string_pos)
5630 (compute_display_string_end): Fix handling the case of C string.
5631 (push_it, pop_it): Save and restore from_disp_prop_p.
5632 (handle_single_display_spec, push_display_prop): Set the
5633 from_disp_prop_p flag.
5634 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5635 (pop_it): Call iterate_out_of_display_property only if we are
5636 popping after iteration over a string that came from a display
5637 property. Fix a typo in popping stretch info. Add an assertion
5638 for verifying that the iterator position is in sync with the bidi
5639 iterator.
5640 (handle_single_display_spec, get_overlay_strings_1)
5641 (push_display_prop): Fix initialization of paragraph direction for
5642 string when that of the parent object is not yet determined.
5643 (reseat_1): Call bidi_init_it to resync the bidi
5644 iterator with IT's position. (Bug#7616)
5645 (find_row_edges): If ROW->start.pos gives position
5646 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5647 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5648 Reset the from_disp_prop_p flag.
5649 (SAVE_IT, RESTORE_IT): New macros.
5650 (pos_visible_p, face_before_or_after_it_pos)
5651 (back_to_previous_visible_line_start)
5652 (move_it_in_display_line_to, move_it_in_display_line)
5653 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5654 (try_scrolling, redisplay_window, display_line): Use them when
5655 saving a temporary copy of the iterator and restoring it back.
5656 (back_to_previous_visible_line_start, reseat_1)
5657 (init_iterator): Empty the bidi cache "stack".
5658 (move_it_in_display_line_to): If iterator ended up at
5659 EOL, but we never saw any buffer positions smaller than
5660 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5661 motion in bidi-reordered lines.
5662 (move_it_in_display_line_to): Record prev_method and prev_pos
5663 immediately before the call to set_iterator_to_next. Fixes cursor
5664 motion in bidi-reordered lines with stretch glyphs and strings
5665 displayed in margins. (Bug#8133) (Bug#8867)
5666 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5667 TO_CHARPOS.
640c8776
SM
5668 (pos_visible_p): Support positions in bidi-reordered lines.
5669 Save and restore bidi cache.
0bb23927
EZ
5670
5671 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5672 (bidi_paragraph_info): Delete unused struct.
5673 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5674 (bidi_cache_start): New variable.
5675 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5676 to zero.
5677 (bidi_cache_fetch_state, bidi_cache_search)
5678 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5679 (bidi_cache_find, bidi_peek_at_next_level)
5680 (bidi_level_of_next_char, bidi_find_other_level_edge)
5681 (bidi_move_to_visually_next): Compare cache index with
5682 bidi_cache_start rather than with zero.
5683 (bidi_fetch_char): Accept new argument STRING; all callers
5684 changed. Support iteration over a string. Support strings with
5685 display properties. Support unibyte strings. Fix the type of
5686 `len' according to what STRING_CHAR_AND_LENGTH expects.
5687 (bidi_paragraph_init, bidi_resolve_explicit_1)
5688 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
5689 (bidi_level_of_next_char, bidi_move_to_visually_next):
5690 Support iteration over a string.
0bb23927
EZ
5691 (bidi_set_sor_type, bidi_resolve_explicit_1)
5692 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5693 can now be zero (for strings); special values 0 and -1 were
5694 changed to -1 and -2, respectively.
5695 (bidi_char_at_pos): New function.
5696 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5697 Call it instead of FETCH_MULTIBYTE_CHAR.
5698 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5699 initialized to valid values.
5700 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5701 values.
5702 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5703 the test for valid cached positions. Fix the logic for looking up
5704 the sentinel state in the cache. GCPRO the Lisp string we are
5705 iterating.
5706 (bidi_push_it, bidi_pop_it): New functions.
5707 (bidi_initialize): Initialize the bidi cache start stack pointer.
5708 (bidi_cache_ensure_space): New function, refactored from part of
5709 bidi_cache_iterator_state. Don't assume the required size is just
5710 one BIDI_CACHE_CHUNK away.
5711 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5712 (bidi_count_bytes, bidi_char_at_pos): New functions.
5713 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5714 always valid if bidi_cache_idx is valid.
5715 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5716 is valid if it's going to be used.
5717 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5718 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
5719 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5720 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
5721 (bidi_find_other_level_edge, bidi_cache_start_stack):
5722 All variables related to cache indices are now EMACS_INT.
c965adc5 5723
0bb23927
EZ
5724 * dispextern.h (struct bidi_string_data): New structure.
5725 (struct bidi_it): New member `string'. Make flag members be 1-bit
5726 fields, and put them last in the struct.
640c8776
SM
5727 (compute_display_string_pos, compute_display_string_end):
5728 Update prototypes.
0bb23927
EZ
5729 (bidi_push_it, bidi_pop_it): Add prototypes.
5730 (struct iterator_stack_entry): New members bidi_p,
5731 paragraph_embedding, and from_disp_prop_p.
5732 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
5733 (bidi_shelve_cache, bidi_unshelve_cache):
5734 Declare prototypes.
0bb23927
EZ
5735
5736 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5737 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5738 and vector-like objects.
5739
5740 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5741 cache around display iteration.
5742
5743 * window.c (Fwindow_end, window_scroll_pixel_based)
5744 (displayed_window_lines, Frecenter): Save and restore the bidi
5745 cache around display iteration.
5746
3bbd2265
LMI
57472011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5748
5749 * editfns.c (Fdelete_region): Clarify the use of the named
5750 parameters (bug#6788).
5751
adc47434
MR
57522011-07-14 Martin Rudalics <rudalics@gmx.at>
5753
5754 * indent.c (Fvertical_motion): Set and restore w->pointm when
5755 saving and restoring the window's buffer (Bug#9006).
5756
837c31f8
LMI
57572011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
5758
5759 * editfns.c (Fstring_to_char): Clarify just what is returned
5760 (bug#6576). Text by Eli Zaretskii.
5761
ac389d0c
JB
57622011-07-13 Juanma Barranquero <lekktu@gmail.com>
5763
5764 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
5765
0be0ce47
EZ
57662011-07-13 Eli Zaretskii <eliz@gnu.org>
5767
5768 * buffer.c (mmap_find): Fix a typo.
5769
cd18e7e3
JB
57702011-07-13 Johan Bockgård <bojohan@gnu.org>
5771
5772 Fix execution of x selection hooks.
5773 * xselect.c (Qx_lost_selection_functions)
5774 (Qx_sent_selection_functions): New vars.
5775 (syms_of_xselect): DEFSYM them.
5776 (x_handle_selection_request): Pass Qx_sent_selection_functions
5777 rather than Vx_sent_selection_functions to Frun_hook_with_args.
5778 (x_handle_selection_clear,x_clear_frame_selections):
5779 Pass Qx_lost_selection_functions rather than
5780 Vx_lost_selection_functions to Frun_hook_with_args.
5781
47ea7f44
PE
57822011-07-13 Paul Eggert <eggert@cs.ucla.edu>
5783
ac389d0c 5784 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
5785 The old code sometimes used this field without initializing it.
5786
47ea7f44
PE
5787 * alloc.c (gc_sweep): Don't read past end of array.
5788 In theory, the old code could also have corrupted Emacs internals,
5789 though it'd be very unlikely.
5790
bc985c87
AS
57912011-07-12 Andreas Schwab <schwab@linux-m68k.org>
5792
5793 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 5794 argument. (Bug#4026)
bc985c87 5795
0cf34688
LMI
57962011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
5797
b3dadd76
LMI
5798 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
5799 key" (bug#4257).
5800
0cf34688
LMI
5801 * window.c (Fset_window_start): Doc fix (bug#4199).
5802 (Fset_window_hscroll): Ditto.
5803
270768cd
PE
58042011-07-12 Paul Eggert <eggert@cs.ucla.edu>
5805
077e3dda 5806 Fix minor new problems caught by GCC 4.6.1.
270768cd 5807 * term.c (init_tty): Remove unused local.
490011a6 5808 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 5809 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 5810 not used otherwise.
270768cd 5811
b1f58454
CY
58122011-07-12 Chong Yidong <cyd@stupidchicken.com>
5813
5814 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
5815
22b9578d
LMI
58162011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5817
6e70ab07
LMI
5818 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
5819 are the mini-buffer and the echo area (bug#3320).
5820
22b9578d
LMI
5821 * term.c (init_tty): Remove support for supdup, c10 and perq
5822 terminals, which are no longer supported (bug#1482).
5823
8974cc9f
JB
58242011-07-10 Johan Bockgård <bojohan@gnu.org>
5825
5826 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
5827
a560d974
JD
58282011-07-10 Jan Djärv <jan.h.d@swipnet.se>
5829
5830 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
5831 for non-popups (Bug#3642).
5832
1dae0f0a
AS
58332011-07-10 Andreas Schwab <schwab@linux-m68k.org>
5834
268c2c36 5835 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 5836 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
5837 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
5838 * cm.c (losecursor): Likewise.
1dae0f0a
AS
5839 * data.c (fmod): Likewise.
5840 * dispnew.c (swap_glyphs_in_rows): Likewise.
5841 * emacs.c (memory_warning_signal): Likewise.
5842 * floatfns.c (float_error): Likewise.
5843 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
5844 (otf_open, font_otf_capability, generate_otf_features)
5845 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
5846 Likewise.
5847 * image.c (pbm_read_file): Likewise.
5848 * indent.c (string_display_width): Likewise.
5849 * intervals.c (check_for_interval, search_for_interval)
5850 (inc_interval_count, count_intervals, root_interval)
5851 (adjust_intervals_for_insertion, make_new_interval): Likewise.
5852 * lread.c (defalias): Likewise.
268c2c36 5853 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
5854 * regex.c (set_image_of_range_1, set_image_of_range)
5855 (regex_grow_registers): Likewise.
5856 * sysdep.c (strerror): Likewise.
5857 * termcap.c (valid_filename_p, tprint, main): Likewise.
5858 * tparam.c (main): Likewise.
5859 * unexhp9k800.c (run_time_remap, save_data_space)
5860 (update_file_ptrs, read_header, write_header, calculate_checksum)
5861 (copy_file, copy_rest, display_header): Likewise.
5862 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
5863 Likewise.
5864 * xdisp.c (check_it): Likewise.
5865 * xfaces.c (register_color, unregister_color, unregister_colors):
5866 Likewise.
5867 * xfns.c (print_fontset_result): Likewise.
5868 * xrdb.c (member, fatal, main): Likewise.
5869
99033785
PE
58702011-07-10 Paul Eggert <eggert@cs.ucla.edu>
5871
5872 Fix minor problems found by static checking (Bug#9031).
5873 * chartab.c (char_table_set_range, map_sub_char_table):
5874 Remove unused locals.
5875 (uniprop_table): Now static.
5876 * composite.c (_work_char): Remove unused static var.
5877
9cb2ac56
JB
58782011-07-09 Juanma Barranquero <lekktu@gmail.com>
5879
5880 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
5881
f25661f0
JD
58822011-07-09 Jan Djärv <jan.h.d@swipnet.se>
5883
5884 * gtkutil.c (qttip_cb): Remove code without function.
5885
8278c4fe
EZ
58862011-07-09 Eli Zaretskii <eliz@gnu.org>
5887
5888 * w32.c (pthread_sigmask): New stub.
5889
1692ae2d 58902011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 5891
8a6ebd58 5892 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
5893 sigprocmask is portable only for single-threaded applications, and
5894 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
5895 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
5896 (LIBES): Use it.
5897 * callproc.c (Fcall_process):
5898 * process.c (create_process):
5899 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
5900 Use pthread_sigmask, not sigprocmask.
123403e4 5901
1b854618
JD
59022011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5903
5904 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
5905 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
5906 wrong (Bug#8591).
5907
3fe4b549
JD
59082011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5909
0ce7e563
JD
5910 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
5911 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
5912 (xg_hide_tooltip): Fix comment.
5913
3fe4b549
JD
5914 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
5915 in registerServicesMenuSendTypes.
5916 (validRequestorForSendType): Don't check ns_return_types.
5917
5918 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
5919 ns_return_type.
5920
5df75e47
JR
59212011-07-08 Jason Rumney <jasonr@gnu.org>
5922
22610910
JR
5923 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
5924 SH_SHOW for hidden windows (Bug#5482).
5925
5df75e47
JR
5926 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
5927 frame struct members of non-existent frames (Bug#6284).
5928
699c10bd
JD
59292011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5930
4393663b
JD
5931 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
5932 variable firstTime not needed on OSX >= 10.6.
5933 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
5934 >= 10.5. Use setKnobProportion, setDoubleValue.
5935
5936 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
5937 (MAC_OS_X_VERSION_10_5): Define if not defined.
5938 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
5939 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
5940 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
5941
5942 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
5943 cString and lossyCString on OSX >= 10.4
5944
58179cce 5945 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
5946 sizeToFit on OSX >= 10.2.
5947
5948 * nsimage.m (allocInitFromFile): Don't use deprecated method
5949 bestRepresentationForDevice on OSX >= 10.6.
5950
5951 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
5952 to avoid warning.
5953
5954 * emacs.c: Declare unexec_init_emacs_zone.
5955
a63e0781
JD
5956 * nsgui.h: Fix compiler warning about gnulib redefining verify.
5957
699c10bd
JD
5958 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
5959
5960 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
5961 on svcsMenu (Bug#8842).
5962
5963 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
5964 ns_return_types.
5965 (Fns_list_services): Just return Qnil on 10.6, code not working there.
5966
5967 * nsterm.m (QUTF8_STRING): Declare.
5968 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
5969 (validRequestorForSendType): Return type is (id).
5970 Change indexOfObjectIdenticalTo to indexOfObject.
5971 Check if we have local selection before returning self (Bug#8842).
5972 (writeSelectionToPasteboard): Put local selection into paste board
5973 if we have a local selection (Bug#8842).
5974 (syms_of_nsterm): DEFSYM QUTF8_STRING.
5975
5976 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
5977 (ns_get_local_selection): Declare.
5978
54e10184
LMI
59792011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
5980
9888ff71
LMI
5981 * keymap.c (describe_map_tree): Don't insert a double newline at
5982 the end of the buffer (bug#1169) and return whether we inserted
5983 something.
5984
54e10184
LMI
5985 * callint.c (Fcall_interactively): Change "reading args" to
5986 "providing args" to try to clarify what it does (bug#1010).
5987
15fa4783
KH
59882011-07-07 Kenichi Handa <handa@m17n.org>
5989
5990 * composite.c (composition_compute_stop_pos): Ignore a static
5991 composition starting before CHARPOS (Bug#8915).
5992
5993 * xdisp.c (handle_composition_prop): Likewise.
5994
a8815b00
EZ
59952011-07-07 Eli Zaretskii <eliz@gnu.org>
5996
5997 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
5998 (Bug#9015)
5999
ef7b981d 60002011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6001
6002 * character.h (unicode_category_t): New enum type.
6003
6004 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6005 (Qchar_code_property_table): New variable.
6006 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6007 (UNIPROP_COMPRESSED_FORM_P): New macros.
6008 (char_table_ascii): Uncompress the compressed values.
6009 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6010 Uncompress the compressed values.
ac389d0c 6011 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6012 (char_table_ref_and_range): Uncompress the compressed values.
6013 (sub_char_table_set): New arg is_uniprop. Callers changed.
6014 Uncompress the compressed values.
6015 (sub_char_table_set_range): Args changed. Callers changed.
6016 (char_table_set_range): Adjuted for the above change.
6017 (map_sub_char_table): Delete args default_val and parent. Add arg
6018 top. Give decoded values to a Lisp function.
640c8776 6019 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6020 values to a Lisp function. Gcpro more variables.
6021 (uniprop_table_uncompress)
6022 (uniprop_decode_value_run_length): New functions.
6023 (uniprop_decoder, uniprop_decoder_count): New variables.
6024 (uniprop_get_decoder, uniprop_encode_value_character)
6025 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6026 New functions.
6027 (uniprop_encoder, uniprop_encoder_count): New variables.
6028 (uniprop_get_encoder, uniprop_table)
6029 (Funicode_property_table_internal, Fget_unicode_property_internal)
6030 (Fput_unicode_property_internal): New functions.
6031 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6032 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6033 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6034 char-code-property-alist.
6035
640c8776 6036 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6037 Vunicode_category_table.
6038
640c8776 6039 * font.c (font_range): Adjust for the change of
c805dec0
KH
6040 Vunicode_category_table.
6041
76b397fb
DN
60422011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6043
6044 * m/iris4d.h: Remove file, move contents ...
6045 * s/irix6-5.h: ... here.
6046
22b4128e
PE
60472011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6048
6049 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6050 * alloc.c (mark_buffer):
6051 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6052 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6053 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6054 This isn't true in general, and it's particularly not true
6055 if Emacs is configured with --with-wide-int.
6056 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6057 New macros, used in the buffer.c change.
6058
869795d6
JD
60592011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6060
6061 * xsettings.c: Use both GConf and GSettings if both are available.
6062 (store_config_changed_event): Add comment.
6063 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6064 (store_tool_bar_style_changed): New functions.
5e617bc2 6065 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6066 (struct xsettings): Move font inside HAVE_XFT.
6067 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6068 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6069 Move inside HAVE_XFT.
640c8776 6070 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6071 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6072 also.
6073 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6074 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6075 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6076 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6077 (parse_settings): Move check for font inside HAVE_XFT.
6078 (read_settings, apply_xft_settings): Add comment.
6079 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6080 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6081 call store_font_name_changed.
6082 (xft_settings_event): Add comment.
6083 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6084 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6085 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6086 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6087 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6088 (xsettings_get_system_font, xsettings_get_system_normal_font):
6089 Add comment.
869795d6 6090
d8ed26bd
PE
60912011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6092
6093 Random fixes. E.g., (random) never returned negative values.
6094 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6095 subseconds part to the entropy, as that's a bit more random.
6096 Prefer signed to unsigned, since the signedness doesn't matter and
6097 in general we prefer signed. When given a limit, use a
6098 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6099 latter isn't right if USE_2_TAGS_FOR_INTS.
6100 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6101 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6102
cabf1cac
SM
61032011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6104
6105 * textprop.c (text_property_stickiness):
6106 Obey Vtext_property_default_nonsticky.
6107 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6108 * w32fns.c (syms_of_w32fns):
6109 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6110
6e9b2be9
PE
61112011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6112
6113 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6114 This is more efficient than Ffile_directory_p and avoids a minor race.
6115
90186c68
LMI
61162011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6117
7c301272
LMI
6118 * buffer.c (Foverlay_put): Say what the return value is
6119 (bug#7835).
6120
c4f2d8d4
LMI
6121 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6122 is a directory before asking whether to use the file name
6123 (bug#7564).
ad637907
LMI
6124 (barf_or_query_if_file_exists): Make the "File is a directory"
6125 error be more correct.
c4f2d8d4 6126
90186c68
LMI
6127 * fns.c (Frequire): Remove the mention of the .gz files, since
6128 that's installation-specific, but keep the mention of
6129 `get-load-suffixes'.
6130
da64016e
PE
61312011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6132
6133 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6134 Report string overflow if the output is too long.
6135
7d47b580
JB
61362011-07-04 Juanma Barranquero <lekktu@gmail.com>
6137
a555cb87
JB
6138 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6139 (syms_of_gnutls): Remove duplicate DEFSYM for
6140 Qgnutls_bootprop_verify_hostname_error, an error for
6141 Qgnutls_bootprop_verify_error (which is no longer used).
6142
7d47b580
JB
6143 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6144 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6145 Also (re)move comments that are misplaced or no longer relevant.
6146
1e49bfab
LMI
61472011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6148
6149 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6150
1485f4c0
CY
61512011-07-03 Chong Yidong <cyd@stupidchicken.com>
6152
6153 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6154 and background color parameters if they have been changed.
6155
a9ab721e
LMI
61562011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6157
6158 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6159
cf7cff57
PE
61602011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6161
2e13213d
PE
6162 * xsettings.c (SYSTEM_FONT): Define only when used.
6163 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6164
cf7cff57
PE
6165 * keymap.c (access_keymap_1): Now static.
6166
7a8e04f7
CY
61672011-07-02 Chong Yidong <cyd@stupidchicken.com>
6168
6169 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6170 leave any prefix arg for the up event (Bug#1586).
6171
61352f62
LMI
61722011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6173
69bb1ef7
LMI
6174 * lread.c (syms_of_lread): Mention single symbols defined by
6175 `defvar' or `defconst' (bug#7154).
6176
61352f62 6177 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 6178 (Frequire): Mention get-load-suffixes.
61352f62 6179
28545e04
MR
61802011-07-02 Martin Rudalics <rudalics@gmx.at>
6181
6182 * window.h (window): Remove clone_number slot.
6183 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6184 Remove.
6185 (make_parent_window, make_window, saved_window)
6186 (Fset_window_configuration, save_window_save): Don't deal with
6187 clone numbers.
6188 * buffer.c (Qclone_number): Remove declaration.
6189 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6190
3349e122
SM
61912011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6192
6193 Add multiple inheritance to keymaps.
6194 * keymap.c (Fmake_composed_keymap): New function.
6195 (Fset_keymap_parent): Simplify.
6196 (fix_submap_inheritance): Remove.
6197 (access_keymap_1): New function extracted from access_keymap to handle
6198 embedded parents and handle lists of maps.
6199 (access_keymap): Use it.
6200 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6201 (Fcopy_keymap): Handle embedded parents.
6202 (Fcommand_remapping, define_as_prefix): Simplify.
6203 (Fkey_binding): Simplify.
6204 (syms_of_keymap): Move minibuffer-local-completion-map,
6205 minibuffer-local-filename-completion-map,
6206 minibuffer-local-must-match-map, and
6207 minibuffer-local-filename-must-match-map to Elisp.
6208 (syms_of_keymap): Defsubr make-composed-keymap.
6209 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6210 (parse_menu_item): Trivial simplification.
6211
3279eb87
GM
62122011-07-01 Glenn Morris <rgm@gnu.org>
6213
6214 * Makefile.in (SETTINGS_LIBS): Fix typo.
6215
4550efdf
KI
62162011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6217
6218 * coding.c (Fencode_coding_string): Record the last coding system
6219 used, as the function doc string says (bug#8738).
6220
0949d2b6
JD
62212011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6222
6223 * xsettings.c (store_monospaced_changed): Take new font as arg and
6224 check for change against current_mono_font.
6225 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6226 (emacs_settings_constructor, emacs_settings_get_property)
6227 (emacs_settings_set_property, emacs_settings_class_init)
6228 (emacs_settings_init, gsettings_obj): Remove.
6229 (something_changedCB): New function for HAVE_GSETTINGS.
6230 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6231 with value as argument.
6232 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6233 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 6234 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
6235 "changed".
6236
6237 * xgselect.c: Add defined (HAVE_GSETTINGS).
6238 (xgselect_initialize): Ditto.
6239
6240 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6241 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6242 xg_select.
6243
bbc6b304
PE
62442011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6245
6246 * eval.c (struct backtrace): Simplify and port the data structure.
6247 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6248 signed bit field, as this assumption is not portable and it makes
6249 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6250 "char debug_on_exit : 1" as this is not portable either; instead,
6251 use the portable "unsigned int debug_on_exit : 1". Remove unused
6252 member evalargs. Remove obsolete comments about cc bombing out.
6253
9851bfc5
JD
62542011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6255
51bb811f 6256 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
6257 Let HAVE_GSETTINGS override HAVE_GCONF.
6258 (store_monospaced_changed): New function.
6259 (EMACS_SETTINGS): A new type derived from GObject to handle
6260 GSettings notifications.
6261 (emacs_settings_constructor, emacs_settings_get_property)
6262 (emacs_settings_set_property, emacs_settings_class_init):
6263 New functions.
6264 (gsettings_client, gsettings_obj): New variables.
6265 (GSETTINGS_SCHEMA): New define.
6266 (something_changedCB): Call store_monospaced_changed.
6267 (init_gsettings): New function.
6268 (xsettings_initialize): Call init_gsettings.
6269 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6270 to NULL.
6271
640c8776 6272 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
6273 GCONF_CFLAGS/LIBS.
6274
5386012d
MR
62752011-06-29 Martin Rudalics <rudalics@gmx.at>
6276
6277 * window.c (resize_root_window, grow_mini_window)
6278 (shrink_mini_window): Rename Qresize_root_window to
6279 Qwindow_resize_root_window and Qresize_root_window_vertically to
6280 Qwindow_resize_root_window_vertically.
6281
f13e0b08
PE
62822011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6283
6284 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6285
94515237
JB
62862011-06-27 Juanma Barranquero <lekktu@gmail.com>
6287
6288 * makefile.w32-in: Redesign dependencies so they reflect more
6289 clearly which files are directly included by each source file,
6290 and not through other includes.
6291
e43b6e43
MR
62922011-06-27 Martin Rudalics <rudalics@gmx.at>
6293
6294 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6295 (sort_overlays, overlay_strings): When an overlay's clone number
6296 matches the window's clone number process the overlay even if
6297 the overlay's window property doesn't match the current window.
6298
d68443dc
MR
6299 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6300 (Fwindow_hchild): Rename to Fwindow_left_child.
6301 (Fwindow_next): Rename to Fwindow_next_sibling.
6302 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
6303 (resize_window_check): Rename to window_resize_check.
6304 (resize_window_apply): Rename to window_resize_apply.
6305 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6306 (Fdelete_other_windows_internal, resize_frame_windows)
6307 (Fsplit_window_internal, Fdelete_window_internal)
6308 (grow_mini_window, shrink_mini_window)
6309 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 6310
c7e73be5
JD
63112011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6312
6313 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6314 (emacs_fixed_set_min_size): Remove.
6315 (emacs_fixed_new): Take frame as argument.
6316
6317 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6318 (_EmacsFixedPrivate): Remove minwidth/height.
6319 Add struct frame *f.
6320 (emacs_fixed_init): Initialize priv->f.
6321 (get_parent_class, emacs_fixed_set_min_size): Remove.
6322 (emacs_fixed_new): Set priv->f to argument.
6323 (emacs_fixed_get_preferred_width)
6324 (emacs_fixed_get_preferred_height): Use min_width/height from
6325 frames size_hint to set minimum and natural (Bug#8919).
6326 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6327 and use min_width/height from frames size_hint to set
6328 min_width/height (Bug#8919).
6329
6330 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
6331 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6332 Fix indentation.
c7e73be5 6333
cf99dcf8
EZ
63342011-06-26 Eli Zaretskii <eliz@gnu.org>
6335
6336 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6337 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6338 called at ZV.
6339
029529ac
CY
63402011-06-26 Chong Yidong <cyd@stupidchicken.com>
6341
6342 * process.c (wait_reading_process_output): Bypass select if
6343 waiting for a cell while ignoring keyboard input, and input is
6344 pending. Suggested by Jan Djärv (Bug#8869).
6345
7a7ef429
PE
63462011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6347
6348 Use gnulib's dup2 module instead of rolling our own.
6349 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6350
11fdef7d 63512011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
6352
6353 * dispnew.c (scrolling_window): Before scrolling, turn off a
6354 mouse-highlight in the window being scrolled.
6355
cd3520a4
JB
63562011-06-24 Juanma Barranquero <lekktu@gmail.com>
6357
6358 Move DEFSYM to lisp.h and use everywhere.
6359
6360 * character.h (DEFSYM): Move declaration...
6361 * lisp.h (DEFSYM): ...here.
6362
6363 * gnutls.c:
6364 * minibuf.c:
6365 * w32menu.c:
6366 * w32proc.c:
6367 * w32select.c: Don't include character.h.
6368
6369 * alloc.c (syms_of_alloc):
6370 * buffer.c (syms_of_buffer):
6371 * bytecode.c (syms_of_bytecode):
6372 * callint.c (syms_of_callint):
6373 * casefiddle.c (syms_of_casefiddle):
6374 * casetab.c (init_casetab_once):
6375 * category.c (init_category_once, syms_of_category):
6376 * ccl.c (syms_of_ccl):
6377 * cmds.c (syms_of_cmds):
6378 * composite.c (syms_of_composite):
6379 * dbusbind.c (syms_of_dbusbind):
6380 * dired.c (syms_of_dired):
6381 * dispnew.c (syms_of_display):
6382 * doc.c (syms_of_doc):
6383 * editfns.c (syms_of_editfns):
6384 * emacs.c (syms_of_emacs):
6385 * eval.c (syms_of_eval):
6386 * fileio.c (syms_of_fileio):
6387 * fns.c (syms_of_fns):
6388 * frame.c (syms_of_frame):
6389 * fringe.c (syms_of_fringe):
6390 * insdel.c (syms_of_insdel):
6391 * keymap.c (syms_of_keymap):
6392 * lread.c (init_obarray, syms_of_lread):
6393 * macros.c (syms_of_macros):
6394 * msdos.c (syms_of_msdos):
6395 * print.c (syms_of_print):
6396 * process.c (syms_of_process):
6397 * search.c (syms_of_search):
6398 * sound.c (syms_of_sound):
6399 * syntax.c (init_syntax_once, syms_of_syntax):
6400 * terminal.c (syms_of_terminal):
6401 * textprop.c (syms_of_textprop):
6402 * undo.c (syms_of_undo):
6403 * w32.c (globals_of_w32):
6404 * window.c (syms_of_window):
6405 * xdisp.c (syms_of_xdisp):
6406 * xfaces.c (syms_of_xfaces):
6407 * xfns.c (syms_of_xfns):
6408 * xmenu.c (syms_of_xmenu):
6409 * xsettings.c (syms_of_xsettings):
6410 * xterm.c (syms_of_xterm): Use DEFSYM.
6411
4228cf16
TZ
64122011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6413
cd3520a4 6414 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 6415
7fcccf1e
PE
64162011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6417
7efb4e0e
PE
6418 Integer and buffer overflow fixes (Bug#8873).
6419
ff5844ad
PE
6420 * print.c (printchar, strout): Check for string overflow.
6421 (PRINTPREPARE, printchar, strout):
6422 Don't set size unless allocation succeeds.
6423
90532f02
PE
6424 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6425 for sizes. Check for string overflow more accurately.
6426 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6427
6d84508d
PE
6428 * macros.c: Integer and buffer overflow fixes.
6429 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6430 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6431 Use ptrdiff_t, not int, for sizes.
6432 Don't increment bufsize until after realloc succeeds.
6433 Check for size-calculation overflow.
6434 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6435
437b2cb4
PE
6436 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6437
8b9ac8b4
PE
6438 * lread.c: Integer overflow fixes.
6439 (read_integer): Radix is now EMACS_INT, not int,
6440 to improve quality of diagnostics for out-of-range radices.
6441 Calculate buffer size correctly for out-of-range radices.
6442 (read1): Check for integer overflow in radices, and in
6443 read-circle numbers.
82cb60d3
PE
6444 (read_escape): Avoid int overflow.
6445 (Fload, openp, read_buffer_size, read1)
6446 (substitute_object_recurse, read_vector, read_list, map_obarray):
6447 Use ptrdiff_t, not int, for sizes.
6448 (read1): Use EMACS_INT, not int, for sizes.
20270765 6449 Check for size overflow.
8b9ac8b4 6450
7fcccf1e
PE
6451 * image.c (cache_image): Check for size arithmetic overflow.
6452
bfbbd7e7
PE
6453 * lread.c: Integer overflow issues.
6454 (saved_doc_string_size, saved_doc_string_length)
6455 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6456 Now ptrdiff_t, not int.
6457 (read1): Don't assume doc string length fits in int. Check for
6458 out-of-range doc string lengths.
6459 (read_list): Don't assume file position fits in int.
39019e54 6460 (read_escape): Check for hex character overflow.
bfbbd7e7 6461
4e323265
LL
64622011-06-22 Leo Liu <sdl.web@gmail.com>
6463
6464 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6465 Move to minibuffer.el.
6466
85fece3e
PE
64672011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6468
20b84ce9 6469 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
6470 The following patches are for when GLYPH_DEBUG && !XASSERT.
6471 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6472 * dispnew.c (flush_stdout):
6473 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6474 Mark as externally visible.
6475 * dispnew.c (check_window_matrix_pointers): Now static.
6476 * dispnew.c (window_to_frame_vpos):
6477 * xfns.c (unwind_create_frame):
6478 * xterm.c (x_check_font): Remove unused local.
6479 * scroll.c (CHECK_BOUNDS):
6480 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6481 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6482 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6483 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6484 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6485 Now static.
6486 (debug_method_add): Use va_list and vsprintf rather than relying
6487 on undefined behavior with wrong number of arguments.
6488 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6489 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6490 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6491 since we're not interested in debugging glyphs with old libraries.
6492 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6493 GCC 4.6.0's static checking.
6494
0766b489
PE
64952011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6496
31fd4b32
PE
6497 Integer overflow and signedness fixes (Bug#8873).
6498 A few related buffer overrun fixes, too.
6499
b79e8648
PE
6500 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6501
0766b489
PE
6502 * dispextern.h (struct face.stipple):
6503 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6504 (x_bitmap_mask, x_allocate_bitmap_record)
6505 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6506 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6507 (x_create_bitmap_from_xpm_data):
6508 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6509 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6510 (.bitmaps_last):
6511 * xfaces.c (load_pixmap):
6512 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6513 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6514 (.bitmaps_last, struct x_output.icon_bitmap):
6515 Use ptrdiff_t, not int, for bitmap indexes.
6516 (x_allocate_bitmap_record): Check for size overflow.
6517 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6518
b081724f
PE
6519 Use ptrdiff_t, not int, for overlay counts.
6520 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6521 * editfns.c (overlays_around, get_pos_property):
6522 * textprop.c (get_char_property_and_overlay):
6523 * xdisp.c (next_overlay_change, note_mouse_highlight):
6524 * xfaces.c (face_at_buffer_position):
21514da7
PE
6525 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6526 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6527 (Fnext_overlay_change, Fprevious_overlay_change)
6528 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 6529 Use ptrdiff_t, not int, for sizes.
21514da7 6530 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 6531
3de73e5e
PE
6532 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6533
2606c57b
PE
6534 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6535 (x_session_initialize): Do not assume string length fits in int.
6536
aaafe47a
PE
6537 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6538 This is unlikely, but can occur if DPI is outlandish.
6539
2674ddc8 6540 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
6541 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6542
28154962
PE
6543 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6544 * xrdb.c (magic_file_p, search_magic_path):
6545 Omit last arg SUFFIX; it was always 0. All callers changed.
6546 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6547
7de51af5
PE
6548 * xfont.c (xfont_match): Avoid need for strlen.
6549
25ed6cc3
PE
6550 * xfns.c: Don't assume strlen fits in int.
6551 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6552
4eab31dd
PE
6553 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6554 not unsigned long, as we prefer signed integers. All callers changed.
6555 Detect integer overflow in repeat count.
6556 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 6557 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 6558
171e2a58
PE
6559 * termcap.c: Don't assume sizes fit in int and never overflow.
6560 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6561 (gobble_line): Check for size-calculation overflow.
6562
ad39faca 6563 * minibuf.c (Fread_buffer):
6e5bb2dc 6564 * lread.c (intern, intern_c_string):
74ca2eb3
PE
6565 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6566 Don't assume string length fits in int.
6567
52c61c22 6568 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
6569 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6570
b5b8c9e5
PE
6571 * font.c: Don't assume string length fits in int.
6572 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6573 Use ptrdiff_t, not int.
ccd6111c
PE
6574 (font_intern_prop): Don't assume string length fits in int.
6575 Don't assume integer property fits in fixnum.
6576 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 6577
882f0d81 6578 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 6579 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
6580 Reformulate so as not to need the command string.
6581 Invoke gzip -cd rather than gunzip, as it's more portable.
6582 (lock_info_type, lock_file_1, lock_file):
6583 Don't assume pid_t and time_t fit in unsigned long.
6584 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6585 (current_lock_owner): Prefer signed type for sizes.
6586 Use memcpy, not strncpy, where memcpy is what is really wanted.
6587 Don't assume (via atoi) that time_t and pid_t fit in int.
6588 Check for time_t and/or pid_t out of range, e.g., via a network share.
6589 Don't alloca where an auto var works fine.
6590
93f4cf88
PE
6591 * fileio.c: Fix some integer overflow issues.
6592 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6593 Don't assume string length fits in int.
6594 (directory_file_name): Don't assume string length fits in long.
6595 (make_temp_name): Don't assume pid fits in int, or that its print
6596 length is less than 20.
6597
f3e92b69
PE
6598 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6599
1bfdaf10
PE
6600 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6601
35016e9a
PE
6602 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6603
3d1e65a1
PE
6604 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6605 We prefer signed integers, even for size calculations.
6606
0b963a93
PE
6607 * emacs.c: Don't assume string length fits in 'int'.
6608 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6609 (main): Don't invoke strlen when not needed.
6610
573f4b54
PE
6611 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6612 (XD_DEBUG_MESSAGE): Don't waste a byte.
6613
989f33ba
PE
6614 * callproc.c (getenv_internal_1, getenv_internal)
6615 (Fgetenv_internal):
965d34eb
PE
6616 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6617
e4d29b33
PE
6618 * lread.c (invalid_syntax): Omit length argument.
6619 All uses changed. This doesn't fix a bug, but it simplifies the
6620 code away from its former Hollerith-constant appearance, and it's
6621 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 6622 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 6623
eb49b136
PE
6624 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6625 This didn't break anything, but it didn't help either.
6626 It's confusing to put a bogus integer in a place where the actual
6627 value does not matter.
9f62aeb1 6628 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 6629 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 6630
15375a22
PE
6631 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6632 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6633 implementation.
b61cc01c
PE
6634 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6635 We prefer signed types, and the value cannot exceed the EMACS_INT
6636 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
6637 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6638 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6639 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 6640
53b2623d
PE
6641 * indent.c (sane_tab_width): New function.
6642 (current_column, scan_for_column, Findent_to, position_indentation)
6643 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 6644 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 6645
51cab52b 6646 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 6647
f2ed8a70
PE
6648 * lisp.h (lint_assume): New macro.
6649 * composite.c (composition_gstring_put_cache):
6650 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6651
abe80cc6
PE
6652 * editfns.c, insdel.c:
6653 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 6654
b02c740e
PE
6655 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6656
ebc96716
PE
6657 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6658
b4e50fa0 6659 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 6660 Use much-faster test for byte-length change.
311d5d7c 6661 Don't assume string byte-length fits in 'int'.
a4cf38e4 6662 Check that character arg fits in 'int'.
85461888 6663 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 6664
c0c1ee9f
PE
6665 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6666
a498d7f4
PE
6667 * fns.c (concat): Catch string overflow earlier.
6668 Do not rely on integer wraparound.
6669
51cab52b
PE
6670 * dispextern.h (struct it.overlay_strings_charpos)
6671 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
6672 * xdisp.c (forward_to_next_line_start)
6673 (back_to_previous_visible_line_start)
6674 (reseat_at_next_visible_line_start, next_element_from_buffer):
6675 Don't arbitrarily truncate the value of 'selective' to int.
6676
76031fad
PE
6677 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6678
5eb55db9
PE
6679 * composite.c: Don't truncate sizes to 'int'.
6680 (composition_gstring_p, composition_reseat_it)
6681 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
6682 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6683 not EMACS_UINT, for indexes.
5eb55db9 6684
0703a717
PE
6685 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6686
d6202519
PE
6687 * buffer.c: Include <verify.h>.
6688 (struct sortvec.priority, struct sortstr.priority):
8961a454 6689 Now EMACS_INT, not int.
c20998a7 6690 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
6691 (struct sortstr.size, record_overlay_string)
6692 (struct sortstrlist.size, struct sortlist.used):
6693 Don't truncate size to int.
6694 (record_overlay_string): Check for size-calculation overflow.
d6202519 6695 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 6696
d5a19415
JM
66972011-06-22 Jim Meyering <meyering@redhat.com>
6698
029529ac 6699 Don't leak an XBM-image-sized buffer
d5a19415
JM
6700 * image.c (xbm_load): Free the image buffer after using it.
6701
a9041e6c
PE
67022011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6703
6704 Port to Sun C.
6705 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6706 that Sun C diagnosed.
6707 * fns.c (secure_hash): Fix pointer signedness issue.
6708 * intervals.c (static_offset_intervals): New function.
6709 (offset_intervals): Use it.
6710
7f3f739f
LL
67112011-06-21 Leo Liu <sdl.web@gmail.com>
6712
6713 * deps.mk (fns.o):
6714 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6715 sha512.h.
6716
6717 * fns.c (secure_hash): Rename from crypto_hash_function and change
6718 the first arg to accept symbols.
5b66d427 6719 (Fsecure_hash): New primitive.
7f3f739f
LL
6720 (syms_of_fns): New symbols.
6721
76147d94
DD
67222011-06-20 Deniz Dogan <deniz@dogan.se>
6723
6724 * process.c (Fset_process_buffer): Clarify return value in
6725 docstring.
6726
7d7d0045
CY
67272011-06-18 Chong Yidong <cyd@stupidchicken.com>
6728
6729 * dispnew.c (add_window_display_history): Use BVAR.
6730
6731 * xdisp.c (debug_method_add): Use BVAR.
6732 (check_window_end, dump_glyph_matrix, dump_glyph)
6733 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6734
6735 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6736 Likewise.
6737
6738 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6739 check till after the cache is created in init_frame_faces.
6740
ff2bc410
SM
67412011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6742
6743 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
6744
28177add
PE
67452011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6746
dd3482fe
PE
6747 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
6748 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
6749 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
6750
393d71f3 6751 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
6752 * fileio.c (Finsert_file_contents):
6753 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
6754 Remove the old (too-loose) buffer overflow checks.
6755 They weren't needed, since make_gap checks for buffer overflow.
6756 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
6757 The old code merely checked for Emacs fixnum overflow, and relied
6758 on undefined (wraparound) behavior. The new code avoids undefined
6759 behavior, and also checks for ptrdiff_t and/or size_t overflow.
6760
2e6813b0 6761 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
6762 Tune. Don't use wider integers than needed. Don't use alloca.
6763 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 6764
599a9e4f
PE
6765 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
6766
99561444
PE
6767 * insdel.c, lisp.h (buffer_overflow): New function.
6768 (insert_from_buffer_1, replace_range, replace_range_2):
6769 * insdel.c (make_gap_larger):
6770 * editfns.c (Finsert_char):
6771 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
6772
28177add
PE
6773 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
6774
e69dafad
PE
67752011-06-15 Paul Eggert <eggert@cs.ucla.edu>
6776
4baa020d 6777 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 6778
b1c46f02
PE
6779 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
6780 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
6781
e69dafad
PE
6782 * fileio.c: Don't assume EMACS_INT fits in off_t.
6783 (emacs_lseek): New static function.
6784 (Finsert_file_contents, Fwrite_region): Use it.
6785 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
6786
566684ea
PE
6787 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
6788
e6966cd6
PE
6789 * fns.c: Don't overflow int when computing a list length.
6790 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
6791 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
6792 truncation on 64-bit hosts. Check for QUIT every
6793 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
6794 faster and is responsive enough.
6795 (Flength): Report an error instead of overflowing an integer.
6796 (Fsafe_length): Return a float if the value is not representable
6797 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 6798 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 6799 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 6800
dd0b0efb
PE
6801 * alloc.c: Check that resized vectors' lengths fit in fixnums.
6802 (header_size, word_size): New constants.
6803 (allocate_vectorlike): Don't check size overflow here.
6804 (allocate_vector): Check it here instead, since this is the only
6805 caller of allocate_vectorlike that could cause overflow.
6806 Check that the new vector's length is representable as a fixnum.
6807
86fe5cfe
PE
6808 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
6809 The previous code was bogus. For example, next_almost_prime (32)
6810 returned 39, which is undesirable as it is a multiple of 3; and
6811 next_almost_prime (24) returned 25, which is a multiple of 5 so
6812 why was the code bothering to check for multiples of 7?
6813
80e88859
PE
6814 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
6815
4a2f0ad6
PE
6816 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
6817
f66c7cf8
PE
6818 Variadic C functions now count arguments with ptrdiff_t.
6819 This partly undoes my 2011-03-30 change, which replaced int with size_t.
6820 Back then I didn't know that the Emacs coding style prefers signed int.
6821 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
6822 were being counted with int, which may truncate counts on 64-bit
6823 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
6824 * lisp.h (struct Lisp_Subr.function.aMANY)
6825 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
6826 Arg counts are now ptrdiff_t, not size_t.
6827 All variadic functions and their callers changed accordingly.
6828 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
6829 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
6830 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
6831 * callint.c (Fcall_interactively): Check arg count for overflow,
6832 to avoid potential buffer overrun. Use signed char, not 'int',
6833 for 'varies' array, so that we needn't bother to check its size
6834 calculation for overflow.
6835 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
6836 * eval.c (apply_lambda):
6837 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
6838 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
6839 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
6840
a1759b76
PE
6841 * callint.c (Fcall_interactively): Don't use index var as event count.
6842
d96be9fc
PE
6843 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
6844 * mem-limits.h (SIZE): Remove; no longer used.
6845
a690a978 6846 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 6847
578c21e6
PE
6848 Remove unnecessary casts.
6849 * xterm.c (x_term_init):
6850 * xfns.c (x_set_border_pixel):
6851 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
6852 These aren't needed now that we assume ANSI C.
6853
96f53c6c
PE
6854 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
6855 It's more likely to cause problems (due to unsigned overflow)
6856 than to cure them.
6857
83c77d31
PE
6858 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
6859
ee2079f1
PE
6860 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
6861
6da65536
PE
6862 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
6863
7147c4a4
PE
6864 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
6865
193e32d9
PE
6866 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
6867
e5533da6
PE
6868 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
6869
9910e595
PE
6870 GLYPH_CODE_FACE returns EMACS_INT, not int.
6871 * dispextern.h (merge_faces):
6872 * xfaces.c (merge_faces):
01103c44
PE
6873 * xdisp.c (get_next_display_element, next_element_from_display_vector):
6874 Don't assume EMACS_INT fits in int.
9910e595 6875
2638320e
PE
6876 * character.h (CHAR_VALID_P): Remove unused parameter.
6877 * fontset.c, lisp.h, xdisp.c: All uses changed.
6878
045eb8d9
PE
6879 * editfns.c (Ftranslate_region_internal): Omit redundant test.
6880
c1f134b5
PE
6881 * fns.c (concat): Minor tuning based on overflow analysis.
6882 This doesn't fix any bugs. Use int to hold character, instead
6883 of constantly refetching from Emacs object. Use XFASTINT, not
6884 XINT, for value known to be a character. Don't bother comparing
6885 a single byte to 0400, as it's always less.
6886
395fcb93 6887 * floatfns.c (Fexpt):
327eeec8
PE
6888 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
6889
abbd3d23
PE
6890 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
6891 for characters.
6892
684a03ef
PE
6893 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
6894
0fed43f3
PE
6895 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
6896 Without this fix, on a 64-bit host (aset S 0 4294967386) would
6897 incorrectly succeed when S was a string, because 4294967386 was
6898 truncated before it was used.
6899
8fd02eb7
PE
6900 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
6901 Otherwise, an out-of-range integer could cause undefined behavior
6902 on a 64-bit host.
6903
f8c86b69
PE
6904 * composite.c: Use int, not EMACS_INT, for characters.
6905 (fill_gstring_body, composition_compute_stop_pos): Use int, not
6906 EMACS_INT, for values that are known to be in character range.
6907 This doesn't fix any bugs but is the usual style inside Emacs and
6908 may generate better code on 32-bit machines.
6909
34206dd2
PE
6910 Make sure a 64-bit char is never passed to ENCODE_CHAR.
6911 This is for reasons similar to the recent CHAR_STRING fix.
6912 * charset.c (Fencode_char): Check that character arg is actually
6913 a character. Pass an int to ENCODE_CHAR.
6914 * charset.h (ENCODE_CHAR): Verify that the character argument is no
6915 wider than 'int', as a compile-time check to prevent future regressions
6916 in this area.
6917
c5958d4c 6918 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
6919
6920 Make sure a 64-bit char is never passed to CHAR_STRING.
6921 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
6922 by silently ignoring the top 32 bits, allowing some values
6923 that were far too large to be valid characters.
6924 * character.h: Include <verify.h>.
6925 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
6926 arguments are no wider than unsigned, as a compile-time check
6927 to prevent future regressions in this area.
6928 * data.c (Faset):
01103c44 6929 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
6930 (Fsubst_char_in_region):
6931 * fns.c (concat):
6932 * xdisp.c (decode_mode_spec_coding):
6933 Adjust to CHAR_STRING's new requirement.
6934 * editfns.c (Finsert_char, Fsubst_char_in_region):
6935 * fns.c (concat): Check that character args are actually
6936 characters. Without this test, these functions did the wrong
6937 thing with wildly out-of-range values on 64-bit hosts.
6938
d37ca623
PE
6939 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
6940 These casts should not be needed on 32-bit hosts, either.
6941 * keyboard.c (read_char):
6942 * lread.c (Fload): Remove casts to unsigned.
6943
ea204efb
PE
6944 * lisp.h (UNSIGNED_CMP): New macro.
6945 This fixes comparison bugs on 64-bit hosts.
6946 (ASCII_CHAR_P): Use it.
6947 * casefiddle.c (casify_object):
01103c44 6948 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
6949 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
6950 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
6951 * dispextern.h (FACE_FROM_ID):
6952 * keyboard.c (read_char): Use UNSIGNED_CMP.
6953
41cb286c
PE
6954 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
6955 not to EMACS_INT, to avoid GCC warning.
6956
4a1b9832
PE
6957 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
6958
55daad71
PE
6959 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
6960 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
6961 isn't needed on 32-bit machines.
8f95c75c 6962
01103c44
PE
6963 * buffer.c (Fgenerate_new_buffer_name):
6964 Use EMACS_INT for count, not int.
0ceccced 6965 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
6966
6967 * data.c (Qcompiled_function): Now static.
6968
c6f072e7
PE
6969 * window.c (window_body_lines): Now static.
6970
20ce5912
PE
6971 * image.c (gif_load): Rename local to avoid shadowing.
6972
9c4c5f81
PE
6973 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
6974 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
6975 * alloc.c (make_save_value): Integer argument is now of type
6976 ptrdiff_t, not int.
6977 (mark_object): Use ptrdiff_t, not int.
6978 * lisp.h (pD): New macro.
6979 * print.c (print_object): Use it.
6980
c0c5c8ae
PE
6981 * alloc.c: Use EMACS_INT, not int, to count objects.
6982 (total_conses, total_markers, total_symbols, total_vector_size)
6983 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
6984 (total_free_floats, total_floats, total_free_intervals)
6985 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
6986 Now EMACS_INT, not int. All uses changed.
6987 (Fgarbage_collect): Compute overall total using a double, so that
6988 integer overflow is less likely to be a problem. Check for overflow
6989 when converting back to an integer.
5a25e253
PE
6990 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
6991 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
6992 These were 'int' variables that could overflow on 64-bit hosts;
6993 they were never used, so remove them instead of repairing them.
211a0b2a 6994 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
6995 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
6996 Previously, this ceilinged at INT_MAX, but that doesn't work on
6997 64-bit machines.
e46bb31a 6998 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 6999
c78baabf 7000 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7001 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7002 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7003 when a (possibly-narrower) signed value would do just as well.
7004 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7005
c9d624c6
PE
7006 * alloc.c: Catch some string size overflows that we were missing.
7007 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7008 for convenience in STRING_BYTES_MAX.
7009 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7010 The definition here is exact; the one in lisp.h was approximate.
7011 (allocate_string_data): Check for string overflow. This catches
7012 some instances we weren't catching before. Also, it catches
7013 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7014 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7015 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7016
c9d624c6
PE
7017 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7018 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7019 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7020
353032ce
PE
7021 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7022
2bccce07
PE
7023 * alloc.c (Fmake_string): Check for out-of-range init.
7024
0ac30604
SM
70252011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7026
7027 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7028
c195f2de
JD
70292011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7030
7031 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7032 xg_get_default_scrollbar_width.
7033
7034 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7035 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7036 (style_changed_cb): Call update_theme_scrollbar_width and call
7037 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7038 all frames (Bug#8505).
7039 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7040 Call gtk_window_set_resizable if HAVE_GTK3.
7041 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7042 and height if HAVE_GTK3 (Bug#8505).
7043 (scroll_bar_width_for_theme): New variable.
7044 (update_theme_scrollbar_width): New function.
7045 (xg_get_default_scrollbar_width): Move code to
7046 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7047 (xg_initialize): Call update_theme_scrollbar_width.
7048
7049 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7050
7051 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7052
e10ac9f1
MR
70532011-06-12 Martin Rudalics <rudalics@gmx.at>
7054
7055 * frame.c (make_frame): Call other_buffer_safely instead of
7056 other_buffer.
7057
7058 * window.c (temp_output_buffer_show): Call display_buffer with
7059 second argument Vtemp_buffer_show_specifiers and reset latter
7060 immediately after the call.
7061 (Vtemp_buffer_show_specifiers): New variable.
7062 (auto_window_vscroll_p, next_screen_context_lines)
7063 (Vscroll_preserve_screen_position): Remove leading asterisks from
7064 doc-strings.
7065
2d3c217e 70662011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7067
7b7f97e8 7068 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7069 * buffer.c (Qclone_number): Remove for now, as it's unused.
7070 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7071 (record_buffer): Remove unused local.
7072 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7073 (set_frame_buffer_list): Remove; unused.
7074 * frame.h (other_visible_frames): Remove decl.
7075 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7076 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7077 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7078 if HAVE_GPM.
7079 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7080 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7081 Define only if HAVE_GPM.
7082 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7083 (update_hints_inhibit): Remove; never set. All uses removed.
7084 * widgetprv.h (emacsFrameClassRec): Remove decl.
7085 * window.c (delete_deletable_window): Now returns void, since it
7086 wasn't returning anything.
7087 (compare_window_configurations): Remove unused locals.
7088 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7089 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7090 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7091 the same widths as pointers. This follows up on the 2011-05-06 patch.
7092 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7093 * xterm.h: Likewise.
7094 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7095
1384b89e
JB
70962011-06-12 Juanma Barranquero <lekktu@gmail.com>
7097
7098 * makefile.w32-in: Update dependencies.
7099 (LISP_H): Add lib/intprops.h.
7100
1100a63c
CY
71012011-06-11 Chong Yidong <cyd@stupidchicken.com>
7102
7103 * image.c (gif_load): Add animation frame delay to the metadata.
7104 (syms_of_image): Use DEFSYM. New symbol `delay'.
7105
6198ccd0
MR
71062011-06-11 Martin Rudalics <rudalics@gmx.at>
7107
7108 * window.c (delete_deletable_window): Re-add.
7109 (Fset_window_configuration): Rewrite to handle dead buffers and
7110 consequently deletable windows.
7111 (window_tree, Fwindow_tree): Remove. Supply functionality in
7112 window.el.
7113 (compare_window_configurations): Simplify code.
7114
b6e3633c
AS
71152011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7116
1ab0dee5
AS
7117 * image.c (imagemagick_load_image): Fix type mismatch.
7118 (Fimagemagick_types): Likewise.
7119
b6e3633c
AS
7120 * window.h (replace_buffer_in_windows): Declare.
7121
9397e56f
MR
71222011-06-11 Martin Rudalics <rudalics@gmx.at>
7123
7124 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7125 Qclone_number. Remove external declaration of Qdelete_window.
7126 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7127 code.
640c8776
SM
7128 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7129 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7130 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7131 buffer list implementation.
7132 (other_buffer_safely): New function.
7133 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7134 calls to replace_buffer_in_windows and
7135 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7136 if allowed.
7137 (record_buffer): Inhibit quitting and rewrite using quittable
7138 functions. Run Qbuffer_list_update_hook if allowed.
7139 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7140 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7141 Move switch-to-buffer to window.el.
9397e56f
MR
7142 (bury-buffer): Move to window.el.
7143 (Vbuffer_list_update_hook): New variable.
7144
7145 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7146 section.
7147
7148 * window.h (resize_frame_windows): Move up in code.
7149 (Fwindow_frame): Remove EXFUN.
7150 (replace_buffer_in_all_windows): Remove prototype.
7151 (replace_buffer_in_windows_safely): Add prototype.
7152
7153 * window.c: Declare Qdelete_window static again. Move down
7154 declaration of select_count.
7155 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7156 (Fother_window): Move to window.el.
7157 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7158 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7159 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7160 window.el.
7161 (replace_buffer_in_windows): Implement by calling
7162 Qreplace_buffer_in_windows.
7163 (replace_buffer_in_all_windows): Remove with some functionality
7164 moved into replace_buffer_in_windows_safely.
7165 (replace_buffer_in_windows_safely): New function.
7166 (select_window_norecord, select_frame_norecord): Move in front
7167 of run_window_configuration_change_hook. Remove now obsolete
7168 declarations.
640c8776
SM
7169 (Fset_window_buffer): Rewrite doc-string.
7170 Call Qrecord_window_buffer.
9397e56f
MR
7171 (keys_of_window): Move binding for other-window to window.el.
7172
b50691aa
CY
71732011-06-11 Chong Yidong <cyd@stupidchicken.com>
7174
7175 * dispextern.h (struct image): Replace data member, whose int_val
7176 and ptr_val fields were not used by anything, with a single
7177 lisp_val object.
7178
7179 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7180 (gif_clear_image, gif_load, imagemagick_load_image)
7181 (gs_clear_image, gs_load): Callers changed.
7182
3f754b86
PE
71832011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7184
cca69397
PE
7185 * buffer.h: Include <time.h>, for time_t.
7186 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7187
109e28d0
PE
7188 Fix minor problems found by static checking.
7189
60737f02
PE
7190 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7191
4b66faf3
PE
7192 Make identifiers static if they are not used in other modules.
7193 * data.c (Qcompiled_function, Qframe, Qvector):
7194 * image.c (QimageMagick, Qsvg):
7195 * minibuf.c (Qmetadata):
7196 * window.c (resize_window_check, resize_root_window): Now static.
7197 * window.h (resize_window_check, resize_root_window): Remove decls.
7198
109e28d0
PE
7199 * window.c (window_deletion_count, delete_deletable_window):
7200 Remove; unused.
46a4ce9e
PE
7201 (window_body_lines): Now static.
7202 (Fdelete_other_windows_internal): Mark vars as initialized.
7203 Make sure 'resize_failed' is initialized.
7204 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7205 (resize_window_apply): Remove unused local.
7206 * window.h (delete_deletable_window): Remove decl.
7207
109e28d0 7208 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
7209 (imagemagick_load_image): Fix pointer signedness problem by changing
7210 last arg from unsigned char * to char *. All uses changed.
7211 Also, fix a local for similar reasons.
7212 Remove unused locals. Remove locals to avoid shadowing.
7213 (fn_rsvg_handle_free): Remove; unused.
7214 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 7215 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 7216
3f754b86
PE
7217 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7218
2547adb1
CY
72192011-06-10 Chong Yidong <cyd@stupidchicken.com>
7220
7221 * image.c (gif_load): Fix omitted cast error introduced by
7222 2011-06-06 change.
7223
2c8e37d4
MR
72242011-06-10 Martin Rudalics <rudalics@gmx.at>
7225
7226 * window.h (resize_proportionally, orig_total_lines)
7227 (orig_top_line): Remove from window structure.
7228 (set_window_height, set_window_width, change_window_heights)
7229 (Fdelete_window): Remove prototypes.
7230 (resize_frame_windows): Remove duplicate declaration.
7231
440a42e3
EZ
72322011-06-10 Eli Zaretskii <eliz@gnu.org>
7233
7234 * window.h (resize_frame_windows, resize_window_check)
7235 (delete_deletable_window, resize_root_window)
7236 (resize_frame_windows): Declare prototypes.
7237
7238 * window.c (resize_window_apply): Make definition be "static" to
7239 match the prototype.
7240
562dd5e9
MR
72412011-06-10 Martin Rudalics <rudalics@gmx.at>
7242
7243 * window.c: Remove declarations of Qwindow_size_fixed,
7244 window_min_size_1, window_min_size_2, window_min_size,
7245 size_window, window_fixed_size_p, enlarge_window, delete_window.
7246 Remove static from declaration of Qdelete_window, it's
7247 temporarily needed by Fbury_buffer.
7248 (replace_window): Don't assign orig_top_line and
7249 orig_total_lines.
7250 (Fdelete_window, delete_window): Remove. Window deletion is
7251 handled by window.el.
640c8776
SM
7252 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7253 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
7254 (Fdelete_other_windows): Remove. Deleting other windows is
7255 handled by window.el.
7256 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7257 handled in window.el.
7258 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7259 Window minimum sizes are handled in window.el.
7260 (shrink_windows, size_window, set_window_height)
7261 (set_window_width, change_window_heights, window_height)
7262 (window_width, CURBEG, CURSIZE, enlarge_window)
7263 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7264 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7265 handled in window.el.
7266 (make_dummy_parent): Rename to make_parent_window and give it a
7267 second argument horflag.
7268 (make_window): Don't set resize_proportionally any more.
7269 (Fsplit_window): Remove. Windows are split in window.el.
7270 (save_restore_action, save_restore_orig_size)
7271 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7272 Resize mini windows in window.el.
7273 (grow_mini_window, shrink_mini_window): Implement by calling
7274 Qresize_root_window_vertically, resize_window_check and
7275 resize_window_apply.
640c8776
SM
7276 (saved_window, Fset_window_configuration, save_window_save):
7277 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
7278 resize_proportionally.
7279 (window_min_height, window_min_width): Move to window.el.
7280 (keys_of_window): Move bindings for delete-other-windows,
7281 split-window, delete-window and enlarge-window to window.el.
7282
7283 * buffer.c: Temporarily extern Qdelete_window.
7284 (Fbury_buffer): Temporarily call Qdelete_window instead of
7285 Fdelete_window (Fbury_buffer will move to window.el soon).
7286
7287 * frame.c (set_menu_bar_lines_1): Remove code handling
7288 orig_top_line and orig_total_lines.
7289
7290 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7291 set_window_height but set heights directly.
7292 (change_frame_size_1): Use resize_frame_windows.
7293
7294 * xdisp.c (init_xdisp): Don't use set_window_height but set
7295 heights directly.
7296
640c8776
SM
7297 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7298 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
7299 run_window_configuration_change_hook.
7300
7301 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7302 instead of change_window_heights and run
7303 run_window_configuration_change_hook.
7304
1a13852e
MR
73052011-06-09 Martin Rudalics <rudalics@gmx.at>
7306
7307 * window.c (replace_window): Rename second argument REPLACEMENT to
7308 NEW. New third argument SETFLAG. Rewrite.
7309 (delete_window, make_dummy_parent): Call replace_window with
7310 third argument 1.
7311 (window_list_1): Move down in code.
7312 (run_window_configuration_change_hook): Move set_buffer part
7313 before select_frame_norecord part in order to unwind correctly.
7314 Rename count1 to count.
7315 (recombine_windows, delete_deletable_window, resize_root_window)
7316 (Fdelete_other_windows_internal)
7317 (Frun_window_configuration_change_hook, make_parent_window)
7318 (resize_window_check, resize_window_apply, Fresize_window_apply)
7319 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
7320 (Fdelete_window_internal, Fresize_mini_window_internal):
7321 New functions.
1a13852e
MR
7322 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7323
f3d1777e
MR
73242011-06-08 Martin Rudalics <rudalics@gmx.at>
7325
496e208e
MR
7326 * window.h (window): Add some new members to window structure -
7327 normal_lines, normal_cols, new_total, new_normal, clone_number,
7328 splits, nest, prev_buffers, next_buffers.
7329 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 7330 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 7331
f3d1777e
MR
7332 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7333 Remove.
496e208e
MR
7334 (make_dummy_parent): Set new members of windows structure.
7335 (make_window): Move down in code. Handle new members of window
7336 structure.
7337 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7338 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7339 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7340 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
7341 (Fset_window_next_buffers, Fset_window_clone_number):
7342 New functions.
496e208e
MR
7343 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7344 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7345 Doc-string fixes.
7346 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7347 Argument WINDOW can be now internal window too.
7348 (Fwindow_use_time): Move up in code.
7349 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7350 Rewrite doc-string.
7351 (Fset_window_configuration, saved_window)
7352 (Fcurrent_window_configuration, save_window_save): Handle new
7353 members of window structure.
b9e809c2
MR
7354 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7355 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7356 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7357 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7358 Qget_mru_window, Qresize_root_window,
7359 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7360 Qauto_buffer_name; staticpro them.
f3d1777e 7361
abde8f8c
MR
73622011-06-07 Martin Rudalics <rudalics@gmx.at>
7363
7364 * window.c (Fwindow_total_size, Fwindow_left_column)
7365 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7366 (Fwindow_list_1): New functions.
7367 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
7368 (Fwindow_width, Fscroll_left, Fscroll_right):
7369 Use window_body_cols instead of window_box_text_cols.
7370 (delete_window, Fset_window_configuration):
7371 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
7372 (delete_all_subwindows): Take a window as argument and not a
7373 structure. Rewrite.
190b47e6
MR
7374 (window_loop): Remove handling of GET_LRU_WINDOW and
7375 GET_LARGEST_WINDOW.
7376 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
7377
7378 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
7379 window_box_text_cols. delete_all_subwindows now takes a
7380 Lisp_Object as argument.
abde8f8c 7381
640c8776
SM
7382 * indent.c (compute_motion, Fcompute_motion):
7383 Use window_body_cols instead of window_box_text_cols.
abde8f8c 7384
fa8a67e6
MR
7385 * frame.c (delete_frame): Call delete_all_subwindows with root
7386 window as argument.
7387
a54e3482
DC
73882011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7389
7390 * fns.c (Fputhash): Document return value.
7391
60002bf5
CY
73922011-06-06 Chong Yidong <cyd@stupidchicken.com>
7393
7394 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7395
0c671da6 73962011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 7397
b862a52a 7398 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 7399
be44ca6c
PE
7400 Check for overflow when converting integer to cons and back.
7401 * charset.c (Fdefine_charset_internal, Fdecode_char):
7402 Use cons_to_unsigned to catch overflow.
7403 (Fencode_char): Use INTEGER_TO_CONS.
7404 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7405 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7406 * data.c (long_to_cons, cons_to_long): Remove.
7407 (cons_to_unsigned, cons_to_signed): New functions.
7408 These signal an error for invalid or out-of-range values.
7409 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7410 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7411 * font.c (Ffont_variation_glyphs):
7412 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7413 * lisp.h: Include <intprops.h>.
7414 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7415 (cons_to_signed, cons_to_unsigned): New decls.
7416 (long_to_cons, cons_to_long): Remove decls.
7417 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7418 (Fprimitive_undo): Use CONS_TO_INTEGER.
7419 * xfns.c (Fx_window_property): Likewise.
7420 * xselect.c: Include <limits.h>.
7421 (x_own_selection, selection_data_to_lisp_data):
7422 Use INTEGER_TO_CONS.
7423 (x_handle_selection_request, x_handle_selection_clear)
7424 (x_get_foreign_selection, Fx_disown_selection_internal)
7425 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7426 (lisp_data_to_selection_data): Use cons_to_unsigned.
7427 (x_fill_property_data): Use cons_to_signed.
7428 Report values out of range.
7429
d1f3d2af
PE
7430 Check for buffer and string overflow more precisely.
7431 * buffer.h (BUF_BYTES_MAX): New macro.
7432 * lisp.h (STRING_BYTES_MAX): New macro.
7433 * alloc.c (Fmake_string):
7434 * character.c (string_escape_byte8):
7435 * coding.c (coding_alloc_by_realloc):
7436 * doprnt.c (doprnt):
7437 * editfns.c (Fformat):
7438 * eval.c (verror):
7439 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7440 since they may not be the same number.
7441 * editfns.c (Finsert_char):
7442 * fileio.c (Finsert_file_contents):
7443 Likewise for BUF_BYTES_MAX.
7444
dd52fcea
PE
7445 * image.c: Use ptrdiff_t, not int, for sizes.
7446 (slurp_file): Switch from int to ptrdiff_t.
7447 All uses changed.
7448 (slurp_file): Check that file size fits in both size_t (for
7449 malloc) and ptrdiff_t (for sanity and safety).
7450
7f9bbdbb
PE
7451 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7452 if b->modtime has its maximal value.
7453
dfe18f82
PE
7454 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7455
84acfcf0
PE
7456 Don't assume time_t can fit into int.
7457 * buffer.h (struct buffer.modtime): Now time_t, not int.
7458 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7459 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7460
ccd9a01a
PE
7461 Minor fixes for signed vs unsigned integers.
7462 * character.h (MAYBE_UNIFY_CHAR):
7463 * charset.c (maybe_unify_char):
7464 * keyboard.c (read_char, reorder_modifiers):
7465 XINT -> XFASTINT, since the integer must be nonnegative.
7466 * ftfont.c (ftfont_spec_pattern):
7467 * keymap.c (access_keymap, silly_event_symbol_error):
7468 XUINT -> XFASTINT, since the integer must be nonnegative.
7469 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7470 since it makes no difference and we prefer signed.
7471 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7472 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7473 nonnegative.
7474
d6d100dd
SM
74752011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7476
7477 * window.h (Fwindow_frame): Declare.
7478
2b6148e4
PE
74792011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7480
7481 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7482 (SPARE_MEMORY): Always define.
7483 (LARGE_REQUEST): Remove.
7484 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7485
f230ecc9
MR
74862011-06-06 Martin Rudalics <rudalics@gmx.at>
7487
727e958e
MR
7488 * lisp.h: Move EXFUNS for Fframe_root_window,
7489 Fframe_first_window and Fset_frame_selected_window to window.h.
7490
7491 * window.h: Move EXFUNS for Fframe_root_window,
7492 Fframe_first_window and Fset_frame_selected_window here from
7493 lisp.h.
7494
7495 * frame.c (Fwindow_frame, Fframe_first_window)
7496 (Fframe_root_window, Fframe_selected_window)
7497 (Fset_frame_selected_window): Move to window.c.
7498 (Factive_minibuffer_window): Move to minibuf.c.
7499 (Fother_visible_frames_p): New function.
7500
7501 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7502
f230ecc9
MR
7503 * window.c (decode_window, decode_any_window): Move up in code.
7504 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7505 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
7506 (Fwindow_buffer): Move up and rewrite doc-string.
7507 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7508 (Fwindow_prev): New functions.
727e958e
MR
7509 (Fwindow_frame): Move here from frame.c. Accept any window as
7510 argument.
7511 (Fframe_root_window, Fframe_first_window)
7512 (Fframe_selected_window): Move here from frame.c. Accept frame
7513 or arbitrary window as argument. Update doc-strings.
7514 (Fminibuffer_window): Move up in code.
7515 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
7516 (Fset_frame_selected_window): Move here from frame.c.
7517 Marginal rewrite.
727e958e
MR
7518 (Fselected_window, select_window, Fselect_window): Move up in
7519 code. Minor doc-string fixes.
f230ecc9 7520
4d09bcf6
PE
75212011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7522
7523 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7524 Do not assume that spare memory exists; that assumption is valid
7525 only if SYSTEM_MALLOC.
7526 (LARGE_REQUEST): New macro, so that the issue of large requests
7527 is separated from the issue of spare memory.
7528
810928a2
AS
75292011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7530
172418ad
AS
7531 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7532 format. (Bug#8806)
7533
43f862f7
AS
7534 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7535
810928a2
AS
7536 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7537 before statements.
7538
a059fe24
JD
75392011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7540
7541 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7542
7543 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7544
7545 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7546 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7547
989bf368
JB
75482011-06-05 Juanma Barranquero <lekktu@gmail.com>
7549
7550 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7551
4b80f674
CY
75522011-06-04 Chong Yidong <cyd@stupidchicken.com>
7553
7554 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7555 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
7556 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7557 New error handlers.
4b80f674
CY
7558 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7559 Obey Vx_select_enable_clipboard_manager. Catch errors in
7560 x_clipboard_manager_save (Bug#8779).
7561 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 7562 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 7563
99a33b77 75642011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
7565
7566 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7567
99a33b77 75682011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
7569
7570 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7571 in the current matrix if keep_current_p is non-zero.
7572
8264569d
EZ
75732011-06-04 Eli Zaretskii <eliz@gnu.org>
7574
7575 * bidi.c (bidi_level_of_next_char): Fix last change.
7576
57f97249
EZ
75772011-06-03 Eli Zaretskii <eliz@gnu.org>
7578
fec2107c 7579 Support bidi reordering of text covered by display properties.
57f97249 7580
fec2107c
EZ
7581 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7582 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7583 (bidi_cache_search, bidi_cache_iterator_state)
7584 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
7585 (bidi_level_of_next_char, bidi_move_to_visually_next):
7586 Support character positions inside a run of characters covered by a
fec2107c
EZ
7587 display string.
7588 (bidi_paragraph_init, bidi_resolve_explicit_1)
7589 (bidi_level_of_next_char): Call bidi_fetch_char and
7590 bidi_fetch_char_advance instead of FETCH_CHAR and
7591 FETCH_CHAR_ADVANCE.
7592 (bidi_init_it): Initialize new members.
7593 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7594 definitions.
7595 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7596 instead of using explicit *_CHAR codes.
d6d100dd
SM
7597 (bidi_resolve_explicit, bidi_resolve_weak):
7598 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
7599 bidirectional text is supported only in multibyte buffers.
7600 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7601 it to initialize the frame_window_p member of struct bidi_it.
7602 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7603 (bidi_resolve_explicit, bidi_resolve_weak)
7604 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7605 bidi_it->nchars is non-positive.
7606 (bidi_level_of_next_char): Don't try to lookup the cache for the
7607 next/previous character if nothing is cached there yet, or if we
7608 were just reseat()'ed to a new position.
c40e2fb2 7609
0e14fe90
EZ
7610 * xdisp.c (set_cursor_from_row): Set start and stop points
7611 according to the row's direction when priming the loop that looks
7612 for the glyph on which to display cursor.
7613 (single_display_spec_intangible_p): Function deleted.
7614 (display_prop_intangible_p): Reimplement to call
7615 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
7616 Accept 3 additional arguments needed by handle_display_spec.
7617 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
7618 values: lists, `(when COND...)' forms, etc.
7619 (single_display_spec_string_p): Support property values that are
7620 lists with the argument STRING its top-level element.
7621 (display_prop_string_p): Fix the condition for processing a
7622 property that is a list to be consistent with handle_display_spec.
fec2107c 7623 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
7624 last portion of handle_display_prop.
7625 (compute_display_string_pos): Accept additional argument
7626 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7627 value of a `display' property is a "replacing spec".
7628 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7629 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7630 the display property, but just return a value indicating whether
7631 the display property will replace the characters it covers.
7632 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7633 frame_window_p members of struct bidi_it.
d6d100dd
SM
7634 (compute_display_string_pos, compute_display_string_end):
7635 New functions.
fec2107c
EZ
7636 (push_it): Accept second argument POSITION, where pop_it should
7637 jump to continue iteration.
7638 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 7639
fec2107c
EZ
7640 * keyboard.c (adjust_point_for_property): Adjust the call to
7641 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
7642
7643 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
7644 (bidi_init_it): Update prototypes.
7645 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
7646 (compute_display_string_pos, compute_display_string_end):
7647 Declare prototypes.
fec2107c
EZ
7648 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7649 EMACS_INT.
fc6f18ce 7650
40087514 76512011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 7652
57f53182
PE
7653 Malloc failure behavior now depends on size of allocation.
7654 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7655 * lisp.h: Change signatures accordingly.
7656 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7657 All callers changed. (Bug#8762)
7658
7659 * gnutls.c: Use Emacs's memory allocators.
7660 Without this change, the gnutls library would invoke malloc etc.
7661 directly, which causes problems on non-SYNC_INPUT hosts, and which
7662 runs afoul of improving memory_full behavior. (Bug#8761)
7663 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7664 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7665 xfree instead of the default malloc, realloc, free.
7666 (Fgnutls_boot): No need to check for memory allocation failure,
7667 since xmalloc does that for us.
7668
ac32cd99 7669 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
7670 * category.c (hash_get_category_set):
7671 * ccl.c (ccl_driver):
7672 * charset.c (Fdefine_charset_internal):
7673 * charset.h (struct charset.hash_index):
7674 * composite.c (get_composition_id, gstring_lookup_cache)
7675 (composition_gstring_put_cache):
7676 * composite.h (struct composition.hash_index):
7677 * dispextern.h (struct image.hash):
7678 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7679 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7680 (hashfn_equal, hashfn_user_defined, make_hash_table)
7681 (maybe_resize_hash_table, hash_lookup, hash_put)
7682 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7683 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7684 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7685 * image.c (make_image, search_image_cache, lookup_image)
7686 (xpm_put_color_table_h):
7687 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 7688 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 7689 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 7690 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
7691 * alloc.c (allocate_vectorlike):
7692 Check for overflow in vector size calculations.
7693 * ccl.c (ccl_driver):
7694 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
7695 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7696 need to be updated by these changes.
40087514
PE
7697 * fns.c (make_hash_table, maybe_resize_hash_table):
7698 Check for integer overflow with large hash tables.
0de4bb68
PE
7699 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7700 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7701 (SXHASH_REDUCE): New macro.
7702 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7703 Use it instead of discarding useful hash info with large hash values.
7704 (sxhash_float): New function.
7705 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7706 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
7707 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7708 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
7709 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7710 Adjust signatures to match updated version of code.
7711 (consing_since_gc): Now EMACS_INT, since a single hash table can
7712 use more than INT_MAX bytes.
7713
698d32e2
DN
77142011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7715
7716 Make it possible to build with GCC-4.6+ -O2 -flto.
7717
7718 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7719
fd6fa53f
SM
77202011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7721
7722 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7723 Call minibuffer-inactive-mode.
7724
864db017
JB
77252011-05-31 Juanma Barranquero <lekktu@gmail.com>
7726
7727 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7728 Update dependencies.
7729
2ad0baf4
DN
77302011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7731
7732 * data.c (init_data): Remove code for UTS, this system is not
7733 supported anymore.
7734
4fcc2638
DN
77352011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7736
7737 Don't force ./temacs to start in terminal mode.
7738
7739 * frame.c (make_initial_frame): Initialize faces in all cases, not
7740 only when CANNOT_DUMP is defined.
7741 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
7742
c56e0fd5
DN
77432011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7744
7745 * dispnew.c (add_window_display_history): Use const for the string
7746 pointer. Remove declaration, not needed.
7747
333d54da 77482011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 7749
55d4c1b2 7750 Use 'inline', not 'INLINE'.
333d54da 7751 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
7752 * alloc.c, fontset.c (INLINE): Remove.
7753 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
7754 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
7755 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
7756 * gmalloc.c (register_heapinfo): Use inline unconditionally.
7757 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
7758
738db178
DN
77592011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7760
7761 Make it possible to run ./temacs.
7762
7763 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
7764 syms_of_callproc does the same thing. Remove test for
7765 "initialized", do it in the caller.
7766 * emacs.c (main): Avoid calling set_initial_environment when dumping.
7767
620c53a6
SM
77682011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
7769
7770 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
7771 (read_minibuf): Use get_minibuffer.
7772 (syms_of_minibuf): Use DEFSYM.
7773 (Qmetadata): New var.
7774 * data.c (Qbuffer): Don't make it static.
7775 (syms_of_data): Use DEFSYM.
7776
e003a292
PE
77772011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7778
7779 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
7780 (CCL_CODE_MIN): New macro.
7781
ed008a6d
PE
77822011-05-30 Paul Eggert <eggert@cs.ucla.edu>
7783
3687c2ef
PE
7784 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
7785
ed008a6d
PE
7786 * eval.c (Qdebug): Now static.
7787 * lisp.h (Qdebug): Remove decl. This reverts a part of the
7788 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
7789 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
7790
d66c4c7c
CY
77912011-05-29 Chong Yidong <cyd@stupidchicken.com>
7792
7793 * image.c: Various fixes to ImageMagick code comments.
7794 (Fimagemagick_types): Doc fix.
7795
5fbc2025
PE
77962011-05-29 Paul Eggert <eggert@cs.ucla.edu>
7797
0196f88a
PE
7798 Minor fixes prompted by GCC 4.6.0 warnings.
7799
7800 * xselect.c (converted_selections, conversion_fail_tag): Now static.
7801
5fbc2025
PE
7802 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
7803 (x_clipboard_manager_save_all): Move extern decl to ...
7804 * xterm.h: ... here, so that it can be checked for consistency.
7805
1dd3c2d9
CY
78062011-05-29 Chong Yidong <cyd@stupidchicken.com>
7807
7808 * xselect.c (x_clipboard_manager_save_frame)
7809 (x_clipboard_manager_save_all): New functions.
7810 (Fx_clipboard_manager_save): Lisp function deleted.
7811
7812 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
7813 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
7814
7815 * xterm.h: Update prototype.
7816
5ba6571d
WX
78172011-05-28 William Xu <william.xwl@gmail.com>
7818
7819 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
7820 exiting (Bug#8239).
7821
3eaff834
JM
78222011-05-28 Jim Meyering <meyering@redhat.com>
7823
e1900994 7824 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
7825 * fns.c (to_uchar): Define.
7826 (crypto_hash_function): Use it to convert some newly-signed
7827 variables to unsigned, to avoid sign-extension bugs. For example,
7828 without this change, (md5 "truc") would evaluate to
7829 45723a2aff78ff4fff7fff1114760e62 rather than the expected
7830 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 7831 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 7832
0f6990a7
PE
78332011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7834
7835 Integer overflow fixes.
c8a9ca5a 7836
08686060
PE
7837 * dbusbind.c: Serial number integer overflow fixes.
7838 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
7839 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
7840 to hold a serial number that is too large for a fixnum.
7841 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7842 Check for serial numbers out of range. Decode any serial number
59568bf0 7843 that was so large that it became a float. (Bug#8722)
08686060 7844
2d1fc3c7
PE
7845 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
7846 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7847 Use XFASTINT rather than XUINT when numbers are nonnegative.
7848 (xd_append_arg, Fdbus_method_return_internal):
7849 (Fdbus_method_error_internal): Likewise. Also, for unsigned
7850 arguments, check that Lisp number is nonnegative, rather than
59568bf0 7851 silently wrapping negative numbers around. (Bug#8722)
30217ff0 7852 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 7853 (Bug#8722)
2d1fc3c7 7854
c8a9ca5a
PE
7855 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
7856
519e1d69
PE
7857 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
7858
6df6ae42 7859 ccl: Add integer overflow checks.
30569699
PE
7860 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
7861 (IN_INT_RANGE): New macros.
7862 (ccl_driver): Use them to check for integer overflow when
7863 decoding a CCL program. Many of the new checks are whether XINT (x)
7864 fits in int; it doesn't always, on 64-bit hosts. The new version
7865 doesn't catch all possible integer overflows, but it's an
847044ea 7866 improvement. (Bug#8719)
30569699 7867
c11285dc
PE
7868 * alloc.c (make_event_array): Use XINT, not XUINT.
7869 There's no need for unsigned here.
7870
fdccd48e
PE
7871 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
7872 This follows up to the 2011-05-06 change that substituted uintptr_t
7873 for EMACS_INT. This case wasn't caught back then.
7874
37910ab2
PE
7875 Rework Fformat to avoid integer overflow issues.
7876 * editfns.c: Include <float.h> unconditionally, as it's everywhere
7877 now (part of C89). Include <verify.h>.
7878 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
7879 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
7880 (Fformat): Avoid the prepass trying to compute sizes; it was only
7881 approximate and thus did not catch overflow reliably. Instead, walk
7882 through the format just once, formatting and computing sizes as we go,
7883 checking for integer overflow at every step, and allocating a larger
7884 buffer as needed. Keep track separately whether the format is
7885 multibyte. Keep only the most-recently calculated precision, rather
7886 than them all. Record whether each argument has been converted to
7887 string. Use EMACS_INT, not int, for byte and char and arg counts.
7888 Support field widths and precisions larger than INT_MAX. Avoid
7889 sprintf's undefined behavior with conversion specifications such as %#d
7890 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
7891 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
7892 formatting out-of-range floating point numbers with int
9173deec 7893 formats. (Bug#8668)
37910ab2 7894
2e6578fb
PE
7895 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
7896
0ae6bdee
PE
7897 * data.c: Avoid integer truncation in expressions involving floats.
7898 * data.c: Include <intprops.h>.
7899 (arith_driver): When there's an integer overflow in an expression
7900 involving floating point, convert the integers to floating point
7901 so that the resulting value does not suffer from catastrophic
7902 integer truncation. For example, on a 64-bit host (* 4
7903 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
7904 Do not rely on undefined behavior after integer overflow.
7905
de883a70
PE
7906 merge count_size_as_multibyte, parse_str_to_multibyte
7907 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 7908 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
7909 Check for integer overflow.
7910 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
7911 since it's now a duplicate of the other. This is more of
7912 a character than a buffer op, so better that it's in character.c.
7913 * fns.c, print.c: Adjust to above changes.
7914
2ff916cb
PE
79152011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
7916
7917 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
7918
f1b54466
PE
79192011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7920
fb1ac845
PE
7921 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7922 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
7923 (x_clipboard_manager_save): Now static.
7924 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
7925
f1b54466
PE
7926 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7927 (crypto_hash_function): Now static.
7928 Fix pointer signedness problems. Avoid unnecessary initializations.
7929
a9f737ee
CY
79302011-05-27 Chong Yidong <cyd@stupidchicken.com>
7931
7932 * termhooks.h (Vselection_alist): Make it terminal-local.
7933
7934 * terminal.c (create_terminal): Initialize it.
7935
7936 * xselect.c: Support for clipboard managers.
7937 (Vselection_alist): Move to termhooks.h as terminal-local var.
7938 (LOCAL_SELECTION): New macro.
7939 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
7940 (symbol_to_x_atom): Remove gratuitous arg.
7941 (x_handle_selection_request, lisp_data_to_selection_data)
7942 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
7943 (x_own_selection, x_get_local_selection, x_convert_selection):
7944 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
7945 (some_frame_on_display): Delete unused function.
7946 (Fx_own_selection_internal, Fx_get_selection_internal)
7947 (Fx_disown_selection_internal, Fx_selection_owner_p)
7948 (Fx_selection_exists_p): New optional frame arg.
7949 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
7950 (x_handle_selection_clear): Don't treat other terminals with the
7951 same keyboard specially. Use the terminal-local Vselection_alist.
7952 (x_clear_frame_selections): Use Frun_hook_with_args.
7953
7954 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
7955
7956 * xterm.h: Add support for those atoms.
7957
e067f0c1
CY
79582011-05-26 Chong Yidong <cyd@stupidchicken.com>
7959
7960 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
7961 (converted_selections, conversion_fail_tag): New global variables.
7962 (x_selection_request_lisp_error): Free the above.
7963 (x_get_local_selection): Remove unnecessary code.
7964 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
7965 of converted selections stored in converted_selections.
7966 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
7967 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
7968 (x_convert_selection): New function.
7969 (x_handle_selection_event): Simplify.
7970 (x_get_foreign_selection): Don't ignore incoming requests while
7971 waiting for an answer; this will fail when we implement
7972 SAVE_TARGETS, and seems unnecessary anyway.
7973 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
7974 (Vx_sent_selection_functions): Doc fix.
7975
0f4aebc0
LL
79762011-05-26 Leo Liu <sdl.web@gmail.com>
7977
7978 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
7979
e61124cd
YM
79802011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7981
7982 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
7983
7984 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
7985 for fringe update if it has periodic bitmap.
ac389d0c 7986 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
7987 and fringe_bitmap_periodic_p.
7988
7989 * fringe.c (get_fringe_bitmap_data): New function.
7990 (draw_fringe_bitmap_1, update_window_fringes): Use it.
7991 (update_window_fringes): Record periodicity of fringe bitmap in glyph
7992 row. Mark glyph row for fringe update if periodicity changed.
7993
7994 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
7995 for fringe update unless it has periodic bitmap.
7996
f16d9837
KH
79972011-05-25 Kenichi Handa <handa@m17n.org>
7998
7999 * xdisp.c (get_next_display_element): Set correct it->face_id for
8000 a static composition.
8001
e1b90ef6
LL
80022011-05-24 Leo Liu <sdl.web@gmail.com>
8003
8004 * deps.mk (fns.o):
8005 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8006
8007 * fns.c (crypto_hash_function, Fsha1): New function.
8008 (Fmd5): Use crypto_hash_function.
8009 (syms_of_fns): Add Ssha1.
8010
7400048f
PE
80112011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8012
8013 * gnutls.c: Remove unused macros.
8014 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8015 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8016 Remove macros that are defined and never used.
8017 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8018
abb71cf4
CY
80192011-05-22 Chong Yidong <cyd@stupidchicken.com>
8020
8021 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8022 (Fx_get_selection_internal): Minor cleanup.
8023 (Fx_own_selection_internal): Rename arguments for consistency with
8024 select.el.
8025
6307db39
PE
80262011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8027
8028 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8029
f3d4e0a4
CY
80302011-05-22 Chong Yidong <cyd@stupidchicken.com>
8031
8032 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8033
4d8ade89
YM
80342011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8035
8036 * dispnew.c (scrolling_window): Don't exclude the case that the
8037 last enabled row in the desired matrix touches the bottom boundary.
8038
32078c8d
GM
80392011-05-21 Glenn Morris <rgm@gnu.org>
8040
8041 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8042 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8043 and add some more files.
32078c8d 8044
7285dc67
EZ
80452011-05-20 Eli Zaretskii <eliz@gnu.org>
8046
8047 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8048 report_file_error introduced by the change from 2011-05-07.
8049
89d1bd22
PE
80502011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8051
8052 * systime.h (Time): Define only if emacs is defined.
8053 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8054 where the include path doesn't have X11/X.h by default. See
8055 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8056
cd394be1 80572011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8058
8059 * composite.c (find_automatic_composition): Fix previous change.
8060
b9704ad9
GM
80612011-05-20 Glenn Morris <rgm@gnu.org>
8062
8063 * lisp.mk: New file, split from Makefile.in.
8064 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8065 (shortlisp): Remove.
8066 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8067
4a720484
GM
80682011-05-19 Glenn Morris <rgm@gnu.org>
8069
8070 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8071 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8072 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8073 (lisp): Set the order to that of loadup.el.
8074 (shortlisp): Make it a copy of $lisp.
8075 (SOME_MACHINE_LISP): Remove.
8076 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8077 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8078
a28d4396
KH
80792011-05-18 Kenichi Handa <handa@m17n.org>
8080
8081 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8082 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8083 (find_automatic_composition): Mostly rewrite for efficiency.
8084
a2b1fa8e
JB
80852011-05-18 Juanma Barranquero <lekktu@gmail.com>
8086
8087 * makefile.w32-in: Update dependencies.
8088
8e1f5610
CS
80892011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8090
8091 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8092 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8093
7025ee00 80942011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8095
cdfa6eab
PE
8096 Fix some integer overflow issues, such as string length overflow.
8097
06d6db33
PE
8098 * insdel.c (count_size_as_multibyte): Check for string overflow.
8099
2b4560a8
PE
8100 * character.c (lisp_string_width): Check for string overflow.
8101 Use EMACS_INT, not int, for string indexes and lengths; in
8102 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8103 the resulting string length overflows an EMACS_INT; instead,
8104 report a string overflow if no precision given. When checking for
8105 precision exhaustion, use a check that cannot possibly have
8106 integer overflow. (Bug#8675)
8107 * character.h (lisp_string_width): Adjust to new signature.
8108
cb93f9be
PE
8109 * alloc.c (string_overflow): New function.
8110 (Fmake_string): Use it. This doesn't change behavior, but saves
8111 a few bytes and will simplify future changes.
8112 * character.c (string_escape_byte8): Likewise.
8113 * lisp.h (string_overflow): New decl.
8114
1a1f3366
PE
8115 Fixups, following up to the user-interface timestamp change.
8116 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8117 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8118 * msdos.c (mouse_get_pos): Likewise.
8119 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8120 * w32gui.h (Time): Define by including "systime.h" rather than by
8121 declaring it ourselves. (Bug#8664)
8122
d4e3e4d3
PE
8123 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8124 * image.c (clear_image_cache): Likewise.
8125
f6a24d19
PE
8126 * term.c (term_mouse_position): Don't assume time_t wraparound.
8127
08dc5ae6
PE
8128 Be more systematic about user-interface timestamps.
8129 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8130 and sometimes 'EMACS_UINT', to represent these timestamps.
8131 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8132 This makes the code easier to follow, and makes it easier to catch
8133 integer overflow bugs such as Bug#8664.
8134 * frame.c (Fmouse_position, Fmouse_pixel_position):
8135 Use Time, not unsigned long, for user-interface timestamps.
8136 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8137 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8138 * keyboard.h (last_event_timestamp): Likewise.
8139 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8140 * menu.h (xmenu_show): Likewise.
8141 * term.c (term_mouse_position): Likewise.
8142 * termhooks.h (struct input_event.timestamp): Likewise.
8143 (struct terminal.mouse_position_hook): Likewise.
8144 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8145 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8146 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8147 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8148 what it was before.
8149 * menu.h, termhooks.h: Include "systime.h", for Time.
8150
8e55734a
PE
8151 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8152 Don't assume that the difference between two unsigned long values
8153 can fit into an integer. At this point, we know button_down_time
8154 <= event->timestamp, so the difference must be nonnegative, so
8155 there's no need to cast the result if double-click-time is
8156 nonnegative, as it should be; check that it's nonnegative, just in
8157 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8158 apart (about 25 days). (Bug#8664)
8e55734a 8159
841f1b75 8160 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8161 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8162
3e26f69c
PE
8163 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8164 that always fit in int. Use a sentinel instead of a counter, to
8165 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8166 * frame.h (struct frame): Use int for menu_bar_items_used
8167 instead of EMACS_INT, since it always fits in int.
3e26f69c 8168
5cc152c0
PE
8169 * menu.c (grow_menu_items): Check for int overflow.
8170
d89eb65e
PE
8171 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8172
5235bd3e
PE
8173 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8174 Before, the code was not consistent. These values cannot exceed
8175 2**31 - 1 so there's no need to make them unsigned.
8176 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8177 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8178 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8179 as modifiers.
8180 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8181
bc827e23
PE
8182 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8183 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8184 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8185 presumably because the widths might not match.
8186
78eb494e
PE
8187 * window.c (size_window): Avoid needless test at loop start.
8188
04f2d78b
CB
81892011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8190
8191 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8192
d2fc7e3d 81932011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
8194
8195 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8196
d2fc7e3d 81972011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
8198
8199 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8200 `width' to `bar_area_x' and `bar_area_width', respectively.
8201 (x_scroll_run): Take account of fringe background extension.
8202
04f2d78b
CB
8203 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8204 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
8205 `bar_area_width', respectively.
8206 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8207 background extension.
8208
79b70037
GM
82092011-05-10 Jim Meyering <meyering@redhat.com>
8210
8211 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8212
2f142cc5
JB
82132011-05-10 Juanma Barranquero <lekktu@gmail.com>
8214
8215 * image.c (Finit_image_library): Return t for built-in image types,
8216 like pbm and xbm. (Bug#8640)
8217
57679c86
AS
82182011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8219
8220 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8221
888c9e86
EZ
82222011-05-07 Eli Zaretskii <eliz@gnu.org>
8223
b0512a1d
EZ
8224 * w32console.c (Fset_screen_color): Doc fix.
8225 (Fget_screen_color): New function.
8226 (syms_of_ntterm): Defsubr it.
8227
7285dc67
EZ
8228 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8229 unlink the temporary file if Fcall_process didn't create it in the
8230 first place.
8231 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8232 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
8233 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8234 cue to call_process_cleanup not to close that handle.
8235
4d3fcc8e
BK
82362011-05-07 Ben Key <bkey76@gmail.com>
8237
8238 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8239 one of two shell specific rules, either bootstrap-temacs-CMD or
8240 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8241 to the previous implementation of the bootstrap-temacs rule.
8242 The bootstrap-temacs-CMD rule is similar to the previous
8243 implementation of the bootstrap-temacs rule except that it
8244 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8245 variable.
8246
8247 These changes, along with some changes to nt/configure.bat,
8248 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8249 earlier fix to add support for --cflags and --ldflags options
8250 that include quotes so that it works whether make uses cmd or
8251 sh as the shell.
8252
b4289b64
MA
82532011-05-06 Michael Albinus <michael.albinus@gmx.de>
8254
8255 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8256 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8257 is a constant.
8258 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8259 a string. Handle both cases.
8260 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8261 (Fdbus_register_method): Use Qinvalid_function.
8262
af4c0e28
JB
82632011-05-06 Juanma Barranquero <lekktu@gmail.com>
8264
8265 * makefile.w32-in: Update dependencies.
8266 (LISP_H): Add inttypes.h and stdin.h.
8267 (PROCESS_H): Add unistd.h.
8268
c51453d9
EZ
82692011-05-06 Eli Zaretskii <eliz@gnu.org>
8270
8271 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8272 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8273
8ff0ac3c 82742011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 8275
4c4b566b
PE
8276 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8277
aab2b9b5
PE
8278 * term.c (vfatal): Remove stray call to va_end.
8279 It's not needed and the C Standard doesn't allow it here anyway.
8280
c378da0b
PE
8281 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8282 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8283
288b08c7
PE
8284 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8285 bytes.
8286
e3601888
PE
8287 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8288
db6c0e74
PE
8289 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8290
dd5963ea
PE
8291 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8292
88c9450f
PE
8293 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8294
2f9442b8
PE
8295 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8296
c032b5f8
PE
8297 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8298 * charset.c (Fdefine_charset_internal): Don't initialize
8299 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 8300 32-bit int (Bug#8600).
a108c10b
PE
8301
8302 * lread.c (read_integer): Be more consistent with string-to-number.
8303 Use string_to_number to do the actual conversion; this avoids
8304 rounding errors and fixes some other screwups. Without this fix,
8305 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8306 (digit_to_number): Move earlier, for benefit of read_integer.
8307 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 8308 not a digit in any supported base. (Bug#8602)
a108c10b 8309
ad5f9eea
PE
8310 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8311
aec1708a
PE
8312 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8313 to match comment at start of function. This also removes a
8314 GCC warning about overflow in a 32+64-bit port.
8315
47be4ab5
PE
8316 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8317
371cac43
PE
8318 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8319 Reported by Stefan Monnier in
8320 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
8321 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8322 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 8323
d01a7826
PE
8324 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8325 (EMACS_UINTPTR): Likewise, with uintptr_t.
8326
7fd47d5c
PE
8327 * lisp.h: Prefer 64-bit EMACS_INT if available.
8328 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8329 on 32-bit hosts that have 64-bit int, so that they can access
8330 large files.
122b0c86
PE
8331 However, temporarily disable this change unless the temporary
8332 symbol WIDE_EMACS_INT is defined.
7fd47d5c 8333
8727937b
PE
8334 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8335
8ac068ac
PE
8336 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8337 This removes an assumption that EMACS_INT and long are the same
8338 width as pointers. The assumption is true for Emacs porting targets
8339 now, but we want to make other targets possible.
8340 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8341 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8342 In the rest of the code, change types of integers that hold casted
8343 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8344 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8345 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8346 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8347 No need to cast type when ORing.
8348 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8349 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8350 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8351 assume EMACS_INT is the same width as char *.
8352 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8353 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8354 Remove no-longer-needed casts.
8355 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8356 (xg_tool_bar_help_callback, xg_make_tool_item):
8357 Use EMACS_INTPTR to hold an integer
8358 that will be cast to void *; this can avoid a GCC warning
8359 if EMACS_INT is not the same width as void *.
8360 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8361 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8362 (current_message_1, set_message_1):
8363 Use a local to convert to proper width without a cast.
8364 * xmenu.c (dialog_selection_callback): Likewise.
8365
ede49d71
PE
8366 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8367 Also, don't assume VALBITS / RAND_BITS is less than 5,
8368 and don't rely on undefined behavior when shifting a 1 left into
8369 the sign bit.
8370 * lisp.h (get_random): Change signature to match.
8371
2f30ecd0
PE
8372 * lread.c (hash_string): Use size_t, not int, for hash computation.
8373 Normally we prefer signed values; but hashing is special, because
8374 it's better to use unsigned division on hash table sizes so that
8375 the remainder is nonnegative. Also, size_t is the natural width
8376 for hashing into memory. The previous code used 'int', which doesn't
8377 retain enough info to hash well into very large tables.
8378 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8379
2a866e7b
PE
8380 * dbusbind.c: Don't possibly lose pointer info when converting.
8381 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8382 Use XPNTR rather than XHASH, so that the high-order bits of
8383 the pointer aren't lost when converting through void *.
8384
51639eac
PE
8385 * eval.c (Fautoload): Don't double-shift a pointer.
8386
92394119
PE
8387 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8388
dbdb9a7c
JB
83892011-05-06 Juanma Barranquero <lekktu@gmail.com>
8390
8391 * gnutls.c (DEF_GNUTLS_FN):
8392 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8393
db7a0b4f
AS
83942011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8395
8396 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8397 marker. (Bug#8610)
8398
cd394be1 83992011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
8400
8401 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8402 New version that can reserve upto 2GB of heap space.
8403
f7ff1b0f 84042011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
8405
8406 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8407
639c109b
TZ
84082011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8409
8410 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8411 `gnutls_certificate_set_x509_key_file'.
8412
d2127135
JB
84132011-05-05 Juanma Barranquero <lekktu@gmail.com>
8414
8415 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8416 Update dependencies.
8417
e968f4f3
JB
84182011-05-04 Juanma Barranquero <lekktu@gmail.com>
8419
8420 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8421 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8422 Remove unused parameter `fildes'.
8423 * process.c (read_process_output, send_process): Don't pass it.
8424
84d358f0
JB
84252011-05-04 Juanma Barranquero <lekktu@gmail.com>
8426
8427 Fix previous change: the library cache is defined in w32.c.
8428 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8429 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8430
0898ca10
JB
84312011-05-04 Juanma Barranquero <lekktu@gmail.com>
8432
8433 Implement dynamic loading of GnuTLS on Windows.
8434
8435 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8436 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8437 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8438 Declare.
8439
8440 * gnutls.c (Qgnutls_dll): Define.
8441 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8442 (gnutls_*): Declare function pointers.
8443 (init_gnutls_functions): New function to initialize function pointers.
8444 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8445 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8446 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8447 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8448 (emacs_gnutls_write, emacs_gnutls_read)
8449 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8450 (Fgnutls_available_p): New function.
8451 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8452 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8453 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8454
8455 * image.c: Include w32.h.
8456 (Vimage_type_cache): Delete.
8457 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8458 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8459 (w32_delayed_load): Move to w32.c.
8460
8461 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8462
8463 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8464 (w32_delayed_load): Move from image.c. When loading a library, record
8465 its filename in the :loaded-from property of the library id.
8466 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8467 Initialize and staticpro them.
8468 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8469
8470 * process.c: Include lisp.h before w32.h, not after.
8471 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8472 instead of gnutls_record_check_pending.
8473
8474 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8475
ff4de4aa
TZ
84762011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8477
8478 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8479 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8480 as passed in.
8481
abe95abb
JD
84822011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8483
8484 * xterm.c (x_set_frame_alpha): Do not set property on anything
8485 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8486
e16e55d4
JB
84872011-05-02 Juanma Barranquero <lekktu@gmail.com>
8488
8489 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8490
bafcf6a5
JB
84912011-05-02 Juanma Barranquero <lekktu@gmail.com>
8492
8493 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8494 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8495 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8496 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8497 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8498 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8499 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8500 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8501 (Qgnutls_bootprop_callbacks_verify): Make static.
8502
e7a6747f
AS
85032011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8504
19ed11ba
AS
8505 * callproc.c: Indentation fixup.
8506
e7a6747f 8507 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
8508 (wait_for_termination, interruptible_wait_for_termination):
8509 Move after wait_for_termination_1.
e7a6747f 8510
1ef14cb4
LMI
85112011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8512
8513 * sysdep.c (interruptible_wait_for_termination): New function
8514 which is like wait_for_termination, but allows keyboard
8515 interruptions.
8516
8517 * callproc.c (Fcall_process): Add (:file "file") as an option for
8518 the STDOUT buffer.
8519 (Fcall_process_region): Ditto.
8520
330d880c
EZ
85212011-04-30 Eli Zaretskii <eliz@gnu.org>
8522
8db90b73
EZ
8523 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8524 rather than `XVECTOR (FOO)->size'.
8525
330d880c
EZ
8526 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8527 inttypes.h, as a gnulib replacement is used if it not available in
8528 system headers.
8529
15cbd324
EZ
85302011-04-21 Eli Zaretskii <eliz@gnu.org>
8531
8532 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8533 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8534 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8535
8536 * coding.c (coding_alloc_by_realloc): Error out if destination
8537 will grow beyond MOST_POSITIVE_FIXNUM.
8538 (decode_coding_emacs_mule): Abort if there isn't enough place in
8539 charbuf for the composition carryover bytes. Reserve an extra
8540 space for up to 2 characters produced in a loop.
8541 (decode_coding_iso_2022): Abort if there isn't enough place in
8542 charbuf for the composition carryover bytes.
8543
85442011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 8545
ae940cca
EZ
8546 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8547 aborting when %lld or %lll format is passed.
8548 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8549 %llo or %llx format is passed. (Bug#8545)
8550
03ab8921
EZ
8551 * window.c (window_scroll_line_based): Use a marker instead of
8552 simple variables to record original value of point. (Bug#7952)
8553
afda1437
EZ
8554 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8555 produced by %s or %c overflows available buffer space. (Bug#8545)
8556
f76dee0c
PE
85572011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8558
8559 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 8560 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 8561
fdc5744d
JB
85622011-04-28 Juanma Barranquero <lekktu@gmail.com>
8563
8564 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8565
638f053a
JB
85662011-04-28 Juanma Barranquero <lekktu@gmail.com>
8567
8568 * keyboard.c (Qdelayed_warnings_hook): Define.
8569 (command_loop_1): Run `delayed-warnings-hook'
8570 if Vdelayed_warnings_list is non-nil.
8571 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8572 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8573
d178f871
EZ
85742011-04-28 Eli Zaretskii <eliz@gnu.org>
8575
8576 * doprnt.c (doprnt): Don't return value smaller than the buffer
8577 size if the message was truncated. (Bug#8545).
8578
b124fd93
JB
85792011-04-28 Juanma Barranquero <lekktu@gmail.com>
8580
8581 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8582 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8583
e810457d
PE
85842011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8585
8586 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8587
ea51cceb
JB
85882011-04-27 Juanma Barranquero <lekktu@gmail.com>
8589
8590 * makefile.w32-in: Update dependencies.
8591
94dcfacf
EZ
85922011-04-27 Eli Zaretskii <eliz@gnu.org>
8593
8594 Improve `doprnt' and its usage. (Bug#8545)
8595 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8596 `format_end'. Remove support for %l as a conversion specifier.
8597 Don't use xrealloc. Improve diagnostics when the %l size modifier
8598 is used. Update the commentary.
8599
8600 * eval.c (verror): Simplify calculation of size_t.
8601
8602 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8603 messages.
8604
f61f41d7
PE
86052011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8606
8607 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8608 change.
8609
96fb4434
PE
86102011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8611
8612 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8613 This makes this file independent of the recent pseudovector change.
8614
671875da 86152011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 8616
69e9b5a3
PE
8617 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8618
b5f869a7 8619 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 8620 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 8621 Remove unused local.
c8926152 8622 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 8623
841a1577 8624 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
8625 GCC 4.6.0 optimizes based on type-based alias analysis.
8626 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
8627 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8628 != &v->size, and therefore "v->size = 1; b->size = 2; return
8629 v->size;" must therefore return 1. This assumption is incorrect
8630 for Emacs, since it type-puns struct Lisp_Vector * with many other
8631 types. To fix this problem, this patch adds a new type struct
f904488f 8632 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
8633 and pseudovectors, and helps optimizing compilers not get fooled
8634 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8635 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
8636 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8637 the size member.
eab3844f
PE
8638 (XSETPVECTYPE): Rewrite in terms of new macro.
8639 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8640 This is a bit clearer, and further avoids the possibility of
8641 undesirable aliasing.
8642 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 8643 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
8644 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8645 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
8646 (ASIZE): Now uses header.size rather than size.
8647 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
8648 to avoid the hassle of writing XVECTOR (foo)->header.size.
8649 (struct vectorlike_header): New type.
eab3844f
PE
8650 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8651 object, to help avoid aliasing.
8652 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8653 (SUBRP): Likewise, since Lisp_Subr is a special case.
8654 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8655 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8656 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 8657 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
8658 changed to be "header.size" and "header.next".
8659 * buffer.h (struct buffer): Likewise.
8660 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8661 * frame.h (struct frame): Likewise.
8662 * process.h (struct Lisp_Process): Likewise.
8663 * termhooks.h (struct terminal): Likewise.
8664 * window.c (struct save_window_data, struct saved_window): Likewise.
8665 * window.h (struct window): Likewise.
8666 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8667 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8668 * buffer.c (init_buffer_once): Likewise.
8669 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8670 special case.
8671 * process.c (Fformat_network_address): Use local var for size,
8672 for brevity.
8673
0df1eac5
PE
8674 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8675
847ab9d1 8676 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
8677 * data.c (atof): Remove decl; no longer used or needed.
8678 (digit_to_number): Move to lread.c.
8679 (Fstring_to_number): Use new string_to_number function, to be
8680 consistent with how the Lisp reader treats infinities and NaNs.
8681 Do not assume that floating-point numbers represent EMACS_INT
8682 without losing information; this is not true on most 64-bit hosts.
8683 Avoid double-rounding errors, by insisting on integers when
8684 parsing non-base-10 numbers, as the documentation specifies.
8685 * lisp.h (string_to_number): New decl, replacing ...
8686 (isfloat_string): Remove.
bc0a5c13 8687 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 8688 (read1): Do not accept +. and -. as integers; this
452f4150
PE
8689 appears to have been a coding error. Similarly, do not accept
8690 strings like +-1e0 as floating point numbers. Do not report
8691 overflow for integer overflows unless the base is not 10 which
8692 means we have no simple and reliable way to continue.
8693 Break out the floating-point parsing into a new
8694 function string_to_number, so that Fstring_to_number parses
8695 floating point numbers consistently with the Lisp reader.
04f2d78b 8696 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
8697 (E_CHAR, EXP_INT): Remove, replacing with ...
8698 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8699 (string_to_number): New function, replacing isfloat_string.
8700 This function checks for valid syntax and produces the resulting
8701 Lisp float number too. Rework it so that string-to-number
bc0a5c13 8702 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
8703 so that overflow for non-base-10 numbers is reported only when
8704 there's no portable and simple way to convert to floating point.
452f4150 8705
67769ffc
PE
8706 * textprop.c (set_text_properties_1): Rewrite for clarity,
8707 and to avoid GCC warning about integer overflow.
8708
c20db43f
PE
8709 * intervals.h (struct interval): Use EMACS_INT for members
8710 where EMACS_UINT might cause problems. See
8711 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8712 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8713 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8714 All uses changed.
37aa2f85
PE
8715 (offset_intervals): Tell GCC not to worry about length overflow
8716 when negating a negative length.
c20db43f 8717
2538aa2f
PE
8718 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8719 (overrun_check_free): Likewise.
8720
f2d3008d
PE
8721 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8722 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8723 word size.
8724
ec8df744
PE
8725 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8726 (gnutls_make_error): Rename local to avoid shadowing.
8727 (gnutls_emacs_global_deinit): ifdef out; not used.
8728 (Fgnutls_boot): Use const for pointer to readonly storage.
8729 Comment out unused local. Fix pointer signedness problems.
8730
640ee02d
PE
8731 * lread.c (openp): Don't stuff size_t into an 'int'.
8732 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8733 about possible signed overflow.
8734
6048fb2a
PE
8735 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8736 (GDK_KEY_g): Don't define if already defined.
8737 (xg_prepare_tooltip): Avoid pointer signedness problem.
8738 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8739
fa3c87e1
PE
8740 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8741 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8742
2172544b
PE
8743 * xfns.c (Fx_window_property): Simplify a bit,
8744 to make a bit faster and to avoid GCC 4.6.0 warning.
8745 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
8746
9b821a21
PE
8747 * fns.c (internal_equal): Don't assume size_t fits in int.
8748
3c616cfa
PE
8749 * alloc.c (compact_small_strings): Tighten assertion a little.
8750
c2982e87
PE
8751 Replace pEd with more-general pI, and fix some printf arg casts.
8752 * lisp.h (pI): New macro, generalizing old pEd macro to other
8753 conversion specifiers. For example, use "...%"pI"d..." rather
8754 than "...%"pEd"...".
8755 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 8756 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
8757 * alloc.c (check_pure_size): Don't overflow by converting size to int.
8758 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
8759 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
8760 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
8761 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
8762 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
8763 64-bit hosts.
8764 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
8765 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
8766 * print.c (safe_debug_print, print_object): Likewise.
8767 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
8768 to int.
6f04d126
PE
8769 Use pI instead of if-then-else-abort. Use %p to avoid casts,
8770 avoiding the 0 flag, which is not portable.
c2982e87
PE
8771 * process.c (Fmake_network_process): Use pI to avoid cast.
8772 * region-cache.c (pp_cache): Likewise.
8773 * xdisp.c (decode_mode_spec): Likewise.
8774 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
8775 behavior on 64-bit hosts with printf arg.
6f04d126 8776 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
8777 (x_stop_queuing_selection_requests): Likewise.
8778 (x_get_window_property): Don't truncate byte count to an 'int'
8779 when tracing.
0b432f21 8780
5e073ec7
PE
8781 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
8782 here, since it parses constructs like leading '-' and spaces,
8783 which are not wanted; and it overflows with large numbers.
8784 Instead, simply match F[0-9]+, which is what is wanted anyway.
8785
36372bf9
PE
8786 * alloc.c: Remove unportable assumptions about struct layout.
8787 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
8788 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
8789 (allocate_vectorlike, make_pure_vector): Use the new macros,
8790 plus offsetof, to remove unportable assumptions about struct layout.
8791 These assumptions hold on all porting targets that I know of, but
8792 they are not guaranteed, they're easy to remove, and removing them
8793 makes further changes easier.
8794
0b432f21
PE
8795 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
8796 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
8797 (string_overrun_cookie): Now const. Use initializers that
8798 don't formally overflow signed char, to avoid warnings.
000098c1
PE
8799 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
8800 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
8801 (allocate_buffer): Don't assume sizeof (struct buffer) is a
8802 multiple of sizeof (EMACS_INT); it need not be, if
8803 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 8804 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 8805
895009e1
JB
88062011-04-26 Juanma Barranquero <lekktu@gmail.com>
8807
8808 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
8809
6a7a1b0b
TZ
88102011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
8811
8812 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 8813 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
8814 Reported by Paul Eggert <eggert@cs.ucla.edu>.
8815
841a1577 88162011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
8817
8818 * lisp.h (Qdebug): List symbol.
895009e1 8819 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
8820 * keyboard.c (debug-on-event): New variable.
8821 (handle_user_signal): Break into debugger when debug-on-event
8822 matches the current signal symbol.
8823
f2d3ba6f
DN
88242011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
8825
8826 * alloc.c (check_sblock, check_string_bytes)
8827 (check_string_free_list): Convert to standard C.
8828
42ce4c63
TZ
88292011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
8830
8831 * w32.c (emacs_gnutls_push): Fix typo.
8832
825cd63c
EZ
88332011-04-25 Eli Zaretskii <eliz@gnu.org>
8834
fb11d64d
EZ
8835 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
8836 "cast to pointer from integer of different size".
8837
825cd63c
EZ
8838 Improve doprnt and its use in verror. (Bug#8545)
8839 * doprnt.c (doprnt): Document the set of format control sequences
8840 supported by the function. Use SAFE_ALLOCA instead of always
8841 using `alloca'.
8842
8843 * eval.c (verror): Don't limit the buffer size at size_max-1, that
8844 is one byte too soon. Don't use xrealloc; instead xfree and
8845 xmalloc anew.
8846
e061a11b
TZ
88472011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
8848
8849 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
8850 callbacks stage.
8851
8852 * gnutls.c: Renamed global_initialized to
8853 gnutls_global_initialized. Added internals for the
8854 :verify-hostname-error, :verify-error, and :verify-flags
8855 parameters of `gnutls-boot' and documented those parameters in the
8856 docstring. Start callback support.
9173deec
JB
8857 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
8858 unless a fatal error occurred. Call gnutls_alert_send_appropriate
8859 on error. Return error code.
e061a11b
TZ
8860 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
8861 (emacs_gnutls_read): Likewise.
8862 (Fgnutls_boot): Return handshake error code.
8863 (emacs_gnutls_handle_error): New function.
8864 (wsaerror_to_errno): Likewise.
8865
8866 * w32.h (emacs_gnutls_pull): Add prototype.
8867 (emacs_gnutls_push): Likewise.
8868
8869 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
8870 (emacs_gnutls_push): Likewise.
8871
88722011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
8873
8874 * process.c (wait_reading_process_output): Check if GnuTLS
8875 buffered some data internally if no FDs are set for TLS
8876 connections.
8877
8878 * makefile.w32-in (OBJ2): Add gnutls.$(O).
8879 (LIBS): Link to USER_LIBS.
8880 ($(BLD)/gnutls.$(0)): New target.
8881
fa6996bc
EZ
88822011-04-24 Eli Zaretskii <eliz@gnu.org>
8883
eb35682e
EZ
8884 * xdisp.c (handle_single_display_spec): Rename the
8885 display_replaced_before_p argument into display_replaced_p, to
8886 make it consistent with the commentary. Fix typos in the
8887 commentary.
8888
e2ad650c
EZ
8889 * textprop.c (syms_of_textprop): Remove dead code.
8890 (copy_text_properties): Delete obsolete commentary about an
8891 interface that was deleted long ago. Fix typos in the description
8892 of arguments.
8893
1b2de274
EZ
8894 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
8895 to changes in oldXMenu/XMenu.h from 2011-04-16.
8896 <menu_help_message, prev_menu_help_message>: Constify.
8897 (IT_menu_make_room): menu->help_text is now `const char **';
8898 adjust.
8899
8900 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
8901 to changes in oldXMenu/XMenu.h from 2011-04-16.
8902 (struct XMenu): Declare `help_text' `const char **'.
8903
8904 * xfaces.c <Qunspecified>: Make extern again.
8905
8906 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 8907 required by POSIX.
1b2de274 8908
762b15be
EZ
8909 * doc.c (get_doc_string): Improve the format passed to `error'.
8910
8911 * doprnt.c (doprnt): Improve commentary.
8912
8913 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
8914
8915 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
8916 them with etags.
8917
f1052e5d
EZ
8918 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
8919 changes in globals.h immediately force recompilation.
762b15be
EZ
8920 (TAGS): Depend on $(CURDIR)/m/intel386.h and
8921 $(CURDIR)/s/ms-w32.h.
8922 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 8923
fa6996bc
EZ
8924 * character.c (Fchar_direction): Function deleted.
8925 (syms_of_character): Don't defsubr it.
8926 <char-direction-table>: Deleted.
8927
e6c3da20
EZ
89282011-04-23 Eli Zaretskii <eliz@gnu.org>
8929
8930 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
8931 * doprnt.c: Include limits.h.
8932 (SIZE_MAX): New macro.
04f2d78b
CB
8933 (doprnt): Return a size_t value. 2nd arg is now size_t.
8934 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
8935 Improve overflow protection. Support `l' modifier for integer
8936 conversions. Support %l conversion. Don't assume an EMACS_INT
8937 argument for integer conversions and for %c.
8938
8939 * lisp.h (doprnt): Restore prototype.
8940
8941 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
8942 $(SRC)/character.h.
8943
8944 * Makefile.in (base_obj): Add back doprnt.o.
8945
8946 * deps.mk (doprnt.o): Add back prerequisites.
8947 (callint.o): Depend on character.h.
8948
8949 * eval.c (internal_lisp_condition_case): Include the handler
8950 representation in the error message.
8951 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
8952 when breaking from the loop.
8953
8954 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
8955
8956 * callint.c (Fcall_interactively): When displaying error message
8957 about invalid control letter, pass the character's codepoint, not
8958 a pointer to its multibyte form. Improve display of the character
8959 in octal and display also its hex code.
8960
8961 * character.c (char_string): Use %x to display the (unsigned)
8962 codepoint of an invalid character, to avoid displaying a bogus
8963 negative value.
8964
8965 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
8966 `error', not SYMBOL_NAME itself.
8967
8968 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
8969 character arguments to `error'.
8970
8971 * charset.c (check_iso_charset_parameter): Fix incorrect argument
8972 to `error' in error message about FINAL_CHAR argument. Make sure
8973 FINAL_CHAR is a character, and use %c when it is passed as
8974 argument to `error'.
8975
4ffd0d6b 89762011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
8977
8978 * s/ms-w32.h (localtime): Redirect to sys_localtime.
8979
8980 * w32.c: Include <time.h>.
8981 (sys_localtime): New function.
8982
4ffd0d6b 89832011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
8984
8985 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
8986
4ffd0d6b 8987 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 8988
4ffd0d6b 89892011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 8990
4ffd0d6b
GM
8991 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
8992 zombies (Bug#8467).
aac0c6e3 8993
04c56954
EZ
89942011-04-19 Eli Zaretskii <eliz@gnu.org>
8995
8996 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
8997 gl_state.e_property when gl_state.object is Qt.
8998
8999 * insdel.c (make_gap_larger): Remove limitation of buffer size
9000 to <= INT_MAX.
9001
16a43933
CY
90022011-04-18 Chong Yidong <cyd@stupidchicken.com>
9003
9004 * xdisp.c (lookup_glyphless_char_display)
9005 (produce_glyphless_glyph): Handle cons cell entry in
9006 glyphless-char-display.
9007 (Vglyphless_char_display): Document it.
9008
9009 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9010 glyphless-char-display.
9011
4581706e
CY
90122011-04-17 Chong Yidong <cyd@stupidchicken.com>
9013
9014 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9015
9016 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9017
9018 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9019 definition for no-X builds.
9020
4887c6e2 90212011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9022
fd35b6f9
PE
9023 Static checks with GCC 4.6.0 and non-default toolkits.
9024
5c1ccb01
PE
9025 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9026
006c5daa
PE
9027 * process.c (keyboard_bit_set): Define only if SIGIO.
9028 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9029 (send_process): Repair possible setjmp clobbering.
9030
efc736d3
PE
9031 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9032
4e2fe2e6
PE
9033 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9034
f97334a2
PE
9035 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9036
4e75f29d
PE
9037 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9038 Define only if needed.
9039
90efadd1
PE
9040 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9041 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9042 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9043
3c647824
PE
9044 * dispextern.h (struct redisplay_interface): Rename param
9045 to avoid shadowing.
e264f262 9046 * termhooks.h (struct terminal): Likewise.
761383f4 9047 * xterm.c (xembed_send_message): Likewise.
3c647824 9048
b58c5c4a
PE
9049 * insdel.c (make_gap_smaller): Define only if
9050 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9051
cad59032
PE
9052 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9053 it.
9054
c339dc2e
PE
9055 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9056 so that we aren't warned about unused symbols.
9057
91a3e27b
PE
9058 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9059
399c71d3 9060 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9061
8ffc96f5
PE
9062 * xfns.c (x_real_positions): Mark locals as initialized.
9063
eef9bc79
PE
9064 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9065
098db9dd
PE
9066 * xterm.c: Fix problems found by static analysis with other toolkits.
9067 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9068 (x_dispatch_event): Declare static if USE_GTK, and
9069 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9070 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9071 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9072 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9073 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9074
eb18f6cc
PE
9075 * xmenu.c (menu_help_callback): Pointer type fixes.
9076 Use const pointers when pointing at readonly data. Avoid pointer
9077 signedness clashes.
9078 (FALSE): Remove unused macro.
9079 (update_frame_menubar): Remove unused decl.
9080
1fe72bf8
PE
9081 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9082
60d9e1db
PE
9083 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9084 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9085 (single_menu_item): Rename local to avoid shadowing.
9086
39261c26
PE
9087 * keyboard.c (make_lispy_event): Remove unused local var.
9088
018c5e19
PE
9089 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9090 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9091
63d2b86e
PE
9092 * bitmaps: Change bitmaps from unsigned char back to the X11
9093 compatible char. Avoid the old compiler warnings about
9094 out-of-range initializers by using, for example, '\xab' rather
9095 than 0xab.
9096
aefd87e1
PE
9097 * xgselect.c (xgselect_initialize): Check vs interface
9098 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9099
bf501fb9
PE
9100 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9101
e9829fdf
PE
9102 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9103 to read-only memory.
9104
1086c095
PE
9105 * fns.c (vector): Remove; this old hack is no longer needed.
9106
2baccd04 9107 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9108 Remove unused var.
dde42981 9109 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9110
72391843 9111 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9112
436c16df 9113 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9114 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9115 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9116
92bb796d 9117 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9118 (x_term_init): Remove local to avoid shadowing.
92bb796d 9119
764430a3 9120 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9121
9122 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9123 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9124
d1dfb56c
EZ
91252011-04-16 Eli Zaretskii <eliz@gnu.org>
9126
c4354cb4
EZ
9127 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9128
d1dfb56c
EZ
9129 Fix regex.c, syntax.c and friends for buffers > 2GB.
9130 * syntax.h (struct gl_state_s): Declare character position members
9131 EMACS_INT.
9132
9133 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9134
04f2d78b
CB
9135 * textprop.c (verify_interval_modification, interval_of):
9136 Declare arguments EMACS_INT.
d1dfb56c
EZ
9137
9138 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9139 EMACS_INT.
9140
9141 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9142
9143 * indent.c (Fvertical_motion): Local variable it_start is now
9144 EMACS_INT.
9145
9146 * regex.c (re_match, re_match_2, re_match_2_internal)
9147 (bcmp_translate, regcomp, regexec, print_double_string)
9148 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9149 (re_compile_pattern, re_exec): Declare arguments and local
9150 variables `size_t' and `ssize_t' and return values `regoff_t', as
9151 appropriate.
9152 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9153 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9154 <compile_stack_type>: `size' and `avail' are now `size_t'.
9155
9156 * regex.h <regoff_t>: Use ssize_t, not int.
9157 (re_search, re_search_2, re_match, re_match_2): Arguments that
9158 specify buffer/string position and length are now ssize_t and
9159 size_t. Return type is regoff_t.
9160
613052cd
BK
91612011-04-16 Ben Key <bkey76@gmail.com>
9162
9163 * nsfont.m: Fixed bugs in ns_get_family and
9164 ns_descriptor_to_entity that were caused by using free to
9165 deallocate memory blocks that were allocated by xmalloc (via
9166 xstrdup). This caused Emacs to crash when compiled with
9167 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9168 --enable-checking=xmallocoverrun). xfree is now used to
9169 deallocate these memory blocks.
9170
4170f62f 91712011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 9172
71b41406
PE
9173 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9174
9587a89d
PE
9175 emacs_write: Accept and return EMACS_INT for sizes.
9176 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9177 et seq.
9178 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9179 Accept and return EMACS_INT.
9180 (emacs_gnutls_write): Return the number of bytes written on
9181 partial writes.
9182 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
9183 (emacs_read, emacs_write): Remove check for negative size, as the
9184 Emacs source code has been audited now.
9587a89d
PE
9185 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9186 (emacs_read, emacs_write): Use it.
273a5f82
PE
9187 * process.c (send_process): Adjust to the new signatures of
9188 emacs_write and emacs_gnutls_write. Do not attempt to store
9189 a byte offset into an 'int'; it might overflow.
9587a89d 9190 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 9191
3e047f51
PE
9192 * sound.c: Don't assume sizes fit in 'int'.
9193 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 9194 Return EMACS_INT, not int.
3e047f51 9195 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
9196 Accept EMACS_INT, not int.
9197 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
9198 record read return values.
9199
cc39a9db
BK
92002011-04-15 Ben Key <bkey76@gmail.com>
9201
c9d0ec6d
JB
9202 * keyboard.c (Qundefined): Don't declare static since it is used
9203 in nsfns.m.
9204 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9205 static since they are used in nsfont.m.
cc39a9db 9206
6c60eb9f
SM
92072011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9208
9209 * process.c (Qprocessp): Don't declare static.
9210 * lisp.h (Qprocessp): Declare again.
9211
7990b61a
JB
92122011-04-15 Juanma Barranquero <lekktu@gmail.com>
9213
9214 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9215
5d4cb038
PE
92162011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9217
8bd7b830 9218 Improve C-level modularity by making more things 'static'.
cd64ea1d 9219
e3b27b31
PE
9220 Don't publish debugger-only interfaces to other modules.
9221 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9222 (verify_bytepos, count_markers): Move decls to the only modules
9223 that need them.
9224 * region-cache.h (pp_cache): Likewise.
9225 * window.h (check_all_windows): Likewise.
9226 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9227
5d4cb038
PE
9228 * sysdep.c (croak): Now static, if
9229 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9230 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
9231
9232 * alloc.c (refill_memory_reserve): Now static if
9233 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9234 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 9235
e87b6180
PE
9236 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9237 Define only if USE_LUCID.
9238
ac64929e
PE
9239 * xrdb.c (x_customization_string, x_rm_string): Now static.
9240
6f37259d
PE
9241 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9242 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9243
1683e3ab
PE
9244 * xdisp.c (draw_row_with_mouse_face): Now static.
9245 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9246
de9c2632
PE
9247 * window.h (check_all_windows): Mark externally visible.
9248
2b96acb7
PE
9249 * window.c (window_deletion_count): Now static.
9250
9251 * undo.c: Make symbols static if they're not exported.
9252 (last_undo_buffer, last_boundary_position, pending_boundary):
9253 Now static.
9254
50436f33
PE
9255 * textprop.c (interval_insert_behind_hooks): Now static.
9256 (interval_insert_in_front_hooks): Likewise.
9257
64520e5c
PE
9258 * term.c: Make symbols static if they're not exported.
9259 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9260 (max_frame_lines, tty_set_terminal_modes):
9261 (tty_reset_terminal_modes, tty_turn_off_highlight):
9262 (get_tty_terminal): Now static.
9263 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9264 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 9265 HAVE_WINDOW_SYSTEM.
64520e5c
PE
9266 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9267 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9268
1fa53021
PE
9269 * sysdep.c: Make symbols static if they're not exported.
9270 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9271 Now static.
9272 (sigprocmask_set, full_mask): Remove; unused.
9273 (wait_debugging): Mark as visible.
9274 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9275 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9276
d4b43b22
PE
9277 * syntax.c (syntax_temp): Define only if !__GNUC__.
9278
b7c513d0
PE
9279 * sound.c (current_sound_device, current_sound): Now static.
9280
989b29ad
PE
9281 * search.c (searchbufs, searchbuf_head): Now static.
9282
13a55a78
PE
9283 * scroll.c (scroll_cost): Remove; unused.
9284 * dispextern.h (scroll_cost): Remove decl.
9285
de68a1fc
PE
9286 * region-cache.h (pp_cache): Mark as externally visible.
9287
40ccffa6
PE
9288 * process.c: Make symbols static if they're not exported.
9289 (process_tick, update_tick, create_process, chan_process):
9290 (Vprocess_alist, proc_buffered_char, datagram_access):
9291 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9292 (deactivate_process): Mark defn as static, as well as decl.
9293 * lisp.h (create_process): Remove decl.
9294 * process.h (chan_process, Vprocess_alist): Remove decls.
9295
ad64fc97
PE
9296 * print.c: Make symbols static if they're not exported.
9297 (print_depth, new_backquote_output, being_printed, print_buffer):
9298 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9299 (print_interval, print_number_index, initial_stderr_stream):
9300 Now static.
9301 * lisp.h (Fprinc): Remove decl.
9302 (debug_output_compilation_hack): Mark as externally visible.
9303
adddb265
PE
9304 * sysdep.c (croak): Move decl from here to syssignal.h.
9305 * syssignal.h (croak): Put it here, so the API can be checked when
9306 'croak' is called from dissociate_if_controlling_tty.
9307
1717ede2
PE
9308 * minibuf.c: Make symbols static if they're not exported.
9309 (minibuf_save_list, choose_minibuf_frame): Now static.
9310 * lisp.h (choose_minibuf_frame): Remove decl.
9311
fa5fb2bc
PE
9312 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9313
1e3890d1
PE
9314 * lread.c: Make symbols static if they're not exported.
9315 (read_objects, initial_obarray, oblookup_last_bucket_number):
9316 Now static.
9317 (make_symbol): Remove; unused.
9318 * lisp.h (initial_obarray, make_symbol): Remove decls.
9319
8a1414fa
PE
9320 * keyboard.c: Make symbols static if they're not exported.
9321 (single_kboard, recent_keys_index, total_keys, recent_keys):
9322 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9323 (this_single_command_key_start, echoing, last_auto_save):
9324 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9325 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9326 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9327 (Vlispy_mouse_stem, double_click_count):
9328 Now static.
9329 (force_auto_save_soon): Define only if SIGDANGER.
9330 (ignore_mouse_drag_p): Now static if
9331 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9332 (print_help): Remove; unused.
9333 (stop_character, last_timer_event): Mark as externally visible.
9334 * keyboard.h (ignore_mouse_drag_p): Declare only if
9335 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9336 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9337 * lisp.h (echoing): Remove decl.
9338 (force_auto_save_soon): Declare only if SIGDANGER.
9339 * xdisp.c (redisplay_window): Simplify code, to make it more
9340 obvious that ignore_mouse_drag_p is not accessed if !defined
9341 USE_GTK && !defined HAVE_NS.
9342
93ea6e8f
PE
9343 * intervals.c: Make symbols static if they're not exported.
9344 (merge_properties_sticky, merge_interval_right, delete_interval):
9345 Now static.
9346 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9347
77382fcc
PE
9348 * insdel.c: Make symbols static if they're not exported.
9349 However, leave prepare_to_modify_buffer alone. It's never
9350 called from outside this function, but that appears to be a bug.
9351 (combine_after_change_list, combine_after_change_buffer):
4889fc82 9352 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
9353 (adjust_after_replace_noundo): Remove; unused.
9354 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 9355 (signal_before_change): Remove decls.
77382fcc 9356
9306c32e
PE
9357 * indent.c (val_compute_motion, val_vmotion): Now static.
9358
cd44d2eb
PE
9359 * image.c: Make symbols static if they're not exported.
9360 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9361 if USE_GTK.
9362 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9363 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9364
ad9a7a06
PE
9365 * fringe.c (standard_bitmaps): Now static.
9366 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9367
81626931
PE
9368 * frame.c: Make symbols static if they're not exported.
9369 (x_report_frame_params, make_terminal_frame): Now static.
9370 (get_frame_param): Now static, unless HAVE_NS.
9371 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9372 (x_get_resource_string): Remove; not used.
9373 * frame.h (make_terminal_frame, x_report_frame_params):
9374 (x_get_resource_string); Remove decls.
9375 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9376 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9377
239f9db9
PE
9378 * font.c, fontset.c: Make symbols static if they're not exported.
9379 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9380 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9381 * font.c (font_close_object): Now static.
9382 * font.h (font_close_object): Remove.
9383 * fontset.c (FONTSET_OBJLIST): Remove.
9384 (free_realized_fontset) #if-0 the body, which does nothing.
9385 (face_suitable_for_char_p): #if-0, as it's never called.
9386 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
9387 * xfaces.c (face_at_string_position):
9388 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
9389 since 0 is always ASCII.
9390
dfcf3579
PE
9391 * fns.c (weak_hash_tables): Now static.
9392
5045092b
PE
9393 * fileio.c: Make symbols static if they're not exported.
9394 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9395 (Vwrite_region_annotation_buffers): Now static.
9396
57a96f5c
PE
9397 * eval.c: Make symbols static if they're not exported.
9398 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9399 * lisp.h (backtrace_list): Remove decl.
9400
35f08c38
PE
9401 * emacs.c: Make symbols static if they're not exported.
9402 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9403 (fatal_error_code, fatal_error_signal_hook, standard_args):
9404 Now static.
9405 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9406 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9407 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9408 * lisp.h (fatal_error_signal_hook): Remove decl.
9409 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9410
f44bd759
PE
9411 * editfns.c: Move a (normally-unused) function to its only use.
9412 * editfns.c, lisp.h (get_operating_system_release): Remove.
9413 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9414 worth the hassle of breaking this out.
9415
b532497d
PE
9416 * xterm.c: Make symbols static if they're not exported.
9417 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9418 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9419 (x_destroy_window, x_delete_display):
9420 Now static.
9421 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9422 (x_mouse_leave): Remove; unused.
9423 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9424 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9425 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9426 Remove decls.
9427 (x_mouse_leave): Declare only if WINDOWSNT.
9428 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9429 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9430 USE_X_TOOLKIT.
9431
1675728f
PE
9432 * ftxfont.c: Make symbols static if they're not exported.
9433 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9434 HAVE_FREETYPE.
9435 * font.h (ftxfont_driver): Likewise.
9436
e4cebfca
PE
9437 * xfns.c: Make symbols static if they're not exported.
9438 (x_last_font_name, x_display_info_for_name):
9439 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9440 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9441 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9442 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9443 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9444 (last_show_tip_args): Now static.
9445 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9446 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9447 (x_screen_planes): Remove; unused.
9448 * dispextern.h (x_screen_planes): Remove decl.
9449
5bf46f05
PE
9450 * dispnew.c: Make symbols static if they're not exported.
9451 * dispextern.h (redraw_garbaged_frames, scrolling):
9452 (increment_row_positions): Remove.
9453 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9454 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9455 Now static.
9456 (redraw_garbaged_frames): Remove; unused.
9457
435f4c28
PE
9458 * xfaces.c: Make symbols static if they're not exported.
9459 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9460 Remove decls.
9461 * xterm.h (defined_color): Remove decls.
9462 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9463 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9464 (menu_face_changed_default, defined_color, free_realized_face):
9465 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9466 (ascii_face_of_lisp_face): Remove; unused.
9467
8524aef3
PE
9468 * xdisp.c: Make symbols static if they're not exported.
9469 * dispextern.h (scratch_glyph_row, window_box_edges):
9470 (glyph_to_pixel_coords, set_cursor_from_row):
9471 (get_next_display_element, set_iterator_to_next):
9472 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9473 (show_mouse_face): Remove decls
9474 * frame.h (message_buf_print): Likewise.
9475 * lisp.h (pop_message, set_message, check_point_in_composition):
9476 Likewise.
9477 * xterm.h (set_vertical_scroll_bar): Likewise.
9478 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9479 (message_buf_print, scratch_glyph_row, displayed_buffer):
9480 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9481 (get_next_display_element, show_mouse_face, window_box_edges):
9482 (frame_to_window_pixel_xy, check_point_in_composition):
9483 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9484 (glyph_to_pixel_coords): Remove; unused.
9485
16390cd2
PE
9486 * dired.c (file_name_completion): Now static.
9487
9488 * dbusbind.c (xd_in_read_queued_messages): Now static.
9489
a25f4dfa
PE
9490 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9491 * data.c (circular_list_error): Remove.
9492
14a9c8df
PE
9493 * commands.h (last_point_position, last_point_position_buffer):
9494 (last_point_position_window): Remove decls.
9495 * keyboard.c: Make these variables static.
9496
04f2d78b
CB
9497 * coding.h (coding, code_convert_region, encode_coding_gap):
9498 Remove decls.
74ab6df5
PE
9499 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9500 (iso_code_class, detect_coding, code_convert_region): Now static.
9501 (encode_coding_gap): Remove; unused.
9502
38dfbee1
PE
9503 * chartab.c (chartab_chars, chartab_bits): Now static.
9504
a2cb4e63
PE
9505 * charset.h (charset_iso_8859_1): Remove decl.
9506 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9507 Now static.
9508
127198fd
PE
9509 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9510 * ccl.c (Vccl_program_table): Now static.
9511 (check_ccl_update): Remove; unused.
9512
d85b608f
PE
9513 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9514 * category.h: ... from here.
9515 * category.c (check_category_table, set_category_set): Now static.
9516
31cd66f3
PE
9517 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9518 * lisp.h: Remove these decls.
9519
c358e587
PE
9520 * buffer.c (buffer_count): Remove unused var.
9521
e78aecca
PE
9522 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9523 so that it's not optimized away.
9524 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9525 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9526 exported only to the debugger.
9527
e192d7d3 9528 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 9529 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 9530
92470028
PE
9531 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9532 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9533 was inaccessible from Lisp.
9534 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9535 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9536
244ed907
PE
9537 alloc.c: Import and export fewer symbols, and remove unused items.
9538 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9539 is defined.
9540 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9541 it's not optimized away by whole-program optimization.
9542 (message_enable_multibyte, free_misc): Remove.
9543 (catchlist, handlerlist, mark_backtrace):
9544 Declare only if BYTE_MARK_STACK.
9545 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9546 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9547 (message_enable_multibyte): Remove decl.
9548 (free_misc, interval_free_list, float_block, float_block_index):
9549 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9550 (cons_free_list, last_marked_index):
9551 Now static.
9552 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9553 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9554 (mark_backtrace): Define only if BYTE_MARK_STACK.
9555 * xdisp.c (message_enable_multibyte): Now static.
9556
61c2b50e 9557 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
9558 This makes it easier for human readers (and static analyzers)
9559 to see whether these variables are used from other modules.
9560 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9561 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9562 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9563 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9564 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9565 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9566 * xmenu.c, xselect.c:
9567 Declare Q* vars static if they are not used in other modules.
9568 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9569 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9570 Remove decls of unexported vars.
9571 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9572
95c82688
PE
9573 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9574
16a97296
PE
9575 Make Emacs functions such as Fatom 'static' by default.
9576 This makes it easier for human readers (and static analyzers)
9577 to see whether these functions can be called from other modules.
9578 DEFUN now defines a static function. To make the function external
9579 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
9580 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9581 (Finit_image_library):
16a97296
PE
9582 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9583 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9584 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9585 Remove decls, since these functions are now static.
9586 (Funintern, Fget_internal_run_time): New decls, since these functions
9587 were already external.
95c82688 9588
16a97296
PE
9589 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9590 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9591 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9592 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9593 * keyboard.c, keymap.c, lread.c:
9594 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9595 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9596 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9597 Mark functions with DEFUE instead of DEFUN,
9598 if they are used in other modules.
9599 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9600 decls for now-static functions.
9601 * buffer.h (Fdelete_overlay): Remove decl.
9602 * callproc.c (Fgetenv_internal): Mark as internal.
9603 * composite.c (Fremove_list_of_text_properties): Remove decl.
9604 (Fcomposition_get_gstring): New forward static decl.
9605 * composite.h (Fcomposite_get_gstring): Remove decl.
9606 * dired.c (Ffile_attributes): New forward static decl.
9607 * doc.c (Fdocumntation_property): New forward static decl.
9608 * eval.c (Ffetch_bytecode): New forward static decl.
9609 (Funintern): Remove extern decl; now in .h file where it belongs.
9610 * fileio.c (Fmake_symbolic_link): New forward static decl.
9611 * image.c (Finit_image_library): New forward static decl.
9612 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9613 * intervals.h (Fprevious_property_change):
9614 (Fremove_list_of_text_properties): Remove decls.
9615 * keyboard.c (Fthis_command_keys): Remove decl.
9616 (Fcommand_execute): New forward static decl.
9617 * keymap.c (Flookup_key): New forward static decl.
9618 (Fcopy_keymap): Now static.
9619 * keymap.h (Flookup_key): Remove decl.
9620 * process.c (Fget_process): New forward static decl.
9621 (Fprocess_datagram_address): Mark as internal.
9622 * syntax.c (Fsyntax_table_p): New forward static decl.
9623 (skip_chars): Remove duplicate decl.
9624 * textprop.c (Fprevious_property_change): New forward static decl.
9625 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9626 Now internal.
9627 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9628 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9629
785bbd42
PE
9630 * editfns.c (Fformat): Remove unreachable code.
9631
8b913b57
AS
96322011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9633
9634 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9635 change. (Bug#8496)
9636
a6744a35
EZ
96372011-04-13 Eli Zaretskii <eliz@gnu.org>
9638
9639 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9640 when at ZV. (Bug#8487)
9641
e7974947
AS
96422011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9643
baad03f0
AS
9644 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9645 (Bug#8437)
9646 * keyboard.c (parse_tool_bar_item): Likewise.
9647 * sound.c (sound_cleanup, alsa_close): Likewise.
9648 * termcap.c (tgetent): Likewise.
9649 * xfns.c (x_default_font_parameter): Likewise.
9650 * xsettings.c (read_and_apply_settings): Likewise.
9651
e7974947
AS
9652 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9653 (overrun_check_free): Protoize.
9654
28272684
PE
96552011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9656
9657 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9658 since callers should never pass a negative size.
9659 Change the signature to match that of plain 'read' and 'write'; see
9660 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9661 * lisp.h: Update prototypes of emacs_write and emacs_read.
9662
11997c76
EZ
96632011-04-11 Eli Zaretskii <eliz@gnu.org>
9664
9665 * xdisp.c (redisplay_window): Don't try to determine the character
9666 position of the scroll margin if the window start point w->startp
e896f03c 9667 is outside the buffer's accessible region. (Bug#8468)
11997c76 9668
8a2cbd72
EZ
96692011-04-10 Eli Zaretskii <eliz@gnu.org>
9670
9671 Fix write-region and its subroutines for buffers > 2GB.
9672 * fileio.c (a_write, e_write): Modify declaration of arguments and
9673 local variables to support buffers larger than 2GB.
9674 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9675
9676 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9677 argument, local variables, and return value.
9678
9679 * lisp.h: Update prototypes of emacs_write and emacs_read.
9680
9681 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9682
4073e537 96832011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 9684
1ebfdcb6
PE
9685 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9686
b2ded58d
PE
9687 Fix more problems found by GCC 4.6.0's static checks.
9688
7d66342c
PE
9689 * xdisp.c (vmessage): Use a better test for character truncation.
9690
bbf47d44
PE
9691 * charset.c (load_charset_map): <, not <=, for optimization,
9692 and to avoid potential problems with integer overflow.
9248994d 9693 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 9694 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 9695 * editfns.c (Fformat): Likewise.
1e69125e 9696 * syntax.c (skip_chars): Likewise.
3befa583 9697
e3019616
PE
9698 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9699 This also lets GCC 4.6.0 generate slightly better loop code.
9700
becfa255
PE
9701 * callint.c (Fcall_interactively): <, not <=, for optimization.
9702 (Fcall_interactively): Count the number of arguments produced,
9703 not the number of arguments given. This is simpler and lets GCC
9704 4.6.0 generate slightly better code.
9705
dae0cd48
PE
9706 * ftfont.c: Distingish more carefully between FcChar8 and char.
9707 The previous code passed unsigned char * to a functions like
9708 strlen and xstrcasecmp that expect char *, which does not
9709 conform to the C standard.
9710 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9711 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9712 char * when the C standard requires it.
9713
76032d70
PE
9714 * keyboard.c (read_char): Remove unused var.
9715
eb3f1cc8
PE
9716 * eval.c: Port to Windows vsnprintf (Bug#8435).
9717 Include <limits.h>.
9718 (SIZE_MAX): Define if the headers do not.
9719 (verror): Do not give up if vsnprintf returns a negative count.
9720 Instead, grow the buffer. This ports to Windows vsnprintf, which
9721 does not conform to C99. Problem reported by Eli Zaretskii.
9722 Also, simplify the allocation scheme, by avoiding the need for
9723 calling realloc, and removing the ALLOCATED variable.
9724
70476b54
PE
9725 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9726
12020a9e
PE
9727 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9728 But keep the doprint source code for now, as we might revamp it
9729 and use it again (Bug#8435).
ea6c7ae6
PE
9730 * lisp.h (doprnt): Remove.
9731 * Makefile.in (base_obj): Remove doprnt.o.
9732 * deps.mk (doprnt.o): Remove.
9733
5fdb398c
PE
9734 error: Print 32- and 64-bit integers portably (Bug#8435).
9735 Without this change, on typical 64-bit hosts error ("...%d...", N)
9736 was used to print both 32- and 64-bit integers N, which relied on
9737 undefined behavior.
61bdb816 9738 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
9739 * lisp.h (error, verror): Mark as printf-like functions.
9740 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9741 Report overflow in size calculations when allocating printf buffer.
9742 Do not truncate output string at its first null byte.
9743 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
9744 Truncate the output at a character boundary, since vsnprintf does not
9745 do that.
9746 * charset.c (check_iso_charset_parameter): Convert internal
9747 character to string before calling 'error', since %c now has the
9748 printf meaning.
9749 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
9750 overflow when computing char to be passed to 'error'. Do not
9751 pass Lisp_Object to 'error'; pass the integer instead.
9752 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
9753 formatted with plain %d.
9754
b189fa66
PE
9755 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
9756
bff87ef0
PE
9757 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
9758
7e2cac20
PE
9759 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
9760
ce4d90b5
PE
9761 * xterm.c (x_catch_errors): Remove duplicate declaration.
9762
266c9547
PE
9763 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
9764
79c49ad2
PE
9765 * xdisp.c, lisp.h (message_nolog): Remove; unused.
9766
368f4090
JM
97672011-04-10 Jim Meyering <meyering@redhat.com>
9768
9769 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
9770 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
9771 return ssize_t not "int", and use size_t as the buffer length.
9772 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
9773 * gnutls.h: Update declarations.
9774 * process.c (read_process_output): Use ssize_t, to match.
9775 (send_process): Likewise.
9776
a32d4040
CY
97772011-04-09 Chong Yidong <cyd@stupidchicken.com>
9778
9779 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
9780
8546720e 97812011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 9782
04f2d78b
CB
9783 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
9784 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 9785
8546720e
GM
9786 * xterm.c (handle_one_xevent):
9787 * xmenu.c (create_and_show_popup_menu):
9788 * xselect.c (x_decline_selection_request)
9789 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 9790
0a2f5c1a 97912011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
9792
9793 Fix some uses of `int' instead of EMACS_INT.
9794 * search.c (string_match_1, fast_string_match)
9795 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
9796 (scan_buffer, find_next_newline_no_quit)
9797 (find_before_next_newline, search_command, Freplace_match)
9798 (Fmatch_data): Make some `int' variables be EMACS_INT.
9799
9800 * xdisp.c (display_count_lines): 3rd argument and return value now
9801 EMACS_INT. All callers changed.
9802 (pint2hrstr): Last argument is now EMACS_INT.
9803
9804 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
9805 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
9806 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
9807 (decode_coding_utf_16, decode_coding_emacs_mule)
9808 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
9809 (decode_coding_ccl, decode_coding_charset)
9810 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
9811 (decode_coding_iso_2022, decode_coding_emacs_mule)
9812 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
9813 <char_offset, last_offset>: Declare EMACS_INT.
9814 (encode_coding_utf_8, encode_coding_utf_16)
9815 (encode_coding_emacs_mule, encode_invocation_designation)
9816 (encode_designation_at_bol, encode_coding_iso_2022)
9817 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
9818 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
9819 Declare EMACS_INT.
9820 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
9821 (encode_invocation_designation): Last argument P_NCHARS is now
9822 EMACS_INT.
9823 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
9824 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
9825
9826 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
9827 All users changed.
9828
9829 * ccl.c (Fccl_execute_on_string): Declare some variables
9830 EMACS_INT.
9831
8546720e 98322011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
9833
9834 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
9835
4e19a977
CS
98362011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
9837
9838 * process.c (Fformat_network_address): Doc fix.
9839
87302331
R
98402011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
9841
ee7683eb 9842 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 9843
cbb59342
CY
98442011-04-08 Chong Yidong <cyd@stupidchicken.com>
9845
9846 * keyboard.c (read_char): Call Lisp function help-form-show,
9847 instead of using internal_with_output_to_temp_buffer.
9848 (Qhelp_form_show): New var.
e0d38eeb 9849 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
9850
9851 * print.c (internal_with_output_to_temp_buffer): Function deleted.
9852
9853 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
9854
e67a13ab
CY
98552011-04-06 Chong Yidong <cyd@stupidchicken.com>
9856
04f2d78b
CB
9857 * process.c (Flist_processes): Remove to Lisp.
9858 (list_processes_1): Delete.
e67a13ab 9859
973f782d
EZ
98602011-04-06 Eli Zaretskii <eliz@gnu.org>
9861
7c106b1e
EZ
9862 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
9863
973f782d
EZ
9864 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
9865
41cf7d1a 98662011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 9867
ca23cc88
PE
9868 Fix more problems found by GCC 4.6.0's static checks.
9869
f390e2d5
PE
9870 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
9871
42eea0d0
PE
9872 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
9873
b69769da 9874 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 9875
f9541e84
PE
9876 * xdisp.c (vmessage): Mark as a printf-like function.
9877
13841b55
PE
9878 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
9879
c136c10f
PE
9880 * sound.c (sound_warning): Don't crash if arg contains a printf format.
9881
5e2d4a30
PE
9882 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
9883 printf-like functions.
9884 (tiff_load): Add casts to remove these marks before passing them
9885 to system-supplied API.
9886
583f48b9
PE
9887 * eval.c (Fsignal): Remove excess argument to 'fatal'.
9888
b25d760e
PE
9889 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
9890 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
9891 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
9892 directly, rather than having caller test rule sign. This avoids
9893 some unnecessary tests.
9894 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
9895 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
9896 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 9897
bc7b6697 9898 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 9899 (xfont_open): Avoid unnecessary tests.
bc7b6697 9900
27ccc379
PE
9901 * composite.c (composition_gstring_put_cache): Use unsigned integer.
9902
dcd5c89a
PE
9903 * composite.h, composite.c (composition_gstring_put_cache):
9904 Use EMACS_INT, not int, for length.
9905
b13a45c6
PE
9906 * composite.h (COMPOSITION_DECODE_REFS): New macro,
9907 breaking out part of COMPOSITION_DECODE_RULE.
9908 (COMPOSITION_DECODE_RULE): Use it.
9909 * composite.c (get_composition_id): Remove unused local vars,
9910 by using the new macro.
9911
1e792e4d
PE
9912 * textprop.c (set_text_properties_1): Change while to do-while,
9913 since the condition is always true at first.
9914
dc6c6455 9915 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
9916 (interval_deletion_adjustment): Return unsigned value.
9917 All uses changed.
dc6c6455 9918
aba7731a
PE
9919 * process.c (list_processes_1, create_pty, read_process_output):
9920 (exec_sentinel): Remove vars that were set but not used.
afd4052b 9921 (create_pty): Remove unnecessary "volatile"s.
bc57d757 9922 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 9923 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 9924 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 9925
fdfc4bf3
PE
9926 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
9927
fca8fe46 9928 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 9929 (update_syntax_table): Use unsigned instead of int.
fca8fe46 9930
06a0259a 9931 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 9932 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 9933 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 9934
e7b9e80f
PE
9935 * print.c (print_error_message): Avoid int overflow.
9936
56201685
PE
9937 * font.c (font_list_entities): Redo for clarity,
9938 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
9939
78834453 9940 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 9941 (font_score): Avoid potential overflow in diff calculation.
78834453 9942
0bc0b309 9943 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 9944 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 9945
e610eaca
PE
9946 * eval.c (funcall_lambda): Rename local to avoid shadowing.
9947
b895abce
PE
9948 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
9949 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
9950 can always succeed if overflow has undefined behavior.
9951
1f1d9321 9952 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 9953 (wordify): Omit three unnecessary tests.
1f1d9321 9954
c59478bc
PE
9955 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
9956 All callers changed. This avoids the need for an unused var.
9957
79b73827
PE
9958 * casefiddle.c (casify_region): Remove var that is set but not used.
9959
a4db5dfe
PE
9960 * dired.c (file_name_completion): Remove var that is set but not used.
9961
43aae36e
PE
9962 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
9963
2a47c44d 9964 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 9965 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 9966
a37c69bf
PE
9967 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
9968 Check for integer overflow on size calculations.
9969
328ab8e7
PE
9970 * buffer.c (Fprevious_overlay_change): Remove var that is set
9971 but not used.
9972
e5a2a5cb
PE
9973 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
9974 Remove vars that are set but not used.
8d84a6eb 9975 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 9976 (timer_check_2): Mark vars as initialized.
e5a2a5cb 9977
a60e5f68
PE
9978 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
9979
f661cb61 9980 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 9981 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 9982
f0397f5a
PE
9983 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
9984 that are set but not used.
9985
8664db06 9986 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 9987 if XCreateBitmapFromData fails (Bug#8410).
8664db06 9988
6abdaa4a
PE
9989 * xselect.c (x_get_local_selection, x_handle_property_notify):
9990 Remove vars that are set but not used.
9991
0ce7538d 9992 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 9993 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 9994
9ae848fc
PE
9995 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
9996 Remove var that is set but not used.
0b918413
PE
9997 (scroll_bar_windows_size): Now size_t, not int.
9998 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
9999 Check for overflow.
9ae848fc 10000
a5a62657
PE
10001 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10002 (map_tty_color) [!defined MSDOS]: Likewise.
10003
5c5cdd39
PE
10004 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10005
66ebf983
PE
10006 * coding.c: Remove vars that are set but not used.
10007 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10008 All callers changed.
10009 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10010 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10011 (decode_coding_charset): Remove vars that are set but not used.
10012
1be4d761
PE
10013 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10014 that is set but not used.
10015
47553fa8
PE
10016 * print.c (print_object): Remove var that is set but not used.
10017
1f7196bf 10018 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10019 The gnulib version avoids calling malloc in the usual case,
10020 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10021 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10022 * filelock.c (current_lock_owner): Likewise.
10023 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10024 * sysdep.c: Include allocator.h, careadlinkat.h.
10025 (emacs_no_realloc_allocator): New static constant.
10026 (emacs_readlink): New function.
fdb61804
PE
10027 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10028 ../lib/careadlinkat.h.
d1fdcab7 10029
f84c17c7
SM
100302011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10031
10032 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10033 first non-nil return value).
10034
ef3862ad
JD
100352011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10036
10037 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10038 if not defined (Bug#8403).
10039
376a7006
JB
100402011-04-02 Juanma Barranquero <lekktu@gmail.com>
10041
10042 * xdisp.c (display_count_lines): Remove parameter `start',
10043 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10044 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10045 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10046 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10047 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10048 and thereabouts. All callers changed.
10049 (get_per_char_metric): Remove parameter `f', unused since
10050 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10051
6ca3801d
JM
100522011-04-02 Jim Meyering <meyering@redhat.com>
10053
10054 do not dereference NULL upon failed strdup
10055 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10056 (ns_get_family): Likewise.
10057
d8e2b5ba
JB
100582011-04-02 Juanma Barranquero <lekktu@gmail.com>
10059
10060 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10061
8c74fcbd
JD
100622011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10063
10064 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10065 later (Bug#8403).
10066
7200d79c
SM
100672011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10068
03408648 10069 Add lexical binding.
7200d79c 10070
03408648
SM
10071 * window.c (Ftemp_output_buffer_show): New fun.
10072 (Fsave_window_excursion):
10073 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10074
10075 * lread.c (lisp_file_lexically_bound_p): New function.
10076 (Fload): Bind Qlexical_binding.
10077 (readevalloop): Remove `evalfun' arg.
10078 Bind Qinternal_interpreter_environment.
10079 (Feval_buffer): Bind Qlexical_binding.
10080 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10081 Mark as dynamic.
10082 (syms_of_lread): Declare `lexical-binding'.
10083
10084 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10085
10086 * keyboard.c (eval_dyn): New fun.
10087 (menu_item_eval_property): Use it.
ca105506
SM
10088
10089 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10090
03408648
SM
10091 * fns.c (concat, mapcar1): Accept byte-code-functions.
10092
10093 * eval.c (Fsetq): Handle lexical vars.
10094 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10095 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10096 (FletX, Flet): Obey lexical binding.
10097 (Fcommandp): Handle closures.
10098 (Feval): New `lexical' arg.
10099 (eval_sub): New function extracted from Feval. Use it almost
10100 everywhere where Feval was used. Look up vars in lexical env.
10101 Handle closures.
10102 (Ffunctionp): Move from subr.el.
10103 (Ffuncall): Handle closures.
10104 (apply_lambda): Remove `eval_flags'.
10105 (funcall_lambda): Handle closures and new byte-code-functions.
10106 (Fspecial_variable_p): New function.
10107 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10108 but without exporting it to Lisp.
23aba0ea 10109
23aba0ea 10110 * doc.c (Fdocumentation, store_function_docstring):
03408648 10111 * data.c (Finteractive_form): Handle closures.
23aba0ea 10112
03408648
SM
10113 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10114 interactive spec.
ba83908c 10115
04f2d78b
CB
10116 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10117 New byte-codes.
03408648
SM
10118 (exec_byte_code): New function extracted from Fbyte_code to handle new
10119 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10120
03408648 10121 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10122
03408648 10123 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10124
e2abce01
JB
101252011-03-31 Juanma Barranquero <lekktu@gmail.com>
10126
10127 * xdisp.c (redisplay_internal): Fix prototype.
10128
63696a73 101292011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10130
63696a73 10131 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10132 (try_scrolling): Use it when setting scroll_limit.
10133 Limit scrolling to 100 screen lines.
63696a73
EZ
10134 (redisplay_window): Even when falling back on "recentering",
10135 position point in the window according to scroll-conservatively,
10136 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10137
10138 (try_scrolling): When point is above the window, allow searching
10139 as far as scroll_max, or one screenful, to compute vertical
10140 distance from PT to the scroll margin position. This prevents
10141 try_scrolling from unnecessarily failing when
10142 scroll-conservatively is set to a value slightly larger than the
10143 window height. Clean up the case of PT below the margin at bottom
10144 of window: scroll_max can no longer be INT_MAX. When aggressive
10145 scrolling is in use, don't let point enter the opposite scroll
10146 margin as result of the scroll.
10147 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10148 threshold of 100 lines for never-recentering scrolling.
10149
e4cc2dfc
JB
101502011-03-31 Juanma Barranquero <lekktu@gmail.com>
10151
10152 * dispextern.h (move_it_by_lines):
10153 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10154 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10155 (message_log_check_duplicate): Remove parameters `prev_bol' and
10156 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10157 (redisplay_internal): Remove parameter `preserve_echo_area',
10158 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10159
10160 * indent.c (Fvertical_motion):
10161 * window.c (window_scroll_pixel_based, Frecenter):
10162 Don't pass `need_y_p' to `move_it_by_lines'.
10163
1c470562
SM
101642011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10165
44f230aa
SM
10166 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10167 steal a few bits to be more compact.
10168 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10169 Remove unneeded casts.
10170
1c470562
SM
10171 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10172
888adce9
ZK
101732011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10174
10175 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10176 binding" message (bug#7967).
10177
f838ed7b
PE
101782011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10179
77861b95
PE
10180 Fix more problems found by GCC 4.6.0's static checks.
10181
de6dbc14
PE
10182 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10183 Remove unused local var.
10184
f838ed7b
PE
10185 * editfns.c (Fmessage_box): Remove unused local var.
10186
792c7b2b
PE
10187 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10188 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10189 Omit unused local vars.
c499e557 10190 * window.c (shrink_windows): Omit unused local var.
b01a1c29 10191 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
10192 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10193 Omit unused local var.
10194
ba0165e1
PE
10195 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10196 Don't assume string length fits in int.
32ad8845 10197 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 10198 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 10199
3c59b4c9
PE
10200 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10201 instead of alloca (Bug#8344).
10202
a3eed478 10203 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 10204 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 10205
eb4d412d
PE
10206 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10207
1658b401
PE
10208 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10209 concerns.
10210
10211 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10212
10213 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 10214
9a2c6e05
PE
10215 * keyboard.c (syms_of_keyboard): Use the same style as later
10216 in this function when indexing through an array. This also
10217 works around GCC bug 48267.
10218
03d0a109
PE
10219 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10220
44f730c8
PE
10221 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10222
fe75f926
PE
10223 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10224 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10225
ffa8c828
PE
10226 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10227 This avoids undefined behavior on integer overflow, and is a bit
10228 more convenient anyway since it is compared to a size_t variable.
10229
c5101a77
PE
10230 Variadic C functions now count arguments with size_t, not int.
10231 This avoids an unnecessary limitation on 64-bit machines, which
10232 caused (substring ...) to crash on large vectors (Bug#8344).
10233 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10234 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 10235 All variadic functions and their callers changed accordingly.
c5101a77
PE
10236 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10237 * data.c (arith_driver, float_arith_driver): Likewise.
10238 * editfns.c (general_insert_function): Likewise.
10239 * eval.c (struct backtrace.nargs, interactive_p)
10240 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10241 (funcall_lambda, mark_backtrace): Likewise.
10242 * fns.c (concat): Likewise.
10243 * frame.c (x_set_frame_parameters): Likewise.
10244 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10245 0 if not found, not -1. All callers changed.
10246
dd3f25f7
PE
10247 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10248 (stack_copy_size): Now size_t, not int.
10249 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10250
461c2ab9
JB
102512011-03-28 Juanma Barranquero <lekktu@gmail.com>
10252
10253 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10254 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10255 All callers changed.
10256
10257 * lisp.h (multibyte_char_to_unibyte):
10258 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10259 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10260 * character.h (CHAR_TO_BYTE8):
10261 * cmds.c (internal_self_insert):
10262 * editfns.c (general_insert_function):
10263 * keymap.c (push_key_description):
10264 * search.c (Freplace_match):
10265 * xdisp.c (message_dolog, set_message_1): All callers changed.
10266
f6d62986
SM
102672011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10268
10269 * keyboard.c (safe_run_hook_funcall): New function.
10270 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10271 don't set the hook to nil, but remove the offending function instead.
10272 (Qcommand_hook_internal): Remove, unused.
10273 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10274 Vcommand_hook_internal.
10275
10276 * eval.c (enum run_hooks_condition): Remove.
10277 (funcall_nil, funcall_not): New functions.
10278 (run_hook_with_args): Call each function through a `funcall' argument.
10279 Remove `cond' argument, now redundant.
10280 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10281 (Frun_hook_with_args_until_failure): Adjust accordingly.
10282 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10283
1db5b1ad
JB
102842011-03-28 Juanma Barranquero <lekktu@gmail.com>
10285
10286 * dispextern.h (string_buffer_position): Remove declaration.
10287
10288 * print.c (strout): Remove parameter `multibyte', unused since
10289 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10290
10291 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10292 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10293 All callers changed.
10294
10295 * w32.c (_wsa_errlist): Use braces for struct initializers.
10296
10297 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10298 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10299 All callers changed.
10300 (string_buffer_position): Likewise. Also, make static (it's never
10301 used outside xdisp.c).
10302 (cursor_row_p): Remove parameter `w', unused since
10303 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10304 (decode_mode_spec): Remove parameter `precision', introduced during
10305 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10306 All callers changed.
10307
5ffb62aa
JD
103082011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10309
10310 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10311
461c2ab9 103122011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
10313
10314 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10315 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10316 (ns_update_auto_hide_menu_bar): New functions.
10317 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10318 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10319 ns_constrain_all_frames.
10320 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10321 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10322
5c380ffb
JD
103232011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10324
10325 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10326
9af30bdf
GM
103272011-03-27 Glenn Morris <rgm@gnu.org>
10328
10329 * syssignal.h: Replace RETSIGTYPE with void.
10330 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10331 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10332 Replace SIGTYPE with void everywhere.
10333 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10334 * s/template.h (SIGTYPE): Remove commented out definition.
10335
e2abce01
JB
103362011-03-26 Eli Zaretskii <eliz@gnu.org>
10337
10338 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10339 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10340
f868cd8a
JB
103412011-03-26 Juanma Barranquero <lekktu@gmail.com>
10342
59eb0929
JB
10343 * w32.c (read_unc_volume): Use parameter `henum', instead of
10344 global variable `wget_enum_handle'.
10345
10346 * keymap.c (describe_vector): Remove parameters `indices' and
10347 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10348 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10349
f868cd8a
JB
10350 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10351
10352 * keyboard.c (timer_check): Remove parameter `do_it_now',
10353 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10354 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10355 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10356
10357 * keyboard.c (read_char):
10358 * w32menu.c (w32_menu_display_help):
10359 * xmenu.c (show_help_event, menu_help_callback):
10360 Adjust calls to `show_help_echo'.
10361
10362 * gtkutil.c (xg_maybe_add_timer):
10363 * keyboard.c (readable_events):
10364 * process.c (wait_reading_process_output):
10365 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10366
10367 * insdel.c (adjust_markers_gap_motion):
10368 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10369 (gap_left, gap_right): Don't call it.
10370
2ecf6fdb
CY
103712011-03-25 Chong Yidong <cyd@stupidchicken.com>
10372
10373 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10374 incurred during fontification.
10375
6b1f9ba4
JB
103762011-03-25 Juanma Barranquero <lekktu@gmail.com>
10377
10378 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10379 (DEFVAR_PER_BUFFER): Don't pass it.
10380
10381 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10382 (scrolling_window): Don't pass it.
10383
0f4a96b5
JB
103842011-03-25 Juanma Barranquero <lekktu@gmail.com>
10385
10386 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10387
10388 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10389 and `suffix'.
10390 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10391 of variables specific to SELinux and computation of `encoded_absname'.
10392
10393 * image.c (XPutPixel): Remove unused variable `height'.
10394
10395 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10396
10397 * unexw32.c (get_section_info): Remove unused variable `section'.
10398
10399 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10400 (system_process_attributes): Remove unused variable `sess'.
10401 (sys_read): Remove unused variable `err'.
10402
10403 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10404 (w32_wnd_proc): Remove unused variable `isdead'.
10405 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10406 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10407 (x_create_tip_frame): Remove unused variable `tem'.
10408
10409 * w32inevt.c (w32_console_read_socket):
10410 Remove unused variable `no_events'.
10411
10412 * w32term.c (x_draw_composite_glyph_string_foreground):
10413 Remove unused variable `width'.
10414
1149507c
JB
104152011-03-24 Juanma Barranquero <lekktu@gmail.com>
10416
10417 * w32term.c (x_set_glyph_string_clipping):
10418 Don't pass uninitialized region to CombineRgn.
10419
9c88f339
JB
104202011-03-23 Juanma Barranquero <lekktu@gmail.com>
10421
10422 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10423 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10424 (Fx_close_connection): Remove unused variable `i'.
10425
10426 * w32font.c (w32font_draw): Return number of glyphs.
10427 (w32font_open_internal): Remove unused variable `i'.
10428 (w32font_driver): Add missing initializer.
10429
10430 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10431 (fill_in_menu): Remove unused variable `items_added'.
10432
10433 * w32term.c (last_mouse_press_frame): Remove static global variable.
10434 (w32_clip_to_row): Remove unused variable `f'.
10435 (x_delete_terminal): Remove unused variable `i'.
10436
10437 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10438 (NOTHING): Remove unused static global variable.
10439 (uniscribe_check_otf): Remove unused variable `table'.
10440 (uniscribe_font_driver): Add missing initializers.
10441
dee091a3
JD
104422011-03-23 Julien Danjou <julien@danjou.info>
10443
10444 * term.c (Fsuspend_tty, Fresume_tty):
10445 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10446 * window.c (temp_output_buffer_show):
10447 * insdel.c (signal_before_change):
10448 * frame.c (Fhandle_switch_frame):
10449 * fileio.c (Fdo_auto_save):
10450 * emacs.c (Fkill_emacs):
10451 * editfns.c (save_excursion_restore):
10452 * cmds.c (internal_self_insert):
10453 * callint.c (Fcall_interactively):
10454 * buffer.c (Fkill_all_local_variables):
10455 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10456 Use Frun_hooks.
0f4a96b5 10457 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 10458 unconditionally since it does the check itself.
dee091a3 10459
2c520ab5 104602011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 10461
c9c49752
PE
10462 Fix more problems found by GCC 4.5.2's static checks.
10463
8abc3f12
PE
10464 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10465 the first time through the loop, since we know p0 < p1 then.
10466 This also avoids a gcc -Wstrict-overflow warning.
10467
a2d26660
PE
10468 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10469 leading to a memory leak, possible in functions like
10470 load_charset_map_from_file that can allocate an unbounded number
b12ef411 10471 of objects (Bug#8318).
a2d26660 10472
916c72e9
PE
10473 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10474 that could (at least in theory) be that large.
10475
19ab8a18
PE
10476 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10477 This is less likely to overflow, and avoids undefined behavior if
10478 overflow does occur. All callers changed. Use strtoul to scan
10479 for the unsigned long integer.
b7cbbd6f
PE
10480 (pint2hrstr): Simplify and tune code slightly.
10481 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 10482
f0641eff
PE
10483 * scroll.c (do_scrolling): Work around GCC bug 48228.
10484 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10485
7f650bb9
PE
10486 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10487 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
10488 (validate_x_resource_name): Simplify count usage.
10489 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 10490
37dd57d1
PE
10491 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10492 fail (Bug#8306).
81e56e61 10493
699979fc 10494 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 10495
401bf9b4
PE
10496 * process.c (Fmake_network_process): Use socklen_t, not int,
10497 where POSIX says socklen_t is required in portable programs.
10498 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 10499 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
10500 (Fmake_network_process, server_accept_connection):
10501 (wait_reading_process_output, read_process_output):
10502 Likewise.
10503
b93aacde
PE
10504 * process.c: Rename or move locals to avoid shadowing.
10505 (list_processes_1, Fmake_network_process):
10506 (read_process_output_error_handler, exec_sentinel_error_handler):
10507 Rename or move locals.
4dc343ee 10508 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 10509 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 10510 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 10511 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 10512 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 10513
af8a867c 10514 Make tparam.h and terminfo.c consistent.
44f230aa
SM
10515 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10516 Include tparam.h instead, since it declares them.
af8a867c
PE
10517 * cm.h (PC): Remove extern decl; tparam.h now does this.
10518 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10519 * terminfo.c: Include tparam.h, to check interfaces.
10520 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10521 (tparam): Adjust signature to match interface in tparam.h;
10522 this removes some undefined behavior. Check that outstring and len
10523 are zero, which they always are with Emacs.
10524 * tparam.h (PC, BC, UP): New extern decls.
10525
0248044d 10526 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 10527 (xftfont_open): Rename locals to avoid shadowing.
0248044d 10528
8ff096c1 10529 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
10530 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10531 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 10532 (ftfont_list): Remove unused local.
49eaafba
PE
10533 (get_adstyle_property, ftfont_pattern_entity):
10534 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10535 Rename locals to avoid shadowing.
8ff096c1 10536
e2be39f6
PE
10537 * xfont.c (xfont_list_family): Mark var as initialized.
10538
c9735e30
PE
10539 * xml.c (make_dom): Now static.
10540
8f5201ae
PE
10541 * composite.c (composition_compute_stop_pos): Rename local to
10542 avoid shadowing.
b246f932
PE
10543 (composition_reseat_it): Remove unused locals.
10544 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 10545 (composition_update_it): Mark var as initialized.
11b61122
PE
10546 (find_automatic_composition): Mark vars as initialized,
10547 with a FIXME (Bug#8290).
8f5201ae 10548
760fbc2c
PE
10549 character.h: Rename locals to avoid shadowing.
10550 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10551 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10552 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10553 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10554 to avoid shadowing.
10555
ff08eb85
PE
10556 * textprop.c (property_change_between_p): Remove; unused.
10557
fc7bf025
PE
10558 * intervals.c (interval_start_pos): Now static.
10559
235d7abc
PE
10560 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10561
44f230aa
SM
10562 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10563 Rename locals to avoid shadowing.
3e7d6594 10564
50060332
PE
10565 * sound.c (wav_play, au_play, Fplay_sound_internal):
10566 Fix pointer signedness.
d01f234b 10567 (alsa_choose_format): Remove unused local var.
c83b8872
PE
10568 (wav_play): Initialize a variable to 0, to prevent undefined
10569 behavior (Bug#8278).
50060332 10570
c4fc4e30
PE
10571 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10572
918436ed
PE
10573 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10574
c939f91b
PE
10575 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10576 clobbering (Bug#8298).
b9c7f648
PE
10577 * sysdep.c (sys_subshell): Likewise.
10578 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 10579
6bd8c144
PE
10580 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10581 This should get cleaned up, so that child_setup has the
10582 same signature on all platforms.
10583
7710357c 10584 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 10585 (relocate_fd): Rename locals to avoid shadowing.
7710357c 10586
c59da222
CY
105872011-03-22 Chong Yidong <cyd@stupidchicken.com>
10588
10589 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10590 not to be necessary, and produces flickering.
10591
66b87493
GM
105922011-03-20 Glenn Morris <rgm@gnu.org>
10593
10594 * config.in: Remove file.
10595
45b6f6d5
JB
105962011-03-20 Juanma Barranquero <lekktu@gmail.com>
10597
10598 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10599 are now in src/globals.h.
10600 (syms_of_minibuf): Remove spurious & from previous change.
10601
cd394be1 106022011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
10603
10604 * minibuf.c (completing-read-function): New variable.
10605 (completing-read-default): Rename from completing-read.
10606 (completing-read): Call completing-read-function.
10607
b14e3e21
CY
106082011-03-19 Juanma Barranquero <lekktu@gmail.com>
10609
10610 * xfaces.c (Fx_load_color_file):
10611 Read color file from absolute filename (bug#8250).
10612
f2b726e6
JB
106132011-03-19 Juanma Barranquero <lekktu@gmail.com>
10614
10615 * makefile.w32-in: Update dependencies.
10616
09f6ff02
EZ
106172011-03-17 Eli Zaretskii <eliz@gnu.org>
10618
10619 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10620
29a6015a
PE
106212011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10622
a3a6c54e
PE
10623 Fix more problems found by GCC 4.5.2's static checks.
10624
b766f867
PE
10625 * process.c (make_serial_process_unwind, send_process_trap):
10626 (sigchld_handler): Now static.
10627
be02381c
PE
10628 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10629 That way, the code declares only the vars that it needs.
10630 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10631 * s/cygwin.h (PTY_ITERATION): Likewise.
10632 * s/darwin.h (PTY_ITERATION): Likewise.
10633 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10634
57048744
PE
10635 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10636 * process.c (allocate_pty): Don't declare stb unless it's needed.
10637
7914961c 10638 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
10639 (CONSTANTLIM): Remove; unused.
10640 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10641 Define only if needed.
7914961c 10642
b3967b18
PE
10643 * unexelf.c (unexec): Name an expression,
10644 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
10645 Use a different way to cause a compilation error if anyone uses
10646 n rather than nn, a way that does not involve shadowing.
73366a00 10647 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 10648
29a6015a
PE
10649 * deps.mk (unexalpha.o): Remove; unused.
10650
43cfc33e 10651 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 10652 * unexec.h: New file.
ce701a33
PE
10653 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10654 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10655 Depend on unexec.h.
10656 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10657 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10658 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 10659 Change as necessary to match prototype in unexec.h.
ce701a33 10660
01f44d5a
PE
10661 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10662 shadowing.
4f63c6bb 10663 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 10664
a6670b0b
PE
10665 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10666 Rename locals to avoid shadowing.
10667
cef2010d 10668 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 10669 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 10670
d4d7173a
PE
10671 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10672
f08b802a
PE
10673 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10674 warning when compiling print.c.
10675
3ddb0639
PE
10676 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10677 instead of using an uninitialized var.
5ad03b97 10678 (font_sort_entities): Mark var as initialized.
3ddb0639 10679
170a2692
PE
10680 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10681
e663c700
PE
10682 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10683 pointers to constants.
89bc529a 10684 (font_parse_fcname): Remove unused vars.
7b81e2d0 10685 (font_delete_unmatched): Now static.
ea838e10 10686 (font_get_spec): Remove; unused.
13a547c6
PE
10687 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10688 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10689 Rename or move locals to avoid shadowing.
e663c700 10690
2a80c887 10691 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 10692 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 10693
1384fa33 10694 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 10695 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 10696
8b2c52e9
PE
10697 * alloc.c (mark_backtrace): Move decl from here ...
10698 * lisp.h: ... to here, so that it can be checked.
10699
475545b5 10700 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 10701 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
10702 (lisp_indirect_variable): Name an expression,
10703 to avoid gcc -Wbad-function-cast warning.
1faed8ae 10704 (Fdefvar): Rename locals to avoid shadowing.
475545b5 10705
b1349114 10706 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 10707 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 10708 Use const pointer when appropriate.
b1349114 10709
a2928364
PE
10710 * lisp.h (get_system_name, get_operating_system_release):
10711 Move decls here, to check interfaces.
10712 * process.c (get_operating_system_release): Move decl to lisp.h.
10713 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
10714 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10715 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10716 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
10717 (Fformat_time_string, Fencode_time, Finsert_char):
10718 (Ftranslate_region_internal, Fformat):
10719 Rename or remove local vars to avoid shadowing.
9710023e 10720 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 10721
a415e694
PE
10722 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10723 avoid shadowing.
10724
8ef4622d
PE
10725 * lisp.h (eassert): Check that the argument compiles, even if
10726 ENABLE_CHECKING is not defined.
10727
946f9a5b
PE
10728 * data.c (Findirect_variable): Name an expression, to avoid
10729 gcc -Wbad-function-cast warning.
112396d6 10730 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 10731 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
10732 (Fmake_variable_buffer_local, Fmake_local_variable):
10733 Mark variables as initialized.
52746918 10734 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 10735
e5aab7e7 10736 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
10737 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10738 Rename locals to avoid shadowing.
dff45157
PE
10739 (mark_stack): Move local variables into the #ifdef region where
10740 they're used.
7bc26fdb
PE
10741 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10742 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
10743 needed otherwise.
10744 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
10745 (GC_STRING_CHARS): Remove; not used.
d40d4be1 10746 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 10747
e5aab7e7
PE
10748 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
10749 avoids undefined behavior in theory.
10750
4da60324
PE
10751 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
10752
88043301
PE
10753 Use functions, not macros, for up- and down-casing (Bug#8254).
10754 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10755 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
10756 to use the following functions instead of these macros.
10757 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
10758 EMACS_INT, since callers assume the returned value fits in int.
10759 (upcase1): Likewise, for UPCASE_TABLE.
10760 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 10761 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 10762 the race-condition problem in the old DOWNCASE.
88043301 10763
19ed5445
PE
10764 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
10765 Rename locals to avoid shadowing.
10766 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
10767 (regex_compile, re_search_2, re_match_2_internal):
10768 Remove unused local vars.
952db0d7
PE
10769 (FREE_VAR): Rewrite so as not to use empty "else",
10770 which gcc can warn about.
da053e48 10771 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
10772 (RETALLOC_IF): Define only if needed.
10773 (WORDCHAR_P): Likewise. This one is never needed, but is used
10774 only in a comment talking about a compiler bug, so put inside
10775 the #if 0 of that comment.
10776 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
10777 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
10778 Remove; unused.
19ed5445 10779
1f3561e4 10780 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
10781 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
10782 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 10783
ded6f8f7
PE
10784 * search.c (simple_search): Remove unused var.
10785
dbd37a95
PE
10786 * dired.c (compile_pattern): Move decl from here ...
10787 * lisp.h: ... to here, so that it can be checked.
10788 (struct re_registers): New forward decl.
10789
7e47afad
PE
10790 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
10791
85f24f61
PE
10792 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
10793 All uses changed.
10794 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
10795 Rename locals to avoid shadowing.
5671df8f 10796 (Fvertical_motion): Mark locals as initialized.
85f24f61 10797
181aa2be 10798 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 10799 (casify_region): Mark local as initialized.
181aa2be 10800
930d429c
PE
10801 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
10802
7082eac6
PE
10803 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
10804 New macros, so that the caller can use some names other than
10805 gcpro1, gcpro2, etc.
10806 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
10807 of the new macros.
10808 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
10809 argument, for consistency with GCPRO2_VAR, etc: it is now the
10810 prefix of the variable, not the variable itself. All uses
10811 changed.
38b2c076
PE
10812 * dired.c (directory_files_internal, file_name_completion):
10813 Rename locals to avoid shadowing.
10814
15206ed9
PE
10815 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
10816 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
10817 dired.c's scmp function, had undefined behavior.
10818 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10819 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
10820 * buffer.h: ... to here, because these macros use current_buffer,
10821 and the new implementation with inline functions needs to have
10822 current_buffer in scope now, rather than later when the macros
10823 are used.
10824 (downcase, upcase1): New static inline functions.
10825 (DOWNCASE, UPCASE1): Reimplement using these functions.
10826 This avoids undefined behavior in expressions like
10827 DOWNCASE (x) == DOWNCASE (y), which previously suffered
10828 from race conditions in accessing the global variables
10829 case_temp1 and case_temp2.
10830 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
10831 * lisp.h (case_temp1, case_temp2): Remove their decls.
10832 * character.h (ASCII_CHAR_P): Move from here ...
10833 * lisp.h: ... to here, so that the inline functions mentioned
10834 above can use them.
10835
4a6bea26
PE
10836 * dired.c (directory_files_internal_unwind): Now static.
10837
f14b7e14
PE
10838 * fileio.c (file_name_as_directory, directory_file_name):
10839 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
10840 Now static.
2893f146
PE
10841 (file_name_as_directory): Use const pointers when appropriate.
10842 (Fexpand_file_name): Likewise. In particular, newdir might
10843 point at constant storage, so make it a const pointer.
fd4ead52 10844 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
10845 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
10846 signedness issues.
f839df0c
PE
10847 (Fset_file_times, Finsert_file_contents, auto_save_error):
10848 Rename locals to avoid shadowing.
f14b7e14 10849
5716756e 10850 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
10851 (Ftry_completion, Fall_completions): Rename or remove locals
10852 to avoid shadowing.
5716756e 10853
b4c3046a
PE
10854 * marker.c (bytepos_to_charpos): Remove; unused.
10855
b45db522
PE
10856 * lisp.h (verify_bytepos, count_markers): New decls,
10857 so that gcc does not warn that these functions aren't declared.
10858
85876d07
PE
10859 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
10860 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 10861 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 10862 (copy_text): Remove unused local var.
85876d07 10863
03d78a21 10864 * filelock.c (within_one_second): Now static.
b3dd38ab 10865 (lock_file_1): Rename local to avoid shadowing.
03d78a21 10866
5df8f01b
PE
10867 * buffer.c (fix_overlays_before): Mark locals as initialized.
10868 (fix_start_end_in_overlays): Likewise. This function should be
10869 simplified by using pointers-to-pointers, but that's a different
10870 matter.
b1d876f1 10871 (switch_to_buffer_1): Now static.
8f54f30a
PE
10872 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
10873 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 10874
a70072c9 10875 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 10876 Fix pointer signedness issue.
edced198
PE
10877 (sys_subshell): Mark local as volatile if checking for lint,
10878 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 10879 (MAXPATHLEN): Define only if needed.
a70072c9 10880
a0977c44
PE
10881 * process.c (serial_open, serial_configure): Move decls from here ...
10882 * systty.h: ... to here, so that they can be checked.
10883
a884fdcc
PE
10884 * fns.c (get_random, seed_random): Move extern decls from here ...
10885 * lisp.h: ... to here, so that they can be checked.
10886
604efe86 10887 * sysdep.c (reset_io): Now static.
b8950c94 10888 (wait_for_termination_signal): Remove; unused.
604efe86 10889
38fc62d9
PE
10890 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
10891 (copy_keymap_item, append_key, push_text_char_description):
10892 Now static.
1004a21a 10893 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 10894 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
10895 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
10896 (describe_map_tree):
10897 Rename locals to avoid shadowing.
38fc62d9 10898
2f2650da
PE
10899 * keyboard.c: Declare functions static if they are not used elsewhere.
10900 (echo_char, echo_dash, cmd_error, top_level_2):
10901 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
10902 (read_char, kbd_buffer_get_event, make_lispy_position):
10903 (make_lispy_event, make_lispy_movement, apply_modifiers):
10904 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
10905 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
10906 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 10907 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 10908 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 10909
a053e86c 10910 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
10911 (mark_kboards): Move decl here ...
10912 * alloc.c (mark_kboards): ... from here.
a053e86c 10913
4752793e
PE
10914 * lisp.h (force_auto_save_soon): New decl.
10915
74f10ca7 10916 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
10917 (DEFINE_DUMMY_FUNCTION): New macro.
10918 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
10919 Use it.
c03cd23f
PE
10920 (main): Add casts to avoid warnings
10921 if GCC considers string literals to be constants.
74f10ca7 10922
022e70d4
PE
10923 * lisp.h (fatal_error_signal): Add decl, since it's exported.
10924
59d6fe83
PE
10925 * dbusbind.c: Pointer signedness fixes.
10926 (xd_signature, xd_append_arg, xd_initialize):
10927 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10928 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10929 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
10930 (Fdbus_register_signal): Use SSDATA when the context wants char *.
10931
78320123
PE
10932 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
10933 if GCC considers string literals to be constants.
49cebcca 10934 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 10935
35ac2a97
SM
109362011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
10937
fb103ca9
SM
10938 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
10939 (print_preprocess, print_object): New macro to fix last change.
10940
35ac2a97
SM
10941 * print.c (print_preprocess): Don't forget font objects.
10942
62973b41
JB
109432011-03-16 Juanma Barranquero <lekktu@gmail.com>
10944
10945 * emacs.c (USAGE3): Doc fixes.
10946
0e48bb22
AS
109472011-03-15 Andreas Schwab <schwab@linux-m68k.org>
10948
10949 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
10950 structure.
10951
7684e57b
JB
109522011-03-14 Juanma Barranquero <lekktu@gmail.com>
10953
10954 * lisp.h (VWindow_system, Qfile_name_history):
10955 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
10956 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
10957 (w32_system_caret_x, w32_system_caret_y): Declare extern.
10958
10959 * w32select.c: Don't #include "keyboard.h".
c96bbc66 10960 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
10961
10962 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
10963 * w32console.c (detect_input_pending, read_input_pending)
10964 (encode_terminal_code):
10965 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
10966 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
10967 (w32_system_caret_y, Qfile_name_history):
10968 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
10969 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
10970 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
10971 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
10972 * w32proc.c (Qlocal, report_file_error):
10973 * w32term.c (Vwindow_system, updating_frame):
10974 * w32uniscribe.c (initialized, uniscribe_font_driver):
10975 Remove unneeded extern declarations.
10976
2aa46d6c
CY
109772011-03-14 Chong Yidong <cyd@stupidchicken.com>
10978
c96bbc66 10979 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 10980
cffc6f3b
CY
109812011-03-13 Chong Yidong <cyd@stupidchicken.com>
10982
10983 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
10984 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
10985 These macros can no longer be used for assignment.
10986
44f230aa
SM
10987 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
10988 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
10989 (record_buffer_markers, fetch_buffer_markers): New functions for
10990 recording and fetching special buffer markers.
10991 (set_buffer_internal_1, set_buffer_temp): Use them.
10992
10993 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
10994
10995 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
10996
10997 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
10998 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
10999
11000 * xdisp.c (hscroll_window_tree):
11001 (reconsider_clip_changes): Use PT instead of BUF_PT.
11002
d251f04b
EZ
110032011-03-13 Eli Zaretskii <eliz@gnu.org>
11004
11005 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11006 $(EMACS_ROOT)/lib/intprops.h.
11007
f0c77cd1
PE
110082011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11009
3eca4629
PE
11010 Fix more problems found by GCC 4.5.2's static checks.
11011
7c86ee98
PE
11012 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11013 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11014 (xg_free_frame_widgets): Make it clear that a local variable is
11015 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11016 (gdk_window_get_screen): Make it clear that this macro is needed
11017 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11018 (int_gtk_range_get_value): New function, which avoids a diagnostic
11019 from gcc -Wbad-function-cast.
11020 (xg_set_toolkit_scroll_bar_thumb): Use it.
11021 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11022 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11023 (get_utf8_string, xg_get_file_with_chooser):
11024 Rename locals to avoid shadowing.
11025 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11026
41729b81
PE
11027 * xgselect.c (xg_select): Remove unused var.
11028
f0c77cd1
PE
11029 * image.c (four_corners_best): Mark locals as initialized.
11030 (gif_load): Initialize transparent_p to zero (Bug#8238).
11031 Mark another local as initialized.
ec6cf4c6 11032 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11033
ce0ad53d 11034 * image.c (clear_image_cache): Now static.
d5d5a617 11035 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11036 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11037 (x_edge_detection): Remove unnecessary cast that
11038 gcc -Wbad-function-cast diagnoses.
2037898d 11039 (gif_load): Fix pointer signedness.
6ae141d6
PE
11040 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11041 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11042
33383987 110432011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11044
d32df629
PE
11045 Improve quality of tests for time stamp overflow.
11046 For example, without this patch (encode-time 0 0 0 1 1
11047 1152921504606846976) returns the obviously-bogus value (-948597
11048 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11049 reports time overflow. See
11050 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11051 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11052 * editfns.c: Include limits.h and intprops.h.
11053 (TIME_T_MIN, TIME_T_MAX): New macros.
11054 (time_overflow): Move earlier, to before first use.
11055 (hi_time, lo_time): New functions, for an accurate test for
11056 out-of-range times.
11057 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11058 (Fget_internal_run_time): Don't assume time_t fits in int.
11059 (make_time): Use list2 instead of Fcons twice.
11060 (Fdecode_time): More accurate test for out-of-range times.
11061 (check_tm_member): New function.
11062 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11063 (lisp_time_argument): Don't rely on undefined left-shift and
11064 right-shift behavior when checking for time stamp overflow.
8be6f318 11065
fe31d94c
PE
11066 * editfns.c (time_overflow): New function, refactoring common code.
11067 (Fformat_time_string, Fdecode_time, Fencode_time):
11068 (Fcurrent_time_string): Use it.
11069
8be6f318
PE
11070 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11071 * dired.c (make_time): Move to ...
11072 * editfns.c (make_time): ... here.
11073 * systime.h: Note the move.
11074
09d9db2c 110752011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11076
126bc0dc
YM
11077 * fringe.c (update_window_fringes): Remove unused variables.
11078
c47cbdfd
YM
11079 * unexmacosx.c (copy_data_segment): Also copy __got section.
11080 (Bug#8223)
11081
7ac80be9
EZ
110822011-03-12 Eli Zaretskii <eliz@gnu.org>
11083
c96bbc66 11084 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11085 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11086 Constify `char *' arguments and their references according to
11087 prototypes in tparam.h.
11088
ecb0f94d 11089 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11090
7ac80be9
EZ
11091 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11092 Adapt all references accordingly.
11093
11094 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11095
ef1fd07e
TT
110962011-03-11 Tom Tromey <tromey@redhat.com>
11097
11098 * buffer.c (syms_of_buffer): Remove obsolete comment.
11099
7ef4b50c
EZ
111002011-03-11 Eli Zaretskii <eliz@gnu.org>
11101
11102 * termhooks.h (encode_terminal_code): Declare prototype.
11103
11104 * msdos.c (encode_terminal_code): Don't declare prototype.
11105
11106 * term.c (encode_terminal_code): Now external again, used by
11107 w32console.c and msdos.c.
11108
44f230aa
SM
11109 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11110 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11111
4b1ec863 111122011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11113
1714f52b 11114 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11115
4b1ec863
PE
11116 * fringe.c (update_window_fringes): Mark locals as initialized
11117 (Bug#8227).
11118 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11119
524c7aa6
PE
11120 * alloc.c (mark_fringe_data): Move decl from here ...
11121 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11122 to check its interface.
11123 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11124
a5c0af81 11125 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11126 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11127 (fontset_font): Mark local as initialized.
a9a06e0b 11128 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11129
b4716021
PE
11130 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11131
811e9bac 11132 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11133 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11134 (x_own_selection, Fx_disown_selection_internal): Rename locals
11135 to avoid shadowing.
11136 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11137
7e3ab302
PE
11138 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11139 so that the caller can use some name other than gcpro1.
11140 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11141 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11142 (Fx_backspace_delete_keys_p):
11143 Use them to avoid shadowing, and rename vars to avoid shadowing.
11144 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11145 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11146 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11147 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11148 Remove unused locals.
7e3ab302
PE
11149 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11150 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11151 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11152 macros.
f78faa98 11153
e2b13473
PE
11154 * xterm.h (x_mouse_leave): New decl.
11155
77f23912
PE
11156 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11157 Remove unused functions.
cdf4ba58
PE
11158 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11159 (x_calc_absolute_position): Now static.
7411c686 11160 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11161 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11162 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11163 unless they are used.
38d0b34a
PE
11164 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11165 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11166 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11167 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11168 (x_error_catcher, x_connection_closed, x_error_handler):
11169 (x_error_quitter, xembed_send_message, x_iconify_frame):
11170 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 11171 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 11172 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 11173
44f230aa
SM
11174 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11175 Rename or move locals to avoid shadowing.
6b463e58 11176 (tty_defined_color, merge_face_heights): Now static.
5967d051 11177 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
11178 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11179 does not deduce is never used uninitialized.
73719eba
PE
11180 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11181 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 11182
426994c3 11183 * terminal.c (store_terminal_param): Now static.
5489860b 11184
032f1620 11185 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 11186 (set_frame_menubar): Remove unused local.
d4323972 11187 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
11188 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11189 since they might point to immutable storage.
281585b0
PE
11190 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11191 since it's unused otherwise.
032f1620 11192
367c19e5 11193 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 11194 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
11195 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11196 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 11197 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
11198 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11199 does not deduce are never used uninitialized.
70739cbe 11200
07b48fa9
PE
11201 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11202
8868a238 11203 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
11204 * window.c (window_loop, size_window):
11205 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 11206
7e5cf297 11207 * window.c (display_buffer): Now static.
d6550a9f
PE
11208 (size_window): Mark variables that gcc -Wuninitialized
11209 does not deduce are never used uninitialized.
a586633d
PE
11210 * window.h (check_all_windows): New decl, to forestall
11211 gcc -Wmissing-prototypes diagnostic.
5b555da1 11212 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 11213
f6095868
PE
11214 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11215 shadowing.
11216 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
11217 Include <limits.h>.
11218 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11219 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
11220 (load_charset_map): Mark variables that gcc -Wuninitialized
11221 does not deduce are never used uninitialized.
53df7c11 11222 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 11223
f38b440c
PE
11224 * coding.c (coding_set_source, coding_set_destination):
11225 Use "else { /* comment */ }" rather than "else /* comment */;"
11226 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
11227 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11228 a block, when the outer 'i' will do.
11229 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11230 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11231 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11232 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11233 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11234 Rename locals to avoid shadowing.
11235 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
11236 * coding.c (emacs_mule_char, encode_invocation_designation):
11237 Now static, since they're not used elsewhere.
413bb2db 11238 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 11239 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
11240 (decode_coding_emacs_mule): Mark variables that gcc
11241 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
11242 (detect_coding_iso_2022): Initialize a local variable that might
11243 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 11244 this initialization is needed. (Bug#8211)
5f58e762
PE
11245 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11246 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11247 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11248 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11249 Remove unused macros.
f38b440c 11250
232b38b9 11251 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 11252 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 11253 * character.c (string_count_byte8): Likewise.
232b38b9 11254
fb90da1b
PE
11255 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11256 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11257
fb93dbc2
PE
11258 * chartab.c (copy_sub_char_table): Now static, since it's not used
11259 elsewhere.
5c156ace
PE
11260 (sub_char_table_ref_and_range, char_table_ref_and_range):
11261 Rename locals to avoid shadowing.
bbcd0949 11262 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 11263
7d3b3862 11264 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 11265 (BIDI_BOB): Remove unused macro.
7d3b3862 11266
6be7d3da
PE
11267 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11268 deduce are never used uninitialized.
c2ed9c8b 11269 * term.c (encode_terminal_code): Likewise.
6be7d3da 11270
75f8807f 11271 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 11272
50938595
PE
11273 * tparam.h: New file.
11274 * term.c, tparam.h: Include it.
11275 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11276 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11277 Move these decls to tparam.h, and make them agree with what
11278 is actually in tparam.c. The previous trick of using incompatible
11279 decls in different modules does not conform to the C standard.
11280 All callers of tparam changed to use tparam's actual API.
11281 * tparam.c (tparam1, tparam, tgoto):
11282 Use const pointers where appropriate.
11283
fbceeba2
PE
11284 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11285 * cm.h (struct cm): Likewise.
11286 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11287 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11288 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11289 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11290 (turn_on_face, init_tty): Likewise.
11291 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 11292
7f3f1250
PE
11293 * term.c (term_mouse_position): Rename local to avoid shadowing.
11294
e6ca6543
PE
11295 * alloc.c (mark_ttys): Move decl from here ...
11296 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11297
c40f8d15
AS
112982011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11299
11300 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11301
cfe0661d
JB
113022011-03-09 Juanma Barranquero <lekktu@gmail.com>
11303
11304 * search.c (compile_pattern_1): Remove argument regp, unused since
11305 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11306 (compile_pattern): Don't pass it.
11307
0afb4571
J
113082011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11309
11310 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11311 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11312 for ! HAVE_GTK3.
11313 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11314
11315 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11316
11317 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11318 gdk_window_get_screen, gdk_window_get_geometry,
11319 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11320 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11321 (xg_get_pixbuf_from_pixmap): New function.
11322 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11323 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11324 Call xg_get_pixbuf_from_pixmap instead of
11325 gdk_pixbuf_get_from_drawable.
11326 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11327 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11328 (xg_check_special_colors): Use GtkStyleContext and its functions
11329 for HAVE_GTK3.
11330 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11331 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11332 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
11333 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11334 Call gtk_widget_get_preferred_size.
0afb4571
J
11335 (xg_frame_resized): gdk_window_get_geometry only takes 5
11336 parameters.
44f230aa
SM
11337 (xg_win_to_widget, xg_event_is_for_menubar):
11338 Call gdk_x11_window_lookup_for_display.
0afb4571
J
11339 (xg_set_widget_bg): New function.
11340 (delete_cb): New function.
895009e1 11341 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 11342 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
11343 (xg_set_background_color): Call xg_set_widget_bg.
11344 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11345 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11346 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11347 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11348 if ! HAVE_GTK3.
11349 (update_frame_tool_bar): Call gtk_widget_hide.
11350 (xg_initialize): Use GDK_KEY_g.
11351
11352 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11353 if ! HAVE_GTK3
11354 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11355
11356 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11357 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11358 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11359
1c2cc4ef
JB
113602011-03-08 Juanma Barranquero <lekktu@gmail.com>
11361
11362 * w32xfns.c (select_palette): Check success of RealizePalette against
11363 GDI_ERROR, not zero.
11364
33383987 11365See ChangeLog.11 for earlier changes.
aac0c6e3
MR
11366
11367;; Local Variables:
11368;; coding: utf-8
aac0c6e3
MR
11369;; End:
11370
2f097256 11371 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
11372
11373 This file is part of GNU Emacs.
11374
11375 GNU Emacs is free software: you can redistribute it and/or modify
11376 it under the terms of the GNU General Public License as published by
11377 the Free Software Foundation, either version 3 of the License, or
11378 (at your option) any later version.
11379
11380 GNU Emacs is distributed in the hope that it will be useful,
11381 but WITHOUT ANY WARRANTY; without even the implied warranty of
11382 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11383 GNU General Public License for more details.
11384
11385 You should have received a copy of the GNU General Public License
11386 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.