* term.c (init_tty): Remove unused local.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
270768cd
PE
12011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2
3 Fix recently-introduced minor problems.
4 * term.c (init_tty): Remove unused local.
5
b1f58454
CY
62011-07-12 Chong Yidong <cyd@stupidchicken.com>
7
8 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9
22b9578d
LMI
102011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
11
6e70ab07
LMI
12 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
13 are the mini-buffer and the echo area (bug#3320).
14
22b9578d
LMI
15 * term.c (init_tty): Remove support for supdup, c10 and perq
16 terminals, which are no longer supported (bug#1482).
17
8974cc9f
JB
182011-07-10 Johan Bockgård <bojohan@gnu.org>
19
20 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
21
a560d974
JD
222011-07-10 Jan Djärv <jan.h.d@swipnet.se>
23
24 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
25 for non-popups (Bug#3642).
26
1dae0f0a
AS
272011-07-10 Andreas Schwab <schwab@linux-m68k.org>
28
268c2c36 29 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 30 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
31 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
32 * cm.c (losecursor): Likewise.
1dae0f0a
AS
33 * data.c (fmod): Likewise.
34 * dispnew.c (swap_glyphs_in_rows): Likewise.
35 * emacs.c (memory_warning_signal): Likewise.
36 * floatfns.c (float_error): Likewise.
37 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
38 (otf_open, font_otf_capability, generate_otf_features)
39 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
40 Likewise.
41 * image.c (pbm_read_file): Likewise.
42 * indent.c (string_display_width): Likewise.
43 * intervals.c (check_for_interval, search_for_interval)
44 (inc_interval_count, count_intervals, root_interval)
45 (adjust_intervals_for_insertion, make_new_interval): Likewise.
46 * lread.c (defalias): Likewise.
268c2c36 47 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
48 * regex.c (set_image_of_range_1, set_image_of_range)
49 (regex_grow_registers): Likewise.
50 * sysdep.c (strerror): Likewise.
51 * termcap.c (valid_filename_p, tprint, main): Likewise.
52 * tparam.c (main): Likewise.
53 * unexhp9k800.c (run_time_remap, save_data_space)
54 (update_file_ptrs, read_header, write_header, calculate_checksum)
55 (copy_file, copy_rest, display_header): Likewise.
56 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
57 Likewise.
58 * xdisp.c (check_it): Likewise.
59 * xfaces.c (register_color, unregister_color, unregister_colors):
60 Likewise.
61 * xfns.c (print_fontset_result): Likewise.
62 * xrdb.c (member, fatal, main): Likewise.
63
99033785
PE
642011-07-10 Paul Eggert <eggert@cs.ucla.edu>
65
66 Fix minor problems found by static checking (Bug#9031).
67 * chartab.c (char_table_set_range, map_sub_char_table):
68 Remove unused locals.
69 (uniprop_table): Now static.
70 * composite.c (_work_char): Remove unused static var.
71
9cb2ac56
JB
722011-07-09 Juanma Barranquero <lekktu@gmail.com>
73
74 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
75
f25661f0
JD
762011-07-09 Jan Djärv <jan.h.d@swipnet.se>
77
78 * gtkutil.c (qttip_cb): Remove code without function.
79
8278c4fe
EZ
802011-07-09 Eli Zaretskii <eliz@gnu.org>
81
82 * w32.c (pthread_sigmask): New stub.
83
1692ae2d 842011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 85
8a6ebd58 86 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
87 sigprocmask is portable only for single-threaded applications, and
88 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
89 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
90 (LIBES): Use it.
91 * callproc.c (Fcall_process):
92 * process.c (create_process):
93 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
94 Use pthread_sigmask, not sigprocmask.
123403e4 95
1b854618
JD
962011-07-08 Jan Djärv <jan.h.d@swipnet.se>
97
98 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
99 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
100 wrong (Bug#8591).
101
3fe4b549
JD
1022011-07-08 Jan Djärv <jan.h.d@swipnet.se>
103
0ce7e563
JD
104 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
105 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
106 (xg_hide_tooltip): Fix comment.
107
3fe4b549
JD
108 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
109 in registerServicesMenuSendTypes.
110 (validRequestorForSendType): Don't check ns_return_types.
111
112 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
113 ns_return_type.
114
5df75e47
JR
1152011-07-08 Jason Rumney <jasonr@gnu.org>
116
117 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
118 frame struct members of non-existent frames (Bug#6284).
119
699c10bd
JD
1202011-07-08 Jan Djärv <jan.h.d@swipnet.se>
121
4393663b
JD
122 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
123 variable firstTime not needed on OSX >= 10.6.
124 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
125 >= 10.5. Use setKnobProportion, setDoubleValue.
126
127 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
128 (MAC_OS_X_VERSION_10_5): Define if not defined.
129 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
130 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
131 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
132
133 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
134 cString and lossyCString on OSX >= 10.4
135
136 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
137 sizeToFit on OSX >= 10.2.
138
139 * nsimage.m (allocInitFromFile): Don't use deprecated method
140 bestRepresentationForDevice on OSX >= 10.6.
141
142 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
143 to avoid warning.
144
145 * emacs.c: Declare unexec_init_emacs_zone.
146
a63e0781
JD
147 * nsgui.h: Fix compiler warning about gnulib redefining verify.
148
699c10bd
JD
149 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
150
151 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
152 on svcsMenu (Bug#8842).
153
154 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
155 ns_return_types.
156 (Fns_list_services): Just return Qnil on 10.6, code not working there.
157
158 * nsterm.m (QUTF8_STRING): Declare.
159 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
160 (validRequestorForSendType): Return type is (id).
161 Change indexOfObjectIdenticalTo to indexOfObject.
162 Check if we have local selection before returning self (Bug#8842).
163 (writeSelectionToPasteboard): Put local selection into paste board
164 if we have a local selection (Bug#8842).
165 (syms_of_nsterm): DEFSYM QUTF8_STRING.
166
167 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
168 (ns_get_local_selection): Declare.
169
54e10184
LMI
1702011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
171
9888ff71
LMI
172 * keymap.c (describe_map_tree): Don't insert a double newline at
173 the end of the buffer (bug#1169) and return whether we inserted
174 something.
175
54e10184
LMI
176 * callint.c (Fcall_interactively): Change "reading args" to
177 "providing args" to try to clarify what it does (bug#1010).
178
15fa4783
KH
1792011-07-07 Kenichi Handa <handa@m17n.org>
180
181 * composite.c (composition_compute_stop_pos): Ignore a static
182 composition starting before CHARPOS (Bug#8915).
183
184 * xdisp.c (handle_composition_prop): Likewise.
185
a8815b00
EZ
1862011-07-07 Eli Zaretskii <eliz@gnu.org>
187
188 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
189 (Bug#9015)
190
ef7b981d 1912011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
192
193 * character.h (unicode_category_t): New enum type.
194
195 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
196 (Qchar_code_property_table): New variable.
197 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
198 (UNIPROP_COMPRESSED_FORM_P): New macros.
199 (char_table_ascii): Uncompress the compressed values.
200 (sub_char_table_ref): New arg is_uniprop. Callers changed.
201 Uncompress the compressed values.
202 (sub_char_table_ref_and_range): Likewise.
203 (char_table_ref_and_range): Uncompress the compressed values.
204 (sub_char_table_set): New arg is_uniprop. Callers changed.
205 Uncompress the compressed values.
206 (sub_char_table_set_range): Args changed. Callers changed.
207 (char_table_set_range): Adjuted for the above change.
208 (map_sub_char_table): Delete args default_val and parent. Add arg
209 top. Give decoded values to a Lisp function.
210 (map_char_table): Adjusted for the above change. Give decoded
211 values to a Lisp function. Gcpro more variables.
212 (uniprop_table_uncompress)
213 (uniprop_decode_value_run_length): New functions.
214 (uniprop_decoder, uniprop_decoder_count): New variables.
215 (uniprop_get_decoder, uniprop_encode_value_character)
216 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
217 New functions.
218 (uniprop_encoder, uniprop_encoder_count): New variables.
219 (uniprop_get_encoder, uniprop_table)
220 (Funicode_property_table_internal, Fget_unicode_property_internal)
221 (Fput_unicode_property_internal): New functions.
222 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
223 Sunicode_property_table_internal, Sget_unicode_property_internal,
224 and Sput_unicode_property_internal. Defvar_lisp
225 char-code-property-alist.
226
227 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
228 Vunicode_category_table.
229
230 * font.c (font_range): Adjusted for the change of
231 Vunicode_category_table.
232
76b397fb
DN
2332011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
234
235 * m/iris4d.h: Remove file, move contents ...
236 * s/irix6-5.h: ... here.
237
22b4128e
PE
2382011-07-06 Paul Eggert <eggert@cs.ucla.edu>
239
240 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
241 * alloc.c (mark_buffer):
242 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
243 (clone_per_buffer_values): Don't assume that
22b4128e
PE
244 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
245 This isn't true in general, and it's particularly not true
246 if Emacs is configured with --with-wide-int.
247 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
248 New macros, used in the buffer.c change.
249
869795d6
JD
2502011-07-05 Jan Djärv <jan.h.d@swipnet.se>
251
252 * xsettings.c: Use both GConf and GSettings if both are available.
253 (store_config_changed_event): Add comment.
254 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
255 (store_tool_bar_style_changed): New functions.
256 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
257 (struct xsettings): Move font inside HAVE_XFT.
258 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
259 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
260 Move inside HAVE_XFT.
261 (something_changed_gsettingsCB): Renamed from something_changedCB.
262 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
263 also.
264 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
265 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
266 (something_changed_gconfCB): Renamed from something_changedCB.
267 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
268 (parse_settings): Move check for font inside HAVE_XFT.
269 (read_settings, apply_xft_settings): Add comment.
270 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
271 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
272 call store_font_name_changed.
273 (xft_settings_event): Add comment.
274 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
275 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
276 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
277 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
278 (xsettings_initialize): Call init_gsettings last.
279 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
280 comment.
281
d8ed26bd
PE
2822011-07-05 Paul Eggert <eggert@cs.ucla.edu>
283
284 Random fixes. E.g., (random) never returned negative values.
285 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
286 subseconds part to the entropy, as that's a bit more random.
287 Prefer signed to unsigned, since the signedness doesn't matter and
288 in general we prefer signed. When given a limit, use a
289 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
290 latter isn't right if USE_2_TAGS_FOR_INTS.
291 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
292 not 0..VALMASK. Don't discard "excess" bits that random () returns.
293
cabf1cac
SM
2942011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
295
296 * textprop.c (text_property_stickiness):
297 Obey Vtext_property_default_nonsticky.
298 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
299 * w32fns.c (syms_of_w32fns):
300 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
301
6e9b2be9
PE
3022011-07-04 Paul Eggert <eggert@cs.ucla.edu>
303
304 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
305 This is more efficient than Ffile_directory_p and avoids a minor race.
306
90186c68
LMI
3072011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
308
7c301272
LMI
309 * buffer.c (Foverlay_put): Say what the return value is
310 (bug#7835).
311
c4f2d8d4
LMI
312 * fileio.c (barf_or_query_if_file_exists): Check first if the file
313 is a directory before asking whether to use the file name
314 (bug#7564).
ad637907
LMI
315 (barf_or_query_if_file_exists): Make the "File is a directory"
316 error be more correct.
c4f2d8d4 317
90186c68
LMI
318 * fns.c (Frequire): Remove the mention of the .gz files, since
319 that's installation-specific, but keep the mention of
320 `get-load-suffixes'.
321
da64016e
PE
3222011-07-04 Paul Eggert <eggert@cs.ucla.edu>
323
324 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
325 Report string overflow if the output is too long.
326
7d47b580
JB
3272011-07-04 Juanma Barranquero <lekktu@gmail.com>
328
a555cb87
JB
329 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
330 (syms_of_gnutls): Remove duplicate DEFSYM for
331 Qgnutls_bootprop_verify_hostname_error, an error for
332 Qgnutls_bootprop_verify_error (which is no longer used).
333
7d47b580
JB
334 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
335 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
336 Also (re)move comments that are misplaced or no longer relevant.
337
1e49bfab
LMI
3382011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
339
340 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
341
1485f4c0
CY
3422011-07-03 Chong Yidong <cyd@stupidchicken.com>
343
344 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
345 and background color parameters if they have been changed.
346
a9ab721e
LMI
3472011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
348
349 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
350
cf7cff57
PE
3512011-07-03 Paul Eggert <eggert@cs.ucla.edu>
352
2e13213d
PE
353 * xsettings.c (SYSTEM_FONT): Define only when used.
354 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
355
cf7cff57
PE
356 * keymap.c (access_keymap_1): Now static.
357
7a8e04f7
CY
3582011-07-02 Chong Yidong <cyd@stupidchicken.com>
359
360 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
361 leave any prefix arg for the up event (Bug#1586).
362
61352f62
LMI
3632011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
364
69bb1ef7
LMI
365 * lread.c (syms_of_lread): Mention single symbols defined by
366 `defvar' or `defconst' (bug#7154).
367
61352f62 368 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 369 (Frequire): Mention get-load-suffixes.
61352f62 370
28545e04
MR
3712011-07-02 Martin Rudalics <rudalics@gmx.at>
372
373 * window.h (window): Remove clone_number slot.
374 * window.c (Fwindow_clone_number, Fset_window_clone_number):
375 Remove.
376 (make_parent_window, make_window, saved_window)
377 (Fset_window_configuration, save_window_save): Don't deal with
378 clone numbers.
379 * buffer.c (Qclone_number): Remove declaration.
380 (sort_overlays, overlay_strings): Don't deal with clone numbers.
381
3349e122
SM
3822011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
383
384 Add multiple inheritance to keymaps.
385 * keymap.c (Fmake_composed_keymap): New function.
386 (Fset_keymap_parent): Simplify.
387 (fix_submap_inheritance): Remove.
388 (access_keymap_1): New function extracted from access_keymap to handle
389 embedded parents and handle lists of maps.
390 (access_keymap): Use it.
391 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
392 (Fcopy_keymap): Handle embedded parents.
393 (Fcommand_remapping, define_as_prefix): Simplify.
394 (Fkey_binding): Simplify.
395 (syms_of_keymap): Move minibuffer-local-completion-map,
396 minibuffer-local-filename-completion-map,
397 minibuffer-local-must-match-map, and
398 minibuffer-local-filename-must-match-map to Elisp.
399 (syms_of_keymap): Defsubr make-composed-keymap.
400 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
401 (parse_menu_item): Trivial simplification.
402
3279eb87
GM
4032011-07-01 Glenn Morris <rgm@gnu.org>
404
405 * Makefile.in (SETTINGS_LIBS): Fix typo.
406
4550efdf
KI
4072011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
408
409 * coding.c (Fencode_coding_string): Record the last coding system
410 used, as the function doc string says (bug#8738).
411
0949d2b6
JD
4122011-07-01 Jan Djärv <jan.h.d@swipnet.se>
413
414 * xsettings.c (store_monospaced_changed): Take new font as arg and
415 check for change against current_mono_font.
416 (EMACS_TYPE_SETTINGS): Remove this and related defines.
417 (emacs_settings_constructor, emacs_settings_get_property)
418 (emacs_settings_set_property, emacs_settings_class_init)
419 (emacs_settings_init, gsettings_obj): Remove.
420 (something_changedCB): New function for HAVE_GSETTINGS.
421 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
422 with value as argument.
423 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
424 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 425 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
426 "changed".
427
428 * xgselect.c: Add defined (HAVE_GSETTINGS).
429 (xgselect_initialize): Ditto.
430
431 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
432 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
433 xg_select.
434
bbc6b304
PE
4352011-07-01 Paul Eggert <eggert@cs.ucla.edu>
436
437 * eval.c (struct backtrace): Simplify and port the data structure.
438 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
439 signed bit field, as this assumption is not portable and it makes
440 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
441 "char debug_on_exit : 1" as this is not portable either; instead,
442 use the portable "unsigned int debug_on_exit : 1". Remove unused
443 member evalargs. Remove obsolete comments about cc bombing out.
444
9851bfc5
JD
4452011-06-30 Jan Djärv <jan.h.d@swipnet.se>
446
51bb811f 447 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
448 Let HAVE_GSETTINGS override HAVE_GCONF.
449 (store_monospaced_changed): New function.
450 (EMACS_SETTINGS): A new type derived from GObject to handle
451 GSettings notifications.
452 (emacs_settings_constructor, emacs_settings_get_property)
453 (emacs_settings_set_property, emacs_settings_class_init):
454 New functions.
455 (gsettings_client, gsettings_obj): New variables.
456 (GSETTINGS_SCHEMA): New define.
457 (something_changedCB): Call store_monospaced_changed.
458 (init_gsettings): New function.
459 (xsettings_initialize): Call init_gsettings.
460 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
461 to NULL.
462
463 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
464 GCONF_CFLAGS/LIBS.
465
5386012d
MR
4662011-06-29 Martin Rudalics <rudalics@gmx.at>
467
468 * window.c (resize_root_window, grow_mini_window)
469 (shrink_mini_window): Rename Qresize_root_window to
470 Qwindow_resize_root_window and Qresize_root_window_vertically to
471 Qwindow_resize_root_window_vertically.
472
f13e0b08
PE
4732011-06-28 Paul Eggert <eggert@cs.ucla.edu>
474
475 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
476
94515237
JB
4772011-06-27 Juanma Barranquero <lekktu@gmail.com>
478
479 * makefile.w32-in: Redesign dependencies so they reflect more
480 clearly which files are directly included by each source file,
481 and not through other includes.
482
e43b6e43
MR
4832011-06-27 Martin Rudalics <rudalics@gmx.at>
484
485 * buffer.c (Qclone_number): Declare static and DEFSYM it.
486 (sort_overlays, overlay_strings): When an overlay's clone number
487 matches the window's clone number process the overlay even if
488 the overlay's window property doesn't match the current window.
489
d68443dc
MR
490 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
491 (Fwindow_hchild): Rename to Fwindow_left_child.
492 (Fwindow_next): Rename to Fwindow_next_sibling.
493 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
494 (resize_window_check): Rename to window_resize_check.
495 (resize_window_apply): Rename to window_resize_apply.
496 (Fresize_window_apply): Rename to Fwindow_resize_apply.
497 (Fdelete_other_windows_internal, resize_frame_windows)
498 (Fsplit_window_internal, Fdelete_window_internal)
499 (grow_mini_window, shrink_mini_window)
500 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 501
c7e73be5
JD
5022011-06-26 Jan Djärv <jan.h.d@swipnet.se>
503
504 * emacsgtkfixed.h: State that this is only used with Gtk+3.
505 (emacs_fixed_set_min_size): Remove.
506 (emacs_fixed_new): Take frame as argument.
507
508 * emacsgtkfixed.c: State that this is only used with Gtk+3.
509 (_EmacsFixedPrivate): Remove minwidth/height.
510 Add struct frame *f.
511 (emacs_fixed_init): Initialize priv->f.
512 (get_parent_class, emacs_fixed_set_min_size): Remove.
513 (emacs_fixed_new): Set priv->f to argument.
514 (emacs_fixed_get_preferred_width)
515 (emacs_fixed_get_preferred_height): Use min_width/height from
516 frames size_hint to set minimum and natural (Bug#8919).
517 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
518 and use min_width/height from frames size_hint to set
519 min_width/height (Bug#8919).
520
521 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
522 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
523 Fix indentation.
c7e73be5 524
cf99dcf8
EZ
5252011-06-26 Eli Zaretskii <eliz@gnu.org>
526
527 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
528 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
529 called at ZV.
530
029529ac
CY
5312011-06-26 Chong Yidong <cyd@stupidchicken.com>
532
533 * process.c (wait_reading_process_output): Bypass select if
534 waiting for a cell while ignoring keyboard input, and input is
535 pending. Suggested by Jan Djärv (Bug#8869).
536
7a7ef429
PE
5372011-06-25 Paul Eggert <eggert@cs.ucla.edu>
538
539 Use gnulib's dup2 module instead of rolling our own.
540 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
541
11fdef7d 5422011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
543
544 * dispnew.c (scrolling_window): Before scrolling, turn off a
545 mouse-highlight in the window being scrolled.
546
cd3520a4
JB
5472011-06-24 Juanma Barranquero <lekktu@gmail.com>
548
549 Move DEFSYM to lisp.h and use everywhere.
550
551 * character.h (DEFSYM): Move declaration...
552 * lisp.h (DEFSYM): ...here.
553
554 * gnutls.c:
555 * minibuf.c:
556 * w32menu.c:
557 * w32proc.c:
558 * w32select.c: Don't include character.h.
559
560 * alloc.c (syms_of_alloc):
561 * buffer.c (syms_of_buffer):
562 * bytecode.c (syms_of_bytecode):
563 * callint.c (syms_of_callint):
564 * casefiddle.c (syms_of_casefiddle):
565 * casetab.c (init_casetab_once):
566 * category.c (init_category_once, syms_of_category):
567 * ccl.c (syms_of_ccl):
568 * cmds.c (syms_of_cmds):
569 * composite.c (syms_of_composite):
570 * dbusbind.c (syms_of_dbusbind):
571 * dired.c (syms_of_dired):
572 * dispnew.c (syms_of_display):
573 * doc.c (syms_of_doc):
574 * editfns.c (syms_of_editfns):
575 * emacs.c (syms_of_emacs):
576 * eval.c (syms_of_eval):
577 * fileio.c (syms_of_fileio):
578 * fns.c (syms_of_fns):
579 * frame.c (syms_of_frame):
580 * fringe.c (syms_of_fringe):
581 * insdel.c (syms_of_insdel):
582 * keymap.c (syms_of_keymap):
583 * lread.c (init_obarray, syms_of_lread):
584 * macros.c (syms_of_macros):
585 * msdos.c (syms_of_msdos):
586 * print.c (syms_of_print):
587 * process.c (syms_of_process):
588 * search.c (syms_of_search):
589 * sound.c (syms_of_sound):
590 * syntax.c (init_syntax_once, syms_of_syntax):
591 * terminal.c (syms_of_terminal):
592 * textprop.c (syms_of_textprop):
593 * undo.c (syms_of_undo):
594 * w32.c (globals_of_w32):
595 * window.c (syms_of_window):
596 * xdisp.c (syms_of_xdisp):
597 * xfaces.c (syms_of_xfaces):
598 * xfns.c (syms_of_xfns):
599 * xmenu.c (syms_of_xmenu):
600 * xsettings.c (syms_of_xsettings):
601 * xterm.c (syms_of_xterm): Use DEFSYM.
602
4228cf16
TZ
6032011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
604
cd3520a4 605 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 606
7fcccf1e
PE
6072011-06-23 Paul Eggert <eggert@cs.ucla.edu>
608
7efb4e0e
PE
609 Integer and buffer overflow fixes (Bug#8873).
610
ff5844ad
PE
611 * print.c (printchar, strout): Check for string overflow.
612 (PRINTPREPARE, printchar, strout):
613 Don't set size unless allocation succeeds.
614
90532f02
PE
615 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
616 for sizes. Check for string overflow more accurately.
617 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
618
6d84508d
PE
619 * macros.c: Integer and buffer overflow fixes.
620 * keyboard.h (struct keyboard.kbd_macro_bufsize):
621 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
622 Use ptrdiff_t, not int, for sizes.
623 Don't increment bufsize until after realloc succeeds.
624 Check for size-calculation overflow.
625 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
626
437b2cb4
PE
627 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
628
8b9ac8b4
PE
629 * lread.c: Integer overflow fixes.
630 (read_integer): Radix is now EMACS_INT, not int,
631 to improve quality of diagnostics for out-of-range radices.
632 Calculate buffer size correctly for out-of-range radices.
633 (read1): Check for integer overflow in radices, and in
634 read-circle numbers.
82cb60d3
PE
635 (read_escape): Avoid int overflow.
636 (Fload, openp, read_buffer_size, read1)
637 (substitute_object_recurse, read_vector, read_list, map_obarray):
638 Use ptrdiff_t, not int, for sizes.
639 (read1): Use EMACS_INT, not int, for sizes.
20270765 640 Check for size overflow.
8b9ac8b4 641
7fcccf1e
PE
642 * image.c (cache_image): Check for size arithmetic overflow.
643
bfbbd7e7
PE
644 * lread.c: Integer overflow issues.
645 (saved_doc_string_size, saved_doc_string_length)
646 (prev_saved_doc_string_size, prev_saved_doc_string_length):
647 Now ptrdiff_t, not int.
648 (read1): Don't assume doc string length fits in int. Check for
649 out-of-range doc string lengths.
650 (read_list): Don't assume file position fits in int.
39019e54 651 (read_escape): Check for hex character overflow.
bfbbd7e7 652
4e323265
LL
6532011-06-22 Leo Liu <sdl.web@gmail.com>
654
655 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
656 Move to minibuffer.el.
657
85fece3e
PE
6582011-06-22 Paul Eggert <eggert@cs.ucla.edu>
659
20b84ce9 660 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
661 The following patches are for when GLYPH_DEBUG && !XASSERT.
662 * dispextern.h (trace_redisplay_p, dump_glyph_string):
663 * dispnew.c (flush_stdout):
664 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
665 Mark as externally visible.
666 * dispnew.c (check_window_matrix_pointers): Now static.
667 * dispnew.c (window_to_frame_vpos):
668 * xfns.c (unwind_create_frame):
669 * xterm.c (x_check_font): Remove unused local.
670 * scroll.c (CHECK_BOUNDS):
671 * xfaces.c (cache_fache): Rename local to avoid shadowing.
672 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
673 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
674 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
675 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
676 Now static.
677 (debug_method_add): Use va_list and vsprintf rather than relying
678 on undefined behavior with wrong number of arguments.
679 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
680 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
681 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
682 since we're not interested in debugging glyphs with old libraries.
683 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
684 GCC 4.6.0's static checking.
685
0766b489
PE
6862011-06-22 Paul Eggert <eggert@cs.ucla.edu>
687
31fd4b32
PE
688 Integer overflow and signedness fixes (Bug#8873).
689 A few related buffer overrun fixes, too.
690
b79e8648
PE
691 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
692
0766b489
PE
693 * dispextern.h (struct face.stipple):
694 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
695 (x_bitmap_mask, x_allocate_bitmap_record)
696 (x_create_bitmap_from_data, x_create_bitmap_from_file)
697 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
698 (x_create_bitmap_from_xpm_data):
699 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
700 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
701 (.bitmaps_last):
702 * xfaces.c (load_pixmap):
703 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
704 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
705 (.bitmaps_last, struct x_output.icon_bitmap):
706 Use ptrdiff_t, not int, for bitmap indexes.
707 (x_allocate_bitmap_record): Check for size overflow.
708 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
709
b081724f
PE
710 Use ptrdiff_t, not int, for overlay counts.
711 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
712 * editfns.c (overlays_around, get_pos_property):
713 * textprop.c (get_char_property_and_overlay):
714 * xdisp.c (next_overlay_change, note_mouse_highlight):
715 * xfaces.c (face_at_buffer_position):
21514da7
PE
716 * buffer.c (OVERLAY_COUNT_MAX): New macro.
717 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
718 (Fnext_overlay_change, Fprevious_overlay_change)
719 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 720 Use ptrdiff_t, not int, for sizes.
21514da7 721 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 722
3de73e5e
PE
723 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
724
2606c57b
PE
725 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
726 (x_session_initialize): Do not assume string length fits in int.
727
aaafe47a
PE
728 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
729 This is unlikely, but can occur if DPI is outlandish.
730
2674ddc8 731 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
732 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
733
28154962
PE
734 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
735 * xrdb.c (magic_file_p, search_magic_path):
736 Omit last arg SUFFIX; it was always 0. All callers changed.
737 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
738
7de51af5
PE
739 * xfont.c (xfont_match): Avoid need for strlen.
740
25ed6cc3
PE
741 * xfns.c: Don't assume strlen fits in int.
742 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
743
4eab31dd
PE
744 * xdisp.c (message_log_check_duplicate): Return intmax_t,
745 not unsigned long, as we prefer signed integers. All callers changed.
746 Detect integer overflow in repeat count.
747 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 748 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 749
171e2a58
PE
750 * termcap.c: Don't assume sizes fit in int and never overflow.
751 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
752 (gobble_line): Check for size-calculation overflow.
753
ad39faca 754 * minibuf.c (Fread_buffer):
6e5bb2dc 755 * lread.c (intern, intern_c_string):
74ca2eb3
PE
756 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
757 Don't assume string length fits in int.
758
52c61c22 759 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
760 * gtkutil.c (style_changed_cb): Avoid need for strlen.
761
b5b8c9e5
PE
762 * font.c: Don't assume string length fits in int.
763 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
764 Use ptrdiff_t, not int.
ccd6111c
PE
765 (font_intern_prop): Don't assume string length fits in int.
766 Don't assume integer property fits in fixnum.
767 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 768
882f0d81 769 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 770 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
771 Reformulate so as not to need the command string.
772 Invoke gzip -cd rather than gunzip, as it's more portable.
773 (lock_info_type, lock_file_1, lock_file):
774 Don't assume pid_t and time_t fit in unsigned long.
775 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
776 (current_lock_owner): Prefer signed type for sizes.
777 Use memcpy, not strncpy, where memcpy is what is really wanted.
778 Don't assume (via atoi) that time_t and pid_t fit in int.
779 Check for time_t and/or pid_t out of range, e.g., via a network share.
780 Don't alloca where an auto var works fine.
781
93f4cf88
PE
782 * fileio.c: Fix some integer overflow issues.
783 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
784 Don't assume string length fits in int.
785 (directory_file_name): Don't assume string length fits in long.
786 (make_temp_name): Don't assume pid fits in int, or that its print
787 length is less than 20.
788
f3e92b69
PE
789 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
790
1bfdaf10
PE
791 * coding.c (make_subsidiaries): Don't assume string length fits in int.
792
35016e9a
PE
793 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
794
3d1e65a1
PE
795 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
796 We prefer signed integers, even for size calculations.
797
0b963a93
PE
798 * emacs.c: Don't assume string length fits in 'int'.
799 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
800 (main): Don't invoke strlen when not needed.
801
573f4b54
PE
802 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
803 (XD_DEBUG_MESSAGE): Don't waste a byte.
804
989f33ba
PE
805 * callproc.c (getenv_internal_1, getenv_internal)
806 (Fgetenv_internal):
965d34eb
PE
807 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
808
e4d29b33
PE
809 * lread.c (invalid_syntax): Omit length argument.
810 All uses changed. This doesn't fix a bug, but it simplifies the
811 code away from its former Hollerith-constant appearance, and it's
812 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 813 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 814
eb49b136
PE
815 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
816 This didn't break anything, but it didn't help either.
817 It's confusing to put a bogus integer in a place where the actual
818 value does not matter.
9f62aeb1 819 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 820 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 821
15375a22
PE
822 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
823 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
824 implementation.
b61cc01c
PE
825 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
826 We prefer signed types, and the value cannot exceed the EMACS_INT
827 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
828 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
829 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
830 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 831
53b2623d
PE
832 * indent.c (sane_tab_width): New function.
833 (current_column, scan_for_column, Findent_to, position_indentation)
834 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 835 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 836
51cab52b 837 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 838
f2ed8a70
PE
839 * lisp.h (lint_assume): New macro.
840 * composite.c (composition_gstring_put_cache):
841 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
842
abe80cc6
PE
843 * editfns.c, insdel.c:
844 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 845
b02c740e
PE
846 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
847
ebc96716
PE
848 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
849
b4e50fa0 850 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 851 Use much-faster test for byte-length change.
311d5d7c 852 Don't assume string byte-length fits in 'int'.
a4cf38e4 853 Check that character arg fits in 'int'.
85461888 854 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 855
c0c1ee9f
PE
856 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
857
a498d7f4
PE
858 * fns.c (concat): Catch string overflow earlier.
859 Do not rely on integer wraparound.
860
51cab52b
PE
861 * dispextern.h (struct it.overlay_strings_charpos)
862 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
863 * xdisp.c (forward_to_next_line_start)
864 (back_to_previous_visible_line_start)
865 (reseat_at_next_visible_line_start, next_element_from_buffer):
866 Don't arbitrarily truncate the value of 'selective' to int.
867
76031fad
PE
868 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
869
5eb55db9
PE
870 * composite.c: Don't truncate sizes to 'int'.
871 (composition_gstring_p, composition_reseat_it)
872 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
873 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
874 not EMACS_UINT, for indexes.
5eb55db9 875
0703a717
PE
876 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
877
d6202519
PE
878 * buffer.c: Include <verify.h>.
879 (struct sortvec.priority, struct sortstr.priority):
8961a454 880 Now EMACS_INT, not int.
c20998a7 881 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
882 (struct sortstr.size, record_overlay_string)
883 (struct sortstrlist.size, struct sortlist.used):
884 Don't truncate size to int.
885 (record_overlay_string): Check for size-calculation overflow.
d6202519 886 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 887
d5a19415
JM
8882011-06-22 Jim Meyering <meyering@redhat.com>
889
029529ac 890 Don't leak an XBM-image-sized buffer
d5a19415
JM
891 * image.c (xbm_load): Free the image buffer after using it.
892
a9041e6c
PE
8932011-06-21 Paul Eggert <eggert@cs.ucla.edu>
894
895 Port to Sun C.
896 * composite.c (find_automatic_composition): Omit needless 'return 0;'
897 that Sun C diagnosed.
898 * fns.c (secure_hash): Fix pointer signedness issue.
899 * intervals.c (static_offset_intervals): New function.
900 (offset_intervals): Use it.
901
7f3f739f
LL
9022011-06-21 Leo Liu <sdl.web@gmail.com>
903
904 * deps.mk (fns.o):
905 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
906 sha512.h.
907
908 * fns.c (secure_hash): Rename from crypto_hash_function and change
909 the first arg to accept symbols.
5b66d427 910 (Fsecure_hash): New primitive.
7f3f739f
LL
911 (syms_of_fns): New symbols.
912
76147d94
DD
9132011-06-20 Deniz Dogan <deniz@dogan.se>
914
915 * process.c (Fset_process_buffer): Clarify return value in
916 docstring.
917
7d7d0045
CY
9182011-06-18 Chong Yidong <cyd@stupidchicken.com>
919
920 * dispnew.c (add_window_display_history): Use BVAR.
921
922 * xdisp.c (debug_method_add): Use BVAR.
923 (check_window_end, dump_glyph_matrix, dump_glyph)
924 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
925
926 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
927 Likewise.
928
929 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
930 check till after the cache is created in init_frame_faces.
931
ff2bc410
SM
9322011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
933
934 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
935
28177add
PE
9362011-06-16 Paul Eggert <eggert@cs.ucla.edu>
937
dd3482fe
PE
938 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
939 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
940 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
941
393d71f3 942 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
943 * fileio.c (Finsert_file_contents):
944 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
945 Remove the old (too-loose) buffer overflow checks.
946 They weren't needed, since make_gap checks for buffer overflow.
947 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
948 The old code merely checked for Emacs fixnum overflow, and relied
949 on undefined (wraparound) behavior. The new code avoids undefined
950 behavior, and also checks for ptrdiff_t and/or size_t overflow.
951
2e6813b0 952 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
953 Tune. Don't use wider integers than needed. Don't use alloca.
954 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 955
599a9e4f
PE
956 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
957
99561444
PE
958 * insdel.c, lisp.h (buffer_overflow): New function.
959 (insert_from_buffer_1, replace_range, replace_range_2):
960 * insdel.c (make_gap_larger):
961 * editfns.c (Finsert_char):
962 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
963
28177add
PE
964 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
965
e69dafad
PE
9662011-06-15 Paul Eggert <eggert@cs.ucla.edu>
967
a7af7fde 968 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 969
b1c46f02
PE
970 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
971 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
972
e69dafad
PE
973 * fileio.c: Don't assume EMACS_INT fits in off_t.
974 (emacs_lseek): New static function.
975 (Finsert_file_contents, Fwrite_region): Use it.
976 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
977
566684ea
PE
978 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
979
e6966cd6
PE
980 * fns.c: Don't overflow int when computing a list length.
981 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
982 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
983 truncation on 64-bit hosts. Check for QUIT every
984 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
985 faster and is responsive enough.
986 (Flength): Report an error instead of overflowing an integer.
987 (Fsafe_length): Return a float if the value is not representable
988 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 989 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 990 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 991
dd0b0efb
PE
992 * alloc.c: Check that resized vectors' lengths fit in fixnums.
993 (header_size, word_size): New constants.
994 (allocate_vectorlike): Don't check size overflow here.
995 (allocate_vector): Check it here instead, since this is the only
996 caller of allocate_vectorlike that could cause overflow.
997 Check that the new vector's length is representable as a fixnum.
998
86fe5cfe
PE
999 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1000 The previous code was bogus. For example, next_almost_prime (32)
1001 returned 39, which is undesirable as it is a multiple of 3; and
1002 next_almost_prime (24) returned 25, which is a multiple of 5 so
1003 why was the code bothering to check for multiples of 7?
1004
80e88859
PE
1005 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1006
4a2f0ad6
PE
1007 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1008
f66c7cf8
PE
1009 Variadic C functions now count arguments with ptrdiff_t.
1010 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1011 Back then I didn't know that the Emacs coding style prefers signed int.
1012 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1013 were being counted with int, which may truncate counts on 64-bit
1014 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1015 * lisp.h (struct Lisp_Subr.function.aMANY)
1016 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1017 Arg counts are now ptrdiff_t, not size_t.
1018 All variadic functions and their callers changed accordingly.
1019 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1020 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1021 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1022 * callint.c (Fcall_interactively): Check arg count for overflow,
1023 to avoid potential buffer overrun. Use signed char, not 'int',
1024 for 'varies' array, so that we needn't bother to check its size
1025 calculation for overflow.
1026 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1027 * eval.c (apply_lambda):
1028 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1029 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1030 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1031
a1759b76
PE
1032 * callint.c (Fcall_interactively): Don't use index var as event count.
1033
d96be9fc
PE
1034 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1035 * mem-limits.h (SIZE): Remove; no longer used.
1036
a690a978 1037 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1038
578c21e6
PE
1039 Remove unnecessary casts.
1040 * xterm.c (x_term_init):
1041 * xfns.c (x_set_border_pixel):
1042 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1043 These aren't needed now that we assume ANSI C.
1044
96f53c6c
PE
1045 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1046 It's more likely to cause problems (due to unsigned overflow)
1047 than to cure them.
1048
83c77d31
PE
1049 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1050
ee2079f1
PE
1051 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1052
6da65536
PE
1053 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1054
7147c4a4
PE
1055 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1056
193e32d9
PE
1057 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1058
e5533da6
PE
1059 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1060
9910e595
PE
1061 GLYPH_CODE_FACE returns EMACS_INT, not int.
1062 * dispextern.h (merge_faces):
1063 * xfaces.c (merge_faces):
01103c44
PE
1064 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1065 Don't assume EMACS_INT fits in int.
9910e595 1066
2638320e
PE
1067 * character.h (CHAR_VALID_P): Remove unused parameter.
1068 * fontset.c, lisp.h, xdisp.c: All uses changed.
1069
045eb8d9
PE
1070 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1071
c1f134b5
PE
1072 * fns.c (concat): Minor tuning based on overflow analysis.
1073 This doesn't fix any bugs. Use int to hold character, instead
1074 of constantly refetching from Emacs object. Use XFASTINT, not
1075 XINT, for value known to be a character. Don't bother comparing
1076 a single byte to 0400, as it's always less.
1077
395fcb93 1078 * floatfns.c (Fexpt):
327eeec8
PE
1079 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1080
abbd3d23
PE
1081 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1082 for characters.
1083
684a03ef
PE
1084 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1085
0fed43f3
PE
1086 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1087 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1088 incorrectly succeed when S was a string, because 4294967386 was
1089 truncated before it was used.
1090
8fd02eb7
PE
1091 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1092 Otherwise, an out-of-range integer could cause undefined behavior
1093 on a 64-bit host.
1094
f8c86b69
PE
1095 * composite.c: Use int, not EMACS_INT, for characters.
1096 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1097 EMACS_INT, for values that are known to be in character range.
1098 This doesn't fix any bugs but is the usual style inside Emacs and
1099 may generate better code on 32-bit machines.
1100
34206dd2
PE
1101 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1102 This is for reasons similar to the recent CHAR_STRING fix.
1103 * charset.c (Fencode_char): Check that character arg is actually
1104 a character. Pass an int to ENCODE_CHAR.
1105 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1106 wider than 'int', as a compile-time check to prevent future regressions
1107 in this area.
1108
c5958d4c 1109 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1110
1111 Make sure a 64-bit char is never passed to CHAR_STRING.
1112 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1113 by silently ignoring the top 32 bits, allowing some values
1114 that were far too large to be valid characters.
1115 * character.h: Include <verify.h>.
1116 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1117 arguments are no wider than unsigned, as a compile-time check
1118 to prevent future regressions in this area.
1119 * data.c (Faset):
01103c44 1120 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1121 (Fsubst_char_in_region):
1122 * fns.c (concat):
1123 * xdisp.c (decode_mode_spec_coding):
1124 Adjust to CHAR_STRING's new requirement.
1125 * editfns.c (Finsert_char, Fsubst_char_in_region):
1126 * fns.c (concat): Check that character args are actually
1127 characters. Without this test, these functions did the wrong
1128 thing with wildly out-of-range values on 64-bit hosts.
1129
d37ca623
PE
1130 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1131 These casts should not be needed on 32-bit hosts, either.
1132 * keyboard.c (read_char):
1133 * lread.c (Fload): Remove casts to unsigned.
1134
ea204efb
PE
1135 * lisp.h (UNSIGNED_CMP): New macro.
1136 This fixes comparison bugs on 64-bit hosts.
1137 (ASCII_CHAR_P): Use it.
1138 * casefiddle.c (casify_object):
01103c44 1139 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1140 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1141 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1142 * dispextern.h (FACE_FROM_ID):
1143 * keyboard.c (read_char): Use UNSIGNED_CMP.
1144
41cb286c
PE
1145 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1146 not to EMACS_INT, to avoid GCC warning.
1147
4a1b9832
PE
1148 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1149
55daad71
PE
1150 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1151 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1152 isn't needed on 32-bit machines.
8f95c75c 1153
01103c44
PE
1154 * buffer.c (Fgenerate_new_buffer_name):
1155 Use EMACS_INT for count, not int.
0ceccced 1156 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1157
1158 * data.c (Qcompiled_function): Now static.
1159
c6f072e7
PE
1160 * window.c (window_body_lines): Now static.
1161
20ce5912
PE
1162 * image.c (gif_load): Rename local to avoid shadowing.
1163
9c4c5f81
PE
1164 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1165 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1166 * alloc.c (make_save_value): Integer argument is now of type
1167 ptrdiff_t, not int.
1168 (mark_object): Use ptrdiff_t, not int.
1169 * lisp.h (pD): New macro.
1170 * print.c (print_object): Use it.
1171
c0c5c8ae
PE
1172 * alloc.c: Use EMACS_INT, not int, to count objects.
1173 (total_conses, total_markers, total_symbols, total_vector_size)
1174 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1175 (total_free_floats, total_floats, total_free_intervals)
1176 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1177 Now EMACS_INT, not int. All uses changed.
1178 (Fgarbage_collect): Compute overall total using a double, so that
1179 integer overflow is less likely to be a problem. Check for overflow
1180 when converting back to an integer.
5a25e253
PE
1181 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1182 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1183 These were 'int' variables that could overflow on 64-bit hosts;
1184 they were never used, so remove them instead of repairing them.
211a0b2a 1185 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1186 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1187 Previously, this ceilinged at INT_MAX, but that doesn't work on
1188 64-bit machines.
e46bb31a 1189 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1190
c78baabf 1191 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1192 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1193 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1194 when a (possibly-narrower) signed value would do just as well.
1195 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1196
c9d624c6
PE
1197 * alloc.c: Catch some string size overflows that we were missing.
1198 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1199 for convenience in STRING_BYTES_MAX.
1200 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1201 The definition here is exact; the one in lisp.h was approximate.
1202 (allocate_string_data): Check for string overflow. This catches
1203 some instances we weren't catching before. Also, it catches
1204 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1205 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1206 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1207
c9d624c6
PE
1208 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1209 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1210 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1211
353032ce
PE
1212 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1213
2bccce07
PE
1214 * alloc.c (Fmake_string): Check for out-of-range init.
1215
0ac30604
SM
12162011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1217
1218 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1219
c195f2de
JD
12202011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1221
1222 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1223 xg_get_default_scrollbar_width.
1224
1225 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1226 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1227 (style_changed_cb): Call update_theme_scrollbar_width and call
1228 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1229 all frames (Bug#8505).
1230 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1231 Call gtk_window_set_resizable if HAVE_GTK3.
1232 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1233 and height if HAVE_GTK3 (Bug#8505).
1234 (scroll_bar_width_for_theme): New variable.
1235 (update_theme_scrollbar_width): New function.
1236 (xg_get_default_scrollbar_width): Move code to
1237 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1238 (xg_initialize): Call update_theme_scrollbar_width.
1239
1240 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1241
1242 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1243
e10ac9f1
MR
12442011-06-12 Martin Rudalics <rudalics@gmx.at>
1245
1246 * frame.c (make_frame): Call other_buffer_safely instead of
1247 other_buffer.
1248
1249 * window.c (temp_output_buffer_show): Call display_buffer with
1250 second argument Vtemp_buffer_show_specifiers and reset latter
1251 immediately after the call.
1252 (Vtemp_buffer_show_specifiers): New variable.
1253 (auto_window_vscroll_p, next_screen_context_lines)
1254 (Vscroll_preserve_screen_position): Remove leading asterisks from
1255 doc-strings.
1256
2d3c217e 12572011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1258
7b7f97e8 1259 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1260 * buffer.c (Qclone_number): Remove for now, as it's unused.
1261 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1262 (record_buffer): Remove unused local.
1263 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1264 (set_frame_buffer_list): Remove; unused.
1265 * frame.h (other_visible_frames): Remove decl.
1266 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1267 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1268 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1269 if HAVE_GPM.
1270 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1271 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1272 Define only if HAVE_GPM.
1273 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1274 (update_hints_inhibit): Remove; never set. All uses removed.
1275 * widgetprv.h (emacsFrameClassRec): Remove decl.
1276 * window.c (delete_deletable_window): Now returns void, since it
1277 wasn't returning anything.
1278 (compare_window_configurations): Remove unused locals.
1279 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1280 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1281 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1282 the same widths as pointers. This follows up on the 2011-05-06 patch.
1283 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1284 * xterm.h: Likewise.
1285 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1286
1384b89e
JB
12872011-06-12 Juanma Barranquero <lekktu@gmail.com>
1288
1289 * makefile.w32-in: Update dependencies.
1290 (LISP_H): Add lib/intprops.h.
1291
1100a63c
CY
12922011-06-11 Chong Yidong <cyd@stupidchicken.com>
1293
1294 * image.c (gif_load): Add animation frame delay to the metadata.
1295 (syms_of_image): Use DEFSYM. New symbol `delay'.
1296
6198ccd0
MR
12972011-06-11 Martin Rudalics <rudalics@gmx.at>
1298
1299 * window.c (delete_deletable_window): Re-add.
1300 (Fset_window_configuration): Rewrite to handle dead buffers and
1301 consequently deletable windows.
1302 (window_tree, Fwindow_tree): Remove. Supply functionality in
1303 window.el.
1304 (compare_window_configurations): Simplify code.
1305
b6e3633c
AS
13062011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1307
1ab0dee5
AS
1308 * image.c (imagemagick_load_image): Fix type mismatch.
1309 (Fimagemagick_types): Likewise.
1310
b6e3633c
AS
1311 * window.h (replace_buffer_in_windows): Declare.
1312
9397e56f
MR
13132011-06-11 Martin Rudalics <rudalics@gmx.at>
1314
1315 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1316 Qclone_number. Remove external declaration of Qdelete_window.
1317 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1318 code.
1319 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1320 Qbuffer_list_update_hook if allowed.
1321 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1322 buffer list implementation.
1323 (other_buffer_safely): New function.
1324 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1325 calls to replace_buffer_in_windows and
1326 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1327 if allowed.
1328 (record_buffer): Inhibit quitting and rewrite using quittable
1329 functions. Run Qbuffer_list_update_hook if allowed.
1330 (Frecord_buffer, Funrecord_buffer): New functions.
1331 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1332 switch-to-buffer to window.el.
1333 (bury-buffer): Move to window.el.
1334 (Vbuffer_list_update_hook): New variable.
1335
1336 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1337 section.
1338
1339 * window.h (resize_frame_windows): Move up in code.
1340 (Fwindow_frame): Remove EXFUN.
1341 (replace_buffer_in_all_windows): Remove prototype.
1342 (replace_buffer_in_windows_safely): Add prototype.
1343
1344 * window.c: Declare Qdelete_window static again. Move down
1345 declaration of select_count.
1346 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1347 (Fother_window): Move to window.el.
1348 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1349 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1350 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1351 window.el.
1352 (replace_buffer_in_windows): Implement by calling
1353 Qreplace_buffer_in_windows.
1354 (replace_buffer_in_all_windows): Remove with some functionality
1355 moved into replace_buffer_in_windows_safely.
1356 (replace_buffer_in_windows_safely): New function.
1357 (select_window_norecord, select_frame_norecord): Move in front
1358 of run_window_configuration_change_hook. Remove now obsolete
1359 declarations.
1360 (Fset_window_buffer): Rewrite doc-string. Call
1361 Qrecord_window_buffer.
1362 (keys_of_window): Move binding for other-window to window.el.
1363
b50691aa
CY
13642011-06-11 Chong Yidong <cyd@stupidchicken.com>
1365
1366 * dispextern.h (struct image): Replace data member, whose int_val
1367 and ptr_val fields were not used by anything, with a single
1368 lisp_val object.
1369
1370 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1371 (gif_clear_image, gif_load, imagemagick_load_image)
1372 (gs_clear_image, gs_load): Callers changed.
1373
3f754b86
PE
13742011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1375
cca69397
PE
1376 * buffer.h: Include <time.h>, for time_t.
1377 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1378
109e28d0
PE
1379 Fix minor problems found by static checking.
1380
60737f02
PE
1381 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1382
4b66faf3
PE
1383 Make identifiers static if they are not used in other modules.
1384 * data.c (Qcompiled_function, Qframe, Qvector):
1385 * image.c (QimageMagick, Qsvg):
1386 * minibuf.c (Qmetadata):
1387 * window.c (resize_window_check, resize_root_window): Now static.
1388 * window.h (resize_window_check, resize_root_window): Remove decls.
1389
109e28d0
PE
1390 * window.c (window_deletion_count, delete_deletable_window):
1391 Remove; unused.
46a4ce9e
PE
1392 (window_body_lines): Now static.
1393 (Fdelete_other_windows_internal): Mark vars as initialized.
1394 Make sure 'resize_failed' is initialized.
1395 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1396 (resize_window_apply): Remove unused local.
1397 * window.h (delete_deletable_window): Remove decl.
1398
109e28d0 1399 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1400 (imagemagick_load_image): Fix pointer signedness problem by changing
1401 last arg from unsigned char * to char *. All uses changed.
1402 Also, fix a local for similar reasons.
1403 Remove unused locals. Remove locals to avoid shadowing.
1404 (fn_rsvg_handle_free): Remove; unused.
1405 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1406 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1407
3f754b86
PE
1408 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1409
2547adb1
CY
14102011-06-10 Chong Yidong <cyd@stupidchicken.com>
1411
1412 * image.c (gif_load): Fix omitted cast error introduced by
1413 2011-06-06 change.
1414
2c8e37d4
MR
14152011-06-10 Martin Rudalics <rudalics@gmx.at>
1416
1417 * window.h (resize_proportionally, orig_total_lines)
1418 (orig_top_line): Remove from window structure.
1419 (set_window_height, set_window_width, change_window_heights)
1420 (Fdelete_window): Remove prototypes.
1421 (resize_frame_windows): Remove duplicate declaration.
1422
440a42e3
EZ
14232011-06-10 Eli Zaretskii <eliz@gnu.org>
1424
1425 * window.h (resize_frame_windows, resize_window_check)
1426 (delete_deletable_window, resize_root_window)
1427 (resize_frame_windows): Declare prototypes.
1428
1429 * window.c (resize_window_apply): Make definition be "static" to
1430 match the prototype.
1431
562dd5e9
MR
14322011-06-10 Martin Rudalics <rudalics@gmx.at>
1433
1434 * window.c: Remove declarations of Qwindow_size_fixed,
1435 window_min_size_1, window_min_size_2, window_min_size,
1436 size_window, window_fixed_size_p, enlarge_window, delete_window.
1437 Remove static from declaration of Qdelete_window, it's
1438 temporarily needed by Fbury_buffer.
1439 (replace_window): Don't assign orig_top_line and
1440 orig_total_lines.
1441 (Fdelete_window, delete_window): Remove. Window deletion is
1442 handled by window.el.
1443 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1444 Fdelete_window calls with calls to Qdelete_window.
1445 (Fdelete_other_windows): Remove. Deleting other windows is
1446 handled by window.el.
1447 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1448 handled in window.el.
1449 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1450 Window minimum sizes are handled in window.el.
1451 (shrink_windows, size_window, set_window_height)
1452 (set_window_width, change_window_heights, window_height)
1453 (window_width, CURBEG, CURSIZE, enlarge_window)
1454 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1455 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1456 handled in window.el.
1457 (make_dummy_parent): Rename to make_parent_window and give it a
1458 second argument horflag.
1459 (make_window): Don't set resize_proportionally any more.
1460 (Fsplit_window): Remove. Windows are split in window.el.
1461 (save_restore_action, save_restore_orig_size)
1462 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1463 Resize mini windows in window.el.
1464 (grow_mini_window, shrink_mini_window): Implement by calling
1465 Qresize_root_window_vertically, resize_window_check and
1466 resize_window_apply.
1467 (saved_window, Fset_window_configuration, save_window_save): Do
1468 not handle orig_top_line, orig_total_lines, and
1469 resize_proportionally.
1470 (window_min_height, window_min_width): Move to window.el.
1471 (keys_of_window): Move bindings for delete-other-windows,
1472 split-window, delete-window and enlarge-window to window.el.
1473
1474 * buffer.c: Temporarily extern Qdelete_window.
1475 (Fbury_buffer): Temporarily call Qdelete_window instead of
1476 Fdelete_window (Fbury_buffer will move to window.el soon).
1477
1478 * frame.c (set_menu_bar_lines_1): Remove code handling
1479 orig_top_line and orig_total_lines.
1480
1481 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1482 set_window_height but set heights directly.
1483 (change_frame_size_1): Use resize_frame_windows.
1484
1485 * xdisp.c (init_xdisp): Don't use set_window_height but set
1486 heights directly.
1487
1488 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1489 resize_frame_windows instead of change_window_heights and run
1490 run_window_configuration_change_hook.
1491
1492 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1493 instead of change_window_heights and run
1494 run_window_configuration_change_hook.
1495
1a13852e
MR
14962011-06-09 Martin Rudalics <rudalics@gmx.at>
1497
1498 * window.c (replace_window): Rename second argument REPLACEMENT to
1499 NEW. New third argument SETFLAG. Rewrite.
1500 (delete_window, make_dummy_parent): Call replace_window with
1501 third argument 1.
1502 (window_list_1): Move down in code.
1503 (run_window_configuration_change_hook): Move set_buffer part
1504 before select_frame_norecord part in order to unwind correctly.
1505 Rename count1 to count.
1506 (recombine_windows, delete_deletable_window, resize_root_window)
1507 (Fdelete_other_windows_internal)
1508 (Frun_window_configuration_change_hook, make_parent_window)
1509 (resize_window_check, resize_window_apply, Fresize_window_apply)
1510 (resize_frame_windows, Fsplit_window_internal)
1511 (Fdelete_window_internal, Fresize_mini_window_internal): New
1512 functions.
1513 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1514
f3d1777e
MR
15152011-06-08 Martin Rudalics <rudalics@gmx.at>
1516
496e208e
MR
1517 * window.h (window): Add some new members to window structure -
1518 normal_lines, normal_cols, new_total, new_normal, clone_number,
1519 splits, nest, prev_buffers, next_buffers.
1520 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1521 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1522
f3d1777e
MR
1523 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1524 Remove.
496e208e
MR
1525 (make_dummy_parent): Set new members of windows structure.
1526 (make_window): Move down in code. Handle new members of window
1527 structure.
1528 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1529 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1530 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1531 (Fset_window_prev_buffers, Fwindow_next_buffers)
1532 (Fset_window_next_buffers, Fset_window_clone_number): New
1533 functions.
1534 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1535 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1536 Doc-string fixes.
1537 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1538 Argument WINDOW can be now internal window too.
1539 (Fwindow_use_time): Move up in code.
1540 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1541 Rewrite doc-string.
1542 (Fset_window_configuration, saved_window)
1543 (Fcurrent_window_configuration, save_window_save): Handle new
1544 members of window structure.
b9e809c2
MR
1545 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1546 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1547 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1548 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1549 Qget_mru_window, Qresize_root_window,
1550 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1551 Qauto_buffer_name; staticpro them.
f3d1777e 1552
abde8f8c
MR
15532011-06-07 Martin Rudalics <rudalics@gmx.at>
1554
1555 * window.c (Fwindow_total_size, Fwindow_left_column)
1556 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1557 (Fwindow_list_1): New functions.
1558 (window_box_text_cols): Replace with window_body_cols.
1559 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1560 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1561 (delete_window, Fset_window_configuration): Call
1562 delete_all_subwindows with window as argument.
1563 (delete_all_subwindows): Take a window as argument and not a
1564 structure. Rewrite.
190b47e6
MR
1565 (window_loop): Remove handling of GET_LRU_WINDOW and
1566 GET_LARGEST_WINDOW.
1567 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1568
1569 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1570 window_box_text_cols. delete_all_subwindows now takes a
1571 Lisp_Object as argument.
abde8f8c
MR
1572
1573 * indent.c (compute_motion, Fcompute_motion): Use
1574 window_body_cols instead of window_box_text_cols.
1575
fa8a67e6
MR
1576 * frame.c (delete_frame): Call delete_all_subwindows with root
1577 window as argument.
1578
a54e3482
DC
15792011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1580
1581 * fns.c (Fputhash): Document return value.
1582
60002bf5
CY
15832011-06-06 Chong Yidong <cyd@stupidchicken.com>
1584
1585 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1586
0c671da6 15872011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1588
b862a52a 1589 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1590
be44ca6c
PE
1591 Check for overflow when converting integer to cons and back.
1592 * charset.c (Fdefine_charset_internal, Fdecode_char):
1593 Use cons_to_unsigned to catch overflow.
1594 (Fencode_char): Use INTEGER_TO_CONS.
1595 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1596 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1597 * data.c (long_to_cons, cons_to_long): Remove.
1598 (cons_to_unsigned, cons_to_signed): New functions.
1599 These signal an error for invalid or out-of-range values.
1600 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1601 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1602 * font.c (Ffont_variation_glyphs):
1603 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1604 * lisp.h: Include <intprops.h>.
1605 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1606 (cons_to_signed, cons_to_unsigned): New decls.
1607 (long_to_cons, cons_to_long): Remove decls.
1608 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1609 (Fprimitive_undo): Use CONS_TO_INTEGER.
1610 * xfns.c (Fx_window_property): Likewise.
1611 * xselect.c: Include <limits.h>.
1612 (x_own_selection, selection_data_to_lisp_data):
1613 Use INTEGER_TO_CONS.
1614 (x_handle_selection_request, x_handle_selection_clear)
1615 (x_get_foreign_selection, Fx_disown_selection_internal)
1616 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1617 (lisp_data_to_selection_data): Use cons_to_unsigned.
1618 (x_fill_property_data): Use cons_to_signed.
1619 Report values out of range.
1620
d1f3d2af
PE
1621 Check for buffer and string overflow more precisely.
1622 * buffer.h (BUF_BYTES_MAX): New macro.
1623 * lisp.h (STRING_BYTES_MAX): New macro.
1624 * alloc.c (Fmake_string):
1625 * character.c (string_escape_byte8):
1626 * coding.c (coding_alloc_by_realloc):
1627 * doprnt.c (doprnt):
1628 * editfns.c (Fformat):
1629 * eval.c (verror):
1630 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1631 since they may not be the same number.
1632 * editfns.c (Finsert_char):
1633 * fileio.c (Finsert_file_contents):
1634 Likewise for BUF_BYTES_MAX.
1635
dd52fcea
PE
1636 * image.c: Use ptrdiff_t, not int, for sizes.
1637 (slurp_file): Switch from int to ptrdiff_t.
1638 All uses changed.
1639 (slurp_file): Check that file size fits in both size_t (for
1640 malloc) and ptrdiff_t (for sanity and safety).
1641
7f9bbdbb
PE
1642 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1643 if b->modtime has its maximal value.
1644
dfe18f82
PE
1645 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1646
84acfcf0
PE
1647 Don't assume time_t can fit into int.
1648 * buffer.h (struct buffer.modtime): Now time_t, not int.
1649 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1650 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1651
ccd9a01a
PE
1652 Minor fixes for signed vs unsigned integers.
1653 * character.h (MAYBE_UNIFY_CHAR):
1654 * charset.c (maybe_unify_char):
1655 * keyboard.c (read_char, reorder_modifiers):
1656 XINT -> XFASTINT, since the integer must be nonnegative.
1657 * ftfont.c (ftfont_spec_pattern):
1658 * keymap.c (access_keymap, silly_event_symbol_error):
1659 XUINT -> XFASTINT, since the integer must be nonnegative.
1660 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1661 since it makes no difference and we prefer signed.
1662 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1663 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1664 nonnegative.
1665
d6d100dd
SM
16662011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1667
1668 * window.h (Fwindow_frame): Declare.
1669
2b6148e4
PE
16702011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1671
1672 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1673 (SPARE_MEMORY): Always define.
1674 (LARGE_REQUEST): Remove.
1675 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1676
f230ecc9
MR
16772011-06-06 Martin Rudalics <rudalics@gmx.at>
1678
727e958e
MR
1679 * lisp.h: Move EXFUNS for Fframe_root_window,
1680 Fframe_first_window and Fset_frame_selected_window to window.h.
1681
1682 * window.h: Move EXFUNS for Fframe_root_window,
1683 Fframe_first_window and Fset_frame_selected_window here from
1684 lisp.h.
1685
1686 * frame.c (Fwindow_frame, Fframe_first_window)
1687 (Fframe_root_window, Fframe_selected_window)
1688 (Fset_frame_selected_window): Move to window.c.
1689 (Factive_minibuffer_window): Move to minibuf.c.
1690 (Fother_visible_frames_p): New function.
1691
1692 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1693
f230ecc9
MR
1694 * window.c (decode_window, decode_any_window): Move up in code.
1695 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1696 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1697 (Fwindow_buffer): Move up and rewrite doc-string.
1698 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1699 (Fwindow_prev): New functions.
727e958e
MR
1700 (Fwindow_frame): Move here from frame.c. Accept any window as
1701 argument.
1702 (Fframe_root_window, Fframe_first_window)
1703 (Fframe_selected_window): Move here from frame.c. Accept frame
1704 or arbitrary window as argument. Update doc-strings.
1705 (Fminibuffer_window): Move up in code.
1706 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1707 (Fset_frame_selected_window): Move here from frame.c.
1708 Marginal rewrite.
727e958e
MR
1709 (Fselected_window, select_window, Fselect_window): Move up in
1710 code. Minor doc-string fixes.
f230ecc9 1711
4d09bcf6
PE
17122011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1713
1714 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1715 Do not assume that spare memory exists; that assumption is valid
1716 only if SYSTEM_MALLOC.
1717 (LARGE_REQUEST): New macro, so that the issue of large requests
1718 is separated from the issue of spare memory.
1719
810928a2
AS
17202011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1721
172418ad
AS
1722 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1723 format. (Bug#8806)
1724
43f862f7
AS
1725 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1726
810928a2
AS
1727 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1728 before statements.
1729
a059fe24
JD
17302011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1731
1732 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1733
1734 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1735
1736 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1737 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1738
989bf368
JB
17392011-06-05 Juanma Barranquero <lekktu@gmail.com>
1740
1741 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1742
4b80f674
CY
17432011-06-04 Chong Yidong <cyd@stupidchicken.com>
1744
1745 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1746 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1747 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1748 New error handlers.
4b80f674
CY
1749 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1750 Obey Vx_select_enable_clipboard_manager. Catch errors in
1751 x_clipboard_manager_save (Bug#8779).
1752 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1753 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1754
99a33b77 17552011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1756
1757 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1758
99a33b77 17592011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1760
1761 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1762 in the current matrix if keep_current_p is non-zero.
1763
8264569d
EZ
17642011-06-04 Eli Zaretskii <eliz@gnu.org>
1765
1766 * bidi.c (bidi_level_of_next_char): Fix last change.
1767
57f97249
EZ
17682011-06-03 Eli Zaretskii <eliz@gnu.org>
1769
fec2107c 1770 Support bidi reordering of text covered by display properties.
57f97249 1771
fec2107c
EZ
1772 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1773 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1774 (bidi_cache_search, bidi_cache_iterator_state)
1775 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1776 (bidi_level_of_next_char, bidi_move_to_visually_next):
1777 Support character positions inside a run of characters covered by a
fec2107c
EZ
1778 display string.
1779 (bidi_paragraph_init, bidi_resolve_explicit_1)
1780 (bidi_level_of_next_char): Call bidi_fetch_char and
1781 bidi_fetch_char_advance instead of FETCH_CHAR and
1782 FETCH_CHAR_ADVANCE.
1783 (bidi_init_it): Initialize new members.
1784 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1785 definitions.
1786 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1787 instead of using explicit *_CHAR codes.
d6d100dd
SM
1788 (bidi_resolve_explicit, bidi_resolve_weak):
1789 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1790 bidirectional text is supported only in multibyte buffers.
1791 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1792 it to initialize the frame_window_p member of struct bidi_it.
1793 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1794 (bidi_resolve_explicit, bidi_resolve_weak)
1795 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1796 bidi_it->nchars is non-positive.
1797 (bidi_level_of_next_char): Don't try to lookup the cache for the
1798 next/previous character if nothing is cached there yet, or if we
1799 were just reseat()'ed to a new position.
c40e2fb2 1800
0e14fe90
EZ
1801 * xdisp.c (set_cursor_from_row): Set start and stop points
1802 according to the row's direction when priming the loop that looks
1803 for the glyph on which to display cursor.
1804 (single_display_spec_intangible_p): Function deleted.
1805 (display_prop_intangible_p): Reimplement to call
1806 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1807 Accept 3 additional arguments needed by handle_display_spec.
1808 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1809 values: lists, `(when COND...)' forms, etc.
1810 (single_display_spec_string_p): Support property values that are
1811 lists with the argument STRING its top-level element.
1812 (display_prop_string_p): Fix the condition for processing a
1813 property that is a list to be consistent with handle_display_spec.
fec2107c 1814 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1815 last portion of handle_display_prop.
1816 (compute_display_string_pos): Accept additional argument
1817 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1818 value of a `display' property is a "replacing spec".
1819 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1820 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1821 the display property, but just return a value indicating whether
1822 the display property will replace the characters it covers.
1823 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1824 frame_window_p members of struct bidi_it.
d6d100dd
SM
1825 (compute_display_string_pos, compute_display_string_end):
1826 New functions.
fec2107c
EZ
1827 (push_it): Accept second argument POSITION, where pop_it should
1828 jump to continue iteration.
1829 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1830
fec2107c
EZ
1831 * keyboard.c (adjust_point_for_property): Adjust the call to
1832 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1833
1834 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1835 (bidi_init_it): Update prototypes.
1836 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1837 (compute_display_string_pos, compute_display_string_end):
1838 Declare prototypes.
fec2107c
EZ
1839 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1840 EMACS_INT.
fc6f18ce 1841
40087514 18422011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1843
57f53182
PE
1844 Malloc failure behavior now depends on size of allocation.
1845 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1846 * lisp.h: Change signatures accordingly.
1847 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1848 All callers changed. (Bug#8762)
1849
1850 * gnutls.c: Use Emacs's memory allocators.
1851 Without this change, the gnutls library would invoke malloc etc.
1852 directly, which causes problems on non-SYNC_INPUT hosts, and which
1853 runs afoul of improving memory_full behavior. (Bug#8761)
1854 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1855 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1856 xfree instead of the default malloc, realloc, free.
1857 (Fgnutls_boot): No need to check for memory allocation failure,
1858 since xmalloc does that for us.
1859
ac32cd99 1860 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1861 * category.c (hash_get_category_set):
1862 * ccl.c (ccl_driver):
1863 * charset.c (Fdefine_charset_internal):
1864 * charset.h (struct charset.hash_index):
1865 * composite.c (get_composition_id, gstring_lookup_cache)
1866 (composition_gstring_put_cache):
1867 * composite.h (struct composition.hash_index):
1868 * dispextern.h (struct image.hash):
1869 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1870 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1871 (hashfn_equal, hashfn_user_defined, make_hash_table)
1872 (maybe_resize_hash_table, hash_lookup, hash_put)
1873 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1874 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1875 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1876 * image.c (make_image, search_image_cache, lookup_image)
1877 (xpm_put_color_table_h):
1878 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1879 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1880 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1881 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1882 * alloc.c (allocate_vectorlike):
1883 Check for overflow in vector size calculations.
1884 * ccl.c (ccl_driver):
1885 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1886 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1887 need to be updated by these changes.
40087514
PE
1888 * fns.c (make_hash_table, maybe_resize_hash_table):
1889 Check for integer overflow with large hash tables.
0de4bb68
PE
1890 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1891 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1892 (SXHASH_REDUCE): New macro.
1893 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1894 Use it instead of discarding useful hash info with large hash values.
1895 (sxhash_float): New function.
1896 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1897 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1898 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1899 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1900 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1901 Adjust signatures to match updated version of code.
1902 (consing_since_gc): Now EMACS_INT, since a single hash table can
1903 use more than INT_MAX bytes.
1904
698d32e2
DN
19052011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1906
1907 Make it possible to build with GCC-4.6+ -O2 -flto.
1908
1909 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1910
fd6fa53f
SM
19112011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1912
1913 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1914 Call minibuffer-inactive-mode.
1915
864db017
JB
19162011-05-31 Juanma Barranquero <lekktu@gmail.com>
1917
1918 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1919 Update dependencies.
1920
2ad0baf4
DN
19212011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1922
1923 * data.c (init_data): Remove code for UTS, this system is not
1924 supported anymore.
1925
4fcc2638
DN
19262011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1927
1928 Don't force ./temacs to start in terminal mode.
1929
1930 * frame.c (make_initial_frame): Initialize faces in all cases, not
1931 only when CANNOT_DUMP is defined.
1932 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1933
c56e0fd5
DN
19342011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1935
1936 * dispnew.c (add_window_display_history): Use const for the string
1937 pointer. Remove declaration, not needed.
1938
333d54da 19392011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1940
55d4c1b2 1941 Use 'inline', not 'INLINE'.
333d54da 1942 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1943 * alloc.c, fontset.c (INLINE): Remove.
1944 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1945 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1946 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1947 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1948 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1949
738db178
DN
19502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1951
1952 Make it possible to run ./temacs.
1953
1954 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1955 syms_of_callproc does the same thing. Remove test for
1956 "initialized", do it in the caller.
1957 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1958
620c53a6
SM
19592011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1960
1961 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1962 (read_minibuf): Use get_minibuffer.
1963 (syms_of_minibuf): Use DEFSYM.
1964 (Qmetadata): New var.
1965 * data.c (Qbuffer): Don't make it static.
1966 (syms_of_data): Use DEFSYM.
1967
e003a292
PE
19682011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1969
1970 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1971 (CCL_CODE_MIN): New macro.
1972
ed008a6d
PE
19732011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1974
3687c2ef
PE
1975 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1976
ed008a6d
PE
1977 * eval.c (Qdebug): Now static.
1978 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1979 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1980 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1981
d66c4c7c
CY
19822011-05-29 Chong Yidong <cyd@stupidchicken.com>
1983
1984 * image.c: Various fixes to ImageMagick code comments.
1985 (Fimagemagick_types): Doc fix.
1986
5fbc2025
PE
19872011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1988
0196f88a
PE
1989 Minor fixes prompted by GCC 4.6.0 warnings.
1990
1991 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1992
5fbc2025
PE
1993 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1994 (x_clipboard_manager_save_all): Move extern decl to ...
1995 * xterm.h: ... here, so that it can be checked for consistency.
1996
1dd3c2d9
CY
19972011-05-29 Chong Yidong <cyd@stupidchicken.com>
1998
1999 * xselect.c (x_clipboard_manager_save_frame)
2000 (x_clipboard_manager_save_all): New functions.
2001 (Fx_clipboard_manager_save): Lisp function deleted.
2002
2003 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2004 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2005
2006 * xterm.h: Update prototype.
2007
5ba6571d
WX
20082011-05-28 William Xu <william.xwl@gmail.com>
2009
2010 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2011 exiting (Bug#8239).
2012
3eaff834
JM
20132011-05-28 Jim Meyering <meyering@redhat.com>
2014
e1900994 2015 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2016 * fns.c (to_uchar): Define.
2017 (crypto_hash_function): Use it to convert some newly-signed
2018 variables to unsigned, to avoid sign-extension bugs. For example,
2019 without this change, (md5 "truc") would evaluate to
2020 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2021 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2022 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2023
0f6990a7
PE
20242011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2025
2026 Integer overflow fixes.
c8a9ca5a 2027
08686060
PE
2028 * dbusbind.c: Serial number integer overflow fixes.
2029 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2030 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2031 to hold a serial number that is too large for a fixnum.
2032 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2033 Check for serial numbers out of range. Decode any serial number
59568bf0 2034 that was so large that it became a float. (Bug#8722)
08686060 2035
2d1fc3c7
PE
2036 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2037 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2038 Use XFASTINT rather than XUINT when numbers are nonnegative.
2039 (xd_append_arg, Fdbus_method_return_internal):
2040 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2041 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2042 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2043 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2044 (Bug#8722)
2d1fc3c7 2045
c8a9ca5a
PE
2046 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2047
519e1d69
PE
2048 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2049
30569699
PE
2050 ccl: add integer overflow checks
2051 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2052 (IN_INT_RANGE): New macros.
2053 (ccl_driver): Use them to check for integer overflow when
2054 decoding a CCL program. Many of the new checks are whether XINT (x)
2055 fits in int; it doesn't always, on 64-bit hosts. The new version
2056 doesn't catch all possible integer overflows, but it's an
847044ea 2057 improvement. (Bug#8719)
30569699 2058
c11285dc
PE
2059 * alloc.c (make_event_array): Use XINT, not XUINT.
2060 There's no need for unsigned here.
2061
fdccd48e
PE
2062 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2063 This follows up to the 2011-05-06 change that substituted uintptr_t
2064 for EMACS_INT. This case wasn't caught back then.
2065
37910ab2
PE
2066 Rework Fformat to avoid integer overflow issues.
2067 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2068 now (part of C89). Include <verify.h>.
2069 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2070 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2071 (Fformat): Avoid the prepass trying to compute sizes; it was only
2072 approximate and thus did not catch overflow reliably. Instead, walk
2073 through the format just once, formatting and computing sizes as we go,
2074 checking for integer overflow at every step, and allocating a larger
2075 buffer as needed. Keep track separately whether the format is
2076 multibyte. Keep only the most-recently calculated precision, rather
2077 than them all. Record whether each argument has been converted to
2078 string. Use EMACS_INT, not int, for byte and char and arg counts.
2079 Support field widths and precisions larger than INT_MAX. Avoid
2080 sprintf's undefined behavior with conversion specifications such as %#d
2081 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2082 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2083 formatting out-of-range floating point numbers with int
9173deec 2084 formats. (Bug#8668)
37910ab2 2085
2e6578fb
PE
2086 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2087
0ae6bdee
PE
2088 * data.c: Avoid integer truncation in expressions involving floats.
2089 * data.c: Include <intprops.h>.
2090 (arith_driver): When there's an integer overflow in an expression
2091 involving floating point, convert the integers to floating point
2092 so that the resulting value does not suffer from catastrophic
2093 integer truncation. For example, on a 64-bit host (* 4
2094 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2095 Do not rely on undefined behavior after integer overflow.
2096
de883a70
PE
2097 merge count_size_as_multibyte, parse_str_to_multibyte
2098 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2099 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2100 Check for integer overflow.
2101 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2102 since it's now a duplicate of the other. This is more of
2103 a character than a buffer op, so better that it's in character.c.
2104 * fns.c, print.c: Adjust to above changes.
2105
2ff916cb
PE
21062011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2107
2108 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2109
f1b54466
PE
21102011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2111
fb1ac845
PE
2112 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2113 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2114 (x_clipboard_manager_save): Now static.
2115 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2116
f1b54466
PE
2117 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2118 (crypto_hash_function): Now static.
2119 Fix pointer signedness problems. Avoid unnecessary initializations.
2120
a9f737ee
CY
21212011-05-27 Chong Yidong <cyd@stupidchicken.com>
2122
2123 * termhooks.h (Vselection_alist): Make it terminal-local.
2124
2125 * terminal.c (create_terminal): Initialize it.
2126
2127 * xselect.c: Support for clipboard managers.
2128 (Vselection_alist): Move to termhooks.h as terminal-local var.
2129 (LOCAL_SELECTION): New macro.
2130 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2131 (symbol_to_x_atom): Remove gratuitous arg.
2132 (x_handle_selection_request, lisp_data_to_selection_data)
2133 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2134 (x_own_selection, x_get_local_selection, x_convert_selection):
2135 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2136 (some_frame_on_display): Delete unused function.
2137 (Fx_own_selection_internal, Fx_get_selection_internal)
2138 (Fx_disown_selection_internal, Fx_selection_owner_p)
2139 (Fx_selection_exists_p): New optional frame arg.
2140 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2141 (x_handle_selection_clear): Don't treat other terminals with the
2142 same keyboard specially. Use the terminal-local Vselection_alist.
2143 (x_clear_frame_selections): Use Frun_hook_with_args.
2144
2145 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2146
2147 * xterm.h: Add support for those atoms.
2148
e067f0c1
CY
21492011-05-26 Chong Yidong <cyd@stupidchicken.com>
2150
2151 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2152 (converted_selections, conversion_fail_tag): New global variables.
2153 (x_selection_request_lisp_error): Free the above.
2154 (x_get_local_selection): Remove unnecessary code.
2155 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2156 of converted selections stored in converted_selections.
2157 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2158 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2159 (x_convert_selection): New function.
2160 (x_handle_selection_event): Simplify.
2161 (x_get_foreign_selection): Don't ignore incoming requests while
2162 waiting for an answer; this will fail when we implement
2163 SAVE_TARGETS, and seems unnecessary anyway.
2164 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2165 (Vx_sent_selection_functions): Doc fix.
2166
0f4aebc0
LL
21672011-05-26 Leo Liu <sdl.web@gmail.com>
2168
2169 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2170
e61124cd
YM
21712011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2172
2173 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2174
2175 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2176 for fringe update if it has periodic bitmap.
2177 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2178 and fringe_bitmap_periodic_p.
2179
2180 * fringe.c (get_fringe_bitmap_data): New function.
2181 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2182 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2183 row. Mark glyph row for fringe update if periodicity changed.
2184
2185 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2186 for fringe update unless it has periodic bitmap.
2187
f16d9837
KH
21882011-05-25 Kenichi Handa <handa@m17n.org>
2189
2190 * xdisp.c (get_next_display_element): Set correct it->face_id for
2191 a static composition.
2192
e1b90ef6
LL
21932011-05-24 Leo Liu <sdl.web@gmail.com>
2194
2195 * deps.mk (fns.o):
2196 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2197
2198 * fns.c (crypto_hash_function, Fsha1): New function.
2199 (Fmd5): Use crypto_hash_function.
2200 (syms_of_fns): Add Ssha1.
2201
7400048f
PE
22022011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2203
2204 * gnutls.c: Remove unused macros.
2205 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2206 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2207 Remove macros that are defined and never used.
2208 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2209
abb71cf4
CY
22102011-05-22 Chong Yidong <cyd@stupidchicken.com>
2211
2212 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2213 (Fx_get_selection_internal): Minor cleanup.
2214 (Fx_own_selection_internal): Rename arguments for consistency with
2215 select.el.
2216
6307db39
PE
22172011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2218
2219 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2220
f3d4e0a4
CY
22212011-05-22 Chong Yidong <cyd@stupidchicken.com>
2222
2223 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2224
4d8ade89
YM
22252011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2226
2227 * dispnew.c (scrolling_window): Don't exclude the case that the
2228 last enabled row in the desired matrix touches the bottom boundary.
2229
32078c8d
GM
22302011-05-21 Glenn Morris <rgm@gnu.org>
2231
2232 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2233 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2234 and add some more files.
32078c8d 2235
7285dc67
EZ
22362011-05-20 Eli Zaretskii <eliz@gnu.org>
2237
2238 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2239 report_file_error introduced by the change from 2011-05-07.
2240
89d1bd22
PE
22412011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2242
2243 * systime.h (Time): Define only if emacs is defined.
2244 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2245 where the include path doesn't have X11/X.h by default. See
2246 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2247
e23640bb 22482011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2249
2250 * composite.c (find_automatic_composition): Fix previous change.
2251
b9704ad9
GM
22522011-05-20 Glenn Morris <rgm@gnu.org>
2253
2254 * lisp.mk: New file, split from Makefile.in.
2255 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2256 (shortlisp): Remove.
2257 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2258
4a720484
GM
22592011-05-19 Glenn Morris <rgm@gnu.org>
2260
2261 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2262 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2263 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2264 (lisp): Set the order to that of loadup.el.
2265 (shortlisp): Make it a copy of $lisp.
2266 (SOME_MACHINE_LISP): Remove.
2267 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2268 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2269
a28d4396
KH
22702011-05-18 Kenichi Handa <handa@m17n.org>
2271
2272 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2273 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2274 (find_automatic_composition): Mostly rewrite for efficiency.
2275
a2b1fa8e
JB
22762011-05-18 Juanma Barranquero <lekktu@gmail.com>
2277
2278 * makefile.w32-in: Update dependencies.
2279
8e1f5610
CS
22802011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2281
2282 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2283 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2284
7025ee00 22852011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2286
cdfa6eab
PE
2287 Fix some integer overflow issues, such as string length overflow.
2288
06d6db33
PE
2289 * insdel.c (count_size_as_multibyte): Check for string overflow.
2290
2b4560a8
PE
2291 * character.c (lisp_string_width): Check for string overflow.
2292 Use EMACS_INT, not int, for string indexes and lengths; in
2293 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2294 the resulting string length overflows an EMACS_INT; instead,
2295 report a string overflow if no precision given. When checking for
2296 precision exhaustion, use a check that cannot possibly have
2297 integer overflow. (Bug#8675)
2298 * character.h (lisp_string_width): Adjust to new signature.
2299
cb93f9be
PE
2300 * alloc.c (string_overflow): New function.
2301 (Fmake_string): Use it. This doesn't change behavior, but saves
2302 a few bytes and will simplify future changes.
2303 * character.c (string_escape_byte8): Likewise.
2304 * lisp.h (string_overflow): New decl.
2305
1a1f3366
PE
2306 Fixups, following up to the user-interface timestamp change.
2307 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2308 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2309 * msdos.c (mouse_get_pos): Likewise.
2310 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2311 * w32gui.h (Time): Define by including "systime.h" rather than by
2312 declaring it ourselves. (Bug#8664)
2313
d4e3e4d3
PE
2314 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2315 * image.c (clear_image_cache): Likewise.
2316
f6a24d19
PE
2317 * term.c (term_mouse_position): Don't assume time_t wraparound.
2318
08dc5ae6
PE
2319 Be more systematic about user-interface timestamps.
2320 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2321 and sometimes 'EMACS_UINT', to represent these timestamps.
2322 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2323 This makes the code easier to follow, and makes it easier to catch
2324 integer overflow bugs such as Bug#8664.
2325 * frame.c (Fmouse_position, Fmouse_pixel_position):
2326 Use Time, not unsigned long, for user-interface timestamps.
2327 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2328 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2329 * keyboard.h (last_event_timestamp): Likewise.
2330 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2331 * menu.h (xmenu_show): Likewise.
2332 * term.c (term_mouse_position): Likewise.
2333 * termhooks.h (struct input_event.timestamp): Likewise.
2334 (struct terminal.mouse_position_hook): Likewise.
2335 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2336 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2337 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2338 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2339 what it was before.
2340 * menu.h, termhooks.h: Include "systime.h", for Time.
2341
8e55734a
PE
2342 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2343 Don't assume that the difference between two unsigned long values
2344 can fit into an integer. At this point, we know button_down_time
2345 <= event->timestamp, so the difference must be nonnegative, so
2346 there's no need to cast the result if double-click-time is
2347 nonnegative, as it should be; check that it's nonnegative, just in
2348 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2349 apart (about 25 days). (Bug#8664)
8e55734a 2350
841f1b75 2351 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2352 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2353
3e26f69c
PE
2354 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2355 that always fit in int. Use a sentinel instead of a counter, to
2356 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2357 * frame.h (struct frame): Use int for menu_bar_items_used
2358 instead of EMACS_INT, since it always fits in int.
3e26f69c 2359
5cc152c0
PE
2360 * menu.c (grow_menu_items): Check for int overflow.
2361
d89eb65e
PE
2362 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2363
5235bd3e
PE
2364 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2365 Before, the code was not consistent. These values cannot exceed
2366 2**31 - 1 so there's no need to make them unsigned.
2367 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2368 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2369 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2370 as modifiers.
2371 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2372
bc827e23
PE
2373 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2374 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2375 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2376 presumably because the widths might not match.
2377
78eb494e
PE
2378 * window.c (size_window): Avoid needless test at loop start.
2379
04f2d78b
CB
23802011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2381
2382 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2383
d2fc7e3d 23842011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2385
2386 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2387
d2fc7e3d 23882011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2389
2390 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2391 `width' to `bar_area_x' and `bar_area_width', respectively.
2392 (x_scroll_run): Take account of fringe background extension.
2393
04f2d78b
CB
2394 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2395 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2396 `bar_area_width', respectively.
2397 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2398 background extension.
2399
79b70037
GM
24002011-05-10 Jim Meyering <meyering@redhat.com>
2401
2402 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2403
2f142cc5
JB
24042011-05-10 Juanma Barranquero <lekktu@gmail.com>
2405
2406 * image.c (Finit_image_library): Return t for built-in image types,
2407 like pbm and xbm. (Bug#8640)
2408
57679c86
AS
24092011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2410
2411 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2412
888c9e86
EZ
24132011-05-07 Eli Zaretskii <eliz@gnu.org>
2414
b0512a1d
EZ
2415 * w32console.c (Fset_screen_color): Doc fix.
2416 (Fget_screen_color): New function.
2417 (syms_of_ntterm): Defsubr it.
2418
7285dc67
EZ
2419 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2420 unlink the temporary file if Fcall_process didn't create it in the
2421 first place.
2422 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2423 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2424 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2425 cue to call_process_cleanup not to close that handle.
2426
4d3fcc8e
BK
24272011-05-07 Ben Key <bkey76@gmail.com>
2428
2429 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2430 one of two shell specific rules, either bootstrap-temacs-CMD or
2431 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2432 to the previous implementation of the bootstrap-temacs rule.
2433 The bootstrap-temacs-CMD rule is similar to the previous
2434 implementation of the bootstrap-temacs rule except that it
2435 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2436 variable.
2437
2438 These changes, along with some changes to nt/configure.bat,
2439 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2440 earlier fix to add support for --cflags and --ldflags options
2441 that include quotes so that it works whether make uses cmd or
2442 sh as the shell.
2443
b4289b64
MA
24442011-05-06 Michael Albinus <michael.albinus@gmx.de>
2445
2446 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2447 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2448 is a constant.
2449 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2450 a string. Handle both cases.
2451 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2452 (Fdbus_register_method): Use Qinvalid_function.
2453
af4c0e28
JB
24542011-05-06 Juanma Barranquero <lekktu@gmail.com>
2455
2456 * makefile.w32-in: Update dependencies.
2457 (LISP_H): Add inttypes.h and stdin.h.
2458 (PROCESS_H): Add unistd.h.
2459
c51453d9
EZ
24602011-05-06 Eli Zaretskii <eliz@gnu.org>
2461
2462 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2463 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2464
8ff0ac3c 24652011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2466
4c4b566b
PE
2467 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2468
aab2b9b5
PE
2469 * term.c (vfatal): Remove stray call to va_end.
2470 It's not needed and the C Standard doesn't allow it here anyway.
2471
c378da0b
PE
2472 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2473 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2474
288b08c7
PE
2475 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2476 bytes.
2477
e3601888
PE
2478 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2479
db6c0e74
PE
2480 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2481
dd5963ea
PE
2482 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2483
88c9450f
PE
2484 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2485
2f9442b8
PE
2486 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2487
c032b5f8
PE
2488 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2489 * charset.c (Fdefine_charset_internal): Don't initialize
2490 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2491 32-bit int (Bug#8600).
a108c10b
PE
2492
2493 * lread.c (read_integer): Be more consistent with string-to-number.
2494 Use string_to_number to do the actual conversion; this avoids
2495 rounding errors and fixes some other screwups. Without this fix,
2496 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2497 (digit_to_number): Move earlier, for benefit of read_integer.
2498 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2499 not a digit in any supported base. (Bug#8602)
a108c10b 2500
ad5f9eea
PE
2501 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2502
aec1708a
PE
2503 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2504 to match comment at start of function. This also removes a
2505 GCC warning about overflow in a 32+64-bit port.
2506
47be4ab5
PE
2507 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2508
371cac43
PE
2509 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2510 Reported by Stefan Monnier in
2511 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2512 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2513 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2514
d01a7826
PE
2515 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2516 (EMACS_UINTPTR): Likewise, with uintptr_t.
2517
7fd47d5c
PE
2518 * lisp.h: Prefer 64-bit EMACS_INT if available.
2519 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2520 on 32-bit hosts that have 64-bit int, so that they can access
2521 large files.
122b0c86
PE
2522 However, temporarily disable this change unless the temporary
2523 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2524
8727937b
PE
2525 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2526
8ac068ac
PE
2527 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2528 This removes an assumption that EMACS_INT and long are the same
2529 width as pointers. The assumption is true for Emacs porting targets
2530 now, but we want to make other targets possible.
2531 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2532 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2533 In the rest of the code, change types of integers that hold casted
2534 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2535 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2536 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2537 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2538 No need to cast type when ORing.
2539 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2540 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2541 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2542 assume EMACS_INT is the same width as char *.
2543 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2544 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2545 Remove no-longer-needed casts.
2546 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2547 (xg_tool_bar_help_callback, xg_make_tool_item):
2548 Use EMACS_INTPTR to hold an integer
2549 that will be cast to void *; this can avoid a GCC warning
2550 if EMACS_INT is not the same width as void *.
2551 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2552 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2553 (current_message_1, set_message_1):
2554 Use a local to convert to proper width without a cast.
2555 * xmenu.c (dialog_selection_callback): Likewise.
2556
ede49d71
PE
2557 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2558 Also, don't assume VALBITS / RAND_BITS is less than 5,
2559 and don't rely on undefined behavior when shifting a 1 left into
2560 the sign bit.
2561 * lisp.h (get_random): Change signature to match.
2562
2f30ecd0
PE
2563 * lread.c (hash_string): Use size_t, not int, for hash computation.
2564 Normally we prefer signed values; but hashing is special, because
2565 it's better to use unsigned division on hash table sizes so that
2566 the remainder is nonnegative. Also, size_t is the natural width
2567 for hashing into memory. The previous code used 'int', which doesn't
2568 retain enough info to hash well into very large tables.
2569 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2570
2a866e7b
PE
2571 * dbusbind.c: Don't possibly lose pointer info when converting.
2572 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2573 Use XPNTR rather than XHASH, so that the high-order bits of
2574 the pointer aren't lost when converting through void *.
2575
51639eac
PE
2576 * eval.c (Fautoload): Don't double-shift a pointer.
2577
92394119
PE
2578 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2579
dbdb9a7c
JB
25802011-05-06 Juanma Barranquero <lekktu@gmail.com>
2581
2582 * gnutls.c (DEF_GNUTLS_FN):
2583 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2584
db7a0b4f
AS
25852011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2586
2587 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2588 marker. (Bug#8610)
2589
f7ff1b0f 25902011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2591
2592 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2593 New version that can reserve upto 2GB of heap space.
2594
f7ff1b0f 25952011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2596
2597 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2598
639c109b
TZ
25992011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2600
2601 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2602 `gnutls_certificate_set_x509_key_file'.
2603
d2127135
JB
26042011-05-05 Juanma Barranquero <lekktu@gmail.com>
2605
2606 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2607 Update dependencies.
2608
e968f4f3
JB
26092011-05-04 Juanma Barranquero <lekktu@gmail.com>
2610
2611 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2612 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2613 Remove unused parameter `fildes'.
2614 * process.c (read_process_output, send_process): Don't pass it.
2615
84d358f0
JB
26162011-05-04 Juanma Barranquero <lekktu@gmail.com>
2617
2618 Fix previous change: the library cache is defined in w32.c.
2619 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2620 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2621
0898ca10
JB
26222011-05-04 Juanma Barranquero <lekktu@gmail.com>
2623
2624 Implement dynamic loading of GnuTLS on Windows.
2625
2626 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2627 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2628 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2629 Declare.
2630
2631 * gnutls.c (Qgnutls_dll): Define.
2632 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2633 (gnutls_*): Declare function pointers.
2634 (init_gnutls_functions): New function to initialize function pointers.
2635 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2636 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2637 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2638 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2639 (emacs_gnutls_write, emacs_gnutls_read)
2640 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2641 (Fgnutls_available_p): New function.
2642 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2643 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2644 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2645
2646 * image.c: Include w32.h.
2647 (Vimage_type_cache): Delete.
2648 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2649 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2650 (w32_delayed_load): Move to w32.c.
2651
2652 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2653
2654 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2655 (w32_delayed_load): Move from image.c. When loading a library, record
2656 its filename in the :loaded-from property of the library id.
2657 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2658 Initialize and staticpro them.
2659 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2660
2661 * process.c: Include lisp.h before w32.h, not after.
2662 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2663 instead of gnutls_record_check_pending.
2664
2665 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2666
ff4de4aa
TZ
26672011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2668
2669 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2670 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2671 as passed in.
2672
abe95abb
JD
26732011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2674
2675 * xterm.c (x_set_frame_alpha): Do not set property on anything
2676 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2677
e16e55d4
JB
26782011-05-02 Juanma Barranquero <lekktu@gmail.com>
2679
2680 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2681
bafcf6a5
JB
26822011-05-02 Juanma Barranquero <lekktu@gmail.com>
2683
2684 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2685 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2686 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2687 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2688 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2689 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2690 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2691 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2692 (Qgnutls_bootprop_callbacks_verify): Make static.
2693
e7a6747f
AS
26942011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2695
19ed11ba
AS
2696 * callproc.c: Indentation fixup.
2697
e7a6747f 2698 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2699 (wait_for_termination, interruptible_wait_for_termination):
2700 Move after wait_for_termination_1.
e7a6747f 2701
1ef14cb4
LMI
27022011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2703
2704 * sysdep.c (interruptible_wait_for_termination): New function
2705 which is like wait_for_termination, but allows keyboard
2706 interruptions.
2707
2708 * callproc.c (Fcall_process): Add (:file "file") as an option for
2709 the STDOUT buffer.
2710 (Fcall_process_region): Ditto.
2711
330d880c
EZ
27122011-04-30 Eli Zaretskii <eliz@gnu.org>
2713
8db90b73
EZ
2714 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2715 rather than `XVECTOR (FOO)->size'.
2716
330d880c
EZ
2717 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2718 inttypes.h, as a gnulib replacement is used if it not available in
2719 system headers.
2720
15cbd324
EZ
27212011-04-21 Eli Zaretskii <eliz@gnu.org>
2722
2723 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2724 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2725 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2726
2727 * coding.c (coding_alloc_by_realloc): Error out if destination
2728 will grow beyond MOST_POSITIVE_FIXNUM.
2729 (decode_coding_emacs_mule): Abort if there isn't enough place in
2730 charbuf for the composition carryover bytes. Reserve an extra
2731 space for up to 2 characters produced in a loop.
2732 (decode_coding_iso_2022): Abort if there isn't enough place in
2733 charbuf for the composition carryover bytes.
2734
27352011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2736
ae940cca
EZ
2737 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2738 aborting when %lld or %lll format is passed.
2739 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2740 %llo or %llx format is passed. (Bug#8545)
2741
03ab8921
EZ
2742 * window.c (window_scroll_line_based): Use a marker instead of
2743 simple variables to record original value of point. (Bug#7952)
2744
afda1437
EZ
2745 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2746 produced by %s or %c overflows available buffer space. (Bug#8545)
2747
f76dee0c
PE
27482011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2749
2750 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2751 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2752
fdc5744d
JB
27532011-04-28 Juanma Barranquero <lekktu@gmail.com>
2754
2755 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2756
638f053a
JB
27572011-04-28 Juanma Barranquero <lekktu@gmail.com>
2758
2759 * keyboard.c (Qdelayed_warnings_hook): Define.
2760 (command_loop_1): Run `delayed-warnings-hook'
2761 if Vdelayed_warnings_list is non-nil.
2762 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2763 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2764
d178f871
EZ
27652011-04-28 Eli Zaretskii <eliz@gnu.org>
2766
2767 * doprnt.c (doprnt): Don't return value smaller than the buffer
2768 size if the message was truncated. (Bug#8545).
2769
b124fd93
JB
27702011-04-28 Juanma Barranquero <lekktu@gmail.com>
2771
2772 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2773 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2774
e810457d
PE
27752011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2776
2777 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2778
ea51cceb
JB
27792011-04-27 Juanma Barranquero <lekktu@gmail.com>
2780
2781 * makefile.w32-in: Update dependencies.
2782
94dcfacf
EZ
27832011-04-27 Eli Zaretskii <eliz@gnu.org>
2784
2785 Improve `doprnt' and its usage. (Bug#8545)
2786 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2787 `format_end'. Remove support for %l as a conversion specifier.
2788 Don't use xrealloc. Improve diagnostics when the %l size modifier
2789 is used. Update the commentary.
2790
2791 * eval.c (verror): Simplify calculation of size_t.
2792
2793 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2794 messages.
2795
f61f41d7
PE
27962011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2797
2798 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2799 change.
2800
96fb4434
PE
28012011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2802
2803 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2804 This makes this file independent of the recent pseudovector change.
2805
671875da 28062011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2807
69e9b5a3
PE
2808 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2809
b5f869a7 2810 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2811 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2812 Remove unused local.
c8926152 2813 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2814
841a1577 2815 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2816 GCC 4.6.0 optimizes based on type-based alias analysis.
2817 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2818 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2819 != &v->size, and therefore "v->size = 1; b->size = 2; return
2820 v->size;" must therefore return 1. This assumption is incorrect
2821 for Emacs, since it type-puns struct Lisp_Vector * with many other
2822 types. To fix this problem, this patch adds a new type struct
f904488f 2823 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2824 and pseudovectors, and helps optimizing compilers not get fooled
2825 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2826 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2827 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2828 the size member.
eab3844f
PE
2829 (XSETPVECTYPE): Rewrite in terms of new macro.
2830 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2831 This is a bit clearer, and further avoids the possibility of
2832 undesirable aliasing.
2833 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2834 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2835 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2836 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2837 (ASIZE): Now uses header.size rather than size.
2838 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2839 to avoid the hassle of writing XVECTOR (foo)->header.size.
2840 (struct vectorlike_header): New type.
eab3844f
PE
2841 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2842 object, to help avoid aliasing.
2843 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2844 (SUBRP): Likewise, since Lisp_Subr is a special case.
2845 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2846 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2847 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2848 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2849 changed to be "header.size" and "header.next".
2850 * buffer.h (struct buffer): Likewise.
2851 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2852 * frame.h (struct frame): Likewise.
2853 * process.h (struct Lisp_Process): Likewise.
2854 * termhooks.h (struct terminal): Likewise.
2855 * window.c (struct save_window_data, struct saved_window): Likewise.
2856 * window.h (struct window): Likewise.
2857 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2858 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2859 * buffer.c (init_buffer_once): Likewise.
2860 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2861 special case.
2862 * process.c (Fformat_network_address): Use local var for size,
2863 for brevity.
2864
0df1eac5
PE
2865 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2866
847ab9d1 2867 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2868 * data.c (atof): Remove decl; no longer used or needed.
2869 (digit_to_number): Move to lread.c.
2870 (Fstring_to_number): Use new string_to_number function, to be
2871 consistent with how the Lisp reader treats infinities and NaNs.
2872 Do not assume that floating-point numbers represent EMACS_INT
2873 without losing information; this is not true on most 64-bit hosts.
2874 Avoid double-rounding errors, by insisting on integers when
2875 parsing non-base-10 numbers, as the documentation specifies.
2876 * lisp.h (string_to_number): New decl, replacing ...
2877 (isfloat_string): Remove.
bc0a5c13 2878 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2879 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2880 appears to have been a coding error. Similarly, do not accept
2881 strings like +-1e0 as floating point numbers. Do not report
2882 overflow for integer overflows unless the base is not 10 which
2883 means we have no simple and reliable way to continue.
2884 Break out the floating-point parsing into a new
2885 function string_to_number, so that Fstring_to_number parses
2886 floating point numbers consistently with the Lisp reader.
04f2d78b 2887 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2888 (E_CHAR, EXP_INT): Remove, replacing with ...
2889 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2890 (string_to_number): New function, replacing isfloat_string.
2891 This function checks for valid syntax and produces the resulting
2892 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2893 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2894 so that overflow for non-base-10 numbers is reported only when
2895 there's no portable and simple way to convert to floating point.
452f4150 2896
67769ffc
PE
2897 * textprop.c (set_text_properties_1): Rewrite for clarity,
2898 and to avoid GCC warning about integer overflow.
2899
c20db43f
PE
2900 * intervals.h (struct interval): Use EMACS_INT for members
2901 where EMACS_UINT might cause problems. See
2902 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2903 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2904 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2905 All uses changed.
37aa2f85
PE
2906 (offset_intervals): Tell GCC not to worry about length overflow
2907 when negating a negative length.
c20db43f 2908
2538aa2f
PE
2909 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2910 (overrun_check_free): Likewise.
2911
f2d3008d
PE
2912 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2913 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2914 word size.
2915
ec8df744
PE
2916 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2917 (gnutls_make_error): Rename local to avoid shadowing.
2918 (gnutls_emacs_global_deinit): ifdef out; not used.
2919 (Fgnutls_boot): Use const for pointer to readonly storage.
2920 Comment out unused local. Fix pointer signedness problems.
2921
640ee02d
PE
2922 * lread.c (openp): Don't stuff size_t into an 'int'.
2923 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2924 about possible signed overflow.
2925
6048fb2a
PE
2926 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2927 (GDK_KEY_g): Don't define if already defined.
2928 (xg_prepare_tooltip): Avoid pointer signedness problem.
2929 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2930
fa3c87e1
PE
2931 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2932 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2933
2172544b
PE
2934 * xfns.c (Fx_window_property): Simplify a bit,
2935 to make a bit faster and to avoid GCC 4.6.0 warning.
2936 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2937
9b821a21
PE
2938 * fns.c (internal_equal): Don't assume size_t fits in int.
2939
3c616cfa
PE
2940 * alloc.c (compact_small_strings): Tighten assertion a little.
2941
c2982e87
PE
2942 Replace pEd with more-general pI, and fix some printf arg casts.
2943 * lisp.h (pI): New macro, generalizing old pEd macro to other
2944 conversion specifiers. For example, use "...%"pI"d..." rather
2945 than "...%"pEd"...".
2946 (pEd): Remove. All uses replaced with similar uses of pI.
2947 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2948 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2949 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2950 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2951 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2952 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2953 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2954 64-bit hosts.
2955 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2956 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2957 * print.c (safe_debug_print, print_object): Likewise.
2958 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2959 to int.
6f04d126
PE
2960 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2961 avoiding the 0 flag, which is not portable.
c2982e87
PE
2962 * process.c (Fmake_network_process): Use pI to avoid cast.
2963 * region-cache.c (pp_cache): Likewise.
2964 * xdisp.c (decode_mode_spec): Likewise.
2965 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2966 behavior on 64-bit hosts with printf arg.
6f04d126 2967 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2968 (x_stop_queuing_selection_requests): Likewise.
2969 (x_get_window_property): Don't truncate byte count to an 'int'
2970 when tracing.
0b432f21 2971
5e073ec7
PE
2972 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2973 here, since it parses constructs like leading '-' and spaces,
2974 which are not wanted; and it overflows with large numbers.
2975 Instead, simply match F[0-9]+, which is what is wanted anyway.
2976
36372bf9
PE
2977 * alloc.c: Remove unportable assumptions about struct layout.
2978 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2979 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2980 (allocate_vectorlike, make_pure_vector): Use the new macros,
2981 plus offsetof, to remove unportable assumptions about struct layout.
2982 These assumptions hold on all porting targets that I know of, but
2983 they are not guaranteed, they're easy to remove, and removing them
2984 makes further changes easier.
2985
0b432f21
PE
2986 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2987 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2988 (string_overrun_cookie): Now const. Use initializers that
2989 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2990 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2991 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2992 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2993 multiple of sizeof (EMACS_INT); it need not be, if
2994 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2995 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2996
895009e1
JB
29972011-04-26 Juanma Barranquero <lekktu@gmail.com>
2998
2999 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3000
6a7a1b0b
TZ
30012011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3002
3003 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3004 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3005 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3006
841a1577 30072011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3008
3009 * lisp.h (Qdebug): List symbol.
895009e1 3010 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3011 * keyboard.c (debug-on-event): New variable.
3012 (handle_user_signal): Break into debugger when debug-on-event
3013 matches the current signal symbol.
3014
f2d3ba6f
DN
30152011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3016
3017 * alloc.c (check_sblock, check_string_bytes)
3018 (check_string_free_list): Convert to standard C.
3019
42ce4c63
TZ
30202011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3021
3022 * w32.c (emacs_gnutls_push): Fix typo.
3023
825cd63c
EZ
30242011-04-25 Eli Zaretskii <eliz@gnu.org>
3025
fb11d64d
EZ
3026 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3027 "cast to pointer from integer of different size".
3028
825cd63c
EZ
3029 Improve doprnt and its use in verror. (Bug#8545)
3030 * doprnt.c (doprnt): Document the set of format control sequences
3031 supported by the function. Use SAFE_ALLOCA instead of always
3032 using `alloca'.
3033
3034 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3035 is one byte too soon. Don't use xrealloc; instead xfree and
3036 xmalloc anew.
3037
e061a11b
TZ
30382011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3039
3040 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3041 callbacks stage.
3042
3043 * gnutls.c: Renamed global_initialized to
3044 gnutls_global_initialized. Added internals for the
3045 :verify-hostname-error, :verify-error, and :verify-flags
3046 parameters of `gnutls-boot' and documented those parameters in the
3047 docstring. Start callback support.
9173deec
JB
3048 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3049 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3050 on error. Return error code.
e061a11b
TZ
3051 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3052 (emacs_gnutls_read): Likewise.
3053 (Fgnutls_boot): Return handshake error code.
3054 (emacs_gnutls_handle_error): New function.
3055 (wsaerror_to_errno): Likewise.
3056
3057 * w32.h (emacs_gnutls_pull): Add prototype.
3058 (emacs_gnutls_push): Likewise.
3059
3060 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3061 (emacs_gnutls_push): Likewise.
3062
30632011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3064
3065 * process.c (wait_reading_process_output): Check if GnuTLS
3066 buffered some data internally if no FDs are set for TLS
3067 connections.
3068
3069 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3070 (LIBS): Link to USER_LIBS.
3071 ($(BLD)/gnutls.$(0)): New target.
3072
fa6996bc
EZ
30732011-04-24 Eli Zaretskii <eliz@gnu.org>
3074
eb35682e
EZ
3075 * xdisp.c (handle_single_display_spec): Rename the
3076 display_replaced_before_p argument into display_replaced_p, to
3077 make it consistent with the commentary. Fix typos in the
3078 commentary.
3079
e2ad650c
EZ
3080 * textprop.c (syms_of_textprop): Remove dead code.
3081 (copy_text_properties): Delete obsolete commentary about an
3082 interface that was deleted long ago. Fix typos in the description
3083 of arguments.
3084
1b2de274
EZ
3085 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3086 to changes in oldXMenu/XMenu.h from 2011-04-16.
3087 <menu_help_message, prev_menu_help_message>: Constify.
3088 (IT_menu_make_room): menu->help_text is now `const char **';
3089 adjust.
3090
3091 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3092 to changes in oldXMenu/XMenu.h from 2011-04-16.
3093 (struct XMenu): Declare `help_text' `const char **'.
3094
3095 * xfaces.c <Qunspecified>: Make extern again.
3096
3097 * syntax.c: Include sys/types.h before including regex.h, as
3098 required by Posix.
3099
762b15be
EZ
3100 * doc.c (get_doc_string): Improve the format passed to `error'.
3101
3102 * doprnt.c (doprnt): Improve commentary.
3103
3104 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3105
3106 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3107 them with etags.
3108
f1052e5d
EZ
3109 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3110 changes in globals.h immediately force recompilation.
762b15be
EZ
3111 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3112 $(CURDIR)/s/ms-w32.h.
3113 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3114
fa6996bc
EZ
3115 * character.c (Fchar_direction): Function deleted.
3116 (syms_of_character): Don't defsubr it.
3117 <char-direction-table>: Deleted.
3118
e6c3da20
EZ
31192011-04-23 Eli Zaretskii <eliz@gnu.org>
3120
3121 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3122 * doprnt.c: Include limits.h.
3123 (SIZE_MAX): New macro.
04f2d78b
CB
3124 (doprnt): Return a size_t value. 2nd arg is now size_t.
3125 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3126 Improve overflow protection. Support `l' modifier for integer
3127 conversions. Support %l conversion. Don't assume an EMACS_INT
3128 argument for integer conversions and for %c.
3129
3130 * lisp.h (doprnt): Restore prototype.
3131
3132 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3133 $(SRC)/character.h.
3134
3135 * Makefile.in (base_obj): Add back doprnt.o.
3136
3137 * deps.mk (doprnt.o): Add back prerequisites.
3138 (callint.o): Depend on character.h.
3139
3140 * eval.c (internal_lisp_condition_case): Include the handler
3141 representation in the error message.
3142 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3143 when breaking from the loop.
3144
3145 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3146
3147 * callint.c (Fcall_interactively): When displaying error message
3148 about invalid control letter, pass the character's codepoint, not
3149 a pointer to its multibyte form. Improve display of the character
3150 in octal and display also its hex code.
3151
3152 * character.c (char_string): Use %x to display the (unsigned)
3153 codepoint of an invalid character, to avoid displaying a bogus
3154 negative value.
3155
3156 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3157 `error', not SYMBOL_NAME itself.
3158
3159 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3160 character arguments to `error'.
3161
3162 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3163 to `error' in error message about FINAL_CHAR argument. Make sure
3164 FINAL_CHAR is a character, and use %c when it is passed as
3165 argument to `error'.
3166
4ffd0d6b 31672011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3168
3169 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3170
3171 * w32.c: Include <time.h>.
3172 (sys_localtime): New function.
3173
4ffd0d6b 31742011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3175
3176 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3177
4ffd0d6b 3178 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3179
4ffd0d6b 31802011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3181
4ffd0d6b
GM
3182 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3183 zombies (Bug#8467).
aac0c6e3 3184
04c56954
EZ
31852011-04-19 Eli Zaretskii <eliz@gnu.org>
3186
3187 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3188 gl_state.e_property when gl_state.object is Qt.
3189
3190 * insdel.c (make_gap_larger): Remove limitation of buffer size
3191 to <= INT_MAX.
3192
16a43933
CY
31932011-04-18 Chong Yidong <cyd@stupidchicken.com>
3194
3195 * xdisp.c (lookup_glyphless_char_display)
3196 (produce_glyphless_glyph): Handle cons cell entry in
3197 glyphless-char-display.
3198 (Vglyphless_char_display): Document it.
3199
3200 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3201 glyphless-char-display.
3202
4581706e
CY
32032011-04-17 Chong Yidong <cyd@stupidchicken.com>
3204
3205 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3206
3207 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3208
3209 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3210 definition for no-X builds.
3211
4887c6e2 32122011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3213
fd35b6f9
PE
3214 Static checks with GCC 4.6.0 and non-default toolkits.
3215
5c1ccb01
PE
3216 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3217
006c5daa
PE
3218 * process.c (keyboard_bit_set): Define only if SIGIO.
3219 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3220 (send_process): Repair possible setjmp clobbering.
3221
efc736d3
PE
3222 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3223
4e2fe2e6
PE
3224 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3225
f97334a2
PE
3226 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3227
4e75f29d
PE
3228 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3229 Define only if needed.
3230
90efadd1
PE
3231 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3232 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3233 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3234
3c647824
PE
3235 * dispextern.h (struct redisplay_interface): Rename param
3236 to avoid shadowing.
e264f262 3237 * termhooks.h (struct terminal): Likewise.
761383f4 3238 * xterm.c (xembed_send_message): Likewise.
3c647824 3239
b58c5c4a
PE
3240 * insdel.c (make_gap_smaller): Define only if
3241 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3242
cad59032
PE
3243 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3244 it.
3245
c339dc2e
PE
3246 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3247 so that we aren't warned about unused symbols.
3248
91a3e27b
PE
3249 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3250
399c71d3 3251 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3252
8ffc96f5
PE
3253 * xfns.c (x_real_positions): Mark locals as initialized.
3254
eef9bc79
PE
3255 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3256
098db9dd
PE
3257 * xterm.c: Fix problems found by static analysis with other toolkits.
3258 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3259 (x_dispatch_event): Declare static if USE_GTK, and
3260 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3261 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3262 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3263 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3264 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3265
eb18f6cc
PE
3266 * xmenu.c (menu_help_callback): Pointer type fixes.
3267 Use const pointers when pointing at readonly data. Avoid pointer
3268 signedness clashes.
3269 (FALSE): Remove unused macro.
3270 (update_frame_menubar): Remove unused decl.
3271
1fe72bf8
PE
3272 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3273
60d9e1db
PE
3274 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3275 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3276 (single_menu_item): Rename local to avoid shadowing.
3277
39261c26
PE
3278 * keyboard.c (make_lispy_event): Remove unused local var.
3279
018c5e19
PE
3280 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3281 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3282
63d2b86e
PE
3283 * bitmaps: Change bitmaps from unsigned char back to the X11
3284 compatible char. Avoid the old compiler warnings about
3285 out-of-range initializers by using, for example, '\xab' rather
3286 than 0xab.
3287
aefd87e1
PE
3288 * xgselect.c (xgselect_initialize): Check vs interface
3289 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3290
bf501fb9
PE
3291 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3292
e9829fdf
PE
3293 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3294 to read-only memory.
3295
1086c095
PE
3296 * fns.c (vector): Remove; this old hack is no longer needed.
3297
2baccd04 3298 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3299 Remove unused var.
dde42981 3300 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3301
72391843 3302 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3303
436c16df 3304 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3305 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3306 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3307
92bb796d 3308 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3309 (x_term_init): Remove local to avoid shadowing.
92bb796d 3310
764430a3 3311 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3312
3313 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3314 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3315
d1dfb56c
EZ
33162011-04-16 Eli Zaretskii <eliz@gnu.org>
3317
c4354cb4
EZ
3318 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3319
d1dfb56c
EZ
3320 Fix regex.c, syntax.c and friends for buffers > 2GB.
3321 * syntax.h (struct gl_state_s): Declare character position members
3322 EMACS_INT.
3323
3324 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3325
04f2d78b
CB
3326 * textprop.c (verify_interval_modification, interval_of):
3327 Declare arguments EMACS_INT.
d1dfb56c
EZ
3328
3329 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3330 EMACS_INT.
3331
3332 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3333
3334 * indent.c (Fvertical_motion): Local variable it_start is now
3335 EMACS_INT.
3336
3337 * regex.c (re_match, re_match_2, re_match_2_internal)
3338 (bcmp_translate, regcomp, regexec, print_double_string)
3339 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3340 (re_compile_pattern, re_exec): Declare arguments and local
3341 variables `size_t' and `ssize_t' and return values `regoff_t', as
3342 appropriate.
3343 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3344 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3345 <compile_stack_type>: `size' and `avail' are now `size_t'.
3346
3347 * regex.h <regoff_t>: Use ssize_t, not int.
3348 (re_search, re_search_2, re_match, re_match_2): Arguments that
3349 specify buffer/string position and length are now ssize_t and
3350 size_t. Return type is regoff_t.
3351
613052cd
BK
33522011-04-16 Ben Key <bkey76@gmail.com>
3353
3354 * nsfont.m: Fixed bugs in ns_get_family and
3355 ns_descriptor_to_entity that were caused by using free to
3356 deallocate memory blocks that were allocated by xmalloc (via
3357 xstrdup). This caused Emacs to crash when compiled with
3358 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3359 --enable-checking=xmallocoverrun). xfree is now used to
3360 deallocate these memory blocks.
3361
4170f62f 33622011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3363
71b41406
PE
3364 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3365
9587a89d
PE
3366 emacs_write: Accept and return EMACS_INT for sizes.
3367 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3368 et seq.
3369 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3370 Accept and return EMACS_INT.
3371 (emacs_gnutls_write): Return the number of bytes written on
3372 partial writes.
3373 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3374 (emacs_read, emacs_write): Remove check for negative size, as the
3375 Emacs source code has been audited now.
9587a89d
PE
3376 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3377 (emacs_read, emacs_write): Use it.
273a5f82
PE
3378 * process.c (send_process): Adjust to the new signatures of
3379 emacs_write and emacs_gnutls_write. Do not attempt to store
3380 a byte offset into an 'int'; it might overflow.
9587a89d 3381 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3382
3e047f51
PE
3383 * sound.c: Don't assume sizes fit in 'int'.
3384 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3385 Return EMACS_INT, not int.
3e047f51 3386 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3387 Accept EMACS_INT, not int.
3388 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3389 record read return values.
3390
cc39a9db
BK
33912011-04-15 Ben Key <bkey76@gmail.com>
3392
c9d0ec6d
JB
3393 * keyboard.c (Qundefined): Don't declare static since it is used
3394 in nsfns.m.
3395 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3396 static since they are used in nsfont.m.
cc39a9db 3397
6c60eb9f
SM
33982011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3399
3400 * process.c (Qprocessp): Don't declare static.
3401 * lisp.h (Qprocessp): Declare again.
3402
7990b61a
JB
34032011-04-15 Juanma Barranquero <lekktu@gmail.com>
3404
3405 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3406
5d4cb038
PE
34072011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3408
8bd7b830 3409 Improve C-level modularity by making more things 'static'.
cd64ea1d 3410
e3b27b31
PE
3411 Don't publish debugger-only interfaces to other modules.
3412 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3413 (verify_bytepos, count_markers): Move decls to the only modules
3414 that need them.
3415 * region-cache.h (pp_cache): Likewise.
3416 * window.h (check_all_windows): Likewise.
3417 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3418
5d4cb038
PE
3419 * sysdep.c (croak): Now static, if
3420 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3421 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3422
3423 * alloc.c (refill_memory_reserve): Now static if
3424 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3425 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3426
e87b6180
PE
3427 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3428 Define only if USE_LUCID.
3429
ac64929e
PE
3430 * xrdb.c (x_customization_string, x_rm_string): Now static.
3431
6f37259d
PE
3432 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3433 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3434
1683e3ab
PE
3435 * xdisp.c (draw_row_with_mouse_face): Now static.
3436 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3437
de9c2632
PE
3438 * window.h (check_all_windows): Mark externally visible.
3439
2b96acb7
PE
3440 * window.c (window_deletion_count): Now static.
3441
3442 * undo.c: Make symbols static if they're not exported.
3443 (last_undo_buffer, last_boundary_position, pending_boundary):
3444 Now static.
3445
50436f33
PE
3446 * textprop.c (interval_insert_behind_hooks): Now static.
3447 (interval_insert_in_front_hooks): Likewise.
3448
64520e5c
PE
3449 * term.c: Make symbols static if they're not exported.
3450 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3451 (max_frame_lines, tty_set_terminal_modes):
3452 (tty_reset_terminal_modes, tty_turn_off_highlight):
3453 (get_tty_terminal): Now static.
3454 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3455 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3456 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3457 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3458 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3459
1fa53021
PE
3460 * sysdep.c: Make symbols static if they're not exported.
3461 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3462 Now static.
3463 (sigprocmask_set, full_mask): Remove; unused.
3464 (wait_debugging): Mark as visible.
3465 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3466 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3467
d4b43b22
PE
3468 * syntax.c (syntax_temp): Define only if !__GNUC__.
3469
b7c513d0
PE
3470 * sound.c (current_sound_device, current_sound): Now static.
3471
989b29ad
PE
3472 * search.c (searchbufs, searchbuf_head): Now static.
3473
13a55a78
PE
3474 * scroll.c (scroll_cost): Remove; unused.
3475 * dispextern.h (scroll_cost): Remove decl.
3476
de68a1fc
PE
3477 * region-cache.h (pp_cache): Mark as externally visible.
3478
40ccffa6
PE
3479 * process.c: Make symbols static if they're not exported.
3480 (process_tick, update_tick, create_process, chan_process):
3481 (Vprocess_alist, proc_buffered_char, datagram_access):
3482 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3483 (deactivate_process): Mark defn as static, as well as decl.
3484 * lisp.h (create_process): Remove decl.
3485 * process.h (chan_process, Vprocess_alist): Remove decls.
3486
ad64fc97
PE
3487 * print.c: Make symbols static if they're not exported.
3488 (print_depth, new_backquote_output, being_printed, print_buffer):
3489 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3490 (print_interval, print_number_index, initial_stderr_stream):
3491 Now static.
3492 * lisp.h (Fprinc): Remove decl.
3493 (debug_output_compilation_hack): Mark as externally visible.
3494
adddb265
PE
3495 * sysdep.c (croak): Move decl from here to syssignal.h.
3496 * syssignal.h (croak): Put it here, so the API can be checked when
3497 'croak' is called from dissociate_if_controlling_tty.
3498
1717ede2
PE
3499 * minibuf.c: Make symbols static if they're not exported.
3500 (minibuf_save_list, choose_minibuf_frame): Now static.
3501 * lisp.h (choose_minibuf_frame): Remove decl.
3502
fa5fb2bc
PE
3503 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3504
1e3890d1
PE
3505 * lread.c: Make symbols static if they're not exported.
3506 (read_objects, initial_obarray, oblookup_last_bucket_number):
3507 Now static.
3508 (make_symbol): Remove; unused.
3509 * lisp.h (initial_obarray, make_symbol): Remove decls.
3510
8a1414fa
PE
3511 * keyboard.c: Make symbols static if they're not exported.
3512 (single_kboard, recent_keys_index, total_keys, recent_keys):
3513 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3514 (this_single_command_key_start, echoing, last_auto_save):
3515 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3516 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3517 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3518 (Vlispy_mouse_stem, double_click_count):
3519 Now static.
3520 (force_auto_save_soon): Define only if SIGDANGER.
3521 (ignore_mouse_drag_p): Now static if
3522 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3523 (print_help): Remove; unused.
3524 (stop_character, last_timer_event): Mark as externally visible.
3525 * keyboard.h (ignore_mouse_drag_p): Declare only if
3526 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3527 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3528 * lisp.h (echoing): Remove decl.
3529 (force_auto_save_soon): Declare only if SIGDANGER.
3530 * xdisp.c (redisplay_window): Simplify code, to make it more
3531 obvious that ignore_mouse_drag_p is not accessed if !defined
3532 USE_GTK && !defined HAVE_NS.
3533
93ea6e8f
PE
3534 * intervals.c: Make symbols static if they're not exported.
3535 (merge_properties_sticky, merge_interval_right, delete_interval):
3536 Now static.
3537 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3538
77382fcc
PE
3539 * insdel.c: Make symbols static if they're not exported.
3540 However, leave prepare_to_modify_buffer alone. It's never
3541 called from outside this function, but that appears to be a bug.
3542 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3543 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3544 (adjust_after_replace_noundo): Remove; unused.
3545 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3546 (signal_before_change): Remove decls.
77382fcc 3547
9306c32e
PE
3548 * indent.c (val_compute_motion, val_vmotion): Now static.
3549
cd44d2eb
PE
3550 * image.c: Make symbols static if they're not exported.
3551 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3552 if USE_GTK.
3553 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3554 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3555
ad9a7a06
PE
3556 * fringe.c (standard_bitmaps): Now static.
3557 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3558
81626931
PE
3559 * frame.c: Make symbols static if they're not exported.
3560 (x_report_frame_params, make_terminal_frame): Now static.
3561 (get_frame_param): Now static, unless HAVE_NS.
3562 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3563 (x_get_resource_string): Remove; not used.
3564 * frame.h (make_terminal_frame, x_report_frame_params):
3565 (x_get_resource_string); Remove decls.
3566 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3567 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3568
239f9db9
PE
3569 * font.c, fontset.c: Make symbols static if they're not exported.
3570 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3571 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3572 * font.c (font_close_object): Now static.
3573 * font.h (font_close_object): Remove.
3574 * fontset.c (FONTSET_OBJLIST): Remove.
3575 (free_realized_fontset) #if-0 the body, which does nothing.
3576 (face_suitable_for_char_p): #if-0, as it's never called.
3577 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3578 * xfaces.c (face_at_string_position):
3579 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3580 since 0 is always ASCII.
3581
dfcf3579
PE
3582 * fns.c (weak_hash_tables): Now static.
3583
5045092b
PE
3584 * fileio.c: Make symbols static if they're not exported.
3585 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3586 (Vwrite_region_annotation_buffers): Now static.
3587
57a96f5c
PE
3588 * eval.c: Make symbols static if they're not exported.
3589 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3590 * lisp.h (backtrace_list): Remove decl.
3591
35f08c38
PE
3592 * emacs.c: Make symbols static if they're not exported.
3593 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3594 (fatal_error_code, fatal_error_signal_hook, standard_args):
3595 Now static.
3596 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3597 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3598 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3599 * lisp.h (fatal_error_signal_hook): Remove decl.
3600 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3601
f44bd759
PE
3602 * editfns.c: Move a (normally-unused) function to its only use.
3603 * editfns.c, lisp.h (get_operating_system_release): Remove.
3604 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3605 worth the hassle of breaking this out.
3606
b532497d
PE
3607 * xterm.c: Make symbols static if they're not exported.
3608 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3609 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3610 (x_destroy_window, x_delete_display):
3611 Now static.
3612 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3613 (x_mouse_leave): Remove; unused.
3614 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3615 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3616 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3617 Remove decls.
3618 (x_mouse_leave): Declare only if WINDOWSNT.
3619 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3620 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3621 USE_X_TOOLKIT.
3622
1675728f
PE
3623 * ftxfont.c: Make symbols static if they're not exported.
3624 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3625 HAVE_FREETYPE.
3626 * font.h (ftxfont_driver): Likewise.
3627
e4cebfca
PE
3628 * xfns.c: Make symbols static if they're not exported.
3629 (x_last_font_name, x_display_info_for_name):
3630 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3631 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3632 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3633 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3634 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3635 (last_show_tip_args): Now static.
3636 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3637 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3638 (x_screen_planes): Remove; unused.
3639 * dispextern.h (x_screen_planes): Remove decl.
3640
5bf46f05
PE
3641 * dispnew.c: Make symbols static if they're not exported.
3642 * dispextern.h (redraw_garbaged_frames, scrolling):
3643 (increment_row_positions): Remove.
3644 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3645 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3646 Now static.
3647 (redraw_garbaged_frames): Remove; unused.
3648
435f4c28
PE
3649 * xfaces.c: Make symbols static if they're not exported.
3650 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3651 Remove decls.
3652 * xterm.h (defined_color): Remove decls.
3653 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3654 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3655 (menu_face_changed_default, defined_color, free_realized_face):
3656 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3657 (ascii_face_of_lisp_face): Remove; unused.
3658
8524aef3
PE
3659 * xdisp.c: Make symbols static if they're not exported.
3660 * dispextern.h (scratch_glyph_row, window_box_edges):
3661 (glyph_to_pixel_coords, set_cursor_from_row):
3662 (get_next_display_element, set_iterator_to_next):
3663 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3664 (show_mouse_face): Remove decls
3665 * frame.h (message_buf_print): Likewise.
3666 * lisp.h (pop_message, set_message, check_point_in_composition):
3667 Likewise.
3668 * xterm.h (set_vertical_scroll_bar): Likewise.
3669 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3670 (message_buf_print, scratch_glyph_row, displayed_buffer):
3671 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3672 (get_next_display_element, show_mouse_face, window_box_edges):
3673 (frame_to_window_pixel_xy, check_point_in_composition):
3674 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3675 (glyph_to_pixel_coords): Remove; unused.
3676
16390cd2
PE
3677 * dired.c (file_name_completion): Now static.
3678
3679 * dbusbind.c (xd_in_read_queued_messages): Now static.
3680
a25f4dfa
PE
3681 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3682 * data.c (circular_list_error): Remove.
3683
14a9c8df
PE
3684 * commands.h (last_point_position, last_point_position_buffer):
3685 (last_point_position_window): Remove decls.
3686 * keyboard.c: Make these variables static.
3687
04f2d78b
CB
3688 * coding.h (coding, code_convert_region, encode_coding_gap):
3689 Remove decls.
74ab6df5
PE
3690 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3691 (iso_code_class, detect_coding, code_convert_region): Now static.
3692 (encode_coding_gap): Remove; unused.
3693
38dfbee1
PE
3694 * chartab.c (chartab_chars, chartab_bits): Now static.
3695
a2cb4e63
PE
3696 * charset.h (charset_iso_8859_1): Remove decl.
3697 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3698 Now static.
3699
127198fd
PE
3700 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3701 * ccl.c (Vccl_program_table): Now static.
3702 (check_ccl_update): Remove; unused.
3703
d85b608f
PE
3704 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3705 * category.h: ... from here.
3706 * category.c (check_category_table, set_category_set): Now static.
3707
31cd66f3
PE
3708 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3709 * lisp.h: Remove these decls.
3710
c358e587
PE
3711 * buffer.c (buffer_count): Remove unused var.
3712
e78aecca
PE
3713 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3714 so that it's not optimized away.
3715 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3716 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3717 exported only to the debugger.
3718
e192d7d3 3719 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3720 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3721
92470028
PE
3722 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3723 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3724 was inaccessible from Lisp.
3725 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3726 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3727
244ed907
PE
3728 alloc.c: Import and export fewer symbols, and remove unused items.
3729 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3730 is defined.
3731 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3732 it's not optimized away by whole-program optimization.
3733 (message_enable_multibyte, free_misc): Remove.
3734 (catchlist, handlerlist, mark_backtrace):
3735 Declare only if BYTE_MARK_STACK.
3736 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3737 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3738 (message_enable_multibyte): Remove decl.
3739 (free_misc, interval_free_list, float_block, float_block_index):
3740 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3741 (cons_free_list, last_marked_index):
3742 Now static.
3743 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3744 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3745 (mark_backtrace): Define only if BYTE_MARK_STACK.
3746 * xdisp.c (message_enable_multibyte): Now static.
3747
61c2b50e 3748 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3749 This makes it easier for human readers (and static analyzers)
3750 to see whether these variables are used from other modules.
3751 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3752 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3753 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3754 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3755 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3756 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3757 * xmenu.c, xselect.c:
3758 Declare Q* vars static if they are not used in other modules.
3759 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3760 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3761 Remove decls of unexported vars.
3762 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3763
95c82688
PE
3764 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3765
16a97296
PE
3766 Make Emacs functions such as Fatom 'static' by default.
3767 This makes it easier for human readers (and static analyzers)
3768 to see whether these functions can be called from other modules.
3769 DEFUN now defines a static function. To make the function external
3770 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3771 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3772 (Finit_image_library):
16a97296
PE
3773 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3774 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3775 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3776 Remove decls, since these functions are now static.
3777 (Funintern, Fget_internal_run_time): New decls, since these functions
3778 were already external.
95c82688 3779
16a97296
PE
3780 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3781 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3782 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3783 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3784 * keyboard.c, keymap.c, lread.c:
3785 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3786 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3787 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3788 Mark functions with DEFUE instead of DEFUN,
3789 if they are used in other modules.
3790 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3791 decls for now-static functions.
3792 * buffer.h (Fdelete_overlay): Remove decl.
3793 * callproc.c (Fgetenv_internal): Mark as internal.
3794 * composite.c (Fremove_list_of_text_properties): Remove decl.
3795 (Fcomposition_get_gstring): New forward static decl.
3796 * composite.h (Fcomposite_get_gstring): Remove decl.
3797 * dired.c (Ffile_attributes): New forward static decl.
3798 * doc.c (Fdocumntation_property): New forward static decl.
3799 * eval.c (Ffetch_bytecode): New forward static decl.
3800 (Funintern): Remove extern decl; now in .h file where it belongs.
3801 * fileio.c (Fmake_symbolic_link): New forward static decl.
3802 * image.c (Finit_image_library): New forward static decl.
3803 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3804 * intervals.h (Fprevious_property_change):
3805 (Fremove_list_of_text_properties): Remove decls.
3806 * keyboard.c (Fthis_command_keys): Remove decl.
3807 (Fcommand_execute): New forward static decl.
3808 * keymap.c (Flookup_key): New forward static decl.
3809 (Fcopy_keymap): Now static.
3810 * keymap.h (Flookup_key): Remove decl.
3811 * process.c (Fget_process): New forward static decl.
3812 (Fprocess_datagram_address): Mark as internal.
3813 * syntax.c (Fsyntax_table_p): New forward static decl.
3814 (skip_chars): Remove duplicate decl.
3815 * textprop.c (Fprevious_property_change): New forward static decl.
3816 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3817 Now internal.
3818 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3819 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3820
785bbd42
PE
3821 * editfns.c (Fformat): Remove unreachable code.
3822
8b913b57
AS
38232011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3824
3825 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3826 change. (Bug#8496)
3827
a6744a35
EZ
38282011-04-13 Eli Zaretskii <eliz@gnu.org>
3829
3830 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3831 when at ZV. (Bug#8487)
3832
e7974947
AS
38332011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3834
baad03f0
AS
3835 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3836 (Bug#8437)
3837 * keyboard.c (parse_tool_bar_item): Likewise.
3838 * sound.c (sound_cleanup, alsa_close): Likewise.
3839 * termcap.c (tgetent): Likewise.
3840 * xfns.c (x_default_font_parameter): Likewise.
3841 * xsettings.c (read_and_apply_settings): Likewise.
3842
e7974947
AS
3843 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3844 (overrun_check_free): Protoize.
3845
28272684
PE
38462011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3847
3848 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3849 since callers should never pass a negative size.
3850 Change the signature to match that of plain 'read' and 'write'; see
3851 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3852 * lisp.h: Update prototypes of emacs_write and emacs_read.
3853
11997c76
EZ
38542011-04-11 Eli Zaretskii <eliz@gnu.org>
3855
3856 * xdisp.c (redisplay_window): Don't try to determine the character
3857 position of the scroll margin if the window start point w->startp
e896f03c 3858 is outside the buffer's accessible region. (Bug#8468)
11997c76 3859
8a2cbd72
EZ
38602011-04-10 Eli Zaretskii <eliz@gnu.org>
3861
3862 Fix write-region and its subroutines for buffers > 2GB.
3863 * fileio.c (a_write, e_write): Modify declaration of arguments and
3864 local variables to support buffers larger than 2GB.
3865 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3866
3867 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3868 argument, local variables, and return value.
3869
3870 * lisp.h: Update prototypes of emacs_write and emacs_read.
3871
3872 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3873
4073e537 38742011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3875
1ebfdcb6
PE
3876 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3877
b2ded58d
PE
3878 Fix more problems found by GCC 4.6.0's static checks.
3879
7d66342c
PE
3880 * xdisp.c (vmessage): Use a better test for character truncation.
3881
bbf47d44
PE
3882 * charset.c (load_charset_map): <, not <=, for optimization,
3883 and to avoid potential problems with integer overflow.
9248994d 3884 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3885 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3886 * editfns.c (Fformat): Likewise.
1e69125e 3887 * syntax.c (skip_chars): Likewise.
3befa583 3888
e3019616
PE
3889 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3890 This also lets GCC 4.6.0 generate slightly better loop code.
3891
becfa255
PE
3892 * callint.c (Fcall_interactively): <, not <=, for optimization.
3893 (Fcall_interactively): Count the number of arguments produced,
3894 not the number of arguments given. This is simpler and lets GCC
3895 4.6.0 generate slightly better code.
3896
dae0cd48
PE
3897 * ftfont.c: Distingish more carefully between FcChar8 and char.
3898 The previous code passed unsigned char * to a functions like
3899 strlen and xstrcasecmp that expect char *, which does not
3900 conform to the C standard.
3901 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3902 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3903 char * when the C standard requires it.
3904
76032d70
PE
3905 * keyboard.c (read_char): Remove unused var.
3906
eb3f1cc8
PE
3907 * eval.c: Port to Windows vsnprintf (Bug#8435).
3908 Include <limits.h>.
3909 (SIZE_MAX): Define if the headers do not.
3910 (verror): Do not give up if vsnprintf returns a negative count.
3911 Instead, grow the buffer. This ports to Windows vsnprintf, which
3912 does not conform to C99. Problem reported by Eli Zaretskii.
3913 Also, simplify the allocation scheme, by avoiding the need for
3914 calling realloc, and removing the ALLOCATED variable.
3915
70476b54
PE
3916 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3917
12020a9e
PE
3918 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3919 But keep the doprint source code for now, as we might revamp it
3920 and use it again (Bug#8435).
ea6c7ae6
PE
3921 * lisp.h (doprnt): Remove.
3922 * Makefile.in (base_obj): Remove doprnt.o.
3923 * deps.mk (doprnt.o): Remove.
3924
5fdb398c
PE
3925 error: Print 32- and 64-bit integers portably (Bug#8435).
3926 Without this change, on typical 64-bit hosts error ("...%d...", N)
3927 was used to print both 32- and 64-bit integers N, which relied on
3928 undefined behavior.
3929 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3930 New macro.
3931 * lisp.h (error, verror): Mark as printf-like functions.
3932 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3933 Report overflow in size calculations when allocating printf buffer.
3934 Do not truncate output string at its first null byte.
3935 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3936 Truncate the output at a character boundary, since vsnprintf does not
3937 do that.
3938 * charset.c (check_iso_charset_parameter): Convert internal
3939 character to string before calling 'error', since %c now has the
3940 printf meaning.
3941 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3942 overflow when computing char to be passed to 'error'. Do not
3943 pass Lisp_Object to 'error'; pass the integer instead.
3944 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3945 formatted with plain %d.
3946
b189fa66
PE
3947 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3948
bff87ef0
PE
3949 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3950
7e2cac20
PE
3951 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3952
ce4d90b5
PE
3953 * xterm.c (x_catch_errors): Remove duplicate declaration.
3954
266c9547
PE
3955 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3956
79c49ad2
PE
3957 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3958
368f4090
JM
39592011-04-10 Jim Meyering <meyering@redhat.com>
3960
3961 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3962 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3963 return ssize_t not "int", and use size_t as the buffer length.
3964 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3965 * gnutls.h: Update declarations.
3966 * process.c (read_process_output): Use ssize_t, to match.
3967 (send_process): Likewise.
3968
a32d4040
CY
39692011-04-09 Chong Yidong <cyd@stupidchicken.com>
3970
3971 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3972
8546720e 39732011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3974
04f2d78b
CB
3975 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3976 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3977
8546720e
GM
3978 * xterm.c (handle_one_xevent):
3979 * xmenu.c (create_and_show_popup_menu):
3980 * xselect.c (x_decline_selection_request)
3981 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3982
0a2f5c1a 39832011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3984
3985 Fix some uses of `int' instead of EMACS_INT.
3986 * search.c (string_match_1, fast_string_match)
3987 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3988 (scan_buffer, find_next_newline_no_quit)
3989 (find_before_next_newline, search_command, Freplace_match)
3990 (Fmatch_data): Make some `int' variables be EMACS_INT.
3991
3992 * xdisp.c (display_count_lines): 3rd argument and return value now
3993 EMACS_INT. All callers changed.
3994 (pint2hrstr): Last argument is now EMACS_INT.
3995
3996 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3997 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3998 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3999 (decode_coding_utf_16, decode_coding_emacs_mule)
4000 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4001 (decode_coding_ccl, decode_coding_charset)
4002 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4003 (decode_coding_iso_2022, decode_coding_emacs_mule)
4004 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4005 <char_offset, last_offset>: Declare EMACS_INT.
4006 (encode_coding_utf_8, encode_coding_utf_16)
4007 (encode_coding_emacs_mule, encode_invocation_designation)
4008 (encode_designation_at_bol, encode_coding_iso_2022)
4009 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4010 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4011 Declare EMACS_INT.
4012 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4013 (encode_invocation_designation): Last argument P_NCHARS is now
4014 EMACS_INT.
4015 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4016 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4017
4018 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4019 All users changed.
4020
4021 * ccl.c (Fccl_execute_on_string): Declare some variables
4022 EMACS_INT.
4023
8546720e 40242011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4025
4026 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4027
4e19a977
CS
40282011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4029
4030 * process.c (Fformat_network_address): Doc fix.
4031
87302331
R
40322011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4033
4034 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4035
cbb59342
CY
40362011-04-08 Chong Yidong <cyd@stupidchicken.com>
4037
4038 * keyboard.c (read_char): Call Lisp function help-form-show,
4039 instead of using internal_with_output_to_temp_buffer.
4040 (Qhelp_form_show): New var.
e0d38eeb 4041 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4042
4043 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4044
4045 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4046
e67a13ab
CY
40472011-04-06 Chong Yidong <cyd@stupidchicken.com>
4048
04f2d78b
CB
4049 * process.c (Flist_processes): Remove to Lisp.
4050 (list_processes_1): Delete.
e67a13ab 4051
973f782d
EZ
40522011-04-06 Eli Zaretskii <eliz@gnu.org>
4053
7c106b1e
EZ
4054 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4055
973f782d
EZ
4056 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4057
41cf7d1a 40582011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4059
ca23cc88
PE
4060 Fix more problems found by GCC 4.6.0's static checks.
4061
f390e2d5
PE
4062 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4063
42eea0d0
PE
4064 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4065
b69769da 4066 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4067
f9541e84
PE
4068 * xdisp.c (vmessage): Mark as a printf-like function.
4069
13841b55
PE
4070 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4071
c136c10f
PE
4072 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4073
5e2d4a30
PE
4074 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4075 printf-like functions.
4076 (tiff_load): Add casts to remove these marks before passing them
4077 to system-supplied API.
4078
583f48b9
PE
4079 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4080
b25d760e
PE
4081 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4082 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4083 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4084 directly, rather than having caller test rule sign. This avoids
4085 some unnecessary tests.
4086 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4087 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4088 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4089
bc7b6697 4090 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4091 (xfont_open): Avoid unnecessary tests.
bc7b6697 4092
27ccc379
PE
4093 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4094
dcd5c89a
PE
4095 * composite.h, composite.c (composition_gstring_put_cache):
4096 Use EMACS_INT, not int, for length.
4097
b13a45c6
PE
4098 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4099 breaking out part of COMPOSITION_DECODE_RULE.
4100 (COMPOSITION_DECODE_RULE): Use it.
4101 * composite.c (get_composition_id): Remove unused local vars,
4102 by using the new macro.
4103
1e792e4d
PE
4104 * textprop.c (set_text_properties_1): Change while to do-while,
4105 since the condition is always true at first.
4106
dc6c6455 4107 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4108 (interval_deletion_adjustment): Return unsigned value.
4109 All uses changed.
dc6c6455 4110
aba7731a
PE
4111 * process.c (list_processes_1, create_pty, read_process_output):
4112 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4113 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4114 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4115 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4116 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4117
fdfc4bf3
PE
4118 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4119
fca8fe46 4120 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4121 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4122
06a0259a 4123 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4124 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4125 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4126
e7b9e80f
PE
4127 * print.c (print_error_message): Avoid int overflow.
4128
56201685
PE
4129 * font.c (font_list_entities): Redo for clarity,
4130 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4131
78834453 4132 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4133 (font_score): Avoid potential overflow in diff calculation.
78834453 4134
0bc0b309 4135 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4136 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4137
e610eaca
PE
4138 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4139
b895abce
PE
4140 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4141 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4142 can always succeed if overflow has undefined behavior.
4143
1f1d9321 4144 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4145 (wordify): Omit three unnecessary tests.
1f1d9321 4146
c59478bc
PE
4147 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4148 All callers changed. This avoids the need for an unused var.
4149
79b73827
PE
4150 * casefiddle.c (casify_region): Remove var that is set but not used.
4151
a4db5dfe
PE
4152 * dired.c (file_name_completion): Remove var that is set but not used.
4153
43aae36e
PE
4154 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4155
2a47c44d 4156 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4157 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4158
a37c69bf
PE
4159 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4160 Check for integer overflow on size calculations.
4161
328ab8e7
PE
4162 * buffer.c (Fprevious_overlay_change): Remove var that is set
4163 but not used.
4164
e5a2a5cb
PE
4165 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4166 Remove vars that are set but not used.
8d84a6eb 4167 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4168 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4169
a60e5f68
PE
4170 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4171
f661cb61 4172 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4173 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4174
f0397f5a
PE
4175 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4176 that are set but not used.
4177
8664db06 4178 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4179 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4180
6abdaa4a
PE
4181 * xselect.c (x_get_local_selection, x_handle_property_notify):
4182 Remove vars that are set but not used.
4183
0ce7538d 4184 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4185 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4186
9ae848fc
PE
4187 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4188 Remove var that is set but not used.
0b918413
PE
4189 (scroll_bar_windows_size): Now size_t, not int.
4190 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4191 Check for overflow.
9ae848fc 4192
a5a62657
PE
4193 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4194 (map_tty_color) [!defined MSDOS]: Likewise.
4195
5c5cdd39
PE
4196 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4197
66ebf983
PE
4198 * coding.c: Remove vars that are set but not used.
4199 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4200 All callers changed.
4201 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4202 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4203 (decode_coding_charset): Remove vars that are set but not used.
4204
1be4d761
PE
4205 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4206 that is set but not used.
4207
47553fa8
PE
4208 * print.c (print_object): Remove var that is set but not used.
4209
1f7196bf 4210 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4211 The gnulib version avoids calling malloc in the usual case,
4212 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4213 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4214 * filelock.c (current_lock_owner): Likewise.
4215 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4216 * sysdep.c: Include allocator.h, careadlinkat.h.
4217 (emacs_no_realloc_allocator): New static constant.
4218 (emacs_readlink): New function.
fdb61804
PE
4219 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4220 ../lib/careadlinkat.h.
d1fdcab7 4221
f84c17c7
SM
42222011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4223
4224 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4225 first non-nil return value).
4226
ef3862ad
JD
42272011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4228
4229 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4230 if not defined (Bug#8403).
4231
376a7006
JB
42322011-04-02 Juanma Barranquero <lekktu@gmail.com>
4233
4234 * xdisp.c (display_count_lines): Remove parameter `start',
4235 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4236 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4237 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4238 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4239 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4240 and thereabouts. All callers changed.
4241 (get_per_char_metric): Remove parameter `f', unused since
4242 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4243
6ca3801d
JM
42442011-04-02 Jim Meyering <meyering@redhat.com>
4245
4246 do not dereference NULL upon failed strdup
4247 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4248 (ns_get_family): Likewise.
4249
d8e2b5ba
JB
42502011-04-02 Juanma Barranquero <lekktu@gmail.com>
4251
4252 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4253
8c74fcbd
JD
42542011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4255
4256 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4257 later (Bug#8403).
4258
7200d79c
SM
42592011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4260
03408648 4261 Add lexical binding.
7200d79c 4262
03408648
SM
4263 * window.c (Ftemp_output_buffer_show): New fun.
4264 (Fsave_window_excursion):
4265 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4266
4267 * lread.c (lisp_file_lexically_bound_p): New function.
4268 (Fload): Bind Qlexical_binding.
4269 (readevalloop): Remove `evalfun' arg.
4270 Bind Qinternal_interpreter_environment.
4271 (Feval_buffer): Bind Qlexical_binding.
4272 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4273 Mark as dynamic.
4274 (syms_of_lread): Declare `lexical-binding'.
4275
4276 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4277
4278 * keyboard.c (eval_dyn): New fun.
4279 (menu_item_eval_property): Use it.
ca105506
SM
4280
4281 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4282
03408648
SM
4283 * fns.c (concat, mapcar1): Accept byte-code-functions.
4284
4285 * eval.c (Fsetq): Handle lexical vars.
4286 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4287 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4288 (FletX, Flet): Obey lexical binding.
4289 (Fcommandp): Handle closures.
4290 (Feval): New `lexical' arg.
4291 (eval_sub): New function extracted from Feval. Use it almost
4292 everywhere where Feval was used. Look up vars in lexical env.
4293 Handle closures.
4294 (Ffunctionp): Move from subr.el.
4295 (Ffuncall): Handle closures.
4296 (apply_lambda): Remove `eval_flags'.
4297 (funcall_lambda): Handle closures and new byte-code-functions.
4298 (Fspecial_variable_p): New function.
4299 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4300 but without exporting it to Lisp.
23aba0ea 4301
23aba0ea 4302 * doc.c (Fdocumentation, store_function_docstring):
03408648 4303 * data.c (Finteractive_form): Handle closures.
23aba0ea 4304
03408648
SM
4305 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4306 interactive spec.
ba83908c 4307
04f2d78b
CB
4308 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4309 New byte-codes.
03408648
SM
4310 (exec_byte_code): New function extracted from Fbyte_code to handle new
4311 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4312
03408648 4313 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4314
03408648 4315 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4316
e2abce01
JB
43172011-03-31 Juanma Barranquero <lekktu@gmail.com>
4318
4319 * xdisp.c (redisplay_internal): Fix prototype.
4320
63696a73 43212011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4322
63696a73 4323 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4324 (try_scrolling): Use it when setting scroll_limit.
4325 Limit scrolling to 100 screen lines.
63696a73
EZ
4326 (redisplay_window): Even when falling back on "recentering",
4327 position point in the window according to scroll-conservatively,
4328 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4329
4330 (try_scrolling): When point is above the window, allow searching
4331 as far as scroll_max, or one screenful, to compute vertical
4332 distance from PT to the scroll margin position. This prevents
4333 try_scrolling from unnecessarily failing when
4334 scroll-conservatively is set to a value slightly larger than the
4335 window height. Clean up the case of PT below the margin at bottom
4336 of window: scroll_max can no longer be INT_MAX. When aggressive
4337 scrolling is in use, don't let point enter the opposite scroll
4338 margin as result of the scroll.
4339 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4340 threshold of 100 lines for never-recentering scrolling.
4341
e4cc2dfc
JB
43422011-03-31 Juanma Barranquero <lekktu@gmail.com>
4343
4344 * dispextern.h (move_it_by_lines):
4345 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4346 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4347 (message_log_check_duplicate): Remove parameters `prev_bol' and
4348 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4349 (redisplay_internal): Remove parameter `preserve_echo_area',
4350 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4351
4352 * indent.c (Fvertical_motion):
4353 * window.c (window_scroll_pixel_based, Frecenter):
4354 Don't pass `need_y_p' to `move_it_by_lines'.
4355
1c470562
SM
43562011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4357
44f230aa
SM
4358 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4359 steal a few bits to be more compact.
4360 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4361 Remove unneeded casts.
4362
1c470562
SM
4363 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4364
888adce9
ZK
43652011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4366
4367 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4368 binding" message (bug#7967).
4369
f838ed7b
PE
43702011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4371
77861b95
PE
4372 Fix more problems found by GCC 4.6.0's static checks.
4373
de6dbc14
PE
4374 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4375 Remove unused local var.
4376
f838ed7b
PE
4377 * editfns.c (Fmessage_box): Remove unused local var.
4378
792c7b2b
PE
4379 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4380 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4381 Omit unused local vars.
c499e557 4382 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4383 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4384 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4385 Omit unused local var.
4386
ba0165e1
PE
4387 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4388 Don't assume string length fits in int.
32ad8845 4389 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4390 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4391
3c59b4c9
PE
4392 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4393 instead of alloca (Bug#8344).
4394
a3eed478 4395 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4396 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4397
eb4d412d
PE
4398 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4399
1658b401
PE
4400 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4401 concerns.
4402
4403 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4404
4405 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4406
9a2c6e05
PE
4407 * keyboard.c (syms_of_keyboard): Use the same style as later
4408 in this function when indexing through an array. This also
4409 works around GCC bug 48267.
4410
03d0a109
PE
4411 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4412
44f730c8
PE
4413 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4414
fe75f926
PE
4415 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4416 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4417
ffa8c828
PE
4418 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4419 This avoids undefined behavior on integer overflow, and is a bit
4420 more convenient anyway since it is compared to a size_t variable.
4421
c5101a77
PE
4422 Variadic C functions now count arguments with size_t, not int.
4423 This avoids an unnecessary limitation on 64-bit machines, which
4424 caused (substring ...) to crash on large vectors (Bug#8344).
4425 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4426 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4427 All variadic functions and their callers changed accordingly.
c5101a77
PE
4428 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4429 * data.c (arith_driver, float_arith_driver): Likewise.
4430 * editfns.c (general_insert_function): Likewise.
4431 * eval.c (struct backtrace.nargs, interactive_p)
4432 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4433 (funcall_lambda, mark_backtrace): Likewise.
4434 * fns.c (concat): Likewise.
4435 * frame.c (x_set_frame_parameters): Likewise.
4436 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4437 0 if not found, not -1. All callers changed.
4438
dd3f25f7
PE
4439 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4440 (stack_copy_size): Now size_t, not int.
4441 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4442
461c2ab9
JB
44432011-03-28 Juanma Barranquero <lekktu@gmail.com>
4444
4445 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4446 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4447 All callers changed.
4448
4449 * lisp.h (multibyte_char_to_unibyte):
4450 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4451 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4452 * character.h (CHAR_TO_BYTE8):
4453 * cmds.c (internal_self_insert):
4454 * editfns.c (general_insert_function):
4455 * keymap.c (push_key_description):
4456 * search.c (Freplace_match):
4457 * xdisp.c (message_dolog, set_message_1): All callers changed.
4458
f6d62986
SM
44592011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4460
4461 * keyboard.c (safe_run_hook_funcall): New function.
4462 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4463 don't set the hook to nil, but remove the offending function instead.
4464 (Qcommand_hook_internal): Remove, unused.
4465 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4466 Vcommand_hook_internal.
4467
4468 * eval.c (enum run_hooks_condition): Remove.
4469 (funcall_nil, funcall_not): New functions.
4470 (run_hook_with_args): Call each function through a `funcall' argument.
4471 Remove `cond' argument, now redundant.
4472 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4473 (Frun_hook_with_args_until_failure): Adjust accordingly.
4474 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4475
1db5b1ad
JB
44762011-03-28 Juanma Barranquero <lekktu@gmail.com>
4477
4478 * dispextern.h (string_buffer_position): Remove declaration.
4479
4480 * print.c (strout): Remove parameter `multibyte', unused since
4481 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4482
4483 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4484 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4485 All callers changed.
4486
4487 * w32.c (_wsa_errlist): Use braces for struct initializers.
4488
4489 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4490 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4491 All callers changed.
4492 (string_buffer_position): Likewise. Also, make static (it's never
4493 used outside xdisp.c).
4494 (cursor_row_p): Remove parameter `w', unused since
4495 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4496 (decode_mode_spec): Remove parameter `precision', introduced during
4497 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4498 All callers changed.
4499
5ffb62aa
JD
45002011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4501
4502 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4503
461c2ab9 45042011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4505
4506 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4507 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4508 (ns_update_auto_hide_menu_bar): New functions.
4509 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4510 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4511 ns_constrain_all_frames.
4512 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4513 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4514
5c380ffb
JD
45152011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4516
4517 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4518
9af30bdf
GM
45192011-03-27 Glenn Morris <rgm@gnu.org>
4520
4521 * syssignal.h: Replace RETSIGTYPE with void.
4522 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4523 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4524 Replace SIGTYPE with void everywhere.
4525 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4526 * s/template.h (SIGTYPE): Remove commented out definition.
4527
e2abce01
JB
45282011-03-26 Eli Zaretskii <eliz@gnu.org>
4529
4530 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4531 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4532
f868cd8a
JB
45332011-03-26 Juanma Barranquero <lekktu@gmail.com>
4534
59eb0929
JB
4535 * w32.c (read_unc_volume): Use parameter `henum', instead of
4536 global variable `wget_enum_handle'.
4537
4538 * keymap.c (describe_vector): Remove parameters `indices' and
4539 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4540 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4541
f868cd8a
JB
4542 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4543
4544 * keyboard.c (timer_check): Remove parameter `do_it_now',
4545 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4546 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4547 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4548
4549 * keyboard.c (read_char):
4550 * w32menu.c (w32_menu_display_help):
4551 * xmenu.c (show_help_event, menu_help_callback):
4552 Adjust calls to `show_help_echo'.
4553
4554 * gtkutil.c (xg_maybe_add_timer):
4555 * keyboard.c (readable_events):
4556 * process.c (wait_reading_process_output):
4557 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4558
4559 * insdel.c (adjust_markers_gap_motion):
4560 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4561 (gap_left, gap_right): Don't call it.
4562
2ecf6fdb
CY
45632011-03-25 Chong Yidong <cyd@stupidchicken.com>
4564
4565 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4566 incurred during fontification.
4567
6b1f9ba4
JB
45682011-03-25 Juanma Barranquero <lekktu@gmail.com>
4569
4570 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4571 (DEFVAR_PER_BUFFER): Don't pass it.
4572
4573 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4574 (scrolling_window): Don't pass it.
4575
0f4a96b5
JB
45762011-03-25 Juanma Barranquero <lekktu@gmail.com>
4577
4578 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4579
4580 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4581 and `suffix'.
4582 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4583 of variables specific to SELinux and computation of `encoded_absname'.
4584
4585 * image.c (XPutPixel): Remove unused variable `height'.
4586
4587 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4588
4589 * unexw32.c (get_section_info): Remove unused variable `section'.
4590
4591 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4592 (system_process_attributes): Remove unused variable `sess'.
4593 (sys_read): Remove unused variable `err'.
4594
4595 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4596 (w32_wnd_proc): Remove unused variable `isdead'.
4597 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4598 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4599 (x_create_tip_frame): Remove unused variable `tem'.
4600
4601 * w32inevt.c (w32_console_read_socket):
4602 Remove unused variable `no_events'.
4603
4604 * w32term.c (x_draw_composite_glyph_string_foreground):
4605 Remove unused variable `width'.
4606
1149507c
JB
46072011-03-24 Juanma Barranquero <lekktu@gmail.com>
4608
4609 * w32term.c (x_set_glyph_string_clipping):
4610 Don't pass uninitialized region to CombineRgn.
4611
9c88f339
JB
46122011-03-23 Juanma Barranquero <lekktu@gmail.com>
4613
4614 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4615 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4616 (Fx_close_connection): Remove unused variable `i'.
4617
4618 * w32font.c (w32font_draw): Return number of glyphs.
4619 (w32font_open_internal): Remove unused variable `i'.
4620 (w32font_driver): Add missing initializer.
4621
4622 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4623 (fill_in_menu): Remove unused variable `items_added'.
4624
4625 * w32term.c (last_mouse_press_frame): Remove static global variable.
4626 (w32_clip_to_row): Remove unused variable `f'.
4627 (x_delete_terminal): Remove unused variable `i'.
4628
4629 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4630 (NOTHING): Remove unused static global variable.
4631 (uniscribe_check_otf): Remove unused variable `table'.
4632 (uniscribe_font_driver): Add missing initializers.
4633
dee091a3
JD
46342011-03-23 Julien Danjou <julien@danjou.info>
4635
4636 * term.c (Fsuspend_tty, Fresume_tty):
4637 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4638 * window.c (temp_output_buffer_show):
4639 * insdel.c (signal_before_change):
4640 * frame.c (Fhandle_switch_frame):
4641 * fileio.c (Fdo_auto_save):
4642 * emacs.c (Fkill_emacs):
4643 * editfns.c (save_excursion_restore):
4644 * cmds.c (internal_self_insert):
4645 * callint.c (Fcall_interactively):
4646 * buffer.c (Fkill_all_local_variables):
4647 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4648 Use Frun_hooks.
0f4a96b5 4649 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4650 unconditionnaly since it does the check itself.
4651
2c520ab5 46522011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4653
c9c49752
PE
4654 Fix more problems found by GCC 4.5.2's static checks.
4655
8abc3f12
PE
4656 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4657 the first time through the loop, since we know p0 < p1 then.
4658 This also avoids a gcc -Wstrict-overflow warning.
4659
a2d26660
PE
4660 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4661 leading to a memory leak, possible in functions like
4662 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4663 of objects (Bug#8318).
a2d26660 4664
916c72e9
PE
4665 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4666 that could (at least in theory) be that large.
4667
19ab8a18
PE
4668 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4669 This is less likely to overflow, and avoids undefined behavior if
4670 overflow does occur. All callers changed. Use strtoul to scan
4671 for the unsigned long integer.
b7cbbd6f
PE
4672 (pint2hrstr): Simplify and tune code slightly.
4673 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4674
f0641eff
PE
4675 * scroll.c (do_scrolling): Work around GCC bug 48228.
4676 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4677
7f650bb9
PE
4678 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4679 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4680 (validate_x_resource_name): Simplify count usage.
4681 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4682
37dd57d1
PE
4683 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4684 fail (Bug#8306).
81e56e61 4685
699979fc 4686 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4687
401bf9b4
PE
4688 * process.c (Fmake_network_process): Use socklen_t, not int,
4689 where POSIX says socklen_t is required in portable programs.
4690 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4691 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4692 (Fmake_network_process, server_accept_connection):
4693 (wait_reading_process_output, read_process_output):
4694 Likewise.
4695
b93aacde
PE
4696 * process.c: Rename or move locals to avoid shadowing.
4697 (list_processes_1, Fmake_network_process):
4698 (read_process_output_error_handler, exec_sentinel_error_handler):
4699 Rename or move locals.
4dc343ee 4700 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4701 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4702 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4703 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4704 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4705
af8a867c 4706 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4707 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4708 Include tparam.h instead, since it declares them.
af8a867c
PE
4709 * cm.h (PC): Remove extern decl; tparam.h now does this.
4710 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4711 * terminfo.c: Include tparam.h, to check interfaces.
4712 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4713 (tparam): Adjust signature to match interface in tparam.h;
4714 this removes some undefined behavior. Check that outstring and len
4715 are zero, which they always are with Emacs.
4716 * tparam.h (PC, BC, UP): New extern decls.
4717
0248044d 4718 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4719 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4720
8ff096c1 4721 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4722 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4723 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4724 (ftfont_list): Remove unused local.
49eaafba
PE
4725 (get_adstyle_property, ftfont_pattern_entity):
4726 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4727 Rename locals to avoid shadowing.
8ff096c1 4728
e2be39f6
PE
4729 * xfont.c (xfont_list_family): Mark var as initialized.
4730
c9735e30
PE
4731 * xml.c (make_dom): Now static.
4732
8f5201ae
PE
4733 * composite.c (composition_compute_stop_pos): Rename local to
4734 avoid shadowing.
b246f932
PE
4735 (composition_reseat_it): Remove unused locals.
4736 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4737 (composition_update_it): Mark var as initialized.
11b61122
PE
4738 (find_automatic_composition): Mark vars as initialized,
4739 with a FIXME (Bug#8290).
8f5201ae 4740
760fbc2c
PE
4741 character.h: Rename locals to avoid shadowing.
4742 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4743 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4744 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4745 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4746 to avoid shadowing.
4747
ff08eb85
PE
4748 * textprop.c (property_change_between_p): Remove; unused.
4749
fc7bf025
PE
4750 * intervals.c (interval_start_pos): Now static.
4751
235d7abc
PE
4752 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4753
44f230aa
SM
4754 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4755 Rename locals to avoid shadowing.
3e7d6594 4756
50060332
PE
4757 * sound.c (wav_play, au_play, Fplay_sound_internal):
4758 Fix pointer signedness.
d01f234b 4759 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4760 (wav_play): Initialize a variable to 0, to prevent undefined
4761 behavior (Bug#8278).
50060332 4762
c4fc4e30
PE
4763 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4764
918436ed
PE
4765 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4766
c939f91b
PE
4767 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4768 clobbering (Bug#8298).
b9c7f648
PE
4769 * sysdep.c (sys_subshell): Likewise.
4770 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4771
6bd8c144
PE
4772 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4773 This should get cleaned up, so that child_setup has the
4774 same signature on all platforms.
4775
7710357c 4776 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4777 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4778
c59da222
CY
47792011-03-22 Chong Yidong <cyd@stupidchicken.com>
4780
4781 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4782 not to be necessary, and produces flickering.
4783
66b87493
GM
47842011-03-20 Glenn Morris <rgm@gnu.org>
4785
4786 * config.in: Remove file.
4787
45b6f6d5
JB
47882011-03-20 Juanma Barranquero <lekktu@gmail.com>
4789
4790 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4791 are now in src/globals.h.
4792 (syms_of_minibuf): Remove spurious & from previous change.
4793
3ec03f7e
LL
47942011-03-20 Leo <sdl.web@gmail.com>
4795
4796 * minibuf.c (completing-read-function): New variable.
4797 (completing-read-default): Rename from completing-read.
4798 (completing-read): Call completing-read-function.
4799
b14e3e21
CY
48002011-03-19 Juanma Barranquero <lekktu@gmail.com>
4801
4802 * xfaces.c (Fx_load_color_file):
4803 Read color file from absolute filename (bug#8250).
4804
f2b726e6
JB
48052011-03-19 Juanma Barranquero <lekktu@gmail.com>
4806
4807 * makefile.w32-in: Update dependencies.
4808
09f6ff02
EZ
48092011-03-17 Eli Zaretskii <eliz@gnu.org>
4810
4811 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4812
29a6015a
PE
48132011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4814
a3a6c54e
PE
4815 Fix more problems found by GCC 4.5.2's static checks.
4816
b766f867
PE
4817 * process.c (make_serial_process_unwind, send_process_trap):
4818 (sigchld_handler): Now static.
4819
be02381c
PE
4820 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4821 That way, the code declares only the vars that it needs.
4822 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4823 * s/cygwin.h (PTY_ITERATION): Likewise.
4824 * s/darwin.h (PTY_ITERATION): Likewise.
4825 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4826
57048744
PE
4827 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4828 * process.c (allocate_pty): Don't declare stb unless it's needed.
4829
7914961c 4830 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4831 (CONSTANTLIM): Remove; unused.
4832 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4833 Define only if needed.
7914961c 4834
b3967b18
PE
4835 * unexelf.c (unexec): Name an expression,
4836 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4837 Use a different way to cause a compilation error if anyone uses
4838 n rather than nn, a way that does not involve shadowing.
73366a00 4839 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4840
29a6015a
PE
4841 * deps.mk (unexalpha.o): Remove; unused.
4842
43cfc33e 4843 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4844 * unexec.h: New file.
ce701a33
PE
4845 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4846 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4847 Depend on unexec.h.
4848 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4849 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4850 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4851 Change as necessary to match prototype in unexec.h.
ce701a33 4852
01f44d5a
PE
4853 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4854 shadowing.
4f63c6bb 4855 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4856
a6670b0b
PE
4857 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4858 Rename locals to avoid shadowing.
4859
cef2010d 4860 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4861 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4862
d4d7173a
PE
4863 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4864
f08b802a
PE
4865 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4866 warning when compiling print.c.
4867
3ddb0639
PE
4868 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4869 instead of using an uninitialized var.
5ad03b97 4870 (font_sort_entities): Mark var as initialized.
3ddb0639 4871
170a2692
PE
4872 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4873
e663c700
PE
4874 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4875 pointers to constants.
89bc529a 4876 (font_parse_fcname): Remove unused vars.
7b81e2d0 4877 (font_delete_unmatched): Now static.
ea838e10 4878 (font_get_spec): Remove; unused.
13a547c6
PE
4879 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4880 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4881 Rename or move locals to avoid shadowing.
e663c700 4882
2a80c887 4883 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4884 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4885
1384fa33 4886 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4887 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4888
8b2c52e9
PE
4889 * alloc.c (mark_backtrace): Move decl from here ...
4890 * lisp.h: ... to here, so that it can be checked.
4891
475545b5 4892 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4893 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4894 (lisp_indirect_variable): Name an expression,
4895 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4896 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4897
b1349114 4898 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4899 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4900 Use const pointer when appropriate.
b1349114 4901
a2928364
PE
4902 * lisp.h (get_system_name, get_operating_system_release):
4903 Move decls here, to check interfaces.
4904 * process.c (get_operating_system_release): Move decl to lisp.h.
4905 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4906 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4907 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4908 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4909 (Fformat_time_string, Fencode_time, Finsert_char):
4910 (Ftranslate_region_internal, Fformat):
4911 Rename or remove local vars to avoid shadowing.
9710023e 4912 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4913
a415e694
PE
4914 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4915 avoid shadowing.
4916
8ef4622d
PE
4917 * lisp.h (eassert): Check that the argument compiles, even if
4918 ENABLE_CHECKING is not defined.
4919
946f9a5b
PE
4920 * data.c (Findirect_variable): Name an expression, to avoid
4921 gcc -Wbad-function-cast warning.
112396d6 4922 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4923 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4924 (Fmake_variable_buffer_local, Fmake_local_variable):
4925 Mark variables as initialized.
52746918 4926 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4927
e5aab7e7 4928 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4929 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4930 Rename locals to avoid shadowing.
dff45157
PE
4931 (mark_stack): Move local variables into the #ifdef region where
4932 they're used.
7bc26fdb
PE
4933 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4934 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4935 needed otherwise.
4936 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4937 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4938 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4939
e5aab7e7
PE
4940 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4941 avoids undefined behavior in theory.
4942
4da60324
PE
4943 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4944
88043301
PE
4945 Use functions, not macros, for up- and down-casing (Bug#8254).
4946 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4947 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4948 to use the following functions instead of these macros.
4949 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4950 EMACS_INT, since callers assume the returned value fits in int.
4951 (upcase1): Likewise, for UPCASE_TABLE.
4952 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4953 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4954 the race-condition problem in the old DOWNCASE.
88043301 4955
19ed5445
PE
4956 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4957 Rename locals to avoid shadowing.
4958 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4959 (regex_compile, re_search_2, re_match_2_internal):
4960 Remove unused local vars.
952db0d7
PE
4961 (FREE_VAR): Rewrite so as not to use empty "else",
4962 which gcc can warn about.
da053e48 4963 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4964 (RETALLOC_IF): Define only if needed.
4965 (WORDCHAR_P): Likewise. This one is never needed, but is used
4966 only in a comment talking about a compiler bug, so put inside
4967 the #if 0 of that comment.
4968 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4969 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4970 Remove; unused.
19ed5445 4971
1f3561e4 4972 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4973 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4974 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4975
ded6f8f7
PE
4976 * search.c (simple_search): Remove unused var.
4977
dbd37a95
PE
4978 * dired.c (compile_pattern): Move decl from here ...
4979 * lisp.h: ... to here, so that it can be checked.
4980 (struct re_registers): New forward decl.
4981
7e47afad
PE
4982 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4983
85f24f61
PE
4984 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4985 All uses changed.
4986 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4987 Rename locals to avoid shadowing.
5671df8f 4988 (Fvertical_motion): Mark locals as initialized.
85f24f61 4989
181aa2be 4990 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4991 (casify_region): Mark local as initialized.
181aa2be 4992
930d429c
PE
4993 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4994
7082eac6
PE
4995 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4996 New macros, so that the caller can use some names other than
4997 gcpro1, gcpro2, etc.
4998 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4999 of the new macros.
5000 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5001 argument, for consistency with GCPRO2_VAR, etc: it is now the
5002 prefix of the variable, not the variable itself. All uses
5003 changed.
38b2c076
PE
5004 * dired.c (directory_files_internal, file_name_completion):
5005 Rename locals to avoid shadowing.
5006
15206ed9
PE
5007 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5008 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5009 dired.c's scmp function, had undefined behavior.
5010 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5011 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5012 * buffer.h: ... to here, because these macros use current_buffer,
5013 and the new implementation with inline functions needs to have
5014 current_buffer in scope now, rather than later when the macros
5015 are used.
5016 (downcase, upcase1): New static inline functions.
5017 (DOWNCASE, UPCASE1): Reimplement using these functions.
5018 This avoids undefined behavior in expressions like
5019 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5020 from race conditions in accessing the global variables
5021 case_temp1 and case_temp2.
5022 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5023 * lisp.h (case_temp1, case_temp2): Remove their decls.
5024 * character.h (ASCII_CHAR_P): Move from here ...
5025 * lisp.h: ... to here, so that the inline functions mentioned
5026 above can use them.
5027
4a6bea26
PE
5028 * dired.c (directory_files_internal_unwind): Now static.
5029
f14b7e14
PE
5030 * fileio.c (file_name_as_directory, directory_file_name):
5031 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5032 Now static.
2893f146
PE
5033 (file_name_as_directory): Use const pointers when appropriate.
5034 (Fexpand_file_name): Likewise. In particular, newdir might
5035 point at constant storage, so make it a const pointer.
fd4ead52 5036 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5037 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5038 signedness issues.
f839df0c
PE
5039 (Fset_file_times, Finsert_file_contents, auto_save_error):
5040 Rename locals to avoid shadowing.
f14b7e14 5041
5716756e 5042 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5043 (Ftry_completion, Fall_completions): Rename or remove locals
5044 to avoid shadowing.
5716756e 5045
b4c3046a
PE
5046 * marker.c (bytepos_to_charpos): Remove; unused.
5047
b45db522
PE
5048 * lisp.h (verify_bytepos, count_markers): New decls,
5049 so that gcc does not warn that these functions aren't declared.
5050
85876d07
PE
5051 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5052 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5053 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5054 (copy_text): Remove unused local var.
85876d07 5055
03d78a21 5056 * filelock.c (within_one_second): Now static.
b3dd38ab 5057 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5058
5df8f01b
PE
5059 * buffer.c (fix_overlays_before): Mark locals as initialized.
5060 (fix_start_end_in_overlays): Likewise. This function should be
5061 simplified by using pointers-to-pointers, but that's a different
5062 matter.
b1d876f1 5063 (switch_to_buffer_1): Now static.
8f54f30a
PE
5064 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5065 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5066
a70072c9 5067 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5068 Fix pointer signedness issue.
edced198
PE
5069 (sys_subshell): Mark local as volatile if checking for lint,
5070 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5071 (MAXPATHLEN): Define only if needed.
a70072c9 5072
a0977c44
PE
5073 * process.c (serial_open, serial_configure): Move decls from here ...
5074 * systty.h: ... to here, so that they can be checked.
5075
a884fdcc
PE
5076 * fns.c (get_random, seed_random): Move extern decls from here ...
5077 * lisp.h: ... to here, so that they can be checked.
5078
604efe86 5079 * sysdep.c (reset_io): Now static.
b8950c94 5080 (wait_for_termination_signal): Remove; unused.
604efe86 5081
38fc62d9
PE
5082 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5083 (copy_keymap_item, append_key, push_text_char_description):
5084 Now static.
1004a21a 5085 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5086 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5087 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5088 (describe_map_tree):
5089 Rename locals to avoid shadowing.
38fc62d9 5090
2f2650da
PE
5091 * keyboard.c: Declare functions static if they are not used elsewhere.
5092 (echo_char, echo_dash, cmd_error, top_level_2):
5093 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5094 (read_char, kbd_buffer_get_event, make_lispy_position):
5095 (make_lispy_event, make_lispy_movement, apply_modifiers):
5096 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5097 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5098 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5099 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5100 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5101
a053e86c 5102 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5103 (mark_kboards): Move decl here ...
5104 * alloc.c (mark_kboards): ... from here.
a053e86c 5105
4752793e
PE
5106 * lisp.h (force_auto_save_soon): New decl.
5107
74f10ca7 5108 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5109 (DEFINE_DUMMY_FUNCTION): New macro.
5110 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5111 Use it.
c03cd23f
PE
5112 (main): Add casts to avoid warnings
5113 if GCC considers string literals to be constants.
74f10ca7 5114
022e70d4
PE
5115 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5116
59d6fe83
PE
5117 * dbusbind.c: Pointer signedness fixes.
5118 (xd_signature, xd_append_arg, xd_initialize):
5119 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5120 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5121 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5122 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5123
78320123
PE
5124 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5125 if GCC considers string literals to be constants.
49cebcca 5126 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5127
35ac2a97
SM
51282011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5129
fb103ca9
SM
5130 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5131 (print_preprocess, print_object): New macro to fix last change.
5132
35ac2a97
SM
5133 * print.c (print_preprocess): Don't forget font objects.
5134
62973b41
JB
51352011-03-16 Juanma Barranquero <lekktu@gmail.com>
5136
5137 * emacs.c (USAGE3): Doc fixes.
5138
0e48bb22
AS
51392011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5140
5141 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5142 structure.
5143
7684e57b
JB
51442011-03-14 Juanma Barranquero <lekktu@gmail.com>
5145
5146 * lisp.h (VWindow_system, Qfile_name_history):
5147 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5148 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5149 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5150
5151 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5152 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5153
5154 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5155 * w32console.c (detect_input_pending, read_input_pending)
5156 (encode_terminal_code):
5157 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5158 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5159 (w32_system_caret_y, Qfile_name_history):
5160 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5161 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5162 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5163 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5164 * w32proc.c (Qlocal, report_file_error):
5165 * w32term.c (Vwindow_system, updating_frame):
5166 * w32uniscribe.c (initialized, uniscribe_font_driver):
5167 Remove unneeded extern declarations.
5168
2aa46d6c
CY
51692011-03-14 Chong Yidong <cyd@stupidchicken.com>
5170
c96bbc66 5171 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5172
cffc6f3b
CY
51732011-03-13 Chong Yidong <cyd@stupidchicken.com>
5174
5175 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5176 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5177 These macros can no longer be used for assignment.
5178
44f230aa
SM
5179 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5180 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5181 (record_buffer_markers, fetch_buffer_markers): New functions for
5182 recording and fetching special buffer markers.
5183 (set_buffer_internal_1, set_buffer_temp): Use them.
5184
5185 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5186
5187 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5188
5189 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5190 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5191
5192 * xdisp.c (hscroll_window_tree):
5193 (reconsider_clip_changes): Use PT instead of BUF_PT.
5194
d251f04b
EZ
51952011-03-13 Eli Zaretskii <eliz@gnu.org>
5196
5197 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5198 $(EMACS_ROOT)/lib/intprops.h.
5199
f0c77cd1
PE
52002011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5201
3eca4629
PE
5202 Fix more problems found by GCC 4.5.2's static checks.
5203
7c86ee98
PE
5204 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5205 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5206 (xg_free_frame_widgets): Make it clear that a local variable is
5207 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5208 (gdk_window_get_screen): Make it clear that this macro is needed
5209 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5210 (int_gtk_range_get_value): New function, which avoids a diagnostic
5211 from gcc -Wbad-function-cast.
5212 (xg_set_toolkit_scroll_bar_thumb): Use it.
5213 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5214 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5215 (get_utf8_string, xg_get_file_with_chooser):
5216 Rename locals to avoid shadowing.
5217 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5218
41729b81
PE
5219 * xgselect.c (xg_select): Remove unused var.
5220
f0c77cd1
PE
5221 * image.c (four_corners_best): Mark locals as initialized.
5222 (gif_load): Initialize transparent_p to zero (Bug#8238).
5223 Mark another local as initialized.
ec6cf4c6 5224 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5225
ce0ad53d 5226 * image.c (clear_image_cache): Now static.
d5d5a617 5227 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5228 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5229 (x_edge_detection): Remove unnecessary cast that
5230 gcc -Wbad-function-cast diagnoses.
2037898d 5231 (gif_load): Fix pointer signedness.
6ae141d6
PE
5232 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5233 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5234
33383987 52352011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5236
d32df629
PE
5237 Improve quality of tests for time stamp overflow.
5238 For example, without this patch (encode-time 0 0 0 1 1
5239 1152921504606846976) returns the obviously-bogus value (-948597
5240 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5241 reports time overflow. See
5242 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5243 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5244 * editfns.c: Include limits.h and intprops.h.
5245 (TIME_T_MIN, TIME_T_MAX): New macros.
5246 (time_overflow): Move earlier, to before first use.
5247 (hi_time, lo_time): New functions, for an accurate test for
5248 out-of-range times.
5249 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5250 (Fget_internal_run_time): Don't assume time_t fits in int.
5251 (make_time): Use list2 instead of Fcons twice.
5252 (Fdecode_time): More accurate test for out-of-range times.
5253 (check_tm_member): New function.
5254 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5255 (lisp_time_argument): Don't rely on undefined left-shift and
5256 right-shift behavior when checking for time stamp overflow.
8be6f318 5257
fe31d94c
PE
5258 * editfns.c (time_overflow): New function, refactoring common code.
5259 (Fformat_time_string, Fdecode_time, Fencode_time):
5260 (Fcurrent_time_string): Use it.
5261
8be6f318
PE
5262 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5263 * dired.c (make_time): Move to ...
5264 * editfns.c (make_time): ... here.
5265 * systime.h: Note the move.
5266
09d9db2c 52672011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5268
126bc0dc
YM
5269 * fringe.c (update_window_fringes): Remove unused variables.
5270
c47cbdfd
YM
5271 * unexmacosx.c (copy_data_segment): Also copy __got section.
5272 (Bug#8223)
5273
7ac80be9
EZ
52742011-03-12 Eli Zaretskii <eliz@gnu.org>
5275
c96bbc66 5276 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5277 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5278 Constify `char *' arguments and their references according to
5279 prototypes in tparam.h.
5280
ecb0f94d 5281 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5282
7ac80be9
EZ
5283 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5284 Adapt all references accordingly.
5285
5286 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5287
ef1fd07e
TT
52882011-03-11 Tom Tromey <tromey@redhat.com>
5289
5290 * buffer.c (syms_of_buffer): Remove obsolete comment.
5291
7ef4b50c
EZ
52922011-03-11 Eli Zaretskii <eliz@gnu.org>
5293
5294 * termhooks.h (encode_terminal_code): Declare prototype.
5295
5296 * msdos.c (encode_terminal_code): Don't declare prototype.
5297
5298 * term.c (encode_terminal_code): Now external again, used by
5299 w32console.c and msdos.c.
5300
44f230aa
SM
5301 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5302 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5303
4b1ec863 53042011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5305
1714f52b 5306 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5307
4b1ec863
PE
5308 * fringe.c (update_window_fringes): Mark locals as initialized
5309 (Bug#8227).
5310 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5311
524c7aa6
PE
5312 * alloc.c (mark_fringe_data): Move decl from here ...
5313 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5314 to check its interface.
5315 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5316
a5c0af81 5317 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5318 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5319 (fontset_font): Mark local as initialized.
a9a06e0b 5320 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5321
b4716021
PE
5322 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5323
811e9bac 5324 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5325 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5326 (x_own_selection, Fx_disown_selection_internal): Rename locals
5327 to avoid shadowing.
5328 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5329
7e3ab302
PE
5330 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5331 so that the caller can use some name other than gcpro1.
5332 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5333 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5334 (Fx_backspace_delete_keys_p):
5335 Use them to avoid shadowing, and rename vars to avoid shadowing.
5336 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5337 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5338 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5339 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5340 Remove unused locals.
7e3ab302
PE
5341 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5342 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5343 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5344 macros.
f78faa98 5345
e2b13473
PE
5346 * xterm.h (x_mouse_leave): New decl.
5347
77f23912
PE
5348 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5349 Remove unused functions.
cdf4ba58
PE
5350 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5351 (x_calc_absolute_position): Now static.
7411c686 5352 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5353 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5354 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5355 unless they are used.
38d0b34a
PE
5356 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5357 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5358 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5359 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5360 (x_error_catcher, x_connection_closed, x_error_handler):
5361 (x_error_quitter, xembed_send_message, x_iconify_frame):
5362 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5363 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5364 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5365
44f230aa
SM
5366 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5367 Rename or move locals to avoid shadowing.
6b463e58 5368 (tty_defined_color, merge_face_heights): Now static.
5967d051 5369 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5370 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5371 does not deduce is never used uninitialized.
73719eba
PE
5372 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5373 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5374
426994c3 5375 * terminal.c (store_terminal_param): Now static.
5489860b 5376
032f1620 5377 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5378 (set_frame_menubar): Remove unused local.
d4323972 5379 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5380 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5381 since they might point to immutable storage.
281585b0
PE
5382 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5383 since it's unused otherwise.
032f1620 5384
367c19e5 5385 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5386 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5387 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5388 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5389 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5390 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5391 does not deduce are never used uninitialized.
70739cbe 5392
07b48fa9
PE
5393 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5394
8868a238 5395 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5396 * window.c (window_loop, size_window):
5397 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5398
7e5cf297 5399 * window.c (display_buffer): Now static.
d6550a9f
PE
5400 (size_window): Mark variables that gcc -Wuninitialized
5401 does not deduce are never used uninitialized.
a586633d
PE
5402 * window.h (check_all_windows): New decl, to forestall
5403 gcc -Wmissing-prototypes diagnostic.
5b555da1 5404 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5405
f6095868
PE
5406 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5407 shadowing.
5408 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5409 Include <limits.h>.
5410 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5411 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5412 (load_charset_map): Mark variables that gcc -Wuninitialized
5413 does not deduce are never used uninitialized.
53df7c11 5414 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5415
f38b440c
PE
5416 * coding.c (coding_set_source, coding_set_destination):
5417 Use "else { /* comment */ }" rather than "else /* comment */;"
5418 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5419 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5420 a block, when the outer 'i' will do.
5421 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5422 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5423 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5424 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5425 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5426 Rename locals to avoid shadowing.
5427 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5428 * coding.c (emacs_mule_char, encode_invocation_designation):
5429 Now static, since they're not used elsewhere.
413bb2db 5430 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5431 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5432 (decode_coding_emacs_mule): Mark variables that gcc
5433 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5434 (detect_coding_iso_2022): Initialize a local variable that might
5435 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5436 this initialization is needed. (Bug#8211)
5f58e762
PE
5437 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5438 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5439 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5440 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5441 Remove unused macros.
f38b440c 5442
232b38b9 5443 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5444 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5445 * character.c (string_count_byte8): Likewise.
232b38b9 5446
fb90da1b
PE
5447 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5448 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5449
fb93dbc2
PE
5450 * chartab.c (copy_sub_char_table): Now static, since it's not used
5451 elsewhere.
5c156ace
PE
5452 (sub_char_table_ref_and_range, char_table_ref_and_range):
5453 Rename locals to avoid shadowing.
bbcd0949 5454 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5455
7d3b3862 5456 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5457 (BIDI_BOB): Remove unused macro.
7d3b3862 5458
6be7d3da
PE
5459 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5460 deduce are never used uninitialized.
c2ed9c8b 5461 * term.c (encode_terminal_code): Likewise.
6be7d3da 5462
75f8807f 5463 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5464
50938595
PE
5465 * tparam.h: New file.
5466 * term.c, tparam.h: Include it.
5467 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5468 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5469 Move these decls to tparam.h, and make them agree with what
5470 is actually in tparam.c. The previous trick of using incompatible
5471 decls in different modules does not conform to the C standard.
5472 All callers of tparam changed to use tparam's actual API.
5473 * tparam.c (tparam1, tparam, tgoto):
5474 Use const pointers where appropriate.
5475
fbceeba2
PE
5476 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5477 * cm.h (struct cm): Likewise.
5478 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5479 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5480 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5481 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5482 (turn_on_face, init_tty): Likewise.
5483 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5484
7f3f1250
PE
5485 * term.c (term_mouse_position): Rename local to avoid shadowing.
5486
e6ca6543
PE
5487 * alloc.c (mark_ttys): Move decl from here ...
5488 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5489
c40f8d15
AS
54902011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5491
5492 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5493
cfe0661d
JB
54942011-03-09 Juanma Barranquero <lekktu@gmail.com>
5495
5496 * search.c (compile_pattern_1): Remove argument regp, unused since
5497 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5498 (compile_pattern): Don't pass it.
5499
0afb4571
J
55002011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5501
5502 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5503 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5504 for ! HAVE_GTK3.
5505 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5506
5507 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5508
5509 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5510 gdk_window_get_screen, gdk_window_get_geometry,
5511 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5512 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5513 (xg_get_pixbuf_from_pixmap): New function.
5514 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5515 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5516 Call xg_get_pixbuf_from_pixmap instead of
5517 gdk_pixbuf_get_from_drawable.
5518 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5519 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5520 (xg_check_special_colors): Use GtkStyleContext and its functions
5521 for HAVE_GTK3.
5522 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5523 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5524 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5525 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5526 Call gtk_widget_get_preferred_size.
0afb4571
J
5527 (xg_frame_resized): gdk_window_get_geometry only takes 5
5528 parameters.
44f230aa
SM
5529 (xg_win_to_widget, xg_event_is_for_menubar):
5530 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5531 (xg_set_widget_bg): New function.
5532 (delete_cb): New function.
895009e1 5533 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5534 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5535 (xg_set_background_color): Call xg_set_widget_bg.
5536 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5537 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5538 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5539 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5540 if ! HAVE_GTK3.
5541 (update_frame_tool_bar): Call gtk_widget_hide.
5542 (xg_initialize): Use GDK_KEY_g.
5543
5544 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5545 if ! HAVE_GTK3
5546 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5547
5548 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5549 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5550 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5551
1c2cc4ef
JB
55522011-03-08 Juanma Barranquero <lekktu@gmail.com>
5553
5554 * w32xfns.c (select_palette): Check success of RealizePalette against
5555 GDI_ERROR, not zero.
5556
33383987 5557See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5558
5559;; Local Variables:
5560;; coding: utf-8
aac0c6e3
MR
5561;; End:
5562
33383987 5563 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5564
5565 This file is part of GNU Emacs.
5566
5567 GNU Emacs is free software: you can redistribute it and/or modify
5568 it under the terms of the GNU General Public License as published by
5569 the Free Software Foundation, either version 3 of the License, or
5570 (at your option) any later version.
5571
5572 GNU Emacs is distributed in the hope that it will be useful,
5573 but WITHOUT ANY WARRANTY; without even the implied warranty of
5574 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5575 GNU General Public License for more details.
5576
5577 You should have received a copy of the GNU General Public License
5578 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.