src/makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
81755f69
JB
12012-06-13 Juanma Barranquero <lekktu@gmail.com>
2
3 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
4
16192a57
GM
52012-06-13 Glenn Morris <rgm@gnu.org>
6
7 * s/bsd-common.h (BSD4_3):
8 * s/usg5-4-common.h (USG5_4): No longer define; unused.
9
646b5f55
AS
102012-06-13 Andreas Schwab <schwab@linux-m68k.org>
11
12 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
13 instead of union.
14 (XLI, XIL): Define.
15 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG): Use
16 them.
17 * emacs.c (gdb_use_struct): Renamed from gdb_use_union.
18 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
19 * alloc.c (widen_to_Lisp_Object): Removed.
20 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
21 * frame.c (delete_frame): Remove outdated comment.
22 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
23 USE_LISP_UNION_TYPE.
24 (Fw32_unregister_hot_key): Likewise.
25 (Fw32_toggle_lock_key): Likewise.
26 * w32menu.c (add_menu_item): Likewise.
27 (w32_menu_display_help): Use XIL instead of checking
28 USE_LISP_UNION_TYPE.
29 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
30 (init_heap): Likewise.
31 * w32term.c (w32_read_socket): Update comment.
32
1d3823c9
GM
332012-06-13 Glenn Morris <rgm@gnu.org>
34
c62ff706
GM
35 * s/usg5-4-common.h, src/s/unixware.h:
36 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
37
1d3823c9
GM
38 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
39
bfe3e0a2
PE
402012-06-13 Paul Eggert <eggert@cs.ucla.edu>
41
42 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
43 * alloc.c (make_number) [!defined make_number]:
44 Remove, as lisp.h always defines this now.
45 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
46 (roundup_size): Verify that it is a power of 2.
47 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
48 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
49 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
50 -DUSE_LSB_TAG=0, to override the automatically-selected default.
51 USE_LSB_TAG now is always defined to be either 0 or 1.
52 All uses changed.
53 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
54 code works fine either way, and efficiency is not a concern here,
55 as the union type is for debugging, not for production.
56 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
57 Use an inline function on all platforms when using the union type,
58 since this is simpler and 'static inline' can be used portably
59 within Emacs now.
60 (LISP_INITIALLY_ZERO): New macro.
61 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
62 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
63
45fa9c0f
GM
642012-06-12 Glenn Morris <rgm@gnu.org>
65
b4492cba
GM
66 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
67
68 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 69
45fa9c0f
GM
70 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
71 Move BROKEN_SIGIO to configure.
72
73 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
74 Move NO_TERMIO to configure.
75
0e25d334
CY
762012-06-12 Chong Yidong <cyd@gnu.org>
77
78 * image.c (imagemagick_load_image): Use MagickFlattenImage if
79 MagickMergeImageLayers is undefined. Use pixel pusher loop if
80 MagickExportImagePixels is undefined.
81
43682bb6
PE
822012-06-12 Paul Eggert <eggert@cs.ucla.edu>
83
84 * image.c (imagemagick_load_image): Remove unused label.
85
a9be7d2b
GM
862012-06-11 Glenn Morris <rgm@gnu.org>
87
88 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
89 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
90 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
91 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
92
3017f87f
SM
932012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
94
95 * alloc.c (make_byte_code): New function.
96 (Fmake_byte_code): Use it. Don't purify here.
97 * lread.c (read1): Use it as well to avoid extra allocation.
98
1b9b4cf4
CY
992012-06-11 Chong Yidong <cyd@gnu.org>
100
101 * image.c (imagemagick_load_image): Implement transparency.
102
95988fcf
AS
1032012-06-10 Andreas Schwab <schwab@linux-m68k.org>
104
105 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
106 account for preceding backslashes. (Bug#11663)
107
cd4eb164
CY
1082012-06-09 Chong Yidong <cyd@gnu.org>
109
110 * term.c: Support italics in capable terminals (Bug#9652).
111 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
112 (turn_on_face): Output using TS_enter_italic_mode if available.
113 Don't handle unused blinking and alt-charset cases.
114 (turn_off_face): Handle italic case; discard unused tty_blinking_p
115 and tty_alt_charset_p cases.
116 (tty_capable_p, init_tty): Support italics.
117
118 * termchar.h (struct tty_display_info): Add field for italics.
119 Remove unused blink field.
120
121 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
122 Handle slant.
123
124 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
125 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
126 tty_alt_charset_p. Add tty_italic_p.
127
ff88beb8
MA
1282012-06-09 Michael Albinus <michael.albinus@gmx.de>
129
130 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
131 dbus_type_is_basic if available.
132 (xd_extract_signed, xd_extract_unsigned): Rename from
133 extract_signed and extract_unsigned, respectively. Adapt callers.
134
44286096
CY
1352012-06-09 Chong Yidong <cyd@gnu.org>
136
1682701f
CY
137 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
138
44286096
CY
139 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
140 case (Bug#9752).
141
d86feb17
PE
1422012-06-08 Paul Eggert <eggert@cs.ucla.edu>
143
144 * xdisp.c (vmessage): Treat frame message as multibyte.
145 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
146 would generate the diagnostic "Making \302\247 buffer-local while
147 let-bound!".
148
d5c20fe8
EZ
1492012-06-08 Eli Zaretskii <eliz@gnu.org>
150
151 * dispnew.c (showing_window_margins_p): Undo last change, which
152 was done due to an inadvertent commit.
153 (adjust_frame_glyphs_for_frame_redisplay): Do call
154 showing_window_margins_p.
155
513749ee
SM
1562012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
157
158 * eval.c (Fmake_var_non_special): New primitive.
159 (syms_of_eval): Defsubr it.
160 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
161
d4a8f5c1
JB
1622012-06-08 Juanma Barranquero <lekktu@gmail.com>
163
164 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
165 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
166
8bbbc977
EZ
1672012-06-08 Eli Zaretskii <eliz@gnu.org>
168
169 * alloc.c (allocate_vectorlike): Fix last change.
170
f3372c87
DA
1712012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
172
173 Block-based vector allocation of small vectors.
174 * lisp.h (struct vectorlike_header): New field `nbytes',
175 adjust comment accordingly.
176 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
177 to denote vector blocks. Adjust users (live_vector_p,
178 mark_maybe_pointer, valid_lisp_object_p) accordingly.
179 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
180 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
181 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
182 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
183 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
184 (roundup_size): New constant.
185 (struct vector_block): New data type.
186 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 187 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
188 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
189 (sweep_vectors): New functions.
190 (allocate_vectorlike): Return `zero_vector' as the only vector of
191 0 items. Allocate new vector from block if vector size is less than
192 or equal to VBLOCK_BYTES_MAX.
193 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
194 (init_alloc_once): Add call to init_vectors.
195
4f18a4ed
SM
1962012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
197
198 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
199
86f158bc
PE
2002012-06-07 Paul Eggert <eggert@cs.ucla.edu>
201
202 * doprnt.c (doprnt): Truncate multibyte char correctly.
203 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
204 would mishandle a string argument "Xc" if X was a multibyte
205 character of length 2: it would truncate after X's first byte
206 rather than including all of X.
207
c5cfcbe0
CY
2082012-06-06 Chong Yidong <cyd@gnu.org>
209
210 * buffer.c (word_wrap): Doc fix.
211
c05cf390
PE
2122012-06-04 Paul Eggert <eggert@cs.ucla.edu>
213
214 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
215
0c3461de
GM
2162012-06-03 Glenn Morris <rgm@gnu.org>
217
218 * xdisp.c (tool-bar-style): Doc fix.
219
c71232db
UM
2202012-06-03 Ulrich Müller <ulm@gentoo.org>
221
222 * Makefile.in (PAXCTL): Define.
223 (temacs$(EXEEXT)): Disable memory randomization for the temacs
224 binary via PaX flags if the paxctl utility is available.
225 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
226 Restore PaX flags to their default. (Bug#11398)
227
383f7350
CY
2282012-06-03 Chong Yidong <cyd@gnu.org>
229
230 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
231 buffer (Bug#11226).
232
5f2c76c6
CY
2332012-06-03 Chong Yidong <cyd@gnu.org>
234
235 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
236 (note_mode_line_or_margin_highlight): If there is no help echo,
237 use mode-line-default-help-echo. Handle the case where the mouse
238 position is past the end of the mode line string.
239
240 * buffer.c (buffer_local_value_1): New function, split from
241 Fbuffer_local_value; can return Qunbound.
242 (Fbuffer_local_value): Use it.
243 (Vmode_line_format): Docstring tweaks.
244
773d47f6
PE
2452012-06-02 Paul Eggert <eggert@cs.ucla.edu>
246
247 * sysdep.c (system_process_attributes): Improve comment.
248
f2d6a3df
SM
2492012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
250
251 * keyboard.c: Export real-this-command to Elisp.
252 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
253 and DEFVAR it. Update all users.
254
63810350
PE
2552012-06-02 Paul Eggert <eggert@cs.ucla.edu>
256
7bd5c1f4
PE
257 * minibuf.c (Fassoc_string): Remove duplicate declaration.
258
63810350
PE
259 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
260 Convert pctcpu and pctmem to Lisp float properly.
261 Let the compiler fold better, as 100.0/0x8000 is exact.
262
a2821611
AS
2632012-06-02 Andreas Schwab <schwab@linux-m68k.org>
264
265 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
266 cons_block.
267
5fceba1d
PE
2682012-06-01 Paul Eggert <eggert@cs.ucla.edu>
269
270 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
271
c98ff5dd
DA
2722012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
273
274 For a 'struct window', replace some Lisp_Object fields to
275 bitfields where appropriate, remove unused fields.
276 * window.h (struct window): Remove unused 'last_mark_x' and
277 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
278 change it's type from Lisp_Object to bitfield.
279 Change type of 'force_start', 'optional_new_start',
280 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
281 fields from Lisp_Object to bitfield. Adjust users accordingly.
282
ca34e0be
PE
2832012-05-31 Paul Eggert <eggert@cs.ucla.edu>
284
285 Pacify gcc -Wdouble-precision when using Xaw.
286 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
287 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
288 Use 'float' consistently, rather than 'float' in most places
289 and 'double' in a couple of places.
290
efc00ab1 2912012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
292
293 * xdisp.c (handle_stop): Detect whether we have overlay strings
294 loaded by testing it->current.overlay_string_index to be
295 non-negative, instead of checking whether n_overlay_strings is
296 positive. (Bug#11587)
297
efc00ab1 2982012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
299
300 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
301
302 * doc.c (Fsubstitute_command_keys): Doc fix.
303
efc00ab1 3042012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
305
306 * search.c (search_buffer): Remove calls to
307 r_alloc_inhibit_buffer_relocation, as it is now called by
308 maybe_unify_char, which was the cause of relocation of buffer text
309 in bug#11519.
310
efc00ab1 3112012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
312
313 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
314 for the duration of call to load_charset, to avoid problems with
315 callers of maybe_unify_char that access buffer text through C
316 pointers.
317
318 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
319 decrement the inhibition flag, instead of just setting or
320 resetting it.
321
ba93a187
PE
3222012-05-31 Paul Eggert <eggert@cs.ucla.edu>
323
324 Remove obsolete '#define static' cruft.
325 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
326 This #undef was "temporary" in 2000; it is no longer needed
327 now that '#define static' has gone away.
328 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
329 (gray_bitmap_bits): Remove; no longer needed.
330 All uses replaced with definiens.
331 * xterm.c: Include "bitmaps/gray.xbm".
332
9e4bf381
PE
3332012-05-30 Paul Eggert <eggert@cs.ucla.edu>
334
335 Clean up __executable_start, monstartup when --enable-profiling.
336 The following changes affect the code only when profiling.
337 * dispnew.c (__executable_start): Rename from safe_bcopy.
338 Define only on platforms that need it.
339 * emacs.c: Include <sys/gmon.h> when profiling.
340 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
341 (__executable_start): Remove decl, since lisp.h does it now.
342 (safe_bcopy): Remove decl; no longer has that name.
343 (main): Coalesce #if into single bit of code, for simplicity.
344 Cast pointers to uintptr_t, since standard libraries want integers
345 and not pointers.
346 * lisp.h (__executable_start): New decl.
347
32d72c2f
GM
3482012-05-31 Glenn Morris <rgm@gnu.org>
349
350 * image.c (Fimagemagick_types): Doc fix.
351
baac5bc7
JM
3522012-05-30 Jim Meyering <meyering@redhat.com>
353
354 * callproc.c (Fcall_process_region): Include directory component
355 in mkstemp error message (Bug#11586).
356
72cb32cf
PE
3572012-05-30 Paul Eggert <eggert@cs.ucla.edu>
358
359 * alloc.c, lisp.h (make_pure_vector): Now static.
360
61b108cc
SM
3612012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
362
363 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
364 Move to byte-run.el.
365 (Fautoload): Do the hash-doc more carefully.
366 * data.c (Fdefalias): Purify definition, except for keymaps.
367 (Qdefun): Move from eval.c.
368 * lisp.h (Qdefun): Remove.
369 * lread.c (read1): Tiny simplification.
370
471fe23d
TN
3712012-05-29 Troels Nielsen <bn.troels@gmail.com>
372
934f3f58 373 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
374 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
375 Bug#9642, but explicitly check that the buffer the overlay would
376 be moved to is live and rearrange lines to make sure that errors
377 will not put the overlay in an inconsistent state.
378 (Fdelete_overlay): Cosmetics.
379
85d0efd1
EZ
3802012-05-28 Eli Zaretskii <eliz@gnu.org>
381
382 * w32term.c (my_bring_window_to_top): New function.
383 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
384 could be different from the original one.
385 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
386 (Bug#11513)
387
388 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
389 by calling BringWindowToTop.
390
391 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
392 (WM_EMACS_END): Increase by one.
393
da92a98c
PE
3942012-05-28 Paul Eggert <eggert@cs.ucla.edu>
395
396 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
397 This avoids undefined behavior that might cause the eassert
398 to not catch an out-of-range value.
399
74d1f848
JB
4002012-05-28 Juanma Barranquero <lekktu@gmail.com>
401
402 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
403 Update dependencies.
404
9e1a06fc
EZ
4052012-05-27 Eli Zaretskii <eliz@gnu.org>
406
407 * bidi.c (bidi_mirror_char): Fix last change.
408
f3dd7312
AS
4092012-05-27 Andreas Schwab <schwab@linux-m68k.org>
410
411 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
412 when referring to sectname field in printf format.
413
81899c91
PE
4142012-05-27 Paul Eggert <eggert@cs.ucla.edu>
415
57b81a9f
PE
416 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
417 Only r_alloc_inhibit_buffer_relocation needed to be added;
418 the others were already declared.
419
81899c91
PE
420 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
421 before checking whether it's out of range. Put the check inside
422 eassert. See
423 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
424
33017faf 4252012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
426
427 * callproc.c (Fcall_process): Restore a line that was accidentally
428 commented out in the 2011-02-13 change (bug#11547).
429
33017faf 4302012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
431
432 * lisp.h [REL_ALLOC]: Add prototypes for external functions
433 defined on ralloc.c.
434
435 * buffer.c [REL_ALLOC]: Remove prototypes of
436 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
437 they are now on lisp.h.
438
439 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
440
441 * search.c (search_buffer): Use it to inhibit relocation of buffer
442 text while re_search_2 is doing its job, because re_search_2 is
443 passed C pointers to buffer text. (Bug#11519)
444
23415acf
EZ
445 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
446 Update value to 24.
447
44e27368
EZ
448 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
449 state after an additional call to move_it_in_display_line_to, keep
450 the values of it->max_ascent and it->max_descent found for the
451 entire line.
452 (pos_visible_p): Revert the comparison against bottom_y to what it
453 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
454 (Bug#11464)
455
c1892f11
PE
4562012-05-26 Paul Eggert <eggert@cs.ucla.edu>
457
458 Fix coding-related core dumps with gcc -ftrapv.
459 The code was computing A - B, where A and B are pointers, and B is
460 random garbage. This can lead to core dumps on platforms that
461 have special pointer registers, and it also leads to core dumps on
462 x86-64 when compiled with gcc -ftrapv. The fix is to compute
463 A - B only when B is initialized properly.
464 * coding.c (coding_set_source, coding_set_destination): Return void.
465 (coding_change_source, coding_change_destinations): New functions,
466 with the old behaviors of coding_set_source and coding_set_destination.
467 All callers that need an offset changed to use these new functions.
468
eb7afdad
GM
4692012-05-26 Glenn Morris <rgm@gnu.org>
470
471 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
472
f12fdf02
EZ
4732012-05-26 Eli Zaretskii <eliz@gnu.org>
474
53a63be6 475 Extend mouse support on W32 text-mode console.
61b108cc
SM
476 * xdisp.c (draw_row_with_mouse_face):
477 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 478
eb3f6f01 479 * w32console.c: Include window.h.
61b108cc
SM
480 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
481 New functions.
eb3f6f01
EZ
482 (initialize_w32_display): Initialize mouse-highlight data.
483
53a63be6
EZ
484 * w32inevt.c: Include termchar.h and window.h.
485 (do_mouse_event): Support mouse-autoselect-window. When the mouse
486 moves, call note_mouse_highlight. If help_echo changed, call
487 gen_help_event to produce help-echo message in the echo area.
488 Call clear_mouse_face if mouse_face_hidden is set in the mouse
489 highlight info.
490
4cfd81f6
PE
4912012-05-26 Paul Eggert <eggert@cs.ucla.edu>
492
493 * lread.c (read1): Simplify slightly to avoid an overflow warning
494 with GCC 4.7.0 on x86-64.
495
4446092a
EZ
4962012-05-26 Eli Zaretskii <eliz@gnu.org>
497
498 * bidi.c (bidi_mirror_char): Revert last change: an int is
499 definitely wide enough here.
500
42b2a986 5012012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 502
42b2a986 503 Fix integer width and related bugs (Bug#9874).
eb106a49 504 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
505 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
506 (string_bytes, check_sblock, allocate_string_data):
507 (compact_small_strings, Fmake_bool_vector, make_string)
508 (make_unibyte_string, make_multibyte_string)
509 (make_string_from_bytes, make_specified_string)
510 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
511 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
512 (mark_vectorlike):
513 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
514 (allocate_pseudovector):
515 Use int, not EMACS_INT, where int is wide enough.
516 (inhibit_garbage_collection, Fgarbage_collect):
517 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
518 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
519 int might not be wide enough.
520 (bidi_cache_search, bidi_cache_find, bidi_init_it)
521 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
522 (bidi_at_paragraph_end, bidi_find_paragraph_start)
523 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
524 (bidi_level_of_next_char, bidi_move_to_visually_next):
525 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
526 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
527 (Fkill_buffer, Fset_buffer_major_mode)
528 (advance_to_char_boundary, Fbuffer_swap_text)
529 (Fset_buffer_multibyte, overlays_at, overlays_in)
530 (overlay_touches_p, struct sortvec, record_overlay_string)
531 (overlay_strings, recenter_overlay_lists)
532 (adjust_overlays_for_insert, adjust_overlays_for_delete)
533 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
534 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
535 (Foverlay_recenter, last_overlay_modification_hooks_used)
536 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
537 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
538 (validate_region): Omit unnecessary test for b <= e,
539 since that's guaranteed by the previous test.
d311d28c
PE
540 (adjust_overlays_for_delete): Avoid pos + length overflow.
541 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
542 (report_overlay_modification):
543 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
544 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
545 Omit pointer cast, which isn't needed anyway, and doesn't work
546 after the EMACS_INT -> ptrdiff_t change.
02481186 547 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
548 * buffer.h: Adjust decls to match defn changes elsewhere.
549 (struct buffer_text, struct buffer):
550 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
551 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
552 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
553 not int, to avoid needless 32-bit limit on 64-bit hosts.
554 (exec_byte_code): Use tighter memory-full test, one that checks
555 for alloca overflow. Don't compute the address of the object just
556 before an array, as that's not portable. Use EMACS_INT, not
557 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
558 * callint.c (Fcall_interactively):
559 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
560 * callproc.c (call_process_kill, Fcall_process):
561 Don't assume pid_t fits into an Emacs fixnum.
562 (call_process_cleanup, Fcall_process, child_setup):
563 Don't assume pid_t fits into int.
564 (call_process_cleanup, Fcall_process, delete_temp_file)
565 (Fcall_process_region):
566 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
567 (Fcall_process): Simplify handling of volatile integers.
568 Use int, not EMACS_INT, where int will do.
569 * casefiddle.c (casify_object, casify_region, operate_on_word)
570 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
571 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
572 (casify_object): Avoid integer overflow when overallocating buffer.
573 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 574 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
575 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
576 * category.h (CATEGORYP): Don't assume arg is nonnegative.
577 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
578 integers are now checked earlier. All uses replaced with XINT.
579 (ccl_driver):
580 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
581 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
582 (ccl_driver, Fregister_code_conversion_map):
583 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
584 (resolve_symbol_ccl_program): Check that vector header is in range.
585 Always copy the vector, so that we can check its contents reliably
586 now rather than having to recheck each instruction as it's being
587 executed. Check that vector words fit in 'int'.
588 (ccl_get_compiled_code, Fregister_ccl_program)
589 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
590 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
591 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
592 contents are in range.
593 (Fccl_execute_on_string): Check that status is in range.
594 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
595 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
596 Accept and return EMACS_INT, not int, because callers can pass values
597 out of 'int' range.
598 (c_string_width, strwidth, lisp_string_width, chars_in_text)
599 (multibyte_chars_in_text, parse_str_as_multibyte)
600 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
601 (str_as_unibyte, str_to_unibyte, string_count_byte8)
602 (string_escape_byte8, Fget_byte):
603 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 604 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
605 avoid mishandling large integers.
606 * character.h: Adjust decls to match defn changes elsewhere.
607 * charset.c (load_charset_map_from_file, find_charsets_in_text)
608 (Ffind_charset_region):
609 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
610 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
611 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 612 Don't assume fixnum fits in int.
d311d28c
PE
613 (load_charset_map_from_vector, Fmap_charset_chars):
614 Remove now-unnecessary CHECK_NATNUMs.
615 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
616 Don't rely on undefined behavior with signed left shift overflow.
617 Don't assume unsigned int fits into fixnum, or that fixnum fits
618 into unsigned int. Don't require max_code to be a valid fixnum;
619 that's not true for gb10830 4-byte on a 32-bit host. Allow
620 invalid_code to be a cons, for the same reason. Require code_offset
621 to be a character. Avoid int overflow if max_char is close
622 to INT_MAX.
623 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
624 this is intended anyway and avoids some undefined behavior.
625 (load_charset_map): Pass unsigned, not int, as 2nd arg of
626 INDEX_TO_CODE_POINT, as that's what it expects.
627 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
628 * charset.h (DECODE_CHAR): Return int, not unsigned;
629 this is what was intended anyway, and it avoids undefined behavior.
630 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
631 integer-overflow issues.
632 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
633 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
634 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
635 * chartab.c (Fmake_char_table, Fset_char_table_range)
636 (uniprop_get_decoder, uniprop_get_encoder):
637 Don't assume fixnum fits in int.
638 * cmds.c (move_point): New function, that does the gist of
639 Fforward_char and Fbackward_char, but does so while checking
640 for integer overflow more accurately.
c96e5d6a 641 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
642 (Fforward_line, Fend_of_line, internal_self_insert)
643 (internal_self_insert):
644 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
645 Fix a FIXME, by checking for integer overflow when calculating
646 target_clm and actual_clm.
647 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 648 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
649 (ASSURE_DESTINATION, coding_alloc_by_realloc)
650 (coding_alloc_by_making_gap, alloc_destination)
651 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
652 (encode_coding_utf_16, detect_coding_emacs_mule)
653 (decode_coding_emacs_mule, encode_coding_emacs_mule)
654 (detect_coding_iso_2022, decode_coding_iso_2022)
655 (encode_invocation_designation, encode_designation_at_bol)
656 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
657 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
658 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
659 (encode_coding_ccl, encode_coding_raw_text)
660 (detect_coding_charset, decode_coding_charset)
661 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
662 (produce_composition, produce_charset, produce_annotation)
663 (decode_coding, handle_composition_annotation)
664 (handle_charset_annotation, consume_chars, decode_coding_gap)
665 (decode_coding_object, encode_coding_object, detect_coding_system)
666 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
667 (code_convert_region, code_convert_string)
8f50130c
PE
668 (Fdefine_coding_system_internal)
669 (coding_set_source, coding_set_destination):
d311d28c
PE
670 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
671 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
672 (Fdefine_coding_system_internal):
673 Don't assume fixnums fit in int.
674 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 675 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
676 (Funencodable_char_position, Fcheck_coding_systems_region)
677 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 678 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 679 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 680 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 681 Don't access memory outside of the args array.
d311d28c 682 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
683 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
684 result of ENCODE_CHAR.
d311d28c
PE
685 * coding.h: Adjust decls to match defn changes elsewhere.
686 (struct coding_system):
687 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
688 * composite.c (get_composition_id, find_composition)
689 (run_composition_function, update_compositions)
690 (compose_text, composition_gstring_put_cache)
691 (composition_gstring_p, composition_gstring_width)
692 (fill_gstring_header, fill_gstring_body, autocmp_chars)
693 (composition_compute_stop_pos, composition_reseat_it)
694 (composition_update_it, struct position_record)
695 (find_automatic_composition, composition_adjust_point)
696 (Fcomposition_get_gstring, Ffind_composition_internal):
697 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
698 (update_compositions):
699 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
700 * composite.h: Adjust decls to match defn changes elsewhere.
701 (struct composition):
702 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
703 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
704 Do not attempt to compute the address of the object just before a
705 buffer; this is not portable.
706 (Faref, Faset):
707 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
708 (Faset): Use int, not EMACS_INT, where int is wide enough.
709 (Fstring_to_number): Don't assume fixnums fit in int.
710 (Frem): Don't assume arg is nonnegative.
711 * dbusbind.c (xd_append_arg): Check for integers out of range.
712 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 713 (extract_signed, extract_unsigned): New functions.
243e0530
PE
714 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
715 (xd_get_connection_references): Return ptrdiff_t, not int.
716 All uses changed.
717 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
718 (xd_read_message_1):
719 Use int, not unsigned, where the dbus API uses int.
720 (Fdbus_message_internal): Don't overflow mtype.
721 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
722 * dired.c (directory_files_internal, file_name_completion, scmp)
723 (file_name_completion_stat):
724 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
725 (file_name_completion): Don't overflow matchcount.
726 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
727 * dispextern.h: Adjust decls to match defn changes elsewhere.
728 (struct text_pos, struct glyph, struct bidi_saved_info)
729 (struct bidi_string_data, struct bidi_it, struct composition_it)
730 (struct it):
731 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
732 (struct display_pos, struct composition_it, struct it):
733 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
734 * dispnew.c (increment_matrix_positions)
735 (increment_row_positions, mode_line_string)
736 (marginal_area_string):
737 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 738 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
739 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
740 (duration_to_sec_usec): New function, to check for overflow better.
741 (Fsleep_for, sit_for): Use it.
742 * doc.c (get_doc_string, store_function_docstring):
743 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
744 (get_doc_string, Fsnarf_documentation):
745 Use int, not EMACS_INT, where int is wide enough.
746 (get_doc_string):
747 Use SAFE_ALLOCA, not alloca.
748 Check for overflow when converting EMACS_INT to off_t.
749 * doprnt.c (doprnt):
750 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
751 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
752 Don't assume uid_t fits into fixnum.
753 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
754 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
755 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
756 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
757 (general_insert_function)
758 (Finsert_char, make_buffer_string, make_buffer_string_both)
759 (update_buffer_properties, Fbuffer_substring)
760 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
761 (Fsubst_char_in_region, check_translation)
762 (Ftranslate_region_internal, save_restriction_restore, Fformat)
763 (transpose_markers, Ftranspose_regions):
764 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
765 (clip_to_bounds): Move to lisp.h as an inline function).
766 (Fconstrain_to_field): Don't assume integers are nonnegative.
767 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
768 (Fsubst_char_in_region, Fsave_restriction):
769 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
770 (Femacs_pid): Don't assume pid_t fits into fixnum.
771 (lo_time): Use int, not EMACS_INT, when int suffices.
772 (lisp_time_argument): Check for usec out of range.
773 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
774 (Fuser_login_name, Fuser_full_name): Signal an error
775 if a uid argument is out of range, rather than relying on
776 undefined behavior.
c8d5c857
PE
777 (Fformat_time_string): Remove now-unnecessary check.
778 lisp_time_argument checks for out-of-range usec now.
243e0530 779 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
780 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
781 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
782 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
783 (init_cmdargs, Fdump_emacs):
784 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
785 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
786 the bottom (typically) 32 bits of the fixnum.
787 * eval.c (specpdl_size, call_debugger):
788 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
789 (when_entered_debugger, Fbacktrace_debug):
790 Don't assume fixnum can fit in int.
791 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
792 the object just before a buffer; this is not portable.
793 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
794 (grow_specpdl, unbind_to):
795 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
796 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
797 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 798 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
799 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
800 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
801 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
802 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
803 (a_write, e_write):
804 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
805 (Fcopy_file, non_regular_nbytes, read_non_regular)
806 (Finsert_file_contents):
807 Use int, not EMACS_INT, where int is wide enough.
808 (READ_BUF_SIZE): Verify that it fits in int.
809 (Finsert_file_contents): Check that counts are in proper range,
810 rather than assuming fixnums fit into ptrdiff_t etc.
811 Don't assume fixnums fit into int.
125b3835 812 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
813 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
814 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
815 (string_char_to_byte, string_byte_to_char)
816 (string_make_multibyte, string_to_multibyte)
817 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
818 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
819 (substring_both, Fdelete, internal_equal, Ffillarray)
820 (Fclear_string, mapcar1)
821 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
822 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
823 (larger_vector, make_hash_table, maybe_resize_hash_table)
824 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
825 (Fmaphash, secure_hash):
826 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
827 (concat): Check for string index and length overflow.
828 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
829 (Frequire):
830 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
831 (larger_vector): New API (vec, incr_min, size_max) replaces old
832 one (vec, new_size, init). This catches size overflow.
833 INIT was removed because it was always Qnil.
834 All callers changed.
835 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
836 the upper bound on a hash table index size.
837 (make_hash_table, maybe_resize_hash_table): Use it.
838 (secure_hash): Computer start_byte and end_byte only after
839 they're known to be in ptrdiff_t range.
840 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
841 (Ffont_get_glyphs, Ffont_at):
842 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
843 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
844 (Flist_fonts, Fopen_font):
845 Don't assume fixnum can fit in int.
846 (check_gstring): Don't assume index can fit in int.
847 (font_match_p): Check that fixnum is a character, not a nonnegative
848 fixnum, since the later code needs to stuff it into an int.
849 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
850 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
851 conversion overflow issues.
852 (Fopen_font): Check for integer out of range.
853 (Ffont_get_glyphs): Don't assume index can fit in int.
854 * font.h: Adjust decls to match defn changes elsewhere.
855 * fontset.c (reorder_font_vector): Redo score calculation to avoid
856 integer overflow.
857 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
858 printmax_t, where ptrdiff_t is wide enough.
859 (Finternal_char_font):
860 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
861 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
862 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
863 (Fset_frame_position, x_set_frame_parameters)
864 (x_set_line_spacing, x_set_border_width)
865 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
866 Check that fixnums are in proper range for system types.
867 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
868 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
869 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
870 Use SAFE_ALLOCA_LISP, not alloca.
871 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
872 intptr_t is wide enough.
873 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
874 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
875 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
876 Check for fixnum out of range.
877 * ftfont.c (ftfont_list): Don't assume index fits in int.
878 Check that fixnums are in proper range for system types.
879 (ftfont_shape_by_flt):
880 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
881 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
882 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
883 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
884 Check that fixnums are in proper range for system types.
885 * gnutls.h: Adjust decls to match defn changes elsewhere.
886 * gtkutil.c (xg_dialog_run):
887 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
888 (update_frame_tool_bar):
889 Check that fixnums are in proper range for system types.
890 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 891 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
892 * indent.c (last_known_column, last_known_column_point):
893 (current_column_bol_cache):
894 (skip_invisible, current_column, check_display_width):
895 (check_display_width, scan_for_column, current_column_1)
896 (Findent_to, Fcurrent_indentation, position_indentation)
897 (indented_beyond_p, Fmove_to_column, compute_motion):
898 (Fcompute_motion, Fvertical_motion):
899 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
900 (last_known_column_modified): Use EMACS_INT, not int.
901 (check_display_width):
902 (Fcompute_motion):
903 Check that fixnums and floats are in proper range for system types.
904 (compute_motion): Don't assume index or fixnum fits in int.
905 (compute_motion, Fcompute_motion):
906 Use int, not EMACS_INT, when it is wide enough.
907 (vmotion): Omit local var start_hpos that is always 0; that way
908 we don't need to worry about overflow in expressions involving it.
909 * indent.h: Adjust decls to match defn changes elsewhere.
910 (struct position):
911 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
912 Use int, not EMACS_INT, where int is wide enough.
913 Remove unused members ovstring_chars_done and tab_offset;
914 all uses removed.
915 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
916 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
917 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
918 (make_gap, copy_text, insert, insert_and_inherit)
919 (insert_before_markers, insert_before_markers_and_inherit)
920 (insert_1, count_combining_before, count_combining_after)
921 (insert_1_both, insert_from_string)
922 (insert_from_string_before_markers, insert_from_string_1)
923 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
924 (adjust_after_replace, adjust_after_insert, replace_range)
925 (replace_range_2, del_range, del_range_1, del_range_byte)
926 (del_range_both, del_range_2, modify_region)
927 (prepare_to_modify_buffer, signal_before_change)
928 (signal_after_change, Fcombine_after_change_execute):
929 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
930 * intervals.c (traverse_intervals, rotate_right, rotate_left)
931 (balance_an_interval, split_interval_right, split_interval_left)
932 (find_interval, next_interval, update_interval)
933 (adjust_intervals_for_insertion, delete_node, delete_interval)
934 (interval_deletion_adjustment, adjust_intervals_for_deletion)
935 (static_offset_intervals, offset_intervals)
936 (merge_interval_right, merge_interval_left, make_new_interval)
937 (graft_intervals_into_buffer, temp_set_point_both)
938 (temp_set_point, set_point, adjust_for_invis_intang)
939 (set_point_both, move_if_not_intangible, get_property_and_range)
940 (get_local_map, copy_intervals, copy_intervals_to_string)
941 (compare_string_intervals, set_intervals_multibyte_1):
942 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
943 * intervals.h: Adjust decls to match defn changes elsewhere.
944 (struct interval):
945 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
946 * keyboard.c (this_command_key_count, this_single_command_key_start)
947 (before_command_key_count, before_command_echo_length, echo_now)
948 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
949 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
950 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
951 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
952 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
953 (last_non_minibuf_size, last_point_position, echo_truncate)
954 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
955 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
956 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
957 (stuff_buffered_input):
958 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
959 (last_auto_save, command_loop_1, read_char):
960 Use EMACS_INT, not int, to avoid integer overflow.
961 (record_char): Avoid overflow in total_keys computation.
962 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
963 * keyboard.h: Adjust decls to match defn changes elsewhere.
964 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
965 (Fkey_description, Fdescribe_vector, Flookup_key):
966 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
967 (click_position): New function, to check that positions are in range.
968 (Fcurrent_active_maps):
969 (describe_command):
970 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
971 (Faccessible_keymaps, Fkey_description):
972 (preferred_sequence_p):
973 Don't assume fixnum can fit into int.
974 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
975 Check for integer overflow in size calculations.
976 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
977 avoid mishandling large integers.
978 * lisp.h: Adjust decls to match defn changes elsewhere.
979 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
980 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
981 (struct Lisp_Marker):
982 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
983 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
984 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
985 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
986 All callers changed.
987 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
988 Assume the arg has valid form, since it always does.
989 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
990 unsigned integer system type.
991 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
992 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
993 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
994 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
995 (duration_to_sec_usec): New decl.
996 * lread.c (read_from_string_index, read_from_string_index_byte)
997 (read_from_string_limit, readchar, unreadchar, openp)
998 (read_internal_start, read1, oblookup):
999 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1000 (Fload, readevalloop, Feval_buffer, Feval_region):
1001 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1002 (openp): Check for out-of-range argument to 'access'.
1003 (read1): Use int, not EMACS_INT, where int is wide enough.
1004 Don't assume fixnum fits into int.
6efdadfd 1005 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1006 (read_filtered_event): Use duration_to_sec_usec
1007 to do proper overflow checking on durations.
d311d28c
PE
1008 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1009 in size calculation.
1010 (Fexecute_kbd_macro):
1011 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1012 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1013 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1014 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1015 (set_marker_both, set_marker_restricted_both, marker_position)
1016 (marker_byte_position, Fbuffer_has_markers_at):
1017 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1018 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1019 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1020 It now merely ensures that the menu is large enough, without
1021 necessarily growing it, as this avoids some integer overflow issues.
1022 All callers changed.
1023 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1024 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1025 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1026 Use SAFE_ALLOCA_LISP, not alloca.
1027 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1028 to EMACS_INT. Check that fixnums are in proper range for system types.
1029 * minibuf.c (minibuf_prompt_width, string_to_object)
1030 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1031 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1032 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1033 (get_minibuffer, read_minibuf_unwind):
1034 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1035 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1036 this simplifies overflow checking. All callers changed.
1037 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1038 (Ftest_completion):
1039 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1040 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1041 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1042 Check that fixnums are in proper range for system types.
1043 (Fx_create_frame, Fx_show_tip):
1044 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1045 * nsfont.m (ns_findfonts, nsfont_list_family):
1046 Don't assume fixnum fits in long.
1047 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1048 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1049 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1050 wide enough.
17fdb222 1051 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1052 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1053 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1054 (PRINTDECLARE, PRINTPREPARE):
1055 (strout, print_string):
1056 (print, print_preprocess, print_check_string_charset_prop)
1057 (print_object):
1058 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1059 (PRINTDECLARE):
1060 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1061 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1062 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1063 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1064 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1065 (print_error_message): Use SAFE_ALLOCA, not alloca.
1066 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1067 (print_depth, new_backquote_output, print_number_index):
1068 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1069 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1070 (Fset_process_window_size, Fformat_network_address)
1071 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1072 (sigchld_handler):
d311d28c 1073 Check that fixnums are in proper range for system types.
d44287d4 1074 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1075 Check for process-ids out of pid_t range rather than relying on
1076 undefined behavior.
e4d81efc 1077 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1078 (Fformat_network_address, read_process_output, send_process)
1079 (Fprocess_send_region, status_notify):
1080 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1081 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1082 (wait_reading_process_output, read_process_output, exec_sentinel):
1083 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1084 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1085 (Faccept_process_output): Use duration_to_sec_usec to do proper
1086 overflow checking on durations.
dde14581
PE
1087 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1088 Don't assume pid_t fits in int.
02481186
PE
1089 * process.h (struct Lisp_Process): Members tick and update_tick
1090 are now of type EMACS_INT, not int.
b62b53e8
PE
1091 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1092 configured --with-wide-int.
d311d28c
PE
1093 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1094 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1095 * search.c (looking_at_1, string_match_1):
1096 (fast_string_match, fast_c_string_match_ignore_case)
1097 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1098 (scan_newline, find_before_next_newline, search_command)
1099 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1100 (set_search_regs, wordify):
1101 (Freplace_match):
1102 (Fmatch_data):
1103 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1104 (string_match_1, search_buffer, set_search_regs):
1105 (Fmatch_data):
1106 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1107 (wordify): Check for overflow in size calculation.
1108 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1109 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1110 Check that fixnums are in proper range for system types.
1111 * sound.c (struct sound_device)
1112 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1113 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1114 (Fplay_sound_internal):
1115 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1116 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1117 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1118 (Fparse_partial_sexp):
1119 Don't assume fixnums can fit in int.
1120 (struct lisp_parse_state, find_start_pos, find_start_value)
1121 (find_start_value_byte, find_start_begv)
1122 (update_syntax_table, char_quoted, dec_bytepos)
1123 (find_defun_start, prev_char_comend_first, back_comment):
1124 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1125 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1126 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1127 (Finternal_describe_syntax_value): Check that match_lisp is a
1128 character, not an integer, since the code stuffs it into int.
1129 (scan_words, scan_sexps_forward):
1130 Check that fixnums are in proper range for system types.
1131 (Fforward_word):
1132 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1133 (scan_sexps_forward):
1134 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1135 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1136 * syntax.h: Adjust decls to match defn changes elsewhere.
1137 (struct gl_state_s):
1138 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1139 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1140 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1141 * sysdep.c (wait_for_termination_1, wait_for_termination)
1142 (interruptible_wait_for_termination, mkdir):
1143 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1144 (emacs_read, emacs_write):
1145 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1146 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1147 and double all fit in int.
d311d28c
PE
1148 * term.c (set_tty_color_mode):
1149 Check that fixnums are in proper range for system types.
1150 * termhooks.h (struct input_event):
1151 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1152 * textprop.c (validate_interval_range, interval_of)
1153 (Fadd_text_properties, set_text_properties_1)
1154 (Fremove_text_properties, Fremove_list_of_text_properties)
1155 (Ftext_property_any, Ftext_property_not_all)
1156 (copy_text_properties, text_property_list, extend_property_ranges)
1157 (verify_interval_modification):
1158 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1159 (Fnext_single_char_property_change)
1160 (Fprevious_single_char_property_change):
1161 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1162 (copy_text_properties):
1163 Check for integer overflow in index calculation.
d311d28c
PE
1164 * undo.c (last_boundary_position, record_point, record_insert)
1165 (record_delete, record_marker_adjustment, record_change)
1166 (record_property_change):
1167 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1168 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1169 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1170 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1171 (Fx_hide_tip, Fx_file_dialog):
1172 * w32menu.c (set_frame_menubar):
1173 Use ptrdiff_t, not int, for consistency with rest of code.
1174 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1175 (select_window, Fdelete_other_windows_internal)
1176 (window_scroll_pixel_based, window_scroll_line_based)
1177 (Frecenter, Fset_window_configuration):
1178 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1179 (Fset_window_hscroll, run_window_configuration_change_hook)
1180 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1181 (Fscroll_other_window, Frecenter):
d311d28c
PE
1182 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1183 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1184 Don't assume fixnum fits in int.
1185 (Fset_window_scroll_bars):
1186 Check that fixnums are in proper range for system types.
1187 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1188 (string_pos, c_string_pos, number_of_chars, init_iterator)
1189 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1190 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1191 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1192 (face_before_or_after_it_pos, handle_invisible_prop)
1193 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1194 (display_prop_intangible_p, string_buffer_position_lim)
1195 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1196 (get_overlay_strings_1, get_overlay_strings)
1197 (iterate_out_of_display_property, forward_to_next_line_start)
1198 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1199 (get_next_display_element, set_iterator_to_next)
1200 (get_visually_first_element, compute_stop_pos_backwards)
1201 (handle_stop_backwards, next_element_from_buffer)
1202 (move_it_in_display_line_to, move_it_in_display_line)
1203 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1204 (add_to_log, message_dolog, message_log_check_duplicate)
1205 (message2, message2_nolog, message3, message3_nolog
1206 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1207 (current_message_1, truncate_echo_area, truncate_message_1)
1208 (set_message, set_message_1, store_mode_line_noprop)
1209 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1210 (text_outside_line_unchanged_p, check_point_in_composition)
1211 (reconsider_clip_changes)
1212 (redisplay_internal, set_cursor_from_row, try_scrolling)
1213 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1214 (redisplay_window, find_last_unchanged_at_beg_row)
1215 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1216 (trailing_whitespace_p, find_row_edges, display_line)
1217 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1218 (display_mode_element, store_mode_line_string)
1219 (pint2str, pint2hrstr, decode_mode_spec)
1220 (display_count_lines, display_string, draw_glyphs)
1221 (x_produce_glyphs, x_insert_glyphs)
1222 (rows_from_pos_range, mouse_face_from_buffer_pos)
1223 (fast_find_string_pos, mouse_face_from_string_pos)
1224 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1225 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1226 (safe_call, init_from_display_pos, handle_fontified_prop)
1227 (handle_single_display_spec, load_overlay_strings)
1228 (with_echo_area_buffer, setup_echo_area_for_printing)
1229 (display_echo_area, echo_area_display)
1230 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1231 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1232 (redisplay_window, dump_glyph_row, display_mode_line)
1233 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1234 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1235 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1236 (handle_single_display_spec, build_desired_tool_bar_string)
1237 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1238 (get_specified_cursor_type):
1239 Check that fixnums are in proper range for system types.
1240 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1241 (Flookup_image_map):
1242 Don't assume fixnums fit in int.
1243 (compare_overlay_entries):
1244 Avoid mishandling comparisons due to subtraction overflow.
1245 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1246 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1247 (handle_tool_bar_click):
1248 Use int, not unsigned, since we prefer signed and the signedness
1249 doesn't matter here.
1250 (get_next_display_element, next_element_from_display_vector):
1251 Use int, not EMACS_INT, when int is wide enough.
1252 (start_hourglass): Use duration_to_sec_usec to do proper
1253 overflow checking on durations.
1254 * xfaces.c (Fbitmap_spec_p):
1255 Check that fixnums are in proper range for system types.
1256 (compare_fonts_by_sort_order):
1257 Avoid mishandling comparisons due to subtraction overflow.
1258 (Fx_family_fonts, realize_basic_faces):
1259 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1260 (Fx_family_fonts):
1261 Don't assume fixnum fits in int.
1262 Use SAFE_ALLOCA_LISP, not alloca.
1263 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1264 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1265 (face_at_buffer_position, face_for_overlay_string)
1266 (face_at_string_position):
1267 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1268 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1269 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1270 (Fx_show_tip):
1271 Check that fixnums are in proper range for system types.
1272 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1273 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1274 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1275 (Fx_change_window_property): Don't assume fixnums fit in int.
1276 * xfont.c (xfont_chars_supported):
1277 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1278 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1279 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1280 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1281 * xml.c (parse_region):
1282 * xrdb.c (magic_file_p):
1283 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1284 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1285 (x_get_local_selection, x_reply_selection_request)
1286 (x_handle_selection_request, wait_for_property_change):
1287 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1288 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1289 short is wide enough.
1290 (x_send_client_event): Don't assume fixnum fits in int.
1291 * xterm.c (x_x_to_emacs_modifiers):
1292 Don't assume EMACS_INT overflows nicely into int.
1293 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1294 may come from Lisp.
1295 (handle_one_xevent): NATNUMP can eval its arg twice.
1296 (x_connection_closed):
1297 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1298 * xterm.h: Adjust decls to match defn changes elsewhere.
1299 (struct scroll_bar): Use struct vectorlike_header
1300 rather than rolling our own approximation.
1301 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1302
c6574eb5
GM
13032012-05-25 Glenn Morris <rgm@gnu.org>
1304
1305 * lisp.mk (lisp): Update for more files being compiled now.
1306
e8d32c7e
SM
13072012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1308
48def666
SM
1309 * lread.c: Remove `read_pure' which makes no difference.
1310 (read_pure): Remove var.
1311 (unreadpure): Remove function.
1312 (readevalloop): Don't call read_list with -1 flag.
1313 (read1, read_vector): Don't test read_pure any more.
1314 (read_list): Simplify.
1315
e8d32c7e
SM
1316 * fileio.c, character.h: Minor style tweaks.
1317
4b2addb7
DA
13182012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1319
1320 * window.h (clip_changed): Remove useless declaration.
1321
584461b2
JB
13222012-05-22 Juanma Barranquero <lekktu@gmail.com>
1323
1324 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1325 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1326
34374650
PE
13272012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1328
1329 Remove src/m/*.
1330 This directory predates autoconf and is no longer needed nowadays.
1331 Move its few remaining bits of functionality to where they're needed.
1332 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1333 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1334 * m/template.h: Remove.
1335 * Makefile.in (M_FILE): Remove. All uses removed.
1336 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1337 * lisp.h (USE_LSB_TAG):
1338 * mem-limits.h (EXCEEDS_LISP_PTR):
1339 Use VAL_MAX, not VALBITS, in #if.
1340 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1341 (EMACS_UINT): Define unconditionally now.
1342 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1343 (BITS_PER_EMACS_INT): New constants, replacing
1344 what used to be in config.h, but not useful in #if.
1345 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1346 define them any more.
1347 (VAL_MAX): New macro.
1348 (VALMASK): Use it.
1349 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1350 BITS_PER_EMACS_INT, in #if.
1351 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1352 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1353 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1354 * s/ms-w32.h (DATA_START):
1355 Move here from removed file m/intel386.h.
1356 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1357 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1358
261cb4bb
PE
13592012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1360
1361 Assume C89 or later.
1362 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1363 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1364 (xrealloc):
1365 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1366 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1367 * textprop.c, tparam.c (NULL): Remove.
1368 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1369 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1370 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1371 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1372 * xterm.c (input_signal_count): Assume volatile works.
1373
ff23cd9f
KB
13742012-05-21 Ken Brown <kbrown@cornell.edu>
1375
1376 * xgselect.c (xg_select): Fix first argument in call to 'select'
1377 (bug#11508).
1378
1b170bc6
KB
13792012-05-20 Ken Brown <kbrown@cornell.edu>
1380
1381 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1382 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1383
b2f4d39f
KB
13842012-05-19 Ken Brown <kbrown@cornell.edu>
1385
1386 * xfns.c (x_in_use): Remove `static' qualifier.
1387 * xterm.h (x_in_use): Declare.
1388 * xgselect.c: Include xterm.h.
1389 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1390 and `display_arg' (bug#9754).
1391
003fdae2
PE
13922012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1393
9232a6d9
PE
1394 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1395
003fdae2
PE
1396 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1397 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1398
784b56e2
EZ
13992012-05-18 Eli Zaretskii <eliz@gnu.org>
1400
1401 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1402
1403 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1404 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1405
1406 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1407 reference to image_cache->refcount.
1408 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1409
a0a79cde
JL
14102012-05-17 Juri Linkov <juri@jurta.org>
1411
1412 * search.c (Fword_search_regexp, Fword_search_backward)
1413 (Fword_search_forward, Fword_search_backward_lax)
1414 (Fword_search_forward_lax): Move functions to isearch.el
1415 (bug#10145, bug#11381).
1416
b0572523
PE
14172012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1418
1419 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1420
9660f5fc
SM
14212012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1422
1423 * lread.c (init_obarray): Declare Qt and Qnil as special.
1424
4374de83
GM
14252012-05-14 Glenn Morris <rgm@gnu.org>
1426
1427 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1428 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1429
dc44c39a
PE
14302012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1431
078c97cb
PE
1432 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1433
dc44c39a
PE
1434 * unexaix.c: Port to more-recent AIX compilers.
1435 (report_error, report_error_1, make_hdr, copy_sym)
1436 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1437 Make arguments const char *, not char *, to avoid violations of C
1438 standard and to fix some AIX warnings reported by Gilles Pion.
1439
e18afed7 14402012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1441
1442 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1443 already have overlays loaded.
1444 (handle_single_display_spec): Before returning without displaying
1445 fringe bitmap, synchronize the bidi iterator with the main display
1446 iterator, by calling iterate_out_of_display_property.
1447 (iterate_out_of_display_property): Detect buffer iteration by
1448 testing that it->string is a Lisp string.
1449 (get_next_display_element): When the current object is exhausted,
1450 and there's something on it->stack, call set_iterator_to_next to
1451 proceed with what's on the stack, instead of returning zero.
1452 (set_iterator_to_next): If called at the end of a Lisp string,
1453 proceed to consider_string_end without incrementing string
1454 position. Don't increment display vector index past the end of
1455 the display vector. (Bug#11417)
c8fb9dc6
EZ
1456 (pos_visible_p): Don't report a position visible when move_it_to
1457 stopped at the last line of window, which happens to be scanned
1458 backwards by the bidi iteration. (Bug#11464)
ac268e67 1459
e18afed7 14602012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1461
1462 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1463 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1464 are on a TTY, and thus unable to display on the fringes.
1465 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1466 so we need to signal to the caller that this is a "replacing"
1467 display spec. This fixes display when the spec is invalid or we
1468 are on a TTY.
1469
e18afed7 14702012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1471
1472 * unexaix.c (make_hdr): Fix typo in prototype.
1473 This bug broke the build on AIX. Problem reported by Gilles Pion.
1474
9d0a235a
MA
14752012-05-14 Michael Albinus <michael.albinus@gmx.de>
1476
1477 * keyboard.c (kbd_buffer_get_event): Read special events also in
1478 batch mode. (Bug#11415)
1479
9e6b06ed
GM
14802012-05-12 Glenn Morris <rgm@gnu.org>
1481
1482 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1483
c1a1d7a3
EZ
14842012-05-12 Eli Zaretskii <eliz@gnu.org>
1485
1486 * lisp.mk (lisp): Add newcomment.elc.
1487
3fe7cdc8
GM
14882012-05-12 Glenn Morris <rgm@gnu.org>
1489
1490 * Makefile.in (MKDIR_P): New, set by configure.
1491 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1492
53f7d2c0
PE
14932012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1494
1495 Remove unused function hourglass_started.
1496 * dispextern.h (hourglass_started):
1497 * w32fns.c (hourglass_started):
1498 * xdisp.c (hourglass_started): Remove.
1499
75aafb17
JB
15002012-05-10 Juanma Barranquero <lekktu@gmail.com>
1501
1502 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1503 Update dependencies.
1504
12959e8e
PE
15052012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1506
97107e2e
PE
1507 * xgselect.c (xg_select): Put maxfds+1 into a var.
1508 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1509
12959e8e
PE
1510 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1511
836d29b3
DA
15122012-05-10 Dave Abrahams <dave@boostpro.com>
1513
1514 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1515 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1516
5cb67954
MA
15172012-05-09 Michael Albinus <michael.albinus@gmx.de>
1518
1519 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1520 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1521 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1522 Initialize xd_registered_buses.
1523
3478ec45
PE
15242012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1525
b263a6b0
PE
1526 Untag more efficiently if USE_LSB_TAG.
1527 This is based on a proposal by YAMAMOTO Mitsuharu in
1528 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1529 For an admittedly artificial (nth 8000 longlist) benchmark on
1530 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1531 Emacs's overall text size by 1%.
1532 * lisp.h (XUNTAG): New macro.
1533 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1534 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1535 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1536 * eval.c (Fautoload):
1537 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1538 * frame.h (XFRAME): Use XUNTAG.
1539
3478ec45
PE
1540 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1541 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1542 Remove unportable assumptions about print widths of types like
1543 dbus_uint32_t.
1544 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1545 intptr_t when converting between pointer and integer, to avoid GCC
1546 warnings about wrong width.
1547
666b903b 15482012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1549
1550 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1551 stack for each reader_thread, instead of defaulting to 8MB
1552 determined by the linker. This avoids failures in creating
1553 subprocesses on Windows 7, see the discussion in this thread:
1554 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1555
b120cc17
JC
15562012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1557
1558 Fix up display of the *Minibuf-0* buffer in the mini window.
1559 * keyboard.c (read_char): Don't clear the echo area if there's no
1560 message to clear.
1561 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1562 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 1563
9a4b36f8
MA
15642012-05-07 Michael Albinus <michael.albinus@gmx.de>
1565
1566 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1567 batch mode.
1568
e5f9458f
CY
15692012-05-06 Chong Yidong <cyd@gnu.org>
1570
1571 * lisp.mk (lisp): Update.
1572
eceeb5fc 15732012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
1574
1575 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1576
71873e2b
SM
15772012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1578
1579 * data.c (PUT_ERROR): New macro.
1580 (syms_of_data): Use it. Add new error type `user-error'.
1581 * undo.c (user_error): New function.
1582 (Fprimitive_undo): Use it.
1583 * print.c (print_error_message): Adjust print style for `user-error'.
1584 * keyboard.c (user_error): New function.
1585 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1586
ab0fa4e4
PE
15872012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1588
1589 Do not limit current-time-string to years 1000..9999.
1590 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1591 (Fcurrent_time_string): Support any year that is supported by the
1592 underlying localtime representation. Don't use asctime, as it
1593 has undefined behavior for years outside the range -999..9999.
1594
7ed806a7
PE
15952012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1596
1597 Fix race conditions involving setenv, gmtime, localtime, asctime.
1598 Without this fix, interrupts could mess up code that uses these
1599 nonreentrant functions, since setting TZ invalidates existing
1600 tm_zone or tzname values, and since most of these functions return
1601 pointers to static storage.
1602 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1603 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1604 Grow the critical sections to include not just invoking
1605 localtime/gmtime, but also accessing these functions' results
1606 including their tm_zone values if any, and any related TZ setting.
1607 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
1608 so that the struct tm is saved in the critical section.
1609 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
1610 motivated by the fact that memory allocation needs to be outside
1611 the critical section.
1612
0c16dfed
DA
16132012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1614
1615 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1616 with RESET_INTERVAL.
1617
1618 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1619 Remove duplicated buffer name initialization.
1620
3f83ace8
JM
16212012-05-02 Jim Meyering <jim@meyering.net>
1622
1623 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1624
c7b8541e
JM
1625 * xfns.c (x_window): Use xstrdup (Bug#11375).
1626
90207a15 16272012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
1628
1629 * xdisp.c (pos_visible_p): If already at a newline from the
1630 display string before the 'while' loop, don't walk back the glyphs
1631 from it3.glyph_row. Solves assertion violation when the display
1632 string begins with a newline (egg.el). (Bug#11367)
1633
b593d6a9
AH
16342012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1635
1636 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1637 Move to simple.el.
1638
4737362e
GM
16392012-05-01 Glenn Morris <rgm@gnu.org>
1640
99cf43f9
GM
1641 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1642 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1643 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1644 All were removed before 23.1.
1645
9311dcff
GM
1646 * dispnew.c: Remove HAVE_LIBNCURSES test;
1647 it is always true on relevant platforms.
1648
4d5c6349
GM
1649 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1650 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1651
4737362e
GM
1652 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1653
74dd3a6b
AS
16542012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1655
1656 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1657 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1658 Remove.
1659
13c379ee
PE
16602012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1661
1662 Do not avoid creating empty evaporating overlays (Bug#9642).
1663 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1664 That is, do not delete an evaporating overlay if it becomes
1665 empty after its bounds are adjusted to fit within its buffer.
1666 This fix caused other problems, and I'm reverting it until we get
1667 to the bottom of them.
1668
a8e7d6d7 16692012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
1670
1671 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1672
a8e7d6d7 16732012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
1674
1675 * xdisp.c (pos_visible_p): If the window start position is beyond
1676 ZV, start the display from buffer beginning. Prevents assertion
1677 violation in init_iterator when the minibuffer window is scrolled
1678 via the scroll bar.
1679
1680 * window.c (window_scroll_pixel_based): Likewise.
1681
a8e7d6d7 16822012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
1683
1684 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1685
a8e7d6d7 16862012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
1687
1688 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1689 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1690
a8e7d6d7 16912012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 1692
b593d6a9
AH
1693 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1694 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 1695
1c6900d9
EZ
16962012-04-26 Eli Zaretskii <eliz@gnu.org>
1697
4c3fa1d9
EZ
1698 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1699 display element, check also the underlying string or buffer
1700 character. (Bug#11341)
1701
1c6900d9
EZ
1702 * w32menu.c: Include w32heap.h.
1703 (add_menu_item): If the call to AppendMenuW (via
1704 unicode_append_menu) fails, disable Unicode menus only if we are
1705 running on Windows 9X/Me.
1706
42bf8205
AS
17072012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1708
1709 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1710 (xgetint): Add missing shift for LSB tags.
1711
b1bac16e
MR
17122012-04-24 Martin Rudalics <rudalics@gmx.at>
1713
1714 * keyboard.c (read_char): Don't wipe echo area for select window
1715 events: These might get delayed via `mouse-autoselect-window'
1716 (Bug#11304).
1717
d69621cc
JB
17182012-04-24 Juanma Barranquero <lekktu@gmail.com>
1719
1720 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1721 manipulation of :loaded-from data.
1722
02fd101b
JB
17232012-04-23 Juanma Barranquero <lekktu@gmail.com>
1724
1725 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1726 now a cons (bug#11311).
1727
888bec30
PE
17282012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1729
89a438bd
PE
1730 Do not create empty overlays with the evaporate property (Bug#9642).
1731 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1732 if it becomes empty after its bounds are adjusted to fit within
1733 its buffer. Without this fix, in a nonempty buffer (let ((o
1734 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1735 yields an empty overlay that has the evaporate property, which is
1736 not supposed to happen.
1737
1068fe4d
PE
1738 Fix minor GTK3 problems found by static checking.
1739 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1740 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1741 (struct _EmacsFixedClass, emacs_fixed_get_type):
1742 Move decls here from emacsgtkfixed.h, since they needn't be public.
1743 (emacs_fixed_get_type): Now static.
1744 (emacs_fixed_class_init): Omit unused local.
1745 (emacs_fixed_child_type): Remove; unused.
1746 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1747 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1748 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1749 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1750 (EMACS_FIXED_GET_CLASS): Remove; unused.
1751 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1752
888bec30
PE
1753 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1754 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1755
de85e130
PE
17562012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1757
d0baac98 1758 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 1759 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
1760 (__malloc_size_t, __malloc_ptrdiff_t):
1761 Remove. All uses removed, replaced by the definiens if needed,
1762 since we can assume C89 or better now.
1763 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1764 (protect_malloc_state, align, get_contiguous_space)
1765 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1766 (malloc_atfork_handler_child, malloc_enable_thread)
1767 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1768 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1769 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1770 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1771 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1772 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1773 Define using prototypes, not old style.
1774 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1775 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1776 (align): Don't assume that signed integer overflow wraps around.
1777 Omit unused local var.
1778 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1779 (_free_internal_nolock, memalign, mallochook, reallochook):
1780 Omit no-longer-needed casts.
1781 (valloc): Use getpagesize, not __getpagesize.
1782 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1783 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1784
de85e130
PE
1785 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1786
dcbf5805
MA
17872012-04-22 Michael Albinus <michael.albinus@gmx.de>
1788
1789 Move functions from C to Lisp. Make non-blocking method calls
1790 the default. Implement further D-Bus standard interfaces.
1791
1792 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1793 (QCdbus_request_name_allow_replacement)
1794 (QCdbus_request_name_replace_existing)
1795 (QCdbus_request_name_do_not_queue)
1796 (QCdbus_request_name_reply_primary_owner)
1797 (QCdbus_request_name_reply_in_queue)
1798 (QCdbus_request_name_reply_exists)
1799 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1800 (QCdbus_registered_serial, QCdbus_registered_method)
1801 (QCdbus_registered_signal): New Lisp objects.
1802 (XD_DEBUG_MESSAGE): Use sizeof.
1803 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1804 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1805 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1806 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1807 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1808 (xd_signature, xd_append_arg): Allow float for integer types.
1809 (xd_get_connection_references): New function.
b593d6a9
AH
1810 (xd_get_connection_address): Rename from xd_initialize.
1811 Return cached address.
dcbf5805
MA
1812 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1813 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1814 level.
1815 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 1816 Return number of refcounts.
dcbf5805
MA
1817 (Fdbus_get_unique_name): Make stronger parameter check.
1818 (Fdbus_message_internal): New defun.
1819 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1820 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1821 (Fdbus_send_signal, Fdbus_register_service)
1822 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1823 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1824 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1825 (Vdbus_compiled_version, Vdbus_runtime_version)
1826 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1827 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1828 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
1829 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1830 Adapt docstring.
dcbf5805 1831
52828e02
PE
18322012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1833
da05bc4c
PE
1834 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1835 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1836 Do not assume ptrdiff_t is the same width as 'int'.
1837
52828e02
PE
1838 * alloc.c: Handle unusual debugging option combinations.
1839 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1840 since the two debugging options are incompatible.
1841 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1842 is defined.
1843 (mem_init, mem_insert, mem_insert_fixup):
1844 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1845 (NEED_MEM_INSERT): Remove; no longer needed.
1846
f01769f9
LL
18472012-04-22 Leo Liu <sdl.web@gmail.com>
1848
1849 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1850
5790543d
PE
18512012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1852
1853 * sysdep.c [__FreeBSD__]: Minor cleanups.
1854 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1855 Use Emacs indenting style more consistently. Avoid some casts.
1856 Use 'double' consistently rather than mixing 'float' and 'double'.
1857
b91b7e4d
EW
18582012-04-21 Eduard Wiebe <usenet@pusto.de>
1859
b593d6a9
AH
1860 * sysdep.c (list_system_processes, system_process_attributes):
1861 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 1862
6114eb15
AS
18632012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1864
1865 * lisp.mk (lisp): Update.
1866
2f38dff7
PE
18672012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1868
1869 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1870 It is never used otherwise.
1871
4ae29f89
SM
18722012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1873
1874 * print.c (print_preprocess): Only check print_depth if print-circle
1875 is nil.
1876 (print_object): Check for cycles even when print-circle is nil and
1877 print-gensym is t, but only check print_depth if print-circle is nil.
1878
f30d612a
CY
18792012-04-20 Chong Yidong <cyd@gnu.org>
1880
1881 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1882 set the status to "failed" and ensure that sentinel is run.
1883
c07a4c0b 18842012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
1885
1886 * process.c (Fset_process_inherit_coding_system_flag)
1887 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 1888 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 1889
c07a4c0b 18902012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
1891
1892 * xdisp.c (string_buffer_position_lim): Limit starting position to
1893 BEGV.
1894 (set_cursor_from_row): If called for a mode-line or header-line
1895 row, return zero immediately.
1896 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
1897 farther than the first row after the header line, if any.
1898 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
1899 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1900
c07a4c0b 19012012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1902
4ae29f89
SM
1903 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1904 (bug#11238).
ad3a2b41 1905
c07a4c0b 19062012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 19072012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
1908
1909 configure: new option --enable-gcc-warnings (Bug#11207)
1910 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1911 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1912 (ALL_CFLAGS): Use new macros rather than old.
1913 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1914 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1915 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1916 -Wunused-result, -Wunused-variable. This should go away once
1917 the Emacs and Gnulib regex code is merged.
1918 (xmalloc, xrealloc): Now static.
1919
aba027e8
PE
19202012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1921
1922 * dired.c (Fsystem_groups): Remove unused local.
1923
e5a36063
GM
19242012-04-17 Glenn Morris <rgm@gnu.org>
1925
1926 * dired.c (Fsystem_users): Doc fix.
1927
316411f0
DA
19282012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1929
1930 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1931 (syms_of_dired): Add them.
1932
9426aba4
PE
19332012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1934
b62a57be
PE
1935 Fix minor alloc.c problems found by static checking.
1936 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1937 New extern decls, to avoid calling undeclared functions.
1938 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1939 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1940 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1941 (NEED_MEM_INSERT): New macro.
1942 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 1943 Remove one incorrect comment and fix another.
b62a57be 1944
3539f31f
PE
1945 Fix minor ralloc.c problems found by static checking.
1946 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1947 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1948 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1949 (r_alloc_sbrk): Now static.
1950
a041960a
PE
1951 Improve ralloc.c interface checking.
1952 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1953 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1954 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1955 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1956 [REL_ALLOC]: ... to here, to check interface.
1957 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1958 Remove decls. This fixes an "It stinks!".
1959
9426aba4
PE
1960 * alloc.c (which_symbols): Fix alignment issue / type clash.
1961
d55c12ed
AS
19622012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1963
1964 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1965 (struct Lisp_Misc_Any): Likewise.
1966 (struct Lisp_Free): Likewise.
1967 * alloc.c (union aligned_Lisp_Symbol): Define.
1968 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1969 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1970 (union aligned_Lisp_Misc): Define.
1971 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1972 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 1973 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 1974
b948ce8b
PE
19752012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1976
1977 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1978 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1979 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1980 * s/netbsd.h, s/sol2-6.h:
1981 Remove definition of GC_MARK_STACK, since the default now works.
1982 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1983 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1984 no longer the default.
1985 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1986
35dc09a1 19872012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1988
35dc09a1
GM
1989 * lread.c (lisp_file_lexically_bound_p):
1990 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 1991
35dc09a1
GM
19922012-04-14 Eli Zaretskii <eliz@gnu.org>
1993
1994 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1995 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1996
19972012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1998
1999 * nsterm.m (constrainFrameRect): Always constrain when there is only
2000 one screen (Bug#10962).
2001
bcd86815
KB
20022012-04-13 Ken Brown <kbrown@cornell.edu>
2003
2004 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2005
c25df26e
RT
20062012-04-13 Reuben Thomas <rrt@sc3d.org>
2007
2008 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2009
0fc59f1e
DC
20102012-04-11 Daniel Colascione <dancol@dancol.org>
2011
2012 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2013 against is gone. It's better to use vfork now so that when Cygwin
2014 gains a new, working vfork, we use it automatically (bug#10398).
2015
de8c03dc
SM
20162012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2017
2018 * window.c (save_window_save): Obey window-point-insertion-type.
2019
2f097256
GM
20202012-04-11 Glenn Morris <rgm@gnu.org>
2021
2022 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2023
453b951e
SM
20242012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2025
2026 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2027
75f1671a 20282012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2029
2030 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2031 (force_quit_count): New var.
2032 (handle_interrupt): Use it.
2033
2a8ce227
JB
20342012-04-10 Juanma Barranquero <lekktu@gmail.com>
2035
2036 * w32.c (w32_delayed_load): Record the full path of the library
2037 being loaded (bug#10424).
2038
935396c0
GM
20392012-04-09 Glenn Morris <rgm@gnu.org>
2040
05920a43
GM
2041 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2042 not just in the obarray, before snarfing them. (Bug#11036)
2043
935396c0
GM
2044 * Makefile.in ($(leimdir)/leim-list.el):
2045 Pass EMACS rather than BUILT_EMACS.
2046
a18ecafa
TZ
20472012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2048
2049 * process.c (make_process):
2050 * process.h: Add integer `gnutls_handshakes_tried' member to
2051 process struct.
2052
6bbef4e5
JC
2053 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2054 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2055
2056 * gnutls.c (gnutls_log_function2i): Convenience log function.
2057 (emacs_gnutls_read): Use new log functions,
2058 `gnutls_handshakes_tried' process member, and
2059 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2060 attempts per process (connection).
2061
b4d3bc10
CY
20622012-04-09 Chong Yidong <cyd@gnu.org>
2063
2064 * eval.c (Fuser_variable_p, user_variable_p_eh)
2065 (lisp_indirect_variable): Functions deleted.
2066 (Fdefvar): Caller changed.
2067
2068 * callint.c (Finteractive, Fcall_interactively):
2069 * minibuf.c (Fread_variable): Callers changed.
2070
70f4d973
EZ
20712012-04-09 Eli Zaretskii <eliz@gnu.org>
2072
2073 * xdisp.c (set_cursor_from_row): If the display string appears in
2074 the buffer at position that is closer to point than the position
2075 after the display string, display the cursor on the first glyph of
2076 the display string. Fixes cursor display when a 'display' text
2077 property immediately follows invisible text. (Bug#11094)
2078
cb3c2e3e
PE
20792012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2080
2081 composite.c: use 'double' consistently
2082 * composite.c (get_composition_id): Use 'double' consistently
2083 instead of converting 'float' to 'double' and vice versa; this is
2084 easier to understand and avoids a GCC warning.
2085
fd06db5d
GM
20862012-04-09 Glenn Morris <rgm@gnu.org>
2087
50fe702a
GM
2088 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2089 preparation for dumping it with emacs. (Bug#4789)
2090 (leimdir): New variable.
2091 ($(leimdir)/leim-list.el): New rule.
2092 (emacs$(EXEEXT)): Depend on leim-list.el.
2093
fd06db5d
GM
2094 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2095 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2096 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2097
55c131ee
AS
20982012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2099
2100 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2101 proper alignment.
2102
9209588f
JB
21032012-04-07 Juanma Barranquero <lekktu@gmail.com>
2104
2105 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2106 Remove unused local variable.
2107
e3fb2efb
PE
21082012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2109
2110 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2111 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2112 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2113 objects, as mark_maybe_pointer will catch them otherwise.
2114 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2115 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2116
b5385551
PE
21172012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2118
2119 Fix typo that broke non-Windows builds.
2120 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2121
9078ead6
EZ
21222012-04-07 Eli Zaretskii <eliz@gnu.org>
2123
2124 Support building on MS-Windows with libxml2.
2125
2126 * makefile.w32-in (OBJ2): Add xml.$(O).
2127 (GLOBAL_SOURCES): Add xml.c.
2128 ($(BLD)/xml.$(O)): New dependency list.
2129
2130 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2131 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2132 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2133 [!WINDOWSNT]: New macros.
2134 (init_libxml2_functions, libxml2_loaded_p): New functions.
2135 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2136 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2137 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2138 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2139 linked in).
6bbef4e5
JC
2140 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2141 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2142 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2143
2144 * emacs.c: Don't include libxml/parser.h.
2145 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2146 xmlCleanupParser directly.
2147
2148 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2149
3811fdf3
EZ
21502012-04-07 Eli Zaretskii <eliz@gnu.org>
2151
2152 * indent.c (Fvertical_motion): If there is a display string at
2153 point, use it.vpos to compute how many lines to backtrack after
2154 move_it_to point. (Bug#11133)
2155
2f8e16b2
EZ
21562012-04-06 Eli Zaretskii <eliz@gnu.org>
2157
2158 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2159 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2160 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2161 macros related to unification of CJK characters. For the details,
2162 see the discussion following the message here:
2163 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2164
3d439cd1
CY
21652012-04-04 Chong Yidong <cyd@gnu.org>
2166
2167 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2168
8bc53d00
EZ
21692012-04-01 Eli Zaretskii <eliz@gnu.org>
2170
2171 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2172 instead of alloca. (Bug#11138)
2173
3b0512a3
AS
21742012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2175
2176 * w32menu.c (is_simple_dialog): Properly check lisp types.
2177 (Bug#11141)
2178
8427ddd2
EZ
21792012-03-31 Eli Zaretskii <eliz@gnu.org>
2180
979022ef
EZ
2181 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2182 position we get to after a call to move_it_to fails the
2183 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2184 only if we wind up in a string from display property. (Bug#11063)
2185
a6b1c7cc
EZ
2186 * window.c (Fdelete_other_windows_internal): Invalidate the row
2187 and column information about mouse highlight, so that redisplay
2188 restores it after reallocating the glyph matrices. (Bug#7464)
2189
8427ddd2
EZ
2190 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2191 string comes from a `display' text property, use the buffer
2192 position of that property as if we actually saw that position in
2193 the row's glyphs.
697ba24b
EZ
2194 (move_it_by_lines): Remove the assertion that
2195 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2196 violated when there's a before-string at the beginning of a line.
2197 (Bug#11063)
8427ddd2 2198
65a0a738
EZ
21992012-03-30 Eli Zaretskii <eliz@gnu.org>
2200
2201 * xdisp.c (append_space_for_newline): If the default face was
2202 remapped, use the remapped face for the appended newline.
2203 (extend_face_to_end_of_line): Use the remapped default face for
2204 extending the face to the end of the line.
2205 (display_line): Call extend_face_to_end_of_line when the default
2206 face was remapped. (Bug#11068)
2207
581355cc
EZ
22082012-03-29 Eli Zaretskii <eliz@gnu.org>
2209
2210 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2211
e8fc049f
SM
22122012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2213
2214 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2215
4fb9a543
GM
22162012-03-27 Glenn Morris <rgm@gnu.org>
2217
2218 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2219 Doc fixes.
2220
679910f1
KH
22212012-03-26 Kenichi Handa <handa@m17n.org>
2222
2223 * dispextern.h (struct glyph): Fix previous change. Change the
2224 bit length of glyphless.ch to 25 (Bug#11082).
2225
90d49b7f
CY
22262012-03-26 Chong Yidong <cyd@gnu.org>
2227
2228 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2229 (command_loop_1): Use it; inhibit selection update for
2230 handle-select-window too (Bug#8996).
2231
f514f6f0
FP
22322012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2233
e8fc049f 2234 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2235
bf43fa51
KH
22362012-03-25 Kenichi Handa <handa@m17n.org>
2237
2238 * dispextern.h (struct glyph): Change the bit length of
2239 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2240
8a0c01dd
EZ
22412012-03-24 Eli Zaretskii <eliz@gnu.org>
2242
2243 * s/ms-w32.h (tzname): Include time.h before redirecting to
2244 _tzname. Fixes the MSVC build. (Bug#9960)
2245
7d1c3a76
AS
22462012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2247
8ed79523
AS
2248 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2249 characters.
2250
7d1c3a76
AS
2251 * xterm.c (XTread_socket): Only modify handling_signal if
2252 !SYNC_INPUT. (Bug#11080)
2253
e99a9b8b
EZ
22542012-03-23 Eli Zaretskii <eliz@gnu.org>
2255
2256 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2257 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2258 when fetching a multibyte character consumes more bytes than
2259 CHAR_BYTES returns, due to unification of CJK characters in
2260 string_char. (Bug#11073)
2261
5063c0e1
TN
22622012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2263
2264 * process.c (wait_reading_process_output): Handle pty disconnect
2265 by refraining from sending oneself a SIGCHLD (bug#10933).
2266
9f851fbd
CY
22672012-03-22 Chong Yidong <cyd@gnu.org>
2268
2269 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2270
5063c0e1 2271 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2272 Mark string as coming from a prefix property.
2273 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2274 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2275
fb5b8aca
CY
22762012-03-21 Chong Yidong <cyd@gnu.org>
2277
2278 * xfaces.c (Vface_remapping_alist): Doc fix.
2279
62356a1b
EZ
22802012-03-20 Eli Zaretskii <eliz@gnu.org>
2281
2282 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2283 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2284 Doc fixes.
62356a1b 2285
025de85b
CY
22862012-03-20 Chong Yidong <cyd@gnu.org>
2287
2288 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2289 to reflect default non-nil value of redisplay-dont-pause.
2290
4827f94e
KH
22912012-03-19 Kenichi Handa <handa@m17n.org>
2292
2293 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2294 it fit in a valid range (Bug#11003).
2295
e50a24a2
EZ
22962012-03-18 Eli Zaretskii <eliz@gnu.org>
2297
2298 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2299 that is not from display property, accept the row as a "cursor
2300 row" if one of the string's character has a non-nil `cursor'
2301 property. Fixes cursor positioning when there are newlines in
2302 overlay strings, e.g. in icomplete.el. (Bug#11035)
2303
9af5ed87
PE
23042012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2305
2306 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2307
d1f55f16
CY
23082012-03-12 Chong Yidong <cyd@gnu.org>
2309
2310 * eval.c (inhibit_lisp_code): Rename from
2311 inhibit_window_configuration_change_hook; move from window.c.
2312
2313 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2314 * window.c (run_window_configuration_change_hook)
2315 (syms_of_window): Callers changed.
2316
66c5eebd
CY
23172012-03-11 Chong Yidong <cyd@gnu.org>
2318
413df973
CY
2319 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2320
66c5eebd
CY
2321 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2322
1de11f56
CY
23232012-03-10 Chong Yidong <cyd@gnu.org>
2324
2325 * frame.c (other_visible_frames): Don't assume the selected frame
2326 is visible (Bug#10955).
2327
cae07000
SM
23282012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2329
2330 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2331
89c94350
JD
23322012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2333
2334 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2335 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2336 zero (Bug#10954).
2337
999dd333
GM
23382012-03-03 Glenn Morris <rgm@gnu.org>
2339
01a6dcc8 2340 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2341
de0100f2
EZ
23422012-03-02 Eli Zaretskii <eliz@gnu.org>
2343
2344 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2345 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2346 (redisplay_window, next_element_from_string): Fix typos in
2347 comments.
3e441275
EZ
2348 (redisplay_window): Pass to move_it_vertically the margin in
2349 pixels, not in screen lines.
de0100f2 2350
96a72ee9
GM
23512012-03-02 Glenn Morris <rgm@gnu.org>
2352
2353 * buffer.c (buffer-list-update-hook): Doc fix.
2354
312508d7
EZ
23552012-02-29 Eli Zaretskii <eliz@gnu.org>
2356
2357 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2358 push_it before setting up the iterator for the first overlay
2359 string, even if we have an empty string loaded.
2360 (next_overlay_string): If there's an empty string on the iterator
2361 stack, pop the stack. (Bug#10903)
2362
27f3c637
PE
23632012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2364
2365 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2366 Suggested by Stefan Monnier in
2367 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2368 * alloc.c (widen_to_Lisp_Object): New static function.
2369 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2370 and widening them to Lisp_Objects. This would work even if
2371 USE_LSB_TAG is defined and wide integers are used, which might
2372 happen in a future version of Emacs.
2373
3c9dfce6
CY
23742012-02-25 Chong Yidong <cyd@gnu.org>
2375
fa74b241
CY
2376 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2377 Doc fix.
2378
3c9dfce6
CY
2379 * xselect.c (Fx_selection_exists_p): Doc fix.
2380 (x_clipboard_manager_save_all): Print an informative message
2381 before saving to clipboard manager.
2382
9486df08
CY
23832012-02-24 Chong Yidong <cyd@gnu.org>
2384
2385 * keyboard.c (process_special_events): Handle all X selection
2386 requests in kbd_buffer, not just the next one (Bug#8869).
2387
f01d3321
CY
23882012-02-23 Chong Yidong <cyd@gnu.org>
2389
2390 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2391 call when setting menu-bar-lines and tool-bar-lines parameters.
2392 (unwind_create_frame_1): New helper function.
2393
2394 * window.c (inhibit_window_configuration_change_hook): New var.
2395 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2396 (syms_of_window): Initialize it.
f01d3321 2397
86b847b6
CY
23982012-02-22 Chong Yidong <cyd@gnu.org>
2399
2400 * xterm.c (x_draw_image_relief): Add missing type check for
2401 Vtool_bar_button_margin (Bug#10743).
2402
a59225b1
CY
24032012-02-21 Chong Yidong <cyd@gnu.org>
2404
2405 * fileio.c (Vfile_name_handler_alist): Doc fix.
2406
2407 * buffer.c (Fget_file_buffer): Protect against invalid file
2408 handler return value.
2409
310f5bd4
PE
24102012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2411
cb3a28cc
PE
2412 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2413 when computing $valmask.
2414
310f5bd4
PE
2415 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2416 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2417 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2418 It's useless in that case, and it can cause problems on hosts
2419 that allocate halves of EMACS_INT values separately.
2420 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2421 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2422 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2423 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2424 it avoids undefined behavior on hosts where shifting right by more
2425 than the word width has undefined behavior.
2426
2375c96a
CY
24272012-02-19 Chong Yidong <cyd@gnu.org>
2428
2429 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2430 (Funhandled_file_name_directory, Ffile_name_as_directory)
2431 (Fdirectory_file_name, Fexpand_file_name)
2432 (Fsubstitute_in_file_name): Protect against invalid file handler
2433 return values (Bug#10845).
2434
3eb49e71
EZ
24352012-02-18 Eli Zaretskii <eliz@gnu.org>
2436
2437 * .gdbinit (pitx): Fix incorrect references to fields of the
2438 iterator stack.
2439
7b926f3f
CY
24402012-02-17 Chong Yidong <cyd@gnu.org>
2441
2442 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2443
11273115
PE
24442012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2445
2446 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2447 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2448
c3a70e2b
CY
24492012-02-15 Chong Yidong <cyd@gnu.org>
2450
2451 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2452 marked as special. Also, starting docstrings with * is obsolete.
2453
0ca43699
AS
24542012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2455
2456 * gnutls.c (emacs_gnutls_write): Fix last change.
2457
2e8f3c56
LI
24582012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2459
2460 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2461 send_process.
2462
af70074f
SM
24632012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2464
2465 * keymap.c (Fsingle_key_description): Handle char ranges.
2466
95986d52
CY
24672012-02-12 Chong Yidong <cyd@gnu.org>
2468
afd83bd1
CY
2469 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2470 as that creates a dangerous corner case.
2471
95986d52
CY
2472 * window.c (Fdelete_window_internal): Invalidate the mouse
2473 highlight (Bug#9904).
2474
bd7da63e
GM
24752012-02-12 Glenn Morris <rgm@gnu.org>
2476
2477 * xselect.c (Fx_own_selection_internal)
2478 (Fx_get_selection_internal, Fx_disown_selection_internal)
2479 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2480 * nsselect.m (Fx_own_selection_internal)
2481 (Fx_disown_selection_internal, Fx_selection_exists_p)
2482 (Fx_selection_owner_p, Fx_get_selection_internal):
2483 Sync docs and argument specs with the xselect.c versions.
2484
77abcbc2
LI
24852012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2486
2487 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2488
90b671e2
EZ
24892012-02-11 Eli Zaretskii <eliz@gnu.org>
2490
1c0ca0b7
EZ
2491 * w32select.c (Fx_selection_exists_p): Sync doc string and
2492 argument list with xselect.c. (Bug#10783)
2493
2494 * w16select.c (Fx_selection_exists_p): Sync doc string and
2495 argument list with xselect.c. (Bug#10783)
90b671e2 2496
49241268
GM
24972012-02-10 Glenn Morris <rgm@gnu.org>
2498
2499 * fns.c (Fsecure_hash): Doc fix.
2500
f998bbe7 25012012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2502
2503 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2504
0992bd9c
CY
25052012-02-07 Chong Yidong <cyd@gnu.org>
2506
2507 * buffer.c (Fbuffer_local_variables)
2508 (buffer_lisp_local_variables): Handle unbound vars correctly;
2509 don't let Qunbound leak into Lisp.
2510
af008560
GM
25112012-02-07 Glenn Morris <rgm@gnu.org>
2512
dd605cc4
GM
2513 * image.c (Fimagemagick_types): Doc fix.
2514
af008560
GM
2515 * image.c (imagemagick-render-type): Change it from a lisp object
2516 to an integer. Move the doc here from the lisp manual.
2517 Treat all values not equal to 0 the same.
2518
1449fa1d
CY
25192012-02-06 Chong Yidong <cyd@gnu.org>
2520
2521 * doc.c (store_function_docstring): Avoid applying docstring of
2522 alias to base function (Bug#2603).
2523
3723ec07
AS
25242012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2525
2526 * .gdbinit (pp1, pv1): Remove redundant defines.
2527 (pr): Use pp.
2528
79c1cc1e
CY
25292012-02-04 Chong Yidong <cyd@gnu.org>
2530
2531 * nsterm.m: Declare a global (Bug#10694).
2532
d7f29f8e
EZ
25332012-02-04 Eli Zaretskii <eliz@gnu.org>
2534
cae07000
SM
2535 * w32.c (get_emacs_configuration_options):
2536 Include --enable-checking, if specified, in the return value.
d7f29f8e 2537
3b95a6f9
MR
25382012-02-04 Martin Rudalics <rudalics@gmx.at>
2539
2540 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2541 after rounding frame sizes. (Bug#9723)
2542
d6fa96a6
EZ
25432012-02-04 Eli Zaretskii <eliz@gnu.org>
2544
2545 * keyboard.c (adjust_point_for_property): Don't position point
2546 before BEGV. (Bug#10696)
2547
df0b2940
PE
25482012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2549
2550 Handle overflow when computing char display width (Bug#9496).
2551 * character.c (char_width): Return EMACS_INT, not int.
2552 (char_width, c_string_width): Check for overflow when
2553 computing the width; this is possible now that individual
2554 characters can have unbounded width. Problem introduced
2555 by merge from Emacs 23 on 2012-01-19.
2556
6bee44d6
MA
25572012-02-02 Michael Albinus <michael.albinus@gmx.de>
2558
2559 * dbusbind.c (Fdbus_register_method): Mention the return value
2560 :ignore in the docstring.
2561
44f92739
GM
25622012-02-02 Glenn Morris <rgm@gnu.org>
2563
1b9f60cc
GM
2564 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2565
44f92739
GM
2566 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2567 Unconditionally set to t. (Bug#10673)
2568 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2569 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2570 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2571
c5d3843c
KH
25722012-02-02 Kenichi Handa <handa@m17n.org>
2573
2574 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2575 0, do not call append_composite_glyph.
2576
159462d4 25772012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
2578
2579 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2580 NULL (Bug#6988).
2581 (x_produce_glyphs): If the component of a composition is a null
2582 string, set it->pixel_width to 1 to avoid zero-width glyph.
2583
78cef877
EZ
25842012-02-01 Eli Zaretskii <eliz@gnu.org>
2585
2586 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2587 first 2 arguments are identical. This makes inserting large
2588 output from a subprocess an order of magnitude faster on
2589 MS-Windows, where all sbrk'ed memory is always contiguous.
2590
97897668
GM
25912012-01-31 Glenn Morris <rgm@gnu.org>
2592
2593 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 2594 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
2595 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2596
31fd3586
GM
25972012-01-29 Glenn Morris <rgm@gnu.org>
2598
2599 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2600
0e24a8b2
CY
26012012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2602
2603 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2604
cc0adcb0
CY
26052012-01-28 Chong Yidong <cyd@gnu.org>
2606
2607 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2608
acc28cb9
CY
26092012-01-26 Chong Yidong <cyd@gnu.org>
2610
9c69cfb7
CY
2611 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2612
acc28cb9
CY
2613 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2614 repeat counts (Bug#10507).
2615
48da7392
GM
26162012-01-26 Glenn Morris <rgm@gnu.org>
2617
2618 * lread.c (syms_of_lread): Doc fix.
2619
14af5f7f
CY
26202012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2621
2622 * coding.c (encode_designation_at_bol): Change return value to
2623 EMACS_INT.
2624
0b21c100
CY
26252012-01-25 Chong Yidong <cyd@gnu.org>
2626
2627 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2628
3c2907f7
CY
26292012-01-21 Chong Yidong <cyd@gnu.org>
2630
2631 * floatfns.c (Fcopysign): Make the second argument non-optional,
2632 since nil is not allowed anyway.
2633
959ad23f
AS
26342012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2635
2636 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2637 (send_process): Likewise.
2638
34a02f46
MR
26392012-01-19 Martin Rudalics <rudalics@gmx.at>
2640
2641 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
2642 (Vwindow_persistent_parameters): Do not use Qstate.
2643 Rewrite doc-strings.
34a02f46 2644
1259009a 26452012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
2646
2647 * character.c (char_width): New function.
70d4fdf6
GM
2648 (Fchar_width, c_string_width, lisp_string_width):
2649 Use char_width (Bug#9496).
25ed9e61 2650
6a6ee00d
MR
26512012-01-16 Martin Rudalics <rudalics@gmx.at>
2652
2653 * window.c (Vwindow_persistent_parameters): New variable.
2654 (Fset_window_configuration, save_window_save): Handle persistent
2655 window parameters.
2656
c85efaf7
EZ
26572012-01-14 Eli Zaretskii <eliz@gnu.org>
2658
2659 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2660 thrashing the stack of the thread. (Bug#9087)
2661
5944709e
PE
26622012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2663
2664 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2665
e71f5d99
EZ
26662012-01-11 Eli Zaretskii <eliz@gnu.org>
2667
2668 * xdisp.c (rows_from_pos_range): Handle the case where the
2669 highlight ends on a newline. (Bug#10464)
2670 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2671 he end column for display of highlight that ends on a newline
2672 before a R2L line.
2673
ce316182
GM
26742012-01-11 Glenn Morris <rgm@gnu.org>
2675
2676 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2677 from load-path also when installation-directory is nil. (Bug#10208)
2678
5b43da69
GM
26792012-01-10 Glenn Morris <rgm@gnu.org>
2680
74cc8ff9
GM
2681 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2682
7d8d6e4e
GM
2683 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2684 Update template values to be closer to their typical values these days.
5b43da69 2685
a0db8d43
EZ
26862012-01-09 Eli Zaretskii <eliz@gnu.org>
2687
2688 * xdisp.c (rows_from_pos_range): Accept additional argument
2689 DISP_STRING, and accept any glyph in a row whose object is that
2690 string as eligible for mouse highlight. Fixes mouse highlight of
2691 display strings from overlays. (Bug#10464)
2692
9a0115ab 26932012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 2694
b9110d6a 2695 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
2696 * fileio.c (auto_saving_dir_umask): New static var.
2697 (Fmake_directory_internal): Use it.
2698 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2699 creating the directory. The old code temporarily assigns
2700 too-generous permissions to the directory.
2701 (do_auto_save_eh): Clear it.
b9110d6a 2702 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
2703 that the var is always cleared.
2704
6c1bd3f3
EZ
27052012-01-07 Eli Zaretskii <eliz@gnu.org>
2706
2707 * search.c (scan_buffer): Pass character positions to
2708 know_region_cache, not byte positions. (Bug#6540)
2709
069d2b50
L
27102012-01-07 LynX <_LynX@bk.ru> (tiny change)
2711
2712 * w32.c (sys_rename): Report EXDEV when rename of a directory
2713 fails because the target is on another logical disk. (Bug#10284)
2714
75bf0d33
DB
27152012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2716
2717 * xterm.c (x_embed_request_focus): New function.
2718
2719 * xterm.h: Add prototype.
2720
2721 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2722
1c6e5a32
GM
27232012-01-05 Glenn Morris <rgm@gnu.org>
2724
2725 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2726
651e947e
EZ
27272012-01-01 Eli Zaretskii <eliz@gnu.org>
2728
2729 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2730 Load gnutls_transport_set_lowat only if GnuTLS version is below
2731 2.11.1.
2732 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2733 GnuTLS versions below 2.11.1.
2734
3778cdd8
AL
27352011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2736
2737 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2738 to the doc string advising against its use for altering the way
2739 windows are scrolled.
2740
0e5317f7
KH
27412011-12-28 Kenichi Handa <handa@m17n.org>
2742
2743 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2744 coding-system ASCII compatible only when it does not produce BOM
2745 on encoding (Bug#10383).
2746
93d5ca1f
JD
27472011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2748
2749 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2750 can scroll.
2751 (create_and_show_popup_menu): Always use menu_position_func for
2752 Gtk3 (Bug#10361).
2753
ca22b785
AS
27542011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2755
2756 * callint.c (Fcall_interactively): Don't truncate prompt string.
2757
d048e1e6
EZ
27582011-12-23 Eli Zaretskii <eliz@gnu.org>
2759
2760 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2761 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 2762 resumed from there (after widening). (Bug#10360)
d048e1e6 2763
5ccaba1f
JD
27642011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2765
2766 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2767
204ee57f
JD
27682011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2769
b81d40f0
JB
2770 * nsterm.m (x_free_frame_resources):
2771 Release f->output_data.ns->miniimage.
204ee57f
JD
2772 (ns_index_color): Fix indentation. Do not retain
2773 color_table->colors[i].
2774
2775 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2776 before returning.
2777
2778 * nsfns.m (x_set_background_color): Assign return value from
2779 ns_index_color to face-background instead of NSColor*.
2780 (ns_implicitly_set_icon_type): Fix indentation.
2781 Change assignment in for loop to comparison.
2782
2783 * emacs.c (ns_pool): New variable.
2784 (main): Assign ns_pool.
2785 (Fkill_emacs): Call ns_release_autorelease_pool.
2786
2787 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2788 autorelease fdesc, release fdAttrs and tdict.
2789 (ns_get_covering_families): Release charset.
2790 (ns_findfonts): Release NSFontDescriptor created with new.
2791 (ns_uni_to_glyphs): Fix indentation.
2792 (setString): Release attrStr before assigning new value.
2793
c803b2b7
JD
27942011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2795
678f4426
JD
2796 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2797 and NS_IMPL_COCOA.
2798 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2799 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2800
cd394be1 28012011-12-18 David Reitter <reitter@cmu.edu>
678f4426 2802
5fecd5fc
JD
2803 * nsterm.m (ns_term_init): Subscribe for notifications
2804 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2805 to method trackingNotification in EmacsMenu.
2806
2807 * nsmenu.m (trackingMenu): New variable.
3771cb17 2808 (trackingNotification): New method (from Aquamacs).
5fecd5fc 2809 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 2810 from Aquamacs (Bug#7030).
678f4426
JD
2811
28122011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 2813
c803b2b7
JD
2814 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2815 (symbol_to_nsstring): Fix indentation.
2816 (ns_symbol_to_pb): New function.
cae07000
SM
2817 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2818 (Fns_rotate_cut_buffers_internal): Remove.
2819 (Fns_store_selection_internal): Rename from
c803b2b7
JD
2820 Fns_store_cut_buffer_internal.
2821 (ns_get_foreign_selection, Fx_own_selection_internal)
2822 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
2823 (Fns_get_selection_internal, Fns_store_selection_internal):
2824 Use ns_symbol_to_pb and check if return value is nil.
2825 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2826 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
2827 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2828 renamed to Sns_store_selection_internal.
2829 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2830 and remove this function.
2831 (ns_handle_selection_clear): Remove, never used.
2832 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2833 here.
2834
e1b01a3a
KB
28352011-12-17 Ken Brown <kbrown@cornell.edu>
2836
2837 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2838 GID is unknown (Bug#10257).
2839
2adb6e85
PE
28402011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2841
2842 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2843 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2844 which caused a build failure on GNU/Linux IA-64. This problem was
2845 introduced by my 2011-10-07 patch.
2846
d1d7b339
JL
28472011-12-15 Juri Linkov <juri@jurta.org>
2848
2849 * image.c (imagemagick_error): New function. (Bug#10112)
2850 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2851 Use `imagemagick_error' where ImageMagick functions return
2852 `MagickFalse'.
2853 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2854 proper order.
2855
100d5755
KH
28562011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2857
2858 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2859 fill background (Bug#8992).
2860
454592a6
MR
28612011-12-13 Martin Rudalics <rudalics@gmx.at>
2862
2863 * window.c (Vwindow_combination_resize)
2864 (Vwindow_combination_limit): Use t instead of non-nil in
2865 doc-strings.
61d4b438
MR
2866 (Vrecenter_redisplay): Add first sentence of doc-string on
2867 separate line.
53524d93 2868 (Frecenter): Fix doc-string typo.
454592a6 2869
3633e3aa
KH
28702011-12-11 Kenichi Handa <handa@m17n.org>
2871
2872 * coding.c (Funencodable_char_position): Pay attention to the
2873 buffer text relocation (Bug#9389).
2874
7b9d523a 28752011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 2876
7b9d523a
JD
2877 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2878 gtk_init (Bug#10100).
2879
b73189c6
EZ
28802011-12-10 Eli Zaretskii <eliz@gnu.org>
2881
2882 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2883 IT->string is nil. (Bug#10263)
2884
f7dfe5d6
JD
28852011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2886
83faebb4
JD
2887 * nsterm.h (x_free_frame_resources): Declare.
2888
f7dfe5d6
JD
2889 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2890 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2891
2892 * nsterm.h (ns_get_defaults_value): Declare.
2893
2894 * nsterm.m (ns_default): Call ns_get_defaults_value.
2895
7cd4e72c
EZ
28962011-12-09 Eli Zaretskii <eliz@gnu.org>
2897
2898 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2899 (Bug#10170)
2900
b34d7317
YM
29012011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2902
2903 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2904 that where the value of an _OBJC_* symbol points to is in the .bss
2905 section (Bug#10240).
2906
76470ad1
KH
29072011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2908
2909 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 2910 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 2911
745fff94
KH
29122011-12-08 Kenichi Handa <handa@m17n.org>
2913
2914 * ftfont.c (get_adstyle_property): Fix previous change
2915 (Bug#10233).
2916
6e44397c
JB
29172011-12-07 Juanma Barranquero <lekktu@gmail.com>
2918
2919 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2920 dirs from the default value of EMACSLOADPATH (bug#10208).
2921
7efa6272
GM
29222011-12-07 Glenn Morris <rgm@gnu.org>
2923
2924 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2925 installation and source directories as well. (Bug#10208)
2926
f6fc4d87
CY
29272011-12-06 Chong Yidong <cyd@gnu.org>
2928
2929 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2930
2bf26180
GM
29312011-12-06 Glenn Morris <rgm@gnu.org>
2932
2933 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2934 as an error, not just -1. (Bug#10217)
2935
3a6ad4f0
CY
29362011-12-05 Chong Yidong <cyd@gnu.org>
2937
2938 * keyboard.c (process_special_events): New function.
2939 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2940
75a3b399
PE
29412011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2942
2943 * coding.c (encode_designation_at_bol): Don't use uninitialized
2944 local variable (Bug#9318).
2945
c3c9e25e
KH
29462011-12-05 Kenichi Handa <handa@m17n.org>
2947
2948 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2949 return Qnil (Bug#8046, Bug#10193).
2950
5eb05ea3
KH
29512011-12-05 Kenichi Handa <handa@m17n.org>
2952
2953 * coding.c (encode_designation_at_bol): New args charbuf_end and
2954 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
2955 (coding_set_source): Return how many bytes coding->source was
2956 relocated.
2957 (coding_set_destination): Return how many bytes
2958 coding->destination was relocated.
2959 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 2960 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
2961
29622011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2963
2964 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2965 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2966 macro (Bug#9318).
2967
29682011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2969
2970 The following changes are to fix Bug#9318.
2971
a79703f5 2972 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
2973 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2974 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 2975 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 2976
7dbda6df
JB
29772011-12-05 Juanma Barranquero <lekktu@gmail.com>
2978
2979 * lisp.h (process_quit_flag): Fix external declaration.
2980
6d5eb5b0
SM
29812011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2982
2983 Don't macro-inline non-performance-critical code.
2984 * eval.c (process_quit_flag): New function.
2985 * lisp.h (QUIT): Use it.
2986
a0c3fad0
JD
29872011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2988
2989 * nsfns.m (get_geometry_from_preferences): New function.
2990 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2991
6c07aac2
AS
29922011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2993
2994 * emacs.c (Qkill_emacs): Define.
2995 (syms_of_emacs): Initialize it.
2996 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2997 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
2998 (quit_throw_to_read_char): Add parameter `from_signal'.
2999 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3000 * lisp.h (QUIT): Call Fkill_emacs if requested.
3001
c052ead4
JD
30022011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3003
3004 * widget.c (update_wm_hints): Return if wmshell is null.
3005 (widget_update_wm_size_hints): New function.
3006
3007 * widget.h (widget_update_wm_size_hints): Declare.
3008
3009 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3010 widget_update_wm_size_hints (Bug#10104).
3011
9e49252b
EZ
30122011-12-03 Eli Zaretskii <eliz@gnu.org>
3013
3014 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3015 before a newline, prepare the bidi iterator for consuming the
3016 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3017 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3018
02b16839
JL
30192011-12-02 Juri Linkov <juri@jurta.org>
3020
3021 * search.c (Fword_search_regexp): New Lisp function created from
3022 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3023 (Fword_search_backward, Fword_search_forward)
3024 (Fword_search_backward_lax, Fword_search_forward_lax):
3025 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3026 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3027
0068070e
SM
30282011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3029
3030 * fileio.c (Finsert_file_contents): Move after-change-function call
3031 to before the "handled:" label, since all "goto handled" appear in
3032 cases where the *-change-functions have already been properly called
3033 (bug#10117).
3034
3360a3fc
AS
30352011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3036
3037 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3038 waiting for input. (Bug#10169)
3039
73d6c093
EZ
30402011-11-30 Eli Zaretskii <eliz@gnu.org>
3041
3042 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3043 verifies glyph row's hash code--we have just reallocated the
3044 glyphs, so their contents can be complete garbage. (Bug#10164)
3045
febe6bea
JB
30462011-11-30 Juanma Barranquero <lekktu@gmail.com>
3047
3048 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3049
801a4313
EZ
30502011-11-30 Eli Zaretskii <eliz@gnu.org>
3051
3052 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3053 attributes are tested _before_ calling verify_row_hash, to protect
3054 against GCC re-ordering of the tests. (Bug#10164)
3055
2b56b87e
JD
30562011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3057
3058 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3059
3060 * xterm.c (handle_one_xevent): Only set async_visible and friends
3061 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3062 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3063 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3064
dbf31225
PE
30652011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3066
3067 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3068 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3069 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3070 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3071 All uses changed to use GCPRO1 etc.
3072 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3073 Revert to old implementation (i.e., before 2011-03-11).
3074
1305621b
YM
30752011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3076
3077 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3078 of scroll runs so as to avoid assigning disabled bogus rows and
3079 unnecessary graphics copy operations.
3080
8c9afb46
EZ
30812011-11-27 Eli Zaretskii <eliz@gnu.org>
3082
3083 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3084 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3085 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3086 (malloc, free, realloc, calloc): Redirect to e_* only when
3087 compiling Emacs.
3088
3089 * lisp.h (GCTYPEBITS): Move before first use.
3090 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3091 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3092 this macro definition.
3093
3094 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3095 _MSC_VER.
3096
54e9e3bf
JD
30972011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3098
6d5eb5b0
SM
3099 * gtkutil.c (xg_create_frame_widgets):
3100 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3101 present with Gtk+ 2.0.
3102
83aca1cb
PE
31032011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3104
3105 * fileio.c (Finsert_file_contents): Undo previous change; see
3106 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3107
5b76caa4
PE
31082011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3109
3110 Rename locals to avoid shadowing.
3111 * fileio.c (Finsert_file_contents):
3112 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3113 * process.c (wait_reading_process_output):
3114 Rename inner 'proc' to 'p' to avoid shadowing.
3115 Indent for consistency with usual Emacs style.
3116
8c535114
EZ
31172011-11-25 Eli Zaretskii <eliz@gnu.org>
3118
3119 * xdisp.c (redisplay_window): If cursor row is not fully visible
3120 after recentering, and scroll-conservatively is set to a large
3121 number, scroll window by a few more lines to make the cursor fully
3122 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3123 (start_display): Don't move to the next line if the display should
3124 start at a newline that is part of a display vector or an overlay
3125 string. (Bug#10119)
8c535114 3126
fa4fdb5c
JL
31272011-11-24 Juri Linkov <juri@jurta.org>
3128
3129 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3130 after the `MagickPingImage' call. (Bug#10112)
3131
90ec88df
CY
31322011-11-23 Chong Yidong <cyd@gnu.org>
3133
3134 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3135
56e2e794
MR
31362011-11-23 Martin Rudalics <rudalics@gmx.at>
3137
3138 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3139 making another buffer current. (Bug#10114)
3140
b6e64c41
GM
31412011-11-23 Glenn Morris <rgm@gnu.org>
3142
3143 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3144
6b21de18
CY
31452011-11-23 Chong Yidong <cyd@gnu.org>
3146
3147 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3148 using it (Bug#5984).
3149
b12cd789
EZ
31502011-11-22 Eli Zaretskii <eliz@gnu.org>
3151
3152 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3153 and header-lines, as they don't have one computed for them.
3154 (Bug#10098)
3155
3156 * .gdbinit (prow): Make displayed values more self-explaining.
3157 Add row's hash code.
3158
261b6fd4
LMI
31592011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3160
3161 * process.c (wait_reading_process_output): Fix asynchrounous
3162 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3163 (wait_reading_process_output): Add comment and URL.
261b6fd4 3164
e7cfd277
JD
31652011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3166
3167 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3168
a9b9b7f5
CY
31692011-11-21 Chong Yidong <cyd@gnu.org>
3170
3171 * window.c (Fnext_window, Fprevious_window): Doc fix.
3172
b0d15b4f
SM
31732011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3174
3175 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3176
fe7a3057
JB
31772011-11-20 Juanma Barranquero <lekktu@gmail.com>
3178
3179 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3180
d2999b1a
MR
31812011-11-20 Martin Rudalics <rudalics@gmx.at>
3182
3183 * window.c (Fset_window_combination_limit): Rename argument
3184 STATUS to LIMIT.
3185 (Vwindow_combination_limit): Remove "status" from doc-string.
3186
d5ff9cd0
AS
31872011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3188
3189 * m/ibms390.h: Remove.
3190 * m/ibms390x.h: Don't include "ibms390.h".
3191
a5bb9bd3
SM
31922011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3193
3194 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3195 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3196
cd1181db
JB
31972011-11-20 Juanma Barranquero <lekktu@gmail.com>
3198
3199 * casetab.c (Fset_case_table):
3200 * charset.c (Fcharset_after): Fix typos.
3201
615a3b8d 32022011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3203
17e845af
PE
3204 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3205 Otherwise, valgrind does not work on some platforms.
3206 Problem reported by Andreas Schwab in
6a0bf43d
PE
3207 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3208 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3209 is set, removing the need for VIRT_ADDRESS_VARIES.
3210 (PURE_P): Use a more-efficient implementation that needs just one
3211 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3212 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3213 to 4 (xorl, subq, cmpq, setbe).
3214 * alloc.c (pure): Always extern now, since that's the
3215 VIRT_ADDR_VARIES behavior.
3216 (PURE_POINTER_P): Use a single comparison, not two, for
3217 consistency with the new puresize.h.
3218 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3219 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3220 Remove VIRT_ADDR_VARIES no longer needed.
3221
f8fe6f96
EZ
32222011-11-19 Eli Zaretskii <eliz@gnu.org>
3223
3224 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3225 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3226 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3227 behave as if the cursor position were at the window margin.
3228
3229 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3230 and the cursor position is out of bounds, behave as if the cursor
3231 position were at the window margin. (Bug#10075)
3232
df05a53c
CY
32332011-11-18 Chong Yidong <cyd@gnu.org>
3234
3235 * window.c (Fwindow_combination_limit): Make first argument
3236 non-optional, since it is meaningless for live windows like the
3237 selected window.
61ccba97 3238
2071918e
DA
32392011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3240
3241 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3242
b50a28de
SM
32432011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3244
3245 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3246 (graft_intervals_into_buffer): Simplify.
3247
015137db
EZ
32482011-11-18 Eli Zaretskii <eliz@gnu.org>
3249
3250 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3251 hash values of the two rows.
3252 (copy_row_except_pointers): Preserve the used[] arrays and the
3253 hash values of the two rows. (Bug#10035)
68c95424 3254 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3255
3256 * xdisp.c (row_hash): New function, body extracted from
3257 compute_line_metrics.
3258 (compute_line_metrics): Call row_hash, instead of computing the
3259 hash code inline.
3260
3261 * dispnew.c (verify_row_hash): Call row_hash for computing the
3262 hash code of a row, instead of duplicating code from xdisp.c.
3263
3264 * dispextern.h (row_hash): Add prototype.
3265
a2addb04
TH
32662011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3267
3268 * frame.c (delete_frame): Don't delete the terminal when the last
3269 X frame is closed if emacs is built with GTK toolkit.
3270
df85d315
JB
32712011-11-17 Juanma Barranquero <lekktu@gmail.com>
3272
3273 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3274
a0c2d0ae
MR
32752011-11-17 Martin Rudalics <rudalics@gmx.at>
3276
3277 * window.c (Vwindow_splits): Rename to
3278 Vwindow_combination_resize. Suggested by Juri Linkov.
3279 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3280 of Vwindow_splits.
3281
58179cce
JB
32822011-11-16 Juanma Barranquero <lekktu@gmail.com>
3283
7877f373
JB
3284 * nsfns.m (Fns_font_name):
3285 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3286
b6f67890
MR
32872011-11-16 Martin Rudalics <rudalics@gmx.at>
3288
3289 * window.h (window): Rename slot "nest" to "combination_limit".
3290 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3291 (Fset_window_nest): Rename to Fset_window_combination_limit.
3292 (Vwindow_nest): Rename to Vwindow_combination_limit.
3293 (recombine_windows, make_parent_window, make_window)
3294 (Fsplit_window_internal, saved_window)
3295 (Fset_window_configuration, save_window_save): Rename all
3296 occurrences of window_nest to window_combination_limit.
3297
c7015153
JB
32982011-11-15 Juanma Barranquero <lekktu@gmail.com>
3299
3300 * image.c (imagemagick_load_image): Fix typo.
3301
322ad6ec
EZ
33022011-11-14 Eli Zaretskii <eliz@gnu.org>
3303
3304 * xdisp.c (display_line): Move the call to
3305 highlight_trailing_whitespace before the call to
3306 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3307 faces of all the glyphs to compute ROW's hash value.
3308 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3309
f067b8ec
JB
33102011-11-14 Juanma Barranquero <lekktu@gmail.com>
3311
3312 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3313 just return (bug#10044).
3314
1e5b2111
EZ
33152011-11-12 Eli Zaretskii <eliz@gnu.org>
3316
7ef3cbd5
EZ
3317 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3318 with user-defined heap size. Bump the default size of the temacs
3319 heap to 27MB, to avoid memory warning when running temacs.
3320 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3321
1e5b2111
EZ
3322 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3323 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3324 (verify_row_hash) [XASSERTS]: New function.
3325 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3326 that the hash value of glyph rows is correct.
1e5b2111 3327
89d61221
MR
33282011-11-12 Martin Rudalics <rudalics@gmx.at>
3329
3330 * window.h (window): Remove splits slot.
3331 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3332 (Fdelete_other_windows_internal, make_parent_window)
3333 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3334 (Fset_window_configuration, save_window_save): Don't deal with
3335 split status of windows.
3336 (saved_window): Remove splits slot.
3337 (Vwindow_splits): Rewrite doc-string.
3338
97f18cc8
JD
33392011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3340
3341 * xfns.c (unwind_create_frame):
3342 * nsfns.m (unwind_create_frame):
3343 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3344 Vframe_list (Bug#9999).
3345
22a648b4
DA
33462011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3347
0b381c7e 3348 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3349
659afede
KH
33502011-11-11 Kenichi Handa <handa@m17n.org>
3351
3352 * callproc.c (Fcall_process): Set the member dst_multibyte of
3353 process_coding.
3354
9ac0394b
KH
33552011-11-11 Johan Bockgård <bojohan@gnu.org>
3356
3357 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3358 avoid a crash (bug#9496).
3359
2fbdc249
CY
33602011-11-09 Chong Yidong <cyd@gnu.org>
3361
3362 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3363 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3364
ac6b1f81
PE
33652011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3366
3367 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3368
09db192c
PE
33692011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3370
3371 Avoid some portability problems by eschewing 'extern inline' functions.
3372 The trivial performance wins aren't worth the portability hassles; see
3373 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3374 et seq.
3375 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3376 (window_box_width, window_box_left, window_box_left_offset)
3377 (window_box_right, window_box_right_offset): Undo previous change,
3378 by removing the "extern"s.
3379 * intervals.c (adjust_intervals_for_insertion)
3380 (adjust_intervals_for_deletion): Undo previous change,
3381 making these static again.
3382 (offset_intervals, temp_set_point_both, temp_set_point)
3383 (copy_intervals_to_string): No longer inline.
3384 * xdisp.c (window_text_bottom_y, window_box_width)
3385 (window_box_height, window_box_left_offset)
3386 (window_box_right_offset, window_box_left, window_box_right)
3387 (window_box): No longer inline.
3388
105216ed
CY
33892011-11-08 Chong Yidong <cyd@gnu.org>
3390
3391 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3392 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3393 Signal an error if not a live window.
105216ed
CY
3394 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3395 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3396
ae9e237f
JB
33972011-11-07 Juanma Barranquero <lekktu@gmail.com>
3398
3399 * lisp.h (syms_of_abbrev): Remove declaration.
3400 Reported by CHENG Gao <chenggao@royau.me>.
3401
c7aa8333
EZ
34022011-11-07 Eli Zaretskii <eliz@gnu.org>
3403
3404 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3405 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3406 of temacs in GUI mode.
3407
be7f5545
MR
34082011-11-07 Martin Rudalics <rudalics@gmx.at>
3409
3410 * window.h: Declare delete_all_child_windows instead of
3411 delete_all_subwindows.
3412 * window.c (Fwindow_nest, Fset_window_nest)
3413 (Fset_window_new_total, Fset_window_new_normal)
3414 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3415 (delete_all_subwindows): Rename to delete_all_child_windows.
3416 (Fdelete_other_windows_internal, Fset_window_configuration):
3417 Call delete_all_child_windows instead of delete_all_subwindows.
3418 * frame.c (delete_frame): Call delete_all_child_windows instead
3419 of delete_all_subwindows.
3420
ca78dc43
PE
34212011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3422
3423 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3424 This is also needed for porting to any host where GC_MARK_STACK is
3425 not GC_MAKE_GCPROS_NOOPS.
3426 (which_symbols): Use it.
3427
a0241d01
KH
34282011-11-07 Kenichi Handa <handa@m17n.org>
3429
3430 * coding.c (coding_set_destination): Check coding->src_pos only
3431 when coding->src_object is a buffer (bug#9910).
3432
3433 * process.c (send_process): Set the member src_multibyte of coding
3434 to 0 (bug#9911) when sending a unibyte text.
3435
3436 * callproc.c (Fcall_process): Set the member src_multibyte of
3437 process_coding to 0 (bug#9912).
3438
a64bfdfa 34392011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3440
3441 * xmenu.c (cleanup_widget_value_tree): New function.
3442 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3443 calling free_menubar_widget_value_tree directly (Bug#9830).
3444
cb41b32a
PE
34452011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3446
3447 Fix some portability problems with 'inline'.
3448 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3449 (window_box_width, window_box_left, window_box_left_offset)
3450 (window_box_right, window_box_right_offset): Declare extern.
3451 Otherwise, these inline functions do not conform to C99 and
3452 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3453 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3454 * intervals.c (adjust_intervals_for_insertion)
3455 (adjust_intervals_for_deletion): Now extern, because otherwise the
3456 extern inline functions 'offset_intervals' couldn't refer to it.
3457 (static_offset_intervals): Remove.
3458 (offset_intervals): Rewrite using the old contents of
3459 static_offset_intervals. The old version didn't conform to C99
3460 because an extern inline function contained a reference to an
3461 identifier with static linkage.
3462
b7041366
AS
34632011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3464
3465 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3466 GC.
3467
88a37c4d
EZ
34682011-11-06 Eli Zaretskii <eliz@gnu.org>
3469
3470 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3471 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3472 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3473 return Qleft_to_right.
3474
49745b39
CY
34752011-11-06 Chong Yidong <cyd@gnu.org>
3476
3477 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3478 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3479 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3480 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3481 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3482 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3483 (Fwindow_vscroll): Doc fix.
3484 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3485 argument, since it makes no sense to pass a live window and for
3486 consistency with window-child.
3487
1f05cd82
CS
34882011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3489
3490 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3491 support MSVC.
3492
22610910
JR
34932011-11-05 Jason Rumney <jasonr@gnu.org>
3494
3495 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3496 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3497 fonts (Bug#6029).
3498 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3499 bitwise arithmetic preventing use of unicode-sip and non-truetype
3500 opentype fonts.
3501
a06776b2
EZ
35022011-11-05 Eli Zaretskii <eliz@gnu.org>
3503
3ad924ba
EZ
3504 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3505 "emacs"-only part.
3506
a06776b2
EZ
3507 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3508 initialization code to keep similarity to xfns.c after changes
3509 from 2011-11-05.
3510
c9e7db78
JD
35112011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3512
a97f8f3f
JD
3513 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3514 (unwind_create_frame): New function (Bug#9943).
3515 (Fx_create_frame): Restructure code to be more similar to the one in
3516 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3517 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3518 Move terminal->reference_count++ just before making the frame official
3519 (Bug#9943).
3520
3521 * nsterm.m (x_free_frame_resources): New function.
3522 (x_destroy_window): Move code to x_free_frame_resources.
3523
c9e7db78 3524 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3525 (Fx_create_frame, x_create_tip_frame):
3526 Move terminal->reference_count++ just before making the frame
75f1671a 3527 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3528 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3529
a6fc3b5c
EZ
35302011-11-05 Eli Zaretskii <eliz@gnu.org>
3531
3532 Support MSVC build with newer versions of Visual Studio.
3533 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3534 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3535 nt/gmake.defs.
3536
3537 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3538 which are not supported by MSVC.
3539 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3540 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3541 bitfields.
3542 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3543 types in bitfields.
3544 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3545
3546 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3547
58179cce 35482011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3549
3550 Support MSVC build with newer versions of Visual Studio.
3551 * w32.c: Don't include w32api.h for MSVC.
3552 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3553
3554 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3555 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3556 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3557 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3558 e_* cousins.
3559 (alloca) [_MSC_VER]: Define to _alloca.
3560
3561 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3562
3563 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3564
a58c13ed
EZ
35652011-11-04 Eli Zaretskii <eliz@gnu.org>
3566
3567 * xdisp.c (note_mouse_highlight): If either of
3568 previous/next-single-property-change returns nil, treat that as
3569 the beginning or the end of the buffer. (Bug#9955)
3570
fe0b6370
JD
35712011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3572
a58c13ed 3573 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
3574 label is not null (Bug#9951).
3575 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3576 may be NULL.
3577
89bd5ee1
EZ
35782011-11-04 Eli Zaretskii <eliz@gnu.org>
3579
3580 * window.c (Fwindow_body_size): Mention in the doc string that the
3581 return value is in frame's canonical units. (Bug#9949)
3582
84c3edb9
EZ
35832011-11-03 Eli Zaretskii <eliz@gnu.org>
3584
4e2fb5c7
EZ
3585 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3586
84c3edb9 3587 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 3588 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 3589 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 3590
bc17a887
EZ
35912011-11-01 Eli Zaretskii <eliz@gnu.org>
3592
3593 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3594 Don't stop backward scan on the continuation glyph, even though
3595 its CHARPOS is positive.
6d5eb5b0
SM
3596 (mouse_face_from_buffer_pos, note_mouse_highlight):
3597 Rename cover_string to disp_string.
bc17a887 3598
4ee88440
MR
35992011-11-01 Martin Rudalics <rudalics@gmx.at>
3600
3601 * window.c (temp_output_buffer_show): Don't use
3602 Vtemp_buffer_show_specifiers.
3603 (Vtemp_buffer_show_specifiers): Remove unused variable.
3604
c2ff3c02
EZ
36052011-10-30 Eli Zaretskii <eliz@gnu.org>
3606
3607 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3608 past the beginning of the current glyph matrix.
3609
58179cce 36102011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
3611
3612 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3613 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3614 HAVE_GTK3 (Bug#9869).
b77a6a7f 3615
3b574623
JD
3616 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3617 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3618
b77a6a7f
JD
3619 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3620
3621 * xterm.c: Declare x_handle_net_wm_state to return int.
3622 (handle_one_xevent): Check if we are iconified but don't have
3623 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3624 (get_current_wm_state): Return non-zero if not hidden,
3625 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3626 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3627 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3628 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3629
196e41e4
PE
36302011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3631
3632 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3633 so that this new function doesn't get optimized away by a
3634 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3635
021f2e1a
AS
36362011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3637
3638 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3639
8b058d44
EZ
36402011-10-29 Eli Zaretskii <eliz@gnu.org>
3641
3642 Fix the `xbytecode' command.
3643 * .gdbinit (xprintbytestr): New command.
b50a28de 3644 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
3645 (xbytecode): Print the byte-code string as well.
3646
4452fb80
EZ
36472011-10-29 Kim Storm <storm@cua.dk>
3648
8b058d44
EZ
3649 * alloc.c (which_symbols): New function.
3650
21b72067
AS
36512011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3652
3653 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3654 line. (Bug#9903)
3655
83ed7b5c
GM
36562011-10-29 Glenn Morris <rgm@gnu.org>
3657
3658 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3659 Not clear what it was for, and it causes various bugs. (Bug#9839)
3660
5a7a728b
EZ
36612011-10-28 Eli Zaretskii <eliz@gnu.org>
3662
3663 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3664 possible random value that matches one of those tested as
3665 condition to clear the mouse face.
3666
d3d0842f
CY
36672011-10-28 Chong Yidong <cyd@gnu.org>
3668
3669 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3670
31b39d13
DN
36712011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3672
3673 * window.c (make_window): Initialize phys_cursor_on_p.
3674
9aba6043
SM
36752011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3676
3677 * lisp.h (struct Lisp_Symbol): Update comments.
3678
c20992f4
JB
36792011-10-28 Juanma Barranquero <lekktu@gmail.com>
3680
3681 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3682
db4f02f2
EZ
36832011-10-28 Eli Zaretskii <eliz@gnu.org>
3684
3685 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3686 <oslsachem@gmail.com> for helping to debug this.
3687
3688 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3689 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3690 (g_b_init_get_glyph_outline_w): New static variables.
3691 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3692 (GetGlyphOutlineW_Proc): New typedefs.
3693 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
3694 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3695 New functions.
3696 (w32font_open_internal, compute_metrics):
3697 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
3698 instead of calling the "wide" APIs directly.
3699
3700 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3701
3702 * w32.h (syms_of_w32font): Add prototype.
3703
87e68db4
JB
37042011-10-27 Juanma Barranquero <lekktu@gmail.com>
3705
3706 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3707 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3708 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3709 (Fmove_to_window_line): Doc fix.
3710
435c1d67
CY
37112011-10-27 Chong Yidong <cyd@gnu.org>
3712
3713 * process.c (make_process): Set gnutls_state to NULL.
3714
3715 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3716 non-NULL, regardless of GNUTLS_INITSTAGE.
3717 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3718 an error. Set process slots as soon as we allocate them.
3719
3720 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3721
9c6c6f49
CY
37222011-10-27 Chong Yidong <cyd@gnu.org>
3723
9aba6043
SM
3724 * gnutls.c (emacs_gnutls_deinit): New function.
3725 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
3726 (Fgnutls_deinit, Fgnutls_boot): Use it.
3727
3728 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3729 (deactivate_process): Call emacs_gnutls_deinit.
3730
657d08d3
JB
37312011-10-27 Juanma Barranquero <lekktu@gmail.com>
3732
3733 * image.c (x_create_x_image_and_pixmap):
3734 * w32.c (sys_rename, w32_delayed_load):
3735 * w32font.c (fill_in_logfont):
3736 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3737
5430d399
JB
37382011-10-26 Juanma Barranquero <lekktu@gmail.com>
3739
3740 * w32fns.c (w32_default_color_map): New function,
3741 extracted from Fw32_default_color_map.
a7ef684b 3742 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 3743
fe0055fa
PE
37442011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3745
3746 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3747
e6346438
SM
37482011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3749
3750 * keyboard.c (test_undefined): New function (bug#9751).
3751 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3752
e112cc37
ET
37532011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3754
3755 * sysdep.c (init_sys_modes): Fix the check for the controlling
3756 terminal (Bug#6649).
3757
7b5d6677
EZ
37582011-10-20 Eli Zaretskii <eliz@gnu.org>
3759
3760 * dispextern.h (struct bidi_it): New member next_en_type.
3761
3762 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3763 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3764 current character, check also for next_en_type being WEAK_EN.
3765 (bidi_resolve_weak): Don't enter the expensive loop if the current
3766 position is before next_en_pos. Record the bidi type of the first
3767 non-ET, non-BN character we find, in addition to its position.
3768 (bidi_level_of_next_char): Invalidate next_en_type when
3769 next_en_pos is over-stepped.
3770
7da0b018
PE
37712011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3772
3773 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3774 * editfns.c: Rewrite current-time-zone so that it invokes
3775 the equivalent of (format-time-string "%Z") to get the time zone name.
3776 This fixes a bug when the time zone name contains characters that
3777 need converting from the system time locale to Emacs internal format.
3778 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3779 that patch fixed format-time-string to do the conversion, but
3780 I forgot to fix current-time-zone.
3781 (format_time_string): New function, containing most of
3782 what Fformat_time_string used to contain.
3783 (Fformat_time_string): Rewrite in terms of format_time_string.
3784 This doesn't change this function's behavior.
3785 (current-time-zone): Rewrite to use format_time_string.
3786 This fixes the bug reported by Michael Schierl in
3787 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3788 Jason Rumney's 2007-06-07 change worked around this bug, but
3789 didn't fix it.
3790 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3791
8547b010
EZ
37922011-10-19 Eli Zaretskii <eliz@gnu.org>
3793
3794 * xdisp.c (start_display): If the character at POS is displayed
3795 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
3796 (try_window_reusing_current_matrix): If a line ends in a display
3797 vector or the next line starts in a display vector, continue
3798 redrawing the window even though the character position of
3799 start_row was reached.
8547b010
EZ
3800 (Bug#9771, part 2)
3801
4e948d15
CY
38022011-10-18 Chong Yidong <cyd@gnu.org>
3803
3804 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3805 with nobreak-char-display too.
3806
4787455f
EZ
38072011-10-18 Eli Zaretskii <eliz@gnu.org>
3808
3809 Fix part 3 of bug#9771.
3810 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3811 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3812 non-neutral characters if the current character is a paragraph
3813 separator (a.k.a. Newline). This avoids running the same
3814 expensive loop twice, once when we consume the preceding newline
3815 and the other time when the line actually needs to be displayed.
3816 Avoid the loop when we see neutrals on the base embedding level
3817 following a character whose directionality is the same as the
3818 paragraph's. This avoids running the expensive loop when a line
3819 ends in a long sequence of neutrals, like control characters.
3820 Add assertion against STRONG_AL type. Slightly rearrange code
3821 that determines the type of a neutral given the first non-neutral
3822 that follows it.
3823 (bidi_level_of_next_char): Set next_en_pos to zero when
3824 invalidating its info.
3825
2c91f553
EZ
38262011-10-17 Eli Zaretskii <eliz@gnu.org>
3827
3828 * xdisp.c (push_display_prop): Determine whether to record string
3829 or buffer position by IT->string, not by IT->method. Allow
3830 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
3831 (move_it_vertically_backward): Don't look for character position
3832 immediately after the newline when in a continuation line.
3833 (Bug#9771, part 1)
2c91f553 3834
c7b08b0d
MR
38352011-10-15 Martin Rudalics <rudalics@gmx.at>
3836
3837 * window.c (coordinates_in_window): Rewrite and delabelize
3838 vertical border check. (Bug#5357) (Bug#9618)
3839
6b02f655
SM
38402011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3841
3842 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3843 errors in XSetWindowBorder (bug#9310).
3844
81d40c92
DA
38452011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3846
3847 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3848 avoid crash when xmalloc overrun checking is enabled.
3849
d4172c3b
EZ
38502011-10-13 Eli Zaretskii <eliz@gnu.org>
3851
3852 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3853 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3854 cursor motion with <left> and <right> arrow keys.
3855
3856 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3857 some callers set that themselves.
3858
b00eea75
EZ
38592011-10-12 Eli Zaretskii <eliz@gnu.org>
3860
3861 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3862 display string and the previous row comes from the same string and
3863 is empty. (Bug#9739) (Bug#9738)
3864
8fe012c4
SM
38652011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3866
3867 * doc.c (get_doc_string): Encode file name (bug#9735).
3868
0074aef2
EZ
38692011-10-12 Eli Zaretskii <eliz@gnu.org>
3870
79beb178
EZ
3871 * bidi.c (bidi_level_of_next_char):
3872 * xdisp.c (get_visually_first_element): Remove old incorrect
3873 comments regarding the Unicode Line Separator character.
3874
0074aef2
EZ
3875 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3876
6e4b3fbe
DA
38772011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3878
3879 * alloc.c (Fgc_status): Do not access beyond zombies array
3880 boundary if nzombies > MAX_ZOMBIES.
3881 * alloc.c (dump_zombies): Add missing format specifier.
3882
0324f3af
PE
38832011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3884
b5525cac
PE
3885 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3886 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3887
0324f3af
PE
3888 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3889 Some packages use them to denote characters with modifiers.
3890
e9b5f888
AS
38912011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3892
3893 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3894 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3895 matching a pp-number. Rename parameter var to var1.
3896
127827c0
SM
38972011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3898
3899 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3900
c8fd3bd0
GM
39012011-10-08 Glenn Morris <rgm@gnu.org>
3902
3903 * callint.c (Fcall_interactively): Give a more explicit error for the
3904 'c' case with a non-character input. (Bug#8479)
3905
352ec8ff
EZ
39062011-10-08 Eli Zaretskii <eliz@gnu.org>
3907
03669ccb
EZ
3908 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3909 lines.
7061c986
EZ
3910 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3911 lines that are hscrolled on the left.
03669ccb 3912
352ec8ff
EZ
3913 * dispnew.c (buffer_posn_from_coords): Account for a possible
3914 presence of header-line. (Bug#4426)
3915
a66cfb1c
SM
39162011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3917
6b02f655
SM
3918 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3919 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 3920
7c5ee88e
PE
39212011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3922
3923 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3924 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3925 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3926 this makes Emacs dump core during garbage collection on rare
3927 occasions. sizeof is obviously inferior to offsetof here, so
3928 stick with offsetof.
3929 (GC_POINTER_ALIGNMENT): New macro.
3930 (mark_memory): Omit 3rd (offset) arg; caller changed.
3931 Don't assume EMACS_INT alignment is the same as pointer alignment.
3932
df1bbe5b
SM
39332011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3934
3935 * keyboard.c (read_key_sequence_remapped): New var.
3936 (read_key_sequence): Compute remapping in the right buffer.
3937 (command_loop_1): Use read_key_sequence's remapping directly.
3938
51553db6
SM
39392011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3940
32c1fffd
SM
3941 * dired.c (file_name_completion): Don't expand file name.
3942 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3943 before checking file name handler.
3944
51553db6
SM
3945 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3946 they've been requested explicitly (bug#9591).
3947
b6bd1599 39482011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
3949
3950 * keymap.c (Fsingle_key_description): Use make_specified_string
3951 instead of build_string to build string from push_key_description.
3952 (Bug#5193)
3953
f701dc2a
PE
39542011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3955
4222c55d
PE
3956 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3957 This fixes a Y2038 bug on 64-bit hosts.
3958 * buffer.c (reset_buffer):
3959 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3960 (Fclear_buffer_auto_save_failure):
3961 Use 0, not -1, to represent an unset failure time, since time_t
3962 might not be signed.
3963
f701dc2a
PE
3964 Remove dependency on glibc malloc internals.
3965 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3966 Move back here from lisp.h, but with their new implementations.
3967 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3968 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3969 * charset.c (charset_table_init): New static var.
3970 (syms_of_charset): Use it instead of xmalloc. This removes a
3971 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3972 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3973 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3974 Move back to alloc.c.
3975 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3976 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3977
9ceebf39
JD
39782011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3979
3980 * nsterm.m (windowDidResize): Call x_set_window_size only when
3981 ns_in_resize is true. Otherwise set pixelwidth/height and
3982 call change_frame_size (Bug#9628).
3983
cb993c58
PE
39842011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3985
3930c88b
PE
3986 Port --enable-checking=all to Fedora 14 x86-64.
3987 * charset.c (syms_of_charset): Also account for glibc malloc's
3988 internal overhead when calculating the initial malloc maximum.
3989
cb993c58
PE
3990 Port --enable-checking=all to Fedora 14 x86.
3991 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3992 Move to lisp.h.
3993 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3994 (overrun_check_realloc, overrun_check_free):
3995 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3996 That way, xmalloc returns a properly-aligned pointer even if
3997 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3998 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3999 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4000 into account when calculating the initial malloc maximum.
4001 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4002 Move here from alloc.c, so that charset.c can use it too.
4003 Properly align; the old code wasn't right for common 32-bit hosts
4004 when configured with --enable-checking=all.
4005 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4006 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4007
31bed486
EZ
40082011-09-29 Eli Zaretskii <eliz@gnu.org>
4009
04c70788 4010 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4011 use EDOM.
4012
fbcaa2f3
EZ
40132011-09-28 Eli Zaretskii <eliz@gnu.org>
4014
4015 * xdisp.c (compute_display_string_end): If there's no display
4016 string at CHARPOS, return -1.
4017
4018 * bidi.c (bidi_fetch_char): When compute_display_string_end
4019 returns a negative value, treat the character as a normal
4020 character not covered by a display string. (Bug#9624)
4021
a239d4e9
JB
40222011-09-28 Juanma Barranquero <lekktu@gmail.com>
4023
4024 * lread.c (Fread_from_string): Fix typo in docstring.
4025
88652fd5
EZ
40262011-09-27 Eli Zaretskii <eliz@gnu.org>
4027
4028 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4029 newline, reseat the iterator instead of bidi-iterating there one
4030 character at a time. (Bug#9610)
32c1fffd
SM
4031 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4032 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4033
ed497dd4
AS
40342011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4035
4036 * lread.c (readevalloop): Use correct code for NBSP.
4037 (read1): Likewise. (Bug#9608)
4038
b2bf61aa
MA
40392011-09-25 Michael Albinus <michael.albinus@gmx.de>
4040
4041 * dbusbind.c (Fdbus_register_signal): When service is not
4042 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4043
32bbb17c
GM
40442011-09-25 Glenn Morris <rgm@gnu.org>
4045
4046 * buffer.c (truncate-lines): Doc fix.
4047
94e0933e
CY
40482011-09-24 Chong Yidong <cyd@stupidchicken.com>
4049
4050 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4051 (Fset_window_next_buffers): Doc fix.
4052
cddde921
GM
40532011-09-24 Glenn Morris <rgm@gnu.org>
4054
4055 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4056
1260aef1
PE
40572011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4058
25b4bfa0
PE
4059 Fix minor problems found by static checking.
4060 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4061 * indent.c (Fvertical_motion): Fix == vs = typo.
4062
e3cbd34b
EZ
40632011-09-24 Eli Zaretskii <eliz@gnu.org>
4064
a66cfb1c
SM
4065 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4066 Default value is now t. Doc fix.
6bf7006f 4067
e3cbd34b 4068 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4069 logic when moving up, not only when moving down. Fix the
e3cbd34b 4070 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4071 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4072
4073 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4074 CHARPOS is covered by a display string which includes newlines.
4075 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4076 is covered by a display string with embedded newlines.
4077
a3de0cbd
MA
40782011-09-24 Michael Albinus <michael.albinus@gmx.de>
4079
4080 * dbusbind.c (Fdbus_register_signal): Add match rule to
4081 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4082 (Fdbus_register_method, Vdbus_registered_objects_table):
4083 Fix docstring.
a3de0cbd 4084
b260039d
JM
40852011-09-24 Jim Meyering <meyering@redhat.com>
4086
32c1fffd 4087 do not ignore write error for any output size
b260039d
JM
4088 The previous change was incomplete.
4089 While it makes emacs --batch detect the vast majority of stdout
4090 write failures, errors were still ignored whenever the output size is
4091 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4092 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4093 && echo FAIL: ignored write error
4094 FAIL: ignored write error
4095 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4096 && echo FAIL: ignored write error
4097 FAIL: ignored write error
4098 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4099
8eca8a7c
AS
41002011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4101
4102 * emacs.c (Fkill_emacs): In noninteractive mode exit
4103 non-successfully if a write error occurred on stdout. (Bug#9574)
4104
3341db62
EZ
41052011-09-21 Eli Zaretskii <eliz@gnu.org>
4106
4107 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4108 the xassert test.
4109
4110 * dispextern.h (struct it): Update the comment documenting what
4111 can it->OBJECT be.
4112
8c203dbf
EZ
41132011-09-20 Eli Zaretskii <eliz@gnu.org>
4114
4115 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4116 a display string, extend search for cursor position to end of row.
4117 (find_row_edges): If the row ends in a newline from a display
4118 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4119 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4120 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4121 non-empty line. Fixes confusing cursor motion with arrow keys at
4122 the beginning of a line that starts with whitespace.
8c203dbf 4123
a4824228
LMI
41242011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4125
4126 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4127 (bug#9493).
4128
33ed493b
CY
41292011-09-18 Chong Yidong <cyd@stupidchicken.com>
4130
4131 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4132 boolean (Bug#9154).
4133
56cd55c8
EZ
41342011-09-18 Eli Zaretskii <eliz@gnu.org>
4135
4136 * xdisp.c (display_line): Record maximum and minimum buffer
4137 positions even if no glyphs were produced (e.g., by a zero-width
4138 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4139 buffer positions that will be removed from the glyph row because
4140 they don't fit.
c02dcedf
EZ
4141 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4142 column is beyond frame width: don't subtract 1 "pixel" when
4143 computing width of the stretch.
3e62b7e0
EZ
4144 (reseat_at_next_visible_line_start): Undo the change made on
4145 2011-09-17 that saved paragraph information and restored it after
4146 the call to `reseat'. (Bug#9545)
56cd55c8 4147
5ed99d36 41482011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4149
4150 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4151 and turn window cursor on if cleared (Bug#9415).
4152
5ed99d36 41532011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4154
4155 * search.c (boyer_moore): Take unibyte characters from pattern
4156 literally. (Bug#9458)
4157
9bade7b2
EZ
41582011-09-18 Eli Zaretskii <eliz@gnu.org>
4159
4160 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4161
e5e9d610
PE
41622011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4163
87e4427a
PE
4164 Fix minor problem found by static checking.
4165 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4166 initialized, to pacify gcc -Wuninitialized.
4167
e5e9d610
PE
4168 * fileio.c: Report proper errno when syscall falls.
4169 (Finsert_file_contents): Save and restore errno,
4170 so that report_file_error outputs the correct diagnostic.
4171 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4172
a1674f0b
EZ
41732011-09-18 Eli Zaretskii <eliz@gnu.org>
4174
4175 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4176
fbfb6dd4
EZ
41772011-09-17 Eli Zaretskii <eliz@gnu.org>
4178
4179 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4180 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4181
bb187662
EZ
41822011-09-17 Eli Zaretskii <eliz@gnu.org>
4183
1137e8b8 4184 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4185 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4186
4187 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4188 (bidi_find_paragraph_start): Search back for paragraph beginning
4189 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4190 (bidi_move_to_visually_next): Only trigger paragraph-related
4191 computations when the last character is a newline or at EOB, not
4192 just any NEUTRAL_B. (Bug#9470)
4193
bb187662
EZ
4194 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4195 truncated lines if point is covered by a display string. (Bug#9524)
4196
2e621251
PE
41972011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4198
4199 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4200 (cons_to_x_long): New function.
4201 (lisp_data_to_selection_data): Use it. Correct the test for
4202 short-versus-long data; it was negated. Break out of vector
4203 loop, for efficiency, when a long datum is discovered.
4204
91a15bc6
SM
42052011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4206
4207 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4208
b41c3a35
EZ
42092011-09-16 Eli Zaretskii <eliz@gnu.org>
4210
4211 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4212 GCC PR/17406) by declaring this function with external scope.
4213
7812ba2d
PE
42142011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4215
4216 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4217 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4218
cf7edc2a
AS
42192011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4220
4221 * editfns.c (Fformat): Correctly handle text properties on "%%".
4222
bd01620e
EZ
42232011-09-15 Eli Zaretskii <eliz@gnu.org>
4224
4225 * xterm.c (x_draw_composite_glyph_string_foreground):
4226 * w32term.c (x_draw_composite_glyph_string_foreground):
4227 * term.c (encode_terminal_code):
4228 * composite.c (composition_update_it, get_composition_id):
4229 * xdisp.c (get_next_display_element)
4230 (fill_composite_glyph_string): Add comments about special meaning
4231 of TAB characters in a composition.
4232
a02719a3
PE
42332011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4234
4235 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4236 This occurs when processing a multibyte format.
4237 Problem reported by Wolfgang Jenker.
a02719a3 4238
72589a3c
JB
42392011-09-15 Johan Bockgård <bojohan@gnu.org>
4240
4241 * xdisp.c (try_cursor_movement): Only check for exact match if
4242 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4243
1c14176c
PE
42442011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4245
4246 Remove unused external symbols.
4247 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4248 * xdisp.c (calc_pixel_width_or_height): Now static.
4249 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4250 * indent.c (check_display_width):
4251 * w32term.c: Fix comment to match code.
4252 * xterm.c, xterm.h (x_catching_errors): Remove.
4253
d2eea5b5
PE
42542011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4255
4256 * xselect.c: Use signed conversions more consistently (Bug#9498).
4257 (selection_data_to_lisp_data): Assume incoming selection data are
4258 signed integers, not unsigned. This is to be consistent with
4259 outgoing selection data, which was modified to use signed integers
4260 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4261 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4262 expects long, not unsigned long.
4263
46888499
EZ
42642011-09-14 Eli Zaretskii <eliz@gnu.org>
4265
4266 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4267 computation of loop end. Reported by Johan Bockgård
4268 <bojohan@gnu.org>.
4269
ef8ef9fb
CY
42702011-09-13 Chong Yidong <cyd@stupidchicken.com>
4271
4272 * frame.c (Fother_visible_frames_p): Function deleted.
4273
fa819fed
EZ
42742011-09-12 Eli Zaretskii <eliz@gnu.org>
4275
4276 * indent.c (compute_motion): Process display vector front to back
4277 rather than the other way around. (Bug#2496)
4278
2ba8e008
SM
42792011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4280
4281 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4282
20f53c69
CY
42832011-09-11 Chong Yidong <cyd@stupidchicken.com>
4284
4285 * minibuf.c (Fread_from_minibuffer): Doc fix.
4286
d562d7a4
EZ
42872011-09-11 Eli Zaretskii <eliz@gnu.org>
4288
4289 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4290 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4291
1c4d7f3d
LMI
42922011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4293
4294 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4295 value for non-existent files.
4296
b885bf36
EZ
42972011-09-11 Eli Zaretskii <eliz@gnu.org>
4298
4299 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4300 set its "size" to -1. This will set the modtime_size field of
4301 the corresponding buffer to -1, which is what
4302 verify-visited-file-modtime expects for files that do not exist.
4303 (Bug#9139)
4304
6612f0bf
PE
43052011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4306
4307 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4308 here ...
4309 * lisp.h: ... from here. push_key_description is no longer
4310 defined in keyboard.c, so its declaration should not be in
4311 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4312 logically belongs with push_key_description.
4313
dfb3f755
PE
43142011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4315
4316 * buffer.h: Include <sys/types.h> instead of <time.h>.
4317 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4318 Problem reported by Herbert J. Skuhra.
4319
3134906c
LMI
43202011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4321
4322 * xml.c (parse_region): Make the parsing work for
4323 non-comment-starting XML files again (bug#9144).
4324
8d903f4e
AS
43252011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4326
4327 * image.c (gif_load): Fix calculation of bottom and right corner.
4328 (Bug#9468)
4329
80ad64f4
EZ
43302011-09-10 Eli Zaretskii <eliz@gnu.org>
4331
4332 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4333 redisplay in small windows.
4334
208a048d
EZ
43352011-09-09 Eli Zaretskii <eliz@gnu.org>
4336
4337 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4338
9b1c252e
MR
43392011-09-08 Martin Rudalics <rudalics@gmx.at>
4340
4341 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4342 Operate on live windows only.
4343
2949f33b
JB
43442011-09-08 Juanma Barranquero <lekktu@gmail.com>
4345
4346 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4347
e08dcafd
EZ
43482011-09-07 Eli Zaretskii <eliz@gnu.org>
4349
4350 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4351 only under bidi iteration.
4352
115b96bd
JD
43532011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4354
4355 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4356
c8199d0f
PE
43572011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4358
4359 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4360 Without this fix, the command to link temacs failed due to an
4361 undefined symbol __builtin_isnan. This is because
4362 /usr/include/iso/math_c99.h #defines isnan(x) to
4363 __builtin_isnan(x), but the bundled gcc, which identifies itself
4364 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4365 a __builtin_isnan.
4366 * floatfns.c (isnan): #undef, and then #define to a clone of
4367 what's in data.c.
4368 (Fisnan): Always define, since it's always available now.
4369 (syms_of_floatfns): Always define isnan at the Lisp level.
4370
e39b275c 43712011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4372
4373 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4374
b2db44d9 43752011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4376
f4af5137 4377 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4378 The previous code assumed that file offsets (off_t values) fit in
4379 EMACS_INT variables, which is not true on typical 32-bit hosts.
4380 The code messed up by falsely reporting buffer overflow in cases
4381 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4382 when "big" contains more than 2**29 bytes, even though this
4383 inserts just one byte and does not overflow the buffer.
4384 (Finsert_file_contents): Store file offsets as off_t
4385 values, not as EMACS_INT values. Check for overflow when
4386 converting between EMACS_INT and off_t. When checking for
4387 buffer overflow or for overlap, take the offsets into account.
4388 Don't use EMACS_INT for small values where int suffices.
4389 When checking for overlap, fix a typo: ZV was used where
4390 ZV_BYTE was intended.
4391 (Fwrite_region): Don't assume off_t fits into 'long'.
4392 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4393
ecfc0a49
MA
43942011-09-05 Michael Albinus <michael.albinus@gmx.de>
4395
4396 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4397
6511acf2 43982011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4399
0999621a 4400 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4401
4402 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4403 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4404 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4405 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4406 (modify_event_symbol): Do not assume that the length of
4407 name_alist_or_stem is safe to alloca and fits in int.
4408 (Fexecute_extended_command): Likewise for function name and binding.
4409 (Frecursion_depth): Wrap around reliably on integer overflow.
4410 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4411 since some callers pass EMACS_INT values.
4412 (Fsingle_key_description): Don't crash if symbol name contains more
4413 than MAX_ALLOCA bytes.
4414 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4415 (get_minibuffer): Arg is now EMACS_INT, not int.
4416 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4417 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4418 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4419
2be7d702
PE
4420 * dbusbind.c (signature_cat): New function.
4421 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4422 Do not overrun buffer; instead, report string overflow.
4423
9d1df220
PE
4424 * dispnew.c (add_window_display_history): Don't overrun buffer.
4425 Truncate instead; this is OK since it's just a log.
4426
33ef5c64
PE
4427 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4428 even if the time zone offset is outlandishly large.
4429 Don't mishandle offset == INT_MIN.
4430
66c6fdd5
PE
4431 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4432 when creating daemon; the previous buffer-overflow check was incorrect.
4433
d749b01b
PE
4434 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4435 which has the guts of the old verror function.
4436
b5cd1905
PE
4437 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4438 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4439
6e1a67fb
PE
4440 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4441 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4442 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4443 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4444 length of string rather than counting it via multiple sprintfs;
4445 that's simpler and more reliable.
c21721cc
PE
4446 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4447 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4448 sprintf, in case result does not fit in int.
4449
c57b67fc
PE
4450 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4451 (fontset_from_font): Print it.
4452
8a401434
PE
4453 * frame.c (tty_frame_count): Now printmax_t, not int.
4454 (make_terminal_frame, set_term_frame_name): Print it.
4455 (x_report_frame_params): In X, window IDs are unsigned long,
4456 not signed long, so print them as unsigned.
4457 (validate_x_resource_name): Check for implausibly long names,
4458 and don't assume name length fits in 'int'.
4459 (x_get_resource_string): Don't blindly alloca invocation name;
4460 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4461 not fit in int.
4462
6e1a67fb
PE
4463 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4464 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4465 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4466
0df02bf3
PE
4467 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4468 Use esprintf, not sprintf, in case result does not fit in int.
4469
48e30793
PE
4470 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4471 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4472 it as a large positive number.
4473 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4474 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4475
a66ff6d8
PE
4476 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4477 in case result does not fit in int.
4478
aca216ff
PE
4479 * print.c (float_to_string): Detect width overflow more reliably.
4480 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4481 buffer overrun. Don't assume list length fits in 'int'. Treat
4482 print length of 0 as 0, not as infinity; to be consistent with other
4483 uses of print length in this function. Don't overflow print length
4484 index. Don't assume hash table size fits in 'long', or that
4485 vectorlike size fits in 'unsigned long'.
4486
31c286f7
PE
4487 * process.c (make_process): Use printmax_t, not int, to format
4488 process-name gensyms.
4489
55e5faa1
PE
4490 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4491
80f2e268
PE
4492 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4493 to avoid potential buffer overrun.
4494
670741ab
PE
4495 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4496 if X resource line is longer than 512 bytes.
4497
b7163a50
PE
4498 * xfns.c (x_window): Make sprintf buffer a bit bigger
4499 to avoid potential buffer overrun.
4500
ae58ff1f
PE
4501 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4502
c43c8a6a
PE
4503 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4504
3f8236f4
PE
45052011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4506
53e9fe90 4507 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4508 Without these, Emacs silently mishandles large integers sometimes.
4509 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4510 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4511
6511acf2
PE
4512 * xdisp.c (try_window_id): Check Emacs fixnum range before
4513 converting to 'int'.
806add1d 4514
6511acf2 4515 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4516 Check that an Emacs fixnum is in range before assigning it to 'int'.
4517 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4518 values converted from Emacs fixnums.
4519 (Frecenter): Don't wrap around a line count if it is out of 'int'
4520 range; instead, treat it as an extreme value.
4521 (Fset_window_configuration, compare_window_configurations):
4522 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4523
6511acf2
PE
4524 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4525 that can exceed INT_MAX. Check that EMACS_INT value is in range
4526 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4527 (match_limit): Don't assume that a fixnum can fit in 'int'.
4528
6511acf2 4529 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4530 exceed INT_MAX.
4531
6511acf2 4532 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4533 (Fvertical_motion): Don't wrap around LINES values that don't fit
4534 in 'int'. Instead, treat them as extreme values. This is good
4535 enough for windows, which can't have more than INT_MAX lines anyway.
4536
fcb901a7
LMI
45372011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4538
0f2f6b6d
LMI
4539 * Require libxml/parser.h to avoid compilation warning.
4540
fcb901a7
LMI
4541 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4542
4543 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4544 since this reportedly can destroy thread storage.
4545
6e20a0d4
CY
45462011-08-30 Chong Yidong <cyd@stupidchicken.com>
4547
4548 * syntax.c (find_defun_start): Update all cache variables if
4549 exiting early (Bug#9401).
4550
148ae00e
EZ
45512011-08-30 Eli Zaretskii <eliz@gnu.org>
4552
f6cfbd8f
EZ
4553 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4554
148ae00e
EZ
4555 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4556 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4557 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4558
4559 * term.c (tty_append_glyph): New function.
4560 (produce_stretch_glyph): Static function and its prototype deleted.
4561
a66cfb1c
SM
4562 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4563 Add prototypes.
148ae00e 4564
c4a07a4c
PE
45652011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4566
4567 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4568 when checking :margin (Bug#9390).
4569 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 4570 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
4571 so that the name doesn't mislead. All uses changed.
4572
6bc8cd65
JB
45732011-08-28 Johan Bockgård <bojohan@gnu.org>
4574
4575 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4576 set_tty_hooks.
4577
dca4927e
EZ
45782011-08-27 Eli Zaretskii <eliz@gnu.org>
4579
4580 * xdisp.c (move_it_to): Don't bail out early when reaching
4581 position beyond to_charpos, if we are scanning backwards.
4582 (move_it_vertically_backward): When DY == 0, make sure we get to
4583 the first character in the line after the newline.
4584
f2cad773
PE
45852011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4586
4587 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4588 (ccl_driver): Do not generate an out-of-range pointer.
4589 (Fccl_execute_on_string): Remove unnecessary check for
4590 integer overflow, noted by Stefan Monnier in
4591 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4592 Remove a FIXME that didn't need fixing.
4593 Simplify the newly-introduced buffer reallocation code.
4594
0cae2cdb
JB
45952011-08-27 Juanma Barranquero <lekktu@gmail.com>
4596
4597 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4598
5fc295a4 45992011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 4600
70c60eb2 4601 Integer and memory overflow issues (Bug#9196).
726e0ab1 4602
d31850da
PE
4603 * doc.c (get_doc_string): Rework so that
4604 get_doc_string_buffer_size is the actual buffer size, rather than
4605 being 1 less than the actual buffer size; this makes xpalloc more
4606 convenient.
4607
a69fbedb
PE
4608 * image.c (x_allocate_bitmap_record, cache_image):
4609 * xselect.c (Fx_register_dnd_atom):
4610 Simplify previous changes by using xpalloc.
4611
fe5c5d37
PE
4612 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4613 since either will do and ptrdiff_t is convenient with xpalloc.
4614
0065d054
PE
4615 * charset.c (charset_table_size)
4616 (struct charset_sort_data.priority): Now ptrdiff_t.
4617 (charset_compare): Don't overflow if priorities differ greatly.
4618 (Fsort_charsets): Don't assume list length fits in int.
4619 Check for size-calculation overflow when allocating sort data.
4620 (syms_of_charset): Allocate an initial charset table that is
4621 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4622
4623 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4624
4625 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4626 The actual value is always <= INT_MAX, and leaving it unsigned made
4627 overflow checking harder.
4628
4629 * dispextern.h (struct glyph_matrix.rows_allocated)
4630 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4631 with xpalloc. The values are still always <= INT_MAX.
4632
4633 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4634
4635 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4636 (SAFE_NALLOCA): New macro.
4637
4638 * region-cache.c (struct boundary.pos, find_cache_boundary)
4639 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4640 (set_cache_region, invalidate_region_cache)
4641 (revalidate_region_cache, know_region_cache, region_cache_forward)
4642 (region_cache_backward, pp_cache):
4643 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4644 so that ptrdiff_t * can be passed to xpalloc.
4645 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4646 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4647 (pp_cache): Don't assume cache_len fits in int.
4648 * region-cache.h: Adjust extern decls to match.
4649
4650 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4651 EMACS_INT, since either will do, for xpalloc.
4652
4653 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4654 (xnmalloc, xnrealloc, xpalloc): New functions.
4655
726e0ab1
PE
4656 * bidi.c (bidi_shelve_header_size): New constant.
4657 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4658 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4659
51f30bc5 4660 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
4661 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4662 (overlay_strings):
4663 Don't update size of array until after memory allocation succeeds,
4664 because xmalloc/xrealloc may not return.
0065d054
PE
4665 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4666 now that we have proper integer overflow checking.
4667 (record_overlay_string, overlay_strings): Catch overflows when
4668 calculating size of overlay_str_buf.
726e0ab1 4669
0065d054
PE
4670 * callproc.c (Fcall_process): Check for size overflow when
4671 calculating size of args2.
4672 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4673 Normally we prefer signed values, but sticking with ptrdiff_t would
4674 require adding more-complicated checks.
726e0ab1
PE
4675
4676 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4677 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4678 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 4679 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
4680
4681 * character.c (Fstring): Check for size-calculation overflow.
4682
4683 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4684 unnecessary integer overflow. Check for size overflow.
4685 (encode_coding_object): Don't update size until xmalloc succeeds.
4686
4687 * composite.c (get_composition_id): Check for overflow in glyph
4688 length calculations.
4689
4690 Integer and memory overflow fixes for display code.
4691 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4692 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4693 (scrolling_window): Check for overflow in size calculations.
4694 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4695 Don't assume glyph table len fits in int.
4696 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4697 (row_table_size): Now ptrdiff_t, not int.
4698 (scrolling_window): Avoid overflow in size calculations.
4699 Don't update size until allocation succeeds.
4700 * fns.c (concat): Check for overflow in size calculations.
4701 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4702 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4703 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4704
4705 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4706 (get_doc_string): Check for size calculation overflow.
4707 Don't update size until allocation succeeds.
4708 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4709 EMACS_INT, where ptrdiff_t will do.
4710 (Fsubstitute_command_keys): Check for string overflow.
4711
4712 * editfns.c (set_time_zone_rule): Don't assume environment length
4713 fits in int.
4714 (message_length): Now ptrdiff_t, not int.
4715 (Fmessage_box): Don't update size until allocation succeeds.
4716 Don't assume message length fits in int.
4717 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4718
0065d054
PE
4719 * emacs.c (main): Do not reallocate argv, since there is a null at
4720 the end that can be overwritten, and this way there's no need to
4721 worry about size-calculation overflow.
4722 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
4723
4724 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4725 alloc succeeds.
4726 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4727
4728 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4729 (x_set_scroll_bar_width, x_figure_window_size):
4730 Check for integer overflow.
4731 (x_set_alpha): Do not assume XINT fits in int.
4732
4733 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4734 This is for the members text_lines, text_cols, total_lines, total_cols,
4735 where the system imposes an 'int' limit.
4736
4737 * fringe.c (Fdefine_fringe_bitmap):
4738 Don't update size until alloc works.
4739
4740 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4741 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4742
4743 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4744 Check for size-calculation overflow.
4745 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4746 do, as we prefer signed integers.
4747 (id_to_widget.max_size, id_to_widget.used)
4748 (xg_store_widget_in_map, xg_remove_widget_from_map)
4749 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4750 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4751 Use and return ptrdiff_t, not int.
4752 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4753 * gtkutil.h: Change prototypes to match the above.
4754
4755 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4756 are duplicate now that they've been promoted to lisp.h.
4757 (x_allocate_bitmap_record, x_alloc_image_color)
4758 (make_image_cache, cache_image, xpm_load):
4759 Don't update size until alloc is done.
4760 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4761 (x_detect_edges):
3256efce 4762 Check for size calculation overflow.
726e0ab1
PE
4763 (ct_colors_allocated_max): New constant.
4764 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4765 overflow.
3256efce 4766
726e0ab1
PE
4767 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4768 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4769 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4770 Use ptrdiff_t, not int, to count maps.
4771 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
4772 calculations. Don't update size until allocation succeeds.
4773 Redo calculations to avoid overflow.
726e0ab1
PE
4774 * keyboard.h: Change prototypes to match the above.
4775
4776 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4777 to count maps.
4778 (current_minor_maps): Check for size calculation overflow.
4779 * keymap.h: Change prototypes to match the above.
4780
4781 * lread.c (read1, init_obarray): Don't update size until alloc done.
4782
4783 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4784 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4785
726e0ab1
PE
4786 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4787 Now ptrdiff_t, not int.
4788 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4789 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4790
4791 * process.c (Fnetwork_interface_list): Check for overflow
4792 in size calculation.
4793
4794 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4795
4796 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4797 overflow. Don't bother calling xmalloc when xrealloc will do.
4798
4799 * search.c (Freplace_match): Check for size calculation overflow.
4800 (Fset_match_data): Don't assume list lengths fit in 'int'.
4801
4802 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4803 for command line length. Do not attempt to address one before the
4804 beginning of an array, as that's not portable.
4805
4806 * term.c (max_frame_lines): Remove; unused.
4807 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4808 not int.
4809 (encode_terminal_code, calculate_costs): Check for size
4810 calculation overflow.
4811 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4812 table lengths and related sizes. Don't update size until alloc
4813 done. Redo calculations to avoid overflow.
4814 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4815
4816 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4817 subtracting pointers.
4818 (gobble_line): Check for overflow more carefully. Don't update size
4819 until alloc done.
4820
4821 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4822 Don't update size until alloc done.
4823 Redo size calculations to avoid overflow.
4824 Check for size calculation overflow.
0065d054 4825 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
4826
4827 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4828 Use ptrdiff_t, not int, for sizes.
4829 (store_mode_line_noprop_char): Don't update size until alloc done.
4830
0065d054
PE
4831 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4832 Use ptrdiff_t, not int, for sizes.
4833 (Finternal_make_lisp_face, cache_face):
4834 Check for size calculation overflow.
4835 (cache_face): Treat size calculation overflows as if they were
4836 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
4837
4838 * xfns.c (x_encode_text, x_set_name_internal)
4839 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4840 sizes, since they can exceed INT_MAX in size. Check for size
4841 calculation overflow.
4842
0065d054
PE
4843 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4844 (xg_select): Check for size calculation overflow.
726e0ab1
PE
4845 Don't update size until alloc done.
4846
0065d054 4847 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 4848 as sprintf is limited to int lengths.
1d526e2f 4849
252c5ee1
PE
4850 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4851 (X_LONG_MIN): New macros.
864d7ce7
PE
4852 Use them to make the following changes clearer.
4853 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4854 This change doesn't affect the value now, but it may help remind
4855 future maintainers not to raise the value too much later.
4856 (SELECTION_QUANTUM): Remove, replacing with ...
4857 (selection_quantum): ... new function, which avoids overflow.
4858 All uses changed.
4859 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4860 assumption that selection length fits in 'int'.
4861 (x_reply_selection_request, x_handle_selection_request)
4862 (x_get_window_property, receive_incremental_selection)
4863 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4864 (lisp_data_to_selection_data, clean_local_selection_data):
4865 Use ptrdiff_t, not int, to record length of selection.
4866 (x_reply_selection_request, x_get_window_property)
4867 (receive_incremental_selection, x_property_data_to_lisp):
4868 Redo calculations to avoid overflow.
4869 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 4870 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
4871 something.
4872 (x_get_window_property, receive_incremental_selection)
4873 (lisp_data_to_selection_data, x_property_data_to_lisp):
4874 Check for size-calculation overflow.
4875 (x_get_window_property, receive_incremental_selection)
4876 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4877 Don't store size until memory allocation succeeds.
4878 (x_get_window_property): Plug memory leak on memory exhaustion.
4879 Don't double-block input; malloc is safe here. Don't assume 2**34
4880 - 4 fits in unsigned long. Add an xassert to check
4881 XGetWindowProperty overflow. Be more careful about overflow
4882 calculations, and distinguish size from memory overflow better.
4883 (receive_incremental_selection): When tracing, don't assume
4884 unsigned int is less than INT_MAX.
4885 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4886 harmful) conversions of unsigned short to int.
4887 (lisp_data_to_selection_data): Don't assume that integers
4888 in the range -65535 through -1 fit in an X unsigned short.
4889 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4890 result parameters unless successful. Rely on cons_to_unsigned
4891 to report problems with elements; the old code wasn't right anyway.
4892 (x_check_property_data): Check for int overflow; we cannot use
4893 a wider type due to X limits.
4894 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4895
726e0ab1 4896 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 4897
0065d054
PE
4898 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4899 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
4900 (x_color_cells): Don't store size until memory allocation succeeds.
4901 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 4902 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
4903 (x_term_init): Don't assume length fits in int (sprintf is limited
4904 to int size).
bc18e09d 4905
ebfa62c0
PE
4906 Use ptrdiff_t for composition IDs.
4907 * character.c (lisp_string_width):
4908 * composite.c (composition_table_size, n_compositions)
4909 (get_composition_id, composition_gstring_from_id):
4910 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4911 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4912 * window.c (Frecenter):
4913 Use ptrdiff_t, not int, for composition IDs.
4914 * composite.c (get_composition_id): Check for integer overflow.
4915 * composite.h: Adjust prototypes to match the above changes.
4916
d3411f89
PE
4917 Use ptrdiff_t for hash table indexes.
4918 * category.c (hash_get_category_set):
4919 * ccl.c (ccl_driver):
4920 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4921 * coding.c (coding_system_charset_list, detect_coding_system):
4922 * coding.h (struct coding_system.id):
4923 * composite.c (get_composition_id, gstring_lookup_cache):
4924 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4925 * image.c (xpm_get_color_table_h):
4926 * lisp.h (hash_lookup, hash_put):
4927 * minibuf.c (Ftest_completion):
4928 Use ptrdiff_t for hash table indexes, not int (which is too
4929 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4930 32-bit --with-wide-int hosts).
4931
e097a6fa
PE
4932 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4933 Add a FIXME comment about memory leaks.
4934 (syms_of_charset): Don't assume xmalloc returns.
4935
5637687f
PE
4936 Don't assume that stated character widths fit in int.
4937 * character.c (Fchar_width, c_string_width, lisp_string_width):
4938 * character.h (CHAR_WIDTH):
4939 * indent.c (MULTIBYTE_BYTES_WIDTH):
4940 Use sanitize_char_width to avoid undefined and/or bad behavior
4941 with outlandish widths.
a66cfb1c 4942 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
4943 now that we have two such functions. All uses changed.
4944 (sanitize_char_width): New inline function.
4945
a2271ba2
PE
4946 Don't assume that tab-width fits in int.
4947 * character.h (sanitize_width): New inline function.
4948 (SANE_TAB_WIDTH): New macro.
4949 (ASCII_CHAR_WIDTH): Use it.
4950 * indent.c (sane_tab_width): Remove. All uses replaced by
4951 SANE_TAB_WIDTH (current_buffer).
4952 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4953
18c52557
PE
4954 * fileio.c: Integer overflow issues with file modes.
4955 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4956
caeeedc1
PE
4957 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4958 Remove unreachable code.
4959 (read_hex, load_charset_map_from_file): Check for integer overflow.
4960
6df6ae42 4961 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
4962 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4963 (x_send_scroll_bar_event): Likewise. Check that the size does not
4964 exceed limits imposed by XClientMessageEvent, as well as the usual
4965 ptrdiff_t and size_t limits.
4966
b13995db
PE
4967 * keyboard.c: Overflow, signedness and related fixes.
4968 (make_lispy_movement): Use same integer type in forward decl
4969 that is used in the definition.
4970 (read_key_sequence, keyremap_step):
4971 Change bufsize argument back to int, undoing my 2011-03-30 change.
4972 We prefer signed types, and int is wide enough here.
4973 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4974 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4975 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4976 length, not size_t. Use ptrdiff_t for index, not int.
4977 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4978 possibility of integer overflow.
4979
13464394
PE
4980 Overflow, signedness and related fixes for images.
4981
4982 * dispextern.h (struct it.stack[0].u.image.image_id)
4983 (struct_it.image_id, struct image.id, struct image_cache.size)
4984 (struct image_cache.used, struct image_cache.ref_count):
4985 * gtkutil.c (update_frame_tool_bar):
4986 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4987 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4988 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4989 * nsmenu.m (update_frame_tool_bar):
4990 * xdisp.c (calc_pixel_width_or_height):
4991 * xfns.c (image_cache_refcount):
4992 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4993 on typical 64-bit hosts.
4994
4995 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4996 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4997 Omit unnecessary casts to int.
4998 (parse_image_spec): Check that integers fall into 'int' range
4999 when the callers expect that.
5000 (image_ascent): Redo ascent calculation to avoid int overflow.
5001 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5002 (lookup_image): Remove unnecessary tests.
5003 (xbm_image_p): Locals are now of int, not EMACS_INT,
5004 since parse_image_check makes sure they fit into int.
5005 (png_load, gif_load, svg_load_image):
5006 Prefer int to unsigned where either will do.
5007 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5008 old tiff_error_handler and tiff_warning_handler.
5009 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5010 stack buffer overflows. It uses only the features of vsnprintf
5011 that are common to both POSIX and native Microsoft.
5012 (tiff_error_handler, tiff_warning_handler): Use it.
5013 (tiff_load, gif_load, imagemagick_load_image):
5014 Don't assume :index value fits in 'int'.
5015 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5016 (imagemagick_load_image): Check that crop parameters fit into
5017 the integer types that MagickCropImage accepts. Don't assume
5018 Vimagemagick_render_type has a nonnegative value. Don't assume
5019 size_t fits in 'long'.
5020 (gs_load): Use printmax_t to print the widest integers possible.
5021 Check for integer overflow when computing image height and width.
5022
c11821d4
EZ
50232011-08-26 Eli Zaretskii <eliz@gnu.org>
5024
5025 * xdisp.c (redisplay_window): Don't force window start if point
5026 will be invisible in the resulting window. (Bug#9324)
5027
0c95fcf7
EZ
50282011-08-25 Eli Zaretskii <eliz@gnu.org>
5029
5030 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5031 the display spec is of the form `(space ...)'.
5032 (handle_display_spec): Return the value returned by
5033 handle_single_display_spec, not just 1 or zero.
5034 (handle_single_display_spec): If the display spec is of the form
5035 `(space ...)', and specifies display in the text area, return 2
5036 rather than 1.
fee65a97 5037 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5038 accurately, and prefer exact match for point under bidi.
5039 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5040
5041 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5042 into disp_prop; all users changed.
5043
5044 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5045 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5046 for the text covered by the display property.
5047
e4ed06f1
CY
50482011-08-25 Chong Yidong <cyd@stupidchicken.com>
5049
5050 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5051 Change return value to nil.
5052 (Frecord_buffer): Delete unused function.
5053
f67cdd7f
EZ
50542011-08-24 Eli Zaretskii <eliz@gnu.org>
5055
5980d4c6
EZ
5056 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5057 buffers, return left-to-right.
8610fe8b
EZ
5058 (set_cursor_from_row): Consider candidate row a win if its glyph
5059 represents a newline and point is on that newline. Fixes cursor
5060 positioning on the newline at EOL of R2L text within L2R
5061 paragraph, and vice versa.
5062 (try_cursor_movement): Check continued rows, in addition to
5063 continuation rows. Fixes unwarranted scroll when point enters a
5064 continued line of R2L text within an L2R paragraph, or vice versa.
5065 (cursor_row_p): Consider the case of point being equal to
5066 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5067 from the end of a short line to the beginning of a continued line
5068 of R2L text within L2R paragraph.
5069 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5070 composed characters.
5980d4c6 5071
f67cdd7f
EZ
5072 * bidi.c (bidi_check_type): Use xassert.
5073 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5074 members.
5075
bca633fb
EZ
50762011-08-23 Eli Zaretskii <eliz@gnu.org>
5077
5078 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5079 a character.
5080
4a5885a7
CY
50812011-08-23 Chong Yidong <cyd@stupidchicken.com>
5082
5083 * nsfont.m (ns_otf_to_script): Fix typo.
5084
0902a04e
KH
50852011-08-22 Kenichi Handa <handa@m17n.org>
5086
5087 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5088 extra slot even if the purpose is char-code-property-table.
5089
1a2e6670
EZ
50902011-08-23 Eli Zaretskii <eliz@gnu.org>
5091
8ddde651
EZ
5092 * xdisp.c (redisplay_window): When computing centering_position,
5093 account for the height of the header line. (Bug#8874)
5094
425cc014
EZ
5095 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5096 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5097 candidate is selected by the mouse, and that candidate has a
5098 composed character under the mouse.
5099
1a2e6670
EZ
5100 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5101 coordinates reported by pos-visible-in-window-p for a composed
5102 character in column zero.
5103
8b76d6f8
SM
51042011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5105
5106 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5107
dac347dd
EZ
51082011-08-22 Eli Zaretskii <eliz@gnu.org>
5109
5110 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5111 consider it a hit if to_charpos is anywhere in the range of the
5112 composed buffer positions.
5113
e013fb34
CY
51142011-08-22 Chong Yidong <cyd@stupidchicken.com>
5115
5116 * image.c (gif_load): Don't assume that each subimage has the same
5117 dimensions as the base image. Handle disposal method that is
5118 "undefined" by the gif spec (Bug#9335).
5119
bd1ba3e8
CY
51202011-08-20 Chong Yidong <cyd@stupidchicken.com>
5121
5122 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5123 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5124
54a1215b
EZ
51252011-08-19 Eli Zaretskii <eliz@gnu.org>
5126
823564e5
EZ
5127 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5128 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5129 from an Org mode buffer to a Speedbar frame.
5130
54a1215b
EZ
5131 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5132 a composition, take its buffer position from IT->cmp_it.charpos.
5133 Fixes cursor positioning at the beginning of a line that begins
5134 with a composed character.
5135
9778ebcc
EZ
51362011-08-18 Eli Zaretskii <eliz@gnu.org>
5137
0be6ee06
EZ
5138 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5139 character bidirectional type, use STRONG_L instead. Fixes crashes
5140 in a buffer produced by `describe-categories'.
5141
9778ebcc
EZ
5142 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5143 members before the level stack, so they would be saved and
5144 restored when copying iterator state. Fixes incorrect reordering
5145 around TABs covered by display properties.
5146
156bffbe
AS
51472011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5148
6b02f655 5149 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5150
72ad093b
CY
51512011-08-17 Chong Yidong <cyd@stupidchicken.com>
5152
5153 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5154 (internal_condition_case_2, internal_condition_case_n):
5155 Remove unnecessary aborts (Bug#9081).
72ad093b 5156
35774242
EZ
51572011-08-17 Eli Zaretskii <eliz@gnu.org>
5158
5159 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5160 has no `load' handler, try opening the file locally. (Bug#9311)
5161
db76dd85
KB
51622011-08-16 Ken Brown <kbrown@cornell.edu>
5163
5164 * gmalloc.c: Expand comment.
5165
b215eee5
EZ
51662011-08-16 Eli Zaretskii <eliz@gnu.org>
5167
5168 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5169 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5170
a4579d33
KB
51712011-08-16 Ken Brown <kbrown@cornell.edu>
5172
5173 Fix memory allocation problems in Cygwin build (Bug#9273).
5174
5175 * unexcw.c ( __malloc_initialized): Declare external variable.
5176 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5177
8b76d6f8
SM
5178 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5179 New variables.
a4579d33
KB
5180 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5181 dumped emacs.
5182 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5183 in the static heap.
5184 [CYGWIN] (special_realloc): New function.
5185 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5186 requests to realloc storage in the static heap.
5187
3ebec551
PE
51882011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5189
5190 * bidi.c (bidi_initialize): Remove unused local.
5191
9fd8be00
EZ
51922011-08-15 Eli Zaretskii <eliz@gnu.org>
5193
6b02f655
SM
5194 * bidimirror.h:
5195 * biditype.h: Remove file.
5196 * makefile.w32-in ($(BLD)/bidi.$(O)):
5197 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5198
5199 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5200
5201 * chartab.c: Improve commentary for the uniprop_table API.
5202
32413314
EZ
5203 * bidi.c (bidi_paragraph_init): Support zero value of
5204 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5205 (bidi_initialize): Use uniprop_table instead of including
5206 biditype.h and bidimirror.h.
32413314 5207
9fd8be00
EZ
5208 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5209 coordinates of the iterator when restoring from ppos_it.
5210 (Bug#9296)
5211
5cf2b69b
KH
52122011-08-14 Kenichi Handa <handa@m17n.org>
5213
5214 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5215 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5216
daf17d00
EZ
52172011-08-14 Eli Zaretskii <eliz@gnu.org>
5218
5219 * xdisp.c (move_it_in_display_line_to): Don't invoke
5220 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5221 ppos_it. Fixes vertical cursor motion when line beginning is
5222 covered by an image. (Bug#9296)
5223
08e3161a
JD
52242011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5225
5226 * nsterm.h (ns_run_ascript): Declare.
5227 (NSAPP_DATA2_RUNASSCRIPT): Define.
5228
5229 * nsfns.m (as_script, as_result, as_status): New static variables.
5230 (ns_run_ascript): New function.
5e617bc2 5231 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5232 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5233 the event loop. Get status from as_status (Bug#7276).
5234
5235 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5236 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5237 the event loop (Bug#7276).
5238
a3720aa2
AS
52392011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5240
5241 * gnutls.c (QCgnutls_bootprop_priority)
5242 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5243 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5244 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5245 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5246 (QCgnutls_bootprop_verify_hostname_error)
5247 (QCgnutls_bootprop_callbacks_verify): Rename from
5248 Qgnutls_bootprop_..., all uses changed.
5249
5250 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5251 uses changed.
5252
0a0d27fb
PE
52532011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5254
19d5c50c
PE
5255 * xfaces.c (Qframe_set_background_mode): Now static.
5256 * dispextern.h (Qframe_set_background_mode): Remove decl.
5257
0a0d27fb
PE
5258 * process.c (Fnetwork_interface_info): Declare local only if needed.
5259
377538cb
JD
52602011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5261
5262 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5263 (Fnetwork_interface_list): Allocate in increments of bytes instead
5264 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5265 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5266 sockaddr.
5267 (struct ifflag_def): notrailers is smart on OSX.
5268 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5269 Get hardware address with getifaddrs if available.
5270
08fff70c
EZ
52712011-08-12 Eli Zaretskii <eliz@gnu.org>
5272
5273 * xdisp.c (iterate_out_of_display_property): xassert that
5274 IT->position is set to within IT->object's boundaries. Break from
5275 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5276 when IT->position is set up wrongly due to some bug.
5277 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5278 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5279 entry. Force push_it to save on the stack the current
5280 buffer/string position, to be restored by pop_it. Fix flags in
5281 the iterator structure wrt the object coming from a display
5282 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5283 properties. (Bug#9284)
5284
7be1c708 52852011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5286
7be1c708
CY
5287 * fontset.c (fontset_get_font_group): Add proper type checks.
5288 (Bug#9172)
aac0c6e3 5289
7be1c708 52902011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5291
7be1c708
CY
5292 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5293 and LC_VERSION_MIN_MACOSX.
5294 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5295 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5296
97bb72a6
EZ
52972011-08-08 Eli Zaretskii <eliz@gnu.org>
5298
5299 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5300 no-display-properties-and-no-overlays under bidi display.
5301 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5302 properties and overlays.
97bb72a6 5303
d5617611
CY
53042011-08-08 Chong Yidong <cyd@stupidchicken.com>
5305
37e11a63
CY
5306 * editfns.c (Fset_time_zone_rule): Document relationship with the
5307 setenv function.
5308
d5617611
CY
5309 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5310 the font entity extracted from the cache (Bug#8109).
5311
58872834
CY
53122011-08-07 Chong Yidong <cyd@stupidchicken.com>
5313
5314 * composite.c (autocmp_chars): Don't reset point. That is done by
5315 restore_point_unwind (Bug#5984).
5316
75bfc667
JL
53172011-08-07 Juri Linkov <juri@jurta.org>
5318
5319 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5320 to show the arg `TIME' instead of `TIMEVAL'.
5321
d1410150
EZ
53222011-08-06 Eli Zaretskii <eliz@gnu.org>
5323
5324 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5325 display property strides EOL and includes a newline, as in
5326 longlines-mode. (Bug#9254)
75b771e4
EZ
5327 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5328 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5329
5330 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5331 is non-zero, even if the data buffer is NULL. Fixes a crash in
5332 vertical-motion with longlines-mode. (Bug#9254)
5333
35928349
EZ
53342011-08-05 Eli Zaretskii <eliz@gnu.org>
5335
ec7cc85b
EZ
5336 * bidi.c <bidi_cache_total_alloc>: Now static.
5337 (bidi_initialize): Initialize bidi_cache_total_alloc.
5338
8b76d6f8 5339 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5340 cache. (Bug#9221)
5341
5342 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5343 amount allocated this far in `bidi_cache_total_alloc'.
5344 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5345 non-zero, only free the data buffer without restoring the cache
5346 contents. All callers changed.
5347
5348 * dispextern.h (bidi_unshelve_cache): Update prototype.
5349
5350 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5351 (move_it_in_display_line, move_it_to)
5352 (move_it_vertically_backward, move_it_by_lines): Replace the call
5353 to xfree to an equivalent call to bidi_unshelve_cache.
5354 (move_it_in_display_line_to): Fix logic of returning
412b6358 5355 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5356
e2e2423b
EZ
53572011-08-05 Eli Zaretskii <eliz@gnu.org>
5358
5359 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5360 came from a string character with a `cursor' property. (Bug#9229)
5361
ae9e757a
JD
53622011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5363
5364 * Makefile.in (LIB_PTHREAD): New variable.
5365 (LIBES): Add LIB_PTHREAD (Bug#9216).
5366
5367 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5368 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5369
213bd7f2
AS
53702011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5371
6b02f655 5372 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5373
99aaf75f
JD
53742011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5375
5376 * xterm.c (x_find_topmost_parent): New function.
5377 (x_set_frame_alpha): Find topmost parent window with
5378 x_find_topmost_parent and set the property there also (bug#9181).
5379 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5380
c74e9d86
PE
53812011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5382
5383 * callproc.c (Fcall_process): Avoid vfork clobbering
5384 the local vars buffer, coding_systems, current_dir.
5385
640c8776
SM
53862011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5387
5388 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5389
f26d0e4c
PE
53902011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5391
8a10d76c
PE
5392 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5393 so that it is not optimized away.
5394
f26d0e4c
PE
5395 * xdisp.c (compute_display_string_pos): Remove unused local.
5396
55439c61
EZ
53972011-08-02 Eli Zaretskii <eliz@gnu.org>
5398
5399 Fix slow cursor motion and scrolling in large buffers with
5400 selective display, like Org Mode buffers. (Bug#9218)
5401
5402 * dispextern.h (struct bidi_it): New member disp_prop_p.
5403
5404 * xdisp.c: Remove one-slot cache of display string positions.
5405 (compute_display_string_pos): Accept an additional argument
5e617bc2 5406 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5407 for a display string or property. If found, set DISP_PROP_P
5408 non-zero.
5409
5410 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5411 DISP_PROP_P, and pass it to compute_display_string_pos.
5412 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5413 non-zero. All callers of bidi_fetch_char changed.
5414
fb33fa43
SM
54152011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5416
5417 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5418
b099e063
DM
54192010-12-03 Don March <don@ohspite.net>
5420
5421 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5422 last character M-[char] is translated to ESC [char] (bug#7541).
5423
5cc7f7af
KH
54242011-08-02 Kenichi Handa <handa@m17n.org>
5425
d0fffa3f 5426 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5427
5428 * chartab.c (uniprop_table): Make it non-static.
5429
525d5e6e
EZ
54302011-08-01 Eli Zaretskii <eliz@gnu.org>
5431
5432 * xdisp.c (forward_to_next_line_start): Accept additional argument
5433 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5434 on the newline.
5435 (reseat_at_next_visible_line_start): Use the bidi iterator state
5436 returned by forward_to_next_line_start to restore the state of
5437 it->bidi_it after backing up to previous newline. (Bug#9212)
5438
31011111
AS
54392011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5440
5441 * regex.c (re_comp): Protoize.
5442 (re_exec): Fix return type.
5443 (regexec): Fix type of `ret'. (Bug#9203)
5444
476371c4
PE
54452011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5446
e5d76069
PE
5447 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5448 This is needed if max-image-size is a floating-point number.
5449
9a79b20c
AS
54502011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5451
5452 * print.c (print_object): Print empty symbol as ##.
5453
5454 * lread.c (read1): Read ## as empty symbol.
5455
d8c2fa78
AA
54562011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5457
5458 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5459 setting frame foreground color (Bug#9175).
5460 (x_set_background_color): Likewise.
5461
ffe57a7a
AA
5462 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5463 contents (Bug#9176).
5464 (EmacsTooltip -init): Remove bezels and add shadows to
5465 tooltip windows.
5466
bf3492a5
AA
5467 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5468 or scroll bar (Bug#8470).
5469
d55e9c53
AA
5470 * nsfont.m (nsfont_open): Remove assignment to voffset and
5471 unnecessary vars hshink, expand, hd, full_height, min_height.
5472 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5473
5474 * nsterm.h (nsfont_info): Remove voffset field.
5475
d8c2fa78 54762011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5477
5478 Implement strike-through and overline on NextStep (Bug#8863).
5479
5480 * nsfont.m (nsfont_open): Use underline position provided by font,
5481 instead of hard-coded value of 2.
5482 (nsfont_draw): Call ns_draw_text_decoration instead.
5483
5484 * nsterm.h: Add declaration for ns_draw_text_decoration.
5485
5486 * nsterm.m (ns_draw_text_decoration): New function for drawing
5487 underline, overline, and strike-through.
5488 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5489 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5490 accommodate underlining, etc.
4843aac3 5491
4cc60b9b
EZ
54922011-07-28 Eli Zaretskii <eliz@gnu.org>
5493
bc7ece87
EZ
5494 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5495 default.
4cc60b9b 5496
476371c4
PE
54972011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5498
66606eea
PE
5499 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5500 Without this fix, if a signal arrives just after memory fills up,
5501 'malloc' might be invoked reentrantly.
5502
476371c4
PE
5503 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5504 In other words, assume that every image size is allowed, on non-X
5505 hosts. This assumption is probably wrong, but it lets Emacs compile.
5506
f3fcc40d
AS
55072011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5508
5509 * regex.c (re_iswctype): Convert return values to boolean.
5510
350c992f
EZ
55112011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5512
5513 * xdisp.c (compute_display_string_pos): Don't use cached display
5514 string position if the buffer had its restriction changed.
5515 (Bug#9184)
5516
5266b4bb
PE
55172011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5518
5519 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5520
2573a837 55212011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5522
41f55ccd 5523 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5524
39e378da
PE
5525 * bidi.c: Integer size and overflow fixes.
5526 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5527 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5528 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5529 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5530 (bidi_find_other_level_edge):
5531 Use ptrdiff_t instead of EMACS_INT where either will do.
5532 This works better on 32-bit hosts configured --with-wide-int.
5533 (bidi_cache_ensure_space): Check for size-calculation overflow.
5534 Use % rather than repeated addition, for better worst-case speed.
5535 Don't set bidi_cache_size until after xrealloc returns, because it
5536 might not return.
5537 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5538 (bidi_cache_ensure_space): Also check that the bidi cache size
5539 does not exceed that of the largest Lisp string or buffer. See Eli
5540 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5541
5e927815
PE
5542 * alloc.c (__malloc_size_t): Remove.
5543 All uses replaced by size_t. See Andreas Schwab's note
5544 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5545
ca4aa935
PE
5546 * image.c: Improve checking for integer overflow.
5547 (check_image_size): Assume that f is nonnull, since
5548 it is always nonnull in practice. This is one less thing to
5549 worry about when checking for integer overflow later.
5550 (x_check_image_size): New function, which checks for integer
5551 overflow issues inside X.
5552 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5553 This removes the need for a memory_full check.
5554 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5555 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5556 (xbm_read_bitmap_data): Change locals back to 'int', since
5557 their values must fit in 'int'.
5558 (xpm_load_image, png_load, tiff_load):
5559 Invoke x_create_x_image_and_pixmap earlier,
5560 to avoid much needless work if the image is too large.
5561 (tiff_load): Treat overly large images as if
5562 x_create_x_image_and_pixmap failed, not as malloc failures.
5563 (gs_load): Use x_check_image_size.
5564
5f8f9cc2
PE
5565 * gtkutil.c: Omit integer casts.
5566 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5567 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5568
5adf60bc
PE
5569 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5570
c8907a93
PE
5571 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5572 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5573 would wrongly return t on a 64-bit host.
5574
e3c25c68
PE
5575 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5576 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5577 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5578 and therefore cause GCC to emit a bogus diagnostic in some cases.
5579
3f791afe
PE
5580 * image.c: Integer signedness and overflow and related fixes.
5581 This is not an exhaustive set of fixes, but it's time to
5582 record what I've got.
5583 (lookup_pixel_color, check_image_size): Remove redundant decls.
5584 (check_image_size): Don't assume that arbitrary EMACS_INT values
5585 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5586 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5587 (tiff_load, imagemagick_load_image):
5588 Check for overflow in size calculations.
5589 (x_create_x_image_and_pixmap): Remove unnecessary test for
5590 xmalloc returning NULL; that can't happen.
5591 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5592 (xpm_color_bucket): Use better integer hashing function.
5593 (xpm_cache_color): Don't possibly over-allocate memory.
5594 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5595 (gif_memory_source):
5596 Use ptrdiff_t, not int or size_t, to record sizes.
5597 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5598 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5599 either works, as we prefer signed integers.
5600 (tiff_read_from_memory, tiff_write_from_memory):
5601 Return tsize_t, not size_t, since that's what the TIFF API wants.
5602 (tiff_read_from_memory): Don't fail simply because the read would
5603 go past EOF; instead, return a short read.
5604 (tiff_load): Omit no-longer-needed casts.
5605 (Fimagemagick_types): Don't assume size fits into 'int'.
5606
3cc5a532
PE
5607 Improve hashing quality when configured --with-wide-int.
5608 * fns.c (hash_string): New function, taken from sxhash_string.
5609 Do not discard information about ASCII character case; this
5610 discarding is no longer needed.
5611 (sxhash-string): Use it. Change sig to match it. Caller changed.
5612 * lisp.h: Declare it.
5613 * lread.c (hash_string): Remove, since we now use fns.c's version.
5614 The fns.c version returns a wider integer if --with-wide-int is
5615 specified, so this should help the quality of the hashing a bit.
5616
b312a492
PE
5617 * emacs.c: Integer overflow minor fix.
5618 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5619 Define only if GNU_LINUX.
5620 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5621
dfd153ae
PE
5622 * dispnew.c: Integer signedness and overflow fixes.
5623 Remove unnecessary forward decls, that were a maintenance hassle.
5624 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5625 All uses changed.
5626 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5627 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5628 (prepare_desired_row, line_draw_cost):
5629 Use int, not unsigned, where either works.
5630 (save_current_matrix, restore_current_matrix):
5631 Use ptrdiff_t, not size_t, where either works.
5632 (init_display): Check for overflow more accurately, and without
5633 relying on undefined behavior.
5634
a81d11a3
PE
5635 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5636 Remove, replacing with the new symbols in lisp.h. All uses changed.
5637 * fileio.c (make_temp_name):
5638 * filelock.c (lock_file_1, lock_file):
5639 * xdisp.c (message_dolog):
5640 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5641 Use pMd etc. instead.
5642 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5643 replacing the pWIDE etc. symbols removed from editfns.c.
5644
3300e6fd
PE
5645 * keyboard.h (num_input_events): Now uintmax_t.
5646 This is (very slightly) less likely to mess up due to wraparound.
5647 All uses changed.
5648
fd05c7e9
PE
5649 * buffer.c: Integer signedness fixes.
5650 (alloc_buffer_text, enlarge_buffer_text):
5651 Use ptrdiff_t rather than size_t when either will do, as we prefer
5652 signed integers.
5653
903fe15d
PE
5654 * alloc.c: Integer signedness and overflow fixes.
5655 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5656 (__malloc_size_t): Default to size_t, not to int.
5657 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5658 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5659 Prefer ptrdiff_t to size_t when either would do, as we prefer
5660 signed integers.
5661 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5662 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5663 Now const. Initialize with values that are in range even if char
5664 is signed.
5665 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5666 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5667 These functions do the right thing with sizes > 2**32.
5668 (check_depth): Now ptrdiff_t, not int.
5669 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5670 Adjust to new way of storing sizes. Check for size overflow bugs
5671 in rest of code.
5672 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5673 slightly wrong anyway, as it missed one instance of
5674 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5675 (refill_memory_reserve): Omit needless cast to size_t.
5676 (mark_object_loop_halt): Mark as externally visible.
5677
ac82cc6a
PE
5678 * xselect.c: Integer signedness and overflow fixes.
5679 (Fx_register_dnd_atom, x_handle_dnd_message):
5680 Use ptrdiff_t, not size_t, since we prefer signed.
5681 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5682 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5683 x_dnd_atoms_size and x_dnd_atoms_length.
5684
c2d1e36d
PE
5685 * doprnt.c: Prefer signed to unsigned when either works.
5686 * eval.c (verror):
5687 * doprnt.c (doprnt):
5688 * lisp.h (doprnt):
5689 * xdisp.c (vmessage):
5690 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5691 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5692 prefer signed arithmetic to avoid comparison confusion.
5693 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5694 but is a bit tricky.
5695
0e926e56
PE
5696 Assume freestanding C89 headers, string.h, stdlib.h.
5697 * data.c, doprnt.c, floatfns.c, print.c:
5698 Include float.h unconditionally.
5699 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5700 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5701 * regex.c: Likewise for stddef.h, string.h.
5702 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5703 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5704 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5705 (STDC_HEADERS): Remove obsolete defines.
5706 * sysdep.c: Include limits.h unconditionally.
5707
9cfdb3ec
PE
5708 Assume support for memcmp, memcpy, memmove, memset.
5709 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5710 * regex.c (memcmp, memcpy):
5711 Remove; we assume C89 now.
5712
5713 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5714 (__malloc_safe_bcopy): Remove; no longer needed.
5715
cf950e6b 5716 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
5717 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5718 well either way, and we prefer signed to unsigned.
5719
dbf38e02
LMI
57202011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5721
5722 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5723 closes the connection while we're reading (bug#9182).
5724
d6f0886c 57252011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 5726
d6f0886c
JD
5727 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5728 are specified (Bug#9168).
24e0f6b1 5729
2eb1f9e6
PE
57302011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5731
5732 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5733 Found by GCC static checking and --with-wide-int on a 32-bit host.
5734
22381272 57352011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
5736
5737 * xdisp.c (compute_display_string_pos): Fix logic of caching
5738 previous display string position. Initialize cached_prev_pos to
5739 -1. Fixes slow-down at the beginning of a buffer.
5740
f25e39b4
EZ
57412011-07-24 Eli Zaretskii <eliz@gnu.org>
5742
5743 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5744 for attrs[LFACE_FONTSET_INDEX].
5745
04c4b52e
PE
57462011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5747
5748 * xml.c (parse_region): Remove unused local
5749 that was recently introduced.
5750
c1734fbd
EZ
57512011-07-23 Eli Zaretskii <eliz@gnu.org>
5752
be18c5a5
EZ
5753 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5754 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5755
c1734fbd
EZ
5756 * xdisp.c (move_it_in_display_line_to): Record the best matching
5757 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
5758 exit if none of the characters scanned was an exact match.
5759 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
5760 when exact match is impossible due to invisible text, and the
5761 lines are truncated.
5762
a258d627
JD
57632011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5764
5765 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5766 for OSX >= 10.7.
5767
b6d5a689
EZ
57682011-07-22 Eli Zaretskii <eliz@gnu.org>
5769
0f74f785
EZ
5770 Fix a significant slow-down of cursor motion with C-n, C-p,
5771 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5772 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 5773 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
5774 (next_element_from_buffer): Call compute_stop_pos_backwards to
5775 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
5776 base_level_stop.
5777 (reseat): Don't look for prev_stop, as that could mean a very long
5778 run.
5779 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5780 <cached_disp_overlay_modiff>: Cache for last found display string
5781 position.
551918c1 5782 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
5783 about the same buffer in the same area of character positions, and
5784 the buffer wasn't changed since the time the display string
5785 position was cached.
551918c1 5786
b2d0c91a
EZ
57872011-07-22 Eli Zaretskii <eliz@gnu.org>
5788
5789 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5790 is an integer, which is important for empty lines. (Bug#9149)
5791
043604ee
CY
57922011-07-22 Chong Yidong <cyd@stupidchicken.com>
5793
5794 * frame.c (Fmodify_frame_parameters): In tty case, update the
5795 default face if necessary (Bug#4238).
5796
da4adb04
CY
57972011-07-21 Chong Yidong <cyd@stupidchicken.com>
5798
5799 * editfns.c (Fstring_to_char): No need to explain what a character
5800 is in the docstring (Bug#6576).
5801
9abd0532
LMI
58022011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5803
5804 * xml.c (parse_region): Make sure we always return a tree.
5805
36881d16
HK
58062011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5807
5808 * xml.c (parse_region): If a document contains only comments,
5809 return that, too.
5810
1e98674d
LMI
58112011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5812
5813 * xml.c (make_dom): Return comments, too.
5814
590bd467
PE
58152011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5816
5817 Port to OpenBSD.
5818 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5819 and the surrounding thread.
5820 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5821 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5822 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5823 timer goes off.
5824 * s/openbsd.h (BROKEN_SIGIO): Define.
5825 * unexelf.c (unexec) [__OpenBSD__]:
5826 Don't update the .mdebug section of the Alpha COFF symbol table.
5827
f41628b2
LMI
58282011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5829
5830 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5831 (bug#8460).
5832
b59b67c5
PE
58332011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5834
15e3a074
PE
5835 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5836 This fixes some race conditions on the permissions of any newly
5837 created file.
5838
41bed37d
PE
5839 * alloc.c (valid_pointer_p): Use pipe, not open.
5840 This fixes some permissions issues when debugging.
5841
b59b67c5
PE
5842 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5843 If fchown fails to set both uid and gid, try to set just gid,
5844 as that is sometimes allowed. Adjust the file's mode to eliminate
5845 setuid or setgid bits that are inappropriate if fchown fails.
5846
925a6be7
SM
58472011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5848
5849 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5850 to compare Lisp_Objects.
5851 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5852 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5853 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5854
52968808
AS
58552011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5856
0a6a104b
AS
5857 * lread.c (read_integer): Unread even EOF character.
5858 (read1): Likewise. Properly record start position of symbol.
5859
52968808
AS
5860 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5861 symbol character follows.
5862
9e381cdd
PE
58632011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5864
5865 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5866 This works around a problem with the previous change to Fcopy_file.
5867 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5868 and without this change, GCC might complain about discarding
5869 fchown's return value.
5870
b5641435
JB
58712011-07-16 Juanma Barranquero <lekktu@gmail.com>
5872
5873 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5874
a8031457
PE
58752011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5876
5877 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5878
dd889327
LMI
58792011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5880
750c33f7
LMI
5881 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5882 it's used from the C level.
5883
dd889327
LMI
5884 * process.c: Use the same condition for POLL_FOR_INPUT in both
5885 keyboard.c and process.c (bug#1858).
5886
87e86684
LM
58872011-07-09 Lawrence Mitchell <wence@gmx.li>
5888
5889 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5890 (Fgnutls_boot): Use it.
5891
64348f40
AS
58922011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5893
5894 * doc.c (Fsubstitute_command_keys): Revert last change.
5895
1d698799
LMI
58962011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5897
f863868c
LMI
5898 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5899 quotes the next character, and doesn't affect other longer
5900 sequences (bug#8935).
5901
1d698799
LMI
5902 * lread.c (syms_of_lread): Clarify that is isn't only
5903 `eval-buffer' and `eval-defun' that's affected by
5904 `lexical-binding' (bug#8460).
5905
aa4b6df6
EZ
59062011-07-15 Eli Zaretskii <eliz@gnu.org>
5907
5908 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 5909 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 5910
5d856da6
PE
59112011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5912
ad6042bb
PE
5913 Fix minor problems found by static checking.
5914 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5915 (elsz): Now a signed constant, not a size_t var. We prefer signed
5916 types to unsigned, to avoid integer comparison confusion. Without
5917 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5918 "cannot optimize loop, the loop counter may overflow", a symptom
5919 of the confusion.
f00bbb22 5920 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
5921 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5922
6468f31c
LMI
59232011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5924
49080b10
LMI
5925 * search.c (Fre_search_backward): Mention `case-fold-search' in
5926 all the re_search_* functions (bug#8138).
5927
6468f31c
LMI
5928 * keyboard.c (Fopen_dribble_file): Document when the file is
5929 closed (bug#8056).
5930
c965adc5
EZ
59312011-07-14 Eli Zaretskii <eliz@gnu.org>
5932
df9733bf
EZ
5933 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5934 bidi_cache_idx.
5935
0bb23927
EZ
5936 Support bidi reordering of display and overlay strings.
5937 * xdisp.c (compute_display_string_pos)
5938 (compute_display_string_end): Accept additional argument STRING.
5939 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5940 (reseat_to_string): Initialize bidi_it->string.s and
5941 bidi_it->string.schars.
5942 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
5943 NULL (avoids a crash in bidi_paragraph_init).
5944 Initialize itb.string.lstring.
0bb23927
EZ
5945 (init_iterator): Call bidi_init_it only of a valid
5946 buffer position was specified. Initialize paragraph_embedding to
5947 L2R.
5948 (reseat_to_string): Initialize the bidi iterator.
5949 (display_string): If we need to ignore text properties of
5950 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5951 original value of -1 will not work with bidi.)
5952 (compute_display_string_pos): First arg is now struct
5953 `text_pos *'; all callers changed. Support display properties on
5954 Lisp strings.
5955 (compute_display_string_end): Support display properties on Lisp
5956 strings.
5957 (init_iterator, reseat_1, reseat_to_string): Initialize the
5958 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5959 when iterating on a string not from display properties).
640c8776
SM
5960 (compute_display_string_pos, compute_display_string_end):
5961 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
5962 arrow keys.
5963 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
5964 base_level_stop; instead, set base_level_stop to BEGV.
5965 Fixes crashes in vertical-motion.
0bb23927
EZ
5966 (next_element_from_buffer): Improve commentary for when
5967 the iterator is before prev_stop.
5968 (init_iterator): Initialize bidi_p from the default value of
5969 bidi-display-reordering, not from buffer-local value. Use the
5970 buffer-local value only if initializing for buffer iteration.
5971 (handle_invisible_prop): Support invisible properties on strings
5972 that are being bidi-reordered.
5973 (set_iterator_to_next): Support bidi reordering of C strings and
5974 Lisp strings.
5975 (next_element_from_string): Support bidi reordering of Lisp
5976 strings.
5977 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
5978 (display_string): Support display of R2L glyph rows.
5979 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
5980 (init_iterator): Don't initialize it->bidi_p for strings
5981 here.
5982 (reseat_to_string): Initialize it->bidi_p for strings here.
5983 (next_element_from_string, next_element_from_c_string)
5984 (next_element_from_buffer): Add xassert's for correspondence
5985 between IT's object being iterated and it->bidi_it.string
5986 structure.
5987 (face_before_or_after_it_pos): Support bidi iteration.
5988 (next_element_from_c_string): Handle the case of the first string
5989 character that is not the first one in the visual order.
5990 (get_visually_first_element): New function, refactored from common
5991 parts of next_element_from_buffer, next_element_from_string, and
5992 next_element_from_c_string.
5993 (tool_bar_lines_needed, redisplay_tool_bar)
5994 (display_menu_bar): Force left-to-right direction. Add a FIXME
5995 comment for making that be controlled by a user option.
5996 (push_it, pop_it): Save and restore the state of the
5997 bidi iterator. Save and restore the bidi_p flag.
5998 (pop_it): Iterate out of display property for string iteration as
5999 well.
6000 (iterate_out_of_display_property): Support iteration over strings.
6001 (handle_single_display_spec): Set up it->bidi_it for iteration
6002 over a display string, and call bidi_init_it.
6003 (handle_single_display_spec, next_overlay_string)
6004 (get_overlay_strings_1, push_display_prop): Set up the bidi
6005 iterator for displaying display or overlay strings.
6006 (forward_to_next_line_start): Don't use the shortcut if
6007 bidi-iterating.
6008 (back_to_previous_visible_line_start): If handle_display_prop
6009 pushed the iterator stack, restore the internal state of the bidi
6010 iterator by calling bidi_pop_it same number of times.
6011 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6012 and we are bidi-iterating, don't decrement the iterator position;
6013 instead, set the first_elt flag in the bidi iterator, to produce
6014 the same effect.
6015 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6016 (push_display_prop): xassert that we are iterating a buffer.
6017 (push_it, pop_it): Save and restore paragraph_embedding member.
6018 (handle_single_display_spec, next_overlay_string)
6019 (get_overlay_strings_1, reseat_1, reseat_to_string)
6020 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6021 correctly. Don't assume unibyte strings are not bidi-reordered.
6022 (compute_display_string_pos)
6023 (compute_display_string_end): Fix handling the case of C string.
6024 (push_it, pop_it): Save and restore from_disp_prop_p.
6025 (handle_single_display_spec, push_display_prop): Set the
6026 from_disp_prop_p flag.
6027 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6028 (pop_it): Call iterate_out_of_display_property only if we are
6029 popping after iteration over a string that came from a display
6030 property. Fix a typo in popping stretch info. Add an assertion
6031 for verifying that the iterator position is in sync with the bidi
6032 iterator.
6033 (handle_single_display_spec, get_overlay_strings_1)
6034 (push_display_prop): Fix initialization of paragraph direction for
6035 string when that of the parent object is not yet determined.
6036 (reseat_1): Call bidi_init_it to resync the bidi
6037 iterator with IT's position. (Bug#7616)
6038 (find_row_edges): If ROW->start.pos gives position
6039 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6040 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6041 Reset the from_disp_prop_p flag.
6042 (SAVE_IT, RESTORE_IT): New macros.
6043 (pos_visible_p, face_before_or_after_it_pos)
6044 (back_to_previous_visible_line_start)
6045 (move_it_in_display_line_to, move_it_in_display_line)
6046 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6047 (try_scrolling, redisplay_window, display_line): Use them when
6048 saving a temporary copy of the iterator and restoring it back.
6049 (back_to_previous_visible_line_start, reseat_1)
6050 (init_iterator): Empty the bidi cache "stack".
6051 (move_it_in_display_line_to): If iterator ended up at
6052 EOL, but we never saw any buffer positions smaller than
6053 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6054 motion in bidi-reordered lines.
6055 (move_it_in_display_line_to): Record prev_method and prev_pos
6056 immediately before the call to set_iterator_to_next. Fixes cursor
6057 motion in bidi-reordered lines with stretch glyphs and strings
6058 displayed in margins. (Bug#8133) (Bug#8867)
6059 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6060 TO_CHARPOS.
640c8776
SM
6061 (pos_visible_p): Support positions in bidi-reordered lines.
6062 Save and restore bidi cache.
0bb23927
EZ
6063
6064 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6065 (bidi_paragraph_info): Delete unused struct.
6066 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6067 (bidi_cache_start): New variable.
6068 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6069 to zero.
6070 (bidi_cache_fetch_state, bidi_cache_search)
6071 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6072 (bidi_cache_find, bidi_peek_at_next_level)
6073 (bidi_level_of_next_char, bidi_find_other_level_edge)
6074 (bidi_move_to_visually_next): Compare cache index with
6075 bidi_cache_start rather than with zero.
6076 (bidi_fetch_char): Accept new argument STRING; all callers
6077 changed. Support iteration over a string. Support strings with
6078 display properties. Support unibyte strings. Fix the type of
6079 `len' according to what STRING_CHAR_AND_LENGTH expects.
6080 (bidi_paragraph_init, bidi_resolve_explicit_1)
6081 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6082 (bidi_level_of_next_char, bidi_move_to_visually_next):
6083 Support iteration over a string.
0bb23927
EZ
6084 (bidi_set_sor_type, bidi_resolve_explicit_1)
6085 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6086 can now be zero (for strings); special values 0 and -1 were
6087 changed to -1 and -2, respectively.
6088 (bidi_char_at_pos): New function.
6089 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6090 Call it instead of FETCH_MULTIBYTE_CHAR.
6091 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6092 initialized to valid values.
6093 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6094 values.
6095 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6096 the test for valid cached positions. Fix the logic for looking up
6097 the sentinel state in the cache. GCPRO the Lisp string we are
6098 iterating.
6099 (bidi_push_it, bidi_pop_it): New functions.
6100 (bidi_initialize): Initialize the bidi cache start stack pointer.
6101 (bidi_cache_ensure_space): New function, refactored from part of
6102 bidi_cache_iterator_state. Don't assume the required size is just
6103 one BIDI_CACHE_CHUNK away.
6104 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6105 (bidi_count_bytes, bidi_char_at_pos): New functions.
6106 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6107 always valid if bidi_cache_idx is valid.
6108 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6109 is valid if it's going to be used.
6110 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6111 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6112 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6113 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6114 (bidi_find_other_level_edge, bidi_cache_start_stack):
6115 All variables related to cache indices are now EMACS_INT.
c965adc5 6116
0bb23927
EZ
6117 * dispextern.h (struct bidi_string_data): New structure.
6118 (struct bidi_it): New member `string'. Make flag members be 1-bit
6119 fields, and put them last in the struct.
640c8776
SM
6120 (compute_display_string_pos, compute_display_string_end):
6121 Update prototypes.
0bb23927
EZ
6122 (bidi_push_it, bidi_pop_it): Add prototypes.
6123 (struct iterator_stack_entry): New members bidi_p,
6124 paragraph_embedding, and from_disp_prop_p.
6125 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6126 (bidi_shelve_cache, bidi_unshelve_cache):
6127 Declare prototypes.
0bb23927
EZ
6128
6129 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6130 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6131 and vector-like objects.
6132
6133 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6134 cache around display iteration.
6135
6136 * window.c (Fwindow_end, window_scroll_pixel_based)
6137 (displayed_window_lines, Frecenter): Save and restore the bidi
6138 cache around display iteration.
6139
3bbd2265
LMI
61402011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6141
6142 * editfns.c (Fdelete_region): Clarify the use of the named
6143 parameters (bug#6788).
6144
adc47434
MR
61452011-07-14 Martin Rudalics <rudalics@gmx.at>
6146
6147 * indent.c (Fvertical_motion): Set and restore w->pointm when
6148 saving and restoring the window's buffer (Bug#9006).
6149
837c31f8
LMI
61502011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6151
6152 * editfns.c (Fstring_to_char): Clarify just what is returned
6153 (bug#6576). Text by Eli Zaretskii.
6154
ac389d0c
JB
61552011-07-13 Juanma Barranquero <lekktu@gmail.com>
6156
6157 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6158
0be0ce47
EZ
61592011-07-13 Eli Zaretskii <eliz@gnu.org>
6160
6161 * buffer.c (mmap_find): Fix a typo.
6162
cd18e7e3
JB
61632011-07-13 Johan Bockgård <bojohan@gnu.org>
6164
6165 Fix execution of x selection hooks.
6166 * xselect.c (Qx_lost_selection_functions)
6167 (Qx_sent_selection_functions): New vars.
6168 (syms_of_xselect): DEFSYM them.
6169 (x_handle_selection_request): Pass Qx_sent_selection_functions
6170 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6171 (x_handle_selection_clear,x_clear_frame_selections):
6172 Pass Qx_lost_selection_functions rather than
6173 Vx_lost_selection_functions to Frun_hook_with_args.
6174
47ea7f44
PE
61752011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6176
ac389d0c 6177 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6178 The old code sometimes used this field without initializing it.
6179
47ea7f44
PE
6180 * alloc.c (gc_sweep): Don't read past end of array.
6181 In theory, the old code could also have corrupted Emacs internals,
6182 though it'd be very unlikely.
6183
bc985c87
AS
61842011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6185
6186 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6187 argument. (Bug#4026)
bc985c87 6188
0cf34688
LMI
61892011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6190
b3dadd76
LMI
6191 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6192 key" (bug#4257).
6193
0cf34688
LMI
6194 * window.c (Fset_window_start): Doc fix (bug#4199).
6195 (Fset_window_hscroll): Ditto.
6196
270768cd
PE
61972011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6198
077e3dda 6199 Fix minor new problems caught by GCC 4.6.1.
270768cd 6200 * term.c (init_tty): Remove unused local.
490011a6 6201 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6202 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6203 not used otherwise.
270768cd 6204
b1f58454
CY
62052011-07-12 Chong Yidong <cyd@stupidchicken.com>
6206
6207 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6208
22b9578d
LMI
62092011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6210
6e70ab07
LMI
6211 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6212 are the mini-buffer and the echo area (bug#3320).
6213
22b9578d
LMI
6214 * term.c (init_tty): Remove support for supdup, c10 and perq
6215 terminals, which are no longer supported (bug#1482).
6216
8974cc9f
JB
62172011-07-10 Johan Bockgård <bojohan@gnu.org>
6218
6219 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6220
a560d974
JD
62212011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6222
6223 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6224 for non-popups (Bug#3642).
6225
1dae0f0a
AS
62262011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6227
268c2c36 6228 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6229 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6230 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6231 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6232 * data.c (fmod): Likewise.
6233 * dispnew.c (swap_glyphs_in_rows): Likewise.
6234 * emacs.c (memory_warning_signal): Likewise.
6235 * floatfns.c (float_error): Likewise.
6236 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6237 (otf_open, font_otf_capability, generate_otf_features)
6238 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6239 Likewise.
6240 * image.c (pbm_read_file): Likewise.
6241 * indent.c (string_display_width): Likewise.
6242 * intervals.c (check_for_interval, search_for_interval)
6243 (inc_interval_count, count_intervals, root_interval)
6244 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6245 * lread.c (defalias): Likewise.
268c2c36 6246 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6247 * regex.c (set_image_of_range_1, set_image_of_range)
6248 (regex_grow_registers): Likewise.
6249 * sysdep.c (strerror): Likewise.
6250 * termcap.c (valid_filename_p, tprint, main): Likewise.
6251 * tparam.c (main): Likewise.
6252 * unexhp9k800.c (run_time_remap, save_data_space)
6253 (update_file_ptrs, read_header, write_header, calculate_checksum)
6254 (copy_file, copy_rest, display_header): Likewise.
6255 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6256 Likewise.
6257 * xdisp.c (check_it): Likewise.
6258 * xfaces.c (register_color, unregister_color, unregister_colors):
6259 Likewise.
6260 * xfns.c (print_fontset_result): Likewise.
6261 * xrdb.c (member, fatal, main): Likewise.
6262
99033785
PE
62632011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6264
6265 Fix minor problems found by static checking (Bug#9031).
6266 * chartab.c (char_table_set_range, map_sub_char_table):
6267 Remove unused locals.
6268 (uniprop_table): Now static.
6269 * composite.c (_work_char): Remove unused static var.
6270
9cb2ac56
JB
62712011-07-09 Juanma Barranquero <lekktu@gmail.com>
6272
6273 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6274
f25661f0
JD
62752011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6276
6277 * gtkutil.c (qttip_cb): Remove code without function.
6278
8278c4fe
EZ
62792011-07-09 Eli Zaretskii <eliz@gnu.org>
6280
6281 * w32.c (pthread_sigmask): New stub.
6282
1692ae2d 62832011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6284
8a6ebd58 6285 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6286 sigprocmask is portable only for single-threaded applications, and
6287 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6288 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6289 (LIBES): Use it.
6290 * callproc.c (Fcall_process):
6291 * process.c (create_process):
6292 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6293 Use pthread_sigmask, not sigprocmask.
123403e4 6294
1b854618
JD
62952011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6296
6297 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6298 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6299 wrong (Bug#8591).
6300
3fe4b549
JD
63012011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6302
0ce7e563
JD
6303 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6304 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6305 (xg_hide_tooltip): Fix comment.
6306
3fe4b549
JD
6307 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6308 in registerServicesMenuSendTypes.
6309 (validRequestorForSendType): Don't check ns_return_types.
6310
6311 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6312 ns_return_type.
6313
5df75e47
JR
63142011-07-08 Jason Rumney <jasonr@gnu.org>
6315
22610910
JR
6316 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6317 SH_SHOW for hidden windows (Bug#5482).
6318
5df75e47
JR
6319 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6320 frame struct members of non-existent frames (Bug#6284).
6321
699c10bd
JD
63222011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6323
4393663b
JD
6324 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6325 variable firstTime not needed on OSX >= 10.6.
6326 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6327 >= 10.5. Use setKnobProportion, setDoubleValue.
6328
6329 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6330 (MAC_OS_X_VERSION_10_5): Define if not defined.
6331 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6332 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6333 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6334
6335 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6336 cString and lossyCString on OSX >= 10.4
6337
58179cce 6338 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6339 sizeToFit on OSX >= 10.2.
6340
6341 * nsimage.m (allocInitFromFile): Don't use deprecated method
6342 bestRepresentationForDevice on OSX >= 10.6.
6343
6344 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6345 to avoid warning.
6346
6347 * emacs.c: Declare unexec_init_emacs_zone.
6348
a63e0781
JD
6349 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6350
699c10bd
JD
6351 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6352
6353 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6354 on svcsMenu (Bug#8842).
6355
6356 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6357 ns_return_types.
6358 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6359
6360 * nsterm.m (QUTF8_STRING): Declare.
6361 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6362 (validRequestorForSendType): Return type is (id).
6363 Change indexOfObjectIdenticalTo to indexOfObject.
6364 Check if we have local selection before returning self (Bug#8842).
6365 (writeSelectionToPasteboard): Put local selection into paste board
6366 if we have a local selection (Bug#8842).
6367 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6368
6369 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6370 (ns_get_local_selection): Declare.
6371
54e10184
LMI
63722011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6373
9888ff71
LMI
6374 * keymap.c (describe_map_tree): Don't insert a double newline at
6375 the end of the buffer (bug#1169) and return whether we inserted
6376 something.
6377
54e10184
LMI
6378 * callint.c (Fcall_interactively): Change "reading args" to
6379 "providing args" to try to clarify what it does (bug#1010).
6380
15fa4783
KH
63812011-07-07 Kenichi Handa <handa@m17n.org>
6382
6383 * composite.c (composition_compute_stop_pos): Ignore a static
6384 composition starting before CHARPOS (Bug#8915).
6385
6386 * xdisp.c (handle_composition_prop): Likewise.
6387
a8815b00
EZ
63882011-07-07 Eli Zaretskii <eliz@gnu.org>
6389
6390 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6391 (Bug#9015)
6392
ef7b981d 63932011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6394
6395 * character.h (unicode_category_t): New enum type.
6396
6397 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6398 (Qchar_code_property_table): New variable.
6399 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6400 (UNIPROP_COMPRESSED_FORM_P): New macros.
6401 (char_table_ascii): Uncompress the compressed values.
6402 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6403 Uncompress the compressed values.
ac389d0c 6404 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6405 (char_table_ref_and_range): Uncompress the compressed values.
6406 (sub_char_table_set): New arg is_uniprop. Callers changed.
6407 Uncompress the compressed values.
6408 (sub_char_table_set_range): Args changed. Callers changed.
6409 (char_table_set_range): Adjuted for the above change.
6410 (map_sub_char_table): Delete args default_val and parent. Add arg
6411 top. Give decoded values to a Lisp function.
640c8776 6412 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6413 values to a Lisp function. Gcpro more variables.
6414 (uniprop_table_uncompress)
6415 (uniprop_decode_value_run_length): New functions.
6416 (uniprop_decoder, uniprop_decoder_count): New variables.
6417 (uniprop_get_decoder, uniprop_encode_value_character)
6418 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6419 New functions.
6420 (uniprop_encoder, uniprop_encoder_count): New variables.
6421 (uniprop_get_encoder, uniprop_table)
6422 (Funicode_property_table_internal, Fget_unicode_property_internal)
6423 (Fput_unicode_property_internal): New functions.
6424 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6425 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6426 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6427 char-code-property-alist.
6428
640c8776 6429 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6430 Vunicode_category_table.
6431
640c8776 6432 * font.c (font_range): Adjust for the change of
c805dec0
KH
6433 Vunicode_category_table.
6434
76b397fb
DN
64352011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6436
6437 * m/iris4d.h: Remove file, move contents ...
6438 * s/irix6-5.h: ... here.
6439
22b4128e
PE
64402011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6441
6442 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6443 * alloc.c (mark_buffer):
6444 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6445 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6446 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6447 This isn't true in general, and it's particularly not true
6448 if Emacs is configured with --with-wide-int.
6449 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6450 New macros, used in the buffer.c change.
6451
869795d6
JD
64522011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6453
6454 * xsettings.c: Use both GConf and GSettings if both are available.
6455 (store_config_changed_event): Add comment.
6456 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6457 (store_tool_bar_style_changed): New functions.
5e617bc2 6458 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6459 (struct xsettings): Move font inside HAVE_XFT.
6460 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6461 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6462 Move inside HAVE_XFT.
640c8776 6463 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6464 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6465 also.
6466 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6467 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6468 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6469 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6470 (parse_settings): Move check for font inside HAVE_XFT.
6471 (read_settings, apply_xft_settings): Add comment.
6472 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6473 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6474 call store_font_name_changed.
6475 (xft_settings_event): Add comment.
6476 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6477 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6478 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6479 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6480 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6481 (xsettings_get_system_font, xsettings_get_system_normal_font):
6482 Add comment.
869795d6 6483
d8ed26bd
PE
64842011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6485
6486 Random fixes. E.g., (random) never returned negative values.
6487 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6488 subseconds part to the entropy, as that's a bit more random.
6489 Prefer signed to unsigned, since the signedness doesn't matter and
6490 in general we prefer signed. When given a limit, use a
6491 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6492 latter isn't right if USE_2_TAGS_FOR_INTS.
6493 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6494 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6495
cabf1cac
SM
64962011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6497
6498 * textprop.c (text_property_stickiness):
6499 Obey Vtext_property_default_nonsticky.
6500 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6501 * w32fns.c (syms_of_w32fns):
6502 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6503
6e9b2be9
PE
65042011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6505
6506 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6507 This is more efficient than Ffile_directory_p and avoids a minor race.
6508
90186c68
LMI
65092011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6510
7c301272
LMI
6511 * buffer.c (Foverlay_put): Say what the return value is
6512 (bug#7835).
6513
c4f2d8d4
LMI
6514 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6515 is a directory before asking whether to use the file name
6516 (bug#7564).
ad637907
LMI
6517 (barf_or_query_if_file_exists): Make the "File is a directory"
6518 error be more correct.
c4f2d8d4 6519
90186c68
LMI
6520 * fns.c (Frequire): Remove the mention of the .gz files, since
6521 that's installation-specific, but keep the mention of
6522 `get-load-suffixes'.
6523
da64016e
PE
65242011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6525
6526 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6527 Report string overflow if the output is too long.
6528
7d47b580
JB
65292011-07-04 Juanma Barranquero <lekktu@gmail.com>
6530
a555cb87
JB
6531 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6532 (syms_of_gnutls): Remove duplicate DEFSYM for
6533 Qgnutls_bootprop_verify_hostname_error, an error for
6534 Qgnutls_bootprop_verify_error (which is no longer used).
6535
7d47b580
JB
6536 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6537 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6538 Also (re)move comments that are misplaced or no longer relevant.
6539
1e49bfab
LMI
65402011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6541
6542 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6543
1485f4c0
CY
65442011-07-03 Chong Yidong <cyd@stupidchicken.com>
6545
6546 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6547 and background color parameters if they have been changed.
6548
a9ab721e
LMI
65492011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6550
6551 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6552
cf7cff57
PE
65532011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6554
2e13213d
PE
6555 * xsettings.c (SYSTEM_FONT): Define only when used.
6556 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6557
cf7cff57
PE
6558 * keymap.c (access_keymap_1): Now static.
6559
7a8e04f7
CY
65602011-07-02 Chong Yidong <cyd@stupidchicken.com>
6561
6562 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6563 leave any prefix arg for the up event (Bug#1586).
6564
61352f62
LMI
65652011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6566
69bb1ef7
LMI
6567 * lread.c (syms_of_lread): Mention single symbols defined by
6568 `defvar' or `defconst' (bug#7154).
6569
61352f62 6570 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 6571 (Frequire): Mention get-load-suffixes.
61352f62 6572
28545e04
MR
65732011-07-02 Martin Rudalics <rudalics@gmx.at>
6574
6575 * window.h (window): Remove clone_number slot.
6576 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6577 Remove.
6578 (make_parent_window, make_window, saved_window)
6579 (Fset_window_configuration, save_window_save): Don't deal with
6580 clone numbers.
6581 * buffer.c (Qclone_number): Remove declaration.
6582 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6583
3349e122
SM
65842011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6585
6586 Add multiple inheritance to keymaps.
6587 * keymap.c (Fmake_composed_keymap): New function.
6588 (Fset_keymap_parent): Simplify.
6589 (fix_submap_inheritance): Remove.
6590 (access_keymap_1): New function extracted from access_keymap to handle
6591 embedded parents and handle lists of maps.
6592 (access_keymap): Use it.
6593 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6594 (Fcopy_keymap): Handle embedded parents.
6595 (Fcommand_remapping, define_as_prefix): Simplify.
6596 (Fkey_binding): Simplify.
6597 (syms_of_keymap): Move minibuffer-local-completion-map,
6598 minibuffer-local-filename-completion-map,
6599 minibuffer-local-must-match-map, and
6600 minibuffer-local-filename-must-match-map to Elisp.
6601 (syms_of_keymap): Defsubr make-composed-keymap.
6602 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6603 (parse_menu_item): Trivial simplification.
6604
3279eb87
GM
66052011-07-01 Glenn Morris <rgm@gnu.org>
6606
6607 * Makefile.in (SETTINGS_LIBS): Fix typo.
6608
4550efdf
KI
66092011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6610
6611 * coding.c (Fencode_coding_string): Record the last coding system
6612 used, as the function doc string says (bug#8738).
6613
0949d2b6
JD
66142011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6615
6616 * xsettings.c (store_monospaced_changed): Take new font as arg and
6617 check for change against current_mono_font.
6618 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6619 (emacs_settings_constructor, emacs_settings_get_property)
6620 (emacs_settings_set_property, emacs_settings_class_init)
6621 (emacs_settings_init, gsettings_obj): Remove.
6622 (something_changedCB): New function for HAVE_GSETTINGS.
6623 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6624 with value as argument.
6625 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6626 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 6627 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
6628 "changed".
6629
6630 * xgselect.c: Add defined (HAVE_GSETTINGS).
6631 (xgselect_initialize): Ditto.
6632
6633 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6634 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6635 xg_select.
6636
bbc6b304
PE
66372011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6638
6639 * eval.c (struct backtrace): Simplify and port the data structure.
6640 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6641 signed bit field, as this assumption is not portable and it makes
6642 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6643 "char debug_on_exit : 1" as this is not portable either; instead,
6644 use the portable "unsigned int debug_on_exit : 1". Remove unused
6645 member evalargs. Remove obsolete comments about cc bombing out.
6646
9851bfc5
JD
66472011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6648
51bb811f 6649 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
6650 Let HAVE_GSETTINGS override HAVE_GCONF.
6651 (store_monospaced_changed): New function.
6652 (EMACS_SETTINGS): A new type derived from GObject to handle
6653 GSettings notifications.
6654 (emacs_settings_constructor, emacs_settings_get_property)
6655 (emacs_settings_set_property, emacs_settings_class_init):
6656 New functions.
6657 (gsettings_client, gsettings_obj): New variables.
6658 (GSETTINGS_SCHEMA): New define.
6659 (something_changedCB): Call store_monospaced_changed.
6660 (init_gsettings): New function.
6661 (xsettings_initialize): Call init_gsettings.
6662 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6663 to NULL.
6664
640c8776 6665 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
6666 GCONF_CFLAGS/LIBS.
6667
5386012d
MR
66682011-06-29 Martin Rudalics <rudalics@gmx.at>
6669
6670 * window.c (resize_root_window, grow_mini_window)
6671 (shrink_mini_window): Rename Qresize_root_window to
6672 Qwindow_resize_root_window and Qresize_root_window_vertically to
6673 Qwindow_resize_root_window_vertically.
6674
f13e0b08
PE
66752011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6676
6677 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6678
94515237
JB
66792011-06-27 Juanma Barranquero <lekktu@gmail.com>
6680
6681 * makefile.w32-in: Redesign dependencies so they reflect more
6682 clearly which files are directly included by each source file,
6683 and not through other includes.
6684
e43b6e43
MR
66852011-06-27 Martin Rudalics <rudalics@gmx.at>
6686
6687 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6688 (sort_overlays, overlay_strings): When an overlay's clone number
6689 matches the window's clone number process the overlay even if
6690 the overlay's window property doesn't match the current window.
6691
d68443dc
MR
6692 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6693 (Fwindow_hchild): Rename to Fwindow_left_child.
6694 (Fwindow_next): Rename to Fwindow_next_sibling.
6695 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
6696 (resize_window_check): Rename to window_resize_check.
6697 (resize_window_apply): Rename to window_resize_apply.
6698 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6699 (Fdelete_other_windows_internal, resize_frame_windows)
6700 (Fsplit_window_internal, Fdelete_window_internal)
6701 (grow_mini_window, shrink_mini_window)
6702 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 6703
c7e73be5
JD
67042011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6705
6706 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6707 (emacs_fixed_set_min_size): Remove.
6708 (emacs_fixed_new): Take frame as argument.
6709
6710 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6711 (_EmacsFixedPrivate): Remove minwidth/height.
6712 Add struct frame *f.
6713 (emacs_fixed_init): Initialize priv->f.
6714 (get_parent_class, emacs_fixed_set_min_size): Remove.
6715 (emacs_fixed_new): Set priv->f to argument.
6716 (emacs_fixed_get_preferred_width)
6717 (emacs_fixed_get_preferred_height): Use min_width/height from
6718 frames size_hint to set minimum and natural (Bug#8919).
6719 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6720 and use min_width/height from frames size_hint to set
6721 min_width/height (Bug#8919).
6722
6723 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
6724 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6725 Fix indentation.
c7e73be5 6726
cf99dcf8
EZ
67272011-06-26 Eli Zaretskii <eliz@gnu.org>
6728
6729 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6730 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6731 called at ZV.
6732
029529ac
CY
67332011-06-26 Chong Yidong <cyd@stupidchicken.com>
6734
6735 * process.c (wait_reading_process_output): Bypass select if
6736 waiting for a cell while ignoring keyboard input, and input is
6737 pending. Suggested by Jan Djärv (Bug#8869).
6738
7a7ef429
PE
67392011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6740
6741 Use gnulib's dup2 module instead of rolling our own.
6742 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6743
11fdef7d 67442011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
6745
6746 * dispnew.c (scrolling_window): Before scrolling, turn off a
6747 mouse-highlight in the window being scrolled.
6748
cd3520a4
JB
67492011-06-24 Juanma Barranquero <lekktu@gmail.com>
6750
6751 Move DEFSYM to lisp.h and use everywhere.
6752
6753 * character.h (DEFSYM): Move declaration...
6754 * lisp.h (DEFSYM): ...here.
6755
6756 * gnutls.c:
6757 * minibuf.c:
6758 * w32menu.c:
6759 * w32proc.c:
6760 * w32select.c: Don't include character.h.
6761
6762 * alloc.c (syms_of_alloc):
6763 * buffer.c (syms_of_buffer):
6764 * bytecode.c (syms_of_bytecode):
6765 * callint.c (syms_of_callint):
6766 * casefiddle.c (syms_of_casefiddle):
6767 * casetab.c (init_casetab_once):
6768 * category.c (init_category_once, syms_of_category):
6769 * ccl.c (syms_of_ccl):
6770 * cmds.c (syms_of_cmds):
6771 * composite.c (syms_of_composite):
6772 * dbusbind.c (syms_of_dbusbind):
6773 * dired.c (syms_of_dired):
6774 * dispnew.c (syms_of_display):
6775 * doc.c (syms_of_doc):
6776 * editfns.c (syms_of_editfns):
6777 * emacs.c (syms_of_emacs):
6778 * eval.c (syms_of_eval):
6779 * fileio.c (syms_of_fileio):
6780 * fns.c (syms_of_fns):
6781 * frame.c (syms_of_frame):
6782 * fringe.c (syms_of_fringe):
6783 * insdel.c (syms_of_insdel):
6784 * keymap.c (syms_of_keymap):
6785 * lread.c (init_obarray, syms_of_lread):
6786 * macros.c (syms_of_macros):
6787 * msdos.c (syms_of_msdos):
6788 * print.c (syms_of_print):
6789 * process.c (syms_of_process):
6790 * search.c (syms_of_search):
6791 * sound.c (syms_of_sound):
6792 * syntax.c (init_syntax_once, syms_of_syntax):
6793 * terminal.c (syms_of_terminal):
6794 * textprop.c (syms_of_textprop):
6795 * undo.c (syms_of_undo):
6796 * w32.c (globals_of_w32):
6797 * window.c (syms_of_window):
6798 * xdisp.c (syms_of_xdisp):
6799 * xfaces.c (syms_of_xfaces):
6800 * xfns.c (syms_of_xfns):
6801 * xmenu.c (syms_of_xmenu):
6802 * xsettings.c (syms_of_xsettings):
6803 * xterm.c (syms_of_xterm): Use DEFSYM.
6804
4228cf16
TZ
68052011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6806
cd3520a4 6807 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 6808
7fcccf1e
PE
68092011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6810
7efb4e0e
PE
6811 Integer and buffer overflow fixes (Bug#8873).
6812
ff5844ad
PE
6813 * print.c (printchar, strout): Check for string overflow.
6814 (PRINTPREPARE, printchar, strout):
6815 Don't set size unless allocation succeeds.
6816
90532f02
PE
6817 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6818 for sizes. Check for string overflow more accurately.
6819 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6820
6d84508d
PE
6821 * macros.c: Integer and buffer overflow fixes.
6822 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6823 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6824 Use ptrdiff_t, not int, for sizes.
6825 Don't increment bufsize until after realloc succeeds.
6826 Check for size-calculation overflow.
6827 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6828
437b2cb4
PE
6829 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6830
8b9ac8b4
PE
6831 * lread.c: Integer overflow fixes.
6832 (read_integer): Radix is now EMACS_INT, not int,
6833 to improve quality of diagnostics for out-of-range radices.
6834 Calculate buffer size correctly for out-of-range radices.
6835 (read1): Check for integer overflow in radices, and in
6836 read-circle numbers.
82cb60d3
PE
6837 (read_escape): Avoid int overflow.
6838 (Fload, openp, read_buffer_size, read1)
6839 (substitute_object_recurse, read_vector, read_list, map_obarray):
6840 Use ptrdiff_t, not int, for sizes.
6841 (read1): Use EMACS_INT, not int, for sizes.
20270765 6842 Check for size overflow.
8b9ac8b4 6843
7fcccf1e
PE
6844 * image.c (cache_image): Check for size arithmetic overflow.
6845
bfbbd7e7
PE
6846 * lread.c: Integer overflow issues.
6847 (saved_doc_string_size, saved_doc_string_length)
6848 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6849 Now ptrdiff_t, not int.
6850 (read1): Don't assume doc string length fits in int. Check for
6851 out-of-range doc string lengths.
6852 (read_list): Don't assume file position fits in int.
39019e54 6853 (read_escape): Check for hex character overflow.
bfbbd7e7 6854
4e323265
LL
68552011-06-22 Leo Liu <sdl.web@gmail.com>
6856
6857 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6858 Move to minibuffer.el.
6859
85fece3e
PE
68602011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6861
20b84ce9 6862 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
6863 The following patches are for when GLYPH_DEBUG && !XASSERT.
6864 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6865 * dispnew.c (flush_stdout):
6866 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6867 Mark as externally visible.
6868 * dispnew.c (check_window_matrix_pointers): Now static.
6869 * dispnew.c (window_to_frame_vpos):
6870 * xfns.c (unwind_create_frame):
6871 * xterm.c (x_check_font): Remove unused local.
6872 * scroll.c (CHECK_BOUNDS):
6873 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6874 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6875 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6876 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6877 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6878 Now static.
6879 (debug_method_add): Use va_list and vsprintf rather than relying
6880 on undefined behavior with wrong number of arguments.
6881 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6882 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6883 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6884 since we're not interested in debugging glyphs with old libraries.
6885 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6886 GCC 4.6.0's static checking.
6887
0766b489
PE
68882011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6889
31fd4b32
PE
6890 Integer overflow and signedness fixes (Bug#8873).
6891 A few related buffer overrun fixes, too.
6892
b79e8648
PE
6893 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6894
0766b489
PE
6895 * dispextern.h (struct face.stipple):
6896 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6897 (x_bitmap_mask, x_allocate_bitmap_record)
6898 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6899 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6900 (x_create_bitmap_from_xpm_data):
6901 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6902 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6903 (.bitmaps_last):
6904 * xfaces.c (load_pixmap):
6905 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6906 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6907 (.bitmaps_last, struct x_output.icon_bitmap):
6908 Use ptrdiff_t, not int, for bitmap indexes.
6909 (x_allocate_bitmap_record): Check for size overflow.
6910 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6911
b081724f
PE
6912 Use ptrdiff_t, not int, for overlay counts.
6913 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6914 * editfns.c (overlays_around, get_pos_property):
6915 * textprop.c (get_char_property_and_overlay):
6916 * xdisp.c (next_overlay_change, note_mouse_highlight):
6917 * xfaces.c (face_at_buffer_position):
21514da7
PE
6918 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6919 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6920 (Fnext_overlay_change, Fprevious_overlay_change)
6921 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 6922 Use ptrdiff_t, not int, for sizes.
21514da7 6923 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 6924
3de73e5e
PE
6925 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6926
2606c57b
PE
6927 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6928 (x_session_initialize): Do not assume string length fits in int.
6929
aaafe47a
PE
6930 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6931 This is unlikely, but can occur if DPI is outlandish.
6932
2674ddc8 6933 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
6934 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6935
28154962
PE
6936 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6937 * xrdb.c (magic_file_p, search_magic_path):
6938 Omit last arg SUFFIX; it was always 0. All callers changed.
6939 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6940
7de51af5
PE
6941 * xfont.c (xfont_match): Avoid need for strlen.
6942
25ed6cc3
PE
6943 * xfns.c: Don't assume strlen fits in int.
6944 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6945
4eab31dd
PE
6946 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6947 not unsigned long, as we prefer signed integers. All callers changed.
6948 Detect integer overflow in repeat count.
6949 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 6950 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 6951
171e2a58
PE
6952 * termcap.c: Don't assume sizes fit in int and never overflow.
6953 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6954 (gobble_line): Check for size-calculation overflow.
6955
ad39faca 6956 * minibuf.c (Fread_buffer):
6e5bb2dc 6957 * lread.c (intern, intern_c_string):
74ca2eb3
PE
6958 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6959 Don't assume string length fits in int.
6960
52c61c22 6961 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
6962 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6963
b5b8c9e5
PE
6964 * font.c: Don't assume string length fits in int.
6965 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6966 Use ptrdiff_t, not int.
ccd6111c
PE
6967 (font_intern_prop): Don't assume string length fits in int.
6968 Don't assume integer property fits in fixnum.
6969 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 6970
882f0d81 6971 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 6972 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
6973 Reformulate so as not to need the command string.
6974 Invoke gzip -cd rather than gunzip, as it's more portable.
6975 (lock_info_type, lock_file_1, lock_file):
6976 Don't assume pid_t and time_t fit in unsigned long.
6977 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6978 (current_lock_owner): Prefer signed type for sizes.
6979 Use memcpy, not strncpy, where memcpy is what is really wanted.
6980 Don't assume (via atoi) that time_t and pid_t fit in int.
6981 Check for time_t and/or pid_t out of range, e.g., via a network share.
6982 Don't alloca where an auto var works fine.
6983
93f4cf88
PE
6984 * fileio.c: Fix some integer overflow issues.
6985 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6986 Don't assume string length fits in int.
6987 (directory_file_name): Don't assume string length fits in long.
6988 (make_temp_name): Don't assume pid fits in int, or that its print
6989 length is less than 20.
6990
f3e92b69
PE
6991 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6992
1bfdaf10
PE
6993 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6994
35016e9a
PE
6995 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6996
3d1e65a1
PE
6997 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6998 We prefer signed integers, even for size calculations.
6999
0b963a93
PE
7000 * emacs.c: Don't assume string length fits in 'int'.
7001 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7002 (main): Don't invoke strlen when not needed.
7003
573f4b54
PE
7004 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7005 (XD_DEBUG_MESSAGE): Don't waste a byte.
7006
989f33ba
PE
7007 * callproc.c (getenv_internal_1, getenv_internal)
7008 (Fgetenv_internal):
965d34eb
PE
7009 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7010
e4d29b33
PE
7011 * lread.c (invalid_syntax): Omit length argument.
7012 All uses changed. This doesn't fix a bug, but it simplifies the
7013 code away from its former Hollerith-constant appearance, and it's
7014 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7015 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7016
eb49b136
PE
7017 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7018 This didn't break anything, but it didn't help either.
7019 It's confusing to put a bogus integer in a place where the actual
7020 value does not matter.
9f62aeb1 7021 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7022 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7023
15375a22
PE
7024 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7025 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7026 implementation.
b61cc01c
PE
7027 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7028 We prefer signed types, and the value cannot exceed the EMACS_INT
7029 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7030 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7031 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7032 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7033
53b2623d
PE
7034 * indent.c (sane_tab_width): New function.
7035 (current_column, scan_for_column, Findent_to, position_indentation)
7036 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7037 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7038
51cab52b 7039 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7040
f2ed8a70
PE
7041 * lisp.h (lint_assume): New macro.
7042 * composite.c (composition_gstring_put_cache):
7043 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7044
abe80cc6
PE
7045 * editfns.c, insdel.c:
7046 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7047
b02c740e
PE
7048 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7049
ebc96716
PE
7050 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7051
b4e50fa0 7052 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7053 Use much-faster test for byte-length change.
311d5d7c 7054 Don't assume string byte-length fits in 'int'.
a4cf38e4 7055 Check that character arg fits in 'int'.
85461888 7056 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7057
c0c1ee9f
PE
7058 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7059
a498d7f4
PE
7060 * fns.c (concat): Catch string overflow earlier.
7061 Do not rely on integer wraparound.
7062
51cab52b
PE
7063 * dispextern.h (struct it.overlay_strings_charpos)
7064 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7065 * xdisp.c (forward_to_next_line_start)
7066 (back_to_previous_visible_line_start)
7067 (reseat_at_next_visible_line_start, next_element_from_buffer):
7068 Don't arbitrarily truncate the value of 'selective' to int.
7069
76031fad
PE
7070 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7071
5eb55db9
PE
7072 * composite.c: Don't truncate sizes to 'int'.
7073 (composition_gstring_p, composition_reseat_it)
7074 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7075 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7076 not EMACS_UINT, for indexes.
5eb55db9 7077
0703a717
PE
7078 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7079
d6202519
PE
7080 * buffer.c: Include <verify.h>.
7081 (struct sortvec.priority, struct sortstr.priority):
8961a454 7082 Now EMACS_INT, not int.
c20998a7 7083 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7084 (struct sortstr.size, record_overlay_string)
7085 (struct sortstrlist.size, struct sortlist.used):
7086 Don't truncate size to int.
7087 (record_overlay_string): Check for size-calculation overflow.
d6202519 7088 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7089
d5a19415
JM
70902011-06-22 Jim Meyering <meyering@redhat.com>
7091
029529ac 7092 Don't leak an XBM-image-sized buffer
d5a19415
JM
7093 * image.c (xbm_load): Free the image buffer after using it.
7094
a9041e6c
PE
70952011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7096
7097 Port to Sun C.
7098 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7099 that Sun C diagnosed.
7100 * fns.c (secure_hash): Fix pointer signedness issue.
7101 * intervals.c (static_offset_intervals): New function.
7102 (offset_intervals): Use it.
7103
7f3f739f
LL
71042011-06-21 Leo Liu <sdl.web@gmail.com>
7105
7106 * deps.mk (fns.o):
7107 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7108 sha512.h.
7109
7110 * fns.c (secure_hash): Rename from crypto_hash_function and change
7111 the first arg to accept symbols.
5b66d427 7112 (Fsecure_hash): New primitive.
7f3f739f
LL
7113 (syms_of_fns): New symbols.
7114
76147d94
DD
71152011-06-20 Deniz Dogan <deniz@dogan.se>
7116
7117 * process.c (Fset_process_buffer): Clarify return value in
7118 docstring.
7119
7d7d0045
CY
71202011-06-18 Chong Yidong <cyd@stupidchicken.com>
7121
7122 * dispnew.c (add_window_display_history): Use BVAR.
7123
7124 * xdisp.c (debug_method_add): Use BVAR.
7125 (check_window_end, dump_glyph_matrix, dump_glyph)
7126 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7127
7128 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7129 Likewise.
7130
7131 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7132 check till after the cache is created in init_frame_faces.
7133
ff2bc410
SM
71342011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7135
7136 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7137
28177add
PE
71382011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7139
dd3482fe
PE
7140 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7141 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7142 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7143
393d71f3 7144 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7145 * fileio.c (Finsert_file_contents):
7146 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7147 Remove the old (too-loose) buffer overflow checks.
7148 They weren't needed, since make_gap checks for buffer overflow.
7149 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7150 The old code merely checked for Emacs fixnum overflow, and relied
7151 on undefined (wraparound) behavior. The new code avoids undefined
7152 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7153
2e6813b0 7154 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7155 Tune. Don't use wider integers than needed. Don't use alloca.
7156 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7157
599a9e4f
PE
7158 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7159
99561444
PE
7160 * insdel.c, lisp.h (buffer_overflow): New function.
7161 (insert_from_buffer_1, replace_range, replace_range_2):
7162 * insdel.c (make_gap_larger):
7163 * editfns.c (Finsert_char):
7164 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7165
28177add
PE
7166 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7167
e69dafad
PE
71682011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7169
4baa020d 7170 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7171
b1c46f02
PE
7172 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7173 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7174
e69dafad
PE
7175 * fileio.c: Don't assume EMACS_INT fits in off_t.
7176 (emacs_lseek): New static function.
7177 (Finsert_file_contents, Fwrite_region): Use it.
7178 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7179
566684ea
PE
7180 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7181
e6966cd6
PE
7182 * fns.c: Don't overflow int when computing a list length.
7183 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7184 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7185 truncation on 64-bit hosts. Check for QUIT every
7186 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7187 faster and is responsive enough.
7188 (Flength): Report an error instead of overflowing an integer.
7189 (Fsafe_length): Return a float if the value is not representable
7190 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7191 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7192 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7193
dd0b0efb
PE
7194 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7195 (header_size, word_size): New constants.
7196 (allocate_vectorlike): Don't check size overflow here.
7197 (allocate_vector): Check it here instead, since this is the only
7198 caller of allocate_vectorlike that could cause overflow.
7199 Check that the new vector's length is representable as a fixnum.
7200
86fe5cfe
PE
7201 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7202 The previous code was bogus. For example, next_almost_prime (32)
7203 returned 39, which is undesirable as it is a multiple of 3; and
7204 next_almost_prime (24) returned 25, which is a multiple of 5 so
7205 why was the code bothering to check for multiples of 7?
7206
80e88859
PE
7207 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7208
4a2f0ad6
PE
7209 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7210
f66c7cf8
PE
7211 Variadic C functions now count arguments with ptrdiff_t.
7212 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7213 Back then I didn't know that the Emacs coding style prefers signed int.
7214 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7215 were being counted with int, which may truncate counts on 64-bit
7216 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7217 * lisp.h (struct Lisp_Subr.function.aMANY)
7218 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7219 Arg counts are now ptrdiff_t, not size_t.
7220 All variadic functions and their callers changed accordingly.
7221 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7222 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7223 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7224 * callint.c (Fcall_interactively): Check arg count for overflow,
7225 to avoid potential buffer overrun. Use signed char, not 'int',
7226 for 'varies' array, so that we needn't bother to check its size
7227 calculation for overflow.
7228 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7229 * eval.c (apply_lambda):
7230 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7231 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7232 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7233
a1759b76
PE
7234 * callint.c (Fcall_interactively): Don't use index var as event count.
7235
d96be9fc
PE
7236 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7237 * mem-limits.h (SIZE): Remove; no longer used.
7238
a690a978 7239 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7240
578c21e6
PE
7241 Remove unnecessary casts.
7242 * xterm.c (x_term_init):
7243 * xfns.c (x_set_border_pixel):
7244 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7245 These aren't needed now that we assume ANSI C.
7246
96f53c6c
PE
7247 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7248 It's more likely to cause problems (due to unsigned overflow)
7249 than to cure them.
7250
83c77d31
PE
7251 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7252
ee2079f1
PE
7253 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7254
6da65536
PE
7255 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7256
7147c4a4
PE
7257 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7258
193e32d9
PE
7259 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7260
e5533da6
PE
7261 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7262
9910e595
PE
7263 GLYPH_CODE_FACE returns EMACS_INT, not int.
7264 * dispextern.h (merge_faces):
7265 * xfaces.c (merge_faces):
01103c44
PE
7266 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7267 Don't assume EMACS_INT fits in int.
9910e595 7268
2638320e
PE
7269 * character.h (CHAR_VALID_P): Remove unused parameter.
7270 * fontset.c, lisp.h, xdisp.c: All uses changed.
7271
045eb8d9
PE
7272 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7273
c1f134b5
PE
7274 * fns.c (concat): Minor tuning based on overflow analysis.
7275 This doesn't fix any bugs. Use int to hold character, instead
7276 of constantly refetching from Emacs object. Use XFASTINT, not
7277 XINT, for value known to be a character. Don't bother comparing
7278 a single byte to 0400, as it's always less.
7279
395fcb93 7280 * floatfns.c (Fexpt):
327eeec8
PE
7281 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7282
abbd3d23
PE
7283 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7284 for characters.
7285
684a03ef
PE
7286 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7287
0fed43f3
PE
7288 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7289 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7290 incorrectly succeed when S was a string, because 4294967386 was
7291 truncated before it was used.
7292
8fd02eb7
PE
7293 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7294 Otherwise, an out-of-range integer could cause undefined behavior
7295 on a 64-bit host.
7296
f8c86b69
PE
7297 * composite.c: Use int, not EMACS_INT, for characters.
7298 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7299 EMACS_INT, for values that are known to be in character range.
7300 This doesn't fix any bugs but is the usual style inside Emacs and
7301 may generate better code on 32-bit machines.
7302
34206dd2
PE
7303 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7304 This is for reasons similar to the recent CHAR_STRING fix.
7305 * charset.c (Fencode_char): Check that character arg is actually
7306 a character. Pass an int to ENCODE_CHAR.
7307 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7308 wider than 'int', as a compile-time check to prevent future regressions
7309 in this area.
7310
c5958d4c 7311 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7312
7313 Make sure a 64-bit char is never passed to CHAR_STRING.
7314 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7315 by silently ignoring the top 32 bits, allowing some values
7316 that were far too large to be valid characters.
7317 * character.h: Include <verify.h>.
7318 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7319 arguments are no wider than unsigned, as a compile-time check
7320 to prevent future regressions in this area.
7321 * data.c (Faset):
01103c44 7322 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7323 (Fsubst_char_in_region):
7324 * fns.c (concat):
7325 * xdisp.c (decode_mode_spec_coding):
7326 Adjust to CHAR_STRING's new requirement.
7327 * editfns.c (Finsert_char, Fsubst_char_in_region):
7328 * fns.c (concat): Check that character args are actually
7329 characters. Without this test, these functions did the wrong
7330 thing with wildly out-of-range values on 64-bit hosts.
7331
d37ca623
PE
7332 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7333 These casts should not be needed on 32-bit hosts, either.
7334 * keyboard.c (read_char):
7335 * lread.c (Fload): Remove casts to unsigned.
7336
ea204efb
PE
7337 * lisp.h (UNSIGNED_CMP): New macro.
7338 This fixes comparison bugs on 64-bit hosts.
7339 (ASCII_CHAR_P): Use it.
7340 * casefiddle.c (casify_object):
01103c44 7341 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7342 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7343 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7344 * dispextern.h (FACE_FROM_ID):
7345 * keyboard.c (read_char): Use UNSIGNED_CMP.
7346
41cb286c
PE
7347 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7348 not to EMACS_INT, to avoid GCC warning.
7349
4a1b9832
PE
7350 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7351
55daad71
PE
7352 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7353 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7354 isn't needed on 32-bit machines.
8f95c75c 7355
01103c44
PE
7356 * buffer.c (Fgenerate_new_buffer_name):
7357 Use EMACS_INT for count, not int.
0ceccced 7358 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7359
7360 * data.c (Qcompiled_function): Now static.
7361
c6f072e7
PE
7362 * window.c (window_body_lines): Now static.
7363
20ce5912
PE
7364 * image.c (gif_load): Rename local to avoid shadowing.
7365
9c4c5f81
PE
7366 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7367 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7368 * alloc.c (make_save_value): Integer argument is now of type
7369 ptrdiff_t, not int.
7370 (mark_object): Use ptrdiff_t, not int.
7371 * lisp.h (pD): New macro.
7372 * print.c (print_object): Use it.
7373
c0c5c8ae
PE
7374 * alloc.c: Use EMACS_INT, not int, to count objects.
7375 (total_conses, total_markers, total_symbols, total_vector_size)
7376 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7377 (total_free_floats, total_floats, total_free_intervals)
7378 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7379 Now EMACS_INT, not int. All uses changed.
7380 (Fgarbage_collect): Compute overall total using a double, so that
7381 integer overflow is less likely to be a problem. Check for overflow
7382 when converting back to an integer.
5a25e253
PE
7383 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7384 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7385 These were 'int' variables that could overflow on 64-bit hosts;
7386 they were never used, so remove them instead of repairing them.
211a0b2a 7387 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7388 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7389 Previously, this ceilinged at INT_MAX, but that doesn't work on
7390 64-bit machines.
e46bb31a 7391 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7392
c78baabf 7393 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7394 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7395 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7396 when a (possibly-narrower) signed value would do just as well.
7397 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7398
c9d624c6
PE
7399 * alloc.c: Catch some string size overflows that we were missing.
7400 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7401 for convenience in STRING_BYTES_MAX.
7402 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7403 The definition here is exact; the one in lisp.h was approximate.
7404 (allocate_string_data): Check for string overflow. This catches
7405 some instances we weren't catching before. Also, it catches
7406 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7407 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7408 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7409
c9d624c6
PE
7410 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7411 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7412 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7413
353032ce
PE
7414 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7415
2bccce07
PE
7416 * alloc.c (Fmake_string): Check for out-of-range init.
7417
0ac30604
SM
74182011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7419
7420 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7421
c195f2de
JD
74222011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7423
7424 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7425 xg_get_default_scrollbar_width.
7426
7427 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7428 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7429 (style_changed_cb): Call update_theme_scrollbar_width and call
7430 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7431 all frames (Bug#8505).
7432 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7433 Call gtk_window_set_resizable if HAVE_GTK3.
7434 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7435 and height if HAVE_GTK3 (Bug#8505).
7436 (scroll_bar_width_for_theme): New variable.
7437 (update_theme_scrollbar_width): New function.
7438 (xg_get_default_scrollbar_width): Move code to
7439 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7440 (xg_initialize): Call update_theme_scrollbar_width.
7441
7442 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7443
7444 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7445
e10ac9f1
MR
74462011-06-12 Martin Rudalics <rudalics@gmx.at>
7447
7448 * frame.c (make_frame): Call other_buffer_safely instead of
7449 other_buffer.
7450
7451 * window.c (temp_output_buffer_show): Call display_buffer with
7452 second argument Vtemp_buffer_show_specifiers and reset latter
7453 immediately after the call.
7454 (Vtemp_buffer_show_specifiers): New variable.
7455 (auto_window_vscroll_p, next_screen_context_lines)
7456 (Vscroll_preserve_screen_position): Remove leading asterisks from
7457 doc-strings.
7458
2d3c217e 74592011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7460
7b7f97e8 7461 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7462 * buffer.c (Qclone_number): Remove for now, as it's unused.
7463 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7464 (record_buffer): Remove unused local.
7465 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7466 (set_frame_buffer_list): Remove; unused.
7467 * frame.h (other_visible_frames): Remove decl.
7468 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7469 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7470 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7471 if HAVE_GPM.
7472 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7473 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7474 Define only if HAVE_GPM.
7475 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7476 (update_hints_inhibit): Remove; never set. All uses removed.
7477 * widgetprv.h (emacsFrameClassRec): Remove decl.
7478 * window.c (delete_deletable_window): Now returns void, since it
7479 wasn't returning anything.
7480 (compare_window_configurations): Remove unused locals.
7481 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7482 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7483 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7484 the same widths as pointers. This follows up on the 2011-05-06 patch.
7485 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7486 * xterm.h: Likewise.
7487 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7488
1384b89e
JB
74892011-06-12 Juanma Barranquero <lekktu@gmail.com>
7490
7491 * makefile.w32-in: Update dependencies.
7492 (LISP_H): Add lib/intprops.h.
7493
1100a63c
CY
74942011-06-11 Chong Yidong <cyd@stupidchicken.com>
7495
7496 * image.c (gif_load): Add animation frame delay to the metadata.
7497 (syms_of_image): Use DEFSYM. New symbol `delay'.
7498
6198ccd0
MR
74992011-06-11 Martin Rudalics <rudalics@gmx.at>
7500
7501 * window.c (delete_deletable_window): Re-add.
7502 (Fset_window_configuration): Rewrite to handle dead buffers and
7503 consequently deletable windows.
7504 (window_tree, Fwindow_tree): Remove. Supply functionality in
7505 window.el.
7506 (compare_window_configurations): Simplify code.
7507
b6e3633c
AS
75082011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7509
1ab0dee5
AS
7510 * image.c (imagemagick_load_image): Fix type mismatch.
7511 (Fimagemagick_types): Likewise.
7512
b6e3633c
AS
7513 * window.h (replace_buffer_in_windows): Declare.
7514
9397e56f
MR
75152011-06-11 Martin Rudalics <rudalics@gmx.at>
7516
7517 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7518 Qclone_number. Remove external declaration of Qdelete_window.
7519 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7520 code.
640c8776
SM
7521 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7522 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7523 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7524 buffer list implementation.
7525 (other_buffer_safely): New function.
7526 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7527 calls to replace_buffer_in_windows and
7528 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7529 if allowed.
7530 (record_buffer): Inhibit quitting and rewrite using quittable
7531 functions. Run Qbuffer_list_update_hook if allowed.
7532 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7533 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7534 Move switch-to-buffer to window.el.
9397e56f
MR
7535 (bury-buffer): Move to window.el.
7536 (Vbuffer_list_update_hook): New variable.
7537
7538 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7539 section.
7540
7541 * window.h (resize_frame_windows): Move up in code.
7542 (Fwindow_frame): Remove EXFUN.
7543 (replace_buffer_in_all_windows): Remove prototype.
7544 (replace_buffer_in_windows_safely): Add prototype.
7545
7546 * window.c: Declare Qdelete_window static again. Move down
7547 declaration of select_count.
7548 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7549 (Fother_window): Move to window.el.
7550 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7551 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7552 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7553 window.el.
7554 (replace_buffer_in_windows): Implement by calling
7555 Qreplace_buffer_in_windows.
7556 (replace_buffer_in_all_windows): Remove with some functionality
7557 moved into replace_buffer_in_windows_safely.
7558 (replace_buffer_in_windows_safely): New function.
7559 (select_window_norecord, select_frame_norecord): Move in front
7560 of run_window_configuration_change_hook. Remove now obsolete
7561 declarations.
640c8776
SM
7562 (Fset_window_buffer): Rewrite doc-string.
7563 Call Qrecord_window_buffer.
9397e56f
MR
7564 (keys_of_window): Move binding for other-window to window.el.
7565
b50691aa
CY
75662011-06-11 Chong Yidong <cyd@stupidchicken.com>
7567
7568 * dispextern.h (struct image): Replace data member, whose int_val
7569 and ptr_val fields were not used by anything, with a single
7570 lisp_val object.
7571
7572 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7573 (gif_clear_image, gif_load, imagemagick_load_image)
7574 (gs_clear_image, gs_load): Callers changed.
7575
3f754b86
PE
75762011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7577
cca69397
PE
7578 * buffer.h: Include <time.h>, for time_t.
7579 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7580
109e28d0
PE
7581 Fix minor problems found by static checking.
7582
60737f02
PE
7583 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7584
4b66faf3
PE
7585 Make identifiers static if they are not used in other modules.
7586 * data.c (Qcompiled_function, Qframe, Qvector):
7587 * image.c (QimageMagick, Qsvg):
7588 * minibuf.c (Qmetadata):
7589 * window.c (resize_window_check, resize_root_window): Now static.
7590 * window.h (resize_window_check, resize_root_window): Remove decls.
7591
109e28d0
PE
7592 * window.c (window_deletion_count, delete_deletable_window):
7593 Remove; unused.
46a4ce9e
PE
7594 (window_body_lines): Now static.
7595 (Fdelete_other_windows_internal): Mark vars as initialized.
7596 Make sure 'resize_failed' is initialized.
7597 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7598 (resize_window_apply): Remove unused local.
7599 * window.h (delete_deletable_window): Remove decl.
7600
109e28d0 7601 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
7602 (imagemagick_load_image): Fix pointer signedness problem by changing
7603 last arg from unsigned char * to char *. All uses changed.
7604 Also, fix a local for similar reasons.
7605 Remove unused locals. Remove locals to avoid shadowing.
7606 (fn_rsvg_handle_free): Remove; unused.
7607 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 7608 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 7609
3f754b86
PE
7610 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7611
2547adb1
CY
76122011-06-10 Chong Yidong <cyd@stupidchicken.com>
7613
7614 * image.c (gif_load): Fix omitted cast error introduced by
7615 2011-06-06 change.
7616
2c8e37d4
MR
76172011-06-10 Martin Rudalics <rudalics@gmx.at>
7618
7619 * window.h (resize_proportionally, orig_total_lines)
7620 (orig_top_line): Remove from window structure.
7621 (set_window_height, set_window_width, change_window_heights)
7622 (Fdelete_window): Remove prototypes.
7623 (resize_frame_windows): Remove duplicate declaration.
7624
440a42e3
EZ
76252011-06-10 Eli Zaretskii <eliz@gnu.org>
7626
7627 * window.h (resize_frame_windows, resize_window_check)
7628 (delete_deletable_window, resize_root_window)
7629 (resize_frame_windows): Declare prototypes.
7630
7631 * window.c (resize_window_apply): Make definition be "static" to
7632 match the prototype.
7633
562dd5e9
MR
76342011-06-10 Martin Rudalics <rudalics@gmx.at>
7635
7636 * window.c: Remove declarations of Qwindow_size_fixed,
7637 window_min_size_1, window_min_size_2, window_min_size,
7638 size_window, window_fixed_size_p, enlarge_window, delete_window.
7639 Remove static from declaration of Qdelete_window, it's
7640 temporarily needed by Fbury_buffer.
7641 (replace_window): Don't assign orig_top_line and
7642 orig_total_lines.
7643 (Fdelete_window, delete_window): Remove. Window deletion is
7644 handled by window.el.
640c8776
SM
7645 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7646 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
7647 (Fdelete_other_windows): Remove. Deleting other windows is
7648 handled by window.el.
7649 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7650 handled in window.el.
7651 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7652 Window minimum sizes are handled in window.el.
7653 (shrink_windows, size_window, set_window_height)
7654 (set_window_width, change_window_heights, window_height)
7655 (window_width, CURBEG, CURSIZE, enlarge_window)
7656 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7657 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7658 handled in window.el.
7659 (make_dummy_parent): Rename to make_parent_window and give it a
7660 second argument horflag.
7661 (make_window): Don't set resize_proportionally any more.
7662 (Fsplit_window): Remove. Windows are split in window.el.
7663 (save_restore_action, save_restore_orig_size)
7664 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7665 Resize mini windows in window.el.
7666 (grow_mini_window, shrink_mini_window): Implement by calling
7667 Qresize_root_window_vertically, resize_window_check and
7668 resize_window_apply.
640c8776
SM
7669 (saved_window, Fset_window_configuration, save_window_save):
7670 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
7671 resize_proportionally.
7672 (window_min_height, window_min_width): Move to window.el.
7673 (keys_of_window): Move bindings for delete-other-windows,
7674 split-window, delete-window and enlarge-window to window.el.
7675
7676 * buffer.c: Temporarily extern Qdelete_window.
7677 (Fbury_buffer): Temporarily call Qdelete_window instead of
7678 Fdelete_window (Fbury_buffer will move to window.el soon).
7679
7680 * frame.c (set_menu_bar_lines_1): Remove code handling
7681 orig_top_line and orig_total_lines.
7682
7683 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7684 set_window_height but set heights directly.
7685 (change_frame_size_1): Use resize_frame_windows.
7686
7687 * xdisp.c (init_xdisp): Don't use set_window_height but set
7688 heights directly.
7689
640c8776
SM
7690 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7691 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
7692 run_window_configuration_change_hook.
7693
7694 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7695 instead of change_window_heights and run
7696 run_window_configuration_change_hook.
7697
1a13852e
MR
76982011-06-09 Martin Rudalics <rudalics@gmx.at>
7699
7700 * window.c (replace_window): Rename second argument REPLACEMENT to
7701 NEW. New third argument SETFLAG. Rewrite.
7702 (delete_window, make_dummy_parent): Call replace_window with
7703 third argument 1.
7704 (window_list_1): Move down in code.
7705 (run_window_configuration_change_hook): Move set_buffer part
7706 before select_frame_norecord part in order to unwind correctly.
7707 Rename count1 to count.
7708 (recombine_windows, delete_deletable_window, resize_root_window)
7709 (Fdelete_other_windows_internal)
7710 (Frun_window_configuration_change_hook, make_parent_window)
7711 (resize_window_check, resize_window_apply, Fresize_window_apply)
7712 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
7713 (Fdelete_window_internal, Fresize_mini_window_internal):
7714 New functions.
1a13852e
MR
7715 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7716
f3d1777e
MR
77172011-06-08 Martin Rudalics <rudalics@gmx.at>
7718
496e208e
MR
7719 * window.h (window): Add some new members to window structure -
7720 normal_lines, normal_cols, new_total, new_normal, clone_number,
7721 splits, nest, prev_buffers, next_buffers.
7722 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 7723 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 7724
f3d1777e
MR
7725 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7726 Remove.
496e208e
MR
7727 (make_dummy_parent): Set new members of windows structure.
7728 (make_window): Move down in code. Handle new members of window
7729 structure.
7730 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7731 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7732 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7733 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
7734 (Fset_window_next_buffers, Fset_window_clone_number):
7735 New functions.
496e208e
MR
7736 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7737 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7738 Doc-string fixes.
7739 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7740 Argument WINDOW can be now internal window too.
7741 (Fwindow_use_time): Move up in code.
7742 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7743 Rewrite doc-string.
7744 (Fset_window_configuration, saved_window)
7745 (Fcurrent_window_configuration, save_window_save): Handle new
7746 members of window structure.
b9e809c2
MR
7747 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7748 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7749 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7750 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7751 Qget_mru_window, Qresize_root_window,
7752 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7753 Qauto_buffer_name; staticpro them.
f3d1777e 7754
abde8f8c
MR
77552011-06-07 Martin Rudalics <rudalics@gmx.at>
7756
7757 * window.c (Fwindow_total_size, Fwindow_left_column)
7758 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7759 (Fwindow_list_1): New functions.
7760 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
7761 (Fwindow_width, Fscroll_left, Fscroll_right):
7762 Use window_body_cols instead of window_box_text_cols.
7763 (delete_window, Fset_window_configuration):
7764 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
7765 (delete_all_subwindows): Take a window as argument and not a
7766 structure. Rewrite.
190b47e6
MR
7767 (window_loop): Remove handling of GET_LRU_WINDOW and
7768 GET_LARGEST_WINDOW.
7769 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
7770
7771 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
7772 window_box_text_cols. delete_all_subwindows now takes a
7773 Lisp_Object as argument.
abde8f8c 7774
640c8776
SM
7775 * indent.c (compute_motion, Fcompute_motion):
7776 Use window_body_cols instead of window_box_text_cols.
abde8f8c 7777
fa8a67e6
MR
7778 * frame.c (delete_frame): Call delete_all_subwindows with root
7779 window as argument.
7780
a54e3482
DC
77812011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7782
7783 * fns.c (Fputhash): Document return value.
7784
60002bf5
CY
77852011-06-06 Chong Yidong <cyd@stupidchicken.com>
7786
7787 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7788
0c671da6 77892011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 7790
b862a52a 7791 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 7792
be44ca6c
PE
7793 Check for overflow when converting integer to cons and back.
7794 * charset.c (Fdefine_charset_internal, Fdecode_char):
7795 Use cons_to_unsigned to catch overflow.
7796 (Fencode_char): Use INTEGER_TO_CONS.
7797 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7798 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7799 * data.c (long_to_cons, cons_to_long): Remove.
7800 (cons_to_unsigned, cons_to_signed): New functions.
7801 These signal an error for invalid or out-of-range values.
7802 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7803 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7804 * font.c (Ffont_variation_glyphs):
7805 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7806 * lisp.h: Include <intprops.h>.
7807 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7808 (cons_to_signed, cons_to_unsigned): New decls.
7809 (long_to_cons, cons_to_long): Remove decls.
7810 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7811 (Fprimitive_undo): Use CONS_TO_INTEGER.
7812 * xfns.c (Fx_window_property): Likewise.
7813 * xselect.c: Include <limits.h>.
7814 (x_own_selection, selection_data_to_lisp_data):
7815 Use INTEGER_TO_CONS.
7816 (x_handle_selection_request, x_handle_selection_clear)
7817 (x_get_foreign_selection, Fx_disown_selection_internal)
7818 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7819 (lisp_data_to_selection_data): Use cons_to_unsigned.
7820 (x_fill_property_data): Use cons_to_signed.
7821 Report values out of range.
7822
d1f3d2af
PE
7823 Check for buffer and string overflow more precisely.
7824 * buffer.h (BUF_BYTES_MAX): New macro.
7825 * lisp.h (STRING_BYTES_MAX): New macro.
7826 * alloc.c (Fmake_string):
7827 * character.c (string_escape_byte8):
7828 * coding.c (coding_alloc_by_realloc):
7829 * doprnt.c (doprnt):
7830 * editfns.c (Fformat):
7831 * eval.c (verror):
7832 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7833 since they may not be the same number.
7834 * editfns.c (Finsert_char):
7835 * fileio.c (Finsert_file_contents):
7836 Likewise for BUF_BYTES_MAX.
7837
dd52fcea
PE
7838 * image.c: Use ptrdiff_t, not int, for sizes.
7839 (slurp_file): Switch from int to ptrdiff_t.
7840 All uses changed.
7841 (slurp_file): Check that file size fits in both size_t (for
7842 malloc) and ptrdiff_t (for sanity and safety).
7843
7f9bbdbb
PE
7844 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7845 if b->modtime has its maximal value.
7846
dfe18f82
PE
7847 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7848
84acfcf0
PE
7849 Don't assume time_t can fit into int.
7850 * buffer.h (struct buffer.modtime): Now time_t, not int.
7851 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7852 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7853
ccd9a01a
PE
7854 Minor fixes for signed vs unsigned integers.
7855 * character.h (MAYBE_UNIFY_CHAR):
7856 * charset.c (maybe_unify_char):
7857 * keyboard.c (read_char, reorder_modifiers):
7858 XINT -> XFASTINT, since the integer must be nonnegative.
7859 * ftfont.c (ftfont_spec_pattern):
7860 * keymap.c (access_keymap, silly_event_symbol_error):
7861 XUINT -> XFASTINT, since the integer must be nonnegative.
7862 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7863 since it makes no difference and we prefer signed.
7864 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7865 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7866 nonnegative.
7867
d6d100dd
SM
78682011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7869
7870 * window.h (Fwindow_frame): Declare.
7871
2b6148e4
PE
78722011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7873
7874 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7875 (SPARE_MEMORY): Always define.
7876 (LARGE_REQUEST): Remove.
7877 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7878
f230ecc9
MR
78792011-06-06 Martin Rudalics <rudalics@gmx.at>
7880
727e958e
MR
7881 * lisp.h: Move EXFUNS for Fframe_root_window,
7882 Fframe_first_window and Fset_frame_selected_window to window.h.
7883
7884 * window.h: Move EXFUNS for Fframe_root_window,
7885 Fframe_first_window and Fset_frame_selected_window here from
7886 lisp.h.
7887
7888 * frame.c (Fwindow_frame, Fframe_first_window)
7889 (Fframe_root_window, Fframe_selected_window)
7890 (Fset_frame_selected_window): Move to window.c.
7891 (Factive_minibuffer_window): Move to minibuf.c.
7892 (Fother_visible_frames_p): New function.
7893
7894 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7895
f230ecc9
MR
7896 * window.c (decode_window, decode_any_window): Move up in code.
7897 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7898 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
7899 (Fwindow_buffer): Move up and rewrite doc-string.
7900 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7901 (Fwindow_prev): New functions.
727e958e
MR
7902 (Fwindow_frame): Move here from frame.c. Accept any window as
7903 argument.
7904 (Fframe_root_window, Fframe_first_window)
7905 (Fframe_selected_window): Move here from frame.c. Accept frame
7906 or arbitrary window as argument. Update doc-strings.
7907 (Fminibuffer_window): Move up in code.
7908 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
7909 (Fset_frame_selected_window): Move here from frame.c.
7910 Marginal rewrite.
727e958e
MR
7911 (Fselected_window, select_window, Fselect_window): Move up in
7912 code. Minor doc-string fixes.
f230ecc9 7913
4d09bcf6
PE
79142011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7915
7916 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7917 Do not assume that spare memory exists; that assumption is valid
7918 only if SYSTEM_MALLOC.
7919 (LARGE_REQUEST): New macro, so that the issue of large requests
7920 is separated from the issue of spare memory.
7921
810928a2
AS
79222011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7923
172418ad
AS
7924 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7925 format. (Bug#8806)
7926
43f862f7
AS
7927 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7928
810928a2
AS
7929 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7930 before statements.
7931
a059fe24
JD
79322011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7933
7934 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7935
7936 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7937
7938 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7939 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7940
989bf368
JB
79412011-06-05 Juanma Barranquero <lekktu@gmail.com>
7942
7943 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7944
4b80f674
CY
79452011-06-04 Chong Yidong <cyd@stupidchicken.com>
7946
7947 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7948 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
7949 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7950 New error handlers.
4b80f674
CY
7951 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7952 Obey Vx_select_enable_clipboard_manager. Catch errors in
7953 x_clipboard_manager_save (Bug#8779).
7954 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 7955 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 7956
99a33b77 79572011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
7958
7959 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7960
99a33b77 79612011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
7962
7963 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7964 in the current matrix if keep_current_p is non-zero.
7965
8264569d
EZ
79662011-06-04 Eli Zaretskii <eliz@gnu.org>
7967
7968 * bidi.c (bidi_level_of_next_char): Fix last change.
7969
57f97249
EZ
79702011-06-03 Eli Zaretskii <eliz@gnu.org>
7971
fec2107c 7972 Support bidi reordering of text covered by display properties.
57f97249 7973
fec2107c
EZ
7974 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7975 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7976 (bidi_cache_search, bidi_cache_iterator_state)
7977 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
7978 (bidi_level_of_next_char, bidi_move_to_visually_next):
7979 Support character positions inside a run of characters covered by a
fec2107c
EZ
7980 display string.
7981 (bidi_paragraph_init, bidi_resolve_explicit_1)
7982 (bidi_level_of_next_char): Call bidi_fetch_char and
7983 bidi_fetch_char_advance instead of FETCH_CHAR and
7984 FETCH_CHAR_ADVANCE.
7985 (bidi_init_it): Initialize new members.
7986 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7987 definitions.
7988 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7989 instead of using explicit *_CHAR codes.
d6d100dd
SM
7990 (bidi_resolve_explicit, bidi_resolve_weak):
7991 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
7992 bidirectional text is supported only in multibyte buffers.
7993 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7994 it to initialize the frame_window_p member of struct bidi_it.
7995 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7996 (bidi_resolve_explicit, bidi_resolve_weak)
7997 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7998 bidi_it->nchars is non-positive.
7999 (bidi_level_of_next_char): Don't try to lookup the cache for the
8000 next/previous character if nothing is cached there yet, or if we
8001 were just reseat()'ed to a new position.
c40e2fb2 8002
0e14fe90
EZ
8003 * xdisp.c (set_cursor_from_row): Set start and stop points
8004 according to the row's direction when priming the loop that looks
8005 for the glyph on which to display cursor.
8006 (single_display_spec_intangible_p): Function deleted.
8007 (display_prop_intangible_p): Reimplement to call
8008 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8009 Accept 3 additional arguments needed by handle_display_spec.
8010 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8011 values: lists, `(when COND...)' forms, etc.
8012 (single_display_spec_string_p): Support property values that are
8013 lists with the argument STRING its top-level element.
8014 (display_prop_string_p): Fix the condition for processing a
8015 property that is a list to be consistent with handle_display_spec.
fec2107c 8016 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8017 last portion of handle_display_prop.
8018 (compute_display_string_pos): Accept additional argument
8019 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8020 value of a `display' property is a "replacing spec".
8021 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8022 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8023 the display property, but just return a value indicating whether
8024 the display property will replace the characters it covers.
8025 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8026 frame_window_p members of struct bidi_it.
d6d100dd
SM
8027 (compute_display_string_pos, compute_display_string_end):
8028 New functions.
fec2107c
EZ
8029 (push_it): Accept second argument POSITION, where pop_it should
8030 jump to continue iteration.
8031 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8032
fec2107c
EZ
8033 * keyboard.c (adjust_point_for_property): Adjust the call to
8034 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8035
8036 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8037 (bidi_init_it): Update prototypes.
8038 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8039 (compute_display_string_pos, compute_display_string_end):
8040 Declare prototypes.
fec2107c
EZ
8041 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8042 EMACS_INT.
fc6f18ce 8043
40087514 80442011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8045
57f53182
PE
8046 Malloc failure behavior now depends on size of allocation.
8047 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8048 * lisp.h: Change signatures accordingly.
8049 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8050 All callers changed. (Bug#8762)
8051
8052 * gnutls.c: Use Emacs's memory allocators.
8053 Without this change, the gnutls library would invoke malloc etc.
8054 directly, which causes problems on non-SYNC_INPUT hosts, and which
8055 runs afoul of improving memory_full behavior. (Bug#8761)
8056 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8057 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8058 xfree instead of the default malloc, realloc, free.
8059 (Fgnutls_boot): No need to check for memory allocation failure,
8060 since xmalloc does that for us.
8061
ac32cd99 8062 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8063 * category.c (hash_get_category_set):
8064 * ccl.c (ccl_driver):
8065 * charset.c (Fdefine_charset_internal):
8066 * charset.h (struct charset.hash_index):
8067 * composite.c (get_composition_id, gstring_lookup_cache)
8068 (composition_gstring_put_cache):
8069 * composite.h (struct composition.hash_index):
8070 * dispextern.h (struct image.hash):
8071 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8072 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8073 (hashfn_equal, hashfn_user_defined, make_hash_table)
8074 (maybe_resize_hash_table, hash_lookup, hash_put)
8075 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8076 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8077 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8078 * image.c (make_image, search_image_cache, lookup_image)
8079 (xpm_put_color_table_h):
8080 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8081 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8082 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8083 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8084 * alloc.c (allocate_vectorlike):
8085 Check for overflow in vector size calculations.
8086 * ccl.c (ccl_driver):
8087 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8088 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8089 need to be updated by these changes.
40087514
PE
8090 * fns.c (make_hash_table, maybe_resize_hash_table):
8091 Check for integer overflow with large hash tables.
0de4bb68
PE
8092 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8093 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8094 (SXHASH_REDUCE): New macro.
8095 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8096 Use it instead of discarding useful hash info with large hash values.
8097 (sxhash_float): New function.
8098 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8099 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8100 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8101 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8102 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8103 Adjust signatures to match updated version of code.
8104 (consing_since_gc): Now EMACS_INT, since a single hash table can
8105 use more than INT_MAX bytes.
8106
698d32e2
DN
81072011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8108
8109 Make it possible to build with GCC-4.6+ -O2 -flto.
8110
8111 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8112
fd6fa53f
SM
81132011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8114
8115 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8116 Call minibuffer-inactive-mode.
8117
864db017
JB
81182011-05-31 Juanma Barranquero <lekktu@gmail.com>
8119
8120 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8121 Update dependencies.
8122
2ad0baf4
DN
81232011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8124
8125 * data.c (init_data): Remove code for UTS, this system is not
8126 supported anymore.
8127
4fcc2638
DN
81282011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8129
8130 Don't force ./temacs to start in terminal mode.
8131
8132 * frame.c (make_initial_frame): Initialize faces in all cases, not
8133 only when CANNOT_DUMP is defined.
8134 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8135
c56e0fd5
DN
81362011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8137
8138 * dispnew.c (add_window_display_history): Use const for the string
8139 pointer. Remove declaration, not needed.
8140
333d54da 81412011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8142
55d4c1b2 8143 Use 'inline', not 'INLINE'.
333d54da 8144 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8145 * alloc.c, fontset.c (INLINE): Remove.
8146 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8147 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8148 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8149 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8150 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8151
738db178
DN
81522011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8153
8154 Make it possible to run ./temacs.
8155
8156 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8157 syms_of_callproc does the same thing. Remove test for
8158 "initialized", do it in the caller.
8159 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8160
620c53a6
SM
81612011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8162
8163 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8164 (read_minibuf): Use get_minibuffer.
8165 (syms_of_minibuf): Use DEFSYM.
8166 (Qmetadata): New var.
8167 * data.c (Qbuffer): Don't make it static.
8168 (syms_of_data): Use DEFSYM.
8169
e003a292
PE
81702011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8171
8172 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8173 (CCL_CODE_MIN): New macro.
8174
ed008a6d
PE
81752011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8176
3687c2ef
PE
8177 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8178
ed008a6d
PE
8179 * eval.c (Qdebug): Now static.
8180 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8181 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8182 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8183
d66c4c7c
CY
81842011-05-29 Chong Yidong <cyd@stupidchicken.com>
8185
8186 * image.c: Various fixes to ImageMagick code comments.
8187 (Fimagemagick_types): Doc fix.
8188
5fbc2025
PE
81892011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8190
0196f88a
PE
8191 Minor fixes prompted by GCC 4.6.0 warnings.
8192
8193 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8194
5fbc2025
PE
8195 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8196 (x_clipboard_manager_save_all): Move extern decl to ...
8197 * xterm.h: ... here, so that it can be checked for consistency.
8198
1dd3c2d9
CY
81992011-05-29 Chong Yidong <cyd@stupidchicken.com>
8200
8201 * xselect.c (x_clipboard_manager_save_frame)
8202 (x_clipboard_manager_save_all): New functions.
8203 (Fx_clipboard_manager_save): Lisp function deleted.
8204
8205 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8206 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8207
8208 * xterm.h: Update prototype.
8209
5ba6571d
WX
82102011-05-28 William Xu <william.xwl@gmail.com>
8211
8212 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8213 exiting (Bug#8239).
8214
3eaff834
JM
82152011-05-28 Jim Meyering <meyering@redhat.com>
8216
e1900994 8217 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8218 * fns.c (to_uchar): Define.
8219 (crypto_hash_function): Use it to convert some newly-signed
8220 variables to unsigned, to avoid sign-extension bugs. For example,
8221 without this change, (md5 "truc") would evaluate to
8222 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8223 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8224 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8225
0f6990a7
PE
82262011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8227
8228 Integer overflow fixes.
c8a9ca5a 8229
08686060
PE
8230 * dbusbind.c: Serial number integer overflow fixes.
8231 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8232 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8233 to hold a serial number that is too large for a fixnum.
8234 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8235 Check for serial numbers out of range. Decode any serial number
59568bf0 8236 that was so large that it became a float. (Bug#8722)
08686060 8237
2d1fc3c7
PE
8238 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8239 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8240 Use XFASTINT rather than XUINT when numbers are nonnegative.
8241 (xd_append_arg, Fdbus_method_return_internal):
8242 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8243 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8244 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8245 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8246 (Bug#8722)
2d1fc3c7 8247
c8a9ca5a
PE
8248 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8249
519e1d69
PE
8250 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8251
6df6ae42 8252 ccl: Add integer overflow checks.
30569699
PE
8253 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8254 (IN_INT_RANGE): New macros.
8255 (ccl_driver): Use them to check for integer overflow when
8256 decoding a CCL program. Many of the new checks are whether XINT (x)
8257 fits in int; it doesn't always, on 64-bit hosts. The new version
8258 doesn't catch all possible integer overflows, but it's an
847044ea 8259 improvement. (Bug#8719)
30569699 8260
c11285dc
PE
8261 * alloc.c (make_event_array): Use XINT, not XUINT.
8262 There's no need for unsigned here.
8263
fdccd48e
PE
8264 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8265 This follows up to the 2011-05-06 change that substituted uintptr_t
8266 for EMACS_INT. This case wasn't caught back then.
8267
37910ab2
PE
8268 Rework Fformat to avoid integer overflow issues.
8269 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8270 now (part of C89). Include <verify.h>.
8271 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8272 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8273 (Fformat): Avoid the prepass trying to compute sizes; it was only
8274 approximate and thus did not catch overflow reliably. Instead, walk
8275 through the format just once, formatting and computing sizes as we go,
8276 checking for integer overflow at every step, and allocating a larger
8277 buffer as needed. Keep track separately whether the format is
8278 multibyte. Keep only the most-recently calculated precision, rather
8279 than them all. Record whether each argument has been converted to
8280 string. Use EMACS_INT, not int, for byte and char and arg counts.
8281 Support field widths and precisions larger than INT_MAX. Avoid
8282 sprintf's undefined behavior with conversion specifications such as %#d
8283 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8284 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8285 formatting out-of-range floating point numbers with int
9173deec 8286 formats. (Bug#8668)
37910ab2 8287
2e6578fb
PE
8288 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8289
0ae6bdee
PE
8290 * data.c: Avoid integer truncation in expressions involving floats.
8291 * data.c: Include <intprops.h>.
8292 (arith_driver): When there's an integer overflow in an expression
8293 involving floating point, convert the integers to floating point
8294 so that the resulting value does not suffer from catastrophic
8295 integer truncation. For example, on a 64-bit host (* 4
8296 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8297 Do not rely on undefined behavior after integer overflow.
8298
de883a70
PE
8299 merge count_size_as_multibyte, parse_str_to_multibyte
8300 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8301 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8302 Check for integer overflow.
8303 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8304 since it's now a duplicate of the other. This is more of
8305 a character than a buffer op, so better that it's in character.c.
8306 * fns.c, print.c: Adjust to above changes.
8307
2ff916cb
PE
83082011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8309
8310 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8311
f1b54466
PE
83122011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8313
fb1ac845
PE
8314 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8315 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8316 (x_clipboard_manager_save): Now static.
8317 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8318
f1b54466
PE
8319 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8320 (crypto_hash_function): Now static.
8321 Fix pointer signedness problems. Avoid unnecessary initializations.
8322
a9f737ee
CY
83232011-05-27 Chong Yidong <cyd@stupidchicken.com>
8324
8325 * termhooks.h (Vselection_alist): Make it terminal-local.
8326
8327 * terminal.c (create_terminal): Initialize it.
8328
8329 * xselect.c: Support for clipboard managers.
8330 (Vselection_alist): Move to termhooks.h as terminal-local var.
8331 (LOCAL_SELECTION): New macro.
8332 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8333 (symbol_to_x_atom): Remove gratuitous arg.
8334 (x_handle_selection_request, lisp_data_to_selection_data)
8335 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8336 (x_own_selection, x_get_local_selection, x_convert_selection):
8337 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8338 (some_frame_on_display): Delete unused function.
8339 (Fx_own_selection_internal, Fx_get_selection_internal)
8340 (Fx_disown_selection_internal, Fx_selection_owner_p)
8341 (Fx_selection_exists_p): New optional frame arg.
8342 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8343 (x_handle_selection_clear): Don't treat other terminals with the
8344 same keyboard specially. Use the terminal-local Vselection_alist.
8345 (x_clear_frame_selections): Use Frun_hook_with_args.
8346
8347 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8348
8349 * xterm.h: Add support for those atoms.
8350
e067f0c1
CY
83512011-05-26 Chong Yidong <cyd@stupidchicken.com>
8352
8353 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8354 (converted_selections, conversion_fail_tag): New global variables.
8355 (x_selection_request_lisp_error): Free the above.
8356 (x_get_local_selection): Remove unnecessary code.
8357 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8358 of converted selections stored in converted_selections.
8359 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8360 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8361 (x_convert_selection): New function.
8362 (x_handle_selection_event): Simplify.
8363 (x_get_foreign_selection): Don't ignore incoming requests while
8364 waiting for an answer; this will fail when we implement
8365 SAVE_TARGETS, and seems unnecessary anyway.
8366 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8367 (Vx_sent_selection_functions): Doc fix.
8368
0f4aebc0
LL
83692011-05-26 Leo Liu <sdl.web@gmail.com>
8370
8371 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8372
e61124cd
YM
83732011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8374
8375 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8376
8377 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8378 for fringe update if it has periodic bitmap.
ac389d0c 8379 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8380 and fringe_bitmap_periodic_p.
8381
8382 * fringe.c (get_fringe_bitmap_data): New function.
8383 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8384 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8385 row. Mark glyph row for fringe update if periodicity changed.
8386
8387 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8388 for fringe update unless it has periodic bitmap.
8389
f16d9837
KH
83902011-05-25 Kenichi Handa <handa@m17n.org>
8391
8392 * xdisp.c (get_next_display_element): Set correct it->face_id for
8393 a static composition.
8394
e1b90ef6
LL
83952011-05-24 Leo Liu <sdl.web@gmail.com>
8396
8397 * deps.mk (fns.o):
8398 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8399
8400 * fns.c (crypto_hash_function, Fsha1): New function.
8401 (Fmd5): Use crypto_hash_function.
8402 (syms_of_fns): Add Ssha1.
8403
7400048f
PE
84042011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8405
8406 * gnutls.c: Remove unused macros.
8407 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8408 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8409 Remove macros that are defined and never used.
8410 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8411
abb71cf4
CY
84122011-05-22 Chong Yidong <cyd@stupidchicken.com>
8413
8414 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8415 (Fx_get_selection_internal): Minor cleanup.
8416 (Fx_own_selection_internal): Rename arguments for consistency with
8417 select.el.
8418
6307db39
PE
84192011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8420
8421 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8422
f3d4e0a4
CY
84232011-05-22 Chong Yidong <cyd@stupidchicken.com>
8424
8425 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8426
4d8ade89
YM
84272011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8428
8429 * dispnew.c (scrolling_window): Don't exclude the case that the
8430 last enabled row in the desired matrix touches the bottom boundary.
8431
32078c8d
GM
84322011-05-21 Glenn Morris <rgm@gnu.org>
8433
8434 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8435 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8436 and add some more files.
32078c8d 8437
7285dc67
EZ
84382011-05-20 Eli Zaretskii <eliz@gnu.org>
8439
8440 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8441 report_file_error introduced by the change from 2011-05-07.
8442
89d1bd22
PE
84432011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8444
8445 * systime.h (Time): Define only if emacs is defined.
8446 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8447 where the include path doesn't have X11/X.h by default. See
8448 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8449
cd394be1 84502011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8451
8452 * composite.c (find_automatic_composition): Fix previous change.
8453
b9704ad9
GM
84542011-05-20 Glenn Morris <rgm@gnu.org>
8455
8456 * lisp.mk: New file, split from Makefile.in.
8457 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8458 (shortlisp): Remove.
8459 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8460
4a720484
GM
84612011-05-19 Glenn Morris <rgm@gnu.org>
8462
8463 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8464 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8465 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8466 (lisp): Set the order to that of loadup.el.
8467 (shortlisp): Make it a copy of $lisp.
8468 (SOME_MACHINE_LISP): Remove.
8469 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8470 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8471
a28d4396
KH
84722011-05-18 Kenichi Handa <handa@m17n.org>
8473
8474 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8475 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8476 (find_automatic_composition): Mostly rewrite for efficiency.
8477
a2b1fa8e
JB
84782011-05-18 Juanma Barranquero <lekktu@gmail.com>
8479
8480 * makefile.w32-in: Update dependencies.
8481
8e1f5610
CS
84822011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8483
8484 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8485 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8486
7025ee00 84872011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8488
cdfa6eab
PE
8489 Fix some integer overflow issues, such as string length overflow.
8490
06d6db33
PE
8491 * insdel.c (count_size_as_multibyte): Check for string overflow.
8492
2b4560a8
PE
8493 * character.c (lisp_string_width): Check for string overflow.
8494 Use EMACS_INT, not int, for string indexes and lengths; in
8495 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8496 the resulting string length overflows an EMACS_INT; instead,
8497 report a string overflow if no precision given. When checking for
8498 precision exhaustion, use a check that cannot possibly have
8499 integer overflow. (Bug#8675)
8500 * character.h (lisp_string_width): Adjust to new signature.
8501
cb93f9be
PE
8502 * alloc.c (string_overflow): New function.
8503 (Fmake_string): Use it. This doesn't change behavior, but saves
8504 a few bytes and will simplify future changes.
8505 * character.c (string_escape_byte8): Likewise.
8506 * lisp.h (string_overflow): New decl.
8507
1a1f3366
PE
8508 Fixups, following up to the user-interface timestamp change.
8509 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8510 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8511 * msdos.c (mouse_get_pos): Likewise.
8512 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8513 * w32gui.h (Time): Define by including "systime.h" rather than by
8514 declaring it ourselves. (Bug#8664)
8515
d4e3e4d3
PE
8516 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8517 * image.c (clear_image_cache): Likewise.
8518
f6a24d19
PE
8519 * term.c (term_mouse_position): Don't assume time_t wraparound.
8520
08dc5ae6
PE
8521 Be more systematic about user-interface timestamps.
8522 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8523 and sometimes 'EMACS_UINT', to represent these timestamps.
8524 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8525 This makes the code easier to follow, and makes it easier to catch
8526 integer overflow bugs such as Bug#8664.
8527 * frame.c (Fmouse_position, Fmouse_pixel_position):
8528 Use Time, not unsigned long, for user-interface timestamps.
8529 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8530 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8531 * keyboard.h (last_event_timestamp): Likewise.
8532 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8533 * menu.h (xmenu_show): Likewise.
8534 * term.c (term_mouse_position): Likewise.
8535 * termhooks.h (struct input_event.timestamp): Likewise.
8536 (struct terminal.mouse_position_hook): Likewise.
8537 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8538 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8539 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8540 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8541 what it was before.
8542 * menu.h, termhooks.h: Include "systime.h", for Time.
8543
8e55734a
PE
8544 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8545 Don't assume that the difference between two unsigned long values
8546 can fit into an integer. At this point, we know button_down_time
8547 <= event->timestamp, so the difference must be nonnegative, so
8548 there's no need to cast the result if double-click-time is
8549 nonnegative, as it should be; check that it's nonnegative, just in
8550 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8551 apart (about 25 days). (Bug#8664)
8e55734a 8552
841f1b75 8553 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8554 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8555
3e26f69c
PE
8556 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8557 that always fit in int. Use a sentinel instead of a counter, to
8558 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8559 * frame.h (struct frame): Use int for menu_bar_items_used
8560 instead of EMACS_INT, since it always fits in int.
3e26f69c 8561
5cc152c0
PE
8562 * menu.c (grow_menu_items): Check for int overflow.
8563
d89eb65e
PE
8564 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8565
5235bd3e
PE
8566 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8567 Before, the code was not consistent. These values cannot exceed
8568 2**31 - 1 so there's no need to make them unsigned.
8569 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8570 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8571 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8572 as modifiers.
8573 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8574
bc827e23
PE
8575 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8576 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8577 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8578 presumably because the widths might not match.
8579
78eb494e
PE
8580 * window.c (size_window): Avoid needless test at loop start.
8581
04f2d78b
CB
85822011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8583
8584 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8585
d2fc7e3d 85862011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
8587
8588 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8589
d2fc7e3d 85902011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
8591
8592 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8593 `width' to `bar_area_x' and `bar_area_width', respectively.
8594 (x_scroll_run): Take account of fringe background extension.
8595
04f2d78b
CB
8596 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8597 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
8598 `bar_area_width', respectively.
8599 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8600 background extension.
8601
79b70037
GM
86022011-05-10 Jim Meyering <meyering@redhat.com>
8603
8604 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8605
2f142cc5
JB
86062011-05-10 Juanma Barranquero <lekktu@gmail.com>
8607
8608 * image.c (Finit_image_library): Return t for built-in image types,
8609 like pbm and xbm. (Bug#8640)
8610
57679c86
AS
86112011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8612
8613 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8614
888c9e86
EZ
86152011-05-07 Eli Zaretskii <eliz@gnu.org>
8616
b0512a1d
EZ
8617 * w32console.c (Fset_screen_color): Doc fix.
8618 (Fget_screen_color): New function.
8619 (syms_of_ntterm): Defsubr it.
8620
7285dc67
EZ
8621 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8622 unlink the temporary file if Fcall_process didn't create it in the
8623 first place.
8624 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8625 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
8626 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8627 cue to call_process_cleanup not to close that handle.
8628
4d3fcc8e
BK
86292011-05-07 Ben Key <bkey76@gmail.com>
8630
8631 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8632 one of two shell specific rules, either bootstrap-temacs-CMD or
8633 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8634 to the previous implementation of the bootstrap-temacs rule.
8635 The bootstrap-temacs-CMD rule is similar to the previous
8636 implementation of the bootstrap-temacs rule except that it
8637 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8638 variable.
8639
8640 These changes, along with some changes to nt/configure.bat,
8641 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8642 earlier fix to add support for --cflags and --ldflags options
8643 that include quotes so that it works whether make uses cmd or
8644 sh as the shell.
8645
b4289b64
MA
86462011-05-06 Michael Albinus <michael.albinus@gmx.de>
8647
8648 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8649 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8650 is a constant.
8651 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8652 a string. Handle both cases.
8653 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8654 (Fdbus_register_method): Use Qinvalid_function.
8655
af4c0e28
JB
86562011-05-06 Juanma Barranquero <lekktu@gmail.com>
8657
8658 * makefile.w32-in: Update dependencies.
8659 (LISP_H): Add inttypes.h and stdin.h.
8660 (PROCESS_H): Add unistd.h.
8661
c51453d9
EZ
86622011-05-06 Eli Zaretskii <eliz@gnu.org>
8663
8664 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8665 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8666
8ff0ac3c 86672011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 8668
4c4b566b
PE
8669 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8670
aab2b9b5
PE
8671 * term.c (vfatal): Remove stray call to va_end.
8672 It's not needed and the C Standard doesn't allow it here anyway.
8673
c378da0b
PE
8674 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8675 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8676
288b08c7
PE
8677 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8678 bytes.
8679
e3601888
PE
8680 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8681
db6c0e74
PE
8682 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8683
dd5963ea
PE
8684 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8685
88c9450f
PE
8686 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8687
2f9442b8
PE
8688 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8689
c032b5f8
PE
8690 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8691 * charset.c (Fdefine_charset_internal): Don't initialize
8692 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 8693 32-bit int (Bug#8600).
a108c10b
PE
8694
8695 * lread.c (read_integer): Be more consistent with string-to-number.
8696 Use string_to_number to do the actual conversion; this avoids
8697 rounding errors and fixes some other screwups. Without this fix,
8698 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8699 (digit_to_number): Move earlier, for benefit of read_integer.
8700 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 8701 not a digit in any supported base. (Bug#8602)
a108c10b 8702
ad5f9eea
PE
8703 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8704
aec1708a
PE
8705 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8706 to match comment at start of function. This also removes a
8707 GCC warning about overflow in a 32+64-bit port.
8708
47be4ab5
PE
8709 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8710
371cac43
PE
8711 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8712 Reported by Stefan Monnier in
8713 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
8714 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8715 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 8716
d01a7826
PE
8717 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8718 (EMACS_UINTPTR): Likewise, with uintptr_t.
8719
7fd47d5c
PE
8720 * lisp.h: Prefer 64-bit EMACS_INT if available.
8721 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8722 on 32-bit hosts that have 64-bit int, so that they can access
8723 large files.
122b0c86
PE
8724 However, temporarily disable this change unless the temporary
8725 symbol WIDE_EMACS_INT is defined.
7fd47d5c 8726
8727937b
PE
8727 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8728
8ac068ac
PE
8729 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8730 This removes an assumption that EMACS_INT and long are the same
8731 width as pointers. The assumption is true for Emacs porting targets
8732 now, but we want to make other targets possible.
8733 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8734 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8735 In the rest of the code, change types of integers that hold casted
8736 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8737 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8738 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8739 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8740 No need to cast type when ORing.
8741 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8742 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8743 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8744 assume EMACS_INT is the same width as char *.
8745 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8746 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8747 Remove no-longer-needed casts.
8748 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8749 (xg_tool_bar_help_callback, xg_make_tool_item):
8750 Use EMACS_INTPTR to hold an integer
8751 that will be cast to void *; this can avoid a GCC warning
8752 if EMACS_INT is not the same width as void *.
8753 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8754 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8755 (current_message_1, set_message_1):
8756 Use a local to convert to proper width without a cast.
8757 * xmenu.c (dialog_selection_callback): Likewise.
8758
ede49d71
PE
8759 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8760 Also, don't assume VALBITS / RAND_BITS is less than 5,
8761 and don't rely on undefined behavior when shifting a 1 left into
8762 the sign bit.
8763 * lisp.h (get_random): Change signature to match.
8764
2f30ecd0
PE
8765 * lread.c (hash_string): Use size_t, not int, for hash computation.
8766 Normally we prefer signed values; but hashing is special, because
8767 it's better to use unsigned division on hash table sizes so that
8768 the remainder is nonnegative. Also, size_t is the natural width
8769 for hashing into memory. The previous code used 'int', which doesn't
8770 retain enough info to hash well into very large tables.
8771 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8772
2a866e7b
PE
8773 * dbusbind.c: Don't possibly lose pointer info when converting.
8774 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8775 Use XPNTR rather than XHASH, so that the high-order bits of
8776 the pointer aren't lost when converting through void *.
8777
51639eac
PE
8778 * eval.c (Fautoload): Don't double-shift a pointer.
8779
92394119
PE
8780 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8781
dbdb9a7c
JB
87822011-05-06 Juanma Barranquero <lekktu@gmail.com>
8783
8784 * gnutls.c (DEF_GNUTLS_FN):
8785 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8786
db7a0b4f
AS
87872011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8788
8789 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8790 marker. (Bug#8610)
8791
cd394be1 87922011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
8793
8794 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8795 New version that can reserve upto 2GB of heap space.
8796
f7ff1b0f 87972011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
8798
8799 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8800
639c109b
TZ
88012011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8802
8803 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8804 `gnutls_certificate_set_x509_key_file'.
8805
d2127135
JB
88062011-05-05 Juanma Barranquero <lekktu@gmail.com>
8807
8808 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8809 Update dependencies.
8810
e968f4f3
JB
88112011-05-04 Juanma Barranquero <lekktu@gmail.com>
8812
8813 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8814 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8815 Remove unused parameter `fildes'.
8816 * process.c (read_process_output, send_process): Don't pass it.
8817
84d358f0
JB
88182011-05-04 Juanma Barranquero <lekktu@gmail.com>
8819
8820 Fix previous change: the library cache is defined in w32.c.
8821 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8822 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8823
0898ca10
JB
88242011-05-04 Juanma Barranquero <lekktu@gmail.com>
8825
8826 Implement dynamic loading of GnuTLS on Windows.
8827
8828 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8829 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8830 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8831 Declare.
8832
8833 * gnutls.c (Qgnutls_dll): Define.
8834 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8835 (gnutls_*): Declare function pointers.
8836 (init_gnutls_functions): New function to initialize function pointers.
8837 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8838 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8839 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8840 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8841 (emacs_gnutls_write, emacs_gnutls_read)
8842 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8843 (Fgnutls_available_p): New function.
8844 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8845 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8846 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8847
8848 * image.c: Include w32.h.
8849 (Vimage_type_cache): Delete.
8850 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8851 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8852 (w32_delayed_load): Move to w32.c.
8853
8854 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8855
8856 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8857 (w32_delayed_load): Move from image.c. When loading a library, record
8858 its filename in the :loaded-from property of the library id.
8859 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8860 Initialize and staticpro them.
8861 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8862
8863 * process.c: Include lisp.h before w32.h, not after.
8864 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8865 instead of gnutls_record_check_pending.
8866
8867 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8868
ff4de4aa
TZ
88692011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8870
8871 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8872 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8873 as passed in.
8874
abe95abb
JD
88752011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8876
8877 * xterm.c (x_set_frame_alpha): Do not set property on anything
8878 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8879
e16e55d4
JB
88802011-05-02 Juanma Barranquero <lekktu@gmail.com>
8881
8882 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8883
bafcf6a5
JB
88842011-05-02 Juanma Barranquero <lekktu@gmail.com>
8885
8886 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8887 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8888 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8889 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8890 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8891 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8892 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8893 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8894 (Qgnutls_bootprop_callbacks_verify): Make static.
8895
e7a6747f
AS
88962011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8897
19ed11ba
AS
8898 * callproc.c: Indentation fixup.
8899
e7a6747f 8900 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
8901 (wait_for_termination, interruptible_wait_for_termination):
8902 Move after wait_for_termination_1.
e7a6747f 8903
1ef14cb4
LMI
89042011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8905
8906 * sysdep.c (interruptible_wait_for_termination): New function
8907 which is like wait_for_termination, but allows keyboard
8908 interruptions.
8909
8910 * callproc.c (Fcall_process): Add (:file "file") as an option for
8911 the STDOUT buffer.
8912 (Fcall_process_region): Ditto.
8913
330d880c
EZ
89142011-04-30 Eli Zaretskii <eliz@gnu.org>
8915
8db90b73
EZ
8916 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8917 rather than `XVECTOR (FOO)->size'.
8918
330d880c
EZ
8919 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8920 inttypes.h, as a gnulib replacement is used if it not available in
8921 system headers.
8922
15cbd324
EZ
89232011-04-21 Eli Zaretskii <eliz@gnu.org>
8924
8925 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8926 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8927 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8928
8929 * coding.c (coding_alloc_by_realloc): Error out if destination
8930 will grow beyond MOST_POSITIVE_FIXNUM.
8931 (decode_coding_emacs_mule): Abort if there isn't enough place in
8932 charbuf for the composition carryover bytes. Reserve an extra
8933 space for up to 2 characters produced in a loop.
8934 (decode_coding_iso_2022): Abort if there isn't enough place in
8935 charbuf for the composition carryover bytes.
8936
89372011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 8938
ae940cca
EZ
8939 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8940 aborting when %lld or %lll format is passed.
8941 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8942 %llo or %llx format is passed. (Bug#8545)
8943
03ab8921
EZ
8944 * window.c (window_scroll_line_based): Use a marker instead of
8945 simple variables to record original value of point. (Bug#7952)
8946
afda1437
EZ
8947 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8948 produced by %s or %c overflows available buffer space. (Bug#8545)
8949
f76dee0c
PE
89502011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8951
8952 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 8953 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 8954
fdc5744d
JB
89552011-04-28 Juanma Barranquero <lekktu@gmail.com>
8956
8957 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8958
638f053a
JB
89592011-04-28 Juanma Barranquero <lekktu@gmail.com>
8960
8961 * keyboard.c (Qdelayed_warnings_hook): Define.
8962 (command_loop_1): Run `delayed-warnings-hook'
8963 if Vdelayed_warnings_list is non-nil.
8964 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8965 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8966
d178f871
EZ
89672011-04-28 Eli Zaretskii <eliz@gnu.org>
8968
8969 * doprnt.c (doprnt): Don't return value smaller than the buffer
8970 size if the message was truncated. (Bug#8545).
8971
b124fd93
JB
89722011-04-28 Juanma Barranquero <lekktu@gmail.com>
8973
8974 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8975 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8976
e810457d
PE
89772011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8978
8979 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8980
ea51cceb
JB
89812011-04-27 Juanma Barranquero <lekktu@gmail.com>
8982
8983 * makefile.w32-in: Update dependencies.
8984
94dcfacf
EZ
89852011-04-27 Eli Zaretskii <eliz@gnu.org>
8986
8987 Improve `doprnt' and its usage. (Bug#8545)
8988 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8989 `format_end'. Remove support for %l as a conversion specifier.
8990 Don't use xrealloc. Improve diagnostics when the %l size modifier
8991 is used. Update the commentary.
8992
8993 * eval.c (verror): Simplify calculation of size_t.
8994
8995 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8996 messages.
8997
f61f41d7
PE
89982011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8999
9000 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9001 change.
9002
96fb4434
PE
90032011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9004
9005 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9006 This makes this file independent of the recent pseudovector change.
9007
671875da 90082011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9009
69e9b5a3
PE
9010 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9011
b5f869a7 9012 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9013 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9014 Remove unused local.
c8926152 9015 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9016
841a1577 9017 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9018 GCC 4.6.0 optimizes based on type-based alias analysis.
9019 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9020 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9021 != &v->size, and therefore "v->size = 1; b->size = 2; return
9022 v->size;" must therefore return 1. This assumption is incorrect
9023 for Emacs, since it type-puns struct Lisp_Vector * with many other
9024 types. To fix this problem, this patch adds a new type struct
f904488f 9025 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9026 and pseudovectors, and helps optimizing compilers not get fooled
9027 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9028 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9029 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9030 the size member.
eab3844f
PE
9031 (XSETPVECTYPE): Rewrite in terms of new macro.
9032 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9033 This is a bit clearer, and further avoids the possibility of
9034 undesirable aliasing.
9035 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9036 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9037 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9038 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9039 (ASIZE): Now uses header.size rather than size.
9040 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9041 to avoid the hassle of writing XVECTOR (foo)->header.size.
9042 (struct vectorlike_header): New type.
eab3844f
PE
9043 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9044 object, to help avoid aliasing.
9045 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9046 (SUBRP): Likewise, since Lisp_Subr is a special case.
9047 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9048 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9049 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9050 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9051 changed to be "header.size" and "header.next".
9052 * buffer.h (struct buffer): Likewise.
9053 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9054 * frame.h (struct frame): Likewise.
9055 * process.h (struct Lisp_Process): Likewise.
9056 * termhooks.h (struct terminal): Likewise.
9057 * window.c (struct save_window_data, struct saved_window): Likewise.
9058 * window.h (struct window): Likewise.
9059 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9060 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9061 * buffer.c (init_buffer_once): Likewise.
9062 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9063 special case.
9064 * process.c (Fformat_network_address): Use local var for size,
9065 for brevity.
9066
0df1eac5
PE
9067 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9068
847ab9d1 9069 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9070 * data.c (atof): Remove decl; no longer used or needed.
9071 (digit_to_number): Move to lread.c.
9072 (Fstring_to_number): Use new string_to_number function, to be
9073 consistent with how the Lisp reader treats infinities and NaNs.
9074 Do not assume that floating-point numbers represent EMACS_INT
9075 without losing information; this is not true on most 64-bit hosts.
9076 Avoid double-rounding errors, by insisting on integers when
9077 parsing non-base-10 numbers, as the documentation specifies.
9078 * lisp.h (string_to_number): New decl, replacing ...
9079 (isfloat_string): Remove.
bc0a5c13 9080 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9081 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9082 appears to have been a coding error. Similarly, do not accept
9083 strings like +-1e0 as floating point numbers. Do not report
9084 overflow for integer overflows unless the base is not 10 which
9085 means we have no simple and reliable way to continue.
9086 Break out the floating-point parsing into a new
9087 function string_to_number, so that Fstring_to_number parses
9088 floating point numbers consistently with the Lisp reader.
04f2d78b 9089 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9090 (E_CHAR, EXP_INT): Remove, replacing with ...
9091 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9092 (string_to_number): New function, replacing isfloat_string.
9093 This function checks for valid syntax and produces the resulting
9094 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9095 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9096 so that overflow for non-base-10 numbers is reported only when
9097 there's no portable and simple way to convert to floating point.
452f4150 9098
67769ffc
PE
9099 * textprop.c (set_text_properties_1): Rewrite for clarity,
9100 and to avoid GCC warning about integer overflow.
9101
c20db43f
PE
9102 * intervals.h (struct interval): Use EMACS_INT for members
9103 where EMACS_UINT might cause problems. See
9104 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9105 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9106 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9107 All uses changed.
37aa2f85
PE
9108 (offset_intervals): Tell GCC not to worry about length overflow
9109 when negating a negative length.
c20db43f 9110
2538aa2f
PE
9111 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9112 (overrun_check_free): Likewise.
9113
f2d3008d
PE
9114 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9115 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9116 word size.
9117
ec8df744
PE
9118 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9119 (gnutls_make_error): Rename local to avoid shadowing.
9120 (gnutls_emacs_global_deinit): ifdef out; not used.
9121 (Fgnutls_boot): Use const for pointer to readonly storage.
9122 Comment out unused local. Fix pointer signedness problems.
9123
640ee02d
PE
9124 * lread.c (openp): Don't stuff size_t into an 'int'.
9125 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9126 about possible signed overflow.
9127
6048fb2a
PE
9128 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9129 (GDK_KEY_g): Don't define if already defined.
9130 (xg_prepare_tooltip): Avoid pointer signedness problem.
9131 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9132
fa3c87e1
PE
9133 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9134 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9135
2172544b
PE
9136 * xfns.c (Fx_window_property): Simplify a bit,
9137 to make a bit faster and to avoid GCC 4.6.0 warning.
9138 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9139
9b821a21
PE
9140 * fns.c (internal_equal): Don't assume size_t fits in int.
9141
3c616cfa
PE
9142 * alloc.c (compact_small_strings): Tighten assertion a little.
9143
c2982e87
PE
9144 Replace pEd with more-general pI, and fix some printf arg casts.
9145 * lisp.h (pI): New macro, generalizing old pEd macro to other
9146 conversion specifiers. For example, use "...%"pI"d..." rather
9147 than "...%"pEd"...".
9148 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9149 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9150 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9151 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9152 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9153 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9154 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9155 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9156 64-bit hosts.
9157 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9158 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9159 * print.c (safe_debug_print, print_object): Likewise.
9160 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9161 to int.
6f04d126
PE
9162 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9163 avoiding the 0 flag, which is not portable.
c2982e87
PE
9164 * process.c (Fmake_network_process): Use pI to avoid cast.
9165 * region-cache.c (pp_cache): Likewise.
9166 * xdisp.c (decode_mode_spec): Likewise.
9167 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9168 behavior on 64-bit hosts with printf arg.
6f04d126 9169 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9170 (x_stop_queuing_selection_requests): Likewise.
9171 (x_get_window_property): Don't truncate byte count to an 'int'
9172 when tracing.
0b432f21 9173
5e073ec7
PE
9174 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9175 here, since it parses constructs like leading '-' and spaces,
9176 which are not wanted; and it overflows with large numbers.
9177 Instead, simply match F[0-9]+, which is what is wanted anyway.
9178
36372bf9
PE
9179 * alloc.c: Remove unportable assumptions about struct layout.
9180 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9181 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9182 (allocate_vectorlike, make_pure_vector): Use the new macros,
9183 plus offsetof, to remove unportable assumptions about struct layout.
9184 These assumptions hold on all porting targets that I know of, but
9185 they are not guaranteed, they're easy to remove, and removing them
9186 makes further changes easier.
9187
0b432f21
PE
9188 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9189 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9190 (string_overrun_cookie): Now const. Use initializers that
9191 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9192 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9193 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9194 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9195 multiple of sizeof (EMACS_INT); it need not be, if
9196 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9197 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9198
895009e1
JB
91992011-04-26 Juanma Barranquero <lekktu@gmail.com>
9200
9201 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9202
6a7a1b0b
TZ
92032011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9204
9205 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9206 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9207 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9208
841a1577 92092011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9210
9211 * lisp.h (Qdebug): List symbol.
895009e1 9212 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9213 * keyboard.c (debug-on-event): New variable.
9214 (handle_user_signal): Break into debugger when debug-on-event
9215 matches the current signal symbol.
9216
f2d3ba6f
DN
92172011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9218
9219 * alloc.c (check_sblock, check_string_bytes)
9220 (check_string_free_list): Convert to standard C.
9221
42ce4c63
TZ
92222011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9223
9224 * w32.c (emacs_gnutls_push): Fix typo.
9225
825cd63c
EZ
92262011-04-25 Eli Zaretskii <eliz@gnu.org>
9227
fb11d64d
EZ
9228 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9229 "cast to pointer from integer of different size".
9230
825cd63c
EZ
9231 Improve doprnt and its use in verror. (Bug#8545)
9232 * doprnt.c (doprnt): Document the set of format control sequences
9233 supported by the function. Use SAFE_ALLOCA instead of always
9234 using `alloca'.
9235
9236 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9237 is one byte too soon. Don't use xrealloc; instead xfree and
9238 xmalloc anew.
9239
e061a11b
TZ
92402011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9241
9242 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9243 callbacks stage.
9244
9245 * gnutls.c: Renamed global_initialized to
9246 gnutls_global_initialized. Added internals for the
9247 :verify-hostname-error, :verify-error, and :verify-flags
9248 parameters of `gnutls-boot' and documented those parameters in the
9249 docstring. Start callback support.
9173deec
JB
9250 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9251 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9252 on error. Return error code.
e061a11b
TZ
9253 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9254 (emacs_gnutls_read): Likewise.
9255 (Fgnutls_boot): Return handshake error code.
9256 (emacs_gnutls_handle_error): New function.
9257 (wsaerror_to_errno): Likewise.
9258
9259 * w32.h (emacs_gnutls_pull): Add prototype.
9260 (emacs_gnutls_push): Likewise.
9261
9262 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9263 (emacs_gnutls_push): Likewise.
9264
92652011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9266
9267 * process.c (wait_reading_process_output): Check if GnuTLS
9268 buffered some data internally if no FDs are set for TLS
9269 connections.
9270
9271 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9272 (LIBS): Link to USER_LIBS.
9273 ($(BLD)/gnutls.$(0)): New target.
9274
fa6996bc
EZ
92752011-04-24 Eli Zaretskii <eliz@gnu.org>
9276
eb35682e
EZ
9277 * xdisp.c (handle_single_display_spec): Rename the
9278 display_replaced_before_p argument into display_replaced_p, to
9279 make it consistent with the commentary. Fix typos in the
9280 commentary.
9281
e2ad650c
EZ
9282 * textprop.c (syms_of_textprop): Remove dead code.
9283 (copy_text_properties): Delete obsolete commentary about an
9284 interface that was deleted long ago. Fix typos in the description
9285 of arguments.
9286
1b2de274
EZ
9287 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9288 to changes in oldXMenu/XMenu.h from 2011-04-16.
9289 <menu_help_message, prev_menu_help_message>: Constify.
9290 (IT_menu_make_room): menu->help_text is now `const char **';
9291 adjust.
9292
9293 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9294 to changes in oldXMenu/XMenu.h from 2011-04-16.
9295 (struct XMenu): Declare `help_text' `const char **'.
9296
9297 * xfaces.c <Qunspecified>: Make extern again.
9298
9299 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9300 required by POSIX.
1b2de274 9301
762b15be
EZ
9302 * doc.c (get_doc_string): Improve the format passed to `error'.
9303
9304 * doprnt.c (doprnt): Improve commentary.
9305
9306 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9307
9308 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9309 them with etags.
9310
f1052e5d
EZ
9311 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9312 changes in globals.h immediately force recompilation.
762b15be
EZ
9313 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9314 $(CURDIR)/s/ms-w32.h.
9315 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9316
fa6996bc
EZ
9317 * character.c (Fchar_direction): Function deleted.
9318 (syms_of_character): Don't defsubr it.
9319 <char-direction-table>: Deleted.
9320
e6c3da20
EZ
93212011-04-23 Eli Zaretskii <eliz@gnu.org>
9322
9323 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9324 * doprnt.c: Include limits.h.
9325 (SIZE_MAX): New macro.
04f2d78b
CB
9326 (doprnt): Return a size_t value. 2nd arg is now size_t.
9327 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9328 Improve overflow protection. Support `l' modifier for integer
9329 conversions. Support %l conversion. Don't assume an EMACS_INT
9330 argument for integer conversions and for %c.
9331
9332 * lisp.h (doprnt): Restore prototype.
9333
9334 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9335 $(SRC)/character.h.
9336
9337 * Makefile.in (base_obj): Add back doprnt.o.
9338
9339 * deps.mk (doprnt.o): Add back prerequisites.
9340 (callint.o): Depend on character.h.
9341
9342 * eval.c (internal_lisp_condition_case): Include the handler
9343 representation in the error message.
9344 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9345 when breaking from the loop.
9346
9347 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9348
9349 * callint.c (Fcall_interactively): When displaying error message
9350 about invalid control letter, pass the character's codepoint, not
9351 a pointer to its multibyte form. Improve display of the character
9352 in octal and display also its hex code.
9353
9354 * character.c (char_string): Use %x to display the (unsigned)
9355 codepoint of an invalid character, to avoid displaying a bogus
9356 negative value.
9357
9358 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9359 `error', not SYMBOL_NAME itself.
9360
9361 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9362 character arguments to `error'.
9363
9364 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9365 to `error' in error message about FINAL_CHAR argument. Make sure
9366 FINAL_CHAR is a character, and use %c when it is passed as
9367 argument to `error'.
9368
4ffd0d6b 93692011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9370
9371 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9372
9373 * w32.c: Include <time.h>.
9374 (sys_localtime): New function.
9375
4ffd0d6b 93762011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9377
9378 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9379
4ffd0d6b 9380 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9381
4ffd0d6b 93822011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9383
4ffd0d6b
GM
9384 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9385 zombies (Bug#8467).
aac0c6e3 9386
04c56954
EZ
93872011-04-19 Eli Zaretskii <eliz@gnu.org>
9388
9389 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9390 gl_state.e_property when gl_state.object is Qt.
9391
9392 * insdel.c (make_gap_larger): Remove limitation of buffer size
9393 to <= INT_MAX.
9394
16a43933
CY
93952011-04-18 Chong Yidong <cyd@stupidchicken.com>
9396
9397 * xdisp.c (lookup_glyphless_char_display)
9398 (produce_glyphless_glyph): Handle cons cell entry in
9399 glyphless-char-display.
9400 (Vglyphless_char_display): Document it.
9401
9402 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9403 glyphless-char-display.
9404
4581706e
CY
94052011-04-17 Chong Yidong <cyd@stupidchicken.com>
9406
9407 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9408
9409 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9410
9411 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9412 definition for no-X builds.
9413
4887c6e2 94142011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9415
fd35b6f9
PE
9416 Static checks with GCC 4.6.0 and non-default toolkits.
9417
5c1ccb01
PE
9418 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9419
006c5daa
PE
9420 * process.c (keyboard_bit_set): Define only if SIGIO.
9421 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9422 (send_process): Repair possible setjmp clobbering.
9423
efc736d3
PE
9424 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9425
4e2fe2e6
PE
9426 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9427
f97334a2
PE
9428 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9429
4e75f29d
PE
9430 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9431 Define only if needed.
9432
90efadd1
PE
9433 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9434 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9435 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9436
3c647824
PE
9437 * dispextern.h (struct redisplay_interface): Rename param
9438 to avoid shadowing.
e264f262 9439 * termhooks.h (struct terminal): Likewise.
761383f4 9440 * xterm.c (xembed_send_message): Likewise.
3c647824 9441
b58c5c4a
PE
9442 * insdel.c (make_gap_smaller): Define only if
9443 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9444
cad59032
PE
9445 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9446 it.
9447
c339dc2e
PE
9448 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9449 so that we aren't warned about unused symbols.
9450
91a3e27b
PE
9451 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9452
399c71d3 9453 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9454
8ffc96f5
PE
9455 * xfns.c (x_real_positions): Mark locals as initialized.
9456
eef9bc79
PE
9457 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9458
098db9dd
PE
9459 * xterm.c: Fix problems found by static analysis with other toolkits.
9460 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9461 (x_dispatch_event): Declare static if USE_GTK, and
9462 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9463 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9464 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9465 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9466 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9467
eb18f6cc
PE
9468 * xmenu.c (menu_help_callback): Pointer type fixes.
9469 Use const pointers when pointing at readonly data. Avoid pointer
9470 signedness clashes.
9471 (FALSE): Remove unused macro.
9472 (update_frame_menubar): Remove unused decl.
9473
1fe72bf8
PE
9474 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9475
60d9e1db
PE
9476 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9477 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9478 (single_menu_item): Rename local to avoid shadowing.
9479
39261c26
PE
9480 * keyboard.c (make_lispy_event): Remove unused local var.
9481
018c5e19
PE
9482 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9483 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9484
63d2b86e
PE
9485 * bitmaps: Change bitmaps from unsigned char back to the X11
9486 compatible char. Avoid the old compiler warnings about
9487 out-of-range initializers by using, for example, '\xab' rather
9488 than 0xab.
9489
aefd87e1
PE
9490 * xgselect.c (xgselect_initialize): Check vs interface
9491 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9492
bf501fb9
PE
9493 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9494
e9829fdf
PE
9495 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9496 to read-only memory.
9497
1086c095
PE
9498 * fns.c (vector): Remove; this old hack is no longer needed.
9499
2baccd04 9500 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9501 Remove unused var.
dde42981 9502 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9503
72391843 9504 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9505
436c16df 9506 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9507 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9508 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9509
92bb796d 9510 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9511 (x_term_init): Remove local to avoid shadowing.
92bb796d 9512
764430a3 9513 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9514
9515 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9516 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9517
d1dfb56c
EZ
95182011-04-16 Eli Zaretskii <eliz@gnu.org>
9519
c4354cb4
EZ
9520 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9521
d1dfb56c
EZ
9522 Fix regex.c, syntax.c and friends for buffers > 2GB.
9523 * syntax.h (struct gl_state_s): Declare character position members
9524 EMACS_INT.
9525
9526 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9527
04f2d78b
CB
9528 * textprop.c (verify_interval_modification, interval_of):
9529 Declare arguments EMACS_INT.
d1dfb56c
EZ
9530
9531 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9532 EMACS_INT.
9533
9534 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9535
9536 * indent.c (Fvertical_motion): Local variable it_start is now
9537 EMACS_INT.
9538
9539 * regex.c (re_match, re_match_2, re_match_2_internal)
9540 (bcmp_translate, regcomp, regexec, print_double_string)
9541 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9542 (re_compile_pattern, re_exec): Declare arguments and local
9543 variables `size_t' and `ssize_t' and return values `regoff_t', as
9544 appropriate.
9545 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9546 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9547 <compile_stack_type>: `size' and `avail' are now `size_t'.
9548
9549 * regex.h <regoff_t>: Use ssize_t, not int.
9550 (re_search, re_search_2, re_match, re_match_2): Arguments that
9551 specify buffer/string position and length are now ssize_t and
9552 size_t. Return type is regoff_t.
9553
613052cd
BK
95542011-04-16 Ben Key <bkey76@gmail.com>
9555
9556 * nsfont.m: Fixed bugs in ns_get_family and
9557 ns_descriptor_to_entity that were caused by using free to
9558 deallocate memory blocks that were allocated by xmalloc (via
9559 xstrdup). This caused Emacs to crash when compiled with
9560 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9561 --enable-checking=xmallocoverrun). xfree is now used to
9562 deallocate these memory blocks.
9563
4170f62f 95642011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 9565
71b41406
PE
9566 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9567
9587a89d
PE
9568 emacs_write: Accept and return EMACS_INT for sizes.
9569 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9570 et seq.
9571 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9572 Accept and return EMACS_INT.
9573 (emacs_gnutls_write): Return the number of bytes written on
9574 partial writes.
9575 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
9576 (emacs_read, emacs_write): Remove check for negative size, as the
9577 Emacs source code has been audited now.
9587a89d
PE
9578 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9579 (emacs_read, emacs_write): Use it.
273a5f82
PE
9580 * process.c (send_process): Adjust to the new signatures of
9581 emacs_write and emacs_gnutls_write. Do not attempt to store
9582 a byte offset into an 'int'; it might overflow.
9587a89d 9583 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 9584
3e047f51
PE
9585 * sound.c: Don't assume sizes fit in 'int'.
9586 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 9587 Return EMACS_INT, not int.
3e047f51 9588 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
9589 Accept EMACS_INT, not int.
9590 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
9591 record read return values.
9592
cc39a9db
BK
95932011-04-15 Ben Key <bkey76@gmail.com>
9594
c9d0ec6d
JB
9595 * keyboard.c (Qundefined): Don't declare static since it is used
9596 in nsfns.m.
9597 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9598 static since they are used in nsfont.m.
cc39a9db 9599
6c60eb9f
SM
96002011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9601
9602 * process.c (Qprocessp): Don't declare static.
9603 * lisp.h (Qprocessp): Declare again.
9604
7990b61a
JB
96052011-04-15 Juanma Barranquero <lekktu@gmail.com>
9606
9607 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9608
5d4cb038
PE
96092011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9610
8bd7b830 9611 Improve C-level modularity by making more things 'static'.
cd64ea1d 9612
e3b27b31
PE
9613 Don't publish debugger-only interfaces to other modules.
9614 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9615 (verify_bytepos, count_markers): Move decls to the only modules
9616 that need them.
9617 * region-cache.h (pp_cache): Likewise.
9618 * window.h (check_all_windows): Likewise.
9619 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9620
5d4cb038
PE
9621 * sysdep.c (croak): Now static, if
9622 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9623 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
9624
9625 * alloc.c (refill_memory_reserve): Now static if
9626 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9627 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 9628
e87b6180
PE
9629 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9630 Define only if USE_LUCID.
9631
ac64929e
PE
9632 * xrdb.c (x_customization_string, x_rm_string): Now static.
9633
6f37259d
PE
9634 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9635 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9636
1683e3ab
PE
9637 * xdisp.c (draw_row_with_mouse_face): Now static.
9638 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9639
de9c2632
PE
9640 * window.h (check_all_windows): Mark externally visible.
9641
2b96acb7
PE
9642 * window.c (window_deletion_count): Now static.
9643
9644 * undo.c: Make symbols static if they're not exported.
9645 (last_undo_buffer, last_boundary_position, pending_boundary):
9646 Now static.
9647
50436f33
PE
9648 * textprop.c (interval_insert_behind_hooks): Now static.
9649 (interval_insert_in_front_hooks): Likewise.
9650
64520e5c
PE
9651 * term.c: Make symbols static if they're not exported.
9652 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9653 (max_frame_lines, tty_set_terminal_modes):
9654 (tty_reset_terminal_modes, tty_turn_off_highlight):
9655 (get_tty_terminal): Now static.
9656 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9657 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 9658 HAVE_WINDOW_SYSTEM.
64520e5c
PE
9659 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9660 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9661
1fa53021
PE
9662 * sysdep.c: Make symbols static if they're not exported.
9663 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9664 Now static.
9665 (sigprocmask_set, full_mask): Remove; unused.
9666 (wait_debugging): Mark as visible.
9667 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9668 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9669
d4b43b22
PE
9670 * syntax.c (syntax_temp): Define only if !__GNUC__.
9671
b7c513d0
PE
9672 * sound.c (current_sound_device, current_sound): Now static.
9673
989b29ad
PE
9674 * search.c (searchbufs, searchbuf_head): Now static.
9675
13a55a78
PE
9676 * scroll.c (scroll_cost): Remove; unused.
9677 * dispextern.h (scroll_cost): Remove decl.
9678
de68a1fc
PE
9679 * region-cache.h (pp_cache): Mark as externally visible.
9680
40ccffa6
PE
9681 * process.c: Make symbols static if they're not exported.
9682 (process_tick, update_tick, create_process, chan_process):
9683 (Vprocess_alist, proc_buffered_char, datagram_access):
9684 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9685 (deactivate_process): Mark defn as static, as well as decl.
9686 * lisp.h (create_process): Remove decl.
9687 * process.h (chan_process, Vprocess_alist): Remove decls.
9688
ad64fc97
PE
9689 * print.c: Make symbols static if they're not exported.
9690 (print_depth, new_backquote_output, being_printed, print_buffer):
9691 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9692 (print_interval, print_number_index, initial_stderr_stream):
9693 Now static.
9694 * lisp.h (Fprinc): Remove decl.
9695 (debug_output_compilation_hack): Mark as externally visible.
9696
adddb265
PE
9697 * sysdep.c (croak): Move decl from here to syssignal.h.
9698 * syssignal.h (croak): Put it here, so the API can be checked when
9699 'croak' is called from dissociate_if_controlling_tty.
9700
1717ede2
PE
9701 * minibuf.c: Make symbols static if they're not exported.
9702 (minibuf_save_list, choose_minibuf_frame): Now static.
9703 * lisp.h (choose_minibuf_frame): Remove decl.
9704
fa5fb2bc
PE
9705 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9706
1e3890d1
PE
9707 * lread.c: Make symbols static if they're not exported.
9708 (read_objects, initial_obarray, oblookup_last_bucket_number):
9709 Now static.
9710 (make_symbol): Remove; unused.
9711 * lisp.h (initial_obarray, make_symbol): Remove decls.
9712
8a1414fa
PE
9713 * keyboard.c: Make symbols static if they're not exported.
9714 (single_kboard, recent_keys_index, total_keys, recent_keys):
9715 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9716 (this_single_command_key_start, echoing, last_auto_save):
9717 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9718 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9719 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9720 (Vlispy_mouse_stem, double_click_count):
9721 Now static.
9722 (force_auto_save_soon): Define only if SIGDANGER.
9723 (ignore_mouse_drag_p): Now static if
9724 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9725 (print_help): Remove; unused.
9726 (stop_character, last_timer_event): Mark as externally visible.
9727 * keyboard.h (ignore_mouse_drag_p): Declare only if
9728 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9729 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9730 * lisp.h (echoing): Remove decl.
9731 (force_auto_save_soon): Declare only if SIGDANGER.
9732 * xdisp.c (redisplay_window): Simplify code, to make it more
9733 obvious that ignore_mouse_drag_p is not accessed if !defined
9734 USE_GTK && !defined HAVE_NS.
9735
93ea6e8f
PE
9736 * intervals.c: Make symbols static if they're not exported.
9737 (merge_properties_sticky, merge_interval_right, delete_interval):
9738 Now static.
9739 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9740
77382fcc
PE
9741 * insdel.c: Make symbols static if they're not exported.
9742 However, leave prepare_to_modify_buffer alone. It's never
9743 called from outside this function, but that appears to be a bug.
9744 (combine_after_change_list, combine_after_change_buffer):
4889fc82 9745 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
9746 (adjust_after_replace_noundo): Remove; unused.
9747 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 9748 (signal_before_change): Remove decls.
77382fcc 9749
9306c32e
PE
9750 * indent.c (val_compute_motion, val_vmotion): Now static.
9751
cd44d2eb
PE
9752 * image.c: Make symbols static if they're not exported.
9753 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9754 if USE_GTK.
9755 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9756 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9757
ad9a7a06
PE
9758 * fringe.c (standard_bitmaps): Now static.
9759 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9760
81626931
PE
9761 * frame.c: Make symbols static if they're not exported.
9762 (x_report_frame_params, make_terminal_frame): Now static.
9763 (get_frame_param): Now static, unless HAVE_NS.
9764 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9765 (x_get_resource_string): Remove; not used.
9766 * frame.h (make_terminal_frame, x_report_frame_params):
9767 (x_get_resource_string); Remove decls.
9768 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9769 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9770
239f9db9
PE
9771 * font.c, fontset.c: Make symbols static if they're not exported.
9772 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9773 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9774 * font.c (font_close_object): Now static.
9775 * font.h (font_close_object): Remove.
9776 * fontset.c (FONTSET_OBJLIST): Remove.
9777 (free_realized_fontset) #if-0 the body, which does nothing.
9778 (face_suitable_for_char_p): #if-0, as it's never called.
9779 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
9780 * xfaces.c (face_at_string_position):
9781 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
9782 since 0 is always ASCII.
9783
dfcf3579
PE
9784 * fns.c (weak_hash_tables): Now static.
9785
5045092b
PE
9786 * fileio.c: Make symbols static if they're not exported.
9787 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9788 (Vwrite_region_annotation_buffers): Now static.
9789
57a96f5c
PE
9790 * eval.c: Make symbols static if they're not exported.
9791 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9792 * lisp.h (backtrace_list): Remove decl.
9793
35f08c38
PE
9794 * emacs.c: Make symbols static if they're not exported.
9795 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9796 (fatal_error_code, fatal_error_signal_hook, standard_args):
9797 Now static.
9798 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9799 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9800 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9801 * lisp.h (fatal_error_signal_hook): Remove decl.
9802 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9803
f44bd759
PE
9804 * editfns.c: Move a (normally-unused) function to its only use.
9805 * editfns.c, lisp.h (get_operating_system_release): Remove.
9806 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9807 worth the hassle of breaking this out.
9808
b532497d
PE
9809 * xterm.c: Make symbols static if they're not exported.
9810 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9811 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9812 (x_destroy_window, x_delete_display):
9813 Now static.
9814 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9815 (x_mouse_leave): Remove; unused.
9816 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9817 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9818 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9819 Remove decls.
9820 (x_mouse_leave): Declare only if WINDOWSNT.
9821 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9822 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9823 USE_X_TOOLKIT.
9824
1675728f
PE
9825 * ftxfont.c: Make symbols static if they're not exported.
9826 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9827 HAVE_FREETYPE.
9828 * font.h (ftxfont_driver): Likewise.
9829
e4cebfca
PE
9830 * xfns.c: Make symbols static if they're not exported.
9831 (x_last_font_name, x_display_info_for_name):
9832 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9833 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9834 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9835 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9836 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9837 (last_show_tip_args): Now static.
9838 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9839 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9840 (x_screen_planes): Remove; unused.
9841 * dispextern.h (x_screen_planes): Remove decl.
9842
5bf46f05
PE
9843 * dispnew.c: Make symbols static if they're not exported.
9844 * dispextern.h (redraw_garbaged_frames, scrolling):
9845 (increment_row_positions): Remove.
9846 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9847 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9848 Now static.
9849 (redraw_garbaged_frames): Remove; unused.
9850
435f4c28
PE
9851 * xfaces.c: Make symbols static if they're not exported.
9852 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9853 Remove decls.
9854 * xterm.h (defined_color): Remove decls.
9855 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9856 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9857 (menu_face_changed_default, defined_color, free_realized_face):
9858 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9859 (ascii_face_of_lisp_face): Remove; unused.
9860
8524aef3
PE
9861 * xdisp.c: Make symbols static if they're not exported.
9862 * dispextern.h (scratch_glyph_row, window_box_edges):
9863 (glyph_to_pixel_coords, set_cursor_from_row):
9864 (get_next_display_element, set_iterator_to_next):
9865 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9866 (show_mouse_face): Remove decls
9867 * frame.h (message_buf_print): Likewise.
9868 * lisp.h (pop_message, set_message, check_point_in_composition):
9869 Likewise.
9870 * xterm.h (set_vertical_scroll_bar): Likewise.
9871 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9872 (message_buf_print, scratch_glyph_row, displayed_buffer):
9873 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9874 (get_next_display_element, show_mouse_face, window_box_edges):
9875 (frame_to_window_pixel_xy, check_point_in_composition):
9876 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9877 (glyph_to_pixel_coords): Remove; unused.
9878
16390cd2
PE
9879 * dired.c (file_name_completion): Now static.
9880
9881 * dbusbind.c (xd_in_read_queued_messages): Now static.
9882
a25f4dfa
PE
9883 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9884 * data.c (circular_list_error): Remove.
9885
14a9c8df
PE
9886 * commands.h (last_point_position, last_point_position_buffer):
9887 (last_point_position_window): Remove decls.
9888 * keyboard.c: Make these variables static.
9889
04f2d78b
CB
9890 * coding.h (coding, code_convert_region, encode_coding_gap):
9891 Remove decls.
74ab6df5
PE
9892 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9893 (iso_code_class, detect_coding, code_convert_region): Now static.
9894 (encode_coding_gap): Remove; unused.
9895
38dfbee1
PE
9896 * chartab.c (chartab_chars, chartab_bits): Now static.
9897
a2cb4e63
PE
9898 * charset.h (charset_iso_8859_1): Remove decl.
9899 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9900 Now static.
9901
127198fd
PE
9902 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9903 * ccl.c (Vccl_program_table): Now static.
9904 (check_ccl_update): Remove; unused.
9905
d85b608f
PE
9906 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9907 * category.h: ... from here.
9908 * category.c (check_category_table, set_category_set): Now static.
9909
31cd66f3
PE
9910 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9911 * lisp.h: Remove these decls.
9912
c358e587
PE
9913 * buffer.c (buffer_count): Remove unused var.
9914
e78aecca
PE
9915 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9916 so that it's not optimized away.
9917 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9918 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9919 exported only to the debugger.
9920
e192d7d3 9921 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 9922 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 9923
92470028
PE
9924 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9925 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9926 was inaccessible from Lisp.
9927 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9928 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9929
244ed907
PE
9930 alloc.c: Import and export fewer symbols, and remove unused items.
9931 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9932 is defined.
9933 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9934 it's not optimized away by whole-program optimization.
9935 (message_enable_multibyte, free_misc): Remove.
9936 (catchlist, handlerlist, mark_backtrace):
9937 Declare only if BYTE_MARK_STACK.
9938 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9939 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9940 (message_enable_multibyte): Remove decl.
9941 (free_misc, interval_free_list, float_block, float_block_index):
9942 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9943 (cons_free_list, last_marked_index):
9944 Now static.
9945 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9946 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9947 (mark_backtrace): Define only if BYTE_MARK_STACK.
9948 * xdisp.c (message_enable_multibyte): Now static.
9949
61c2b50e 9950 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
9951 This makes it easier for human readers (and static analyzers)
9952 to see whether these variables are used from other modules.
9953 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9954 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9955 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9956 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9957 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9958 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9959 * xmenu.c, xselect.c:
9960 Declare Q* vars static if they are not used in other modules.
9961 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9962 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9963 Remove decls of unexported vars.
9964 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9965
95c82688
PE
9966 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9967
16a97296
PE
9968 Make Emacs functions such as Fatom 'static' by default.
9969 This makes it easier for human readers (and static analyzers)
9970 to see whether these functions can be called from other modules.
9971 DEFUN now defines a static function. To make the function external
9972 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
9973 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9974 (Finit_image_library):
16a97296
PE
9975 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9976 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9977 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9978 Remove decls, since these functions are now static.
9979 (Funintern, Fget_internal_run_time): New decls, since these functions
9980 were already external.
95c82688 9981
16a97296
PE
9982 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9983 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9984 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9985 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9986 * keyboard.c, keymap.c, lread.c:
9987 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9988 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9989 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9990 Mark functions with DEFUE instead of DEFUN,
9991 if they are used in other modules.
9992 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9993 decls for now-static functions.
9994 * buffer.h (Fdelete_overlay): Remove decl.
9995 * callproc.c (Fgetenv_internal): Mark as internal.
9996 * composite.c (Fremove_list_of_text_properties): Remove decl.
9997 (Fcomposition_get_gstring): New forward static decl.
9998 * composite.h (Fcomposite_get_gstring): Remove decl.
9999 * dired.c (Ffile_attributes): New forward static decl.
10000 * doc.c (Fdocumntation_property): New forward static decl.
10001 * eval.c (Ffetch_bytecode): New forward static decl.
10002 (Funintern): Remove extern decl; now in .h file where it belongs.
10003 * fileio.c (Fmake_symbolic_link): New forward static decl.
10004 * image.c (Finit_image_library): New forward static decl.
10005 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10006 * intervals.h (Fprevious_property_change):
10007 (Fremove_list_of_text_properties): Remove decls.
10008 * keyboard.c (Fthis_command_keys): Remove decl.
10009 (Fcommand_execute): New forward static decl.
10010 * keymap.c (Flookup_key): New forward static decl.
10011 (Fcopy_keymap): Now static.
10012 * keymap.h (Flookup_key): Remove decl.
10013 * process.c (Fget_process): New forward static decl.
10014 (Fprocess_datagram_address): Mark as internal.
10015 * syntax.c (Fsyntax_table_p): New forward static decl.
10016 (skip_chars): Remove duplicate decl.
10017 * textprop.c (Fprevious_property_change): New forward static decl.
10018 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10019 Now internal.
10020 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10021 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10022
785bbd42
PE
10023 * editfns.c (Fformat): Remove unreachable code.
10024
8b913b57
AS
100252011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10026
10027 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10028 change. (Bug#8496)
10029
a6744a35
EZ
100302011-04-13 Eli Zaretskii <eliz@gnu.org>
10031
10032 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10033 when at ZV. (Bug#8487)
10034
e7974947
AS
100352011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10036
baad03f0
AS
10037 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10038 (Bug#8437)
10039 * keyboard.c (parse_tool_bar_item): Likewise.
10040 * sound.c (sound_cleanup, alsa_close): Likewise.
10041 * termcap.c (tgetent): Likewise.
10042 * xfns.c (x_default_font_parameter): Likewise.
10043 * xsettings.c (read_and_apply_settings): Likewise.
10044
e7974947
AS
10045 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10046 (overrun_check_free): Protoize.
10047
28272684
PE
100482011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10049
10050 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10051 since callers should never pass a negative size.
10052 Change the signature to match that of plain 'read' and 'write'; see
10053 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10054 * lisp.h: Update prototypes of emacs_write and emacs_read.
10055
11997c76
EZ
100562011-04-11 Eli Zaretskii <eliz@gnu.org>
10057
10058 * xdisp.c (redisplay_window): Don't try to determine the character
10059 position of the scroll margin if the window start point w->startp
e896f03c 10060 is outside the buffer's accessible region. (Bug#8468)
11997c76 10061
8a2cbd72
EZ
100622011-04-10 Eli Zaretskii <eliz@gnu.org>
10063
10064 Fix write-region and its subroutines for buffers > 2GB.
10065 * fileio.c (a_write, e_write): Modify declaration of arguments and
10066 local variables to support buffers larger than 2GB.
10067 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10068
10069 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10070 argument, local variables, and return value.
10071
10072 * lisp.h: Update prototypes of emacs_write and emacs_read.
10073
10074 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10075
4073e537 100762011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10077
1ebfdcb6
PE
10078 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10079
b2ded58d
PE
10080 Fix more problems found by GCC 4.6.0's static checks.
10081
7d66342c
PE
10082 * xdisp.c (vmessage): Use a better test for character truncation.
10083
bbf47d44
PE
10084 * charset.c (load_charset_map): <, not <=, for optimization,
10085 and to avoid potential problems with integer overflow.
9248994d 10086 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10087 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10088 * editfns.c (Fformat): Likewise.
1e69125e 10089 * syntax.c (skip_chars): Likewise.
3befa583 10090
e3019616
PE
10091 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10092 This also lets GCC 4.6.0 generate slightly better loop code.
10093
becfa255
PE
10094 * callint.c (Fcall_interactively): <, not <=, for optimization.
10095 (Fcall_interactively): Count the number of arguments produced,
10096 not the number of arguments given. This is simpler and lets GCC
10097 4.6.0 generate slightly better code.
10098
dae0cd48
PE
10099 * ftfont.c: Distingish more carefully between FcChar8 and char.
10100 The previous code passed unsigned char * to a functions like
10101 strlen and xstrcasecmp that expect char *, which does not
10102 conform to the C standard.
10103 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10104 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10105 char * when the C standard requires it.
10106
76032d70
PE
10107 * keyboard.c (read_char): Remove unused var.
10108
eb3f1cc8
PE
10109 * eval.c: Port to Windows vsnprintf (Bug#8435).
10110 Include <limits.h>.
10111 (SIZE_MAX): Define if the headers do not.
10112 (verror): Do not give up if vsnprintf returns a negative count.
10113 Instead, grow the buffer. This ports to Windows vsnprintf, which
10114 does not conform to C99. Problem reported by Eli Zaretskii.
10115 Also, simplify the allocation scheme, by avoiding the need for
10116 calling realloc, and removing the ALLOCATED variable.
10117
70476b54
PE
10118 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10119
12020a9e
PE
10120 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10121 But keep the doprint source code for now, as we might revamp it
10122 and use it again (Bug#8435).
ea6c7ae6
PE
10123 * lisp.h (doprnt): Remove.
10124 * Makefile.in (base_obj): Remove doprnt.o.
10125 * deps.mk (doprnt.o): Remove.
10126
5fdb398c
PE
10127 error: Print 32- and 64-bit integers portably (Bug#8435).
10128 Without this change, on typical 64-bit hosts error ("...%d...", N)
10129 was used to print both 32- and 64-bit integers N, which relied on
10130 undefined behavior.
61bdb816 10131 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10132 * lisp.h (error, verror): Mark as printf-like functions.
10133 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10134 Report overflow in size calculations when allocating printf buffer.
10135 Do not truncate output string at its first null byte.
10136 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10137 Truncate the output at a character boundary, since vsnprintf does not
10138 do that.
10139 * charset.c (check_iso_charset_parameter): Convert internal
10140 character to string before calling 'error', since %c now has the
10141 printf meaning.
10142 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10143 overflow when computing char to be passed to 'error'. Do not
10144 pass Lisp_Object to 'error'; pass the integer instead.
10145 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10146 formatted with plain %d.
10147
b189fa66
PE
10148 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10149
bff87ef0
PE
10150 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10151
7e2cac20
PE
10152 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10153
ce4d90b5
PE
10154 * xterm.c (x_catch_errors): Remove duplicate declaration.
10155
266c9547
PE
10156 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10157
79c49ad2
PE
10158 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10159
368f4090
JM
101602011-04-10 Jim Meyering <meyering@redhat.com>
10161
10162 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10163 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10164 return ssize_t not "int", and use size_t as the buffer length.
10165 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10166 * gnutls.h: Update declarations.
10167 * process.c (read_process_output): Use ssize_t, to match.
10168 (send_process): Likewise.
10169
a32d4040
CY
101702011-04-09 Chong Yidong <cyd@stupidchicken.com>
10171
10172 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10173
8546720e 101742011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10175
04f2d78b
CB
10176 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10177 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10178
8546720e
GM
10179 * xterm.c (handle_one_xevent):
10180 * xmenu.c (create_and_show_popup_menu):
10181 * xselect.c (x_decline_selection_request)
10182 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10183
0a2f5c1a 101842011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10185
10186 Fix some uses of `int' instead of EMACS_INT.
10187 * search.c (string_match_1, fast_string_match)
10188 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10189 (scan_buffer, find_next_newline_no_quit)
10190 (find_before_next_newline, search_command, Freplace_match)
10191 (Fmatch_data): Make some `int' variables be EMACS_INT.
10192
10193 * xdisp.c (display_count_lines): 3rd argument and return value now
10194 EMACS_INT. All callers changed.
10195 (pint2hrstr): Last argument is now EMACS_INT.
10196
10197 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10198 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10199 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10200 (decode_coding_utf_16, decode_coding_emacs_mule)
10201 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10202 (decode_coding_ccl, decode_coding_charset)
10203 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10204 (decode_coding_iso_2022, decode_coding_emacs_mule)
10205 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10206 <char_offset, last_offset>: Declare EMACS_INT.
10207 (encode_coding_utf_8, encode_coding_utf_16)
10208 (encode_coding_emacs_mule, encode_invocation_designation)
10209 (encode_designation_at_bol, encode_coding_iso_2022)
10210 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10211 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10212 Declare EMACS_INT.
10213 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10214 (encode_invocation_designation): Last argument P_NCHARS is now
10215 EMACS_INT.
10216 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10217 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10218
10219 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10220 All users changed.
10221
10222 * ccl.c (Fccl_execute_on_string): Declare some variables
10223 EMACS_INT.
10224
8546720e 102252011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10226
10227 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10228
4e19a977
CS
102292011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10230
10231 * process.c (Fformat_network_address): Doc fix.
10232
87302331
R
102332011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10234
ee7683eb 10235 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10236
cbb59342
CY
102372011-04-08 Chong Yidong <cyd@stupidchicken.com>
10238
10239 * keyboard.c (read_char): Call Lisp function help-form-show,
10240 instead of using internal_with_output_to_temp_buffer.
10241 (Qhelp_form_show): New var.
e0d38eeb 10242 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10243
10244 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10245
10246 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10247
e67a13ab
CY
102482011-04-06 Chong Yidong <cyd@stupidchicken.com>
10249
04f2d78b
CB
10250 * process.c (Flist_processes): Remove to Lisp.
10251 (list_processes_1): Delete.
e67a13ab 10252
973f782d
EZ
102532011-04-06 Eli Zaretskii <eliz@gnu.org>
10254
7c106b1e
EZ
10255 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10256
973f782d
EZ
10257 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10258
41cf7d1a 102592011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10260
ca23cc88
PE
10261 Fix more problems found by GCC 4.6.0's static checks.
10262
f390e2d5
PE
10263 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10264
42eea0d0
PE
10265 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10266
b69769da 10267 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10268
f9541e84
PE
10269 * xdisp.c (vmessage): Mark as a printf-like function.
10270
13841b55
PE
10271 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10272
c136c10f
PE
10273 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10274
5e2d4a30
PE
10275 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10276 printf-like functions.
10277 (tiff_load): Add casts to remove these marks before passing them
10278 to system-supplied API.
10279
583f48b9
PE
10280 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10281
b25d760e
PE
10282 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10283 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10284 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10285 directly, rather than having caller test rule sign. This avoids
10286 some unnecessary tests.
10287 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10288 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10289 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10290
bc7b6697 10291 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10292 (xfont_open): Avoid unnecessary tests.
bc7b6697 10293
27ccc379
PE
10294 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10295
dcd5c89a
PE
10296 * composite.h, composite.c (composition_gstring_put_cache):
10297 Use EMACS_INT, not int, for length.
10298
b13a45c6
PE
10299 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10300 breaking out part of COMPOSITION_DECODE_RULE.
10301 (COMPOSITION_DECODE_RULE): Use it.
10302 * composite.c (get_composition_id): Remove unused local vars,
10303 by using the new macro.
10304
1e792e4d
PE
10305 * textprop.c (set_text_properties_1): Change while to do-while,
10306 since the condition is always true at first.
10307
dc6c6455 10308 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10309 (interval_deletion_adjustment): Return unsigned value.
10310 All uses changed.
dc6c6455 10311
aba7731a
PE
10312 * process.c (list_processes_1, create_pty, read_process_output):
10313 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10314 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10315 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10316 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10317 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10318
fdfc4bf3
PE
10319 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10320
fca8fe46 10321 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10322 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10323
06a0259a 10324 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10325 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10326 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10327
e7b9e80f
PE
10328 * print.c (print_error_message): Avoid int overflow.
10329
56201685
PE
10330 * font.c (font_list_entities): Redo for clarity,
10331 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10332
78834453 10333 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10334 (font_score): Avoid potential overflow in diff calculation.
78834453 10335
0bc0b309 10336 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10337 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10338
e610eaca
PE
10339 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10340
b895abce
PE
10341 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10342 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10343 can always succeed if overflow has undefined behavior.
10344
1f1d9321 10345 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10346 (wordify): Omit three unnecessary tests.
1f1d9321 10347
c59478bc
PE
10348 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10349 All callers changed. This avoids the need for an unused var.
10350
79b73827
PE
10351 * casefiddle.c (casify_region): Remove var that is set but not used.
10352
a4db5dfe
PE
10353 * dired.c (file_name_completion): Remove var that is set but not used.
10354
43aae36e
PE
10355 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10356
2a47c44d 10357 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10358 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10359
a37c69bf
PE
10360 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10361 Check for integer overflow on size calculations.
10362
328ab8e7
PE
10363 * buffer.c (Fprevious_overlay_change): Remove var that is set
10364 but not used.
10365
e5a2a5cb
PE
10366 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10367 Remove vars that are set but not used.
8d84a6eb 10368 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10369 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10370
a60e5f68
PE
10371 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10372
f661cb61 10373 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10374 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10375
f0397f5a
PE
10376 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10377 that are set but not used.
10378
8664db06 10379 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10380 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10381
6abdaa4a
PE
10382 * xselect.c (x_get_local_selection, x_handle_property_notify):
10383 Remove vars that are set but not used.
10384
0ce7538d 10385 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10386 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10387
9ae848fc
PE
10388 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10389 Remove var that is set but not used.
0b918413
PE
10390 (scroll_bar_windows_size): Now size_t, not int.
10391 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10392 Check for overflow.
9ae848fc 10393
a5a62657
PE
10394 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10395 (map_tty_color) [!defined MSDOS]: Likewise.
10396
5c5cdd39
PE
10397 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10398
66ebf983
PE
10399 * coding.c: Remove vars that are set but not used.
10400 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10401 All callers changed.
10402 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10403 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10404 (decode_coding_charset): Remove vars that are set but not used.
10405
1be4d761
PE
10406 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10407 that is set but not used.
10408
47553fa8
PE
10409 * print.c (print_object): Remove var that is set but not used.
10410
1f7196bf 10411 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10412 The gnulib version avoids calling malloc in the usual case,
10413 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10414 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10415 * filelock.c (current_lock_owner): Likewise.
10416 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10417 * sysdep.c: Include allocator.h, careadlinkat.h.
10418 (emacs_no_realloc_allocator): New static constant.
10419 (emacs_readlink): New function.
fdb61804
PE
10420 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10421 ../lib/careadlinkat.h.
d1fdcab7 10422
f84c17c7
SM
104232011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10424
10425 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10426 first non-nil return value).
10427
ef3862ad
JD
104282011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10429
10430 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10431 if not defined (Bug#8403).
10432
376a7006
JB
104332011-04-02 Juanma Barranquero <lekktu@gmail.com>
10434
10435 * xdisp.c (display_count_lines): Remove parameter `start',
10436 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10437 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10438 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10439 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10440 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10441 and thereabouts. All callers changed.
10442 (get_per_char_metric): Remove parameter `f', unused since
10443 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10444
6ca3801d
JM
104452011-04-02 Jim Meyering <meyering@redhat.com>
10446
10447 do not dereference NULL upon failed strdup
10448 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10449 (ns_get_family): Likewise.
10450
d8e2b5ba
JB
104512011-04-02 Juanma Barranquero <lekktu@gmail.com>
10452
10453 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10454
8c74fcbd
JD
104552011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10456
10457 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10458 later (Bug#8403).
10459
7200d79c
SM
104602011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10461
03408648 10462 Add lexical binding.
7200d79c 10463
03408648
SM
10464 * window.c (Ftemp_output_buffer_show): New fun.
10465 (Fsave_window_excursion):
10466 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10467
10468 * lread.c (lisp_file_lexically_bound_p): New function.
10469 (Fload): Bind Qlexical_binding.
10470 (readevalloop): Remove `evalfun' arg.
10471 Bind Qinternal_interpreter_environment.
10472 (Feval_buffer): Bind Qlexical_binding.
10473 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10474 Mark as dynamic.
10475 (syms_of_lread): Declare `lexical-binding'.
10476
10477 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10478
10479 * keyboard.c (eval_dyn): New fun.
10480 (menu_item_eval_property): Use it.
ca105506
SM
10481
10482 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10483
03408648
SM
10484 * fns.c (concat, mapcar1): Accept byte-code-functions.
10485
10486 * eval.c (Fsetq): Handle lexical vars.
10487 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10488 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10489 (FletX, Flet): Obey lexical binding.
10490 (Fcommandp): Handle closures.
10491 (Feval): New `lexical' arg.
10492 (eval_sub): New function extracted from Feval. Use it almost
10493 everywhere where Feval was used. Look up vars in lexical env.
10494 Handle closures.
10495 (Ffunctionp): Move from subr.el.
10496 (Ffuncall): Handle closures.
10497 (apply_lambda): Remove `eval_flags'.
10498 (funcall_lambda): Handle closures and new byte-code-functions.
10499 (Fspecial_variable_p): New function.
10500 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10501 but without exporting it to Lisp.
23aba0ea 10502
23aba0ea 10503 * doc.c (Fdocumentation, store_function_docstring):
03408648 10504 * data.c (Finteractive_form): Handle closures.
23aba0ea 10505
03408648
SM
10506 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10507 interactive spec.
ba83908c 10508
04f2d78b
CB
10509 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10510 New byte-codes.
03408648
SM
10511 (exec_byte_code): New function extracted from Fbyte_code to handle new
10512 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10513
03408648 10514 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10515
03408648 10516 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10517
e2abce01
JB
105182011-03-31 Juanma Barranquero <lekktu@gmail.com>
10519
10520 * xdisp.c (redisplay_internal): Fix prototype.
10521
63696a73 105222011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10523
63696a73 10524 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10525 (try_scrolling): Use it when setting scroll_limit.
10526 Limit scrolling to 100 screen lines.
63696a73
EZ
10527 (redisplay_window): Even when falling back on "recentering",
10528 position point in the window according to scroll-conservatively,
10529 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10530
10531 (try_scrolling): When point is above the window, allow searching
10532 as far as scroll_max, or one screenful, to compute vertical
10533 distance from PT to the scroll margin position. This prevents
10534 try_scrolling from unnecessarily failing when
10535 scroll-conservatively is set to a value slightly larger than the
10536 window height. Clean up the case of PT below the margin at bottom
10537 of window: scroll_max can no longer be INT_MAX. When aggressive
10538 scrolling is in use, don't let point enter the opposite scroll
10539 margin as result of the scroll.
10540 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10541 threshold of 100 lines for never-recentering scrolling.
10542
e4cc2dfc
JB
105432011-03-31 Juanma Barranquero <lekktu@gmail.com>
10544
10545 * dispextern.h (move_it_by_lines):
10546 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10547 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10548 (message_log_check_duplicate): Remove parameters `prev_bol' and
10549 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10550 (redisplay_internal): Remove parameter `preserve_echo_area',
10551 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10552
10553 * indent.c (Fvertical_motion):
10554 * window.c (window_scroll_pixel_based, Frecenter):
10555 Don't pass `need_y_p' to `move_it_by_lines'.
10556
1c470562
SM
105572011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10558
44f230aa
SM
10559 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10560 steal a few bits to be more compact.
10561 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10562 Remove unneeded casts.
10563
1c470562
SM
10564 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10565
888adce9
ZK
105662011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10567
10568 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10569 binding" message (bug#7967).
10570
f838ed7b
PE
105712011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10572
77861b95
PE
10573 Fix more problems found by GCC 4.6.0's static checks.
10574
de6dbc14
PE
10575 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10576 Remove unused local var.
10577
f838ed7b
PE
10578 * editfns.c (Fmessage_box): Remove unused local var.
10579
792c7b2b
PE
10580 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10581 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10582 Omit unused local vars.
c499e557 10583 * window.c (shrink_windows): Omit unused local var.
b01a1c29 10584 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
10585 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10586 Omit unused local var.
10587
ba0165e1
PE
10588 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10589 Don't assume string length fits in int.
32ad8845 10590 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 10591 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 10592
3c59b4c9
PE
10593 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10594 instead of alloca (Bug#8344).
10595
a3eed478 10596 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 10597 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 10598
eb4d412d
PE
10599 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10600
1658b401
PE
10601 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10602 concerns.
10603
10604 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10605
10606 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 10607
9a2c6e05
PE
10608 * keyboard.c (syms_of_keyboard): Use the same style as later
10609 in this function when indexing through an array. This also
10610 works around GCC bug 48267.
10611
03d0a109
PE
10612 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10613
44f730c8
PE
10614 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10615
fe75f926
PE
10616 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10617 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10618
ffa8c828
PE
10619 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10620 This avoids undefined behavior on integer overflow, and is a bit
10621 more convenient anyway since it is compared to a size_t variable.
10622
c5101a77
PE
10623 Variadic C functions now count arguments with size_t, not int.
10624 This avoids an unnecessary limitation on 64-bit machines, which
10625 caused (substring ...) to crash on large vectors (Bug#8344).
10626 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10627 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 10628 All variadic functions and their callers changed accordingly.
c5101a77
PE
10629 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10630 * data.c (arith_driver, float_arith_driver): Likewise.
10631 * editfns.c (general_insert_function): Likewise.
10632 * eval.c (struct backtrace.nargs, interactive_p)
10633 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10634 (funcall_lambda, mark_backtrace): Likewise.
10635 * fns.c (concat): Likewise.
10636 * frame.c (x_set_frame_parameters): Likewise.
10637 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10638 0 if not found, not -1. All callers changed.
10639
dd3f25f7
PE
10640 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10641 (stack_copy_size): Now size_t, not int.
10642 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10643
461c2ab9
JB
106442011-03-28 Juanma Barranquero <lekktu@gmail.com>
10645
10646 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10647 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10648 All callers changed.
10649
10650 * lisp.h (multibyte_char_to_unibyte):
10651 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10652 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10653 * character.h (CHAR_TO_BYTE8):
10654 * cmds.c (internal_self_insert):
10655 * editfns.c (general_insert_function):
10656 * keymap.c (push_key_description):
10657 * search.c (Freplace_match):
10658 * xdisp.c (message_dolog, set_message_1): All callers changed.
10659
f6d62986
SM
106602011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10661
10662 * keyboard.c (safe_run_hook_funcall): New function.
10663 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10664 don't set the hook to nil, but remove the offending function instead.
10665 (Qcommand_hook_internal): Remove, unused.
10666 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10667 Vcommand_hook_internal.
10668
10669 * eval.c (enum run_hooks_condition): Remove.
10670 (funcall_nil, funcall_not): New functions.
10671 (run_hook_with_args): Call each function through a `funcall' argument.
10672 Remove `cond' argument, now redundant.
10673 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10674 (Frun_hook_with_args_until_failure): Adjust accordingly.
10675 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10676
1db5b1ad
JB
106772011-03-28 Juanma Barranquero <lekktu@gmail.com>
10678
10679 * dispextern.h (string_buffer_position): Remove declaration.
10680
10681 * print.c (strout): Remove parameter `multibyte', unused since
10682 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10683
10684 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10685 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10686 All callers changed.
10687
10688 * w32.c (_wsa_errlist): Use braces for struct initializers.
10689
10690 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10691 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10692 All callers changed.
10693 (string_buffer_position): Likewise. Also, make static (it's never
10694 used outside xdisp.c).
10695 (cursor_row_p): Remove parameter `w', unused since
10696 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10697 (decode_mode_spec): Remove parameter `precision', introduced during
10698 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10699 All callers changed.
10700
5ffb62aa
JD
107012011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10702
10703 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10704
461c2ab9 107052011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
10706
10707 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10708 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10709 (ns_update_auto_hide_menu_bar): New functions.
10710 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10711 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10712 ns_constrain_all_frames.
10713 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10714 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10715
5c380ffb
JD
107162011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10717
10718 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10719
9af30bdf
GM
107202011-03-27 Glenn Morris <rgm@gnu.org>
10721
10722 * syssignal.h: Replace RETSIGTYPE with void.
10723 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10724 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10725 Replace SIGTYPE with void everywhere.
10726 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10727 * s/template.h (SIGTYPE): Remove commented out definition.
10728
e2abce01
JB
107292011-03-26 Eli Zaretskii <eliz@gnu.org>
10730
10731 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10732 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10733
f868cd8a
JB
107342011-03-26 Juanma Barranquero <lekktu@gmail.com>
10735
59eb0929
JB
10736 * w32.c (read_unc_volume): Use parameter `henum', instead of
10737 global variable `wget_enum_handle'.
10738
10739 * keymap.c (describe_vector): Remove parameters `indices' and
10740 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10741 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10742
f868cd8a
JB
10743 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10744
10745 * keyboard.c (timer_check): Remove parameter `do_it_now',
10746 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10747 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10748 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10749
10750 * keyboard.c (read_char):
10751 * w32menu.c (w32_menu_display_help):
10752 * xmenu.c (show_help_event, menu_help_callback):
10753 Adjust calls to `show_help_echo'.
10754
10755 * gtkutil.c (xg_maybe_add_timer):
10756 * keyboard.c (readable_events):
10757 * process.c (wait_reading_process_output):
10758 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10759
10760 * insdel.c (adjust_markers_gap_motion):
10761 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10762 (gap_left, gap_right): Don't call it.
10763
2ecf6fdb
CY
107642011-03-25 Chong Yidong <cyd@stupidchicken.com>
10765
10766 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10767 incurred during fontification.
10768
6b1f9ba4
JB
107692011-03-25 Juanma Barranquero <lekktu@gmail.com>
10770
10771 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10772 (DEFVAR_PER_BUFFER): Don't pass it.
10773
10774 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10775 (scrolling_window): Don't pass it.
10776
0f4a96b5
JB
107772011-03-25 Juanma Barranquero <lekktu@gmail.com>
10778
10779 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10780
10781 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10782 and `suffix'.
10783 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10784 of variables specific to SELinux and computation of `encoded_absname'.
10785
10786 * image.c (XPutPixel): Remove unused variable `height'.
10787
10788 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10789
10790 * unexw32.c (get_section_info): Remove unused variable `section'.
10791
10792 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10793 (system_process_attributes): Remove unused variable `sess'.
10794 (sys_read): Remove unused variable `err'.
10795
10796 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10797 (w32_wnd_proc): Remove unused variable `isdead'.
10798 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10799 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10800 (x_create_tip_frame): Remove unused variable `tem'.
10801
10802 * w32inevt.c (w32_console_read_socket):
10803 Remove unused variable `no_events'.
10804
10805 * w32term.c (x_draw_composite_glyph_string_foreground):
10806 Remove unused variable `width'.
10807
1149507c
JB
108082011-03-24 Juanma Barranquero <lekktu@gmail.com>
10809
10810 * w32term.c (x_set_glyph_string_clipping):
10811 Don't pass uninitialized region to CombineRgn.
10812
9c88f339
JB
108132011-03-23 Juanma Barranquero <lekktu@gmail.com>
10814
10815 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10816 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10817 (Fx_close_connection): Remove unused variable `i'.
10818
10819 * w32font.c (w32font_draw): Return number of glyphs.
10820 (w32font_open_internal): Remove unused variable `i'.
10821 (w32font_driver): Add missing initializer.
10822
10823 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10824 (fill_in_menu): Remove unused variable `items_added'.
10825
10826 * w32term.c (last_mouse_press_frame): Remove static global variable.
10827 (w32_clip_to_row): Remove unused variable `f'.
10828 (x_delete_terminal): Remove unused variable `i'.
10829
10830 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10831 (NOTHING): Remove unused static global variable.
10832 (uniscribe_check_otf): Remove unused variable `table'.
10833 (uniscribe_font_driver): Add missing initializers.
10834
dee091a3
JD
108352011-03-23 Julien Danjou <julien@danjou.info>
10836
10837 * term.c (Fsuspend_tty, Fresume_tty):
10838 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10839 * window.c (temp_output_buffer_show):
10840 * insdel.c (signal_before_change):
10841 * frame.c (Fhandle_switch_frame):
10842 * fileio.c (Fdo_auto_save):
10843 * emacs.c (Fkill_emacs):
10844 * editfns.c (save_excursion_restore):
10845 * cmds.c (internal_self_insert):
10846 * callint.c (Fcall_interactively):
10847 * buffer.c (Fkill_all_local_variables):
10848 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10849 Use Frun_hooks.
0f4a96b5 10850 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 10851 unconditionally since it does the check itself.
dee091a3 10852
2c520ab5 108532011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 10854
c9c49752
PE
10855 Fix more problems found by GCC 4.5.2's static checks.
10856
8abc3f12
PE
10857 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10858 the first time through the loop, since we know p0 < p1 then.
10859 This also avoids a gcc -Wstrict-overflow warning.
10860
a2d26660
PE
10861 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10862 leading to a memory leak, possible in functions like
10863 load_charset_map_from_file that can allocate an unbounded number
b12ef411 10864 of objects (Bug#8318).
a2d26660 10865
916c72e9
PE
10866 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10867 that could (at least in theory) be that large.
10868
19ab8a18
PE
10869 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10870 This is less likely to overflow, and avoids undefined behavior if
10871 overflow does occur. All callers changed. Use strtoul to scan
10872 for the unsigned long integer.
b7cbbd6f
PE
10873 (pint2hrstr): Simplify and tune code slightly.
10874 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 10875
f0641eff
PE
10876 * scroll.c (do_scrolling): Work around GCC bug 48228.
10877 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10878
7f650bb9
PE
10879 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10880 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
10881 (validate_x_resource_name): Simplify count usage.
10882 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 10883
37dd57d1
PE
10884 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10885 fail (Bug#8306).
81e56e61 10886
699979fc 10887 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 10888
401bf9b4
PE
10889 * process.c (Fmake_network_process): Use socklen_t, not int,
10890 where POSIX says socklen_t is required in portable programs.
10891 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 10892 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
10893 (Fmake_network_process, server_accept_connection):
10894 (wait_reading_process_output, read_process_output):
10895 Likewise.
10896
b93aacde
PE
10897 * process.c: Rename or move locals to avoid shadowing.
10898 (list_processes_1, Fmake_network_process):
10899 (read_process_output_error_handler, exec_sentinel_error_handler):
10900 Rename or move locals.
4dc343ee 10901 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 10902 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 10903 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 10904 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 10905 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 10906
af8a867c 10907 Make tparam.h and terminfo.c consistent.
44f230aa
SM
10908 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10909 Include tparam.h instead, since it declares them.
af8a867c
PE
10910 * cm.h (PC): Remove extern decl; tparam.h now does this.
10911 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10912 * terminfo.c: Include tparam.h, to check interfaces.
10913 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10914 (tparam): Adjust signature to match interface in tparam.h;
10915 this removes some undefined behavior. Check that outstring and len
10916 are zero, which they always are with Emacs.
10917 * tparam.h (PC, BC, UP): New extern decls.
10918
0248044d 10919 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 10920 (xftfont_open): Rename locals to avoid shadowing.
0248044d 10921
8ff096c1 10922 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
10923 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10924 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 10925 (ftfont_list): Remove unused local.
49eaafba
PE
10926 (get_adstyle_property, ftfont_pattern_entity):
10927 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10928 Rename locals to avoid shadowing.
8ff096c1 10929
e2be39f6
PE
10930 * xfont.c (xfont_list_family): Mark var as initialized.
10931
c9735e30
PE
10932 * xml.c (make_dom): Now static.
10933
8f5201ae
PE
10934 * composite.c (composition_compute_stop_pos): Rename local to
10935 avoid shadowing.
b246f932
PE
10936 (composition_reseat_it): Remove unused locals.
10937 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 10938 (composition_update_it): Mark var as initialized.
11b61122
PE
10939 (find_automatic_composition): Mark vars as initialized,
10940 with a FIXME (Bug#8290).
8f5201ae 10941
760fbc2c
PE
10942 character.h: Rename locals to avoid shadowing.
10943 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10944 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10945 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10946 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10947 to avoid shadowing.
10948
ff08eb85
PE
10949 * textprop.c (property_change_between_p): Remove; unused.
10950
fc7bf025
PE
10951 * intervals.c (interval_start_pos): Now static.
10952
235d7abc
PE
10953 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10954
44f230aa
SM
10955 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10956 Rename locals to avoid shadowing.
3e7d6594 10957
50060332
PE
10958 * sound.c (wav_play, au_play, Fplay_sound_internal):
10959 Fix pointer signedness.
d01f234b 10960 (alsa_choose_format): Remove unused local var.
c83b8872
PE
10961 (wav_play): Initialize a variable to 0, to prevent undefined
10962 behavior (Bug#8278).
50060332 10963
c4fc4e30
PE
10964 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10965
918436ed
PE
10966 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10967
c939f91b
PE
10968 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10969 clobbering (Bug#8298).
b9c7f648
PE
10970 * sysdep.c (sys_subshell): Likewise.
10971 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 10972
6bd8c144
PE
10973 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10974 This should get cleaned up, so that child_setup has the
10975 same signature on all platforms.
10976
7710357c 10977 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 10978 (relocate_fd): Rename locals to avoid shadowing.
7710357c 10979
c59da222
CY
109802011-03-22 Chong Yidong <cyd@stupidchicken.com>
10981
10982 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10983 not to be necessary, and produces flickering.
10984
66b87493
GM
109852011-03-20 Glenn Morris <rgm@gnu.org>
10986
10987 * config.in: Remove file.
10988
45b6f6d5
JB
109892011-03-20 Juanma Barranquero <lekktu@gmail.com>
10990
10991 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10992 are now in src/globals.h.
10993 (syms_of_minibuf): Remove spurious & from previous change.
10994
cd394be1 109952011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
10996
10997 * minibuf.c (completing-read-function): New variable.
10998 (completing-read-default): Rename from completing-read.
10999 (completing-read): Call completing-read-function.
11000
b14e3e21
CY
110012011-03-19 Juanma Barranquero <lekktu@gmail.com>
11002
11003 * xfaces.c (Fx_load_color_file):
11004 Read color file from absolute filename (bug#8250).
11005
f2b726e6
JB
110062011-03-19 Juanma Barranquero <lekktu@gmail.com>
11007
11008 * makefile.w32-in: Update dependencies.
11009
09f6ff02
EZ
110102011-03-17 Eli Zaretskii <eliz@gnu.org>
11011
11012 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11013
29a6015a
PE
110142011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11015
a3a6c54e
PE
11016 Fix more problems found by GCC 4.5.2's static checks.
11017
b766f867
PE
11018 * process.c (make_serial_process_unwind, send_process_trap):
11019 (sigchld_handler): Now static.
11020
be02381c
PE
11021 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11022 That way, the code declares only the vars that it needs.
11023 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11024 * s/cygwin.h (PTY_ITERATION): Likewise.
11025 * s/darwin.h (PTY_ITERATION): Likewise.
11026 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11027
57048744
PE
11028 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11029 * process.c (allocate_pty): Don't declare stb unless it's needed.
11030
7914961c 11031 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11032 (CONSTANTLIM): Remove; unused.
11033 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11034 Define only if needed.
7914961c 11035
b3967b18
PE
11036 * unexelf.c (unexec): Name an expression,
11037 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11038 Use a different way to cause a compilation error if anyone uses
11039 n rather than nn, a way that does not involve shadowing.
73366a00 11040 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11041
29a6015a
PE
11042 * deps.mk (unexalpha.o): Remove; unused.
11043
43cfc33e 11044 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11045 * unexec.h: New file.
ce701a33
PE
11046 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11047 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11048 Depend on unexec.h.
11049 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11050 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11051 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11052 Change as necessary to match prototype in unexec.h.
ce701a33 11053
01f44d5a
PE
11054 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11055 shadowing.
4f63c6bb 11056 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11057
a6670b0b
PE
11058 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11059 Rename locals to avoid shadowing.
11060
cef2010d 11061 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11062 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11063
d4d7173a
PE
11064 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11065
f08b802a
PE
11066 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11067 warning when compiling print.c.
11068
3ddb0639
PE
11069 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11070 instead of using an uninitialized var.
5ad03b97 11071 (font_sort_entities): Mark var as initialized.
3ddb0639 11072
170a2692
PE
11073 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11074
e663c700
PE
11075 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11076 pointers to constants.
89bc529a 11077 (font_parse_fcname): Remove unused vars.
7b81e2d0 11078 (font_delete_unmatched): Now static.
ea838e10 11079 (font_get_spec): Remove; unused.
13a547c6
PE
11080 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11081 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11082 Rename or move locals to avoid shadowing.
e663c700 11083
2a80c887 11084 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11085 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11086
1384fa33 11087 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11088 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11089
8b2c52e9
PE
11090 * alloc.c (mark_backtrace): Move decl from here ...
11091 * lisp.h: ... to here, so that it can be checked.
11092
475545b5 11093 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11094 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11095 (lisp_indirect_variable): Name an expression,
11096 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11097 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11098
b1349114 11099 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11100 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11101 Use const pointer when appropriate.
b1349114 11102
a2928364
PE
11103 * lisp.h (get_system_name, get_operating_system_release):
11104 Move decls here, to check interfaces.
11105 * process.c (get_operating_system_release): Move decl to lisp.h.
11106 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11107 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11108 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11109 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11110 (Fformat_time_string, Fencode_time, Finsert_char):
11111 (Ftranslate_region_internal, Fformat):
11112 Rename or remove local vars to avoid shadowing.
9710023e 11113 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11114
a415e694
PE
11115 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11116 avoid shadowing.
11117
8ef4622d
PE
11118 * lisp.h (eassert): Check that the argument compiles, even if
11119 ENABLE_CHECKING is not defined.
11120
946f9a5b
PE
11121 * data.c (Findirect_variable): Name an expression, to avoid
11122 gcc -Wbad-function-cast warning.
112396d6 11123 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11124 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11125 (Fmake_variable_buffer_local, Fmake_local_variable):
11126 Mark variables as initialized.
52746918 11127 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11128
e5aab7e7 11129 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11130 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11131 Rename locals to avoid shadowing.
dff45157
PE
11132 (mark_stack): Move local variables into the #ifdef region where
11133 they're used.
7bc26fdb
PE
11134 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11135 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11136 needed otherwise.
11137 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11138 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11139 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11140
e5aab7e7
PE
11141 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11142 avoids undefined behavior in theory.
11143
4da60324
PE
11144 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11145
88043301
PE
11146 Use functions, not macros, for up- and down-casing (Bug#8254).
11147 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11148 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11149 to use the following functions instead of these macros.
11150 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11151 EMACS_INT, since callers assume the returned value fits in int.
11152 (upcase1): Likewise, for UPCASE_TABLE.
11153 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11154 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11155 the race-condition problem in the old DOWNCASE.
88043301 11156
19ed5445
PE
11157 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11158 Rename locals to avoid shadowing.
11159 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11160 (regex_compile, re_search_2, re_match_2_internal):
11161 Remove unused local vars.
952db0d7
PE
11162 (FREE_VAR): Rewrite so as not to use empty "else",
11163 which gcc can warn about.
da053e48 11164 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11165 (RETALLOC_IF): Define only if needed.
11166 (WORDCHAR_P): Likewise. This one is never needed, but is used
11167 only in a comment talking about a compiler bug, so put inside
11168 the #if 0 of that comment.
11169 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11170 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11171 Remove; unused.
19ed5445 11172
1f3561e4 11173 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11174 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11175 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11176
ded6f8f7
PE
11177 * search.c (simple_search): Remove unused var.
11178
dbd37a95
PE
11179 * dired.c (compile_pattern): Move decl from here ...
11180 * lisp.h: ... to here, so that it can be checked.
11181 (struct re_registers): New forward decl.
11182
7e47afad
PE
11183 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11184
85f24f61
PE
11185 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11186 All uses changed.
11187 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11188 Rename locals to avoid shadowing.
5671df8f 11189 (Fvertical_motion): Mark locals as initialized.
85f24f61 11190
181aa2be 11191 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11192 (casify_region): Mark local as initialized.
181aa2be 11193
930d429c
PE
11194 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11195
7082eac6
PE
11196 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11197 New macros, so that the caller can use some names other than
11198 gcpro1, gcpro2, etc.
11199 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11200 of the new macros.
11201 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11202 argument, for consistency with GCPRO2_VAR, etc: it is now the
11203 prefix of the variable, not the variable itself. All uses
11204 changed.
38b2c076
PE
11205 * dired.c (directory_files_internal, file_name_completion):
11206 Rename locals to avoid shadowing.
11207
15206ed9
PE
11208 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11209 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11210 dired.c's scmp function, had undefined behavior.
11211 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11212 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11213 * buffer.h: ... to here, because these macros use current_buffer,
11214 and the new implementation with inline functions needs to have
11215 current_buffer in scope now, rather than later when the macros
11216 are used.
11217 (downcase, upcase1): New static inline functions.
11218 (DOWNCASE, UPCASE1): Reimplement using these functions.
11219 This avoids undefined behavior in expressions like
11220 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11221 from race conditions in accessing the global variables
11222 case_temp1 and case_temp2.
11223 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11224 * lisp.h (case_temp1, case_temp2): Remove their decls.
11225 * character.h (ASCII_CHAR_P): Move from here ...
11226 * lisp.h: ... to here, so that the inline functions mentioned
11227 above can use them.
11228
4a6bea26
PE
11229 * dired.c (directory_files_internal_unwind): Now static.
11230
f14b7e14
PE
11231 * fileio.c (file_name_as_directory, directory_file_name):
11232 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11233 Now static.
2893f146
PE
11234 (file_name_as_directory): Use const pointers when appropriate.
11235 (Fexpand_file_name): Likewise. In particular, newdir might
11236 point at constant storage, so make it a const pointer.
fd4ead52 11237 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11238 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11239 signedness issues.
f839df0c
PE
11240 (Fset_file_times, Finsert_file_contents, auto_save_error):
11241 Rename locals to avoid shadowing.
f14b7e14 11242
5716756e 11243 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11244 (Ftry_completion, Fall_completions): Rename or remove locals
11245 to avoid shadowing.
5716756e 11246
b4c3046a
PE
11247 * marker.c (bytepos_to_charpos): Remove; unused.
11248
b45db522
PE
11249 * lisp.h (verify_bytepos, count_markers): New decls,
11250 so that gcc does not warn that these functions aren't declared.
11251
85876d07
PE
11252 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11253 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11254 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11255 (copy_text): Remove unused local var.
85876d07 11256
03d78a21 11257 * filelock.c (within_one_second): Now static.
b3dd38ab 11258 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11259
5df8f01b
PE
11260 * buffer.c (fix_overlays_before): Mark locals as initialized.
11261 (fix_start_end_in_overlays): Likewise. This function should be
11262 simplified by using pointers-to-pointers, but that's a different
11263 matter.
b1d876f1 11264 (switch_to_buffer_1): Now static.
8f54f30a
PE
11265 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11266 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11267
a70072c9 11268 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11269 Fix pointer signedness issue.
edced198
PE
11270 (sys_subshell): Mark local as volatile if checking for lint,
11271 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11272 (MAXPATHLEN): Define only if needed.
a70072c9 11273
a0977c44
PE
11274 * process.c (serial_open, serial_configure): Move decls from here ...
11275 * systty.h: ... to here, so that they can be checked.
11276
a884fdcc
PE
11277 * fns.c (get_random, seed_random): Move extern decls from here ...
11278 * lisp.h: ... to here, so that they can be checked.
11279
604efe86 11280 * sysdep.c (reset_io): Now static.
b8950c94 11281 (wait_for_termination_signal): Remove; unused.
604efe86 11282
38fc62d9
PE
11283 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11284 (copy_keymap_item, append_key, push_text_char_description):
11285 Now static.
1004a21a 11286 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11287 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11288 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11289 (describe_map_tree):
11290 Rename locals to avoid shadowing.
38fc62d9 11291
2f2650da
PE
11292 * keyboard.c: Declare functions static if they are not used elsewhere.
11293 (echo_char, echo_dash, cmd_error, top_level_2):
11294 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11295 (read_char, kbd_buffer_get_event, make_lispy_position):
11296 (make_lispy_event, make_lispy_movement, apply_modifiers):
11297 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11298 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11299 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11300 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11301 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11302
a053e86c 11303 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11304 (mark_kboards): Move decl here ...
11305 * alloc.c (mark_kboards): ... from here.
a053e86c 11306
4752793e
PE
11307 * lisp.h (force_auto_save_soon): New decl.
11308
74f10ca7 11309 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11310 (DEFINE_DUMMY_FUNCTION): New macro.
11311 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11312 Use it.
c03cd23f
PE
11313 (main): Add casts to avoid warnings
11314 if GCC considers string literals to be constants.
74f10ca7 11315
022e70d4
PE
11316 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11317
59d6fe83
PE
11318 * dbusbind.c: Pointer signedness fixes.
11319 (xd_signature, xd_append_arg, xd_initialize):
11320 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11321 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11322 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11323 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11324
78320123
PE
11325 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11326 if GCC considers string literals to be constants.
49cebcca 11327 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11328
35ac2a97
SM
113292011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11330
fb103ca9
SM
11331 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11332 (print_preprocess, print_object): New macro to fix last change.
11333
35ac2a97
SM
11334 * print.c (print_preprocess): Don't forget font objects.
11335
62973b41
JB
113362011-03-16 Juanma Barranquero <lekktu@gmail.com>
11337
11338 * emacs.c (USAGE3): Doc fixes.
11339
0e48bb22
AS
113402011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11341
11342 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11343 structure.
11344
7684e57b
JB
113452011-03-14 Juanma Barranquero <lekktu@gmail.com>
11346
11347 * lisp.h (VWindow_system, Qfile_name_history):
11348 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11349 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11350 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11351
11352 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11353 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11354
11355 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11356 * w32console.c (detect_input_pending, read_input_pending)
11357 (encode_terminal_code):
11358 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11359 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11360 (w32_system_caret_y, Qfile_name_history):
11361 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11362 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11363 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11364 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11365 * w32proc.c (Qlocal, report_file_error):
11366 * w32term.c (Vwindow_system, updating_frame):
11367 * w32uniscribe.c (initialized, uniscribe_font_driver):
11368 Remove unneeded extern declarations.
11369
2aa46d6c
CY
113702011-03-14 Chong Yidong <cyd@stupidchicken.com>
11371
c96bbc66 11372 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11373
cffc6f3b
CY
113742011-03-13 Chong Yidong <cyd@stupidchicken.com>
11375
11376 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11377 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11378 These macros can no longer be used for assignment.
11379
44f230aa
SM
11380 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11381 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11382 (record_buffer_markers, fetch_buffer_markers): New functions for
11383 recording and fetching special buffer markers.
11384 (set_buffer_internal_1, set_buffer_temp): Use them.
11385
11386 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11387
11388 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11389
11390 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11391 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11392
11393 * xdisp.c (hscroll_window_tree):
11394 (reconsider_clip_changes): Use PT instead of BUF_PT.
11395
d251f04b
EZ
113962011-03-13 Eli Zaretskii <eliz@gnu.org>
11397
11398 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11399 $(EMACS_ROOT)/lib/intprops.h.
11400
f0c77cd1
PE
114012011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11402
3eca4629
PE
11403 Fix more problems found by GCC 4.5.2's static checks.
11404
7c86ee98
PE
11405 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11406 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11407 (xg_free_frame_widgets): Make it clear that a local variable is
11408 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11409 (gdk_window_get_screen): Make it clear that this macro is needed
11410 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11411 (int_gtk_range_get_value): New function, which avoids a diagnostic
11412 from gcc -Wbad-function-cast.
11413 (xg_set_toolkit_scroll_bar_thumb): Use it.
11414 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11415 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11416 (get_utf8_string, xg_get_file_with_chooser):
11417 Rename locals to avoid shadowing.
11418 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11419
41729b81
PE
11420 * xgselect.c (xg_select): Remove unused var.
11421
f0c77cd1
PE
11422 * image.c (four_corners_best): Mark locals as initialized.
11423 (gif_load): Initialize transparent_p to zero (Bug#8238).
11424 Mark another local as initialized.
ec6cf4c6 11425 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11426
ce0ad53d 11427 * image.c (clear_image_cache): Now static.
d5d5a617 11428 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11429 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11430 (x_edge_detection): Remove unnecessary cast that
11431 gcc -Wbad-function-cast diagnoses.
2037898d 11432 (gif_load): Fix pointer signedness.
6ae141d6
PE
11433 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11434 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11435
33383987 114362011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11437
d32df629
PE
11438 Improve quality of tests for time stamp overflow.
11439 For example, without this patch (encode-time 0 0 0 1 1
11440 1152921504606846976) returns the obviously-bogus value (-948597
11441 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11442 reports time overflow. See
11443 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11444 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11445 * editfns.c: Include limits.h and intprops.h.
11446 (TIME_T_MIN, TIME_T_MAX): New macros.
11447 (time_overflow): Move earlier, to before first use.
11448 (hi_time, lo_time): New functions, for an accurate test for
11449 out-of-range times.
11450 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11451 (Fget_internal_run_time): Don't assume time_t fits in int.
11452 (make_time): Use list2 instead of Fcons twice.
11453 (Fdecode_time): More accurate test for out-of-range times.
11454 (check_tm_member): New function.
11455 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11456 (lisp_time_argument): Don't rely on undefined left-shift and
11457 right-shift behavior when checking for time stamp overflow.
8be6f318 11458
fe31d94c
PE
11459 * editfns.c (time_overflow): New function, refactoring common code.
11460 (Fformat_time_string, Fdecode_time, Fencode_time):
11461 (Fcurrent_time_string): Use it.
11462
8be6f318
PE
11463 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11464 * dired.c (make_time): Move to ...
11465 * editfns.c (make_time): ... here.
11466 * systime.h: Note the move.
11467
09d9db2c 114682011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11469
126bc0dc
YM
11470 * fringe.c (update_window_fringes): Remove unused variables.
11471
c47cbdfd
YM
11472 * unexmacosx.c (copy_data_segment): Also copy __got section.
11473 (Bug#8223)
11474
7ac80be9
EZ
114752011-03-12 Eli Zaretskii <eliz@gnu.org>
11476
c96bbc66 11477 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11478 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11479 Constify `char *' arguments and their references according to
11480 prototypes in tparam.h.
11481
ecb0f94d 11482 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11483
7ac80be9
EZ
11484 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11485 Adapt all references accordingly.
11486
11487 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11488
ef1fd07e
TT
114892011-03-11 Tom Tromey <tromey@redhat.com>
11490
11491 * buffer.c (syms_of_buffer): Remove obsolete comment.
11492
7ef4b50c
EZ
114932011-03-11 Eli Zaretskii <eliz@gnu.org>
11494
11495 * termhooks.h (encode_terminal_code): Declare prototype.
11496
11497 * msdos.c (encode_terminal_code): Don't declare prototype.
11498
11499 * term.c (encode_terminal_code): Now external again, used by
11500 w32console.c and msdos.c.
11501
44f230aa
SM
11502 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11503 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11504
4b1ec863 115052011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11506
1714f52b 11507 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11508
4b1ec863
PE
11509 * fringe.c (update_window_fringes): Mark locals as initialized
11510 (Bug#8227).
11511 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11512
524c7aa6
PE
11513 * alloc.c (mark_fringe_data): Move decl from here ...
11514 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11515 to check its interface.
11516 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11517
a5c0af81 11518 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11519 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11520 (fontset_font): Mark local as initialized.
a9a06e0b 11521 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11522
b4716021
PE
11523 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11524
811e9bac 11525 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11526 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11527 (x_own_selection, Fx_disown_selection_internal): Rename locals
11528 to avoid shadowing.
11529 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11530
7e3ab302
PE
11531 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11532 so that the caller can use some name other than gcpro1.
11533 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11534 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11535 (Fx_backspace_delete_keys_p):
11536 Use them to avoid shadowing, and rename vars to avoid shadowing.
11537 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11538 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11539 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11540 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11541 Remove unused locals.
7e3ab302
PE
11542 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11543 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11544 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11545 macros.
f78faa98 11546
e2b13473
PE
11547 * xterm.h (x_mouse_leave): New decl.
11548
77f23912
PE
11549 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11550 Remove unused functions.
cdf4ba58
PE
11551 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11552 (x_calc_absolute_position): Now static.
7411c686 11553 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11554 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11555 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11556 unless they are used.
38d0b34a
PE
11557 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11558 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11559 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11560 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11561 (x_error_catcher, x_connection_closed, x_error_handler):
11562 (x_error_quitter, xembed_send_message, x_iconify_frame):
11563 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 11564 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 11565 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 11566
44f230aa
SM
11567 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11568 Rename or move locals to avoid shadowing.
6b463e58 11569 (tty_defined_color, merge_face_heights): Now static.
5967d051 11570 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
11571 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11572 does not deduce is never used uninitialized.
73719eba
PE
11573 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11574 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 11575
426994c3 11576 * terminal.c (store_terminal_param): Now static.
5489860b 11577
032f1620 11578 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 11579 (set_frame_menubar): Remove unused local.
d4323972 11580 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
11581 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11582 since they might point to immutable storage.
281585b0
PE
11583 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11584 since it's unused otherwise.
032f1620 11585
367c19e5 11586 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 11587 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
11588 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11589 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 11590 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
11591 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11592 does not deduce are never used uninitialized.
70739cbe 11593
07b48fa9
PE
11594 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11595
8868a238 11596 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
11597 * window.c (window_loop, size_window):
11598 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 11599
7e5cf297 11600 * window.c (display_buffer): Now static.
d6550a9f
PE
11601 (size_window): Mark variables that gcc -Wuninitialized
11602 does not deduce are never used uninitialized.
a586633d
PE
11603 * window.h (check_all_windows): New decl, to forestall
11604 gcc -Wmissing-prototypes diagnostic.
5b555da1 11605 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 11606
f6095868
PE
11607 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11608 shadowing.
11609 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
11610 Include <limits.h>.
11611 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11612 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
11613 (load_charset_map): Mark variables that gcc -Wuninitialized
11614 does not deduce are never used uninitialized.
53df7c11 11615 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 11616
f38b440c
PE
11617 * coding.c (coding_set_source, coding_set_destination):
11618 Use "else { /* comment */ }" rather than "else /* comment */;"
11619 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
11620 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11621 a block, when the outer 'i' will do.
11622 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11623 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11624 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11625 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11626 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11627 Rename locals to avoid shadowing.
11628 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
11629 * coding.c (emacs_mule_char, encode_invocation_designation):
11630 Now static, since they're not used elsewhere.
413bb2db 11631 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 11632 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
11633 (decode_coding_emacs_mule): Mark variables that gcc
11634 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
11635 (detect_coding_iso_2022): Initialize a local variable that might
11636 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 11637 this initialization is needed. (Bug#8211)
5f58e762
PE
11638 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11639 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11640 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11641 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11642 Remove unused macros.
f38b440c 11643
232b38b9 11644 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 11645 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 11646 * character.c (string_count_byte8): Likewise.
232b38b9 11647
fb90da1b
PE
11648 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11649 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11650
fb93dbc2
PE
11651 * chartab.c (copy_sub_char_table): Now static, since it's not used
11652 elsewhere.
5c156ace
PE
11653 (sub_char_table_ref_and_range, char_table_ref_and_range):
11654 Rename locals to avoid shadowing.
bbcd0949 11655 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 11656
7d3b3862 11657 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 11658 (BIDI_BOB): Remove unused macro.
7d3b3862 11659
6be7d3da
PE
11660 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11661 deduce are never used uninitialized.
c2ed9c8b 11662 * term.c (encode_terminal_code): Likewise.
6be7d3da 11663
75f8807f 11664 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 11665
50938595
PE
11666 * tparam.h: New file.
11667 * term.c, tparam.h: Include it.
11668 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11669 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11670 Move these decls to tparam.h, and make them agree with what
11671 is actually in tparam.c. The previous trick of using incompatible
11672 decls in different modules does not conform to the C standard.
11673 All callers of tparam changed to use tparam's actual API.
11674 * tparam.c (tparam1, tparam, tgoto):
11675 Use const pointers where appropriate.
11676
fbceeba2
PE
11677 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11678 * cm.h (struct cm): Likewise.
11679 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11680 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11681 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11682 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11683 (turn_on_face, init_tty): Likewise.
11684 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 11685
7f3f1250
PE
11686 * term.c (term_mouse_position): Rename local to avoid shadowing.
11687
e6ca6543
PE
11688 * alloc.c (mark_ttys): Move decl from here ...
11689 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11690
c40f8d15
AS
116912011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11692
11693 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11694
cfe0661d
JB
116952011-03-09 Juanma Barranquero <lekktu@gmail.com>
11696
11697 * search.c (compile_pattern_1): Remove argument regp, unused since
11698 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11699 (compile_pattern): Don't pass it.
11700
0afb4571
J
117012011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11702
11703 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11704 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11705 for ! HAVE_GTK3.
11706 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11707
11708 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11709
11710 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11711 gdk_window_get_screen, gdk_window_get_geometry,
11712 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11713 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11714 (xg_get_pixbuf_from_pixmap): New function.
11715 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11716 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11717 Call xg_get_pixbuf_from_pixmap instead of
11718 gdk_pixbuf_get_from_drawable.
11719 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11720 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11721 (xg_check_special_colors): Use GtkStyleContext and its functions
11722 for HAVE_GTK3.
11723 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11724 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11725 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
11726 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11727 Call gtk_widget_get_preferred_size.
0afb4571
J
11728 (xg_frame_resized): gdk_window_get_geometry only takes 5
11729 parameters.
44f230aa
SM
11730 (xg_win_to_widget, xg_event_is_for_menubar):
11731 Call gdk_x11_window_lookup_for_display.
0afb4571
J
11732 (xg_set_widget_bg): New function.
11733 (delete_cb): New function.
895009e1 11734 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 11735 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
11736 (xg_set_background_color): Call xg_set_widget_bg.
11737 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11738 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11739 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11740 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11741 if ! HAVE_GTK3.
11742 (update_frame_tool_bar): Call gtk_widget_hide.
11743 (xg_initialize): Use GDK_KEY_g.
11744
11745 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11746 if ! HAVE_GTK3
11747 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11748
11749 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11750 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11751 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11752
1c2cc4ef
JB
117532011-03-08 Juanma Barranquero <lekktu@gmail.com>
11754
11755 * w32xfns.c (select_palette): Check success of RealizePalette against
11756 GDI_ERROR, not zero.
11757
33383987 11758See ChangeLog.11 for earlier changes.
aac0c6e3
MR
11759
11760;; Local Variables:
11761;; coding: utf-8
aac0c6e3
MR
11762;; End:
11763
2f097256 11764 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
11765
11766 This file is part of GNU Emacs.
11767
11768 GNU Emacs is free software: you can redistribute it and/or modify
11769 it under the terms of the GNU General Public License as published by
11770 the Free Software Foundation, either version 3 of the License, or
11771 (at your option) any later version.
11772
11773 GNU Emacs is distributed in the hope that it will be useful,
11774 but WITHOUT ANY WARRANTY; without even the implied warranty of
11775 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11776 GNU General Public License for more details.
11777
11778 You should have received a copy of the GNU General Public License
11779 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.