Move AMPERSAND_FULL_NAME, subprocesses from conf_post.h to configure.ac
[bpt/emacs.git] / src / ChangeLog
CommitLineData
8d8e2dfe
GM
12012-07-31 Glenn Morris <rgm@gnu.org>
2
3 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
4 Move to configure.ac.
5
5b20b3cc
EZ
62012-07-31 Eli Zaretskii <eliz@gnu.org>
7
1e0afd9a
EZ
8 * .gdbinit (xframe): Adapt to introduction of FVAR and the
9 resulting renaming of 'struct frame' members.
10
5b20b3cc
EZ
11 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
12
13 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
14 after introduction of FVAR.
15
f1310128
JD
162012-07-31 Jan Djärv <jan.h.d@swipnet.se>
17
79e721e0
JD
18 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
19
20 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
21 instead of compositeToPoint.
22 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
23
f1310128
JD
24 * nsfns.m, nsmenu.m, msterm.m: Adopt to struct frame/FVAR changes.
25
e34f7f79
DA
262012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
27
28 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
29 * lisp.h (INTERNAL_FIELD): New macro.
30 * buffer.h (BUFFER_INTERNAL_FIELD): Removed.
31 (BVAR): Change to use INTERNAL_FIELD.
32 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
33 (KVAR): Change to use INTERNAL_FIELD.
34 * frame.h (FVAR): New macro.
35 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
36 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c
37 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c
38 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h,
39 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
40
c09bfb2f
DA
412012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
42
43 Miscellaneous fixes for non-default X toolkits.
44 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
45 * xterm.c (x_frame_of_widget): Remove redundant prototype.
46 Move under #ifdef USE_LUCID.
47 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
48 definition and usage to avoid warnings.
49
14c114ae
JD
502012-07-31 Jan Djärv <jan.h.d@swipnet.se>
51
52 * nsterm.m (openFiles): Fix previous checkin.
53
3bd21e82
PE
542012-07-31 Paul Eggert <eggert@cs.ucla.edu>
55
56 * indent.c (compute_motion): Remove unused local.
57
c1529ded
GM
582012-07-31 Glenn Morris <rgm@gnu.org>
59
400d5621
GM
60 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
61
268e2432
GM
62 * conf_post.h [USG5_4]:
63 Move remaining contents of s/usg5-4-common.h here.
64 * s/usg5-4-common.h: Remove file.
65
7552f3ee
GM
66 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
67 * s/irix6-5.h: Remove file.
68
6a381852
GM
69 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
70 * s/darwin.h: Remove file.
71
c1529ded
GM
72 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
73 * s/hpux10-20.h: Remove file, which is now empty.
74
b429a4ee
GM
752012-07-30 Glenn Morris <rgm@gnu.org>
76
77 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
78 * Makefile.in (config_h): Add conf_post.h.
79 * makefile.w32-in (CONFIG_H): Add conf_post.h.
80
adff3182
JD
812012-07-30 Jan Djärv <jan.h.d@swipnet.se>
82
83 * nsterm.m (ns_do_open_file): New variable.
b9031d69 84 (ns_term_init): Set ns_do_open_file to YES after run returns.
adff3182
JD
85 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
86 files only if ns_do_open_file.
87
c32af1e4
PE
882012-07-30 Paul Eggert <eggert@cs.ucla.edu>
89
7393bcbb
PE
90 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
91 This no-op macro hasn't been needed for many years.
92 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
93
c32af1e4
PE
94 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
95 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
96 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
97 gdb_make_enums_visible.
98 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
99 (DIRECTORY_SEP): Now a constant, not a macro.
100
302fc036
EZ
1012012-07-30 Eli Zaretskii <eliz@gnu.org>
102
103 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
104 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
105
106 * w32term.c <w32_keyboard_codepage>: Renamed from
107 keyboard_codepage and now external. All users changed.
108
109 * w32term.h: Add declaration of w32_keyboard_codepage.
110
111 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
112 the codepage to translate keys to Unicode. If this argument is
113 -1, use the value returned by GetConsoleCP. All callers changed.
114
88fb40b4
PE
1152012-07-30 Paul Eggert <eggert@cs.ucla.edu>
116
0aee6912
PE
117 Update .PHONY listings in makefiles.
118 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
119 bootstrap-clean, distclean, maintainer-clean, versioclean,
120 extraclean, frc.
121
88fb40b4
PE
122 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
123 This is a bit clearer. Fix some commentary typos.
124
0a763bd1
GM
1252012-07-30 Glenn Morris <rgm@gnu.org>
126
32bac6d6
GM
127 * s/netbsd.h: Let configure include signal.h if needed.
128 Remove file, which is now empty.
129
b65e7c46
GM
130 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
131 Let configure set them.
132 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
133 No more need to undefine.
0a763bd1 134
169304bd
AS
1352012-07-30 Andreas Schwab <schwab@linux-m68k.org>
136
137 * keymap.c (Fkey_description): Don't remove 0x80 bit from
138 non-single-byte char when adding meta modifier. (Bug#12090)
139
6cd7a139
DA
1402012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
141
142 Convert safe_call to use variable number of arguments.
143 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
144 (safe_call2): Fix comment.
145 * lisp.h (safe_call): Adjust prototype.
146 * coding.c (encode_coding_object): Change to use safe_call2.
147 * xfaces.c (merge_face_heights): Change to use safe_call1.
148
d34d6ffc
GM
1492012-07-30 Glenn Morris <rgm@gnu.org>
150
7b8a48e4 151 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 152 does that unconditionally. Remove file, which is now empty.
7b8a48e4 153
d34d6ffc
GM
154 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
155 Remove empty files.
156
03a660a6
PE
1572012-07-30 Paul Eggert <eggert@cs.ucla.edu>
158
159 Export to GDB most of lisp.h's remaining object-like macros.
160 * lisp.h (min, max): Move earlier, because they're used earlier now.
161 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
162 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
163 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
164 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
165 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
166 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
167 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
168 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
169 Now constants, for GDB. They need not be macros.
170 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
171 Now constants, for GDB, as well as macros, for static initializers.
172 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
173 Move to after the definition of struct Lisp_Char_Table,
174 since the former now needs that type defined.
175 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
176 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
177 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
178 New enums, for gdb_make_enums_visible.
179 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 180 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
181 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
182 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
183 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
184 enum maxargs, enum MAX_ALLOCA.
185 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
186 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
187 no longer needed, now that they are done in lisp.h.
188
e499d0ee
DA
1892012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
190
191 Cleanup string bytes checking.
192 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
193 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
194 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
195 (check_sblock, compact_small_strings): Simplify.
196
d5040d2d
PE
1972012-07-29 Paul Eggert <eggert@cs.ucla.edu>
198
199 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
200 These macros are confusing and no longer need to be defined, as
201 the enum values now suffice. All uses replaced with definiens.
202 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
203
7f259ae6
JB
2042012-07-29 Juanma Barranquero <lekktu@gmail.com>
205
206 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
207 ($(BLD)/w32console.$(O)): Update dependencies.
208
7e63e0c3
DA
2092012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
210
211 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
212 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
213 time. Adjust users.
214 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
215
ffd817eb
JD
2162012-07-29 Jan Djärv <jan.h.d@swipnet.se>
217
218 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
219 setting sitelisp (Bug#12010).
220
417a7a0e
EZ
2212012-07-29 Eli Zaretskii <eliz@gnu.org>
222
223 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
224
225 * w32heap.c (cache_system_info):
226 * w32.c (sys_rename):
227 * w32proc.c (find_child_console, sys_kill): All users changed.
228
387d4d92
PE
2292012-07-29 Paul Eggert <eggert@cs.ucla.edu>
230
231 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
232
55a6cca6
EZ
2332012-07-29 Eli Zaretskii <eliz@gnu.org>
234
235 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
236
dbcf001c
DA
2372012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
238
239 Cleanup statistics calculation in Fgarbage_collect.
240 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
241 zombies percentage calculation. Simplify elapsed time calculation.
242
e2688e4a
DA
2432012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
244
245 Generalize marker debugging code under MARKER_DEBUG and use eassert.
246 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
247 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
248 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
249 (replace_range, replace_range_2, del_range_2): Change to eassert.
250 * marker.c (byte_char_debug_check): Adjust style.
251
b46a6a83
PE
2522012-07-29 Paul Eggert <eggert@cs.ucla.edu>
253
254 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
255 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
256 long-ago-commented-out code that talks about "WIN32".
257 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
258 All uses changed.
259
e32a5799
PE
2602012-07-28 Paul Eggert <eggert@cs.ucla.edu>
261
262 Use Gnulib stdalign module (Bug#9772, Bug#9960).
263 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
264 Simplify by using alignof.
265 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
266 * lisp.h: Include <stdalign.h>.
267 (GCALIGNMENT): New macro and constant.
268 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
269 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
270 (stdalign): New macro, if not already defined.
271
df81cd29
EZ
2722012-07-28 Eli Zaretskii <eliz@gnu.org>
273
01bd1b0d
EZ
274 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
275 * w32inevt.c: Include w32inevt.h.
276 (w32_read_console_input): New inline function, calls either
277 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
278 w32_console_unicode_input.
279 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
280 (w32_kbd_patch_key, key_event): Use the codepage returned by
281 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
282 (key_event): use uChar.UnicodeChar only if
283 w32_console_unicode_input is non-zero.
284
285 * w32console.c: Include w32heap.h.
286 <w32_console_unicode_input>: New global variable.
287 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
288 family of Windows, zero otherwise.
289
290 * w32inevt.h: Declare w32_console_unicode_input.
291
df81cd29
EZ
292 * xdisp.c (init_iterator): Don't reference tip_frame in a build
293 --without-x. (Bug#11742)
294
c20fdd9e
PE
2952012-07-27 Paul Eggert <eggert@cs.ucla.edu>
296
297 Adjust GDB to reflect pvec_type changes (Bug#12036).
298 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
299 2012-07-04 changes to pseudovector representation. Problem
300 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
301
32770973 3022012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
303
304 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
305 bus address.
306 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
307
3438fe21
EZ
3082012-07-27 Eli Zaretskii <eliz@gnu.org>
309
bcfbc9de
EZ
310 * alloc.c (listn): Fix the order the arguments are consed onto the
311 list.
312
3438fe21
EZ
313 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
314 enumeration constants, as PURE and HEAP are too general, and clash
315 with other headers and sources, such as gmalloc.c and the
316 MS-Windows system headers. All users changed.
317
eeaea515
DA
3182012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
319
320 Revert last save_excursion_save and save_excursion_restore changes.
321 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
322 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
323
073c88c2
DA
3242012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
325
326 Fix recently-introduced typos in Windows port.
327 Reported by Martin Rudalics <rudalics@gmx.at>.
328 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 329 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 330
4706125e
PE
3312012-07-27 Paul Eggert <eggert@cs.ucla.edu>
332
333 Improve GDB symbol export (Bug#12036).
334 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
335 arms of an 'if', not using conditional expressions; otherwise GDB
336 complains about the types in the unevaluated arm when the argument
337 is an integer literal.
338 (xgetint): Simplify expression.
339 * alloc.c (gdb_make_enums_visible): New constant. This ports to
340 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
341 Zaretskii in <http://bugs.gnu.org/12036#13>.
342 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
343 needed now that we have gdb_make_enums_visible.
344 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
345 (enum enum_USE_LSB_TAG):
346 New enum types, packaging up enums that need to be exported to GDB.
347
694b6c97
DA
3482012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
349
350 Utility function to make a list from specified amount of objects.
351 * lisp.h (enum constype): New datatype.
352 (listn): New prototype.
353 * alloc.c (listn): New function.
354 (Fmemory_use_count, syms_of_alloc): Use it.
355 * buffer.c (syms_of_buffer): Likewise.
356 * callint.c (syms_of_callint): Likewise.
357 * charset.c (define_charset_internal): Likewise.
358 * coding.c (syms_of_coding): Likewise.
359 * keymap.c (syms_of_keymap): Likewise.
360 * search.c (syms_of_search): Likewise.
361 * syntax.c (syms_of_syntax): Likewise.
362 * w32.c (init_environment): Likewise.
363 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
364 * xdisp.c (syms_of_xdisp): Likewise.
365 * xfns.c (syms_of_xfns): Likewise.
366
6195f384
DA
3672012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
368
369 Fast save_excursion_save and save_excursion_restore.
370 * lisp.h (struct Lisp_Excursion): New data type.
371 (PVEC_EXCURSION): New pseudovector type.
372 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
373 to deal with it. Adjust comments.
374 (init_marker, attach_marker): New prototype.
375 (unchain_marker): Adjust prototype.
376 * marker.c (attach_marker): Change to global.
377 (init_marker): New function.
378 * alloc.c (Fmake_marker, build_marker): Use it.
379 (build_marker): More easserts.
380 (mark_object): Handle struct Lisp_Excursion.
381 * editfns.c (save_excursion_save, save_excursion_restore):
382 Reimplement to use struct Lisp_Excursion. Add comments.
383
5eceb8fb
PE
3842012-07-26 Paul Eggert <eggert@cs.ucla.edu>
385
386 Fix export of symbols to GDB (Bug#12036).
387 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
388 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
389 emacs.c, as this is a more-suitable home. Had this been done earlier
390 the fix for 12036 would have avoided some of the problems noted in
391 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
392 would have been more obvious.
562157c8
PE
393 * emacs.c: Do not include <verify.h>; no longer needed.
394 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
395 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
396 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
397 Remove; now done in lisp.h.
398 * lisp.h (PUBLISH_TO_GDB): New macro.
399 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
400 (DATA_SEG_BITS): Use it.
401 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
402 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
403 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
404 not be usable in #if. This simplifies things.
405
d6749401
JB
4062012-07-26 Juanma Barranquero <lekktu@gmail.com>
407
408 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
409
1781b9e9
PE
4102012-07-26 Paul Eggert <eggert@cs.ucla.edu>
411
d89518db 412 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
413 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
414 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
415 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
416 Adjust to changes in lisp.h and emacs.c, by using
417 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
418 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
419 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
420 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
421 instead of gdb_valbits.
422 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
423 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
424 instead of gdb_array_mark_flag.
425 (xboolvector): Get size from $->size, not $->header.size.
426 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
427 (xreload, hook-run, hookpost-run): Remove.
428 * emacs.c: Include <verify.h>.
429 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
430 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
431 Remove.
432 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
433 (gdb_USE_LSB_TAG): New enum constants.
434 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
435 Also define these as enum constants, so they're visible to GDB.
436 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
437 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
438 as constants, so they're visible to GDB.
439 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
440 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
441 Now enum constants, not macros, so they're visible to GDB.
442 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
443 more convenient now. All uses changed.
444 (VALMASK) [USE_LSB_TAG]: Also define in this case.
445 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
446
3628596a
DA
4472012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
448
449 Explicitly free restriction data that are not needed anymore.
450 * editfns.c (save_restriction_restore): Free restriction data.
451
7abaf5cc
SM
4522012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
453
454 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
455 add argument, tune behavior, and adjust all callers.
456
71f88e00
PE
4572012-07-25 Paul Eggert <eggert@cs.ucla.edu>
458
459 Use typedef for EMACS_INT, EMACS_UINT.
460 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
461 than macros. This simplifies debugging in the usual case, since
462 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
463 and it allows expressions involving EMACS_INT casts.
464 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
465
57ec3034
JD
4662012-07-25 Jan Djärv <jan.h.d@swipnet.se>
467
468 * nsterm.m (ns_read_socket): Return early if there is a modal
469 window (Bug#12043).
470
8137e7b3
MR
4712012-07-25 Martin Rudalics <rudalics@gmx.at>
472
473 * frame.c (Fredirect_frame_focus): In doc-string don't mention
474 that FOCUS-FRAME can be omitted.
475
04e9897c
DA
4762012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
477
478 Adjust buffer text indirection counters at the end of Fkill_buffer.
479 * buffer.c (Fkill_buffer): Adjust indirection counters when the
480 buffer is definitely dead. This should really fix an issue reported
481 by Christoph Scholtes again. (Bug#12007).
482 (init_buffer_once): Initialize indirection counters of
483 buffer_defaults and buffer_local_symbols (for sanity and safety).
484
8a0484e1
EZ
4852012-07-24 Eli Zaretskii <eliz@gnu.org>
486
487 * xdisp.c (init_iterator): Don't compute dimensions of truncation
488 and continuation glyphs on tooltip frames, leave them at zero.
489 Avoids continued lines in tooltips. (Bug#11832)
490
fa691a83
DA
4912012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
492
493 Simplify copy_overlay.
04e9897c 494 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
495 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
496
436bc8e0
EZ
4972012-07-23 Eli Zaretskii <eliz@gnu.org>
498
499 * print.c (print_object): Don't crash when a frame's name is nil
500 or invalid. (Bug#12025)
501
502 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
503 it signals an error when a tooltip frame is being created.
504
d7a7fda3
DA
5052012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
506
507 Cleanup miscellaneous objects allocation and initialization.
508 * alloc.c (allocate_misc): Change to static. Add argument to
509 specify the subtype. Adjust comment and users.
510 (build_overlay): New function.
511 * buffer.c (copy_overlays, Fmake_overlay): Use it.
512 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
513 (allocate_misc): Remove prototype.
514 (build_overlay): Add prototype.
515
5162012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
517
518 Swap buffer text indirection counters in Fbuffer_swap_text.
519 * buffer.c (Fbuffer_swap_text): Swap indirections too.
520 This avoids crash reported by Christoph Scholtes at
521 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
522
9d7fa573
JD
5232012-07-22 Jan Djärv <jan.h.d@swipnet.se>
524
525 * nsmenu.m (Popdown_data): New struct.
526 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
527 free Popdown_data.
528 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
529 (initWithContentRect): Make imgView and contentView non-static
530 and autorelease them. Also autorelease img and matrix (Bug#12005).
531 (dealloc): Remove (Bug#12005).
532
0dd6d66d
DA
5332012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
534
535 Adjust consing_since_gc when objects are explicitly freed.
536 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
537 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
538 (free_cons, free_misc): Subtract object size from consing_since_gc.
539
d36d71df
DA
5402012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
541
542 Simplify and cleanup markers positioning code.
543 * marker.c (attach_marker): More useful eassert.
544 (live_buffer, set_marker_internal): New function.
545 (Fset_marker, set_marker_restricted): Use set_marker_internal.
546 (set_marker_both, set_marker_restricted_both): Use live_buffer.
547
fb9ea40f
PE
5482012-07-22 Paul Eggert <eggert@cs.ucla.edu>
549
550 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
551 as it's limited by the amount of memory, not by INT_MAX.
552
2d5c5f7d
EZ
5532012-07-21 Eli Zaretskii <eliz@gnu.org>
554
07fb592e
EZ
555 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
556 in special-event-map. See the discussion at
557 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
558 for the reasons.
559
37a9eac8 560 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
561 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
562 Fabrice Popineau <fabrice.popineau@supelec.fr>.
563
c4328746
JD
5642012-07-21 Jan Djärv <jan.h.d@swipnet.se>
565
566 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 567 (conversationIdentifier): Return value is NSInteger.
784051c4 568 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 569
6e5d1c12
CY
5702012-07-21 Chong Yidong <cyd@gnu.org>
571
572 * window.c (decode_any_window): Signal an error if the window is
573 on a dead frame (Bug#11984).
574
9928463d
DA
5752012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
576
577 Add indirection counting to speed up Fkill_buffer.
578 * buffer.h (struct buffer): New member.
579 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
580 (Fmake_indirect_buffer): Set indirection counter to -1, increment
581 base buffer indirection counter.
582 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
583 (Fkill_buffer): Adjust indirection counters as needed, don't walk
584 through buffer list if indirection counter is 0.
585
f8643a6b
DA
5862012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
587
588 Extend the value returned by Fgarbage_collect with heap statistics.
589 * alloc.c (Qheap): New symbol.
590 (syms_of_alloc): DEFSYM it.
591 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
592 (Fmemory_free): Remove.
593 (syms_of_alloc): Don't defsubr it.
594 * buffer.c (Fcompact_buffer): Remove.
595 (syms_of_buffer): Don't defsubr it.
596
dac616ff
DA
5972012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
598
599 Make maybe_gc inline.
600 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
601 * lisp.h (consing_since_gc, gc_relative_threshold)
602 (memory_full_cons_threshold): Revert declaration.
603 (maybe_gc): Remove prototype, define as inline.
604 * alloc.c: Remove old commented-out code.
605 (consing_since_gc, gc_relative_threshold)
606 (memory_full_cons_threshold): Revert to global.
607 (maybe_gc): Remove.
608
d7ea76b4
DA
6092012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
610
611 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
612 * lisp.h (build_unibyte_string): New function.
613 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
614 * sysdep.c, w32fns.c, xfns.c: Use it.
615 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
616 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
617 Adjust users accordingly.
618 * font.h (font_open_by_name): Adjust prototype.
619
765e61e3
DA
6202012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
621
622 Cleanup calls to Fgarbage_collect.
623 * lisp.h (maybe_gc): New prototype.
624 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
625 Remove declarations.
626 * alloc.c (maybe_gc): New function.
627 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
628 Make them static.
629 * bytecode.c (MAYBE_GC): Use maybe_gc.
630 * eval.c (eval_sub, Ffuncall): Likewise.
631 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
632 to avoid dependency from auto-save feature.
633
52b852c7
PE
6342012-07-19 Paul Eggert <eggert@cs.ucla.edu>
635
636 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
637 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
638 'for_each_per_buffer_object_at'.
639 All uses changed. It's better to use upper-case for macros that
640 cannot be implemented as functions, to give the reader a clue
641 that they're special.
642
5db81e33
SM
6432012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
644
645 * alloc.c (Fgarbage_collect): Tweak docstring.
646
5b835e1d
DA
6472012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
648
649 Tweak the value returned from Fgarbage_collect again.
650 * alloc.c (Fgarbage_collect): New return value, as confirmed in
651 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
652 Adjust documentation.
653 (total_vector_bytes): Rename to total_vector_slots, adjust
654 accounting.
655 (total_free_vector_bytes): Rename to total_free_vector_slots,
656 adjust accounting.
657 (Qstring_bytes, Qvector_slots): New symbols.
658 (syms_of_alloc): DEFSYM them.
659
9cd47b72
DA
6602012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
661
662 Buffer compaction primitive which may be used from Lisp.
663 * buffer.c (compact_buffer, Fcompact_buffer): New function.
664 (syms_of_buffer): Register Fcompact_buffer.
665 * alloc.c (Fgarbage_collect): Use compact_buffer.
666 * buffer.h (compact_buffer): New prototype.
667 (struct buffer_text): New member.
668
d17337e5
DA
6692012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
670
671 New macro to iterate over all buffers, miscellaneous cleanups.
672 * lisp.h (all_buffers): Remove declaration.
673 * buffer.h (all_buffers): Add declaration, with comment.
674 (for_each_buffer): New macro.
675 * alloc.c (Fgarbage_collect, mark_object): Use it.
676 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
677 (init_buffer): Likewise.
678 * data.c (Fset_default): Likewise.
679 * coding.c (code_conversion_restore): Remove redundant check
680 for dead buffer.
681 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
682
60cfd278
AS
6832012-07-18 Andreas Schwab <schwab@linux-m68k.org>
684
685 Fix bug that created negative-length intervals.
686 * intervals.c (merge_interval_right, merge_interval_left):
687 Do not zero out this interval if it is absorbed by its children,
688 as this interval's total length doesn't change in that case. See
689 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
690
d06714cb
PE
6912012-07-18 Paul Eggert <eggert@cs.ucla.edu>
692
83713154
PE
693 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
694 when invoking (make-bool-vector N t) and N is a positive
695 multiple of 8 -- the last 8 bits were mistakenly cleared.
696
d06714cb
PE
697 Remove some struct layout assumptions in bool vectors.
698 * alloc.c (bool_header_size): New constant.
699 (header_size, word_size): Move earlier, as they're now used earlier.
700 Use 'word_size' in a few more places, where it's appropriate.
701 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
702 padding before the data member of a bool vector.
703 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
704 than doing the check by hand with an abort ().
705
464d5a5e
SM
7062012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
707
5fbc0409
SM
708 * eval.c (Fdefvar): Don't check constants since we only set the var if
709 it's not yet defined anyway (bug#11904).
710
464d5a5e
SM
711 * lisp.h (last_undo_boundary): Declare new var.
712 * keyboard.c (command_loop_1): Set it.
713 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
714 were auto-added by the command loop (bug#11774).
715
8dc2e44a
AS
7162012-07-18 Andreas Schwab <schwab@linux-m68k.org>
717
718 * w32font.c (Qsymbol): Remove local definition.
719 (syms_of_w32font): Don't DEFSYM it.
720
169925ec
DA
7212012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
722
723 Fix sweep_vectors to handle large bool vectors correctly.
724 * alloc.c (sweep_vectors): Account total_vector_bytes for
725 bool vectors larger than VBLOCK_BYTES_MAX.
726
5fbfb018
CY
7272012-07-18 Chong Yidong <cyd@gnu.org>
728
729 * frame.c (x_set_frame_parameters): Revert bogus change introduced
730 in 2012-05-25 commit by Paul Eggert (Bug#11738).
731
3ab6e069
DA
7322012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
733
734 Return more descriptive data from Fgarbage_collect.
735 Suggested by Stefan Monnier in
736 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
737 * alloc.c (bounded_number): New function.
738 (total_buffers, total_vectors): New variable.
739 (total_string_size): Rename to total_string_bytes, adjust users.
740 (total_vector_size): Rename to total_vector_bytes, adjust users.
741 (sweep_vectors): Account total_vectors and total_vector_bytes.
742 (Fgarbage_collect): New return value. Adjust documentation.
743 (gc_sweep): Account total_buffers.
744 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
745 (VECTOR_SIZE): Remove.
746 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
747 (Qinterval, Qmisc): New symbols.
748 (syms_of_data): Initialize them.
749 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
750 (Qcons, Qbuffer): New declarations.
751
6d02fe5b
PE
7522012-07-17 Paul Eggert <eggert@cs.ucla.edu>
753
754 * alloc.c (Fmemory_free): Account for memory-free's own storage.
755 Round up, not down. Improve doc.
756
b7ffe040
DA
7572012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
758
759 Restore old code in allocate_string_data to avoid Faset breakage.
760 Reported by Julien Danjou <julien@danjou.info> in
761 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
762 * alloc.c (allocate_string_data): Restore old code with minor
763 adjustments, fix comment to explain this subtle issue.
764
4dc7c8d5
SM
7652012-07-17 Eli Zaretskii <eliz@gnu.org>
766
767 Remove FILE_SYSTEM_CASE.
768 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
769
770 * fileio.c (FILE_SYSTEM_CASE): Don't define.
771 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
772 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
773 call-process-region passes it through expand-file-name.
774
775 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
776
7772012-07-17 Andreas Schwab <schwab@linux-m68k.org>
778
779 Fix crash when creating indirect buffer (Bug#11917)
780 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
781 Don't handle unbound variables specially if non-zero.
782 (Fbuffer_local_variables): Pass zero.
783 (clone_per_buffer_values): Pass non-zero.
784
7852012-07-17 Andreas Schwab <schwab@linux-m68k.org>
786
787 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
788 to make the loop interruptible.
789
7902012-07-17 Andreas Schwab <schwab@linux-m68k.org>
791
792 * gnutls.c (emacs_gnutls_handshake): Only retry if
793 GNUTLS_E_INTERRUPTED.
794
cce7fefc
DA
7952012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
796
797 Cleanup and convert miscellaneous checks to eassert.
798 * alloc.c (mark_interval): Fix comment, partially rephrase
799 old comment from intervals.h (see below).
800 * intervals.c (find_interval, adjust_intervals_for_insertion)
801 (delete_interval, adjust_intervals_for_deletion)
802 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
803 Convert to eassert.
804 (adjust_intervals_for_insertion, make_new_interval):
805 Remove obsolete and unused code.
806 * intervals.h (struct interval): Remove obsolete comment.
807 * textprotp.c (erase_properties): Remove unused code.
808 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
809 (Fremove_list_of_text_properties): Convert to eassert.
810
9ea10cc3
CY
8112012-07-17 Chong Yidong <cyd@gnu.org>
812
813 * editfns.c (Finsert_char): Doc fix.
814
3900d5de
DA
8152012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
816
817 Fix previous change to make Fmemory_free always accurate.
818 * alloc.c (make_interval): Update total_free_intervals.
819 (make_float): Likewise for total_free_floats.
820 (free_cons, Fcons): Likewise for total_free_conses.
821 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
822 Likewise for total_free_vector_bytes.
823 (Fmake_symbol): Likewise for total_free_symbols.
824 (bytes_free): Remove.
825
7098646f
DA
8262012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
827
828 Simple free memory accounting feature.
829 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
830 (sweep_vectors): Accumulate size of free vectors.
831 (Fgarbage_collect): Setup bytes_free.
832 (Fmemory_free): New function.
833 (syms_of_alloc): Register it.
834
22657b40
DA
8352012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
836
837 Cleanup overlays checking.
838 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
839 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
840 eassert and OVERLAYP.
841 (sort_overlays): Change to use OVERLAYP.
842
ddfc8813
RK
8432012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
844
845 * editfns.c (Finsert_char): Make it interactive, and make the
846 second arg optional. Copy interactive spec and docstring from
847 ucs-insert.
848
7c26cf3c
PE
8492012-07-17 Paul Eggert <eggert@cs.ucla.edu>
850
851 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
852 Unlike the other wrapped functions, fabs has an unspecified
853 effect on errno.
854
5d127af9
JD
8552012-07-16 Jan Djärv <jan.h.d@swipnet.se>
856
857 * nsterm.m (keyDown): Interpret flags without left/right bits
858 as the left key (Bug#11670).
859
6a0dd1d7
DA
8602012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
861
862 Remove empty and useless init functions.
863 * lisp.h (init_character_once, init_fns, init_image)
864 (init_filelock, init_sound): Remove prototype.
865 * character.c (init_character_once): Remove.
866 * filelock.c (init_filelock): Likewise.
867 * fns.c (init_fns): Likewise.
868 * image.c (init_image): Likewise.
869 * sound.c (init_sound): Likewise.
870 * emacs.c (main): Adjust accordingly.
871
7a6136fd
DA
8722012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
873
874 * gtkutil.h: Tiny cleanups.
875 (use_old_gtk_file_dialog): Remove useless declaration.
876 (xg_uses_old_file_dialog): Add suggested const attribute.
877
ce811ad9
EZ
8782012-07-15 Eli Zaretskii <eliz@gnu.org>
879
880 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
881 (bidi_paragraph_init): Use it to limit search forward for a strong
882 directional character in abnormally large paragraphs full of
883 neutral or weak characters. (Bug#11943)
884
c9adfeaa
SF
8852012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
886
887 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
888 the toolbar (Bug#9451).
889 (xg_make_tool_item): Give the widget event box a transparent
890 background.
891
fff62aa9
DA
8922012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
893
894 Cleanup basic allocation variables and functions.
895 * alloc.c (ignore_warnings, init_intervals, init_float)
896 (init_cons, init_symbol, init_marker): Remove.
897 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
898 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
899 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
900 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
901 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
902 (staticidx, init_alloc_once, init_strings, free_ablock):
903 Remove redundant initialization.
904 * fns.c (init_weak_hash_tables): Remove.
905 * lisp.h (init_weak_hash_tables): Remove prototype.
906
9730daca
DA
9072012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
908
909 Use zero_vector where appropriate.
910 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
911 accordingly.
912 * lisp.h (zero_vector): New declaration.
913 * font.c (null_vector): Remove.
914 (syms_of_font): Remove initialization and staticpro.
915 (font_list_entities, font_find_for_lface): Change to use zero_vector.
916 * keymap.c (Faccessible_keymaps): Likewise.
917
2e2d2a13
LL
9182012-07-15 Leo Liu <sdl.web@gmail.com>
919
920 * fringe.c: Fix typo in comments.
921
cd276f6e
LL
9222012-07-14 Leo Liu <sdl.web@gmail.com>
923
924 * fringe.c: Add a new bitmap exclamation-mark.
925
5a1131d9
EZ
9262012-07-14 Eli Zaretskii <eliz@gnu.org>
927
928 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
929
930 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
931 (HAVE_MENUS): Don't define, defined by editing config.in with
932 msdos/sed2v2.inp.
933 (GMALLOC_INHIBIT_VALLOC): Don't define.
934 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
935
22e983b7
JB
9362012-07-14 Juanma Barranquero <lekktu@gmail.com>
937
938 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
939
5b3f250f
GM
9402012-07-14 Glenn Morris <rgm@gnu.org>
941
942 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
943 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
944 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
945
33d63ff4
GM
9462012-07-13 Glenn Morris <rgm@gnu.org>
947
5b633342
GM
948 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
949
33d63ff4
GM
950 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
951 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
952
b55b9f85
JD
9532012-07-13 Jan Djärv <jan.h.d@swipnet.se>
954
0dc8cf50
JD
955 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
956 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
957 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
958 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
959 where appropriate.
960 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
961 as boolean expression.
962 (x_set_window_size): Remove unused variable toolbar.
963 (ns_get_color_default, ns_mod_to_lisp): Remove.
964 (ns_mouse_position): Remove unused variables xchar and ychar.
965 (ns_compute_glyph_string_overhangs): Remove unused variable face.
966 (ns_set_vertical_scroll_bar): Remove unused variable count.
967 (ns_delete_terminal): Remove unused variable i.
968 (ns_term_init): Remove unused variables r, g and b.
969 (mouseDown): Remove unused variable window.
970 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
971 (initFrameFromEmacs): Remove unused variable vbextra.
972 (mouseEntered): Remove unused variables p and dpyinfo.
973 (mouseExited): Remove unused variables p and r.
974 (ns_define_frame_cursor, ns_clear_frame_area)
975 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
976 (menuDown): Assign [sender tag] to variable and cast the variable.
977
978 * nsterm.h (menuDown): Add id as type to argument sender.
979 (ns_display_info_for_name): Add Lisp_Object argument.
980 (ns_term_init): Add Lisp_Object argument.
981 (ns_map_event_to_object): Add void argument.
982 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
983 prototype with arguments and only declare if __OBJC__.
984 (nxatoms_of_nsselect): Add void argument.
985 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
986 (ns_alloc_autorelease_pool): Add void argument.
987 (ns_release_autorelease_pool): Add void* argument.
988 (ns_get_defaults_value): Add const char* argument.
989
990 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
991 (initFromContents): Use SSDATA where appropriate.
992 (ns_update_menubar): Add braces to ambigous if-else.
993 (initWithTitle): Put () around assignment in if statement.
994 (ns_menu_show): Remove unused variables window and keymap.
995 (update_frame_tool_bar): Remove unused variable selected_p.
996 (initWithContentRect): Remove unused variable this_cmd_name.
997
998 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
999 appropriate.
1000 (setXBMColor): Remove unused variable len.
1001 (setPixmapData): Put () around assignment in loop statement.
1002
1003 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1004 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1005 where appropriate.
1006 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1007 around assignment in loop statement.
1008 (nsfont_open): Remove unused variable i.
1009 (nsfont_open): Remove unused variable len.
1010 (nsfont_draw): Remove unused variable cs.
1011
1012 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1013 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1014 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1015 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1016 (Fns_font_name, Fns_perform_service)
1017 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1018 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1019 (ns_set_name): Remove unused variable view.
1020 (x_set_menu_bar_lines): Remove unused variable olines.
1021 (x_set_tool_bar_lines): Remove unused variable root_window.
1022 (Fns_list_colors): Put () around assignment in while statement.
1023 (Fns_perform_service): Remove unused variable len.
1024 (Fns_display_usable_bounds): Remove unused variable top.
1025 (syms_of_nsfns): Remove unused variable i.
1026
b55b9f85
JD
1027 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1028 memcpy (Bug#11907).
1029
ed9265fc 10302012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1031
1032 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1033 and free it with DestroyExceptionInfo (Bug#11558).
1034
ef099b57
JB
10352012-07-13 Juanma Barranquero <lekktu@gmail.com>
1036
1037 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1038 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1039 Set here, not in nt/config.nt.
1040
ea814a5d
EZ
10412012-07-13 Eli Zaretskii <eliz@gnu.org>
1042
1043 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1044 cursor overflow into the last glyph on display line when the right
1045 fringe is off. (Bug#11832)
1046
1a952767
PE
10472012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1048
1049 * xdisp.c (produce_special_glyphs): Now static.
1050 * dispextern.h (produce_special_glyphs): Remove decl.
1051
983188fd
GM
10522012-07-13 Glenn Morris <rgm@gnu.org>
1053
32fb4bb6
GM
1054 * s/bsd-common, s/cygwin.h: Remove empty files.
1055 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1056
983188fd
GM
1057 * s/usg5-4-common.h (USG, USG5):
1058 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1059 * s/sol2-6.h (SOLARIS2):
1060 * s/irix6-5.h (IRIX6_5):
1061 * s/hpux10-20.h (USG, USG5, HPUX):
1062 * s/gnu-linux.h (USG, GNU_LINUX):
1063 * s/freebsd.h (BSD_SYSTEM):
1064 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1065 * s/cygwin.h (CYGWIN):
1066 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1067 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1068
d1e68667 10692012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1070
1071 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1072
6de0e799
GM
10732012-07-13 Glenn Morris <rgm@gnu.org>
1074
739ae010
GM
1075 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1076
dbee5793
GM
1077 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1078
6de0e799
GM
1079 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1080 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1081
b82da769
GM
10822012-07-12 Glenn Morris <rgm@gnu.org>
1083
4fae5a7a 1084 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1085
1086 * process.c (init_process_emacs): Rename from init_process.
1087 The old name is also the name of a Mach system call.
1088 * lisp.h, emacs.c: Update for this name change.
1089 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1090 longer needed.
1091
5a979817
EZ
10922012-07-12 Eli Zaretskii <eliz@gnu.org>
1093
1094 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1095 memmove call that removes glyphs covered by the left truncation
1096 glyph. Improve commentary.
1097 (display_line): Fix display of continuation glyphs on GUI frames
1098 when the right fringe is turned off and variable-size fonts are
1099 used in the window. Move the code that appends a stretch glyph to
1100 produce_special_glyphs, so that it could be used for truncation
1101 and continuation glyphs alike.
1102 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1103 glyph of a suitably computed width, to align the special glyphs at
1104 the window margin. Code moved from display_line. (Bug#11832)
1105
3e91a053
GM
11062012-07-12 Glenn Morris <rgm@gnu.org>
1107
ba9e4b84
GM
1108 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1109
1110 * s/gnu-linux.h, s/hpux10-20.h:
1111 Do not unconditionally define HAVE_XRMSETDATABASE.
1112
3e91a053
GM
1113 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1114
b300b1f4
PE
11152012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1116
1117 Fix typos that broke OS X build.
1118 Reported by Randal L. Schwartz in
1119 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1120 * nsterm.m (ns_timeout): Add missing local decl.
1121 (ns_get_color): snprintf -> sprintf, to fix typo.
1122
6e777848
GM
11232012-07-12 Glenn Morris <rgm@gnu.org>
1124
3f922c37
GM
1125 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1126 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1127 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1128 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1129
0ab7b23a
GM
1130 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1131 Move PTY_OPEN to configure.
1132
6e777848
GM
1133 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1134 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1135 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1136
4a7edc24
DA
11372012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1138
1139 Use empty_unibyte_string where applicable.
1140 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1141 * lread.c (read1): Likewise.
1142 * xsettings.c (syms_of_xsettings): Likewise.
1143
308aab79
GM
11442012-07-12 Glenn Morris <rgm@gnu.org>
1145
42bd1719
GM
1146 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1147 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1148 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1149 * s/hpux10-20.h (RUN_TIME_REMAP):
1150 * s/bsd-common.h (TABDLY): Move to configure.
1151
1152 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1153
1154 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1155
ea0bbd17 1156 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1157 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1158
1159 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1160
308aab79
GM
1161 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1162 * s/template.h: Move NARROWPROTO to configure.
1163
ee1cf5cf
GM
11642012-07-11 Glenn Morris <rgm@gnu.org>
1165
30fe9bf4
GM
1166 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1167 unused since 2011-01-17 change to systty.h.
1168
ee1cf5cf
GM
1169 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1170 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1171 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1172
63e47e07
PE
11732012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1174
1175 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1176
c43fb4c3
GM
11772012-07-11 Glenn Morris <rgm@gnu.org>
1178
1179 * s/darwin.h, s/gnu-linux.h, s/template.h:
1180 Move INTERRUPT_INPUT to configure.
1181
e8df9267
DA
11822012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1183
1184 Minor adjustments to interning code.
1185 * lisp.h (intern, intern_c_string): Redefine as static inline
1186 wrappers for intern_1 and intern_c_string_1, respectively.
1187 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1188 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1189 Vobarray checking.
e8df9267
DA
1190 * font.c (font_intern_prop): Likewise. Adjust comment.
1191 * w32font.c (intern_font_name): Likewise.
1192
34348bd4
AS
11932012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1194
d96a1e0c
AS
1195 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1196
34348bd4
AS
1197 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1198 of Fcar/Fcdr if possible.
1199 * font.c (check_otf_features): Likewise.
1200 * fontset.c (Fnew_fontset): Likewise.
1201 * gnutls.c (Fgnutls_boot): Likewise.
1202 * minibuf.c (read_minibuf): Likewise.
1203 * msdos.c (IT_set_frame_parameters): Likewise.
1204 * xmenu.c (Fx_popup_dialog): Likewise.
1205 * w32menu.c (Fx_popup_dialog): Likewise.
1206
c8add24e
GM
12072012-07-11 Glenn Morris <rgm@gnu.org>
1208
4b575b3c
GM
1209 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1210 since nothing has defined it on these platforms.
1211
09f4e3b0
GM
1212 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1213 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1214
172bedef
GM
1215 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1216 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1217 Move CLASH_DETECTION to configure.
1218
249685df
GM
1219 * s/gnu.h: Remove file, which is now empty.
1220
c8add24e
GM
1221 * s/gnu.h, s/gnu-linux.h:
1222 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1223
b41253a3
JW
12242012-07-11 John Wiegley <johnw@newartisans.com>
1225
1226 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1227 function attribute, so we only use it if it exists in the
1228 compiler.
1229
d923b542
DA
12302012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1231
1232 Avoid call to strlen in fast_c_string_match_ignore_case.
1233 * search.c (fast_c_string_match_ignore_case): Change to use
1234 length argument. Adjust users accordingly.
1235 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1236
5ebbef1d
PE
12372012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1238
bb352260
PE
1239 Assume mkdir, rmdir.
1240 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1241 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1242
57054ddd
PE
1243 Assume rename.
1244 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1245
b747d3f7
PE
1246 Assume perror.
1247 * s/hpux10-20.h (HAVE_PERROR): Remove.
1248 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1249 Remove dummy definition, as this problem was obsolete long ago.
1250
5ebbef1d
PE
1251 Assume strerror.
1252 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1253
984e7f30
DA
12542012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1255
1256 Avoid calls to strlen in font processing functions.
1257 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1258 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1259 users accordingly.
d923b542
DA
1260 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1261 Adjust prototypes.
1262 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1263 Change to return ptrdiff_t.
984e7f30
DA
1264 (xfont_list_pattern, xfont_match): Use length returned by
1265 xfont_decode_coding_xlfd.
1266 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1267
20e94fdd
GM
12682012-07-11 Glenn Morris <rgm@gnu.org>
1269
9d596af3
GM
1270 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1271 Move DONT_REOPEN_PTY to configure.
1272
20e94fdd
GM
1273 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1274 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1275
e99a530f
PE
12762012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1277
22ffb973
PE
1278 Remove "#define unix" that is no longer needed (Bug#11905).
1279 * s/aix4-2.h (unix): Remove; no longer needed.
1280
e9a9ae03
PE
1281 EMACS_TIME simplification (Bug#11875).
1282 This replaces macros (which typically do not work in GDB)
1283 with functions, typedefs and enums, making the code easier to debug.
1284 The functional style also makes code easier to read and maintain.
1285 * systime.h: Include <sys/time.h> on all hosts, not just if
1286 WINDOWSNT, since 'struct timeval' is needed in general.
1287 (EMACS_TIME): Now a typedef, not a macro.
1288 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1289 not macros.
1290 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1291 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1292 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1293 (EMACS_TIME_LE): Now functions, not macros.
1294 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1295 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1296 which are not functions. All uses rewritten to use:
1297 (make_emacs_time): New function.
1298 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1299 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1300 not functions. All uses rewritten to use the following, respectively:
1301 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1302 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1303 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1304 * fileio.c (Fcopy_file):
1305 * xterm.c (XTflash): Get the current time closer to when it's used.
1306 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1307
ffacb126
PE
1308 * bytecode.c (targets): Suppress -Woverride-init warnings.
1309
e99a530f
PE
1310 Simplify by avoiding confusing use of strncpy etc.
1311 * doc.c (Fsnarf_documentation):
1312 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1313 * frame.c (Fmake_terminal_frame):
1314 * gtkutil.c (get_utf8_string):
1315 * lread.c (openp):
1316 * nsmenu.m (ns_update_menubar):
1317 * regex.c (regerror):
1318 Prefer memcpy to strncpy and strncat when either will do.
1319 * fileio.c (Fsubstitute_in_file_name):
1320 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1321 (menu_separator_name_p):
1322 * nsmenu.m (ns_update_menubar):
1323 Prefer memcmp to strncmp when either will do.
1324 * nsterm.m: Include <ftoastr.h>.
1325 (ns_get_color):
1326 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1327 Prefer snprintf to strncpy.
1328 * nsterm.m (ns_term_init):
1329 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1330 * nsterm.m (ns_term_init):
1331 Avoid the need for strncpy, by using build_string or
1332 make_unibyte_string directly. Use dtoastr, not snprintf.
1333 * process.c (Fmake_network_process): Diagnose service names that
1334 are too long, rather than silently truncating them or creating
1335 non-null-terminated names.
1336 (Fnetwork_interface_info): Likewise, for interface names.
1337 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1338 Prefer sprintf to strncat.
1339 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1340 Prefer vsnprintf to vsprintf + strncpy.
1341
c59592b3
GM
13422012-07-10 Glenn Morris <rgm@gnu.org>
1343
1344 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1345 Clarify fallback case.
1346
7d7bbefd
DA
13472012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1348
1349 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1350 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1351 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1352 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1353 where argument type is known to be a Lisp_Cons.
1354
3a4c8000
TT
13552012-07-10 Tom Tromey <tromey@redhat.com>
1356
1357 * bytecode.c (BYTE_CODE_THREADED): New macro.
1358 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1359 (enum byte_code_op): New type.
1360 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1361 (exec_byte_code): Use them. Use token threading when applicable.
1362
2a0213a6
DA
13632012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1364
1365 Optimize pure C strings initialization.
1366 * lisp.h (make_pure_string): Fix prototype.
1367 (build_pure_c_string): New function, defined as static inline. This
1368 provides a better opportunity to optimize away calls to strlen when
1369 the function is called with compile-time constant argument.
1370 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1371 argument, adjust users accordingly. Use build_pure_c_string where
1372 appropriate.
1373 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1374 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1375 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1376
cb1caeaf
DA
13772012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1378
1379 Avoid calls to strlen in miscellaneous functions.
1380 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1381 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1382 * lread.c (openp): Likewise.
1383
c293e30c
DA
13842012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1385
1386 Avoid calls to strlen in path processing functions.
1387 * fileio.c (file_name_as_directory): Add comment. Change to add
1388 srclen argument and return the length of result. Adjust users
1389 accordingly.
1390 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1391 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1392 users accordingly.
1393 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1394
9e059e3f
GM
13952012-07-10 Glenn Morris <rgm@gnu.org>
1396
d02eb359
GM
1397 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1398 Move PENDING_OUTPUT_COUNT definition to configure.
1399
882cf227
GM
1400 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1401 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1402 * s/gnu.h (DATA_START): Move definitions to configure.
1403
af6e839f
GM
1404 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1405 We include usg5-4-common.h, which defines them both.
1406
40289a12
GM
1407 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1408 O_RDONLY already includes it).
1409
9e059e3f
GM
1410 Stop ns builds setting the EMACSLOADPATH environment variable.
1411 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1412 Now it does not set EMACSLOADPATH, just returns the load-path string.
1413 * nsterm.h: Update accordingly.
1414 * lread.c [HAVE_NS]: Include nsterm.h.
1415 (init_lread) [HAVE_NS]: Use ns_load_path.
1416 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1417
7c4e8ec0
GM
14182012-07-09 Glenn Morris <rgm@gnu.org>
1419
d4f600ff
GM
1420 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1421 since the included bsd-common.h does so.
1422
cbb31951
GM
1423 Stop ns builds setting the EMACSPATH environment variable.
1424 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1425 (ns_init_paths): Do not set EMACSPATH.
1426 * nsterm.h (ns_exec_path): Add it.
1427 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1428 Use ns_exec_path.
1429
7c4e8ec0
GM
1430 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1431
26bccfae
PE
14322012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1433
a0bee46f
PE
1434 * process.c (wait_reading_process_output): 'waitchannels' was unset
1435 when read_kbd || !NILP (wait_for_cell); fix this.
1436
5994c183
PE
1437 Add GCC-style 'const' attribute to functions that can use it.
1438 * character.h (char_resolve_modifier_mask):
1439 * keyboard.h (make_ctrl_char):
1440 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1441 (init_character_once, next_almost_prime, init_fns, init_image)
1442 (flush_pending_output, init_sound):
1443 * mem-limits.h (start_of_data):
1444 * menu.h (finish_menu_items):
1445 Add ATTRIBUTE_CONST.
1446 * emacs.c (DEFINE_DUMMY_FUNCTION):
1447 Declare the dummy function with ATTRIBUTE_CONST.
1448 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1449 Add decls with ATTRIBUTE_CONST.
1450
26bccfae
PE
1451 Minor improvements to make_formatted_string.
1452 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1453 where int is good enough, as vsprintf returns an int.
1454 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1455
a8290ec3
DA
14562012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1457
1458 Use make_formatted_string to avoid double length calculation.
1459 * lisp.h (make_formatted_string): New prototype.
1460 * alloc.c (make_formatted_string): New function.
1461 * buffer.c (Fgenerate_new_buffer_name): Use it.
1462 * dbus.c (syms_of_dbusbind): Likewise.
1463 * editfns.c (Fcurrent_time_zone): Likewise.
1464 * filelock.c (get_boot_time): Likewise.
1465 * frame.c (make_terminal_frame, set_term_frame_name)
1466 (x_report_frame_params): Likewise.
1467 * image.c (gs_load): Likewise.
1468 * minibuf.c (get_minibuffer): Likewise.
1469 * msdos.c (dos_set_window_size): Likewise.
1470 * process.c (make_process): Likewise.
1471 * xdisp.c (ensure_echo_area_buffers): Likewise.
1472 * xsettings.c (apply_xft_settings): Likewise.
1473
d01ba2f1
GM
14742012-07-09 Glenn Morris <rgm@gnu.org>
1475
1476 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1477 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1478 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1479 * nsterm.h (ns_etc_directory): Add it.
1480 * callproc.c [HAVE_NS]: Include nsterm.h.
1481 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1482
f1f924b6
DA
14832012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1484
1485 Move marker debugging code under MARKER_DEBUG.
1486 * marker.c (MARKER_DEBUG): Move marker debugging code under
1487 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1488 for bootstrap with --enable-checking (~3x slowdown reported
1489 by Juanma Barranquero <lekktu@gmail.com>).
1490 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1491
ab531b66
PE
14922012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1493
1494 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1495 See <http://bugs.gnu.org/11825#29>.
1496
c4b3bc8a
EZ
14972012-07-08 Eli Zaretskii <eliz@gnu.org>
1498
1499 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1500 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1501 (display_line): Add commentary about displaying truncation glyphs
1502 on GUI frames.
1503 (produce_special_glyphs): Move here from term.c.
1504
1505 * term.c (produce_special_glyphs): Move to xdisp.c.
1506
1507 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1508 section.
c4b3bc8a 1509
b676b881
AS
15102012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1511
f17c5273
AS
1512 * xdisp.c (display_line): Avoid warning about implicit declaration
1513 of FRAME_FONT.
1514
298819b9
AS
1515 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1516
b676b881
AS
1517 * lisp.h: Remove empty conditional.
1518
6045c4fd
PE
15192012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1520
b3350bf9
PE
1521 * lread.c (load_path_check): Now static.
1522
6045c4fd
PE
1523 Fix some minor --with-ns problems found by static checking.
1524 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1525 (x_set_font) [!HAVE_X_WINDOWS]:
1526 * image.c (xpm_load_image) [HAVE_NS]:
1527 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1528 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1529 Remove unused local.
1530 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1531 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1532 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1533 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1534 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1535 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1536 Fix pointer signedness problem.
1537 * xfaces.c (FRAME_X_FONT_TABLE):
1538 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1539
929e7845
GM
15402012-07-07 Glenn Morris <rgm@gnu.org>
1541
1542 * lread.c (load_path_check): New function, split from init_lread.
1543 (init_lread): Reorganize. Motivation:
1544 If EMACSLOADPATH is set, check/warn about that rather than the
1545 defaults, which we are not going to use. Hence we can remove
1546 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1547 Don't warn if site-lisp directories are missing.
1548 If not installed, start from a blank load-path, since
1549 PATH_LOADSEARCH refers to the eventual installation directories.
1550
58dd0aa4
EZ
15512012-07-07 Eli Zaretskii <eliz@gnu.org>
1552
1553 Support truncation and continuation glyphs on GUI frames, when
1554 fringes are disabled. (Bug#11832)
1555 * xdisp.c (init_iterator): Get dimensions of truncation and
1556 continuation glyphs even if on GUI frames. Adjust
1557 it->last_visible_x on GUI frames when the left or right fringes,
1558 or both, are absent.
1559 (start_display, move_it_in_display_line_to): Handle the case of a
1560 GUI frame without a fringe to display continuation or truncation
1561 glyphs.
1562 (insert_left_trunc_glyphs): Support GUI frames: make sure
1563 truncation glyphs overwrite enough glyphs from the current line to
1564 have sufficient space in pixels.
1565 (display_line): Support truncation and continuation glyphs on GUI
1566 frames. If some spare pixels are left on the line after inserting
1567 the truncation glyphs, fill that space with a stretch glyph of a
1568 suitably computed width.
1569
1570 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1571 produce_glyphs, to support GUI sessions.
1572
31571fd7
PE
15732012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1574
5a16b9bc
PE
1575 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1576
f3047c75
PE
1577 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1578
31571fd7
PE
1579 Do not require float-time's arg to fit in time_t (Bug#11825).
1580 This works better on hosts where time_t is unsigned, and where
1581 float-time is applied to the (negative) difference between two times.
1582 * editfns.c (decode_time_components): Last arg is now double *,
1583 not int *, and means to store all the result as a double, without
1584 worrying about whether the seconds part fits in time_t.
1585 All callers changed.
1586 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1587 All callers changed.
1588 (Ffloat_time): Do not fail merely because the specified time falls
1589 outside of time_t range.
1590
4516fbef
GM
15912012-07-07 Glenn Morris <rgm@gnu.org>
1592
1593 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1594 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1595 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1596
07adc2c6
JB
15972012-07-07 Juanma Barranquero <lekktu@gmail.com>
1598
1599 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1600 Update dependencies.
1601
1602 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1603
fd573f31
PE
16042012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1605
fee5959d
PE
1606 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1607 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1608 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1609 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1610 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1611 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1612
fd573f31
PE
1613 * xfont.c (compare_font_names): Redo to omit the need for casts.
1614
ddadbc0e
AS
16152012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1616
fca8d6b6
AS
1617 * xfns.c (Fx_change_window_property): Doc fix.
1618 * w32fns.c (Fx_change_window_property): Doc fix.
1619
ddadbc0e
AS
1620 * w32fns.c (Fx_window_property): Accept the same arguments as the
1621 X Windows version. Doc fix.
1622 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1623
ed9265fc 16242012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1625 Eli Zaretskii <eliz@gnu.org>
1626
1627 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1628 Windows-specific code from nt/config.nt moved here.
1629 Obsolete settings removed.
1630
216ee680
PE
16312012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1632
1633 * process.c: Avoid unnecessary calls to gettime.
1634 (wait_reading_process_output): Don't get the time of day
1635 when gobbling data immediately and not waiting, as there's no need
1636 for it in that case. This removes a FIXME.
1637
bdd091e4
JD
16382012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1639
1640 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1641 is defined (Bug#11768).
1642
9d44f8ce
DA
16432012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1644
1645 Fix marker debugging code.
1646 * marker.c (byte_char_debug_check): Do not perform the check
1647 if buffer is not multibyte.
090bd7cb
JB
1648 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1649 Call byte_char_debug_check with correct arguments.
9d44f8ce 1650
90fc4786
DA
16512012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1652
1653 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1654 * marker.c (byte_char_debug_check, count_markers):
1655 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1656 (byte_debug_flag): Remove.
1657 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1658 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1659
7b7ae965
DA
16602012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1661
4e57b342
DA
1662 Avoid code repetition in marker-related functions.
1663 * marker.c (attach_marker): New function.
1664 (Fset_marker, set_marker_restricted, set_marker_both)
1665 (set_marker_restricted_both): Use it.
1666 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1667 Consistently rename charno to charpos.
1668 (marker_position): Add eassert.
1669 (marker_byte_position): Convert to eassert.
1670
16712012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1672
1673 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1674 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1675 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1676
657924ff
DA
16772012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1678
1679 Introduce fast path for the widely used marker operation.
1680 * alloc.c (build_marker): New function.
1681 * lisp.h (build_marker): New prototype.
1682 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1683 * composite.c (autocmp_chars): Likewise.
1684 * editfns.c (buildmark): Remove.
1685 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1686 (save_restriction_save): Use build_marker.
1687 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1688 * window.c (save_window_save): Likewise.
1689
041a49a6
DA
16902012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1691
1692 Do not use Fdelete_overlay in delete_all_overlays
1693 to avoid redundant calls to unchain_overlay.
1694 * buffer.c (drop_overlay): New function.
1695 (delete_all_overlays, Fdelete_overlay): Use it.
1696 * minibuf.c (get_minibuffer): Fix comment.
1697
7dca65a4
PE
16982012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1699
1700 Port to OpenBSD 5.1 amd64.
1701 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1702 This is needed for OpenBSD, and should be harmless on all BSD systems.
1703 Also, include <sys/sysctl.h>, as it should be available on all
1704 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1705 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1706 use p_pid member, not kp_proc.pid.
1707
8eb876e2
GM
17082012-07-06 Glenn Morris <rgm@gnu.org>
1709
1710 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1711
38182d90
PE
17122012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1713
1714 More xmalloc and related cleanup.
1715 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1716 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1717 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1718 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1719 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1720 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1721 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1722 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1723 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1724 * xterm.c:
1725 Omit needless casts involving void * pointers and allocation.
1726 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1727 as the former is more robust if P's type is changed.
1728 Prefer xzalloc to xmalloc + memset 0.
1729 Simplify malloc-or-realloc to realloc.
1730 Don't worry about xmalloc returning a null pointer.
1731 Prefer xstrdup to xmalloc + strcpy.
1732 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1733 growing it.
1734 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1735 alloca of a constant.
1736
6dd5a677
EZ
17372012-07-05 Eli Zaretskii <eliz@gnu.org>
1738
1739 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1740 hscroll is larger than the line width. Fixes long and futile
1741 looping inside extend_face_to_end_of_line (on a TTY) producing
1742 glyphs that are not needed and thrown away.
1743
6b312f0f
DA
17442012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1745
1746 * marker.c (set_marker_restricted_both): Simplify by using
1747 clip_to_bounds.
1748
f520ef9b
PE
17492012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1750
1751 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1752
383b7c95
JD
17532012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1754
1755 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1756 not defined (Bug#11768).
1757 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1758 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1759 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1760 followed by gtk_box_set_homogeneous (Bug#11768).
1761 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1762 (update_theme_scrollbar_width, xg_create_scroll_bar):
1763 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1764 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1765 (is_box_type): New function (Bug#11768).
1766 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1767 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1768 with default display (Bug#11768).
1769
d6e7bf45
EZ
17702012-07-05 Eli Zaretskii <eliz@gnu.org>
1771
1772 * xdisp.c (window_hscroll_limited): New function.
1773 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1774 coordinates when window's hscroll is set to insanely large
1775 values. (Bug#11857)
1776
431391ec
JB
17772012-07-05 Juanma Barranquero <lekktu@gmail.com>
1778
1779 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1780 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1781
23f86fce
DA
17822012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1783
1784 Cleanup xmalloc.
1785 * lisp.h (xzalloc): New prototype. Omit needless casts.
1786 * alloc.c (xzalloc): New function. Omit needless casts.
1787 * charset.c: Omit needless casts. Convert all calls to
1788 xmalloc with following memset to xzalloc.
1789 * dispnew.c: Likewise.
1790 * fringe.c: Likewise.
1791 * image.c: Likewise.
1792 * sound.c: Likewise.
1793 * term.c: Likewise.
1794 * w32fns.c: Likewise.
1795 * w32font.c: Likewise.
1796 * w32term.c: Likewise.
1797 * xfaces.c: Likewise.
1798 * xfns.c: Likewise.
1799 * xterm.c: Likewise.
1800 * atimer.c: Omit needless casts.
1801 * buffer.c: Likewise.
1802 * callproc.c: Likewise.
1803 * ccl.c: Likewise.
1804 * coding.c: Likewise.
1805 * composite.c: Likewise.
1806 * doc.c: Likewise.
1807 * doprnt.c: Likewise.
1808 * editfns.c: Likewise.
1809 * emacs.c: Likewise.
1810 * eval.c: Likewise.
1811 * filelock.c: Likewise.
1812 * fns.c: Likewise.
1813 * gtkutil.c: Likewise.
1814 * keyboard.c: Likewise.
1815 * lisp.h: Likewise.
1816 * lread.c: Likewise.
1817 * minibuf.c: Likewise.
1818 * msdos.c: Likewise.
1819 * print.c: Likewise.
1820 * process.c: Likewise.
1821 * region-cache.c: Likewise.
1822 * search.c: Likewise.
1823 * sysdep.c: Likewise.
1824 * termcap.c: Likewise.
1825 * terminal.c: Likewise.
1826 * tparam.c: Likewise.
1827 * w16select.c: Likewise.
1828 * w32.c: Likewise.
1829 * w32reg.c: Likewise.
1830 * w32select.c: Likewise.
1831 * w32uniscribe.c: Likewise.
1832 * widget.c: Likewise.
1833 * xdisp.c: Likewise.
1834 * xmenu.c: Likewise.
1835 * xrdb.c: Likewise.
1836 * xselect.c: Likewise.
1837
0497dc44
PE
18382012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1839
1840 * fileio.c (time_error_value): Check the right error number.
1841 Problem reported by Troels Nielsen in
1842 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1843
356e7178
PE
18442012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1845
4e71fd89
PE
1846 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1847 This should be fixed in a better way; see Eli Zaretskii in
1848 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1849 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1850
f0941253
PE
1851 * fileio.c (time_error_value): Rename from special_mtime.
1852 The old name's problems were noted by Eli Zaretskii in
1853 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1854
065c9eb4
PE
1855 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1856 This variable's comment says Emacs needs at least one GDB-visible
1857 symbol of type enum pvec_type, to work around GDB problems.
1858 The symbol's value doesn't matter.
1859
356e7178
PE
1860 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1861 that causes compilation to fail on pre-C99 compilers.
1862
ed9265fc 18632012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1864
1865 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1866 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1867
3884d954
DA
18682012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1869
d209e2fb 1870 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1871 headers for buffer_defaults and buffer_local_symbols.
1872 Reported by Juanma Barranquero <lekktu@gmail.com>.
1873
ee28be33
SM
18742012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1875
1876 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1877 * lisp.h (enum pvec_type): Use fewer bits.
1878 (PSEUDOVECTOR_SIZE_BITS): New constant.
1879 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1880 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1881 change in pvec_type.
1882 (PSEUDOVECTOR_TYPEP): New macro.
1883 (TYPED_PSEUDOVECTORP): Use it.
1884 * fns.c (internal_equal): Adapt code to extract pvectype.
1885 * emacs.c (gdb_pvec_type): Update type.
1886 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1887 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1888 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1889 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1890 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1891 abusing vector->header.next.nbytes.
1892 (live_vector_p): Use PVEC_TYPE.
1893 (mark_object): Adapt code to extract pvectype. Use switch.
1894
c7f2cd7f
PE
18952012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1896
1897 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1898 Tighten new eassert a bit.
1899
8ce70ed2
DA
19002012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1901
1902 Fix compilation with --enable-gcc-warnings and -O1
1903 optimization level.
1904 * doprnt.c (doprnt): Change type of tem to int, initialize
1905 to avoid compiler warning. Add eassert.
1906 * search.c (simple_search): Initialize match_byte to avoid
1907 compiler warning. Add eassert.
1908
dea7f1e5
PE
19092012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1910
24a212eb
PE
1911 Avoid weird behavior with large horizontal scrolls.
1912 Without this change, for example, large hscroll values would
1913 mess up Emacs's display on Fedora 15 x86, presumably due to
1914 overflows in int calculations in the display code.
1915 Also, if buffers had long lines, Emacs would freeze.
1916 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1917 (set_window_hscroll): New function, containing the old guts of
1918 Fset_window_hscroll. Return the clipped value.
1919 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1920 This avoids the need to check against PTRDIFF_MAX.
1921
dea7f1e5
PE
1922 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1923
76046526
DA
19242012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1925
1926 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1927
39adff0d
PE
19282012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1929
63807d47
PE
1930 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1931 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1932 since GCC 4.4.6 issues a bogus warning for them.
1933
39adff0d
PE
1934 Fix bugs in file timestamp newness comparisons.
1935 * fileio.c (Ffile_newer_than_file_p):
1936 * lread.c (Fload): Use full timestamp resolution of files,
1937 not just the 1-second resolution, so that files that are only
1938 slightly newer still count as newer.
1939 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1940 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1941
dbeed9a6
PE
19422012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1943
1944 * fileio.c: Improve handling of file time marker. (Bug#11852)
1945 (special_mtime): New function.
1946 (Finsert_file_contents, Fverify_visited_file_modtime):
1947 Use it to set special mtime values consistently.
1948
636334d6
AS
19492012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1950
1951 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1952 marker for non-existing file. (Bug#11852)
1953
e2017fe2
GM
19542012-07-03 Glenn Morris <rgm@gnu.org>
1955
1956 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1957 and did not make it into globals.h).
1958
404dbd37
TT
19592012-07-03 Tom Tromey <tromey@redhat.com>
1960
1961 * window.c (Fset_window_margins, Fset_window_fringes)
1962 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1963 * textprop.c (Fprevious_property_change): No longer static.
1964 * syntax.c (Fsyntax_table_p): No longer static.
1965 * process.c (Fget_process, Fprocess_datagram_address): No longer
1966 static.
1967 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1968 * keyboard.c (Fcommand_execute): No longer static.
1969 Remove EXFUN.
1970 * insdel.c (Fcombine_after_change_execute): No longer static.
1971 * image.c (Finit_image_library): No longer static.
1972 * fileio.c (Fmake_symbolic_link): No longer static.
1973 * eval.c (Ffetch_bytecode): No longer static.
1974 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1975 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1976 No longer static.
404dbd37
TT
1977 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1978 static.
1979 * dired.c (Ffile_attributes): No longer static.
1980 * composite.c (Fcomposition_get_gstring): No longer static.
1981 * callproc.c (Fgetenv_internal): No longer static.
1982
1983 * ccl.h: Remove EXFUNs.
1984 * buffer.h: Remove EXFUNs.
1985 * dispextern.h: Remove EXFUNs.
1986 * intervals.h: Remove EXFUNs.
1987 * fontset.h: Remove EXFUN.
1988 * font.h: Remove EXFUNs.
1989 * dosfns.c (system_process_attributes): Remove EXFUN.
1990 * keymap.h: Remove EXFUNs.
1991 * lisp.h: Remove EXFUNs.
1992 * w32term.h: Remove EXFUNs.
1993 * window.h: Remove EXFUNs.
1994 * xsettings.h: Remove EXFUN.
1995 * xterm.h: Remove EXFUN.
1996
8e4fd1e1
GM
19972012-07-03 Glenn Morris <rgm@gnu.org>
1998
1999 * lisp.h (Frandom): Make it visible to C.
2000 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2001 buffer for invisible buffers. (Bug#1229)
2002
ca95b3eb
DA
20032012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2004
2005 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2006 values which aren't power of 2.
2007 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
2008 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
2009 accordingly.
2010
7555c33f
SM
20112012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2012
2013 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2014
2015 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2016
d12e8f5a
DA
20172012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2018
2019 * alloc.c (allocate_vector_block): Remove redundant
2020 calls to mallopt if DOUG_LEA_MALLOC is defined.
2021 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2022 avoid calls to mallopt if zero_vector is returned.
2023
296094c3
DA
20242012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2025
2026 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2027 is enabled, avoid dereferencing NULL current_sblock if
2028 running undumped.
2029
36429c89
DA
20302012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2031
2032 Cleanup basic buffer management.
2033 * buffer.h (struct buffer): Change layout to use generic vector
2034 marking code. Fix some comments. Change type of 'clip_changed'
2035 to bitfield. Remove unused #ifndef old.
2036 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2037 (GET_OVERLAYS_AT): Fix indentation.
2038 (for_each_per_buffer_object_at): New macro.
2039 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2040 (Fbuffer_local_variables): Use it.
2041 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2042 * alloc.c (allocate_buffer): Adjust to match new layout of
2043 struct buffer. Fix comment.
2044 (mark_overlay): New function.
2045 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2046 Lisp area of struct buffer.
2047 (mark_object): Use it. Adjust marking of misc objects
2048 and related comments.
2049
3b3e4cac
PE
20502012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2051
2052 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2053 wrapper that is not needed because the wrapped code is a no-op (zero
2054 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2055 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2056
cf5c0175
DA
20572012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2058
2059 * alloc.c (mark_buffer): Simplify. Remove prototype.
2060 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2061 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
2062 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2063 redundant calls to mark_vectorlike for bool vectors.
2064
ca26824c
GM
20652012-06-30 Glenn Morris <rgm@gnu.org>
2066
2e4c5312
GM
2067 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2068
ca26824c
GM
2069 * epaths.in (PATH_SITELOADSEARCH): New.
2070 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2071 This is rather than relying on --enable-locallisppath elements
2072 having "site-lisp" in their names. (Bug#10208#25, 11658)
2073
0d23c240
EZ
20742012-06-30 Eli Zaretskii <eliz@gnu.org>
2075
c9240d7a
EZ
2076 * w32proc.c (sys_select): Accept and ignore one more argument.
2077
2078 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2079
0d23c240 2080 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2081 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2082
2083 * sysdep.c: Don't include dos.h and dosfns.h.
2084
2085 * process.c (sys_select):
2086 * msdos.c (sys_select): Accept one more argument and ignore it.
2087
2088 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2089 adapt data types and code to that.
2090
2091 * dosfns.c:
2092 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2093 which clashes with the gnulib function of the same name.
2094
af5a5a98
AS
20952012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2096
c5e4379c
AS
2097 * font.c (font_style_to_value, font_style_symbolic)
2098 (font_prop_validate_style): Add type checks for values in
2099 font_style_table.
2100
af5a5a98
AS
2101 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2102 argument.
2103 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2104 uses.
2105
8d38f461
EZ
21062012-06-29 Eli Zaretskii <eliz@gnu.org>
2107
2e5a6631
EZ
2108 * xdisp.c (try_window_id): Undo last change.
2109
8d38f461
EZ
2110 * w32.c (getwd): Adjust commentary about startup_dir.
2111 (init_environment): Always call sys_access, even in non-MSVC
2112 builds. Don't chdir to the directory of the Emacs executable.
2113 This undoes code from 1997 which was justified by the need to
2114 "avoid conflicts when removing and renaming directories". But its
2115 downside was that every relative file name was being interpreted
2116 relative to the directory of the Emacs executable, which can never
2117 be TRT. In particular, it broke sys_access when called with
2118 relative file names.
2119 (sys_access): Map GetLastError to errno.
2120
2af3565e
DA
21212012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2122
2123 * window.h (struct window): Change type of 'fringes_outside_margins'
2124 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2125 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2126 Adjust comment.
2127 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2128 to ptrdiff_t.
2129
c8d3a25c 21302012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2131
c8d3a25c
GM
2132 * gnutls.c (emacs_gnutls_handshake):
2133 Add QUIT to make the loop interruptible.
57570cd3 2134
c8d3a25c 21352012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2136
c8d3a25c
GM
2137 * charset.c (init_charset): Make lack of etc/charsets fatal.
2138
3e984ee8
DA
21392012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2140
2141 * editfns.c (region_limit): Fix type mismatch.
2142
ef884f23
DA
21432012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2144
2145 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2146 undefined. Convert from xassert to eassert.
2147 * nsmenu.m: Convert from xassert to eassert.
2148 * nsterm.m: Likewise.
2149
7d7e0027
SM
21502012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2151
2152 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2153
aa754e6a
PE
21542012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2155
2156 Avoid integer overflow on scroll-left and scroll-right.
2157 * window.c (HSCROLL_MAX): New macro.
2158 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2159 overflow when requested scroll falls outside ptrdiff_t range.
2160
80b00b08
DA
21612012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2162
2163 * window.h (struct window): Change type of 'hscroll',
2164 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2165 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2166 Adjust users accordingly.
2167 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2168 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2169 from EMACS_INT to ptrdiff_t.
2170 (make_window): Omit redundant initialization.
2171
62b2bcf6
JB
21722012-06-28 Juanma Barranquero <lekktu@gmail.com>
2173
2174 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2175
45942c7d
DA
21762012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2177
2178 * window.h (struct window): Change type of 'use_time' and
2179 'sequence_number' from Lisp_Object to int.
2180 * frame.c (make_frame): Adjust users accordingly.
2181 * print.c (print_object): Likewise.
2182 * window.c (select_window, Fwindow_use_time, make_parent_window)
2183 (make_window): Likewise.
2184
e509cfa6
DA
21852012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2186
2187 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2188 enabled with --enable-checking=[all,glyphs] configure option.
2189 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2190 adjust comments accordingly.
2191 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2192 undefined, adjust comments accordingly.
2193 * image.c: Likewise.
2194 * scroll.c: Likewise.
2195 * w32fns.c: Likewise.
2196 * w32term.c: Likewise.
2197 * xdisp.c: Likewise.
2198 * xfaces.c: Likewise.
2199 * xfns.c: Likewise.
2200 * xterm.c: Likewise.
2201
a54e2c05
DA
22022012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2203
2204 Generalize run-time debugging checks.
2205 * dispextern.h (XASSERTS): Remove.
2206 * fontset.c (xassert): Remove.
2207 Convert from xassert to eassert.
2208 * alloc.c: Convert from xassert to eassert.
2209 * bidi.c: Likewise.
2210 * dispnew.c: Likewise.
2211 * fns.c: Likewise.
2212 * fringe.c: Likewise.
2213 * ftfont.c: Likewise.
2214 * gtkutil.c: Likewise.
2215 * image.c: Likewise.
2216 * keyboard.c: Likewise.
2217 * menu.c: Likewise.
2218 * process.c: Likewise.
2219 * scroll.c: Likewise.
2220 * sound.c: Likewise.
2221 * term.c: Likewise.
2222 * w32console.c: Likewise.
2223 * w32fns.c: Likewise.
2224 * w32term.c: Likewise.
2225 * window.c: Likewise.
2226 * xdisp.c: Likewise.
2227 * xfaces.c: Likewise.
2228 * xfns.c: Likewise.
2229 * xselect.c: Likewise.
2230 * xterm.c: Likewise.
2231
1ec4b7b2
SM
22322012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2233
2234 * fns.c (maybe_resize_hash_table): Output message when growing the
2235 purify-hashtable.
2236
2014308a
DA
22372012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2238
2239 * alloc.c (allocate_string_data): Remove dead code.
2240 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2241 avoid GCC warning about unused macro.
2242
246155eb
DA
22432012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2244
2245 * alloc.c (allocate_string): Omit intervals initialization.
2246 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2247 as in make_pure_string and make_pure_c_string.
2248
43184b7b
DA
22492012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2250
d209e2fb 2251 * alloc.c (allocate_string): Fix last change.
43184b7b 2252
3fe6dd74
DA
22532012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2254
d209e2fb 2255 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2256 to memset, add explicit initialization where appropriate.
2257
1ba6038a
GM
22582012-06-27 Glenn Morris <rgm@gnu.org>
2259
2260 * lisp.mk (lisp): Remove paths.elc.
2261
c89926a5
CY
22622012-06-27 Chong Yidong <cyd@gnu.org>
2263
2264 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2265
ed6b3510
JW
22662012-06-26 John Wiegley <johnw@newartisans.com>
2267
1ec4b7b2 2268 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2269 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2270
ed6b3510
JW
2271 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2272 when building with Clang.
2273
8edd4a2b
SM
22742012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2275
2276 * eval.c (Fapply): Allow calling it with a single argument.
2277
f6f62d1b
EZ
22782012-06-26 Eli Zaretskii <eliz@gnu.org>
2279
2280 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2281 _stricmp and _strnicmp.
2282 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2283
62efea5e
DA
22842012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2285
2286 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2287 allocated window.
2288 (allocate_process): Likewise for new process.
8edd4a2b 2289 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2290 (allocate_frame): Likewise.
2291 * frame.c (make_frame): Omit redundant initialization.
2292 * window.c (make_parent_window): Use memset.
2293 (make_window): Omit redundant initialization.
2294 * process.c (make_process): Omit redundant initialization.
2295 * terminal.c (create_terminal): Likewise.
2296
42997f4d
DA
22972012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2298
2299 * term.c (delete_tty): Remove redundant call to memset.
2300
1130ecfc
DA
23012012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2302
2303 * alloc.c: Remove build_string.
2304 * lisp.h: Define build_string as static inline. This provides
2305 a better opportunity to optimize away calls to strlen when the
2306 function is called with compile-time constant argument.
2307 * image.c (imagemagick_error): Convert to build_string.
2308 * w32proc.c (sys_spawnve): Likewise.
2309 * xterm.c (x_term_init): Likewise.
2310
cf38a720
PE
23112012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2312
99027bdd
PE
2313 Use sprintf return value instead of invoking strlen on result.
2314 In the old days this wasn't portable, since some sprintf
2315 implementations returned char *. But they died out years ago and
2316 Emacs already assumes sprintf returns int.
2317 Similarly for float_to_string.
2318 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2319 * ccl.c (ccl_driver):
2320 * character.c (string_escape_byte8):
2321 * data.c (Fnumber_to_string):
2322 * doprnt.c (doprnt):
2323 * print.c (print_object):
2324 * xdisp.c (message_dolog):
2325 * xfns.c (syms_of_xfns):
2326 Use sprintf or float_to_string result to avoid need to call strlen.
2327 * data.c (Fnumber_to_string):
2328 Use make_unibyte_string, since the string must be ASCII.
2329 * lisp.h, print.c (float_to_string): Now returns int length.
2330 * term.c (produce_glyphless_glyph):
2331 Use sprintf result rather than recomputing it.
2332
cf38a720
PE
2333 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2334 * Makefile.in (ALL_CFLAGS):
2335 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2336 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2337
3511c784
DA
23382012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2339
0a08eb21 2340 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2341 strcasecmp if available.
2342 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2343
fb7da12e
AS
23442012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2345
2346 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2347 Avoid comma operator.
2348 * menu.c (push_submenu_start, push_submenu_end)
2349 (push_left_right_boundary, push_menu_pane): Likewise.
2350 * msdos.c (dos_rawgetc): Likewise.
2351
afa2ffd8
DA
23522012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2353
2354 * xfns.c (xic_create_fontsetname): Remove redundant calls
2355 to memset.
2356
b3b4476b
PE
23572012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2358
4495ff38
PE
2359 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2360 sprintf already null-terminates its output.
2361
b3b4476b
PE
2362 * xfns.c (x_window): Remove redundant cast.
2363
b00876c9
DA
23642012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2365
2366 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2367 `const char *' to `char *' to avoid compiler warning.
2368
d188e26b
PE
23692012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2370
885d1d74
PE
2371 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2372 instead of truncating it to 63 (admittedly a generous limit).
2373
d188e26b
PE
2374 * process.c: Fix spelling and caps in comments.
2375
e2f560b1
DN
23762012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2377
e86db54b 2378 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2379 * sysdep.c (setpgrp): Remove definition, not used in this file.
2380
7583a3a1
JB
23812012-06-24 Juanma Barranquero <lekktu@gmail.com>
2382
2383 * makefile.w32-in: Update dependencies.
2384
696056c2
EZ
23852012-06-24 Eli Zaretskii <eliz@gnu.org>
2386
2387 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2388 (SYSTIME_H): Add nt/inc/sys/time.h.
2389
2390 * systime.h [WINDOWSNT]: Include sys/time.h.
2391
2392 * s/ms-w32.h (struct timespec): Definition moved from
2393 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2394
845ca893
PE
23952012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2396
2397 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2398 * buffer.h (buffer_slot_type_mismatch):
2399 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2400 * eval.c (unwind_to_catch):
2401 * image.c (my_png_error, my_error_exit):
2402 * keyboard.c (quit_throw_to_read_char, user_error)
2403 (Fexit_recursive_edit, Fabort_recursive_edit):
2404 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2405 (wrong_type_argument, buffer_overflow, __executable_start)
2406 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2407 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2408 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2409 (fatal):
2410 (child_setup) [!DOS_NT]:
2411 * lread.c (end_of_file_error, invalid_syntax):
2412 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2413 * puresize.h (pure_write_error):
2414 * search.c (matcher_overflow):
2415 * sound.c (sound_perror, alsa_sound_perror):
2416 * sysdep.c, syssignal.h (croak):
2417 * term.c (maybe_fatal, vfatal):
2418 * textprop.c (text_read_only):
2419 * undo.c (user_error):
2420 * unexmacosx.c (unexec_error):
2421 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2422 Use _Noreturn rather than NO_RETURN.
2423 No need for separate decl merely because of _Noreturn.
2424 * sound.c (sound_warning, parse_sound):
2425 Remove unnecessary forward decls.
2426
f1dd8073
PE
24272012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2428
2429 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2430 * lisp.h (WAIT_READING_MAX): New macro.
2431 * dispnew.c (Fsleep_for, sit_for):
2432 * keyboard.c (kbd_buffer_get_event):
2433 * process.c (Faccept_process_output):
2434 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2435 This improves on the previous patch, which introduced a bug
2436 when time_t is unsigned and as wide as intmax_t.
2437 See <http://bugs.gnu.org/9000#51>.
2438
b82c1755
EZ
24392012-06-23 Eli Zaretskii <eliz@gnu.org>
2440
2441 * dispnew.c (sit_for, Fsleep_for):
2442 * keyboard.c (kbd_buffer_get_event):
2443 * process.c (Faccept_process_output): Avoid compiler warnings when
2444 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2445
ca300656
JB
24462012-06-23 Juanma Barranquero <lekktu@gmail.com>
2447
049ec95b
JB
2448 * makefile.w32-in: Update dependencies.
2449
ca300656
JB
2450 * w32.c (ltime): Add return type and declare static.
2451 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2452
db7b8d06
PE
24532012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2454
2455 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2456 Privately reported by Herbert J. Skuhra.
2457 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2458 All uses changed.
2459 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2460 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2461
0bd8297f
EZ
24622012-06-23 Eli Zaretskii <eliz@gnu.org>
2463
96512555
EZ
2464 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2465 last argument of make_unibyte_string.
2466
0bd8297f
EZ
2467 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2468 language ID in the event parameters.
2469
2470 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2471 event.code, not the obscure "character set ID".
2472
63def6b6
CY
24732012-06-23 Chong Yidong <cyd@gnu.org>
2474
2475 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2476
e8a02204
EZ
24772012-06-23 Eli Zaretskii <eliz@gnu.org>
2478
388cdec0
EZ
2479 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2480 * w32.c (fdutimens): New function.
2481
2482 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2483
2484 * s/ms-w32.h (pselect): Redirect to sys_select.
2485
2486 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2487
e8a02204
EZ
2488 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2489 in the logic of incrementing and decrementing the value of
2490 use_relocatable_buffers.
2491
d054f3fb
PE
24922012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2493
2494 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2495 Privately reported by Herbert J. Skuhra.
2496 [__FreeBSD__]: Remove "*/" typo after "#include".
2497 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2498 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2499 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2500 Don't assume EMACS_TIME and struct timeval are the same type.
2501
d35af63c
PE
25022012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2503
2504 Support higher-resolution time stamps (Bug#9000).
2505 The time stamps are only nanosecond-resolution at the C level,
2506 since that's the best that any real-world system supports now.
2507 But they are picosecond-resolution at the Lisp level, as that's
2508 easy, and leaves room for future OS improvements.
2509
2510 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2511 (LIBES): Use it.
2512
2513 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2514 Don't get current time unless it's needed.
2515
2516 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2517 now provides it if it's absent.
2518 (start_atimer): Port to higher-res time stamps.
2519 Check for time stamp overflow. Don't get current time more
2520 often than is needed.
2521
2522 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2523 Include systime.h, not time.h.
2524 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2525
2526 * dired.c: Include stat-time.h.
2527 (Ffile-attributes): File times now have higher resolution.
2528
2529 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2530 (struct image): Timestamp now has higher resolution.
2531
2532 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2533 has at least microseconds now. All uses removed.
2534 (update_frame, update_single_window, update_window, update_frame_1)
2535 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2536
2537 * editfns.c (time_overflow): Now extern.
2538 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2539 (float-time, Fformat_time_string, Fcurrent_time_string)
2540 (Fcurrent_time_zone): Accept and generate higher-resolution
2541 time stamps.
2542 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2543 (decode_time_components, lisp_seconds_argument): New functions.
2544 (make_time): Now static.
2545 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2546 Report an error if the time is invalid, rather than having the caller
2547 do that.
2548
2549 * fileio.c: Include <stat-time.h>
2550 (Fcopy_file): Copy higher-resolution time stamps.
2551 Prefer to set the time stamp via a file descriptor if that works.
2552 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2553 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2554 (Fvisited_file_modtime, Fset_visited_file_modtime):
2555 Support higher-resolution time stamps.
2556
2557 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2558
2559 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2560
2561 * image.c (prepare_image_for_display, clear_image_cache)
2562 (lookup_image): Port to higer-resolution time stamps.
2563
2564 * keyboard.c (start_polling, bind_polling_period):
2565 Check for time stamp overflow.
2566 (read_char, kbd_buffer_get_event, timer_start_idle)
2567 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2568 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2569 Port to higher-resolution time stamps. Do not assume time_t is signed.
2570 (decode_timer): New function. Timers are now vectors of length 9,
2571 not 8, to accommodate the picosecond component.
2572 (timer_check_2): Use it.
2573
2574 * nsterm.m (select_timeout, timeval_subtract): Remove.
2575 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2576 as they're a bit more accurate and handle overflow better.
2577 (ns_select): Change prototype to be compatible with pselect.
2578 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2579 * nsterm.h (ns_select): Adjust prototype.
2580
2581 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2582 us-resolution time stamps.
2583 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2584
2585 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2586
2587 * lisp.h (time_overflow): New decl.
2588 (wait_reading_process_output): First arg is now intmax_t, not int,
2589 to accommodate larger waits.
2590
2591 * process.h (struct Lisp_Process.read_output_delay):
2592 Now counts nanoseconds, not microseconds.
2593 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2594 EMACS_HAS_USECS.
2595 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2596 (wait_reading_process_output):
2597 Port to ns-resolution time stamps.
2598 (Faccept_process_output, wait_reading_process_output):
2599 Check for time stamp overflow. Do not assume time_t is signed.
2600 (select_wrapper): Remove; we now use pselect.
2601 (Fprocess_attributes): Now generates ns-resolution time stamps.
2602
2603 * sysdep.c: Include utimens.h. Don't include utime.h
2604 or worry about struct utimbuf; gnulib does that for us now.
2605 (gettimeofday): Remove; gnulib provides a substitute.
2606 (make_timeval): New function.
2607 (set_file_times): Now sets ns-resolution time stamps.
2608 New arg FD; all uses changed.
2609 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2610 (system_process_attributes):
2611 Now returns ns-resolution time stamp. All uses changed.
2612 Check for time stamp overflow.
2613
2614 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2615 provides a substitute now.
2616
2617 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2618 since it guarantees struct timespec.
2619 (EMACS_TIME): Now struct timespec, so that we can support
2620 ns-resolution time stamps.
2621 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2622 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2623 (EMACS_USECS): Remove.
2624 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2625 so multiply the arg by 1000 before storing it.
2626 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2627 New macros.
2628 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2629 Port to ns-resolution time stamps.
2630 (EMACS_TIME_NEG_P): Remove; replaced by....
2631 (EMACS_TIME_SIGN): New macro.
2632 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2633 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2634 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2635 (make_timeval, make_lisp_time, decode_time_components): New decls.
2636 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2637 that it mishandled time_t overflow. You can't compare by subtracting!
2638 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2639 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2640
2641 * term.c: Include <sys/time.h>.
2642 (timeval_to_Time): New function, for proper overflow wraparound.
2643 (term_mouse_position, term_mouse_click): Use it.
2644
2645 * undo.c (record_first_change): Support higher-resolution time stamps
2646 in the undo buffer.
2647 (Fprimitive_undo): Use them when restoring time stamps.
2648
2649 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2650 (w32_get_internal_run_time):
2651 Port to higher-resolution Emacs time stamps.
2652 (ltime): Now accepts single 64-bit integer, as that's more convenient
2653 for callers.
2654
2655 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2656
2657 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2658 for compatibility with pselect. Support ns-resolution time stamps.
2659
2660 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2661
2662 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2663 Check for time stamp overflow, and support ns-resolution time stamps.
2664
2665 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2666 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2667 (timeval_subtract): Remove; no longer needed.
2668 (XTflash, XTring_bell, x_wait_for_event):
2669 Port to ns-resolution time stamps. Don't assume time_t is signed.
2670
b6a92dfe
CY
26712012-06-22 Chong Yidong <cyd@gnu.org>
2672
2673 * xdisp.c (x_consider_frame_title): Revert last change.
2674
d251c37c
EZ
26752012-06-22 Eli Zaretskii <eliz@gnu.org>
2676
2677 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2678 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2679 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2680 staticidx goes up to 1597 out of 1600 = 0x640.)
2681
f10deafb
PE
26822012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2683
2684 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2685 Otherwise, the umask might be mistakenly 0 while handling input signals.
2686
ec6de1e2
SM
26872012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2688
2689 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2690
28be1ada
DA
26912012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2692
2693 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2694 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2695 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2696 access to `contents' member of Lisp_Vector objects with AREF and ASET
2697 where appropriate.
2698
c6bf3022
CY
26992012-06-19 Chong Yidong <cyd@gnu.org>
2700
2701 * frame.c (delete_frame): When selecting a frame on a different
2702 text terminal, do not alter the terminal's top-frame.
2703
2704 * xdisp.c (format_mode_line_unwind_data): Record the target
2705 frame's selected window and its terminal's top-frame.
2706 (unwind_format_mode_line): Restore them.
2707 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2708 Callers changed.
2709 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2710 since tty frames can be explicitly named.
2711 (prepare_menu_bars): Likewise.
2712
2713 * term.c (Ftty_top_frame): New function.
2714
defd4196
PE
27152012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2716
2717 Port byte-code-meter to modern targets.
2718 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2719 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2720 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2721 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2722 (METER_1, METER_2): Simplify.
2723
1053a871
SM
27242012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2725
2726 * data.c (Fdefalias): Return `symbol' (bug#11686).
2727
b7e8d081
MR
27282012-06-18 Martin Rudalics <rudalics@gmx.at>
2729
2730 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2731 gets killed during executing of this function (Bug#11665).
2732 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2733 (Vkill_buffer_query_functions): In doc-string say that functions
2734 run by this hook should not change the current buffer.
2735
7ea2b339
PE
27362012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2737
2738 Fix recently-introduced process.c problems found by static checking.
2739 * process.c (write_queue_push, write_queue_pop, send_process):
2740 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2741 (write_queue_pop): Fix pointer signedness problem.
2742 (send_process): Remove unused local.
2743
96a313a1
CY
27442012-06-17 Chong Yidong <cyd@gnu.org>
2745
2746 * xdisp.c (redisplay_internal): No need to redisplay terminal
2747 frames that are not on top.
2748
20ca2e94
TN
27492012-06-17 Troels Nielsen <bn.troels@gmail.com>
2750
2751 * process.c (make_process): Initialize write_queue.
2752 (write_queue_push, write_queue_pop): New functions.
2753 (send_process): Use them to maintain correct ordering of process
2754 writes (Bug#10815).
2755
9a900ca9
PE
27562012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2757
310fbfa8
PE
2758 * lisp.h (eassert): Assume C89 or later.
2759 This removes the need for CHECK.
2760 (CHECK): Remove. Its comments about always evaluating its
2761 argument were confusing, as 'eassert' typically does not evaluate
2762 its argument.
2763
27bb1ca4
PE
2764 * coding.c (produce_chars): Use ptrdiff_t, not int.
2765
9a900ca9
PE
2766 * xterm.c (x_draw_underwave): Check for integer overflow.
2767 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2768
41b7f8bc 27692012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2770
2771 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2772 referenced (Bug#11583).
2773
9b0e3eba
AA
27742012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2775
2776 Implement wave-style variant of underlining.
2777 * dispextern.h (face_underline_type): New enum.
2778 (face): Add field for underline type.
2779 * nsterm.m (ns_draw_underwave): New function.
2780 (ns_draw_text_decoration): Use it.
2781 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2782 New functions.
2783 (x_draw_glyph_string): Use them.
2784 * xfaces.c (Qline, Qwave): New Lisp objects.
2785 (check_lface_attrs, merge_face_ref)
1053a871
SM
2786 (Finternal_set_lisp_face_attribute, realize_x_face):
2787 Handle wave-style underline face attributes.
9b0e3eba
AA
2788 * xterm.c (x_draw_underwave): New function.
2789 (x_draw_glyph_string): Use it.
2790
0fb52f11
JB
27912012-06-16 Juanma Barranquero <lekktu@gmail.com>
2792
2793 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2794 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2795 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2796 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2797 ($(BLD)/w32select.$(O)): Update dependencies.
2798
e5560ff7
AS
27992012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2800
2801 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2802 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2803 * character.c (_fetch_multibyte_char_p): Remove.
2804 * alloc.c: Include "character.h" before "buffer.h".
2805 * bidi.c: Likewise.
2806 * buffer.c: Likewise.
2807 * bytecode.c: Likewise.
2808 * callint.c: Likewise.
2809 * callproc.c: Likewise.
2810 * casefiddle.c: Likewise.
2811 * casetab.c: Likewise.
2812 * category.c: Likewise.
2813 * cmds.c: Likewise.
2814 * coding.c: Likewise.
2815 * composite.c: Likewise.
2816 * dired.c: Likewise.
2817 * dispnew.c: Likewise.
2818 * doc.c: Likewise.
2819 * dosfns.c: Likewise.
2820 * editfns.c: Likewise.
2821 * emacs.c: Likewise.
2822 * fileio.c: Likewise.
2823 * filelock.c: Likewise.
2824 * font.c: Likewise.
2825 * fontset.c: Likewise.
2826 * fringe.c: Likewise.
2827 * indent.c: Likewise.
2828 * insdel.c: Likewise.
2829 * intervals.c: Likewise.
2830 * keyboard.c: Likewise.
2831 * keymap.c: Likewise.
2832 * lread.c: Likewise.
2833 * macros.c: Likewise.
2834 * marker.c: Likewise.
2835 * minibuf.c: Likewise.
2836 * nsfns.m: Likewise.
2837 * nsmenu.m: Likewise.
2838 * print.c: Likewise.
2839 * process.c: Likewise.
2840 * regex.c: Likewise.
2841 * region-cache.c: Likewise.
2842 * search.c: Likewise.
2843 * syntax.c: Likewise.
2844 * term.c: Likewise.
2845 * textprop.c: Likewise.
2846 * undo.c: Likewise.
2847 * unexsol.c: Likewise.
2848 * w16select.c: Likewise.
2849 * w32fns.c: Likewise.
2850 * w32menu.c: Likewise.
2851 * window.c: Likewise.
2852 * xdisp.c: Likewise.
2853 * xfns.c: Likewise.
2854 * xmenu.c: Likewise.
2855 * xml.c: Likewise.
2856 * xselect.c: Likewise.
2857
2f07e6af
EZ
28582012-06-16 Eli Zaretskii <eliz@gnu.org>
2859
1053a871
SM
2860 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2861 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2862 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2863 row.
2864 (handle_face_prop): Use chunk-relative overlay string index when
2865 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2866 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2867 the rightmost. (Bug#11720)
2f07e6af 2868
29b83cec
AS
28692012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2870
2871 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2872 (CATEGORY_MEMBER): Enforce 1/0 value.
2873 * category.c (_temp_category_set): Remove.
2874
4c5501e9
EZ
28752012-06-16 Eli Zaretskii <eliz@gnu.org>
2876
2877 * window.c (Fdelete_other_windows_internal)
2878 (Fdelete_window_internal): Don't access frame's mouse highlight
2879 info of the initial frame. (Bug#11677)
2880
2b570124
PE
28812012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2882
e93864f9
PE
2883 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2884 Assume USE_2_TAGS_FOR_INTS.
2885 (xreload): Adjust $tagmask width to match recent lisp.h change.
2886
2b570124
PE
2887 Simplify lisp.h in minor ways that should not affect code.
2888 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2889 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2890 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2891 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2892 (INTTYPEBITS): New macro, for clarity.
2893 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2894 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2895 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2896 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2897 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2898
81755f69
JB
28992012-06-13 Juanma Barranquero <lekktu@gmail.com>
2900
2901 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2902
16192a57
GM
29032012-06-13 Glenn Morris <rgm@gnu.org>
2904
2905 * s/bsd-common.h (BSD4_3):
2906 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2907
646b5f55
AS
29082012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2909
2910 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2911 instead of union.
2912 (XLI, XIL): Define.
1053a871
SM
2913 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2914 Use them.
2915 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2916 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2917 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2918 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2919 * frame.c (delete_frame): Remove outdated comment.
2920 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2921 USE_LISP_UNION_TYPE.
2922 (Fw32_unregister_hot_key): Likewise.
2923 (Fw32_toggle_lock_key): Likewise.
2924 * w32menu.c (add_menu_item): Likewise.
2925 (w32_menu_display_help): Use XIL instead of checking
2926 USE_LISP_UNION_TYPE.
2927 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2928 (init_heap): Likewise.
2929 * w32term.c (w32_read_socket): Update comment.
2930
1d3823c9
GM
29312012-06-13 Glenn Morris <rgm@gnu.org>
2932
c62ff706
GM
2933 * s/usg5-4-common.h, src/s/unixware.h:
2934 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2935
1d3823c9
GM
2936 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2937
bfe3e0a2
PE
29382012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2939
2940 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2941 * alloc.c (make_number) [!defined make_number]:
2942 Remove, as lisp.h always defines this now.
2943 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2944 (roundup_size): Verify that it is a power of 2.
2945 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2946 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2947 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2948 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2949 USE_LSB_TAG now is always defined to be either 0 or 1.
2950 All uses changed.
2951 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2952 code works fine either way, and efficiency is not a concern here,
2953 as the union type is for debugging, not for production.
2954 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2955 Use an inline function on all platforms when using the union type,
2956 since this is simpler and 'static inline' can be used portably
2957 within Emacs now.
2958 (LISP_INITIALLY_ZERO): New macro.
2959 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2960 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2961
45fa9c0f
GM
29622012-06-12 Glenn Morris <rgm@gnu.org>
2963
b4492cba
GM
2964 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2965
2966 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2967
45fa9c0f
GM
2968 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2969 Move BROKEN_SIGIO to configure.
2970
2971 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2972 Move NO_TERMIO to configure.
2973
0e25d334
CY
29742012-06-12 Chong Yidong <cyd@gnu.org>
2975
2976 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2977 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2978 MagickExportImagePixels is undefined.
2979
43682bb6
PE
29802012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2981
2982 * image.c (imagemagick_load_image): Remove unused label.
2983
a9be7d2b
GM
29842012-06-11 Glenn Morris <rgm@gnu.org>
2985
2986 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2987 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2988 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2989 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2990
3017f87f
SM
29912012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2992
2993 * alloc.c (make_byte_code): New function.
2994 (Fmake_byte_code): Use it. Don't purify here.
2995 * lread.c (read1): Use it as well to avoid extra allocation.
2996
1b9b4cf4
CY
29972012-06-11 Chong Yidong <cyd@gnu.org>
2998
2999 * image.c (imagemagick_load_image): Implement transparency.
3000
95988fcf
AS
30012012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3002
3003 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3004 account for preceding backslashes. (Bug#11663)
3005
cd4eb164
CY
30062012-06-09 Chong Yidong <cyd@gnu.org>
3007
3008 * term.c: Support italics in capable terminals (Bug#9652).
3009 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3010 (turn_on_face): Output using TS_enter_italic_mode if available.
3011 Don't handle unused blinking and alt-charset cases.
3012 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3013 and tty_alt_charset_p cases.
3014 (tty_capable_p, init_tty): Support italics.
3015
3016 * termchar.h (struct tty_display_info): Add field for italics.
3017 Remove unused blink field.
3018
3019 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3020 Handle slant.
3021
3022 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3023 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3024 tty_alt_charset_p. Add tty_italic_p.
3025
ff88beb8
MA
30262012-06-09 Michael Albinus <michael.albinus@gmx.de>
3027
3028 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3029 dbus_type_is_basic if available.
3030 (xd_extract_signed, xd_extract_unsigned): Rename from
3031 extract_signed and extract_unsigned, respectively. Adapt callers.
3032
44286096
CY
30332012-06-09 Chong Yidong <cyd@gnu.org>
3034
1682701f
CY
3035 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3036
44286096
CY
3037 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3038 case (Bug#9752).
3039
d86feb17
PE
30402012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3041
3042 * xdisp.c (vmessage): Treat frame message as multibyte.
3043 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3044 would generate the diagnostic "Making \302\247 buffer-local while
3045 let-bound!".
3046
d5c20fe8
EZ
30472012-06-08 Eli Zaretskii <eliz@gnu.org>
3048
3049 * dispnew.c (showing_window_margins_p): Undo last change, which
3050 was done due to an inadvertent commit.
3051 (adjust_frame_glyphs_for_frame_redisplay): Do call
3052 showing_window_margins_p.
3053
513749ee
SM
30542012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3055
3056 * eval.c (Fmake_var_non_special): New primitive.
3057 (syms_of_eval): Defsubr it.
3058 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3059
d4a8f5c1
JB
30602012-06-08 Juanma Barranquero <lekktu@gmail.com>
3061
3062 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3063 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3064
8bbbc977
EZ
30652012-06-08 Eli Zaretskii <eliz@gnu.org>
3066
3067 * alloc.c (allocate_vectorlike): Fix last change.
3068
f3372c87
DA
30692012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3070
3071 Block-based vector allocation of small vectors.
3072 * lisp.h (struct vectorlike_header): New field `nbytes',
3073 adjust comment accordingly.
3074 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3075 to denote vector blocks. Adjust users (live_vector_p,
3076 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3077 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3078 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3079 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3080 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3081 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3082 (roundup_size): New constant.
3083 (struct vector_block): New data type.
3084 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3085 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3086 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3087 (sweep_vectors): New functions.
3088 (allocate_vectorlike): Return `zero_vector' as the only vector of
3089 0 items. Allocate new vector from block if vector size is less than
3090 or equal to VBLOCK_BYTES_MAX.
3091 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3092 (init_alloc_once): Add call to init_vectors.
3093
4f18a4ed
SM
30942012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3095
3096 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3097
86f158bc
PE
30982012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3099
3100 * doprnt.c (doprnt): Truncate multibyte char correctly.
3101 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3102 would mishandle a string argument "Xc" if X was a multibyte
3103 character of length 2: it would truncate after X's first byte
3104 rather than including all of X.
3105
c5cfcbe0
CY
31062012-06-06 Chong Yidong <cyd@gnu.org>
3107
3108 * buffer.c (word_wrap): Doc fix.
3109
c05cf390
PE
31102012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3111
3112 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3113
0c3461de
GM
31142012-06-03 Glenn Morris <rgm@gnu.org>
3115
3116 * xdisp.c (tool-bar-style): Doc fix.
3117
c71232db
UM
31182012-06-03 Ulrich Müller <ulm@gentoo.org>
3119
3120 * Makefile.in (PAXCTL): Define.
3121 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3122 binary via PaX flags if the paxctl utility is available.
3123 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3124 Restore PaX flags to their default. (Bug#11398)
3125
383f7350
CY
31262012-06-03 Chong Yidong <cyd@gnu.org>
3127
3128 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3129 buffer (Bug#11226).
3130
5f2c76c6
CY
31312012-06-03 Chong Yidong <cyd@gnu.org>
3132
3133 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3134 (note_mode_line_or_margin_highlight): If there is no help echo,
3135 use mode-line-default-help-echo. Handle the case where the mouse
3136 position is past the end of the mode line string.
3137
3138 * buffer.c (buffer_local_value_1): New function, split from
3139 Fbuffer_local_value; can return Qunbound.
3140 (Fbuffer_local_value): Use it.
3141 (Vmode_line_format): Docstring tweaks.
3142
773d47f6
PE
31432012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3144
3145 * sysdep.c (system_process_attributes): Improve comment.
3146
f2d6a3df
SM
31472012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3148
3149 * keyboard.c: Export real-this-command to Elisp.
3150 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3151 and DEFVAR it. Update all users.
3152
63810350
PE
31532012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3154
7bd5c1f4
PE
3155 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3156
63810350
PE
3157 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3158 Convert pctcpu and pctmem to Lisp float properly.
3159 Let the compiler fold better, as 100.0/0x8000 is exact.
3160
a2821611
AS
31612012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3162
3163 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3164 cons_block.
3165
5fceba1d
PE
31662012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3167
3168 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3169
c98ff5dd
DA
31702012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3171
3172 For a 'struct window', replace some Lisp_Object fields to
3173 bitfields where appropriate, remove unused fields.
3174 * window.h (struct window): Remove unused 'last_mark_x' and
3175 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3176 change it's type from Lisp_Object to bitfield.
3177 Change type of 'force_start', 'optional_new_start',
3178 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3179 fields from Lisp_Object to bitfield. Adjust users accordingly.
3180
ca34e0be
PE
31812012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3182
3183 Pacify gcc -Wdouble-precision when using Xaw.
3184 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3185 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3186 Use 'float' consistently, rather than 'float' in most places
3187 and 'double' in a couple of places.
3188
efc00ab1 31892012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3190
3191 * xdisp.c (handle_stop): Detect whether we have overlay strings
3192 loaded by testing it->current.overlay_string_index to be
3193 non-negative, instead of checking whether n_overlay_strings is
3194 positive. (Bug#11587)
3195
efc00ab1 31962012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3197
3198 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3199
3200 * doc.c (Fsubstitute_command_keys): Doc fix.
3201
efc00ab1 32022012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3203
3204 * search.c (search_buffer): Remove calls to
3205 r_alloc_inhibit_buffer_relocation, as it is now called by
3206 maybe_unify_char, which was the cause of relocation of buffer text
3207 in bug#11519.
3208
efc00ab1 32092012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3210
3211 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3212 for the duration of call to load_charset, to avoid problems with
3213 callers of maybe_unify_char that access buffer text through C
3214 pointers.
3215
3216 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3217 decrement the inhibition flag, instead of just setting or
3218 resetting it.
3219
ba93a187
PE
32202012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3221
3222 Remove obsolete '#define static' cruft.
3223 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3224 This #undef was "temporary" in 2000; it is no longer needed
3225 now that '#define static' has gone away.
3226 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3227 (gray_bitmap_bits): Remove; no longer needed.
3228 All uses replaced with definiens.
3229 * xterm.c: Include "bitmaps/gray.xbm".
3230
9e4bf381
PE
32312012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3232
3233 Clean up __executable_start, monstartup when --enable-profiling.
3234 The following changes affect the code only when profiling.
3235 * dispnew.c (__executable_start): Rename from safe_bcopy.
3236 Define only on platforms that need it.
3237 * emacs.c: Include <sys/gmon.h> when profiling.
3238 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3239 (__executable_start): Remove decl, since lisp.h does it now.
3240 (safe_bcopy): Remove decl; no longer has that name.
3241 (main): Coalesce #if into single bit of code, for simplicity.
3242 Cast pointers to uintptr_t, since standard libraries want integers
3243 and not pointers.
3244 * lisp.h (__executable_start): New decl.
3245
32d72c2f
GM
32462012-05-31 Glenn Morris <rgm@gnu.org>
3247
3248 * image.c (Fimagemagick_types): Doc fix.
3249
baac5bc7
JM
32502012-05-30 Jim Meyering <meyering@redhat.com>
3251
3252 * callproc.c (Fcall_process_region): Include directory component
3253 in mkstemp error message (Bug#11586).
3254
72cb32cf
PE
32552012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3256
3257 * alloc.c, lisp.h (make_pure_vector): Now static.
3258
61b108cc
SM
32592012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3260
3261 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3262 Move to byte-run.el.
3263 (Fautoload): Do the hash-doc more carefully.
3264 * data.c (Fdefalias): Purify definition, except for keymaps.
3265 (Qdefun): Move from eval.c.
3266 * lisp.h (Qdefun): Remove.
3267 * lread.c (read1): Tiny simplification.
3268
471fe23d
TN
32692012-05-29 Troels Nielsen <bn.troels@gmail.com>
3270
934f3f58 3271 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3272 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3273 Bug#9642, but explicitly check that the buffer the overlay would
3274 be moved to is live and rearrange lines to make sure that errors
3275 will not put the overlay in an inconsistent state.
3276 (Fdelete_overlay): Cosmetics.
3277
85d0efd1
EZ
32782012-05-28 Eli Zaretskii <eliz@gnu.org>
3279
3280 * w32term.c (my_bring_window_to_top): New function.
3281 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3282 could be different from the original one.
3283 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3284 (Bug#11513)
3285
3286 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3287 by calling BringWindowToTop.
3288
3289 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3290 (WM_EMACS_END): Increase by one.
3291
da92a98c
PE
32922012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3293
3294 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3295 This avoids undefined behavior that might cause the eassert
3296 to not catch an out-of-range value.
3297
74d1f848
JB
32982012-05-28 Juanma Barranquero <lekktu@gmail.com>
3299
3300 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3301 Update dependencies.
3302
9e1a06fc
EZ
33032012-05-27 Eli Zaretskii <eliz@gnu.org>
3304
3305 * bidi.c (bidi_mirror_char): Fix last change.
3306
f3dd7312
AS
33072012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3308
3309 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3310 when referring to sectname field in printf format.
3311
81899c91
PE
33122012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3313
57b81a9f
PE
3314 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3315 Only r_alloc_inhibit_buffer_relocation needed to be added;
3316 the others were already declared.
3317
81899c91
PE
3318 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3319 before checking whether it's out of range. Put the check inside
3320 eassert. See
3321 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3322
33017faf 33232012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3324
3325 * callproc.c (Fcall_process): Restore a line that was accidentally
3326 commented out in the 2011-02-13 change (bug#11547).
3327
33017faf 33282012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3329
3330 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3331 defined on ralloc.c.
3332
3333 * buffer.c [REL_ALLOC]: Remove prototypes of
3334 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3335 they are now on lisp.h.
3336
3337 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3338
3339 * search.c (search_buffer): Use it to inhibit relocation of buffer
3340 text while re_search_2 is doing its job, because re_search_2 is
3341 passed C pointers to buffer text. (Bug#11519)
3342
23415acf
EZ
3343 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3344 Update value to 24.
3345
44e27368
EZ
3346 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3347 state after an additional call to move_it_in_display_line_to, keep
3348 the values of it->max_ascent and it->max_descent found for the
3349 entire line.
3350 (pos_visible_p): Revert the comparison against bottom_y to what it
3351 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3352 (Bug#11464)
3353
c1892f11
PE
33542012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3355
3356 Fix coding-related core dumps with gcc -ftrapv.
3357 The code was computing A - B, where A and B are pointers, and B is
3358 random garbage. This can lead to core dumps on platforms that
3359 have special pointer registers, and it also leads to core dumps on
3360 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3361 A - B only when B is initialized properly.
3362 * coding.c (coding_set_source, coding_set_destination): Return void.
3363 (coding_change_source, coding_change_destinations): New functions,
3364 with the old behaviors of coding_set_source and coding_set_destination.
3365 All callers that need an offset changed to use these new functions.
3366
eb7afdad
GM
33672012-05-26 Glenn Morris <rgm@gnu.org>
3368
3369 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3370
f12fdf02
EZ
33712012-05-26 Eli Zaretskii <eliz@gnu.org>
3372
53a63be6 3373 Extend mouse support on W32 text-mode console.
61b108cc
SM
3374 * xdisp.c (draw_row_with_mouse_face):
3375 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3376
eb3f6f01 3377 * w32console.c: Include window.h.
61b108cc
SM
3378 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3379 New functions.
eb3f6f01
EZ
3380 (initialize_w32_display): Initialize mouse-highlight data.
3381
53a63be6
EZ
3382 * w32inevt.c: Include termchar.h and window.h.
3383 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3384 moves, call note_mouse_highlight. If help_echo changed, call
3385 gen_help_event to produce help-echo message in the echo area.
3386 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3387 highlight info.
3388
4cfd81f6
PE
33892012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3390
3391 * lread.c (read1): Simplify slightly to avoid an overflow warning
3392 with GCC 4.7.0 on x86-64.
3393
4446092a
EZ
33942012-05-26 Eli Zaretskii <eliz@gnu.org>
3395
3396 * bidi.c (bidi_mirror_char): Revert last change: an int is
3397 definitely wide enough here.
3398
42b2a986 33992012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3400
42b2a986 3401 Fix integer width and related bugs (Bug#9874).
eb106a49 3402 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3403 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3404 (string_bytes, check_sblock, allocate_string_data):
3405 (compact_small_strings, Fmake_bool_vector, make_string)
3406 (make_unibyte_string, make_multibyte_string)
3407 (make_string_from_bytes, make_specified_string)
3408 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3409 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3410 (mark_vectorlike):
3411 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3412 (allocate_pseudovector):
3413 Use int, not EMACS_INT, where int is wide enough.
3414 (inhibit_garbage_collection, Fgarbage_collect):
3415 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3416 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3417 int might not be wide enough.
3418 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3419 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3420 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3421 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3422 (bidi_level_of_next_char, bidi_move_to_visually_next):
3423 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3424 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3425 (Fkill_buffer, Fset_buffer_major_mode)
3426 (advance_to_char_boundary, Fbuffer_swap_text)
3427 (Fset_buffer_multibyte, overlays_at, overlays_in)
3428 (overlay_touches_p, struct sortvec, record_overlay_string)
3429 (overlay_strings, recenter_overlay_lists)
3430 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3431 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3432 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3433 (Foverlay_recenter, last_overlay_modification_hooks_used)
3434 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3435 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3436 (validate_region): Omit unnecessary test for b <= e,
3437 since that's guaranteed by the previous test.
d311d28c
PE
3438 (adjust_overlays_for_delete): Avoid pos + length overflow.
3439 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3440 (report_overlay_modification):
3441 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3442 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3443 Omit pointer cast, which isn't needed anyway, and doesn't work
3444 after the EMACS_INT -> ptrdiff_t change.
02481186 3445 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3446 * buffer.h: Adjust decls to match defn changes elsewhere.
3447 (struct buffer_text, struct buffer):
3448 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3449 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3450 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3451 not int, to avoid needless 32-bit limit on 64-bit hosts.
3452 (exec_byte_code): Use tighter memory-full test, one that checks
3453 for alloca overflow. Don't compute the address of the object just
3454 before an array, as that's not portable. Use EMACS_INT, not
3455 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3456 * callint.c (Fcall_interactively):
3457 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3458 * callproc.c (call_process_kill, Fcall_process):
3459 Don't assume pid_t fits into an Emacs fixnum.
3460 (call_process_cleanup, Fcall_process, child_setup):
3461 Don't assume pid_t fits into int.
3462 (call_process_cleanup, Fcall_process, delete_temp_file)
3463 (Fcall_process_region):
3464 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3465 (Fcall_process): Simplify handling of volatile integers.
3466 Use int, not EMACS_INT, where int will do.
3467 * casefiddle.c (casify_object, casify_region, operate_on_word)
3468 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3469 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3470 (casify_object): Avoid integer overflow when overallocating buffer.
3471 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3472 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3473 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3474 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3475 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3476 integers are now checked earlier. All uses replaced with XINT.
3477 (ccl_driver):
3478 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3479 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3480 (ccl_driver, Fregister_code_conversion_map):
3481 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3482 (resolve_symbol_ccl_program): Check that vector header is in range.
3483 Always copy the vector, so that we can check its contents reliably
3484 now rather than having to recheck each instruction as it's being
3485 executed. Check that vector words fit in 'int'.
3486 (ccl_get_compiled_code, Fregister_ccl_program)
3487 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3488 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3489 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3490 contents are in range.
3491 (Fccl_execute_on_string): Check that status is in range.
3492 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3493 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3494 Accept and return EMACS_INT, not int, because callers can pass values
3495 out of 'int' range.
3496 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3497 (multibyte_chars_in_text, parse_str_as_multibyte)
3498 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3499 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3500 (string_escape_byte8, Fget_byte):
3501 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3502 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3503 avoid mishandling large integers.
3504 * character.h: Adjust decls to match defn changes elsewhere.
3505 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3506 (Ffind_charset_region):
3507 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3508 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3509 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3510 Don't assume fixnum fits in int.
d311d28c
PE
3511 (load_charset_map_from_vector, Fmap_charset_chars):
3512 Remove now-unnecessary CHECK_NATNUMs.
3513 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3514 Don't rely on undefined behavior with signed left shift overflow.
3515 Don't assume unsigned int fits into fixnum, or that fixnum fits
3516 into unsigned int. Don't require max_code to be a valid fixnum;
3517 that's not true for gb10830 4-byte on a 32-bit host. Allow
3518 invalid_code to be a cons, for the same reason. Require code_offset
3519 to be a character. Avoid int overflow if max_char is close
3520 to INT_MAX.
3521 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3522 this is intended anyway and avoids some undefined behavior.
3523 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3524 INDEX_TO_CODE_POINT, as that's what it expects.
3525 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3526 * charset.h (DECODE_CHAR): Return int, not unsigned;
3527 this is what was intended anyway, and it avoids undefined behavior.
3528 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3529 integer-overflow issues.
3530 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3531 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3532 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3533 * chartab.c (Fmake_char_table, Fset_char_table_range)
3534 (uniprop_get_decoder, uniprop_get_encoder):
3535 Don't assume fixnum fits in int.
3536 * cmds.c (move_point): New function, that does the gist of
3537 Fforward_char and Fbackward_char, but does so while checking
3538 for integer overflow more accurately.
c96e5d6a 3539 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3540 (Fforward_line, Fend_of_line, internal_self_insert)
3541 (internal_self_insert):
3542 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3543 Fix a FIXME, by checking for integer overflow when calculating
3544 target_clm and actual_clm.
3545 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3546 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3547 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3548 (coding_alloc_by_making_gap, alloc_destination)
3549 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3550 (encode_coding_utf_16, detect_coding_emacs_mule)
3551 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3552 (detect_coding_iso_2022, decode_coding_iso_2022)
3553 (encode_invocation_designation, encode_designation_at_bol)
3554 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3555 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3556 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3557 (encode_coding_ccl, encode_coding_raw_text)
3558 (detect_coding_charset, decode_coding_charset)
3559 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3560 (produce_composition, produce_charset, produce_annotation)
3561 (decode_coding, handle_composition_annotation)
3562 (handle_charset_annotation, consume_chars, decode_coding_gap)
3563 (decode_coding_object, encode_coding_object, detect_coding_system)
3564 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3565 (code_convert_region, code_convert_string)
8f50130c
PE
3566 (Fdefine_coding_system_internal)
3567 (coding_set_source, coding_set_destination):
d311d28c
PE
3568 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3569 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3570 (Fdefine_coding_system_internal):
3571 Don't assume fixnums fit in int.
3572 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3573 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3574 (Funencodable_char_position, Fcheck_coding_systems_region)
3575 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3576 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3577 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3578 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3579 Don't access memory outside of the args array.
d311d28c 3580 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3581 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3582 result of ENCODE_CHAR.
d311d28c
PE
3583 * coding.h: Adjust decls to match defn changes elsewhere.
3584 (struct coding_system):
3585 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3586 * composite.c (get_composition_id, find_composition)
3587 (run_composition_function, update_compositions)
3588 (compose_text, composition_gstring_put_cache)
3589 (composition_gstring_p, composition_gstring_width)
3590 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3591 (composition_compute_stop_pos, composition_reseat_it)
3592 (composition_update_it, struct position_record)
3593 (find_automatic_composition, composition_adjust_point)
3594 (Fcomposition_get_gstring, Ffind_composition_internal):
3595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3596 (update_compositions):
3597 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3598 * composite.h: Adjust decls to match defn changes elsewhere.
3599 (struct composition):
3600 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3601 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3602 Do not attempt to compute the address of the object just before a
3603 buffer; this is not portable.
3604 (Faref, Faset):
3605 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3606 (Faset): Use int, not EMACS_INT, where int is wide enough.
3607 (Fstring_to_number): Don't assume fixnums fit in int.
3608 (Frem): Don't assume arg is nonnegative.
3609 * dbusbind.c (xd_append_arg): Check for integers out of range.
3610 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3611 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3612 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3613 (xd_get_connection_references): Return ptrdiff_t, not int.
3614 All uses changed.
3615 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3616 (xd_read_message_1):
3617 Use int, not unsigned, where the dbus API uses int.
3618 (Fdbus_message_internal): Don't overflow mtype.
3619 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3620 * dired.c (directory_files_internal, file_name_completion, scmp)
3621 (file_name_completion_stat):
3622 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3623 (file_name_completion): Don't overflow matchcount.
3624 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3625 * dispextern.h: Adjust decls to match defn changes elsewhere.
3626 (struct text_pos, struct glyph, struct bidi_saved_info)
3627 (struct bidi_string_data, struct bidi_it, struct composition_it)
3628 (struct it):
3629 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3630 (struct display_pos, struct composition_it, struct it):
3631 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3632 * dispnew.c (increment_matrix_positions)
3633 (increment_row_positions, mode_line_string)
3634 (marginal_area_string):
3635 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3636 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3637 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3638 (duration_to_sec_usec): New function, to check for overflow better.
3639 (Fsleep_for, sit_for): Use it.
3640 * doc.c (get_doc_string, store_function_docstring):
3641 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3642 (get_doc_string, Fsnarf_documentation):
3643 Use int, not EMACS_INT, where int is wide enough.
3644 (get_doc_string):
3645 Use SAFE_ALLOCA, not alloca.
3646 Check for overflow when converting EMACS_INT to off_t.
3647 * doprnt.c (doprnt):
3648 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3649 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3650 Don't assume uid_t fits into fixnum.
3651 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3652 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3653 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3654 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3655 (general_insert_function)
3656 (Finsert_char, make_buffer_string, make_buffer_string_both)
3657 (update_buffer_properties, Fbuffer_substring)
3658 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3659 (Fsubst_char_in_region, check_translation)
3660 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3661 (transpose_markers, Ftranspose_regions):
3662 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3663 (clip_to_bounds): Move to lisp.h as an inline function).
3664 (Fconstrain_to_field): Don't assume integers are nonnegative.
3665 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3666 (Fsubst_char_in_region, Fsave_restriction):
3667 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3668 (Femacs_pid): Don't assume pid_t fits into fixnum.
3669 (lo_time): Use int, not EMACS_INT, when int suffices.
3670 (lisp_time_argument): Check for usec out of range.
3671 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3672 (Fuser_login_name, Fuser_full_name): Signal an error
3673 if a uid argument is out of range, rather than relying on
3674 undefined behavior.
c8d5c857
PE
3675 (Fformat_time_string): Remove now-unnecessary check.
3676 lisp_time_argument checks for out-of-range usec now.
243e0530 3677 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3678 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3679 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3680 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3681 (init_cmdargs, Fdump_emacs):
3682 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3683 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3684 the bottom (typically) 32 bits of the fixnum.
3685 * eval.c (specpdl_size, call_debugger):
3686 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3687 (when_entered_debugger, Fbacktrace_debug):
3688 Don't assume fixnum can fit in int.
3689 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3690 the object just before a buffer; this is not portable.
3691 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3692 (grow_specpdl, unbind_to):
3693 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3694 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3695 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3696 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3697 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3698 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3699 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3700 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3701 (a_write, e_write):
3702 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3703 (Fcopy_file, non_regular_nbytes, read_non_regular)
3704 (Finsert_file_contents):
3705 Use int, not EMACS_INT, where int is wide enough.
3706 (READ_BUF_SIZE): Verify that it fits in int.
3707 (Finsert_file_contents): Check that counts are in proper range,
3708 rather than assuming fixnums fit into ptrdiff_t etc.
3709 Don't assume fixnums fit into int.
125b3835 3710 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3711 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3712 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3713 (string_char_to_byte, string_byte_to_char)
3714 (string_make_multibyte, string_to_multibyte)
3715 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3716 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3717 (substring_both, Fdelete, internal_equal, Ffillarray)
3718 (Fclear_string, mapcar1)
3719 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3720 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3721 (larger_vector, make_hash_table, maybe_resize_hash_table)
3722 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3723 (Fmaphash, secure_hash):
3724 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3725 (concat): Check for string index and length overflow.
3726 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3727 (Frequire):
3728 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3729 (larger_vector): New API (vec, incr_min, size_max) replaces old
3730 one (vec, new_size, init). This catches size overflow.
3731 INIT was removed because it was always Qnil.
3732 All callers changed.
3733 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3734 the upper bound on a hash table index size.
3735 (make_hash_table, maybe_resize_hash_table): Use it.
3736 (secure_hash): Computer start_byte and end_byte only after
3737 they're known to be in ptrdiff_t range.
3738 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3739 (Ffont_get_glyphs, Ffont_at):
3740 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3741 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3742 (Flist_fonts, Fopen_font):
3743 Don't assume fixnum can fit in int.
3744 (check_gstring): Don't assume index can fit in int.
3745 (font_match_p): Check that fixnum is a character, not a nonnegative
3746 fixnum, since the later code needs to stuff it into an int.
3747 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3748 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3749 conversion overflow issues.
3750 (Fopen_font): Check for integer out of range.
3751 (Ffont_get_glyphs): Don't assume index can fit in int.
3752 * font.h: Adjust decls to match defn changes elsewhere.
3753 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3754 integer overflow.
3755 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3756 printmax_t, where ptrdiff_t is wide enough.
3757 (Finternal_char_font):
3758 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3759 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3760 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3761 (Fset_frame_position, x_set_frame_parameters)
3762 (x_set_line_spacing, x_set_border_width)
3763 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3764 Check that fixnums are in proper range for system types.
3765 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3766 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3767 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3768 Use SAFE_ALLOCA_LISP, not alloca.
3769 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3770 intptr_t is wide enough.
3771 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3772 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3773 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3774 Check for fixnum out of range.
3775 * ftfont.c (ftfont_list): Don't assume index fits in int.
3776 Check that fixnums are in proper range for system types.
3777 (ftfont_shape_by_flt):
3778 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3779 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3780 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3781 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3782 Check that fixnums are in proper range for system types.
3783 * gnutls.h: Adjust decls to match defn changes elsewhere.
3784 * gtkutil.c (xg_dialog_run):
3785 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3786 (update_frame_tool_bar):
3787 Check that fixnums are in proper range for system types.
3788 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3789 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3790 * indent.c (last_known_column, last_known_column_point):
3791 (current_column_bol_cache):
3792 (skip_invisible, current_column, check_display_width):
3793 (check_display_width, scan_for_column, current_column_1)
3794 (Findent_to, Fcurrent_indentation, position_indentation)
3795 (indented_beyond_p, Fmove_to_column, compute_motion):
3796 (Fcompute_motion, Fvertical_motion):
3797 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3798 (last_known_column_modified): Use EMACS_INT, not int.
3799 (check_display_width):
3800 (Fcompute_motion):
3801 Check that fixnums and floats are in proper range for system types.
3802 (compute_motion): Don't assume index or fixnum fits in int.
3803 (compute_motion, Fcompute_motion):
3804 Use int, not EMACS_INT, when it is wide enough.
3805 (vmotion): Omit local var start_hpos that is always 0; that way
3806 we don't need to worry about overflow in expressions involving it.
3807 * indent.h: Adjust decls to match defn changes elsewhere.
3808 (struct position):
3809 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3810 Use int, not EMACS_INT, where int is wide enough.
3811 Remove unused members ovstring_chars_done and tab_offset;
3812 all uses removed.
3813 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3814 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3815 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3816 (make_gap, copy_text, insert, insert_and_inherit)
3817 (insert_before_markers, insert_before_markers_and_inherit)
3818 (insert_1, count_combining_before, count_combining_after)
3819 (insert_1_both, insert_from_string)
3820 (insert_from_string_before_markers, insert_from_string_1)
3821 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3822 (adjust_after_replace, adjust_after_insert, replace_range)
3823 (replace_range_2, del_range, del_range_1, del_range_byte)
3824 (del_range_both, del_range_2, modify_region)
3825 (prepare_to_modify_buffer, signal_before_change)
3826 (signal_after_change, Fcombine_after_change_execute):
3827 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3828 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3829 (balance_an_interval, split_interval_right, split_interval_left)
3830 (find_interval, next_interval, update_interval)
3831 (adjust_intervals_for_insertion, delete_node, delete_interval)
3832 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3833 (static_offset_intervals, offset_intervals)
3834 (merge_interval_right, merge_interval_left, make_new_interval)
3835 (graft_intervals_into_buffer, temp_set_point_both)
3836 (temp_set_point, set_point, adjust_for_invis_intang)
3837 (set_point_both, move_if_not_intangible, get_property_and_range)
3838 (get_local_map, copy_intervals, copy_intervals_to_string)
3839 (compare_string_intervals, set_intervals_multibyte_1):
3840 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3841 * intervals.h: Adjust decls to match defn changes elsewhere.
3842 (struct interval):
3843 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3844 * keyboard.c (this_command_key_count, this_single_command_key_start)
3845 (before_command_key_count, before_command_echo_length, echo_now)
3846 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3847 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3848 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3849 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3850 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3851 (last_non_minibuf_size, last_point_position, echo_truncate)
3852 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3853 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3854 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3855 (stuff_buffered_input):
3856 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3857 (last_auto_save, command_loop_1, read_char):
3858 Use EMACS_INT, not int, to avoid integer overflow.
3859 (record_char): Avoid overflow in total_keys computation.
3860 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3861 * keyboard.h: Adjust decls to match defn changes elsewhere.
3862 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3863 (Fkey_description, Fdescribe_vector, Flookup_key):
3864 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3865 (click_position): New function, to check that positions are in range.
3866 (Fcurrent_active_maps):
3867 (describe_command):
3868 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3869 (Faccessible_keymaps, Fkey_description):
3870 (preferred_sequence_p):
3871 Don't assume fixnum can fit into int.
3872 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3873 Check for integer overflow in size calculations.
3874 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3875 avoid mishandling large integers.
3876 * lisp.h: Adjust decls to match defn changes elsewhere.
3877 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3878 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3879 (struct Lisp_Marker):
3880 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3881 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3882 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3883 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3884 All callers changed.
3885 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3886 Assume the arg has valid form, since it always does.
3887 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3888 unsigned integer system type.
3889 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3890 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3891 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3892 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3893 (duration_to_sec_usec): New decl.
3894 * lread.c (read_from_string_index, read_from_string_index_byte)
3895 (read_from_string_limit, readchar, unreadchar, openp)
3896 (read_internal_start, read1, oblookup):
3897 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3898 (Fload, readevalloop, Feval_buffer, Feval_region):
3899 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3900 (openp): Check for out-of-range argument to 'access'.
3901 (read1): Use int, not EMACS_INT, where int is wide enough.
3902 Don't assume fixnum fits into int.
6efdadfd 3903 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3904 (read_filtered_event): Use duration_to_sec_usec
3905 to do proper overflow checking on durations.
d311d28c
PE
3906 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3907 in size calculation.
3908 (Fexecute_kbd_macro):
3909 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3910 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3911 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3912 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3913 (set_marker_both, set_marker_restricted_both, marker_position)
3914 (marker_byte_position, Fbuffer_has_markers_at):
3915 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3916 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3917 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3918 It now merely ensures that the menu is large enough, without
3919 necessarily growing it, as this avoids some integer overflow issues.
3920 All callers changed.
3921 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3922 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3923 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3924 Use SAFE_ALLOCA_LISP, not alloca.
3925 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3926 to EMACS_INT. Check that fixnums are in proper range for system types.
3927 * minibuf.c (minibuf_prompt_width, string_to_object)
3928 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3929 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3930 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3931 (get_minibuffer, read_minibuf_unwind):
3932 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3933 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3934 this simplifies overflow checking. All callers changed.
3935 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3936 (Ftest_completion):
3937 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3938 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3939 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3940 Check that fixnums are in proper range for system types.
3941 (Fx_create_frame, Fx_show_tip):
3942 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3943 * nsfont.m (ns_findfonts, nsfont_list_family):
3944 Don't assume fixnum fits in long.
3945 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3946 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3947 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3948 wide enough.
17fdb222 3949 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3950 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3951 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3952 (PRINTDECLARE, PRINTPREPARE):
3953 (strout, print_string):
3954 (print, print_preprocess, print_check_string_charset_prop)
3955 (print_object):
3956 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3957 (PRINTDECLARE):
3958 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3959 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3960 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3961 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3962 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3963 (print_error_message): Use SAFE_ALLOCA, not alloca.
3964 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3965 (print_depth, new_backquote_output, print_number_index):
3966 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3967 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3968 (Fset_process_window_size, Fformat_network_address)
3969 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3970 (sigchld_handler):
d311d28c 3971 Check that fixnums are in proper range for system types.
d44287d4 3972 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3973 Check for process-ids out of pid_t range rather than relying on
3974 undefined behavior.
e4d81efc 3975 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3976 (Fformat_network_address, read_process_output, send_process)
3977 (Fprocess_send_region, status_notify):
3978 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3979 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3980 (wait_reading_process_output, read_process_output, exec_sentinel):
3981 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3982 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3983 (Faccept_process_output): Use duration_to_sec_usec to do proper
3984 overflow checking on durations.
dde14581
PE
3985 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3986 Don't assume pid_t fits in int.
02481186
PE
3987 * process.h (struct Lisp_Process): Members tick and update_tick
3988 are now of type EMACS_INT, not int.
b62b53e8
PE
3989 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3990 configured --with-wide-int.
d311d28c
PE
3991 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3992 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3993 * search.c (looking_at_1, string_match_1):
3994 (fast_string_match, fast_c_string_match_ignore_case)
3995 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3996 (scan_newline, find_before_next_newline, search_command)
3997 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3998 (set_search_regs, wordify):
3999 (Freplace_match):
4000 (Fmatch_data):
4001 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4002 (string_match_1, search_buffer, set_search_regs):
4003 (Fmatch_data):
4004 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4005 (wordify): Check for overflow in size calculation.
4006 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4007 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4008 Check that fixnums are in proper range for system types.
4009 * sound.c (struct sound_device)
4010 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4011 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4012 (Fplay_sound_internal):
4013 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4014 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4015 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4016 (Fparse_partial_sexp):
4017 Don't assume fixnums can fit in int.
4018 (struct lisp_parse_state, find_start_pos, find_start_value)
4019 (find_start_value_byte, find_start_begv)
4020 (update_syntax_table, char_quoted, dec_bytepos)
4021 (find_defun_start, prev_char_comend_first, back_comment):
4022 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4023 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4024 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4025 (Finternal_describe_syntax_value): Check that match_lisp is a
4026 character, not an integer, since the code stuffs it into int.
4027 (scan_words, scan_sexps_forward):
4028 Check that fixnums are in proper range for system types.
4029 (Fforward_word):
4030 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4031 (scan_sexps_forward):
4032 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4033 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4034 * syntax.h: Adjust decls to match defn changes elsewhere.
4035 (struct gl_state_s):
4036 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4037 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4038 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4039 * sysdep.c (wait_for_termination_1, wait_for_termination)
4040 (interruptible_wait_for_termination, mkdir):
4041 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4042 (emacs_read, emacs_write):
4043 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4044 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4045 and double all fit in int.
d311d28c
PE
4046 * term.c (set_tty_color_mode):
4047 Check that fixnums are in proper range for system types.
4048 * termhooks.h (struct input_event):
4049 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4050 * textprop.c (validate_interval_range, interval_of)
4051 (Fadd_text_properties, set_text_properties_1)
4052 (Fremove_text_properties, Fremove_list_of_text_properties)
4053 (Ftext_property_any, Ftext_property_not_all)
4054 (copy_text_properties, text_property_list, extend_property_ranges)
4055 (verify_interval_modification):
4056 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4057 (Fnext_single_char_property_change)
4058 (Fprevious_single_char_property_change):
4059 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4060 (copy_text_properties):
4061 Check for integer overflow in index calculation.
d311d28c
PE
4062 * undo.c (last_boundary_position, record_point, record_insert)
4063 (record_delete, record_marker_adjustment, record_change)
4064 (record_property_change):
4065 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4066 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4067 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4068 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4069 (Fx_hide_tip, Fx_file_dialog):
4070 * w32menu.c (set_frame_menubar):
4071 Use ptrdiff_t, not int, for consistency with rest of code.
4072 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4073 (select_window, Fdelete_other_windows_internal)
4074 (window_scroll_pixel_based, window_scroll_line_based)
4075 (Frecenter, Fset_window_configuration):
4076 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4077 (Fset_window_hscroll, run_window_configuration_change_hook)
4078 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4079 (Fscroll_other_window, Frecenter):
d311d28c
PE
4080 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4081 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4082 Don't assume fixnum fits in int.
4083 (Fset_window_scroll_bars):
4084 Check that fixnums are in proper range for system types.
4085 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4086 (string_pos, c_string_pos, number_of_chars, init_iterator)
4087 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4088 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4089 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4090 (face_before_or_after_it_pos, handle_invisible_prop)
4091 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4092 (display_prop_intangible_p, string_buffer_position_lim)
4093 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4094 (get_overlay_strings_1, get_overlay_strings)
4095 (iterate_out_of_display_property, forward_to_next_line_start)
4096 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4097 (get_next_display_element, set_iterator_to_next)
4098 (get_visually_first_element, compute_stop_pos_backwards)
4099 (handle_stop_backwards, next_element_from_buffer)
4100 (move_it_in_display_line_to, move_it_in_display_line)
4101 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4102 (add_to_log, message_dolog, message_log_check_duplicate)
4103 (message2, message2_nolog, message3, message3_nolog
4104 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4105 (current_message_1, truncate_echo_area, truncate_message_1)
4106 (set_message, set_message_1, store_mode_line_noprop)
4107 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4108 (text_outside_line_unchanged_p, check_point_in_composition)
4109 (reconsider_clip_changes)
4110 (redisplay_internal, set_cursor_from_row, try_scrolling)
4111 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4112 (redisplay_window, find_last_unchanged_at_beg_row)
4113 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4114 (trailing_whitespace_p, find_row_edges, display_line)
4115 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4116 (display_mode_element, store_mode_line_string)
4117 (pint2str, pint2hrstr, decode_mode_spec)
4118 (display_count_lines, display_string, draw_glyphs)
4119 (x_produce_glyphs, x_insert_glyphs)
4120 (rows_from_pos_range, mouse_face_from_buffer_pos)
4121 (fast_find_string_pos, mouse_face_from_string_pos)
4122 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4123 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4124 (safe_call, init_from_display_pos, handle_fontified_prop)
4125 (handle_single_display_spec, load_overlay_strings)
4126 (with_echo_area_buffer, setup_echo_area_for_printing)
4127 (display_echo_area, echo_area_display)
4128 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4129 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4130 (redisplay_window, dump_glyph_row, display_mode_line)
4131 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4132 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4133 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4134 (handle_single_display_spec, build_desired_tool_bar_string)
4135 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4136 (get_specified_cursor_type):
4137 Check that fixnums are in proper range for system types.
4138 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4139 (Flookup_image_map):
4140 Don't assume fixnums fit in int.
4141 (compare_overlay_entries):
4142 Avoid mishandling comparisons due to subtraction overflow.
4143 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4144 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4145 (handle_tool_bar_click):
4146 Use int, not unsigned, since we prefer signed and the signedness
4147 doesn't matter here.
4148 (get_next_display_element, next_element_from_display_vector):
4149 Use int, not EMACS_INT, when int is wide enough.
4150 (start_hourglass): Use duration_to_sec_usec to do proper
4151 overflow checking on durations.
4152 * xfaces.c (Fbitmap_spec_p):
4153 Check that fixnums are in proper range for system types.
4154 (compare_fonts_by_sort_order):
4155 Avoid mishandling comparisons due to subtraction overflow.
4156 (Fx_family_fonts, realize_basic_faces):
4157 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4158 (Fx_family_fonts):
4159 Don't assume fixnum fits in int.
4160 Use SAFE_ALLOCA_LISP, not alloca.
4161 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4162 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4163 (face_at_buffer_position, face_for_overlay_string)
4164 (face_at_string_position):
4165 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4166 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4167 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4168 (Fx_show_tip):
4169 Check that fixnums are in proper range for system types.
4170 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4171 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4172 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4173 (Fx_change_window_property): Don't assume fixnums fit in int.
4174 * xfont.c (xfont_chars_supported):
4175 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4176 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4177 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4178 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4179 * xml.c (parse_region):
4180 * xrdb.c (magic_file_p):
4181 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4182 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4183 (x_get_local_selection, x_reply_selection_request)
4184 (x_handle_selection_request, wait_for_property_change):
4185 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4186 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4187 short is wide enough.
4188 (x_send_client_event): Don't assume fixnum fits in int.
4189 * xterm.c (x_x_to_emacs_modifiers):
4190 Don't assume EMACS_INT overflows nicely into int.
4191 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4192 may come from Lisp.
4193 (handle_one_xevent): NATNUMP can eval its arg twice.
4194 (x_connection_closed):
4195 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4196 * xterm.h: Adjust decls to match defn changes elsewhere.
4197 (struct scroll_bar): Use struct vectorlike_header
4198 rather than rolling our own approximation.
4199 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4200
c6574eb5
GM
42012012-05-25 Glenn Morris <rgm@gnu.org>
4202
4203 * lisp.mk (lisp): Update for more files being compiled now.
4204
e8d32c7e
SM
42052012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4206
48def666
SM
4207 * lread.c: Remove `read_pure' which makes no difference.
4208 (read_pure): Remove var.
4209 (unreadpure): Remove function.
4210 (readevalloop): Don't call read_list with -1 flag.
4211 (read1, read_vector): Don't test read_pure any more.
4212 (read_list): Simplify.
4213
e8d32c7e
SM
4214 * fileio.c, character.h: Minor style tweaks.
4215
4b2addb7
DA
42162012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4217
4218 * window.h (clip_changed): Remove useless declaration.
4219
584461b2
JB
42202012-05-22 Juanma Barranquero <lekktu@gmail.com>
4221
4222 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4223 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4224
34374650
PE
42252012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4226
4227 Remove src/m/*.
4228 This directory predates autoconf and is no longer needed nowadays.
4229 Move its few remaining bits of functionality to where they're needed.
4230 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4231 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4232 * m/template.h: Remove.
4233 * Makefile.in (M_FILE): Remove. All uses removed.
4234 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4235 * lisp.h (USE_LSB_TAG):
4236 * mem-limits.h (EXCEEDS_LISP_PTR):
4237 Use VAL_MAX, not VALBITS, in #if.
4238 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4239 (EMACS_UINT): Define unconditionally now.
4240 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4241 (BITS_PER_EMACS_INT): New constants, replacing
4242 what used to be in config.h, but not useful in #if.
4243 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4244 define them any more.
4245 (VAL_MAX): New macro.
4246 (VALMASK): Use it.
4247 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4248 BITS_PER_EMACS_INT, in #if.
4249 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4250 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4251 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4252 * s/ms-w32.h (DATA_START):
4253 Move here from removed file m/intel386.h.
4254 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4255 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4256
261cb4bb
PE
42572012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4258
4259 Assume C89 or later.
4260 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4261 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4262 (xrealloc):
4263 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4264 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4265 * textprop.c, tparam.c (NULL): Remove.
4266 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4267 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4268 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4269 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4270 * xterm.c (input_signal_count): Assume volatile works.
4271
ff23cd9f
KB
42722012-05-21 Ken Brown <kbrown@cornell.edu>
4273
4274 * xgselect.c (xg_select): Fix first argument in call to 'select'
4275 (bug#11508).
4276
1b170bc6
KB
42772012-05-20 Ken Brown <kbrown@cornell.edu>
4278
4279 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4280 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4281
b2f4d39f
KB
42822012-05-19 Ken Brown <kbrown@cornell.edu>
4283
4284 * xfns.c (x_in_use): Remove `static' qualifier.
4285 * xterm.h (x_in_use): Declare.
4286 * xgselect.c: Include xterm.h.
4287 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4288 and `display_arg' (bug#9754).
4289
003fdae2
PE
42902012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4291
9232a6d9
PE
4292 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4293
003fdae2
PE
4294 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4295 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4296
784b56e2
EZ
42972012-05-18 Eli Zaretskii <eliz@gnu.org>
4298
4299 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4300
4301 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4302 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4303
4304 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4305 reference to image_cache->refcount.
4306 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4307
a0a79cde
JL
43082012-05-17 Juri Linkov <juri@jurta.org>
4309
4310 * search.c (Fword_search_regexp, Fword_search_backward)
4311 (Fword_search_forward, Fword_search_backward_lax)
4312 (Fword_search_forward_lax): Move functions to isearch.el
4313 (bug#10145, bug#11381).
4314
b0572523
PE
43152012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4316
4317 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4318
9660f5fc
SM
43192012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4320
4321 * lread.c (init_obarray): Declare Qt and Qnil as special.
4322
4374de83
GM
43232012-05-14 Glenn Morris <rgm@gnu.org>
4324
4325 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4326 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4327
dc44c39a
PE
43282012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4329
078c97cb
PE
4330 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4331
dc44c39a
PE
4332 * unexaix.c: Port to more-recent AIX compilers.
4333 (report_error, report_error_1, make_hdr, copy_sym)
4334 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4335 Make arguments const char *, not char *, to avoid violations of C
4336 standard and to fix some AIX warnings reported by Gilles Pion.
4337
e18afed7 43382012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4339
4340 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4341 already have overlays loaded.
4342 (handle_single_display_spec): Before returning without displaying
4343 fringe bitmap, synchronize the bidi iterator with the main display
4344 iterator, by calling iterate_out_of_display_property.
4345 (iterate_out_of_display_property): Detect buffer iteration by
4346 testing that it->string is a Lisp string.
4347 (get_next_display_element): When the current object is exhausted,
4348 and there's something on it->stack, call set_iterator_to_next to
4349 proceed with what's on the stack, instead of returning zero.
4350 (set_iterator_to_next): If called at the end of a Lisp string,
4351 proceed to consider_string_end without incrementing string
4352 position. Don't increment display vector index past the end of
4353 the display vector. (Bug#11417)
c8fb9dc6
EZ
4354 (pos_visible_p): Don't report a position visible when move_it_to
4355 stopped at the last line of window, which happens to be scanned
4356 backwards by the bidi iteration. (Bug#11464)
ac268e67 4357
e18afed7 43582012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4359
4360 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4361 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4362 are on a TTY, and thus unable to display on the fringes.
4363 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4364 so we need to signal to the caller that this is a "replacing"
4365 display spec. This fixes display when the spec is invalid or we
4366 are on a TTY.
4367
e18afed7 43682012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4369
4370 * unexaix.c (make_hdr): Fix typo in prototype.
4371 This bug broke the build on AIX. Problem reported by Gilles Pion.
4372
9d0a235a
MA
43732012-05-14 Michael Albinus <michael.albinus@gmx.de>
4374
4375 * keyboard.c (kbd_buffer_get_event): Read special events also in
4376 batch mode. (Bug#11415)
4377
9e6b06ed
GM
43782012-05-12 Glenn Morris <rgm@gnu.org>
4379
4380 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4381
c1a1d7a3
EZ
43822012-05-12 Eli Zaretskii <eliz@gnu.org>
4383
4384 * lisp.mk (lisp): Add newcomment.elc.
4385
3fe7cdc8
GM
43862012-05-12 Glenn Morris <rgm@gnu.org>
4387
4388 * Makefile.in (MKDIR_P): New, set by configure.
4389 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4390
53f7d2c0
PE
43912012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4392
4393 Remove unused function hourglass_started.
4394 * dispextern.h (hourglass_started):
4395 * w32fns.c (hourglass_started):
4396 * xdisp.c (hourglass_started): Remove.
4397
75aafb17
JB
43982012-05-10 Juanma Barranquero <lekktu@gmail.com>
4399
4400 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4401 Update dependencies.
4402
12959e8e
PE
44032012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4404
97107e2e
PE
4405 * xgselect.c (xg_select): Put maxfds+1 into a var.
4406 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4407
12959e8e
PE
4408 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4409
836d29b3
DA
44102012-05-10 Dave Abrahams <dave@boostpro.com>
4411
4412 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4413 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4414
5cb67954
MA
44152012-05-09 Michael Albinus <michael.albinus@gmx.de>
4416
4417 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4418 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4419 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4420 Initialize xd_registered_buses.
4421
3478ec45
PE
44222012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4423
b263a6b0
PE
4424 Untag more efficiently if USE_LSB_TAG.
4425 This is based on a proposal by YAMAMOTO Mitsuharu in
4426 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4427 For an admittedly artificial (nth 8000 longlist) benchmark on
4428 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4429 Emacs's overall text size by 1%.
4430 * lisp.h (XUNTAG): New macro.
4431 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4432 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4433 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4434 * eval.c (Fautoload):
4435 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4436 * frame.h (XFRAME): Use XUNTAG.
4437
3478ec45
PE
4438 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4439 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4440 Remove unportable assumptions about print widths of types like
4441 dbus_uint32_t.
4442 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4443 intptr_t when converting between pointer and integer, to avoid GCC
4444 warnings about wrong width.
4445
666b903b 44462012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4447
4448 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4449 stack for each reader_thread, instead of defaulting to 8MB
4450 determined by the linker. This avoids failures in creating
4451 subprocesses on Windows 7, see the discussion in this thread:
4452 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4453
b120cc17
JC
44542012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4455
4456 Fix up display of the *Minibuf-0* buffer in the mini window.
4457 * keyboard.c (read_char): Don't clear the echo area if there's no
4458 message to clear.
4459 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4460 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4461
9a4b36f8
MA
44622012-05-07 Michael Albinus <michael.albinus@gmx.de>
4463
4464 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4465 batch mode.
4466
e5f9458f
CY
44672012-05-06 Chong Yidong <cyd@gnu.org>
4468
4469 * lisp.mk (lisp): Update.
4470
eceeb5fc 44712012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4472
4473 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4474
71873e2b
SM
44752012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4476
4477 * data.c (PUT_ERROR): New macro.
4478 (syms_of_data): Use it. Add new error type `user-error'.
4479 * undo.c (user_error): New function.
4480 (Fprimitive_undo): Use it.
4481 * print.c (print_error_message): Adjust print style for `user-error'.
4482 * keyboard.c (user_error): New function.
4483 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4484
ab0fa4e4
PE
44852012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4486
4487 Do not limit current-time-string to years 1000..9999.
4488 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4489 (Fcurrent_time_string): Support any year that is supported by the
4490 underlying localtime representation. Don't use asctime, as it
4491 has undefined behavior for years outside the range -999..9999.
4492
7ed806a7
PE
44932012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4494
4495 Fix race conditions involving setenv, gmtime, localtime, asctime.
4496 Without this fix, interrupts could mess up code that uses these
4497 nonreentrant functions, since setting TZ invalidates existing
4498 tm_zone or tzname values, and since most of these functions return
4499 pointers to static storage.
4500 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4501 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4502 Grow the critical sections to include not just invoking
4503 localtime/gmtime, but also accessing these functions' results
4504 including their tm_zone values if any, and any related TZ setting.
4505 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4506 so that the struct tm is saved in the critical section.
4507 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4508 motivated by the fact that memory allocation needs to be outside
4509 the critical section.
4510
0c16dfed
DA
45112012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4512
4513 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4514 with RESET_INTERVAL.
4515
4516 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4517 Remove duplicated buffer name initialization.
4518
3f83ace8
JM
45192012-05-02 Jim Meyering <jim@meyering.net>
4520
4521 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4522
c7b8541e
JM
4523 * xfns.c (x_window): Use xstrdup (Bug#11375).
4524
90207a15 45252012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4526
4527 * xdisp.c (pos_visible_p): If already at a newline from the
4528 display string before the 'while' loop, don't walk back the glyphs
4529 from it3.glyph_row. Solves assertion violation when the display
4530 string begins with a newline (egg.el). (Bug#11367)
4531
b593d6a9
AH
45322012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4533
4534 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4535 Move to simple.el.
4536
4737362e
GM
45372012-05-01 Glenn Morris <rgm@gnu.org>
4538
99cf43f9
GM
4539 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4540 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4541 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4542 All were removed before 23.1.
4543
9311dcff
GM
4544 * dispnew.c: Remove HAVE_LIBNCURSES test;
4545 it is always true on relevant platforms.
4546
4d5c6349
GM
4547 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4548 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4549
4737362e
GM
4550 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4551
74dd3a6b
AS
45522012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4553
4554 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4555 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4556 Remove.
4557
13c379ee
PE
45582012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4559
4560 Do not avoid creating empty evaporating overlays (Bug#9642).
4561 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4562 That is, do not delete an evaporating overlay if it becomes
4563 empty after its bounds are adjusted to fit within its buffer.
4564 This fix caused other problems, and I'm reverting it until we get
4565 to the bottom of them.
4566
a8e7d6d7 45672012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4568
4569 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4570
a8e7d6d7 45712012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4572
4573 * xdisp.c (pos_visible_p): If the window start position is beyond
4574 ZV, start the display from buffer beginning. Prevents assertion
4575 violation in init_iterator when the minibuffer window is scrolled
4576 via the scroll bar.
4577
4578 * window.c (window_scroll_pixel_based): Likewise.
4579
a8e7d6d7 45802012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4581
4582 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4583
a8e7d6d7 45842012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4585
4586 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4587 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4588
a8e7d6d7 45892012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4590
b593d6a9
AH
4591 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4592 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4593
1c6900d9
EZ
45942012-04-26 Eli Zaretskii <eliz@gnu.org>
4595
4c3fa1d9
EZ
4596 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4597 display element, check also the underlying string or buffer
4598 character. (Bug#11341)
4599
1c6900d9
EZ
4600 * w32menu.c: Include w32heap.h.
4601 (add_menu_item): If the call to AppendMenuW (via
4602 unicode_append_menu) fails, disable Unicode menus only if we are
4603 running on Windows 9X/Me.
4604
42bf8205
AS
46052012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4606
4607 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4608 (xgetint): Add missing shift for LSB tags.
4609
b1bac16e
MR
46102012-04-24 Martin Rudalics <rudalics@gmx.at>
4611
4612 * keyboard.c (read_char): Don't wipe echo area for select window
4613 events: These might get delayed via `mouse-autoselect-window'
4614 (Bug#11304).
4615
d69621cc
JB
46162012-04-24 Juanma Barranquero <lekktu@gmail.com>
4617
4618 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4619 manipulation of :loaded-from data.
4620
02fd101b
JB
46212012-04-23 Juanma Barranquero <lekktu@gmail.com>
4622
4623 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4624 now a cons (bug#11311).
4625
888bec30
PE
46262012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4627
89a438bd
PE
4628 Do not create empty overlays with the evaporate property (Bug#9642).
4629 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4630 if it becomes empty after its bounds are adjusted to fit within
4631 its buffer. Without this fix, in a nonempty buffer (let ((o
4632 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4633 yields an empty overlay that has the evaporate property, which is
4634 not supposed to happen.
4635
1068fe4d
PE
4636 Fix minor GTK3 problems found by static checking.
4637 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4638 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4639 (struct _EmacsFixedClass, emacs_fixed_get_type):
4640 Move decls here from emacsgtkfixed.h, since they needn't be public.
4641 (emacs_fixed_get_type): Now static.
4642 (emacs_fixed_class_init): Omit unused local.
4643 (emacs_fixed_child_type): Remove; unused.
4644 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4645 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4646 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4647 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4648 (EMACS_FIXED_GET_CLASS): Remove; unused.
4649 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4650
888bec30
PE
4651 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4652 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4653
de85e130
PE
46542012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4655
d0baac98 4656 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4657 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4658 (__malloc_size_t, __malloc_ptrdiff_t):
4659 Remove. All uses removed, replaced by the definiens if needed,
4660 since we can assume C89 or better now.
4661 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4662 (protect_malloc_state, align, get_contiguous_space)
4663 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4664 (malloc_atfork_handler_child, malloc_enable_thread)
4665 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4666 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4667 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4668 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4669 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4670 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4671 Define using prototypes, not old style.
4672 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4673 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4674 (align): Don't assume that signed integer overflow wraps around.
4675 Omit unused local var.
4676 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4677 (_free_internal_nolock, memalign, mallochook, reallochook):
4678 Omit no-longer-needed casts.
4679 (valloc): Use getpagesize, not __getpagesize.
4680 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4681 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4682
de85e130
PE
4683 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4684
dcbf5805
MA
46852012-04-22 Michael Albinus <michael.albinus@gmx.de>
4686
4687 Move functions from C to Lisp. Make non-blocking method calls
4688 the default. Implement further D-Bus standard interfaces.
4689
4690 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4691 (QCdbus_request_name_allow_replacement)
4692 (QCdbus_request_name_replace_existing)
4693 (QCdbus_request_name_do_not_queue)
4694 (QCdbus_request_name_reply_primary_owner)
4695 (QCdbus_request_name_reply_in_queue)
4696 (QCdbus_request_name_reply_exists)
4697 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4698 (QCdbus_registered_serial, QCdbus_registered_method)
4699 (QCdbus_registered_signal): New Lisp objects.
4700 (XD_DEBUG_MESSAGE): Use sizeof.
4701 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4702 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4703 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4704 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4705 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4706 (xd_signature, xd_append_arg): Allow float for integer types.
4707 (xd_get_connection_references): New function.
b593d6a9
AH
4708 (xd_get_connection_address): Rename from xd_initialize.
4709 Return cached address.
dcbf5805
MA
4710 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4711 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4712 level.
4713 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4714 Return number of refcounts.
dcbf5805
MA
4715 (Fdbus_get_unique_name): Make stronger parameter check.
4716 (Fdbus_message_internal): New defun.
4717 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4718 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4719 (Fdbus_send_signal, Fdbus_register_service)
4720 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4721 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4722 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4723 (Vdbus_compiled_version, Vdbus_runtime_version)
4724 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4725 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4726 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4727 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4728 Adapt docstring.
dcbf5805 4729
52828e02
PE
47302012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4731
da05bc4c
PE
4732 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4733 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4734 Do not assume ptrdiff_t is the same width as 'int'.
4735
52828e02
PE
4736 * alloc.c: Handle unusual debugging option combinations.
4737 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4738 since the two debugging options are incompatible.
4739 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4740 is defined.
4741 (mem_init, mem_insert, mem_insert_fixup):
4742 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4743 (NEED_MEM_INSERT): Remove; no longer needed.
4744
f01769f9
LL
47452012-04-22 Leo Liu <sdl.web@gmail.com>
4746
4747 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4748
5790543d
PE
47492012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4750
4751 * sysdep.c [__FreeBSD__]: Minor cleanups.
4752 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4753 Use Emacs indenting style more consistently. Avoid some casts.
4754 Use 'double' consistently rather than mixing 'float' and 'double'.
4755
b91b7e4d
EW
47562012-04-21 Eduard Wiebe <usenet@pusto.de>
4757
b593d6a9
AH
4758 * sysdep.c (list_system_processes, system_process_attributes):
4759 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4760
6114eb15
AS
47612012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4762
4763 * lisp.mk (lisp): Update.
4764
2f38dff7
PE
47652012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4766
4767 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4768 It is never used otherwise.
4769
4ae29f89
SM
47702012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4771
4772 * print.c (print_preprocess): Only check print_depth if print-circle
4773 is nil.
4774 (print_object): Check for cycles even when print-circle is nil and
4775 print-gensym is t, but only check print_depth if print-circle is nil.
4776
f30d612a
CY
47772012-04-20 Chong Yidong <cyd@gnu.org>
4778
4779 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4780 set the status to "failed" and ensure that sentinel is run.
4781
c07a4c0b 47822012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4783
4784 * process.c (Fset_process_inherit_coding_system_flag)
4785 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4786 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4787
c07a4c0b 47882012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4789
4790 * xdisp.c (string_buffer_position_lim): Limit starting position to
4791 BEGV.
4792 (set_cursor_from_row): If called for a mode-line or header-line
4793 row, return zero immediately.
4794 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4795 farther than the first row after the header line, if any.
4796 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4797 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4798
c07a4c0b 47992012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4800
4ae29f89
SM
4801 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4802 (bug#11238).
ad3a2b41 4803
c07a4c0b 48042012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 48052012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4806
4807 configure: new option --enable-gcc-warnings (Bug#11207)
4808 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4809 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4810 (ALL_CFLAGS): Use new macros rather than old.
4811 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4812 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4813 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4814 -Wunused-result, -Wunused-variable. This should go away once
4815 the Emacs and Gnulib regex code is merged.
4816 (xmalloc, xrealloc): Now static.
4817
aba027e8
PE
48182012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4819
4820 * dired.c (Fsystem_groups): Remove unused local.
4821
e5a36063
GM
48222012-04-17 Glenn Morris <rgm@gnu.org>
4823
4824 * dired.c (Fsystem_users): Doc fix.
4825
316411f0
DA
48262012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4827
4828 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4829 (syms_of_dired): Add them.
4830
9426aba4
PE
48312012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4832
b62a57be
PE
4833 Fix minor alloc.c problems found by static checking.
4834 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4835 New extern decls, to avoid calling undeclared functions.
4836 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4837 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4838 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4839 (NEED_MEM_INSERT): New macro.
4840 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4841 Remove one incorrect comment and fix another.
b62a57be 4842
3539f31f
PE
4843 Fix minor ralloc.c problems found by static checking.
4844 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4845 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4846 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4847 (r_alloc_sbrk): Now static.
4848
a041960a
PE
4849 Improve ralloc.c interface checking.
4850 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4851 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4852 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4853 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4854 [REL_ALLOC]: ... to here, to check interface.
4855 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4856 Remove decls. This fixes an "It stinks!".
4857
9426aba4
PE
4858 * alloc.c (which_symbols): Fix alignment issue / type clash.
4859
d55c12ed
AS
48602012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4861
4862 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4863 (struct Lisp_Misc_Any): Likewise.
4864 (struct Lisp_Free): Likewise.
4865 * alloc.c (union aligned_Lisp_Symbol): Define.
4866 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4867 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4868 (union aligned_Lisp_Misc): Define.
4869 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4870 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4871 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4872
b948ce8b
PE
48732012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4874
4875 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4876 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4877 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4878 * s/netbsd.h, s/sol2-6.h:
4879 Remove definition of GC_MARK_STACK, since the default now works.
4880 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4881 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4882 no longer the default.
4883 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4884
35dc09a1 48852012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4886
35dc09a1
GM
4887 * lread.c (lisp_file_lexically_bound_p):
4888 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4889
35dc09a1
GM
48902012-04-14 Eli Zaretskii <eliz@gnu.org>
4891
4892 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4893 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4894
48952012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4896
4897 * nsterm.m (constrainFrameRect): Always constrain when there is only
4898 one screen (Bug#10962).
4899
bcd86815
KB
49002012-04-13 Ken Brown <kbrown@cornell.edu>
4901
4902 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4903
c25df26e
RT
49042012-04-13 Reuben Thomas <rrt@sc3d.org>
4905
4906 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4907
0fc59f1e
DC
49082012-04-11 Daniel Colascione <dancol@dancol.org>
4909
4910 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4911 against is gone. It's better to use vfork now so that when Cygwin
4912 gains a new, working vfork, we use it automatically (bug#10398).
4913
de8c03dc
SM
49142012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4915
4916 * window.c (save_window_save): Obey window-point-insertion-type.
4917
2f097256
GM
49182012-04-11 Glenn Morris <rgm@gnu.org>
4919
4920 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4921
453b951e
SM
49222012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4923
4924 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4925
75f1671a 49262012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4927
4928 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4929 (force_quit_count): New var.
4930 (handle_interrupt): Use it.
4931
2a8ce227
JB
49322012-04-10 Juanma Barranquero <lekktu@gmail.com>
4933
4934 * w32.c (w32_delayed_load): Record the full path of the library
4935 being loaded (bug#10424).
4936
935396c0
GM
49372012-04-09 Glenn Morris <rgm@gnu.org>
4938
05920a43
GM
4939 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4940 not just in the obarray, before snarfing them. (Bug#11036)
4941
935396c0
GM
4942 * Makefile.in ($(leimdir)/leim-list.el):
4943 Pass EMACS rather than BUILT_EMACS.
4944
a18ecafa
TZ
49452012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4946
4947 * process.c (make_process):
4948 * process.h: Add integer `gnutls_handshakes_tried' member to
4949 process struct.
4950
6bbef4e5
JC
4951 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4952 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4953
4954 * gnutls.c (gnutls_log_function2i): Convenience log function.
4955 (emacs_gnutls_read): Use new log functions,
4956 `gnutls_handshakes_tried' process member, and
4957 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4958 attempts per process (connection).
4959
b4d3bc10
CY
49602012-04-09 Chong Yidong <cyd@gnu.org>
4961
4962 * eval.c (Fuser_variable_p, user_variable_p_eh)
4963 (lisp_indirect_variable): Functions deleted.
4964 (Fdefvar): Caller changed.
4965
4966 * callint.c (Finteractive, Fcall_interactively):
4967 * minibuf.c (Fread_variable): Callers changed.
4968
70f4d973
EZ
49692012-04-09 Eli Zaretskii <eliz@gnu.org>
4970
4971 * xdisp.c (set_cursor_from_row): If the display string appears in
4972 the buffer at position that is closer to point than the position
4973 after the display string, display the cursor on the first glyph of
4974 the display string. Fixes cursor display when a 'display' text
4975 property immediately follows invisible text. (Bug#11094)
4976
cb3c2e3e
PE
49772012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4978
4979 composite.c: use 'double' consistently
4980 * composite.c (get_composition_id): Use 'double' consistently
4981 instead of converting 'float' to 'double' and vice versa; this is
4982 easier to understand and avoids a GCC warning.
4983
fd06db5d
GM
49842012-04-09 Glenn Morris <rgm@gnu.org>
4985
50fe702a
GM
4986 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4987 preparation for dumping it with emacs. (Bug#4789)
4988 (leimdir): New variable.
4989 ($(leimdir)/leim-list.el): New rule.
4990 (emacs$(EXEEXT)): Depend on leim-list.el.
4991
fd06db5d
GM
4992 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4993 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4994 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4995
55c131ee
AS
49962012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4997
4998 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4999 proper alignment.
5000
9209588f
JB
50012012-04-07 Juanma Barranquero <lekktu@gmail.com>
5002
5003 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5004 Remove unused local variable.
5005
e3fb2efb
PE
50062012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5007
5008 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5009 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5010 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5011 objects, as mark_maybe_pointer will catch them otherwise.
5012 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5013 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5014
b5385551
PE
50152012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5016
5017 Fix typo that broke non-Windows builds.
5018 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5019
9078ead6
EZ
50202012-04-07 Eli Zaretskii <eliz@gnu.org>
5021
5022 Support building on MS-Windows with libxml2.
5023
5024 * makefile.w32-in (OBJ2): Add xml.$(O).
5025 (GLOBAL_SOURCES): Add xml.c.
5026 ($(BLD)/xml.$(O)): New dependency list.
5027
5028 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5029 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5030 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5031 [!WINDOWSNT]: New macros.
5032 (init_libxml2_functions, libxml2_loaded_p): New functions.
5033 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5034 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5035 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5036 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5037 linked in).
6bbef4e5
JC
5038 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5039 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5040 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5041
5042 * emacs.c: Don't include libxml/parser.h.
5043 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5044 xmlCleanupParser directly.
5045
5046 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5047
3811fdf3
EZ
50482012-04-07 Eli Zaretskii <eliz@gnu.org>
5049
5050 * indent.c (Fvertical_motion): If there is a display string at
5051 point, use it.vpos to compute how many lines to backtrack after
5052 move_it_to point. (Bug#11133)
5053
2f8e16b2
EZ
50542012-04-06 Eli Zaretskii <eliz@gnu.org>
5055
5056 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5057 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5058 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5059 macros related to unification of CJK characters. For the details,
5060 see the discussion following the message here:
5061 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5062
3d439cd1
CY
50632012-04-04 Chong Yidong <cyd@gnu.org>
5064
5065 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5066
8bc53d00
EZ
50672012-04-01 Eli Zaretskii <eliz@gnu.org>
5068
5069 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5070 instead of alloca. (Bug#11138)
5071
3b0512a3
AS
50722012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5073
5074 * w32menu.c (is_simple_dialog): Properly check lisp types.
5075 (Bug#11141)
5076
8427ddd2
EZ
50772012-03-31 Eli Zaretskii <eliz@gnu.org>
5078
979022ef
EZ
5079 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5080 position we get to after a call to move_it_to fails the
5081 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5082 only if we wind up in a string from display property. (Bug#11063)
5083
a6b1c7cc
EZ
5084 * window.c (Fdelete_other_windows_internal): Invalidate the row
5085 and column information about mouse highlight, so that redisplay
5086 restores it after reallocating the glyph matrices. (Bug#7464)
5087
8427ddd2
EZ
5088 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5089 string comes from a `display' text property, use the buffer
5090 position of that property as if we actually saw that position in
5091 the row's glyphs.
697ba24b
EZ
5092 (move_it_by_lines): Remove the assertion that
5093 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5094 violated when there's a before-string at the beginning of a line.
5095 (Bug#11063)
8427ddd2 5096
65a0a738
EZ
50972012-03-30 Eli Zaretskii <eliz@gnu.org>
5098
5099 * xdisp.c (append_space_for_newline): If the default face was
5100 remapped, use the remapped face for the appended newline.
5101 (extend_face_to_end_of_line): Use the remapped default face for
5102 extending the face to the end of the line.
5103 (display_line): Call extend_face_to_end_of_line when the default
5104 face was remapped. (Bug#11068)
5105
581355cc
EZ
51062012-03-29 Eli Zaretskii <eliz@gnu.org>
5107
5108 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5109
e8fc049f
SM
51102012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5111
5112 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5113
4fb9a543
GM
51142012-03-27 Glenn Morris <rgm@gnu.org>
5115
5116 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5117 Doc fixes.
5118
679910f1
KH
51192012-03-26 Kenichi Handa <handa@m17n.org>
5120
5121 * dispextern.h (struct glyph): Fix previous change. Change the
5122 bit length of glyphless.ch to 25 (Bug#11082).
5123
90d49b7f
CY
51242012-03-26 Chong Yidong <cyd@gnu.org>
5125
5126 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5127 (command_loop_1): Use it; inhibit selection update for
5128 handle-select-window too (Bug#8996).
5129
f514f6f0
FP
51302012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5131
e8fc049f 5132 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5133
bf43fa51
KH
51342012-03-25 Kenichi Handa <handa@m17n.org>
5135
5136 * dispextern.h (struct glyph): Change the bit length of
5137 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5138
8a0c01dd
EZ
51392012-03-24 Eli Zaretskii <eliz@gnu.org>
5140
5141 * s/ms-w32.h (tzname): Include time.h before redirecting to
5142 _tzname. Fixes the MSVC build. (Bug#9960)
5143
7d1c3a76
AS
51442012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5145
8ed79523
AS
5146 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5147 characters.
5148
7d1c3a76
AS
5149 * xterm.c (XTread_socket): Only modify handling_signal if
5150 !SYNC_INPUT. (Bug#11080)
5151
e99a9b8b
EZ
51522012-03-23 Eli Zaretskii <eliz@gnu.org>
5153
5154 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5155 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5156 when fetching a multibyte character consumes more bytes than
5157 CHAR_BYTES returns, due to unification of CJK characters in
5158 string_char. (Bug#11073)
5159
5063c0e1
TN
51602012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5161
5162 * process.c (wait_reading_process_output): Handle pty disconnect
5163 by refraining from sending oneself a SIGCHLD (bug#10933).
5164
9f851fbd
CY
51652012-03-22 Chong Yidong <cyd@gnu.org>
5166
5167 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5168
5063c0e1 5169 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5170 Mark string as coming from a prefix property.
5171 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5172 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5173
fb5b8aca
CY
51742012-03-21 Chong Yidong <cyd@gnu.org>
5175
5176 * xfaces.c (Vface_remapping_alist): Doc fix.
5177
62356a1b
EZ
51782012-03-20 Eli Zaretskii <eliz@gnu.org>
5179
5180 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5181 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5182 Doc fixes.
62356a1b 5183
025de85b
CY
51842012-03-20 Chong Yidong <cyd@gnu.org>
5185
5186 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5187 to reflect default non-nil value of redisplay-dont-pause.
5188
4827f94e
KH
51892012-03-19 Kenichi Handa <handa@m17n.org>
5190
5191 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5192 it fit in a valid range (Bug#11003).
5193
e50a24a2
EZ
51942012-03-18 Eli Zaretskii <eliz@gnu.org>
5195
5196 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5197 that is not from display property, accept the row as a "cursor
5198 row" if one of the string's character has a non-nil `cursor'
5199 property. Fixes cursor positioning when there are newlines in
5200 overlay strings, e.g. in icomplete.el. (Bug#11035)
5201
9af5ed87
PE
52022012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5203
5204 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5205
d1f55f16
CY
52062012-03-12 Chong Yidong <cyd@gnu.org>
5207
5208 * eval.c (inhibit_lisp_code): Rename from
5209 inhibit_window_configuration_change_hook; move from window.c.
5210
5211 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5212 * window.c (run_window_configuration_change_hook)
5213 (syms_of_window): Callers changed.
5214
66c5eebd
CY
52152012-03-11 Chong Yidong <cyd@gnu.org>
5216
413df973
CY
5217 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5218
66c5eebd
CY
5219 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5220
1de11f56
CY
52212012-03-10 Chong Yidong <cyd@gnu.org>
5222
5223 * frame.c (other_visible_frames): Don't assume the selected frame
5224 is visible (Bug#10955).
5225
cae07000
SM
52262012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5227
5228 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5229
89c94350
JD
52302012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5231
5232 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5233 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5234 zero (Bug#10954).
5235
999dd333
GM
52362012-03-03 Glenn Morris <rgm@gnu.org>
5237
01a6dcc8 5238 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5239
de0100f2
EZ
52402012-03-02 Eli Zaretskii <eliz@gnu.org>
5241
5242 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5243 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5244 (redisplay_window, next_element_from_string): Fix typos in
5245 comments.
3e441275
EZ
5246 (redisplay_window): Pass to move_it_vertically the margin in
5247 pixels, not in screen lines.
de0100f2 5248
96a72ee9
GM
52492012-03-02 Glenn Morris <rgm@gnu.org>
5250
5251 * buffer.c (buffer-list-update-hook): Doc fix.
5252
312508d7
EZ
52532012-02-29 Eli Zaretskii <eliz@gnu.org>
5254
5255 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5256 push_it before setting up the iterator for the first overlay
5257 string, even if we have an empty string loaded.
5258 (next_overlay_string): If there's an empty string on the iterator
5259 stack, pop the stack. (Bug#10903)
5260
27f3c637
PE
52612012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5262
5263 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5264 Suggested by Stefan Monnier in
5265 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5266 * alloc.c (widen_to_Lisp_Object): New static function.
5267 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5268 and widening them to Lisp_Objects. This would work even if
5269 USE_LSB_TAG is defined and wide integers are used, which might
5270 happen in a future version of Emacs.
5271
3c9dfce6
CY
52722012-02-25 Chong Yidong <cyd@gnu.org>
5273
fa74b241
CY
5274 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5275 Doc fix.
5276
3c9dfce6
CY
5277 * xselect.c (Fx_selection_exists_p): Doc fix.
5278 (x_clipboard_manager_save_all): Print an informative message
5279 before saving to clipboard manager.
5280
9486df08
CY
52812012-02-24 Chong Yidong <cyd@gnu.org>
5282
5283 * keyboard.c (process_special_events): Handle all X selection
5284 requests in kbd_buffer, not just the next one (Bug#8869).
5285
f01d3321
CY
52862012-02-23 Chong Yidong <cyd@gnu.org>
5287
5288 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5289 call when setting menu-bar-lines and tool-bar-lines parameters.
5290 (unwind_create_frame_1): New helper function.
5291
5292 * window.c (inhibit_window_configuration_change_hook): New var.
5293 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5294 (syms_of_window): Initialize it.
f01d3321 5295
86b847b6
CY
52962012-02-22 Chong Yidong <cyd@gnu.org>
5297
5298 * xterm.c (x_draw_image_relief): Add missing type check for
5299 Vtool_bar_button_margin (Bug#10743).
5300
a59225b1
CY
53012012-02-21 Chong Yidong <cyd@gnu.org>
5302
5303 * fileio.c (Vfile_name_handler_alist): Doc fix.
5304
5305 * buffer.c (Fget_file_buffer): Protect against invalid file
5306 handler return value.
5307
310f5bd4
PE
53082012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5309
cb3a28cc
PE
5310 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5311 when computing $valmask.
5312
310f5bd4
PE
5313 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5314 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5315 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5316 It's useless in that case, and it can cause problems on hosts
5317 that allocate halves of EMACS_INT values separately.
5318 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5319 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5320 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5321 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5322 it avoids undefined behavior on hosts where shifting right by more
5323 than the word width has undefined behavior.
5324
2375c96a
CY
53252012-02-19 Chong Yidong <cyd@gnu.org>
5326
5327 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5328 (Funhandled_file_name_directory, Ffile_name_as_directory)
5329 (Fdirectory_file_name, Fexpand_file_name)
5330 (Fsubstitute_in_file_name): Protect against invalid file handler
5331 return values (Bug#10845).
5332
3eb49e71
EZ
53332012-02-18 Eli Zaretskii <eliz@gnu.org>
5334
5335 * .gdbinit (pitx): Fix incorrect references to fields of the
5336 iterator stack.
5337
7b926f3f
CY
53382012-02-17 Chong Yidong <cyd@gnu.org>
5339
5340 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5341
11273115
PE
53422012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5343
5344 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5345 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5346
c3a70e2b
CY
53472012-02-15 Chong Yidong <cyd@gnu.org>
5348
5349 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5350 marked as special. Also, starting docstrings with * is obsolete.
5351
0ca43699
AS
53522012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5353
5354 * gnutls.c (emacs_gnutls_write): Fix last change.
5355
2e8f3c56
LI
53562012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5357
5358 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5359 send_process.
5360
af70074f
SM
53612012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5362
5363 * keymap.c (Fsingle_key_description): Handle char ranges.
5364
95986d52
CY
53652012-02-12 Chong Yidong <cyd@gnu.org>
5366
afd83bd1
CY
5367 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5368 as that creates a dangerous corner case.
5369
95986d52
CY
5370 * window.c (Fdelete_window_internal): Invalidate the mouse
5371 highlight (Bug#9904).
5372
bd7da63e
GM
53732012-02-12 Glenn Morris <rgm@gnu.org>
5374
5375 * xselect.c (Fx_own_selection_internal)
5376 (Fx_get_selection_internal, Fx_disown_selection_internal)
5377 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5378 * nsselect.m (Fx_own_selection_internal)
5379 (Fx_disown_selection_internal, Fx_selection_exists_p)
5380 (Fx_selection_owner_p, Fx_get_selection_internal):
5381 Sync docs and argument specs with the xselect.c versions.
5382
77abcbc2
LI
53832012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5384
5385 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5386
90b671e2
EZ
53872012-02-11 Eli Zaretskii <eliz@gnu.org>
5388
1c0ca0b7
EZ
5389 * w32select.c (Fx_selection_exists_p): Sync doc string and
5390 argument list with xselect.c. (Bug#10783)
5391
5392 * w16select.c (Fx_selection_exists_p): Sync doc string and
5393 argument list with xselect.c. (Bug#10783)
90b671e2 5394
49241268
GM
53952012-02-10 Glenn Morris <rgm@gnu.org>
5396
5397 * fns.c (Fsecure_hash): Doc fix.
5398
f998bbe7 53992012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5400
5401 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5402
0992bd9c
CY
54032012-02-07 Chong Yidong <cyd@gnu.org>
5404
5405 * buffer.c (Fbuffer_local_variables)
5406 (buffer_lisp_local_variables): Handle unbound vars correctly;
5407 don't let Qunbound leak into Lisp.
5408
af008560
GM
54092012-02-07 Glenn Morris <rgm@gnu.org>
5410
dd605cc4
GM
5411 * image.c (Fimagemagick_types): Doc fix.
5412
af008560
GM
5413 * image.c (imagemagick-render-type): Change it from a lisp object
5414 to an integer. Move the doc here from the lisp manual.
5415 Treat all values not equal to 0 the same.
5416
1449fa1d
CY
54172012-02-06 Chong Yidong <cyd@gnu.org>
5418
5419 * doc.c (store_function_docstring): Avoid applying docstring of
5420 alias to base function (Bug#2603).
5421
3723ec07
AS
54222012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5423
5424 * .gdbinit (pp1, pv1): Remove redundant defines.
5425 (pr): Use pp.
5426
79c1cc1e
CY
54272012-02-04 Chong Yidong <cyd@gnu.org>
5428
5429 * nsterm.m: Declare a global (Bug#10694).
5430
d7f29f8e
EZ
54312012-02-04 Eli Zaretskii <eliz@gnu.org>
5432
cae07000
SM
5433 * w32.c (get_emacs_configuration_options):
5434 Include --enable-checking, if specified, in the return value.
d7f29f8e 5435
3b95a6f9
MR
54362012-02-04 Martin Rudalics <rudalics@gmx.at>
5437
5438 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5439 after rounding frame sizes. (Bug#9723)
5440
d6fa96a6
EZ
54412012-02-04 Eli Zaretskii <eliz@gnu.org>
5442
5443 * keyboard.c (adjust_point_for_property): Don't position point
5444 before BEGV. (Bug#10696)
5445
df0b2940
PE
54462012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5447
5448 Handle overflow when computing char display width (Bug#9496).
5449 * character.c (char_width): Return EMACS_INT, not int.
5450 (char_width, c_string_width): Check for overflow when
5451 computing the width; this is possible now that individual
5452 characters can have unbounded width. Problem introduced
5453 by merge from Emacs 23 on 2012-01-19.
5454
6bee44d6
MA
54552012-02-02 Michael Albinus <michael.albinus@gmx.de>
5456
5457 * dbusbind.c (Fdbus_register_method): Mention the return value
5458 :ignore in the docstring.
5459
44f92739
GM
54602012-02-02 Glenn Morris <rgm@gnu.org>
5461
1b9f60cc
GM
5462 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5463
44f92739
GM
5464 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5465 Unconditionally set to t. (Bug#10673)
5466 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5467 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5468 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5469
c5d3843c
KH
54702012-02-02 Kenichi Handa <handa@m17n.org>
5471
5472 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5473 0, do not call append_composite_glyph.
5474
159462d4 54752012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5476
5477 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5478 NULL (Bug#6988).
5479 (x_produce_glyphs): If the component of a composition is a null
5480 string, set it->pixel_width to 1 to avoid zero-width glyph.
5481
78cef877
EZ
54822012-02-01 Eli Zaretskii <eliz@gnu.org>
5483
5484 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5485 first 2 arguments are identical. This makes inserting large
5486 output from a subprocess an order of magnitude faster on
5487 MS-Windows, where all sbrk'ed memory is always contiguous.
5488
97897668
GM
54892012-01-31 Glenn Morris <rgm@gnu.org>
5490
5491 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5492 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5493 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5494
31fd3586
GM
54952012-01-29 Glenn Morris <rgm@gnu.org>
5496
5497 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5498
0e24a8b2
CY
54992012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5500
5501 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5502
cc0adcb0
CY
55032012-01-28 Chong Yidong <cyd@gnu.org>
5504
5505 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5506
acc28cb9
CY
55072012-01-26 Chong Yidong <cyd@gnu.org>
5508
9c69cfb7
CY
5509 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5510
acc28cb9
CY
5511 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5512 repeat counts (Bug#10507).
5513
48da7392
GM
55142012-01-26 Glenn Morris <rgm@gnu.org>
5515
5516 * lread.c (syms_of_lread): Doc fix.
5517
14af5f7f
CY
55182012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5519
5520 * coding.c (encode_designation_at_bol): Change return value to
5521 EMACS_INT.
5522
0b21c100
CY
55232012-01-25 Chong Yidong <cyd@gnu.org>
5524
5525 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5526
3c2907f7
CY
55272012-01-21 Chong Yidong <cyd@gnu.org>
5528
5529 * floatfns.c (Fcopysign): Make the second argument non-optional,
5530 since nil is not allowed anyway.
5531
959ad23f
AS
55322012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5533
5534 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5535 (send_process): Likewise.
5536
34a02f46
MR
55372012-01-19 Martin Rudalics <rudalics@gmx.at>
5538
5539 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5540 (Vwindow_persistent_parameters): Do not use Qstate.
5541 Rewrite doc-strings.
34a02f46 5542
1259009a 55432012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5544
5545 * character.c (char_width): New function.
70d4fdf6
GM
5546 (Fchar_width, c_string_width, lisp_string_width):
5547 Use char_width (Bug#9496).
25ed9e61 5548
6a6ee00d
MR
55492012-01-16 Martin Rudalics <rudalics@gmx.at>
5550
5551 * window.c (Vwindow_persistent_parameters): New variable.
5552 (Fset_window_configuration, save_window_save): Handle persistent
5553 window parameters.
5554
c85efaf7
EZ
55552012-01-14 Eli Zaretskii <eliz@gnu.org>
5556
5557 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5558 thrashing the stack of the thread. (Bug#9087)
5559
5944709e
PE
55602012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5561
5562 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5563
e71f5d99
EZ
55642012-01-11 Eli Zaretskii <eliz@gnu.org>
5565
5566 * xdisp.c (rows_from_pos_range): Handle the case where the
5567 highlight ends on a newline. (Bug#10464)
5568 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5569 he end column for display of highlight that ends on a newline
5570 before a R2L line.
5571
ce316182
GM
55722012-01-11 Glenn Morris <rgm@gnu.org>
5573
5574 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5575 from load-path also when installation-directory is nil. (Bug#10208)
5576
5b43da69
GM
55772012-01-10 Glenn Morris <rgm@gnu.org>
5578
74cc8ff9
GM
5579 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5580
7d8d6e4e
GM
5581 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5582 Update template values to be closer to their typical values these days.
5b43da69 5583
a0db8d43
EZ
55842012-01-09 Eli Zaretskii <eliz@gnu.org>
5585
5586 * xdisp.c (rows_from_pos_range): Accept additional argument
5587 DISP_STRING, and accept any glyph in a row whose object is that
5588 string as eligible for mouse highlight. Fixes mouse highlight of
5589 display strings from overlays. (Bug#10464)
5590
9a0115ab 55912012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5592
b9110d6a 5593 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5594 * fileio.c (auto_saving_dir_umask): New static var.
5595 (Fmake_directory_internal): Use it.
5596 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5597 creating the directory. The old code temporarily assigns
5598 too-generous permissions to the directory.
5599 (do_auto_save_eh): Clear it.
b9110d6a 5600 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5601 that the var is always cleared.
5602
6c1bd3f3
EZ
56032012-01-07 Eli Zaretskii <eliz@gnu.org>
5604
5605 * search.c (scan_buffer): Pass character positions to
5606 know_region_cache, not byte positions. (Bug#6540)
5607
069d2b50
L
56082012-01-07 LynX <_LynX@bk.ru> (tiny change)
5609
5610 * w32.c (sys_rename): Report EXDEV when rename of a directory
5611 fails because the target is on another logical disk. (Bug#10284)
5612
75bf0d33
DB
56132012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5614
5615 * xterm.c (x_embed_request_focus): New function.
5616
5617 * xterm.h: Add prototype.
5618
5619 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5620
1c6e5a32
GM
56212012-01-05 Glenn Morris <rgm@gnu.org>
5622
5623 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5624
651e947e
EZ
56252012-01-01 Eli Zaretskii <eliz@gnu.org>
5626
5627 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5628 Load gnutls_transport_set_lowat only if GnuTLS version is below
5629 2.11.1.
5630 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5631 GnuTLS versions below 2.11.1.
5632
3778cdd8
AL
56332011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5634
5635 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5636 to the doc string advising against its use for altering the way
5637 windows are scrolled.
5638
0e5317f7
KH
56392011-12-28 Kenichi Handa <handa@m17n.org>
5640
5641 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5642 coding-system ASCII compatible only when it does not produce BOM
5643 on encoding (Bug#10383).
5644
93d5ca1f
JD
56452011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5646
5647 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5648 can scroll.
5649 (create_and_show_popup_menu): Always use menu_position_func for
5650 Gtk3 (Bug#10361).
5651
ca22b785
AS
56522011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5653
5654 * callint.c (Fcall_interactively): Don't truncate prompt string.
5655
d048e1e6
EZ
56562011-12-23 Eli Zaretskii <eliz@gnu.org>
5657
5658 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5659 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5660 resumed from there (after widening). (Bug#10360)
d048e1e6 5661
5ccaba1f
JD
56622011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5663
5664 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5665
204ee57f
JD
56662011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5667
b81d40f0
JB
5668 * nsterm.m (x_free_frame_resources):
5669 Release f->output_data.ns->miniimage.
204ee57f
JD
5670 (ns_index_color): Fix indentation. Do not retain
5671 color_table->colors[i].
5672
5673 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5674 before returning.
5675
5676 * nsfns.m (x_set_background_color): Assign return value from
5677 ns_index_color to face-background instead of NSColor*.
5678 (ns_implicitly_set_icon_type): Fix indentation.
5679 Change assignment in for loop to comparison.
5680
5681 * emacs.c (ns_pool): New variable.
5682 (main): Assign ns_pool.
5683 (Fkill_emacs): Call ns_release_autorelease_pool.
5684
5685 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5686 autorelease fdesc, release fdAttrs and tdict.
5687 (ns_get_covering_families): Release charset.
5688 (ns_findfonts): Release NSFontDescriptor created with new.
5689 (ns_uni_to_glyphs): Fix indentation.
5690 (setString): Release attrStr before assigning new value.
5691
c803b2b7
JD
56922011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5693
678f4426
JD
5694 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5695 and NS_IMPL_COCOA.
5696 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5697 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5698
cd394be1 56992011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5700
5fecd5fc
JD
5701 * nsterm.m (ns_term_init): Subscribe for notifications
5702 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5703 to method trackingNotification in EmacsMenu.
5704
5705 * nsmenu.m (trackingMenu): New variable.
3771cb17 5706 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5707 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5708 from Aquamacs (Bug#7030).
678f4426
JD
5709
57102011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5711
c803b2b7
JD
5712 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5713 (symbol_to_nsstring): Fix indentation.
5714 (ns_symbol_to_pb): New function.
cae07000
SM
5715 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5716 (Fns_rotate_cut_buffers_internal): Remove.
5717 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5718 Fns_store_cut_buffer_internal.
5719 (ns_get_foreign_selection, Fx_own_selection_internal)
5720 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5721 (Fns_get_selection_internal, Fns_store_selection_internal):
5722 Use ns_symbol_to_pb and check if return value is nil.
5723 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5724 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5725 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5726 renamed to Sns_store_selection_internal.
5727 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5728 and remove this function.
5729 (ns_handle_selection_clear): Remove, never used.
5730 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5731 here.
5732
e1b01a3a
KB
57332011-12-17 Ken Brown <kbrown@cornell.edu>
5734
5735 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5736 GID is unknown (Bug#10257).
5737
2adb6e85
PE
57382011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5739
5740 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5741 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5742 which caused a build failure on GNU/Linux IA-64. This problem was
5743 introduced by my 2011-10-07 patch.
5744
d1d7b339
JL
57452011-12-15 Juri Linkov <juri@jurta.org>
5746
5747 * image.c (imagemagick_error): New function. (Bug#10112)
5748 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5749 Use `imagemagick_error' where ImageMagick functions return
5750 `MagickFalse'.
5751 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5752 proper order.
5753
100d5755
KH
57542011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5755
5756 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5757 fill background (Bug#8992).
5758
454592a6
MR
57592011-12-13 Martin Rudalics <rudalics@gmx.at>
5760
5761 * window.c (Vwindow_combination_resize)
5762 (Vwindow_combination_limit): Use t instead of non-nil in
5763 doc-strings.
61d4b438
MR
5764 (Vrecenter_redisplay): Add first sentence of doc-string on
5765 separate line.
53524d93 5766 (Frecenter): Fix doc-string typo.
454592a6 5767
3633e3aa
KH
57682011-12-11 Kenichi Handa <handa@m17n.org>
5769
5770 * coding.c (Funencodable_char_position): Pay attention to the
5771 buffer text relocation (Bug#9389).
5772
7b9d523a 57732011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5774
7b9d523a
JD
5775 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5776 gtk_init (Bug#10100).
5777
b73189c6
EZ
57782011-12-10 Eli Zaretskii <eliz@gnu.org>
5779
5780 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5781 IT->string is nil. (Bug#10263)
5782
f7dfe5d6
JD
57832011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5784
83faebb4
JD
5785 * nsterm.h (x_free_frame_resources): Declare.
5786
f7dfe5d6
JD
5787 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5788 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5789
5790 * nsterm.h (ns_get_defaults_value): Declare.
5791
5792 * nsterm.m (ns_default): Call ns_get_defaults_value.
5793
7cd4e72c
EZ
57942011-12-09 Eli Zaretskii <eliz@gnu.org>
5795
5796 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5797 (Bug#10170)
5798
b34d7317
YM
57992011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5800
5801 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5802 that where the value of an _OBJC_* symbol points to is in the .bss
5803 section (Bug#10240).
5804
76470ad1
KH
58052011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5806
5807 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5808 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5809
745fff94
KH
58102011-12-08 Kenichi Handa <handa@m17n.org>
5811
5812 * ftfont.c (get_adstyle_property): Fix previous change
5813 (Bug#10233).
5814
6e44397c
JB
58152011-12-07 Juanma Barranquero <lekktu@gmail.com>
5816
5817 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5818 dirs from the default value of EMACSLOADPATH (bug#10208).
5819
7efa6272
GM
58202011-12-07 Glenn Morris <rgm@gnu.org>
5821
5822 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5823 installation and source directories as well. (Bug#10208)
5824
f6fc4d87
CY
58252011-12-06 Chong Yidong <cyd@gnu.org>
5826
5827 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5828
2bf26180
GM
58292011-12-06 Glenn Morris <rgm@gnu.org>
5830
5831 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5832 as an error, not just -1. (Bug#10217)
5833
3a6ad4f0
CY
58342011-12-05 Chong Yidong <cyd@gnu.org>
5835
5836 * keyboard.c (process_special_events): New function.
5837 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5838
75a3b399
PE
58392011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5840
5841 * coding.c (encode_designation_at_bol): Don't use uninitialized
5842 local variable (Bug#9318).
5843
c3c9e25e
KH
58442011-12-05 Kenichi Handa <handa@m17n.org>
5845
5846 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5847 return Qnil (Bug#8046, Bug#10193).
5848
5eb05ea3
KH
58492011-12-05 Kenichi Handa <handa@m17n.org>
5850
5851 * coding.c (encode_designation_at_bol): New args charbuf_end and
5852 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5853 (coding_set_source): Return how many bytes coding->source was
5854 relocated.
5855 (coding_set_destination): Return how many bytes
5856 coding->destination was relocated.
5857 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5858 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5859
58602011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5861
5862 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5863 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5864 macro (Bug#9318).
5865
58662011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5867
5868 The following changes are to fix Bug#9318.
5869
a79703f5 5870 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5871 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5872 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5873 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5874
7dbda6df
JB
58752011-12-05 Juanma Barranquero <lekktu@gmail.com>
5876
5877 * lisp.h (process_quit_flag): Fix external declaration.
5878
6d5eb5b0
SM
58792011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5880
5881 Don't macro-inline non-performance-critical code.
5882 * eval.c (process_quit_flag): New function.
5883 * lisp.h (QUIT): Use it.
5884
a0c3fad0
JD
58852011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5886
5887 * nsfns.m (get_geometry_from_preferences): New function.
5888 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5889
6c07aac2
AS
58902011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5891
5892 * emacs.c (Qkill_emacs): Define.
5893 (syms_of_emacs): Initialize it.
5894 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5895 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5896 (quit_throw_to_read_char): Add parameter `from_signal'.
5897 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5898 * lisp.h (QUIT): Call Fkill_emacs if requested.
5899
c052ead4
JD
59002011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5901
5902 * widget.c (update_wm_hints): Return if wmshell is null.
5903 (widget_update_wm_size_hints): New function.
5904
5905 * widget.h (widget_update_wm_size_hints): Declare.
5906
5907 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5908 widget_update_wm_size_hints (Bug#10104).
5909
9e49252b
EZ
59102011-12-03 Eli Zaretskii <eliz@gnu.org>
5911
5912 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5913 before a newline, prepare the bidi iterator for consuming the
5914 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5915 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5916
02b16839
JL
59172011-12-02 Juri Linkov <juri@jurta.org>
5918
5919 * search.c (Fword_search_regexp): New Lisp function created from
5920 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5921 (Fword_search_backward, Fword_search_forward)
5922 (Fword_search_backward_lax, Fword_search_forward_lax):
5923 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5924 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5925
0068070e
SM
59262011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5927
5928 * fileio.c (Finsert_file_contents): Move after-change-function call
5929 to before the "handled:" label, since all "goto handled" appear in
5930 cases where the *-change-functions have already been properly called
5931 (bug#10117).
5932
3360a3fc
AS
59332011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5934
5935 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5936 waiting for input. (Bug#10169)
5937
73d6c093
EZ
59382011-11-30 Eli Zaretskii <eliz@gnu.org>
5939
5940 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5941 verifies glyph row's hash code--we have just reallocated the
5942 glyphs, so their contents can be complete garbage. (Bug#10164)
5943
febe6bea
JB
59442011-11-30 Juanma Barranquero <lekktu@gmail.com>
5945
5946 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5947
801a4313
EZ
59482011-11-30 Eli Zaretskii <eliz@gnu.org>
5949
5950 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5951 attributes are tested _before_ calling verify_row_hash, to protect
5952 against GCC re-ordering of the tests. (Bug#10164)
5953
2b56b87e
JD
59542011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5955
5956 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5957
5958 * xterm.c (handle_one_xevent): Only set async_visible and friends
5959 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5960 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5961 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5962
dbf31225
PE
59632011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5964
5965 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5966 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5967 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5968 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5969 All uses changed to use GCPRO1 etc.
5970 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5971 Revert to old implementation (i.e., before 2011-03-11).
5972
1305621b
YM
59732011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5974
5975 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5976 of scroll runs so as to avoid assigning disabled bogus rows and
5977 unnecessary graphics copy operations.
5978
8c9afb46
EZ
59792011-11-27 Eli Zaretskii <eliz@gnu.org>
5980
5981 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5982 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5983 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5984 (malloc, free, realloc, calloc): Redirect to e_* only when
5985 compiling Emacs.
5986
5987 * lisp.h (GCTYPEBITS): Move before first use.
5988 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5989 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5990 this macro definition.
5991
5992 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5993 _MSC_VER.
5994
54e9e3bf
JD
59952011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5996
6d5eb5b0
SM
5997 * gtkutil.c (xg_create_frame_widgets):
5998 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5999 present with Gtk+ 2.0.
6000
83aca1cb
PE
60012011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6002
6003 * fileio.c (Finsert_file_contents): Undo previous change; see
6004 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6005
5b76caa4
PE
60062011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6007
6008 Rename locals to avoid shadowing.
6009 * fileio.c (Finsert_file_contents):
6010 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6011 * process.c (wait_reading_process_output):
6012 Rename inner 'proc' to 'p' to avoid shadowing.
6013 Indent for consistency with usual Emacs style.
6014
8c535114
EZ
60152011-11-25 Eli Zaretskii <eliz@gnu.org>
6016
6017 * xdisp.c (redisplay_window): If cursor row is not fully visible
6018 after recentering, and scroll-conservatively is set to a large
6019 number, scroll window by a few more lines to make the cursor fully
6020 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6021 (start_display): Don't move to the next line if the display should
6022 start at a newline that is part of a display vector or an overlay
6023 string. (Bug#10119)
8c535114 6024
fa4fdb5c
JL
60252011-11-24 Juri Linkov <juri@jurta.org>
6026
6027 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6028 after the `MagickPingImage' call. (Bug#10112)
6029
90ec88df
CY
60302011-11-23 Chong Yidong <cyd@gnu.org>
6031
6032 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6033
56e2e794
MR
60342011-11-23 Martin Rudalics <rudalics@gmx.at>
6035
6036 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6037 making another buffer current. (Bug#10114)
6038
b6e64c41
GM
60392011-11-23 Glenn Morris <rgm@gnu.org>
6040
6041 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6042
6b21de18
CY
60432011-11-23 Chong Yidong <cyd@gnu.org>
6044
6045 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6046 using it (Bug#5984).
6047
b12cd789
EZ
60482011-11-22 Eli Zaretskii <eliz@gnu.org>
6049
6050 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6051 and header-lines, as they don't have one computed for them.
6052 (Bug#10098)
6053
6054 * .gdbinit (prow): Make displayed values more self-explaining.
6055 Add row's hash code.
6056
261b6fd4
LMI
60572011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6058
6059 * process.c (wait_reading_process_output): Fix asynchrounous
6060 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6061 (wait_reading_process_output): Add comment and URL.
261b6fd4 6062
e7cfd277
JD
60632011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6064
6065 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6066
a9b9b7f5
CY
60672011-11-21 Chong Yidong <cyd@gnu.org>
6068
6069 * window.c (Fnext_window, Fprevious_window): Doc fix.
6070
b0d15b4f
SM
60712011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6072
6073 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6074
fe7a3057
JB
60752011-11-20 Juanma Barranquero <lekktu@gmail.com>
6076
6077 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6078
d2999b1a
MR
60792011-11-20 Martin Rudalics <rudalics@gmx.at>
6080
6081 * window.c (Fset_window_combination_limit): Rename argument
6082 STATUS to LIMIT.
6083 (Vwindow_combination_limit): Remove "status" from doc-string.
6084
d5ff9cd0
AS
60852011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6086
6087 * m/ibms390.h: Remove.
6088 * m/ibms390x.h: Don't include "ibms390.h".
6089
a5bb9bd3
SM
60902011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6091
6092 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6093 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6094
cd1181db
JB
60952011-11-20 Juanma Barranquero <lekktu@gmail.com>
6096
6097 * casetab.c (Fset_case_table):
6098 * charset.c (Fcharset_after): Fix typos.
6099
615a3b8d 61002011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6101
17e845af
PE
6102 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6103 Otherwise, valgrind does not work on some platforms.
6104 Problem reported by Andreas Schwab in
6a0bf43d
PE
6105 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6106 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6107 is set, removing the need for VIRT_ADDRESS_VARIES.
6108 (PURE_P): Use a more-efficient implementation that needs just one
6109 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6110 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6111 to 4 (xorl, subq, cmpq, setbe).
6112 * alloc.c (pure): Always extern now, since that's the
6113 VIRT_ADDR_VARIES behavior.
6114 (PURE_POINTER_P): Use a single comparison, not two, for
6115 consistency with the new puresize.h.
6116 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6117 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6118 Remove VIRT_ADDR_VARIES no longer needed.
6119
f8fe6f96
EZ
61202011-11-19 Eli Zaretskii <eliz@gnu.org>
6121
6122 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6123 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6124 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6125 behave as if the cursor position were at the window margin.
6126
6127 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6128 and the cursor position is out of bounds, behave as if the cursor
6129 position were at the window margin. (Bug#10075)
6130
df05a53c
CY
61312011-11-18 Chong Yidong <cyd@gnu.org>
6132
6133 * window.c (Fwindow_combination_limit): Make first argument
6134 non-optional, since it is meaningless for live windows like the
6135 selected window.
61ccba97 6136
2071918e
DA
61372011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6138
6139 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6140
b50a28de
SM
61412011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6142
6143 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6144 (graft_intervals_into_buffer): Simplify.
6145
015137db
EZ
61462011-11-18 Eli Zaretskii <eliz@gnu.org>
6147
6148 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6149 hash values of the two rows.
6150 (copy_row_except_pointers): Preserve the used[] arrays and the
6151 hash values of the two rows. (Bug#10035)
68c95424 6152 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6153
6154 * xdisp.c (row_hash): New function, body extracted from
6155 compute_line_metrics.
6156 (compute_line_metrics): Call row_hash, instead of computing the
6157 hash code inline.
6158
6159 * dispnew.c (verify_row_hash): Call row_hash for computing the
6160 hash code of a row, instead of duplicating code from xdisp.c.
6161
6162 * dispextern.h (row_hash): Add prototype.
6163
a2addb04
TH
61642011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6165
6166 * frame.c (delete_frame): Don't delete the terminal when the last
6167 X frame is closed if emacs is built with GTK toolkit.
6168
df85d315
JB
61692011-11-17 Juanma Barranquero <lekktu@gmail.com>
6170
6171 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6172
a0c2d0ae
MR
61732011-11-17 Martin Rudalics <rudalics@gmx.at>
6174
6175 * window.c (Vwindow_splits): Rename to
6176 Vwindow_combination_resize. Suggested by Juri Linkov.
6177 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6178 of Vwindow_splits.
6179
58179cce
JB
61802011-11-16 Juanma Barranquero <lekktu@gmail.com>
6181
7877f373
JB
6182 * nsfns.m (Fns_font_name):
6183 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6184
b6f67890
MR
61852011-11-16 Martin Rudalics <rudalics@gmx.at>
6186
6187 * window.h (window): Rename slot "nest" to "combination_limit".
6188 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6189 (Fset_window_nest): Rename to Fset_window_combination_limit.
6190 (Vwindow_nest): Rename to Vwindow_combination_limit.
6191 (recombine_windows, make_parent_window, make_window)
6192 (Fsplit_window_internal, saved_window)
6193 (Fset_window_configuration, save_window_save): Rename all
6194 occurrences of window_nest to window_combination_limit.
6195
c7015153
JB
61962011-11-15 Juanma Barranquero <lekktu@gmail.com>
6197
6198 * image.c (imagemagick_load_image): Fix typo.
6199
322ad6ec
EZ
62002011-11-14 Eli Zaretskii <eliz@gnu.org>
6201
6202 * xdisp.c (display_line): Move the call to
6203 highlight_trailing_whitespace before the call to
6204 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6205 faces of all the glyphs to compute ROW's hash value.
6206 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6207
f067b8ec
JB
62082011-11-14 Juanma Barranquero <lekktu@gmail.com>
6209
6210 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6211 just return (bug#10044).
6212
1e5b2111
EZ
62132011-11-12 Eli Zaretskii <eliz@gnu.org>
6214
7ef3cbd5
EZ
6215 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6216 with user-defined heap size. Bump the default size of the temacs
6217 heap to 27MB, to avoid memory warning when running temacs.
6218 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6219
1e5b2111
EZ
6220 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6221 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6222 (verify_row_hash) [XASSERTS]: New function.
6223 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6224 that the hash value of glyph rows is correct.
1e5b2111 6225
89d61221
MR
62262011-11-12 Martin Rudalics <rudalics@gmx.at>
6227
6228 * window.h (window): Remove splits slot.
6229 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6230 (Fdelete_other_windows_internal, make_parent_window)
6231 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6232 (Fset_window_configuration, save_window_save): Don't deal with
6233 split status of windows.
6234 (saved_window): Remove splits slot.
6235 (Vwindow_splits): Rewrite doc-string.
6236
97f18cc8
JD
62372011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6238
6239 * xfns.c (unwind_create_frame):
6240 * nsfns.m (unwind_create_frame):
6241 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6242 Vframe_list (Bug#9999).
6243
22a648b4
DA
62442011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6245
0b381c7e 6246 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6247
659afede
KH
62482011-11-11 Kenichi Handa <handa@m17n.org>
6249
6250 * callproc.c (Fcall_process): Set the member dst_multibyte of
6251 process_coding.
6252
9ac0394b
KH
62532011-11-11 Johan Bockgård <bojohan@gnu.org>
6254
6255 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6256 avoid a crash (bug#9496).
6257
2fbdc249
CY
62582011-11-09 Chong Yidong <cyd@gnu.org>
6259
6260 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6261 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6262
ac6b1f81
PE
62632011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6264
6265 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6266
09db192c
PE
62672011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6268
6269 Avoid some portability problems by eschewing 'extern inline' functions.
6270 The trivial performance wins aren't worth the portability hassles; see
6271 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6272 et seq.
6273 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6274 (window_box_width, window_box_left, window_box_left_offset)
6275 (window_box_right, window_box_right_offset): Undo previous change,
6276 by removing the "extern"s.
6277 * intervals.c (adjust_intervals_for_insertion)
6278 (adjust_intervals_for_deletion): Undo previous change,
6279 making these static again.
6280 (offset_intervals, temp_set_point_both, temp_set_point)
6281 (copy_intervals_to_string): No longer inline.
6282 * xdisp.c (window_text_bottom_y, window_box_width)
6283 (window_box_height, window_box_left_offset)
6284 (window_box_right_offset, window_box_left, window_box_right)
6285 (window_box): No longer inline.
6286
105216ed
CY
62872011-11-08 Chong Yidong <cyd@gnu.org>
6288
6289 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6290 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6291 Signal an error if not a live window.
105216ed
CY
6292 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6293 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6294
ae9e237f
JB
62952011-11-07 Juanma Barranquero <lekktu@gmail.com>
6296
6297 * lisp.h (syms_of_abbrev): Remove declaration.
6298 Reported by CHENG Gao <chenggao@royau.me>.
6299
c7aa8333
EZ
63002011-11-07 Eli Zaretskii <eliz@gnu.org>
6301
6302 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6303 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6304 of temacs in GUI mode.
6305
be7f5545
MR
63062011-11-07 Martin Rudalics <rudalics@gmx.at>
6307
6308 * window.h: Declare delete_all_child_windows instead of
6309 delete_all_subwindows.
6310 * window.c (Fwindow_nest, Fset_window_nest)
6311 (Fset_window_new_total, Fset_window_new_normal)
6312 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6313 (delete_all_subwindows): Rename to delete_all_child_windows.
6314 (Fdelete_other_windows_internal, Fset_window_configuration):
6315 Call delete_all_child_windows instead of delete_all_subwindows.
6316 * frame.c (delete_frame): Call delete_all_child_windows instead
6317 of delete_all_subwindows.
6318
ca78dc43
PE
63192011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6320
6321 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6322 This is also needed for porting to any host where GC_MARK_STACK is
6323 not GC_MAKE_GCPROS_NOOPS.
6324 (which_symbols): Use it.
6325
a0241d01
KH
63262011-11-07 Kenichi Handa <handa@m17n.org>
6327
6328 * coding.c (coding_set_destination): Check coding->src_pos only
6329 when coding->src_object is a buffer (bug#9910).
6330
6331 * process.c (send_process): Set the member src_multibyte of coding
6332 to 0 (bug#9911) when sending a unibyte text.
6333
6334 * callproc.c (Fcall_process): Set the member src_multibyte of
6335 process_coding to 0 (bug#9912).
6336
a64bfdfa 63372011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6338
6339 * xmenu.c (cleanup_widget_value_tree): New function.
6340 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6341 calling free_menubar_widget_value_tree directly (Bug#9830).
6342
cb41b32a
PE
63432011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6344
6345 Fix some portability problems with 'inline'.
6346 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6347 (window_box_width, window_box_left, window_box_left_offset)
6348 (window_box_right, window_box_right_offset): Declare extern.
6349 Otherwise, these inline functions do not conform to C99 and
6350 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6351 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6352 * intervals.c (adjust_intervals_for_insertion)
6353 (adjust_intervals_for_deletion): Now extern, because otherwise the
6354 extern inline functions 'offset_intervals' couldn't refer to it.
6355 (static_offset_intervals): Remove.
6356 (offset_intervals): Rewrite using the old contents of
6357 static_offset_intervals. The old version didn't conform to C99
6358 because an extern inline function contained a reference to an
6359 identifier with static linkage.
6360
b7041366
AS
63612011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6362
6363 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6364 GC.
6365
88a37c4d
EZ
63662011-11-06 Eli Zaretskii <eliz@gnu.org>
6367
6368 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6369 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6370 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6371 return Qleft_to_right.
6372
49745b39
CY
63732011-11-06 Chong Yidong <cyd@gnu.org>
6374
6375 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6376 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6377 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6378 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6379 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6380 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6381 (Fwindow_vscroll): Doc fix.
6382 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6383 argument, since it makes no sense to pass a live window and for
6384 consistency with window-child.
6385
1f05cd82
CS
63862011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6387
6388 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6389 support MSVC.
6390
22610910
JR
63912011-11-05 Jason Rumney <jasonr@gnu.org>
6392
6393 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6394 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6395 fonts (Bug#6029).
6396 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6397 bitwise arithmetic preventing use of unicode-sip and non-truetype
6398 opentype fonts.
6399
a06776b2
EZ
64002011-11-05 Eli Zaretskii <eliz@gnu.org>
6401
3ad924ba
EZ
6402 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6403 "emacs"-only part.
6404
a06776b2
EZ
6405 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6406 initialization code to keep similarity to xfns.c after changes
6407 from 2011-11-05.
6408
c9e7db78
JD
64092011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6410
a97f8f3f
JD
6411 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6412 (unwind_create_frame): New function (Bug#9943).
6413 (Fx_create_frame): Restructure code to be more similar to the one in
6414 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6415 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6416 Move terminal->reference_count++ just before making the frame official
6417 (Bug#9943).
6418
6419 * nsterm.m (x_free_frame_resources): New function.
6420 (x_destroy_window): Move code to x_free_frame_resources.
6421
c9e7db78 6422 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6423 (Fx_create_frame, x_create_tip_frame):
6424 Move terminal->reference_count++ just before making the frame
75f1671a 6425 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6426 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6427
a6fc3b5c
EZ
64282011-11-05 Eli Zaretskii <eliz@gnu.org>
6429
6430 Support MSVC build with newer versions of Visual Studio.
6431 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6432 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6433 nt/gmake.defs.
6434
6435 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6436 which are not supported by MSVC.
6437 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6438 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6439 bitfields.
6440 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6441 types in bitfields.
6442 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6443
6444 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6445
58179cce 64462011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6447
6448 Support MSVC build with newer versions of Visual Studio.
6449 * w32.c: Don't include w32api.h for MSVC.
6450 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6451
6452 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6453 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6454 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6455 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6456 e_* cousins.
6457 (alloca) [_MSC_VER]: Define to _alloca.
6458
6459 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6460
6461 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6462
a58c13ed
EZ
64632011-11-04 Eli Zaretskii <eliz@gnu.org>
6464
6465 * xdisp.c (note_mouse_highlight): If either of
6466 previous/next-single-property-change returns nil, treat that as
6467 the beginning or the end of the buffer. (Bug#9955)
6468
fe0b6370
JD
64692011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6470
a58c13ed 6471 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6472 label is not null (Bug#9951).
6473 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6474 may be NULL.
6475
89bd5ee1
EZ
64762011-11-04 Eli Zaretskii <eliz@gnu.org>
6477
6478 * window.c (Fwindow_body_size): Mention in the doc string that the
6479 return value is in frame's canonical units. (Bug#9949)
6480
84c3edb9
EZ
64812011-11-03 Eli Zaretskii <eliz@gnu.org>
6482
4e2fb5c7
EZ
6483 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6484
84c3edb9 6485 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6486 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6487 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6488
bc17a887
EZ
64892011-11-01 Eli Zaretskii <eliz@gnu.org>
6490
6491 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6492 Don't stop backward scan on the continuation glyph, even though
6493 its CHARPOS is positive.
6d5eb5b0
SM
6494 (mouse_face_from_buffer_pos, note_mouse_highlight):
6495 Rename cover_string to disp_string.
bc17a887 6496
4ee88440
MR
64972011-11-01 Martin Rudalics <rudalics@gmx.at>
6498
6499 * window.c (temp_output_buffer_show): Don't use
6500 Vtemp_buffer_show_specifiers.
6501 (Vtemp_buffer_show_specifiers): Remove unused variable.
6502
c2ff3c02
EZ
65032011-10-30 Eli Zaretskii <eliz@gnu.org>
6504
6505 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6506 past the beginning of the current glyph matrix.
6507
58179cce 65082011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6509
6510 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6511 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6512 HAVE_GTK3 (Bug#9869).
b77a6a7f 6513
3b574623
JD
6514 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6515 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6516
b77a6a7f
JD
6517 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6518
6519 * xterm.c: Declare x_handle_net_wm_state to return int.
6520 (handle_one_xevent): Check if we are iconified but don't have
6521 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6522 (get_current_wm_state): Return non-zero if not hidden,
6523 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6524 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6525 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6526 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6527
196e41e4
PE
65282011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6529
6530 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6531 so that this new function doesn't get optimized away by a
6532 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6533
021f2e1a
AS
65342011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6535
6536 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6537
8b058d44
EZ
65382011-10-29 Eli Zaretskii <eliz@gnu.org>
6539
6540 Fix the `xbytecode' command.
6541 * .gdbinit (xprintbytestr): New command.
b50a28de 6542 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6543 (xbytecode): Print the byte-code string as well.
6544
4452fb80
EZ
65452011-10-29 Kim Storm <storm@cua.dk>
6546
8b058d44
EZ
6547 * alloc.c (which_symbols): New function.
6548
21b72067
AS
65492011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6550
6551 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6552 line. (Bug#9903)
6553
83ed7b5c
GM
65542011-10-29 Glenn Morris <rgm@gnu.org>
6555
6556 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6557 Not clear what it was for, and it causes various bugs. (Bug#9839)
6558
5a7a728b
EZ
65592011-10-28 Eli Zaretskii <eliz@gnu.org>
6560
6561 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6562 possible random value that matches one of those tested as
6563 condition to clear the mouse face.
6564
d3d0842f
CY
65652011-10-28 Chong Yidong <cyd@gnu.org>
6566
6567 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6568
31b39d13
DN
65692011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6570
6571 * window.c (make_window): Initialize phys_cursor_on_p.
6572
9aba6043
SM
65732011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6574
6575 * lisp.h (struct Lisp_Symbol): Update comments.
6576
c20992f4
JB
65772011-10-28 Juanma Barranquero <lekktu@gmail.com>
6578
6579 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6580
db4f02f2
EZ
65812011-10-28 Eli Zaretskii <eliz@gnu.org>
6582
6583 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6584 <oslsachem@gmail.com> for helping to debug this.
6585
6586 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6587 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6588 (g_b_init_get_glyph_outline_w): New static variables.
6589 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6590 (GetGlyphOutlineW_Proc): New typedefs.
6591 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6592 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6593 New functions.
6594 (w32font_open_internal, compute_metrics):
6595 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6596 instead of calling the "wide" APIs directly.
6597
6598 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6599
6600 * w32.h (syms_of_w32font): Add prototype.
6601
87e68db4
JB
66022011-10-27 Juanma Barranquero <lekktu@gmail.com>
6603
6604 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6605 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6606 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6607 (Fmove_to_window_line): Doc fix.
6608
435c1d67
CY
66092011-10-27 Chong Yidong <cyd@gnu.org>
6610
6611 * process.c (make_process): Set gnutls_state to NULL.
6612
6613 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6614 non-NULL, regardless of GNUTLS_INITSTAGE.
6615 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6616 an error. Set process slots as soon as we allocate them.
6617
6618 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6619
9c6c6f49
CY
66202011-10-27 Chong Yidong <cyd@gnu.org>
6621
9aba6043
SM
6622 * gnutls.c (emacs_gnutls_deinit): New function.
6623 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6624 (Fgnutls_deinit, Fgnutls_boot): Use it.
6625
6626 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6627 (deactivate_process): Call emacs_gnutls_deinit.
6628
657d08d3
JB
66292011-10-27 Juanma Barranquero <lekktu@gmail.com>
6630
6631 * image.c (x_create_x_image_and_pixmap):
6632 * w32.c (sys_rename, w32_delayed_load):
6633 * w32font.c (fill_in_logfont):
6634 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6635
5430d399
JB
66362011-10-26 Juanma Barranquero <lekktu@gmail.com>
6637
6638 * w32fns.c (w32_default_color_map): New function,
6639 extracted from Fw32_default_color_map.
a7ef684b 6640 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6641
fe0055fa
PE
66422011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6643
6644 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6645
e6346438
SM
66462011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6647
6648 * keyboard.c (test_undefined): New function (bug#9751).
6649 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6650
e112cc37
ET
66512011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6652
6653 * sysdep.c (init_sys_modes): Fix the check for the controlling
6654 terminal (Bug#6649).
6655
7b5d6677
EZ
66562011-10-20 Eli Zaretskii <eliz@gnu.org>
6657
6658 * dispextern.h (struct bidi_it): New member next_en_type.
6659
6660 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6661 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6662 current character, check also for next_en_type being WEAK_EN.
6663 (bidi_resolve_weak): Don't enter the expensive loop if the current
6664 position is before next_en_pos. Record the bidi type of the first
6665 non-ET, non-BN character we find, in addition to its position.
6666 (bidi_level_of_next_char): Invalidate next_en_type when
6667 next_en_pos is over-stepped.
6668
7da0b018
PE
66692011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6670
6671 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6672 * editfns.c: Rewrite current-time-zone so that it invokes
6673 the equivalent of (format-time-string "%Z") to get the time zone name.
6674 This fixes a bug when the time zone name contains characters that
6675 need converting from the system time locale to Emacs internal format.
6676 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6677 that patch fixed format-time-string to do the conversion, but
6678 I forgot to fix current-time-zone.
6679 (format_time_string): New function, containing most of
6680 what Fformat_time_string used to contain.
6681 (Fformat_time_string): Rewrite in terms of format_time_string.
6682 This doesn't change this function's behavior.
6683 (current-time-zone): Rewrite to use format_time_string.
6684 This fixes the bug reported by Michael Schierl in
6685 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6686 Jason Rumney's 2007-06-07 change worked around this bug, but
6687 didn't fix it.
6688 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6689
8547b010
EZ
66902011-10-19 Eli Zaretskii <eliz@gnu.org>
6691
6692 * xdisp.c (start_display): If the character at POS is displayed
6693 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6694 (try_window_reusing_current_matrix): If a line ends in a display
6695 vector or the next line starts in a display vector, continue
6696 redrawing the window even though the character position of
6697 start_row was reached.
8547b010
EZ
6698 (Bug#9771, part 2)
6699
4e948d15
CY
67002011-10-18 Chong Yidong <cyd@gnu.org>
6701
6702 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6703 with nobreak-char-display too.
6704
4787455f
EZ
67052011-10-18 Eli Zaretskii <eliz@gnu.org>
6706
6707 Fix part 3 of bug#9771.
6708 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6709 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6710 non-neutral characters if the current character is a paragraph
6711 separator (a.k.a. Newline). This avoids running the same
6712 expensive loop twice, once when we consume the preceding newline
6713 and the other time when the line actually needs to be displayed.
6714 Avoid the loop when we see neutrals on the base embedding level
6715 following a character whose directionality is the same as the
6716 paragraph's. This avoids running the expensive loop when a line
6717 ends in a long sequence of neutrals, like control characters.
6718 Add assertion against STRONG_AL type. Slightly rearrange code
6719 that determines the type of a neutral given the first non-neutral
6720 that follows it.
6721 (bidi_level_of_next_char): Set next_en_pos to zero when
6722 invalidating its info.
6723
2c91f553
EZ
67242011-10-17 Eli Zaretskii <eliz@gnu.org>
6725
6726 * xdisp.c (push_display_prop): Determine whether to record string
6727 or buffer position by IT->string, not by IT->method. Allow
6728 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6729 (move_it_vertically_backward): Don't look for character position
6730 immediately after the newline when in a continuation line.
6731 (Bug#9771, part 1)
2c91f553 6732
c7b08b0d
MR
67332011-10-15 Martin Rudalics <rudalics@gmx.at>
6734
6735 * window.c (coordinates_in_window): Rewrite and delabelize
6736 vertical border check. (Bug#5357) (Bug#9618)
6737
6b02f655
SM
67382011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6739
6740 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6741 errors in XSetWindowBorder (bug#9310).
6742
81d40c92
DA
67432011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6744
6745 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6746 avoid crash when xmalloc overrun checking is enabled.
6747
d4172c3b
EZ
67482011-10-13 Eli Zaretskii <eliz@gnu.org>
6749
6750 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6751 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6752 cursor motion with <left> and <right> arrow keys.
6753
6754 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6755 some callers set that themselves.
6756
b00eea75
EZ
67572011-10-12 Eli Zaretskii <eliz@gnu.org>
6758
6759 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6760 display string and the previous row comes from the same string and
6761 is empty. (Bug#9739) (Bug#9738)
6762
8fe012c4
SM
67632011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6764
6765 * doc.c (get_doc_string): Encode file name (bug#9735).
6766
0074aef2
EZ
67672011-10-12 Eli Zaretskii <eliz@gnu.org>
6768
79beb178
EZ
6769 * bidi.c (bidi_level_of_next_char):
6770 * xdisp.c (get_visually_first_element): Remove old incorrect
6771 comments regarding the Unicode Line Separator character.
6772
0074aef2
EZ
6773 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6774
6e4b3fbe
DA
67752011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6776
6777 * alloc.c (Fgc_status): Do not access beyond zombies array
6778 boundary if nzombies > MAX_ZOMBIES.
6779 * alloc.c (dump_zombies): Add missing format specifier.
6780
0324f3af
PE
67812011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6782
b5525cac
PE
6783 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6784 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6785
0324f3af
PE
6786 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6787 Some packages use them to denote characters with modifiers.
6788
e9b5f888
AS
67892011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6790
6791 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6792 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6793 matching a pp-number. Rename parameter var to var1.
6794
127827c0
SM
67952011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6796
6797 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6798
c8fd3bd0
GM
67992011-10-08 Glenn Morris <rgm@gnu.org>
6800
6801 * callint.c (Fcall_interactively): Give a more explicit error for the
6802 'c' case with a non-character input. (Bug#8479)
6803
352ec8ff
EZ
68042011-10-08 Eli Zaretskii <eliz@gnu.org>
6805
03669ccb
EZ
6806 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6807 lines.
7061c986
EZ
6808 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6809 lines that are hscrolled on the left.
03669ccb 6810
352ec8ff
EZ
6811 * dispnew.c (buffer_posn_from_coords): Account for a possible
6812 presence of header-line. (Bug#4426)
6813
a66cfb1c
SM
68142011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6815
6b02f655
SM
6816 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6817 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6818
7c5ee88e
PE
68192011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6820
6821 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6822 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6823 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6824 this makes Emacs dump core during garbage collection on rare
6825 occasions. sizeof is obviously inferior to offsetof here, so
6826 stick with offsetof.
6827 (GC_POINTER_ALIGNMENT): New macro.
6828 (mark_memory): Omit 3rd (offset) arg; caller changed.
6829 Don't assume EMACS_INT alignment is the same as pointer alignment.
6830
df1bbe5b
SM
68312011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6832
6833 * keyboard.c (read_key_sequence_remapped): New var.
6834 (read_key_sequence): Compute remapping in the right buffer.
6835 (command_loop_1): Use read_key_sequence's remapping directly.
6836
51553db6
SM
68372011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6838
32c1fffd
SM
6839 * dired.c (file_name_completion): Don't expand file name.
6840 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6841 before checking file name handler.
6842
51553db6
SM
6843 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6844 they've been requested explicitly (bug#9591).
6845
b6bd1599 68462011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6847
6848 * keymap.c (Fsingle_key_description): Use make_specified_string
6849 instead of build_string to build string from push_key_description.
6850 (Bug#5193)
6851
f701dc2a
PE
68522011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6853
4222c55d
PE
6854 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6855 This fixes a Y2038 bug on 64-bit hosts.
6856 * buffer.c (reset_buffer):
6857 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6858 (Fclear_buffer_auto_save_failure):
6859 Use 0, not -1, to represent an unset failure time, since time_t
6860 might not be signed.
6861
f701dc2a
PE
6862 Remove dependency on glibc malloc internals.
6863 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6864 Move back here from lisp.h, but with their new implementations.
6865 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6866 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6867 * charset.c (charset_table_init): New static var.
6868 (syms_of_charset): Use it instead of xmalloc. This removes a
6869 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6870 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6871 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6872 Move back to alloc.c.
6873 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6874 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6875
9ceebf39
JD
68762011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6877
6878 * nsterm.m (windowDidResize): Call x_set_window_size only when
6879 ns_in_resize is true. Otherwise set pixelwidth/height and
6880 call change_frame_size (Bug#9628).
6881
cb993c58
PE
68822011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6883
3930c88b
PE
6884 Port --enable-checking=all to Fedora 14 x86-64.
6885 * charset.c (syms_of_charset): Also account for glibc malloc's
6886 internal overhead when calculating the initial malloc maximum.
6887
cb993c58
PE
6888 Port --enable-checking=all to Fedora 14 x86.
6889 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6890 Move to lisp.h.
6891 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6892 (overrun_check_realloc, overrun_check_free):
6893 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6894 That way, xmalloc returns a properly-aligned pointer even if
6895 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6896 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6897 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6898 into account when calculating the initial malloc maximum.
6899 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6900 Move here from alloc.c, so that charset.c can use it too.
6901 Properly align; the old code wasn't right for common 32-bit hosts
6902 when configured with --enable-checking=all.
6903 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6904 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6905
31bed486
EZ
69062011-09-29 Eli Zaretskii <eliz@gnu.org>
6907
04c70788 6908 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6909 use EDOM.
6910
fbcaa2f3
EZ
69112011-09-28 Eli Zaretskii <eliz@gnu.org>
6912
6913 * xdisp.c (compute_display_string_end): If there's no display
6914 string at CHARPOS, return -1.
6915
6916 * bidi.c (bidi_fetch_char): When compute_display_string_end
6917 returns a negative value, treat the character as a normal
6918 character not covered by a display string. (Bug#9624)
6919
a239d4e9
JB
69202011-09-28 Juanma Barranquero <lekktu@gmail.com>
6921
6922 * lread.c (Fread_from_string): Fix typo in docstring.
6923
88652fd5
EZ
69242011-09-27 Eli Zaretskii <eliz@gnu.org>
6925
6926 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6927 newline, reseat the iterator instead of bidi-iterating there one
6928 character at a time. (Bug#9610)
32c1fffd
SM
6929 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6930 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6931
ed497dd4
AS
69322011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6933
6934 * lread.c (readevalloop): Use correct code for NBSP.
6935 (read1): Likewise. (Bug#9608)
6936
b2bf61aa
MA
69372011-09-25 Michael Albinus <michael.albinus@gmx.de>
6938
6939 * dbusbind.c (Fdbus_register_signal): When service is not
6940 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6941
32bbb17c
GM
69422011-09-25 Glenn Morris <rgm@gnu.org>
6943
6944 * buffer.c (truncate-lines): Doc fix.
6945
94e0933e
CY
69462011-09-24 Chong Yidong <cyd@stupidchicken.com>
6947
6948 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6949 (Fset_window_next_buffers): Doc fix.
6950
cddde921
GM
69512011-09-24 Glenn Morris <rgm@gnu.org>
6952
6953 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6954
1260aef1
PE
69552011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6956
25b4bfa0
PE
6957 Fix minor problems found by static checking.
6958 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6959 * indent.c (Fvertical_motion): Fix == vs = typo.
6960
e3cbd34b
EZ
69612011-09-24 Eli Zaretskii <eliz@gnu.org>
6962
a66cfb1c
SM
6963 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6964 Default value is now t. Doc fix.
6bf7006f 6965
e3cbd34b 6966 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6967 logic when moving up, not only when moving down. Fix the
e3cbd34b 6968 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6969 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6970
6971 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6972 CHARPOS is covered by a display string which includes newlines.
6973 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6974 is covered by a display string with embedded newlines.
6975
a3de0cbd
MA
69762011-09-24 Michael Albinus <michael.albinus@gmx.de>
6977
6978 * dbusbind.c (Fdbus_register_signal): Add match rule to
6979 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6980 (Fdbus_register_method, Vdbus_registered_objects_table):
6981 Fix docstring.
a3de0cbd 6982
b260039d
JM
69832011-09-24 Jim Meyering <meyering@redhat.com>
6984
32c1fffd 6985 do not ignore write error for any output size
b260039d
JM
6986 The previous change was incomplete.
6987 While it makes emacs --batch detect the vast majority of stdout
6988 write failures, errors were still ignored whenever the output size is
6989 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6990 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6991 && echo FAIL: ignored write error
6992 FAIL: ignored write error
6993 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6994 && echo FAIL: ignored write error
6995 FAIL: ignored write error
6996 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6997
8eca8a7c
AS
69982011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6999
7000 * emacs.c (Fkill_emacs): In noninteractive mode exit
7001 non-successfully if a write error occurred on stdout. (Bug#9574)
7002
3341db62
EZ
70032011-09-21 Eli Zaretskii <eliz@gnu.org>
7004
7005 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7006 the xassert test.
7007
7008 * dispextern.h (struct it): Update the comment documenting what
7009 can it->OBJECT be.
7010
8c203dbf
EZ
70112011-09-20 Eli Zaretskii <eliz@gnu.org>
7012
7013 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7014 a display string, extend search for cursor position to end of row.
7015 (find_row_edges): If the row ends in a newline from a display
7016 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7017 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7018 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7019 non-empty line. Fixes confusing cursor motion with arrow keys at
7020 the beginning of a line that starts with whitespace.
8c203dbf 7021
a4824228
LMI
70222011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7023
7024 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7025 (bug#9493).
7026
33ed493b
CY
70272011-09-18 Chong Yidong <cyd@stupidchicken.com>
7028
7029 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7030 boolean (Bug#9154).
7031
56cd55c8
EZ
70322011-09-18 Eli Zaretskii <eliz@gnu.org>
7033
7034 * xdisp.c (display_line): Record maximum and minimum buffer
7035 positions even if no glyphs were produced (e.g., by a zero-width
7036 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7037 buffer positions that will be removed from the glyph row because
7038 they don't fit.
c02dcedf
EZ
7039 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7040 column is beyond frame width: don't subtract 1 "pixel" when
7041 computing width of the stretch.
3e62b7e0
EZ
7042 (reseat_at_next_visible_line_start): Undo the change made on
7043 2011-09-17 that saved paragraph information and restored it after
7044 the call to `reseat'. (Bug#9545)
56cd55c8 7045
5ed99d36 70462011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7047
7048 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7049 and turn window cursor on if cleared (Bug#9415).
7050
5ed99d36 70512011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7052
7053 * search.c (boyer_moore): Take unibyte characters from pattern
7054 literally. (Bug#9458)
7055
9bade7b2
EZ
70562011-09-18 Eli Zaretskii <eliz@gnu.org>
7057
7058 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7059
e5e9d610
PE
70602011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7061
87e4427a
PE
7062 Fix minor problem found by static checking.
7063 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7064 initialized, to pacify gcc -Wuninitialized.
7065
e5e9d610
PE
7066 * fileio.c: Report proper errno when syscall falls.
7067 (Finsert_file_contents): Save and restore errno,
7068 so that report_file_error outputs the correct diagnostic.
7069 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7070
a1674f0b
EZ
70712011-09-18 Eli Zaretskii <eliz@gnu.org>
7072
7073 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7074
fbfb6dd4
EZ
70752011-09-17 Eli Zaretskii <eliz@gnu.org>
7076
7077 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7078 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7079
bb187662
EZ
70802011-09-17 Eli Zaretskii <eliz@gnu.org>
7081
1137e8b8 7082 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7083 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7084
7085 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7086 (bidi_find_paragraph_start): Search back for paragraph beginning
7087 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7088 (bidi_move_to_visually_next): Only trigger paragraph-related
7089 computations when the last character is a newline or at EOB, not
7090 just any NEUTRAL_B. (Bug#9470)
7091
bb187662
EZ
7092 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7093 truncated lines if point is covered by a display string. (Bug#9524)
7094
2e621251
PE
70952011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7096
7097 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7098 (cons_to_x_long): New function.
7099 (lisp_data_to_selection_data): Use it. Correct the test for
7100 short-versus-long data; it was negated. Break out of vector
7101 loop, for efficiency, when a long datum is discovered.
7102
91a15bc6
SM
71032011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7104
7105 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7106
b41c3a35
EZ
71072011-09-16 Eli Zaretskii <eliz@gnu.org>
7108
7109 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7110 GCC PR/17406) by declaring this function with external scope.
7111
7812ba2d
PE
71122011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7113
7114 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7115 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7116
cf7edc2a
AS
71172011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7118
7119 * editfns.c (Fformat): Correctly handle text properties on "%%".
7120
bd01620e
EZ
71212011-09-15 Eli Zaretskii <eliz@gnu.org>
7122
7123 * xterm.c (x_draw_composite_glyph_string_foreground):
7124 * w32term.c (x_draw_composite_glyph_string_foreground):
7125 * term.c (encode_terminal_code):
7126 * composite.c (composition_update_it, get_composition_id):
7127 * xdisp.c (get_next_display_element)
7128 (fill_composite_glyph_string): Add comments about special meaning
7129 of TAB characters in a composition.
7130
a02719a3
PE
71312011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7132
7133 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7134 This occurs when processing a multibyte format.
7135 Problem reported by Wolfgang Jenker.
a02719a3 7136
72589a3c
JB
71372011-09-15 Johan Bockgård <bojohan@gnu.org>
7138
7139 * xdisp.c (try_cursor_movement): Only check for exact match if
7140 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7141
1c14176c
PE
71422011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7143
7144 Remove unused external symbols.
7145 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7146 * xdisp.c (calc_pixel_width_or_height): Now static.
7147 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7148 * indent.c (check_display_width):
7149 * w32term.c: Fix comment to match code.
7150 * xterm.c, xterm.h (x_catching_errors): Remove.
7151
d2eea5b5
PE
71522011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7153
7154 * xselect.c: Use signed conversions more consistently (Bug#9498).
7155 (selection_data_to_lisp_data): Assume incoming selection data are
7156 signed integers, not unsigned. This is to be consistent with
7157 outgoing selection data, which was modified to use signed integers
7158 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7159 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7160 expects long, not unsigned long.
7161
46888499
EZ
71622011-09-14 Eli Zaretskii <eliz@gnu.org>
7163
7164 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7165 computation of loop end. Reported by Johan Bockgård
7166 <bojohan@gnu.org>.
7167
ef8ef9fb
CY
71682011-09-13 Chong Yidong <cyd@stupidchicken.com>
7169
7170 * frame.c (Fother_visible_frames_p): Function deleted.
7171
fa819fed
EZ
71722011-09-12 Eli Zaretskii <eliz@gnu.org>
7173
7174 * indent.c (compute_motion): Process display vector front to back
7175 rather than the other way around. (Bug#2496)
7176
2ba8e008
SM
71772011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7178
7179 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7180
20f53c69
CY
71812011-09-11 Chong Yidong <cyd@stupidchicken.com>
7182
7183 * minibuf.c (Fread_from_minibuffer): Doc fix.
7184
d562d7a4
EZ
71852011-09-11 Eli Zaretskii <eliz@gnu.org>
7186
7187 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7188 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7189
1c4d7f3d
LMI
71902011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7191
7192 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7193 value for non-existent files.
7194
b885bf36
EZ
71952011-09-11 Eli Zaretskii <eliz@gnu.org>
7196
7197 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7198 set its "size" to -1. This will set the modtime_size field of
7199 the corresponding buffer to -1, which is what
7200 verify-visited-file-modtime expects for files that do not exist.
7201 (Bug#9139)
7202
6612f0bf
PE
72032011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7204
7205 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7206 here ...
7207 * lisp.h: ... from here. push_key_description is no longer
7208 defined in keyboard.c, so its declaration should not be in
7209 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7210 logically belongs with push_key_description.
7211
dfb3f755
PE
72122011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7213
7214 * buffer.h: Include <sys/types.h> instead of <time.h>.
7215 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7216 Problem reported by Herbert J. Skuhra.
7217
3134906c
LMI
72182011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7219
7220 * xml.c (parse_region): Make the parsing work for
7221 non-comment-starting XML files again (bug#9144).
7222
8d903f4e
AS
72232011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7224
7225 * image.c (gif_load): Fix calculation of bottom and right corner.
7226 (Bug#9468)
7227
80ad64f4
EZ
72282011-09-10 Eli Zaretskii <eliz@gnu.org>
7229
7230 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7231 redisplay in small windows.
7232
208a048d
EZ
72332011-09-09 Eli Zaretskii <eliz@gnu.org>
7234
7235 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7236
9b1c252e
MR
72372011-09-08 Martin Rudalics <rudalics@gmx.at>
7238
7239 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7240 Operate on live windows only.
7241
2949f33b
JB
72422011-09-08 Juanma Barranquero <lekktu@gmail.com>
7243
7244 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7245
e08dcafd
EZ
72462011-09-07 Eli Zaretskii <eliz@gnu.org>
7247
7248 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7249 only under bidi iteration.
7250
115b96bd
JD
72512011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7252
7253 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7254
c8199d0f
PE
72552011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7256
7257 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7258 Without this fix, the command to link temacs failed due to an
7259 undefined symbol __builtin_isnan. This is because
7260 /usr/include/iso/math_c99.h #defines isnan(x) to
7261 __builtin_isnan(x), but the bundled gcc, which identifies itself
7262 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7263 a __builtin_isnan.
7264 * floatfns.c (isnan): #undef, and then #define to a clone of
7265 what's in data.c.
7266 (Fisnan): Always define, since it's always available now.
7267 (syms_of_floatfns): Always define isnan at the Lisp level.
7268
e39b275c 72692011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7270
7271 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7272
b2db44d9 72732011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7274
f4af5137 7275 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7276 The previous code assumed that file offsets (off_t values) fit in
7277 EMACS_INT variables, which is not true on typical 32-bit hosts.
7278 The code messed up by falsely reporting buffer overflow in cases
7279 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7280 when "big" contains more than 2**29 bytes, even though this
7281 inserts just one byte and does not overflow the buffer.
7282 (Finsert_file_contents): Store file offsets as off_t
7283 values, not as EMACS_INT values. Check for overflow when
7284 converting between EMACS_INT and off_t. When checking for
7285 buffer overflow or for overlap, take the offsets into account.
7286 Don't use EMACS_INT for small values where int suffices.
7287 When checking for overlap, fix a typo: ZV was used where
7288 ZV_BYTE was intended.
7289 (Fwrite_region): Don't assume off_t fits into 'long'.
7290 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7291
ecfc0a49
MA
72922011-09-05 Michael Albinus <michael.albinus@gmx.de>
7293
7294 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7295
6511acf2 72962011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7297
0999621a 7298 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7299
7300 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7301 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7302 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7303 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7304 (modify_event_symbol): Do not assume that the length of
7305 name_alist_or_stem is safe to alloca and fits in int.
7306 (Fexecute_extended_command): Likewise for function name and binding.
7307 (Frecursion_depth): Wrap around reliably on integer overflow.
7308 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7309 since some callers pass EMACS_INT values.
7310 (Fsingle_key_description): Don't crash if symbol name contains more
7311 than MAX_ALLOCA bytes.
7312 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7313 (get_minibuffer): Arg is now EMACS_INT, not int.
7314 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7315 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7316 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7317
2be7d702
PE
7318 * dbusbind.c (signature_cat): New function.
7319 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7320 Do not overrun buffer; instead, report string overflow.
7321
9d1df220
PE
7322 * dispnew.c (add_window_display_history): Don't overrun buffer.
7323 Truncate instead; this is OK since it's just a log.
7324
33ef5c64
PE
7325 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7326 even if the time zone offset is outlandishly large.
7327 Don't mishandle offset == INT_MIN.
7328
66c6fdd5
PE
7329 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7330 when creating daemon; the previous buffer-overflow check was incorrect.
7331
d749b01b
PE
7332 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7333 which has the guts of the old verror function.
7334
b5cd1905
PE
7335 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7336 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7337
6e1a67fb
PE
7338 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7339 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7340 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7341 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7342 length of string rather than counting it via multiple sprintfs;
7343 that's simpler and more reliable.
c21721cc
PE
7344 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7345 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7346 sprintf, in case result does not fit in int.
7347
c57b67fc
PE
7348 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7349 (fontset_from_font): Print it.
7350
8a401434
PE
7351 * frame.c (tty_frame_count): Now printmax_t, not int.
7352 (make_terminal_frame, set_term_frame_name): Print it.
7353 (x_report_frame_params): In X, window IDs are unsigned long,
7354 not signed long, so print them as unsigned.
7355 (validate_x_resource_name): Check for implausibly long names,
7356 and don't assume name length fits in 'int'.
7357 (x_get_resource_string): Don't blindly alloca invocation name;
7358 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7359 not fit in int.
7360
6e1a67fb
PE
7361 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7362 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7363 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7364
0df02bf3
PE
7365 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7366 Use esprintf, not sprintf, in case result does not fit in int.
7367
48e30793
PE
7368 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7369 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7370 it as a large positive number.
7371 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7372 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7373
a66ff6d8
PE
7374 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7375 in case result does not fit in int.
7376
aca216ff
PE
7377 * print.c (float_to_string): Detect width overflow more reliably.
7378 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7379 buffer overrun. Don't assume list length fits in 'int'. Treat
7380 print length of 0 as 0, not as infinity; to be consistent with other
7381 uses of print length in this function. Don't overflow print length
7382 index. Don't assume hash table size fits in 'long', or that
7383 vectorlike size fits in 'unsigned long'.
7384
31c286f7
PE
7385 * process.c (make_process): Use printmax_t, not int, to format
7386 process-name gensyms.
7387
55e5faa1
PE
7388 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7389
80f2e268
PE
7390 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7391 to avoid potential buffer overrun.
7392
670741ab
PE
7393 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7394 if X resource line is longer than 512 bytes.
7395
b7163a50
PE
7396 * xfns.c (x_window): Make sprintf buffer a bit bigger
7397 to avoid potential buffer overrun.
7398
ae58ff1f
PE
7399 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7400
c43c8a6a
PE
7401 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7402
3f8236f4
PE
74032011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7404
53e9fe90 7405 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7406 Without these, Emacs silently mishandles large integers sometimes.
7407 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7408 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7409
6511acf2
PE
7410 * xdisp.c (try_window_id): Check Emacs fixnum range before
7411 converting to 'int'.
806add1d 7412
6511acf2 7413 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7414 Check that an Emacs fixnum is in range before assigning it to 'int'.
7415 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7416 values converted from Emacs fixnums.
7417 (Frecenter): Don't wrap around a line count if it is out of 'int'
7418 range; instead, treat it as an extreme value.
7419 (Fset_window_configuration, compare_window_configurations):
7420 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7421
6511acf2
PE
7422 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7423 that can exceed INT_MAX. Check that EMACS_INT value is in range
7424 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7425 (match_limit): Don't assume that a fixnum can fit in 'int'.
7426
6511acf2 7427 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7428 exceed INT_MAX.
7429
6511acf2 7430 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7431 (Fvertical_motion): Don't wrap around LINES values that don't fit
7432 in 'int'. Instead, treat them as extreme values. This is good
7433 enough for windows, which can't have more than INT_MAX lines anyway.
7434
fcb901a7
LMI
74352011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7436
0f2f6b6d
LMI
7437 * Require libxml/parser.h to avoid compilation warning.
7438
fcb901a7
LMI
7439 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7440
7441 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7442 since this reportedly can destroy thread storage.
7443
6e20a0d4
CY
74442011-08-30 Chong Yidong <cyd@stupidchicken.com>
7445
7446 * syntax.c (find_defun_start): Update all cache variables if
7447 exiting early (Bug#9401).
7448
148ae00e
EZ
74492011-08-30 Eli Zaretskii <eliz@gnu.org>
7450
f6cfbd8f
EZ
7451 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7452
148ae00e
EZ
7453 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7454 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7455 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7456
7457 * term.c (tty_append_glyph): New function.
7458 (produce_stretch_glyph): Static function and its prototype deleted.
7459
a66cfb1c
SM
7460 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7461 Add prototypes.
148ae00e 7462
c4a07a4c
PE
74632011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7464
7465 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7466 when checking :margin (Bug#9390).
7467 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7468 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7469 so that the name doesn't mislead. All uses changed.
7470
6bc8cd65
JB
74712011-08-28 Johan Bockgård <bojohan@gnu.org>
7472
7473 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7474 set_tty_hooks.
7475
dca4927e
EZ
74762011-08-27 Eli Zaretskii <eliz@gnu.org>
7477
7478 * xdisp.c (move_it_to): Don't bail out early when reaching
7479 position beyond to_charpos, if we are scanning backwards.
7480 (move_it_vertically_backward): When DY == 0, make sure we get to
7481 the first character in the line after the newline.
7482
f2cad773
PE
74832011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7484
7485 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7486 (ccl_driver): Do not generate an out-of-range pointer.
7487 (Fccl_execute_on_string): Remove unnecessary check for
7488 integer overflow, noted by Stefan Monnier in
7489 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7490 Remove a FIXME that didn't need fixing.
7491 Simplify the newly-introduced buffer reallocation code.
7492
0cae2cdb
JB
74932011-08-27 Juanma Barranquero <lekktu@gmail.com>
7494
7495 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7496
5fc295a4 74972011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7498
70c60eb2 7499 Integer and memory overflow issues (Bug#9196).
726e0ab1 7500
d31850da
PE
7501 * doc.c (get_doc_string): Rework so that
7502 get_doc_string_buffer_size is the actual buffer size, rather than
7503 being 1 less than the actual buffer size; this makes xpalloc more
7504 convenient.
7505
a69fbedb
PE
7506 * image.c (x_allocate_bitmap_record, cache_image):
7507 * xselect.c (Fx_register_dnd_atom):
7508 Simplify previous changes by using xpalloc.
7509
fe5c5d37
PE
7510 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7511 since either will do and ptrdiff_t is convenient with xpalloc.
7512
0065d054
PE
7513 * charset.c (charset_table_size)
7514 (struct charset_sort_data.priority): Now ptrdiff_t.
7515 (charset_compare): Don't overflow if priorities differ greatly.
7516 (Fsort_charsets): Don't assume list length fits in int.
7517 Check for size-calculation overflow when allocating sort data.
7518 (syms_of_charset): Allocate an initial charset table that is
7519 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7520
7521 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7522
7523 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7524 The actual value is always <= INT_MAX, and leaving it unsigned made
7525 overflow checking harder.
7526
7527 * dispextern.h (struct glyph_matrix.rows_allocated)
7528 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7529 with xpalloc. The values are still always <= INT_MAX.
7530
7531 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7532
7533 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7534 (SAFE_NALLOCA): New macro.
7535
7536 * region-cache.c (struct boundary.pos, find_cache_boundary)
7537 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7538 (set_cache_region, invalidate_region_cache)
7539 (revalidate_region_cache, know_region_cache, region_cache_forward)
7540 (region_cache_backward, pp_cache):
7541 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7542 so that ptrdiff_t * can be passed to xpalloc.
7543 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7544 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7545 (pp_cache): Don't assume cache_len fits in int.
7546 * region-cache.h: Adjust extern decls to match.
7547
7548 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7549 EMACS_INT, since either will do, for xpalloc.
7550
7551 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7552 (xnmalloc, xnrealloc, xpalloc): New functions.
7553
726e0ab1
PE
7554 * bidi.c (bidi_shelve_header_size): New constant.
7555 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7556 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7557
51f30bc5 7558 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7559 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7560 (overlay_strings):
7561 Don't update size of array until after memory allocation succeeds,
7562 because xmalloc/xrealloc may not return.
0065d054
PE
7563 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7564 now that we have proper integer overflow checking.
7565 (record_overlay_string, overlay_strings): Catch overflows when
7566 calculating size of overlay_str_buf.
726e0ab1 7567
0065d054
PE
7568 * callproc.c (Fcall_process): Check for size overflow when
7569 calculating size of args2.
7570 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7571 Normally we prefer signed values, but sticking with ptrdiff_t would
7572 require adding more-complicated checks.
726e0ab1
PE
7573
7574 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7575 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7576 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7577 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7578
7579 * character.c (Fstring): Check for size-calculation overflow.
7580
7581 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7582 unnecessary integer overflow. Check for size overflow.
7583 (encode_coding_object): Don't update size until xmalloc succeeds.
7584
7585 * composite.c (get_composition_id): Check for overflow in glyph
7586 length calculations.
7587
7588 Integer and memory overflow fixes for display code.
7589 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7590 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7591 (scrolling_window): Check for overflow in size calculations.
7592 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7593 Don't assume glyph table len fits in int.
7594 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7595 (row_table_size): Now ptrdiff_t, not int.
7596 (scrolling_window): Avoid overflow in size calculations.
7597 Don't update size until allocation succeeds.
7598 * fns.c (concat): Check for overflow in size calculations.
7599 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7600 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7601 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7602
7603 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7604 (get_doc_string): Check for size calculation overflow.
7605 Don't update size until allocation succeeds.
7606 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7607 EMACS_INT, where ptrdiff_t will do.
7608 (Fsubstitute_command_keys): Check for string overflow.
7609
7610 * editfns.c (set_time_zone_rule): Don't assume environment length
7611 fits in int.
7612 (message_length): Now ptrdiff_t, not int.
7613 (Fmessage_box): Don't update size until allocation succeeds.
7614 Don't assume message length fits in int.
7615 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7616
0065d054
PE
7617 * emacs.c (main): Do not reallocate argv, since there is a null at
7618 the end that can be overwritten, and this way there's no need to
7619 worry about size-calculation overflow.
7620 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7621
7622 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7623 alloc succeeds.
7624 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7625
7626 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7627 (x_set_scroll_bar_width, x_figure_window_size):
7628 Check for integer overflow.
7629 (x_set_alpha): Do not assume XINT fits in int.
7630
7631 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7632 This is for the members text_lines, text_cols, total_lines, total_cols,
7633 where the system imposes an 'int' limit.
7634
7635 * fringe.c (Fdefine_fringe_bitmap):
7636 Don't update size until alloc works.
7637
7638 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7639 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7640
7641 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7642 Check for size-calculation overflow.
7643 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7644 do, as we prefer signed integers.
7645 (id_to_widget.max_size, id_to_widget.used)
7646 (xg_store_widget_in_map, xg_remove_widget_from_map)
7647 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7648 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7649 Use and return ptrdiff_t, not int.
7650 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7651 * gtkutil.h: Change prototypes to match the above.
7652
7653 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7654 are duplicate now that they've been promoted to lisp.h.
7655 (x_allocate_bitmap_record, x_alloc_image_color)
7656 (make_image_cache, cache_image, xpm_load):
7657 Don't update size until alloc is done.
7658 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7659 (x_detect_edges):
3256efce 7660 Check for size calculation overflow.
726e0ab1
PE
7661 (ct_colors_allocated_max): New constant.
7662 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7663 overflow.
3256efce 7664
726e0ab1
PE
7665 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7666 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7667 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7668 Use ptrdiff_t, not int, to count maps.
7669 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7670 calculations. Don't update size until allocation succeeds.
7671 Redo calculations to avoid overflow.
726e0ab1
PE
7672 * keyboard.h: Change prototypes to match the above.
7673
7674 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7675 to count maps.
7676 (current_minor_maps): Check for size calculation overflow.
7677 * keymap.h: Change prototypes to match the above.
7678
7679 * lread.c (read1, init_obarray): Don't update size until alloc done.
7680
7681 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7682 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7683
726e0ab1
PE
7684 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7685 Now ptrdiff_t, not int.
7686 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7687 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7688
7689 * process.c (Fnetwork_interface_list): Check for overflow
7690 in size calculation.
7691
7692 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7693
7694 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7695 overflow. Don't bother calling xmalloc when xrealloc will do.
7696
7697 * search.c (Freplace_match): Check for size calculation overflow.
7698 (Fset_match_data): Don't assume list lengths fit in 'int'.
7699
7700 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7701 for command line length. Do not attempt to address one before the
7702 beginning of an array, as that's not portable.
7703
7704 * term.c (max_frame_lines): Remove; unused.
7705 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7706 not int.
7707 (encode_terminal_code, calculate_costs): Check for size
7708 calculation overflow.
7709 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7710 table lengths and related sizes. Don't update size until alloc
7711 done. Redo calculations to avoid overflow.
7712 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7713
7714 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7715 subtracting pointers.
7716 (gobble_line): Check for overflow more carefully. Don't update size
7717 until alloc done.
7718
7719 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7720 Don't update size until alloc done.
7721 Redo size calculations to avoid overflow.
7722 Check for size calculation overflow.
0065d054 7723 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7724
7725 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7726 Use ptrdiff_t, not int, for sizes.
7727 (store_mode_line_noprop_char): Don't update size until alloc done.
7728
0065d054
PE
7729 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7730 Use ptrdiff_t, not int, for sizes.
7731 (Finternal_make_lisp_face, cache_face):
7732 Check for size calculation overflow.
7733 (cache_face): Treat size calculation overflows as if they were
7734 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7735
7736 * xfns.c (x_encode_text, x_set_name_internal)
7737 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7738 sizes, since they can exceed INT_MAX in size. Check for size
7739 calculation overflow.
7740
0065d054
PE
7741 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7742 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7743 Don't update size until alloc done.
7744
0065d054 7745 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7746 as sprintf is limited to int lengths.
1d526e2f 7747
252c5ee1
PE
7748 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7749 (X_LONG_MIN): New macros.
864d7ce7
PE
7750 Use them to make the following changes clearer.
7751 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7752 This change doesn't affect the value now, but it may help remind
7753 future maintainers not to raise the value too much later.
7754 (SELECTION_QUANTUM): Remove, replacing with ...
7755 (selection_quantum): ... new function, which avoids overflow.
7756 All uses changed.
7757 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7758 assumption that selection length fits in 'int'.
7759 (x_reply_selection_request, x_handle_selection_request)
7760 (x_get_window_property, receive_incremental_selection)
7761 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7762 (lisp_data_to_selection_data, clean_local_selection_data):
7763 Use ptrdiff_t, not int, to record length of selection.
7764 (x_reply_selection_request, x_get_window_property)
7765 (receive_incremental_selection, x_property_data_to_lisp):
7766 Redo calculations to avoid overflow.
7767 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7768 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7769 something.
7770 (x_get_window_property, receive_incremental_selection)
7771 (lisp_data_to_selection_data, x_property_data_to_lisp):
7772 Check for size-calculation overflow.
7773 (x_get_window_property, receive_incremental_selection)
7774 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7775 Don't store size until memory allocation succeeds.
7776 (x_get_window_property): Plug memory leak on memory exhaustion.
7777 Don't double-block input; malloc is safe here. Don't assume 2**34
7778 - 4 fits in unsigned long. Add an xassert to check
7779 XGetWindowProperty overflow. Be more careful about overflow
7780 calculations, and distinguish size from memory overflow better.
7781 (receive_incremental_selection): When tracing, don't assume
7782 unsigned int is less than INT_MAX.
7783 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7784 harmful) conversions of unsigned short to int.
7785 (lisp_data_to_selection_data): Don't assume that integers
7786 in the range -65535 through -1 fit in an X unsigned short.
7787 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7788 result parameters unless successful. Rely on cons_to_unsigned
7789 to report problems with elements; the old code wasn't right anyway.
7790 (x_check_property_data): Check for int overflow; we cannot use
7791 a wider type due to X limits.
7792 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7793
726e0ab1 7794 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7795
0065d054
PE
7796 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7797 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7798 (x_color_cells): Don't store size until memory allocation succeeds.
7799 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7800 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7801 (x_term_init): Don't assume length fits in int (sprintf is limited
7802 to int size).
bc18e09d 7803
ebfa62c0
PE
7804 Use ptrdiff_t for composition IDs.
7805 * character.c (lisp_string_width):
7806 * composite.c (composition_table_size, n_compositions)
7807 (get_composition_id, composition_gstring_from_id):
7808 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7809 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7810 * window.c (Frecenter):
7811 Use ptrdiff_t, not int, for composition IDs.
7812 * composite.c (get_composition_id): Check for integer overflow.
7813 * composite.h: Adjust prototypes to match the above changes.
7814
d3411f89
PE
7815 Use ptrdiff_t for hash table indexes.
7816 * category.c (hash_get_category_set):
7817 * ccl.c (ccl_driver):
7818 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7819 * coding.c (coding_system_charset_list, detect_coding_system):
7820 * coding.h (struct coding_system.id):
7821 * composite.c (get_composition_id, gstring_lookup_cache):
7822 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7823 * image.c (xpm_get_color_table_h):
7824 * lisp.h (hash_lookup, hash_put):
7825 * minibuf.c (Ftest_completion):
7826 Use ptrdiff_t for hash table indexes, not int (which is too
7827 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7828 32-bit --with-wide-int hosts).
7829
e097a6fa
PE
7830 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7831 Add a FIXME comment about memory leaks.
7832 (syms_of_charset): Don't assume xmalloc returns.
7833
5637687f
PE
7834 Don't assume that stated character widths fit in int.
7835 * character.c (Fchar_width, c_string_width, lisp_string_width):
7836 * character.h (CHAR_WIDTH):
7837 * indent.c (MULTIBYTE_BYTES_WIDTH):
7838 Use sanitize_char_width to avoid undefined and/or bad behavior
7839 with outlandish widths.
a66cfb1c 7840 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7841 now that we have two such functions. All uses changed.
7842 (sanitize_char_width): New inline function.
7843
a2271ba2
PE
7844 Don't assume that tab-width fits in int.
7845 * character.h (sanitize_width): New inline function.
7846 (SANE_TAB_WIDTH): New macro.
7847 (ASCII_CHAR_WIDTH): Use it.
7848 * indent.c (sane_tab_width): Remove. All uses replaced by
7849 SANE_TAB_WIDTH (current_buffer).
7850 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7851
18c52557
PE
7852 * fileio.c: Integer overflow issues with file modes.
7853 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7854
caeeedc1
PE
7855 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7856 Remove unreachable code.
7857 (read_hex, load_charset_map_from_file): Check for integer overflow.
7858
6df6ae42 7859 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7860 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7861 (x_send_scroll_bar_event): Likewise. Check that the size does not
7862 exceed limits imposed by XClientMessageEvent, as well as the usual
7863 ptrdiff_t and size_t limits.
7864
b13995db
PE
7865 * keyboard.c: Overflow, signedness and related fixes.
7866 (make_lispy_movement): Use same integer type in forward decl
7867 that is used in the definition.
7868 (read_key_sequence, keyremap_step):
7869 Change bufsize argument back to int, undoing my 2011-03-30 change.
7870 We prefer signed types, and int is wide enough here.
7871 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7872 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7873 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7874 length, not size_t. Use ptrdiff_t for index, not int.
7875 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7876 possibility of integer overflow.
7877
13464394
PE
7878 Overflow, signedness and related fixes for images.
7879
7880 * dispextern.h (struct it.stack[0].u.image.image_id)
7881 (struct_it.image_id, struct image.id, struct image_cache.size)
7882 (struct image_cache.used, struct image_cache.ref_count):
7883 * gtkutil.c (update_frame_tool_bar):
7884 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7885 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7886 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7887 * nsmenu.m (update_frame_tool_bar):
7888 * xdisp.c (calc_pixel_width_or_height):
7889 * xfns.c (image_cache_refcount):
7890 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7891 on typical 64-bit hosts.
7892
7893 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7894 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7895 Omit unnecessary casts to int.
7896 (parse_image_spec): Check that integers fall into 'int' range
7897 when the callers expect that.
7898 (image_ascent): Redo ascent calculation to avoid int overflow.
7899 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7900 (lookup_image): Remove unnecessary tests.
7901 (xbm_image_p): Locals are now of int, not EMACS_INT,
7902 since parse_image_check makes sure they fit into int.
7903 (png_load, gif_load, svg_load_image):
7904 Prefer int to unsigned where either will do.
7905 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7906 old tiff_error_handler and tiff_warning_handler.
7907 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7908 stack buffer overflows. It uses only the features of vsnprintf
7909 that are common to both POSIX and native Microsoft.
7910 (tiff_error_handler, tiff_warning_handler): Use it.
7911 (tiff_load, gif_load, imagemagick_load_image):
7912 Don't assume :index value fits in 'int'.
7913 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7914 (imagemagick_load_image): Check that crop parameters fit into
7915 the integer types that MagickCropImage accepts. Don't assume
7916 Vimagemagick_render_type has a nonnegative value. Don't assume
7917 size_t fits in 'long'.
7918 (gs_load): Use printmax_t to print the widest integers possible.
7919 Check for integer overflow when computing image height and width.
7920
c11821d4
EZ
79212011-08-26 Eli Zaretskii <eliz@gnu.org>
7922
7923 * xdisp.c (redisplay_window): Don't force window start if point
7924 will be invisible in the resulting window. (Bug#9324)
7925
0c95fcf7
EZ
79262011-08-25 Eli Zaretskii <eliz@gnu.org>
7927
7928 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7929 the display spec is of the form `(space ...)'.
7930 (handle_display_spec): Return the value returned by
7931 handle_single_display_spec, not just 1 or zero.
7932 (handle_single_display_spec): If the display spec is of the form
7933 `(space ...)', and specifies display in the text area, return 2
7934 rather than 1.
fee65a97 7935 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7936 accurately, and prefer exact match for point under bidi.
7937 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7938
7939 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7940 into disp_prop; all users changed.
7941
7942 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7943 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7944 for the text covered by the display property.
7945
e4ed06f1
CY
79462011-08-25 Chong Yidong <cyd@stupidchicken.com>
7947
7948 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7949 Change return value to nil.
7950 (Frecord_buffer): Delete unused function.
7951
f67cdd7f
EZ
79522011-08-24 Eli Zaretskii <eliz@gnu.org>
7953
5980d4c6
EZ
7954 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7955 buffers, return left-to-right.
8610fe8b
EZ
7956 (set_cursor_from_row): Consider candidate row a win if its glyph
7957 represents a newline and point is on that newline. Fixes cursor
7958 positioning on the newline at EOL of R2L text within L2R
7959 paragraph, and vice versa.
7960 (try_cursor_movement): Check continued rows, in addition to
7961 continuation rows. Fixes unwarranted scroll when point enters a
7962 continued line of R2L text within an L2R paragraph, or vice versa.
7963 (cursor_row_p): Consider the case of point being equal to
7964 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7965 from the end of a short line to the beginning of a continued line
7966 of R2L text within L2R paragraph.
7967 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7968 composed characters.
5980d4c6 7969
f67cdd7f
EZ
7970 * bidi.c (bidi_check_type): Use xassert.
7971 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7972 members.
7973
bca633fb
EZ
79742011-08-23 Eli Zaretskii <eliz@gnu.org>
7975
7976 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7977 a character.
7978
4a5885a7
CY
79792011-08-23 Chong Yidong <cyd@stupidchicken.com>
7980
7981 * nsfont.m (ns_otf_to_script): Fix typo.
7982
0902a04e
KH
79832011-08-22 Kenichi Handa <handa@m17n.org>
7984
7985 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7986 extra slot even if the purpose is char-code-property-table.
7987
1a2e6670
EZ
79882011-08-23 Eli Zaretskii <eliz@gnu.org>
7989
8ddde651
EZ
7990 * xdisp.c (redisplay_window): When computing centering_position,
7991 account for the height of the header line. (Bug#8874)
7992
425cc014
EZ
7993 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7994 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7995 candidate is selected by the mouse, and that candidate has a
7996 composed character under the mouse.
7997
1a2e6670
EZ
7998 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7999 coordinates reported by pos-visible-in-window-p for a composed
8000 character in column zero.
8001
8b76d6f8
SM
80022011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8003
8004 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8005
dac347dd
EZ
80062011-08-22 Eli Zaretskii <eliz@gnu.org>
8007
8008 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8009 consider it a hit if to_charpos is anywhere in the range of the
8010 composed buffer positions.
8011
e013fb34
CY
80122011-08-22 Chong Yidong <cyd@stupidchicken.com>
8013
8014 * image.c (gif_load): Don't assume that each subimage has the same
8015 dimensions as the base image. Handle disposal method that is
8016 "undefined" by the gif spec (Bug#9335).
8017
bd1ba3e8
CY
80182011-08-20 Chong Yidong <cyd@stupidchicken.com>
8019
8020 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8021 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8022
54a1215b
EZ
80232011-08-19 Eli Zaretskii <eliz@gnu.org>
8024
823564e5
EZ
8025 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8026 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8027 from an Org mode buffer to a Speedbar frame.
8028
54a1215b
EZ
8029 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8030 a composition, take its buffer position from IT->cmp_it.charpos.
8031 Fixes cursor positioning at the beginning of a line that begins
8032 with a composed character.
8033
9778ebcc
EZ
80342011-08-18 Eli Zaretskii <eliz@gnu.org>
8035
0be6ee06
EZ
8036 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8037 character bidirectional type, use STRONG_L instead. Fixes crashes
8038 in a buffer produced by `describe-categories'.
8039
9778ebcc
EZ
8040 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8041 members before the level stack, so they would be saved and
8042 restored when copying iterator state. Fixes incorrect reordering
8043 around TABs covered by display properties.
8044
156bffbe
AS
80452011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8046
6b02f655 8047 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8048
72ad093b
CY
80492011-08-17 Chong Yidong <cyd@stupidchicken.com>
8050
8051 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8052 (internal_condition_case_2, internal_condition_case_n):
8053 Remove unnecessary aborts (Bug#9081).
72ad093b 8054
35774242
EZ
80552011-08-17 Eli Zaretskii <eliz@gnu.org>
8056
8057 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8058 has no `load' handler, try opening the file locally. (Bug#9311)
8059
db76dd85
KB
80602011-08-16 Ken Brown <kbrown@cornell.edu>
8061
8062 * gmalloc.c: Expand comment.
8063
b215eee5
EZ
80642011-08-16 Eli Zaretskii <eliz@gnu.org>
8065
8066 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8067 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8068
a4579d33
KB
80692011-08-16 Ken Brown <kbrown@cornell.edu>
8070
8071 Fix memory allocation problems in Cygwin build (Bug#9273).
8072
8073 * unexcw.c ( __malloc_initialized): Declare external variable.
8074 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8075
8b76d6f8
SM
8076 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8077 New variables.
a4579d33
KB
8078 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8079 dumped emacs.
8080 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8081 in the static heap.
8082 [CYGWIN] (special_realloc): New function.
8083 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8084 requests to realloc storage in the static heap.
8085
3ebec551
PE
80862011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8087
8088 * bidi.c (bidi_initialize): Remove unused local.
8089
9fd8be00
EZ
80902011-08-15 Eli Zaretskii <eliz@gnu.org>
8091
6b02f655
SM
8092 * bidimirror.h:
8093 * biditype.h: Remove file.
8094 * makefile.w32-in ($(BLD)/bidi.$(O)):
8095 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8096
8097 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8098
8099 * chartab.c: Improve commentary for the uniprop_table API.
8100
32413314
EZ
8101 * bidi.c (bidi_paragraph_init): Support zero value of
8102 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8103 (bidi_initialize): Use uniprop_table instead of including
8104 biditype.h and bidimirror.h.
32413314 8105
9fd8be00
EZ
8106 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8107 coordinates of the iterator when restoring from ppos_it.
8108 (Bug#9296)
8109
5cf2b69b
KH
81102011-08-14 Kenichi Handa <handa@m17n.org>
8111
8112 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8113 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8114
daf17d00
EZ
81152011-08-14 Eli Zaretskii <eliz@gnu.org>
8116
8117 * xdisp.c (move_it_in_display_line_to): Don't invoke
8118 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8119 ppos_it. Fixes vertical cursor motion when line beginning is
8120 covered by an image. (Bug#9296)
8121
08e3161a
JD
81222011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8123
8124 * nsterm.h (ns_run_ascript): Declare.
8125 (NSAPP_DATA2_RUNASSCRIPT): Define.
8126
8127 * nsfns.m (as_script, as_result, as_status): New static variables.
8128 (ns_run_ascript): New function.
5e617bc2 8129 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8130 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8131 the event loop. Get status from as_status (Bug#7276).
8132
8133 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8134 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8135 the event loop (Bug#7276).
8136
a3720aa2
AS
81372011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8138
8139 * gnutls.c (QCgnutls_bootprop_priority)
8140 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8141 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8142 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8143 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8144 (QCgnutls_bootprop_verify_hostname_error)
8145 (QCgnutls_bootprop_callbacks_verify): Rename from
8146 Qgnutls_bootprop_..., all uses changed.
8147
8148 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8149 uses changed.
8150
0a0d27fb
PE
81512011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8152
19d5c50c
PE
8153 * xfaces.c (Qframe_set_background_mode): Now static.
8154 * dispextern.h (Qframe_set_background_mode): Remove decl.
8155
0a0d27fb
PE
8156 * process.c (Fnetwork_interface_info): Declare local only if needed.
8157
377538cb
JD
81582011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8159
8160 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8161 (Fnetwork_interface_list): Allocate in increments of bytes instead
8162 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8163 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8164 sockaddr.
8165 (struct ifflag_def): notrailers is smart on OSX.
8166 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8167 Get hardware address with getifaddrs if available.
8168
08fff70c
EZ
81692011-08-12 Eli Zaretskii <eliz@gnu.org>
8170
8171 * xdisp.c (iterate_out_of_display_property): xassert that
8172 IT->position is set to within IT->object's boundaries. Break from
8173 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8174 when IT->position is set up wrongly due to some bug.
8175 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8176 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8177 entry. Force push_it to save on the stack the current
8178 buffer/string position, to be restored by pop_it. Fix flags in
8179 the iterator structure wrt the object coming from a display
8180 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8181 properties. (Bug#9284)
8182
7be1c708 81832011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8184
7be1c708
CY
8185 * fontset.c (fontset_get_font_group): Add proper type checks.
8186 (Bug#9172)
aac0c6e3 8187
7be1c708 81882011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8189
7be1c708
CY
8190 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8191 and LC_VERSION_MIN_MACOSX.
8192 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8193 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8194
97bb72a6
EZ
81952011-08-08 Eli Zaretskii <eliz@gnu.org>
8196
8197 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8198 no-display-properties-and-no-overlays under bidi display.
8199 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8200 properties and overlays.
97bb72a6 8201
d5617611
CY
82022011-08-08 Chong Yidong <cyd@stupidchicken.com>
8203
37e11a63
CY
8204 * editfns.c (Fset_time_zone_rule): Document relationship with the
8205 setenv function.
8206
d5617611
CY
8207 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8208 the font entity extracted from the cache (Bug#8109).
8209
58872834
CY
82102011-08-07 Chong Yidong <cyd@stupidchicken.com>
8211
8212 * composite.c (autocmp_chars): Don't reset point. That is done by
8213 restore_point_unwind (Bug#5984).
8214
75bfc667
JL
82152011-08-07 Juri Linkov <juri@jurta.org>
8216
8217 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8218 to show the arg `TIME' instead of `TIMEVAL'.
8219
d1410150
EZ
82202011-08-06 Eli Zaretskii <eliz@gnu.org>
8221
8222 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8223 display property strides EOL and includes a newline, as in
8224 longlines-mode. (Bug#9254)
75b771e4
EZ
8225 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8226 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8227
8228 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8229 is non-zero, even if the data buffer is NULL. Fixes a crash in
8230 vertical-motion with longlines-mode. (Bug#9254)
8231
35928349
EZ
82322011-08-05 Eli Zaretskii <eliz@gnu.org>
8233
ec7cc85b
EZ
8234 * bidi.c <bidi_cache_total_alloc>: Now static.
8235 (bidi_initialize): Initialize bidi_cache_total_alloc.
8236
8b76d6f8 8237 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8238 cache. (Bug#9221)
8239
8240 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8241 amount allocated this far in `bidi_cache_total_alloc'.
8242 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8243 non-zero, only free the data buffer without restoring the cache
8244 contents. All callers changed.
8245
8246 * dispextern.h (bidi_unshelve_cache): Update prototype.
8247
8248 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8249 (move_it_in_display_line, move_it_to)
8250 (move_it_vertically_backward, move_it_by_lines): Replace the call
8251 to xfree to an equivalent call to bidi_unshelve_cache.
8252 (move_it_in_display_line_to): Fix logic of returning
412b6358 8253 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8254
e2e2423b
EZ
82552011-08-05 Eli Zaretskii <eliz@gnu.org>
8256
8257 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8258 came from a string character with a `cursor' property. (Bug#9229)
8259
ae9e757a
JD
82602011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8261
8262 * Makefile.in (LIB_PTHREAD): New variable.
8263 (LIBES): Add LIB_PTHREAD (Bug#9216).
8264
8265 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8266 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8267
213bd7f2
AS
82682011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8269
6b02f655 8270 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8271
99aaf75f
JD
82722011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8273
8274 * xterm.c (x_find_topmost_parent): New function.
8275 (x_set_frame_alpha): Find topmost parent window with
8276 x_find_topmost_parent and set the property there also (bug#9181).
8277 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8278
c74e9d86
PE
82792011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8280
8281 * callproc.c (Fcall_process): Avoid vfork clobbering
8282 the local vars buffer, coding_systems, current_dir.
8283
640c8776
SM
82842011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8285
8286 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8287
f26d0e4c
PE
82882011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8289
8a10d76c
PE
8290 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8291 so that it is not optimized away.
8292
f26d0e4c
PE
8293 * xdisp.c (compute_display_string_pos): Remove unused local.
8294
55439c61
EZ
82952011-08-02 Eli Zaretskii <eliz@gnu.org>
8296
8297 Fix slow cursor motion and scrolling in large buffers with
8298 selective display, like Org Mode buffers. (Bug#9218)
8299
8300 * dispextern.h (struct bidi_it): New member disp_prop_p.
8301
8302 * xdisp.c: Remove one-slot cache of display string positions.
8303 (compute_display_string_pos): Accept an additional argument
5e617bc2 8304 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8305 for a display string or property. If found, set DISP_PROP_P
8306 non-zero.
8307
8308 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8309 DISP_PROP_P, and pass it to compute_display_string_pos.
8310 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8311 non-zero. All callers of bidi_fetch_char changed.
8312
fb33fa43
SM
83132011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8314
8315 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8316
b099e063
DM
83172010-12-03 Don March <don@ohspite.net>
8318
8319 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8320 last character M-[char] is translated to ESC [char] (bug#7541).
8321
5cc7f7af
KH
83222011-08-02 Kenichi Handa <handa@m17n.org>
8323
d0fffa3f 8324 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8325
8326 * chartab.c (uniprop_table): Make it non-static.
8327
525d5e6e
EZ
83282011-08-01 Eli Zaretskii <eliz@gnu.org>
8329
8330 * xdisp.c (forward_to_next_line_start): Accept additional argument
8331 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8332 on the newline.
8333 (reseat_at_next_visible_line_start): Use the bidi iterator state
8334 returned by forward_to_next_line_start to restore the state of
8335 it->bidi_it after backing up to previous newline. (Bug#9212)
8336
31011111
AS
83372011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8338
8339 * regex.c (re_comp): Protoize.
8340 (re_exec): Fix return type.
8341 (regexec): Fix type of `ret'. (Bug#9203)
8342
476371c4
PE
83432011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8344
e5d76069
PE
8345 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8346 This is needed if max-image-size is a floating-point number.
8347
9a79b20c
AS
83482011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8349
8350 * print.c (print_object): Print empty symbol as ##.
8351
8352 * lread.c (read1): Read ## as empty symbol.
8353
d8c2fa78
AA
83542011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8355
8356 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8357 setting frame foreground color (Bug#9175).
8358 (x_set_background_color): Likewise.
8359
ffe57a7a
AA
8360 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8361 contents (Bug#9176).
8362 (EmacsTooltip -init): Remove bezels and add shadows to
8363 tooltip windows.
8364
bf3492a5
AA
8365 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8366 or scroll bar (Bug#8470).
8367
d55e9c53
AA
8368 * nsfont.m (nsfont_open): Remove assignment to voffset and
8369 unnecessary vars hshink, expand, hd, full_height, min_height.
8370 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8371
8372 * nsterm.h (nsfont_info): Remove voffset field.
8373
d8c2fa78 83742011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8375
8376 Implement strike-through and overline on NextStep (Bug#8863).
8377
8378 * nsfont.m (nsfont_open): Use underline position provided by font,
8379 instead of hard-coded value of 2.
8380 (nsfont_draw): Call ns_draw_text_decoration instead.
8381
8382 * nsterm.h: Add declaration for ns_draw_text_decoration.
8383
8384 * nsterm.m (ns_draw_text_decoration): New function for drawing
8385 underline, overline, and strike-through.
8386 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8387 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8388 accommodate underlining, etc.
4843aac3 8389
4cc60b9b
EZ
83902011-07-28 Eli Zaretskii <eliz@gnu.org>
8391
bc7ece87
EZ
8392 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8393 default.
4cc60b9b 8394
476371c4
PE
83952011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8396
66606eea
PE
8397 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8398 Without this fix, if a signal arrives just after memory fills up,
8399 'malloc' might be invoked reentrantly.
8400
476371c4
PE
8401 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8402 In other words, assume that every image size is allowed, on non-X
8403 hosts. This assumption is probably wrong, but it lets Emacs compile.
8404
f3fcc40d
AS
84052011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8406
8407 * regex.c (re_iswctype): Convert return values to boolean.
8408
350c992f
EZ
84092011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8410
8411 * xdisp.c (compute_display_string_pos): Don't use cached display
8412 string position if the buffer had its restriction changed.
8413 (Bug#9184)
8414
5266b4bb
PE
84152011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8416
8417 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8418
2573a837 84192011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8420
41f55ccd 8421 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8422
39e378da
PE
8423 * bidi.c: Integer size and overflow fixes.
8424 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8425 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8426 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8427 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8428 (bidi_find_other_level_edge):
8429 Use ptrdiff_t instead of EMACS_INT where either will do.
8430 This works better on 32-bit hosts configured --with-wide-int.
8431 (bidi_cache_ensure_space): Check for size-calculation overflow.
8432 Use % rather than repeated addition, for better worst-case speed.
8433 Don't set bidi_cache_size until after xrealloc returns, because it
8434 might not return.
8435 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8436 (bidi_cache_ensure_space): Also check that the bidi cache size
8437 does not exceed that of the largest Lisp string or buffer. See Eli
8438 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8439
5e927815
PE
8440 * alloc.c (__malloc_size_t): Remove.
8441 All uses replaced by size_t. See Andreas Schwab's note
8442 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8443
ca4aa935
PE
8444 * image.c: Improve checking for integer overflow.
8445 (check_image_size): Assume that f is nonnull, since
8446 it is always nonnull in practice. This is one less thing to
8447 worry about when checking for integer overflow later.
8448 (x_check_image_size): New function, which checks for integer
8449 overflow issues inside X.
8450 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8451 This removes the need for a memory_full check.
8452 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8453 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8454 (xbm_read_bitmap_data): Change locals back to 'int', since
8455 their values must fit in 'int'.
8456 (xpm_load_image, png_load, tiff_load):
8457 Invoke x_create_x_image_and_pixmap earlier,
8458 to avoid much needless work if the image is too large.
8459 (tiff_load): Treat overly large images as if
8460 x_create_x_image_and_pixmap failed, not as malloc failures.
8461 (gs_load): Use x_check_image_size.
8462
5f8f9cc2
PE
8463 * gtkutil.c: Omit integer casts.
8464 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8465 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8466
5adf60bc
PE
8467 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8468
c8907a93
PE
8469 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8470 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8471 would wrongly return t on a 64-bit host.
8472
e3c25c68
PE
8473 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8474 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8475 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8476 and therefore cause GCC to emit a bogus diagnostic in some cases.
8477
3f791afe
PE
8478 * image.c: Integer signedness and overflow and related fixes.
8479 This is not an exhaustive set of fixes, but it's time to
8480 record what I've got.
8481 (lookup_pixel_color, check_image_size): Remove redundant decls.
8482 (check_image_size): Don't assume that arbitrary EMACS_INT values
8483 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8484 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8485 (tiff_load, imagemagick_load_image):
8486 Check for overflow in size calculations.
8487 (x_create_x_image_and_pixmap): Remove unnecessary test for
8488 xmalloc returning NULL; that can't happen.
8489 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8490 (xpm_color_bucket): Use better integer hashing function.
8491 (xpm_cache_color): Don't possibly over-allocate memory.
8492 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8493 (gif_memory_source):
8494 Use ptrdiff_t, not int or size_t, to record sizes.
8495 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8496 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8497 either works, as we prefer signed integers.
8498 (tiff_read_from_memory, tiff_write_from_memory):
8499 Return tsize_t, not size_t, since that's what the TIFF API wants.
8500 (tiff_read_from_memory): Don't fail simply because the read would
8501 go past EOF; instead, return a short read.
8502 (tiff_load): Omit no-longer-needed casts.
8503 (Fimagemagick_types): Don't assume size fits into 'int'.
8504
3cc5a532
PE
8505 Improve hashing quality when configured --with-wide-int.
8506 * fns.c (hash_string): New function, taken from sxhash_string.
8507 Do not discard information about ASCII character case; this
8508 discarding is no longer needed.
8509 (sxhash-string): Use it. Change sig to match it. Caller changed.
8510 * lisp.h: Declare it.
8511 * lread.c (hash_string): Remove, since we now use fns.c's version.
8512 The fns.c version returns a wider integer if --with-wide-int is
8513 specified, so this should help the quality of the hashing a bit.
8514
b312a492
PE
8515 * emacs.c: Integer overflow minor fix.
8516 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8517 Define only if GNU_LINUX.
8518 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8519
dfd153ae
PE
8520 * dispnew.c: Integer signedness and overflow fixes.
8521 Remove unnecessary forward decls, that were a maintenance hassle.
8522 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8523 All uses changed.
8524 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8525 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8526 (prepare_desired_row, line_draw_cost):
8527 Use int, not unsigned, where either works.
8528 (save_current_matrix, restore_current_matrix):
8529 Use ptrdiff_t, not size_t, where either works.
8530 (init_display): Check for overflow more accurately, and without
8531 relying on undefined behavior.
8532
a81d11a3
PE
8533 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8534 Remove, replacing with the new symbols in lisp.h. All uses changed.
8535 * fileio.c (make_temp_name):
8536 * filelock.c (lock_file_1, lock_file):
8537 * xdisp.c (message_dolog):
8538 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8539 Use pMd etc. instead.
8540 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8541 replacing the pWIDE etc. symbols removed from editfns.c.
8542
3300e6fd
PE
8543 * keyboard.h (num_input_events): Now uintmax_t.
8544 This is (very slightly) less likely to mess up due to wraparound.
8545 All uses changed.
8546
fd05c7e9
PE
8547 * buffer.c: Integer signedness fixes.
8548 (alloc_buffer_text, enlarge_buffer_text):
8549 Use ptrdiff_t rather than size_t when either will do, as we prefer
8550 signed integers.
8551
903fe15d
PE
8552 * alloc.c: Integer signedness and overflow fixes.
8553 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8554 (__malloc_size_t): Default to size_t, not to int.
8555 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8556 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8557 Prefer ptrdiff_t to size_t when either would do, as we prefer
8558 signed integers.
8559 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8560 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8561 Now const. Initialize with values that are in range even if char
8562 is signed.
8563 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8564 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8565 These functions do the right thing with sizes > 2**32.
8566 (check_depth): Now ptrdiff_t, not int.
8567 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8568 Adjust to new way of storing sizes. Check for size overflow bugs
8569 in rest of code.
8570 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8571 slightly wrong anyway, as it missed one instance of
8572 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8573 (refill_memory_reserve): Omit needless cast to size_t.
8574 (mark_object_loop_halt): Mark as externally visible.
8575
ac82cc6a
PE
8576 * xselect.c: Integer signedness and overflow fixes.
8577 (Fx_register_dnd_atom, x_handle_dnd_message):
8578 Use ptrdiff_t, not size_t, since we prefer signed.
8579 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8580 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8581 x_dnd_atoms_size and x_dnd_atoms_length.
8582
c2d1e36d
PE
8583 * doprnt.c: Prefer signed to unsigned when either works.
8584 * eval.c (verror):
8585 * doprnt.c (doprnt):
8586 * lisp.h (doprnt):
8587 * xdisp.c (vmessage):
8588 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8589 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8590 prefer signed arithmetic to avoid comparison confusion.
8591 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8592 but is a bit tricky.
8593
0e926e56
PE
8594 Assume freestanding C89 headers, string.h, stdlib.h.
8595 * data.c, doprnt.c, floatfns.c, print.c:
8596 Include float.h unconditionally.
8597 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8598 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8599 * regex.c: Likewise for stddef.h, string.h.
8600 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8601 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8602 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8603 (STDC_HEADERS): Remove obsolete defines.
8604 * sysdep.c: Include limits.h unconditionally.
8605
9cfdb3ec
PE
8606 Assume support for memcmp, memcpy, memmove, memset.
8607 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8608 * regex.c (memcmp, memcpy):
8609 Remove; we assume C89 now.
8610
8611 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8612 (__malloc_safe_bcopy): Remove; no longer needed.
8613
cf950e6b 8614 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8615 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8616 well either way, and we prefer signed to unsigned.
8617
dbf38e02
LMI
86182011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8619
8620 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8621 closes the connection while we're reading (bug#9182).
8622
d6f0886c 86232011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8624
d6f0886c
JD
8625 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8626 are specified (Bug#9168).
24e0f6b1 8627
2eb1f9e6
PE
86282011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8629
8630 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8631 Found by GCC static checking and --with-wide-int on a 32-bit host.
8632
22381272 86332011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8634
8635 * xdisp.c (compute_display_string_pos): Fix logic of caching
8636 previous display string position. Initialize cached_prev_pos to
8637 -1. Fixes slow-down at the beginning of a buffer.
8638
f25e39b4
EZ
86392011-07-24 Eli Zaretskii <eliz@gnu.org>
8640
8641 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8642 for attrs[LFACE_FONTSET_INDEX].
8643
04c4b52e
PE
86442011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8645
8646 * xml.c (parse_region): Remove unused local
8647 that was recently introduced.
8648
c1734fbd
EZ
86492011-07-23 Eli Zaretskii <eliz@gnu.org>
8650
be18c5a5
EZ
8651 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8652 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8653
c1734fbd
EZ
8654 * xdisp.c (move_it_in_display_line_to): Record the best matching
8655 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8656 exit if none of the characters scanned was an exact match.
8657 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8658 when exact match is impossible due to invisible text, and the
8659 lines are truncated.
8660
a258d627
JD
86612011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8662
8663 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8664 for OSX >= 10.7.
8665
b6d5a689
EZ
86662011-07-22 Eli Zaretskii <eliz@gnu.org>
8667
0f74f785
EZ
8668 Fix a significant slow-down of cursor motion with C-n, C-p,
8669 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8670 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8671 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8672 (next_element_from_buffer): Call compute_stop_pos_backwards to
8673 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8674 base_level_stop.
8675 (reseat): Don't look for prev_stop, as that could mean a very long
8676 run.
8677 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8678 <cached_disp_overlay_modiff>: Cache for last found display string
8679 position.
551918c1 8680 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8681 about the same buffer in the same area of character positions, and
8682 the buffer wasn't changed since the time the display string
8683 position was cached.
551918c1 8684
b2d0c91a
EZ
86852011-07-22 Eli Zaretskii <eliz@gnu.org>
8686
8687 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8688 is an integer, which is important for empty lines. (Bug#9149)
8689
043604ee
CY
86902011-07-22 Chong Yidong <cyd@stupidchicken.com>
8691
8692 * frame.c (Fmodify_frame_parameters): In tty case, update the
8693 default face if necessary (Bug#4238).
8694
da4adb04
CY
86952011-07-21 Chong Yidong <cyd@stupidchicken.com>
8696
8697 * editfns.c (Fstring_to_char): No need to explain what a character
8698 is in the docstring (Bug#6576).
8699
9abd0532
LMI
87002011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8701
8702 * xml.c (parse_region): Make sure we always return a tree.
8703
36881d16
HK
87042011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8705
8706 * xml.c (parse_region): If a document contains only comments,
8707 return that, too.
8708
1e98674d
LMI
87092011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8710
8711 * xml.c (make_dom): Return comments, too.
8712
590bd467
PE
87132011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8714
8715 Port to OpenBSD.
8716 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8717 and the surrounding thread.
8718 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8719 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8720 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8721 timer goes off.
8722 * s/openbsd.h (BROKEN_SIGIO): Define.
8723 * unexelf.c (unexec) [__OpenBSD__]:
8724 Don't update the .mdebug section of the Alpha COFF symbol table.
8725
f41628b2
LMI
87262011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8727
8728 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8729 (bug#8460).
8730
b59b67c5
PE
87312011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8732
15e3a074
PE
8733 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8734 This fixes some race conditions on the permissions of any newly
8735 created file.
8736
41bed37d
PE
8737 * alloc.c (valid_pointer_p): Use pipe, not open.
8738 This fixes some permissions issues when debugging.
8739
b59b67c5
PE
8740 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8741 If fchown fails to set both uid and gid, try to set just gid,
8742 as that is sometimes allowed. Adjust the file's mode to eliminate
8743 setuid or setgid bits that are inappropriate if fchown fails.
8744
925a6be7
SM
87452011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8746
8747 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8748 to compare Lisp_Objects.
8749 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8750 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8751 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8752
52968808
AS
87532011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8754
0a6a104b
AS
8755 * lread.c (read_integer): Unread even EOF character.
8756 (read1): Likewise. Properly record start position of symbol.
8757
52968808
AS
8758 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8759 symbol character follows.
8760
9e381cdd
PE
87612011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8762
8763 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8764 This works around a problem with the previous change to Fcopy_file.
8765 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8766 and without this change, GCC might complain about discarding
8767 fchown's return value.
8768
b5641435
JB
87692011-07-16 Juanma Barranquero <lekktu@gmail.com>
8770
8771 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8772
a8031457
PE
87732011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8774
8775 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8776
dd889327
LMI
87772011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8778
750c33f7
LMI
8779 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8780 it's used from the C level.
8781
dd889327
LMI
8782 * process.c: Use the same condition for POLL_FOR_INPUT in both
8783 keyboard.c and process.c (bug#1858).
8784
87e86684
LM
87852011-07-09 Lawrence Mitchell <wence@gmx.li>
8786
8787 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8788 (Fgnutls_boot): Use it.
8789
64348f40
AS
87902011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8791
8792 * doc.c (Fsubstitute_command_keys): Revert last change.
8793
1d698799
LMI
87942011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8795
f863868c
LMI
8796 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8797 quotes the next character, and doesn't affect other longer
8798 sequences (bug#8935).
8799
1d698799
LMI
8800 * lread.c (syms_of_lread): Clarify that is isn't only
8801 `eval-buffer' and `eval-defun' that's affected by
8802 `lexical-binding' (bug#8460).
8803
aa4b6df6
EZ
88042011-07-15 Eli Zaretskii <eliz@gnu.org>
8805
8806 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8807 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8808
5d856da6
PE
88092011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8810
ad6042bb
PE
8811 Fix minor problems found by static checking.
8812 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8813 (elsz): Now a signed constant, not a size_t var. We prefer signed
8814 types to unsigned, to avoid integer comparison confusion. Without
8815 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8816 "cannot optimize loop, the loop counter may overflow", a symptom
8817 of the confusion.
f00bbb22 8818 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8819 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8820
6468f31c
LMI
88212011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8822
49080b10
LMI
8823 * search.c (Fre_search_backward): Mention `case-fold-search' in
8824 all the re_search_* functions (bug#8138).
8825
6468f31c
LMI
8826 * keyboard.c (Fopen_dribble_file): Document when the file is
8827 closed (bug#8056).
8828
c965adc5
EZ
88292011-07-14 Eli Zaretskii <eliz@gnu.org>
8830
df9733bf
EZ
8831 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8832 bidi_cache_idx.
8833
0bb23927
EZ
8834 Support bidi reordering of display and overlay strings.
8835 * xdisp.c (compute_display_string_pos)
8836 (compute_display_string_end): Accept additional argument STRING.
8837 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8838 (reseat_to_string): Initialize bidi_it->string.s and
8839 bidi_it->string.schars.
8840 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8841 NULL (avoids a crash in bidi_paragraph_init).
8842 Initialize itb.string.lstring.
0bb23927
EZ
8843 (init_iterator): Call bidi_init_it only of a valid
8844 buffer position was specified. Initialize paragraph_embedding to
8845 L2R.
8846 (reseat_to_string): Initialize the bidi iterator.
8847 (display_string): If we need to ignore text properties of
8848 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8849 original value of -1 will not work with bidi.)
8850 (compute_display_string_pos): First arg is now struct
8851 `text_pos *'; all callers changed. Support display properties on
8852 Lisp strings.
8853 (compute_display_string_end): Support display properties on Lisp
8854 strings.
8855 (init_iterator, reseat_1, reseat_to_string): Initialize the
8856 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8857 when iterating on a string not from display properties).
640c8776
SM
8858 (compute_display_string_pos, compute_display_string_end):
8859 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8860 arrow keys.
8861 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8862 base_level_stop; instead, set base_level_stop to BEGV.
8863 Fixes crashes in vertical-motion.
0bb23927
EZ
8864 (next_element_from_buffer): Improve commentary for when
8865 the iterator is before prev_stop.
8866 (init_iterator): Initialize bidi_p from the default value of
8867 bidi-display-reordering, not from buffer-local value. Use the
8868 buffer-local value only if initializing for buffer iteration.
8869 (handle_invisible_prop): Support invisible properties on strings
8870 that are being bidi-reordered.
8871 (set_iterator_to_next): Support bidi reordering of C strings and
8872 Lisp strings.
8873 (next_element_from_string): Support bidi reordering of Lisp
8874 strings.
8875 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8876 (display_string): Support display of R2L glyph rows.
8877 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8878 (init_iterator): Don't initialize it->bidi_p for strings
8879 here.
8880 (reseat_to_string): Initialize it->bidi_p for strings here.
8881 (next_element_from_string, next_element_from_c_string)
8882 (next_element_from_buffer): Add xassert's for correspondence
8883 between IT's object being iterated and it->bidi_it.string
8884 structure.
8885 (face_before_or_after_it_pos): Support bidi iteration.
8886 (next_element_from_c_string): Handle the case of the first string
8887 character that is not the first one in the visual order.
8888 (get_visually_first_element): New function, refactored from common
8889 parts of next_element_from_buffer, next_element_from_string, and
8890 next_element_from_c_string.
8891 (tool_bar_lines_needed, redisplay_tool_bar)
8892 (display_menu_bar): Force left-to-right direction. Add a FIXME
8893 comment for making that be controlled by a user option.
8894 (push_it, pop_it): Save and restore the state of the
8895 bidi iterator. Save and restore the bidi_p flag.
8896 (pop_it): Iterate out of display property for string iteration as
8897 well.
8898 (iterate_out_of_display_property): Support iteration over strings.
8899 (handle_single_display_spec): Set up it->bidi_it for iteration
8900 over a display string, and call bidi_init_it.
8901 (handle_single_display_spec, next_overlay_string)
8902 (get_overlay_strings_1, push_display_prop): Set up the bidi
8903 iterator for displaying display or overlay strings.
8904 (forward_to_next_line_start): Don't use the shortcut if
8905 bidi-iterating.
8906 (back_to_previous_visible_line_start): If handle_display_prop
8907 pushed the iterator stack, restore the internal state of the bidi
8908 iterator by calling bidi_pop_it same number of times.
8909 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8910 and we are bidi-iterating, don't decrement the iterator position;
8911 instead, set the first_elt flag in the bidi iterator, to produce
8912 the same effect.
8913 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8914 (push_display_prop): xassert that we are iterating a buffer.
8915 (push_it, pop_it): Save and restore paragraph_embedding member.
8916 (handle_single_display_spec, next_overlay_string)
8917 (get_overlay_strings_1, reseat_1, reseat_to_string)
8918 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8919 correctly. Don't assume unibyte strings are not bidi-reordered.
8920 (compute_display_string_pos)
8921 (compute_display_string_end): Fix handling the case of C string.
8922 (push_it, pop_it): Save and restore from_disp_prop_p.
8923 (handle_single_display_spec, push_display_prop): Set the
8924 from_disp_prop_p flag.
8925 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8926 (pop_it): Call iterate_out_of_display_property only if we are
8927 popping after iteration over a string that came from a display
8928 property. Fix a typo in popping stretch info. Add an assertion
8929 for verifying that the iterator position is in sync with the bidi
8930 iterator.
8931 (handle_single_display_spec, get_overlay_strings_1)
8932 (push_display_prop): Fix initialization of paragraph direction for
8933 string when that of the parent object is not yet determined.
8934 (reseat_1): Call bidi_init_it to resync the bidi
8935 iterator with IT's position. (Bug#7616)
8936 (find_row_edges): If ROW->start.pos gives position
8937 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8938 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8939 Reset the from_disp_prop_p flag.
8940 (SAVE_IT, RESTORE_IT): New macros.
8941 (pos_visible_p, face_before_or_after_it_pos)
8942 (back_to_previous_visible_line_start)
8943 (move_it_in_display_line_to, move_it_in_display_line)
8944 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8945 (try_scrolling, redisplay_window, display_line): Use them when
8946 saving a temporary copy of the iterator and restoring it back.
8947 (back_to_previous_visible_line_start, reseat_1)
8948 (init_iterator): Empty the bidi cache "stack".
8949 (move_it_in_display_line_to): If iterator ended up at
8950 EOL, but we never saw any buffer positions smaller than
8951 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8952 motion in bidi-reordered lines.
8953 (move_it_in_display_line_to): Record prev_method and prev_pos
8954 immediately before the call to set_iterator_to_next. Fixes cursor
8955 motion in bidi-reordered lines with stretch glyphs and strings
8956 displayed in margins. (Bug#8133) (Bug#8867)
8957 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8958 TO_CHARPOS.
640c8776
SM
8959 (pos_visible_p): Support positions in bidi-reordered lines.
8960 Save and restore bidi cache.
0bb23927
EZ
8961
8962 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8963 (bidi_paragraph_info): Delete unused struct.
8964 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8965 (bidi_cache_start): New variable.
8966 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8967 to zero.
8968 (bidi_cache_fetch_state, bidi_cache_search)
8969 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8970 (bidi_cache_find, bidi_peek_at_next_level)
8971 (bidi_level_of_next_char, bidi_find_other_level_edge)
8972 (bidi_move_to_visually_next): Compare cache index with
8973 bidi_cache_start rather than with zero.
8974 (bidi_fetch_char): Accept new argument STRING; all callers
8975 changed. Support iteration over a string. Support strings with
8976 display properties. Support unibyte strings. Fix the type of
8977 `len' according to what STRING_CHAR_AND_LENGTH expects.
8978 (bidi_paragraph_init, bidi_resolve_explicit_1)
8979 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8980 (bidi_level_of_next_char, bidi_move_to_visually_next):
8981 Support iteration over a string.
0bb23927
EZ
8982 (bidi_set_sor_type, bidi_resolve_explicit_1)
8983 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8984 can now be zero (for strings); special values 0 and -1 were
8985 changed to -1 and -2, respectively.
8986 (bidi_char_at_pos): New function.
8987 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8988 Call it instead of FETCH_MULTIBYTE_CHAR.
8989 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8990 initialized to valid values.
8991 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8992 values.
8993 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8994 the test for valid cached positions. Fix the logic for looking up
8995 the sentinel state in the cache. GCPRO the Lisp string we are
8996 iterating.
8997 (bidi_push_it, bidi_pop_it): New functions.
8998 (bidi_initialize): Initialize the bidi cache start stack pointer.
8999 (bidi_cache_ensure_space): New function, refactored from part of
9000 bidi_cache_iterator_state. Don't assume the required size is just
9001 one BIDI_CACHE_CHUNK away.
9002 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9003 (bidi_count_bytes, bidi_char_at_pos): New functions.
9004 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9005 always valid if bidi_cache_idx is valid.
9006 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9007 is valid if it's going to be used.
9008 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9009 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9010 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9011 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9012 (bidi_find_other_level_edge, bidi_cache_start_stack):
9013 All variables related to cache indices are now EMACS_INT.
c965adc5 9014
0bb23927
EZ
9015 * dispextern.h (struct bidi_string_data): New structure.
9016 (struct bidi_it): New member `string'. Make flag members be 1-bit
9017 fields, and put them last in the struct.
640c8776
SM
9018 (compute_display_string_pos, compute_display_string_end):
9019 Update prototypes.
0bb23927
EZ
9020 (bidi_push_it, bidi_pop_it): Add prototypes.
9021 (struct iterator_stack_entry): New members bidi_p,
9022 paragraph_embedding, and from_disp_prop_p.
9023 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9024 (bidi_shelve_cache, bidi_unshelve_cache):
9025 Declare prototypes.
0bb23927
EZ
9026
9027 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9028 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9029 and vector-like objects.
9030
9031 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9032 cache around display iteration.
9033
9034 * window.c (Fwindow_end, window_scroll_pixel_based)
9035 (displayed_window_lines, Frecenter): Save and restore the bidi
9036 cache around display iteration.
9037
3bbd2265
LMI
90382011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9039
9040 * editfns.c (Fdelete_region): Clarify the use of the named
9041 parameters (bug#6788).
9042
adc47434
MR
90432011-07-14 Martin Rudalics <rudalics@gmx.at>
9044
9045 * indent.c (Fvertical_motion): Set and restore w->pointm when
9046 saving and restoring the window's buffer (Bug#9006).
9047
837c31f8
LMI
90482011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9049
9050 * editfns.c (Fstring_to_char): Clarify just what is returned
9051 (bug#6576). Text by Eli Zaretskii.
9052
ac389d0c
JB
90532011-07-13 Juanma Barranquero <lekktu@gmail.com>
9054
9055 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9056
0be0ce47
EZ
90572011-07-13 Eli Zaretskii <eliz@gnu.org>
9058
9059 * buffer.c (mmap_find): Fix a typo.
9060
cd18e7e3
JB
90612011-07-13 Johan Bockgård <bojohan@gnu.org>
9062
9063 Fix execution of x selection hooks.
9064 * xselect.c (Qx_lost_selection_functions)
9065 (Qx_sent_selection_functions): New vars.
9066 (syms_of_xselect): DEFSYM them.
9067 (x_handle_selection_request): Pass Qx_sent_selection_functions
9068 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9069 (x_handle_selection_clear,x_clear_frame_selections):
9070 Pass Qx_lost_selection_functions rather than
9071 Vx_lost_selection_functions to Frun_hook_with_args.
9072
47ea7f44
PE
90732011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9074
ac389d0c 9075 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9076 The old code sometimes used this field without initializing it.
9077
47ea7f44
PE
9078 * alloc.c (gc_sweep): Don't read past end of array.
9079 In theory, the old code could also have corrupted Emacs internals,
9080 though it'd be very unlikely.
9081
bc985c87
AS
90822011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9083
9084 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9085 argument. (Bug#4026)
bc985c87 9086
0cf34688
LMI
90872011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9088
b3dadd76
LMI
9089 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9090 key" (bug#4257).
9091
0cf34688
LMI
9092 * window.c (Fset_window_start): Doc fix (bug#4199).
9093 (Fset_window_hscroll): Ditto.
9094
270768cd
PE
90952011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9096
077e3dda 9097 Fix minor new problems caught by GCC 4.6.1.
270768cd 9098 * term.c (init_tty): Remove unused local.
490011a6 9099 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9100 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9101 not used otherwise.
270768cd 9102
b1f58454
CY
91032011-07-12 Chong Yidong <cyd@stupidchicken.com>
9104
9105 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9106
22b9578d
LMI
91072011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9108
6e70ab07
LMI
9109 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9110 are the mini-buffer and the echo area (bug#3320).
9111
22b9578d
LMI
9112 * term.c (init_tty): Remove support for supdup, c10 and perq
9113 terminals, which are no longer supported (bug#1482).
9114
8974cc9f
JB
91152011-07-10 Johan Bockgård <bojohan@gnu.org>
9116
9117 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9118
a560d974
JD
91192011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9120
9121 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9122 for non-popups (Bug#3642).
9123
1dae0f0a
AS
91242011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9125
268c2c36 9126 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9127 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9128 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9129 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9130 * data.c (fmod): Likewise.
9131 * dispnew.c (swap_glyphs_in_rows): Likewise.
9132 * emacs.c (memory_warning_signal): Likewise.
9133 * floatfns.c (float_error): Likewise.
9134 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9135 (otf_open, font_otf_capability, generate_otf_features)
9136 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9137 Likewise.
9138 * image.c (pbm_read_file): Likewise.
9139 * indent.c (string_display_width): Likewise.
9140 * intervals.c (check_for_interval, search_for_interval)
9141 (inc_interval_count, count_intervals, root_interval)
9142 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9143 * lread.c (defalias): Likewise.
268c2c36 9144 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9145 * regex.c (set_image_of_range_1, set_image_of_range)
9146 (regex_grow_registers): Likewise.
9147 * sysdep.c (strerror): Likewise.
9148 * termcap.c (valid_filename_p, tprint, main): Likewise.
9149 * tparam.c (main): Likewise.
9150 * unexhp9k800.c (run_time_remap, save_data_space)
9151 (update_file_ptrs, read_header, write_header, calculate_checksum)
9152 (copy_file, copy_rest, display_header): Likewise.
9153 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9154 Likewise.
9155 * xdisp.c (check_it): Likewise.
9156 * xfaces.c (register_color, unregister_color, unregister_colors):
9157 Likewise.
9158 * xfns.c (print_fontset_result): Likewise.
9159 * xrdb.c (member, fatal, main): Likewise.
9160
99033785
PE
91612011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9162
9163 Fix minor problems found by static checking (Bug#9031).
9164 * chartab.c (char_table_set_range, map_sub_char_table):
9165 Remove unused locals.
9166 (uniprop_table): Now static.
9167 * composite.c (_work_char): Remove unused static var.
9168
9cb2ac56
JB
91692011-07-09 Juanma Barranquero <lekktu@gmail.com>
9170
9171 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9172
f25661f0
JD
91732011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9174
9175 * gtkutil.c (qttip_cb): Remove code without function.
9176
8278c4fe
EZ
91772011-07-09 Eli Zaretskii <eliz@gnu.org>
9178
9179 * w32.c (pthread_sigmask): New stub.
9180
1692ae2d 91812011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9182
8a6ebd58 9183 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9184 sigprocmask is portable only for single-threaded applications, and
9185 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9186 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9187 (LIBES): Use it.
9188 * callproc.c (Fcall_process):
9189 * process.c (create_process):
9190 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9191 Use pthread_sigmask, not sigprocmask.
123403e4 9192
1b854618
JD
91932011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9194
9195 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9196 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9197 wrong (Bug#8591).
9198
3fe4b549
JD
91992011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9200
0ce7e563
JD
9201 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9202 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9203 (xg_hide_tooltip): Fix comment.
9204
3fe4b549
JD
9205 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9206 in registerServicesMenuSendTypes.
9207 (validRequestorForSendType): Don't check ns_return_types.
9208
9209 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9210 ns_return_type.
9211
5df75e47
JR
92122011-07-08 Jason Rumney <jasonr@gnu.org>
9213
22610910
JR
9214 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9215 SH_SHOW for hidden windows (Bug#5482).
9216
5df75e47
JR
9217 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9218 frame struct members of non-existent frames (Bug#6284).
9219
699c10bd
JD
92202011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9221
4393663b
JD
9222 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9223 variable firstTime not needed on OSX >= 10.6.
9224 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9225 >= 10.5. Use setKnobProportion, setDoubleValue.
9226
9227 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9228 (MAC_OS_X_VERSION_10_5): Define if not defined.
9229 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9230 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9231 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9232
9233 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9234 cString and lossyCString on OSX >= 10.4.
4393663b 9235
58179cce 9236 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9237 sizeToFit on OSX >= 10.2.
9238
9239 * nsimage.m (allocInitFromFile): Don't use deprecated method
9240 bestRepresentationForDevice on OSX >= 10.6.
9241
9242 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9243 to avoid warning.
9244
9245 * emacs.c: Declare unexec_init_emacs_zone.
9246
a63e0781
JD
9247 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9248
699c10bd
JD
9249 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9250
9251 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9252 on svcsMenu (Bug#8842).
9253
9254 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9255 ns_return_types.
9256 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9257
9258 * nsterm.m (QUTF8_STRING): Declare.
9259 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9260 (validRequestorForSendType): Return type is (id).
9261 Change indexOfObjectIdenticalTo to indexOfObject.
9262 Check if we have local selection before returning self (Bug#8842).
9263 (writeSelectionToPasteboard): Put local selection into paste board
9264 if we have a local selection (Bug#8842).
9265 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9266
9267 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9268 (ns_get_local_selection): Declare.
9269
54e10184
LMI
92702011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9271
9888ff71
LMI
9272 * keymap.c (describe_map_tree): Don't insert a double newline at
9273 the end of the buffer (bug#1169) and return whether we inserted
9274 something.
9275
54e10184
LMI
9276 * callint.c (Fcall_interactively): Change "reading args" to
9277 "providing args" to try to clarify what it does (bug#1010).
9278
15fa4783
KH
92792011-07-07 Kenichi Handa <handa@m17n.org>
9280
9281 * composite.c (composition_compute_stop_pos): Ignore a static
9282 composition starting before CHARPOS (Bug#8915).
9283
9284 * xdisp.c (handle_composition_prop): Likewise.
9285
a8815b00
EZ
92862011-07-07 Eli Zaretskii <eliz@gnu.org>
9287
9288 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9289 (Bug#9015)
9290
ef7b981d 92912011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9292
9293 * character.h (unicode_category_t): New enum type.
9294
9295 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9296 (Qchar_code_property_table): New variable.
9297 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9298 (UNIPROP_COMPRESSED_FORM_P): New macros.
9299 (char_table_ascii): Uncompress the compressed values.
9300 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9301 Uncompress the compressed values.
ac389d0c 9302 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9303 (char_table_ref_and_range): Uncompress the compressed values.
9304 (sub_char_table_set): New arg is_uniprop. Callers changed.
9305 Uncompress the compressed values.
9306 (sub_char_table_set_range): Args changed. Callers changed.
9307 (char_table_set_range): Adjuted for the above change.
9308 (map_sub_char_table): Delete args default_val and parent. Add arg
9309 top. Give decoded values to a Lisp function.
640c8776 9310 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9311 values to a Lisp function. Gcpro more variables.
9312 (uniprop_table_uncompress)
9313 (uniprop_decode_value_run_length): New functions.
9314 (uniprop_decoder, uniprop_decoder_count): New variables.
9315 (uniprop_get_decoder, uniprop_encode_value_character)
9316 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9317 New functions.
9318 (uniprop_encoder, uniprop_encoder_count): New variables.
9319 (uniprop_get_encoder, uniprop_table)
9320 (Funicode_property_table_internal, Fget_unicode_property_internal)
9321 (Fput_unicode_property_internal): New functions.
9322 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9323 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9324 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9325 char-code-property-alist.
9326
640c8776 9327 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9328 Vunicode_category_table.
9329
640c8776 9330 * font.c (font_range): Adjust for the change of
c805dec0
KH
9331 Vunicode_category_table.
9332
76b397fb
DN
93332011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9334
9335 * m/iris4d.h: Remove file, move contents ...
9336 * s/irix6-5.h: ... here.
9337
22b4128e
PE
93382011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9339
9340 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9341 * alloc.c (mark_buffer):
9342 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9343 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9344 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9345 This isn't true in general, and it's particularly not true
9346 if Emacs is configured with --with-wide-int.
9347 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9348 New macros, used in the buffer.c change.
9349
869795d6
JD
93502011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9351
9352 * xsettings.c: Use both GConf and GSettings if both are available.
9353 (store_config_changed_event): Add comment.
9354 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9355 (store_tool_bar_style_changed): New functions.
5e617bc2 9356 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9357 (struct xsettings): Move font inside HAVE_XFT.
9358 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9359 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9360 Move inside HAVE_XFT.
640c8776 9361 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9362 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9363 also.
9364 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9365 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9366 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9367 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9368 (parse_settings): Move check for font inside HAVE_XFT.
9369 (read_settings, apply_xft_settings): Add comment.
9370 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9371 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9372 call store_font_name_changed.
9373 (xft_settings_event): Add comment.
9374 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9375 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9376 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9377 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9378 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9379 (xsettings_get_system_font, xsettings_get_system_normal_font):
9380 Add comment.
869795d6 9381
d8ed26bd
PE
93822011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9383
9384 Random fixes. E.g., (random) never returned negative values.
9385 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9386 subseconds part to the entropy, as that's a bit more random.
9387 Prefer signed to unsigned, since the signedness doesn't matter and
9388 in general we prefer signed. When given a limit, use a
9389 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9390 latter isn't right if USE_2_TAGS_FOR_INTS.
9391 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9392 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9393
cabf1cac
SM
93942011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9395
9396 * textprop.c (text_property_stickiness):
9397 Obey Vtext_property_default_nonsticky.
9398 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9399 * w32fns.c (syms_of_w32fns):
9400 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9401
6e9b2be9
PE
94022011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9403
9404 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9405 This is more efficient than Ffile_directory_p and avoids a minor race.
9406
90186c68
LMI
94072011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9408
7c301272
LMI
9409 * buffer.c (Foverlay_put): Say what the return value is
9410 (bug#7835).
9411
c4f2d8d4
LMI
9412 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9413 is a directory before asking whether to use the file name
9414 (bug#7564).
ad637907
LMI
9415 (barf_or_query_if_file_exists): Make the "File is a directory"
9416 error be more correct.
c4f2d8d4 9417
90186c68
LMI
9418 * fns.c (Frequire): Remove the mention of the .gz files, since
9419 that's installation-specific, but keep the mention of
9420 `get-load-suffixes'.
9421
da64016e
PE
94222011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9423
9424 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9425 Report string overflow if the output is too long.
9426
7d47b580
JB
94272011-07-04 Juanma Barranquero <lekktu@gmail.com>
9428
a555cb87
JB
9429 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9430 (syms_of_gnutls): Remove duplicate DEFSYM for
9431 Qgnutls_bootprop_verify_hostname_error, an error for
9432 Qgnutls_bootprop_verify_error (which is no longer used).
9433
7d47b580
JB
9434 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9435 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9436 Also (re)move comments that are misplaced or no longer relevant.
9437
1e49bfab
LMI
94382011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9439
9440 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9441
1485f4c0
CY
94422011-07-03 Chong Yidong <cyd@stupidchicken.com>
9443
9444 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9445 and background color parameters if they have been changed.
9446
a9ab721e
LMI
94472011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9448
9449 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9450
cf7cff57
PE
94512011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9452
2e13213d
PE
9453 * xsettings.c (SYSTEM_FONT): Define only when used.
9454 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9455
cf7cff57
PE
9456 * keymap.c (access_keymap_1): Now static.
9457
7a8e04f7
CY
94582011-07-02 Chong Yidong <cyd@stupidchicken.com>
9459
9460 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9461 leave any prefix arg for the up event (Bug#1586).
9462
61352f62
LMI
94632011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9464
69bb1ef7
LMI
9465 * lread.c (syms_of_lread): Mention single symbols defined by
9466 `defvar' or `defconst' (bug#7154).
9467
61352f62 9468 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9469 (Frequire): Mention get-load-suffixes.
61352f62 9470
28545e04
MR
94712011-07-02 Martin Rudalics <rudalics@gmx.at>
9472
9473 * window.h (window): Remove clone_number slot.
9474 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9475 Remove.
9476 (make_parent_window, make_window, saved_window)
9477 (Fset_window_configuration, save_window_save): Don't deal with
9478 clone numbers.
9479 * buffer.c (Qclone_number): Remove declaration.
9480 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9481
3349e122
SM
94822011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9483
9484 Add multiple inheritance to keymaps.
9485 * keymap.c (Fmake_composed_keymap): New function.
9486 (Fset_keymap_parent): Simplify.
9487 (fix_submap_inheritance): Remove.
9488 (access_keymap_1): New function extracted from access_keymap to handle
9489 embedded parents and handle lists of maps.
9490 (access_keymap): Use it.
9491 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9492 (Fcopy_keymap): Handle embedded parents.
9493 (Fcommand_remapping, define_as_prefix): Simplify.
9494 (Fkey_binding): Simplify.
9495 (syms_of_keymap): Move minibuffer-local-completion-map,
9496 minibuffer-local-filename-completion-map,
9497 minibuffer-local-must-match-map, and
9498 minibuffer-local-filename-must-match-map to Elisp.
9499 (syms_of_keymap): Defsubr make-composed-keymap.
9500 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9501 (parse_menu_item): Trivial simplification.
9502
3279eb87
GM
95032011-07-01 Glenn Morris <rgm@gnu.org>
9504
9505 * Makefile.in (SETTINGS_LIBS): Fix typo.
9506
4550efdf
KI
95072011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9508
9509 * coding.c (Fencode_coding_string): Record the last coding system
9510 used, as the function doc string says (bug#8738).
9511
0949d2b6
JD
95122011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9513
9514 * xsettings.c (store_monospaced_changed): Take new font as arg and
9515 check for change against current_mono_font.
9516 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9517 (emacs_settings_constructor, emacs_settings_get_property)
9518 (emacs_settings_set_property, emacs_settings_class_init)
9519 (emacs_settings_init, gsettings_obj): Remove.
9520 (something_changedCB): New function for HAVE_GSETTINGS.
9521 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9522 with value as argument.
9523 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9524 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9525 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9526 "changed".
9527
9528 * xgselect.c: Add defined (HAVE_GSETTINGS).
9529 (xgselect_initialize): Ditto.
9530
9531 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9532 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9533 xg_select.
9534
bbc6b304
PE
95352011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9536
9537 * eval.c (struct backtrace): Simplify and port the data structure.
9538 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9539 signed bit field, as this assumption is not portable and it makes
9540 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9541 "char debug_on_exit : 1" as this is not portable either; instead,
9542 use the portable "unsigned int debug_on_exit : 1". Remove unused
9543 member evalargs. Remove obsolete comments about cc bombing out.
9544
9851bfc5
JD
95452011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9546
51bb811f 9547 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9548 Let HAVE_GSETTINGS override HAVE_GCONF.
9549 (store_monospaced_changed): New function.
9550 (EMACS_SETTINGS): A new type derived from GObject to handle
9551 GSettings notifications.
9552 (emacs_settings_constructor, emacs_settings_get_property)
9553 (emacs_settings_set_property, emacs_settings_class_init):
9554 New functions.
9555 (gsettings_client, gsettings_obj): New variables.
9556 (GSETTINGS_SCHEMA): New define.
9557 (something_changedCB): Call store_monospaced_changed.
9558 (init_gsettings): New function.
9559 (xsettings_initialize): Call init_gsettings.
9560 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9561 to NULL.
9562
640c8776 9563 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9564 GCONF_CFLAGS/LIBS.
9565
5386012d
MR
95662011-06-29 Martin Rudalics <rudalics@gmx.at>
9567
9568 * window.c (resize_root_window, grow_mini_window)
9569 (shrink_mini_window): Rename Qresize_root_window to
9570 Qwindow_resize_root_window and Qresize_root_window_vertically to
9571 Qwindow_resize_root_window_vertically.
9572
f13e0b08
PE
95732011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9574
9575 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9576
94515237
JB
95772011-06-27 Juanma Barranquero <lekktu@gmail.com>
9578
9579 * makefile.w32-in: Redesign dependencies so they reflect more
9580 clearly which files are directly included by each source file,
9581 and not through other includes.
9582
e43b6e43
MR
95832011-06-27 Martin Rudalics <rudalics@gmx.at>
9584
9585 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9586 (sort_overlays, overlay_strings): When an overlay's clone number
9587 matches the window's clone number process the overlay even if
9588 the overlay's window property doesn't match the current window.
9589
d68443dc
MR
9590 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9591 (Fwindow_hchild): Rename to Fwindow_left_child.
9592 (Fwindow_next): Rename to Fwindow_next_sibling.
9593 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9594 (resize_window_check): Rename to window_resize_check.
9595 (resize_window_apply): Rename to window_resize_apply.
9596 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9597 (Fdelete_other_windows_internal, resize_frame_windows)
9598 (Fsplit_window_internal, Fdelete_window_internal)
9599 (grow_mini_window, shrink_mini_window)
9600 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9601
c7e73be5
JD
96022011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9603
9604 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9605 (emacs_fixed_set_min_size): Remove.
9606 (emacs_fixed_new): Take frame as argument.
9607
9608 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9609 (_EmacsFixedPrivate): Remove minwidth/height.
9610 Add struct frame *f.
9611 (emacs_fixed_init): Initialize priv->f.
9612 (get_parent_class, emacs_fixed_set_min_size): Remove.
9613 (emacs_fixed_new): Set priv->f to argument.
9614 (emacs_fixed_get_preferred_width)
9615 (emacs_fixed_get_preferred_height): Use min_width/height from
9616 frames size_hint to set minimum and natural (Bug#8919).
9617 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9618 and use min_width/height from frames size_hint to set
9619 min_width/height (Bug#8919).
9620
9621 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9622 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9623 Fix indentation.
c7e73be5 9624
cf99dcf8
EZ
96252011-06-26 Eli Zaretskii <eliz@gnu.org>
9626
9627 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9628 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9629 called at ZV.
9630
029529ac
CY
96312011-06-26 Chong Yidong <cyd@stupidchicken.com>
9632
9633 * process.c (wait_reading_process_output): Bypass select if
9634 waiting for a cell while ignoring keyboard input, and input is
9635 pending. Suggested by Jan Djärv (Bug#8869).
9636
7a7ef429
PE
96372011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9638
9639 Use gnulib's dup2 module instead of rolling our own.
9640 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9641
11fdef7d 96422011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9643
9644 * dispnew.c (scrolling_window): Before scrolling, turn off a
9645 mouse-highlight in the window being scrolled.
9646
cd3520a4
JB
96472011-06-24 Juanma Barranquero <lekktu@gmail.com>
9648
9649 Move DEFSYM to lisp.h and use everywhere.
9650
9651 * character.h (DEFSYM): Move declaration...
9652 * lisp.h (DEFSYM): ...here.
9653
9654 * gnutls.c:
9655 * minibuf.c:
9656 * w32menu.c:
9657 * w32proc.c:
9658 * w32select.c: Don't include character.h.
9659
9660 * alloc.c (syms_of_alloc):
9661 * buffer.c (syms_of_buffer):
9662 * bytecode.c (syms_of_bytecode):
9663 * callint.c (syms_of_callint):
9664 * casefiddle.c (syms_of_casefiddle):
9665 * casetab.c (init_casetab_once):
9666 * category.c (init_category_once, syms_of_category):
9667 * ccl.c (syms_of_ccl):
9668 * cmds.c (syms_of_cmds):
9669 * composite.c (syms_of_composite):
9670 * dbusbind.c (syms_of_dbusbind):
9671 * dired.c (syms_of_dired):
9672 * dispnew.c (syms_of_display):
9673 * doc.c (syms_of_doc):
9674 * editfns.c (syms_of_editfns):
9675 * emacs.c (syms_of_emacs):
9676 * eval.c (syms_of_eval):
9677 * fileio.c (syms_of_fileio):
9678 * fns.c (syms_of_fns):
9679 * frame.c (syms_of_frame):
9680 * fringe.c (syms_of_fringe):
9681 * insdel.c (syms_of_insdel):
9682 * keymap.c (syms_of_keymap):
9683 * lread.c (init_obarray, syms_of_lread):
9684 * macros.c (syms_of_macros):
9685 * msdos.c (syms_of_msdos):
9686 * print.c (syms_of_print):
9687 * process.c (syms_of_process):
9688 * search.c (syms_of_search):
9689 * sound.c (syms_of_sound):
9690 * syntax.c (init_syntax_once, syms_of_syntax):
9691 * terminal.c (syms_of_terminal):
9692 * textprop.c (syms_of_textprop):
9693 * undo.c (syms_of_undo):
9694 * w32.c (globals_of_w32):
9695 * window.c (syms_of_window):
9696 * xdisp.c (syms_of_xdisp):
9697 * xfaces.c (syms_of_xfaces):
9698 * xfns.c (syms_of_xfns):
9699 * xmenu.c (syms_of_xmenu):
9700 * xsettings.c (syms_of_xsettings):
9701 * xterm.c (syms_of_xterm): Use DEFSYM.
9702
4228cf16
TZ
97032011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9704
cd3520a4 9705 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9706
7fcccf1e
PE
97072011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9708
7efb4e0e
PE
9709 Integer and buffer overflow fixes (Bug#8873).
9710
ff5844ad
PE
9711 * print.c (printchar, strout): Check for string overflow.
9712 (PRINTPREPARE, printchar, strout):
9713 Don't set size unless allocation succeeds.
9714
90532f02
PE
9715 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9716 for sizes. Check for string overflow more accurately.
9717 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9718
6d84508d
PE
9719 * macros.c: Integer and buffer overflow fixes.
9720 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9721 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9722 Use ptrdiff_t, not int, for sizes.
9723 Don't increment bufsize until after realloc succeeds.
9724 Check for size-calculation overflow.
9725 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9726
437b2cb4
PE
9727 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9728
8b9ac8b4
PE
9729 * lread.c: Integer overflow fixes.
9730 (read_integer): Radix is now EMACS_INT, not int,
9731 to improve quality of diagnostics for out-of-range radices.
9732 Calculate buffer size correctly for out-of-range radices.
9733 (read1): Check for integer overflow in radices, and in
9734 read-circle numbers.
82cb60d3
PE
9735 (read_escape): Avoid int overflow.
9736 (Fload, openp, read_buffer_size, read1)
9737 (substitute_object_recurse, read_vector, read_list, map_obarray):
9738 Use ptrdiff_t, not int, for sizes.
9739 (read1): Use EMACS_INT, not int, for sizes.
20270765 9740 Check for size overflow.
8b9ac8b4 9741
7fcccf1e
PE
9742 * image.c (cache_image): Check for size arithmetic overflow.
9743
bfbbd7e7
PE
9744 * lread.c: Integer overflow issues.
9745 (saved_doc_string_size, saved_doc_string_length)
9746 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9747 Now ptrdiff_t, not int.
9748 (read1): Don't assume doc string length fits in int. Check for
9749 out-of-range doc string lengths.
9750 (read_list): Don't assume file position fits in int.
39019e54 9751 (read_escape): Check for hex character overflow.
bfbbd7e7 9752
4e323265
LL
97532011-06-22 Leo Liu <sdl.web@gmail.com>
9754
9755 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9756 Move to minibuffer.el.
9757
85fece3e
PE
97582011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9759
20b84ce9 9760 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9761 The following patches are for when GLYPH_DEBUG && !XASSERT.
9762 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9763 * dispnew.c (flush_stdout):
9764 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9765 Mark as externally visible.
9766 * dispnew.c (check_window_matrix_pointers): Now static.
9767 * dispnew.c (window_to_frame_vpos):
9768 * xfns.c (unwind_create_frame):
9769 * xterm.c (x_check_font): Remove unused local.
9770 * scroll.c (CHECK_BOUNDS):
9771 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9772 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9773 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9774 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9775 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9776 Now static.
9777 (debug_method_add): Use va_list and vsprintf rather than relying
9778 on undefined behavior with wrong number of arguments.
9779 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9780 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9781 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9782 since we're not interested in debugging glyphs with old libraries.
9783 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9784 GCC 4.6.0's static checking.
9785
0766b489
PE
97862011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9787
31fd4b32
PE
9788 Integer overflow and signedness fixes (Bug#8873).
9789 A few related buffer overrun fixes, too.
9790
b79e8648
PE
9791 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9792
0766b489
PE
9793 * dispextern.h (struct face.stipple):
9794 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9795 (x_bitmap_mask, x_allocate_bitmap_record)
9796 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9797 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9798 (x_create_bitmap_from_xpm_data):
9799 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9800 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9801 (.bitmaps_last):
9802 * xfaces.c (load_pixmap):
9803 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9804 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9805 (.bitmaps_last, struct x_output.icon_bitmap):
9806 Use ptrdiff_t, not int, for bitmap indexes.
9807 (x_allocate_bitmap_record): Check for size overflow.
9808 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9809
b081724f
PE
9810 Use ptrdiff_t, not int, for overlay counts.
9811 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9812 * editfns.c (overlays_around, get_pos_property):
9813 * textprop.c (get_char_property_and_overlay):
9814 * xdisp.c (next_overlay_change, note_mouse_highlight):
9815 * xfaces.c (face_at_buffer_position):
21514da7
PE
9816 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9817 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9818 (Fnext_overlay_change, Fprevious_overlay_change)
9819 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9820 Use ptrdiff_t, not int, for sizes.
21514da7 9821 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9822
3de73e5e
PE
9823 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9824
2606c57b
PE
9825 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9826 (x_session_initialize): Do not assume string length fits in int.
9827
aaafe47a
PE
9828 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9829 This is unlikely, but can occur if DPI is outlandish.
9830
2674ddc8 9831 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9832 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9833
28154962
PE
9834 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9835 * xrdb.c (magic_file_p, search_magic_path):
9836 Omit last arg SUFFIX; it was always 0. All callers changed.
9837 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9838
7de51af5
PE
9839 * xfont.c (xfont_match): Avoid need for strlen.
9840
25ed6cc3
PE
9841 * xfns.c: Don't assume strlen fits in int.
9842 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9843
4eab31dd
PE
9844 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9845 not unsigned long, as we prefer signed integers. All callers changed.
9846 Detect integer overflow in repeat count.
9847 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9848 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9849
171e2a58
PE
9850 * termcap.c: Don't assume sizes fit in int and never overflow.
9851 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9852 (gobble_line): Check for size-calculation overflow.
9853
ad39faca 9854 * minibuf.c (Fread_buffer):
6e5bb2dc 9855 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9856 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9857 Don't assume string length fits in int.
9858
52c61c22 9859 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9860 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9861
b5b8c9e5
PE
9862 * font.c: Don't assume string length fits in int.
9863 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9864 Use ptrdiff_t, not int.
ccd6111c
PE
9865 (font_intern_prop): Don't assume string length fits in int.
9866 Don't assume integer property fits in fixnum.
9867 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9868
882f0d81 9869 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9870 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9871 Reformulate so as not to need the command string.
9872 Invoke gzip -cd rather than gunzip, as it's more portable.
9873 (lock_info_type, lock_file_1, lock_file):
9874 Don't assume pid_t and time_t fit in unsigned long.
9875 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9876 (current_lock_owner): Prefer signed type for sizes.
9877 Use memcpy, not strncpy, where memcpy is what is really wanted.
9878 Don't assume (via atoi) that time_t and pid_t fit in int.
9879 Check for time_t and/or pid_t out of range, e.g., via a network share.
9880 Don't alloca where an auto var works fine.
9881
93f4cf88
PE
9882 * fileio.c: Fix some integer overflow issues.
9883 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9884 Don't assume string length fits in int.
9885 (directory_file_name): Don't assume string length fits in long.
9886 (make_temp_name): Don't assume pid fits in int, or that its print
9887 length is less than 20.
9888
f3e92b69
PE
9889 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9890
1bfdaf10
PE
9891 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9892
35016e9a
PE
9893 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9894
3d1e65a1
PE
9895 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9896 We prefer signed integers, even for size calculations.
9897
0b963a93
PE
9898 * emacs.c: Don't assume string length fits in 'int'.
9899 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9900 (main): Don't invoke strlen when not needed.
9901
573f4b54
PE
9902 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9903 (XD_DEBUG_MESSAGE): Don't waste a byte.
9904
989f33ba
PE
9905 * callproc.c (getenv_internal_1, getenv_internal)
9906 (Fgetenv_internal):
965d34eb
PE
9907 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9908
e4d29b33
PE
9909 * lread.c (invalid_syntax): Omit length argument.
9910 All uses changed. This doesn't fix a bug, but it simplifies the
9911 code away from its former Hollerith-constant appearance, and it's
9912 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9913 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9914
eb49b136
PE
9915 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9916 This didn't break anything, but it didn't help either.
9917 It's confusing to put a bogus integer in a place where the actual
9918 value does not matter.
9f62aeb1 9919 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9920 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9921
15375a22
PE
9922 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9923 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9924 implementation.
b61cc01c
PE
9925 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9926 We prefer signed types, and the value cannot exceed the EMACS_INT
9927 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9928 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9929 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9930 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9931
53b2623d
PE
9932 * indent.c (sane_tab_width): New function.
9933 (current_column, scan_for_column, Findent_to, position_indentation)
9934 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9935 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9936
51cab52b 9937 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9938
f2ed8a70
PE
9939 * lisp.h (lint_assume): New macro.
9940 * composite.c (composition_gstring_put_cache):
9941 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9942
abe80cc6
PE
9943 * editfns.c, insdel.c:
9944 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9945
b02c740e
PE
9946 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9947
ebc96716
PE
9948 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9949
b4e50fa0 9950 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9951 Use much-faster test for byte-length change.
311d5d7c 9952 Don't assume string byte-length fits in 'int'.
a4cf38e4 9953 Check that character arg fits in 'int'.
85461888 9954 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9955
c0c1ee9f
PE
9956 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9957
a498d7f4
PE
9958 * fns.c (concat): Catch string overflow earlier.
9959 Do not rely on integer wraparound.
9960
51cab52b
PE
9961 * dispextern.h (struct it.overlay_strings_charpos)
9962 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9963 * xdisp.c (forward_to_next_line_start)
9964 (back_to_previous_visible_line_start)
9965 (reseat_at_next_visible_line_start, next_element_from_buffer):
9966 Don't arbitrarily truncate the value of 'selective' to int.
9967
76031fad
PE
9968 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9969
5eb55db9
PE
9970 * composite.c: Don't truncate sizes to 'int'.
9971 (composition_gstring_p, composition_reseat_it)
9972 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9973 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9974 not EMACS_UINT, for indexes.
5eb55db9 9975
0703a717
PE
9976 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9977
d6202519
PE
9978 * buffer.c: Include <verify.h>.
9979 (struct sortvec.priority, struct sortstr.priority):
8961a454 9980 Now EMACS_INT, not int.
c20998a7 9981 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9982 (struct sortstr.size, record_overlay_string)
9983 (struct sortstrlist.size, struct sortlist.used):
9984 Don't truncate size to int.
9985 (record_overlay_string): Check for size-calculation overflow.
d6202519 9986 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9987
d5a19415
JM
99882011-06-22 Jim Meyering <meyering@redhat.com>
9989
029529ac 9990 Don't leak an XBM-image-sized buffer
d5a19415
JM
9991 * image.c (xbm_load): Free the image buffer after using it.
9992
a9041e6c
PE
99932011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9994
9995 Port to Sun C.
9996 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9997 that Sun C diagnosed.
9998 * fns.c (secure_hash): Fix pointer signedness issue.
9999 * intervals.c (static_offset_intervals): New function.
10000 (offset_intervals): Use it.
10001
7f3f739f
LL
100022011-06-21 Leo Liu <sdl.web@gmail.com>
10003
10004 * deps.mk (fns.o):
10005 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10006 sha512.h.
10007
10008 * fns.c (secure_hash): Rename from crypto_hash_function and change
10009 the first arg to accept symbols.
5b66d427 10010 (Fsecure_hash): New primitive.
7f3f739f
LL
10011 (syms_of_fns): New symbols.
10012
76147d94
DD
100132011-06-20 Deniz Dogan <deniz@dogan.se>
10014
10015 * process.c (Fset_process_buffer): Clarify return value in
10016 docstring.
10017
7d7d0045
CY
100182011-06-18 Chong Yidong <cyd@stupidchicken.com>
10019
10020 * dispnew.c (add_window_display_history): Use BVAR.
10021
10022 * xdisp.c (debug_method_add): Use BVAR.
10023 (check_window_end, dump_glyph_matrix, dump_glyph)
10024 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10025
10026 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10027 Likewise.
10028
10029 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10030 check till after the cache is created in init_frame_faces.
10031
ff2bc410
SM
100322011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10033
10034 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10035
28177add
PE
100362011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10037
dd3482fe
PE
10038 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10039 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10040 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10041
393d71f3 10042 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10043 * fileio.c (Finsert_file_contents):
10044 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10045 Remove the old (too-loose) buffer overflow checks.
10046 They weren't needed, since make_gap checks for buffer overflow.
10047 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10048 The old code merely checked for Emacs fixnum overflow, and relied
10049 on undefined (wraparound) behavior. The new code avoids undefined
10050 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10051
2e6813b0 10052 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10053 Tune. Don't use wider integers than needed. Don't use alloca.
10054 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10055
599a9e4f
PE
10056 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10057
99561444
PE
10058 * insdel.c, lisp.h (buffer_overflow): New function.
10059 (insert_from_buffer_1, replace_range, replace_range_2):
10060 * insdel.c (make_gap_larger):
10061 * editfns.c (Finsert_char):
10062 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10063
28177add
PE
10064 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10065
e69dafad
PE
100662011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10067
4baa020d 10068 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10069
b1c46f02
PE
10070 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10071 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10072
e69dafad
PE
10073 * fileio.c: Don't assume EMACS_INT fits in off_t.
10074 (emacs_lseek): New static function.
10075 (Finsert_file_contents, Fwrite_region): Use it.
10076 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10077
566684ea
PE
10078 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10079
e6966cd6
PE
10080 * fns.c: Don't overflow int when computing a list length.
10081 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10082 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10083 truncation on 64-bit hosts. Check for QUIT every
10084 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10085 faster and is responsive enough.
10086 (Flength): Report an error instead of overflowing an integer.
10087 (Fsafe_length): Return a float if the value is not representable
10088 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10089 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10090 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10091
dd0b0efb
PE
10092 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10093 (header_size, word_size): New constants.
10094 (allocate_vectorlike): Don't check size overflow here.
10095 (allocate_vector): Check it here instead, since this is the only
10096 caller of allocate_vectorlike that could cause overflow.
10097 Check that the new vector's length is representable as a fixnum.
10098
86fe5cfe
PE
10099 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10100 The previous code was bogus. For example, next_almost_prime (32)
10101 returned 39, which is undesirable as it is a multiple of 3; and
10102 next_almost_prime (24) returned 25, which is a multiple of 5 so
10103 why was the code bothering to check for multiples of 7?
10104
80e88859
PE
10105 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10106
4a2f0ad6
PE
10107 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10108
f66c7cf8
PE
10109 Variadic C functions now count arguments with ptrdiff_t.
10110 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10111 Back then I didn't know that the Emacs coding style prefers signed int.
10112 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10113 were being counted with int, which may truncate counts on 64-bit
10114 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10115 * lisp.h (struct Lisp_Subr.function.aMANY)
10116 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10117 Arg counts are now ptrdiff_t, not size_t.
10118 All variadic functions and their callers changed accordingly.
10119 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10120 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10121 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10122 * callint.c (Fcall_interactively): Check arg count for overflow,
10123 to avoid potential buffer overrun. Use signed char, not 'int',
10124 for 'varies' array, so that we needn't bother to check its size
10125 calculation for overflow.
10126 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10127 * eval.c (apply_lambda):
10128 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10129 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10130 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10131
a1759b76
PE
10132 * callint.c (Fcall_interactively): Don't use index var as event count.
10133
d96be9fc
PE
10134 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10135 * mem-limits.h (SIZE): Remove; no longer used.
10136
a690a978 10137 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10138
578c21e6
PE
10139 Remove unnecessary casts.
10140 * xterm.c (x_term_init):
10141 * xfns.c (x_set_border_pixel):
10142 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10143 These aren't needed now that we assume ANSI C.
10144
96f53c6c
PE
10145 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10146 It's more likely to cause problems (due to unsigned overflow)
10147 than to cure them.
10148
83c77d31
PE
10149 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10150
ee2079f1
PE
10151 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10152
6da65536
PE
10153 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10154
7147c4a4
PE
10155 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10156
193e32d9
PE
10157 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10158
e5533da6
PE
10159 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10160
9910e595
PE
10161 GLYPH_CODE_FACE returns EMACS_INT, not int.
10162 * dispextern.h (merge_faces):
10163 * xfaces.c (merge_faces):
01103c44
PE
10164 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10165 Don't assume EMACS_INT fits in int.
9910e595 10166
2638320e
PE
10167 * character.h (CHAR_VALID_P): Remove unused parameter.
10168 * fontset.c, lisp.h, xdisp.c: All uses changed.
10169
045eb8d9
PE
10170 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10171
c1f134b5
PE
10172 * fns.c (concat): Minor tuning based on overflow analysis.
10173 This doesn't fix any bugs. Use int to hold character, instead
10174 of constantly refetching from Emacs object. Use XFASTINT, not
10175 XINT, for value known to be a character. Don't bother comparing
10176 a single byte to 0400, as it's always less.
10177
395fcb93 10178 * floatfns.c (Fexpt):
327eeec8
PE
10179 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10180
abbd3d23
PE
10181 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10182 for characters.
10183
684a03ef
PE
10184 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10185
0fed43f3
PE
10186 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10187 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10188 incorrectly succeed when S was a string, because 4294967386 was
10189 truncated before it was used.
10190
8fd02eb7
PE
10191 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10192 Otherwise, an out-of-range integer could cause undefined behavior
10193 on a 64-bit host.
10194
f8c86b69
PE
10195 * composite.c: Use int, not EMACS_INT, for characters.
10196 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10197 EMACS_INT, for values that are known to be in character range.
10198 This doesn't fix any bugs but is the usual style inside Emacs and
10199 may generate better code on 32-bit machines.
10200
34206dd2
PE
10201 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10202 This is for reasons similar to the recent CHAR_STRING fix.
10203 * charset.c (Fencode_char): Check that character arg is actually
10204 a character. Pass an int to ENCODE_CHAR.
10205 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10206 wider than 'int', as a compile-time check to prevent future regressions
10207 in this area.
10208
c5958d4c 10209 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10210
10211 Make sure a 64-bit char is never passed to CHAR_STRING.
10212 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10213 by silently ignoring the top 32 bits, allowing some values
10214 that were far too large to be valid characters.
10215 * character.h: Include <verify.h>.
10216 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10217 arguments are no wider than unsigned, as a compile-time check
10218 to prevent future regressions in this area.
10219 * data.c (Faset):
01103c44 10220 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10221 (Fsubst_char_in_region):
10222 * fns.c (concat):
10223 * xdisp.c (decode_mode_spec_coding):
10224 Adjust to CHAR_STRING's new requirement.
10225 * editfns.c (Finsert_char, Fsubst_char_in_region):
10226 * fns.c (concat): Check that character args are actually
10227 characters. Without this test, these functions did the wrong
10228 thing with wildly out-of-range values on 64-bit hosts.
10229
d37ca623
PE
10230 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10231 These casts should not be needed on 32-bit hosts, either.
10232 * keyboard.c (read_char):
10233 * lread.c (Fload): Remove casts to unsigned.
10234
ea204efb
PE
10235 * lisp.h (UNSIGNED_CMP): New macro.
10236 This fixes comparison bugs on 64-bit hosts.
10237 (ASCII_CHAR_P): Use it.
10238 * casefiddle.c (casify_object):
01103c44 10239 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10240 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10241 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10242 * dispextern.h (FACE_FROM_ID):
10243 * keyboard.c (read_char): Use UNSIGNED_CMP.
10244
41cb286c
PE
10245 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10246 not to EMACS_INT, to avoid GCC warning.
10247
4a1b9832
PE
10248 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10249
55daad71
PE
10250 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10251 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10252 isn't needed on 32-bit machines.
8f95c75c 10253
01103c44
PE
10254 * buffer.c (Fgenerate_new_buffer_name):
10255 Use EMACS_INT for count, not int.
0ceccced 10256 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10257
10258 * data.c (Qcompiled_function): Now static.
10259
c6f072e7
PE
10260 * window.c (window_body_lines): Now static.
10261
20ce5912
PE
10262 * image.c (gif_load): Rename local to avoid shadowing.
10263
9c4c5f81
PE
10264 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10265 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10266 * alloc.c (make_save_value): Integer argument is now of type
10267 ptrdiff_t, not int.
10268 (mark_object): Use ptrdiff_t, not int.
10269 * lisp.h (pD): New macro.
10270 * print.c (print_object): Use it.
10271
c0c5c8ae
PE
10272 * alloc.c: Use EMACS_INT, not int, to count objects.
10273 (total_conses, total_markers, total_symbols, total_vector_size)
10274 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10275 (total_free_floats, total_floats, total_free_intervals)
10276 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10277 Now EMACS_INT, not int. All uses changed.
10278 (Fgarbage_collect): Compute overall total using a double, so that
10279 integer overflow is less likely to be a problem. Check for overflow
10280 when converting back to an integer.
5a25e253
PE
10281 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10282 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10283 These were 'int' variables that could overflow on 64-bit hosts;
10284 they were never used, so remove them instead of repairing them.
211a0b2a 10285 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10286 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10287 Previously, this ceilinged at INT_MAX, but that doesn't work on
10288 64-bit machines.
e46bb31a 10289 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10290
c78baabf 10291 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10292 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10293 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10294 when a (possibly-narrower) signed value would do just as well.
10295 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10296
c9d624c6
PE
10297 * alloc.c: Catch some string size overflows that we were missing.
10298 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10299 for convenience in STRING_BYTES_MAX.
10300 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10301 The definition here is exact; the one in lisp.h was approximate.
10302 (allocate_string_data): Check for string overflow. This catches
10303 some instances we weren't catching before. Also, it catches
10304 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10305 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10306 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10307
c9d624c6
PE
10308 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10309 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10310 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10311
353032ce
PE
10312 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10313
2bccce07
PE
10314 * alloc.c (Fmake_string): Check for out-of-range init.
10315
0ac30604
SM
103162011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10317
10318 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10319
c195f2de
JD
103202011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10321
10322 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10323 xg_get_default_scrollbar_width.
10324
10325 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10326 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10327 (style_changed_cb): Call update_theme_scrollbar_width and call
10328 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10329 all frames (Bug#8505).
10330 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10331 Call gtk_window_set_resizable if HAVE_GTK3.
10332 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10333 and height if HAVE_GTK3 (Bug#8505).
10334 (scroll_bar_width_for_theme): New variable.
10335 (update_theme_scrollbar_width): New function.
10336 (xg_get_default_scrollbar_width): Move code to
10337 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10338 (xg_initialize): Call update_theme_scrollbar_width.
10339
10340 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10341
10342 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10343
e10ac9f1
MR
103442011-06-12 Martin Rudalics <rudalics@gmx.at>
10345
10346 * frame.c (make_frame): Call other_buffer_safely instead of
10347 other_buffer.
10348
10349 * window.c (temp_output_buffer_show): Call display_buffer with
10350 second argument Vtemp_buffer_show_specifiers and reset latter
10351 immediately after the call.
10352 (Vtemp_buffer_show_specifiers): New variable.
10353 (auto_window_vscroll_p, next_screen_context_lines)
10354 (Vscroll_preserve_screen_position): Remove leading asterisks from
10355 doc-strings.
10356
2d3c217e 103572011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10358
7b7f97e8 10359 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10360 * buffer.c (Qclone_number): Remove for now, as it's unused.
10361 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10362 (record_buffer): Remove unused local.
10363 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10364 (set_frame_buffer_list): Remove; unused.
10365 * frame.h (other_visible_frames): Remove decl.
10366 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10367 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10368 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10369 if HAVE_GPM.
10370 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10371 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10372 Define only if HAVE_GPM.
10373 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10374 (update_hints_inhibit): Remove; never set. All uses removed.
10375 * widgetprv.h (emacsFrameClassRec): Remove decl.
10376 * window.c (delete_deletable_window): Now returns void, since it
10377 wasn't returning anything.
10378 (compare_window_configurations): Remove unused locals.
10379 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10380 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10381 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10382 the same widths as pointers. This follows up on the 2011-05-06 patch.
10383 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10384 * xterm.h: Likewise.
10385 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10386
1384b89e
JB
103872011-06-12 Juanma Barranquero <lekktu@gmail.com>
10388
10389 * makefile.w32-in: Update dependencies.
10390 (LISP_H): Add lib/intprops.h.
10391
1100a63c
CY
103922011-06-11 Chong Yidong <cyd@stupidchicken.com>
10393
10394 * image.c (gif_load): Add animation frame delay to the metadata.
10395 (syms_of_image): Use DEFSYM. New symbol `delay'.
10396
6198ccd0
MR
103972011-06-11 Martin Rudalics <rudalics@gmx.at>
10398
10399 * window.c (delete_deletable_window): Re-add.
10400 (Fset_window_configuration): Rewrite to handle dead buffers and
10401 consequently deletable windows.
10402 (window_tree, Fwindow_tree): Remove. Supply functionality in
10403 window.el.
10404 (compare_window_configurations): Simplify code.
10405
b6e3633c
AS
104062011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10407
1ab0dee5
AS
10408 * image.c (imagemagick_load_image): Fix type mismatch.
10409 (Fimagemagick_types): Likewise.
10410
b6e3633c
AS
10411 * window.h (replace_buffer_in_windows): Declare.
10412
9397e56f
MR
104132011-06-11 Martin Rudalics <rudalics@gmx.at>
10414
10415 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10416 Qclone_number. Remove external declaration of Qdelete_window.
10417 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10418 code.
640c8776
SM
10419 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10420 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10421 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10422 buffer list implementation.
10423 (other_buffer_safely): New function.
10424 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10425 calls to replace_buffer_in_windows and
10426 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10427 if allowed.
10428 (record_buffer): Inhibit quitting and rewrite using quittable
10429 functions. Run Qbuffer_list_update_hook if allowed.
10430 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10431 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10432 Move switch-to-buffer to window.el.
9397e56f
MR
10433 (bury-buffer): Move to window.el.
10434 (Vbuffer_list_update_hook): New variable.
10435
10436 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10437 section.
10438
10439 * window.h (resize_frame_windows): Move up in code.
10440 (Fwindow_frame): Remove EXFUN.
10441 (replace_buffer_in_all_windows): Remove prototype.
10442 (replace_buffer_in_windows_safely): Add prototype.
10443
10444 * window.c: Declare Qdelete_window static again. Move down
10445 declaration of select_count.
10446 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10447 (Fother_window): Move to window.el.
10448 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10449 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10450 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10451 window.el.
10452 (replace_buffer_in_windows): Implement by calling
10453 Qreplace_buffer_in_windows.
10454 (replace_buffer_in_all_windows): Remove with some functionality
10455 moved into replace_buffer_in_windows_safely.
10456 (replace_buffer_in_windows_safely): New function.
10457 (select_window_norecord, select_frame_norecord): Move in front
10458 of run_window_configuration_change_hook. Remove now obsolete
10459 declarations.
640c8776
SM
10460 (Fset_window_buffer): Rewrite doc-string.
10461 Call Qrecord_window_buffer.
9397e56f
MR
10462 (keys_of_window): Move binding for other-window to window.el.
10463
b50691aa
CY
104642011-06-11 Chong Yidong <cyd@stupidchicken.com>
10465
10466 * dispextern.h (struct image): Replace data member, whose int_val
10467 and ptr_val fields were not used by anything, with a single
10468 lisp_val object.
10469
10470 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10471 (gif_clear_image, gif_load, imagemagick_load_image)
10472 (gs_clear_image, gs_load): Callers changed.
10473
3f754b86
PE
104742011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10475
cca69397
PE
10476 * buffer.h: Include <time.h>, for time_t.
10477 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10478
109e28d0
PE
10479 Fix minor problems found by static checking.
10480
60737f02
PE
10481 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10482
4b66faf3
PE
10483 Make identifiers static if they are not used in other modules.
10484 * data.c (Qcompiled_function, Qframe, Qvector):
10485 * image.c (QimageMagick, Qsvg):
10486 * minibuf.c (Qmetadata):
10487 * window.c (resize_window_check, resize_root_window): Now static.
10488 * window.h (resize_window_check, resize_root_window): Remove decls.
10489
109e28d0
PE
10490 * window.c (window_deletion_count, delete_deletable_window):
10491 Remove; unused.
46a4ce9e
PE
10492 (window_body_lines): Now static.
10493 (Fdelete_other_windows_internal): Mark vars as initialized.
10494 Make sure 'resize_failed' is initialized.
10495 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10496 (resize_window_apply): Remove unused local.
10497 * window.h (delete_deletable_window): Remove decl.
10498
109e28d0 10499 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10500 (imagemagick_load_image): Fix pointer signedness problem by changing
10501 last arg from unsigned char * to char *. All uses changed.
10502 Also, fix a local for similar reasons.
10503 Remove unused locals. Remove locals to avoid shadowing.
10504 (fn_rsvg_handle_free): Remove; unused.
10505 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10506 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10507
3f754b86
PE
10508 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10509
2547adb1
CY
105102011-06-10 Chong Yidong <cyd@stupidchicken.com>
10511
10512 * image.c (gif_load): Fix omitted cast error introduced by
10513 2011-06-06 change.
10514
2c8e37d4
MR
105152011-06-10 Martin Rudalics <rudalics@gmx.at>
10516
10517 * window.h (resize_proportionally, orig_total_lines)
10518 (orig_top_line): Remove from window structure.
10519 (set_window_height, set_window_width, change_window_heights)
10520 (Fdelete_window): Remove prototypes.
10521 (resize_frame_windows): Remove duplicate declaration.
10522
440a42e3
EZ
105232011-06-10 Eli Zaretskii <eliz@gnu.org>
10524
10525 * window.h (resize_frame_windows, resize_window_check)
10526 (delete_deletable_window, resize_root_window)
10527 (resize_frame_windows): Declare prototypes.
10528
10529 * window.c (resize_window_apply): Make definition be "static" to
10530 match the prototype.
10531
562dd5e9
MR
105322011-06-10 Martin Rudalics <rudalics@gmx.at>
10533
10534 * window.c: Remove declarations of Qwindow_size_fixed,
10535 window_min_size_1, window_min_size_2, window_min_size,
10536 size_window, window_fixed_size_p, enlarge_window, delete_window.
10537 Remove static from declaration of Qdelete_window, it's
10538 temporarily needed by Fbury_buffer.
10539 (replace_window): Don't assign orig_top_line and
10540 orig_total_lines.
10541 (Fdelete_window, delete_window): Remove. Window deletion is
10542 handled by window.el.
640c8776
SM
10543 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10544 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10545 (Fdelete_other_windows): Remove. Deleting other windows is
10546 handled by window.el.
10547 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10548 handled in window.el.
10549 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10550 Window minimum sizes are handled in window.el.
10551 (shrink_windows, size_window, set_window_height)
10552 (set_window_width, change_window_heights, window_height)
10553 (window_width, CURBEG, CURSIZE, enlarge_window)
10554 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10555 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10556 handled in window.el.
10557 (make_dummy_parent): Rename to make_parent_window and give it a
10558 second argument horflag.
10559 (make_window): Don't set resize_proportionally any more.
10560 (Fsplit_window): Remove. Windows are split in window.el.
10561 (save_restore_action, save_restore_orig_size)
10562 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10563 Resize mini windows in window.el.
10564 (grow_mini_window, shrink_mini_window): Implement by calling
10565 Qresize_root_window_vertically, resize_window_check and
10566 resize_window_apply.
640c8776
SM
10567 (saved_window, Fset_window_configuration, save_window_save):
10568 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10569 resize_proportionally.
10570 (window_min_height, window_min_width): Move to window.el.
10571 (keys_of_window): Move bindings for delete-other-windows,
10572 split-window, delete-window and enlarge-window to window.el.
10573
10574 * buffer.c: Temporarily extern Qdelete_window.
10575 (Fbury_buffer): Temporarily call Qdelete_window instead of
10576 Fdelete_window (Fbury_buffer will move to window.el soon).
10577
10578 * frame.c (set_menu_bar_lines_1): Remove code handling
10579 orig_top_line and orig_total_lines.
10580
10581 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10582 set_window_height but set heights directly.
10583 (change_frame_size_1): Use resize_frame_windows.
10584
10585 * xdisp.c (init_xdisp): Don't use set_window_height but set
10586 heights directly.
10587
640c8776
SM
10588 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10589 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10590 run_window_configuration_change_hook.
10591
10592 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10593 instead of change_window_heights and run
10594 run_window_configuration_change_hook.
10595
1a13852e
MR
105962011-06-09 Martin Rudalics <rudalics@gmx.at>
10597
10598 * window.c (replace_window): Rename second argument REPLACEMENT to
10599 NEW. New third argument SETFLAG. Rewrite.
10600 (delete_window, make_dummy_parent): Call replace_window with
10601 third argument 1.
10602 (window_list_1): Move down in code.
10603 (run_window_configuration_change_hook): Move set_buffer part
10604 before select_frame_norecord part in order to unwind correctly.
10605 Rename count1 to count.
10606 (recombine_windows, delete_deletable_window, resize_root_window)
10607 (Fdelete_other_windows_internal)
10608 (Frun_window_configuration_change_hook, make_parent_window)
10609 (resize_window_check, resize_window_apply, Fresize_window_apply)
10610 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10611 (Fdelete_window_internal, Fresize_mini_window_internal):
10612 New functions.
1a13852e
MR
10613 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10614
f3d1777e
MR
106152011-06-08 Martin Rudalics <rudalics@gmx.at>
10616
496e208e
MR
10617 * window.h (window): Add some new members to window structure -
10618 normal_lines, normal_cols, new_total, new_normal, clone_number,
10619 splits, nest, prev_buffers, next_buffers.
10620 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10621 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10622
f3d1777e
MR
10623 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10624 Remove.
496e208e
MR
10625 (make_dummy_parent): Set new members of windows structure.
10626 (make_window): Move down in code. Handle new members of window
10627 structure.
10628 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10629 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10630 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10631 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10632 (Fset_window_next_buffers, Fset_window_clone_number):
10633 New functions.
496e208e
MR
10634 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10635 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10636 Doc-string fixes.
10637 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10638 Argument WINDOW can be now internal window too.
10639 (Fwindow_use_time): Move up in code.
10640 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10641 Rewrite doc-string.
10642 (Fset_window_configuration, saved_window)
10643 (Fcurrent_window_configuration, save_window_save): Handle new
10644 members of window structure.
b9e809c2
MR
10645 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10646 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10647 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10648 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10649 Qget_mru_window, Qresize_root_window,
10650 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10651 Qauto_buffer_name; staticpro them.
f3d1777e 10652
abde8f8c
MR
106532011-06-07 Martin Rudalics <rudalics@gmx.at>
10654
10655 * window.c (Fwindow_total_size, Fwindow_left_column)
10656 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10657 (Fwindow_list_1): New functions.
10658 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10659 (Fwindow_width, Fscroll_left, Fscroll_right):
10660 Use window_body_cols instead of window_box_text_cols.
10661 (delete_window, Fset_window_configuration):
10662 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10663 (delete_all_subwindows): Take a window as argument and not a
10664 structure. Rewrite.
190b47e6
MR
10665 (window_loop): Remove handling of GET_LRU_WINDOW and
10666 GET_LARGEST_WINDOW.
10667 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10668
10669 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10670 window_box_text_cols. delete_all_subwindows now takes a
10671 Lisp_Object as argument.
abde8f8c 10672
640c8776
SM
10673 * indent.c (compute_motion, Fcompute_motion):
10674 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10675
fa8a67e6
MR
10676 * frame.c (delete_frame): Call delete_all_subwindows with root
10677 window as argument.
10678
a54e3482
DC
106792011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10680
10681 * fns.c (Fputhash): Document return value.
10682
60002bf5
CY
106832011-06-06 Chong Yidong <cyd@stupidchicken.com>
10684
10685 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10686
0c671da6 106872011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10688
b862a52a 10689 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10690
be44ca6c
PE
10691 Check for overflow when converting integer to cons and back.
10692 * charset.c (Fdefine_charset_internal, Fdecode_char):
10693 Use cons_to_unsigned to catch overflow.
10694 (Fencode_char): Use INTEGER_TO_CONS.
10695 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10696 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10697 * data.c (long_to_cons, cons_to_long): Remove.
10698 (cons_to_unsigned, cons_to_signed): New functions.
10699 These signal an error for invalid or out-of-range values.
10700 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10701 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10702 * font.c (Ffont_variation_glyphs):
10703 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10704 * lisp.h: Include <intprops.h>.
10705 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10706 (cons_to_signed, cons_to_unsigned): New decls.
10707 (long_to_cons, cons_to_long): Remove decls.
10708 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10709 (Fprimitive_undo): Use CONS_TO_INTEGER.
10710 * xfns.c (Fx_window_property): Likewise.
10711 * xselect.c: Include <limits.h>.
10712 (x_own_selection, selection_data_to_lisp_data):
10713 Use INTEGER_TO_CONS.
10714 (x_handle_selection_request, x_handle_selection_clear)
10715 (x_get_foreign_selection, Fx_disown_selection_internal)
10716 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10717 (lisp_data_to_selection_data): Use cons_to_unsigned.
10718 (x_fill_property_data): Use cons_to_signed.
10719 Report values out of range.
10720
d1f3d2af
PE
10721 Check for buffer and string overflow more precisely.
10722 * buffer.h (BUF_BYTES_MAX): New macro.
10723 * lisp.h (STRING_BYTES_MAX): New macro.
10724 * alloc.c (Fmake_string):
10725 * character.c (string_escape_byte8):
10726 * coding.c (coding_alloc_by_realloc):
10727 * doprnt.c (doprnt):
10728 * editfns.c (Fformat):
10729 * eval.c (verror):
10730 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10731 since they may not be the same number.
10732 * editfns.c (Finsert_char):
10733 * fileio.c (Finsert_file_contents):
10734 Likewise for BUF_BYTES_MAX.
10735
dd52fcea
PE
10736 * image.c: Use ptrdiff_t, not int, for sizes.
10737 (slurp_file): Switch from int to ptrdiff_t.
10738 All uses changed.
10739 (slurp_file): Check that file size fits in both size_t (for
10740 malloc) and ptrdiff_t (for sanity and safety).
10741
7f9bbdbb
PE
10742 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10743 if b->modtime has its maximal value.
10744
dfe18f82
PE
10745 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10746
84acfcf0
PE
10747 Don't assume time_t can fit into int.
10748 * buffer.h (struct buffer.modtime): Now time_t, not int.
10749 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10750 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10751
ccd9a01a
PE
10752 Minor fixes for signed vs unsigned integers.
10753 * character.h (MAYBE_UNIFY_CHAR):
10754 * charset.c (maybe_unify_char):
10755 * keyboard.c (read_char, reorder_modifiers):
10756 XINT -> XFASTINT, since the integer must be nonnegative.
10757 * ftfont.c (ftfont_spec_pattern):
10758 * keymap.c (access_keymap, silly_event_symbol_error):
10759 XUINT -> XFASTINT, since the integer must be nonnegative.
10760 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10761 since it makes no difference and we prefer signed.
10762 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10763 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10764 nonnegative.
10765
d6d100dd
SM
107662011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10767
10768 * window.h (Fwindow_frame): Declare.
10769
2b6148e4
PE
107702011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10771
10772 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10773 (SPARE_MEMORY): Always define.
10774 (LARGE_REQUEST): Remove.
10775 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10776
f230ecc9
MR
107772011-06-06 Martin Rudalics <rudalics@gmx.at>
10778
727e958e
MR
10779 * lisp.h: Move EXFUNS for Fframe_root_window,
10780 Fframe_first_window and Fset_frame_selected_window to window.h.
10781
10782 * window.h: Move EXFUNS for Fframe_root_window,
10783 Fframe_first_window and Fset_frame_selected_window here from
10784 lisp.h.
10785
10786 * frame.c (Fwindow_frame, Fframe_first_window)
10787 (Fframe_root_window, Fframe_selected_window)
10788 (Fset_frame_selected_window): Move to window.c.
10789 (Factive_minibuffer_window): Move to minibuf.c.
10790 (Fother_visible_frames_p): New function.
10791
10792 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10793
f230ecc9
MR
10794 * window.c (decode_window, decode_any_window): Move up in code.
10795 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10796 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10797 (Fwindow_buffer): Move up and rewrite doc-string.
10798 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10799 (Fwindow_prev): New functions.
727e958e
MR
10800 (Fwindow_frame): Move here from frame.c. Accept any window as
10801 argument.
10802 (Fframe_root_window, Fframe_first_window)
10803 (Fframe_selected_window): Move here from frame.c. Accept frame
10804 or arbitrary window as argument. Update doc-strings.
10805 (Fminibuffer_window): Move up in code.
10806 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10807 (Fset_frame_selected_window): Move here from frame.c.
10808 Marginal rewrite.
727e958e
MR
10809 (Fselected_window, select_window, Fselect_window): Move up in
10810 code. Minor doc-string fixes.
f230ecc9 10811
4d09bcf6
PE
108122011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10813
10814 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10815 Do not assume that spare memory exists; that assumption is valid
10816 only if SYSTEM_MALLOC.
10817 (LARGE_REQUEST): New macro, so that the issue of large requests
10818 is separated from the issue of spare memory.
10819
810928a2
AS
108202011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10821
172418ad
AS
10822 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10823 format. (Bug#8806)
10824
43f862f7
AS
10825 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10826
810928a2
AS
10827 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10828 before statements.
10829
a059fe24
JD
108302011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10831
10832 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10833
10834 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10835
10836 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10837 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10838
989bf368
JB
108392011-06-05 Juanma Barranquero <lekktu@gmail.com>
10840
10841 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10842
4b80f674
CY
108432011-06-04 Chong Yidong <cyd@stupidchicken.com>
10844
10845 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10846 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10847 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10848 New error handlers.
4b80f674
CY
10849 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10850 Obey Vx_select_enable_clipboard_manager. Catch errors in
10851 x_clipboard_manager_save (Bug#8779).
10852 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10853 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10854
99a33b77 108552011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10856
10857 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10858
99a33b77 108592011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10860
10861 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10862 in the current matrix if keep_current_p is non-zero.
10863
8264569d
EZ
108642011-06-04 Eli Zaretskii <eliz@gnu.org>
10865
10866 * bidi.c (bidi_level_of_next_char): Fix last change.
10867
57f97249
EZ
108682011-06-03 Eli Zaretskii <eliz@gnu.org>
10869
fec2107c 10870 Support bidi reordering of text covered by display properties.
57f97249 10871
fec2107c
EZ
10872 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10873 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10874 (bidi_cache_search, bidi_cache_iterator_state)
10875 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10876 (bidi_level_of_next_char, bidi_move_to_visually_next):
10877 Support character positions inside a run of characters covered by a
fec2107c
EZ
10878 display string.
10879 (bidi_paragraph_init, bidi_resolve_explicit_1)
10880 (bidi_level_of_next_char): Call bidi_fetch_char and
10881 bidi_fetch_char_advance instead of FETCH_CHAR and
10882 FETCH_CHAR_ADVANCE.
10883 (bidi_init_it): Initialize new members.
10884 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10885 definitions.
10886 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10887 instead of using explicit *_CHAR codes.
d6d100dd
SM
10888 (bidi_resolve_explicit, bidi_resolve_weak):
10889 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10890 bidirectional text is supported only in multibyte buffers.
10891 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10892 it to initialize the frame_window_p member of struct bidi_it.
10893 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10894 (bidi_resolve_explicit, bidi_resolve_weak)
10895 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10896 bidi_it->nchars is non-positive.
10897 (bidi_level_of_next_char): Don't try to lookup the cache for the
10898 next/previous character if nothing is cached there yet, or if we
10899 were just reseat()'ed to a new position.
c40e2fb2 10900
0e14fe90
EZ
10901 * xdisp.c (set_cursor_from_row): Set start and stop points
10902 according to the row's direction when priming the loop that looks
10903 for the glyph on which to display cursor.
10904 (single_display_spec_intangible_p): Function deleted.
10905 (display_prop_intangible_p): Reimplement to call
10906 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10907 Accept 3 additional arguments needed by handle_display_spec.
10908 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10909 values: lists, `(when COND...)' forms, etc.
10910 (single_display_spec_string_p): Support property values that are
10911 lists with the argument STRING its top-level element.
10912 (display_prop_string_p): Fix the condition for processing a
10913 property that is a list to be consistent with handle_display_spec.
fec2107c 10914 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10915 last portion of handle_display_prop.
10916 (compute_display_string_pos): Accept additional argument
10917 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10918 value of a `display' property is a "replacing spec".
10919 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10920 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10921 the display property, but just return a value indicating whether
10922 the display property will replace the characters it covers.
10923 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10924 frame_window_p members of struct bidi_it.
d6d100dd
SM
10925 (compute_display_string_pos, compute_display_string_end):
10926 New functions.
fec2107c
EZ
10927 (push_it): Accept second argument POSITION, where pop_it should
10928 jump to continue iteration.
10929 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10930
fec2107c
EZ
10931 * keyboard.c (adjust_point_for_property): Adjust the call to
10932 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10933
10934 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10935 (bidi_init_it): Update prototypes.
10936 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10937 (compute_display_string_pos, compute_display_string_end):
10938 Declare prototypes.
fec2107c
EZ
10939 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10940 EMACS_INT.
fc6f18ce 10941
40087514 109422011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10943
57f53182
PE
10944 Malloc failure behavior now depends on size of allocation.
10945 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10946 * lisp.h: Change signatures accordingly.
10947 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10948 All callers changed. (Bug#8762)
10949
10950 * gnutls.c: Use Emacs's memory allocators.
10951 Without this change, the gnutls library would invoke malloc etc.
10952 directly, which causes problems on non-SYNC_INPUT hosts, and which
10953 runs afoul of improving memory_full behavior. (Bug#8761)
10954 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10955 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10956 xfree instead of the default malloc, realloc, free.
10957 (Fgnutls_boot): No need to check for memory allocation failure,
10958 since xmalloc does that for us.
10959
ac32cd99 10960 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10961 * category.c (hash_get_category_set):
10962 * ccl.c (ccl_driver):
10963 * charset.c (Fdefine_charset_internal):
10964 * charset.h (struct charset.hash_index):
10965 * composite.c (get_composition_id, gstring_lookup_cache)
10966 (composition_gstring_put_cache):
10967 * composite.h (struct composition.hash_index):
10968 * dispextern.h (struct image.hash):
10969 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10970 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10971 (hashfn_equal, hashfn_user_defined, make_hash_table)
10972 (maybe_resize_hash_table, hash_lookup, hash_put)
10973 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10974 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10975 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10976 * image.c (make_image, search_image_cache, lookup_image)
10977 (xpm_put_color_table_h):
10978 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10979 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10980 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10981 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10982 * alloc.c (allocate_vectorlike):
10983 Check for overflow in vector size calculations.
10984 * ccl.c (ccl_driver):
10985 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10986 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10987 need to be updated by these changes.
40087514
PE
10988 * fns.c (make_hash_table, maybe_resize_hash_table):
10989 Check for integer overflow with large hash tables.
0de4bb68
PE
10990 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10991 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10992 (SXHASH_REDUCE): New macro.
10993 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10994 Use it instead of discarding useful hash info with large hash values.
10995 (sxhash_float): New function.
10996 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10997 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10998 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10999 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11000 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11001 Adjust signatures to match updated version of code.
11002 (consing_since_gc): Now EMACS_INT, since a single hash table can
11003 use more than INT_MAX bytes.
11004
698d32e2
DN
110052011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11006
11007 Make it possible to build with GCC-4.6+ -O2 -flto.
11008
11009 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11010
fd6fa53f
SM
110112011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11012
11013 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11014 Call minibuffer-inactive-mode.
11015
864db017
JB
110162011-05-31 Juanma Barranquero <lekktu@gmail.com>
11017
11018 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11019 Update dependencies.
11020
2ad0baf4
DN
110212011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11022
11023 * data.c (init_data): Remove code for UTS, this system is not
11024 supported anymore.
11025
4fcc2638
DN
110262011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11027
11028 Don't force ./temacs to start in terminal mode.
11029
11030 * frame.c (make_initial_frame): Initialize faces in all cases, not
11031 only when CANNOT_DUMP is defined.
11032 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11033
c56e0fd5
DN
110342011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11035
11036 * dispnew.c (add_window_display_history): Use const for the string
11037 pointer. Remove declaration, not needed.
11038
333d54da 110392011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11040
55d4c1b2 11041 Use 'inline', not 'INLINE'.
333d54da 11042 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11043 * alloc.c, fontset.c (INLINE): Remove.
11044 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11045 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11046 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11047 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11048 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11049
738db178
DN
110502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11051
11052 Make it possible to run ./temacs.
11053
11054 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11055 syms_of_callproc does the same thing. Remove test for
11056 "initialized", do it in the caller.
11057 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11058
620c53a6
SM
110592011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11060
11061 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11062 (read_minibuf): Use get_minibuffer.
11063 (syms_of_minibuf): Use DEFSYM.
11064 (Qmetadata): New var.
11065 * data.c (Qbuffer): Don't make it static.
11066 (syms_of_data): Use DEFSYM.
11067
e003a292
PE
110682011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11069
11070 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11071 (CCL_CODE_MIN): New macro.
11072
ed008a6d
PE
110732011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11074
3687c2ef
PE
11075 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11076
ed008a6d
PE
11077 * eval.c (Qdebug): Now static.
11078 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11079 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11080 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11081
d66c4c7c
CY
110822011-05-29 Chong Yidong <cyd@stupidchicken.com>
11083
11084 * image.c: Various fixes to ImageMagick code comments.
11085 (Fimagemagick_types): Doc fix.
11086
5fbc2025
PE
110872011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11088
0196f88a
PE
11089 Minor fixes prompted by GCC 4.6.0 warnings.
11090
11091 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11092
5fbc2025
PE
11093 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11094 (x_clipboard_manager_save_all): Move extern decl to ...
11095 * xterm.h: ... here, so that it can be checked for consistency.
11096
1dd3c2d9
CY
110972011-05-29 Chong Yidong <cyd@stupidchicken.com>
11098
11099 * xselect.c (x_clipboard_manager_save_frame)
11100 (x_clipboard_manager_save_all): New functions.
11101 (Fx_clipboard_manager_save): Lisp function deleted.
11102
11103 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11104 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11105
11106 * xterm.h: Update prototype.
11107
5ba6571d
WX
111082011-05-28 William Xu <william.xwl@gmail.com>
11109
11110 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11111 exiting (Bug#8239).
11112
3eaff834
JM
111132011-05-28 Jim Meyering <meyering@redhat.com>
11114
e1900994 11115 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11116 * fns.c (to_uchar): Define.
11117 (crypto_hash_function): Use it to convert some newly-signed
11118 variables to unsigned, to avoid sign-extension bugs. For example,
11119 without this change, (md5 "truc") would evaluate to
11120 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11121 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11122 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11123
0f6990a7
PE
111242011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11125
11126 Integer overflow fixes.
c8a9ca5a 11127
08686060
PE
11128 * dbusbind.c: Serial number integer overflow fixes.
11129 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11130 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11131 to hold a serial number that is too large for a fixnum.
11132 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11133 Check for serial numbers out of range. Decode any serial number
59568bf0 11134 that was so large that it became a float. (Bug#8722)
08686060 11135
2d1fc3c7
PE
11136 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11137 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11138 Use XFASTINT rather than XUINT when numbers are nonnegative.
11139 (xd_append_arg, Fdbus_method_return_internal):
11140 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11141 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11142 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11143 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11144 (Bug#8722)
2d1fc3c7 11145
c8a9ca5a
PE
11146 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11147
519e1d69
PE
11148 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11149
6df6ae42 11150 ccl: Add integer overflow checks.
30569699
PE
11151 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11152 (IN_INT_RANGE): New macros.
11153 (ccl_driver): Use them to check for integer overflow when
11154 decoding a CCL program. Many of the new checks are whether XINT (x)
11155 fits in int; it doesn't always, on 64-bit hosts. The new version
11156 doesn't catch all possible integer overflows, but it's an
847044ea 11157 improvement. (Bug#8719)
30569699 11158
c11285dc
PE
11159 * alloc.c (make_event_array): Use XINT, not XUINT.
11160 There's no need for unsigned here.
11161
fdccd48e
PE
11162 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11163 This follows up to the 2011-05-06 change that substituted uintptr_t
11164 for EMACS_INT. This case wasn't caught back then.
11165
37910ab2
PE
11166 Rework Fformat to avoid integer overflow issues.
11167 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11168 now (part of C89). Include <verify.h>.
11169 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11170 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11171 (Fformat): Avoid the prepass trying to compute sizes; it was only
11172 approximate and thus did not catch overflow reliably. Instead, walk
11173 through the format just once, formatting and computing sizes as we go,
11174 checking for integer overflow at every step, and allocating a larger
11175 buffer as needed. Keep track separately whether the format is
11176 multibyte. Keep only the most-recently calculated precision, rather
11177 than them all. Record whether each argument has been converted to
11178 string. Use EMACS_INT, not int, for byte and char and arg counts.
11179 Support field widths and precisions larger than INT_MAX. Avoid
11180 sprintf's undefined behavior with conversion specifications such as %#d
11181 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11182 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11183 formatting out-of-range floating point numbers with int
9173deec 11184 formats. (Bug#8668)
37910ab2 11185
2e6578fb
PE
11186 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11187
0ae6bdee
PE
11188 * data.c: Avoid integer truncation in expressions involving floats.
11189 * data.c: Include <intprops.h>.
11190 (arith_driver): When there's an integer overflow in an expression
11191 involving floating point, convert the integers to floating point
11192 so that the resulting value does not suffer from catastrophic
11193 integer truncation. For example, on a 64-bit host (* 4
11194 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11195 Do not rely on undefined behavior after integer overflow.
11196
de883a70
PE
11197 merge count_size_as_multibyte, parse_str_to_multibyte
11198 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11199 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11200 Check for integer overflow.
11201 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11202 since it's now a duplicate of the other. This is more of
11203 a character than a buffer op, so better that it's in character.c.
11204 * fns.c, print.c: Adjust to above changes.
11205
2ff916cb
PE
112062011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11207
11208 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11209
f1b54466
PE
112102011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11211
fb1ac845
PE
11212 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11213 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11214 (x_clipboard_manager_save): Now static.
11215 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11216
f1b54466
PE
11217 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11218 (crypto_hash_function): Now static.
11219 Fix pointer signedness problems. Avoid unnecessary initializations.
11220
a9f737ee
CY
112212011-05-27 Chong Yidong <cyd@stupidchicken.com>
11222
11223 * termhooks.h (Vselection_alist): Make it terminal-local.
11224
11225 * terminal.c (create_terminal): Initialize it.
11226
11227 * xselect.c: Support for clipboard managers.
11228 (Vselection_alist): Move to termhooks.h as terminal-local var.
11229 (LOCAL_SELECTION): New macro.
11230 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11231 (symbol_to_x_atom): Remove gratuitous arg.
11232 (x_handle_selection_request, lisp_data_to_selection_data)
11233 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11234 (x_own_selection, x_get_local_selection, x_convert_selection):
11235 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11236 (some_frame_on_display): Delete unused function.
11237 (Fx_own_selection_internal, Fx_get_selection_internal)
11238 (Fx_disown_selection_internal, Fx_selection_owner_p)
11239 (Fx_selection_exists_p): New optional frame arg.
11240 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11241 (x_handle_selection_clear): Don't treat other terminals with the
11242 same keyboard specially. Use the terminal-local Vselection_alist.
11243 (x_clear_frame_selections): Use Frun_hook_with_args.
11244
11245 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11246
11247 * xterm.h: Add support for those atoms.
11248
e067f0c1
CY
112492011-05-26 Chong Yidong <cyd@stupidchicken.com>
11250
11251 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11252 (converted_selections, conversion_fail_tag): New global variables.
11253 (x_selection_request_lisp_error): Free the above.
11254 (x_get_local_selection): Remove unnecessary code.
11255 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11256 of converted selections stored in converted_selections.
11257 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11258 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11259 (x_convert_selection): New function.
11260 (x_handle_selection_event): Simplify.
11261 (x_get_foreign_selection): Don't ignore incoming requests while
11262 waiting for an answer; this will fail when we implement
11263 SAVE_TARGETS, and seems unnecessary anyway.
11264 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11265 (Vx_sent_selection_functions): Doc fix.
11266
0f4aebc0
LL
112672011-05-26 Leo Liu <sdl.web@gmail.com>
11268
11269 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11270
e61124cd
YM
112712011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11272
11273 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11274
11275 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11276 for fringe update if it has periodic bitmap.
ac389d0c 11277 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11278 and fringe_bitmap_periodic_p.
11279
11280 * fringe.c (get_fringe_bitmap_data): New function.
11281 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11282 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11283 row. Mark glyph row for fringe update if periodicity changed.
11284
11285 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11286 for fringe update unless it has periodic bitmap.
11287
f16d9837
KH
112882011-05-25 Kenichi Handa <handa@m17n.org>
11289
11290 * xdisp.c (get_next_display_element): Set correct it->face_id for
11291 a static composition.
11292
e1b90ef6
LL
112932011-05-24 Leo Liu <sdl.web@gmail.com>
11294
11295 * deps.mk (fns.o):
11296 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11297
11298 * fns.c (crypto_hash_function, Fsha1): New function.
11299 (Fmd5): Use crypto_hash_function.
11300 (syms_of_fns): Add Ssha1.
11301
7400048f
PE
113022011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11303
11304 * gnutls.c: Remove unused macros.
11305 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11306 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11307 Remove macros that are defined and never used.
11308 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11309
abb71cf4
CY
113102011-05-22 Chong Yidong <cyd@stupidchicken.com>
11311
11312 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11313 (Fx_get_selection_internal): Minor cleanup.
11314 (Fx_own_selection_internal): Rename arguments for consistency with
11315 select.el.
11316
6307db39
PE
113172011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11318
11319 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11320
f3d4e0a4
CY
113212011-05-22 Chong Yidong <cyd@stupidchicken.com>
11322
11323 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11324
4d8ade89
YM
113252011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11326
11327 * dispnew.c (scrolling_window): Don't exclude the case that the
11328 last enabled row in the desired matrix touches the bottom boundary.
11329
32078c8d
GM
113302011-05-21 Glenn Morris <rgm@gnu.org>
11331
11332 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11333 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11334 and add some more files.
32078c8d 11335
7285dc67
EZ
113362011-05-20 Eli Zaretskii <eliz@gnu.org>
11337
11338 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11339 report_file_error introduced by the change from 2011-05-07.
11340
89d1bd22
PE
113412011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11342
11343 * systime.h (Time): Define only if emacs is defined.
11344 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11345 where the include path doesn't have X11/X.h by default. See
11346 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11347
cd394be1 113482011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11349
11350 * composite.c (find_automatic_composition): Fix previous change.
11351
b9704ad9
GM
113522011-05-20 Glenn Morris <rgm@gnu.org>
11353
11354 * lisp.mk: New file, split from Makefile.in.
11355 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11356 (shortlisp): Remove.
11357 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11358
4a720484
GM
113592011-05-19 Glenn Morris <rgm@gnu.org>
11360
11361 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11362 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11363 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11364 (lisp): Set the order to that of loadup.el.
11365 (shortlisp): Make it a copy of $lisp.
11366 (SOME_MACHINE_LISP): Remove.
11367 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11368 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11369
a28d4396
KH
113702011-05-18 Kenichi Handa <handa@m17n.org>
11371
11372 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11373 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11374 (find_automatic_composition): Mostly rewrite for efficiency.
11375
a2b1fa8e
JB
113762011-05-18 Juanma Barranquero <lekktu@gmail.com>
11377
11378 * makefile.w32-in: Update dependencies.
11379
8e1f5610
CS
113802011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11381
11382 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11383 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11384
7025ee00 113852011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11386
cdfa6eab
PE
11387 Fix some integer overflow issues, such as string length overflow.
11388
06d6db33
PE
11389 * insdel.c (count_size_as_multibyte): Check for string overflow.
11390
2b4560a8
PE
11391 * character.c (lisp_string_width): Check for string overflow.
11392 Use EMACS_INT, not int, for string indexes and lengths; in
11393 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11394 the resulting string length overflows an EMACS_INT; instead,
11395 report a string overflow if no precision given. When checking for
11396 precision exhaustion, use a check that cannot possibly have
11397 integer overflow. (Bug#8675)
11398 * character.h (lisp_string_width): Adjust to new signature.
11399
cb93f9be
PE
11400 * alloc.c (string_overflow): New function.
11401 (Fmake_string): Use it. This doesn't change behavior, but saves
11402 a few bytes and will simplify future changes.
11403 * character.c (string_escape_byte8): Likewise.
11404 * lisp.h (string_overflow): New decl.
11405
1a1f3366
PE
11406 Fixups, following up to the user-interface timestamp change.
11407 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11408 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11409 * msdos.c (mouse_get_pos): Likewise.
11410 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11411 * w32gui.h (Time): Define by including "systime.h" rather than by
11412 declaring it ourselves. (Bug#8664)
11413
d4e3e4d3
PE
11414 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11415 * image.c (clear_image_cache): Likewise.
11416
f6a24d19
PE
11417 * term.c (term_mouse_position): Don't assume time_t wraparound.
11418
08dc5ae6
PE
11419 Be more systematic about user-interface timestamps.
11420 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11421 and sometimes 'EMACS_UINT', to represent these timestamps.
11422 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11423 This makes the code easier to follow, and makes it easier to catch
11424 integer overflow bugs such as Bug#8664.
11425 * frame.c (Fmouse_position, Fmouse_pixel_position):
11426 Use Time, not unsigned long, for user-interface timestamps.
11427 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11428 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11429 * keyboard.h (last_event_timestamp): Likewise.
11430 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11431 * menu.h (xmenu_show): Likewise.
11432 * term.c (term_mouse_position): Likewise.
11433 * termhooks.h (struct input_event.timestamp): Likewise.
11434 (struct terminal.mouse_position_hook): Likewise.
11435 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11436 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11437 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11438 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11439 what it was before.
11440 * menu.h, termhooks.h: Include "systime.h", for Time.
11441
8e55734a
PE
11442 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11443 Don't assume that the difference between two unsigned long values
11444 can fit into an integer. At this point, we know button_down_time
11445 <= event->timestamp, so the difference must be nonnegative, so
11446 there's no need to cast the result if double-click-time is
11447 nonnegative, as it should be; check that it's nonnegative, just in
11448 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11449 apart (about 25 days). (Bug#8664)
8e55734a 11450
841f1b75 11451 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11452 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11453
3e26f69c
PE
11454 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11455 that always fit in int. Use a sentinel instead of a counter, to
11456 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11457 * frame.h (struct frame): Use int for menu_bar_items_used
11458 instead of EMACS_INT, since it always fits in int.
3e26f69c 11459
5cc152c0
PE
11460 * menu.c (grow_menu_items): Check for int overflow.
11461
d89eb65e
PE
11462 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11463
5235bd3e
PE
11464 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11465 Before, the code was not consistent. These values cannot exceed
11466 2**31 - 1 so there's no need to make them unsigned.
11467 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11468 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11469 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11470 as modifiers.
11471 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11472
bc827e23
PE
11473 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11474 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11475 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11476 presumably because the widths might not match.
11477
78eb494e
PE
11478 * window.c (size_window): Avoid needless test at loop start.
11479
04f2d78b
CB
114802011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11481
11482 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11483
d2fc7e3d 114842011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11485
11486 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11487
d2fc7e3d 114882011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11489
11490 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11491 `width' to `bar_area_x' and `bar_area_width', respectively.
11492 (x_scroll_run): Take account of fringe background extension.
11493
04f2d78b
CB
11494 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11495 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11496 `bar_area_width', respectively.
11497 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11498 background extension.
11499
79b70037
GM
115002011-05-10 Jim Meyering <meyering@redhat.com>
11501
11502 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11503
2f142cc5
JB
115042011-05-10 Juanma Barranquero <lekktu@gmail.com>
11505
11506 * image.c (Finit_image_library): Return t for built-in image types,
11507 like pbm and xbm. (Bug#8640)
11508
57679c86
AS
115092011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11510
11511 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11512
888c9e86
EZ
115132011-05-07 Eli Zaretskii <eliz@gnu.org>
11514
b0512a1d
EZ
11515 * w32console.c (Fset_screen_color): Doc fix.
11516 (Fget_screen_color): New function.
11517 (syms_of_ntterm): Defsubr it.
11518
7285dc67
EZ
11519 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11520 unlink the temporary file if Fcall_process didn't create it in the
11521 first place.
11522 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11523 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11524 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11525 cue to call_process_cleanup not to close that handle.
11526
4d3fcc8e
BK
115272011-05-07 Ben Key <bkey76@gmail.com>
11528
11529 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11530 one of two shell specific rules, either bootstrap-temacs-CMD or
11531 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11532 to the previous implementation of the bootstrap-temacs rule.
11533 The bootstrap-temacs-CMD rule is similar to the previous
11534 implementation of the bootstrap-temacs rule except that it
11535 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11536 variable.
11537
11538 These changes, along with some changes to nt/configure.bat,
11539 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11540 earlier fix to add support for --cflags and --ldflags options
11541 that include quotes so that it works whether make uses cmd or
11542 sh as the shell.
11543
b4289b64
MA
115442011-05-06 Michael Albinus <michael.albinus@gmx.de>
11545
11546 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11547 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11548 is a constant.
11549 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11550 a string. Handle both cases.
11551 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11552 (Fdbus_register_method): Use Qinvalid_function.
11553
af4c0e28
JB
115542011-05-06 Juanma Barranquero <lekktu@gmail.com>
11555
11556 * makefile.w32-in: Update dependencies.
11557 (LISP_H): Add inttypes.h and stdin.h.
11558 (PROCESS_H): Add unistd.h.
11559
c51453d9
EZ
115602011-05-06 Eli Zaretskii <eliz@gnu.org>
11561
11562 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11563 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11564
8ff0ac3c 115652011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11566
4c4b566b
PE
11567 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11568
aab2b9b5
PE
11569 * term.c (vfatal): Remove stray call to va_end.
11570 It's not needed and the C Standard doesn't allow it here anyway.
11571
c378da0b
PE
11572 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11573 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11574
288b08c7
PE
11575 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11576 bytes.
11577
e3601888
PE
11578 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11579
db6c0e74
PE
11580 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11581
dd5963ea
PE
11582 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11583
88c9450f
PE
11584 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11585
2f9442b8
PE
11586 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11587
c032b5f8
PE
11588 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11589 * charset.c (Fdefine_charset_internal): Don't initialize
11590 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11591 32-bit int (Bug#8600).
a108c10b
PE
11592
11593 * lread.c (read_integer): Be more consistent with string-to-number.
11594 Use string_to_number to do the actual conversion; this avoids
11595 rounding errors and fixes some other screwups. Without this fix,
11596 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11597 (digit_to_number): Move earlier, for benefit of read_integer.
11598 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11599 not a digit in any supported base. (Bug#8602)
a108c10b 11600
ad5f9eea
PE
11601 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11602
aec1708a
PE
11603 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11604 to match comment at start of function. This also removes a
11605 GCC warning about overflow in a 32+64-bit port.
11606
47be4ab5
PE
11607 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11608
371cac43
PE
11609 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11610 Reported by Stefan Monnier in
11611 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11612 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11613 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11614
d01a7826
PE
11615 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11616 (EMACS_UINTPTR): Likewise, with uintptr_t.
11617
7fd47d5c
PE
11618 * lisp.h: Prefer 64-bit EMACS_INT if available.
11619 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11620 on 32-bit hosts that have 64-bit int, so that they can access
11621 large files.
122b0c86
PE
11622 However, temporarily disable this change unless the temporary
11623 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11624
8727937b
PE
11625 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11626
8ac068ac
PE
11627 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11628 This removes an assumption that EMACS_INT and long are the same
11629 width as pointers. The assumption is true for Emacs porting targets
11630 now, but we want to make other targets possible.
11631 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11632 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11633 In the rest of the code, change types of integers that hold casted
11634 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11635 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11636 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11637 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11638 No need to cast type when ORing.
11639 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11640 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11641 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11642 assume EMACS_INT is the same width as char *.
11643 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11644 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11645 Remove no-longer-needed casts.
11646 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11647 (xg_tool_bar_help_callback, xg_make_tool_item):
11648 Use EMACS_INTPTR to hold an integer
11649 that will be cast to void *; this can avoid a GCC warning
11650 if EMACS_INT is not the same width as void *.
11651 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11652 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11653 (current_message_1, set_message_1):
11654 Use a local to convert to proper width without a cast.
11655 * xmenu.c (dialog_selection_callback): Likewise.
11656
ede49d71
PE
11657 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11658 Also, don't assume VALBITS / RAND_BITS is less than 5,
11659 and don't rely on undefined behavior when shifting a 1 left into
11660 the sign bit.
11661 * lisp.h (get_random): Change signature to match.
11662
2f30ecd0
PE
11663 * lread.c (hash_string): Use size_t, not int, for hash computation.
11664 Normally we prefer signed values; but hashing is special, because
11665 it's better to use unsigned division on hash table sizes so that
11666 the remainder is nonnegative. Also, size_t is the natural width
11667 for hashing into memory. The previous code used 'int', which doesn't
11668 retain enough info to hash well into very large tables.
11669 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11670
2a866e7b
PE
11671 * dbusbind.c: Don't possibly lose pointer info when converting.
11672 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11673 Use XPNTR rather than XHASH, so that the high-order bits of
11674 the pointer aren't lost when converting through void *.
11675
51639eac
PE
11676 * eval.c (Fautoload): Don't double-shift a pointer.
11677
92394119
PE
11678 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11679
dbdb9a7c
JB
116802011-05-06 Juanma Barranquero <lekktu@gmail.com>
11681
11682 * gnutls.c (DEF_GNUTLS_FN):
11683 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11684
db7a0b4f
AS
116852011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11686
11687 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11688 marker. (Bug#8610)
11689
cd394be1 116902011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11691
11692 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11693 New version that can reserve upto 2GB of heap space.
11694
f7ff1b0f 116952011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11696
11697 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11698
639c109b
TZ
116992011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11700
11701 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11702 `gnutls_certificate_set_x509_key_file'.
11703
d2127135
JB
117042011-05-05 Juanma Barranquero <lekktu@gmail.com>
11705
11706 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11707 Update dependencies.
11708
e968f4f3
JB
117092011-05-04 Juanma Barranquero <lekktu@gmail.com>
11710
11711 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11712 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11713 Remove unused parameter `fildes'.
11714 * process.c (read_process_output, send_process): Don't pass it.
11715
84d358f0
JB
117162011-05-04 Juanma Barranquero <lekktu@gmail.com>
11717
11718 Fix previous change: the library cache is defined in w32.c.
11719 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11720 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11721
0898ca10
JB
117222011-05-04 Juanma Barranquero <lekktu@gmail.com>
11723
11724 Implement dynamic loading of GnuTLS on Windows.
11725
11726 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11727 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11728 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11729 Declare.
11730
11731 * gnutls.c (Qgnutls_dll): Define.
11732 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11733 (gnutls_*): Declare function pointers.
11734 (init_gnutls_functions): New function to initialize function pointers.
11735 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11736 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11737 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11738 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11739 (emacs_gnutls_write, emacs_gnutls_read)
11740 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11741 (Fgnutls_available_p): New function.
11742 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11743 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11744 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11745
11746 * image.c: Include w32.h.
11747 (Vimage_type_cache): Delete.
11748 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11749 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11750 (w32_delayed_load): Move to w32.c.
11751
11752 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11753
11754 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11755 (w32_delayed_load): Move from image.c. When loading a library, record
11756 its filename in the :loaded-from property of the library id.
11757 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11758 Initialize and staticpro them.
11759 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11760
11761 * process.c: Include lisp.h before w32.h, not after.
11762 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11763 instead of gnutls_record_check_pending.
11764
11765 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11766
ff4de4aa
TZ
117672011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11768
11769 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11770 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11771 as passed in.
11772
abe95abb
JD
117732011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11774
11775 * xterm.c (x_set_frame_alpha): Do not set property on anything
11776 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11777
e16e55d4
JB
117782011-05-02 Juanma Barranquero <lekktu@gmail.com>
11779
11780 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11781
bafcf6a5
JB
117822011-05-02 Juanma Barranquero <lekktu@gmail.com>
11783
11784 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11785 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11786 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11787 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11788 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11789 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11790 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11791 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11792 (Qgnutls_bootprop_callbacks_verify): Make static.
11793
e7a6747f
AS
117942011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11795
19ed11ba
AS
11796 * callproc.c: Indentation fixup.
11797
e7a6747f 11798 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11799 (wait_for_termination, interruptible_wait_for_termination):
11800 Move after wait_for_termination_1.
e7a6747f 11801
1ef14cb4
LMI
118022011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11803
11804 * sysdep.c (interruptible_wait_for_termination): New function
11805 which is like wait_for_termination, but allows keyboard
11806 interruptions.
11807
11808 * callproc.c (Fcall_process): Add (:file "file") as an option for
11809 the STDOUT buffer.
11810 (Fcall_process_region): Ditto.
11811
330d880c
EZ
118122011-04-30 Eli Zaretskii <eliz@gnu.org>
11813
8db90b73
EZ
11814 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11815 rather than `XVECTOR (FOO)->size'.
11816
330d880c
EZ
11817 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11818 inttypes.h, as a gnulib replacement is used if it not available in
11819 system headers.
11820
15cbd324
EZ
118212011-04-21 Eli Zaretskii <eliz@gnu.org>
11822
11823 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11824 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11825 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11826
11827 * coding.c (coding_alloc_by_realloc): Error out if destination
11828 will grow beyond MOST_POSITIVE_FIXNUM.
11829 (decode_coding_emacs_mule): Abort if there isn't enough place in
11830 charbuf for the composition carryover bytes. Reserve an extra
11831 space for up to 2 characters produced in a loop.
11832 (decode_coding_iso_2022): Abort if there isn't enough place in
11833 charbuf for the composition carryover bytes.
11834
118352011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11836
ae940cca
EZ
11837 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11838 aborting when %lld or %lll format is passed.
11839 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11840 %llo or %llx format is passed. (Bug#8545)
11841
03ab8921
EZ
11842 * window.c (window_scroll_line_based): Use a marker instead of
11843 simple variables to record original value of point. (Bug#7952)
11844
afda1437
EZ
11845 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11846 produced by %s or %c overflows available buffer space. (Bug#8545)
11847
f76dee0c
PE
118482011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11849
11850 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11851 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11852
fdc5744d
JB
118532011-04-28 Juanma Barranquero <lekktu@gmail.com>
11854
11855 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11856
638f053a
JB
118572011-04-28 Juanma Barranquero <lekktu@gmail.com>
11858
11859 * keyboard.c (Qdelayed_warnings_hook): Define.
11860 (command_loop_1): Run `delayed-warnings-hook'
11861 if Vdelayed_warnings_list is non-nil.
11862 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11863 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11864
d178f871
EZ
118652011-04-28 Eli Zaretskii <eliz@gnu.org>
11866
11867 * doprnt.c (doprnt): Don't return value smaller than the buffer
11868 size if the message was truncated. (Bug#8545).
11869
b124fd93
JB
118702011-04-28 Juanma Barranquero <lekktu@gmail.com>
11871
11872 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11873 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11874
e810457d
PE
118752011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11876
11877 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11878
ea51cceb
JB
118792011-04-27 Juanma Barranquero <lekktu@gmail.com>
11880
11881 * makefile.w32-in: Update dependencies.
11882
94dcfacf
EZ
118832011-04-27 Eli Zaretskii <eliz@gnu.org>
11884
11885 Improve `doprnt' and its usage. (Bug#8545)
11886 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11887 `format_end'. Remove support for %l as a conversion specifier.
11888 Don't use xrealloc. Improve diagnostics when the %l size modifier
11889 is used. Update the commentary.
11890
11891 * eval.c (verror): Simplify calculation of size_t.
11892
11893 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11894 messages.
11895
f61f41d7
PE
118962011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11897
11898 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11899 change.
11900
96fb4434
PE
119012011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11902
11903 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11904 This makes this file independent of the recent pseudovector change.
11905
671875da 119062011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11907
69e9b5a3
PE
11908 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11909
b5f869a7 11910 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11911 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11912 Remove unused local.
c8926152 11913 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11914
841a1577 11915 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11916 GCC 4.6.0 optimizes based on type-based alias analysis.
11917 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11918 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11919 != &v->size, and therefore "v->size = 1; b->size = 2; return
11920 v->size;" must therefore return 1. This assumption is incorrect
11921 for Emacs, since it type-puns struct Lisp_Vector * with many other
11922 types. To fix this problem, this patch adds a new type struct
f904488f 11923 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11924 and pseudovectors, and helps optimizing compilers not get fooled
11925 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11926 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11927 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11928 the size member.
eab3844f
PE
11929 (XSETPVECTYPE): Rewrite in terms of new macro.
11930 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11931 This is a bit clearer, and further avoids the possibility of
11932 undesirable aliasing.
11933 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11934 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11935 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11936 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11937 (ASIZE): Now uses header.size rather than size.
11938 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11939 to avoid the hassle of writing XVECTOR (foo)->header.size.
11940 (struct vectorlike_header): New type.
eab3844f
PE
11941 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11942 object, to help avoid aliasing.
11943 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11944 (SUBRP): Likewise, since Lisp_Subr is a special case.
11945 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11946 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11947 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11948 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11949 changed to be "header.size" and "header.next".
11950 * buffer.h (struct buffer): Likewise.
11951 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11952 * frame.h (struct frame): Likewise.
11953 * process.h (struct Lisp_Process): Likewise.
11954 * termhooks.h (struct terminal): Likewise.
11955 * window.c (struct save_window_data, struct saved_window): Likewise.
11956 * window.h (struct window): Likewise.
11957 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11958 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11959 * buffer.c (init_buffer_once): Likewise.
11960 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11961 special case.
11962 * process.c (Fformat_network_address): Use local var for size,
11963 for brevity.
11964
0df1eac5
PE
11965 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11966
847ab9d1 11967 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11968 * data.c (atof): Remove decl; no longer used or needed.
11969 (digit_to_number): Move to lread.c.
11970 (Fstring_to_number): Use new string_to_number function, to be
11971 consistent with how the Lisp reader treats infinities and NaNs.
11972 Do not assume that floating-point numbers represent EMACS_INT
11973 without losing information; this is not true on most 64-bit hosts.
11974 Avoid double-rounding errors, by insisting on integers when
11975 parsing non-base-10 numbers, as the documentation specifies.
11976 * lisp.h (string_to_number): New decl, replacing ...
11977 (isfloat_string): Remove.
bc0a5c13 11978 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11979 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11980 appears to have been a coding error. Similarly, do not accept
11981 strings like +-1e0 as floating point numbers. Do not report
11982 overflow for integer overflows unless the base is not 10 which
11983 means we have no simple and reliable way to continue.
11984 Break out the floating-point parsing into a new
11985 function string_to_number, so that Fstring_to_number parses
11986 floating point numbers consistently with the Lisp reader.
04f2d78b 11987 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11988 (E_CHAR, EXP_INT): Remove, replacing with ...
11989 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11990 (string_to_number): New function, replacing isfloat_string.
11991 This function checks for valid syntax and produces the resulting
11992 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11993 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11994 so that overflow for non-base-10 numbers is reported only when
11995 there's no portable and simple way to convert to floating point.
452f4150 11996
67769ffc
PE
11997 * textprop.c (set_text_properties_1): Rewrite for clarity,
11998 and to avoid GCC warning about integer overflow.
11999
c20db43f
PE
12000 * intervals.h (struct interval): Use EMACS_INT for members
12001 where EMACS_UINT might cause problems. See
12002 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12003 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12004 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12005 All uses changed.
37aa2f85
PE
12006 (offset_intervals): Tell GCC not to worry about length overflow
12007 when negating a negative length.
c20db43f 12008
2538aa2f
PE
12009 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12010 (overrun_check_free): Likewise.
12011
f2d3008d
PE
12012 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12013 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12014 word size.
12015
ec8df744
PE
12016 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12017 (gnutls_make_error): Rename local to avoid shadowing.
12018 (gnutls_emacs_global_deinit): ifdef out; not used.
12019 (Fgnutls_boot): Use const for pointer to readonly storage.
12020 Comment out unused local. Fix pointer signedness problems.
12021
640ee02d
PE
12022 * lread.c (openp): Don't stuff size_t into an 'int'.
12023 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12024 about possible signed overflow.
12025
6048fb2a
PE
12026 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12027 (GDK_KEY_g): Don't define if already defined.
12028 (xg_prepare_tooltip): Avoid pointer signedness problem.
12029 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12030
fa3c87e1
PE
12031 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12032 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12033
2172544b
PE
12034 * xfns.c (Fx_window_property): Simplify a bit,
12035 to make a bit faster and to avoid GCC 4.6.0 warning.
12036 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12037
9b821a21
PE
12038 * fns.c (internal_equal): Don't assume size_t fits in int.
12039
3c616cfa
PE
12040 * alloc.c (compact_small_strings): Tighten assertion a little.
12041
c2982e87
PE
12042 Replace pEd with more-general pI, and fix some printf arg casts.
12043 * lisp.h (pI): New macro, generalizing old pEd macro to other
12044 conversion specifiers. For example, use "...%"pI"d..." rather
12045 than "...%"pEd"...".
12046 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12047 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12048 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12049 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12050 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12051 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12052 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12053 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12054 64-bit hosts.
12055 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12056 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12057 * print.c (safe_debug_print, print_object): Likewise.
12058 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12059 to int.
6f04d126
PE
12060 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12061 avoiding the 0 flag, which is not portable.
c2982e87
PE
12062 * process.c (Fmake_network_process): Use pI to avoid cast.
12063 * region-cache.c (pp_cache): Likewise.
12064 * xdisp.c (decode_mode_spec): Likewise.
12065 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12066 behavior on 64-bit hosts with printf arg.
6f04d126 12067 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12068 (x_stop_queuing_selection_requests): Likewise.
12069 (x_get_window_property): Don't truncate byte count to an 'int'
12070 when tracing.
0b432f21 12071
5e073ec7
PE
12072 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12073 here, since it parses constructs like leading '-' and spaces,
12074 which are not wanted; and it overflows with large numbers.
12075 Instead, simply match F[0-9]+, which is what is wanted anyway.
12076
36372bf9
PE
12077 * alloc.c: Remove unportable assumptions about struct layout.
12078 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12079 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12080 (allocate_vectorlike, make_pure_vector): Use the new macros,
12081 plus offsetof, to remove unportable assumptions about struct layout.
12082 These assumptions hold on all porting targets that I know of, but
12083 they are not guaranteed, they're easy to remove, and removing them
12084 makes further changes easier.
12085
0b432f21
PE
12086 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12087 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12088 (string_overrun_cookie): Now const. Use initializers that
12089 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12090 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12091 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12092 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12093 multiple of sizeof (EMACS_INT); it need not be, if
12094 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12095 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12096
895009e1
JB
120972011-04-26 Juanma Barranquero <lekktu@gmail.com>
12098
12099 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12100
6a7a1b0b
TZ
121012011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12102
12103 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12104 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12105 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12106
841a1577 121072011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12108
12109 * lisp.h (Qdebug): List symbol.
895009e1 12110 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12111 * keyboard.c (debug-on-event): New variable.
12112 (handle_user_signal): Break into debugger when debug-on-event
12113 matches the current signal symbol.
12114
f2d3ba6f
DN
121152011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12116
12117 * alloc.c (check_sblock, check_string_bytes)
12118 (check_string_free_list): Convert to standard C.
12119
42ce4c63
TZ
121202011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12121
12122 * w32.c (emacs_gnutls_push): Fix typo.
12123
825cd63c
EZ
121242011-04-25 Eli Zaretskii <eliz@gnu.org>
12125
fb11d64d
EZ
12126 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12127 "cast to pointer from integer of different size".
12128
825cd63c
EZ
12129 Improve doprnt and its use in verror. (Bug#8545)
12130 * doprnt.c (doprnt): Document the set of format control sequences
12131 supported by the function. Use SAFE_ALLOCA instead of always
12132 using `alloca'.
12133
12134 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12135 is one byte too soon. Don't use xrealloc; instead xfree and
12136 xmalloc anew.
12137
e061a11b
TZ
121382011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12139
12140 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12141 callbacks stage.
12142
12143 * gnutls.c: Renamed global_initialized to
12144 gnutls_global_initialized. Added internals for the
12145 :verify-hostname-error, :verify-error, and :verify-flags
12146 parameters of `gnutls-boot' and documented those parameters in the
12147 docstring. Start callback support.
9173deec
JB
12148 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12149 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12150 on error. Return error code.
e061a11b
TZ
12151 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12152 (emacs_gnutls_read): Likewise.
12153 (Fgnutls_boot): Return handshake error code.
12154 (emacs_gnutls_handle_error): New function.
12155 (wsaerror_to_errno): Likewise.
12156
12157 * w32.h (emacs_gnutls_pull): Add prototype.
12158 (emacs_gnutls_push): Likewise.
12159
12160 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12161 (emacs_gnutls_push): Likewise.
12162
121632011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12164
12165 * process.c (wait_reading_process_output): Check if GnuTLS
12166 buffered some data internally if no FDs are set for TLS
12167 connections.
12168
12169 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12170 (LIBS): Link to USER_LIBS.
12171 ($(BLD)/gnutls.$(0)): New target.
12172
fa6996bc
EZ
121732011-04-24 Eli Zaretskii <eliz@gnu.org>
12174
eb35682e
EZ
12175 * xdisp.c (handle_single_display_spec): Rename the
12176 display_replaced_before_p argument into display_replaced_p, to
12177 make it consistent with the commentary. Fix typos in the
12178 commentary.
12179
e2ad650c
EZ
12180 * textprop.c (syms_of_textprop): Remove dead code.
12181 (copy_text_properties): Delete obsolete commentary about an
12182 interface that was deleted long ago. Fix typos in the description
12183 of arguments.
12184
1b2de274
EZ
12185 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12186 to changes in oldXMenu/XMenu.h from 2011-04-16.
12187 <menu_help_message, prev_menu_help_message>: Constify.
12188 (IT_menu_make_room): menu->help_text is now `const char **';
12189 adjust.
12190
12191 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12192 to changes in oldXMenu/XMenu.h from 2011-04-16.
12193 (struct XMenu): Declare `help_text' `const char **'.
12194
12195 * xfaces.c <Qunspecified>: Make extern again.
12196
12197 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12198 required by POSIX.
1b2de274 12199
762b15be
EZ
12200 * doc.c (get_doc_string): Improve the format passed to `error'.
12201
12202 * doprnt.c (doprnt): Improve commentary.
12203
12204 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12205
12206 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12207 them with etags.
12208
f1052e5d
EZ
12209 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12210 changes in globals.h immediately force recompilation.
762b15be
EZ
12211 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12212 $(CURDIR)/s/ms-w32.h.
12213 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12214
fa6996bc
EZ
12215 * character.c (Fchar_direction): Function deleted.
12216 (syms_of_character): Don't defsubr it.
12217 <char-direction-table>: Deleted.
12218
e6c3da20
EZ
122192011-04-23 Eli Zaretskii <eliz@gnu.org>
12220
12221 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12222 * doprnt.c: Include limits.h.
12223 (SIZE_MAX): New macro.
04f2d78b
CB
12224 (doprnt): Return a size_t value. 2nd arg is now size_t.
12225 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12226 Improve overflow protection. Support `l' modifier for integer
12227 conversions. Support %l conversion. Don't assume an EMACS_INT
12228 argument for integer conversions and for %c.
12229
12230 * lisp.h (doprnt): Restore prototype.
12231
12232 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12233 $(SRC)/character.h.
12234
12235 * Makefile.in (base_obj): Add back doprnt.o.
12236
12237 * deps.mk (doprnt.o): Add back prerequisites.
12238 (callint.o): Depend on character.h.
12239
12240 * eval.c (internal_lisp_condition_case): Include the handler
12241 representation in the error message.
12242 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12243 when breaking from the loop.
12244
12245 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12246
12247 * callint.c (Fcall_interactively): When displaying error message
12248 about invalid control letter, pass the character's codepoint, not
12249 a pointer to its multibyte form. Improve display of the character
12250 in octal and display also its hex code.
12251
12252 * character.c (char_string): Use %x to display the (unsigned)
12253 codepoint of an invalid character, to avoid displaying a bogus
12254 negative value.
12255
12256 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12257 `error', not SYMBOL_NAME itself.
12258
12259 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12260 character arguments to `error'.
12261
12262 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12263 to `error' in error message about FINAL_CHAR argument. Make sure
12264 FINAL_CHAR is a character, and use %c when it is passed as
12265 argument to `error'.
12266
4ffd0d6b 122672011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12268
12269 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12270
12271 * w32.c: Include <time.h>.
12272 (sys_localtime): New function.
12273
4ffd0d6b 122742011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12275
12276 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12277
4ffd0d6b 12278 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12279
4ffd0d6b 122802011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12281
4ffd0d6b
GM
12282 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12283 zombies (Bug#8467).
aac0c6e3 12284
04c56954
EZ
122852011-04-19 Eli Zaretskii <eliz@gnu.org>
12286
12287 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12288 gl_state.e_property when gl_state.object is Qt.
12289
12290 * insdel.c (make_gap_larger): Remove limitation of buffer size
12291 to <= INT_MAX.
12292
16a43933
CY
122932011-04-18 Chong Yidong <cyd@stupidchicken.com>
12294
12295 * xdisp.c (lookup_glyphless_char_display)
12296 (produce_glyphless_glyph): Handle cons cell entry in
12297 glyphless-char-display.
12298 (Vglyphless_char_display): Document it.
12299
12300 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12301 glyphless-char-display.
12302
4581706e
CY
123032011-04-17 Chong Yidong <cyd@stupidchicken.com>
12304
12305 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12306
12307 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12308
12309 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12310 definition for no-X builds.
12311
4887c6e2 123122011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12313
fd35b6f9
PE
12314 Static checks with GCC 4.6.0 and non-default toolkits.
12315
5c1ccb01
PE
12316 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12317
006c5daa
PE
12318 * process.c (keyboard_bit_set): Define only if SIGIO.
12319 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12320 (send_process): Repair possible setjmp clobbering.
12321
efc736d3
PE
12322 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12323
4e2fe2e6
PE
12324 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12325
f97334a2
PE
12326 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12327
4e75f29d
PE
12328 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12329 Define only if needed.
12330
90efadd1
PE
12331 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12332 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12333 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12334
3c647824
PE
12335 * dispextern.h (struct redisplay_interface): Rename param
12336 to avoid shadowing.
e264f262 12337 * termhooks.h (struct terminal): Likewise.
761383f4 12338 * xterm.c (xembed_send_message): Likewise.
3c647824 12339
b58c5c4a
PE
12340 * insdel.c (make_gap_smaller): Define only if
12341 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12342
cad59032
PE
12343 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12344 it.
12345
c339dc2e
PE
12346 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12347 so that we aren't warned about unused symbols.
12348
91a3e27b
PE
12349 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12350
399c71d3 12351 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12352
8ffc96f5
PE
12353 * xfns.c (x_real_positions): Mark locals as initialized.
12354
eef9bc79
PE
12355 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12356
098db9dd
PE
12357 * xterm.c: Fix problems found by static analysis with other toolkits.
12358 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12359 (x_dispatch_event): Declare static if USE_GTK, and
12360 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12361 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12362 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12363 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12364 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12365
eb18f6cc
PE
12366 * xmenu.c (menu_help_callback): Pointer type fixes.
12367 Use const pointers when pointing at readonly data. Avoid pointer
12368 signedness clashes.
12369 (FALSE): Remove unused macro.
12370 (update_frame_menubar): Remove unused decl.
12371
1fe72bf8
PE
12372 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12373
60d9e1db
PE
12374 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12375 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12376 (single_menu_item): Rename local to avoid shadowing.
12377
39261c26
PE
12378 * keyboard.c (make_lispy_event): Remove unused local var.
12379
018c5e19
PE
12380 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12381 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12382
63d2b86e
PE
12383 * bitmaps: Change bitmaps from unsigned char back to the X11
12384 compatible char. Avoid the old compiler warnings about
12385 out-of-range initializers by using, for example, '\xab' rather
12386 than 0xab.
12387
aefd87e1
PE
12388 * xgselect.c (xgselect_initialize): Check vs interface
12389 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12390
bf501fb9
PE
12391 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12392
e9829fdf
PE
12393 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12394 to read-only memory.
12395
1086c095
PE
12396 * fns.c (vector): Remove; this old hack is no longer needed.
12397
2baccd04 12398 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12399 Remove unused var.
dde42981 12400 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12401
72391843 12402 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12403
436c16df 12404 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12405 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12406 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12407
92bb796d 12408 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12409 (x_term_init): Remove local to avoid shadowing.
92bb796d 12410
764430a3 12411 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12412
12413 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12414 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12415
d1dfb56c
EZ
124162011-04-16 Eli Zaretskii <eliz@gnu.org>
12417
c4354cb4
EZ
12418 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12419
d1dfb56c
EZ
12420 Fix regex.c, syntax.c and friends for buffers > 2GB.
12421 * syntax.h (struct gl_state_s): Declare character position members
12422 EMACS_INT.
12423
12424 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12425
04f2d78b
CB
12426 * textprop.c (verify_interval_modification, interval_of):
12427 Declare arguments EMACS_INT.
d1dfb56c
EZ
12428
12429 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12430 EMACS_INT.
12431
12432 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12433
12434 * indent.c (Fvertical_motion): Local variable it_start is now
12435 EMACS_INT.
12436
12437 * regex.c (re_match, re_match_2, re_match_2_internal)
12438 (bcmp_translate, regcomp, regexec, print_double_string)
12439 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12440 (re_compile_pattern, re_exec): Declare arguments and local
12441 variables `size_t' and `ssize_t' and return values `regoff_t', as
12442 appropriate.
12443 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12444 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12445 <compile_stack_type>: `size' and `avail' are now `size_t'.
12446
12447 * regex.h <regoff_t>: Use ssize_t, not int.
12448 (re_search, re_search_2, re_match, re_match_2): Arguments that
12449 specify buffer/string position and length are now ssize_t and
12450 size_t. Return type is regoff_t.
12451
613052cd
BK
124522011-04-16 Ben Key <bkey76@gmail.com>
12453
12454 * nsfont.m: Fixed bugs in ns_get_family and
12455 ns_descriptor_to_entity that were caused by using free to
12456 deallocate memory blocks that were allocated by xmalloc (via
12457 xstrdup). This caused Emacs to crash when compiled with
12458 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12459 --enable-checking=xmallocoverrun). xfree is now used to
12460 deallocate these memory blocks.
12461
4170f62f 124622011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12463
71b41406
PE
12464 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12465
9587a89d
PE
12466 emacs_write: Accept and return EMACS_INT for sizes.
12467 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12468 et seq.
12469 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12470 Accept and return EMACS_INT.
12471 (emacs_gnutls_write): Return the number of bytes written on
12472 partial writes.
12473 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12474 (emacs_read, emacs_write): Remove check for negative size, as the
12475 Emacs source code has been audited now.
9587a89d
PE
12476 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12477 (emacs_read, emacs_write): Use it.
273a5f82
PE
12478 * process.c (send_process): Adjust to the new signatures of
12479 emacs_write and emacs_gnutls_write. Do not attempt to store
12480 a byte offset into an 'int'; it might overflow.
9587a89d 12481 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12482
3e047f51
PE
12483 * sound.c: Don't assume sizes fit in 'int'.
12484 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12485 Return EMACS_INT, not int.
3e047f51 12486 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12487 Accept EMACS_INT, not int.
12488 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12489 record read return values.
12490
cc39a9db
BK
124912011-04-15 Ben Key <bkey76@gmail.com>
12492
c9d0ec6d
JB
12493 * keyboard.c (Qundefined): Don't declare static since it is used
12494 in nsfns.m.
12495 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12496 static since they are used in nsfont.m.
cc39a9db 12497
6c60eb9f
SM
124982011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12499
12500 * process.c (Qprocessp): Don't declare static.
12501 * lisp.h (Qprocessp): Declare again.
12502
7990b61a
JB
125032011-04-15 Juanma Barranquero <lekktu@gmail.com>
12504
12505 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12506
5d4cb038
PE
125072011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12508
8bd7b830 12509 Improve C-level modularity by making more things 'static'.
cd64ea1d 12510
e3b27b31
PE
12511 Don't publish debugger-only interfaces to other modules.
12512 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12513 (verify_bytepos, count_markers): Move decls to the only modules
12514 that need them.
12515 * region-cache.h (pp_cache): Likewise.
12516 * window.h (check_all_windows): Likewise.
12517 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12518
5d4cb038
PE
12519 * sysdep.c (croak): Now static, if
12520 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12521 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12522
12523 * alloc.c (refill_memory_reserve): Now static if
12524 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12525 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12526
e87b6180
PE
12527 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12528 Define only if USE_LUCID.
12529
ac64929e
PE
12530 * xrdb.c (x_customization_string, x_rm_string): Now static.
12531
6f37259d
PE
12532 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12533 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12534
1683e3ab
PE
12535 * xdisp.c (draw_row_with_mouse_face): Now static.
12536 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12537
de9c2632
PE
12538 * window.h (check_all_windows): Mark externally visible.
12539
2b96acb7
PE
12540 * window.c (window_deletion_count): Now static.
12541
12542 * undo.c: Make symbols static if they're not exported.
12543 (last_undo_buffer, last_boundary_position, pending_boundary):
12544 Now static.
12545
50436f33
PE
12546 * textprop.c (interval_insert_behind_hooks): Now static.
12547 (interval_insert_in_front_hooks): Likewise.
12548
64520e5c
PE
12549 * term.c: Make symbols static if they're not exported.
12550 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12551 (max_frame_lines, tty_set_terminal_modes):
12552 (tty_reset_terminal_modes, tty_turn_off_highlight):
12553 (get_tty_terminal): Now static.
12554 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12555 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12556 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12557 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12558 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12559
1fa53021
PE
12560 * sysdep.c: Make symbols static if they're not exported.
12561 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12562 Now static.
12563 (sigprocmask_set, full_mask): Remove; unused.
12564 (wait_debugging): Mark as visible.
12565 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12566 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12567
d4b43b22
PE
12568 * syntax.c (syntax_temp): Define only if !__GNUC__.
12569
b7c513d0
PE
12570 * sound.c (current_sound_device, current_sound): Now static.
12571
989b29ad
PE
12572 * search.c (searchbufs, searchbuf_head): Now static.
12573
13a55a78
PE
12574 * scroll.c (scroll_cost): Remove; unused.
12575 * dispextern.h (scroll_cost): Remove decl.
12576
de68a1fc
PE
12577 * region-cache.h (pp_cache): Mark as externally visible.
12578
40ccffa6
PE
12579 * process.c: Make symbols static if they're not exported.
12580 (process_tick, update_tick, create_process, chan_process):
12581 (Vprocess_alist, proc_buffered_char, datagram_access):
12582 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12583 (deactivate_process): Mark defn as static, as well as decl.
12584 * lisp.h (create_process): Remove decl.
12585 * process.h (chan_process, Vprocess_alist): Remove decls.
12586
ad64fc97
PE
12587 * print.c: Make symbols static if they're not exported.
12588 (print_depth, new_backquote_output, being_printed, print_buffer):
12589 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12590 (print_interval, print_number_index, initial_stderr_stream):
12591 Now static.
12592 * lisp.h (Fprinc): Remove decl.
12593 (debug_output_compilation_hack): Mark as externally visible.
12594
adddb265
PE
12595 * sysdep.c (croak): Move decl from here to syssignal.h.
12596 * syssignal.h (croak): Put it here, so the API can be checked when
12597 'croak' is called from dissociate_if_controlling_tty.
12598
1717ede2
PE
12599 * minibuf.c: Make symbols static if they're not exported.
12600 (minibuf_save_list, choose_minibuf_frame): Now static.
12601 * lisp.h (choose_minibuf_frame): Remove decl.
12602
fa5fb2bc
PE
12603 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12604
1e3890d1
PE
12605 * lread.c: Make symbols static if they're not exported.
12606 (read_objects, initial_obarray, oblookup_last_bucket_number):
12607 Now static.
12608 (make_symbol): Remove; unused.
12609 * lisp.h (initial_obarray, make_symbol): Remove decls.
12610
8a1414fa
PE
12611 * keyboard.c: Make symbols static if they're not exported.
12612 (single_kboard, recent_keys_index, total_keys, recent_keys):
12613 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12614 (this_single_command_key_start, echoing, last_auto_save):
12615 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12616 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12617 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12618 (Vlispy_mouse_stem, double_click_count):
12619 Now static.
12620 (force_auto_save_soon): Define only if SIGDANGER.
12621 (ignore_mouse_drag_p): Now static if
12622 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12623 (print_help): Remove; unused.
12624 (stop_character, last_timer_event): Mark as externally visible.
12625 * keyboard.h (ignore_mouse_drag_p): Declare only if
12626 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12627 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12628 * lisp.h (echoing): Remove decl.
12629 (force_auto_save_soon): Declare only if SIGDANGER.
12630 * xdisp.c (redisplay_window): Simplify code, to make it more
12631 obvious that ignore_mouse_drag_p is not accessed if !defined
12632 USE_GTK && !defined HAVE_NS.
12633
93ea6e8f
PE
12634 * intervals.c: Make symbols static if they're not exported.
12635 (merge_properties_sticky, merge_interval_right, delete_interval):
12636 Now static.
12637 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12638
77382fcc
PE
12639 * insdel.c: Make symbols static if they're not exported.
12640 However, leave prepare_to_modify_buffer alone. It's never
12641 called from outside this function, but that appears to be a bug.
12642 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12643 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12644 (adjust_after_replace_noundo): Remove; unused.
12645 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12646 (signal_before_change): Remove decls.
77382fcc 12647
9306c32e
PE
12648 * indent.c (val_compute_motion, val_vmotion): Now static.
12649
cd44d2eb
PE
12650 * image.c: Make symbols static if they're not exported.
12651 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12652 if USE_GTK.
12653 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12654 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12655
ad9a7a06
PE
12656 * fringe.c (standard_bitmaps): Now static.
12657 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12658
81626931
PE
12659 * frame.c: Make symbols static if they're not exported.
12660 (x_report_frame_params, make_terminal_frame): Now static.
12661 (get_frame_param): Now static, unless HAVE_NS.
12662 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12663 (x_get_resource_string): Remove; not used.
12664 * frame.h (make_terminal_frame, x_report_frame_params):
12665 (x_get_resource_string); Remove decls.
12666 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12667 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12668
239f9db9
PE
12669 * font.c, fontset.c: Make symbols static if they're not exported.
12670 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12671 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12672 * font.c (font_close_object): Now static.
12673 * font.h (font_close_object): Remove.
12674 * fontset.c (FONTSET_OBJLIST): Remove.
12675 (free_realized_fontset) #if-0 the body, which does nothing.
12676 (face_suitable_for_char_p): #if-0, as it's never called.
12677 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12678 * xfaces.c (face_at_string_position):
12679 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12680 since 0 is always ASCII.
12681
dfcf3579
PE
12682 * fns.c (weak_hash_tables): Now static.
12683
5045092b
PE
12684 * fileio.c: Make symbols static if they're not exported.
12685 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12686 (Vwrite_region_annotation_buffers): Now static.
12687
57a96f5c
PE
12688 * eval.c: Make symbols static if they're not exported.
12689 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12690 * lisp.h (backtrace_list): Remove decl.
12691
35f08c38
PE
12692 * emacs.c: Make symbols static if they're not exported.
12693 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12694 (fatal_error_code, fatal_error_signal_hook, standard_args):
12695 Now static.
12696 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12697 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12698 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12699 * lisp.h (fatal_error_signal_hook): Remove decl.
12700 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12701
f44bd759
PE
12702 * editfns.c: Move a (normally-unused) function to its only use.
12703 * editfns.c, lisp.h (get_operating_system_release): Remove.
12704 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12705 worth the hassle of breaking this out.
12706
b532497d
PE
12707 * xterm.c: Make symbols static if they're not exported.
12708 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12709 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12710 (x_destroy_window, x_delete_display):
12711 Now static.
12712 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12713 (x_mouse_leave): Remove; unused.
12714 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12715 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12716 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12717 Remove decls.
12718 (x_mouse_leave): Declare only if WINDOWSNT.
12719 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12720 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12721 USE_X_TOOLKIT.
12722
1675728f
PE
12723 * ftxfont.c: Make symbols static if they're not exported.
12724 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12725 HAVE_FREETYPE.
12726 * font.h (ftxfont_driver): Likewise.
12727
e4cebfca
PE
12728 * xfns.c: Make symbols static if they're not exported.
12729 (x_last_font_name, x_display_info_for_name):
12730 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12731 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12732 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12733 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12734 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12735 (last_show_tip_args): Now static.
12736 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12737 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12738 (x_screen_planes): Remove; unused.
12739 * dispextern.h (x_screen_planes): Remove decl.
12740
5bf46f05
PE
12741 * dispnew.c: Make symbols static if they're not exported.
12742 * dispextern.h (redraw_garbaged_frames, scrolling):
12743 (increment_row_positions): Remove.
12744 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12745 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12746 Now static.
12747 (redraw_garbaged_frames): Remove; unused.
12748
435f4c28
PE
12749 * xfaces.c: Make symbols static if they're not exported.
12750 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12751 Remove decls.
12752 * xterm.h (defined_color): Remove decls.
12753 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12754 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12755 (menu_face_changed_default, defined_color, free_realized_face):
12756 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12757 (ascii_face_of_lisp_face): Remove; unused.
12758
8524aef3
PE
12759 * xdisp.c: Make symbols static if they're not exported.
12760 * dispextern.h (scratch_glyph_row, window_box_edges):
12761 (glyph_to_pixel_coords, set_cursor_from_row):
12762 (get_next_display_element, set_iterator_to_next):
12763 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12764 (show_mouse_face): Remove decls
12765 * frame.h (message_buf_print): Likewise.
12766 * lisp.h (pop_message, set_message, check_point_in_composition):
12767 Likewise.
12768 * xterm.h (set_vertical_scroll_bar): Likewise.
12769 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12770 (message_buf_print, scratch_glyph_row, displayed_buffer):
12771 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12772 (get_next_display_element, show_mouse_face, window_box_edges):
12773 (frame_to_window_pixel_xy, check_point_in_composition):
12774 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12775 (glyph_to_pixel_coords): Remove; unused.
12776
16390cd2
PE
12777 * dired.c (file_name_completion): Now static.
12778
12779 * dbusbind.c (xd_in_read_queued_messages): Now static.
12780
a25f4dfa
PE
12781 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12782 * data.c (circular_list_error): Remove.
12783
14a9c8df
PE
12784 * commands.h (last_point_position, last_point_position_buffer):
12785 (last_point_position_window): Remove decls.
12786 * keyboard.c: Make these variables static.
12787
04f2d78b
CB
12788 * coding.h (coding, code_convert_region, encode_coding_gap):
12789 Remove decls.
74ab6df5
PE
12790 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12791 (iso_code_class, detect_coding, code_convert_region): Now static.
12792 (encode_coding_gap): Remove; unused.
12793
38dfbee1
PE
12794 * chartab.c (chartab_chars, chartab_bits): Now static.
12795
a2cb4e63
PE
12796 * charset.h (charset_iso_8859_1): Remove decl.
12797 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12798 Now static.
12799
127198fd
PE
12800 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12801 * ccl.c (Vccl_program_table): Now static.
12802 (check_ccl_update): Remove; unused.
12803
d85b608f
PE
12804 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12805 * category.h: ... from here.
12806 * category.c (check_category_table, set_category_set): Now static.
12807
31cd66f3
PE
12808 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12809 * lisp.h: Remove these decls.
12810
c358e587
PE
12811 * buffer.c (buffer_count): Remove unused var.
12812
e78aecca
PE
12813 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12814 so that it's not optimized away.
12815 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12816 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12817 exported only to the debugger.
12818
e192d7d3 12819 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12820 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12821
92470028
PE
12822 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12823 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12824 was inaccessible from Lisp.
12825 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12826 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12827
244ed907
PE
12828 alloc.c: Import and export fewer symbols, and remove unused items.
12829 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12830 is defined.
12831 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12832 it's not optimized away by whole-program optimization.
12833 (message_enable_multibyte, free_misc): Remove.
12834 (catchlist, handlerlist, mark_backtrace):
12835 Declare only if BYTE_MARK_STACK.
12836 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12837 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12838 (message_enable_multibyte): Remove decl.
12839 (free_misc, interval_free_list, float_block, float_block_index):
12840 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12841 (cons_free_list, last_marked_index):
12842 Now static.
12843 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12844 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12845 (mark_backtrace): Define only if BYTE_MARK_STACK.
12846 * xdisp.c (message_enable_multibyte): Now static.
12847
61c2b50e 12848 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12849 This makes it easier for human readers (and static analyzers)
12850 to see whether these variables are used from other modules.
12851 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12852 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12853 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12854 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12855 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12856 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12857 * xmenu.c, xselect.c:
12858 Declare Q* vars static if they are not used in other modules.
12859 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12860 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12861 Remove decls of unexported vars.
12862 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12863
95c82688
PE
12864 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12865
16a97296
PE
12866 Make Emacs functions such as Fatom 'static' by default.
12867 This makes it easier for human readers (and static analyzers)
12868 to see whether these functions can be called from other modules.
12869 DEFUN now defines a static function. To make the function external
12870 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12871 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12872 (Finit_image_library):
16a97296
PE
12873 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12874 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12875 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12876 Remove decls, since these functions are now static.
12877 (Funintern, Fget_internal_run_time): New decls, since these functions
12878 were already external.
95c82688 12879
16a97296
PE
12880 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12881 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12882 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12883 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12884 * keyboard.c, keymap.c, lread.c:
12885 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12886 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12887 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12888 Mark functions with DEFUE instead of DEFUN,
12889 if they are used in other modules.
12890 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12891 decls for now-static functions.
12892 * buffer.h (Fdelete_overlay): Remove decl.
12893 * callproc.c (Fgetenv_internal): Mark as internal.
12894 * composite.c (Fremove_list_of_text_properties): Remove decl.
12895 (Fcomposition_get_gstring): New forward static decl.
12896 * composite.h (Fcomposite_get_gstring): Remove decl.
12897 * dired.c (Ffile_attributes): New forward static decl.
12898 * doc.c (Fdocumntation_property): New forward static decl.
12899 * eval.c (Ffetch_bytecode): New forward static decl.
12900 (Funintern): Remove extern decl; now in .h file where it belongs.
12901 * fileio.c (Fmake_symbolic_link): New forward static decl.
12902 * image.c (Finit_image_library): New forward static decl.
12903 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12904 * intervals.h (Fprevious_property_change):
12905 (Fremove_list_of_text_properties): Remove decls.
12906 * keyboard.c (Fthis_command_keys): Remove decl.
12907 (Fcommand_execute): New forward static decl.
12908 * keymap.c (Flookup_key): New forward static decl.
12909 (Fcopy_keymap): Now static.
12910 * keymap.h (Flookup_key): Remove decl.
12911 * process.c (Fget_process): New forward static decl.
12912 (Fprocess_datagram_address): Mark as internal.
12913 * syntax.c (Fsyntax_table_p): New forward static decl.
12914 (skip_chars): Remove duplicate decl.
12915 * textprop.c (Fprevious_property_change): New forward static decl.
12916 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12917 Now internal.
12918 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12919 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12920
785bbd42
PE
12921 * editfns.c (Fformat): Remove unreachable code.
12922
8b913b57
AS
129232011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12924
12925 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12926 change. (Bug#8496)
12927
a6744a35
EZ
129282011-04-13 Eli Zaretskii <eliz@gnu.org>
12929
12930 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12931 when at ZV. (Bug#8487)
12932
e7974947
AS
129332011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12934
baad03f0
AS
12935 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12936 (Bug#8437)
12937 * keyboard.c (parse_tool_bar_item): Likewise.
12938 * sound.c (sound_cleanup, alsa_close): Likewise.
12939 * termcap.c (tgetent): Likewise.
12940 * xfns.c (x_default_font_parameter): Likewise.
12941 * xsettings.c (read_and_apply_settings): Likewise.
12942
e7974947
AS
12943 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12944 (overrun_check_free): Protoize.
12945
28272684
PE
129462011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12947
12948 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12949 since callers should never pass a negative size.
12950 Change the signature to match that of plain 'read' and 'write'; see
12951 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12952 * lisp.h: Update prototypes of emacs_write and emacs_read.
12953
11997c76
EZ
129542011-04-11 Eli Zaretskii <eliz@gnu.org>
12955
12956 * xdisp.c (redisplay_window): Don't try to determine the character
12957 position of the scroll margin if the window start point w->startp
e896f03c 12958 is outside the buffer's accessible region. (Bug#8468)
11997c76 12959
8a2cbd72
EZ
129602011-04-10 Eli Zaretskii <eliz@gnu.org>
12961
12962 Fix write-region and its subroutines for buffers > 2GB.
12963 * fileio.c (a_write, e_write): Modify declaration of arguments and
12964 local variables to support buffers larger than 2GB.
12965 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12966
12967 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12968 argument, local variables, and return value.
12969
12970 * lisp.h: Update prototypes of emacs_write and emacs_read.
12971
12972 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12973
4073e537 129742011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12975
1ebfdcb6
PE
12976 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12977
b2ded58d
PE
12978 Fix more problems found by GCC 4.6.0's static checks.
12979
7d66342c
PE
12980 * xdisp.c (vmessage): Use a better test for character truncation.
12981
bbf47d44
PE
12982 * charset.c (load_charset_map): <, not <=, for optimization,
12983 and to avoid potential problems with integer overflow.
9248994d 12984 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12985 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12986 * editfns.c (Fformat): Likewise.
1e69125e 12987 * syntax.c (skip_chars): Likewise.
3befa583 12988
e3019616
PE
12989 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12990 This also lets GCC 4.6.0 generate slightly better loop code.
12991
becfa255
PE
12992 * callint.c (Fcall_interactively): <, not <=, for optimization.
12993 (Fcall_interactively): Count the number of arguments produced,
12994 not the number of arguments given. This is simpler and lets GCC
12995 4.6.0 generate slightly better code.
12996
dae0cd48
PE
12997 * ftfont.c: Distingish more carefully between FcChar8 and char.
12998 The previous code passed unsigned char * to a functions like
12999 strlen and xstrcasecmp that expect char *, which does not
13000 conform to the C standard.
13001 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13002 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13003 char * when the C standard requires it.
13004
76032d70
PE
13005 * keyboard.c (read_char): Remove unused var.
13006
eb3f1cc8
PE
13007 * eval.c: Port to Windows vsnprintf (Bug#8435).
13008 Include <limits.h>.
13009 (SIZE_MAX): Define if the headers do not.
13010 (verror): Do not give up if vsnprintf returns a negative count.
13011 Instead, grow the buffer. This ports to Windows vsnprintf, which
13012 does not conform to C99. Problem reported by Eli Zaretskii.
13013 Also, simplify the allocation scheme, by avoiding the need for
13014 calling realloc, and removing the ALLOCATED variable.
13015
70476b54
PE
13016 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13017
12020a9e
PE
13018 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13019 But keep the doprint source code for now, as we might revamp it
13020 and use it again (Bug#8435).
ea6c7ae6
PE
13021 * lisp.h (doprnt): Remove.
13022 * Makefile.in (base_obj): Remove doprnt.o.
13023 * deps.mk (doprnt.o): Remove.
13024
5fdb398c
PE
13025 error: Print 32- and 64-bit integers portably (Bug#8435).
13026 Without this change, on typical 64-bit hosts error ("...%d...", N)
13027 was used to print both 32- and 64-bit integers N, which relied on
13028 undefined behavior.
61bdb816 13029 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13030 * lisp.h (error, verror): Mark as printf-like functions.
13031 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13032 Report overflow in size calculations when allocating printf buffer.
13033 Do not truncate output string at its first null byte.
13034 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13035 Truncate the output at a character boundary, since vsnprintf does not
13036 do that.
13037 * charset.c (check_iso_charset_parameter): Convert internal
13038 character to string before calling 'error', since %c now has the
13039 printf meaning.
13040 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13041 overflow when computing char to be passed to 'error'. Do not
13042 pass Lisp_Object to 'error'; pass the integer instead.
13043 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13044 formatted with plain %d.
13045
b189fa66
PE
13046 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13047
bff87ef0
PE
13048 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13049
7e2cac20
PE
13050 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13051
ce4d90b5
PE
13052 * xterm.c (x_catch_errors): Remove duplicate declaration.
13053
266c9547
PE
13054 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13055
79c49ad2
PE
13056 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13057
368f4090
JM
130582011-04-10 Jim Meyering <meyering@redhat.com>
13059
13060 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13061 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13062 return ssize_t not "int", and use size_t as the buffer length.
13063 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13064 * gnutls.h: Update declarations.
13065 * process.c (read_process_output): Use ssize_t, to match.
13066 (send_process): Likewise.
13067
a32d4040
CY
130682011-04-09 Chong Yidong <cyd@stupidchicken.com>
13069
13070 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13071
8546720e 130722011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13073
04f2d78b
CB
13074 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13075 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13076
8546720e
GM
13077 * xterm.c (handle_one_xevent):
13078 * xmenu.c (create_and_show_popup_menu):
13079 * xselect.c (x_decline_selection_request)
13080 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13081
0a2f5c1a 130822011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13083
13084 Fix some uses of `int' instead of EMACS_INT.
13085 * search.c (string_match_1, fast_string_match)
13086 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13087 (scan_buffer, find_next_newline_no_quit)
13088 (find_before_next_newline, search_command, Freplace_match)
13089 (Fmatch_data): Make some `int' variables be EMACS_INT.
13090
13091 * xdisp.c (display_count_lines): 3rd argument and return value now
13092 EMACS_INT. All callers changed.
13093 (pint2hrstr): Last argument is now EMACS_INT.
13094
13095 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13096 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13097 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13098 (decode_coding_utf_16, decode_coding_emacs_mule)
13099 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13100 (decode_coding_ccl, decode_coding_charset)
13101 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13102 (decode_coding_iso_2022, decode_coding_emacs_mule)
13103 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13104 <char_offset, last_offset>: Declare EMACS_INT.
13105 (encode_coding_utf_8, encode_coding_utf_16)
13106 (encode_coding_emacs_mule, encode_invocation_designation)
13107 (encode_designation_at_bol, encode_coding_iso_2022)
13108 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13109 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13110 Declare EMACS_INT.
13111 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13112 (encode_invocation_designation): Last argument P_NCHARS is now
13113 EMACS_INT.
13114 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13115 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13116
13117 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13118 All users changed.
13119
13120 * ccl.c (Fccl_execute_on_string): Declare some variables
13121 EMACS_INT.
13122
8546720e 131232011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13124
13125 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13126
4e19a977
CS
131272011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13128
13129 * process.c (Fformat_network_address): Doc fix.
13130
87302331
R
131312011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13132
ee7683eb 13133 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13134
cbb59342
CY
131352011-04-08 Chong Yidong <cyd@stupidchicken.com>
13136
13137 * keyboard.c (read_char): Call Lisp function help-form-show,
13138 instead of using internal_with_output_to_temp_buffer.
13139 (Qhelp_form_show): New var.
e0d38eeb 13140 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13141
13142 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13143
13144 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13145
e67a13ab
CY
131462011-04-06 Chong Yidong <cyd@stupidchicken.com>
13147
04f2d78b
CB
13148 * process.c (Flist_processes): Remove to Lisp.
13149 (list_processes_1): Delete.
e67a13ab 13150
973f782d
EZ
131512011-04-06 Eli Zaretskii <eliz@gnu.org>
13152
7c106b1e
EZ
13153 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13154
973f782d
EZ
13155 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13156
41cf7d1a 131572011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13158
ca23cc88
PE
13159 Fix more problems found by GCC 4.6.0's static checks.
13160
f390e2d5
PE
13161 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13162
42eea0d0
PE
13163 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13164
b69769da 13165 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13166
f9541e84
PE
13167 * xdisp.c (vmessage): Mark as a printf-like function.
13168
13841b55
PE
13169 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13170
c136c10f
PE
13171 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13172
5e2d4a30
PE
13173 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13174 printf-like functions.
13175 (tiff_load): Add casts to remove these marks before passing them
13176 to system-supplied API.
13177
583f48b9
PE
13178 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13179
b25d760e
PE
13180 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13181 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13182 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13183 directly, rather than having caller test rule sign. This avoids
13184 some unnecessary tests.
13185 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13186 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13187 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13188
bc7b6697 13189 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13190 (xfont_open): Avoid unnecessary tests.
bc7b6697 13191
27ccc379
PE
13192 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13193
dcd5c89a
PE
13194 * composite.h, composite.c (composition_gstring_put_cache):
13195 Use EMACS_INT, not int, for length.
13196
b13a45c6
PE
13197 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13198 breaking out part of COMPOSITION_DECODE_RULE.
13199 (COMPOSITION_DECODE_RULE): Use it.
13200 * composite.c (get_composition_id): Remove unused local vars,
13201 by using the new macro.
13202
1e792e4d
PE
13203 * textprop.c (set_text_properties_1): Change while to do-while,
13204 since the condition is always true at first.
13205
dc6c6455 13206 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13207 (interval_deletion_adjustment): Return unsigned value.
13208 All uses changed.
dc6c6455 13209
aba7731a
PE
13210 * process.c (list_processes_1, create_pty, read_process_output):
13211 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13212 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13213 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13214 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13215 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13216
fdfc4bf3
PE
13217 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13218
fca8fe46 13219 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13220 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13221
06a0259a 13222 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13223 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13224 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13225
e7b9e80f
PE
13226 * print.c (print_error_message): Avoid int overflow.
13227
56201685
PE
13228 * font.c (font_list_entities): Redo for clarity,
13229 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13230
78834453 13231 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13232 (font_score): Avoid potential overflow in diff calculation.
78834453 13233
0bc0b309 13234 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13235 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13236
e610eaca
PE
13237 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13238
b895abce
PE
13239 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13240 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13241 can always succeed if overflow has undefined behavior.
13242
1f1d9321 13243 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13244 (wordify): Omit three unnecessary tests.
1f1d9321 13245
c59478bc
PE
13246 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13247 All callers changed. This avoids the need for an unused var.
13248
79b73827
PE
13249 * casefiddle.c (casify_region): Remove var that is set but not used.
13250
a4db5dfe
PE
13251 * dired.c (file_name_completion): Remove var that is set but not used.
13252
43aae36e
PE
13253 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13254
2a47c44d 13255 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13256 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13257
a37c69bf
PE
13258 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13259 Check for integer overflow on size calculations.
13260
328ab8e7
PE
13261 * buffer.c (Fprevious_overlay_change): Remove var that is set
13262 but not used.
13263
e5a2a5cb
PE
13264 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13265 Remove vars that are set but not used.
8d84a6eb 13266 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13267 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13268
a60e5f68
PE
13269 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13270
f661cb61 13271 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13272 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13273
f0397f5a
PE
13274 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13275 that are set but not used.
13276
8664db06 13277 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13278 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13279
6abdaa4a
PE
13280 * xselect.c (x_get_local_selection, x_handle_property_notify):
13281 Remove vars that are set but not used.
13282
0ce7538d 13283 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13284 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13285
9ae848fc
PE
13286 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13287 Remove var that is set but not used.
0b918413
PE
13288 (scroll_bar_windows_size): Now size_t, not int.
13289 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13290 Check for overflow.
9ae848fc 13291
a5a62657
PE
13292 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13293 (map_tty_color) [!defined MSDOS]: Likewise.
13294
5c5cdd39
PE
13295 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13296
66ebf983
PE
13297 * coding.c: Remove vars that are set but not used.
13298 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13299 All callers changed.
13300 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13301 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13302 (decode_coding_charset): Remove vars that are set but not used.
13303
1be4d761
PE
13304 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13305 that is set but not used.
13306
47553fa8
PE
13307 * print.c (print_object): Remove var that is set but not used.
13308
1f7196bf 13309 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13310 The gnulib version avoids calling malloc in the usual case,
13311 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13312 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13313 * filelock.c (current_lock_owner): Likewise.
13314 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13315 * sysdep.c: Include allocator.h, careadlinkat.h.
13316 (emacs_no_realloc_allocator): New static constant.
13317 (emacs_readlink): New function.
fdb61804
PE
13318 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13319 ../lib/careadlinkat.h.
d1fdcab7 13320
f84c17c7
SM
133212011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13322
13323 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13324 first non-nil return value).
13325
ef3862ad
JD
133262011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13327
13328 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13329 if not defined (Bug#8403).
13330
376a7006
JB
133312011-04-02 Juanma Barranquero <lekktu@gmail.com>
13332
13333 * xdisp.c (display_count_lines): Remove parameter `start',
13334 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13335 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13336 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13337 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13338 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13339 and thereabouts. All callers changed.
13340 (get_per_char_metric): Remove parameter `f', unused since
13341 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13342
6ca3801d
JM
133432011-04-02 Jim Meyering <meyering@redhat.com>
13344
13345 do not dereference NULL upon failed strdup
13346 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13347 (ns_get_family): Likewise.
13348
d8e2b5ba
JB
133492011-04-02 Juanma Barranquero <lekktu@gmail.com>
13350
13351 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13352
8c74fcbd
JD
133532011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13354
13355 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13356 later (Bug#8403).
13357
7200d79c
SM
133582011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13359
03408648 13360 Add lexical binding.
7200d79c 13361
03408648
SM
13362 * window.c (Ftemp_output_buffer_show): New fun.
13363 (Fsave_window_excursion):
13364 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13365
13366 * lread.c (lisp_file_lexically_bound_p): New function.
13367 (Fload): Bind Qlexical_binding.
13368 (readevalloop): Remove `evalfun' arg.
13369 Bind Qinternal_interpreter_environment.
13370 (Feval_buffer): Bind Qlexical_binding.
13371 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13372 Mark as dynamic.
13373 (syms_of_lread): Declare `lexical-binding'.
13374
13375 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13376
13377 * keyboard.c (eval_dyn): New fun.
13378 (menu_item_eval_property): Use it.
ca105506
SM
13379
13380 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13381
03408648
SM
13382 * fns.c (concat, mapcar1): Accept byte-code-functions.
13383
13384 * eval.c (Fsetq): Handle lexical vars.
13385 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13386 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13387 (FletX, Flet): Obey lexical binding.
13388 (Fcommandp): Handle closures.
13389 (Feval): New `lexical' arg.
13390 (eval_sub): New function extracted from Feval. Use it almost
13391 everywhere where Feval was used. Look up vars in lexical env.
13392 Handle closures.
13393 (Ffunctionp): Move from subr.el.
13394 (Ffuncall): Handle closures.
13395 (apply_lambda): Remove `eval_flags'.
13396 (funcall_lambda): Handle closures and new byte-code-functions.
13397 (Fspecial_variable_p): New function.
13398 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13399 but without exporting it to Lisp.
23aba0ea 13400
23aba0ea 13401 * doc.c (Fdocumentation, store_function_docstring):
03408648 13402 * data.c (Finteractive_form): Handle closures.
23aba0ea 13403
03408648
SM
13404 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13405 interactive spec.
ba83908c 13406
04f2d78b
CB
13407 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13408 New byte-codes.
03408648
SM
13409 (exec_byte_code): New function extracted from Fbyte_code to handle new
13410 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13411
03408648 13412 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13413
03408648 13414 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13415
e2abce01
JB
134162011-03-31 Juanma Barranquero <lekktu@gmail.com>
13417
13418 * xdisp.c (redisplay_internal): Fix prototype.
13419
63696a73 134202011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13421
63696a73 13422 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13423 (try_scrolling): Use it when setting scroll_limit.
13424 Limit scrolling to 100 screen lines.
63696a73
EZ
13425 (redisplay_window): Even when falling back on "recentering",
13426 position point in the window according to scroll-conservatively,
13427 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13428
13429 (try_scrolling): When point is above the window, allow searching
13430 as far as scroll_max, or one screenful, to compute vertical
13431 distance from PT to the scroll margin position. This prevents
13432 try_scrolling from unnecessarily failing when
13433 scroll-conservatively is set to a value slightly larger than the
13434 window height. Clean up the case of PT below the margin at bottom
13435 of window: scroll_max can no longer be INT_MAX. When aggressive
13436 scrolling is in use, don't let point enter the opposite scroll
13437 margin as result of the scroll.
13438 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13439 threshold of 100 lines for never-recentering scrolling.
13440
e4cc2dfc
JB
134412011-03-31 Juanma Barranquero <lekktu@gmail.com>
13442
13443 * dispextern.h (move_it_by_lines):
13444 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13445 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13446 (message_log_check_duplicate): Remove parameters `prev_bol' and
13447 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13448 (redisplay_internal): Remove parameter `preserve_echo_area',
13449 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13450
13451 * indent.c (Fvertical_motion):
13452 * window.c (window_scroll_pixel_based, Frecenter):
13453 Don't pass `need_y_p' to `move_it_by_lines'.
13454
1c470562
SM
134552011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13456
44f230aa
SM
13457 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13458 steal a few bits to be more compact.
13459 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13460 Remove unneeded casts.
13461
1c470562
SM
13462 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13463
888adce9
ZK
134642011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13465
13466 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13467 binding" message (bug#7967).
13468
f838ed7b
PE
134692011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13470
77861b95
PE
13471 Fix more problems found by GCC 4.6.0's static checks.
13472
de6dbc14
PE
13473 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13474 Remove unused local var.
13475
f838ed7b
PE
13476 * editfns.c (Fmessage_box): Remove unused local var.
13477
792c7b2b
PE
13478 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13479 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13480 Omit unused local vars.
c499e557 13481 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13482 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13483 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13484 Omit unused local var.
13485
ba0165e1
PE
13486 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13487 Don't assume string length fits in int.
32ad8845 13488 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13489 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13490
3c59b4c9
PE
13491 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13492 instead of alloca (Bug#8344).
13493
a3eed478 13494 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13495 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13496
eb4d412d
PE
13497 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13498
1658b401
PE
13499 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13500 concerns.
13501
13502 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13503
13504 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13505
9a2c6e05
PE
13506 * keyboard.c (syms_of_keyboard): Use the same style as later
13507 in this function when indexing through an array. This also
13508 works around GCC bug 48267.
13509
03d0a109
PE
13510 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13511
44f730c8
PE
13512 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13513
fe75f926
PE
13514 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13515 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13516
ffa8c828
PE
13517 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13518 This avoids undefined behavior on integer overflow, and is a bit
13519 more convenient anyway since it is compared to a size_t variable.
13520
c5101a77
PE
13521 Variadic C functions now count arguments with size_t, not int.
13522 This avoids an unnecessary limitation on 64-bit machines, which
13523 caused (substring ...) to crash on large vectors (Bug#8344).
13524 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13525 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13526 All variadic functions and their callers changed accordingly.
c5101a77
PE
13527 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13528 * data.c (arith_driver, float_arith_driver): Likewise.
13529 * editfns.c (general_insert_function): Likewise.
13530 * eval.c (struct backtrace.nargs, interactive_p)
13531 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13532 (funcall_lambda, mark_backtrace): Likewise.
13533 * fns.c (concat): Likewise.
13534 * frame.c (x_set_frame_parameters): Likewise.
13535 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13536 0 if not found, not -1. All callers changed.
13537
dd3f25f7
PE
13538 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13539 (stack_copy_size): Now size_t, not int.
13540 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13541
461c2ab9
JB
135422011-03-28 Juanma Barranquero <lekktu@gmail.com>
13543
13544 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13545 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13546 All callers changed.
13547
13548 * lisp.h (multibyte_char_to_unibyte):
13549 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13550 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13551 * character.h (CHAR_TO_BYTE8):
13552 * cmds.c (internal_self_insert):
13553 * editfns.c (general_insert_function):
13554 * keymap.c (push_key_description):
13555 * search.c (Freplace_match):
13556 * xdisp.c (message_dolog, set_message_1): All callers changed.
13557
f6d62986
SM
135582011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13559
13560 * keyboard.c (safe_run_hook_funcall): New function.
13561 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13562 don't set the hook to nil, but remove the offending function instead.
13563 (Qcommand_hook_internal): Remove, unused.
13564 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13565 Vcommand_hook_internal.
13566
13567 * eval.c (enum run_hooks_condition): Remove.
13568 (funcall_nil, funcall_not): New functions.
13569 (run_hook_with_args): Call each function through a `funcall' argument.
13570 Remove `cond' argument, now redundant.
13571 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13572 (Frun_hook_with_args_until_failure): Adjust accordingly.
13573 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13574
1db5b1ad
JB
135752011-03-28 Juanma Barranquero <lekktu@gmail.com>
13576
13577 * dispextern.h (string_buffer_position): Remove declaration.
13578
13579 * print.c (strout): Remove parameter `multibyte', unused since
13580 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13581
13582 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13583 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13584 All callers changed.
13585
13586 * w32.c (_wsa_errlist): Use braces for struct initializers.
13587
13588 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13589 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13590 All callers changed.
13591 (string_buffer_position): Likewise. Also, make static (it's never
13592 used outside xdisp.c).
13593 (cursor_row_p): Remove parameter `w', unused since
13594 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13595 (decode_mode_spec): Remove parameter `precision', introduced during
13596 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13597 All callers changed.
13598
5ffb62aa
JD
135992011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13600
13601 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13602
461c2ab9 136032011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13604
13605 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13606 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13607 (ns_update_auto_hide_menu_bar): New functions.
13608 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13609 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13610 ns_constrain_all_frames.
13611 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13612 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13613
5c380ffb
JD
136142011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13615
13616 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13617
9af30bdf
GM
136182011-03-27 Glenn Morris <rgm@gnu.org>
13619
13620 * syssignal.h: Replace RETSIGTYPE with void.
13621 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13622 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13623 Replace SIGTYPE with void everywhere.
13624 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13625 * s/template.h (SIGTYPE): Remove commented out definition.
13626
e2abce01
JB
136272011-03-26 Eli Zaretskii <eliz@gnu.org>
13628
13629 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13630 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13631
f868cd8a
JB
136322011-03-26 Juanma Barranquero <lekktu@gmail.com>
13633
59eb0929
JB
13634 * w32.c (read_unc_volume): Use parameter `henum', instead of
13635 global variable `wget_enum_handle'.
13636
13637 * keymap.c (describe_vector): Remove parameters `indices' and
13638 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13639 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13640
f868cd8a
JB
13641 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13642
13643 * keyboard.c (timer_check): Remove parameter `do_it_now',
13644 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13645 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13646 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13647
13648 * keyboard.c (read_char):
13649 * w32menu.c (w32_menu_display_help):
13650 * xmenu.c (show_help_event, menu_help_callback):
13651 Adjust calls to `show_help_echo'.
13652
13653 * gtkutil.c (xg_maybe_add_timer):
13654 * keyboard.c (readable_events):
13655 * process.c (wait_reading_process_output):
13656 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13657
13658 * insdel.c (adjust_markers_gap_motion):
13659 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13660 (gap_left, gap_right): Don't call it.
13661
2ecf6fdb
CY
136622011-03-25 Chong Yidong <cyd@stupidchicken.com>
13663
13664 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13665 incurred during fontification.
13666
6b1f9ba4
JB
136672011-03-25 Juanma Barranquero <lekktu@gmail.com>
13668
13669 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13670 (DEFVAR_PER_BUFFER): Don't pass it.
13671
13672 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13673 (scrolling_window): Don't pass it.
13674
0f4a96b5
JB
136752011-03-25 Juanma Barranquero <lekktu@gmail.com>
13676
13677 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13678
13679 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13680 and `suffix'.
13681 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13682 of variables specific to SELinux and computation of `encoded_absname'.
13683
13684 * image.c (XPutPixel): Remove unused variable `height'.
13685
13686 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13687
13688 * unexw32.c (get_section_info): Remove unused variable `section'.
13689
13690 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13691 (system_process_attributes): Remove unused variable `sess'.
13692 (sys_read): Remove unused variable `err'.
13693
13694 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13695 (w32_wnd_proc): Remove unused variable `isdead'.
13696 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13697 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13698 (x_create_tip_frame): Remove unused variable `tem'.
13699
13700 * w32inevt.c (w32_console_read_socket):
13701 Remove unused variable `no_events'.
13702
13703 * w32term.c (x_draw_composite_glyph_string_foreground):
13704 Remove unused variable `width'.
13705
1149507c
JB
137062011-03-24 Juanma Barranquero <lekktu@gmail.com>
13707
13708 * w32term.c (x_set_glyph_string_clipping):
13709 Don't pass uninitialized region to CombineRgn.
13710
9c88f339
JB
137112011-03-23 Juanma Barranquero <lekktu@gmail.com>
13712
13713 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13714 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13715 (Fx_close_connection): Remove unused variable `i'.
13716
13717 * w32font.c (w32font_draw): Return number of glyphs.
13718 (w32font_open_internal): Remove unused variable `i'.
13719 (w32font_driver): Add missing initializer.
13720
13721 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13722 (fill_in_menu): Remove unused variable `items_added'.
13723
13724 * w32term.c (last_mouse_press_frame): Remove static global variable.
13725 (w32_clip_to_row): Remove unused variable `f'.
13726 (x_delete_terminal): Remove unused variable `i'.
13727
13728 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13729 (NOTHING): Remove unused static global variable.
13730 (uniscribe_check_otf): Remove unused variable `table'.
13731 (uniscribe_font_driver): Add missing initializers.
13732
dee091a3
JD
137332011-03-23 Julien Danjou <julien@danjou.info>
13734
13735 * term.c (Fsuspend_tty, Fresume_tty):
13736 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13737 * window.c (temp_output_buffer_show):
13738 * insdel.c (signal_before_change):
13739 * frame.c (Fhandle_switch_frame):
13740 * fileio.c (Fdo_auto_save):
13741 * emacs.c (Fkill_emacs):
13742 * editfns.c (save_excursion_restore):
13743 * cmds.c (internal_self_insert):
13744 * callint.c (Fcall_interactively):
13745 * buffer.c (Fkill_all_local_variables):
13746 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13747 Use Frun_hooks.
0f4a96b5 13748 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13749 unconditionally since it does the check itself.
dee091a3 13750
2c520ab5 137512011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13752
c9c49752
PE
13753 Fix more problems found by GCC 4.5.2's static checks.
13754
8abc3f12
PE
13755 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13756 the first time through the loop, since we know p0 < p1 then.
13757 This also avoids a gcc -Wstrict-overflow warning.
13758
a2d26660
PE
13759 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13760 leading to a memory leak, possible in functions like
13761 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13762 of objects (Bug#8318).
a2d26660 13763
916c72e9
PE
13764 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13765 that could (at least in theory) be that large.
13766
19ab8a18
PE
13767 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13768 This is less likely to overflow, and avoids undefined behavior if
13769 overflow does occur. All callers changed. Use strtoul to scan
13770 for the unsigned long integer.
b7cbbd6f
PE
13771 (pint2hrstr): Simplify and tune code slightly.
13772 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13773
f0641eff
PE
13774 * scroll.c (do_scrolling): Work around GCC bug 48228.
13775 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13776
7f650bb9
PE
13777 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13778 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13779 (validate_x_resource_name): Simplify count usage.
13780 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13781
37dd57d1
PE
13782 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13783 fail (Bug#8306).
81e56e61 13784
699979fc 13785 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13786
401bf9b4
PE
13787 * process.c (Fmake_network_process): Use socklen_t, not int,
13788 where POSIX says socklen_t is required in portable programs.
13789 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13790 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13791 (Fmake_network_process, server_accept_connection):
13792 (wait_reading_process_output, read_process_output):
13793 Likewise.
13794
b93aacde
PE
13795 * process.c: Rename or move locals to avoid shadowing.
13796 (list_processes_1, Fmake_network_process):
13797 (read_process_output_error_handler, exec_sentinel_error_handler):
13798 Rename or move locals.
4dc343ee 13799 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13800 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13801 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13802 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13803 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13804
af8a867c 13805 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13806 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13807 Include tparam.h instead, since it declares them.
af8a867c
PE
13808 * cm.h (PC): Remove extern decl; tparam.h now does this.
13809 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13810 * terminfo.c: Include tparam.h, to check interfaces.
13811 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13812 (tparam): Adjust signature to match interface in tparam.h;
13813 this removes some undefined behavior. Check that outstring and len
13814 are zero, which they always are with Emacs.
13815 * tparam.h (PC, BC, UP): New extern decls.
13816
0248044d 13817 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13818 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13819
8ff096c1 13820 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13821 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13822 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13823 (ftfont_list): Remove unused local.
49eaafba
PE
13824 (get_adstyle_property, ftfont_pattern_entity):
13825 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13826 Rename locals to avoid shadowing.
8ff096c1 13827
e2be39f6
PE
13828 * xfont.c (xfont_list_family): Mark var as initialized.
13829
c9735e30
PE
13830 * xml.c (make_dom): Now static.
13831
8f5201ae
PE
13832 * composite.c (composition_compute_stop_pos): Rename local to
13833 avoid shadowing.
b246f932
PE
13834 (composition_reseat_it): Remove unused locals.
13835 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13836 (composition_update_it): Mark var as initialized.
11b61122
PE
13837 (find_automatic_composition): Mark vars as initialized,
13838 with a FIXME (Bug#8290).
8f5201ae 13839
760fbc2c
PE
13840 character.h: Rename locals to avoid shadowing.
13841 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13842 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13843 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13844 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13845 to avoid shadowing.
13846
ff08eb85
PE
13847 * textprop.c (property_change_between_p): Remove; unused.
13848
fc7bf025
PE
13849 * intervals.c (interval_start_pos): Now static.
13850
235d7abc
PE
13851 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13852
44f230aa
SM
13853 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13854 Rename locals to avoid shadowing.
3e7d6594 13855
50060332
PE
13856 * sound.c (wav_play, au_play, Fplay_sound_internal):
13857 Fix pointer signedness.
d01f234b 13858 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13859 (wav_play): Initialize a variable to 0, to prevent undefined
13860 behavior (Bug#8278).
50060332 13861
c4fc4e30
PE
13862 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13863
918436ed
PE
13864 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13865
c939f91b
PE
13866 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13867 clobbering (Bug#8298).
b9c7f648
PE
13868 * sysdep.c (sys_subshell): Likewise.
13869 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13870
6bd8c144
PE
13871 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13872 This should get cleaned up, so that child_setup has the
13873 same signature on all platforms.
13874
7710357c 13875 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13876 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13877
c59da222
CY
138782011-03-22 Chong Yidong <cyd@stupidchicken.com>
13879
13880 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13881 not to be necessary, and produces flickering.
13882
66b87493
GM
138832011-03-20 Glenn Morris <rgm@gnu.org>
13884
13885 * config.in: Remove file.
13886
45b6f6d5
JB
138872011-03-20 Juanma Barranquero <lekktu@gmail.com>
13888
13889 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13890 are now in src/globals.h.
13891 (syms_of_minibuf): Remove spurious & from previous change.
13892
cd394be1 138932011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13894
13895 * minibuf.c (completing-read-function): New variable.
13896 (completing-read-default): Rename from completing-read.
13897 (completing-read): Call completing-read-function.
13898
b14e3e21
CY
138992011-03-19 Juanma Barranquero <lekktu@gmail.com>
13900
13901 * xfaces.c (Fx_load_color_file):
13902 Read color file from absolute filename (bug#8250).
13903
f2b726e6
JB
139042011-03-19 Juanma Barranquero <lekktu@gmail.com>
13905
13906 * makefile.w32-in: Update dependencies.
13907
09f6ff02
EZ
139082011-03-17 Eli Zaretskii <eliz@gnu.org>
13909
13910 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13911
29a6015a
PE
139122011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13913
a3a6c54e
PE
13914 Fix more problems found by GCC 4.5.2's static checks.
13915
b766f867
PE
13916 * process.c (make_serial_process_unwind, send_process_trap):
13917 (sigchld_handler): Now static.
13918
be02381c
PE
13919 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13920 That way, the code declares only the vars that it needs.
13921 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13922 * s/cygwin.h (PTY_ITERATION): Likewise.
13923 * s/darwin.h (PTY_ITERATION): Likewise.
13924 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13925
57048744
PE
13926 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13927 * process.c (allocate_pty): Don't declare stb unless it's needed.
13928
7914961c 13929 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13930 (CONSTANTLIM): Remove; unused.
13931 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13932 Define only if needed.
7914961c 13933
b3967b18
PE
13934 * unexelf.c (unexec): Name an expression,
13935 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13936 Use a different way to cause a compilation error if anyone uses
13937 n rather than nn, a way that does not involve shadowing.
73366a00 13938 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13939
29a6015a
PE
13940 * deps.mk (unexalpha.o): Remove; unused.
13941
43cfc33e 13942 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13943 * unexec.h: New file.
ce701a33
PE
13944 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13945 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13946 Depend on unexec.h.
13947 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13948 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13949 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13950 Change as necessary to match prototype in unexec.h.
ce701a33 13951
01f44d5a
PE
13952 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13953 shadowing.
4f63c6bb 13954 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13955
a6670b0b
PE
13956 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13957 Rename locals to avoid shadowing.
13958
cef2010d 13959 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13960 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13961
d4d7173a
PE
13962 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13963
f08b802a
PE
13964 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13965 warning when compiling print.c.
13966
3ddb0639
PE
13967 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13968 instead of using an uninitialized var.
5ad03b97 13969 (font_sort_entities): Mark var as initialized.
3ddb0639 13970
170a2692
PE
13971 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13972
e663c700
PE
13973 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13974 pointers to constants.
89bc529a 13975 (font_parse_fcname): Remove unused vars.
7b81e2d0 13976 (font_delete_unmatched): Now static.
ea838e10 13977 (font_get_spec): Remove; unused.
13a547c6
PE
13978 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13979 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13980 Rename or move locals to avoid shadowing.
e663c700 13981
2a80c887 13982 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13983 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13984
1384fa33 13985 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13986 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13987
8b2c52e9
PE
13988 * alloc.c (mark_backtrace): Move decl from here ...
13989 * lisp.h: ... to here, so that it can be checked.
13990
475545b5 13991 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13992 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13993 (lisp_indirect_variable): Name an expression,
13994 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13995 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13996
b1349114 13997 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13998 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13999 Use const pointer when appropriate.
b1349114 14000
a2928364
PE
14001 * lisp.h (get_system_name, get_operating_system_release):
14002 Move decls here, to check interfaces.
14003 * process.c (get_operating_system_release): Move decl to lisp.h.
14004 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14005 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14006 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14007 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14008 (Fformat_time_string, Fencode_time, Finsert_char):
14009 (Ftranslate_region_internal, Fformat):
14010 Rename or remove local vars to avoid shadowing.
9710023e 14011 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14012
a415e694
PE
14013 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14014 avoid shadowing.
14015
8ef4622d
PE
14016 * lisp.h (eassert): Check that the argument compiles, even if
14017 ENABLE_CHECKING is not defined.
14018
946f9a5b
PE
14019 * data.c (Findirect_variable): Name an expression, to avoid
14020 gcc -Wbad-function-cast warning.
112396d6 14021 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14022 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14023 (Fmake_variable_buffer_local, Fmake_local_variable):
14024 Mark variables as initialized.
52746918 14025 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14026
e5aab7e7 14027 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14028 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14029 Rename locals to avoid shadowing.
dff45157
PE
14030 (mark_stack): Move local variables into the #ifdef region where
14031 they're used.
7bc26fdb
PE
14032 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14033 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14034 needed otherwise.
14035 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14036 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14037 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14038
e5aab7e7
PE
14039 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14040 avoids undefined behavior in theory.
14041
4da60324
PE
14042 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14043
88043301
PE
14044 Use functions, not macros, for up- and down-casing (Bug#8254).
14045 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14046 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14047 to use the following functions instead of these macros.
14048 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14049 EMACS_INT, since callers assume the returned value fits in int.
14050 (upcase1): Likewise, for UPCASE_TABLE.
14051 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14052 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14053 the race-condition problem in the old DOWNCASE.
88043301 14054
19ed5445
PE
14055 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14056 Rename locals to avoid shadowing.
14057 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14058 (regex_compile, re_search_2, re_match_2_internal):
14059 Remove unused local vars.
952db0d7
PE
14060 (FREE_VAR): Rewrite so as not to use empty "else",
14061 which gcc can warn about.
da053e48 14062 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14063 (RETALLOC_IF): Define only if needed.
14064 (WORDCHAR_P): Likewise. This one is never needed, but is used
14065 only in a comment talking about a compiler bug, so put inside
14066 the #if 0 of that comment.
14067 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14068 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14069 Remove; unused.
19ed5445 14070
1f3561e4 14071 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14072 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14073 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14074
ded6f8f7
PE
14075 * search.c (simple_search): Remove unused var.
14076
dbd37a95
PE
14077 * dired.c (compile_pattern): Move decl from here ...
14078 * lisp.h: ... to here, so that it can be checked.
14079 (struct re_registers): New forward decl.
14080
7e47afad
PE
14081 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14082
85f24f61
PE
14083 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14084 All uses changed.
14085 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14086 Rename locals to avoid shadowing.
5671df8f 14087 (Fvertical_motion): Mark locals as initialized.
85f24f61 14088
181aa2be 14089 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14090 (casify_region): Mark local as initialized.
181aa2be 14091
930d429c
PE
14092 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14093
7082eac6
PE
14094 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14095 New macros, so that the caller can use some names other than
14096 gcpro1, gcpro2, etc.
14097 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14098 of the new macros.
14099 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14100 argument, for consistency with GCPRO2_VAR, etc: it is now the
14101 prefix of the variable, not the variable itself. All uses
14102 changed.
38b2c076
PE
14103 * dired.c (directory_files_internal, file_name_completion):
14104 Rename locals to avoid shadowing.
14105
15206ed9
PE
14106 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14107 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14108 dired.c's scmp function, had undefined behavior.
14109 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14110 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14111 * buffer.h: ... to here, because these macros use current_buffer,
14112 and the new implementation with inline functions needs to have
14113 current_buffer in scope now, rather than later when the macros
14114 are used.
14115 (downcase, upcase1): New static inline functions.
14116 (DOWNCASE, UPCASE1): Reimplement using these functions.
14117 This avoids undefined behavior in expressions like
14118 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14119 from race conditions in accessing the global variables
14120 case_temp1 and case_temp2.
14121 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14122 * lisp.h (case_temp1, case_temp2): Remove their decls.
14123 * character.h (ASCII_CHAR_P): Move from here ...
14124 * lisp.h: ... to here, so that the inline functions mentioned
14125 above can use them.
14126
4a6bea26
PE
14127 * dired.c (directory_files_internal_unwind): Now static.
14128
f14b7e14
PE
14129 * fileio.c (file_name_as_directory, directory_file_name):
14130 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14131 Now static.
2893f146
PE
14132 (file_name_as_directory): Use const pointers when appropriate.
14133 (Fexpand_file_name): Likewise. In particular, newdir might
14134 point at constant storage, so make it a const pointer.
fd4ead52 14135 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14136 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14137 signedness issues.
f839df0c
PE
14138 (Fset_file_times, Finsert_file_contents, auto_save_error):
14139 Rename locals to avoid shadowing.
f14b7e14 14140
5716756e 14141 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14142 (Ftry_completion, Fall_completions): Rename or remove locals
14143 to avoid shadowing.
5716756e 14144
b4c3046a
PE
14145 * marker.c (bytepos_to_charpos): Remove; unused.
14146
b45db522
PE
14147 * lisp.h (verify_bytepos, count_markers): New decls,
14148 so that gcc does not warn that these functions aren't declared.
14149
85876d07
PE
14150 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14151 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14152 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14153 (copy_text): Remove unused local var.
85876d07 14154
03d78a21 14155 * filelock.c (within_one_second): Now static.
b3dd38ab 14156 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14157
5df8f01b
PE
14158 * buffer.c (fix_overlays_before): Mark locals as initialized.
14159 (fix_start_end_in_overlays): Likewise. This function should be
14160 simplified by using pointers-to-pointers, but that's a different
14161 matter.
b1d876f1 14162 (switch_to_buffer_1): Now static.
8f54f30a
PE
14163 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14164 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14165
a70072c9 14166 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14167 Fix pointer signedness issue.
edced198
PE
14168 (sys_subshell): Mark local as volatile if checking for lint,
14169 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14170 (MAXPATHLEN): Define only if needed.
a70072c9 14171
a0977c44
PE
14172 * process.c (serial_open, serial_configure): Move decls from here ...
14173 * systty.h: ... to here, so that they can be checked.
14174
a884fdcc
PE
14175 * fns.c (get_random, seed_random): Move extern decls from here ...
14176 * lisp.h: ... to here, so that they can be checked.
14177
604efe86 14178 * sysdep.c (reset_io): Now static.
b8950c94 14179 (wait_for_termination_signal): Remove; unused.
604efe86 14180
38fc62d9
PE
14181 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14182 (copy_keymap_item, append_key, push_text_char_description):
14183 Now static.
1004a21a 14184 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14185 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14186 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14187 (describe_map_tree):
14188 Rename locals to avoid shadowing.
38fc62d9 14189
2f2650da
PE
14190 * keyboard.c: Declare functions static if they are not used elsewhere.
14191 (echo_char, echo_dash, cmd_error, top_level_2):
14192 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14193 (read_char, kbd_buffer_get_event, make_lispy_position):
14194 (make_lispy_event, make_lispy_movement, apply_modifiers):
14195 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14196 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14197 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14198 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14199 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14200
a053e86c 14201 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14202 (mark_kboards): Move decl here ...
14203 * alloc.c (mark_kboards): ... from here.
a053e86c 14204
4752793e
PE
14205 * lisp.h (force_auto_save_soon): New decl.
14206
74f10ca7 14207 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14208 (DEFINE_DUMMY_FUNCTION): New macro.
14209 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14210 Use it.
c03cd23f
PE
14211 (main): Add casts to avoid warnings
14212 if GCC considers string literals to be constants.
74f10ca7 14213
022e70d4
PE
14214 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14215
59d6fe83
PE
14216 * dbusbind.c: Pointer signedness fixes.
14217 (xd_signature, xd_append_arg, xd_initialize):
14218 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14219 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14220 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14221 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14222
78320123
PE
14223 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14224 if GCC considers string literals to be constants.
49cebcca 14225 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14226
35ac2a97
SM
142272011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14228
fb103ca9
SM
14229 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14230 (print_preprocess, print_object): New macro to fix last change.
14231
35ac2a97
SM
14232 * print.c (print_preprocess): Don't forget font objects.
14233
62973b41
JB
142342011-03-16 Juanma Barranquero <lekktu@gmail.com>
14235
14236 * emacs.c (USAGE3): Doc fixes.
14237
0e48bb22
AS
142382011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14239
14240 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14241 structure.
14242
7684e57b
JB
142432011-03-14 Juanma Barranquero <lekktu@gmail.com>
14244
14245 * lisp.h (VWindow_system, Qfile_name_history):
14246 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14247 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14248 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14249
14250 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14251 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14252
14253 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14254 * w32console.c (detect_input_pending, read_input_pending)
14255 (encode_terminal_code):
14256 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14257 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14258 (w32_system_caret_y, Qfile_name_history):
14259 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14260 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14261 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14262 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14263 * w32proc.c (Qlocal, report_file_error):
14264 * w32term.c (Vwindow_system, updating_frame):
14265 * w32uniscribe.c (initialized, uniscribe_font_driver):
14266 Remove unneeded extern declarations.
14267
2aa46d6c
CY
142682011-03-14 Chong Yidong <cyd@stupidchicken.com>
14269
c96bbc66 14270 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14271
cffc6f3b
CY
142722011-03-13 Chong Yidong <cyd@stupidchicken.com>
14273
14274 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14275 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14276 These macros can no longer be used for assignment.
14277
44f230aa
SM
14278 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14279 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14280 (record_buffer_markers, fetch_buffer_markers): New functions for
14281 recording and fetching special buffer markers.
14282 (set_buffer_internal_1, set_buffer_temp): Use them.
14283
14284 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14285
14286 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14287
14288 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14289 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14290
14291 * xdisp.c (hscroll_window_tree):
14292 (reconsider_clip_changes): Use PT instead of BUF_PT.
14293
d251f04b
EZ
142942011-03-13 Eli Zaretskii <eliz@gnu.org>
14295
14296 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14297 $(EMACS_ROOT)/lib/intprops.h.
14298
f0c77cd1
PE
142992011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14300
3eca4629
PE
14301 Fix more problems found by GCC 4.5.2's static checks.
14302
7c86ee98
PE
14303 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14304 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14305 (xg_free_frame_widgets): Make it clear that a local variable is
14306 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14307 (gdk_window_get_screen): Make it clear that this macro is needed
14308 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14309 (int_gtk_range_get_value): New function, which avoids a diagnostic
14310 from gcc -Wbad-function-cast.
14311 (xg_set_toolkit_scroll_bar_thumb): Use it.
14312 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14313 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14314 (get_utf8_string, xg_get_file_with_chooser):
14315 Rename locals to avoid shadowing.
14316 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14317
41729b81
PE
14318 * xgselect.c (xg_select): Remove unused var.
14319
f0c77cd1
PE
14320 * image.c (four_corners_best): Mark locals as initialized.
14321 (gif_load): Initialize transparent_p to zero (Bug#8238).
14322 Mark another local as initialized.
ec6cf4c6 14323 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14324
ce0ad53d 14325 * image.c (clear_image_cache): Now static.
d5d5a617 14326 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14327 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14328 (x_edge_detection): Remove unnecessary cast that
14329 gcc -Wbad-function-cast diagnoses.
2037898d 14330 (gif_load): Fix pointer signedness.
6ae141d6
PE
14331 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14332 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14333
33383987 143342011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14335
d32df629
PE
14336 Improve quality of tests for time stamp overflow.
14337 For example, without this patch (encode-time 0 0 0 1 1
14338 1152921504606846976) returns the obviously-bogus value (-948597
14339 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14340 reports time overflow. See
14341 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14342 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14343 * editfns.c: Include limits.h and intprops.h.
14344 (TIME_T_MIN, TIME_T_MAX): New macros.
14345 (time_overflow): Move earlier, to before first use.
14346 (hi_time, lo_time): New functions, for an accurate test for
14347 out-of-range times.
14348 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14349 (Fget_internal_run_time): Don't assume time_t fits in int.
14350 (make_time): Use list2 instead of Fcons twice.
14351 (Fdecode_time): More accurate test for out-of-range times.
14352 (check_tm_member): New function.
14353 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14354 (lisp_time_argument): Don't rely on undefined left-shift and
14355 right-shift behavior when checking for time stamp overflow.
8be6f318 14356
fe31d94c
PE
14357 * editfns.c (time_overflow): New function, refactoring common code.
14358 (Fformat_time_string, Fdecode_time, Fencode_time):
14359 (Fcurrent_time_string): Use it.
14360
8be6f318
PE
14361 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14362 * dired.c (make_time): Move to ...
14363 * editfns.c (make_time): ... here.
14364 * systime.h: Note the move.
14365
09d9db2c 143662011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14367
126bc0dc
YM
14368 * fringe.c (update_window_fringes): Remove unused variables.
14369
c47cbdfd
YM
14370 * unexmacosx.c (copy_data_segment): Also copy __got section.
14371 (Bug#8223)
14372
7ac80be9
EZ
143732011-03-12 Eli Zaretskii <eliz@gnu.org>
14374
c96bbc66 14375 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14376 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14377 Constify `char *' arguments and their references according to
14378 prototypes in tparam.h.
14379
ecb0f94d 14380 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14381
7ac80be9
EZ
14382 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14383 Adapt all references accordingly.
14384
14385 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14386
ef1fd07e
TT
143872011-03-11 Tom Tromey <tromey@redhat.com>
14388
14389 * buffer.c (syms_of_buffer): Remove obsolete comment.
14390
7ef4b50c
EZ
143912011-03-11 Eli Zaretskii <eliz@gnu.org>
14392
14393 * termhooks.h (encode_terminal_code): Declare prototype.
14394
14395 * msdos.c (encode_terminal_code): Don't declare prototype.
14396
14397 * term.c (encode_terminal_code): Now external again, used by
14398 w32console.c and msdos.c.
14399
44f230aa
SM
14400 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14401 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14402
4b1ec863 144032011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14404
1714f52b 14405 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14406
4b1ec863
PE
14407 * fringe.c (update_window_fringes): Mark locals as initialized
14408 (Bug#8227).
14409 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14410
524c7aa6
PE
14411 * alloc.c (mark_fringe_data): Move decl from here ...
14412 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14413 to check its interface.
14414 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14415
a5c0af81 14416 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14417 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14418 (fontset_font): Mark local as initialized.
a9a06e0b 14419 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14420
b4716021
PE
14421 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14422
811e9bac 14423 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14424 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14425 (x_own_selection, Fx_disown_selection_internal): Rename locals
14426 to avoid shadowing.
14427 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14428
7e3ab302
PE
14429 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14430 so that the caller can use some name other than gcpro1.
14431 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14432 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14433 (Fx_backspace_delete_keys_p):
14434 Use them to avoid shadowing, and rename vars to avoid shadowing.
14435 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14436 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14437 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14438 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14439 Remove unused locals.
7e3ab302
PE
14440 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14441 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14442 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14443 macros.
f78faa98 14444
e2b13473
PE
14445 * xterm.h (x_mouse_leave): New decl.
14446
77f23912
PE
14447 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14448 Remove unused functions.
cdf4ba58
PE
14449 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14450 (x_calc_absolute_position): Now static.
7411c686 14451 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14452 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14453 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14454 unless they are used.
38d0b34a
PE
14455 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14456 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14457 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14458 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14459 (x_error_catcher, x_connection_closed, x_error_handler):
14460 (x_error_quitter, xembed_send_message, x_iconify_frame):
14461 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14462 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14463 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14464
44f230aa
SM
14465 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14466 Rename or move locals to avoid shadowing.
6b463e58 14467 (tty_defined_color, merge_face_heights): Now static.
5967d051 14468 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14469 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14470 does not deduce is never used uninitialized.
73719eba
PE
14471 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14472 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14473
426994c3 14474 * terminal.c (store_terminal_param): Now static.
5489860b 14475
032f1620 14476 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14477 (set_frame_menubar): Remove unused local.
d4323972 14478 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14479 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14480 since they might point to immutable storage.
281585b0
PE
14481 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14482 since it's unused otherwise.
032f1620 14483
367c19e5 14484 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14485 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14486 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14487 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14488 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14489 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14490 does not deduce are never used uninitialized.
70739cbe 14491
07b48fa9
PE
14492 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14493
8868a238 14494 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14495 * window.c (window_loop, size_window):
14496 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14497
7e5cf297 14498 * window.c (display_buffer): Now static.
d6550a9f
PE
14499 (size_window): Mark variables that gcc -Wuninitialized
14500 does not deduce are never used uninitialized.
a586633d
PE
14501 * window.h (check_all_windows): New decl, to forestall
14502 gcc -Wmissing-prototypes diagnostic.
5b555da1 14503 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14504
f6095868
PE
14505 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14506 shadowing.
14507 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14508 Include <limits.h>.
14509 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14510 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14511 (load_charset_map): Mark variables that gcc -Wuninitialized
14512 does not deduce are never used uninitialized.
53df7c11 14513 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14514
f38b440c
PE
14515 * coding.c (coding_set_source, coding_set_destination):
14516 Use "else { /* comment */ }" rather than "else /* comment */;"
14517 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14518 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14519 a block, when the outer 'i' will do.
14520 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14521 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14522 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14523 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14524 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14525 Rename locals to avoid shadowing.
14526 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14527 * coding.c (emacs_mule_char, encode_invocation_designation):
14528 Now static, since they're not used elsewhere.
413bb2db 14529 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14530 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14531 (decode_coding_emacs_mule): Mark variables that gcc
14532 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14533 (detect_coding_iso_2022): Initialize a local variable that might
14534 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14535 this initialization is needed. (Bug#8211)
5f58e762
PE
14536 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14537 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14538 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14539 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14540 Remove unused macros.
f38b440c 14541
232b38b9 14542 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14543 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14544 * character.c (string_count_byte8): Likewise.
232b38b9 14545
fb90da1b
PE
14546 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14547 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14548
fb93dbc2
PE
14549 * chartab.c (copy_sub_char_table): Now static, since it's not used
14550 elsewhere.
5c156ace
PE
14551 (sub_char_table_ref_and_range, char_table_ref_and_range):
14552 Rename locals to avoid shadowing.
bbcd0949 14553 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14554
7d3b3862 14555 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14556 (BIDI_BOB): Remove unused macro.
7d3b3862 14557
6be7d3da
PE
14558 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14559 deduce are never used uninitialized.
c2ed9c8b 14560 * term.c (encode_terminal_code): Likewise.
6be7d3da 14561
75f8807f 14562 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14563
50938595
PE
14564 * tparam.h: New file.
14565 * term.c, tparam.h: Include it.
14566 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14567 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14568 Move these decls to tparam.h, and make them agree with what
14569 is actually in tparam.c. The previous trick of using incompatible
14570 decls in different modules does not conform to the C standard.
14571 All callers of tparam changed to use tparam's actual API.
14572 * tparam.c (tparam1, tparam, tgoto):
14573 Use const pointers where appropriate.
14574
fbceeba2
PE
14575 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14576 * cm.h (struct cm): Likewise.
14577 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14578 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14579 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14580 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14581 (turn_on_face, init_tty): Likewise.
14582 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14583
7f3f1250
PE
14584 * term.c (term_mouse_position): Rename local to avoid shadowing.
14585
e6ca6543
PE
14586 * alloc.c (mark_ttys): Move decl from here ...
14587 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14588
c40f8d15
AS
145892011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14590
14591 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14592
cfe0661d
JB
145932011-03-09 Juanma Barranquero <lekktu@gmail.com>
14594
14595 * search.c (compile_pattern_1): Remove argument regp, unused since
14596 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14597 (compile_pattern): Don't pass it.
14598
0afb4571
J
145992011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14600
14601 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14602 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14603 for ! HAVE_GTK3.
14604 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14605
14606 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14607
14608 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14609 gdk_window_get_screen, gdk_window_get_geometry,
14610 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14611 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14612 (xg_get_pixbuf_from_pixmap): New function.
14613 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14614 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14615 Call xg_get_pixbuf_from_pixmap instead of
14616 gdk_pixbuf_get_from_drawable.
14617 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14618 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14619 (xg_check_special_colors): Use GtkStyleContext and its functions
14620 for HAVE_GTK3.
14621 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14622 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14623 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14624 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14625 Call gtk_widget_get_preferred_size.
0afb4571
J
14626 (xg_frame_resized): gdk_window_get_geometry only takes 5
14627 parameters.
44f230aa
SM
14628 (xg_win_to_widget, xg_event_is_for_menubar):
14629 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14630 (xg_set_widget_bg): New function.
14631 (delete_cb): New function.
895009e1 14632 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14633 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14634 (xg_set_background_color): Call xg_set_widget_bg.
14635 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14636 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14637 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14638 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14639 if ! HAVE_GTK3.
14640 (update_frame_tool_bar): Call gtk_widget_hide.
14641 (xg_initialize): Use GDK_KEY_g.
14642
14643 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14644 if ! HAVE_GTK3
14645 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14646
14647 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14648 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14649 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14650
1c2cc4ef
JB
146512011-03-08 Juanma Barranquero <lekktu@gmail.com>
14652
14653 * w32xfns.c (select_palette): Check success of RealizePalette against
14654 GDI_ERROR, not zero.
14655
33383987 14656See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14657
14658;; Local Variables:
14659;; coding: utf-8
aac0c6e3
MR
14660;; End:
14661
2f097256 14662 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14663
14664 This file is part of GNU Emacs.
14665
14666 GNU Emacs is free software: you can redistribute it and/or modify
14667 it under the terms of the GNU General Public License as published by
14668 the Free Software Foundation, either version 3 of the License, or
14669 (at your option) any later version.
14670
14671 GNU Emacs is distributed in the hope that it will be useful,
14672 but WITHOUT ANY WARRANTY; without even the implied warranty of
14673 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14674 GNU General Public License for more details.
14675
14676 You should have received a copy of the GNU General Public License
14677 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.