Assume strerror.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
5ebbef1d
PE
12012-07-11 Paul Eggert <eggert@cs.ucla.edu>
2
3 Assume strerror.
4 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
5
984e7f30
DA
62012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
7
8 Avoid calls to strlen in font processing functions.
9 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
10 (font_open_by_name): Changed to use length argument. Adjust
11 users accordingly.
12 * font.h (font_open_by_name, font_parse_xlfd): Adjust prototypes.
13 * xfont.c (xfont_decode_coding_xlfd): Changed to return ptrdiff_t.
14 (xfont_list_pattern, xfont_match): Use length returned by
15 xfont_decode_coding_xlfd.
16 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
17
20e94fdd
GM
182012-07-11 Glenn Morris <rgm@gnu.org>
19
9d596af3
GM
20 * s/darwin.h, s/freebsd.h, s/netbsd.h:
21 Move DONT_REOPEN_PTY to configure.
22
20e94fdd
GM
23 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
24 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
25
e99a530f
PE
262012-07-10 Paul Eggert <eggert@cs.ucla.edu>
27
22ffb973
PE
28 Remove "#define unix" that is no longer needed (Bug#11905).
29 * s/aix4-2.h (unix): Remove; no longer needed.
30
e9a9ae03
PE
31 EMACS_TIME simplification (Bug#11875).
32 This replaces macros (which typically do not work in GDB)
33 with functions, typedefs and enums, making the code easier to debug.
34 The functional style also makes code easier to read and maintain.
35 * systime.h: Include <sys/time.h> on all hosts, not just if
36 WINDOWSNT, since 'struct timeval' is needed in general.
37 (EMACS_TIME): Now a typedef, not a macro.
38 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
39 not macros.
40 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
41 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
42 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
43 (EMACS_TIME_LE): Now functions, not macros.
44 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
45 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
46 which are not functions. All uses rewritten to use:
47 (make_emacs_time): New function.
48 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
49 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
50 not functions. All uses rewritten to use the following, respectively:
51 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
52 (add_emacs_time, sub_emacs_time): New functions.
53 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
54 * fileio.c (Fcopy_file):
55 * xterm.c (XTflash): Get the current time closer to when it's used.
56 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
57
ffacb126
PE
58 * bytecode.c (targets): Suppress -Woverride-init warnings.
59
e99a530f
PE
60 Simplify by avoiding confusing use of strncpy etc.
61 * doc.c (Fsnarf_documentation):
62 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
63 * frame.c (Fmake_terminal_frame):
64 * gtkutil.c (get_utf8_string):
65 * lread.c (openp):
66 * nsmenu.m (ns_update_menubar):
67 * regex.c (regerror):
68 Prefer memcpy to strncpy and strncat when either will do.
69 * fileio.c (Fsubstitute_in_file_name):
70 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
71 (menu_separator_name_p):
72 * nsmenu.m (ns_update_menubar):
73 Prefer memcmp to strncmp when either will do.
74 * nsterm.m: Include <ftoastr.h>.
75 (ns_get_color):
76 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
77 Prefer snprintf to strncpy.
78 * nsterm.m (ns_term_init):
79 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
80 * nsterm.m (ns_term_init):
81 Avoid the need for strncpy, by using build_string or
82 make_unibyte_string directly. Use dtoastr, not snprintf.
83 * process.c (Fmake_network_process): Diagnose service names that
84 are too long, rather than silently truncating them or creating
85 non-null-terminated names.
86 (Fnetwork_interface_info): Likewise, for interface names.
87 * sysdep.c (system_process_attributes) [GNU_LINUX]:
88 Prefer sprintf to strncat.
89 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
90 Prefer vsnprintf to vsprintf + strncpy.
91
c59592b3
GM
922012-07-10 Glenn Morris <rgm@gnu.org>
93
94 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
95 Clarify fallback case.
96
7d7bbefd
DA
972012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
98
99 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
100 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
101 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
102 * w32menu.c, window.c, xmenu.c: Changed to use XCAR and XCDR
103 where argument type is known to be a Lisp_Cons.
104
3a4c8000
TT
1052012-07-10 Tom Tromey <tromey@redhat.com>
106
107 * bytecode.c (BYTE_CODE_THREADED): New macro.
108 (BYTE_CODES): New macro. Replaces all old byte-code defines.
109 (enum byte_code_op): New type.
110 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
111 (exec_byte_code): Use them. Use token threading when applicable.
112
2a0213a6
DA
1132012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
114
115 Optimize pure C strings initialization.
116 * lisp.h (make_pure_string): Fix prototype.
117 (build_pure_c_string): New function, defined as static inline. This
118 provides a better opportunity to optimize away calls to strlen when
119 the function is called with compile-time constant argument.
120 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
121 argument, adjust users accordingly. Use build_pure_c_string where
122 appropriate.
123 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
124 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
125 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
126
cb1caeaf
DA
1272012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
128
129 Avoid calls to strlen in miscellaneous functions.
130 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
131 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
132 * lread.c (openp): Likewise.
133
c293e30c
DA
1342012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
135
136 Avoid calls to strlen in path processing functions.
137 * fileio.c (file_name_as_directory): Add comment. Change to add
138 srclen argument and return the length of result. Adjust users
139 accordingly.
140 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 141 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
142 users accordingly.
143 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
144
9e059e3f
GM
1452012-07-10 Glenn Morris <rgm@gnu.org>
146
d02eb359
GM
147 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
148 Move PENDING_OUTPUT_COUNT definition to configure.
149
882cf227
GM
150 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
151 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
152 * s/gnu.h (DATA_START): Move definitions to configure.
153
af6e839f
GM
154 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
155 We include usg5-4-common.h, which defines them both.
156
40289a12
GM
157 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
158 O_RDONLY already includes it).
159
9e059e3f
GM
160 Stop ns builds setting the EMACSLOADPATH environment variable.
161 * nsterm.m (ns_load_path): Rename from ns_init_paths.
162 Now it does not set EMACSLOADPATH, just returns the load-path string.
163 * nsterm.h: Update accordingly.
164 * lread.c [HAVE_NS]: Include nsterm.h.
165 (init_lread) [HAVE_NS]: Use ns_load_path.
166 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
167
7c4e8ec0
GM
1682012-07-09 Glenn Morris <rgm@gnu.org>
169
d4f600ff
GM
170 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
171 since the included bsd-common.h does so.
172
cbb31951
GM
173 Stop ns builds setting the EMACSPATH environment variable.
174 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
175 (ns_init_paths): Do not set EMACSPATH.
176 * nsterm.h (ns_exec_path): Add it.
177 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
178 Use ns_exec_path.
179
7c4e8ec0
GM
180 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
181
26bccfae
PE
1822012-07-09 Paul Eggert <eggert@cs.ucla.edu>
183
a0bee46f
PE
184 * process.c (wait_reading_process_output): 'waitchannels' was unset
185 when read_kbd || !NILP (wait_for_cell); fix this.
186
5994c183
PE
187 Add GCC-style 'const' attribute to functions that can use it.
188 * character.h (char_resolve_modifier_mask):
189 * keyboard.h (make_ctrl_char):
190 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
191 (init_character_once, next_almost_prime, init_fns, init_image)
192 (flush_pending_output, init_sound):
193 * mem-limits.h (start_of_data):
194 * menu.h (finish_menu_items):
195 Add ATTRIBUTE_CONST.
196 * emacs.c (DEFINE_DUMMY_FUNCTION):
197 Declare the dummy function with ATTRIBUTE_CONST.
198 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
199 Add decls with ATTRIBUTE_CONST.
200
26bccfae
PE
201 Minor improvements to make_formatted_string.
202 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
203 where int is good enough, as vsprintf returns an int.
204 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
205
a8290ec3
DA
2062012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
207
208 Use make_formatted_string to avoid double length calculation.
209 * lisp.h (make_formatted_string): New prototype.
210 * alloc.c (make_formatted_string): New function.
211 * buffer.c (Fgenerate_new_buffer_name): Use it.
212 * dbus.c (syms_of_dbusbind): Likewise.
213 * editfns.c (Fcurrent_time_zone): Likewise.
214 * filelock.c (get_boot_time): Likewise.
215 * frame.c (make_terminal_frame, set_term_frame_name)
216 (x_report_frame_params): Likewise.
217 * image.c (gs_load): Likewise.
218 * minibuf.c (get_minibuffer): Likewise.
219 * msdos.c (dos_set_window_size): Likewise.
220 * process.c (make_process): Likewise.
221 * xdisp.c (ensure_echo_area_buffers): Likewise.
222 * xsettings.c (apply_xft_settings): Likewise.
223
d01ba2f1
GM
2242012-07-09 Glenn Morris <rgm@gnu.org>
225
226 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
227 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
228 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
229 * nsterm.h (ns_etc_directory): Add it.
230 * callproc.c [HAVE_NS]: Include nsterm.h.
231 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
232
f1f924b6
DA
2332012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
234
235 Move marker debugging code under MARKER_DEBUG.
236 * marker.c (MARKER_DEBUG): Move marker debugging code under
237 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
238 for bootstrap with --enable-checking (~3x slowdown reported
239 by Juanma Barranquero <lekktu@gmail.com>).
240 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
241
ab531b66
PE
2422012-07-08 Paul Eggert <eggert@cs.ucla.edu>
243
244 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
245 See <http://bugs.gnu.org/11825#29>.
246
c4b3bc8a
EZ
2472012-07-08 Eli Zaretskii <eliz@gnu.org>
248
249 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
250 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
251 (display_line): Add commentary about displaying truncation glyphs
252 on GUI frames.
253 (produce_special_glyphs): Move here from term.c.
254
255 * term.c (produce_special_glyphs): Move to xdisp.c.
256
257 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
258 section.
c4b3bc8a 259
b676b881
AS
2602012-07-07 Andreas Schwab <schwab@linux-m68k.org>
261
f17c5273
AS
262 * xdisp.c (display_line): Avoid warning about implicit declaration
263 of FRAME_FONT.
264
298819b9
AS
265 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
266
b676b881
AS
267 * lisp.h: Remove empty conditional.
268
6045c4fd
PE
2692012-07-07 Paul Eggert <eggert@cs.ucla.edu>
270
b3350bf9
PE
271 * lread.c (load_path_check): Now static.
272
6045c4fd
PE
273 Fix some minor --with-ns problems found by static checking.
274 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
275 (x_set_font) [!HAVE_X_WINDOWS]:
276 * image.c (xpm_load_image) [HAVE_NS]:
277 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
278 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
279 Remove unused local.
280 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
281 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
282 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
283 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
284 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
285 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
286 Fix pointer signedness problem.
287 * xfaces.c (FRAME_X_FONT_TABLE):
288 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
289
929e7845
GM
2902012-07-07 Glenn Morris <rgm@gnu.org>
291
292 * lread.c (load_path_check): New function, split from init_lread.
293 (init_lread): Reorganize. Motivation:
294 If EMACSLOADPATH is set, check/warn about that rather than the
295 defaults, which we are not going to use. Hence we can remove
296 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
297 Don't warn if site-lisp directories are missing.
298 If not installed, start from a blank load-path, since
299 PATH_LOADSEARCH refers to the eventual installation directories.
300
58dd0aa4
EZ
3012012-07-07 Eli Zaretskii <eliz@gnu.org>
302
303 Support truncation and continuation glyphs on GUI frames, when
304 fringes are disabled. (Bug#11832)
305 * xdisp.c (init_iterator): Get dimensions of truncation and
306 continuation glyphs even if on GUI frames. Adjust
307 it->last_visible_x on GUI frames when the left or right fringes,
308 or both, are absent.
309 (start_display, move_it_in_display_line_to): Handle the case of a
310 GUI frame without a fringe to display continuation or truncation
311 glyphs.
312 (insert_left_trunc_glyphs): Support GUI frames: make sure
313 truncation glyphs overwrite enough glyphs from the current line to
314 have sufficient space in pixels.
315 (display_line): Support truncation and continuation glyphs on GUI
316 frames. If some spare pixels are left on the line after inserting
317 the truncation glyphs, fill that space with a stretch glyph of a
318 suitably computed width.
319
320 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
321 produce_glyphs, to support GUI sessions.
322
31571fd7
PE
3232012-07-07 Paul Eggert <eggert@cs.ucla.edu>
324
5a16b9bc
PE
325 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
326
f3047c75
PE
327 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
328
31571fd7
PE
329 Do not require float-time's arg to fit in time_t (Bug#11825).
330 This works better on hosts where time_t is unsigned, and where
331 float-time is applied to the (negative) difference between two times.
332 * editfns.c (decode_time_components): Last arg is now double *,
333 not int *, and means to store all the result as a double, without
334 worrying about whether the seconds part fits in time_t.
335 All callers changed.
336 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
337 All callers changed.
338 (Ffloat_time): Do not fail merely because the specified time falls
339 outside of time_t range.
340
4516fbef
GM
3412012-07-07 Glenn Morris <rgm@gnu.org>
342
343 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
344 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
345 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
346
07adc2c6
JB
3472012-07-07 Juanma Barranquero <lekktu@gmail.com>
348
349 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
350 Update dependencies.
351
352 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
353
fd573f31
PE
3542012-07-06 Paul Eggert <eggert@cs.ucla.edu>
355
fee5959d
PE
356 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
357 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
358 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
359 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
360 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
361 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
362
fd573f31
PE
363 * xfont.c (compare_font_names): Redo to omit the need for casts.
364
ddadbc0e
AS
3652012-07-06 Andreas Schwab <schwab@linux-m68k.org>
366
fca8d6b6
AS
367 * xfns.c (Fx_change_window_property): Doc fix.
368 * w32fns.c (Fx_change_window_property): Doc fix.
369
ddadbc0e
AS
370 * w32fns.c (Fx_window_property): Accept the same arguments as the
371 X Windows version. Doc fix.
372 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
373
f247498e
JB
3742012-07-06 Juanma Barranquero <lekktu@gmail.com>
375 Eli Zaretskii <eliz@gnu.org>
376
377 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
378 Windows-specific code from nt/config.nt moved here.
379 Obsolete settings removed.
380
216ee680
PE
3812012-07-06 Paul Eggert <eggert@cs.ucla.edu>
382
383 * process.c: Avoid unnecessary calls to gettime.
384 (wait_reading_process_output): Don't get the time of day
385 when gobbling data immediately and not waiting, as there's no need
386 for it in that case. This removes a FIXME.
387
bdd091e4
JD
3882012-07-06 Jan Djärv <jan.h.d@swipnet.se>
389
390 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
391 is defined (Bug#11768).
392
9d44f8ce
DA
3932012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
394
395 Fix marker debugging code.
396 * marker.c (byte_char_debug_check): Do not perform the check
397 if buffer is not multibyte.
090bd7cb
JB
398 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
399 Call byte_char_debug_check with correct arguments.
9d44f8ce 400
90fc4786
DA
4012012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
402
403 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
404 * marker.c (byte_char_debug_check, count_markers):
405 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
406 (byte_debug_flag): Remove.
407 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
408 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
409
7b7ae965
DA
4102012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
411
4e57b342
DA
412 Avoid code repetition in marker-related functions.
413 * marker.c (attach_marker): New function.
414 (Fset_marker, set_marker_restricted, set_marker_both)
415 (set_marker_restricted_both): Use it.
416 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
417 Consistently rename charno to charpos.
418 (marker_position): Add eassert.
419 (marker_byte_position): Convert to eassert.
420
4212012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
422
423 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 424 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 425 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 426
657924ff
DA
4272012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
428
429 Introduce fast path for the widely used marker operation.
430 * alloc.c (build_marker): New function.
431 * lisp.h (build_marker): New prototype.
432 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
433 * composite.c (autocmp_chars): Likewise.
434 * editfns.c (buildmark): Remove.
435 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
436 (save_restriction_save): Use build_marker.
437 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
438 * window.c (save_window_save): Likewise.
439
041a49a6
DA
4402012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
441
442 Do not use Fdelete_overlay in delete_all_overlays
443 to avoid redundant calls to unchain_overlay.
444 * buffer.c (drop_overlay): New function.
445 (delete_all_overlays, Fdelete_overlay): Use it.
446 * minibuf.c (get_minibuffer): Fix comment.
447
7dca65a4
PE
4482012-07-06 Paul Eggert <eggert@cs.ucla.edu>
449
450 Port to OpenBSD 5.1 amd64.
451 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
452 This is needed for OpenBSD, and should be harmless on all BSD systems.
453 Also, include <sys/sysctl.h>, as it should be available on all
454 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
455 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
456 use p_pid member, not kp_proc.pid.
457
8eb876e2
GM
4582012-07-06 Glenn Morris <rgm@gnu.org>
459
460 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
461
38182d90
PE
4622012-07-05 Paul Eggert <eggert@cs.ucla.edu>
463
464 More xmalloc and related cleanup.
465 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
466 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
467 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
468 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
469 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
470 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
471 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
472 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
473 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
474 * xterm.c:
475 Omit needless casts involving void * pointers and allocation.
476 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
477 as the former is more robust if P's type is changed.
478 Prefer xzalloc to xmalloc + memset 0.
479 Simplify malloc-or-realloc to realloc.
480 Don't worry about xmalloc returning a null pointer.
481 Prefer xstrdup to xmalloc + strcpy.
482 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
483 growing it.
484 * keyboard.c (apply_modifiers_uncached): Prefer local array to
485 alloca of a constant.
486
6dd5a677
EZ
4872012-07-05 Eli Zaretskii <eliz@gnu.org>
488
489 * xdisp.c (display_line): Fix horizontal pixel coordinates when
490 hscroll is larger than the line width. Fixes long and futile
491 looping inside extend_face_to_end_of_line (on a TTY) producing
492 glyphs that are not needed and thrown away.
493
6b312f0f
DA
4942012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
495
496 * marker.c (set_marker_restricted_both): Simplify by using
497 clip_to_bounds.
498
f520ef9b
PE
4992012-07-05 Paul Eggert <eggert@cs.ucla.edu>
500
501 * editfns.c (region_limit): Simplify by using clip_to_bounds.
502
383b7c95
JD
5032012-07-05 Jan Djärv <jan.h.d@swipnet.se>
504
505 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
506 not defined (Bug#11768).
507 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
508 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
509 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
510 followed by gtk_box_set_homogeneous (Bug#11768).
511 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
512 (update_theme_scrollbar_width, xg_create_scroll_bar):
513 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
514 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
515 (is_box_type): New function (Bug#11768).
516 (xg_tool_item_stale_p): Call is_box_type.
5293d758 517 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
518 with default display (Bug#11768).
519
d6e7bf45
EZ
5202012-07-05 Eli Zaretskii <eliz@gnu.org>
521
522 * xdisp.c (window_hscroll_limited): New function.
523 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
524 coordinates when window's hscroll is set to insanely large
525 values. (Bug#11857)
526
431391ec
JB
5272012-07-05 Juanma Barranquero <lekktu@gmail.com>
528
529 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
530 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
531
23f86fce
DA
5322012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
533
534 Cleanup xmalloc.
535 * lisp.h (xzalloc): New prototype. Omit needless casts.
536 * alloc.c (xzalloc): New function. Omit needless casts.
537 * charset.c: Omit needless casts. Convert all calls to
538 xmalloc with following memset to xzalloc.
539 * dispnew.c: Likewise.
540 * fringe.c: Likewise.
541 * image.c: Likewise.
542 * sound.c: Likewise.
543 * term.c: Likewise.
544 * w32fns.c: Likewise.
545 * w32font.c: Likewise.
546 * w32term.c: Likewise.
547 * xfaces.c: Likewise.
548 * xfns.c: Likewise.
549 * xterm.c: Likewise.
550 * atimer.c: Omit needless casts.
551 * buffer.c: Likewise.
552 * callproc.c: Likewise.
553 * ccl.c: Likewise.
554 * coding.c: Likewise.
555 * composite.c: Likewise.
556 * doc.c: Likewise.
557 * doprnt.c: Likewise.
558 * editfns.c: Likewise.
559 * emacs.c: Likewise.
560 * eval.c: Likewise.
561 * filelock.c: Likewise.
562 * fns.c: Likewise.
563 * gtkutil.c: Likewise.
564 * keyboard.c: Likewise.
565 * lisp.h: Likewise.
566 * lread.c: Likewise.
567 * minibuf.c: Likewise.
568 * msdos.c: Likewise.
569 * print.c: Likewise.
570 * process.c: Likewise.
571 * region-cache.c: Likewise.
572 * search.c: Likewise.
573 * sysdep.c: Likewise.
574 * termcap.c: Likewise.
575 * terminal.c: Likewise.
576 * tparam.c: Likewise.
577 * w16select.c: Likewise.
578 * w32.c: Likewise.
579 * w32reg.c: Likewise.
580 * w32select.c: Likewise.
581 * w32uniscribe.c: Likewise.
582 * widget.c: Likewise.
583 * xdisp.c: Likewise.
584 * xmenu.c: Likewise.
585 * xrdb.c: Likewise.
586 * xselect.c: Likewise.
587
0497dc44
PE
5882012-07-05 Paul Eggert <eggert@cs.ucla.edu>
589
590 * fileio.c (time_error_value): Check the right error number.
591 Problem reported by Troels Nielsen in
592 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
593
356e7178
PE
5942012-07-04 Paul Eggert <eggert@cs.ucla.edu>
595
4e71fd89
PE
596 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
597 This should be fixed in a better way; see Eli Zaretskii in
598 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
599 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
600
f0941253
PE
601 * fileio.c (time_error_value): Rename from special_mtime.
602 The old name's problems were noted by Eli Zaretskii in
603 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
604
065c9eb4
PE
605 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
606 This variable's comment says Emacs needs at least one GDB-visible
607 symbol of type enum pvec_type, to work around GDB problems.
608 The symbol's value doesn't matter.
609
356e7178
PE
610 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
611 that causes compilation to fail on pre-C99 compilers.
612
95f61aa2
JB
6132012-07-04 Juanma Barranquero <lekktu@gmail.com>
614
615 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
616 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
617
3884d954
DA
6182012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
619
d209e2fb 620 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
621 headers for buffer_defaults and buffer_local_symbols.
622 Reported by Juanma Barranquero <lekktu@gmail.com>.
623
ee28be33
SM
6242012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
625
626 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
627 * lisp.h (enum pvec_type): Use fewer bits.
628 (PSEUDOVECTOR_SIZE_BITS): New constant.
629 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
630 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
631 change in pvec_type.
632 (PSEUDOVECTOR_TYPEP): New macro.
633 (TYPED_PSEUDOVECTORP): Use it.
634 * fns.c (internal_equal): Adapt code to extract pvectype.
635 * emacs.c (gdb_pvec_type): Update type.
636 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
637 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
638 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
639 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
640 (sweep_vectors): Use it. Use local var `total_bytes' instead of
641 abusing vector->header.next.nbytes.
642 (live_vector_p): Use PVEC_TYPE.
643 (mark_object): Adapt code to extract pvectype. Use switch.
644
c7f2cd7f
PE
6452012-07-04 Paul Eggert <eggert@cs.ucla.edu>
646
647 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
648 Tighten new eassert a bit.
649
8ce70ed2
DA
6502012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
651
652 Fix compilation with --enable-gcc-warnings and -O1
653 optimization level.
654 * doprnt.c (doprnt): Change type of tem to int, initialize
655 to avoid compiler warning. Add eassert.
656 * search.c (simple_search): Initialize match_byte to avoid
657 compiler warning. Add eassert.
658
dea7f1e5
PE
6592012-07-04 Paul Eggert <eggert@cs.ucla.edu>
660
24a212eb
PE
661 Avoid weird behavior with large horizontal scrolls.
662 Without this change, for example, large hscroll values would
663 mess up Emacs's display on Fedora 15 x86, presumably due to
664 overflows in int calculations in the display code.
665 Also, if buffers had long lines, Emacs would freeze.
666 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
667 (set_window_hscroll): New function, containing the old guts of
668 Fset_window_hscroll. Return the clipped value.
669 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
670 This avoids the need to check against PTRDIFF_MAX.
671
dea7f1e5
PE
672 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
673
76046526
DA
6742012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
675
676 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
677
39adff0d
PE
6782012-07-04 Paul Eggert <eggert@cs.ucla.edu>
679
63807d47
PE
680 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
681 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
682 since GCC 4.4.6 issues a bogus warning for them.
683
39adff0d
PE
684 Fix bugs in file timestamp newness comparisons.
685 * fileio.c (Ffile_newer_than_file_p):
686 * lread.c (Fload): Use full timestamp resolution of files,
687 not just the 1-second resolution, so that files that are only
688 slightly newer still count as newer.
689 * fileio.c (Ffile_newer_than_file_p): Don't assume file
690 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
691
dbeed9a6
PE
6922012-07-03 Paul Eggert <eggert@cs.ucla.edu>
693
694 * fileio.c: Improve handling of file time marker. (Bug#11852)
695 (special_mtime): New function.
696 (Finsert_file_contents, Fverify_visited_file_modtime):
697 Use it to set special mtime values consistently.
698
636334d6
AS
6992012-07-03 Andreas Schwab <schwab@linux-m68k.org>
700
701 * fileio.c (Finsert_file_contents): Properly handle st_mtime
702 marker for non-existing file. (Bug#11852)
703
e2017fe2
GM
7042012-07-03 Glenn Morris <rgm@gnu.org>
705
706 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
707 and did not make it into globals.h).
708
404dbd37
TT
7092012-07-03 Tom Tromey <tromey@redhat.com>
710
711 * window.c (Fset_window_margins, Fset_window_fringes)
712 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
713 * textprop.c (Fprevious_property_change): No longer static.
714 * syntax.c (Fsyntax_table_p): No longer static.
715 * process.c (Fget_process, Fprocess_datagram_address): No longer
716 static.
717 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
718 * keyboard.c (Fcommand_execute): No longer static.
719 Remove EXFUN.
720 * insdel.c (Fcombine_after_change_execute): No longer static.
721 * image.c (Finit_image_library): No longer static.
722 * fileio.c (Fmake_symbolic_link): No longer static.
723 * eval.c (Ffetch_bytecode): No longer static.
724 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
725 * doc.c (Fdocumentation_property, Fsnarf_documentation):
726 No longer static.
404dbd37
TT
727 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
728 static.
729 * dired.c (Ffile_attributes): No longer static.
730 * composite.c (Fcomposition_get_gstring): No longer static.
731 * callproc.c (Fgetenv_internal): No longer static.
732
733 * ccl.h: Remove EXFUNs.
734 * buffer.h: Remove EXFUNs.
735 * dispextern.h: Remove EXFUNs.
736 * intervals.h: Remove EXFUNs.
737 * fontset.h: Remove EXFUN.
738 * font.h: Remove EXFUNs.
739 * dosfns.c (system_process_attributes): Remove EXFUN.
740 * keymap.h: Remove EXFUNs.
741 * lisp.h: Remove EXFUNs.
742 * w32term.h: Remove EXFUNs.
743 * window.h: Remove EXFUNs.
744 * xsettings.h: Remove EXFUN.
745 * xterm.h: Remove EXFUN.
746
8e4fd1e1
GM
7472012-07-03 Glenn Morris <rgm@gnu.org>
748
749 * lisp.h (Frandom): Make it visible to C.
750 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
751 buffer for invisible buffers. (Bug#1229)
752
ca95b3eb
DA
7532012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
754
755 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
756 values which aren't power of 2.
757 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
758 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
759 accordingly.
760
7555c33f
SM
7612012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
762
763 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
764
765 * alloc.c (mark_object): Revert part of last patch to use `switch'.
766
d12e8f5a
DA
7672012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
768
769 * alloc.c (allocate_vector_block): Remove redundant
770 calls to mallopt if DOUG_LEA_MALLOC is defined.
771 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
772 avoid calls to mallopt if zero_vector is returned.
773
296094c3
DA
7742012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
775
776 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
777 is enabled, avoid dereferencing NULL current_sblock if
778 running undumped.
779
36429c89
DA
7802012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
781
782 Cleanup basic buffer management.
783 * buffer.h (struct buffer): Change layout to use generic vector
784 marking code. Fix some comments. Change type of 'clip_changed'
785 to bitfield. Remove unused #ifndef old.
786 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
787 (GET_OVERLAYS_AT): Fix indentation.
788 (for_each_per_buffer_object_at): New macro.
789 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
790 (Fbuffer_local_variables): Use it.
791 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
792 * alloc.c (allocate_buffer): Adjust to match new layout of
793 struct buffer. Fix comment.
794 (mark_overlay): New function.
795 (mark_buffer): Use it. Use mark_vectorlike to mark normal
796 Lisp area of struct buffer.
797 (mark_object): Use it. Adjust marking of misc objects
798 and related comments.
799
3b3e4cac
PE
8002012-07-02 Paul Eggert <eggert@cs.ucla.edu>
801
802 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
803 wrapper that is not needed because the wrapped code is a no-op (zero
804 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
805 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
806
cf5c0175
DA
8072012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
808
809 * alloc.c (mark_buffer): Simplify. Remove prototype.
810 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 811 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
812 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
813 redundant calls to mark_vectorlike for bool vectors.
814
ca26824c
GM
8152012-06-30 Glenn Morris <rgm@gnu.org>
816
2e4c5312
GM
817 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
818
ca26824c
GM
819 * epaths.in (PATH_SITELOADSEARCH): New.
820 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
821 This is rather than relying on --enable-locallisppath elements
822 having "site-lisp" in their names. (Bug#10208#25, 11658)
823
0d23c240
EZ
8242012-06-30 Eli Zaretskii <eliz@gnu.org>
825
c9240d7a
EZ
826 * w32proc.c (sys_select): Accept and ignore one more argument.
827
828 * w32.c (emacs_gnutls_pull): Call select with one more argument.
829
0d23c240 830 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 831 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
832
833 * sysdep.c: Don't include dos.h and dosfns.h.
834
835 * process.c (sys_select):
836 * msdos.c (sys_select): Accept one more argument and ignore it.
837
838 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
839 adapt data types and code to that.
840
841 * dosfns.c:
842 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
843 which clashes with the gnulib function of the same name.
844
af5a5a98
AS
8452012-06-30 Andreas Schwab <schwab@linux-m68k.org>
846
c5e4379c
AS
847 * font.c (font_style_to_value, font_style_symbolic)
848 (font_prop_validate_style): Add type checks for values in
849 font_style_table.
850
af5a5a98
AS
851 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
852 argument.
853 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
854 uses.
855
8d38f461
EZ
8562012-06-29 Eli Zaretskii <eliz@gnu.org>
857
2e5a6631
EZ
858 * xdisp.c (try_window_id): Undo last change.
859
8d38f461
EZ
860 * w32.c (getwd): Adjust commentary about startup_dir.
861 (init_environment): Always call sys_access, even in non-MSVC
862 builds. Don't chdir to the directory of the Emacs executable.
863 This undoes code from 1997 which was justified by the need to
864 "avoid conflicts when removing and renaming directories". But its
865 downside was that every relative file name was being interpreted
866 relative to the directory of the Emacs executable, which can never
867 be TRT. In particular, it broke sys_access when called with
868 relative file names.
869 (sys_access): Map GetLastError to errno.
870
2af3565e
DA
8712012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
872
873 * window.h (struct window): Change type of 'fringes_outside_margins'
874 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 875 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
876 Adjust comment.
877 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
878 to ptrdiff_t.
879
c8d3a25c 8802012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 881
c8d3a25c
GM
882 * gnutls.c (emacs_gnutls_handshake):
883 Add QUIT to make the loop interruptible.
57570cd3 884
c8d3a25c 8852012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 886
c8d3a25c
GM
887 * charset.c (init_charset): Make lack of etc/charsets fatal.
888
3e984ee8
DA
8892012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
890
891 * editfns.c (region_limit): Fix type mismatch.
892
ef884f23
DA
8932012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
894
895 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
896 undefined. Convert from xassert to eassert.
897 * nsmenu.m: Convert from xassert to eassert.
898 * nsterm.m: Likewise.
899
7d7e0027
SM
9002012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
901
902 * editfns.c (region_limit): Clip to narrowing (bug#11770).
903
aa754e6a
PE
9042012-06-28 Paul Eggert <eggert@cs.ucla.edu>
905
906 Avoid integer overflow on scroll-left and scroll-right.
907 * window.c (HSCROLL_MAX): New macro.
908 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
909 overflow when requested scroll falls outside ptrdiff_t range.
910
80b00b08
DA
9112012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
912
913 * window.h (struct window): Change type of 'hscroll',
914 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
915 'last_modified' and 'last_overlay_modified' to EMACS_INT.
916 Adjust users accordingly.
917 * xdisp.c (try_cursor_movement): Replace type check with eassert.
918 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
919 from EMACS_INT to ptrdiff_t.
920 (make_window): Omit redundant initialization.
921
62b2bcf6
JB
9222012-06-28 Juanma Barranquero <lekktu@gmail.com>
923
924 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
925
45942c7d
DA
9262012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
927
928 * window.h (struct window): Change type of 'use_time' and
929 'sequence_number' from Lisp_Object to int.
930 * frame.c (make_frame): Adjust users accordingly.
931 * print.c (print_object): Likewise.
932 * window.c (select_window, Fwindow_use_time, make_parent_window)
933 (make_window): Likewise.
934
e509cfa6
DA
9352012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
936
937 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
938 enabled with --enable-checking=[all,glyphs] configure option.
939 Fix GLYPH_DEBUG usage assuming that it may be undefined,
940 adjust comments accordingly.
941 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
942 undefined, adjust comments accordingly.
943 * image.c: Likewise.
944 * scroll.c: Likewise.
945 * w32fns.c: Likewise.
946 * w32term.c: Likewise.
947 * xdisp.c: Likewise.
948 * xfaces.c: Likewise.
949 * xfns.c: Likewise.
950 * xterm.c: Likewise.
951
a54e2c05
DA
9522012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
953
954 Generalize run-time debugging checks.
955 * dispextern.h (XASSERTS): Remove.
956 * fontset.c (xassert): Remove.
957 Convert from xassert to eassert.
958 * alloc.c: Convert from xassert to eassert.
959 * bidi.c: Likewise.
960 * dispnew.c: Likewise.
961 * fns.c: Likewise.
962 * fringe.c: Likewise.
963 * ftfont.c: Likewise.
964 * gtkutil.c: Likewise.
965 * image.c: Likewise.
966 * keyboard.c: Likewise.
967 * menu.c: Likewise.
968 * process.c: Likewise.
969 * scroll.c: Likewise.
970 * sound.c: Likewise.
971 * term.c: Likewise.
972 * w32console.c: Likewise.
973 * w32fns.c: Likewise.
974 * w32term.c: Likewise.
975 * window.c: Likewise.
976 * xdisp.c: Likewise.
977 * xfaces.c: Likewise.
978 * xfns.c: Likewise.
979 * xselect.c: Likewise.
980 * xterm.c: Likewise.
981
1ec4b7b2
SM
9822012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
983
984 * fns.c (maybe_resize_hash_table): Output message when growing the
985 purify-hashtable.
986
2014308a
DA
9872012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
988
989 * alloc.c (allocate_string_data): Remove dead code.
990 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
991 avoid GCC warning about unused macro.
992
246155eb
DA
9932012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
994
995 * alloc.c (allocate_string): Omit intervals initialization.
996 * alloc.c (make_uninit_multibyte_string): Initialize intervals
997 as in make_pure_string and make_pure_c_string.
998
43184b7b
DA
9992012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1000
d209e2fb 1001 * alloc.c (allocate_string): Fix last change.
43184b7b 1002
3fe6dd74
DA
10032012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1004
d209e2fb 1005 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1006 to memset, add explicit initialization where appropriate.
1007
1ba6038a
GM
10082012-06-27 Glenn Morris <rgm@gnu.org>
1009
1010 * lisp.mk (lisp): Remove paths.elc.
1011
c89926a5
CY
10122012-06-27 Chong Yidong <cyd@gnu.org>
1013
1014 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1015
ed6b3510
JW
10162012-06-26 John Wiegley <johnw@newartisans.com>
1017
1ec4b7b2 1018 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1019 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1020
ed6b3510
JW
1021 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1022 when building with Clang.
1023
8edd4a2b
SM
10242012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1025
1026 * eval.c (Fapply): Allow calling it with a single argument.
1027
f6f62d1b
EZ
10282012-06-26 Eli Zaretskii <eliz@gnu.org>
1029
1030 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1031 _stricmp and _strnicmp.
1032 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1033
62efea5e
DA
10342012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1035
1036 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1037 allocated window.
1038 (allocate_process): Likewise for new process.
8edd4a2b 1039 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1040 (allocate_frame): Likewise.
1041 * frame.c (make_frame): Omit redundant initialization.
1042 * window.c (make_parent_window): Use memset.
1043 (make_window): Omit redundant initialization.
1044 * process.c (make_process): Omit redundant initialization.
1045 * terminal.c (create_terminal): Likewise.
1046
42997f4d
DA
10472012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1048
1049 * term.c (delete_tty): Remove redundant call to memset.
1050
1130ecfc
DA
10512012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1052
1053 * alloc.c: Remove build_string.
1054 * lisp.h: Define build_string as static inline. This provides
1055 a better opportunity to optimize away calls to strlen when the
1056 function is called with compile-time constant argument.
1057 * image.c (imagemagick_error): Convert to build_string.
1058 * w32proc.c (sys_spawnve): Likewise.
1059 * xterm.c (x_term_init): Likewise.
1060
cf38a720
PE
10612012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1062
99027bdd
PE
1063 Use sprintf return value instead of invoking strlen on result.
1064 In the old days this wasn't portable, since some sprintf
1065 implementations returned char *. But they died out years ago and
1066 Emacs already assumes sprintf returns int.
1067 Similarly for float_to_string.
1068 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1069 * ccl.c (ccl_driver):
1070 * character.c (string_escape_byte8):
1071 * data.c (Fnumber_to_string):
1072 * doprnt.c (doprnt):
1073 * print.c (print_object):
1074 * xdisp.c (message_dolog):
1075 * xfns.c (syms_of_xfns):
1076 Use sprintf or float_to_string result to avoid need to call strlen.
1077 * data.c (Fnumber_to_string):
1078 Use make_unibyte_string, since the string must be ASCII.
1079 * lisp.h, print.c (float_to_string): Now returns int length.
1080 * term.c (produce_glyphless_glyph):
1081 Use sprintf result rather than recomputing it.
1082
cf38a720
PE
1083 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1084 * Makefile.in (ALL_CFLAGS):
1085 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1086 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1087
3511c784
DA
10882012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1089
0a08eb21 1090 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1091 strcasecmp if available.
1092 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1093
fb7da12e
AS
10942012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1095
1096 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1097 Avoid comma operator.
1098 * menu.c (push_submenu_start, push_submenu_end)
1099 (push_left_right_boundary, push_menu_pane): Likewise.
1100 * msdos.c (dos_rawgetc): Likewise.
1101
afa2ffd8
DA
11022012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1103
1104 * xfns.c (xic_create_fontsetname): Remove redundant calls
1105 to memset.
1106
b3b4476b
PE
11072012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1108
4495ff38
PE
1109 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1110 sprintf already null-terminates its output.
1111
b3b4476b
PE
1112 * xfns.c (x_window): Remove redundant cast.
1113
b00876c9
DA
11142012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1115
1116 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1117 `const char *' to `char *' to avoid compiler warning.
1118
d188e26b
PE
11192012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1120
885d1d74
PE
1121 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1122 instead of truncating it to 63 (admittedly a generous limit).
1123
d188e26b
PE
1124 * process.c: Fix spelling and caps in comments.
1125
e2f560b1
DN
11262012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1127
e86db54b 1128 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1129 * sysdep.c (setpgrp): Remove definition, not used in this file.
1130
7583a3a1
JB
11312012-06-24 Juanma Barranquero <lekktu@gmail.com>
1132
1133 * makefile.w32-in: Update dependencies.
1134
696056c2
EZ
11352012-06-24 Eli Zaretskii <eliz@gnu.org>
1136
1137 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1138 (SYSTIME_H): Add nt/inc/sys/time.h.
1139
1140 * systime.h [WINDOWSNT]: Include sys/time.h.
1141
1142 * s/ms-w32.h (struct timespec): Definition moved from
1143 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1144
845ca893
PE
11452012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1146
1147 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1148 * buffer.h (buffer_slot_type_mismatch):
1149 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1150 * eval.c (unwind_to_catch):
1151 * image.c (my_png_error, my_error_exit):
1152 * keyboard.c (quit_throw_to_read_char, user_error)
1153 (Fexit_recursive_edit, Fabort_recursive_edit):
1154 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1155 (wrong_type_argument, buffer_overflow, __executable_start)
1156 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1157 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1158 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1159 (fatal):
1160 (child_setup) [!DOS_NT]:
1161 * lread.c (end_of_file_error, invalid_syntax):
1162 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1163 * puresize.h (pure_write_error):
1164 * search.c (matcher_overflow):
1165 * sound.c (sound_perror, alsa_sound_perror):
1166 * sysdep.c, syssignal.h (croak):
1167 * term.c (maybe_fatal, vfatal):
1168 * textprop.c (text_read_only):
1169 * undo.c (user_error):
1170 * unexmacosx.c (unexec_error):
1171 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1172 Use _Noreturn rather than NO_RETURN.
1173 No need for separate decl merely because of _Noreturn.
1174 * sound.c (sound_warning, parse_sound):
1175 Remove unnecessary forward decls.
1176
f1dd8073
PE
11772012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1178
1179 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1180 * lisp.h (WAIT_READING_MAX): New macro.
1181 * dispnew.c (Fsleep_for, sit_for):
1182 * keyboard.c (kbd_buffer_get_event):
1183 * process.c (Faccept_process_output):
1184 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1185 This improves on the previous patch, which introduced a bug
1186 when time_t is unsigned and as wide as intmax_t.
1187 See <http://bugs.gnu.org/9000#51>.
1188
b82c1755
EZ
11892012-06-23 Eli Zaretskii <eliz@gnu.org>
1190
1191 * dispnew.c (sit_for, Fsleep_for):
1192 * keyboard.c (kbd_buffer_get_event):
1193 * process.c (Faccept_process_output): Avoid compiler warnings when
1194 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1195
ca300656
JB
11962012-06-23 Juanma Barranquero <lekktu@gmail.com>
1197
049ec95b
JB
1198 * makefile.w32-in: Update dependencies.
1199
ca300656
JB
1200 * w32.c (ltime): Add return type and declare static.
1201 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1202
db7b8d06
PE
12032012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1204
1205 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1206 Privately reported by Herbert J. Skuhra.
1207 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1208 All uses changed.
1209 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1210 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1211
0bd8297f
EZ
12122012-06-23 Eli Zaretskii <eliz@gnu.org>
1213
96512555
EZ
1214 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1215 last argument of make_unibyte_string.
1216
0bd8297f
EZ
1217 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1218 language ID in the event parameters.
1219
1220 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1221 event.code, not the obscure "character set ID".
1222
63def6b6
CY
12232012-06-23 Chong Yidong <cyd@gnu.org>
1224
1225 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1226
e8a02204
EZ
12272012-06-23 Eli Zaretskii <eliz@gnu.org>
1228
388cdec0
EZ
1229 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1230 * w32.c (fdutimens): New function.
1231
1232 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1233
1234 * s/ms-w32.h (pselect): Redirect to sys_select.
1235
1236 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1237
e8a02204
EZ
1238 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1239 in the logic of incrementing and decrementing the value of
1240 use_relocatable_buffers.
1241
d054f3fb
PE
12422012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1243
1244 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1245 Privately reported by Herbert J. Skuhra.
1246 [__FreeBSD__]: Remove "*/" typo after "#include".
1247 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1248 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1249 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1250 Don't assume EMACS_TIME and struct timeval are the same type.
1251
d35af63c
PE
12522012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1253
1254 Support higher-resolution time stamps (Bug#9000).
1255 The time stamps are only nanosecond-resolution at the C level,
1256 since that's the best that any real-world system supports now.
1257 But they are picosecond-resolution at the Lisp level, as that's
1258 easy, and leaves room for future OS improvements.
1259
1260 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1261 (LIBES): Use it.
1262
1263 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1264 Don't get current time unless it's needed.
1265
1266 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1267 now provides it if it's absent.
1268 (start_atimer): Port to higher-res time stamps.
1269 Check for time stamp overflow. Don't get current time more
1270 often than is needed.
1271
1272 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1273 Include systime.h, not time.h.
1274 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1275
1276 * dired.c: Include stat-time.h.
1277 (Ffile-attributes): File times now have higher resolution.
1278
1279 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1280 (struct image): Timestamp now has higher resolution.
1281
1282 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1283 has at least microseconds now. All uses removed.
1284 (update_frame, update_single_window, update_window, update_frame_1)
1285 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1286
1287 * editfns.c (time_overflow): Now extern.
1288 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1289 (float-time, Fformat_time_string, Fcurrent_time_string)
1290 (Fcurrent_time_zone): Accept and generate higher-resolution
1291 time stamps.
1292 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1293 (decode_time_components, lisp_seconds_argument): New functions.
1294 (make_time): Now static.
1295 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1296 Report an error if the time is invalid, rather than having the caller
1297 do that.
1298
1299 * fileio.c: Include <stat-time.h>
1300 (Fcopy_file): Copy higher-resolution time stamps.
1301 Prefer to set the time stamp via a file descriptor if that works.
1302 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1303 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1304 (Fvisited_file_modtime, Fset_visited_file_modtime):
1305 Support higher-resolution time stamps.
1306
1307 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1308
1309 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1310
1311 * image.c (prepare_image_for_display, clear_image_cache)
1312 (lookup_image): Port to higer-resolution time stamps.
1313
1314 * keyboard.c (start_polling, bind_polling_period):
1315 Check for time stamp overflow.
1316 (read_char, kbd_buffer_get_event, timer_start_idle)
1317 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1318 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1319 Port to higher-resolution time stamps. Do not assume time_t is signed.
1320 (decode_timer): New function. Timers are now vectors of length 9,
1321 not 8, to accommodate the picosecond component.
1322 (timer_check_2): Use it.
1323
1324 * nsterm.m (select_timeout, timeval_subtract): Remove.
1325 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1326 as they're a bit more accurate and handle overflow better.
1327 (ns_select): Change prototype to be compatible with pselect.
1328 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1329 * nsterm.h (ns_select): Adjust prototype.
1330
1331 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1332 us-resolution time stamps.
1333 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1334
1335 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1336
1337 * lisp.h (time_overflow): New decl.
1338 (wait_reading_process_output): First arg is now intmax_t, not int,
1339 to accommodate larger waits.
1340
1341 * process.h (struct Lisp_Process.read_output_delay):
1342 Now counts nanoseconds, not microseconds.
1343 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1344 EMACS_HAS_USECS.
1345 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1346 (wait_reading_process_output):
1347 Port to ns-resolution time stamps.
1348 (Faccept_process_output, wait_reading_process_output):
1349 Check for time stamp overflow. Do not assume time_t is signed.
1350 (select_wrapper): Remove; we now use pselect.
1351 (Fprocess_attributes): Now generates ns-resolution time stamps.
1352
1353 * sysdep.c: Include utimens.h. Don't include utime.h
1354 or worry about struct utimbuf; gnulib does that for us now.
1355 (gettimeofday): Remove; gnulib provides a substitute.
1356 (make_timeval): New function.
1357 (set_file_times): Now sets ns-resolution time stamps.
1358 New arg FD; all uses changed.
1359 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1360 (system_process_attributes):
1361 Now returns ns-resolution time stamp. All uses changed.
1362 Check for time stamp overflow.
1363
1364 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1365 provides a substitute now.
1366
1367 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1368 since it guarantees struct timespec.
1369 (EMACS_TIME): Now struct timespec, so that we can support
1370 ns-resolution time stamps.
1371 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1372 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1373 (EMACS_USECS): Remove.
1374 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1375 so multiply the arg by 1000 before storing it.
1376 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1377 New macros.
1378 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1379 Port to ns-resolution time stamps.
1380 (EMACS_TIME_NEG_P): Remove; replaced by....
1381 (EMACS_TIME_SIGN): New macro.
1382 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1383 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1384 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1385 (make_timeval, make_lisp_time, decode_time_components): New decls.
1386 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1387 that it mishandled time_t overflow. You can't compare by subtracting!
1388 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1389 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1390
1391 * term.c: Include <sys/time.h>.
1392 (timeval_to_Time): New function, for proper overflow wraparound.
1393 (term_mouse_position, term_mouse_click): Use it.
1394
1395 * undo.c (record_first_change): Support higher-resolution time stamps
1396 in the undo buffer.
1397 (Fprimitive_undo): Use them when restoring time stamps.
1398
1399 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1400 (w32_get_internal_run_time):
1401 Port to higher-resolution Emacs time stamps.
1402 (ltime): Now accepts single 64-bit integer, as that's more convenient
1403 for callers.
1404
1405 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1406
1407 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1408 for compatibility with pselect. Support ns-resolution time stamps.
1409
1410 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1411
1412 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1413 Check for time stamp overflow, and support ns-resolution time stamps.
1414
1415 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1416 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1417 (timeval_subtract): Remove; no longer needed.
1418 (XTflash, XTring_bell, x_wait_for_event):
1419 Port to ns-resolution time stamps. Don't assume time_t is signed.
1420
b6a92dfe
CY
14212012-06-22 Chong Yidong <cyd@gnu.org>
1422
1423 * xdisp.c (x_consider_frame_title): Revert last change.
1424
d251c37c
EZ
14252012-06-22 Eli Zaretskii <eliz@gnu.org>
1426
1427 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1428 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1429 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1430 staticidx goes up to 1597 out of 1600 = 0x640.)
1431
f10deafb
PE
14322012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1433
1434 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1435 Otherwise, the umask might be mistakenly 0 while handling input signals.
1436
ec6de1e2
SM
14372012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1438
1439 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1440
28be1ada
DA
14412012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1442
1443 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1444 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1445 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1446 access to `contents' member of Lisp_Vector objects with AREF and ASET
1447 where appropriate.
1448
c6bf3022
CY
14492012-06-19 Chong Yidong <cyd@gnu.org>
1450
1451 * frame.c (delete_frame): When selecting a frame on a different
1452 text terminal, do not alter the terminal's top-frame.
1453
1454 * xdisp.c (format_mode_line_unwind_data): Record the target
1455 frame's selected window and its terminal's top-frame.
1456 (unwind_format_mode_line): Restore them.
1457 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1458 Callers changed.
1459 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1460 since tty frames can be explicitly named.
1461 (prepare_menu_bars): Likewise.
1462
1463 * term.c (Ftty_top_frame): New function.
1464
defd4196
PE
14652012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1466
1467 Port byte-code-meter to modern targets.
1468 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1469 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1470 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1471 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1472 (METER_1, METER_2): Simplify.
1473
1053a871
SM
14742012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1475
1476 * data.c (Fdefalias): Return `symbol' (bug#11686).
1477
b7e8d081
MR
14782012-06-18 Martin Rudalics <rudalics@gmx.at>
1479
1480 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1481 gets killed during executing of this function (Bug#11665).
1482 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1483 (Vkill_buffer_query_functions): In doc-string say that functions
1484 run by this hook should not change the current buffer.
1485
7ea2b339
PE
14862012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1487
1488 Fix recently-introduced process.c problems found by static checking.
1489 * process.c (write_queue_push, write_queue_pop, send_process):
1490 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1491 (write_queue_pop): Fix pointer signedness problem.
1492 (send_process): Remove unused local.
1493
96a313a1
CY
14942012-06-17 Chong Yidong <cyd@gnu.org>
1495
1496 * xdisp.c (redisplay_internal): No need to redisplay terminal
1497 frames that are not on top.
1498
20ca2e94
TN
14992012-06-17 Troels Nielsen <bn.troels@gmail.com>
1500
1501 * process.c (make_process): Initialize write_queue.
1502 (write_queue_push, write_queue_pop): New functions.
1503 (send_process): Use them to maintain correct ordering of process
1504 writes (Bug#10815).
1505
9a900ca9
PE
15062012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1507
310fbfa8
PE
1508 * lisp.h (eassert): Assume C89 or later.
1509 This removes the need for CHECK.
1510 (CHECK): Remove. Its comments about always evaluating its
1511 argument were confusing, as 'eassert' typically does not evaluate
1512 its argument.
1513
27bb1ca4
PE
1514 * coding.c (produce_chars): Use ptrdiff_t, not int.
1515
9a900ca9
PE
1516 * xterm.c (x_draw_underwave): Check for integer overflow.
1517 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1518
41b7f8bc 15192012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1520
1521 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1522 referenced (Bug#11583).
1523
9b0e3eba
AA
15242012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1525
1526 Implement wave-style variant of underlining.
1527 * dispextern.h (face_underline_type): New enum.
1528 (face): Add field for underline type.
1529 * nsterm.m (ns_draw_underwave): New function.
1530 (ns_draw_text_decoration): Use it.
1531 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1532 New functions.
1533 (x_draw_glyph_string): Use them.
1534 * xfaces.c (Qline, Qwave): New Lisp objects.
1535 (check_lface_attrs, merge_face_ref)
1053a871
SM
1536 (Finternal_set_lisp_face_attribute, realize_x_face):
1537 Handle wave-style underline face attributes.
9b0e3eba
AA
1538 * xterm.c (x_draw_underwave): New function.
1539 (x_draw_glyph_string): Use it.
1540
0fb52f11
JB
15412012-06-16 Juanma Barranquero <lekktu@gmail.com>
1542
1543 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1544 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1545 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1546 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1547 ($(BLD)/w32select.$(O)): Update dependencies.
1548
e5560ff7
AS
15492012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1550
1551 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1552 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1553 * character.c (_fetch_multibyte_char_p): Remove.
1554 * alloc.c: Include "character.h" before "buffer.h".
1555 * bidi.c: Likewise.
1556 * buffer.c: Likewise.
1557 * bytecode.c: Likewise.
1558 * callint.c: Likewise.
1559 * callproc.c: Likewise.
1560 * casefiddle.c: Likewise.
1561 * casetab.c: Likewise.
1562 * category.c: Likewise.
1563 * cmds.c: Likewise.
1564 * coding.c: Likewise.
1565 * composite.c: Likewise.
1566 * dired.c: Likewise.
1567 * dispnew.c: Likewise.
1568 * doc.c: Likewise.
1569 * dosfns.c: Likewise.
1570 * editfns.c: Likewise.
1571 * emacs.c: Likewise.
1572 * fileio.c: Likewise.
1573 * filelock.c: Likewise.
1574 * font.c: Likewise.
1575 * fontset.c: Likewise.
1576 * fringe.c: Likewise.
1577 * indent.c: Likewise.
1578 * insdel.c: Likewise.
1579 * intervals.c: Likewise.
1580 * keyboard.c: Likewise.
1581 * keymap.c: Likewise.
1582 * lread.c: Likewise.
1583 * macros.c: Likewise.
1584 * marker.c: Likewise.
1585 * minibuf.c: Likewise.
1586 * nsfns.m: Likewise.
1587 * nsmenu.m: Likewise.
1588 * print.c: Likewise.
1589 * process.c: Likewise.
1590 * regex.c: Likewise.
1591 * region-cache.c: Likewise.
1592 * search.c: Likewise.
1593 * syntax.c: Likewise.
1594 * term.c: Likewise.
1595 * textprop.c: Likewise.
1596 * undo.c: Likewise.
1597 * unexsol.c: Likewise.
1598 * w16select.c: Likewise.
1599 * w32fns.c: Likewise.
1600 * w32menu.c: Likewise.
1601 * window.c: Likewise.
1602 * xdisp.c: Likewise.
1603 * xfns.c: Likewise.
1604 * xmenu.c: Likewise.
1605 * xml.c: Likewise.
1606 * xselect.c: Likewise.
1607
2f07e6af
EZ
16082012-06-16 Eli Zaretskii <eliz@gnu.org>
1609
1053a871
SM
1610 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1611 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1612 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1613 row.
1614 (handle_face_prop): Use chunk-relative overlay string index when
1615 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1616 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1617 the rightmost. (Bug#11720)
2f07e6af 1618
29b83cec
AS
16192012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1620
1621 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1622 (CATEGORY_MEMBER): Enforce 1/0 value.
1623 * category.c (_temp_category_set): Remove.
1624
4c5501e9
EZ
16252012-06-16 Eli Zaretskii <eliz@gnu.org>
1626
1627 * window.c (Fdelete_other_windows_internal)
1628 (Fdelete_window_internal): Don't access frame's mouse highlight
1629 info of the initial frame. (Bug#11677)
1630
2b570124
PE
16312012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1632
e93864f9
PE
1633 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1634 Assume USE_2_TAGS_FOR_INTS.
1635 (xreload): Adjust $tagmask width to match recent lisp.h change.
1636
2b570124
PE
1637 Simplify lisp.h in minor ways that should not affect code.
1638 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1639 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1640 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1641 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1642 (INTTYPEBITS): New macro, for clarity.
1643 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1644 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1645 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1646 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1647 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1648
81755f69
JB
16492012-06-13 Juanma Barranquero <lekktu@gmail.com>
1650
1651 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1652
16192a57
GM
16532012-06-13 Glenn Morris <rgm@gnu.org>
1654
1655 * s/bsd-common.h (BSD4_3):
1656 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1657
646b5f55
AS
16582012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1659
1660 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1661 instead of union.
1662 (XLI, XIL): Define.
1053a871
SM
1663 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1664 Use them.
1665 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1666 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1667 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1668 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1669 * frame.c (delete_frame): Remove outdated comment.
1670 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1671 USE_LISP_UNION_TYPE.
1672 (Fw32_unregister_hot_key): Likewise.
1673 (Fw32_toggle_lock_key): Likewise.
1674 * w32menu.c (add_menu_item): Likewise.
1675 (w32_menu_display_help): Use XIL instead of checking
1676 USE_LISP_UNION_TYPE.
1677 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1678 (init_heap): Likewise.
1679 * w32term.c (w32_read_socket): Update comment.
1680
1d3823c9
GM
16812012-06-13 Glenn Morris <rgm@gnu.org>
1682
c62ff706
GM
1683 * s/usg5-4-common.h, src/s/unixware.h:
1684 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1685
1d3823c9
GM
1686 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1687
bfe3e0a2
PE
16882012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1689
1690 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1691 * alloc.c (make_number) [!defined make_number]:
1692 Remove, as lisp.h always defines this now.
1693 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1694 (roundup_size): Verify that it is a power of 2.
1695 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1696 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1697 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1698 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1699 USE_LSB_TAG now is always defined to be either 0 or 1.
1700 All uses changed.
1701 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1702 code works fine either way, and efficiency is not a concern here,
1703 as the union type is for debugging, not for production.
1704 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1705 Use an inline function on all platforms when using the union type,
1706 since this is simpler and 'static inline' can be used portably
1707 within Emacs now.
1708 (LISP_INITIALLY_ZERO): New macro.
1709 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1710 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1711
45fa9c0f
GM
17122012-06-12 Glenn Morris <rgm@gnu.org>
1713
b4492cba
GM
1714 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1715
1716 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1717
45fa9c0f
GM
1718 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1719 Move BROKEN_SIGIO to configure.
1720
1721 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1722 Move NO_TERMIO to configure.
1723
0e25d334
CY
17242012-06-12 Chong Yidong <cyd@gnu.org>
1725
1726 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1727 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1728 MagickExportImagePixels is undefined.
1729
43682bb6
PE
17302012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1731
1732 * image.c (imagemagick_load_image): Remove unused label.
1733
a9be7d2b
GM
17342012-06-11 Glenn Morris <rgm@gnu.org>
1735
1736 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1737 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1738 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1739 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1740
3017f87f
SM
17412012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1742
1743 * alloc.c (make_byte_code): New function.
1744 (Fmake_byte_code): Use it. Don't purify here.
1745 * lread.c (read1): Use it as well to avoid extra allocation.
1746
1b9b4cf4
CY
17472012-06-11 Chong Yidong <cyd@gnu.org>
1748
1749 * image.c (imagemagick_load_image): Implement transparency.
1750
95988fcf
AS
17512012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1752
1753 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1754 account for preceding backslashes. (Bug#11663)
1755
cd4eb164
CY
17562012-06-09 Chong Yidong <cyd@gnu.org>
1757
1758 * term.c: Support italics in capable terminals (Bug#9652).
1759 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1760 (turn_on_face): Output using TS_enter_italic_mode if available.
1761 Don't handle unused blinking and alt-charset cases.
1762 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1763 and tty_alt_charset_p cases.
1764 (tty_capable_p, init_tty): Support italics.
1765
1766 * termchar.h (struct tty_display_info): Add field for italics.
1767 Remove unused blink field.
1768
1769 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1770 Handle slant.
1771
1772 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1773 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1774 tty_alt_charset_p. Add tty_italic_p.
1775
ff88beb8
MA
17762012-06-09 Michael Albinus <michael.albinus@gmx.de>
1777
1778 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1779 dbus_type_is_basic if available.
1780 (xd_extract_signed, xd_extract_unsigned): Rename from
1781 extract_signed and extract_unsigned, respectively. Adapt callers.
1782
44286096
CY
17832012-06-09 Chong Yidong <cyd@gnu.org>
1784
1682701f
CY
1785 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1786
44286096
CY
1787 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1788 case (Bug#9752).
1789
d86feb17
PE
17902012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1791
1792 * xdisp.c (vmessage): Treat frame message as multibyte.
1793 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1794 would generate the diagnostic "Making \302\247 buffer-local while
1795 let-bound!".
1796
d5c20fe8
EZ
17972012-06-08 Eli Zaretskii <eliz@gnu.org>
1798
1799 * dispnew.c (showing_window_margins_p): Undo last change, which
1800 was done due to an inadvertent commit.
1801 (adjust_frame_glyphs_for_frame_redisplay): Do call
1802 showing_window_margins_p.
1803
513749ee
SM
18042012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1805
1806 * eval.c (Fmake_var_non_special): New primitive.
1807 (syms_of_eval): Defsubr it.
1808 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1809
d4a8f5c1
JB
18102012-06-08 Juanma Barranquero <lekktu@gmail.com>
1811
1812 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1813 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1814
8bbbc977
EZ
18152012-06-08 Eli Zaretskii <eliz@gnu.org>
1816
1817 * alloc.c (allocate_vectorlike): Fix last change.
1818
f3372c87
DA
18192012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1820
1821 Block-based vector allocation of small vectors.
1822 * lisp.h (struct vectorlike_header): New field `nbytes',
1823 adjust comment accordingly.
1824 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1825 to denote vector blocks. Adjust users (live_vector_p,
1826 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1827 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1828 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1829 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1830 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1831 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1832 (roundup_size): New constant.
1833 (struct vector_block): New data type.
1834 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1835 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1836 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1837 (sweep_vectors): New functions.
1838 (allocate_vectorlike): Return `zero_vector' as the only vector of
1839 0 items. Allocate new vector from block if vector size is less than
1840 or equal to VBLOCK_BYTES_MAX.
1841 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1842 (init_alloc_once): Add call to init_vectors.
1843
4f18a4ed
SM
18442012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1845
1846 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1847
86f158bc
PE
18482012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1849
1850 * doprnt.c (doprnt): Truncate multibyte char correctly.
1851 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1852 would mishandle a string argument "Xc" if X was a multibyte
1853 character of length 2: it would truncate after X's first byte
1854 rather than including all of X.
1855
c5cfcbe0
CY
18562012-06-06 Chong Yidong <cyd@gnu.org>
1857
1858 * buffer.c (word_wrap): Doc fix.
1859
c05cf390
PE
18602012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1861
1862 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1863
0c3461de
GM
18642012-06-03 Glenn Morris <rgm@gnu.org>
1865
1866 * xdisp.c (tool-bar-style): Doc fix.
1867
c71232db
UM
18682012-06-03 Ulrich Müller <ulm@gentoo.org>
1869
1870 * Makefile.in (PAXCTL): Define.
1871 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1872 binary via PaX flags if the paxctl utility is available.
1873 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1874 Restore PaX flags to their default. (Bug#11398)
1875
383f7350
CY
18762012-06-03 Chong Yidong <cyd@gnu.org>
1877
1878 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1879 buffer (Bug#11226).
1880
5f2c76c6
CY
18812012-06-03 Chong Yidong <cyd@gnu.org>
1882
1883 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1884 (note_mode_line_or_margin_highlight): If there is no help echo,
1885 use mode-line-default-help-echo. Handle the case where the mouse
1886 position is past the end of the mode line string.
1887
1888 * buffer.c (buffer_local_value_1): New function, split from
1889 Fbuffer_local_value; can return Qunbound.
1890 (Fbuffer_local_value): Use it.
1891 (Vmode_line_format): Docstring tweaks.
1892
773d47f6
PE
18932012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1894
1895 * sysdep.c (system_process_attributes): Improve comment.
1896
f2d6a3df
SM
18972012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1898
1899 * keyboard.c: Export real-this-command to Elisp.
1900 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1901 and DEFVAR it. Update all users.
1902
63810350
PE
19032012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1904
7bd5c1f4
PE
1905 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1906
63810350
PE
1907 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1908 Convert pctcpu and pctmem to Lisp float properly.
1909 Let the compiler fold better, as 100.0/0x8000 is exact.
1910
a2821611
AS
19112012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1912
1913 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1914 cons_block.
1915
5fceba1d
PE
19162012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1917
1918 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1919
c98ff5dd
DA
19202012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1921
1922 For a 'struct window', replace some Lisp_Object fields to
1923 bitfields where appropriate, remove unused fields.
1924 * window.h (struct window): Remove unused 'last_mark_x' and
1925 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1926 change it's type from Lisp_Object to bitfield.
1927 Change type of 'force_start', 'optional_new_start',
1928 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1929 fields from Lisp_Object to bitfield. Adjust users accordingly.
1930
ca34e0be
PE
19312012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1932
1933 Pacify gcc -Wdouble-precision when using Xaw.
1934 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1935 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1936 Use 'float' consistently, rather than 'float' in most places
1937 and 'double' in a couple of places.
1938
efc00ab1 19392012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1940
1941 * xdisp.c (handle_stop): Detect whether we have overlay strings
1942 loaded by testing it->current.overlay_string_index to be
1943 non-negative, instead of checking whether n_overlay_strings is
1944 positive. (Bug#11587)
1945
efc00ab1 19462012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1947
1948 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1949
1950 * doc.c (Fsubstitute_command_keys): Doc fix.
1951
efc00ab1 19522012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1953
1954 * search.c (search_buffer): Remove calls to
1955 r_alloc_inhibit_buffer_relocation, as it is now called by
1956 maybe_unify_char, which was the cause of relocation of buffer text
1957 in bug#11519.
1958
efc00ab1 19592012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1960
1961 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1962 for the duration of call to load_charset, to avoid problems with
1963 callers of maybe_unify_char that access buffer text through C
1964 pointers.
1965
1966 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1967 decrement the inhibition flag, instead of just setting or
1968 resetting it.
1969
ba93a187
PE
19702012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1971
1972 Remove obsolete '#define static' cruft.
1973 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1974 This #undef was "temporary" in 2000; it is no longer needed
1975 now that '#define static' has gone away.
1976 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1977 (gray_bitmap_bits): Remove; no longer needed.
1978 All uses replaced with definiens.
1979 * xterm.c: Include "bitmaps/gray.xbm".
1980
9e4bf381
PE
19812012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1982
1983 Clean up __executable_start, monstartup when --enable-profiling.
1984 The following changes affect the code only when profiling.
1985 * dispnew.c (__executable_start): Rename from safe_bcopy.
1986 Define only on platforms that need it.
1987 * emacs.c: Include <sys/gmon.h> when profiling.
1988 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1989 (__executable_start): Remove decl, since lisp.h does it now.
1990 (safe_bcopy): Remove decl; no longer has that name.
1991 (main): Coalesce #if into single bit of code, for simplicity.
1992 Cast pointers to uintptr_t, since standard libraries want integers
1993 and not pointers.
1994 * lisp.h (__executable_start): New decl.
1995
32d72c2f
GM
19962012-05-31 Glenn Morris <rgm@gnu.org>
1997
1998 * image.c (Fimagemagick_types): Doc fix.
1999
baac5bc7
JM
20002012-05-30 Jim Meyering <meyering@redhat.com>
2001
2002 * callproc.c (Fcall_process_region): Include directory component
2003 in mkstemp error message (Bug#11586).
2004
72cb32cf
PE
20052012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2006
2007 * alloc.c, lisp.h (make_pure_vector): Now static.
2008
61b108cc
SM
20092012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2010
2011 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2012 Move to byte-run.el.
2013 (Fautoload): Do the hash-doc more carefully.
2014 * data.c (Fdefalias): Purify definition, except for keymaps.
2015 (Qdefun): Move from eval.c.
2016 * lisp.h (Qdefun): Remove.
2017 * lread.c (read1): Tiny simplification.
2018
471fe23d
TN
20192012-05-29 Troels Nielsen <bn.troels@gmail.com>
2020
934f3f58 2021 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2022 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2023 Bug#9642, but explicitly check that the buffer the overlay would
2024 be moved to is live and rearrange lines to make sure that errors
2025 will not put the overlay in an inconsistent state.
2026 (Fdelete_overlay): Cosmetics.
2027
85d0efd1
EZ
20282012-05-28 Eli Zaretskii <eliz@gnu.org>
2029
2030 * w32term.c (my_bring_window_to_top): New function.
2031 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2032 could be different from the original one.
2033 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2034 (Bug#11513)
2035
2036 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2037 by calling BringWindowToTop.
2038
2039 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2040 (WM_EMACS_END): Increase by one.
2041
da92a98c
PE
20422012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2043
2044 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2045 This avoids undefined behavior that might cause the eassert
2046 to not catch an out-of-range value.
2047
74d1f848
JB
20482012-05-28 Juanma Barranquero <lekktu@gmail.com>
2049
2050 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2051 Update dependencies.
2052
9e1a06fc
EZ
20532012-05-27 Eli Zaretskii <eliz@gnu.org>
2054
2055 * bidi.c (bidi_mirror_char): Fix last change.
2056
f3dd7312
AS
20572012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2058
2059 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2060 when referring to sectname field in printf format.
2061
81899c91
PE
20622012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2063
57b81a9f
PE
2064 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2065 Only r_alloc_inhibit_buffer_relocation needed to be added;
2066 the others were already declared.
2067
81899c91
PE
2068 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2069 before checking whether it's out of range. Put the check inside
2070 eassert. See
2071 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2072
33017faf 20732012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2074
2075 * callproc.c (Fcall_process): Restore a line that was accidentally
2076 commented out in the 2011-02-13 change (bug#11547).
2077
33017faf 20782012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2079
2080 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2081 defined on ralloc.c.
2082
2083 * buffer.c [REL_ALLOC]: Remove prototypes of
2084 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2085 they are now on lisp.h.
2086
2087 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2088
2089 * search.c (search_buffer): Use it to inhibit relocation of buffer
2090 text while re_search_2 is doing its job, because re_search_2 is
2091 passed C pointers to buffer text. (Bug#11519)
2092
23415acf
EZ
2093 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2094 Update value to 24.
2095
44e27368
EZ
2096 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2097 state after an additional call to move_it_in_display_line_to, keep
2098 the values of it->max_ascent and it->max_descent found for the
2099 entire line.
2100 (pos_visible_p): Revert the comparison against bottom_y to what it
2101 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2102 (Bug#11464)
2103
c1892f11
PE
21042012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2105
2106 Fix coding-related core dumps with gcc -ftrapv.
2107 The code was computing A - B, where A and B are pointers, and B is
2108 random garbage. This can lead to core dumps on platforms that
2109 have special pointer registers, and it also leads to core dumps on
2110 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2111 A - B only when B is initialized properly.
2112 * coding.c (coding_set_source, coding_set_destination): Return void.
2113 (coding_change_source, coding_change_destinations): New functions,
2114 with the old behaviors of coding_set_source and coding_set_destination.
2115 All callers that need an offset changed to use these new functions.
2116
eb7afdad
GM
21172012-05-26 Glenn Morris <rgm@gnu.org>
2118
2119 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2120
f12fdf02
EZ
21212012-05-26 Eli Zaretskii <eliz@gnu.org>
2122
53a63be6 2123 Extend mouse support on W32 text-mode console.
61b108cc
SM
2124 * xdisp.c (draw_row_with_mouse_face):
2125 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2126
eb3f6f01 2127 * w32console.c: Include window.h.
61b108cc
SM
2128 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2129 New functions.
eb3f6f01
EZ
2130 (initialize_w32_display): Initialize mouse-highlight data.
2131
53a63be6
EZ
2132 * w32inevt.c: Include termchar.h and window.h.
2133 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2134 moves, call note_mouse_highlight. If help_echo changed, call
2135 gen_help_event to produce help-echo message in the echo area.
2136 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2137 highlight info.
2138
4cfd81f6
PE
21392012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2140
2141 * lread.c (read1): Simplify slightly to avoid an overflow warning
2142 with GCC 4.7.0 on x86-64.
2143
4446092a
EZ
21442012-05-26 Eli Zaretskii <eliz@gnu.org>
2145
2146 * bidi.c (bidi_mirror_char): Revert last change: an int is
2147 definitely wide enough here.
2148
42b2a986 21492012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2150
42b2a986 2151 Fix integer width and related bugs (Bug#9874).
eb106a49 2152 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2153 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2154 (string_bytes, check_sblock, allocate_string_data):
2155 (compact_small_strings, Fmake_bool_vector, make_string)
2156 (make_unibyte_string, make_multibyte_string)
2157 (make_string_from_bytes, make_specified_string)
2158 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2159 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2160 (mark_vectorlike):
2161 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2162 (allocate_pseudovector):
2163 Use int, not EMACS_INT, where int is wide enough.
2164 (inhibit_garbage_collection, Fgarbage_collect):
2165 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2166 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2167 int might not be wide enough.
2168 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2169 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2170 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2171 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2172 (bidi_level_of_next_char, bidi_move_to_visually_next):
2173 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2174 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2175 (Fkill_buffer, Fset_buffer_major_mode)
2176 (advance_to_char_boundary, Fbuffer_swap_text)
2177 (Fset_buffer_multibyte, overlays_at, overlays_in)
2178 (overlay_touches_p, struct sortvec, record_overlay_string)
2179 (overlay_strings, recenter_overlay_lists)
2180 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2181 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2182 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2183 (Foverlay_recenter, last_overlay_modification_hooks_used)
2184 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2185 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2186 (validate_region): Omit unnecessary test for b <= e,
2187 since that's guaranteed by the previous test.
d311d28c
PE
2188 (adjust_overlays_for_delete): Avoid pos + length overflow.
2189 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2190 (report_overlay_modification):
2191 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2192 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2193 Omit pointer cast, which isn't needed anyway, and doesn't work
2194 after the EMACS_INT -> ptrdiff_t change.
02481186 2195 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2196 * buffer.h: Adjust decls to match defn changes elsewhere.
2197 (struct buffer_text, struct buffer):
2198 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2199 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2200 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2201 not int, to avoid needless 32-bit limit on 64-bit hosts.
2202 (exec_byte_code): Use tighter memory-full test, one that checks
2203 for alloca overflow. Don't compute the address of the object just
2204 before an array, as that's not portable. Use EMACS_INT, not
2205 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2206 * callint.c (Fcall_interactively):
2207 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2208 * callproc.c (call_process_kill, Fcall_process):
2209 Don't assume pid_t fits into an Emacs fixnum.
2210 (call_process_cleanup, Fcall_process, child_setup):
2211 Don't assume pid_t fits into int.
2212 (call_process_cleanup, Fcall_process, delete_temp_file)
2213 (Fcall_process_region):
2214 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2215 (Fcall_process): Simplify handling of volatile integers.
2216 Use int, not EMACS_INT, where int will do.
2217 * casefiddle.c (casify_object, casify_region, operate_on_word)
2218 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2219 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2220 (casify_object): Avoid integer overflow when overallocating buffer.
2221 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2222 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2223 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2224 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2225 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2226 integers are now checked earlier. All uses replaced with XINT.
2227 (ccl_driver):
2228 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2229 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2230 (ccl_driver, Fregister_code_conversion_map):
2231 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2232 (resolve_symbol_ccl_program): Check that vector header is in range.
2233 Always copy the vector, so that we can check its contents reliably
2234 now rather than having to recheck each instruction as it's being
2235 executed. Check that vector words fit in 'int'.
2236 (ccl_get_compiled_code, Fregister_ccl_program)
2237 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2238 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2239 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2240 contents are in range.
2241 (Fccl_execute_on_string): Check that status is in range.
2242 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2243 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2244 Accept and return EMACS_INT, not int, because callers can pass values
2245 out of 'int' range.
2246 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2247 (multibyte_chars_in_text, parse_str_as_multibyte)
2248 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2249 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2250 (string_escape_byte8, Fget_byte):
2251 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2252 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2253 avoid mishandling large integers.
2254 * character.h: Adjust decls to match defn changes elsewhere.
2255 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2256 (Ffind_charset_region):
2257 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2258 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2259 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2260 Don't assume fixnum fits in int.
d311d28c
PE
2261 (load_charset_map_from_vector, Fmap_charset_chars):
2262 Remove now-unnecessary CHECK_NATNUMs.
2263 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2264 Don't rely on undefined behavior with signed left shift overflow.
2265 Don't assume unsigned int fits into fixnum, or that fixnum fits
2266 into unsigned int. Don't require max_code to be a valid fixnum;
2267 that's not true for gb10830 4-byte on a 32-bit host. Allow
2268 invalid_code to be a cons, for the same reason. Require code_offset
2269 to be a character. Avoid int overflow if max_char is close
2270 to INT_MAX.
2271 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2272 this is intended anyway and avoids some undefined behavior.
2273 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2274 INDEX_TO_CODE_POINT, as that's what it expects.
2275 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2276 * charset.h (DECODE_CHAR): Return int, not unsigned;
2277 this is what was intended anyway, and it avoids undefined behavior.
2278 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2279 integer-overflow issues.
2280 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2281 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2282 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2283 * chartab.c (Fmake_char_table, Fset_char_table_range)
2284 (uniprop_get_decoder, uniprop_get_encoder):
2285 Don't assume fixnum fits in int.
2286 * cmds.c (move_point): New function, that does the gist of
2287 Fforward_char and Fbackward_char, but does so while checking
2288 for integer overflow more accurately.
c96e5d6a 2289 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2290 (Fforward_line, Fend_of_line, internal_self_insert)
2291 (internal_self_insert):
2292 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2293 Fix a FIXME, by checking for integer overflow when calculating
2294 target_clm and actual_clm.
2295 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2296 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2297 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2298 (coding_alloc_by_making_gap, alloc_destination)
2299 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2300 (encode_coding_utf_16, detect_coding_emacs_mule)
2301 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2302 (detect_coding_iso_2022, decode_coding_iso_2022)
2303 (encode_invocation_designation, encode_designation_at_bol)
2304 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2305 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2306 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2307 (encode_coding_ccl, encode_coding_raw_text)
2308 (detect_coding_charset, decode_coding_charset)
2309 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2310 (produce_composition, produce_charset, produce_annotation)
2311 (decode_coding, handle_composition_annotation)
2312 (handle_charset_annotation, consume_chars, decode_coding_gap)
2313 (decode_coding_object, encode_coding_object, detect_coding_system)
2314 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2315 (code_convert_region, code_convert_string)
8f50130c
PE
2316 (Fdefine_coding_system_internal)
2317 (coding_set_source, coding_set_destination):
d311d28c
PE
2318 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2319 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2320 (Fdefine_coding_system_internal):
2321 Don't assume fixnums fit in int.
2322 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2323 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2324 (Funencodable_char_position, Fcheck_coding_systems_region)
2325 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2326 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2327 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2328 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2329 Don't access memory outside of the args array.
d311d28c 2330 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2331 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2332 result of ENCODE_CHAR.
d311d28c
PE
2333 * coding.h: Adjust decls to match defn changes elsewhere.
2334 (struct coding_system):
2335 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2336 * composite.c (get_composition_id, find_composition)
2337 (run_composition_function, update_compositions)
2338 (compose_text, composition_gstring_put_cache)
2339 (composition_gstring_p, composition_gstring_width)
2340 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2341 (composition_compute_stop_pos, composition_reseat_it)
2342 (composition_update_it, struct position_record)
2343 (find_automatic_composition, composition_adjust_point)
2344 (Fcomposition_get_gstring, Ffind_composition_internal):
2345 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2346 (update_compositions):
2347 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2348 * composite.h: Adjust decls to match defn changes elsewhere.
2349 (struct composition):
2350 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2351 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2352 Do not attempt to compute the address of the object just before a
2353 buffer; this is not portable.
2354 (Faref, Faset):
2355 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2356 (Faset): Use int, not EMACS_INT, where int is wide enough.
2357 (Fstring_to_number): Don't assume fixnums fit in int.
2358 (Frem): Don't assume arg is nonnegative.
2359 * dbusbind.c (xd_append_arg): Check for integers out of range.
2360 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2361 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2362 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2363 (xd_get_connection_references): Return ptrdiff_t, not int.
2364 All uses changed.
2365 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2366 (xd_read_message_1):
2367 Use int, not unsigned, where the dbus API uses int.
2368 (Fdbus_message_internal): Don't overflow mtype.
2369 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2370 * dired.c (directory_files_internal, file_name_completion, scmp)
2371 (file_name_completion_stat):
2372 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2373 (file_name_completion): Don't overflow matchcount.
2374 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2375 * dispextern.h: Adjust decls to match defn changes elsewhere.
2376 (struct text_pos, struct glyph, struct bidi_saved_info)
2377 (struct bidi_string_data, struct bidi_it, struct composition_it)
2378 (struct it):
2379 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2380 (struct display_pos, struct composition_it, struct it):
2381 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2382 * dispnew.c (increment_matrix_positions)
2383 (increment_row_positions, mode_line_string)
2384 (marginal_area_string):
2385 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2386 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2387 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2388 (duration_to_sec_usec): New function, to check for overflow better.
2389 (Fsleep_for, sit_for): Use it.
2390 * doc.c (get_doc_string, store_function_docstring):
2391 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2392 (get_doc_string, Fsnarf_documentation):
2393 Use int, not EMACS_INT, where int is wide enough.
2394 (get_doc_string):
2395 Use SAFE_ALLOCA, not alloca.
2396 Check for overflow when converting EMACS_INT to off_t.
2397 * doprnt.c (doprnt):
2398 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2399 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2400 Don't assume uid_t fits into fixnum.
2401 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2402 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2403 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2404 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2405 (general_insert_function)
2406 (Finsert_char, make_buffer_string, make_buffer_string_both)
2407 (update_buffer_properties, Fbuffer_substring)
2408 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2409 (Fsubst_char_in_region, check_translation)
2410 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2411 (transpose_markers, Ftranspose_regions):
2412 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2413 (clip_to_bounds): Move to lisp.h as an inline function).
2414 (Fconstrain_to_field): Don't assume integers are nonnegative.
2415 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2416 (Fsubst_char_in_region, Fsave_restriction):
2417 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2418 (Femacs_pid): Don't assume pid_t fits into fixnum.
2419 (lo_time): Use int, not EMACS_INT, when int suffices.
2420 (lisp_time_argument): Check for usec out of range.
2421 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2422 (Fuser_login_name, Fuser_full_name): Signal an error
2423 if a uid argument is out of range, rather than relying on
2424 undefined behavior.
c8d5c857
PE
2425 (Fformat_time_string): Remove now-unnecessary check.
2426 lisp_time_argument checks for out-of-range usec now.
243e0530 2427 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2428 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2429 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2430 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2431 (init_cmdargs, Fdump_emacs):
2432 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2433 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2434 the bottom (typically) 32 bits of the fixnum.
2435 * eval.c (specpdl_size, call_debugger):
2436 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2437 (when_entered_debugger, Fbacktrace_debug):
2438 Don't assume fixnum can fit in int.
2439 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2440 the object just before a buffer; this is not portable.
2441 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2442 (grow_specpdl, unbind_to):
2443 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2444 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2445 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2446 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2447 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2448 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2449 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2450 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2451 (a_write, e_write):
2452 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2453 (Fcopy_file, non_regular_nbytes, read_non_regular)
2454 (Finsert_file_contents):
2455 Use int, not EMACS_INT, where int is wide enough.
2456 (READ_BUF_SIZE): Verify that it fits in int.
2457 (Finsert_file_contents): Check that counts are in proper range,
2458 rather than assuming fixnums fit into ptrdiff_t etc.
2459 Don't assume fixnums fit into int.
125b3835 2460 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2461 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2462 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2463 (string_char_to_byte, string_byte_to_char)
2464 (string_make_multibyte, string_to_multibyte)
2465 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2466 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2467 (substring_both, Fdelete, internal_equal, Ffillarray)
2468 (Fclear_string, mapcar1)
2469 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2470 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2471 (larger_vector, make_hash_table, maybe_resize_hash_table)
2472 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2473 (Fmaphash, secure_hash):
2474 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2475 (concat): Check for string index and length overflow.
2476 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2477 (Frequire):
2478 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2479 (larger_vector): New API (vec, incr_min, size_max) replaces old
2480 one (vec, new_size, init). This catches size overflow.
2481 INIT was removed because it was always Qnil.
2482 All callers changed.
2483 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2484 the upper bound on a hash table index size.
2485 (make_hash_table, maybe_resize_hash_table): Use it.
2486 (secure_hash): Computer start_byte and end_byte only after
2487 they're known to be in ptrdiff_t range.
2488 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2489 (Ffont_get_glyphs, Ffont_at):
2490 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2491 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2492 (Flist_fonts, Fopen_font):
2493 Don't assume fixnum can fit in int.
2494 (check_gstring): Don't assume index can fit in int.
2495 (font_match_p): Check that fixnum is a character, not a nonnegative
2496 fixnum, since the later code needs to stuff it into an int.
2497 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2498 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2499 conversion overflow issues.
2500 (Fopen_font): Check for integer out of range.
2501 (Ffont_get_glyphs): Don't assume index can fit in int.
2502 * font.h: Adjust decls to match defn changes elsewhere.
2503 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2504 integer overflow.
2505 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2506 printmax_t, where ptrdiff_t is wide enough.
2507 (Finternal_char_font):
2508 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2509 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2510 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2511 (Fset_frame_position, x_set_frame_parameters)
2512 (x_set_line_spacing, x_set_border_width)
2513 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2514 Check that fixnums are in proper range for system types.
2515 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2516 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2517 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2518 Use SAFE_ALLOCA_LISP, not alloca.
2519 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2520 intptr_t is wide enough.
2521 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2522 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2523 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2524 Check for fixnum out of range.
2525 * ftfont.c (ftfont_list): Don't assume index fits in int.
2526 Check that fixnums are in proper range for system types.
2527 (ftfont_shape_by_flt):
2528 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2529 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2530 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2531 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2532 Check that fixnums are in proper range for system types.
2533 * gnutls.h: Adjust decls to match defn changes elsewhere.
2534 * gtkutil.c (xg_dialog_run):
2535 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2536 (update_frame_tool_bar):
2537 Check that fixnums are in proper range for system types.
2538 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2539 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2540 * indent.c (last_known_column, last_known_column_point):
2541 (current_column_bol_cache):
2542 (skip_invisible, current_column, check_display_width):
2543 (check_display_width, scan_for_column, current_column_1)
2544 (Findent_to, Fcurrent_indentation, position_indentation)
2545 (indented_beyond_p, Fmove_to_column, compute_motion):
2546 (Fcompute_motion, Fvertical_motion):
2547 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2548 (last_known_column_modified): Use EMACS_INT, not int.
2549 (check_display_width):
2550 (Fcompute_motion):
2551 Check that fixnums and floats are in proper range for system types.
2552 (compute_motion): Don't assume index or fixnum fits in int.
2553 (compute_motion, Fcompute_motion):
2554 Use int, not EMACS_INT, when it is wide enough.
2555 (vmotion): Omit local var start_hpos that is always 0; that way
2556 we don't need to worry about overflow in expressions involving it.
2557 * indent.h: Adjust decls to match defn changes elsewhere.
2558 (struct position):
2559 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2560 Use int, not EMACS_INT, where int is wide enough.
2561 Remove unused members ovstring_chars_done and tab_offset;
2562 all uses removed.
2563 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2564 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2565 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2566 (make_gap, copy_text, insert, insert_and_inherit)
2567 (insert_before_markers, insert_before_markers_and_inherit)
2568 (insert_1, count_combining_before, count_combining_after)
2569 (insert_1_both, insert_from_string)
2570 (insert_from_string_before_markers, insert_from_string_1)
2571 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2572 (adjust_after_replace, adjust_after_insert, replace_range)
2573 (replace_range_2, del_range, del_range_1, del_range_byte)
2574 (del_range_both, del_range_2, modify_region)
2575 (prepare_to_modify_buffer, signal_before_change)
2576 (signal_after_change, Fcombine_after_change_execute):
2577 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2578 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2579 (balance_an_interval, split_interval_right, split_interval_left)
2580 (find_interval, next_interval, update_interval)
2581 (adjust_intervals_for_insertion, delete_node, delete_interval)
2582 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2583 (static_offset_intervals, offset_intervals)
2584 (merge_interval_right, merge_interval_left, make_new_interval)
2585 (graft_intervals_into_buffer, temp_set_point_both)
2586 (temp_set_point, set_point, adjust_for_invis_intang)
2587 (set_point_both, move_if_not_intangible, get_property_and_range)
2588 (get_local_map, copy_intervals, copy_intervals_to_string)
2589 (compare_string_intervals, set_intervals_multibyte_1):
2590 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2591 * intervals.h: Adjust decls to match defn changes elsewhere.
2592 (struct interval):
2593 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2594 * keyboard.c (this_command_key_count, this_single_command_key_start)
2595 (before_command_key_count, before_command_echo_length, echo_now)
2596 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2597 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2598 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2599 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2600 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2601 (last_non_minibuf_size, last_point_position, echo_truncate)
2602 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2603 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2604 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2605 (stuff_buffered_input):
2606 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2607 (last_auto_save, command_loop_1, read_char):
2608 Use EMACS_INT, not int, to avoid integer overflow.
2609 (record_char): Avoid overflow in total_keys computation.
2610 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2611 * keyboard.h: Adjust decls to match defn changes elsewhere.
2612 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2613 (Fkey_description, Fdescribe_vector, Flookup_key):
2614 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2615 (click_position): New function, to check that positions are in range.
2616 (Fcurrent_active_maps):
2617 (describe_command):
2618 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2619 (Faccessible_keymaps, Fkey_description):
2620 (preferred_sequence_p):
2621 Don't assume fixnum can fit into int.
2622 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2623 Check for integer overflow in size calculations.
2624 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2625 avoid mishandling large integers.
2626 * lisp.h: Adjust decls to match defn changes elsewhere.
2627 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2628 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2629 (struct Lisp_Marker):
2630 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2631 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2632 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2633 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2634 All callers changed.
2635 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2636 Assume the arg has valid form, since it always does.
2637 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2638 unsigned integer system type.
2639 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2640 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2641 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2642 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2643 (duration_to_sec_usec): New decl.
2644 * lread.c (read_from_string_index, read_from_string_index_byte)
2645 (read_from_string_limit, readchar, unreadchar, openp)
2646 (read_internal_start, read1, oblookup):
2647 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2648 (Fload, readevalloop, Feval_buffer, Feval_region):
2649 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2650 (openp): Check for out-of-range argument to 'access'.
2651 (read1): Use int, not EMACS_INT, where int is wide enough.
2652 Don't assume fixnum fits into int.
6efdadfd 2653 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2654 (read_filtered_event): Use duration_to_sec_usec
2655 to do proper overflow checking on durations.
d311d28c
PE
2656 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2657 in size calculation.
2658 (Fexecute_kbd_macro):
2659 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2660 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2661 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2662 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2663 (set_marker_both, set_marker_restricted_both, marker_position)
2664 (marker_byte_position, Fbuffer_has_markers_at):
2665 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2666 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2667 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2668 It now merely ensures that the menu is large enough, without
2669 necessarily growing it, as this avoids some integer overflow issues.
2670 All callers changed.
2671 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2672 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2673 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2674 Use SAFE_ALLOCA_LISP, not alloca.
2675 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2676 to EMACS_INT. Check that fixnums are in proper range for system types.
2677 * minibuf.c (minibuf_prompt_width, string_to_object)
2678 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2679 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2680 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2681 (get_minibuffer, read_minibuf_unwind):
2682 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2683 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2684 this simplifies overflow checking. All callers changed.
2685 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2686 (Ftest_completion):
2687 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2688 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2689 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2690 Check that fixnums are in proper range for system types.
2691 (Fx_create_frame, Fx_show_tip):
2692 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2693 * nsfont.m (ns_findfonts, nsfont_list_family):
2694 Don't assume fixnum fits in long.
2695 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2696 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2697 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2698 wide enough.
17fdb222 2699 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2700 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2701 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2702 (PRINTDECLARE, PRINTPREPARE):
2703 (strout, print_string):
2704 (print, print_preprocess, print_check_string_charset_prop)
2705 (print_object):
2706 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2707 (PRINTDECLARE):
2708 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2709 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2710 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2711 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2712 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2713 (print_error_message): Use SAFE_ALLOCA, not alloca.
2714 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2715 (print_depth, new_backquote_output, print_number_index):
2716 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2717 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2718 (Fset_process_window_size, Fformat_network_address)
2719 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2720 (sigchld_handler):
d311d28c 2721 Check that fixnums are in proper range for system types.
d44287d4 2722 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2723 Check for process-ids out of pid_t range rather than relying on
2724 undefined behavior.
e4d81efc 2725 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2726 (Fformat_network_address, read_process_output, send_process)
2727 (Fprocess_send_region, status_notify):
2728 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2729 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2730 (wait_reading_process_output, read_process_output, exec_sentinel):
2731 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2732 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2733 (Faccept_process_output): Use duration_to_sec_usec to do proper
2734 overflow checking on durations.
dde14581
PE
2735 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2736 Don't assume pid_t fits in int.
02481186
PE
2737 * process.h (struct Lisp_Process): Members tick and update_tick
2738 are now of type EMACS_INT, not int.
b62b53e8
PE
2739 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2740 configured --with-wide-int.
d311d28c
PE
2741 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2742 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2743 * search.c (looking_at_1, string_match_1):
2744 (fast_string_match, fast_c_string_match_ignore_case)
2745 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2746 (scan_newline, find_before_next_newline, search_command)
2747 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2748 (set_search_regs, wordify):
2749 (Freplace_match):
2750 (Fmatch_data):
2751 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2752 (string_match_1, search_buffer, set_search_regs):
2753 (Fmatch_data):
2754 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2755 (wordify): Check for overflow in size calculation.
2756 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2757 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2758 Check that fixnums are in proper range for system types.
2759 * sound.c (struct sound_device)
2760 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2761 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2762 (Fplay_sound_internal):
2763 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2764 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2765 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2766 (Fparse_partial_sexp):
2767 Don't assume fixnums can fit in int.
2768 (struct lisp_parse_state, find_start_pos, find_start_value)
2769 (find_start_value_byte, find_start_begv)
2770 (update_syntax_table, char_quoted, dec_bytepos)
2771 (find_defun_start, prev_char_comend_first, back_comment):
2772 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2773 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2774 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2775 (Finternal_describe_syntax_value): Check that match_lisp is a
2776 character, not an integer, since the code stuffs it into int.
2777 (scan_words, scan_sexps_forward):
2778 Check that fixnums are in proper range for system types.
2779 (Fforward_word):
2780 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2781 (scan_sexps_forward):
2782 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2783 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2784 * syntax.h: Adjust decls to match defn changes elsewhere.
2785 (struct gl_state_s):
2786 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2787 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2788 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2789 * sysdep.c (wait_for_termination_1, wait_for_termination)
2790 (interruptible_wait_for_termination, mkdir):
2791 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2792 (emacs_read, emacs_write):
2793 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2794 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2795 and double all fit in int.
d311d28c
PE
2796 * term.c (set_tty_color_mode):
2797 Check that fixnums are in proper range for system types.
2798 * termhooks.h (struct input_event):
2799 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2800 * textprop.c (validate_interval_range, interval_of)
2801 (Fadd_text_properties, set_text_properties_1)
2802 (Fremove_text_properties, Fremove_list_of_text_properties)
2803 (Ftext_property_any, Ftext_property_not_all)
2804 (copy_text_properties, text_property_list, extend_property_ranges)
2805 (verify_interval_modification):
2806 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2807 (Fnext_single_char_property_change)
2808 (Fprevious_single_char_property_change):
2809 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2810 (copy_text_properties):
2811 Check for integer overflow in index calculation.
d311d28c
PE
2812 * undo.c (last_boundary_position, record_point, record_insert)
2813 (record_delete, record_marker_adjustment, record_change)
2814 (record_property_change):
2815 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2816 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2817 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2818 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2819 (Fx_hide_tip, Fx_file_dialog):
2820 * w32menu.c (set_frame_menubar):
2821 Use ptrdiff_t, not int, for consistency with rest of code.
2822 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2823 (select_window, Fdelete_other_windows_internal)
2824 (window_scroll_pixel_based, window_scroll_line_based)
2825 (Frecenter, Fset_window_configuration):
2826 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2827 (Fset_window_hscroll, run_window_configuration_change_hook)
2828 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2829 (Fscroll_other_window, Frecenter):
d311d28c
PE
2830 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2831 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2832 Don't assume fixnum fits in int.
2833 (Fset_window_scroll_bars):
2834 Check that fixnums are in proper range for system types.
2835 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2836 (string_pos, c_string_pos, number_of_chars, init_iterator)
2837 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2838 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2839 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2840 (face_before_or_after_it_pos, handle_invisible_prop)
2841 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2842 (display_prop_intangible_p, string_buffer_position_lim)
2843 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2844 (get_overlay_strings_1, get_overlay_strings)
2845 (iterate_out_of_display_property, forward_to_next_line_start)
2846 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2847 (get_next_display_element, set_iterator_to_next)
2848 (get_visually_first_element, compute_stop_pos_backwards)
2849 (handle_stop_backwards, next_element_from_buffer)
2850 (move_it_in_display_line_to, move_it_in_display_line)
2851 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2852 (add_to_log, message_dolog, message_log_check_duplicate)
2853 (message2, message2_nolog, message3, message3_nolog
2854 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2855 (current_message_1, truncate_echo_area, truncate_message_1)
2856 (set_message, set_message_1, store_mode_line_noprop)
2857 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2858 (text_outside_line_unchanged_p, check_point_in_composition)
2859 (reconsider_clip_changes)
2860 (redisplay_internal, set_cursor_from_row, try_scrolling)
2861 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2862 (redisplay_window, find_last_unchanged_at_beg_row)
2863 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2864 (trailing_whitespace_p, find_row_edges, display_line)
2865 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2866 (display_mode_element, store_mode_line_string)
2867 (pint2str, pint2hrstr, decode_mode_spec)
2868 (display_count_lines, display_string, draw_glyphs)
2869 (x_produce_glyphs, x_insert_glyphs)
2870 (rows_from_pos_range, mouse_face_from_buffer_pos)
2871 (fast_find_string_pos, mouse_face_from_string_pos)
2872 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2873 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2874 (safe_call, init_from_display_pos, handle_fontified_prop)
2875 (handle_single_display_spec, load_overlay_strings)
2876 (with_echo_area_buffer, setup_echo_area_for_printing)
2877 (display_echo_area, echo_area_display)
2878 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2879 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2880 (redisplay_window, dump_glyph_row, display_mode_line)
2881 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2882 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2883 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2884 (handle_single_display_spec, build_desired_tool_bar_string)
2885 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2886 (get_specified_cursor_type):
2887 Check that fixnums are in proper range for system types.
2888 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2889 (Flookup_image_map):
2890 Don't assume fixnums fit in int.
2891 (compare_overlay_entries):
2892 Avoid mishandling comparisons due to subtraction overflow.
2893 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2894 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2895 (handle_tool_bar_click):
2896 Use int, not unsigned, since we prefer signed and the signedness
2897 doesn't matter here.
2898 (get_next_display_element, next_element_from_display_vector):
2899 Use int, not EMACS_INT, when int is wide enough.
2900 (start_hourglass): Use duration_to_sec_usec to do proper
2901 overflow checking on durations.
2902 * xfaces.c (Fbitmap_spec_p):
2903 Check that fixnums are in proper range for system types.
2904 (compare_fonts_by_sort_order):
2905 Avoid mishandling comparisons due to subtraction overflow.
2906 (Fx_family_fonts, realize_basic_faces):
2907 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2908 (Fx_family_fonts):
2909 Don't assume fixnum fits in int.
2910 Use SAFE_ALLOCA_LISP, not alloca.
2911 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2912 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2913 (face_at_buffer_position, face_for_overlay_string)
2914 (face_at_string_position):
2915 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2916 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2917 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2918 (Fx_show_tip):
2919 Check that fixnums are in proper range for system types.
2920 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2921 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2922 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2923 (Fx_change_window_property): Don't assume fixnums fit in int.
2924 * xfont.c (xfont_chars_supported):
2925 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2926 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2927 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2928 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2929 * xml.c (parse_region):
2930 * xrdb.c (magic_file_p):
2931 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2932 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2933 (x_get_local_selection, x_reply_selection_request)
2934 (x_handle_selection_request, wait_for_property_change):
2935 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2936 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2937 short is wide enough.
2938 (x_send_client_event): Don't assume fixnum fits in int.
2939 * xterm.c (x_x_to_emacs_modifiers):
2940 Don't assume EMACS_INT overflows nicely into int.
2941 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2942 may come from Lisp.
2943 (handle_one_xevent): NATNUMP can eval its arg twice.
2944 (x_connection_closed):
2945 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2946 * xterm.h: Adjust decls to match defn changes elsewhere.
2947 (struct scroll_bar): Use struct vectorlike_header
2948 rather than rolling our own approximation.
2949 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2950
c6574eb5
GM
29512012-05-25 Glenn Morris <rgm@gnu.org>
2952
2953 * lisp.mk (lisp): Update for more files being compiled now.
2954
e8d32c7e
SM
29552012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2956
48def666
SM
2957 * lread.c: Remove `read_pure' which makes no difference.
2958 (read_pure): Remove var.
2959 (unreadpure): Remove function.
2960 (readevalloop): Don't call read_list with -1 flag.
2961 (read1, read_vector): Don't test read_pure any more.
2962 (read_list): Simplify.
2963
e8d32c7e
SM
2964 * fileio.c, character.h: Minor style tweaks.
2965
4b2addb7
DA
29662012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2967
2968 * window.h (clip_changed): Remove useless declaration.
2969
584461b2
JB
29702012-05-22 Juanma Barranquero <lekktu@gmail.com>
2971
2972 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2973 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2974
34374650
PE
29752012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2976
2977 Remove src/m/*.
2978 This directory predates autoconf and is no longer needed nowadays.
2979 Move its few remaining bits of functionality to where they're needed.
2980 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2981 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2982 * m/template.h: Remove.
2983 * Makefile.in (M_FILE): Remove. All uses removed.
2984 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2985 * lisp.h (USE_LSB_TAG):
2986 * mem-limits.h (EXCEEDS_LISP_PTR):
2987 Use VAL_MAX, not VALBITS, in #if.
2988 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2989 (EMACS_UINT): Define unconditionally now.
2990 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2991 (BITS_PER_EMACS_INT): New constants, replacing
2992 what used to be in config.h, but not useful in #if.
2993 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2994 define them any more.
2995 (VAL_MAX): New macro.
2996 (VALMASK): Use it.
2997 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2998 BITS_PER_EMACS_INT, in #if.
2999 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3000 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3001 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3002 * s/ms-w32.h (DATA_START):
3003 Move here from removed file m/intel386.h.
3004 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3005 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3006
261cb4bb
PE
30072012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3008
3009 Assume C89 or later.
3010 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3011 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3012 (xrealloc):
3013 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3014 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3015 * textprop.c, tparam.c (NULL): Remove.
3016 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3017 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3018 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3019 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3020 * xterm.c (input_signal_count): Assume volatile works.
3021
ff23cd9f
KB
30222012-05-21 Ken Brown <kbrown@cornell.edu>
3023
3024 * xgselect.c (xg_select): Fix first argument in call to 'select'
3025 (bug#11508).
3026
1b170bc6
KB
30272012-05-20 Ken Brown <kbrown@cornell.edu>
3028
3029 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3030 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3031
b2f4d39f
KB
30322012-05-19 Ken Brown <kbrown@cornell.edu>
3033
3034 * xfns.c (x_in_use): Remove `static' qualifier.
3035 * xterm.h (x_in_use): Declare.
3036 * xgselect.c: Include xterm.h.
3037 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3038 and `display_arg' (bug#9754).
3039
003fdae2
PE
30402012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3041
9232a6d9
PE
3042 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3043
003fdae2
PE
3044 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3045 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3046
784b56e2
EZ
30472012-05-18 Eli Zaretskii <eliz@gnu.org>
3048
3049 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3050
3051 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3052 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3053
3054 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3055 reference to image_cache->refcount.
3056 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3057
a0a79cde
JL
30582012-05-17 Juri Linkov <juri@jurta.org>
3059
3060 * search.c (Fword_search_regexp, Fword_search_backward)
3061 (Fword_search_forward, Fword_search_backward_lax)
3062 (Fword_search_forward_lax): Move functions to isearch.el
3063 (bug#10145, bug#11381).
3064
b0572523
PE
30652012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3066
3067 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3068
9660f5fc
SM
30692012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3070
3071 * lread.c (init_obarray): Declare Qt and Qnil as special.
3072
4374de83
GM
30732012-05-14 Glenn Morris <rgm@gnu.org>
3074
3075 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3076 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3077
dc44c39a
PE
30782012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3079
078c97cb
PE
3080 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3081
dc44c39a
PE
3082 * unexaix.c: Port to more-recent AIX compilers.
3083 (report_error, report_error_1, make_hdr, copy_sym)
3084 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3085 Make arguments const char *, not char *, to avoid violations of C
3086 standard and to fix some AIX warnings reported by Gilles Pion.
3087
e18afed7 30882012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3089
3090 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3091 already have overlays loaded.
3092 (handle_single_display_spec): Before returning without displaying
3093 fringe bitmap, synchronize the bidi iterator with the main display
3094 iterator, by calling iterate_out_of_display_property.
3095 (iterate_out_of_display_property): Detect buffer iteration by
3096 testing that it->string is a Lisp string.
3097 (get_next_display_element): When the current object is exhausted,
3098 and there's something on it->stack, call set_iterator_to_next to
3099 proceed with what's on the stack, instead of returning zero.
3100 (set_iterator_to_next): If called at the end of a Lisp string,
3101 proceed to consider_string_end without incrementing string
3102 position. Don't increment display vector index past the end of
3103 the display vector. (Bug#11417)
c8fb9dc6
EZ
3104 (pos_visible_p): Don't report a position visible when move_it_to
3105 stopped at the last line of window, which happens to be scanned
3106 backwards by the bidi iteration. (Bug#11464)
ac268e67 3107
e18afed7 31082012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3109
3110 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3111 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3112 are on a TTY, and thus unable to display on the fringes.
3113 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3114 so we need to signal to the caller that this is a "replacing"
3115 display spec. This fixes display when the spec is invalid or we
3116 are on a TTY.
3117
e18afed7 31182012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3119
3120 * unexaix.c (make_hdr): Fix typo in prototype.
3121 This bug broke the build on AIX. Problem reported by Gilles Pion.
3122
9d0a235a
MA
31232012-05-14 Michael Albinus <michael.albinus@gmx.de>
3124
3125 * keyboard.c (kbd_buffer_get_event): Read special events also in
3126 batch mode. (Bug#11415)
3127
9e6b06ed
GM
31282012-05-12 Glenn Morris <rgm@gnu.org>
3129
3130 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3131
c1a1d7a3
EZ
31322012-05-12 Eli Zaretskii <eliz@gnu.org>
3133
3134 * lisp.mk (lisp): Add newcomment.elc.
3135
3fe7cdc8
GM
31362012-05-12 Glenn Morris <rgm@gnu.org>
3137
3138 * Makefile.in (MKDIR_P): New, set by configure.
3139 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3140
53f7d2c0
PE
31412012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3142
3143 Remove unused function hourglass_started.
3144 * dispextern.h (hourglass_started):
3145 * w32fns.c (hourglass_started):
3146 * xdisp.c (hourglass_started): Remove.
3147
75aafb17
JB
31482012-05-10 Juanma Barranquero <lekktu@gmail.com>
3149
3150 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3151 Update dependencies.
3152
12959e8e
PE
31532012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3154
97107e2e
PE
3155 * xgselect.c (xg_select): Put maxfds+1 into a var.
3156 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3157
12959e8e
PE
3158 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3159
836d29b3
DA
31602012-05-10 Dave Abrahams <dave@boostpro.com>
3161
3162 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3163 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3164
5cb67954
MA
31652012-05-09 Michael Albinus <michael.albinus@gmx.de>
3166
3167 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3168 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3169 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3170 Initialize xd_registered_buses.
3171
3478ec45
PE
31722012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3173
b263a6b0
PE
3174 Untag more efficiently if USE_LSB_TAG.
3175 This is based on a proposal by YAMAMOTO Mitsuharu in
3176 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3177 For an admittedly artificial (nth 8000 longlist) benchmark on
3178 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3179 Emacs's overall text size by 1%.
3180 * lisp.h (XUNTAG): New macro.
3181 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3182 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3183 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3184 * eval.c (Fautoload):
3185 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3186 * frame.h (XFRAME): Use XUNTAG.
3187
3478ec45
PE
3188 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3189 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3190 Remove unportable assumptions about print widths of types like
3191 dbus_uint32_t.
3192 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3193 intptr_t when converting between pointer and integer, to avoid GCC
3194 warnings about wrong width.
3195
666b903b 31962012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3197
3198 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3199 stack for each reader_thread, instead of defaulting to 8MB
3200 determined by the linker. This avoids failures in creating
3201 subprocesses on Windows 7, see the discussion in this thread:
3202 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3203
b120cc17
JC
32042012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3205
3206 Fix up display of the *Minibuf-0* buffer in the mini window.
3207 * keyboard.c (read_char): Don't clear the echo area if there's no
3208 message to clear.
3209 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3210 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3211
9a4b36f8
MA
32122012-05-07 Michael Albinus <michael.albinus@gmx.de>
3213
3214 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3215 batch mode.
3216
e5f9458f
CY
32172012-05-06 Chong Yidong <cyd@gnu.org>
3218
3219 * lisp.mk (lisp): Update.
3220
eceeb5fc 32212012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3222
3223 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3224
71873e2b
SM
32252012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3226
3227 * data.c (PUT_ERROR): New macro.
3228 (syms_of_data): Use it. Add new error type `user-error'.
3229 * undo.c (user_error): New function.
3230 (Fprimitive_undo): Use it.
3231 * print.c (print_error_message): Adjust print style for `user-error'.
3232 * keyboard.c (user_error): New function.
3233 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3234
ab0fa4e4
PE
32352012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3236
3237 Do not limit current-time-string to years 1000..9999.
3238 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3239 (Fcurrent_time_string): Support any year that is supported by the
3240 underlying localtime representation. Don't use asctime, as it
3241 has undefined behavior for years outside the range -999..9999.
3242
7ed806a7
PE
32432012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3244
3245 Fix race conditions involving setenv, gmtime, localtime, asctime.
3246 Without this fix, interrupts could mess up code that uses these
3247 nonreentrant functions, since setting TZ invalidates existing
3248 tm_zone or tzname values, and since most of these functions return
3249 pointers to static storage.
3250 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3251 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3252 Grow the critical sections to include not just invoking
3253 localtime/gmtime, but also accessing these functions' results
3254 including their tm_zone values if any, and any related TZ setting.
3255 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3256 so that the struct tm is saved in the critical section.
3257 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3258 motivated by the fact that memory allocation needs to be outside
3259 the critical section.
3260
0c16dfed
DA
32612012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3262
3263 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3264 with RESET_INTERVAL.
3265
3266 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3267 Remove duplicated buffer name initialization.
3268
3f83ace8
JM
32692012-05-02 Jim Meyering <jim@meyering.net>
3270
3271 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3272
c7b8541e
JM
3273 * xfns.c (x_window): Use xstrdup (Bug#11375).
3274
90207a15 32752012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3276
3277 * xdisp.c (pos_visible_p): If already at a newline from the
3278 display string before the 'while' loop, don't walk back the glyphs
3279 from it3.glyph_row. Solves assertion violation when the display
3280 string begins with a newline (egg.el). (Bug#11367)
3281
b593d6a9
AH
32822012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3283
3284 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3285 Move to simple.el.
3286
4737362e
GM
32872012-05-01 Glenn Morris <rgm@gnu.org>
3288
99cf43f9
GM
3289 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3290 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3291 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3292 All were removed before 23.1.
3293
9311dcff
GM
3294 * dispnew.c: Remove HAVE_LIBNCURSES test;
3295 it is always true on relevant platforms.
3296
4d5c6349
GM
3297 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3298 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3299
4737362e
GM
3300 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3301
74dd3a6b
AS
33022012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3303
3304 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3305 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3306 Remove.
3307
13c379ee
PE
33082012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3309
3310 Do not avoid creating empty evaporating overlays (Bug#9642).
3311 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3312 That is, do not delete an evaporating overlay if it becomes
3313 empty after its bounds are adjusted to fit within its buffer.
3314 This fix caused other problems, and I'm reverting it until we get
3315 to the bottom of them.
3316
a8e7d6d7 33172012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3318
3319 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3320
a8e7d6d7 33212012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3322
3323 * xdisp.c (pos_visible_p): If the window start position is beyond
3324 ZV, start the display from buffer beginning. Prevents assertion
3325 violation in init_iterator when the minibuffer window is scrolled
3326 via the scroll bar.
3327
3328 * window.c (window_scroll_pixel_based): Likewise.
3329
a8e7d6d7 33302012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3331
3332 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3333
a8e7d6d7 33342012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3335
3336 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3337 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3338
a8e7d6d7 33392012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3340
b593d6a9
AH
3341 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3342 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3343
1c6900d9
EZ
33442012-04-26 Eli Zaretskii <eliz@gnu.org>
3345
4c3fa1d9
EZ
3346 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3347 display element, check also the underlying string or buffer
3348 character. (Bug#11341)
3349
1c6900d9
EZ
3350 * w32menu.c: Include w32heap.h.
3351 (add_menu_item): If the call to AppendMenuW (via
3352 unicode_append_menu) fails, disable Unicode menus only if we are
3353 running on Windows 9X/Me.
3354
42bf8205
AS
33552012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3356
3357 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3358 (xgetint): Add missing shift for LSB tags.
3359
b1bac16e
MR
33602012-04-24 Martin Rudalics <rudalics@gmx.at>
3361
3362 * keyboard.c (read_char): Don't wipe echo area for select window
3363 events: These might get delayed via `mouse-autoselect-window'
3364 (Bug#11304).
3365
d69621cc
JB
33662012-04-24 Juanma Barranquero <lekktu@gmail.com>
3367
3368 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3369 manipulation of :loaded-from data.
3370
02fd101b
JB
33712012-04-23 Juanma Barranquero <lekktu@gmail.com>
3372
3373 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3374 now a cons (bug#11311).
3375
888bec30
PE
33762012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3377
89a438bd
PE
3378 Do not create empty overlays with the evaporate property (Bug#9642).
3379 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3380 if it becomes empty after its bounds are adjusted to fit within
3381 its buffer. Without this fix, in a nonempty buffer (let ((o
3382 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3383 yields an empty overlay that has the evaporate property, which is
3384 not supposed to happen.
3385
1068fe4d
PE
3386 Fix minor GTK3 problems found by static checking.
3387 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3388 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3389 (struct _EmacsFixedClass, emacs_fixed_get_type):
3390 Move decls here from emacsgtkfixed.h, since they needn't be public.
3391 (emacs_fixed_get_type): Now static.
3392 (emacs_fixed_class_init): Omit unused local.
3393 (emacs_fixed_child_type): Remove; unused.
3394 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3395 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3396 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3397 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3398 (EMACS_FIXED_GET_CLASS): Remove; unused.
3399 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3400
888bec30
PE
3401 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3402 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3403
de85e130
PE
34042012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3405
d0baac98 3406 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3407 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3408 (__malloc_size_t, __malloc_ptrdiff_t):
3409 Remove. All uses removed, replaced by the definiens if needed,
3410 since we can assume C89 or better now.
3411 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3412 (protect_malloc_state, align, get_contiguous_space)
3413 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3414 (malloc_atfork_handler_child, malloc_enable_thread)
3415 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3416 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3417 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3418 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3419 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3420 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3421 Define using prototypes, not old style.
3422 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3423 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3424 (align): Don't assume that signed integer overflow wraps around.
3425 Omit unused local var.
3426 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3427 (_free_internal_nolock, memalign, mallochook, reallochook):
3428 Omit no-longer-needed casts.
3429 (valloc): Use getpagesize, not __getpagesize.
3430 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3431 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3432
de85e130
PE
3433 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3434
dcbf5805
MA
34352012-04-22 Michael Albinus <michael.albinus@gmx.de>
3436
3437 Move functions from C to Lisp. Make non-blocking method calls
3438 the default. Implement further D-Bus standard interfaces.
3439
3440 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3441 (QCdbus_request_name_allow_replacement)
3442 (QCdbus_request_name_replace_existing)
3443 (QCdbus_request_name_do_not_queue)
3444 (QCdbus_request_name_reply_primary_owner)
3445 (QCdbus_request_name_reply_in_queue)
3446 (QCdbus_request_name_reply_exists)
3447 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3448 (QCdbus_registered_serial, QCdbus_registered_method)
3449 (QCdbus_registered_signal): New Lisp objects.
3450 (XD_DEBUG_MESSAGE): Use sizeof.
3451 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3452 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3453 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3454 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3455 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3456 (xd_signature, xd_append_arg): Allow float for integer types.
3457 (xd_get_connection_references): New function.
b593d6a9
AH
3458 (xd_get_connection_address): Rename from xd_initialize.
3459 Return cached address.
dcbf5805
MA
3460 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3461 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3462 level.
3463 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3464 Return number of refcounts.
dcbf5805
MA
3465 (Fdbus_get_unique_name): Make stronger parameter check.
3466 (Fdbus_message_internal): New defun.
3467 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3468 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3469 (Fdbus_send_signal, Fdbus_register_service)
3470 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3471 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3472 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3473 (Vdbus_compiled_version, Vdbus_runtime_version)
3474 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3475 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3476 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3477 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3478 Adapt docstring.
dcbf5805 3479
52828e02
PE
34802012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3481
da05bc4c
PE
3482 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3483 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3484 Do not assume ptrdiff_t is the same width as 'int'.
3485
52828e02
PE
3486 * alloc.c: Handle unusual debugging option combinations.
3487 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3488 since the two debugging options are incompatible.
3489 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3490 is defined.
3491 (mem_init, mem_insert, mem_insert_fixup):
3492 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3493 (NEED_MEM_INSERT): Remove; no longer needed.
3494
f01769f9
LL
34952012-04-22 Leo Liu <sdl.web@gmail.com>
3496
3497 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3498
5790543d
PE
34992012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3500
3501 * sysdep.c [__FreeBSD__]: Minor cleanups.
3502 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3503 Use Emacs indenting style more consistently. Avoid some casts.
3504 Use 'double' consistently rather than mixing 'float' and 'double'.
3505
b91b7e4d
EW
35062012-04-21 Eduard Wiebe <usenet@pusto.de>
3507
b593d6a9
AH
3508 * sysdep.c (list_system_processes, system_process_attributes):
3509 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3510
6114eb15
AS
35112012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3512
3513 * lisp.mk (lisp): Update.
3514
2f38dff7
PE
35152012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3516
3517 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3518 It is never used otherwise.
3519
4ae29f89
SM
35202012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3521
3522 * print.c (print_preprocess): Only check print_depth if print-circle
3523 is nil.
3524 (print_object): Check for cycles even when print-circle is nil and
3525 print-gensym is t, but only check print_depth if print-circle is nil.
3526
f30d612a
CY
35272012-04-20 Chong Yidong <cyd@gnu.org>
3528
3529 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3530 set the status to "failed" and ensure that sentinel is run.
3531
c07a4c0b 35322012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3533
3534 * process.c (Fset_process_inherit_coding_system_flag)
3535 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3536 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3537
c07a4c0b 35382012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3539
3540 * xdisp.c (string_buffer_position_lim): Limit starting position to
3541 BEGV.
3542 (set_cursor_from_row): If called for a mode-line or header-line
3543 row, return zero immediately.
3544 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3545 farther than the first row after the header line, if any.
3546 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3547 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3548
c07a4c0b 35492012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3550
4ae29f89
SM
3551 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3552 (bug#11238).
ad3a2b41 3553
c07a4c0b 35542012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 35552012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3556
3557 configure: new option --enable-gcc-warnings (Bug#11207)
3558 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3559 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3560 (ALL_CFLAGS): Use new macros rather than old.
3561 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3562 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3563 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3564 -Wunused-result, -Wunused-variable. This should go away once
3565 the Emacs and Gnulib regex code is merged.
3566 (xmalloc, xrealloc): Now static.
3567
aba027e8
PE
35682012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3569
3570 * dired.c (Fsystem_groups): Remove unused local.
3571
e5a36063
GM
35722012-04-17 Glenn Morris <rgm@gnu.org>
3573
3574 * dired.c (Fsystem_users): Doc fix.
3575
316411f0
DA
35762012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3577
3578 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3579 (syms_of_dired): Add them.
3580
9426aba4
PE
35812012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3582
b62a57be
PE
3583 Fix minor alloc.c problems found by static checking.
3584 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3585 New extern decls, to avoid calling undeclared functions.
3586 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3587 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3588 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3589 (NEED_MEM_INSERT): New macro.
3590 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3591 Remove one incorrect comment and fix another.
b62a57be 3592
3539f31f
PE
3593 Fix minor ralloc.c problems found by static checking.
3594 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3595 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3596 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3597 (r_alloc_sbrk): Now static.
3598
a041960a
PE
3599 Improve ralloc.c interface checking.
3600 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3601 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3602 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3603 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3604 [REL_ALLOC]: ... to here, to check interface.
3605 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3606 Remove decls. This fixes an "It stinks!".
3607
9426aba4
PE
3608 * alloc.c (which_symbols): Fix alignment issue / type clash.
3609
d55c12ed
AS
36102012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3611
3612 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3613 (struct Lisp_Misc_Any): Likewise.
3614 (struct Lisp_Free): Likewise.
3615 * alloc.c (union aligned_Lisp_Symbol): Define.
3616 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3617 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3618 (union aligned_Lisp_Misc): Define.
3619 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3620 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3621 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3622
b948ce8b
PE
36232012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3624
3625 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3626 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3627 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3628 * s/netbsd.h, s/sol2-6.h:
3629 Remove definition of GC_MARK_STACK, since the default now works.
3630 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3631 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3632 no longer the default.
3633 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3634
35dc09a1 36352012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3636
35dc09a1
GM
3637 * lread.c (lisp_file_lexically_bound_p):
3638 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3639
35dc09a1
GM
36402012-04-14 Eli Zaretskii <eliz@gnu.org>
3641
3642 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3643 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3644
36452012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3646
3647 * nsterm.m (constrainFrameRect): Always constrain when there is only
3648 one screen (Bug#10962).
3649
bcd86815
KB
36502012-04-13 Ken Brown <kbrown@cornell.edu>
3651
3652 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3653
c25df26e
RT
36542012-04-13 Reuben Thomas <rrt@sc3d.org>
3655
3656 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3657
0fc59f1e
DC
36582012-04-11 Daniel Colascione <dancol@dancol.org>
3659
3660 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3661 against is gone. It's better to use vfork now so that when Cygwin
3662 gains a new, working vfork, we use it automatically (bug#10398).
3663
de8c03dc
SM
36642012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3665
3666 * window.c (save_window_save): Obey window-point-insertion-type.
3667
2f097256
GM
36682012-04-11 Glenn Morris <rgm@gnu.org>
3669
3670 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3671
453b951e
SM
36722012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3673
3674 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3675
75f1671a 36762012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3677
3678 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3679 (force_quit_count): New var.
3680 (handle_interrupt): Use it.
3681
2a8ce227
JB
36822012-04-10 Juanma Barranquero <lekktu@gmail.com>
3683
3684 * w32.c (w32_delayed_load): Record the full path of the library
3685 being loaded (bug#10424).
3686
935396c0
GM
36872012-04-09 Glenn Morris <rgm@gnu.org>
3688
05920a43
GM
3689 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3690 not just in the obarray, before snarfing them. (Bug#11036)
3691
935396c0
GM
3692 * Makefile.in ($(leimdir)/leim-list.el):
3693 Pass EMACS rather than BUILT_EMACS.
3694
a18ecafa
TZ
36952012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3696
3697 * process.c (make_process):
3698 * process.h: Add integer `gnutls_handshakes_tried' member to
3699 process struct.
3700
6bbef4e5
JC
3701 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3702 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3703
3704 * gnutls.c (gnutls_log_function2i): Convenience log function.
3705 (emacs_gnutls_read): Use new log functions,
3706 `gnutls_handshakes_tried' process member, and
3707 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3708 attempts per process (connection).
3709
b4d3bc10
CY
37102012-04-09 Chong Yidong <cyd@gnu.org>
3711
3712 * eval.c (Fuser_variable_p, user_variable_p_eh)
3713 (lisp_indirect_variable): Functions deleted.
3714 (Fdefvar): Caller changed.
3715
3716 * callint.c (Finteractive, Fcall_interactively):
3717 * minibuf.c (Fread_variable): Callers changed.
3718
70f4d973
EZ
37192012-04-09 Eli Zaretskii <eliz@gnu.org>
3720
3721 * xdisp.c (set_cursor_from_row): If the display string appears in
3722 the buffer at position that is closer to point than the position
3723 after the display string, display the cursor on the first glyph of
3724 the display string. Fixes cursor display when a 'display' text
3725 property immediately follows invisible text. (Bug#11094)
3726
cb3c2e3e
PE
37272012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3728
3729 composite.c: use 'double' consistently
3730 * composite.c (get_composition_id): Use 'double' consistently
3731 instead of converting 'float' to 'double' and vice versa; this is
3732 easier to understand and avoids a GCC warning.
3733
fd06db5d
GM
37342012-04-09 Glenn Morris <rgm@gnu.org>
3735
50fe702a
GM
3736 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3737 preparation for dumping it with emacs. (Bug#4789)
3738 (leimdir): New variable.
3739 ($(leimdir)/leim-list.el): New rule.
3740 (emacs$(EXEEXT)): Depend on leim-list.el.
3741
fd06db5d
GM
3742 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3743 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3744 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3745
55c131ee
AS
37462012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3747
3748 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3749 proper alignment.
3750
9209588f
JB
37512012-04-07 Juanma Barranquero <lekktu@gmail.com>
3752
3753 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3754 Remove unused local variable.
3755
e3fb2efb
PE
37562012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3757
3758 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3759 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3760 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3761 objects, as mark_maybe_pointer will catch them otherwise.
3762 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3763 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3764
b5385551
PE
37652012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3766
3767 Fix typo that broke non-Windows builds.
3768 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3769
9078ead6
EZ
37702012-04-07 Eli Zaretskii <eliz@gnu.org>
3771
3772 Support building on MS-Windows with libxml2.
3773
3774 * makefile.w32-in (OBJ2): Add xml.$(O).
3775 (GLOBAL_SOURCES): Add xml.c.
3776 ($(BLD)/xml.$(O)): New dependency list.
3777
3778 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3779 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3780 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3781 [!WINDOWSNT]: New macros.
3782 (init_libxml2_functions, libxml2_loaded_p): New functions.
3783 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3784 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3785 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3786 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3787 linked in).
6bbef4e5
JC
3788 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3789 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3790 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3791
3792 * emacs.c: Don't include libxml/parser.h.
3793 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3794 xmlCleanupParser directly.
3795
3796 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3797
3811fdf3
EZ
37982012-04-07 Eli Zaretskii <eliz@gnu.org>
3799
3800 * indent.c (Fvertical_motion): If there is a display string at
3801 point, use it.vpos to compute how many lines to backtrack after
3802 move_it_to point. (Bug#11133)
3803
2f8e16b2
EZ
38042012-04-06 Eli Zaretskii <eliz@gnu.org>
3805
3806 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3807 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3808 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3809 macros related to unification of CJK characters. For the details,
3810 see the discussion following the message here:
3811 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3812
3d439cd1
CY
38132012-04-04 Chong Yidong <cyd@gnu.org>
3814
3815 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3816
8bc53d00
EZ
38172012-04-01 Eli Zaretskii <eliz@gnu.org>
3818
3819 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3820 instead of alloca. (Bug#11138)
3821
3b0512a3
AS
38222012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3823
3824 * w32menu.c (is_simple_dialog): Properly check lisp types.
3825 (Bug#11141)
3826
8427ddd2
EZ
38272012-03-31 Eli Zaretskii <eliz@gnu.org>
3828
979022ef
EZ
3829 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3830 position we get to after a call to move_it_to fails the
3831 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3832 only if we wind up in a string from display property. (Bug#11063)
3833
a6b1c7cc
EZ
3834 * window.c (Fdelete_other_windows_internal): Invalidate the row
3835 and column information about mouse highlight, so that redisplay
3836 restores it after reallocating the glyph matrices. (Bug#7464)
3837
8427ddd2
EZ
3838 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3839 string comes from a `display' text property, use the buffer
3840 position of that property as if we actually saw that position in
3841 the row's glyphs.
697ba24b
EZ
3842 (move_it_by_lines): Remove the assertion that
3843 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3844 violated when there's a before-string at the beginning of a line.
3845 (Bug#11063)
8427ddd2 3846
65a0a738
EZ
38472012-03-30 Eli Zaretskii <eliz@gnu.org>
3848
3849 * xdisp.c (append_space_for_newline): If the default face was
3850 remapped, use the remapped face for the appended newline.
3851 (extend_face_to_end_of_line): Use the remapped default face for
3852 extending the face to the end of the line.
3853 (display_line): Call extend_face_to_end_of_line when the default
3854 face was remapped. (Bug#11068)
3855
581355cc
EZ
38562012-03-29 Eli Zaretskii <eliz@gnu.org>
3857
3858 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3859
e8fc049f
SM
38602012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3861
3862 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3863
4fb9a543
GM
38642012-03-27 Glenn Morris <rgm@gnu.org>
3865
3866 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3867 Doc fixes.
3868
679910f1
KH
38692012-03-26 Kenichi Handa <handa@m17n.org>
3870
3871 * dispextern.h (struct glyph): Fix previous change. Change the
3872 bit length of glyphless.ch to 25 (Bug#11082).
3873
90d49b7f
CY
38742012-03-26 Chong Yidong <cyd@gnu.org>
3875
3876 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3877 (command_loop_1): Use it; inhibit selection update for
3878 handle-select-window too (Bug#8996).
3879
f514f6f0
FP
38802012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3881
e8fc049f 3882 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3883
bf43fa51
KH
38842012-03-25 Kenichi Handa <handa@m17n.org>
3885
3886 * dispextern.h (struct glyph): Change the bit length of
3887 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3888
8a0c01dd
EZ
38892012-03-24 Eli Zaretskii <eliz@gnu.org>
3890
3891 * s/ms-w32.h (tzname): Include time.h before redirecting to
3892 _tzname. Fixes the MSVC build. (Bug#9960)
3893
7d1c3a76
AS
38942012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3895
8ed79523
AS
3896 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3897 characters.
3898
7d1c3a76
AS
3899 * xterm.c (XTread_socket): Only modify handling_signal if
3900 !SYNC_INPUT. (Bug#11080)
3901
e99a9b8b
EZ
39022012-03-23 Eli Zaretskii <eliz@gnu.org>
3903
3904 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3905 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3906 when fetching a multibyte character consumes more bytes than
3907 CHAR_BYTES returns, due to unification of CJK characters in
3908 string_char. (Bug#11073)
3909
5063c0e1
TN
39102012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3911
3912 * process.c (wait_reading_process_output): Handle pty disconnect
3913 by refraining from sending oneself a SIGCHLD (bug#10933).
3914
9f851fbd
CY
39152012-03-22 Chong Yidong <cyd@gnu.org>
3916
3917 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3918
5063c0e1 3919 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3920 Mark string as coming from a prefix property.
3921 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3922 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3923
fb5b8aca
CY
39242012-03-21 Chong Yidong <cyd@gnu.org>
3925
3926 * xfaces.c (Vface_remapping_alist): Doc fix.
3927
62356a1b
EZ
39282012-03-20 Eli Zaretskii <eliz@gnu.org>
3929
3930 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3931 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3932 Doc fixes.
62356a1b 3933
025de85b
CY
39342012-03-20 Chong Yidong <cyd@gnu.org>
3935
3936 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3937 to reflect default non-nil value of redisplay-dont-pause.
3938
4827f94e
KH
39392012-03-19 Kenichi Handa <handa@m17n.org>
3940
3941 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3942 it fit in a valid range (Bug#11003).
3943
e50a24a2
EZ
39442012-03-18 Eli Zaretskii <eliz@gnu.org>
3945
3946 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3947 that is not from display property, accept the row as a "cursor
3948 row" if one of the string's character has a non-nil `cursor'
3949 property. Fixes cursor positioning when there are newlines in
3950 overlay strings, e.g. in icomplete.el. (Bug#11035)
3951
9af5ed87
PE
39522012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3953
3954 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3955
d1f55f16
CY
39562012-03-12 Chong Yidong <cyd@gnu.org>
3957
3958 * eval.c (inhibit_lisp_code): Rename from
3959 inhibit_window_configuration_change_hook; move from window.c.
3960
3961 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3962 * window.c (run_window_configuration_change_hook)
3963 (syms_of_window): Callers changed.
3964
66c5eebd
CY
39652012-03-11 Chong Yidong <cyd@gnu.org>
3966
413df973
CY
3967 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3968
66c5eebd
CY
3969 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3970
1de11f56
CY
39712012-03-10 Chong Yidong <cyd@gnu.org>
3972
3973 * frame.c (other_visible_frames): Don't assume the selected frame
3974 is visible (Bug#10955).
3975
cae07000
SM
39762012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3977
3978 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3979
89c94350
JD
39802012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3981
3982 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3983 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3984 zero (Bug#10954).
3985
999dd333
GM
39862012-03-03 Glenn Morris <rgm@gnu.org>
3987
01a6dcc8 3988 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3989
de0100f2
EZ
39902012-03-02 Eli Zaretskii <eliz@gnu.org>
3991
3992 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3993 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3994 (redisplay_window, next_element_from_string): Fix typos in
3995 comments.
3e441275
EZ
3996 (redisplay_window): Pass to move_it_vertically the margin in
3997 pixels, not in screen lines.
de0100f2 3998
96a72ee9
GM
39992012-03-02 Glenn Morris <rgm@gnu.org>
4000
4001 * buffer.c (buffer-list-update-hook): Doc fix.
4002
312508d7
EZ
40032012-02-29 Eli Zaretskii <eliz@gnu.org>
4004
4005 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4006 push_it before setting up the iterator for the first overlay
4007 string, even if we have an empty string loaded.
4008 (next_overlay_string): If there's an empty string on the iterator
4009 stack, pop the stack. (Bug#10903)
4010
27f3c637
PE
40112012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4012
4013 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4014 Suggested by Stefan Monnier in
4015 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4016 * alloc.c (widen_to_Lisp_Object): New static function.
4017 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4018 and widening them to Lisp_Objects. This would work even if
4019 USE_LSB_TAG is defined and wide integers are used, which might
4020 happen in a future version of Emacs.
4021
3c9dfce6
CY
40222012-02-25 Chong Yidong <cyd@gnu.org>
4023
fa74b241
CY
4024 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4025 Doc fix.
4026
3c9dfce6
CY
4027 * xselect.c (Fx_selection_exists_p): Doc fix.
4028 (x_clipboard_manager_save_all): Print an informative message
4029 before saving to clipboard manager.
4030
9486df08
CY
40312012-02-24 Chong Yidong <cyd@gnu.org>
4032
4033 * keyboard.c (process_special_events): Handle all X selection
4034 requests in kbd_buffer, not just the next one (Bug#8869).
4035
f01d3321
CY
40362012-02-23 Chong Yidong <cyd@gnu.org>
4037
4038 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4039 call when setting menu-bar-lines and tool-bar-lines parameters.
4040 (unwind_create_frame_1): New helper function.
4041
4042 * window.c (inhibit_window_configuration_change_hook): New var.
4043 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4044 (syms_of_window): Initialize it.
f01d3321 4045
86b847b6
CY
40462012-02-22 Chong Yidong <cyd@gnu.org>
4047
4048 * xterm.c (x_draw_image_relief): Add missing type check for
4049 Vtool_bar_button_margin (Bug#10743).
4050
a59225b1
CY
40512012-02-21 Chong Yidong <cyd@gnu.org>
4052
4053 * fileio.c (Vfile_name_handler_alist): Doc fix.
4054
4055 * buffer.c (Fget_file_buffer): Protect against invalid file
4056 handler return value.
4057
310f5bd4
PE
40582012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4059
cb3a28cc
PE
4060 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4061 when computing $valmask.
4062
310f5bd4
PE
4063 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4064 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4065 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4066 It's useless in that case, and it can cause problems on hosts
4067 that allocate halves of EMACS_INT values separately.
4068 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4069 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4070 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4071 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4072 it avoids undefined behavior on hosts where shifting right by more
4073 than the word width has undefined behavior.
4074
2375c96a
CY
40752012-02-19 Chong Yidong <cyd@gnu.org>
4076
4077 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4078 (Funhandled_file_name_directory, Ffile_name_as_directory)
4079 (Fdirectory_file_name, Fexpand_file_name)
4080 (Fsubstitute_in_file_name): Protect against invalid file handler
4081 return values (Bug#10845).
4082
3eb49e71
EZ
40832012-02-18 Eli Zaretskii <eliz@gnu.org>
4084
4085 * .gdbinit (pitx): Fix incorrect references to fields of the
4086 iterator stack.
4087
7b926f3f
CY
40882012-02-17 Chong Yidong <cyd@gnu.org>
4089
4090 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4091
11273115
PE
40922012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4093
4094 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4095 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4096
c3a70e2b
CY
40972012-02-15 Chong Yidong <cyd@gnu.org>
4098
4099 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4100 marked as special. Also, starting docstrings with * is obsolete.
4101
0ca43699
AS
41022012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4103
4104 * gnutls.c (emacs_gnutls_write): Fix last change.
4105
2e8f3c56
LI
41062012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4107
4108 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4109 send_process.
4110
af70074f
SM
41112012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4112
4113 * keymap.c (Fsingle_key_description): Handle char ranges.
4114
95986d52
CY
41152012-02-12 Chong Yidong <cyd@gnu.org>
4116
afd83bd1
CY
4117 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4118 as that creates a dangerous corner case.
4119
95986d52
CY
4120 * window.c (Fdelete_window_internal): Invalidate the mouse
4121 highlight (Bug#9904).
4122
bd7da63e
GM
41232012-02-12 Glenn Morris <rgm@gnu.org>
4124
4125 * xselect.c (Fx_own_selection_internal)
4126 (Fx_get_selection_internal, Fx_disown_selection_internal)
4127 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4128 * nsselect.m (Fx_own_selection_internal)
4129 (Fx_disown_selection_internal, Fx_selection_exists_p)
4130 (Fx_selection_owner_p, Fx_get_selection_internal):
4131 Sync docs and argument specs with the xselect.c versions.
4132
77abcbc2
LI
41332012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4134
4135 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4136
90b671e2
EZ
41372012-02-11 Eli Zaretskii <eliz@gnu.org>
4138
1c0ca0b7
EZ
4139 * w32select.c (Fx_selection_exists_p): Sync doc string and
4140 argument list with xselect.c. (Bug#10783)
4141
4142 * w16select.c (Fx_selection_exists_p): Sync doc string and
4143 argument list with xselect.c. (Bug#10783)
90b671e2 4144
49241268
GM
41452012-02-10 Glenn Morris <rgm@gnu.org>
4146
4147 * fns.c (Fsecure_hash): Doc fix.
4148
f998bbe7 41492012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4150
4151 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4152
0992bd9c
CY
41532012-02-07 Chong Yidong <cyd@gnu.org>
4154
4155 * buffer.c (Fbuffer_local_variables)
4156 (buffer_lisp_local_variables): Handle unbound vars correctly;
4157 don't let Qunbound leak into Lisp.
4158
af008560
GM
41592012-02-07 Glenn Morris <rgm@gnu.org>
4160
dd605cc4
GM
4161 * image.c (Fimagemagick_types): Doc fix.
4162
af008560
GM
4163 * image.c (imagemagick-render-type): Change it from a lisp object
4164 to an integer. Move the doc here from the lisp manual.
4165 Treat all values not equal to 0 the same.
4166
1449fa1d
CY
41672012-02-06 Chong Yidong <cyd@gnu.org>
4168
4169 * doc.c (store_function_docstring): Avoid applying docstring of
4170 alias to base function (Bug#2603).
4171
3723ec07
AS
41722012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4173
4174 * .gdbinit (pp1, pv1): Remove redundant defines.
4175 (pr): Use pp.
4176
79c1cc1e
CY
41772012-02-04 Chong Yidong <cyd@gnu.org>
4178
4179 * nsterm.m: Declare a global (Bug#10694).
4180
d7f29f8e
EZ
41812012-02-04 Eli Zaretskii <eliz@gnu.org>
4182
cae07000
SM
4183 * w32.c (get_emacs_configuration_options):
4184 Include --enable-checking, if specified, in the return value.
d7f29f8e 4185
3b95a6f9
MR
41862012-02-04 Martin Rudalics <rudalics@gmx.at>
4187
4188 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4189 after rounding frame sizes. (Bug#9723)
4190
d6fa96a6
EZ
41912012-02-04 Eli Zaretskii <eliz@gnu.org>
4192
4193 * keyboard.c (adjust_point_for_property): Don't position point
4194 before BEGV. (Bug#10696)
4195
df0b2940
PE
41962012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4197
4198 Handle overflow when computing char display width (Bug#9496).
4199 * character.c (char_width): Return EMACS_INT, not int.
4200 (char_width, c_string_width): Check for overflow when
4201 computing the width; this is possible now that individual
4202 characters can have unbounded width. Problem introduced
4203 by merge from Emacs 23 on 2012-01-19.
4204
6bee44d6
MA
42052012-02-02 Michael Albinus <michael.albinus@gmx.de>
4206
4207 * dbusbind.c (Fdbus_register_method): Mention the return value
4208 :ignore in the docstring.
4209
44f92739
GM
42102012-02-02 Glenn Morris <rgm@gnu.org>
4211
1b9f60cc
GM
4212 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4213
44f92739
GM
4214 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4215 Unconditionally set to t. (Bug#10673)
4216 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4217 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4218 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4219
c5d3843c
KH
42202012-02-02 Kenichi Handa <handa@m17n.org>
4221
4222 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4223 0, do not call append_composite_glyph.
4224
159462d4 42252012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4226
4227 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4228 NULL (Bug#6988).
4229 (x_produce_glyphs): If the component of a composition is a null
4230 string, set it->pixel_width to 1 to avoid zero-width glyph.
4231
78cef877
EZ
42322012-02-01 Eli Zaretskii <eliz@gnu.org>
4233
4234 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4235 first 2 arguments are identical. This makes inserting large
4236 output from a subprocess an order of magnitude faster on
4237 MS-Windows, where all sbrk'ed memory is always contiguous.
4238
97897668
GM
42392012-01-31 Glenn Morris <rgm@gnu.org>
4240
4241 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4242 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4243 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4244
31fd3586
GM
42452012-01-29 Glenn Morris <rgm@gnu.org>
4246
4247 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4248
0e24a8b2
CY
42492012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4250
4251 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4252
cc0adcb0
CY
42532012-01-28 Chong Yidong <cyd@gnu.org>
4254
4255 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4256
acc28cb9
CY
42572012-01-26 Chong Yidong <cyd@gnu.org>
4258
9c69cfb7
CY
4259 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4260
acc28cb9
CY
4261 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4262 repeat counts (Bug#10507).
4263
48da7392
GM
42642012-01-26 Glenn Morris <rgm@gnu.org>
4265
4266 * lread.c (syms_of_lread): Doc fix.
4267
14af5f7f
CY
42682012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4269
4270 * coding.c (encode_designation_at_bol): Change return value to
4271 EMACS_INT.
4272
0b21c100
CY
42732012-01-25 Chong Yidong <cyd@gnu.org>
4274
4275 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4276
3c2907f7
CY
42772012-01-21 Chong Yidong <cyd@gnu.org>
4278
4279 * floatfns.c (Fcopysign): Make the second argument non-optional,
4280 since nil is not allowed anyway.
4281
959ad23f
AS
42822012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4283
4284 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4285 (send_process): Likewise.
4286
34a02f46
MR
42872012-01-19 Martin Rudalics <rudalics@gmx.at>
4288
4289 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4290 (Vwindow_persistent_parameters): Do not use Qstate.
4291 Rewrite doc-strings.
34a02f46 4292
1259009a 42932012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4294
4295 * character.c (char_width): New function.
70d4fdf6
GM
4296 (Fchar_width, c_string_width, lisp_string_width):
4297 Use char_width (Bug#9496).
25ed9e61 4298
6a6ee00d
MR
42992012-01-16 Martin Rudalics <rudalics@gmx.at>
4300
4301 * window.c (Vwindow_persistent_parameters): New variable.
4302 (Fset_window_configuration, save_window_save): Handle persistent
4303 window parameters.
4304
c85efaf7
EZ
43052012-01-14 Eli Zaretskii <eliz@gnu.org>
4306
4307 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4308 thrashing the stack of the thread. (Bug#9087)
4309
5944709e
PE
43102012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4311
4312 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4313
e71f5d99
EZ
43142012-01-11 Eli Zaretskii <eliz@gnu.org>
4315
4316 * xdisp.c (rows_from_pos_range): Handle the case where the
4317 highlight ends on a newline. (Bug#10464)
4318 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4319 he end column for display of highlight that ends on a newline
4320 before a R2L line.
4321
ce316182
GM
43222012-01-11 Glenn Morris <rgm@gnu.org>
4323
4324 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4325 from load-path also when installation-directory is nil. (Bug#10208)
4326
5b43da69
GM
43272012-01-10 Glenn Morris <rgm@gnu.org>
4328
74cc8ff9
GM
4329 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4330
7d8d6e4e
GM
4331 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4332 Update template values to be closer to their typical values these days.
5b43da69 4333
a0db8d43
EZ
43342012-01-09 Eli Zaretskii <eliz@gnu.org>
4335
4336 * xdisp.c (rows_from_pos_range): Accept additional argument
4337 DISP_STRING, and accept any glyph in a row whose object is that
4338 string as eligible for mouse highlight. Fixes mouse highlight of
4339 display strings from overlays. (Bug#10464)
4340
9a0115ab 43412012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4342
b9110d6a 4343 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4344 * fileio.c (auto_saving_dir_umask): New static var.
4345 (Fmake_directory_internal): Use it.
4346 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4347 creating the directory. The old code temporarily assigns
4348 too-generous permissions to the directory.
4349 (do_auto_save_eh): Clear it.
b9110d6a 4350 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4351 that the var is always cleared.
4352
6c1bd3f3
EZ
43532012-01-07 Eli Zaretskii <eliz@gnu.org>
4354
4355 * search.c (scan_buffer): Pass character positions to
4356 know_region_cache, not byte positions. (Bug#6540)
4357
069d2b50
L
43582012-01-07 LynX <_LynX@bk.ru> (tiny change)
4359
4360 * w32.c (sys_rename): Report EXDEV when rename of a directory
4361 fails because the target is on another logical disk. (Bug#10284)
4362
75bf0d33
DB
43632012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4364
4365 * xterm.c (x_embed_request_focus): New function.
4366
4367 * xterm.h: Add prototype.
4368
4369 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4370
1c6e5a32
GM
43712012-01-05 Glenn Morris <rgm@gnu.org>
4372
4373 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4374
651e947e
EZ
43752012-01-01 Eli Zaretskii <eliz@gnu.org>
4376
4377 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4378 Load gnutls_transport_set_lowat only if GnuTLS version is below
4379 2.11.1.
4380 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4381 GnuTLS versions below 2.11.1.
4382
3778cdd8
AL
43832011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4384
4385 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4386 to the doc string advising against its use for altering the way
4387 windows are scrolled.
4388
0e5317f7
KH
43892011-12-28 Kenichi Handa <handa@m17n.org>
4390
4391 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4392 coding-system ASCII compatible only when it does not produce BOM
4393 on encoding (Bug#10383).
4394
93d5ca1f
JD
43952011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4396
4397 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4398 can scroll.
4399 (create_and_show_popup_menu): Always use menu_position_func for
4400 Gtk3 (Bug#10361).
4401
ca22b785
AS
44022011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4403
4404 * callint.c (Fcall_interactively): Don't truncate prompt string.
4405
d048e1e6
EZ
44062011-12-23 Eli Zaretskii <eliz@gnu.org>
4407
4408 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4409 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4410 resumed from there (after widening). (Bug#10360)
d048e1e6 4411
5ccaba1f
JD
44122011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4413
4414 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4415
204ee57f
JD
44162011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4417
b81d40f0
JB
4418 * nsterm.m (x_free_frame_resources):
4419 Release f->output_data.ns->miniimage.
204ee57f
JD
4420 (ns_index_color): Fix indentation. Do not retain
4421 color_table->colors[i].
4422
4423 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4424 before returning.
4425
4426 * nsfns.m (x_set_background_color): Assign return value from
4427 ns_index_color to face-background instead of NSColor*.
4428 (ns_implicitly_set_icon_type): Fix indentation.
4429 Change assignment in for loop to comparison.
4430
4431 * emacs.c (ns_pool): New variable.
4432 (main): Assign ns_pool.
4433 (Fkill_emacs): Call ns_release_autorelease_pool.
4434
4435 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4436 autorelease fdesc, release fdAttrs and tdict.
4437 (ns_get_covering_families): Release charset.
4438 (ns_findfonts): Release NSFontDescriptor created with new.
4439 (ns_uni_to_glyphs): Fix indentation.
4440 (setString): Release attrStr before assigning new value.
4441
c803b2b7
JD
44422011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4443
678f4426
JD
4444 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4445 and NS_IMPL_COCOA.
4446 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4447 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4448
cd394be1 44492011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4450
5fecd5fc
JD
4451 * nsterm.m (ns_term_init): Subscribe for notifications
4452 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4453 to method trackingNotification in EmacsMenu.
4454
4455 * nsmenu.m (trackingMenu): New variable.
3771cb17 4456 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4457 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4458 from Aquamacs (Bug#7030).
678f4426
JD
4459
44602011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4461
c803b2b7
JD
4462 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4463 (symbol_to_nsstring): Fix indentation.
4464 (ns_symbol_to_pb): New function.
cae07000
SM
4465 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4466 (Fns_rotate_cut_buffers_internal): Remove.
4467 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4468 Fns_store_cut_buffer_internal.
4469 (ns_get_foreign_selection, Fx_own_selection_internal)
4470 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4471 (Fns_get_selection_internal, Fns_store_selection_internal):
4472 Use ns_symbol_to_pb and check if return value is nil.
4473 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4474 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4475 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4476 renamed to Sns_store_selection_internal.
4477 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4478 and remove this function.
4479 (ns_handle_selection_clear): Remove, never used.
4480 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4481 here.
4482
e1b01a3a
KB
44832011-12-17 Ken Brown <kbrown@cornell.edu>
4484
4485 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4486 GID is unknown (Bug#10257).
4487
2adb6e85
PE
44882011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4489
4490 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4491 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4492 which caused a build failure on GNU/Linux IA-64. This problem was
4493 introduced by my 2011-10-07 patch.
4494
d1d7b339
JL
44952011-12-15 Juri Linkov <juri@jurta.org>
4496
4497 * image.c (imagemagick_error): New function. (Bug#10112)
4498 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4499 Use `imagemagick_error' where ImageMagick functions return
4500 `MagickFalse'.
4501 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4502 proper order.
4503
100d5755
KH
45042011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4505
4506 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4507 fill background (Bug#8992).
4508
454592a6
MR
45092011-12-13 Martin Rudalics <rudalics@gmx.at>
4510
4511 * window.c (Vwindow_combination_resize)
4512 (Vwindow_combination_limit): Use t instead of non-nil in
4513 doc-strings.
61d4b438
MR
4514 (Vrecenter_redisplay): Add first sentence of doc-string on
4515 separate line.
53524d93 4516 (Frecenter): Fix doc-string typo.
454592a6 4517
3633e3aa
KH
45182011-12-11 Kenichi Handa <handa@m17n.org>
4519
4520 * coding.c (Funencodable_char_position): Pay attention to the
4521 buffer text relocation (Bug#9389).
4522
7b9d523a 45232011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4524
7b9d523a
JD
4525 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4526 gtk_init (Bug#10100).
4527
b73189c6
EZ
45282011-12-10 Eli Zaretskii <eliz@gnu.org>
4529
4530 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4531 IT->string is nil. (Bug#10263)
4532
f7dfe5d6
JD
45332011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4534
83faebb4
JD
4535 * nsterm.h (x_free_frame_resources): Declare.
4536
f7dfe5d6
JD
4537 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4538 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4539
4540 * nsterm.h (ns_get_defaults_value): Declare.
4541
4542 * nsterm.m (ns_default): Call ns_get_defaults_value.
4543
7cd4e72c
EZ
45442011-12-09 Eli Zaretskii <eliz@gnu.org>
4545
4546 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4547 (Bug#10170)
4548
b34d7317
YM
45492011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4550
4551 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4552 that where the value of an _OBJC_* symbol points to is in the .bss
4553 section (Bug#10240).
4554
76470ad1
KH
45552011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4556
4557 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4558 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4559
745fff94
KH
45602011-12-08 Kenichi Handa <handa@m17n.org>
4561
4562 * ftfont.c (get_adstyle_property): Fix previous change
4563 (Bug#10233).
4564
6e44397c
JB
45652011-12-07 Juanma Barranquero <lekktu@gmail.com>
4566
4567 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4568 dirs from the default value of EMACSLOADPATH (bug#10208).
4569
7efa6272
GM
45702011-12-07 Glenn Morris <rgm@gnu.org>
4571
4572 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4573 installation and source directories as well. (Bug#10208)
4574
f6fc4d87
CY
45752011-12-06 Chong Yidong <cyd@gnu.org>
4576
4577 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4578
2bf26180
GM
45792011-12-06 Glenn Morris <rgm@gnu.org>
4580
4581 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4582 as an error, not just -1. (Bug#10217)
4583
3a6ad4f0
CY
45842011-12-05 Chong Yidong <cyd@gnu.org>
4585
4586 * keyboard.c (process_special_events): New function.
4587 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4588
75a3b399
PE
45892011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4590
4591 * coding.c (encode_designation_at_bol): Don't use uninitialized
4592 local variable (Bug#9318).
4593
c3c9e25e
KH
45942011-12-05 Kenichi Handa <handa@m17n.org>
4595
4596 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4597 return Qnil (Bug#8046, Bug#10193).
4598
5eb05ea3
KH
45992011-12-05 Kenichi Handa <handa@m17n.org>
4600
4601 * coding.c (encode_designation_at_bol): New args charbuf_end and
4602 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4603 (coding_set_source): Return how many bytes coding->source was
4604 relocated.
4605 (coding_set_destination): Return how many bytes
4606 coding->destination was relocated.
4607 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4608 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4609
46102011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4611
4612 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4613 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4614 macro (Bug#9318).
4615
46162011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4617
4618 The following changes are to fix Bug#9318.
4619
a79703f5 4620 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4621 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4622 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4623 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4624
7dbda6df
JB
46252011-12-05 Juanma Barranquero <lekktu@gmail.com>
4626
4627 * lisp.h (process_quit_flag): Fix external declaration.
4628
6d5eb5b0
SM
46292011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4630
4631 Don't macro-inline non-performance-critical code.
4632 * eval.c (process_quit_flag): New function.
4633 * lisp.h (QUIT): Use it.
4634
a0c3fad0
JD
46352011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4636
4637 * nsfns.m (get_geometry_from_preferences): New function.
4638 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4639
6c07aac2
AS
46402011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4641
4642 * emacs.c (Qkill_emacs): Define.
4643 (syms_of_emacs): Initialize it.
4644 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4645 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4646 (quit_throw_to_read_char): Add parameter `from_signal'.
4647 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4648 * lisp.h (QUIT): Call Fkill_emacs if requested.
4649
c052ead4
JD
46502011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4651
4652 * widget.c (update_wm_hints): Return if wmshell is null.
4653 (widget_update_wm_size_hints): New function.
4654
4655 * widget.h (widget_update_wm_size_hints): Declare.
4656
4657 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4658 widget_update_wm_size_hints (Bug#10104).
4659
9e49252b
EZ
46602011-12-03 Eli Zaretskii <eliz@gnu.org>
4661
4662 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4663 before a newline, prepare the bidi iterator for consuming the
4664 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4665 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4666
02b16839
JL
46672011-12-02 Juri Linkov <juri@jurta.org>
4668
4669 * search.c (Fword_search_regexp): New Lisp function created from
4670 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4671 (Fword_search_backward, Fword_search_forward)
4672 (Fword_search_backward_lax, Fword_search_forward_lax):
4673 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4674 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4675
0068070e
SM
46762011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4677
4678 * fileio.c (Finsert_file_contents): Move after-change-function call
4679 to before the "handled:" label, since all "goto handled" appear in
4680 cases where the *-change-functions have already been properly called
4681 (bug#10117).
4682
3360a3fc
AS
46832011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4684
4685 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4686 waiting for input. (Bug#10169)
4687
73d6c093
EZ
46882011-11-30 Eli Zaretskii <eliz@gnu.org>
4689
4690 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4691 verifies glyph row's hash code--we have just reallocated the
4692 glyphs, so their contents can be complete garbage. (Bug#10164)
4693
febe6bea
JB
46942011-11-30 Juanma Barranquero <lekktu@gmail.com>
4695
4696 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4697
801a4313
EZ
46982011-11-30 Eli Zaretskii <eliz@gnu.org>
4699
4700 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4701 attributes are tested _before_ calling verify_row_hash, to protect
4702 against GCC re-ordering of the tests. (Bug#10164)
4703
2b56b87e
JD
47042011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4705
4706 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4707
4708 * xterm.c (handle_one_xevent): Only set async_visible and friends
4709 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4710 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4711 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4712
dbf31225
PE
47132011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4714
4715 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4716 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4717 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4718 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4719 All uses changed to use GCPRO1 etc.
4720 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4721 Revert to old implementation (i.e., before 2011-03-11).
4722
1305621b
YM
47232011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4724
4725 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4726 of scroll runs so as to avoid assigning disabled bogus rows and
4727 unnecessary graphics copy operations.
4728
8c9afb46
EZ
47292011-11-27 Eli Zaretskii <eliz@gnu.org>
4730
4731 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4732 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4733 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4734 (malloc, free, realloc, calloc): Redirect to e_* only when
4735 compiling Emacs.
4736
4737 * lisp.h (GCTYPEBITS): Move before first use.
4738 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4739 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4740 this macro definition.
4741
4742 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4743 _MSC_VER.
4744
54e9e3bf
JD
47452011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4746
6d5eb5b0
SM
4747 * gtkutil.c (xg_create_frame_widgets):
4748 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4749 present with Gtk+ 2.0.
4750
83aca1cb
PE
47512011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4752
4753 * fileio.c (Finsert_file_contents): Undo previous change; see
4754 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4755
5b76caa4
PE
47562011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4757
4758 Rename locals to avoid shadowing.
4759 * fileio.c (Finsert_file_contents):
4760 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4761 * process.c (wait_reading_process_output):
4762 Rename inner 'proc' to 'p' to avoid shadowing.
4763 Indent for consistency with usual Emacs style.
4764
8c535114
EZ
47652011-11-25 Eli Zaretskii <eliz@gnu.org>
4766
4767 * xdisp.c (redisplay_window): If cursor row is not fully visible
4768 after recentering, and scroll-conservatively is set to a large
4769 number, scroll window by a few more lines to make the cursor fully
4770 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4771 (start_display): Don't move to the next line if the display should
4772 start at a newline that is part of a display vector or an overlay
4773 string. (Bug#10119)
8c535114 4774
fa4fdb5c
JL
47752011-11-24 Juri Linkov <juri@jurta.org>
4776
4777 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4778 after the `MagickPingImage' call. (Bug#10112)
4779
90ec88df
CY
47802011-11-23 Chong Yidong <cyd@gnu.org>
4781
4782 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4783
56e2e794
MR
47842011-11-23 Martin Rudalics <rudalics@gmx.at>
4785
4786 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4787 making another buffer current. (Bug#10114)
4788
b6e64c41
GM
47892011-11-23 Glenn Morris <rgm@gnu.org>
4790
4791 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4792
6b21de18
CY
47932011-11-23 Chong Yidong <cyd@gnu.org>
4794
4795 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4796 using it (Bug#5984).
4797
b12cd789
EZ
47982011-11-22 Eli Zaretskii <eliz@gnu.org>
4799
4800 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4801 and header-lines, as they don't have one computed for them.
4802 (Bug#10098)
4803
4804 * .gdbinit (prow): Make displayed values more self-explaining.
4805 Add row's hash code.
4806
261b6fd4
LMI
48072011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4808
4809 * process.c (wait_reading_process_output): Fix asynchrounous
4810 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4811 (wait_reading_process_output): Add comment and URL.
261b6fd4 4812
e7cfd277
JD
48132011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4814
4815 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4816
a9b9b7f5
CY
48172011-11-21 Chong Yidong <cyd@gnu.org>
4818
4819 * window.c (Fnext_window, Fprevious_window): Doc fix.
4820
b0d15b4f
SM
48212011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4822
4823 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4824
fe7a3057
JB
48252011-11-20 Juanma Barranquero <lekktu@gmail.com>
4826
4827 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4828
d2999b1a
MR
48292011-11-20 Martin Rudalics <rudalics@gmx.at>
4830
4831 * window.c (Fset_window_combination_limit): Rename argument
4832 STATUS to LIMIT.
4833 (Vwindow_combination_limit): Remove "status" from doc-string.
4834
d5ff9cd0
AS
48352011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4836
4837 * m/ibms390.h: Remove.
4838 * m/ibms390x.h: Don't include "ibms390.h".
4839
a5bb9bd3
SM
48402011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4841
4842 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4843 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4844
cd1181db
JB
48452011-11-20 Juanma Barranquero <lekktu@gmail.com>
4846
4847 * casetab.c (Fset_case_table):
4848 * charset.c (Fcharset_after): Fix typos.
4849
615a3b8d 48502011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4851
17e845af
PE
4852 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4853 Otherwise, valgrind does not work on some platforms.
4854 Problem reported by Andreas Schwab in
6a0bf43d
PE
4855 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4856 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4857 is set, removing the need for VIRT_ADDRESS_VARIES.
4858 (PURE_P): Use a more-efficient implementation that needs just one
4859 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4860 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4861 to 4 (xorl, subq, cmpq, setbe).
4862 * alloc.c (pure): Always extern now, since that's the
4863 VIRT_ADDR_VARIES behavior.
4864 (PURE_POINTER_P): Use a single comparison, not two, for
4865 consistency with the new puresize.h.
4866 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4867 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4868 Remove VIRT_ADDR_VARIES no longer needed.
4869
f8fe6f96
EZ
48702011-11-19 Eli Zaretskii <eliz@gnu.org>
4871
4872 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4873 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4874 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4875 behave as if the cursor position were at the window margin.
4876
4877 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4878 and the cursor position is out of bounds, behave as if the cursor
4879 position were at the window margin. (Bug#10075)
4880
df05a53c
CY
48812011-11-18 Chong Yidong <cyd@gnu.org>
4882
4883 * window.c (Fwindow_combination_limit): Make first argument
4884 non-optional, since it is meaningless for live windows like the
4885 selected window.
61ccba97 4886
2071918e
DA
48872011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4888
4889 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4890
b50a28de
SM
48912011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4892
4893 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4894 (graft_intervals_into_buffer): Simplify.
4895
015137db
EZ
48962011-11-18 Eli Zaretskii <eliz@gnu.org>
4897
4898 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4899 hash values of the two rows.
4900 (copy_row_except_pointers): Preserve the used[] arrays and the
4901 hash values of the two rows. (Bug#10035)
68c95424 4902 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4903
4904 * xdisp.c (row_hash): New function, body extracted from
4905 compute_line_metrics.
4906 (compute_line_metrics): Call row_hash, instead of computing the
4907 hash code inline.
4908
4909 * dispnew.c (verify_row_hash): Call row_hash for computing the
4910 hash code of a row, instead of duplicating code from xdisp.c.
4911
4912 * dispextern.h (row_hash): Add prototype.
4913
a2addb04
TH
49142011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4915
4916 * frame.c (delete_frame): Don't delete the terminal when the last
4917 X frame is closed if emacs is built with GTK toolkit.
4918
df85d315
JB
49192011-11-17 Juanma Barranquero <lekktu@gmail.com>
4920
4921 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4922
a0c2d0ae
MR
49232011-11-17 Martin Rudalics <rudalics@gmx.at>
4924
4925 * window.c (Vwindow_splits): Rename to
4926 Vwindow_combination_resize. Suggested by Juri Linkov.
4927 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4928 of Vwindow_splits.
4929
58179cce
JB
49302011-11-16 Juanma Barranquero <lekktu@gmail.com>
4931
7877f373
JB
4932 * nsfns.m (Fns_font_name):
4933 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4934
b6f67890
MR
49352011-11-16 Martin Rudalics <rudalics@gmx.at>
4936
4937 * window.h (window): Rename slot "nest" to "combination_limit".
4938 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4939 (Fset_window_nest): Rename to Fset_window_combination_limit.
4940 (Vwindow_nest): Rename to Vwindow_combination_limit.
4941 (recombine_windows, make_parent_window, make_window)
4942 (Fsplit_window_internal, saved_window)
4943 (Fset_window_configuration, save_window_save): Rename all
4944 occurrences of window_nest to window_combination_limit.
4945
c7015153
JB
49462011-11-15 Juanma Barranquero <lekktu@gmail.com>
4947
4948 * image.c (imagemagick_load_image): Fix typo.
4949
322ad6ec
EZ
49502011-11-14 Eli Zaretskii <eliz@gnu.org>
4951
4952 * xdisp.c (display_line): Move the call to
4953 highlight_trailing_whitespace before the call to
4954 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4955 faces of all the glyphs to compute ROW's hash value.
4956 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4957
f067b8ec
JB
49582011-11-14 Juanma Barranquero <lekktu@gmail.com>
4959
4960 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4961 just return (bug#10044).
4962
1e5b2111
EZ
49632011-11-12 Eli Zaretskii <eliz@gnu.org>
4964
7ef3cbd5
EZ
4965 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4966 with user-defined heap size. Bump the default size of the temacs
4967 heap to 27MB, to avoid memory warning when running temacs.
4968 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4969
1e5b2111
EZ
4970 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4971 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4972 (verify_row_hash) [XASSERTS]: New function.
4973 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4974 that the hash value of glyph rows is correct.
1e5b2111 4975
89d61221
MR
49762011-11-12 Martin Rudalics <rudalics@gmx.at>
4977
4978 * window.h (window): Remove splits slot.
4979 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4980 (Fdelete_other_windows_internal, make_parent_window)
4981 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4982 (Fset_window_configuration, save_window_save): Don't deal with
4983 split status of windows.
4984 (saved_window): Remove splits slot.
4985 (Vwindow_splits): Rewrite doc-string.
4986
97f18cc8
JD
49872011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4988
4989 * xfns.c (unwind_create_frame):
4990 * nsfns.m (unwind_create_frame):
4991 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4992 Vframe_list (Bug#9999).
4993
22a648b4
DA
49942011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4995
0b381c7e 4996 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4997
659afede
KH
49982011-11-11 Kenichi Handa <handa@m17n.org>
4999
5000 * callproc.c (Fcall_process): Set the member dst_multibyte of
5001 process_coding.
5002
9ac0394b
KH
50032011-11-11 Johan Bockgård <bojohan@gnu.org>
5004
5005 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5006 avoid a crash (bug#9496).
5007
2fbdc249
CY
50082011-11-09 Chong Yidong <cyd@gnu.org>
5009
5010 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5011 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5012
ac6b1f81
PE
50132011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5014
5015 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5016
09db192c
PE
50172011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5018
5019 Avoid some portability problems by eschewing 'extern inline' functions.
5020 The trivial performance wins aren't worth the portability hassles; see
5021 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5022 et seq.
5023 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5024 (window_box_width, window_box_left, window_box_left_offset)
5025 (window_box_right, window_box_right_offset): Undo previous change,
5026 by removing the "extern"s.
5027 * intervals.c (adjust_intervals_for_insertion)
5028 (adjust_intervals_for_deletion): Undo previous change,
5029 making these static again.
5030 (offset_intervals, temp_set_point_both, temp_set_point)
5031 (copy_intervals_to_string): No longer inline.
5032 * xdisp.c (window_text_bottom_y, window_box_width)
5033 (window_box_height, window_box_left_offset)
5034 (window_box_right_offset, window_box_left, window_box_right)
5035 (window_box): No longer inline.
5036
105216ed
CY
50372011-11-08 Chong Yidong <cyd@gnu.org>
5038
5039 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5040 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5041 Signal an error if not a live window.
105216ed
CY
5042 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5043 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5044
ae9e237f
JB
50452011-11-07 Juanma Barranquero <lekktu@gmail.com>
5046
5047 * lisp.h (syms_of_abbrev): Remove declaration.
5048 Reported by CHENG Gao <chenggao@royau.me>.
5049
c7aa8333
EZ
50502011-11-07 Eli Zaretskii <eliz@gnu.org>
5051
5052 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5053 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5054 of temacs in GUI mode.
5055
be7f5545
MR
50562011-11-07 Martin Rudalics <rudalics@gmx.at>
5057
5058 * window.h: Declare delete_all_child_windows instead of
5059 delete_all_subwindows.
5060 * window.c (Fwindow_nest, Fset_window_nest)
5061 (Fset_window_new_total, Fset_window_new_normal)
5062 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5063 (delete_all_subwindows): Rename to delete_all_child_windows.
5064 (Fdelete_other_windows_internal, Fset_window_configuration):
5065 Call delete_all_child_windows instead of delete_all_subwindows.
5066 * frame.c (delete_frame): Call delete_all_child_windows instead
5067 of delete_all_subwindows.
5068
ca78dc43
PE
50692011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5070
5071 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5072 This is also needed for porting to any host where GC_MARK_STACK is
5073 not GC_MAKE_GCPROS_NOOPS.
5074 (which_symbols): Use it.
5075
a0241d01
KH
50762011-11-07 Kenichi Handa <handa@m17n.org>
5077
5078 * coding.c (coding_set_destination): Check coding->src_pos only
5079 when coding->src_object is a buffer (bug#9910).
5080
5081 * process.c (send_process): Set the member src_multibyte of coding
5082 to 0 (bug#9911) when sending a unibyte text.
5083
5084 * callproc.c (Fcall_process): Set the member src_multibyte of
5085 process_coding to 0 (bug#9912).
5086
a64bfdfa 50872011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5088
5089 * xmenu.c (cleanup_widget_value_tree): New function.
5090 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5091 calling free_menubar_widget_value_tree directly (Bug#9830).
5092
cb41b32a
PE
50932011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5094
5095 Fix some portability problems with 'inline'.
5096 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5097 (window_box_width, window_box_left, window_box_left_offset)
5098 (window_box_right, window_box_right_offset): Declare extern.
5099 Otherwise, these inline functions do not conform to C99 and
5100 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5101 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5102 * intervals.c (adjust_intervals_for_insertion)
5103 (adjust_intervals_for_deletion): Now extern, because otherwise the
5104 extern inline functions 'offset_intervals' couldn't refer to it.
5105 (static_offset_intervals): Remove.
5106 (offset_intervals): Rewrite using the old contents of
5107 static_offset_intervals. The old version didn't conform to C99
5108 because an extern inline function contained a reference to an
5109 identifier with static linkage.
5110
b7041366
AS
51112011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5112
5113 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5114 GC.
5115
88a37c4d
EZ
51162011-11-06 Eli Zaretskii <eliz@gnu.org>
5117
5118 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5119 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5120 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5121 return Qleft_to_right.
5122
49745b39
CY
51232011-11-06 Chong Yidong <cyd@gnu.org>
5124
5125 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5126 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5127 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5128 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5129 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5130 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5131 (Fwindow_vscroll): Doc fix.
5132 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5133 argument, since it makes no sense to pass a live window and for
5134 consistency with window-child.
5135
1f05cd82
CS
51362011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5137
5138 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5139 support MSVC.
5140
22610910
JR
51412011-11-05 Jason Rumney <jasonr@gnu.org>
5142
5143 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5144 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5145 fonts (Bug#6029).
5146 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5147 bitwise arithmetic preventing use of unicode-sip and non-truetype
5148 opentype fonts.
5149
a06776b2
EZ
51502011-11-05 Eli Zaretskii <eliz@gnu.org>
5151
3ad924ba
EZ
5152 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5153 "emacs"-only part.
5154
a06776b2
EZ
5155 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5156 initialization code to keep similarity to xfns.c after changes
5157 from 2011-11-05.
5158
c9e7db78
JD
51592011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5160
a97f8f3f
JD
5161 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5162 (unwind_create_frame): New function (Bug#9943).
5163 (Fx_create_frame): Restructure code to be more similar to the one in
5164 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5165 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5166 Move terminal->reference_count++ just before making the frame official
5167 (Bug#9943).
5168
5169 * nsterm.m (x_free_frame_resources): New function.
5170 (x_destroy_window): Move code to x_free_frame_resources.
5171
c9e7db78 5172 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5173 (Fx_create_frame, x_create_tip_frame):
5174 Move terminal->reference_count++ just before making the frame
75f1671a 5175 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5176 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5177
a6fc3b5c
EZ
51782011-11-05 Eli Zaretskii <eliz@gnu.org>
5179
5180 Support MSVC build with newer versions of Visual Studio.
5181 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5182 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5183 nt/gmake.defs.
5184
5185 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5186 which are not supported by MSVC.
5187 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5188 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5189 bitfields.
5190 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5191 types in bitfields.
5192 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5193
5194 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5195
58179cce 51962011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5197
5198 Support MSVC build with newer versions of Visual Studio.
5199 * w32.c: Don't include w32api.h for MSVC.
5200 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5201
5202 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5203 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5204 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5205 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5206 e_* cousins.
5207 (alloca) [_MSC_VER]: Define to _alloca.
5208
5209 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5210
5211 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5212
a58c13ed
EZ
52132011-11-04 Eli Zaretskii <eliz@gnu.org>
5214
5215 * xdisp.c (note_mouse_highlight): If either of
5216 previous/next-single-property-change returns nil, treat that as
5217 the beginning or the end of the buffer. (Bug#9955)
5218
fe0b6370
JD
52192011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5220
a58c13ed 5221 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5222 label is not null (Bug#9951).
5223 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5224 may be NULL.
5225
89bd5ee1
EZ
52262011-11-04 Eli Zaretskii <eliz@gnu.org>
5227
5228 * window.c (Fwindow_body_size): Mention in the doc string that the
5229 return value is in frame's canonical units. (Bug#9949)
5230
84c3edb9
EZ
52312011-11-03 Eli Zaretskii <eliz@gnu.org>
5232
4e2fb5c7
EZ
5233 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5234
84c3edb9 5235 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5236 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5237 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5238
bc17a887
EZ
52392011-11-01 Eli Zaretskii <eliz@gnu.org>
5240
5241 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5242 Don't stop backward scan on the continuation glyph, even though
5243 its CHARPOS is positive.
6d5eb5b0
SM
5244 (mouse_face_from_buffer_pos, note_mouse_highlight):
5245 Rename cover_string to disp_string.
bc17a887 5246
4ee88440
MR
52472011-11-01 Martin Rudalics <rudalics@gmx.at>
5248
5249 * window.c (temp_output_buffer_show): Don't use
5250 Vtemp_buffer_show_specifiers.
5251 (Vtemp_buffer_show_specifiers): Remove unused variable.
5252
c2ff3c02
EZ
52532011-10-30 Eli Zaretskii <eliz@gnu.org>
5254
5255 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5256 past the beginning of the current glyph matrix.
5257
58179cce 52582011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5259
5260 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5261 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5262 HAVE_GTK3 (Bug#9869).
b77a6a7f 5263
3b574623
JD
5264 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5265 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5266
b77a6a7f
JD
5267 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5268
5269 * xterm.c: Declare x_handle_net_wm_state to return int.
5270 (handle_one_xevent): Check if we are iconified but don't have
5271 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5272 (get_current_wm_state): Return non-zero if not hidden,
5273 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5274 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5275 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5276 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5277
196e41e4
PE
52782011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5279
5280 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5281 so that this new function doesn't get optimized away by a
5282 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5283
021f2e1a
AS
52842011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5285
5286 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5287
8b058d44
EZ
52882011-10-29 Eli Zaretskii <eliz@gnu.org>
5289
5290 Fix the `xbytecode' command.
5291 * .gdbinit (xprintbytestr): New command.
b50a28de 5292 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5293 (xbytecode): Print the byte-code string as well.
5294
4452fb80
EZ
52952011-10-29 Kim Storm <storm@cua.dk>
5296
8b058d44
EZ
5297 * alloc.c (which_symbols): New function.
5298
21b72067
AS
52992011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5300
5301 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5302 line. (Bug#9903)
5303
83ed7b5c
GM
53042011-10-29 Glenn Morris <rgm@gnu.org>
5305
5306 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5307 Not clear what it was for, and it causes various bugs. (Bug#9839)
5308
5a7a728b
EZ
53092011-10-28 Eli Zaretskii <eliz@gnu.org>
5310
5311 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5312 possible random value that matches one of those tested as
5313 condition to clear the mouse face.
5314
d3d0842f
CY
53152011-10-28 Chong Yidong <cyd@gnu.org>
5316
5317 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5318
31b39d13
DN
53192011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5320
5321 * window.c (make_window): Initialize phys_cursor_on_p.
5322
9aba6043
SM
53232011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5324
5325 * lisp.h (struct Lisp_Symbol): Update comments.
5326
c20992f4
JB
53272011-10-28 Juanma Barranquero <lekktu@gmail.com>
5328
5329 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5330
db4f02f2
EZ
53312011-10-28 Eli Zaretskii <eliz@gnu.org>
5332
5333 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5334 <oslsachem@gmail.com> for helping to debug this.
5335
5336 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5337 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5338 (g_b_init_get_glyph_outline_w): New static variables.
5339 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5340 (GetGlyphOutlineW_Proc): New typedefs.
5341 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5342 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5343 New functions.
5344 (w32font_open_internal, compute_metrics):
5345 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5346 instead of calling the "wide" APIs directly.
5347
5348 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5349
5350 * w32.h (syms_of_w32font): Add prototype.
5351
87e68db4
JB
53522011-10-27 Juanma Barranquero <lekktu@gmail.com>
5353
5354 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5355 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5356 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5357 (Fmove_to_window_line): Doc fix.
5358
435c1d67
CY
53592011-10-27 Chong Yidong <cyd@gnu.org>
5360
5361 * process.c (make_process): Set gnutls_state to NULL.
5362
5363 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5364 non-NULL, regardless of GNUTLS_INITSTAGE.
5365 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5366 an error. Set process slots as soon as we allocate them.
5367
5368 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5369
9c6c6f49
CY
53702011-10-27 Chong Yidong <cyd@gnu.org>
5371
9aba6043
SM
5372 * gnutls.c (emacs_gnutls_deinit): New function.
5373 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5374 (Fgnutls_deinit, Fgnutls_boot): Use it.
5375
5376 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5377 (deactivate_process): Call emacs_gnutls_deinit.
5378
657d08d3
JB
53792011-10-27 Juanma Barranquero <lekktu@gmail.com>
5380
5381 * image.c (x_create_x_image_and_pixmap):
5382 * w32.c (sys_rename, w32_delayed_load):
5383 * w32font.c (fill_in_logfont):
5384 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5385
5430d399
JB
53862011-10-26 Juanma Barranquero <lekktu@gmail.com>
5387
5388 * w32fns.c (w32_default_color_map): New function,
5389 extracted from Fw32_default_color_map.
a7ef684b 5390 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5391
fe0055fa
PE
53922011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5393
5394 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5395
e6346438
SM
53962011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5397
5398 * keyboard.c (test_undefined): New function (bug#9751).
5399 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5400
e112cc37
ET
54012011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5402
5403 * sysdep.c (init_sys_modes): Fix the check for the controlling
5404 terminal (Bug#6649).
5405
7b5d6677
EZ
54062011-10-20 Eli Zaretskii <eliz@gnu.org>
5407
5408 * dispextern.h (struct bidi_it): New member next_en_type.
5409
5410 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5411 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5412 current character, check also for next_en_type being WEAK_EN.
5413 (bidi_resolve_weak): Don't enter the expensive loop if the current
5414 position is before next_en_pos. Record the bidi type of the first
5415 non-ET, non-BN character we find, in addition to its position.
5416 (bidi_level_of_next_char): Invalidate next_en_type when
5417 next_en_pos is over-stepped.
5418
7da0b018
PE
54192011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5420
5421 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5422 * editfns.c: Rewrite current-time-zone so that it invokes
5423 the equivalent of (format-time-string "%Z") to get the time zone name.
5424 This fixes a bug when the time zone name contains characters that
5425 need converting from the system time locale to Emacs internal format.
5426 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5427 that patch fixed format-time-string to do the conversion, but
5428 I forgot to fix current-time-zone.
5429 (format_time_string): New function, containing most of
5430 what Fformat_time_string used to contain.
5431 (Fformat_time_string): Rewrite in terms of format_time_string.
5432 This doesn't change this function's behavior.
5433 (current-time-zone): Rewrite to use format_time_string.
5434 This fixes the bug reported by Michael Schierl in
5435 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5436 Jason Rumney's 2007-06-07 change worked around this bug, but
5437 didn't fix it.
5438 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5439
8547b010
EZ
54402011-10-19 Eli Zaretskii <eliz@gnu.org>
5441
5442 * xdisp.c (start_display): If the character at POS is displayed
5443 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5444 (try_window_reusing_current_matrix): If a line ends in a display
5445 vector or the next line starts in a display vector, continue
5446 redrawing the window even though the character position of
5447 start_row was reached.
8547b010
EZ
5448 (Bug#9771, part 2)
5449
4e948d15
CY
54502011-10-18 Chong Yidong <cyd@gnu.org>
5451
5452 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5453 with nobreak-char-display too.
5454
4787455f
EZ
54552011-10-18 Eli Zaretskii <eliz@gnu.org>
5456
5457 Fix part 3 of bug#9771.
5458 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5459 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5460 non-neutral characters if the current character is a paragraph
5461 separator (a.k.a. Newline). This avoids running the same
5462 expensive loop twice, once when we consume the preceding newline
5463 and the other time when the line actually needs to be displayed.
5464 Avoid the loop when we see neutrals on the base embedding level
5465 following a character whose directionality is the same as the
5466 paragraph's. This avoids running the expensive loop when a line
5467 ends in a long sequence of neutrals, like control characters.
5468 Add assertion against STRONG_AL type. Slightly rearrange code
5469 that determines the type of a neutral given the first non-neutral
5470 that follows it.
5471 (bidi_level_of_next_char): Set next_en_pos to zero when
5472 invalidating its info.
5473
2c91f553
EZ
54742011-10-17 Eli Zaretskii <eliz@gnu.org>
5475
5476 * xdisp.c (push_display_prop): Determine whether to record string
5477 or buffer position by IT->string, not by IT->method. Allow
5478 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5479 (move_it_vertically_backward): Don't look for character position
5480 immediately after the newline when in a continuation line.
5481 (Bug#9771, part 1)
2c91f553 5482
c7b08b0d
MR
54832011-10-15 Martin Rudalics <rudalics@gmx.at>
5484
5485 * window.c (coordinates_in_window): Rewrite and delabelize
5486 vertical border check. (Bug#5357) (Bug#9618)
5487
6b02f655
SM
54882011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5489
5490 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5491 errors in XSetWindowBorder (bug#9310).
5492
81d40c92
DA
54932011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5494
5495 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5496 avoid crash when xmalloc overrun checking is enabled.
5497
d4172c3b
EZ
54982011-10-13 Eli Zaretskii <eliz@gnu.org>
5499
5500 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5501 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5502 cursor motion with <left> and <right> arrow keys.
5503
5504 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5505 some callers set that themselves.
5506
b00eea75
EZ
55072011-10-12 Eli Zaretskii <eliz@gnu.org>
5508
5509 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5510 display string and the previous row comes from the same string and
5511 is empty. (Bug#9739) (Bug#9738)
5512
8fe012c4
SM
55132011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5514
5515 * doc.c (get_doc_string): Encode file name (bug#9735).
5516
0074aef2
EZ
55172011-10-12 Eli Zaretskii <eliz@gnu.org>
5518
79beb178
EZ
5519 * bidi.c (bidi_level_of_next_char):
5520 * xdisp.c (get_visually_first_element): Remove old incorrect
5521 comments regarding the Unicode Line Separator character.
5522
0074aef2
EZ
5523 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5524
6e4b3fbe
DA
55252011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5526
5527 * alloc.c (Fgc_status): Do not access beyond zombies array
5528 boundary if nzombies > MAX_ZOMBIES.
5529 * alloc.c (dump_zombies): Add missing format specifier.
5530
0324f3af
PE
55312011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5532
b5525cac
PE
5533 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5534 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5535
0324f3af
PE
5536 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5537 Some packages use them to denote characters with modifiers.
5538
e9b5f888
AS
55392011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5540
5541 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5542 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5543 matching a pp-number. Rename parameter var to var1.
5544
127827c0
SM
55452011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5546
5547 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5548
c8fd3bd0
GM
55492011-10-08 Glenn Morris <rgm@gnu.org>
5550
5551 * callint.c (Fcall_interactively): Give a more explicit error for the
5552 'c' case with a non-character input. (Bug#8479)
5553
352ec8ff
EZ
55542011-10-08 Eli Zaretskii <eliz@gnu.org>
5555
03669ccb
EZ
5556 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5557 lines.
7061c986
EZ
5558 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5559 lines that are hscrolled on the left.
03669ccb 5560
352ec8ff
EZ
5561 * dispnew.c (buffer_posn_from_coords): Account for a possible
5562 presence of header-line. (Bug#4426)
5563
a66cfb1c
SM
55642011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5565
6b02f655
SM
5566 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5567 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5568
7c5ee88e
PE
55692011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5570
5571 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5572 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5573 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5574 this makes Emacs dump core during garbage collection on rare
5575 occasions. sizeof is obviously inferior to offsetof here, so
5576 stick with offsetof.
5577 (GC_POINTER_ALIGNMENT): New macro.
5578 (mark_memory): Omit 3rd (offset) arg; caller changed.
5579 Don't assume EMACS_INT alignment is the same as pointer alignment.
5580
df1bbe5b
SM
55812011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5582
5583 * keyboard.c (read_key_sequence_remapped): New var.
5584 (read_key_sequence): Compute remapping in the right buffer.
5585 (command_loop_1): Use read_key_sequence's remapping directly.
5586
51553db6
SM
55872011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5588
32c1fffd
SM
5589 * dired.c (file_name_completion): Don't expand file name.
5590 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5591 before checking file name handler.
5592
51553db6
SM
5593 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5594 they've been requested explicitly (bug#9591).
5595
b6bd1599 55962011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5597
5598 * keymap.c (Fsingle_key_description): Use make_specified_string
5599 instead of build_string to build string from push_key_description.
5600 (Bug#5193)
5601
f701dc2a
PE
56022011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5603
4222c55d
PE
5604 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5605 This fixes a Y2038 bug on 64-bit hosts.
5606 * buffer.c (reset_buffer):
5607 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5608 (Fclear_buffer_auto_save_failure):
5609 Use 0, not -1, to represent an unset failure time, since time_t
5610 might not be signed.
5611
f701dc2a
PE
5612 Remove dependency on glibc malloc internals.
5613 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5614 Move back here from lisp.h, but with their new implementations.
5615 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5616 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5617 * charset.c (charset_table_init): New static var.
5618 (syms_of_charset): Use it instead of xmalloc. This removes a
5619 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5620 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5621 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5622 Move back to alloc.c.
5623 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5624 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5625
9ceebf39
JD
56262011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5627
5628 * nsterm.m (windowDidResize): Call x_set_window_size only when
5629 ns_in_resize is true. Otherwise set pixelwidth/height and
5630 call change_frame_size (Bug#9628).
5631
cb993c58
PE
56322011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5633
3930c88b
PE
5634 Port --enable-checking=all to Fedora 14 x86-64.
5635 * charset.c (syms_of_charset): Also account for glibc malloc's
5636 internal overhead when calculating the initial malloc maximum.
5637
cb993c58
PE
5638 Port --enable-checking=all to Fedora 14 x86.
5639 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5640 Move to lisp.h.
5641 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5642 (overrun_check_realloc, overrun_check_free):
5643 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5644 That way, xmalloc returns a properly-aligned pointer even if
5645 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5646 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5647 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5648 into account when calculating the initial malloc maximum.
5649 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5650 Move here from alloc.c, so that charset.c can use it too.
5651 Properly align; the old code wasn't right for common 32-bit hosts
5652 when configured with --enable-checking=all.
5653 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5654 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5655
31bed486
EZ
56562011-09-29 Eli Zaretskii <eliz@gnu.org>
5657
04c70788 5658 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5659 use EDOM.
5660
fbcaa2f3
EZ
56612011-09-28 Eli Zaretskii <eliz@gnu.org>
5662
5663 * xdisp.c (compute_display_string_end): If there's no display
5664 string at CHARPOS, return -1.
5665
5666 * bidi.c (bidi_fetch_char): When compute_display_string_end
5667 returns a negative value, treat the character as a normal
5668 character not covered by a display string. (Bug#9624)
5669
a239d4e9
JB
56702011-09-28 Juanma Barranquero <lekktu@gmail.com>
5671
5672 * lread.c (Fread_from_string): Fix typo in docstring.
5673
88652fd5
EZ
56742011-09-27 Eli Zaretskii <eliz@gnu.org>
5675
5676 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5677 newline, reseat the iterator instead of bidi-iterating there one
5678 character at a time. (Bug#9610)
32c1fffd
SM
5679 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5680 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5681
ed497dd4
AS
56822011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5683
5684 * lread.c (readevalloop): Use correct code for NBSP.
5685 (read1): Likewise. (Bug#9608)
5686
b2bf61aa
MA
56872011-09-25 Michael Albinus <michael.albinus@gmx.de>
5688
5689 * dbusbind.c (Fdbus_register_signal): When service is not
5690 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5691
32bbb17c
GM
56922011-09-25 Glenn Morris <rgm@gnu.org>
5693
5694 * buffer.c (truncate-lines): Doc fix.
5695
94e0933e
CY
56962011-09-24 Chong Yidong <cyd@stupidchicken.com>
5697
5698 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5699 (Fset_window_next_buffers): Doc fix.
5700
cddde921
GM
57012011-09-24 Glenn Morris <rgm@gnu.org>
5702
5703 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5704
1260aef1
PE
57052011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5706
25b4bfa0
PE
5707 Fix minor problems found by static checking.
5708 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5709 * indent.c (Fvertical_motion): Fix == vs = typo.
5710
e3cbd34b
EZ
57112011-09-24 Eli Zaretskii <eliz@gnu.org>
5712
a66cfb1c
SM
5713 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5714 Default value is now t. Doc fix.
6bf7006f 5715
e3cbd34b 5716 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5717 logic when moving up, not only when moving down. Fix the
e3cbd34b 5718 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5719 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5720
5721 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5722 CHARPOS is covered by a display string which includes newlines.
5723 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5724 is covered by a display string with embedded newlines.
5725
a3de0cbd
MA
57262011-09-24 Michael Albinus <michael.albinus@gmx.de>
5727
5728 * dbusbind.c (Fdbus_register_signal): Add match rule to
5729 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5730 (Fdbus_register_method, Vdbus_registered_objects_table):
5731 Fix docstring.
a3de0cbd 5732
b260039d
JM
57332011-09-24 Jim Meyering <meyering@redhat.com>
5734
32c1fffd 5735 do not ignore write error for any output size
b260039d
JM
5736 The previous change was incomplete.
5737 While it makes emacs --batch detect the vast majority of stdout
5738 write failures, errors were still ignored whenever the output size is
5739 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5740 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5741 && echo FAIL: ignored write error
5742 FAIL: ignored write error
5743 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5744 && echo FAIL: ignored write error
5745 FAIL: ignored write error
5746 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5747
8eca8a7c
AS
57482011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5749
5750 * emacs.c (Fkill_emacs): In noninteractive mode exit
5751 non-successfully if a write error occurred on stdout. (Bug#9574)
5752
3341db62
EZ
57532011-09-21 Eli Zaretskii <eliz@gnu.org>
5754
5755 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5756 the xassert test.
5757
5758 * dispextern.h (struct it): Update the comment documenting what
5759 can it->OBJECT be.
5760
8c203dbf
EZ
57612011-09-20 Eli Zaretskii <eliz@gnu.org>
5762
5763 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5764 a display string, extend search for cursor position to end of row.
5765 (find_row_edges): If the row ends in a newline from a display
5766 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5767 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5768 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5769 non-empty line. Fixes confusing cursor motion with arrow keys at
5770 the beginning of a line that starts with whitespace.
8c203dbf 5771
a4824228
LMI
57722011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5773
5774 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5775 (bug#9493).
5776
33ed493b
CY
57772011-09-18 Chong Yidong <cyd@stupidchicken.com>
5778
5779 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5780 boolean (Bug#9154).
5781
56cd55c8
EZ
57822011-09-18 Eli Zaretskii <eliz@gnu.org>
5783
5784 * xdisp.c (display_line): Record maximum and minimum buffer
5785 positions even if no glyphs were produced (e.g., by a zero-width
5786 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5787 buffer positions that will be removed from the glyph row because
5788 they don't fit.
c02dcedf
EZ
5789 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5790 column is beyond frame width: don't subtract 1 "pixel" when
5791 computing width of the stretch.
3e62b7e0
EZ
5792 (reseat_at_next_visible_line_start): Undo the change made on
5793 2011-09-17 that saved paragraph information and restored it after
5794 the call to `reseat'. (Bug#9545)
56cd55c8 5795
5ed99d36 57962011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5797
5798 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5799 and turn window cursor on if cleared (Bug#9415).
5800
5ed99d36 58012011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5802
5803 * search.c (boyer_moore): Take unibyte characters from pattern
5804 literally. (Bug#9458)
5805
9bade7b2
EZ
58062011-09-18 Eli Zaretskii <eliz@gnu.org>
5807
5808 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5809
e5e9d610
PE
58102011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5811
87e4427a
PE
5812 Fix minor problem found by static checking.
5813 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5814 initialized, to pacify gcc -Wuninitialized.
5815
e5e9d610
PE
5816 * fileio.c: Report proper errno when syscall falls.
5817 (Finsert_file_contents): Save and restore errno,
5818 so that report_file_error outputs the correct diagnostic.
5819 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5820
a1674f0b
EZ
58212011-09-18 Eli Zaretskii <eliz@gnu.org>
5822
5823 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5824
fbfb6dd4
EZ
58252011-09-17 Eli Zaretskii <eliz@gnu.org>
5826
5827 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5828 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5829
bb187662
EZ
58302011-09-17 Eli Zaretskii <eliz@gnu.org>
5831
1137e8b8 5832 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5833 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5834
5835 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5836 (bidi_find_paragraph_start): Search back for paragraph beginning
5837 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5838 (bidi_move_to_visually_next): Only trigger paragraph-related
5839 computations when the last character is a newline or at EOB, not
5840 just any NEUTRAL_B. (Bug#9470)
5841
bb187662
EZ
5842 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5843 truncated lines if point is covered by a display string. (Bug#9524)
5844
2e621251
PE
58452011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5846
5847 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5848 (cons_to_x_long): New function.
5849 (lisp_data_to_selection_data): Use it. Correct the test for
5850 short-versus-long data; it was negated. Break out of vector
5851 loop, for efficiency, when a long datum is discovered.
5852
91a15bc6
SM
58532011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5854
5855 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5856
b41c3a35
EZ
58572011-09-16 Eli Zaretskii <eliz@gnu.org>
5858
5859 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5860 GCC PR/17406) by declaring this function with external scope.
5861
7812ba2d
PE
58622011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5863
5864 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5865 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5866
cf7edc2a
AS
58672011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5868
5869 * editfns.c (Fformat): Correctly handle text properties on "%%".
5870
bd01620e
EZ
58712011-09-15 Eli Zaretskii <eliz@gnu.org>
5872
5873 * xterm.c (x_draw_composite_glyph_string_foreground):
5874 * w32term.c (x_draw_composite_glyph_string_foreground):
5875 * term.c (encode_terminal_code):
5876 * composite.c (composition_update_it, get_composition_id):
5877 * xdisp.c (get_next_display_element)
5878 (fill_composite_glyph_string): Add comments about special meaning
5879 of TAB characters in a composition.
5880
a02719a3
PE
58812011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5882
5883 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5884 This occurs when processing a multibyte format.
5885 Problem reported by Wolfgang Jenker.
a02719a3 5886
72589a3c
JB
58872011-09-15 Johan Bockgård <bojohan@gnu.org>
5888
5889 * xdisp.c (try_cursor_movement): Only check for exact match if
5890 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5891
1c14176c
PE
58922011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5893
5894 Remove unused external symbols.
5895 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5896 * xdisp.c (calc_pixel_width_or_height): Now static.
5897 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5898 * indent.c (check_display_width):
5899 * w32term.c: Fix comment to match code.
5900 * xterm.c, xterm.h (x_catching_errors): Remove.
5901
d2eea5b5
PE
59022011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5903
5904 * xselect.c: Use signed conversions more consistently (Bug#9498).
5905 (selection_data_to_lisp_data): Assume incoming selection data are
5906 signed integers, not unsigned. This is to be consistent with
5907 outgoing selection data, which was modified to use signed integers
5908 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5909 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5910 expects long, not unsigned long.
5911
46888499
EZ
59122011-09-14 Eli Zaretskii <eliz@gnu.org>
5913
5914 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5915 computation of loop end. Reported by Johan Bockgård
5916 <bojohan@gnu.org>.
5917
ef8ef9fb
CY
59182011-09-13 Chong Yidong <cyd@stupidchicken.com>
5919
5920 * frame.c (Fother_visible_frames_p): Function deleted.
5921
fa819fed
EZ
59222011-09-12 Eli Zaretskii <eliz@gnu.org>
5923
5924 * indent.c (compute_motion): Process display vector front to back
5925 rather than the other way around. (Bug#2496)
5926
2ba8e008
SM
59272011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5928
5929 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5930
20f53c69
CY
59312011-09-11 Chong Yidong <cyd@stupidchicken.com>
5932
5933 * minibuf.c (Fread_from_minibuffer): Doc fix.
5934
d562d7a4
EZ
59352011-09-11 Eli Zaretskii <eliz@gnu.org>
5936
5937 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5938 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5939
1c4d7f3d
LMI
59402011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5941
5942 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5943 value for non-existent files.
5944
b885bf36
EZ
59452011-09-11 Eli Zaretskii <eliz@gnu.org>
5946
5947 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5948 set its "size" to -1. This will set the modtime_size field of
5949 the corresponding buffer to -1, which is what
5950 verify-visited-file-modtime expects for files that do not exist.
5951 (Bug#9139)
5952
6612f0bf
PE
59532011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5954
5955 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5956 here ...
5957 * lisp.h: ... from here. push_key_description is no longer
5958 defined in keyboard.c, so its declaration should not be in
5959 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5960 logically belongs with push_key_description.
5961
dfb3f755
PE
59622011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5963
5964 * buffer.h: Include <sys/types.h> instead of <time.h>.
5965 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5966 Problem reported by Herbert J. Skuhra.
5967
3134906c
LMI
59682011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5969
5970 * xml.c (parse_region): Make the parsing work for
5971 non-comment-starting XML files again (bug#9144).
5972
8d903f4e
AS
59732011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5974
5975 * image.c (gif_load): Fix calculation of bottom and right corner.
5976 (Bug#9468)
5977
80ad64f4
EZ
59782011-09-10 Eli Zaretskii <eliz@gnu.org>
5979
5980 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5981 redisplay in small windows.
5982
208a048d
EZ
59832011-09-09 Eli Zaretskii <eliz@gnu.org>
5984
5985 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5986
9b1c252e
MR
59872011-09-08 Martin Rudalics <rudalics@gmx.at>
5988
5989 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5990 Operate on live windows only.
5991
2949f33b
JB
59922011-09-08 Juanma Barranquero <lekktu@gmail.com>
5993
5994 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5995
e08dcafd
EZ
59962011-09-07 Eli Zaretskii <eliz@gnu.org>
5997
5998 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5999 only under bidi iteration.
6000
115b96bd
JD
60012011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6002
6003 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6004
c8199d0f
PE
60052011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6006
6007 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6008 Without this fix, the command to link temacs failed due to an
6009 undefined symbol __builtin_isnan. This is because
6010 /usr/include/iso/math_c99.h #defines isnan(x) to
6011 __builtin_isnan(x), but the bundled gcc, which identifies itself
6012 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6013 a __builtin_isnan.
6014 * floatfns.c (isnan): #undef, and then #define to a clone of
6015 what's in data.c.
6016 (Fisnan): Always define, since it's always available now.
6017 (syms_of_floatfns): Always define isnan at the Lisp level.
6018
e39b275c 60192011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6020
6021 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6022
b2db44d9 60232011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6024
f4af5137 6025 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6026 The previous code assumed that file offsets (off_t values) fit in
6027 EMACS_INT variables, which is not true on typical 32-bit hosts.
6028 The code messed up by falsely reporting buffer overflow in cases
6029 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6030 when "big" contains more than 2**29 bytes, even though this
6031 inserts just one byte and does not overflow the buffer.
6032 (Finsert_file_contents): Store file offsets as off_t
6033 values, not as EMACS_INT values. Check for overflow when
6034 converting between EMACS_INT and off_t. When checking for
6035 buffer overflow or for overlap, take the offsets into account.
6036 Don't use EMACS_INT for small values where int suffices.
6037 When checking for overlap, fix a typo: ZV was used where
6038 ZV_BYTE was intended.
6039 (Fwrite_region): Don't assume off_t fits into 'long'.
6040 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6041
ecfc0a49
MA
60422011-09-05 Michael Albinus <michael.albinus@gmx.de>
6043
6044 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6045
6511acf2 60462011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6047
0999621a 6048 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6049
6050 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6051 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6052 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6053 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6054 (modify_event_symbol): Do not assume that the length of
6055 name_alist_or_stem is safe to alloca and fits in int.
6056 (Fexecute_extended_command): Likewise for function name and binding.
6057 (Frecursion_depth): Wrap around reliably on integer overflow.
6058 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6059 since some callers pass EMACS_INT values.
6060 (Fsingle_key_description): Don't crash if symbol name contains more
6061 than MAX_ALLOCA bytes.
6062 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6063 (get_minibuffer): Arg is now EMACS_INT, not int.
6064 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6065 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6066 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6067
2be7d702
PE
6068 * dbusbind.c (signature_cat): New function.
6069 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6070 Do not overrun buffer; instead, report string overflow.
6071
9d1df220
PE
6072 * dispnew.c (add_window_display_history): Don't overrun buffer.
6073 Truncate instead; this is OK since it's just a log.
6074
33ef5c64
PE
6075 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6076 even if the time zone offset is outlandishly large.
6077 Don't mishandle offset == INT_MIN.
6078
66c6fdd5
PE
6079 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6080 when creating daemon; the previous buffer-overflow check was incorrect.
6081
d749b01b
PE
6082 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6083 which has the guts of the old verror function.
6084
b5cd1905
PE
6085 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6086 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6087
6e1a67fb
PE
6088 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6089 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6090 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6091 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6092 length of string rather than counting it via multiple sprintfs;
6093 that's simpler and more reliable.
c21721cc
PE
6094 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6095 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6096 sprintf, in case result does not fit in int.
6097
c57b67fc
PE
6098 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6099 (fontset_from_font): Print it.
6100
8a401434
PE
6101 * frame.c (tty_frame_count): Now printmax_t, not int.
6102 (make_terminal_frame, set_term_frame_name): Print it.
6103 (x_report_frame_params): In X, window IDs are unsigned long,
6104 not signed long, so print them as unsigned.
6105 (validate_x_resource_name): Check for implausibly long names,
6106 and don't assume name length fits in 'int'.
6107 (x_get_resource_string): Don't blindly alloca invocation name;
6108 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6109 not fit in int.
6110
6e1a67fb
PE
6111 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6112 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6113 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6114
0df02bf3
PE
6115 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6116 Use esprintf, not sprintf, in case result does not fit in int.
6117
48e30793
PE
6118 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6119 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6120 it as a large positive number.
6121 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6122 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6123
a66ff6d8
PE
6124 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6125 in case result does not fit in int.
6126
aca216ff
PE
6127 * print.c (float_to_string): Detect width overflow more reliably.
6128 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6129 buffer overrun. Don't assume list length fits in 'int'. Treat
6130 print length of 0 as 0, not as infinity; to be consistent with other
6131 uses of print length in this function. Don't overflow print length
6132 index. Don't assume hash table size fits in 'long', or that
6133 vectorlike size fits in 'unsigned long'.
6134
31c286f7
PE
6135 * process.c (make_process): Use printmax_t, not int, to format
6136 process-name gensyms.
6137
55e5faa1
PE
6138 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6139
80f2e268
PE
6140 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6141 to avoid potential buffer overrun.
6142
670741ab
PE
6143 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6144 if X resource line is longer than 512 bytes.
6145
b7163a50
PE
6146 * xfns.c (x_window): Make sprintf buffer a bit bigger
6147 to avoid potential buffer overrun.
6148
ae58ff1f
PE
6149 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6150
c43c8a6a
PE
6151 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6152
3f8236f4
PE
61532011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6154
53e9fe90 6155 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6156 Without these, Emacs silently mishandles large integers sometimes.
6157 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6158 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6159
6511acf2
PE
6160 * xdisp.c (try_window_id): Check Emacs fixnum range before
6161 converting to 'int'.
806add1d 6162
6511acf2 6163 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6164 Check that an Emacs fixnum is in range before assigning it to 'int'.
6165 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6166 values converted from Emacs fixnums.
6167 (Frecenter): Don't wrap around a line count if it is out of 'int'
6168 range; instead, treat it as an extreme value.
6169 (Fset_window_configuration, compare_window_configurations):
6170 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6171
6511acf2
PE
6172 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6173 that can exceed INT_MAX. Check that EMACS_INT value is in range
6174 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6175 (match_limit): Don't assume that a fixnum can fit in 'int'.
6176
6511acf2 6177 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6178 exceed INT_MAX.
6179
6511acf2 6180 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6181 (Fvertical_motion): Don't wrap around LINES values that don't fit
6182 in 'int'. Instead, treat them as extreme values. This is good
6183 enough for windows, which can't have more than INT_MAX lines anyway.
6184
fcb901a7
LMI
61852011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6186
0f2f6b6d
LMI
6187 * Require libxml/parser.h to avoid compilation warning.
6188
fcb901a7
LMI
6189 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6190
6191 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6192 since this reportedly can destroy thread storage.
6193
6e20a0d4
CY
61942011-08-30 Chong Yidong <cyd@stupidchicken.com>
6195
6196 * syntax.c (find_defun_start): Update all cache variables if
6197 exiting early (Bug#9401).
6198
148ae00e
EZ
61992011-08-30 Eli Zaretskii <eliz@gnu.org>
6200
f6cfbd8f
EZ
6201 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6202
148ae00e
EZ
6203 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6204 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6205 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6206
6207 * term.c (tty_append_glyph): New function.
6208 (produce_stretch_glyph): Static function and its prototype deleted.
6209
a66cfb1c
SM
6210 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6211 Add prototypes.
148ae00e 6212
c4a07a4c
PE
62132011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6214
6215 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6216 when checking :margin (Bug#9390).
6217 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6218 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6219 so that the name doesn't mislead. All uses changed.
6220
6bc8cd65
JB
62212011-08-28 Johan Bockgård <bojohan@gnu.org>
6222
6223 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6224 set_tty_hooks.
6225
dca4927e
EZ
62262011-08-27 Eli Zaretskii <eliz@gnu.org>
6227
6228 * xdisp.c (move_it_to): Don't bail out early when reaching
6229 position beyond to_charpos, if we are scanning backwards.
6230 (move_it_vertically_backward): When DY == 0, make sure we get to
6231 the first character in the line after the newline.
6232
f2cad773
PE
62332011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6234
6235 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6236 (ccl_driver): Do not generate an out-of-range pointer.
6237 (Fccl_execute_on_string): Remove unnecessary check for
6238 integer overflow, noted by Stefan Monnier in
6239 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6240 Remove a FIXME that didn't need fixing.
6241 Simplify the newly-introduced buffer reallocation code.
6242
0cae2cdb
JB
62432011-08-27 Juanma Barranquero <lekktu@gmail.com>
6244
6245 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6246
5fc295a4 62472011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6248
70c60eb2 6249 Integer and memory overflow issues (Bug#9196).
726e0ab1 6250
d31850da
PE
6251 * doc.c (get_doc_string): Rework so that
6252 get_doc_string_buffer_size is the actual buffer size, rather than
6253 being 1 less than the actual buffer size; this makes xpalloc more
6254 convenient.
6255
a69fbedb
PE
6256 * image.c (x_allocate_bitmap_record, cache_image):
6257 * xselect.c (Fx_register_dnd_atom):
6258 Simplify previous changes by using xpalloc.
6259
fe5c5d37
PE
6260 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6261 since either will do and ptrdiff_t is convenient with xpalloc.
6262
0065d054
PE
6263 * charset.c (charset_table_size)
6264 (struct charset_sort_data.priority): Now ptrdiff_t.
6265 (charset_compare): Don't overflow if priorities differ greatly.
6266 (Fsort_charsets): Don't assume list length fits in int.
6267 Check for size-calculation overflow when allocating sort data.
6268 (syms_of_charset): Allocate an initial charset table that is
6269 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6270
6271 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6272
6273 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6274 The actual value is always <= INT_MAX, and leaving it unsigned made
6275 overflow checking harder.
6276
6277 * dispextern.h (struct glyph_matrix.rows_allocated)
6278 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6279 with xpalloc. The values are still always <= INT_MAX.
6280
6281 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6282
6283 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6284 (SAFE_NALLOCA): New macro.
6285
6286 * region-cache.c (struct boundary.pos, find_cache_boundary)
6287 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6288 (set_cache_region, invalidate_region_cache)
6289 (revalidate_region_cache, know_region_cache, region_cache_forward)
6290 (region_cache_backward, pp_cache):
6291 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6292 so that ptrdiff_t * can be passed to xpalloc.
6293 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6294 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6295 (pp_cache): Don't assume cache_len fits in int.
6296 * region-cache.h: Adjust extern decls to match.
6297
6298 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6299 EMACS_INT, since either will do, for xpalloc.
6300
6301 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6302 (xnmalloc, xnrealloc, xpalloc): New functions.
6303
726e0ab1
PE
6304 * bidi.c (bidi_shelve_header_size): New constant.
6305 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6306 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6307
51f30bc5 6308 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6309 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6310 (overlay_strings):
6311 Don't update size of array until after memory allocation succeeds,
6312 because xmalloc/xrealloc may not return.
0065d054
PE
6313 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6314 now that we have proper integer overflow checking.
6315 (record_overlay_string, overlay_strings): Catch overflows when
6316 calculating size of overlay_str_buf.
726e0ab1 6317
0065d054
PE
6318 * callproc.c (Fcall_process): Check for size overflow when
6319 calculating size of args2.
6320 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6321 Normally we prefer signed values, but sticking with ptrdiff_t would
6322 require adding more-complicated checks.
726e0ab1
PE
6323
6324 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6325 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6326 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6327 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6328
6329 * character.c (Fstring): Check for size-calculation overflow.
6330
6331 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6332 unnecessary integer overflow. Check for size overflow.
6333 (encode_coding_object): Don't update size until xmalloc succeeds.
6334
6335 * composite.c (get_composition_id): Check for overflow in glyph
6336 length calculations.
6337
6338 Integer and memory overflow fixes for display code.
6339 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6340 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6341 (scrolling_window): Check for overflow in size calculations.
6342 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6343 Don't assume glyph table len fits in int.
6344 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6345 (row_table_size): Now ptrdiff_t, not int.
6346 (scrolling_window): Avoid overflow in size calculations.
6347 Don't update size until allocation succeeds.
6348 * fns.c (concat): Check for overflow in size calculations.
6349 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6350 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6351 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6352
6353 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6354 (get_doc_string): Check for size calculation overflow.
6355 Don't update size until allocation succeeds.
6356 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6357 EMACS_INT, where ptrdiff_t will do.
6358 (Fsubstitute_command_keys): Check for string overflow.
6359
6360 * editfns.c (set_time_zone_rule): Don't assume environment length
6361 fits in int.
6362 (message_length): Now ptrdiff_t, not int.
6363 (Fmessage_box): Don't update size until allocation succeeds.
6364 Don't assume message length fits in int.
6365 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6366
0065d054
PE
6367 * emacs.c (main): Do not reallocate argv, since there is a null at
6368 the end that can be overwritten, and this way there's no need to
6369 worry about size-calculation overflow.
6370 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6371
6372 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6373 alloc succeeds.
6374 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6375
6376 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6377 (x_set_scroll_bar_width, x_figure_window_size):
6378 Check for integer overflow.
6379 (x_set_alpha): Do not assume XINT fits in int.
6380
6381 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6382 This is for the members text_lines, text_cols, total_lines, total_cols,
6383 where the system imposes an 'int' limit.
6384
6385 * fringe.c (Fdefine_fringe_bitmap):
6386 Don't update size until alloc works.
6387
6388 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6389 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6390
6391 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6392 Check for size-calculation overflow.
6393 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6394 do, as we prefer signed integers.
6395 (id_to_widget.max_size, id_to_widget.used)
6396 (xg_store_widget_in_map, xg_remove_widget_from_map)
6397 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6398 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6399 Use and return ptrdiff_t, not int.
6400 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6401 * gtkutil.h: Change prototypes to match the above.
6402
6403 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6404 are duplicate now that they've been promoted to lisp.h.
6405 (x_allocate_bitmap_record, x_alloc_image_color)
6406 (make_image_cache, cache_image, xpm_load):
6407 Don't update size until alloc is done.
6408 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6409 (x_detect_edges):
3256efce 6410 Check for size calculation overflow.
726e0ab1
PE
6411 (ct_colors_allocated_max): New constant.
6412 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6413 overflow.
3256efce 6414
726e0ab1
PE
6415 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6416 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6417 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6418 Use ptrdiff_t, not int, to count maps.
6419 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6420 calculations. Don't update size until allocation succeeds.
6421 Redo calculations to avoid overflow.
726e0ab1
PE
6422 * keyboard.h: Change prototypes to match the above.
6423
6424 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6425 to count maps.
6426 (current_minor_maps): Check for size calculation overflow.
6427 * keymap.h: Change prototypes to match the above.
6428
6429 * lread.c (read1, init_obarray): Don't update size until alloc done.
6430
6431 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6432 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6433
726e0ab1
PE
6434 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6435 Now ptrdiff_t, not int.
6436 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6437 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6438
6439 * process.c (Fnetwork_interface_list): Check for overflow
6440 in size calculation.
6441
6442 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6443
6444 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6445 overflow. Don't bother calling xmalloc when xrealloc will do.
6446
6447 * search.c (Freplace_match): Check for size calculation overflow.
6448 (Fset_match_data): Don't assume list lengths fit in 'int'.
6449
6450 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6451 for command line length. Do not attempt to address one before the
6452 beginning of an array, as that's not portable.
6453
6454 * term.c (max_frame_lines): Remove; unused.
6455 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6456 not int.
6457 (encode_terminal_code, calculate_costs): Check for size
6458 calculation overflow.
6459 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6460 table lengths and related sizes. Don't update size until alloc
6461 done. Redo calculations to avoid overflow.
6462 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6463
6464 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6465 subtracting pointers.
6466 (gobble_line): Check for overflow more carefully. Don't update size
6467 until alloc done.
6468
6469 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6470 Don't update size until alloc done.
6471 Redo size calculations to avoid overflow.
6472 Check for size calculation overflow.
0065d054 6473 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6474
6475 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6476 Use ptrdiff_t, not int, for sizes.
6477 (store_mode_line_noprop_char): Don't update size until alloc done.
6478
0065d054
PE
6479 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6480 Use ptrdiff_t, not int, for sizes.
6481 (Finternal_make_lisp_face, cache_face):
6482 Check for size calculation overflow.
6483 (cache_face): Treat size calculation overflows as if they were
6484 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6485
6486 * xfns.c (x_encode_text, x_set_name_internal)
6487 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6488 sizes, since they can exceed INT_MAX in size. Check for size
6489 calculation overflow.
6490
0065d054
PE
6491 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6492 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6493 Don't update size until alloc done.
6494
0065d054 6495 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6496 as sprintf is limited to int lengths.
1d526e2f 6497
252c5ee1
PE
6498 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6499 (X_LONG_MIN): New macros.
864d7ce7
PE
6500 Use them to make the following changes clearer.
6501 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6502 This change doesn't affect the value now, but it may help remind
6503 future maintainers not to raise the value too much later.
6504 (SELECTION_QUANTUM): Remove, replacing with ...
6505 (selection_quantum): ... new function, which avoids overflow.
6506 All uses changed.
6507 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6508 assumption that selection length fits in 'int'.
6509 (x_reply_selection_request, x_handle_selection_request)
6510 (x_get_window_property, receive_incremental_selection)
6511 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6512 (lisp_data_to_selection_data, clean_local_selection_data):
6513 Use ptrdiff_t, not int, to record length of selection.
6514 (x_reply_selection_request, x_get_window_property)
6515 (receive_incremental_selection, x_property_data_to_lisp):
6516 Redo calculations to avoid overflow.
6517 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6518 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6519 something.
6520 (x_get_window_property, receive_incremental_selection)
6521 (lisp_data_to_selection_data, x_property_data_to_lisp):
6522 Check for size-calculation overflow.
6523 (x_get_window_property, receive_incremental_selection)
6524 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6525 Don't store size until memory allocation succeeds.
6526 (x_get_window_property): Plug memory leak on memory exhaustion.
6527 Don't double-block input; malloc is safe here. Don't assume 2**34
6528 - 4 fits in unsigned long. Add an xassert to check
6529 XGetWindowProperty overflow. Be more careful about overflow
6530 calculations, and distinguish size from memory overflow better.
6531 (receive_incremental_selection): When tracing, don't assume
6532 unsigned int is less than INT_MAX.
6533 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6534 harmful) conversions of unsigned short to int.
6535 (lisp_data_to_selection_data): Don't assume that integers
6536 in the range -65535 through -1 fit in an X unsigned short.
6537 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6538 result parameters unless successful. Rely on cons_to_unsigned
6539 to report problems with elements; the old code wasn't right anyway.
6540 (x_check_property_data): Check for int overflow; we cannot use
6541 a wider type due to X limits.
6542 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6543
726e0ab1 6544 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6545
0065d054
PE
6546 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6547 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6548 (x_color_cells): Don't store size until memory allocation succeeds.
6549 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6550 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6551 (x_term_init): Don't assume length fits in int (sprintf is limited
6552 to int size).
bc18e09d 6553
ebfa62c0
PE
6554 Use ptrdiff_t for composition IDs.
6555 * character.c (lisp_string_width):
6556 * composite.c (composition_table_size, n_compositions)
6557 (get_composition_id, composition_gstring_from_id):
6558 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6559 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6560 * window.c (Frecenter):
6561 Use ptrdiff_t, not int, for composition IDs.
6562 * composite.c (get_composition_id): Check for integer overflow.
6563 * composite.h: Adjust prototypes to match the above changes.
6564
d3411f89
PE
6565 Use ptrdiff_t for hash table indexes.
6566 * category.c (hash_get_category_set):
6567 * ccl.c (ccl_driver):
6568 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6569 * coding.c (coding_system_charset_list, detect_coding_system):
6570 * coding.h (struct coding_system.id):
6571 * composite.c (get_composition_id, gstring_lookup_cache):
6572 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6573 * image.c (xpm_get_color_table_h):
6574 * lisp.h (hash_lookup, hash_put):
6575 * minibuf.c (Ftest_completion):
6576 Use ptrdiff_t for hash table indexes, not int (which is too
6577 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6578 32-bit --with-wide-int hosts).
6579
e097a6fa
PE
6580 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6581 Add a FIXME comment about memory leaks.
6582 (syms_of_charset): Don't assume xmalloc returns.
6583
5637687f
PE
6584 Don't assume that stated character widths fit in int.
6585 * character.c (Fchar_width, c_string_width, lisp_string_width):
6586 * character.h (CHAR_WIDTH):
6587 * indent.c (MULTIBYTE_BYTES_WIDTH):
6588 Use sanitize_char_width to avoid undefined and/or bad behavior
6589 with outlandish widths.
a66cfb1c 6590 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6591 now that we have two such functions. All uses changed.
6592 (sanitize_char_width): New inline function.
6593
a2271ba2
PE
6594 Don't assume that tab-width fits in int.
6595 * character.h (sanitize_width): New inline function.
6596 (SANE_TAB_WIDTH): New macro.
6597 (ASCII_CHAR_WIDTH): Use it.
6598 * indent.c (sane_tab_width): Remove. All uses replaced by
6599 SANE_TAB_WIDTH (current_buffer).
6600 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6601
18c52557
PE
6602 * fileio.c: Integer overflow issues with file modes.
6603 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6604
caeeedc1
PE
6605 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6606 Remove unreachable code.
6607 (read_hex, load_charset_map_from_file): Check for integer overflow.
6608
6df6ae42 6609 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6610 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6611 (x_send_scroll_bar_event): Likewise. Check that the size does not
6612 exceed limits imposed by XClientMessageEvent, as well as the usual
6613 ptrdiff_t and size_t limits.
6614
b13995db
PE
6615 * keyboard.c: Overflow, signedness and related fixes.
6616 (make_lispy_movement): Use same integer type in forward decl
6617 that is used in the definition.
6618 (read_key_sequence, keyremap_step):
6619 Change bufsize argument back to int, undoing my 2011-03-30 change.
6620 We prefer signed types, and int is wide enough here.
6621 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6622 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6623 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6624 length, not size_t. Use ptrdiff_t for index, not int.
6625 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6626 possibility of integer overflow.
6627
13464394
PE
6628 Overflow, signedness and related fixes for images.
6629
6630 * dispextern.h (struct it.stack[0].u.image.image_id)
6631 (struct_it.image_id, struct image.id, struct image_cache.size)
6632 (struct image_cache.used, struct image_cache.ref_count):
6633 * gtkutil.c (update_frame_tool_bar):
6634 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6635 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6636 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6637 * nsmenu.m (update_frame_tool_bar):
6638 * xdisp.c (calc_pixel_width_or_height):
6639 * xfns.c (image_cache_refcount):
6640 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6641 on typical 64-bit hosts.
6642
6643 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6644 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6645 Omit unnecessary casts to int.
6646 (parse_image_spec): Check that integers fall into 'int' range
6647 when the callers expect that.
6648 (image_ascent): Redo ascent calculation to avoid int overflow.
6649 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6650 (lookup_image): Remove unnecessary tests.
6651 (xbm_image_p): Locals are now of int, not EMACS_INT,
6652 since parse_image_check makes sure they fit into int.
6653 (png_load, gif_load, svg_load_image):
6654 Prefer int to unsigned where either will do.
6655 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6656 old tiff_error_handler and tiff_warning_handler.
6657 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6658 stack buffer overflows. It uses only the features of vsnprintf
6659 that are common to both POSIX and native Microsoft.
6660 (tiff_error_handler, tiff_warning_handler): Use it.
6661 (tiff_load, gif_load, imagemagick_load_image):
6662 Don't assume :index value fits in 'int'.
6663 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6664 (imagemagick_load_image): Check that crop parameters fit into
6665 the integer types that MagickCropImage accepts. Don't assume
6666 Vimagemagick_render_type has a nonnegative value. Don't assume
6667 size_t fits in 'long'.
6668 (gs_load): Use printmax_t to print the widest integers possible.
6669 Check for integer overflow when computing image height and width.
6670
c11821d4
EZ
66712011-08-26 Eli Zaretskii <eliz@gnu.org>
6672
6673 * xdisp.c (redisplay_window): Don't force window start if point
6674 will be invisible in the resulting window. (Bug#9324)
6675
0c95fcf7
EZ
66762011-08-25 Eli Zaretskii <eliz@gnu.org>
6677
6678 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6679 the display spec is of the form `(space ...)'.
6680 (handle_display_spec): Return the value returned by
6681 handle_single_display_spec, not just 1 or zero.
6682 (handle_single_display_spec): If the display spec is of the form
6683 `(space ...)', and specifies display in the text area, return 2
6684 rather than 1.
fee65a97 6685 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6686 accurately, and prefer exact match for point under bidi.
6687 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6688
6689 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6690 into disp_prop; all users changed.
6691
6692 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6693 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6694 for the text covered by the display property.
6695
e4ed06f1
CY
66962011-08-25 Chong Yidong <cyd@stupidchicken.com>
6697
6698 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6699 Change return value to nil.
6700 (Frecord_buffer): Delete unused function.
6701
f67cdd7f
EZ
67022011-08-24 Eli Zaretskii <eliz@gnu.org>
6703
5980d4c6
EZ
6704 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6705 buffers, return left-to-right.
8610fe8b
EZ
6706 (set_cursor_from_row): Consider candidate row a win if its glyph
6707 represents a newline and point is on that newline. Fixes cursor
6708 positioning on the newline at EOL of R2L text within L2R
6709 paragraph, and vice versa.
6710 (try_cursor_movement): Check continued rows, in addition to
6711 continuation rows. Fixes unwarranted scroll when point enters a
6712 continued line of R2L text within an L2R paragraph, or vice versa.
6713 (cursor_row_p): Consider the case of point being equal to
6714 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6715 from the end of a short line to the beginning of a continued line
6716 of R2L text within L2R paragraph.
6717 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6718 composed characters.
5980d4c6 6719
f67cdd7f
EZ
6720 * bidi.c (bidi_check_type): Use xassert.
6721 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6722 members.
6723
bca633fb
EZ
67242011-08-23 Eli Zaretskii <eliz@gnu.org>
6725
6726 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6727 a character.
6728
4a5885a7
CY
67292011-08-23 Chong Yidong <cyd@stupidchicken.com>
6730
6731 * nsfont.m (ns_otf_to_script): Fix typo.
6732
0902a04e
KH
67332011-08-22 Kenichi Handa <handa@m17n.org>
6734
6735 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6736 extra slot even if the purpose is char-code-property-table.
6737
1a2e6670
EZ
67382011-08-23 Eli Zaretskii <eliz@gnu.org>
6739
8ddde651
EZ
6740 * xdisp.c (redisplay_window): When computing centering_position,
6741 account for the height of the header line. (Bug#8874)
6742
425cc014
EZ
6743 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6744 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6745 candidate is selected by the mouse, and that candidate has a
6746 composed character under the mouse.
6747
1a2e6670
EZ
6748 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6749 coordinates reported by pos-visible-in-window-p for a composed
6750 character in column zero.
6751
8b76d6f8
SM
67522011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6753
6754 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6755
dac347dd
EZ
67562011-08-22 Eli Zaretskii <eliz@gnu.org>
6757
6758 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6759 consider it a hit if to_charpos is anywhere in the range of the
6760 composed buffer positions.
6761
e013fb34
CY
67622011-08-22 Chong Yidong <cyd@stupidchicken.com>
6763
6764 * image.c (gif_load): Don't assume that each subimage has the same
6765 dimensions as the base image. Handle disposal method that is
6766 "undefined" by the gif spec (Bug#9335).
6767
bd1ba3e8
CY
67682011-08-20 Chong Yidong <cyd@stupidchicken.com>
6769
6770 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6771 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6772
54a1215b
EZ
67732011-08-19 Eli Zaretskii <eliz@gnu.org>
6774
823564e5
EZ
6775 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6776 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6777 from an Org mode buffer to a Speedbar frame.
6778
54a1215b
EZ
6779 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6780 a composition, take its buffer position from IT->cmp_it.charpos.
6781 Fixes cursor positioning at the beginning of a line that begins
6782 with a composed character.
6783
9778ebcc
EZ
67842011-08-18 Eli Zaretskii <eliz@gnu.org>
6785
0be6ee06
EZ
6786 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6787 character bidirectional type, use STRONG_L instead. Fixes crashes
6788 in a buffer produced by `describe-categories'.
6789
9778ebcc
EZ
6790 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6791 members before the level stack, so they would be saved and
6792 restored when copying iterator state. Fixes incorrect reordering
6793 around TABs covered by display properties.
6794
156bffbe
AS
67952011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6796
6b02f655 6797 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6798
72ad093b
CY
67992011-08-17 Chong Yidong <cyd@stupidchicken.com>
6800
6801 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6802 (internal_condition_case_2, internal_condition_case_n):
6803 Remove unnecessary aborts (Bug#9081).
72ad093b 6804
35774242
EZ
68052011-08-17 Eli Zaretskii <eliz@gnu.org>
6806
6807 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6808 has no `load' handler, try opening the file locally. (Bug#9311)
6809
db76dd85
KB
68102011-08-16 Ken Brown <kbrown@cornell.edu>
6811
6812 * gmalloc.c: Expand comment.
6813
b215eee5
EZ
68142011-08-16 Eli Zaretskii <eliz@gnu.org>
6815
6816 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6817 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6818
a4579d33
KB
68192011-08-16 Ken Brown <kbrown@cornell.edu>
6820
6821 Fix memory allocation problems in Cygwin build (Bug#9273).
6822
6823 * unexcw.c ( __malloc_initialized): Declare external variable.
6824 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6825
8b76d6f8
SM
6826 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6827 New variables.
a4579d33
KB
6828 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6829 dumped emacs.
6830 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6831 in the static heap.
6832 [CYGWIN] (special_realloc): New function.
6833 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6834 requests to realloc storage in the static heap.
6835
3ebec551
PE
68362011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6837
6838 * bidi.c (bidi_initialize): Remove unused local.
6839
9fd8be00
EZ
68402011-08-15 Eli Zaretskii <eliz@gnu.org>
6841
6b02f655
SM
6842 * bidimirror.h:
6843 * biditype.h: Remove file.
6844 * makefile.w32-in ($(BLD)/bidi.$(O)):
6845 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6846
6847 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6848
6849 * chartab.c: Improve commentary for the uniprop_table API.
6850
32413314
EZ
6851 * bidi.c (bidi_paragraph_init): Support zero value of
6852 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6853 (bidi_initialize): Use uniprop_table instead of including
6854 biditype.h and bidimirror.h.
32413314 6855
9fd8be00
EZ
6856 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6857 coordinates of the iterator when restoring from ppos_it.
6858 (Bug#9296)
6859
5cf2b69b
KH
68602011-08-14 Kenichi Handa <handa@m17n.org>
6861
6862 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6863 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6864
daf17d00
EZ
68652011-08-14 Eli Zaretskii <eliz@gnu.org>
6866
6867 * xdisp.c (move_it_in_display_line_to): Don't invoke
6868 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6869 ppos_it. Fixes vertical cursor motion when line beginning is
6870 covered by an image. (Bug#9296)
6871
08e3161a
JD
68722011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6873
6874 * nsterm.h (ns_run_ascript): Declare.
6875 (NSAPP_DATA2_RUNASSCRIPT): Define.
6876
6877 * nsfns.m (as_script, as_result, as_status): New static variables.
6878 (ns_run_ascript): New function.
5e617bc2 6879 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6880 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6881 the event loop. Get status from as_status (Bug#7276).
6882
6883 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6884 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6885 the event loop (Bug#7276).
6886
a3720aa2
AS
68872011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6888
6889 * gnutls.c (QCgnutls_bootprop_priority)
6890 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6891 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6892 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6893 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6894 (QCgnutls_bootprop_verify_hostname_error)
6895 (QCgnutls_bootprop_callbacks_verify): Rename from
6896 Qgnutls_bootprop_..., all uses changed.
6897
6898 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6899 uses changed.
6900
0a0d27fb
PE
69012011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6902
19d5c50c
PE
6903 * xfaces.c (Qframe_set_background_mode): Now static.
6904 * dispextern.h (Qframe_set_background_mode): Remove decl.
6905
0a0d27fb
PE
6906 * process.c (Fnetwork_interface_info): Declare local only if needed.
6907
377538cb
JD
69082011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6909
6910 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6911 (Fnetwork_interface_list): Allocate in increments of bytes instead
6912 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6913 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6914 sockaddr.
6915 (struct ifflag_def): notrailers is smart on OSX.
6916 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6917 Get hardware address with getifaddrs if available.
6918
08fff70c
EZ
69192011-08-12 Eli Zaretskii <eliz@gnu.org>
6920
6921 * xdisp.c (iterate_out_of_display_property): xassert that
6922 IT->position is set to within IT->object's boundaries. Break from
6923 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6924 when IT->position is set up wrongly due to some bug.
6925 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6926 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6927 entry. Force push_it to save on the stack the current
6928 buffer/string position, to be restored by pop_it. Fix flags in
6929 the iterator structure wrt the object coming from a display
6930 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6931 properties. (Bug#9284)
6932
7be1c708 69332011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6934
7be1c708
CY
6935 * fontset.c (fontset_get_font_group): Add proper type checks.
6936 (Bug#9172)
aac0c6e3 6937
7be1c708 69382011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6939
7be1c708
CY
6940 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6941 and LC_VERSION_MIN_MACOSX.
6942 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6943 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6944
97bb72a6
EZ
69452011-08-08 Eli Zaretskii <eliz@gnu.org>
6946
6947 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6948 no-display-properties-and-no-overlays under bidi display.
6949 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6950 properties and overlays.
97bb72a6 6951
d5617611
CY
69522011-08-08 Chong Yidong <cyd@stupidchicken.com>
6953
37e11a63
CY
6954 * editfns.c (Fset_time_zone_rule): Document relationship with the
6955 setenv function.
6956
d5617611
CY
6957 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6958 the font entity extracted from the cache (Bug#8109).
6959
58872834
CY
69602011-08-07 Chong Yidong <cyd@stupidchicken.com>
6961
6962 * composite.c (autocmp_chars): Don't reset point. That is done by
6963 restore_point_unwind (Bug#5984).
6964
75bfc667
JL
69652011-08-07 Juri Linkov <juri@jurta.org>
6966
6967 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6968 to show the arg `TIME' instead of `TIMEVAL'.
6969
d1410150
EZ
69702011-08-06 Eli Zaretskii <eliz@gnu.org>
6971
6972 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6973 display property strides EOL and includes a newline, as in
6974 longlines-mode. (Bug#9254)
75b771e4
EZ
6975 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6976 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6977
6978 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6979 is non-zero, even if the data buffer is NULL. Fixes a crash in
6980 vertical-motion with longlines-mode. (Bug#9254)
6981
35928349
EZ
69822011-08-05 Eli Zaretskii <eliz@gnu.org>
6983
ec7cc85b
EZ
6984 * bidi.c <bidi_cache_total_alloc>: Now static.
6985 (bidi_initialize): Initialize bidi_cache_total_alloc.
6986
8b76d6f8 6987 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6988 cache. (Bug#9221)
6989
6990 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6991 amount allocated this far in `bidi_cache_total_alloc'.
6992 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6993 non-zero, only free the data buffer without restoring the cache
6994 contents. All callers changed.
6995
6996 * dispextern.h (bidi_unshelve_cache): Update prototype.
6997
6998 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6999 (move_it_in_display_line, move_it_to)
7000 (move_it_vertically_backward, move_it_by_lines): Replace the call
7001 to xfree to an equivalent call to bidi_unshelve_cache.
7002 (move_it_in_display_line_to): Fix logic of returning
412b6358 7003 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7004
e2e2423b
EZ
70052011-08-05 Eli Zaretskii <eliz@gnu.org>
7006
7007 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7008 came from a string character with a `cursor' property. (Bug#9229)
7009
ae9e757a
JD
70102011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7011
7012 * Makefile.in (LIB_PTHREAD): New variable.
7013 (LIBES): Add LIB_PTHREAD (Bug#9216).
7014
7015 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7016 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7017
213bd7f2
AS
70182011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7019
6b02f655 7020 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7021
99aaf75f
JD
70222011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7023
7024 * xterm.c (x_find_topmost_parent): New function.
7025 (x_set_frame_alpha): Find topmost parent window with
7026 x_find_topmost_parent and set the property there also (bug#9181).
7027 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7028
c74e9d86
PE
70292011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7030
7031 * callproc.c (Fcall_process): Avoid vfork clobbering
7032 the local vars buffer, coding_systems, current_dir.
7033
640c8776
SM
70342011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7035
7036 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7037
f26d0e4c
PE
70382011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7039
8a10d76c
PE
7040 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7041 so that it is not optimized away.
7042
f26d0e4c
PE
7043 * xdisp.c (compute_display_string_pos): Remove unused local.
7044
55439c61
EZ
70452011-08-02 Eli Zaretskii <eliz@gnu.org>
7046
7047 Fix slow cursor motion and scrolling in large buffers with
7048 selective display, like Org Mode buffers. (Bug#9218)
7049
7050 * dispextern.h (struct bidi_it): New member disp_prop_p.
7051
7052 * xdisp.c: Remove one-slot cache of display string positions.
7053 (compute_display_string_pos): Accept an additional argument
5e617bc2 7054 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7055 for a display string or property. If found, set DISP_PROP_P
7056 non-zero.
7057
7058 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7059 DISP_PROP_P, and pass it to compute_display_string_pos.
7060 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7061 non-zero. All callers of bidi_fetch_char changed.
7062
fb33fa43
SM
70632011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7064
7065 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7066
b099e063
DM
70672010-12-03 Don March <don@ohspite.net>
7068
7069 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7070 last character M-[char] is translated to ESC [char] (bug#7541).
7071
5cc7f7af
KH
70722011-08-02 Kenichi Handa <handa@m17n.org>
7073
d0fffa3f 7074 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7075
7076 * chartab.c (uniprop_table): Make it non-static.
7077
525d5e6e
EZ
70782011-08-01 Eli Zaretskii <eliz@gnu.org>
7079
7080 * xdisp.c (forward_to_next_line_start): Accept additional argument
7081 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7082 on the newline.
7083 (reseat_at_next_visible_line_start): Use the bidi iterator state
7084 returned by forward_to_next_line_start to restore the state of
7085 it->bidi_it after backing up to previous newline. (Bug#9212)
7086
31011111
AS
70872011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7088
7089 * regex.c (re_comp): Protoize.
7090 (re_exec): Fix return type.
7091 (regexec): Fix type of `ret'. (Bug#9203)
7092
476371c4
PE
70932011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7094
e5d76069
PE
7095 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7096 This is needed if max-image-size is a floating-point number.
7097
9a79b20c
AS
70982011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7099
7100 * print.c (print_object): Print empty symbol as ##.
7101
7102 * lread.c (read1): Read ## as empty symbol.
7103
d8c2fa78
AA
71042011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7105
7106 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7107 setting frame foreground color (Bug#9175).
7108 (x_set_background_color): Likewise.
7109
ffe57a7a
AA
7110 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7111 contents (Bug#9176).
7112 (EmacsTooltip -init): Remove bezels and add shadows to
7113 tooltip windows.
7114
bf3492a5
AA
7115 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7116 or scroll bar (Bug#8470).
7117
d55e9c53
AA
7118 * nsfont.m (nsfont_open): Remove assignment to voffset and
7119 unnecessary vars hshink, expand, hd, full_height, min_height.
7120 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7121
7122 * nsterm.h (nsfont_info): Remove voffset field.
7123
d8c2fa78 71242011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7125
7126 Implement strike-through and overline on NextStep (Bug#8863).
7127
7128 * nsfont.m (nsfont_open): Use underline position provided by font,
7129 instead of hard-coded value of 2.
7130 (nsfont_draw): Call ns_draw_text_decoration instead.
7131
7132 * nsterm.h: Add declaration for ns_draw_text_decoration.
7133
7134 * nsterm.m (ns_draw_text_decoration): New function for drawing
7135 underline, overline, and strike-through.
7136 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7137 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7138 accommodate underlining, etc.
4843aac3 7139
4cc60b9b
EZ
71402011-07-28 Eli Zaretskii <eliz@gnu.org>
7141
bc7ece87
EZ
7142 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7143 default.
4cc60b9b 7144
476371c4
PE
71452011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7146
66606eea
PE
7147 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7148 Without this fix, if a signal arrives just after memory fills up,
7149 'malloc' might be invoked reentrantly.
7150
476371c4
PE
7151 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7152 In other words, assume that every image size is allowed, on non-X
7153 hosts. This assumption is probably wrong, but it lets Emacs compile.
7154
f3fcc40d
AS
71552011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7156
7157 * regex.c (re_iswctype): Convert return values to boolean.
7158
350c992f
EZ
71592011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7160
7161 * xdisp.c (compute_display_string_pos): Don't use cached display
7162 string position if the buffer had its restriction changed.
7163 (Bug#9184)
7164
5266b4bb
PE
71652011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7166
7167 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7168
2573a837 71692011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7170
41f55ccd 7171 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7172
39e378da
PE
7173 * bidi.c: Integer size and overflow fixes.
7174 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7175 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7176 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7177 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7178 (bidi_find_other_level_edge):
7179 Use ptrdiff_t instead of EMACS_INT where either will do.
7180 This works better on 32-bit hosts configured --with-wide-int.
7181 (bidi_cache_ensure_space): Check for size-calculation overflow.
7182 Use % rather than repeated addition, for better worst-case speed.
7183 Don't set bidi_cache_size until after xrealloc returns, because it
7184 might not return.
7185 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7186 (bidi_cache_ensure_space): Also check that the bidi cache size
7187 does not exceed that of the largest Lisp string or buffer. See Eli
7188 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7189
5e927815
PE
7190 * alloc.c (__malloc_size_t): Remove.
7191 All uses replaced by size_t. See Andreas Schwab's note
7192 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7193
ca4aa935
PE
7194 * image.c: Improve checking for integer overflow.
7195 (check_image_size): Assume that f is nonnull, since
7196 it is always nonnull in practice. This is one less thing to
7197 worry about when checking for integer overflow later.
7198 (x_check_image_size): New function, which checks for integer
7199 overflow issues inside X.
7200 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7201 This removes the need for a memory_full check.
7202 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7203 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7204 (xbm_read_bitmap_data): Change locals back to 'int', since
7205 their values must fit in 'int'.
7206 (xpm_load_image, png_load, tiff_load):
7207 Invoke x_create_x_image_and_pixmap earlier,
7208 to avoid much needless work if the image is too large.
7209 (tiff_load): Treat overly large images as if
7210 x_create_x_image_and_pixmap failed, not as malloc failures.
7211 (gs_load): Use x_check_image_size.
7212
5f8f9cc2
PE
7213 * gtkutil.c: Omit integer casts.
7214 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7215 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7216
5adf60bc
PE
7217 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7218
c8907a93
PE
7219 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7220 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7221 would wrongly return t on a 64-bit host.
7222
e3c25c68
PE
7223 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7224 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7225 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7226 and therefore cause GCC to emit a bogus diagnostic in some cases.
7227
3f791afe
PE
7228 * image.c: Integer signedness and overflow and related fixes.
7229 This is not an exhaustive set of fixes, but it's time to
7230 record what I've got.
7231 (lookup_pixel_color, check_image_size): Remove redundant decls.
7232 (check_image_size): Don't assume that arbitrary EMACS_INT values
7233 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7234 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7235 (tiff_load, imagemagick_load_image):
7236 Check for overflow in size calculations.
7237 (x_create_x_image_and_pixmap): Remove unnecessary test for
7238 xmalloc returning NULL; that can't happen.
7239 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7240 (xpm_color_bucket): Use better integer hashing function.
7241 (xpm_cache_color): Don't possibly over-allocate memory.
7242 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7243 (gif_memory_source):
7244 Use ptrdiff_t, not int or size_t, to record sizes.
7245 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7246 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7247 either works, as we prefer signed integers.
7248 (tiff_read_from_memory, tiff_write_from_memory):
7249 Return tsize_t, not size_t, since that's what the TIFF API wants.
7250 (tiff_read_from_memory): Don't fail simply because the read would
7251 go past EOF; instead, return a short read.
7252 (tiff_load): Omit no-longer-needed casts.
7253 (Fimagemagick_types): Don't assume size fits into 'int'.
7254
3cc5a532
PE
7255 Improve hashing quality when configured --with-wide-int.
7256 * fns.c (hash_string): New function, taken from sxhash_string.
7257 Do not discard information about ASCII character case; this
7258 discarding is no longer needed.
7259 (sxhash-string): Use it. Change sig to match it. Caller changed.
7260 * lisp.h: Declare it.
7261 * lread.c (hash_string): Remove, since we now use fns.c's version.
7262 The fns.c version returns a wider integer if --with-wide-int is
7263 specified, so this should help the quality of the hashing a bit.
7264
b312a492
PE
7265 * emacs.c: Integer overflow minor fix.
7266 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7267 Define only if GNU_LINUX.
7268 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7269
dfd153ae
PE
7270 * dispnew.c: Integer signedness and overflow fixes.
7271 Remove unnecessary forward decls, that were a maintenance hassle.
7272 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7273 All uses changed.
7274 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7275 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7276 (prepare_desired_row, line_draw_cost):
7277 Use int, not unsigned, where either works.
7278 (save_current_matrix, restore_current_matrix):
7279 Use ptrdiff_t, not size_t, where either works.
7280 (init_display): Check for overflow more accurately, and without
7281 relying on undefined behavior.
7282
a81d11a3
PE
7283 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7284 Remove, replacing with the new symbols in lisp.h. All uses changed.
7285 * fileio.c (make_temp_name):
7286 * filelock.c (lock_file_1, lock_file):
7287 * xdisp.c (message_dolog):
7288 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7289 Use pMd etc. instead.
7290 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7291 replacing the pWIDE etc. symbols removed from editfns.c.
7292
3300e6fd
PE
7293 * keyboard.h (num_input_events): Now uintmax_t.
7294 This is (very slightly) less likely to mess up due to wraparound.
7295 All uses changed.
7296
fd05c7e9
PE
7297 * buffer.c: Integer signedness fixes.
7298 (alloc_buffer_text, enlarge_buffer_text):
7299 Use ptrdiff_t rather than size_t when either will do, as we prefer
7300 signed integers.
7301
903fe15d
PE
7302 * alloc.c: Integer signedness and overflow fixes.
7303 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7304 (__malloc_size_t): Default to size_t, not to int.
7305 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7306 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7307 Prefer ptrdiff_t to size_t when either would do, as we prefer
7308 signed integers.
7309 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7310 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7311 Now const. Initialize with values that are in range even if char
7312 is signed.
7313 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7314 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7315 These functions do the right thing with sizes > 2**32.
7316 (check_depth): Now ptrdiff_t, not int.
7317 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7318 Adjust to new way of storing sizes. Check for size overflow bugs
7319 in rest of code.
7320 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7321 slightly wrong anyway, as it missed one instance of
7322 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7323 (refill_memory_reserve): Omit needless cast to size_t.
7324 (mark_object_loop_halt): Mark as externally visible.
7325
ac82cc6a
PE
7326 * xselect.c: Integer signedness and overflow fixes.
7327 (Fx_register_dnd_atom, x_handle_dnd_message):
7328 Use ptrdiff_t, not size_t, since we prefer signed.
7329 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7330 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7331 x_dnd_atoms_size and x_dnd_atoms_length.
7332
c2d1e36d
PE
7333 * doprnt.c: Prefer signed to unsigned when either works.
7334 * eval.c (verror):
7335 * doprnt.c (doprnt):
7336 * lisp.h (doprnt):
7337 * xdisp.c (vmessage):
7338 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7339 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7340 prefer signed arithmetic to avoid comparison confusion.
7341 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7342 but is a bit tricky.
7343
0e926e56
PE
7344 Assume freestanding C89 headers, string.h, stdlib.h.
7345 * data.c, doprnt.c, floatfns.c, print.c:
7346 Include float.h unconditionally.
7347 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7348 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7349 * regex.c: Likewise for stddef.h, string.h.
7350 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7351 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7352 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7353 (STDC_HEADERS): Remove obsolete defines.
7354 * sysdep.c: Include limits.h unconditionally.
7355
9cfdb3ec
PE
7356 Assume support for memcmp, memcpy, memmove, memset.
7357 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7358 * regex.c (memcmp, memcpy):
7359 Remove; we assume C89 now.
7360
7361 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7362 (__malloc_safe_bcopy): Remove; no longer needed.
7363
cf950e6b 7364 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7365 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7366 well either way, and we prefer signed to unsigned.
7367
dbf38e02
LMI
73682011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7369
7370 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7371 closes the connection while we're reading (bug#9182).
7372
d6f0886c 73732011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7374
d6f0886c
JD
7375 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7376 are specified (Bug#9168).
24e0f6b1 7377
2eb1f9e6
PE
73782011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7379
7380 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7381 Found by GCC static checking and --with-wide-int on a 32-bit host.
7382
22381272 73832011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7384
7385 * xdisp.c (compute_display_string_pos): Fix logic of caching
7386 previous display string position. Initialize cached_prev_pos to
7387 -1. Fixes slow-down at the beginning of a buffer.
7388
f25e39b4
EZ
73892011-07-24 Eli Zaretskii <eliz@gnu.org>
7390
7391 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7392 for attrs[LFACE_FONTSET_INDEX].
7393
04c4b52e
PE
73942011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7395
7396 * xml.c (parse_region): Remove unused local
7397 that was recently introduced.
7398
c1734fbd
EZ
73992011-07-23 Eli Zaretskii <eliz@gnu.org>
7400
be18c5a5
EZ
7401 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7402 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7403
c1734fbd
EZ
7404 * xdisp.c (move_it_in_display_line_to): Record the best matching
7405 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7406 exit if none of the characters scanned was an exact match.
7407 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7408 when exact match is impossible due to invisible text, and the
7409 lines are truncated.
7410
a258d627
JD
74112011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7412
7413 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7414 for OSX >= 10.7.
7415
b6d5a689
EZ
74162011-07-22 Eli Zaretskii <eliz@gnu.org>
7417
0f74f785
EZ
7418 Fix a significant slow-down of cursor motion with C-n, C-p,
7419 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7420 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7421 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7422 (next_element_from_buffer): Call compute_stop_pos_backwards to
7423 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7424 base_level_stop.
7425 (reseat): Don't look for prev_stop, as that could mean a very long
7426 run.
7427 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7428 <cached_disp_overlay_modiff>: Cache for last found display string
7429 position.
551918c1 7430 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7431 about the same buffer in the same area of character positions, and
7432 the buffer wasn't changed since the time the display string
7433 position was cached.
551918c1 7434
b2d0c91a
EZ
74352011-07-22 Eli Zaretskii <eliz@gnu.org>
7436
7437 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7438 is an integer, which is important for empty lines. (Bug#9149)
7439
043604ee
CY
74402011-07-22 Chong Yidong <cyd@stupidchicken.com>
7441
7442 * frame.c (Fmodify_frame_parameters): In tty case, update the
7443 default face if necessary (Bug#4238).
7444
da4adb04
CY
74452011-07-21 Chong Yidong <cyd@stupidchicken.com>
7446
7447 * editfns.c (Fstring_to_char): No need to explain what a character
7448 is in the docstring (Bug#6576).
7449
9abd0532
LMI
74502011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7451
7452 * xml.c (parse_region): Make sure we always return a tree.
7453
36881d16
HK
74542011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7455
7456 * xml.c (parse_region): If a document contains only comments,
7457 return that, too.
7458
1e98674d
LMI
74592011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7460
7461 * xml.c (make_dom): Return comments, too.
7462
590bd467
PE
74632011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7464
7465 Port to OpenBSD.
7466 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7467 and the surrounding thread.
7468 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7469 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7470 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7471 timer goes off.
7472 * s/openbsd.h (BROKEN_SIGIO): Define.
7473 * unexelf.c (unexec) [__OpenBSD__]:
7474 Don't update the .mdebug section of the Alpha COFF symbol table.
7475
f41628b2
LMI
74762011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7477
7478 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7479 (bug#8460).
7480
b59b67c5
PE
74812011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7482
15e3a074
PE
7483 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7484 This fixes some race conditions on the permissions of any newly
7485 created file.
7486
41bed37d
PE
7487 * alloc.c (valid_pointer_p): Use pipe, not open.
7488 This fixes some permissions issues when debugging.
7489
b59b67c5
PE
7490 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7491 If fchown fails to set both uid and gid, try to set just gid,
7492 as that is sometimes allowed. Adjust the file's mode to eliminate
7493 setuid or setgid bits that are inappropriate if fchown fails.
7494
925a6be7
SM
74952011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7496
7497 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7498 to compare Lisp_Objects.
7499 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7500 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7501 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7502
52968808
AS
75032011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7504
0a6a104b
AS
7505 * lread.c (read_integer): Unread even EOF character.
7506 (read1): Likewise. Properly record start position of symbol.
7507
52968808
AS
7508 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7509 symbol character follows.
7510
9e381cdd
PE
75112011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7512
7513 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7514 This works around a problem with the previous change to Fcopy_file.
7515 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7516 and without this change, GCC might complain about discarding
7517 fchown's return value.
7518
b5641435
JB
75192011-07-16 Juanma Barranquero <lekktu@gmail.com>
7520
7521 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7522
a8031457
PE
75232011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7524
7525 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7526
dd889327
LMI
75272011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7528
750c33f7
LMI
7529 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7530 it's used from the C level.
7531
dd889327
LMI
7532 * process.c: Use the same condition for POLL_FOR_INPUT in both
7533 keyboard.c and process.c (bug#1858).
7534
87e86684
LM
75352011-07-09 Lawrence Mitchell <wence@gmx.li>
7536
7537 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7538 (Fgnutls_boot): Use it.
7539
64348f40
AS
75402011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7541
7542 * doc.c (Fsubstitute_command_keys): Revert last change.
7543
1d698799
LMI
75442011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7545
f863868c
LMI
7546 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7547 quotes the next character, and doesn't affect other longer
7548 sequences (bug#8935).
7549
1d698799
LMI
7550 * lread.c (syms_of_lread): Clarify that is isn't only
7551 `eval-buffer' and `eval-defun' that's affected by
7552 `lexical-binding' (bug#8460).
7553
aa4b6df6
EZ
75542011-07-15 Eli Zaretskii <eliz@gnu.org>
7555
7556 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7557 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7558
5d856da6
PE
75592011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7560
ad6042bb
PE
7561 Fix minor problems found by static checking.
7562 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7563 (elsz): Now a signed constant, not a size_t var. We prefer signed
7564 types to unsigned, to avoid integer comparison confusion. Without
7565 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7566 "cannot optimize loop, the loop counter may overflow", a symptom
7567 of the confusion.
f00bbb22 7568 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7569 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7570
6468f31c
LMI
75712011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7572
49080b10
LMI
7573 * search.c (Fre_search_backward): Mention `case-fold-search' in
7574 all the re_search_* functions (bug#8138).
7575
6468f31c
LMI
7576 * keyboard.c (Fopen_dribble_file): Document when the file is
7577 closed (bug#8056).
7578
c965adc5
EZ
75792011-07-14 Eli Zaretskii <eliz@gnu.org>
7580
df9733bf
EZ
7581 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7582 bidi_cache_idx.
7583
0bb23927
EZ
7584 Support bidi reordering of display and overlay strings.
7585 * xdisp.c (compute_display_string_pos)
7586 (compute_display_string_end): Accept additional argument STRING.
7587 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7588 (reseat_to_string): Initialize bidi_it->string.s and
7589 bidi_it->string.schars.
7590 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7591 NULL (avoids a crash in bidi_paragraph_init).
7592 Initialize itb.string.lstring.
0bb23927
EZ
7593 (init_iterator): Call bidi_init_it only of a valid
7594 buffer position was specified. Initialize paragraph_embedding to
7595 L2R.
7596 (reseat_to_string): Initialize the bidi iterator.
7597 (display_string): If we need to ignore text properties of
7598 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7599 original value of -1 will not work with bidi.)
7600 (compute_display_string_pos): First arg is now struct
7601 `text_pos *'; all callers changed. Support display properties on
7602 Lisp strings.
7603 (compute_display_string_end): Support display properties on Lisp
7604 strings.
7605 (init_iterator, reseat_1, reseat_to_string): Initialize the
7606 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7607 when iterating on a string not from display properties).
640c8776
SM
7608 (compute_display_string_pos, compute_display_string_end):
7609 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7610 arrow keys.
7611 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7612 base_level_stop; instead, set base_level_stop to BEGV.
7613 Fixes crashes in vertical-motion.
0bb23927
EZ
7614 (next_element_from_buffer): Improve commentary for when
7615 the iterator is before prev_stop.
7616 (init_iterator): Initialize bidi_p from the default value of
7617 bidi-display-reordering, not from buffer-local value. Use the
7618 buffer-local value only if initializing for buffer iteration.
7619 (handle_invisible_prop): Support invisible properties on strings
7620 that are being bidi-reordered.
7621 (set_iterator_to_next): Support bidi reordering of C strings and
7622 Lisp strings.
7623 (next_element_from_string): Support bidi reordering of Lisp
7624 strings.
7625 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7626 (display_string): Support display of R2L glyph rows.
7627 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7628 (init_iterator): Don't initialize it->bidi_p for strings
7629 here.
7630 (reseat_to_string): Initialize it->bidi_p for strings here.
7631 (next_element_from_string, next_element_from_c_string)
7632 (next_element_from_buffer): Add xassert's for correspondence
7633 between IT's object being iterated and it->bidi_it.string
7634 structure.
7635 (face_before_or_after_it_pos): Support bidi iteration.
7636 (next_element_from_c_string): Handle the case of the first string
7637 character that is not the first one in the visual order.
7638 (get_visually_first_element): New function, refactored from common
7639 parts of next_element_from_buffer, next_element_from_string, and
7640 next_element_from_c_string.
7641 (tool_bar_lines_needed, redisplay_tool_bar)
7642 (display_menu_bar): Force left-to-right direction. Add a FIXME
7643 comment for making that be controlled by a user option.
7644 (push_it, pop_it): Save and restore the state of the
7645 bidi iterator. Save and restore the bidi_p flag.
7646 (pop_it): Iterate out of display property for string iteration as
7647 well.
7648 (iterate_out_of_display_property): Support iteration over strings.
7649 (handle_single_display_spec): Set up it->bidi_it for iteration
7650 over a display string, and call bidi_init_it.
7651 (handle_single_display_spec, next_overlay_string)
7652 (get_overlay_strings_1, push_display_prop): Set up the bidi
7653 iterator for displaying display or overlay strings.
7654 (forward_to_next_line_start): Don't use the shortcut if
7655 bidi-iterating.
7656 (back_to_previous_visible_line_start): If handle_display_prop
7657 pushed the iterator stack, restore the internal state of the bidi
7658 iterator by calling bidi_pop_it same number of times.
7659 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7660 and we are bidi-iterating, don't decrement the iterator position;
7661 instead, set the first_elt flag in the bidi iterator, to produce
7662 the same effect.
7663 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7664 (push_display_prop): xassert that we are iterating a buffer.
7665 (push_it, pop_it): Save and restore paragraph_embedding member.
7666 (handle_single_display_spec, next_overlay_string)
7667 (get_overlay_strings_1, reseat_1, reseat_to_string)
7668 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7669 correctly. Don't assume unibyte strings are not bidi-reordered.
7670 (compute_display_string_pos)
7671 (compute_display_string_end): Fix handling the case of C string.
7672 (push_it, pop_it): Save and restore from_disp_prop_p.
7673 (handle_single_display_spec, push_display_prop): Set the
7674 from_disp_prop_p flag.
7675 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7676 (pop_it): Call iterate_out_of_display_property only if we are
7677 popping after iteration over a string that came from a display
7678 property. Fix a typo in popping stretch info. Add an assertion
7679 for verifying that the iterator position is in sync with the bidi
7680 iterator.
7681 (handle_single_display_spec, get_overlay_strings_1)
7682 (push_display_prop): Fix initialization of paragraph direction for
7683 string when that of the parent object is not yet determined.
7684 (reseat_1): Call bidi_init_it to resync the bidi
7685 iterator with IT's position. (Bug#7616)
7686 (find_row_edges): If ROW->start.pos gives position
7687 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7688 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7689 Reset the from_disp_prop_p flag.
7690 (SAVE_IT, RESTORE_IT): New macros.
7691 (pos_visible_p, face_before_or_after_it_pos)
7692 (back_to_previous_visible_line_start)
7693 (move_it_in_display_line_to, move_it_in_display_line)
7694 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7695 (try_scrolling, redisplay_window, display_line): Use them when
7696 saving a temporary copy of the iterator and restoring it back.
7697 (back_to_previous_visible_line_start, reseat_1)
7698 (init_iterator): Empty the bidi cache "stack".
7699 (move_it_in_display_line_to): If iterator ended up at
7700 EOL, but we never saw any buffer positions smaller than
7701 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7702 motion in bidi-reordered lines.
7703 (move_it_in_display_line_to): Record prev_method and prev_pos
7704 immediately before the call to set_iterator_to_next. Fixes cursor
7705 motion in bidi-reordered lines with stretch glyphs and strings
7706 displayed in margins. (Bug#8133) (Bug#8867)
7707 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7708 TO_CHARPOS.
640c8776
SM
7709 (pos_visible_p): Support positions in bidi-reordered lines.
7710 Save and restore bidi cache.
0bb23927
EZ
7711
7712 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7713 (bidi_paragraph_info): Delete unused struct.
7714 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7715 (bidi_cache_start): New variable.
7716 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7717 to zero.
7718 (bidi_cache_fetch_state, bidi_cache_search)
7719 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7720 (bidi_cache_find, bidi_peek_at_next_level)
7721 (bidi_level_of_next_char, bidi_find_other_level_edge)
7722 (bidi_move_to_visually_next): Compare cache index with
7723 bidi_cache_start rather than with zero.
7724 (bidi_fetch_char): Accept new argument STRING; all callers
7725 changed. Support iteration over a string. Support strings with
7726 display properties. Support unibyte strings. Fix the type of
7727 `len' according to what STRING_CHAR_AND_LENGTH expects.
7728 (bidi_paragraph_init, bidi_resolve_explicit_1)
7729 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7730 (bidi_level_of_next_char, bidi_move_to_visually_next):
7731 Support iteration over a string.
0bb23927
EZ
7732 (bidi_set_sor_type, bidi_resolve_explicit_1)
7733 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7734 can now be zero (for strings); special values 0 and -1 were
7735 changed to -1 and -2, respectively.
7736 (bidi_char_at_pos): New function.
7737 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7738 Call it instead of FETCH_MULTIBYTE_CHAR.
7739 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7740 initialized to valid values.
7741 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7742 values.
7743 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7744 the test for valid cached positions. Fix the logic for looking up
7745 the sentinel state in the cache. GCPRO the Lisp string we are
7746 iterating.
7747 (bidi_push_it, bidi_pop_it): New functions.
7748 (bidi_initialize): Initialize the bidi cache start stack pointer.
7749 (bidi_cache_ensure_space): New function, refactored from part of
7750 bidi_cache_iterator_state. Don't assume the required size is just
7751 one BIDI_CACHE_CHUNK away.
7752 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7753 (bidi_count_bytes, bidi_char_at_pos): New functions.
7754 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7755 always valid if bidi_cache_idx is valid.
7756 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7757 is valid if it's going to be used.
7758 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7759 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7760 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7761 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7762 (bidi_find_other_level_edge, bidi_cache_start_stack):
7763 All variables related to cache indices are now EMACS_INT.
c965adc5 7764
0bb23927
EZ
7765 * dispextern.h (struct bidi_string_data): New structure.
7766 (struct bidi_it): New member `string'. Make flag members be 1-bit
7767 fields, and put them last in the struct.
640c8776
SM
7768 (compute_display_string_pos, compute_display_string_end):
7769 Update prototypes.
0bb23927
EZ
7770 (bidi_push_it, bidi_pop_it): Add prototypes.
7771 (struct iterator_stack_entry): New members bidi_p,
7772 paragraph_embedding, and from_disp_prop_p.
7773 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7774 (bidi_shelve_cache, bidi_unshelve_cache):
7775 Declare prototypes.
0bb23927
EZ
7776
7777 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7778 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7779 and vector-like objects.
7780
7781 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7782 cache around display iteration.
7783
7784 * window.c (Fwindow_end, window_scroll_pixel_based)
7785 (displayed_window_lines, Frecenter): Save and restore the bidi
7786 cache around display iteration.
7787
3bbd2265
LMI
77882011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7789
7790 * editfns.c (Fdelete_region): Clarify the use of the named
7791 parameters (bug#6788).
7792
adc47434
MR
77932011-07-14 Martin Rudalics <rudalics@gmx.at>
7794
7795 * indent.c (Fvertical_motion): Set and restore w->pointm when
7796 saving and restoring the window's buffer (Bug#9006).
7797
837c31f8
LMI
77982011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7799
7800 * editfns.c (Fstring_to_char): Clarify just what is returned
7801 (bug#6576). Text by Eli Zaretskii.
7802
ac389d0c
JB
78032011-07-13 Juanma Barranquero <lekktu@gmail.com>
7804
7805 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7806
0be0ce47
EZ
78072011-07-13 Eli Zaretskii <eliz@gnu.org>
7808
7809 * buffer.c (mmap_find): Fix a typo.
7810
cd18e7e3
JB
78112011-07-13 Johan Bockgård <bojohan@gnu.org>
7812
7813 Fix execution of x selection hooks.
7814 * xselect.c (Qx_lost_selection_functions)
7815 (Qx_sent_selection_functions): New vars.
7816 (syms_of_xselect): DEFSYM them.
7817 (x_handle_selection_request): Pass Qx_sent_selection_functions
7818 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7819 (x_handle_selection_clear,x_clear_frame_selections):
7820 Pass Qx_lost_selection_functions rather than
7821 Vx_lost_selection_functions to Frun_hook_with_args.
7822
47ea7f44
PE
78232011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7824
ac389d0c 7825 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7826 The old code sometimes used this field without initializing it.
7827
47ea7f44
PE
7828 * alloc.c (gc_sweep): Don't read past end of array.
7829 In theory, the old code could also have corrupted Emacs internals,
7830 though it'd be very unlikely.
7831
bc985c87
AS
78322011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7833
7834 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7835 argument. (Bug#4026)
bc985c87 7836
0cf34688
LMI
78372011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7838
b3dadd76
LMI
7839 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7840 key" (bug#4257).
7841
0cf34688
LMI
7842 * window.c (Fset_window_start): Doc fix (bug#4199).
7843 (Fset_window_hscroll): Ditto.
7844
270768cd
PE
78452011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7846
077e3dda 7847 Fix minor new problems caught by GCC 4.6.1.
270768cd 7848 * term.c (init_tty): Remove unused local.
490011a6 7849 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7850 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7851 not used otherwise.
270768cd 7852
b1f58454
CY
78532011-07-12 Chong Yidong <cyd@stupidchicken.com>
7854
7855 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7856
22b9578d
LMI
78572011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7858
6e70ab07
LMI
7859 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7860 are the mini-buffer and the echo area (bug#3320).
7861
22b9578d
LMI
7862 * term.c (init_tty): Remove support for supdup, c10 and perq
7863 terminals, which are no longer supported (bug#1482).
7864
8974cc9f
JB
78652011-07-10 Johan Bockgård <bojohan@gnu.org>
7866
7867 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7868
a560d974
JD
78692011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7870
7871 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7872 for non-popups (Bug#3642).
7873
1dae0f0a
AS
78742011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7875
268c2c36 7876 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7877 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7878 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7879 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7880 * data.c (fmod): Likewise.
7881 * dispnew.c (swap_glyphs_in_rows): Likewise.
7882 * emacs.c (memory_warning_signal): Likewise.
7883 * floatfns.c (float_error): Likewise.
7884 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7885 (otf_open, font_otf_capability, generate_otf_features)
7886 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7887 Likewise.
7888 * image.c (pbm_read_file): Likewise.
7889 * indent.c (string_display_width): Likewise.
7890 * intervals.c (check_for_interval, search_for_interval)
7891 (inc_interval_count, count_intervals, root_interval)
7892 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7893 * lread.c (defalias): Likewise.
268c2c36 7894 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7895 * regex.c (set_image_of_range_1, set_image_of_range)
7896 (regex_grow_registers): Likewise.
7897 * sysdep.c (strerror): Likewise.
7898 * termcap.c (valid_filename_p, tprint, main): Likewise.
7899 * tparam.c (main): Likewise.
7900 * unexhp9k800.c (run_time_remap, save_data_space)
7901 (update_file_ptrs, read_header, write_header, calculate_checksum)
7902 (copy_file, copy_rest, display_header): Likewise.
7903 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7904 Likewise.
7905 * xdisp.c (check_it): Likewise.
7906 * xfaces.c (register_color, unregister_color, unregister_colors):
7907 Likewise.
7908 * xfns.c (print_fontset_result): Likewise.
7909 * xrdb.c (member, fatal, main): Likewise.
7910
99033785
PE
79112011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7912
7913 Fix minor problems found by static checking (Bug#9031).
7914 * chartab.c (char_table_set_range, map_sub_char_table):
7915 Remove unused locals.
7916 (uniprop_table): Now static.
7917 * composite.c (_work_char): Remove unused static var.
7918
9cb2ac56
JB
79192011-07-09 Juanma Barranquero <lekktu@gmail.com>
7920
7921 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7922
f25661f0
JD
79232011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7924
7925 * gtkutil.c (qttip_cb): Remove code without function.
7926
8278c4fe
EZ
79272011-07-09 Eli Zaretskii <eliz@gnu.org>
7928
7929 * w32.c (pthread_sigmask): New stub.
7930
1692ae2d 79312011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7932
8a6ebd58 7933 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7934 sigprocmask is portable only for single-threaded applications, and
7935 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7936 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7937 (LIBES): Use it.
7938 * callproc.c (Fcall_process):
7939 * process.c (create_process):
7940 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7941 Use pthread_sigmask, not sigprocmask.
123403e4 7942
1b854618
JD
79432011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7944
7945 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7946 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7947 wrong (Bug#8591).
7948
3fe4b549
JD
79492011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7950
0ce7e563
JD
7951 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7952 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7953 (xg_hide_tooltip): Fix comment.
7954
3fe4b549
JD
7955 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7956 in registerServicesMenuSendTypes.
7957 (validRequestorForSendType): Don't check ns_return_types.
7958
7959 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7960 ns_return_type.
7961
5df75e47
JR
79622011-07-08 Jason Rumney <jasonr@gnu.org>
7963
22610910
JR
7964 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7965 SH_SHOW for hidden windows (Bug#5482).
7966
5df75e47
JR
7967 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7968 frame struct members of non-existent frames (Bug#6284).
7969
699c10bd
JD
79702011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7971
4393663b
JD
7972 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7973 variable firstTime not needed on OSX >= 10.6.
7974 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7975 >= 10.5. Use setKnobProportion, setDoubleValue.
7976
7977 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7978 (MAC_OS_X_VERSION_10_5): Define if not defined.
7979 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7980 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7981 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7982
7983 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 7984 cString and lossyCString on OSX >= 10.4.
4393663b 7985
58179cce 7986 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7987 sizeToFit on OSX >= 10.2.
7988
7989 * nsimage.m (allocInitFromFile): Don't use deprecated method
7990 bestRepresentationForDevice on OSX >= 10.6.
7991
7992 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7993 to avoid warning.
7994
7995 * emacs.c: Declare unexec_init_emacs_zone.
7996
a63e0781
JD
7997 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7998
699c10bd
JD
7999 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8000
8001 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8002 on svcsMenu (Bug#8842).
8003
8004 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8005 ns_return_types.
8006 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8007
8008 * nsterm.m (QUTF8_STRING): Declare.
8009 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8010 (validRequestorForSendType): Return type is (id).
8011 Change indexOfObjectIdenticalTo to indexOfObject.
8012 Check if we have local selection before returning self (Bug#8842).
8013 (writeSelectionToPasteboard): Put local selection into paste board
8014 if we have a local selection (Bug#8842).
8015 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8016
8017 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8018 (ns_get_local_selection): Declare.
8019
54e10184
LMI
80202011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8021
9888ff71
LMI
8022 * keymap.c (describe_map_tree): Don't insert a double newline at
8023 the end of the buffer (bug#1169) and return whether we inserted
8024 something.
8025
54e10184
LMI
8026 * callint.c (Fcall_interactively): Change "reading args" to
8027 "providing args" to try to clarify what it does (bug#1010).
8028
15fa4783
KH
80292011-07-07 Kenichi Handa <handa@m17n.org>
8030
8031 * composite.c (composition_compute_stop_pos): Ignore a static
8032 composition starting before CHARPOS (Bug#8915).
8033
8034 * xdisp.c (handle_composition_prop): Likewise.
8035
a8815b00
EZ
80362011-07-07 Eli Zaretskii <eliz@gnu.org>
8037
8038 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8039 (Bug#9015)
8040
ef7b981d 80412011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8042
8043 * character.h (unicode_category_t): New enum type.
8044
8045 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8046 (Qchar_code_property_table): New variable.
8047 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8048 (UNIPROP_COMPRESSED_FORM_P): New macros.
8049 (char_table_ascii): Uncompress the compressed values.
8050 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8051 Uncompress the compressed values.
ac389d0c 8052 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8053 (char_table_ref_and_range): Uncompress the compressed values.
8054 (sub_char_table_set): New arg is_uniprop. Callers changed.
8055 Uncompress the compressed values.
8056 (sub_char_table_set_range): Args changed. Callers changed.
8057 (char_table_set_range): Adjuted for the above change.
8058 (map_sub_char_table): Delete args default_val and parent. Add arg
8059 top. Give decoded values to a Lisp function.
640c8776 8060 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8061 values to a Lisp function. Gcpro more variables.
8062 (uniprop_table_uncompress)
8063 (uniprop_decode_value_run_length): New functions.
8064 (uniprop_decoder, uniprop_decoder_count): New variables.
8065 (uniprop_get_decoder, uniprop_encode_value_character)
8066 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8067 New functions.
8068 (uniprop_encoder, uniprop_encoder_count): New variables.
8069 (uniprop_get_encoder, uniprop_table)
8070 (Funicode_property_table_internal, Fget_unicode_property_internal)
8071 (Fput_unicode_property_internal): New functions.
8072 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8073 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8074 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8075 char-code-property-alist.
8076
640c8776 8077 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8078 Vunicode_category_table.
8079
640c8776 8080 * font.c (font_range): Adjust for the change of
c805dec0
KH
8081 Vunicode_category_table.
8082
76b397fb
DN
80832011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8084
8085 * m/iris4d.h: Remove file, move contents ...
8086 * s/irix6-5.h: ... here.
8087
22b4128e
PE
80882011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8089
8090 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8091 * alloc.c (mark_buffer):
8092 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8093 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8094 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8095 This isn't true in general, and it's particularly not true
8096 if Emacs is configured with --with-wide-int.
8097 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8098 New macros, used in the buffer.c change.
8099
869795d6
JD
81002011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8101
8102 * xsettings.c: Use both GConf and GSettings if both are available.
8103 (store_config_changed_event): Add comment.
8104 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8105 (store_tool_bar_style_changed): New functions.
5e617bc2 8106 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8107 (struct xsettings): Move font inside HAVE_XFT.
8108 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8109 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8110 Move inside HAVE_XFT.
640c8776 8111 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8112 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8113 also.
8114 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8115 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8116 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8117 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8118 (parse_settings): Move check for font inside HAVE_XFT.
8119 (read_settings, apply_xft_settings): Add comment.
8120 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8121 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8122 call store_font_name_changed.
8123 (xft_settings_event): Add comment.
8124 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8125 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8126 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8127 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8128 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8129 (xsettings_get_system_font, xsettings_get_system_normal_font):
8130 Add comment.
869795d6 8131
d8ed26bd
PE
81322011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8133
8134 Random fixes. E.g., (random) never returned negative values.
8135 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8136 subseconds part to the entropy, as that's a bit more random.
8137 Prefer signed to unsigned, since the signedness doesn't matter and
8138 in general we prefer signed. When given a limit, use a
8139 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8140 latter isn't right if USE_2_TAGS_FOR_INTS.
8141 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8142 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8143
cabf1cac
SM
81442011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8145
8146 * textprop.c (text_property_stickiness):
8147 Obey Vtext_property_default_nonsticky.
8148 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8149 * w32fns.c (syms_of_w32fns):
8150 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8151
6e9b2be9
PE
81522011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8153
8154 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8155 This is more efficient than Ffile_directory_p and avoids a minor race.
8156
90186c68
LMI
81572011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8158
7c301272
LMI
8159 * buffer.c (Foverlay_put): Say what the return value is
8160 (bug#7835).
8161
c4f2d8d4
LMI
8162 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8163 is a directory before asking whether to use the file name
8164 (bug#7564).
ad637907
LMI
8165 (barf_or_query_if_file_exists): Make the "File is a directory"
8166 error be more correct.
c4f2d8d4 8167
90186c68
LMI
8168 * fns.c (Frequire): Remove the mention of the .gz files, since
8169 that's installation-specific, but keep the mention of
8170 `get-load-suffixes'.
8171
da64016e
PE
81722011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8173
8174 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8175 Report string overflow if the output is too long.
8176
7d47b580
JB
81772011-07-04 Juanma Barranquero <lekktu@gmail.com>
8178
a555cb87
JB
8179 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8180 (syms_of_gnutls): Remove duplicate DEFSYM for
8181 Qgnutls_bootprop_verify_hostname_error, an error for
8182 Qgnutls_bootprop_verify_error (which is no longer used).
8183
7d47b580
JB
8184 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8185 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8186 Also (re)move comments that are misplaced or no longer relevant.
8187
1e49bfab
LMI
81882011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8189
8190 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8191
1485f4c0
CY
81922011-07-03 Chong Yidong <cyd@stupidchicken.com>
8193
8194 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8195 and background color parameters if they have been changed.
8196
a9ab721e
LMI
81972011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8198
8199 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8200
cf7cff57
PE
82012011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8202
2e13213d
PE
8203 * xsettings.c (SYSTEM_FONT): Define only when used.
8204 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8205
cf7cff57
PE
8206 * keymap.c (access_keymap_1): Now static.
8207
7a8e04f7
CY
82082011-07-02 Chong Yidong <cyd@stupidchicken.com>
8209
8210 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8211 leave any prefix arg for the up event (Bug#1586).
8212
61352f62
LMI
82132011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8214
69bb1ef7
LMI
8215 * lread.c (syms_of_lread): Mention single symbols defined by
8216 `defvar' or `defconst' (bug#7154).
8217
61352f62 8218 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8219 (Frequire): Mention get-load-suffixes.
61352f62 8220
28545e04
MR
82212011-07-02 Martin Rudalics <rudalics@gmx.at>
8222
8223 * window.h (window): Remove clone_number slot.
8224 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8225 Remove.
8226 (make_parent_window, make_window, saved_window)
8227 (Fset_window_configuration, save_window_save): Don't deal with
8228 clone numbers.
8229 * buffer.c (Qclone_number): Remove declaration.
8230 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8231
3349e122
SM
82322011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8233
8234 Add multiple inheritance to keymaps.
8235 * keymap.c (Fmake_composed_keymap): New function.
8236 (Fset_keymap_parent): Simplify.
8237 (fix_submap_inheritance): Remove.
8238 (access_keymap_1): New function extracted from access_keymap to handle
8239 embedded parents and handle lists of maps.
8240 (access_keymap): Use it.
8241 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8242 (Fcopy_keymap): Handle embedded parents.
8243 (Fcommand_remapping, define_as_prefix): Simplify.
8244 (Fkey_binding): Simplify.
8245 (syms_of_keymap): Move minibuffer-local-completion-map,
8246 minibuffer-local-filename-completion-map,
8247 minibuffer-local-must-match-map, and
8248 minibuffer-local-filename-must-match-map to Elisp.
8249 (syms_of_keymap): Defsubr make-composed-keymap.
8250 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8251 (parse_menu_item): Trivial simplification.
8252
3279eb87
GM
82532011-07-01 Glenn Morris <rgm@gnu.org>
8254
8255 * Makefile.in (SETTINGS_LIBS): Fix typo.
8256
4550efdf
KI
82572011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8258
8259 * coding.c (Fencode_coding_string): Record the last coding system
8260 used, as the function doc string says (bug#8738).
8261
0949d2b6
JD
82622011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8263
8264 * xsettings.c (store_monospaced_changed): Take new font as arg and
8265 check for change against current_mono_font.
8266 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8267 (emacs_settings_constructor, emacs_settings_get_property)
8268 (emacs_settings_set_property, emacs_settings_class_init)
8269 (emacs_settings_init, gsettings_obj): Remove.
8270 (something_changedCB): New function for HAVE_GSETTINGS.
8271 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8272 with value as argument.
8273 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8274 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8275 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8276 "changed".
8277
8278 * xgselect.c: Add defined (HAVE_GSETTINGS).
8279 (xgselect_initialize): Ditto.
8280
8281 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8282 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8283 xg_select.
8284
bbc6b304
PE
82852011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8286
8287 * eval.c (struct backtrace): Simplify and port the data structure.
8288 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8289 signed bit field, as this assumption is not portable and it makes
8290 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8291 "char debug_on_exit : 1" as this is not portable either; instead,
8292 use the portable "unsigned int debug_on_exit : 1". Remove unused
8293 member evalargs. Remove obsolete comments about cc bombing out.
8294
9851bfc5
JD
82952011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8296
51bb811f 8297 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8298 Let HAVE_GSETTINGS override HAVE_GCONF.
8299 (store_monospaced_changed): New function.
8300 (EMACS_SETTINGS): A new type derived from GObject to handle
8301 GSettings notifications.
8302 (emacs_settings_constructor, emacs_settings_get_property)
8303 (emacs_settings_set_property, emacs_settings_class_init):
8304 New functions.
8305 (gsettings_client, gsettings_obj): New variables.
8306 (GSETTINGS_SCHEMA): New define.
8307 (something_changedCB): Call store_monospaced_changed.
8308 (init_gsettings): New function.
8309 (xsettings_initialize): Call init_gsettings.
8310 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8311 to NULL.
8312
640c8776 8313 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8314 GCONF_CFLAGS/LIBS.
8315
5386012d
MR
83162011-06-29 Martin Rudalics <rudalics@gmx.at>
8317
8318 * window.c (resize_root_window, grow_mini_window)
8319 (shrink_mini_window): Rename Qresize_root_window to
8320 Qwindow_resize_root_window and Qresize_root_window_vertically to
8321 Qwindow_resize_root_window_vertically.
8322
f13e0b08
PE
83232011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8324
8325 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8326
94515237
JB
83272011-06-27 Juanma Barranquero <lekktu@gmail.com>
8328
8329 * makefile.w32-in: Redesign dependencies so they reflect more
8330 clearly which files are directly included by each source file,
8331 and not through other includes.
8332
e43b6e43
MR
83332011-06-27 Martin Rudalics <rudalics@gmx.at>
8334
8335 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8336 (sort_overlays, overlay_strings): When an overlay's clone number
8337 matches the window's clone number process the overlay even if
8338 the overlay's window property doesn't match the current window.
8339
d68443dc
MR
8340 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8341 (Fwindow_hchild): Rename to Fwindow_left_child.
8342 (Fwindow_next): Rename to Fwindow_next_sibling.
8343 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8344 (resize_window_check): Rename to window_resize_check.
8345 (resize_window_apply): Rename to window_resize_apply.
8346 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8347 (Fdelete_other_windows_internal, resize_frame_windows)
8348 (Fsplit_window_internal, Fdelete_window_internal)
8349 (grow_mini_window, shrink_mini_window)
8350 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8351
c7e73be5
JD
83522011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8353
8354 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8355 (emacs_fixed_set_min_size): Remove.
8356 (emacs_fixed_new): Take frame as argument.
8357
8358 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8359 (_EmacsFixedPrivate): Remove minwidth/height.
8360 Add struct frame *f.
8361 (emacs_fixed_init): Initialize priv->f.
8362 (get_parent_class, emacs_fixed_set_min_size): Remove.
8363 (emacs_fixed_new): Set priv->f to argument.
8364 (emacs_fixed_get_preferred_width)
8365 (emacs_fixed_get_preferred_height): Use min_width/height from
8366 frames size_hint to set minimum and natural (Bug#8919).
8367 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8368 and use min_width/height from frames size_hint to set
8369 min_width/height (Bug#8919).
8370
8371 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8372 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8373 Fix indentation.
c7e73be5 8374
cf99dcf8
EZ
83752011-06-26 Eli Zaretskii <eliz@gnu.org>
8376
8377 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8378 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8379 called at ZV.
8380
029529ac
CY
83812011-06-26 Chong Yidong <cyd@stupidchicken.com>
8382
8383 * process.c (wait_reading_process_output): Bypass select if
8384 waiting for a cell while ignoring keyboard input, and input is
8385 pending. Suggested by Jan Djärv (Bug#8869).
8386
7a7ef429
PE
83872011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8388
8389 Use gnulib's dup2 module instead of rolling our own.
8390 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8391
11fdef7d 83922011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8393
8394 * dispnew.c (scrolling_window): Before scrolling, turn off a
8395 mouse-highlight in the window being scrolled.
8396
cd3520a4
JB
83972011-06-24 Juanma Barranquero <lekktu@gmail.com>
8398
8399 Move DEFSYM to lisp.h and use everywhere.
8400
8401 * character.h (DEFSYM): Move declaration...
8402 * lisp.h (DEFSYM): ...here.
8403
8404 * gnutls.c:
8405 * minibuf.c:
8406 * w32menu.c:
8407 * w32proc.c:
8408 * w32select.c: Don't include character.h.
8409
8410 * alloc.c (syms_of_alloc):
8411 * buffer.c (syms_of_buffer):
8412 * bytecode.c (syms_of_bytecode):
8413 * callint.c (syms_of_callint):
8414 * casefiddle.c (syms_of_casefiddle):
8415 * casetab.c (init_casetab_once):
8416 * category.c (init_category_once, syms_of_category):
8417 * ccl.c (syms_of_ccl):
8418 * cmds.c (syms_of_cmds):
8419 * composite.c (syms_of_composite):
8420 * dbusbind.c (syms_of_dbusbind):
8421 * dired.c (syms_of_dired):
8422 * dispnew.c (syms_of_display):
8423 * doc.c (syms_of_doc):
8424 * editfns.c (syms_of_editfns):
8425 * emacs.c (syms_of_emacs):
8426 * eval.c (syms_of_eval):
8427 * fileio.c (syms_of_fileio):
8428 * fns.c (syms_of_fns):
8429 * frame.c (syms_of_frame):
8430 * fringe.c (syms_of_fringe):
8431 * insdel.c (syms_of_insdel):
8432 * keymap.c (syms_of_keymap):
8433 * lread.c (init_obarray, syms_of_lread):
8434 * macros.c (syms_of_macros):
8435 * msdos.c (syms_of_msdos):
8436 * print.c (syms_of_print):
8437 * process.c (syms_of_process):
8438 * search.c (syms_of_search):
8439 * sound.c (syms_of_sound):
8440 * syntax.c (init_syntax_once, syms_of_syntax):
8441 * terminal.c (syms_of_terminal):
8442 * textprop.c (syms_of_textprop):
8443 * undo.c (syms_of_undo):
8444 * w32.c (globals_of_w32):
8445 * window.c (syms_of_window):
8446 * xdisp.c (syms_of_xdisp):
8447 * xfaces.c (syms_of_xfaces):
8448 * xfns.c (syms_of_xfns):
8449 * xmenu.c (syms_of_xmenu):
8450 * xsettings.c (syms_of_xsettings):
8451 * xterm.c (syms_of_xterm): Use DEFSYM.
8452
4228cf16
TZ
84532011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8454
cd3520a4 8455 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8456
7fcccf1e
PE
84572011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8458
7efb4e0e
PE
8459 Integer and buffer overflow fixes (Bug#8873).
8460
ff5844ad
PE
8461 * print.c (printchar, strout): Check for string overflow.
8462 (PRINTPREPARE, printchar, strout):
8463 Don't set size unless allocation succeeds.
8464
90532f02
PE
8465 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8466 for sizes. Check for string overflow more accurately.
8467 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8468
6d84508d
PE
8469 * macros.c: Integer and buffer overflow fixes.
8470 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8471 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8472 Use ptrdiff_t, not int, for sizes.
8473 Don't increment bufsize until after realloc succeeds.
8474 Check for size-calculation overflow.
8475 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8476
437b2cb4
PE
8477 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8478
8b9ac8b4
PE
8479 * lread.c: Integer overflow fixes.
8480 (read_integer): Radix is now EMACS_INT, not int,
8481 to improve quality of diagnostics for out-of-range radices.
8482 Calculate buffer size correctly for out-of-range radices.
8483 (read1): Check for integer overflow in radices, and in
8484 read-circle numbers.
82cb60d3
PE
8485 (read_escape): Avoid int overflow.
8486 (Fload, openp, read_buffer_size, read1)
8487 (substitute_object_recurse, read_vector, read_list, map_obarray):
8488 Use ptrdiff_t, not int, for sizes.
8489 (read1): Use EMACS_INT, not int, for sizes.
20270765 8490 Check for size overflow.
8b9ac8b4 8491
7fcccf1e
PE
8492 * image.c (cache_image): Check for size arithmetic overflow.
8493
bfbbd7e7
PE
8494 * lread.c: Integer overflow issues.
8495 (saved_doc_string_size, saved_doc_string_length)
8496 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8497 Now ptrdiff_t, not int.
8498 (read1): Don't assume doc string length fits in int. Check for
8499 out-of-range doc string lengths.
8500 (read_list): Don't assume file position fits in int.
39019e54 8501 (read_escape): Check for hex character overflow.
bfbbd7e7 8502
4e323265
LL
85032011-06-22 Leo Liu <sdl.web@gmail.com>
8504
8505 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8506 Move to minibuffer.el.
8507
85fece3e
PE
85082011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8509
20b84ce9 8510 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8511 The following patches are for when GLYPH_DEBUG && !XASSERT.
8512 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8513 * dispnew.c (flush_stdout):
8514 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8515 Mark as externally visible.
8516 * dispnew.c (check_window_matrix_pointers): Now static.
8517 * dispnew.c (window_to_frame_vpos):
8518 * xfns.c (unwind_create_frame):
8519 * xterm.c (x_check_font): Remove unused local.
8520 * scroll.c (CHECK_BOUNDS):
8521 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8522 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8523 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8524 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8525 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8526 Now static.
8527 (debug_method_add): Use va_list and vsprintf rather than relying
8528 on undefined behavior with wrong number of arguments.
8529 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8530 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8531 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8532 since we're not interested in debugging glyphs with old libraries.
8533 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8534 GCC 4.6.0's static checking.
8535
0766b489
PE
85362011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8537
31fd4b32
PE
8538 Integer overflow and signedness fixes (Bug#8873).
8539 A few related buffer overrun fixes, too.
8540
b79e8648
PE
8541 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8542
0766b489
PE
8543 * dispextern.h (struct face.stipple):
8544 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8545 (x_bitmap_mask, x_allocate_bitmap_record)
8546 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8547 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8548 (x_create_bitmap_from_xpm_data):
8549 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8550 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8551 (.bitmaps_last):
8552 * xfaces.c (load_pixmap):
8553 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8554 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8555 (.bitmaps_last, struct x_output.icon_bitmap):
8556 Use ptrdiff_t, not int, for bitmap indexes.
8557 (x_allocate_bitmap_record): Check for size overflow.
8558 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8559
b081724f
PE
8560 Use ptrdiff_t, not int, for overlay counts.
8561 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8562 * editfns.c (overlays_around, get_pos_property):
8563 * textprop.c (get_char_property_and_overlay):
8564 * xdisp.c (next_overlay_change, note_mouse_highlight):
8565 * xfaces.c (face_at_buffer_position):
21514da7
PE
8566 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8567 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8568 (Fnext_overlay_change, Fprevious_overlay_change)
8569 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8570 Use ptrdiff_t, not int, for sizes.
21514da7 8571 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8572
3de73e5e
PE
8573 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8574
2606c57b
PE
8575 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8576 (x_session_initialize): Do not assume string length fits in int.
8577
aaafe47a
PE
8578 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8579 This is unlikely, but can occur if DPI is outlandish.
8580
2674ddc8 8581 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8582 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8583
28154962
PE
8584 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8585 * xrdb.c (magic_file_p, search_magic_path):
8586 Omit last arg SUFFIX; it was always 0. All callers changed.
8587 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8588
7de51af5
PE
8589 * xfont.c (xfont_match): Avoid need for strlen.
8590
25ed6cc3
PE
8591 * xfns.c: Don't assume strlen fits in int.
8592 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8593
4eab31dd
PE
8594 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8595 not unsigned long, as we prefer signed integers. All callers changed.
8596 Detect integer overflow in repeat count.
8597 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8598 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8599
171e2a58
PE
8600 * termcap.c: Don't assume sizes fit in int and never overflow.
8601 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8602 (gobble_line): Check for size-calculation overflow.
8603
ad39faca 8604 * minibuf.c (Fread_buffer):
6e5bb2dc 8605 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8606 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8607 Don't assume string length fits in int.
8608
52c61c22 8609 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8610 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8611
b5b8c9e5
PE
8612 * font.c: Don't assume string length fits in int.
8613 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8614 Use ptrdiff_t, not int.
ccd6111c
PE
8615 (font_intern_prop): Don't assume string length fits in int.
8616 Don't assume integer property fits in fixnum.
8617 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8618
882f0d81 8619 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8620 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8621 Reformulate so as not to need the command string.
8622 Invoke gzip -cd rather than gunzip, as it's more portable.
8623 (lock_info_type, lock_file_1, lock_file):
8624 Don't assume pid_t and time_t fit in unsigned long.
8625 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8626 (current_lock_owner): Prefer signed type for sizes.
8627 Use memcpy, not strncpy, where memcpy is what is really wanted.
8628 Don't assume (via atoi) that time_t and pid_t fit in int.
8629 Check for time_t and/or pid_t out of range, e.g., via a network share.
8630 Don't alloca where an auto var works fine.
8631
93f4cf88
PE
8632 * fileio.c: Fix some integer overflow issues.
8633 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8634 Don't assume string length fits in int.
8635 (directory_file_name): Don't assume string length fits in long.
8636 (make_temp_name): Don't assume pid fits in int, or that its print
8637 length is less than 20.
8638
f3e92b69
PE
8639 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8640
1bfdaf10
PE
8641 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8642
35016e9a
PE
8643 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8644
3d1e65a1
PE
8645 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8646 We prefer signed integers, even for size calculations.
8647
0b963a93
PE
8648 * emacs.c: Don't assume string length fits in 'int'.
8649 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8650 (main): Don't invoke strlen when not needed.
8651
573f4b54
PE
8652 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8653 (XD_DEBUG_MESSAGE): Don't waste a byte.
8654
989f33ba
PE
8655 * callproc.c (getenv_internal_1, getenv_internal)
8656 (Fgetenv_internal):
965d34eb
PE
8657 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8658
e4d29b33
PE
8659 * lread.c (invalid_syntax): Omit length argument.
8660 All uses changed. This doesn't fix a bug, but it simplifies the
8661 code away from its former Hollerith-constant appearance, and it's
8662 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8663 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8664
eb49b136
PE
8665 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8666 This didn't break anything, but it didn't help either.
8667 It's confusing to put a bogus integer in a place where the actual
8668 value does not matter.
9f62aeb1 8669 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8670 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8671
15375a22
PE
8672 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8673 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8674 implementation.
b61cc01c
PE
8675 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8676 We prefer signed types, and the value cannot exceed the EMACS_INT
8677 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8678 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8679 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8680 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8681
53b2623d
PE
8682 * indent.c (sane_tab_width): New function.
8683 (current_column, scan_for_column, Findent_to, position_indentation)
8684 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8685 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8686
51cab52b 8687 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8688
f2ed8a70
PE
8689 * lisp.h (lint_assume): New macro.
8690 * composite.c (composition_gstring_put_cache):
8691 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8692
abe80cc6
PE
8693 * editfns.c, insdel.c:
8694 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8695
b02c740e
PE
8696 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8697
ebc96716
PE
8698 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8699
b4e50fa0 8700 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8701 Use much-faster test for byte-length change.
311d5d7c 8702 Don't assume string byte-length fits in 'int'.
a4cf38e4 8703 Check that character arg fits in 'int'.
85461888 8704 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8705
c0c1ee9f
PE
8706 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8707
a498d7f4
PE
8708 * fns.c (concat): Catch string overflow earlier.
8709 Do not rely on integer wraparound.
8710
51cab52b
PE
8711 * dispextern.h (struct it.overlay_strings_charpos)
8712 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8713 * xdisp.c (forward_to_next_line_start)
8714 (back_to_previous_visible_line_start)
8715 (reseat_at_next_visible_line_start, next_element_from_buffer):
8716 Don't arbitrarily truncate the value of 'selective' to int.
8717
76031fad
PE
8718 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8719
5eb55db9
PE
8720 * composite.c: Don't truncate sizes to 'int'.
8721 (composition_gstring_p, composition_reseat_it)
8722 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8723 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8724 not EMACS_UINT, for indexes.
5eb55db9 8725
0703a717
PE
8726 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8727
d6202519
PE
8728 * buffer.c: Include <verify.h>.
8729 (struct sortvec.priority, struct sortstr.priority):
8961a454 8730 Now EMACS_INT, not int.
c20998a7 8731 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8732 (struct sortstr.size, record_overlay_string)
8733 (struct sortstrlist.size, struct sortlist.used):
8734 Don't truncate size to int.
8735 (record_overlay_string): Check for size-calculation overflow.
d6202519 8736 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8737
d5a19415
JM
87382011-06-22 Jim Meyering <meyering@redhat.com>
8739
029529ac 8740 Don't leak an XBM-image-sized buffer
d5a19415
JM
8741 * image.c (xbm_load): Free the image buffer after using it.
8742
a9041e6c
PE
87432011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8744
8745 Port to Sun C.
8746 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8747 that Sun C diagnosed.
8748 * fns.c (secure_hash): Fix pointer signedness issue.
8749 * intervals.c (static_offset_intervals): New function.
8750 (offset_intervals): Use it.
8751
7f3f739f
LL
87522011-06-21 Leo Liu <sdl.web@gmail.com>
8753
8754 * deps.mk (fns.o):
8755 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8756 sha512.h.
8757
8758 * fns.c (secure_hash): Rename from crypto_hash_function and change
8759 the first arg to accept symbols.
5b66d427 8760 (Fsecure_hash): New primitive.
7f3f739f
LL
8761 (syms_of_fns): New symbols.
8762
76147d94
DD
87632011-06-20 Deniz Dogan <deniz@dogan.se>
8764
8765 * process.c (Fset_process_buffer): Clarify return value in
8766 docstring.
8767
7d7d0045
CY
87682011-06-18 Chong Yidong <cyd@stupidchicken.com>
8769
8770 * dispnew.c (add_window_display_history): Use BVAR.
8771
8772 * xdisp.c (debug_method_add): Use BVAR.
8773 (check_window_end, dump_glyph_matrix, dump_glyph)
8774 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8775
8776 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8777 Likewise.
8778
8779 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8780 check till after the cache is created in init_frame_faces.
8781
ff2bc410
SM
87822011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8783
8784 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8785
28177add
PE
87862011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8787
dd3482fe
PE
8788 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8789 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8790 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8791
393d71f3 8792 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8793 * fileio.c (Finsert_file_contents):
8794 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8795 Remove the old (too-loose) buffer overflow checks.
8796 They weren't needed, since make_gap checks for buffer overflow.
8797 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8798 The old code merely checked for Emacs fixnum overflow, and relied
8799 on undefined (wraparound) behavior. The new code avoids undefined
8800 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8801
2e6813b0 8802 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8803 Tune. Don't use wider integers than needed. Don't use alloca.
8804 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8805
599a9e4f
PE
8806 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8807
99561444
PE
8808 * insdel.c, lisp.h (buffer_overflow): New function.
8809 (insert_from_buffer_1, replace_range, replace_range_2):
8810 * insdel.c (make_gap_larger):
8811 * editfns.c (Finsert_char):
8812 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8813
28177add
PE
8814 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8815
e69dafad
PE
88162011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8817
4baa020d 8818 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8819
b1c46f02
PE
8820 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8821 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8822
e69dafad
PE
8823 * fileio.c: Don't assume EMACS_INT fits in off_t.
8824 (emacs_lseek): New static function.
8825 (Finsert_file_contents, Fwrite_region): Use it.
8826 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8827
566684ea
PE
8828 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8829
e6966cd6
PE
8830 * fns.c: Don't overflow int when computing a list length.
8831 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8832 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8833 truncation on 64-bit hosts. Check for QUIT every
8834 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8835 faster and is responsive enough.
8836 (Flength): Report an error instead of overflowing an integer.
8837 (Fsafe_length): Return a float if the value is not representable
8838 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8839 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8840 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8841
dd0b0efb
PE
8842 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8843 (header_size, word_size): New constants.
8844 (allocate_vectorlike): Don't check size overflow here.
8845 (allocate_vector): Check it here instead, since this is the only
8846 caller of allocate_vectorlike that could cause overflow.
8847 Check that the new vector's length is representable as a fixnum.
8848
86fe5cfe
PE
8849 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8850 The previous code was bogus. For example, next_almost_prime (32)
8851 returned 39, which is undesirable as it is a multiple of 3; and
8852 next_almost_prime (24) returned 25, which is a multiple of 5 so
8853 why was the code bothering to check for multiples of 7?
8854
80e88859
PE
8855 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8856
4a2f0ad6
PE
8857 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8858
f66c7cf8
PE
8859 Variadic C functions now count arguments with ptrdiff_t.
8860 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8861 Back then I didn't know that the Emacs coding style prefers signed int.
8862 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8863 were being counted with int, which may truncate counts on 64-bit
8864 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8865 * lisp.h (struct Lisp_Subr.function.aMANY)
8866 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8867 Arg counts are now ptrdiff_t, not size_t.
8868 All variadic functions and their callers changed accordingly.
8869 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8870 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8871 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8872 * callint.c (Fcall_interactively): Check arg count for overflow,
8873 to avoid potential buffer overrun. Use signed char, not 'int',
8874 for 'varies' array, so that we needn't bother to check its size
8875 calculation for overflow.
8876 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8877 * eval.c (apply_lambda):
8878 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8879 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8880 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8881
a1759b76
PE
8882 * callint.c (Fcall_interactively): Don't use index var as event count.
8883
d96be9fc
PE
8884 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8885 * mem-limits.h (SIZE): Remove; no longer used.
8886
a690a978 8887 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8888
578c21e6
PE
8889 Remove unnecessary casts.
8890 * xterm.c (x_term_init):
8891 * xfns.c (x_set_border_pixel):
8892 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8893 These aren't needed now that we assume ANSI C.
8894
96f53c6c
PE
8895 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8896 It's more likely to cause problems (due to unsigned overflow)
8897 than to cure them.
8898
83c77d31
PE
8899 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8900
ee2079f1
PE
8901 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8902
6da65536
PE
8903 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8904
7147c4a4
PE
8905 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8906
193e32d9
PE
8907 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8908
e5533da6
PE
8909 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8910
9910e595
PE
8911 GLYPH_CODE_FACE returns EMACS_INT, not int.
8912 * dispextern.h (merge_faces):
8913 * xfaces.c (merge_faces):
01103c44
PE
8914 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8915 Don't assume EMACS_INT fits in int.
9910e595 8916
2638320e
PE
8917 * character.h (CHAR_VALID_P): Remove unused parameter.
8918 * fontset.c, lisp.h, xdisp.c: All uses changed.
8919
045eb8d9
PE
8920 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8921
c1f134b5
PE
8922 * fns.c (concat): Minor tuning based on overflow analysis.
8923 This doesn't fix any bugs. Use int to hold character, instead
8924 of constantly refetching from Emacs object. Use XFASTINT, not
8925 XINT, for value known to be a character. Don't bother comparing
8926 a single byte to 0400, as it's always less.
8927
395fcb93 8928 * floatfns.c (Fexpt):
327eeec8
PE
8929 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8930
abbd3d23
PE
8931 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8932 for characters.
8933
684a03ef
PE
8934 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8935
0fed43f3
PE
8936 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8937 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8938 incorrectly succeed when S was a string, because 4294967386 was
8939 truncated before it was used.
8940
8fd02eb7
PE
8941 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8942 Otherwise, an out-of-range integer could cause undefined behavior
8943 on a 64-bit host.
8944
f8c86b69
PE
8945 * composite.c: Use int, not EMACS_INT, for characters.
8946 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8947 EMACS_INT, for values that are known to be in character range.
8948 This doesn't fix any bugs but is the usual style inside Emacs and
8949 may generate better code on 32-bit machines.
8950
34206dd2
PE
8951 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8952 This is for reasons similar to the recent CHAR_STRING fix.
8953 * charset.c (Fencode_char): Check that character arg is actually
8954 a character. Pass an int to ENCODE_CHAR.
8955 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8956 wider than 'int', as a compile-time check to prevent future regressions
8957 in this area.
8958
c5958d4c 8959 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8960
8961 Make sure a 64-bit char is never passed to CHAR_STRING.
8962 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8963 by silently ignoring the top 32 bits, allowing some values
8964 that were far too large to be valid characters.
8965 * character.h: Include <verify.h>.
8966 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8967 arguments are no wider than unsigned, as a compile-time check
8968 to prevent future regressions in this area.
8969 * data.c (Faset):
01103c44 8970 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8971 (Fsubst_char_in_region):
8972 * fns.c (concat):
8973 * xdisp.c (decode_mode_spec_coding):
8974 Adjust to CHAR_STRING's new requirement.
8975 * editfns.c (Finsert_char, Fsubst_char_in_region):
8976 * fns.c (concat): Check that character args are actually
8977 characters. Without this test, these functions did the wrong
8978 thing with wildly out-of-range values on 64-bit hosts.
8979
d37ca623
PE
8980 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8981 These casts should not be needed on 32-bit hosts, either.
8982 * keyboard.c (read_char):
8983 * lread.c (Fload): Remove casts to unsigned.
8984
ea204efb
PE
8985 * lisp.h (UNSIGNED_CMP): New macro.
8986 This fixes comparison bugs on 64-bit hosts.
8987 (ASCII_CHAR_P): Use it.
8988 * casefiddle.c (casify_object):
01103c44 8989 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8990 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8991 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8992 * dispextern.h (FACE_FROM_ID):
8993 * keyboard.c (read_char): Use UNSIGNED_CMP.
8994
41cb286c
PE
8995 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8996 not to EMACS_INT, to avoid GCC warning.
8997
4a1b9832
PE
8998 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8999
55daad71
PE
9000 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9001 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9002 isn't needed on 32-bit machines.
8f95c75c 9003
01103c44
PE
9004 * buffer.c (Fgenerate_new_buffer_name):
9005 Use EMACS_INT for count, not int.
0ceccced 9006 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9007
9008 * data.c (Qcompiled_function): Now static.
9009
c6f072e7
PE
9010 * window.c (window_body_lines): Now static.
9011
20ce5912
PE
9012 * image.c (gif_load): Rename local to avoid shadowing.
9013
9c4c5f81
PE
9014 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9015 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9016 * alloc.c (make_save_value): Integer argument is now of type
9017 ptrdiff_t, not int.
9018 (mark_object): Use ptrdiff_t, not int.
9019 * lisp.h (pD): New macro.
9020 * print.c (print_object): Use it.
9021
c0c5c8ae
PE
9022 * alloc.c: Use EMACS_INT, not int, to count objects.
9023 (total_conses, total_markers, total_symbols, total_vector_size)
9024 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9025 (total_free_floats, total_floats, total_free_intervals)
9026 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9027 Now EMACS_INT, not int. All uses changed.
9028 (Fgarbage_collect): Compute overall total using a double, so that
9029 integer overflow is less likely to be a problem. Check for overflow
9030 when converting back to an integer.
5a25e253
PE
9031 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9032 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9033 These were 'int' variables that could overflow on 64-bit hosts;
9034 they were never used, so remove them instead of repairing them.
211a0b2a 9035 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9036 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9037 Previously, this ceilinged at INT_MAX, but that doesn't work on
9038 64-bit machines.
e46bb31a 9039 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9040
c78baabf 9041 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9042 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9043 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9044 when a (possibly-narrower) signed value would do just as well.
9045 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9046
c9d624c6
PE
9047 * alloc.c: Catch some string size overflows that we were missing.
9048 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9049 for convenience in STRING_BYTES_MAX.
9050 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9051 The definition here is exact; the one in lisp.h was approximate.
9052 (allocate_string_data): Check for string overflow. This catches
9053 some instances we weren't catching before. Also, it catches
9054 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9055 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9056 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9057
c9d624c6
PE
9058 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9059 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9060 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9061
353032ce
PE
9062 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9063
2bccce07
PE
9064 * alloc.c (Fmake_string): Check for out-of-range init.
9065
0ac30604
SM
90662011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9067
9068 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9069
c195f2de
JD
90702011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9071
9072 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9073 xg_get_default_scrollbar_width.
9074
9075 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9076 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9077 (style_changed_cb): Call update_theme_scrollbar_width and call
9078 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9079 all frames (Bug#8505).
9080 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9081 Call gtk_window_set_resizable if HAVE_GTK3.
9082 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9083 and height if HAVE_GTK3 (Bug#8505).
9084 (scroll_bar_width_for_theme): New variable.
9085 (update_theme_scrollbar_width): New function.
9086 (xg_get_default_scrollbar_width): Move code to
9087 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9088 (xg_initialize): Call update_theme_scrollbar_width.
9089
9090 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9091
9092 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9093
e10ac9f1
MR
90942011-06-12 Martin Rudalics <rudalics@gmx.at>
9095
9096 * frame.c (make_frame): Call other_buffer_safely instead of
9097 other_buffer.
9098
9099 * window.c (temp_output_buffer_show): Call display_buffer with
9100 second argument Vtemp_buffer_show_specifiers and reset latter
9101 immediately after the call.
9102 (Vtemp_buffer_show_specifiers): New variable.
9103 (auto_window_vscroll_p, next_screen_context_lines)
9104 (Vscroll_preserve_screen_position): Remove leading asterisks from
9105 doc-strings.
9106
2d3c217e 91072011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9108
7b7f97e8 9109 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9110 * buffer.c (Qclone_number): Remove for now, as it's unused.
9111 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9112 (record_buffer): Remove unused local.
9113 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9114 (set_frame_buffer_list): Remove; unused.
9115 * frame.h (other_visible_frames): Remove decl.
9116 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9117 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9118 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9119 if HAVE_GPM.
9120 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9121 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9122 Define only if HAVE_GPM.
9123 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9124 (update_hints_inhibit): Remove; never set. All uses removed.
9125 * widgetprv.h (emacsFrameClassRec): Remove decl.
9126 * window.c (delete_deletable_window): Now returns void, since it
9127 wasn't returning anything.
9128 (compare_window_configurations): Remove unused locals.
9129 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9130 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9131 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9132 the same widths as pointers. This follows up on the 2011-05-06 patch.
9133 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9134 * xterm.h: Likewise.
9135 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9136
1384b89e
JB
91372011-06-12 Juanma Barranquero <lekktu@gmail.com>
9138
9139 * makefile.w32-in: Update dependencies.
9140 (LISP_H): Add lib/intprops.h.
9141
1100a63c
CY
91422011-06-11 Chong Yidong <cyd@stupidchicken.com>
9143
9144 * image.c (gif_load): Add animation frame delay to the metadata.
9145 (syms_of_image): Use DEFSYM. New symbol `delay'.
9146
6198ccd0
MR
91472011-06-11 Martin Rudalics <rudalics@gmx.at>
9148
9149 * window.c (delete_deletable_window): Re-add.
9150 (Fset_window_configuration): Rewrite to handle dead buffers and
9151 consequently deletable windows.
9152 (window_tree, Fwindow_tree): Remove. Supply functionality in
9153 window.el.
9154 (compare_window_configurations): Simplify code.
9155
b6e3633c
AS
91562011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9157
1ab0dee5
AS
9158 * image.c (imagemagick_load_image): Fix type mismatch.
9159 (Fimagemagick_types): Likewise.
9160
b6e3633c
AS
9161 * window.h (replace_buffer_in_windows): Declare.
9162
9397e56f
MR
91632011-06-11 Martin Rudalics <rudalics@gmx.at>
9164
9165 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9166 Qclone_number. Remove external declaration of Qdelete_window.
9167 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9168 code.
640c8776
SM
9169 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9170 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9171 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9172 buffer list implementation.
9173 (other_buffer_safely): New function.
9174 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9175 calls to replace_buffer_in_windows and
9176 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9177 if allowed.
9178 (record_buffer): Inhibit quitting and rewrite using quittable
9179 functions. Run Qbuffer_list_update_hook if allowed.
9180 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9181 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9182 Move switch-to-buffer to window.el.
9397e56f
MR
9183 (bury-buffer): Move to window.el.
9184 (Vbuffer_list_update_hook): New variable.
9185
9186 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9187 section.
9188
9189 * window.h (resize_frame_windows): Move up in code.
9190 (Fwindow_frame): Remove EXFUN.
9191 (replace_buffer_in_all_windows): Remove prototype.
9192 (replace_buffer_in_windows_safely): Add prototype.
9193
9194 * window.c: Declare Qdelete_window static again. Move down
9195 declaration of select_count.
9196 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9197 (Fother_window): Move to window.el.
9198 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9199 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9200 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9201 window.el.
9202 (replace_buffer_in_windows): Implement by calling
9203 Qreplace_buffer_in_windows.
9204 (replace_buffer_in_all_windows): Remove with some functionality
9205 moved into replace_buffer_in_windows_safely.
9206 (replace_buffer_in_windows_safely): New function.
9207 (select_window_norecord, select_frame_norecord): Move in front
9208 of run_window_configuration_change_hook. Remove now obsolete
9209 declarations.
640c8776
SM
9210 (Fset_window_buffer): Rewrite doc-string.
9211 Call Qrecord_window_buffer.
9397e56f
MR
9212 (keys_of_window): Move binding for other-window to window.el.
9213
b50691aa
CY
92142011-06-11 Chong Yidong <cyd@stupidchicken.com>
9215
9216 * dispextern.h (struct image): Replace data member, whose int_val
9217 and ptr_val fields were not used by anything, with a single
9218 lisp_val object.
9219
9220 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9221 (gif_clear_image, gif_load, imagemagick_load_image)
9222 (gs_clear_image, gs_load): Callers changed.
9223
3f754b86
PE
92242011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9225
cca69397
PE
9226 * buffer.h: Include <time.h>, for time_t.
9227 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9228
109e28d0
PE
9229 Fix minor problems found by static checking.
9230
60737f02
PE
9231 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9232
4b66faf3
PE
9233 Make identifiers static if they are not used in other modules.
9234 * data.c (Qcompiled_function, Qframe, Qvector):
9235 * image.c (QimageMagick, Qsvg):
9236 * minibuf.c (Qmetadata):
9237 * window.c (resize_window_check, resize_root_window): Now static.
9238 * window.h (resize_window_check, resize_root_window): Remove decls.
9239
109e28d0
PE
9240 * window.c (window_deletion_count, delete_deletable_window):
9241 Remove; unused.
46a4ce9e
PE
9242 (window_body_lines): Now static.
9243 (Fdelete_other_windows_internal): Mark vars as initialized.
9244 Make sure 'resize_failed' is initialized.
9245 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9246 (resize_window_apply): Remove unused local.
9247 * window.h (delete_deletable_window): Remove decl.
9248
109e28d0 9249 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9250 (imagemagick_load_image): Fix pointer signedness problem by changing
9251 last arg from unsigned char * to char *. All uses changed.
9252 Also, fix a local for similar reasons.
9253 Remove unused locals. Remove locals to avoid shadowing.
9254 (fn_rsvg_handle_free): Remove; unused.
9255 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9256 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9257
3f754b86
PE
9258 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9259
2547adb1
CY
92602011-06-10 Chong Yidong <cyd@stupidchicken.com>
9261
9262 * image.c (gif_load): Fix omitted cast error introduced by
9263 2011-06-06 change.
9264
2c8e37d4
MR
92652011-06-10 Martin Rudalics <rudalics@gmx.at>
9266
9267 * window.h (resize_proportionally, orig_total_lines)
9268 (orig_top_line): Remove from window structure.
9269 (set_window_height, set_window_width, change_window_heights)
9270 (Fdelete_window): Remove prototypes.
9271 (resize_frame_windows): Remove duplicate declaration.
9272
440a42e3
EZ
92732011-06-10 Eli Zaretskii <eliz@gnu.org>
9274
9275 * window.h (resize_frame_windows, resize_window_check)
9276 (delete_deletable_window, resize_root_window)
9277 (resize_frame_windows): Declare prototypes.
9278
9279 * window.c (resize_window_apply): Make definition be "static" to
9280 match the prototype.
9281
562dd5e9
MR
92822011-06-10 Martin Rudalics <rudalics@gmx.at>
9283
9284 * window.c: Remove declarations of Qwindow_size_fixed,
9285 window_min_size_1, window_min_size_2, window_min_size,
9286 size_window, window_fixed_size_p, enlarge_window, delete_window.
9287 Remove static from declaration of Qdelete_window, it's
9288 temporarily needed by Fbury_buffer.
9289 (replace_window): Don't assign orig_top_line and
9290 orig_total_lines.
9291 (Fdelete_window, delete_window): Remove. Window deletion is
9292 handled by window.el.
640c8776
SM
9293 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9294 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9295 (Fdelete_other_windows): Remove. Deleting other windows is
9296 handled by window.el.
9297 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9298 handled in window.el.
9299 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9300 Window minimum sizes are handled in window.el.
9301 (shrink_windows, size_window, set_window_height)
9302 (set_window_width, change_window_heights, window_height)
9303 (window_width, CURBEG, CURSIZE, enlarge_window)
9304 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9305 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9306 handled in window.el.
9307 (make_dummy_parent): Rename to make_parent_window and give it a
9308 second argument horflag.
9309 (make_window): Don't set resize_proportionally any more.
9310 (Fsplit_window): Remove. Windows are split in window.el.
9311 (save_restore_action, save_restore_orig_size)
9312 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9313 Resize mini windows in window.el.
9314 (grow_mini_window, shrink_mini_window): Implement by calling
9315 Qresize_root_window_vertically, resize_window_check and
9316 resize_window_apply.
640c8776
SM
9317 (saved_window, Fset_window_configuration, save_window_save):
9318 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9319 resize_proportionally.
9320 (window_min_height, window_min_width): Move to window.el.
9321 (keys_of_window): Move bindings for delete-other-windows,
9322 split-window, delete-window and enlarge-window to window.el.
9323
9324 * buffer.c: Temporarily extern Qdelete_window.
9325 (Fbury_buffer): Temporarily call Qdelete_window instead of
9326 Fdelete_window (Fbury_buffer will move to window.el soon).
9327
9328 * frame.c (set_menu_bar_lines_1): Remove code handling
9329 orig_top_line and orig_total_lines.
9330
9331 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9332 set_window_height but set heights directly.
9333 (change_frame_size_1): Use resize_frame_windows.
9334
9335 * xdisp.c (init_xdisp): Don't use set_window_height but set
9336 heights directly.
9337
640c8776
SM
9338 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9339 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9340 run_window_configuration_change_hook.
9341
9342 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9343 instead of change_window_heights and run
9344 run_window_configuration_change_hook.
9345
1a13852e
MR
93462011-06-09 Martin Rudalics <rudalics@gmx.at>
9347
9348 * window.c (replace_window): Rename second argument REPLACEMENT to
9349 NEW. New third argument SETFLAG. Rewrite.
9350 (delete_window, make_dummy_parent): Call replace_window with
9351 third argument 1.
9352 (window_list_1): Move down in code.
9353 (run_window_configuration_change_hook): Move set_buffer part
9354 before select_frame_norecord part in order to unwind correctly.
9355 Rename count1 to count.
9356 (recombine_windows, delete_deletable_window, resize_root_window)
9357 (Fdelete_other_windows_internal)
9358 (Frun_window_configuration_change_hook, make_parent_window)
9359 (resize_window_check, resize_window_apply, Fresize_window_apply)
9360 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9361 (Fdelete_window_internal, Fresize_mini_window_internal):
9362 New functions.
1a13852e
MR
9363 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9364
f3d1777e
MR
93652011-06-08 Martin Rudalics <rudalics@gmx.at>
9366
496e208e
MR
9367 * window.h (window): Add some new members to window structure -
9368 normal_lines, normal_cols, new_total, new_normal, clone_number,
9369 splits, nest, prev_buffers, next_buffers.
9370 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9371 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9372
f3d1777e
MR
9373 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9374 Remove.
496e208e
MR
9375 (make_dummy_parent): Set new members of windows structure.
9376 (make_window): Move down in code. Handle new members of window
9377 structure.
9378 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9379 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9380 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9381 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9382 (Fset_window_next_buffers, Fset_window_clone_number):
9383 New functions.
496e208e
MR
9384 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9385 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9386 Doc-string fixes.
9387 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9388 Argument WINDOW can be now internal window too.
9389 (Fwindow_use_time): Move up in code.
9390 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9391 Rewrite doc-string.
9392 (Fset_window_configuration, saved_window)
9393 (Fcurrent_window_configuration, save_window_save): Handle new
9394 members of window structure.
b9e809c2
MR
9395 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9396 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9397 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9398 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9399 Qget_mru_window, Qresize_root_window,
9400 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9401 Qauto_buffer_name; staticpro them.
f3d1777e 9402
abde8f8c
MR
94032011-06-07 Martin Rudalics <rudalics@gmx.at>
9404
9405 * window.c (Fwindow_total_size, Fwindow_left_column)
9406 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9407 (Fwindow_list_1): New functions.
9408 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9409 (Fwindow_width, Fscroll_left, Fscroll_right):
9410 Use window_body_cols instead of window_box_text_cols.
9411 (delete_window, Fset_window_configuration):
9412 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9413 (delete_all_subwindows): Take a window as argument and not a
9414 structure. Rewrite.
190b47e6
MR
9415 (window_loop): Remove handling of GET_LRU_WINDOW and
9416 GET_LARGEST_WINDOW.
9417 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9418
9419 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9420 window_box_text_cols. delete_all_subwindows now takes a
9421 Lisp_Object as argument.
abde8f8c 9422
640c8776
SM
9423 * indent.c (compute_motion, Fcompute_motion):
9424 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9425
fa8a67e6
MR
9426 * frame.c (delete_frame): Call delete_all_subwindows with root
9427 window as argument.
9428
a54e3482
DC
94292011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9430
9431 * fns.c (Fputhash): Document return value.
9432
60002bf5
CY
94332011-06-06 Chong Yidong <cyd@stupidchicken.com>
9434
9435 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9436
0c671da6 94372011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9438
b862a52a 9439 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9440
be44ca6c
PE
9441 Check for overflow when converting integer to cons and back.
9442 * charset.c (Fdefine_charset_internal, Fdecode_char):
9443 Use cons_to_unsigned to catch overflow.
9444 (Fencode_char): Use INTEGER_TO_CONS.
9445 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9446 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9447 * data.c (long_to_cons, cons_to_long): Remove.
9448 (cons_to_unsigned, cons_to_signed): New functions.
9449 These signal an error for invalid or out-of-range values.
9450 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9451 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9452 * font.c (Ffont_variation_glyphs):
9453 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9454 * lisp.h: Include <intprops.h>.
9455 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9456 (cons_to_signed, cons_to_unsigned): New decls.
9457 (long_to_cons, cons_to_long): Remove decls.
9458 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9459 (Fprimitive_undo): Use CONS_TO_INTEGER.
9460 * xfns.c (Fx_window_property): Likewise.
9461 * xselect.c: Include <limits.h>.
9462 (x_own_selection, selection_data_to_lisp_data):
9463 Use INTEGER_TO_CONS.
9464 (x_handle_selection_request, x_handle_selection_clear)
9465 (x_get_foreign_selection, Fx_disown_selection_internal)
9466 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9467 (lisp_data_to_selection_data): Use cons_to_unsigned.
9468 (x_fill_property_data): Use cons_to_signed.
9469 Report values out of range.
9470
d1f3d2af
PE
9471 Check for buffer and string overflow more precisely.
9472 * buffer.h (BUF_BYTES_MAX): New macro.
9473 * lisp.h (STRING_BYTES_MAX): New macro.
9474 * alloc.c (Fmake_string):
9475 * character.c (string_escape_byte8):
9476 * coding.c (coding_alloc_by_realloc):
9477 * doprnt.c (doprnt):
9478 * editfns.c (Fformat):
9479 * eval.c (verror):
9480 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9481 since they may not be the same number.
9482 * editfns.c (Finsert_char):
9483 * fileio.c (Finsert_file_contents):
9484 Likewise for BUF_BYTES_MAX.
9485
dd52fcea
PE
9486 * image.c: Use ptrdiff_t, not int, for sizes.
9487 (slurp_file): Switch from int to ptrdiff_t.
9488 All uses changed.
9489 (slurp_file): Check that file size fits in both size_t (for
9490 malloc) and ptrdiff_t (for sanity and safety).
9491
7f9bbdbb
PE
9492 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9493 if b->modtime has its maximal value.
9494
dfe18f82
PE
9495 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9496
84acfcf0
PE
9497 Don't assume time_t can fit into int.
9498 * buffer.h (struct buffer.modtime): Now time_t, not int.
9499 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9500 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9501
ccd9a01a
PE
9502 Minor fixes for signed vs unsigned integers.
9503 * character.h (MAYBE_UNIFY_CHAR):
9504 * charset.c (maybe_unify_char):
9505 * keyboard.c (read_char, reorder_modifiers):
9506 XINT -> XFASTINT, since the integer must be nonnegative.
9507 * ftfont.c (ftfont_spec_pattern):
9508 * keymap.c (access_keymap, silly_event_symbol_error):
9509 XUINT -> XFASTINT, since the integer must be nonnegative.
9510 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9511 since it makes no difference and we prefer signed.
9512 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9513 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9514 nonnegative.
9515
d6d100dd
SM
95162011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9517
9518 * window.h (Fwindow_frame): Declare.
9519
2b6148e4
PE
95202011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9521
9522 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9523 (SPARE_MEMORY): Always define.
9524 (LARGE_REQUEST): Remove.
9525 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9526
f230ecc9
MR
95272011-06-06 Martin Rudalics <rudalics@gmx.at>
9528
727e958e
MR
9529 * lisp.h: Move EXFUNS for Fframe_root_window,
9530 Fframe_first_window and Fset_frame_selected_window to window.h.
9531
9532 * window.h: Move EXFUNS for Fframe_root_window,
9533 Fframe_first_window and Fset_frame_selected_window here from
9534 lisp.h.
9535
9536 * frame.c (Fwindow_frame, Fframe_first_window)
9537 (Fframe_root_window, Fframe_selected_window)
9538 (Fset_frame_selected_window): Move to window.c.
9539 (Factive_minibuffer_window): Move to minibuf.c.
9540 (Fother_visible_frames_p): New function.
9541
9542 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9543
f230ecc9
MR
9544 * window.c (decode_window, decode_any_window): Move up in code.
9545 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9546 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9547 (Fwindow_buffer): Move up and rewrite doc-string.
9548 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9549 (Fwindow_prev): New functions.
727e958e
MR
9550 (Fwindow_frame): Move here from frame.c. Accept any window as
9551 argument.
9552 (Fframe_root_window, Fframe_first_window)
9553 (Fframe_selected_window): Move here from frame.c. Accept frame
9554 or arbitrary window as argument. Update doc-strings.
9555 (Fminibuffer_window): Move up in code.
9556 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9557 (Fset_frame_selected_window): Move here from frame.c.
9558 Marginal rewrite.
727e958e
MR
9559 (Fselected_window, select_window, Fselect_window): Move up in
9560 code. Minor doc-string fixes.
f230ecc9 9561
4d09bcf6
PE
95622011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9563
9564 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9565 Do not assume that spare memory exists; that assumption is valid
9566 only if SYSTEM_MALLOC.
9567 (LARGE_REQUEST): New macro, so that the issue of large requests
9568 is separated from the issue of spare memory.
9569
810928a2
AS
95702011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9571
172418ad
AS
9572 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9573 format. (Bug#8806)
9574
43f862f7
AS
9575 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9576
810928a2
AS
9577 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9578 before statements.
9579
a059fe24
JD
95802011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9581
9582 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9583
9584 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9585
9586 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9587 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9588
989bf368
JB
95892011-06-05 Juanma Barranquero <lekktu@gmail.com>
9590
9591 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9592
4b80f674
CY
95932011-06-04 Chong Yidong <cyd@stupidchicken.com>
9594
9595 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9596 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9597 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9598 New error handlers.
4b80f674
CY
9599 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9600 Obey Vx_select_enable_clipboard_manager. Catch errors in
9601 x_clipboard_manager_save (Bug#8779).
9602 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9603 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9604
99a33b77 96052011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9606
9607 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9608
99a33b77 96092011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9610
9611 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9612 in the current matrix if keep_current_p is non-zero.
9613
8264569d
EZ
96142011-06-04 Eli Zaretskii <eliz@gnu.org>
9615
9616 * bidi.c (bidi_level_of_next_char): Fix last change.
9617
57f97249
EZ
96182011-06-03 Eli Zaretskii <eliz@gnu.org>
9619
fec2107c 9620 Support bidi reordering of text covered by display properties.
57f97249 9621
fec2107c
EZ
9622 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9623 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9624 (bidi_cache_search, bidi_cache_iterator_state)
9625 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9626 (bidi_level_of_next_char, bidi_move_to_visually_next):
9627 Support character positions inside a run of characters covered by a
fec2107c
EZ
9628 display string.
9629 (bidi_paragraph_init, bidi_resolve_explicit_1)
9630 (bidi_level_of_next_char): Call bidi_fetch_char and
9631 bidi_fetch_char_advance instead of FETCH_CHAR and
9632 FETCH_CHAR_ADVANCE.
9633 (bidi_init_it): Initialize new members.
9634 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9635 definitions.
9636 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9637 instead of using explicit *_CHAR codes.
d6d100dd
SM
9638 (bidi_resolve_explicit, bidi_resolve_weak):
9639 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9640 bidirectional text is supported only in multibyte buffers.
9641 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9642 it to initialize the frame_window_p member of struct bidi_it.
9643 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9644 (bidi_resolve_explicit, bidi_resolve_weak)
9645 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9646 bidi_it->nchars is non-positive.
9647 (bidi_level_of_next_char): Don't try to lookup the cache for the
9648 next/previous character if nothing is cached there yet, or if we
9649 were just reseat()'ed to a new position.
c40e2fb2 9650
0e14fe90
EZ
9651 * xdisp.c (set_cursor_from_row): Set start and stop points
9652 according to the row's direction when priming the loop that looks
9653 for the glyph on which to display cursor.
9654 (single_display_spec_intangible_p): Function deleted.
9655 (display_prop_intangible_p): Reimplement to call
9656 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9657 Accept 3 additional arguments needed by handle_display_spec.
9658 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9659 values: lists, `(when COND...)' forms, etc.
9660 (single_display_spec_string_p): Support property values that are
9661 lists with the argument STRING its top-level element.
9662 (display_prop_string_p): Fix the condition for processing a
9663 property that is a list to be consistent with handle_display_spec.
fec2107c 9664 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9665 last portion of handle_display_prop.
9666 (compute_display_string_pos): Accept additional argument
9667 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9668 value of a `display' property is a "replacing spec".
9669 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9670 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9671 the display property, but just return a value indicating whether
9672 the display property will replace the characters it covers.
9673 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9674 frame_window_p members of struct bidi_it.
d6d100dd
SM
9675 (compute_display_string_pos, compute_display_string_end):
9676 New functions.
fec2107c
EZ
9677 (push_it): Accept second argument POSITION, where pop_it should
9678 jump to continue iteration.
9679 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9680
fec2107c
EZ
9681 * keyboard.c (adjust_point_for_property): Adjust the call to
9682 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9683
9684 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9685 (bidi_init_it): Update prototypes.
9686 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9687 (compute_display_string_pos, compute_display_string_end):
9688 Declare prototypes.
fec2107c
EZ
9689 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9690 EMACS_INT.
fc6f18ce 9691
40087514 96922011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9693
57f53182
PE
9694 Malloc failure behavior now depends on size of allocation.
9695 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9696 * lisp.h: Change signatures accordingly.
9697 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9698 All callers changed. (Bug#8762)
9699
9700 * gnutls.c: Use Emacs's memory allocators.
9701 Without this change, the gnutls library would invoke malloc etc.
9702 directly, which causes problems on non-SYNC_INPUT hosts, and which
9703 runs afoul of improving memory_full behavior. (Bug#8761)
9704 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9705 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9706 xfree instead of the default malloc, realloc, free.
9707 (Fgnutls_boot): No need to check for memory allocation failure,
9708 since xmalloc does that for us.
9709
ac32cd99 9710 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9711 * category.c (hash_get_category_set):
9712 * ccl.c (ccl_driver):
9713 * charset.c (Fdefine_charset_internal):
9714 * charset.h (struct charset.hash_index):
9715 * composite.c (get_composition_id, gstring_lookup_cache)
9716 (composition_gstring_put_cache):
9717 * composite.h (struct composition.hash_index):
9718 * dispextern.h (struct image.hash):
9719 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9720 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9721 (hashfn_equal, hashfn_user_defined, make_hash_table)
9722 (maybe_resize_hash_table, hash_lookup, hash_put)
9723 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9724 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9725 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9726 * image.c (make_image, search_image_cache, lookup_image)
9727 (xpm_put_color_table_h):
9728 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9729 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9730 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9731 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9732 * alloc.c (allocate_vectorlike):
9733 Check for overflow in vector size calculations.
9734 * ccl.c (ccl_driver):
9735 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9736 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9737 need to be updated by these changes.
40087514
PE
9738 * fns.c (make_hash_table, maybe_resize_hash_table):
9739 Check for integer overflow with large hash tables.
0de4bb68
PE
9740 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9741 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9742 (SXHASH_REDUCE): New macro.
9743 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9744 Use it instead of discarding useful hash info with large hash values.
9745 (sxhash_float): New function.
9746 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9747 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9748 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9749 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9750 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9751 Adjust signatures to match updated version of code.
9752 (consing_since_gc): Now EMACS_INT, since a single hash table can
9753 use more than INT_MAX bytes.
9754
698d32e2
DN
97552011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9756
9757 Make it possible to build with GCC-4.6+ -O2 -flto.
9758
9759 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9760
fd6fa53f
SM
97612011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9762
9763 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9764 Call minibuffer-inactive-mode.
9765
864db017
JB
97662011-05-31 Juanma Barranquero <lekktu@gmail.com>
9767
9768 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9769 Update dependencies.
9770
2ad0baf4
DN
97712011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9772
9773 * data.c (init_data): Remove code for UTS, this system is not
9774 supported anymore.
9775
4fcc2638
DN
97762011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9777
9778 Don't force ./temacs to start in terminal mode.
9779
9780 * frame.c (make_initial_frame): Initialize faces in all cases, not
9781 only when CANNOT_DUMP is defined.
9782 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9783
c56e0fd5
DN
97842011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9785
9786 * dispnew.c (add_window_display_history): Use const for the string
9787 pointer. Remove declaration, not needed.
9788
333d54da 97892011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9790
55d4c1b2 9791 Use 'inline', not 'INLINE'.
333d54da 9792 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9793 * alloc.c, fontset.c (INLINE): Remove.
9794 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9795 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9796 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9797 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9798 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9799
738db178
DN
98002011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9801
9802 Make it possible to run ./temacs.
9803
9804 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9805 syms_of_callproc does the same thing. Remove test for
9806 "initialized", do it in the caller.
9807 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9808
620c53a6
SM
98092011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9810
9811 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9812 (read_minibuf): Use get_minibuffer.
9813 (syms_of_minibuf): Use DEFSYM.
9814 (Qmetadata): New var.
9815 * data.c (Qbuffer): Don't make it static.
9816 (syms_of_data): Use DEFSYM.
9817
e003a292
PE
98182011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9819
9820 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9821 (CCL_CODE_MIN): New macro.
9822
ed008a6d
PE
98232011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9824
3687c2ef
PE
9825 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9826
ed008a6d
PE
9827 * eval.c (Qdebug): Now static.
9828 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9829 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9830 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9831
d66c4c7c
CY
98322011-05-29 Chong Yidong <cyd@stupidchicken.com>
9833
9834 * image.c: Various fixes to ImageMagick code comments.
9835 (Fimagemagick_types): Doc fix.
9836
5fbc2025
PE
98372011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9838
0196f88a
PE
9839 Minor fixes prompted by GCC 4.6.0 warnings.
9840
9841 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9842
5fbc2025
PE
9843 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9844 (x_clipboard_manager_save_all): Move extern decl to ...
9845 * xterm.h: ... here, so that it can be checked for consistency.
9846
1dd3c2d9
CY
98472011-05-29 Chong Yidong <cyd@stupidchicken.com>
9848
9849 * xselect.c (x_clipboard_manager_save_frame)
9850 (x_clipboard_manager_save_all): New functions.
9851 (Fx_clipboard_manager_save): Lisp function deleted.
9852
9853 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9854 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9855
9856 * xterm.h: Update prototype.
9857
5ba6571d
WX
98582011-05-28 William Xu <william.xwl@gmail.com>
9859
9860 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9861 exiting (Bug#8239).
9862
3eaff834
JM
98632011-05-28 Jim Meyering <meyering@redhat.com>
9864
e1900994 9865 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9866 * fns.c (to_uchar): Define.
9867 (crypto_hash_function): Use it to convert some newly-signed
9868 variables to unsigned, to avoid sign-extension bugs. For example,
9869 without this change, (md5 "truc") would evaluate to
9870 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9871 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9872 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9873
0f6990a7
PE
98742011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9875
9876 Integer overflow fixes.
c8a9ca5a 9877
08686060
PE
9878 * dbusbind.c: Serial number integer overflow fixes.
9879 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9880 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9881 to hold a serial number that is too large for a fixnum.
9882 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9883 Check for serial numbers out of range. Decode any serial number
59568bf0 9884 that was so large that it became a float. (Bug#8722)
08686060 9885
2d1fc3c7
PE
9886 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9887 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9888 Use XFASTINT rather than XUINT when numbers are nonnegative.
9889 (xd_append_arg, Fdbus_method_return_internal):
9890 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9891 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9892 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9893 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9894 (Bug#8722)
2d1fc3c7 9895
c8a9ca5a
PE
9896 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9897
519e1d69
PE
9898 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9899
6df6ae42 9900 ccl: Add integer overflow checks.
30569699
PE
9901 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9902 (IN_INT_RANGE): New macros.
9903 (ccl_driver): Use them to check for integer overflow when
9904 decoding a CCL program. Many of the new checks are whether XINT (x)
9905 fits in int; it doesn't always, on 64-bit hosts. The new version
9906 doesn't catch all possible integer overflows, but it's an
847044ea 9907 improvement. (Bug#8719)
30569699 9908
c11285dc
PE
9909 * alloc.c (make_event_array): Use XINT, not XUINT.
9910 There's no need for unsigned here.
9911
fdccd48e
PE
9912 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9913 This follows up to the 2011-05-06 change that substituted uintptr_t
9914 for EMACS_INT. This case wasn't caught back then.
9915
37910ab2
PE
9916 Rework Fformat to avoid integer overflow issues.
9917 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9918 now (part of C89). Include <verify.h>.
9919 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9920 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9921 (Fformat): Avoid the prepass trying to compute sizes; it was only
9922 approximate and thus did not catch overflow reliably. Instead, walk
9923 through the format just once, formatting and computing sizes as we go,
9924 checking for integer overflow at every step, and allocating a larger
9925 buffer as needed. Keep track separately whether the format is
9926 multibyte. Keep only the most-recently calculated precision, rather
9927 than them all. Record whether each argument has been converted to
9928 string. Use EMACS_INT, not int, for byte and char and arg counts.
9929 Support field widths and precisions larger than INT_MAX. Avoid
9930 sprintf's undefined behavior with conversion specifications such as %#d
9931 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9932 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9933 formatting out-of-range floating point numbers with int
9173deec 9934 formats. (Bug#8668)
37910ab2 9935
2e6578fb
PE
9936 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9937
0ae6bdee
PE
9938 * data.c: Avoid integer truncation in expressions involving floats.
9939 * data.c: Include <intprops.h>.
9940 (arith_driver): When there's an integer overflow in an expression
9941 involving floating point, convert the integers to floating point
9942 so that the resulting value does not suffer from catastrophic
9943 integer truncation. For example, on a 64-bit host (* 4
9944 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9945 Do not rely on undefined behavior after integer overflow.
9946
de883a70
PE
9947 merge count_size_as_multibyte, parse_str_to_multibyte
9948 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9949 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9950 Check for integer overflow.
9951 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9952 since it's now a duplicate of the other. This is more of
9953 a character than a buffer op, so better that it's in character.c.
9954 * fns.c, print.c: Adjust to above changes.
9955
2ff916cb
PE
99562011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9957
9958 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9959
f1b54466
PE
99602011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9961
fb1ac845
PE
9962 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9963 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9964 (x_clipboard_manager_save): Now static.
9965 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9966
f1b54466
PE
9967 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9968 (crypto_hash_function): Now static.
9969 Fix pointer signedness problems. Avoid unnecessary initializations.
9970
a9f737ee
CY
99712011-05-27 Chong Yidong <cyd@stupidchicken.com>
9972
9973 * termhooks.h (Vselection_alist): Make it terminal-local.
9974
9975 * terminal.c (create_terminal): Initialize it.
9976
9977 * xselect.c: Support for clipboard managers.
9978 (Vselection_alist): Move to termhooks.h as terminal-local var.
9979 (LOCAL_SELECTION): New macro.
9980 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9981 (symbol_to_x_atom): Remove gratuitous arg.
9982 (x_handle_selection_request, lisp_data_to_selection_data)
9983 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9984 (x_own_selection, x_get_local_selection, x_convert_selection):
9985 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9986 (some_frame_on_display): Delete unused function.
9987 (Fx_own_selection_internal, Fx_get_selection_internal)
9988 (Fx_disown_selection_internal, Fx_selection_owner_p)
9989 (Fx_selection_exists_p): New optional frame arg.
9990 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9991 (x_handle_selection_clear): Don't treat other terminals with the
9992 same keyboard specially. Use the terminal-local Vselection_alist.
9993 (x_clear_frame_selections): Use Frun_hook_with_args.
9994
9995 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9996
9997 * xterm.h: Add support for those atoms.
9998
e067f0c1
CY
99992011-05-26 Chong Yidong <cyd@stupidchicken.com>
10000
10001 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10002 (converted_selections, conversion_fail_tag): New global variables.
10003 (x_selection_request_lisp_error): Free the above.
10004 (x_get_local_selection): Remove unnecessary code.
10005 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10006 of converted selections stored in converted_selections.
10007 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10008 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10009 (x_convert_selection): New function.
10010 (x_handle_selection_event): Simplify.
10011 (x_get_foreign_selection): Don't ignore incoming requests while
10012 waiting for an answer; this will fail when we implement
10013 SAVE_TARGETS, and seems unnecessary anyway.
10014 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10015 (Vx_sent_selection_functions): Doc fix.
10016
0f4aebc0
LL
100172011-05-26 Leo Liu <sdl.web@gmail.com>
10018
10019 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10020
e61124cd
YM
100212011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10022
10023 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10024
10025 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10026 for fringe update if it has periodic bitmap.
ac389d0c 10027 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10028 and fringe_bitmap_periodic_p.
10029
10030 * fringe.c (get_fringe_bitmap_data): New function.
10031 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10032 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10033 row. Mark glyph row for fringe update if periodicity changed.
10034
10035 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10036 for fringe update unless it has periodic bitmap.
10037
f16d9837
KH
100382011-05-25 Kenichi Handa <handa@m17n.org>
10039
10040 * xdisp.c (get_next_display_element): Set correct it->face_id for
10041 a static composition.
10042
e1b90ef6
LL
100432011-05-24 Leo Liu <sdl.web@gmail.com>
10044
10045 * deps.mk (fns.o):
10046 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10047
10048 * fns.c (crypto_hash_function, Fsha1): New function.
10049 (Fmd5): Use crypto_hash_function.
10050 (syms_of_fns): Add Ssha1.
10051
7400048f
PE
100522011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10053
10054 * gnutls.c: Remove unused macros.
10055 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10056 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10057 Remove macros that are defined and never used.
10058 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10059
abb71cf4
CY
100602011-05-22 Chong Yidong <cyd@stupidchicken.com>
10061
10062 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10063 (Fx_get_selection_internal): Minor cleanup.
10064 (Fx_own_selection_internal): Rename arguments for consistency with
10065 select.el.
10066
6307db39
PE
100672011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10068
10069 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10070
f3d4e0a4
CY
100712011-05-22 Chong Yidong <cyd@stupidchicken.com>
10072
10073 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10074
4d8ade89
YM
100752011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10076
10077 * dispnew.c (scrolling_window): Don't exclude the case that the
10078 last enabled row in the desired matrix touches the bottom boundary.
10079
32078c8d
GM
100802011-05-21 Glenn Morris <rgm@gnu.org>
10081
10082 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10083 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10084 and add some more files.
32078c8d 10085
7285dc67
EZ
100862011-05-20 Eli Zaretskii <eliz@gnu.org>
10087
10088 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10089 report_file_error introduced by the change from 2011-05-07.
10090
89d1bd22
PE
100912011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10092
10093 * systime.h (Time): Define only if emacs is defined.
10094 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10095 where the include path doesn't have X11/X.h by default. See
10096 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10097
cd394be1 100982011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10099
10100 * composite.c (find_automatic_composition): Fix previous change.
10101
b9704ad9
GM
101022011-05-20 Glenn Morris <rgm@gnu.org>
10103
10104 * lisp.mk: New file, split from Makefile.in.
10105 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10106 (shortlisp): Remove.
10107 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10108
4a720484
GM
101092011-05-19 Glenn Morris <rgm@gnu.org>
10110
10111 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10112 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10113 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10114 (lisp): Set the order to that of loadup.el.
10115 (shortlisp): Make it a copy of $lisp.
10116 (SOME_MACHINE_LISP): Remove.
10117 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10118 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10119
a28d4396
KH
101202011-05-18 Kenichi Handa <handa@m17n.org>
10121
10122 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10123 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10124 (find_automatic_composition): Mostly rewrite for efficiency.
10125
a2b1fa8e
JB
101262011-05-18 Juanma Barranquero <lekktu@gmail.com>
10127
10128 * makefile.w32-in: Update dependencies.
10129
8e1f5610
CS
101302011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10131
10132 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10133 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10134
7025ee00 101352011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10136
cdfa6eab
PE
10137 Fix some integer overflow issues, such as string length overflow.
10138
06d6db33
PE
10139 * insdel.c (count_size_as_multibyte): Check for string overflow.
10140
2b4560a8
PE
10141 * character.c (lisp_string_width): Check for string overflow.
10142 Use EMACS_INT, not int, for string indexes and lengths; in
10143 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10144 the resulting string length overflows an EMACS_INT; instead,
10145 report a string overflow if no precision given. When checking for
10146 precision exhaustion, use a check that cannot possibly have
10147 integer overflow. (Bug#8675)
10148 * character.h (lisp_string_width): Adjust to new signature.
10149
cb93f9be
PE
10150 * alloc.c (string_overflow): New function.
10151 (Fmake_string): Use it. This doesn't change behavior, but saves
10152 a few bytes and will simplify future changes.
10153 * character.c (string_escape_byte8): Likewise.
10154 * lisp.h (string_overflow): New decl.
10155
1a1f3366
PE
10156 Fixups, following up to the user-interface timestamp change.
10157 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10158 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10159 * msdos.c (mouse_get_pos): Likewise.
10160 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10161 * w32gui.h (Time): Define by including "systime.h" rather than by
10162 declaring it ourselves. (Bug#8664)
10163
d4e3e4d3
PE
10164 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10165 * image.c (clear_image_cache): Likewise.
10166
f6a24d19
PE
10167 * term.c (term_mouse_position): Don't assume time_t wraparound.
10168
08dc5ae6
PE
10169 Be more systematic about user-interface timestamps.
10170 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10171 and sometimes 'EMACS_UINT', to represent these timestamps.
10172 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10173 This makes the code easier to follow, and makes it easier to catch
10174 integer overflow bugs such as Bug#8664.
10175 * frame.c (Fmouse_position, Fmouse_pixel_position):
10176 Use Time, not unsigned long, for user-interface timestamps.
10177 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10178 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10179 * keyboard.h (last_event_timestamp): Likewise.
10180 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10181 * menu.h (xmenu_show): Likewise.
10182 * term.c (term_mouse_position): Likewise.
10183 * termhooks.h (struct input_event.timestamp): Likewise.
10184 (struct terminal.mouse_position_hook): Likewise.
10185 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10186 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10187 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10188 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10189 what it was before.
10190 * menu.h, termhooks.h: Include "systime.h", for Time.
10191
8e55734a
PE
10192 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10193 Don't assume that the difference between two unsigned long values
10194 can fit into an integer. At this point, we know button_down_time
10195 <= event->timestamp, so the difference must be nonnegative, so
10196 there's no need to cast the result if double-click-time is
10197 nonnegative, as it should be; check that it's nonnegative, just in
10198 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10199 apart (about 25 days). (Bug#8664)
8e55734a 10200
841f1b75 10201 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10202 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10203
3e26f69c
PE
10204 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10205 that always fit in int. Use a sentinel instead of a counter, to
10206 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10207 * frame.h (struct frame): Use int for menu_bar_items_used
10208 instead of EMACS_INT, since it always fits in int.
3e26f69c 10209
5cc152c0
PE
10210 * menu.c (grow_menu_items): Check for int overflow.
10211
d89eb65e
PE
10212 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10213
5235bd3e
PE
10214 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10215 Before, the code was not consistent. These values cannot exceed
10216 2**31 - 1 so there's no need to make them unsigned.
10217 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10218 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10219 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10220 as modifiers.
10221 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10222
bc827e23
PE
10223 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10224 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10225 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10226 presumably because the widths might not match.
10227
78eb494e
PE
10228 * window.c (size_window): Avoid needless test at loop start.
10229
04f2d78b
CB
102302011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10231
10232 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10233
d2fc7e3d 102342011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10235
10236 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10237
d2fc7e3d 102382011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10239
10240 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10241 `width' to `bar_area_x' and `bar_area_width', respectively.
10242 (x_scroll_run): Take account of fringe background extension.
10243
04f2d78b
CB
10244 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10245 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10246 `bar_area_width', respectively.
10247 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10248 background extension.
10249
79b70037
GM
102502011-05-10 Jim Meyering <meyering@redhat.com>
10251
10252 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10253
2f142cc5
JB
102542011-05-10 Juanma Barranquero <lekktu@gmail.com>
10255
10256 * image.c (Finit_image_library): Return t for built-in image types,
10257 like pbm and xbm. (Bug#8640)
10258
57679c86
AS
102592011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10260
10261 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10262
888c9e86
EZ
102632011-05-07 Eli Zaretskii <eliz@gnu.org>
10264
b0512a1d
EZ
10265 * w32console.c (Fset_screen_color): Doc fix.
10266 (Fget_screen_color): New function.
10267 (syms_of_ntterm): Defsubr it.
10268
7285dc67
EZ
10269 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10270 unlink the temporary file if Fcall_process didn't create it in the
10271 first place.
10272 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10273 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10274 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10275 cue to call_process_cleanup not to close that handle.
10276
4d3fcc8e
BK
102772011-05-07 Ben Key <bkey76@gmail.com>
10278
10279 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10280 one of two shell specific rules, either bootstrap-temacs-CMD or
10281 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10282 to the previous implementation of the bootstrap-temacs rule.
10283 The bootstrap-temacs-CMD rule is similar to the previous
10284 implementation of the bootstrap-temacs rule except that it
10285 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10286 variable.
10287
10288 These changes, along with some changes to nt/configure.bat,
10289 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10290 earlier fix to add support for --cflags and --ldflags options
10291 that include quotes so that it works whether make uses cmd or
10292 sh as the shell.
10293
b4289b64
MA
102942011-05-06 Michael Albinus <michael.albinus@gmx.de>
10295
10296 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10297 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10298 is a constant.
10299 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10300 a string. Handle both cases.
10301 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10302 (Fdbus_register_method): Use Qinvalid_function.
10303
af4c0e28
JB
103042011-05-06 Juanma Barranquero <lekktu@gmail.com>
10305
10306 * makefile.w32-in: Update dependencies.
10307 (LISP_H): Add inttypes.h and stdin.h.
10308 (PROCESS_H): Add unistd.h.
10309
c51453d9
EZ
103102011-05-06 Eli Zaretskii <eliz@gnu.org>
10311
10312 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10313 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10314
8ff0ac3c 103152011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10316
4c4b566b
PE
10317 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10318
aab2b9b5
PE
10319 * term.c (vfatal): Remove stray call to va_end.
10320 It's not needed and the C Standard doesn't allow it here anyway.
10321
c378da0b
PE
10322 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10323 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10324
288b08c7
PE
10325 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10326 bytes.
10327
e3601888
PE
10328 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10329
db6c0e74
PE
10330 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10331
dd5963ea
PE
10332 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10333
88c9450f
PE
10334 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10335
2f9442b8
PE
10336 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10337
c032b5f8
PE
10338 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10339 * charset.c (Fdefine_charset_internal): Don't initialize
10340 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10341 32-bit int (Bug#8600).
a108c10b
PE
10342
10343 * lread.c (read_integer): Be more consistent with string-to-number.
10344 Use string_to_number to do the actual conversion; this avoids
10345 rounding errors and fixes some other screwups. Without this fix,
10346 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10347 (digit_to_number): Move earlier, for benefit of read_integer.
10348 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10349 not a digit in any supported base. (Bug#8602)
a108c10b 10350
ad5f9eea
PE
10351 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10352
aec1708a
PE
10353 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10354 to match comment at start of function. This also removes a
10355 GCC warning about overflow in a 32+64-bit port.
10356
47be4ab5
PE
10357 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10358
371cac43
PE
10359 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10360 Reported by Stefan Monnier in
10361 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10362 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10363 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10364
d01a7826
PE
10365 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10366 (EMACS_UINTPTR): Likewise, with uintptr_t.
10367
7fd47d5c
PE
10368 * lisp.h: Prefer 64-bit EMACS_INT if available.
10369 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10370 on 32-bit hosts that have 64-bit int, so that they can access
10371 large files.
122b0c86
PE
10372 However, temporarily disable this change unless the temporary
10373 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10374
8727937b
PE
10375 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10376
8ac068ac
PE
10377 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10378 This removes an assumption that EMACS_INT and long are the same
10379 width as pointers. The assumption is true for Emacs porting targets
10380 now, but we want to make other targets possible.
10381 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10382 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10383 In the rest of the code, change types of integers that hold casted
10384 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10385 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10386 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10387 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10388 No need to cast type when ORing.
10389 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10390 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10391 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10392 assume EMACS_INT is the same width as char *.
10393 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10394 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10395 Remove no-longer-needed casts.
10396 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10397 (xg_tool_bar_help_callback, xg_make_tool_item):
10398 Use EMACS_INTPTR to hold an integer
10399 that will be cast to void *; this can avoid a GCC warning
10400 if EMACS_INT is not the same width as void *.
10401 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10402 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10403 (current_message_1, set_message_1):
10404 Use a local to convert to proper width without a cast.
10405 * xmenu.c (dialog_selection_callback): Likewise.
10406
ede49d71
PE
10407 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10408 Also, don't assume VALBITS / RAND_BITS is less than 5,
10409 and don't rely on undefined behavior when shifting a 1 left into
10410 the sign bit.
10411 * lisp.h (get_random): Change signature to match.
10412
2f30ecd0
PE
10413 * lread.c (hash_string): Use size_t, not int, for hash computation.
10414 Normally we prefer signed values; but hashing is special, because
10415 it's better to use unsigned division on hash table sizes so that
10416 the remainder is nonnegative. Also, size_t is the natural width
10417 for hashing into memory. The previous code used 'int', which doesn't
10418 retain enough info to hash well into very large tables.
10419 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10420
2a866e7b
PE
10421 * dbusbind.c: Don't possibly lose pointer info when converting.
10422 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10423 Use XPNTR rather than XHASH, so that the high-order bits of
10424 the pointer aren't lost when converting through void *.
10425
51639eac
PE
10426 * eval.c (Fautoload): Don't double-shift a pointer.
10427
92394119
PE
10428 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10429
dbdb9a7c
JB
104302011-05-06 Juanma Barranquero <lekktu@gmail.com>
10431
10432 * gnutls.c (DEF_GNUTLS_FN):
10433 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10434
db7a0b4f
AS
104352011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10436
10437 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10438 marker. (Bug#8610)
10439
cd394be1 104402011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10441
10442 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10443 New version that can reserve upto 2GB of heap space.
10444
f7ff1b0f 104452011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10446
10447 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10448
639c109b
TZ
104492011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10450
10451 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10452 `gnutls_certificate_set_x509_key_file'.
10453
d2127135
JB
104542011-05-05 Juanma Barranquero <lekktu@gmail.com>
10455
10456 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10457 Update dependencies.
10458
e968f4f3
JB
104592011-05-04 Juanma Barranquero <lekktu@gmail.com>
10460
10461 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10462 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10463 Remove unused parameter `fildes'.
10464 * process.c (read_process_output, send_process): Don't pass it.
10465
84d358f0
JB
104662011-05-04 Juanma Barranquero <lekktu@gmail.com>
10467
10468 Fix previous change: the library cache is defined in w32.c.
10469 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10470 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10471
0898ca10
JB
104722011-05-04 Juanma Barranquero <lekktu@gmail.com>
10473
10474 Implement dynamic loading of GnuTLS on Windows.
10475
10476 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10477 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10478 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10479 Declare.
10480
10481 * gnutls.c (Qgnutls_dll): Define.
10482 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10483 (gnutls_*): Declare function pointers.
10484 (init_gnutls_functions): New function to initialize function pointers.
10485 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10486 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10487 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10488 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10489 (emacs_gnutls_write, emacs_gnutls_read)
10490 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10491 (Fgnutls_available_p): New function.
10492 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10493 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10494 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10495
10496 * image.c: Include w32.h.
10497 (Vimage_type_cache): Delete.
10498 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10499 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10500 (w32_delayed_load): Move to w32.c.
10501
10502 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10503
10504 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10505 (w32_delayed_load): Move from image.c. When loading a library, record
10506 its filename in the :loaded-from property of the library id.
10507 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10508 Initialize and staticpro them.
10509 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10510
10511 * process.c: Include lisp.h before w32.h, not after.
10512 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10513 instead of gnutls_record_check_pending.
10514
10515 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10516
ff4de4aa
TZ
105172011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10518
10519 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10520 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10521 as passed in.
10522
abe95abb
JD
105232011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10524
10525 * xterm.c (x_set_frame_alpha): Do not set property on anything
10526 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10527
e16e55d4
JB
105282011-05-02 Juanma Barranquero <lekktu@gmail.com>
10529
10530 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10531
bafcf6a5
JB
105322011-05-02 Juanma Barranquero <lekktu@gmail.com>
10533
10534 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10535 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10536 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10537 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10538 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10539 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10540 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10541 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10542 (Qgnutls_bootprop_callbacks_verify): Make static.
10543
e7a6747f
AS
105442011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10545
19ed11ba
AS
10546 * callproc.c: Indentation fixup.
10547
e7a6747f 10548 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10549 (wait_for_termination, interruptible_wait_for_termination):
10550 Move after wait_for_termination_1.
e7a6747f 10551
1ef14cb4
LMI
105522011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10553
10554 * sysdep.c (interruptible_wait_for_termination): New function
10555 which is like wait_for_termination, but allows keyboard
10556 interruptions.
10557
10558 * callproc.c (Fcall_process): Add (:file "file") as an option for
10559 the STDOUT buffer.
10560 (Fcall_process_region): Ditto.
10561
330d880c
EZ
105622011-04-30 Eli Zaretskii <eliz@gnu.org>
10563
8db90b73
EZ
10564 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10565 rather than `XVECTOR (FOO)->size'.
10566
330d880c
EZ
10567 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10568 inttypes.h, as a gnulib replacement is used if it not available in
10569 system headers.
10570
15cbd324
EZ
105712011-04-21 Eli Zaretskii <eliz@gnu.org>
10572
10573 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10574 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10575 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10576
10577 * coding.c (coding_alloc_by_realloc): Error out if destination
10578 will grow beyond MOST_POSITIVE_FIXNUM.
10579 (decode_coding_emacs_mule): Abort if there isn't enough place in
10580 charbuf for the composition carryover bytes. Reserve an extra
10581 space for up to 2 characters produced in a loop.
10582 (decode_coding_iso_2022): Abort if there isn't enough place in
10583 charbuf for the composition carryover bytes.
10584
105852011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10586
ae940cca
EZ
10587 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10588 aborting when %lld or %lll format is passed.
10589 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10590 %llo or %llx format is passed. (Bug#8545)
10591
03ab8921
EZ
10592 * window.c (window_scroll_line_based): Use a marker instead of
10593 simple variables to record original value of point. (Bug#7952)
10594
afda1437
EZ
10595 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10596 produced by %s or %c overflows available buffer space. (Bug#8545)
10597
f76dee0c
PE
105982011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10599
10600 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10601 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10602
fdc5744d
JB
106032011-04-28 Juanma Barranquero <lekktu@gmail.com>
10604
10605 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10606
638f053a
JB
106072011-04-28 Juanma Barranquero <lekktu@gmail.com>
10608
10609 * keyboard.c (Qdelayed_warnings_hook): Define.
10610 (command_loop_1): Run `delayed-warnings-hook'
10611 if Vdelayed_warnings_list is non-nil.
10612 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10613 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10614
d178f871
EZ
106152011-04-28 Eli Zaretskii <eliz@gnu.org>
10616
10617 * doprnt.c (doprnt): Don't return value smaller than the buffer
10618 size if the message was truncated. (Bug#8545).
10619
b124fd93
JB
106202011-04-28 Juanma Barranquero <lekktu@gmail.com>
10621
10622 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10623 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10624
e810457d
PE
106252011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10626
10627 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10628
ea51cceb
JB
106292011-04-27 Juanma Barranquero <lekktu@gmail.com>
10630
10631 * makefile.w32-in: Update dependencies.
10632
94dcfacf
EZ
106332011-04-27 Eli Zaretskii <eliz@gnu.org>
10634
10635 Improve `doprnt' and its usage. (Bug#8545)
10636 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10637 `format_end'. Remove support for %l as a conversion specifier.
10638 Don't use xrealloc. Improve diagnostics when the %l size modifier
10639 is used. Update the commentary.
10640
10641 * eval.c (verror): Simplify calculation of size_t.
10642
10643 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10644 messages.
10645
f61f41d7
PE
106462011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10647
10648 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10649 change.
10650
96fb4434
PE
106512011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10652
10653 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10654 This makes this file independent of the recent pseudovector change.
10655
671875da 106562011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10657
69e9b5a3
PE
10658 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10659
b5f869a7 10660 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10661 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10662 Remove unused local.
c8926152 10663 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10664
841a1577 10665 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10666 GCC 4.6.0 optimizes based on type-based alias analysis.
10667 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10668 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10669 != &v->size, and therefore "v->size = 1; b->size = 2; return
10670 v->size;" must therefore return 1. This assumption is incorrect
10671 for Emacs, since it type-puns struct Lisp_Vector * with many other
10672 types. To fix this problem, this patch adds a new type struct
f904488f 10673 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10674 and pseudovectors, and helps optimizing compilers not get fooled
10675 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10676 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10677 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10678 the size member.
eab3844f
PE
10679 (XSETPVECTYPE): Rewrite in terms of new macro.
10680 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10681 This is a bit clearer, and further avoids the possibility of
10682 undesirable aliasing.
10683 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10684 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10685 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10686 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10687 (ASIZE): Now uses header.size rather than size.
10688 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10689 to avoid the hassle of writing XVECTOR (foo)->header.size.
10690 (struct vectorlike_header): New type.
eab3844f
PE
10691 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10692 object, to help avoid aliasing.
10693 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10694 (SUBRP): Likewise, since Lisp_Subr is a special case.
10695 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10696 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10697 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10698 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10699 changed to be "header.size" and "header.next".
10700 * buffer.h (struct buffer): Likewise.
10701 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10702 * frame.h (struct frame): Likewise.
10703 * process.h (struct Lisp_Process): Likewise.
10704 * termhooks.h (struct terminal): Likewise.
10705 * window.c (struct save_window_data, struct saved_window): Likewise.
10706 * window.h (struct window): Likewise.
10707 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10708 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10709 * buffer.c (init_buffer_once): Likewise.
10710 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10711 special case.
10712 * process.c (Fformat_network_address): Use local var for size,
10713 for brevity.
10714
0df1eac5
PE
10715 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10716
847ab9d1 10717 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10718 * data.c (atof): Remove decl; no longer used or needed.
10719 (digit_to_number): Move to lread.c.
10720 (Fstring_to_number): Use new string_to_number function, to be
10721 consistent with how the Lisp reader treats infinities and NaNs.
10722 Do not assume that floating-point numbers represent EMACS_INT
10723 without losing information; this is not true on most 64-bit hosts.
10724 Avoid double-rounding errors, by insisting on integers when
10725 parsing non-base-10 numbers, as the documentation specifies.
10726 * lisp.h (string_to_number): New decl, replacing ...
10727 (isfloat_string): Remove.
bc0a5c13 10728 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10729 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10730 appears to have been a coding error. Similarly, do not accept
10731 strings like +-1e0 as floating point numbers. Do not report
10732 overflow for integer overflows unless the base is not 10 which
10733 means we have no simple and reliable way to continue.
10734 Break out the floating-point parsing into a new
10735 function string_to_number, so that Fstring_to_number parses
10736 floating point numbers consistently with the Lisp reader.
04f2d78b 10737 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10738 (E_CHAR, EXP_INT): Remove, replacing with ...
10739 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10740 (string_to_number): New function, replacing isfloat_string.
10741 This function checks for valid syntax and produces the resulting
10742 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10743 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10744 so that overflow for non-base-10 numbers is reported only when
10745 there's no portable and simple way to convert to floating point.
452f4150 10746
67769ffc
PE
10747 * textprop.c (set_text_properties_1): Rewrite for clarity,
10748 and to avoid GCC warning about integer overflow.
10749
c20db43f
PE
10750 * intervals.h (struct interval): Use EMACS_INT for members
10751 where EMACS_UINT might cause problems. See
10752 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10753 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10754 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10755 All uses changed.
37aa2f85
PE
10756 (offset_intervals): Tell GCC not to worry about length overflow
10757 when negating a negative length.
c20db43f 10758
2538aa2f
PE
10759 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10760 (overrun_check_free): Likewise.
10761
f2d3008d
PE
10762 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10763 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10764 word size.
10765
ec8df744
PE
10766 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10767 (gnutls_make_error): Rename local to avoid shadowing.
10768 (gnutls_emacs_global_deinit): ifdef out; not used.
10769 (Fgnutls_boot): Use const for pointer to readonly storage.
10770 Comment out unused local. Fix pointer signedness problems.
10771
640ee02d
PE
10772 * lread.c (openp): Don't stuff size_t into an 'int'.
10773 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10774 about possible signed overflow.
10775
6048fb2a
PE
10776 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10777 (GDK_KEY_g): Don't define if already defined.
10778 (xg_prepare_tooltip): Avoid pointer signedness problem.
10779 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10780
fa3c87e1
PE
10781 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10782 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10783
2172544b
PE
10784 * xfns.c (Fx_window_property): Simplify a bit,
10785 to make a bit faster and to avoid GCC 4.6.0 warning.
10786 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10787
9b821a21
PE
10788 * fns.c (internal_equal): Don't assume size_t fits in int.
10789
3c616cfa
PE
10790 * alloc.c (compact_small_strings): Tighten assertion a little.
10791
c2982e87
PE
10792 Replace pEd with more-general pI, and fix some printf arg casts.
10793 * lisp.h (pI): New macro, generalizing old pEd macro to other
10794 conversion specifiers. For example, use "...%"pI"d..." rather
10795 than "...%"pEd"...".
10796 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10797 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10798 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10799 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10800 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10801 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10802 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10803 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10804 64-bit hosts.
10805 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10806 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10807 * print.c (safe_debug_print, print_object): Likewise.
10808 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10809 to int.
6f04d126
PE
10810 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10811 avoiding the 0 flag, which is not portable.
c2982e87
PE
10812 * process.c (Fmake_network_process): Use pI to avoid cast.
10813 * region-cache.c (pp_cache): Likewise.
10814 * xdisp.c (decode_mode_spec): Likewise.
10815 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10816 behavior on 64-bit hosts with printf arg.
6f04d126 10817 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10818 (x_stop_queuing_selection_requests): Likewise.
10819 (x_get_window_property): Don't truncate byte count to an 'int'
10820 when tracing.
0b432f21 10821
5e073ec7
PE
10822 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10823 here, since it parses constructs like leading '-' and spaces,
10824 which are not wanted; and it overflows with large numbers.
10825 Instead, simply match F[0-9]+, which is what is wanted anyway.
10826
36372bf9
PE
10827 * alloc.c: Remove unportable assumptions about struct layout.
10828 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10829 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10830 (allocate_vectorlike, make_pure_vector): Use the new macros,
10831 plus offsetof, to remove unportable assumptions about struct layout.
10832 These assumptions hold on all porting targets that I know of, but
10833 they are not guaranteed, they're easy to remove, and removing them
10834 makes further changes easier.
10835
0b432f21
PE
10836 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10837 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10838 (string_overrun_cookie): Now const. Use initializers that
10839 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10840 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10841 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10842 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10843 multiple of sizeof (EMACS_INT); it need not be, if
10844 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10845 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10846
895009e1
JB
108472011-04-26 Juanma Barranquero <lekktu@gmail.com>
10848
10849 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10850
6a7a1b0b
TZ
108512011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10852
10853 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10854 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10855 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10856
841a1577 108572011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10858
10859 * lisp.h (Qdebug): List symbol.
895009e1 10860 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10861 * keyboard.c (debug-on-event): New variable.
10862 (handle_user_signal): Break into debugger when debug-on-event
10863 matches the current signal symbol.
10864
f2d3ba6f
DN
108652011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10866
10867 * alloc.c (check_sblock, check_string_bytes)
10868 (check_string_free_list): Convert to standard C.
10869
42ce4c63
TZ
108702011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10871
10872 * w32.c (emacs_gnutls_push): Fix typo.
10873
825cd63c
EZ
108742011-04-25 Eli Zaretskii <eliz@gnu.org>
10875
fb11d64d
EZ
10876 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10877 "cast to pointer from integer of different size".
10878
825cd63c
EZ
10879 Improve doprnt and its use in verror. (Bug#8545)
10880 * doprnt.c (doprnt): Document the set of format control sequences
10881 supported by the function. Use SAFE_ALLOCA instead of always
10882 using `alloca'.
10883
10884 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10885 is one byte too soon. Don't use xrealloc; instead xfree and
10886 xmalloc anew.
10887
e061a11b
TZ
108882011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10889
10890 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10891 callbacks stage.
10892
10893 * gnutls.c: Renamed global_initialized to
10894 gnutls_global_initialized. Added internals for the
10895 :verify-hostname-error, :verify-error, and :verify-flags
10896 parameters of `gnutls-boot' and documented those parameters in the
10897 docstring. Start callback support.
9173deec
JB
10898 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10899 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10900 on error. Return error code.
e061a11b
TZ
10901 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10902 (emacs_gnutls_read): Likewise.
10903 (Fgnutls_boot): Return handshake error code.
10904 (emacs_gnutls_handle_error): New function.
10905 (wsaerror_to_errno): Likewise.
10906
10907 * w32.h (emacs_gnutls_pull): Add prototype.
10908 (emacs_gnutls_push): Likewise.
10909
10910 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10911 (emacs_gnutls_push): Likewise.
10912
109132011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10914
10915 * process.c (wait_reading_process_output): Check if GnuTLS
10916 buffered some data internally if no FDs are set for TLS
10917 connections.
10918
10919 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10920 (LIBS): Link to USER_LIBS.
10921 ($(BLD)/gnutls.$(0)): New target.
10922
fa6996bc
EZ
109232011-04-24 Eli Zaretskii <eliz@gnu.org>
10924
eb35682e
EZ
10925 * xdisp.c (handle_single_display_spec): Rename the
10926 display_replaced_before_p argument into display_replaced_p, to
10927 make it consistent with the commentary. Fix typos in the
10928 commentary.
10929
e2ad650c
EZ
10930 * textprop.c (syms_of_textprop): Remove dead code.
10931 (copy_text_properties): Delete obsolete commentary about an
10932 interface that was deleted long ago. Fix typos in the description
10933 of arguments.
10934
1b2de274
EZ
10935 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10936 to changes in oldXMenu/XMenu.h from 2011-04-16.
10937 <menu_help_message, prev_menu_help_message>: Constify.
10938 (IT_menu_make_room): menu->help_text is now `const char **';
10939 adjust.
10940
10941 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10942 to changes in oldXMenu/XMenu.h from 2011-04-16.
10943 (struct XMenu): Declare `help_text' `const char **'.
10944
10945 * xfaces.c <Qunspecified>: Make extern again.
10946
10947 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10948 required by POSIX.
1b2de274 10949
762b15be
EZ
10950 * doc.c (get_doc_string): Improve the format passed to `error'.
10951
10952 * doprnt.c (doprnt): Improve commentary.
10953
10954 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10955
10956 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10957 them with etags.
10958
f1052e5d
EZ
10959 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10960 changes in globals.h immediately force recompilation.
762b15be
EZ
10961 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10962 $(CURDIR)/s/ms-w32.h.
10963 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10964
fa6996bc
EZ
10965 * character.c (Fchar_direction): Function deleted.
10966 (syms_of_character): Don't defsubr it.
10967 <char-direction-table>: Deleted.
10968
e6c3da20
EZ
109692011-04-23 Eli Zaretskii <eliz@gnu.org>
10970
10971 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10972 * doprnt.c: Include limits.h.
10973 (SIZE_MAX): New macro.
04f2d78b
CB
10974 (doprnt): Return a size_t value. 2nd arg is now size_t.
10975 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10976 Improve overflow protection. Support `l' modifier for integer
10977 conversions. Support %l conversion. Don't assume an EMACS_INT
10978 argument for integer conversions and for %c.
10979
10980 * lisp.h (doprnt): Restore prototype.
10981
10982 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10983 $(SRC)/character.h.
10984
10985 * Makefile.in (base_obj): Add back doprnt.o.
10986
10987 * deps.mk (doprnt.o): Add back prerequisites.
10988 (callint.o): Depend on character.h.
10989
10990 * eval.c (internal_lisp_condition_case): Include the handler
10991 representation in the error message.
10992 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10993 when breaking from the loop.
10994
10995 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10996
10997 * callint.c (Fcall_interactively): When displaying error message
10998 about invalid control letter, pass the character's codepoint, not
10999 a pointer to its multibyte form. Improve display of the character
11000 in octal and display also its hex code.
11001
11002 * character.c (char_string): Use %x to display the (unsigned)
11003 codepoint of an invalid character, to avoid displaying a bogus
11004 negative value.
11005
11006 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11007 `error', not SYMBOL_NAME itself.
11008
11009 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11010 character arguments to `error'.
11011
11012 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11013 to `error' in error message about FINAL_CHAR argument. Make sure
11014 FINAL_CHAR is a character, and use %c when it is passed as
11015 argument to `error'.
11016
4ffd0d6b 110172011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11018
11019 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11020
11021 * w32.c: Include <time.h>.
11022 (sys_localtime): New function.
11023
4ffd0d6b 110242011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11025
11026 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11027
4ffd0d6b 11028 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11029
4ffd0d6b 110302011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11031
4ffd0d6b
GM
11032 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11033 zombies (Bug#8467).
aac0c6e3 11034
04c56954
EZ
110352011-04-19 Eli Zaretskii <eliz@gnu.org>
11036
11037 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11038 gl_state.e_property when gl_state.object is Qt.
11039
11040 * insdel.c (make_gap_larger): Remove limitation of buffer size
11041 to <= INT_MAX.
11042
16a43933
CY
110432011-04-18 Chong Yidong <cyd@stupidchicken.com>
11044
11045 * xdisp.c (lookup_glyphless_char_display)
11046 (produce_glyphless_glyph): Handle cons cell entry in
11047 glyphless-char-display.
11048 (Vglyphless_char_display): Document it.
11049
11050 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11051 glyphless-char-display.
11052
4581706e
CY
110532011-04-17 Chong Yidong <cyd@stupidchicken.com>
11054
11055 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11056
11057 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11058
11059 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11060 definition for no-X builds.
11061
4887c6e2 110622011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11063
fd35b6f9
PE
11064 Static checks with GCC 4.6.0 and non-default toolkits.
11065
5c1ccb01
PE
11066 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11067
006c5daa
PE
11068 * process.c (keyboard_bit_set): Define only if SIGIO.
11069 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11070 (send_process): Repair possible setjmp clobbering.
11071
efc736d3
PE
11072 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11073
4e2fe2e6
PE
11074 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11075
f97334a2
PE
11076 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11077
4e75f29d
PE
11078 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11079 Define only if needed.
11080
90efadd1
PE
11081 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11082 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11083 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11084
3c647824
PE
11085 * dispextern.h (struct redisplay_interface): Rename param
11086 to avoid shadowing.
e264f262 11087 * termhooks.h (struct terminal): Likewise.
761383f4 11088 * xterm.c (xembed_send_message): Likewise.
3c647824 11089
b58c5c4a
PE
11090 * insdel.c (make_gap_smaller): Define only if
11091 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11092
cad59032
PE
11093 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11094 it.
11095
c339dc2e
PE
11096 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11097 so that we aren't warned about unused symbols.
11098
91a3e27b
PE
11099 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11100
399c71d3 11101 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11102
8ffc96f5
PE
11103 * xfns.c (x_real_positions): Mark locals as initialized.
11104
eef9bc79
PE
11105 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11106
098db9dd
PE
11107 * xterm.c: Fix problems found by static analysis with other toolkits.
11108 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11109 (x_dispatch_event): Declare static if USE_GTK, and
11110 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11111 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11112 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11113 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11114 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11115
eb18f6cc
PE
11116 * xmenu.c (menu_help_callback): Pointer type fixes.
11117 Use const pointers when pointing at readonly data. Avoid pointer
11118 signedness clashes.
11119 (FALSE): Remove unused macro.
11120 (update_frame_menubar): Remove unused decl.
11121
1fe72bf8
PE
11122 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11123
60d9e1db
PE
11124 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11125 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11126 (single_menu_item): Rename local to avoid shadowing.
11127
39261c26
PE
11128 * keyboard.c (make_lispy_event): Remove unused local var.
11129
018c5e19
PE
11130 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11131 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11132
63d2b86e
PE
11133 * bitmaps: Change bitmaps from unsigned char back to the X11
11134 compatible char. Avoid the old compiler warnings about
11135 out-of-range initializers by using, for example, '\xab' rather
11136 than 0xab.
11137
aefd87e1
PE
11138 * xgselect.c (xgselect_initialize): Check vs interface
11139 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11140
bf501fb9
PE
11141 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11142
e9829fdf
PE
11143 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11144 to read-only memory.
11145
1086c095
PE
11146 * fns.c (vector): Remove; this old hack is no longer needed.
11147
2baccd04 11148 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11149 Remove unused var.
dde42981 11150 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11151
72391843 11152 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11153
436c16df 11154 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11155 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11156 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11157
92bb796d 11158 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11159 (x_term_init): Remove local to avoid shadowing.
92bb796d 11160
764430a3 11161 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11162
11163 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11164 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11165
d1dfb56c
EZ
111662011-04-16 Eli Zaretskii <eliz@gnu.org>
11167
c4354cb4
EZ
11168 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11169
d1dfb56c
EZ
11170 Fix regex.c, syntax.c and friends for buffers > 2GB.
11171 * syntax.h (struct gl_state_s): Declare character position members
11172 EMACS_INT.
11173
11174 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11175
04f2d78b
CB
11176 * textprop.c (verify_interval_modification, interval_of):
11177 Declare arguments EMACS_INT.
d1dfb56c
EZ
11178
11179 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11180 EMACS_INT.
11181
11182 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11183
11184 * indent.c (Fvertical_motion): Local variable it_start is now
11185 EMACS_INT.
11186
11187 * regex.c (re_match, re_match_2, re_match_2_internal)
11188 (bcmp_translate, regcomp, regexec, print_double_string)
11189 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11190 (re_compile_pattern, re_exec): Declare arguments and local
11191 variables `size_t' and `ssize_t' and return values `regoff_t', as
11192 appropriate.
11193 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11194 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11195 <compile_stack_type>: `size' and `avail' are now `size_t'.
11196
11197 * regex.h <regoff_t>: Use ssize_t, not int.
11198 (re_search, re_search_2, re_match, re_match_2): Arguments that
11199 specify buffer/string position and length are now ssize_t and
11200 size_t. Return type is regoff_t.
11201
613052cd
BK
112022011-04-16 Ben Key <bkey76@gmail.com>
11203
11204 * nsfont.m: Fixed bugs in ns_get_family and
11205 ns_descriptor_to_entity that were caused by using free to
11206 deallocate memory blocks that were allocated by xmalloc (via
11207 xstrdup). This caused Emacs to crash when compiled with
11208 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11209 --enable-checking=xmallocoverrun). xfree is now used to
11210 deallocate these memory blocks.
11211
4170f62f 112122011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11213
71b41406
PE
11214 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11215
9587a89d
PE
11216 emacs_write: Accept and return EMACS_INT for sizes.
11217 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11218 et seq.
11219 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11220 Accept and return EMACS_INT.
11221 (emacs_gnutls_write): Return the number of bytes written on
11222 partial writes.
11223 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11224 (emacs_read, emacs_write): Remove check for negative size, as the
11225 Emacs source code has been audited now.
9587a89d
PE
11226 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11227 (emacs_read, emacs_write): Use it.
273a5f82
PE
11228 * process.c (send_process): Adjust to the new signatures of
11229 emacs_write and emacs_gnutls_write. Do not attempt to store
11230 a byte offset into an 'int'; it might overflow.
9587a89d 11231 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11232
3e047f51
PE
11233 * sound.c: Don't assume sizes fit in 'int'.
11234 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11235 Return EMACS_INT, not int.
3e047f51 11236 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11237 Accept EMACS_INT, not int.
11238 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11239 record read return values.
11240
cc39a9db
BK
112412011-04-15 Ben Key <bkey76@gmail.com>
11242
c9d0ec6d
JB
11243 * keyboard.c (Qundefined): Don't declare static since it is used
11244 in nsfns.m.
11245 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11246 static since they are used in nsfont.m.
cc39a9db 11247
6c60eb9f
SM
112482011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11249
11250 * process.c (Qprocessp): Don't declare static.
11251 * lisp.h (Qprocessp): Declare again.
11252
7990b61a
JB
112532011-04-15 Juanma Barranquero <lekktu@gmail.com>
11254
11255 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11256
5d4cb038
PE
112572011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11258
8bd7b830 11259 Improve C-level modularity by making more things 'static'.
cd64ea1d 11260
e3b27b31
PE
11261 Don't publish debugger-only interfaces to other modules.
11262 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11263 (verify_bytepos, count_markers): Move decls to the only modules
11264 that need them.
11265 * region-cache.h (pp_cache): Likewise.
11266 * window.h (check_all_windows): Likewise.
11267 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11268
5d4cb038
PE
11269 * sysdep.c (croak): Now static, if
11270 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11271 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11272
11273 * alloc.c (refill_memory_reserve): Now static if
11274 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11275 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11276
e87b6180
PE
11277 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11278 Define only if USE_LUCID.
11279
ac64929e
PE
11280 * xrdb.c (x_customization_string, x_rm_string): Now static.
11281
6f37259d
PE
11282 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11283 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11284
1683e3ab
PE
11285 * xdisp.c (draw_row_with_mouse_face): Now static.
11286 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11287
de9c2632
PE
11288 * window.h (check_all_windows): Mark externally visible.
11289
2b96acb7
PE
11290 * window.c (window_deletion_count): Now static.
11291
11292 * undo.c: Make symbols static if they're not exported.
11293 (last_undo_buffer, last_boundary_position, pending_boundary):
11294 Now static.
11295
50436f33
PE
11296 * textprop.c (interval_insert_behind_hooks): Now static.
11297 (interval_insert_in_front_hooks): Likewise.
11298
64520e5c
PE
11299 * term.c: Make symbols static if they're not exported.
11300 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11301 (max_frame_lines, tty_set_terminal_modes):
11302 (tty_reset_terminal_modes, tty_turn_off_highlight):
11303 (get_tty_terminal): Now static.
11304 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11305 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11306 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11307 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11308 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11309
1fa53021
PE
11310 * sysdep.c: Make symbols static if they're not exported.
11311 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11312 Now static.
11313 (sigprocmask_set, full_mask): Remove; unused.
11314 (wait_debugging): Mark as visible.
11315 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11316 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11317
d4b43b22
PE
11318 * syntax.c (syntax_temp): Define only if !__GNUC__.
11319
b7c513d0
PE
11320 * sound.c (current_sound_device, current_sound): Now static.
11321
989b29ad
PE
11322 * search.c (searchbufs, searchbuf_head): Now static.
11323
13a55a78
PE
11324 * scroll.c (scroll_cost): Remove; unused.
11325 * dispextern.h (scroll_cost): Remove decl.
11326
de68a1fc
PE
11327 * region-cache.h (pp_cache): Mark as externally visible.
11328
40ccffa6
PE
11329 * process.c: Make symbols static if they're not exported.
11330 (process_tick, update_tick, create_process, chan_process):
11331 (Vprocess_alist, proc_buffered_char, datagram_access):
11332 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11333 (deactivate_process): Mark defn as static, as well as decl.
11334 * lisp.h (create_process): Remove decl.
11335 * process.h (chan_process, Vprocess_alist): Remove decls.
11336
ad64fc97
PE
11337 * print.c: Make symbols static if they're not exported.
11338 (print_depth, new_backquote_output, being_printed, print_buffer):
11339 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11340 (print_interval, print_number_index, initial_stderr_stream):
11341 Now static.
11342 * lisp.h (Fprinc): Remove decl.
11343 (debug_output_compilation_hack): Mark as externally visible.
11344
adddb265
PE
11345 * sysdep.c (croak): Move decl from here to syssignal.h.
11346 * syssignal.h (croak): Put it here, so the API can be checked when
11347 'croak' is called from dissociate_if_controlling_tty.
11348
1717ede2
PE
11349 * minibuf.c: Make symbols static if they're not exported.
11350 (minibuf_save_list, choose_minibuf_frame): Now static.
11351 * lisp.h (choose_minibuf_frame): Remove decl.
11352
fa5fb2bc
PE
11353 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11354
1e3890d1
PE
11355 * lread.c: Make symbols static if they're not exported.
11356 (read_objects, initial_obarray, oblookup_last_bucket_number):
11357 Now static.
11358 (make_symbol): Remove; unused.
11359 * lisp.h (initial_obarray, make_symbol): Remove decls.
11360
8a1414fa
PE
11361 * keyboard.c: Make symbols static if they're not exported.
11362 (single_kboard, recent_keys_index, total_keys, recent_keys):
11363 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11364 (this_single_command_key_start, echoing, last_auto_save):
11365 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11366 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11367 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11368 (Vlispy_mouse_stem, double_click_count):
11369 Now static.
11370 (force_auto_save_soon): Define only if SIGDANGER.
11371 (ignore_mouse_drag_p): Now static if
11372 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11373 (print_help): Remove; unused.
11374 (stop_character, last_timer_event): Mark as externally visible.
11375 * keyboard.h (ignore_mouse_drag_p): Declare only if
11376 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11377 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11378 * lisp.h (echoing): Remove decl.
11379 (force_auto_save_soon): Declare only if SIGDANGER.
11380 * xdisp.c (redisplay_window): Simplify code, to make it more
11381 obvious that ignore_mouse_drag_p is not accessed if !defined
11382 USE_GTK && !defined HAVE_NS.
11383
93ea6e8f
PE
11384 * intervals.c: Make symbols static if they're not exported.
11385 (merge_properties_sticky, merge_interval_right, delete_interval):
11386 Now static.
11387 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11388
77382fcc
PE
11389 * insdel.c: Make symbols static if they're not exported.
11390 However, leave prepare_to_modify_buffer alone. It's never
11391 called from outside this function, but that appears to be a bug.
11392 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11393 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11394 (adjust_after_replace_noundo): Remove; unused.
11395 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11396 (signal_before_change): Remove decls.
77382fcc 11397
9306c32e
PE
11398 * indent.c (val_compute_motion, val_vmotion): Now static.
11399
cd44d2eb
PE
11400 * image.c: Make symbols static if they're not exported.
11401 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11402 if USE_GTK.
11403 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11404 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11405
ad9a7a06
PE
11406 * fringe.c (standard_bitmaps): Now static.
11407 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11408
81626931
PE
11409 * frame.c: Make symbols static if they're not exported.
11410 (x_report_frame_params, make_terminal_frame): Now static.
11411 (get_frame_param): Now static, unless HAVE_NS.
11412 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11413 (x_get_resource_string): Remove; not used.
11414 * frame.h (make_terminal_frame, x_report_frame_params):
11415 (x_get_resource_string); Remove decls.
11416 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11417 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11418
239f9db9
PE
11419 * font.c, fontset.c: Make symbols static if they're not exported.
11420 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11421 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11422 * font.c (font_close_object): Now static.
11423 * font.h (font_close_object): Remove.
11424 * fontset.c (FONTSET_OBJLIST): Remove.
11425 (free_realized_fontset) #if-0 the body, which does nothing.
11426 (face_suitable_for_char_p): #if-0, as it's never called.
11427 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11428 * xfaces.c (face_at_string_position):
11429 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11430 since 0 is always ASCII.
11431
dfcf3579
PE
11432 * fns.c (weak_hash_tables): Now static.
11433
5045092b
PE
11434 * fileio.c: Make symbols static if they're not exported.
11435 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11436 (Vwrite_region_annotation_buffers): Now static.
11437
57a96f5c
PE
11438 * eval.c: Make symbols static if they're not exported.
11439 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11440 * lisp.h (backtrace_list): Remove decl.
11441
35f08c38
PE
11442 * emacs.c: Make symbols static if they're not exported.
11443 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11444 (fatal_error_code, fatal_error_signal_hook, standard_args):
11445 Now static.
11446 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11447 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11448 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11449 * lisp.h (fatal_error_signal_hook): Remove decl.
11450 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11451
f44bd759
PE
11452 * editfns.c: Move a (normally-unused) function to its only use.
11453 * editfns.c, lisp.h (get_operating_system_release): Remove.
11454 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11455 worth the hassle of breaking this out.
11456
b532497d
PE
11457 * xterm.c: Make symbols static if they're not exported.
11458 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11459 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11460 (x_destroy_window, x_delete_display):
11461 Now static.
11462 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11463 (x_mouse_leave): Remove; unused.
11464 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11465 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11466 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11467 Remove decls.
11468 (x_mouse_leave): Declare only if WINDOWSNT.
11469 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11470 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11471 USE_X_TOOLKIT.
11472
1675728f
PE
11473 * ftxfont.c: Make symbols static if they're not exported.
11474 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11475 HAVE_FREETYPE.
11476 * font.h (ftxfont_driver): Likewise.
11477
e4cebfca
PE
11478 * xfns.c: Make symbols static if they're not exported.
11479 (x_last_font_name, x_display_info_for_name):
11480 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11481 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11482 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11483 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11484 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11485 (last_show_tip_args): Now static.
11486 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11487 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11488 (x_screen_planes): Remove; unused.
11489 * dispextern.h (x_screen_planes): Remove decl.
11490
5bf46f05
PE
11491 * dispnew.c: Make symbols static if they're not exported.
11492 * dispextern.h (redraw_garbaged_frames, scrolling):
11493 (increment_row_positions): Remove.
11494 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11495 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11496 Now static.
11497 (redraw_garbaged_frames): Remove; unused.
11498
435f4c28
PE
11499 * xfaces.c: Make symbols static if they're not exported.
11500 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11501 Remove decls.
11502 * xterm.h (defined_color): Remove decls.
11503 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11504 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11505 (menu_face_changed_default, defined_color, free_realized_face):
11506 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11507 (ascii_face_of_lisp_face): Remove; unused.
11508
8524aef3
PE
11509 * xdisp.c: Make symbols static if they're not exported.
11510 * dispextern.h (scratch_glyph_row, window_box_edges):
11511 (glyph_to_pixel_coords, set_cursor_from_row):
11512 (get_next_display_element, set_iterator_to_next):
11513 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11514 (show_mouse_face): Remove decls
11515 * frame.h (message_buf_print): Likewise.
11516 * lisp.h (pop_message, set_message, check_point_in_composition):
11517 Likewise.
11518 * xterm.h (set_vertical_scroll_bar): Likewise.
11519 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11520 (message_buf_print, scratch_glyph_row, displayed_buffer):
11521 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11522 (get_next_display_element, show_mouse_face, window_box_edges):
11523 (frame_to_window_pixel_xy, check_point_in_composition):
11524 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11525 (glyph_to_pixel_coords): Remove; unused.
11526
16390cd2
PE
11527 * dired.c (file_name_completion): Now static.
11528
11529 * dbusbind.c (xd_in_read_queued_messages): Now static.
11530
a25f4dfa
PE
11531 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11532 * data.c (circular_list_error): Remove.
11533
14a9c8df
PE
11534 * commands.h (last_point_position, last_point_position_buffer):
11535 (last_point_position_window): Remove decls.
11536 * keyboard.c: Make these variables static.
11537
04f2d78b
CB
11538 * coding.h (coding, code_convert_region, encode_coding_gap):
11539 Remove decls.
74ab6df5
PE
11540 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11541 (iso_code_class, detect_coding, code_convert_region): Now static.
11542 (encode_coding_gap): Remove; unused.
11543
38dfbee1
PE
11544 * chartab.c (chartab_chars, chartab_bits): Now static.
11545
a2cb4e63
PE
11546 * charset.h (charset_iso_8859_1): Remove decl.
11547 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11548 Now static.
11549
127198fd
PE
11550 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11551 * ccl.c (Vccl_program_table): Now static.
11552 (check_ccl_update): Remove; unused.
11553
d85b608f
PE
11554 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11555 * category.h: ... from here.
11556 * category.c (check_category_table, set_category_set): Now static.
11557
31cd66f3
PE
11558 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11559 * lisp.h: Remove these decls.
11560
c358e587
PE
11561 * buffer.c (buffer_count): Remove unused var.
11562
e78aecca
PE
11563 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11564 so that it's not optimized away.
11565 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11566 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11567 exported only to the debugger.
11568
e192d7d3 11569 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11570 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11571
92470028
PE
11572 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11573 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11574 was inaccessible from Lisp.
11575 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11576 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11577
244ed907
PE
11578 alloc.c: Import and export fewer symbols, and remove unused items.
11579 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11580 is defined.
11581 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11582 it's not optimized away by whole-program optimization.
11583 (message_enable_multibyte, free_misc): Remove.
11584 (catchlist, handlerlist, mark_backtrace):
11585 Declare only if BYTE_MARK_STACK.
11586 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11587 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11588 (message_enable_multibyte): Remove decl.
11589 (free_misc, interval_free_list, float_block, float_block_index):
11590 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11591 (cons_free_list, last_marked_index):
11592 Now static.
11593 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11594 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11595 (mark_backtrace): Define only if BYTE_MARK_STACK.
11596 * xdisp.c (message_enable_multibyte): Now static.
11597
61c2b50e 11598 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11599 This makes it easier for human readers (and static analyzers)
11600 to see whether these variables are used from other modules.
11601 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11602 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11603 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11604 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11605 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11606 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11607 * xmenu.c, xselect.c:
11608 Declare Q* vars static if they are not used in other modules.
11609 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11610 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11611 Remove decls of unexported vars.
11612 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11613
95c82688
PE
11614 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11615
16a97296
PE
11616 Make Emacs functions such as Fatom 'static' by default.
11617 This makes it easier for human readers (and static analyzers)
11618 to see whether these functions can be called from other modules.
11619 DEFUN now defines a static function. To make the function external
11620 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11621 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11622 (Finit_image_library):
16a97296
PE
11623 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11624 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11625 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11626 Remove decls, since these functions are now static.
11627 (Funintern, Fget_internal_run_time): New decls, since these functions
11628 were already external.
95c82688 11629
16a97296
PE
11630 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11631 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11632 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11633 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11634 * keyboard.c, keymap.c, lread.c:
11635 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11636 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11637 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11638 Mark functions with DEFUE instead of DEFUN,
11639 if they are used in other modules.
11640 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11641 decls for now-static functions.
11642 * buffer.h (Fdelete_overlay): Remove decl.
11643 * callproc.c (Fgetenv_internal): Mark as internal.
11644 * composite.c (Fremove_list_of_text_properties): Remove decl.
11645 (Fcomposition_get_gstring): New forward static decl.
11646 * composite.h (Fcomposite_get_gstring): Remove decl.
11647 * dired.c (Ffile_attributes): New forward static decl.
11648 * doc.c (Fdocumntation_property): New forward static decl.
11649 * eval.c (Ffetch_bytecode): New forward static decl.
11650 (Funintern): Remove extern decl; now in .h file where it belongs.
11651 * fileio.c (Fmake_symbolic_link): New forward static decl.
11652 * image.c (Finit_image_library): New forward static decl.
11653 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11654 * intervals.h (Fprevious_property_change):
11655 (Fremove_list_of_text_properties): Remove decls.
11656 * keyboard.c (Fthis_command_keys): Remove decl.
11657 (Fcommand_execute): New forward static decl.
11658 * keymap.c (Flookup_key): New forward static decl.
11659 (Fcopy_keymap): Now static.
11660 * keymap.h (Flookup_key): Remove decl.
11661 * process.c (Fget_process): New forward static decl.
11662 (Fprocess_datagram_address): Mark as internal.
11663 * syntax.c (Fsyntax_table_p): New forward static decl.
11664 (skip_chars): Remove duplicate decl.
11665 * textprop.c (Fprevious_property_change): New forward static decl.
11666 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11667 Now internal.
11668 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11669 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11670
785bbd42
PE
11671 * editfns.c (Fformat): Remove unreachable code.
11672
8b913b57
AS
116732011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11674
11675 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11676 change. (Bug#8496)
11677
a6744a35
EZ
116782011-04-13 Eli Zaretskii <eliz@gnu.org>
11679
11680 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11681 when at ZV. (Bug#8487)
11682
e7974947
AS
116832011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11684
baad03f0
AS
11685 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11686 (Bug#8437)
11687 * keyboard.c (parse_tool_bar_item): Likewise.
11688 * sound.c (sound_cleanup, alsa_close): Likewise.
11689 * termcap.c (tgetent): Likewise.
11690 * xfns.c (x_default_font_parameter): Likewise.
11691 * xsettings.c (read_and_apply_settings): Likewise.
11692
e7974947
AS
11693 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11694 (overrun_check_free): Protoize.
11695
28272684
PE
116962011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11697
11698 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11699 since callers should never pass a negative size.
11700 Change the signature to match that of plain 'read' and 'write'; see
11701 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11702 * lisp.h: Update prototypes of emacs_write and emacs_read.
11703
11997c76
EZ
117042011-04-11 Eli Zaretskii <eliz@gnu.org>
11705
11706 * xdisp.c (redisplay_window): Don't try to determine the character
11707 position of the scroll margin if the window start point w->startp
e896f03c 11708 is outside the buffer's accessible region. (Bug#8468)
11997c76 11709
8a2cbd72
EZ
117102011-04-10 Eli Zaretskii <eliz@gnu.org>
11711
11712 Fix write-region and its subroutines for buffers > 2GB.
11713 * fileio.c (a_write, e_write): Modify declaration of arguments and
11714 local variables to support buffers larger than 2GB.
11715 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11716
11717 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11718 argument, local variables, and return value.
11719
11720 * lisp.h: Update prototypes of emacs_write and emacs_read.
11721
11722 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11723
4073e537 117242011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11725
1ebfdcb6
PE
11726 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11727
b2ded58d
PE
11728 Fix more problems found by GCC 4.6.0's static checks.
11729
7d66342c
PE
11730 * xdisp.c (vmessage): Use a better test for character truncation.
11731
bbf47d44
PE
11732 * charset.c (load_charset_map): <, not <=, for optimization,
11733 and to avoid potential problems with integer overflow.
9248994d 11734 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11735 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11736 * editfns.c (Fformat): Likewise.
1e69125e 11737 * syntax.c (skip_chars): Likewise.
3befa583 11738
e3019616
PE
11739 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11740 This also lets GCC 4.6.0 generate slightly better loop code.
11741
becfa255
PE
11742 * callint.c (Fcall_interactively): <, not <=, for optimization.
11743 (Fcall_interactively): Count the number of arguments produced,
11744 not the number of arguments given. This is simpler and lets GCC
11745 4.6.0 generate slightly better code.
11746
dae0cd48
PE
11747 * ftfont.c: Distingish more carefully between FcChar8 and char.
11748 The previous code passed unsigned char * to a functions like
11749 strlen and xstrcasecmp that expect char *, which does not
11750 conform to the C standard.
11751 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11752 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11753 char * when the C standard requires it.
11754
76032d70
PE
11755 * keyboard.c (read_char): Remove unused var.
11756
eb3f1cc8
PE
11757 * eval.c: Port to Windows vsnprintf (Bug#8435).
11758 Include <limits.h>.
11759 (SIZE_MAX): Define if the headers do not.
11760 (verror): Do not give up if vsnprintf returns a negative count.
11761 Instead, grow the buffer. This ports to Windows vsnprintf, which
11762 does not conform to C99. Problem reported by Eli Zaretskii.
11763 Also, simplify the allocation scheme, by avoiding the need for
11764 calling realloc, and removing the ALLOCATED variable.
11765
70476b54
PE
11766 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11767
12020a9e
PE
11768 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11769 But keep the doprint source code for now, as we might revamp it
11770 and use it again (Bug#8435).
ea6c7ae6
PE
11771 * lisp.h (doprnt): Remove.
11772 * Makefile.in (base_obj): Remove doprnt.o.
11773 * deps.mk (doprnt.o): Remove.
11774
5fdb398c
PE
11775 error: Print 32- and 64-bit integers portably (Bug#8435).
11776 Without this change, on typical 64-bit hosts error ("...%d...", N)
11777 was used to print both 32- and 64-bit integers N, which relied on
11778 undefined behavior.
61bdb816 11779 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11780 * lisp.h (error, verror): Mark as printf-like functions.
11781 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11782 Report overflow in size calculations when allocating printf buffer.
11783 Do not truncate output string at its first null byte.
11784 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11785 Truncate the output at a character boundary, since vsnprintf does not
11786 do that.
11787 * charset.c (check_iso_charset_parameter): Convert internal
11788 character to string before calling 'error', since %c now has the
11789 printf meaning.
11790 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11791 overflow when computing char to be passed to 'error'. Do not
11792 pass Lisp_Object to 'error'; pass the integer instead.
11793 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11794 formatted with plain %d.
11795
b189fa66
PE
11796 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11797
bff87ef0
PE
11798 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11799
7e2cac20
PE
11800 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11801
ce4d90b5
PE
11802 * xterm.c (x_catch_errors): Remove duplicate declaration.
11803
266c9547
PE
11804 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11805
79c49ad2
PE
11806 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11807
368f4090
JM
118082011-04-10 Jim Meyering <meyering@redhat.com>
11809
11810 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11811 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11812 return ssize_t not "int", and use size_t as the buffer length.
11813 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11814 * gnutls.h: Update declarations.
11815 * process.c (read_process_output): Use ssize_t, to match.
11816 (send_process): Likewise.
11817
a32d4040
CY
118182011-04-09 Chong Yidong <cyd@stupidchicken.com>
11819
11820 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11821
8546720e 118222011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11823
04f2d78b
CB
11824 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11825 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11826
8546720e
GM
11827 * xterm.c (handle_one_xevent):
11828 * xmenu.c (create_and_show_popup_menu):
11829 * xselect.c (x_decline_selection_request)
11830 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11831
0a2f5c1a 118322011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11833
11834 Fix some uses of `int' instead of EMACS_INT.
11835 * search.c (string_match_1, fast_string_match)
11836 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11837 (scan_buffer, find_next_newline_no_quit)
11838 (find_before_next_newline, search_command, Freplace_match)
11839 (Fmatch_data): Make some `int' variables be EMACS_INT.
11840
11841 * xdisp.c (display_count_lines): 3rd argument and return value now
11842 EMACS_INT. All callers changed.
11843 (pint2hrstr): Last argument is now EMACS_INT.
11844
11845 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11846 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11847 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11848 (decode_coding_utf_16, decode_coding_emacs_mule)
11849 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11850 (decode_coding_ccl, decode_coding_charset)
11851 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11852 (decode_coding_iso_2022, decode_coding_emacs_mule)
11853 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11854 <char_offset, last_offset>: Declare EMACS_INT.
11855 (encode_coding_utf_8, encode_coding_utf_16)
11856 (encode_coding_emacs_mule, encode_invocation_designation)
11857 (encode_designation_at_bol, encode_coding_iso_2022)
11858 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11859 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11860 Declare EMACS_INT.
11861 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11862 (encode_invocation_designation): Last argument P_NCHARS is now
11863 EMACS_INT.
11864 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11865 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11866
11867 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11868 All users changed.
11869
11870 * ccl.c (Fccl_execute_on_string): Declare some variables
11871 EMACS_INT.
11872
8546720e 118732011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11874
11875 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11876
4e19a977
CS
118772011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11878
11879 * process.c (Fformat_network_address): Doc fix.
11880
87302331
R
118812011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11882
ee7683eb 11883 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11884
cbb59342
CY
118852011-04-08 Chong Yidong <cyd@stupidchicken.com>
11886
11887 * keyboard.c (read_char): Call Lisp function help-form-show,
11888 instead of using internal_with_output_to_temp_buffer.
11889 (Qhelp_form_show): New var.
e0d38eeb 11890 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11891
11892 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11893
11894 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11895
e67a13ab
CY
118962011-04-06 Chong Yidong <cyd@stupidchicken.com>
11897
04f2d78b
CB
11898 * process.c (Flist_processes): Remove to Lisp.
11899 (list_processes_1): Delete.
e67a13ab 11900
973f782d
EZ
119012011-04-06 Eli Zaretskii <eliz@gnu.org>
11902
7c106b1e
EZ
11903 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11904
973f782d
EZ
11905 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11906
41cf7d1a 119072011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11908
ca23cc88
PE
11909 Fix more problems found by GCC 4.6.0's static checks.
11910
f390e2d5
PE
11911 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11912
42eea0d0
PE
11913 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11914
b69769da 11915 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11916
f9541e84
PE
11917 * xdisp.c (vmessage): Mark as a printf-like function.
11918
13841b55
PE
11919 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11920
c136c10f
PE
11921 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11922
5e2d4a30
PE
11923 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11924 printf-like functions.
11925 (tiff_load): Add casts to remove these marks before passing them
11926 to system-supplied API.
11927
583f48b9
PE
11928 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11929
b25d760e
PE
11930 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11931 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11932 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11933 directly, rather than having caller test rule sign. This avoids
11934 some unnecessary tests.
11935 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11936 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11937 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11938
bc7b6697 11939 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11940 (xfont_open): Avoid unnecessary tests.
bc7b6697 11941
27ccc379
PE
11942 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11943
dcd5c89a
PE
11944 * composite.h, composite.c (composition_gstring_put_cache):
11945 Use EMACS_INT, not int, for length.
11946
b13a45c6
PE
11947 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11948 breaking out part of COMPOSITION_DECODE_RULE.
11949 (COMPOSITION_DECODE_RULE): Use it.
11950 * composite.c (get_composition_id): Remove unused local vars,
11951 by using the new macro.
11952
1e792e4d
PE
11953 * textprop.c (set_text_properties_1): Change while to do-while,
11954 since the condition is always true at first.
11955
dc6c6455 11956 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11957 (interval_deletion_adjustment): Return unsigned value.
11958 All uses changed.
dc6c6455 11959
aba7731a
PE
11960 * process.c (list_processes_1, create_pty, read_process_output):
11961 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11962 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11963 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11964 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11965 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11966
fdfc4bf3
PE
11967 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11968
fca8fe46 11969 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11970 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11971
06a0259a 11972 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11973 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11974 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11975
e7b9e80f
PE
11976 * print.c (print_error_message): Avoid int overflow.
11977
56201685
PE
11978 * font.c (font_list_entities): Redo for clarity,
11979 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11980
78834453 11981 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11982 (font_score): Avoid potential overflow in diff calculation.
78834453 11983
0bc0b309 11984 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11985 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11986
e610eaca
PE
11987 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11988
b895abce
PE
11989 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11990 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11991 can always succeed if overflow has undefined behavior.
11992
1f1d9321 11993 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11994 (wordify): Omit three unnecessary tests.
1f1d9321 11995
c59478bc
PE
11996 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11997 All callers changed. This avoids the need for an unused var.
11998
79b73827
PE
11999 * casefiddle.c (casify_region): Remove var that is set but not used.
12000
a4db5dfe
PE
12001 * dired.c (file_name_completion): Remove var that is set but not used.
12002
43aae36e
PE
12003 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12004
2a47c44d 12005 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12006 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12007
a37c69bf
PE
12008 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12009 Check for integer overflow on size calculations.
12010
328ab8e7
PE
12011 * buffer.c (Fprevious_overlay_change): Remove var that is set
12012 but not used.
12013
e5a2a5cb
PE
12014 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12015 Remove vars that are set but not used.
8d84a6eb 12016 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12017 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12018
a60e5f68
PE
12019 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12020
f661cb61 12021 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12022 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12023
f0397f5a
PE
12024 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12025 that are set but not used.
12026
8664db06 12027 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12028 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12029
6abdaa4a
PE
12030 * xselect.c (x_get_local_selection, x_handle_property_notify):
12031 Remove vars that are set but not used.
12032
0ce7538d 12033 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12034 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12035
9ae848fc
PE
12036 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12037 Remove var that is set but not used.
0b918413
PE
12038 (scroll_bar_windows_size): Now size_t, not int.
12039 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12040 Check for overflow.
9ae848fc 12041
a5a62657
PE
12042 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12043 (map_tty_color) [!defined MSDOS]: Likewise.
12044
5c5cdd39
PE
12045 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12046
66ebf983
PE
12047 * coding.c: Remove vars that are set but not used.
12048 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12049 All callers changed.
12050 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12051 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12052 (decode_coding_charset): Remove vars that are set but not used.
12053
1be4d761
PE
12054 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12055 that is set but not used.
12056
47553fa8
PE
12057 * print.c (print_object): Remove var that is set but not used.
12058
1f7196bf 12059 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12060 The gnulib version avoids calling malloc in the usual case,
12061 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12062 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12063 * filelock.c (current_lock_owner): Likewise.
12064 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12065 * sysdep.c: Include allocator.h, careadlinkat.h.
12066 (emacs_no_realloc_allocator): New static constant.
12067 (emacs_readlink): New function.
fdb61804
PE
12068 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12069 ../lib/careadlinkat.h.
d1fdcab7 12070
f84c17c7
SM
120712011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12072
12073 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12074 first non-nil return value).
12075
ef3862ad
JD
120762011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12077
12078 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12079 if not defined (Bug#8403).
12080
376a7006
JB
120812011-04-02 Juanma Barranquero <lekktu@gmail.com>
12082
12083 * xdisp.c (display_count_lines): Remove parameter `start',
12084 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12085 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12086 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12087 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12088 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12089 and thereabouts. All callers changed.
12090 (get_per_char_metric): Remove parameter `f', unused since
12091 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12092
6ca3801d
JM
120932011-04-02 Jim Meyering <meyering@redhat.com>
12094
12095 do not dereference NULL upon failed strdup
12096 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12097 (ns_get_family): Likewise.
12098
d8e2b5ba
JB
120992011-04-02 Juanma Barranquero <lekktu@gmail.com>
12100
12101 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12102
8c74fcbd
JD
121032011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12104
12105 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12106 later (Bug#8403).
12107
7200d79c
SM
121082011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12109
03408648 12110 Add lexical binding.
7200d79c 12111
03408648
SM
12112 * window.c (Ftemp_output_buffer_show): New fun.
12113 (Fsave_window_excursion):
12114 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12115
12116 * lread.c (lisp_file_lexically_bound_p): New function.
12117 (Fload): Bind Qlexical_binding.
12118 (readevalloop): Remove `evalfun' arg.
12119 Bind Qinternal_interpreter_environment.
12120 (Feval_buffer): Bind Qlexical_binding.
12121 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12122 Mark as dynamic.
12123 (syms_of_lread): Declare `lexical-binding'.
12124
12125 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12126
12127 * keyboard.c (eval_dyn): New fun.
12128 (menu_item_eval_property): Use it.
ca105506
SM
12129
12130 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12131
03408648
SM
12132 * fns.c (concat, mapcar1): Accept byte-code-functions.
12133
12134 * eval.c (Fsetq): Handle lexical vars.
12135 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12136 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12137 (FletX, Flet): Obey lexical binding.
12138 (Fcommandp): Handle closures.
12139 (Feval): New `lexical' arg.
12140 (eval_sub): New function extracted from Feval. Use it almost
12141 everywhere where Feval was used. Look up vars in lexical env.
12142 Handle closures.
12143 (Ffunctionp): Move from subr.el.
12144 (Ffuncall): Handle closures.
12145 (apply_lambda): Remove `eval_flags'.
12146 (funcall_lambda): Handle closures and new byte-code-functions.
12147 (Fspecial_variable_p): New function.
12148 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12149 but without exporting it to Lisp.
23aba0ea 12150
23aba0ea 12151 * doc.c (Fdocumentation, store_function_docstring):
03408648 12152 * data.c (Finteractive_form): Handle closures.
23aba0ea 12153
03408648
SM
12154 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12155 interactive spec.
ba83908c 12156
04f2d78b
CB
12157 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12158 New byte-codes.
03408648
SM
12159 (exec_byte_code): New function extracted from Fbyte_code to handle new
12160 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12161
03408648 12162 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12163
03408648 12164 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12165
e2abce01
JB
121662011-03-31 Juanma Barranquero <lekktu@gmail.com>
12167
12168 * xdisp.c (redisplay_internal): Fix prototype.
12169
63696a73 121702011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12171
63696a73 12172 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12173 (try_scrolling): Use it when setting scroll_limit.
12174 Limit scrolling to 100 screen lines.
63696a73
EZ
12175 (redisplay_window): Even when falling back on "recentering",
12176 position point in the window according to scroll-conservatively,
12177 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12178
12179 (try_scrolling): When point is above the window, allow searching
12180 as far as scroll_max, or one screenful, to compute vertical
12181 distance from PT to the scroll margin position. This prevents
12182 try_scrolling from unnecessarily failing when
12183 scroll-conservatively is set to a value slightly larger than the
12184 window height. Clean up the case of PT below the margin at bottom
12185 of window: scroll_max can no longer be INT_MAX. When aggressive
12186 scrolling is in use, don't let point enter the opposite scroll
12187 margin as result of the scroll.
12188 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12189 threshold of 100 lines for never-recentering scrolling.
12190
e4cc2dfc
JB
121912011-03-31 Juanma Barranquero <lekktu@gmail.com>
12192
12193 * dispextern.h (move_it_by_lines):
12194 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12195 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12196 (message_log_check_duplicate): Remove parameters `prev_bol' and
12197 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12198 (redisplay_internal): Remove parameter `preserve_echo_area',
12199 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12200
12201 * indent.c (Fvertical_motion):
12202 * window.c (window_scroll_pixel_based, Frecenter):
12203 Don't pass `need_y_p' to `move_it_by_lines'.
12204
1c470562
SM
122052011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12206
44f230aa
SM
12207 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12208 steal a few bits to be more compact.
12209 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12210 Remove unneeded casts.
12211
1c470562
SM
12212 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12213
888adce9
ZK
122142011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12215
12216 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12217 binding" message (bug#7967).
12218
f838ed7b
PE
122192011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12220
77861b95
PE
12221 Fix more problems found by GCC 4.6.0's static checks.
12222
de6dbc14
PE
12223 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12224 Remove unused local var.
12225
f838ed7b
PE
12226 * editfns.c (Fmessage_box): Remove unused local var.
12227
792c7b2b
PE
12228 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12229 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12230 Omit unused local vars.
c499e557 12231 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12232 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12233 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12234 Omit unused local var.
12235
ba0165e1
PE
12236 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12237 Don't assume string length fits in int.
32ad8845 12238 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12239 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12240
3c59b4c9
PE
12241 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12242 instead of alloca (Bug#8344).
12243
a3eed478 12244 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12245 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12246
eb4d412d
PE
12247 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12248
1658b401
PE
12249 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12250 concerns.
12251
12252 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12253
12254 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12255
9a2c6e05
PE
12256 * keyboard.c (syms_of_keyboard): Use the same style as later
12257 in this function when indexing through an array. This also
12258 works around GCC bug 48267.
12259
03d0a109
PE
12260 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12261
44f730c8
PE
12262 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12263
fe75f926
PE
12264 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12265 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12266
ffa8c828
PE
12267 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12268 This avoids undefined behavior on integer overflow, and is a bit
12269 more convenient anyway since it is compared to a size_t variable.
12270
c5101a77
PE
12271 Variadic C functions now count arguments with size_t, not int.
12272 This avoids an unnecessary limitation on 64-bit machines, which
12273 caused (substring ...) to crash on large vectors (Bug#8344).
12274 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12275 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12276 All variadic functions and their callers changed accordingly.
c5101a77
PE
12277 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12278 * data.c (arith_driver, float_arith_driver): Likewise.
12279 * editfns.c (general_insert_function): Likewise.
12280 * eval.c (struct backtrace.nargs, interactive_p)
12281 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12282 (funcall_lambda, mark_backtrace): Likewise.
12283 * fns.c (concat): Likewise.
12284 * frame.c (x_set_frame_parameters): Likewise.
12285 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12286 0 if not found, not -1. All callers changed.
12287
dd3f25f7
PE
12288 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12289 (stack_copy_size): Now size_t, not int.
12290 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12291
461c2ab9
JB
122922011-03-28 Juanma Barranquero <lekktu@gmail.com>
12293
12294 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12295 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12296 All callers changed.
12297
12298 * lisp.h (multibyte_char_to_unibyte):
12299 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12300 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12301 * character.h (CHAR_TO_BYTE8):
12302 * cmds.c (internal_self_insert):
12303 * editfns.c (general_insert_function):
12304 * keymap.c (push_key_description):
12305 * search.c (Freplace_match):
12306 * xdisp.c (message_dolog, set_message_1): All callers changed.
12307
f6d62986
SM
123082011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12309
12310 * keyboard.c (safe_run_hook_funcall): New function.
12311 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12312 don't set the hook to nil, but remove the offending function instead.
12313 (Qcommand_hook_internal): Remove, unused.
12314 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12315 Vcommand_hook_internal.
12316
12317 * eval.c (enum run_hooks_condition): Remove.
12318 (funcall_nil, funcall_not): New functions.
12319 (run_hook_with_args): Call each function through a `funcall' argument.
12320 Remove `cond' argument, now redundant.
12321 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12322 (Frun_hook_with_args_until_failure): Adjust accordingly.
12323 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12324
1db5b1ad
JB
123252011-03-28 Juanma Barranquero <lekktu@gmail.com>
12326
12327 * dispextern.h (string_buffer_position): Remove declaration.
12328
12329 * print.c (strout): Remove parameter `multibyte', unused since
12330 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12331
12332 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12333 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12334 All callers changed.
12335
12336 * w32.c (_wsa_errlist): Use braces for struct initializers.
12337
12338 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12339 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12340 All callers changed.
12341 (string_buffer_position): Likewise. Also, make static (it's never
12342 used outside xdisp.c).
12343 (cursor_row_p): Remove parameter `w', unused since
12344 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12345 (decode_mode_spec): Remove parameter `precision', introduced during
12346 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12347 All callers changed.
12348
5ffb62aa
JD
123492011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12350
12351 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12352
461c2ab9 123532011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12354
12355 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12356 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12357 (ns_update_auto_hide_menu_bar): New functions.
12358 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12359 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12360 ns_constrain_all_frames.
12361 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12362 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12363
5c380ffb
JD
123642011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12365
12366 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12367
9af30bdf
GM
123682011-03-27 Glenn Morris <rgm@gnu.org>
12369
12370 * syssignal.h: Replace RETSIGTYPE with void.
12371 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12372 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12373 Replace SIGTYPE with void everywhere.
12374 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12375 * s/template.h (SIGTYPE): Remove commented out definition.
12376
e2abce01
JB
123772011-03-26 Eli Zaretskii <eliz@gnu.org>
12378
12379 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12380 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12381
f868cd8a
JB
123822011-03-26 Juanma Barranquero <lekktu@gmail.com>
12383
59eb0929
JB
12384 * w32.c (read_unc_volume): Use parameter `henum', instead of
12385 global variable `wget_enum_handle'.
12386
12387 * keymap.c (describe_vector): Remove parameters `indices' and
12388 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12389 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12390
f868cd8a
JB
12391 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12392
12393 * keyboard.c (timer_check): Remove parameter `do_it_now',
12394 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12395 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12396 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12397
12398 * keyboard.c (read_char):
12399 * w32menu.c (w32_menu_display_help):
12400 * xmenu.c (show_help_event, menu_help_callback):
12401 Adjust calls to `show_help_echo'.
12402
12403 * gtkutil.c (xg_maybe_add_timer):
12404 * keyboard.c (readable_events):
12405 * process.c (wait_reading_process_output):
12406 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12407
12408 * insdel.c (adjust_markers_gap_motion):
12409 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12410 (gap_left, gap_right): Don't call it.
12411
2ecf6fdb
CY
124122011-03-25 Chong Yidong <cyd@stupidchicken.com>
12413
12414 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12415 incurred during fontification.
12416
6b1f9ba4
JB
124172011-03-25 Juanma Barranquero <lekktu@gmail.com>
12418
12419 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12420 (DEFVAR_PER_BUFFER): Don't pass it.
12421
12422 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12423 (scrolling_window): Don't pass it.
12424
0f4a96b5
JB
124252011-03-25 Juanma Barranquero <lekktu@gmail.com>
12426
12427 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12428
12429 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12430 and `suffix'.
12431 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12432 of variables specific to SELinux and computation of `encoded_absname'.
12433
12434 * image.c (XPutPixel): Remove unused variable `height'.
12435
12436 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12437
12438 * unexw32.c (get_section_info): Remove unused variable `section'.
12439
12440 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12441 (system_process_attributes): Remove unused variable `sess'.
12442 (sys_read): Remove unused variable `err'.
12443
12444 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12445 (w32_wnd_proc): Remove unused variable `isdead'.
12446 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12447 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12448 (x_create_tip_frame): Remove unused variable `tem'.
12449
12450 * w32inevt.c (w32_console_read_socket):
12451 Remove unused variable `no_events'.
12452
12453 * w32term.c (x_draw_composite_glyph_string_foreground):
12454 Remove unused variable `width'.
12455
1149507c
JB
124562011-03-24 Juanma Barranquero <lekktu@gmail.com>
12457
12458 * w32term.c (x_set_glyph_string_clipping):
12459 Don't pass uninitialized region to CombineRgn.
12460
9c88f339
JB
124612011-03-23 Juanma Barranquero <lekktu@gmail.com>
12462
12463 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12464 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12465 (Fx_close_connection): Remove unused variable `i'.
12466
12467 * w32font.c (w32font_draw): Return number of glyphs.
12468 (w32font_open_internal): Remove unused variable `i'.
12469 (w32font_driver): Add missing initializer.
12470
12471 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12472 (fill_in_menu): Remove unused variable `items_added'.
12473
12474 * w32term.c (last_mouse_press_frame): Remove static global variable.
12475 (w32_clip_to_row): Remove unused variable `f'.
12476 (x_delete_terminal): Remove unused variable `i'.
12477
12478 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12479 (NOTHING): Remove unused static global variable.
12480 (uniscribe_check_otf): Remove unused variable `table'.
12481 (uniscribe_font_driver): Add missing initializers.
12482
dee091a3
JD
124832011-03-23 Julien Danjou <julien@danjou.info>
12484
12485 * term.c (Fsuspend_tty, Fresume_tty):
12486 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12487 * window.c (temp_output_buffer_show):
12488 * insdel.c (signal_before_change):
12489 * frame.c (Fhandle_switch_frame):
12490 * fileio.c (Fdo_auto_save):
12491 * emacs.c (Fkill_emacs):
12492 * editfns.c (save_excursion_restore):
12493 * cmds.c (internal_self_insert):
12494 * callint.c (Fcall_interactively):
12495 * buffer.c (Fkill_all_local_variables):
12496 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12497 Use Frun_hooks.
0f4a96b5 12498 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12499 unconditionally since it does the check itself.
dee091a3 12500
2c520ab5 125012011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12502
c9c49752
PE
12503 Fix more problems found by GCC 4.5.2's static checks.
12504
8abc3f12
PE
12505 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12506 the first time through the loop, since we know p0 < p1 then.
12507 This also avoids a gcc -Wstrict-overflow warning.
12508
a2d26660
PE
12509 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12510 leading to a memory leak, possible in functions like
12511 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12512 of objects (Bug#8318).
a2d26660 12513
916c72e9
PE
12514 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12515 that could (at least in theory) be that large.
12516
19ab8a18
PE
12517 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12518 This is less likely to overflow, and avoids undefined behavior if
12519 overflow does occur. All callers changed. Use strtoul to scan
12520 for the unsigned long integer.
b7cbbd6f
PE
12521 (pint2hrstr): Simplify and tune code slightly.
12522 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12523
f0641eff
PE
12524 * scroll.c (do_scrolling): Work around GCC bug 48228.
12525 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12526
7f650bb9
PE
12527 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12528 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12529 (validate_x_resource_name): Simplify count usage.
12530 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12531
37dd57d1
PE
12532 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12533 fail (Bug#8306).
81e56e61 12534
699979fc 12535 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12536
401bf9b4
PE
12537 * process.c (Fmake_network_process): Use socklen_t, not int,
12538 where POSIX says socklen_t is required in portable programs.
12539 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12540 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12541 (Fmake_network_process, server_accept_connection):
12542 (wait_reading_process_output, read_process_output):
12543 Likewise.
12544
b93aacde
PE
12545 * process.c: Rename or move locals to avoid shadowing.
12546 (list_processes_1, Fmake_network_process):
12547 (read_process_output_error_handler, exec_sentinel_error_handler):
12548 Rename or move locals.
4dc343ee 12549 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12550 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12551 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12552 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12553 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12554
af8a867c 12555 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12556 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12557 Include tparam.h instead, since it declares them.
af8a867c
PE
12558 * cm.h (PC): Remove extern decl; tparam.h now does this.
12559 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12560 * terminfo.c: Include tparam.h, to check interfaces.
12561 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12562 (tparam): Adjust signature to match interface in tparam.h;
12563 this removes some undefined behavior. Check that outstring and len
12564 are zero, which they always are with Emacs.
12565 * tparam.h (PC, BC, UP): New extern decls.
12566
0248044d 12567 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12568 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12569
8ff096c1 12570 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12571 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12572 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12573 (ftfont_list): Remove unused local.
49eaafba
PE
12574 (get_adstyle_property, ftfont_pattern_entity):
12575 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12576 Rename locals to avoid shadowing.
8ff096c1 12577
e2be39f6
PE
12578 * xfont.c (xfont_list_family): Mark var as initialized.
12579
c9735e30
PE
12580 * xml.c (make_dom): Now static.
12581
8f5201ae
PE
12582 * composite.c (composition_compute_stop_pos): Rename local to
12583 avoid shadowing.
b246f932
PE
12584 (composition_reseat_it): Remove unused locals.
12585 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12586 (composition_update_it): Mark var as initialized.
11b61122
PE
12587 (find_automatic_composition): Mark vars as initialized,
12588 with a FIXME (Bug#8290).
8f5201ae 12589
760fbc2c
PE
12590 character.h: Rename locals to avoid shadowing.
12591 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12592 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12593 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12594 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12595 to avoid shadowing.
12596
ff08eb85
PE
12597 * textprop.c (property_change_between_p): Remove; unused.
12598
fc7bf025
PE
12599 * intervals.c (interval_start_pos): Now static.
12600
235d7abc
PE
12601 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12602
44f230aa
SM
12603 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12604 Rename locals to avoid shadowing.
3e7d6594 12605
50060332
PE
12606 * sound.c (wav_play, au_play, Fplay_sound_internal):
12607 Fix pointer signedness.
d01f234b 12608 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12609 (wav_play): Initialize a variable to 0, to prevent undefined
12610 behavior (Bug#8278).
50060332 12611
c4fc4e30
PE
12612 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12613
918436ed
PE
12614 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12615
c939f91b
PE
12616 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12617 clobbering (Bug#8298).
b9c7f648
PE
12618 * sysdep.c (sys_subshell): Likewise.
12619 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12620
6bd8c144
PE
12621 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12622 This should get cleaned up, so that child_setup has the
12623 same signature on all platforms.
12624
7710357c 12625 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12626 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12627
c59da222
CY
126282011-03-22 Chong Yidong <cyd@stupidchicken.com>
12629
12630 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12631 not to be necessary, and produces flickering.
12632
66b87493
GM
126332011-03-20 Glenn Morris <rgm@gnu.org>
12634
12635 * config.in: Remove file.
12636
45b6f6d5
JB
126372011-03-20 Juanma Barranquero <lekktu@gmail.com>
12638
12639 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12640 are now in src/globals.h.
12641 (syms_of_minibuf): Remove spurious & from previous change.
12642
cd394be1 126432011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12644
12645 * minibuf.c (completing-read-function): New variable.
12646 (completing-read-default): Rename from completing-read.
12647 (completing-read): Call completing-read-function.
12648
b14e3e21
CY
126492011-03-19 Juanma Barranquero <lekktu@gmail.com>
12650
12651 * xfaces.c (Fx_load_color_file):
12652 Read color file from absolute filename (bug#8250).
12653
f2b726e6
JB
126542011-03-19 Juanma Barranquero <lekktu@gmail.com>
12655
12656 * makefile.w32-in: Update dependencies.
12657
09f6ff02
EZ
126582011-03-17 Eli Zaretskii <eliz@gnu.org>
12659
12660 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12661
29a6015a
PE
126622011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12663
a3a6c54e
PE
12664 Fix more problems found by GCC 4.5.2's static checks.
12665
b766f867
PE
12666 * process.c (make_serial_process_unwind, send_process_trap):
12667 (sigchld_handler): Now static.
12668
be02381c
PE
12669 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12670 That way, the code declares only the vars that it needs.
12671 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12672 * s/cygwin.h (PTY_ITERATION): Likewise.
12673 * s/darwin.h (PTY_ITERATION): Likewise.
12674 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12675
57048744
PE
12676 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12677 * process.c (allocate_pty): Don't declare stb unless it's needed.
12678
7914961c 12679 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12680 (CONSTANTLIM): Remove; unused.
12681 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12682 Define only if needed.
7914961c 12683
b3967b18
PE
12684 * unexelf.c (unexec): Name an expression,
12685 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12686 Use a different way to cause a compilation error if anyone uses
12687 n rather than nn, a way that does not involve shadowing.
73366a00 12688 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12689
29a6015a
PE
12690 * deps.mk (unexalpha.o): Remove; unused.
12691
43cfc33e 12692 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12693 * unexec.h: New file.
ce701a33
PE
12694 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12695 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12696 Depend on unexec.h.
12697 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12698 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12699 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12700 Change as necessary to match prototype in unexec.h.
ce701a33 12701
01f44d5a
PE
12702 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12703 shadowing.
4f63c6bb 12704 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12705
a6670b0b
PE
12706 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12707 Rename locals to avoid shadowing.
12708
cef2010d 12709 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12710 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12711
d4d7173a
PE
12712 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12713
f08b802a
PE
12714 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12715 warning when compiling print.c.
12716
3ddb0639
PE
12717 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12718 instead of using an uninitialized var.
5ad03b97 12719 (font_sort_entities): Mark var as initialized.
3ddb0639 12720
170a2692
PE
12721 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12722
e663c700
PE
12723 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12724 pointers to constants.
89bc529a 12725 (font_parse_fcname): Remove unused vars.
7b81e2d0 12726 (font_delete_unmatched): Now static.
ea838e10 12727 (font_get_spec): Remove; unused.
13a547c6
PE
12728 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12729 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12730 Rename or move locals to avoid shadowing.
e663c700 12731
2a80c887 12732 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12733 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12734
1384fa33 12735 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12736 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12737
8b2c52e9
PE
12738 * alloc.c (mark_backtrace): Move decl from here ...
12739 * lisp.h: ... to here, so that it can be checked.
12740
475545b5 12741 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12742 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12743 (lisp_indirect_variable): Name an expression,
12744 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12745 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12746
b1349114 12747 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12748 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12749 Use const pointer when appropriate.
b1349114 12750
a2928364
PE
12751 * lisp.h (get_system_name, get_operating_system_release):
12752 Move decls here, to check interfaces.
12753 * process.c (get_operating_system_release): Move decl to lisp.h.
12754 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12755 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12756 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12757 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12758 (Fformat_time_string, Fencode_time, Finsert_char):
12759 (Ftranslate_region_internal, Fformat):
12760 Rename or remove local vars to avoid shadowing.
9710023e 12761 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12762
a415e694
PE
12763 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12764 avoid shadowing.
12765
8ef4622d
PE
12766 * lisp.h (eassert): Check that the argument compiles, even if
12767 ENABLE_CHECKING is not defined.
12768
946f9a5b
PE
12769 * data.c (Findirect_variable): Name an expression, to avoid
12770 gcc -Wbad-function-cast warning.
112396d6 12771 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12772 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12773 (Fmake_variable_buffer_local, Fmake_local_variable):
12774 Mark variables as initialized.
52746918 12775 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12776
e5aab7e7 12777 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12778 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12779 Rename locals to avoid shadowing.
dff45157
PE
12780 (mark_stack): Move local variables into the #ifdef region where
12781 they're used.
7bc26fdb
PE
12782 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12783 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12784 needed otherwise.
12785 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12786 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12787 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12788
e5aab7e7
PE
12789 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12790 avoids undefined behavior in theory.
12791
4da60324
PE
12792 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12793
88043301
PE
12794 Use functions, not macros, for up- and down-casing (Bug#8254).
12795 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12796 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12797 to use the following functions instead of these macros.
12798 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12799 EMACS_INT, since callers assume the returned value fits in int.
12800 (upcase1): Likewise, for UPCASE_TABLE.
12801 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12802 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12803 the race-condition problem in the old DOWNCASE.
88043301 12804
19ed5445
PE
12805 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12806 Rename locals to avoid shadowing.
12807 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12808 (regex_compile, re_search_2, re_match_2_internal):
12809 Remove unused local vars.
952db0d7
PE
12810 (FREE_VAR): Rewrite so as not to use empty "else",
12811 which gcc can warn about.
da053e48 12812 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12813 (RETALLOC_IF): Define only if needed.
12814 (WORDCHAR_P): Likewise. This one is never needed, but is used
12815 only in a comment talking about a compiler bug, so put inside
12816 the #if 0 of that comment.
12817 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12818 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12819 Remove; unused.
19ed5445 12820
1f3561e4 12821 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12822 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12823 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12824
ded6f8f7
PE
12825 * search.c (simple_search): Remove unused var.
12826
dbd37a95
PE
12827 * dired.c (compile_pattern): Move decl from here ...
12828 * lisp.h: ... to here, so that it can be checked.
12829 (struct re_registers): New forward decl.
12830
7e47afad
PE
12831 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12832
85f24f61
PE
12833 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12834 All uses changed.
12835 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12836 Rename locals to avoid shadowing.
5671df8f 12837 (Fvertical_motion): Mark locals as initialized.
85f24f61 12838
181aa2be 12839 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12840 (casify_region): Mark local as initialized.
181aa2be 12841
930d429c
PE
12842 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12843
7082eac6
PE
12844 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12845 New macros, so that the caller can use some names other than
12846 gcpro1, gcpro2, etc.
12847 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12848 of the new macros.
12849 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12850 argument, for consistency with GCPRO2_VAR, etc: it is now the
12851 prefix of the variable, not the variable itself. All uses
12852 changed.
38b2c076
PE
12853 * dired.c (directory_files_internal, file_name_completion):
12854 Rename locals to avoid shadowing.
12855
15206ed9
PE
12856 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12857 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12858 dired.c's scmp function, had undefined behavior.
12859 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12860 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12861 * buffer.h: ... to here, because these macros use current_buffer,
12862 and the new implementation with inline functions needs to have
12863 current_buffer in scope now, rather than later when the macros
12864 are used.
12865 (downcase, upcase1): New static inline functions.
12866 (DOWNCASE, UPCASE1): Reimplement using these functions.
12867 This avoids undefined behavior in expressions like
12868 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12869 from race conditions in accessing the global variables
12870 case_temp1 and case_temp2.
12871 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12872 * lisp.h (case_temp1, case_temp2): Remove their decls.
12873 * character.h (ASCII_CHAR_P): Move from here ...
12874 * lisp.h: ... to here, so that the inline functions mentioned
12875 above can use them.
12876
4a6bea26
PE
12877 * dired.c (directory_files_internal_unwind): Now static.
12878
f14b7e14
PE
12879 * fileio.c (file_name_as_directory, directory_file_name):
12880 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12881 Now static.
2893f146
PE
12882 (file_name_as_directory): Use const pointers when appropriate.
12883 (Fexpand_file_name): Likewise. In particular, newdir might
12884 point at constant storage, so make it a const pointer.
fd4ead52 12885 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12886 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12887 signedness issues.
f839df0c
PE
12888 (Fset_file_times, Finsert_file_contents, auto_save_error):
12889 Rename locals to avoid shadowing.
f14b7e14 12890
5716756e 12891 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12892 (Ftry_completion, Fall_completions): Rename or remove locals
12893 to avoid shadowing.
5716756e 12894
b4c3046a
PE
12895 * marker.c (bytepos_to_charpos): Remove; unused.
12896
b45db522
PE
12897 * lisp.h (verify_bytepos, count_markers): New decls,
12898 so that gcc does not warn that these functions aren't declared.
12899
85876d07
PE
12900 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12901 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12902 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12903 (copy_text): Remove unused local var.
85876d07 12904
03d78a21 12905 * filelock.c (within_one_second): Now static.
b3dd38ab 12906 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12907
5df8f01b
PE
12908 * buffer.c (fix_overlays_before): Mark locals as initialized.
12909 (fix_start_end_in_overlays): Likewise. This function should be
12910 simplified by using pointers-to-pointers, but that's a different
12911 matter.
b1d876f1 12912 (switch_to_buffer_1): Now static.
8f54f30a
PE
12913 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12914 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12915
a70072c9 12916 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12917 Fix pointer signedness issue.
edced198
PE
12918 (sys_subshell): Mark local as volatile if checking for lint,
12919 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12920 (MAXPATHLEN): Define only if needed.
a70072c9 12921
a0977c44
PE
12922 * process.c (serial_open, serial_configure): Move decls from here ...
12923 * systty.h: ... to here, so that they can be checked.
12924
a884fdcc
PE
12925 * fns.c (get_random, seed_random): Move extern decls from here ...
12926 * lisp.h: ... to here, so that they can be checked.
12927
604efe86 12928 * sysdep.c (reset_io): Now static.
b8950c94 12929 (wait_for_termination_signal): Remove; unused.
604efe86 12930
38fc62d9
PE
12931 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12932 (copy_keymap_item, append_key, push_text_char_description):
12933 Now static.
1004a21a 12934 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12935 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12936 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12937 (describe_map_tree):
12938 Rename locals to avoid shadowing.
38fc62d9 12939
2f2650da
PE
12940 * keyboard.c: Declare functions static if they are not used elsewhere.
12941 (echo_char, echo_dash, cmd_error, top_level_2):
12942 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12943 (read_char, kbd_buffer_get_event, make_lispy_position):
12944 (make_lispy_event, make_lispy_movement, apply_modifiers):
12945 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12946 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12947 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12948 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12949 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12950
a053e86c 12951 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12952 (mark_kboards): Move decl here ...
12953 * alloc.c (mark_kboards): ... from here.
a053e86c 12954
4752793e
PE
12955 * lisp.h (force_auto_save_soon): New decl.
12956
74f10ca7 12957 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12958 (DEFINE_DUMMY_FUNCTION): New macro.
12959 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12960 Use it.
c03cd23f
PE
12961 (main): Add casts to avoid warnings
12962 if GCC considers string literals to be constants.
74f10ca7 12963
022e70d4
PE
12964 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12965
59d6fe83
PE
12966 * dbusbind.c: Pointer signedness fixes.
12967 (xd_signature, xd_append_arg, xd_initialize):
12968 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12969 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12970 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12971 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12972
78320123
PE
12973 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12974 if GCC considers string literals to be constants.
49cebcca 12975 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12976
35ac2a97
SM
129772011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12978
fb103ca9
SM
12979 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12980 (print_preprocess, print_object): New macro to fix last change.
12981
35ac2a97
SM
12982 * print.c (print_preprocess): Don't forget font objects.
12983
62973b41
JB
129842011-03-16 Juanma Barranquero <lekktu@gmail.com>
12985
12986 * emacs.c (USAGE3): Doc fixes.
12987
0e48bb22
AS
129882011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12989
12990 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12991 structure.
12992
7684e57b
JB
129932011-03-14 Juanma Barranquero <lekktu@gmail.com>
12994
12995 * lisp.h (VWindow_system, Qfile_name_history):
12996 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12997 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12998 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12999
13000 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13001 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13002
13003 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13004 * w32console.c (detect_input_pending, read_input_pending)
13005 (encode_terminal_code):
13006 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13007 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13008 (w32_system_caret_y, Qfile_name_history):
13009 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13010 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13011 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13012 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13013 * w32proc.c (Qlocal, report_file_error):
13014 * w32term.c (Vwindow_system, updating_frame):
13015 * w32uniscribe.c (initialized, uniscribe_font_driver):
13016 Remove unneeded extern declarations.
13017
2aa46d6c
CY
130182011-03-14 Chong Yidong <cyd@stupidchicken.com>
13019
c96bbc66 13020 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13021
cffc6f3b
CY
130222011-03-13 Chong Yidong <cyd@stupidchicken.com>
13023
13024 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13025 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13026 These macros can no longer be used for assignment.
13027
44f230aa
SM
13028 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13029 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13030 (record_buffer_markers, fetch_buffer_markers): New functions for
13031 recording and fetching special buffer markers.
13032 (set_buffer_internal_1, set_buffer_temp): Use them.
13033
13034 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13035
13036 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13037
13038 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13039 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13040
13041 * xdisp.c (hscroll_window_tree):
13042 (reconsider_clip_changes): Use PT instead of BUF_PT.
13043
d251f04b
EZ
130442011-03-13 Eli Zaretskii <eliz@gnu.org>
13045
13046 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13047 $(EMACS_ROOT)/lib/intprops.h.
13048
f0c77cd1
PE
130492011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13050
3eca4629
PE
13051 Fix more problems found by GCC 4.5.2's static checks.
13052
7c86ee98
PE
13053 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13054 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13055 (xg_free_frame_widgets): Make it clear that a local variable is
13056 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13057 (gdk_window_get_screen): Make it clear that this macro is needed
13058 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13059 (int_gtk_range_get_value): New function, which avoids a diagnostic
13060 from gcc -Wbad-function-cast.
13061 (xg_set_toolkit_scroll_bar_thumb): Use it.
13062 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13063 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13064 (get_utf8_string, xg_get_file_with_chooser):
13065 Rename locals to avoid shadowing.
13066 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13067
41729b81
PE
13068 * xgselect.c (xg_select): Remove unused var.
13069
f0c77cd1
PE
13070 * image.c (four_corners_best): Mark locals as initialized.
13071 (gif_load): Initialize transparent_p to zero (Bug#8238).
13072 Mark another local as initialized.
ec6cf4c6 13073 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13074
ce0ad53d 13075 * image.c (clear_image_cache): Now static.
d5d5a617 13076 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13077 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13078 (x_edge_detection): Remove unnecessary cast that
13079 gcc -Wbad-function-cast diagnoses.
2037898d 13080 (gif_load): Fix pointer signedness.
6ae141d6
PE
13081 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13082 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13083
33383987 130842011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13085
d32df629
PE
13086 Improve quality of tests for time stamp overflow.
13087 For example, without this patch (encode-time 0 0 0 1 1
13088 1152921504606846976) returns the obviously-bogus value (-948597
13089 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13090 reports time overflow. See
13091 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13092 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13093 * editfns.c: Include limits.h and intprops.h.
13094 (TIME_T_MIN, TIME_T_MAX): New macros.
13095 (time_overflow): Move earlier, to before first use.
13096 (hi_time, lo_time): New functions, for an accurate test for
13097 out-of-range times.
13098 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13099 (Fget_internal_run_time): Don't assume time_t fits in int.
13100 (make_time): Use list2 instead of Fcons twice.
13101 (Fdecode_time): More accurate test for out-of-range times.
13102 (check_tm_member): New function.
13103 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13104 (lisp_time_argument): Don't rely on undefined left-shift and
13105 right-shift behavior when checking for time stamp overflow.
8be6f318 13106
fe31d94c
PE
13107 * editfns.c (time_overflow): New function, refactoring common code.
13108 (Fformat_time_string, Fdecode_time, Fencode_time):
13109 (Fcurrent_time_string): Use it.
13110
8be6f318
PE
13111 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13112 * dired.c (make_time): Move to ...
13113 * editfns.c (make_time): ... here.
13114 * systime.h: Note the move.
13115
09d9db2c 131162011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13117
126bc0dc
YM
13118 * fringe.c (update_window_fringes): Remove unused variables.
13119
c47cbdfd
YM
13120 * unexmacosx.c (copy_data_segment): Also copy __got section.
13121 (Bug#8223)
13122
7ac80be9
EZ
131232011-03-12 Eli Zaretskii <eliz@gnu.org>
13124
c96bbc66 13125 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13126 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13127 Constify `char *' arguments and their references according to
13128 prototypes in tparam.h.
13129
ecb0f94d 13130 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13131
7ac80be9
EZ
13132 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13133 Adapt all references accordingly.
13134
13135 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13136
ef1fd07e
TT
131372011-03-11 Tom Tromey <tromey@redhat.com>
13138
13139 * buffer.c (syms_of_buffer): Remove obsolete comment.
13140
7ef4b50c
EZ
131412011-03-11 Eli Zaretskii <eliz@gnu.org>
13142
13143 * termhooks.h (encode_terminal_code): Declare prototype.
13144
13145 * msdos.c (encode_terminal_code): Don't declare prototype.
13146
13147 * term.c (encode_terminal_code): Now external again, used by
13148 w32console.c and msdos.c.
13149
44f230aa
SM
13150 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13151 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13152
4b1ec863 131532011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13154
1714f52b 13155 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13156
4b1ec863
PE
13157 * fringe.c (update_window_fringes): Mark locals as initialized
13158 (Bug#8227).
13159 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13160
524c7aa6
PE
13161 * alloc.c (mark_fringe_data): Move decl from here ...
13162 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13163 to check its interface.
13164 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13165
a5c0af81 13166 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13167 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13168 (fontset_font): Mark local as initialized.
a9a06e0b 13169 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13170
b4716021
PE
13171 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13172
811e9bac 13173 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13174 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13175 (x_own_selection, Fx_disown_selection_internal): Rename locals
13176 to avoid shadowing.
13177 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13178
7e3ab302
PE
13179 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13180 so that the caller can use some name other than gcpro1.
13181 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13182 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13183 (Fx_backspace_delete_keys_p):
13184 Use them to avoid shadowing, and rename vars to avoid shadowing.
13185 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13186 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13187 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13188 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13189 Remove unused locals.
7e3ab302
PE
13190 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13191 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13192 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13193 macros.
f78faa98 13194
e2b13473
PE
13195 * xterm.h (x_mouse_leave): New decl.
13196
77f23912
PE
13197 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13198 Remove unused functions.
cdf4ba58
PE
13199 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13200 (x_calc_absolute_position): Now static.
7411c686 13201 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13202 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13203 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13204 unless they are used.
38d0b34a
PE
13205 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13206 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13207 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13208 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13209 (x_error_catcher, x_connection_closed, x_error_handler):
13210 (x_error_quitter, xembed_send_message, x_iconify_frame):
13211 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13212 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13213 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13214
44f230aa
SM
13215 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13216 Rename or move locals to avoid shadowing.
6b463e58 13217 (tty_defined_color, merge_face_heights): Now static.
5967d051 13218 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13219 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13220 does not deduce is never used uninitialized.
73719eba
PE
13221 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13222 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13223
426994c3 13224 * terminal.c (store_terminal_param): Now static.
5489860b 13225
032f1620 13226 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13227 (set_frame_menubar): Remove unused local.
d4323972 13228 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13229 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13230 since they might point to immutable storage.
281585b0
PE
13231 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13232 since it's unused otherwise.
032f1620 13233
367c19e5 13234 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13235 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13236 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13237 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13238 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13239 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13240 does not deduce are never used uninitialized.
70739cbe 13241
07b48fa9
PE
13242 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13243
8868a238 13244 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13245 * window.c (window_loop, size_window):
13246 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13247
7e5cf297 13248 * window.c (display_buffer): Now static.
d6550a9f
PE
13249 (size_window): Mark variables that gcc -Wuninitialized
13250 does not deduce are never used uninitialized.
a586633d
PE
13251 * window.h (check_all_windows): New decl, to forestall
13252 gcc -Wmissing-prototypes diagnostic.
5b555da1 13253 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13254
f6095868
PE
13255 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13256 shadowing.
13257 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13258 Include <limits.h>.
13259 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13260 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13261 (load_charset_map): Mark variables that gcc -Wuninitialized
13262 does not deduce are never used uninitialized.
53df7c11 13263 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13264
f38b440c
PE
13265 * coding.c (coding_set_source, coding_set_destination):
13266 Use "else { /* comment */ }" rather than "else /* comment */;"
13267 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13268 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13269 a block, when the outer 'i' will do.
13270 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13271 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13272 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13273 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13274 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13275 Rename locals to avoid shadowing.
13276 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13277 * coding.c (emacs_mule_char, encode_invocation_designation):
13278 Now static, since they're not used elsewhere.
413bb2db 13279 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13280 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13281 (decode_coding_emacs_mule): Mark variables that gcc
13282 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13283 (detect_coding_iso_2022): Initialize a local variable that might
13284 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13285 this initialization is needed. (Bug#8211)
5f58e762
PE
13286 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13287 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13288 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13289 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13290 Remove unused macros.
f38b440c 13291
232b38b9 13292 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13293 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13294 * character.c (string_count_byte8): Likewise.
232b38b9 13295
fb90da1b
PE
13296 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13297 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13298
fb93dbc2
PE
13299 * chartab.c (copy_sub_char_table): Now static, since it's not used
13300 elsewhere.
5c156ace
PE
13301 (sub_char_table_ref_and_range, char_table_ref_and_range):
13302 Rename locals to avoid shadowing.
bbcd0949 13303 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13304
7d3b3862 13305 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13306 (BIDI_BOB): Remove unused macro.
7d3b3862 13307
6be7d3da
PE
13308 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13309 deduce are never used uninitialized.
c2ed9c8b 13310 * term.c (encode_terminal_code): Likewise.
6be7d3da 13311
75f8807f 13312 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13313
50938595
PE
13314 * tparam.h: New file.
13315 * term.c, tparam.h: Include it.
13316 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13317 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13318 Move these decls to tparam.h, and make them agree with what
13319 is actually in tparam.c. The previous trick of using incompatible
13320 decls in different modules does not conform to the C standard.
13321 All callers of tparam changed to use tparam's actual API.
13322 * tparam.c (tparam1, tparam, tgoto):
13323 Use const pointers where appropriate.
13324
fbceeba2
PE
13325 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13326 * cm.h (struct cm): Likewise.
13327 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13328 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13329 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13330 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13331 (turn_on_face, init_tty): Likewise.
13332 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13333
7f3f1250
PE
13334 * term.c (term_mouse_position): Rename local to avoid shadowing.
13335
e6ca6543
PE
13336 * alloc.c (mark_ttys): Move decl from here ...
13337 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13338
c40f8d15
AS
133392011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13340
13341 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13342
cfe0661d
JB
133432011-03-09 Juanma Barranquero <lekktu@gmail.com>
13344
13345 * search.c (compile_pattern_1): Remove argument regp, unused since
13346 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13347 (compile_pattern): Don't pass it.
13348
0afb4571
J
133492011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13350
13351 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13352 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13353 for ! HAVE_GTK3.
13354 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13355
13356 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13357
13358 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13359 gdk_window_get_screen, gdk_window_get_geometry,
13360 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13361 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13362 (xg_get_pixbuf_from_pixmap): New function.
13363 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13364 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13365 Call xg_get_pixbuf_from_pixmap instead of
13366 gdk_pixbuf_get_from_drawable.
13367 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13368 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13369 (xg_check_special_colors): Use GtkStyleContext and its functions
13370 for HAVE_GTK3.
13371 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13372 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13373 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13374 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13375 Call gtk_widget_get_preferred_size.
0afb4571
J
13376 (xg_frame_resized): gdk_window_get_geometry only takes 5
13377 parameters.
44f230aa
SM
13378 (xg_win_to_widget, xg_event_is_for_menubar):
13379 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13380 (xg_set_widget_bg): New function.
13381 (delete_cb): New function.
895009e1 13382 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13383 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13384 (xg_set_background_color): Call xg_set_widget_bg.
13385 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13386 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13387 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13388 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13389 if ! HAVE_GTK3.
13390 (update_frame_tool_bar): Call gtk_widget_hide.
13391 (xg_initialize): Use GDK_KEY_g.
13392
13393 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13394 if ! HAVE_GTK3
13395 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13396
13397 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13398 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13399 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13400
1c2cc4ef
JB
134012011-03-08 Juanma Barranquero <lekktu@gmail.com>
13402
13403 * w32xfns.c (select_palette): Check success of RealizePalette against
13404 GDI_ERROR, not zero.
13405
33383987 13406See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13407
13408;; Local Variables:
13409;; coding: utf-8
aac0c6e3
MR
13410;; End:
13411
2f097256 13412 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13413
13414 This file is part of GNU Emacs.
13415
13416 GNU Emacs is free software: you can redistribute it and/or modify
13417 it under the terms of the GNU General Public License as published by
13418 the Free Software Foundation, either version 3 of the License, or
13419 (at your option) any later version.
13420
13421 GNU Emacs is distributed in the hope that it will be useful,
13422 but WITHOUT ANY WARRANTY; without even the implied warranty of
13423 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13424 GNU General Public License for more details.
13425
13426 You should have received a copy of the GNU General Public License
13427 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.