* src/nsterm.m, src/nsterm.h (ns_etc_directory): Fix type, empty return.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
7c4e8ec0
GM
12012-07-09 Glenn Morris <rgm@gnu.org>
2
3 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
4
26bccfae
PE
52012-07-09 Paul Eggert <eggert@cs.ucla.edu>
6
a0bee46f
PE
7 * process.c (wait_reading_process_output): 'waitchannels' was unset
8 when read_kbd || !NILP (wait_for_cell); fix this.
9
5994c183
PE
10 Add GCC-style 'const' attribute to functions that can use it.
11 * character.h (char_resolve_modifier_mask):
12 * keyboard.h (make_ctrl_char):
13 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
14 (init_character_once, next_almost_prime, init_fns, init_image)
15 (flush_pending_output, init_sound):
16 * mem-limits.h (start_of_data):
17 * menu.h (finish_menu_items):
18 Add ATTRIBUTE_CONST.
19 * emacs.c (DEFINE_DUMMY_FUNCTION):
20 Declare the dummy function with ATTRIBUTE_CONST.
21 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
22 Add decls with ATTRIBUTE_CONST.
23
26bccfae
PE
24 Minor improvements to make_formatted_string.
25 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
26 where int is good enough, as vsprintf returns an int.
27 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
28
a8290ec3
DA
292012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
30
31 Use make_formatted_string to avoid double length calculation.
32 * lisp.h (make_formatted_string): New prototype.
33 * alloc.c (make_formatted_string): New function.
34 * buffer.c (Fgenerate_new_buffer_name): Use it.
35 * dbus.c (syms_of_dbusbind): Likewise.
36 * editfns.c (Fcurrent_time_zone): Likewise.
37 * filelock.c (get_boot_time): Likewise.
38 * frame.c (make_terminal_frame, set_term_frame_name)
39 (x_report_frame_params): Likewise.
40 * image.c (gs_load): Likewise.
41 * minibuf.c (get_minibuffer): Likewise.
42 * msdos.c (dos_set_window_size): Likewise.
43 * process.c (make_process): Likewise.
44 * xdisp.c (ensure_echo_area_buffers): Likewise.
45 * xsettings.c (apply_xft_settings): Likewise.
46
d01ba2f1
GM
472012-07-09 Glenn Morris <rgm@gnu.org>
48
49 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
50 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
51 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
52 * nsterm.h (ns_etc_directory): Add it.
53 * callproc.c [HAVE_NS]: Include nsterm.h.
54 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
55
f1f924b6
DA
562012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
57
58 Move marker debugging code under MARKER_DEBUG.
59 * marker.c (MARKER_DEBUG): Move marker debugging code under
60 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
61 for bootstrap with --enable-checking (~3x slowdown reported
62 by Juanma Barranquero <lekktu@gmail.com>).
63 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
64
ab531b66
PE
652012-07-08 Paul Eggert <eggert@cs.ucla.edu>
66
67 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
68 See <http://bugs.gnu.org/11825#29>.
69
c4b3bc8a
EZ
702012-07-08 Eli Zaretskii <eliz@gnu.org>
71
72 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
73 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
74 (display_line): Add commentary about displaying truncation glyphs
75 on GUI frames.
76 (produce_special_glyphs): Move here from term.c.
77
78 * term.c (produce_special_glyphs): Move to xdisp.c.
79
80 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
81 section.
c4b3bc8a 82
b676b881
AS
832012-07-07 Andreas Schwab <schwab@linux-m68k.org>
84
f17c5273
AS
85 * xdisp.c (display_line): Avoid warning about implicit declaration
86 of FRAME_FONT.
87
298819b9
AS
88 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
89
b676b881
AS
90 * lisp.h: Remove empty conditional.
91
6045c4fd
PE
922012-07-07 Paul Eggert <eggert@cs.ucla.edu>
93
b3350bf9
PE
94 * lread.c (load_path_check): Now static.
95
6045c4fd
PE
96 Fix some minor --with-ns problems found by static checking.
97 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
98 (x_set_font) [!HAVE_X_WINDOWS]:
99 * image.c (xpm_load_image) [HAVE_NS]:
100 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
101 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
102 Remove unused local.
103 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
104 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
105 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
106 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
107 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
108 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
109 Fix pointer signedness problem.
110 * xfaces.c (FRAME_X_FONT_TABLE):
111 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
112
929e7845
GM
1132012-07-07 Glenn Morris <rgm@gnu.org>
114
115 * lread.c (load_path_check): New function, split from init_lread.
116 (init_lread): Reorganize. Motivation:
117 If EMACSLOADPATH is set, check/warn about that rather than the
118 defaults, which we are not going to use. Hence we can remove
119 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
120 Don't warn if site-lisp directories are missing.
121 If not installed, start from a blank load-path, since
122 PATH_LOADSEARCH refers to the eventual installation directories.
123
58dd0aa4
EZ
1242012-07-07 Eli Zaretskii <eliz@gnu.org>
125
126 Support truncation and continuation glyphs on GUI frames, when
127 fringes are disabled. (Bug#11832)
128 * xdisp.c (init_iterator): Get dimensions of truncation and
129 continuation glyphs even if on GUI frames. Adjust
130 it->last_visible_x on GUI frames when the left or right fringes,
131 or both, are absent.
132 (start_display, move_it_in_display_line_to): Handle the case of a
133 GUI frame without a fringe to display continuation or truncation
134 glyphs.
135 (insert_left_trunc_glyphs): Support GUI frames: make sure
136 truncation glyphs overwrite enough glyphs from the current line to
137 have sufficient space in pixels.
138 (display_line): Support truncation and continuation glyphs on GUI
139 frames. If some spare pixels are left on the line after inserting
140 the truncation glyphs, fill that space with a stretch glyph of a
141 suitably computed width.
142
143 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
144 produce_glyphs, to support GUI sessions.
145
31571fd7
PE
1462012-07-07 Paul Eggert <eggert@cs.ucla.edu>
147
5a16b9bc
PE
148 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
149
f3047c75
PE
150 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
151
31571fd7
PE
152 Do not require float-time's arg to fit in time_t (Bug#11825).
153 This works better on hosts where time_t is unsigned, and where
154 float-time is applied to the (negative) difference between two times.
155 * editfns.c (decode_time_components): Last arg is now double *,
156 not int *, and means to store all the result as a double, without
157 worrying about whether the seconds part fits in time_t.
158 All callers changed.
159 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
160 All callers changed.
161 (Ffloat_time): Do not fail merely because the specified time falls
162 outside of time_t range.
163
4516fbef
GM
1642012-07-07 Glenn Morris <rgm@gnu.org>
165
166 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
167 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
168 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
169
07adc2c6
JB
1702012-07-07 Juanma Barranquero <lekktu@gmail.com>
171
172 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
173 Update dependencies.
174
175 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
176
fd573f31
PE
1772012-07-06 Paul Eggert <eggert@cs.ucla.edu>
178
fee5959d
PE
179 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
180 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
181 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
182 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
183 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
184 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
185
fd573f31
PE
186 * xfont.c (compare_font_names): Redo to omit the need for casts.
187
ddadbc0e
AS
1882012-07-06 Andreas Schwab <schwab@linux-m68k.org>
189
fca8d6b6
AS
190 * xfns.c (Fx_change_window_property): Doc fix.
191 * w32fns.c (Fx_change_window_property): Doc fix.
192
ddadbc0e
AS
193 * w32fns.c (Fx_window_property): Accept the same arguments as the
194 X Windows version. Doc fix.
195 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
196
f247498e
JB
1972012-07-06 Juanma Barranquero <lekktu@gmail.com>
198 Eli Zaretskii <eliz@gnu.org>
199
200 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
201 Windows-specific code from nt/config.nt moved here.
202 Obsolete settings removed.
203
216ee680
PE
2042012-07-06 Paul Eggert <eggert@cs.ucla.edu>
205
206 * process.c: Avoid unnecessary calls to gettime.
207 (wait_reading_process_output): Don't get the time of day
208 when gobbling data immediately and not waiting, as there's no need
209 for it in that case. This removes a FIXME.
210
bdd091e4
JD
2112012-07-06 Jan Djärv <jan.h.d@swipnet.se>
212
213 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
214 is defined (Bug#11768).
215
9d44f8ce
DA
2162012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
217
218 Fix marker debugging code.
219 * marker.c (byte_char_debug_check): Do not perform the check
220 if buffer is not multibyte.
090bd7cb
JB
221 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
222 Call byte_char_debug_check with correct arguments.
9d44f8ce 223
90fc4786
DA
2242012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
225
226 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
227 * marker.c (byte_char_debug_check, count_markers):
228 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
229 (byte_debug_flag): Remove.
230 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
231 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
232
7b7ae965
DA
2332012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
234
4e57b342
DA
235 Avoid code repetition in marker-related functions.
236 * marker.c (attach_marker): New function.
237 (Fset_marker, set_marker_restricted, set_marker_both)
238 (set_marker_restricted_both): Use it.
239 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
240 Consistently rename charno to charpos.
241 (marker_position): Add eassert.
242 (marker_byte_position): Convert to eassert.
243
2442012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
245
246 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 247 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 248 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 249
657924ff
DA
2502012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
251
252 Introduce fast path for the widely used marker operation.
253 * alloc.c (build_marker): New function.
254 * lisp.h (build_marker): New prototype.
255 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
256 * composite.c (autocmp_chars): Likewise.
257 * editfns.c (buildmark): Remove.
258 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
259 (save_restriction_save): Use build_marker.
260 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
261 * window.c (save_window_save): Likewise.
262
041a49a6
DA
2632012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
264
265 Do not use Fdelete_overlay in delete_all_overlays
266 to avoid redundant calls to unchain_overlay.
267 * buffer.c (drop_overlay): New function.
268 (delete_all_overlays, Fdelete_overlay): Use it.
269 * minibuf.c (get_minibuffer): Fix comment.
270
7dca65a4
PE
2712012-07-06 Paul Eggert <eggert@cs.ucla.edu>
272
273 Port to OpenBSD 5.1 amd64.
274 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
275 This is needed for OpenBSD, and should be harmless on all BSD systems.
276 Also, include <sys/sysctl.h>, as it should be available on all
277 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
278 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
279 use p_pid member, not kp_proc.pid.
280
8eb876e2
GM
2812012-07-06 Glenn Morris <rgm@gnu.org>
282
283 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
284
38182d90
PE
2852012-07-05 Paul Eggert <eggert@cs.ucla.edu>
286
287 More xmalloc and related cleanup.
288 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
289 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
290 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
291 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
292 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
293 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
294 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
295 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
296 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
297 * xterm.c:
298 Omit needless casts involving void * pointers and allocation.
299 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
300 as the former is more robust if P's type is changed.
301 Prefer xzalloc to xmalloc + memset 0.
302 Simplify malloc-or-realloc to realloc.
303 Don't worry about xmalloc returning a null pointer.
304 Prefer xstrdup to xmalloc + strcpy.
305 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
306 growing it.
307 * keyboard.c (apply_modifiers_uncached): Prefer local array to
308 alloca of a constant.
309
6dd5a677
EZ
3102012-07-05 Eli Zaretskii <eliz@gnu.org>
311
312 * xdisp.c (display_line): Fix horizontal pixel coordinates when
313 hscroll is larger than the line width. Fixes long and futile
314 looping inside extend_face_to_end_of_line (on a TTY) producing
315 glyphs that are not needed and thrown away.
316
6b312f0f
DA
3172012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
318
319 * marker.c (set_marker_restricted_both): Simplify by using
320 clip_to_bounds.
321
f520ef9b
PE
3222012-07-05 Paul Eggert <eggert@cs.ucla.edu>
323
324 * editfns.c (region_limit): Simplify by using clip_to_bounds.
325
383b7c95
JD
3262012-07-05 Jan Djärv <jan.h.d@swipnet.se>
327
328 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
329 not defined (Bug#11768).
330 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
331 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
332 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
333 followed by gtk_box_set_homogeneous (Bug#11768).
334 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
335 (update_theme_scrollbar_width, xg_create_scroll_bar):
336 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
337 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
338 (is_box_type): New function (Bug#11768).
339 (xg_tool_item_stale_p): Call is_box_type.
5293d758 340 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
341 with default display (Bug#11768).
342
d6e7bf45
EZ
3432012-07-05 Eli Zaretskii <eliz@gnu.org>
344
345 * xdisp.c (window_hscroll_limited): New function.
346 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
347 coordinates when window's hscroll is set to insanely large
348 values. (Bug#11857)
349
431391ec
JB
3502012-07-05 Juanma Barranquero <lekktu@gmail.com>
351
352 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
353 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
354
23f86fce
DA
3552012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
356
357 Cleanup xmalloc.
358 * lisp.h (xzalloc): New prototype. Omit needless casts.
359 * alloc.c (xzalloc): New function. Omit needless casts.
360 * charset.c: Omit needless casts. Convert all calls to
361 xmalloc with following memset to xzalloc.
362 * dispnew.c: Likewise.
363 * fringe.c: Likewise.
364 * image.c: Likewise.
365 * sound.c: Likewise.
366 * term.c: Likewise.
367 * w32fns.c: Likewise.
368 * w32font.c: Likewise.
369 * w32term.c: Likewise.
370 * xfaces.c: Likewise.
371 * xfns.c: Likewise.
372 * xterm.c: Likewise.
373 * atimer.c: Omit needless casts.
374 * buffer.c: Likewise.
375 * callproc.c: Likewise.
376 * ccl.c: Likewise.
377 * coding.c: Likewise.
378 * composite.c: Likewise.
379 * doc.c: Likewise.
380 * doprnt.c: Likewise.
381 * editfns.c: Likewise.
382 * emacs.c: Likewise.
383 * eval.c: Likewise.
384 * filelock.c: Likewise.
385 * fns.c: Likewise.
386 * gtkutil.c: Likewise.
387 * keyboard.c: Likewise.
388 * lisp.h: Likewise.
389 * lread.c: Likewise.
390 * minibuf.c: Likewise.
391 * msdos.c: Likewise.
392 * print.c: Likewise.
393 * process.c: Likewise.
394 * region-cache.c: Likewise.
395 * search.c: Likewise.
396 * sysdep.c: Likewise.
397 * termcap.c: Likewise.
398 * terminal.c: Likewise.
399 * tparam.c: Likewise.
400 * w16select.c: Likewise.
401 * w32.c: Likewise.
402 * w32reg.c: Likewise.
403 * w32select.c: Likewise.
404 * w32uniscribe.c: Likewise.
405 * widget.c: Likewise.
406 * xdisp.c: Likewise.
407 * xmenu.c: Likewise.
408 * xrdb.c: Likewise.
409 * xselect.c: Likewise.
410
0497dc44
PE
4112012-07-05 Paul Eggert <eggert@cs.ucla.edu>
412
413 * fileio.c (time_error_value): Check the right error number.
414 Problem reported by Troels Nielsen in
415 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
416
356e7178
PE
4172012-07-04 Paul Eggert <eggert@cs.ucla.edu>
418
4e71fd89
PE
419 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
420 This should be fixed in a better way; see Eli Zaretskii in
421 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
422 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
423
f0941253
PE
424 * fileio.c (time_error_value): Rename from special_mtime.
425 The old name's problems were noted by Eli Zaretskii in
426 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
427
065c9eb4
PE
428 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
429 This variable's comment says Emacs needs at least one GDB-visible
430 symbol of type enum pvec_type, to work around GDB problems.
431 The symbol's value doesn't matter.
432
356e7178
PE
433 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
434 that causes compilation to fail on pre-C99 compilers.
435
95f61aa2
JB
4362012-07-04 Juanma Barranquero <lekktu@gmail.com>
437
438 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
439 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
440
3884d954
DA
4412012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
442
d209e2fb 443 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
444 headers for buffer_defaults and buffer_local_symbols.
445 Reported by Juanma Barranquero <lekktu@gmail.com>.
446
ee28be33
SM
4472012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
448
449 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
450 * lisp.h (enum pvec_type): Use fewer bits.
451 (PSEUDOVECTOR_SIZE_BITS): New constant.
452 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
453 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
454 change in pvec_type.
455 (PSEUDOVECTOR_TYPEP): New macro.
456 (TYPED_PSEUDOVECTORP): Use it.
457 * fns.c (internal_equal): Adapt code to extract pvectype.
458 * emacs.c (gdb_pvec_type): Update type.
459 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
460 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
461 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
462 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
463 (sweep_vectors): Use it. Use local var `total_bytes' instead of
464 abusing vector->header.next.nbytes.
465 (live_vector_p): Use PVEC_TYPE.
466 (mark_object): Adapt code to extract pvectype. Use switch.
467
c7f2cd7f
PE
4682012-07-04 Paul Eggert <eggert@cs.ucla.edu>
469
470 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
471 Tighten new eassert a bit.
472
8ce70ed2
DA
4732012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
474
475 Fix compilation with --enable-gcc-warnings and -O1
476 optimization level.
477 * doprnt.c (doprnt): Change type of tem to int, initialize
478 to avoid compiler warning. Add eassert.
479 * search.c (simple_search): Initialize match_byte to avoid
480 compiler warning. Add eassert.
481
dea7f1e5
PE
4822012-07-04 Paul Eggert <eggert@cs.ucla.edu>
483
24a212eb
PE
484 Avoid weird behavior with large horizontal scrolls.
485 Without this change, for example, large hscroll values would
486 mess up Emacs's display on Fedora 15 x86, presumably due to
487 overflows in int calculations in the display code.
488 Also, if buffers had long lines, Emacs would freeze.
489 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
490 (set_window_hscroll): New function, containing the old guts of
491 Fset_window_hscroll. Return the clipped value.
492 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
493 This avoids the need to check against PTRDIFF_MAX.
494
dea7f1e5
PE
495 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
496
76046526
DA
4972012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
498
499 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
500
39adff0d
PE
5012012-07-04 Paul Eggert <eggert@cs.ucla.edu>
502
63807d47
PE
503 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
504 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
505 since GCC 4.4.6 issues a bogus warning for them.
506
39adff0d
PE
507 Fix bugs in file timestamp newness comparisons.
508 * fileio.c (Ffile_newer_than_file_p):
509 * lread.c (Fload): Use full timestamp resolution of files,
510 not just the 1-second resolution, so that files that are only
511 slightly newer still count as newer.
512 * fileio.c (Ffile_newer_than_file_p): Don't assume file
513 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
514
dbeed9a6
PE
5152012-07-03 Paul Eggert <eggert@cs.ucla.edu>
516
517 * fileio.c: Improve handling of file time marker. (Bug#11852)
518 (special_mtime): New function.
519 (Finsert_file_contents, Fverify_visited_file_modtime):
520 Use it to set special mtime values consistently.
521
636334d6
AS
5222012-07-03 Andreas Schwab <schwab@linux-m68k.org>
523
524 * fileio.c (Finsert_file_contents): Properly handle st_mtime
525 marker for non-existing file. (Bug#11852)
526
e2017fe2
GM
5272012-07-03 Glenn Morris <rgm@gnu.org>
528
529 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
530 and did not make it into globals.h).
531
404dbd37
TT
5322012-07-03 Tom Tromey <tromey@redhat.com>
533
534 * window.c (Fset_window_margins, Fset_window_fringes)
535 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
536 * textprop.c (Fprevious_property_change): No longer static.
537 * syntax.c (Fsyntax_table_p): No longer static.
538 * process.c (Fget_process, Fprocess_datagram_address): No longer
539 static.
540 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
541 * keyboard.c (Fcommand_execute): No longer static.
542 Remove EXFUN.
543 * insdel.c (Fcombine_after_change_execute): No longer static.
544 * image.c (Finit_image_library): No longer static.
545 * fileio.c (Fmake_symbolic_link): No longer static.
546 * eval.c (Ffetch_bytecode): No longer static.
547 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
548 * doc.c (Fdocumentation_property, Fsnarf_documentation):
549 No longer static.
404dbd37
TT
550 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
551 static.
552 * dired.c (Ffile_attributes): No longer static.
553 * composite.c (Fcomposition_get_gstring): No longer static.
554 * callproc.c (Fgetenv_internal): No longer static.
555
556 * ccl.h: Remove EXFUNs.
557 * buffer.h: Remove EXFUNs.
558 * dispextern.h: Remove EXFUNs.
559 * intervals.h: Remove EXFUNs.
560 * fontset.h: Remove EXFUN.
561 * font.h: Remove EXFUNs.
562 * dosfns.c (system_process_attributes): Remove EXFUN.
563 * keymap.h: Remove EXFUNs.
564 * lisp.h: Remove EXFUNs.
565 * w32term.h: Remove EXFUNs.
566 * window.h: Remove EXFUNs.
567 * xsettings.h: Remove EXFUN.
568 * xterm.h: Remove EXFUN.
569
8e4fd1e1
GM
5702012-07-03 Glenn Morris <rgm@gnu.org>
571
572 * lisp.h (Frandom): Make it visible to C.
573 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
574 buffer for invisible buffers. (Bug#1229)
575
ca95b3eb
DA
5762012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
577
578 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
579 values which aren't power of 2.
580 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
581 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
582 accordingly.
583
7555c33f
SM
5842012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
585
586 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
587
588 * alloc.c (mark_object): Revert part of last patch to use `switch'.
589
d12e8f5a
DA
5902012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
591
592 * alloc.c (allocate_vector_block): Remove redundant
593 calls to mallopt if DOUG_LEA_MALLOC is defined.
594 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
595 avoid calls to mallopt if zero_vector is returned.
596
296094c3
DA
5972012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
598
599 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
600 is enabled, avoid dereferencing NULL current_sblock if
601 running undumped.
602
36429c89
DA
6032012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
604
605 Cleanup basic buffer management.
606 * buffer.h (struct buffer): Change layout to use generic vector
607 marking code. Fix some comments. Change type of 'clip_changed'
608 to bitfield. Remove unused #ifndef old.
609 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
610 (GET_OVERLAYS_AT): Fix indentation.
611 (for_each_per_buffer_object_at): New macro.
612 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
613 (Fbuffer_local_variables): Use it.
614 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
615 * alloc.c (allocate_buffer): Adjust to match new layout of
616 struct buffer. Fix comment.
617 (mark_overlay): New function.
618 (mark_buffer): Use it. Use mark_vectorlike to mark normal
619 Lisp area of struct buffer.
620 (mark_object): Use it. Adjust marking of misc objects
621 and related comments.
622
3b3e4cac
PE
6232012-07-02 Paul Eggert <eggert@cs.ucla.edu>
624
625 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
626 wrapper that is not needed because the wrapped code is a no-op (zero
627 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
628 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
629
cf5c0175
DA
6302012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
631
632 * alloc.c (mark_buffer): Simplify. Remove prototype.
633 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 634 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
635 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
636 redundant calls to mark_vectorlike for bool vectors.
637
ca26824c
GM
6382012-06-30 Glenn Morris <rgm@gnu.org>
639
2e4c5312
GM
640 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
641
ca26824c
GM
642 * epaths.in (PATH_SITELOADSEARCH): New.
643 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
644 This is rather than relying on --enable-locallisppath elements
645 having "site-lisp" in their names. (Bug#10208#25, 11658)
646
0d23c240
EZ
6472012-06-30 Eli Zaretskii <eliz@gnu.org>
648
c9240d7a
EZ
649 * w32proc.c (sys_select): Accept and ignore one more argument.
650
651 * w32.c (emacs_gnutls_pull): Call select with one more argument.
652
0d23c240 653 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 654 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
655
656 * sysdep.c: Don't include dos.h and dosfns.h.
657
658 * process.c (sys_select):
659 * msdos.c (sys_select): Accept one more argument and ignore it.
660
661 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
662 adapt data types and code to that.
663
664 * dosfns.c:
665 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
666 which clashes with the gnulib function of the same name.
667
af5a5a98
AS
6682012-06-30 Andreas Schwab <schwab@linux-m68k.org>
669
c5e4379c
AS
670 * font.c (font_style_to_value, font_style_symbolic)
671 (font_prop_validate_style): Add type checks for values in
672 font_style_table.
673
af5a5a98
AS
674 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
675 argument.
676 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
677 uses.
678
8d38f461
EZ
6792012-06-29 Eli Zaretskii <eliz@gnu.org>
680
2e5a6631
EZ
681 * xdisp.c (try_window_id): Undo last change.
682
8d38f461
EZ
683 * w32.c (getwd): Adjust commentary about startup_dir.
684 (init_environment): Always call sys_access, even in non-MSVC
685 builds. Don't chdir to the directory of the Emacs executable.
686 This undoes code from 1997 which was justified by the need to
687 "avoid conflicts when removing and renaming directories". But its
688 downside was that every relative file name was being interpreted
689 relative to the directory of the Emacs executable, which can never
690 be TRT. In particular, it broke sys_access when called with
691 relative file names.
692 (sys_access): Map GetLastError to errno.
693
2af3565e
DA
6942012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
695
696 * window.h (struct window): Change type of 'fringes_outside_margins'
697 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 698 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
699 Adjust comment.
700 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
701 to ptrdiff_t.
702
c8d3a25c 7032012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 704
c8d3a25c
GM
705 * gnutls.c (emacs_gnutls_handshake):
706 Add QUIT to make the loop interruptible.
57570cd3 707
c8d3a25c 7082012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 709
c8d3a25c
GM
710 * charset.c (init_charset): Make lack of etc/charsets fatal.
711
3e984ee8
DA
7122012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
713
714 * editfns.c (region_limit): Fix type mismatch.
715
ef884f23
DA
7162012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
717
718 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
719 undefined. Convert from xassert to eassert.
720 * nsmenu.m: Convert from xassert to eassert.
721 * nsterm.m: Likewise.
722
7d7e0027
SM
7232012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
724
725 * editfns.c (region_limit): Clip to narrowing (bug#11770).
726
aa754e6a
PE
7272012-06-28 Paul Eggert <eggert@cs.ucla.edu>
728
729 Avoid integer overflow on scroll-left and scroll-right.
730 * window.c (HSCROLL_MAX): New macro.
731 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
732 overflow when requested scroll falls outside ptrdiff_t range.
733
80b00b08
DA
7342012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
735
736 * window.h (struct window): Change type of 'hscroll',
737 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
738 'last_modified' and 'last_overlay_modified' to EMACS_INT.
739 Adjust users accordingly.
740 * xdisp.c (try_cursor_movement): Replace type check with eassert.
741 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
742 from EMACS_INT to ptrdiff_t.
743 (make_window): Omit redundant initialization.
744
62b2bcf6
JB
7452012-06-28 Juanma Barranquero <lekktu@gmail.com>
746
747 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
748
45942c7d
DA
7492012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
750
751 * window.h (struct window): Change type of 'use_time' and
752 'sequence_number' from Lisp_Object to int.
753 * frame.c (make_frame): Adjust users accordingly.
754 * print.c (print_object): Likewise.
755 * window.c (select_window, Fwindow_use_time, make_parent_window)
756 (make_window): Likewise.
757
e509cfa6
DA
7582012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
759
760 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
761 enabled with --enable-checking=[all,glyphs] configure option.
762 Fix GLYPH_DEBUG usage assuming that it may be undefined,
763 adjust comments accordingly.
764 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
765 undefined, adjust comments accordingly.
766 * image.c: Likewise.
767 * scroll.c: Likewise.
768 * w32fns.c: Likewise.
769 * w32term.c: Likewise.
770 * xdisp.c: Likewise.
771 * xfaces.c: Likewise.
772 * xfns.c: Likewise.
773 * xterm.c: Likewise.
774
a54e2c05
DA
7752012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
776
777 Generalize run-time debugging checks.
778 * dispextern.h (XASSERTS): Remove.
779 * fontset.c (xassert): Remove.
780 Convert from xassert to eassert.
781 * alloc.c: Convert from xassert to eassert.
782 * bidi.c: Likewise.
783 * dispnew.c: Likewise.
784 * fns.c: Likewise.
785 * fringe.c: Likewise.
786 * ftfont.c: Likewise.
787 * gtkutil.c: Likewise.
788 * image.c: Likewise.
789 * keyboard.c: Likewise.
790 * menu.c: Likewise.
791 * process.c: Likewise.
792 * scroll.c: Likewise.
793 * sound.c: Likewise.
794 * term.c: Likewise.
795 * w32console.c: Likewise.
796 * w32fns.c: Likewise.
797 * w32term.c: Likewise.
798 * window.c: Likewise.
799 * xdisp.c: Likewise.
800 * xfaces.c: Likewise.
801 * xfns.c: Likewise.
802 * xselect.c: Likewise.
803 * xterm.c: Likewise.
804
1ec4b7b2
SM
8052012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
806
807 * fns.c (maybe_resize_hash_table): Output message when growing the
808 purify-hashtable.
809
2014308a
DA
8102012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
811
812 * alloc.c (allocate_string_data): Remove dead code.
813 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
814 avoid GCC warning about unused macro.
815
246155eb
DA
8162012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
817
818 * alloc.c (allocate_string): Omit intervals initialization.
819 * alloc.c (make_uninit_multibyte_string): Initialize intervals
820 as in make_pure_string and make_pure_c_string.
821
43184b7b
DA
8222012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
823
d209e2fb 824 * alloc.c (allocate_string): Fix last change.
43184b7b 825
3fe6dd74
DA
8262012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
827
d209e2fb 828 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
829 to memset, add explicit initialization where appropriate.
830
1ba6038a
GM
8312012-06-27 Glenn Morris <rgm@gnu.org>
832
833 * lisp.mk (lisp): Remove paths.elc.
834
c89926a5
CY
8352012-06-27 Chong Yidong <cyd@gnu.org>
836
837 * doc.c (Fsubstitute_command_keys): Fix punctuation.
838
ed6b3510
JW
8392012-06-26 John Wiegley <johnw@newartisans.com>
840
1ec4b7b2 841 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
842 on Mac OS X Lion: __mod_init_func and __mod_term_func.
843
ed6b3510
JW
844 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
845 when building with Clang.
846
8edd4a2b
SM
8472012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
848
849 * eval.c (Fapply): Allow calling it with a single argument.
850
f6f62d1b
EZ
8512012-06-26 Eli Zaretskii <eliz@gnu.org>
852
853 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
854 _stricmp and _strnicmp.
855 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
856
62efea5e
DA
8572012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
858
859 * alloc.c (allocate_window): Zero out non-Lisp part of newly
860 allocated window.
861 (allocate_process): Likewise for new process.
8edd4a2b 862 (allocate_terminal): Change to use offsetof.
62efea5e
DA
863 (allocate_frame): Likewise.
864 * frame.c (make_frame): Omit redundant initialization.
865 * window.c (make_parent_window): Use memset.
866 (make_window): Omit redundant initialization.
867 * process.c (make_process): Omit redundant initialization.
868 * terminal.c (create_terminal): Likewise.
869
42997f4d
DA
8702012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
871
872 * term.c (delete_tty): Remove redundant call to memset.
873
1130ecfc
DA
8742012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
875
876 * alloc.c: Remove build_string.
877 * lisp.h: Define build_string as static inline. This provides
878 a better opportunity to optimize away calls to strlen when the
879 function is called with compile-time constant argument.
880 * image.c (imagemagick_error): Convert to build_string.
881 * w32proc.c (sys_spawnve): Likewise.
882 * xterm.c (x_term_init): Likewise.
883
cf38a720
PE
8842012-06-26 Paul Eggert <eggert@cs.ucla.edu>
885
99027bdd
PE
886 Use sprintf return value instead of invoking strlen on result.
887 In the old days this wasn't portable, since some sprintf
888 implementations returned char *. But they died out years ago and
889 Emacs already assumes sprintf returns int.
890 Similarly for float_to_string.
891 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
892 * ccl.c (ccl_driver):
893 * character.c (string_escape_byte8):
894 * data.c (Fnumber_to_string):
895 * doprnt.c (doprnt):
896 * print.c (print_object):
897 * xdisp.c (message_dolog):
898 * xfns.c (syms_of_xfns):
899 Use sprintf or float_to_string result to avoid need to call strlen.
900 * data.c (Fnumber_to_string):
901 Use make_unibyte_string, since the string must be ASCII.
902 * lisp.h, print.c (float_to_string): Now returns int length.
903 * term.c (produce_glyphless_glyph):
904 Use sprintf result rather than recomputing it.
905
cf38a720
PE
906 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
907 * Makefile.in (ALL_CFLAGS):
908 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
909 * gmalloc.c, regex.c: Include <config.h> unconditionally.
910
3511c784
DA
9112012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
912
0a08eb21 913 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
914 strcasecmp if available.
915 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
916
fb7da12e
AS
9172012-06-25 Andreas Schwab <schwab@linux-m68k.org>
918
919 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
920 Avoid comma operator.
921 * menu.c (push_submenu_start, push_submenu_end)
922 (push_left_right_boundary, push_menu_pane): Likewise.
923 * msdos.c (dos_rawgetc): Likewise.
924
afa2ffd8
DA
9252012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
926
927 * xfns.c (xic_create_fontsetname): Remove redundant calls
928 to memset.
929
b3b4476b
PE
9302012-06-25 Paul Eggert <eggert@cs.ucla.edu>
931
4495ff38
PE
932 * gtkutil.c (get_utf8_string): Remove redundant assignment.
933 sprintf already null-terminates its output.
934
b3b4476b
PE
935 * xfns.c (x_window): Remove redundant cast.
936
b00876c9
DA
9372012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
938
939 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
940 `const char *' to `char *' to avoid compiler warning.
941
d188e26b
PE
9422012-06-24 Paul Eggert <eggert@cs.ucla.edu>
943
885d1d74
PE
944 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
945 instead of truncating it to 63 (admittedly a generous limit).
946
d188e26b
PE
947 * process.c: Fix spelling and caps in comments.
948
e2f560b1
DN
9492012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
950
e86db54b 951 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
952 * sysdep.c (setpgrp): Remove definition, not used in this file.
953
7583a3a1
JB
9542012-06-24 Juanma Barranquero <lekktu@gmail.com>
955
956 * makefile.w32-in: Update dependencies.
957
696056c2
EZ
9582012-06-24 Eli Zaretskii <eliz@gnu.org>
959
960 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
961 (SYSTIME_H): Add nt/inc/sys/time.h.
962
963 * systime.h [WINDOWSNT]: Include sys/time.h.
964
965 * s/ms-w32.h (struct timespec): Definition moved from
966 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
967
845ca893
PE
9682012-06-24 Paul Eggert <eggert@cs.ucla.edu>
969
970 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
971 * buffer.h (buffer_slot_type_mismatch):
972 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
973 * eval.c (unwind_to_catch):
974 * image.c (my_png_error, my_error_exit):
975 * keyboard.c (quit_throw_to_read_char, user_error)
976 (Fexit_recursive_edit, Fabort_recursive_edit):
977 * lisp.h (die, args_out_of_range, args_out_of_range_3)
978 (wrong_type_argument, buffer_overflow, __executable_start)
979 (memory_full, buffer_memory_full, string_overflow, Fthrow)
980 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
981 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
982 (fatal):
983 (child_setup) [!DOS_NT]:
984 * lread.c (end_of_file_error, invalid_syntax):
985 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
986 * puresize.h (pure_write_error):
987 * search.c (matcher_overflow):
988 * sound.c (sound_perror, alsa_sound_perror):
989 * sysdep.c, syssignal.h (croak):
990 * term.c (maybe_fatal, vfatal):
991 * textprop.c (text_read_only):
992 * undo.c (user_error):
993 * unexmacosx.c (unexec_error):
994 * xterm.c (x_ins_del_lines, x_delete_glyphs):
995 Use _Noreturn rather than NO_RETURN.
996 No need for separate decl merely because of _Noreturn.
997 * sound.c (sound_warning, parse_sound):
998 Remove unnecessary forward decls.
999
f1dd8073
PE
10002012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1001
1002 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1003 * lisp.h (WAIT_READING_MAX): New macro.
1004 * dispnew.c (Fsleep_for, sit_for):
1005 * keyboard.c (kbd_buffer_get_event):
1006 * process.c (Faccept_process_output):
1007 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1008 This improves on the previous patch, which introduced a bug
1009 when time_t is unsigned and as wide as intmax_t.
1010 See <http://bugs.gnu.org/9000#51>.
1011
b82c1755
EZ
10122012-06-23 Eli Zaretskii <eliz@gnu.org>
1013
1014 * dispnew.c (sit_for, Fsleep_for):
1015 * keyboard.c (kbd_buffer_get_event):
1016 * process.c (Faccept_process_output): Avoid compiler warnings when
1017 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1018
ca300656
JB
10192012-06-23 Juanma Barranquero <lekktu@gmail.com>
1020
049ec95b
JB
1021 * makefile.w32-in: Update dependencies.
1022
ca300656
JB
1023 * w32.c (ltime): Add return type and declare static.
1024 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1025
db7b8d06
PE
10262012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1027
1028 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1029 Privately reported by Herbert J. Skuhra.
1030 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1031 All uses changed.
1032 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1033 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1034
0bd8297f
EZ
10352012-06-23 Eli Zaretskii <eliz@gnu.org>
1036
96512555
EZ
1037 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1038 last argument of make_unibyte_string.
1039
0bd8297f
EZ
1040 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1041 language ID in the event parameters.
1042
1043 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1044 event.code, not the obscure "character set ID".
1045
63def6b6
CY
10462012-06-23 Chong Yidong <cyd@gnu.org>
1047
1048 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1049
e8a02204
EZ
10502012-06-23 Eli Zaretskii <eliz@gnu.org>
1051
388cdec0
EZ
1052 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1053 * w32.c (fdutimens): New function.
1054
1055 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1056
1057 * s/ms-w32.h (pselect): Redirect to sys_select.
1058
1059 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1060
e8a02204
EZ
1061 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1062 in the logic of incrementing and decrementing the value of
1063 use_relocatable_buffers.
1064
d054f3fb
PE
10652012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1066
1067 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1068 Privately reported by Herbert J. Skuhra.
1069 [__FreeBSD__]: Remove "*/" typo after "#include".
1070 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1071 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1072 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1073 Don't assume EMACS_TIME and struct timeval are the same type.
1074
d35af63c
PE
10752012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1076
1077 Support higher-resolution time stamps (Bug#9000).
1078 The time stamps are only nanosecond-resolution at the C level,
1079 since that's the best that any real-world system supports now.
1080 But they are picosecond-resolution at the Lisp level, as that's
1081 easy, and leaves room for future OS improvements.
1082
1083 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1084 (LIBES): Use it.
1085
1086 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1087 Don't get current time unless it's needed.
1088
1089 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1090 now provides it if it's absent.
1091 (start_atimer): Port to higher-res time stamps.
1092 Check for time stamp overflow. Don't get current time more
1093 often than is needed.
1094
1095 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1096 Include systime.h, not time.h.
1097 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1098
1099 * dired.c: Include stat-time.h.
1100 (Ffile-attributes): File times now have higher resolution.
1101
1102 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1103 (struct image): Timestamp now has higher resolution.
1104
1105 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1106 has at least microseconds now. All uses removed.
1107 (update_frame, update_single_window, update_window, update_frame_1)
1108 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1109
1110 * editfns.c (time_overflow): Now extern.
1111 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1112 (float-time, Fformat_time_string, Fcurrent_time_string)
1113 (Fcurrent_time_zone): Accept and generate higher-resolution
1114 time stamps.
1115 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1116 (decode_time_components, lisp_seconds_argument): New functions.
1117 (make_time): Now static.
1118 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1119 Report an error if the time is invalid, rather than having the caller
1120 do that.
1121
1122 * fileio.c: Include <stat-time.h>
1123 (Fcopy_file): Copy higher-resolution time stamps.
1124 Prefer to set the time stamp via a file descriptor if that works.
1125 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1126 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1127 (Fvisited_file_modtime, Fset_visited_file_modtime):
1128 Support higher-resolution time stamps.
1129
1130 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1131
1132 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1133
1134 * image.c (prepare_image_for_display, clear_image_cache)
1135 (lookup_image): Port to higer-resolution time stamps.
1136
1137 * keyboard.c (start_polling, bind_polling_period):
1138 Check for time stamp overflow.
1139 (read_char, kbd_buffer_get_event, timer_start_idle)
1140 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1141 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1142 Port to higher-resolution time stamps. Do not assume time_t is signed.
1143 (decode_timer): New function. Timers are now vectors of length 9,
1144 not 8, to accommodate the picosecond component.
1145 (timer_check_2): Use it.
1146
1147 * nsterm.m (select_timeout, timeval_subtract): Remove.
1148 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1149 as they're a bit more accurate and handle overflow better.
1150 (ns_select): Change prototype to be compatible with pselect.
1151 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1152 * nsterm.h (ns_select): Adjust prototype.
1153
1154 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1155 us-resolution time stamps.
1156 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1157
1158 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1159
1160 * lisp.h (time_overflow): New decl.
1161 (wait_reading_process_output): First arg is now intmax_t, not int,
1162 to accommodate larger waits.
1163
1164 * process.h (struct Lisp_Process.read_output_delay):
1165 Now counts nanoseconds, not microseconds.
1166 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1167 EMACS_HAS_USECS.
1168 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1169 (wait_reading_process_output):
1170 Port to ns-resolution time stamps.
1171 (Faccept_process_output, wait_reading_process_output):
1172 Check for time stamp overflow. Do not assume time_t is signed.
1173 (select_wrapper): Remove; we now use pselect.
1174 (Fprocess_attributes): Now generates ns-resolution time stamps.
1175
1176 * sysdep.c: Include utimens.h. Don't include utime.h
1177 or worry about struct utimbuf; gnulib does that for us now.
1178 (gettimeofday): Remove; gnulib provides a substitute.
1179 (make_timeval): New function.
1180 (set_file_times): Now sets ns-resolution time stamps.
1181 New arg FD; all uses changed.
1182 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1183 (system_process_attributes):
1184 Now returns ns-resolution time stamp. All uses changed.
1185 Check for time stamp overflow.
1186
1187 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1188 provides a substitute now.
1189
1190 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1191 since it guarantees struct timespec.
1192 (EMACS_TIME): Now struct timespec, so that we can support
1193 ns-resolution time stamps.
1194 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1195 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1196 (EMACS_USECS): Remove.
1197 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1198 so multiply the arg by 1000 before storing it.
1199 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1200 New macros.
1201 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1202 Port to ns-resolution time stamps.
1203 (EMACS_TIME_NEG_P): Remove; replaced by....
1204 (EMACS_TIME_SIGN): New macro.
1205 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1206 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1207 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1208 (make_timeval, make_lisp_time, decode_time_components): New decls.
1209 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1210 that it mishandled time_t overflow. You can't compare by subtracting!
1211 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1212 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1213
1214 * term.c: Include <sys/time.h>.
1215 (timeval_to_Time): New function, for proper overflow wraparound.
1216 (term_mouse_position, term_mouse_click): Use it.
1217
1218 * undo.c (record_first_change): Support higher-resolution time stamps
1219 in the undo buffer.
1220 (Fprimitive_undo): Use them when restoring time stamps.
1221
1222 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1223 (w32_get_internal_run_time):
1224 Port to higher-resolution Emacs time stamps.
1225 (ltime): Now accepts single 64-bit integer, as that's more convenient
1226 for callers.
1227
1228 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1229
1230 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1231 for compatibility with pselect. Support ns-resolution time stamps.
1232
1233 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1234
1235 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1236 Check for time stamp overflow, and support ns-resolution time stamps.
1237
1238 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1239 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1240 (timeval_subtract): Remove; no longer needed.
1241 (XTflash, XTring_bell, x_wait_for_event):
1242 Port to ns-resolution time stamps. Don't assume time_t is signed.
1243
b6a92dfe
CY
12442012-06-22 Chong Yidong <cyd@gnu.org>
1245
1246 * xdisp.c (x_consider_frame_title): Revert last change.
1247
d251c37c
EZ
12482012-06-22 Eli Zaretskii <eliz@gnu.org>
1249
1250 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1251 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1252 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1253 staticidx goes up to 1597 out of 1600 = 0x640.)
1254
f10deafb
PE
12552012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1256
1257 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1258 Otherwise, the umask might be mistakenly 0 while handling input signals.
1259
ec6de1e2
SM
12602012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1261
1262 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1263
28be1ada
DA
12642012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1265
1266 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1267 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1268 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1269 access to `contents' member of Lisp_Vector objects with AREF and ASET
1270 where appropriate.
1271
c6bf3022
CY
12722012-06-19 Chong Yidong <cyd@gnu.org>
1273
1274 * frame.c (delete_frame): When selecting a frame on a different
1275 text terminal, do not alter the terminal's top-frame.
1276
1277 * xdisp.c (format_mode_line_unwind_data): Record the target
1278 frame's selected window and its terminal's top-frame.
1279 (unwind_format_mode_line): Restore them.
1280 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1281 Callers changed.
1282 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1283 since tty frames can be explicitly named.
1284 (prepare_menu_bars): Likewise.
1285
1286 * term.c (Ftty_top_frame): New function.
1287
defd4196
PE
12882012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1289
1290 Port byte-code-meter to modern targets.
1291 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1292 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1293 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1294 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1295 (METER_1, METER_2): Simplify.
1296
1053a871
SM
12972012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1298
1299 * data.c (Fdefalias): Return `symbol' (bug#11686).
1300
b7e8d081
MR
13012012-06-18 Martin Rudalics <rudalics@gmx.at>
1302
1303 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1304 gets killed during executing of this function (Bug#11665).
1305 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1306 (Vkill_buffer_query_functions): In doc-string say that functions
1307 run by this hook should not change the current buffer.
1308
7ea2b339
PE
13092012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1310
1311 Fix recently-introduced process.c problems found by static checking.
1312 * process.c (write_queue_push, write_queue_pop, send_process):
1313 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1314 (write_queue_pop): Fix pointer signedness problem.
1315 (send_process): Remove unused local.
1316
96a313a1
CY
13172012-06-17 Chong Yidong <cyd@gnu.org>
1318
1319 * xdisp.c (redisplay_internal): No need to redisplay terminal
1320 frames that are not on top.
1321
20ca2e94
TN
13222012-06-17 Troels Nielsen <bn.troels@gmail.com>
1323
1324 * process.c (make_process): Initialize write_queue.
1325 (write_queue_push, write_queue_pop): New functions.
1326 (send_process): Use them to maintain correct ordering of process
1327 writes (Bug#10815).
1328
9a900ca9
PE
13292012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1330
310fbfa8
PE
1331 * lisp.h (eassert): Assume C89 or later.
1332 This removes the need for CHECK.
1333 (CHECK): Remove. Its comments about always evaluating its
1334 argument were confusing, as 'eassert' typically does not evaluate
1335 its argument.
1336
27bb1ca4
PE
1337 * coding.c (produce_chars): Use ptrdiff_t, not int.
1338
9a900ca9
PE
1339 * xterm.c (x_draw_underwave): Check for integer overflow.
1340 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1341
41b7f8bc 13422012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1343
1344 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1345 referenced (Bug#11583).
1346
9b0e3eba
AA
13472012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1348
1349 Implement wave-style variant of underlining.
1350 * dispextern.h (face_underline_type): New enum.
1351 (face): Add field for underline type.
1352 * nsterm.m (ns_draw_underwave): New function.
1353 (ns_draw_text_decoration): Use it.
1354 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1355 New functions.
1356 (x_draw_glyph_string): Use them.
1357 * xfaces.c (Qline, Qwave): New Lisp objects.
1358 (check_lface_attrs, merge_face_ref)
1053a871
SM
1359 (Finternal_set_lisp_face_attribute, realize_x_face):
1360 Handle wave-style underline face attributes.
9b0e3eba
AA
1361 * xterm.c (x_draw_underwave): New function.
1362 (x_draw_glyph_string): Use it.
1363
0fb52f11
JB
13642012-06-16 Juanma Barranquero <lekktu@gmail.com>
1365
1366 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1367 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1368 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1369 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1370 ($(BLD)/w32select.$(O)): Update dependencies.
1371
e5560ff7
AS
13722012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1373
1374 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1375 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1376 * character.c (_fetch_multibyte_char_p): Remove.
1377 * alloc.c: Include "character.h" before "buffer.h".
1378 * bidi.c: Likewise.
1379 * buffer.c: Likewise.
1380 * bytecode.c: Likewise.
1381 * callint.c: Likewise.
1382 * callproc.c: Likewise.
1383 * casefiddle.c: Likewise.
1384 * casetab.c: Likewise.
1385 * category.c: Likewise.
1386 * cmds.c: Likewise.
1387 * coding.c: Likewise.
1388 * composite.c: Likewise.
1389 * dired.c: Likewise.
1390 * dispnew.c: Likewise.
1391 * doc.c: Likewise.
1392 * dosfns.c: Likewise.
1393 * editfns.c: Likewise.
1394 * emacs.c: Likewise.
1395 * fileio.c: Likewise.
1396 * filelock.c: Likewise.
1397 * font.c: Likewise.
1398 * fontset.c: Likewise.
1399 * fringe.c: Likewise.
1400 * indent.c: Likewise.
1401 * insdel.c: Likewise.
1402 * intervals.c: Likewise.
1403 * keyboard.c: Likewise.
1404 * keymap.c: Likewise.
1405 * lread.c: Likewise.
1406 * macros.c: Likewise.
1407 * marker.c: Likewise.
1408 * minibuf.c: Likewise.
1409 * nsfns.m: Likewise.
1410 * nsmenu.m: Likewise.
1411 * print.c: Likewise.
1412 * process.c: Likewise.
1413 * regex.c: Likewise.
1414 * region-cache.c: Likewise.
1415 * search.c: Likewise.
1416 * syntax.c: Likewise.
1417 * term.c: Likewise.
1418 * textprop.c: Likewise.
1419 * undo.c: Likewise.
1420 * unexsol.c: Likewise.
1421 * w16select.c: Likewise.
1422 * w32fns.c: Likewise.
1423 * w32menu.c: Likewise.
1424 * window.c: Likewise.
1425 * xdisp.c: Likewise.
1426 * xfns.c: Likewise.
1427 * xmenu.c: Likewise.
1428 * xml.c: Likewise.
1429 * xselect.c: Likewise.
1430
2f07e6af
EZ
14312012-06-16 Eli Zaretskii <eliz@gnu.org>
1432
1053a871
SM
1433 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1434 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1435 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1436 row.
1437 (handle_face_prop): Use chunk-relative overlay string index when
1438 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1439 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1440 the rightmost. (Bug#11720)
2f07e6af 1441
29b83cec
AS
14422012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1443
1444 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1445 (CATEGORY_MEMBER): Enforce 1/0 value.
1446 * category.c (_temp_category_set): Remove.
1447
4c5501e9
EZ
14482012-06-16 Eli Zaretskii <eliz@gnu.org>
1449
1450 * window.c (Fdelete_other_windows_internal)
1451 (Fdelete_window_internal): Don't access frame's mouse highlight
1452 info of the initial frame. (Bug#11677)
1453
2b570124
PE
14542012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1455
e93864f9
PE
1456 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1457 Assume USE_2_TAGS_FOR_INTS.
1458 (xreload): Adjust $tagmask width to match recent lisp.h change.
1459
2b570124
PE
1460 Simplify lisp.h in minor ways that should not affect code.
1461 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1462 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1463 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1464 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1465 (INTTYPEBITS): New macro, for clarity.
1466 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1467 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1468 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1469 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1470 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1471
81755f69
JB
14722012-06-13 Juanma Barranquero <lekktu@gmail.com>
1473
1474 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1475
16192a57
GM
14762012-06-13 Glenn Morris <rgm@gnu.org>
1477
1478 * s/bsd-common.h (BSD4_3):
1479 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1480
646b5f55
AS
14812012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1482
1483 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1484 instead of union.
1485 (XLI, XIL): Define.
1053a871
SM
1486 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1487 Use them.
1488 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1489 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1490 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1491 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1492 * frame.c (delete_frame): Remove outdated comment.
1493 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1494 USE_LISP_UNION_TYPE.
1495 (Fw32_unregister_hot_key): Likewise.
1496 (Fw32_toggle_lock_key): Likewise.
1497 * w32menu.c (add_menu_item): Likewise.
1498 (w32_menu_display_help): Use XIL instead of checking
1499 USE_LISP_UNION_TYPE.
1500 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1501 (init_heap): Likewise.
1502 * w32term.c (w32_read_socket): Update comment.
1503
1d3823c9
GM
15042012-06-13 Glenn Morris <rgm@gnu.org>
1505
c62ff706
GM
1506 * s/usg5-4-common.h, src/s/unixware.h:
1507 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1508
1d3823c9
GM
1509 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1510
bfe3e0a2
PE
15112012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1512
1513 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1514 * alloc.c (make_number) [!defined make_number]:
1515 Remove, as lisp.h always defines this now.
1516 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1517 (roundup_size): Verify that it is a power of 2.
1518 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1519 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1520 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1521 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1522 USE_LSB_TAG now is always defined to be either 0 or 1.
1523 All uses changed.
1524 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1525 code works fine either way, and efficiency is not a concern here,
1526 as the union type is for debugging, not for production.
1527 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1528 Use an inline function on all platforms when using the union type,
1529 since this is simpler and 'static inline' can be used portably
1530 within Emacs now.
1531 (LISP_INITIALLY_ZERO): New macro.
1532 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1533 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1534
45fa9c0f
GM
15352012-06-12 Glenn Morris <rgm@gnu.org>
1536
b4492cba
GM
1537 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1538
1539 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1540
45fa9c0f
GM
1541 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1542 Move BROKEN_SIGIO to configure.
1543
1544 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1545 Move NO_TERMIO to configure.
1546
0e25d334
CY
15472012-06-12 Chong Yidong <cyd@gnu.org>
1548
1549 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1550 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1551 MagickExportImagePixels is undefined.
1552
43682bb6
PE
15532012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1554
1555 * image.c (imagemagick_load_image): Remove unused label.
1556
a9be7d2b
GM
15572012-06-11 Glenn Morris <rgm@gnu.org>
1558
1559 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1560 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1561 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1562 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1563
3017f87f
SM
15642012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1565
1566 * alloc.c (make_byte_code): New function.
1567 (Fmake_byte_code): Use it. Don't purify here.
1568 * lread.c (read1): Use it as well to avoid extra allocation.
1569
1b9b4cf4
CY
15702012-06-11 Chong Yidong <cyd@gnu.org>
1571
1572 * image.c (imagemagick_load_image): Implement transparency.
1573
95988fcf
AS
15742012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1575
1576 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1577 account for preceding backslashes. (Bug#11663)
1578
cd4eb164
CY
15792012-06-09 Chong Yidong <cyd@gnu.org>
1580
1581 * term.c: Support italics in capable terminals (Bug#9652).
1582 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1583 (turn_on_face): Output using TS_enter_italic_mode if available.
1584 Don't handle unused blinking and alt-charset cases.
1585 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1586 and tty_alt_charset_p cases.
1587 (tty_capable_p, init_tty): Support italics.
1588
1589 * termchar.h (struct tty_display_info): Add field for italics.
1590 Remove unused blink field.
1591
1592 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1593 Handle slant.
1594
1595 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1596 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1597 tty_alt_charset_p. Add tty_italic_p.
1598
ff88beb8
MA
15992012-06-09 Michael Albinus <michael.albinus@gmx.de>
1600
1601 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1602 dbus_type_is_basic if available.
1603 (xd_extract_signed, xd_extract_unsigned): Rename from
1604 extract_signed and extract_unsigned, respectively. Adapt callers.
1605
44286096
CY
16062012-06-09 Chong Yidong <cyd@gnu.org>
1607
1682701f
CY
1608 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1609
44286096
CY
1610 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1611 case (Bug#9752).
1612
d86feb17
PE
16132012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1614
1615 * xdisp.c (vmessage): Treat frame message as multibyte.
1616 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1617 would generate the diagnostic "Making \302\247 buffer-local while
1618 let-bound!".
1619
d5c20fe8
EZ
16202012-06-08 Eli Zaretskii <eliz@gnu.org>
1621
1622 * dispnew.c (showing_window_margins_p): Undo last change, which
1623 was done due to an inadvertent commit.
1624 (adjust_frame_glyphs_for_frame_redisplay): Do call
1625 showing_window_margins_p.
1626
513749ee
SM
16272012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1628
1629 * eval.c (Fmake_var_non_special): New primitive.
1630 (syms_of_eval): Defsubr it.
1631 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1632
d4a8f5c1
JB
16332012-06-08 Juanma Barranquero <lekktu@gmail.com>
1634
1635 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1636 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1637
8bbbc977
EZ
16382012-06-08 Eli Zaretskii <eliz@gnu.org>
1639
1640 * alloc.c (allocate_vectorlike): Fix last change.
1641
f3372c87
DA
16422012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1643
1644 Block-based vector allocation of small vectors.
1645 * lisp.h (struct vectorlike_header): New field `nbytes',
1646 adjust comment accordingly.
1647 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1648 to denote vector blocks. Adjust users (live_vector_p,
1649 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1650 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1651 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1652 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1653 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1654 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1655 (roundup_size): New constant.
1656 (struct vector_block): New data type.
1657 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1658 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1659 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1660 (sweep_vectors): New functions.
1661 (allocate_vectorlike): Return `zero_vector' as the only vector of
1662 0 items. Allocate new vector from block if vector size is less than
1663 or equal to VBLOCK_BYTES_MAX.
1664 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1665 (init_alloc_once): Add call to init_vectors.
1666
4f18a4ed
SM
16672012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1668
1669 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1670
86f158bc
PE
16712012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1672
1673 * doprnt.c (doprnt): Truncate multibyte char correctly.
1674 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1675 would mishandle a string argument "Xc" if X was a multibyte
1676 character of length 2: it would truncate after X's first byte
1677 rather than including all of X.
1678
c5cfcbe0
CY
16792012-06-06 Chong Yidong <cyd@gnu.org>
1680
1681 * buffer.c (word_wrap): Doc fix.
1682
c05cf390
PE
16832012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1684
1685 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1686
0c3461de
GM
16872012-06-03 Glenn Morris <rgm@gnu.org>
1688
1689 * xdisp.c (tool-bar-style): Doc fix.
1690
c71232db
UM
16912012-06-03 Ulrich Müller <ulm@gentoo.org>
1692
1693 * Makefile.in (PAXCTL): Define.
1694 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1695 binary via PaX flags if the paxctl utility is available.
1696 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1697 Restore PaX flags to their default. (Bug#11398)
1698
383f7350
CY
16992012-06-03 Chong Yidong <cyd@gnu.org>
1700
1701 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1702 buffer (Bug#11226).
1703
5f2c76c6
CY
17042012-06-03 Chong Yidong <cyd@gnu.org>
1705
1706 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1707 (note_mode_line_or_margin_highlight): If there is no help echo,
1708 use mode-line-default-help-echo. Handle the case where the mouse
1709 position is past the end of the mode line string.
1710
1711 * buffer.c (buffer_local_value_1): New function, split from
1712 Fbuffer_local_value; can return Qunbound.
1713 (Fbuffer_local_value): Use it.
1714 (Vmode_line_format): Docstring tweaks.
1715
773d47f6
PE
17162012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1717
1718 * sysdep.c (system_process_attributes): Improve comment.
1719
f2d6a3df
SM
17202012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1721
1722 * keyboard.c: Export real-this-command to Elisp.
1723 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1724 and DEFVAR it. Update all users.
1725
63810350
PE
17262012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1727
7bd5c1f4
PE
1728 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1729
63810350
PE
1730 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1731 Convert pctcpu and pctmem to Lisp float properly.
1732 Let the compiler fold better, as 100.0/0x8000 is exact.
1733
a2821611
AS
17342012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1735
1736 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1737 cons_block.
1738
5fceba1d
PE
17392012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1740
1741 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1742
c98ff5dd
DA
17432012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1744
1745 For a 'struct window', replace some Lisp_Object fields to
1746 bitfields where appropriate, remove unused fields.
1747 * window.h (struct window): Remove unused 'last_mark_x' and
1748 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1749 change it's type from Lisp_Object to bitfield.
1750 Change type of 'force_start', 'optional_new_start',
1751 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1752 fields from Lisp_Object to bitfield. Adjust users accordingly.
1753
ca34e0be
PE
17542012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1755
1756 Pacify gcc -Wdouble-precision when using Xaw.
1757 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1758 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1759 Use 'float' consistently, rather than 'float' in most places
1760 and 'double' in a couple of places.
1761
efc00ab1 17622012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1763
1764 * xdisp.c (handle_stop): Detect whether we have overlay strings
1765 loaded by testing it->current.overlay_string_index to be
1766 non-negative, instead of checking whether n_overlay_strings is
1767 positive. (Bug#11587)
1768
efc00ab1 17692012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1770
1771 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1772
1773 * doc.c (Fsubstitute_command_keys): Doc fix.
1774
efc00ab1 17752012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1776
1777 * search.c (search_buffer): Remove calls to
1778 r_alloc_inhibit_buffer_relocation, as it is now called by
1779 maybe_unify_char, which was the cause of relocation of buffer text
1780 in bug#11519.
1781
efc00ab1 17822012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1783
1784 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1785 for the duration of call to load_charset, to avoid problems with
1786 callers of maybe_unify_char that access buffer text through C
1787 pointers.
1788
1789 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1790 decrement the inhibition flag, instead of just setting or
1791 resetting it.
1792
ba93a187
PE
17932012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1794
1795 Remove obsolete '#define static' cruft.
1796 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1797 This #undef was "temporary" in 2000; it is no longer needed
1798 now that '#define static' has gone away.
1799 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1800 (gray_bitmap_bits): Remove; no longer needed.
1801 All uses replaced with definiens.
1802 * xterm.c: Include "bitmaps/gray.xbm".
1803
9e4bf381
PE
18042012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1805
1806 Clean up __executable_start, monstartup when --enable-profiling.
1807 The following changes affect the code only when profiling.
1808 * dispnew.c (__executable_start): Rename from safe_bcopy.
1809 Define only on platforms that need it.
1810 * emacs.c: Include <sys/gmon.h> when profiling.
1811 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1812 (__executable_start): Remove decl, since lisp.h does it now.
1813 (safe_bcopy): Remove decl; no longer has that name.
1814 (main): Coalesce #if into single bit of code, for simplicity.
1815 Cast pointers to uintptr_t, since standard libraries want integers
1816 and not pointers.
1817 * lisp.h (__executable_start): New decl.
1818
32d72c2f
GM
18192012-05-31 Glenn Morris <rgm@gnu.org>
1820
1821 * image.c (Fimagemagick_types): Doc fix.
1822
baac5bc7
JM
18232012-05-30 Jim Meyering <meyering@redhat.com>
1824
1825 * callproc.c (Fcall_process_region): Include directory component
1826 in mkstemp error message (Bug#11586).
1827
72cb32cf
PE
18282012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1829
1830 * alloc.c, lisp.h (make_pure_vector): Now static.
1831
61b108cc
SM
18322012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1833
1834 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1835 Move to byte-run.el.
1836 (Fautoload): Do the hash-doc more carefully.
1837 * data.c (Fdefalias): Purify definition, except for keymaps.
1838 (Qdefun): Move from eval.c.
1839 * lisp.h (Qdefun): Remove.
1840 * lread.c (read1): Tiny simplification.
1841
471fe23d
TN
18422012-05-29 Troels Nielsen <bn.troels@gmail.com>
1843
934f3f58 1844 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1845 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1846 Bug#9642, but explicitly check that the buffer the overlay would
1847 be moved to is live and rearrange lines to make sure that errors
1848 will not put the overlay in an inconsistent state.
1849 (Fdelete_overlay): Cosmetics.
1850
85d0efd1
EZ
18512012-05-28 Eli Zaretskii <eliz@gnu.org>
1852
1853 * w32term.c (my_bring_window_to_top): New function.
1854 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1855 could be different from the original one.
1856 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1857 (Bug#11513)
1858
1859 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1860 by calling BringWindowToTop.
1861
1862 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1863 (WM_EMACS_END): Increase by one.
1864
da92a98c
PE
18652012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1866
1867 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1868 This avoids undefined behavior that might cause the eassert
1869 to not catch an out-of-range value.
1870
74d1f848
JB
18712012-05-28 Juanma Barranquero <lekktu@gmail.com>
1872
1873 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1874 Update dependencies.
1875
9e1a06fc
EZ
18762012-05-27 Eli Zaretskii <eliz@gnu.org>
1877
1878 * bidi.c (bidi_mirror_char): Fix last change.
1879
f3dd7312
AS
18802012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1881
1882 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1883 when referring to sectname field in printf format.
1884
81899c91
PE
18852012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1886
57b81a9f
PE
1887 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1888 Only r_alloc_inhibit_buffer_relocation needed to be added;
1889 the others were already declared.
1890
81899c91
PE
1891 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1892 before checking whether it's out of range. Put the check inside
1893 eassert. See
1894 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1895
33017faf 18962012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1897
1898 * callproc.c (Fcall_process): Restore a line that was accidentally
1899 commented out in the 2011-02-13 change (bug#11547).
1900
33017faf 19012012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1902
1903 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1904 defined on ralloc.c.
1905
1906 * buffer.c [REL_ALLOC]: Remove prototypes of
1907 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1908 they are now on lisp.h.
1909
1910 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1911
1912 * search.c (search_buffer): Use it to inhibit relocation of buffer
1913 text while re_search_2 is doing its job, because re_search_2 is
1914 passed C pointers to buffer text. (Bug#11519)
1915
23415acf
EZ
1916 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1917 Update value to 24.
1918
44e27368
EZ
1919 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1920 state after an additional call to move_it_in_display_line_to, keep
1921 the values of it->max_ascent and it->max_descent found for the
1922 entire line.
1923 (pos_visible_p): Revert the comparison against bottom_y to what it
1924 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1925 (Bug#11464)
1926
c1892f11
PE
19272012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1928
1929 Fix coding-related core dumps with gcc -ftrapv.
1930 The code was computing A - B, where A and B are pointers, and B is
1931 random garbage. This can lead to core dumps on platforms that
1932 have special pointer registers, and it also leads to core dumps on
1933 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1934 A - B only when B is initialized properly.
1935 * coding.c (coding_set_source, coding_set_destination): Return void.
1936 (coding_change_source, coding_change_destinations): New functions,
1937 with the old behaviors of coding_set_source and coding_set_destination.
1938 All callers that need an offset changed to use these new functions.
1939
eb7afdad
GM
19402012-05-26 Glenn Morris <rgm@gnu.org>
1941
1942 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1943
f12fdf02
EZ
19442012-05-26 Eli Zaretskii <eliz@gnu.org>
1945
53a63be6 1946 Extend mouse support on W32 text-mode console.
61b108cc
SM
1947 * xdisp.c (draw_row_with_mouse_face):
1948 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1949
eb3f6f01 1950 * w32console.c: Include window.h.
61b108cc
SM
1951 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1952 New functions.
eb3f6f01
EZ
1953 (initialize_w32_display): Initialize mouse-highlight data.
1954
53a63be6
EZ
1955 * w32inevt.c: Include termchar.h and window.h.
1956 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1957 moves, call note_mouse_highlight. If help_echo changed, call
1958 gen_help_event to produce help-echo message in the echo area.
1959 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1960 highlight info.
1961
4cfd81f6
PE
19622012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1963
1964 * lread.c (read1): Simplify slightly to avoid an overflow warning
1965 with GCC 4.7.0 on x86-64.
1966
4446092a
EZ
19672012-05-26 Eli Zaretskii <eliz@gnu.org>
1968
1969 * bidi.c (bidi_mirror_char): Revert last change: an int is
1970 definitely wide enough here.
1971
42b2a986 19722012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1973
42b2a986 1974 Fix integer width and related bugs (Bug#9874).
eb106a49 1975 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1976 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1977 (string_bytes, check_sblock, allocate_string_data):
1978 (compact_small_strings, Fmake_bool_vector, make_string)
1979 (make_unibyte_string, make_multibyte_string)
1980 (make_string_from_bytes, make_specified_string)
1981 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1982 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1983 (mark_vectorlike):
1984 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1985 (allocate_pseudovector):
1986 Use int, not EMACS_INT, where int is wide enough.
1987 (inhibit_garbage_collection, Fgarbage_collect):
1988 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1989 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1990 int might not be wide enough.
1991 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1992 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1993 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1994 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1995 (bidi_level_of_next_char, bidi_move_to_visually_next):
1996 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1997 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1998 (Fkill_buffer, Fset_buffer_major_mode)
1999 (advance_to_char_boundary, Fbuffer_swap_text)
2000 (Fset_buffer_multibyte, overlays_at, overlays_in)
2001 (overlay_touches_p, struct sortvec, record_overlay_string)
2002 (overlay_strings, recenter_overlay_lists)
2003 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2004 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2005 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2006 (Foverlay_recenter, last_overlay_modification_hooks_used)
2007 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2008 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2009 (validate_region): Omit unnecessary test for b <= e,
2010 since that's guaranteed by the previous test.
d311d28c
PE
2011 (adjust_overlays_for_delete): Avoid pos + length overflow.
2012 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2013 (report_overlay_modification):
2014 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2015 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2016 Omit pointer cast, which isn't needed anyway, and doesn't work
2017 after the EMACS_INT -> ptrdiff_t change.
02481186 2018 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2019 * buffer.h: Adjust decls to match defn changes elsewhere.
2020 (struct buffer_text, struct buffer):
2021 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2022 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2023 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2024 not int, to avoid needless 32-bit limit on 64-bit hosts.
2025 (exec_byte_code): Use tighter memory-full test, one that checks
2026 for alloca overflow. Don't compute the address of the object just
2027 before an array, as that's not portable. Use EMACS_INT, not
2028 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2029 * callint.c (Fcall_interactively):
2030 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2031 * callproc.c (call_process_kill, Fcall_process):
2032 Don't assume pid_t fits into an Emacs fixnum.
2033 (call_process_cleanup, Fcall_process, child_setup):
2034 Don't assume pid_t fits into int.
2035 (call_process_cleanup, Fcall_process, delete_temp_file)
2036 (Fcall_process_region):
2037 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2038 (Fcall_process): Simplify handling of volatile integers.
2039 Use int, not EMACS_INT, where int will do.
2040 * casefiddle.c (casify_object, casify_region, operate_on_word)
2041 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2042 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2043 (casify_object): Avoid integer overflow when overallocating buffer.
2044 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2045 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2046 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2047 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2048 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2049 integers are now checked earlier. All uses replaced with XINT.
2050 (ccl_driver):
2051 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2052 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2053 (ccl_driver, Fregister_code_conversion_map):
2054 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2055 (resolve_symbol_ccl_program): Check that vector header is in range.
2056 Always copy the vector, so that we can check its contents reliably
2057 now rather than having to recheck each instruction as it's being
2058 executed. Check that vector words fit in 'int'.
2059 (ccl_get_compiled_code, Fregister_ccl_program)
2060 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2061 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2062 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2063 contents are in range.
2064 (Fccl_execute_on_string): Check that status is in range.
2065 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2066 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2067 Accept and return EMACS_INT, not int, because callers can pass values
2068 out of 'int' range.
2069 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2070 (multibyte_chars_in_text, parse_str_as_multibyte)
2071 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2072 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2073 (string_escape_byte8, Fget_byte):
2074 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2075 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2076 avoid mishandling large integers.
2077 * character.h: Adjust decls to match defn changes elsewhere.
2078 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2079 (Ffind_charset_region):
2080 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2081 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2082 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2083 Don't assume fixnum fits in int.
d311d28c
PE
2084 (load_charset_map_from_vector, Fmap_charset_chars):
2085 Remove now-unnecessary CHECK_NATNUMs.
2086 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2087 Don't rely on undefined behavior with signed left shift overflow.
2088 Don't assume unsigned int fits into fixnum, or that fixnum fits
2089 into unsigned int. Don't require max_code to be a valid fixnum;
2090 that's not true for gb10830 4-byte on a 32-bit host. Allow
2091 invalid_code to be a cons, for the same reason. Require code_offset
2092 to be a character. Avoid int overflow if max_char is close
2093 to INT_MAX.
2094 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2095 this is intended anyway and avoids some undefined behavior.
2096 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2097 INDEX_TO_CODE_POINT, as that's what it expects.
2098 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2099 * charset.h (DECODE_CHAR): Return int, not unsigned;
2100 this is what was intended anyway, and it avoids undefined behavior.
2101 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2102 integer-overflow issues.
2103 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2104 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2105 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2106 * chartab.c (Fmake_char_table, Fset_char_table_range)
2107 (uniprop_get_decoder, uniprop_get_encoder):
2108 Don't assume fixnum fits in int.
2109 * cmds.c (move_point): New function, that does the gist of
2110 Fforward_char and Fbackward_char, but does so while checking
2111 for integer overflow more accurately.
c96e5d6a 2112 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2113 (Fforward_line, Fend_of_line, internal_self_insert)
2114 (internal_self_insert):
2115 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2116 Fix a FIXME, by checking for integer overflow when calculating
2117 target_clm and actual_clm.
2118 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2119 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2120 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2121 (coding_alloc_by_making_gap, alloc_destination)
2122 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2123 (encode_coding_utf_16, detect_coding_emacs_mule)
2124 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2125 (detect_coding_iso_2022, decode_coding_iso_2022)
2126 (encode_invocation_designation, encode_designation_at_bol)
2127 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2128 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2129 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2130 (encode_coding_ccl, encode_coding_raw_text)
2131 (detect_coding_charset, decode_coding_charset)
2132 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2133 (produce_composition, produce_charset, produce_annotation)
2134 (decode_coding, handle_composition_annotation)
2135 (handle_charset_annotation, consume_chars, decode_coding_gap)
2136 (decode_coding_object, encode_coding_object, detect_coding_system)
2137 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2138 (code_convert_region, code_convert_string)
8f50130c
PE
2139 (Fdefine_coding_system_internal)
2140 (coding_set_source, coding_set_destination):
d311d28c
PE
2141 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2142 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2143 (Fdefine_coding_system_internal):
2144 Don't assume fixnums fit in int.
2145 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2146 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2147 (Funencodable_char_position, Fcheck_coding_systems_region)
2148 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2149 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2150 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2151 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2152 Don't access memory outside of the args array.
d311d28c 2153 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2154 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2155 result of ENCODE_CHAR.
d311d28c
PE
2156 * coding.h: Adjust decls to match defn changes elsewhere.
2157 (struct coding_system):
2158 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2159 * composite.c (get_composition_id, find_composition)
2160 (run_composition_function, update_compositions)
2161 (compose_text, composition_gstring_put_cache)
2162 (composition_gstring_p, composition_gstring_width)
2163 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2164 (composition_compute_stop_pos, composition_reseat_it)
2165 (composition_update_it, struct position_record)
2166 (find_automatic_composition, composition_adjust_point)
2167 (Fcomposition_get_gstring, Ffind_composition_internal):
2168 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2169 (update_compositions):
2170 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2171 * composite.h: Adjust decls to match defn changes elsewhere.
2172 (struct composition):
2173 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2174 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2175 Do not attempt to compute the address of the object just before a
2176 buffer; this is not portable.
2177 (Faref, Faset):
2178 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2179 (Faset): Use int, not EMACS_INT, where int is wide enough.
2180 (Fstring_to_number): Don't assume fixnums fit in int.
2181 (Frem): Don't assume arg is nonnegative.
2182 * dbusbind.c (xd_append_arg): Check for integers out of range.
2183 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2184 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2185 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2186 (xd_get_connection_references): Return ptrdiff_t, not int.
2187 All uses changed.
2188 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2189 (xd_read_message_1):
2190 Use int, not unsigned, where the dbus API uses int.
2191 (Fdbus_message_internal): Don't overflow mtype.
2192 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2193 * dired.c (directory_files_internal, file_name_completion, scmp)
2194 (file_name_completion_stat):
2195 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2196 (file_name_completion): Don't overflow matchcount.
2197 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2198 * dispextern.h: Adjust decls to match defn changes elsewhere.
2199 (struct text_pos, struct glyph, struct bidi_saved_info)
2200 (struct bidi_string_data, struct bidi_it, struct composition_it)
2201 (struct it):
2202 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2203 (struct display_pos, struct composition_it, struct it):
2204 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2205 * dispnew.c (increment_matrix_positions)
2206 (increment_row_positions, mode_line_string)
2207 (marginal_area_string):
2208 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2209 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2210 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2211 (duration_to_sec_usec): New function, to check for overflow better.
2212 (Fsleep_for, sit_for): Use it.
2213 * doc.c (get_doc_string, store_function_docstring):
2214 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2215 (get_doc_string, Fsnarf_documentation):
2216 Use int, not EMACS_INT, where int is wide enough.
2217 (get_doc_string):
2218 Use SAFE_ALLOCA, not alloca.
2219 Check for overflow when converting EMACS_INT to off_t.
2220 * doprnt.c (doprnt):
2221 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2222 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2223 Don't assume uid_t fits into fixnum.
2224 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2225 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2226 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2227 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2228 (general_insert_function)
2229 (Finsert_char, make_buffer_string, make_buffer_string_both)
2230 (update_buffer_properties, Fbuffer_substring)
2231 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2232 (Fsubst_char_in_region, check_translation)
2233 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2234 (transpose_markers, Ftranspose_regions):
2235 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2236 (clip_to_bounds): Move to lisp.h as an inline function).
2237 (Fconstrain_to_field): Don't assume integers are nonnegative.
2238 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2239 (Fsubst_char_in_region, Fsave_restriction):
2240 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2241 (Femacs_pid): Don't assume pid_t fits into fixnum.
2242 (lo_time): Use int, not EMACS_INT, when int suffices.
2243 (lisp_time_argument): Check for usec out of range.
2244 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2245 (Fuser_login_name, Fuser_full_name): Signal an error
2246 if a uid argument is out of range, rather than relying on
2247 undefined behavior.
c8d5c857
PE
2248 (Fformat_time_string): Remove now-unnecessary check.
2249 lisp_time_argument checks for out-of-range usec now.
243e0530 2250 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2251 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2252 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2253 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2254 (init_cmdargs, Fdump_emacs):
2255 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2256 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2257 the bottom (typically) 32 bits of the fixnum.
2258 * eval.c (specpdl_size, call_debugger):
2259 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2260 (when_entered_debugger, Fbacktrace_debug):
2261 Don't assume fixnum can fit in int.
2262 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2263 the object just before a buffer; this is not portable.
2264 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2265 (grow_specpdl, unbind_to):
2266 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2267 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2268 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2269 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2270 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2271 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2272 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2273 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2274 (a_write, e_write):
2275 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2276 (Fcopy_file, non_regular_nbytes, read_non_regular)
2277 (Finsert_file_contents):
2278 Use int, not EMACS_INT, where int is wide enough.
2279 (READ_BUF_SIZE): Verify that it fits in int.
2280 (Finsert_file_contents): Check that counts are in proper range,
2281 rather than assuming fixnums fit into ptrdiff_t etc.
2282 Don't assume fixnums fit into int.
125b3835 2283 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2284 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2285 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2286 (string_char_to_byte, string_byte_to_char)
2287 (string_make_multibyte, string_to_multibyte)
2288 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2289 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2290 (substring_both, Fdelete, internal_equal, Ffillarray)
2291 (Fclear_string, mapcar1)
2292 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2293 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2294 (larger_vector, make_hash_table, maybe_resize_hash_table)
2295 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2296 (Fmaphash, secure_hash):
2297 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2298 (concat): Check for string index and length overflow.
2299 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2300 (Frequire):
2301 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2302 (larger_vector): New API (vec, incr_min, size_max) replaces old
2303 one (vec, new_size, init). This catches size overflow.
2304 INIT was removed because it was always Qnil.
2305 All callers changed.
2306 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2307 the upper bound on a hash table index size.
2308 (make_hash_table, maybe_resize_hash_table): Use it.
2309 (secure_hash): Computer start_byte and end_byte only after
2310 they're known to be in ptrdiff_t range.
2311 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2312 (Ffont_get_glyphs, Ffont_at):
2313 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2314 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2315 (Flist_fonts, Fopen_font):
2316 Don't assume fixnum can fit in int.
2317 (check_gstring): Don't assume index can fit in int.
2318 (font_match_p): Check that fixnum is a character, not a nonnegative
2319 fixnum, since the later code needs to stuff it into an int.
2320 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2321 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2322 conversion overflow issues.
2323 (Fopen_font): Check for integer out of range.
2324 (Ffont_get_glyphs): Don't assume index can fit in int.
2325 * font.h: Adjust decls to match defn changes elsewhere.
2326 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2327 integer overflow.
2328 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2329 printmax_t, where ptrdiff_t is wide enough.
2330 (Finternal_char_font):
2331 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2332 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2333 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2334 (Fset_frame_position, x_set_frame_parameters)
2335 (x_set_line_spacing, x_set_border_width)
2336 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2337 Check that fixnums are in proper range for system types.
2338 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2339 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2340 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2341 Use SAFE_ALLOCA_LISP, not alloca.
2342 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2343 intptr_t is wide enough.
2344 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2345 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2346 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2347 Check for fixnum out of range.
2348 * ftfont.c (ftfont_list): Don't assume index fits in int.
2349 Check that fixnums are in proper range for system types.
2350 (ftfont_shape_by_flt):
2351 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2352 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2353 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2354 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2355 Check that fixnums are in proper range for system types.
2356 * gnutls.h: Adjust decls to match defn changes elsewhere.
2357 * gtkutil.c (xg_dialog_run):
2358 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2359 (update_frame_tool_bar):
2360 Check that fixnums are in proper range for system types.
2361 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2362 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2363 * indent.c (last_known_column, last_known_column_point):
2364 (current_column_bol_cache):
2365 (skip_invisible, current_column, check_display_width):
2366 (check_display_width, scan_for_column, current_column_1)
2367 (Findent_to, Fcurrent_indentation, position_indentation)
2368 (indented_beyond_p, Fmove_to_column, compute_motion):
2369 (Fcompute_motion, Fvertical_motion):
2370 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2371 (last_known_column_modified): Use EMACS_INT, not int.
2372 (check_display_width):
2373 (Fcompute_motion):
2374 Check that fixnums and floats are in proper range for system types.
2375 (compute_motion): Don't assume index or fixnum fits in int.
2376 (compute_motion, Fcompute_motion):
2377 Use int, not EMACS_INT, when it is wide enough.
2378 (vmotion): Omit local var start_hpos that is always 0; that way
2379 we don't need to worry about overflow in expressions involving it.
2380 * indent.h: Adjust decls to match defn changes elsewhere.
2381 (struct position):
2382 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2383 Use int, not EMACS_INT, where int is wide enough.
2384 Remove unused members ovstring_chars_done and tab_offset;
2385 all uses removed.
2386 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2387 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2388 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2389 (make_gap, copy_text, insert, insert_and_inherit)
2390 (insert_before_markers, insert_before_markers_and_inherit)
2391 (insert_1, count_combining_before, count_combining_after)
2392 (insert_1_both, insert_from_string)
2393 (insert_from_string_before_markers, insert_from_string_1)
2394 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2395 (adjust_after_replace, adjust_after_insert, replace_range)
2396 (replace_range_2, del_range, del_range_1, del_range_byte)
2397 (del_range_both, del_range_2, modify_region)
2398 (prepare_to_modify_buffer, signal_before_change)
2399 (signal_after_change, Fcombine_after_change_execute):
2400 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2401 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2402 (balance_an_interval, split_interval_right, split_interval_left)
2403 (find_interval, next_interval, update_interval)
2404 (adjust_intervals_for_insertion, delete_node, delete_interval)
2405 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2406 (static_offset_intervals, offset_intervals)
2407 (merge_interval_right, merge_interval_left, make_new_interval)
2408 (graft_intervals_into_buffer, temp_set_point_both)
2409 (temp_set_point, set_point, adjust_for_invis_intang)
2410 (set_point_both, move_if_not_intangible, get_property_and_range)
2411 (get_local_map, copy_intervals, copy_intervals_to_string)
2412 (compare_string_intervals, set_intervals_multibyte_1):
2413 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2414 * intervals.h: Adjust decls to match defn changes elsewhere.
2415 (struct interval):
2416 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2417 * keyboard.c (this_command_key_count, this_single_command_key_start)
2418 (before_command_key_count, before_command_echo_length, echo_now)
2419 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2420 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2421 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2422 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2423 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2424 (last_non_minibuf_size, last_point_position, echo_truncate)
2425 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2426 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2427 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2428 (stuff_buffered_input):
2429 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2430 (last_auto_save, command_loop_1, read_char):
2431 Use EMACS_INT, not int, to avoid integer overflow.
2432 (record_char): Avoid overflow in total_keys computation.
2433 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2434 * keyboard.h: Adjust decls to match defn changes elsewhere.
2435 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2436 (Fkey_description, Fdescribe_vector, Flookup_key):
2437 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2438 (click_position): New function, to check that positions are in range.
2439 (Fcurrent_active_maps):
2440 (describe_command):
2441 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2442 (Faccessible_keymaps, Fkey_description):
2443 (preferred_sequence_p):
2444 Don't assume fixnum can fit into int.
2445 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2446 Check for integer overflow in size calculations.
2447 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2448 avoid mishandling large integers.
2449 * lisp.h: Adjust decls to match defn changes elsewhere.
2450 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2451 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2452 (struct Lisp_Marker):
2453 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2454 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2455 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2456 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2457 All callers changed.
2458 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2459 Assume the arg has valid form, since it always does.
2460 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2461 unsigned integer system type.
2462 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2463 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2464 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2465 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2466 (duration_to_sec_usec): New decl.
2467 * lread.c (read_from_string_index, read_from_string_index_byte)
2468 (read_from_string_limit, readchar, unreadchar, openp)
2469 (read_internal_start, read1, oblookup):
2470 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2471 (Fload, readevalloop, Feval_buffer, Feval_region):
2472 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2473 (openp): Check for out-of-range argument to 'access'.
2474 (read1): Use int, not EMACS_INT, where int is wide enough.
2475 Don't assume fixnum fits into int.
6efdadfd 2476 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2477 (read_filtered_event): Use duration_to_sec_usec
2478 to do proper overflow checking on durations.
d311d28c
PE
2479 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2480 in size calculation.
2481 (Fexecute_kbd_macro):
2482 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2483 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2484 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2485 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2486 (set_marker_both, set_marker_restricted_both, marker_position)
2487 (marker_byte_position, Fbuffer_has_markers_at):
2488 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2489 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2490 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2491 It now merely ensures that the menu is large enough, without
2492 necessarily growing it, as this avoids some integer overflow issues.
2493 All callers changed.
2494 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2495 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2496 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2497 Use SAFE_ALLOCA_LISP, not alloca.
2498 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2499 to EMACS_INT. Check that fixnums are in proper range for system types.
2500 * minibuf.c (minibuf_prompt_width, string_to_object)
2501 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2502 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2503 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2504 (get_minibuffer, read_minibuf_unwind):
2505 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2506 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2507 this simplifies overflow checking. All callers changed.
2508 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2509 (Ftest_completion):
2510 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2511 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2512 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2513 Check that fixnums are in proper range for system types.
2514 (Fx_create_frame, Fx_show_tip):
2515 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2516 * nsfont.m (ns_findfonts, nsfont_list_family):
2517 Don't assume fixnum fits in long.
2518 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2519 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2520 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2521 wide enough.
17fdb222 2522 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2523 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2524 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2525 (PRINTDECLARE, PRINTPREPARE):
2526 (strout, print_string):
2527 (print, print_preprocess, print_check_string_charset_prop)
2528 (print_object):
2529 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2530 (PRINTDECLARE):
2531 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2532 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2533 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2534 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2535 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2536 (print_error_message): Use SAFE_ALLOCA, not alloca.
2537 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2538 (print_depth, new_backquote_output, print_number_index):
2539 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2540 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2541 (Fset_process_window_size, Fformat_network_address)
2542 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2543 (sigchld_handler):
d311d28c 2544 Check that fixnums are in proper range for system types.
d44287d4 2545 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2546 Check for process-ids out of pid_t range rather than relying on
2547 undefined behavior.
e4d81efc 2548 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2549 (Fformat_network_address, read_process_output, send_process)
2550 (Fprocess_send_region, status_notify):
2551 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2552 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2553 (wait_reading_process_output, read_process_output, exec_sentinel):
2554 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2555 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2556 (Faccept_process_output): Use duration_to_sec_usec to do proper
2557 overflow checking on durations.
dde14581
PE
2558 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2559 Don't assume pid_t fits in int.
02481186
PE
2560 * process.h (struct Lisp_Process): Members tick and update_tick
2561 are now of type EMACS_INT, not int.
b62b53e8
PE
2562 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2563 configured --with-wide-int.
d311d28c
PE
2564 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2565 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2566 * search.c (looking_at_1, string_match_1):
2567 (fast_string_match, fast_c_string_match_ignore_case)
2568 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2569 (scan_newline, find_before_next_newline, search_command)
2570 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2571 (set_search_regs, wordify):
2572 (Freplace_match):
2573 (Fmatch_data):
2574 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2575 (string_match_1, search_buffer, set_search_regs):
2576 (Fmatch_data):
2577 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2578 (wordify): Check for overflow in size calculation.
2579 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2580 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2581 Check that fixnums are in proper range for system types.
2582 * sound.c (struct sound_device)
2583 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2584 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2585 (Fplay_sound_internal):
2586 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2587 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2588 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2589 (Fparse_partial_sexp):
2590 Don't assume fixnums can fit in int.
2591 (struct lisp_parse_state, find_start_pos, find_start_value)
2592 (find_start_value_byte, find_start_begv)
2593 (update_syntax_table, char_quoted, dec_bytepos)
2594 (find_defun_start, prev_char_comend_first, back_comment):
2595 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2596 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2597 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2598 (Finternal_describe_syntax_value): Check that match_lisp is a
2599 character, not an integer, since the code stuffs it into int.
2600 (scan_words, scan_sexps_forward):
2601 Check that fixnums are in proper range for system types.
2602 (Fforward_word):
2603 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2604 (scan_sexps_forward):
2605 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2606 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2607 * syntax.h: Adjust decls to match defn changes elsewhere.
2608 (struct gl_state_s):
2609 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2610 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2611 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2612 * sysdep.c (wait_for_termination_1, wait_for_termination)
2613 (interruptible_wait_for_termination, mkdir):
2614 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2615 (emacs_read, emacs_write):
2616 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2617 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2618 and double all fit in int.
d311d28c
PE
2619 * term.c (set_tty_color_mode):
2620 Check that fixnums are in proper range for system types.
2621 * termhooks.h (struct input_event):
2622 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2623 * textprop.c (validate_interval_range, interval_of)
2624 (Fadd_text_properties, set_text_properties_1)
2625 (Fremove_text_properties, Fremove_list_of_text_properties)
2626 (Ftext_property_any, Ftext_property_not_all)
2627 (copy_text_properties, text_property_list, extend_property_ranges)
2628 (verify_interval_modification):
2629 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2630 (Fnext_single_char_property_change)
2631 (Fprevious_single_char_property_change):
2632 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2633 (copy_text_properties):
2634 Check for integer overflow in index calculation.
d311d28c
PE
2635 * undo.c (last_boundary_position, record_point, record_insert)
2636 (record_delete, record_marker_adjustment, record_change)
2637 (record_property_change):
2638 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2639 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2640 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2641 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2642 (Fx_hide_tip, Fx_file_dialog):
2643 * w32menu.c (set_frame_menubar):
2644 Use ptrdiff_t, not int, for consistency with rest of code.
2645 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2646 (select_window, Fdelete_other_windows_internal)
2647 (window_scroll_pixel_based, window_scroll_line_based)
2648 (Frecenter, Fset_window_configuration):
2649 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2650 (Fset_window_hscroll, run_window_configuration_change_hook)
2651 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2652 (Fscroll_other_window, Frecenter):
d311d28c
PE
2653 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2654 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2655 Don't assume fixnum fits in int.
2656 (Fset_window_scroll_bars):
2657 Check that fixnums are in proper range for system types.
2658 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2659 (string_pos, c_string_pos, number_of_chars, init_iterator)
2660 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2661 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2662 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2663 (face_before_or_after_it_pos, handle_invisible_prop)
2664 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2665 (display_prop_intangible_p, string_buffer_position_lim)
2666 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2667 (get_overlay_strings_1, get_overlay_strings)
2668 (iterate_out_of_display_property, forward_to_next_line_start)
2669 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2670 (get_next_display_element, set_iterator_to_next)
2671 (get_visually_first_element, compute_stop_pos_backwards)
2672 (handle_stop_backwards, next_element_from_buffer)
2673 (move_it_in_display_line_to, move_it_in_display_line)
2674 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2675 (add_to_log, message_dolog, message_log_check_duplicate)
2676 (message2, message2_nolog, message3, message3_nolog
2677 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2678 (current_message_1, truncate_echo_area, truncate_message_1)
2679 (set_message, set_message_1, store_mode_line_noprop)
2680 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2681 (text_outside_line_unchanged_p, check_point_in_composition)
2682 (reconsider_clip_changes)
2683 (redisplay_internal, set_cursor_from_row, try_scrolling)
2684 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2685 (redisplay_window, find_last_unchanged_at_beg_row)
2686 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2687 (trailing_whitespace_p, find_row_edges, display_line)
2688 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2689 (display_mode_element, store_mode_line_string)
2690 (pint2str, pint2hrstr, decode_mode_spec)
2691 (display_count_lines, display_string, draw_glyphs)
2692 (x_produce_glyphs, x_insert_glyphs)
2693 (rows_from_pos_range, mouse_face_from_buffer_pos)
2694 (fast_find_string_pos, mouse_face_from_string_pos)
2695 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2696 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2697 (safe_call, init_from_display_pos, handle_fontified_prop)
2698 (handle_single_display_spec, load_overlay_strings)
2699 (with_echo_area_buffer, setup_echo_area_for_printing)
2700 (display_echo_area, echo_area_display)
2701 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2702 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2703 (redisplay_window, dump_glyph_row, display_mode_line)
2704 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2705 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2706 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2707 (handle_single_display_spec, build_desired_tool_bar_string)
2708 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2709 (get_specified_cursor_type):
2710 Check that fixnums are in proper range for system types.
2711 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2712 (Flookup_image_map):
2713 Don't assume fixnums fit in int.
2714 (compare_overlay_entries):
2715 Avoid mishandling comparisons due to subtraction overflow.
2716 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2717 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2718 (handle_tool_bar_click):
2719 Use int, not unsigned, since we prefer signed and the signedness
2720 doesn't matter here.
2721 (get_next_display_element, next_element_from_display_vector):
2722 Use int, not EMACS_INT, when int is wide enough.
2723 (start_hourglass): Use duration_to_sec_usec to do proper
2724 overflow checking on durations.
2725 * xfaces.c (Fbitmap_spec_p):
2726 Check that fixnums are in proper range for system types.
2727 (compare_fonts_by_sort_order):
2728 Avoid mishandling comparisons due to subtraction overflow.
2729 (Fx_family_fonts, realize_basic_faces):
2730 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2731 (Fx_family_fonts):
2732 Don't assume fixnum fits in int.
2733 Use SAFE_ALLOCA_LISP, not alloca.
2734 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2735 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2736 (face_at_buffer_position, face_for_overlay_string)
2737 (face_at_string_position):
2738 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2739 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2740 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2741 (Fx_show_tip):
2742 Check that fixnums are in proper range for system types.
2743 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2744 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2745 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2746 (Fx_change_window_property): Don't assume fixnums fit in int.
2747 * xfont.c (xfont_chars_supported):
2748 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2749 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2750 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2751 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2752 * xml.c (parse_region):
2753 * xrdb.c (magic_file_p):
2754 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2755 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2756 (x_get_local_selection, x_reply_selection_request)
2757 (x_handle_selection_request, wait_for_property_change):
2758 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2759 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2760 short is wide enough.
2761 (x_send_client_event): Don't assume fixnum fits in int.
2762 * xterm.c (x_x_to_emacs_modifiers):
2763 Don't assume EMACS_INT overflows nicely into int.
2764 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2765 may come from Lisp.
2766 (handle_one_xevent): NATNUMP can eval its arg twice.
2767 (x_connection_closed):
2768 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2769 * xterm.h: Adjust decls to match defn changes elsewhere.
2770 (struct scroll_bar): Use struct vectorlike_header
2771 rather than rolling our own approximation.
2772 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2773
c6574eb5
GM
27742012-05-25 Glenn Morris <rgm@gnu.org>
2775
2776 * lisp.mk (lisp): Update for more files being compiled now.
2777
e8d32c7e
SM
27782012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2779
48def666
SM
2780 * lread.c: Remove `read_pure' which makes no difference.
2781 (read_pure): Remove var.
2782 (unreadpure): Remove function.
2783 (readevalloop): Don't call read_list with -1 flag.
2784 (read1, read_vector): Don't test read_pure any more.
2785 (read_list): Simplify.
2786
e8d32c7e
SM
2787 * fileio.c, character.h: Minor style tweaks.
2788
4b2addb7
DA
27892012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2790
2791 * window.h (clip_changed): Remove useless declaration.
2792
584461b2
JB
27932012-05-22 Juanma Barranquero <lekktu@gmail.com>
2794
2795 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2796 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2797
34374650
PE
27982012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2799
2800 Remove src/m/*.
2801 This directory predates autoconf and is no longer needed nowadays.
2802 Move its few remaining bits of functionality to where they're needed.
2803 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2804 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2805 * m/template.h: Remove.
2806 * Makefile.in (M_FILE): Remove. All uses removed.
2807 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2808 * lisp.h (USE_LSB_TAG):
2809 * mem-limits.h (EXCEEDS_LISP_PTR):
2810 Use VAL_MAX, not VALBITS, in #if.
2811 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2812 (EMACS_UINT): Define unconditionally now.
2813 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2814 (BITS_PER_EMACS_INT): New constants, replacing
2815 what used to be in config.h, but not useful in #if.
2816 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2817 define them any more.
2818 (VAL_MAX): New macro.
2819 (VALMASK): Use it.
2820 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2821 BITS_PER_EMACS_INT, in #if.
2822 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2823 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2824 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2825 * s/ms-w32.h (DATA_START):
2826 Move here from removed file m/intel386.h.
2827 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2828 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2829
261cb4bb
PE
28302012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2831
2832 Assume C89 or later.
2833 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2834 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2835 (xrealloc):
2836 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2837 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2838 * textprop.c, tparam.c (NULL): Remove.
2839 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2840 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2841 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2842 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2843 * xterm.c (input_signal_count): Assume volatile works.
2844
ff23cd9f
KB
28452012-05-21 Ken Brown <kbrown@cornell.edu>
2846
2847 * xgselect.c (xg_select): Fix first argument in call to 'select'
2848 (bug#11508).
2849
1b170bc6
KB
28502012-05-20 Ken Brown <kbrown@cornell.edu>
2851
2852 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2853 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2854
b2f4d39f
KB
28552012-05-19 Ken Brown <kbrown@cornell.edu>
2856
2857 * xfns.c (x_in_use): Remove `static' qualifier.
2858 * xterm.h (x_in_use): Declare.
2859 * xgselect.c: Include xterm.h.
2860 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2861 and `display_arg' (bug#9754).
2862
003fdae2
PE
28632012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2864
9232a6d9
PE
2865 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2866
003fdae2
PE
2867 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2868 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2869
784b56e2
EZ
28702012-05-18 Eli Zaretskii <eliz@gnu.org>
2871
2872 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2873
2874 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 2875 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
2876
2877 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2878 reference to image_cache->refcount.
2879 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2880
a0a79cde
JL
28812012-05-17 Juri Linkov <juri@jurta.org>
2882
2883 * search.c (Fword_search_regexp, Fword_search_backward)
2884 (Fword_search_forward, Fword_search_backward_lax)
2885 (Fword_search_forward_lax): Move functions to isearch.el
2886 (bug#10145, bug#11381).
2887
b0572523
PE
28882012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2889
2890 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2891
9660f5fc
SM
28922012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2893
2894 * lread.c (init_obarray): Declare Qt and Qnil as special.
2895
4374de83
GM
28962012-05-14 Glenn Morris <rgm@gnu.org>
2897
2898 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2899 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2900
dc44c39a
PE
29012012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2902
078c97cb
PE
2903 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2904
dc44c39a
PE
2905 * unexaix.c: Port to more-recent AIX compilers.
2906 (report_error, report_error_1, make_hdr, copy_sym)
2907 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2908 Make arguments const char *, not char *, to avoid violations of C
2909 standard and to fix some AIX warnings reported by Gilles Pion.
2910
e18afed7 29112012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2912
2913 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2914 already have overlays loaded.
2915 (handle_single_display_spec): Before returning without displaying
2916 fringe bitmap, synchronize the bidi iterator with the main display
2917 iterator, by calling iterate_out_of_display_property.
2918 (iterate_out_of_display_property): Detect buffer iteration by
2919 testing that it->string is a Lisp string.
2920 (get_next_display_element): When the current object is exhausted,
2921 and there's something on it->stack, call set_iterator_to_next to
2922 proceed with what's on the stack, instead of returning zero.
2923 (set_iterator_to_next): If called at the end of a Lisp string,
2924 proceed to consider_string_end without incrementing string
2925 position. Don't increment display vector index past the end of
2926 the display vector. (Bug#11417)
c8fb9dc6
EZ
2927 (pos_visible_p): Don't report a position visible when move_it_to
2928 stopped at the last line of window, which happens to be scanned
2929 backwards by the bidi iteration. (Bug#11464)
ac268e67 2930
e18afed7 29312012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2932
2933 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2934 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2935 are on a TTY, and thus unable to display on the fringes.
2936 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2937 so we need to signal to the caller that this is a "replacing"
2938 display spec. This fixes display when the spec is invalid or we
2939 are on a TTY.
2940
e18afed7 29412012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2942
2943 * unexaix.c (make_hdr): Fix typo in prototype.
2944 This bug broke the build on AIX. Problem reported by Gilles Pion.
2945
9d0a235a
MA
29462012-05-14 Michael Albinus <michael.albinus@gmx.de>
2947
2948 * keyboard.c (kbd_buffer_get_event): Read special events also in
2949 batch mode. (Bug#11415)
2950
9e6b06ed
GM
29512012-05-12 Glenn Morris <rgm@gnu.org>
2952
2953 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2954
c1a1d7a3
EZ
29552012-05-12 Eli Zaretskii <eliz@gnu.org>
2956
2957 * lisp.mk (lisp): Add newcomment.elc.
2958
3fe7cdc8
GM
29592012-05-12 Glenn Morris <rgm@gnu.org>
2960
2961 * Makefile.in (MKDIR_P): New, set by configure.
2962 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2963
53f7d2c0
PE
29642012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2965
2966 Remove unused function hourglass_started.
2967 * dispextern.h (hourglass_started):
2968 * w32fns.c (hourglass_started):
2969 * xdisp.c (hourglass_started): Remove.
2970
75aafb17
JB
29712012-05-10 Juanma Barranquero <lekktu@gmail.com>
2972
2973 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2974 Update dependencies.
2975
12959e8e
PE
29762012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2977
97107e2e
PE
2978 * xgselect.c (xg_select): Put maxfds+1 into a var.
2979 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2980
12959e8e
PE
2981 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2982
836d29b3
DA
29832012-05-10 Dave Abrahams <dave@boostpro.com>
2984
2985 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2986 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2987
5cb67954
MA
29882012-05-09 Michael Albinus <michael.albinus@gmx.de>
2989
2990 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2991 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2992 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2993 Initialize xd_registered_buses.
2994
3478ec45
PE
29952012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2996
b263a6b0
PE
2997 Untag more efficiently if USE_LSB_TAG.
2998 This is based on a proposal by YAMAMOTO Mitsuharu in
2999 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3000 For an admittedly artificial (nth 8000 longlist) benchmark on
3001 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3002 Emacs's overall text size by 1%.
3003 * lisp.h (XUNTAG): New macro.
3004 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3005 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3006 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3007 * eval.c (Fautoload):
3008 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3009 * frame.h (XFRAME): Use XUNTAG.
3010
3478ec45
PE
3011 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3012 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3013 Remove unportable assumptions about print widths of types like
3014 dbus_uint32_t.
3015 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3016 intptr_t when converting between pointer and integer, to avoid GCC
3017 warnings about wrong width.
3018
666b903b 30192012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3020
3021 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3022 stack for each reader_thread, instead of defaulting to 8MB
3023 determined by the linker. This avoids failures in creating
3024 subprocesses on Windows 7, see the discussion in this thread:
3025 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3026
b120cc17
JC
30272012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3028
3029 Fix up display of the *Minibuf-0* buffer in the mini window.
3030 * keyboard.c (read_char): Don't clear the echo area if there's no
3031 message to clear.
3032 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3033 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3034
9a4b36f8
MA
30352012-05-07 Michael Albinus <michael.albinus@gmx.de>
3036
3037 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3038 batch mode.
3039
e5f9458f
CY
30402012-05-06 Chong Yidong <cyd@gnu.org>
3041
3042 * lisp.mk (lisp): Update.
3043
eceeb5fc 30442012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3045
3046 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3047
71873e2b
SM
30482012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3049
3050 * data.c (PUT_ERROR): New macro.
3051 (syms_of_data): Use it. Add new error type `user-error'.
3052 * undo.c (user_error): New function.
3053 (Fprimitive_undo): Use it.
3054 * print.c (print_error_message): Adjust print style for `user-error'.
3055 * keyboard.c (user_error): New function.
3056 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3057
ab0fa4e4
PE
30582012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3059
3060 Do not limit current-time-string to years 1000..9999.
3061 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3062 (Fcurrent_time_string): Support any year that is supported by the
3063 underlying localtime representation. Don't use asctime, as it
3064 has undefined behavior for years outside the range -999..9999.
3065
7ed806a7
PE
30662012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3067
3068 Fix race conditions involving setenv, gmtime, localtime, asctime.
3069 Without this fix, interrupts could mess up code that uses these
3070 nonreentrant functions, since setting TZ invalidates existing
3071 tm_zone or tzname values, and since most of these functions return
3072 pointers to static storage.
3073 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3074 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3075 Grow the critical sections to include not just invoking
3076 localtime/gmtime, but also accessing these functions' results
3077 including their tm_zone values if any, and any related TZ setting.
3078 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3079 so that the struct tm is saved in the critical section.
3080 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3081 motivated by the fact that memory allocation needs to be outside
3082 the critical section.
3083
0c16dfed
DA
30842012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3085
3086 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3087 with RESET_INTERVAL.
3088
3089 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3090 Remove duplicated buffer name initialization.
3091
3f83ace8
JM
30922012-05-02 Jim Meyering <jim@meyering.net>
3093
3094 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3095
c7b8541e
JM
3096 * xfns.c (x_window): Use xstrdup (Bug#11375).
3097
90207a15 30982012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3099
3100 * xdisp.c (pos_visible_p): If already at a newline from the
3101 display string before the 'while' loop, don't walk back the glyphs
3102 from it3.glyph_row. Solves assertion violation when the display
3103 string begins with a newline (egg.el). (Bug#11367)
3104
b593d6a9
AH
31052012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3106
3107 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3108 Move to simple.el.
3109
4737362e
GM
31102012-05-01 Glenn Morris <rgm@gnu.org>
3111
99cf43f9
GM
3112 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3113 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3114 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3115 All were removed before 23.1.
3116
9311dcff
GM
3117 * dispnew.c: Remove HAVE_LIBNCURSES test;
3118 it is always true on relevant platforms.
3119
4d5c6349
GM
3120 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3121 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3122
4737362e
GM
3123 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3124
74dd3a6b
AS
31252012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3126
3127 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3128 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3129 Remove.
3130
13c379ee
PE
31312012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3132
3133 Do not avoid creating empty evaporating overlays (Bug#9642).
3134 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3135 That is, do not delete an evaporating overlay if it becomes
3136 empty after its bounds are adjusted to fit within its buffer.
3137 This fix caused other problems, and I'm reverting it until we get
3138 to the bottom of them.
3139
a8e7d6d7 31402012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3141
3142 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3143
a8e7d6d7 31442012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3145
3146 * xdisp.c (pos_visible_p): If the window start position is beyond
3147 ZV, start the display from buffer beginning. Prevents assertion
3148 violation in init_iterator when the minibuffer window is scrolled
3149 via the scroll bar.
3150
3151 * window.c (window_scroll_pixel_based): Likewise.
3152
a8e7d6d7 31532012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3154
3155 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3156
a8e7d6d7 31572012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3158
3159 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3160 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3161
a8e7d6d7 31622012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3163
b593d6a9
AH
3164 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3165 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3166
1c6900d9
EZ
31672012-04-26 Eli Zaretskii <eliz@gnu.org>
3168
4c3fa1d9
EZ
3169 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3170 display element, check also the underlying string or buffer
3171 character. (Bug#11341)
3172
1c6900d9
EZ
3173 * w32menu.c: Include w32heap.h.
3174 (add_menu_item): If the call to AppendMenuW (via
3175 unicode_append_menu) fails, disable Unicode menus only if we are
3176 running on Windows 9X/Me.
3177
42bf8205
AS
31782012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3179
3180 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3181 (xgetint): Add missing shift for LSB tags.
3182
b1bac16e
MR
31832012-04-24 Martin Rudalics <rudalics@gmx.at>
3184
3185 * keyboard.c (read_char): Don't wipe echo area for select window
3186 events: These might get delayed via `mouse-autoselect-window'
3187 (Bug#11304).
3188
d69621cc
JB
31892012-04-24 Juanma Barranquero <lekktu@gmail.com>
3190
3191 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3192 manipulation of :loaded-from data.
3193
02fd101b
JB
31942012-04-23 Juanma Barranquero <lekktu@gmail.com>
3195
3196 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3197 now a cons (bug#11311).
3198
888bec30
PE
31992012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3200
89a438bd
PE
3201 Do not create empty overlays with the evaporate property (Bug#9642).
3202 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3203 if it becomes empty after its bounds are adjusted to fit within
3204 its buffer. Without this fix, in a nonempty buffer (let ((o
3205 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3206 yields an empty overlay that has the evaporate property, which is
3207 not supposed to happen.
3208
1068fe4d
PE
3209 Fix minor GTK3 problems found by static checking.
3210 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3211 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3212 (struct _EmacsFixedClass, emacs_fixed_get_type):
3213 Move decls here from emacsgtkfixed.h, since they needn't be public.
3214 (emacs_fixed_get_type): Now static.
3215 (emacs_fixed_class_init): Omit unused local.
3216 (emacs_fixed_child_type): Remove; unused.
3217 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3218 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3219 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3220 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3221 (EMACS_FIXED_GET_CLASS): Remove; unused.
3222 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3223
888bec30
PE
3224 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3225 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3226
de85e130
PE
32272012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3228
d0baac98 3229 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3230 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3231 (__malloc_size_t, __malloc_ptrdiff_t):
3232 Remove. All uses removed, replaced by the definiens if needed,
3233 since we can assume C89 or better now.
3234 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3235 (protect_malloc_state, align, get_contiguous_space)
3236 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3237 (malloc_atfork_handler_child, malloc_enable_thread)
3238 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3239 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3240 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3241 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3242 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3243 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3244 Define using prototypes, not old style.
3245 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3246 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3247 (align): Don't assume that signed integer overflow wraps around.
3248 Omit unused local var.
3249 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3250 (_free_internal_nolock, memalign, mallochook, reallochook):
3251 Omit no-longer-needed casts.
3252 (valloc): Use getpagesize, not __getpagesize.
3253 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3254 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3255
de85e130
PE
3256 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3257
dcbf5805
MA
32582012-04-22 Michael Albinus <michael.albinus@gmx.de>
3259
3260 Move functions from C to Lisp. Make non-blocking method calls
3261 the default. Implement further D-Bus standard interfaces.
3262
3263 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3264 (QCdbus_request_name_allow_replacement)
3265 (QCdbus_request_name_replace_existing)
3266 (QCdbus_request_name_do_not_queue)
3267 (QCdbus_request_name_reply_primary_owner)
3268 (QCdbus_request_name_reply_in_queue)
3269 (QCdbus_request_name_reply_exists)
3270 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3271 (QCdbus_registered_serial, QCdbus_registered_method)
3272 (QCdbus_registered_signal): New Lisp objects.
3273 (XD_DEBUG_MESSAGE): Use sizeof.
3274 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3275 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3276 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3277 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3278 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3279 (xd_signature, xd_append_arg): Allow float for integer types.
3280 (xd_get_connection_references): New function.
b593d6a9
AH
3281 (xd_get_connection_address): Rename from xd_initialize.
3282 Return cached address.
dcbf5805
MA
3283 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3284 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3285 level.
3286 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3287 Return number of refcounts.
dcbf5805
MA
3288 (Fdbus_get_unique_name): Make stronger parameter check.
3289 (Fdbus_message_internal): New defun.
3290 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3291 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3292 (Fdbus_send_signal, Fdbus_register_service)
3293 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3294 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3295 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3296 (Vdbus_compiled_version, Vdbus_runtime_version)
3297 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3298 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3299 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3300 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3301 Adapt docstring.
dcbf5805 3302
52828e02
PE
33032012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3304
da05bc4c
PE
3305 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3306 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3307 Do not assume ptrdiff_t is the same width as 'int'.
3308
52828e02
PE
3309 * alloc.c: Handle unusual debugging option combinations.
3310 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3311 since the two debugging options are incompatible.
3312 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3313 is defined.
3314 (mem_init, mem_insert, mem_insert_fixup):
3315 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3316 (NEED_MEM_INSERT): Remove; no longer needed.
3317
f01769f9
LL
33182012-04-22 Leo Liu <sdl.web@gmail.com>
3319
3320 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3321
5790543d
PE
33222012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3323
3324 * sysdep.c [__FreeBSD__]: Minor cleanups.
3325 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3326 Use Emacs indenting style more consistently. Avoid some casts.
3327 Use 'double' consistently rather than mixing 'float' and 'double'.
3328
b91b7e4d
EW
33292012-04-21 Eduard Wiebe <usenet@pusto.de>
3330
b593d6a9
AH
3331 * sysdep.c (list_system_processes, system_process_attributes):
3332 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3333
6114eb15
AS
33342012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3335
3336 * lisp.mk (lisp): Update.
3337
2f38dff7
PE
33382012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3339
3340 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3341 It is never used otherwise.
3342
4ae29f89
SM
33432012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3344
3345 * print.c (print_preprocess): Only check print_depth if print-circle
3346 is nil.
3347 (print_object): Check for cycles even when print-circle is nil and
3348 print-gensym is t, but only check print_depth if print-circle is nil.
3349
f30d612a
CY
33502012-04-20 Chong Yidong <cyd@gnu.org>
3351
3352 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3353 set the status to "failed" and ensure that sentinel is run.
3354
c07a4c0b 33552012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3356
3357 * process.c (Fset_process_inherit_coding_system_flag)
3358 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3359 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3360
c07a4c0b 33612012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3362
3363 * xdisp.c (string_buffer_position_lim): Limit starting position to
3364 BEGV.
3365 (set_cursor_from_row): If called for a mode-line or header-line
3366 row, return zero immediately.
3367 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3368 farther than the first row after the header line, if any.
3369 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3370 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3371
c07a4c0b 33722012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3373
4ae29f89
SM
3374 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3375 (bug#11238).
ad3a2b41 3376
c07a4c0b 33772012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 33782012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3379
3380 configure: new option --enable-gcc-warnings (Bug#11207)
3381 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3382 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3383 (ALL_CFLAGS): Use new macros rather than old.
3384 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3385 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3386 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3387 -Wunused-result, -Wunused-variable. This should go away once
3388 the Emacs and Gnulib regex code is merged.
3389 (xmalloc, xrealloc): Now static.
3390
aba027e8
PE
33912012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3392
3393 * dired.c (Fsystem_groups): Remove unused local.
3394
e5a36063
GM
33952012-04-17 Glenn Morris <rgm@gnu.org>
3396
3397 * dired.c (Fsystem_users): Doc fix.
3398
316411f0
DA
33992012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3400
3401 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3402 (syms_of_dired): Add them.
3403
9426aba4
PE
34042012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3405
b62a57be
PE
3406 Fix minor alloc.c problems found by static checking.
3407 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3408 New extern decls, to avoid calling undeclared functions.
3409 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3410 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3411 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3412 (NEED_MEM_INSERT): New macro.
3413 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3414 Remove one incorrect comment and fix another.
b62a57be 3415
3539f31f
PE
3416 Fix minor ralloc.c problems found by static checking.
3417 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3418 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3419 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3420 (r_alloc_sbrk): Now static.
3421
a041960a
PE
3422 Improve ralloc.c interface checking.
3423 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3424 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3425 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3426 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3427 [REL_ALLOC]: ... to here, to check interface.
3428 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3429 Remove decls. This fixes an "It stinks!".
3430
9426aba4
PE
3431 * alloc.c (which_symbols): Fix alignment issue / type clash.
3432
d55c12ed
AS
34332012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3434
3435 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3436 (struct Lisp_Misc_Any): Likewise.
3437 (struct Lisp_Free): Likewise.
3438 * alloc.c (union aligned_Lisp_Symbol): Define.
3439 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3440 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3441 (union aligned_Lisp_Misc): Define.
3442 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3443 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3444 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3445
b948ce8b
PE
34462012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3447
3448 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3449 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3450 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3451 * s/netbsd.h, s/sol2-6.h:
3452 Remove definition of GC_MARK_STACK, since the default now works.
3453 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3454 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3455 no longer the default.
3456 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3457
35dc09a1 34582012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3459
35dc09a1
GM
3460 * lread.c (lisp_file_lexically_bound_p):
3461 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3462
35dc09a1
GM
34632012-04-14 Eli Zaretskii <eliz@gnu.org>
3464
3465 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3466 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3467
34682012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3469
3470 * nsterm.m (constrainFrameRect): Always constrain when there is only
3471 one screen (Bug#10962).
3472
bcd86815
KB
34732012-04-13 Ken Brown <kbrown@cornell.edu>
3474
3475 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3476
c25df26e
RT
34772012-04-13 Reuben Thomas <rrt@sc3d.org>
3478
3479 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3480
0fc59f1e
DC
34812012-04-11 Daniel Colascione <dancol@dancol.org>
3482
3483 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3484 against is gone. It's better to use vfork now so that when Cygwin
3485 gains a new, working vfork, we use it automatically (bug#10398).
3486
de8c03dc
SM
34872012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3488
3489 * window.c (save_window_save): Obey window-point-insertion-type.
3490
2f097256
GM
34912012-04-11 Glenn Morris <rgm@gnu.org>
3492
3493 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3494
453b951e
SM
34952012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3496
3497 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3498
75f1671a 34992012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3500
3501 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3502 (force_quit_count): New var.
3503 (handle_interrupt): Use it.
3504
2a8ce227
JB
35052012-04-10 Juanma Barranquero <lekktu@gmail.com>
3506
3507 * w32.c (w32_delayed_load): Record the full path of the library
3508 being loaded (bug#10424).
3509
935396c0
GM
35102012-04-09 Glenn Morris <rgm@gnu.org>
3511
05920a43
GM
3512 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3513 not just in the obarray, before snarfing them. (Bug#11036)
3514
935396c0
GM
3515 * Makefile.in ($(leimdir)/leim-list.el):
3516 Pass EMACS rather than BUILT_EMACS.
3517
a18ecafa
TZ
35182012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3519
3520 * process.c (make_process):
3521 * process.h: Add integer `gnutls_handshakes_tried' member to
3522 process struct.
3523
6bbef4e5
JC
3524 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3525 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3526
3527 * gnutls.c (gnutls_log_function2i): Convenience log function.
3528 (emacs_gnutls_read): Use new log functions,
3529 `gnutls_handshakes_tried' process member, and
3530 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3531 attempts per process (connection).
3532
b4d3bc10
CY
35332012-04-09 Chong Yidong <cyd@gnu.org>
3534
3535 * eval.c (Fuser_variable_p, user_variable_p_eh)
3536 (lisp_indirect_variable): Functions deleted.
3537 (Fdefvar): Caller changed.
3538
3539 * callint.c (Finteractive, Fcall_interactively):
3540 * minibuf.c (Fread_variable): Callers changed.
3541
70f4d973
EZ
35422012-04-09 Eli Zaretskii <eliz@gnu.org>
3543
3544 * xdisp.c (set_cursor_from_row): If the display string appears in
3545 the buffer at position that is closer to point than the position
3546 after the display string, display the cursor on the first glyph of
3547 the display string. Fixes cursor display when a 'display' text
3548 property immediately follows invisible text. (Bug#11094)
3549
cb3c2e3e
PE
35502012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3551
3552 composite.c: use 'double' consistently
3553 * composite.c (get_composition_id): Use 'double' consistently
3554 instead of converting 'float' to 'double' and vice versa; this is
3555 easier to understand and avoids a GCC warning.
3556
fd06db5d
GM
35572012-04-09 Glenn Morris <rgm@gnu.org>
3558
50fe702a
GM
3559 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3560 preparation for dumping it with emacs. (Bug#4789)
3561 (leimdir): New variable.
3562 ($(leimdir)/leim-list.el): New rule.
3563 (emacs$(EXEEXT)): Depend on leim-list.el.
3564
fd06db5d
GM
3565 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3566 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3567 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3568
55c131ee
AS
35692012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3570
3571 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3572 proper alignment.
3573
9209588f
JB
35742012-04-07 Juanma Barranquero <lekktu@gmail.com>
3575
3576 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3577 Remove unused local variable.
3578
e3fb2efb
PE
35792012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3580
3581 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3582 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3583 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3584 objects, as mark_maybe_pointer will catch them otherwise.
3585 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3586 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3587
b5385551
PE
35882012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3589
3590 Fix typo that broke non-Windows builds.
3591 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3592
9078ead6
EZ
35932012-04-07 Eli Zaretskii <eliz@gnu.org>
3594
3595 Support building on MS-Windows with libxml2.
3596
3597 * makefile.w32-in (OBJ2): Add xml.$(O).
3598 (GLOBAL_SOURCES): Add xml.c.
3599 ($(BLD)/xml.$(O)): New dependency list.
3600
3601 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3602 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3603 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3604 [!WINDOWSNT]: New macros.
3605 (init_libxml2_functions, libxml2_loaded_p): New functions.
3606 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3607 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3608 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3609 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3610 linked in).
6bbef4e5
JC
3611 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3612 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3613 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3614
3615 * emacs.c: Don't include libxml/parser.h.
3616 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3617 xmlCleanupParser directly.
3618
3619 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3620
3811fdf3
EZ
36212012-04-07 Eli Zaretskii <eliz@gnu.org>
3622
3623 * indent.c (Fvertical_motion): If there is a display string at
3624 point, use it.vpos to compute how many lines to backtrack after
3625 move_it_to point. (Bug#11133)
3626
2f8e16b2
EZ
36272012-04-06 Eli Zaretskii <eliz@gnu.org>
3628
3629 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3630 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3631 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3632 macros related to unification of CJK characters. For the details,
3633 see the discussion following the message here:
3634 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3635
3d439cd1
CY
36362012-04-04 Chong Yidong <cyd@gnu.org>
3637
3638 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3639
8bc53d00
EZ
36402012-04-01 Eli Zaretskii <eliz@gnu.org>
3641
3642 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3643 instead of alloca. (Bug#11138)
3644
3b0512a3
AS
36452012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3646
3647 * w32menu.c (is_simple_dialog): Properly check lisp types.
3648 (Bug#11141)
3649
8427ddd2
EZ
36502012-03-31 Eli Zaretskii <eliz@gnu.org>
3651
979022ef
EZ
3652 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3653 position we get to after a call to move_it_to fails the
3654 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3655 only if we wind up in a string from display property. (Bug#11063)
3656
a6b1c7cc
EZ
3657 * window.c (Fdelete_other_windows_internal): Invalidate the row
3658 and column information about mouse highlight, so that redisplay
3659 restores it after reallocating the glyph matrices. (Bug#7464)
3660
8427ddd2
EZ
3661 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3662 string comes from a `display' text property, use the buffer
3663 position of that property as if we actually saw that position in
3664 the row's glyphs.
697ba24b
EZ
3665 (move_it_by_lines): Remove the assertion that
3666 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3667 violated when there's a before-string at the beginning of a line.
3668 (Bug#11063)
8427ddd2 3669
65a0a738
EZ
36702012-03-30 Eli Zaretskii <eliz@gnu.org>
3671
3672 * xdisp.c (append_space_for_newline): If the default face was
3673 remapped, use the remapped face for the appended newline.
3674 (extend_face_to_end_of_line): Use the remapped default face for
3675 extending the face to the end of the line.
3676 (display_line): Call extend_face_to_end_of_line when the default
3677 face was remapped. (Bug#11068)
3678
581355cc
EZ
36792012-03-29 Eli Zaretskii <eliz@gnu.org>
3680
3681 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3682
e8fc049f
SM
36832012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3684
3685 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3686
4fb9a543
GM
36872012-03-27 Glenn Morris <rgm@gnu.org>
3688
3689 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3690 Doc fixes.
3691
679910f1
KH
36922012-03-26 Kenichi Handa <handa@m17n.org>
3693
3694 * dispextern.h (struct glyph): Fix previous change. Change the
3695 bit length of glyphless.ch to 25 (Bug#11082).
3696
90d49b7f
CY
36972012-03-26 Chong Yidong <cyd@gnu.org>
3698
3699 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3700 (command_loop_1): Use it; inhibit selection update for
3701 handle-select-window too (Bug#8996).
3702
f514f6f0
FP
37032012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3704
e8fc049f 3705 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3706
bf43fa51
KH
37072012-03-25 Kenichi Handa <handa@m17n.org>
3708
3709 * dispextern.h (struct glyph): Change the bit length of
3710 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3711
8a0c01dd
EZ
37122012-03-24 Eli Zaretskii <eliz@gnu.org>
3713
3714 * s/ms-w32.h (tzname): Include time.h before redirecting to
3715 _tzname. Fixes the MSVC build. (Bug#9960)
3716
7d1c3a76
AS
37172012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3718
8ed79523
AS
3719 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3720 characters.
3721
7d1c3a76
AS
3722 * xterm.c (XTread_socket): Only modify handling_signal if
3723 !SYNC_INPUT. (Bug#11080)
3724
e99a9b8b
EZ
37252012-03-23 Eli Zaretskii <eliz@gnu.org>
3726
3727 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3728 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3729 when fetching a multibyte character consumes more bytes than
3730 CHAR_BYTES returns, due to unification of CJK characters in
3731 string_char. (Bug#11073)
3732
5063c0e1
TN
37332012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3734
3735 * process.c (wait_reading_process_output): Handle pty disconnect
3736 by refraining from sending oneself a SIGCHLD (bug#10933).
3737
9f851fbd
CY
37382012-03-22 Chong Yidong <cyd@gnu.org>
3739
3740 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3741
5063c0e1 3742 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3743 Mark string as coming from a prefix property.
3744 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3745 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3746
fb5b8aca
CY
37472012-03-21 Chong Yidong <cyd@gnu.org>
3748
3749 * xfaces.c (Vface_remapping_alist): Doc fix.
3750
62356a1b
EZ
37512012-03-20 Eli Zaretskii <eliz@gnu.org>
3752
3753 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3754 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3755 Doc fixes.
62356a1b 3756
025de85b
CY
37572012-03-20 Chong Yidong <cyd@gnu.org>
3758
3759 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3760 to reflect default non-nil value of redisplay-dont-pause.
3761
4827f94e
KH
37622012-03-19 Kenichi Handa <handa@m17n.org>
3763
3764 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3765 it fit in a valid range (Bug#11003).
3766
e50a24a2
EZ
37672012-03-18 Eli Zaretskii <eliz@gnu.org>
3768
3769 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3770 that is not from display property, accept the row as a "cursor
3771 row" if one of the string's character has a non-nil `cursor'
3772 property. Fixes cursor positioning when there are newlines in
3773 overlay strings, e.g. in icomplete.el. (Bug#11035)
3774
9af5ed87
PE
37752012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3776
3777 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3778
d1f55f16
CY
37792012-03-12 Chong Yidong <cyd@gnu.org>
3780
3781 * eval.c (inhibit_lisp_code): Rename from
3782 inhibit_window_configuration_change_hook; move from window.c.
3783
3784 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3785 * window.c (run_window_configuration_change_hook)
3786 (syms_of_window): Callers changed.
3787
66c5eebd
CY
37882012-03-11 Chong Yidong <cyd@gnu.org>
3789
413df973
CY
3790 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3791
66c5eebd
CY
3792 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3793
1de11f56
CY
37942012-03-10 Chong Yidong <cyd@gnu.org>
3795
3796 * frame.c (other_visible_frames): Don't assume the selected frame
3797 is visible (Bug#10955).
3798
cae07000
SM
37992012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3800
3801 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3802
89c94350
JD
38032012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3804
3805 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3806 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3807 zero (Bug#10954).
3808
999dd333
GM
38092012-03-03 Glenn Morris <rgm@gnu.org>
3810
01a6dcc8 3811 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3812
de0100f2
EZ
38132012-03-02 Eli Zaretskii <eliz@gnu.org>
3814
3815 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3816 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3817 (redisplay_window, next_element_from_string): Fix typos in
3818 comments.
3e441275
EZ
3819 (redisplay_window): Pass to move_it_vertically the margin in
3820 pixels, not in screen lines.
de0100f2 3821
96a72ee9
GM
38222012-03-02 Glenn Morris <rgm@gnu.org>
3823
3824 * buffer.c (buffer-list-update-hook): Doc fix.
3825
312508d7
EZ
38262012-02-29 Eli Zaretskii <eliz@gnu.org>
3827
3828 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3829 push_it before setting up the iterator for the first overlay
3830 string, even if we have an empty string loaded.
3831 (next_overlay_string): If there's an empty string on the iterator
3832 stack, pop the stack. (Bug#10903)
3833
27f3c637
PE
38342012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3835
3836 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3837 Suggested by Stefan Monnier in
3838 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3839 * alloc.c (widen_to_Lisp_Object): New static function.
3840 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3841 and widening them to Lisp_Objects. This would work even if
3842 USE_LSB_TAG is defined and wide integers are used, which might
3843 happen in a future version of Emacs.
3844
3c9dfce6
CY
38452012-02-25 Chong Yidong <cyd@gnu.org>
3846
fa74b241
CY
3847 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3848 Doc fix.
3849
3c9dfce6
CY
3850 * xselect.c (Fx_selection_exists_p): Doc fix.
3851 (x_clipboard_manager_save_all): Print an informative message
3852 before saving to clipboard manager.
3853
9486df08
CY
38542012-02-24 Chong Yidong <cyd@gnu.org>
3855
3856 * keyboard.c (process_special_events): Handle all X selection
3857 requests in kbd_buffer, not just the next one (Bug#8869).
3858
f01d3321
CY
38592012-02-23 Chong Yidong <cyd@gnu.org>
3860
3861 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3862 call when setting menu-bar-lines and tool-bar-lines parameters.
3863 (unwind_create_frame_1): New helper function.
3864
3865 * window.c (inhibit_window_configuration_change_hook): New var.
3866 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3867 (syms_of_window): Initialize it.
f01d3321 3868
86b847b6
CY
38692012-02-22 Chong Yidong <cyd@gnu.org>
3870
3871 * xterm.c (x_draw_image_relief): Add missing type check for
3872 Vtool_bar_button_margin (Bug#10743).
3873
a59225b1
CY
38742012-02-21 Chong Yidong <cyd@gnu.org>
3875
3876 * fileio.c (Vfile_name_handler_alist): Doc fix.
3877
3878 * buffer.c (Fget_file_buffer): Protect against invalid file
3879 handler return value.
3880
310f5bd4
PE
38812012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3882
cb3a28cc
PE
3883 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3884 when computing $valmask.
3885
310f5bd4
PE
3886 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3887 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3888 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3889 It's useless in that case, and it can cause problems on hosts
3890 that allocate halves of EMACS_INT values separately.
3891 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3892 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3893 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3894 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3895 it avoids undefined behavior on hosts where shifting right by more
3896 than the word width has undefined behavior.
3897
2375c96a
CY
38982012-02-19 Chong Yidong <cyd@gnu.org>
3899
3900 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3901 (Funhandled_file_name_directory, Ffile_name_as_directory)
3902 (Fdirectory_file_name, Fexpand_file_name)
3903 (Fsubstitute_in_file_name): Protect against invalid file handler
3904 return values (Bug#10845).
3905
3eb49e71
EZ
39062012-02-18 Eli Zaretskii <eliz@gnu.org>
3907
3908 * .gdbinit (pitx): Fix incorrect references to fields of the
3909 iterator stack.
3910
7b926f3f
CY
39112012-02-17 Chong Yidong <cyd@gnu.org>
3912
3913 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3914
11273115
PE
39152012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3916
3917 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3918 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3919
c3a70e2b
CY
39202012-02-15 Chong Yidong <cyd@gnu.org>
3921
3922 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3923 marked as special. Also, starting docstrings with * is obsolete.
3924
0ca43699
AS
39252012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3926
3927 * gnutls.c (emacs_gnutls_write): Fix last change.
3928
2e8f3c56
LI
39292012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3930
3931 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3932 send_process.
3933
af70074f
SM
39342012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3935
3936 * keymap.c (Fsingle_key_description): Handle char ranges.
3937
95986d52
CY
39382012-02-12 Chong Yidong <cyd@gnu.org>
3939
afd83bd1
CY
3940 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3941 as that creates a dangerous corner case.
3942
95986d52
CY
3943 * window.c (Fdelete_window_internal): Invalidate the mouse
3944 highlight (Bug#9904).
3945
bd7da63e
GM
39462012-02-12 Glenn Morris <rgm@gnu.org>
3947
3948 * xselect.c (Fx_own_selection_internal)
3949 (Fx_get_selection_internal, Fx_disown_selection_internal)
3950 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3951 * nsselect.m (Fx_own_selection_internal)
3952 (Fx_disown_selection_internal, Fx_selection_exists_p)
3953 (Fx_selection_owner_p, Fx_get_selection_internal):
3954 Sync docs and argument specs with the xselect.c versions.
3955
77abcbc2
LI
39562012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3957
3958 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3959
90b671e2
EZ
39602012-02-11 Eli Zaretskii <eliz@gnu.org>
3961
1c0ca0b7
EZ
3962 * w32select.c (Fx_selection_exists_p): Sync doc string and
3963 argument list with xselect.c. (Bug#10783)
3964
3965 * w16select.c (Fx_selection_exists_p): Sync doc string and
3966 argument list with xselect.c. (Bug#10783)
90b671e2 3967
49241268
GM
39682012-02-10 Glenn Morris <rgm@gnu.org>
3969
3970 * fns.c (Fsecure_hash): Doc fix.
3971
f998bbe7 39722012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3973
3974 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3975
0992bd9c
CY
39762012-02-07 Chong Yidong <cyd@gnu.org>
3977
3978 * buffer.c (Fbuffer_local_variables)
3979 (buffer_lisp_local_variables): Handle unbound vars correctly;
3980 don't let Qunbound leak into Lisp.
3981
af008560
GM
39822012-02-07 Glenn Morris <rgm@gnu.org>
3983
dd605cc4
GM
3984 * image.c (Fimagemagick_types): Doc fix.
3985
af008560
GM
3986 * image.c (imagemagick-render-type): Change it from a lisp object
3987 to an integer. Move the doc here from the lisp manual.
3988 Treat all values not equal to 0 the same.
3989
1449fa1d
CY
39902012-02-06 Chong Yidong <cyd@gnu.org>
3991
3992 * doc.c (store_function_docstring): Avoid applying docstring of
3993 alias to base function (Bug#2603).
3994
3723ec07
AS
39952012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3996
3997 * .gdbinit (pp1, pv1): Remove redundant defines.
3998 (pr): Use pp.
3999
79c1cc1e
CY
40002012-02-04 Chong Yidong <cyd@gnu.org>
4001
4002 * nsterm.m: Declare a global (Bug#10694).
4003
d7f29f8e
EZ
40042012-02-04 Eli Zaretskii <eliz@gnu.org>
4005
cae07000
SM
4006 * w32.c (get_emacs_configuration_options):
4007 Include --enable-checking, if specified, in the return value.
d7f29f8e 4008
3b95a6f9
MR
40092012-02-04 Martin Rudalics <rudalics@gmx.at>
4010
4011 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4012 after rounding frame sizes. (Bug#9723)
4013
d6fa96a6
EZ
40142012-02-04 Eli Zaretskii <eliz@gnu.org>
4015
4016 * keyboard.c (adjust_point_for_property): Don't position point
4017 before BEGV. (Bug#10696)
4018
df0b2940
PE
40192012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4020
4021 Handle overflow when computing char display width (Bug#9496).
4022 * character.c (char_width): Return EMACS_INT, not int.
4023 (char_width, c_string_width): Check for overflow when
4024 computing the width; this is possible now that individual
4025 characters can have unbounded width. Problem introduced
4026 by merge from Emacs 23 on 2012-01-19.
4027
6bee44d6
MA
40282012-02-02 Michael Albinus <michael.albinus@gmx.de>
4029
4030 * dbusbind.c (Fdbus_register_method): Mention the return value
4031 :ignore in the docstring.
4032
44f92739
GM
40332012-02-02 Glenn Morris <rgm@gnu.org>
4034
1b9f60cc
GM
4035 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4036
44f92739
GM
4037 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4038 Unconditionally set to t. (Bug#10673)
4039 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4040 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4041 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4042
c5d3843c
KH
40432012-02-02 Kenichi Handa <handa@m17n.org>
4044
4045 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4046 0, do not call append_composite_glyph.
4047
159462d4 40482012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4049
4050 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4051 NULL (Bug#6988).
4052 (x_produce_glyphs): If the component of a composition is a null
4053 string, set it->pixel_width to 1 to avoid zero-width glyph.
4054
78cef877
EZ
40552012-02-01 Eli Zaretskii <eliz@gnu.org>
4056
4057 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4058 first 2 arguments are identical. This makes inserting large
4059 output from a subprocess an order of magnitude faster on
4060 MS-Windows, where all sbrk'ed memory is always contiguous.
4061
97897668
GM
40622012-01-31 Glenn Morris <rgm@gnu.org>
4063
4064 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4065 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4066 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4067
31fd3586
GM
40682012-01-29 Glenn Morris <rgm@gnu.org>
4069
4070 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4071
0e24a8b2
CY
40722012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4073
4074 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4075
cc0adcb0
CY
40762012-01-28 Chong Yidong <cyd@gnu.org>
4077
4078 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4079
acc28cb9
CY
40802012-01-26 Chong Yidong <cyd@gnu.org>
4081
9c69cfb7
CY
4082 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4083
acc28cb9
CY
4084 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4085 repeat counts (Bug#10507).
4086
48da7392
GM
40872012-01-26 Glenn Morris <rgm@gnu.org>
4088
4089 * lread.c (syms_of_lread): Doc fix.
4090
14af5f7f
CY
40912012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4092
4093 * coding.c (encode_designation_at_bol): Change return value to
4094 EMACS_INT.
4095
0b21c100
CY
40962012-01-25 Chong Yidong <cyd@gnu.org>
4097
4098 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4099
3c2907f7
CY
41002012-01-21 Chong Yidong <cyd@gnu.org>
4101
4102 * floatfns.c (Fcopysign): Make the second argument non-optional,
4103 since nil is not allowed anyway.
4104
959ad23f
AS
41052012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4106
4107 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4108 (send_process): Likewise.
4109
34a02f46
MR
41102012-01-19 Martin Rudalics <rudalics@gmx.at>
4111
4112 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4113 (Vwindow_persistent_parameters): Do not use Qstate.
4114 Rewrite doc-strings.
34a02f46 4115
1259009a 41162012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4117
4118 * character.c (char_width): New function.
70d4fdf6
GM
4119 (Fchar_width, c_string_width, lisp_string_width):
4120 Use char_width (Bug#9496).
25ed9e61 4121
6a6ee00d
MR
41222012-01-16 Martin Rudalics <rudalics@gmx.at>
4123
4124 * window.c (Vwindow_persistent_parameters): New variable.
4125 (Fset_window_configuration, save_window_save): Handle persistent
4126 window parameters.
4127
c85efaf7
EZ
41282012-01-14 Eli Zaretskii <eliz@gnu.org>
4129
4130 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4131 thrashing the stack of the thread. (Bug#9087)
4132
5944709e
PE
41332012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4134
4135 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4136
e71f5d99
EZ
41372012-01-11 Eli Zaretskii <eliz@gnu.org>
4138
4139 * xdisp.c (rows_from_pos_range): Handle the case where the
4140 highlight ends on a newline. (Bug#10464)
4141 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4142 he end column for display of highlight that ends on a newline
4143 before a R2L line.
4144
ce316182
GM
41452012-01-11 Glenn Morris <rgm@gnu.org>
4146
4147 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4148 from load-path also when installation-directory is nil. (Bug#10208)
4149
5b43da69
GM
41502012-01-10 Glenn Morris <rgm@gnu.org>
4151
74cc8ff9
GM
4152 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4153
7d8d6e4e
GM
4154 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4155 Update template values to be closer to their typical values these days.
5b43da69 4156
a0db8d43
EZ
41572012-01-09 Eli Zaretskii <eliz@gnu.org>
4158
4159 * xdisp.c (rows_from_pos_range): Accept additional argument
4160 DISP_STRING, and accept any glyph in a row whose object is that
4161 string as eligible for mouse highlight. Fixes mouse highlight of
4162 display strings from overlays. (Bug#10464)
4163
9a0115ab 41642012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4165
b9110d6a 4166 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4167 * fileio.c (auto_saving_dir_umask): New static var.
4168 (Fmake_directory_internal): Use it.
4169 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4170 creating the directory. The old code temporarily assigns
4171 too-generous permissions to the directory.
4172 (do_auto_save_eh): Clear it.
b9110d6a 4173 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4174 that the var is always cleared.
4175
6c1bd3f3
EZ
41762012-01-07 Eli Zaretskii <eliz@gnu.org>
4177
4178 * search.c (scan_buffer): Pass character positions to
4179 know_region_cache, not byte positions. (Bug#6540)
4180
069d2b50
L
41812012-01-07 LynX <_LynX@bk.ru> (tiny change)
4182
4183 * w32.c (sys_rename): Report EXDEV when rename of a directory
4184 fails because the target is on another logical disk. (Bug#10284)
4185
75bf0d33
DB
41862012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4187
4188 * xterm.c (x_embed_request_focus): New function.
4189
4190 * xterm.h: Add prototype.
4191
4192 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4193
1c6e5a32
GM
41942012-01-05 Glenn Morris <rgm@gnu.org>
4195
4196 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4197
651e947e
EZ
41982012-01-01 Eli Zaretskii <eliz@gnu.org>
4199
4200 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4201 Load gnutls_transport_set_lowat only if GnuTLS version is below
4202 2.11.1.
4203 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4204 GnuTLS versions below 2.11.1.
4205
3778cdd8
AL
42062011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4207
4208 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4209 to the doc string advising against its use for altering the way
4210 windows are scrolled.
4211
0e5317f7
KH
42122011-12-28 Kenichi Handa <handa@m17n.org>
4213
4214 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4215 coding-system ASCII compatible only when it does not produce BOM
4216 on encoding (Bug#10383).
4217
93d5ca1f
JD
42182011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4219
4220 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4221 can scroll.
4222 (create_and_show_popup_menu): Always use menu_position_func for
4223 Gtk3 (Bug#10361).
4224
ca22b785
AS
42252011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4226
4227 * callint.c (Fcall_interactively): Don't truncate prompt string.
4228
d048e1e6
EZ
42292011-12-23 Eli Zaretskii <eliz@gnu.org>
4230
4231 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4232 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4233 resumed from there (after widening). (Bug#10360)
d048e1e6 4234
5ccaba1f
JD
42352011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4236
4237 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4238
204ee57f
JD
42392011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4240
b81d40f0
JB
4241 * nsterm.m (x_free_frame_resources):
4242 Release f->output_data.ns->miniimage.
204ee57f
JD
4243 (ns_index_color): Fix indentation. Do not retain
4244 color_table->colors[i].
4245
4246 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4247 before returning.
4248
4249 * nsfns.m (x_set_background_color): Assign return value from
4250 ns_index_color to face-background instead of NSColor*.
4251 (ns_implicitly_set_icon_type): Fix indentation.
4252 Change assignment in for loop to comparison.
4253
4254 * emacs.c (ns_pool): New variable.
4255 (main): Assign ns_pool.
4256 (Fkill_emacs): Call ns_release_autorelease_pool.
4257
4258 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4259 autorelease fdesc, release fdAttrs and tdict.
4260 (ns_get_covering_families): Release charset.
4261 (ns_findfonts): Release NSFontDescriptor created with new.
4262 (ns_uni_to_glyphs): Fix indentation.
4263 (setString): Release attrStr before assigning new value.
4264
c803b2b7
JD
42652011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4266
678f4426
JD
4267 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4268 and NS_IMPL_COCOA.
4269 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4270 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4271
cd394be1 42722011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4273
5fecd5fc
JD
4274 * nsterm.m (ns_term_init): Subscribe for notifications
4275 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4276 to method trackingNotification in EmacsMenu.
4277
4278 * nsmenu.m (trackingMenu): New variable.
3771cb17 4279 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4280 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4281 from Aquamacs (Bug#7030).
678f4426
JD
4282
42832011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4284
c803b2b7
JD
4285 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4286 (symbol_to_nsstring): Fix indentation.
4287 (ns_symbol_to_pb): New function.
cae07000
SM
4288 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4289 (Fns_rotate_cut_buffers_internal): Remove.
4290 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4291 Fns_store_cut_buffer_internal.
4292 (ns_get_foreign_selection, Fx_own_selection_internal)
4293 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4294 (Fns_get_selection_internal, Fns_store_selection_internal):
4295 Use ns_symbol_to_pb and check if return value is nil.
4296 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4297 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4298 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4299 renamed to Sns_store_selection_internal.
4300 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4301 and remove this function.
4302 (ns_handle_selection_clear): Remove, never used.
4303 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4304 here.
4305
e1b01a3a
KB
43062011-12-17 Ken Brown <kbrown@cornell.edu>
4307
4308 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4309 GID is unknown (Bug#10257).
4310
2adb6e85
PE
43112011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4312
4313 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4314 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4315 which caused a build failure on GNU/Linux IA-64. This problem was
4316 introduced by my 2011-10-07 patch.
4317
d1d7b339
JL
43182011-12-15 Juri Linkov <juri@jurta.org>
4319
4320 * image.c (imagemagick_error): New function. (Bug#10112)
4321 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4322 Use `imagemagick_error' where ImageMagick functions return
4323 `MagickFalse'.
4324 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4325 proper order.
4326
100d5755
KH
43272011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4328
4329 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4330 fill background (Bug#8992).
4331
454592a6
MR
43322011-12-13 Martin Rudalics <rudalics@gmx.at>
4333
4334 * window.c (Vwindow_combination_resize)
4335 (Vwindow_combination_limit): Use t instead of non-nil in
4336 doc-strings.
61d4b438
MR
4337 (Vrecenter_redisplay): Add first sentence of doc-string on
4338 separate line.
53524d93 4339 (Frecenter): Fix doc-string typo.
454592a6 4340
3633e3aa
KH
43412011-12-11 Kenichi Handa <handa@m17n.org>
4342
4343 * coding.c (Funencodable_char_position): Pay attention to the
4344 buffer text relocation (Bug#9389).
4345
7b9d523a 43462011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4347
7b9d523a
JD
4348 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4349 gtk_init (Bug#10100).
4350
b73189c6
EZ
43512011-12-10 Eli Zaretskii <eliz@gnu.org>
4352
4353 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4354 IT->string is nil. (Bug#10263)
4355
f7dfe5d6
JD
43562011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4357
83faebb4
JD
4358 * nsterm.h (x_free_frame_resources): Declare.
4359
f7dfe5d6
JD
4360 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4361 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4362
4363 * nsterm.h (ns_get_defaults_value): Declare.
4364
4365 * nsterm.m (ns_default): Call ns_get_defaults_value.
4366
7cd4e72c
EZ
43672011-12-09 Eli Zaretskii <eliz@gnu.org>
4368
4369 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4370 (Bug#10170)
4371
b34d7317
YM
43722011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4373
4374 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4375 that where the value of an _OBJC_* symbol points to is in the .bss
4376 section (Bug#10240).
4377
76470ad1
KH
43782011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4379
4380 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4381 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4382
745fff94
KH
43832011-12-08 Kenichi Handa <handa@m17n.org>
4384
4385 * ftfont.c (get_adstyle_property): Fix previous change
4386 (Bug#10233).
4387
6e44397c
JB
43882011-12-07 Juanma Barranquero <lekktu@gmail.com>
4389
4390 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4391 dirs from the default value of EMACSLOADPATH (bug#10208).
4392
7efa6272
GM
43932011-12-07 Glenn Morris <rgm@gnu.org>
4394
4395 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4396 installation and source directories as well. (Bug#10208)
4397
f6fc4d87
CY
43982011-12-06 Chong Yidong <cyd@gnu.org>
4399
4400 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4401
2bf26180
GM
44022011-12-06 Glenn Morris <rgm@gnu.org>
4403
4404 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4405 as an error, not just -1. (Bug#10217)
4406
3a6ad4f0
CY
44072011-12-05 Chong Yidong <cyd@gnu.org>
4408
4409 * keyboard.c (process_special_events): New function.
4410 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4411
75a3b399
PE
44122011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4413
4414 * coding.c (encode_designation_at_bol): Don't use uninitialized
4415 local variable (Bug#9318).
4416
c3c9e25e
KH
44172011-12-05 Kenichi Handa <handa@m17n.org>
4418
4419 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4420 return Qnil (Bug#8046, Bug#10193).
4421
5eb05ea3
KH
44222011-12-05 Kenichi Handa <handa@m17n.org>
4423
4424 * coding.c (encode_designation_at_bol): New args charbuf_end and
4425 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4426 (coding_set_source): Return how many bytes coding->source was
4427 relocated.
4428 (coding_set_destination): Return how many bytes
4429 coding->destination was relocated.
4430 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4431 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4432
44332011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4434
4435 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4436 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4437 macro (Bug#9318).
4438
44392011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4440
4441 The following changes are to fix Bug#9318.
4442
a79703f5 4443 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4444 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4445 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4446 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4447
7dbda6df
JB
44482011-12-05 Juanma Barranquero <lekktu@gmail.com>
4449
4450 * lisp.h (process_quit_flag): Fix external declaration.
4451
6d5eb5b0
SM
44522011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4453
4454 Don't macro-inline non-performance-critical code.
4455 * eval.c (process_quit_flag): New function.
4456 * lisp.h (QUIT): Use it.
4457
a0c3fad0
JD
44582011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4459
4460 * nsfns.m (get_geometry_from_preferences): New function.
4461 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4462
6c07aac2
AS
44632011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4464
4465 * emacs.c (Qkill_emacs): Define.
4466 (syms_of_emacs): Initialize it.
4467 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4468 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4469 (quit_throw_to_read_char): Add parameter `from_signal'.
4470 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4471 * lisp.h (QUIT): Call Fkill_emacs if requested.
4472
c052ead4
JD
44732011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4474
4475 * widget.c (update_wm_hints): Return if wmshell is null.
4476 (widget_update_wm_size_hints): New function.
4477
4478 * widget.h (widget_update_wm_size_hints): Declare.
4479
4480 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4481 widget_update_wm_size_hints (Bug#10104).
4482
9e49252b
EZ
44832011-12-03 Eli Zaretskii <eliz@gnu.org>
4484
4485 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4486 before a newline, prepare the bidi iterator for consuming the
4487 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4488 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4489
02b16839
JL
44902011-12-02 Juri Linkov <juri@jurta.org>
4491
4492 * search.c (Fword_search_regexp): New Lisp function created from
4493 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4494 (Fword_search_backward, Fword_search_forward)
4495 (Fword_search_backward_lax, Fword_search_forward_lax):
4496 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4497 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4498
0068070e
SM
44992011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4500
4501 * fileio.c (Finsert_file_contents): Move after-change-function call
4502 to before the "handled:" label, since all "goto handled" appear in
4503 cases where the *-change-functions have already been properly called
4504 (bug#10117).
4505
3360a3fc
AS
45062011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4507
4508 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4509 waiting for input. (Bug#10169)
4510
73d6c093
EZ
45112011-11-30 Eli Zaretskii <eliz@gnu.org>
4512
4513 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4514 verifies glyph row's hash code--we have just reallocated the
4515 glyphs, so their contents can be complete garbage. (Bug#10164)
4516
febe6bea
JB
45172011-11-30 Juanma Barranquero <lekktu@gmail.com>
4518
4519 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4520
801a4313
EZ
45212011-11-30 Eli Zaretskii <eliz@gnu.org>
4522
4523 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4524 attributes are tested _before_ calling verify_row_hash, to protect
4525 against GCC re-ordering of the tests. (Bug#10164)
4526
2b56b87e
JD
45272011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4528
4529 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4530
4531 * xterm.c (handle_one_xevent): Only set async_visible and friends
4532 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4533 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4534 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4535
dbf31225
PE
45362011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4537
4538 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4539 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4540 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4541 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4542 All uses changed to use GCPRO1 etc.
4543 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4544 Revert to old implementation (i.e., before 2011-03-11).
4545
1305621b
YM
45462011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4547
4548 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4549 of scroll runs so as to avoid assigning disabled bogus rows and
4550 unnecessary graphics copy operations.
4551
8c9afb46
EZ
45522011-11-27 Eli Zaretskii <eliz@gnu.org>
4553
4554 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4555 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4556 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4557 (malloc, free, realloc, calloc): Redirect to e_* only when
4558 compiling Emacs.
4559
4560 * lisp.h (GCTYPEBITS): Move before first use.
4561 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4562 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4563 this macro definition.
4564
4565 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4566 _MSC_VER.
4567
54e9e3bf
JD
45682011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4569
6d5eb5b0
SM
4570 * gtkutil.c (xg_create_frame_widgets):
4571 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4572 present with Gtk+ 2.0.
4573
83aca1cb
PE
45742011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4575
4576 * fileio.c (Finsert_file_contents): Undo previous change; see
4577 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4578
5b76caa4
PE
45792011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4580
4581 Rename locals to avoid shadowing.
4582 * fileio.c (Finsert_file_contents):
4583 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4584 * process.c (wait_reading_process_output):
4585 Rename inner 'proc' to 'p' to avoid shadowing.
4586 Indent for consistency with usual Emacs style.
4587
8c535114
EZ
45882011-11-25 Eli Zaretskii <eliz@gnu.org>
4589
4590 * xdisp.c (redisplay_window): If cursor row is not fully visible
4591 after recentering, and scroll-conservatively is set to a large
4592 number, scroll window by a few more lines to make the cursor fully
4593 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4594 (start_display): Don't move to the next line if the display should
4595 start at a newline that is part of a display vector or an overlay
4596 string. (Bug#10119)
8c535114 4597
fa4fdb5c
JL
45982011-11-24 Juri Linkov <juri@jurta.org>
4599
4600 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4601 after the `MagickPingImage' call. (Bug#10112)
4602
90ec88df
CY
46032011-11-23 Chong Yidong <cyd@gnu.org>
4604
4605 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4606
56e2e794
MR
46072011-11-23 Martin Rudalics <rudalics@gmx.at>
4608
4609 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4610 making another buffer current. (Bug#10114)
4611
b6e64c41
GM
46122011-11-23 Glenn Morris <rgm@gnu.org>
4613
4614 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4615
6b21de18
CY
46162011-11-23 Chong Yidong <cyd@gnu.org>
4617
4618 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4619 using it (Bug#5984).
4620
b12cd789
EZ
46212011-11-22 Eli Zaretskii <eliz@gnu.org>
4622
4623 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4624 and header-lines, as they don't have one computed for them.
4625 (Bug#10098)
4626
4627 * .gdbinit (prow): Make displayed values more self-explaining.
4628 Add row's hash code.
4629
261b6fd4
LMI
46302011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4631
4632 * process.c (wait_reading_process_output): Fix asynchrounous
4633 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4634 (wait_reading_process_output): Add comment and URL.
261b6fd4 4635
e7cfd277
JD
46362011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4637
4638 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4639
a9b9b7f5
CY
46402011-11-21 Chong Yidong <cyd@gnu.org>
4641
4642 * window.c (Fnext_window, Fprevious_window): Doc fix.
4643
b0d15b4f
SM
46442011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4645
4646 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4647
fe7a3057
JB
46482011-11-20 Juanma Barranquero <lekktu@gmail.com>
4649
4650 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4651
d2999b1a
MR
46522011-11-20 Martin Rudalics <rudalics@gmx.at>
4653
4654 * window.c (Fset_window_combination_limit): Rename argument
4655 STATUS to LIMIT.
4656 (Vwindow_combination_limit): Remove "status" from doc-string.
4657
d5ff9cd0
AS
46582011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4659
4660 * m/ibms390.h: Remove.
4661 * m/ibms390x.h: Don't include "ibms390.h".
4662
a5bb9bd3
SM
46632011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4664
4665 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4666 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4667
cd1181db
JB
46682011-11-20 Juanma Barranquero <lekktu@gmail.com>
4669
4670 * casetab.c (Fset_case_table):
4671 * charset.c (Fcharset_after): Fix typos.
4672
615a3b8d 46732011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4674
17e845af
PE
4675 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4676 Otherwise, valgrind does not work on some platforms.
4677 Problem reported by Andreas Schwab in
6a0bf43d
PE
4678 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4679 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4680 is set, removing the need for VIRT_ADDRESS_VARIES.
4681 (PURE_P): Use a more-efficient implementation that needs just one
4682 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4683 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4684 to 4 (xorl, subq, cmpq, setbe).
4685 * alloc.c (pure): Always extern now, since that's the
4686 VIRT_ADDR_VARIES behavior.
4687 (PURE_POINTER_P): Use a single comparison, not two, for
4688 consistency with the new puresize.h.
4689 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4690 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4691 Remove VIRT_ADDR_VARIES no longer needed.
4692
f8fe6f96
EZ
46932011-11-19 Eli Zaretskii <eliz@gnu.org>
4694
4695 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4696 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4697 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4698 behave as if the cursor position were at the window margin.
4699
4700 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4701 and the cursor position is out of bounds, behave as if the cursor
4702 position were at the window margin. (Bug#10075)
4703
df05a53c
CY
47042011-11-18 Chong Yidong <cyd@gnu.org>
4705
4706 * window.c (Fwindow_combination_limit): Make first argument
4707 non-optional, since it is meaningless for live windows like the
4708 selected window.
61ccba97 4709
2071918e
DA
47102011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4711
4712 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4713
b50a28de
SM
47142011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4715
4716 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4717 (graft_intervals_into_buffer): Simplify.
4718
015137db
EZ
47192011-11-18 Eli Zaretskii <eliz@gnu.org>
4720
4721 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4722 hash values of the two rows.
4723 (copy_row_except_pointers): Preserve the used[] arrays and the
4724 hash values of the two rows. (Bug#10035)
68c95424 4725 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4726
4727 * xdisp.c (row_hash): New function, body extracted from
4728 compute_line_metrics.
4729 (compute_line_metrics): Call row_hash, instead of computing the
4730 hash code inline.
4731
4732 * dispnew.c (verify_row_hash): Call row_hash for computing the
4733 hash code of a row, instead of duplicating code from xdisp.c.
4734
4735 * dispextern.h (row_hash): Add prototype.
4736
a2addb04
TH
47372011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4738
4739 * frame.c (delete_frame): Don't delete the terminal when the last
4740 X frame is closed if emacs is built with GTK toolkit.
4741
df85d315
JB
47422011-11-17 Juanma Barranquero <lekktu@gmail.com>
4743
4744 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4745
a0c2d0ae
MR
47462011-11-17 Martin Rudalics <rudalics@gmx.at>
4747
4748 * window.c (Vwindow_splits): Rename to
4749 Vwindow_combination_resize. Suggested by Juri Linkov.
4750 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4751 of Vwindow_splits.
4752
58179cce
JB
47532011-11-16 Juanma Barranquero <lekktu@gmail.com>
4754
7877f373
JB
4755 * nsfns.m (Fns_font_name):
4756 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4757
b6f67890
MR
47582011-11-16 Martin Rudalics <rudalics@gmx.at>
4759
4760 * window.h (window): Rename slot "nest" to "combination_limit".
4761 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4762 (Fset_window_nest): Rename to Fset_window_combination_limit.
4763 (Vwindow_nest): Rename to Vwindow_combination_limit.
4764 (recombine_windows, make_parent_window, make_window)
4765 (Fsplit_window_internal, saved_window)
4766 (Fset_window_configuration, save_window_save): Rename all
4767 occurrences of window_nest to window_combination_limit.
4768
c7015153
JB
47692011-11-15 Juanma Barranquero <lekktu@gmail.com>
4770
4771 * image.c (imagemagick_load_image): Fix typo.
4772
322ad6ec
EZ
47732011-11-14 Eli Zaretskii <eliz@gnu.org>
4774
4775 * xdisp.c (display_line): Move the call to
4776 highlight_trailing_whitespace before the call to
4777 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4778 faces of all the glyphs to compute ROW's hash value.
4779 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4780
f067b8ec
JB
47812011-11-14 Juanma Barranquero <lekktu@gmail.com>
4782
4783 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4784 just return (bug#10044).
4785
1e5b2111
EZ
47862011-11-12 Eli Zaretskii <eliz@gnu.org>
4787
7ef3cbd5
EZ
4788 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4789 with user-defined heap size. Bump the default size of the temacs
4790 heap to 27MB, to avoid memory warning when running temacs.
4791 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4792
1e5b2111
EZ
4793 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4794 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4795 (verify_row_hash) [XASSERTS]: New function.
4796 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4797 that the hash value of glyph rows is correct.
1e5b2111 4798
89d61221
MR
47992011-11-12 Martin Rudalics <rudalics@gmx.at>
4800
4801 * window.h (window): Remove splits slot.
4802 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4803 (Fdelete_other_windows_internal, make_parent_window)
4804 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4805 (Fset_window_configuration, save_window_save): Don't deal with
4806 split status of windows.
4807 (saved_window): Remove splits slot.
4808 (Vwindow_splits): Rewrite doc-string.
4809
97f18cc8
JD
48102011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4811
4812 * xfns.c (unwind_create_frame):
4813 * nsfns.m (unwind_create_frame):
4814 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4815 Vframe_list (Bug#9999).
4816
22a648b4
DA
48172011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4818
0b381c7e 4819 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4820
659afede
KH
48212011-11-11 Kenichi Handa <handa@m17n.org>
4822
4823 * callproc.c (Fcall_process): Set the member dst_multibyte of
4824 process_coding.
4825
9ac0394b
KH
48262011-11-11 Johan Bockgård <bojohan@gnu.org>
4827
4828 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4829 avoid a crash (bug#9496).
4830
2fbdc249
CY
48312011-11-09 Chong Yidong <cyd@gnu.org>
4832
4833 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4834 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4835
ac6b1f81
PE
48362011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4837
4838 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4839
09db192c
PE
48402011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4841
4842 Avoid some portability problems by eschewing 'extern inline' functions.
4843 The trivial performance wins aren't worth the portability hassles; see
4844 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4845 et seq.
4846 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4847 (window_box_width, window_box_left, window_box_left_offset)
4848 (window_box_right, window_box_right_offset): Undo previous change,
4849 by removing the "extern"s.
4850 * intervals.c (adjust_intervals_for_insertion)
4851 (adjust_intervals_for_deletion): Undo previous change,
4852 making these static again.
4853 (offset_intervals, temp_set_point_both, temp_set_point)
4854 (copy_intervals_to_string): No longer inline.
4855 * xdisp.c (window_text_bottom_y, window_box_width)
4856 (window_box_height, window_box_left_offset)
4857 (window_box_right_offset, window_box_left, window_box_right)
4858 (window_box): No longer inline.
4859
105216ed
CY
48602011-11-08 Chong Yidong <cyd@gnu.org>
4861
4862 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4863 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4864 Signal an error if not a live window.
105216ed
CY
4865 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4866 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4867
ae9e237f
JB
48682011-11-07 Juanma Barranquero <lekktu@gmail.com>
4869
4870 * lisp.h (syms_of_abbrev): Remove declaration.
4871 Reported by CHENG Gao <chenggao@royau.me>.
4872
c7aa8333
EZ
48732011-11-07 Eli Zaretskii <eliz@gnu.org>
4874
4875 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4876 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4877 of temacs in GUI mode.
4878
be7f5545
MR
48792011-11-07 Martin Rudalics <rudalics@gmx.at>
4880
4881 * window.h: Declare delete_all_child_windows instead of
4882 delete_all_subwindows.
4883 * window.c (Fwindow_nest, Fset_window_nest)
4884 (Fset_window_new_total, Fset_window_new_normal)
4885 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4886 (delete_all_subwindows): Rename to delete_all_child_windows.
4887 (Fdelete_other_windows_internal, Fset_window_configuration):
4888 Call delete_all_child_windows instead of delete_all_subwindows.
4889 * frame.c (delete_frame): Call delete_all_child_windows instead
4890 of delete_all_subwindows.
4891
ca78dc43
PE
48922011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4893
4894 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4895 This is also needed for porting to any host where GC_MARK_STACK is
4896 not GC_MAKE_GCPROS_NOOPS.
4897 (which_symbols): Use it.
4898
a0241d01
KH
48992011-11-07 Kenichi Handa <handa@m17n.org>
4900
4901 * coding.c (coding_set_destination): Check coding->src_pos only
4902 when coding->src_object is a buffer (bug#9910).
4903
4904 * process.c (send_process): Set the member src_multibyte of coding
4905 to 0 (bug#9911) when sending a unibyte text.
4906
4907 * callproc.c (Fcall_process): Set the member src_multibyte of
4908 process_coding to 0 (bug#9912).
4909
a64bfdfa 49102011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4911
4912 * xmenu.c (cleanup_widget_value_tree): New function.
4913 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4914 calling free_menubar_widget_value_tree directly (Bug#9830).
4915
cb41b32a
PE
49162011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4917
4918 Fix some portability problems with 'inline'.
4919 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4920 (window_box_width, window_box_left, window_box_left_offset)
4921 (window_box_right, window_box_right_offset): Declare extern.
4922 Otherwise, these inline functions do not conform to C99 and
4923 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4924 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4925 * intervals.c (adjust_intervals_for_insertion)
4926 (adjust_intervals_for_deletion): Now extern, because otherwise the
4927 extern inline functions 'offset_intervals' couldn't refer to it.
4928 (static_offset_intervals): Remove.
4929 (offset_intervals): Rewrite using the old contents of
4930 static_offset_intervals. The old version didn't conform to C99
4931 because an extern inline function contained a reference to an
4932 identifier with static linkage.
4933
b7041366
AS
49342011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4935
4936 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4937 GC.
4938
88a37c4d
EZ
49392011-11-06 Eli Zaretskii <eliz@gnu.org>
4940
4941 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4942 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4943 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4944 return Qleft_to_right.
4945
49745b39
CY
49462011-11-06 Chong Yidong <cyd@gnu.org>
4947
4948 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4949 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4950 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4951 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4952 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4953 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4954 (Fwindow_vscroll): Doc fix.
4955 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4956 argument, since it makes no sense to pass a live window and for
4957 consistency with window-child.
4958
1f05cd82
CS
49592011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4960
4961 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4962 support MSVC.
4963
22610910
JR
49642011-11-05 Jason Rumney <jasonr@gnu.org>
4965
4966 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4967 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4968 fonts (Bug#6029).
4969 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4970 bitwise arithmetic preventing use of unicode-sip and non-truetype
4971 opentype fonts.
4972
a06776b2
EZ
49732011-11-05 Eli Zaretskii <eliz@gnu.org>
4974
3ad924ba
EZ
4975 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4976 "emacs"-only part.
4977
a06776b2
EZ
4978 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4979 initialization code to keep similarity to xfns.c after changes
4980 from 2011-11-05.
4981
c9e7db78
JD
49822011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4983
a97f8f3f
JD
4984 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4985 (unwind_create_frame): New function (Bug#9943).
4986 (Fx_create_frame): Restructure code to be more similar to the one in
4987 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4988 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4989 Move terminal->reference_count++ just before making the frame official
4990 (Bug#9943).
4991
4992 * nsterm.m (x_free_frame_resources): New function.
4993 (x_destroy_window): Move code to x_free_frame_resources.
4994
c9e7db78 4995 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4996 (Fx_create_frame, x_create_tip_frame):
4997 Move terminal->reference_count++ just before making the frame
75f1671a 4998 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4999 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5000
a6fc3b5c
EZ
50012011-11-05 Eli Zaretskii <eliz@gnu.org>
5002
5003 Support MSVC build with newer versions of Visual Studio.
5004 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5005 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5006 nt/gmake.defs.
5007
5008 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5009 which are not supported by MSVC.
5010 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5011 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5012 bitfields.
5013 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5014 types in bitfields.
5015 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5016
5017 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5018
58179cce 50192011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5020
5021 Support MSVC build with newer versions of Visual Studio.
5022 * w32.c: Don't include w32api.h for MSVC.
5023 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5024
5025 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5026 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5027 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5028 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5029 e_* cousins.
5030 (alloca) [_MSC_VER]: Define to _alloca.
5031
5032 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5033
5034 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5035
a58c13ed
EZ
50362011-11-04 Eli Zaretskii <eliz@gnu.org>
5037
5038 * xdisp.c (note_mouse_highlight): If either of
5039 previous/next-single-property-change returns nil, treat that as
5040 the beginning or the end of the buffer. (Bug#9955)
5041
fe0b6370
JD
50422011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5043
a58c13ed 5044 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5045 label is not null (Bug#9951).
5046 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5047 may be NULL.
5048
89bd5ee1
EZ
50492011-11-04 Eli Zaretskii <eliz@gnu.org>
5050
5051 * window.c (Fwindow_body_size): Mention in the doc string that the
5052 return value is in frame's canonical units. (Bug#9949)
5053
84c3edb9
EZ
50542011-11-03 Eli Zaretskii <eliz@gnu.org>
5055
4e2fb5c7
EZ
5056 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5057
84c3edb9 5058 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5059 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5060 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5061
bc17a887
EZ
50622011-11-01 Eli Zaretskii <eliz@gnu.org>
5063
5064 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5065 Don't stop backward scan on the continuation glyph, even though
5066 its CHARPOS is positive.
6d5eb5b0
SM
5067 (mouse_face_from_buffer_pos, note_mouse_highlight):
5068 Rename cover_string to disp_string.
bc17a887 5069
4ee88440
MR
50702011-11-01 Martin Rudalics <rudalics@gmx.at>
5071
5072 * window.c (temp_output_buffer_show): Don't use
5073 Vtemp_buffer_show_specifiers.
5074 (Vtemp_buffer_show_specifiers): Remove unused variable.
5075
c2ff3c02
EZ
50762011-10-30 Eli Zaretskii <eliz@gnu.org>
5077
5078 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5079 past the beginning of the current glyph matrix.
5080
58179cce 50812011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5082
5083 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5084 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5085 HAVE_GTK3 (Bug#9869).
b77a6a7f 5086
3b574623
JD
5087 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5088 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5089
b77a6a7f
JD
5090 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5091
5092 * xterm.c: Declare x_handle_net_wm_state to return int.
5093 (handle_one_xevent): Check if we are iconified but don't have
5094 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5095 (get_current_wm_state): Return non-zero if not hidden,
5096 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5097 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5098 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5099 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5100
196e41e4
PE
51012011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5102
5103 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5104 so that this new function doesn't get optimized away by a
5105 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5106
021f2e1a
AS
51072011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5108
5109 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5110
8b058d44
EZ
51112011-10-29 Eli Zaretskii <eliz@gnu.org>
5112
5113 Fix the `xbytecode' command.
5114 * .gdbinit (xprintbytestr): New command.
b50a28de 5115 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5116 (xbytecode): Print the byte-code string as well.
5117
4452fb80
EZ
51182011-10-29 Kim Storm <storm@cua.dk>
5119
8b058d44
EZ
5120 * alloc.c (which_symbols): New function.
5121
21b72067
AS
51222011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5123
5124 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5125 line. (Bug#9903)
5126
83ed7b5c
GM
51272011-10-29 Glenn Morris <rgm@gnu.org>
5128
5129 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5130 Not clear what it was for, and it causes various bugs. (Bug#9839)
5131
5a7a728b
EZ
51322011-10-28 Eli Zaretskii <eliz@gnu.org>
5133
5134 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5135 possible random value that matches one of those tested as
5136 condition to clear the mouse face.
5137
d3d0842f
CY
51382011-10-28 Chong Yidong <cyd@gnu.org>
5139
5140 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5141
31b39d13
DN
51422011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5143
5144 * window.c (make_window): Initialize phys_cursor_on_p.
5145
9aba6043
SM
51462011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5147
5148 * lisp.h (struct Lisp_Symbol): Update comments.
5149
c20992f4
JB
51502011-10-28 Juanma Barranquero <lekktu@gmail.com>
5151
5152 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5153
db4f02f2
EZ
51542011-10-28 Eli Zaretskii <eliz@gnu.org>
5155
5156 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5157 <oslsachem@gmail.com> for helping to debug this.
5158
5159 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5160 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5161 (g_b_init_get_glyph_outline_w): New static variables.
5162 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5163 (GetGlyphOutlineW_Proc): New typedefs.
5164 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5165 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5166 New functions.
5167 (w32font_open_internal, compute_metrics):
5168 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5169 instead of calling the "wide" APIs directly.
5170
5171 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5172
5173 * w32.h (syms_of_w32font): Add prototype.
5174
87e68db4
JB
51752011-10-27 Juanma Barranquero <lekktu@gmail.com>
5176
5177 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5178 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5179 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5180 (Fmove_to_window_line): Doc fix.
5181
435c1d67
CY
51822011-10-27 Chong Yidong <cyd@gnu.org>
5183
5184 * process.c (make_process): Set gnutls_state to NULL.
5185
5186 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5187 non-NULL, regardless of GNUTLS_INITSTAGE.
5188 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5189 an error. Set process slots as soon as we allocate them.
5190
5191 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5192
9c6c6f49
CY
51932011-10-27 Chong Yidong <cyd@gnu.org>
5194
9aba6043
SM
5195 * gnutls.c (emacs_gnutls_deinit): New function.
5196 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5197 (Fgnutls_deinit, Fgnutls_boot): Use it.
5198
5199 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5200 (deactivate_process): Call emacs_gnutls_deinit.
5201
657d08d3
JB
52022011-10-27 Juanma Barranquero <lekktu@gmail.com>
5203
5204 * image.c (x_create_x_image_and_pixmap):
5205 * w32.c (sys_rename, w32_delayed_load):
5206 * w32font.c (fill_in_logfont):
5207 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5208
5430d399
JB
52092011-10-26 Juanma Barranquero <lekktu@gmail.com>
5210
5211 * w32fns.c (w32_default_color_map): New function,
5212 extracted from Fw32_default_color_map.
a7ef684b 5213 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5214
fe0055fa
PE
52152011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5216
5217 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5218
e6346438
SM
52192011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5220
5221 * keyboard.c (test_undefined): New function (bug#9751).
5222 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5223
e112cc37
ET
52242011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5225
5226 * sysdep.c (init_sys_modes): Fix the check for the controlling
5227 terminal (Bug#6649).
5228
7b5d6677
EZ
52292011-10-20 Eli Zaretskii <eliz@gnu.org>
5230
5231 * dispextern.h (struct bidi_it): New member next_en_type.
5232
5233 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5234 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5235 current character, check also for next_en_type being WEAK_EN.
5236 (bidi_resolve_weak): Don't enter the expensive loop if the current
5237 position is before next_en_pos. Record the bidi type of the first
5238 non-ET, non-BN character we find, in addition to its position.
5239 (bidi_level_of_next_char): Invalidate next_en_type when
5240 next_en_pos is over-stepped.
5241
7da0b018
PE
52422011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5243
5244 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5245 * editfns.c: Rewrite current-time-zone so that it invokes
5246 the equivalent of (format-time-string "%Z") to get the time zone name.
5247 This fixes a bug when the time zone name contains characters that
5248 need converting from the system time locale to Emacs internal format.
5249 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5250 that patch fixed format-time-string to do the conversion, but
5251 I forgot to fix current-time-zone.
5252 (format_time_string): New function, containing most of
5253 what Fformat_time_string used to contain.
5254 (Fformat_time_string): Rewrite in terms of format_time_string.
5255 This doesn't change this function's behavior.
5256 (current-time-zone): Rewrite to use format_time_string.
5257 This fixes the bug reported by Michael Schierl in
5258 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5259 Jason Rumney's 2007-06-07 change worked around this bug, but
5260 didn't fix it.
5261 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5262
8547b010
EZ
52632011-10-19 Eli Zaretskii <eliz@gnu.org>
5264
5265 * xdisp.c (start_display): If the character at POS is displayed
5266 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5267 (try_window_reusing_current_matrix): If a line ends in a display
5268 vector or the next line starts in a display vector, continue
5269 redrawing the window even though the character position of
5270 start_row was reached.
8547b010
EZ
5271 (Bug#9771, part 2)
5272
4e948d15
CY
52732011-10-18 Chong Yidong <cyd@gnu.org>
5274
5275 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5276 with nobreak-char-display too.
5277
4787455f
EZ
52782011-10-18 Eli Zaretskii <eliz@gnu.org>
5279
5280 Fix part 3 of bug#9771.
5281 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5282 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5283 non-neutral characters if the current character is a paragraph
5284 separator (a.k.a. Newline). This avoids running the same
5285 expensive loop twice, once when we consume the preceding newline
5286 and the other time when the line actually needs to be displayed.
5287 Avoid the loop when we see neutrals on the base embedding level
5288 following a character whose directionality is the same as the
5289 paragraph's. This avoids running the expensive loop when a line
5290 ends in a long sequence of neutrals, like control characters.
5291 Add assertion against STRONG_AL type. Slightly rearrange code
5292 that determines the type of a neutral given the first non-neutral
5293 that follows it.
5294 (bidi_level_of_next_char): Set next_en_pos to zero when
5295 invalidating its info.
5296
2c91f553
EZ
52972011-10-17 Eli Zaretskii <eliz@gnu.org>
5298
5299 * xdisp.c (push_display_prop): Determine whether to record string
5300 or buffer position by IT->string, not by IT->method. Allow
5301 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5302 (move_it_vertically_backward): Don't look for character position
5303 immediately after the newline when in a continuation line.
5304 (Bug#9771, part 1)
2c91f553 5305
c7b08b0d
MR
53062011-10-15 Martin Rudalics <rudalics@gmx.at>
5307
5308 * window.c (coordinates_in_window): Rewrite and delabelize
5309 vertical border check. (Bug#5357) (Bug#9618)
5310
6b02f655
SM
53112011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5312
5313 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5314 errors in XSetWindowBorder (bug#9310).
5315
81d40c92
DA
53162011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5317
5318 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5319 avoid crash when xmalloc overrun checking is enabled.
5320
d4172c3b
EZ
53212011-10-13 Eli Zaretskii <eliz@gnu.org>
5322
5323 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5324 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5325 cursor motion with <left> and <right> arrow keys.
5326
5327 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5328 some callers set that themselves.
5329
b00eea75
EZ
53302011-10-12 Eli Zaretskii <eliz@gnu.org>
5331
5332 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5333 display string and the previous row comes from the same string and
5334 is empty. (Bug#9739) (Bug#9738)
5335
8fe012c4
SM
53362011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5337
5338 * doc.c (get_doc_string): Encode file name (bug#9735).
5339
0074aef2
EZ
53402011-10-12 Eli Zaretskii <eliz@gnu.org>
5341
79beb178
EZ
5342 * bidi.c (bidi_level_of_next_char):
5343 * xdisp.c (get_visually_first_element): Remove old incorrect
5344 comments regarding the Unicode Line Separator character.
5345
0074aef2
EZ
5346 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5347
6e4b3fbe
DA
53482011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5349
5350 * alloc.c (Fgc_status): Do not access beyond zombies array
5351 boundary if nzombies > MAX_ZOMBIES.
5352 * alloc.c (dump_zombies): Add missing format specifier.
5353
0324f3af
PE
53542011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5355
b5525cac
PE
5356 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5357 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5358
0324f3af
PE
5359 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5360 Some packages use them to denote characters with modifiers.
5361
e9b5f888
AS
53622011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5363
5364 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5365 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5366 matching a pp-number. Rename parameter var to var1.
5367
127827c0
SM
53682011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5369
5370 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5371
c8fd3bd0
GM
53722011-10-08 Glenn Morris <rgm@gnu.org>
5373
5374 * callint.c (Fcall_interactively): Give a more explicit error for the
5375 'c' case with a non-character input. (Bug#8479)
5376
352ec8ff
EZ
53772011-10-08 Eli Zaretskii <eliz@gnu.org>
5378
03669ccb
EZ
5379 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5380 lines.
7061c986
EZ
5381 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5382 lines that are hscrolled on the left.
03669ccb 5383
352ec8ff
EZ
5384 * dispnew.c (buffer_posn_from_coords): Account for a possible
5385 presence of header-line. (Bug#4426)
5386
a66cfb1c
SM
53872011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5388
6b02f655
SM
5389 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5390 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5391
7c5ee88e
PE
53922011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5393
5394 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5395 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5396 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5397 this makes Emacs dump core during garbage collection on rare
5398 occasions. sizeof is obviously inferior to offsetof here, so
5399 stick with offsetof.
5400 (GC_POINTER_ALIGNMENT): New macro.
5401 (mark_memory): Omit 3rd (offset) arg; caller changed.
5402 Don't assume EMACS_INT alignment is the same as pointer alignment.
5403
df1bbe5b
SM
54042011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5405
5406 * keyboard.c (read_key_sequence_remapped): New var.
5407 (read_key_sequence): Compute remapping in the right buffer.
5408 (command_loop_1): Use read_key_sequence's remapping directly.
5409
51553db6
SM
54102011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5411
32c1fffd
SM
5412 * dired.c (file_name_completion): Don't expand file name.
5413 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5414 before checking file name handler.
5415
51553db6
SM
5416 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5417 they've been requested explicitly (bug#9591).
5418
b6bd1599 54192011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5420
5421 * keymap.c (Fsingle_key_description): Use make_specified_string
5422 instead of build_string to build string from push_key_description.
5423 (Bug#5193)
5424
f701dc2a
PE
54252011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5426
4222c55d
PE
5427 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5428 This fixes a Y2038 bug on 64-bit hosts.
5429 * buffer.c (reset_buffer):
5430 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5431 (Fclear_buffer_auto_save_failure):
5432 Use 0, not -1, to represent an unset failure time, since time_t
5433 might not be signed.
5434
f701dc2a
PE
5435 Remove dependency on glibc malloc internals.
5436 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5437 Move back here from lisp.h, but with their new implementations.
5438 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5439 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5440 * charset.c (charset_table_init): New static var.
5441 (syms_of_charset): Use it instead of xmalloc. This removes a
5442 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5443 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5444 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5445 Move back to alloc.c.
5446 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5447 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5448
9ceebf39
JD
54492011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5450
5451 * nsterm.m (windowDidResize): Call x_set_window_size only when
5452 ns_in_resize is true. Otherwise set pixelwidth/height and
5453 call change_frame_size (Bug#9628).
5454
cb993c58
PE
54552011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5456
3930c88b
PE
5457 Port --enable-checking=all to Fedora 14 x86-64.
5458 * charset.c (syms_of_charset): Also account for glibc malloc's
5459 internal overhead when calculating the initial malloc maximum.
5460
cb993c58
PE
5461 Port --enable-checking=all to Fedora 14 x86.
5462 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5463 Move to lisp.h.
5464 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5465 (overrun_check_realloc, overrun_check_free):
5466 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5467 That way, xmalloc returns a properly-aligned pointer even if
5468 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5469 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5470 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5471 into account when calculating the initial malloc maximum.
5472 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5473 Move here from alloc.c, so that charset.c can use it too.
5474 Properly align; the old code wasn't right for common 32-bit hosts
5475 when configured with --enable-checking=all.
5476 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5477 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5478
31bed486
EZ
54792011-09-29 Eli Zaretskii <eliz@gnu.org>
5480
04c70788 5481 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5482 use EDOM.
5483
fbcaa2f3
EZ
54842011-09-28 Eli Zaretskii <eliz@gnu.org>
5485
5486 * xdisp.c (compute_display_string_end): If there's no display
5487 string at CHARPOS, return -1.
5488
5489 * bidi.c (bidi_fetch_char): When compute_display_string_end
5490 returns a negative value, treat the character as a normal
5491 character not covered by a display string. (Bug#9624)
5492
a239d4e9
JB
54932011-09-28 Juanma Barranquero <lekktu@gmail.com>
5494
5495 * lread.c (Fread_from_string): Fix typo in docstring.
5496
88652fd5
EZ
54972011-09-27 Eli Zaretskii <eliz@gnu.org>
5498
5499 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5500 newline, reseat the iterator instead of bidi-iterating there one
5501 character at a time. (Bug#9610)
32c1fffd
SM
5502 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5503 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5504
ed497dd4
AS
55052011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5506
5507 * lread.c (readevalloop): Use correct code for NBSP.
5508 (read1): Likewise. (Bug#9608)
5509
b2bf61aa
MA
55102011-09-25 Michael Albinus <michael.albinus@gmx.de>
5511
5512 * dbusbind.c (Fdbus_register_signal): When service is not
5513 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5514
32bbb17c
GM
55152011-09-25 Glenn Morris <rgm@gnu.org>
5516
5517 * buffer.c (truncate-lines): Doc fix.
5518
94e0933e
CY
55192011-09-24 Chong Yidong <cyd@stupidchicken.com>
5520
5521 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5522 (Fset_window_next_buffers): Doc fix.
5523
cddde921
GM
55242011-09-24 Glenn Morris <rgm@gnu.org>
5525
5526 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5527
1260aef1
PE
55282011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5529
25b4bfa0
PE
5530 Fix minor problems found by static checking.
5531 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5532 * indent.c (Fvertical_motion): Fix == vs = typo.
5533
e3cbd34b
EZ
55342011-09-24 Eli Zaretskii <eliz@gnu.org>
5535
a66cfb1c
SM
5536 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5537 Default value is now t. Doc fix.
6bf7006f 5538
e3cbd34b 5539 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5540 logic when moving up, not only when moving down. Fix the
e3cbd34b 5541 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5542 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5543
5544 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5545 CHARPOS is covered by a display string which includes newlines.
5546 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5547 is covered by a display string with embedded newlines.
5548
a3de0cbd
MA
55492011-09-24 Michael Albinus <michael.albinus@gmx.de>
5550
5551 * dbusbind.c (Fdbus_register_signal): Add match rule to
5552 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5553 (Fdbus_register_method, Vdbus_registered_objects_table):
5554 Fix docstring.
a3de0cbd 5555
b260039d
JM
55562011-09-24 Jim Meyering <meyering@redhat.com>
5557
32c1fffd 5558 do not ignore write error for any output size
b260039d
JM
5559 The previous change was incomplete.
5560 While it makes emacs --batch detect the vast majority of stdout
5561 write failures, errors were still ignored whenever the output size is
5562 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5563 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5564 && echo FAIL: ignored write error
5565 FAIL: ignored write error
5566 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5567 && echo FAIL: ignored write error
5568 FAIL: ignored write error
5569 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5570
8eca8a7c
AS
55712011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5572
5573 * emacs.c (Fkill_emacs): In noninteractive mode exit
5574 non-successfully if a write error occurred on stdout. (Bug#9574)
5575
3341db62
EZ
55762011-09-21 Eli Zaretskii <eliz@gnu.org>
5577
5578 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5579 the xassert test.
5580
5581 * dispextern.h (struct it): Update the comment documenting what
5582 can it->OBJECT be.
5583
8c203dbf
EZ
55842011-09-20 Eli Zaretskii <eliz@gnu.org>
5585
5586 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5587 a display string, extend search for cursor position to end of row.
5588 (find_row_edges): If the row ends in a newline from a display
5589 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5590 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5591 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5592 non-empty line. Fixes confusing cursor motion with arrow keys at
5593 the beginning of a line that starts with whitespace.
8c203dbf 5594
a4824228
LMI
55952011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5596
5597 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5598 (bug#9493).
5599
33ed493b
CY
56002011-09-18 Chong Yidong <cyd@stupidchicken.com>
5601
5602 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5603 boolean (Bug#9154).
5604
56cd55c8
EZ
56052011-09-18 Eli Zaretskii <eliz@gnu.org>
5606
5607 * xdisp.c (display_line): Record maximum and minimum buffer
5608 positions even if no glyphs were produced (e.g., by a zero-width
5609 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5610 buffer positions that will be removed from the glyph row because
5611 they don't fit.
c02dcedf
EZ
5612 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5613 column is beyond frame width: don't subtract 1 "pixel" when
5614 computing width of the stretch.
3e62b7e0
EZ
5615 (reseat_at_next_visible_line_start): Undo the change made on
5616 2011-09-17 that saved paragraph information and restored it after
5617 the call to `reseat'. (Bug#9545)
56cd55c8 5618
5ed99d36 56192011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5620
5621 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5622 and turn window cursor on if cleared (Bug#9415).
5623
5ed99d36 56242011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5625
5626 * search.c (boyer_moore): Take unibyte characters from pattern
5627 literally. (Bug#9458)
5628
9bade7b2
EZ
56292011-09-18 Eli Zaretskii <eliz@gnu.org>
5630
5631 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5632
e5e9d610
PE
56332011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5634
87e4427a
PE
5635 Fix minor problem found by static checking.
5636 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5637 initialized, to pacify gcc -Wuninitialized.
5638
e5e9d610
PE
5639 * fileio.c: Report proper errno when syscall falls.
5640 (Finsert_file_contents): Save and restore errno,
5641 so that report_file_error outputs the correct diagnostic.
5642 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5643
a1674f0b
EZ
56442011-09-18 Eli Zaretskii <eliz@gnu.org>
5645
5646 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5647
fbfb6dd4
EZ
56482011-09-17 Eli Zaretskii <eliz@gnu.org>
5649
5650 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5651 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5652
bb187662
EZ
56532011-09-17 Eli Zaretskii <eliz@gnu.org>
5654
1137e8b8 5655 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5656 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5657
5658 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5659 (bidi_find_paragraph_start): Search back for paragraph beginning
5660 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5661 (bidi_move_to_visually_next): Only trigger paragraph-related
5662 computations when the last character is a newline or at EOB, not
5663 just any NEUTRAL_B. (Bug#9470)
5664
bb187662
EZ
5665 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5666 truncated lines if point is covered by a display string. (Bug#9524)
5667
2e621251
PE
56682011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5669
5670 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5671 (cons_to_x_long): New function.
5672 (lisp_data_to_selection_data): Use it. Correct the test for
5673 short-versus-long data; it was negated. Break out of vector
5674 loop, for efficiency, when a long datum is discovered.
5675
91a15bc6
SM
56762011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5677
5678 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5679
b41c3a35
EZ
56802011-09-16 Eli Zaretskii <eliz@gnu.org>
5681
5682 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5683 GCC PR/17406) by declaring this function with external scope.
5684
7812ba2d
PE
56852011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5686
5687 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5688 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5689
cf7edc2a
AS
56902011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5691
5692 * editfns.c (Fformat): Correctly handle text properties on "%%".
5693
bd01620e
EZ
56942011-09-15 Eli Zaretskii <eliz@gnu.org>
5695
5696 * xterm.c (x_draw_composite_glyph_string_foreground):
5697 * w32term.c (x_draw_composite_glyph_string_foreground):
5698 * term.c (encode_terminal_code):
5699 * composite.c (composition_update_it, get_composition_id):
5700 * xdisp.c (get_next_display_element)
5701 (fill_composite_glyph_string): Add comments about special meaning
5702 of TAB characters in a composition.
5703
a02719a3
PE
57042011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5705
5706 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5707 This occurs when processing a multibyte format.
5708 Problem reported by Wolfgang Jenker.
a02719a3 5709
72589a3c
JB
57102011-09-15 Johan Bockgård <bojohan@gnu.org>
5711
5712 * xdisp.c (try_cursor_movement): Only check for exact match if
5713 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5714
1c14176c
PE
57152011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5716
5717 Remove unused external symbols.
5718 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5719 * xdisp.c (calc_pixel_width_or_height): Now static.
5720 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5721 * indent.c (check_display_width):
5722 * w32term.c: Fix comment to match code.
5723 * xterm.c, xterm.h (x_catching_errors): Remove.
5724
d2eea5b5
PE
57252011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5726
5727 * xselect.c: Use signed conversions more consistently (Bug#9498).
5728 (selection_data_to_lisp_data): Assume incoming selection data are
5729 signed integers, not unsigned. This is to be consistent with
5730 outgoing selection data, which was modified to use signed integers
5731 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5732 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5733 expects long, not unsigned long.
5734
46888499
EZ
57352011-09-14 Eli Zaretskii <eliz@gnu.org>
5736
5737 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5738 computation of loop end. Reported by Johan Bockgård
5739 <bojohan@gnu.org>.
5740
ef8ef9fb
CY
57412011-09-13 Chong Yidong <cyd@stupidchicken.com>
5742
5743 * frame.c (Fother_visible_frames_p): Function deleted.
5744
fa819fed
EZ
57452011-09-12 Eli Zaretskii <eliz@gnu.org>
5746
5747 * indent.c (compute_motion): Process display vector front to back
5748 rather than the other way around. (Bug#2496)
5749
2ba8e008
SM
57502011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5751
5752 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5753
20f53c69
CY
57542011-09-11 Chong Yidong <cyd@stupidchicken.com>
5755
5756 * minibuf.c (Fread_from_minibuffer): Doc fix.
5757
d562d7a4
EZ
57582011-09-11 Eli Zaretskii <eliz@gnu.org>
5759
5760 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5761 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5762
1c4d7f3d
LMI
57632011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5764
5765 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5766 value for non-existent files.
5767
b885bf36
EZ
57682011-09-11 Eli Zaretskii <eliz@gnu.org>
5769
5770 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5771 set its "size" to -1. This will set the modtime_size field of
5772 the corresponding buffer to -1, which is what
5773 verify-visited-file-modtime expects for files that do not exist.
5774 (Bug#9139)
5775
6612f0bf
PE
57762011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5777
5778 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5779 here ...
5780 * lisp.h: ... from here. push_key_description is no longer
5781 defined in keyboard.c, so its declaration should not be in
5782 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5783 logically belongs with push_key_description.
5784
dfb3f755
PE
57852011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5786
5787 * buffer.h: Include <sys/types.h> instead of <time.h>.
5788 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5789 Problem reported by Herbert J. Skuhra.
5790
3134906c
LMI
57912011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5792
5793 * xml.c (parse_region): Make the parsing work for
5794 non-comment-starting XML files again (bug#9144).
5795
8d903f4e
AS
57962011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5797
5798 * image.c (gif_load): Fix calculation of bottom and right corner.
5799 (Bug#9468)
5800
80ad64f4
EZ
58012011-09-10 Eli Zaretskii <eliz@gnu.org>
5802
5803 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5804 redisplay in small windows.
5805
208a048d
EZ
58062011-09-09 Eli Zaretskii <eliz@gnu.org>
5807
5808 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5809
9b1c252e
MR
58102011-09-08 Martin Rudalics <rudalics@gmx.at>
5811
5812 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5813 Operate on live windows only.
5814
2949f33b
JB
58152011-09-08 Juanma Barranquero <lekktu@gmail.com>
5816
5817 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5818
e08dcafd
EZ
58192011-09-07 Eli Zaretskii <eliz@gnu.org>
5820
5821 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5822 only under bidi iteration.
5823
115b96bd
JD
58242011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5825
5826 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5827
c8199d0f
PE
58282011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5829
5830 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5831 Without this fix, the command to link temacs failed due to an
5832 undefined symbol __builtin_isnan. This is because
5833 /usr/include/iso/math_c99.h #defines isnan(x) to
5834 __builtin_isnan(x), but the bundled gcc, which identifies itself
5835 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5836 a __builtin_isnan.
5837 * floatfns.c (isnan): #undef, and then #define to a clone of
5838 what's in data.c.
5839 (Fisnan): Always define, since it's always available now.
5840 (syms_of_floatfns): Always define isnan at the Lisp level.
5841
e39b275c 58422011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5843
5844 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5845
b2db44d9 58462011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5847
f4af5137 5848 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5849 The previous code assumed that file offsets (off_t values) fit in
5850 EMACS_INT variables, which is not true on typical 32-bit hosts.
5851 The code messed up by falsely reporting buffer overflow in cases
5852 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5853 when "big" contains more than 2**29 bytes, even though this
5854 inserts just one byte and does not overflow the buffer.
5855 (Finsert_file_contents): Store file offsets as off_t
5856 values, not as EMACS_INT values. Check for overflow when
5857 converting between EMACS_INT and off_t. When checking for
5858 buffer overflow or for overlap, take the offsets into account.
5859 Don't use EMACS_INT for small values where int suffices.
5860 When checking for overlap, fix a typo: ZV was used where
5861 ZV_BYTE was intended.
5862 (Fwrite_region): Don't assume off_t fits into 'long'.
5863 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5864
ecfc0a49
MA
58652011-09-05 Michael Albinus <michael.albinus@gmx.de>
5866
5867 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5868
6511acf2 58692011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5870
0999621a 5871 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5872
5873 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5874 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5875 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5876 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5877 (modify_event_symbol): Do not assume that the length of
5878 name_alist_or_stem is safe to alloca and fits in int.
5879 (Fexecute_extended_command): Likewise for function name and binding.
5880 (Frecursion_depth): Wrap around reliably on integer overflow.
5881 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5882 since some callers pass EMACS_INT values.
5883 (Fsingle_key_description): Don't crash if symbol name contains more
5884 than MAX_ALLOCA bytes.
5885 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5886 (get_minibuffer): Arg is now EMACS_INT, not int.
5887 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5888 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5889 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5890
2be7d702
PE
5891 * dbusbind.c (signature_cat): New function.
5892 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5893 Do not overrun buffer; instead, report string overflow.
5894
9d1df220
PE
5895 * dispnew.c (add_window_display_history): Don't overrun buffer.
5896 Truncate instead; this is OK since it's just a log.
5897
33ef5c64
PE
5898 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5899 even if the time zone offset is outlandishly large.
5900 Don't mishandle offset == INT_MIN.
5901
66c6fdd5
PE
5902 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5903 when creating daemon; the previous buffer-overflow check was incorrect.
5904
d749b01b
PE
5905 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5906 which has the guts of the old verror function.
5907
b5cd1905
PE
5908 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5909 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5910
6e1a67fb
PE
5911 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5912 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5913 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5914 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5915 length of string rather than counting it via multiple sprintfs;
5916 that's simpler and more reliable.
c21721cc
PE
5917 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5918 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5919 sprintf, in case result does not fit in int.
5920
c57b67fc
PE
5921 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5922 (fontset_from_font): Print it.
5923
8a401434
PE
5924 * frame.c (tty_frame_count): Now printmax_t, not int.
5925 (make_terminal_frame, set_term_frame_name): Print it.
5926 (x_report_frame_params): In X, window IDs are unsigned long,
5927 not signed long, so print them as unsigned.
5928 (validate_x_resource_name): Check for implausibly long names,
5929 and don't assume name length fits in 'int'.
5930 (x_get_resource_string): Don't blindly alloca invocation name;
5931 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5932 not fit in int.
5933
6e1a67fb
PE
5934 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5935 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5936 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5937
0df02bf3
PE
5938 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5939 Use esprintf, not sprintf, in case result does not fit in int.
5940
48e30793
PE
5941 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5942 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5943 it as a large positive number.
5944 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5945 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5946
a66ff6d8
PE
5947 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5948 in case result does not fit in int.
5949
aca216ff
PE
5950 * print.c (float_to_string): Detect width overflow more reliably.
5951 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5952 buffer overrun. Don't assume list length fits in 'int'. Treat
5953 print length of 0 as 0, not as infinity; to be consistent with other
5954 uses of print length in this function. Don't overflow print length
5955 index. Don't assume hash table size fits in 'long', or that
5956 vectorlike size fits in 'unsigned long'.
5957
31c286f7
PE
5958 * process.c (make_process): Use printmax_t, not int, to format
5959 process-name gensyms.
5960
55e5faa1
PE
5961 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5962
80f2e268
PE
5963 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5964 to avoid potential buffer overrun.
5965
670741ab
PE
5966 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5967 if X resource line is longer than 512 bytes.
5968
b7163a50
PE
5969 * xfns.c (x_window): Make sprintf buffer a bit bigger
5970 to avoid potential buffer overrun.
5971
ae58ff1f
PE
5972 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5973
c43c8a6a
PE
5974 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5975
3f8236f4
PE
59762011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5977
53e9fe90 5978 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5979 Without these, Emacs silently mishandles large integers sometimes.
5980 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5981 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5982
6511acf2
PE
5983 * xdisp.c (try_window_id): Check Emacs fixnum range before
5984 converting to 'int'.
806add1d 5985
6511acf2 5986 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5987 Check that an Emacs fixnum is in range before assigning it to 'int'.
5988 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5989 values converted from Emacs fixnums.
5990 (Frecenter): Don't wrap around a line count if it is out of 'int'
5991 range; instead, treat it as an extreme value.
5992 (Fset_window_configuration, compare_window_configurations):
5993 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5994
6511acf2
PE
5995 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5996 that can exceed INT_MAX. Check that EMACS_INT value is in range
5997 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5998 (match_limit): Don't assume that a fixnum can fit in 'int'.
5999
6511acf2 6000 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6001 exceed INT_MAX.
6002
6511acf2 6003 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6004 (Fvertical_motion): Don't wrap around LINES values that don't fit
6005 in 'int'. Instead, treat them as extreme values. This is good
6006 enough for windows, which can't have more than INT_MAX lines anyway.
6007
fcb901a7
LMI
60082011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6009
0f2f6b6d
LMI
6010 * Require libxml/parser.h to avoid compilation warning.
6011
fcb901a7
LMI
6012 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6013
6014 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6015 since this reportedly can destroy thread storage.
6016
6e20a0d4
CY
60172011-08-30 Chong Yidong <cyd@stupidchicken.com>
6018
6019 * syntax.c (find_defun_start): Update all cache variables if
6020 exiting early (Bug#9401).
6021
148ae00e
EZ
60222011-08-30 Eli Zaretskii <eliz@gnu.org>
6023
f6cfbd8f
EZ
6024 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6025
148ae00e
EZ
6026 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6027 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6028 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6029
6030 * term.c (tty_append_glyph): New function.
6031 (produce_stretch_glyph): Static function and its prototype deleted.
6032
a66cfb1c
SM
6033 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6034 Add prototypes.
148ae00e 6035
c4a07a4c
PE
60362011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6037
6038 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6039 when checking :margin (Bug#9390).
6040 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6041 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6042 so that the name doesn't mislead. All uses changed.
6043
6bc8cd65
JB
60442011-08-28 Johan Bockgård <bojohan@gnu.org>
6045
6046 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6047 set_tty_hooks.
6048
dca4927e
EZ
60492011-08-27 Eli Zaretskii <eliz@gnu.org>
6050
6051 * xdisp.c (move_it_to): Don't bail out early when reaching
6052 position beyond to_charpos, if we are scanning backwards.
6053 (move_it_vertically_backward): When DY == 0, make sure we get to
6054 the first character in the line after the newline.
6055
f2cad773
PE
60562011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6057
6058 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6059 (ccl_driver): Do not generate an out-of-range pointer.
6060 (Fccl_execute_on_string): Remove unnecessary check for
6061 integer overflow, noted by Stefan Monnier in
6062 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6063 Remove a FIXME that didn't need fixing.
6064 Simplify the newly-introduced buffer reallocation code.
6065
0cae2cdb
JB
60662011-08-27 Juanma Barranquero <lekktu@gmail.com>
6067
6068 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6069
5fc295a4 60702011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6071
70c60eb2 6072 Integer and memory overflow issues (Bug#9196).
726e0ab1 6073
d31850da
PE
6074 * doc.c (get_doc_string): Rework so that
6075 get_doc_string_buffer_size is the actual buffer size, rather than
6076 being 1 less than the actual buffer size; this makes xpalloc more
6077 convenient.
6078
a69fbedb
PE
6079 * image.c (x_allocate_bitmap_record, cache_image):
6080 * xselect.c (Fx_register_dnd_atom):
6081 Simplify previous changes by using xpalloc.
6082
fe5c5d37
PE
6083 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6084 since either will do and ptrdiff_t is convenient with xpalloc.
6085
0065d054
PE
6086 * charset.c (charset_table_size)
6087 (struct charset_sort_data.priority): Now ptrdiff_t.
6088 (charset_compare): Don't overflow if priorities differ greatly.
6089 (Fsort_charsets): Don't assume list length fits in int.
6090 Check for size-calculation overflow when allocating sort data.
6091 (syms_of_charset): Allocate an initial charset table that is
6092 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6093
6094 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6095
6096 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6097 The actual value is always <= INT_MAX, and leaving it unsigned made
6098 overflow checking harder.
6099
6100 * dispextern.h (struct glyph_matrix.rows_allocated)
6101 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6102 with xpalloc. The values are still always <= INT_MAX.
6103
6104 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6105
6106 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6107 (SAFE_NALLOCA): New macro.
6108
6109 * region-cache.c (struct boundary.pos, find_cache_boundary)
6110 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6111 (set_cache_region, invalidate_region_cache)
6112 (revalidate_region_cache, know_region_cache, region_cache_forward)
6113 (region_cache_backward, pp_cache):
6114 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6115 so that ptrdiff_t * can be passed to xpalloc.
6116 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6117 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6118 (pp_cache): Don't assume cache_len fits in int.
6119 * region-cache.h: Adjust extern decls to match.
6120
6121 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6122 EMACS_INT, since either will do, for xpalloc.
6123
6124 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6125 (xnmalloc, xnrealloc, xpalloc): New functions.
6126
726e0ab1
PE
6127 * bidi.c (bidi_shelve_header_size): New constant.
6128 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6129 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6130
51f30bc5 6131 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6132 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6133 (overlay_strings):
6134 Don't update size of array until after memory allocation succeeds,
6135 because xmalloc/xrealloc may not return.
0065d054
PE
6136 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6137 now that we have proper integer overflow checking.
6138 (record_overlay_string, overlay_strings): Catch overflows when
6139 calculating size of overlay_str_buf.
726e0ab1 6140
0065d054
PE
6141 * callproc.c (Fcall_process): Check for size overflow when
6142 calculating size of args2.
6143 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6144 Normally we prefer signed values, but sticking with ptrdiff_t would
6145 require adding more-complicated checks.
726e0ab1
PE
6146
6147 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6148 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6149 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6150 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6151
6152 * character.c (Fstring): Check for size-calculation overflow.
6153
6154 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6155 unnecessary integer overflow. Check for size overflow.
6156 (encode_coding_object): Don't update size until xmalloc succeeds.
6157
6158 * composite.c (get_composition_id): Check for overflow in glyph
6159 length calculations.
6160
6161 Integer and memory overflow fixes for display code.
6162 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6163 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6164 (scrolling_window): Check for overflow in size calculations.
6165 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6166 Don't assume glyph table len fits in int.
6167 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6168 (row_table_size): Now ptrdiff_t, not int.
6169 (scrolling_window): Avoid overflow in size calculations.
6170 Don't update size until allocation succeeds.
6171 * fns.c (concat): Check for overflow in size calculations.
6172 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6173 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6174 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6175
6176 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6177 (get_doc_string): Check for size calculation overflow.
6178 Don't update size until allocation succeeds.
6179 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6180 EMACS_INT, where ptrdiff_t will do.
6181 (Fsubstitute_command_keys): Check for string overflow.
6182
6183 * editfns.c (set_time_zone_rule): Don't assume environment length
6184 fits in int.
6185 (message_length): Now ptrdiff_t, not int.
6186 (Fmessage_box): Don't update size until allocation succeeds.
6187 Don't assume message length fits in int.
6188 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6189
0065d054
PE
6190 * emacs.c (main): Do not reallocate argv, since there is a null at
6191 the end that can be overwritten, and this way there's no need to
6192 worry about size-calculation overflow.
6193 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6194
6195 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6196 alloc succeeds.
6197 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6198
6199 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6200 (x_set_scroll_bar_width, x_figure_window_size):
6201 Check for integer overflow.
6202 (x_set_alpha): Do not assume XINT fits in int.
6203
6204 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6205 This is for the members text_lines, text_cols, total_lines, total_cols,
6206 where the system imposes an 'int' limit.
6207
6208 * fringe.c (Fdefine_fringe_bitmap):
6209 Don't update size until alloc works.
6210
6211 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6212 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6213
6214 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6215 Check for size-calculation overflow.
6216 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6217 do, as we prefer signed integers.
6218 (id_to_widget.max_size, id_to_widget.used)
6219 (xg_store_widget_in_map, xg_remove_widget_from_map)
6220 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6221 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6222 Use and return ptrdiff_t, not int.
6223 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6224 * gtkutil.h: Change prototypes to match the above.
6225
6226 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6227 are duplicate now that they've been promoted to lisp.h.
6228 (x_allocate_bitmap_record, x_alloc_image_color)
6229 (make_image_cache, cache_image, xpm_load):
6230 Don't update size until alloc is done.
6231 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6232 (x_detect_edges):
3256efce 6233 Check for size calculation overflow.
726e0ab1
PE
6234 (ct_colors_allocated_max): New constant.
6235 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6236 overflow.
3256efce 6237
726e0ab1
PE
6238 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6239 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6240 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6241 Use ptrdiff_t, not int, to count maps.
6242 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6243 calculations. Don't update size until allocation succeeds.
6244 Redo calculations to avoid overflow.
726e0ab1
PE
6245 * keyboard.h: Change prototypes to match the above.
6246
6247 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6248 to count maps.
6249 (current_minor_maps): Check for size calculation overflow.
6250 * keymap.h: Change prototypes to match the above.
6251
6252 * lread.c (read1, init_obarray): Don't update size until alloc done.
6253
6254 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6255 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6256
726e0ab1
PE
6257 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6258 Now ptrdiff_t, not int.
6259 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6260 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6261
6262 * process.c (Fnetwork_interface_list): Check for overflow
6263 in size calculation.
6264
6265 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6266
6267 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6268 overflow. Don't bother calling xmalloc when xrealloc will do.
6269
6270 * search.c (Freplace_match): Check for size calculation overflow.
6271 (Fset_match_data): Don't assume list lengths fit in 'int'.
6272
6273 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6274 for command line length. Do not attempt to address one before the
6275 beginning of an array, as that's not portable.
6276
6277 * term.c (max_frame_lines): Remove; unused.
6278 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6279 not int.
6280 (encode_terminal_code, calculate_costs): Check for size
6281 calculation overflow.
6282 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6283 table lengths and related sizes. Don't update size until alloc
6284 done. Redo calculations to avoid overflow.
6285 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6286
6287 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6288 subtracting pointers.
6289 (gobble_line): Check for overflow more carefully. Don't update size
6290 until alloc done.
6291
6292 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6293 Don't update size until alloc done.
6294 Redo size calculations to avoid overflow.
6295 Check for size calculation overflow.
0065d054 6296 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6297
6298 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6299 Use ptrdiff_t, not int, for sizes.
6300 (store_mode_line_noprop_char): Don't update size until alloc done.
6301
0065d054
PE
6302 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6303 Use ptrdiff_t, not int, for sizes.
6304 (Finternal_make_lisp_face, cache_face):
6305 Check for size calculation overflow.
6306 (cache_face): Treat size calculation overflows as if they were
6307 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6308
6309 * xfns.c (x_encode_text, x_set_name_internal)
6310 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6311 sizes, since they can exceed INT_MAX in size. Check for size
6312 calculation overflow.
6313
0065d054
PE
6314 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6315 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6316 Don't update size until alloc done.
6317
0065d054 6318 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6319 as sprintf is limited to int lengths.
1d526e2f 6320
252c5ee1
PE
6321 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6322 (X_LONG_MIN): New macros.
864d7ce7
PE
6323 Use them to make the following changes clearer.
6324 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6325 This change doesn't affect the value now, but it may help remind
6326 future maintainers not to raise the value too much later.
6327 (SELECTION_QUANTUM): Remove, replacing with ...
6328 (selection_quantum): ... new function, which avoids overflow.
6329 All uses changed.
6330 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6331 assumption that selection length fits in 'int'.
6332 (x_reply_selection_request, x_handle_selection_request)
6333 (x_get_window_property, receive_incremental_selection)
6334 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6335 (lisp_data_to_selection_data, clean_local_selection_data):
6336 Use ptrdiff_t, not int, to record length of selection.
6337 (x_reply_selection_request, x_get_window_property)
6338 (receive_incremental_selection, x_property_data_to_lisp):
6339 Redo calculations to avoid overflow.
6340 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6341 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6342 something.
6343 (x_get_window_property, receive_incremental_selection)
6344 (lisp_data_to_selection_data, x_property_data_to_lisp):
6345 Check for size-calculation overflow.
6346 (x_get_window_property, receive_incremental_selection)
6347 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6348 Don't store size until memory allocation succeeds.
6349 (x_get_window_property): Plug memory leak on memory exhaustion.
6350 Don't double-block input; malloc is safe here. Don't assume 2**34
6351 - 4 fits in unsigned long. Add an xassert to check
6352 XGetWindowProperty overflow. Be more careful about overflow
6353 calculations, and distinguish size from memory overflow better.
6354 (receive_incremental_selection): When tracing, don't assume
6355 unsigned int is less than INT_MAX.
6356 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6357 harmful) conversions of unsigned short to int.
6358 (lisp_data_to_selection_data): Don't assume that integers
6359 in the range -65535 through -1 fit in an X unsigned short.
6360 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6361 result parameters unless successful. Rely on cons_to_unsigned
6362 to report problems with elements; the old code wasn't right anyway.
6363 (x_check_property_data): Check for int overflow; we cannot use
6364 a wider type due to X limits.
6365 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6366
726e0ab1 6367 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6368
0065d054
PE
6369 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6370 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6371 (x_color_cells): Don't store size until memory allocation succeeds.
6372 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6373 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6374 (x_term_init): Don't assume length fits in int (sprintf is limited
6375 to int size).
bc18e09d 6376
ebfa62c0
PE
6377 Use ptrdiff_t for composition IDs.
6378 * character.c (lisp_string_width):
6379 * composite.c (composition_table_size, n_compositions)
6380 (get_composition_id, composition_gstring_from_id):
6381 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6382 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6383 * window.c (Frecenter):
6384 Use ptrdiff_t, not int, for composition IDs.
6385 * composite.c (get_composition_id): Check for integer overflow.
6386 * composite.h: Adjust prototypes to match the above changes.
6387
d3411f89
PE
6388 Use ptrdiff_t for hash table indexes.
6389 * category.c (hash_get_category_set):
6390 * ccl.c (ccl_driver):
6391 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6392 * coding.c (coding_system_charset_list, detect_coding_system):
6393 * coding.h (struct coding_system.id):
6394 * composite.c (get_composition_id, gstring_lookup_cache):
6395 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6396 * image.c (xpm_get_color_table_h):
6397 * lisp.h (hash_lookup, hash_put):
6398 * minibuf.c (Ftest_completion):
6399 Use ptrdiff_t for hash table indexes, not int (which is too
6400 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6401 32-bit --with-wide-int hosts).
6402
e097a6fa
PE
6403 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6404 Add a FIXME comment about memory leaks.
6405 (syms_of_charset): Don't assume xmalloc returns.
6406
5637687f
PE
6407 Don't assume that stated character widths fit in int.
6408 * character.c (Fchar_width, c_string_width, lisp_string_width):
6409 * character.h (CHAR_WIDTH):
6410 * indent.c (MULTIBYTE_BYTES_WIDTH):
6411 Use sanitize_char_width to avoid undefined and/or bad behavior
6412 with outlandish widths.
a66cfb1c 6413 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6414 now that we have two such functions. All uses changed.
6415 (sanitize_char_width): New inline function.
6416
a2271ba2
PE
6417 Don't assume that tab-width fits in int.
6418 * character.h (sanitize_width): New inline function.
6419 (SANE_TAB_WIDTH): New macro.
6420 (ASCII_CHAR_WIDTH): Use it.
6421 * indent.c (sane_tab_width): Remove. All uses replaced by
6422 SANE_TAB_WIDTH (current_buffer).
6423 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6424
18c52557
PE
6425 * fileio.c: Integer overflow issues with file modes.
6426 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6427
caeeedc1
PE
6428 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6429 Remove unreachable code.
6430 (read_hex, load_charset_map_from_file): Check for integer overflow.
6431
6df6ae42 6432 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6433 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6434 (x_send_scroll_bar_event): Likewise. Check that the size does not
6435 exceed limits imposed by XClientMessageEvent, as well as the usual
6436 ptrdiff_t and size_t limits.
6437
b13995db
PE
6438 * keyboard.c: Overflow, signedness and related fixes.
6439 (make_lispy_movement): Use same integer type in forward decl
6440 that is used in the definition.
6441 (read_key_sequence, keyremap_step):
6442 Change bufsize argument back to int, undoing my 2011-03-30 change.
6443 We prefer signed types, and int is wide enough here.
6444 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6445 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6446 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6447 length, not size_t. Use ptrdiff_t for index, not int.
6448 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6449 possibility of integer overflow.
6450
13464394
PE
6451 Overflow, signedness and related fixes for images.
6452
6453 * dispextern.h (struct it.stack[0].u.image.image_id)
6454 (struct_it.image_id, struct image.id, struct image_cache.size)
6455 (struct image_cache.used, struct image_cache.ref_count):
6456 * gtkutil.c (update_frame_tool_bar):
6457 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6458 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6459 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6460 * nsmenu.m (update_frame_tool_bar):
6461 * xdisp.c (calc_pixel_width_or_height):
6462 * xfns.c (image_cache_refcount):
6463 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6464 on typical 64-bit hosts.
6465
6466 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6467 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6468 Omit unnecessary casts to int.
6469 (parse_image_spec): Check that integers fall into 'int' range
6470 when the callers expect that.
6471 (image_ascent): Redo ascent calculation to avoid int overflow.
6472 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6473 (lookup_image): Remove unnecessary tests.
6474 (xbm_image_p): Locals are now of int, not EMACS_INT,
6475 since parse_image_check makes sure they fit into int.
6476 (png_load, gif_load, svg_load_image):
6477 Prefer int to unsigned where either will do.
6478 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6479 old tiff_error_handler and tiff_warning_handler.
6480 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6481 stack buffer overflows. It uses only the features of vsnprintf
6482 that are common to both POSIX and native Microsoft.
6483 (tiff_error_handler, tiff_warning_handler): Use it.
6484 (tiff_load, gif_load, imagemagick_load_image):
6485 Don't assume :index value fits in 'int'.
6486 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6487 (imagemagick_load_image): Check that crop parameters fit into
6488 the integer types that MagickCropImage accepts. Don't assume
6489 Vimagemagick_render_type has a nonnegative value. Don't assume
6490 size_t fits in 'long'.
6491 (gs_load): Use printmax_t to print the widest integers possible.
6492 Check for integer overflow when computing image height and width.
6493
c11821d4
EZ
64942011-08-26 Eli Zaretskii <eliz@gnu.org>
6495
6496 * xdisp.c (redisplay_window): Don't force window start if point
6497 will be invisible in the resulting window. (Bug#9324)
6498
0c95fcf7
EZ
64992011-08-25 Eli Zaretskii <eliz@gnu.org>
6500
6501 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6502 the display spec is of the form `(space ...)'.
6503 (handle_display_spec): Return the value returned by
6504 handle_single_display_spec, not just 1 or zero.
6505 (handle_single_display_spec): If the display spec is of the form
6506 `(space ...)', and specifies display in the text area, return 2
6507 rather than 1.
fee65a97 6508 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6509 accurately, and prefer exact match for point under bidi.
6510 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6511
6512 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6513 into disp_prop; all users changed.
6514
6515 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6516 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6517 for the text covered by the display property.
6518
e4ed06f1
CY
65192011-08-25 Chong Yidong <cyd@stupidchicken.com>
6520
6521 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6522 Change return value to nil.
6523 (Frecord_buffer): Delete unused function.
6524
f67cdd7f
EZ
65252011-08-24 Eli Zaretskii <eliz@gnu.org>
6526
5980d4c6
EZ
6527 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6528 buffers, return left-to-right.
8610fe8b
EZ
6529 (set_cursor_from_row): Consider candidate row a win if its glyph
6530 represents a newline and point is on that newline. Fixes cursor
6531 positioning on the newline at EOL of R2L text within L2R
6532 paragraph, and vice versa.
6533 (try_cursor_movement): Check continued rows, in addition to
6534 continuation rows. Fixes unwarranted scroll when point enters a
6535 continued line of R2L text within an L2R paragraph, or vice versa.
6536 (cursor_row_p): Consider the case of point being equal to
6537 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6538 from the end of a short line to the beginning of a continued line
6539 of R2L text within L2R paragraph.
6540 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6541 composed characters.
5980d4c6 6542
f67cdd7f
EZ
6543 * bidi.c (bidi_check_type): Use xassert.
6544 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6545 members.
6546
bca633fb
EZ
65472011-08-23 Eli Zaretskii <eliz@gnu.org>
6548
6549 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6550 a character.
6551
4a5885a7
CY
65522011-08-23 Chong Yidong <cyd@stupidchicken.com>
6553
6554 * nsfont.m (ns_otf_to_script): Fix typo.
6555
0902a04e
KH
65562011-08-22 Kenichi Handa <handa@m17n.org>
6557
6558 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6559 extra slot even if the purpose is char-code-property-table.
6560
1a2e6670
EZ
65612011-08-23 Eli Zaretskii <eliz@gnu.org>
6562
8ddde651
EZ
6563 * xdisp.c (redisplay_window): When computing centering_position,
6564 account for the height of the header line. (Bug#8874)
6565
425cc014
EZ
6566 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6567 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6568 candidate is selected by the mouse, and that candidate has a
6569 composed character under the mouse.
6570
1a2e6670
EZ
6571 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6572 coordinates reported by pos-visible-in-window-p for a composed
6573 character in column zero.
6574
8b76d6f8
SM
65752011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6576
6577 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6578
dac347dd
EZ
65792011-08-22 Eli Zaretskii <eliz@gnu.org>
6580
6581 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6582 consider it a hit if to_charpos is anywhere in the range of the
6583 composed buffer positions.
6584
e013fb34
CY
65852011-08-22 Chong Yidong <cyd@stupidchicken.com>
6586
6587 * image.c (gif_load): Don't assume that each subimage has the same
6588 dimensions as the base image. Handle disposal method that is
6589 "undefined" by the gif spec (Bug#9335).
6590
bd1ba3e8
CY
65912011-08-20 Chong Yidong <cyd@stupidchicken.com>
6592
6593 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6594 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6595
54a1215b
EZ
65962011-08-19 Eli Zaretskii <eliz@gnu.org>
6597
823564e5
EZ
6598 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6599 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6600 from an Org mode buffer to a Speedbar frame.
6601
54a1215b
EZ
6602 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6603 a composition, take its buffer position from IT->cmp_it.charpos.
6604 Fixes cursor positioning at the beginning of a line that begins
6605 with a composed character.
6606
9778ebcc
EZ
66072011-08-18 Eli Zaretskii <eliz@gnu.org>
6608
0be6ee06
EZ
6609 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6610 character bidirectional type, use STRONG_L instead. Fixes crashes
6611 in a buffer produced by `describe-categories'.
6612
9778ebcc
EZ
6613 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6614 members before the level stack, so they would be saved and
6615 restored when copying iterator state. Fixes incorrect reordering
6616 around TABs covered by display properties.
6617
156bffbe
AS
66182011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6619
6b02f655 6620 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6621
72ad093b
CY
66222011-08-17 Chong Yidong <cyd@stupidchicken.com>
6623
6624 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6625 (internal_condition_case_2, internal_condition_case_n):
6626 Remove unnecessary aborts (Bug#9081).
72ad093b 6627
35774242
EZ
66282011-08-17 Eli Zaretskii <eliz@gnu.org>
6629
6630 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6631 has no `load' handler, try opening the file locally. (Bug#9311)
6632
db76dd85
KB
66332011-08-16 Ken Brown <kbrown@cornell.edu>
6634
6635 * gmalloc.c: Expand comment.
6636
b215eee5
EZ
66372011-08-16 Eli Zaretskii <eliz@gnu.org>
6638
6639 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6640 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6641
a4579d33
KB
66422011-08-16 Ken Brown <kbrown@cornell.edu>
6643
6644 Fix memory allocation problems in Cygwin build (Bug#9273).
6645
6646 * unexcw.c ( __malloc_initialized): Declare external variable.
6647 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6648
8b76d6f8
SM
6649 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6650 New variables.
a4579d33
KB
6651 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6652 dumped emacs.
6653 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6654 in the static heap.
6655 [CYGWIN] (special_realloc): New function.
6656 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6657 requests to realloc storage in the static heap.
6658
3ebec551
PE
66592011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6660
6661 * bidi.c (bidi_initialize): Remove unused local.
6662
9fd8be00
EZ
66632011-08-15 Eli Zaretskii <eliz@gnu.org>
6664
6b02f655
SM
6665 * bidimirror.h:
6666 * biditype.h: Remove file.
6667 * makefile.w32-in ($(BLD)/bidi.$(O)):
6668 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6669
6670 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6671
6672 * chartab.c: Improve commentary for the uniprop_table API.
6673
32413314
EZ
6674 * bidi.c (bidi_paragraph_init): Support zero value of
6675 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6676 (bidi_initialize): Use uniprop_table instead of including
6677 biditype.h and bidimirror.h.
32413314 6678
9fd8be00
EZ
6679 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6680 coordinates of the iterator when restoring from ppos_it.
6681 (Bug#9296)
6682
5cf2b69b
KH
66832011-08-14 Kenichi Handa <handa@m17n.org>
6684
6685 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6686 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6687
daf17d00
EZ
66882011-08-14 Eli Zaretskii <eliz@gnu.org>
6689
6690 * xdisp.c (move_it_in_display_line_to): Don't invoke
6691 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6692 ppos_it. Fixes vertical cursor motion when line beginning is
6693 covered by an image. (Bug#9296)
6694
08e3161a
JD
66952011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6696
6697 * nsterm.h (ns_run_ascript): Declare.
6698 (NSAPP_DATA2_RUNASSCRIPT): Define.
6699
6700 * nsfns.m (as_script, as_result, as_status): New static variables.
6701 (ns_run_ascript): New function.
5e617bc2 6702 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6703 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6704 the event loop. Get status from as_status (Bug#7276).
6705
6706 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6707 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6708 the event loop (Bug#7276).
6709
a3720aa2
AS
67102011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6711
6712 * gnutls.c (QCgnutls_bootprop_priority)
6713 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6714 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6715 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6716 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6717 (QCgnutls_bootprop_verify_hostname_error)
6718 (QCgnutls_bootprop_callbacks_verify): Rename from
6719 Qgnutls_bootprop_..., all uses changed.
6720
6721 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6722 uses changed.
6723
0a0d27fb
PE
67242011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6725
19d5c50c
PE
6726 * xfaces.c (Qframe_set_background_mode): Now static.
6727 * dispextern.h (Qframe_set_background_mode): Remove decl.
6728
0a0d27fb
PE
6729 * process.c (Fnetwork_interface_info): Declare local only if needed.
6730
377538cb
JD
67312011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6732
6733 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6734 (Fnetwork_interface_list): Allocate in increments of bytes instead
6735 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6736 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6737 sockaddr.
6738 (struct ifflag_def): notrailers is smart on OSX.
6739 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6740 Get hardware address with getifaddrs if available.
6741
08fff70c
EZ
67422011-08-12 Eli Zaretskii <eliz@gnu.org>
6743
6744 * xdisp.c (iterate_out_of_display_property): xassert that
6745 IT->position is set to within IT->object's boundaries. Break from
6746 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6747 when IT->position is set up wrongly due to some bug.
6748 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6749 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6750 entry. Force push_it to save on the stack the current
6751 buffer/string position, to be restored by pop_it. Fix flags in
6752 the iterator structure wrt the object coming from a display
6753 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6754 properties. (Bug#9284)
6755
7be1c708 67562011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6757
7be1c708
CY
6758 * fontset.c (fontset_get_font_group): Add proper type checks.
6759 (Bug#9172)
aac0c6e3 6760
7be1c708 67612011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6762
7be1c708
CY
6763 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6764 and LC_VERSION_MIN_MACOSX.
6765 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6766 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6767
97bb72a6
EZ
67682011-08-08 Eli Zaretskii <eliz@gnu.org>
6769
6770 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6771 no-display-properties-and-no-overlays under bidi display.
6772 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6773 properties and overlays.
97bb72a6 6774
d5617611
CY
67752011-08-08 Chong Yidong <cyd@stupidchicken.com>
6776
37e11a63
CY
6777 * editfns.c (Fset_time_zone_rule): Document relationship with the
6778 setenv function.
6779
d5617611
CY
6780 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6781 the font entity extracted from the cache (Bug#8109).
6782
58872834
CY
67832011-08-07 Chong Yidong <cyd@stupidchicken.com>
6784
6785 * composite.c (autocmp_chars): Don't reset point. That is done by
6786 restore_point_unwind (Bug#5984).
6787
75bfc667
JL
67882011-08-07 Juri Linkov <juri@jurta.org>
6789
6790 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6791 to show the arg `TIME' instead of `TIMEVAL'.
6792
d1410150
EZ
67932011-08-06 Eli Zaretskii <eliz@gnu.org>
6794
6795 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6796 display property strides EOL and includes a newline, as in
6797 longlines-mode. (Bug#9254)
75b771e4
EZ
6798 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6799 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6800
6801 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6802 is non-zero, even if the data buffer is NULL. Fixes a crash in
6803 vertical-motion with longlines-mode. (Bug#9254)
6804
35928349
EZ
68052011-08-05 Eli Zaretskii <eliz@gnu.org>
6806
ec7cc85b
EZ
6807 * bidi.c <bidi_cache_total_alloc>: Now static.
6808 (bidi_initialize): Initialize bidi_cache_total_alloc.
6809
8b76d6f8 6810 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6811 cache. (Bug#9221)
6812
6813 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6814 amount allocated this far in `bidi_cache_total_alloc'.
6815 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6816 non-zero, only free the data buffer without restoring the cache
6817 contents. All callers changed.
6818
6819 * dispextern.h (bidi_unshelve_cache): Update prototype.
6820
6821 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6822 (move_it_in_display_line, move_it_to)
6823 (move_it_vertically_backward, move_it_by_lines): Replace the call
6824 to xfree to an equivalent call to bidi_unshelve_cache.
6825 (move_it_in_display_line_to): Fix logic of returning
412b6358 6826 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6827
e2e2423b
EZ
68282011-08-05 Eli Zaretskii <eliz@gnu.org>
6829
6830 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6831 came from a string character with a `cursor' property. (Bug#9229)
6832
ae9e757a
JD
68332011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6834
6835 * Makefile.in (LIB_PTHREAD): New variable.
6836 (LIBES): Add LIB_PTHREAD (Bug#9216).
6837
6838 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6839 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6840
213bd7f2
AS
68412011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6842
6b02f655 6843 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6844
99aaf75f
JD
68452011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6846
6847 * xterm.c (x_find_topmost_parent): New function.
6848 (x_set_frame_alpha): Find topmost parent window with
6849 x_find_topmost_parent and set the property there also (bug#9181).
6850 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6851
c74e9d86
PE
68522011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6853
6854 * callproc.c (Fcall_process): Avoid vfork clobbering
6855 the local vars buffer, coding_systems, current_dir.
6856
640c8776
SM
68572011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6858
6859 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6860
f26d0e4c
PE
68612011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6862
8a10d76c
PE
6863 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6864 so that it is not optimized away.
6865
f26d0e4c
PE
6866 * xdisp.c (compute_display_string_pos): Remove unused local.
6867
55439c61
EZ
68682011-08-02 Eli Zaretskii <eliz@gnu.org>
6869
6870 Fix slow cursor motion and scrolling in large buffers with
6871 selective display, like Org Mode buffers. (Bug#9218)
6872
6873 * dispextern.h (struct bidi_it): New member disp_prop_p.
6874
6875 * xdisp.c: Remove one-slot cache of display string positions.
6876 (compute_display_string_pos): Accept an additional argument
5e617bc2 6877 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6878 for a display string or property. If found, set DISP_PROP_P
6879 non-zero.
6880
6881 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6882 DISP_PROP_P, and pass it to compute_display_string_pos.
6883 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6884 non-zero. All callers of bidi_fetch_char changed.
6885
fb33fa43
SM
68862011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6887
6888 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6889
b099e063
DM
68902010-12-03 Don March <don@ohspite.net>
6891
6892 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6893 last character M-[char] is translated to ESC [char] (bug#7541).
6894
5cc7f7af
KH
68952011-08-02 Kenichi Handa <handa@m17n.org>
6896
d0fffa3f 6897 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6898
6899 * chartab.c (uniprop_table): Make it non-static.
6900
525d5e6e
EZ
69012011-08-01 Eli Zaretskii <eliz@gnu.org>
6902
6903 * xdisp.c (forward_to_next_line_start): Accept additional argument
6904 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6905 on the newline.
6906 (reseat_at_next_visible_line_start): Use the bidi iterator state
6907 returned by forward_to_next_line_start to restore the state of
6908 it->bidi_it after backing up to previous newline. (Bug#9212)
6909
31011111
AS
69102011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6911
6912 * regex.c (re_comp): Protoize.
6913 (re_exec): Fix return type.
6914 (regexec): Fix type of `ret'. (Bug#9203)
6915
476371c4
PE
69162011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6917
e5d76069
PE
6918 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6919 This is needed if max-image-size is a floating-point number.
6920
9a79b20c
AS
69212011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6922
6923 * print.c (print_object): Print empty symbol as ##.
6924
6925 * lread.c (read1): Read ## as empty symbol.
6926
d8c2fa78
AA
69272011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6928
6929 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6930 setting frame foreground color (Bug#9175).
6931 (x_set_background_color): Likewise.
6932
ffe57a7a
AA
6933 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6934 contents (Bug#9176).
6935 (EmacsTooltip -init): Remove bezels and add shadows to
6936 tooltip windows.
6937
bf3492a5
AA
6938 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6939 or scroll bar (Bug#8470).
6940
d55e9c53
AA
6941 * nsfont.m (nsfont_open): Remove assignment to voffset and
6942 unnecessary vars hshink, expand, hd, full_height, min_height.
6943 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6944
6945 * nsterm.h (nsfont_info): Remove voffset field.
6946
d8c2fa78 69472011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6948
6949 Implement strike-through and overline on NextStep (Bug#8863).
6950
6951 * nsfont.m (nsfont_open): Use underline position provided by font,
6952 instead of hard-coded value of 2.
6953 (nsfont_draw): Call ns_draw_text_decoration instead.
6954
6955 * nsterm.h: Add declaration for ns_draw_text_decoration.
6956
6957 * nsterm.m (ns_draw_text_decoration): New function for drawing
6958 underline, overline, and strike-through.
6959 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6960 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6961 accommodate underlining, etc.
4843aac3 6962
4cc60b9b
EZ
69632011-07-28 Eli Zaretskii <eliz@gnu.org>
6964
bc7ece87
EZ
6965 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6966 default.
4cc60b9b 6967
476371c4
PE
69682011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6969
66606eea
PE
6970 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6971 Without this fix, if a signal arrives just after memory fills up,
6972 'malloc' might be invoked reentrantly.
6973
476371c4
PE
6974 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6975 In other words, assume that every image size is allowed, on non-X
6976 hosts. This assumption is probably wrong, but it lets Emacs compile.
6977
f3fcc40d
AS
69782011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6979
6980 * regex.c (re_iswctype): Convert return values to boolean.
6981
350c992f
EZ
69822011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6983
6984 * xdisp.c (compute_display_string_pos): Don't use cached display
6985 string position if the buffer had its restriction changed.
6986 (Bug#9184)
6987
5266b4bb
PE
69882011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6989
6990 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6991
2573a837 69922011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6993
41f55ccd 6994 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6995
39e378da
PE
6996 * bidi.c: Integer size and overflow fixes.
6997 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6998 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6999 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7000 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7001 (bidi_find_other_level_edge):
7002 Use ptrdiff_t instead of EMACS_INT where either will do.
7003 This works better on 32-bit hosts configured --with-wide-int.
7004 (bidi_cache_ensure_space): Check for size-calculation overflow.
7005 Use % rather than repeated addition, for better worst-case speed.
7006 Don't set bidi_cache_size until after xrealloc returns, because it
7007 might not return.
7008 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7009 (bidi_cache_ensure_space): Also check that the bidi cache size
7010 does not exceed that of the largest Lisp string or buffer. See Eli
7011 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7012
5e927815
PE
7013 * alloc.c (__malloc_size_t): Remove.
7014 All uses replaced by size_t. See Andreas Schwab's note
7015 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7016
ca4aa935
PE
7017 * image.c: Improve checking for integer overflow.
7018 (check_image_size): Assume that f is nonnull, since
7019 it is always nonnull in practice. This is one less thing to
7020 worry about when checking for integer overflow later.
7021 (x_check_image_size): New function, which checks for integer
7022 overflow issues inside X.
7023 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7024 This removes the need for a memory_full check.
7025 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7026 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7027 (xbm_read_bitmap_data): Change locals back to 'int', since
7028 their values must fit in 'int'.
7029 (xpm_load_image, png_load, tiff_load):
7030 Invoke x_create_x_image_and_pixmap earlier,
7031 to avoid much needless work if the image is too large.
7032 (tiff_load): Treat overly large images as if
7033 x_create_x_image_and_pixmap failed, not as malloc failures.
7034 (gs_load): Use x_check_image_size.
7035
5f8f9cc2
PE
7036 * gtkutil.c: Omit integer casts.
7037 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7038 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7039
5adf60bc
PE
7040 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7041
c8907a93
PE
7042 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7043 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7044 would wrongly return t on a 64-bit host.
7045
e3c25c68
PE
7046 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7047 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7048 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7049 and therefore cause GCC to emit a bogus diagnostic in some cases.
7050
3f791afe
PE
7051 * image.c: Integer signedness and overflow and related fixes.
7052 This is not an exhaustive set of fixes, but it's time to
7053 record what I've got.
7054 (lookup_pixel_color, check_image_size): Remove redundant decls.
7055 (check_image_size): Don't assume that arbitrary EMACS_INT values
7056 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7057 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7058 (tiff_load, imagemagick_load_image):
7059 Check for overflow in size calculations.
7060 (x_create_x_image_and_pixmap): Remove unnecessary test for
7061 xmalloc returning NULL; that can't happen.
7062 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7063 (xpm_color_bucket): Use better integer hashing function.
7064 (xpm_cache_color): Don't possibly over-allocate memory.
7065 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7066 (gif_memory_source):
7067 Use ptrdiff_t, not int or size_t, to record sizes.
7068 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7069 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7070 either works, as we prefer signed integers.
7071 (tiff_read_from_memory, tiff_write_from_memory):
7072 Return tsize_t, not size_t, since that's what the TIFF API wants.
7073 (tiff_read_from_memory): Don't fail simply because the read would
7074 go past EOF; instead, return a short read.
7075 (tiff_load): Omit no-longer-needed casts.
7076 (Fimagemagick_types): Don't assume size fits into 'int'.
7077
3cc5a532
PE
7078 Improve hashing quality when configured --with-wide-int.
7079 * fns.c (hash_string): New function, taken from sxhash_string.
7080 Do not discard information about ASCII character case; this
7081 discarding is no longer needed.
7082 (sxhash-string): Use it. Change sig to match it. Caller changed.
7083 * lisp.h: Declare it.
7084 * lread.c (hash_string): Remove, since we now use fns.c's version.
7085 The fns.c version returns a wider integer if --with-wide-int is
7086 specified, so this should help the quality of the hashing a bit.
7087
b312a492
PE
7088 * emacs.c: Integer overflow minor fix.
7089 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7090 Define only if GNU_LINUX.
7091 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7092
dfd153ae
PE
7093 * dispnew.c: Integer signedness and overflow fixes.
7094 Remove unnecessary forward decls, that were a maintenance hassle.
7095 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7096 All uses changed.
7097 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7098 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7099 (prepare_desired_row, line_draw_cost):
7100 Use int, not unsigned, where either works.
7101 (save_current_matrix, restore_current_matrix):
7102 Use ptrdiff_t, not size_t, where either works.
7103 (init_display): Check for overflow more accurately, and without
7104 relying on undefined behavior.
7105
a81d11a3
PE
7106 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7107 Remove, replacing with the new symbols in lisp.h. All uses changed.
7108 * fileio.c (make_temp_name):
7109 * filelock.c (lock_file_1, lock_file):
7110 * xdisp.c (message_dolog):
7111 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7112 Use pMd etc. instead.
7113 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7114 replacing the pWIDE etc. symbols removed from editfns.c.
7115
3300e6fd
PE
7116 * keyboard.h (num_input_events): Now uintmax_t.
7117 This is (very slightly) less likely to mess up due to wraparound.
7118 All uses changed.
7119
fd05c7e9
PE
7120 * buffer.c: Integer signedness fixes.
7121 (alloc_buffer_text, enlarge_buffer_text):
7122 Use ptrdiff_t rather than size_t when either will do, as we prefer
7123 signed integers.
7124
903fe15d
PE
7125 * alloc.c: Integer signedness and overflow fixes.
7126 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7127 (__malloc_size_t): Default to size_t, not to int.
7128 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7129 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7130 Prefer ptrdiff_t to size_t when either would do, as we prefer
7131 signed integers.
7132 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7133 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7134 Now const. Initialize with values that are in range even if char
7135 is signed.
7136 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7137 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7138 These functions do the right thing with sizes > 2**32.
7139 (check_depth): Now ptrdiff_t, not int.
7140 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7141 Adjust to new way of storing sizes. Check for size overflow bugs
7142 in rest of code.
7143 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7144 slightly wrong anyway, as it missed one instance of
7145 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7146 (refill_memory_reserve): Omit needless cast to size_t.
7147 (mark_object_loop_halt): Mark as externally visible.
7148
ac82cc6a
PE
7149 * xselect.c: Integer signedness and overflow fixes.
7150 (Fx_register_dnd_atom, x_handle_dnd_message):
7151 Use ptrdiff_t, not size_t, since we prefer signed.
7152 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7153 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7154 x_dnd_atoms_size and x_dnd_atoms_length.
7155
c2d1e36d
PE
7156 * doprnt.c: Prefer signed to unsigned when either works.
7157 * eval.c (verror):
7158 * doprnt.c (doprnt):
7159 * lisp.h (doprnt):
7160 * xdisp.c (vmessage):
7161 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7162 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7163 prefer signed arithmetic to avoid comparison confusion.
7164 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7165 but is a bit tricky.
7166
0e926e56
PE
7167 Assume freestanding C89 headers, string.h, stdlib.h.
7168 * data.c, doprnt.c, floatfns.c, print.c:
7169 Include float.h unconditionally.
7170 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7171 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7172 * regex.c: Likewise for stddef.h, string.h.
7173 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7174 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7175 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7176 (STDC_HEADERS): Remove obsolete defines.
7177 * sysdep.c: Include limits.h unconditionally.
7178
9cfdb3ec
PE
7179 Assume support for memcmp, memcpy, memmove, memset.
7180 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7181 * regex.c (memcmp, memcpy):
7182 Remove; we assume C89 now.
7183
7184 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7185 (__malloc_safe_bcopy): Remove; no longer needed.
7186
cf950e6b 7187 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7188 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7189 well either way, and we prefer signed to unsigned.
7190
dbf38e02
LMI
71912011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7192
7193 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7194 closes the connection while we're reading (bug#9182).
7195
d6f0886c 71962011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7197
d6f0886c
JD
7198 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7199 are specified (Bug#9168).
24e0f6b1 7200
2eb1f9e6
PE
72012011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7202
7203 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7204 Found by GCC static checking and --with-wide-int on a 32-bit host.
7205
22381272 72062011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7207
7208 * xdisp.c (compute_display_string_pos): Fix logic of caching
7209 previous display string position. Initialize cached_prev_pos to
7210 -1. Fixes slow-down at the beginning of a buffer.
7211
f25e39b4
EZ
72122011-07-24 Eli Zaretskii <eliz@gnu.org>
7213
7214 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7215 for attrs[LFACE_FONTSET_INDEX].
7216
04c4b52e
PE
72172011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7218
7219 * xml.c (parse_region): Remove unused local
7220 that was recently introduced.
7221
c1734fbd
EZ
72222011-07-23 Eli Zaretskii <eliz@gnu.org>
7223
be18c5a5
EZ
7224 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7225 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7226
c1734fbd
EZ
7227 * xdisp.c (move_it_in_display_line_to): Record the best matching
7228 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7229 exit if none of the characters scanned was an exact match.
7230 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7231 when exact match is impossible due to invisible text, and the
7232 lines are truncated.
7233
a258d627
JD
72342011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7235
7236 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7237 for OSX >= 10.7.
7238
b6d5a689
EZ
72392011-07-22 Eli Zaretskii <eliz@gnu.org>
7240
0f74f785
EZ
7241 Fix a significant slow-down of cursor motion with C-n, C-p,
7242 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7243 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7244 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7245 (next_element_from_buffer): Call compute_stop_pos_backwards to
7246 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7247 base_level_stop.
7248 (reseat): Don't look for prev_stop, as that could mean a very long
7249 run.
7250 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7251 <cached_disp_overlay_modiff>: Cache for last found display string
7252 position.
551918c1 7253 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7254 about the same buffer in the same area of character positions, and
7255 the buffer wasn't changed since the time the display string
7256 position was cached.
551918c1 7257
b2d0c91a
EZ
72582011-07-22 Eli Zaretskii <eliz@gnu.org>
7259
7260 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7261 is an integer, which is important for empty lines. (Bug#9149)
7262
043604ee
CY
72632011-07-22 Chong Yidong <cyd@stupidchicken.com>
7264
7265 * frame.c (Fmodify_frame_parameters): In tty case, update the
7266 default face if necessary (Bug#4238).
7267
da4adb04
CY
72682011-07-21 Chong Yidong <cyd@stupidchicken.com>
7269
7270 * editfns.c (Fstring_to_char): No need to explain what a character
7271 is in the docstring (Bug#6576).
7272
9abd0532
LMI
72732011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7274
7275 * xml.c (parse_region): Make sure we always return a tree.
7276
36881d16
HK
72772011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7278
7279 * xml.c (parse_region): If a document contains only comments,
7280 return that, too.
7281
1e98674d
LMI
72822011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7283
7284 * xml.c (make_dom): Return comments, too.
7285
590bd467
PE
72862011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7287
7288 Port to OpenBSD.
7289 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7290 and the surrounding thread.
7291 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7292 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7293 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7294 timer goes off.
7295 * s/openbsd.h (BROKEN_SIGIO): Define.
7296 * unexelf.c (unexec) [__OpenBSD__]:
7297 Don't update the .mdebug section of the Alpha COFF symbol table.
7298
f41628b2
LMI
72992011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7300
7301 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7302 (bug#8460).
7303
b59b67c5
PE
73042011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7305
15e3a074
PE
7306 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7307 This fixes some race conditions on the permissions of any newly
7308 created file.
7309
41bed37d
PE
7310 * alloc.c (valid_pointer_p): Use pipe, not open.
7311 This fixes some permissions issues when debugging.
7312
b59b67c5
PE
7313 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7314 If fchown fails to set both uid and gid, try to set just gid,
7315 as that is sometimes allowed. Adjust the file's mode to eliminate
7316 setuid or setgid bits that are inappropriate if fchown fails.
7317
925a6be7
SM
73182011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7319
7320 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7321 to compare Lisp_Objects.
7322 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7323 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7324 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7325
52968808
AS
73262011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7327
0a6a104b
AS
7328 * lread.c (read_integer): Unread even EOF character.
7329 (read1): Likewise. Properly record start position of symbol.
7330
52968808
AS
7331 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7332 symbol character follows.
7333
9e381cdd
PE
73342011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7335
7336 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7337 This works around a problem with the previous change to Fcopy_file.
7338 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7339 and without this change, GCC might complain about discarding
7340 fchown's return value.
7341
b5641435
JB
73422011-07-16 Juanma Barranquero <lekktu@gmail.com>
7343
7344 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7345
a8031457
PE
73462011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7347
7348 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7349
dd889327
LMI
73502011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7351
750c33f7
LMI
7352 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7353 it's used from the C level.
7354
dd889327
LMI
7355 * process.c: Use the same condition for POLL_FOR_INPUT in both
7356 keyboard.c and process.c (bug#1858).
7357
87e86684
LM
73582011-07-09 Lawrence Mitchell <wence@gmx.li>
7359
7360 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7361 (Fgnutls_boot): Use it.
7362
64348f40
AS
73632011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7364
7365 * doc.c (Fsubstitute_command_keys): Revert last change.
7366
1d698799
LMI
73672011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7368
f863868c
LMI
7369 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7370 quotes the next character, and doesn't affect other longer
7371 sequences (bug#8935).
7372
1d698799
LMI
7373 * lread.c (syms_of_lread): Clarify that is isn't only
7374 `eval-buffer' and `eval-defun' that's affected by
7375 `lexical-binding' (bug#8460).
7376
aa4b6df6
EZ
73772011-07-15 Eli Zaretskii <eliz@gnu.org>
7378
7379 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7380 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7381
5d856da6
PE
73822011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7383
ad6042bb
PE
7384 Fix minor problems found by static checking.
7385 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7386 (elsz): Now a signed constant, not a size_t var. We prefer signed
7387 types to unsigned, to avoid integer comparison confusion. Without
7388 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7389 "cannot optimize loop, the loop counter may overflow", a symptom
7390 of the confusion.
f00bbb22 7391 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7392 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7393
6468f31c
LMI
73942011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7395
49080b10
LMI
7396 * search.c (Fre_search_backward): Mention `case-fold-search' in
7397 all the re_search_* functions (bug#8138).
7398
6468f31c
LMI
7399 * keyboard.c (Fopen_dribble_file): Document when the file is
7400 closed (bug#8056).
7401
c965adc5
EZ
74022011-07-14 Eli Zaretskii <eliz@gnu.org>
7403
df9733bf
EZ
7404 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7405 bidi_cache_idx.
7406
0bb23927
EZ
7407 Support bidi reordering of display and overlay strings.
7408 * xdisp.c (compute_display_string_pos)
7409 (compute_display_string_end): Accept additional argument STRING.
7410 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7411 (reseat_to_string): Initialize bidi_it->string.s and
7412 bidi_it->string.schars.
7413 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7414 NULL (avoids a crash in bidi_paragraph_init).
7415 Initialize itb.string.lstring.
0bb23927
EZ
7416 (init_iterator): Call bidi_init_it only of a valid
7417 buffer position was specified. Initialize paragraph_embedding to
7418 L2R.
7419 (reseat_to_string): Initialize the bidi iterator.
7420 (display_string): If we need to ignore text properties of
7421 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7422 original value of -1 will not work with bidi.)
7423 (compute_display_string_pos): First arg is now struct
7424 `text_pos *'; all callers changed. Support display properties on
7425 Lisp strings.
7426 (compute_display_string_end): Support display properties on Lisp
7427 strings.
7428 (init_iterator, reseat_1, reseat_to_string): Initialize the
7429 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7430 when iterating on a string not from display properties).
640c8776
SM
7431 (compute_display_string_pos, compute_display_string_end):
7432 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7433 arrow keys.
7434 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7435 base_level_stop; instead, set base_level_stop to BEGV.
7436 Fixes crashes in vertical-motion.
0bb23927
EZ
7437 (next_element_from_buffer): Improve commentary for when
7438 the iterator is before prev_stop.
7439 (init_iterator): Initialize bidi_p from the default value of
7440 bidi-display-reordering, not from buffer-local value. Use the
7441 buffer-local value only if initializing for buffer iteration.
7442 (handle_invisible_prop): Support invisible properties on strings
7443 that are being bidi-reordered.
7444 (set_iterator_to_next): Support bidi reordering of C strings and
7445 Lisp strings.
7446 (next_element_from_string): Support bidi reordering of Lisp
7447 strings.
7448 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7449 (display_string): Support display of R2L glyph rows.
7450 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7451 (init_iterator): Don't initialize it->bidi_p for strings
7452 here.
7453 (reseat_to_string): Initialize it->bidi_p for strings here.
7454 (next_element_from_string, next_element_from_c_string)
7455 (next_element_from_buffer): Add xassert's for correspondence
7456 between IT's object being iterated and it->bidi_it.string
7457 structure.
7458 (face_before_or_after_it_pos): Support bidi iteration.
7459 (next_element_from_c_string): Handle the case of the first string
7460 character that is not the first one in the visual order.
7461 (get_visually_first_element): New function, refactored from common
7462 parts of next_element_from_buffer, next_element_from_string, and
7463 next_element_from_c_string.
7464 (tool_bar_lines_needed, redisplay_tool_bar)
7465 (display_menu_bar): Force left-to-right direction. Add a FIXME
7466 comment for making that be controlled by a user option.
7467 (push_it, pop_it): Save and restore the state of the
7468 bidi iterator. Save and restore the bidi_p flag.
7469 (pop_it): Iterate out of display property for string iteration as
7470 well.
7471 (iterate_out_of_display_property): Support iteration over strings.
7472 (handle_single_display_spec): Set up it->bidi_it for iteration
7473 over a display string, and call bidi_init_it.
7474 (handle_single_display_spec, next_overlay_string)
7475 (get_overlay_strings_1, push_display_prop): Set up the bidi
7476 iterator for displaying display or overlay strings.
7477 (forward_to_next_line_start): Don't use the shortcut if
7478 bidi-iterating.
7479 (back_to_previous_visible_line_start): If handle_display_prop
7480 pushed the iterator stack, restore the internal state of the bidi
7481 iterator by calling bidi_pop_it same number of times.
7482 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7483 and we are bidi-iterating, don't decrement the iterator position;
7484 instead, set the first_elt flag in the bidi iterator, to produce
7485 the same effect.
7486 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7487 (push_display_prop): xassert that we are iterating a buffer.
7488 (push_it, pop_it): Save and restore paragraph_embedding member.
7489 (handle_single_display_spec, next_overlay_string)
7490 (get_overlay_strings_1, reseat_1, reseat_to_string)
7491 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7492 correctly. Don't assume unibyte strings are not bidi-reordered.
7493 (compute_display_string_pos)
7494 (compute_display_string_end): Fix handling the case of C string.
7495 (push_it, pop_it): Save and restore from_disp_prop_p.
7496 (handle_single_display_spec, push_display_prop): Set the
7497 from_disp_prop_p flag.
7498 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7499 (pop_it): Call iterate_out_of_display_property only if we are
7500 popping after iteration over a string that came from a display
7501 property. Fix a typo in popping stretch info. Add an assertion
7502 for verifying that the iterator position is in sync with the bidi
7503 iterator.
7504 (handle_single_display_spec, get_overlay_strings_1)
7505 (push_display_prop): Fix initialization of paragraph direction for
7506 string when that of the parent object is not yet determined.
7507 (reseat_1): Call bidi_init_it to resync the bidi
7508 iterator with IT's position. (Bug#7616)
7509 (find_row_edges): If ROW->start.pos gives position
7510 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7511 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7512 Reset the from_disp_prop_p flag.
7513 (SAVE_IT, RESTORE_IT): New macros.
7514 (pos_visible_p, face_before_or_after_it_pos)
7515 (back_to_previous_visible_line_start)
7516 (move_it_in_display_line_to, move_it_in_display_line)
7517 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7518 (try_scrolling, redisplay_window, display_line): Use them when
7519 saving a temporary copy of the iterator and restoring it back.
7520 (back_to_previous_visible_line_start, reseat_1)
7521 (init_iterator): Empty the bidi cache "stack".
7522 (move_it_in_display_line_to): If iterator ended up at
7523 EOL, but we never saw any buffer positions smaller than
7524 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7525 motion in bidi-reordered lines.
7526 (move_it_in_display_line_to): Record prev_method and prev_pos
7527 immediately before the call to set_iterator_to_next. Fixes cursor
7528 motion in bidi-reordered lines with stretch glyphs and strings
7529 displayed in margins. (Bug#8133) (Bug#8867)
7530 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7531 TO_CHARPOS.
640c8776
SM
7532 (pos_visible_p): Support positions in bidi-reordered lines.
7533 Save and restore bidi cache.
0bb23927
EZ
7534
7535 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7536 (bidi_paragraph_info): Delete unused struct.
7537 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7538 (bidi_cache_start): New variable.
7539 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7540 to zero.
7541 (bidi_cache_fetch_state, bidi_cache_search)
7542 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7543 (bidi_cache_find, bidi_peek_at_next_level)
7544 (bidi_level_of_next_char, bidi_find_other_level_edge)
7545 (bidi_move_to_visually_next): Compare cache index with
7546 bidi_cache_start rather than with zero.
7547 (bidi_fetch_char): Accept new argument STRING; all callers
7548 changed. Support iteration over a string. Support strings with
7549 display properties. Support unibyte strings. Fix the type of
7550 `len' according to what STRING_CHAR_AND_LENGTH expects.
7551 (bidi_paragraph_init, bidi_resolve_explicit_1)
7552 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7553 (bidi_level_of_next_char, bidi_move_to_visually_next):
7554 Support iteration over a string.
0bb23927
EZ
7555 (bidi_set_sor_type, bidi_resolve_explicit_1)
7556 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7557 can now be zero (for strings); special values 0 and -1 were
7558 changed to -1 and -2, respectively.
7559 (bidi_char_at_pos): New function.
7560 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7561 Call it instead of FETCH_MULTIBYTE_CHAR.
7562 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7563 initialized to valid values.
7564 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7565 values.
7566 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7567 the test for valid cached positions. Fix the logic for looking up
7568 the sentinel state in the cache. GCPRO the Lisp string we are
7569 iterating.
7570 (bidi_push_it, bidi_pop_it): New functions.
7571 (bidi_initialize): Initialize the bidi cache start stack pointer.
7572 (bidi_cache_ensure_space): New function, refactored from part of
7573 bidi_cache_iterator_state. Don't assume the required size is just
7574 one BIDI_CACHE_CHUNK away.
7575 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7576 (bidi_count_bytes, bidi_char_at_pos): New functions.
7577 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7578 always valid if bidi_cache_idx is valid.
7579 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7580 is valid if it's going to be used.
7581 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7582 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7583 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7584 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7585 (bidi_find_other_level_edge, bidi_cache_start_stack):
7586 All variables related to cache indices are now EMACS_INT.
c965adc5 7587
0bb23927
EZ
7588 * dispextern.h (struct bidi_string_data): New structure.
7589 (struct bidi_it): New member `string'. Make flag members be 1-bit
7590 fields, and put them last in the struct.
640c8776
SM
7591 (compute_display_string_pos, compute_display_string_end):
7592 Update prototypes.
0bb23927
EZ
7593 (bidi_push_it, bidi_pop_it): Add prototypes.
7594 (struct iterator_stack_entry): New members bidi_p,
7595 paragraph_embedding, and from_disp_prop_p.
7596 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7597 (bidi_shelve_cache, bidi_unshelve_cache):
7598 Declare prototypes.
0bb23927
EZ
7599
7600 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7601 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7602 and vector-like objects.
7603
7604 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7605 cache around display iteration.
7606
7607 * window.c (Fwindow_end, window_scroll_pixel_based)
7608 (displayed_window_lines, Frecenter): Save and restore the bidi
7609 cache around display iteration.
7610
3bbd2265
LMI
76112011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7612
7613 * editfns.c (Fdelete_region): Clarify the use of the named
7614 parameters (bug#6788).
7615
adc47434
MR
76162011-07-14 Martin Rudalics <rudalics@gmx.at>
7617
7618 * indent.c (Fvertical_motion): Set and restore w->pointm when
7619 saving and restoring the window's buffer (Bug#9006).
7620
837c31f8
LMI
76212011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7622
7623 * editfns.c (Fstring_to_char): Clarify just what is returned
7624 (bug#6576). Text by Eli Zaretskii.
7625
ac389d0c
JB
76262011-07-13 Juanma Barranquero <lekktu@gmail.com>
7627
7628 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7629
0be0ce47
EZ
76302011-07-13 Eli Zaretskii <eliz@gnu.org>
7631
7632 * buffer.c (mmap_find): Fix a typo.
7633
cd18e7e3
JB
76342011-07-13 Johan Bockgård <bojohan@gnu.org>
7635
7636 Fix execution of x selection hooks.
7637 * xselect.c (Qx_lost_selection_functions)
7638 (Qx_sent_selection_functions): New vars.
7639 (syms_of_xselect): DEFSYM them.
7640 (x_handle_selection_request): Pass Qx_sent_selection_functions
7641 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7642 (x_handle_selection_clear,x_clear_frame_selections):
7643 Pass Qx_lost_selection_functions rather than
7644 Vx_lost_selection_functions to Frun_hook_with_args.
7645
47ea7f44
PE
76462011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7647
ac389d0c 7648 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7649 The old code sometimes used this field without initializing it.
7650
47ea7f44
PE
7651 * alloc.c (gc_sweep): Don't read past end of array.
7652 In theory, the old code could also have corrupted Emacs internals,
7653 though it'd be very unlikely.
7654
bc985c87
AS
76552011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7656
7657 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7658 argument. (Bug#4026)
bc985c87 7659
0cf34688
LMI
76602011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7661
b3dadd76
LMI
7662 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7663 key" (bug#4257).
7664
0cf34688
LMI
7665 * window.c (Fset_window_start): Doc fix (bug#4199).
7666 (Fset_window_hscroll): Ditto.
7667
270768cd
PE
76682011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7669
077e3dda 7670 Fix minor new problems caught by GCC 4.6.1.
270768cd 7671 * term.c (init_tty): Remove unused local.
490011a6 7672 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7673 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7674 not used otherwise.
270768cd 7675
b1f58454
CY
76762011-07-12 Chong Yidong <cyd@stupidchicken.com>
7677
7678 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7679
22b9578d
LMI
76802011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7681
6e70ab07
LMI
7682 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7683 are the mini-buffer and the echo area (bug#3320).
7684
22b9578d
LMI
7685 * term.c (init_tty): Remove support for supdup, c10 and perq
7686 terminals, which are no longer supported (bug#1482).
7687
8974cc9f
JB
76882011-07-10 Johan Bockgård <bojohan@gnu.org>
7689
7690 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7691
a560d974
JD
76922011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7693
7694 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7695 for non-popups (Bug#3642).
7696
1dae0f0a
AS
76972011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7698
268c2c36 7699 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7700 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7701 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7702 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7703 * data.c (fmod): Likewise.
7704 * dispnew.c (swap_glyphs_in_rows): Likewise.
7705 * emacs.c (memory_warning_signal): Likewise.
7706 * floatfns.c (float_error): Likewise.
7707 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7708 (otf_open, font_otf_capability, generate_otf_features)
7709 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7710 Likewise.
7711 * image.c (pbm_read_file): Likewise.
7712 * indent.c (string_display_width): Likewise.
7713 * intervals.c (check_for_interval, search_for_interval)
7714 (inc_interval_count, count_intervals, root_interval)
7715 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7716 * lread.c (defalias): Likewise.
268c2c36 7717 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7718 * regex.c (set_image_of_range_1, set_image_of_range)
7719 (regex_grow_registers): Likewise.
7720 * sysdep.c (strerror): Likewise.
7721 * termcap.c (valid_filename_p, tprint, main): Likewise.
7722 * tparam.c (main): Likewise.
7723 * unexhp9k800.c (run_time_remap, save_data_space)
7724 (update_file_ptrs, read_header, write_header, calculate_checksum)
7725 (copy_file, copy_rest, display_header): Likewise.
7726 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7727 Likewise.
7728 * xdisp.c (check_it): Likewise.
7729 * xfaces.c (register_color, unregister_color, unregister_colors):
7730 Likewise.
7731 * xfns.c (print_fontset_result): Likewise.
7732 * xrdb.c (member, fatal, main): Likewise.
7733
99033785
PE
77342011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7735
7736 Fix minor problems found by static checking (Bug#9031).
7737 * chartab.c (char_table_set_range, map_sub_char_table):
7738 Remove unused locals.
7739 (uniprop_table): Now static.
7740 * composite.c (_work_char): Remove unused static var.
7741
9cb2ac56
JB
77422011-07-09 Juanma Barranquero <lekktu@gmail.com>
7743
7744 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7745
f25661f0
JD
77462011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7747
7748 * gtkutil.c (qttip_cb): Remove code without function.
7749
8278c4fe
EZ
77502011-07-09 Eli Zaretskii <eliz@gnu.org>
7751
7752 * w32.c (pthread_sigmask): New stub.
7753
1692ae2d 77542011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7755
8a6ebd58 7756 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7757 sigprocmask is portable only for single-threaded applications, and
7758 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7759 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7760 (LIBES): Use it.
7761 * callproc.c (Fcall_process):
7762 * process.c (create_process):
7763 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7764 Use pthread_sigmask, not sigprocmask.
123403e4 7765
1b854618
JD
77662011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7767
7768 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7769 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7770 wrong (Bug#8591).
7771
3fe4b549
JD
77722011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7773
0ce7e563
JD
7774 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7775 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7776 (xg_hide_tooltip): Fix comment.
7777
3fe4b549
JD
7778 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7779 in registerServicesMenuSendTypes.
7780 (validRequestorForSendType): Don't check ns_return_types.
7781
7782 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7783 ns_return_type.
7784
5df75e47
JR
77852011-07-08 Jason Rumney <jasonr@gnu.org>
7786
22610910
JR
7787 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7788 SH_SHOW for hidden windows (Bug#5482).
7789
5df75e47
JR
7790 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7791 frame struct members of non-existent frames (Bug#6284).
7792
699c10bd
JD
77932011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7794
4393663b
JD
7795 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7796 variable firstTime not needed on OSX >= 10.6.
7797 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7798 >= 10.5. Use setKnobProportion, setDoubleValue.
7799
7800 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7801 (MAC_OS_X_VERSION_10_5): Define if not defined.
7802 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7803 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7804 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7805
7806 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 7807 cString and lossyCString on OSX >= 10.4.
4393663b 7808
58179cce 7809 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7810 sizeToFit on OSX >= 10.2.
7811
7812 * nsimage.m (allocInitFromFile): Don't use deprecated method
7813 bestRepresentationForDevice on OSX >= 10.6.
7814
7815 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7816 to avoid warning.
7817
7818 * emacs.c: Declare unexec_init_emacs_zone.
7819
a63e0781
JD
7820 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7821
699c10bd
JD
7822 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7823
7824 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7825 on svcsMenu (Bug#8842).
7826
7827 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7828 ns_return_types.
7829 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7830
7831 * nsterm.m (QUTF8_STRING): Declare.
7832 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7833 (validRequestorForSendType): Return type is (id).
7834 Change indexOfObjectIdenticalTo to indexOfObject.
7835 Check if we have local selection before returning self (Bug#8842).
7836 (writeSelectionToPasteboard): Put local selection into paste board
7837 if we have a local selection (Bug#8842).
7838 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7839
7840 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7841 (ns_get_local_selection): Declare.
7842
54e10184
LMI
78432011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7844
9888ff71
LMI
7845 * keymap.c (describe_map_tree): Don't insert a double newline at
7846 the end of the buffer (bug#1169) and return whether we inserted
7847 something.
7848
54e10184
LMI
7849 * callint.c (Fcall_interactively): Change "reading args" to
7850 "providing args" to try to clarify what it does (bug#1010).
7851
15fa4783
KH
78522011-07-07 Kenichi Handa <handa@m17n.org>
7853
7854 * composite.c (composition_compute_stop_pos): Ignore a static
7855 composition starting before CHARPOS (Bug#8915).
7856
7857 * xdisp.c (handle_composition_prop): Likewise.
7858
a8815b00
EZ
78592011-07-07 Eli Zaretskii <eliz@gnu.org>
7860
7861 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7862 (Bug#9015)
7863
ef7b981d 78642011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7865
7866 * character.h (unicode_category_t): New enum type.
7867
7868 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7869 (Qchar_code_property_table): New variable.
7870 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7871 (UNIPROP_COMPRESSED_FORM_P): New macros.
7872 (char_table_ascii): Uncompress the compressed values.
7873 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7874 Uncompress the compressed values.
ac389d0c 7875 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7876 (char_table_ref_and_range): Uncompress the compressed values.
7877 (sub_char_table_set): New arg is_uniprop. Callers changed.
7878 Uncompress the compressed values.
7879 (sub_char_table_set_range): Args changed. Callers changed.
7880 (char_table_set_range): Adjuted for the above change.
7881 (map_sub_char_table): Delete args default_val and parent. Add arg
7882 top. Give decoded values to a Lisp function.
640c8776 7883 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7884 values to a Lisp function. Gcpro more variables.
7885 (uniprop_table_uncompress)
7886 (uniprop_decode_value_run_length): New functions.
7887 (uniprop_decoder, uniprop_decoder_count): New variables.
7888 (uniprop_get_decoder, uniprop_encode_value_character)
7889 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7890 New functions.
7891 (uniprop_encoder, uniprop_encoder_count): New variables.
7892 (uniprop_get_encoder, uniprop_table)
7893 (Funicode_property_table_internal, Fget_unicode_property_internal)
7894 (Fput_unicode_property_internal): New functions.
7895 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7896 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7897 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7898 char-code-property-alist.
7899
640c8776 7900 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7901 Vunicode_category_table.
7902
640c8776 7903 * font.c (font_range): Adjust for the change of
c805dec0
KH
7904 Vunicode_category_table.
7905
76b397fb
DN
79062011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7907
7908 * m/iris4d.h: Remove file, move contents ...
7909 * s/irix6-5.h: ... here.
7910
22b4128e
PE
79112011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7912
7913 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7914 * alloc.c (mark_buffer):
7915 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7916 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7917 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7918 This isn't true in general, and it's particularly not true
7919 if Emacs is configured with --with-wide-int.
7920 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7921 New macros, used in the buffer.c change.
7922
869795d6
JD
79232011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7924
7925 * xsettings.c: Use both GConf and GSettings if both are available.
7926 (store_config_changed_event): Add comment.
7927 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7928 (store_tool_bar_style_changed): New functions.
5e617bc2 7929 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7930 (struct xsettings): Move font inside HAVE_XFT.
7931 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7932 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7933 Move inside HAVE_XFT.
640c8776 7934 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7935 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7936 also.
7937 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7938 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7939 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7940 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7941 (parse_settings): Move check for font inside HAVE_XFT.
7942 (read_settings, apply_xft_settings): Add comment.
7943 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7944 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7945 call store_font_name_changed.
7946 (xft_settings_event): Add comment.
7947 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7948 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7949 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7950 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7951 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7952 (xsettings_get_system_font, xsettings_get_system_normal_font):
7953 Add comment.
869795d6 7954
d8ed26bd
PE
79552011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7956
7957 Random fixes. E.g., (random) never returned negative values.
7958 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7959 subseconds part to the entropy, as that's a bit more random.
7960 Prefer signed to unsigned, since the signedness doesn't matter and
7961 in general we prefer signed. When given a limit, use a
7962 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7963 latter isn't right if USE_2_TAGS_FOR_INTS.
7964 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7965 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7966
cabf1cac
SM
79672011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7968
7969 * textprop.c (text_property_stickiness):
7970 Obey Vtext_property_default_nonsticky.
7971 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7972 * w32fns.c (syms_of_w32fns):
7973 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7974
6e9b2be9
PE
79752011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7976
7977 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7978 This is more efficient than Ffile_directory_p and avoids a minor race.
7979
90186c68
LMI
79802011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7981
7c301272
LMI
7982 * buffer.c (Foverlay_put): Say what the return value is
7983 (bug#7835).
7984
c4f2d8d4
LMI
7985 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7986 is a directory before asking whether to use the file name
7987 (bug#7564).
ad637907
LMI
7988 (barf_or_query_if_file_exists): Make the "File is a directory"
7989 error be more correct.
c4f2d8d4 7990
90186c68
LMI
7991 * fns.c (Frequire): Remove the mention of the .gz files, since
7992 that's installation-specific, but keep the mention of
7993 `get-load-suffixes'.
7994
da64016e
PE
79952011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7996
7997 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7998 Report string overflow if the output is too long.
7999
7d47b580
JB
80002011-07-04 Juanma Barranquero <lekktu@gmail.com>
8001
a555cb87
JB
8002 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8003 (syms_of_gnutls): Remove duplicate DEFSYM for
8004 Qgnutls_bootprop_verify_hostname_error, an error for
8005 Qgnutls_bootprop_verify_error (which is no longer used).
8006
7d47b580
JB
8007 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8008 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8009 Also (re)move comments that are misplaced or no longer relevant.
8010
1e49bfab
LMI
80112011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8012
8013 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8014
1485f4c0
CY
80152011-07-03 Chong Yidong <cyd@stupidchicken.com>
8016
8017 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8018 and background color parameters if they have been changed.
8019
a9ab721e
LMI
80202011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8021
8022 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8023
cf7cff57
PE
80242011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8025
2e13213d
PE
8026 * xsettings.c (SYSTEM_FONT): Define only when used.
8027 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8028
cf7cff57
PE
8029 * keymap.c (access_keymap_1): Now static.
8030
7a8e04f7
CY
80312011-07-02 Chong Yidong <cyd@stupidchicken.com>
8032
8033 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8034 leave any prefix arg for the up event (Bug#1586).
8035
61352f62
LMI
80362011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8037
69bb1ef7
LMI
8038 * lread.c (syms_of_lread): Mention single symbols defined by
8039 `defvar' or `defconst' (bug#7154).
8040
61352f62 8041 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8042 (Frequire): Mention get-load-suffixes.
61352f62 8043
28545e04
MR
80442011-07-02 Martin Rudalics <rudalics@gmx.at>
8045
8046 * window.h (window): Remove clone_number slot.
8047 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8048 Remove.
8049 (make_parent_window, make_window, saved_window)
8050 (Fset_window_configuration, save_window_save): Don't deal with
8051 clone numbers.
8052 * buffer.c (Qclone_number): Remove declaration.
8053 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8054
3349e122
SM
80552011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8056
8057 Add multiple inheritance to keymaps.
8058 * keymap.c (Fmake_composed_keymap): New function.
8059 (Fset_keymap_parent): Simplify.
8060 (fix_submap_inheritance): Remove.
8061 (access_keymap_1): New function extracted from access_keymap to handle
8062 embedded parents and handle lists of maps.
8063 (access_keymap): Use it.
8064 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8065 (Fcopy_keymap): Handle embedded parents.
8066 (Fcommand_remapping, define_as_prefix): Simplify.
8067 (Fkey_binding): Simplify.
8068 (syms_of_keymap): Move minibuffer-local-completion-map,
8069 minibuffer-local-filename-completion-map,
8070 minibuffer-local-must-match-map, and
8071 minibuffer-local-filename-must-match-map to Elisp.
8072 (syms_of_keymap): Defsubr make-composed-keymap.
8073 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8074 (parse_menu_item): Trivial simplification.
8075
3279eb87
GM
80762011-07-01 Glenn Morris <rgm@gnu.org>
8077
8078 * Makefile.in (SETTINGS_LIBS): Fix typo.
8079
4550efdf
KI
80802011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8081
8082 * coding.c (Fencode_coding_string): Record the last coding system
8083 used, as the function doc string says (bug#8738).
8084
0949d2b6
JD
80852011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8086
8087 * xsettings.c (store_monospaced_changed): Take new font as arg and
8088 check for change against current_mono_font.
8089 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8090 (emacs_settings_constructor, emacs_settings_get_property)
8091 (emacs_settings_set_property, emacs_settings_class_init)
8092 (emacs_settings_init, gsettings_obj): Remove.
8093 (something_changedCB): New function for HAVE_GSETTINGS.
8094 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8095 with value as argument.
8096 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8097 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8098 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8099 "changed".
8100
8101 * xgselect.c: Add defined (HAVE_GSETTINGS).
8102 (xgselect_initialize): Ditto.
8103
8104 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8105 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8106 xg_select.
8107
bbc6b304
PE
81082011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8109
8110 * eval.c (struct backtrace): Simplify and port the data structure.
8111 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8112 signed bit field, as this assumption is not portable and it makes
8113 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8114 "char debug_on_exit : 1" as this is not portable either; instead,
8115 use the portable "unsigned int debug_on_exit : 1". Remove unused
8116 member evalargs. Remove obsolete comments about cc bombing out.
8117
9851bfc5
JD
81182011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8119
51bb811f 8120 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8121 Let HAVE_GSETTINGS override HAVE_GCONF.
8122 (store_monospaced_changed): New function.
8123 (EMACS_SETTINGS): A new type derived from GObject to handle
8124 GSettings notifications.
8125 (emacs_settings_constructor, emacs_settings_get_property)
8126 (emacs_settings_set_property, emacs_settings_class_init):
8127 New functions.
8128 (gsettings_client, gsettings_obj): New variables.
8129 (GSETTINGS_SCHEMA): New define.
8130 (something_changedCB): Call store_monospaced_changed.
8131 (init_gsettings): New function.
8132 (xsettings_initialize): Call init_gsettings.
8133 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8134 to NULL.
8135
640c8776 8136 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8137 GCONF_CFLAGS/LIBS.
8138
5386012d
MR
81392011-06-29 Martin Rudalics <rudalics@gmx.at>
8140
8141 * window.c (resize_root_window, grow_mini_window)
8142 (shrink_mini_window): Rename Qresize_root_window to
8143 Qwindow_resize_root_window and Qresize_root_window_vertically to
8144 Qwindow_resize_root_window_vertically.
8145
f13e0b08
PE
81462011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8147
8148 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8149
94515237
JB
81502011-06-27 Juanma Barranquero <lekktu@gmail.com>
8151
8152 * makefile.w32-in: Redesign dependencies so they reflect more
8153 clearly which files are directly included by each source file,
8154 and not through other includes.
8155
e43b6e43
MR
81562011-06-27 Martin Rudalics <rudalics@gmx.at>
8157
8158 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8159 (sort_overlays, overlay_strings): When an overlay's clone number
8160 matches the window's clone number process the overlay even if
8161 the overlay's window property doesn't match the current window.
8162
d68443dc
MR
8163 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8164 (Fwindow_hchild): Rename to Fwindow_left_child.
8165 (Fwindow_next): Rename to Fwindow_next_sibling.
8166 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8167 (resize_window_check): Rename to window_resize_check.
8168 (resize_window_apply): Rename to window_resize_apply.
8169 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8170 (Fdelete_other_windows_internal, resize_frame_windows)
8171 (Fsplit_window_internal, Fdelete_window_internal)
8172 (grow_mini_window, shrink_mini_window)
8173 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8174
c7e73be5
JD
81752011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8176
8177 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8178 (emacs_fixed_set_min_size): Remove.
8179 (emacs_fixed_new): Take frame as argument.
8180
8181 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8182 (_EmacsFixedPrivate): Remove minwidth/height.
8183 Add struct frame *f.
8184 (emacs_fixed_init): Initialize priv->f.
8185 (get_parent_class, emacs_fixed_set_min_size): Remove.
8186 (emacs_fixed_new): Set priv->f to argument.
8187 (emacs_fixed_get_preferred_width)
8188 (emacs_fixed_get_preferred_height): Use min_width/height from
8189 frames size_hint to set minimum and natural (Bug#8919).
8190 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8191 and use min_width/height from frames size_hint to set
8192 min_width/height (Bug#8919).
8193
8194 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8195 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8196 Fix indentation.
c7e73be5 8197
cf99dcf8
EZ
81982011-06-26 Eli Zaretskii <eliz@gnu.org>
8199
8200 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8201 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8202 called at ZV.
8203
029529ac
CY
82042011-06-26 Chong Yidong <cyd@stupidchicken.com>
8205
8206 * process.c (wait_reading_process_output): Bypass select if
8207 waiting for a cell while ignoring keyboard input, and input is
8208 pending. Suggested by Jan Djärv (Bug#8869).
8209
7a7ef429
PE
82102011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8211
8212 Use gnulib's dup2 module instead of rolling our own.
8213 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8214
11fdef7d 82152011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8216
8217 * dispnew.c (scrolling_window): Before scrolling, turn off a
8218 mouse-highlight in the window being scrolled.
8219
cd3520a4
JB
82202011-06-24 Juanma Barranquero <lekktu@gmail.com>
8221
8222 Move DEFSYM to lisp.h and use everywhere.
8223
8224 * character.h (DEFSYM): Move declaration...
8225 * lisp.h (DEFSYM): ...here.
8226
8227 * gnutls.c:
8228 * minibuf.c:
8229 * w32menu.c:
8230 * w32proc.c:
8231 * w32select.c: Don't include character.h.
8232
8233 * alloc.c (syms_of_alloc):
8234 * buffer.c (syms_of_buffer):
8235 * bytecode.c (syms_of_bytecode):
8236 * callint.c (syms_of_callint):
8237 * casefiddle.c (syms_of_casefiddle):
8238 * casetab.c (init_casetab_once):
8239 * category.c (init_category_once, syms_of_category):
8240 * ccl.c (syms_of_ccl):
8241 * cmds.c (syms_of_cmds):
8242 * composite.c (syms_of_composite):
8243 * dbusbind.c (syms_of_dbusbind):
8244 * dired.c (syms_of_dired):
8245 * dispnew.c (syms_of_display):
8246 * doc.c (syms_of_doc):
8247 * editfns.c (syms_of_editfns):
8248 * emacs.c (syms_of_emacs):
8249 * eval.c (syms_of_eval):
8250 * fileio.c (syms_of_fileio):
8251 * fns.c (syms_of_fns):
8252 * frame.c (syms_of_frame):
8253 * fringe.c (syms_of_fringe):
8254 * insdel.c (syms_of_insdel):
8255 * keymap.c (syms_of_keymap):
8256 * lread.c (init_obarray, syms_of_lread):
8257 * macros.c (syms_of_macros):
8258 * msdos.c (syms_of_msdos):
8259 * print.c (syms_of_print):
8260 * process.c (syms_of_process):
8261 * search.c (syms_of_search):
8262 * sound.c (syms_of_sound):
8263 * syntax.c (init_syntax_once, syms_of_syntax):
8264 * terminal.c (syms_of_terminal):
8265 * textprop.c (syms_of_textprop):
8266 * undo.c (syms_of_undo):
8267 * w32.c (globals_of_w32):
8268 * window.c (syms_of_window):
8269 * xdisp.c (syms_of_xdisp):
8270 * xfaces.c (syms_of_xfaces):
8271 * xfns.c (syms_of_xfns):
8272 * xmenu.c (syms_of_xmenu):
8273 * xsettings.c (syms_of_xsettings):
8274 * xterm.c (syms_of_xterm): Use DEFSYM.
8275
4228cf16
TZ
82762011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8277
cd3520a4 8278 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8279
7fcccf1e
PE
82802011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8281
7efb4e0e
PE
8282 Integer and buffer overflow fixes (Bug#8873).
8283
ff5844ad
PE
8284 * print.c (printchar, strout): Check for string overflow.
8285 (PRINTPREPARE, printchar, strout):
8286 Don't set size unless allocation succeeds.
8287
90532f02
PE
8288 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8289 for sizes. Check for string overflow more accurately.
8290 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8291
6d84508d
PE
8292 * macros.c: Integer and buffer overflow fixes.
8293 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8294 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8295 Use ptrdiff_t, not int, for sizes.
8296 Don't increment bufsize until after realloc succeeds.
8297 Check for size-calculation overflow.
8298 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8299
437b2cb4
PE
8300 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8301
8b9ac8b4
PE
8302 * lread.c: Integer overflow fixes.
8303 (read_integer): Radix is now EMACS_INT, not int,
8304 to improve quality of diagnostics for out-of-range radices.
8305 Calculate buffer size correctly for out-of-range radices.
8306 (read1): Check for integer overflow in radices, and in
8307 read-circle numbers.
82cb60d3
PE
8308 (read_escape): Avoid int overflow.
8309 (Fload, openp, read_buffer_size, read1)
8310 (substitute_object_recurse, read_vector, read_list, map_obarray):
8311 Use ptrdiff_t, not int, for sizes.
8312 (read1): Use EMACS_INT, not int, for sizes.
20270765 8313 Check for size overflow.
8b9ac8b4 8314
7fcccf1e
PE
8315 * image.c (cache_image): Check for size arithmetic overflow.
8316
bfbbd7e7
PE
8317 * lread.c: Integer overflow issues.
8318 (saved_doc_string_size, saved_doc_string_length)
8319 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8320 Now ptrdiff_t, not int.
8321 (read1): Don't assume doc string length fits in int. Check for
8322 out-of-range doc string lengths.
8323 (read_list): Don't assume file position fits in int.
39019e54 8324 (read_escape): Check for hex character overflow.
bfbbd7e7 8325
4e323265
LL
83262011-06-22 Leo Liu <sdl.web@gmail.com>
8327
8328 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8329 Move to minibuffer.el.
8330
85fece3e
PE
83312011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8332
20b84ce9 8333 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8334 The following patches are for when GLYPH_DEBUG && !XASSERT.
8335 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8336 * dispnew.c (flush_stdout):
8337 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8338 Mark as externally visible.
8339 * dispnew.c (check_window_matrix_pointers): Now static.
8340 * dispnew.c (window_to_frame_vpos):
8341 * xfns.c (unwind_create_frame):
8342 * xterm.c (x_check_font): Remove unused local.
8343 * scroll.c (CHECK_BOUNDS):
8344 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8345 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8346 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8347 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8348 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8349 Now static.
8350 (debug_method_add): Use va_list and vsprintf rather than relying
8351 on undefined behavior with wrong number of arguments.
8352 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8353 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8354 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8355 since we're not interested in debugging glyphs with old libraries.
8356 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8357 GCC 4.6.0's static checking.
8358
0766b489
PE
83592011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8360
31fd4b32
PE
8361 Integer overflow and signedness fixes (Bug#8873).
8362 A few related buffer overrun fixes, too.
8363
b79e8648
PE
8364 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8365
0766b489
PE
8366 * dispextern.h (struct face.stipple):
8367 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8368 (x_bitmap_mask, x_allocate_bitmap_record)
8369 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8370 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8371 (x_create_bitmap_from_xpm_data):
8372 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8373 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8374 (.bitmaps_last):
8375 * xfaces.c (load_pixmap):
8376 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8377 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8378 (.bitmaps_last, struct x_output.icon_bitmap):
8379 Use ptrdiff_t, not int, for bitmap indexes.
8380 (x_allocate_bitmap_record): Check for size overflow.
8381 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8382
b081724f
PE
8383 Use ptrdiff_t, not int, for overlay counts.
8384 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8385 * editfns.c (overlays_around, get_pos_property):
8386 * textprop.c (get_char_property_and_overlay):
8387 * xdisp.c (next_overlay_change, note_mouse_highlight):
8388 * xfaces.c (face_at_buffer_position):
21514da7
PE
8389 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8390 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8391 (Fnext_overlay_change, Fprevious_overlay_change)
8392 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8393 Use ptrdiff_t, not int, for sizes.
21514da7 8394 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8395
3de73e5e
PE
8396 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8397
2606c57b
PE
8398 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8399 (x_session_initialize): Do not assume string length fits in int.
8400
aaafe47a
PE
8401 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8402 This is unlikely, but can occur if DPI is outlandish.
8403
2674ddc8 8404 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8405 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8406
28154962
PE
8407 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8408 * xrdb.c (magic_file_p, search_magic_path):
8409 Omit last arg SUFFIX; it was always 0. All callers changed.
8410 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8411
7de51af5
PE
8412 * xfont.c (xfont_match): Avoid need for strlen.
8413
25ed6cc3
PE
8414 * xfns.c: Don't assume strlen fits in int.
8415 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8416
4eab31dd
PE
8417 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8418 not unsigned long, as we prefer signed integers. All callers changed.
8419 Detect integer overflow in repeat count.
8420 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8421 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8422
171e2a58
PE
8423 * termcap.c: Don't assume sizes fit in int and never overflow.
8424 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8425 (gobble_line): Check for size-calculation overflow.
8426
ad39faca 8427 * minibuf.c (Fread_buffer):
6e5bb2dc 8428 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8429 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8430 Don't assume string length fits in int.
8431
52c61c22 8432 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8433 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8434
b5b8c9e5
PE
8435 * font.c: Don't assume string length fits in int.
8436 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8437 Use ptrdiff_t, not int.
ccd6111c
PE
8438 (font_intern_prop): Don't assume string length fits in int.
8439 Don't assume integer property fits in fixnum.
8440 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8441
882f0d81 8442 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8443 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8444 Reformulate so as not to need the command string.
8445 Invoke gzip -cd rather than gunzip, as it's more portable.
8446 (lock_info_type, lock_file_1, lock_file):
8447 Don't assume pid_t and time_t fit in unsigned long.
8448 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8449 (current_lock_owner): Prefer signed type for sizes.
8450 Use memcpy, not strncpy, where memcpy is what is really wanted.
8451 Don't assume (via atoi) that time_t and pid_t fit in int.
8452 Check for time_t and/or pid_t out of range, e.g., via a network share.
8453 Don't alloca where an auto var works fine.
8454
93f4cf88
PE
8455 * fileio.c: Fix some integer overflow issues.
8456 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8457 Don't assume string length fits in int.
8458 (directory_file_name): Don't assume string length fits in long.
8459 (make_temp_name): Don't assume pid fits in int, or that its print
8460 length is less than 20.
8461
f3e92b69
PE
8462 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8463
1bfdaf10
PE
8464 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8465
35016e9a
PE
8466 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8467
3d1e65a1
PE
8468 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8469 We prefer signed integers, even for size calculations.
8470
0b963a93
PE
8471 * emacs.c: Don't assume string length fits in 'int'.
8472 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8473 (main): Don't invoke strlen when not needed.
8474
573f4b54
PE
8475 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8476 (XD_DEBUG_MESSAGE): Don't waste a byte.
8477
989f33ba
PE
8478 * callproc.c (getenv_internal_1, getenv_internal)
8479 (Fgetenv_internal):
965d34eb
PE
8480 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8481
e4d29b33
PE
8482 * lread.c (invalid_syntax): Omit length argument.
8483 All uses changed. This doesn't fix a bug, but it simplifies the
8484 code away from its former Hollerith-constant appearance, and it's
8485 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8486 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8487
eb49b136
PE
8488 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8489 This didn't break anything, but it didn't help either.
8490 It's confusing to put a bogus integer in a place where the actual
8491 value does not matter.
9f62aeb1 8492 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8493 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8494
15375a22
PE
8495 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8496 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8497 implementation.
b61cc01c
PE
8498 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8499 We prefer signed types, and the value cannot exceed the EMACS_INT
8500 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8501 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8502 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8503 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8504
53b2623d
PE
8505 * indent.c (sane_tab_width): New function.
8506 (current_column, scan_for_column, Findent_to, position_indentation)
8507 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8508 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8509
51cab52b 8510 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8511
f2ed8a70
PE
8512 * lisp.h (lint_assume): New macro.
8513 * composite.c (composition_gstring_put_cache):
8514 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8515
abe80cc6
PE
8516 * editfns.c, insdel.c:
8517 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8518
b02c740e
PE
8519 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8520
ebc96716
PE
8521 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8522
b4e50fa0 8523 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8524 Use much-faster test for byte-length change.
311d5d7c 8525 Don't assume string byte-length fits in 'int'.
a4cf38e4 8526 Check that character arg fits in 'int'.
85461888 8527 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8528
c0c1ee9f
PE
8529 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8530
a498d7f4
PE
8531 * fns.c (concat): Catch string overflow earlier.
8532 Do not rely on integer wraparound.
8533
51cab52b
PE
8534 * dispextern.h (struct it.overlay_strings_charpos)
8535 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8536 * xdisp.c (forward_to_next_line_start)
8537 (back_to_previous_visible_line_start)
8538 (reseat_at_next_visible_line_start, next_element_from_buffer):
8539 Don't arbitrarily truncate the value of 'selective' to int.
8540
76031fad
PE
8541 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8542
5eb55db9
PE
8543 * composite.c: Don't truncate sizes to 'int'.
8544 (composition_gstring_p, composition_reseat_it)
8545 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8546 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8547 not EMACS_UINT, for indexes.
5eb55db9 8548
0703a717
PE
8549 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8550
d6202519
PE
8551 * buffer.c: Include <verify.h>.
8552 (struct sortvec.priority, struct sortstr.priority):
8961a454 8553 Now EMACS_INT, not int.
c20998a7 8554 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8555 (struct sortstr.size, record_overlay_string)
8556 (struct sortstrlist.size, struct sortlist.used):
8557 Don't truncate size to int.
8558 (record_overlay_string): Check for size-calculation overflow.
d6202519 8559 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8560
d5a19415
JM
85612011-06-22 Jim Meyering <meyering@redhat.com>
8562
029529ac 8563 Don't leak an XBM-image-sized buffer
d5a19415
JM
8564 * image.c (xbm_load): Free the image buffer after using it.
8565
a9041e6c
PE
85662011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8567
8568 Port to Sun C.
8569 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8570 that Sun C diagnosed.
8571 * fns.c (secure_hash): Fix pointer signedness issue.
8572 * intervals.c (static_offset_intervals): New function.
8573 (offset_intervals): Use it.
8574
7f3f739f
LL
85752011-06-21 Leo Liu <sdl.web@gmail.com>
8576
8577 * deps.mk (fns.o):
8578 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8579 sha512.h.
8580
8581 * fns.c (secure_hash): Rename from crypto_hash_function and change
8582 the first arg to accept symbols.
5b66d427 8583 (Fsecure_hash): New primitive.
7f3f739f
LL
8584 (syms_of_fns): New symbols.
8585
76147d94
DD
85862011-06-20 Deniz Dogan <deniz@dogan.se>
8587
8588 * process.c (Fset_process_buffer): Clarify return value in
8589 docstring.
8590
7d7d0045
CY
85912011-06-18 Chong Yidong <cyd@stupidchicken.com>
8592
8593 * dispnew.c (add_window_display_history): Use BVAR.
8594
8595 * xdisp.c (debug_method_add): Use BVAR.
8596 (check_window_end, dump_glyph_matrix, dump_glyph)
8597 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8598
8599 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8600 Likewise.
8601
8602 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8603 check till after the cache is created in init_frame_faces.
8604
ff2bc410
SM
86052011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8606
8607 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8608
28177add
PE
86092011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8610
dd3482fe
PE
8611 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8612 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8613 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8614
393d71f3 8615 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8616 * fileio.c (Finsert_file_contents):
8617 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8618 Remove the old (too-loose) buffer overflow checks.
8619 They weren't needed, since make_gap checks for buffer overflow.
8620 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8621 The old code merely checked for Emacs fixnum overflow, and relied
8622 on undefined (wraparound) behavior. The new code avoids undefined
8623 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8624
2e6813b0 8625 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8626 Tune. Don't use wider integers than needed. Don't use alloca.
8627 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8628
599a9e4f
PE
8629 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8630
99561444
PE
8631 * insdel.c, lisp.h (buffer_overflow): New function.
8632 (insert_from_buffer_1, replace_range, replace_range_2):
8633 * insdel.c (make_gap_larger):
8634 * editfns.c (Finsert_char):
8635 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8636
28177add
PE
8637 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8638
e69dafad
PE
86392011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8640
4baa020d 8641 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8642
b1c46f02
PE
8643 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8644 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8645
e69dafad
PE
8646 * fileio.c: Don't assume EMACS_INT fits in off_t.
8647 (emacs_lseek): New static function.
8648 (Finsert_file_contents, Fwrite_region): Use it.
8649 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8650
566684ea
PE
8651 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8652
e6966cd6
PE
8653 * fns.c: Don't overflow int when computing a list length.
8654 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8655 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8656 truncation on 64-bit hosts. Check for QUIT every
8657 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8658 faster and is responsive enough.
8659 (Flength): Report an error instead of overflowing an integer.
8660 (Fsafe_length): Return a float if the value is not representable
8661 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8662 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8663 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8664
dd0b0efb
PE
8665 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8666 (header_size, word_size): New constants.
8667 (allocate_vectorlike): Don't check size overflow here.
8668 (allocate_vector): Check it here instead, since this is the only
8669 caller of allocate_vectorlike that could cause overflow.
8670 Check that the new vector's length is representable as a fixnum.
8671
86fe5cfe
PE
8672 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8673 The previous code was bogus. For example, next_almost_prime (32)
8674 returned 39, which is undesirable as it is a multiple of 3; and
8675 next_almost_prime (24) returned 25, which is a multiple of 5 so
8676 why was the code bothering to check for multiples of 7?
8677
80e88859
PE
8678 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8679
4a2f0ad6
PE
8680 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8681
f66c7cf8
PE
8682 Variadic C functions now count arguments with ptrdiff_t.
8683 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8684 Back then I didn't know that the Emacs coding style prefers signed int.
8685 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8686 were being counted with int, which may truncate counts on 64-bit
8687 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8688 * lisp.h (struct Lisp_Subr.function.aMANY)
8689 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8690 Arg counts are now ptrdiff_t, not size_t.
8691 All variadic functions and their callers changed accordingly.
8692 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8693 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8694 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8695 * callint.c (Fcall_interactively): Check arg count for overflow,
8696 to avoid potential buffer overrun. Use signed char, not 'int',
8697 for 'varies' array, so that we needn't bother to check its size
8698 calculation for overflow.
8699 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8700 * eval.c (apply_lambda):
8701 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8702 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8703 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8704
a1759b76
PE
8705 * callint.c (Fcall_interactively): Don't use index var as event count.
8706
d96be9fc
PE
8707 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8708 * mem-limits.h (SIZE): Remove; no longer used.
8709
a690a978 8710 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8711
578c21e6
PE
8712 Remove unnecessary casts.
8713 * xterm.c (x_term_init):
8714 * xfns.c (x_set_border_pixel):
8715 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8716 These aren't needed now that we assume ANSI C.
8717
96f53c6c
PE
8718 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8719 It's more likely to cause problems (due to unsigned overflow)
8720 than to cure them.
8721
83c77d31
PE
8722 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8723
ee2079f1
PE
8724 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8725
6da65536
PE
8726 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8727
7147c4a4
PE
8728 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8729
193e32d9
PE
8730 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8731
e5533da6
PE
8732 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8733
9910e595
PE
8734 GLYPH_CODE_FACE returns EMACS_INT, not int.
8735 * dispextern.h (merge_faces):
8736 * xfaces.c (merge_faces):
01103c44
PE
8737 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8738 Don't assume EMACS_INT fits in int.
9910e595 8739
2638320e
PE
8740 * character.h (CHAR_VALID_P): Remove unused parameter.
8741 * fontset.c, lisp.h, xdisp.c: All uses changed.
8742
045eb8d9
PE
8743 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8744
c1f134b5
PE
8745 * fns.c (concat): Minor tuning based on overflow analysis.
8746 This doesn't fix any bugs. Use int to hold character, instead
8747 of constantly refetching from Emacs object. Use XFASTINT, not
8748 XINT, for value known to be a character. Don't bother comparing
8749 a single byte to 0400, as it's always less.
8750
395fcb93 8751 * floatfns.c (Fexpt):
327eeec8
PE
8752 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8753
abbd3d23
PE
8754 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8755 for characters.
8756
684a03ef
PE
8757 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8758
0fed43f3
PE
8759 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8760 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8761 incorrectly succeed when S was a string, because 4294967386 was
8762 truncated before it was used.
8763
8fd02eb7
PE
8764 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8765 Otherwise, an out-of-range integer could cause undefined behavior
8766 on a 64-bit host.
8767
f8c86b69
PE
8768 * composite.c: Use int, not EMACS_INT, for characters.
8769 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8770 EMACS_INT, for values that are known to be in character range.
8771 This doesn't fix any bugs but is the usual style inside Emacs and
8772 may generate better code on 32-bit machines.
8773
34206dd2
PE
8774 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8775 This is for reasons similar to the recent CHAR_STRING fix.
8776 * charset.c (Fencode_char): Check that character arg is actually
8777 a character. Pass an int to ENCODE_CHAR.
8778 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8779 wider than 'int', as a compile-time check to prevent future regressions
8780 in this area.
8781
c5958d4c 8782 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8783
8784 Make sure a 64-bit char is never passed to CHAR_STRING.
8785 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8786 by silently ignoring the top 32 bits, allowing some values
8787 that were far too large to be valid characters.
8788 * character.h: Include <verify.h>.
8789 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8790 arguments are no wider than unsigned, as a compile-time check
8791 to prevent future regressions in this area.
8792 * data.c (Faset):
01103c44 8793 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8794 (Fsubst_char_in_region):
8795 * fns.c (concat):
8796 * xdisp.c (decode_mode_spec_coding):
8797 Adjust to CHAR_STRING's new requirement.
8798 * editfns.c (Finsert_char, Fsubst_char_in_region):
8799 * fns.c (concat): Check that character args are actually
8800 characters. Without this test, these functions did the wrong
8801 thing with wildly out-of-range values on 64-bit hosts.
8802
d37ca623
PE
8803 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8804 These casts should not be needed on 32-bit hosts, either.
8805 * keyboard.c (read_char):
8806 * lread.c (Fload): Remove casts to unsigned.
8807
ea204efb
PE
8808 * lisp.h (UNSIGNED_CMP): New macro.
8809 This fixes comparison bugs on 64-bit hosts.
8810 (ASCII_CHAR_P): Use it.
8811 * casefiddle.c (casify_object):
01103c44 8812 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8813 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8814 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8815 * dispextern.h (FACE_FROM_ID):
8816 * keyboard.c (read_char): Use UNSIGNED_CMP.
8817
41cb286c
PE
8818 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8819 not to EMACS_INT, to avoid GCC warning.
8820
4a1b9832
PE
8821 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8822
55daad71
PE
8823 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8824 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8825 isn't needed on 32-bit machines.
8f95c75c 8826
01103c44
PE
8827 * buffer.c (Fgenerate_new_buffer_name):
8828 Use EMACS_INT for count, not int.
0ceccced 8829 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8830
8831 * data.c (Qcompiled_function): Now static.
8832
c6f072e7
PE
8833 * window.c (window_body_lines): Now static.
8834
20ce5912
PE
8835 * image.c (gif_load): Rename local to avoid shadowing.
8836
9c4c5f81
PE
8837 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8838 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8839 * alloc.c (make_save_value): Integer argument is now of type
8840 ptrdiff_t, not int.
8841 (mark_object): Use ptrdiff_t, not int.
8842 * lisp.h (pD): New macro.
8843 * print.c (print_object): Use it.
8844
c0c5c8ae
PE
8845 * alloc.c: Use EMACS_INT, not int, to count objects.
8846 (total_conses, total_markers, total_symbols, total_vector_size)
8847 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8848 (total_free_floats, total_floats, total_free_intervals)
8849 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8850 Now EMACS_INT, not int. All uses changed.
8851 (Fgarbage_collect): Compute overall total using a double, so that
8852 integer overflow is less likely to be a problem. Check for overflow
8853 when converting back to an integer.
5a25e253
PE
8854 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8855 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8856 These were 'int' variables that could overflow on 64-bit hosts;
8857 they were never used, so remove them instead of repairing them.
211a0b2a 8858 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8859 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8860 Previously, this ceilinged at INT_MAX, but that doesn't work on
8861 64-bit machines.
e46bb31a 8862 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8863
c78baabf 8864 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8865 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8866 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8867 when a (possibly-narrower) signed value would do just as well.
8868 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8869
c9d624c6
PE
8870 * alloc.c: Catch some string size overflows that we were missing.
8871 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8872 for convenience in STRING_BYTES_MAX.
8873 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8874 The definition here is exact; the one in lisp.h was approximate.
8875 (allocate_string_data): Check for string overflow. This catches
8876 some instances we weren't catching before. Also, it catches
8877 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8878 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8879 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8880
c9d624c6
PE
8881 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8882 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8883 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8884
353032ce
PE
8885 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8886
2bccce07
PE
8887 * alloc.c (Fmake_string): Check for out-of-range init.
8888
0ac30604
SM
88892011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8890
8891 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8892
c195f2de
JD
88932011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8894
8895 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8896 xg_get_default_scrollbar_width.
8897
8898 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8899 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8900 (style_changed_cb): Call update_theme_scrollbar_width and call
8901 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8902 all frames (Bug#8505).
8903 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8904 Call gtk_window_set_resizable if HAVE_GTK3.
8905 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8906 and height if HAVE_GTK3 (Bug#8505).
8907 (scroll_bar_width_for_theme): New variable.
8908 (update_theme_scrollbar_width): New function.
8909 (xg_get_default_scrollbar_width): Move code to
8910 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8911 (xg_initialize): Call update_theme_scrollbar_width.
8912
8913 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8914
8915 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8916
e10ac9f1
MR
89172011-06-12 Martin Rudalics <rudalics@gmx.at>
8918
8919 * frame.c (make_frame): Call other_buffer_safely instead of
8920 other_buffer.
8921
8922 * window.c (temp_output_buffer_show): Call display_buffer with
8923 second argument Vtemp_buffer_show_specifiers and reset latter
8924 immediately after the call.
8925 (Vtemp_buffer_show_specifiers): New variable.
8926 (auto_window_vscroll_p, next_screen_context_lines)
8927 (Vscroll_preserve_screen_position): Remove leading asterisks from
8928 doc-strings.
8929
2d3c217e 89302011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8931
7b7f97e8 8932 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8933 * buffer.c (Qclone_number): Remove for now, as it's unused.
8934 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8935 (record_buffer): Remove unused local.
8936 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8937 (set_frame_buffer_list): Remove; unused.
8938 * frame.h (other_visible_frames): Remove decl.
8939 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8940 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8941 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8942 if HAVE_GPM.
8943 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8944 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8945 Define only if HAVE_GPM.
8946 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8947 (update_hints_inhibit): Remove; never set. All uses removed.
8948 * widgetprv.h (emacsFrameClassRec): Remove decl.
8949 * window.c (delete_deletable_window): Now returns void, since it
8950 wasn't returning anything.
8951 (compare_window_configurations): Remove unused locals.
8952 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8953 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8954 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8955 the same widths as pointers. This follows up on the 2011-05-06 patch.
8956 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8957 * xterm.h: Likewise.
8958 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8959
1384b89e
JB
89602011-06-12 Juanma Barranquero <lekktu@gmail.com>
8961
8962 * makefile.w32-in: Update dependencies.
8963 (LISP_H): Add lib/intprops.h.
8964
1100a63c
CY
89652011-06-11 Chong Yidong <cyd@stupidchicken.com>
8966
8967 * image.c (gif_load): Add animation frame delay to the metadata.
8968 (syms_of_image): Use DEFSYM. New symbol `delay'.
8969
6198ccd0
MR
89702011-06-11 Martin Rudalics <rudalics@gmx.at>
8971
8972 * window.c (delete_deletable_window): Re-add.
8973 (Fset_window_configuration): Rewrite to handle dead buffers and
8974 consequently deletable windows.
8975 (window_tree, Fwindow_tree): Remove. Supply functionality in
8976 window.el.
8977 (compare_window_configurations): Simplify code.
8978
b6e3633c
AS
89792011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8980
1ab0dee5
AS
8981 * image.c (imagemagick_load_image): Fix type mismatch.
8982 (Fimagemagick_types): Likewise.
8983
b6e3633c
AS
8984 * window.h (replace_buffer_in_windows): Declare.
8985
9397e56f
MR
89862011-06-11 Martin Rudalics <rudalics@gmx.at>
8987
8988 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8989 Qclone_number. Remove external declaration of Qdelete_window.
8990 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8991 code.
640c8776
SM
8992 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8993 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8994 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8995 buffer list implementation.
8996 (other_buffer_safely): New function.
8997 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8998 calls to replace_buffer_in_windows and
8999 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9000 if allowed.
9001 (record_buffer): Inhibit quitting and rewrite using quittable
9002 functions. Run Qbuffer_list_update_hook if allowed.
9003 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9004 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9005 Move switch-to-buffer to window.el.
9397e56f
MR
9006 (bury-buffer): Move to window.el.
9007 (Vbuffer_list_update_hook): New variable.
9008
9009 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9010 section.
9011
9012 * window.h (resize_frame_windows): Move up in code.
9013 (Fwindow_frame): Remove EXFUN.
9014 (replace_buffer_in_all_windows): Remove prototype.
9015 (replace_buffer_in_windows_safely): Add prototype.
9016
9017 * window.c: Declare Qdelete_window static again. Move down
9018 declaration of select_count.
9019 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9020 (Fother_window): Move to window.el.
9021 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9022 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9023 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9024 window.el.
9025 (replace_buffer_in_windows): Implement by calling
9026 Qreplace_buffer_in_windows.
9027 (replace_buffer_in_all_windows): Remove with some functionality
9028 moved into replace_buffer_in_windows_safely.
9029 (replace_buffer_in_windows_safely): New function.
9030 (select_window_norecord, select_frame_norecord): Move in front
9031 of run_window_configuration_change_hook. Remove now obsolete
9032 declarations.
640c8776
SM
9033 (Fset_window_buffer): Rewrite doc-string.
9034 Call Qrecord_window_buffer.
9397e56f
MR
9035 (keys_of_window): Move binding for other-window to window.el.
9036
b50691aa
CY
90372011-06-11 Chong Yidong <cyd@stupidchicken.com>
9038
9039 * dispextern.h (struct image): Replace data member, whose int_val
9040 and ptr_val fields were not used by anything, with a single
9041 lisp_val object.
9042
9043 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9044 (gif_clear_image, gif_load, imagemagick_load_image)
9045 (gs_clear_image, gs_load): Callers changed.
9046
3f754b86
PE
90472011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9048
cca69397
PE
9049 * buffer.h: Include <time.h>, for time_t.
9050 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9051
109e28d0
PE
9052 Fix minor problems found by static checking.
9053
60737f02
PE
9054 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9055
4b66faf3
PE
9056 Make identifiers static if they are not used in other modules.
9057 * data.c (Qcompiled_function, Qframe, Qvector):
9058 * image.c (QimageMagick, Qsvg):
9059 * minibuf.c (Qmetadata):
9060 * window.c (resize_window_check, resize_root_window): Now static.
9061 * window.h (resize_window_check, resize_root_window): Remove decls.
9062
109e28d0
PE
9063 * window.c (window_deletion_count, delete_deletable_window):
9064 Remove; unused.
46a4ce9e
PE
9065 (window_body_lines): Now static.
9066 (Fdelete_other_windows_internal): Mark vars as initialized.
9067 Make sure 'resize_failed' is initialized.
9068 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9069 (resize_window_apply): Remove unused local.
9070 * window.h (delete_deletable_window): Remove decl.
9071
109e28d0 9072 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9073 (imagemagick_load_image): Fix pointer signedness problem by changing
9074 last arg from unsigned char * to char *. All uses changed.
9075 Also, fix a local for similar reasons.
9076 Remove unused locals. Remove locals to avoid shadowing.
9077 (fn_rsvg_handle_free): Remove; unused.
9078 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9079 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9080
3f754b86
PE
9081 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9082
2547adb1
CY
90832011-06-10 Chong Yidong <cyd@stupidchicken.com>
9084
9085 * image.c (gif_load): Fix omitted cast error introduced by
9086 2011-06-06 change.
9087
2c8e37d4
MR
90882011-06-10 Martin Rudalics <rudalics@gmx.at>
9089
9090 * window.h (resize_proportionally, orig_total_lines)
9091 (orig_top_line): Remove from window structure.
9092 (set_window_height, set_window_width, change_window_heights)
9093 (Fdelete_window): Remove prototypes.
9094 (resize_frame_windows): Remove duplicate declaration.
9095
440a42e3
EZ
90962011-06-10 Eli Zaretskii <eliz@gnu.org>
9097
9098 * window.h (resize_frame_windows, resize_window_check)
9099 (delete_deletable_window, resize_root_window)
9100 (resize_frame_windows): Declare prototypes.
9101
9102 * window.c (resize_window_apply): Make definition be "static" to
9103 match the prototype.
9104
562dd5e9
MR
91052011-06-10 Martin Rudalics <rudalics@gmx.at>
9106
9107 * window.c: Remove declarations of Qwindow_size_fixed,
9108 window_min_size_1, window_min_size_2, window_min_size,
9109 size_window, window_fixed_size_p, enlarge_window, delete_window.
9110 Remove static from declaration of Qdelete_window, it's
9111 temporarily needed by Fbury_buffer.
9112 (replace_window): Don't assign orig_top_line and
9113 orig_total_lines.
9114 (Fdelete_window, delete_window): Remove. Window deletion is
9115 handled by window.el.
640c8776
SM
9116 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9117 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9118 (Fdelete_other_windows): Remove. Deleting other windows is
9119 handled by window.el.
9120 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9121 handled in window.el.
9122 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9123 Window minimum sizes are handled in window.el.
9124 (shrink_windows, size_window, set_window_height)
9125 (set_window_width, change_window_heights, window_height)
9126 (window_width, CURBEG, CURSIZE, enlarge_window)
9127 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9128 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9129 handled in window.el.
9130 (make_dummy_parent): Rename to make_parent_window and give it a
9131 second argument horflag.
9132 (make_window): Don't set resize_proportionally any more.
9133 (Fsplit_window): Remove. Windows are split in window.el.
9134 (save_restore_action, save_restore_orig_size)
9135 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9136 Resize mini windows in window.el.
9137 (grow_mini_window, shrink_mini_window): Implement by calling
9138 Qresize_root_window_vertically, resize_window_check and
9139 resize_window_apply.
640c8776
SM
9140 (saved_window, Fset_window_configuration, save_window_save):
9141 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9142 resize_proportionally.
9143 (window_min_height, window_min_width): Move to window.el.
9144 (keys_of_window): Move bindings for delete-other-windows,
9145 split-window, delete-window and enlarge-window to window.el.
9146
9147 * buffer.c: Temporarily extern Qdelete_window.
9148 (Fbury_buffer): Temporarily call Qdelete_window instead of
9149 Fdelete_window (Fbury_buffer will move to window.el soon).
9150
9151 * frame.c (set_menu_bar_lines_1): Remove code handling
9152 orig_top_line and orig_total_lines.
9153
9154 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9155 set_window_height but set heights directly.
9156 (change_frame_size_1): Use resize_frame_windows.
9157
9158 * xdisp.c (init_xdisp): Don't use set_window_height but set
9159 heights directly.
9160
640c8776
SM
9161 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9162 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9163 run_window_configuration_change_hook.
9164
9165 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9166 instead of change_window_heights and run
9167 run_window_configuration_change_hook.
9168
1a13852e
MR
91692011-06-09 Martin Rudalics <rudalics@gmx.at>
9170
9171 * window.c (replace_window): Rename second argument REPLACEMENT to
9172 NEW. New third argument SETFLAG. Rewrite.
9173 (delete_window, make_dummy_parent): Call replace_window with
9174 third argument 1.
9175 (window_list_1): Move down in code.
9176 (run_window_configuration_change_hook): Move set_buffer part
9177 before select_frame_norecord part in order to unwind correctly.
9178 Rename count1 to count.
9179 (recombine_windows, delete_deletable_window, resize_root_window)
9180 (Fdelete_other_windows_internal)
9181 (Frun_window_configuration_change_hook, make_parent_window)
9182 (resize_window_check, resize_window_apply, Fresize_window_apply)
9183 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9184 (Fdelete_window_internal, Fresize_mini_window_internal):
9185 New functions.
1a13852e
MR
9186 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9187
f3d1777e
MR
91882011-06-08 Martin Rudalics <rudalics@gmx.at>
9189
496e208e
MR
9190 * window.h (window): Add some new members to window structure -
9191 normal_lines, normal_cols, new_total, new_normal, clone_number,
9192 splits, nest, prev_buffers, next_buffers.
9193 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9194 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9195
f3d1777e
MR
9196 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9197 Remove.
496e208e
MR
9198 (make_dummy_parent): Set new members of windows structure.
9199 (make_window): Move down in code. Handle new members of window
9200 structure.
9201 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9202 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9203 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9204 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9205 (Fset_window_next_buffers, Fset_window_clone_number):
9206 New functions.
496e208e
MR
9207 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9208 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9209 Doc-string fixes.
9210 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9211 Argument WINDOW can be now internal window too.
9212 (Fwindow_use_time): Move up in code.
9213 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9214 Rewrite doc-string.
9215 (Fset_window_configuration, saved_window)
9216 (Fcurrent_window_configuration, save_window_save): Handle new
9217 members of window structure.
b9e809c2
MR
9218 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9219 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9220 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9221 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9222 Qget_mru_window, Qresize_root_window,
9223 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9224 Qauto_buffer_name; staticpro them.
f3d1777e 9225
abde8f8c
MR
92262011-06-07 Martin Rudalics <rudalics@gmx.at>
9227
9228 * window.c (Fwindow_total_size, Fwindow_left_column)
9229 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9230 (Fwindow_list_1): New functions.
9231 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9232 (Fwindow_width, Fscroll_left, Fscroll_right):
9233 Use window_body_cols instead of window_box_text_cols.
9234 (delete_window, Fset_window_configuration):
9235 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9236 (delete_all_subwindows): Take a window as argument and not a
9237 structure. Rewrite.
190b47e6
MR
9238 (window_loop): Remove handling of GET_LRU_WINDOW and
9239 GET_LARGEST_WINDOW.
9240 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9241
9242 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9243 window_box_text_cols. delete_all_subwindows now takes a
9244 Lisp_Object as argument.
abde8f8c 9245
640c8776
SM
9246 * indent.c (compute_motion, Fcompute_motion):
9247 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9248
fa8a67e6
MR
9249 * frame.c (delete_frame): Call delete_all_subwindows with root
9250 window as argument.
9251
a54e3482
DC
92522011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9253
9254 * fns.c (Fputhash): Document return value.
9255
60002bf5
CY
92562011-06-06 Chong Yidong <cyd@stupidchicken.com>
9257
9258 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9259
0c671da6 92602011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9261
b862a52a 9262 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9263
be44ca6c
PE
9264 Check for overflow when converting integer to cons and back.
9265 * charset.c (Fdefine_charset_internal, Fdecode_char):
9266 Use cons_to_unsigned to catch overflow.
9267 (Fencode_char): Use INTEGER_TO_CONS.
9268 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9269 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9270 * data.c (long_to_cons, cons_to_long): Remove.
9271 (cons_to_unsigned, cons_to_signed): New functions.
9272 These signal an error for invalid or out-of-range values.
9273 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9274 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9275 * font.c (Ffont_variation_glyphs):
9276 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9277 * lisp.h: Include <intprops.h>.
9278 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9279 (cons_to_signed, cons_to_unsigned): New decls.
9280 (long_to_cons, cons_to_long): Remove decls.
9281 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9282 (Fprimitive_undo): Use CONS_TO_INTEGER.
9283 * xfns.c (Fx_window_property): Likewise.
9284 * xselect.c: Include <limits.h>.
9285 (x_own_selection, selection_data_to_lisp_data):
9286 Use INTEGER_TO_CONS.
9287 (x_handle_selection_request, x_handle_selection_clear)
9288 (x_get_foreign_selection, Fx_disown_selection_internal)
9289 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9290 (lisp_data_to_selection_data): Use cons_to_unsigned.
9291 (x_fill_property_data): Use cons_to_signed.
9292 Report values out of range.
9293
d1f3d2af
PE
9294 Check for buffer and string overflow more precisely.
9295 * buffer.h (BUF_BYTES_MAX): New macro.
9296 * lisp.h (STRING_BYTES_MAX): New macro.
9297 * alloc.c (Fmake_string):
9298 * character.c (string_escape_byte8):
9299 * coding.c (coding_alloc_by_realloc):
9300 * doprnt.c (doprnt):
9301 * editfns.c (Fformat):
9302 * eval.c (verror):
9303 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9304 since they may not be the same number.
9305 * editfns.c (Finsert_char):
9306 * fileio.c (Finsert_file_contents):
9307 Likewise for BUF_BYTES_MAX.
9308
dd52fcea
PE
9309 * image.c: Use ptrdiff_t, not int, for sizes.
9310 (slurp_file): Switch from int to ptrdiff_t.
9311 All uses changed.
9312 (slurp_file): Check that file size fits in both size_t (for
9313 malloc) and ptrdiff_t (for sanity and safety).
9314
7f9bbdbb
PE
9315 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9316 if b->modtime has its maximal value.
9317
dfe18f82
PE
9318 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9319
84acfcf0
PE
9320 Don't assume time_t can fit into int.
9321 * buffer.h (struct buffer.modtime): Now time_t, not int.
9322 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9323 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9324
ccd9a01a
PE
9325 Minor fixes for signed vs unsigned integers.
9326 * character.h (MAYBE_UNIFY_CHAR):
9327 * charset.c (maybe_unify_char):
9328 * keyboard.c (read_char, reorder_modifiers):
9329 XINT -> XFASTINT, since the integer must be nonnegative.
9330 * ftfont.c (ftfont_spec_pattern):
9331 * keymap.c (access_keymap, silly_event_symbol_error):
9332 XUINT -> XFASTINT, since the integer must be nonnegative.
9333 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9334 since it makes no difference and we prefer signed.
9335 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9336 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9337 nonnegative.
9338
d6d100dd
SM
93392011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9340
9341 * window.h (Fwindow_frame): Declare.
9342
2b6148e4
PE
93432011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9344
9345 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9346 (SPARE_MEMORY): Always define.
9347 (LARGE_REQUEST): Remove.
9348 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9349
f230ecc9
MR
93502011-06-06 Martin Rudalics <rudalics@gmx.at>
9351
727e958e
MR
9352 * lisp.h: Move EXFUNS for Fframe_root_window,
9353 Fframe_first_window and Fset_frame_selected_window to window.h.
9354
9355 * window.h: Move EXFUNS for Fframe_root_window,
9356 Fframe_first_window and Fset_frame_selected_window here from
9357 lisp.h.
9358
9359 * frame.c (Fwindow_frame, Fframe_first_window)
9360 (Fframe_root_window, Fframe_selected_window)
9361 (Fset_frame_selected_window): Move to window.c.
9362 (Factive_minibuffer_window): Move to minibuf.c.
9363 (Fother_visible_frames_p): New function.
9364
9365 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9366
f230ecc9
MR
9367 * window.c (decode_window, decode_any_window): Move up in code.
9368 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9369 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9370 (Fwindow_buffer): Move up and rewrite doc-string.
9371 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9372 (Fwindow_prev): New functions.
727e958e
MR
9373 (Fwindow_frame): Move here from frame.c. Accept any window as
9374 argument.
9375 (Fframe_root_window, Fframe_first_window)
9376 (Fframe_selected_window): Move here from frame.c. Accept frame
9377 or arbitrary window as argument. Update doc-strings.
9378 (Fminibuffer_window): Move up in code.
9379 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9380 (Fset_frame_selected_window): Move here from frame.c.
9381 Marginal rewrite.
727e958e
MR
9382 (Fselected_window, select_window, Fselect_window): Move up in
9383 code. Minor doc-string fixes.
f230ecc9 9384
4d09bcf6
PE
93852011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9386
9387 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9388 Do not assume that spare memory exists; that assumption is valid
9389 only if SYSTEM_MALLOC.
9390 (LARGE_REQUEST): New macro, so that the issue of large requests
9391 is separated from the issue of spare memory.
9392
810928a2
AS
93932011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9394
172418ad
AS
9395 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9396 format. (Bug#8806)
9397
43f862f7
AS
9398 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9399
810928a2
AS
9400 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9401 before statements.
9402
a059fe24
JD
94032011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9404
9405 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9406
9407 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9408
9409 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9410 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9411
989bf368
JB
94122011-06-05 Juanma Barranquero <lekktu@gmail.com>
9413
9414 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9415
4b80f674
CY
94162011-06-04 Chong Yidong <cyd@stupidchicken.com>
9417
9418 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9419 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9420 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9421 New error handlers.
4b80f674
CY
9422 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9423 Obey Vx_select_enable_clipboard_manager. Catch errors in
9424 x_clipboard_manager_save (Bug#8779).
9425 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9426 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9427
99a33b77 94282011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9429
9430 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9431
99a33b77 94322011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9433
9434 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9435 in the current matrix if keep_current_p is non-zero.
9436
8264569d
EZ
94372011-06-04 Eli Zaretskii <eliz@gnu.org>
9438
9439 * bidi.c (bidi_level_of_next_char): Fix last change.
9440
57f97249
EZ
94412011-06-03 Eli Zaretskii <eliz@gnu.org>
9442
fec2107c 9443 Support bidi reordering of text covered by display properties.
57f97249 9444
fec2107c
EZ
9445 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9446 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9447 (bidi_cache_search, bidi_cache_iterator_state)
9448 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9449 (bidi_level_of_next_char, bidi_move_to_visually_next):
9450 Support character positions inside a run of characters covered by a
fec2107c
EZ
9451 display string.
9452 (bidi_paragraph_init, bidi_resolve_explicit_1)
9453 (bidi_level_of_next_char): Call bidi_fetch_char and
9454 bidi_fetch_char_advance instead of FETCH_CHAR and
9455 FETCH_CHAR_ADVANCE.
9456 (bidi_init_it): Initialize new members.
9457 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9458 definitions.
9459 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9460 instead of using explicit *_CHAR codes.
d6d100dd
SM
9461 (bidi_resolve_explicit, bidi_resolve_weak):
9462 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9463 bidirectional text is supported only in multibyte buffers.
9464 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9465 it to initialize the frame_window_p member of struct bidi_it.
9466 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9467 (bidi_resolve_explicit, bidi_resolve_weak)
9468 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9469 bidi_it->nchars is non-positive.
9470 (bidi_level_of_next_char): Don't try to lookup the cache for the
9471 next/previous character if nothing is cached there yet, or if we
9472 were just reseat()'ed to a new position.
c40e2fb2 9473
0e14fe90
EZ
9474 * xdisp.c (set_cursor_from_row): Set start and stop points
9475 according to the row's direction when priming the loop that looks
9476 for the glyph on which to display cursor.
9477 (single_display_spec_intangible_p): Function deleted.
9478 (display_prop_intangible_p): Reimplement to call
9479 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9480 Accept 3 additional arguments needed by handle_display_spec.
9481 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9482 values: lists, `(when COND...)' forms, etc.
9483 (single_display_spec_string_p): Support property values that are
9484 lists with the argument STRING its top-level element.
9485 (display_prop_string_p): Fix the condition for processing a
9486 property that is a list to be consistent with handle_display_spec.
fec2107c 9487 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9488 last portion of handle_display_prop.
9489 (compute_display_string_pos): Accept additional argument
9490 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9491 value of a `display' property is a "replacing spec".
9492 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9493 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9494 the display property, but just return a value indicating whether
9495 the display property will replace the characters it covers.
9496 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9497 frame_window_p members of struct bidi_it.
d6d100dd
SM
9498 (compute_display_string_pos, compute_display_string_end):
9499 New functions.
fec2107c
EZ
9500 (push_it): Accept second argument POSITION, where pop_it should
9501 jump to continue iteration.
9502 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9503
fec2107c
EZ
9504 * keyboard.c (adjust_point_for_property): Adjust the call to
9505 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9506
9507 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9508 (bidi_init_it): Update prototypes.
9509 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9510 (compute_display_string_pos, compute_display_string_end):
9511 Declare prototypes.
fec2107c
EZ
9512 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9513 EMACS_INT.
fc6f18ce 9514
40087514 95152011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9516
57f53182
PE
9517 Malloc failure behavior now depends on size of allocation.
9518 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9519 * lisp.h: Change signatures accordingly.
9520 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9521 All callers changed. (Bug#8762)
9522
9523 * gnutls.c: Use Emacs's memory allocators.
9524 Without this change, the gnutls library would invoke malloc etc.
9525 directly, which causes problems on non-SYNC_INPUT hosts, and which
9526 runs afoul of improving memory_full behavior. (Bug#8761)
9527 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9528 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9529 xfree instead of the default malloc, realloc, free.
9530 (Fgnutls_boot): No need to check for memory allocation failure,
9531 since xmalloc does that for us.
9532
ac32cd99 9533 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9534 * category.c (hash_get_category_set):
9535 * ccl.c (ccl_driver):
9536 * charset.c (Fdefine_charset_internal):
9537 * charset.h (struct charset.hash_index):
9538 * composite.c (get_composition_id, gstring_lookup_cache)
9539 (composition_gstring_put_cache):
9540 * composite.h (struct composition.hash_index):
9541 * dispextern.h (struct image.hash):
9542 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9543 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9544 (hashfn_equal, hashfn_user_defined, make_hash_table)
9545 (maybe_resize_hash_table, hash_lookup, hash_put)
9546 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9547 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9548 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9549 * image.c (make_image, search_image_cache, lookup_image)
9550 (xpm_put_color_table_h):
9551 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9552 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9553 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9554 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9555 * alloc.c (allocate_vectorlike):
9556 Check for overflow in vector size calculations.
9557 * ccl.c (ccl_driver):
9558 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9559 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9560 need to be updated by these changes.
40087514
PE
9561 * fns.c (make_hash_table, maybe_resize_hash_table):
9562 Check for integer overflow with large hash tables.
0de4bb68
PE
9563 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9564 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9565 (SXHASH_REDUCE): New macro.
9566 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9567 Use it instead of discarding useful hash info with large hash values.
9568 (sxhash_float): New function.
9569 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9570 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9571 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9572 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9573 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9574 Adjust signatures to match updated version of code.
9575 (consing_since_gc): Now EMACS_INT, since a single hash table can
9576 use more than INT_MAX bytes.
9577
698d32e2
DN
95782011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9579
9580 Make it possible to build with GCC-4.6+ -O2 -flto.
9581
9582 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9583
fd6fa53f
SM
95842011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9585
9586 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9587 Call minibuffer-inactive-mode.
9588
864db017
JB
95892011-05-31 Juanma Barranquero <lekktu@gmail.com>
9590
9591 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9592 Update dependencies.
9593
2ad0baf4
DN
95942011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9595
9596 * data.c (init_data): Remove code for UTS, this system is not
9597 supported anymore.
9598
4fcc2638
DN
95992011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9600
9601 Don't force ./temacs to start in terminal mode.
9602
9603 * frame.c (make_initial_frame): Initialize faces in all cases, not
9604 only when CANNOT_DUMP is defined.
9605 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9606
c56e0fd5
DN
96072011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9608
9609 * dispnew.c (add_window_display_history): Use const for the string
9610 pointer. Remove declaration, not needed.
9611
333d54da 96122011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9613
55d4c1b2 9614 Use 'inline', not 'INLINE'.
333d54da 9615 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9616 * alloc.c, fontset.c (INLINE): Remove.
9617 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9618 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9619 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9620 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9621 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9622
738db178
DN
96232011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9624
9625 Make it possible to run ./temacs.
9626
9627 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9628 syms_of_callproc does the same thing. Remove test for
9629 "initialized", do it in the caller.
9630 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9631
620c53a6
SM
96322011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9633
9634 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9635 (read_minibuf): Use get_minibuffer.
9636 (syms_of_minibuf): Use DEFSYM.
9637 (Qmetadata): New var.
9638 * data.c (Qbuffer): Don't make it static.
9639 (syms_of_data): Use DEFSYM.
9640
e003a292
PE
96412011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9642
9643 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9644 (CCL_CODE_MIN): New macro.
9645
ed008a6d
PE
96462011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9647
3687c2ef
PE
9648 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9649
ed008a6d
PE
9650 * eval.c (Qdebug): Now static.
9651 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9652 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9653 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9654
d66c4c7c
CY
96552011-05-29 Chong Yidong <cyd@stupidchicken.com>
9656
9657 * image.c: Various fixes to ImageMagick code comments.
9658 (Fimagemagick_types): Doc fix.
9659
5fbc2025
PE
96602011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9661
0196f88a
PE
9662 Minor fixes prompted by GCC 4.6.0 warnings.
9663
9664 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9665
5fbc2025
PE
9666 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9667 (x_clipboard_manager_save_all): Move extern decl to ...
9668 * xterm.h: ... here, so that it can be checked for consistency.
9669
1dd3c2d9
CY
96702011-05-29 Chong Yidong <cyd@stupidchicken.com>
9671
9672 * xselect.c (x_clipboard_manager_save_frame)
9673 (x_clipboard_manager_save_all): New functions.
9674 (Fx_clipboard_manager_save): Lisp function deleted.
9675
9676 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9677 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9678
9679 * xterm.h: Update prototype.
9680
5ba6571d
WX
96812011-05-28 William Xu <william.xwl@gmail.com>
9682
9683 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9684 exiting (Bug#8239).
9685
3eaff834
JM
96862011-05-28 Jim Meyering <meyering@redhat.com>
9687
e1900994 9688 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9689 * fns.c (to_uchar): Define.
9690 (crypto_hash_function): Use it to convert some newly-signed
9691 variables to unsigned, to avoid sign-extension bugs. For example,
9692 without this change, (md5 "truc") would evaluate to
9693 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9694 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9695 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9696
0f6990a7
PE
96972011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9698
9699 Integer overflow fixes.
c8a9ca5a 9700
08686060
PE
9701 * dbusbind.c: Serial number integer overflow fixes.
9702 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9703 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9704 to hold a serial number that is too large for a fixnum.
9705 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9706 Check for serial numbers out of range. Decode any serial number
59568bf0 9707 that was so large that it became a float. (Bug#8722)
08686060 9708
2d1fc3c7
PE
9709 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9710 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9711 Use XFASTINT rather than XUINT when numbers are nonnegative.
9712 (xd_append_arg, Fdbus_method_return_internal):
9713 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9714 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9715 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9716 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9717 (Bug#8722)
2d1fc3c7 9718
c8a9ca5a
PE
9719 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9720
519e1d69
PE
9721 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9722
6df6ae42 9723 ccl: Add integer overflow checks.
30569699
PE
9724 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9725 (IN_INT_RANGE): New macros.
9726 (ccl_driver): Use them to check for integer overflow when
9727 decoding a CCL program. Many of the new checks are whether XINT (x)
9728 fits in int; it doesn't always, on 64-bit hosts. The new version
9729 doesn't catch all possible integer overflows, but it's an
847044ea 9730 improvement. (Bug#8719)
30569699 9731
c11285dc
PE
9732 * alloc.c (make_event_array): Use XINT, not XUINT.
9733 There's no need for unsigned here.
9734
fdccd48e
PE
9735 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9736 This follows up to the 2011-05-06 change that substituted uintptr_t
9737 for EMACS_INT. This case wasn't caught back then.
9738
37910ab2
PE
9739 Rework Fformat to avoid integer overflow issues.
9740 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9741 now (part of C89). Include <verify.h>.
9742 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9743 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9744 (Fformat): Avoid the prepass trying to compute sizes; it was only
9745 approximate and thus did not catch overflow reliably. Instead, walk
9746 through the format just once, formatting and computing sizes as we go,
9747 checking for integer overflow at every step, and allocating a larger
9748 buffer as needed. Keep track separately whether the format is
9749 multibyte. Keep only the most-recently calculated precision, rather
9750 than them all. Record whether each argument has been converted to
9751 string. Use EMACS_INT, not int, for byte and char and arg counts.
9752 Support field widths and precisions larger than INT_MAX. Avoid
9753 sprintf's undefined behavior with conversion specifications such as %#d
9754 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9755 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9756 formatting out-of-range floating point numbers with int
9173deec 9757 formats. (Bug#8668)
37910ab2 9758
2e6578fb
PE
9759 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9760
0ae6bdee
PE
9761 * data.c: Avoid integer truncation in expressions involving floats.
9762 * data.c: Include <intprops.h>.
9763 (arith_driver): When there's an integer overflow in an expression
9764 involving floating point, convert the integers to floating point
9765 so that the resulting value does not suffer from catastrophic
9766 integer truncation. For example, on a 64-bit host (* 4
9767 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9768 Do not rely on undefined behavior after integer overflow.
9769
de883a70
PE
9770 merge count_size_as_multibyte, parse_str_to_multibyte
9771 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9772 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9773 Check for integer overflow.
9774 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9775 since it's now a duplicate of the other. This is more of
9776 a character than a buffer op, so better that it's in character.c.
9777 * fns.c, print.c: Adjust to above changes.
9778
2ff916cb
PE
97792011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9780
9781 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9782
f1b54466
PE
97832011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9784
fb1ac845
PE
9785 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9786 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9787 (x_clipboard_manager_save): Now static.
9788 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9789
f1b54466
PE
9790 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9791 (crypto_hash_function): Now static.
9792 Fix pointer signedness problems. Avoid unnecessary initializations.
9793
a9f737ee
CY
97942011-05-27 Chong Yidong <cyd@stupidchicken.com>
9795
9796 * termhooks.h (Vselection_alist): Make it terminal-local.
9797
9798 * terminal.c (create_terminal): Initialize it.
9799
9800 * xselect.c: Support for clipboard managers.
9801 (Vselection_alist): Move to termhooks.h as terminal-local var.
9802 (LOCAL_SELECTION): New macro.
9803 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9804 (symbol_to_x_atom): Remove gratuitous arg.
9805 (x_handle_selection_request, lisp_data_to_selection_data)
9806 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9807 (x_own_selection, x_get_local_selection, x_convert_selection):
9808 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9809 (some_frame_on_display): Delete unused function.
9810 (Fx_own_selection_internal, Fx_get_selection_internal)
9811 (Fx_disown_selection_internal, Fx_selection_owner_p)
9812 (Fx_selection_exists_p): New optional frame arg.
9813 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9814 (x_handle_selection_clear): Don't treat other terminals with the
9815 same keyboard specially. Use the terminal-local Vselection_alist.
9816 (x_clear_frame_selections): Use Frun_hook_with_args.
9817
9818 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9819
9820 * xterm.h: Add support for those atoms.
9821
e067f0c1
CY
98222011-05-26 Chong Yidong <cyd@stupidchicken.com>
9823
9824 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9825 (converted_selections, conversion_fail_tag): New global variables.
9826 (x_selection_request_lisp_error): Free the above.
9827 (x_get_local_selection): Remove unnecessary code.
9828 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9829 of converted selections stored in converted_selections.
9830 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9831 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9832 (x_convert_selection): New function.
9833 (x_handle_selection_event): Simplify.
9834 (x_get_foreign_selection): Don't ignore incoming requests while
9835 waiting for an answer; this will fail when we implement
9836 SAVE_TARGETS, and seems unnecessary anyway.
9837 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9838 (Vx_sent_selection_functions): Doc fix.
9839
0f4aebc0
LL
98402011-05-26 Leo Liu <sdl.web@gmail.com>
9841
9842 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9843
e61124cd
YM
98442011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9845
9846 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9847
9848 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9849 for fringe update if it has periodic bitmap.
ac389d0c 9850 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9851 and fringe_bitmap_periodic_p.
9852
9853 * fringe.c (get_fringe_bitmap_data): New function.
9854 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9855 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9856 row. Mark glyph row for fringe update if periodicity changed.
9857
9858 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9859 for fringe update unless it has periodic bitmap.
9860
f16d9837
KH
98612011-05-25 Kenichi Handa <handa@m17n.org>
9862
9863 * xdisp.c (get_next_display_element): Set correct it->face_id for
9864 a static composition.
9865
e1b90ef6
LL
98662011-05-24 Leo Liu <sdl.web@gmail.com>
9867
9868 * deps.mk (fns.o):
9869 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9870
9871 * fns.c (crypto_hash_function, Fsha1): New function.
9872 (Fmd5): Use crypto_hash_function.
9873 (syms_of_fns): Add Ssha1.
9874
7400048f
PE
98752011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9876
9877 * gnutls.c: Remove unused macros.
9878 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9879 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9880 Remove macros that are defined and never used.
9881 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9882
abb71cf4
CY
98832011-05-22 Chong Yidong <cyd@stupidchicken.com>
9884
9885 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9886 (Fx_get_selection_internal): Minor cleanup.
9887 (Fx_own_selection_internal): Rename arguments for consistency with
9888 select.el.
9889
6307db39
PE
98902011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9891
9892 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9893
f3d4e0a4
CY
98942011-05-22 Chong Yidong <cyd@stupidchicken.com>
9895
9896 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9897
4d8ade89
YM
98982011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9899
9900 * dispnew.c (scrolling_window): Don't exclude the case that the
9901 last enabled row in the desired matrix touches the bottom boundary.
9902
32078c8d
GM
99032011-05-21 Glenn Morris <rgm@gnu.org>
9904
9905 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9906 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9907 and add some more files.
32078c8d 9908
7285dc67
EZ
99092011-05-20 Eli Zaretskii <eliz@gnu.org>
9910
9911 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9912 report_file_error introduced by the change from 2011-05-07.
9913
89d1bd22
PE
99142011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9915
9916 * systime.h (Time): Define only if emacs is defined.
9917 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9918 where the include path doesn't have X11/X.h by default. See
9919 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9920
cd394be1 99212011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9922
9923 * composite.c (find_automatic_composition): Fix previous change.
9924
b9704ad9
GM
99252011-05-20 Glenn Morris <rgm@gnu.org>
9926
9927 * lisp.mk: New file, split from Makefile.in.
9928 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9929 (shortlisp): Remove.
9930 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9931
4a720484
GM
99322011-05-19 Glenn Morris <rgm@gnu.org>
9933
9934 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9935 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9936 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9937 (lisp): Set the order to that of loadup.el.
9938 (shortlisp): Make it a copy of $lisp.
9939 (SOME_MACHINE_LISP): Remove.
9940 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9941 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9942
a28d4396
KH
99432011-05-18 Kenichi Handa <handa@m17n.org>
9944
9945 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9946 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9947 (find_automatic_composition): Mostly rewrite for efficiency.
9948
a2b1fa8e
JB
99492011-05-18 Juanma Barranquero <lekktu@gmail.com>
9950
9951 * makefile.w32-in: Update dependencies.
9952
8e1f5610
CS
99532011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9954
9955 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9956 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9957
7025ee00 99582011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9959
cdfa6eab
PE
9960 Fix some integer overflow issues, such as string length overflow.
9961
06d6db33
PE
9962 * insdel.c (count_size_as_multibyte): Check for string overflow.
9963
2b4560a8
PE
9964 * character.c (lisp_string_width): Check for string overflow.
9965 Use EMACS_INT, not int, for string indexes and lengths; in
9966 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9967 the resulting string length overflows an EMACS_INT; instead,
9968 report a string overflow if no precision given. When checking for
9969 precision exhaustion, use a check that cannot possibly have
9970 integer overflow. (Bug#8675)
9971 * character.h (lisp_string_width): Adjust to new signature.
9972
cb93f9be
PE
9973 * alloc.c (string_overflow): New function.
9974 (Fmake_string): Use it. This doesn't change behavior, but saves
9975 a few bytes and will simplify future changes.
9976 * character.c (string_escape_byte8): Likewise.
9977 * lisp.h (string_overflow): New decl.
9978
1a1f3366
PE
9979 Fixups, following up to the user-interface timestamp change.
9980 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9981 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9982 * msdos.c (mouse_get_pos): Likewise.
9983 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9984 * w32gui.h (Time): Define by including "systime.h" rather than by
9985 declaring it ourselves. (Bug#8664)
9986
d4e3e4d3
PE
9987 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9988 * image.c (clear_image_cache): Likewise.
9989
f6a24d19
PE
9990 * term.c (term_mouse_position): Don't assume time_t wraparound.
9991
08dc5ae6
PE
9992 Be more systematic about user-interface timestamps.
9993 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9994 and sometimes 'EMACS_UINT', to represent these timestamps.
9995 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9996 This makes the code easier to follow, and makes it easier to catch
9997 integer overflow bugs such as Bug#8664.
9998 * frame.c (Fmouse_position, Fmouse_pixel_position):
9999 Use Time, not unsigned long, for user-interface timestamps.
10000 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10001 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10002 * keyboard.h (last_event_timestamp): Likewise.
10003 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10004 * menu.h (xmenu_show): Likewise.
10005 * term.c (term_mouse_position): Likewise.
10006 * termhooks.h (struct input_event.timestamp): Likewise.
10007 (struct terminal.mouse_position_hook): Likewise.
10008 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10009 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10010 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10011 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10012 what it was before.
10013 * menu.h, termhooks.h: Include "systime.h", for Time.
10014
8e55734a
PE
10015 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10016 Don't assume that the difference between two unsigned long values
10017 can fit into an integer. At this point, we know button_down_time
10018 <= event->timestamp, so the difference must be nonnegative, so
10019 there's no need to cast the result if double-click-time is
10020 nonnegative, as it should be; check that it's nonnegative, just in
10021 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10022 apart (about 25 days). (Bug#8664)
8e55734a 10023
841f1b75 10024 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10025 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10026
3e26f69c
PE
10027 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10028 that always fit in int. Use a sentinel instead of a counter, to
10029 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10030 * frame.h (struct frame): Use int for menu_bar_items_used
10031 instead of EMACS_INT, since it always fits in int.
3e26f69c 10032
5cc152c0
PE
10033 * menu.c (grow_menu_items): Check for int overflow.
10034
d89eb65e
PE
10035 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10036
5235bd3e
PE
10037 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10038 Before, the code was not consistent. These values cannot exceed
10039 2**31 - 1 so there's no need to make them unsigned.
10040 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10041 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10042 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10043 as modifiers.
10044 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10045
bc827e23
PE
10046 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10047 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10048 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10049 presumably because the widths might not match.
10050
78eb494e
PE
10051 * window.c (size_window): Avoid needless test at loop start.
10052
04f2d78b
CB
100532011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10054
10055 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10056
d2fc7e3d 100572011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10058
10059 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10060
d2fc7e3d 100612011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10062
10063 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10064 `width' to `bar_area_x' and `bar_area_width', respectively.
10065 (x_scroll_run): Take account of fringe background extension.
10066
04f2d78b
CB
10067 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10068 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10069 `bar_area_width', respectively.
10070 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10071 background extension.
10072
79b70037
GM
100732011-05-10 Jim Meyering <meyering@redhat.com>
10074
10075 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10076
2f142cc5
JB
100772011-05-10 Juanma Barranquero <lekktu@gmail.com>
10078
10079 * image.c (Finit_image_library): Return t for built-in image types,
10080 like pbm and xbm. (Bug#8640)
10081
57679c86
AS
100822011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10083
10084 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10085
888c9e86
EZ
100862011-05-07 Eli Zaretskii <eliz@gnu.org>
10087
b0512a1d
EZ
10088 * w32console.c (Fset_screen_color): Doc fix.
10089 (Fget_screen_color): New function.
10090 (syms_of_ntterm): Defsubr it.
10091
7285dc67
EZ
10092 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10093 unlink the temporary file if Fcall_process didn't create it in the
10094 first place.
10095 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10096 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10097 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10098 cue to call_process_cleanup not to close that handle.
10099
4d3fcc8e
BK
101002011-05-07 Ben Key <bkey76@gmail.com>
10101
10102 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10103 one of two shell specific rules, either bootstrap-temacs-CMD or
10104 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10105 to the previous implementation of the bootstrap-temacs rule.
10106 The bootstrap-temacs-CMD rule is similar to the previous
10107 implementation of the bootstrap-temacs rule except that it
10108 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10109 variable.
10110
10111 These changes, along with some changes to nt/configure.bat,
10112 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10113 earlier fix to add support for --cflags and --ldflags options
10114 that include quotes so that it works whether make uses cmd or
10115 sh as the shell.
10116
b4289b64
MA
101172011-05-06 Michael Albinus <michael.albinus@gmx.de>
10118
10119 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10120 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10121 is a constant.
10122 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10123 a string. Handle both cases.
10124 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10125 (Fdbus_register_method): Use Qinvalid_function.
10126
af4c0e28
JB
101272011-05-06 Juanma Barranquero <lekktu@gmail.com>
10128
10129 * makefile.w32-in: Update dependencies.
10130 (LISP_H): Add inttypes.h and stdin.h.
10131 (PROCESS_H): Add unistd.h.
10132
c51453d9
EZ
101332011-05-06 Eli Zaretskii <eliz@gnu.org>
10134
10135 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10136 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10137
8ff0ac3c 101382011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10139
4c4b566b
PE
10140 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10141
aab2b9b5
PE
10142 * term.c (vfatal): Remove stray call to va_end.
10143 It's not needed and the C Standard doesn't allow it here anyway.
10144
c378da0b
PE
10145 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10146 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10147
288b08c7
PE
10148 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10149 bytes.
10150
e3601888
PE
10151 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10152
db6c0e74
PE
10153 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10154
dd5963ea
PE
10155 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10156
88c9450f
PE
10157 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10158
2f9442b8
PE
10159 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10160
c032b5f8
PE
10161 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10162 * charset.c (Fdefine_charset_internal): Don't initialize
10163 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10164 32-bit int (Bug#8600).
a108c10b
PE
10165
10166 * lread.c (read_integer): Be more consistent with string-to-number.
10167 Use string_to_number to do the actual conversion; this avoids
10168 rounding errors and fixes some other screwups. Without this fix,
10169 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10170 (digit_to_number): Move earlier, for benefit of read_integer.
10171 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10172 not a digit in any supported base. (Bug#8602)
a108c10b 10173
ad5f9eea
PE
10174 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10175
aec1708a
PE
10176 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10177 to match comment at start of function. This also removes a
10178 GCC warning about overflow in a 32+64-bit port.
10179
47be4ab5
PE
10180 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10181
371cac43
PE
10182 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10183 Reported by Stefan Monnier in
10184 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10185 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10186 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10187
d01a7826
PE
10188 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10189 (EMACS_UINTPTR): Likewise, with uintptr_t.
10190
7fd47d5c
PE
10191 * lisp.h: Prefer 64-bit EMACS_INT if available.
10192 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10193 on 32-bit hosts that have 64-bit int, so that they can access
10194 large files.
122b0c86
PE
10195 However, temporarily disable this change unless the temporary
10196 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10197
8727937b
PE
10198 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10199
8ac068ac
PE
10200 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10201 This removes an assumption that EMACS_INT and long are the same
10202 width as pointers. The assumption is true for Emacs porting targets
10203 now, but we want to make other targets possible.
10204 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10205 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10206 In the rest of the code, change types of integers that hold casted
10207 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10208 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10209 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10210 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10211 No need to cast type when ORing.
10212 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10213 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10214 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10215 assume EMACS_INT is the same width as char *.
10216 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10217 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10218 Remove no-longer-needed casts.
10219 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10220 (xg_tool_bar_help_callback, xg_make_tool_item):
10221 Use EMACS_INTPTR to hold an integer
10222 that will be cast to void *; this can avoid a GCC warning
10223 if EMACS_INT is not the same width as void *.
10224 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10225 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10226 (current_message_1, set_message_1):
10227 Use a local to convert to proper width without a cast.
10228 * xmenu.c (dialog_selection_callback): Likewise.
10229
ede49d71
PE
10230 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10231 Also, don't assume VALBITS / RAND_BITS is less than 5,
10232 and don't rely on undefined behavior when shifting a 1 left into
10233 the sign bit.
10234 * lisp.h (get_random): Change signature to match.
10235
2f30ecd0
PE
10236 * lread.c (hash_string): Use size_t, not int, for hash computation.
10237 Normally we prefer signed values; but hashing is special, because
10238 it's better to use unsigned division on hash table sizes so that
10239 the remainder is nonnegative. Also, size_t is the natural width
10240 for hashing into memory. The previous code used 'int', which doesn't
10241 retain enough info to hash well into very large tables.
10242 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10243
2a866e7b
PE
10244 * dbusbind.c: Don't possibly lose pointer info when converting.
10245 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10246 Use XPNTR rather than XHASH, so that the high-order bits of
10247 the pointer aren't lost when converting through void *.
10248
51639eac
PE
10249 * eval.c (Fautoload): Don't double-shift a pointer.
10250
92394119
PE
10251 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10252
dbdb9a7c
JB
102532011-05-06 Juanma Barranquero <lekktu@gmail.com>
10254
10255 * gnutls.c (DEF_GNUTLS_FN):
10256 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10257
db7a0b4f
AS
102582011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10259
10260 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10261 marker. (Bug#8610)
10262
cd394be1 102632011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10264
10265 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10266 New version that can reserve upto 2GB of heap space.
10267
f7ff1b0f 102682011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10269
10270 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10271
639c109b
TZ
102722011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10273
10274 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10275 `gnutls_certificate_set_x509_key_file'.
10276
d2127135
JB
102772011-05-05 Juanma Barranquero <lekktu@gmail.com>
10278
10279 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10280 Update dependencies.
10281
e968f4f3
JB
102822011-05-04 Juanma Barranquero <lekktu@gmail.com>
10283
10284 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10285 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10286 Remove unused parameter `fildes'.
10287 * process.c (read_process_output, send_process): Don't pass it.
10288
84d358f0
JB
102892011-05-04 Juanma Barranquero <lekktu@gmail.com>
10290
10291 Fix previous change: the library cache is defined in w32.c.
10292 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10293 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10294
0898ca10
JB
102952011-05-04 Juanma Barranquero <lekktu@gmail.com>
10296
10297 Implement dynamic loading of GnuTLS on Windows.
10298
10299 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10300 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10301 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10302 Declare.
10303
10304 * gnutls.c (Qgnutls_dll): Define.
10305 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10306 (gnutls_*): Declare function pointers.
10307 (init_gnutls_functions): New function to initialize function pointers.
10308 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10309 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10310 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10311 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10312 (emacs_gnutls_write, emacs_gnutls_read)
10313 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10314 (Fgnutls_available_p): New function.
10315 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10316 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10317 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10318
10319 * image.c: Include w32.h.
10320 (Vimage_type_cache): Delete.
10321 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10322 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10323 (w32_delayed_load): Move to w32.c.
10324
10325 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10326
10327 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10328 (w32_delayed_load): Move from image.c. When loading a library, record
10329 its filename in the :loaded-from property of the library id.
10330 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10331 Initialize and staticpro them.
10332 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10333
10334 * process.c: Include lisp.h before w32.h, not after.
10335 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10336 instead of gnutls_record_check_pending.
10337
10338 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10339
ff4de4aa
TZ
103402011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10341
10342 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10343 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10344 as passed in.
10345
abe95abb
JD
103462011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10347
10348 * xterm.c (x_set_frame_alpha): Do not set property on anything
10349 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10350
e16e55d4
JB
103512011-05-02 Juanma Barranquero <lekktu@gmail.com>
10352
10353 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10354
bafcf6a5
JB
103552011-05-02 Juanma Barranquero <lekktu@gmail.com>
10356
10357 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10358 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10359 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10360 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10361 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10362 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10363 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10364 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10365 (Qgnutls_bootprop_callbacks_verify): Make static.
10366
e7a6747f
AS
103672011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10368
19ed11ba
AS
10369 * callproc.c: Indentation fixup.
10370
e7a6747f 10371 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10372 (wait_for_termination, interruptible_wait_for_termination):
10373 Move after wait_for_termination_1.
e7a6747f 10374
1ef14cb4
LMI
103752011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10376
10377 * sysdep.c (interruptible_wait_for_termination): New function
10378 which is like wait_for_termination, but allows keyboard
10379 interruptions.
10380
10381 * callproc.c (Fcall_process): Add (:file "file") as an option for
10382 the STDOUT buffer.
10383 (Fcall_process_region): Ditto.
10384
330d880c
EZ
103852011-04-30 Eli Zaretskii <eliz@gnu.org>
10386
8db90b73
EZ
10387 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10388 rather than `XVECTOR (FOO)->size'.
10389
330d880c
EZ
10390 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10391 inttypes.h, as a gnulib replacement is used if it not available in
10392 system headers.
10393
15cbd324
EZ
103942011-04-21 Eli Zaretskii <eliz@gnu.org>
10395
10396 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10397 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10398 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10399
10400 * coding.c (coding_alloc_by_realloc): Error out if destination
10401 will grow beyond MOST_POSITIVE_FIXNUM.
10402 (decode_coding_emacs_mule): Abort if there isn't enough place in
10403 charbuf for the composition carryover bytes. Reserve an extra
10404 space for up to 2 characters produced in a loop.
10405 (decode_coding_iso_2022): Abort if there isn't enough place in
10406 charbuf for the composition carryover bytes.
10407
104082011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10409
ae940cca
EZ
10410 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10411 aborting when %lld or %lll format is passed.
10412 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10413 %llo or %llx format is passed. (Bug#8545)
10414
03ab8921
EZ
10415 * window.c (window_scroll_line_based): Use a marker instead of
10416 simple variables to record original value of point. (Bug#7952)
10417
afda1437
EZ
10418 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10419 produced by %s or %c overflows available buffer space. (Bug#8545)
10420
f76dee0c
PE
104212011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10422
10423 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10424 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10425
fdc5744d
JB
104262011-04-28 Juanma Barranquero <lekktu@gmail.com>
10427
10428 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10429
638f053a
JB
104302011-04-28 Juanma Barranquero <lekktu@gmail.com>
10431
10432 * keyboard.c (Qdelayed_warnings_hook): Define.
10433 (command_loop_1): Run `delayed-warnings-hook'
10434 if Vdelayed_warnings_list is non-nil.
10435 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10436 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10437
d178f871
EZ
104382011-04-28 Eli Zaretskii <eliz@gnu.org>
10439
10440 * doprnt.c (doprnt): Don't return value smaller than the buffer
10441 size if the message was truncated. (Bug#8545).
10442
b124fd93
JB
104432011-04-28 Juanma Barranquero <lekktu@gmail.com>
10444
10445 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10446 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10447
e810457d
PE
104482011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10449
10450 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10451
ea51cceb
JB
104522011-04-27 Juanma Barranquero <lekktu@gmail.com>
10453
10454 * makefile.w32-in: Update dependencies.
10455
94dcfacf
EZ
104562011-04-27 Eli Zaretskii <eliz@gnu.org>
10457
10458 Improve `doprnt' and its usage. (Bug#8545)
10459 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10460 `format_end'. Remove support for %l as a conversion specifier.
10461 Don't use xrealloc. Improve diagnostics when the %l size modifier
10462 is used. Update the commentary.
10463
10464 * eval.c (verror): Simplify calculation of size_t.
10465
10466 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10467 messages.
10468
f61f41d7
PE
104692011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10470
10471 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10472 change.
10473
96fb4434
PE
104742011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10475
10476 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10477 This makes this file independent of the recent pseudovector change.
10478
671875da 104792011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10480
69e9b5a3
PE
10481 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10482
b5f869a7 10483 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10484 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10485 Remove unused local.
c8926152 10486 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10487
841a1577 10488 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10489 GCC 4.6.0 optimizes based on type-based alias analysis.
10490 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10491 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10492 != &v->size, and therefore "v->size = 1; b->size = 2; return
10493 v->size;" must therefore return 1. This assumption is incorrect
10494 for Emacs, since it type-puns struct Lisp_Vector * with many other
10495 types. To fix this problem, this patch adds a new type struct
f904488f 10496 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10497 and pseudovectors, and helps optimizing compilers not get fooled
10498 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10499 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10500 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10501 the size member.
eab3844f
PE
10502 (XSETPVECTYPE): Rewrite in terms of new macro.
10503 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10504 This is a bit clearer, and further avoids the possibility of
10505 undesirable aliasing.
10506 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10507 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10508 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10509 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10510 (ASIZE): Now uses header.size rather than size.
10511 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10512 to avoid the hassle of writing XVECTOR (foo)->header.size.
10513 (struct vectorlike_header): New type.
eab3844f
PE
10514 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10515 object, to help avoid aliasing.
10516 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10517 (SUBRP): Likewise, since Lisp_Subr is a special case.
10518 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10519 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10520 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10521 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10522 changed to be "header.size" and "header.next".
10523 * buffer.h (struct buffer): Likewise.
10524 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10525 * frame.h (struct frame): Likewise.
10526 * process.h (struct Lisp_Process): Likewise.
10527 * termhooks.h (struct terminal): Likewise.
10528 * window.c (struct save_window_data, struct saved_window): Likewise.
10529 * window.h (struct window): Likewise.
10530 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10531 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10532 * buffer.c (init_buffer_once): Likewise.
10533 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10534 special case.
10535 * process.c (Fformat_network_address): Use local var for size,
10536 for brevity.
10537
0df1eac5
PE
10538 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10539
847ab9d1 10540 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10541 * data.c (atof): Remove decl; no longer used or needed.
10542 (digit_to_number): Move to lread.c.
10543 (Fstring_to_number): Use new string_to_number function, to be
10544 consistent with how the Lisp reader treats infinities and NaNs.
10545 Do not assume that floating-point numbers represent EMACS_INT
10546 without losing information; this is not true on most 64-bit hosts.
10547 Avoid double-rounding errors, by insisting on integers when
10548 parsing non-base-10 numbers, as the documentation specifies.
10549 * lisp.h (string_to_number): New decl, replacing ...
10550 (isfloat_string): Remove.
bc0a5c13 10551 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10552 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10553 appears to have been a coding error. Similarly, do not accept
10554 strings like +-1e0 as floating point numbers. Do not report
10555 overflow for integer overflows unless the base is not 10 which
10556 means we have no simple and reliable way to continue.
10557 Break out the floating-point parsing into a new
10558 function string_to_number, so that Fstring_to_number parses
10559 floating point numbers consistently with the Lisp reader.
04f2d78b 10560 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10561 (E_CHAR, EXP_INT): Remove, replacing with ...
10562 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10563 (string_to_number): New function, replacing isfloat_string.
10564 This function checks for valid syntax and produces the resulting
10565 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10566 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10567 so that overflow for non-base-10 numbers is reported only when
10568 there's no portable and simple way to convert to floating point.
452f4150 10569
67769ffc
PE
10570 * textprop.c (set_text_properties_1): Rewrite for clarity,
10571 and to avoid GCC warning about integer overflow.
10572
c20db43f
PE
10573 * intervals.h (struct interval): Use EMACS_INT for members
10574 where EMACS_UINT might cause problems. See
10575 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10576 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10577 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10578 All uses changed.
37aa2f85
PE
10579 (offset_intervals): Tell GCC not to worry about length overflow
10580 when negating a negative length.
c20db43f 10581
2538aa2f
PE
10582 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10583 (overrun_check_free): Likewise.
10584
f2d3008d
PE
10585 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10586 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10587 word size.
10588
ec8df744
PE
10589 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10590 (gnutls_make_error): Rename local to avoid shadowing.
10591 (gnutls_emacs_global_deinit): ifdef out; not used.
10592 (Fgnutls_boot): Use const for pointer to readonly storage.
10593 Comment out unused local. Fix pointer signedness problems.
10594
640ee02d
PE
10595 * lread.c (openp): Don't stuff size_t into an 'int'.
10596 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10597 about possible signed overflow.
10598
6048fb2a
PE
10599 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10600 (GDK_KEY_g): Don't define if already defined.
10601 (xg_prepare_tooltip): Avoid pointer signedness problem.
10602 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10603
fa3c87e1
PE
10604 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10605 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10606
2172544b
PE
10607 * xfns.c (Fx_window_property): Simplify a bit,
10608 to make a bit faster and to avoid GCC 4.6.0 warning.
10609 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10610
9b821a21
PE
10611 * fns.c (internal_equal): Don't assume size_t fits in int.
10612
3c616cfa
PE
10613 * alloc.c (compact_small_strings): Tighten assertion a little.
10614
c2982e87
PE
10615 Replace pEd with more-general pI, and fix some printf arg casts.
10616 * lisp.h (pI): New macro, generalizing old pEd macro to other
10617 conversion specifiers. For example, use "...%"pI"d..." rather
10618 than "...%"pEd"...".
10619 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10620 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10621 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10622 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10623 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10624 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10625 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10626 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10627 64-bit hosts.
10628 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10629 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10630 * print.c (safe_debug_print, print_object): Likewise.
10631 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10632 to int.
6f04d126
PE
10633 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10634 avoiding the 0 flag, which is not portable.
c2982e87
PE
10635 * process.c (Fmake_network_process): Use pI to avoid cast.
10636 * region-cache.c (pp_cache): Likewise.
10637 * xdisp.c (decode_mode_spec): Likewise.
10638 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10639 behavior on 64-bit hosts with printf arg.
6f04d126 10640 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10641 (x_stop_queuing_selection_requests): Likewise.
10642 (x_get_window_property): Don't truncate byte count to an 'int'
10643 when tracing.
0b432f21 10644
5e073ec7
PE
10645 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10646 here, since it parses constructs like leading '-' and spaces,
10647 which are not wanted; and it overflows with large numbers.
10648 Instead, simply match F[0-9]+, which is what is wanted anyway.
10649
36372bf9
PE
10650 * alloc.c: Remove unportable assumptions about struct layout.
10651 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10652 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10653 (allocate_vectorlike, make_pure_vector): Use the new macros,
10654 plus offsetof, to remove unportable assumptions about struct layout.
10655 These assumptions hold on all porting targets that I know of, but
10656 they are not guaranteed, they're easy to remove, and removing them
10657 makes further changes easier.
10658
0b432f21
PE
10659 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10660 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10661 (string_overrun_cookie): Now const. Use initializers that
10662 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10663 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10664 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10665 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10666 multiple of sizeof (EMACS_INT); it need not be, if
10667 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10668 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10669
895009e1
JB
106702011-04-26 Juanma Barranquero <lekktu@gmail.com>
10671
10672 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10673
6a7a1b0b
TZ
106742011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10675
10676 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10677 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10678 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10679
841a1577 106802011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10681
10682 * lisp.h (Qdebug): List symbol.
895009e1 10683 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10684 * keyboard.c (debug-on-event): New variable.
10685 (handle_user_signal): Break into debugger when debug-on-event
10686 matches the current signal symbol.
10687
f2d3ba6f
DN
106882011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10689
10690 * alloc.c (check_sblock, check_string_bytes)
10691 (check_string_free_list): Convert to standard C.
10692
42ce4c63
TZ
106932011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10694
10695 * w32.c (emacs_gnutls_push): Fix typo.
10696
825cd63c
EZ
106972011-04-25 Eli Zaretskii <eliz@gnu.org>
10698
fb11d64d
EZ
10699 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10700 "cast to pointer from integer of different size".
10701
825cd63c
EZ
10702 Improve doprnt and its use in verror. (Bug#8545)
10703 * doprnt.c (doprnt): Document the set of format control sequences
10704 supported by the function. Use SAFE_ALLOCA instead of always
10705 using `alloca'.
10706
10707 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10708 is one byte too soon. Don't use xrealloc; instead xfree and
10709 xmalloc anew.
10710
e061a11b
TZ
107112011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10712
10713 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10714 callbacks stage.
10715
10716 * gnutls.c: Renamed global_initialized to
10717 gnutls_global_initialized. Added internals for the
10718 :verify-hostname-error, :verify-error, and :verify-flags
10719 parameters of `gnutls-boot' and documented those parameters in the
10720 docstring. Start callback support.
9173deec
JB
10721 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10722 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10723 on error. Return error code.
e061a11b
TZ
10724 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10725 (emacs_gnutls_read): Likewise.
10726 (Fgnutls_boot): Return handshake error code.
10727 (emacs_gnutls_handle_error): New function.
10728 (wsaerror_to_errno): Likewise.
10729
10730 * w32.h (emacs_gnutls_pull): Add prototype.
10731 (emacs_gnutls_push): Likewise.
10732
10733 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10734 (emacs_gnutls_push): Likewise.
10735
107362011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10737
10738 * process.c (wait_reading_process_output): Check if GnuTLS
10739 buffered some data internally if no FDs are set for TLS
10740 connections.
10741
10742 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10743 (LIBS): Link to USER_LIBS.
10744 ($(BLD)/gnutls.$(0)): New target.
10745
fa6996bc
EZ
107462011-04-24 Eli Zaretskii <eliz@gnu.org>
10747
eb35682e
EZ
10748 * xdisp.c (handle_single_display_spec): Rename the
10749 display_replaced_before_p argument into display_replaced_p, to
10750 make it consistent with the commentary. Fix typos in the
10751 commentary.
10752
e2ad650c
EZ
10753 * textprop.c (syms_of_textprop): Remove dead code.
10754 (copy_text_properties): Delete obsolete commentary about an
10755 interface that was deleted long ago. Fix typos in the description
10756 of arguments.
10757
1b2de274
EZ
10758 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10759 to changes in oldXMenu/XMenu.h from 2011-04-16.
10760 <menu_help_message, prev_menu_help_message>: Constify.
10761 (IT_menu_make_room): menu->help_text is now `const char **';
10762 adjust.
10763
10764 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10765 to changes in oldXMenu/XMenu.h from 2011-04-16.
10766 (struct XMenu): Declare `help_text' `const char **'.
10767
10768 * xfaces.c <Qunspecified>: Make extern again.
10769
10770 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10771 required by POSIX.
1b2de274 10772
762b15be
EZ
10773 * doc.c (get_doc_string): Improve the format passed to `error'.
10774
10775 * doprnt.c (doprnt): Improve commentary.
10776
10777 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10778
10779 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10780 them with etags.
10781
f1052e5d
EZ
10782 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10783 changes in globals.h immediately force recompilation.
762b15be
EZ
10784 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10785 $(CURDIR)/s/ms-w32.h.
10786 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10787
fa6996bc
EZ
10788 * character.c (Fchar_direction): Function deleted.
10789 (syms_of_character): Don't defsubr it.
10790 <char-direction-table>: Deleted.
10791
e6c3da20
EZ
107922011-04-23 Eli Zaretskii <eliz@gnu.org>
10793
10794 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10795 * doprnt.c: Include limits.h.
10796 (SIZE_MAX): New macro.
04f2d78b
CB
10797 (doprnt): Return a size_t value. 2nd arg is now size_t.
10798 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10799 Improve overflow protection. Support `l' modifier for integer
10800 conversions. Support %l conversion. Don't assume an EMACS_INT
10801 argument for integer conversions and for %c.
10802
10803 * lisp.h (doprnt): Restore prototype.
10804
10805 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10806 $(SRC)/character.h.
10807
10808 * Makefile.in (base_obj): Add back doprnt.o.
10809
10810 * deps.mk (doprnt.o): Add back prerequisites.
10811 (callint.o): Depend on character.h.
10812
10813 * eval.c (internal_lisp_condition_case): Include the handler
10814 representation in the error message.
10815 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10816 when breaking from the loop.
10817
10818 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10819
10820 * callint.c (Fcall_interactively): When displaying error message
10821 about invalid control letter, pass the character's codepoint, not
10822 a pointer to its multibyte form. Improve display of the character
10823 in octal and display also its hex code.
10824
10825 * character.c (char_string): Use %x to display the (unsigned)
10826 codepoint of an invalid character, to avoid displaying a bogus
10827 negative value.
10828
10829 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10830 `error', not SYMBOL_NAME itself.
10831
10832 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10833 character arguments to `error'.
10834
10835 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10836 to `error' in error message about FINAL_CHAR argument. Make sure
10837 FINAL_CHAR is a character, and use %c when it is passed as
10838 argument to `error'.
10839
4ffd0d6b 108402011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10841
10842 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10843
10844 * w32.c: Include <time.h>.
10845 (sys_localtime): New function.
10846
4ffd0d6b 108472011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10848
10849 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10850
4ffd0d6b 10851 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10852
4ffd0d6b 108532011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10854
4ffd0d6b
GM
10855 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10856 zombies (Bug#8467).
aac0c6e3 10857
04c56954
EZ
108582011-04-19 Eli Zaretskii <eliz@gnu.org>
10859
10860 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10861 gl_state.e_property when gl_state.object is Qt.
10862
10863 * insdel.c (make_gap_larger): Remove limitation of buffer size
10864 to <= INT_MAX.
10865
16a43933
CY
108662011-04-18 Chong Yidong <cyd@stupidchicken.com>
10867
10868 * xdisp.c (lookup_glyphless_char_display)
10869 (produce_glyphless_glyph): Handle cons cell entry in
10870 glyphless-char-display.
10871 (Vglyphless_char_display): Document it.
10872
10873 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10874 glyphless-char-display.
10875
4581706e
CY
108762011-04-17 Chong Yidong <cyd@stupidchicken.com>
10877
10878 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10879
10880 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10881
10882 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10883 definition for no-X builds.
10884
4887c6e2 108852011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10886
fd35b6f9
PE
10887 Static checks with GCC 4.6.0 and non-default toolkits.
10888
5c1ccb01
PE
10889 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10890
006c5daa
PE
10891 * process.c (keyboard_bit_set): Define only if SIGIO.
10892 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10893 (send_process): Repair possible setjmp clobbering.
10894
efc736d3
PE
10895 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10896
4e2fe2e6
PE
10897 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10898
f97334a2
PE
10899 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10900
4e75f29d
PE
10901 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10902 Define only if needed.
10903
90efadd1
PE
10904 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10905 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10906 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10907
3c647824
PE
10908 * dispextern.h (struct redisplay_interface): Rename param
10909 to avoid shadowing.
e264f262 10910 * termhooks.h (struct terminal): Likewise.
761383f4 10911 * xterm.c (xembed_send_message): Likewise.
3c647824 10912
b58c5c4a
PE
10913 * insdel.c (make_gap_smaller): Define only if
10914 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10915
cad59032
PE
10916 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10917 it.
10918
c339dc2e
PE
10919 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10920 so that we aren't warned about unused symbols.
10921
91a3e27b
PE
10922 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10923
399c71d3 10924 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10925
8ffc96f5
PE
10926 * xfns.c (x_real_positions): Mark locals as initialized.
10927
eef9bc79
PE
10928 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10929
098db9dd
PE
10930 * xterm.c: Fix problems found by static analysis with other toolkits.
10931 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10932 (x_dispatch_event): Declare static if USE_GTK, and
10933 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10934 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10935 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10936 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10937 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10938
eb18f6cc
PE
10939 * xmenu.c (menu_help_callback): Pointer type fixes.
10940 Use const pointers when pointing at readonly data. Avoid pointer
10941 signedness clashes.
10942 (FALSE): Remove unused macro.
10943 (update_frame_menubar): Remove unused decl.
10944
1fe72bf8
PE
10945 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10946
60d9e1db
PE
10947 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10948 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10949 (single_menu_item): Rename local to avoid shadowing.
10950
39261c26
PE
10951 * keyboard.c (make_lispy_event): Remove unused local var.
10952
018c5e19
PE
10953 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10954 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10955
63d2b86e
PE
10956 * bitmaps: Change bitmaps from unsigned char back to the X11
10957 compatible char. Avoid the old compiler warnings about
10958 out-of-range initializers by using, for example, '\xab' rather
10959 than 0xab.
10960
aefd87e1
PE
10961 * xgselect.c (xgselect_initialize): Check vs interface
10962 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10963
bf501fb9
PE
10964 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10965
e9829fdf
PE
10966 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10967 to read-only memory.
10968
1086c095
PE
10969 * fns.c (vector): Remove; this old hack is no longer needed.
10970
2baccd04 10971 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10972 Remove unused var.
dde42981 10973 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10974
72391843 10975 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10976
436c16df 10977 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10978 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10979 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10980
92bb796d 10981 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10982 (x_term_init): Remove local to avoid shadowing.
92bb796d 10983
764430a3 10984 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10985
10986 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10987 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10988
d1dfb56c
EZ
109892011-04-16 Eli Zaretskii <eliz@gnu.org>
10990
c4354cb4
EZ
10991 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10992
d1dfb56c
EZ
10993 Fix regex.c, syntax.c and friends for buffers > 2GB.
10994 * syntax.h (struct gl_state_s): Declare character position members
10995 EMACS_INT.
10996
10997 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10998
04f2d78b
CB
10999 * textprop.c (verify_interval_modification, interval_of):
11000 Declare arguments EMACS_INT.
d1dfb56c
EZ
11001
11002 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11003 EMACS_INT.
11004
11005 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11006
11007 * indent.c (Fvertical_motion): Local variable it_start is now
11008 EMACS_INT.
11009
11010 * regex.c (re_match, re_match_2, re_match_2_internal)
11011 (bcmp_translate, regcomp, regexec, print_double_string)
11012 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11013 (re_compile_pattern, re_exec): Declare arguments and local
11014 variables `size_t' and `ssize_t' and return values `regoff_t', as
11015 appropriate.
11016 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11017 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11018 <compile_stack_type>: `size' and `avail' are now `size_t'.
11019
11020 * regex.h <regoff_t>: Use ssize_t, not int.
11021 (re_search, re_search_2, re_match, re_match_2): Arguments that
11022 specify buffer/string position and length are now ssize_t and
11023 size_t. Return type is regoff_t.
11024
613052cd
BK
110252011-04-16 Ben Key <bkey76@gmail.com>
11026
11027 * nsfont.m: Fixed bugs in ns_get_family and
11028 ns_descriptor_to_entity that were caused by using free to
11029 deallocate memory blocks that were allocated by xmalloc (via
11030 xstrdup). This caused Emacs to crash when compiled with
11031 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11032 --enable-checking=xmallocoverrun). xfree is now used to
11033 deallocate these memory blocks.
11034
4170f62f 110352011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11036
71b41406
PE
11037 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11038
9587a89d
PE
11039 emacs_write: Accept and return EMACS_INT for sizes.
11040 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11041 et seq.
11042 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11043 Accept and return EMACS_INT.
11044 (emacs_gnutls_write): Return the number of bytes written on
11045 partial writes.
11046 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11047 (emacs_read, emacs_write): Remove check for negative size, as the
11048 Emacs source code has been audited now.
9587a89d
PE
11049 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11050 (emacs_read, emacs_write): Use it.
273a5f82
PE
11051 * process.c (send_process): Adjust to the new signatures of
11052 emacs_write and emacs_gnutls_write. Do not attempt to store
11053 a byte offset into an 'int'; it might overflow.
9587a89d 11054 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11055
3e047f51
PE
11056 * sound.c: Don't assume sizes fit in 'int'.
11057 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11058 Return EMACS_INT, not int.
3e047f51 11059 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11060 Accept EMACS_INT, not int.
11061 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11062 record read return values.
11063
cc39a9db
BK
110642011-04-15 Ben Key <bkey76@gmail.com>
11065
c9d0ec6d
JB
11066 * keyboard.c (Qundefined): Don't declare static since it is used
11067 in nsfns.m.
11068 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11069 static since they are used in nsfont.m.
cc39a9db 11070
6c60eb9f
SM
110712011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11072
11073 * process.c (Qprocessp): Don't declare static.
11074 * lisp.h (Qprocessp): Declare again.
11075
7990b61a
JB
110762011-04-15 Juanma Barranquero <lekktu@gmail.com>
11077
11078 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11079
5d4cb038
PE
110802011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11081
8bd7b830 11082 Improve C-level modularity by making more things 'static'.
cd64ea1d 11083
e3b27b31
PE
11084 Don't publish debugger-only interfaces to other modules.
11085 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11086 (verify_bytepos, count_markers): Move decls to the only modules
11087 that need them.
11088 * region-cache.h (pp_cache): Likewise.
11089 * window.h (check_all_windows): Likewise.
11090 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11091
5d4cb038
PE
11092 * sysdep.c (croak): Now static, if
11093 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11094 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11095
11096 * alloc.c (refill_memory_reserve): Now static if
11097 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11098 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11099
e87b6180
PE
11100 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11101 Define only if USE_LUCID.
11102
ac64929e
PE
11103 * xrdb.c (x_customization_string, x_rm_string): Now static.
11104
6f37259d
PE
11105 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11106 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11107
1683e3ab
PE
11108 * xdisp.c (draw_row_with_mouse_face): Now static.
11109 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11110
de9c2632
PE
11111 * window.h (check_all_windows): Mark externally visible.
11112
2b96acb7
PE
11113 * window.c (window_deletion_count): Now static.
11114
11115 * undo.c: Make symbols static if they're not exported.
11116 (last_undo_buffer, last_boundary_position, pending_boundary):
11117 Now static.
11118
50436f33
PE
11119 * textprop.c (interval_insert_behind_hooks): Now static.
11120 (interval_insert_in_front_hooks): Likewise.
11121
64520e5c
PE
11122 * term.c: Make symbols static if they're not exported.
11123 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11124 (max_frame_lines, tty_set_terminal_modes):
11125 (tty_reset_terminal_modes, tty_turn_off_highlight):
11126 (get_tty_terminal): Now static.
11127 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11128 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11129 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11130 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11131 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11132
1fa53021
PE
11133 * sysdep.c: Make symbols static if they're not exported.
11134 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11135 Now static.
11136 (sigprocmask_set, full_mask): Remove; unused.
11137 (wait_debugging): Mark as visible.
11138 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11139 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11140
d4b43b22
PE
11141 * syntax.c (syntax_temp): Define only if !__GNUC__.
11142
b7c513d0
PE
11143 * sound.c (current_sound_device, current_sound): Now static.
11144
989b29ad
PE
11145 * search.c (searchbufs, searchbuf_head): Now static.
11146
13a55a78
PE
11147 * scroll.c (scroll_cost): Remove; unused.
11148 * dispextern.h (scroll_cost): Remove decl.
11149
de68a1fc
PE
11150 * region-cache.h (pp_cache): Mark as externally visible.
11151
40ccffa6
PE
11152 * process.c: Make symbols static if they're not exported.
11153 (process_tick, update_tick, create_process, chan_process):
11154 (Vprocess_alist, proc_buffered_char, datagram_access):
11155 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11156 (deactivate_process): Mark defn as static, as well as decl.
11157 * lisp.h (create_process): Remove decl.
11158 * process.h (chan_process, Vprocess_alist): Remove decls.
11159
ad64fc97
PE
11160 * print.c: Make symbols static if they're not exported.
11161 (print_depth, new_backquote_output, being_printed, print_buffer):
11162 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11163 (print_interval, print_number_index, initial_stderr_stream):
11164 Now static.
11165 * lisp.h (Fprinc): Remove decl.
11166 (debug_output_compilation_hack): Mark as externally visible.
11167
adddb265
PE
11168 * sysdep.c (croak): Move decl from here to syssignal.h.
11169 * syssignal.h (croak): Put it here, so the API can be checked when
11170 'croak' is called from dissociate_if_controlling_tty.
11171
1717ede2
PE
11172 * minibuf.c: Make symbols static if they're not exported.
11173 (minibuf_save_list, choose_minibuf_frame): Now static.
11174 * lisp.h (choose_minibuf_frame): Remove decl.
11175
fa5fb2bc
PE
11176 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11177
1e3890d1
PE
11178 * lread.c: Make symbols static if they're not exported.
11179 (read_objects, initial_obarray, oblookup_last_bucket_number):
11180 Now static.
11181 (make_symbol): Remove; unused.
11182 * lisp.h (initial_obarray, make_symbol): Remove decls.
11183
8a1414fa
PE
11184 * keyboard.c: Make symbols static if they're not exported.
11185 (single_kboard, recent_keys_index, total_keys, recent_keys):
11186 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11187 (this_single_command_key_start, echoing, last_auto_save):
11188 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11189 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11190 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11191 (Vlispy_mouse_stem, double_click_count):
11192 Now static.
11193 (force_auto_save_soon): Define only if SIGDANGER.
11194 (ignore_mouse_drag_p): Now static if
11195 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11196 (print_help): Remove; unused.
11197 (stop_character, last_timer_event): Mark as externally visible.
11198 * keyboard.h (ignore_mouse_drag_p): Declare only if
11199 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11200 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11201 * lisp.h (echoing): Remove decl.
11202 (force_auto_save_soon): Declare only if SIGDANGER.
11203 * xdisp.c (redisplay_window): Simplify code, to make it more
11204 obvious that ignore_mouse_drag_p is not accessed if !defined
11205 USE_GTK && !defined HAVE_NS.
11206
93ea6e8f
PE
11207 * intervals.c: Make symbols static if they're not exported.
11208 (merge_properties_sticky, merge_interval_right, delete_interval):
11209 Now static.
11210 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11211
77382fcc
PE
11212 * insdel.c: Make symbols static if they're not exported.
11213 However, leave prepare_to_modify_buffer alone. It's never
11214 called from outside this function, but that appears to be a bug.
11215 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11216 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11217 (adjust_after_replace_noundo): Remove; unused.
11218 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11219 (signal_before_change): Remove decls.
77382fcc 11220
9306c32e
PE
11221 * indent.c (val_compute_motion, val_vmotion): Now static.
11222
cd44d2eb
PE
11223 * image.c: Make symbols static if they're not exported.
11224 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11225 if USE_GTK.
11226 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11227 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11228
ad9a7a06
PE
11229 * fringe.c (standard_bitmaps): Now static.
11230 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11231
81626931
PE
11232 * frame.c: Make symbols static if they're not exported.
11233 (x_report_frame_params, make_terminal_frame): Now static.
11234 (get_frame_param): Now static, unless HAVE_NS.
11235 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11236 (x_get_resource_string): Remove; not used.
11237 * frame.h (make_terminal_frame, x_report_frame_params):
11238 (x_get_resource_string); Remove decls.
11239 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11240 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11241
239f9db9
PE
11242 * font.c, fontset.c: Make symbols static if they're not exported.
11243 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11244 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11245 * font.c (font_close_object): Now static.
11246 * font.h (font_close_object): Remove.
11247 * fontset.c (FONTSET_OBJLIST): Remove.
11248 (free_realized_fontset) #if-0 the body, which does nothing.
11249 (face_suitable_for_char_p): #if-0, as it's never called.
11250 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11251 * xfaces.c (face_at_string_position):
11252 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11253 since 0 is always ASCII.
11254
dfcf3579
PE
11255 * fns.c (weak_hash_tables): Now static.
11256
5045092b
PE
11257 * fileio.c: Make symbols static if they're not exported.
11258 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11259 (Vwrite_region_annotation_buffers): Now static.
11260
57a96f5c
PE
11261 * eval.c: Make symbols static if they're not exported.
11262 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11263 * lisp.h (backtrace_list): Remove decl.
11264
35f08c38
PE
11265 * emacs.c: Make symbols static if they're not exported.
11266 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11267 (fatal_error_code, fatal_error_signal_hook, standard_args):
11268 Now static.
11269 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11270 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11271 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11272 * lisp.h (fatal_error_signal_hook): Remove decl.
11273 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11274
f44bd759
PE
11275 * editfns.c: Move a (normally-unused) function to its only use.
11276 * editfns.c, lisp.h (get_operating_system_release): Remove.
11277 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11278 worth the hassle of breaking this out.
11279
b532497d
PE
11280 * xterm.c: Make symbols static if they're not exported.
11281 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11282 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11283 (x_destroy_window, x_delete_display):
11284 Now static.
11285 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11286 (x_mouse_leave): Remove; unused.
11287 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11288 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11289 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11290 Remove decls.
11291 (x_mouse_leave): Declare only if WINDOWSNT.
11292 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11293 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11294 USE_X_TOOLKIT.
11295
1675728f
PE
11296 * ftxfont.c: Make symbols static if they're not exported.
11297 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11298 HAVE_FREETYPE.
11299 * font.h (ftxfont_driver): Likewise.
11300
e4cebfca
PE
11301 * xfns.c: Make symbols static if they're not exported.
11302 (x_last_font_name, x_display_info_for_name):
11303 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11304 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11305 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11306 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11307 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11308 (last_show_tip_args): Now static.
11309 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11310 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11311 (x_screen_planes): Remove; unused.
11312 * dispextern.h (x_screen_planes): Remove decl.
11313
5bf46f05
PE
11314 * dispnew.c: Make symbols static if they're not exported.
11315 * dispextern.h (redraw_garbaged_frames, scrolling):
11316 (increment_row_positions): Remove.
11317 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11318 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11319 Now static.
11320 (redraw_garbaged_frames): Remove; unused.
11321
435f4c28
PE
11322 * xfaces.c: Make symbols static if they're not exported.
11323 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11324 Remove decls.
11325 * xterm.h (defined_color): Remove decls.
11326 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11327 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11328 (menu_face_changed_default, defined_color, free_realized_face):
11329 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11330 (ascii_face_of_lisp_face): Remove; unused.
11331
8524aef3
PE
11332 * xdisp.c: Make symbols static if they're not exported.
11333 * dispextern.h (scratch_glyph_row, window_box_edges):
11334 (glyph_to_pixel_coords, set_cursor_from_row):
11335 (get_next_display_element, set_iterator_to_next):
11336 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11337 (show_mouse_face): Remove decls
11338 * frame.h (message_buf_print): Likewise.
11339 * lisp.h (pop_message, set_message, check_point_in_composition):
11340 Likewise.
11341 * xterm.h (set_vertical_scroll_bar): Likewise.
11342 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11343 (message_buf_print, scratch_glyph_row, displayed_buffer):
11344 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11345 (get_next_display_element, show_mouse_face, window_box_edges):
11346 (frame_to_window_pixel_xy, check_point_in_composition):
11347 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11348 (glyph_to_pixel_coords): Remove; unused.
11349
16390cd2
PE
11350 * dired.c (file_name_completion): Now static.
11351
11352 * dbusbind.c (xd_in_read_queued_messages): Now static.
11353
a25f4dfa
PE
11354 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11355 * data.c (circular_list_error): Remove.
11356
14a9c8df
PE
11357 * commands.h (last_point_position, last_point_position_buffer):
11358 (last_point_position_window): Remove decls.
11359 * keyboard.c: Make these variables static.
11360
04f2d78b
CB
11361 * coding.h (coding, code_convert_region, encode_coding_gap):
11362 Remove decls.
74ab6df5
PE
11363 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11364 (iso_code_class, detect_coding, code_convert_region): Now static.
11365 (encode_coding_gap): Remove; unused.
11366
38dfbee1
PE
11367 * chartab.c (chartab_chars, chartab_bits): Now static.
11368
a2cb4e63
PE
11369 * charset.h (charset_iso_8859_1): Remove decl.
11370 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11371 Now static.
11372
127198fd
PE
11373 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11374 * ccl.c (Vccl_program_table): Now static.
11375 (check_ccl_update): Remove; unused.
11376
d85b608f
PE
11377 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11378 * category.h: ... from here.
11379 * category.c (check_category_table, set_category_set): Now static.
11380
31cd66f3
PE
11381 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11382 * lisp.h: Remove these decls.
11383
c358e587
PE
11384 * buffer.c (buffer_count): Remove unused var.
11385
e78aecca
PE
11386 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11387 so that it's not optimized away.
11388 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11389 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11390 exported only to the debugger.
11391
e192d7d3 11392 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11393 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11394
92470028
PE
11395 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11396 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11397 was inaccessible from Lisp.
11398 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11399 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11400
244ed907
PE
11401 alloc.c: Import and export fewer symbols, and remove unused items.
11402 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11403 is defined.
11404 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11405 it's not optimized away by whole-program optimization.
11406 (message_enable_multibyte, free_misc): Remove.
11407 (catchlist, handlerlist, mark_backtrace):
11408 Declare only if BYTE_MARK_STACK.
11409 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11410 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11411 (message_enable_multibyte): Remove decl.
11412 (free_misc, interval_free_list, float_block, float_block_index):
11413 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11414 (cons_free_list, last_marked_index):
11415 Now static.
11416 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11417 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11418 (mark_backtrace): Define only if BYTE_MARK_STACK.
11419 * xdisp.c (message_enable_multibyte): Now static.
11420
61c2b50e 11421 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11422 This makes it easier for human readers (and static analyzers)
11423 to see whether these variables are used from other modules.
11424 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11425 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11426 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11427 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11428 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11429 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11430 * xmenu.c, xselect.c:
11431 Declare Q* vars static if they are not used in other modules.
11432 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11433 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11434 Remove decls of unexported vars.
11435 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11436
95c82688
PE
11437 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11438
16a97296
PE
11439 Make Emacs functions such as Fatom 'static' by default.
11440 This makes it easier for human readers (and static analyzers)
11441 to see whether these functions can be called from other modules.
11442 DEFUN now defines a static function. To make the function external
11443 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11444 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11445 (Finit_image_library):
16a97296
PE
11446 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11447 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11448 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11449 Remove decls, since these functions are now static.
11450 (Funintern, Fget_internal_run_time): New decls, since these functions
11451 were already external.
95c82688 11452
16a97296
PE
11453 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11454 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11455 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11456 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11457 * keyboard.c, keymap.c, lread.c:
11458 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11459 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11460 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11461 Mark functions with DEFUE instead of DEFUN,
11462 if they are used in other modules.
11463 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11464 decls for now-static functions.
11465 * buffer.h (Fdelete_overlay): Remove decl.
11466 * callproc.c (Fgetenv_internal): Mark as internal.
11467 * composite.c (Fremove_list_of_text_properties): Remove decl.
11468 (Fcomposition_get_gstring): New forward static decl.
11469 * composite.h (Fcomposite_get_gstring): Remove decl.
11470 * dired.c (Ffile_attributes): New forward static decl.
11471 * doc.c (Fdocumntation_property): New forward static decl.
11472 * eval.c (Ffetch_bytecode): New forward static decl.
11473 (Funintern): Remove extern decl; now in .h file where it belongs.
11474 * fileio.c (Fmake_symbolic_link): New forward static decl.
11475 * image.c (Finit_image_library): New forward static decl.
11476 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11477 * intervals.h (Fprevious_property_change):
11478 (Fremove_list_of_text_properties): Remove decls.
11479 * keyboard.c (Fthis_command_keys): Remove decl.
11480 (Fcommand_execute): New forward static decl.
11481 * keymap.c (Flookup_key): New forward static decl.
11482 (Fcopy_keymap): Now static.
11483 * keymap.h (Flookup_key): Remove decl.
11484 * process.c (Fget_process): New forward static decl.
11485 (Fprocess_datagram_address): Mark as internal.
11486 * syntax.c (Fsyntax_table_p): New forward static decl.
11487 (skip_chars): Remove duplicate decl.
11488 * textprop.c (Fprevious_property_change): New forward static decl.
11489 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11490 Now internal.
11491 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11492 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11493
785bbd42
PE
11494 * editfns.c (Fformat): Remove unreachable code.
11495
8b913b57
AS
114962011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11497
11498 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11499 change. (Bug#8496)
11500
a6744a35
EZ
115012011-04-13 Eli Zaretskii <eliz@gnu.org>
11502
11503 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11504 when at ZV. (Bug#8487)
11505
e7974947
AS
115062011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11507
baad03f0
AS
11508 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11509 (Bug#8437)
11510 * keyboard.c (parse_tool_bar_item): Likewise.
11511 * sound.c (sound_cleanup, alsa_close): Likewise.
11512 * termcap.c (tgetent): Likewise.
11513 * xfns.c (x_default_font_parameter): Likewise.
11514 * xsettings.c (read_and_apply_settings): Likewise.
11515
e7974947
AS
11516 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11517 (overrun_check_free): Protoize.
11518
28272684
PE
115192011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11520
11521 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11522 since callers should never pass a negative size.
11523 Change the signature to match that of plain 'read' and 'write'; see
11524 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11525 * lisp.h: Update prototypes of emacs_write and emacs_read.
11526
11997c76
EZ
115272011-04-11 Eli Zaretskii <eliz@gnu.org>
11528
11529 * xdisp.c (redisplay_window): Don't try to determine the character
11530 position of the scroll margin if the window start point w->startp
e896f03c 11531 is outside the buffer's accessible region. (Bug#8468)
11997c76 11532
8a2cbd72
EZ
115332011-04-10 Eli Zaretskii <eliz@gnu.org>
11534
11535 Fix write-region and its subroutines for buffers > 2GB.
11536 * fileio.c (a_write, e_write): Modify declaration of arguments and
11537 local variables to support buffers larger than 2GB.
11538 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11539
11540 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11541 argument, local variables, and return value.
11542
11543 * lisp.h: Update prototypes of emacs_write and emacs_read.
11544
11545 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11546
4073e537 115472011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11548
1ebfdcb6
PE
11549 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11550
b2ded58d
PE
11551 Fix more problems found by GCC 4.6.0's static checks.
11552
7d66342c
PE
11553 * xdisp.c (vmessage): Use a better test for character truncation.
11554
bbf47d44
PE
11555 * charset.c (load_charset_map): <, not <=, for optimization,
11556 and to avoid potential problems with integer overflow.
9248994d 11557 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11558 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11559 * editfns.c (Fformat): Likewise.
1e69125e 11560 * syntax.c (skip_chars): Likewise.
3befa583 11561
e3019616
PE
11562 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11563 This also lets GCC 4.6.0 generate slightly better loop code.
11564
becfa255
PE
11565 * callint.c (Fcall_interactively): <, not <=, for optimization.
11566 (Fcall_interactively): Count the number of arguments produced,
11567 not the number of arguments given. This is simpler and lets GCC
11568 4.6.0 generate slightly better code.
11569
dae0cd48
PE
11570 * ftfont.c: Distingish more carefully between FcChar8 and char.
11571 The previous code passed unsigned char * to a functions like
11572 strlen and xstrcasecmp that expect char *, which does not
11573 conform to the C standard.
11574 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11575 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11576 char * when the C standard requires it.
11577
76032d70
PE
11578 * keyboard.c (read_char): Remove unused var.
11579
eb3f1cc8
PE
11580 * eval.c: Port to Windows vsnprintf (Bug#8435).
11581 Include <limits.h>.
11582 (SIZE_MAX): Define if the headers do not.
11583 (verror): Do not give up if vsnprintf returns a negative count.
11584 Instead, grow the buffer. This ports to Windows vsnprintf, which
11585 does not conform to C99. Problem reported by Eli Zaretskii.
11586 Also, simplify the allocation scheme, by avoiding the need for
11587 calling realloc, and removing the ALLOCATED variable.
11588
70476b54
PE
11589 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11590
12020a9e
PE
11591 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11592 But keep the doprint source code for now, as we might revamp it
11593 and use it again (Bug#8435).
ea6c7ae6
PE
11594 * lisp.h (doprnt): Remove.
11595 * Makefile.in (base_obj): Remove doprnt.o.
11596 * deps.mk (doprnt.o): Remove.
11597
5fdb398c
PE
11598 error: Print 32- and 64-bit integers portably (Bug#8435).
11599 Without this change, on typical 64-bit hosts error ("...%d...", N)
11600 was used to print both 32- and 64-bit integers N, which relied on
11601 undefined behavior.
61bdb816 11602 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11603 * lisp.h (error, verror): Mark as printf-like functions.
11604 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11605 Report overflow in size calculations when allocating printf buffer.
11606 Do not truncate output string at its first null byte.
11607 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11608 Truncate the output at a character boundary, since vsnprintf does not
11609 do that.
11610 * charset.c (check_iso_charset_parameter): Convert internal
11611 character to string before calling 'error', since %c now has the
11612 printf meaning.
11613 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11614 overflow when computing char to be passed to 'error'. Do not
11615 pass Lisp_Object to 'error'; pass the integer instead.
11616 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11617 formatted with plain %d.
11618
b189fa66
PE
11619 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11620
bff87ef0
PE
11621 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11622
7e2cac20
PE
11623 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11624
ce4d90b5
PE
11625 * xterm.c (x_catch_errors): Remove duplicate declaration.
11626
266c9547
PE
11627 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11628
79c49ad2
PE
11629 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11630
368f4090
JM
116312011-04-10 Jim Meyering <meyering@redhat.com>
11632
11633 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11634 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11635 return ssize_t not "int", and use size_t as the buffer length.
11636 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11637 * gnutls.h: Update declarations.
11638 * process.c (read_process_output): Use ssize_t, to match.
11639 (send_process): Likewise.
11640
a32d4040
CY
116412011-04-09 Chong Yidong <cyd@stupidchicken.com>
11642
11643 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11644
8546720e 116452011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11646
04f2d78b
CB
11647 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11648 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11649
8546720e
GM
11650 * xterm.c (handle_one_xevent):
11651 * xmenu.c (create_and_show_popup_menu):
11652 * xselect.c (x_decline_selection_request)
11653 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11654
0a2f5c1a 116552011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11656
11657 Fix some uses of `int' instead of EMACS_INT.
11658 * search.c (string_match_1, fast_string_match)
11659 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11660 (scan_buffer, find_next_newline_no_quit)
11661 (find_before_next_newline, search_command, Freplace_match)
11662 (Fmatch_data): Make some `int' variables be EMACS_INT.
11663
11664 * xdisp.c (display_count_lines): 3rd argument and return value now
11665 EMACS_INT. All callers changed.
11666 (pint2hrstr): Last argument is now EMACS_INT.
11667
11668 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11669 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11670 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11671 (decode_coding_utf_16, decode_coding_emacs_mule)
11672 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11673 (decode_coding_ccl, decode_coding_charset)
11674 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11675 (decode_coding_iso_2022, decode_coding_emacs_mule)
11676 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11677 <char_offset, last_offset>: Declare EMACS_INT.
11678 (encode_coding_utf_8, encode_coding_utf_16)
11679 (encode_coding_emacs_mule, encode_invocation_designation)
11680 (encode_designation_at_bol, encode_coding_iso_2022)
11681 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11682 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11683 Declare EMACS_INT.
11684 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11685 (encode_invocation_designation): Last argument P_NCHARS is now
11686 EMACS_INT.
11687 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11688 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11689
11690 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11691 All users changed.
11692
11693 * ccl.c (Fccl_execute_on_string): Declare some variables
11694 EMACS_INT.
11695
8546720e 116962011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11697
11698 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11699
4e19a977
CS
117002011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11701
11702 * process.c (Fformat_network_address): Doc fix.
11703
87302331
R
117042011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11705
ee7683eb 11706 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11707
cbb59342
CY
117082011-04-08 Chong Yidong <cyd@stupidchicken.com>
11709
11710 * keyboard.c (read_char): Call Lisp function help-form-show,
11711 instead of using internal_with_output_to_temp_buffer.
11712 (Qhelp_form_show): New var.
e0d38eeb 11713 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11714
11715 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11716
11717 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11718
e67a13ab
CY
117192011-04-06 Chong Yidong <cyd@stupidchicken.com>
11720
04f2d78b
CB
11721 * process.c (Flist_processes): Remove to Lisp.
11722 (list_processes_1): Delete.
e67a13ab 11723
973f782d
EZ
117242011-04-06 Eli Zaretskii <eliz@gnu.org>
11725
7c106b1e
EZ
11726 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11727
973f782d
EZ
11728 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11729
41cf7d1a 117302011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11731
ca23cc88
PE
11732 Fix more problems found by GCC 4.6.0's static checks.
11733
f390e2d5
PE
11734 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11735
42eea0d0
PE
11736 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11737
b69769da 11738 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11739
f9541e84
PE
11740 * xdisp.c (vmessage): Mark as a printf-like function.
11741
13841b55
PE
11742 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11743
c136c10f
PE
11744 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11745
5e2d4a30
PE
11746 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11747 printf-like functions.
11748 (tiff_load): Add casts to remove these marks before passing them
11749 to system-supplied API.
11750
583f48b9
PE
11751 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11752
b25d760e
PE
11753 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11754 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11755 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11756 directly, rather than having caller test rule sign. This avoids
11757 some unnecessary tests.
11758 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11759 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11760 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11761
bc7b6697 11762 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11763 (xfont_open): Avoid unnecessary tests.
bc7b6697 11764
27ccc379
PE
11765 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11766
dcd5c89a
PE
11767 * composite.h, composite.c (composition_gstring_put_cache):
11768 Use EMACS_INT, not int, for length.
11769
b13a45c6
PE
11770 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11771 breaking out part of COMPOSITION_DECODE_RULE.
11772 (COMPOSITION_DECODE_RULE): Use it.
11773 * composite.c (get_composition_id): Remove unused local vars,
11774 by using the new macro.
11775
1e792e4d
PE
11776 * textprop.c (set_text_properties_1): Change while to do-while,
11777 since the condition is always true at first.
11778
dc6c6455 11779 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11780 (interval_deletion_adjustment): Return unsigned value.
11781 All uses changed.
dc6c6455 11782
aba7731a
PE
11783 * process.c (list_processes_1, create_pty, read_process_output):
11784 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11785 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11786 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11787 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11788 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11789
fdfc4bf3
PE
11790 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11791
fca8fe46 11792 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11793 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11794
06a0259a 11795 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11796 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11797 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11798
e7b9e80f
PE
11799 * print.c (print_error_message): Avoid int overflow.
11800
56201685
PE
11801 * font.c (font_list_entities): Redo for clarity,
11802 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11803
78834453 11804 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11805 (font_score): Avoid potential overflow in diff calculation.
78834453 11806
0bc0b309 11807 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11808 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11809
e610eaca
PE
11810 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11811
b895abce
PE
11812 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11813 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11814 can always succeed if overflow has undefined behavior.
11815
1f1d9321 11816 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11817 (wordify): Omit three unnecessary tests.
1f1d9321 11818
c59478bc
PE
11819 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11820 All callers changed. This avoids the need for an unused var.
11821
79b73827
PE
11822 * casefiddle.c (casify_region): Remove var that is set but not used.
11823
a4db5dfe
PE
11824 * dired.c (file_name_completion): Remove var that is set but not used.
11825
43aae36e
PE
11826 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11827
2a47c44d 11828 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11829 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11830
a37c69bf
PE
11831 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11832 Check for integer overflow on size calculations.
11833
328ab8e7
PE
11834 * buffer.c (Fprevious_overlay_change): Remove var that is set
11835 but not used.
11836
e5a2a5cb
PE
11837 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11838 Remove vars that are set but not used.
8d84a6eb 11839 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11840 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11841
a60e5f68
PE
11842 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11843
f661cb61 11844 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11845 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11846
f0397f5a
PE
11847 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11848 that are set but not used.
11849
8664db06 11850 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11851 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11852
6abdaa4a
PE
11853 * xselect.c (x_get_local_selection, x_handle_property_notify):
11854 Remove vars that are set but not used.
11855
0ce7538d 11856 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11857 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11858
9ae848fc
PE
11859 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11860 Remove var that is set but not used.
0b918413
PE
11861 (scroll_bar_windows_size): Now size_t, not int.
11862 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11863 Check for overflow.
9ae848fc 11864
a5a62657
PE
11865 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11866 (map_tty_color) [!defined MSDOS]: Likewise.
11867
5c5cdd39
PE
11868 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11869
66ebf983
PE
11870 * coding.c: Remove vars that are set but not used.
11871 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11872 All callers changed.
11873 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11874 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11875 (decode_coding_charset): Remove vars that are set but not used.
11876
1be4d761
PE
11877 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11878 that is set but not used.
11879
47553fa8
PE
11880 * print.c (print_object): Remove var that is set but not used.
11881
1f7196bf 11882 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11883 The gnulib version avoids calling malloc in the usual case,
11884 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11885 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11886 * filelock.c (current_lock_owner): Likewise.
11887 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11888 * sysdep.c: Include allocator.h, careadlinkat.h.
11889 (emacs_no_realloc_allocator): New static constant.
11890 (emacs_readlink): New function.
fdb61804
PE
11891 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11892 ../lib/careadlinkat.h.
d1fdcab7 11893
f84c17c7
SM
118942011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11895
11896 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11897 first non-nil return value).
11898
ef3862ad
JD
118992011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11900
11901 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11902 if not defined (Bug#8403).
11903
376a7006
JB
119042011-04-02 Juanma Barranquero <lekktu@gmail.com>
11905
11906 * xdisp.c (display_count_lines): Remove parameter `start',
11907 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11908 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11909 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11910 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11911 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11912 and thereabouts. All callers changed.
11913 (get_per_char_metric): Remove parameter `f', unused since
11914 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11915
6ca3801d
JM
119162011-04-02 Jim Meyering <meyering@redhat.com>
11917
11918 do not dereference NULL upon failed strdup
11919 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11920 (ns_get_family): Likewise.
11921
d8e2b5ba
JB
119222011-04-02 Juanma Barranquero <lekktu@gmail.com>
11923
11924 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11925
8c74fcbd
JD
119262011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11927
11928 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11929 later (Bug#8403).
11930
7200d79c
SM
119312011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11932
03408648 11933 Add lexical binding.
7200d79c 11934
03408648
SM
11935 * window.c (Ftemp_output_buffer_show): New fun.
11936 (Fsave_window_excursion):
11937 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11938
11939 * lread.c (lisp_file_lexically_bound_p): New function.
11940 (Fload): Bind Qlexical_binding.
11941 (readevalloop): Remove `evalfun' arg.
11942 Bind Qinternal_interpreter_environment.
11943 (Feval_buffer): Bind Qlexical_binding.
11944 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11945 Mark as dynamic.
11946 (syms_of_lread): Declare `lexical-binding'.
11947
11948 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11949
11950 * keyboard.c (eval_dyn): New fun.
11951 (menu_item_eval_property): Use it.
ca105506
SM
11952
11953 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11954
03408648
SM
11955 * fns.c (concat, mapcar1): Accept byte-code-functions.
11956
11957 * eval.c (Fsetq): Handle lexical vars.
11958 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11959 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11960 (FletX, Flet): Obey lexical binding.
11961 (Fcommandp): Handle closures.
11962 (Feval): New `lexical' arg.
11963 (eval_sub): New function extracted from Feval. Use it almost
11964 everywhere where Feval was used. Look up vars in lexical env.
11965 Handle closures.
11966 (Ffunctionp): Move from subr.el.
11967 (Ffuncall): Handle closures.
11968 (apply_lambda): Remove `eval_flags'.
11969 (funcall_lambda): Handle closures and new byte-code-functions.
11970 (Fspecial_variable_p): New function.
11971 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11972 but without exporting it to Lisp.
23aba0ea 11973
23aba0ea 11974 * doc.c (Fdocumentation, store_function_docstring):
03408648 11975 * data.c (Finteractive_form): Handle closures.
23aba0ea 11976
03408648
SM
11977 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11978 interactive spec.
ba83908c 11979
04f2d78b
CB
11980 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11981 New byte-codes.
03408648
SM
11982 (exec_byte_code): New function extracted from Fbyte_code to handle new
11983 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11984
03408648 11985 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11986
03408648 11987 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11988
e2abce01
JB
119892011-03-31 Juanma Barranquero <lekktu@gmail.com>
11990
11991 * xdisp.c (redisplay_internal): Fix prototype.
11992
63696a73 119932011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11994
63696a73 11995 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11996 (try_scrolling): Use it when setting scroll_limit.
11997 Limit scrolling to 100 screen lines.
63696a73
EZ
11998 (redisplay_window): Even when falling back on "recentering",
11999 position point in the window according to scroll-conservatively,
12000 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12001
12002 (try_scrolling): When point is above the window, allow searching
12003 as far as scroll_max, or one screenful, to compute vertical
12004 distance from PT to the scroll margin position. This prevents
12005 try_scrolling from unnecessarily failing when
12006 scroll-conservatively is set to a value slightly larger than the
12007 window height. Clean up the case of PT below the margin at bottom
12008 of window: scroll_max can no longer be INT_MAX. When aggressive
12009 scrolling is in use, don't let point enter the opposite scroll
12010 margin as result of the scroll.
12011 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12012 threshold of 100 lines for never-recentering scrolling.
12013
e4cc2dfc
JB
120142011-03-31 Juanma Barranquero <lekktu@gmail.com>
12015
12016 * dispextern.h (move_it_by_lines):
12017 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12018 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12019 (message_log_check_duplicate): Remove parameters `prev_bol' and
12020 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12021 (redisplay_internal): Remove parameter `preserve_echo_area',
12022 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12023
12024 * indent.c (Fvertical_motion):
12025 * window.c (window_scroll_pixel_based, Frecenter):
12026 Don't pass `need_y_p' to `move_it_by_lines'.
12027
1c470562
SM
120282011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12029
44f230aa
SM
12030 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12031 steal a few bits to be more compact.
12032 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12033 Remove unneeded casts.
12034
1c470562
SM
12035 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12036
888adce9
ZK
120372011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12038
12039 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12040 binding" message (bug#7967).
12041
f838ed7b
PE
120422011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12043
77861b95
PE
12044 Fix more problems found by GCC 4.6.0's static checks.
12045
de6dbc14
PE
12046 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12047 Remove unused local var.
12048
f838ed7b
PE
12049 * editfns.c (Fmessage_box): Remove unused local var.
12050
792c7b2b
PE
12051 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12052 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12053 Omit unused local vars.
c499e557 12054 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12055 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12056 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12057 Omit unused local var.
12058
ba0165e1
PE
12059 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12060 Don't assume string length fits in int.
32ad8845 12061 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12062 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12063
3c59b4c9
PE
12064 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12065 instead of alloca (Bug#8344).
12066
a3eed478 12067 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12068 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12069
eb4d412d
PE
12070 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12071
1658b401
PE
12072 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12073 concerns.
12074
12075 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12076
12077 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12078
9a2c6e05
PE
12079 * keyboard.c (syms_of_keyboard): Use the same style as later
12080 in this function when indexing through an array. This also
12081 works around GCC bug 48267.
12082
03d0a109
PE
12083 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12084
44f730c8
PE
12085 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12086
fe75f926
PE
12087 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12088 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12089
ffa8c828
PE
12090 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12091 This avoids undefined behavior on integer overflow, and is a bit
12092 more convenient anyway since it is compared to a size_t variable.
12093
c5101a77
PE
12094 Variadic C functions now count arguments with size_t, not int.
12095 This avoids an unnecessary limitation on 64-bit machines, which
12096 caused (substring ...) to crash on large vectors (Bug#8344).
12097 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12098 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12099 All variadic functions and their callers changed accordingly.
c5101a77
PE
12100 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12101 * data.c (arith_driver, float_arith_driver): Likewise.
12102 * editfns.c (general_insert_function): Likewise.
12103 * eval.c (struct backtrace.nargs, interactive_p)
12104 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12105 (funcall_lambda, mark_backtrace): Likewise.
12106 * fns.c (concat): Likewise.
12107 * frame.c (x_set_frame_parameters): Likewise.
12108 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12109 0 if not found, not -1. All callers changed.
12110
dd3f25f7
PE
12111 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12112 (stack_copy_size): Now size_t, not int.
12113 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12114
461c2ab9
JB
121152011-03-28 Juanma Barranquero <lekktu@gmail.com>
12116
12117 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12118 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12119 All callers changed.
12120
12121 * lisp.h (multibyte_char_to_unibyte):
12122 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12123 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12124 * character.h (CHAR_TO_BYTE8):
12125 * cmds.c (internal_self_insert):
12126 * editfns.c (general_insert_function):
12127 * keymap.c (push_key_description):
12128 * search.c (Freplace_match):
12129 * xdisp.c (message_dolog, set_message_1): All callers changed.
12130
f6d62986
SM
121312011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12132
12133 * keyboard.c (safe_run_hook_funcall): New function.
12134 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12135 don't set the hook to nil, but remove the offending function instead.
12136 (Qcommand_hook_internal): Remove, unused.
12137 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12138 Vcommand_hook_internal.
12139
12140 * eval.c (enum run_hooks_condition): Remove.
12141 (funcall_nil, funcall_not): New functions.
12142 (run_hook_with_args): Call each function through a `funcall' argument.
12143 Remove `cond' argument, now redundant.
12144 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12145 (Frun_hook_with_args_until_failure): Adjust accordingly.
12146 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12147
1db5b1ad
JB
121482011-03-28 Juanma Barranquero <lekktu@gmail.com>
12149
12150 * dispextern.h (string_buffer_position): Remove declaration.
12151
12152 * print.c (strout): Remove parameter `multibyte', unused since
12153 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12154
12155 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12156 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12157 All callers changed.
12158
12159 * w32.c (_wsa_errlist): Use braces for struct initializers.
12160
12161 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12162 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12163 All callers changed.
12164 (string_buffer_position): Likewise. Also, make static (it's never
12165 used outside xdisp.c).
12166 (cursor_row_p): Remove parameter `w', unused since
12167 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12168 (decode_mode_spec): Remove parameter `precision', introduced during
12169 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12170 All callers changed.
12171
5ffb62aa
JD
121722011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12173
12174 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12175
461c2ab9 121762011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12177
12178 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12179 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12180 (ns_update_auto_hide_menu_bar): New functions.
12181 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12182 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12183 ns_constrain_all_frames.
12184 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12185 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12186
5c380ffb
JD
121872011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12188
12189 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12190
9af30bdf
GM
121912011-03-27 Glenn Morris <rgm@gnu.org>
12192
12193 * syssignal.h: Replace RETSIGTYPE with void.
12194 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12195 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12196 Replace SIGTYPE with void everywhere.
12197 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12198 * s/template.h (SIGTYPE): Remove commented out definition.
12199
e2abce01
JB
122002011-03-26 Eli Zaretskii <eliz@gnu.org>
12201
12202 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12203 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12204
f868cd8a
JB
122052011-03-26 Juanma Barranquero <lekktu@gmail.com>
12206
59eb0929
JB
12207 * w32.c (read_unc_volume): Use parameter `henum', instead of
12208 global variable `wget_enum_handle'.
12209
12210 * keymap.c (describe_vector): Remove parameters `indices' and
12211 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12212 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12213
f868cd8a
JB
12214 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12215
12216 * keyboard.c (timer_check): Remove parameter `do_it_now',
12217 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12218 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12219 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12220
12221 * keyboard.c (read_char):
12222 * w32menu.c (w32_menu_display_help):
12223 * xmenu.c (show_help_event, menu_help_callback):
12224 Adjust calls to `show_help_echo'.
12225
12226 * gtkutil.c (xg_maybe_add_timer):
12227 * keyboard.c (readable_events):
12228 * process.c (wait_reading_process_output):
12229 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12230
12231 * insdel.c (adjust_markers_gap_motion):
12232 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12233 (gap_left, gap_right): Don't call it.
12234
2ecf6fdb
CY
122352011-03-25 Chong Yidong <cyd@stupidchicken.com>
12236
12237 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12238 incurred during fontification.
12239
6b1f9ba4
JB
122402011-03-25 Juanma Barranquero <lekktu@gmail.com>
12241
12242 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12243 (DEFVAR_PER_BUFFER): Don't pass it.
12244
12245 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12246 (scrolling_window): Don't pass it.
12247
0f4a96b5
JB
122482011-03-25 Juanma Barranquero <lekktu@gmail.com>
12249
12250 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12251
12252 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12253 and `suffix'.
12254 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12255 of variables specific to SELinux and computation of `encoded_absname'.
12256
12257 * image.c (XPutPixel): Remove unused variable `height'.
12258
12259 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12260
12261 * unexw32.c (get_section_info): Remove unused variable `section'.
12262
12263 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12264 (system_process_attributes): Remove unused variable `sess'.
12265 (sys_read): Remove unused variable `err'.
12266
12267 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12268 (w32_wnd_proc): Remove unused variable `isdead'.
12269 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12270 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12271 (x_create_tip_frame): Remove unused variable `tem'.
12272
12273 * w32inevt.c (w32_console_read_socket):
12274 Remove unused variable `no_events'.
12275
12276 * w32term.c (x_draw_composite_glyph_string_foreground):
12277 Remove unused variable `width'.
12278
1149507c
JB
122792011-03-24 Juanma Barranquero <lekktu@gmail.com>
12280
12281 * w32term.c (x_set_glyph_string_clipping):
12282 Don't pass uninitialized region to CombineRgn.
12283
9c88f339
JB
122842011-03-23 Juanma Barranquero <lekktu@gmail.com>
12285
12286 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12287 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12288 (Fx_close_connection): Remove unused variable `i'.
12289
12290 * w32font.c (w32font_draw): Return number of glyphs.
12291 (w32font_open_internal): Remove unused variable `i'.
12292 (w32font_driver): Add missing initializer.
12293
12294 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12295 (fill_in_menu): Remove unused variable `items_added'.
12296
12297 * w32term.c (last_mouse_press_frame): Remove static global variable.
12298 (w32_clip_to_row): Remove unused variable `f'.
12299 (x_delete_terminal): Remove unused variable `i'.
12300
12301 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12302 (NOTHING): Remove unused static global variable.
12303 (uniscribe_check_otf): Remove unused variable `table'.
12304 (uniscribe_font_driver): Add missing initializers.
12305
dee091a3
JD
123062011-03-23 Julien Danjou <julien@danjou.info>
12307
12308 * term.c (Fsuspend_tty, Fresume_tty):
12309 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12310 * window.c (temp_output_buffer_show):
12311 * insdel.c (signal_before_change):
12312 * frame.c (Fhandle_switch_frame):
12313 * fileio.c (Fdo_auto_save):
12314 * emacs.c (Fkill_emacs):
12315 * editfns.c (save_excursion_restore):
12316 * cmds.c (internal_self_insert):
12317 * callint.c (Fcall_interactively):
12318 * buffer.c (Fkill_all_local_variables):
12319 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12320 Use Frun_hooks.
0f4a96b5 12321 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12322 unconditionally since it does the check itself.
dee091a3 12323
2c520ab5 123242011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12325
c9c49752
PE
12326 Fix more problems found by GCC 4.5.2's static checks.
12327
8abc3f12
PE
12328 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12329 the first time through the loop, since we know p0 < p1 then.
12330 This also avoids a gcc -Wstrict-overflow warning.
12331
a2d26660
PE
12332 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12333 leading to a memory leak, possible in functions like
12334 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12335 of objects (Bug#8318).
a2d26660 12336
916c72e9
PE
12337 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12338 that could (at least in theory) be that large.
12339
19ab8a18
PE
12340 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12341 This is less likely to overflow, and avoids undefined behavior if
12342 overflow does occur. All callers changed. Use strtoul to scan
12343 for the unsigned long integer.
b7cbbd6f
PE
12344 (pint2hrstr): Simplify and tune code slightly.
12345 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12346
f0641eff
PE
12347 * scroll.c (do_scrolling): Work around GCC bug 48228.
12348 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12349
7f650bb9
PE
12350 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12351 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12352 (validate_x_resource_name): Simplify count usage.
12353 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12354
37dd57d1
PE
12355 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12356 fail (Bug#8306).
81e56e61 12357
699979fc 12358 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12359
401bf9b4
PE
12360 * process.c (Fmake_network_process): Use socklen_t, not int,
12361 where POSIX says socklen_t is required in portable programs.
12362 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12363 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12364 (Fmake_network_process, server_accept_connection):
12365 (wait_reading_process_output, read_process_output):
12366 Likewise.
12367
b93aacde
PE
12368 * process.c: Rename or move locals to avoid shadowing.
12369 (list_processes_1, Fmake_network_process):
12370 (read_process_output_error_handler, exec_sentinel_error_handler):
12371 Rename or move locals.
4dc343ee 12372 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12373 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12374 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12375 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12376 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12377
af8a867c 12378 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12379 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12380 Include tparam.h instead, since it declares them.
af8a867c
PE
12381 * cm.h (PC): Remove extern decl; tparam.h now does this.
12382 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12383 * terminfo.c: Include tparam.h, to check interfaces.
12384 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12385 (tparam): Adjust signature to match interface in tparam.h;
12386 this removes some undefined behavior. Check that outstring and len
12387 are zero, which they always are with Emacs.
12388 * tparam.h (PC, BC, UP): New extern decls.
12389
0248044d 12390 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12391 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12392
8ff096c1 12393 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12394 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12395 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12396 (ftfont_list): Remove unused local.
49eaafba
PE
12397 (get_adstyle_property, ftfont_pattern_entity):
12398 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12399 Rename locals to avoid shadowing.
8ff096c1 12400
e2be39f6
PE
12401 * xfont.c (xfont_list_family): Mark var as initialized.
12402
c9735e30
PE
12403 * xml.c (make_dom): Now static.
12404
8f5201ae
PE
12405 * composite.c (composition_compute_stop_pos): Rename local to
12406 avoid shadowing.
b246f932
PE
12407 (composition_reseat_it): Remove unused locals.
12408 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12409 (composition_update_it): Mark var as initialized.
11b61122
PE
12410 (find_automatic_composition): Mark vars as initialized,
12411 with a FIXME (Bug#8290).
8f5201ae 12412
760fbc2c
PE
12413 character.h: Rename locals to avoid shadowing.
12414 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12415 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12416 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12417 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12418 to avoid shadowing.
12419
ff08eb85
PE
12420 * textprop.c (property_change_between_p): Remove; unused.
12421
fc7bf025
PE
12422 * intervals.c (interval_start_pos): Now static.
12423
235d7abc
PE
12424 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12425
44f230aa
SM
12426 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12427 Rename locals to avoid shadowing.
3e7d6594 12428
50060332
PE
12429 * sound.c (wav_play, au_play, Fplay_sound_internal):
12430 Fix pointer signedness.
d01f234b 12431 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12432 (wav_play): Initialize a variable to 0, to prevent undefined
12433 behavior (Bug#8278).
50060332 12434
c4fc4e30
PE
12435 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12436
918436ed
PE
12437 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12438
c939f91b
PE
12439 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12440 clobbering (Bug#8298).
b9c7f648
PE
12441 * sysdep.c (sys_subshell): Likewise.
12442 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12443
6bd8c144
PE
12444 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12445 This should get cleaned up, so that child_setup has the
12446 same signature on all platforms.
12447
7710357c 12448 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12449 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12450
c59da222
CY
124512011-03-22 Chong Yidong <cyd@stupidchicken.com>
12452
12453 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12454 not to be necessary, and produces flickering.
12455
66b87493
GM
124562011-03-20 Glenn Morris <rgm@gnu.org>
12457
12458 * config.in: Remove file.
12459
45b6f6d5
JB
124602011-03-20 Juanma Barranquero <lekktu@gmail.com>
12461
12462 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12463 are now in src/globals.h.
12464 (syms_of_minibuf): Remove spurious & from previous change.
12465
cd394be1 124662011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12467
12468 * minibuf.c (completing-read-function): New variable.
12469 (completing-read-default): Rename from completing-read.
12470 (completing-read): Call completing-read-function.
12471
b14e3e21
CY
124722011-03-19 Juanma Barranquero <lekktu@gmail.com>
12473
12474 * xfaces.c (Fx_load_color_file):
12475 Read color file from absolute filename (bug#8250).
12476
f2b726e6
JB
124772011-03-19 Juanma Barranquero <lekktu@gmail.com>
12478
12479 * makefile.w32-in: Update dependencies.
12480
09f6ff02
EZ
124812011-03-17 Eli Zaretskii <eliz@gnu.org>
12482
12483 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12484
29a6015a
PE
124852011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12486
a3a6c54e
PE
12487 Fix more problems found by GCC 4.5.2's static checks.
12488
b766f867
PE
12489 * process.c (make_serial_process_unwind, send_process_trap):
12490 (sigchld_handler): Now static.
12491
be02381c
PE
12492 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12493 That way, the code declares only the vars that it needs.
12494 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12495 * s/cygwin.h (PTY_ITERATION): Likewise.
12496 * s/darwin.h (PTY_ITERATION): Likewise.
12497 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12498
57048744
PE
12499 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12500 * process.c (allocate_pty): Don't declare stb unless it's needed.
12501
7914961c 12502 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12503 (CONSTANTLIM): Remove; unused.
12504 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12505 Define only if needed.
7914961c 12506
b3967b18
PE
12507 * unexelf.c (unexec): Name an expression,
12508 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12509 Use a different way to cause a compilation error if anyone uses
12510 n rather than nn, a way that does not involve shadowing.
73366a00 12511 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12512
29a6015a
PE
12513 * deps.mk (unexalpha.o): Remove; unused.
12514
43cfc33e 12515 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12516 * unexec.h: New file.
ce701a33
PE
12517 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12518 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12519 Depend on unexec.h.
12520 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12521 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12522 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12523 Change as necessary to match prototype in unexec.h.
ce701a33 12524
01f44d5a
PE
12525 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12526 shadowing.
4f63c6bb 12527 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12528
a6670b0b
PE
12529 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12530 Rename locals to avoid shadowing.
12531
cef2010d 12532 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12533 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12534
d4d7173a
PE
12535 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12536
f08b802a
PE
12537 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12538 warning when compiling print.c.
12539
3ddb0639
PE
12540 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12541 instead of using an uninitialized var.
5ad03b97 12542 (font_sort_entities): Mark var as initialized.
3ddb0639 12543
170a2692
PE
12544 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12545
e663c700
PE
12546 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12547 pointers to constants.
89bc529a 12548 (font_parse_fcname): Remove unused vars.
7b81e2d0 12549 (font_delete_unmatched): Now static.
ea838e10 12550 (font_get_spec): Remove; unused.
13a547c6
PE
12551 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12552 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12553 Rename or move locals to avoid shadowing.
e663c700 12554
2a80c887 12555 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12556 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12557
1384fa33 12558 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12559 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12560
8b2c52e9
PE
12561 * alloc.c (mark_backtrace): Move decl from here ...
12562 * lisp.h: ... to here, so that it can be checked.
12563
475545b5 12564 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12565 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12566 (lisp_indirect_variable): Name an expression,
12567 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12568 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12569
b1349114 12570 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12571 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12572 Use const pointer when appropriate.
b1349114 12573
a2928364
PE
12574 * lisp.h (get_system_name, get_operating_system_release):
12575 Move decls here, to check interfaces.
12576 * process.c (get_operating_system_release): Move decl to lisp.h.
12577 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12578 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12579 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12580 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12581 (Fformat_time_string, Fencode_time, Finsert_char):
12582 (Ftranslate_region_internal, Fformat):
12583 Rename or remove local vars to avoid shadowing.
9710023e 12584 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12585
a415e694
PE
12586 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12587 avoid shadowing.
12588
8ef4622d
PE
12589 * lisp.h (eassert): Check that the argument compiles, even if
12590 ENABLE_CHECKING is not defined.
12591
946f9a5b
PE
12592 * data.c (Findirect_variable): Name an expression, to avoid
12593 gcc -Wbad-function-cast warning.
112396d6 12594 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12595 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12596 (Fmake_variable_buffer_local, Fmake_local_variable):
12597 Mark variables as initialized.
52746918 12598 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12599
e5aab7e7 12600 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12601 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12602 Rename locals to avoid shadowing.
dff45157
PE
12603 (mark_stack): Move local variables into the #ifdef region where
12604 they're used.
7bc26fdb
PE
12605 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12606 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12607 needed otherwise.
12608 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12609 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12610 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12611
e5aab7e7
PE
12612 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12613 avoids undefined behavior in theory.
12614
4da60324
PE
12615 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12616
88043301
PE
12617 Use functions, not macros, for up- and down-casing (Bug#8254).
12618 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12619 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12620 to use the following functions instead of these macros.
12621 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12622 EMACS_INT, since callers assume the returned value fits in int.
12623 (upcase1): Likewise, for UPCASE_TABLE.
12624 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12625 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12626 the race-condition problem in the old DOWNCASE.
88043301 12627
19ed5445
PE
12628 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12629 Rename locals to avoid shadowing.
12630 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12631 (regex_compile, re_search_2, re_match_2_internal):
12632 Remove unused local vars.
952db0d7
PE
12633 (FREE_VAR): Rewrite so as not to use empty "else",
12634 which gcc can warn about.
da053e48 12635 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12636 (RETALLOC_IF): Define only if needed.
12637 (WORDCHAR_P): Likewise. This one is never needed, but is used
12638 only in a comment talking about a compiler bug, so put inside
12639 the #if 0 of that comment.
12640 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12641 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12642 Remove; unused.
19ed5445 12643
1f3561e4 12644 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12645 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12646 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12647
ded6f8f7
PE
12648 * search.c (simple_search): Remove unused var.
12649
dbd37a95
PE
12650 * dired.c (compile_pattern): Move decl from here ...
12651 * lisp.h: ... to here, so that it can be checked.
12652 (struct re_registers): New forward decl.
12653
7e47afad
PE
12654 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12655
85f24f61
PE
12656 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12657 All uses changed.
12658 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12659 Rename locals to avoid shadowing.
5671df8f 12660 (Fvertical_motion): Mark locals as initialized.
85f24f61 12661
181aa2be 12662 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12663 (casify_region): Mark local as initialized.
181aa2be 12664
930d429c
PE
12665 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12666
7082eac6
PE
12667 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12668 New macros, so that the caller can use some names other than
12669 gcpro1, gcpro2, etc.
12670 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12671 of the new macros.
12672 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12673 argument, for consistency with GCPRO2_VAR, etc: it is now the
12674 prefix of the variable, not the variable itself. All uses
12675 changed.
38b2c076
PE
12676 * dired.c (directory_files_internal, file_name_completion):
12677 Rename locals to avoid shadowing.
12678
15206ed9
PE
12679 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12680 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12681 dired.c's scmp function, had undefined behavior.
12682 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12683 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12684 * buffer.h: ... to here, because these macros use current_buffer,
12685 and the new implementation with inline functions needs to have
12686 current_buffer in scope now, rather than later when the macros
12687 are used.
12688 (downcase, upcase1): New static inline functions.
12689 (DOWNCASE, UPCASE1): Reimplement using these functions.
12690 This avoids undefined behavior in expressions like
12691 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12692 from race conditions in accessing the global variables
12693 case_temp1 and case_temp2.
12694 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12695 * lisp.h (case_temp1, case_temp2): Remove their decls.
12696 * character.h (ASCII_CHAR_P): Move from here ...
12697 * lisp.h: ... to here, so that the inline functions mentioned
12698 above can use them.
12699
4a6bea26
PE
12700 * dired.c (directory_files_internal_unwind): Now static.
12701
f14b7e14
PE
12702 * fileio.c (file_name_as_directory, directory_file_name):
12703 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12704 Now static.
2893f146
PE
12705 (file_name_as_directory): Use const pointers when appropriate.
12706 (Fexpand_file_name): Likewise. In particular, newdir might
12707 point at constant storage, so make it a const pointer.
fd4ead52 12708 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12709 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12710 signedness issues.
f839df0c
PE
12711 (Fset_file_times, Finsert_file_contents, auto_save_error):
12712 Rename locals to avoid shadowing.
f14b7e14 12713
5716756e 12714 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12715 (Ftry_completion, Fall_completions): Rename or remove locals
12716 to avoid shadowing.
5716756e 12717
b4c3046a
PE
12718 * marker.c (bytepos_to_charpos): Remove; unused.
12719
b45db522
PE
12720 * lisp.h (verify_bytepos, count_markers): New decls,
12721 so that gcc does not warn that these functions aren't declared.
12722
85876d07
PE
12723 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12724 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12725 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12726 (copy_text): Remove unused local var.
85876d07 12727
03d78a21 12728 * filelock.c (within_one_second): Now static.
b3dd38ab 12729 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12730
5df8f01b
PE
12731 * buffer.c (fix_overlays_before): Mark locals as initialized.
12732 (fix_start_end_in_overlays): Likewise. This function should be
12733 simplified by using pointers-to-pointers, but that's a different
12734 matter.
b1d876f1 12735 (switch_to_buffer_1): Now static.
8f54f30a
PE
12736 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12737 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12738
a70072c9 12739 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12740 Fix pointer signedness issue.
edced198
PE
12741 (sys_subshell): Mark local as volatile if checking for lint,
12742 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12743 (MAXPATHLEN): Define only if needed.
a70072c9 12744
a0977c44
PE
12745 * process.c (serial_open, serial_configure): Move decls from here ...
12746 * systty.h: ... to here, so that they can be checked.
12747
a884fdcc
PE
12748 * fns.c (get_random, seed_random): Move extern decls from here ...
12749 * lisp.h: ... to here, so that they can be checked.
12750
604efe86 12751 * sysdep.c (reset_io): Now static.
b8950c94 12752 (wait_for_termination_signal): Remove; unused.
604efe86 12753
38fc62d9
PE
12754 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12755 (copy_keymap_item, append_key, push_text_char_description):
12756 Now static.
1004a21a 12757 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12758 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12759 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12760 (describe_map_tree):
12761 Rename locals to avoid shadowing.
38fc62d9 12762
2f2650da
PE
12763 * keyboard.c: Declare functions static if they are not used elsewhere.
12764 (echo_char, echo_dash, cmd_error, top_level_2):
12765 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12766 (read_char, kbd_buffer_get_event, make_lispy_position):
12767 (make_lispy_event, make_lispy_movement, apply_modifiers):
12768 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12769 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12770 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12771 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12772 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12773
a053e86c 12774 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12775 (mark_kboards): Move decl here ...
12776 * alloc.c (mark_kboards): ... from here.
a053e86c 12777
4752793e
PE
12778 * lisp.h (force_auto_save_soon): New decl.
12779
74f10ca7 12780 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12781 (DEFINE_DUMMY_FUNCTION): New macro.
12782 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12783 Use it.
c03cd23f
PE
12784 (main): Add casts to avoid warnings
12785 if GCC considers string literals to be constants.
74f10ca7 12786
022e70d4
PE
12787 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12788
59d6fe83
PE
12789 * dbusbind.c: Pointer signedness fixes.
12790 (xd_signature, xd_append_arg, xd_initialize):
12791 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12792 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12793 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12794 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12795
78320123
PE
12796 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12797 if GCC considers string literals to be constants.
49cebcca 12798 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12799
35ac2a97
SM
128002011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12801
fb103ca9
SM
12802 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12803 (print_preprocess, print_object): New macro to fix last change.
12804
35ac2a97
SM
12805 * print.c (print_preprocess): Don't forget font objects.
12806
62973b41
JB
128072011-03-16 Juanma Barranquero <lekktu@gmail.com>
12808
12809 * emacs.c (USAGE3): Doc fixes.
12810
0e48bb22
AS
128112011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12812
12813 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12814 structure.
12815
7684e57b
JB
128162011-03-14 Juanma Barranquero <lekktu@gmail.com>
12817
12818 * lisp.h (VWindow_system, Qfile_name_history):
12819 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12820 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12821 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12822
12823 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12824 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12825
12826 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12827 * w32console.c (detect_input_pending, read_input_pending)
12828 (encode_terminal_code):
12829 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12830 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12831 (w32_system_caret_y, Qfile_name_history):
12832 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12833 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12834 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12835 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12836 * w32proc.c (Qlocal, report_file_error):
12837 * w32term.c (Vwindow_system, updating_frame):
12838 * w32uniscribe.c (initialized, uniscribe_font_driver):
12839 Remove unneeded extern declarations.
12840
2aa46d6c
CY
128412011-03-14 Chong Yidong <cyd@stupidchicken.com>
12842
c96bbc66 12843 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12844
cffc6f3b
CY
128452011-03-13 Chong Yidong <cyd@stupidchicken.com>
12846
12847 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12848 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12849 These macros can no longer be used for assignment.
12850
44f230aa
SM
12851 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12852 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12853 (record_buffer_markers, fetch_buffer_markers): New functions for
12854 recording and fetching special buffer markers.
12855 (set_buffer_internal_1, set_buffer_temp): Use them.
12856
12857 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12858
12859 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12860
12861 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12862 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12863
12864 * xdisp.c (hscroll_window_tree):
12865 (reconsider_clip_changes): Use PT instead of BUF_PT.
12866
d251f04b
EZ
128672011-03-13 Eli Zaretskii <eliz@gnu.org>
12868
12869 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12870 $(EMACS_ROOT)/lib/intprops.h.
12871
f0c77cd1
PE
128722011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12873
3eca4629
PE
12874 Fix more problems found by GCC 4.5.2's static checks.
12875
7c86ee98
PE
12876 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12877 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12878 (xg_free_frame_widgets): Make it clear that a local variable is
12879 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12880 (gdk_window_get_screen): Make it clear that this macro is needed
12881 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12882 (int_gtk_range_get_value): New function, which avoids a diagnostic
12883 from gcc -Wbad-function-cast.
12884 (xg_set_toolkit_scroll_bar_thumb): Use it.
12885 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12886 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12887 (get_utf8_string, xg_get_file_with_chooser):
12888 Rename locals to avoid shadowing.
12889 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12890
41729b81
PE
12891 * xgselect.c (xg_select): Remove unused var.
12892
f0c77cd1
PE
12893 * image.c (four_corners_best): Mark locals as initialized.
12894 (gif_load): Initialize transparent_p to zero (Bug#8238).
12895 Mark another local as initialized.
ec6cf4c6 12896 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12897
ce0ad53d 12898 * image.c (clear_image_cache): Now static.
d5d5a617 12899 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12900 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12901 (x_edge_detection): Remove unnecessary cast that
12902 gcc -Wbad-function-cast diagnoses.
2037898d 12903 (gif_load): Fix pointer signedness.
6ae141d6
PE
12904 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12905 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12906
33383987 129072011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12908
d32df629
PE
12909 Improve quality of tests for time stamp overflow.
12910 For example, without this patch (encode-time 0 0 0 1 1
12911 1152921504606846976) returns the obviously-bogus value (-948597
12912 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12913 reports time overflow. See
12914 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12915 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12916 * editfns.c: Include limits.h and intprops.h.
12917 (TIME_T_MIN, TIME_T_MAX): New macros.
12918 (time_overflow): Move earlier, to before first use.
12919 (hi_time, lo_time): New functions, for an accurate test for
12920 out-of-range times.
12921 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12922 (Fget_internal_run_time): Don't assume time_t fits in int.
12923 (make_time): Use list2 instead of Fcons twice.
12924 (Fdecode_time): More accurate test for out-of-range times.
12925 (check_tm_member): New function.
12926 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12927 (lisp_time_argument): Don't rely on undefined left-shift and
12928 right-shift behavior when checking for time stamp overflow.
8be6f318 12929
fe31d94c
PE
12930 * editfns.c (time_overflow): New function, refactoring common code.
12931 (Fformat_time_string, Fdecode_time, Fencode_time):
12932 (Fcurrent_time_string): Use it.
12933
8be6f318
PE
12934 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12935 * dired.c (make_time): Move to ...
12936 * editfns.c (make_time): ... here.
12937 * systime.h: Note the move.
12938
09d9db2c 129392011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12940
126bc0dc
YM
12941 * fringe.c (update_window_fringes): Remove unused variables.
12942
c47cbdfd
YM
12943 * unexmacosx.c (copy_data_segment): Also copy __got section.
12944 (Bug#8223)
12945
7ac80be9
EZ
129462011-03-12 Eli Zaretskii <eliz@gnu.org>
12947
c96bbc66 12948 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12949 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12950 Constify `char *' arguments and their references according to
12951 prototypes in tparam.h.
12952
ecb0f94d 12953 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12954
7ac80be9
EZ
12955 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12956 Adapt all references accordingly.
12957
12958 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12959
ef1fd07e
TT
129602011-03-11 Tom Tromey <tromey@redhat.com>
12961
12962 * buffer.c (syms_of_buffer): Remove obsolete comment.
12963
7ef4b50c
EZ
129642011-03-11 Eli Zaretskii <eliz@gnu.org>
12965
12966 * termhooks.h (encode_terminal_code): Declare prototype.
12967
12968 * msdos.c (encode_terminal_code): Don't declare prototype.
12969
12970 * term.c (encode_terminal_code): Now external again, used by
12971 w32console.c and msdos.c.
12972
44f230aa
SM
12973 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12974 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12975
4b1ec863 129762011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12977
1714f52b 12978 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12979
4b1ec863
PE
12980 * fringe.c (update_window_fringes): Mark locals as initialized
12981 (Bug#8227).
12982 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12983
524c7aa6
PE
12984 * alloc.c (mark_fringe_data): Move decl from here ...
12985 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12986 to check its interface.
12987 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12988
a5c0af81 12989 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12990 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12991 (fontset_font): Mark local as initialized.
a9a06e0b 12992 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12993
b4716021
PE
12994 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12995
811e9bac 12996 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12997 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12998 (x_own_selection, Fx_disown_selection_internal): Rename locals
12999 to avoid shadowing.
13000 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13001
7e3ab302
PE
13002 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13003 so that the caller can use some name other than gcpro1.
13004 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13005 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13006 (Fx_backspace_delete_keys_p):
13007 Use them to avoid shadowing, and rename vars to avoid shadowing.
13008 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13009 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13010 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13011 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13012 Remove unused locals.
7e3ab302
PE
13013 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13014 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13015 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13016 macros.
f78faa98 13017
e2b13473
PE
13018 * xterm.h (x_mouse_leave): New decl.
13019
77f23912
PE
13020 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13021 Remove unused functions.
cdf4ba58
PE
13022 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13023 (x_calc_absolute_position): Now static.
7411c686 13024 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13025 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13026 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13027 unless they are used.
38d0b34a
PE
13028 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13029 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13030 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13031 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13032 (x_error_catcher, x_connection_closed, x_error_handler):
13033 (x_error_quitter, xembed_send_message, x_iconify_frame):
13034 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13035 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13036 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13037
44f230aa
SM
13038 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13039 Rename or move locals to avoid shadowing.
6b463e58 13040 (tty_defined_color, merge_face_heights): Now static.
5967d051 13041 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13042 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13043 does not deduce is never used uninitialized.
73719eba
PE
13044 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13045 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13046
426994c3 13047 * terminal.c (store_terminal_param): Now static.
5489860b 13048
032f1620 13049 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13050 (set_frame_menubar): Remove unused local.
d4323972 13051 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13052 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13053 since they might point to immutable storage.
281585b0
PE
13054 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13055 since it's unused otherwise.
032f1620 13056
367c19e5 13057 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13058 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13059 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13060 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13061 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13062 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13063 does not deduce are never used uninitialized.
70739cbe 13064
07b48fa9
PE
13065 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13066
8868a238 13067 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13068 * window.c (window_loop, size_window):
13069 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13070
7e5cf297 13071 * window.c (display_buffer): Now static.
d6550a9f
PE
13072 (size_window): Mark variables that gcc -Wuninitialized
13073 does not deduce are never used uninitialized.
a586633d
PE
13074 * window.h (check_all_windows): New decl, to forestall
13075 gcc -Wmissing-prototypes diagnostic.
5b555da1 13076 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13077
f6095868
PE
13078 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13079 shadowing.
13080 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13081 Include <limits.h>.
13082 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13083 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13084 (load_charset_map): Mark variables that gcc -Wuninitialized
13085 does not deduce are never used uninitialized.
53df7c11 13086 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13087
f38b440c
PE
13088 * coding.c (coding_set_source, coding_set_destination):
13089 Use "else { /* comment */ }" rather than "else /* comment */;"
13090 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13091 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13092 a block, when the outer 'i' will do.
13093 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13094 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13095 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13096 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13097 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13098 Rename locals to avoid shadowing.
13099 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13100 * coding.c (emacs_mule_char, encode_invocation_designation):
13101 Now static, since they're not used elsewhere.
413bb2db 13102 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13103 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13104 (decode_coding_emacs_mule): Mark variables that gcc
13105 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13106 (detect_coding_iso_2022): Initialize a local variable that might
13107 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13108 this initialization is needed. (Bug#8211)
5f58e762
PE
13109 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13110 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13111 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13112 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13113 Remove unused macros.
f38b440c 13114
232b38b9 13115 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13116 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13117 * character.c (string_count_byte8): Likewise.
232b38b9 13118
fb90da1b
PE
13119 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13120 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13121
fb93dbc2
PE
13122 * chartab.c (copy_sub_char_table): Now static, since it's not used
13123 elsewhere.
5c156ace
PE
13124 (sub_char_table_ref_and_range, char_table_ref_and_range):
13125 Rename locals to avoid shadowing.
bbcd0949 13126 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13127
7d3b3862 13128 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13129 (BIDI_BOB): Remove unused macro.
7d3b3862 13130
6be7d3da
PE
13131 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13132 deduce are never used uninitialized.
c2ed9c8b 13133 * term.c (encode_terminal_code): Likewise.
6be7d3da 13134
75f8807f 13135 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13136
50938595
PE
13137 * tparam.h: New file.
13138 * term.c, tparam.h: Include it.
13139 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13140 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13141 Move these decls to tparam.h, and make them agree with what
13142 is actually in tparam.c. The previous trick of using incompatible
13143 decls in different modules does not conform to the C standard.
13144 All callers of tparam changed to use tparam's actual API.
13145 * tparam.c (tparam1, tparam, tgoto):
13146 Use const pointers where appropriate.
13147
fbceeba2
PE
13148 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13149 * cm.h (struct cm): Likewise.
13150 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13151 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13152 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13153 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13154 (turn_on_face, init_tty): Likewise.
13155 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13156
7f3f1250
PE
13157 * term.c (term_mouse_position): Rename local to avoid shadowing.
13158
e6ca6543
PE
13159 * alloc.c (mark_ttys): Move decl from here ...
13160 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13161
c40f8d15
AS
131622011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13163
13164 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13165
cfe0661d
JB
131662011-03-09 Juanma Barranquero <lekktu@gmail.com>
13167
13168 * search.c (compile_pattern_1): Remove argument regp, unused since
13169 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13170 (compile_pattern): Don't pass it.
13171
0afb4571
J
131722011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13173
13174 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13175 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13176 for ! HAVE_GTK3.
13177 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13178
13179 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13180
13181 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13182 gdk_window_get_screen, gdk_window_get_geometry,
13183 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13184 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13185 (xg_get_pixbuf_from_pixmap): New function.
13186 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13187 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13188 Call xg_get_pixbuf_from_pixmap instead of
13189 gdk_pixbuf_get_from_drawable.
13190 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13191 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13192 (xg_check_special_colors): Use GtkStyleContext and its functions
13193 for HAVE_GTK3.
13194 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13195 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13196 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13197 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13198 Call gtk_widget_get_preferred_size.
0afb4571
J
13199 (xg_frame_resized): gdk_window_get_geometry only takes 5
13200 parameters.
44f230aa
SM
13201 (xg_win_to_widget, xg_event_is_for_menubar):
13202 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13203 (xg_set_widget_bg): New function.
13204 (delete_cb): New function.
895009e1 13205 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13206 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13207 (xg_set_background_color): Call xg_set_widget_bg.
13208 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13209 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13210 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13211 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13212 if ! HAVE_GTK3.
13213 (update_frame_tool_bar): Call gtk_widget_hide.
13214 (xg_initialize): Use GDK_KEY_g.
13215
13216 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13217 if ! HAVE_GTK3
13218 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13219
13220 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13221 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13222 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13223
1c2cc4ef
JB
132242011-03-08 Juanma Barranquero <lekktu@gmail.com>
13225
13226 * w32xfns.c (select_palette): Check success of RealizePalette against
13227 GDI_ERROR, not zero.
13228
33383987 13229See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13230
13231;; Local Variables:
13232;; coding: utf-8
aac0c6e3
MR
13233;; End:
13234
2f097256 13235 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13236
13237 This file is part of GNU Emacs.
13238
13239 GNU Emacs is free software: you can redistribute it and/or modify
13240 it under the terms of the GNU General Public License as published by
13241 the Free Software Foundation, either version 3 of the License, or
13242 (at your option) any later version.
13243
13244 GNU Emacs is distributed in the hope that it will be useful,
13245 but WITHOUT ANY WARRANTY; without even the implied warranty of
13246 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13247 GNU General Public License for more details.
13248
13249 You should have received a copy of the GNU General Public License
13250 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.