lisp/url/url-handlers.el (url-handler-regexp): Declare.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
646b5f55
AS
12012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2
3 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
4 instead of union.
5 (XLI, XIL): Define.
6 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG): Use
7 them.
8 * emacs.c (gdb_use_struct): Renamed from gdb_use_union.
9 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
10 * alloc.c (widen_to_Lisp_Object): Removed.
11 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
12 * frame.c (delete_frame): Remove outdated comment.
13 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
14 USE_LISP_UNION_TYPE.
15 (Fw32_unregister_hot_key): Likewise.
16 (Fw32_toggle_lock_key): Likewise.
17 * w32menu.c (add_menu_item): Likewise.
18 (w32_menu_display_help): Use XIL instead of checking
19 USE_LISP_UNION_TYPE.
20 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
21 (init_heap): Likewise.
22 * w32term.c (w32_read_socket): Update comment.
23
1d3823c9
GM
242012-06-13 Glenn Morris <rgm@gnu.org>
25
c62ff706
GM
26 * s/usg5-4-common.h, src/s/unixware.h:
27 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
28
1d3823c9
GM
29 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
30
bfe3e0a2
PE
312012-06-13 Paul Eggert <eggert@cs.ucla.edu>
32
33 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
34 * alloc.c (make_number) [!defined make_number]:
35 Remove, as lisp.h always defines this now.
36 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
37 (roundup_size): Verify that it is a power of 2.
38 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
39 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
40 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
41 -DUSE_LSB_TAG=0, to override the automatically-selected default.
42 USE_LSB_TAG now is always defined to be either 0 or 1.
43 All uses changed.
44 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
45 code works fine either way, and efficiency is not a concern here,
46 as the union type is for debugging, not for production.
47 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
48 Use an inline function on all platforms when using the union type,
49 since this is simpler and 'static inline' can be used portably
50 within Emacs now.
51 (LISP_INITIALLY_ZERO): New macro.
52 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
53 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
54
45fa9c0f
GM
552012-06-12 Glenn Morris <rgm@gnu.org>
56
b4492cba
GM
57 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
58
59 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 60
45fa9c0f
GM
61 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
62 Move BROKEN_SIGIO to configure.
63
64 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
65 Move NO_TERMIO to configure.
66
0e25d334
CY
672012-06-12 Chong Yidong <cyd@gnu.org>
68
69 * image.c (imagemagick_load_image): Use MagickFlattenImage if
70 MagickMergeImageLayers is undefined. Use pixel pusher loop if
71 MagickExportImagePixels is undefined.
72
43682bb6
PE
732012-06-12 Paul Eggert <eggert@cs.ucla.edu>
74
75 * image.c (imagemagick_load_image): Remove unused label.
76
a9be7d2b
GM
772012-06-11 Glenn Morris <rgm@gnu.org>
78
79 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
80 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
81 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
82 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
83
3017f87f
SM
842012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
85
86 * alloc.c (make_byte_code): New function.
87 (Fmake_byte_code): Use it. Don't purify here.
88 * lread.c (read1): Use it as well to avoid extra allocation.
89
1b9b4cf4
CY
902012-06-11 Chong Yidong <cyd@gnu.org>
91
92 * image.c (imagemagick_load_image): Implement transparency.
93
95988fcf
AS
942012-06-10 Andreas Schwab <schwab@linux-m68k.org>
95
96 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
97 account for preceding backslashes. (Bug#11663)
98
cd4eb164
CY
992012-06-09 Chong Yidong <cyd@gnu.org>
100
101 * term.c: Support italics in capable terminals (Bug#9652).
102 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
103 (turn_on_face): Output using TS_enter_italic_mode if available.
104 Don't handle unused blinking and alt-charset cases.
105 (turn_off_face): Handle italic case; discard unused tty_blinking_p
106 and tty_alt_charset_p cases.
107 (tty_capable_p, init_tty): Support italics.
108
109 * termchar.h (struct tty_display_info): Add field for italics.
110 Remove unused blink field.
111
112 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
113 Handle slant.
114
115 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
116 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
117 tty_alt_charset_p. Add tty_italic_p.
118
ff88beb8
MA
1192012-06-09 Michael Albinus <michael.albinus@gmx.de>
120
121 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
122 dbus_type_is_basic if available.
123 (xd_extract_signed, xd_extract_unsigned): Rename from
124 extract_signed and extract_unsigned, respectively. Adapt callers.
125
44286096
CY
1262012-06-09 Chong Yidong <cyd@gnu.org>
127
1682701f
CY
128 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
129
44286096
CY
130 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
131 case (Bug#9752).
132
d86feb17
PE
1332012-06-08 Paul Eggert <eggert@cs.ucla.edu>
134
135 * xdisp.c (vmessage): Treat frame message as multibyte.
136 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
137 would generate the diagnostic "Making \302\247 buffer-local while
138 let-bound!".
139
d5c20fe8
EZ
1402012-06-08 Eli Zaretskii <eliz@gnu.org>
141
142 * dispnew.c (showing_window_margins_p): Undo last change, which
143 was done due to an inadvertent commit.
144 (adjust_frame_glyphs_for_frame_redisplay): Do call
145 showing_window_margins_p.
146
513749ee
SM
1472012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
148
149 * eval.c (Fmake_var_non_special): New primitive.
150 (syms_of_eval): Defsubr it.
151 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
152
d4a8f5c1
JB
1532012-06-08 Juanma Barranquero <lekktu@gmail.com>
154
155 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
156 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
157
8bbbc977
EZ
1582012-06-08 Eli Zaretskii <eliz@gnu.org>
159
160 * alloc.c (allocate_vectorlike): Fix last change.
161
f3372c87
DA
1622012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
163
164 Block-based vector allocation of small vectors.
165 * lisp.h (struct vectorlike_header): New field `nbytes',
166 adjust comment accordingly.
167 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
168 to denote vector blocks. Adjust users (live_vector_p,
169 mark_maybe_pointer, valid_lisp_object_p) accordingly.
170 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
171 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
172 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
173 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
174 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
175 (roundup_size): New constant.
176 (struct vector_block): New data type.
177 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 178 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
179 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
180 (sweep_vectors): New functions.
181 (allocate_vectorlike): Return `zero_vector' as the only vector of
182 0 items. Allocate new vector from block if vector size is less than
183 or equal to VBLOCK_BYTES_MAX.
184 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
185 (init_alloc_once): Add call to init_vectors.
186
4f18a4ed
SM
1872012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
188
189 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
190
86f158bc
PE
1912012-06-07 Paul Eggert <eggert@cs.ucla.edu>
192
193 * doprnt.c (doprnt): Truncate multibyte char correctly.
194 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
195 would mishandle a string argument "Xc" if X was a multibyte
196 character of length 2: it would truncate after X's first byte
197 rather than including all of X.
198
c5cfcbe0
CY
1992012-06-06 Chong Yidong <cyd@gnu.org>
200
201 * buffer.c (word_wrap): Doc fix.
202
c05cf390
PE
2032012-06-04 Paul Eggert <eggert@cs.ucla.edu>
204
205 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
206
0c3461de
GM
2072012-06-03 Glenn Morris <rgm@gnu.org>
208
209 * xdisp.c (tool-bar-style): Doc fix.
210
c71232db
UM
2112012-06-03 Ulrich Müller <ulm@gentoo.org>
212
213 * Makefile.in (PAXCTL): Define.
214 (temacs$(EXEEXT)): Disable memory randomization for the temacs
215 binary via PaX flags if the paxctl utility is available.
216 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
217 Restore PaX flags to their default. (Bug#11398)
218
383f7350
CY
2192012-06-03 Chong Yidong <cyd@gnu.org>
220
221 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
222 buffer (Bug#11226).
223
5f2c76c6
CY
2242012-06-03 Chong Yidong <cyd@gnu.org>
225
226 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
227 (note_mode_line_or_margin_highlight): If there is no help echo,
228 use mode-line-default-help-echo. Handle the case where the mouse
229 position is past the end of the mode line string.
230
231 * buffer.c (buffer_local_value_1): New function, split from
232 Fbuffer_local_value; can return Qunbound.
233 (Fbuffer_local_value): Use it.
234 (Vmode_line_format): Docstring tweaks.
235
773d47f6
PE
2362012-06-02 Paul Eggert <eggert@cs.ucla.edu>
237
238 * sysdep.c (system_process_attributes): Improve comment.
239
f2d6a3df
SM
2402012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
241
242 * keyboard.c: Export real-this-command to Elisp.
243 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
244 and DEFVAR it. Update all users.
245
63810350
PE
2462012-06-02 Paul Eggert <eggert@cs.ucla.edu>
247
7bd5c1f4
PE
248 * minibuf.c (Fassoc_string): Remove duplicate declaration.
249
63810350
PE
250 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
251 Convert pctcpu and pctmem to Lisp float properly.
252 Let the compiler fold better, as 100.0/0x8000 is exact.
253
a2821611
AS
2542012-06-02 Andreas Schwab <schwab@linux-m68k.org>
255
256 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
257 cons_block.
258
5fceba1d
PE
2592012-06-01 Paul Eggert <eggert@cs.ucla.edu>
260
261 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
262
c98ff5dd
DA
2632012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
264
265 For a 'struct window', replace some Lisp_Object fields to
266 bitfields where appropriate, remove unused fields.
267 * window.h (struct window): Remove unused 'last_mark_x' and
268 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
269 change it's type from Lisp_Object to bitfield.
270 Change type of 'force_start', 'optional_new_start',
271 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
272 fields from Lisp_Object to bitfield. Adjust users accordingly.
273
ca34e0be
PE
2742012-05-31 Paul Eggert <eggert@cs.ucla.edu>
275
276 Pacify gcc -Wdouble-precision when using Xaw.
277 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
278 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
279 Use 'float' consistently, rather than 'float' in most places
280 and 'double' in a couple of places.
281
efc00ab1 2822012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
283
284 * xdisp.c (handle_stop): Detect whether we have overlay strings
285 loaded by testing it->current.overlay_string_index to be
286 non-negative, instead of checking whether n_overlay_strings is
287 positive. (Bug#11587)
288
efc00ab1 2892012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
290
291 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
292
293 * doc.c (Fsubstitute_command_keys): Doc fix.
294
efc00ab1 2952012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
296
297 * search.c (search_buffer): Remove calls to
298 r_alloc_inhibit_buffer_relocation, as it is now called by
299 maybe_unify_char, which was the cause of relocation of buffer text
300 in bug#11519.
301
efc00ab1 3022012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
303
304 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
305 for the duration of call to load_charset, to avoid problems with
306 callers of maybe_unify_char that access buffer text through C
307 pointers.
308
309 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
310 decrement the inhibition flag, instead of just setting or
311 resetting it.
312
ba93a187
PE
3132012-05-31 Paul Eggert <eggert@cs.ucla.edu>
314
315 Remove obsolete '#define static' cruft.
316 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
317 This #undef was "temporary" in 2000; it is no longer needed
318 now that '#define static' has gone away.
319 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
320 (gray_bitmap_bits): Remove; no longer needed.
321 All uses replaced with definiens.
322 * xterm.c: Include "bitmaps/gray.xbm".
323
9e4bf381
PE
3242012-05-30 Paul Eggert <eggert@cs.ucla.edu>
325
326 Clean up __executable_start, monstartup when --enable-profiling.
327 The following changes affect the code only when profiling.
328 * dispnew.c (__executable_start): Rename from safe_bcopy.
329 Define only on platforms that need it.
330 * emacs.c: Include <sys/gmon.h> when profiling.
331 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
332 (__executable_start): Remove decl, since lisp.h does it now.
333 (safe_bcopy): Remove decl; no longer has that name.
334 (main): Coalesce #if into single bit of code, for simplicity.
335 Cast pointers to uintptr_t, since standard libraries want integers
336 and not pointers.
337 * lisp.h (__executable_start): New decl.
338
32d72c2f
GM
3392012-05-31 Glenn Morris <rgm@gnu.org>
340
341 * image.c (Fimagemagick_types): Doc fix.
342
baac5bc7
JM
3432012-05-30 Jim Meyering <meyering@redhat.com>
344
345 * callproc.c (Fcall_process_region): Include directory component
346 in mkstemp error message (Bug#11586).
347
72cb32cf
PE
3482012-05-30 Paul Eggert <eggert@cs.ucla.edu>
349
350 * alloc.c, lisp.h (make_pure_vector): Now static.
351
61b108cc
SM
3522012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
353
354 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
355 Move to byte-run.el.
356 (Fautoload): Do the hash-doc more carefully.
357 * data.c (Fdefalias): Purify definition, except for keymaps.
358 (Qdefun): Move from eval.c.
359 * lisp.h (Qdefun): Remove.
360 * lread.c (read1): Tiny simplification.
361
471fe23d
TN
3622012-05-29 Troels Nielsen <bn.troels@gmail.com>
363
934f3f58 364 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
365 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
366 Bug#9642, but explicitly check that the buffer the overlay would
367 be moved to is live and rearrange lines to make sure that errors
368 will not put the overlay in an inconsistent state.
369 (Fdelete_overlay): Cosmetics.
370
85d0efd1
EZ
3712012-05-28 Eli Zaretskii <eliz@gnu.org>
372
373 * w32term.c (my_bring_window_to_top): New function.
374 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
375 could be different from the original one.
376 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
377 (Bug#11513)
378
379 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
380 by calling BringWindowToTop.
381
382 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
383 (WM_EMACS_END): Increase by one.
384
da92a98c
PE
3852012-05-28 Paul Eggert <eggert@cs.ucla.edu>
386
387 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
388 This avoids undefined behavior that might cause the eassert
389 to not catch an out-of-range value.
390
74d1f848
JB
3912012-05-28 Juanma Barranquero <lekktu@gmail.com>
392
393 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
394 Update dependencies.
395
9e1a06fc
EZ
3962012-05-27 Eli Zaretskii <eliz@gnu.org>
397
398 * bidi.c (bidi_mirror_char): Fix last change.
399
f3dd7312
AS
4002012-05-27 Andreas Schwab <schwab@linux-m68k.org>
401
402 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
403 when referring to sectname field in printf format.
404
81899c91
PE
4052012-05-27 Paul Eggert <eggert@cs.ucla.edu>
406
57b81a9f
PE
407 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
408 Only r_alloc_inhibit_buffer_relocation needed to be added;
409 the others were already declared.
410
81899c91
PE
411 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
412 before checking whether it's out of range. Put the check inside
413 eassert. See
414 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
415
33017faf 4162012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
417
418 * callproc.c (Fcall_process): Restore a line that was accidentally
419 commented out in the 2011-02-13 change (bug#11547).
420
33017faf 4212012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
422
423 * lisp.h [REL_ALLOC]: Add prototypes for external functions
424 defined on ralloc.c.
425
426 * buffer.c [REL_ALLOC]: Remove prototypes of
427 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
428 they are now on lisp.h.
429
430 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
431
432 * search.c (search_buffer): Use it to inhibit relocation of buffer
433 text while re_search_2 is doing its job, because re_search_2 is
434 passed C pointers to buffer text. (Bug#11519)
435
23415acf
EZ
436 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
437 Update value to 24.
438
44e27368
EZ
439 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
440 state after an additional call to move_it_in_display_line_to, keep
441 the values of it->max_ascent and it->max_descent found for the
442 entire line.
443 (pos_visible_p): Revert the comparison against bottom_y to what it
444 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
445 (Bug#11464)
446
c1892f11
PE
4472012-05-26 Paul Eggert <eggert@cs.ucla.edu>
448
449 Fix coding-related core dumps with gcc -ftrapv.
450 The code was computing A - B, where A and B are pointers, and B is
451 random garbage. This can lead to core dumps on platforms that
452 have special pointer registers, and it also leads to core dumps on
453 x86-64 when compiled with gcc -ftrapv. The fix is to compute
454 A - B only when B is initialized properly.
455 * coding.c (coding_set_source, coding_set_destination): Return void.
456 (coding_change_source, coding_change_destinations): New functions,
457 with the old behaviors of coding_set_source and coding_set_destination.
458 All callers that need an offset changed to use these new functions.
459
eb7afdad
GM
4602012-05-26 Glenn Morris <rgm@gnu.org>
461
462 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
463
f12fdf02
EZ
4642012-05-26 Eli Zaretskii <eliz@gnu.org>
465
53a63be6 466 Extend mouse support on W32 text-mode console.
61b108cc
SM
467 * xdisp.c (draw_row_with_mouse_face):
468 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 469
eb3f6f01 470 * w32console.c: Include window.h.
61b108cc
SM
471 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
472 New functions.
eb3f6f01
EZ
473 (initialize_w32_display): Initialize mouse-highlight data.
474
53a63be6
EZ
475 * w32inevt.c: Include termchar.h and window.h.
476 (do_mouse_event): Support mouse-autoselect-window. When the mouse
477 moves, call note_mouse_highlight. If help_echo changed, call
478 gen_help_event to produce help-echo message in the echo area.
479 Call clear_mouse_face if mouse_face_hidden is set in the mouse
480 highlight info.
481
4cfd81f6
PE
4822012-05-26 Paul Eggert <eggert@cs.ucla.edu>
483
484 * lread.c (read1): Simplify slightly to avoid an overflow warning
485 with GCC 4.7.0 on x86-64.
486
4446092a
EZ
4872012-05-26 Eli Zaretskii <eliz@gnu.org>
488
489 * bidi.c (bidi_mirror_char): Revert last change: an int is
490 definitely wide enough here.
491
42b2a986 4922012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 493
42b2a986 494 Fix integer width and related bugs (Bug#9874).
eb106a49 495 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
496 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
497 (string_bytes, check_sblock, allocate_string_data):
498 (compact_small_strings, Fmake_bool_vector, make_string)
499 (make_unibyte_string, make_multibyte_string)
500 (make_string_from_bytes, make_specified_string)
501 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
502 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
503 (mark_vectorlike):
504 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
505 (allocate_pseudovector):
506 Use int, not EMACS_INT, where int is wide enough.
507 (inhibit_garbage_collection, Fgarbage_collect):
508 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
509 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
510 int might not be wide enough.
511 (bidi_cache_search, bidi_cache_find, bidi_init_it)
512 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
513 (bidi_at_paragraph_end, bidi_find_paragraph_start)
514 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
515 (bidi_level_of_next_char, bidi_move_to_visually_next):
516 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
517 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
518 (Fkill_buffer, Fset_buffer_major_mode)
519 (advance_to_char_boundary, Fbuffer_swap_text)
520 (Fset_buffer_multibyte, overlays_at, overlays_in)
521 (overlay_touches_p, struct sortvec, record_overlay_string)
522 (overlay_strings, recenter_overlay_lists)
523 (adjust_overlays_for_insert, adjust_overlays_for_delete)
524 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
525 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
526 (Foverlay_recenter, last_overlay_modification_hooks_used)
527 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
528 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
529 (validate_region): Omit unnecessary test for b <= e,
530 since that's guaranteed by the previous test.
d311d28c
PE
531 (adjust_overlays_for_delete): Avoid pos + length overflow.
532 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
533 (report_overlay_modification):
534 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
535 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
536 Omit pointer cast, which isn't needed anyway, and doesn't work
537 after the EMACS_INT -> ptrdiff_t change.
02481186 538 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
539 * buffer.h: Adjust decls to match defn changes elsewhere.
540 (struct buffer_text, struct buffer):
541 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
542 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
543 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
544 not int, to avoid needless 32-bit limit on 64-bit hosts.
545 (exec_byte_code): Use tighter memory-full test, one that checks
546 for alloca overflow. Don't compute the address of the object just
547 before an array, as that's not portable. Use EMACS_INT, not
548 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
549 * callint.c (Fcall_interactively):
550 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
551 * callproc.c (call_process_kill, Fcall_process):
552 Don't assume pid_t fits into an Emacs fixnum.
553 (call_process_cleanup, Fcall_process, child_setup):
554 Don't assume pid_t fits into int.
555 (call_process_cleanup, Fcall_process, delete_temp_file)
556 (Fcall_process_region):
557 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
558 (Fcall_process): Simplify handling of volatile integers.
559 Use int, not EMACS_INT, where int will do.
560 * casefiddle.c (casify_object, casify_region, operate_on_word)
561 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
562 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
563 (casify_object): Avoid integer overflow when overallocating buffer.
564 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 565 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
566 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
567 * category.h (CATEGORYP): Don't assume arg is nonnegative.
568 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
569 integers are now checked earlier. All uses replaced with XINT.
570 (ccl_driver):
571 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
572 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
573 (ccl_driver, Fregister_code_conversion_map):
574 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
575 (resolve_symbol_ccl_program): Check that vector header is in range.
576 Always copy the vector, so that we can check its contents reliably
577 now rather than having to recheck each instruction as it's being
578 executed. Check that vector words fit in 'int'.
579 (ccl_get_compiled_code, Fregister_ccl_program)
580 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
581 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
582 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
583 contents are in range.
584 (Fccl_execute_on_string): Check that status is in range.
585 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
586 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
587 Accept and return EMACS_INT, not int, because callers can pass values
588 out of 'int' range.
589 (c_string_width, strwidth, lisp_string_width, chars_in_text)
590 (multibyte_chars_in_text, parse_str_as_multibyte)
591 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
592 (str_as_unibyte, str_to_unibyte, string_count_byte8)
593 (string_escape_byte8, Fget_byte):
594 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 595 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
596 avoid mishandling large integers.
597 * character.h: Adjust decls to match defn changes elsewhere.
598 * charset.c (load_charset_map_from_file, find_charsets_in_text)
599 (Ffind_charset_region):
600 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
601 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
602 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 603 Don't assume fixnum fits in int.
d311d28c
PE
604 (load_charset_map_from_vector, Fmap_charset_chars):
605 Remove now-unnecessary CHECK_NATNUMs.
606 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
607 Don't rely on undefined behavior with signed left shift overflow.
608 Don't assume unsigned int fits into fixnum, or that fixnum fits
609 into unsigned int. Don't require max_code to be a valid fixnum;
610 that's not true for gb10830 4-byte on a 32-bit host. Allow
611 invalid_code to be a cons, for the same reason. Require code_offset
612 to be a character. Avoid int overflow if max_char is close
613 to INT_MAX.
614 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
615 this is intended anyway and avoids some undefined behavior.
616 (load_charset_map): Pass unsigned, not int, as 2nd arg of
617 INDEX_TO_CODE_POINT, as that's what it expects.
618 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
619 * charset.h (DECODE_CHAR): Return int, not unsigned;
620 this is what was intended anyway, and it avoids undefined behavior.
621 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
622 integer-overflow issues.
623 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
624 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
625 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
626 * chartab.c (Fmake_char_table, Fset_char_table_range)
627 (uniprop_get_decoder, uniprop_get_encoder):
628 Don't assume fixnum fits in int.
629 * cmds.c (move_point): New function, that does the gist of
630 Fforward_char and Fbackward_char, but does so while checking
631 for integer overflow more accurately.
c96e5d6a 632 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
633 (Fforward_line, Fend_of_line, internal_self_insert)
634 (internal_self_insert):
635 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
636 Fix a FIXME, by checking for integer overflow when calculating
637 target_clm and actual_clm.
638 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 639 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
640 (ASSURE_DESTINATION, coding_alloc_by_realloc)
641 (coding_alloc_by_making_gap, alloc_destination)
642 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
643 (encode_coding_utf_16, detect_coding_emacs_mule)
644 (decode_coding_emacs_mule, encode_coding_emacs_mule)
645 (detect_coding_iso_2022, decode_coding_iso_2022)
646 (encode_invocation_designation, encode_designation_at_bol)
647 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
648 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
649 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
650 (encode_coding_ccl, encode_coding_raw_text)
651 (detect_coding_charset, decode_coding_charset)
652 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
653 (produce_composition, produce_charset, produce_annotation)
654 (decode_coding, handle_composition_annotation)
655 (handle_charset_annotation, consume_chars, decode_coding_gap)
656 (decode_coding_object, encode_coding_object, detect_coding_system)
657 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
658 (code_convert_region, code_convert_string)
8f50130c
PE
659 (Fdefine_coding_system_internal)
660 (coding_set_source, coding_set_destination):
d311d28c
PE
661 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
662 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
663 (Fdefine_coding_system_internal):
664 Don't assume fixnums fit in int.
665 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 666 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
667 (Funencodable_char_position, Fcheck_coding_systems_region)
668 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 669 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 670 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 671 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 672 Don't access memory outside of the args array.
d311d28c 673 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
674 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
675 result of ENCODE_CHAR.
d311d28c
PE
676 * coding.h: Adjust decls to match defn changes elsewhere.
677 (struct coding_system):
678 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
679 * composite.c (get_composition_id, find_composition)
680 (run_composition_function, update_compositions)
681 (compose_text, composition_gstring_put_cache)
682 (composition_gstring_p, composition_gstring_width)
683 (fill_gstring_header, fill_gstring_body, autocmp_chars)
684 (composition_compute_stop_pos, composition_reseat_it)
685 (composition_update_it, struct position_record)
686 (find_automatic_composition, composition_adjust_point)
687 (Fcomposition_get_gstring, Ffind_composition_internal):
688 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
689 (update_compositions):
690 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
691 * composite.h: Adjust decls to match defn changes elsewhere.
692 (struct composition):
693 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
694 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
695 Do not attempt to compute the address of the object just before a
696 buffer; this is not portable.
697 (Faref, Faset):
698 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
699 (Faset): Use int, not EMACS_INT, where int is wide enough.
700 (Fstring_to_number): Don't assume fixnums fit in int.
701 (Frem): Don't assume arg is nonnegative.
702 * dbusbind.c (xd_append_arg): Check for integers out of range.
703 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 704 (extract_signed, extract_unsigned): New functions.
243e0530
PE
705 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
706 (xd_get_connection_references): Return ptrdiff_t, not int.
707 All uses changed.
708 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
709 (xd_read_message_1):
710 Use int, not unsigned, where the dbus API uses int.
711 (Fdbus_message_internal): Don't overflow mtype.
712 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
713 * dired.c (directory_files_internal, file_name_completion, scmp)
714 (file_name_completion_stat):
715 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
716 (file_name_completion): Don't overflow matchcount.
717 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
718 * dispextern.h: Adjust decls to match defn changes elsewhere.
719 (struct text_pos, struct glyph, struct bidi_saved_info)
720 (struct bidi_string_data, struct bidi_it, struct composition_it)
721 (struct it):
722 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
723 (struct display_pos, struct composition_it, struct it):
724 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
725 * dispnew.c (increment_matrix_positions)
726 (increment_row_positions, mode_line_string)
727 (marginal_area_string):
728 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 729 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
730 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
731 (duration_to_sec_usec): New function, to check for overflow better.
732 (Fsleep_for, sit_for): Use it.
733 * doc.c (get_doc_string, store_function_docstring):
734 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
735 (get_doc_string, Fsnarf_documentation):
736 Use int, not EMACS_INT, where int is wide enough.
737 (get_doc_string):
738 Use SAFE_ALLOCA, not alloca.
739 Check for overflow when converting EMACS_INT to off_t.
740 * doprnt.c (doprnt):
741 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
742 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
743 Don't assume uid_t fits into fixnum.
744 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
745 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
746 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
747 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
748 (general_insert_function)
749 (Finsert_char, make_buffer_string, make_buffer_string_both)
750 (update_buffer_properties, Fbuffer_substring)
751 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
752 (Fsubst_char_in_region, check_translation)
753 (Ftranslate_region_internal, save_restriction_restore, Fformat)
754 (transpose_markers, Ftranspose_regions):
755 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
756 (clip_to_bounds): Move to lisp.h as an inline function).
757 (Fconstrain_to_field): Don't assume integers are nonnegative.
758 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
759 (Fsubst_char_in_region, Fsave_restriction):
760 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
761 (Femacs_pid): Don't assume pid_t fits into fixnum.
762 (lo_time): Use int, not EMACS_INT, when int suffices.
763 (lisp_time_argument): Check for usec out of range.
764 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
765 (Fuser_login_name, Fuser_full_name): Signal an error
766 if a uid argument is out of range, rather than relying on
767 undefined behavior.
c8d5c857
PE
768 (Fformat_time_string): Remove now-unnecessary check.
769 lisp_time_argument checks for out-of-range usec now.
243e0530 770 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
771 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
772 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
773 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
774 (init_cmdargs, Fdump_emacs):
775 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
776 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
777 the bottom (typically) 32 bits of the fixnum.
778 * eval.c (specpdl_size, call_debugger):
779 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
780 (when_entered_debugger, Fbacktrace_debug):
781 Don't assume fixnum can fit in int.
782 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
783 the object just before a buffer; this is not portable.
784 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
785 (grow_specpdl, unbind_to):
786 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
787 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
788 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 789 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
790 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
791 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
792 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
793 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
794 (a_write, e_write):
795 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
796 (Fcopy_file, non_regular_nbytes, read_non_regular)
797 (Finsert_file_contents):
798 Use int, not EMACS_INT, where int is wide enough.
799 (READ_BUF_SIZE): Verify that it fits in int.
800 (Finsert_file_contents): Check that counts are in proper range,
801 rather than assuming fixnums fit into ptrdiff_t etc.
802 Don't assume fixnums fit into int.
125b3835 803 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
804 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
805 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
806 (string_char_to_byte, string_byte_to_char)
807 (string_make_multibyte, string_to_multibyte)
808 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
809 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
810 (substring_both, Fdelete, internal_equal, Ffillarray)
811 (Fclear_string, mapcar1)
812 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
813 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
814 (larger_vector, make_hash_table, maybe_resize_hash_table)
815 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
816 (Fmaphash, secure_hash):
817 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
818 (concat): Check for string index and length overflow.
819 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
820 (Frequire):
821 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
822 (larger_vector): New API (vec, incr_min, size_max) replaces old
823 one (vec, new_size, init). This catches size overflow.
824 INIT was removed because it was always Qnil.
825 All callers changed.
826 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
827 the upper bound on a hash table index size.
828 (make_hash_table, maybe_resize_hash_table): Use it.
829 (secure_hash): Computer start_byte and end_byte only after
830 they're known to be in ptrdiff_t range.
831 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
832 (Ffont_get_glyphs, Ffont_at):
833 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
834 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
835 (Flist_fonts, Fopen_font):
836 Don't assume fixnum can fit in int.
837 (check_gstring): Don't assume index can fit in int.
838 (font_match_p): Check that fixnum is a character, not a nonnegative
839 fixnum, since the later code needs to stuff it into an int.
840 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
841 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
842 conversion overflow issues.
843 (Fopen_font): Check for integer out of range.
844 (Ffont_get_glyphs): Don't assume index can fit in int.
845 * font.h: Adjust decls to match defn changes elsewhere.
846 * fontset.c (reorder_font_vector): Redo score calculation to avoid
847 integer overflow.
848 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
849 printmax_t, where ptrdiff_t is wide enough.
850 (Finternal_char_font):
851 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
852 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
853 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
854 (Fset_frame_position, x_set_frame_parameters)
855 (x_set_line_spacing, x_set_border_width)
856 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
857 Check that fixnums are in proper range for system types.
858 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
859 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
860 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
861 Use SAFE_ALLOCA_LISP, not alloca.
862 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
863 intptr_t is wide enough.
864 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
865 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
866 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
867 Check for fixnum out of range.
868 * ftfont.c (ftfont_list): Don't assume index fits in int.
869 Check that fixnums are in proper range for system types.
870 (ftfont_shape_by_flt):
871 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
872 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
873 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
874 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
875 Check that fixnums are in proper range for system types.
876 * gnutls.h: Adjust decls to match defn changes elsewhere.
877 * gtkutil.c (xg_dialog_run):
878 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
879 (update_frame_tool_bar):
880 Check that fixnums are in proper range for system types.
881 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 882 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
883 * indent.c (last_known_column, last_known_column_point):
884 (current_column_bol_cache):
885 (skip_invisible, current_column, check_display_width):
886 (check_display_width, scan_for_column, current_column_1)
887 (Findent_to, Fcurrent_indentation, position_indentation)
888 (indented_beyond_p, Fmove_to_column, compute_motion):
889 (Fcompute_motion, Fvertical_motion):
890 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
891 (last_known_column_modified): Use EMACS_INT, not int.
892 (check_display_width):
893 (Fcompute_motion):
894 Check that fixnums and floats are in proper range for system types.
895 (compute_motion): Don't assume index or fixnum fits in int.
896 (compute_motion, Fcompute_motion):
897 Use int, not EMACS_INT, when it is wide enough.
898 (vmotion): Omit local var start_hpos that is always 0; that way
899 we don't need to worry about overflow in expressions involving it.
900 * indent.h: Adjust decls to match defn changes elsewhere.
901 (struct position):
902 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
903 Use int, not EMACS_INT, where int is wide enough.
904 Remove unused members ovstring_chars_done and tab_offset;
905 all uses removed.
906 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
907 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
908 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
909 (make_gap, copy_text, insert, insert_and_inherit)
910 (insert_before_markers, insert_before_markers_and_inherit)
911 (insert_1, count_combining_before, count_combining_after)
912 (insert_1_both, insert_from_string)
913 (insert_from_string_before_markers, insert_from_string_1)
914 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
915 (adjust_after_replace, adjust_after_insert, replace_range)
916 (replace_range_2, del_range, del_range_1, del_range_byte)
917 (del_range_both, del_range_2, modify_region)
918 (prepare_to_modify_buffer, signal_before_change)
919 (signal_after_change, Fcombine_after_change_execute):
920 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
921 * intervals.c (traverse_intervals, rotate_right, rotate_left)
922 (balance_an_interval, split_interval_right, split_interval_left)
923 (find_interval, next_interval, update_interval)
924 (adjust_intervals_for_insertion, delete_node, delete_interval)
925 (interval_deletion_adjustment, adjust_intervals_for_deletion)
926 (static_offset_intervals, offset_intervals)
927 (merge_interval_right, merge_interval_left, make_new_interval)
928 (graft_intervals_into_buffer, temp_set_point_both)
929 (temp_set_point, set_point, adjust_for_invis_intang)
930 (set_point_both, move_if_not_intangible, get_property_and_range)
931 (get_local_map, copy_intervals, copy_intervals_to_string)
932 (compare_string_intervals, set_intervals_multibyte_1):
933 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
934 * intervals.h: Adjust decls to match defn changes elsewhere.
935 (struct interval):
936 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
937 * keyboard.c (this_command_key_count, this_single_command_key_start)
938 (before_command_key_count, before_command_echo_length, echo_now)
939 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
940 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
941 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
942 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
943 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
944 (last_non_minibuf_size, last_point_position, echo_truncate)
945 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
946 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
947 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
948 (stuff_buffered_input):
949 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
950 (last_auto_save, command_loop_1, read_char):
951 Use EMACS_INT, not int, to avoid integer overflow.
952 (record_char): Avoid overflow in total_keys computation.
953 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
954 * keyboard.h: Adjust decls to match defn changes elsewhere.
955 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
956 (Fkey_description, Fdescribe_vector, Flookup_key):
957 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
958 (click_position): New function, to check that positions are in range.
959 (Fcurrent_active_maps):
960 (describe_command):
961 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
962 (Faccessible_keymaps, Fkey_description):
963 (preferred_sequence_p):
964 Don't assume fixnum can fit into int.
965 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
966 Check for integer overflow in size calculations.
967 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
968 avoid mishandling large integers.
969 * lisp.h: Adjust decls to match defn changes elsewhere.
970 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
971 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
972 (struct Lisp_Marker):
973 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
974 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
975 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
976 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
977 All callers changed.
978 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
979 Assume the arg has valid form, since it always does.
980 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
981 unsigned integer system type.
982 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
983 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
984 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
985 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
986 (duration_to_sec_usec): New decl.
987 * lread.c (read_from_string_index, read_from_string_index_byte)
988 (read_from_string_limit, readchar, unreadchar, openp)
989 (read_internal_start, read1, oblookup):
990 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
991 (Fload, readevalloop, Feval_buffer, Feval_region):
992 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
993 (openp): Check for out-of-range argument to 'access'.
994 (read1): Use int, not EMACS_INT, where int is wide enough.
995 Don't assume fixnum fits into int.
6efdadfd 996 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
997 (read_filtered_event): Use duration_to_sec_usec
998 to do proper overflow checking on durations.
d311d28c
PE
999 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1000 in size calculation.
1001 (Fexecute_kbd_macro):
1002 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1003 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1004 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1005 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1006 (set_marker_both, set_marker_restricted_both, marker_position)
1007 (marker_byte_position, Fbuffer_has_markers_at):
1008 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1009 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1010 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1011 It now merely ensures that the menu is large enough, without
1012 necessarily growing it, as this avoids some integer overflow issues.
1013 All callers changed.
1014 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1015 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1016 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1017 Use SAFE_ALLOCA_LISP, not alloca.
1018 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1019 to EMACS_INT. Check that fixnums are in proper range for system types.
1020 * minibuf.c (minibuf_prompt_width, string_to_object)
1021 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1022 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1023 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1024 (get_minibuffer, read_minibuf_unwind):
1025 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1026 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1027 this simplifies overflow checking. All callers changed.
1028 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1029 (Ftest_completion):
1030 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1031 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1032 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1033 Check that fixnums are in proper range for system types.
1034 (Fx_create_frame, Fx_show_tip):
1035 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1036 * nsfont.m (ns_findfonts, nsfont_list_family):
1037 Don't assume fixnum fits in long.
1038 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1039 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1040 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1041 wide enough.
17fdb222 1042 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1043 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1044 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1045 (PRINTDECLARE, PRINTPREPARE):
1046 (strout, print_string):
1047 (print, print_preprocess, print_check_string_charset_prop)
1048 (print_object):
1049 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1050 (PRINTDECLARE):
1051 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1052 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1053 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1054 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1055 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1056 (print_error_message): Use SAFE_ALLOCA, not alloca.
1057 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1058 (print_depth, new_backquote_output, print_number_index):
1059 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1060 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1061 (Fset_process_window_size, Fformat_network_address)
1062 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1063 (sigchld_handler):
d311d28c 1064 Check that fixnums are in proper range for system types.
d44287d4 1065 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1066 Check for process-ids out of pid_t range rather than relying on
1067 undefined behavior.
e4d81efc 1068 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1069 (Fformat_network_address, read_process_output, send_process)
1070 (Fprocess_send_region, status_notify):
1071 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1072 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1073 (wait_reading_process_output, read_process_output, exec_sentinel):
1074 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1075 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1076 (Faccept_process_output): Use duration_to_sec_usec to do proper
1077 overflow checking on durations.
dde14581
PE
1078 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1079 Don't assume pid_t fits in int.
02481186
PE
1080 * process.h (struct Lisp_Process): Members tick and update_tick
1081 are now of type EMACS_INT, not int.
b62b53e8
PE
1082 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1083 configured --with-wide-int.
d311d28c
PE
1084 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1085 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1086 * search.c (looking_at_1, string_match_1):
1087 (fast_string_match, fast_c_string_match_ignore_case)
1088 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1089 (scan_newline, find_before_next_newline, search_command)
1090 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1091 (set_search_regs, wordify):
1092 (Freplace_match):
1093 (Fmatch_data):
1094 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1095 (string_match_1, search_buffer, set_search_regs):
1096 (Fmatch_data):
1097 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1098 (wordify): Check for overflow in size calculation.
1099 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1100 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1101 Check that fixnums are in proper range for system types.
1102 * sound.c (struct sound_device)
1103 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1104 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1105 (Fplay_sound_internal):
1106 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1107 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1108 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1109 (Fparse_partial_sexp):
1110 Don't assume fixnums can fit in int.
1111 (struct lisp_parse_state, find_start_pos, find_start_value)
1112 (find_start_value_byte, find_start_begv)
1113 (update_syntax_table, char_quoted, dec_bytepos)
1114 (find_defun_start, prev_char_comend_first, back_comment):
1115 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1116 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1117 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1118 (Finternal_describe_syntax_value): Check that match_lisp is a
1119 character, not an integer, since the code stuffs it into int.
1120 (scan_words, scan_sexps_forward):
1121 Check that fixnums are in proper range for system types.
1122 (Fforward_word):
1123 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1124 (scan_sexps_forward):
1125 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1126 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1127 * syntax.h: Adjust decls to match defn changes elsewhere.
1128 (struct gl_state_s):
1129 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1130 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1131 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1132 * sysdep.c (wait_for_termination_1, wait_for_termination)
1133 (interruptible_wait_for_termination, mkdir):
1134 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1135 (emacs_read, emacs_write):
1136 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1137 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1138 and double all fit in int.
d311d28c
PE
1139 * term.c (set_tty_color_mode):
1140 Check that fixnums are in proper range for system types.
1141 * termhooks.h (struct input_event):
1142 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1143 * textprop.c (validate_interval_range, interval_of)
1144 (Fadd_text_properties, set_text_properties_1)
1145 (Fremove_text_properties, Fremove_list_of_text_properties)
1146 (Ftext_property_any, Ftext_property_not_all)
1147 (copy_text_properties, text_property_list, extend_property_ranges)
1148 (verify_interval_modification):
1149 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1150 (Fnext_single_char_property_change)
1151 (Fprevious_single_char_property_change):
1152 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1153 (copy_text_properties):
1154 Check for integer overflow in index calculation.
d311d28c
PE
1155 * undo.c (last_boundary_position, record_point, record_insert)
1156 (record_delete, record_marker_adjustment, record_change)
1157 (record_property_change):
1158 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1159 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1160 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1161 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1162 (Fx_hide_tip, Fx_file_dialog):
1163 * w32menu.c (set_frame_menubar):
1164 Use ptrdiff_t, not int, for consistency with rest of code.
1165 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1166 (select_window, Fdelete_other_windows_internal)
1167 (window_scroll_pixel_based, window_scroll_line_based)
1168 (Frecenter, Fset_window_configuration):
1169 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1170 (Fset_window_hscroll, run_window_configuration_change_hook)
1171 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1172 (Fscroll_other_window, Frecenter):
d311d28c
PE
1173 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1174 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1175 Don't assume fixnum fits in int.
1176 (Fset_window_scroll_bars):
1177 Check that fixnums are in proper range for system types.
1178 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1179 (string_pos, c_string_pos, number_of_chars, init_iterator)
1180 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1181 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1182 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1183 (face_before_or_after_it_pos, handle_invisible_prop)
1184 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1185 (display_prop_intangible_p, string_buffer_position_lim)
1186 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1187 (get_overlay_strings_1, get_overlay_strings)
1188 (iterate_out_of_display_property, forward_to_next_line_start)
1189 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1190 (get_next_display_element, set_iterator_to_next)
1191 (get_visually_first_element, compute_stop_pos_backwards)
1192 (handle_stop_backwards, next_element_from_buffer)
1193 (move_it_in_display_line_to, move_it_in_display_line)
1194 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1195 (add_to_log, message_dolog, message_log_check_duplicate)
1196 (message2, message2_nolog, message3, message3_nolog
1197 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1198 (current_message_1, truncate_echo_area, truncate_message_1)
1199 (set_message, set_message_1, store_mode_line_noprop)
1200 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1201 (text_outside_line_unchanged_p, check_point_in_composition)
1202 (reconsider_clip_changes)
1203 (redisplay_internal, set_cursor_from_row, try_scrolling)
1204 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1205 (redisplay_window, find_last_unchanged_at_beg_row)
1206 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1207 (trailing_whitespace_p, find_row_edges, display_line)
1208 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1209 (display_mode_element, store_mode_line_string)
1210 (pint2str, pint2hrstr, decode_mode_spec)
1211 (display_count_lines, display_string, draw_glyphs)
1212 (x_produce_glyphs, x_insert_glyphs)
1213 (rows_from_pos_range, mouse_face_from_buffer_pos)
1214 (fast_find_string_pos, mouse_face_from_string_pos)
1215 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1216 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1217 (safe_call, init_from_display_pos, handle_fontified_prop)
1218 (handle_single_display_spec, load_overlay_strings)
1219 (with_echo_area_buffer, setup_echo_area_for_printing)
1220 (display_echo_area, echo_area_display)
1221 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1222 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1223 (redisplay_window, dump_glyph_row, display_mode_line)
1224 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1225 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1226 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1227 (handle_single_display_spec, build_desired_tool_bar_string)
1228 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1229 (get_specified_cursor_type):
1230 Check that fixnums are in proper range for system types.
1231 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1232 (Flookup_image_map):
1233 Don't assume fixnums fit in int.
1234 (compare_overlay_entries):
1235 Avoid mishandling comparisons due to subtraction overflow.
1236 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1237 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1238 (handle_tool_bar_click):
1239 Use int, not unsigned, since we prefer signed and the signedness
1240 doesn't matter here.
1241 (get_next_display_element, next_element_from_display_vector):
1242 Use int, not EMACS_INT, when int is wide enough.
1243 (start_hourglass): Use duration_to_sec_usec to do proper
1244 overflow checking on durations.
1245 * xfaces.c (Fbitmap_spec_p):
1246 Check that fixnums are in proper range for system types.
1247 (compare_fonts_by_sort_order):
1248 Avoid mishandling comparisons due to subtraction overflow.
1249 (Fx_family_fonts, realize_basic_faces):
1250 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1251 (Fx_family_fonts):
1252 Don't assume fixnum fits in int.
1253 Use SAFE_ALLOCA_LISP, not alloca.
1254 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1255 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1256 (face_at_buffer_position, face_for_overlay_string)
1257 (face_at_string_position):
1258 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1259 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1260 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1261 (Fx_show_tip):
1262 Check that fixnums are in proper range for system types.
1263 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1264 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1265 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1266 (Fx_change_window_property): Don't assume fixnums fit in int.
1267 * xfont.c (xfont_chars_supported):
1268 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1269 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1270 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1271 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1272 * xml.c (parse_region):
1273 * xrdb.c (magic_file_p):
1274 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1275 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1276 (x_get_local_selection, x_reply_selection_request)
1277 (x_handle_selection_request, wait_for_property_change):
1278 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1279 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1280 short is wide enough.
1281 (x_send_client_event): Don't assume fixnum fits in int.
1282 * xterm.c (x_x_to_emacs_modifiers):
1283 Don't assume EMACS_INT overflows nicely into int.
1284 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1285 may come from Lisp.
1286 (handle_one_xevent): NATNUMP can eval its arg twice.
1287 (x_connection_closed):
1288 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1289 * xterm.h: Adjust decls to match defn changes elsewhere.
1290 (struct scroll_bar): Use struct vectorlike_header
1291 rather than rolling our own approximation.
1292 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1293
c6574eb5
GM
12942012-05-25 Glenn Morris <rgm@gnu.org>
1295
1296 * lisp.mk (lisp): Update for more files being compiled now.
1297
e8d32c7e
SM
12982012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1299
48def666
SM
1300 * lread.c: Remove `read_pure' which makes no difference.
1301 (read_pure): Remove var.
1302 (unreadpure): Remove function.
1303 (readevalloop): Don't call read_list with -1 flag.
1304 (read1, read_vector): Don't test read_pure any more.
1305 (read_list): Simplify.
1306
e8d32c7e
SM
1307 * fileio.c, character.h: Minor style tweaks.
1308
4b2addb7
DA
13092012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1310
1311 * window.h (clip_changed): Remove useless declaration.
1312
584461b2
JB
13132012-05-22 Juanma Barranquero <lekktu@gmail.com>
1314
1315 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1316 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1317
34374650
PE
13182012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1319
1320 Remove src/m/*.
1321 This directory predates autoconf and is no longer needed nowadays.
1322 Move its few remaining bits of functionality to where they're needed.
1323 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1324 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1325 * m/template.h: Remove.
1326 * Makefile.in (M_FILE): Remove. All uses removed.
1327 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1328 * lisp.h (USE_LSB_TAG):
1329 * mem-limits.h (EXCEEDS_LISP_PTR):
1330 Use VAL_MAX, not VALBITS, in #if.
1331 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1332 (EMACS_UINT): Define unconditionally now.
1333 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1334 (BITS_PER_EMACS_INT): New constants, replacing
1335 what used to be in config.h, but not useful in #if.
1336 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1337 define them any more.
1338 (VAL_MAX): New macro.
1339 (VALMASK): Use it.
1340 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1341 BITS_PER_EMACS_INT, in #if.
1342 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1343 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1344 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1345 * s/ms-w32.h (DATA_START):
1346 Move here from removed file m/intel386.h.
1347 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1348 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1349
261cb4bb
PE
13502012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1351
1352 Assume C89 or later.
1353 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1354 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1355 (xrealloc):
1356 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1357 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1358 * textprop.c, tparam.c (NULL): Remove.
1359 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1360 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1361 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1362 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1363 * xterm.c (input_signal_count): Assume volatile works.
1364
ff23cd9f
KB
13652012-05-21 Ken Brown <kbrown@cornell.edu>
1366
1367 * xgselect.c (xg_select): Fix first argument in call to 'select'
1368 (bug#11508).
1369
1b170bc6
KB
13702012-05-20 Ken Brown <kbrown@cornell.edu>
1371
1372 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1373 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1374
b2f4d39f
KB
13752012-05-19 Ken Brown <kbrown@cornell.edu>
1376
1377 * xfns.c (x_in_use): Remove `static' qualifier.
1378 * xterm.h (x_in_use): Declare.
1379 * xgselect.c: Include xterm.h.
1380 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1381 and `display_arg' (bug#9754).
1382
003fdae2
PE
13832012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1384
9232a6d9
PE
1385 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1386
003fdae2
PE
1387 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1388 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1389
784b56e2
EZ
13902012-05-18 Eli Zaretskii <eliz@gnu.org>
1391
1392 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1393
1394 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1395 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1396
1397 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1398 reference to image_cache->refcount.
1399 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1400
a0a79cde
JL
14012012-05-17 Juri Linkov <juri@jurta.org>
1402
1403 * search.c (Fword_search_regexp, Fword_search_backward)
1404 (Fword_search_forward, Fword_search_backward_lax)
1405 (Fword_search_forward_lax): Move functions to isearch.el
1406 (bug#10145, bug#11381).
1407
b0572523
PE
14082012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1409
1410 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1411
9660f5fc
SM
14122012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1413
1414 * lread.c (init_obarray): Declare Qt and Qnil as special.
1415
4374de83
GM
14162012-05-14 Glenn Morris <rgm@gnu.org>
1417
1418 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1419 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1420
dc44c39a
PE
14212012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1422
078c97cb
PE
1423 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1424
dc44c39a
PE
1425 * unexaix.c: Port to more-recent AIX compilers.
1426 (report_error, report_error_1, make_hdr, copy_sym)
1427 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1428 Make arguments const char *, not char *, to avoid violations of C
1429 standard and to fix some AIX warnings reported by Gilles Pion.
1430
e18afed7 14312012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1432
1433 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1434 already have overlays loaded.
1435 (handle_single_display_spec): Before returning without displaying
1436 fringe bitmap, synchronize the bidi iterator with the main display
1437 iterator, by calling iterate_out_of_display_property.
1438 (iterate_out_of_display_property): Detect buffer iteration by
1439 testing that it->string is a Lisp string.
1440 (get_next_display_element): When the current object is exhausted,
1441 and there's something on it->stack, call set_iterator_to_next to
1442 proceed with what's on the stack, instead of returning zero.
1443 (set_iterator_to_next): If called at the end of a Lisp string,
1444 proceed to consider_string_end without incrementing string
1445 position. Don't increment display vector index past the end of
1446 the display vector. (Bug#11417)
c8fb9dc6
EZ
1447 (pos_visible_p): Don't report a position visible when move_it_to
1448 stopped at the last line of window, which happens to be scanned
1449 backwards by the bidi iteration. (Bug#11464)
ac268e67 1450
e18afed7 14512012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1452
1453 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1454 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1455 are on a TTY, and thus unable to display on the fringes.
1456 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1457 so we need to signal to the caller that this is a "replacing"
1458 display spec. This fixes display when the spec is invalid or we
1459 are on a TTY.
1460
e18afed7 14612012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1462
1463 * unexaix.c (make_hdr): Fix typo in prototype.
1464 This bug broke the build on AIX. Problem reported by Gilles Pion.
1465
9d0a235a
MA
14662012-05-14 Michael Albinus <michael.albinus@gmx.de>
1467
1468 * keyboard.c (kbd_buffer_get_event): Read special events also in
1469 batch mode. (Bug#11415)
1470
9e6b06ed
GM
14712012-05-12 Glenn Morris <rgm@gnu.org>
1472
1473 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1474
c1a1d7a3
EZ
14752012-05-12 Eli Zaretskii <eliz@gnu.org>
1476
1477 * lisp.mk (lisp): Add newcomment.elc.
1478
3fe7cdc8
GM
14792012-05-12 Glenn Morris <rgm@gnu.org>
1480
1481 * Makefile.in (MKDIR_P): New, set by configure.
1482 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1483
53f7d2c0
PE
14842012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1485
1486 Remove unused function hourglass_started.
1487 * dispextern.h (hourglass_started):
1488 * w32fns.c (hourglass_started):
1489 * xdisp.c (hourglass_started): Remove.
1490
75aafb17
JB
14912012-05-10 Juanma Barranquero <lekktu@gmail.com>
1492
1493 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1494 Update dependencies.
1495
12959e8e
PE
14962012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1497
97107e2e
PE
1498 * xgselect.c (xg_select): Put maxfds+1 into a var.
1499 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1500
12959e8e
PE
1501 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1502
836d29b3
DA
15032012-05-10 Dave Abrahams <dave@boostpro.com>
1504
1505 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1506 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1507
5cb67954
MA
15082012-05-09 Michael Albinus <michael.albinus@gmx.de>
1509
1510 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1511 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1512 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1513 Initialize xd_registered_buses.
1514
3478ec45
PE
15152012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1516
b263a6b0
PE
1517 Untag more efficiently if USE_LSB_TAG.
1518 This is based on a proposal by YAMAMOTO Mitsuharu in
1519 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1520 For an admittedly artificial (nth 8000 longlist) benchmark on
1521 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1522 Emacs's overall text size by 1%.
1523 * lisp.h (XUNTAG): New macro.
1524 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1525 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1526 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1527 * eval.c (Fautoload):
1528 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1529 * frame.h (XFRAME): Use XUNTAG.
1530
3478ec45
PE
1531 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1532 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1533 Remove unportable assumptions about print widths of types like
1534 dbus_uint32_t.
1535 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1536 intptr_t when converting between pointer and integer, to avoid GCC
1537 warnings about wrong width.
1538
666b903b 15392012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1540
1541 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1542 stack for each reader_thread, instead of defaulting to 8MB
1543 determined by the linker. This avoids failures in creating
1544 subprocesses on Windows 7, see the discussion in this thread:
1545 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1546
b120cc17
JC
15472012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1548
1549 Fix up display of the *Minibuf-0* buffer in the mini window.
1550 * keyboard.c (read_char): Don't clear the echo area if there's no
1551 message to clear.
1552 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1553 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 1554
9a4b36f8
MA
15552012-05-07 Michael Albinus <michael.albinus@gmx.de>
1556
1557 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1558 batch mode.
1559
e5f9458f
CY
15602012-05-06 Chong Yidong <cyd@gnu.org>
1561
1562 * lisp.mk (lisp): Update.
1563
eceeb5fc 15642012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
1565
1566 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1567
71873e2b
SM
15682012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1569
1570 * data.c (PUT_ERROR): New macro.
1571 (syms_of_data): Use it. Add new error type `user-error'.
1572 * undo.c (user_error): New function.
1573 (Fprimitive_undo): Use it.
1574 * print.c (print_error_message): Adjust print style for `user-error'.
1575 * keyboard.c (user_error): New function.
1576 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1577
ab0fa4e4
PE
15782012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1579
1580 Do not limit current-time-string to years 1000..9999.
1581 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1582 (Fcurrent_time_string): Support any year that is supported by the
1583 underlying localtime representation. Don't use asctime, as it
1584 has undefined behavior for years outside the range -999..9999.
1585
7ed806a7
PE
15862012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1587
1588 Fix race conditions involving setenv, gmtime, localtime, asctime.
1589 Without this fix, interrupts could mess up code that uses these
1590 nonreentrant functions, since setting TZ invalidates existing
1591 tm_zone or tzname values, and since most of these functions return
1592 pointers to static storage.
1593 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1594 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1595 Grow the critical sections to include not just invoking
1596 localtime/gmtime, but also accessing these functions' results
1597 including their tm_zone values if any, and any related TZ setting.
1598 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
1599 so that the struct tm is saved in the critical section.
1600 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
1601 motivated by the fact that memory allocation needs to be outside
1602 the critical section.
1603
0c16dfed
DA
16042012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1605
1606 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1607 with RESET_INTERVAL.
1608
1609 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1610 Remove duplicated buffer name initialization.
1611
3f83ace8
JM
16122012-05-02 Jim Meyering <jim@meyering.net>
1613
1614 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1615
c7b8541e
JM
1616 * xfns.c (x_window): Use xstrdup (Bug#11375).
1617
90207a15 16182012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
1619
1620 * xdisp.c (pos_visible_p): If already at a newline from the
1621 display string before the 'while' loop, don't walk back the glyphs
1622 from it3.glyph_row. Solves assertion violation when the display
1623 string begins with a newline (egg.el). (Bug#11367)
1624
b593d6a9
AH
16252012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1626
1627 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1628 Move to simple.el.
1629
4737362e
GM
16302012-05-01 Glenn Morris <rgm@gnu.org>
1631
99cf43f9
GM
1632 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1633 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1634 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1635 All were removed before 23.1.
1636
9311dcff
GM
1637 * dispnew.c: Remove HAVE_LIBNCURSES test;
1638 it is always true on relevant platforms.
1639
4d5c6349
GM
1640 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1641 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1642
4737362e
GM
1643 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1644
74dd3a6b
AS
16452012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1646
1647 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1648 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1649 Remove.
1650
13c379ee
PE
16512012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1652
1653 Do not avoid creating empty evaporating overlays (Bug#9642).
1654 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1655 That is, do not delete an evaporating overlay if it becomes
1656 empty after its bounds are adjusted to fit within its buffer.
1657 This fix caused other problems, and I'm reverting it until we get
1658 to the bottom of them.
1659
a8e7d6d7 16602012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
1661
1662 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1663
a8e7d6d7 16642012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
1665
1666 * xdisp.c (pos_visible_p): If the window start position is beyond
1667 ZV, start the display from buffer beginning. Prevents assertion
1668 violation in init_iterator when the minibuffer window is scrolled
1669 via the scroll bar.
1670
1671 * window.c (window_scroll_pixel_based): Likewise.
1672
a8e7d6d7 16732012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
1674
1675 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1676
a8e7d6d7 16772012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
1678
1679 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1680 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1681
a8e7d6d7 16822012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 1683
b593d6a9
AH
1684 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1685 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 1686
1c6900d9
EZ
16872012-04-26 Eli Zaretskii <eliz@gnu.org>
1688
4c3fa1d9
EZ
1689 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1690 display element, check also the underlying string or buffer
1691 character. (Bug#11341)
1692
1c6900d9
EZ
1693 * w32menu.c: Include w32heap.h.
1694 (add_menu_item): If the call to AppendMenuW (via
1695 unicode_append_menu) fails, disable Unicode menus only if we are
1696 running on Windows 9X/Me.
1697
42bf8205
AS
16982012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1699
1700 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1701 (xgetint): Add missing shift for LSB tags.
1702
b1bac16e
MR
17032012-04-24 Martin Rudalics <rudalics@gmx.at>
1704
1705 * keyboard.c (read_char): Don't wipe echo area for select window
1706 events: These might get delayed via `mouse-autoselect-window'
1707 (Bug#11304).
1708
d69621cc
JB
17092012-04-24 Juanma Barranquero <lekktu@gmail.com>
1710
1711 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1712 manipulation of :loaded-from data.
1713
02fd101b
JB
17142012-04-23 Juanma Barranquero <lekktu@gmail.com>
1715
1716 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1717 now a cons (bug#11311).
1718
888bec30
PE
17192012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1720
89a438bd
PE
1721 Do not create empty overlays with the evaporate property (Bug#9642).
1722 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1723 if it becomes empty after its bounds are adjusted to fit within
1724 its buffer. Without this fix, in a nonempty buffer (let ((o
1725 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1726 yields an empty overlay that has the evaporate property, which is
1727 not supposed to happen.
1728
1068fe4d
PE
1729 Fix minor GTK3 problems found by static checking.
1730 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1731 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1732 (struct _EmacsFixedClass, emacs_fixed_get_type):
1733 Move decls here from emacsgtkfixed.h, since they needn't be public.
1734 (emacs_fixed_get_type): Now static.
1735 (emacs_fixed_class_init): Omit unused local.
1736 (emacs_fixed_child_type): Remove; unused.
1737 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1738 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1739 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1740 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1741 (EMACS_FIXED_GET_CLASS): Remove; unused.
1742 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1743
888bec30
PE
1744 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1745 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1746
de85e130
PE
17472012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1748
d0baac98 1749 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 1750 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
1751 (__malloc_size_t, __malloc_ptrdiff_t):
1752 Remove. All uses removed, replaced by the definiens if needed,
1753 since we can assume C89 or better now.
1754 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1755 (protect_malloc_state, align, get_contiguous_space)
1756 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1757 (malloc_atfork_handler_child, malloc_enable_thread)
1758 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1759 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1760 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1761 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1762 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1763 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1764 Define using prototypes, not old style.
1765 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1766 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1767 (align): Don't assume that signed integer overflow wraps around.
1768 Omit unused local var.
1769 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1770 (_free_internal_nolock, memalign, mallochook, reallochook):
1771 Omit no-longer-needed casts.
1772 (valloc): Use getpagesize, not __getpagesize.
1773 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1774 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1775
de85e130
PE
1776 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1777
dcbf5805
MA
17782012-04-22 Michael Albinus <michael.albinus@gmx.de>
1779
1780 Move functions from C to Lisp. Make non-blocking method calls
1781 the default. Implement further D-Bus standard interfaces.
1782
1783 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1784 (QCdbus_request_name_allow_replacement)
1785 (QCdbus_request_name_replace_existing)
1786 (QCdbus_request_name_do_not_queue)
1787 (QCdbus_request_name_reply_primary_owner)
1788 (QCdbus_request_name_reply_in_queue)
1789 (QCdbus_request_name_reply_exists)
1790 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1791 (QCdbus_registered_serial, QCdbus_registered_method)
1792 (QCdbus_registered_signal): New Lisp objects.
1793 (XD_DEBUG_MESSAGE): Use sizeof.
1794 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1795 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1796 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1797 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1798 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1799 (xd_signature, xd_append_arg): Allow float for integer types.
1800 (xd_get_connection_references): New function.
b593d6a9
AH
1801 (xd_get_connection_address): Rename from xd_initialize.
1802 Return cached address.
dcbf5805
MA
1803 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1804 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1805 level.
1806 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 1807 Return number of refcounts.
dcbf5805
MA
1808 (Fdbus_get_unique_name): Make stronger parameter check.
1809 (Fdbus_message_internal): New defun.
1810 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1811 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1812 (Fdbus_send_signal, Fdbus_register_service)
1813 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1814 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1815 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1816 (Vdbus_compiled_version, Vdbus_runtime_version)
1817 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1818 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1819 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
1820 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1821 Adapt docstring.
dcbf5805 1822
52828e02
PE
18232012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1824
da05bc4c
PE
1825 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1826 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1827 Do not assume ptrdiff_t is the same width as 'int'.
1828
52828e02
PE
1829 * alloc.c: Handle unusual debugging option combinations.
1830 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1831 since the two debugging options are incompatible.
1832 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1833 is defined.
1834 (mem_init, mem_insert, mem_insert_fixup):
1835 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1836 (NEED_MEM_INSERT): Remove; no longer needed.
1837
f01769f9
LL
18382012-04-22 Leo Liu <sdl.web@gmail.com>
1839
1840 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1841
5790543d
PE
18422012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1843
1844 * sysdep.c [__FreeBSD__]: Minor cleanups.
1845 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1846 Use Emacs indenting style more consistently. Avoid some casts.
1847 Use 'double' consistently rather than mixing 'float' and 'double'.
1848
b91b7e4d
EW
18492012-04-21 Eduard Wiebe <usenet@pusto.de>
1850
b593d6a9
AH
1851 * sysdep.c (list_system_processes, system_process_attributes):
1852 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 1853
6114eb15
AS
18542012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1855
1856 * lisp.mk (lisp): Update.
1857
2f38dff7
PE
18582012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1859
1860 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1861 It is never used otherwise.
1862
4ae29f89
SM
18632012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1864
1865 * print.c (print_preprocess): Only check print_depth if print-circle
1866 is nil.
1867 (print_object): Check for cycles even when print-circle is nil and
1868 print-gensym is t, but only check print_depth if print-circle is nil.
1869
f30d612a
CY
18702012-04-20 Chong Yidong <cyd@gnu.org>
1871
1872 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1873 set the status to "failed" and ensure that sentinel is run.
1874
c07a4c0b 18752012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
1876
1877 * process.c (Fset_process_inherit_coding_system_flag)
1878 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 1879 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 1880
c07a4c0b 18812012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
1882
1883 * xdisp.c (string_buffer_position_lim): Limit starting position to
1884 BEGV.
1885 (set_cursor_from_row): If called for a mode-line or header-line
1886 row, return zero immediately.
1887 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
1888 farther than the first row after the header line, if any.
1889 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
1890 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1891
c07a4c0b 18922012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1893
4ae29f89
SM
1894 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1895 (bug#11238).
ad3a2b41 1896
c07a4c0b 18972012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 18982012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
1899
1900 configure: new option --enable-gcc-warnings (Bug#11207)
1901 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1902 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1903 (ALL_CFLAGS): Use new macros rather than old.
1904 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1905 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1906 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1907 -Wunused-result, -Wunused-variable. This should go away once
1908 the Emacs and Gnulib regex code is merged.
1909 (xmalloc, xrealloc): Now static.
1910
aba027e8
PE
19112012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1912
1913 * dired.c (Fsystem_groups): Remove unused local.
1914
e5a36063
GM
19152012-04-17 Glenn Morris <rgm@gnu.org>
1916
1917 * dired.c (Fsystem_users): Doc fix.
1918
316411f0
DA
19192012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1920
1921 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1922 (syms_of_dired): Add them.
1923
9426aba4
PE
19242012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1925
b62a57be
PE
1926 Fix minor alloc.c problems found by static checking.
1927 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1928 New extern decls, to avoid calling undeclared functions.
1929 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1930 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1931 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1932 (NEED_MEM_INSERT): New macro.
1933 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 1934 Remove one incorrect comment and fix another.
b62a57be 1935
3539f31f
PE
1936 Fix minor ralloc.c problems found by static checking.
1937 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1938 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1939 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1940 (r_alloc_sbrk): Now static.
1941
a041960a
PE
1942 Improve ralloc.c interface checking.
1943 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1944 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1945 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1946 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1947 [REL_ALLOC]: ... to here, to check interface.
1948 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1949 Remove decls. This fixes an "It stinks!".
1950
9426aba4
PE
1951 * alloc.c (which_symbols): Fix alignment issue / type clash.
1952
d55c12ed
AS
19532012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1954
1955 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1956 (struct Lisp_Misc_Any): Likewise.
1957 (struct Lisp_Free): Likewise.
1958 * alloc.c (union aligned_Lisp_Symbol): Define.
1959 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1960 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1961 (union aligned_Lisp_Misc): Define.
1962 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1963 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 1964 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 1965
b948ce8b
PE
19662012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1967
1968 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1969 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1970 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1971 * s/netbsd.h, s/sol2-6.h:
1972 Remove definition of GC_MARK_STACK, since the default now works.
1973 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1974 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1975 no longer the default.
1976 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1977
35dc09a1 19782012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1979
35dc09a1
GM
1980 * lread.c (lisp_file_lexically_bound_p):
1981 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 1982
35dc09a1
GM
19832012-04-14 Eli Zaretskii <eliz@gnu.org>
1984
1985 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1986 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1987
19882012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1989
1990 * nsterm.m (constrainFrameRect): Always constrain when there is only
1991 one screen (Bug#10962).
1992
bcd86815
KB
19932012-04-13 Ken Brown <kbrown@cornell.edu>
1994
1995 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1996
c25df26e
RT
19972012-04-13 Reuben Thomas <rrt@sc3d.org>
1998
1999 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2000
0fc59f1e
DC
20012012-04-11 Daniel Colascione <dancol@dancol.org>
2002
2003 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2004 against is gone. It's better to use vfork now so that when Cygwin
2005 gains a new, working vfork, we use it automatically (bug#10398).
2006
de8c03dc
SM
20072012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2008
2009 * window.c (save_window_save): Obey window-point-insertion-type.
2010
2f097256
GM
20112012-04-11 Glenn Morris <rgm@gnu.org>
2012
2013 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2014
453b951e
SM
20152012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2016
2017 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2018
75f1671a 20192012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2020
2021 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2022 (force_quit_count): New var.
2023 (handle_interrupt): Use it.
2024
2a8ce227
JB
20252012-04-10 Juanma Barranquero <lekktu@gmail.com>
2026
2027 * w32.c (w32_delayed_load): Record the full path of the library
2028 being loaded (bug#10424).
2029
935396c0
GM
20302012-04-09 Glenn Morris <rgm@gnu.org>
2031
05920a43
GM
2032 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2033 not just in the obarray, before snarfing them. (Bug#11036)
2034
935396c0
GM
2035 * Makefile.in ($(leimdir)/leim-list.el):
2036 Pass EMACS rather than BUILT_EMACS.
2037
a18ecafa
TZ
20382012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2039
2040 * process.c (make_process):
2041 * process.h: Add integer `gnutls_handshakes_tried' member to
2042 process struct.
2043
6bbef4e5
JC
2044 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2045 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2046
2047 * gnutls.c (gnutls_log_function2i): Convenience log function.
2048 (emacs_gnutls_read): Use new log functions,
2049 `gnutls_handshakes_tried' process member, and
2050 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2051 attempts per process (connection).
2052
b4d3bc10
CY
20532012-04-09 Chong Yidong <cyd@gnu.org>
2054
2055 * eval.c (Fuser_variable_p, user_variable_p_eh)
2056 (lisp_indirect_variable): Functions deleted.
2057 (Fdefvar): Caller changed.
2058
2059 * callint.c (Finteractive, Fcall_interactively):
2060 * minibuf.c (Fread_variable): Callers changed.
2061
70f4d973
EZ
20622012-04-09 Eli Zaretskii <eliz@gnu.org>
2063
2064 * xdisp.c (set_cursor_from_row): If the display string appears in
2065 the buffer at position that is closer to point than the position
2066 after the display string, display the cursor on the first glyph of
2067 the display string. Fixes cursor display when a 'display' text
2068 property immediately follows invisible text. (Bug#11094)
2069
cb3c2e3e
PE
20702012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2071
2072 composite.c: use 'double' consistently
2073 * composite.c (get_composition_id): Use 'double' consistently
2074 instead of converting 'float' to 'double' and vice versa; this is
2075 easier to understand and avoids a GCC warning.
2076
fd06db5d
GM
20772012-04-09 Glenn Morris <rgm@gnu.org>
2078
50fe702a
GM
2079 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2080 preparation for dumping it with emacs. (Bug#4789)
2081 (leimdir): New variable.
2082 ($(leimdir)/leim-list.el): New rule.
2083 (emacs$(EXEEXT)): Depend on leim-list.el.
2084
fd06db5d
GM
2085 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2086 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2087 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2088
55c131ee
AS
20892012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2090
2091 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2092 proper alignment.
2093
9209588f
JB
20942012-04-07 Juanma Barranquero <lekktu@gmail.com>
2095
2096 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2097 Remove unused local variable.
2098
e3fb2efb
PE
20992012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2100
2101 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2102 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2103 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2104 objects, as mark_maybe_pointer will catch them otherwise.
2105 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2106 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2107
b5385551
PE
21082012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2109
2110 Fix typo that broke non-Windows builds.
2111 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2112
9078ead6
EZ
21132012-04-07 Eli Zaretskii <eliz@gnu.org>
2114
2115 Support building on MS-Windows with libxml2.
2116
2117 * makefile.w32-in (OBJ2): Add xml.$(O).
2118 (GLOBAL_SOURCES): Add xml.c.
2119 ($(BLD)/xml.$(O)): New dependency list.
2120
2121 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2122 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2123 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2124 [!WINDOWSNT]: New macros.
2125 (init_libxml2_functions, libxml2_loaded_p): New functions.
2126 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2127 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2128 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2129 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2130 linked in).
6bbef4e5
JC
2131 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2132 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2133 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2134
2135 * emacs.c: Don't include libxml/parser.h.
2136 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2137 xmlCleanupParser directly.
2138
2139 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2140
3811fdf3
EZ
21412012-04-07 Eli Zaretskii <eliz@gnu.org>
2142
2143 * indent.c (Fvertical_motion): If there is a display string at
2144 point, use it.vpos to compute how many lines to backtrack after
2145 move_it_to point. (Bug#11133)
2146
2f8e16b2
EZ
21472012-04-06 Eli Zaretskii <eliz@gnu.org>
2148
2149 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2150 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2151 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2152 macros related to unification of CJK characters. For the details,
2153 see the discussion following the message here:
2154 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2155
3d439cd1
CY
21562012-04-04 Chong Yidong <cyd@gnu.org>
2157
2158 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2159
8bc53d00
EZ
21602012-04-01 Eli Zaretskii <eliz@gnu.org>
2161
2162 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2163 instead of alloca. (Bug#11138)
2164
3b0512a3
AS
21652012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2166
2167 * w32menu.c (is_simple_dialog): Properly check lisp types.
2168 (Bug#11141)
2169
8427ddd2
EZ
21702012-03-31 Eli Zaretskii <eliz@gnu.org>
2171
979022ef
EZ
2172 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2173 position we get to after a call to move_it_to fails the
2174 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2175 only if we wind up in a string from display property. (Bug#11063)
2176
a6b1c7cc
EZ
2177 * window.c (Fdelete_other_windows_internal): Invalidate the row
2178 and column information about mouse highlight, so that redisplay
2179 restores it after reallocating the glyph matrices. (Bug#7464)
2180
8427ddd2
EZ
2181 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2182 string comes from a `display' text property, use the buffer
2183 position of that property as if we actually saw that position in
2184 the row's glyphs.
697ba24b
EZ
2185 (move_it_by_lines): Remove the assertion that
2186 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2187 violated when there's a before-string at the beginning of a line.
2188 (Bug#11063)
8427ddd2 2189
65a0a738
EZ
21902012-03-30 Eli Zaretskii <eliz@gnu.org>
2191
2192 * xdisp.c (append_space_for_newline): If the default face was
2193 remapped, use the remapped face for the appended newline.
2194 (extend_face_to_end_of_line): Use the remapped default face for
2195 extending the face to the end of the line.
2196 (display_line): Call extend_face_to_end_of_line when the default
2197 face was remapped. (Bug#11068)
2198
581355cc
EZ
21992012-03-29 Eli Zaretskii <eliz@gnu.org>
2200
2201 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2202
e8fc049f
SM
22032012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2204
2205 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2206
4fb9a543
GM
22072012-03-27 Glenn Morris <rgm@gnu.org>
2208
2209 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2210 Doc fixes.
2211
679910f1
KH
22122012-03-26 Kenichi Handa <handa@m17n.org>
2213
2214 * dispextern.h (struct glyph): Fix previous change. Change the
2215 bit length of glyphless.ch to 25 (Bug#11082).
2216
90d49b7f
CY
22172012-03-26 Chong Yidong <cyd@gnu.org>
2218
2219 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2220 (command_loop_1): Use it; inhibit selection update for
2221 handle-select-window too (Bug#8996).
2222
f514f6f0
FP
22232012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2224
e8fc049f 2225 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2226
bf43fa51
KH
22272012-03-25 Kenichi Handa <handa@m17n.org>
2228
2229 * dispextern.h (struct glyph): Change the bit length of
2230 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2231
8a0c01dd
EZ
22322012-03-24 Eli Zaretskii <eliz@gnu.org>
2233
2234 * s/ms-w32.h (tzname): Include time.h before redirecting to
2235 _tzname. Fixes the MSVC build. (Bug#9960)
2236
7d1c3a76
AS
22372012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2238
8ed79523
AS
2239 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2240 characters.
2241
7d1c3a76
AS
2242 * xterm.c (XTread_socket): Only modify handling_signal if
2243 !SYNC_INPUT. (Bug#11080)
2244
e99a9b8b
EZ
22452012-03-23 Eli Zaretskii <eliz@gnu.org>
2246
2247 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2248 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2249 when fetching a multibyte character consumes more bytes than
2250 CHAR_BYTES returns, due to unification of CJK characters in
2251 string_char. (Bug#11073)
2252
5063c0e1
TN
22532012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2254
2255 * process.c (wait_reading_process_output): Handle pty disconnect
2256 by refraining from sending oneself a SIGCHLD (bug#10933).
2257
9f851fbd
CY
22582012-03-22 Chong Yidong <cyd@gnu.org>
2259
2260 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2261
5063c0e1 2262 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2263 Mark string as coming from a prefix property.
2264 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2265 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2266
fb5b8aca
CY
22672012-03-21 Chong Yidong <cyd@gnu.org>
2268
2269 * xfaces.c (Vface_remapping_alist): Doc fix.
2270
62356a1b
EZ
22712012-03-20 Eli Zaretskii <eliz@gnu.org>
2272
2273 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2274 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2275 Doc fixes.
62356a1b 2276
025de85b
CY
22772012-03-20 Chong Yidong <cyd@gnu.org>
2278
2279 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2280 to reflect default non-nil value of redisplay-dont-pause.
2281
4827f94e
KH
22822012-03-19 Kenichi Handa <handa@m17n.org>
2283
2284 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2285 it fit in a valid range (Bug#11003).
2286
e50a24a2
EZ
22872012-03-18 Eli Zaretskii <eliz@gnu.org>
2288
2289 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2290 that is not from display property, accept the row as a "cursor
2291 row" if one of the string's character has a non-nil `cursor'
2292 property. Fixes cursor positioning when there are newlines in
2293 overlay strings, e.g. in icomplete.el. (Bug#11035)
2294
9af5ed87
PE
22952012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2296
2297 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2298
d1f55f16
CY
22992012-03-12 Chong Yidong <cyd@gnu.org>
2300
2301 * eval.c (inhibit_lisp_code): Rename from
2302 inhibit_window_configuration_change_hook; move from window.c.
2303
2304 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2305 * window.c (run_window_configuration_change_hook)
2306 (syms_of_window): Callers changed.
2307
66c5eebd
CY
23082012-03-11 Chong Yidong <cyd@gnu.org>
2309
413df973
CY
2310 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2311
66c5eebd
CY
2312 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2313
1de11f56
CY
23142012-03-10 Chong Yidong <cyd@gnu.org>
2315
2316 * frame.c (other_visible_frames): Don't assume the selected frame
2317 is visible (Bug#10955).
2318
cae07000
SM
23192012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2320
2321 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2322
89c94350
JD
23232012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2324
2325 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2326 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2327 zero (Bug#10954).
2328
999dd333
GM
23292012-03-03 Glenn Morris <rgm@gnu.org>
2330
01a6dcc8 2331 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2332
de0100f2
EZ
23332012-03-02 Eli Zaretskii <eliz@gnu.org>
2334
2335 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2336 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2337 (redisplay_window, next_element_from_string): Fix typos in
2338 comments.
3e441275
EZ
2339 (redisplay_window): Pass to move_it_vertically the margin in
2340 pixels, not in screen lines.
de0100f2 2341
96a72ee9
GM
23422012-03-02 Glenn Morris <rgm@gnu.org>
2343
2344 * buffer.c (buffer-list-update-hook): Doc fix.
2345
312508d7
EZ
23462012-02-29 Eli Zaretskii <eliz@gnu.org>
2347
2348 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2349 push_it before setting up the iterator for the first overlay
2350 string, even if we have an empty string loaded.
2351 (next_overlay_string): If there's an empty string on the iterator
2352 stack, pop the stack. (Bug#10903)
2353
27f3c637
PE
23542012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2355
2356 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2357 Suggested by Stefan Monnier in
2358 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2359 * alloc.c (widen_to_Lisp_Object): New static function.
2360 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2361 and widening them to Lisp_Objects. This would work even if
2362 USE_LSB_TAG is defined and wide integers are used, which might
2363 happen in a future version of Emacs.
2364
3c9dfce6
CY
23652012-02-25 Chong Yidong <cyd@gnu.org>
2366
fa74b241
CY
2367 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2368 Doc fix.
2369
3c9dfce6
CY
2370 * xselect.c (Fx_selection_exists_p): Doc fix.
2371 (x_clipboard_manager_save_all): Print an informative message
2372 before saving to clipboard manager.
2373
9486df08
CY
23742012-02-24 Chong Yidong <cyd@gnu.org>
2375
2376 * keyboard.c (process_special_events): Handle all X selection
2377 requests in kbd_buffer, not just the next one (Bug#8869).
2378
f01d3321
CY
23792012-02-23 Chong Yidong <cyd@gnu.org>
2380
2381 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2382 call when setting menu-bar-lines and tool-bar-lines parameters.
2383 (unwind_create_frame_1): New helper function.
2384
2385 * window.c (inhibit_window_configuration_change_hook): New var.
2386 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2387 (syms_of_window): Initialize it.
f01d3321 2388
86b847b6
CY
23892012-02-22 Chong Yidong <cyd@gnu.org>
2390
2391 * xterm.c (x_draw_image_relief): Add missing type check for
2392 Vtool_bar_button_margin (Bug#10743).
2393
a59225b1
CY
23942012-02-21 Chong Yidong <cyd@gnu.org>
2395
2396 * fileio.c (Vfile_name_handler_alist): Doc fix.
2397
2398 * buffer.c (Fget_file_buffer): Protect against invalid file
2399 handler return value.
2400
310f5bd4
PE
24012012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2402
cb3a28cc
PE
2403 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2404 when computing $valmask.
2405
310f5bd4
PE
2406 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2407 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2408 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2409 It's useless in that case, and it can cause problems on hosts
2410 that allocate halves of EMACS_INT values separately.
2411 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2412 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2413 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2414 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2415 it avoids undefined behavior on hosts where shifting right by more
2416 than the word width has undefined behavior.
2417
2375c96a
CY
24182012-02-19 Chong Yidong <cyd@gnu.org>
2419
2420 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2421 (Funhandled_file_name_directory, Ffile_name_as_directory)
2422 (Fdirectory_file_name, Fexpand_file_name)
2423 (Fsubstitute_in_file_name): Protect against invalid file handler
2424 return values (Bug#10845).
2425
3eb49e71
EZ
24262012-02-18 Eli Zaretskii <eliz@gnu.org>
2427
2428 * .gdbinit (pitx): Fix incorrect references to fields of the
2429 iterator stack.
2430
7b926f3f
CY
24312012-02-17 Chong Yidong <cyd@gnu.org>
2432
2433 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2434
11273115
PE
24352012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2436
2437 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2438 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2439
c3a70e2b
CY
24402012-02-15 Chong Yidong <cyd@gnu.org>
2441
2442 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2443 marked as special. Also, starting docstrings with * is obsolete.
2444
0ca43699
AS
24452012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2446
2447 * gnutls.c (emacs_gnutls_write): Fix last change.
2448
2e8f3c56
LI
24492012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2450
2451 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2452 send_process.
2453
af70074f
SM
24542012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2455
2456 * keymap.c (Fsingle_key_description): Handle char ranges.
2457
95986d52
CY
24582012-02-12 Chong Yidong <cyd@gnu.org>
2459
afd83bd1
CY
2460 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2461 as that creates a dangerous corner case.
2462
95986d52
CY
2463 * window.c (Fdelete_window_internal): Invalidate the mouse
2464 highlight (Bug#9904).
2465
bd7da63e
GM
24662012-02-12 Glenn Morris <rgm@gnu.org>
2467
2468 * xselect.c (Fx_own_selection_internal)
2469 (Fx_get_selection_internal, Fx_disown_selection_internal)
2470 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2471 * nsselect.m (Fx_own_selection_internal)
2472 (Fx_disown_selection_internal, Fx_selection_exists_p)
2473 (Fx_selection_owner_p, Fx_get_selection_internal):
2474 Sync docs and argument specs with the xselect.c versions.
2475
77abcbc2
LI
24762012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2477
2478 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2479
90b671e2
EZ
24802012-02-11 Eli Zaretskii <eliz@gnu.org>
2481
1c0ca0b7
EZ
2482 * w32select.c (Fx_selection_exists_p): Sync doc string and
2483 argument list with xselect.c. (Bug#10783)
2484
2485 * w16select.c (Fx_selection_exists_p): Sync doc string and
2486 argument list with xselect.c. (Bug#10783)
90b671e2 2487
49241268
GM
24882012-02-10 Glenn Morris <rgm@gnu.org>
2489
2490 * fns.c (Fsecure_hash): Doc fix.
2491
f998bbe7 24922012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2493
2494 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2495
0992bd9c
CY
24962012-02-07 Chong Yidong <cyd@gnu.org>
2497
2498 * buffer.c (Fbuffer_local_variables)
2499 (buffer_lisp_local_variables): Handle unbound vars correctly;
2500 don't let Qunbound leak into Lisp.
2501
af008560
GM
25022012-02-07 Glenn Morris <rgm@gnu.org>
2503
dd605cc4
GM
2504 * image.c (Fimagemagick_types): Doc fix.
2505
af008560
GM
2506 * image.c (imagemagick-render-type): Change it from a lisp object
2507 to an integer. Move the doc here from the lisp manual.
2508 Treat all values not equal to 0 the same.
2509
1449fa1d
CY
25102012-02-06 Chong Yidong <cyd@gnu.org>
2511
2512 * doc.c (store_function_docstring): Avoid applying docstring of
2513 alias to base function (Bug#2603).
2514
3723ec07
AS
25152012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2516
2517 * .gdbinit (pp1, pv1): Remove redundant defines.
2518 (pr): Use pp.
2519
79c1cc1e
CY
25202012-02-04 Chong Yidong <cyd@gnu.org>
2521
2522 * nsterm.m: Declare a global (Bug#10694).
2523
d7f29f8e
EZ
25242012-02-04 Eli Zaretskii <eliz@gnu.org>
2525
cae07000
SM
2526 * w32.c (get_emacs_configuration_options):
2527 Include --enable-checking, if specified, in the return value.
d7f29f8e 2528
3b95a6f9
MR
25292012-02-04 Martin Rudalics <rudalics@gmx.at>
2530
2531 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2532 after rounding frame sizes. (Bug#9723)
2533
d6fa96a6
EZ
25342012-02-04 Eli Zaretskii <eliz@gnu.org>
2535
2536 * keyboard.c (adjust_point_for_property): Don't position point
2537 before BEGV. (Bug#10696)
2538
df0b2940
PE
25392012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2540
2541 Handle overflow when computing char display width (Bug#9496).
2542 * character.c (char_width): Return EMACS_INT, not int.
2543 (char_width, c_string_width): Check for overflow when
2544 computing the width; this is possible now that individual
2545 characters can have unbounded width. Problem introduced
2546 by merge from Emacs 23 on 2012-01-19.
2547
6bee44d6
MA
25482012-02-02 Michael Albinus <michael.albinus@gmx.de>
2549
2550 * dbusbind.c (Fdbus_register_method): Mention the return value
2551 :ignore in the docstring.
2552
44f92739
GM
25532012-02-02 Glenn Morris <rgm@gnu.org>
2554
1b9f60cc
GM
2555 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2556
44f92739
GM
2557 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2558 Unconditionally set to t. (Bug#10673)
2559 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2560 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2561 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2562
c5d3843c
KH
25632012-02-02 Kenichi Handa <handa@m17n.org>
2564
2565 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2566 0, do not call append_composite_glyph.
2567
159462d4 25682012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
2569
2570 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2571 NULL (Bug#6988).
2572 (x_produce_glyphs): If the component of a composition is a null
2573 string, set it->pixel_width to 1 to avoid zero-width glyph.
2574
78cef877
EZ
25752012-02-01 Eli Zaretskii <eliz@gnu.org>
2576
2577 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2578 first 2 arguments are identical. This makes inserting large
2579 output from a subprocess an order of magnitude faster on
2580 MS-Windows, where all sbrk'ed memory is always contiguous.
2581
97897668
GM
25822012-01-31 Glenn Morris <rgm@gnu.org>
2583
2584 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 2585 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
2586 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2587
31fd3586
GM
25882012-01-29 Glenn Morris <rgm@gnu.org>
2589
2590 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2591
0e24a8b2
CY
25922012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2593
2594 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2595
cc0adcb0
CY
25962012-01-28 Chong Yidong <cyd@gnu.org>
2597
2598 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2599
acc28cb9
CY
26002012-01-26 Chong Yidong <cyd@gnu.org>
2601
9c69cfb7
CY
2602 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2603
acc28cb9
CY
2604 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2605 repeat counts (Bug#10507).
2606
48da7392
GM
26072012-01-26 Glenn Morris <rgm@gnu.org>
2608
2609 * lread.c (syms_of_lread): Doc fix.
2610
14af5f7f
CY
26112012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2612
2613 * coding.c (encode_designation_at_bol): Change return value to
2614 EMACS_INT.
2615
0b21c100
CY
26162012-01-25 Chong Yidong <cyd@gnu.org>
2617
2618 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2619
3c2907f7
CY
26202012-01-21 Chong Yidong <cyd@gnu.org>
2621
2622 * floatfns.c (Fcopysign): Make the second argument non-optional,
2623 since nil is not allowed anyway.
2624
959ad23f
AS
26252012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2626
2627 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2628 (send_process): Likewise.
2629
34a02f46
MR
26302012-01-19 Martin Rudalics <rudalics@gmx.at>
2631
2632 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
2633 (Vwindow_persistent_parameters): Do not use Qstate.
2634 Rewrite doc-strings.
34a02f46 2635
1259009a 26362012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
2637
2638 * character.c (char_width): New function.
70d4fdf6
GM
2639 (Fchar_width, c_string_width, lisp_string_width):
2640 Use char_width (Bug#9496).
25ed9e61 2641
6a6ee00d
MR
26422012-01-16 Martin Rudalics <rudalics@gmx.at>
2643
2644 * window.c (Vwindow_persistent_parameters): New variable.
2645 (Fset_window_configuration, save_window_save): Handle persistent
2646 window parameters.
2647
c85efaf7
EZ
26482012-01-14 Eli Zaretskii <eliz@gnu.org>
2649
2650 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2651 thrashing the stack of the thread. (Bug#9087)
2652
5944709e
PE
26532012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2654
2655 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2656
e71f5d99
EZ
26572012-01-11 Eli Zaretskii <eliz@gnu.org>
2658
2659 * xdisp.c (rows_from_pos_range): Handle the case where the
2660 highlight ends on a newline. (Bug#10464)
2661 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2662 he end column for display of highlight that ends on a newline
2663 before a R2L line.
2664
ce316182
GM
26652012-01-11 Glenn Morris <rgm@gnu.org>
2666
2667 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2668 from load-path also when installation-directory is nil. (Bug#10208)
2669
5b43da69
GM
26702012-01-10 Glenn Morris <rgm@gnu.org>
2671
74cc8ff9
GM
2672 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2673
7d8d6e4e
GM
2674 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2675 Update template values to be closer to their typical values these days.
5b43da69 2676
a0db8d43
EZ
26772012-01-09 Eli Zaretskii <eliz@gnu.org>
2678
2679 * xdisp.c (rows_from_pos_range): Accept additional argument
2680 DISP_STRING, and accept any glyph in a row whose object is that
2681 string as eligible for mouse highlight. Fixes mouse highlight of
2682 display strings from overlays. (Bug#10464)
2683
9a0115ab 26842012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 2685
b9110d6a 2686 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
2687 * fileio.c (auto_saving_dir_umask): New static var.
2688 (Fmake_directory_internal): Use it.
2689 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2690 creating the directory. The old code temporarily assigns
2691 too-generous permissions to the directory.
2692 (do_auto_save_eh): Clear it.
b9110d6a 2693 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
2694 that the var is always cleared.
2695
6c1bd3f3
EZ
26962012-01-07 Eli Zaretskii <eliz@gnu.org>
2697
2698 * search.c (scan_buffer): Pass character positions to
2699 know_region_cache, not byte positions. (Bug#6540)
2700
069d2b50
L
27012012-01-07 LynX <_LynX@bk.ru> (tiny change)
2702
2703 * w32.c (sys_rename): Report EXDEV when rename of a directory
2704 fails because the target is on another logical disk. (Bug#10284)
2705
75bf0d33
DB
27062012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2707
2708 * xterm.c (x_embed_request_focus): New function.
2709
2710 * xterm.h: Add prototype.
2711
2712 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2713
1c6e5a32
GM
27142012-01-05 Glenn Morris <rgm@gnu.org>
2715
2716 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2717
651e947e
EZ
27182012-01-01 Eli Zaretskii <eliz@gnu.org>
2719
2720 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2721 Load gnutls_transport_set_lowat only if GnuTLS version is below
2722 2.11.1.
2723 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2724 GnuTLS versions below 2.11.1.
2725
3778cdd8
AL
27262011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2727
2728 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2729 to the doc string advising against its use for altering the way
2730 windows are scrolled.
2731
0e5317f7
KH
27322011-12-28 Kenichi Handa <handa@m17n.org>
2733
2734 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2735 coding-system ASCII compatible only when it does not produce BOM
2736 on encoding (Bug#10383).
2737
93d5ca1f
JD
27382011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2739
2740 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2741 can scroll.
2742 (create_and_show_popup_menu): Always use menu_position_func for
2743 Gtk3 (Bug#10361).
2744
ca22b785
AS
27452011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2746
2747 * callint.c (Fcall_interactively): Don't truncate prompt string.
2748
d048e1e6
EZ
27492011-12-23 Eli Zaretskii <eliz@gnu.org>
2750
2751 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2752 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 2753 resumed from there (after widening). (Bug#10360)
d048e1e6 2754
5ccaba1f
JD
27552011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2756
2757 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2758
204ee57f
JD
27592011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2760
b81d40f0
JB
2761 * nsterm.m (x_free_frame_resources):
2762 Release f->output_data.ns->miniimage.
204ee57f
JD
2763 (ns_index_color): Fix indentation. Do not retain
2764 color_table->colors[i].
2765
2766 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2767 before returning.
2768
2769 * nsfns.m (x_set_background_color): Assign return value from
2770 ns_index_color to face-background instead of NSColor*.
2771 (ns_implicitly_set_icon_type): Fix indentation.
2772 Change assignment in for loop to comparison.
2773
2774 * emacs.c (ns_pool): New variable.
2775 (main): Assign ns_pool.
2776 (Fkill_emacs): Call ns_release_autorelease_pool.
2777
2778 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2779 autorelease fdesc, release fdAttrs and tdict.
2780 (ns_get_covering_families): Release charset.
2781 (ns_findfonts): Release NSFontDescriptor created with new.
2782 (ns_uni_to_glyphs): Fix indentation.
2783 (setString): Release attrStr before assigning new value.
2784
c803b2b7
JD
27852011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2786
678f4426
JD
2787 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2788 and NS_IMPL_COCOA.
2789 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2790 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2791
cd394be1 27922011-12-18 David Reitter <reitter@cmu.edu>
678f4426 2793
5fecd5fc
JD
2794 * nsterm.m (ns_term_init): Subscribe for notifications
2795 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2796 to method trackingNotification in EmacsMenu.
2797
2798 * nsmenu.m (trackingMenu): New variable.
3771cb17 2799 (trackingNotification): New method (from Aquamacs).
5fecd5fc 2800 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 2801 from Aquamacs (Bug#7030).
678f4426
JD
2802
28032011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 2804
c803b2b7
JD
2805 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2806 (symbol_to_nsstring): Fix indentation.
2807 (ns_symbol_to_pb): New function.
cae07000
SM
2808 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2809 (Fns_rotate_cut_buffers_internal): Remove.
2810 (Fns_store_selection_internal): Rename from
c803b2b7
JD
2811 Fns_store_cut_buffer_internal.
2812 (ns_get_foreign_selection, Fx_own_selection_internal)
2813 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
2814 (Fns_get_selection_internal, Fns_store_selection_internal):
2815 Use ns_symbol_to_pb and check if return value is nil.
2816 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2817 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
2818 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2819 renamed to Sns_store_selection_internal.
2820 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2821 and remove this function.
2822 (ns_handle_selection_clear): Remove, never used.
2823 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2824 here.
2825
e1b01a3a
KB
28262011-12-17 Ken Brown <kbrown@cornell.edu>
2827
2828 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2829 GID is unknown (Bug#10257).
2830
2adb6e85
PE
28312011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2832
2833 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2834 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2835 which caused a build failure on GNU/Linux IA-64. This problem was
2836 introduced by my 2011-10-07 patch.
2837
d1d7b339
JL
28382011-12-15 Juri Linkov <juri@jurta.org>
2839
2840 * image.c (imagemagick_error): New function. (Bug#10112)
2841 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2842 Use `imagemagick_error' where ImageMagick functions return
2843 `MagickFalse'.
2844 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2845 proper order.
2846
100d5755
KH
28472011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2848
2849 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2850 fill background (Bug#8992).
2851
454592a6
MR
28522011-12-13 Martin Rudalics <rudalics@gmx.at>
2853
2854 * window.c (Vwindow_combination_resize)
2855 (Vwindow_combination_limit): Use t instead of non-nil in
2856 doc-strings.
61d4b438
MR
2857 (Vrecenter_redisplay): Add first sentence of doc-string on
2858 separate line.
53524d93 2859 (Frecenter): Fix doc-string typo.
454592a6 2860
3633e3aa
KH
28612011-12-11 Kenichi Handa <handa@m17n.org>
2862
2863 * coding.c (Funencodable_char_position): Pay attention to the
2864 buffer text relocation (Bug#9389).
2865
7b9d523a 28662011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 2867
7b9d523a
JD
2868 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2869 gtk_init (Bug#10100).
2870
b73189c6
EZ
28712011-12-10 Eli Zaretskii <eliz@gnu.org>
2872
2873 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2874 IT->string is nil. (Bug#10263)
2875
f7dfe5d6
JD
28762011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2877
83faebb4
JD
2878 * nsterm.h (x_free_frame_resources): Declare.
2879
f7dfe5d6
JD
2880 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2881 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2882
2883 * nsterm.h (ns_get_defaults_value): Declare.
2884
2885 * nsterm.m (ns_default): Call ns_get_defaults_value.
2886
7cd4e72c
EZ
28872011-12-09 Eli Zaretskii <eliz@gnu.org>
2888
2889 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2890 (Bug#10170)
2891
b34d7317
YM
28922011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2893
2894 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2895 that where the value of an _OBJC_* symbol points to is in the .bss
2896 section (Bug#10240).
2897
76470ad1
KH
28982011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2899
2900 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 2901 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 2902
745fff94
KH
29032011-12-08 Kenichi Handa <handa@m17n.org>
2904
2905 * ftfont.c (get_adstyle_property): Fix previous change
2906 (Bug#10233).
2907
6e44397c
JB
29082011-12-07 Juanma Barranquero <lekktu@gmail.com>
2909
2910 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2911 dirs from the default value of EMACSLOADPATH (bug#10208).
2912
7efa6272
GM
29132011-12-07 Glenn Morris <rgm@gnu.org>
2914
2915 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2916 installation and source directories as well. (Bug#10208)
2917
f6fc4d87
CY
29182011-12-06 Chong Yidong <cyd@gnu.org>
2919
2920 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2921
2bf26180
GM
29222011-12-06 Glenn Morris <rgm@gnu.org>
2923
2924 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2925 as an error, not just -1. (Bug#10217)
2926
3a6ad4f0
CY
29272011-12-05 Chong Yidong <cyd@gnu.org>
2928
2929 * keyboard.c (process_special_events): New function.
2930 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2931
75a3b399
PE
29322011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2933
2934 * coding.c (encode_designation_at_bol): Don't use uninitialized
2935 local variable (Bug#9318).
2936
c3c9e25e
KH
29372011-12-05 Kenichi Handa <handa@m17n.org>
2938
2939 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2940 return Qnil (Bug#8046, Bug#10193).
2941
5eb05ea3
KH
29422011-12-05 Kenichi Handa <handa@m17n.org>
2943
2944 * coding.c (encode_designation_at_bol): New args charbuf_end and
2945 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
2946 (coding_set_source): Return how many bytes coding->source was
2947 relocated.
2948 (coding_set_destination): Return how many bytes
2949 coding->destination was relocated.
2950 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 2951 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
2952
29532011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2954
2955 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2956 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2957 macro (Bug#9318).
2958
29592011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2960
2961 The following changes are to fix Bug#9318.
2962
a79703f5 2963 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
2964 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2965 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 2966 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 2967
7dbda6df
JB
29682011-12-05 Juanma Barranquero <lekktu@gmail.com>
2969
2970 * lisp.h (process_quit_flag): Fix external declaration.
2971
6d5eb5b0
SM
29722011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2973
2974 Don't macro-inline non-performance-critical code.
2975 * eval.c (process_quit_flag): New function.
2976 * lisp.h (QUIT): Use it.
2977
a0c3fad0
JD
29782011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2979
2980 * nsfns.m (get_geometry_from_preferences): New function.
2981 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2982
6c07aac2
AS
29832011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2984
2985 * emacs.c (Qkill_emacs): Define.
2986 (syms_of_emacs): Initialize it.
2987 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2988 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
2989 (quit_throw_to_read_char): Add parameter `from_signal'.
2990 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
2991 * lisp.h (QUIT): Call Fkill_emacs if requested.
2992
c052ead4
JD
29932011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2994
2995 * widget.c (update_wm_hints): Return if wmshell is null.
2996 (widget_update_wm_size_hints): New function.
2997
2998 * widget.h (widget_update_wm_size_hints): Declare.
2999
3000 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3001 widget_update_wm_size_hints (Bug#10104).
3002
9e49252b
EZ
30032011-12-03 Eli Zaretskii <eliz@gnu.org>
3004
3005 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3006 before a newline, prepare the bidi iterator for consuming the
3007 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3008 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3009
02b16839
JL
30102011-12-02 Juri Linkov <juri@jurta.org>
3011
3012 * search.c (Fword_search_regexp): New Lisp function created from
3013 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3014 (Fword_search_backward, Fword_search_forward)
3015 (Fword_search_backward_lax, Fword_search_forward_lax):
3016 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3017 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3018
0068070e
SM
30192011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3020
3021 * fileio.c (Finsert_file_contents): Move after-change-function call
3022 to before the "handled:" label, since all "goto handled" appear in
3023 cases where the *-change-functions have already been properly called
3024 (bug#10117).
3025
3360a3fc
AS
30262011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3027
3028 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3029 waiting for input. (Bug#10169)
3030
73d6c093
EZ
30312011-11-30 Eli Zaretskii <eliz@gnu.org>
3032
3033 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3034 verifies glyph row's hash code--we have just reallocated the
3035 glyphs, so their contents can be complete garbage. (Bug#10164)
3036
febe6bea
JB
30372011-11-30 Juanma Barranquero <lekktu@gmail.com>
3038
3039 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3040
801a4313
EZ
30412011-11-30 Eli Zaretskii <eliz@gnu.org>
3042
3043 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3044 attributes are tested _before_ calling verify_row_hash, to protect
3045 against GCC re-ordering of the tests. (Bug#10164)
3046
2b56b87e
JD
30472011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3048
3049 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3050
3051 * xterm.c (handle_one_xevent): Only set async_visible and friends
3052 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3053 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3054 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3055
dbf31225
PE
30562011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3057
3058 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3059 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3060 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3061 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3062 All uses changed to use GCPRO1 etc.
3063 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3064 Revert to old implementation (i.e., before 2011-03-11).
3065
1305621b
YM
30662011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3067
3068 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3069 of scroll runs so as to avoid assigning disabled bogus rows and
3070 unnecessary graphics copy operations.
3071
8c9afb46
EZ
30722011-11-27 Eli Zaretskii <eliz@gnu.org>
3073
3074 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3075 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3076 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3077 (malloc, free, realloc, calloc): Redirect to e_* only when
3078 compiling Emacs.
3079
3080 * lisp.h (GCTYPEBITS): Move before first use.
3081 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3082 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3083 this macro definition.
3084
3085 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3086 _MSC_VER.
3087
54e9e3bf
JD
30882011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3089
6d5eb5b0
SM
3090 * gtkutil.c (xg_create_frame_widgets):
3091 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3092 present with Gtk+ 2.0.
3093
83aca1cb
PE
30942011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3095
3096 * fileio.c (Finsert_file_contents): Undo previous change; see
3097 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3098
5b76caa4
PE
30992011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3100
3101 Rename locals to avoid shadowing.
3102 * fileio.c (Finsert_file_contents):
3103 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3104 * process.c (wait_reading_process_output):
3105 Rename inner 'proc' to 'p' to avoid shadowing.
3106 Indent for consistency with usual Emacs style.
3107
8c535114
EZ
31082011-11-25 Eli Zaretskii <eliz@gnu.org>
3109
3110 * xdisp.c (redisplay_window): If cursor row is not fully visible
3111 after recentering, and scroll-conservatively is set to a large
3112 number, scroll window by a few more lines to make the cursor fully
3113 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3114 (start_display): Don't move to the next line if the display should
3115 start at a newline that is part of a display vector or an overlay
3116 string. (Bug#10119)
8c535114 3117
fa4fdb5c
JL
31182011-11-24 Juri Linkov <juri@jurta.org>
3119
3120 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3121 after the `MagickPingImage' call. (Bug#10112)
3122
90ec88df
CY
31232011-11-23 Chong Yidong <cyd@gnu.org>
3124
3125 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3126
56e2e794
MR
31272011-11-23 Martin Rudalics <rudalics@gmx.at>
3128
3129 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3130 making another buffer current. (Bug#10114)
3131
b6e64c41
GM
31322011-11-23 Glenn Morris <rgm@gnu.org>
3133
3134 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3135
6b21de18
CY
31362011-11-23 Chong Yidong <cyd@gnu.org>
3137
3138 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3139 using it (Bug#5984).
3140
b12cd789
EZ
31412011-11-22 Eli Zaretskii <eliz@gnu.org>
3142
3143 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3144 and header-lines, as they don't have one computed for them.
3145 (Bug#10098)
3146
3147 * .gdbinit (prow): Make displayed values more self-explaining.
3148 Add row's hash code.
3149
261b6fd4
LMI
31502011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3151
3152 * process.c (wait_reading_process_output): Fix asynchrounous
3153 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3154 (wait_reading_process_output): Add comment and URL.
261b6fd4 3155
e7cfd277
JD
31562011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3157
3158 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3159
a9b9b7f5
CY
31602011-11-21 Chong Yidong <cyd@gnu.org>
3161
3162 * window.c (Fnext_window, Fprevious_window): Doc fix.
3163
b0d15b4f
SM
31642011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3165
3166 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3167
fe7a3057
JB
31682011-11-20 Juanma Barranquero <lekktu@gmail.com>
3169
3170 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3171
d2999b1a
MR
31722011-11-20 Martin Rudalics <rudalics@gmx.at>
3173
3174 * window.c (Fset_window_combination_limit): Rename argument
3175 STATUS to LIMIT.
3176 (Vwindow_combination_limit): Remove "status" from doc-string.
3177
d5ff9cd0
AS
31782011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3179
3180 * m/ibms390.h: Remove.
3181 * m/ibms390x.h: Don't include "ibms390.h".
3182
a5bb9bd3
SM
31832011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3184
3185 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3186 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3187
cd1181db
JB
31882011-11-20 Juanma Barranquero <lekktu@gmail.com>
3189
3190 * casetab.c (Fset_case_table):
3191 * charset.c (Fcharset_after): Fix typos.
3192
615a3b8d 31932011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3194
17e845af
PE
3195 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3196 Otherwise, valgrind does not work on some platforms.
3197 Problem reported by Andreas Schwab in
6a0bf43d
PE
3198 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3199 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3200 is set, removing the need for VIRT_ADDRESS_VARIES.
3201 (PURE_P): Use a more-efficient implementation that needs just one
3202 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3203 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3204 to 4 (xorl, subq, cmpq, setbe).
3205 * alloc.c (pure): Always extern now, since that's the
3206 VIRT_ADDR_VARIES behavior.
3207 (PURE_POINTER_P): Use a single comparison, not two, for
3208 consistency with the new puresize.h.
3209 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3210 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3211 Remove VIRT_ADDR_VARIES no longer needed.
3212
f8fe6f96
EZ
32132011-11-19 Eli Zaretskii <eliz@gnu.org>
3214
3215 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3216 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3217 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3218 behave as if the cursor position were at the window margin.
3219
3220 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3221 and the cursor position is out of bounds, behave as if the cursor
3222 position were at the window margin. (Bug#10075)
3223
df05a53c
CY
32242011-11-18 Chong Yidong <cyd@gnu.org>
3225
3226 * window.c (Fwindow_combination_limit): Make first argument
3227 non-optional, since it is meaningless for live windows like the
3228 selected window.
61ccba97 3229
2071918e
DA
32302011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3231
3232 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3233
b50a28de
SM
32342011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3235
3236 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3237 (graft_intervals_into_buffer): Simplify.
3238
015137db
EZ
32392011-11-18 Eli Zaretskii <eliz@gnu.org>
3240
3241 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3242 hash values of the two rows.
3243 (copy_row_except_pointers): Preserve the used[] arrays and the
3244 hash values of the two rows. (Bug#10035)
68c95424 3245 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3246
3247 * xdisp.c (row_hash): New function, body extracted from
3248 compute_line_metrics.
3249 (compute_line_metrics): Call row_hash, instead of computing the
3250 hash code inline.
3251
3252 * dispnew.c (verify_row_hash): Call row_hash for computing the
3253 hash code of a row, instead of duplicating code from xdisp.c.
3254
3255 * dispextern.h (row_hash): Add prototype.
3256
a2addb04
TH
32572011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3258
3259 * frame.c (delete_frame): Don't delete the terminal when the last
3260 X frame is closed if emacs is built with GTK toolkit.
3261
df85d315
JB
32622011-11-17 Juanma Barranquero <lekktu@gmail.com>
3263
3264 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3265
a0c2d0ae
MR
32662011-11-17 Martin Rudalics <rudalics@gmx.at>
3267
3268 * window.c (Vwindow_splits): Rename to
3269 Vwindow_combination_resize. Suggested by Juri Linkov.
3270 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3271 of Vwindow_splits.
3272
58179cce
JB
32732011-11-16 Juanma Barranquero <lekktu@gmail.com>
3274
7877f373
JB
3275 * nsfns.m (Fns_font_name):
3276 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3277
b6f67890
MR
32782011-11-16 Martin Rudalics <rudalics@gmx.at>
3279
3280 * window.h (window): Rename slot "nest" to "combination_limit".
3281 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3282 (Fset_window_nest): Rename to Fset_window_combination_limit.
3283 (Vwindow_nest): Rename to Vwindow_combination_limit.
3284 (recombine_windows, make_parent_window, make_window)
3285 (Fsplit_window_internal, saved_window)
3286 (Fset_window_configuration, save_window_save): Rename all
3287 occurrences of window_nest to window_combination_limit.
3288
c7015153
JB
32892011-11-15 Juanma Barranquero <lekktu@gmail.com>
3290
3291 * image.c (imagemagick_load_image): Fix typo.
3292
322ad6ec
EZ
32932011-11-14 Eli Zaretskii <eliz@gnu.org>
3294
3295 * xdisp.c (display_line): Move the call to
3296 highlight_trailing_whitespace before the call to
3297 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3298 faces of all the glyphs to compute ROW's hash value.
3299 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3300
f067b8ec
JB
33012011-11-14 Juanma Barranquero <lekktu@gmail.com>
3302
3303 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3304 just return (bug#10044).
3305
1e5b2111
EZ
33062011-11-12 Eli Zaretskii <eliz@gnu.org>
3307
7ef3cbd5
EZ
3308 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3309 with user-defined heap size. Bump the default size of the temacs
3310 heap to 27MB, to avoid memory warning when running temacs.
3311 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3312
1e5b2111
EZ
3313 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3314 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3315 (verify_row_hash) [XASSERTS]: New function.
3316 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3317 that the hash value of glyph rows is correct.
1e5b2111 3318
89d61221
MR
33192011-11-12 Martin Rudalics <rudalics@gmx.at>
3320
3321 * window.h (window): Remove splits slot.
3322 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3323 (Fdelete_other_windows_internal, make_parent_window)
3324 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3325 (Fset_window_configuration, save_window_save): Don't deal with
3326 split status of windows.
3327 (saved_window): Remove splits slot.
3328 (Vwindow_splits): Rewrite doc-string.
3329
97f18cc8
JD
33302011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3331
3332 * xfns.c (unwind_create_frame):
3333 * nsfns.m (unwind_create_frame):
3334 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3335 Vframe_list (Bug#9999).
3336
22a648b4
DA
33372011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3338
0b381c7e 3339 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3340
659afede
KH
33412011-11-11 Kenichi Handa <handa@m17n.org>
3342
3343 * callproc.c (Fcall_process): Set the member dst_multibyte of
3344 process_coding.
3345
9ac0394b
KH
33462011-11-11 Johan Bockgård <bojohan@gnu.org>
3347
3348 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3349 avoid a crash (bug#9496).
3350
2fbdc249
CY
33512011-11-09 Chong Yidong <cyd@gnu.org>
3352
3353 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3354 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3355
ac6b1f81
PE
33562011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3357
3358 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3359
09db192c
PE
33602011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3361
3362 Avoid some portability problems by eschewing 'extern inline' functions.
3363 The trivial performance wins aren't worth the portability hassles; see
3364 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3365 et seq.
3366 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3367 (window_box_width, window_box_left, window_box_left_offset)
3368 (window_box_right, window_box_right_offset): Undo previous change,
3369 by removing the "extern"s.
3370 * intervals.c (adjust_intervals_for_insertion)
3371 (adjust_intervals_for_deletion): Undo previous change,
3372 making these static again.
3373 (offset_intervals, temp_set_point_both, temp_set_point)
3374 (copy_intervals_to_string): No longer inline.
3375 * xdisp.c (window_text_bottom_y, window_box_width)
3376 (window_box_height, window_box_left_offset)
3377 (window_box_right_offset, window_box_left, window_box_right)
3378 (window_box): No longer inline.
3379
105216ed
CY
33802011-11-08 Chong Yidong <cyd@gnu.org>
3381
3382 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3383 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3384 Signal an error if not a live window.
105216ed
CY
3385 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3386 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3387
ae9e237f
JB
33882011-11-07 Juanma Barranquero <lekktu@gmail.com>
3389
3390 * lisp.h (syms_of_abbrev): Remove declaration.
3391 Reported by CHENG Gao <chenggao@royau.me>.
3392
c7aa8333
EZ
33932011-11-07 Eli Zaretskii <eliz@gnu.org>
3394
3395 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3396 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3397 of temacs in GUI mode.
3398
be7f5545
MR
33992011-11-07 Martin Rudalics <rudalics@gmx.at>
3400
3401 * window.h: Declare delete_all_child_windows instead of
3402 delete_all_subwindows.
3403 * window.c (Fwindow_nest, Fset_window_nest)
3404 (Fset_window_new_total, Fset_window_new_normal)
3405 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3406 (delete_all_subwindows): Rename to delete_all_child_windows.
3407 (Fdelete_other_windows_internal, Fset_window_configuration):
3408 Call delete_all_child_windows instead of delete_all_subwindows.
3409 * frame.c (delete_frame): Call delete_all_child_windows instead
3410 of delete_all_subwindows.
3411
ca78dc43
PE
34122011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3413
3414 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3415 This is also needed for porting to any host where GC_MARK_STACK is
3416 not GC_MAKE_GCPROS_NOOPS.
3417 (which_symbols): Use it.
3418
a0241d01
KH
34192011-11-07 Kenichi Handa <handa@m17n.org>
3420
3421 * coding.c (coding_set_destination): Check coding->src_pos only
3422 when coding->src_object is a buffer (bug#9910).
3423
3424 * process.c (send_process): Set the member src_multibyte of coding
3425 to 0 (bug#9911) when sending a unibyte text.
3426
3427 * callproc.c (Fcall_process): Set the member src_multibyte of
3428 process_coding to 0 (bug#9912).
3429
a64bfdfa 34302011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3431
3432 * xmenu.c (cleanup_widget_value_tree): New function.
3433 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3434 calling free_menubar_widget_value_tree directly (Bug#9830).
3435
cb41b32a
PE
34362011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3437
3438 Fix some portability problems with 'inline'.
3439 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3440 (window_box_width, window_box_left, window_box_left_offset)
3441 (window_box_right, window_box_right_offset): Declare extern.
3442 Otherwise, these inline functions do not conform to C99 and
3443 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3444 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3445 * intervals.c (adjust_intervals_for_insertion)
3446 (adjust_intervals_for_deletion): Now extern, because otherwise the
3447 extern inline functions 'offset_intervals' couldn't refer to it.
3448 (static_offset_intervals): Remove.
3449 (offset_intervals): Rewrite using the old contents of
3450 static_offset_intervals. The old version didn't conform to C99
3451 because an extern inline function contained a reference to an
3452 identifier with static linkage.
3453
b7041366
AS
34542011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3455
3456 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3457 GC.
3458
88a37c4d
EZ
34592011-11-06 Eli Zaretskii <eliz@gnu.org>
3460
3461 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3462 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3463 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3464 return Qleft_to_right.
3465
49745b39
CY
34662011-11-06 Chong Yidong <cyd@gnu.org>
3467
3468 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3469 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3470 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3471 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3472 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3473 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3474 (Fwindow_vscroll): Doc fix.
3475 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3476 argument, since it makes no sense to pass a live window and for
3477 consistency with window-child.
3478
1f05cd82
CS
34792011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3480
3481 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3482 support MSVC.
3483
22610910
JR
34842011-11-05 Jason Rumney <jasonr@gnu.org>
3485
3486 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3487 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3488 fonts (Bug#6029).
3489 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3490 bitwise arithmetic preventing use of unicode-sip and non-truetype
3491 opentype fonts.
3492
a06776b2
EZ
34932011-11-05 Eli Zaretskii <eliz@gnu.org>
3494
3ad924ba
EZ
3495 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3496 "emacs"-only part.
3497
a06776b2
EZ
3498 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3499 initialization code to keep similarity to xfns.c after changes
3500 from 2011-11-05.
3501
c9e7db78
JD
35022011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3503
a97f8f3f
JD
3504 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3505 (unwind_create_frame): New function (Bug#9943).
3506 (Fx_create_frame): Restructure code to be more similar to the one in
3507 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3508 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3509 Move terminal->reference_count++ just before making the frame official
3510 (Bug#9943).
3511
3512 * nsterm.m (x_free_frame_resources): New function.
3513 (x_destroy_window): Move code to x_free_frame_resources.
3514
c9e7db78 3515 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3516 (Fx_create_frame, x_create_tip_frame):
3517 Move terminal->reference_count++ just before making the frame
75f1671a 3518 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3519 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3520
a6fc3b5c
EZ
35212011-11-05 Eli Zaretskii <eliz@gnu.org>
3522
3523 Support MSVC build with newer versions of Visual Studio.
3524 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3525 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3526 nt/gmake.defs.
3527
3528 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3529 which are not supported by MSVC.
3530 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3531 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3532 bitfields.
3533 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3534 types in bitfields.
3535 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3536
3537 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3538
58179cce 35392011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3540
3541 Support MSVC build with newer versions of Visual Studio.
3542 * w32.c: Don't include w32api.h for MSVC.
3543 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3544
3545 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3546 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3547 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3548 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3549 e_* cousins.
3550 (alloca) [_MSC_VER]: Define to _alloca.
3551
3552 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3553
3554 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3555
a58c13ed
EZ
35562011-11-04 Eli Zaretskii <eliz@gnu.org>
3557
3558 * xdisp.c (note_mouse_highlight): If either of
3559 previous/next-single-property-change returns nil, treat that as
3560 the beginning or the end of the buffer. (Bug#9955)
3561
fe0b6370
JD
35622011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3563
a58c13ed 3564 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
3565 label is not null (Bug#9951).
3566 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3567 may be NULL.
3568
89bd5ee1
EZ
35692011-11-04 Eli Zaretskii <eliz@gnu.org>
3570
3571 * window.c (Fwindow_body_size): Mention in the doc string that the
3572 return value is in frame's canonical units. (Bug#9949)
3573
84c3edb9
EZ
35742011-11-03 Eli Zaretskii <eliz@gnu.org>
3575
4e2fb5c7
EZ
3576 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3577
84c3edb9 3578 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 3579 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 3580 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 3581
bc17a887
EZ
35822011-11-01 Eli Zaretskii <eliz@gnu.org>
3583
3584 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3585 Don't stop backward scan on the continuation glyph, even though
3586 its CHARPOS is positive.
6d5eb5b0
SM
3587 (mouse_face_from_buffer_pos, note_mouse_highlight):
3588 Rename cover_string to disp_string.
bc17a887 3589
4ee88440
MR
35902011-11-01 Martin Rudalics <rudalics@gmx.at>
3591
3592 * window.c (temp_output_buffer_show): Don't use
3593 Vtemp_buffer_show_specifiers.
3594 (Vtemp_buffer_show_specifiers): Remove unused variable.
3595
c2ff3c02
EZ
35962011-10-30 Eli Zaretskii <eliz@gnu.org>
3597
3598 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3599 past the beginning of the current glyph matrix.
3600
58179cce 36012011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
3602
3603 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3604 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3605 HAVE_GTK3 (Bug#9869).
b77a6a7f 3606
3b574623
JD
3607 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3608 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3609
b77a6a7f
JD
3610 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3611
3612 * xterm.c: Declare x_handle_net_wm_state to return int.
3613 (handle_one_xevent): Check if we are iconified but don't have
3614 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3615 (get_current_wm_state): Return non-zero if not hidden,
3616 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3617 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3618 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3619 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3620
196e41e4
PE
36212011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3622
3623 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3624 so that this new function doesn't get optimized away by a
3625 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3626
021f2e1a
AS
36272011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3628
3629 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3630
8b058d44
EZ
36312011-10-29 Eli Zaretskii <eliz@gnu.org>
3632
3633 Fix the `xbytecode' command.
3634 * .gdbinit (xprintbytestr): New command.
b50a28de 3635 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
3636 (xbytecode): Print the byte-code string as well.
3637
4452fb80
EZ
36382011-10-29 Kim Storm <storm@cua.dk>
3639
8b058d44
EZ
3640 * alloc.c (which_symbols): New function.
3641
21b72067
AS
36422011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3643
3644 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3645 line. (Bug#9903)
3646
83ed7b5c
GM
36472011-10-29 Glenn Morris <rgm@gnu.org>
3648
3649 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3650 Not clear what it was for, and it causes various bugs. (Bug#9839)
3651
5a7a728b
EZ
36522011-10-28 Eli Zaretskii <eliz@gnu.org>
3653
3654 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3655 possible random value that matches one of those tested as
3656 condition to clear the mouse face.
3657
d3d0842f
CY
36582011-10-28 Chong Yidong <cyd@gnu.org>
3659
3660 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3661
31b39d13
DN
36622011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3663
3664 * window.c (make_window): Initialize phys_cursor_on_p.
3665
9aba6043
SM
36662011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3667
3668 * lisp.h (struct Lisp_Symbol): Update comments.
3669
c20992f4
JB
36702011-10-28 Juanma Barranquero <lekktu@gmail.com>
3671
3672 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3673
db4f02f2
EZ
36742011-10-28 Eli Zaretskii <eliz@gnu.org>
3675
3676 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3677 <oslsachem@gmail.com> for helping to debug this.
3678
3679 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3680 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3681 (g_b_init_get_glyph_outline_w): New static variables.
3682 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3683 (GetGlyphOutlineW_Proc): New typedefs.
3684 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
3685 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3686 New functions.
3687 (w32font_open_internal, compute_metrics):
3688 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
3689 instead of calling the "wide" APIs directly.
3690
3691 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3692
3693 * w32.h (syms_of_w32font): Add prototype.
3694
87e68db4
JB
36952011-10-27 Juanma Barranquero <lekktu@gmail.com>
3696
3697 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3698 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3699 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3700 (Fmove_to_window_line): Doc fix.
3701
435c1d67
CY
37022011-10-27 Chong Yidong <cyd@gnu.org>
3703
3704 * process.c (make_process): Set gnutls_state to NULL.
3705
3706 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3707 non-NULL, regardless of GNUTLS_INITSTAGE.
3708 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3709 an error. Set process slots as soon as we allocate them.
3710
3711 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3712
9c6c6f49
CY
37132011-10-27 Chong Yidong <cyd@gnu.org>
3714
9aba6043
SM
3715 * gnutls.c (emacs_gnutls_deinit): New function.
3716 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
3717 (Fgnutls_deinit, Fgnutls_boot): Use it.
3718
3719 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3720 (deactivate_process): Call emacs_gnutls_deinit.
3721
657d08d3
JB
37222011-10-27 Juanma Barranquero <lekktu@gmail.com>
3723
3724 * image.c (x_create_x_image_and_pixmap):
3725 * w32.c (sys_rename, w32_delayed_load):
3726 * w32font.c (fill_in_logfont):
3727 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3728
5430d399
JB
37292011-10-26 Juanma Barranquero <lekktu@gmail.com>
3730
3731 * w32fns.c (w32_default_color_map): New function,
3732 extracted from Fw32_default_color_map.
a7ef684b 3733 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 3734
fe0055fa
PE
37352011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3736
3737 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3738
e6346438
SM
37392011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3740
3741 * keyboard.c (test_undefined): New function (bug#9751).
3742 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3743
e112cc37
ET
37442011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3745
3746 * sysdep.c (init_sys_modes): Fix the check for the controlling
3747 terminal (Bug#6649).
3748
7b5d6677
EZ
37492011-10-20 Eli Zaretskii <eliz@gnu.org>
3750
3751 * dispextern.h (struct bidi_it): New member next_en_type.
3752
3753 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3754 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3755 current character, check also for next_en_type being WEAK_EN.
3756 (bidi_resolve_weak): Don't enter the expensive loop if the current
3757 position is before next_en_pos. Record the bidi type of the first
3758 non-ET, non-BN character we find, in addition to its position.
3759 (bidi_level_of_next_char): Invalidate next_en_type when
3760 next_en_pos is over-stepped.
3761
7da0b018
PE
37622011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3763
3764 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3765 * editfns.c: Rewrite current-time-zone so that it invokes
3766 the equivalent of (format-time-string "%Z") to get the time zone name.
3767 This fixes a bug when the time zone name contains characters that
3768 need converting from the system time locale to Emacs internal format.
3769 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3770 that patch fixed format-time-string to do the conversion, but
3771 I forgot to fix current-time-zone.
3772 (format_time_string): New function, containing most of
3773 what Fformat_time_string used to contain.
3774 (Fformat_time_string): Rewrite in terms of format_time_string.
3775 This doesn't change this function's behavior.
3776 (current-time-zone): Rewrite to use format_time_string.
3777 This fixes the bug reported by Michael Schierl in
3778 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3779 Jason Rumney's 2007-06-07 change worked around this bug, but
3780 didn't fix it.
3781 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3782
8547b010
EZ
37832011-10-19 Eli Zaretskii <eliz@gnu.org>
3784
3785 * xdisp.c (start_display): If the character at POS is displayed
3786 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
3787 (try_window_reusing_current_matrix): If a line ends in a display
3788 vector or the next line starts in a display vector, continue
3789 redrawing the window even though the character position of
3790 start_row was reached.
8547b010
EZ
3791 (Bug#9771, part 2)
3792
4e948d15
CY
37932011-10-18 Chong Yidong <cyd@gnu.org>
3794
3795 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3796 with nobreak-char-display too.
3797
4787455f
EZ
37982011-10-18 Eli Zaretskii <eliz@gnu.org>
3799
3800 Fix part 3 of bug#9771.
3801 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3802 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3803 non-neutral characters if the current character is a paragraph
3804 separator (a.k.a. Newline). This avoids running the same
3805 expensive loop twice, once when we consume the preceding newline
3806 and the other time when the line actually needs to be displayed.
3807 Avoid the loop when we see neutrals on the base embedding level
3808 following a character whose directionality is the same as the
3809 paragraph's. This avoids running the expensive loop when a line
3810 ends in a long sequence of neutrals, like control characters.
3811 Add assertion against STRONG_AL type. Slightly rearrange code
3812 that determines the type of a neutral given the first non-neutral
3813 that follows it.
3814 (bidi_level_of_next_char): Set next_en_pos to zero when
3815 invalidating its info.
3816
2c91f553
EZ
38172011-10-17 Eli Zaretskii <eliz@gnu.org>
3818
3819 * xdisp.c (push_display_prop): Determine whether to record string
3820 or buffer position by IT->string, not by IT->method. Allow
3821 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
3822 (move_it_vertically_backward): Don't look for character position
3823 immediately after the newline when in a continuation line.
3824 (Bug#9771, part 1)
2c91f553 3825
c7b08b0d
MR
38262011-10-15 Martin Rudalics <rudalics@gmx.at>
3827
3828 * window.c (coordinates_in_window): Rewrite and delabelize
3829 vertical border check. (Bug#5357) (Bug#9618)
3830
6b02f655
SM
38312011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3832
3833 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3834 errors in XSetWindowBorder (bug#9310).
3835
81d40c92
DA
38362011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3837
3838 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3839 avoid crash when xmalloc overrun checking is enabled.
3840
d4172c3b
EZ
38412011-10-13 Eli Zaretskii <eliz@gnu.org>
3842
3843 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3844 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3845 cursor motion with <left> and <right> arrow keys.
3846
3847 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3848 some callers set that themselves.
3849
b00eea75
EZ
38502011-10-12 Eli Zaretskii <eliz@gnu.org>
3851
3852 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3853 display string and the previous row comes from the same string and
3854 is empty. (Bug#9739) (Bug#9738)
3855
8fe012c4
SM
38562011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3857
3858 * doc.c (get_doc_string): Encode file name (bug#9735).
3859
0074aef2
EZ
38602011-10-12 Eli Zaretskii <eliz@gnu.org>
3861
79beb178
EZ
3862 * bidi.c (bidi_level_of_next_char):
3863 * xdisp.c (get_visually_first_element): Remove old incorrect
3864 comments regarding the Unicode Line Separator character.
3865
0074aef2
EZ
3866 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3867
6e4b3fbe
DA
38682011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3869
3870 * alloc.c (Fgc_status): Do not access beyond zombies array
3871 boundary if nzombies > MAX_ZOMBIES.
3872 * alloc.c (dump_zombies): Add missing format specifier.
3873
0324f3af
PE
38742011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3875
b5525cac
PE
3876 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3877 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3878
0324f3af
PE
3879 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3880 Some packages use them to denote characters with modifiers.
3881
e9b5f888
AS
38822011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3883
3884 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3885 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3886 matching a pp-number. Rename parameter var to var1.
3887
127827c0
SM
38882011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3889
3890 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3891
c8fd3bd0
GM
38922011-10-08 Glenn Morris <rgm@gnu.org>
3893
3894 * callint.c (Fcall_interactively): Give a more explicit error for the
3895 'c' case with a non-character input. (Bug#8479)
3896
352ec8ff
EZ
38972011-10-08 Eli Zaretskii <eliz@gnu.org>
3898
03669ccb
EZ
3899 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3900 lines.
7061c986
EZ
3901 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3902 lines that are hscrolled on the left.
03669ccb 3903
352ec8ff
EZ
3904 * dispnew.c (buffer_posn_from_coords): Account for a possible
3905 presence of header-line. (Bug#4426)
3906
a66cfb1c
SM
39072011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3908
6b02f655
SM
3909 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3910 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 3911
7c5ee88e
PE
39122011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3913
3914 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3915 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3916 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3917 this makes Emacs dump core during garbage collection on rare
3918 occasions. sizeof is obviously inferior to offsetof here, so
3919 stick with offsetof.
3920 (GC_POINTER_ALIGNMENT): New macro.
3921 (mark_memory): Omit 3rd (offset) arg; caller changed.
3922 Don't assume EMACS_INT alignment is the same as pointer alignment.
3923
df1bbe5b
SM
39242011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3925
3926 * keyboard.c (read_key_sequence_remapped): New var.
3927 (read_key_sequence): Compute remapping in the right buffer.
3928 (command_loop_1): Use read_key_sequence's remapping directly.
3929
51553db6
SM
39302011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3931
32c1fffd
SM
3932 * dired.c (file_name_completion): Don't expand file name.
3933 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3934 before checking file name handler.
3935
51553db6
SM
3936 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3937 they've been requested explicitly (bug#9591).
3938
b6bd1599 39392011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
3940
3941 * keymap.c (Fsingle_key_description): Use make_specified_string
3942 instead of build_string to build string from push_key_description.
3943 (Bug#5193)
3944
f701dc2a
PE
39452011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3946
4222c55d
PE
3947 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3948 This fixes a Y2038 bug on 64-bit hosts.
3949 * buffer.c (reset_buffer):
3950 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3951 (Fclear_buffer_auto_save_failure):
3952 Use 0, not -1, to represent an unset failure time, since time_t
3953 might not be signed.
3954
f701dc2a
PE
3955 Remove dependency on glibc malloc internals.
3956 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3957 Move back here from lisp.h, but with their new implementations.
3958 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3959 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3960 * charset.c (charset_table_init): New static var.
3961 (syms_of_charset): Use it instead of xmalloc. This removes a
3962 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3963 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3964 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3965 Move back to alloc.c.
3966 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3967 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3968
9ceebf39
JD
39692011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3970
3971 * nsterm.m (windowDidResize): Call x_set_window_size only when
3972 ns_in_resize is true. Otherwise set pixelwidth/height and
3973 call change_frame_size (Bug#9628).
3974
cb993c58
PE
39752011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3976
3930c88b
PE
3977 Port --enable-checking=all to Fedora 14 x86-64.
3978 * charset.c (syms_of_charset): Also account for glibc malloc's
3979 internal overhead when calculating the initial malloc maximum.
3980
cb993c58
PE
3981 Port --enable-checking=all to Fedora 14 x86.
3982 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3983 Move to lisp.h.
3984 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3985 (overrun_check_realloc, overrun_check_free):
3986 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3987 That way, xmalloc returns a properly-aligned pointer even if
3988 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3989 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3990 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3991 into account when calculating the initial malloc maximum.
3992 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3993 Move here from alloc.c, so that charset.c can use it too.
3994 Properly align; the old code wasn't right for common 32-bit hosts
3995 when configured with --enable-checking=all.
3996 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3997 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3998
31bed486
EZ
39992011-09-29 Eli Zaretskii <eliz@gnu.org>
4000
04c70788 4001 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4002 use EDOM.
4003
fbcaa2f3
EZ
40042011-09-28 Eli Zaretskii <eliz@gnu.org>
4005
4006 * xdisp.c (compute_display_string_end): If there's no display
4007 string at CHARPOS, return -1.
4008
4009 * bidi.c (bidi_fetch_char): When compute_display_string_end
4010 returns a negative value, treat the character as a normal
4011 character not covered by a display string. (Bug#9624)
4012
a239d4e9
JB
40132011-09-28 Juanma Barranquero <lekktu@gmail.com>
4014
4015 * lread.c (Fread_from_string): Fix typo in docstring.
4016
88652fd5
EZ
40172011-09-27 Eli Zaretskii <eliz@gnu.org>
4018
4019 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4020 newline, reseat the iterator instead of bidi-iterating there one
4021 character at a time. (Bug#9610)
32c1fffd
SM
4022 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4023 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4024
ed497dd4
AS
40252011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4026
4027 * lread.c (readevalloop): Use correct code for NBSP.
4028 (read1): Likewise. (Bug#9608)
4029
b2bf61aa
MA
40302011-09-25 Michael Albinus <michael.albinus@gmx.de>
4031
4032 * dbusbind.c (Fdbus_register_signal): When service is not
4033 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4034
32bbb17c
GM
40352011-09-25 Glenn Morris <rgm@gnu.org>
4036
4037 * buffer.c (truncate-lines): Doc fix.
4038
94e0933e
CY
40392011-09-24 Chong Yidong <cyd@stupidchicken.com>
4040
4041 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4042 (Fset_window_next_buffers): Doc fix.
4043
cddde921
GM
40442011-09-24 Glenn Morris <rgm@gnu.org>
4045
4046 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4047
1260aef1
PE
40482011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4049
25b4bfa0
PE
4050 Fix minor problems found by static checking.
4051 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4052 * indent.c (Fvertical_motion): Fix == vs = typo.
4053
e3cbd34b
EZ
40542011-09-24 Eli Zaretskii <eliz@gnu.org>
4055
a66cfb1c
SM
4056 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4057 Default value is now t. Doc fix.
6bf7006f 4058
e3cbd34b 4059 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4060 logic when moving up, not only when moving down. Fix the
e3cbd34b 4061 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4062 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4063
4064 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4065 CHARPOS is covered by a display string which includes newlines.
4066 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4067 is covered by a display string with embedded newlines.
4068
a3de0cbd
MA
40692011-09-24 Michael Albinus <michael.albinus@gmx.de>
4070
4071 * dbusbind.c (Fdbus_register_signal): Add match rule to
4072 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4073 (Fdbus_register_method, Vdbus_registered_objects_table):
4074 Fix docstring.
a3de0cbd 4075
b260039d
JM
40762011-09-24 Jim Meyering <meyering@redhat.com>
4077
32c1fffd 4078 do not ignore write error for any output size
b260039d
JM
4079 The previous change was incomplete.
4080 While it makes emacs --batch detect the vast majority of stdout
4081 write failures, errors were still ignored whenever the output size is
4082 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4083 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4084 && echo FAIL: ignored write error
4085 FAIL: ignored write error
4086 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4087 && echo FAIL: ignored write error
4088 FAIL: ignored write error
4089 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4090
8eca8a7c
AS
40912011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4092
4093 * emacs.c (Fkill_emacs): In noninteractive mode exit
4094 non-successfully if a write error occurred on stdout. (Bug#9574)
4095
3341db62
EZ
40962011-09-21 Eli Zaretskii <eliz@gnu.org>
4097
4098 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4099 the xassert test.
4100
4101 * dispextern.h (struct it): Update the comment documenting what
4102 can it->OBJECT be.
4103
8c203dbf
EZ
41042011-09-20 Eli Zaretskii <eliz@gnu.org>
4105
4106 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4107 a display string, extend search for cursor position to end of row.
4108 (find_row_edges): If the row ends in a newline from a display
4109 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4110 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4111 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4112 non-empty line. Fixes confusing cursor motion with arrow keys at
4113 the beginning of a line that starts with whitespace.
8c203dbf 4114
a4824228
LMI
41152011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4116
4117 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4118 (bug#9493).
4119
33ed493b
CY
41202011-09-18 Chong Yidong <cyd@stupidchicken.com>
4121
4122 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4123 boolean (Bug#9154).
4124
56cd55c8
EZ
41252011-09-18 Eli Zaretskii <eliz@gnu.org>
4126
4127 * xdisp.c (display_line): Record maximum and minimum buffer
4128 positions even if no glyphs were produced (e.g., by a zero-width
4129 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4130 buffer positions that will be removed from the glyph row because
4131 they don't fit.
c02dcedf
EZ
4132 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4133 column is beyond frame width: don't subtract 1 "pixel" when
4134 computing width of the stretch.
3e62b7e0
EZ
4135 (reseat_at_next_visible_line_start): Undo the change made on
4136 2011-09-17 that saved paragraph information and restored it after
4137 the call to `reseat'. (Bug#9545)
56cd55c8 4138
5ed99d36 41392011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4140
4141 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4142 and turn window cursor on if cleared (Bug#9415).
4143
5ed99d36 41442011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4145
4146 * search.c (boyer_moore): Take unibyte characters from pattern
4147 literally. (Bug#9458)
4148
9bade7b2
EZ
41492011-09-18 Eli Zaretskii <eliz@gnu.org>
4150
4151 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4152
e5e9d610
PE
41532011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4154
87e4427a
PE
4155 Fix minor problem found by static checking.
4156 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4157 initialized, to pacify gcc -Wuninitialized.
4158
e5e9d610
PE
4159 * fileio.c: Report proper errno when syscall falls.
4160 (Finsert_file_contents): Save and restore errno,
4161 so that report_file_error outputs the correct diagnostic.
4162 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4163
a1674f0b
EZ
41642011-09-18 Eli Zaretskii <eliz@gnu.org>
4165
4166 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4167
fbfb6dd4
EZ
41682011-09-17 Eli Zaretskii <eliz@gnu.org>
4169
4170 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4171 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4172
bb187662
EZ
41732011-09-17 Eli Zaretskii <eliz@gnu.org>
4174
1137e8b8 4175 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4176 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4177
4178 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4179 (bidi_find_paragraph_start): Search back for paragraph beginning
4180 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4181 (bidi_move_to_visually_next): Only trigger paragraph-related
4182 computations when the last character is a newline or at EOB, not
4183 just any NEUTRAL_B. (Bug#9470)
4184
bb187662
EZ
4185 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4186 truncated lines if point is covered by a display string. (Bug#9524)
4187
2e621251
PE
41882011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4189
4190 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4191 (cons_to_x_long): New function.
4192 (lisp_data_to_selection_data): Use it. Correct the test for
4193 short-versus-long data; it was negated. Break out of vector
4194 loop, for efficiency, when a long datum is discovered.
4195
91a15bc6
SM
41962011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4197
4198 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4199
b41c3a35
EZ
42002011-09-16 Eli Zaretskii <eliz@gnu.org>
4201
4202 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4203 GCC PR/17406) by declaring this function with external scope.
4204
7812ba2d
PE
42052011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4206
4207 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4208 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4209
cf7edc2a
AS
42102011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4211
4212 * editfns.c (Fformat): Correctly handle text properties on "%%".
4213
bd01620e
EZ
42142011-09-15 Eli Zaretskii <eliz@gnu.org>
4215
4216 * xterm.c (x_draw_composite_glyph_string_foreground):
4217 * w32term.c (x_draw_composite_glyph_string_foreground):
4218 * term.c (encode_terminal_code):
4219 * composite.c (composition_update_it, get_composition_id):
4220 * xdisp.c (get_next_display_element)
4221 (fill_composite_glyph_string): Add comments about special meaning
4222 of TAB characters in a composition.
4223
a02719a3
PE
42242011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4225
4226 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4227 This occurs when processing a multibyte format.
4228 Problem reported by Wolfgang Jenker.
a02719a3 4229
72589a3c
JB
42302011-09-15 Johan Bockgård <bojohan@gnu.org>
4231
4232 * xdisp.c (try_cursor_movement): Only check for exact match if
4233 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4234
1c14176c
PE
42352011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4236
4237 Remove unused external symbols.
4238 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4239 * xdisp.c (calc_pixel_width_or_height): Now static.
4240 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4241 * indent.c (check_display_width):
4242 * w32term.c: Fix comment to match code.
4243 * xterm.c, xterm.h (x_catching_errors): Remove.
4244
d2eea5b5
PE
42452011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4246
4247 * xselect.c: Use signed conversions more consistently (Bug#9498).
4248 (selection_data_to_lisp_data): Assume incoming selection data are
4249 signed integers, not unsigned. This is to be consistent with
4250 outgoing selection data, which was modified to use signed integers
4251 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4252 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4253 expects long, not unsigned long.
4254
46888499
EZ
42552011-09-14 Eli Zaretskii <eliz@gnu.org>
4256
4257 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4258 computation of loop end. Reported by Johan Bockgård
4259 <bojohan@gnu.org>.
4260
ef8ef9fb
CY
42612011-09-13 Chong Yidong <cyd@stupidchicken.com>
4262
4263 * frame.c (Fother_visible_frames_p): Function deleted.
4264
fa819fed
EZ
42652011-09-12 Eli Zaretskii <eliz@gnu.org>
4266
4267 * indent.c (compute_motion): Process display vector front to back
4268 rather than the other way around. (Bug#2496)
4269
2ba8e008
SM
42702011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4271
4272 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4273
20f53c69
CY
42742011-09-11 Chong Yidong <cyd@stupidchicken.com>
4275
4276 * minibuf.c (Fread_from_minibuffer): Doc fix.
4277
d562d7a4
EZ
42782011-09-11 Eli Zaretskii <eliz@gnu.org>
4279
4280 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4281 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4282
1c4d7f3d
LMI
42832011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4284
4285 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4286 value for non-existent files.
4287
b885bf36
EZ
42882011-09-11 Eli Zaretskii <eliz@gnu.org>
4289
4290 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4291 set its "size" to -1. This will set the modtime_size field of
4292 the corresponding buffer to -1, which is what
4293 verify-visited-file-modtime expects for files that do not exist.
4294 (Bug#9139)
4295
6612f0bf
PE
42962011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4297
4298 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4299 here ...
4300 * lisp.h: ... from here. push_key_description is no longer
4301 defined in keyboard.c, so its declaration should not be in
4302 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4303 logically belongs with push_key_description.
4304
dfb3f755
PE
43052011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4306
4307 * buffer.h: Include <sys/types.h> instead of <time.h>.
4308 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4309 Problem reported by Herbert J. Skuhra.
4310
3134906c
LMI
43112011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4312
4313 * xml.c (parse_region): Make the parsing work for
4314 non-comment-starting XML files again (bug#9144).
4315
8d903f4e
AS
43162011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4317
4318 * image.c (gif_load): Fix calculation of bottom and right corner.
4319 (Bug#9468)
4320
80ad64f4
EZ
43212011-09-10 Eli Zaretskii <eliz@gnu.org>
4322
4323 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4324 redisplay in small windows.
4325
208a048d
EZ
43262011-09-09 Eli Zaretskii <eliz@gnu.org>
4327
4328 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4329
9b1c252e
MR
43302011-09-08 Martin Rudalics <rudalics@gmx.at>
4331
4332 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4333 Operate on live windows only.
4334
2949f33b
JB
43352011-09-08 Juanma Barranquero <lekktu@gmail.com>
4336
4337 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4338
e08dcafd
EZ
43392011-09-07 Eli Zaretskii <eliz@gnu.org>
4340
4341 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4342 only under bidi iteration.
4343
115b96bd
JD
43442011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4345
4346 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4347
c8199d0f
PE
43482011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4349
4350 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4351 Without this fix, the command to link temacs failed due to an
4352 undefined symbol __builtin_isnan. This is because
4353 /usr/include/iso/math_c99.h #defines isnan(x) to
4354 __builtin_isnan(x), but the bundled gcc, which identifies itself
4355 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4356 a __builtin_isnan.
4357 * floatfns.c (isnan): #undef, and then #define to a clone of
4358 what's in data.c.
4359 (Fisnan): Always define, since it's always available now.
4360 (syms_of_floatfns): Always define isnan at the Lisp level.
4361
e39b275c 43622011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4363
4364 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4365
b2db44d9 43662011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4367
f4af5137 4368 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4369 The previous code assumed that file offsets (off_t values) fit in
4370 EMACS_INT variables, which is not true on typical 32-bit hosts.
4371 The code messed up by falsely reporting buffer overflow in cases
4372 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4373 when "big" contains more than 2**29 bytes, even though this
4374 inserts just one byte and does not overflow the buffer.
4375 (Finsert_file_contents): Store file offsets as off_t
4376 values, not as EMACS_INT values. Check for overflow when
4377 converting between EMACS_INT and off_t. When checking for
4378 buffer overflow or for overlap, take the offsets into account.
4379 Don't use EMACS_INT for small values where int suffices.
4380 When checking for overlap, fix a typo: ZV was used where
4381 ZV_BYTE was intended.
4382 (Fwrite_region): Don't assume off_t fits into 'long'.
4383 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4384
ecfc0a49
MA
43852011-09-05 Michael Albinus <michael.albinus@gmx.de>
4386
4387 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4388
6511acf2 43892011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4390
0999621a 4391 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4392
4393 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4394 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4395 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4396 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4397 (modify_event_symbol): Do not assume that the length of
4398 name_alist_or_stem is safe to alloca and fits in int.
4399 (Fexecute_extended_command): Likewise for function name and binding.
4400 (Frecursion_depth): Wrap around reliably on integer overflow.
4401 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4402 since some callers pass EMACS_INT values.
4403 (Fsingle_key_description): Don't crash if symbol name contains more
4404 than MAX_ALLOCA bytes.
4405 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4406 (get_minibuffer): Arg is now EMACS_INT, not int.
4407 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4408 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4409 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4410
2be7d702
PE
4411 * dbusbind.c (signature_cat): New function.
4412 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4413 Do not overrun buffer; instead, report string overflow.
4414
9d1df220
PE
4415 * dispnew.c (add_window_display_history): Don't overrun buffer.
4416 Truncate instead; this is OK since it's just a log.
4417
33ef5c64
PE
4418 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4419 even if the time zone offset is outlandishly large.
4420 Don't mishandle offset == INT_MIN.
4421
66c6fdd5
PE
4422 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4423 when creating daemon; the previous buffer-overflow check was incorrect.
4424
d749b01b
PE
4425 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4426 which has the guts of the old verror function.
4427
b5cd1905
PE
4428 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4429 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4430
6e1a67fb
PE
4431 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4432 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4433 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4434 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4435 length of string rather than counting it via multiple sprintfs;
4436 that's simpler and more reliable.
c21721cc
PE
4437 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4438 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4439 sprintf, in case result does not fit in int.
4440
c57b67fc
PE
4441 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4442 (fontset_from_font): Print it.
4443
8a401434
PE
4444 * frame.c (tty_frame_count): Now printmax_t, not int.
4445 (make_terminal_frame, set_term_frame_name): Print it.
4446 (x_report_frame_params): In X, window IDs are unsigned long,
4447 not signed long, so print them as unsigned.
4448 (validate_x_resource_name): Check for implausibly long names,
4449 and don't assume name length fits in 'int'.
4450 (x_get_resource_string): Don't blindly alloca invocation name;
4451 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4452 not fit in int.
4453
6e1a67fb
PE
4454 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4455 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4456 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4457
0df02bf3
PE
4458 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4459 Use esprintf, not sprintf, in case result does not fit in int.
4460
48e30793
PE
4461 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4462 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4463 it as a large positive number.
4464 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4465 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4466
a66ff6d8
PE
4467 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4468 in case result does not fit in int.
4469
aca216ff
PE
4470 * print.c (float_to_string): Detect width overflow more reliably.
4471 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4472 buffer overrun. Don't assume list length fits in 'int'. Treat
4473 print length of 0 as 0, not as infinity; to be consistent with other
4474 uses of print length in this function. Don't overflow print length
4475 index. Don't assume hash table size fits in 'long', or that
4476 vectorlike size fits in 'unsigned long'.
4477
31c286f7
PE
4478 * process.c (make_process): Use printmax_t, not int, to format
4479 process-name gensyms.
4480
55e5faa1
PE
4481 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4482
80f2e268
PE
4483 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4484 to avoid potential buffer overrun.
4485
670741ab
PE
4486 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4487 if X resource line is longer than 512 bytes.
4488
b7163a50
PE
4489 * xfns.c (x_window): Make sprintf buffer a bit bigger
4490 to avoid potential buffer overrun.
4491
ae58ff1f
PE
4492 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4493
c43c8a6a
PE
4494 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4495
3f8236f4
PE
44962011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4497
53e9fe90 4498 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4499 Without these, Emacs silently mishandles large integers sometimes.
4500 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4501 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4502
6511acf2
PE
4503 * xdisp.c (try_window_id): Check Emacs fixnum range before
4504 converting to 'int'.
806add1d 4505
6511acf2 4506 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4507 Check that an Emacs fixnum is in range before assigning it to 'int'.
4508 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4509 values converted from Emacs fixnums.
4510 (Frecenter): Don't wrap around a line count if it is out of 'int'
4511 range; instead, treat it as an extreme value.
4512 (Fset_window_configuration, compare_window_configurations):
4513 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4514
6511acf2
PE
4515 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4516 that can exceed INT_MAX. Check that EMACS_INT value is in range
4517 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4518 (match_limit): Don't assume that a fixnum can fit in 'int'.
4519
6511acf2 4520 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4521 exceed INT_MAX.
4522
6511acf2 4523 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4524 (Fvertical_motion): Don't wrap around LINES values that don't fit
4525 in 'int'. Instead, treat them as extreme values. This is good
4526 enough for windows, which can't have more than INT_MAX lines anyway.
4527
fcb901a7
LMI
45282011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4529
0f2f6b6d
LMI
4530 * Require libxml/parser.h to avoid compilation warning.
4531
fcb901a7
LMI
4532 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4533
4534 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4535 since this reportedly can destroy thread storage.
4536
6e20a0d4
CY
45372011-08-30 Chong Yidong <cyd@stupidchicken.com>
4538
4539 * syntax.c (find_defun_start): Update all cache variables if
4540 exiting early (Bug#9401).
4541
148ae00e
EZ
45422011-08-30 Eli Zaretskii <eliz@gnu.org>
4543
f6cfbd8f
EZ
4544 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4545
148ae00e
EZ
4546 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4547 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4548 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4549
4550 * term.c (tty_append_glyph): New function.
4551 (produce_stretch_glyph): Static function and its prototype deleted.
4552
a66cfb1c
SM
4553 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4554 Add prototypes.
148ae00e 4555
c4a07a4c
PE
45562011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4557
4558 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4559 when checking :margin (Bug#9390).
4560 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 4561 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
4562 so that the name doesn't mislead. All uses changed.
4563
6bc8cd65
JB
45642011-08-28 Johan Bockgård <bojohan@gnu.org>
4565
4566 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4567 set_tty_hooks.
4568
dca4927e
EZ
45692011-08-27 Eli Zaretskii <eliz@gnu.org>
4570
4571 * xdisp.c (move_it_to): Don't bail out early when reaching
4572 position beyond to_charpos, if we are scanning backwards.
4573 (move_it_vertically_backward): When DY == 0, make sure we get to
4574 the first character in the line after the newline.
4575
f2cad773
PE
45762011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4577
4578 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4579 (ccl_driver): Do not generate an out-of-range pointer.
4580 (Fccl_execute_on_string): Remove unnecessary check for
4581 integer overflow, noted by Stefan Monnier in
4582 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4583 Remove a FIXME that didn't need fixing.
4584 Simplify the newly-introduced buffer reallocation code.
4585
0cae2cdb
JB
45862011-08-27 Juanma Barranquero <lekktu@gmail.com>
4587
4588 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4589
5fc295a4 45902011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 4591
70c60eb2 4592 Integer and memory overflow issues (Bug#9196).
726e0ab1 4593
d31850da
PE
4594 * doc.c (get_doc_string): Rework so that
4595 get_doc_string_buffer_size is the actual buffer size, rather than
4596 being 1 less than the actual buffer size; this makes xpalloc more
4597 convenient.
4598
a69fbedb
PE
4599 * image.c (x_allocate_bitmap_record, cache_image):
4600 * xselect.c (Fx_register_dnd_atom):
4601 Simplify previous changes by using xpalloc.
4602
fe5c5d37
PE
4603 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4604 since either will do and ptrdiff_t is convenient with xpalloc.
4605
0065d054
PE
4606 * charset.c (charset_table_size)
4607 (struct charset_sort_data.priority): Now ptrdiff_t.
4608 (charset_compare): Don't overflow if priorities differ greatly.
4609 (Fsort_charsets): Don't assume list length fits in int.
4610 Check for size-calculation overflow when allocating sort data.
4611 (syms_of_charset): Allocate an initial charset table that is
4612 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4613
4614 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4615
4616 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4617 The actual value is always <= INT_MAX, and leaving it unsigned made
4618 overflow checking harder.
4619
4620 * dispextern.h (struct glyph_matrix.rows_allocated)
4621 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4622 with xpalloc. The values are still always <= INT_MAX.
4623
4624 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4625
4626 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4627 (SAFE_NALLOCA): New macro.
4628
4629 * region-cache.c (struct boundary.pos, find_cache_boundary)
4630 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4631 (set_cache_region, invalidate_region_cache)
4632 (revalidate_region_cache, know_region_cache, region_cache_forward)
4633 (region_cache_backward, pp_cache):
4634 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4635 so that ptrdiff_t * can be passed to xpalloc.
4636 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4637 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4638 (pp_cache): Don't assume cache_len fits in int.
4639 * region-cache.h: Adjust extern decls to match.
4640
4641 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4642 EMACS_INT, since either will do, for xpalloc.
4643
4644 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4645 (xnmalloc, xnrealloc, xpalloc): New functions.
4646
726e0ab1
PE
4647 * bidi.c (bidi_shelve_header_size): New constant.
4648 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4649 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4650
51f30bc5 4651 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
4652 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4653 (overlay_strings):
4654 Don't update size of array until after memory allocation succeeds,
4655 because xmalloc/xrealloc may not return.
0065d054
PE
4656 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4657 now that we have proper integer overflow checking.
4658 (record_overlay_string, overlay_strings): Catch overflows when
4659 calculating size of overlay_str_buf.
726e0ab1 4660
0065d054
PE
4661 * callproc.c (Fcall_process): Check for size overflow when
4662 calculating size of args2.
4663 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4664 Normally we prefer signed values, but sticking with ptrdiff_t would
4665 require adding more-complicated checks.
726e0ab1
PE
4666
4667 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4668 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4669 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 4670 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
4671
4672 * character.c (Fstring): Check for size-calculation overflow.
4673
4674 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4675 unnecessary integer overflow. Check for size overflow.
4676 (encode_coding_object): Don't update size until xmalloc succeeds.
4677
4678 * composite.c (get_composition_id): Check for overflow in glyph
4679 length calculations.
4680
4681 Integer and memory overflow fixes for display code.
4682 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4683 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4684 (scrolling_window): Check for overflow in size calculations.
4685 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4686 Don't assume glyph table len fits in int.
4687 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4688 (row_table_size): Now ptrdiff_t, not int.
4689 (scrolling_window): Avoid overflow in size calculations.
4690 Don't update size until allocation succeeds.
4691 * fns.c (concat): Check for overflow in size calculations.
4692 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4693 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4694 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4695
4696 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4697 (get_doc_string): Check for size calculation overflow.
4698 Don't update size until allocation succeeds.
4699 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4700 EMACS_INT, where ptrdiff_t will do.
4701 (Fsubstitute_command_keys): Check for string overflow.
4702
4703 * editfns.c (set_time_zone_rule): Don't assume environment length
4704 fits in int.
4705 (message_length): Now ptrdiff_t, not int.
4706 (Fmessage_box): Don't update size until allocation succeeds.
4707 Don't assume message length fits in int.
4708 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4709
0065d054
PE
4710 * emacs.c (main): Do not reallocate argv, since there is a null at
4711 the end that can be overwritten, and this way there's no need to
4712 worry about size-calculation overflow.
4713 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
4714
4715 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4716 alloc succeeds.
4717 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4718
4719 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4720 (x_set_scroll_bar_width, x_figure_window_size):
4721 Check for integer overflow.
4722 (x_set_alpha): Do not assume XINT fits in int.
4723
4724 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4725 This is for the members text_lines, text_cols, total_lines, total_cols,
4726 where the system imposes an 'int' limit.
4727
4728 * fringe.c (Fdefine_fringe_bitmap):
4729 Don't update size until alloc works.
4730
4731 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4732 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4733
4734 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4735 Check for size-calculation overflow.
4736 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4737 do, as we prefer signed integers.
4738 (id_to_widget.max_size, id_to_widget.used)
4739 (xg_store_widget_in_map, xg_remove_widget_from_map)
4740 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4741 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4742 Use and return ptrdiff_t, not int.
4743 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4744 * gtkutil.h: Change prototypes to match the above.
4745
4746 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4747 are duplicate now that they've been promoted to lisp.h.
4748 (x_allocate_bitmap_record, x_alloc_image_color)
4749 (make_image_cache, cache_image, xpm_load):
4750 Don't update size until alloc is done.
4751 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4752 (x_detect_edges):
3256efce 4753 Check for size calculation overflow.
726e0ab1
PE
4754 (ct_colors_allocated_max): New constant.
4755 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4756 overflow.
3256efce 4757
726e0ab1
PE
4758 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4759 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4760 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4761 Use ptrdiff_t, not int, to count maps.
4762 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
4763 calculations. Don't update size until allocation succeeds.
4764 Redo calculations to avoid overflow.
726e0ab1
PE
4765 * keyboard.h: Change prototypes to match the above.
4766
4767 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4768 to count maps.
4769 (current_minor_maps): Check for size calculation overflow.
4770 * keymap.h: Change prototypes to match the above.
4771
4772 * lread.c (read1, init_obarray): Don't update size until alloc done.
4773
4774 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4775 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4776
726e0ab1
PE
4777 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4778 Now ptrdiff_t, not int.
4779 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4780 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4781
4782 * process.c (Fnetwork_interface_list): Check for overflow
4783 in size calculation.
4784
4785 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4786
4787 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4788 overflow. Don't bother calling xmalloc when xrealloc will do.
4789
4790 * search.c (Freplace_match): Check for size calculation overflow.
4791 (Fset_match_data): Don't assume list lengths fit in 'int'.
4792
4793 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4794 for command line length. Do not attempt to address one before the
4795 beginning of an array, as that's not portable.
4796
4797 * term.c (max_frame_lines): Remove; unused.
4798 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4799 not int.
4800 (encode_terminal_code, calculate_costs): Check for size
4801 calculation overflow.
4802 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4803 table lengths and related sizes. Don't update size until alloc
4804 done. Redo calculations to avoid overflow.
4805 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4806
4807 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4808 subtracting pointers.
4809 (gobble_line): Check for overflow more carefully. Don't update size
4810 until alloc done.
4811
4812 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4813 Don't update size until alloc done.
4814 Redo size calculations to avoid overflow.
4815 Check for size calculation overflow.
0065d054 4816 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
4817
4818 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4819 Use ptrdiff_t, not int, for sizes.
4820 (store_mode_line_noprop_char): Don't update size until alloc done.
4821
0065d054
PE
4822 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4823 Use ptrdiff_t, not int, for sizes.
4824 (Finternal_make_lisp_face, cache_face):
4825 Check for size calculation overflow.
4826 (cache_face): Treat size calculation overflows as if they were
4827 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
4828
4829 * xfns.c (x_encode_text, x_set_name_internal)
4830 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4831 sizes, since they can exceed INT_MAX in size. Check for size
4832 calculation overflow.
4833
0065d054
PE
4834 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4835 (xg_select): Check for size calculation overflow.
726e0ab1
PE
4836 Don't update size until alloc done.
4837
0065d054 4838 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 4839 as sprintf is limited to int lengths.
1d526e2f 4840
252c5ee1
PE
4841 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4842 (X_LONG_MIN): New macros.
864d7ce7
PE
4843 Use them to make the following changes clearer.
4844 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4845 This change doesn't affect the value now, but it may help remind
4846 future maintainers not to raise the value too much later.
4847 (SELECTION_QUANTUM): Remove, replacing with ...
4848 (selection_quantum): ... new function, which avoids overflow.
4849 All uses changed.
4850 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4851 assumption that selection length fits in 'int'.
4852 (x_reply_selection_request, x_handle_selection_request)
4853 (x_get_window_property, receive_incremental_selection)
4854 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4855 (lisp_data_to_selection_data, clean_local_selection_data):
4856 Use ptrdiff_t, not int, to record length of selection.
4857 (x_reply_selection_request, x_get_window_property)
4858 (receive_incremental_selection, x_property_data_to_lisp):
4859 Redo calculations to avoid overflow.
4860 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 4861 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
4862 something.
4863 (x_get_window_property, receive_incremental_selection)
4864 (lisp_data_to_selection_data, x_property_data_to_lisp):
4865 Check for size-calculation overflow.
4866 (x_get_window_property, receive_incremental_selection)
4867 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4868 Don't store size until memory allocation succeeds.
4869 (x_get_window_property): Plug memory leak on memory exhaustion.
4870 Don't double-block input; malloc is safe here. Don't assume 2**34
4871 - 4 fits in unsigned long. Add an xassert to check
4872 XGetWindowProperty overflow. Be more careful about overflow
4873 calculations, and distinguish size from memory overflow better.
4874 (receive_incremental_selection): When tracing, don't assume
4875 unsigned int is less than INT_MAX.
4876 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4877 harmful) conversions of unsigned short to int.
4878 (lisp_data_to_selection_data): Don't assume that integers
4879 in the range -65535 through -1 fit in an X unsigned short.
4880 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4881 result parameters unless successful. Rely on cons_to_unsigned
4882 to report problems with elements; the old code wasn't right anyway.
4883 (x_check_property_data): Check for int overflow; we cannot use
4884 a wider type due to X limits.
4885 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4886
726e0ab1 4887 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 4888
0065d054
PE
4889 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4890 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
4891 (x_color_cells): Don't store size until memory allocation succeeds.
4892 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 4893 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
4894 (x_term_init): Don't assume length fits in int (sprintf is limited
4895 to int size).
bc18e09d 4896
ebfa62c0
PE
4897 Use ptrdiff_t for composition IDs.
4898 * character.c (lisp_string_width):
4899 * composite.c (composition_table_size, n_compositions)
4900 (get_composition_id, composition_gstring_from_id):
4901 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4902 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4903 * window.c (Frecenter):
4904 Use ptrdiff_t, not int, for composition IDs.
4905 * composite.c (get_composition_id): Check for integer overflow.
4906 * composite.h: Adjust prototypes to match the above changes.
4907
d3411f89
PE
4908 Use ptrdiff_t for hash table indexes.
4909 * category.c (hash_get_category_set):
4910 * ccl.c (ccl_driver):
4911 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4912 * coding.c (coding_system_charset_list, detect_coding_system):
4913 * coding.h (struct coding_system.id):
4914 * composite.c (get_composition_id, gstring_lookup_cache):
4915 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4916 * image.c (xpm_get_color_table_h):
4917 * lisp.h (hash_lookup, hash_put):
4918 * minibuf.c (Ftest_completion):
4919 Use ptrdiff_t for hash table indexes, not int (which is too
4920 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4921 32-bit --with-wide-int hosts).
4922
e097a6fa
PE
4923 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4924 Add a FIXME comment about memory leaks.
4925 (syms_of_charset): Don't assume xmalloc returns.
4926
5637687f
PE
4927 Don't assume that stated character widths fit in int.
4928 * character.c (Fchar_width, c_string_width, lisp_string_width):
4929 * character.h (CHAR_WIDTH):
4930 * indent.c (MULTIBYTE_BYTES_WIDTH):
4931 Use sanitize_char_width to avoid undefined and/or bad behavior
4932 with outlandish widths.
a66cfb1c 4933 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
4934 now that we have two such functions. All uses changed.
4935 (sanitize_char_width): New inline function.
4936
a2271ba2
PE
4937 Don't assume that tab-width fits in int.
4938 * character.h (sanitize_width): New inline function.
4939 (SANE_TAB_WIDTH): New macro.
4940 (ASCII_CHAR_WIDTH): Use it.
4941 * indent.c (sane_tab_width): Remove. All uses replaced by
4942 SANE_TAB_WIDTH (current_buffer).
4943 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4944
18c52557
PE
4945 * fileio.c: Integer overflow issues with file modes.
4946 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4947
caeeedc1
PE
4948 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4949 Remove unreachable code.
4950 (read_hex, load_charset_map_from_file): Check for integer overflow.
4951
6df6ae42 4952 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
4953 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4954 (x_send_scroll_bar_event): Likewise. Check that the size does not
4955 exceed limits imposed by XClientMessageEvent, as well as the usual
4956 ptrdiff_t and size_t limits.
4957
b13995db
PE
4958 * keyboard.c: Overflow, signedness and related fixes.
4959 (make_lispy_movement): Use same integer type in forward decl
4960 that is used in the definition.
4961 (read_key_sequence, keyremap_step):
4962 Change bufsize argument back to int, undoing my 2011-03-30 change.
4963 We prefer signed types, and int is wide enough here.
4964 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4965 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4966 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4967 length, not size_t. Use ptrdiff_t for index, not int.
4968 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4969 possibility of integer overflow.
4970
13464394
PE
4971 Overflow, signedness and related fixes for images.
4972
4973 * dispextern.h (struct it.stack[0].u.image.image_id)
4974 (struct_it.image_id, struct image.id, struct image_cache.size)
4975 (struct image_cache.used, struct image_cache.ref_count):
4976 * gtkutil.c (update_frame_tool_bar):
4977 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4978 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4979 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4980 * nsmenu.m (update_frame_tool_bar):
4981 * xdisp.c (calc_pixel_width_or_height):
4982 * xfns.c (image_cache_refcount):
4983 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4984 on typical 64-bit hosts.
4985
4986 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4987 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4988 Omit unnecessary casts to int.
4989 (parse_image_spec): Check that integers fall into 'int' range
4990 when the callers expect that.
4991 (image_ascent): Redo ascent calculation to avoid int overflow.
4992 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4993 (lookup_image): Remove unnecessary tests.
4994 (xbm_image_p): Locals are now of int, not EMACS_INT,
4995 since parse_image_check makes sure they fit into int.
4996 (png_load, gif_load, svg_load_image):
4997 Prefer int to unsigned where either will do.
4998 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
4999 old tiff_error_handler and tiff_warning_handler.
5000 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5001 stack buffer overflows. It uses only the features of vsnprintf
5002 that are common to both POSIX and native Microsoft.
5003 (tiff_error_handler, tiff_warning_handler): Use it.
5004 (tiff_load, gif_load, imagemagick_load_image):
5005 Don't assume :index value fits in 'int'.
5006 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5007 (imagemagick_load_image): Check that crop parameters fit into
5008 the integer types that MagickCropImage accepts. Don't assume
5009 Vimagemagick_render_type has a nonnegative value. Don't assume
5010 size_t fits in 'long'.
5011 (gs_load): Use printmax_t to print the widest integers possible.
5012 Check for integer overflow when computing image height and width.
5013
c11821d4
EZ
50142011-08-26 Eli Zaretskii <eliz@gnu.org>
5015
5016 * xdisp.c (redisplay_window): Don't force window start if point
5017 will be invisible in the resulting window. (Bug#9324)
5018
0c95fcf7
EZ
50192011-08-25 Eli Zaretskii <eliz@gnu.org>
5020
5021 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5022 the display spec is of the form `(space ...)'.
5023 (handle_display_spec): Return the value returned by
5024 handle_single_display_spec, not just 1 or zero.
5025 (handle_single_display_spec): If the display spec is of the form
5026 `(space ...)', and specifies display in the text area, return 2
5027 rather than 1.
fee65a97 5028 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5029 accurately, and prefer exact match for point under bidi.
5030 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5031
5032 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5033 into disp_prop; all users changed.
5034
5035 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5036 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5037 for the text covered by the display property.
5038
e4ed06f1
CY
50392011-08-25 Chong Yidong <cyd@stupidchicken.com>
5040
5041 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5042 Change return value to nil.
5043 (Frecord_buffer): Delete unused function.
5044
f67cdd7f
EZ
50452011-08-24 Eli Zaretskii <eliz@gnu.org>
5046
5980d4c6
EZ
5047 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5048 buffers, return left-to-right.
8610fe8b
EZ
5049 (set_cursor_from_row): Consider candidate row a win if its glyph
5050 represents a newline and point is on that newline. Fixes cursor
5051 positioning on the newline at EOL of R2L text within L2R
5052 paragraph, and vice versa.
5053 (try_cursor_movement): Check continued rows, in addition to
5054 continuation rows. Fixes unwarranted scroll when point enters a
5055 continued line of R2L text within an L2R paragraph, or vice versa.
5056 (cursor_row_p): Consider the case of point being equal to
5057 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5058 from the end of a short line to the beginning of a continued line
5059 of R2L text within L2R paragraph.
5060 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5061 composed characters.
5980d4c6 5062
f67cdd7f
EZ
5063 * bidi.c (bidi_check_type): Use xassert.
5064 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5065 members.
5066
bca633fb
EZ
50672011-08-23 Eli Zaretskii <eliz@gnu.org>
5068
5069 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5070 a character.
5071
4a5885a7
CY
50722011-08-23 Chong Yidong <cyd@stupidchicken.com>
5073
5074 * nsfont.m (ns_otf_to_script): Fix typo.
5075
0902a04e
KH
50762011-08-22 Kenichi Handa <handa@m17n.org>
5077
5078 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5079 extra slot even if the purpose is char-code-property-table.
5080
1a2e6670
EZ
50812011-08-23 Eli Zaretskii <eliz@gnu.org>
5082
8ddde651
EZ
5083 * xdisp.c (redisplay_window): When computing centering_position,
5084 account for the height of the header line. (Bug#8874)
5085
425cc014
EZ
5086 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5087 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5088 candidate is selected by the mouse, and that candidate has a
5089 composed character under the mouse.
5090
1a2e6670
EZ
5091 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5092 coordinates reported by pos-visible-in-window-p for a composed
5093 character in column zero.
5094
8b76d6f8
SM
50952011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5096
5097 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5098
dac347dd
EZ
50992011-08-22 Eli Zaretskii <eliz@gnu.org>
5100
5101 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5102 consider it a hit if to_charpos is anywhere in the range of the
5103 composed buffer positions.
5104
e013fb34
CY
51052011-08-22 Chong Yidong <cyd@stupidchicken.com>
5106
5107 * image.c (gif_load): Don't assume that each subimage has the same
5108 dimensions as the base image. Handle disposal method that is
5109 "undefined" by the gif spec (Bug#9335).
5110
bd1ba3e8
CY
51112011-08-20 Chong Yidong <cyd@stupidchicken.com>
5112
5113 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5114 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5115
54a1215b
EZ
51162011-08-19 Eli Zaretskii <eliz@gnu.org>
5117
823564e5
EZ
5118 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5119 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5120 from an Org mode buffer to a Speedbar frame.
5121
54a1215b
EZ
5122 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5123 a composition, take its buffer position from IT->cmp_it.charpos.
5124 Fixes cursor positioning at the beginning of a line that begins
5125 with a composed character.
5126
9778ebcc
EZ
51272011-08-18 Eli Zaretskii <eliz@gnu.org>
5128
0be6ee06
EZ
5129 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5130 character bidirectional type, use STRONG_L instead. Fixes crashes
5131 in a buffer produced by `describe-categories'.
5132
9778ebcc
EZ
5133 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5134 members before the level stack, so they would be saved and
5135 restored when copying iterator state. Fixes incorrect reordering
5136 around TABs covered by display properties.
5137
156bffbe
AS
51382011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5139
6b02f655 5140 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5141
72ad093b
CY
51422011-08-17 Chong Yidong <cyd@stupidchicken.com>
5143
5144 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5145 (internal_condition_case_2, internal_condition_case_n):
5146 Remove unnecessary aborts (Bug#9081).
72ad093b 5147
35774242
EZ
51482011-08-17 Eli Zaretskii <eliz@gnu.org>
5149
5150 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5151 has no `load' handler, try opening the file locally. (Bug#9311)
5152
db76dd85
KB
51532011-08-16 Ken Brown <kbrown@cornell.edu>
5154
5155 * gmalloc.c: Expand comment.
5156
b215eee5
EZ
51572011-08-16 Eli Zaretskii <eliz@gnu.org>
5158
5159 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5160 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5161
a4579d33
KB
51622011-08-16 Ken Brown <kbrown@cornell.edu>
5163
5164 Fix memory allocation problems in Cygwin build (Bug#9273).
5165
5166 * unexcw.c ( __malloc_initialized): Declare external variable.
5167 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5168
8b76d6f8
SM
5169 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5170 New variables.
a4579d33
KB
5171 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5172 dumped emacs.
5173 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5174 in the static heap.
5175 [CYGWIN] (special_realloc): New function.
5176 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5177 requests to realloc storage in the static heap.
5178
3ebec551
PE
51792011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5180
5181 * bidi.c (bidi_initialize): Remove unused local.
5182
9fd8be00
EZ
51832011-08-15 Eli Zaretskii <eliz@gnu.org>
5184
6b02f655
SM
5185 * bidimirror.h:
5186 * biditype.h: Remove file.
5187 * makefile.w32-in ($(BLD)/bidi.$(O)):
5188 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5189
5190 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5191
5192 * chartab.c: Improve commentary for the uniprop_table API.
5193
32413314
EZ
5194 * bidi.c (bidi_paragraph_init): Support zero value of
5195 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5196 (bidi_initialize): Use uniprop_table instead of including
5197 biditype.h and bidimirror.h.
32413314 5198
9fd8be00
EZ
5199 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5200 coordinates of the iterator when restoring from ppos_it.
5201 (Bug#9296)
5202
5cf2b69b
KH
52032011-08-14 Kenichi Handa <handa@m17n.org>
5204
5205 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5206 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5207
daf17d00
EZ
52082011-08-14 Eli Zaretskii <eliz@gnu.org>
5209
5210 * xdisp.c (move_it_in_display_line_to): Don't invoke
5211 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5212 ppos_it. Fixes vertical cursor motion when line beginning is
5213 covered by an image. (Bug#9296)
5214
08e3161a
JD
52152011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5216
5217 * nsterm.h (ns_run_ascript): Declare.
5218 (NSAPP_DATA2_RUNASSCRIPT): Define.
5219
5220 * nsfns.m (as_script, as_result, as_status): New static variables.
5221 (ns_run_ascript): New function.
5e617bc2 5222 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5223 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5224 the event loop. Get status from as_status (Bug#7276).
5225
5226 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5227 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5228 the event loop (Bug#7276).
5229
a3720aa2
AS
52302011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5231
5232 * gnutls.c (QCgnutls_bootprop_priority)
5233 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5234 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5235 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5236 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5237 (QCgnutls_bootprop_verify_hostname_error)
5238 (QCgnutls_bootprop_callbacks_verify): Rename from
5239 Qgnutls_bootprop_..., all uses changed.
5240
5241 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5242 uses changed.
5243
0a0d27fb
PE
52442011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5245
19d5c50c
PE
5246 * xfaces.c (Qframe_set_background_mode): Now static.
5247 * dispextern.h (Qframe_set_background_mode): Remove decl.
5248
0a0d27fb
PE
5249 * process.c (Fnetwork_interface_info): Declare local only if needed.
5250
377538cb
JD
52512011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5252
5253 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5254 (Fnetwork_interface_list): Allocate in increments of bytes instead
5255 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5256 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5257 sockaddr.
5258 (struct ifflag_def): notrailers is smart on OSX.
5259 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5260 Get hardware address with getifaddrs if available.
5261
08fff70c
EZ
52622011-08-12 Eli Zaretskii <eliz@gnu.org>
5263
5264 * xdisp.c (iterate_out_of_display_property): xassert that
5265 IT->position is set to within IT->object's boundaries. Break from
5266 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5267 when IT->position is set up wrongly due to some bug.
5268 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5269 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5270 entry. Force push_it to save on the stack the current
5271 buffer/string position, to be restored by pop_it. Fix flags in
5272 the iterator structure wrt the object coming from a display
5273 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5274 properties. (Bug#9284)
5275
7be1c708 52762011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5277
7be1c708
CY
5278 * fontset.c (fontset_get_font_group): Add proper type checks.
5279 (Bug#9172)
aac0c6e3 5280
7be1c708 52812011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5282
7be1c708
CY
5283 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5284 and LC_VERSION_MIN_MACOSX.
5285 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5286 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5287
97bb72a6
EZ
52882011-08-08 Eli Zaretskii <eliz@gnu.org>
5289
5290 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5291 no-display-properties-and-no-overlays under bidi display.
5292 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5293 properties and overlays.
97bb72a6 5294
d5617611
CY
52952011-08-08 Chong Yidong <cyd@stupidchicken.com>
5296
37e11a63
CY
5297 * editfns.c (Fset_time_zone_rule): Document relationship with the
5298 setenv function.
5299
d5617611
CY
5300 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5301 the font entity extracted from the cache (Bug#8109).
5302
58872834
CY
53032011-08-07 Chong Yidong <cyd@stupidchicken.com>
5304
5305 * composite.c (autocmp_chars): Don't reset point. That is done by
5306 restore_point_unwind (Bug#5984).
5307
75bfc667
JL
53082011-08-07 Juri Linkov <juri@jurta.org>
5309
5310 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5311 to show the arg `TIME' instead of `TIMEVAL'.
5312
d1410150
EZ
53132011-08-06 Eli Zaretskii <eliz@gnu.org>
5314
5315 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5316 display property strides EOL and includes a newline, as in
5317 longlines-mode. (Bug#9254)
75b771e4
EZ
5318 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5319 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5320
5321 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5322 is non-zero, even if the data buffer is NULL. Fixes a crash in
5323 vertical-motion with longlines-mode. (Bug#9254)
5324
35928349
EZ
53252011-08-05 Eli Zaretskii <eliz@gnu.org>
5326
ec7cc85b
EZ
5327 * bidi.c <bidi_cache_total_alloc>: Now static.
5328 (bidi_initialize): Initialize bidi_cache_total_alloc.
5329
8b76d6f8 5330 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5331 cache. (Bug#9221)
5332
5333 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5334 amount allocated this far in `bidi_cache_total_alloc'.
5335 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5336 non-zero, only free the data buffer without restoring the cache
5337 contents. All callers changed.
5338
5339 * dispextern.h (bidi_unshelve_cache): Update prototype.
5340
5341 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5342 (move_it_in_display_line, move_it_to)
5343 (move_it_vertically_backward, move_it_by_lines): Replace the call
5344 to xfree to an equivalent call to bidi_unshelve_cache.
5345 (move_it_in_display_line_to): Fix logic of returning
412b6358 5346 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5347
e2e2423b
EZ
53482011-08-05 Eli Zaretskii <eliz@gnu.org>
5349
5350 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5351 came from a string character with a `cursor' property. (Bug#9229)
5352
ae9e757a
JD
53532011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5354
5355 * Makefile.in (LIB_PTHREAD): New variable.
5356 (LIBES): Add LIB_PTHREAD (Bug#9216).
5357
5358 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5359 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5360
213bd7f2
AS
53612011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5362
6b02f655 5363 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5364
99aaf75f
JD
53652011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5366
5367 * xterm.c (x_find_topmost_parent): New function.
5368 (x_set_frame_alpha): Find topmost parent window with
5369 x_find_topmost_parent and set the property there also (bug#9181).
5370 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5371
c74e9d86
PE
53722011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5373
5374 * callproc.c (Fcall_process): Avoid vfork clobbering
5375 the local vars buffer, coding_systems, current_dir.
5376
640c8776
SM
53772011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5378
5379 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5380
f26d0e4c
PE
53812011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5382
8a10d76c
PE
5383 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5384 so that it is not optimized away.
5385
f26d0e4c
PE
5386 * xdisp.c (compute_display_string_pos): Remove unused local.
5387
55439c61
EZ
53882011-08-02 Eli Zaretskii <eliz@gnu.org>
5389
5390 Fix slow cursor motion and scrolling in large buffers with
5391 selective display, like Org Mode buffers. (Bug#9218)
5392
5393 * dispextern.h (struct bidi_it): New member disp_prop_p.
5394
5395 * xdisp.c: Remove one-slot cache of display string positions.
5396 (compute_display_string_pos): Accept an additional argument
5e617bc2 5397 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5398 for a display string or property. If found, set DISP_PROP_P
5399 non-zero.
5400
5401 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5402 DISP_PROP_P, and pass it to compute_display_string_pos.
5403 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5404 non-zero. All callers of bidi_fetch_char changed.
5405
fb33fa43
SM
54062011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5407
5408 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5409
b099e063
DM
54102010-12-03 Don March <don@ohspite.net>
5411
5412 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5413 last character M-[char] is translated to ESC [char] (bug#7541).
5414
5cc7f7af
KH
54152011-08-02 Kenichi Handa <handa@m17n.org>
5416
d0fffa3f 5417 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5418
5419 * chartab.c (uniprop_table): Make it non-static.
5420
525d5e6e
EZ
54212011-08-01 Eli Zaretskii <eliz@gnu.org>
5422
5423 * xdisp.c (forward_to_next_line_start): Accept additional argument
5424 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5425 on the newline.
5426 (reseat_at_next_visible_line_start): Use the bidi iterator state
5427 returned by forward_to_next_line_start to restore the state of
5428 it->bidi_it after backing up to previous newline. (Bug#9212)
5429
31011111
AS
54302011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5431
5432 * regex.c (re_comp): Protoize.
5433 (re_exec): Fix return type.
5434 (regexec): Fix type of `ret'. (Bug#9203)
5435
476371c4
PE
54362011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5437
e5d76069
PE
5438 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5439 This is needed if max-image-size is a floating-point number.
5440
9a79b20c
AS
54412011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5442
5443 * print.c (print_object): Print empty symbol as ##.
5444
5445 * lread.c (read1): Read ## as empty symbol.
5446
d8c2fa78
AA
54472011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5448
5449 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5450 setting frame foreground color (Bug#9175).
5451 (x_set_background_color): Likewise.
5452
ffe57a7a
AA
5453 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5454 contents (Bug#9176).
5455 (EmacsTooltip -init): Remove bezels and add shadows to
5456 tooltip windows.
5457
bf3492a5
AA
5458 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5459 or scroll bar (Bug#8470).
5460
d55e9c53
AA
5461 * nsfont.m (nsfont_open): Remove assignment to voffset and
5462 unnecessary vars hshink, expand, hd, full_height, min_height.
5463 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5464
5465 * nsterm.h (nsfont_info): Remove voffset field.
5466
d8c2fa78 54672011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5468
5469 Implement strike-through and overline on NextStep (Bug#8863).
5470
5471 * nsfont.m (nsfont_open): Use underline position provided by font,
5472 instead of hard-coded value of 2.
5473 (nsfont_draw): Call ns_draw_text_decoration instead.
5474
5475 * nsterm.h: Add declaration for ns_draw_text_decoration.
5476
5477 * nsterm.m (ns_draw_text_decoration): New function for drawing
5478 underline, overline, and strike-through.
5479 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5480 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5481 accommodate underlining, etc.
4843aac3 5482
4cc60b9b
EZ
54832011-07-28 Eli Zaretskii <eliz@gnu.org>
5484
bc7ece87
EZ
5485 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5486 default.
4cc60b9b 5487
476371c4
PE
54882011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5489
66606eea
PE
5490 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5491 Without this fix, if a signal arrives just after memory fills up,
5492 'malloc' might be invoked reentrantly.
5493
476371c4
PE
5494 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5495 In other words, assume that every image size is allowed, on non-X
5496 hosts. This assumption is probably wrong, but it lets Emacs compile.
5497
f3fcc40d
AS
54982011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5499
5500 * regex.c (re_iswctype): Convert return values to boolean.
5501
350c992f
EZ
55022011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5503
5504 * xdisp.c (compute_display_string_pos): Don't use cached display
5505 string position if the buffer had its restriction changed.
5506 (Bug#9184)
5507
5266b4bb
PE
55082011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5509
5510 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5511
2573a837 55122011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5513
41f55ccd 5514 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5515
39e378da
PE
5516 * bidi.c: Integer size and overflow fixes.
5517 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5518 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5519 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5520 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5521 (bidi_find_other_level_edge):
5522 Use ptrdiff_t instead of EMACS_INT where either will do.
5523 This works better on 32-bit hosts configured --with-wide-int.
5524 (bidi_cache_ensure_space): Check for size-calculation overflow.
5525 Use % rather than repeated addition, for better worst-case speed.
5526 Don't set bidi_cache_size until after xrealloc returns, because it
5527 might not return.
5528 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5529 (bidi_cache_ensure_space): Also check that the bidi cache size
5530 does not exceed that of the largest Lisp string or buffer. See Eli
5531 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5532
5e927815
PE
5533 * alloc.c (__malloc_size_t): Remove.
5534 All uses replaced by size_t. See Andreas Schwab's note
5535 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5536
ca4aa935
PE
5537 * image.c: Improve checking for integer overflow.
5538 (check_image_size): Assume that f is nonnull, since
5539 it is always nonnull in practice. This is one less thing to
5540 worry about when checking for integer overflow later.
5541 (x_check_image_size): New function, which checks for integer
5542 overflow issues inside X.
5543 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5544 This removes the need for a memory_full check.
5545 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5546 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5547 (xbm_read_bitmap_data): Change locals back to 'int', since
5548 their values must fit in 'int'.
5549 (xpm_load_image, png_load, tiff_load):
5550 Invoke x_create_x_image_and_pixmap earlier,
5551 to avoid much needless work if the image is too large.
5552 (tiff_load): Treat overly large images as if
5553 x_create_x_image_and_pixmap failed, not as malloc failures.
5554 (gs_load): Use x_check_image_size.
5555
5f8f9cc2
PE
5556 * gtkutil.c: Omit integer casts.
5557 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5558 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5559
5adf60bc
PE
5560 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5561
c8907a93
PE
5562 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5563 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5564 would wrongly return t on a 64-bit host.
5565
e3c25c68
PE
5566 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5567 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5568 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5569 and therefore cause GCC to emit a bogus diagnostic in some cases.
5570
3f791afe
PE
5571 * image.c: Integer signedness and overflow and related fixes.
5572 This is not an exhaustive set of fixes, but it's time to
5573 record what I've got.
5574 (lookup_pixel_color, check_image_size): Remove redundant decls.
5575 (check_image_size): Don't assume that arbitrary EMACS_INT values
5576 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5577 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5578 (tiff_load, imagemagick_load_image):
5579 Check for overflow in size calculations.
5580 (x_create_x_image_and_pixmap): Remove unnecessary test for
5581 xmalloc returning NULL; that can't happen.
5582 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5583 (xpm_color_bucket): Use better integer hashing function.
5584 (xpm_cache_color): Don't possibly over-allocate memory.
5585 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5586 (gif_memory_source):
5587 Use ptrdiff_t, not int or size_t, to record sizes.
5588 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5589 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5590 either works, as we prefer signed integers.
5591 (tiff_read_from_memory, tiff_write_from_memory):
5592 Return tsize_t, not size_t, since that's what the TIFF API wants.
5593 (tiff_read_from_memory): Don't fail simply because the read would
5594 go past EOF; instead, return a short read.
5595 (tiff_load): Omit no-longer-needed casts.
5596 (Fimagemagick_types): Don't assume size fits into 'int'.
5597
3cc5a532
PE
5598 Improve hashing quality when configured --with-wide-int.
5599 * fns.c (hash_string): New function, taken from sxhash_string.
5600 Do not discard information about ASCII character case; this
5601 discarding is no longer needed.
5602 (sxhash-string): Use it. Change sig to match it. Caller changed.
5603 * lisp.h: Declare it.
5604 * lread.c (hash_string): Remove, since we now use fns.c's version.
5605 The fns.c version returns a wider integer if --with-wide-int is
5606 specified, so this should help the quality of the hashing a bit.
5607
b312a492
PE
5608 * emacs.c: Integer overflow minor fix.
5609 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5610 Define only if GNU_LINUX.
5611 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5612
dfd153ae
PE
5613 * dispnew.c: Integer signedness and overflow fixes.
5614 Remove unnecessary forward decls, that were a maintenance hassle.
5615 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5616 All uses changed.
5617 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5618 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5619 (prepare_desired_row, line_draw_cost):
5620 Use int, not unsigned, where either works.
5621 (save_current_matrix, restore_current_matrix):
5622 Use ptrdiff_t, not size_t, where either works.
5623 (init_display): Check for overflow more accurately, and without
5624 relying on undefined behavior.
5625
a81d11a3
PE
5626 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5627 Remove, replacing with the new symbols in lisp.h. All uses changed.
5628 * fileio.c (make_temp_name):
5629 * filelock.c (lock_file_1, lock_file):
5630 * xdisp.c (message_dolog):
5631 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5632 Use pMd etc. instead.
5633 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5634 replacing the pWIDE etc. symbols removed from editfns.c.
5635
3300e6fd
PE
5636 * keyboard.h (num_input_events): Now uintmax_t.
5637 This is (very slightly) less likely to mess up due to wraparound.
5638 All uses changed.
5639
fd05c7e9
PE
5640 * buffer.c: Integer signedness fixes.
5641 (alloc_buffer_text, enlarge_buffer_text):
5642 Use ptrdiff_t rather than size_t when either will do, as we prefer
5643 signed integers.
5644
903fe15d
PE
5645 * alloc.c: Integer signedness and overflow fixes.
5646 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5647 (__malloc_size_t): Default to size_t, not to int.
5648 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5649 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5650 Prefer ptrdiff_t to size_t when either would do, as we prefer
5651 signed integers.
5652 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5653 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5654 Now const. Initialize with values that are in range even if char
5655 is signed.
5656 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5657 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5658 These functions do the right thing with sizes > 2**32.
5659 (check_depth): Now ptrdiff_t, not int.
5660 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5661 Adjust to new way of storing sizes. Check for size overflow bugs
5662 in rest of code.
5663 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5664 slightly wrong anyway, as it missed one instance of
5665 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5666 (refill_memory_reserve): Omit needless cast to size_t.
5667 (mark_object_loop_halt): Mark as externally visible.
5668
ac82cc6a
PE
5669 * xselect.c: Integer signedness and overflow fixes.
5670 (Fx_register_dnd_atom, x_handle_dnd_message):
5671 Use ptrdiff_t, not size_t, since we prefer signed.
5672 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5673 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5674 x_dnd_atoms_size and x_dnd_atoms_length.
5675
c2d1e36d
PE
5676 * doprnt.c: Prefer signed to unsigned when either works.
5677 * eval.c (verror):
5678 * doprnt.c (doprnt):
5679 * lisp.h (doprnt):
5680 * xdisp.c (vmessage):
5681 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5682 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5683 prefer signed arithmetic to avoid comparison confusion.
5684 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5685 but is a bit tricky.
5686
0e926e56
PE
5687 Assume freestanding C89 headers, string.h, stdlib.h.
5688 * data.c, doprnt.c, floatfns.c, print.c:
5689 Include float.h unconditionally.
5690 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5691 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5692 * regex.c: Likewise for stddef.h, string.h.
5693 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5694 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5695 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5696 (STDC_HEADERS): Remove obsolete defines.
5697 * sysdep.c: Include limits.h unconditionally.
5698
9cfdb3ec
PE
5699 Assume support for memcmp, memcpy, memmove, memset.
5700 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5701 * regex.c (memcmp, memcpy):
5702 Remove; we assume C89 now.
5703
5704 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5705 (__malloc_safe_bcopy): Remove; no longer needed.
5706
cf950e6b 5707 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
5708 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5709 well either way, and we prefer signed to unsigned.
5710
dbf38e02
LMI
57112011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5712
5713 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5714 closes the connection while we're reading (bug#9182).
5715
d6f0886c 57162011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 5717
d6f0886c
JD
5718 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5719 are specified (Bug#9168).
24e0f6b1 5720
2eb1f9e6
PE
57212011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5722
5723 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5724 Found by GCC static checking and --with-wide-int on a 32-bit host.
5725
22381272 57262011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
5727
5728 * xdisp.c (compute_display_string_pos): Fix logic of caching
5729 previous display string position. Initialize cached_prev_pos to
5730 -1. Fixes slow-down at the beginning of a buffer.
5731
f25e39b4
EZ
57322011-07-24 Eli Zaretskii <eliz@gnu.org>
5733
5734 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5735 for attrs[LFACE_FONTSET_INDEX].
5736
04c4b52e
PE
57372011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5738
5739 * xml.c (parse_region): Remove unused local
5740 that was recently introduced.
5741
c1734fbd
EZ
57422011-07-23 Eli Zaretskii <eliz@gnu.org>
5743
be18c5a5
EZ
5744 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5745 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5746
c1734fbd
EZ
5747 * xdisp.c (move_it_in_display_line_to): Record the best matching
5748 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
5749 exit if none of the characters scanned was an exact match.
5750 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
5751 when exact match is impossible due to invisible text, and the
5752 lines are truncated.
5753
a258d627
JD
57542011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5755
5756 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5757 for OSX >= 10.7.
5758
b6d5a689
EZ
57592011-07-22 Eli Zaretskii <eliz@gnu.org>
5760
0f74f785
EZ
5761 Fix a significant slow-down of cursor motion with C-n, C-p,
5762 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5763 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 5764 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
5765 (next_element_from_buffer): Call compute_stop_pos_backwards to
5766 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
5767 base_level_stop.
5768 (reseat): Don't look for prev_stop, as that could mean a very long
5769 run.
5770 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5771 <cached_disp_overlay_modiff>: Cache for last found display string
5772 position.
551918c1 5773 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
5774 about the same buffer in the same area of character positions, and
5775 the buffer wasn't changed since the time the display string
5776 position was cached.
551918c1 5777
b2d0c91a
EZ
57782011-07-22 Eli Zaretskii <eliz@gnu.org>
5779
5780 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5781 is an integer, which is important for empty lines. (Bug#9149)
5782
043604ee
CY
57832011-07-22 Chong Yidong <cyd@stupidchicken.com>
5784
5785 * frame.c (Fmodify_frame_parameters): In tty case, update the
5786 default face if necessary (Bug#4238).
5787
da4adb04
CY
57882011-07-21 Chong Yidong <cyd@stupidchicken.com>
5789
5790 * editfns.c (Fstring_to_char): No need to explain what a character
5791 is in the docstring (Bug#6576).
5792
9abd0532
LMI
57932011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5794
5795 * xml.c (parse_region): Make sure we always return a tree.
5796
36881d16
HK
57972011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5798
5799 * xml.c (parse_region): If a document contains only comments,
5800 return that, too.
5801
1e98674d
LMI
58022011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5803
5804 * xml.c (make_dom): Return comments, too.
5805
590bd467
PE
58062011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5807
5808 Port to OpenBSD.
5809 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5810 and the surrounding thread.
5811 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5812 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5813 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5814 timer goes off.
5815 * s/openbsd.h (BROKEN_SIGIO): Define.
5816 * unexelf.c (unexec) [__OpenBSD__]:
5817 Don't update the .mdebug section of the Alpha COFF symbol table.
5818
f41628b2
LMI
58192011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5820
5821 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5822 (bug#8460).
5823
b59b67c5
PE
58242011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5825
15e3a074
PE
5826 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5827 This fixes some race conditions on the permissions of any newly
5828 created file.
5829
41bed37d
PE
5830 * alloc.c (valid_pointer_p): Use pipe, not open.
5831 This fixes some permissions issues when debugging.
5832
b59b67c5
PE
5833 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5834 If fchown fails to set both uid and gid, try to set just gid,
5835 as that is sometimes allowed. Adjust the file's mode to eliminate
5836 setuid or setgid bits that are inappropriate if fchown fails.
5837
925a6be7
SM
58382011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5839
5840 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5841 to compare Lisp_Objects.
5842 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5843 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5844 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5845
52968808
AS
58462011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5847
0a6a104b
AS
5848 * lread.c (read_integer): Unread even EOF character.
5849 (read1): Likewise. Properly record start position of symbol.
5850
52968808
AS
5851 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5852 symbol character follows.
5853
9e381cdd
PE
58542011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5855
5856 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5857 This works around a problem with the previous change to Fcopy_file.
5858 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5859 and without this change, GCC might complain about discarding
5860 fchown's return value.
5861
b5641435
JB
58622011-07-16 Juanma Barranquero <lekktu@gmail.com>
5863
5864 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5865
a8031457
PE
58662011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5867
5868 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5869
dd889327
LMI
58702011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5871
750c33f7
LMI
5872 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5873 it's used from the C level.
5874
dd889327
LMI
5875 * process.c: Use the same condition for POLL_FOR_INPUT in both
5876 keyboard.c and process.c (bug#1858).
5877
87e86684
LM
58782011-07-09 Lawrence Mitchell <wence@gmx.li>
5879
5880 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5881 (Fgnutls_boot): Use it.
5882
64348f40
AS
58832011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5884
5885 * doc.c (Fsubstitute_command_keys): Revert last change.
5886
1d698799
LMI
58872011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5888
f863868c
LMI
5889 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5890 quotes the next character, and doesn't affect other longer
5891 sequences (bug#8935).
5892
1d698799
LMI
5893 * lread.c (syms_of_lread): Clarify that is isn't only
5894 `eval-buffer' and `eval-defun' that's affected by
5895 `lexical-binding' (bug#8460).
5896
aa4b6df6
EZ
58972011-07-15 Eli Zaretskii <eliz@gnu.org>
5898
5899 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 5900 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 5901
5d856da6
PE
59022011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5903
ad6042bb
PE
5904 Fix minor problems found by static checking.
5905 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5906 (elsz): Now a signed constant, not a size_t var. We prefer signed
5907 types to unsigned, to avoid integer comparison confusion. Without
5908 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5909 "cannot optimize loop, the loop counter may overflow", a symptom
5910 of the confusion.
f00bbb22 5911 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
5912 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5913
6468f31c
LMI
59142011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5915
49080b10
LMI
5916 * search.c (Fre_search_backward): Mention `case-fold-search' in
5917 all the re_search_* functions (bug#8138).
5918
6468f31c
LMI
5919 * keyboard.c (Fopen_dribble_file): Document when the file is
5920 closed (bug#8056).
5921
c965adc5
EZ
59222011-07-14 Eli Zaretskii <eliz@gnu.org>
5923
df9733bf
EZ
5924 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5925 bidi_cache_idx.
5926
0bb23927
EZ
5927 Support bidi reordering of display and overlay strings.
5928 * xdisp.c (compute_display_string_pos)
5929 (compute_display_string_end): Accept additional argument STRING.
5930 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5931 (reseat_to_string): Initialize bidi_it->string.s and
5932 bidi_it->string.schars.
5933 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
5934 NULL (avoids a crash in bidi_paragraph_init).
5935 Initialize itb.string.lstring.
0bb23927
EZ
5936 (init_iterator): Call bidi_init_it only of a valid
5937 buffer position was specified. Initialize paragraph_embedding to
5938 L2R.
5939 (reseat_to_string): Initialize the bidi iterator.
5940 (display_string): If we need to ignore text properties of
5941 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5942 original value of -1 will not work with bidi.)
5943 (compute_display_string_pos): First arg is now struct
5944 `text_pos *'; all callers changed. Support display properties on
5945 Lisp strings.
5946 (compute_display_string_end): Support display properties on Lisp
5947 strings.
5948 (init_iterator, reseat_1, reseat_to_string): Initialize the
5949 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5950 when iterating on a string not from display properties).
640c8776
SM
5951 (compute_display_string_pos, compute_display_string_end):
5952 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
5953 arrow keys.
5954 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
5955 base_level_stop; instead, set base_level_stop to BEGV.
5956 Fixes crashes in vertical-motion.
0bb23927
EZ
5957 (next_element_from_buffer): Improve commentary for when
5958 the iterator is before prev_stop.
5959 (init_iterator): Initialize bidi_p from the default value of
5960 bidi-display-reordering, not from buffer-local value. Use the
5961 buffer-local value only if initializing for buffer iteration.
5962 (handle_invisible_prop): Support invisible properties on strings
5963 that are being bidi-reordered.
5964 (set_iterator_to_next): Support bidi reordering of C strings and
5965 Lisp strings.
5966 (next_element_from_string): Support bidi reordering of Lisp
5967 strings.
5968 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
5969 (display_string): Support display of R2L glyph rows.
5970 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
5971 (init_iterator): Don't initialize it->bidi_p for strings
5972 here.
5973 (reseat_to_string): Initialize it->bidi_p for strings here.
5974 (next_element_from_string, next_element_from_c_string)
5975 (next_element_from_buffer): Add xassert's for correspondence
5976 between IT's object being iterated and it->bidi_it.string
5977 structure.
5978 (face_before_or_after_it_pos): Support bidi iteration.
5979 (next_element_from_c_string): Handle the case of the first string
5980 character that is not the first one in the visual order.
5981 (get_visually_first_element): New function, refactored from common
5982 parts of next_element_from_buffer, next_element_from_string, and
5983 next_element_from_c_string.
5984 (tool_bar_lines_needed, redisplay_tool_bar)
5985 (display_menu_bar): Force left-to-right direction. Add a FIXME
5986 comment for making that be controlled by a user option.
5987 (push_it, pop_it): Save and restore the state of the
5988 bidi iterator. Save and restore the bidi_p flag.
5989 (pop_it): Iterate out of display property for string iteration as
5990 well.
5991 (iterate_out_of_display_property): Support iteration over strings.
5992 (handle_single_display_spec): Set up it->bidi_it for iteration
5993 over a display string, and call bidi_init_it.
5994 (handle_single_display_spec, next_overlay_string)
5995 (get_overlay_strings_1, push_display_prop): Set up the bidi
5996 iterator for displaying display or overlay strings.
5997 (forward_to_next_line_start): Don't use the shortcut if
5998 bidi-iterating.
5999 (back_to_previous_visible_line_start): If handle_display_prop
6000 pushed the iterator stack, restore the internal state of the bidi
6001 iterator by calling bidi_pop_it same number of times.
6002 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6003 and we are bidi-iterating, don't decrement the iterator position;
6004 instead, set the first_elt flag in the bidi iterator, to produce
6005 the same effect.
6006 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6007 (push_display_prop): xassert that we are iterating a buffer.
6008 (push_it, pop_it): Save and restore paragraph_embedding member.
6009 (handle_single_display_spec, next_overlay_string)
6010 (get_overlay_strings_1, reseat_1, reseat_to_string)
6011 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6012 correctly. Don't assume unibyte strings are not bidi-reordered.
6013 (compute_display_string_pos)
6014 (compute_display_string_end): Fix handling the case of C string.
6015 (push_it, pop_it): Save and restore from_disp_prop_p.
6016 (handle_single_display_spec, push_display_prop): Set the
6017 from_disp_prop_p flag.
6018 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6019 (pop_it): Call iterate_out_of_display_property only if we are
6020 popping after iteration over a string that came from a display
6021 property. Fix a typo in popping stretch info. Add an assertion
6022 for verifying that the iterator position is in sync with the bidi
6023 iterator.
6024 (handle_single_display_spec, get_overlay_strings_1)
6025 (push_display_prop): Fix initialization of paragraph direction for
6026 string when that of the parent object is not yet determined.
6027 (reseat_1): Call bidi_init_it to resync the bidi
6028 iterator with IT's position. (Bug#7616)
6029 (find_row_edges): If ROW->start.pos gives position
6030 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6031 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6032 Reset the from_disp_prop_p flag.
6033 (SAVE_IT, RESTORE_IT): New macros.
6034 (pos_visible_p, face_before_or_after_it_pos)
6035 (back_to_previous_visible_line_start)
6036 (move_it_in_display_line_to, move_it_in_display_line)
6037 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6038 (try_scrolling, redisplay_window, display_line): Use them when
6039 saving a temporary copy of the iterator and restoring it back.
6040 (back_to_previous_visible_line_start, reseat_1)
6041 (init_iterator): Empty the bidi cache "stack".
6042 (move_it_in_display_line_to): If iterator ended up at
6043 EOL, but we never saw any buffer positions smaller than
6044 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6045 motion in bidi-reordered lines.
6046 (move_it_in_display_line_to): Record prev_method and prev_pos
6047 immediately before the call to set_iterator_to_next. Fixes cursor
6048 motion in bidi-reordered lines with stretch glyphs and strings
6049 displayed in margins. (Bug#8133) (Bug#8867)
6050 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6051 TO_CHARPOS.
640c8776
SM
6052 (pos_visible_p): Support positions in bidi-reordered lines.
6053 Save and restore bidi cache.
0bb23927
EZ
6054
6055 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6056 (bidi_paragraph_info): Delete unused struct.
6057 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6058 (bidi_cache_start): New variable.
6059 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6060 to zero.
6061 (bidi_cache_fetch_state, bidi_cache_search)
6062 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6063 (bidi_cache_find, bidi_peek_at_next_level)
6064 (bidi_level_of_next_char, bidi_find_other_level_edge)
6065 (bidi_move_to_visually_next): Compare cache index with
6066 bidi_cache_start rather than with zero.
6067 (bidi_fetch_char): Accept new argument STRING; all callers
6068 changed. Support iteration over a string. Support strings with
6069 display properties. Support unibyte strings. Fix the type of
6070 `len' according to what STRING_CHAR_AND_LENGTH expects.
6071 (bidi_paragraph_init, bidi_resolve_explicit_1)
6072 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6073 (bidi_level_of_next_char, bidi_move_to_visually_next):
6074 Support iteration over a string.
0bb23927
EZ
6075 (bidi_set_sor_type, bidi_resolve_explicit_1)
6076 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6077 can now be zero (for strings); special values 0 and -1 were
6078 changed to -1 and -2, respectively.
6079 (bidi_char_at_pos): New function.
6080 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6081 Call it instead of FETCH_MULTIBYTE_CHAR.
6082 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6083 initialized to valid values.
6084 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6085 values.
6086 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6087 the test for valid cached positions. Fix the logic for looking up
6088 the sentinel state in the cache. GCPRO the Lisp string we are
6089 iterating.
6090 (bidi_push_it, bidi_pop_it): New functions.
6091 (bidi_initialize): Initialize the bidi cache start stack pointer.
6092 (bidi_cache_ensure_space): New function, refactored from part of
6093 bidi_cache_iterator_state. Don't assume the required size is just
6094 one BIDI_CACHE_CHUNK away.
6095 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6096 (bidi_count_bytes, bidi_char_at_pos): New functions.
6097 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6098 always valid if bidi_cache_idx is valid.
6099 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6100 is valid if it's going to be used.
6101 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6102 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6103 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6104 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6105 (bidi_find_other_level_edge, bidi_cache_start_stack):
6106 All variables related to cache indices are now EMACS_INT.
c965adc5 6107
0bb23927
EZ
6108 * dispextern.h (struct bidi_string_data): New structure.
6109 (struct bidi_it): New member `string'. Make flag members be 1-bit
6110 fields, and put them last in the struct.
640c8776
SM
6111 (compute_display_string_pos, compute_display_string_end):
6112 Update prototypes.
0bb23927
EZ
6113 (bidi_push_it, bidi_pop_it): Add prototypes.
6114 (struct iterator_stack_entry): New members bidi_p,
6115 paragraph_embedding, and from_disp_prop_p.
6116 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6117 (bidi_shelve_cache, bidi_unshelve_cache):
6118 Declare prototypes.
0bb23927
EZ
6119
6120 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6121 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6122 and vector-like objects.
6123
6124 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6125 cache around display iteration.
6126
6127 * window.c (Fwindow_end, window_scroll_pixel_based)
6128 (displayed_window_lines, Frecenter): Save and restore the bidi
6129 cache around display iteration.
6130
3bbd2265
LMI
61312011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6132
6133 * editfns.c (Fdelete_region): Clarify the use of the named
6134 parameters (bug#6788).
6135
adc47434
MR
61362011-07-14 Martin Rudalics <rudalics@gmx.at>
6137
6138 * indent.c (Fvertical_motion): Set and restore w->pointm when
6139 saving and restoring the window's buffer (Bug#9006).
6140
837c31f8
LMI
61412011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6142
6143 * editfns.c (Fstring_to_char): Clarify just what is returned
6144 (bug#6576). Text by Eli Zaretskii.
6145
ac389d0c
JB
61462011-07-13 Juanma Barranquero <lekktu@gmail.com>
6147
6148 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6149
0be0ce47
EZ
61502011-07-13 Eli Zaretskii <eliz@gnu.org>
6151
6152 * buffer.c (mmap_find): Fix a typo.
6153
cd18e7e3
JB
61542011-07-13 Johan Bockgård <bojohan@gnu.org>
6155
6156 Fix execution of x selection hooks.
6157 * xselect.c (Qx_lost_selection_functions)
6158 (Qx_sent_selection_functions): New vars.
6159 (syms_of_xselect): DEFSYM them.
6160 (x_handle_selection_request): Pass Qx_sent_selection_functions
6161 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6162 (x_handle_selection_clear,x_clear_frame_selections):
6163 Pass Qx_lost_selection_functions rather than
6164 Vx_lost_selection_functions to Frun_hook_with_args.
6165
47ea7f44
PE
61662011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6167
ac389d0c 6168 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6169 The old code sometimes used this field without initializing it.
6170
47ea7f44
PE
6171 * alloc.c (gc_sweep): Don't read past end of array.
6172 In theory, the old code could also have corrupted Emacs internals,
6173 though it'd be very unlikely.
6174
bc985c87
AS
61752011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6176
6177 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6178 argument. (Bug#4026)
bc985c87 6179
0cf34688
LMI
61802011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6181
b3dadd76
LMI
6182 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6183 key" (bug#4257).
6184
0cf34688
LMI
6185 * window.c (Fset_window_start): Doc fix (bug#4199).
6186 (Fset_window_hscroll): Ditto.
6187
270768cd
PE
61882011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6189
077e3dda 6190 Fix minor new problems caught by GCC 4.6.1.
270768cd 6191 * term.c (init_tty): Remove unused local.
490011a6 6192 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6193 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6194 not used otherwise.
270768cd 6195
b1f58454
CY
61962011-07-12 Chong Yidong <cyd@stupidchicken.com>
6197
6198 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6199
22b9578d
LMI
62002011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6201
6e70ab07
LMI
6202 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6203 are the mini-buffer and the echo area (bug#3320).
6204
22b9578d
LMI
6205 * term.c (init_tty): Remove support for supdup, c10 and perq
6206 terminals, which are no longer supported (bug#1482).
6207
8974cc9f
JB
62082011-07-10 Johan Bockgård <bojohan@gnu.org>
6209
6210 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6211
a560d974
JD
62122011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6213
6214 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6215 for non-popups (Bug#3642).
6216
1dae0f0a
AS
62172011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6218
268c2c36 6219 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6220 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6221 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6222 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6223 * data.c (fmod): Likewise.
6224 * dispnew.c (swap_glyphs_in_rows): Likewise.
6225 * emacs.c (memory_warning_signal): Likewise.
6226 * floatfns.c (float_error): Likewise.
6227 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6228 (otf_open, font_otf_capability, generate_otf_features)
6229 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6230 Likewise.
6231 * image.c (pbm_read_file): Likewise.
6232 * indent.c (string_display_width): Likewise.
6233 * intervals.c (check_for_interval, search_for_interval)
6234 (inc_interval_count, count_intervals, root_interval)
6235 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6236 * lread.c (defalias): Likewise.
268c2c36 6237 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6238 * regex.c (set_image_of_range_1, set_image_of_range)
6239 (regex_grow_registers): Likewise.
6240 * sysdep.c (strerror): Likewise.
6241 * termcap.c (valid_filename_p, tprint, main): Likewise.
6242 * tparam.c (main): Likewise.
6243 * unexhp9k800.c (run_time_remap, save_data_space)
6244 (update_file_ptrs, read_header, write_header, calculate_checksum)
6245 (copy_file, copy_rest, display_header): Likewise.
6246 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6247 Likewise.
6248 * xdisp.c (check_it): Likewise.
6249 * xfaces.c (register_color, unregister_color, unregister_colors):
6250 Likewise.
6251 * xfns.c (print_fontset_result): Likewise.
6252 * xrdb.c (member, fatal, main): Likewise.
6253
99033785
PE
62542011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6255
6256 Fix minor problems found by static checking (Bug#9031).
6257 * chartab.c (char_table_set_range, map_sub_char_table):
6258 Remove unused locals.
6259 (uniprop_table): Now static.
6260 * composite.c (_work_char): Remove unused static var.
6261
9cb2ac56
JB
62622011-07-09 Juanma Barranquero <lekktu@gmail.com>
6263
6264 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6265
f25661f0
JD
62662011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6267
6268 * gtkutil.c (qttip_cb): Remove code without function.
6269
8278c4fe
EZ
62702011-07-09 Eli Zaretskii <eliz@gnu.org>
6271
6272 * w32.c (pthread_sigmask): New stub.
6273
1692ae2d 62742011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6275
8a6ebd58 6276 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6277 sigprocmask is portable only for single-threaded applications, and
6278 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6279 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6280 (LIBES): Use it.
6281 * callproc.c (Fcall_process):
6282 * process.c (create_process):
6283 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6284 Use pthread_sigmask, not sigprocmask.
123403e4 6285
1b854618
JD
62862011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6287
6288 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6289 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6290 wrong (Bug#8591).
6291
3fe4b549
JD
62922011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6293
0ce7e563
JD
6294 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6295 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6296 (xg_hide_tooltip): Fix comment.
6297
3fe4b549
JD
6298 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6299 in registerServicesMenuSendTypes.
6300 (validRequestorForSendType): Don't check ns_return_types.
6301
6302 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6303 ns_return_type.
6304
5df75e47
JR
63052011-07-08 Jason Rumney <jasonr@gnu.org>
6306
22610910
JR
6307 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6308 SH_SHOW for hidden windows (Bug#5482).
6309
5df75e47
JR
6310 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6311 frame struct members of non-existent frames (Bug#6284).
6312
699c10bd
JD
63132011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6314
4393663b
JD
6315 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6316 variable firstTime not needed on OSX >= 10.6.
6317 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6318 >= 10.5. Use setKnobProportion, setDoubleValue.
6319
6320 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6321 (MAC_OS_X_VERSION_10_5): Define if not defined.
6322 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6323 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6324 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6325
6326 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6327 cString and lossyCString on OSX >= 10.4
6328
58179cce 6329 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6330 sizeToFit on OSX >= 10.2.
6331
6332 * nsimage.m (allocInitFromFile): Don't use deprecated method
6333 bestRepresentationForDevice on OSX >= 10.6.
6334
6335 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6336 to avoid warning.
6337
6338 * emacs.c: Declare unexec_init_emacs_zone.
6339
a63e0781
JD
6340 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6341
699c10bd
JD
6342 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6343
6344 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6345 on svcsMenu (Bug#8842).
6346
6347 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6348 ns_return_types.
6349 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6350
6351 * nsterm.m (QUTF8_STRING): Declare.
6352 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6353 (validRequestorForSendType): Return type is (id).
6354 Change indexOfObjectIdenticalTo to indexOfObject.
6355 Check if we have local selection before returning self (Bug#8842).
6356 (writeSelectionToPasteboard): Put local selection into paste board
6357 if we have a local selection (Bug#8842).
6358 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6359
6360 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6361 (ns_get_local_selection): Declare.
6362
54e10184
LMI
63632011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6364
9888ff71
LMI
6365 * keymap.c (describe_map_tree): Don't insert a double newline at
6366 the end of the buffer (bug#1169) and return whether we inserted
6367 something.
6368
54e10184
LMI
6369 * callint.c (Fcall_interactively): Change "reading args" to
6370 "providing args" to try to clarify what it does (bug#1010).
6371
15fa4783
KH
63722011-07-07 Kenichi Handa <handa@m17n.org>
6373
6374 * composite.c (composition_compute_stop_pos): Ignore a static
6375 composition starting before CHARPOS (Bug#8915).
6376
6377 * xdisp.c (handle_composition_prop): Likewise.
6378
a8815b00
EZ
63792011-07-07 Eli Zaretskii <eliz@gnu.org>
6380
6381 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6382 (Bug#9015)
6383
ef7b981d 63842011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6385
6386 * character.h (unicode_category_t): New enum type.
6387
6388 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6389 (Qchar_code_property_table): New variable.
6390 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6391 (UNIPROP_COMPRESSED_FORM_P): New macros.
6392 (char_table_ascii): Uncompress the compressed values.
6393 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6394 Uncompress the compressed values.
ac389d0c 6395 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6396 (char_table_ref_and_range): Uncompress the compressed values.
6397 (sub_char_table_set): New arg is_uniprop. Callers changed.
6398 Uncompress the compressed values.
6399 (sub_char_table_set_range): Args changed. Callers changed.
6400 (char_table_set_range): Adjuted for the above change.
6401 (map_sub_char_table): Delete args default_val and parent. Add arg
6402 top. Give decoded values to a Lisp function.
640c8776 6403 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6404 values to a Lisp function. Gcpro more variables.
6405 (uniprop_table_uncompress)
6406 (uniprop_decode_value_run_length): New functions.
6407 (uniprop_decoder, uniprop_decoder_count): New variables.
6408 (uniprop_get_decoder, uniprop_encode_value_character)
6409 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6410 New functions.
6411 (uniprop_encoder, uniprop_encoder_count): New variables.
6412 (uniprop_get_encoder, uniprop_table)
6413 (Funicode_property_table_internal, Fget_unicode_property_internal)
6414 (Fput_unicode_property_internal): New functions.
6415 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6416 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6417 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6418 char-code-property-alist.
6419
640c8776 6420 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6421 Vunicode_category_table.
6422
640c8776 6423 * font.c (font_range): Adjust for the change of
c805dec0
KH
6424 Vunicode_category_table.
6425
76b397fb
DN
64262011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6427
6428 * m/iris4d.h: Remove file, move contents ...
6429 * s/irix6-5.h: ... here.
6430
22b4128e
PE
64312011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6432
6433 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6434 * alloc.c (mark_buffer):
6435 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6436 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6437 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6438 This isn't true in general, and it's particularly not true
6439 if Emacs is configured with --with-wide-int.
6440 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6441 New macros, used in the buffer.c change.
6442
869795d6
JD
64432011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6444
6445 * xsettings.c: Use both GConf and GSettings if both are available.
6446 (store_config_changed_event): Add comment.
6447 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6448 (store_tool_bar_style_changed): New functions.
5e617bc2 6449 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6450 (struct xsettings): Move font inside HAVE_XFT.
6451 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6452 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6453 Move inside HAVE_XFT.
640c8776 6454 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6455 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6456 also.
6457 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6458 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6459 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6460 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6461 (parse_settings): Move check for font inside HAVE_XFT.
6462 (read_settings, apply_xft_settings): Add comment.
6463 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6464 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6465 call store_font_name_changed.
6466 (xft_settings_event): Add comment.
6467 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6468 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6469 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6470 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6471 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6472 (xsettings_get_system_font, xsettings_get_system_normal_font):
6473 Add comment.
869795d6 6474
d8ed26bd
PE
64752011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6476
6477 Random fixes. E.g., (random) never returned negative values.
6478 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6479 subseconds part to the entropy, as that's a bit more random.
6480 Prefer signed to unsigned, since the signedness doesn't matter and
6481 in general we prefer signed. When given a limit, use a
6482 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6483 latter isn't right if USE_2_TAGS_FOR_INTS.
6484 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6485 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6486
cabf1cac
SM
64872011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6488
6489 * textprop.c (text_property_stickiness):
6490 Obey Vtext_property_default_nonsticky.
6491 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6492 * w32fns.c (syms_of_w32fns):
6493 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6494
6e9b2be9
PE
64952011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6496
6497 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6498 This is more efficient than Ffile_directory_p and avoids a minor race.
6499
90186c68
LMI
65002011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6501
7c301272
LMI
6502 * buffer.c (Foverlay_put): Say what the return value is
6503 (bug#7835).
6504
c4f2d8d4
LMI
6505 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6506 is a directory before asking whether to use the file name
6507 (bug#7564).
ad637907
LMI
6508 (barf_or_query_if_file_exists): Make the "File is a directory"
6509 error be more correct.
c4f2d8d4 6510
90186c68
LMI
6511 * fns.c (Frequire): Remove the mention of the .gz files, since
6512 that's installation-specific, but keep the mention of
6513 `get-load-suffixes'.
6514
da64016e
PE
65152011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6516
6517 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6518 Report string overflow if the output is too long.
6519
7d47b580
JB
65202011-07-04 Juanma Barranquero <lekktu@gmail.com>
6521
a555cb87
JB
6522 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6523 (syms_of_gnutls): Remove duplicate DEFSYM for
6524 Qgnutls_bootprop_verify_hostname_error, an error for
6525 Qgnutls_bootprop_verify_error (which is no longer used).
6526
7d47b580
JB
6527 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6528 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6529 Also (re)move comments that are misplaced or no longer relevant.
6530
1e49bfab
LMI
65312011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6532
6533 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6534
1485f4c0
CY
65352011-07-03 Chong Yidong <cyd@stupidchicken.com>
6536
6537 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6538 and background color parameters if they have been changed.
6539
a9ab721e
LMI
65402011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6541
6542 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6543
cf7cff57
PE
65442011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6545
2e13213d
PE
6546 * xsettings.c (SYSTEM_FONT): Define only when used.
6547 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6548
cf7cff57
PE
6549 * keymap.c (access_keymap_1): Now static.
6550
7a8e04f7
CY
65512011-07-02 Chong Yidong <cyd@stupidchicken.com>
6552
6553 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6554 leave any prefix arg for the up event (Bug#1586).
6555
61352f62
LMI
65562011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6557
69bb1ef7
LMI
6558 * lread.c (syms_of_lread): Mention single symbols defined by
6559 `defvar' or `defconst' (bug#7154).
6560
61352f62 6561 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 6562 (Frequire): Mention get-load-suffixes.
61352f62 6563
28545e04
MR
65642011-07-02 Martin Rudalics <rudalics@gmx.at>
6565
6566 * window.h (window): Remove clone_number slot.
6567 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6568 Remove.
6569 (make_parent_window, make_window, saved_window)
6570 (Fset_window_configuration, save_window_save): Don't deal with
6571 clone numbers.
6572 * buffer.c (Qclone_number): Remove declaration.
6573 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6574
3349e122
SM
65752011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6576
6577 Add multiple inheritance to keymaps.
6578 * keymap.c (Fmake_composed_keymap): New function.
6579 (Fset_keymap_parent): Simplify.
6580 (fix_submap_inheritance): Remove.
6581 (access_keymap_1): New function extracted from access_keymap to handle
6582 embedded parents and handle lists of maps.
6583 (access_keymap): Use it.
6584 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6585 (Fcopy_keymap): Handle embedded parents.
6586 (Fcommand_remapping, define_as_prefix): Simplify.
6587 (Fkey_binding): Simplify.
6588 (syms_of_keymap): Move minibuffer-local-completion-map,
6589 minibuffer-local-filename-completion-map,
6590 minibuffer-local-must-match-map, and
6591 minibuffer-local-filename-must-match-map to Elisp.
6592 (syms_of_keymap): Defsubr make-composed-keymap.
6593 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6594 (parse_menu_item): Trivial simplification.
6595
3279eb87
GM
65962011-07-01 Glenn Morris <rgm@gnu.org>
6597
6598 * Makefile.in (SETTINGS_LIBS): Fix typo.
6599
4550efdf
KI
66002011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6601
6602 * coding.c (Fencode_coding_string): Record the last coding system
6603 used, as the function doc string says (bug#8738).
6604
0949d2b6
JD
66052011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6606
6607 * xsettings.c (store_monospaced_changed): Take new font as arg and
6608 check for change against current_mono_font.
6609 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6610 (emacs_settings_constructor, emacs_settings_get_property)
6611 (emacs_settings_set_property, emacs_settings_class_init)
6612 (emacs_settings_init, gsettings_obj): Remove.
6613 (something_changedCB): New function for HAVE_GSETTINGS.
6614 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6615 with value as argument.
6616 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6617 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 6618 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
6619 "changed".
6620
6621 * xgselect.c: Add defined (HAVE_GSETTINGS).
6622 (xgselect_initialize): Ditto.
6623
6624 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6625 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6626 xg_select.
6627
bbc6b304
PE
66282011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6629
6630 * eval.c (struct backtrace): Simplify and port the data structure.
6631 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6632 signed bit field, as this assumption is not portable and it makes
6633 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6634 "char debug_on_exit : 1" as this is not portable either; instead,
6635 use the portable "unsigned int debug_on_exit : 1". Remove unused
6636 member evalargs. Remove obsolete comments about cc bombing out.
6637
9851bfc5
JD
66382011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6639
51bb811f 6640 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
6641 Let HAVE_GSETTINGS override HAVE_GCONF.
6642 (store_monospaced_changed): New function.
6643 (EMACS_SETTINGS): A new type derived from GObject to handle
6644 GSettings notifications.
6645 (emacs_settings_constructor, emacs_settings_get_property)
6646 (emacs_settings_set_property, emacs_settings_class_init):
6647 New functions.
6648 (gsettings_client, gsettings_obj): New variables.
6649 (GSETTINGS_SCHEMA): New define.
6650 (something_changedCB): Call store_monospaced_changed.
6651 (init_gsettings): New function.
6652 (xsettings_initialize): Call init_gsettings.
6653 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6654 to NULL.
6655
640c8776 6656 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
6657 GCONF_CFLAGS/LIBS.
6658
5386012d
MR
66592011-06-29 Martin Rudalics <rudalics@gmx.at>
6660
6661 * window.c (resize_root_window, grow_mini_window)
6662 (shrink_mini_window): Rename Qresize_root_window to
6663 Qwindow_resize_root_window and Qresize_root_window_vertically to
6664 Qwindow_resize_root_window_vertically.
6665
f13e0b08
PE
66662011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6667
6668 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6669
94515237
JB
66702011-06-27 Juanma Barranquero <lekktu@gmail.com>
6671
6672 * makefile.w32-in: Redesign dependencies so they reflect more
6673 clearly which files are directly included by each source file,
6674 and not through other includes.
6675
e43b6e43
MR
66762011-06-27 Martin Rudalics <rudalics@gmx.at>
6677
6678 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6679 (sort_overlays, overlay_strings): When an overlay's clone number
6680 matches the window's clone number process the overlay even if
6681 the overlay's window property doesn't match the current window.
6682
d68443dc
MR
6683 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6684 (Fwindow_hchild): Rename to Fwindow_left_child.
6685 (Fwindow_next): Rename to Fwindow_next_sibling.
6686 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
6687 (resize_window_check): Rename to window_resize_check.
6688 (resize_window_apply): Rename to window_resize_apply.
6689 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6690 (Fdelete_other_windows_internal, resize_frame_windows)
6691 (Fsplit_window_internal, Fdelete_window_internal)
6692 (grow_mini_window, shrink_mini_window)
6693 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 6694
c7e73be5
JD
66952011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6696
6697 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6698 (emacs_fixed_set_min_size): Remove.
6699 (emacs_fixed_new): Take frame as argument.
6700
6701 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6702 (_EmacsFixedPrivate): Remove minwidth/height.
6703 Add struct frame *f.
6704 (emacs_fixed_init): Initialize priv->f.
6705 (get_parent_class, emacs_fixed_set_min_size): Remove.
6706 (emacs_fixed_new): Set priv->f to argument.
6707 (emacs_fixed_get_preferred_width)
6708 (emacs_fixed_get_preferred_height): Use min_width/height from
6709 frames size_hint to set minimum and natural (Bug#8919).
6710 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6711 and use min_width/height from frames size_hint to set
6712 min_width/height (Bug#8919).
6713
6714 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
6715 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6716 Fix indentation.
c7e73be5 6717
cf99dcf8
EZ
67182011-06-26 Eli Zaretskii <eliz@gnu.org>
6719
6720 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6721 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6722 called at ZV.
6723
029529ac
CY
67242011-06-26 Chong Yidong <cyd@stupidchicken.com>
6725
6726 * process.c (wait_reading_process_output): Bypass select if
6727 waiting for a cell while ignoring keyboard input, and input is
6728 pending. Suggested by Jan Djärv (Bug#8869).
6729
7a7ef429
PE
67302011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6731
6732 Use gnulib's dup2 module instead of rolling our own.
6733 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6734
11fdef7d 67352011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
6736
6737 * dispnew.c (scrolling_window): Before scrolling, turn off a
6738 mouse-highlight in the window being scrolled.
6739
cd3520a4
JB
67402011-06-24 Juanma Barranquero <lekktu@gmail.com>
6741
6742 Move DEFSYM to lisp.h and use everywhere.
6743
6744 * character.h (DEFSYM): Move declaration...
6745 * lisp.h (DEFSYM): ...here.
6746
6747 * gnutls.c:
6748 * minibuf.c:
6749 * w32menu.c:
6750 * w32proc.c:
6751 * w32select.c: Don't include character.h.
6752
6753 * alloc.c (syms_of_alloc):
6754 * buffer.c (syms_of_buffer):
6755 * bytecode.c (syms_of_bytecode):
6756 * callint.c (syms_of_callint):
6757 * casefiddle.c (syms_of_casefiddle):
6758 * casetab.c (init_casetab_once):
6759 * category.c (init_category_once, syms_of_category):
6760 * ccl.c (syms_of_ccl):
6761 * cmds.c (syms_of_cmds):
6762 * composite.c (syms_of_composite):
6763 * dbusbind.c (syms_of_dbusbind):
6764 * dired.c (syms_of_dired):
6765 * dispnew.c (syms_of_display):
6766 * doc.c (syms_of_doc):
6767 * editfns.c (syms_of_editfns):
6768 * emacs.c (syms_of_emacs):
6769 * eval.c (syms_of_eval):
6770 * fileio.c (syms_of_fileio):
6771 * fns.c (syms_of_fns):
6772 * frame.c (syms_of_frame):
6773 * fringe.c (syms_of_fringe):
6774 * insdel.c (syms_of_insdel):
6775 * keymap.c (syms_of_keymap):
6776 * lread.c (init_obarray, syms_of_lread):
6777 * macros.c (syms_of_macros):
6778 * msdos.c (syms_of_msdos):
6779 * print.c (syms_of_print):
6780 * process.c (syms_of_process):
6781 * search.c (syms_of_search):
6782 * sound.c (syms_of_sound):
6783 * syntax.c (init_syntax_once, syms_of_syntax):
6784 * terminal.c (syms_of_terminal):
6785 * textprop.c (syms_of_textprop):
6786 * undo.c (syms_of_undo):
6787 * w32.c (globals_of_w32):
6788 * window.c (syms_of_window):
6789 * xdisp.c (syms_of_xdisp):
6790 * xfaces.c (syms_of_xfaces):
6791 * xfns.c (syms_of_xfns):
6792 * xmenu.c (syms_of_xmenu):
6793 * xsettings.c (syms_of_xsettings):
6794 * xterm.c (syms_of_xterm): Use DEFSYM.
6795
4228cf16
TZ
67962011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6797
cd3520a4 6798 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 6799
7fcccf1e
PE
68002011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6801
7efb4e0e
PE
6802 Integer and buffer overflow fixes (Bug#8873).
6803
ff5844ad
PE
6804 * print.c (printchar, strout): Check for string overflow.
6805 (PRINTPREPARE, printchar, strout):
6806 Don't set size unless allocation succeeds.
6807
90532f02
PE
6808 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6809 for sizes. Check for string overflow more accurately.
6810 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6811
6d84508d
PE
6812 * macros.c: Integer and buffer overflow fixes.
6813 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6814 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6815 Use ptrdiff_t, not int, for sizes.
6816 Don't increment bufsize until after realloc succeeds.
6817 Check for size-calculation overflow.
6818 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6819
437b2cb4
PE
6820 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6821
8b9ac8b4
PE
6822 * lread.c: Integer overflow fixes.
6823 (read_integer): Radix is now EMACS_INT, not int,
6824 to improve quality of diagnostics for out-of-range radices.
6825 Calculate buffer size correctly for out-of-range radices.
6826 (read1): Check for integer overflow in radices, and in
6827 read-circle numbers.
82cb60d3
PE
6828 (read_escape): Avoid int overflow.
6829 (Fload, openp, read_buffer_size, read1)
6830 (substitute_object_recurse, read_vector, read_list, map_obarray):
6831 Use ptrdiff_t, not int, for sizes.
6832 (read1): Use EMACS_INT, not int, for sizes.
20270765 6833 Check for size overflow.
8b9ac8b4 6834
7fcccf1e
PE
6835 * image.c (cache_image): Check for size arithmetic overflow.
6836
bfbbd7e7
PE
6837 * lread.c: Integer overflow issues.
6838 (saved_doc_string_size, saved_doc_string_length)
6839 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6840 Now ptrdiff_t, not int.
6841 (read1): Don't assume doc string length fits in int. Check for
6842 out-of-range doc string lengths.
6843 (read_list): Don't assume file position fits in int.
39019e54 6844 (read_escape): Check for hex character overflow.
bfbbd7e7 6845
4e323265
LL
68462011-06-22 Leo Liu <sdl.web@gmail.com>
6847
6848 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6849 Move to minibuffer.el.
6850
85fece3e
PE
68512011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6852
20b84ce9 6853 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
6854 The following patches are for when GLYPH_DEBUG && !XASSERT.
6855 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6856 * dispnew.c (flush_stdout):
6857 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6858 Mark as externally visible.
6859 * dispnew.c (check_window_matrix_pointers): Now static.
6860 * dispnew.c (window_to_frame_vpos):
6861 * xfns.c (unwind_create_frame):
6862 * xterm.c (x_check_font): Remove unused local.
6863 * scroll.c (CHECK_BOUNDS):
6864 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6865 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6866 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6867 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6868 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6869 Now static.
6870 (debug_method_add): Use va_list and vsprintf rather than relying
6871 on undefined behavior with wrong number of arguments.
6872 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6873 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6874 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6875 since we're not interested in debugging glyphs with old libraries.
6876 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6877 GCC 4.6.0's static checking.
6878
0766b489
PE
68792011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6880
31fd4b32
PE
6881 Integer overflow and signedness fixes (Bug#8873).
6882 A few related buffer overrun fixes, too.
6883
b79e8648
PE
6884 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6885
0766b489
PE
6886 * dispextern.h (struct face.stipple):
6887 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6888 (x_bitmap_mask, x_allocate_bitmap_record)
6889 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6890 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6891 (x_create_bitmap_from_xpm_data):
6892 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6893 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6894 (.bitmaps_last):
6895 * xfaces.c (load_pixmap):
6896 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6897 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6898 (.bitmaps_last, struct x_output.icon_bitmap):
6899 Use ptrdiff_t, not int, for bitmap indexes.
6900 (x_allocate_bitmap_record): Check for size overflow.
6901 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6902
b081724f
PE
6903 Use ptrdiff_t, not int, for overlay counts.
6904 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6905 * editfns.c (overlays_around, get_pos_property):
6906 * textprop.c (get_char_property_and_overlay):
6907 * xdisp.c (next_overlay_change, note_mouse_highlight):
6908 * xfaces.c (face_at_buffer_position):
21514da7
PE
6909 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6910 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6911 (Fnext_overlay_change, Fprevious_overlay_change)
6912 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 6913 Use ptrdiff_t, not int, for sizes.
21514da7 6914 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 6915
3de73e5e
PE
6916 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6917
2606c57b
PE
6918 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6919 (x_session_initialize): Do not assume string length fits in int.
6920
aaafe47a
PE
6921 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6922 This is unlikely, but can occur if DPI is outlandish.
6923
2674ddc8 6924 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
6925 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6926
28154962
PE
6927 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6928 * xrdb.c (magic_file_p, search_magic_path):
6929 Omit last arg SUFFIX; it was always 0. All callers changed.
6930 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6931
7de51af5
PE
6932 * xfont.c (xfont_match): Avoid need for strlen.
6933
25ed6cc3
PE
6934 * xfns.c: Don't assume strlen fits in int.
6935 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6936
4eab31dd
PE
6937 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6938 not unsigned long, as we prefer signed integers. All callers changed.
6939 Detect integer overflow in repeat count.
6940 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 6941 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 6942
171e2a58
PE
6943 * termcap.c: Don't assume sizes fit in int and never overflow.
6944 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6945 (gobble_line): Check for size-calculation overflow.
6946
ad39faca 6947 * minibuf.c (Fread_buffer):
6e5bb2dc 6948 * lread.c (intern, intern_c_string):
74ca2eb3
PE
6949 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6950 Don't assume string length fits in int.
6951
52c61c22 6952 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
6953 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6954
b5b8c9e5
PE
6955 * font.c: Don't assume string length fits in int.
6956 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6957 Use ptrdiff_t, not int.
ccd6111c
PE
6958 (font_intern_prop): Don't assume string length fits in int.
6959 Don't assume integer property fits in fixnum.
6960 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 6961
882f0d81 6962 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 6963 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
6964 Reformulate so as not to need the command string.
6965 Invoke gzip -cd rather than gunzip, as it's more portable.
6966 (lock_info_type, lock_file_1, lock_file):
6967 Don't assume pid_t and time_t fit in unsigned long.
6968 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6969 (current_lock_owner): Prefer signed type for sizes.
6970 Use memcpy, not strncpy, where memcpy is what is really wanted.
6971 Don't assume (via atoi) that time_t and pid_t fit in int.
6972 Check for time_t and/or pid_t out of range, e.g., via a network share.
6973 Don't alloca where an auto var works fine.
6974
93f4cf88
PE
6975 * fileio.c: Fix some integer overflow issues.
6976 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6977 Don't assume string length fits in int.
6978 (directory_file_name): Don't assume string length fits in long.
6979 (make_temp_name): Don't assume pid fits in int, or that its print
6980 length is less than 20.
6981
f3e92b69
PE
6982 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6983
1bfdaf10
PE
6984 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6985
35016e9a
PE
6986 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6987
3d1e65a1
PE
6988 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6989 We prefer signed integers, even for size calculations.
6990
0b963a93
PE
6991 * emacs.c: Don't assume string length fits in 'int'.
6992 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6993 (main): Don't invoke strlen when not needed.
6994
573f4b54
PE
6995 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6996 (XD_DEBUG_MESSAGE): Don't waste a byte.
6997
989f33ba
PE
6998 * callproc.c (getenv_internal_1, getenv_internal)
6999 (Fgetenv_internal):
965d34eb
PE
7000 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7001
e4d29b33
PE
7002 * lread.c (invalid_syntax): Omit length argument.
7003 All uses changed. This doesn't fix a bug, but it simplifies the
7004 code away from its former Hollerith-constant appearance, and it's
7005 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7006 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7007
eb49b136
PE
7008 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7009 This didn't break anything, but it didn't help either.
7010 It's confusing to put a bogus integer in a place where the actual
7011 value does not matter.
9f62aeb1 7012 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7013 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7014
15375a22
PE
7015 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7016 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7017 implementation.
b61cc01c
PE
7018 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7019 We prefer signed types, and the value cannot exceed the EMACS_INT
7020 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7021 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7022 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7023 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7024
53b2623d
PE
7025 * indent.c (sane_tab_width): New function.
7026 (current_column, scan_for_column, Findent_to, position_indentation)
7027 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7028 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7029
51cab52b 7030 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7031
f2ed8a70
PE
7032 * lisp.h (lint_assume): New macro.
7033 * composite.c (composition_gstring_put_cache):
7034 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7035
abe80cc6
PE
7036 * editfns.c, insdel.c:
7037 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7038
b02c740e
PE
7039 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7040
ebc96716
PE
7041 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7042
b4e50fa0 7043 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7044 Use much-faster test for byte-length change.
311d5d7c 7045 Don't assume string byte-length fits in 'int'.
a4cf38e4 7046 Check that character arg fits in 'int'.
85461888 7047 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7048
c0c1ee9f
PE
7049 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7050
a498d7f4
PE
7051 * fns.c (concat): Catch string overflow earlier.
7052 Do not rely on integer wraparound.
7053
51cab52b
PE
7054 * dispextern.h (struct it.overlay_strings_charpos)
7055 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7056 * xdisp.c (forward_to_next_line_start)
7057 (back_to_previous_visible_line_start)
7058 (reseat_at_next_visible_line_start, next_element_from_buffer):
7059 Don't arbitrarily truncate the value of 'selective' to int.
7060
76031fad
PE
7061 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7062
5eb55db9
PE
7063 * composite.c: Don't truncate sizes to 'int'.
7064 (composition_gstring_p, composition_reseat_it)
7065 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7066 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7067 not EMACS_UINT, for indexes.
5eb55db9 7068
0703a717
PE
7069 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7070
d6202519
PE
7071 * buffer.c: Include <verify.h>.
7072 (struct sortvec.priority, struct sortstr.priority):
8961a454 7073 Now EMACS_INT, not int.
c20998a7 7074 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7075 (struct sortstr.size, record_overlay_string)
7076 (struct sortstrlist.size, struct sortlist.used):
7077 Don't truncate size to int.
7078 (record_overlay_string): Check for size-calculation overflow.
d6202519 7079 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7080
d5a19415
JM
70812011-06-22 Jim Meyering <meyering@redhat.com>
7082
029529ac 7083 Don't leak an XBM-image-sized buffer
d5a19415
JM
7084 * image.c (xbm_load): Free the image buffer after using it.
7085
a9041e6c
PE
70862011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7087
7088 Port to Sun C.
7089 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7090 that Sun C diagnosed.
7091 * fns.c (secure_hash): Fix pointer signedness issue.
7092 * intervals.c (static_offset_intervals): New function.
7093 (offset_intervals): Use it.
7094
7f3f739f
LL
70952011-06-21 Leo Liu <sdl.web@gmail.com>
7096
7097 * deps.mk (fns.o):
7098 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7099 sha512.h.
7100
7101 * fns.c (secure_hash): Rename from crypto_hash_function and change
7102 the first arg to accept symbols.
5b66d427 7103 (Fsecure_hash): New primitive.
7f3f739f
LL
7104 (syms_of_fns): New symbols.
7105
76147d94
DD
71062011-06-20 Deniz Dogan <deniz@dogan.se>
7107
7108 * process.c (Fset_process_buffer): Clarify return value in
7109 docstring.
7110
7d7d0045
CY
71112011-06-18 Chong Yidong <cyd@stupidchicken.com>
7112
7113 * dispnew.c (add_window_display_history): Use BVAR.
7114
7115 * xdisp.c (debug_method_add): Use BVAR.
7116 (check_window_end, dump_glyph_matrix, dump_glyph)
7117 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7118
7119 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7120 Likewise.
7121
7122 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7123 check till after the cache is created in init_frame_faces.
7124
ff2bc410
SM
71252011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7126
7127 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7128
28177add
PE
71292011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7130
dd3482fe
PE
7131 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7132 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7133 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7134
393d71f3 7135 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7136 * fileio.c (Finsert_file_contents):
7137 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7138 Remove the old (too-loose) buffer overflow checks.
7139 They weren't needed, since make_gap checks for buffer overflow.
7140 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7141 The old code merely checked for Emacs fixnum overflow, and relied
7142 on undefined (wraparound) behavior. The new code avoids undefined
7143 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7144
2e6813b0 7145 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7146 Tune. Don't use wider integers than needed. Don't use alloca.
7147 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7148
599a9e4f
PE
7149 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7150
99561444
PE
7151 * insdel.c, lisp.h (buffer_overflow): New function.
7152 (insert_from_buffer_1, replace_range, replace_range_2):
7153 * insdel.c (make_gap_larger):
7154 * editfns.c (Finsert_char):
7155 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7156
28177add
PE
7157 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7158
e69dafad
PE
71592011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7160
4baa020d 7161 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7162
b1c46f02
PE
7163 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7164 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7165
e69dafad
PE
7166 * fileio.c: Don't assume EMACS_INT fits in off_t.
7167 (emacs_lseek): New static function.
7168 (Finsert_file_contents, Fwrite_region): Use it.
7169 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7170
566684ea
PE
7171 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7172
e6966cd6
PE
7173 * fns.c: Don't overflow int when computing a list length.
7174 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7175 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7176 truncation on 64-bit hosts. Check for QUIT every
7177 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7178 faster and is responsive enough.
7179 (Flength): Report an error instead of overflowing an integer.
7180 (Fsafe_length): Return a float if the value is not representable
7181 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7182 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7183 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7184
dd0b0efb
PE
7185 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7186 (header_size, word_size): New constants.
7187 (allocate_vectorlike): Don't check size overflow here.
7188 (allocate_vector): Check it here instead, since this is the only
7189 caller of allocate_vectorlike that could cause overflow.
7190 Check that the new vector's length is representable as a fixnum.
7191
86fe5cfe
PE
7192 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7193 The previous code was bogus. For example, next_almost_prime (32)
7194 returned 39, which is undesirable as it is a multiple of 3; and
7195 next_almost_prime (24) returned 25, which is a multiple of 5 so
7196 why was the code bothering to check for multiples of 7?
7197
80e88859
PE
7198 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7199
4a2f0ad6
PE
7200 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7201
f66c7cf8
PE
7202 Variadic C functions now count arguments with ptrdiff_t.
7203 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7204 Back then I didn't know that the Emacs coding style prefers signed int.
7205 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7206 were being counted with int, which may truncate counts on 64-bit
7207 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7208 * lisp.h (struct Lisp_Subr.function.aMANY)
7209 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7210 Arg counts are now ptrdiff_t, not size_t.
7211 All variadic functions and their callers changed accordingly.
7212 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7213 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7214 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7215 * callint.c (Fcall_interactively): Check arg count for overflow,
7216 to avoid potential buffer overrun. Use signed char, not 'int',
7217 for 'varies' array, so that we needn't bother to check its size
7218 calculation for overflow.
7219 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7220 * eval.c (apply_lambda):
7221 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7222 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7223 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7224
a1759b76
PE
7225 * callint.c (Fcall_interactively): Don't use index var as event count.
7226
d96be9fc
PE
7227 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7228 * mem-limits.h (SIZE): Remove; no longer used.
7229
a690a978 7230 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7231
578c21e6
PE
7232 Remove unnecessary casts.
7233 * xterm.c (x_term_init):
7234 * xfns.c (x_set_border_pixel):
7235 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7236 These aren't needed now that we assume ANSI C.
7237
96f53c6c
PE
7238 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7239 It's more likely to cause problems (due to unsigned overflow)
7240 than to cure them.
7241
83c77d31
PE
7242 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7243
ee2079f1
PE
7244 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7245
6da65536
PE
7246 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7247
7147c4a4
PE
7248 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7249
193e32d9
PE
7250 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7251
e5533da6
PE
7252 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7253
9910e595
PE
7254 GLYPH_CODE_FACE returns EMACS_INT, not int.
7255 * dispextern.h (merge_faces):
7256 * xfaces.c (merge_faces):
01103c44
PE
7257 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7258 Don't assume EMACS_INT fits in int.
9910e595 7259
2638320e
PE
7260 * character.h (CHAR_VALID_P): Remove unused parameter.
7261 * fontset.c, lisp.h, xdisp.c: All uses changed.
7262
045eb8d9
PE
7263 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7264
c1f134b5
PE
7265 * fns.c (concat): Minor tuning based on overflow analysis.
7266 This doesn't fix any bugs. Use int to hold character, instead
7267 of constantly refetching from Emacs object. Use XFASTINT, not
7268 XINT, for value known to be a character. Don't bother comparing
7269 a single byte to 0400, as it's always less.
7270
395fcb93 7271 * floatfns.c (Fexpt):
327eeec8
PE
7272 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7273
abbd3d23
PE
7274 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7275 for characters.
7276
684a03ef
PE
7277 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7278
0fed43f3
PE
7279 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7280 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7281 incorrectly succeed when S was a string, because 4294967386 was
7282 truncated before it was used.
7283
8fd02eb7
PE
7284 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7285 Otherwise, an out-of-range integer could cause undefined behavior
7286 on a 64-bit host.
7287
f8c86b69
PE
7288 * composite.c: Use int, not EMACS_INT, for characters.
7289 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7290 EMACS_INT, for values that are known to be in character range.
7291 This doesn't fix any bugs but is the usual style inside Emacs and
7292 may generate better code on 32-bit machines.
7293
34206dd2
PE
7294 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7295 This is for reasons similar to the recent CHAR_STRING fix.
7296 * charset.c (Fencode_char): Check that character arg is actually
7297 a character. Pass an int to ENCODE_CHAR.
7298 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7299 wider than 'int', as a compile-time check to prevent future regressions
7300 in this area.
7301
c5958d4c 7302 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7303
7304 Make sure a 64-bit char is never passed to CHAR_STRING.
7305 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7306 by silently ignoring the top 32 bits, allowing some values
7307 that were far too large to be valid characters.
7308 * character.h: Include <verify.h>.
7309 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7310 arguments are no wider than unsigned, as a compile-time check
7311 to prevent future regressions in this area.
7312 * data.c (Faset):
01103c44 7313 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7314 (Fsubst_char_in_region):
7315 * fns.c (concat):
7316 * xdisp.c (decode_mode_spec_coding):
7317 Adjust to CHAR_STRING's new requirement.
7318 * editfns.c (Finsert_char, Fsubst_char_in_region):
7319 * fns.c (concat): Check that character args are actually
7320 characters. Without this test, these functions did the wrong
7321 thing with wildly out-of-range values on 64-bit hosts.
7322
d37ca623
PE
7323 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7324 These casts should not be needed on 32-bit hosts, either.
7325 * keyboard.c (read_char):
7326 * lread.c (Fload): Remove casts to unsigned.
7327
ea204efb
PE
7328 * lisp.h (UNSIGNED_CMP): New macro.
7329 This fixes comparison bugs on 64-bit hosts.
7330 (ASCII_CHAR_P): Use it.
7331 * casefiddle.c (casify_object):
01103c44 7332 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7333 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7334 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7335 * dispextern.h (FACE_FROM_ID):
7336 * keyboard.c (read_char): Use UNSIGNED_CMP.
7337
41cb286c
PE
7338 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7339 not to EMACS_INT, to avoid GCC warning.
7340
4a1b9832
PE
7341 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7342
55daad71
PE
7343 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7344 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7345 isn't needed on 32-bit machines.
8f95c75c 7346
01103c44
PE
7347 * buffer.c (Fgenerate_new_buffer_name):
7348 Use EMACS_INT for count, not int.
0ceccced 7349 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7350
7351 * data.c (Qcompiled_function): Now static.
7352
c6f072e7
PE
7353 * window.c (window_body_lines): Now static.
7354
20ce5912
PE
7355 * image.c (gif_load): Rename local to avoid shadowing.
7356
9c4c5f81
PE
7357 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7358 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7359 * alloc.c (make_save_value): Integer argument is now of type
7360 ptrdiff_t, not int.
7361 (mark_object): Use ptrdiff_t, not int.
7362 * lisp.h (pD): New macro.
7363 * print.c (print_object): Use it.
7364
c0c5c8ae
PE
7365 * alloc.c: Use EMACS_INT, not int, to count objects.
7366 (total_conses, total_markers, total_symbols, total_vector_size)
7367 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7368 (total_free_floats, total_floats, total_free_intervals)
7369 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7370 Now EMACS_INT, not int. All uses changed.
7371 (Fgarbage_collect): Compute overall total using a double, so that
7372 integer overflow is less likely to be a problem. Check for overflow
7373 when converting back to an integer.
5a25e253
PE
7374 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7375 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7376 These were 'int' variables that could overflow on 64-bit hosts;
7377 they were never used, so remove them instead of repairing them.
211a0b2a 7378 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7379 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7380 Previously, this ceilinged at INT_MAX, but that doesn't work on
7381 64-bit machines.
e46bb31a 7382 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7383
c78baabf 7384 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7385 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7386 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7387 when a (possibly-narrower) signed value would do just as well.
7388 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7389
c9d624c6
PE
7390 * alloc.c: Catch some string size overflows that we were missing.
7391 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7392 for convenience in STRING_BYTES_MAX.
7393 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7394 The definition here is exact; the one in lisp.h was approximate.
7395 (allocate_string_data): Check for string overflow. This catches
7396 some instances we weren't catching before. Also, it catches
7397 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7398 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7399 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7400
c9d624c6
PE
7401 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7402 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7403 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7404
353032ce
PE
7405 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7406
2bccce07
PE
7407 * alloc.c (Fmake_string): Check for out-of-range init.
7408
0ac30604
SM
74092011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7410
7411 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7412
c195f2de
JD
74132011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7414
7415 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7416 xg_get_default_scrollbar_width.
7417
7418 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7419 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7420 (style_changed_cb): Call update_theme_scrollbar_width and call
7421 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7422 all frames (Bug#8505).
7423 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7424 Call gtk_window_set_resizable if HAVE_GTK3.
7425 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7426 and height if HAVE_GTK3 (Bug#8505).
7427 (scroll_bar_width_for_theme): New variable.
7428 (update_theme_scrollbar_width): New function.
7429 (xg_get_default_scrollbar_width): Move code to
7430 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7431 (xg_initialize): Call update_theme_scrollbar_width.
7432
7433 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7434
7435 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7436
e10ac9f1
MR
74372011-06-12 Martin Rudalics <rudalics@gmx.at>
7438
7439 * frame.c (make_frame): Call other_buffer_safely instead of
7440 other_buffer.
7441
7442 * window.c (temp_output_buffer_show): Call display_buffer with
7443 second argument Vtemp_buffer_show_specifiers and reset latter
7444 immediately after the call.
7445 (Vtemp_buffer_show_specifiers): New variable.
7446 (auto_window_vscroll_p, next_screen_context_lines)
7447 (Vscroll_preserve_screen_position): Remove leading asterisks from
7448 doc-strings.
7449
2d3c217e 74502011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7451
7b7f97e8 7452 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7453 * buffer.c (Qclone_number): Remove for now, as it's unused.
7454 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7455 (record_buffer): Remove unused local.
7456 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7457 (set_frame_buffer_list): Remove; unused.
7458 * frame.h (other_visible_frames): Remove decl.
7459 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7460 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7461 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7462 if HAVE_GPM.
7463 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7464 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7465 Define only if HAVE_GPM.
7466 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7467 (update_hints_inhibit): Remove; never set. All uses removed.
7468 * widgetprv.h (emacsFrameClassRec): Remove decl.
7469 * window.c (delete_deletable_window): Now returns void, since it
7470 wasn't returning anything.
7471 (compare_window_configurations): Remove unused locals.
7472 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7473 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7474 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7475 the same widths as pointers. This follows up on the 2011-05-06 patch.
7476 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7477 * xterm.h: Likewise.
7478 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7479
1384b89e
JB
74802011-06-12 Juanma Barranquero <lekktu@gmail.com>
7481
7482 * makefile.w32-in: Update dependencies.
7483 (LISP_H): Add lib/intprops.h.
7484
1100a63c
CY
74852011-06-11 Chong Yidong <cyd@stupidchicken.com>
7486
7487 * image.c (gif_load): Add animation frame delay to the metadata.
7488 (syms_of_image): Use DEFSYM. New symbol `delay'.
7489
6198ccd0
MR
74902011-06-11 Martin Rudalics <rudalics@gmx.at>
7491
7492 * window.c (delete_deletable_window): Re-add.
7493 (Fset_window_configuration): Rewrite to handle dead buffers and
7494 consequently deletable windows.
7495 (window_tree, Fwindow_tree): Remove. Supply functionality in
7496 window.el.
7497 (compare_window_configurations): Simplify code.
7498
b6e3633c
AS
74992011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7500
1ab0dee5
AS
7501 * image.c (imagemagick_load_image): Fix type mismatch.
7502 (Fimagemagick_types): Likewise.
7503
b6e3633c
AS
7504 * window.h (replace_buffer_in_windows): Declare.
7505
9397e56f
MR
75062011-06-11 Martin Rudalics <rudalics@gmx.at>
7507
7508 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7509 Qclone_number. Remove external declaration of Qdelete_window.
7510 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7511 code.
640c8776
SM
7512 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7513 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7514 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7515 buffer list implementation.
7516 (other_buffer_safely): New function.
7517 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7518 calls to replace_buffer_in_windows and
7519 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7520 if allowed.
7521 (record_buffer): Inhibit quitting and rewrite using quittable
7522 functions. Run Qbuffer_list_update_hook if allowed.
7523 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7524 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7525 Move switch-to-buffer to window.el.
9397e56f
MR
7526 (bury-buffer): Move to window.el.
7527 (Vbuffer_list_update_hook): New variable.
7528
7529 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7530 section.
7531
7532 * window.h (resize_frame_windows): Move up in code.
7533 (Fwindow_frame): Remove EXFUN.
7534 (replace_buffer_in_all_windows): Remove prototype.
7535 (replace_buffer_in_windows_safely): Add prototype.
7536
7537 * window.c: Declare Qdelete_window static again. Move down
7538 declaration of select_count.
7539 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7540 (Fother_window): Move to window.el.
7541 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7542 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7543 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7544 window.el.
7545 (replace_buffer_in_windows): Implement by calling
7546 Qreplace_buffer_in_windows.
7547 (replace_buffer_in_all_windows): Remove with some functionality
7548 moved into replace_buffer_in_windows_safely.
7549 (replace_buffer_in_windows_safely): New function.
7550 (select_window_norecord, select_frame_norecord): Move in front
7551 of run_window_configuration_change_hook. Remove now obsolete
7552 declarations.
640c8776
SM
7553 (Fset_window_buffer): Rewrite doc-string.
7554 Call Qrecord_window_buffer.
9397e56f
MR
7555 (keys_of_window): Move binding for other-window to window.el.
7556
b50691aa
CY
75572011-06-11 Chong Yidong <cyd@stupidchicken.com>
7558
7559 * dispextern.h (struct image): Replace data member, whose int_val
7560 and ptr_val fields were not used by anything, with a single
7561 lisp_val object.
7562
7563 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7564 (gif_clear_image, gif_load, imagemagick_load_image)
7565 (gs_clear_image, gs_load): Callers changed.
7566
3f754b86
PE
75672011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7568
cca69397
PE
7569 * buffer.h: Include <time.h>, for time_t.
7570 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7571
109e28d0
PE
7572 Fix minor problems found by static checking.
7573
60737f02
PE
7574 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7575
4b66faf3
PE
7576 Make identifiers static if they are not used in other modules.
7577 * data.c (Qcompiled_function, Qframe, Qvector):
7578 * image.c (QimageMagick, Qsvg):
7579 * minibuf.c (Qmetadata):
7580 * window.c (resize_window_check, resize_root_window): Now static.
7581 * window.h (resize_window_check, resize_root_window): Remove decls.
7582
109e28d0
PE
7583 * window.c (window_deletion_count, delete_deletable_window):
7584 Remove; unused.
46a4ce9e
PE
7585 (window_body_lines): Now static.
7586 (Fdelete_other_windows_internal): Mark vars as initialized.
7587 Make sure 'resize_failed' is initialized.
7588 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7589 (resize_window_apply): Remove unused local.
7590 * window.h (delete_deletable_window): Remove decl.
7591
109e28d0 7592 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
7593 (imagemagick_load_image): Fix pointer signedness problem by changing
7594 last arg from unsigned char * to char *. All uses changed.
7595 Also, fix a local for similar reasons.
7596 Remove unused locals. Remove locals to avoid shadowing.
7597 (fn_rsvg_handle_free): Remove; unused.
7598 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 7599 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 7600
3f754b86
PE
7601 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7602
2547adb1
CY
76032011-06-10 Chong Yidong <cyd@stupidchicken.com>
7604
7605 * image.c (gif_load): Fix omitted cast error introduced by
7606 2011-06-06 change.
7607
2c8e37d4
MR
76082011-06-10 Martin Rudalics <rudalics@gmx.at>
7609
7610 * window.h (resize_proportionally, orig_total_lines)
7611 (orig_top_line): Remove from window structure.
7612 (set_window_height, set_window_width, change_window_heights)
7613 (Fdelete_window): Remove prototypes.
7614 (resize_frame_windows): Remove duplicate declaration.
7615
440a42e3
EZ
76162011-06-10 Eli Zaretskii <eliz@gnu.org>
7617
7618 * window.h (resize_frame_windows, resize_window_check)
7619 (delete_deletable_window, resize_root_window)
7620 (resize_frame_windows): Declare prototypes.
7621
7622 * window.c (resize_window_apply): Make definition be "static" to
7623 match the prototype.
7624
562dd5e9
MR
76252011-06-10 Martin Rudalics <rudalics@gmx.at>
7626
7627 * window.c: Remove declarations of Qwindow_size_fixed,
7628 window_min_size_1, window_min_size_2, window_min_size,
7629 size_window, window_fixed_size_p, enlarge_window, delete_window.
7630 Remove static from declaration of Qdelete_window, it's
7631 temporarily needed by Fbury_buffer.
7632 (replace_window): Don't assign orig_top_line and
7633 orig_total_lines.
7634 (Fdelete_window, delete_window): Remove. Window deletion is
7635 handled by window.el.
640c8776
SM
7636 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7637 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
7638 (Fdelete_other_windows): Remove. Deleting other windows is
7639 handled by window.el.
7640 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7641 handled in window.el.
7642 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7643 Window minimum sizes are handled in window.el.
7644 (shrink_windows, size_window, set_window_height)
7645 (set_window_width, change_window_heights, window_height)
7646 (window_width, CURBEG, CURSIZE, enlarge_window)
7647 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7648 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7649 handled in window.el.
7650 (make_dummy_parent): Rename to make_parent_window and give it a
7651 second argument horflag.
7652 (make_window): Don't set resize_proportionally any more.
7653 (Fsplit_window): Remove. Windows are split in window.el.
7654 (save_restore_action, save_restore_orig_size)
7655 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7656 Resize mini windows in window.el.
7657 (grow_mini_window, shrink_mini_window): Implement by calling
7658 Qresize_root_window_vertically, resize_window_check and
7659 resize_window_apply.
640c8776
SM
7660 (saved_window, Fset_window_configuration, save_window_save):
7661 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
7662 resize_proportionally.
7663 (window_min_height, window_min_width): Move to window.el.
7664 (keys_of_window): Move bindings for delete-other-windows,
7665 split-window, delete-window and enlarge-window to window.el.
7666
7667 * buffer.c: Temporarily extern Qdelete_window.
7668 (Fbury_buffer): Temporarily call Qdelete_window instead of
7669 Fdelete_window (Fbury_buffer will move to window.el soon).
7670
7671 * frame.c (set_menu_bar_lines_1): Remove code handling
7672 orig_top_line and orig_total_lines.
7673
7674 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7675 set_window_height but set heights directly.
7676 (change_frame_size_1): Use resize_frame_windows.
7677
7678 * xdisp.c (init_xdisp): Don't use set_window_height but set
7679 heights directly.
7680
640c8776
SM
7681 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7682 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
7683 run_window_configuration_change_hook.
7684
7685 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7686 instead of change_window_heights and run
7687 run_window_configuration_change_hook.
7688
1a13852e
MR
76892011-06-09 Martin Rudalics <rudalics@gmx.at>
7690
7691 * window.c (replace_window): Rename second argument REPLACEMENT to
7692 NEW. New third argument SETFLAG. Rewrite.
7693 (delete_window, make_dummy_parent): Call replace_window with
7694 third argument 1.
7695 (window_list_1): Move down in code.
7696 (run_window_configuration_change_hook): Move set_buffer part
7697 before select_frame_norecord part in order to unwind correctly.
7698 Rename count1 to count.
7699 (recombine_windows, delete_deletable_window, resize_root_window)
7700 (Fdelete_other_windows_internal)
7701 (Frun_window_configuration_change_hook, make_parent_window)
7702 (resize_window_check, resize_window_apply, Fresize_window_apply)
7703 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
7704 (Fdelete_window_internal, Fresize_mini_window_internal):
7705 New functions.
1a13852e
MR
7706 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7707
f3d1777e
MR
77082011-06-08 Martin Rudalics <rudalics@gmx.at>
7709
496e208e
MR
7710 * window.h (window): Add some new members to window structure -
7711 normal_lines, normal_cols, new_total, new_normal, clone_number,
7712 splits, nest, prev_buffers, next_buffers.
7713 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 7714 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 7715
f3d1777e
MR
7716 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7717 Remove.
496e208e
MR
7718 (make_dummy_parent): Set new members of windows structure.
7719 (make_window): Move down in code. Handle new members of window
7720 structure.
7721 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7722 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7723 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7724 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
7725 (Fset_window_next_buffers, Fset_window_clone_number):
7726 New functions.
496e208e
MR
7727 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7728 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7729 Doc-string fixes.
7730 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7731 Argument WINDOW can be now internal window too.
7732 (Fwindow_use_time): Move up in code.
7733 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7734 Rewrite doc-string.
7735 (Fset_window_configuration, saved_window)
7736 (Fcurrent_window_configuration, save_window_save): Handle new
7737 members of window structure.
b9e809c2
MR
7738 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7739 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7740 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7741 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7742 Qget_mru_window, Qresize_root_window,
7743 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7744 Qauto_buffer_name; staticpro them.
f3d1777e 7745
abde8f8c
MR
77462011-06-07 Martin Rudalics <rudalics@gmx.at>
7747
7748 * window.c (Fwindow_total_size, Fwindow_left_column)
7749 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7750 (Fwindow_list_1): New functions.
7751 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
7752 (Fwindow_width, Fscroll_left, Fscroll_right):
7753 Use window_body_cols instead of window_box_text_cols.
7754 (delete_window, Fset_window_configuration):
7755 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
7756 (delete_all_subwindows): Take a window as argument and not a
7757 structure. Rewrite.
190b47e6
MR
7758 (window_loop): Remove handling of GET_LRU_WINDOW and
7759 GET_LARGEST_WINDOW.
7760 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
7761
7762 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
7763 window_box_text_cols. delete_all_subwindows now takes a
7764 Lisp_Object as argument.
abde8f8c 7765
640c8776
SM
7766 * indent.c (compute_motion, Fcompute_motion):
7767 Use window_body_cols instead of window_box_text_cols.
abde8f8c 7768
fa8a67e6
MR
7769 * frame.c (delete_frame): Call delete_all_subwindows with root
7770 window as argument.
7771
a54e3482
DC
77722011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7773
7774 * fns.c (Fputhash): Document return value.
7775
60002bf5
CY
77762011-06-06 Chong Yidong <cyd@stupidchicken.com>
7777
7778 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7779
0c671da6 77802011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 7781
b862a52a 7782 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 7783
be44ca6c
PE
7784 Check for overflow when converting integer to cons and back.
7785 * charset.c (Fdefine_charset_internal, Fdecode_char):
7786 Use cons_to_unsigned to catch overflow.
7787 (Fencode_char): Use INTEGER_TO_CONS.
7788 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7789 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7790 * data.c (long_to_cons, cons_to_long): Remove.
7791 (cons_to_unsigned, cons_to_signed): New functions.
7792 These signal an error for invalid or out-of-range values.
7793 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7794 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7795 * font.c (Ffont_variation_glyphs):
7796 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7797 * lisp.h: Include <intprops.h>.
7798 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7799 (cons_to_signed, cons_to_unsigned): New decls.
7800 (long_to_cons, cons_to_long): Remove decls.
7801 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7802 (Fprimitive_undo): Use CONS_TO_INTEGER.
7803 * xfns.c (Fx_window_property): Likewise.
7804 * xselect.c: Include <limits.h>.
7805 (x_own_selection, selection_data_to_lisp_data):
7806 Use INTEGER_TO_CONS.
7807 (x_handle_selection_request, x_handle_selection_clear)
7808 (x_get_foreign_selection, Fx_disown_selection_internal)
7809 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7810 (lisp_data_to_selection_data): Use cons_to_unsigned.
7811 (x_fill_property_data): Use cons_to_signed.
7812 Report values out of range.
7813
d1f3d2af
PE
7814 Check for buffer and string overflow more precisely.
7815 * buffer.h (BUF_BYTES_MAX): New macro.
7816 * lisp.h (STRING_BYTES_MAX): New macro.
7817 * alloc.c (Fmake_string):
7818 * character.c (string_escape_byte8):
7819 * coding.c (coding_alloc_by_realloc):
7820 * doprnt.c (doprnt):
7821 * editfns.c (Fformat):
7822 * eval.c (verror):
7823 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7824 since they may not be the same number.
7825 * editfns.c (Finsert_char):
7826 * fileio.c (Finsert_file_contents):
7827 Likewise for BUF_BYTES_MAX.
7828
dd52fcea
PE
7829 * image.c: Use ptrdiff_t, not int, for sizes.
7830 (slurp_file): Switch from int to ptrdiff_t.
7831 All uses changed.
7832 (slurp_file): Check that file size fits in both size_t (for
7833 malloc) and ptrdiff_t (for sanity and safety).
7834
7f9bbdbb
PE
7835 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7836 if b->modtime has its maximal value.
7837
dfe18f82
PE
7838 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7839
84acfcf0
PE
7840 Don't assume time_t can fit into int.
7841 * buffer.h (struct buffer.modtime): Now time_t, not int.
7842 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7843 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7844
ccd9a01a
PE
7845 Minor fixes for signed vs unsigned integers.
7846 * character.h (MAYBE_UNIFY_CHAR):
7847 * charset.c (maybe_unify_char):
7848 * keyboard.c (read_char, reorder_modifiers):
7849 XINT -> XFASTINT, since the integer must be nonnegative.
7850 * ftfont.c (ftfont_spec_pattern):
7851 * keymap.c (access_keymap, silly_event_symbol_error):
7852 XUINT -> XFASTINT, since the integer must be nonnegative.
7853 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7854 since it makes no difference and we prefer signed.
7855 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7856 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7857 nonnegative.
7858
d6d100dd
SM
78592011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7860
7861 * window.h (Fwindow_frame): Declare.
7862
2b6148e4
PE
78632011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7864
7865 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7866 (SPARE_MEMORY): Always define.
7867 (LARGE_REQUEST): Remove.
7868 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7869
f230ecc9
MR
78702011-06-06 Martin Rudalics <rudalics@gmx.at>
7871
727e958e
MR
7872 * lisp.h: Move EXFUNS for Fframe_root_window,
7873 Fframe_first_window and Fset_frame_selected_window to window.h.
7874
7875 * window.h: Move EXFUNS for Fframe_root_window,
7876 Fframe_first_window and Fset_frame_selected_window here from
7877 lisp.h.
7878
7879 * frame.c (Fwindow_frame, Fframe_first_window)
7880 (Fframe_root_window, Fframe_selected_window)
7881 (Fset_frame_selected_window): Move to window.c.
7882 (Factive_minibuffer_window): Move to minibuf.c.
7883 (Fother_visible_frames_p): New function.
7884
7885 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7886
f230ecc9
MR
7887 * window.c (decode_window, decode_any_window): Move up in code.
7888 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7889 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
7890 (Fwindow_buffer): Move up and rewrite doc-string.
7891 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7892 (Fwindow_prev): New functions.
727e958e
MR
7893 (Fwindow_frame): Move here from frame.c. Accept any window as
7894 argument.
7895 (Fframe_root_window, Fframe_first_window)
7896 (Fframe_selected_window): Move here from frame.c. Accept frame
7897 or arbitrary window as argument. Update doc-strings.
7898 (Fminibuffer_window): Move up in code.
7899 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
7900 (Fset_frame_selected_window): Move here from frame.c.
7901 Marginal rewrite.
727e958e
MR
7902 (Fselected_window, select_window, Fselect_window): Move up in
7903 code. Minor doc-string fixes.
f230ecc9 7904
4d09bcf6
PE
79052011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7906
7907 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7908 Do not assume that spare memory exists; that assumption is valid
7909 only if SYSTEM_MALLOC.
7910 (LARGE_REQUEST): New macro, so that the issue of large requests
7911 is separated from the issue of spare memory.
7912
810928a2
AS
79132011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7914
172418ad
AS
7915 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7916 format. (Bug#8806)
7917
43f862f7
AS
7918 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7919
810928a2
AS
7920 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7921 before statements.
7922
a059fe24
JD
79232011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7924
7925 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7926
7927 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7928
7929 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7930 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7931
989bf368
JB
79322011-06-05 Juanma Barranquero <lekktu@gmail.com>
7933
7934 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7935
4b80f674
CY
79362011-06-04 Chong Yidong <cyd@stupidchicken.com>
7937
7938 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7939 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
7940 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7941 New error handlers.
4b80f674
CY
7942 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7943 Obey Vx_select_enable_clipboard_manager. Catch errors in
7944 x_clipboard_manager_save (Bug#8779).
7945 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 7946 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 7947
99a33b77 79482011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
7949
7950 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7951
99a33b77 79522011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
7953
7954 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7955 in the current matrix if keep_current_p is non-zero.
7956
8264569d
EZ
79572011-06-04 Eli Zaretskii <eliz@gnu.org>
7958
7959 * bidi.c (bidi_level_of_next_char): Fix last change.
7960
57f97249
EZ
79612011-06-03 Eli Zaretskii <eliz@gnu.org>
7962
fec2107c 7963 Support bidi reordering of text covered by display properties.
57f97249 7964
fec2107c
EZ
7965 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7966 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7967 (bidi_cache_search, bidi_cache_iterator_state)
7968 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
7969 (bidi_level_of_next_char, bidi_move_to_visually_next):
7970 Support character positions inside a run of characters covered by a
fec2107c
EZ
7971 display string.
7972 (bidi_paragraph_init, bidi_resolve_explicit_1)
7973 (bidi_level_of_next_char): Call bidi_fetch_char and
7974 bidi_fetch_char_advance instead of FETCH_CHAR and
7975 FETCH_CHAR_ADVANCE.
7976 (bidi_init_it): Initialize new members.
7977 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7978 definitions.
7979 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7980 instead of using explicit *_CHAR codes.
d6d100dd
SM
7981 (bidi_resolve_explicit, bidi_resolve_weak):
7982 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
7983 bidirectional text is supported only in multibyte buffers.
7984 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7985 it to initialize the frame_window_p member of struct bidi_it.
7986 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7987 (bidi_resolve_explicit, bidi_resolve_weak)
7988 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7989 bidi_it->nchars is non-positive.
7990 (bidi_level_of_next_char): Don't try to lookup the cache for the
7991 next/previous character if nothing is cached there yet, or if we
7992 were just reseat()'ed to a new position.
c40e2fb2 7993
0e14fe90
EZ
7994 * xdisp.c (set_cursor_from_row): Set start and stop points
7995 according to the row's direction when priming the loop that looks
7996 for the glyph on which to display cursor.
7997 (single_display_spec_intangible_p): Function deleted.
7998 (display_prop_intangible_p): Reimplement to call
7999 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8000 Accept 3 additional arguments needed by handle_display_spec.
8001 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8002 values: lists, `(when COND...)' forms, etc.
8003 (single_display_spec_string_p): Support property values that are
8004 lists with the argument STRING its top-level element.
8005 (display_prop_string_p): Fix the condition for processing a
8006 property that is a list to be consistent with handle_display_spec.
fec2107c 8007 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8008 last portion of handle_display_prop.
8009 (compute_display_string_pos): Accept additional argument
8010 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8011 value of a `display' property is a "replacing spec".
8012 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8013 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8014 the display property, but just return a value indicating whether
8015 the display property will replace the characters it covers.
8016 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8017 frame_window_p members of struct bidi_it.
d6d100dd
SM
8018 (compute_display_string_pos, compute_display_string_end):
8019 New functions.
fec2107c
EZ
8020 (push_it): Accept second argument POSITION, where pop_it should
8021 jump to continue iteration.
8022 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8023
fec2107c
EZ
8024 * keyboard.c (adjust_point_for_property): Adjust the call to
8025 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8026
8027 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8028 (bidi_init_it): Update prototypes.
8029 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8030 (compute_display_string_pos, compute_display_string_end):
8031 Declare prototypes.
fec2107c
EZ
8032 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8033 EMACS_INT.
fc6f18ce 8034
40087514 80352011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8036
57f53182
PE
8037 Malloc failure behavior now depends on size of allocation.
8038 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8039 * lisp.h: Change signatures accordingly.
8040 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8041 All callers changed. (Bug#8762)
8042
8043 * gnutls.c: Use Emacs's memory allocators.
8044 Without this change, the gnutls library would invoke malloc etc.
8045 directly, which causes problems on non-SYNC_INPUT hosts, and which
8046 runs afoul of improving memory_full behavior. (Bug#8761)
8047 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8048 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8049 xfree instead of the default malloc, realloc, free.
8050 (Fgnutls_boot): No need to check for memory allocation failure,
8051 since xmalloc does that for us.
8052
ac32cd99 8053 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8054 * category.c (hash_get_category_set):
8055 * ccl.c (ccl_driver):
8056 * charset.c (Fdefine_charset_internal):
8057 * charset.h (struct charset.hash_index):
8058 * composite.c (get_composition_id, gstring_lookup_cache)
8059 (composition_gstring_put_cache):
8060 * composite.h (struct composition.hash_index):
8061 * dispextern.h (struct image.hash):
8062 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8063 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8064 (hashfn_equal, hashfn_user_defined, make_hash_table)
8065 (maybe_resize_hash_table, hash_lookup, hash_put)
8066 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8067 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8068 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8069 * image.c (make_image, search_image_cache, lookup_image)
8070 (xpm_put_color_table_h):
8071 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8072 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8073 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8074 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8075 * alloc.c (allocate_vectorlike):
8076 Check for overflow in vector size calculations.
8077 * ccl.c (ccl_driver):
8078 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8079 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8080 need to be updated by these changes.
40087514
PE
8081 * fns.c (make_hash_table, maybe_resize_hash_table):
8082 Check for integer overflow with large hash tables.
0de4bb68
PE
8083 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8084 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8085 (SXHASH_REDUCE): New macro.
8086 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8087 Use it instead of discarding useful hash info with large hash values.
8088 (sxhash_float): New function.
8089 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8090 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8091 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8092 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8093 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8094 Adjust signatures to match updated version of code.
8095 (consing_since_gc): Now EMACS_INT, since a single hash table can
8096 use more than INT_MAX bytes.
8097
698d32e2
DN
80982011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8099
8100 Make it possible to build with GCC-4.6+ -O2 -flto.
8101
8102 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8103
fd6fa53f
SM
81042011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8105
8106 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8107 Call minibuffer-inactive-mode.
8108
864db017
JB
81092011-05-31 Juanma Barranquero <lekktu@gmail.com>
8110
8111 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8112 Update dependencies.
8113
2ad0baf4
DN
81142011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8115
8116 * data.c (init_data): Remove code for UTS, this system is not
8117 supported anymore.
8118
4fcc2638
DN
81192011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8120
8121 Don't force ./temacs to start in terminal mode.
8122
8123 * frame.c (make_initial_frame): Initialize faces in all cases, not
8124 only when CANNOT_DUMP is defined.
8125 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8126
c56e0fd5
DN
81272011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8128
8129 * dispnew.c (add_window_display_history): Use const for the string
8130 pointer. Remove declaration, not needed.
8131
333d54da 81322011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8133
55d4c1b2 8134 Use 'inline', not 'INLINE'.
333d54da 8135 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8136 * alloc.c, fontset.c (INLINE): Remove.
8137 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8138 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8139 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8140 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8141 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8142
738db178
DN
81432011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8144
8145 Make it possible to run ./temacs.
8146
8147 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8148 syms_of_callproc does the same thing. Remove test for
8149 "initialized", do it in the caller.
8150 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8151
620c53a6
SM
81522011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8153
8154 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8155 (read_minibuf): Use get_minibuffer.
8156 (syms_of_minibuf): Use DEFSYM.
8157 (Qmetadata): New var.
8158 * data.c (Qbuffer): Don't make it static.
8159 (syms_of_data): Use DEFSYM.
8160
e003a292
PE
81612011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8162
8163 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8164 (CCL_CODE_MIN): New macro.
8165
ed008a6d
PE
81662011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8167
3687c2ef
PE
8168 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8169
ed008a6d
PE
8170 * eval.c (Qdebug): Now static.
8171 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8172 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8173 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8174
d66c4c7c
CY
81752011-05-29 Chong Yidong <cyd@stupidchicken.com>
8176
8177 * image.c: Various fixes to ImageMagick code comments.
8178 (Fimagemagick_types): Doc fix.
8179
5fbc2025
PE
81802011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8181
0196f88a
PE
8182 Minor fixes prompted by GCC 4.6.0 warnings.
8183
8184 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8185
5fbc2025
PE
8186 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8187 (x_clipboard_manager_save_all): Move extern decl to ...
8188 * xterm.h: ... here, so that it can be checked for consistency.
8189
1dd3c2d9
CY
81902011-05-29 Chong Yidong <cyd@stupidchicken.com>
8191
8192 * xselect.c (x_clipboard_manager_save_frame)
8193 (x_clipboard_manager_save_all): New functions.
8194 (Fx_clipboard_manager_save): Lisp function deleted.
8195
8196 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8197 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8198
8199 * xterm.h: Update prototype.
8200
5ba6571d
WX
82012011-05-28 William Xu <william.xwl@gmail.com>
8202
8203 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8204 exiting (Bug#8239).
8205
3eaff834
JM
82062011-05-28 Jim Meyering <meyering@redhat.com>
8207
e1900994 8208 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8209 * fns.c (to_uchar): Define.
8210 (crypto_hash_function): Use it to convert some newly-signed
8211 variables to unsigned, to avoid sign-extension bugs. For example,
8212 without this change, (md5 "truc") would evaluate to
8213 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8214 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8215 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8216
0f6990a7
PE
82172011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8218
8219 Integer overflow fixes.
c8a9ca5a 8220
08686060
PE
8221 * dbusbind.c: Serial number integer overflow fixes.
8222 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8223 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8224 to hold a serial number that is too large for a fixnum.
8225 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8226 Check for serial numbers out of range. Decode any serial number
59568bf0 8227 that was so large that it became a float. (Bug#8722)
08686060 8228
2d1fc3c7
PE
8229 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8230 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8231 Use XFASTINT rather than XUINT when numbers are nonnegative.
8232 (xd_append_arg, Fdbus_method_return_internal):
8233 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8234 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8235 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8236 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8237 (Bug#8722)
2d1fc3c7 8238
c8a9ca5a
PE
8239 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8240
519e1d69
PE
8241 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8242
6df6ae42 8243 ccl: Add integer overflow checks.
30569699
PE
8244 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8245 (IN_INT_RANGE): New macros.
8246 (ccl_driver): Use them to check for integer overflow when
8247 decoding a CCL program. Many of the new checks are whether XINT (x)
8248 fits in int; it doesn't always, on 64-bit hosts. The new version
8249 doesn't catch all possible integer overflows, but it's an
847044ea 8250 improvement. (Bug#8719)
30569699 8251
c11285dc
PE
8252 * alloc.c (make_event_array): Use XINT, not XUINT.
8253 There's no need for unsigned here.
8254
fdccd48e
PE
8255 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8256 This follows up to the 2011-05-06 change that substituted uintptr_t
8257 for EMACS_INT. This case wasn't caught back then.
8258
37910ab2
PE
8259 Rework Fformat to avoid integer overflow issues.
8260 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8261 now (part of C89). Include <verify.h>.
8262 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8263 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8264 (Fformat): Avoid the prepass trying to compute sizes; it was only
8265 approximate and thus did not catch overflow reliably. Instead, walk
8266 through the format just once, formatting and computing sizes as we go,
8267 checking for integer overflow at every step, and allocating a larger
8268 buffer as needed. Keep track separately whether the format is
8269 multibyte. Keep only the most-recently calculated precision, rather
8270 than them all. Record whether each argument has been converted to
8271 string. Use EMACS_INT, not int, for byte and char and arg counts.
8272 Support field widths and precisions larger than INT_MAX. Avoid
8273 sprintf's undefined behavior with conversion specifications such as %#d
8274 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8275 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8276 formatting out-of-range floating point numbers with int
9173deec 8277 formats. (Bug#8668)
37910ab2 8278
2e6578fb
PE
8279 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8280
0ae6bdee
PE
8281 * data.c: Avoid integer truncation in expressions involving floats.
8282 * data.c: Include <intprops.h>.
8283 (arith_driver): When there's an integer overflow in an expression
8284 involving floating point, convert the integers to floating point
8285 so that the resulting value does not suffer from catastrophic
8286 integer truncation. For example, on a 64-bit host (* 4
8287 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8288 Do not rely on undefined behavior after integer overflow.
8289
de883a70
PE
8290 merge count_size_as_multibyte, parse_str_to_multibyte
8291 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8292 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8293 Check for integer overflow.
8294 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8295 since it's now a duplicate of the other. This is more of
8296 a character than a buffer op, so better that it's in character.c.
8297 * fns.c, print.c: Adjust to above changes.
8298
2ff916cb
PE
82992011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8300
8301 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8302
f1b54466
PE
83032011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8304
fb1ac845
PE
8305 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8306 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8307 (x_clipboard_manager_save): Now static.
8308 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8309
f1b54466
PE
8310 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8311 (crypto_hash_function): Now static.
8312 Fix pointer signedness problems. Avoid unnecessary initializations.
8313
a9f737ee
CY
83142011-05-27 Chong Yidong <cyd@stupidchicken.com>
8315
8316 * termhooks.h (Vselection_alist): Make it terminal-local.
8317
8318 * terminal.c (create_terminal): Initialize it.
8319
8320 * xselect.c: Support for clipboard managers.
8321 (Vselection_alist): Move to termhooks.h as terminal-local var.
8322 (LOCAL_SELECTION): New macro.
8323 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8324 (symbol_to_x_atom): Remove gratuitous arg.
8325 (x_handle_selection_request, lisp_data_to_selection_data)
8326 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8327 (x_own_selection, x_get_local_selection, x_convert_selection):
8328 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8329 (some_frame_on_display): Delete unused function.
8330 (Fx_own_selection_internal, Fx_get_selection_internal)
8331 (Fx_disown_selection_internal, Fx_selection_owner_p)
8332 (Fx_selection_exists_p): New optional frame arg.
8333 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8334 (x_handle_selection_clear): Don't treat other terminals with the
8335 same keyboard specially. Use the terminal-local Vselection_alist.
8336 (x_clear_frame_selections): Use Frun_hook_with_args.
8337
8338 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8339
8340 * xterm.h: Add support for those atoms.
8341
e067f0c1
CY
83422011-05-26 Chong Yidong <cyd@stupidchicken.com>
8343
8344 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8345 (converted_selections, conversion_fail_tag): New global variables.
8346 (x_selection_request_lisp_error): Free the above.
8347 (x_get_local_selection): Remove unnecessary code.
8348 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8349 of converted selections stored in converted_selections.
8350 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8351 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8352 (x_convert_selection): New function.
8353 (x_handle_selection_event): Simplify.
8354 (x_get_foreign_selection): Don't ignore incoming requests while
8355 waiting for an answer; this will fail when we implement
8356 SAVE_TARGETS, and seems unnecessary anyway.
8357 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8358 (Vx_sent_selection_functions): Doc fix.
8359
0f4aebc0
LL
83602011-05-26 Leo Liu <sdl.web@gmail.com>
8361
8362 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8363
e61124cd
YM
83642011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8365
8366 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8367
8368 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8369 for fringe update if it has periodic bitmap.
ac389d0c 8370 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8371 and fringe_bitmap_periodic_p.
8372
8373 * fringe.c (get_fringe_bitmap_data): New function.
8374 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8375 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8376 row. Mark glyph row for fringe update if periodicity changed.
8377
8378 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8379 for fringe update unless it has periodic bitmap.
8380
f16d9837
KH
83812011-05-25 Kenichi Handa <handa@m17n.org>
8382
8383 * xdisp.c (get_next_display_element): Set correct it->face_id for
8384 a static composition.
8385
e1b90ef6
LL
83862011-05-24 Leo Liu <sdl.web@gmail.com>
8387
8388 * deps.mk (fns.o):
8389 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8390
8391 * fns.c (crypto_hash_function, Fsha1): New function.
8392 (Fmd5): Use crypto_hash_function.
8393 (syms_of_fns): Add Ssha1.
8394
7400048f
PE
83952011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8396
8397 * gnutls.c: Remove unused macros.
8398 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8399 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8400 Remove macros that are defined and never used.
8401 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8402
abb71cf4
CY
84032011-05-22 Chong Yidong <cyd@stupidchicken.com>
8404
8405 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8406 (Fx_get_selection_internal): Minor cleanup.
8407 (Fx_own_selection_internal): Rename arguments for consistency with
8408 select.el.
8409
6307db39
PE
84102011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8411
8412 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8413
f3d4e0a4
CY
84142011-05-22 Chong Yidong <cyd@stupidchicken.com>
8415
8416 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8417
4d8ade89
YM
84182011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8419
8420 * dispnew.c (scrolling_window): Don't exclude the case that the
8421 last enabled row in the desired matrix touches the bottom boundary.
8422
32078c8d
GM
84232011-05-21 Glenn Morris <rgm@gnu.org>
8424
8425 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8426 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8427 and add some more files.
32078c8d 8428
7285dc67
EZ
84292011-05-20 Eli Zaretskii <eliz@gnu.org>
8430
8431 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8432 report_file_error introduced by the change from 2011-05-07.
8433
89d1bd22
PE
84342011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8435
8436 * systime.h (Time): Define only if emacs is defined.
8437 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8438 where the include path doesn't have X11/X.h by default. See
8439 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8440
cd394be1 84412011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8442
8443 * composite.c (find_automatic_composition): Fix previous change.
8444
b9704ad9
GM
84452011-05-20 Glenn Morris <rgm@gnu.org>
8446
8447 * lisp.mk: New file, split from Makefile.in.
8448 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8449 (shortlisp): Remove.
8450 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8451
4a720484
GM
84522011-05-19 Glenn Morris <rgm@gnu.org>
8453
8454 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8455 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8456 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8457 (lisp): Set the order to that of loadup.el.
8458 (shortlisp): Make it a copy of $lisp.
8459 (SOME_MACHINE_LISP): Remove.
8460 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8461 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8462
a28d4396
KH
84632011-05-18 Kenichi Handa <handa@m17n.org>
8464
8465 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8466 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8467 (find_automatic_composition): Mostly rewrite for efficiency.
8468
a2b1fa8e
JB
84692011-05-18 Juanma Barranquero <lekktu@gmail.com>
8470
8471 * makefile.w32-in: Update dependencies.
8472
8e1f5610
CS
84732011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8474
8475 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8476 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8477
7025ee00 84782011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8479
cdfa6eab
PE
8480 Fix some integer overflow issues, such as string length overflow.
8481
06d6db33
PE
8482 * insdel.c (count_size_as_multibyte): Check for string overflow.
8483
2b4560a8
PE
8484 * character.c (lisp_string_width): Check for string overflow.
8485 Use EMACS_INT, not int, for string indexes and lengths; in
8486 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8487 the resulting string length overflows an EMACS_INT; instead,
8488 report a string overflow if no precision given. When checking for
8489 precision exhaustion, use a check that cannot possibly have
8490 integer overflow. (Bug#8675)
8491 * character.h (lisp_string_width): Adjust to new signature.
8492
cb93f9be
PE
8493 * alloc.c (string_overflow): New function.
8494 (Fmake_string): Use it. This doesn't change behavior, but saves
8495 a few bytes and will simplify future changes.
8496 * character.c (string_escape_byte8): Likewise.
8497 * lisp.h (string_overflow): New decl.
8498
1a1f3366
PE
8499 Fixups, following up to the user-interface timestamp change.
8500 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8501 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8502 * msdos.c (mouse_get_pos): Likewise.
8503 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8504 * w32gui.h (Time): Define by including "systime.h" rather than by
8505 declaring it ourselves. (Bug#8664)
8506
d4e3e4d3
PE
8507 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8508 * image.c (clear_image_cache): Likewise.
8509
f6a24d19
PE
8510 * term.c (term_mouse_position): Don't assume time_t wraparound.
8511
08dc5ae6
PE
8512 Be more systematic about user-interface timestamps.
8513 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8514 and sometimes 'EMACS_UINT', to represent these timestamps.
8515 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8516 This makes the code easier to follow, and makes it easier to catch
8517 integer overflow bugs such as Bug#8664.
8518 * frame.c (Fmouse_position, Fmouse_pixel_position):
8519 Use Time, not unsigned long, for user-interface timestamps.
8520 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8521 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8522 * keyboard.h (last_event_timestamp): Likewise.
8523 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8524 * menu.h (xmenu_show): Likewise.
8525 * term.c (term_mouse_position): Likewise.
8526 * termhooks.h (struct input_event.timestamp): Likewise.
8527 (struct terminal.mouse_position_hook): Likewise.
8528 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8529 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8530 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8531 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8532 what it was before.
8533 * menu.h, termhooks.h: Include "systime.h", for Time.
8534
8e55734a
PE
8535 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8536 Don't assume that the difference between two unsigned long values
8537 can fit into an integer. At this point, we know button_down_time
8538 <= event->timestamp, so the difference must be nonnegative, so
8539 there's no need to cast the result if double-click-time is
8540 nonnegative, as it should be; check that it's nonnegative, just in
8541 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8542 apart (about 25 days). (Bug#8664)
8e55734a 8543
841f1b75 8544 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8545 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8546
3e26f69c
PE
8547 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8548 that always fit in int. Use a sentinel instead of a counter, to
8549 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8550 * frame.h (struct frame): Use int for menu_bar_items_used
8551 instead of EMACS_INT, since it always fits in int.
3e26f69c 8552
5cc152c0
PE
8553 * menu.c (grow_menu_items): Check for int overflow.
8554
d89eb65e
PE
8555 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8556
5235bd3e
PE
8557 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8558 Before, the code was not consistent. These values cannot exceed
8559 2**31 - 1 so there's no need to make them unsigned.
8560 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8561 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8562 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8563 as modifiers.
8564 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8565
bc827e23
PE
8566 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8567 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8568 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8569 presumably because the widths might not match.
8570
78eb494e
PE
8571 * window.c (size_window): Avoid needless test at loop start.
8572
04f2d78b
CB
85732011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8574
8575 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8576
d2fc7e3d 85772011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
8578
8579 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8580
d2fc7e3d 85812011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
8582
8583 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8584 `width' to `bar_area_x' and `bar_area_width', respectively.
8585 (x_scroll_run): Take account of fringe background extension.
8586
04f2d78b
CB
8587 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8588 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
8589 `bar_area_width', respectively.
8590 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8591 background extension.
8592
79b70037
GM
85932011-05-10 Jim Meyering <meyering@redhat.com>
8594
8595 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8596
2f142cc5
JB
85972011-05-10 Juanma Barranquero <lekktu@gmail.com>
8598
8599 * image.c (Finit_image_library): Return t for built-in image types,
8600 like pbm and xbm. (Bug#8640)
8601
57679c86
AS
86022011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8603
8604 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8605
888c9e86
EZ
86062011-05-07 Eli Zaretskii <eliz@gnu.org>
8607
b0512a1d
EZ
8608 * w32console.c (Fset_screen_color): Doc fix.
8609 (Fget_screen_color): New function.
8610 (syms_of_ntterm): Defsubr it.
8611
7285dc67
EZ
8612 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8613 unlink the temporary file if Fcall_process didn't create it in the
8614 first place.
8615 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8616 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
8617 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8618 cue to call_process_cleanup not to close that handle.
8619
4d3fcc8e
BK
86202011-05-07 Ben Key <bkey76@gmail.com>
8621
8622 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8623 one of two shell specific rules, either bootstrap-temacs-CMD or
8624 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8625 to the previous implementation of the bootstrap-temacs rule.
8626 The bootstrap-temacs-CMD rule is similar to the previous
8627 implementation of the bootstrap-temacs rule except that it
8628 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8629 variable.
8630
8631 These changes, along with some changes to nt/configure.bat,
8632 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8633 earlier fix to add support for --cflags and --ldflags options
8634 that include quotes so that it works whether make uses cmd or
8635 sh as the shell.
8636
b4289b64
MA
86372011-05-06 Michael Albinus <michael.albinus@gmx.de>
8638
8639 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8640 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8641 is a constant.
8642 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8643 a string. Handle both cases.
8644 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8645 (Fdbus_register_method): Use Qinvalid_function.
8646
af4c0e28
JB
86472011-05-06 Juanma Barranquero <lekktu@gmail.com>
8648
8649 * makefile.w32-in: Update dependencies.
8650 (LISP_H): Add inttypes.h and stdin.h.
8651 (PROCESS_H): Add unistd.h.
8652
c51453d9
EZ
86532011-05-06 Eli Zaretskii <eliz@gnu.org>
8654
8655 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8656 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8657
8ff0ac3c 86582011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 8659
4c4b566b
PE
8660 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8661
aab2b9b5
PE
8662 * term.c (vfatal): Remove stray call to va_end.
8663 It's not needed and the C Standard doesn't allow it here anyway.
8664
c378da0b
PE
8665 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8666 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8667
288b08c7
PE
8668 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8669 bytes.
8670
e3601888
PE
8671 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8672
db6c0e74
PE
8673 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8674
dd5963ea
PE
8675 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8676
88c9450f
PE
8677 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8678
2f9442b8
PE
8679 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8680
c032b5f8
PE
8681 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8682 * charset.c (Fdefine_charset_internal): Don't initialize
8683 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 8684 32-bit int (Bug#8600).
a108c10b
PE
8685
8686 * lread.c (read_integer): Be more consistent with string-to-number.
8687 Use string_to_number to do the actual conversion; this avoids
8688 rounding errors and fixes some other screwups. Without this fix,
8689 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8690 (digit_to_number): Move earlier, for benefit of read_integer.
8691 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 8692 not a digit in any supported base. (Bug#8602)
a108c10b 8693
ad5f9eea
PE
8694 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8695
aec1708a
PE
8696 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8697 to match comment at start of function. This also removes a
8698 GCC warning about overflow in a 32+64-bit port.
8699
47be4ab5
PE
8700 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8701
371cac43
PE
8702 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8703 Reported by Stefan Monnier in
8704 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
8705 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8706 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 8707
d01a7826
PE
8708 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8709 (EMACS_UINTPTR): Likewise, with uintptr_t.
8710
7fd47d5c
PE
8711 * lisp.h: Prefer 64-bit EMACS_INT if available.
8712 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8713 on 32-bit hosts that have 64-bit int, so that they can access
8714 large files.
122b0c86
PE
8715 However, temporarily disable this change unless the temporary
8716 symbol WIDE_EMACS_INT is defined.
7fd47d5c 8717
8727937b
PE
8718 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8719
8ac068ac
PE
8720 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8721 This removes an assumption that EMACS_INT and long are the same
8722 width as pointers. The assumption is true for Emacs porting targets
8723 now, but we want to make other targets possible.
8724 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8725 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8726 In the rest of the code, change types of integers that hold casted
8727 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8728 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8729 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8730 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8731 No need to cast type when ORing.
8732 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8733 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8734 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8735 assume EMACS_INT is the same width as char *.
8736 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8737 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8738 Remove no-longer-needed casts.
8739 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8740 (xg_tool_bar_help_callback, xg_make_tool_item):
8741 Use EMACS_INTPTR to hold an integer
8742 that will be cast to void *; this can avoid a GCC warning
8743 if EMACS_INT is not the same width as void *.
8744 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8745 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8746 (current_message_1, set_message_1):
8747 Use a local to convert to proper width without a cast.
8748 * xmenu.c (dialog_selection_callback): Likewise.
8749
ede49d71
PE
8750 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8751 Also, don't assume VALBITS / RAND_BITS is less than 5,
8752 and don't rely on undefined behavior when shifting a 1 left into
8753 the sign bit.
8754 * lisp.h (get_random): Change signature to match.
8755
2f30ecd0
PE
8756 * lread.c (hash_string): Use size_t, not int, for hash computation.
8757 Normally we prefer signed values; but hashing is special, because
8758 it's better to use unsigned division on hash table sizes so that
8759 the remainder is nonnegative. Also, size_t is the natural width
8760 for hashing into memory. The previous code used 'int', which doesn't
8761 retain enough info to hash well into very large tables.
8762 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8763
2a866e7b
PE
8764 * dbusbind.c: Don't possibly lose pointer info when converting.
8765 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8766 Use XPNTR rather than XHASH, so that the high-order bits of
8767 the pointer aren't lost when converting through void *.
8768
51639eac
PE
8769 * eval.c (Fautoload): Don't double-shift a pointer.
8770
92394119
PE
8771 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8772
dbdb9a7c
JB
87732011-05-06 Juanma Barranquero <lekktu@gmail.com>
8774
8775 * gnutls.c (DEF_GNUTLS_FN):
8776 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8777
db7a0b4f
AS
87782011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8779
8780 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8781 marker. (Bug#8610)
8782
cd394be1 87832011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
8784
8785 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8786 New version that can reserve upto 2GB of heap space.
8787
f7ff1b0f 87882011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
8789
8790 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8791
639c109b
TZ
87922011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8793
8794 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8795 `gnutls_certificate_set_x509_key_file'.
8796
d2127135
JB
87972011-05-05 Juanma Barranquero <lekktu@gmail.com>
8798
8799 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8800 Update dependencies.
8801
e968f4f3
JB
88022011-05-04 Juanma Barranquero <lekktu@gmail.com>
8803
8804 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8805 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8806 Remove unused parameter `fildes'.
8807 * process.c (read_process_output, send_process): Don't pass it.
8808
84d358f0
JB
88092011-05-04 Juanma Barranquero <lekktu@gmail.com>
8810
8811 Fix previous change: the library cache is defined in w32.c.
8812 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8813 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8814
0898ca10
JB
88152011-05-04 Juanma Barranquero <lekktu@gmail.com>
8816
8817 Implement dynamic loading of GnuTLS on Windows.
8818
8819 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8820 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8821 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8822 Declare.
8823
8824 * gnutls.c (Qgnutls_dll): Define.
8825 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8826 (gnutls_*): Declare function pointers.
8827 (init_gnutls_functions): New function to initialize function pointers.
8828 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8829 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8830 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8831 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8832 (emacs_gnutls_write, emacs_gnutls_read)
8833 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8834 (Fgnutls_available_p): New function.
8835 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8836 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8837 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8838
8839 * image.c: Include w32.h.
8840 (Vimage_type_cache): Delete.
8841 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8842 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8843 (w32_delayed_load): Move to w32.c.
8844
8845 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8846
8847 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8848 (w32_delayed_load): Move from image.c. When loading a library, record
8849 its filename in the :loaded-from property of the library id.
8850 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8851 Initialize and staticpro them.
8852 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8853
8854 * process.c: Include lisp.h before w32.h, not after.
8855 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8856 instead of gnutls_record_check_pending.
8857
8858 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8859
ff4de4aa
TZ
88602011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8861
8862 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8863 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8864 as passed in.
8865
abe95abb
JD
88662011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8867
8868 * xterm.c (x_set_frame_alpha): Do not set property on anything
8869 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8870
e16e55d4
JB
88712011-05-02 Juanma Barranquero <lekktu@gmail.com>
8872
8873 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8874
bafcf6a5
JB
88752011-05-02 Juanma Barranquero <lekktu@gmail.com>
8876
8877 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8878 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8879 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8880 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8881 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8882 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8883 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8884 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8885 (Qgnutls_bootprop_callbacks_verify): Make static.
8886
e7a6747f
AS
88872011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8888
19ed11ba
AS
8889 * callproc.c: Indentation fixup.
8890
e7a6747f 8891 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
8892 (wait_for_termination, interruptible_wait_for_termination):
8893 Move after wait_for_termination_1.
e7a6747f 8894
1ef14cb4
LMI
88952011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8896
8897 * sysdep.c (interruptible_wait_for_termination): New function
8898 which is like wait_for_termination, but allows keyboard
8899 interruptions.
8900
8901 * callproc.c (Fcall_process): Add (:file "file") as an option for
8902 the STDOUT buffer.
8903 (Fcall_process_region): Ditto.
8904
330d880c
EZ
89052011-04-30 Eli Zaretskii <eliz@gnu.org>
8906
8db90b73
EZ
8907 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8908 rather than `XVECTOR (FOO)->size'.
8909
330d880c
EZ
8910 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8911 inttypes.h, as a gnulib replacement is used if it not available in
8912 system headers.
8913
15cbd324
EZ
89142011-04-21 Eli Zaretskii <eliz@gnu.org>
8915
8916 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8917 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8918 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8919
8920 * coding.c (coding_alloc_by_realloc): Error out if destination
8921 will grow beyond MOST_POSITIVE_FIXNUM.
8922 (decode_coding_emacs_mule): Abort if there isn't enough place in
8923 charbuf for the composition carryover bytes. Reserve an extra
8924 space for up to 2 characters produced in a loop.
8925 (decode_coding_iso_2022): Abort if there isn't enough place in
8926 charbuf for the composition carryover bytes.
8927
89282011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 8929
ae940cca
EZ
8930 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8931 aborting when %lld or %lll format is passed.
8932 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8933 %llo or %llx format is passed. (Bug#8545)
8934
03ab8921
EZ
8935 * window.c (window_scroll_line_based): Use a marker instead of
8936 simple variables to record original value of point. (Bug#7952)
8937
afda1437
EZ
8938 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8939 produced by %s or %c overflows available buffer space. (Bug#8545)
8940
f76dee0c
PE
89412011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8942
8943 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 8944 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 8945
fdc5744d
JB
89462011-04-28 Juanma Barranquero <lekktu@gmail.com>
8947
8948 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8949
638f053a
JB
89502011-04-28 Juanma Barranquero <lekktu@gmail.com>
8951
8952 * keyboard.c (Qdelayed_warnings_hook): Define.
8953 (command_loop_1): Run `delayed-warnings-hook'
8954 if Vdelayed_warnings_list is non-nil.
8955 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8956 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8957
d178f871
EZ
89582011-04-28 Eli Zaretskii <eliz@gnu.org>
8959
8960 * doprnt.c (doprnt): Don't return value smaller than the buffer
8961 size if the message was truncated. (Bug#8545).
8962
b124fd93
JB
89632011-04-28 Juanma Barranquero <lekktu@gmail.com>
8964
8965 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8966 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8967
e810457d
PE
89682011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8969
8970 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8971
ea51cceb
JB
89722011-04-27 Juanma Barranquero <lekktu@gmail.com>
8973
8974 * makefile.w32-in: Update dependencies.
8975
94dcfacf
EZ
89762011-04-27 Eli Zaretskii <eliz@gnu.org>
8977
8978 Improve `doprnt' and its usage. (Bug#8545)
8979 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8980 `format_end'. Remove support for %l as a conversion specifier.
8981 Don't use xrealloc. Improve diagnostics when the %l size modifier
8982 is used. Update the commentary.
8983
8984 * eval.c (verror): Simplify calculation of size_t.
8985
8986 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8987 messages.
8988
f61f41d7
PE
89892011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8990
8991 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8992 change.
8993
96fb4434
PE
89942011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8995
8996 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8997 This makes this file independent of the recent pseudovector change.
8998
671875da 89992011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9000
69e9b5a3
PE
9001 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9002
b5f869a7 9003 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9004 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9005 Remove unused local.
c8926152 9006 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9007
841a1577 9008 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9009 GCC 4.6.0 optimizes based on type-based alias analysis.
9010 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9011 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9012 != &v->size, and therefore "v->size = 1; b->size = 2; return
9013 v->size;" must therefore return 1. This assumption is incorrect
9014 for Emacs, since it type-puns struct Lisp_Vector * with many other
9015 types. To fix this problem, this patch adds a new type struct
f904488f 9016 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9017 and pseudovectors, and helps optimizing compilers not get fooled
9018 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9019 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9020 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9021 the size member.
eab3844f
PE
9022 (XSETPVECTYPE): Rewrite in terms of new macro.
9023 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9024 This is a bit clearer, and further avoids the possibility of
9025 undesirable aliasing.
9026 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9027 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9028 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9029 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9030 (ASIZE): Now uses header.size rather than size.
9031 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9032 to avoid the hassle of writing XVECTOR (foo)->header.size.
9033 (struct vectorlike_header): New type.
eab3844f
PE
9034 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9035 object, to help avoid aliasing.
9036 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9037 (SUBRP): Likewise, since Lisp_Subr is a special case.
9038 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9039 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9040 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9041 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9042 changed to be "header.size" and "header.next".
9043 * buffer.h (struct buffer): Likewise.
9044 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9045 * frame.h (struct frame): Likewise.
9046 * process.h (struct Lisp_Process): Likewise.
9047 * termhooks.h (struct terminal): Likewise.
9048 * window.c (struct save_window_data, struct saved_window): Likewise.
9049 * window.h (struct window): Likewise.
9050 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9051 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9052 * buffer.c (init_buffer_once): Likewise.
9053 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9054 special case.
9055 * process.c (Fformat_network_address): Use local var for size,
9056 for brevity.
9057
0df1eac5
PE
9058 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9059
847ab9d1 9060 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9061 * data.c (atof): Remove decl; no longer used or needed.
9062 (digit_to_number): Move to lread.c.
9063 (Fstring_to_number): Use new string_to_number function, to be
9064 consistent with how the Lisp reader treats infinities and NaNs.
9065 Do not assume that floating-point numbers represent EMACS_INT
9066 without losing information; this is not true on most 64-bit hosts.
9067 Avoid double-rounding errors, by insisting on integers when
9068 parsing non-base-10 numbers, as the documentation specifies.
9069 * lisp.h (string_to_number): New decl, replacing ...
9070 (isfloat_string): Remove.
bc0a5c13 9071 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9072 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9073 appears to have been a coding error. Similarly, do not accept
9074 strings like +-1e0 as floating point numbers. Do not report
9075 overflow for integer overflows unless the base is not 10 which
9076 means we have no simple and reliable way to continue.
9077 Break out the floating-point parsing into a new
9078 function string_to_number, so that Fstring_to_number parses
9079 floating point numbers consistently with the Lisp reader.
04f2d78b 9080 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9081 (E_CHAR, EXP_INT): Remove, replacing with ...
9082 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9083 (string_to_number): New function, replacing isfloat_string.
9084 This function checks for valid syntax and produces the resulting
9085 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9086 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9087 so that overflow for non-base-10 numbers is reported only when
9088 there's no portable and simple way to convert to floating point.
452f4150 9089
67769ffc
PE
9090 * textprop.c (set_text_properties_1): Rewrite for clarity,
9091 and to avoid GCC warning about integer overflow.
9092
c20db43f
PE
9093 * intervals.h (struct interval): Use EMACS_INT for members
9094 where EMACS_UINT might cause problems. See
9095 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9096 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9097 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9098 All uses changed.
37aa2f85
PE
9099 (offset_intervals): Tell GCC not to worry about length overflow
9100 when negating a negative length.
c20db43f 9101
2538aa2f
PE
9102 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9103 (overrun_check_free): Likewise.
9104
f2d3008d
PE
9105 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9106 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9107 word size.
9108
ec8df744
PE
9109 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9110 (gnutls_make_error): Rename local to avoid shadowing.
9111 (gnutls_emacs_global_deinit): ifdef out; not used.
9112 (Fgnutls_boot): Use const for pointer to readonly storage.
9113 Comment out unused local. Fix pointer signedness problems.
9114
640ee02d
PE
9115 * lread.c (openp): Don't stuff size_t into an 'int'.
9116 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9117 about possible signed overflow.
9118
6048fb2a
PE
9119 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9120 (GDK_KEY_g): Don't define if already defined.
9121 (xg_prepare_tooltip): Avoid pointer signedness problem.
9122 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9123
fa3c87e1
PE
9124 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9125 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9126
2172544b
PE
9127 * xfns.c (Fx_window_property): Simplify a bit,
9128 to make a bit faster and to avoid GCC 4.6.0 warning.
9129 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9130
9b821a21
PE
9131 * fns.c (internal_equal): Don't assume size_t fits in int.
9132
3c616cfa
PE
9133 * alloc.c (compact_small_strings): Tighten assertion a little.
9134
c2982e87
PE
9135 Replace pEd with more-general pI, and fix some printf arg casts.
9136 * lisp.h (pI): New macro, generalizing old pEd macro to other
9137 conversion specifiers. For example, use "...%"pI"d..." rather
9138 than "...%"pEd"...".
9139 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9140 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9141 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9142 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9143 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9144 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9145 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9146 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9147 64-bit hosts.
9148 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9149 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9150 * print.c (safe_debug_print, print_object): Likewise.
9151 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9152 to int.
6f04d126
PE
9153 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9154 avoiding the 0 flag, which is not portable.
c2982e87
PE
9155 * process.c (Fmake_network_process): Use pI to avoid cast.
9156 * region-cache.c (pp_cache): Likewise.
9157 * xdisp.c (decode_mode_spec): Likewise.
9158 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9159 behavior on 64-bit hosts with printf arg.
6f04d126 9160 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9161 (x_stop_queuing_selection_requests): Likewise.
9162 (x_get_window_property): Don't truncate byte count to an 'int'
9163 when tracing.
0b432f21 9164
5e073ec7
PE
9165 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9166 here, since it parses constructs like leading '-' and spaces,
9167 which are not wanted; and it overflows with large numbers.
9168 Instead, simply match F[0-9]+, which is what is wanted anyway.
9169
36372bf9
PE
9170 * alloc.c: Remove unportable assumptions about struct layout.
9171 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9172 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9173 (allocate_vectorlike, make_pure_vector): Use the new macros,
9174 plus offsetof, to remove unportable assumptions about struct layout.
9175 These assumptions hold on all porting targets that I know of, but
9176 they are not guaranteed, they're easy to remove, and removing them
9177 makes further changes easier.
9178
0b432f21
PE
9179 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9180 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9181 (string_overrun_cookie): Now const. Use initializers that
9182 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9183 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9184 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9185 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9186 multiple of sizeof (EMACS_INT); it need not be, if
9187 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9188 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9189
895009e1
JB
91902011-04-26 Juanma Barranquero <lekktu@gmail.com>
9191
9192 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9193
6a7a1b0b
TZ
91942011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9195
9196 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9197 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9198 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9199
841a1577 92002011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9201
9202 * lisp.h (Qdebug): List symbol.
895009e1 9203 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9204 * keyboard.c (debug-on-event): New variable.
9205 (handle_user_signal): Break into debugger when debug-on-event
9206 matches the current signal symbol.
9207
f2d3ba6f
DN
92082011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9209
9210 * alloc.c (check_sblock, check_string_bytes)
9211 (check_string_free_list): Convert to standard C.
9212
42ce4c63
TZ
92132011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9214
9215 * w32.c (emacs_gnutls_push): Fix typo.
9216
825cd63c
EZ
92172011-04-25 Eli Zaretskii <eliz@gnu.org>
9218
fb11d64d
EZ
9219 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9220 "cast to pointer from integer of different size".
9221
825cd63c
EZ
9222 Improve doprnt and its use in verror. (Bug#8545)
9223 * doprnt.c (doprnt): Document the set of format control sequences
9224 supported by the function. Use SAFE_ALLOCA instead of always
9225 using `alloca'.
9226
9227 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9228 is one byte too soon. Don't use xrealloc; instead xfree and
9229 xmalloc anew.
9230
e061a11b
TZ
92312011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9232
9233 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9234 callbacks stage.
9235
9236 * gnutls.c: Renamed global_initialized to
9237 gnutls_global_initialized. Added internals for the
9238 :verify-hostname-error, :verify-error, and :verify-flags
9239 parameters of `gnutls-boot' and documented those parameters in the
9240 docstring. Start callback support.
9173deec
JB
9241 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9242 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9243 on error. Return error code.
e061a11b
TZ
9244 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9245 (emacs_gnutls_read): Likewise.
9246 (Fgnutls_boot): Return handshake error code.
9247 (emacs_gnutls_handle_error): New function.
9248 (wsaerror_to_errno): Likewise.
9249
9250 * w32.h (emacs_gnutls_pull): Add prototype.
9251 (emacs_gnutls_push): Likewise.
9252
9253 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9254 (emacs_gnutls_push): Likewise.
9255
92562011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9257
9258 * process.c (wait_reading_process_output): Check if GnuTLS
9259 buffered some data internally if no FDs are set for TLS
9260 connections.
9261
9262 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9263 (LIBS): Link to USER_LIBS.
9264 ($(BLD)/gnutls.$(0)): New target.
9265
fa6996bc
EZ
92662011-04-24 Eli Zaretskii <eliz@gnu.org>
9267
eb35682e
EZ
9268 * xdisp.c (handle_single_display_spec): Rename the
9269 display_replaced_before_p argument into display_replaced_p, to
9270 make it consistent with the commentary. Fix typos in the
9271 commentary.
9272
e2ad650c
EZ
9273 * textprop.c (syms_of_textprop): Remove dead code.
9274 (copy_text_properties): Delete obsolete commentary about an
9275 interface that was deleted long ago. Fix typos in the description
9276 of arguments.
9277
1b2de274
EZ
9278 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9279 to changes in oldXMenu/XMenu.h from 2011-04-16.
9280 <menu_help_message, prev_menu_help_message>: Constify.
9281 (IT_menu_make_room): menu->help_text is now `const char **';
9282 adjust.
9283
9284 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9285 to changes in oldXMenu/XMenu.h from 2011-04-16.
9286 (struct XMenu): Declare `help_text' `const char **'.
9287
9288 * xfaces.c <Qunspecified>: Make extern again.
9289
9290 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9291 required by POSIX.
1b2de274 9292
762b15be
EZ
9293 * doc.c (get_doc_string): Improve the format passed to `error'.
9294
9295 * doprnt.c (doprnt): Improve commentary.
9296
9297 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9298
9299 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9300 them with etags.
9301
f1052e5d
EZ
9302 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9303 changes in globals.h immediately force recompilation.
762b15be
EZ
9304 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9305 $(CURDIR)/s/ms-w32.h.
9306 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9307
fa6996bc
EZ
9308 * character.c (Fchar_direction): Function deleted.
9309 (syms_of_character): Don't defsubr it.
9310 <char-direction-table>: Deleted.
9311
e6c3da20
EZ
93122011-04-23 Eli Zaretskii <eliz@gnu.org>
9313
9314 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9315 * doprnt.c: Include limits.h.
9316 (SIZE_MAX): New macro.
04f2d78b
CB
9317 (doprnt): Return a size_t value. 2nd arg is now size_t.
9318 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9319 Improve overflow protection. Support `l' modifier for integer
9320 conversions. Support %l conversion. Don't assume an EMACS_INT
9321 argument for integer conversions and for %c.
9322
9323 * lisp.h (doprnt): Restore prototype.
9324
9325 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9326 $(SRC)/character.h.
9327
9328 * Makefile.in (base_obj): Add back doprnt.o.
9329
9330 * deps.mk (doprnt.o): Add back prerequisites.
9331 (callint.o): Depend on character.h.
9332
9333 * eval.c (internal_lisp_condition_case): Include the handler
9334 representation in the error message.
9335 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9336 when breaking from the loop.
9337
9338 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9339
9340 * callint.c (Fcall_interactively): When displaying error message
9341 about invalid control letter, pass the character's codepoint, not
9342 a pointer to its multibyte form. Improve display of the character
9343 in octal and display also its hex code.
9344
9345 * character.c (char_string): Use %x to display the (unsigned)
9346 codepoint of an invalid character, to avoid displaying a bogus
9347 negative value.
9348
9349 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9350 `error', not SYMBOL_NAME itself.
9351
9352 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9353 character arguments to `error'.
9354
9355 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9356 to `error' in error message about FINAL_CHAR argument. Make sure
9357 FINAL_CHAR is a character, and use %c when it is passed as
9358 argument to `error'.
9359
4ffd0d6b 93602011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9361
9362 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9363
9364 * w32.c: Include <time.h>.
9365 (sys_localtime): New function.
9366
4ffd0d6b 93672011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9368
9369 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9370
4ffd0d6b 9371 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9372
4ffd0d6b 93732011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9374
4ffd0d6b
GM
9375 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9376 zombies (Bug#8467).
aac0c6e3 9377
04c56954
EZ
93782011-04-19 Eli Zaretskii <eliz@gnu.org>
9379
9380 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9381 gl_state.e_property when gl_state.object is Qt.
9382
9383 * insdel.c (make_gap_larger): Remove limitation of buffer size
9384 to <= INT_MAX.
9385
16a43933
CY
93862011-04-18 Chong Yidong <cyd@stupidchicken.com>
9387
9388 * xdisp.c (lookup_glyphless_char_display)
9389 (produce_glyphless_glyph): Handle cons cell entry in
9390 glyphless-char-display.
9391 (Vglyphless_char_display): Document it.
9392
9393 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9394 glyphless-char-display.
9395
4581706e
CY
93962011-04-17 Chong Yidong <cyd@stupidchicken.com>
9397
9398 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9399
9400 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9401
9402 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9403 definition for no-X builds.
9404
4887c6e2 94052011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9406
fd35b6f9
PE
9407 Static checks with GCC 4.6.0 and non-default toolkits.
9408
5c1ccb01
PE
9409 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9410
006c5daa
PE
9411 * process.c (keyboard_bit_set): Define only if SIGIO.
9412 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9413 (send_process): Repair possible setjmp clobbering.
9414
efc736d3
PE
9415 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9416
4e2fe2e6
PE
9417 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9418
f97334a2
PE
9419 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9420
4e75f29d
PE
9421 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9422 Define only if needed.
9423
90efadd1
PE
9424 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9425 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9426 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9427
3c647824
PE
9428 * dispextern.h (struct redisplay_interface): Rename param
9429 to avoid shadowing.
e264f262 9430 * termhooks.h (struct terminal): Likewise.
761383f4 9431 * xterm.c (xembed_send_message): Likewise.
3c647824 9432
b58c5c4a
PE
9433 * insdel.c (make_gap_smaller): Define only if
9434 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9435
cad59032
PE
9436 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9437 it.
9438
c339dc2e
PE
9439 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9440 so that we aren't warned about unused symbols.
9441
91a3e27b
PE
9442 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9443
399c71d3 9444 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9445
8ffc96f5
PE
9446 * xfns.c (x_real_positions): Mark locals as initialized.
9447
eef9bc79
PE
9448 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9449
098db9dd
PE
9450 * xterm.c: Fix problems found by static analysis with other toolkits.
9451 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9452 (x_dispatch_event): Declare static if USE_GTK, and
9453 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9454 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9455 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9456 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9457 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9458
eb18f6cc
PE
9459 * xmenu.c (menu_help_callback): Pointer type fixes.
9460 Use const pointers when pointing at readonly data. Avoid pointer
9461 signedness clashes.
9462 (FALSE): Remove unused macro.
9463 (update_frame_menubar): Remove unused decl.
9464
1fe72bf8
PE
9465 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9466
60d9e1db
PE
9467 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9468 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9469 (single_menu_item): Rename local to avoid shadowing.
9470
39261c26
PE
9471 * keyboard.c (make_lispy_event): Remove unused local var.
9472
018c5e19
PE
9473 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9474 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9475
63d2b86e
PE
9476 * bitmaps: Change bitmaps from unsigned char back to the X11
9477 compatible char. Avoid the old compiler warnings about
9478 out-of-range initializers by using, for example, '\xab' rather
9479 than 0xab.
9480
aefd87e1
PE
9481 * xgselect.c (xgselect_initialize): Check vs interface
9482 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9483
bf501fb9
PE
9484 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9485
e9829fdf
PE
9486 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9487 to read-only memory.
9488
1086c095
PE
9489 * fns.c (vector): Remove; this old hack is no longer needed.
9490
2baccd04 9491 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9492 Remove unused var.
dde42981 9493 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9494
72391843 9495 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9496
436c16df 9497 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9498 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9499 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9500
92bb796d 9501 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9502 (x_term_init): Remove local to avoid shadowing.
92bb796d 9503
764430a3 9504 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9505
9506 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9507 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9508
d1dfb56c
EZ
95092011-04-16 Eli Zaretskii <eliz@gnu.org>
9510
c4354cb4
EZ
9511 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9512
d1dfb56c
EZ
9513 Fix regex.c, syntax.c and friends for buffers > 2GB.
9514 * syntax.h (struct gl_state_s): Declare character position members
9515 EMACS_INT.
9516
9517 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9518
04f2d78b
CB
9519 * textprop.c (verify_interval_modification, interval_of):
9520 Declare arguments EMACS_INT.
d1dfb56c
EZ
9521
9522 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9523 EMACS_INT.
9524
9525 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9526
9527 * indent.c (Fvertical_motion): Local variable it_start is now
9528 EMACS_INT.
9529
9530 * regex.c (re_match, re_match_2, re_match_2_internal)
9531 (bcmp_translate, regcomp, regexec, print_double_string)
9532 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9533 (re_compile_pattern, re_exec): Declare arguments and local
9534 variables `size_t' and `ssize_t' and return values `regoff_t', as
9535 appropriate.
9536 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9537 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9538 <compile_stack_type>: `size' and `avail' are now `size_t'.
9539
9540 * regex.h <regoff_t>: Use ssize_t, not int.
9541 (re_search, re_search_2, re_match, re_match_2): Arguments that
9542 specify buffer/string position and length are now ssize_t and
9543 size_t. Return type is regoff_t.
9544
613052cd
BK
95452011-04-16 Ben Key <bkey76@gmail.com>
9546
9547 * nsfont.m: Fixed bugs in ns_get_family and
9548 ns_descriptor_to_entity that were caused by using free to
9549 deallocate memory blocks that were allocated by xmalloc (via
9550 xstrdup). This caused Emacs to crash when compiled with
9551 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9552 --enable-checking=xmallocoverrun). xfree is now used to
9553 deallocate these memory blocks.
9554
4170f62f 95552011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 9556
71b41406
PE
9557 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9558
9587a89d
PE
9559 emacs_write: Accept and return EMACS_INT for sizes.
9560 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9561 et seq.
9562 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9563 Accept and return EMACS_INT.
9564 (emacs_gnutls_write): Return the number of bytes written on
9565 partial writes.
9566 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
9567 (emacs_read, emacs_write): Remove check for negative size, as the
9568 Emacs source code has been audited now.
9587a89d
PE
9569 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9570 (emacs_read, emacs_write): Use it.
273a5f82
PE
9571 * process.c (send_process): Adjust to the new signatures of
9572 emacs_write and emacs_gnutls_write. Do not attempt to store
9573 a byte offset into an 'int'; it might overflow.
9587a89d 9574 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 9575
3e047f51
PE
9576 * sound.c: Don't assume sizes fit in 'int'.
9577 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 9578 Return EMACS_INT, not int.
3e047f51 9579 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
9580 Accept EMACS_INT, not int.
9581 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
9582 record read return values.
9583
cc39a9db
BK
95842011-04-15 Ben Key <bkey76@gmail.com>
9585
c9d0ec6d
JB
9586 * keyboard.c (Qundefined): Don't declare static since it is used
9587 in nsfns.m.
9588 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9589 static since they are used in nsfont.m.
cc39a9db 9590
6c60eb9f
SM
95912011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9592
9593 * process.c (Qprocessp): Don't declare static.
9594 * lisp.h (Qprocessp): Declare again.
9595
7990b61a
JB
95962011-04-15 Juanma Barranquero <lekktu@gmail.com>
9597
9598 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9599
5d4cb038
PE
96002011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9601
8bd7b830 9602 Improve C-level modularity by making more things 'static'.
cd64ea1d 9603
e3b27b31
PE
9604 Don't publish debugger-only interfaces to other modules.
9605 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9606 (verify_bytepos, count_markers): Move decls to the only modules
9607 that need them.
9608 * region-cache.h (pp_cache): Likewise.
9609 * window.h (check_all_windows): Likewise.
9610 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9611
5d4cb038
PE
9612 * sysdep.c (croak): Now static, if
9613 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9614 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
9615
9616 * alloc.c (refill_memory_reserve): Now static if
9617 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9618 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 9619
e87b6180
PE
9620 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9621 Define only if USE_LUCID.
9622
ac64929e
PE
9623 * xrdb.c (x_customization_string, x_rm_string): Now static.
9624
6f37259d
PE
9625 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9626 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9627
1683e3ab
PE
9628 * xdisp.c (draw_row_with_mouse_face): Now static.
9629 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9630
de9c2632
PE
9631 * window.h (check_all_windows): Mark externally visible.
9632
2b96acb7
PE
9633 * window.c (window_deletion_count): Now static.
9634
9635 * undo.c: Make symbols static if they're not exported.
9636 (last_undo_buffer, last_boundary_position, pending_boundary):
9637 Now static.
9638
50436f33
PE
9639 * textprop.c (interval_insert_behind_hooks): Now static.
9640 (interval_insert_in_front_hooks): Likewise.
9641
64520e5c
PE
9642 * term.c: Make symbols static if they're not exported.
9643 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9644 (max_frame_lines, tty_set_terminal_modes):
9645 (tty_reset_terminal_modes, tty_turn_off_highlight):
9646 (get_tty_terminal): Now static.
9647 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9648 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 9649 HAVE_WINDOW_SYSTEM.
64520e5c
PE
9650 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9651 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9652
1fa53021
PE
9653 * sysdep.c: Make symbols static if they're not exported.
9654 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9655 Now static.
9656 (sigprocmask_set, full_mask): Remove; unused.
9657 (wait_debugging): Mark as visible.
9658 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9659 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9660
d4b43b22
PE
9661 * syntax.c (syntax_temp): Define only if !__GNUC__.
9662
b7c513d0
PE
9663 * sound.c (current_sound_device, current_sound): Now static.
9664
989b29ad
PE
9665 * search.c (searchbufs, searchbuf_head): Now static.
9666
13a55a78
PE
9667 * scroll.c (scroll_cost): Remove; unused.
9668 * dispextern.h (scroll_cost): Remove decl.
9669
de68a1fc
PE
9670 * region-cache.h (pp_cache): Mark as externally visible.
9671
40ccffa6
PE
9672 * process.c: Make symbols static if they're not exported.
9673 (process_tick, update_tick, create_process, chan_process):
9674 (Vprocess_alist, proc_buffered_char, datagram_access):
9675 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9676 (deactivate_process): Mark defn as static, as well as decl.
9677 * lisp.h (create_process): Remove decl.
9678 * process.h (chan_process, Vprocess_alist): Remove decls.
9679
ad64fc97
PE
9680 * print.c: Make symbols static if they're not exported.
9681 (print_depth, new_backquote_output, being_printed, print_buffer):
9682 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9683 (print_interval, print_number_index, initial_stderr_stream):
9684 Now static.
9685 * lisp.h (Fprinc): Remove decl.
9686 (debug_output_compilation_hack): Mark as externally visible.
9687
adddb265
PE
9688 * sysdep.c (croak): Move decl from here to syssignal.h.
9689 * syssignal.h (croak): Put it here, so the API can be checked when
9690 'croak' is called from dissociate_if_controlling_tty.
9691
1717ede2
PE
9692 * minibuf.c: Make symbols static if they're not exported.
9693 (minibuf_save_list, choose_minibuf_frame): Now static.
9694 * lisp.h (choose_minibuf_frame): Remove decl.
9695
fa5fb2bc
PE
9696 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9697
1e3890d1
PE
9698 * lread.c: Make symbols static if they're not exported.
9699 (read_objects, initial_obarray, oblookup_last_bucket_number):
9700 Now static.
9701 (make_symbol): Remove; unused.
9702 * lisp.h (initial_obarray, make_symbol): Remove decls.
9703
8a1414fa
PE
9704 * keyboard.c: Make symbols static if they're not exported.
9705 (single_kboard, recent_keys_index, total_keys, recent_keys):
9706 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9707 (this_single_command_key_start, echoing, last_auto_save):
9708 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9709 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9710 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9711 (Vlispy_mouse_stem, double_click_count):
9712 Now static.
9713 (force_auto_save_soon): Define only if SIGDANGER.
9714 (ignore_mouse_drag_p): Now static if
9715 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9716 (print_help): Remove; unused.
9717 (stop_character, last_timer_event): Mark as externally visible.
9718 * keyboard.h (ignore_mouse_drag_p): Declare only if
9719 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9720 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9721 * lisp.h (echoing): Remove decl.
9722 (force_auto_save_soon): Declare only if SIGDANGER.
9723 * xdisp.c (redisplay_window): Simplify code, to make it more
9724 obvious that ignore_mouse_drag_p is not accessed if !defined
9725 USE_GTK && !defined HAVE_NS.
9726
93ea6e8f
PE
9727 * intervals.c: Make symbols static if they're not exported.
9728 (merge_properties_sticky, merge_interval_right, delete_interval):
9729 Now static.
9730 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9731
77382fcc
PE
9732 * insdel.c: Make symbols static if they're not exported.
9733 However, leave prepare_to_modify_buffer alone. It's never
9734 called from outside this function, but that appears to be a bug.
9735 (combine_after_change_list, combine_after_change_buffer):
4889fc82 9736 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
9737 (adjust_after_replace_noundo): Remove; unused.
9738 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 9739 (signal_before_change): Remove decls.
77382fcc 9740
9306c32e
PE
9741 * indent.c (val_compute_motion, val_vmotion): Now static.
9742
cd44d2eb
PE
9743 * image.c: Make symbols static if they're not exported.
9744 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9745 if USE_GTK.
9746 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9747 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9748
ad9a7a06
PE
9749 * fringe.c (standard_bitmaps): Now static.
9750 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9751
81626931
PE
9752 * frame.c: Make symbols static if they're not exported.
9753 (x_report_frame_params, make_terminal_frame): Now static.
9754 (get_frame_param): Now static, unless HAVE_NS.
9755 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9756 (x_get_resource_string): Remove; not used.
9757 * frame.h (make_terminal_frame, x_report_frame_params):
9758 (x_get_resource_string); Remove decls.
9759 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9760 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9761
239f9db9
PE
9762 * font.c, fontset.c: Make symbols static if they're not exported.
9763 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9764 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9765 * font.c (font_close_object): Now static.
9766 * font.h (font_close_object): Remove.
9767 * fontset.c (FONTSET_OBJLIST): Remove.
9768 (free_realized_fontset) #if-0 the body, which does nothing.
9769 (face_suitable_for_char_p): #if-0, as it's never called.
9770 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
9771 * xfaces.c (face_at_string_position):
9772 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
9773 since 0 is always ASCII.
9774
dfcf3579
PE
9775 * fns.c (weak_hash_tables): Now static.
9776
5045092b
PE
9777 * fileio.c: Make symbols static if they're not exported.
9778 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9779 (Vwrite_region_annotation_buffers): Now static.
9780
57a96f5c
PE
9781 * eval.c: Make symbols static if they're not exported.
9782 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9783 * lisp.h (backtrace_list): Remove decl.
9784
35f08c38
PE
9785 * emacs.c: Make symbols static if they're not exported.
9786 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9787 (fatal_error_code, fatal_error_signal_hook, standard_args):
9788 Now static.
9789 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9790 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9791 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9792 * lisp.h (fatal_error_signal_hook): Remove decl.
9793 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9794
f44bd759
PE
9795 * editfns.c: Move a (normally-unused) function to its only use.
9796 * editfns.c, lisp.h (get_operating_system_release): Remove.
9797 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9798 worth the hassle of breaking this out.
9799
b532497d
PE
9800 * xterm.c: Make symbols static if they're not exported.
9801 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9802 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9803 (x_destroy_window, x_delete_display):
9804 Now static.
9805 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9806 (x_mouse_leave): Remove; unused.
9807 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9808 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9809 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9810 Remove decls.
9811 (x_mouse_leave): Declare only if WINDOWSNT.
9812 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9813 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9814 USE_X_TOOLKIT.
9815
1675728f
PE
9816 * ftxfont.c: Make symbols static if they're not exported.
9817 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9818 HAVE_FREETYPE.
9819 * font.h (ftxfont_driver): Likewise.
9820
e4cebfca
PE
9821 * xfns.c: Make symbols static if they're not exported.
9822 (x_last_font_name, x_display_info_for_name):
9823 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9824 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9825 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9826 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9827 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9828 (last_show_tip_args): Now static.
9829 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9830 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9831 (x_screen_planes): Remove; unused.
9832 * dispextern.h (x_screen_planes): Remove decl.
9833
5bf46f05
PE
9834 * dispnew.c: Make symbols static if they're not exported.
9835 * dispextern.h (redraw_garbaged_frames, scrolling):
9836 (increment_row_positions): Remove.
9837 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9838 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9839 Now static.
9840 (redraw_garbaged_frames): Remove; unused.
9841
435f4c28
PE
9842 * xfaces.c: Make symbols static if they're not exported.
9843 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9844 Remove decls.
9845 * xterm.h (defined_color): Remove decls.
9846 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9847 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9848 (menu_face_changed_default, defined_color, free_realized_face):
9849 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9850 (ascii_face_of_lisp_face): Remove; unused.
9851
8524aef3
PE
9852 * xdisp.c: Make symbols static if they're not exported.
9853 * dispextern.h (scratch_glyph_row, window_box_edges):
9854 (glyph_to_pixel_coords, set_cursor_from_row):
9855 (get_next_display_element, set_iterator_to_next):
9856 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9857 (show_mouse_face): Remove decls
9858 * frame.h (message_buf_print): Likewise.
9859 * lisp.h (pop_message, set_message, check_point_in_composition):
9860 Likewise.
9861 * xterm.h (set_vertical_scroll_bar): Likewise.
9862 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9863 (message_buf_print, scratch_glyph_row, displayed_buffer):
9864 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9865 (get_next_display_element, show_mouse_face, window_box_edges):
9866 (frame_to_window_pixel_xy, check_point_in_composition):
9867 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9868 (glyph_to_pixel_coords): Remove; unused.
9869
16390cd2
PE
9870 * dired.c (file_name_completion): Now static.
9871
9872 * dbusbind.c (xd_in_read_queued_messages): Now static.
9873
a25f4dfa
PE
9874 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9875 * data.c (circular_list_error): Remove.
9876
14a9c8df
PE
9877 * commands.h (last_point_position, last_point_position_buffer):
9878 (last_point_position_window): Remove decls.
9879 * keyboard.c: Make these variables static.
9880
04f2d78b
CB
9881 * coding.h (coding, code_convert_region, encode_coding_gap):
9882 Remove decls.
74ab6df5
PE
9883 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9884 (iso_code_class, detect_coding, code_convert_region): Now static.
9885 (encode_coding_gap): Remove; unused.
9886
38dfbee1
PE
9887 * chartab.c (chartab_chars, chartab_bits): Now static.
9888
a2cb4e63
PE
9889 * charset.h (charset_iso_8859_1): Remove decl.
9890 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9891 Now static.
9892
127198fd
PE
9893 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9894 * ccl.c (Vccl_program_table): Now static.
9895 (check_ccl_update): Remove; unused.
9896
d85b608f
PE
9897 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9898 * category.h: ... from here.
9899 * category.c (check_category_table, set_category_set): Now static.
9900
31cd66f3
PE
9901 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9902 * lisp.h: Remove these decls.
9903
c358e587
PE
9904 * buffer.c (buffer_count): Remove unused var.
9905
e78aecca
PE
9906 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9907 so that it's not optimized away.
9908 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9909 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9910 exported only to the debugger.
9911
e192d7d3 9912 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 9913 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 9914
92470028
PE
9915 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9916 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9917 was inaccessible from Lisp.
9918 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9919 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9920
244ed907
PE
9921 alloc.c: Import and export fewer symbols, and remove unused items.
9922 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9923 is defined.
9924 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9925 it's not optimized away by whole-program optimization.
9926 (message_enable_multibyte, free_misc): Remove.
9927 (catchlist, handlerlist, mark_backtrace):
9928 Declare only if BYTE_MARK_STACK.
9929 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9930 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9931 (message_enable_multibyte): Remove decl.
9932 (free_misc, interval_free_list, float_block, float_block_index):
9933 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9934 (cons_free_list, last_marked_index):
9935 Now static.
9936 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9937 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9938 (mark_backtrace): Define only if BYTE_MARK_STACK.
9939 * xdisp.c (message_enable_multibyte): Now static.
9940
61c2b50e 9941 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
9942 This makes it easier for human readers (and static analyzers)
9943 to see whether these variables are used from other modules.
9944 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9945 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9946 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9947 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9948 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9949 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9950 * xmenu.c, xselect.c:
9951 Declare Q* vars static if they are not used in other modules.
9952 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9953 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9954 Remove decls of unexported vars.
9955 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9956
95c82688
PE
9957 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9958
16a97296
PE
9959 Make Emacs functions such as Fatom 'static' by default.
9960 This makes it easier for human readers (and static analyzers)
9961 to see whether these functions can be called from other modules.
9962 DEFUN now defines a static function. To make the function external
9963 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
9964 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9965 (Finit_image_library):
16a97296
PE
9966 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9967 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9968 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9969 Remove decls, since these functions are now static.
9970 (Funintern, Fget_internal_run_time): New decls, since these functions
9971 were already external.
95c82688 9972
16a97296
PE
9973 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9974 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9975 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9976 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9977 * keyboard.c, keymap.c, lread.c:
9978 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9979 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9980 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9981 Mark functions with DEFUE instead of DEFUN,
9982 if they are used in other modules.
9983 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9984 decls for now-static functions.
9985 * buffer.h (Fdelete_overlay): Remove decl.
9986 * callproc.c (Fgetenv_internal): Mark as internal.
9987 * composite.c (Fremove_list_of_text_properties): Remove decl.
9988 (Fcomposition_get_gstring): New forward static decl.
9989 * composite.h (Fcomposite_get_gstring): Remove decl.
9990 * dired.c (Ffile_attributes): New forward static decl.
9991 * doc.c (Fdocumntation_property): New forward static decl.
9992 * eval.c (Ffetch_bytecode): New forward static decl.
9993 (Funintern): Remove extern decl; now in .h file where it belongs.
9994 * fileio.c (Fmake_symbolic_link): New forward static decl.
9995 * image.c (Finit_image_library): New forward static decl.
9996 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9997 * intervals.h (Fprevious_property_change):
9998 (Fremove_list_of_text_properties): Remove decls.
9999 * keyboard.c (Fthis_command_keys): Remove decl.
10000 (Fcommand_execute): New forward static decl.
10001 * keymap.c (Flookup_key): New forward static decl.
10002 (Fcopy_keymap): Now static.
10003 * keymap.h (Flookup_key): Remove decl.
10004 * process.c (Fget_process): New forward static decl.
10005 (Fprocess_datagram_address): Mark as internal.
10006 * syntax.c (Fsyntax_table_p): New forward static decl.
10007 (skip_chars): Remove duplicate decl.
10008 * textprop.c (Fprevious_property_change): New forward static decl.
10009 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10010 Now internal.
10011 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10012 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10013
785bbd42
PE
10014 * editfns.c (Fformat): Remove unreachable code.
10015
8b913b57
AS
100162011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10017
10018 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10019 change. (Bug#8496)
10020
a6744a35
EZ
100212011-04-13 Eli Zaretskii <eliz@gnu.org>
10022
10023 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10024 when at ZV. (Bug#8487)
10025
e7974947
AS
100262011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10027
baad03f0
AS
10028 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10029 (Bug#8437)
10030 * keyboard.c (parse_tool_bar_item): Likewise.
10031 * sound.c (sound_cleanup, alsa_close): Likewise.
10032 * termcap.c (tgetent): Likewise.
10033 * xfns.c (x_default_font_parameter): Likewise.
10034 * xsettings.c (read_and_apply_settings): Likewise.
10035
e7974947
AS
10036 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10037 (overrun_check_free): Protoize.
10038
28272684
PE
100392011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10040
10041 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10042 since callers should never pass a negative size.
10043 Change the signature to match that of plain 'read' and 'write'; see
10044 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10045 * lisp.h: Update prototypes of emacs_write and emacs_read.
10046
11997c76
EZ
100472011-04-11 Eli Zaretskii <eliz@gnu.org>
10048
10049 * xdisp.c (redisplay_window): Don't try to determine the character
10050 position of the scroll margin if the window start point w->startp
e896f03c 10051 is outside the buffer's accessible region. (Bug#8468)
11997c76 10052
8a2cbd72
EZ
100532011-04-10 Eli Zaretskii <eliz@gnu.org>
10054
10055 Fix write-region and its subroutines for buffers > 2GB.
10056 * fileio.c (a_write, e_write): Modify declaration of arguments and
10057 local variables to support buffers larger than 2GB.
10058 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10059
10060 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10061 argument, local variables, and return value.
10062
10063 * lisp.h: Update prototypes of emacs_write and emacs_read.
10064
10065 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10066
4073e537 100672011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10068
1ebfdcb6
PE
10069 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10070
b2ded58d
PE
10071 Fix more problems found by GCC 4.6.0's static checks.
10072
7d66342c
PE
10073 * xdisp.c (vmessage): Use a better test for character truncation.
10074
bbf47d44
PE
10075 * charset.c (load_charset_map): <, not <=, for optimization,
10076 and to avoid potential problems with integer overflow.
9248994d 10077 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10078 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10079 * editfns.c (Fformat): Likewise.
1e69125e 10080 * syntax.c (skip_chars): Likewise.
3befa583 10081
e3019616
PE
10082 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10083 This also lets GCC 4.6.0 generate slightly better loop code.
10084
becfa255
PE
10085 * callint.c (Fcall_interactively): <, not <=, for optimization.
10086 (Fcall_interactively): Count the number of arguments produced,
10087 not the number of arguments given. This is simpler and lets GCC
10088 4.6.0 generate slightly better code.
10089
dae0cd48
PE
10090 * ftfont.c: Distingish more carefully between FcChar8 and char.
10091 The previous code passed unsigned char * to a functions like
10092 strlen and xstrcasecmp that expect char *, which does not
10093 conform to the C standard.
10094 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10095 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10096 char * when the C standard requires it.
10097
76032d70
PE
10098 * keyboard.c (read_char): Remove unused var.
10099
eb3f1cc8
PE
10100 * eval.c: Port to Windows vsnprintf (Bug#8435).
10101 Include <limits.h>.
10102 (SIZE_MAX): Define if the headers do not.
10103 (verror): Do not give up if vsnprintf returns a negative count.
10104 Instead, grow the buffer. This ports to Windows vsnprintf, which
10105 does not conform to C99. Problem reported by Eli Zaretskii.
10106 Also, simplify the allocation scheme, by avoiding the need for
10107 calling realloc, and removing the ALLOCATED variable.
10108
70476b54
PE
10109 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10110
12020a9e
PE
10111 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10112 But keep the doprint source code for now, as we might revamp it
10113 and use it again (Bug#8435).
ea6c7ae6
PE
10114 * lisp.h (doprnt): Remove.
10115 * Makefile.in (base_obj): Remove doprnt.o.
10116 * deps.mk (doprnt.o): Remove.
10117
5fdb398c
PE
10118 error: Print 32- and 64-bit integers portably (Bug#8435).
10119 Without this change, on typical 64-bit hosts error ("...%d...", N)
10120 was used to print both 32- and 64-bit integers N, which relied on
10121 undefined behavior.
61bdb816 10122 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10123 * lisp.h (error, verror): Mark as printf-like functions.
10124 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10125 Report overflow in size calculations when allocating printf buffer.
10126 Do not truncate output string at its first null byte.
10127 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10128 Truncate the output at a character boundary, since vsnprintf does not
10129 do that.
10130 * charset.c (check_iso_charset_parameter): Convert internal
10131 character to string before calling 'error', since %c now has the
10132 printf meaning.
10133 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10134 overflow when computing char to be passed to 'error'. Do not
10135 pass Lisp_Object to 'error'; pass the integer instead.
10136 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10137 formatted with plain %d.
10138
b189fa66
PE
10139 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10140
bff87ef0
PE
10141 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10142
7e2cac20
PE
10143 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10144
ce4d90b5
PE
10145 * xterm.c (x_catch_errors): Remove duplicate declaration.
10146
266c9547
PE
10147 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10148
79c49ad2
PE
10149 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10150
368f4090
JM
101512011-04-10 Jim Meyering <meyering@redhat.com>
10152
10153 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10154 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10155 return ssize_t not "int", and use size_t as the buffer length.
10156 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10157 * gnutls.h: Update declarations.
10158 * process.c (read_process_output): Use ssize_t, to match.
10159 (send_process): Likewise.
10160
a32d4040
CY
101612011-04-09 Chong Yidong <cyd@stupidchicken.com>
10162
10163 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10164
8546720e 101652011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10166
04f2d78b
CB
10167 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10168 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10169
8546720e
GM
10170 * xterm.c (handle_one_xevent):
10171 * xmenu.c (create_and_show_popup_menu):
10172 * xselect.c (x_decline_selection_request)
10173 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10174
0a2f5c1a 101752011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10176
10177 Fix some uses of `int' instead of EMACS_INT.
10178 * search.c (string_match_1, fast_string_match)
10179 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10180 (scan_buffer, find_next_newline_no_quit)
10181 (find_before_next_newline, search_command, Freplace_match)
10182 (Fmatch_data): Make some `int' variables be EMACS_INT.
10183
10184 * xdisp.c (display_count_lines): 3rd argument and return value now
10185 EMACS_INT. All callers changed.
10186 (pint2hrstr): Last argument is now EMACS_INT.
10187
10188 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10189 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10190 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10191 (decode_coding_utf_16, decode_coding_emacs_mule)
10192 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10193 (decode_coding_ccl, decode_coding_charset)
10194 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10195 (decode_coding_iso_2022, decode_coding_emacs_mule)
10196 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10197 <char_offset, last_offset>: Declare EMACS_INT.
10198 (encode_coding_utf_8, encode_coding_utf_16)
10199 (encode_coding_emacs_mule, encode_invocation_designation)
10200 (encode_designation_at_bol, encode_coding_iso_2022)
10201 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10202 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10203 Declare EMACS_INT.
10204 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10205 (encode_invocation_designation): Last argument P_NCHARS is now
10206 EMACS_INT.
10207 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10208 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10209
10210 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10211 All users changed.
10212
10213 * ccl.c (Fccl_execute_on_string): Declare some variables
10214 EMACS_INT.
10215
8546720e 102162011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10217
10218 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10219
4e19a977
CS
102202011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10221
10222 * process.c (Fformat_network_address): Doc fix.
10223
87302331
R
102242011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10225
ee7683eb 10226 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10227
cbb59342
CY
102282011-04-08 Chong Yidong <cyd@stupidchicken.com>
10229
10230 * keyboard.c (read_char): Call Lisp function help-form-show,
10231 instead of using internal_with_output_to_temp_buffer.
10232 (Qhelp_form_show): New var.
e0d38eeb 10233 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10234
10235 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10236
10237 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10238
e67a13ab
CY
102392011-04-06 Chong Yidong <cyd@stupidchicken.com>
10240
04f2d78b
CB
10241 * process.c (Flist_processes): Remove to Lisp.
10242 (list_processes_1): Delete.
e67a13ab 10243
973f782d
EZ
102442011-04-06 Eli Zaretskii <eliz@gnu.org>
10245
7c106b1e
EZ
10246 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10247
973f782d
EZ
10248 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10249
41cf7d1a 102502011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10251
ca23cc88
PE
10252 Fix more problems found by GCC 4.6.0's static checks.
10253
f390e2d5
PE
10254 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10255
42eea0d0
PE
10256 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10257
b69769da 10258 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10259
f9541e84
PE
10260 * xdisp.c (vmessage): Mark as a printf-like function.
10261
13841b55
PE
10262 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10263
c136c10f
PE
10264 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10265
5e2d4a30
PE
10266 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10267 printf-like functions.
10268 (tiff_load): Add casts to remove these marks before passing them
10269 to system-supplied API.
10270
583f48b9
PE
10271 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10272
b25d760e
PE
10273 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10274 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10275 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10276 directly, rather than having caller test rule sign. This avoids
10277 some unnecessary tests.
10278 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10279 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10280 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10281
bc7b6697 10282 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10283 (xfont_open): Avoid unnecessary tests.
bc7b6697 10284
27ccc379
PE
10285 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10286
dcd5c89a
PE
10287 * composite.h, composite.c (composition_gstring_put_cache):
10288 Use EMACS_INT, not int, for length.
10289
b13a45c6
PE
10290 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10291 breaking out part of COMPOSITION_DECODE_RULE.
10292 (COMPOSITION_DECODE_RULE): Use it.
10293 * composite.c (get_composition_id): Remove unused local vars,
10294 by using the new macro.
10295
1e792e4d
PE
10296 * textprop.c (set_text_properties_1): Change while to do-while,
10297 since the condition is always true at first.
10298
dc6c6455 10299 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10300 (interval_deletion_adjustment): Return unsigned value.
10301 All uses changed.
dc6c6455 10302
aba7731a
PE
10303 * process.c (list_processes_1, create_pty, read_process_output):
10304 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10305 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10306 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10307 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10308 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10309
fdfc4bf3
PE
10310 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10311
fca8fe46 10312 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10313 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10314
06a0259a 10315 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10316 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10317 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10318
e7b9e80f
PE
10319 * print.c (print_error_message): Avoid int overflow.
10320
56201685
PE
10321 * font.c (font_list_entities): Redo for clarity,
10322 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10323
78834453 10324 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10325 (font_score): Avoid potential overflow in diff calculation.
78834453 10326
0bc0b309 10327 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10328 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10329
e610eaca
PE
10330 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10331
b895abce
PE
10332 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10333 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10334 can always succeed if overflow has undefined behavior.
10335
1f1d9321 10336 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10337 (wordify): Omit three unnecessary tests.
1f1d9321 10338
c59478bc
PE
10339 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10340 All callers changed. This avoids the need for an unused var.
10341
79b73827
PE
10342 * casefiddle.c (casify_region): Remove var that is set but not used.
10343
a4db5dfe
PE
10344 * dired.c (file_name_completion): Remove var that is set but not used.
10345
43aae36e
PE
10346 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10347
2a47c44d 10348 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10349 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10350
a37c69bf
PE
10351 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10352 Check for integer overflow on size calculations.
10353
328ab8e7
PE
10354 * buffer.c (Fprevious_overlay_change): Remove var that is set
10355 but not used.
10356
e5a2a5cb
PE
10357 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10358 Remove vars that are set but not used.
8d84a6eb 10359 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10360 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10361
a60e5f68
PE
10362 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10363
f661cb61 10364 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10365 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10366
f0397f5a
PE
10367 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10368 that are set but not used.
10369
8664db06 10370 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10371 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10372
6abdaa4a
PE
10373 * xselect.c (x_get_local_selection, x_handle_property_notify):
10374 Remove vars that are set but not used.
10375
0ce7538d 10376 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10377 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10378
9ae848fc
PE
10379 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10380 Remove var that is set but not used.
0b918413
PE
10381 (scroll_bar_windows_size): Now size_t, not int.
10382 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10383 Check for overflow.
9ae848fc 10384
a5a62657
PE
10385 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10386 (map_tty_color) [!defined MSDOS]: Likewise.
10387
5c5cdd39
PE
10388 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10389
66ebf983
PE
10390 * coding.c: Remove vars that are set but not used.
10391 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10392 All callers changed.
10393 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10394 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10395 (decode_coding_charset): Remove vars that are set but not used.
10396
1be4d761
PE
10397 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10398 that is set but not used.
10399
47553fa8
PE
10400 * print.c (print_object): Remove var that is set but not used.
10401
1f7196bf 10402 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10403 The gnulib version avoids calling malloc in the usual case,
10404 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10405 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10406 * filelock.c (current_lock_owner): Likewise.
10407 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10408 * sysdep.c: Include allocator.h, careadlinkat.h.
10409 (emacs_no_realloc_allocator): New static constant.
10410 (emacs_readlink): New function.
fdb61804
PE
10411 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10412 ../lib/careadlinkat.h.
d1fdcab7 10413
f84c17c7
SM
104142011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10415
10416 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10417 first non-nil return value).
10418
ef3862ad
JD
104192011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10420
10421 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10422 if not defined (Bug#8403).
10423
376a7006
JB
104242011-04-02 Juanma Barranquero <lekktu@gmail.com>
10425
10426 * xdisp.c (display_count_lines): Remove parameter `start',
10427 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10428 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10429 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10430 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10431 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10432 and thereabouts. All callers changed.
10433 (get_per_char_metric): Remove parameter `f', unused since
10434 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10435
6ca3801d
JM
104362011-04-02 Jim Meyering <meyering@redhat.com>
10437
10438 do not dereference NULL upon failed strdup
10439 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10440 (ns_get_family): Likewise.
10441
d8e2b5ba
JB
104422011-04-02 Juanma Barranquero <lekktu@gmail.com>
10443
10444 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10445
8c74fcbd
JD
104462011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10447
10448 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10449 later (Bug#8403).
10450
7200d79c
SM
104512011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10452
03408648 10453 Add lexical binding.
7200d79c 10454
03408648
SM
10455 * window.c (Ftemp_output_buffer_show): New fun.
10456 (Fsave_window_excursion):
10457 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10458
10459 * lread.c (lisp_file_lexically_bound_p): New function.
10460 (Fload): Bind Qlexical_binding.
10461 (readevalloop): Remove `evalfun' arg.
10462 Bind Qinternal_interpreter_environment.
10463 (Feval_buffer): Bind Qlexical_binding.
10464 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10465 Mark as dynamic.
10466 (syms_of_lread): Declare `lexical-binding'.
10467
10468 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10469
10470 * keyboard.c (eval_dyn): New fun.
10471 (menu_item_eval_property): Use it.
ca105506
SM
10472
10473 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10474
03408648
SM
10475 * fns.c (concat, mapcar1): Accept byte-code-functions.
10476
10477 * eval.c (Fsetq): Handle lexical vars.
10478 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10479 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10480 (FletX, Flet): Obey lexical binding.
10481 (Fcommandp): Handle closures.
10482 (Feval): New `lexical' arg.
10483 (eval_sub): New function extracted from Feval. Use it almost
10484 everywhere where Feval was used. Look up vars in lexical env.
10485 Handle closures.
10486 (Ffunctionp): Move from subr.el.
10487 (Ffuncall): Handle closures.
10488 (apply_lambda): Remove `eval_flags'.
10489 (funcall_lambda): Handle closures and new byte-code-functions.
10490 (Fspecial_variable_p): New function.
10491 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10492 but without exporting it to Lisp.
23aba0ea 10493
23aba0ea 10494 * doc.c (Fdocumentation, store_function_docstring):
03408648 10495 * data.c (Finteractive_form): Handle closures.
23aba0ea 10496
03408648
SM
10497 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10498 interactive spec.
ba83908c 10499
04f2d78b
CB
10500 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10501 New byte-codes.
03408648
SM
10502 (exec_byte_code): New function extracted from Fbyte_code to handle new
10503 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10504
03408648 10505 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10506
03408648 10507 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10508
e2abce01
JB
105092011-03-31 Juanma Barranquero <lekktu@gmail.com>
10510
10511 * xdisp.c (redisplay_internal): Fix prototype.
10512
63696a73 105132011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10514
63696a73 10515 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10516 (try_scrolling): Use it when setting scroll_limit.
10517 Limit scrolling to 100 screen lines.
63696a73
EZ
10518 (redisplay_window): Even when falling back on "recentering",
10519 position point in the window according to scroll-conservatively,
10520 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10521
10522 (try_scrolling): When point is above the window, allow searching
10523 as far as scroll_max, or one screenful, to compute vertical
10524 distance from PT to the scroll margin position. This prevents
10525 try_scrolling from unnecessarily failing when
10526 scroll-conservatively is set to a value slightly larger than the
10527 window height. Clean up the case of PT below the margin at bottom
10528 of window: scroll_max can no longer be INT_MAX. When aggressive
10529 scrolling is in use, don't let point enter the opposite scroll
10530 margin as result of the scroll.
10531 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10532 threshold of 100 lines for never-recentering scrolling.
10533
e4cc2dfc
JB
105342011-03-31 Juanma Barranquero <lekktu@gmail.com>
10535
10536 * dispextern.h (move_it_by_lines):
10537 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10538 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10539 (message_log_check_duplicate): Remove parameters `prev_bol' and
10540 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10541 (redisplay_internal): Remove parameter `preserve_echo_area',
10542 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10543
10544 * indent.c (Fvertical_motion):
10545 * window.c (window_scroll_pixel_based, Frecenter):
10546 Don't pass `need_y_p' to `move_it_by_lines'.
10547
1c470562
SM
105482011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10549
44f230aa
SM
10550 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10551 steal a few bits to be more compact.
10552 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10553 Remove unneeded casts.
10554
1c470562
SM
10555 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10556
888adce9
ZK
105572011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10558
10559 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10560 binding" message (bug#7967).
10561
f838ed7b
PE
105622011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10563
77861b95
PE
10564 Fix more problems found by GCC 4.6.0's static checks.
10565
de6dbc14
PE
10566 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10567 Remove unused local var.
10568
f838ed7b
PE
10569 * editfns.c (Fmessage_box): Remove unused local var.
10570
792c7b2b
PE
10571 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10572 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10573 Omit unused local vars.
c499e557 10574 * window.c (shrink_windows): Omit unused local var.
b01a1c29 10575 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
10576 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10577 Omit unused local var.
10578
ba0165e1
PE
10579 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10580 Don't assume string length fits in int.
32ad8845 10581 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 10582 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 10583
3c59b4c9
PE
10584 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10585 instead of alloca (Bug#8344).
10586
a3eed478 10587 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 10588 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 10589
eb4d412d
PE
10590 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10591
1658b401
PE
10592 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10593 concerns.
10594
10595 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10596
10597 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 10598
9a2c6e05
PE
10599 * keyboard.c (syms_of_keyboard): Use the same style as later
10600 in this function when indexing through an array. This also
10601 works around GCC bug 48267.
10602
03d0a109
PE
10603 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10604
44f730c8
PE
10605 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10606
fe75f926
PE
10607 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10608 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10609
ffa8c828
PE
10610 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10611 This avoids undefined behavior on integer overflow, and is a bit
10612 more convenient anyway since it is compared to a size_t variable.
10613
c5101a77
PE
10614 Variadic C functions now count arguments with size_t, not int.
10615 This avoids an unnecessary limitation on 64-bit machines, which
10616 caused (substring ...) to crash on large vectors (Bug#8344).
10617 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10618 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 10619 All variadic functions and their callers changed accordingly.
c5101a77
PE
10620 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10621 * data.c (arith_driver, float_arith_driver): Likewise.
10622 * editfns.c (general_insert_function): Likewise.
10623 * eval.c (struct backtrace.nargs, interactive_p)
10624 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10625 (funcall_lambda, mark_backtrace): Likewise.
10626 * fns.c (concat): Likewise.
10627 * frame.c (x_set_frame_parameters): Likewise.
10628 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10629 0 if not found, not -1. All callers changed.
10630
dd3f25f7
PE
10631 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10632 (stack_copy_size): Now size_t, not int.
10633 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10634
461c2ab9
JB
106352011-03-28 Juanma Barranquero <lekktu@gmail.com>
10636
10637 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10638 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10639 All callers changed.
10640
10641 * lisp.h (multibyte_char_to_unibyte):
10642 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10643 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10644 * character.h (CHAR_TO_BYTE8):
10645 * cmds.c (internal_self_insert):
10646 * editfns.c (general_insert_function):
10647 * keymap.c (push_key_description):
10648 * search.c (Freplace_match):
10649 * xdisp.c (message_dolog, set_message_1): All callers changed.
10650
f6d62986
SM
106512011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10652
10653 * keyboard.c (safe_run_hook_funcall): New function.
10654 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10655 don't set the hook to nil, but remove the offending function instead.
10656 (Qcommand_hook_internal): Remove, unused.
10657 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10658 Vcommand_hook_internal.
10659
10660 * eval.c (enum run_hooks_condition): Remove.
10661 (funcall_nil, funcall_not): New functions.
10662 (run_hook_with_args): Call each function through a `funcall' argument.
10663 Remove `cond' argument, now redundant.
10664 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10665 (Frun_hook_with_args_until_failure): Adjust accordingly.
10666 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10667
1db5b1ad
JB
106682011-03-28 Juanma Barranquero <lekktu@gmail.com>
10669
10670 * dispextern.h (string_buffer_position): Remove declaration.
10671
10672 * print.c (strout): Remove parameter `multibyte', unused since
10673 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10674
10675 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10676 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10677 All callers changed.
10678
10679 * w32.c (_wsa_errlist): Use braces for struct initializers.
10680
10681 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10682 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10683 All callers changed.
10684 (string_buffer_position): Likewise. Also, make static (it's never
10685 used outside xdisp.c).
10686 (cursor_row_p): Remove parameter `w', unused since
10687 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10688 (decode_mode_spec): Remove parameter `precision', introduced during
10689 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10690 All callers changed.
10691
5ffb62aa
JD
106922011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10693
10694 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10695
461c2ab9 106962011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
10697
10698 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10699 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10700 (ns_update_auto_hide_menu_bar): New functions.
10701 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10702 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10703 ns_constrain_all_frames.
10704 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10705 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10706
5c380ffb
JD
107072011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10708
10709 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10710
9af30bdf
GM
107112011-03-27 Glenn Morris <rgm@gnu.org>
10712
10713 * syssignal.h: Replace RETSIGTYPE with void.
10714 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10715 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10716 Replace SIGTYPE with void everywhere.
10717 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10718 * s/template.h (SIGTYPE): Remove commented out definition.
10719
e2abce01
JB
107202011-03-26 Eli Zaretskii <eliz@gnu.org>
10721
10722 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10723 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10724
f868cd8a
JB
107252011-03-26 Juanma Barranquero <lekktu@gmail.com>
10726
59eb0929
JB
10727 * w32.c (read_unc_volume): Use parameter `henum', instead of
10728 global variable `wget_enum_handle'.
10729
10730 * keymap.c (describe_vector): Remove parameters `indices' and
10731 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10732 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10733
f868cd8a
JB
10734 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10735
10736 * keyboard.c (timer_check): Remove parameter `do_it_now',
10737 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10738 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10739 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10740
10741 * keyboard.c (read_char):
10742 * w32menu.c (w32_menu_display_help):
10743 * xmenu.c (show_help_event, menu_help_callback):
10744 Adjust calls to `show_help_echo'.
10745
10746 * gtkutil.c (xg_maybe_add_timer):
10747 * keyboard.c (readable_events):
10748 * process.c (wait_reading_process_output):
10749 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10750
10751 * insdel.c (adjust_markers_gap_motion):
10752 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10753 (gap_left, gap_right): Don't call it.
10754
2ecf6fdb
CY
107552011-03-25 Chong Yidong <cyd@stupidchicken.com>
10756
10757 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10758 incurred during fontification.
10759
6b1f9ba4
JB
107602011-03-25 Juanma Barranquero <lekktu@gmail.com>
10761
10762 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10763 (DEFVAR_PER_BUFFER): Don't pass it.
10764
10765 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10766 (scrolling_window): Don't pass it.
10767
0f4a96b5
JB
107682011-03-25 Juanma Barranquero <lekktu@gmail.com>
10769
10770 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10771
10772 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10773 and `suffix'.
10774 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10775 of variables specific to SELinux and computation of `encoded_absname'.
10776
10777 * image.c (XPutPixel): Remove unused variable `height'.
10778
10779 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10780
10781 * unexw32.c (get_section_info): Remove unused variable `section'.
10782
10783 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10784 (system_process_attributes): Remove unused variable `sess'.
10785 (sys_read): Remove unused variable `err'.
10786
10787 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10788 (w32_wnd_proc): Remove unused variable `isdead'.
10789 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10790 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10791 (x_create_tip_frame): Remove unused variable `tem'.
10792
10793 * w32inevt.c (w32_console_read_socket):
10794 Remove unused variable `no_events'.
10795
10796 * w32term.c (x_draw_composite_glyph_string_foreground):
10797 Remove unused variable `width'.
10798
1149507c
JB
107992011-03-24 Juanma Barranquero <lekktu@gmail.com>
10800
10801 * w32term.c (x_set_glyph_string_clipping):
10802 Don't pass uninitialized region to CombineRgn.
10803
9c88f339
JB
108042011-03-23 Juanma Barranquero <lekktu@gmail.com>
10805
10806 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10807 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10808 (Fx_close_connection): Remove unused variable `i'.
10809
10810 * w32font.c (w32font_draw): Return number of glyphs.
10811 (w32font_open_internal): Remove unused variable `i'.
10812 (w32font_driver): Add missing initializer.
10813
10814 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10815 (fill_in_menu): Remove unused variable `items_added'.
10816
10817 * w32term.c (last_mouse_press_frame): Remove static global variable.
10818 (w32_clip_to_row): Remove unused variable `f'.
10819 (x_delete_terminal): Remove unused variable `i'.
10820
10821 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10822 (NOTHING): Remove unused static global variable.
10823 (uniscribe_check_otf): Remove unused variable `table'.
10824 (uniscribe_font_driver): Add missing initializers.
10825
dee091a3
JD
108262011-03-23 Julien Danjou <julien@danjou.info>
10827
10828 * term.c (Fsuspend_tty, Fresume_tty):
10829 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10830 * window.c (temp_output_buffer_show):
10831 * insdel.c (signal_before_change):
10832 * frame.c (Fhandle_switch_frame):
10833 * fileio.c (Fdo_auto_save):
10834 * emacs.c (Fkill_emacs):
10835 * editfns.c (save_excursion_restore):
10836 * cmds.c (internal_self_insert):
10837 * callint.c (Fcall_interactively):
10838 * buffer.c (Fkill_all_local_variables):
10839 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10840 Use Frun_hooks.
0f4a96b5 10841 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 10842 unconditionally since it does the check itself.
dee091a3 10843
2c520ab5 108442011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 10845
c9c49752
PE
10846 Fix more problems found by GCC 4.5.2's static checks.
10847
8abc3f12
PE
10848 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10849 the first time through the loop, since we know p0 < p1 then.
10850 This also avoids a gcc -Wstrict-overflow warning.
10851
a2d26660
PE
10852 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10853 leading to a memory leak, possible in functions like
10854 load_charset_map_from_file that can allocate an unbounded number
b12ef411 10855 of objects (Bug#8318).
a2d26660 10856
916c72e9
PE
10857 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10858 that could (at least in theory) be that large.
10859
19ab8a18
PE
10860 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10861 This is less likely to overflow, and avoids undefined behavior if
10862 overflow does occur. All callers changed. Use strtoul to scan
10863 for the unsigned long integer.
b7cbbd6f
PE
10864 (pint2hrstr): Simplify and tune code slightly.
10865 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 10866
f0641eff
PE
10867 * scroll.c (do_scrolling): Work around GCC bug 48228.
10868 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10869
7f650bb9
PE
10870 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10871 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
10872 (validate_x_resource_name): Simplify count usage.
10873 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 10874
37dd57d1
PE
10875 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10876 fail (Bug#8306).
81e56e61 10877
699979fc 10878 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 10879
401bf9b4
PE
10880 * process.c (Fmake_network_process): Use socklen_t, not int,
10881 where POSIX says socklen_t is required in portable programs.
10882 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 10883 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
10884 (Fmake_network_process, server_accept_connection):
10885 (wait_reading_process_output, read_process_output):
10886 Likewise.
10887
b93aacde
PE
10888 * process.c: Rename or move locals to avoid shadowing.
10889 (list_processes_1, Fmake_network_process):
10890 (read_process_output_error_handler, exec_sentinel_error_handler):
10891 Rename or move locals.
4dc343ee 10892 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 10893 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 10894 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 10895 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 10896 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 10897
af8a867c 10898 Make tparam.h and terminfo.c consistent.
44f230aa
SM
10899 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10900 Include tparam.h instead, since it declares them.
af8a867c
PE
10901 * cm.h (PC): Remove extern decl; tparam.h now does this.
10902 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10903 * terminfo.c: Include tparam.h, to check interfaces.
10904 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10905 (tparam): Adjust signature to match interface in tparam.h;
10906 this removes some undefined behavior. Check that outstring and len
10907 are zero, which they always are with Emacs.
10908 * tparam.h (PC, BC, UP): New extern decls.
10909
0248044d 10910 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 10911 (xftfont_open): Rename locals to avoid shadowing.
0248044d 10912
8ff096c1 10913 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
10914 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10915 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 10916 (ftfont_list): Remove unused local.
49eaafba
PE
10917 (get_adstyle_property, ftfont_pattern_entity):
10918 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10919 Rename locals to avoid shadowing.
8ff096c1 10920
e2be39f6
PE
10921 * xfont.c (xfont_list_family): Mark var as initialized.
10922
c9735e30
PE
10923 * xml.c (make_dom): Now static.
10924
8f5201ae
PE
10925 * composite.c (composition_compute_stop_pos): Rename local to
10926 avoid shadowing.
b246f932
PE
10927 (composition_reseat_it): Remove unused locals.
10928 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 10929 (composition_update_it): Mark var as initialized.
11b61122
PE
10930 (find_automatic_composition): Mark vars as initialized,
10931 with a FIXME (Bug#8290).
8f5201ae 10932
760fbc2c
PE
10933 character.h: Rename locals to avoid shadowing.
10934 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10935 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10936 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10937 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10938 to avoid shadowing.
10939
ff08eb85
PE
10940 * textprop.c (property_change_between_p): Remove; unused.
10941
fc7bf025
PE
10942 * intervals.c (interval_start_pos): Now static.
10943
235d7abc
PE
10944 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10945
44f230aa
SM
10946 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10947 Rename locals to avoid shadowing.
3e7d6594 10948
50060332
PE
10949 * sound.c (wav_play, au_play, Fplay_sound_internal):
10950 Fix pointer signedness.
d01f234b 10951 (alsa_choose_format): Remove unused local var.
c83b8872
PE
10952 (wav_play): Initialize a variable to 0, to prevent undefined
10953 behavior (Bug#8278).
50060332 10954
c4fc4e30
PE
10955 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10956
918436ed
PE
10957 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10958
c939f91b
PE
10959 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10960 clobbering (Bug#8298).
b9c7f648
PE
10961 * sysdep.c (sys_subshell): Likewise.
10962 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 10963
6bd8c144
PE
10964 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10965 This should get cleaned up, so that child_setup has the
10966 same signature on all platforms.
10967
7710357c 10968 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 10969 (relocate_fd): Rename locals to avoid shadowing.
7710357c 10970
c59da222
CY
109712011-03-22 Chong Yidong <cyd@stupidchicken.com>
10972
10973 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10974 not to be necessary, and produces flickering.
10975
66b87493
GM
109762011-03-20 Glenn Morris <rgm@gnu.org>
10977
10978 * config.in: Remove file.
10979
45b6f6d5
JB
109802011-03-20 Juanma Barranquero <lekktu@gmail.com>
10981
10982 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10983 are now in src/globals.h.
10984 (syms_of_minibuf): Remove spurious & from previous change.
10985
cd394be1 109862011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
10987
10988 * minibuf.c (completing-read-function): New variable.
10989 (completing-read-default): Rename from completing-read.
10990 (completing-read): Call completing-read-function.
10991
b14e3e21
CY
109922011-03-19 Juanma Barranquero <lekktu@gmail.com>
10993
10994 * xfaces.c (Fx_load_color_file):
10995 Read color file from absolute filename (bug#8250).
10996
f2b726e6
JB
109972011-03-19 Juanma Barranquero <lekktu@gmail.com>
10998
10999 * makefile.w32-in: Update dependencies.
11000
09f6ff02
EZ
110012011-03-17 Eli Zaretskii <eliz@gnu.org>
11002
11003 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11004
29a6015a
PE
110052011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11006
a3a6c54e
PE
11007 Fix more problems found by GCC 4.5.2's static checks.
11008
b766f867
PE
11009 * process.c (make_serial_process_unwind, send_process_trap):
11010 (sigchld_handler): Now static.
11011
be02381c
PE
11012 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11013 That way, the code declares only the vars that it needs.
11014 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11015 * s/cygwin.h (PTY_ITERATION): Likewise.
11016 * s/darwin.h (PTY_ITERATION): Likewise.
11017 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11018
57048744
PE
11019 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11020 * process.c (allocate_pty): Don't declare stb unless it's needed.
11021
7914961c 11022 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11023 (CONSTANTLIM): Remove; unused.
11024 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11025 Define only if needed.
7914961c 11026
b3967b18
PE
11027 * unexelf.c (unexec): Name an expression,
11028 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11029 Use a different way to cause a compilation error if anyone uses
11030 n rather than nn, a way that does not involve shadowing.
73366a00 11031 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11032
29a6015a
PE
11033 * deps.mk (unexalpha.o): Remove; unused.
11034
43cfc33e 11035 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11036 * unexec.h: New file.
ce701a33
PE
11037 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11038 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11039 Depend on unexec.h.
11040 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11041 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11042 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11043 Change as necessary to match prototype in unexec.h.
ce701a33 11044
01f44d5a
PE
11045 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11046 shadowing.
4f63c6bb 11047 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11048
a6670b0b
PE
11049 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11050 Rename locals to avoid shadowing.
11051
cef2010d 11052 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11053 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11054
d4d7173a
PE
11055 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11056
f08b802a
PE
11057 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11058 warning when compiling print.c.
11059
3ddb0639
PE
11060 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11061 instead of using an uninitialized var.
5ad03b97 11062 (font_sort_entities): Mark var as initialized.
3ddb0639 11063
170a2692
PE
11064 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11065
e663c700
PE
11066 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11067 pointers to constants.
89bc529a 11068 (font_parse_fcname): Remove unused vars.
7b81e2d0 11069 (font_delete_unmatched): Now static.
ea838e10 11070 (font_get_spec): Remove; unused.
13a547c6
PE
11071 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11072 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11073 Rename or move locals to avoid shadowing.
e663c700 11074
2a80c887 11075 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11076 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11077
1384fa33 11078 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11079 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11080
8b2c52e9
PE
11081 * alloc.c (mark_backtrace): Move decl from here ...
11082 * lisp.h: ... to here, so that it can be checked.
11083
475545b5 11084 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11085 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11086 (lisp_indirect_variable): Name an expression,
11087 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11088 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11089
b1349114 11090 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11091 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11092 Use const pointer when appropriate.
b1349114 11093
a2928364
PE
11094 * lisp.h (get_system_name, get_operating_system_release):
11095 Move decls here, to check interfaces.
11096 * process.c (get_operating_system_release): Move decl to lisp.h.
11097 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11098 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11099 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11100 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11101 (Fformat_time_string, Fencode_time, Finsert_char):
11102 (Ftranslate_region_internal, Fformat):
11103 Rename or remove local vars to avoid shadowing.
9710023e 11104 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11105
a415e694
PE
11106 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11107 avoid shadowing.
11108
8ef4622d
PE
11109 * lisp.h (eassert): Check that the argument compiles, even if
11110 ENABLE_CHECKING is not defined.
11111
946f9a5b
PE
11112 * data.c (Findirect_variable): Name an expression, to avoid
11113 gcc -Wbad-function-cast warning.
112396d6 11114 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11115 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11116 (Fmake_variable_buffer_local, Fmake_local_variable):
11117 Mark variables as initialized.
52746918 11118 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11119
e5aab7e7 11120 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11121 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11122 Rename locals to avoid shadowing.
dff45157
PE
11123 (mark_stack): Move local variables into the #ifdef region where
11124 they're used.
7bc26fdb
PE
11125 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11126 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11127 needed otherwise.
11128 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11129 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11130 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11131
e5aab7e7
PE
11132 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11133 avoids undefined behavior in theory.
11134
4da60324
PE
11135 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11136
88043301
PE
11137 Use functions, not macros, for up- and down-casing (Bug#8254).
11138 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11139 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11140 to use the following functions instead of these macros.
11141 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11142 EMACS_INT, since callers assume the returned value fits in int.
11143 (upcase1): Likewise, for UPCASE_TABLE.
11144 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11145 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11146 the race-condition problem in the old DOWNCASE.
88043301 11147
19ed5445
PE
11148 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11149 Rename locals to avoid shadowing.
11150 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11151 (regex_compile, re_search_2, re_match_2_internal):
11152 Remove unused local vars.
952db0d7
PE
11153 (FREE_VAR): Rewrite so as not to use empty "else",
11154 which gcc can warn about.
da053e48 11155 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11156 (RETALLOC_IF): Define only if needed.
11157 (WORDCHAR_P): Likewise. This one is never needed, but is used
11158 only in a comment talking about a compiler bug, so put inside
11159 the #if 0 of that comment.
11160 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11161 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11162 Remove; unused.
19ed5445 11163
1f3561e4 11164 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11165 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11166 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11167
ded6f8f7
PE
11168 * search.c (simple_search): Remove unused var.
11169
dbd37a95
PE
11170 * dired.c (compile_pattern): Move decl from here ...
11171 * lisp.h: ... to here, so that it can be checked.
11172 (struct re_registers): New forward decl.
11173
7e47afad
PE
11174 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11175
85f24f61
PE
11176 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11177 All uses changed.
11178 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11179 Rename locals to avoid shadowing.
5671df8f 11180 (Fvertical_motion): Mark locals as initialized.
85f24f61 11181
181aa2be 11182 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11183 (casify_region): Mark local as initialized.
181aa2be 11184
930d429c
PE
11185 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11186
7082eac6
PE
11187 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11188 New macros, so that the caller can use some names other than
11189 gcpro1, gcpro2, etc.
11190 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11191 of the new macros.
11192 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11193 argument, for consistency with GCPRO2_VAR, etc: it is now the
11194 prefix of the variable, not the variable itself. All uses
11195 changed.
38b2c076
PE
11196 * dired.c (directory_files_internal, file_name_completion):
11197 Rename locals to avoid shadowing.
11198
15206ed9
PE
11199 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11200 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11201 dired.c's scmp function, had undefined behavior.
11202 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11203 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11204 * buffer.h: ... to here, because these macros use current_buffer,
11205 and the new implementation with inline functions needs to have
11206 current_buffer in scope now, rather than later when the macros
11207 are used.
11208 (downcase, upcase1): New static inline functions.
11209 (DOWNCASE, UPCASE1): Reimplement using these functions.
11210 This avoids undefined behavior in expressions like
11211 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11212 from race conditions in accessing the global variables
11213 case_temp1 and case_temp2.
11214 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11215 * lisp.h (case_temp1, case_temp2): Remove their decls.
11216 * character.h (ASCII_CHAR_P): Move from here ...
11217 * lisp.h: ... to here, so that the inline functions mentioned
11218 above can use them.
11219
4a6bea26
PE
11220 * dired.c (directory_files_internal_unwind): Now static.
11221
f14b7e14
PE
11222 * fileio.c (file_name_as_directory, directory_file_name):
11223 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11224 Now static.
2893f146
PE
11225 (file_name_as_directory): Use const pointers when appropriate.
11226 (Fexpand_file_name): Likewise. In particular, newdir might
11227 point at constant storage, so make it a const pointer.
fd4ead52 11228 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11229 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11230 signedness issues.
f839df0c
PE
11231 (Fset_file_times, Finsert_file_contents, auto_save_error):
11232 Rename locals to avoid shadowing.
f14b7e14 11233
5716756e 11234 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11235 (Ftry_completion, Fall_completions): Rename or remove locals
11236 to avoid shadowing.
5716756e 11237
b4c3046a
PE
11238 * marker.c (bytepos_to_charpos): Remove; unused.
11239
b45db522
PE
11240 * lisp.h (verify_bytepos, count_markers): New decls,
11241 so that gcc does not warn that these functions aren't declared.
11242
85876d07
PE
11243 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11244 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11245 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11246 (copy_text): Remove unused local var.
85876d07 11247
03d78a21 11248 * filelock.c (within_one_second): Now static.
b3dd38ab 11249 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11250
5df8f01b
PE
11251 * buffer.c (fix_overlays_before): Mark locals as initialized.
11252 (fix_start_end_in_overlays): Likewise. This function should be
11253 simplified by using pointers-to-pointers, but that's a different
11254 matter.
b1d876f1 11255 (switch_to_buffer_1): Now static.
8f54f30a
PE
11256 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11257 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11258
a70072c9 11259 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11260 Fix pointer signedness issue.
edced198
PE
11261 (sys_subshell): Mark local as volatile if checking for lint,
11262 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11263 (MAXPATHLEN): Define only if needed.
a70072c9 11264
a0977c44
PE
11265 * process.c (serial_open, serial_configure): Move decls from here ...
11266 * systty.h: ... to here, so that they can be checked.
11267
a884fdcc
PE
11268 * fns.c (get_random, seed_random): Move extern decls from here ...
11269 * lisp.h: ... to here, so that they can be checked.
11270
604efe86 11271 * sysdep.c (reset_io): Now static.
b8950c94 11272 (wait_for_termination_signal): Remove; unused.
604efe86 11273
38fc62d9
PE
11274 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11275 (copy_keymap_item, append_key, push_text_char_description):
11276 Now static.
1004a21a 11277 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11278 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11279 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11280 (describe_map_tree):
11281 Rename locals to avoid shadowing.
38fc62d9 11282
2f2650da
PE
11283 * keyboard.c: Declare functions static if they are not used elsewhere.
11284 (echo_char, echo_dash, cmd_error, top_level_2):
11285 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11286 (read_char, kbd_buffer_get_event, make_lispy_position):
11287 (make_lispy_event, make_lispy_movement, apply_modifiers):
11288 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11289 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11290 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11291 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11292 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11293
a053e86c 11294 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11295 (mark_kboards): Move decl here ...
11296 * alloc.c (mark_kboards): ... from here.
a053e86c 11297
4752793e
PE
11298 * lisp.h (force_auto_save_soon): New decl.
11299
74f10ca7 11300 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11301 (DEFINE_DUMMY_FUNCTION): New macro.
11302 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11303 Use it.
c03cd23f
PE
11304 (main): Add casts to avoid warnings
11305 if GCC considers string literals to be constants.
74f10ca7 11306
022e70d4
PE
11307 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11308
59d6fe83
PE
11309 * dbusbind.c: Pointer signedness fixes.
11310 (xd_signature, xd_append_arg, xd_initialize):
11311 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11312 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11313 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11314 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11315
78320123
PE
11316 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11317 if GCC considers string literals to be constants.
49cebcca 11318 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11319
35ac2a97
SM
113202011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11321
fb103ca9
SM
11322 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11323 (print_preprocess, print_object): New macro to fix last change.
11324
35ac2a97
SM
11325 * print.c (print_preprocess): Don't forget font objects.
11326
62973b41
JB
113272011-03-16 Juanma Barranquero <lekktu@gmail.com>
11328
11329 * emacs.c (USAGE3): Doc fixes.
11330
0e48bb22
AS
113312011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11332
11333 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11334 structure.
11335
7684e57b
JB
113362011-03-14 Juanma Barranquero <lekktu@gmail.com>
11337
11338 * lisp.h (VWindow_system, Qfile_name_history):
11339 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11340 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11341 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11342
11343 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11344 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11345
11346 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11347 * w32console.c (detect_input_pending, read_input_pending)
11348 (encode_terminal_code):
11349 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11350 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11351 (w32_system_caret_y, Qfile_name_history):
11352 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11353 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11354 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11355 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11356 * w32proc.c (Qlocal, report_file_error):
11357 * w32term.c (Vwindow_system, updating_frame):
11358 * w32uniscribe.c (initialized, uniscribe_font_driver):
11359 Remove unneeded extern declarations.
11360
2aa46d6c
CY
113612011-03-14 Chong Yidong <cyd@stupidchicken.com>
11362
c96bbc66 11363 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11364
cffc6f3b
CY
113652011-03-13 Chong Yidong <cyd@stupidchicken.com>
11366
11367 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11368 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11369 These macros can no longer be used for assignment.
11370
44f230aa
SM
11371 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11372 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11373 (record_buffer_markers, fetch_buffer_markers): New functions for
11374 recording and fetching special buffer markers.
11375 (set_buffer_internal_1, set_buffer_temp): Use them.
11376
11377 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11378
11379 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11380
11381 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11382 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11383
11384 * xdisp.c (hscroll_window_tree):
11385 (reconsider_clip_changes): Use PT instead of BUF_PT.
11386
d251f04b
EZ
113872011-03-13 Eli Zaretskii <eliz@gnu.org>
11388
11389 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11390 $(EMACS_ROOT)/lib/intprops.h.
11391
f0c77cd1
PE
113922011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11393
3eca4629
PE
11394 Fix more problems found by GCC 4.5.2's static checks.
11395
7c86ee98
PE
11396 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11397 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11398 (xg_free_frame_widgets): Make it clear that a local variable is
11399 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11400 (gdk_window_get_screen): Make it clear that this macro is needed
11401 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11402 (int_gtk_range_get_value): New function, which avoids a diagnostic
11403 from gcc -Wbad-function-cast.
11404 (xg_set_toolkit_scroll_bar_thumb): Use it.
11405 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11406 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11407 (get_utf8_string, xg_get_file_with_chooser):
11408 Rename locals to avoid shadowing.
11409 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11410
41729b81
PE
11411 * xgselect.c (xg_select): Remove unused var.
11412
f0c77cd1
PE
11413 * image.c (four_corners_best): Mark locals as initialized.
11414 (gif_load): Initialize transparent_p to zero (Bug#8238).
11415 Mark another local as initialized.
ec6cf4c6 11416 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11417
ce0ad53d 11418 * image.c (clear_image_cache): Now static.
d5d5a617 11419 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11420 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11421 (x_edge_detection): Remove unnecessary cast that
11422 gcc -Wbad-function-cast diagnoses.
2037898d 11423 (gif_load): Fix pointer signedness.
6ae141d6
PE
11424 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11425 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11426
33383987 114272011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11428
d32df629
PE
11429 Improve quality of tests for time stamp overflow.
11430 For example, without this patch (encode-time 0 0 0 1 1
11431 1152921504606846976) returns the obviously-bogus value (-948597
11432 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11433 reports time overflow. See
11434 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11435 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11436 * editfns.c: Include limits.h and intprops.h.
11437 (TIME_T_MIN, TIME_T_MAX): New macros.
11438 (time_overflow): Move earlier, to before first use.
11439 (hi_time, lo_time): New functions, for an accurate test for
11440 out-of-range times.
11441 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11442 (Fget_internal_run_time): Don't assume time_t fits in int.
11443 (make_time): Use list2 instead of Fcons twice.
11444 (Fdecode_time): More accurate test for out-of-range times.
11445 (check_tm_member): New function.
11446 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11447 (lisp_time_argument): Don't rely on undefined left-shift and
11448 right-shift behavior when checking for time stamp overflow.
8be6f318 11449
fe31d94c
PE
11450 * editfns.c (time_overflow): New function, refactoring common code.
11451 (Fformat_time_string, Fdecode_time, Fencode_time):
11452 (Fcurrent_time_string): Use it.
11453
8be6f318
PE
11454 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11455 * dired.c (make_time): Move to ...
11456 * editfns.c (make_time): ... here.
11457 * systime.h: Note the move.
11458
09d9db2c 114592011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11460
126bc0dc
YM
11461 * fringe.c (update_window_fringes): Remove unused variables.
11462
c47cbdfd
YM
11463 * unexmacosx.c (copy_data_segment): Also copy __got section.
11464 (Bug#8223)
11465
7ac80be9
EZ
114662011-03-12 Eli Zaretskii <eliz@gnu.org>
11467
c96bbc66 11468 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11469 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11470 Constify `char *' arguments and their references according to
11471 prototypes in tparam.h.
11472
ecb0f94d 11473 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11474
7ac80be9
EZ
11475 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11476 Adapt all references accordingly.
11477
11478 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11479
ef1fd07e
TT
114802011-03-11 Tom Tromey <tromey@redhat.com>
11481
11482 * buffer.c (syms_of_buffer): Remove obsolete comment.
11483
7ef4b50c
EZ
114842011-03-11 Eli Zaretskii <eliz@gnu.org>
11485
11486 * termhooks.h (encode_terminal_code): Declare prototype.
11487
11488 * msdos.c (encode_terminal_code): Don't declare prototype.
11489
11490 * term.c (encode_terminal_code): Now external again, used by
11491 w32console.c and msdos.c.
11492
44f230aa
SM
11493 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11494 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11495
4b1ec863 114962011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11497
1714f52b 11498 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11499
4b1ec863
PE
11500 * fringe.c (update_window_fringes): Mark locals as initialized
11501 (Bug#8227).
11502 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11503
524c7aa6
PE
11504 * alloc.c (mark_fringe_data): Move decl from here ...
11505 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11506 to check its interface.
11507 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11508
a5c0af81 11509 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11510 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11511 (fontset_font): Mark local as initialized.
a9a06e0b 11512 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11513
b4716021
PE
11514 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11515
811e9bac 11516 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11517 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11518 (x_own_selection, Fx_disown_selection_internal): Rename locals
11519 to avoid shadowing.
11520 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11521
7e3ab302
PE
11522 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11523 so that the caller can use some name other than gcpro1.
11524 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11525 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11526 (Fx_backspace_delete_keys_p):
11527 Use them to avoid shadowing, and rename vars to avoid shadowing.
11528 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11529 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11530 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11531 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11532 Remove unused locals.
7e3ab302
PE
11533 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11534 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11535 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11536 macros.
f78faa98 11537
e2b13473
PE
11538 * xterm.h (x_mouse_leave): New decl.
11539
77f23912
PE
11540 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11541 Remove unused functions.
cdf4ba58
PE
11542 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11543 (x_calc_absolute_position): Now static.
7411c686 11544 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11545 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11546 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11547 unless they are used.
38d0b34a
PE
11548 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11549 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11550 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11551 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11552 (x_error_catcher, x_connection_closed, x_error_handler):
11553 (x_error_quitter, xembed_send_message, x_iconify_frame):
11554 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 11555 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 11556 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 11557
44f230aa
SM
11558 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11559 Rename or move locals to avoid shadowing.
6b463e58 11560 (tty_defined_color, merge_face_heights): Now static.
5967d051 11561 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
11562 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11563 does not deduce is never used uninitialized.
73719eba
PE
11564 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11565 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 11566
426994c3 11567 * terminal.c (store_terminal_param): Now static.
5489860b 11568
032f1620 11569 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 11570 (set_frame_menubar): Remove unused local.
d4323972 11571 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
11572 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11573 since they might point to immutable storage.
281585b0
PE
11574 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11575 since it's unused otherwise.
032f1620 11576
367c19e5 11577 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 11578 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
11579 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11580 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 11581 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
11582 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11583 does not deduce are never used uninitialized.
70739cbe 11584
07b48fa9
PE
11585 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11586
8868a238 11587 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
11588 * window.c (window_loop, size_window):
11589 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 11590
7e5cf297 11591 * window.c (display_buffer): Now static.
d6550a9f
PE
11592 (size_window): Mark variables that gcc -Wuninitialized
11593 does not deduce are never used uninitialized.
a586633d
PE
11594 * window.h (check_all_windows): New decl, to forestall
11595 gcc -Wmissing-prototypes diagnostic.
5b555da1 11596 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 11597
f6095868
PE
11598 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11599 shadowing.
11600 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
11601 Include <limits.h>.
11602 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11603 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
11604 (load_charset_map): Mark variables that gcc -Wuninitialized
11605 does not deduce are never used uninitialized.
53df7c11 11606 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 11607
f38b440c
PE
11608 * coding.c (coding_set_source, coding_set_destination):
11609 Use "else { /* comment */ }" rather than "else /* comment */;"
11610 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
11611 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11612 a block, when the outer 'i' will do.
11613 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11614 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11615 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11616 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11617 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11618 Rename locals to avoid shadowing.
11619 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
11620 * coding.c (emacs_mule_char, encode_invocation_designation):
11621 Now static, since they're not used elsewhere.
413bb2db 11622 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 11623 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
11624 (decode_coding_emacs_mule): Mark variables that gcc
11625 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
11626 (detect_coding_iso_2022): Initialize a local variable that might
11627 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 11628 this initialization is needed. (Bug#8211)
5f58e762
PE
11629 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11630 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11631 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11632 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11633 Remove unused macros.
f38b440c 11634
232b38b9 11635 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 11636 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 11637 * character.c (string_count_byte8): Likewise.
232b38b9 11638
fb90da1b
PE
11639 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11640 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11641
fb93dbc2
PE
11642 * chartab.c (copy_sub_char_table): Now static, since it's not used
11643 elsewhere.
5c156ace
PE
11644 (sub_char_table_ref_and_range, char_table_ref_and_range):
11645 Rename locals to avoid shadowing.
bbcd0949 11646 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 11647
7d3b3862 11648 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 11649 (BIDI_BOB): Remove unused macro.
7d3b3862 11650
6be7d3da
PE
11651 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11652 deduce are never used uninitialized.
c2ed9c8b 11653 * term.c (encode_terminal_code): Likewise.
6be7d3da 11654
75f8807f 11655 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 11656
50938595
PE
11657 * tparam.h: New file.
11658 * term.c, tparam.h: Include it.
11659 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11660 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11661 Move these decls to tparam.h, and make them agree with what
11662 is actually in tparam.c. The previous trick of using incompatible
11663 decls in different modules does not conform to the C standard.
11664 All callers of tparam changed to use tparam's actual API.
11665 * tparam.c (tparam1, tparam, tgoto):
11666 Use const pointers where appropriate.
11667
fbceeba2
PE
11668 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11669 * cm.h (struct cm): Likewise.
11670 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11671 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11672 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11673 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11674 (turn_on_face, init_tty): Likewise.
11675 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 11676
7f3f1250
PE
11677 * term.c (term_mouse_position): Rename local to avoid shadowing.
11678
e6ca6543
PE
11679 * alloc.c (mark_ttys): Move decl from here ...
11680 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11681
c40f8d15
AS
116822011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11683
11684 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11685
cfe0661d
JB
116862011-03-09 Juanma Barranquero <lekktu@gmail.com>
11687
11688 * search.c (compile_pattern_1): Remove argument regp, unused since
11689 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11690 (compile_pattern): Don't pass it.
11691
0afb4571
J
116922011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11693
11694 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11695 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11696 for ! HAVE_GTK3.
11697 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11698
11699 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11700
11701 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11702 gdk_window_get_screen, gdk_window_get_geometry,
11703 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11704 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11705 (xg_get_pixbuf_from_pixmap): New function.
11706 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11707 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11708 Call xg_get_pixbuf_from_pixmap instead of
11709 gdk_pixbuf_get_from_drawable.
11710 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11711 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11712 (xg_check_special_colors): Use GtkStyleContext and its functions
11713 for HAVE_GTK3.
11714 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11715 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11716 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
11717 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11718 Call gtk_widget_get_preferred_size.
0afb4571
J
11719 (xg_frame_resized): gdk_window_get_geometry only takes 5
11720 parameters.
44f230aa
SM
11721 (xg_win_to_widget, xg_event_is_for_menubar):
11722 Call gdk_x11_window_lookup_for_display.
0afb4571
J
11723 (xg_set_widget_bg): New function.
11724 (delete_cb): New function.
895009e1 11725 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 11726 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
11727 (xg_set_background_color): Call xg_set_widget_bg.
11728 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11729 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11730 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11731 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11732 if ! HAVE_GTK3.
11733 (update_frame_tool_bar): Call gtk_widget_hide.
11734 (xg_initialize): Use GDK_KEY_g.
11735
11736 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11737 if ! HAVE_GTK3
11738 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11739
11740 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11741 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11742 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11743
1c2cc4ef
JB
117442011-03-08 Juanma Barranquero <lekktu@gmail.com>
11745
11746 * w32xfns.c (select_palette): Check success of RealizePalette against
11747 GDI_ERROR, not zero.
11748
33383987 11749See ChangeLog.11 for earlier changes.
aac0c6e3
MR
11750
11751;; Local Variables:
11752;; coding: utf-8
aac0c6e3
MR
11753;; End:
11754
2f097256 11755 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
11756
11757 This file is part of GNU Emacs.
11758
11759 GNU Emacs is free software: you can redistribute it and/or modify
11760 it under the terms of the GNU General Public License as published by
11761 the Free Software Foundation, either version 3 of the License, or
11762 (at your option) any later version.
11763
11764 GNU Emacs is distributed in the hope that it will be useful,
11765 but WITHOUT ANY WARRANTY; without even the implied warranty of
11766 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11767 GNU General Public License for more details.
11768
11769 You should have received a copy of the GNU General Public License
11770 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.