Merge from emacs-23; up to 2010-06-13T18:15:45Z!eliz@gnu.org.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
f3d1777e
MR
12011-06-08 Martin Rudalics <rudalics@gmx.at>
2
3 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4 Remove.
5
abde8f8c
MR
62011-06-07 Martin Rudalics <rudalics@gmx.at>
7
8 * window.c (Fwindow_total_size, Fwindow_left_column)
9 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10 (Fwindow_list_1): New functions.
11 (window_box_text_cols): Replace with window_body_cols.
12 (Fwindow_width, Fscroll_left, Fscroll_right): Use
13 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
14 (delete_window, Fset_window_configuration): Call
15 delete_all_subwindows with window as argument.
16 (delete_all_subwindows): Take a window as argument and not a
17 structure. Rewrite.
190b47e6
MR
18 (window_loop): Remove handling of GET_LRU_WINDOW and
19 GET_LARGEST_WINDOW.
20 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
21
22 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
23 window_box_text_cols. delete_all_subwindows now takes a
24 Lisp_Object as argument.
abde8f8c
MR
25
26 * indent.c (compute_motion, Fcompute_motion): Use
27 window_body_cols instead of window_box_text_cols.
28
fa8a67e6
MR
29 * frame.c (delete_frame): Call delete_all_subwindows with root
30 window as argument.
31
a54e3482
DC
322011-06-07 Daniel Colascione <dan.colascione@gmail.com>
33
34 * fns.c (Fputhash): Document return value.
35
60002bf5
CY
362011-06-06 Chong Yidong <cyd@stupidchicken.com>
37
38 * image.c (gif_load): Implement gif89a spec "no disposal" method.
39
0c671da6 402011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 41
b862a52a 42 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 43
be44ca6c
PE
44 Check for overflow when converting integer to cons and back.
45 * charset.c (Fdefine_charset_internal, Fdecode_char):
46 Use cons_to_unsigned to catch overflow.
47 (Fencode_char): Use INTEGER_TO_CONS.
48 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
49 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
50 * data.c (long_to_cons, cons_to_long): Remove.
51 (cons_to_unsigned, cons_to_signed): New functions.
52 These signal an error for invalid or out-of-range values.
53 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
54 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
55 * font.c (Ffont_variation_glyphs):
56 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
57 * lisp.h: Include <intprops.h>.
58 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
59 (cons_to_signed, cons_to_unsigned): New decls.
60 (long_to_cons, cons_to_long): Remove decls.
61 * undo.c (record_first_change): Use INTEGER_TO_CONS.
62 (Fprimitive_undo): Use CONS_TO_INTEGER.
63 * xfns.c (Fx_window_property): Likewise.
64 * xselect.c: Include <limits.h>.
65 (x_own_selection, selection_data_to_lisp_data):
66 Use INTEGER_TO_CONS.
67 (x_handle_selection_request, x_handle_selection_clear)
68 (x_get_foreign_selection, Fx_disown_selection_internal)
69 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
70 (lisp_data_to_selection_data): Use cons_to_unsigned.
71 (x_fill_property_data): Use cons_to_signed.
72 Report values out of range.
73
d1f3d2af
PE
74 Check for buffer and string overflow more precisely.
75 * buffer.h (BUF_BYTES_MAX): New macro.
76 * lisp.h (STRING_BYTES_MAX): New macro.
77 * alloc.c (Fmake_string):
78 * character.c (string_escape_byte8):
79 * coding.c (coding_alloc_by_realloc):
80 * doprnt.c (doprnt):
81 * editfns.c (Fformat):
82 * eval.c (verror):
83 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
84 since they may not be the same number.
85 * editfns.c (Finsert_char):
86 * fileio.c (Finsert_file_contents):
87 Likewise for BUF_BYTES_MAX.
88
dd52fcea
PE
89 * image.c: Use ptrdiff_t, not int, for sizes.
90 (slurp_file): Switch from int to ptrdiff_t.
91 All uses changed.
92 (slurp_file): Check that file size fits in both size_t (for
93 malloc) and ptrdiff_t (for sanity and safety).
94
7f9bbdbb
PE
95 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
96 if b->modtime has its maximal value.
97
dfe18f82
PE
98 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
99
84acfcf0
PE
100 Don't assume time_t can fit into int.
101 * buffer.h (struct buffer.modtime): Now time_t, not int.
102 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
103 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
104
ccd9a01a
PE
105 Minor fixes for signed vs unsigned integers.
106 * character.h (MAYBE_UNIFY_CHAR):
107 * charset.c (maybe_unify_char):
108 * keyboard.c (read_char, reorder_modifiers):
109 XINT -> XFASTINT, since the integer must be nonnegative.
110 * ftfont.c (ftfont_spec_pattern):
111 * keymap.c (access_keymap, silly_event_symbol_error):
112 XUINT -> XFASTINT, since the integer must be nonnegative.
113 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
114 since it makes no difference and we prefer signed.
115 * keyboard.c (record_char): Use XUINT when all the neighbors do.
116 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
117 nonnegative.
118
d6d100dd
SM
1192011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
120
121 * window.h (Fwindow_frame): Declare.
122
2b6148e4
PE
1232011-06-06 Paul Eggert <eggert@cs.ucla.edu>
124
125 * alloc.c: Simplify handling of large-request failures (Bug#8800).
126 (SPARE_MEMORY): Always define.
127 (LARGE_REQUEST): Remove.
128 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
129
f230ecc9
MR
1302011-06-06 Martin Rudalics <rudalics@gmx.at>
131
727e958e
MR
132 * lisp.h: Move EXFUNS for Fframe_root_window,
133 Fframe_first_window and Fset_frame_selected_window to window.h.
134
135 * window.h: Move EXFUNS for Fframe_root_window,
136 Fframe_first_window and Fset_frame_selected_window here from
137 lisp.h.
138
139 * frame.c (Fwindow_frame, Fframe_first_window)
140 (Fframe_root_window, Fframe_selected_window)
141 (Fset_frame_selected_window): Move to window.c.
142 (Factive_minibuffer_window): Move to minibuf.c.
143 (Fother_visible_frames_p): New function.
144
145 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
146
f230ecc9
MR
147 * window.c (decode_window, decode_any_window): Move up in code.
148 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
149 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
150 (Fwindow_buffer): Move up and rewrite doc-string.
151 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
152 (Fwindow_prev): New functions.
727e958e
MR
153 (Fwindow_frame): Move here from frame.c. Accept any window as
154 argument.
155 (Fframe_root_window, Fframe_first_window)
156 (Fframe_selected_window): Move here from frame.c. Accept frame
157 or arbitrary window as argument. Update doc-strings.
158 (Fminibuffer_window): Move up in code.
159 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
160 (Fset_frame_selected_window): Move here from frame.c.
161 Marginal rewrite.
727e958e
MR
162 (Fselected_window, select_window, Fselect_window): Move up in
163 code. Minor doc-string fixes.
f230ecc9 164
4d09bcf6
PE
1652011-06-06 Paul Eggert <eggert@cs.ucla.edu>
166
167 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
168 Do not assume that spare memory exists; that assumption is valid
169 only if SYSTEM_MALLOC.
170 (LARGE_REQUEST): New macro, so that the issue of large requests
171 is separated from the issue of spare memory.
172
810928a2
AS
1732011-06-05 Andreas Schwab <schwab@linux-m68k.org>
174
172418ad
AS
175 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
176 format. (Bug#8806)
177
43f862f7
AS
178 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
179
810928a2
AS
180 * xfns.c (x_set_scroll_bar_default_width): Move declarations
181 before statements.
182
a059fe24
JD
1832011-06-05 Jan Djärv <jan.h.d@swipnet.se>
184
185 * gtkutil.c (xg_get_default_scrollbar_width): New function.
186
187 * gtkutil.h: Declare xg_get_default_scrollbar_width.
188
189 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
190 min width by calling x_set_scroll_bar_default_width (Bug#8505).
191
989bf368
JB
1922011-06-05 Juanma Barranquero <lekktu@gmail.com>
193
194 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
195
4b80f674
CY
1962011-06-04 Chong Yidong <cyd@stupidchicken.com>
197
198 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
199 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
200 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
201 New error handlers.
4b80f674
CY
202 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
203 Obey Vx_select_enable_clipboard_manager. Catch errors in
204 x_clipboard_manager_save (Bug#8779).
205 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 206 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 207
99a33b77 2082011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
209
210 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
211
99a33b77 2122011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
213
214 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
215 in the current matrix if keep_current_p is non-zero.
216
8264569d
EZ
2172011-06-04 Eli Zaretskii <eliz@gnu.org>
218
219 * bidi.c (bidi_level_of_next_char): Fix last change.
220
57f97249
EZ
2212011-06-03 Eli Zaretskii <eliz@gnu.org>
222
fec2107c 223 Support bidi reordering of text covered by display properties.
57f97249 224
fec2107c
EZ
225 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
226 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
227 (bidi_cache_search, bidi_cache_iterator_state)
228 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
229 (bidi_level_of_next_char, bidi_move_to_visually_next):
230 Support character positions inside a run of characters covered by a
fec2107c
EZ
231 display string.
232 (bidi_paragraph_init, bidi_resolve_explicit_1)
233 (bidi_level_of_next_char): Call bidi_fetch_char and
234 bidi_fetch_char_advance instead of FETCH_CHAR and
235 FETCH_CHAR_ADVANCE.
236 (bidi_init_it): Initialize new members.
237 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
238 definitions.
239 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
240 instead of using explicit *_CHAR codes.
d6d100dd
SM
241 (bidi_resolve_explicit, bidi_resolve_weak):
242 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
243 bidirectional text is supported only in multibyte buffers.
244 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
245 it to initialize the frame_window_p member of struct bidi_it.
246 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
247 (bidi_resolve_explicit, bidi_resolve_weak)
248 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
249 bidi_it->nchars is non-positive.
250 (bidi_level_of_next_char): Don't try to lookup the cache for the
251 next/previous character if nothing is cached there yet, or if we
252 were just reseat()'ed to a new position.
c40e2fb2 253
0e14fe90
EZ
254 * xdisp.c (set_cursor_from_row): Set start and stop points
255 according to the row's direction when priming the loop that looks
256 for the glyph on which to display cursor.
257 (single_display_spec_intangible_p): Function deleted.
258 (display_prop_intangible_p): Reimplement to call
259 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
260 Accept 3 additional arguments needed by handle_display_spec.
261 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
262 values: lists, `(when COND...)' forms, etc.
263 (single_display_spec_string_p): Support property values that are
264 lists with the argument STRING its top-level element.
265 (display_prop_string_p): Fix the condition for processing a
266 property that is a list to be consistent with handle_display_spec.
fec2107c 267 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
268 last portion of handle_display_prop.
269 (compute_display_string_pos): Accept additional argument
270 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
271 value of a `display' property is a "replacing spec".
272 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
273 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
274 the display property, but just return a value indicating whether
275 the display property will replace the characters it covers.
276 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
277 frame_window_p members of struct bidi_it.
d6d100dd
SM
278 (compute_display_string_pos, compute_display_string_end):
279 New functions.
fec2107c
EZ
280 (push_it): Accept second argument POSITION, where pop_it should
281 jump to continue iteration.
282 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 283
fec2107c
EZ
284 * keyboard.c (adjust_point_for_property): Adjust the call to
285 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
286
287 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
288 (bidi_init_it): Update prototypes.
289 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
290 (compute_display_string_pos, compute_display_string_end):
291 Declare prototypes.
fec2107c
EZ
292 (struct bidi_it): New members nchars and disp_pos. ch_len is now
293 EMACS_INT.
fc6f18ce 294
40087514 2952011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 296
57f53182
PE
297 Malloc failure behavior now depends on size of allocation.
298 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
299 * lisp.h: Change signatures accordingly.
300 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
301 All callers changed. (Bug#8762)
302
303 * gnutls.c: Use Emacs's memory allocators.
304 Without this change, the gnutls library would invoke malloc etc.
305 directly, which causes problems on non-SYNC_INPUT hosts, and which
306 runs afoul of improving memory_full behavior. (Bug#8761)
307 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
308 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
309 xfree instead of the default malloc, realloc, free.
310 (Fgnutls_boot): No need to check for memory allocation failure,
311 since xmalloc does that for us.
312
ac32cd99 313 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
314 * category.c (hash_get_category_set):
315 * ccl.c (ccl_driver):
316 * charset.c (Fdefine_charset_internal):
317 * charset.h (struct charset.hash_index):
318 * composite.c (get_composition_id, gstring_lookup_cache)
319 (composition_gstring_put_cache):
320 * composite.h (struct composition.hash_index):
321 * dispextern.h (struct image.hash):
322 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
323 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
324 (hashfn_equal, hashfn_user_defined, make_hash_table)
325 (maybe_resize_hash_table, hash_lookup, hash_put)
326 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
327 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
328 (Fsxhash, Fgethash, Fputhash, Fmaphash):
329 * image.c (make_image, search_image_cache, lookup_image)
330 (xpm_put_color_table_h):
331 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 332 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
333 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
334 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
335 * alloc.c (allocate_vectorlike):
336 Check for overflow in vector size calculations.
337 * ccl.c (ccl_driver):
338 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
339 * fns.c, image.c: Remove unnecessary static decls that would otherwise
340 need to be updated by these changes.
40087514
PE
341 * fns.c (make_hash_table, maybe_resize_hash_table):
342 Check for integer overflow with large hash tables.
0de4bb68
PE
343 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
344 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
345 (SXHASH_REDUCE): New macro.
346 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
347 Use it instead of discarding useful hash info with large hash values.
348 (sxhash_float): New function.
349 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
350 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
351 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
352 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
353 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
354 Adjust signatures to match updated version of code.
355 (consing_since_gc): Now EMACS_INT, since a single hash table can
356 use more than INT_MAX bytes.
357
698d32e2
DN
3582011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
359
360 Make it possible to build with GCC-4.6+ -O2 -flto.
361
362 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
363
fd6fa53f
SM
3642011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
365
366 * minibuf.c (get_minibuffer, read_minibuf_unwind):
367 Call minibuffer-inactive-mode.
368
864db017
JB
3692011-05-31 Juanma Barranquero <lekktu@gmail.com>
370
371 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
372 Update dependencies.
373
2ad0baf4
DN
3742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
375
376 * data.c (init_data): Remove code for UTS, this system is not
377 supported anymore.
378
4fcc2638
DN
3792011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
380
381 Don't force ./temacs to start in terminal mode.
382
383 * frame.c (make_initial_frame): Initialize faces in all cases, not
384 only when CANNOT_DUMP is defined.
385 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
386
c56e0fd5
DN
3872011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
388
389 * dispnew.c (add_window_display_history): Use const for the string
390 pointer. Remove declaration, not needed.
391
333d54da 3922011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 393
55d4c1b2 394 Use 'inline', not 'INLINE'.
333d54da 395 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
396 * alloc.c, fontset.c (INLINE): Remove.
397 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
398 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
399 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
400 * gmalloc.c (register_heapinfo): Use inline unconditionally.
401 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
402
738db178
DN
4032011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
404
405 Make it possible to run ./temacs.
406
407 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
408 syms_of_callproc does the same thing. Remove test for
409 "initialized", do it in the caller.
410 * emacs.c (main): Avoid calling set_initial_environment when dumping.
411
620c53a6
SM
4122011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
413
414 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
415 (read_minibuf): Use get_minibuffer.
416 (syms_of_minibuf): Use DEFSYM.
417 (Qmetadata): New var.
418 * data.c (Qbuffer): Don't make it static.
419 (syms_of_data): Use DEFSYM.
420
e003a292
PE
4212011-05-31 Paul Eggert <eggert@cs.ucla.edu>
422
423 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
424 (CCL_CODE_MIN): New macro.
425
ed008a6d
PE
4262011-05-30 Paul Eggert <eggert@cs.ucla.edu>
427
3687c2ef
PE
428 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
429
ed008a6d
PE
430 * eval.c (Qdebug): Now static.
431 * lisp.h (Qdebug): Remove decl. This reverts a part of the
432 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
433 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
434
d66c4c7c
CY
4352011-05-29 Chong Yidong <cyd@stupidchicken.com>
436
437 * image.c: Various fixes to ImageMagick code comments.
438 (Fimagemagick_types): Doc fix.
439
5fbc2025
PE
4402011-05-29 Paul Eggert <eggert@cs.ucla.edu>
441
0196f88a
PE
442 Minor fixes prompted by GCC 4.6.0 warnings.
443
444 * xselect.c (converted_selections, conversion_fail_tag): Now static.
445
5fbc2025
PE
446 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
447 (x_clipboard_manager_save_all): Move extern decl to ...
448 * xterm.h: ... here, so that it can be checked for consistency.
449
1dd3c2d9
CY
4502011-05-29 Chong Yidong <cyd@stupidchicken.com>
451
452 * xselect.c (x_clipboard_manager_save_frame)
453 (x_clipboard_manager_save_all): New functions.
454 (Fx_clipboard_manager_save): Lisp function deleted.
455
456 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
457 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
458
459 * xterm.h: Update prototype.
460
5ba6571d
WX
4612011-05-28 William Xu <william.xwl@gmail.com>
462
463 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
464 exiting (Bug#8239).
465
3eaff834
JM
4662011-05-28 Jim Meyering <meyering@redhat.com>
467
e1900994 468 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
469 * fns.c (to_uchar): Define.
470 (crypto_hash_function): Use it to convert some newly-signed
471 variables to unsigned, to avoid sign-extension bugs. For example,
472 without this change, (md5 "truc") would evaluate to
473 45723a2aff78ff4fff7fff1114760e62 rather than the expected
474 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 475 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 476
0f6990a7
PE
4772011-05-27 Paul Eggert <eggert@cs.ucla.edu>
478
479 Integer overflow fixes.
c8a9ca5a 480
08686060
PE
481 * dbusbind.c: Serial number integer overflow fixes.
482 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
483 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
484 to hold a serial number that is too large for a fixnum.
485 (Fdbus_method_return_internal, Fdbus_method_error_internal):
486 Check for serial numbers out of range. Decode any serial number
59568bf0 487 that was so large that it became a float. (Bug#8722)
08686060 488
2d1fc3c7
PE
489 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
490 (Fdbus_call_method, Fdbus_call_method_asynchronously):
491 Use XFASTINT rather than XUINT when numbers are nonnegative.
492 (xd_append_arg, Fdbus_method_return_internal):
493 (Fdbus_method_error_internal): Likewise. Also, for unsigned
494 arguments, check that Lisp number is nonnegative, rather than
59568bf0 495 silently wrapping negative numbers around. (Bug#8722)
30217ff0 496 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 497 (Bug#8722)
2d1fc3c7 498
c8a9ca5a
PE
499 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
500
519e1d69
PE
501 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
502
30569699
PE
503 ccl: add integer overflow checks
504 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
505 (IN_INT_RANGE): New macros.
506 (ccl_driver): Use them to check for integer overflow when
507 decoding a CCL program. Many of the new checks are whether XINT (x)
508 fits in int; it doesn't always, on 64-bit hosts. The new version
509 doesn't catch all possible integer overflows, but it's an
847044ea 510 improvement. (Bug#8719)
30569699 511
c11285dc
PE
512 * alloc.c (make_event_array): Use XINT, not XUINT.
513 There's no need for unsigned here.
514
fdccd48e
PE
515 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
516 This follows up to the 2011-05-06 change that substituted uintptr_t
517 for EMACS_INT. This case wasn't caught back then.
518
37910ab2
PE
519 Rework Fformat to avoid integer overflow issues.
520 * editfns.c: Include <float.h> unconditionally, as it's everywhere
521 now (part of C89). Include <verify.h>.
522 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
523 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
524 (Fformat): Avoid the prepass trying to compute sizes; it was only
525 approximate and thus did not catch overflow reliably. Instead, walk
526 through the format just once, formatting and computing sizes as we go,
527 checking for integer overflow at every step, and allocating a larger
528 buffer as needed. Keep track separately whether the format is
529 multibyte. Keep only the most-recently calculated precision, rather
530 than them all. Record whether each argument has been converted to
531 string. Use EMACS_INT, not int, for byte and char and arg counts.
532 Support field widths and precisions larger than INT_MAX. Avoid
533 sprintf's undefined behavior with conversion specifications such as %#d
534 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
535 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
536 formatting out-of-range floating point numbers with int
537 formats. (Bug#8668)
538
2e6578fb
PE
539 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
540
0ae6bdee
PE
541 * data.c: Avoid integer truncation in expressions involving floats.
542 * data.c: Include <intprops.h>.
543 (arith_driver): When there's an integer overflow in an expression
544 involving floating point, convert the integers to floating point
545 so that the resulting value does not suffer from catastrophic
546 integer truncation. For example, on a 64-bit host (* 4
547 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
548 Do not rely on undefined behavior after integer overflow.
549
de883a70
PE
550 merge count_size_as_multibyte, parse_str_to_multibyte
551 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 552 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
553 Check for integer overflow.
554 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
555 since it's now a duplicate of the other. This is more of
556 a character than a buffer op, so better that it's in character.c.
557 * fns.c, print.c: Adjust to above changes.
558
2ff916cb
PE
5592011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
560
561 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
562
f1b54466
PE
5632011-05-27 Paul Eggert <eggert@cs.ucla.edu>
564
fb1ac845
PE
565 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
566 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
567 (x_clipboard_manager_save): Now static.
568 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
569
f1b54466
PE
570 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
571 (crypto_hash_function): Now static.
572 Fix pointer signedness problems. Avoid unnecessary initializations.
573
a9f737ee
CY
5742011-05-27 Chong Yidong <cyd@stupidchicken.com>
575
576 * termhooks.h (Vselection_alist): Make it terminal-local.
577
578 * terminal.c (create_terminal): Initialize it.
579
580 * xselect.c: Support for clipboard managers.
581 (Vselection_alist): Move to termhooks.h as terminal-local var.
582 (LOCAL_SELECTION): New macro.
583 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
584 (symbol_to_x_atom): Remove gratuitous arg.
585 (x_handle_selection_request, lisp_data_to_selection_data)
586 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
587 (x_own_selection, x_get_local_selection, x_convert_selection):
588 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
589 (some_frame_on_display): Delete unused function.
590 (Fx_own_selection_internal, Fx_get_selection_internal)
591 (Fx_disown_selection_internal, Fx_selection_owner_p)
592 (Fx_selection_exists_p): New optional frame arg.
593 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
594 (x_handle_selection_clear): Don't treat other terminals with the
595 same keyboard specially. Use the terminal-local Vselection_alist.
596 (x_clear_frame_selections): Use Frun_hook_with_args.
597
598 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
599
600 * xterm.h: Add support for those atoms.
601
e067f0c1
CY
6022011-05-26 Chong Yidong <cyd@stupidchicken.com>
603
604 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
605 (converted_selections, conversion_fail_tag): New global variables.
606 (x_selection_request_lisp_error): Free the above.
607 (x_get_local_selection): Remove unnecessary code.
608 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
609 of converted selections stored in converted_selections.
610 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
611 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
612 (x_convert_selection): New function.
613 (x_handle_selection_event): Simplify.
614 (x_get_foreign_selection): Don't ignore incoming requests while
615 waiting for an answer; this will fail when we implement
616 SAVE_TARGETS, and seems unnecessary anyway.
617 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
618 (Vx_sent_selection_functions): Doc fix.
619
0f4aebc0
LL
6202011-05-26 Leo Liu <sdl.web@gmail.com>
621
622 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
623
e61124cd
YM
6242011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
625
626 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
627
628 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
629 for fringe update if it has periodic bitmap.
630 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
631 and fringe_bitmap_periodic_p.
632
633 * fringe.c (get_fringe_bitmap_data): New function.
634 (draw_fringe_bitmap_1, update_window_fringes): Use it.
635 (update_window_fringes): Record periodicity of fringe bitmap in glyph
636 row. Mark glyph row for fringe update if periodicity changed.
637
638 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
639 for fringe update unless it has periodic bitmap.
640
f16d9837
KH
6412011-05-25 Kenichi Handa <handa@m17n.org>
642
643 * xdisp.c (get_next_display_element): Set correct it->face_id for
644 a static composition.
645
e1b90ef6
LL
6462011-05-24 Leo Liu <sdl.web@gmail.com>
647
648 * deps.mk (fns.o):
649 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
650
651 * fns.c (crypto_hash_function, Fsha1): New function.
652 (Fmd5): Use crypto_hash_function.
653 (syms_of_fns): Add Ssha1.
654
7400048f
PE
6552011-05-22 Paul Eggert <eggert@cs.ucla.edu>
656
657 * gnutls.c: Remove unused macros.
658 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
659 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
660 Remove macros that are defined and never used.
661 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
662
abb71cf4
CY
6632011-05-22 Chong Yidong <cyd@stupidchicken.com>
664
665 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
666 (Fx_get_selection_internal): Minor cleanup.
667 (Fx_own_selection_internal): Rename arguments for consistency with
668 select.el.
669
6307db39
PE
6702011-05-22 Paul Eggert <eggert@cs.ucla.edu>
671
672 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
673
f3d4e0a4
CY
6742011-05-22 Chong Yidong <cyd@stupidchicken.com>
675
676 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
677
4d8ade89
YM
6782011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
679
680 * dispnew.c (scrolling_window): Don't exclude the case that the
681 last enabled row in the desired matrix touches the bottom boundary.
682
32078c8d
GM
6832011-05-21 Glenn Morris <rgm@gnu.org>
684
685 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
686 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
687 and add some more files.
32078c8d 688
7285dc67
EZ
6892011-05-20 Eli Zaretskii <eliz@gnu.org>
690
691 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
692 report_file_error introduced by the change from 2011-05-07.
693
89d1bd22
PE
6942011-05-20 Paul Eggert <eggert@cs.ucla.edu>
695
696 * systime.h (Time): Define only if emacs is defined.
697 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
698 where the include path doesn't have X11/X.h by default. See
699 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
700
e23640bb 7012011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
702
703 * composite.c (find_automatic_composition): Fix previous change.
704
b9704ad9
GM
7052011-05-20 Glenn Morris <rgm@gnu.org>
706
707 * lisp.mk: New file, split from Makefile.in.
708 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
709 (shortlisp): Remove.
710 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
711
4a720484
GM
7122011-05-19 Glenn Morris <rgm@gnu.org>
713
714 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
715 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
716 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
717 (lisp): Set the order to that of loadup.el.
718 (shortlisp): Make it a copy of $lisp.
719 (SOME_MACHINE_LISP): Remove.
720 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
721 Use just $shortlisp, not $SOME_MACHINE_LISP too.
722
a28d4396
KH
7232011-05-18 Kenichi Handa <handa@m17n.org>
724
725 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
726 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
727 (find_automatic_composition): Mostly rewrite for efficiency.
728
a2b1fa8e
JB
7292011-05-18 Juanma Barranquero <lekktu@gmail.com>
730
731 * makefile.w32-in: Update dependencies.
732
8e1f5610
CS
7332011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
734
735 * menu.c: Include limits.h (fixes the MS-Windows build broken by
736 revision 104625).
737
7025ee00 7382011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 739
cdfa6eab
PE
740 Fix some integer overflow issues, such as string length overflow.
741
06d6db33
PE
742 * insdel.c (count_size_as_multibyte): Check for string overflow.
743
2b4560a8
PE
744 * character.c (lisp_string_width): Check for string overflow.
745 Use EMACS_INT, not int, for string indexes and lengths; in
746 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
747 the resulting string length overflows an EMACS_INT; instead,
748 report a string overflow if no precision given. When checking for
749 precision exhaustion, use a check that cannot possibly have
750 integer overflow. (Bug#8675)
751 * character.h (lisp_string_width): Adjust to new signature.
752
cb93f9be
PE
753 * alloc.c (string_overflow): New function.
754 (Fmake_string): Use it. This doesn't change behavior, but saves
755 a few bytes and will simplify future changes.
756 * character.c (string_escape_byte8): Likewise.
757 * lisp.h (string_overflow): New decl.
758
1a1f3366
PE
759 Fixups, following up to the user-interface timestamp change.
760 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
761 for UI timestamps, instead of unsigned long.
9fbd6841
PE
762 * msdos.c (mouse_get_pos): Likewise.
763 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
764 * w32gui.h (Time): Define by including "systime.h" rather than by
765 declaring it ourselves. (Bug#8664)
766
d4e3e4d3
PE
767 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
768 * image.c (clear_image_cache): Likewise.
769
f6a24d19
PE
770 * term.c (term_mouse_position): Don't assume time_t wraparound.
771
08dc5ae6
PE
772 Be more systematic about user-interface timestamps.
773 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
774 and sometimes 'EMACS_UINT', to represent these timestamps.
775 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
776 This makes the code easier to follow, and makes it easier to catch
777 integer overflow bugs such as Bug#8664.
778 * frame.c (Fmouse_position, Fmouse_pixel_position):
779 Use Time, not unsigned long, for user-interface timestamps.
780 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
781 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
782 * keyboard.h (last_event_timestamp): Likewise.
783 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
784 * menu.h (xmenu_show): Likewise.
785 * term.c (term_mouse_position): Likewise.
786 * termhooks.h (struct input_event.timestamp): Likewise.
787 (struct terminal.mouse_position_hook): Likewise.
788 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
789 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
790 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
791 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
792 what it was before.
793 * menu.h, termhooks.h: Include "systime.h", for Time.
794
8e55734a
PE
795 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
796 Don't assume that the difference between two unsigned long values
797 can fit into an integer. At this point, we know button_down_time
798 <= event->timestamp, so the difference must be nonnegative, so
799 there's no need to cast the result if double-click-time is
800 nonnegative, as it should be; check that it's nonnegative, just in
801 case. This bug is triggered when events are more than 2**31 ms
86db42d2 802 apart (about 25 days). (Bug#8664)
8e55734a 803
841f1b75 804 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 805 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 806
3e26f69c
PE
807 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
808 that always fit in int. Use a sentinel instead of a counter, to
809 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
810 * frame.h (struct frame): Use int for menu_bar_items_used
811 instead of EMACS_INT, since it always fits in int.
3e26f69c 812
5cc152c0
PE
813 * menu.c (grow_menu_items): Check for int overflow.
814
d89eb65e
PE
815 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
816
5235bd3e
PE
817 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
818 Before, the code was not consistent. These values cannot exceed
819 2**31 - 1 so there's no need to make them unsigned.
820 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
821 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
822 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
823 as modifiers.
824 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
825
bc827e23
PE
826 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
827 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
828 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
829 presumably because the widths might not match.
830
78eb494e
PE
831 * window.c (size_window): Avoid needless test at loop start.
832
04f2d78b
CB
8332011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
834
835 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
836
d2fc7e3d 8372011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
838
839 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
840
d2fc7e3d 8412011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
842
843 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
844 `width' to `bar_area_x' and `bar_area_width', respectively.
845 (x_scroll_run): Take account of fringe background extension.
846
04f2d78b
CB
847 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
848 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
849 `bar_area_width', respectively.
850 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
851 background extension.
852
79b70037
GM
8532011-05-10 Jim Meyering <meyering@redhat.com>
854
855 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
856
2f142cc5
JB
8572011-05-10 Juanma Barranquero <lekktu@gmail.com>
858
859 * image.c (Finit_image_library): Return t for built-in image types,
860 like pbm and xbm. (Bug#8640)
861
57679c86
AS
8622011-05-09 Andreas Schwab <schwab@linux-m68k.org>
863
864 * w32menu.c (set_frame_menubar): Fix submenu allocation.
865
888c9e86
EZ
8662011-05-07 Eli Zaretskii <eliz@gnu.org>
867
b0512a1d
EZ
868 * w32console.c (Fset_screen_color): Doc fix.
869 (Fget_screen_color): New function.
870 (syms_of_ntterm): Defsubr it.
871
7285dc67
EZ
872 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
873 unlink the temporary file if Fcall_process didn't create it in the
874 first place.
875 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
876 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
877 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
878 cue to call_process_cleanup not to close that handle.
879
4d3fcc8e
BK
8802011-05-07 Ben Key <bkey76@gmail.com>
881
882 * makefile.w32-in: The bootstrap-temacs rule now makes use of
883 one of two shell specific rules, either bootstrap-temacs-CMD or
884 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
885 to the previous implementation of the bootstrap-temacs rule.
886 The bootstrap-temacs-CMD rule is similar to the previous
887 implementation of the bootstrap-temacs rule except that it
888 makes use of the ESC_CFLAGS variable instead of the CFLAGS
889 variable.
890
891 These changes, along with some changes to nt/configure.bat,
892 nt/gmake.defs, and nt/nmake.defs, are required to extend my
893 earlier fix to add support for --cflags and --ldflags options
894 that include quotes so that it works whether make uses cmd or
895 sh as the shell.
896
b4289b64
MA
8972011-05-06 Michael Albinus <michael.albinus@gmx.de>
898
899 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
900 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
901 is a constant.
902 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
903 a string. Handle both cases.
904 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
905 (Fdbus_register_method): Use Qinvalid_function.
906
af4c0e28
JB
9072011-05-06 Juanma Barranquero <lekktu@gmail.com>
908
909 * makefile.w32-in: Update dependencies.
910 (LISP_H): Add inttypes.h and stdin.h.
911 (PROCESS_H): Add unistd.h.
912
c51453d9
EZ
9132011-05-06 Eli Zaretskii <eliz@gnu.org>
914
915 * lread.c: Include limits.h (fixes the MS-Windows build broken by
916 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
917
8ff0ac3c 9182011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 919
4c4b566b
PE
920 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
921
aab2b9b5
PE
922 * term.c (vfatal): Remove stray call to va_end.
923 It's not needed and the C Standard doesn't allow it here anyway.
924
c378da0b
PE
925 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
926 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
927
288b08c7
PE
928 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
929 bytes.
930
e3601888
PE
931 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
932
db6c0e74
PE
933 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
934
dd5963ea
PE
935 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
936
88c9450f
PE
937 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
938
2f9442b8
PE
939 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
940
c032b5f8
PE
941 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
942 * charset.c (Fdefine_charset_internal): Don't initialize
943 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 944 32-bit int (Bug#8600).
a108c10b
PE
945
946 * lread.c (read_integer): Be more consistent with string-to-number.
947 Use string_to_number to do the actual conversion; this avoids
948 rounding errors and fixes some other screwups. Without this fix,
949 for example, #x1fffffffffffffff was misread as -2305843009213693952.
950 (digit_to_number): Move earlier, for benefit of read_integer.
951 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 952 not a digit in any supported base. (Bug#8602)
a108c10b 953
ad5f9eea
PE
954 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
955
aec1708a
PE
956 * dispnew.c (scrolling_window): Return 1 if we scrolled,
957 to match comment at start of function. This also removes a
958 GCC warning about overflow in a 32+64-bit port.
959
47be4ab5
PE
960 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
961
371cac43
PE
962 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
963 Reported by Stefan Monnier in
964 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
965 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
966 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 967
d01a7826
PE
968 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
969 (EMACS_UINTPTR): Likewise, with uintptr_t.
970
7fd47d5c
PE
971 * lisp.h: Prefer 64-bit EMACS_INT if available.
972 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
973 on 32-bit hosts that have 64-bit int, so that they can access
974 large files.
122b0c86
PE
975 However, temporarily disable this change unless the temporary
976 symbol WIDE_EMACS_INT is defined.
7fd47d5c 977
8727937b
PE
978 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
979
8ac068ac
PE
980 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
981 This removes an assumption that EMACS_INT and long are the same
982 width as pointers. The assumption is true for Emacs porting targets
983 now, but we want to make other targets possible.
984 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
985 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
986 In the rest of the code, change types of integers that hold casted
987 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
988 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
989 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
990 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
991 No need to cast type when ORing.
992 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
993 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
994 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
995 assume EMACS_INT is the same width as char *.
996 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
997 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
998 Remove no-longer-needed casts.
999 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1000 (xg_tool_bar_help_callback, xg_make_tool_item):
1001 Use EMACS_INTPTR to hold an integer
1002 that will be cast to void *; this can avoid a GCC warning
1003 if EMACS_INT is not the same width as void *.
1004 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1005 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1006 (current_message_1, set_message_1):
1007 Use a local to convert to proper width without a cast.
1008 * xmenu.c (dialog_selection_callback): Likewise.
1009
ede49d71
PE
1010 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1011 Also, don't assume VALBITS / RAND_BITS is less than 5,
1012 and don't rely on undefined behavior when shifting a 1 left into
1013 the sign bit.
1014 * lisp.h (get_random): Change signature to match.
1015
2f30ecd0
PE
1016 * lread.c (hash_string): Use size_t, not int, for hash computation.
1017 Normally we prefer signed values; but hashing is special, because
1018 it's better to use unsigned division on hash table sizes so that
1019 the remainder is nonnegative. Also, size_t is the natural width
1020 for hashing into memory. The previous code used 'int', which doesn't
1021 retain enough info to hash well into very large tables.
1022 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1023
2a866e7b
PE
1024 * dbusbind.c: Don't possibly lose pointer info when converting.
1025 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1026 Use XPNTR rather than XHASH, so that the high-order bits of
1027 the pointer aren't lost when converting through void *.
1028
51639eac
PE
1029 * eval.c (Fautoload): Don't double-shift a pointer.
1030
92394119
PE
1031 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1032
dbdb9a7c
JB
10332011-05-06 Juanma Barranquero <lekktu@gmail.com>
1034
1035 * gnutls.c (DEF_GNUTLS_FN):
1036 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1037
db7a0b4f
AS
10382011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1039
1040 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1041 marker. (Bug#8610)
1042
f7ff1b0f 10432011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1044
1045 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1046 New version that can reserve upto 2GB of heap space.
1047
f7ff1b0f 10482011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1049
1050 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1051
639c109b
TZ
10522011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1053
1054 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1055 `gnutls_certificate_set_x509_key_file'.
1056
d2127135
JB
10572011-05-05 Juanma Barranquero <lekktu@gmail.com>
1058
1059 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1060 Update dependencies.
1061
e968f4f3
JB
10622011-05-04 Juanma Barranquero <lekktu@gmail.com>
1063
1064 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1065 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1066 Remove unused parameter `fildes'.
1067 * process.c (read_process_output, send_process): Don't pass it.
1068
84d358f0
JB
10692011-05-04 Juanma Barranquero <lekktu@gmail.com>
1070
1071 Fix previous change: the library cache is defined in w32.c.
1072 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1073 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1074
0898ca10
JB
10752011-05-04 Juanma Barranquero <lekktu@gmail.com>
1076
1077 Implement dynamic loading of GnuTLS on Windows.
1078
1079 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1080 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1081 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1082 Declare.
1083
1084 * gnutls.c (Qgnutls_dll): Define.
1085 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1086 (gnutls_*): Declare function pointers.
1087 (init_gnutls_functions): New function to initialize function pointers.
1088 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1089 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1090 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1091 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1092 (emacs_gnutls_write, emacs_gnutls_read)
1093 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1094 (Fgnutls_available_p): New function.
1095 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1096 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1097 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1098
1099 * image.c: Include w32.h.
1100 (Vimage_type_cache): Delete.
1101 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1102 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1103 (w32_delayed_load): Move to w32.c.
1104
1105 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1106
1107 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1108 (w32_delayed_load): Move from image.c. When loading a library, record
1109 its filename in the :loaded-from property of the library id.
1110 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1111 Initialize and staticpro them.
1112 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1113
1114 * process.c: Include lisp.h before w32.h, not after.
1115 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1116 instead of gnutls_record_check_pending.
1117
1118 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1119
ff4de4aa
TZ
11202011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1121
1122 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1123 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1124 as passed in.
1125
abe95abb
JD
11262011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1127
1128 * xterm.c (x_set_frame_alpha): Do not set property on anything
1129 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1130
e16e55d4
JB
11312011-05-02 Juanma Barranquero <lekktu@gmail.com>
1132
1133 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1134
bafcf6a5
JB
11352011-05-02 Juanma Barranquero <lekktu@gmail.com>
1136
1137 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1138 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1139 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1140 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1141 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1142 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1143 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1144 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1145 (Qgnutls_bootprop_callbacks_verify): Make static.
1146
e7a6747f
AS
11472011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1148
19ed11ba
AS
1149 * callproc.c: Indentation fixup.
1150
e7a6747f 1151 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1152 (wait_for_termination, interruptible_wait_for_termination):
1153 Move after wait_for_termination_1.
e7a6747f 1154
1ef14cb4
LMI
11552011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1156
1157 * sysdep.c (interruptible_wait_for_termination): New function
1158 which is like wait_for_termination, but allows keyboard
1159 interruptions.
1160
1161 * callproc.c (Fcall_process): Add (:file "file") as an option for
1162 the STDOUT buffer.
1163 (Fcall_process_region): Ditto.
1164
330d880c
EZ
11652011-04-30 Eli Zaretskii <eliz@gnu.org>
1166
8db90b73
EZ
1167 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1168 rather than `XVECTOR (FOO)->size'.
1169
330d880c
EZ
1170 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1171 inttypes.h, as a gnulib replacement is used if it not available in
1172 system headers.
1173
15cbd324
EZ
11742011-04-21 Eli Zaretskii <eliz@gnu.org>
1175
1176 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1177 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1178 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1179
1180 * coding.c (coding_alloc_by_realloc): Error out if destination
1181 will grow beyond MOST_POSITIVE_FIXNUM.
1182 (decode_coding_emacs_mule): Abort if there isn't enough place in
1183 charbuf for the composition carryover bytes. Reserve an extra
1184 space for up to 2 characters produced in a loop.
1185 (decode_coding_iso_2022): Abort if there isn't enough place in
1186 charbuf for the composition carryover bytes.
1187
11882011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1189
ae940cca
EZ
1190 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1191 aborting when %lld or %lll format is passed.
1192 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1193 %llo or %llx format is passed. (Bug#8545)
1194
03ab8921
EZ
1195 * window.c (window_scroll_line_based): Use a marker instead of
1196 simple variables to record original value of point. (Bug#7952)
1197
afda1437
EZ
1198 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1199 produced by %s or %c overflows available buffer space. (Bug#8545)
1200
f76dee0c
PE
12012011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1202
1203 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1204 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1205
fdc5744d
JB
12062011-04-28 Juanma Barranquero <lekktu@gmail.com>
1207
1208 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1209
638f053a
JB
12102011-04-28 Juanma Barranquero <lekktu@gmail.com>
1211
1212 * keyboard.c (Qdelayed_warnings_hook): Define.
1213 (command_loop_1): Run `delayed-warnings-hook'
1214 if Vdelayed_warnings_list is non-nil.
1215 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1216 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1217
d178f871
EZ
12182011-04-28 Eli Zaretskii <eliz@gnu.org>
1219
1220 * doprnt.c (doprnt): Don't return value smaller than the buffer
1221 size if the message was truncated. (Bug#8545).
1222
b124fd93
JB
12232011-04-28 Juanma Barranquero <lekktu@gmail.com>
1224
1225 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1226 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1227
e810457d
PE
12282011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1229
1230 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1231
ea51cceb
JB
12322011-04-27 Juanma Barranquero <lekktu@gmail.com>
1233
1234 * makefile.w32-in: Update dependencies.
1235
94dcfacf
EZ
12362011-04-27 Eli Zaretskii <eliz@gnu.org>
1237
1238 Improve `doprnt' and its usage. (Bug#8545)
1239 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1240 `format_end'. Remove support for %l as a conversion specifier.
1241 Don't use xrealloc. Improve diagnostics when the %l size modifier
1242 is used. Update the commentary.
1243
1244 * eval.c (verror): Simplify calculation of size_t.
1245
1246 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1247 messages.
1248
f61f41d7
PE
12492011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1250
1251 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1252 change.
1253
96fb4434
PE
12542011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1255
1256 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1257 This makes this file independent of the recent pseudovector change.
1258
671875da 12592011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1260
69e9b5a3
PE
1261 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1262
b5f869a7 1263 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1264 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1265 Remove unused local.
c8926152 1266 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1267
841a1577 1268 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1269 GCC 4.6.0 optimizes based on type-based alias analysis.
1270 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1271 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1272 != &v->size, and therefore "v->size = 1; b->size = 2; return
1273 v->size;" must therefore return 1. This assumption is incorrect
1274 for Emacs, since it type-puns struct Lisp_Vector * with many other
1275 types. To fix this problem, this patch adds a new type struct
f904488f 1276 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1277 and pseudovectors, and helps optimizing compilers not get fooled
1278 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1279 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1280 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1281 the size member.
eab3844f
PE
1282 (XSETPVECTYPE): Rewrite in terms of new macro.
1283 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1284 This is a bit clearer, and further avoids the possibility of
1285 undesirable aliasing.
1286 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1287 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1288 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1289 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1290 (ASIZE): Now uses header.size rather than size.
1291 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1292 to avoid the hassle of writing XVECTOR (foo)->header.size.
1293 (struct vectorlike_header): New type.
eab3844f
PE
1294 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1295 object, to help avoid aliasing.
1296 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1297 (SUBRP): Likewise, since Lisp_Subr is a special case.
1298 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1299 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1300 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1301 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1302 changed to be "header.size" and "header.next".
1303 * buffer.h (struct buffer): Likewise.
1304 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1305 * frame.h (struct frame): Likewise.
1306 * process.h (struct Lisp_Process): Likewise.
1307 * termhooks.h (struct terminal): Likewise.
1308 * window.c (struct save_window_data, struct saved_window): Likewise.
1309 * window.h (struct window): Likewise.
1310 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1311 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1312 * buffer.c (init_buffer_once): Likewise.
1313 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1314 special case.
1315 * process.c (Fformat_network_address): Use local var for size,
1316 for brevity.
1317
0df1eac5
PE
1318 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1319
847ab9d1 1320 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1321 * data.c (atof): Remove decl; no longer used or needed.
1322 (digit_to_number): Move to lread.c.
1323 (Fstring_to_number): Use new string_to_number function, to be
1324 consistent with how the Lisp reader treats infinities and NaNs.
1325 Do not assume that floating-point numbers represent EMACS_INT
1326 without losing information; this is not true on most 64-bit hosts.
1327 Avoid double-rounding errors, by insisting on integers when
1328 parsing non-base-10 numbers, as the documentation specifies.
1329 * lisp.h (string_to_number): New decl, replacing ...
1330 (isfloat_string): Remove.
bc0a5c13 1331 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1332 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1333 appears to have been a coding error. Similarly, do not accept
1334 strings like +-1e0 as floating point numbers. Do not report
1335 overflow for integer overflows unless the base is not 10 which
1336 means we have no simple and reliable way to continue.
1337 Break out the floating-point parsing into a new
1338 function string_to_number, so that Fstring_to_number parses
1339 floating point numbers consistently with the Lisp reader.
04f2d78b 1340 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1341 (E_CHAR, EXP_INT): Remove, replacing with ...
1342 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1343 (string_to_number): New function, replacing isfloat_string.
1344 This function checks for valid syntax and produces the resulting
1345 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1346 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1347 so that overflow for non-base-10 numbers is reported only when
1348 there's no portable and simple way to convert to floating point.
452f4150 1349
67769ffc
PE
1350 * textprop.c (set_text_properties_1): Rewrite for clarity,
1351 and to avoid GCC warning about integer overflow.
1352
c20db43f
PE
1353 * intervals.h (struct interval): Use EMACS_INT for members
1354 where EMACS_UINT might cause problems. See
1355 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1356 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1357 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1358 All uses changed.
37aa2f85
PE
1359 (offset_intervals): Tell GCC not to worry about length overflow
1360 when negating a negative length.
c20db43f 1361
2538aa2f
PE
1362 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1363 (overrun_check_free): Likewise.
1364
f2d3008d
PE
1365 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1366 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1367 word size.
1368
ec8df744
PE
1369 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1370 (gnutls_make_error): Rename local to avoid shadowing.
1371 (gnutls_emacs_global_deinit): ifdef out; not used.
1372 (Fgnutls_boot): Use const for pointer to readonly storage.
1373 Comment out unused local. Fix pointer signedness problems.
1374
640ee02d
PE
1375 * lread.c (openp): Don't stuff size_t into an 'int'.
1376 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1377 about possible signed overflow.
1378
6048fb2a
PE
1379 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1380 (GDK_KEY_g): Don't define if already defined.
1381 (xg_prepare_tooltip): Avoid pointer signedness problem.
1382 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1383
fa3c87e1
PE
1384 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1385 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1386
2172544b
PE
1387 * xfns.c (Fx_window_property): Simplify a bit,
1388 to make a bit faster and to avoid GCC 4.6.0 warning.
1389 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1390
9b821a21
PE
1391 * fns.c (internal_equal): Don't assume size_t fits in int.
1392
3c616cfa
PE
1393 * alloc.c (compact_small_strings): Tighten assertion a little.
1394
c2982e87
PE
1395 Replace pEd with more-general pI, and fix some printf arg casts.
1396 * lisp.h (pI): New macro, generalizing old pEd macro to other
1397 conversion specifiers. For example, use "...%"pI"d..." rather
1398 than "...%"pEd"...".
1399 (pEd): Remove. All uses replaced with similar uses of pI.
1400 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1401 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1402 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1403 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1404 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1405 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1406 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1407 64-bit hosts.
1408 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1409 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1410 * print.c (safe_debug_print, print_object): Likewise.
1411 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1412 to int.
6f04d126
PE
1413 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1414 avoiding the 0 flag, which is not portable.
c2982e87
PE
1415 * process.c (Fmake_network_process): Use pI to avoid cast.
1416 * region-cache.c (pp_cache): Likewise.
1417 * xdisp.c (decode_mode_spec): Likewise.
1418 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1419 behavior on 64-bit hosts with printf arg.
6f04d126 1420 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1421 (x_stop_queuing_selection_requests): Likewise.
1422 (x_get_window_property): Don't truncate byte count to an 'int'
1423 when tracing.
0b432f21 1424
5e073ec7
PE
1425 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1426 here, since it parses constructs like leading '-' and spaces,
1427 which are not wanted; and it overflows with large numbers.
1428 Instead, simply match F[0-9]+, which is what is wanted anyway.
1429
36372bf9
PE
1430 * alloc.c: Remove unportable assumptions about struct layout.
1431 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1432 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1433 (allocate_vectorlike, make_pure_vector): Use the new macros,
1434 plus offsetof, to remove unportable assumptions about struct layout.
1435 These assumptions hold on all porting targets that I know of, but
1436 they are not guaranteed, they're easy to remove, and removing them
1437 makes further changes easier.
1438
0b432f21
PE
1439 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1440 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1441 (string_overrun_cookie): Now const. Use initializers that
1442 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1443 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1444 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1445 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1446 multiple of sizeof (EMACS_INT); it need not be, if
1447 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1448 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1449
895009e1
JB
14502011-04-26 Juanma Barranquero <lekktu@gmail.com>
1451
1452 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1453
6a7a1b0b
TZ
14542011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1455
1456 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1457 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1458 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1459
841a1577 14602011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1461
1462 * lisp.h (Qdebug): List symbol.
895009e1 1463 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1464 * keyboard.c (debug-on-event): New variable.
1465 (handle_user_signal): Break into debugger when debug-on-event
1466 matches the current signal symbol.
1467
f2d3ba6f
DN
14682011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1469
1470 * alloc.c (check_sblock, check_string_bytes)
1471 (check_string_free_list): Convert to standard C.
1472
42ce4c63
TZ
14732011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1474
1475 * w32.c (emacs_gnutls_push): Fix typo.
1476
825cd63c
EZ
14772011-04-25 Eli Zaretskii <eliz@gnu.org>
1478
fb11d64d
EZ
1479 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1480 "cast to pointer from integer of different size".
1481
825cd63c
EZ
1482 Improve doprnt and its use in verror. (Bug#8545)
1483 * doprnt.c (doprnt): Document the set of format control sequences
1484 supported by the function. Use SAFE_ALLOCA instead of always
1485 using `alloca'.
1486
1487 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1488 is one byte too soon. Don't use xrealloc; instead xfree and
1489 xmalloc anew.
1490
e061a11b
TZ
14912011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1492
1493 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1494 callbacks stage.
1495
1496 * gnutls.c: Renamed global_initialized to
1497 gnutls_global_initialized. Added internals for the
1498 :verify-hostname-error, :verify-error, and :verify-flags
1499 parameters of `gnutls-boot' and documented those parameters in the
1500 docstring. Start callback support.
1501 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1502 unless a fatal error occured. Call gnutls_alert_send_appropriate
1503 on error. Return error code.
1504 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1505 (emacs_gnutls_read): Likewise.
1506 (Fgnutls_boot): Return handshake error code.
1507 (emacs_gnutls_handle_error): New function.
1508 (wsaerror_to_errno): Likewise.
1509
1510 * w32.h (emacs_gnutls_pull): Add prototype.
1511 (emacs_gnutls_push): Likewise.
1512
1513 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1514 (emacs_gnutls_push): Likewise.
1515
15162011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1517
1518 * process.c (wait_reading_process_output): Check if GnuTLS
1519 buffered some data internally if no FDs are set for TLS
1520 connections.
1521
1522 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1523 (LIBS): Link to USER_LIBS.
1524 ($(BLD)/gnutls.$(0)): New target.
1525
fa6996bc
EZ
15262011-04-24 Eli Zaretskii <eliz@gnu.org>
1527
eb35682e
EZ
1528 * xdisp.c (handle_single_display_spec): Rename the
1529 display_replaced_before_p argument into display_replaced_p, to
1530 make it consistent with the commentary. Fix typos in the
1531 commentary.
1532
e2ad650c
EZ
1533 * textprop.c (syms_of_textprop): Remove dead code.
1534 (copy_text_properties): Delete obsolete commentary about an
1535 interface that was deleted long ago. Fix typos in the description
1536 of arguments.
1537
1b2de274
EZ
1538 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1539 to changes in oldXMenu/XMenu.h from 2011-04-16.
1540 <menu_help_message, prev_menu_help_message>: Constify.
1541 (IT_menu_make_room): menu->help_text is now `const char **';
1542 adjust.
1543
1544 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1545 to changes in oldXMenu/XMenu.h from 2011-04-16.
1546 (struct XMenu): Declare `help_text' `const char **'.
1547
1548 * xfaces.c <Qunspecified>: Make extern again.
1549
1550 * syntax.c: Include sys/types.h before including regex.h, as
1551 required by Posix.
1552
762b15be
EZ
1553 * doc.c (get_doc_string): Improve the format passed to `error'.
1554
1555 * doprnt.c (doprnt): Improve commentary.
1556
1557 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1558
1559 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1560 them with etags.
1561
f1052e5d
EZ
1562 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1563 changes in globals.h immediately force recompilation.
762b15be
EZ
1564 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1565 $(CURDIR)/s/ms-w32.h.
1566 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1567
fa6996bc
EZ
1568 * character.c (Fchar_direction): Function deleted.
1569 (syms_of_character): Don't defsubr it.
1570 <char-direction-table>: Deleted.
1571
e6c3da20
EZ
15722011-04-23 Eli Zaretskii <eliz@gnu.org>
1573
1574 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1575 * doprnt.c: Include limits.h.
1576 (SIZE_MAX): New macro.
04f2d78b
CB
1577 (doprnt): Return a size_t value. 2nd arg is now size_t.
1578 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1579 Improve overflow protection. Support `l' modifier for integer
1580 conversions. Support %l conversion. Don't assume an EMACS_INT
1581 argument for integer conversions and for %c.
1582
1583 * lisp.h (doprnt): Restore prototype.
1584
1585 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1586 $(SRC)/character.h.
1587
1588 * Makefile.in (base_obj): Add back doprnt.o.
1589
1590 * deps.mk (doprnt.o): Add back prerequisites.
1591 (callint.o): Depend on character.h.
1592
1593 * eval.c (internal_lisp_condition_case): Include the handler
1594 representation in the error message.
1595 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1596 when breaking from the loop.
1597
1598 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1599
1600 * callint.c (Fcall_interactively): When displaying error message
1601 about invalid control letter, pass the character's codepoint, not
1602 a pointer to its multibyte form. Improve display of the character
1603 in octal and display also its hex code.
1604
1605 * character.c (char_string): Use %x to display the (unsigned)
1606 codepoint of an invalid character, to avoid displaying a bogus
1607 negative value.
1608
1609 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1610 `error', not SYMBOL_NAME itself.
1611
1612 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1613 character arguments to `error'.
1614
1615 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1616 to `error' in error message about FINAL_CHAR argument. Make sure
1617 FINAL_CHAR is a character, and use %c when it is passed as
1618 argument to `error'.
1619
4ffd0d6b 16202011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1621
1622 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1623
1624 * w32.c: Include <time.h>.
1625 (sys_localtime): New function.
1626
4ffd0d6b 16272011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1628
1629 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1630
4ffd0d6b 1631 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1632
4ffd0d6b 16332011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1634
4ffd0d6b
GM
1635 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1636 zombies (Bug#8467).
aac0c6e3 1637
04c56954
EZ
16382011-04-19 Eli Zaretskii <eliz@gnu.org>
1639
1640 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1641 gl_state.e_property when gl_state.object is Qt.
1642
1643 * insdel.c (make_gap_larger): Remove limitation of buffer size
1644 to <= INT_MAX.
1645
16a43933
CY
16462011-04-18 Chong Yidong <cyd@stupidchicken.com>
1647
1648 * xdisp.c (lookup_glyphless_char_display)
1649 (produce_glyphless_glyph): Handle cons cell entry in
1650 glyphless-char-display.
1651 (Vglyphless_char_display): Document it.
1652
1653 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1654 glyphless-char-display.
1655
4581706e
CY
16562011-04-17 Chong Yidong <cyd@stupidchicken.com>
1657
1658 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1659
1660 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1661
1662 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1663 definition for no-X builds.
1664
4887c6e2 16652011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1666
fd35b6f9
PE
1667 Static checks with GCC 4.6.0 and non-default toolkits.
1668
5c1ccb01
PE
1669 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1670
006c5daa
PE
1671 * process.c (keyboard_bit_set): Define only if SIGIO.
1672 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1673 (send_process): Repair possible setjmp clobbering.
1674
efc736d3
PE
1675 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1676
4e2fe2e6
PE
1677 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1678
f97334a2
PE
1679 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1680
4e75f29d
PE
1681 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1682 Define only if needed.
1683
90efadd1
PE
1684 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1685 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1686 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1687
3c647824
PE
1688 * dispextern.h (struct redisplay_interface): Rename param
1689 to avoid shadowing.
e264f262 1690 * termhooks.h (struct terminal): Likewise.
761383f4 1691 * xterm.c (xembed_send_message): Likewise.
3c647824 1692
b58c5c4a
PE
1693 * insdel.c (make_gap_smaller): Define only if
1694 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1695
cad59032
PE
1696 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1697 it.
1698
c339dc2e
PE
1699 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1700 so that we aren't warned about unused symbols.
1701
91a3e27b
PE
1702 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1703
399c71d3 1704 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1705
8ffc96f5
PE
1706 * xfns.c (x_real_positions): Mark locals as initialized.
1707
eef9bc79
PE
1708 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1709
098db9dd
PE
1710 * xterm.c: Fix problems found by static analysis with other toolkits.
1711 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1712 (x_dispatch_event): Declare static if USE_GTK, and
1713 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1714 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1715 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1716 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1717 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1718
eb18f6cc
PE
1719 * xmenu.c (menu_help_callback): Pointer type fixes.
1720 Use const pointers when pointing at readonly data. Avoid pointer
1721 signedness clashes.
1722 (FALSE): Remove unused macro.
1723 (update_frame_menubar): Remove unused decl.
1724
1fe72bf8
PE
1725 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1726
60d9e1db
PE
1727 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1728 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1729 (single_menu_item): Rename local to avoid shadowing.
1730
39261c26
PE
1731 * keyboard.c (make_lispy_event): Remove unused local var.
1732
018c5e19
PE
1733 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1734 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1735
63d2b86e
PE
1736 * bitmaps: Change bitmaps from unsigned char back to the X11
1737 compatible char. Avoid the old compiler warnings about
1738 out-of-range initializers by using, for example, '\xab' rather
1739 than 0xab.
1740
aefd87e1
PE
1741 * xgselect.c (xgselect_initialize): Check vs interface
1742 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1743
bf501fb9
PE
1744 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1745
e9829fdf
PE
1746 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1747 to read-only memory.
1748
1086c095
PE
1749 * fns.c (vector): Remove; this old hack is no longer needed.
1750
2baccd04 1751 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1752 Remove unused var.
dde42981 1753 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1754
72391843 1755 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1756
436c16df 1757 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1758 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1759 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1760
92bb796d 1761 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1762 (x_term_init): Remove local to avoid shadowing.
92bb796d 1763
764430a3 1764 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1765
1766 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1767 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1768
d1dfb56c
EZ
17692011-04-16 Eli Zaretskii <eliz@gnu.org>
1770
c4354cb4
EZ
1771 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1772
d1dfb56c
EZ
1773 Fix regex.c, syntax.c and friends for buffers > 2GB.
1774 * syntax.h (struct gl_state_s): Declare character position members
1775 EMACS_INT.
1776
1777 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1778
04f2d78b
CB
1779 * textprop.c (verify_interval_modification, interval_of):
1780 Declare arguments EMACS_INT.
d1dfb56c
EZ
1781
1782 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1783 EMACS_INT.
1784
1785 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1786
1787 * indent.c (Fvertical_motion): Local variable it_start is now
1788 EMACS_INT.
1789
1790 * regex.c (re_match, re_match_2, re_match_2_internal)
1791 (bcmp_translate, regcomp, regexec, print_double_string)
1792 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1793 (re_compile_pattern, re_exec): Declare arguments and local
1794 variables `size_t' and `ssize_t' and return values `regoff_t', as
1795 appropriate.
1796 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1797 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1798 <compile_stack_type>: `size' and `avail' are now `size_t'.
1799
1800 * regex.h <regoff_t>: Use ssize_t, not int.
1801 (re_search, re_search_2, re_match, re_match_2): Arguments that
1802 specify buffer/string position and length are now ssize_t and
1803 size_t. Return type is regoff_t.
1804
613052cd
BK
18052011-04-16 Ben Key <bkey76@gmail.com>
1806
1807 * nsfont.m: Fixed bugs in ns_get_family and
1808 ns_descriptor_to_entity that were caused by using free to
1809 deallocate memory blocks that were allocated by xmalloc (via
1810 xstrdup). This caused Emacs to crash when compiled with
1811 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1812 --enable-checking=xmallocoverrun). xfree is now used to
1813 deallocate these memory blocks.
1814
4170f62f 18152011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1816
71b41406
PE
1817 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1818
9587a89d
PE
1819 emacs_write: Accept and return EMACS_INT for sizes.
1820 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1821 et seq.
1822 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1823 Accept and return EMACS_INT.
1824 (emacs_gnutls_write): Return the number of bytes written on
1825 partial writes.
1826 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1827 (emacs_read, emacs_write): Remove check for negative size, as the
1828 Emacs source code has been audited now.
9587a89d
PE
1829 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1830 (emacs_read, emacs_write): Use it.
273a5f82
PE
1831 * process.c (send_process): Adjust to the new signatures of
1832 emacs_write and emacs_gnutls_write. Do not attempt to store
1833 a byte offset into an 'int'; it might overflow.
9587a89d 1834 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1835
3e047f51
PE
1836 * sound.c: Don't assume sizes fit in 'int'.
1837 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1838 Return EMACS_INT, not int.
3e047f51 1839 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1840 Accept EMACS_INT, not int.
1841 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1842 record read return values.
1843
cc39a9db
BK
18442011-04-15 Ben Key <bkey76@gmail.com>
1845
c9d0ec6d
JB
1846 * keyboard.c (Qundefined): Don't declare static since it is used
1847 in nsfns.m.
1848 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1849 static since they are used in nsfont.m.
cc39a9db 1850
6c60eb9f
SM
18512011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1852
1853 * process.c (Qprocessp): Don't declare static.
1854 * lisp.h (Qprocessp): Declare again.
1855
7990b61a
JB
18562011-04-15 Juanma Barranquero <lekktu@gmail.com>
1857
1858 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1859
5d4cb038
PE
18602011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1861
8bd7b830 1862 Improve C-level modularity by making more things 'static'.
cd64ea1d 1863
e3b27b31
PE
1864 Don't publish debugger-only interfaces to other modules.
1865 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1866 (verify_bytepos, count_markers): Move decls to the only modules
1867 that need them.
1868 * region-cache.h (pp_cache): Likewise.
1869 * window.h (check_all_windows): Likewise.
1870 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1871
5d4cb038
PE
1872 * sysdep.c (croak): Now static, if
1873 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1874 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1875
1876 * alloc.c (refill_memory_reserve): Now static if
1877 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1878 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1879
e87b6180
PE
1880 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1881 Define only if USE_LUCID.
1882
ac64929e
PE
1883 * xrdb.c (x_customization_string, x_rm_string): Now static.
1884
6f37259d
PE
1885 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1886 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1887
1683e3ab
PE
1888 * xdisp.c (draw_row_with_mouse_face): Now static.
1889 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1890
de9c2632
PE
1891 * window.h (check_all_windows): Mark externally visible.
1892
2b96acb7
PE
1893 * window.c (window_deletion_count): Now static.
1894
1895 * undo.c: Make symbols static if they're not exported.
1896 (last_undo_buffer, last_boundary_position, pending_boundary):
1897 Now static.
1898
50436f33
PE
1899 * textprop.c (interval_insert_behind_hooks): Now static.
1900 (interval_insert_in_front_hooks): Likewise.
1901
64520e5c
PE
1902 * term.c: Make symbols static if they're not exported.
1903 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1904 (max_frame_lines, tty_set_terminal_modes):
1905 (tty_reset_terminal_modes, tty_turn_off_highlight):
1906 (get_tty_terminal): Now static.
1907 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1908 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1909 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1910 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1911 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1912
1fa53021
PE
1913 * sysdep.c: Make symbols static if they're not exported.
1914 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1915 Now static.
1916 (sigprocmask_set, full_mask): Remove; unused.
1917 (wait_debugging): Mark as visible.
1918 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1919 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1920
d4b43b22
PE
1921 * syntax.c (syntax_temp): Define only if !__GNUC__.
1922
b7c513d0
PE
1923 * sound.c (current_sound_device, current_sound): Now static.
1924
989b29ad
PE
1925 * search.c (searchbufs, searchbuf_head): Now static.
1926
13a55a78
PE
1927 * scroll.c (scroll_cost): Remove; unused.
1928 * dispextern.h (scroll_cost): Remove decl.
1929
de68a1fc
PE
1930 * region-cache.h (pp_cache): Mark as externally visible.
1931
40ccffa6
PE
1932 * process.c: Make symbols static if they're not exported.
1933 (process_tick, update_tick, create_process, chan_process):
1934 (Vprocess_alist, proc_buffered_char, datagram_access):
1935 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1936 (deactivate_process): Mark defn as static, as well as decl.
1937 * lisp.h (create_process): Remove decl.
1938 * process.h (chan_process, Vprocess_alist): Remove decls.
1939
ad64fc97
PE
1940 * print.c: Make symbols static if they're not exported.
1941 (print_depth, new_backquote_output, being_printed, print_buffer):
1942 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1943 (print_interval, print_number_index, initial_stderr_stream):
1944 Now static.
1945 * lisp.h (Fprinc): Remove decl.
1946 (debug_output_compilation_hack): Mark as externally visible.
1947
adddb265
PE
1948 * sysdep.c (croak): Move decl from here to syssignal.h.
1949 * syssignal.h (croak): Put it here, so the API can be checked when
1950 'croak' is called from dissociate_if_controlling_tty.
1951
1717ede2
PE
1952 * minibuf.c: Make symbols static if they're not exported.
1953 (minibuf_save_list, choose_minibuf_frame): Now static.
1954 * lisp.h (choose_minibuf_frame): Remove decl.
1955
fa5fb2bc
PE
1956 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1957
1e3890d1
PE
1958 * lread.c: Make symbols static if they're not exported.
1959 (read_objects, initial_obarray, oblookup_last_bucket_number):
1960 Now static.
1961 (make_symbol): Remove; unused.
1962 * lisp.h (initial_obarray, make_symbol): Remove decls.
1963
8a1414fa
PE
1964 * keyboard.c: Make symbols static if they're not exported.
1965 (single_kboard, recent_keys_index, total_keys, recent_keys):
1966 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1967 (this_single_command_key_start, echoing, last_auto_save):
1968 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1969 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1970 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1971 (Vlispy_mouse_stem, double_click_count):
1972 Now static.
1973 (force_auto_save_soon): Define only if SIGDANGER.
1974 (ignore_mouse_drag_p): Now static if
1975 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1976 (print_help): Remove; unused.
1977 (stop_character, last_timer_event): Mark as externally visible.
1978 * keyboard.h (ignore_mouse_drag_p): Declare only if
1979 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1980 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1981 * lisp.h (echoing): Remove decl.
1982 (force_auto_save_soon): Declare only if SIGDANGER.
1983 * xdisp.c (redisplay_window): Simplify code, to make it more
1984 obvious that ignore_mouse_drag_p is not accessed if !defined
1985 USE_GTK && !defined HAVE_NS.
1986
93ea6e8f
PE
1987 * intervals.c: Make symbols static if they're not exported.
1988 (merge_properties_sticky, merge_interval_right, delete_interval):
1989 Now static.
1990 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1991
77382fcc
PE
1992 * insdel.c: Make symbols static if they're not exported.
1993 However, leave prepare_to_modify_buffer alone. It's never
1994 called from outside this function, but that appears to be a bug.
1995 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1996 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1997 (adjust_after_replace_noundo): Remove; unused.
1998 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1999 (signal_before_change): Remove decls.
77382fcc 2000
9306c32e
PE
2001 * indent.c (val_compute_motion, val_vmotion): Now static.
2002
cd44d2eb
PE
2003 * image.c: Make symbols static if they're not exported.
2004 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2005 if USE_GTK.
2006 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2007 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2008
ad9a7a06
PE
2009 * fringe.c (standard_bitmaps): Now static.
2010 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2011
81626931
PE
2012 * frame.c: Make symbols static if they're not exported.
2013 (x_report_frame_params, make_terminal_frame): Now static.
2014 (get_frame_param): Now static, unless HAVE_NS.
2015 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2016 (x_get_resource_string): Remove; not used.
2017 * frame.h (make_terminal_frame, x_report_frame_params):
2018 (x_get_resource_string); Remove decls.
2019 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2020 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2021
239f9db9
PE
2022 * font.c, fontset.c: Make symbols static if they're not exported.
2023 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2024 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2025 * font.c (font_close_object): Now static.
2026 * font.h (font_close_object): Remove.
2027 * fontset.c (FONTSET_OBJLIST): Remove.
2028 (free_realized_fontset) #if-0 the body, which does nothing.
2029 (face_suitable_for_char_p): #if-0, as it's never called.
2030 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2031 * xfaces.c (face_at_string_position):
2032 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2033 since 0 is always ASCII.
2034
dfcf3579
PE
2035 * fns.c (weak_hash_tables): Now static.
2036
5045092b
PE
2037 * fileio.c: Make symbols static if they're not exported.
2038 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2039 (Vwrite_region_annotation_buffers): Now static.
2040
57a96f5c
PE
2041 * eval.c: Make symbols static if they're not exported.
2042 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2043 * lisp.h (backtrace_list): Remove decl.
2044
35f08c38
PE
2045 * emacs.c: Make symbols static if they're not exported.
2046 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2047 (fatal_error_code, fatal_error_signal_hook, standard_args):
2048 Now static.
2049 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2050 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2051 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2052 * lisp.h (fatal_error_signal_hook): Remove decl.
2053 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2054
f44bd759
PE
2055 * editfns.c: Move a (normally-unused) function to its only use.
2056 * editfns.c, lisp.h (get_operating_system_release): Remove.
2057 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2058 worth the hassle of breaking this out.
2059
b532497d
PE
2060 * xterm.c: Make symbols static if they're not exported.
2061 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2062 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2063 (x_destroy_window, x_delete_display):
2064 Now static.
2065 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2066 (x_mouse_leave): Remove; unused.
2067 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2068 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2069 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2070 Remove decls.
2071 (x_mouse_leave): Declare only if WINDOWSNT.
2072 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2073 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2074 USE_X_TOOLKIT.
2075
1675728f
PE
2076 * ftxfont.c: Make symbols static if they're not exported.
2077 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2078 HAVE_FREETYPE.
2079 * font.h (ftxfont_driver): Likewise.
2080
e4cebfca
PE
2081 * xfns.c: Make symbols static if they're not exported.
2082 (x_last_font_name, x_display_info_for_name):
2083 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2084 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2085 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2086 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2087 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2088 (last_show_tip_args): Now static.
2089 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2090 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2091 (x_screen_planes): Remove; unused.
2092 * dispextern.h (x_screen_planes): Remove decl.
2093
5bf46f05
PE
2094 * dispnew.c: Make symbols static if they're not exported.
2095 * dispextern.h (redraw_garbaged_frames, scrolling):
2096 (increment_row_positions): Remove.
2097 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2098 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2099 Now static.
2100 (redraw_garbaged_frames): Remove; unused.
2101
435f4c28
PE
2102 * xfaces.c: Make symbols static if they're not exported.
2103 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2104 Remove decls.
2105 * xterm.h (defined_color): Remove decls.
2106 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2107 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2108 (menu_face_changed_default, defined_color, free_realized_face):
2109 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2110 (ascii_face_of_lisp_face): Remove; unused.
2111
8524aef3
PE
2112 * xdisp.c: Make symbols static if they're not exported.
2113 * dispextern.h (scratch_glyph_row, window_box_edges):
2114 (glyph_to_pixel_coords, set_cursor_from_row):
2115 (get_next_display_element, set_iterator_to_next):
2116 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2117 (show_mouse_face): Remove decls
2118 * frame.h (message_buf_print): Likewise.
2119 * lisp.h (pop_message, set_message, check_point_in_composition):
2120 Likewise.
2121 * xterm.h (set_vertical_scroll_bar): Likewise.
2122 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2123 (message_buf_print, scratch_glyph_row, displayed_buffer):
2124 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2125 (get_next_display_element, show_mouse_face, window_box_edges):
2126 (frame_to_window_pixel_xy, check_point_in_composition):
2127 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2128 (glyph_to_pixel_coords): Remove; unused.
2129
16390cd2
PE
2130 * dired.c (file_name_completion): Now static.
2131
2132 * dbusbind.c (xd_in_read_queued_messages): Now static.
2133
a25f4dfa
PE
2134 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2135 * data.c (circular_list_error): Remove.
2136
14a9c8df
PE
2137 * commands.h (last_point_position, last_point_position_buffer):
2138 (last_point_position_window): Remove decls.
2139 * keyboard.c: Make these variables static.
2140
04f2d78b
CB
2141 * coding.h (coding, code_convert_region, encode_coding_gap):
2142 Remove decls.
74ab6df5
PE
2143 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2144 (iso_code_class, detect_coding, code_convert_region): Now static.
2145 (encode_coding_gap): Remove; unused.
2146
38dfbee1
PE
2147 * chartab.c (chartab_chars, chartab_bits): Now static.
2148
a2cb4e63
PE
2149 * charset.h (charset_iso_8859_1): Remove decl.
2150 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2151 Now static.
2152
127198fd
PE
2153 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2154 * ccl.c (Vccl_program_table): Now static.
2155 (check_ccl_update): Remove; unused.
2156
d85b608f
PE
2157 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2158 * category.h: ... from here.
2159 * category.c (check_category_table, set_category_set): Now static.
2160
31cd66f3
PE
2161 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2162 * lisp.h: Remove these decls.
2163
c358e587
PE
2164 * buffer.c (buffer_count): Remove unused var.
2165
e78aecca
PE
2166 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2167 so that it's not optimized away.
2168 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2169 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2170 exported only to the debugger.
2171
e192d7d3 2172 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2173 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2174
92470028
PE
2175 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2176 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2177 was inaccessible from Lisp.
2178 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2179 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2180
244ed907
PE
2181 alloc.c: Import and export fewer symbols, and remove unused items.
2182 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2183 is defined.
2184 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2185 it's not optimized away by whole-program optimization.
2186 (message_enable_multibyte, free_misc): Remove.
2187 (catchlist, handlerlist, mark_backtrace):
2188 Declare only if BYTE_MARK_STACK.
2189 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2190 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2191 (message_enable_multibyte): Remove decl.
2192 (free_misc, interval_free_list, float_block, float_block_index):
2193 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2194 (cons_free_list, last_marked_index):
2195 Now static.
2196 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2197 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2198 (mark_backtrace): Define only if BYTE_MARK_STACK.
2199 * xdisp.c (message_enable_multibyte): Now static.
2200
61c2b50e 2201 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2202 This makes it easier for human readers (and static analyzers)
2203 to see whether these variables are used from other modules.
2204 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2205 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2206 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2207 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2208 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2209 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2210 * xmenu.c, xselect.c:
2211 Declare Q* vars static if they are not used in other modules.
2212 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2213 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2214 Remove decls of unexported vars.
2215 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2216
95c82688
PE
2217 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2218
16a97296
PE
2219 Make Emacs functions such as Fatom 'static' by default.
2220 This makes it easier for human readers (and static analyzers)
2221 to see whether these functions can be called from other modules.
2222 DEFUN now defines a static function. To make the function external
2223 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2224 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2225 (Finit_image_library):
16a97296
PE
2226 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2227 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2228 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2229 Remove decls, since these functions are now static.
2230 (Funintern, Fget_internal_run_time): New decls, since these functions
2231 were already external.
95c82688 2232
16a97296
PE
2233 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2234 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2235 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2236 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2237 * keyboard.c, keymap.c, lread.c:
2238 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2239 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2240 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2241 Mark functions with DEFUE instead of DEFUN,
2242 if they are used in other modules.
2243 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2244 decls for now-static functions.
2245 * buffer.h (Fdelete_overlay): Remove decl.
2246 * callproc.c (Fgetenv_internal): Mark as internal.
2247 * composite.c (Fremove_list_of_text_properties): Remove decl.
2248 (Fcomposition_get_gstring): New forward static decl.
2249 * composite.h (Fcomposite_get_gstring): Remove decl.
2250 * dired.c (Ffile_attributes): New forward static decl.
2251 * doc.c (Fdocumntation_property): New forward static decl.
2252 * eval.c (Ffetch_bytecode): New forward static decl.
2253 (Funintern): Remove extern decl; now in .h file where it belongs.
2254 * fileio.c (Fmake_symbolic_link): New forward static decl.
2255 * image.c (Finit_image_library): New forward static decl.
2256 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2257 * intervals.h (Fprevious_property_change):
2258 (Fremove_list_of_text_properties): Remove decls.
2259 * keyboard.c (Fthis_command_keys): Remove decl.
2260 (Fcommand_execute): New forward static decl.
2261 * keymap.c (Flookup_key): New forward static decl.
2262 (Fcopy_keymap): Now static.
2263 * keymap.h (Flookup_key): Remove decl.
2264 * process.c (Fget_process): New forward static decl.
2265 (Fprocess_datagram_address): Mark as internal.
2266 * syntax.c (Fsyntax_table_p): New forward static decl.
2267 (skip_chars): Remove duplicate decl.
2268 * textprop.c (Fprevious_property_change): New forward static decl.
2269 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2270 Now internal.
2271 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2272 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2273
785bbd42
PE
2274 * editfns.c (Fformat): Remove unreachable code.
2275
8b913b57
AS
22762011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2277
2278 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2279 change. (Bug#8496)
2280
a6744a35
EZ
22812011-04-13 Eli Zaretskii <eliz@gnu.org>
2282
2283 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2284 when at ZV. (Bug#8487)
2285
e7974947
AS
22862011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2287
baad03f0
AS
2288 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2289 (Bug#8437)
2290 * keyboard.c (parse_tool_bar_item): Likewise.
2291 * sound.c (sound_cleanup, alsa_close): Likewise.
2292 * termcap.c (tgetent): Likewise.
2293 * xfns.c (x_default_font_parameter): Likewise.
2294 * xsettings.c (read_and_apply_settings): Likewise.
2295
e7974947
AS
2296 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2297 (overrun_check_free): Protoize.
2298
28272684
PE
22992011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2300
2301 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2302 since callers should never pass a negative size.
2303 Change the signature to match that of plain 'read' and 'write'; see
2304 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2305 * lisp.h: Update prototypes of emacs_write and emacs_read.
2306
11997c76
EZ
23072011-04-11 Eli Zaretskii <eliz@gnu.org>
2308
2309 * xdisp.c (redisplay_window): Don't try to determine the character
2310 position of the scroll margin if the window start point w->startp
e896f03c 2311 is outside the buffer's accessible region. (Bug#8468)
11997c76 2312
8a2cbd72
EZ
23132011-04-10 Eli Zaretskii <eliz@gnu.org>
2314
2315 Fix write-region and its subroutines for buffers > 2GB.
2316 * fileio.c (a_write, e_write): Modify declaration of arguments and
2317 local variables to support buffers larger than 2GB.
2318 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2319
2320 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2321 argument, local variables, and return value.
2322
2323 * lisp.h: Update prototypes of emacs_write and emacs_read.
2324
2325 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2326
4073e537 23272011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2328
1ebfdcb6
PE
2329 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2330
b2ded58d
PE
2331 Fix more problems found by GCC 4.6.0's static checks.
2332
7d66342c
PE
2333 * xdisp.c (vmessage): Use a better test for character truncation.
2334
bbf47d44
PE
2335 * charset.c (load_charset_map): <, not <=, for optimization,
2336 and to avoid potential problems with integer overflow.
9248994d 2337 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2338 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2339 * editfns.c (Fformat): Likewise.
1e69125e 2340 * syntax.c (skip_chars): Likewise.
3befa583 2341
e3019616
PE
2342 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2343 This also lets GCC 4.6.0 generate slightly better loop code.
2344
becfa255
PE
2345 * callint.c (Fcall_interactively): <, not <=, for optimization.
2346 (Fcall_interactively): Count the number of arguments produced,
2347 not the number of arguments given. This is simpler and lets GCC
2348 4.6.0 generate slightly better code.
2349
dae0cd48
PE
2350 * ftfont.c: Distingish more carefully between FcChar8 and char.
2351 The previous code passed unsigned char * to a functions like
2352 strlen and xstrcasecmp that expect char *, which does not
2353 conform to the C standard.
2354 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2355 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2356 char * when the C standard requires it.
2357
76032d70
PE
2358 * keyboard.c (read_char): Remove unused var.
2359
eb3f1cc8
PE
2360 * eval.c: Port to Windows vsnprintf (Bug#8435).
2361 Include <limits.h>.
2362 (SIZE_MAX): Define if the headers do not.
2363 (verror): Do not give up if vsnprintf returns a negative count.
2364 Instead, grow the buffer. This ports to Windows vsnprintf, which
2365 does not conform to C99. Problem reported by Eli Zaretskii.
2366 Also, simplify the allocation scheme, by avoiding the need for
2367 calling realloc, and removing the ALLOCATED variable.
2368
70476b54
PE
2369 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2370
12020a9e
PE
2371 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2372 But keep the doprint source code for now, as we might revamp it
2373 and use it again (Bug#8435).
ea6c7ae6
PE
2374 * lisp.h (doprnt): Remove.
2375 * Makefile.in (base_obj): Remove doprnt.o.
2376 * deps.mk (doprnt.o): Remove.
2377
5fdb398c
PE
2378 error: Print 32- and 64-bit integers portably (Bug#8435).
2379 Without this change, on typical 64-bit hosts error ("...%d...", N)
2380 was used to print both 32- and 64-bit integers N, which relied on
2381 undefined behavior.
2382 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2383 New macro.
2384 * lisp.h (error, verror): Mark as printf-like functions.
2385 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2386 Report overflow in size calculations when allocating printf buffer.
2387 Do not truncate output string at its first null byte.
2388 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2389 Truncate the output at a character boundary, since vsnprintf does not
2390 do that.
2391 * charset.c (check_iso_charset_parameter): Convert internal
2392 character to string before calling 'error', since %c now has the
2393 printf meaning.
2394 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2395 overflow when computing char to be passed to 'error'. Do not
2396 pass Lisp_Object to 'error'; pass the integer instead.
2397 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2398 formatted with plain %d.
2399
b189fa66
PE
2400 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2401
bff87ef0
PE
2402 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2403
7e2cac20
PE
2404 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2405
ce4d90b5
PE
2406 * xterm.c (x_catch_errors): Remove duplicate declaration.
2407
266c9547
PE
2408 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2409
79c49ad2
PE
2410 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2411
368f4090
JM
24122011-04-10 Jim Meyering <meyering@redhat.com>
2413
2414 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2415 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2416 return ssize_t not "int", and use size_t as the buffer length.
2417 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2418 * gnutls.h: Update declarations.
2419 * process.c (read_process_output): Use ssize_t, to match.
2420 (send_process): Likewise.
2421
a32d4040
CY
24222011-04-09 Chong Yidong <cyd@stupidchicken.com>
2423
2424 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2425
8546720e 24262011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2427
04f2d78b
CB
2428 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2429 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2430
8546720e
GM
2431 * xterm.c (handle_one_xevent):
2432 * xmenu.c (create_and_show_popup_menu):
2433 * xselect.c (x_decline_selection_request)
2434 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2435
0a2f5c1a 24362011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2437
2438 Fix some uses of `int' instead of EMACS_INT.
2439 * search.c (string_match_1, fast_string_match)
2440 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2441 (scan_buffer, find_next_newline_no_quit)
2442 (find_before_next_newline, search_command, Freplace_match)
2443 (Fmatch_data): Make some `int' variables be EMACS_INT.
2444
2445 * xdisp.c (display_count_lines): 3rd argument and return value now
2446 EMACS_INT. All callers changed.
2447 (pint2hrstr): Last argument is now EMACS_INT.
2448
2449 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2450 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2451 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2452 (decode_coding_utf_16, decode_coding_emacs_mule)
2453 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2454 (decode_coding_ccl, decode_coding_charset)
2455 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2456 (decode_coding_iso_2022, decode_coding_emacs_mule)
2457 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2458 <char_offset, last_offset>: Declare EMACS_INT.
2459 (encode_coding_utf_8, encode_coding_utf_16)
2460 (encode_coding_emacs_mule, encode_invocation_designation)
2461 (encode_designation_at_bol, encode_coding_iso_2022)
2462 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2463 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2464 Declare EMACS_INT.
2465 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2466 (encode_invocation_designation): Last argument P_NCHARS is now
2467 EMACS_INT.
2468 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2469 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2470
2471 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2472 All users changed.
2473
2474 * ccl.c (Fccl_execute_on_string): Declare some variables
2475 EMACS_INT.
2476
8546720e 24772011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2478
2479 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2480
4e19a977
CS
24812011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2482
2483 * process.c (Fformat_network_address): Doc fix.
2484
87302331
R
24852011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2486
2487 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2488
cbb59342
CY
24892011-04-08 Chong Yidong <cyd@stupidchicken.com>
2490
2491 * keyboard.c (read_char): Call Lisp function help-form-show,
2492 instead of using internal_with_output_to_temp_buffer.
2493 (Qhelp_form_show): New var.
e0d38eeb 2494 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2495
2496 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2497
2498 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2499
e67a13ab
CY
25002011-04-06 Chong Yidong <cyd@stupidchicken.com>
2501
04f2d78b
CB
2502 * process.c (Flist_processes): Remove to Lisp.
2503 (list_processes_1): Delete.
e67a13ab 2504
973f782d
EZ
25052011-04-06 Eli Zaretskii <eliz@gnu.org>
2506
7c106b1e
EZ
2507 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2508
973f782d
EZ
2509 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2510
41cf7d1a 25112011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2512
ca23cc88
PE
2513 Fix more problems found by GCC 4.6.0's static checks.
2514
f390e2d5
PE
2515 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2516
42eea0d0
PE
2517 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2518
b69769da 2519 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2520
f9541e84
PE
2521 * xdisp.c (vmessage): Mark as a printf-like function.
2522
13841b55
PE
2523 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2524
c136c10f
PE
2525 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2526
5e2d4a30
PE
2527 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2528 printf-like functions.
2529 (tiff_load): Add casts to remove these marks before passing them
2530 to system-supplied API.
2531
583f48b9
PE
2532 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2533
b25d760e
PE
2534 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2535 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2536 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2537 directly, rather than having caller test rule sign. This avoids
2538 some unnecessary tests.
2539 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2540 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2541 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2542
bc7b6697 2543 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2544 (xfont_open): Avoid unnecessary tests.
bc7b6697 2545
27ccc379
PE
2546 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2547
dcd5c89a
PE
2548 * composite.h, composite.c (composition_gstring_put_cache):
2549 Use EMACS_INT, not int, for length.
2550
b13a45c6
PE
2551 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2552 breaking out part of COMPOSITION_DECODE_RULE.
2553 (COMPOSITION_DECODE_RULE): Use it.
2554 * composite.c (get_composition_id): Remove unused local vars,
2555 by using the new macro.
2556
1e792e4d
PE
2557 * textprop.c (set_text_properties_1): Change while to do-while,
2558 since the condition is always true at first.
2559
dc6c6455 2560 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2561 (interval_deletion_adjustment): Return unsigned value.
2562 All uses changed.
dc6c6455 2563
aba7731a
PE
2564 * process.c (list_processes_1, create_pty, read_process_output):
2565 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2566 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2567 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2568 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2569 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2570
fdfc4bf3
PE
2571 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2572
fca8fe46 2573 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2574 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2575
06a0259a 2576 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2577 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2578 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2579
e7b9e80f
PE
2580 * print.c (print_error_message): Avoid int overflow.
2581
56201685
PE
2582 * font.c (font_list_entities): Redo for clarity,
2583 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2584
78834453 2585 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2586 (font_score): Avoid potential overflow in diff calculation.
78834453 2587
0bc0b309 2588 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2589 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2590
e610eaca
PE
2591 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2592
b895abce
PE
2593 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2594 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2595 can always succeed if overflow has undefined behavior.
2596
1f1d9321 2597 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2598 (wordify): Omit three unnecessary tests.
1f1d9321 2599
c59478bc
PE
2600 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2601 All callers changed. This avoids the need for an unused var.
2602
79b73827
PE
2603 * casefiddle.c (casify_region): Remove var that is set but not used.
2604
a4db5dfe
PE
2605 * dired.c (file_name_completion): Remove var that is set but not used.
2606
43aae36e
PE
2607 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2608
2a47c44d 2609 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2610 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2611
a37c69bf
PE
2612 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2613 Check for integer overflow on size calculations.
2614
328ab8e7
PE
2615 * buffer.c (Fprevious_overlay_change): Remove var that is set
2616 but not used.
2617
e5a2a5cb
PE
2618 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2619 Remove vars that are set but not used.
8d84a6eb 2620 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2621 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2622
a60e5f68
PE
2623 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2624
f661cb61 2625 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2626 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2627
f0397f5a
PE
2628 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2629 that are set but not used.
2630
8664db06 2631 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2632 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2633
6abdaa4a
PE
2634 * xselect.c (x_get_local_selection, x_handle_property_notify):
2635 Remove vars that are set but not used.
2636
0ce7538d 2637 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2638 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2639
9ae848fc
PE
2640 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2641 Remove var that is set but not used.
0b918413
PE
2642 (scroll_bar_windows_size): Now size_t, not int.
2643 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2644 Check for overflow.
9ae848fc 2645
a5a62657
PE
2646 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2647 (map_tty_color) [!defined MSDOS]: Likewise.
2648
5c5cdd39
PE
2649 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2650
66ebf983
PE
2651 * coding.c: Remove vars that are set but not used.
2652 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2653 All callers changed.
2654 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2655 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2656 (decode_coding_charset): Remove vars that are set but not used.
2657
1be4d761
PE
2658 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2659 that is set but not used.
2660
47553fa8
PE
2661 * print.c (print_object): Remove var that is set but not used.
2662
1f7196bf 2663 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2664 The gnulib version avoids calling malloc in the usual case,
2665 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2666 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2667 * filelock.c (current_lock_owner): Likewise.
2668 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2669 * sysdep.c: Include allocator.h, careadlinkat.h.
2670 (emacs_no_realloc_allocator): New static constant.
2671 (emacs_readlink): New function.
fdb61804
PE
2672 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2673 ../lib/careadlinkat.h.
d1fdcab7 2674
f84c17c7
SM
26752011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2676
2677 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2678 first non-nil return value).
2679
ef3862ad
JD
26802011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2681
2682 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2683 if not defined (Bug#8403).
2684
376a7006
JB
26852011-04-02 Juanma Barranquero <lekktu@gmail.com>
2686
2687 * xdisp.c (display_count_lines): Remove parameter `start',
2688 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2689 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2690 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2691 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2692 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2693 and thereabouts. All callers changed.
2694 (get_per_char_metric): Remove parameter `f', unused since
2695 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2696
6ca3801d
JM
26972011-04-02 Jim Meyering <meyering@redhat.com>
2698
2699 do not dereference NULL upon failed strdup
2700 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2701 (ns_get_family): Likewise.
2702
d8e2b5ba
JB
27032011-04-02 Juanma Barranquero <lekktu@gmail.com>
2704
2705 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2706
8c74fcbd
JD
27072011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2708
2709 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2710 later (Bug#8403).
2711
7200d79c
SM
27122011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2713
03408648 2714 Add lexical binding.
7200d79c 2715
03408648
SM
2716 * window.c (Ftemp_output_buffer_show): New fun.
2717 (Fsave_window_excursion):
2718 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2719
2720 * lread.c (lisp_file_lexically_bound_p): New function.
2721 (Fload): Bind Qlexical_binding.
2722 (readevalloop): Remove `evalfun' arg.
2723 Bind Qinternal_interpreter_environment.
2724 (Feval_buffer): Bind Qlexical_binding.
2725 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2726 Mark as dynamic.
2727 (syms_of_lread): Declare `lexical-binding'.
2728
2729 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2730
2731 * keyboard.c (eval_dyn): New fun.
2732 (menu_item_eval_property): Use it.
ca105506
SM
2733
2734 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2735
03408648
SM
2736 * fns.c (concat, mapcar1): Accept byte-code-functions.
2737
2738 * eval.c (Fsetq): Handle lexical vars.
2739 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2740 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2741 (FletX, Flet): Obey lexical binding.
2742 (Fcommandp): Handle closures.
2743 (Feval): New `lexical' arg.
2744 (eval_sub): New function extracted from Feval. Use it almost
2745 everywhere where Feval was used. Look up vars in lexical env.
2746 Handle closures.
2747 (Ffunctionp): Move from subr.el.
2748 (Ffuncall): Handle closures.
2749 (apply_lambda): Remove `eval_flags'.
2750 (funcall_lambda): Handle closures and new byte-code-functions.
2751 (Fspecial_variable_p): New function.
2752 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2753 but without exporting it to Lisp.
23aba0ea 2754
23aba0ea 2755 * doc.c (Fdocumentation, store_function_docstring):
03408648 2756 * data.c (Finteractive_form): Handle closures.
23aba0ea 2757
03408648
SM
2758 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2759 interactive spec.
ba83908c 2760
04f2d78b
CB
2761 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2762 New byte-codes.
03408648
SM
2763 (exec_byte_code): New function extracted from Fbyte_code to handle new
2764 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2765
03408648 2766 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2767
03408648 2768 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2769
e2abce01
JB
27702011-03-31 Juanma Barranquero <lekktu@gmail.com>
2771
2772 * xdisp.c (redisplay_internal): Fix prototype.
2773
63696a73 27742011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2775
63696a73 2776 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2777 (try_scrolling): Use it when setting scroll_limit.
2778 Limit scrolling to 100 screen lines.
63696a73
EZ
2779 (redisplay_window): Even when falling back on "recentering",
2780 position point in the window according to scroll-conservatively,
2781 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2782
2783 (try_scrolling): When point is above the window, allow searching
2784 as far as scroll_max, or one screenful, to compute vertical
2785 distance from PT to the scroll margin position. This prevents
2786 try_scrolling from unnecessarily failing when
2787 scroll-conservatively is set to a value slightly larger than the
2788 window height. Clean up the case of PT below the margin at bottom
2789 of window: scroll_max can no longer be INT_MAX. When aggressive
2790 scrolling is in use, don't let point enter the opposite scroll
2791 margin as result of the scroll.
2792 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2793 threshold of 100 lines for never-recentering scrolling.
2794
e4cc2dfc
JB
27952011-03-31 Juanma Barranquero <lekktu@gmail.com>
2796
2797 * dispextern.h (move_it_by_lines):
2798 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2799 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2800 (message_log_check_duplicate): Remove parameters `prev_bol' and
2801 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2802 (redisplay_internal): Remove parameter `preserve_echo_area',
2803 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2804
2805 * indent.c (Fvertical_motion):
2806 * window.c (window_scroll_pixel_based, Frecenter):
2807 Don't pass `need_y_p' to `move_it_by_lines'.
2808
1c470562
SM
28092011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2810
44f230aa
SM
2811 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2812 steal a few bits to be more compact.
2813 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2814 Remove unneeded casts.
2815
1c470562
SM
2816 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2817
888adce9
ZK
28182011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2819
2820 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2821 binding" message (bug#7967).
2822
f838ed7b
PE
28232011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2824
77861b95
PE
2825 Fix more problems found by GCC 4.6.0's static checks.
2826
de6dbc14
PE
2827 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2828 Remove unused local var.
2829
f838ed7b
PE
2830 * editfns.c (Fmessage_box): Remove unused local var.
2831
792c7b2b
PE
2832 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2833 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2834 Omit unused local vars.
c499e557 2835 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2836 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2837 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2838 Omit unused local var.
2839
ba0165e1
PE
2840 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2841 Don't assume string length fits in int.
32ad8845 2842 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2843 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2844
3c59b4c9
PE
2845 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2846 instead of alloca (Bug#8344).
2847
a3eed478 2848 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2849 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2850
eb4d412d
PE
2851 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2852
1658b401
PE
2853 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2854 concerns.
2855
2856 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2857
2858 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2859
9a2c6e05
PE
2860 * keyboard.c (syms_of_keyboard): Use the same style as later
2861 in this function when indexing through an array. This also
2862 works around GCC bug 48267.
2863
03d0a109
PE
2864 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2865
44f730c8
PE
2866 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2867
fe75f926
PE
2868 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2869 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2870
ffa8c828
PE
2871 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2872 This avoids undefined behavior on integer overflow, and is a bit
2873 more convenient anyway since it is compared to a size_t variable.
2874
c5101a77
PE
2875 Variadic C functions now count arguments with size_t, not int.
2876 This avoids an unnecessary limitation on 64-bit machines, which
2877 caused (substring ...) to crash on large vectors (Bug#8344).
2878 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2879 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2880 All variadic functions and their callers changed accordingly.
c5101a77
PE
2881 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2882 * data.c (arith_driver, float_arith_driver): Likewise.
2883 * editfns.c (general_insert_function): Likewise.
2884 * eval.c (struct backtrace.nargs, interactive_p)
2885 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2886 (funcall_lambda, mark_backtrace): Likewise.
2887 * fns.c (concat): Likewise.
2888 * frame.c (x_set_frame_parameters): Likewise.
2889 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2890 0 if not found, not -1. All callers changed.
2891
dd3f25f7
PE
2892 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2893 (stack_copy_size): Now size_t, not int.
2894 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2895
461c2ab9
JB
28962011-03-28 Juanma Barranquero <lekktu@gmail.com>
2897
2898 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2899 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2900 All callers changed.
2901
2902 * lisp.h (multibyte_char_to_unibyte):
2903 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2904 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2905 * character.h (CHAR_TO_BYTE8):
2906 * cmds.c (internal_self_insert):
2907 * editfns.c (general_insert_function):
2908 * keymap.c (push_key_description):
2909 * search.c (Freplace_match):
2910 * xdisp.c (message_dolog, set_message_1): All callers changed.
2911
f6d62986
SM
29122011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2913
2914 * keyboard.c (safe_run_hook_funcall): New function.
2915 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2916 don't set the hook to nil, but remove the offending function instead.
2917 (Qcommand_hook_internal): Remove, unused.
2918 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2919 Vcommand_hook_internal.
2920
2921 * eval.c (enum run_hooks_condition): Remove.
2922 (funcall_nil, funcall_not): New functions.
2923 (run_hook_with_args): Call each function through a `funcall' argument.
2924 Remove `cond' argument, now redundant.
2925 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2926 (Frun_hook_with_args_until_failure): Adjust accordingly.
2927 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2928
1db5b1ad
JB
29292011-03-28 Juanma Barranquero <lekktu@gmail.com>
2930
2931 * dispextern.h (string_buffer_position): Remove declaration.
2932
2933 * print.c (strout): Remove parameter `multibyte', unused since
2934 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2935
2936 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2937 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2938 All callers changed.
2939
2940 * w32.c (_wsa_errlist): Use braces for struct initializers.
2941
2942 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2943 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2944 All callers changed.
2945 (string_buffer_position): Likewise. Also, make static (it's never
2946 used outside xdisp.c).
2947 (cursor_row_p): Remove parameter `w', unused since
2948 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2949 (decode_mode_spec): Remove parameter `precision', introduced during
2950 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2951 All callers changed.
2952
5ffb62aa
JD
29532011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2954
2955 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2956
461c2ab9 29572011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2958
2959 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2960 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2961 (ns_update_auto_hide_menu_bar): New functions.
2962 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2963 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2964 ns_constrain_all_frames.
2965 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2966 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2967
5c380ffb
JD
29682011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2969
2970 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2971
9af30bdf
GM
29722011-03-27 Glenn Morris <rgm@gnu.org>
2973
2974 * syssignal.h: Replace RETSIGTYPE with void.
2975 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2976 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2977 Replace SIGTYPE with void everywhere.
2978 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2979 * s/template.h (SIGTYPE): Remove commented out definition.
2980
e2abce01
JB
29812011-03-26 Eli Zaretskii <eliz@gnu.org>
2982
2983 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2984 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2985
f868cd8a
JB
29862011-03-26 Juanma Barranquero <lekktu@gmail.com>
2987
59eb0929
JB
2988 * w32.c (read_unc_volume): Use parameter `henum', instead of
2989 global variable `wget_enum_handle'.
2990
2991 * keymap.c (describe_vector): Remove parameters `indices' and
2992 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2993 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2994
f868cd8a
JB
2995 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2996
2997 * keyboard.c (timer_check): Remove parameter `do_it_now',
2998 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2999 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3000 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3001
3002 * keyboard.c (read_char):
3003 * w32menu.c (w32_menu_display_help):
3004 * xmenu.c (show_help_event, menu_help_callback):
3005 Adjust calls to `show_help_echo'.
3006
3007 * gtkutil.c (xg_maybe_add_timer):
3008 * keyboard.c (readable_events):
3009 * process.c (wait_reading_process_output):
3010 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3011
3012 * insdel.c (adjust_markers_gap_motion):
3013 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3014 (gap_left, gap_right): Don't call it.
3015
2ecf6fdb
CY
30162011-03-25 Chong Yidong <cyd@stupidchicken.com>
3017
3018 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3019 incurred during fontification.
3020
6b1f9ba4
JB
30212011-03-25 Juanma Barranquero <lekktu@gmail.com>
3022
3023 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3024 (DEFVAR_PER_BUFFER): Don't pass it.
3025
3026 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3027 (scrolling_window): Don't pass it.
3028
0f4a96b5
JB
30292011-03-25 Juanma Barranquero <lekktu@gmail.com>
3030
3031 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3032
3033 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3034 and `suffix'.
3035 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3036 of variables specific to SELinux and computation of `encoded_absname'.
3037
3038 * image.c (XPutPixel): Remove unused variable `height'.
3039
3040 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3041
3042 * unexw32.c (get_section_info): Remove unused variable `section'.
3043
3044 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3045 (system_process_attributes): Remove unused variable `sess'.
3046 (sys_read): Remove unused variable `err'.
3047
3048 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3049 (w32_wnd_proc): Remove unused variable `isdead'.
3050 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3051 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3052 (x_create_tip_frame): Remove unused variable `tem'.
3053
3054 * w32inevt.c (w32_console_read_socket):
3055 Remove unused variable `no_events'.
3056
3057 * w32term.c (x_draw_composite_glyph_string_foreground):
3058 Remove unused variable `width'.
3059
1149507c
JB
30602011-03-24 Juanma Barranquero <lekktu@gmail.com>
3061
3062 * w32term.c (x_set_glyph_string_clipping):
3063 Don't pass uninitialized region to CombineRgn.
3064
9c88f339
JB
30652011-03-23 Juanma Barranquero <lekktu@gmail.com>
3066
3067 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3068 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3069 (Fx_close_connection): Remove unused variable `i'.
3070
3071 * w32font.c (w32font_draw): Return number of glyphs.
3072 (w32font_open_internal): Remove unused variable `i'.
3073 (w32font_driver): Add missing initializer.
3074
3075 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3076 (fill_in_menu): Remove unused variable `items_added'.
3077
3078 * w32term.c (last_mouse_press_frame): Remove static global variable.
3079 (w32_clip_to_row): Remove unused variable `f'.
3080 (x_delete_terminal): Remove unused variable `i'.
3081
3082 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3083 (NOTHING): Remove unused static global variable.
3084 (uniscribe_check_otf): Remove unused variable `table'.
3085 (uniscribe_font_driver): Add missing initializers.
3086
dee091a3
JD
30872011-03-23 Julien Danjou <julien@danjou.info>
3088
3089 * term.c (Fsuspend_tty, Fresume_tty):
3090 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3091 * window.c (temp_output_buffer_show):
3092 * insdel.c (signal_before_change):
3093 * frame.c (Fhandle_switch_frame):
3094 * fileio.c (Fdo_auto_save):
3095 * emacs.c (Fkill_emacs):
3096 * editfns.c (save_excursion_restore):
3097 * cmds.c (internal_self_insert):
3098 * callint.c (Fcall_interactively):
3099 * buffer.c (Fkill_all_local_variables):
3100 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3101 Use Frun_hooks.
0f4a96b5 3102 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3103 unconditionnaly since it does the check itself.
3104
2c520ab5 31052011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3106
c9c49752
PE
3107 Fix more problems found by GCC 4.5.2's static checks.
3108
8abc3f12
PE
3109 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3110 the first time through the loop, since we know p0 < p1 then.
3111 This also avoids a gcc -Wstrict-overflow warning.
3112
a2d26660
PE
3113 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3114 leading to a memory leak, possible in functions like
3115 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3116 of objects (Bug#8318).
a2d26660 3117
916c72e9
PE
3118 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3119 that could (at least in theory) be that large.
3120
19ab8a18
PE
3121 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3122 This is less likely to overflow, and avoids undefined behavior if
3123 overflow does occur. All callers changed. Use strtoul to scan
3124 for the unsigned long integer.
b7cbbd6f
PE
3125 (pint2hrstr): Simplify and tune code slightly.
3126 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3127
f0641eff
PE
3128 * scroll.c (do_scrolling): Work around GCC bug 48228.
3129 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3130
7f650bb9
PE
3131 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3132 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3133 (validate_x_resource_name): Simplify count usage.
3134 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3135
37dd57d1
PE
3136 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3137 fail (Bug#8306).
81e56e61 3138
699979fc 3139 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3140
401bf9b4
PE
3141 * process.c (Fmake_network_process): Use socklen_t, not int,
3142 where POSIX says socklen_t is required in portable programs.
3143 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3144 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3145 (Fmake_network_process, server_accept_connection):
3146 (wait_reading_process_output, read_process_output):
3147 Likewise.
3148
b93aacde
PE
3149 * process.c: Rename or move locals to avoid shadowing.
3150 (list_processes_1, Fmake_network_process):
3151 (read_process_output_error_handler, exec_sentinel_error_handler):
3152 Rename or move locals.
4dc343ee 3153 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3154 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3155 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3156 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3157 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3158
af8a867c 3159 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3160 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3161 Include tparam.h instead, since it declares them.
af8a867c
PE
3162 * cm.h (PC): Remove extern decl; tparam.h now does this.
3163 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3164 * terminfo.c: Include tparam.h, to check interfaces.
3165 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3166 (tparam): Adjust signature to match interface in tparam.h;
3167 this removes some undefined behavior. Check that outstring and len
3168 are zero, which they always are with Emacs.
3169 * tparam.h (PC, BC, UP): New extern decls.
3170
0248044d 3171 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3172 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3173
8ff096c1 3174 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3175 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3176 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3177 (ftfont_list): Remove unused local.
49eaafba
PE
3178 (get_adstyle_property, ftfont_pattern_entity):
3179 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3180 Rename locals to avoid shadowing.
8ff096c1 3181
e2be39f6
PE
3182 * xfont.c (xfont_list_family): Mark var as initialized.
3183
c9735e30
PE
3184 * xml.c (make_dom): Now static.
3185
8f5201ae
PE
3186 * composite.c (composition_compute_stop_pos): Rename local to
3187 avoid shadowing.
b246f932
PE
3188 (composition_reseat_it): Remove unused locals.
3189 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3190 (composition_update_it): Mark var as initialized.
11b61122
PE
3191 (find_automatic_composition): Mark vars as initialized,
3192 with a FIXME (Bug#8290).
8f5201ae 3193
760fbc2c
PE
3194 character.h: Rename locals to avoid shadowing.
3195 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3196 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3197 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3198 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3199 to avoid shadowing.
3200
ff08eb85
PE
3201 * textprop.c (property_change_between_p): Remove; unused.
3202
fc7bf025
PE
3203 * intervals.c (interval_start_pos): Now static.
3204
235d7abc
PE
3205 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3206
44f230aa
SM
3207 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3208 Rename locals to avoid shadowing.
3e7d6594 3209
50060332
PE
3210 * sound.c (wav_play, au_play, Fplay_sound_internal):
3211 Fix pointer signedness.
d01f234b 3212 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3213 (wav_play): Initialize a variable to 0, to prevent undefined
3214 behavior (Bug#8278).
50060332 3215
c4fc4e30
PE
3216 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3217
918436ed
PE
3218 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3219
c939f91b
PE
3220 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3221 clobbering (Bug#8298).
b9c7f648
PE
3222 * sysdep.c (sys_subshell): Likewise.
3223 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3224
6bd8c144
PE
3225 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3226 This should get cleaned up, so that child_setup has the
3227 same signature on all platforms.
3228
7710357c 3229 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3230 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3231
c59da222
CY
32322011-03-22 Chong Yidong <cyd@stupidchicken.com>
3233
3234 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3235 not to be necessary, and produces flickering.
3236
66b87493
GM
32372011-03-20 Glenn Morris <rgm@gnu.org>
3238
3239 * config.in: Remove file.
3240
45b6f6d5
JB
32412011-03-20 Juanma Barranquero <lekktu@gmail.com>
3242
3243 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3244 are now in src/globals.h.
3245 (syms_of_minibuf): Remove spurious & from previous change.
3246
3ec03f7e
LL
32472011-03-20 Leo <sdl.web@gmail.com>
3248
3249 * minibuf.c (completing-read-function): New variable.
3250 (completing-read-default): Rename from completing-read.
3251 (completing-read): Call completing-read-function.
3252
b14e3e21
CY
32532011-03-19 Juanma Barranquero <lekktu@gmail.com>
3254
3255 * xfaces.c (Fx_load_color_file):
3256 Read color file from absolute filename (bug#8250).
3257
f2b726e6
JB
32582011-03-19 Juanma Barranquero <lekktu@gmail.com>
3259
3260 * makefile.w32-in: Update dependencies.
3261
09f6ff02
EZ
32622011-03-17 Eli Zaretskii <eliz@gnu.org>
3263
3264 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3265
29a6015a
PE
32662011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3267
a3a6c54e
PE
3268 Fix more problems found by GCC 4.5.2's static checks.
3269
b766f867
PE
3270 * process.c (make_serial_process_unwind, send_process_trap):
3271 (sigchld_handler): Now static.
3272
be02381c
PE
3273 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3274 That way, the code declares only the vars that it needs.
3275 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3276 * s/cygwin.h (PTY_ITERATION): Likewise.
3277 * s/darwin.h (PTY_ITERATION): Likewise.
3278 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3279
57048744
PE
3280 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3281 * process.c (allocate_pty): Don't declare stb unless it's needed.
3282
7914961c 3283 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3284 (CONSTANTLIM): Remove; unused.
3285 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3286 Define only if needed.
7914961c 3287
b3967b18
PE
3288 * unexelf.c (unexec): Name an expression,
3289 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3290 Use a different way to cause a compilation error if anyone uses
3291 n rather than nn, a way that does not involve shadowing.
73366a00 3292 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3293
29a6015a
PE
3294 * deps.mk (unexalpha.o): Remove; unused.
3295
43cfc33e 3296 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3297 * unexec.h: New file.
ce701a33
PE
3298 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3299 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3300 Depend on unexec.h.
3301 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3302 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3303 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3304 Change as necessary to match prototype in unexec.h.
ce701a33 3305
01f44d5a
PE
3306 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3307 shadowing.
4f63c6bb 3308 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3309
a6670b0b
PE
3310 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3311 Rename locals to avoid shadowing.
3312
cef2010d 3313 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3314 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3315
d4d7173a
PE
3316 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3317
f08b802a
PE
3318 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3319 warning when compiling print.c.
3320
3ddb0639
PE
3321 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3322 instead of using an uninitialized var.
5ad03b97 3323 (font_sort_entities): Mark var as initialized.
3ddb0639 3324
170a2692
PE
3325 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3326
e663c700
PE
3327 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3328 pointers to constants.
89bc529a 3329 (font_parse_fcname): Remove unused vars.
7b81e2d0 3330 (font_delete_unmatched): Now static.
ea838e10 3331 (font_get_spec): Remove; unused.
13a547c6
PE
3332 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3333 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3334 Rename or move locals to avoid shadowing.
e663c700 3335
2a80c887 3336 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3337 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3338
1384fa33 3339 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3340 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3341
8b2c52e9
PE
3342 * alloc.c (mark_backtrace): Move decl from here ...
3343 * lisp.h: ... to here, so that it can be checked.
3344
475545b5 3345 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3346 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3347 (lisp_indirect_variable): Name an expression,
3348 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3349 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3350
b1349114 3351 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3352 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3353 Use const pointer when appropriate.
b1349114 3354
a2928364
PE
3355 * lisp.h (get_system_name, get_operating_system_release):
3356 Move decls here, to check interfaces.
3357 * process.c (get_operating_system_release): Move decl to lisp.h.
3358 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3359 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3360 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3361 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3362 (Fformat_time_string, Fencode_time, Finsert_char):
3363 (Ftranslate_region_internal, Fformat):
3364 Rename or remove local vars to avoid shadowing.
9710023e 3365 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3366
a415e694
PE
3367 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3368 avoid shadowing.
3369
8ef4622d
PE
3370 * lisp.h (eassert): Check that the argument compiles, even if
3371 ENABLE_CHECKING is not defined.
3372
946f9a5b
PE
3373 * data.c (Findirect_variable): Name an expression, to avoid
3374 gcc -Wbad-function-cast warning.
112396d6 3375 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3376 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3377 (Fmake_variable_buffer_local, Fmake_local_variable):
3378 Mark variables as initialized.
52746918 3379 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3380
e5aab7e7 3381 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3382 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3383 Rename locals to avoid shadowing.
dff45157
PE
3384 (mark_stack): Move local variables into the #ifdef region where
3385 they're used.
7bc26fdb
PE
3386 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3387 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3388 needed otherwise.
3389 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3390 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3391 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3392
e5aab7e7
PE
3393 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3394 avoids undefined behavior in theory.
3395
4da60324
PE
3396 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3397
88043301
PE
3398 Use functions, not macros, for up- and down-casing (Bug#8254).
3399 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3400 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3401 to use the following functions instead of these macros.
3402 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3403 EMACS_INT, since callers assume the returned value fits in int.
3404 (upcase1): Likewise, for UPCASE_TABLE.
3405 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3406 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3407 the race-condition problem in the old DOWNCASE.
88043301 3408
19ed5445
PE
3409 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3410 Rename locals to avoid shadowing.
3411 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3412 (regex_compile, re_search_2, re_match_2_internal):
3413 Remove unused local vars.
952db0d7
PE
3414 (FREE_VAR): Rewrite so as not to use empty "else",
3415 which gcc can warn about.
da053e48 3416 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3417 (RETALLOC_IF): Define only if needed.
3418 (WORDCHAR_P): Likewise. This one is never needed, but is used
3419 only in a comment talking about a compiler bug, so put inside
3420 the #if 0 of that comment.
3421 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3422 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3423 Remove; unused.
19ed5445 3424
1f3561e4 3425 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3426 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3427 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3428
ded6f8f7
PE
3429 * search.c (simple_search): Remove unused var.
3430
dbd37a95
PE
3431 * dired.c (compile_pattern): Move decl from here ...
3432 * lisp.h: ... to here, so that it can be checked.
3433 (struct re_registers): New forward decl.
3434
7e47afad
PE
3435 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3436
85f24f61
PE
3437 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3438 All uses changed.
3439 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3440 Rename locals to avoid shadowing.
5671df8f 3441 (Fvertical_motion): Mark locals as initialized.
85f24f61 3442
181aa2be 3443 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3444 (casify_region): Mark local as initialized.
181aa2be 3445
930d429c
PE
3446 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3447
7082eac6
PE
3448 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3449 New macros, so that the caller can use some names other than
3450 gcpro1, gcpro2, etc.
3451 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3452 of the new macros.
3453 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3454 argument, for consistency with GCPRO2_VAR, etc: it is now the
3455 prefix of the variable, not the variable itself. All uses
3456 changed.
38b2c076
PE
3457 * dired.c (directory_files_internal, file_name_completion):
3458 Rename locals to avoid shadowing.
3459
15206ed9
PE
3460 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3461 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3462 dired.c's scmp function, had undefined behavior.
3463 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3464 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3465 * buffer.h: ... to here, because these macros use current_buffer,
3466 and the new implementation with inline functions needs to have
3467 current_buffer in scope now, rather than later when the macros
3468 are used.
3469 (downcase, upcase1): New static inline functions.
3470 (DOWNCASE, UPCASE1): Reimplement using these functions.
3471 This avoids undefined behavior in expressions like
3472 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3473 from race conditions in accessing the global variables
3474 case_temp1 and case_temp2.
3475 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3476 * lisp.h (case_temp1, case_temp2): Remove their decls.
3477 * character.h (ASCII_CHAR_P): Move from here ...
3478 * lisp.h: ... to here, so that the inline functions mentioned
3479 above can use them.
3480
4a6bea26
PE
3481 * dired.c (directory_files_internal_unwind): Now static.
3482
f14b7e14
PE
3483 * fileio.c (file_name_as_directory, directory_file_name):
3484 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3485 Now static.
2893f146
PE
3486 (file_name_as_directory): Use const pointers when appropriate.
3487 (Fexpand_file_name): Likewise. In particular, newdir might
3488 point at constant storage, so make it a const pointer.
fd4ead52 3489 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3490 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3491 signedness issues.
f839df0c
PE
3492 (Fset_file_times, Finsert_file_contents, auto_save_error):
3493 Rename locals to avoid shadowing.
f14b7e14 3494
5716756e 3495 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3496 (Ftry_completion, Fall_completions): Rename or remove locals
3497 to avoid shadowing.
5716756e 3498
b4c3046a
PE
3499 * marker.c (bytepos_to_charpos): Remove; unused.
3500
b45db522
PE
3501 * lisp.h (verify_bytepos, count_markers): New decls,
3502 so that gcc does not warn that these functions aren't declared.
3503
85876d07
PE
3504 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3505 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3506 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3507 (copy_text): Remove unused local var.
85876d07 3508
03d78a21 3509 * filelock.c (within_one_second): Now static.
b3dd38ab 3510 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3511
5df8f01b
PE
3512 * buffer.c (fix_overlays_before): Mark locals as initialized.
3513 (fix_start_end_in_overlays): Likewise. This function should be
3514 simplified by using pointers-to-pointers, but that's a different
3515 matter.
b1d876f1 3516 (switch_to_buffer_1): Now static.
8f54f30a
PE
3517 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3518 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3519
a70072c9 3520 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3521 Fix pointer signedness issue.
edced198
PE
3522 (sys_subshell): Mark local as volatile if checking for lint,
3523 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3524 (MAXPATHLEN): Define only if needed.
a70072c9 3525
a0977c44
PE
3526 * process.c (serial_open, serial_configure): Move decls from here ...
3527 * systty.h: ... to here, so that they can be checked.
3528
a884fdcc
PE
3529 * fns.c (get_random, seed_random): Move extern decls from here ...
3530 * lisp.h: ... to here, so that they can be checked.
3531
604efe86 3532 * sysdep.c (reset_io): Now static.
b8950c94 3533 (wait_for_termination_signal): Remove; unused.
604efe86 3534
38fc62d9
PE
3535 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3536 (copy_keymap_item, append_key, push_text_char_description):
3537 Now static.
1004a21a 3538 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3539 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3540 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3541 (describe_map_tree):
3542 Rename locals to avoid shadowing.
38fc62d9 3543
2f2650da
PE
3544 * keyboard.c: Declare functions static if they are not used elsewhere.
3545 (echo_char, echo_dash, cmd_error, top_level_2):
3546 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3547 (read_char, kbd_buffer_get_event, make_lispy_position):
3548 (make_lispy_event, make_lispy_movement, apply_modifiers):
3549 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3550 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3551 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3552 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3553 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3554
a053e86c 3555 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3556 (mark_kboards): Move decl here ...
3557 * alloc.c (mark_kboards): ... from here.
a053e86c 3558
4752793e
PE
3559 * lisp.h (force_auto_save_soon): New decl.
3560
74f10ca7 3561 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3562 (DEFINE_DUMMY_FUNCTION): New macro.
3563 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3564 Use it.
c03cd23f
PE
3565 (main): Add casts to avoid warnings
3566 if GCC considers string literals to be constants.
74f10ca7 3567
022e70d4
PE
3568 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3569
59d6fe83
PE
3570 * dbusbind.c: Pointer signedness fixes.
3571 (xd_signature, xd_append_arg, xd_initialize):
3572 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3573 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3574 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3575 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3576
78320123
PE
3577 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3578 if GCC considers string literals to be constants.
49cebcca 3579 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3580
35ac2a97
SM
35812011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3582
fb103ca9
SM
3583 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3584 (print_preprocess, print_object): New macro to fix last change.
3585
35ac2a97
SM
3586 * print.c (print_preprocess): Don't forget font objects.
3587
62973b41
JB
35882011-03-16 Juanma Barranquero <lekktu@gmail.com>
3589
3590 * emacs.c (USAGE3): Doc fixes.
3591
0e48bb22
AS
35922011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3593
3594 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3595 structure.
3596
7684e57b
JB
35972011-03-14 Juanma Barranquero <lekktu@gmail.com>
3598
3599 * lisp.h (VWindow_system, Qfile_name_history):
3600 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3601 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3602 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3603
3604 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3605 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3606
3607 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3608 * w32console.c (detect_input_pending, read_input_pending)
3609 (encode_terminal_code):
3610 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3611 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3612 (w32_system_caret_y, Qfile_name_history):
3613 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3614 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3615 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3616 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3617 * w32proc.c (Qlocal, report_file_error):
3618 * w32term.c (Vwindow_system, updating_frame):
3619 * w32uniscribe.c (initialized, uniscribe_font_driver):
3620 Remove unneeded extern declarations.
3621
2aa46d6c
CY
36222011-03-14 Chong Yidong <cyd@stupidchicken.com>
3623
c96bbc66 3624 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3625
cffc6f3b
CY
36262011-03-13 Chong Yidong <cyd@stupidchicken.com>
3627
3628 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3629 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3630 These macros can no longer be used for assignment.
3631
44f230aa
SM
3632 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3633 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3634 (record_buffer_markers, fetch_buffer_markers): New functions for
3635 recording and fetching special buffer markers.
3636 (set_buffer_internal_1, set_buffer_temp): Use them.
3637
3638 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3639
3640 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3641
3642 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3643 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3644
3645 * xdisp.c (hscroll_window_tree):
3646 (reconsider_clip_changes): Use PT instead of BUF_PT.
3647
d251f04b
EZ
36482011-03-13 Eli Zaretskii <eliz@gnu.org>
3649
3650 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3651 $(EMACS_ROOT)/lib/intprops.h.
3652
f0c77cd1
PE
36532011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3654
3eca4629
PE
3655 Fix more problems found by GCC 4.5.2's static checks.
3656
7c86ee98
PE
3657 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3658 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3659 (xg_free_frame_widgets): Make it clear that a local variable is
3660 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3661 (gdk_window_get_screen): Make it clear that this macro is needed
3662 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3663 (int_gtk_range_get_value): New function, which avoids a diagnostic
3664 from gcc -Wbad-function-cast.
3665 (xg_set_toolkit_scroll_bar_thumb): Use it.
3666 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3667 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3668 (get_utf8_string, xg_get_file_with_chooser):
3669 Rename locals to avoid shadowing.
3670 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3671
41729b81
PE
3672 * xgselect.c (xg_select): Remove unused var.
3673
f0c77cd1
PE
3674 * image.c (four_corners_best): Mark locals as initialized.
3675 (gif_load): Initialize transparent_p to zero (Bug#8238).
3676 Mark another local as initialized.
ec6cf4c6 3677 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3678
ce0ad53d 3679 * image.c (clear_image_cache): Now static.
d5d5a617 3680 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3681 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3682 (x_edge_detection): Remove unnecessary cast that
3683 gcc -Wbad-function-cast diagnoses.
2037898d 3684 (gif_load): Fix pointer signedness.
6ae141d6
PE
3685 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3686 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3687
33383987 36882011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3689
d32df629
PE
3690 Improve quality of tests for time stamp overflow.
3691 For example, without this patch (encode-time 0 0 0 1 1
3692 1152921504606846976) returns the obviously-bogus value (-948597
3693 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3694 reports time overflow. See
3695 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3696 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3697 * editfns.c: Include limits.h and intprops.h.
3698 (TIME_T_MIN, TIME_T_MAX): New macros.
3699 (time_overflow): Move earlier, to before first use.
3700 (hi_time, lo_time): New functions, for an accurate test for
3701 out-of-range times.
3702 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3703 (Fget_internal_run_time): Don't assume time_t fits in int.
3704 (make_time): Use list2 instead of Fcons twice.
3705 (Fdecode_time): More accurate test for out-of-range times.
3706 (check_tm_member): New function.
3707 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3708 (lisp_time_argument): Don't rely on undefined left-shift and
3709 right-shift behavior when checking for time stamp overflow.
8be6f318 3710
fe31d94c
PE
3711 * editfns.c (time_overflow): New function, refactoring common code.
3712 (Fformat_time_string, Fdecode_time, Fencode_time):
3713 (Fcurrent_time_string): Use it.
3714
8be6f318
PE
3715 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3716 * dired.c (make_time): Move to ...
3717 * editfns.c (make_time): ... here.
3718 * systime.h: Note the move.
3719
09d9db2c 37202011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3721
126bc0dc
YM
3722 * fringe.c (update_window_fringes): Remove unused variables.
3723
c47cbdfd
YM
3724 * unexmacosx.c (copy_data_segment): Also copy __got section.
3725 (Bug#8223)
3726
7ac80be9
EZ
37272011-03-12 Eli Zaretskii <eliz@gnu.org>
3728
c96bbc66 3729 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3730 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3731 Constify `char *' arguments and their references according to
3732 prototypes in tparam.h.
3733
ecb0f94d 3734 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3735
7ac80be9
EZ
3736 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3737 Adapt all references accordingly.
3738
3739 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3740
ef1fd07e
TT
37412011-03-11 Tom Tromey <tromey@redhat.com>
3742
3743 * buffer.c (syms_of_buffer): Remove obsolete comment.
3744
7ef4b50c
EZ
37452011-03-11 Eli Zaretskii <eliz@gnu.org>
3746
3747 * termhooks.h (encode_terminal_code): Declare prototype.
3748
3749 * msdos.c (encode_terminal_code): Don't declare prototype.
3750
3751 * term.c (encode_terminal_code): Now external again, used by
3752 w32console.c and msdos.c.
3753
44f230aa
SM
3754 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3755 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3756
4b1ec863 37572011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3758
1714f52b 3759 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3760
4b1ec863
PE
3761 * fringe.c (update_window_fringes): Mark locals as initialized
3762 (Bug#8227).
3763 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3764
524c7aa6
PE
3765 * alloc.c (mark_fringe_data): Move decl from here ...
3766 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3767 to check its interface.
3768 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3769
a5c0af81 3770 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3771 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3772 (fontset_font): Mark local as initialized.
a9a06e0b 3773 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3774
b4716021
PE
3775 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3776
811e9bac 3777 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3778 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3779 (x_own_selection, Fx_disown_selection_internal): Rename locals
3780 to avoid shadowing.
3781 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3782
7e3ab302
PE
3783 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3784 so that the caller can use some name other than gcpro1.
3785 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3786 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3787 (Fx_backspace_delete_keys_p):
3788 Use them to avoid shadowing, and rename vars to avoid shadowing.
3789 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3790 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3791 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3792 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3793 Remove unused locals.
7e3ab302
PE
3794 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3795 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3796 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3797 macros.
f78faa98 3798
e2b13473
PE
3799 * xterm.h (x_mouse_leave): New decl.
3800
77f23912
PE
3801 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3802 Remove unused functions.
cdf4ba58
PE
3803 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3804 (x_calc_absolute_position): Now static.
7411c686 3805 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3806 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3807 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3808 unless they are used.
38d0b34a
PE
3809 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3810 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3811 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3812 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3813 (x_error_catcher, x_connection_closed, x_error_handler):
3814 (x_error_quitter, xembed_send_message, x_iconify_frame):
3815 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3816 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3817 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3818
44f230aa
SM
3819 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3820 Rename or move locals to avoid shadowing.
6b463e58 3821 (tty_defined_color, merge_face_heights): Now static.
5967d051 3822 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3823 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3824 does not deduce is never used uninitialized.
73719eba
PE
3825 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3826 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3827
426994c3 3828 * terminal.c (store_terminal_param): Now static.
5489860b 3829
032f1620 3830 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3831 (set_frame_menubar): Remove unused local.
d4323972 3832 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3833 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3834 since they might point to immutable storage.
281585b0
PE
3835 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3836 since it's unused otherwise.
032f1620 3837
367c19e5 3838 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3839 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3840 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3841 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3842 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3843 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3844 does not deduce are never used uninitialized.
70739cbe 3845
07b48fa9
PE
3846 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3847
8868a238 3848 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3849 * window.c (window_loop, size_window):
3850 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3851
7e5cf297 3852 * window.c (display_buffer): Now static.
d6550a9f
PE
3853 (size_window): Mark variables that gcc -Wuninitialized
3854 does not deduce are never used uninitialized.
a586633d
PE
3855 * window.h (check_all_windows): New decl, to forestall
3856 gcc -Wmissing-prototypes diagnostic.
5b555da1 3857 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3858
f6095868
PE
3859 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3860 shadowing.
3861 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3862 Include <limits.h>.
3863 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3864 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3865 (load_charset_map): Mark variables that gcc -Wuninitialized
3866 does not deduce are never used uninitialized.
53df7c11 3867 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3868
f38b440c
PE
3869 * coding.c (coding_set_source, coding_set_destination):
3870 Use "else { /* comment */ }" rather than "else /* comment */;"
3871 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3872 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3873 a block, when the outer 'i' will do.
3874 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3875 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3876 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3877 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3878 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3879 Rename locals to avoid shadowing.
3880 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3881 * coding.c (emacs_mule_char, encode_invocation_designation):
3882 Now static, since they're not used elsewhere.
413bb2db 3883 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3884 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3885 (decode_coding_emacs_mule): Mark variables that gcc
3886 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3887 (detect_coding_iso_2022): Initialize a local variable that might
3888 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3889 this initialization is needed. (Bug#8211)
5f58e762
PE
3890 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3891 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3892 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3893 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3894 Remove unused macros.
f38b440c 3895
232b38b9 3896 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3897 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3898 * character.c (string_count_byte8): Likewise.
232b38b9 3899
fb90da1b
PE
3900 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3901 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3902
fb93dbc2
PE
3903 * chartab.c (copy_sub_char_table): Now static, since it's not used
3904 elsewhere.
5c156ace
PE
3905 (sub_char_table_ref_and_range, char_table_ref_and_range):
3906 Rename locals to avoid shadowing.
bbcd0949 3907 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3908
7d3b3862 3909 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3910 (BIDI_BOB): Remove unused macro.
7d3b3862 3911
6be7d3da
PE
3912 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3913 deduce are never used uninitialized.
c2ed9c8b 3914 * term.c (encode_terminal_code): Likewise.
6be7d3da 3915
75f8807f 3916 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3917
50938595
PE
3918 * tparam.h: New file.
3919 * term.c, tparam.h: Include it.
3920 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3921 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3922 Move these decls to tparam.h, and make them agree with what
3923 is actually in tparam.c. The previous trick of using incompatible
3924 decls in different modules does not conform to the C standard.
3925 All callers of tparam changed to use tparam's actual API.
3926 * tparam.c (tparam1, tparam, tgoto):
3927 Use const pointers where appropriate.
3928
fbceeba2
PE
3929 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3930 * cm.h (struct cm): Likewise.
3931 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3932 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3933 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3934 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3935 (turn_on_face, init_tty): Likewise.
3936 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3937
7f3f1250
PE
3938 * term.c (term_mouse_position): Rename local to avoid shadowing.
3939
e6ca6543
PE
3940 * alloc.c (mark_ttys): Move decl from here ...
3941 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3942
c40f8d15
AS
39432011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3944
3945 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3946
cfe0661d
JB
39472011-03-09 Juanma Barranquero <lekktu@gmail.com>
3948
3949 * search.c (compile_pattern_1): Remove argument regp, unused since
3950 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3951 (compile_pattern): Don't pass it.
3952
0afb4571
J
39532011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3954
3955 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3956 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3957 for ! HAVE_GTK3.
3958 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3959
3960 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3961
3962 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3963 gdk_window_get_screen, gdk_window_get_geometry,
3964 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3965 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3966 (xg_get_pixbuf_from_pixmap): New function.
3967 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3968 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3969 Call xg_get_pixbuf_from_pixmap instead of
3970 gdk_pixbuf_get_from_drawable.
3971 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3972 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3973 (xg_check_special_colors): Use GtkStyleContext and its functions
3974 for HAVE_GTK3.
3975 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3976 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3977 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3978 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3979 Call gtk_widget_get_preferred_size.
0afb4571
J
3980 (xg_frame_resized): gdk_window_get_geometry only takes 5
3981 parameters.
44f230aa
SM
3982 (xg_win_to_widget, xg_event_is_for_menubar):
3983 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3984 (xg_set_widget_bg): New function.
3985 (delete_cb): New function.
895009e1 3986 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3987 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3988 (xg_set_background_color): Call xg_set_widget_bg.
3989 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3990 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3991 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3992 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3993 if ! HAVE_GTK3.
3994 (update_frame_tool_bar): Call gtk_widget_hide.
3995 (xg_initialize): Use GDK_KEY_g.
3996
3997 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3998 if ! HAVE_GTK3
3999 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4000
4001 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4002 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4003 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4004
1c2cc4ef
JB
40052011-03-08 Juanma Barranquero <lekktu@gmail.com>
4006
4007 * w32xfns.c (select_palette): Check success of RealizePalette against
4008 GDI_ERROR, not zero.
4009
33383987 4010See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4011
4012;; Local Variables:
4013;; coding: utf-8
aac0c6e3
MR
4014;; End:
4015
33383987 4016 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4017
4018 This file is part of GNU Emacs.
4019
4020 GNU Emacs is free software: you can redistribute it and/or modify
4021 it under the terms of the GNU General Public License as published by
4022 the Free Software Foundation, either version 3 of the License, or
4023 (at your option) any later version.
4024
4025 GNU Emacs is distributed in the hope that it will be useful,
4026 but WITHOUT ANY WARRANTY; without even the implied warranty of
4027 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4028 GNU General Public License for more details.
4029
4030 You should have received a copy of the GNU General Public License
4031 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.