Fix copyrights, licenses, etc in new Org files.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
d1410150
EZ
12011-08-06 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
4 display property strides EOL and includes a newline, as in
5 longlines-mode. (Bug#9254)
75b771e4
EZ
6 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8
9 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
10 is non-zero, even if the data buffer is NULL. Fixes a crash in
11 vertical-motion with longlines-mode. (Bug#9254)
12
35928349
EZ
132011-08-05 Eli Zaretskii <eliz@gnu.org>
14
ec7cc85b
EZ
15 * bidi.c <bidi_cache_total_alloc>: Now static.
16 (bidi_initialize): Initialize bidi_cache_total_alloc.
17
35928349
EZ
18 *xdisp.c (display_line): Release buffer allocated for shelved bidi
19 cache. (Bug#9221)
20
21 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
22 amount allocated this far in `bidi_cache_total_alloc'.
23 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
24 non-zero, only free the data buffer without restoring the cache
25 contents. All callers changed.
26
27 * dispextern.h (bidi_unshelve_cache): Update prototype.
28
29 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
30 (move_it_in_display_line, move_it_to)
31 (move_it_vertically_backward, move_it_by_lines): Replace the call
32 to xfree to an equivalent call to bidi_unshelve_cache.
33 (move_it_in_display_line_to): Fix logic of returning
412b6358 34 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 35
e2e2423b
EZ
362011-08-05 Eli Zaretskii <eliz@gnu.org>
37
38 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
39 came from a string character with a `cursor' property. (Bug#9229)
40
ae9e757a
JD
412011-08-04 Jan Djärv <jan.h.d@swipnet.se>
42
43 * Makefile.in (LIB_PTHREAD): New variable.
44 (LIBES): Add LIB_PTHREAD (Bug#9216).
45
46 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
47 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
48
213bd7f2
AS
492011-08-04 Andreas Schwab <schwab@linux-m68k.org>
50
51 * regex.c (re_iswctype): Remove some redundant boolean
52 conversions.
53
99aaf75f
JD
542011-08-04 Jan Djärv <jan.h.d@swipnet.se>
55
56 * xterm.c (x_find_topmost_parent): New function.
57 (x_set_frame_alpha): Find topmost parent window with
58 x_find_topmost_parent and set the property there also (bug#9181).
59 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
60
c74e9d86
PE
612011-08-04 Paul Eggert <eggert@cs.ucla.edu>
62
63 * callproc.c (Fcall_process): Avoid vfork clobbering
64 the local vars buffer, coding_systems, current_dir.
65
640c8776
SM
662011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
67
68 * keymap.c (Fmake_composed_keymap): Move to subr.el.
69
f26d0e4c
PE
702011-08-03 Paul Eggert <eggert@cs.ucla.edu>
71
8a10d76c
PE
72 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
73 so that it is not optimized away.
74
f26d0e4c
PE
75 * xdisp.c (compute_display_string_pos): Remove unused local.
76
55439c61
EZ
772011-08-02 Eli Zaretskii <eliz@gnu.org>
78
79 Fix slow cursor motion and scrolling in large buffers with
80 selective display, like Org Mode buffers. (Bug#9218)
81
82 * dispextern.h (struct bidi_it): New member disp_prop_p.
83
84 * xdisp.c: Remove one-slot cache of display string positions.
85 (compute_display_string_pos): Accept an additional argument
86 DISP_PROP_P; callers changed. Scan at most 5K characters forward
87 for a display string or property. If found, set DISP_PROP_P
88 non-zero.
89
90 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
91 DISP_PROP_P, and pass it to compute_display_string_pos.
92 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
93 non-zero. All callers of bidi_fetch_char changed.
94
fb33fa43
SM
952011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
96
97 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
98
b099e063
DM
992010-12-03 Don March <don@ohspite.net>
100
101 * keymap.c (Fdefine_key): Fix non-prefix key error message when
102 last character M-[char] is translated to ESC [char] (bug#7541).
103
5cc7f7af
KH
1042011-08-02 Kenichi Handa <handa@m17n.org>
105
d0fffa3f 106 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
107
108 * chartab.c (uniprop_table): Make it non-static.
109
525d5e6e
EZ
1102011-08-01 Eli Zaretskii <eliz@gnu.org>
111
112 * xdisp.c (forward_to_next_line_start): Accept additional argument
113 BIDI_IT_PREV, and store into it the state of the bidi iterator had
114 on the newline.
115 (reseat_at_next_visible_line_start): Use the bidi iterator state
116 returned by forward_to_next_line_start to restore the state of
117 it->bidi_it after backing up to previous newline. (Bug#9212)
118
31011111
AS
1192011-07-30 Andreas Schwab <schwab@linux-m68k.org>
120
121 * regex.c (re_comp): Protoize.
122 (re_exec): Fix return type.
123 (regexec): Fix type of `ret'. (Bug#9203)
124
e5d76069
PE
1252011-07-29 Paul Eggert <eggert@cs.ucla.edu>
126
127 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
128 This is needed if max-image-size is a floating-point number.
129
9a79b20c
AS
1302011-07-28 Andreas Schwab <schwab@linux-m68k.org>
131
132 * print.c (print_object): Print empty symbol as ##.
133
134 * lread.c (read1): Read ## as empty symbol.
135
d8c2fa78
AA
1362011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
137
138 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
139 setting frame foreground color (Bug#9175).
140 (x_set_background_color): Likewise.
141
ffe57a7a
AA
142 * nsmenu.m (-setText): Size tooltip dimensions precisely to
143 contents (Bug#9176).
144 (EmacsTooltip -init): Remove bezels and add shadows to
145 tooltip windows.
146
bf3492a5
AA
147 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
148 or scroll bar (Bug#8470).
149
d55e9c53
AA
150 * nsfont.m (nsfont_open): Remove assignment to voffset and
151 unnecessary vars hshink, expand, hd, full_height, min_height.
152 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
153
154 * nsterm.h (nsfont_info): Remove voffset field.
155
d8c2fa78 1562011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
157
158 Implement strike-through and overline on NextStep (Bug#8863).
159
160 * nsfont.m (nsfont_open): Use underline position provided by font,
161 instead of hard-coded value of 2.
162 (nsfont_draw): Call ns_draw_text_decoration instead.
163
164 * nsterm.h: Add declaration for ns_draw_text_decoration.
165
166 * nsterm.m (ns_draw_text_decoration): New function for drawing
167 underline, overline, and strike-through.
168 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
169 ns_draw_text_decoration. Change treatment of cursor drawing to
170 accomodate underlining, etc.
171
4cc60b9b
EZ
1722011-07-28 Eli Zaretskii <eliz@gnu.org>
173
bc7ece87
EZ
174 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
175 default.
4cc60b9b 176
476371c4
PE
1772011-07-28 Paul Eggert <eggert@cs.ucla.edu>
178
66606eea
PE
179 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
180 Without this fix, if a signal arrives just after memory fills up,
181 'malloc' might be invoked reentrantly.
182
476371c4
PE
183 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
184 In other words, assume that every image size is allowed, on non-X
185 hosts. This assumption is probably wrong, but it lets Emacs compile.
186
f3fcc40d
AS
1872011-07-28 Andreas Schwab <schwab@linux-m68k.org>
188
189 * regex.c (re_iswctype): Convert return values to boolean.
190
350c992f
EZ
1912011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
192
193 * xdisp.c (compute_display_string_pos): Don't use cached display
194 string position if the buffer had its restriction changed.
195 (Bug#9184)
196
5266b4bb
PE
1972011-07-28 Paul Eggert <eggert@cs.ucla.edu>
198
199 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
200
2573a837 2012011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 202
41f55ccd 203 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 204
39e378da
PE
205 * bidi.c: Integer size and overflow fixes.
206 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
207 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
208 (bidi_cache_find_level_change, bidi_cache_ensure_space)
209 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
210 (bidi_find_other_level_edge):
211 Use ptrdiff_t instead of EMACS_INT where either will do.
212 This works better on 32-bit hosts configured --with-wide-int.
213 (bidi_cache_ensure_space): Check for size-calculation overflow.
214 Use % rather than repeated addition, for better worst-case speed.
215 Don't set bidi_cache_size until after xrealloc returns, because it
216 might not return.
217 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
218 (bidi_cache_ensure_space): Also check that the bidi cache size
219 does not exceed that of the largest Lisp string or buffer. See Eli
220 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 221
5e927815
PE
222 * alloc.c (__malloc_size_t): Remove.
223 All uses replaced by size_t. See Andreas Schwab's note
224 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
225
ca4aa935
PE
226 * image.c: Improve checking for integer overflow.
227 (check_image_size): Assume that f is nonnull, since
228 it is always nonnull in practice. This is one less thing to
229 worry about when checking for integer overflow later.
230 (x_check_image_size): New function, which checks for integer
231 overflow issues inside X.
232 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
233 This removes the need for a memory_full check.
234 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
235 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
236 (xbm_read_bitmap_data): Change locals back to 'int', since
237 their values must fit in 'int'.
238 (xpm_load_image, png_load, tiff_load):
239 Invoke x_create_x_image_and_pixmap earlier,
240 to avoid much needless work if the image is too large.
241 (tiff_load): Treat overly large images as if
242 x_create_x_image_and_pixmap failed, not as malloc failures.
243 (gs_load): Use x_check_image_size.
244
5f8f9cc2
PE
245 * gtkutil.c: Omit integer casts.
246 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
247 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
248
5adf60bc
PE
249 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
250
c8907a93
PE
251 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
252 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
253 would wrongly return t on a 64-bit host.
254
e3c25c68
PE
255 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
256 The plain *_OVERFLOW macros run afoul of GCC bug 49705
257 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
258 and therefore cause GCC to emit a bogus diagnostic in some cases.
259
3f791afe
PE
260 * image.c: Integer signedness and overflow and related fixes.
261 This is not an exhaustive set of fixes, but it's time to
262 record what I've got.
263 (lookup_pixel_color, check_image_size): Remove redundant decls.
264 (check_image_size): Don't assume that arbitrary EMACS_INT values
265 fit in 'int', or that arbitrary 'double' values fit in 'int'.
266 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
267 (tiff_load, imagemagick_load_image):
268 Check for overflow in size calculations.
269 (x_create_x_image_and_pixmap): Remove unnecessary test for
270 xmalloc returning NULL; that can't happen.
271 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
272 (xpm_color_bucket): Use better integer hashing function.
273 (xpm_cache_color): Don't possibly over-allocate memory.
274 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
275 (gif_memory_source):
276 Use ptrdiff_t, not int or size_t, to record sizes.
277 (png_load): Don't assume values greater than 2**31 fit in 'int'.
278 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
279 either works, as we prefer signed integers.
280 (tiff_read_from_memory, tiff_write_from_memory):
281 Return tsize_t, not size_t, since that's what the TIFF API wants.
282 (tiff_read_from_memory): Don't fail simply because the read would
283 go past EOF; instead, return a short read.
284 (tiff_load): Omit no-longer-needed casts.
285 (Fimagemagick_types): Don't assume size fits into 'int'.
286
3cc5a532
PE
287 Improve hashing quality when configured --with-wide-int.
288 * fns.c (hash_string): New function, taken from sxhash_string.
289 Do not discard information about ASCII character case; this
290 discarding is no longer needed.
291 (sxhash-string): Use it. Change sig to match it. Caller changed.
292 * lisp.h: Declare it.
293 * lread.c (hash_string): Remove, since we now use fns.c's version.
294 The fns.c version returns a wider integer if --with-wide-int is
295 specified, so this should help the quality of the hashing a bit.
296
b312a492
PE
297 * emacs.c: Integer overflow minor fix.
298 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
299 Define only if GNU_LINUX.
300 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
301
dfd153ae
PE
302 * dispnew.c: Integer signedness and overflow fixes.
303 Remove unnecessary forward decls, that were a maintenance hassle.
304 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
305 All uses changed.
306 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
307 (scrolling_window): Use ptrdiff_t, not int, for byte count.
308 (prepare_desired_row, line_draw_cost):
309 Use int, not unsigned, where either works.
310 (save_current_matrix, restore_current_matrix):
311 Use ptrdiff_t, not size_t, where either works.
312 (init_display): Check for overflow more accurately, and without
313 relying on undefined behavior.
314
a81d11a3
PE
315 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
316 Remove, replacing with the new symbols in lisp.h. All uses changed.
317 * fileio.c (make_temp_name):
318 * filelock.c (lock_file_1, lock_file):
319 * xdisp.c (message_dolog):
320 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
321 Use pMd etc. instead.
322 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
323 replacing the pWIDE etc. symbols removed from editfns.c.
324
3300e6fd
PE
325 * keyboard.h (num_input_events): Now uintmax_t.
326 This is (very slightly) less likely to mess up due to wraparound.
327 All uses changed.
328
fd05c7e9
PE
329 * buffer.c: Integer signedness fixes.
330 (alloc_buffer_text, enlarge_buffer_text):
331 Use ptrdiff_t rather than size_t when either will do, as we prefer
332 signed integers.
333
903fe15d
PE
334 * alloc.c: Integer signedness and overflow fixes.
335 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
336 (__malloc_size_t): Default to size_t, not to int.
337 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
338 (Fgarbage_collect, mark_object_loop_halt, mark_object):
339 Prefer ptrdiff_t to size_t when either would do, as we prefer
340 signed integers.
341 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
342 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
343 Now const. Initialize with values that are in range even if char
344 is signed.
345 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
346 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
347 These functions do the right thing with sizes > 2**32.
348 (check_depth): Now ptrdiff_t, not int.
349 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
350 Adjust to new way of storing sizes. Check for size overflow bugs
351 in rest of code.
352 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
353 slightly wrong anyway, as it missed one instance of
354 XMALLOC_OVERRUN_CHECK_OVERHEAD.
355 (refill_memory_reserve): Omit needless cast to size_t.
356 (mark_object_loop_halt): Mark as externally visible.
357
ac82cc6a
PE
358 * xselect.c: Integer signedness and overflow fixes.
359 (Fx_register_dnd_atom, x_handle_dnd_message):
360 Use ptrdiff_t, not size_t, since we prefer signed.
361 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
362 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
363 x_dnd_atoms_size and x_dnd_atoms_length.
364
c2d1e36d
PE
365 * doprnt.c: Prefer signed to unsigned when either works.
366 * eval.c (verror):
367 * doprnt.c (doprnt):
368 * lisp.h (doprnt):
369 * xdisp.c (vmessage):
370 Use ptrdiff_t, not size_t, when using or implementing doprnt,
371 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
372 prefer signed arithmetic to avoid comparison confusion.
373 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
374 but is a bit tricky.
375
0e926e56
PE
376 Assume freestanding C89 headers, string.h, stdlib.h.
377 * data.c, doprnt.c, floatfns.c, print.c:
378 Include float.h unconditionally.
379 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
380 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
381 * regex.c: Likewise for stddef.h, string.h.
382 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
383 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
384 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
385 (STDC_HEADERS): Remove obsolete defines.
386 * sysdep.c: Include limits.h unconditionally.
387
9cfdb3ec
PE
388 Assume support for memcmp, memcpy, memmove, memset.
389 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
390 * regex.c (memcmp, memcpy):
391 Remove; we assume C89 now.
392
393 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
394 (__malloc_safe_bcopy): Remove; no longer needed.
395
cf950e6b 396 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
397 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
398 well either way, and we prefer signed to unsigned.
399
dbf38e02
LMI
4002011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
401
402 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
403 closes the connection while we're reading (bug#9182).
404
d6f0886c
JD
4052011-07-25 Jan Djärv <jan.h.d@swipnet.se>
406
407 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
408 are specified (Bug#9168).
409
2eb1f9e6
PE
4102011-07-25 Paul Eggert <eggert@cs.ucla.edu>
411
412 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
413 Found by GCC static checking and --with-wide-int on a 32-bit host.
414
22381272 4152011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
416
417 * xdisp.c (compute_display_string_pos): Fix logic of caching
418 previous display string position. Initialize cached_prev_pos to
419 -1. Fixes slow-down at the beginning of a buffer.
420
f25e39b4
EZ
4212011-07-24 Eli Zaretskii <eliz@gnu.org>
422
423 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
424 for attrs[LFACE_FONTSET_INDEX].
425
04c4b52e
PE
4262011-07-23 Paul Eggert <eggert@cs.ucla.edu>
427
428 * xml.c (parse_region): Remove unused local
429 that was recently introduced.
430
c1734fbd
EZ
4312011-07-23 Eli Zaretskii <eliz@gnu.org>
432
be18c5a5
EZ
433 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
434 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
435
c1734fbd
EZ
436 * xdisp.c (move_it_in_display_line_to): Record the best matching
437 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
438 exit if none of the characters scanned was an exact match.
439 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
440 when exact match is impossible due to invisible text, and the
441 lines are truncated.
442
a258d627
JD
4432011-07-23 Jan Djärv <jan.h.d@swipnet.se>
444
445 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
446 for OSX >= 10.7.
447
b6d5a689
EZ
4482011-07-22 Eli Zaretskii <eliz@gnu.org>
449
0f74f785
EZ
450 Fix a significant slow-down of cursor motion with C-n, C-p,
451 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
452 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 453 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
454 (next_element_from_buffer): Call compute_stop_pos_backwards to
455 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
456 base_level_stop.
457 (reseat): Don't look for prev_stop, as that could mean a very long
458 run.
459 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
460 <cached_disp_overlay_modiff>: Cache for last found display string
461 position.
551918c1 462 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
463 about the same buffer in the same area of character positions, and
464 the buffer wasn't changed since the time the display string
465 position was cached.
551918c1 466
b2d0c91a
EZ
4672011-07-22 Eli Zaretskii <eliz@gnu.org>
468
469 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
470 is an integer, which is important for empty lines. (Bug#9149)
471
043604ee
CY
4722011-07-22 Chong Yidong <cyd@stupidchicken.com>
473
474 * frame.c (Fmodify_frame_parameters): In tty case, update the
475 default face if necessary (Bug#4238).
476
da4adb04
CY
4772011-07-21 Chong Yidong <cyd@stupidchicken.com>
478
479 * editfns.c (Fstring_to_char): No need to explain what a character
480 is in the docstring (Bug#6576).
481
9abd0532
LMI
4822011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
483
484 * xml.c (parse_region): Make sure we always return a tree.
485
36881d16
HK
4862011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
487
488 * xml.c (parse_region): If a document contains only comments,
489 return that, too.
490
1e98674d
LMI
4912011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
492
493 * xml.c (make_dom): Return comments, too.
494
590bd467
PE
4952011-07-19 Paul Eggert <eggert@cs.ucla.edu>
496
497 Port to OpenBSD.
498 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
499 and the surrounding thread.
500 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
501 rather than fgets, and retry after EINTR. Otherwise, 'emacs
502 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
503 timer goes off.
504 * s/openbsd.h (BROKEN_SIGIO): Define.
505 * unexelf.c (unexec) [__OpenBSD__]:
506 Don't update the .mdebug section of the Alpha COFF symbol table.
507
f41628b2
LMI
5082011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
509
510 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
511 (bug#8460).
512
b59b67c5
PE
5132011-07-18 Paul Eggert <eggert@cs.ucla.edu>
514
15e3a074
PE
515 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
516 This fixes some race conditions on the permissions of any newly
517 created file.
518
41bed37d
PE
519 * alloc.c (valid_pointer_p): Use pipe, not open.
520 This fixes some permissions issues when debugging.
521
b59b67c5
PE
522 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
523 If fchown fails to set both uid and gid, try to set just gid,
524 as that is sometimes allowed. Adjust the file's mode to eliminate
525 setuid or setgid bits that are inappropriate if fchown fails.
526
925a6be7
SM
5272011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
528
529 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
530 to compare Lisp_Objects.
531 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
532 global_gnutls_log_level, don't mistake it for a Lisp_Object.
533 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
534
52968808
AS
5352011-07-17 Andreas Schwab <schwab@linux-m68k.org>
536
0a6a104b
AS
537 * lread.c (read_integer): Unread even EOF character.
538 (read1): Likewise. Properly record start position of symbol.
539
52968808
AS
540 * lread.c (read1): Read `#:' as empty uninterned symbol if no
541 symbol character follows.
542
9e381cdd
PE
5432011-07-17 Paul Eggert <eggert@cs.ucla.edu>
544
545 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
546 This works around a problem with the previous change to Fcopy_file.
547 Recent glibc declares fchown with __attribute__((warn_unused_result)),
548 and without this change, GCC might complain about discarding
549 fchown's return value.
550
b5641435
JB
5512011-07-16 Juanma Barranquero <lekktu@gmail.com>
552
553 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
554
a8031457
PE
5552011-07-16 Paul Eggert <eggert@cs.ucla.edu>
556
557 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
558
dd889327
LMI
5592011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
560
750c33f7
LMI
561 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
562 it's used from the C level.
563
dd889327
LMI
564 * process.c: Use the same condition for POLL_FOR_INPUT in both
565 keyboard.c and process.c (bug#1858).
566
87e86684
LM
5672011-07-09 Lawrence Mitchell <wence@gmx.li>
568
569 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
570 (Fgnutls_boot): Use it.
571
64348f40
AS
5722011-07-15 Andreas Schwab <schwab@linux-m68k.org>
573
574 * doc.c (Fsubstitute_command_keys): Revert last change.
575
1d698799
LMI
5762011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
577
f863868c
LMI
578 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
579 quotes the next character, and doesn't affect other longer
580 sequences (bug#8935).
581
1d698799
LMI
582 * lread.c (syms_of_lread): Clarify that is isn't only
583 `eval-buffer' and `eval-defun' that's affected by
584 `lexical-binding' (bug#8460).
585
aa4b6df6
EZ
5862011-07-15 Eli Zaretskii <eliz@gnu.org>
587
588 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
589 bidi redisplay when a line includes both an image and is
590 truncated.
591
5d856da6
PE
5922011-07-14 Paul Eggert <eggert@cs.ucla.edu>
593
ad6042bb
PE
594 Fix minor problems found by static checking.
595 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
596 (elsz): Now a signed constant, not a size_t var. We prefer signed
597 types to unsigned, to avoid integer comparison confusion. Without
598 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
599 "cannot optimize loop, the loop counter may overflow", a symptom
600 of the confusion.
f00bbb22 601 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
602 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
603
6468f31c
LMI
6042011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
605
49080b10
LMI
606 * search.c (Fre_search_backward): Mention `case-fold-search' in
607 all the re_search_* functions (bug#8138).
608
6468f31c
LMI
609 * keyboard.c (Fopen_dribble_file): Document when the file is
610 closed (bug#8056).
611
c965adc5
EZ
6122011-07-14 Eli Zaretskii <eliz@gnu.org>
613
df9733bf
EZ
614 * bidi.c (bidi_dump_cached_states): Fix format of displaying
615 bidi_cache_idx.
616
0bb23927
EZ
617 Support bidi reordering of display and overlay strings.
618 * xdisp.c (compute_display_string_pos)
619 (compute_display_string_end): Accept additional argument STRING.
620 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
621 (reseat_to_string): Initialize bidi_it->string.s and
622 bidi_it->string.schars.
623 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
624 NULL (avoids a crash in bidi_paragraph_init).
625 Initialize itb.string.lstring.
0bb23927
EZ
626 (init_iterator): Call bidi_init_it only of a valid
627 buffer position was specified. Initialize paragraph_embedding to
628 L2R.
629 (reseat_to_string): Initialize the bidi iterator.
630 (display_string): If we need to ignore text properties of
631 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
632 original value of -1 will not work with bidi.)
633 (compute_display_string_pos): First arg is now struct
634 `text_pos *'; all callers changed. Support display properties on
635 Lisp strings.
636 (compute_display_string_end): Support display properties on Lisp
637 strings.
638 (init_iterator, reseat_1, reseat_to_string): Initialize the
639 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
640 when iterating on a string not from display properties).
640c8776
SM
641 (compute_display_string_pos, compute_display_string_end):
642 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
643 arrow keys.
644 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
645 base_level_stop; instead, set base_level_stop to BEGV.
646 Fixes crashes in vertical-motion.
0bb23927
EZ
647 (next_element_from_buffer): Improve commentary for when
648 the iterator is before prev_stop.
649 (init_iterator): Initialize bidi_p from the default value of
650 bidi-display-reordering, not from buffer-local value. Use the
651 buffer-local value only if initializing for buffer iteration.
652 (handle_invisible_prop): Support invisible properties on strings
653 that are being bidi-reordered.
654 (set_iterator_to_next): Support bidi reordering of C strings and
655 Lisp strings.
656 (next_element_from_string): Support bidi reordering of Lisp
657 strings.
658 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
659 (display_string): Support display of R2L glyph rows.
660 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
661 (init_iterator): Don't initialize it->bidi_p for strings
662 here.
663 (reseat_to_string): Initialize it->bidi_p for strings here.
664 (next_element_from_string, next_element_from_c_string)
665 (next_element_from_buffer): Add xassert's for correspondence
666 between IT's object being iterated and it->bidi_it.string
667 structure.
668 (face_before_or_after_it_pos): Support bidi iteration.
669 (next_element_from_c_string): Handle the case of the first string
670 character that is not the first one in the visual order.
671 (get_visually_first_element): New function, refactored from common
672 parts of next_element_from_buffer, next_element_from_string, and
673 next_element_from_c_string.
674 (tool_bar_lines_needed, redisplay_tool_bar)
675 (display_menu_bar): Force left-to-right direction. Add a FIXME
676 comment for making that be controlled by a user option.
677 (push_it, pop_it): Save and restore the state of the
678 bidi iterator. Save and restore the bidi_p flag.
679 (pop_it): Iterate out of display property for string iteration as
680 well.
681 (iterate_out_of_display_property): Support iteration over strings.
682 (handle_single_display_spec): Set up it->bidi_it for iteration
683 over a display string, and call bidi_init_it.
684 (handle_single_display_spec, next_overlay_string)
685 (get_overlay_strings_1, push_display_prop): Set up the bidi
686 iterator for displaying display or overlay strings.
687 (forward_to_next_line_start): Don't use the shortcut if
688 bidi-iterating.
689 (back_to_previous_visible_line_start): If handle_display_prop
690 pushed the iterator stack, restore the internal state of the bidi
691 iterator by calling bidi_pop_it same number of times.
692 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
693 and we are bidi-iterating, don't decrement the iterator position;
694 instead, set the first_elt flag in the bidi iterator, to produce
695 the same effect.
696 (reseat_1): Remove redundant setting of string_from_display_prop_p.
697 (push_display_prop): xassert that we are iterating a buffer.
698 (push_it, pop_it): Save and restore paragraph_embedding member.
699 (handle_single_display_spec, next_overlay_string)
700 (get_overlay_strings_1, reseat_1, reseat_to_string)
701 (push_display_prop): Set up the `unibyte' member of bidi_it.string
702 correctly. Don't assume unibyte strings are not bidi-reordered.
703 (compute_display_string_pos)
704 (compute_display_string_end): Fix handling the case of C string.
705 (push_it, pop_it): Save and restore from_disp_prop_p.
706 (handle_single_display_spec, push_display_prop): Set the
707 from_disp_prop_p flag.
708 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
709 (pop_it): Call iterate_out_of_display_property only if we are
710 popping after iteration over a string that came from a display
711 property. Fix a typo in popping stretch info. Add an assertion
712 for verifying that the iterator position is in sync with the bidi
713 iterator.
714 (handle_single_display_spec, get_overlay_strings_1)
715 (push_display_prop): Fix initialization of paragraph direction for
716 string when that of the parent object is not yet determined.
717 (reseat_1): Call bidi_init_it to resync the bidi
718 iterator with IT's position. (Bug#7616)
719 (find_row_edges): If ROW->start.pos gives position
720 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
721 (handle_stop, back_to_previous_visible_line_start, reseat_1):
722 Reset the from_disp_prop_p flag.
723 (SAVE_IT, RESTORE_IT): New macros.
724 (pos_visible_p, face_before_or_after_it_pos)
725 (back_to_previous_visible_line_start)
726 (move_it_in_display_line_to, move_it_in_display_line)
727 (move_it_to, move_it_vertically_backward, move_it_by_lines)
728 (try_scrolling, redisplay_window, display_line): Use them when
729 saving a temporary copy of the iterator and restoring it back.
730 (back_to_previous_visible_line_start, reseat_1)
731 (init_iterator): Empty the bidi cache "stack".
732 (move_it_in_display_line_to): If iterator ended up at
733 EOL, but we never saw any buffer positions smaller than
734 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
735 motion in bidi-reordered lines.
736 (move_it_in_display_line_to): Record prev_method and prev_pos
737 immediately before the call to set_iterator_to_next. Fixes cursor
738 motion in bidi-reordered lines with stretch glyphs and strings
739 displayed in margins. (Bug#8133) (Bug#8867)
740 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
741 TO_CHARPOS.
640c8776
SM
742 (pos_visible_p): Support positions in bidi-reordered lines.
743 Save and restore bidi cache.
0bb23927
EZ
744
745 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
746 (bidi_paragraph_info): Delete unused struct.
747 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
748 (bidi_cache_start): New variable.
749 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
750 to zero.
751 (bidi_cache_fetch_state, bidi_cache_search)
752 (bidi_cache_find_level_change, bidi_cache_iterator_state)
753 (bidi_cache_find, bidi_peek_at_next_level)
754 (bidi_level_of_next_char, bidi_find_other_level_edge)
755 (bidi_move_to_visually_next): Compare cache index with
756 bidi_cache_start rather than with zero.
757 (bidi_fetch_char): Accept new argument STRING; all callers
758 changed. Support iteration over a string. Support strings with
759 display properties. Support unibyte strings. Fix the type of
760 `len' according to what STRING_CHAR_AND_LENGTH expects.
761 (bidi_paragraph_init, bidi_resolve_explicit_1)
762 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
763 (bidi_level_of_next_char, bidi_move_to_visually_next):
764 Support iteration over a string.
0bb23927
EZ
765 (bidi_set_sor_type, bidi_resolve_explicit_1)
766 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
767 can now be zero (for strings); special values 0 and -1 were
768 changed to -1 and -2, respectively.
769 (bidi_char_at_pos): New function.
770 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
771 Call it instead of FETCH_MULTIBYTE_CHAR.
772 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
773 initialized to valid values.
774 (bidi_init_it): Don't initialize charpos and bytepos with invalid
775 values.
776 (bidi_level_of_next_char): Allow the sentinel "position" to pass
777 the test for valid cached positions. Fix the logic for looking up
778 the sentinel state in the cache. GCPRO the Lisp string we are
779 iterating.
780 (bidi_push_it, bidi_pop_it): New functions.
781 (bidi_initialize): Initialize the bidi cache start stack pointer.
782 (bidi_cache_ensure_space): New function, refactored from part of
783 bidi_cache_iterator_state. Don't assume the required size is just
784 one BIDI_CACHE_CHUNK away.
785 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
786 (bidi_count_bytes, bidi_char_at_pos): New functions.
787 (bidi_cache_search): Don't assume bidi_cache_last_idx is
788 always valid if bidi_cache_idx is valid.
789 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
790 is valid if it's going to be used.
791 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
792 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
793 (bidi_cache_find_level_change, bidi_cache_ensure_space)
794 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
795 (bidi_find_other_level_edge, bidi_cache_start_stack):
796 All variables related to cache indices are now EMACS_INT.
c965adc5 797
0bb23927
EZ
798 * dispextern.h (struct bidi_string_data): New structure.
799 (struct bidi_it): New member `string'. Make flag members be 1-bit
800 fields, and put them last in the struct.
640c8776
SM
801 (compute_display_string_pos, compute_display_string_end):
802 Update prototypes.
0bb23927
EZ
803 (bidi_push_it, bidi_pop_it): Add prototypes.
804 (struct iterator_stack_entry): New members bidi_p,
805 paragraph_embedding, and from_disp_prop_p.
806 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
807 (bidi_shelve_cache, bidi_unshelve_cache):
808 Declare prototypes.
0bb23927
EZ
809
810 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
811 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
812 and vector-like objects.
813
814 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
815 cache around display iteration.
816
817 * window.c (Fwindow_end, window_scroll_pixel_based)
818 (displayed_window_lines, Frecenter): Save and restore the bidi
819 cache around display iteration.
820
3bbd2265
LMI
8212011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
822
823 * editfns.c (Fdelete_region): Clarify the use of the named
824 parameters (bug#6788).
825
adc47434
MR
8262011-07-14 Martin Rudalics <rudalics@gmx.at>
827
828 * indent.c (Fvertical_motion): Set and restore w->pointm when
829 saving and restoring the window's buffer (Bug#9006).
830
837c31f8
LMI
8312011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
832
833 * editfns.c (Fstring_to_char): Clarify just what is returned
834 (bug#6576). Text by Eli Zaretskii.
835
ac389d0c
JB
8362011-07-13 Juanma Barranquero <lekktu@gmail.com>
837
838 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
839
0be0ce47
EZ
8402011-07-13 Eli Zaretskii <eliz@gnu.org>
841
842 * buffer.c (mmap_find): Fix a typo.
843
cd18e7e3
JB
8442011-07-13 Johan Bockgård <bojohan@gnu.org>
845
846 Fix execution of x selection hooks.
847 * xselect.c (Qx_lost_selection_functions)
848 (Qx_sent_selection_functions): New vars.
849 (syms_of_xselect): DEFSYM them.
850 (x_handle_selection_request): Pass Qx_sent_selection_functions
851 rather than Vx_sent_selection_functions to Frun_hook_with_args.
852 (x_handle_selection_clear,x_clear_frame_selections):
853 Pass Qx_lost_selection_functions rather than
854 Vx_lost_selection_functions to Frun_hook_with_args.
855
47ea7f44
PE
8562011-07-13 Paul Eggert <eggert@cs.ucla.edu>
857
ac389d0c 858 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
859 The old code sometimes used this field without initializing it.
860
47ea7f44
PE
861 * alloc.c (gc_sweep): Don't read past end of array.
862 In theory, the old code could also have corrupted Emacs internals,
863 though it'd be very unlikely.
864
bc985c87
AS
8652011-07-12 Andreas Schwab <schwab@linux-m68k.org>
866
867 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 868 argument. (Bug#4026)
bc985c87 869
0cf34688
LMI
8702011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
871
b3dadd76
LMI
872 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
873 key" (bug#4257).
874
0cf34688
LMI
875 * window.c (Fset_window_start): Doc fix (bug#4199).
876 (Fset_window_hscroll): Ditto.
877
270768cd
PE
8782011-07-12 Paul Eggert <eggert@cs.ucla.edu>
879
077e3dda 880 Fix minor new problems caught by GCC 4.6.1.
270768cd 881 * term.c (init_tty): Remove unused local.
490011a6 882 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 883 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 884 not used otherwise.
270768cd 885
b1f58454
CY
8862011-07-12 Chong Yidong <cyd@stupidchicken.com>
887
888 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
889
22b9578d
LMI
8902011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
891
6e70ab07
LMI
892 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
893 are the mini-buffer and the echo area (bug#3320).
894
22b9578d
LMI
895 * term.c (init_tty): Remove support for supdup, c10 and perq
896 terminals, which are no longer supported (bug#1482).
897
8974cc9f
JB
8982011-07-10 Johan Bockgård <bojohan@gnu.org>
899
900 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
901
a560d974
JD
9022011-07-10 Jan Djärv <jan.h.d@swipnet.se>
903
904 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
905 for non-popups (Bug#3642).
906
1dae0f0a
AS
9072011-07-10 Andreas Schwab <schwab@linux-m68k.org>
908
268c2c36 909 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 910 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
911 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
912 * cm.c (losecursor): Likewise.
1dae0f0a
AS
913 * data.c (fmod): Likewise.
914 * dispnew.c (swap_glyphs_in_rows): Likewise.
915 * emacs.c (memory_warning_signal): Likewise.
916 * floatfns.c (float_error): Likewise.
917 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
918 (otf_open, font_otf_capability, generate_otf_features)
919 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
920 Likewise.
921 * image.c (pbm_read_file): Likewise.
922 * indent.c (string_display_width): Likewise.
923 * intervals.c (check_for_interval, search_for_interval)
924 (inc_interval_count, count_intervals, root_interval)
925 (adjust_intervals_for_insertion, make_new_interval): Likewise.
926 * lread.c (defalias): Likewise.
268c2c36 927 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
928 * regex.c (set_image_of_range_1, set_image_of_range)
929 (regex_grow_registers): Likewise.
930 * sysdep.c (strerror): Likewise.
931 * termcap.c (valid_filename_p, tprint, main): Likewise.
932 * tparam.c (main): Likewise.
933 * unexhp9k800.c (run_time_remap, save_data_space)
934 (update_file_ptrs, read_header, write_header, calculate_checksum)
935 (copy_file, copy_rest, display_header): Likewise.
936 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
937 Likewise.
938 * xdisp.c (check_it): Likewise.
939 * xfaces.c (register_color, unregister_color, unregister_colors):
940 Likewise.
941 * xfns.c (print_fontset_result): Likewise.
942 * xrdb.c (member, fatal, main): Likewise.
943
99033785
PE
9442011-07-10 Paul Eggert <eggert@cs.ucla.edu>
945
946 Fix minor problems found by static checking (Bug#9031).
947 * chartab.c (char_table_set_range, map_sub_char_table):
948 Remove unused locals.
949 (uniprop_table): Now static.
950 * composite.c (_work_char): Remove unused static var.
951
9cb2ac56
JB
9522011-07-09 Juanma Barranquero <lekktu@gmail.com>
953
954 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
955
f25661f0
JD
9562011-07-09 Jan Djärv <jan.h.d@swipnet.se>
957
958 * gtkutil.c (qttip_cb): Remove code without function.
959
8278c4fe
EZ
9602011-07-09 Eli Zaretskii <eliz@gnu.org>
961
962 * w32.c (pthread_sigmask): New stub.
963
1692ae2d 9642011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 965
8a6ebd58 966 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
967 sigprocmask is portable only for single-threaded applications, and
968 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
969 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
970 (LIBES): Use it.
971 * callproc.c (Fcall_process):
972 * process.c (create_process):
973 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
974 Use pthread_sigmask, not sigprocmask.
123403e4 975
1b854618
JD
9762011-07-08 Jan Djärv <jan.h.d@swipnet.se>
977
978 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
979 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
980 wrong (Bug#8591).
981
3fe4b549
JD
9822011-07-08 Jan Djärv <jan.h.d@swipnet.se>
983
0ce7e563
JD
984 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
985 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
986 (xg_hide_tooltip): Fix comment.
987
3fe4b549
JD
988 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
989 in registerServicesMenuSendTypes.
990 (validRequestorForSendType): Don't check ns_return_types.
991
992 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
993 ns_return_type.
994
5df75e47
JR
9952011-07-08 Jason Rumney <jasonr@gnu.org>
996
997 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
998 frame struct members of non-existent frames (Bug#6284).
999
699c10bd
JD
10002011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1001
4393663b
JD
1002 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1003 variable firstTime not needed on OSX >= 10.6.
1004 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1005 >= 10.5. Use setKnobProportion, setDoubleValue.
1006
1007 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1008 (MAC_OS_X_VERSION_10_5): Define if not defined.
1009 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1010 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1011 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1012
1013 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1014 cString and lossyCString on OSX >= 10.4
1015
1016 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1017 sizeToFit on OSX >= 10.2.
1018
1019 * nsimage.m (allocInitFromFile): Don't use deprecated method
1020 bestRepresentationForDevice on OSX >= 10.6.
1021
1022 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1023 to avoid warning.
1024
1025 * emacs.c: Declare unexec_init_emacs_zone.
1026
a63e0781
JD
1027 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1028
699c10bd
JD
1029 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1030
1031 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1032 on svcsMenu (Bug#8842).
1033
1034 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1035 ns_return_types.
1036 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1037
1038 * nsterm.m (QUTF8_STRING): Declare.
1039 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1040 (validRequestorForSendType): Return type is (id).
1041 Change indexOfObjectIdenticalTo to indexOfObject.
1042 Check if we have local selection before returning self (Bug#8842).
1043 (writeSelectionToPasteboard): Put local selection into paste board
1044 if we have a local selection (Bug#8842).
1045 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1046
1047 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1048 (ns_get_local_selection): Declare.
1049
54e10184
LMI
10502011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1051
9888ff71
LMI
1052 * keymap.c (describe_map_tree): Don't insert a double newline at
1053 the end of the buffer (bug#1169) and return whether we inserted
1054 something.
1055
54e10184
LMI
1056 * callint.c (Fcall_interactively): Change "reading args" to
1057 "providing args" to try to clarify what it does (bug#1010).
1058
15fa4783
KH
10592011-07-07 Kenichi Handa <handa@m17n.org>
1060
1061 * composite.c (composition_compute_stop_pos): Ignore a static
1062 composition starting before CHARPOS (Bug#8915).
1063
1064 * xdisp.c (handle_composition_prop): Likewise.
1065
a8815b00
EZ
10662011-07-07 Eli Zaretskii <eliz@gnu.org>
1067
1068 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1069 (Bug#9015)
1070
ef7b981d 10712011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1072
1073 * character.h (unicode_category_t): New enum type.
1074
1075 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1076 (Qchar_code_property_table): New variable.
1077 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1078 (UNIPROP_COMPRESSED_FORM_P): New macros.
1079 (char_table_ascii): Uncompress the compressed values.
1080 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1081 Uncompress the compressed values.
ac389d0c 1082 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1083 (char_table_ref_and_range): Uncompress the compressed values.
1084 (sub_char_table_set): New arg is_uniprop. Callers changed.
1085 Uncompress the compressed values.
1086 (sub_char_table_set_range): Args changed. Callers changed.
1087 (char_table_set_range): Adjuted for the above change.
1088 (map_sub_char_table): Delete args default_val and parent. Add arg
1089 top. Give decoded values to a Lisp function.
640c8776 1090 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1091 values to a Lisp function. Gcpro more variables.
1092 (uniprop_table_uncompress)
1093 (uniprop_decode_value_run_length): New functions.
1094 (uniprop_decoder, uniprop_decoder_count): New variables.
1095 (uniprop_get_decoder, uniprop_encode_value_character)
1096 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1097 New functions.
1098 (uniprop_encoder, uniprop_encoder_count): New variables.
1099 (uniprop_get_encoder, uniprop_table)
1100 (Funicode_property_table_internal, Fget_unicode_property_internal)
1101 (Fput_unicode_property_internal): New functions.
1102 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1103 Sunicode_property_table_internal, Sget_unicode_property_internal,
1104 and Sput_unicode_property_internal. Defvar_lisp
1105 char-code-property-alist.
1106
640c8776 1107 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1108 Vunicode_category_table.
1109
640c8776 1110 * font.c (font_range): Adjust for the change of
c805dec0
KH
1111 Vunicode_category_table.
1112
76b397fb
DN
11132011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1114
1115 * m/iris4d.h: Remove file, move contents ...
1116 * s/irix6-5.h: ... here.
1117
22b4128e
PE
11182011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1119
1120 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1121 * alloc.c (mark_buffer):
1122 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1123 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1124 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1125 This isn't true in general, and it's particularly not true
1126 if Emacs is configured with --with-wide-int.
1127 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1128 New macros, used in the buffer.c change.
1129
869795d6
JD
11302011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1131
1132 * xsettings.c: Use both GConf and GSettings if both are available.
1133 (store_config_changed_event): Add comment.
1134 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1135 (store_tool_bar_style_changed): New functions.
1136 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1137 (struct xsettings): Move font inside HAVE_XFT.
1138 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 1139 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 1140 Move inside HAVE_XFT.
640c8776 1141 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
1142 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1143 also.
1144 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
1145 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1146 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
1147 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1148 (parse_settings): Move check for font inside HAVE_XFT.
1149 (read_settings, apply_xft_settings): Add comment.
1150 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1151 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1152 call store_font_name_changed.
1153 (xft_settings_event): Add comment.
1154 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1155 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1156 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1157 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1158 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
1159 (xsettings_get_system_font, xsettings_get_system_normal_font):
1160 Add comment.
869795d6 1161
d8ed26bd
PE
11622011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1163
1164 Random fixes. E.g., (random) never returned negative values.
1165 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1166 subseconds part to the entropy, as that's a bit more random.
1167 Prefer signed to unsigned, since the signedness doesn't matter and
1168 in general we prefer signed. When given a limit, use a
1169 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1170 latter isn't right if USE_2_TAGS_FOR_INTS.
1171 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1172 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1173
cabf1cac
SM
11742011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1175
1176 * textprop.c (text_property_stickiness):
1177 Obey Vtext_property_default_nonsticky.
1178 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1179 * w32fns.c (syms_of_w32fns):
1180 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1181
6e9b2be9
PE
11822011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1183
1184 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1185 This is more efficient than Ffile_directory_p and avoids a minor race.
1186
90186c68
LMI
11872011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1188
7c301272
LMI
1189 * buffer.c (Foverlay_put): Say what the return value is
1190 (bug#7835).
1191
c4f2d8d4
LMI
1192 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1193 is a directory before asking whether to use the file name
1194 (bug#7564).
ad637907
LMI
1195 (barf_or_query_if_file_exists): Make the "File is a directory"
1196 error be more correct.
c4f2d8d4 1197
90186c68
LMI
1198 * fns.c (Frequire): Remove the mention of the .gz files, since
1199 that's installation-specific, but keep the mention of
1200 `get-load-suffixes'.
1201
da64016e
PE
12022011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1203
1204 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1205 Report string overflow if the output is too long.
1206
7d47b580
JB
12072011-07-04 Juanma Barranquero <lekktu@gmail.com>
1208
a555cb87
JB
1209 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1210 (syms_of_gnutls): Remove duplicate DEFSYM for
1211 Qgnutls_bootprop_verify_hostname_error, an error for
1212 Qgnutls_bootprop_verify_error (which is no longer used).
1213
7d47b580
JB
1214 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1215 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1216 Also (re)move comments that are misplaced or no longer relevant.
1217
1e49bfab
LMI
12182011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1219
1220 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1221
1485f4c0
CY
12222011-07-03 Chong Yidong <cyd@stupidchicken.com>
1223
1224 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1225 and background color parameters if they have been changed.
1226
a9ab721e
LMI
12272011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1228
1229 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1230
cf7cff57
PE
12312011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1232
2e13213d
PE
1233 * xsettings.c (SYSTEM_FONT): Define only when used.
1234 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1235
cf7cff57
PE
1236 * keymap.c (access_keymap_1): Now static.
1237
7a8e04f7
CY
12382011-07-02 Chong Yidong <cyd@stupidchicken.com>
1239
1240 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1241 leave any prefix arg for the up event (Bug#1586).
1242
61352f62
LMI
12432011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1244
69bb1ef7
LMI
1245 * lread.c (syms_of_lread): Mention single symbols defined by
1246 `defvar' or `defconst' (bug#7154).
1247
61352f62 1248 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1249 (Frequire): Mention get-load-suffixes.
61352f62 1250
28545e04
MR
12512011-07-02 Martin Rudalics <rudalics@gmx.at>
1252
1253 * window.h (window): Remove clone_number slot.
1254 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1255 Remove.
1256 (make_parent_window, make_window, saved_window)
1257 (Fset_window_configuration, save_window_save): Don't deal with
1258 clone numbers.
1259 * buffer.c (Qclone_number): Remove declaration.
1260 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1261
3349e122
SM
12622011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1263
1264 Add multiple inheritance to keymaps.
1265 * keymap.c (Fmake_composed_keymap): New function.
1266 (Fset_keymap_parent): Simplify.
1267 (fix_submap_inheritance): Remove.
1268 (access_keymap_1): New function extracted from access_keymap to handle
1269 embedded parents and handle lists of maps.
1270 (access_keymap): Use it.
1271 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1272 (Fcopy_keymap): Handle embedded parents.
1273 (Fcommand_remapping, define_as_prefix): Simplify.
1274 (Fkey_binding): Simplify.
1275 (syms_of_keymap): Move minibuffer-local-completion-map,
1276 minibuffer-local-filename-completion-map,
1277 minibuffer-local-must-match-map, and
1278 minibuffer-local-filename-must-match-map to Elisp.
1279 (syms_of_keymap): Defsubr make-composed-keymap.
1280 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1281 (parse_menu_item): Trivial simplification.
1282
3279eb87
GM
12832011-07-01 Glenn Morris <rgm@gnu.org>
1284
1285 * Makefile.in (SETTINGS_LIBS): Fix typo.
1286
4550efdf
KI
12872011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1288
1289 * coding.c (Fencode_coding_string): Record the last coding system
1290 used, as the function doc string says (bug#8738).
1291
0949d2b6
JD
12922011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1293
1294 * xsettings.c (store_monospaced_changed): Take new font as arg and
1295 check for change against current_mono_font.
1296 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1297 (emacs_settings_constructor, emacs_settings_get_property)
1298 (emacs_settings_set_property, emacs_settings_class_init)
1299 (emacs_settings_init, gsettings_obj): Remove.
1300 (something_changedCB): New function for HAVE_GSETTINGS.
1301 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1302 with value as argument.
1303 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1304 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1305 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1306 "changed".
1307
1308 * xgselect.c: Add defined (HAVE_GSETTINGS).
1309 (xgselect_initialize): Ditto.
1310
1311 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1312 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1313 xg_select.
1314
bbc6b304
PE
13152011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1316
1317 * eval.c (struct backtrace): Simplify and port the data structure.
1318 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1319 signed bit field, as this assumption is not portable and it makes
1320 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1321 "char debug_on_exit : 1" as this is not portable either; instead,
1322 use the portable "unsigned int debug_on_exit : 1". Remove unused
1323 member evalargs. Remove obsolete comments about cc bombing out.
1324
9851bfc5
JD
13252011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1326
51bb811f 1327 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1328 Let HAVE_GSETTINGS override HAVE_GCONF.
1329 (store_monospaced_changed): New function.
1330 (EMACS_SETTINGS): A new type derived from GObject to handle
1331 GSettings notifications.
1332 (emacs_settings_constructor, emacs_settings_get_property)
1333 (emacs_settings_set_property, emacs_settings_class_init):
1334 New functions.
1335 (gsettings_client, gsettings_obj): New variables.
1336 (GSETTINGS_SCHEMA): New define.
1337 (something_changedCB): Call store_monospaced_changed.
1338 (init_gsettings): New function.
1339 (xsettings_initialize): Call init_gsettings.
1340 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1341 to NULL.
1342
640c8776 1343 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
1344 GCONF_CFLAGS/LIBS.
1345
5386012d
MR
13462011-06-29 Martin Rudalics <rudalics@gmx.at>
1347
1348 * window.c (resize_root_window, grow_mini_window)
1349 (shrink_mini_window): Rename Qresize_root_window to
1350 Qwindow_resize_root_window and Qresize_root_window_vertically to
1351 Qwindow_resize_root_window_vertically.
1352
f13e0b08
PE
13532011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1354
1355 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1356
94515237
JB
13572011-06-27 Juanma Barranquero <lekktu@gmail.com>
1358
1359 * makefile.w32-in: Redesign dependencies so they reflect more
1360 clearly which files are directly included by each source file,
1361 and not through other includes.
1362
e43b6e43
MR
13632011-06-27 Martin Rudalics <rudalics@gmx.at>
1364
1365 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1366 (sort_overlays, overlay_strings): When an overlay's clone number
1367 matches the window's clone number process the overlay even if
1368 the overlay's window property doesn't match the current window.
1369
d68443dc
MR
1370 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1371 (Fwindow_hchild): Rename to Fwindow_left_child.
1372 (Fwindow_next): Rename to Fwindow_next_sibling.
1373 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1374 (resize_window_check): Rename to window_resize_check.
1375 (resize_window_apply): Rename to window_resize_apply.
1376 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1377 (Fdelete_other_windows_internal, resize_frame_windows)
1378 (Fsplit_window_internal, Fdelete_window_internal)
1379 (grow_mini_window, shrink_mini_window)
1380 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1381
c7e73be5
JD
13822011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1383
1384 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1385 (emacs_fixed_set_min_size): Remove.
1386 (emacs_fixed_new): Take frame as argument.
1387
1388 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1389 (_EmacsFixedPrivate): Remove minwidth/height.
1390 Add struct frame *f.
1391 (emacs_fixed_init): Initialize priv->f.
1392 (get_parent_class, emacs_fixed_set_min_size): Remove.
1393 (emacs_fixed_new): Set priv->f to argument.
1394 (emacs_fixed_get_preferred_width)
1395 (emacs_fixed_get_preferred_height): Use min_width/height from
1396 frames size_hint to set minimum and natural (Bug#8919).
1397 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1398 and use min_width/height from frames size_hint to set
1399 min_width/height (Bug#8919).
1400
1401 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1402 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1403 Fix indentation.
c7e73be5 1404
cf99dcf8
EZ
14052011-06-26 Eli Zaretskii <eliz@gnu.org>
1406
1407 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1408 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1409 called at ZV.
1410
029529ac
CY
14112011-06-26 Chong Yidong <cyd@stupidchicken.com>
1412
1413 * process.c (wait_reading_process_output): Bypass select if
1414 waiting for a cell while ignoring keyboard input, and input is
1415 pending. Suggested by Jan Djärv (Bug#8869).
1416
7a7ef429
PE
14172011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1418
1419 Use gnulib's dup2 module instead of rolling our own.
1420 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1421
11fdef7d 14222011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1423
1424 * dispnew.c (scrolling_window): Before scrolling, turn off a
1425 mouse-highlight in the window being scrolled.
1426
cd3520a4
JB
14272011-06-24 Juanma Barranquero <lekktu@gmail.com>
1428
1429 Move DEFSYM to lisp.h and use everywhere.
1430
1431 * character.h (DEFSYM): Move declaration...
1432 * lisp.h (DEFSYM): ...here.
1433
1434 * gnutls.c:
1435 * minibuf.c:
1436 * w32menu.c:
1437 * w32proc.c:
1438 * w32select.c: Don't include character.h.
1439
1440 * alloc.c (syms_of_alloc):
1441 * buffer.c (syms_of_buffer):
1442 * bytecode.c (syms_of_bytecode):
1443 * callint.c (syms_of_callint):
1444 * casefiddle.c (syms_of_casefiddle):
1445 * casetab.c (init_casetab_once):
1446 * category.c (init_category_once, syms_of_category):
1447 * ccl.c (syms_of_ccl):
1448 * cmds.c (syms_of_cmds):
1449 * composite.c (syms_of_composite):
1450 * dbusbind.c (syms_of_dbusbind):
1451 * dired.c (syms_of_dired):
1452 * dispnew.c (syms_of_display):
1453 * doc.c (syms_of_doc):
1454 * editfns.c (syms_of_editfns):
1455 * emacs.c (syms_of_emacs):
1456 * eval.c (syms_of_eval):
1457 * fileio.c (syms_of_fileio):
1458 * fns.c (syms_of_fns):
1459 * frame.c (syms_of_frame):
1460 * fringe.c (syms_of_fringe):
1461 * insdel.c (syms_of_insdel):
1462 * keymap.c (syms_of_keymap):
1463 * lread.c (init_obarray, syms_of_lread):
1464 * macros.c (syms_of_macros):
1465 * msdos.c (syms_of_msdos):
1466 * print.c (syms_of_print):
1467 * process.c (syms_of_process):
1468 * search.c (syms_of_search):
1469 * sound.c (syms_of_sound):
1470 * syntax.c (init_syntax_once, syms_of_syntax):
1471 * terminal.c (syms_of_terminal):
1472 * textprop.c (syms_of_textprop):
1473 * undo.c (syms_of_undo):
1474 * w32.c (globals_of_w32):
1475 * window.c (syms_of_window):
1476 * xdisp.c (syms_of_xdisp):
1477 * xfaces.c (syms_of_xfaces):
1478 * xfns.c (syms_of_xfns):
1479 * xmenu.c (syms_of_xmenu):
1480 * xsettings.c (syms_of_xsettings):
1481 * xterm.c (syms_of_xterm): Use DEFSYM.
1482
4228cf16
TZ
14832011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1484
cd3520a4 1485 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1486
7fcccf1e
PE
14872011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1488
7efb4e0e
PE
1489 Integer and buffer overflow fixes (Bug#8873).
1490
ff5844ad
PE
1491 * print.c (printchar, strout): Check for string overflow.
1492 (PRINTPREPARE, printchar, strout):
1493 Don't set size unless allocation succeeds.
1494
90532f02
PE
1495 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1496 for sizes. Check for string overflow more accurately.
1497 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1498
6d84508d
PE
1499 * macros.c: Integer and buffer overflow fixes.
1500 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1501 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1502 Use ptrdiff_t, not int, for sizes.
1503 Don't increment bufsize until after realloc succeeds.
1504 Check for size-calculation overflow.
1505 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1506
437b2cb4
PE
1507 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1508
8b9ac8b4
PE
1509 * lread.c: Integer overflow fixes.
1510 (read_integer): Radix is now EMACS_INT, not int,
1511 to improve quality of diagnostics for out-of-range radices.
1512 Calculate buffer size correctly for out-of-range radices.
1513 (read1): Check for integer overflow in radices, and in
1514 read-circle numbers.
82cb60d3
PE
1515 (read_escape): Avoid int overflow.
1516 (Fload, openp, read_buffer_size, read1)
1517 (substitute_object_recurse, read_vector, read_list, map_obarray):
1518 Use ptrdiff_t, not int, for sizes.
1519 (read1): Use EMACS_INT, not int, for sizes.
20270765 1520 Check for size overflow.
8b9ac8b4 1521
7fcccf1e
PE
1522 * image.c (cache_image): Check for size arithmetic overflow.
1523
bfbbd7e7
PE
1524 * lread.c: Integer overflow issues.
1525 (saved_doc_string_size, saved_doc_string_length)
1526 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1527 Now ptrdiff_t, not int.
1528 (read1): Don't assume doc string length fits in int. Check for
1529 out-of-range doc string lengths.
1530 (read_list): Don't assume file position fits in int.
39019e54 1531 (read_escape): Check for hex character overflow.
bfbbd7e7 1532
4e323265
LL
15332011-06-22 Leo Liu <sdl.web@gmail.com>
1534
1535 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1536 Move to minibuffer.el.
1537
85fece3e
PE
15382011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1539
20b84ce9 1540 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1541 The following patches are for when GLYPH_DEBUG && !XASSERT.
1542 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1543 * dispnew.c (flush_stdout):
1544 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1545 Mark as externally visible.
1546 * dispnew.c (check_window_matrix_pointers): Now static.
1547 * dispnew.c (window_to_frame_vpos):
1548 * xfns.c (unwind_create_frame):
1549 * xterm.c (x_check_font): Remove unused local.
1550 * scroll.c (CHECK_BOUNDS):
1551 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1552 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1553 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1554 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1555 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1556 Now static.
1557 (debug_method_add): Use va_list and vsprintf rather than relying
1558 on undefined behavior with wrong number of arguments.
1559 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1560 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1561 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1562 since we're not interested in debugging glyphs with old libraries.
1563 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1564 GCC 4.6.0's static checking.
1565
0766b489
PE
15662011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1567
31fd4b32
PE
1568 Integer overflow and signedness fixes (Bug#8873).
1569 A few related buffer overrun fixes, too.
1570
b79e8648
PE
1571 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1572
0766b489
PE
1573 * dispextern.h (struct face.stipple):
1574 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1575 (x_bitmap_mask, x_allocate_bitmap_record)
1576 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1577 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1578 (x_create_bitmap_from_xpm_data):
1579 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1580 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1581 (.bitmaps_last):
1582 * xfaces.c (load_pixmap):
1583 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1584 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1585 (.bitmaps_last, struct x_output.icon_bitmap):
1586 Use ptrdiff_t, not int, for bitmap indexes.
1587 (x_allocate_bitmap_record): Check for size overflow.
1588 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1589
b081724f
PE
1590 Use ptrdiff_t, not int, for overlay counts.
1591 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1592 * editfns.c (overlays_around, get_pos_property):
1593 * textprop.c (get_char_property_and_overlay):
1594 * xdisp.c (next_overlay_change, note_mouse_highlight):
1595 * xfaces.c (face_at_buffer_position):
21514da7
PE
1596 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1597 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1598 (Fnext_overlay_change, Fprevious_overlay_change)
1599 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1600 Use ptrdiff_t, not int, for sizes.
21514da7 1601 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1602
3de73e5e
PE
1603 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1604
2606c57b
PE
1605 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1606 (x_session_initialize): Do not assume string length fits in int.
1607
aaafe47a
PE
1608 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1609 This is unlikely, but can occur if DPI is outlandish.
1610
2674ddc8 1611 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1612 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1613
28154962
PE
1614 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1615 * xrdb.c (magic_file_p, search_magic_path):
1616 Omit last arg SUFFIX; it was always 0. All callers changed.
1617 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1618
7de51af5
PE
1619 * xfont.c (xfont_match): Avoid need for strlen.
1620
25ed6cc3
PE
1621 * xfns.c: Don't assume strlen fits in int.
1622 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1623
4eab31dd
PE
1624 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1625 not unsigned long, as we prefer signed integers. All callers changed.
1626 Detect integer overflow in repeat count.
1627 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1628 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1629
171e2a58
PE
1630 * termcap.c: Don't assume sizes fit in int and never overflow.
1631 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1632 (gobble_line): Check for size-calculation overflow.
1633
ad39faca 1634 * minibuf.c (Fread_buffer):
6e5bb2dc 1635 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1636 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1637 Don't assume string length fits in int.
1638
52c61c22 1639 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1640 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1641
b5b8c9e5
PE
1642 * font.c: Don't assume string length fits in int.
1643 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1644 Use ptrdiff_t, not int.
ccd6111c
PE
1645 (font_intern_prop): Don't assume string length fits in int.
1646 Don't assume integer property fits in fixnum.
1647 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1648
882f0d81 1649 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1650 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1651 Reformulate so as not to need the command string.
1652 Invoke gzip -cd rather than gunzip, as it's more portable.
1653 (lock_info_type, lock_file_1, lock_file):
1654 Don't assume pid_t and time_t fit in unsigned long.
1655 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1656 (current_lock_owner): Prefer signed type for sizes.
1657 Use memcpy, not strncpy, where memcpy is what is really wanted.
1658 Don't assume (via atoi) that time_t and pid_t fit in int.
1659 Check for time_t and/or pid_t out of range, e.g., via a network share.
1660 Don't alloca where an auto var works fine.
1661
93f4cf88
PE
1662 * fileio.c: Fix some integer overflow issues.
1663 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1664 Don't assume string length fits in int.
1665 (directory_file_name): Don't assume string length fits in long.
1666 (make_temp_name): Don't assume pid fits in int, or that its print
1667 length is less than 20.
1668
f3e92b69
PE
1669 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1670
1bfdaf10
PE
1671 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1672
35016e9a
PE
1673 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1674
3d1e65a1
PE
1675 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1676 We prefer signed integers, even for size calculations.
1677
0b963a93
PE
1678 * emacs.c: Don't assume string length fits in 'int'.
1679 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1680 (main): Don't invoke strlen when not needed.
1681
573f4b54
PE
1682 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1683 (XD_DEBUG_MESSAGE): Don't waste a byte.
1684
989f33ba
PE
1685 * callproc.c (getenv_internal_1, getenv_internal)
1686 (Fgetenv_internal):
965d34eb
PE
1687 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1688
e4d29b33
PE
1689 * lread.c (invalid_syntax): Omit length argument.
1690 All uses changed. This doesn't fix a bug, but it simplifies the
1691 code away from its former Hollerith-constant appearance, and it's
1692 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1693 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1694
eb49b136
PE
1695 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1696 This didn't break anything, but it didn't help either.
1697 It's confusing to put a bogus integer in a place where the actual
1698 value does not matter.
9f62aeb1 1699 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1700 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1701
15375a22
PE
1702 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1703 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1704 implementation.
b61cc01c
PE
1705 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1706 We prefer signed types, and the value cannot exceed the EMACS_INT
1707 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1708 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1709 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1710 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1711
53b2623d
PE
1712 * indent.c (sane_tab_width): New function.
1713 (current_column, scan_for_column, Findent_to, position_indentation)
1714 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1715 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1716
51cab52b 1717 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1718
f2ed8a70
PE
1719 * lisp.h (lint_assume): New macro.
1720 * composite.c (composition_gstring_put_cache):
1721 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1722
abe80cc6
PE
1723 * editfns.c, insdel.c:
1724 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1725
b02c740e
PE
1726 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1727
ebc96716
PE
1728 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1729
b4e50fa0 1730 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1731 Use much-faster test for byte-length change.
311d5d7c 1732 Don't assume string byte-length fits in 'int'.
a4cf38e4 1733 Check that character arg fits in 'int'.
85461888 1734 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1735
c0c1ee9f
PE
1736 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1737
a498d7f4
PE
1738 * fns.c (concat): Catch string overflow earlier.
1739 Do not rely on integer wraparound.
1740
51cab52b
PE
1741 * dispextern.h (struct it.overlay_strings_charpos)
1742 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1743 * xdisp.c (forward_to_next_line_start)
1744 (back_to_previous_visible_line_start)
1745 (reseat_at_next_visible_line_start, next_element_from_buffer):
1746 Don't arbitrarily truncate the value of 'selective' to int.
1747
76031fad
PE
1748 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1749
5eb55db9
PE
1750 * composite.c: Don't truncate sizes to 'int'.
1751 (composition_gstring_p, composition_reseat_it)
1752 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1753 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1754 not EMACS_UINT, for indexes.
5eb55db9 1755
0703a717
PE
1756 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1757
d6202519
PE
1758 * buffer.c: Include <verify.h>.
1759 (struct sortvec.priority, struct sortstr.priority):
8961a454 1760 Now EMACS_INT, not int.
c20998a7 1761 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1762 (struct sortstr.size, record_overlay_string)
1763 (struct sortstrlist.size, struct sortlist.used):
1764 Don't truncate size to int.
1765 (record_overlay_string): Check for size-calculation overflow.
d6202519 1766 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1767
d5a19415
JM
17682011-06-22 Jim Meyering <meyering@redhat.com>
1769
029529ac 1770 Don't leak an XBM-image-sized buffer
d5a19415
JM
1771 * image.c (xbm_load): Free the image buffer after using it.
1772
a9041e6c
PE
17732011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1774
1775 Port to Sun C.
1776 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1777 that Sun C diagnosed.
1778 * fns.c (secure_hash): Fix pointer signedness issue.
1779 * intervals.c (static_offset_intervals): New function.
1780 (offset_intervals): Use it.
1781
7f3f739f
LL
17822011-06-21 Leo Liu <sdl.web@gmail.com>
1783
1784 * deps.mk (fns.o):
1785 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1786 sha512.h.
1787
1788 * fns.c (secure_hash): Rename from crypto_hash_function and change
1789 the first arg to accept symbols.
5b66d427 1790 (Fsecure_hash): New primitive.
7f3f739f
LL
1791 (syms_of_fns): New symbols.
1792
76147d94
DD
17932011-06-20 Deniz Dogan <deniz@dogan.se>
1794
1795 * process.c (Fset_process_buffer): Clarify return value in
1796 docstring.
1797
7d7d0045
CY
17982011-06-18 Chong Yidong <cyd@stupidchicken.com>
1799
1800 * dispnew.c (add_window_display_history): Use BVAR.
1801
1802 * xdisp.c (debug_method_add): Use BVAR.
1803 (check_window_end, dump_glyph_matrix, dump_glyph)
1804 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1805
1806 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1807 Likewise.
1808
1809 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1810 check till after the cache is created in init_frame_faces.
1811
ff2bc410
SM
18122011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1813
1814 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1815
28177add
PE
18162011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1817
dd3482fe
PE
1818 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1819 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1820 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1821
393d71f3 1822 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1823 * fileio.c (Finsert_file_contents):
1824 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1825 Remove the old (too-loose) buffer overflow checks.
1826 They weren't needed, since make_gap checks for buffer overflow.
1827 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1828 The old code merely checked for Emacs fixnum overflow, and relied
1829 on undefined (wraparound) behavior. The new code avoids undefined
1830 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1831
2e6813b0 1832 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1833 Tune. Don't use wider integers than needed. Don't use alloca.
1834 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1835
599a9e4f
PE
1836 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1837
99561444
PE
1838 * insdel.c, lisp.h (buffer_overflow): New function.
1839 (insert_from_buffer_1, replace_range, replace_range_2):
1840 * insdel.c (make_gap_larger):
1841 * editfns.c (Finsert_char):
1842 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1843
28177add
PE
1844 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1845
e69dafad
PE
18462011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1847
a7af7fde 1848 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1849
b1c46f02
PE
1850 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1851 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1852
e69dafad
PE
1853 * fileio.c: Don't assume EMACS_INT fits in off_t.
1854 (emacs_lseek): New static function.
1855 (Finsert_file_contents, Fwrite_region): Use it.
1856 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1857
566684ea
PE
1858 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1859
e6966cd6
PE
1860 * fns.c: Don't overflow int when computing a list length.
1861 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1862 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1863 truncation on 64-bit hosts. Check for QUIT every
1864 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1865 faster and is responsive enough.
1866 (Flength): Report an error instead of overflowing an integer.
1867 (Fsafe_length): Return a float if the value is not representable
1868 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1869 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1870 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1871
dd0b0efb
PE
1872 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1873 (header_size, word_size): New constants.
1874 (allocate_vectorlike): Don't check size overflow here.
1875 (allocate_vector): Check it here instead, since this is the only
1876 caller of allocate_vectorlike that could cause overflow.
1877 Check that the new vector's length is representable as a fixnum.
1878
86fe5cfe
PE
1879 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1880 The previous code was bogus. For example, next_almost_prime (32)
1881 returned 39, which is undesirable as it is a multiple of 3; and
1882 next_almost_prime (24) returned 25, which is a multiple of 5 so
1883 why was the code bothering to check for multiples of 7?
1884
80e88859
PE
1885 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1886
4a2f0ad6
PE
1887 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1888
f66c7cf8
PE
1889 Variadic C functions now count arguments with ptrdiff_t.
1890 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1891 Back then I didn't know that the Emacs coding style prefers signed int.
1892 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1893 were being counted with int, which may truncate counts on 64-bit
1894 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1895 * lisp.h (struct Lisp_Subr.function.aMANY)
1896 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1897 Arg counts are now ptrdiff_t, not size_t.
1898 All variadic functions and their callers changed accordingly.
1899 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1900 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1901 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1902 * callint.c (Fcall_interactively): Check arg count for overflow,
1903 to avoid potential buffer overrun. Use signed char, not 'int',
1904 for 'varies' array, so that we needn't bother to check its size
1905 calculation for overflow.
1906 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1907 * eval.c (apply_lambda):
1908 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1909 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1910 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1911
a1759b76
PE
1912 * callint.c (Fcall_interactively): Don't use index var as event count.
1913
d96be9fc
PE
1914 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1915 * mem-limits.h (SIZE): Remove; no longer used.
1916
a690a978 1917 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1918
578c21e6
PE
1919 Remove unnecessary casts.
1920 * xterm.c (x_term_init):
1921 * xfns.c (x_set_border_pixel):
1922 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1923 These aren't needed now that we assume ANSI C.
1924
96f53c6c
PE
1925 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1926 It's more likely to cause problems (due to unsigned overflow)
1927 than to cure them.
1928
83c77d31
PE
1929 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1930
ee2079f1
PE
1931 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1932
6da65536
PE
1933 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1934
7147c4a4
PE
1935 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1936
193e32d9
PE
1937 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1938
e5533da6
PE
1939 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1940
9910e595
PE
1941 GLYPH_CODE_FACE returns EMACS_INT, not int.
1942 * dispextern.h (merge_faces):
1943 * xfaces.c (merge_faces):
01103c44
PE
1944 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1945 Don't assume EMACS_INT fits in int.
9910e595 1946
2638320e
PE
1947 * character.h (CHAR_VALID_P): Remove unused parameter.
1948 * fontset.c, lisp.h, xdisp.c: All uses changed.
1949
045eb8d9
PE
1950 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1951
c1f134b5
PE
1952 * fns.c (concat): Minor tuning based on overflow analysis.
1953 This doesn't fix any bugs. Use int to hold character, instead
1954 of constantly refetching from Emacs object. Use XFASTINT, not
1955 XINT, for value known to be a character. Don't bother comparing
1956 a single byte to 0400, as it's always less.
1957
395fcb93 1958 * floatfns.c (Fexpt):
327eeec8
PE
1959 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1960
abbd3d23
PE
1961 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1962 for characters.
1963
684a03ef
PE
1964 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1965
0fed43f3
PE
1966 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1967 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1968 incorrectly succeed when S was a string, because 4294967386 was
1969 truncated before it was used.
1970
8fd02eb7
PE
1971 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1972 Otherwise, an out-of-range integer could cause undefined behavior
1973 on a 64-bit host.
1974
f8c86b69
PE
1975 * composite.c: Use int, not EMACS_INT, for characters.
1976 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1977 EMACS_INT, for values that are known to be in character range.
1978 This doesn't fix any bugs but is the usual style inside Emacs and
1979 may generate better code on 32-bit machines.
1980
34206dd2
PE
1981 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1982 This is for reasons similar to the recent CHAR_STRING fix.
1983 * charset.c (Fencode_char): Check that character arg is actually
1984 a character. Pass an int to ENCODE_CHAR.
1985 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1986 wider than 'int', as a compile-time check to prevent future regressions
1987 in this area.
1988
c5958d4c 1989 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1990
1991 Make sure a 64-bit char is never passed to CHAR_STRING.
1992 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1993 by silently ignoring the top 32 bits, allowing some values
1994 that were far too large to be valid characters.
1995 * character.h: Include <verify.h>.
1996 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1997 arguments are no wider than unsigned, as a compile-time check
1998 to prevent future regressions in this area.
1999 * data.c (Faset):
01103c44 2000 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2001 (Fsubst_char_in_region):
2002 * fns.c (concat):
2003 * xdisp.c (decode_mode_spec_coding):
2004 Adjust to CHAR_STRING's new requirement.
2005 * editfns.c (Finsert_char, Fsubst_char_in_region):
2006 * fns.c (concat): Check that character args are actually
2007 characters. Without this test, these functions did the wrong
2008 thing with wildly out-of-range values on 64-bit hosts.
2009
d37ca623
PE
2010 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2011 These casts should not be needed on 32-bit hosts, either.
2012 * keyboard.c (read_char):
2013 * lread.c (Fload): Remove casts to unsigned.
2014
ea204efb
PE
2015 * lisp.h (UNSIGNED_CMP): New macro.
2016 This fixes comparison bugs on 64-bit hosts.
2017 (ASCII_CHAR_P): Use it.
2018 * casefiddle.c (casify_object):
01103c44 2019 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2020 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2021 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2022 * dispextern.h (FACE_FROM_ID):
2023 * keyboard.c (read_char): Use UNSIGNED_CMP.
2024
41cb286c
PE
2025 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2026 not to EMACS_INT, to avoid GCC warning.
2027
4a1b9832
PE
2028 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2029
55daad71
PE
2030 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2031 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2032 isn't needed on 32-bit machines.
8f95c75c 2033
01103c44
PE
2034 * buffer.c (Fgenerate_new_buffer_name):
2035 Use EMACS_INT for count, not int.
0ceccced 2036 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2037
2038 * data.c (Qcompiled_function): Now static.
2039
c6f072e7
PE
2040 * window.c (window_body_lines): Now static.
2041
20ce5912
PE
2042 * image.c (gif_load): Rename local to avoid shadowing.
2043
9c4c5f81
PE
2044 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2045 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2046 * alloc.c (make_save_value): Integer argument is now of type
2047 ptrdiff_t, not int.
2048 (mark_object): Use ptrdiff_t, not int.
2049 * lisp.h (pD): New macro.
2050 * print.c (print_object): Use it.
2051
c0c5c8ae
PE
2052 * alloc.c: Use EMACS_INT, not int, to count objects.
2053 (total_conses, total_markers, total_symbols, total_vector_size)
2054 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2055 (total_free_floats, total_floats, total_free_intervals)
2056 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2057 Now EMACS_INT, not int. All uses changed.
2058 (Fgarbage_collect): Compute overall total using a double, so that
2059 integer overflow is less likely to be a problem. Check for overflow
2060 when converting back to an integer.
5a25e253
PE
2061 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2062 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2063 These were 'int' variables that could overflow on 64-bit hosts;
2064 they were never used, so remove them instead of repairing them.
211a0b2a 2065 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2066 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2067 Previously, this ceilinged at INT_MAX, but that doesn't work on
2068 64-bit machines.
e46bb31a 2069 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2070
c78baabf 2071 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2072 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2073 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2074 when a (possibly-narrower) signed value would do just as well.
2075 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2076
c9d624c6
PE
2077 * alloc.c: Catch some string size overflows that we were missing.
2078 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2079 for convenience in STRING_BYTES_MAX.
2080 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2081 The definition here is exact; the one in lisp.h was approximate.
2082 (allocate_string_data): Check for string overflow. This catches
2083 some instances we weren't catching before. Also, it catches
2084 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2085 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2086 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2087
c9d624c6
PE
2088 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2089 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2090 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2091
353032ce
PE
2092 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2093
2bccce07
PE
2094 * alloc.c (Fmake_string): Check for out-of-range init.
2095
0ac30604
SM
20962011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2097
2098 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2099
c195f2de
JD
21002011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2101
2102 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2103 xg_get_default_scrollbar_width.
2104
2105 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2106 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2107 (style_changed_cb): Call update_theme_scrollbar_width and call
2108 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2109 all frames (Bug#8505).
2110 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2111 Call gtk_window_set_resizable if HAVE_GTK3.
2112 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2113 and height if HAVE_GTK3 (Bug#8505).
2114 (scroll_bar_width_for_theme): New variable.
2115 (update_theme_scrollbar_width): New function.
2116 (xg_get_default_scrollbar_width): Move code to
2117 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2118 (xg_initialize): Call update_theme_scrollbar_width.
2119
2120 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2121
2122 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2123
e10ac9f1
MR
21242011-06-12 Martin Rudalics <rudalics@gmx.at>
2125
2126 * frame.c (make_frame): Call other_buffer_safely instead of
2127 other_buffer.
2128
2129 * window.c (temp_output_buffer_show): Call display_buffer with
2130 second argument Vtemp_buffer_show_specifiers and reset latter
2131 immediately after the call.
2132 (Vtemp_buffer_show_specifiers): New variable.
2133 (auto_window_vscroll_p, next_screen_context_lines)
2134 (Vscroll_preserve_screen_position): Remove leading asterisks from
2135 doc-strings.
2136
2d3c217e 21372011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2138
7b7f97e8 2139 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2140 * buffer.c (Qclone_number): Remove for now, as it's unused.
2141 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2142 (record_buffer): Remove unused local.
2143 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2144 (set_frame_buffer_list): Remove; unused.
2145 * frame.h (other_visible_frames): Remove decl.
2146 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2147 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2148 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2149 if HAVE_GPM.
2150 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2151 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2152 Define only if HAVE_GPM.
2153 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2154 (update_hints_inhibit): Remove; never set. All uses removed.
2155 * widgetprv.h (emacsFrameClassRec): Remove decl.
2156 * window.c (delete_deletable_window): Now returns void, since it
2157 wasn't returning anything.
2158 (compare_window_configurations): Remove unused locals.
2159 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2160 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2161 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2162 the same widths as pointers. This follows up on the 2011-05-06 patch.
2163 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2164 * xterm.h: Likewise.
2165 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2166
1384b89e
JB
21672011-06-12 Juanma Barranquero <lekktu@gmail.com>
2168
2169 * makefile.w32-in: Update dependencies.
2170 (LISP_H): Add lib/intprops.h.
2171
1100a63c
CY
21722011-06-11 Chong Yidong <cyd@stupidchicken.com>
2173
2174 * image.c (gif_load): Add animation frame delay to the metadata.
2175 (syms_of_image): Use DEFSYM. New symbol `delay'.
2176
6198ccd0
MR
21772011-06-11 Martin Rudalics <rudalics@gmx.at>
2178
2179 * window.c (delete_deletable_window): Re-add.
2180 (Fset_window_configuration): Rewrite to handle dead buffers and
2181 consequently deletable windows.
2182 (window_tree, Fwindow_tree): Remove. Supply functionality in
2183 window.el.
2184 (compare_window_configurations): Simplify code.
2185
b6e3633c
AS
21862011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2187
1ab0dee5
AS
2188 * image.c (imagemagick_load_image): Fix type mismatch.
2189 (Fimagemagick_types): Likewise.
2190
b6e3633c
AS
2191 * window.h (replace_buffer_in_windows): Declare.
2192
9397e56f
MR
21932011-06-11 Martin Rudalics <rudalics@gmx.at>
2194
2195 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2196 Qclone_number. Remove external declaration of Qdelete_window.
2197 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2198 code.
640c8776
SM
2199 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2200 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
2201 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2202 buffer list implementation.
2203 (other_buffer_safely): New function.
2204 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2205 calls to replace_buffer_in_windows and
2206 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2207 if allowed.
2208 (record_buffer): Inhibit quitting and rewrite using quittable
2209 functions. Run Qbuffer_list_update_hook if allowed.
2210 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
2211 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2212 Move switch-to-buffer to window.el.
9397e56f
MR
2213 (bury-buffer): Move to window.el.
2214 (Vbuffer_list_update_hook): New variable.
2215
2216 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2217 section.
2218
2219 * window.h (resize_frame_windows): Move up in code.
2220 (Fwindow_frame): Remove EXFUN.
2221 (replace_buffer_in_all_windows): Remove prototype.
2222 (replace_buffer_in_windows_safely): Add prototype.
2223
2224 * window.c: Declare Qdelete_window static again. Move down
2225 declaration of select_count.
2226 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2227 (Fother_window): Move to window.el.
2228 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2229 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2230 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2231 window.el.
2232 (replace_buffer_in_windows): Implement by calling
2233 Qreplace_buffer_in_windows.
2234 (replace_buffer_in_all_windows): Remove with some functionality
2235 moved into replace_buffer_in_windows_safely.
2236 (replace_buffer_in_windows_safely): New function.
2237 (select_window_norecord, select_frame_norecord): Move in front
2238 of run_window_configuration_change_hook. Remove now obsolete
2239 declarations.
640c8776
SM
2240 (Fset_window_buffer): Rewrite doc-string.
2241 Call Qrecord_window_buffer.
9397e56f
MR
2242 (keys_of_window): Move binding for other-window to window.el.
2243
b50691aa
CY
22442011-06-11 Chong Yidong <cyd@stupidchicken.com>
2245
2246 * dispextern.h (struct image): Replace data member, whose int_val
2247 and ptr_val fields were not used by anything, with a single
2248 lisp_val object.
2249
2250 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2251 (gif_clear_image, gif_load, imagemagick_load_image)
2252 (gs_clear_image, gs_load): Callers changed.
2253
3f754b86
PE
22542011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2255
cca69397
PE
2256 * buffer.h: Include <time.h>, for time_t.
2257 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2258
109e28d0
PE
2259 Fix minor problems found by static checking.
2260
60737f02
PE
2261 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2262
4b66faf3
PE
2263 Make identifiers static if they are not used in other modules.
2264 * data.c (Qcompiled_function, Qframe, Qvector):
2265 * image.c (QimageMagick, Qsvg):
2266 * minibuf.c (Qmetadata):
2267 * window.c (resize_window_check, resize_root_window): Now static.
2268 * window.h (resize_window_check, resize_root_window): Remove decls.
2269
109e28d0
PE
2270 * window.c (window_deletion_count, delete_deletable_window):
2271 Remove; unused.
46a4ce9e
PE
2272 (window_body_lines): Now static.
2273 (Fdelete_other_windows_internal): Mark vars as initialized.
2274 Make sure 'resize_failed' is initialized.
2275 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2276 (resize_window_apply): Remove unused local.
2277 * window.h (delete_deletable_window): Remove decl.
2278
109e28d0 2279 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2280 (imagemagick_load_image): Fix pointer signedness problem by changing
2281 last arg from unsigned char * to char *. All uses changed.
2282 Also, fix a local for similar reasons.
2283 Remove unused locals. Remove locals to avoid shadowing.
2284 (fn_rsvg_handle_free): Remove; unused.
2285 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2286 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2287
3f754b86
PE
2288 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2289
2547adb1
CY
22902011-06-10 Chong Yidong <cyd@stupidchicken.com>
2291
2292 * image.c (gif_load): Fix omitted cast error introduced by
2293 2011-06-06 change.
2294
2c8e37d4
MR
22952011-06-10 Martin Rudalics <rudalics@gmx.at>
2296
2297 * window.h (resize_proportionally, orig_total_lines)
2298 (orig_top_line): Remove from window structure.
2299 (set_window_height, set_window_width, change_window_heights)
2300 (Fdelete_window): Remove prototypes.
2301 (resize_frame_windows): Remove duplicate declaration.
2302
440a42e3
EZ
23032011-06-10 Eli Zaretskii <eliz@gnu.org>
2304
2305 * window.h (resize_frame_windows, resize_window_check)
2306 (delete_deletable_window, resize_root_window)
2307 (resize_frame_windows): Declare prototypes.
2308
2309 * window.c (resize_window_apply): Make definition be "static" to
2310 match the prototype.
2311
562dd5e9
MR
23122011-06-10 Martin Rudalics <rudalics@gmx.at>
2313
2314 * window.c: Remove declarations of Qwindow_size_fixed,
2315 window_min_size_1, window_min_size_2, window_min_size,
2316 size_window, window_fixed_size_p, enlarge_window, delete_window.
2317 Remove static from declaration of Qdelete_window, it's
2318 temporarily needed by Fbury_buffer.
2319 (replace_window): Don't assign orig_top_line and
2320 orig_total_lines.
2321 (Fdelete_window, delete_window): Remove. Window deletion is
2322 handled by window.el.
640c8776
SM
2323 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2324 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
2325 (Fdelete_other_windows): Remove. Deleting other windows is
2326 handled by window.el.
2327 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2328 handled in window.el.
2329 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2330 Window minimum sizes are handled in window.el.
2331 (shrink_windows, size_window, set_window_height)
2332 (set_window_width, change_window_heights, window_height)
2333 (window_width, CURBEG, CURSIZE, enlarge_window)
2334 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2335 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2336 handled in window.el.
2337 (make_dummy_parent): Rename to make_parent_window and give it a
2338 second argument horflag.
2339 (make_window): Don't set resize_proportionally any more.
2340 (Fsplit_window): Remove. Windows are split in window.el.
2341 (save_restore_action, save_restore_orig_size)
2342 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2343 Resize mini windows in window.el.
2344 (grow_mini_window, shrink_mini_window): Implement by calling
2345 Qresize_root_window_vertically, resize_window_check and
2346 resize_window_apply.
640c8776
SM
2347 (saved_window, Fset_window_configuration, save_window_save):
2348 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
2349 resize_proportionally.
2350 (window_min_height, window_min_width): Move to window.el.
2351 (keys_of_window): Move bindings for delete-other-windows,
2352 split-window, delete-window and enlarge-window to window.el.
2353
2354 * buffer.c: Temporarily extern Qdelete_window.
2355 (Fbury_buffer): Temporarily call Qdelete_window instead of
2356 Fdelete_window (Fbury_buffer will move to window.el soon).
2357
2358 * frame.c (set_menu_bar_lines_1): Remove code handling
2359 orig_top_line and orig_total_lines.
2360
2361 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2362 set_window_height but set heights directly.
2363 (change_frame_size_1): Use resize_frame_windows.
2364
2365 * xdisp.c (init_xdisp): Don't use set_window_height but set
2366 heights directly.
2367
640c8776
SM
2368 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2369 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
2370 run_window_configuration_change_hook.
2371
2372 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2373 instead of change_window_heights and run
2374 run_window_configuration_change_hook.
2375
1a13852e
MR
23762011-06-09 Martin Rudalics <rudalics@gmx.at>
2377
2378 * window.c (replace_window): Rename second argument REPLACEMENT to
2379 NEW. New third argument SETFLAG. Rewrite.
2380 (delete_window, make_dummy_parent): Call replace_window with
2381 third argument 1.
2382 (window_list_1): Move down in code.
2383 (run_window_configuration_change_hook): Move set_buffer part
2384 before select_frame_norecord part in order to unwind correctly.
2385 Rename count1 to count.
2386 (recombine_windows, delete_deletable_window, resize_root_window)
2387 (Fdelete_other_windows_internal)
2388 (Frun_window_configuration_change_hook, make_parent_window)
2389 (resize_window_check, resize_window_apply, Fresize_window_apply)
2390 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
2391 (Fdelete_window_internal, Fresize_mini_window_internal):
2392 New functions.
1a13852e
MR
2393 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2394
f3d1777e
MR
23952011-06-08 Martin Rudalics <rudalics@gmx.at>
2396
496e208e
MR
2397 * window.h (window): Add some new members to window structure -
2398 normal_lines, normal_cols, new_total, new_normal, clone_number,
2399 splits, nest, prev_buffers, next_buffers.
2400 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2401 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2402
f3d1777e
MR
2403 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2404 Remove.
496e208e
MR
2405 (make_dummy_parent): Set new members of windows structure.
2406 (make_window): Move down in code. Handle new members of window
2407 structure.
2408 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2409 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2410 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2411 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
2412 (Fset_window_next_buffers, Fset_window_clone_number):
2413 New functions.
496e208e
MR
2414 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2415 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2416 Doc-string fixes.
2417 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2418 Argument WINDOW can be now internal window too.
2419 (Fwindow_use_time): Move up in code.
2420 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2421 Rewrite doc-string.
2422 (Fset_window_configuration, saved_window)
2423 (Fcurrent_window_configuration, save_window_save): Handle new
2424 members of window structure.
b9e809c2
MR
2425 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2426 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2427 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2428 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2429 Qget_mru_window, Qresize_root_window,
2430 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2431 Qauto_buffer_name; staticpro them.
f3d1777e 2432
abde8f8c
MR
24332011-06-07 Martin Rudalics <rudalics@gmx.at>
2434
2435 * window.c (Fwindow_total_size, Fwindow_left_column)
2436 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2437 (Fwindow_list_1): New functions.
2438 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
2439 (Fwindow_width, Fscroll_left, Fscroll_right):
2440 Use window_body_cols instead of window_box_text_cols.
2441 (delete_window, Fset_window_configuration):
2442 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
2443 (delete_all_subwindows): Take a window as argument and not a
2444 structure. Rewrite.
190b47e6
MR
2445 (window_loop): Remove handling of GET_LRU_WINDOW and
2446 GET_LARGEST_WINDOW.
2447 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2448
2449 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2450 window_box_text_cols. delete_all_subwindows now takes a
2451 Lisp_Object as argument.
abde8f8c 2452
640c8776
SM
2453 * indent.c (compute_motion, Fcompute_motion):
2454 Use window_body_cols instead of window_box_text_cols.
abde8f8c 2455
fa8a67e6
MR
2456 * frame.c (delete_frame): Call delete_all_subwindows with root
2457 window as argument.
2458
a54e3482
DC
24592011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2460
2461 * fns.c (Fputhash): Document return value.
2462
60002bf5
CY
24632011-06-06 Chong Yidong <cyd@stupidchicken.com>
2464
2465 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2466
0c671da6 24672011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2468
b862a52a 2469 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2470
be44ca6c
PE
2471 Check for overflow when converting integer to cons and back.
2472 * charset.c (Fdefine_charset_internal, Fdecode_char):
2473 Use cons_to_unsigned to catch overflow.
2474 (Fencode_char): Use INTEGER_TO_CONS.
2475 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2476 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2477 * data.c (long_to_cons, cons_to_long): Remove.
2478 (cons_to_unsigned, cons_to_signed): New functions.
2479 These signal an error for invalid or out-of-range values.
2480 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2481 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2482 * font.c (Ffont_variation_glyphs):
2483 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2484 * lisp.h: Include <intprops.h>.
2485 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2486 (cons_to_signed, cons_to_unsigned): New decls.
2487 (long_to_cons, cons_to_long): Remove decls.
2488 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2489 (Fprimitive_undo): Use CONS_TO_INTEGER.
2490 * xfns.c (Fx_window_property): Likewise.
2491 * xselect.c: Include <limits.h>.
2492 (x_own_selection, selection_data_to_lisp_data):
2493 Use INTEGER_TO_CONS.
2494 (x_handle_selection_request, x_handle_selection_clear)
2495 (x_get_foreign_selection, Fx_disown_selection_internal)
2496 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2497 (lisp_data_to_selection_data): Use cons_to_unsigned.
2498 (x_fill_property_data): Use cons_to_signed.
2499 Report values out of range.
2500
d1f3d2af
PE
2501 Check for buffer and string overflow more precisely.
2502 * buffer.h (BUF_BYTES_MAX): New macro.
2503 * lisp.h (STRING_BYTES_MAX): New macro.
2504 * alloc.c (Fmake_string):
2505 * character.c (string_escape_byte8):
2506 * coding.c (coding_alloc_by_realloc):
2507 * doprnt.c (doprnt):
2508 * editfns.c (Fformat):
2509 * eval.c (verror):
2510 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2511 since they may not be the same number.
2512 * editfns.c (Finsert_char):
2513 * fileio.c (Finsert_file_contents):
2514 Likewise for BUF_BYTES_MAX.
2515
dd52fcea
PE
2516 * image.c: Use ptrdiff_t, not int, for sizes.
2517 (slurp_file): Switch from int to ptrdiff_t.
2518 All uses changed.
2519 (slurp_file): Check that file size fits in both size_t (for
2520 malloc) and ptrdiff_t (for sanity and safety).
2521
7f9bbdbb
PE
2522 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2523 if b->modtime has its maximal value.
2524
dfe18f82
PE
2525 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2526
84acfcf0
PE
2527 Don't assume time_t can fit into int.
2528 * buffer.h (struct buffer.modtime): Now time_t, not int.
2529 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2530 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2531
ccd9a01a
PE
2532 Minor fixes for signed vs unsigned integers.
2533 * character.h (MAYBE_UNIFY_CHAR):
2534 * charset.c (maybe_unify_char):
2535 * keyboard.c (read_char, reorder_modifiers):
2536 XINT -> XFASTINT, since the integer must be nonnegative.
2537 * ftfont.c (ftfont_spec_pattern):
2538 * keymap.c (access_keymap, silly_event_symbol_error):
2539 XUINT -> XFASTINT, since the integer must be nonnegative.
2540 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2541 since it makes no difference and we prefer signed.
2542 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2543 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2544 nonnegative.
2545
d6d100dd
SM
25462011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2547
2548 * window.h (Fwindow_frame): Declare.
2549
2b6148e4
PE
25502011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2551
2552 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2553 (SPARE_MEMORY): Always define.
2554 (LARGE_REQUEST): Remove.
2555 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2556
f230ecc9
MR
25572011-06-06 Martin Rudalics <rudalics@gmx.at>
2558
727e958e
MR
2559 * lisp.h: Move EXFUNS for Fframe_root_window,
2560 Fframe_first_window and Fset_frame_selected_window to window.h.
2561
2562 * window.h: Move EXFUNS for Fframe_root_window,
2563 Fframe_first_window and Fset_frame_selected_window here from
2564 lisp.h.
2565
2566 * frame.c (Fwindow_frame, Fframe_first_window)
2567 (Fframe_root_window, Fframe_selected_window)
2568 (Fset_frame_selected_window): Move to window.c.
2569 (Factive_minibuffer_window): Move to minibuf.c.
2570 (Fother_visible_frames_p): New function.
2571
2572 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2573
f230ecc9
MR
2574 * window.c (decode_window, decode_any_window): Move up in code.
2575 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2576 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2577 (Fwindow_buffer): Move up and rewrite doc-string.
2578 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2579 (Fwindow_prev): New functions.
727e958e
MR
2580 (Fwindow_frame): Move here from frame.c. Accept any window as
2581 argument.
2582 (Fframe_root_window, Fframe_first_window)
2583 (Fframe_selected_window): Move here from frame.c. Accept frame
2584 or arbitrary window as argument. Update doc-strings.
2585 (Fminibuffer_window): Move up in code.
2586 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2587 (Fset_frame_selected_window): Move here from frame.c.
2588 Marginal rewrite.
727e958e
MR
2589 (Fselected_window, select_window, Fselect_window): Move up in
2590 code. Minor doc-string fixes.
f230ecc9 2591
4d09bcf6
PE
25922011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2593
2594 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2595 Do not assume that spare memory exists; that assumption is valid
2596 only if SYSTEM_MALLOC.
2597 (LARGE_REQUEST): New macro, so that the issue of large requests
2598 is separated from the issue of spare memory.
2599
810928a2
AS
26002011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2601
172418ad
AS
2602 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2603 format. (Bug#8806)
2604
43f862f7
AS
2605 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2606
810928a2
AS
2607 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2608 before statements.
2609
a059fe24
JD
26102011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2611
2612 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2613
2614 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2615
2616 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2617 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2618
989bf368
JB
26192011-06-05 Juanma Barranquero <lekktu@gmail.com>
2620
2621 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2622
4b80f674
CY
26232011-06-04 Chong Yidong <cyd@stupidchicken.com>
2624
2625 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2626 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2627 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2628 New error handlers.
4b80f674
CY
2629 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2630 Obey Vx_select_enable_clipboard_manager. Catch errors in
2631 x_clipboard_manager_save (Bug#8779).
2632 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2633 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2634
99a33b77 26352011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2636
2637 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2638
99a33b77 26392011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2640
2641 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2642 in the current matrix if keep_current_p is non-zero.
2643
8264569d
EZ
26442011-06-04 Eli Zaretskii <eliz@gnu.org>
2645
2646 * bidi.c (bidi_level_of_next_char): Fix last change.
2647
57f97249
EZ
26482011-06-03 Eli Zaretskii <eliz@gnu.org>
2649
fec2107c 2650 Support bidi reordering of text covered by display properties.
57f97249 2651
fec2107c
EZ
2652 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2653 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2654 (bidi_cache_search, bidi_cache_iterator_state)
2655 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2656 (bidi_level_of_next_char, bidi_move_to_visually_next):
2657 Support character positions inside a run of characters covered by a
fec2107c
EZ
2658 display string.
2659 (bidi_paragraph_init, bidi_resolve_explicit_1)
2660 (bidi_level_of_next_char): Call bidi_fetch_char and
2661 bidi_fetch_char_advance instead of FETCH_CHAR and
2662 FETCH_CHAR_ADVANCE.
2663 (bidi_init_it): Initialize new members.
2664 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2665 definitions.
2666 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2667 instead of using explicit *_CHAR codes.
d6d100dd
SM
2668 (bidi_resolve_explicit, bidi_resolve_weak):
2669 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2670 bidirectional text is supported only in multibyte buffers.
2671 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2672 it to initialize the frame_window_p member of struct bidi_it.
2673 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2674 (bidi_resolve_explicit, bidi_resolve_weak)
2675 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2676 bidi_it->nchars is non-positive.
2677 (bidi_level_of_next_char): Don't try to lookup the cache for the
2678 next/previous character if nothing is cached there yet, or if we
2679 were just reseat()'ed to a new position.
c40e2fb2 2680
0e14fe90
EZ
2681 * xdisp.c (set_cursor_from_row): Set start and stop points
2682 according to the row's direction when priming the loop that looks
2683 for the glyph on which to display cursor.
2684 (single_display_spec_intangible_p): Function deleted.
2685 (display_prop_intangible_p): Reimplement to call
2686 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2687 Accept 3 additional arguments needed by handle_display_spec.
2688 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2689 values: lists, `(when COND...)' forms, etc.
2690 (single_display_spec_string_p): Support property values that are
2691 lists with the argument STRING its top-level element.
2692 (display_prop_string_p): Fix the condition for processing a
2693 property that is a list to be consistent with handle_display_spec.
fec2107c 2694 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2695 last portion of handle_display_prop.
2696 (compute_display_string_pos): Accept additional argument
2697 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2698 value of a `display' property is a "replacing spec".
2699 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2700 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2701 the display property, but just return a value indicating whether
2702 the display property will replace the characters it covers.
2703 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2704 frame_window_p members of struct bidi_it.
d6d100dd
SM
2705 (compute_display_string_pos, compute_display_string_end):
2706 New functions.
fec2107c
EZ
2707 (push_it): Accept second argument POSITION, where pop_it should
2708 jump to continue iteration.
2709 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2710
fec2107c
EZ
2711 * keyboard.c (adjust_point_for_property): Adjust the call to
2712 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2713
2714 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2715 (bidi_init_it): Update prototypes.
2716 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2717 (compute_display_string_pos, compute_display_string_end):
2718 Declare prototypes.
fec2107c
EZ
2719 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2720 EMACS_INT.
fc6f18ce 2721
40087514 27222011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2723
57f53182
PE
2724 Malloc failure behavior now depends on size of allocation.
2725 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2726 * lisp.h: Change signatures accordingly.
2727 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2728 All callers changed. (Bug#8762)
2729
2730 * gnutls.c: Use Emacs's memory allocators.
2731 Without this change, the gnutls library would invoke malloc etc.
2732 directly, which causes problems on non-SYNC_INPUT hosts, and which
2733 runs afoul of improving memory_full behavior. (Bug#8761)
2734 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2735 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2736 xfree instead of the default malloc, realloc, free.
2737 (Fgnutls_boot): No need to check for memory allocation failure,
2738 since xmalloc does that for us.
2739
ac32cd99 2740 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2741 * category.c (hash_get_category_set):
2742 * ccl.c (ccl_driver):
2743 * charset.c (Fdefine_charset_internal):
2744 * charset.h (struct charset.hash_index):
2745 * composite.c (get_composition_id, gstring_lookup_cache)
2746 (composition_gstring_put_cache):
2747 * composite.h (struct composition.hash_index):
2748 * dispextern.h (struct image.hash):
2749 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2750 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2751 (hashfn_equal, hashfn_user_defined, make_hash_table)
2752 (maybe_resize_hash_table, hash_lookup, hash_put)
2753 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2754 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2755 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2756 * image.c (make_image, search_image_cache, lookup_image)
2757 (xpm_put_color_table_h):
2758 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2759 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2760 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2761 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2762 * alloc.c (allocate_vectorlike):
2763 Check for overflow in vector size calculations.
2764 * ccl.c (ccl_driver):
2765 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2766 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2767 need to be updated by these changes.
40087514
PE
2768 * fns.c (make_hash_table, maybe_resize_hash_table):
2769 Check for integer overflow with large hash tables.
0de4bb68
PE
2770 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2771 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2772 (SXHASH_REDUCE): New macro.
2773 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2774 Use it instead of discarding useful hash info with large hash values.
2775 (sxhash_float): New function.
2776 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2777 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2778 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2779 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2780 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2781 Adjust signatures to match updated version of code.
2782 (consing_since_gc): Now EMACS_INT, since a single hash table can
2783 use more than INT_MAX bytes.
2784
698d32e2
DN
27852011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2786
2787 Make it possible to build with GCC-4.6+ -O2 -flto.
2788
2789 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2790
fd6fa53f
SM
27912011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2792
2793 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2794 Call minibuffer-inactive-mode.
2795
864db017
JB
27962011-05-31 Juanma Barranquero <lekktu@gmail.com>
2797
2798 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2799 Update dependencies.
2800
2ad0baf4
DN
28012011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2802
2803 * data.c (init_data): Remove code for UTS, this system is not
2804 supported anymore.
2805
4fcc2638
DN
28062011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2807
2808 Don't force ./temacs to start in terminal mode.
2809
2810 * frame.c (make_initial_frame): Initialize faces in all cases, not
2811 only when CANNOT_DUMP is defined.
2812 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2813
c56e0fd5
DN
28142011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2815
2816 * dispnew.c (add_window_display_history): Use const for the string
2817 pointer. Remove declaration, not needed.
2818
333d54da 28192011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2820
55d4c1b2 2821 Use 'inline', not 'INLINE'.
333d54da 2822 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2823 * alloc.c, fontset.c (INLINE): Remove.
2824 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2825 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2826 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2827 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2828 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2829
738db178
DN
28302011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2831
2832 Make it possible to run ./temacs.
2833
2834 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2835 syms_of_callproc does the same thing. Remove test for
2836 "initialized", do it in the caller.
2837 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2838
620c53a6
SM
28392011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2840
2841 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2842 (read_minibuf): Use get_minibuffer.
2843 (syms_of_minibuf): Use DEFSYM.
2844 (Qmetadata): New var.
2845 * data.c (Qbuffer): Don't make it static.
2846 (syms_of_data): Use DEFSYM.
2847
e003a292
PE
28482011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2849
2850 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2851 (CCL_CODE_MIN): New macro.
2852
ed008a6d
PE
28532011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2854
3687c2ef
PE
2855 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2856
ed008a6d
PE
2857 * eval.c (Qdebug): Now static.
2858 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2859 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2860 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2861
d66c4c7c
CY
28622011-05-29 Chong Yidong <cyd@stupidchicken.com>
2863
2864 * image.c: Various fixes to ImageMagick code comments.
2865 (Fimagemagick_types): Doc fix.
2866
5fbc2025
PE
28672011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2868
0196f88a
PE
2869 Minor fixes prompted by GCC 4.6.0 warnings.
2870
2871 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2872
5fbc2025
PE
2873 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2874 (x_clipboard_manager_save_all): Move extern decl to ...
2875 * xterm.h: ... here, so that it can be checked for consistency.
2876
1dd3c2d9
CY
28772011-05-29 Chong Yidong <cyd@stupidchicken.com>
2878
2879 * xselect.c (x_clipboard_manager_save_frame)
2880 (x_clipboard_manager_save_all): New functions.
2881 (Fx_clipboard_manager_save): Lisp function deleted.
2882
2883 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2884 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2885
2886 * xterm.h: Update prototype.
2887
5ba6571d
WX
28882011-05-28 William Xu <william.xwl@gmail.com>
2889
2890 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2891 exiting (Bug#8239).
2892
3eaff834
JM
28932011-05-28 Jim Meyering <meyering@redhat.com>
2894
e1900994 2895 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2896 * fns.c (to_uchar): Define.
2897 (crypto_hash_function): Use it to convert some newly-signed
2898 variables to unsigned, to avoid sign-extension bugs. For example,
2899 without this change, (md5 "truc") would evaluate to
2900 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2901 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2902 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2903
0f6990a7
PE
29042011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2905
2906 Integer overflow fixes.
c8a9ca5a 2907
08686060
PE
2908 * dbusbind.c: Serial number integer overflow fixes.
2909 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2910 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2911 to hold a serial number that is too large for a fixnum.
2912 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2913 Check for serial numbers out of range. Decode any serial number
59568bf0 2914 that was so large that it became a float. (Bug#8722)
08686060 2915
2d1fc3c7
PE
2916 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2917 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2918 Use XFASTINT rather than XUINT when numbers are nonnegative.
2919 (xd_append_arg, Fdbus_method_return_internal):
2920 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2921 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2922 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2923 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2924 (Bug#8722)
2d1fc3c7 2925
c8a9ca5a
PE
2926 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2927
519e1d69
PE
2928 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2929
30569699
PE
2930 ccl: add integer overflow checks
2931 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2932 (IN_INT_RANGE): New macros.
2933 (ccl_driver): Use them to check for integer overflow when
2934 decoding a CCL program. Many of the new checks are whether XINT (x)
2935 fits in int; it doesn't always, on 64-bit hosts. The new version
2936 doesn't catch all possible integer overflows, but it's an
847044ea 2937 improvement. (Bug#8719)
30569699 2938
c11285dc
PE
2939 * alloc.c (make_event_array): Use XINT, not XUINT.
2940 There's no need for unsigned here.
2941
fdccd48e
PE
2942 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2943 This follows up to the 2011-05-06 change that substituted uintptr_t
2944 for EMACS_INT. This case wasn't caught back then.
2945
37910ab2
PE
2946 Rework Fformat to avoid integer overflow issues.
2947 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2948 now (part of C89). Include <verify.h>.
2949 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2950 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2951 (Fformat): Avoid the prepass trying to compute sizes; it was only
2952 approximate and thus did not catch overflow reliably. Instead, walk
2953 through the format just once, formatting and computing sizes as we go,
2954 checking for integer overflow at every step, and allocating a larger
2955 buffer as needed. Keep track separately whether the format is
2956 multibyte. Keep only the most-recently calculated precision, rather
2957 than them all. Record whether each argument has been converted to
2958 string. Use EMACS_INT, not int, for byte and char and arg counts.
2959 Support field widths and precisions larger than INT_MAX. Avoid
2960 sprintf's undefined behavior with conversion specifications such as %#d
2961 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2962 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2963 formatting out-of-range floating point numbers with int
9173deec 2964 formats. (Bug#8668)
37910ab2 2965
2e6578fb
PE
2966 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2967
0ae6bdee
PE
2968 * data.c: Avoid integer truncation in expressions involving floats.
2969 * data.c: Include <intprops.h>.
2970 (arith_driver): When there's an integer overflow in an expression
2971 involving floating point, convert the integers to floating point
2972 so that the resulting value does not suffer from catastrophic
2973 integer truncation. For example, on a 64-bit host (* 4
2974 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2975 Do not rely on undefined behavior after integer overflow.
2976
de883a70
PE
2977 merge count_size_as_multibyte, parse_str_to_multibyte
2978 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2979 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2980 Check for integer overflow.
2981 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2982 since it's now a duplicate of the other. This is more of
2983 a character than a buffer op, so better that it's in character.c.
2984 * fns.c, print.c: Adjust to above changes.
2985
2ff916cb
PE
29862011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2987
2988 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2989
f1b54466
PE
29902011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2991
fb1ac845
PE
2992 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2993 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2994 (x_clipboard_manager_save): Now static.
2995 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2996
f1b54466
PE
2997 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2998 (crypto_hash_function): Now static.
2999 Fix pointer signedness problems. Avoid unnecessary initializations.
3000
a9f737ee
CY
30012011-05-27 Chong Yidong <cyd@stupidchicken.com>
3002
3003 * termhooks.h (Vselection_alist): Make it terminal-local.
3004
3005 * terminal.c (create_terminal): Initialize it.
3006
3007 * xselect.c: Support for clipboard managers.
3008 (Vselection_alist): Move to termhooks.h as terminal-local var.
3009 (LOCAL_SELECTION): New macro.
3010 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3011 (symbol_to_x_atom): Remove gratuitous arg.
3012 (x_handle_selection_request, lisp_data_to_selection_data)
3013 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3014 (x_own_selection, x_get_local_selection, x_convert_selection):
3015 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3016 (some_frame_on_display): Delete unused function.
3017 (Fx_own_selection_internal, Fx_get_selection_internal)
3018 (Fx_disown_selection_internal, Fx_selection_owner_p)
3019 (Fx_selection_exists_p): New optional frame arg.
3020 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3021 (x_handle_selection_clear): Don't treat other terminals with the
3022 same keyboard specially. Use the terminal-local Vselection_alist.
3023 (x_clear_frame_selections): Use Frun_hook_with_args.
3024
3025 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3026
3027 * xterm.h: Add support for those atoms.
3028
e067f0c1
CY
30292011-05-26 Chong Yidong <cyd@stupidchicken.com>
3030
3031 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3032 (converted_selections, conversion_fail_tag): New global variables.
3033 (x_selection_request_lisp_error): Free the above.
3034 (x_get_local_selection): Remove unnecessary code.
3035 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3036 of converted selections stored in converted_selections.
3037 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3038 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3039 (x_convert_selection): New function.
3040 (x_handle_selection_event): Simplify.
3041 (x_get_foreign_selection): Don't ignore incoming requests while
3042 waiting for an answer; this will fail when we implement
3043 SAVE_TARGETS, and seems unnecessary anyway.
3044 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3045 (Vx_sent_selection_functions): Doc fix.
3046
0f4aebc0
LL
30472011-05-26 Leo Liu <sdl.web@gmail.com>
3048
3049 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3050
e61124cd
YM
30512011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3052
3053 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3054
3055 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3056 for fringe update if it has periodic bitmap.
ac389d0c 3057 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3058 and fringe_bitmap_periodic_p.
3059
3060 * fringe.c (get_fringe_bitmap_data): New function.
3061 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3062 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3063 row. Mark glyph row for fringe update if periodicity changed.
3064
3065 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3066 for fringe update unless it has periodic bitmap.
3067
f16d9837
KH
30682011-05-25 Kenichi Handa <handa@m17n.org>
3069
3070 * xdisp.c (get_next_display_element): Set correct it->face_id for
3071 a static composition.
3072
e1b90ef6
LL
30732011-05-24 Leo Liu <sdl.web@gmail.com>
3074
3075 * deps.mk (fns.o):
3076 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3077
3078 * fns.c (crypto_hash_function, Fsha1): New function.
3079 (Fmd5): Use crypto_hash_function.
3080 (syms_of_fns): Add Ssha1.
3081
7400048f
PE
30822011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3083
3084 * gnutls.c: Remove unused macros.
3085 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3086 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3087 Remove macros that are defined and never used.
3088 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3089
abb71cf4
CY
30902011-05-22 Chong Yidong <cyd@stupidchicken.com>
3091
3092 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3093 (Fx_get_selection_internal): Minor cleanup.
3094 (Fx_own_selection_internal): Rename arguments for consistency with
3095 select.el.
3096
6307db39
PE
30972011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3098
3099 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3100
f3d4e0a4
CY
31012011-05-22 Chong Yidong <cyd@stupidchicken.com>
3102
3103 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3104
4d8ade89
YM
31052011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3106
3107 * dispnew.c (scrolling_window): Don't exclude the case that the
3108 last enabled row in the desired matrix touches the bottom boundary.
3109
32078c8d
GM
31102011-05-21 Glenn Morris <rgm@gnu.org>
3111
3112 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3113 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3114 and add some more files.
32078c8d 3115
7285dc67
EZ
31162011-05-20 Eli Zaretskii <eliz@gnu.org>
3117
3118 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3119 report_file_error introduced by the change from 2011-05-07.
3120
89d1bd22
PE
31212011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3122
3123 * systime.h (Time): Define only if emacs is defined.
3124 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3125 where the include path doesn't have X11/X.h by default. See
3126 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3127
e23640bb 31282011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3129
3130 * composite.c (find_automatic_composition): Fix previous change.
3131
b9704ad9
GM
31322011-05-20 Glenn Morris <rgm@gnu.org>
3133
3134 * lisp.mk: New file, split from Makefile.in.
3135 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3136 (shortlisp): Remove.
3137 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3138
4a720484
GM
31392011-05-19 Glenn Morris <rgm@gnu.org>
3140
3141 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3142 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3143 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3144 (lisp): Set the order to that of loadup.el.
3145 (shortlisp): Make it a copy of $lisp.
3146 (SOME_MACHINE_LISP): Remove.
3147 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3148 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3149
a28d4396
KH
31502011-05-18 Kenichi Handa <handa@m17n.org>
3151
3152 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3153 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3154 (find_automatic_composition): Mostly rewrite for efficiency.
3155
a2b1fa8e
JB
31562011-05-18 Juanma Barranquero <lekktu@gmail.com>
3157
3158 * makefile.w32-in: Update dependencies.
3159
8e1f5610
CS
31602011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3161
3162 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3163 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3164
7025ee00 31652011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3166
cdfa6eab
PE
3167 Fix some integer overflow issues, such as string length overflow.
3168
06d6db33
PE
3169 * insdel.c (count_size_as_multibyte): Check for string overflow.
3170
2b4560a8
PE
3171 * character.c (lisp_string_width): Check for string overflow.
3172 Use EMACS_INT, not int, for string indexes and lengths; in
3173 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3174 the resulting string length overflows an EMACS_INT; instead,
3175 report a string overflow if no precision given. When checking for
3176 precision exhaustion, use a check that cannot possibly have
3177 integer overflow. (Bug#8675)
3178 * character.h (lisp_string_width): Adjust to new signature.
3179
cb93f9be
PE
3180 * alloc.c (string_overflow): New function.
3181 (Fmake_string): Use it. This doesn't change behavior, but saves
3182 a few bytes and will simplify future changes.
3183 * character.c (string_escape_byte8): Likewise.
3184 * lisp.h (string_overflow): New decl.
3185
1a1f3366
PE
3186 Fixups, following up to the user-interface timestamp change.
3187 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3188 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3189 * msdos.c (mouse_get_pos): Likewise.
3190 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3191 * w32gui.h (Time): Define by including "systime.h" rather than by
3192 declaring it ourselves. (Bug#8664)
3193
d4e3e4d3
PE
3194 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3195 * image.c (clear_image_cache): Likewise.
3196
f6a24d19
PE
3197 * term.c (term_mouse_position): Don't assume time_t wraparound.
3198
08dc5ae6
PE
3199 Be more systematic about user-interface timestamps.
3200 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3201 and sometimes 'EMACS_UINT', to represent these timestamps.
3202 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3203 This makes the code easier to follow, and makes it easier to catch
3204 integer overflow bugs such as Bug#8664.
3205 * frame.c (Fmouse_position, Fmouse_pixel_position):
3206 Use Time, not unsigned long, for user-interface timestamps.
3207 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3208 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3209 * keyboard.h (last_event_timestamp): Likewise.
3210 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3211 * menu.h (xmenu_show): Likewise.
3212 * term.c (term_mouse_position): Likewise.
3213 * termhooks.h (struct input_event.timestamp): Likewise.
3214 (struct terminal.mouse_position_hook): Likewise.
3215 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3216 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3217 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3218 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3219 what it was before.
3220 * menu.h, termhooks.h: Include "systime.h", for Time.
3221
8e55734a
PE
3222 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3223 Don't assume that the difference between two unsigned long values
3224 can fit into an integer. At this point, we know button_down_time
3225 <= event->timestamp, so the difference must be nonnegative, so
3226 there's no need to cast the result if double-click-time is
3227 nonnegative, as it should be; check that it's nonnegative, just in
3228 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3229 apart (about 25 days). (Bug#8664)
8e55734a 3230
841f1b75 3231 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3232 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3233
3e26f69c
PE
3234 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3235 that always fit in int. Use a sentinel instead of a counter, to
3236 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3237 * frame.h (struct frame): Use int for menu_bar_items_used
3238 instead of EMACS_INT, since it always fits in int.
3e26f69c 3239
5cc152c0
PE
3240 * menu.c (grow_menu_items): Check for int overflow.
3241
d89eb65e
PE
3242 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3243
5235bd3e
PE
3244 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3245 Before, the code was not consistent. These values cannot exceed
3246 2**31 - 1 so there's no need to make them unsigned.
3247 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3248 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3249 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3250 as modifiers.
3251 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3252
bc827e23
PE
3253 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3254 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3255 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3256 presumably because the widths might not match.
3257
78eb494e
PE
3258 * window.c (size_window): Avoid needless test at loop start.
3259
04f2d78b
CB
32602011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3261
3262 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3263
d2fc7e3d 32642011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3265
3266 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3267
d2fc7e3d 32682011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3269
3270 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3271 `width' to `bar_area_x' and `bar_area_width', respectively.
3272 (x_scroll_run): Take account of fringe background extension.
3273
04f2d78b
CB
3274 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3275 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3276 `bar_area_width', respectively.
3277 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3278 background extension.
3279
79b70037
GM
32802011-05-10 Jim Meyering <meyering@redhat.com>
3281
3282 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3283
2f142cc5
JB
32842011-05-10 Juanma Barranquero <lekktu@gmail.com>
3285
3286 * image.c (Finit_image_library): Return t for built-in image types,
3287 like pbm and xbm. (Bug#8640)
3288
57679c86
AS
32892011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3290
3291 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3292
888c9e86
EZ
32932011-05-07 Eli Zaretskii <eliz@gnu.org>
3294
b0512a1d
EZ
3295 * w32console.c (Fset_screen_color): Doc fix.
3296 (Fget_screen_color): New function.
3297 (syms_of_ntterm): Defsubr it.
3298
7285dc67
EZ
3299 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3300 unlink the temporary file if Fcall_process didn't create it in the
3301 first place.
3302 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3303 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3304 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3305 cue to call_process_cleanup not to close that handle.
3306
4d3fcc8e
BK
33072011-05-07 Ben Key <bkey76@gmail.com>
3308
3309 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3310 one of two shell specific rules, either bootstrap-temacs-CMD or
3311 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3312 to the previous implementation of the bootstrap-temacs rule.
3313 The bootstrap-temacs-CMD rule is similar to the previous
3314 implementation of the bootstrap-temacs rule except that it
3315 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3316 variable.
3317
3318 These changes, along with some changes to nt/configure.bat,
3319 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3320 earlier fix to add support for --cflags and --ldflags options
3321 that include quotes so that it works whether make uses cmd or
3322 sh as the shell.
3323
b4289b64
MA
33242011-05-06 Michael Albinus <michael.albinus@gmx.de>
3325
3326 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3327 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3328 is a constant.
3329 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3330 a string. Handle both cases.
3331 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3332 (Fdbus_register_method): Use Qinvalid_function.
3333
af4c0e28
JB
33342011-05-06 Juanma Barranquero <lekktu@gmail.com>
3335
3336 * makefile.w32-in: Update dependencies.
3337 (LISP_H): Add inttypes.h and stdin.h.
3338 (PROCESS_H): Add unistd.h.
3339
c51453d9
EZ
33402011-05-06 Eli Zaretskii <eliz@gnu.org>
3341
3342 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3343 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3344
8ff0ac3c 33452011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3346
4c4b566b
PE
3347 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3348
aab2b9b5
PE
3349 * term.c (vfatal): Remove stray call to va_end.
3350 It's not needed and the C Standard doesn't allow it here anyway.
3351
c378da0b
PE
3352 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3353 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3354
288b08c7
PE
3355 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3356 bytes.
3357
e3601888
PE
3358 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3359
db6c0e74
PE
3360 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3361
dd5963ea
PE
3362 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3363
88c9450f
PE
3364 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3365
2f9442b8
PE
3366 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3367
c032b5f8
PE
3368 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3369 * charset.c (Fdefine_charset_internal): Don't initialize
3370 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3371 32-bit int (Bug#8600).
a108c10b
PE
3372
3373 * lread.c (read_integer): Be more consistent with string-to-number.
3374 Use string_to_number to do the actual conversion; this avoids
3375 rounding errors and fixes some other screwups. Without this fix,
3376 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3377 (digit_to_number): Move earlier, for benefit of read_integer.
3378 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3379 not a digit in any supported base. (Bug#8602)
a108c10b 3380
ad5f9eea
PE
3381 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3382
aec1708a
PE
3383 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3384 to match comment at start of function. This also removes a
3385 GCC warning about overflow in a 32+64-bit port.
3386
47be4ab5
PE
3387 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3388
371cac43
PE
3389 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3390 Reported by Stefan Monnier in
3391 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3392 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3393 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3394
d01a7826
PE
3395 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3396 (EMACS_UINTPTR): Likewise, with uintptr_t.
3397
7fd47d5c
PE
3398 * lisp.h: Prefer 64-bit EMACS_INT if available.
3399 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3400 on 32-bit hosts that have 64-bit int, so that they can access
3401 large files.
122b0c86
PE
3402 However, temporarily disable this change unless the temporary
3403 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3404
8727937b
PE
3405 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3406
8ac068ac
PE
3407 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3408 This removes an assumption that EMACS_INT and long are the same
3409 width as pointers. The assumption is true for Emacs porting targets
3410 now, but we want to make other targets possible.
3411 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3412 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3413 In the rest of the code, change types of integers that hold casted
3414 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3415 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3416 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3417 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3418 No need to cast type when ORing.
3419 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3420 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3421 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3422 assume EMACS_INT is the same width as char *.
3423 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3424 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3425 Remove no-longer-needed casts.
3426 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3427 (xg_tool_bar_help_callback, xg_make_tool_item):
3428 Use EMACS_INTPTR to hold an integer
3429 that will be cast to void *; this can avoid a GCC warning
3430 if EMACS_INT is not the same width as void *.
3431 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3432 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3433 (current_message_1, set_message_1):
3434 Use a local to convert to proper width without a cast.
3435 * xmenu.c (dialog_selection_callback): Likewise.
3436
ede49d71
PE
3437 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3438 Also, don't assume VALBITS / RAND_BITS is less than 5,
3439 and don't rely on undefined behavior when shifting a 1 left into
3440 the sign bit.
3441 * lisp.h (get_random): Change signature to match.
3442
2f30ecd0
PE
3443 * lread.c (hash_string): Use size_t, not int, for hash computation.
3444 Normally we prefer signed values; but hashing is special, because
3445 it's better to use unsigned division on hash table sizes so that
3446 the remainder is nonnegative. Also, size_t is the natural width
3447 for hashing into memory. The previous code used 'int', which doesn't
3448 retain enough info to hash well into very large tables.
3449 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3450
2a866e7b
PE
3451 * dbusbind.c: Don't possibly lose pointer info when converting.
3452 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3453 Use XPNTR rather than XHASH, so that the high-order bits of
3454 the pointer aren't lost when converting through void *.
3455
51639eac
PE
3456 * eval.c (Fautoload): Don't double-shift a pointer.
3457
92394119
PE
3458 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3459
dbdb9a7c
JB
34602011-05-06 Juanma Barranquero <lekktu@gmail.com>
3461
3462 * gnutls.c (DEF_GNUTLS_FN):
3463 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3464
db7a0b4f
AS
34652011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3466
3467 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3468 marker. (Bug#8610)
3469
f7ff1b0f 34702011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3471
3472 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3473 New version that can reserve upto 2GB of heap space.
3474
f7ff1b0f 34752011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3476
3477 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3478
639c109b
TZ
34792011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3480
3481 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3482 `gnutls_certificate_set_x509_key_file'.
3483
d2127135
JB
34842011-05-05 Juanma Barranquero <lekktu@gmail.com>
3485
3486 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3487 Update dependencies.
3488
e968f4f3
JB
34892011-05-04 Juanma Barranquero <lekktu@gmail.com>
3490
3491 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3492 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3493 Remove unused parameter `fildes'.
3494 * process.c (read_process_output, send_process): Don't pass it.
3495
84d358f0
JB
34962011-05-04 Juanma Barranquero <lekktu@gmail.com>
3497
3498 Fix previous change: the library cache is defined in w32.c.
3499 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3500 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3501
0898ca10
JB
35022011-05-04 Juanma Barranquero <lekktu@gmail.com>
3503
3504 Implement dynamic loading of GnuTLS on Windows.
3505
3506 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3507 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3508 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3509 Declare.
3510
3511 * gnutls.c (Qgnutls_dll): Define.
3512 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3513 (gnutls_*): Declare function pointers.
3514 (init_gnutls_functions): New function to initialize function pointers.
3515 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3516 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3517 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3518 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3519 (emacs_gnutls_write, emacs_gnutls_read)
3520 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3521 (Fgnutls_available_p): New function.
3522 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3523 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3524 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3525
3526 * image.c: Include w32.h.
3527 (Vimage_type_cache): Delete.
3528 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3529 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3530 (w32_delayed_load): Move to w32.c.
3531
3532 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3533
3534 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3535 (w32_delayed_load): Move from image.c. When loading a library, record
3536 its filename in the :loaded-from property of the library id.
3537 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3538 Initialize and staticpro them.
3539 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3540
3541 * process.c: Include lisp.h before w32.h, not after.
3542 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3543 instead of gnutls_record_check_pending.
3544
3545 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3546
ff4de4aa
TZ
35472011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3548
3549 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3550 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3551 as passed in.
3552
abe95abb
JD
35532011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3554
3555 * xterm.c (x_set_frame_alpha): Do not set property on anything
3556 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3557
e16e55d4
JB
35582011-05-02 Juanma Barranquero <lekktu@gmail.com>
3559
3560 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3561
bafcf6a5
JB
35622011-05-02 Juanma Barranquero <lekktu@gmail.com>
3563
3564 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3565 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3566 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3567 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3568 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3569 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3570 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3571 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3572 (Qgnutls_bootprop_callbacks_verify): Make static.
3573
e7a6747f
AS
35742011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3575
19ed11ba
AS
3576 * callproc.c: Indentation fixup.
3577
e7a6747f 3578 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3579 (wait_for_termination, interruptible_wait_for_termination):
3580 Move after wait_for_termination_1.
e7a6747f 3581
1ef14cb4
LMI
35822011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3583
3584 * sysdep.c (interruptible_wait_for_termination): New function
3585 which is like wait_for_termination, but allows keyboard
3586 interruptions.
3587
3588 * callproc.c (Fcall_process): Add (:file "file") as an option for
3589 the STDOUT buffer.
3590 (Fcall_process_region): Ditto.
3591
330d880c
EZ
35922011-04-30 Eli Zaretskii <eliz@gnu.org>
3593
8db90b73
EZ
3594 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3595 rather than `XVECTOR (FOO)->size'.
3596
330d880c
EZ
3597 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3598 inttypes.h, as a gnulib replacement is used if it not available in
3599 system headers.
3600
15cbd324
EZ
36012011-04-21 Eli Zaretskii <eliz@gnu.org>
3602
3603 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3604 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3605 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3606
3607 * coding.c (coding_alloc_by_realloc): Error out if destination
3608 will grow beyond MOST_POSITIVE_FIXNUM.
3609 (decode_coding_emacs_mule): Abort if there isn't enough place in
3610 charbuf for the composition carryover bytes. Reserve an extra
3611 space for up to 2 characters produced in a loop.
3612 (decode_coding_iso_2022): Abort if there isn't enough place in
3613 charbuf for the composition carryover bytes.
3614
36152011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3616
ae940cca
EZ
3617 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3618 aborting when %lld or %lll format is passed.
3619 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3620 %llo or %llx format is passed. (Bug#8545)
3621
03ab8921
EZ
3622 * window.c (window_scroll_line_based): Use a marker instead of
3623 simple variables to record original value of point. (Bug#7952)
3624
afda1437
EZ
3625 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3626 produced by %s or %c overflows available buffer space. (Bug#8545)
3627
f76dee0c
PE
36282011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3629
3630 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3631 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3632
fdc5744d
JB
36332011-04-28 Juanma Barranquero <lekktu@gmail.com>
3634
3635 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3636
638f053a
JB
36372011-04-28 Juanma Barranquero <lekktu@gmail.com>
3638
3639 * keyboard.c (Qdelayed_warnings_hook): Define.
3640 (command_loop_1): Run `delayed-warnings-hook'
3641 if Vdelayed_warnings_list is non-nil.
3642 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3643 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3644
d178f871
EZ
36452011-04-28 Eli Zaretskii <eliz@gnu.org>
3646
3647 * doprnt.c (doprnt): Don't return value smaller than the buffer
3648 size if the message was truncated. (Bug#8545).
3649
b124fd93
JB
36502011-04-28 Juanma Barranquero <lekktu@gmail.com>
3651
3652 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3653 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3654
e810457d
PE
36552011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3656
3657 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3658
ea51cceb
JB
36592011-04-27 Juanma Barranquero <lekktu@gmail.com>
3660
3661 * makefile.w32-in: Update dependencies.
3662
94dcfacf
EZ
36632011-04-27 Eli Zaretskii <eliz@gnu.org>
3664
3665 Improve `doprnt' and its usage. (Bug#8545)
3666 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3667 `format_end'. Remove support for %l as a conversion specifier.
3668 Don't use xrealloc. Improve diagnostics when the %l size modifier
3669 is used. Update the commentary.
3670
3671 * eval.c (verror): Simplify calculation of size_t.
3672
3673 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3674 messages.
3675
f61f41d7
PE
36762011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3677
3678 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3679 change.
3680
96fb4434
PE
36812011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3682
3683 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3684 This makes this file independent of the recent pseudovector change.
3685
671875da 36862011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3687
69e9b5a3
PE
3688 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3689
b5f869a7 3690 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3691 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3692 Remove unused local.
c8926152 3693 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3694
841a1577 3695 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3696 GCC 4.6.0 optimizes based on type-based alias analysis.
3697 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3698 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3699 != &v->size, and therefore "v->size = 1; b->size = 2; return
3700 v->size;" must therefore return 1. This assumption is incorrect
3701 for Emacs, since it type-puns struct Lisp_Vector * with many other
3702 types. To fix this problem, this patch adds a new type struct
f904488f 3703 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3704 and pseudovectors, and helps optimizing compilers not get fooled
3705 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3706 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3707 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3708 the size member.
eab3844f
PE
3709 (XSETPVECTYPE): Rewrite in terms of new macro.
3710 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3711 This is a bit clearer, and further avoids the possibility of
3712 undesirable aliasing.
3713 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3714 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3715 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3716 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3717 (ASIZE): Now uses header.size rather than size.
3718 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3719 to avoid the hassle of writing XVECTOR (foo)->header.size.
3720 (struct vectorlike_header): New type.
eab3844f
PE
3721 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3722 object, to help avoid aliasing.
3723 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3724 (SUBRP): Likewise, since Lisp_Subr is a special case.
3725 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3726 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3727 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3728 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3729 changed to be "header.size" and "header.next".
3730 * buffer.h (struct buffer): Likewise.
3731 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3732 * frame.h (struct frame): Likewise.
3733 * process.h (struct Lisp_Process): Likewise.
3734 * termhooks.h (struct terminal): Likewise.
3735 * window.c (struct save_window_data, struct saved_window): Likewise.
3736 * window.h (struct window): Likewise.
3737 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3738 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3739 * buffer.c (init_buffer_once): Likewise.
3740 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3741 special case.
3742 * process.c (Fformat_network_address): Use local var for size,
3743 for brevity.
3744
0df1eac5
PE
3745 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3746
847ab9d1 3747 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3748 * data.c (atof): Remove decl; no longer used or needed.
3749 (digit_to_number): Move to lread.c.
3750 (Fstring_to_number): Use new string_to_number function, to be
3751 consistent with how the Lisp reader treats infinities and NaNs.
3752 Do not assume that floating-point numbers represent EMACS_INT
3753 without losing information; this is not true on most 64-bit hosts.
3754 Avoid double-rounding errors, by insisting on integers when
3755 parsing non-base-10 numbers, as the documentation specifies.
3756 * lisp.h (string_to_number): New decl, replacing ...
3757 (isfloat_string): Remove.
bc0a5c13 3758 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3759 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3760 appears to have been a coding error. Similarly, do not accept
3761 strings like +-1e0 as floating point numbers. Do not report
3762 overflow for integer overflows unless the base is not 10 which
3763 means we have no simple and reliable way to continue.
3764 Break out the floating-point parsing into a new
3765 function string_to_number, so that Fstring_to_number parses
3766 floating point numbers consistently with the Lisp reader.
04f2d78b 3767 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3768 (E_CHAR, EXP_INT): Remove, replacing with ...
3769 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3770 (string_to_number): New function, replacing isfloat_string.
3771 This function checks for valid syntax and produces the resulting
3772 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3773 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3774 so that overflow for non-base-10 numbers is reported only when
3775 there's no portable and simple way to convert to floating point.
452f4150 3776
67769ffc
PE
3777 * textprop.c (set_text_properties_1): Rewrite for clarity,
3778 and to avoid GCC warning about integer overflow.
3779
c20db43f
PE
3780 * intervals.h (struct interval): Use EMACS_INT for members
3781 where EMACS_UINT might cause problems. See
3782 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3783 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3784 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3785 All uses changed.
37aa2f85
PE
3786 (offset_intervals): Tell GCC not to worry about length overflow
3787 when negating a negative length.
c20db43f 3788
2538aa2f
PE
3789 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3790 (overrun_check_free): Likewise.
3791
f2d3008d
PE
3792 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3793 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3794 word size.
3795
ec8df744
PE
3796 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3797 (gnutls_make_error): Rename local to avoid shadowing.
3798 (gnutls_emacs_global_deinit): ifdef out; not used.
3799 (Fgnutls_boot): Use const for pointer to readonly storage.
3800 Comment out unused local. Fix pointer signedness problems.
3801
640ee02d
PE
3802 * lread.c (openp): Don't stuff size_t into an 'int'.
3803 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3804 about possible signed overflow.
3805
6048fb2a
PE
3806 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3807 (GDK_KEY_g): Don't define if already defined.
3808 (xg_prepare_tooltip): Avoid pointer signedness problem.
3809 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3810
fa3c87e1
PE
3811 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3812 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3813
2172544b
PE
3814 * xfns.c (Fx_window_property): Simplify a bit,
3815 to make a bit faster and to avoid GCC 4.6.0 warning.
3816 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3817
9b821a21
PE
3818 * fns.c (internal_equal): Don't assume size_t fits in int.
3819
3c616cfa
PE
3820 * alloc.c (compact_small_strings): Tighten assertion a little.
3821
c2982e87
PE
3822 Replace pEd with more-general pI, and fix some printf arg casts.
3823 * lisp.h (pI): New macro, generalizing old pEd macro to other
3824 conversion specifiers. For example, use "...%"pI"d..." rather
3825 than "...%"pEd"...".
3826 (pEd): Remove. All uses replaced with similar uses of pI.
3827 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3828 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3829 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3830 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3831 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3832 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3833 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3834 64-bit hosts.
3835 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3836 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3837 * print.c (safe_debug_print, print_object): Likewise.
3838 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3839 to int.
6f04d126
PE
3840 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3841 avoiding the 0 flag, which is not portable.
c2982e87
PE
3842 * process.c (Fmake_network_process): Use pI to avoid cast.
3843 * region-cache.c (pp_cache): Likewise.
3844 * xdisp.c (decode_mode_spec): Likewise.
3845 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3846 behavior on 64-bit hosts with printf arg.
6f04d126 3847 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3848 (x_stop_queuing_selection_requests): Likewise.
3849 (x_get_window_property): Don't truncate byte count to an 'int'
3850 when tracing.
0b432f21 3851
5e073ec7
PE
3852 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3853 here, since it parses constructs like leading '-' and spaces,
3854 which are not wanted; and it overflows with large numbers.
3855 Instead, simply match F[0-9]+, which is what is wanted anyway.
3856
36372bf9
PE
3857 * alloc.c: Remove unportable assumptions about struct layout.
3858 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3859 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3860 (allocate_vectorlike, make_pure_vector): Use the new macros,
3861 plus offsetof, to remove unportable assumptions about struct layout.
3862 These assumptions hold on all porting targets that I know of, but
3863 they are not guaranteed, they're easy to remove, and removing them
3864 makes further changes easier.
3865
0b432f21
PE
3866 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3867 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3868 (string_overrun_cookie): Now const. Use initializers that
3869 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3870 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3871 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3872 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3873 multiple of sizeof (EMACS_INT); it need not be, if
3874 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3875 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3876
895009e1
JB
38772011-04-26 Juanma Barranquero <lekktu@gmail.com>
3878
3879 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3880
6a7a1b0b
TZ
38812011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3882
3883 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3884 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3885 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3886
841a1577 38872011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3888
3889 * lisp.h (Qdebug): List symbol.
895009e1 3890 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3891 * keyboard.c (debug-on-event): New variable.
3892 (handle_user_signal): Break into debugger when debug-on-event
3893 matches the current signal symbol.
3894
f2d3ba6f
DN
38952011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3896
3897 * alloc.c (check_sblock, check_string_bytes)
3898 (check_string_free_list): Convert to standard C.
3899
42ce4c63
TZ
39002011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3901
3902 * w32.c (emacs_gnutls_push): Fix typo.
3903
825cd63c
EZ
39042011-04-25 Eli Zaretskii <eliz@gnu.org>
3905
fb11d64d
EZ
3906 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3907 "cast to pointer from integer of different size".
3908
825cd63c
EZ
3909 Improve doprnt and its use in verror. (Bug#8545)
3910 * doprnt.c (doprnt): Document the set of format control sequences
3911 supported by the function. Use SAFE_ALLOCA instead of always
3912 using `alloca'.
3913
3914 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3915 is one byte too soon. Don't use xrealloc; instead xfree and
3916 xmalloc anew.
3917
e061a11b
TZ
39182011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3919
3920 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3921 callbacks stage.
3922
3923 * gnutls.c: Renamed global_initialized to
3924 gnutls_global_initialized. Added internals for the
3925 :verify-hostname-error, :verify-error, and :verify-flags
3926 parameters of `gnutls-boot' and documented those parameters in the
3927 docstring. Start callback support.
9173deec
JB
3928 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3929 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3930 on error. Return error code.
e061a11b
TZ
3931 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3932 (emacs_gnutls_read): Likewise.
3933 (Fgnutls_boot): Return handshake error code.
3934 (emacs_gnutls_handle_error): New function.
3935 (wsaerror_to_errno): Likewise.
3936
3937 * w32.h (emacs_gnutls_pull): Add prototype.
3938 (emacs_gnutls_push): Likewise.
3939
3940 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3941 (emacs_gnutls_push): Likewise.
3942
39432011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3944
3945 * process.c (wait_reading_process_output): Check if GnuTLS
3946 buffered some data internally if no FDs are set for TLS
3947 connections.
3948
3949 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3950 (LIBS): Link to USER_LIBS.
3951 ($(BLD)/gnutls.$(0)): New target.
3952
fa6996bc
EZ
39532011-04-24 Eli Zaretskii <eliz@gnu.org>
3954
eb35682e
EZ
3955 * xdisp.c (handle_single_display_spec): Rename the
3956 display_replaced_before_p argument into display_replaced_p, to
3957 make it consistent with the commentary. Fix typos in the
3958 commentary.
3959
e2ad650c
EZ
3960 * textprop.c (syms_of_textprop): Remove dead code.
3961 (copy_text_properties): Delete obsolete commentary about an
3962 interface that was deleted long ago. Fix typos in the description
3963 of arguments.
3964
1b2de274
EZ
3965 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3966 to changes in oldXMenu/XMenu.h from 2011-04-16.
3967 <menu_help_message, prev_menu_help_message>: Constify.
3968 (IT_menu_make_room): menu->help_text is now `const char **';
3969 adjust.
3970
3971 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3972 to changes in oldXMenu/XMenu.h from 2011-04-16.
3973 (struct XMenu): Declare `help_text' `const char **'.
3974
3975 * xfaces.c <Qunspecified>: Make extern again.
3976
3977 * syntax.c: Include sys/types.h before including regex.h, as
3978 required by Posix.
3979
762b15be
EZ
3980 * doc.c (get_doc_string): Improve the format passed to `error'.
3981
3982 * doprnt.c (doprnt): Improve commentary.
3983
3984 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3985
3986 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3987 them with etags.
3988
f1052e5d
EZ
3989 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3990 changes in globals.h immediately force recompilation.
762b15be
EZ
3991 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3992 $(CURDIR)/s/ms-w32.h.
3993 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3994
fa6996bc
EZ
3995 * character.c (Fchar_direction): Function deleted.
3996 (syms_of_character): Don't defsubr it.
3997 <char-direction-table>: Deleted.
3998
e6c3da20
EZ
39992011-04-23 Eli Zaretskii <eliz@gnu.org>
4000
4001 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4002 * doprnt.c: Include limits.h.
4003 (SIZE_MAX): New macro.
04f2d78b
CB
4004 (doprnt): Return a size_t value. 2nd arg is now size_t.
4005 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4006 Improve overflow protection. Support `l' modifier for integer
4007 conversions. Support %l conversion. Don't assume an EMACS_INT
4008 argument for integer conversions and for %c.
4009
4010 * lisp.h (doprnt): Restore prototype.
4011
4012 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4013 $(SRC)/character.h.
4014
4015 * Makefile.in (base_obj): Add back doprnt.o.
4016
4017 * deps.mk (doprnt.o): Add back prerequisites.
4018 (callint.o): Depend on character.h.
4019
4020 * eval.c (internal_lisp_condition_case): Include the handler
4021 representation in the error message.
4022 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4023 when breaking from the loop.
4024
4025 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4026
4027 * callint.c (Fcall_interactively): When displaying error message
4028 about invalid control letter, pass the character's codepoint, not
4029 a pointer to its multibyte form. Improve display of the character
4030 in octal and display also its hex code.
4031
4032 * character.c (char_string): Use %x to display the (unsigned)
4033 codepoint of an invalid character, to avoid displaying a bogus
4034 negative value.
4035
4036 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4037 `error', not SYMBOL_NAME itself.
4038
4039 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4040 character arguments to `error'.
4041
4042 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4043 to `error' in error message about FINAL_CHAR argument. Make sure
4044 FINAL_CHAR is a character, and use %c when it is passed as
4045 argument to `error'.
4046
4ffd0d6b 40472011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4048
4049 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4050
4051 * w32.c: Include <time.h>.
4052 (sys_localtime): New function.
4053
4ffd0d6b 40542011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4055
4056 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4057
4ffd0d6b 4058 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4059
4ffd0d6b 40602011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4061
4ffd0d6b
GM
4062 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4063 zombies (Bug#8467).
aac0c6e3 4064
04c56954
EZ
40652011-04-19 Eli Zaretskii <eliz@gnu.org>
4066
4067 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4068 gl_state.e_property when gl_state.object is Qt.
4069
4070 * insdel.c (make_gap_larger): Remove limitation of buffer size
4071 to <= INT_MAX.
4072
16a43933
CY
40732011-04-18 Chong Yidong <cyd@stupidchicken.com>
4074
4075 * xdisp.c (lookup_glyphless_char_display)
4076 (produce_glyphless_glyph): Handle cons cell entry in
4077 glyphless-char-display.
4078 (Vglyphless_char_display): Document it.
4079
4080 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4081 glyphless-char-display.
4082
4581706e
CY
40832011-04-17 Chong Yidong <cyd@stupidchicken.com>
4084
4085 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4086
4087 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4088
4089 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4090 definition for no-X builds.
4091
4887c6e2 40922011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4093
fd35b6f9
PE
4094 Static checks with GCC 4.6.0 and non-default toolkits.
4095
5c1ccb01
PE
4096 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4097
006c5daa
PE
4098 * process.c (keyboard_bit_set): Define only if SIGIO.
4099 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4100 (send_process): Repair possible setjmp clobbering.
4101
efc736d3
PE
4102 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4103
4e2fe2e6
PE
4104 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4105
f97334a2
PE
4106 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4107
4e75f29d
PE
4108 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4109 Define only if needed.
4110
90efadd1
PE
4111 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4112 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4113 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4114
3c647824
PE
4115 * dispextern.h (struct redisplay_interface): Rename param
4116 to avoid shadowing.
e264f262 4117 * termhooks.h (struct terminal): Likewise.
761383f4 4118 * xterm.c (xembed_send_message): Likewise.
3c647824 4119
b58c5c4a
PE
4120 * insdel.c (make_gap_smaller): Define only if
4121 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4122
cad59032
PE
4123 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4124 it.
4125
c339dc2e
PE
4126 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4127 so that we aren't warned about unused symbols.
4128
91a3e27b
PE
4129 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4130
399c71d3 4131 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4132
8ffc96f5
PE
4133 * xfns.c (x_real_positions): Mark locals as initialized.
4134
eef9bc79
PE
4135 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4136
098db9dd
PE
4137 * xterm.c: Fix problems found by static analysis with other toolkits.
4138 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4139 (x_dispatch_event): Declare static if USE_GTK, and
4140 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4141 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4142 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4143 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4144 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4145
eb18f6cc
PE
4146 * xmenu.c (menu_help_callback): Pointer type fixes.
4147 Use const pointers when pointing at readonly data. Avoid pointer
4148 signedness clashes.
4149 (FALSE): Remove unused macro.
4150 (update_frame_menubar): Remove unused decl.
4151
1fe72bf8
PE
4152 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4153
60d9e1db
PE
4154 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4155 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4156 (single_menu_item): Rename local to avoid shadowing.
4157
39261c26
PE
4158 * keyboard.c (make_lispy_event): Remove unused local var.
4159
018c5e19
PE
4160 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4161 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4162
63d2b86e
PE
4163 * bitmaps: Change bitmaps from unsigned char back to the X11
4164 compatible char. Avoid the old compiler warnings about
4165 out-of-range initializers by using, for example, '\xab' rather
4166 than 0xab.
4167
aefd87e1
PE
4168 * xgselect.c (xgselect_initialize): Check vs interface
4169 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4170
bf501fb9
PE
4171 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4172
e9829fdf
PE
4173 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4174 to read-only memory.
4175
1086c095
PE
4176 * fns.c (vector): Remove; this old hack is no longer needed.
4177
2baccd04 4178 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4179 Remove unused var.
dde42981 4180 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4181
72391843 4182 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4183
436c16df 4184 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4185 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4186 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4187
92bb796d 4188 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4189 (x_term_init): Remove local to avoid shadowing.
92bb796d 4190
764430a3 4191 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4192
4193 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4194 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4195
d1dfb56c
EZ
41962011-04-16 Eli Zaretskii <eliz@gnu.org>
4197
c4354cb4
EZ
4198 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4199
d1dfb56c
EZ
4200 Fix regex.c, syntax.c and friends for buffers > 2GB.
4201 * syntax.h (struct gl_state_s): Declare character position members
4202 EMACS_INT.
4203
4204 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4205
04f2d78b
CB
4206 * textprop.c (verify_interval_modification, interval_of):
4207 Declare arguments EMACS_INT.
d1dfb56c
EZ
4208
4209 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4210 EMACS_INT.
4211
4212 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4213
4214 * indent.c (Fvertical_motion): Local variable it_start is now
4215 EMACS_INT.
4216
4217 * regex.c (re_match, re_match_2, re_match_2_internal)
4218 (bcmp_translate, regcomp, regexec, print_double_string)
4219 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4220 (re_compile_pattern, re_exec): Declare arguments and local
4221 variables `size_t' and `ssize_t' and return values `regoff_t', as
4222 appropriate.
4223 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4224 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4225 <compile_stack_type>: `size' and `avail' are now `size_t'.
4226
4227 * regex.h <regoff_t>: Use ssize_t, not int.
4228 (re_search, re_search_2, re_match, re_match_2): Arguments that
4229 specify buffer/string position and length are now ssize_t and
4230 size_t. Return type is regoff_t.
4231
613052cd
BK
42322011-04-16 Ben Key <bkey76@gmail.com>
4233
4234 * nsfont.m: Fixed bugs in ns_get_family and
4235 ns_descriptor_to_entity that were caused by using free to
4236 deallocate memory blocks that were allocated by xmalloc (via
4237 xstrdup). This caused Emacs to crash when compiled with
4238 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4239 --enable-checking=xmallocoverrun). xfree is now used to
4240 deallocate these memory blocks.
4241
4170f62f 42422011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4243
71b41406
PE
4244 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4245
9587a89d
PE
4246 emacs_write: Accept and return EMACS_INT for sizes.
4247 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4248 et seq.
4249 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4250 Accept and return EMACS_INT.
4251 (emacs_gnutls_write): Return the number of bytes written on
4252 partial writes.
4253 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4254 (emacs_read, emacs_write): Remove check for negative size, as the
4255 Emacs source code has been audited now.
9587a89d
PE
4256 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4257 (emacs_read, emacs_write): Use it.
273a5f82
PE
4258 * process.c (send_process): Adjust to the new signatures of
4259 emacs_write and emacs_gnutls_write. Do not attempt to store
4260 a byte offset into an 'int'; it might overflow.
9587a89d 4261 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4262
3e047f51
PE
4263 * sound.c: Don't assume sizes fit in 'int'.
4264 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4265 Return EMACS_INT, not int.
3e047f51 4266 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4267 Accept EMACS_INT, not int.
4268 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4269 record read return values.
4270
cc39a9db
BK
42712011-04-15 Ben Key <bkey76@gmail.com>
4272
c9d0ec6d
JB
4273 * keyboard.c (Qundefined): Don't declare static since it is used
4274 in nsfns.m.
4275 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4276 static since they are used in nsfont.m.
cc39a9db 4277
6c60eb9f
SM
42782011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4279
4280 * process.c (Qprocessp): Don't declare static.
4281 * lisp.h (Qprocessp): Declare again.
4282
7990b61a
JB
42832011-04-15 Juanma Barranquero <lekktu@gmail.com>
4284
4285 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4286
5d4cb038
PE
42872011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4288
8bd7b830 4289 Improve C-level modularity by making more things 'static'.
cd64ea1d 4290
e3b27b31
PE
4291 Don't publish debugger-only interfaces to other modules.
4292 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4293 (verify_bytepos, count_markers): Move decls to the only modules
4294 that need them.
4295 * region-cache.h (pp_cache): Likewise.
4296 * window.h (check_all_windows): Likewise.
4297 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4298
5d4cb038
PE
4299 * sysdep.c (croak): Now static, if
4300 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4301 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4302
4303 * alloc.c (refill_memory_reserve): Now static if
4304 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4305 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4306
e87b6180
PE
4307 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4308 Define only if USE_LUCID.
4309
ac64929e
PE
4310 * xrdb.c (x_customization_string, x_rm_string): Now static.
4311
6f37259d
PE
4312 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4313 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4314
1683e3ab
PE
4315 * xdisp.c (draw_row_with_mouse_face): Now static.
4316 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4317
de9c2632
PE
4318 * window.h (check_all_windows): Mark externally visible.
4319
2b96acb7
PE
4320 * window.c (window_deletion_count): Now static.
4321
4322 * undo.c: Make symbols static if they're not exported.
4323 (last_undo_buffer, last_boundary_position, pending_boundary):
4324 Now static.
4325
50436f33
PE
4326 * textprop.c (interval_insert_behind_hooks): Now static.
4327 (interval_insert_in_front_hooks): Likewise.
4328
64520e5c
PE
4329 * term.c: Make symbols static if they're not exported.
4330 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4331 (max_frame_lines, tty_set_terminal_modes):
4332 (tty_reset_terminal_modes, tty_turn_off_highlight):
4333 (get_tty_terminal): Now static.
4334 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4335 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4336 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4337 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4338 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4339
1fa53021
PE
4340 * sysdep.c: Make symbols static if they're not exported.
4341 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4342 Now static.
4343 (sigprocmask_set, full_mask): Remove; unused.
4344 (wait_debugging): Mark as visible.
4345 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4346 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4347
d4b43b22
PE
4348 * syntax.c (syntax_temp): Define only if !__GNUC__.
4349
b7c513d0
PE
4350 * sound.c (current_sound_device, current_sound): Now static.
4351
989b29ad
PE
4352 * search.c (searchbufs, searchbuf_head): Now static.
4353
13a55a78
PE
4354 * scroll.c (scroll_cost): Remove; unused.
4355 * dispextern.h (scroll_cost): Remove decl.
4356
de68a1fc
PE
4357 * region-cache.h (pp_cache): Mark as externally visible.
4358
40ccffa6
PE
4359 * process.c: Make symbols static if they're not exported.
4360 (process_tick, update_tick, create_process, chan_process):
4361 (Vprocess_alist, proc_buffered_char, datagram_access):
4362 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4363 (deactivate_process): Mark defn as static, as well as decl.
4364 * lisp.h (create_process): Remove decl.
4365 * process.h (chan_process, Vprocess_alist): Remove decls.
4366
ad64fc97
PE
4367 * print.c: Make symbols static if they're not exported.
4368 (print_depth, new_backquote_output, being_printed, print_buffer):
4369 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4370 (print_interval, print_number_index, initial_stderr_stream):
4371 Now static.
4372 * lisp.h (Fprinc): Remove decl.
4373 (debug_output_compilation_hack): Mark as externally visible.
4374
adddb265
PE
4375 * sysdep.c (croak): Move decl from here to syssignal.h.
4376 * syssignal.h (croak): Put it here, so the API can be checked when
4377 'croak' is called from dissociate_if_controlling_tty.
4378
1717ede2
PE
4379 * minibuf.c: Make symbols static if they're not exported.
4380 (minibuf_save_list, choose_minibuf_frame): Now static.
4381 * lisp.h (choose_minibuf_frame): Remove decl.
4382
fa5fb2bc
PE
4383 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4384
1e3890d1
PE
4385 * lread.c: Make symbols static if they're not exported.
4386 (read_objects, initial_obarray, oblookup_last_bucket_number):
4387 Now static.
4388 (make_symbol): Remove; unused.
4389 * lisp.h (initial_obarray, make_symbol): Remove decls.
4390
8a1414fa
PE
4391 * keyboard.c: Make symbols static if they're not exported.
4392 (single_kboard, recent_keys_index, total_keys, recent_keys):
4393 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4394 (this_single_command_key_start, echoing, last_auto_save):
4395 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4396 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4397 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4398 (Vlispy_mouse_stem, double_click_count):
4399 Now static.
4400 (force_auto_save_soon): Define only if SIGDANGER.
4401 (ignore_mouse_drag_p): Now static if
4402 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4403 (print_help): Remove; unused.
4404 (stop_character, last_timer_event): Mark as externally visible.
4405 * keyboard.h (ignore_mouse_drag_p): Declare only if
4406 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4407 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4408 * lisp.h (echoing): Remove decl.
4409 (force_auto_save_soon): Declare only if SIGDANGER.
4410 * xdisp.c (redisplay_window): Simplify code, to make it more
4411 obvious that ignore_mouse_drag_p is not accessed if !defined
4412 USE_GTK && !defined HAVE_NS.
4413
93ea6e8f
PE
4414 * intervals.c: Make symbols static if they're not exported.
4415 (merge_properties_sticky, merge_interval_right, delete_interval):
4416 Now static.
4417 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4418
77382fcc
PE
4419 * insdel.c: Make symbols static if they're not exported.
4420 However, leave prepare_to_modify_buffer alone. It's never
4421 called from outside this function, but that appears to be a bug.
4422 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4423 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4424 (adjust_after_replace_noundo): Remove; unused.
4425 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4426 (signal_before_change): Remove decls.
77382fcc 4427
9306c32e
PE
4428 * indent.c (val_compute_motion, val_vmotion): Now static.
4429
cd44d2eb
PE
4430 * image.c: Make symbols static if they're not exported.
4431 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4432 if USE_GTK.
4433 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4434 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4435
ad9a7a06
PE
4436 * fringe.c (standard_bitmaps): Now static.
4437 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4438
81626931
PE
4439 * frame.c: Make symbols static if they're not exported.
4440 (x_report_frame_params, make_terminal_frame): Now static.
4441 (get_frame_param): Now static, unless HAVE_NS.
4442 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4443 (x_get_resource_string): Remove; not used.
4444 * frame.h (make_terminal_frame, x_report_frame_params):
4445 (x_get_resource_string); Remove decls.
4446 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4447 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4448
239f9db9
PE
4449 * font.c, fontset.c: Make symbols static if they're not exported.
4450 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4451 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4452 * font.c (font_close_object): Now static.
4453 * font.h (font_close_object): Remove.
4454 * fontset.c (FONTSET_OBJLIST): Remove.
4455 (free_realized_fontset) #if-0 the body, which does nothing.
4456 (face_suitable_for_char_p): #if-0, as it's never called.
4457 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4458 * xfaces.c (face_at_string_position):
4459 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4460 since 0 is always ASCII.
4461
dfcf3579
PE
4462 * fns.c (weak_hash_tables): Now static.
4463
5045092b
PE
4464 * fileio.c: Make symbols static if they're not exported.
4465 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4466 (Vwrite_region_annotation_buffers): Now static.
4467
57a96f5c
PE
4468 * eval.c: Make symbols static if they're not exported.
4469 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4470 * lisp.h (backtrace_list): Remove decl.
4471
35f08c38
PE
4472 * emacs.c: Make symbols static if they're not exported.
4473 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4474 (fatal_error_code, fatal_error_signal_hook, standard_args):
4475 Now static.
4476 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4477 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4478 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4479 * lisp.h (fatal_error_signal_hook): Remove decl.
4480 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4481
f44bd759
PE
4482 * editfns.c: Move a (normally-unused) function to its only use.
4483 * editfns.c, lisp.h (get_operating_system_release): Remove.
4484 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4485 worth the hassle of breaking this out.
4486
b532497d
PE
4487 * xterm.c: Make symbols static if they're not exported.
4488 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4489 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4490 (x_destroy_window, x_delete_display):
4491 Now static.
4492 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4493 (x_mouse_leave): Remove; unused.
4494 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4495 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4496 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4497 Remove decls.
4498 (x_mouse_leave): Declare only if WINDOWSNT.
4499 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4500 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4501 USE_X_TOOLKIT.
4502
1675728f
PE
4503 * ftxfont.c: Make symbols static if they're not exported.
4504 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4505 HAVE_FREETYPE.
4506 * font.h (ftxfont_driver): Likewise.
4507
e4cebfca
PE
4508 * xfns.c: Make symbols static if they're not exported.
4509 (x_last_font_name, x_display_info_for_name):
4510 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4511 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4512 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4513 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4514 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4515 (last_show_tip_args): Now static.
4516 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4517 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4518 (x_screen_planes): Remove; unused.
4519 * dispextern.h (x_screen_planes): Remove decl.
4520
5bf46f05
PE
4521 * dispnew.c: Make symbols static if they're not exported.
4522 * dispextern.h (redraw_garbaged_frames, scrolling):
4523 (increment_row_positions): Remove.
4524 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4525 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4526 Now static.
4527 (redraw_garbaged_frames): Remove; unused.
4528
435f4c28
PE
4529 * xfaces.c: Make symbols static if they're not exported.
4530 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4531 Remove decls.
4532 * xterm.h (defined_color): Remove decls.
4533 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4534 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4535 (menu_face_changed_default, defined_color, free_realized_face):
4536 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4537 (ascii_face_of_lisp_face): Remove; unused.
4538
8524aef3
PE
4539 * xdisp.c: Make symbols static if they're not exported.
4540 * dispextern.h (scratch_glyph_row, window_box_edges):
4541 (glyph_to_pixel_coords, set_cursor_from_row):
4542 (get_next_display_element, set_iterator_to_next):
4543 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4544 (show_mouse_face): Remove decls
4545 * frame.h (message_buf_print): Likewise.
4546 * lisp.h (pop_message, set_message, check_point_in_composition):
4547 Likewise.
4548 * xterm.h (set_vertical_scroll_bar): Likewise.
4549 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4550 (message_buf_print, scratch_glyph_row, displayed_buffer):
4551 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4552 (get_next_display_element, show_mouse_face, window_box_edges):
4553 (frame_to_window_pixel_xy, check_point_in_composition):
4554 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4555 (glyph_to_pixel_coords): Remove; unused.
4556
16390cd2
PE
4557 * dired.c (file_name_completion): Now static.
4558
4559 * dbusbind.c (xd_in_read_queued_messages): Now static.
4560
a25f4dfa
PE
4561 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4562 * data.c (circular_list_error): Remove.
4563
14a9c8df
PE
4564 * commands.h (last_point_position, last_point_position_buffer):
4565 (last_point_position_window): Remove decls.
4566 * keyboard.c: Make these variables static.
4567
04f2d78b
CB
4568 * coding.h (coding, code_convert_region, encode_coding_gap):
4569 Remove decls.
74ab6df5
PE
4570 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4571 (iso_code_class, detect_coding, code_convert_region): Now static.
4572 (encode_coding_gap): Remove; unused.
4573
38dfbee1
PE
4574 * chartab.c (chartab_chars, chartab_bits): Now static.
4575
a2cb4e63
PE
4576 * charset.h (charset_iso_8859_1): Remove decl.
4577 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4578 Now static.
4579
127198fd
PE
4580 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4581 * ccl.c (Vccl_program_table): Now static.
4582 (check_ccl_update): Remove; unused.
4583
d85b608f
PE
4584 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4585 * category.h: ... from here.
4586 * category.c (check_category_table, set_category_set): Now static.
4587
31cd66f3
PE
4588 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4589 * lisp.h: Remove these decls.
4590
c358e587
PE
4591 * buffer.c (buffer_count): Remove unused var.
4592
e78aecca
PE
4593 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4594 so that it's not optimized away.
4595 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4596 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4597 exported only to the debugger.
4598
e192d7d3 4599 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4600 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4601
92470028
PE
4602 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4603 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4604 was inaccessible from Lisp.
4605 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4606 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4607
244ed907
PE
4608 alloc.c: Import and export fewer symbols, and remove unused items.
4609 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4610 is defined.
4611 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4612 it's not optimized away by whole-program optimization.
4613 (message_enable_multibyte, free_misc): Remove.
4614 (catchlist, handlerlist, mark_backtrace):
4615 Declare only if BYTE_MARK_STACK.
4616 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4617 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4618 (message_enable_multibyte): Remove decl.
4619 (free_misc, interval_free_list, float_block, float_block_index):
4620 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4621 (cons_free_list, last_marked_index):
4622 Now static.
4623 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4624 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4625 (mark_backtrace): Define only if BYTE_MARK_STACK.
4626 * xdisp.c (message_enable_multibyte): Now static.
4627
61c2b50e 4628 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4629 This makes it easier for human readers (and static analyzers)
4630 to see whether these variables are used from other modules.
4631 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4632 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4633 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4634 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4635 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4636 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4637 * xmenu.c, xselect.c:
4638 Declare Q* vars static if they are not used in other modules.
4639 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4640 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4641 Remove decls of unexported vars.
4642 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4643
95c82688
PE
4644 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4645
16a97296
PE
4646 Make Emacs functions such as Fatom 'static' by default.
4647 This makes it easier for human readers (and static analyzers)
4648 to see whether these functions can be called from other modules.
4649 DEFUN now defines a static function. To make the function external
4650 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4651 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4652 (Finit_image_library):
16a97296
PE
4653 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4654 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4655 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4656 Remove decls, since these functions are now static.
4657 (Funintern, Fget_internal_run_time): New decls, since these functions
4658 were already external.
95c82688 4659
16a97296
PE
4660 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4661 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4662 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4663 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4664 * keyboard.c, keymap.c, lread.c:
4665 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4666 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4667 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4668 Mark functions with DEFUE instead of DEFUN,
4669 if they are used in other modules.
4670 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4671 decls for now-static functions.
4672 * buffer.h (Fdelete_overlay): Remove decl.
4673 * callproc.c (Fgetenv_internal): Mark as internal.
4674 * composite.c (Fremove_list_of_text_properties): Remove decl.
4675 (Fcomposition_get_gstring): New forward static decl.
4676 * composite.h (Fcomposite_get_gstring): Remove decl.
4677 * dired.c (Ffile_attributes): New forward static decl.
4678 * doc.c (Fdocumntation_property): New forward static decl.
4679 * eval.c (Ffetch_bytecode): New forward static decl.
4680 (Funintern): Remove extern decl; now in .h file where it belongs.
4681 * fileio.c (Fmake_symbolic_link): New forward static decl.
4682 * image.c (Finit_image_library): New forward static decl.
4683 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4684 * intervals.h (Fprevious_property_change):
4685 (Fremove_list_of_text_properties): Remove decls.
4686 * keyboard.c (Fthis_command_keys): Remove decl.
4687 (Fcommand_execute): New forward static decl.
4688 * keymap.c (Flookup_key): New forward static decl.
4689 (Fcopy_keymap): Now static.
4690 * keymap.h (Flookup_key): Remove decl.
4691 * process.c (Fget_process): New forward static decl.
4692 (Fprocess_datagram_address): Mark as internal.
4693 * syntax.c (Fsyntax_table_p): New forward static decl.
4694 (skip_chars): Remove duplicate decl.
4695 * textprop.c (Fprevious_property_change): New forward static decl.
4696 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4697 Now internal.
4698 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4699 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4700
785bbd42
PE
4701 * editfns.c (Fformat): Remove unreachable code.
4702
8b913b57
AS
47032011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4704
4705 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4706 change. (Bug#8496)
4707
a6744a35
EZ
47082011-04-13 Eli Zaretskii <eliz@gnu.org>
4709
4710 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4711 when at ZV. (Bug#8487)
4712
e7974947
AS
47132011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4714
baad03f0
AS
4715 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4716 (Bug#8437)
4717 * keyboard.c (parse_tool_bar_item): Likewise.
4718 * sound.c (sound_cleanup, alsa_close): Likewise.
4719 * termcap.c (tgetent): Likewise.
4720 * xfns.c (x_default_font_parameter): Likewise.
4721 * xsettings.c (read_and_apply_settings): Likewise.
4722
e7974947
AS
4723 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4724 (overrun_check_free): Protoize.
4725
28272684
PE
47262011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4727
4728 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4729 since callers should never pass a negative size.
4730 Change the signature to match that of plain 'read' and 'write'; see
4731 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4732 * lisp.h: Update prototypes of emacs_write and emacs_read.
4733
11997c76
EZ
47342011-04-11 Eli Zaretskii <eliz@gnu.org>
4735
4736 * xdisp.c (redisplay_window): Don't try to determine the character
4737 position of the scroll margin if the window start point w->startp
e896f03c 4738 is outside the buffer's accessible region. (Bug#8468)
11997c76 4739
8a2cbd72
EZ
47402011-04-10 Eli Zaretskii <eliz@gnu.org>
4741
4742 Fix write-region and its subroutines for buffers > 2GB.
4743 * fileio.c (a_write, e_write): Modify declaration of arguments and
4744 local variables to support buffers larger than 2GB.
4745 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4746
4747 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4748 argument, local variables, and return value.
4749
4750 * lisp.h: Update prototypes of emacs_write and emacs_read.
4751
4752 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4753
4073e537 47542011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4755
1ebfdcb6
PE
4756 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4757
b2ded58d
PE
4758 Fix more problems found by GCC 4.6.0's static checks.
4759
7d66342c
PE
4760 * xdisp.c (vmessage): Use a better test for character truncation.
4761
bbf47d44
PE
4762 * charset.c (load_charset_map): <, not <=, for optimization,
4763 and to avoid potential problems with integer overflow.
9248994d 4764 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4765 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4766 * editfns.c (Fformat): Likewise.
1e69125e 4767 * syntax.c (skip_chars): Likewise.
3befa583 4768
e3019616
PE
4769 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4770 This also lets GCC 4.6.0 generate slightly better loop code.
4771
becfa255
PE
4772 * callint.c (Fcall_interactively): <, not <=, for optimization.
4773 (Fcall_interactively): Count the number of arguments produced,
4774 not the number of arguments given. This is simpler and lets GCC
4775 4.6.0 generate slightly better code.
4776
dae0cd48
PE
4777 * ftfont.c: Distingish more carefully between FcChar8 and char.
4778 The previous code passed unsigned char * to a functions like
4779 strlen and xstrcasecmp that expect char *, which does not
4780 conform to the C standard.
4781 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4782 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4783 char * when the C standard requires it.
4784
76032d70
PE
4785 * keyboard.c (read_char): Remove unused var.
4786
eb3f1cc8
PE
4787 * eval.c: Port to Windows vsnprintf (Bug#8435).
4788 Include <limits.h>.
4789 (SIZE_MAX): Define if the headers do not.
4790 (verror): Do not give up if vsnprintf returns a negative count.
4791 Instead, grow the buffer. This ports to Windows vsnprintf, which
4792 does not conform to C99. Problem reported by Eli Zaretskii.
4793 Also, simplify the allocation scheme, by avoiding the need for
4794 calling realloc, and removing the ALLOCATED variable.
4795
70476b54
PE
4796 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4797
12020a9e
PE
4798 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4799 But keep the doprint source code for now, as we might revamp it
4800 and use it again (Bug#8435).
ea6c7ae6
PE
4801 * lisp.h (doprnt): Remove.
4802 * Makefile.in (base_obj): Remove doprnt.o.
4803 * deps.mk (doprnt.o): Remove.
4804
5fdb398c
PE
4805 error: Print 32- and 64-bit integers portably (Bug#8435).
4806 Without this change, on typical 64-bit hosts error ("...%d...", N)
4807 was used to print both 32- and 64-bit integers N, which relied on
4808 undefined behavior.
4809 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4810 New macro.
4811 * lisp.h (error, verror): Mark as printf-like functions.
4812 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4813 Report overflow in size calculations when allocating printf buffer.
4814 Do not truncate output string at its first null byte.
4815 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4816 Truncate the output at a character boundary, since vsnprintf does not
4817 do that.
4818 * charset.c (check_iso_charset_parameter): Convert internal
4819 character to string before calling 'error', since %c now has the
4820 printf meaning.
4821 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4822 overflow when computing char to be passed to 'error'. Do not
4823 pass Lisp_Object to 'error'; pass the integer instead.
4824 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4825 formatted with plain %d.
4826
b189fa66
PE
4827 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4828
bff87ef0
PE
4829 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4830
7e2cac20
PE
4831 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4832
ce4d90b5
PE
4833 * xterm.c (x_catch_errors): Remove duplicate declaration.
4834
266c9547
PE
4835 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4836
79c49ad2
PE
4837 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4838
368f4090
JM
48392011-04-10 Jim Meyering <meyering@redhat.com>
4840
4841 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4842 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4843 return ssize_t not "int", and use size_t as the buffer length.
4844 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4845 * gnutls.h: Update declarations.
4846 * process.c (read_process_output): Use ssize_t, to match.
4847 (send_process): Likewise.
4848
a32d4040
CY
48492011-04-09 Chong Yidong <cyd@stupidchicken.com>
4850
4851 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4852
8546720e 48532011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4854
04f2d78b
CB
4855 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4856 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4857
8546720e
GM
4858 * xterm.c (handle_one_xevent):
4859 * xmenu.c (create_and_show_popup_menu):
4860 * xselect.c (x_decline_selection_request)
4861 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4862
0a2f5c1a 48632011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4864
4865 Fix some uses of `int' instead of EMACS_INT.
4866 * search.c (string_match_1, fast_string_match)
4867 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4868 (scan_buffer, find_next_newline_no_quit)
4869 (find_before_next_newline, search_command, Freplace_match)
4870 (Fmatch_data): Make some `int' variables be EMACS_INT.
4871
4872 * xdisp.c (display_count_lines): 3rd argument and return value now
4873 EMACS_INT. All callers changed.
4874 (pint2hrstr): Last argument is now EMACS_INT.
4875
4876 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4877 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4878 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4879 (decode_coding_utf_16, decode_coding_emacs_mule)
4880 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4881 (decode_coding_ccl, decode_coding_charset)
4882 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4883 (decode_coding_iso_2022, decode_coding_emacs_mule)
4884 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4885 <char_offset, last_offset>: Declare EMACS_INT.
4886 (encode_coding_utf_8, encode_coding_utf_16)
4887 (encode_coding_emacs_mule, encode_invocation_designation)
4888 (encode_designation_at_bol, encode_coding_iso_2022)
4889 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4890 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4891 Declare EMACS_INT.
4892 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4893 (encode_invocation_designation): Last argument P_NCHARS is now
4894 EMACS_INT.
4895 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4896 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4897
4898 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4899 All users changed.
4900
4901 * ccl.c (Fccl_execute_on_string): Declare some variables
4902 EMACS_INT.
4903
8546720e 49042011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4905
4906 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4907
4e19a977
CS
49082011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4909
4910 * process.c (Fformat_network_address): Doc fix.
4911
87302331
R
49122011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4913
4914 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4915
cbb59342
CY
49162011-04-08 Chong Yidong <cyd@stupidchicken.com>
4917
4918 * keyboard.c (read_char): Call Lisp function help-form-show,
4919 instead of using internal_with_output_to_temp_buffer.
4920 (Qhelp_form_show): New var.
e0d38eeb 4921 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4922
4923 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4924
4925 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4926
e67a13ab
CY
49272011-04-06 Chong Yidong <cyd@stupidchicken.com>
4928
04f2d78b
CB
4929 * process.c (Flist_processes): Remove to Lisp.
4930 (list_processes_1): Delete.
e67a13ab 4931
973f782d
EZ
49322011-04-06 Eli Zaretskii <eliz@gnu.org>
4933
7c106b1e
EZ
4934 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4935
973f782d
EZ
4936 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4937
41cf7d1a 49382011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4939
ca23cc88
PE
4940 Fix more problems found by GCC 4.6.0's static checks.
4941
f390e2d5
PE
4942 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4943
42eea0d0
PE
4944 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4945
b69769da 4946 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4947
f9541e84
PE
4948 * xdisp.c (vmessage): Mark as a printf-like function.
4949
13841b55
PE
4950 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4951
c136c10f
PE
4952 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4953
5e2d4a30
PE
4954 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4955 printf-like functions.
4956 (tiff_load): Add casts to remove these marks before passing them
4957 to system-supplied API.
4958
583f48b9
PE
4959 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4960
b25d760e
PE
4961 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4962 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4963 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4964 directly, rather than having caller test rule sign. This avoids
4965 some unnecessary tests.
4966 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4967 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4968 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4969
bc7b6697 4970 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4971 (xfont_open): Avoid unnecessary tests.
bc7b6697 4972
27ccc379
PE
4973 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4974
dcd5c89a
PE
4975 * composite.h, composite.c (composition_gstring_put_cache):
4976 Use EMACS_INT, not int, for length.
4977
b13a45c6
PE
4978 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4979 breaking out part of COMPOSITION_DECODE_RULE.
4980 (COMPOSITION_DECODE_RULE): Use it.
4981 * composite.c (get_composition_id): Remove unused local vars,
4982 by using the new macro.
4983
1e792e4d
PE
4984 * textprop.c (set_text_properties_1): Change while to do-while,
4985 since the condition is always true at first.
4986
dc6c6455 4987 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4988 (interval_deletion_adjustment): Return unsigned value.
4989 All uses changed.
dc6c6455 4990
aba7731a
PE
4991 * process.c (list_processes_1, create_pty, read_process_output):
4992 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4993 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4994 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4995 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4996 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4997
fdfc4bf3
PE
4998 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4999
fca8fe46 5000 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5001 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5002
06a0259a 5003 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5004 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5005 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5006
e7b9e80f
PE
5007 * print.c (print_error_message): Avoid int overflow.
5008
56201685
PE
5009 * font.c (font_list_entities): Redo for clarity,
5010 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5011
78834453 5012 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5013 (font_score): Avoid potential overflow in diff calculation.
78834453 5014
0bc0b309 5015 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5016 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5017
e610eaca
PE
5018 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5019
b895abce
PE
5020 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5021 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5022 can always succeed if overflow has undefined behavior.
5023
1f1d9321 5024 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5025 (wordify): Omit three unnecessary tests.
1f1d9321 5026
c59478bc
PE
5027 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5028 All callers changed. This avoids the need for an unused var.
5029
79b73827
PE
5030 * casefiddle.c (casify_region): Remove var that is set but not used.
5031
a4db5dfe
PE
5032 * dired.c (file_name_completion): Remove var that is set but not used.
5033
43aae36e
PE
5034 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5035
2a47c44d 5036 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5037 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5038
a37c69bf
PE
5039 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5040 Check for integer overflow on size calculations.
5041
328ab8e7
PE
5042 * buffer.c (Fprevious_overlay_change): Remove var that is set
5043 but not used.
5044
e5a2a5cb
PE
5045 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5046 Remove vars that are set but not used.
8d84a6eb 5047 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5048 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5049
a60e5f68
PE
5050 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5051
f661cb61 5052 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5053 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5054
f0397f5a
PE
5055 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5056 that are set but not used.
5057
8664db06 5058 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5059 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5060
6abdaa4a
PE
5061 * xselect.c (x_get_local_selection, x_handle_property_notify):
5062 Remove vars that are set but not used.
5063
0ce7538d 5064 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5065 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5066
9ae848fc
PE
5067 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5068 Remove var that is set but not used.
0b918413
PE
5069 (scroll_bar_windows_size): Now size_t, not int.
5070 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5071 Check for overflow.
9ae848fc 5072
a5a62657
PE
5073 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5074 (map_tty_color) [!defined MSDOS]: Likewise.
5075
5c5cdd39
PE
5076 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5077
66ebf983
PE
5078 * coding.c: Remove vars that are set but not used.
5079 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5080 All callers changed.
5081 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5082 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5083 (decode_coding_charset): Remove vars that are set but not used.
5084
1be4d761
PE
5085 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5086 that is set but not used.
5087
47553fa8
PE
5088 * print.c (print_object): Remove var that is set but not used.
5089
1f7196bf 5090 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5091 The gnulib version avoids calling malloc in the usual case,
5092 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5093 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5094 * filelock.c (current_lock_owner): Likewise.
5095 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5096 * sysdep.c: Include allocator.h, careadlinkat.h.
5097 (emacs_no_realloc_allocator): New static constant.
5098 (emacs_readlink): New function.
fdb61804
PE
5099 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5100 ../lib/careadlinkat.h.
d1fdcab7 5101
f84c17c7
SM
51022011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5103
5104 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5105 first non-nil return value).
5106
ef3862ad
JD
51072011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5108
5109 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5110 if not defined (Bug#8403).
5111
376a7006
JB
51122011-04-02 Juanma Barranquero <lekktu@gmail.com>
5113
5114 * xdisp.c (display_count_lines): Remove parameter `start',
5115 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5116 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5117 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5118 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5119 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5120 and thereabouts. All callers changed.
5121 (get_per_char_metric): Remove parameter `f', unused since
5122 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5123
6ca3801d
JM
51242011-04-02 Jim Meyering <meyering@redhat.com>
5125
5126 do not dereference NULL upon failed strdup
5127 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5128 (ns_get_family): Likewise.
5129
d8e2b5ba
JB
51302011-04-02 Juanma Barranquero <lekktu@gmail.com>
5131
5132 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5133
8c74fcbd
JD
51342011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5135
5136 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5137 later (Bug#8403).
5138
7200d79c
SM
51392011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5140
03408648 5141 Add lexical binding.
7200d79c 5142
03408648
SM
5143 * window.c (Ftemp_output_buffer_show): New fun.
5144 (Fsave_window_excursion):
5145 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5146
5147 * lread.c (lisp_file_lexically_bound_p): New function.
5148 (Fload): Bind Qlexical_binding.
5149 (readevalloop): Remove `evalfun' arg.
5150 Bind Qinternal_interpreter_environment.
5151 (Feval_buffer): Bind Qlexical_binding.
5152 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5153 Mark as dynamic.
5154 (syms_of_lread): Declare `lexical-binding'.
5155
5156 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5157
5158 * keyboard.c (eval_dyn): New fun.
5159 (menu_item_eval_property): Use it.
ca105506
SM
5160
5161 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5162
03408648
SM
5163 * fns.c (concat, mapcar1): Accept byte-code-functions.
5164
5165 * eval.c (Fsetq): Handle lexical vars.
5166 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5167 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5168 (FletX, Flet): Obey lexical binding.
5169 (Fcommandp): Handle closures.
5170 (Feval): New `lexical' arg.
5171 (eval_sub): New function extracted from Feval. Use it almost
5172 everywhere where Feval was used. Look up vars in lexical env.
5173 Handle closures.
5174 (Ffunctionp): Move from subr.el.
5175 (Ffuncall): Handle closures.
5176 (apply_lambda): Remove `eval_flags'.
5177 (funcall_lambda): Handle closures and new byte-code-functions.
5178 (Fspecial_variable_p): New function.
5179 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5180 but without exporting it to Lisp.
23aba0ea 5181
23aba0ea 5182 * doc.c (Fdocumentation, store_function_docstring):
03408648 5183 * data.c (Finteractive_form): Handle closures.
23aba0ea 5184
03408648
SM
5185 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5186 interactive spec.
ba83908c 5187
04f2d78b
CB
5188 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5189 New byte-codes.
03408648
SM
5190 (exec_byte_code): New function extracted from Fbyte_code to handle new
5191 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5192
03408648 5193 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5194
03408648 5195 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5196
e2abce01
JB
51972011-03-31 Juanma Barranquero <lekktu@gmail.com>
5198
5199 * xdisp.c (redisplay_internal): Fix prototype.
5200
63696a73 52012011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5202
63696a73 5203 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5204 (try_scrolling): Use it when setting scroll_limit.
5205 Limit scrolling to 100 screen lines.
63696a73
EZ
5206 (redisplay_window): Even when falling back on "recentering",
5207 position point in the window according to scroll-conservatively,
5208 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5209
5210 (try_scrolling): When point is above the window, allow searching
5211 as far as scroll_max, or one screenful, to compute vertical
5212 distance from PT to the scroll margin position. This prevents
5213 try_scrolling from unnecessarily failing when
5214 scroll-conservatively is set to a value slightly larger than the
5215 window height. Clean up the case of PT below the margin at bottom
5216 of window: scroll_max can no longer be INT_MAX. When aggressive
5217 scrolling is in use, don't let point enter the opposite scroll
5218 margin as result of the scroll.
5219 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5220 threshold of 100 lines for never-recentering scrolling.
5221
e4cc2dfc
JB
52222011-03-31 Juanma Barranquero <lekktu@gmail.com>
5223
5224 * dispextern.h (move_it_by_lines):
5225 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5226 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5227 (message_log_check_duplicate): Remove parameters `prev_bol' and
5228 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5229 (redisplay_internal): Remove parameter `preserve_echo_area',
5230 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5231
5232 * indent.c (Fvertical_motion):
5233 * window.c (window_scroll_pixel_based, Frecenter):
5234 Don't pass `need_y_p' to `move_it_by_lines'.
5235
1c470562
SM
52362011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5237
44f230aa
SM
5238 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5239 steal a few bits to be more compact.
5240 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5241 Remove unneeded casts.
5242
1c470562
SM
5243 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5244
888adce9
ZK
52452011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5246
5247 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5248 binding" message (bug#7967).
5249
f838ed7b
PE
52502011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5251
77861b95
PE
5252 Fix more problems found by GCC 4.6.0's static checks.
5253
de6dbc14
PE
5254 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5255 Remove unused local var.
5256
f838ed7b
PE
5257 * editfns.c (Fmessage_box): Remove unused local var.
5258
792c7b2b
PE
5259 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5260 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5261 Omit unused local vars.
c499e557 5262 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5263 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5264 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5265 Omit unused local var.
5266
ba0165e1
PE
5267 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5268 Don't assume string length fits in int.
32ad8845 5269 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5270 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5271
3c59b4c9
PE
5272 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5273 instead of alloca (Bug#8344).
5274
a3eed478 5275 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5276 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5277
eb4d412d
PE
5278 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5279
1658b401
PE
5280 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5281 concerns.
5282
5283 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5284
5285 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5286
9a2c6e05
PE
5287 * keyboard.c (syms_of_keyboard): Use the same style as later
5288 in this function when indexing through an array. This also
5289 works around GCC bug 48267.
5290
03d0a109
PE
5291 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5292
44f730c8
PE
5293 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5294
fe75f926
PE
5295 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5296 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5297
ffa8c828
PE
5298 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5299 This avoids undefined behavior on integer overflow, and is a bit
5300 more convenient anyway since it is compared to a size_t variable.
5301
c5101a77
PE
5302 Variadic C functions now count arguments with size_t, not int.
5303 This avoids an unnecessary limitation on 64-bit machines, which
5304 caused (substring ...) to crash on large vectors (Bug#8344).
5305 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5306 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5307 All variadic functions and their callers changed accordingly.
c5101a77
PE
5308 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5309 * data.c (arith_driver, float_arith_driver): Likewise.
5310 * editfns.c (general_insert_function): Likewise.
5311 * eval.c (struct backtrace.nargs, interactive_p)
5312 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5313 (funcall_lambda, mark_backtrace): Likewise.
5314 * fns.c (concat): Likewise.
5315 * frame.c (x_set_frame_parameters): Likewise.
5316 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5317 0 if not found, not -1. All callers changed.
5318
dd3f25f7
PE
5319 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5320 (stack_copy_size): Now size_t, not int.
5321 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5322
461c2ab9
JB
53232011-03-28 Juanma Barranquero <lekktu@gmail.com>
5324
5325 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5326 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5327 All callers changed.
5328
5329 * lisp.h (multibyte_char_to_unibyte):
5330 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5331 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5332 * character.h (CHAR_TO_BYTE8):
5333 * cmds.c (internal_self_insert):
5334 * editfns.c (general_insert_function):
5335 * keymap.c (push_key_description):
5336 * search.c (Freplace_match):
5337 * xdisp.c (message_dolog, set_message_1): All callers changed.
5338
f6d62986
SM
53392011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5340
5341 * keyboard.c (safe_run_hook_funcall): New function.
5342 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5343 don't set the hook to nil, but remove the offending function instead.
5344 (Qcommand_hook_internal): Remove, unused.
5345 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5346 Vcommand_hook_internal.
5347
5348 * eval.c (enum run_hooks_condition): Remove.
5349 (funcall_nil, funcall_not): New functions.
5350 (run_hook_with_args): Call each function through a `funcall' argument.
5351 Remove `cond' argument, now redundant.
5352 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5353 (Frun_hook_with_args_until_failure): Adjust accordingly.
5354 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5355
1db5b1ad
JB
53562011-03-28 Juanma Barranquero <lekktu@gmail.com>
5357
5358 * dispextern.h (string_buffer_position): Remove declaration.
5359
5360 * print.c (strout): Remove parameter `multibyte', unused since
5361 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5362
5363 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5364 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5365 All callers changed.
5366
5367 * w32.c (_wsa_errlist): Use braces for struct initializers.
5368
5369 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5370 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5371 All callers changed.
5372 (string_buffer_position): Likewise. Also, make static (it's never
5373 used outside xdisp.c).
5374 (cursor_row_p): Remove parameter `w', unused since
5375 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5376 (decode_mode_spec): Remove parameter `precision', introduced during
5377 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5378 All callers changed.
5379
5ffb62aa
JD
53802011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5381
5382 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5383
461c2ab9 53842011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5385
5386 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5387 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5388 (ns_update_auto_hide_menu_bar): New functions.
5389 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5390 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5391 ns_constrain_all_frames.
5392 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5393 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5394
5c380ffb
JD
53952011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5396
5397 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5398
9af30bdf
GM
53992011-03-27 Glenn Morris <rgm@gnu.org>
5400
5401 * syssignal.h: Replace RETSIGTYPE with void.
5402 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5403 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5404 Replace SIGTYPE with void everywhere.
5405 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5406 * s/template.h (SIGTYPE): Remove commented out definition.
5407
e2abce01
JB
54082011-03-26 Eli Zaretskii <eliz@gnu.org>
5409
5410 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5411 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5412
f868cd8a
JB
54132011-03-26 Juanma Barranquero <lekktu@gmail.com>
5414
59eb0929
JB
5415 * w32.c (read_unc_volume): Use parameter `henum', instead of
5416 global variable `wget_enum_handle'.
5417
5418 * keymap.c (describe_vector): Remove parameters `indices' and
5419 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5420 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5421
f868cd8a
JB
5422 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5423
5424 * keyboard.c (timer_check): Remove parameter `do_it_now',
5425 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5426 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5427 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5428
5429 * keyboard.c (read_char):
5430 * w32menu.c (w32_menu_display_help):
5431 * xmenu.c (show_help_event, menu_help_callback):
5432 Adjust calls to `show_help_echo'.
5433
5434 * gtkutil.c (xg_maybe_add_timer):
5435 * keyboard.c (readable_events):
5436 * process.c (wait_reading_process_output):
5437 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5438
5439 * insdel.c (adjust_markers_gap_motion):
5440 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5441 (gap_left, gap_right): Don't call it.
5442
2ecf6fdb
CY
54432011-03-25 Chong Yidong <cyd@stupidchicken.com>
5444
5445 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5446 incurred during fontification.
5447
6b1f9ba4
JB
54482011-03-25 Juanma Barranquero <lekktu@gmail.com>
5449
5450 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5451 (DEFVAR_PER_BUFFER): Don't pass it.
5452
5453 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5454 (scrolling_window): Don't pass it.
5455
0f4a96b5
JB
54562011-03-25 Juanma Barranquero <lekktu@gmail.com>
5457
5458 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5459
5460 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5461 and `suffix'.
5462 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5463 of variables specific to SELinux and computation of `encoded_absname'.
5464
5465 * image.c (XPutPixel): Remove unused variable `height'.
5466
5467 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5468
5469 * unexw32.c (get_section_info): Remove unused variable `section'.
5470
5471 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5472 (system_process_attributes): Remove unused variable `sess'.
5473 (sys_read): Remove unused variable `err'.
5474
5475 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5476 (w32_wnd_proc): Remove unused variable `isdead'.
5477 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5478 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5479 (x_create_tip_frame): Remove unused variable `tem'.
5480
5481 * w32inevt.c (w32_console_read_socket):
5482 Remove unused variable `no_events'.
5483
5484 * w32term.c (x_draw_composite_glyph_string_foreground):
5485 Remove unused variable `width'.
5486
1149507c
JB
54872011-03-24 Juanma Barranquero <lekktu@gmail.com>
5488
5489 * w32term.c (x_set_glyph_string_clipping):
5490 Don't pass uninitialized region to CombineRgn.
5491
9c88f339
JB
54922011-03-23 Juanma Barranquero <lekktu@gmail.com>
5493
5494 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5495 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5496 (Fx_close_connection): Remove unused variable `i'.
5497
5498 * w32font.c (w32font_draw): Return number of glyphs.
5499 (w32font_open_internal): Remove unused variable `i'.
5500 (w32font_driver): Add missing initializer.
5501
5502 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5503 (fill_in_menu): Remove unused variable `items_added'.
5504
5505 * w32term.c (last_mouse_press_frame): Remove static global variable.
5506 (w32_clip_to_row): Remove unused variable `f'.
5507 (x_delete_terminal): Remove unused variable `i'.
5508
5509 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5510 (NOTHING): Remove unused static global variable.
5511 (uniscribe_check_otf): Remove unused variable `table'.
5512 (uniscribe_font_driver): Add missing initializers.
5513
dee091a3
JD
55142011-03-23 Julien Danjou <julien@danjou.info>
5515
5516 * term.c (Fsuspend_tty, Fresume_tty):
5517 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5518 * window.c (temp_output_buffer_show):
5519 * insdel.c (signal_before_change):
5520 * frame.c (Fhandle_switch_frame):
5521 * fileio.c (Fdo_auto_save):
5522 * emacs.c (Fkill_emacs):
5523 * editfns.c (save_excursion_restore):
5524 * cmds.c (internal_self_insert):
5525 * callint.c (Fcall_interactively):
5526 * buffer.c (Fkill_all_local_variables):
5527 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5528 Use Frun_hooks.
0f4a96b5 5529 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5530 unconditionnaly since it does the check itself.
5531
2c520ab5 55322011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5533
c9c49752
PE
5534 Fix more problems found by GCC 4.5.2's static checks.
5535
8abc3f12
PE
5536 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5537 the first time through the loop, since we know p0 < p1 then.
5538 This also avoids a gcc -Wstrict-overflow warning.
5539
a2d26660
PE
5540 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5541 leading to a memory leak, possible in functions like
5542 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5543 of objects (Bug#8318).
a2d26660 5544
916c72e9
PE
5545 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5546 that could (at least in theory) be that large.
5547
19ab8a18
PE
5548 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5549 This is less likely to overflow, and avoids undefined behavior if
5550 overflow does occur. All callers changed. Use strtoul to scan
5551 for the unsigned long integer.
b7cbbd6f
PE
5552 (pint2hrstr): Simplify and tune code slightly.
5553 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5554
f0641eff
PE
5555 * scroll.c (do_scrolling): Work around GCC bug 48228.
5556 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5557
7f650bb9
PE
5558 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5559 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5560 (validate_x_resource_name): Simplify count usage.
5561 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5562
37dd57d1
PE
5563 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5564 fail (Bug#8306).
81e56e61 5565
699979fc 5566 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5567
401bf9b4
PE
5568 * process.c (Fmake_network_process): Use socklen_t, not int,
5569 where POSIX says socklen_t is required in portable programs.
5570 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5571 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5572 (Fmake_network_process, server_accept_connection):
5573 (wait_reading_process_output, read_process_output):
5574 Likewise.
5575
b93aacde
PE
5576 * process.c: Rename or move locals to avoid shadowing.
5577 (list_processes_1, Fmake_network_process):
5578 (read_process_output_error_handler, exec_sentinel_error_handler):
5579 Rename or move locals.
4dc343ee 5580 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5581 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5582 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5583 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5584 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5585
af8a867c 5586 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5587 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5588 Include tparam.h instead, since it declares them.
af8a867c
PE
5589 * cm.h (PC): Remove extern decl; tparam.h now does this.
5590 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5591 * terminfo.c: Include tparam.h, to check interfaces.
5592 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5593 (tparam): Adjust signature to match interface in tparam.h;
5594 this removes some undefined behavior. Check that outstring and len
5595 are zero, which they always are with Emacs.
5596 * tparam.h (PC, BC, UP): New extern decls.
5597
0248044d 5598 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5599 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5600
8ff096c1 5601 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5602 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5603 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5604 (ftfont_list): Remove unused local.
49eaafba
PE
5605 (get_adstyle_property, ftfont_pattern_entity):
5606 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5607 Rename locals to avoid shadowing.
8ff096c1 5608
e2be39f6
PE
5609 * xfont.c (xfont_list_family): Mark var as initialized.
5610
c9735e30
PE
5611 * xml.c (make_dom): Now static.
5612
8f5201ae
PE
5613 * composite.c (composition_compute_stop_pos): Rename local to
5614 avoid shadowing.
b246f932
PE
5615 (composition_reseat_it): Remove unused locals.
5616 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5617 (composition_update_it): Mark var as initialized.
11b61122
PE
5618 (find_automatic_composition): Mark vars as initialized,
5619 with a FIXME (Bug#8290).
8f5201ae 5620
760fbc2c
PE
5621 character.h: Rename locals to avoid shadowing.
5622 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5623 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5624 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5625 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5626 to avoid shadowing.
5627
ff08eb85
PE
5628 * textprop.c (property_change_between_p): Remove; unused.
5629
fc7bf025
PE
5630 * intervals.c (interval_start_pos): Now static.
5631
235d7abc
PE
5632 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5633
44f230aa
SM
5634 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5635 Rename locals to avoid shadowing.
3e7d6594 5636
50060332
PE
5637 * sound.c (wav_play, au_play, Fplay_sound_internal):
5638 Fix pointer signedness.
d01f234b 5639 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5640 (wav_play): Initialize a variable to 0, to prevent undefined
5641 behavior (Bug#8278).
50060332 5642
c4fc4e30
PE
5643 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5644
918436ed
PE
5645 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5646
c939f91b
PE
5647 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5648 clobbering (Bug#8298).
b9c7f648
PE
5649 * sysdep.c (sys_subshell): Likewise.
5650 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5651
6bd8c144
PE
5652 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5653 This should get cleaned up, so that child_setup has the
5654 same signature on all platforms.
5655
7710357c 5656 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5657 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5658
c59da222
CY
56592011-03-22 Chong Yidong <cyd@stupidchicken.com>
5660
5661 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5662 not to be necessary, and produces flickering.
5663
66b87493
GM
56642011-03-20 Glenn Morris <rgm@gnu.org>
5665
5666 * config.in: Remove file.
5667
45b6f6d5
JB
56682011-03-20 Juanma Barranquero <lekktu@gmail.com>
5669
5670 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5671 are now in src/globals.h.
5672 (syms_of_minibuf): Remove spurious & from previous change.
5673
3ec03f7e
LL
56742011-03-20 Leo <sdl.web@gmail.com>
5675
5676 * minibuf.c (completing-read-function): New variable.
5677 (completing-read-default): Rename from completing-read.
5678 (completing-read): Call completing-read-function.
5679
b14e3e21
CY
56802011-03-19 Juanma Barranquero <lekktu@gmail.com>
5681
5682 * xfaces.c (Fx_load_color_file):
5683 Read color file from absolute filename (bug#8250).
5684
f2b726e6
JB
56852011-03-19 Juanma Barranquero <lekktu@gmail.com>
5686
5687 * makefile.w32-in: Update dependencies.
5688
09f6ff02
EZ
56892011-03-17 Eli Zaretskii <eliz@gnu.org>
5690
5691 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5692
29a6015a
PE
56932011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5694
a3a6c54e
PE
5695 Fix more problems found by GCC 4.5.2's static checks.
5696
b766f867
PE
5697 * process.c (make_serial_process_unwind, send_process_trap):
5698 (sigchld_handler): Now static.
5699
be02381c
PE
5700 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5701 That way, the code declares only the vars that it needs.
5702 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5703 * s/cygwin.h (PTY_ITERATION): Likewise.
5704 * s/darwin.h (PTY_ITERATION): Likewise.
5705 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5706
57048744
PE
5707 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5708 * process.c (allocate_pty): Don't declare stb unless it's needed.
5709
7914961c 5710 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5711 (CONSTANTLIM): Remove; unused.
5712 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5713 Define only if needed.
7914961c 5714
b3967b18
PE
5715 * unexelf.c (unexec): Name an expression,
5716 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5717 Use a different way to cause a compilation error if anyone uses
5718 n rather than nn, a way that does not involve shadowing.
73366a00 5719 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5720
29a6015a
PE
5721 * deps.mk (unexalpha.o): Remove; unused.
5722
43cfc33e 5723 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5724 * unexec.h: New file.
ce701a33
PE
5725 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5726 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5727 Depend on unexec.h.
5728 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5729 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5730 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5731 Change as necessary to match prototype in unexec.h.
ce701a33 5732
01f44d5a
PE
5733 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5734 shadowing.
4f63c6bb 5735 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5736
a6670b0b
PE
5737 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5738 Rename locals to avoid shadowing.
5739
cef2010d 5740 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5741 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5742
d4d7173a
PE
5743 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5744
f08b802a
PE
5745 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5746 warning when compiling print.c.
5747
3ddb0639
PE
5748 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5749 instead of using an uninitialized var.
5ad03b97 5750 (font_sort_entities): Mark var as initialized.
3ddb0639 5751
170a2692
PE
5752 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5753
e663c700
PE
5754 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5755 pointers to constants.
89bc529a 5756 (font_parse_fcname): Remove unused vars.
7b81e2d0 5757 (font_delete_unmatched): Now static.
ea838e10 5758 (font_get_spec): Remove; unused.
13a547c6
PE
5759 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5760 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5761 Rename or move locals to avoid shadowing.
e663c700 5762
2a80c887 5763 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5764 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5765
1384fa33 5766 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5767 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5768
8b2c52e9
PE
5769 * alloc.c (mark_backtrace): Move decl from here ...
5770 * lisp.h: ... to here, so that it can be checked.
5771
475545b5 5772 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5773 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5774 (lisp_indirect_variable): Name an expression,
5775 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5776 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5777
b1349114 5778 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5779 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5780 Use const pointer when appropriate.
b1349114 5781
a2928364
PE
5782 * lisp.h (get_system_name, get_operating_system_release):
5783 Move decls here, to check interfaces.
5784 * process.c (get_operating_system_release): Move decl to lisp.h.
5785 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5786 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5787 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5788 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5789 (Fformat_time_string, Fencode_time, Finsert_char):
5790 (Ftranslate_region_internal, Fformat):
5791 Rename or remove local vars to avoid shadowing.
9710023e 5792 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5793
a415e694
PE
5794 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5795 avoid shadowing.
5796
8ef4622d
PE
5797 * lisp.h (eassert): Check that the argument compiles, even if
5798 ENABLE_CHECKING is not defined.
5799
946f9a5b
PE
5800 * data.c (Findirect_variable): Name an expression, to avoid
5801 gcc -Wbad-function-cast warning.
112396d6 5802 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5803 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5804 (Fmake_variable_buffer_local, Fmake_local_variable):
5805 Mark variables as initialized.
52746918 5806 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5807
e5aab7e7 5808 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5809 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5810 Rename locals to avoid shadowing.
dff45157
PE
5811 (mark_stack): Move local variables into the #ifdef region where
5812 they're used.
7bc26fdb
PE
5813 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5814 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5815 needed otherwise.
5816 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5817 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5818 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5819
e5aab7e7
PE
5820 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5821 avoids undefined behavior in theory.
5822
4da60324
PE
5823 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5824
88043301
PE
5825 Use functions, not macros, for up- and down-casing (Bug#8254).
5826 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5827 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5828 to use the following functions instead of these macros.
5829 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5830 EMACS_INT, since callers assume the returned value fits in int.
5831 (upcase1): Likewise, for UPCASE_TABLE.
5832 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5833 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5834 the race-condition problem in the old DOWNCASE.
88043301 5835
19ed5445
PE
5836 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5837 Rename locals to avoid shadowing.
5838 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5839 (regex_compile, re_search_2, re_match_2_internal):
5840 Remove unused local vars.
952db0d7
PE
5841 (FREE_VAR): Rewrite so as not to use empty "else",
5842 which gcc can warn about.
da053e48 5843 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5844 (RETALLOC_IF): Define only if needed.
5845 (WORDCHAR_P): Likewise. This one is never needed, but is used
5846 only in a comment talking about a compiler bug, so put inside
5847 the #if 0 of that comment.
5848 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5849 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5850 Remove; unused.
19ed5445 5851
1f3561e4 5852 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5853 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5854 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5855
ded6f8f7
PE
5856 * search.c (simple_search): Remove unused var.
5857
dbd37a95
PE
5858 * dired.c (compile_pattern): Move decl from here ...
5859 * lisp.h: ... to here, so that it can be checked.
5860 (struct re_registers): New forward decl.
5861
7e47afad
PE
5862 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5863
85f24f61
PE
5864 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5865 All uses changed.
5866 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5867 Rename locals to avoid shadowing.
5671df8f 5868 (Fvertical_motion): Mark locals as initialized.
85f24f61 5869
181aa2be 5870 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5871 (casify_region): Mark local as initialized.
181aa2be 5872
930d429c
PE
5873 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5874
7082eac6
PE
5875 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5876 New macros, so that the caller can use some names other than
5877 gcpro1, gcpro2, etc.
5878 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5879 of the new macros.
5880 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5881 argument, for consistency with GCPRO2_VAR, etc: it is now the
5882 prefix of the variable, not the variable itself. All uses
5883 changed.
38b2c076
PE
5884 * dired.c (directory_files_internal, file_name_completion):
5885 Rename locals to avoid shadowing.
5886
15206ed9
PE
5887 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5888 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5889 dired.c's scmp function, had undefined behavior.
5890 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5891 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5892 * buffer.h: ... to here, because these macros use current_buffer,
5893 and the new implementation with inline functions needs to have
5894 current_buffer in scope now, rather than later when the macros
5895 are used.
5896 (downcase, upcase1): New static inline functions.
5897 (DOWNCASE, UPCASE1): Reimplement using these functions.
5898 This avoids undefined behavior in expressions like
5899 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5900 from race conditions in accessing the global variables
5901 case_temp1 and case_temp2.
5902 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5903 * lisp.h (case_temp1, case_temp2): Remove their decls.
5904 * character.h (ASCII_CHAR_P): Move from here ...
5905 * lisp.h: ... to here, so that the inline functions mentioned
5906 above can use them.
5907
4a6bea26
PE
5908 * dired.c (directory_files_internal_unwind): Now static.
5909
f14b7e14
PE
5910 * fileio.c (file_name_as_directory, directory_file_name):
5911 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5912 Now static.
2893f146
PE
5913 (file_name_as_directory): Use const pointers when appropriate.
5914 (Fexpand_file_name): Likewise. In particular, newdir might
5915 point at constant storage, so make it a const pointer.
fd4ead52 5916 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5917 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5918 signedness issues.
f839df0c
PE
5919 (Fset_file_times, Finsert_file_contents, auto_save_error):
5920 Rename locals to avoid shadowing.
f14b7e14 5921
5716756e 5922 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5923 (Ftry_completion, Fall_completions): Rename or remove locals
5924 to avoid shadowing.
5716756e 5925
b4c3046a
PE
5926 * marker.c (bytepos_to_charpos): Remove; unused.
5927
b45db522
PE
5928 * lisp.h (verify_bytepos, count_markers): New decls,
5929 so that gcc does not warn that these functions aren't declared.
5930
85876d07
PE
5931 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5932 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5933 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5934 (copy_text): Remove unused local var.
85876d07 5935
03d78a21 5936 * filelock.c (within_one_second): Now static.
b3dd38ab 5937 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5938
5df8f01b
PE
5939 * buffer.c (fix_overlays_before): Mark locals as initialized.
5940 (fix_start_end_in_overlays): Likewise. This function should be
5941 simplified by using pointers-to-pointers, but that's a different
5942 matter.
b1d876f1 5943 (switch_to_buffer_1): Now static.
8f54f30a
PE
5944 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5945 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5946
a70072c9 5947 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5948 Fix pointer signedness issue.
edced198
PE
5949 (sys_subshell): Mark local as volatile if checking for lint,
5950 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5951 (MAXPATHLEN): Define only if needed.
a70072c9 5952
a0977c44
PE
5953 * process.c (serial_open, serial_configure): Move decls from here ...
5954 * systty.h: ... to here, so that they can be checked.
5955
a884fdcc
PE
5956 * fns.c (get_random, seed_random): Move extern decls from here ...
5957 * lisp.h: ... to here, so that they can be checked.
5958
604efe86 5959 * sysdep.c (reset_io): Now static.
b8950c94 5960 (wait_for_termination_signal): Remove; unused.
604efe86 5961
38fc62d9
PE
5962 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5963 (copy_keymap_item, append_key, push_text_char_description):
5964 Now static.
1004a21a 5965 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5966 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5967 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5968 (describe_map_tree):
5969 Rename locals to avoid shadowing.
38fc62d9 5970
2f2650da
PE
5971 * keyboard.c: Declare functions static if they are not used elsewhere.
5972 (echo_char, echo_dash, cmd_error, top_level_2):
5973 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5974 (read_char, kbd_buffer_get_event, make_lispy_position):
5975 (make_lispy_event, make_lispy_movement, apply_modifiers):
5976 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5977 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5978 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5979 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5980 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5981
a053e86c 5982 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5983 (mark_kboards): Move decl here ...
5984 * alloc.c (mark_kboards): ... from here.
a053e86c 5985
4752793e
PE
5986 * lisp.h (force_auto_save_soon): New decl.
5987
74f10ca7 5988 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5989 (DEFINE_DUMMY_FUNCTION): New macro.
5990 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5991 Use it.
c03cd23f
PE
5992 (main): Add casts to avoid warnings
5993 if GCC considers string literals to be constants.
74f10ca7 5994
022e70d4
PE
5995 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5996
59d6fe83
PE
5997 * dbusbind.c: Pointer signedness fixes.
5998 (xd_signature, xd_append_arg, xd_initialize):
5999 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6000 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6001 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6002 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6003
78320123
PE
6004 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6005 if GCC considers string literals to be constants.
49cebcca 6006 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6007
35ac2a97
SM
60082011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6009
fb103ca9
SM
6010 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6011 (print_preprocess, print_object): New macro to fix last change.
6012
35ac2a97
SM
6013 * print.c (print_preprocess): Don't forget font objects.
6014
62973b41
JB
60152011-03-16 Juanma Barranquero <lekktu@gmail.com>
6016
6017 * emacs.c (USAGE3): Doc fixes.
6018
0e48bb22
AS
60192011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6020
6021 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6022 structure.
6023
7684e57b
JB
60242011-03-14 Juanma Barranquero <lekktu@gmail.com>
6025
6026 * lisp.h (VWindow_system, Qfile_name_history):
6027 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6028 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6029 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6030
6031 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6032 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6033
6034 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6035 * w32console.c (detect_input_pending, read_input_pending)
6036 (encode_terminal_code):
6037 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6038 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6039 (w32_system_caret_y, Qfile_name_history):
6040 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6041 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6042 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6043 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6044 * w32proc.c (Qlocal, report_file_error):
6045 * w32term.c (Vwindow_system, updating_frame):
6046 * w32uniscribe.c (initialized, uniscribe_font_driver):
6047 Remove unneeded extern declarations.
6048
2aa46d6c
CY
60492011-03-14 Chong Yidong <cyd@stupidchicken.com>
6050
c96bbc66 6051 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6052
cffc6f3b
CY
60532011-03-13 Chong Yidong <cyd@stupidchicken.com>
6054
6055 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6056 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6057 These macros can no longer be used for assignment.
6058
44f230aa
SM
6059 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6060 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6061 (record_buffer_markers, fetch_buffer_markers): New functions for
6062 recording and fetching special buffer markers.
6063 (set_buffer_internal_1, set_buffer_temp): Use them.
6064
6065 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6066
6067 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6068
6069 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6070 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6071
6072 * xdisp.c (hscroll_window_tree):
6073 (reconsider_clip_changes): Use PT instead of BUF_PT.
6074
d251f04b
EZ
60752011-03-13 Eli Zaretskii <eliz@gnu.org>
6076
6077 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6078 $(EMACS_ROOT)/lib/intprops.h.
6079
f0c77cd1
PE
60802011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6081
3eca4629
PE
6082 Fix more problems found by GCC 4.5.2's static checks.
6083
7c86ee98
PE
6084 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6085 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6086 (xg_free_frame_widgets): Make it clear that a local variable is
6087 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6088 (gdk_window_get_screen): Make it clear that this macro is needed
6089 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6090 (int_gtk_range_get_value): New function, which avoids a diagnostic
6091 from gcc -Wbad-function-cast.
6092 (xg_set_toolkit_scroll_bar_thumb): Use it.
6093 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6094 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6095 (get_utf8_string, xg_get_file_with_chooser):
6096 Rename locals to avoid shadowing.
6097 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6098
41729b81
PE
6099 * xgselect.c (xg_select): Remove unused var.
6100
f0c77cd1
PE
6101 * image.c (four_corners_best): Mark locals as initialized.
6102 (gif_load): Initialize transparent_p to zero (Bug#8238).
6103 Mark another local as initialized.
ec6cf4c6 6104 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6105
ce0ad53d 6106 * image.c (clear_image_cache): Now static.
d5d5a617 6107 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6108 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6109 (x_edge_detection): Remove unnecessary cast that
6110 gcc -Wbad-function-cast diagnoses.
2037898d 6111 (gif_load): Fix pointer signedness.
6ae141d6
PE
6112 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6113 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6114
33383987 61152011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6116
d32df629
PE
6117 Improve quality of tests for time stamp overflow.
6118 For example, without this patch (encode-time 0 0 0 1 1
6119 1152921504606846976) returns the obviously-bogus value (-948597
6120 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6121 reports time overflow. See
6122 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6123 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6124 * editfns.c: Include limits.h and intprops.h.
6125 (TIME_T_MIN, TIME_T_MAX): New macros.
6126 (time_overflow): Move earlier, to before first use.
6127 (hi_time, lo_time): New functions, for an accurate test for
6128 out-of-range times.
6129 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6130 (Fget_internal_run_time): Don't assume time_t fits in int.
6131 (make_time): Use list2 instead of Fcons twice.
6132 (Fdecode_time): More accurate test for out-of-range times.
6133 (check_tm_member): New function.
6134 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6135 (lisp_time_argument): Don't rely on undefined left-shift and
6136 right-shift behavior when checking for time stamp overflow.
8be6f318 6137
fe31d94c
PE
6138 * editfns.c (time_overflow): New function, refactoring common code.
6139 (Fformat_time_string, Fdecode_time, Fencode_time):
6140 (Fcurrent_time_string): Use it.
6141
8be6f318
PE
6142 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6143 * dired.c (make_time): Move to ...
6144 * editfns.c (make_time): ... here.
6145 * systime.h: Note the move.
6146
09d9db2c 61472011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6148
126bc0dc
YM
6149 * fringe.c (update_window_fringes): Remove unused variables.
6150
c47cbdfd
YM
6151 * unexmacosx.c (copy_data_segment): Also copy __got section.
6152 (Bug#8223)
6153
7ac80be9
EZ
61542011-03-12 Eli Zaretskii <eliz@gnu.org>
6155
c96bbc66 6156 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6157 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6158 Constify `char *' arguments and their references according to
6159 prototypes in tparam.h.
6160
ecb0f94d 6161 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6162
7ac80be9
EZ
6163 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6164 Adapt all references accordingly.
6165
6166 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6167
ef1fd07e
TT
61682011-03-11 Tom Tromey <tromey@redhat.com>
6169
6170 * buffer.c (syms_of_buffer): Remove obsolete comment.
6171
7ef4b50c
EZ
61722011-03-11 Eli Zaretskii <eliz@gnu.org>
6173
6174 * termhooks.h (encode_terminal_code): Declare prototype.
6175
6176 * msdos.c (encode_terminal_code): Don't declare prototype.
6177
6178 * term.c (encode_terminal_code): Now external again, used by
6179 w32console.c and msdos.c.
6180
44f230aa
SM
6181 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6182 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6183
4b1ec863 61842011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6185
1714f52b 6186 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6187
4b1ec863
PE
6188 * fringe.c (update_window_fringes): Mark locals as initialized
6189 (Bug#8227).
6190 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6191
524c7aa6
PE
6192 * alloc.c (mark_fringe_data): Move decl from here ...
6193 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6194 to check its interface.
6195 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6196
a5c0af81 6197 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6198 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6199 (fontset_font): Mark local as initialized.
a9a06e0b 6200 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6201
b4716021
PE
6202 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6203
811e9bac 6204 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6205 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6206 (x_own_selection, Fx_disown_selection_internal): Rename locals
6207 to avoid shadowing.
6208 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6209
7e3ab302
PE
6210 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6211 so that the caller can use some name other than gcpro1.
6212 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6213 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6214 (Fx_backspace_delete_keys_p):
6215 Use them to avoid shadowing, and rename vars to avoid shadowing.
6216 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6217 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6218 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6219 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6220 Remove unused locals.
7e3ab302
PE
6221 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6222 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6223 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6224 macros.
f78faa98 6225
e2b13473
PE
6226 * xterm.h (x_mouse_leave): New decl.
6227
77f23912
PE
6228 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6229 Remove unused functions.
cdf4ba58
PE
6230 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6231 (x_calc_absolute_position): Now static.
7411c686 6232 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6233 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6234 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6235 unless they are used.
38d0b34a
PE
6236 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6237 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6238 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6239 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6240 (x_error_catcher, x_connection_closed, x_error_handler):
6241 (x_error_quitter, xembed_send_message, x_iconify_frame):
6242 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6243 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6244 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6245
44f230aa
SM
6246 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6247 Rename or move locals to avoid shadowing.
6b463e58 6248 (tty_defined_color, merge_face_heights): Now static.
5967d051 6249 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6250 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6251 does not deduce is never used uninitialized.
73719eba
PE
6252 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6253 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6254
426994c3 6255 * terminal.c (store_terminal_param): Now static.
5489860b 6256
032f1620 6257 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6258 (set_frame_menubar): Remove unused local.
d4323972 6259 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6260 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6261 since they might point to immutable storage.
281585b0
PE
6262 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6263 since it's unused otherwise.
032f1620 6264
367c19e5 6265 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6266 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6267 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6268 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6269 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6270 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6271 does not deduce are never used uninitialized.
70739cbe 6272
07b48fa9
PE
6273 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6274
8868a238 6275 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6276 * window.c (window_loop, size_window):
6277 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6278
7e5cf297 6279 * window.c (display_buffer): Now static.
d6550a9f
PE
6280 (size_window): Mark variables that gcc -Wuninitialized
6281 does not deduce are never used uninitialized.
a586633d
PE
6282 * window.h (check_all_windows): New decl, to forestall
6283 gcc -Wmissing-prototypes diagnostic.
5b555da1 6284 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6285
f6095868
PE
6286 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6287 shadowing.
6288 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6289 Include <limits.h>.
6290 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6291 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6292 (load_charset_map): Mark variables that gcc -Wuninitialized
6293 does not deduce are never used uninitialized.
53df7c11 6294 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6295
f38b440c
PE
6296 * coding.c (coding_set_source, coding_set_destination):
6297 Use "else { /* comment */ }" rather than "else /* comment */;"
6298 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6299 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6300 a block, when the outer 'i' will do.
6301 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6302 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6303 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6304 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6305 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6306 Rename locals to avoid shadowing.
6307 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6308 * coding.c (emacs_mule_char, encode_invocation_designation):
6309 Now static, since they're not used elsewhere.
413bb2db 6310 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6311 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6312 (decode_coding_emacs_mule): Mark variables that gcc
6313 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6314 (detect_coding_iso_2022): Initialize a local variable that might
6315 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6316 this initialization is needed. (Bug#8211)
5f58e762
PE
6317 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6318 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6319 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6320 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6321 Remove unused macros.
f38b440c 6322
232b38b9 6323 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6324 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6325 * character.c (string_count_byte8): Likewise.
232b38b9 6326
fb90da1b
PE
6327 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6328 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6329
fb93dbc2
PE
6330 * chartab.c (copy_sub_char_table): Now static, since it's not used
6331 elsewhere.
5c156ace
PE
6332 (sub_char_table_ref_and_range, char_table_ref_and_range):
6333 Rename locals to avoid shadowing.
bbcd0949 6334 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6335
7d3b3862 6336 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6337 (BIDI_BOB): Remove unused macro.
7d3b3862 6338
6be7d3da
PE
6339 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6340 deduce are never used uninitialized.
c2ed9c8b 6341 * term.c (encode_terminal_code): Likewise.
6be7d3da 6342
75f8807f 6343 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6344
50938595
PE
6345 * tparam.h: New file.
6346 * term.c, tparam.h: Include it.
6347 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6348 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6349 Move these decls to tparam.h, and make them agree with what
6350 is actually in tparam.c. The previous trick of using incompatible
6351 decls in different modules does not conform to the C standard.
6352 All callers of tparam changed to use tparam's actual API.
6353 * tparam.c (tparam1, tparam, tgoto):
6354 Use const pointers where appropriate.
6355
fbceeba2
PE
6356 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6357 * cm.h (struct cm): Likewise.
6358 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6359 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6360 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6361 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6362 (turn_on_face, init_tty): Likewise.
6363 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6364
7f3f1250
PE
6365 * term.c (term_mouse_position): Rename local to avoid shadowing.
6366
e6ca6543
PE
6367 * alloc.c (mark_ttys): Move decl from here ...
6368 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6369
c40f8d15
AS
63702011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6371
6372 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6373
cfe0661d
JB
63742011-03-09 Juanma Barranquero <lekktu@gmail.com>
6375
6376 * search.c (compile_pattern_1): Remove argument regp, unused since
6377 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6378 (compile_pattern): Don't pass it.
6379
0afb4571
J
63802011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6381
6382 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6383 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6384 for ! HAVE_GTK3.
6385 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6386
6387 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6388
6389 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6390 gdk_window_get_screen, gdk_window_get_geometry,
6391 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6392 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6393 (xg_get_pixbuf_from_pixmap): New function.
6394 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6395 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6396 Call xg_get_pixbuf_from_pixmap instead of
6397 gdk_pixbuf_get_from_drawable.
6398 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6399 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6400 (xg_check_special_colors): Use GtkStyleContext and its functions
6401 for HAVE_GTK3.
6402 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6403 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6404 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6405 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6406 Call gtk_widget_get_preferred_size.
0afb4571
J
6407 (xg_frame_resized): gdk_window_get_geometry only takes 5
6408 parameters.
44f230aa
SM
6409 (xg_win_to_widget, xg_event_is_for_menubar):
6410 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6411 (xg_set_widget_bg): New function.
6412 (delete_cb): New function.
895009e1 6413 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6414 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6415 (xg_set_background_color): Call xg_set_widget_bg.
6416 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6417 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6418 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6419 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6420 if ! HAVE_GTK3.
6421 (update_frame_tool_bar): Call gtk_widget_hide.
6422 (xg_initialize): Use GDK_KEY_g.
6423
6424 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6425 if ! HAVE_GTK3
6426 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6427
6428 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6429 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6430 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6431
1c2cc4ef
JB
64322011-03-08 Juanma Barranquero <lekktu@gmail.com>
6433
6434 * w32xfns.c (select_palette): Check success of RealizePalette against
6435 GDI_ERROR, not zero.
6436
33383987 6437See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6438
6439;; Local Variables:
6440;; coding: utf-8
aac0c6e3
MR
6441;; End:
6442
33383987 6443 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6444
6445 This file is part of GNU Emacs.
6446
6447 GNU Emacs is free software: you can redistribute it and/or modify
6448 it under the terms of the GNU General Public License as published by
6449 the Free Software Foundation, either version 3 of the License, or
6450 (at your option) any later version.
6451
6452 GNU Emacs is distributed in the hope that it will be useful,
6453 but WITHOUT ANY WARRANTY; without even the implied warranty of
6454 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6455 GNU General Public License for more details.
6456
6457 You should have received a copy of the GNU General Public License
6458 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.