Remove "#define unix" that is no longer needed (Bug#11905).
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e99a530f
PE
12012-07-10 Paul Eggert <eggert@cs.ucla.edu>
2
22ffb973
PE
3 Remove "#define unix" that is no longer needed (Bug#11905).
4 * s/aix4-2.h (unix): Remove; no longer needed.
5
e9a9ae03
PE
6 EMACS_TIME simplification (Bug#11875).
7 This replaces macros (which typically do not work in GDB)
8 with functions, typedefs and enums, making the code easier to debug.
9 The functional style also makes code easier to read and maintain.
10 * systime.h: Include <sys/time.h> on all hosts, not just if
11 WINDOWSNT, since 'struct timeval' is needed in general.
12 (EMACS_TIME): Now a typedef, not a macro.
13 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
14 not macros.
15 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
16 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
17 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
18 (EMACS_TIME_LE): Now functions, not macros.
19 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
20 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
21 which are not functions. All uses rewritten to use:
22 (make_emacs_time): New function.
23 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
24 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
25 not functions. All uses rewritten to use the following, respectively:
26 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
27 (add_emacs_time, sub_emacs_time): New functions.
28 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
29 * fileio.c (Fcopy_file):
30 * xterm.c (XTflash): Get the current time closer to when it's used.
31 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
32
ffacb126
PE
33 * bytecode.c (targets): Suppress -Woverride-init warnings.
34
e99a530f
PE
35 Simplify by avoiding confusing use of strncpy etc.
36 * doc.c (Fsnarf_documentation):
37 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
38 * frame.c (Fmake_terminal_frame):
39 * gtkutil.c (get_utf8_string):
40 * lread.c (openp):
41 * nsmenu.m (ns_update_menubar):
42 * regex.c (regerror):
43 Prefer memcpy to strncpy and strncat when either will do.
44 * fileio.c (Fsubstitute_in_file_name):
45 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
46 (menu_separator_name_p):
47 * nsmenu.m (ns_update_menubar):
48 Prefer memcmp to strncmp when either will do.
49 * nsterm.m: Include <ftoastr.h>.
50 (ns_get_color):
51 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
52 Prefer snprintf to strncpy.
53 * nsterm.m (ns_term_init):
54 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
55 * nsterm.m (ns_term_init):
56 Avoid the need for strncpy, by using build_string or
57 make_unibyte_string directly. Use dtoastr, not snprintf.
58 * process.c (Fmake_network_process): Diagnose service names that
59 are too long, rather than silently truncating them or creating
60 non-null-terminated names.
61 (Fnetwork_interface_info): Likewise, for interface names.
62 * sysdep.c (system_process_attributes) [GNU_LINUX]:
63 Prefer sprintf to strncat.
64 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
65 Prefer vsnprintf to vsprintf + strncpy.
66
c59592b3
GM
672012-07-10 Glenn Morris <rgm@gnu.org>
68
69 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
70 Clarify fallback case.
71
7d7bbefd
DA
722012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
73
74 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
75 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
76 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
77 * w32menu.c, window.c, xmenu.c: Changed to use XCAR and XCDR
78 where argument type is known to be a Lisp_Cons.
79
3a4c8000
TT
802012-07-10 Tom Tromey <tromey@redhat.com>
81
82 * bytecode.c (BYTE_CODE_THREADED): New macro.
83 (BYTE_CODES): New macro. Replaces all old byte-code defines.
84 (enum byte_code_op): New type.
85 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
86 (exec_byte_code): Use them. Use token threading when applicable.
87
2a0213a6
DA
882012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
89
90 Optimize pure C strings initialization.
91 * lisp.h (make_pure_string): Fix prototype.
92 (build_pure_c_string): New function, defined as static inline. This
93 provides a better opportunity to optimize away calls to strlen when
94 the function is called with compile-time constant argument.
95 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
96 argument, adjust users accordingly. Use build_pure_c_string where
97 appropriate.
98 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
99 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
100 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
101
cb1caeaf
DA
1022012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
103
104 Avoid calls to strlen in miscellaneous functions.
105 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
106 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
107 * lread.c (openp): Likewise.
108
c293e30c
DA
1092012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
110
111 Avoid calls to strlen in path processing functions.
112 * fileio.c (file_name_as_directory): Add comment. Change to add
113 srclen argument and return the length of result. Adjust users
114 accordingly.
115 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 116 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
117 users accordingly.
118 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
119
9e059e3f
GM
1202012-07-10 Glenn Morris <rgm@gnu.org>
121
d02eb359
GM
122 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
123 Move PENDING_OUTPUT_COUNT definition to configure.
124
882cf227
GM
125 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
126 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
127 * s/gnu.h (DATA_START): Move definitions to configure.
128
af6e839f
GM
129 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
130 We include usg5-4-common.h, which defines them both.
131
40289a12
GM
132 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
133 O_RDONLY already includes it).
134
9e059e3f
GM
135 Stop ns builds setting the EMACSLOADPATH environment variable.
136 * nsterm.m (ns_load_path): Rename from ns_init_paths.
137 Now it does not set EMACSLOADPATH, just returns the load-path string.
138 * nsterm.h: Update accordingly.
139 * lread.c [HAVE_NS]: Include nsterm.h.
140 (init_lread) [HAVE_NS]: Use ns_load_path.
141 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
142
7c4e8ec0
GM
1432012-07-09 Glenn Morris <rgm@gnu.org>
144
d4f600ff
GM
145 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
146 since the included bsd-common.h does so.
147
cbb31951
GM
148 Stop ns builds setting the EMACSPATH environment variable.
149 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
150 (ns_init_paths): Do not set EMACSPATH.
151 * nsterm.h (ns_exec_path): Add it.
152 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
153 Use ns_exec_path.
154
7c4e8ec0
GM
155 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
156
26bccfae
PE
1572012-07-09 Paul Eggert <eggert@cs.ucla.edu>
158
a0bee46f
PE
159 * process.c (wait_reading_process_output): 'waitchannels' was unset
160 when read_kbd || !NILP (wait_for_cell); fix this.
161
5994c183
PE
162 Add GCC-style 'const' attribute to functions that can use it.
163 * character.h (char_resolve_modifier_mask):
164 * keyboard.h (make_ctrl_char):
165 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
166 (init_character_once, next_almost_prime, init_fns, init_image)
167 (flush_pending_output, init_sound):
168 * mem-limits.h (start_of_data):
169 * menu.h (finish_menu_items):
170 Add ATTRIBUTE_CONST.
171 * emacs.c (DEFINE_DUMMY_FUNCTION):
172 Declare the dummy function with ATTRIBUTE_CONST.
173 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
174 Add decls with ATTRIBUTE_CONST.
175
26bccfae
PE
176 Minor improvements to make_formatted_string.
177 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
178 where int is good enough, as vsprintf returns an int.
179 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
180
a8290ec3
DA
1812012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
182
183 Use make_formatted_string to avoid double length calculation.
184 * lisp.h (make_formatted_string): New prototype.
185 * alloc.c (make_formatted_string): New function.
186 * buffer.c (Fgenerate_new_buffer_name): Use it.
187 * dbus.c (syms_of_dbusbind): Likewise.
188 * editfns.c (Fcurrent_time_zone): Likewise.
189 * filelock.c (get_boot_time): Likewise.
190 * frame.c (make_terminal_frame, set_term_frame_name)
191 (x_report_frame_params): Likewise.
192 * image.c (gs_load): Likewise.
193 * minibuf.c (get_minibuffer): Likewise.
194 * msdos.c (dos_set_window_size): Likewise.
195 * process.c (make_process): Likewise.
196 * xdisp.c (ensure_echo_area_buffers): Likewise.
197 * xsettings.c (apply_xft_settings): Likewise.
198
d01ba2f1
GM
1992012-07-09 Glenn Morris <rgm@gnu.org>
200
201 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
202 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
203 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
204 * nsterm.h (ns_etc_directory): Add it.
205 * callproc.c [HAVE_NS]: Include nsterm.h.
206 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
207
f1f924b6
DA
2082012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
209
210 Move marker debugging code under MARKER_DEBUG.
211 * marker.c (MARKER_DEBUG): Move marker debugging code under
212 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
213 for bootstrap with --enable-checking (~3x slowdown reported
214 by Juanma Barranquero <lekktu@gmail.com>).
215 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
216
ab531b66
PE
2172012-07-08 Paul Eggert <eggert@cs.ucla.edu>
218
219 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
220 See <http://bugs.gnu.org/11825#29>.
221
c4b3bc8a
EZ
2222012-07-08 Eli Zaretskii <eliz@gnu.org>
223
224 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
225 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
226 (display_line): Add commentary about displaying truncation glyphs
227 on GUI frames.
228 (produce_special_glyphs): Move here from term.c.
229
230 * term.c (produce_special_glyphs): Move to xdisp.c.
231
232 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
233 section.
c4b3bc8a 234
b676b881
AS
2352012-07-07 Andreas Schwab <schwab@linux-m68k.org>
236
f17c5273
AS
237 * xdisp.c (display_line): Avoid warning about implicit declaration
238 of FRAME_FONT.
239
298819b9
AS
240 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
241
b676b881
AS
242 * lisp.h: Remove empty conditional.
243
6045c4fd
PE
2442012-07-07 Paul Eggert <eggert@cs.ucla.edu>
245
b3350bf9
PE
246 * lread.c (load_path_check): Now static.
247
6045c4fd
PE
248 Fix some minor --with-ns problems found by static checking.
249 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
250 (x_set_font) [!HAVE_X_WINDOWS]:
251 * image.c (xpm_load_image) [HAVE_NS]:
252 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
253 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
254 Remove unused local.
255 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
256 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
257 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
258 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
259 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
260 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
261 Fix pointer signedness problem.
262 * xfaces.c (FRAME_X_FONT_TABLE):
263 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
264
929e7845
GM
2652012-07-07 Glenn Morris <rgm@gnu.org>
266
267 * lread.c (load_path_check): New function, split from init_lread.
268 (init_lread): Reorganize. Motivation:
269 If EMACSLOADPATH is set, check/warn about that rather than the
270 defaults, which we are not going to use. Hence we can remove
271 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
272 Don't warn if site-lisp directories are missing.
273 If not installed, start from a blank load-path, since
274 PATH_LOADSEARCH refers to the eventual installation directories.
275
58dd0aa4
EZ
2762012-07-07 Eli Zaretskii <eliz@gnu.org>
277
278 Support truncation and continuation glyphs on GUI frames, when
279 fringes are disabled. (Bug#11832)
280 * xdisp.c (init_iterator): Get dimensions of truncation and
281 continuation glyphs even if on GUI frames. Adjust
282 it->last_visible_x on GUI frames when the left or right fringes,
283 or both, are absent.
284 (start_display, move_it_in_display_line_to): Handle the case of a
285 GUI frame without a fringe to display continuation or truncation
286 glyphs.
287 (insert_left_trunc_glyphs): Support GUI frames: make sure
288 truncation glyphs overwrite enough glyphs from the current line to
289 have sufficient space in pixels.
290 (display_line): Support truncation and continuation glyphs on GUI
291 frames. If some spare pixels are left on the line after inserting
292 the truncation glyphs, fill that space with a stretch glyph of a
293 suitably computed width.
294
295 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
296 produce_glyphs, to support GUI sessions.
297
31571fd7
PE
2982012-07-07 Paul Eggert <eggert@cs.ucla.edu>
299
5a16b9bc
PE
300 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
301
f3047c75
PE
302 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
303
31571fd7
PE
304 Do not require float-time's arg to fit in time_t (Bug#11825).
305 This works better on hosts where time_t is unsigned, and where
306 float-time is applied to the (negative) difference between two times.
307 * editfns.c (decode_time_components): Last arg is now double *,
308 not int *, and means to store all the result as a double, without
309 worrying about whether the seconds part fits in time_t.
310 All callers changed.
311 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
312 All callers changed.
313 (Ffloat_time): Do not fail merely because the specified time falls
314 outside of time_t range.
315
4516fbef
GM
3162012-07-07 Glenn Morris <rgm@gnu.org>
317
318 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
319 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
320 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
321
07adc2c6
JB
3222012-07-07 Juanma Barranquero <lekktu@gmail.com>
323
324 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
325 Update dependencies.
326
327 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
328
fd573f31
PE
3292012-07-06 Paul Eggert <eggert@cs.ucla.edu>
330
fee5959d
PE
331 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
332 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
333 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
334 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
335 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
336 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
337
fd573f31
PE
338 * xfont.c (compare_font_names): Redo to omit the need for casts.
339
ddadbc0e
AS
3402012-07-06 Andreas Schwab <schwab@linux-m68k.org>
341
fca8d6b6
AS
342 * xfns.c (Fx_change_window_property): Doc fix.
343 * w32fns.c (Fx_change_window_property): Doc fix.
344
ddadbc0e
AS
345 * w32fns.c (Fx_window_property): Accept the same arguments as the
346 X Windows version. Doc fix.
347 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
348
f247498e
JB
3492012-07-06 Juanma Barranquero <lekktu@gmail.com>
350 Eli Zaretskii <eliz@gnu.org>
351
352 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
353 Windows-specific code from nt/config.nt moved here.
354 Obsolete settings removed.
355
216ee680
PE
3562012-07-06 Paul Eggert <eggert@cs.ucla.edu>
357
358 * process.c: Avoid unnecessary calls to gettime.
359 (wait_reading_process_output): Don't get the time of day
360 when gobbling data immediately and not waiting, as there's no need
361 for it in that case. This removes a FIXME.
362
bdd091e4
JD
3632012-07-06 Jan Djärv <jan.h.d@swipnet.se>
364
365 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
366 is defined (Bug#11768).
367
9d44f8ce
DA
3682012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
369
370 Fix marker debugging code.
371 * marker.c (byte_char_debug_check): Do not perform the check
372 if buffer is not multibyte.
090bd7cb
JB
373 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
374 Call byte_char_debug_check with correct arguments.
9d44f8ce 375
90fc4786
DA
3762012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
377
378 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
379 * marker.c (byte_char_debug_check, count_markers):
380 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
381 (byte_debug_flag): Remove.
382 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
383 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
384
7b7ae965
DA
3852012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
386
4e57b342
DA
387 Avoid code repetition in marker-related functions.
388 * marker.c (attach_marker): New function.
389 (Fset_marker, set_marker_restricted, set_marker_both)
390 (set_marker_restricted_both): Use it.
391 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
392 Consistently rename charno to charpos.
393 (marker_position): Add eassert.
394 (marker_byte_position): Convert to eassert.
395
3962012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
397
398 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 399 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 400 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 401
657924ff
DA
4022012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
403
404 Introduce fast path for the widely used marker operation.
405 * alloc.c (build_marker): New function.
406 * lisp.h (build_marker): New prototype.
407 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
408 * composite.c (autocmp_chars): Likewise.
409 * editfns.c (buildmark): Remove.
410 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
411 (save_restriction_save): Use build_marker.
412 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
413 * window.c (save_window_save): Likewise.
414
041a49a6
DA
4152012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
416
417 Do not use Fdelete_overlay in delete_all_overlays
418 to avoid redundant calls to unchain_overlay.
419 * buffer.c (drop_overlay): New function.
420 (delete_all_overlays, Fdelete_overlay): Use it.
421 * minibuf.c (get_minibuffer): Fix comment.
422
7dca65a4
PE
4232012-07-06 Paul Eggert <eggert@cs.ucla.edu>
424
425 Port to OpenBSD 5.1 amd64.
426 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
427 This is needed for OpenBSD, and should be harmless on all BSD systems.
428 Also, include <sys/sysctl.h>, as it should be available on all
429 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
430 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
431 use p_pid member, not kp_proc.pid.
432
8eb876e2
GM
4332012-07-06 Glenn Morris <rgm@gnu.org>
434
435 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
436
38182d90
PE
4372012-07-05 Paul Eggert <eggert@cs.ucla.edu>
438
439 More xmalloc and related cleanup.
440 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
441 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
442 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
443 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
444 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
445 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
446 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
447 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
448 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
449 * xterm.c:
450 Omit needless casts involving void * pointers and allocation.
451 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
452 as the former is more robust if P's type is changed.
453 Prefer xzalloc to xmalloc + memset 0.
454 Simplify malloc-or-realloc to realloc.
455 Don't worry about xmalloc returning a null pointer.
456 Prefer xstrdup to xmalloc + strcpy.
457 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
458 growing it.
459 * keyboard.c (apply_modifiers_uncached): Prefer local array to
460 alloca of a constant.
461
6dd5a677
EZ
4622012-07-05 Eli Zaretskii <eliz@gnu.org>
463
464 * xdisp.c (display_line): Fix horizontal pixel coordinates when
465 hscroll is larger than the line width. Fixes long and futile
466 looping inside extend_face_to_end_of_line (on a TTY) producing
467 glyphs that are not needed and thrown away.
468
6b312f0f
DA
4692012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
470
471 * marker.c (set_marker_restricted_both): Simplify by using
472 clip_to_bounds.
473
f520ef9b
PE
4742012-07-05 Paul Eggert <eggert@cs.ucla.edu>
475
476 * editfns.c (region_limit): Simplify by using clip_to_bounds.
477
383b7c95
JD
4782012-07-05 Jan Djärv <jan.h.d@swipnet.se>
479
480 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
481 not defined (Bug#11768).
482 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
483 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
484 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
485 followed by gtk_box_set_homogeneous (Bug#11768).
486 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
487 (update_theme_scrollbar_width, xg_create_scroll_bar):
488 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
489 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
490 (is_box_type): New function (Bug#11768).
491 (xg_tool_item_stale_p): Call is_box_type.
5293d758 492 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
493 with default display (Bug#11768).
494
d6e7bf45
EZ
4952012-07-05 Eli Zaretskii <eliz@gnu.org>
496
497 * xdisp.c (window_hscroll_limited): New function.
498 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
499 coordinates when window's hscroll is set to insanely large
500 values. (Bug#11857)
501
431391ec
JB
5022012-07-05 Juanma Barranquero <lekktu@gmail.com>
503
504 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
505 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
506
23f86fce
DA
5072012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
508
509 Cleanup xmalloc.
510 * lisp.h (xzalloc): New prototype. Omit needless casts.
511 * alloc.c (xzalloc): New function. Omit needless casts.
512 * charset.c: Omit needless casts. Convert all calls to
513 xmalloc with following memset to xzalloc.
514 * dispnew.c: Likewise.
515 * fringe.c: Likewise.
516 * image.c: Likewise.
517 * sound.c: Likewise.
518 * term.c: Likewise.
519 * w32fns.c: Likewise.
520 * w32font.c: Likewise.
521 * w32term.c: Likewise.
522 * xfaces.c: Likewise.
523 * xfns.c: Likewise.
524 * xterm.c: Likewise.
525 * atimer.c: Omit needless casts.
526 * buffer.c: Likewise.
527 * callproc.c: Likewise.
528 * ccl.c: Likewise.
529 * coding.c: Likewise.
530 * composite.c: Likewise.
531 * doc.c: Likewise.
532 * doprnt.c: Likewise.
533 * editfns.c: Likewise.
534 * emacs.c: Likewise.
535 * eval.c: Likewise.
536 * filelock.c: Likewise.
537 * fns.c: Likewise.
538 * gtkutil.c: Likewise.
539 * keyboard.c: Likewise.
540 * lisp.h: Likewise.
541 * lread.c: Likewise.
542 * minibuf.c: Likewise.
543 * msdos.c: Likewise.
544 * print.c: Likewise.
545 * process.c: Likewise.
546 * region-cache.c: Likewise.
547 * search.c: Likewise.
548 * sysdep.c: Likewise.
549 * termcap.c: Likewise.
550 * terminal.c: Likewise.
551 * tparam.c: Likewise.
552 * w16select.c: Likewise.
553 * w32.c: Likewise.
554 * w32reg.c: Likewise.
555 * w32select.c: Likewise.
556 * w32uniscribe.c: Likewise.
557 * widget.c: Likewise.
558 * xdisp.c: Likewise.
559 * xmenu.c: Likewise.
560 * xrdb.c: Likewise.
561 * xselect.c: Likewise.
562
0497dc44
PE
5632012-07-05 Paul Eggert <eggert@cs.ucla.edu>
564
565 * fileio.c (time_error_value): Check the right error number.
566 Problem reported by Troels Nielsen in
567 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
568
356e7178
PE
5692012-07-04 Paul Eggert <eggert@cs.ucla.edu>
570
4e71fd89
PE
571 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
572 This should be fixed in a better way; see Eli Zaretskii in
573 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
574 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
575
f0941253
PE
576 * fileio.c (time_error_value): Rename from special_mtime.
577 The old name's problems were noted by Eli Zaretskii in
578 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
579
065c9eb4
PE
580 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
581 This variable's comment says Emacs needs at least one GDB-visible
582 symbol of type enum pvec_type, to work around GDB problems.
583 The symbol's value doesn't matter.
584
356e7178
PE
585 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
586 that causes compilation to fail on pre-C99 compilers.
587
95f61aa2
JB
5882012-07-04 Juanma Barranquero <lekktu@gmail.com>
589
590 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
591 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
592
3884d954
DA
5932012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
594
d209e2fb 595 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
596 headers for buffer_defaults and buffer_local_symbols.
597 Reported by Juanma Barranquero <lekktu@gmail.com>.
598
ee28be33
SM
5992012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
600
601 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
602 * lisp.h (enum pvec_type): Use fewer bits.
603 (PSEUDOVECTOR_SIZE_BITS): New constant.
604 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
605 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
606 change in pvec_type.
607 (PSEUDOVECTOR_TYPEP): New macro.
608 (TYPED_PSEUDOVECTORP): Use it.
609 * fns.c (internal_equal): Adapt code to extract pvectype.
610 * emacs.c (gdb_pvec_type): Update type.
611 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
612 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
613 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
614 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
615 (sweep_vectors): Use it. Use local var `total_bytes' instead of
616 abusing vector->header.next.nbytes.
617 (live_vector_p): Use PVEC_TYPE.
618 (mark_object): Adapt code to extract pvectype. Use switch.
619
c7f2cd7f
PE
6202012-07-04 Paul Eggert <eggert@cs.ucla.edu>
621
622 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
623 Tighten new eassert a bit.
624
8ce70ed2
DA
6252012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
626
627 Fix compilation with --enable-gcc-warnings and -O1
628 optimization level.
629 * doprnt.c (doprnt): Change type of tem to int, initialize
630 to avoid compiler warning. Add eassert.
631 * search.c (simple_search): Initialize match_byte to avoid
632 compiler warning. Add eassert.
633
dea7f1e5
PE
6342012-07-04 Paul Eggert <eggert@cs.ucla.edu>
635
24a212eb
PE
636 Avoid weird behavior with large horizontal scrolls.
637 Without this change, for example, large hscroll values would
638 mess up Emacs's display on Fedora 15 x86, presumably due to
639 overflows in int calculations in the display code.
640 Also, if buffers had long lines, Emacs would freeze.
641 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
642 (set_window_hscroll): New function, containing the old guts of
643 Fset_window_hscroll. Return the clipped value.
644 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
645 This avoids the need to check against PTRDIFF_MAX.
646
dea7f1e5
PE
647 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
648
76046526
DA
6492012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
650
651 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
652
39adff0d
PE
6532012-07-04 Paul Eggert <eggert@cs.ucla.edu>
654
63807d47
PE
655 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
656 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
657 since GCC 4.4.6 issues a bogus warning for them.
658
39adff0d
PE
659 Fix bugs in file timestamp newness comparisons.
660 * fileio.c (Ffile_newer_than_file_p):
661 * lread.c (Fload): Use full timestamp resolution of files,
662 not just the 1-second resolution, so that files that are only
663 slightly newer still count as newer.
664 * fileio.c (Ffile_newer_than_file_p): Don't assume file
665 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
666
dbeed9a6
PE
6672012-07-03 Paul Eggert <eggert@cs.ucla.edu>
668
669 * fileio.c: Improve handling of file time marker. (Bug#11852)
670 (special_mtime): New function.
671 (Finsert_file_contents, Fverify_visited_file_modtime):
672 Use it to set special mtime values consistently.
673
636334d6
AS
6742012-07-03 Andreas Schwab <schwab@linux-m68k.org>
675
676 * fileio.c (Finsert_file_contents): Properly handle st_mtime
677 marker for non-existing file. (Bug#11852)
678
e2017fe2
GM
6792012-07-03 Glenn Morris <rgm@gnu.org>
680
681 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
682 and did not make it into globals.h).
683
404dbd37
TT
6842012-07-03 Tom Tromey <tromey@redhat.com>
685
686 * window.c (Fset_window_margins, Fset_window_fringes)
687 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
688 * textprop.c (Fprevious_property_change): No longer static.
689 * syntax.c (Fsyntax_table_p): No longer static.
690 * process.c (Fget_process, Fprocess_datagram_address): No longer
691 static.
692 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
693 * keyboard.c (Fcommand_execute): No longer static.
694 Remove EXFUN.
695 * insdel.c (Fcombine_after_change_execute): No longer static.
696 * image.c (Finit_image_library): No longer static.
697 * fileio.c (Fmake_symbolic_link): No longer static.
698 * eval.c (Ffetch_bytecode): No longer static.
699 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
700 * doc.c (Fdocumentation_property, Fsnarf_documentation):
701 No longer static.
404dbd37
TT
702 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
703 static.
704 * dired.c (Ffile_attributes): No longer static.
705 * composite.c (Fcomposition_get_gstring): No longer static.
706 * callproc.c (Fgetenv_internal): No longer static.
707
708 * ccl.h: Remove EXFUNs.
709 * buffer.h: Remove EXFUNs.
710 * dispextern.h: Remove EXFUNs.
711 * intervals.h: Remove EXFUNs.
712 * fontset.h: Remove EXFUN.
713 * font.h: Remove EXFUNs.
714 * dosfns.c (system_process_attributes): Remove EXFUN.
715 * keymap.h: Remove EXFUNs.
716 * lisp.h: Remove EXFUNs.
717 * w32term.h: Remove EXFUNs.
718 * window.h: Remove EXFUNs.
719 * xsettings.h: Remove EXFUN.
720 * xterm.h: Remove EXFUN.
721
8e4fd1e1
GM
7222012-07-03 Glenn Morris <rgm@gnu.org>
723
724 * lisp.h (Frandom): Make it visible to C.
725 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
726 buffer for invisible buffers. (Bug#1229)
727
ca95b3eb
DA
7282012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
729
730 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
731 values which aren't power of 2.
732 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
733 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
734 accordingly.
735
7555c33f
SM
7362012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
737
738 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
739
740 * alloc.c (mark_object): Revert part of last patch to use `switch'.
741
d12e8f5a
DA
7422012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
743
744 * alloc.c (allocate_vector_block): Remove redundant
745 calls to mallopt if DOUG_LEA_MALLOC is defined.
746 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
747 avoid calls to mallopt if zero_vector is returned.
748
296094c3
DA
7492012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
750
751 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
752 is enabled, avoid dereferencing NULL current_sblock if
753 running undumped.
754
36429c89
DA
7552012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
756
757 Cleanup basic buffer management.
758 * buffer.h (struct buffer): Change layout to use generic vector
759 marking code. Fix some comments. Change type of 'clip_changed'
760 to bitfield. Remove unused #ifndef old.
761 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
762 (GET_OVERLAYS_AT): Fix indentation.
763 (for_each_per_buffer_object_at): New macro.
764 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
765 (Fbuffer_local_variables): Use it.
766 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
767 * alloc.c (allocate_buffer): Adjust to match new layout of
768 struct buffer. Fix comment.
769 (mark_overlay): New function.
770 (mark_buffer): Use it. Use mark_vectorlike to mark normal
771 Lisp area of struct buffer.
772 (mark_object): Use it. Adjust marking of misc objects
773 and related comments.
774
3b3e4cac
PE
7752012-07-02 Paul Eggert <eggert@cs.ucla.edu>
776
777 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
778 wrapper that is not needed because the wrapped code is a no-op (zero
779 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
780 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
781
cf5c0175
DA
7822012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
783
784 * alloc.c (mark_buffer): Simplify. Remove prototype.
785 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 786 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
787 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
788 redundant calls to mark_vectorlike for bool vectors.
789
ca26824c
GM
7902012-06-30 Glenn Morris <rgm@gnu.org>
791
2e4c5312
GM
792 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
793
ca26824c
GM
794 * epaths.in (PATH_SITELOADSEARCH): New.
795 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
796 This is rather than relying on --enable-locallisppath elements
797 having "site-lisp" in their names. (Bug#10208#25, 11658)
798
0d23c240
EZ
7992012-06-30 Eli Zaretskii <eliz@gnu.org>
800
c9240d7a
EZ
801 * w32proc.c (sys_select): Accept and ignore one more argument.
802
803 * w32.c (emacs_gnutls_pull): Call select with one more argument.
804
0d23c240 805 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 806 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
807
808 * sysdep.c: Don't include dos.h and dosfns.h.
809
810 * process.c (sys_select):
811 * msdos.c (sys_select): Accept one more argument and ignore it.
812
813 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
814 adapt data types and code to that.
815
816 * dosfns.c:
817 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
818 which clashes with the gnulib function of the same name.
819
af5a5a98
AS
8202012-06-30 Andreas Schwab <schwab@linux-m68k.org>
821
c5e4379c
AS
822 * font.c (font_style_to_value, font_style_symbolic)
823 (font_prop_validate_style): Add type checks for values in
824 font_style_table.
825
af5a5a98
AS
826 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
827 argument.
828 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
829 uses.
830
8d38f461
EZ
8312012-06-29 Eli Zaretskii <eliz@gnu.org>
832
2e5a6631
EZ
833 * xdisp.c (try_window_id): Undo last change.
834
8d38f461
EZ
835 * w32.c (getwd): Adjust commentary about startup_dir.
836 (init_environment): Always call sys_access, even in non-MSVC
837 builds. Don't chdir to the directory of the Emacs executable.
838 This undoes code from 1997 which was justified by the need to
839 "avoid conflicts when removing and renaming directories". But its
840 downside was that every relative file name was being interpreted
841 relative to the directory of the Emacs executable, which can never
842 be TRT. In particular, it broke sys_access when called with
843 relative file names.
844 (sys_access): Map GetLastError to errno.
845
2af3565e
DA
8462012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
847
848 * window.h (struct window): Change type of 'fringes_outside_margins'
849 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 850 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
851 Adjust comment.
852 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
853 to ptrdiff_t.
854
c8d3a25c 8552012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 856
c8d3a25c
GM
857 * gnutls.c (emacs_gnutls_handshake):
858 Add QUIT to make the loop interruptible.
57570cd3 859
c8d3a25c 8602012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 861
c8d3a25c
GM
862 * charset.c (init_charset): Make lack of etc/charsets fatal.
863
3e984ee8
DA
8642012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
865
866 * editfns.c (region_limit): Fix type mismatch.
867
ef884f23
DA
8682012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
869
870 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
871 undefined. Convert from xassert to eassert.
872 * nsmenu.m: Convert from xassert to eassert.
873 * nsterm.m: Likewise.
874
7d7e0027
SM
8752012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
876
877 * editfns.c (region_limit): Clip to narrowing (bug#11770).
878
aa754e6a
PE
8792012-06-28 Paul Eggert <eggert@cs.ucla.edu>
880
881 Avoid integer overflow on scroll-left and scroll-right.
882 * window.c (HSCROLL_MAX): New macro.
883 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
884 overflow when requested scroll falls outside ptrdiff_t range.
885
80b00b08
DA
8862012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
887
888 * window.h (struct window): Change type of 'hscroll',
889 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
890 'last_modified' and 'last_overlay_modified' to EMACS_INT.
891 Adjust users accordingly.
892 * xdisp.c (try_cursor_movement): Replace type check with eassert.
893 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
894 from EMACS_INT to ptrdiff_t.
895 (make_window): Omit redundant initialization.
896
62b2bcf6
JB
8972012-06-28 Juanma Barranquero <lekktu@gmail.com>
898
899 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
900
45942c7d
DA
9012012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
902
903 * window.h (struct window): Change type of 'use_time' and
904 'sequence_number' from Lisp_Object to int.
905 * frame.c (make_frame): Adjust users accordingly.
906 * print.c (print_object): Likewise.
907 * window.c (select_window, Fwindow_use_time, make_parent_window)
908 (make_window): Likewise.
909
e509cfa6
DA
9102012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
911
912 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
913 enabled with --enable-checking=[all,glyphs] configure option.
914 Fix GLYPH_DEBUG usage assuming that it may be undefined,
915 adjust comments accordingly.
916 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
917 undefined, adjust comments accordingly.
918 * image.c: Likewise.
919 * scroll.c: Likewise.
920 * w32fns.c: Likewise.
921 * w32term.c: Likewise.
922 * xdisp.c: Likewise.
923 * xfaces.c: Likewise.
924 * xfns.c: Likewise.
925 * xterm.c: Likewise.
926
a54e2c05
DA
9272012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
928
929 Generalize run-time debugging checks.
930 * dispextern.h (XASSERTS): Remove.
931 * fontset.c (xassert): Remove.
932 Convert from xassert to eassert.
933 * alloc.c: Convert from xassert to eassert.
934 * bidi.c: Likewise.
935 * dispnew.c: Likewise.
936 * fns.c: Likewise.
937 * fringe.c: Likewise.
938 * ftfont.c: Likewise.
939 * gtkutil.c: Likewise.
940 * image.c: Likewise.
941 * keyboard.c: Likewise.
942 * menu.c: Likewise.
943 * process.c: Likewise.
944 * scroll.c: Likewise.
945 * sound.c: Likewise.
946 * term.c: Likewise.
947 * w32console.c: Likewise.
948 * w32fns.c: Likewise.
949 * w32term.c: Likewise.
950 * window.c: Likewise.
951 * xdisp.c: Likewise.
952 * xfaces.c: Likewise.
953 * xfns.c: Likewise.
954 * xselect.c: Likewise.
955 * xterm.c: Likewise.
956
1ec4b7b2
SM
9572012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
958
959 * fns.c (maybe_resize_hash_table): Output message when growing the
960 purify-hashtable.
961
2014308a
DA
9622012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
963
964 * alloc.c (allocate_string_data): Remove dead code.
965 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
966 avoid GCC warning about unused macro.
967
246155eb
DA
9682012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
969
970 * alloc.c (allocate_string): Omit intervals initialization.
971 * alloc.c (make_uninit_multibyte_string): Initialize intervals
972 as in make_pure_string and make_pure_c_string.
973
43184b7b
DA
9742012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
975
d209e2fb 976 * alloc.c (allocate_string): Fix last change.
43184b7b 977
3fe6dd74
DA
9782012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
979
d209e2fb 980 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
981 to memset, add explicit initialization where appropriate.
982
1ba6038a
GM
9832012-06-27 Glenn Morris <rgm@gnu.org>
984
985 * lisp.mk (lisp): Remove paths.elc.
986
c89926a5
CY
9872012-06-27 Chong Yidong <cyd@gnu.org>
988
989 * doc.c (Fsubstitute_command_keys): Fix punctuation.
990
ed6b3510
JW
9912012-06-26 John Wiegley <johnw@newartisans.com>
992
1ec4b7b2 993 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
994 on Mac OS X Lion: __mod_init_func and __mod_term_func.
995
ed6b3510
JW
996 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
997 when building with Clang.
998
8edd4a2b
SM
9992012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1000
1001 * eval.c (Fapply): Allow calling it with a single argument.
1002
f6f62d1b
EZ
10032012-06-26 Eli Zaretskii <eliz@gnu.org>
1004
1005 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1006 _stricmp and _strnicmp.
1007 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1008
62efea5e
DA
10092012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1010
1011 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1012 allocated window.
1013 (allocate_process): Likewise for new process.
8edd4a2b 1014 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1015 (allocate_frame): Likewise.
1016 * frame.c (make_frame): Omit redundant initialization.
1017 * window.c (make_parent_window): Use memset.
1018 (make_window): Omit redundant initialization.
1019 * process.c (make_process): Omit redundant initialization.
1020 * terminal.c (create_terminal): Likewise.
1021
42997f4d
DA
10222012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1023
1024 * term.c (delete_tty): Remove redundant call to memset.
1025
1130ecfc
DA
10262012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1027
1028 * alloc.c: Remove build_string.
1029 * lisp.h: Define build_string as static inline. This provides
1030 a better opportunity to optimize away calls to strlen when the
1031 function is called with compile-time constant argument.
1032 * image.c (imagemagick_error): Convert to build_string.
1033 * w32proc.c (sys_spawnve): Likewise.
1034 * xterm.c (x_term_init): Likewise.
1035
cf38a720
PE
10362012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1037
99027bdd
PE
1038 Use sprintf return value instead of invoking strlen on result.
1039 In the old days this wasn't portable, since some sprintf
1040 implementations returned char *. But they died out years ago and
1041 Emacs already assumes sprintf returns int.
1042 Similarly for float_to_string.
1043 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1044 * ccl.c (ccl_driver):
1045 * character.c (string_escape_byte8):
1046 * data.c (Fnumber_to_string):
1047 * doprnt.c (doprnt):
1048 * print.c (print_object):
1049 * xdisp.c (message_dolog):
1050 * xfns.c (syms_of_xfns):
1051 Use sprintf or float_to_string result to avoid need to call strlen.
1052 * data.c (Fnumber_to_string):
1053 Use make_unibyte_string, since the string must be ASCII.
1054 * lisp.h, print.c (float_to_string): Now returns int length.
1055 * term.c (produce_glyphless_glyph):
1056 Use sprintf result rather than recomputing it.
1057
cf38a720
PE
1058 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1059 * Makefile.in (ALL_CFLAGS):
1060 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1061 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1062
3511c784
DA
10632012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1064
0a08eb21 1065 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1066 strcasecmp if available.
1067 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1068
fb7da12e
AS
10692012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1070
1071 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1072 Avoid comma operator.
1073 * menu.c (push_submenu_start, push_submenu_end)
1074 (push_left_right_boundary, push_menu_pane): Likewise.
1075 * msdos.c (dos_rawgetc): Likewise.
1076
afa2ffd8
DA
10772012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1078
1079 * xfns.c (xic_create_fontsetname): Remove redundant calls
1080 to memset.
1081
b3b4476b
PE
10822012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1083
4495ff38
PE
1084 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1085 sprintf already null-terminates its output.
1086
b3b4476b
PE
1087 * xfns.c (x_window): Remove redundant cast.
1088
b00876c9
DA
10892012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1090
1091 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1092 `const char *' to `char *' to avoid compiler warning.
1093
d188e26b
PE
10942012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1095
885d1d74
PE
1096 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1097 instead of truncating it to 63 (admittedly a generous limit).
1098
d188e26b
PE
1099 * process.c: Fix spelling and caps in comments.
1100
e2f560b1
DN
11012012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1102
e86db54b 1103 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1104 * sysdep.c (setpgrp): Remove definition, not used in this file.
1105
7583a3a1
JB
11062012-06-24 Juanma Barranquero <lekktu@gmail.com>
1107
1108 * makefile.w32-in: Update dependencies.
1109
696056c2
EZ
11102012-06-24 Eli Zaretskii <eliz@gnu.org>
1111
1112 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1113 (SYSTIME_H): Add nt/inc/sys/time.h.
1114
1115 * systime.h [WINDOWSNT]: Include sys/time.h.
1116
1117 * s/ms-w32.h (struct timespec): Definition moved from
1118 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1119
845ca893
PE
11202012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1121
1122 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1123 * buffer.h (buffer_slot_type_mismatch):
1124 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1125 * eval.c (unwind_to_catch):
1126 * image.c (my_png_error, my_error_exit):
1127 * keyboard.c (quit_throw_to_read_char, user_error)
1128 (Fexit_recursive_edit, Fabort_recursive_edit):
1129 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1130 (wrong_type_argument, buffer_overflow, __executable_start)
1131 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1132 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1133 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1134 (fatal):
1135 (child_setup) [!DOS_NT]:
1136 * lread.c (end_of_file_error, invalid_syntax):
1137 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1138 * puresize.h (pure_write_error):
1139 * search.c (matcher_overflow):
1140 * sound.c (sound_perror, alsa_sound_perror):
1141 * sysdep.c, syssignal.h (croak):
1142 * term.c (maybe_fatal, vfatal):
1143 * textprop.c (text_read_only):
1144 * undo.c (user_error):
1145 * unexmacosx.c (unexec_error):
1146 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1147 Use _Noreturn rather than NO_RETURN.
1148 No need for separate decl merely because of _Noreturn.
1149 * sound.c (sound_warning, parse_sound):
1150 Remove unnecessary forward decls.
1151
f1dd8073
PE
11522012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1153
1154 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1155 * lisp.h (WAIT_READING_MAX): New macro.
1156 * dispnew.c (Fsleep_for, sit_for):
1157 * keyboard.c (kbd_buffer_get_event):
1158 * process.c (Faccept_process_output):
1159 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1160 This improves on the previous patch, which introduced a bug
1161 when time_t is unsigned and as wide as intmax_t.
1162 See <http://bugs.gnu.org/9000#51>.
1163
b82c1755
EZ
11642012-06-23 Eli Zaretskii <eliz@gnu.org>
1165
1166 * dispnew.c (sit_for, Fsleep_for):
1167 * keyboard.c (kbd_buffer_get_event):
1168 * process.c (Faccept_process_output): Avoid compiler warnings when
1169 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1170
ca300656
JB
11712012-06-23 Juanma Barranquero <lekktu@gmail.com>
1172
049ec95b
JB
1173 * makefile.w32-in: Update dependencies.
1174
ca300656
JB
1175 * w32.c (ltime): Add return type and declare static.
1176 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1177
db7b8d06
PE
11782012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1179
1180 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1181 Privately reported by Herbert J. Skuhra.
1182 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1183 All uses changed.
1184 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1185 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1186
0bd8297f
EZ
11872012-06-23 Eli Zaretskii <eliz@gnu.org>
1188
96512555
EZ
1189 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1190 last argument of make_unibyte_string.
1191
0bd8297f
EZ
1192 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1193 language ID in the event parameters.
1194
1195 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1196 event.code, not the obscure "character set ID".
1197
63def6b6
CY
11982012-06-23 Chong Yidong <cyd@gnu.org>
1199
1200 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1201
e8a02204
EZ
12022012-06-23 Eli Zaretskii <eliz@gnu.org>
1203
388cdec0
EZ
1204 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1205 * w32.c (fdutimens): New function.
1206
1207 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1208
1209 * s/ms-w32.h (pselect): Redirect to sys_select.
1210
1211 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1212
e8a02204
EZ
1213 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1214 in the logic of incrementing and decrementing the value of
1215 use_relocatable_buffers.
1216
d054f3fb
PE
12172012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1218
1219 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1220 Privately reported by Herbert J. Skuhra.
1221 [__FreeBSD__]: Remove "*/" typo after "#include".
1222 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1223 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1224 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1225 Don't assume EMACS_TIME and struct timeval are the same type.
1226
d35af63c
PE
12272012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1228
1229 Support higher-resolution time stamps (Bug#9000).
1230 The time stamps are only nanosecond-resolution at the C level,
1231 since that's the best that any real-world system supports now.
1232 But they are picosecond-resolution at the Lisp level, as that's
1233 easy, and leaves room for future OS improvements.
1234
1235 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1236 (LIBES): Use it.
1237
1238 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1239 Don't get current time unless it's needed.
1240
1241 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1242 now provides it if it's absent.
1243 (start_atimer): Port to higher-res time stamps.
1244 Check for time stamp overflow. Don't get current time more
1245 often than is needed.
1246
1247 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1248 Include systime.h, not time.h.
1249 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1250
1251 * dired.c: Include stat-time.h.
1252 (Ffile-attributes): File times now have higher resolution.
1253
1254 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1255 (struct image): Timestamp now has higher resolution.
1256
1257 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1258 has at least microseconds now. All uses removed.
1259 (update_frame, update_single_window, update_window, update_frame_1)
1260 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1261
1262 * editfns.c (time_overflow): Now extern.
1263 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1264 (float-time, Fformat_time_string, Fcurrent_time_string)
1265 (Fcurrent_time_zone): Accept and generate higher-resolution
1266 time stamps.
1267 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1268 (decode_time_components, lisp_seconds_argument): New functions.
1269 (make_time): Now static.
1270 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1271 Report an error if the time is invalid, rather than having the caller
1272 do that.
1273
1274 * fileio.c: Include <stat-time.h>
1275 (Fcopy_file): Copy higher-resolution time stamps.
1276 Prefer to set the time stamp via a file descriptor if that works.
1277 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1278 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1279 (Fvisited_file_modtime, Fset_visited_file_modtime):
1280 Support higher-resolution time stamps.
1281
1282 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1283
1284 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1285
1286 * image.c (prepare_image_for_display, clear_image_cache)
1287 (lookup_image): Port to higer-resolution time stamps.
1288
1289 * keyboard.c (start_polling, bind_polling_period):
1290 Check for time stamp overflow.
1291 (read_char, kbd_buffer_get_event, timer_start_idle)
1292 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1293 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1294 Port to higher-resolution time stamps. Do not assume time_t is signed.
1295 (decode_timer): New function. Timers are now vectors of length 9,
1296 not 8, to accommodate the picosecond component.
1297 (timer_check_2): Use it.
1298
1299 * nsterm.m (select_timeout, timeval_subtract): Remove.
1300 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1301 as they're a bit more accurate and handle overflow better.
1302 (ns_select): Change prototype to be compatible with pselect.
1303 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1304 * nsterm.h (ns_select): Adjust prototype.
1305
1306 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1307 us-resolution time stamps.
1308 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1309
1310 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1311
1312 * lisp.h (time_overflow): New decl.
1313 (wait_reading_process_output): First arg is now intmax_t, not int,
1314 to accommodate larger waits.
1315
1316 * process.h (struct Lisp_Process.read_output_delay):
1317 Now counts nanoseconds, not microseconds.
1318 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1319 EMACS_HAS_USECS.
1320 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1321 (wait_reading_process_output):
1322 Port to ns-resolution time stamps.
1323 (Faccept_process_output, wait_reading_process_output):
1324 Check for time stamp overflow. Do not assume time_t is signed.
1325 (select_wrapper): Remove; we now use pselect.
1326 (Fprocess_attributes): Now generates ns-resolution time stamps.
1327
1328 * sysdep.c: Include utimens.h. Don't include utime.h
1329 or worry about struct utimbuf; gnulib does that for us now.
1330 (gettimeofday): Remove; gnulib provides a substitute.
1331 (make_timeval): New function.
1332 (set_file_times): Now sets ns-resolution time stamps.
1333 New arg FD; all uses changed.
1334 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1335 (system_process_attributes):
1336 Now returns ns-resolution time stamp. All uses changed.
1337 Check for time stamp overflow.
1338
1339 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1340 provides a substitute now.
1341
1342 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1343 since it guarantees struct timespec.
1344 (EMACS_TIME): Now struct timespec, so that we can support
1345 ns-resolution time stamps.
1346 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1347 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1348 (EMACS_USECS): Remove.
1349 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1350 so multiply the arg by 1000 before storing it.
1351 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1352 New macros.
1353 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1354 Port to ns-resolution time stamps.
1355 (EMACS_TIME_NEG_P): Remove; replaced by....
1356 (EMACS_TIME_SIGN): New macro.
1357 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1358 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1359 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1360 (make_timeval, make_lisp_time, decode_time_components): New decls.
1361 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1362 that it mishandled time_t overflow. You can't compare by subtracting!
1363 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1364 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1365
1366 * term.c: Include <sys/time.h>.
1367 (timeval_to_Time): New function, for proper overflow wraparound.
1368 (term_mouse_position, term_mouse_click): Use it.
1369
1370 * undo.c (record_first_change): Support higher-resolution time stamps
1371 in the undo buffer.
1372 (Fprimitive_undo): Use them when restoring time stamps.
1373
1374 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1375 (w32_get_internal_run_time):
1376 Port to higher-resolution Emacs time stamps.
1377 (ltime): Now accepts single 64-bit integer, as that's more convenient
1378 for callers.
1379
1380 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1381
1382 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1383 for compatibility with pselect. Support ns-resolution time stamps.
1384
1385 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1386
1387 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1388 Check for time stamp overflow, and support ns-resolution time stamps.
1389
1390 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1391 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1392 (timeval_subtract): Remove; no longer needed.
1393 (XTflash, XTring_bell, x_wait_for_event):
1394 Port to ns-resolution time stamps. Don't assume time_t is signed.
1395
b6a92dfe
CY
13962012-06-22 Chong Yidong <cyd@gnu.org>
1397
1398 * xdisp.c (x_consider_frame_title): Revert last change.
1399
d251c37c
EZ
14002012-06-22 Eli Zaretskii <eliz@gnu.org>
1401
1402 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1403 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1404 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1405 staticidx goes up to 1597 out of 1600 = 0x640.)
1406
f10deafb
PE
14072012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1408
1409 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1410 Otherwise, the umask might be mistakenly 0 while handling input signals.
1411
ec6de1e2
SM
14122012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1413
1414 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1415
28be1ada
DA
14162012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1417
1418 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1419 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1420 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1421 access to `contents' member of Lisp_Vector objects with AREF and ASET
1422 where appropriate.
1423
c6bf3022
CY
14242012-06-19 Chong Yidong <cyd@gnu.org>
1425
1426 * frame.c (delete_frame): When selecting a frame on a different
1427 text terminal, do not alter the terminal's top-frame.
1428
1429 * xdisp.c (format_mode_line_unwind_data): Record the target
1430 frame's selected window and its terminal's top-frame.
1431 (unwind_format_mode_line): Restore them.
1432 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1433 Callers changed.
1434 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1435 since tty frames can be explicitly named.
1436 (prepare_menu_bars): Likewise.
1437
1438 * term.c (Ftty_top_frame): New function.
1439
defd4196
PE
14402012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1441
1442 Port byte-code-meter to modern targets.
1443 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1444 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1445 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1446 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1447 (METER_1, METER_2): Simplify.
1448
1053a871
SM
14492012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1450
1451 * data.c (Fdefalias): Return `symbol' (bug#11686).
1452
b7e8d081
MR
14532012-06-18 Martin Rudalics <rudalics@gmx.at>
1454
1455 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1456 gets killed during executing of this function (Bug#11665).
1457 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1458 (Vkill_buffer_query_functions): In doc-string say that functions
1459 run by this hook should not change the current buffer.
1460
7ea2b339
PE
14612012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1462
1463 Fix recently-introduced process.c problems found by static checking.
1464 * process.c (write_queue_push, write_queue_pop, send_process):
1465 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1466 (write_queue_pop): Fix pointer signedness problem.
1467 (send_process): Remove unused local.
1468
96a313a1
CY
14692012-06-17 Chong Yidong <cyd@gnu.org>
1470
1471 * xdisp.c (redisplay_internal): No need to redisplay terminal
1472 frames that are not on top.
1473
20ca2e94
TN
14742012-06-17 Troels Nielsen <bn.troels@gmail.com>
1475
1476 * process.c (make_process): Initialize write_queue.
1477 (write_queue_push, write_queue_pop): New functions.
1478 (send_process): Use them to maintain correct ordering of process
1479 writes (Bug#10815).
1480
9a900ca9
PE
14812012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1482
310fbfa8
PE
1483 * lisp.h (eassert): Assume C89 or later.
1484 This removes the need for CHECK.
1485 (CHECK): Remove. Its comments about always evaluating its
1486 argument were confusing, as 'eassert' typically does not evaluate
1487 its argument.
1488
27bb1ca4
PE
1489 * coding.c (produce_chars): Use ptrdiff_t, not int.
1490
9a900ca9
PE
1491 * xterm.c (x_draw_underwave): Check for integer overflow.
1492 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1493
41b7f8bc 14942012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1495
1496 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1497 referenced (Bug#11583).
1498
9b0e3eba
AA
14992012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1500
1501 Implement wave-style variant of underlining.
1502 * dispextern.h (face_underline_type): New enum.
1503 (face): Add field for underline type.
1504 * nsterm.m (ns_draw_underwave): New function.
1505 (ns_draw_text_decoration): Use it.
1506 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1507 New functions.
1508 (x_draw_glyph_string): Use them.
1509 * xfaces.c (Qline, Qwave): New Lisp objects.
1510 (check_lface_attrs, merge_face_ref)
1053a871
SM
1511 (Finternal_set_lisp_face_attribute, realize_x_face):
1512 Handle wave-style underline face attributes.
9b0e3eba
AA
1513 * xterm.c (x_draw_underwave): New function.
1514 (x_draw_glyph_string): Use it.
1515
0fb52f11
JB
15162012-06-16 Juanma Barranquero <lekktu@gmail.com>
1517
1518 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1519 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1520 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1521 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1522 ($(BLD)/w32select.$(O)): Update dependencies.
1523
e5560ff7
AS
15242012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1525
1526 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1527 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1528 * character.c (_fetch_multibyte_char_p): Remove.
1529 * alloc.c: Include "character.h" before "buffer.h".
1530 * bidi.c: Likewise.
1531 * buffer.c: Likewise.
1532 * bytecode.c: Likewise.
1533 * callint.c: Likewise.
1534 * callproc.c: Likewise.
1535 * casefiddle.c: Likewise.
1536 * casetab.c: Likewise.
1537 * category.c: Likewise.
1538 * cmds.c: Likewise.
1539 * coding.c: Likewise.
1540 * composite.c: Likewise.
1541 * dired.c: Likewise.
1542 * dispnew.c: Likewise.
1543 * doc.c: Likewise.
1544 * dosfns.c: Likewise.
1545 * editfns.c: Likewise.
1546 * emacs.c: Likewise.
1547 * fileio.c: Likewise.
1548 * filelock.c: Likewise.
1549 * font.c: Likewise.
1550 * fontset.c: Likewise.
1551 * fringe.c: Likewise.
1552 * indent.c: Likewise.
1553 * insdel.c: Likewise.
1554 * intervals.c: Likewise.
1555 * keyboard.c: Likewise.
1556 * keymap.c: Likewise.
1557 * lread.c: Likewise.
1558 * macros.c: Likewise.
1559 * marker.c: Likewise.
1560 * minibuf.c: Likewise.
1561 * nsfns.m: Likewise.
1562 * nsmenu.m: Likewise.
1563 * print.c: Likewise.
1564 * process.c: Likewise.
1565 * regex.c: Likewise.
1566 * region-cache.c: Likewise.
1567 * search.c: Likewise.
1568 * syntax.c: Likewise.
1569 * term.c: Likewise.
1570 * textprop.c: Likewise.
1571 * undo.c: Likewise.
1572 * unexsol.c: Likewise.
1573 * w16select.c: Likewise.
1574 * w32fns.c: Likewise.
1575 * w32menu.c: Likewise.
1576 * window.c: Likewise.
1577 * xdisp.c: Likewise.
1578 * xfns.c: Likewise.
1579 * xmenu.c: Likewise.
1580 * xml.c: Likewise.
1581 * xselect.c: Likewise.
1582
2f07e6af
EZ
15832012-06-16 Eli Zaretskii <eliz@gnu.org>
1584
1053a871
SM
1585 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1586 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1587 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1588 row.
1589 (handle_face_prop): Use chunk-relative overlay string index when
1590 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1591 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1592 the rightmost. (Bug#11720)
2f07e6af 1593
29b83cec
AS
15942012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1595
1596 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1597 (CATEGORY_MEMBER): Enforce 1/0 value.
1598 * category.c (_temp_category_set): Remove.
1599
4c5501e9
EZ
16002012-06-16 Eli Zaretskii <eliz@gnu.org>
1601
1602 * window.c (Fdelete_other_windows_internal)
1603 (Fdelete_window_internal): Don't access frame's mouse highlight
1604 info of the initial frame. (Bug#11677)
1605
2b570124
PE
16062012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1607
e93864f9
PE
1608 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1609 Assume USE_2_TAGS_FOR_INTS.
1610 (xreload): Adjust $tagmask width to match recent lisp.h change.
1611
2b570124
PE
1612 Simplify lisp.h in minor ways that should not affect code.
1613 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1614 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1615 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1616 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1617 (INTTYPEBITS): New macro, for clarity.
1618 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1619 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1620 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1621 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1622 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1623
81755f69
JB
16242012-06-13 Juanma Barranquero <lekktu@gmail.com>
1625
1626 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1627
16192a57
GM
16282012-06-13 Glenn Morris <rgm@gnu.org>
1629
1630 * s/bsd-common.h (BSD4_3):
1631 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1632
646b5f55
AS
16332012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1634
1635 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1636 instead of union.
1637 (XLI, XIL): Define.
1053a871
SM
1638 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1639 Use them.
1640 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1641 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1642 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1643 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1644 * frame.c (delete_frame): Remove outdated comment.
1645 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1646 USE_LISP_UNION_TYPE.
1647 (Fw32_unregister_hot_key): Likewise.
1648 (Fw32_toggle_lock_key): Likewise.
1649 * w32menu.c (add_menu_item): Likewise.
1650 (w32_menu_display_help): Use XIL instead of checking
1651 USE_LISP_UNION_TYPE.
1652 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1653 (init_heap): Likewise.
1654 * w32term.c (w32_read_socket): Update comment.
1655
1d3823c9
GM
16562012-06-13 Glenn Morris <rgm@gnu.org>
1657
c62ff706
GM
1658 * s/usg5-4-common.h, src/s/unixware.h:
1659 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1660
1d3823c9
GM
1661 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1662
bfe3e0a2
PE
16632012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1664
1665 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1666 * alloc.c (make_number) [!defined make_number]:
1667 Remove, as lisp.h always defines this now.
1668 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1669 (roundup_size): Verify that it is a power of 2.
1670 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1671 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1672 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1673 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1674 USE_LSB_TAG now is always defined to be either 0 or 1.
1675 All uses changed.
1676 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1677 code works fine either way, and efficiency is not a concern here,
1678 as the union type is for debugging, not for production.
1679 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1680 Use an inline function on all platforms when using the union type,
1681 since this is simpler and 'static inline' can be used portably
1682 within Emacs now.
1683 (LISP_INITIALLY_ZERO): New macro.
1684 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1685 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1686
45fa9c0f
GM
16872012-06-12 Glenn Morris <rgm@gnu.org>
1688
b4492cba
GM
1689 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1690
1691 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1692
45fa9c0f
GM
1693 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1694 Move BROKEN_SIGIO to configure.
1695
1696 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1697 Move NO_TERMIO to configure.
1698
0e25d334
CY
16992012-06-12 Chong Yidong <cyd@gnu.org>
1700
1701 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1702 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1703 MagickExportImagePixels is undefined.
1704
43682bb6
PE
17052012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1706
1707 * image.c (imagemagick_load_image): Remove unused label.
1708
a9be7d2b
GM
17092012-06-11 Glenn Morris <rgm@gnu.org>
1710
1711 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1712 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1713 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1714 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1715
3017f87f
SM
17162012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1717
1718 * alloc.c (make_byte_code): New function.
1719 (Fmake_byte_code): Use it. Don't purify here.
1720 * lread.c (read1): Use it as well to avoid extra allocation.
1721
1b9b4cf4
CY
17222012-06-11 Chong Yidong <cyd@gnu.org>
1723
1724 * image.c (imagemagick_load_image): Implement transparency.
1725
95988fcf
AS
17262012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1727
1728 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1729 account for preceding backslashes. (Bug#11663)
1730
cd4eb164
CY
17312012-06-09 Chong Yidong <cyd@gnu.org>
1732
1733 * term.c: Support italics in capable terminals (Bug#9652).
1734 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1735 (turn_on_face): Output using TS_enter_italic_mode if available.
1736 Don't handle unused blinking and alt-charset cases.
1737 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1738 and tty_alt_charset_p cases.
1739 (tty_capable_p, init_tty): Support italics.
1740
1741 * termchar.h (struct tty_display_info): Add field for italics.
1742 Remove unused blink field.
1743
1744 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1745 Handle slant.
1746
1747 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1748 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1749 tty_alt_charset_p. Add tty_italic_p.
1750
ff88beb8
MA
17512012-06-09 Michael Albinus <michael.albinus@gmx.de>
1752
1753 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1754 dbus_type_is_basic if available.
1755 (xd_extract_signed, xd_extract_unsigned): Rename from
1756 extract_signed and extract_unsigned, respectively. Adapt callers.
1757
44286096
CY
17582012-06-09 Chong Yidong <cyd@gnu.org>
1759
1682701f
CY
1760 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1761
44286096
CY
1762 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1763 case (Bug#9752).
1764
d86feb17
PE
17652012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1766
1767 * xdisp.c (vmessage): Treat frame message as multibyte.
1768 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1769 would generate the diagnostic "Making \302\247 buffer-local while
1770 let-bound!".
1771
d5c20fe8
EZ
17722012-06-08 Eli Zaretskii <eliz@gnu.org>
1773
1774 * dispnew.c (showing_window_margins_p): Undo last change, which
1775 was done due to an inadvertent commit.
1776 (adjust_frame_glyphs_for_frame_redisplay): Do call
1777 showing_window_margins_p.
1778
513749ee
SM
17792012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1780
1781 * eval.c (Fmake_var_non_special): New primitive.
1782 (syms_of_eval): Defsubr it.
1783 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1784
d4a8f5c1
JB
17852012-06-08 Juanma Barranquero <lekktu@gmail.com>
1786
1787 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1788 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1789
8bbbc977
EZ
17902012-06-08 Eli Zaretskii <eliz@gnu.org>
1791
1792 * alloc.c (allocate_vectorlike): Fix last change.
1793
f3372c87
DA
17942012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1795
1796 Block-based vector allocation of small vectors.
1797 * lisp.h (struct vectorlike_header): New field `nbytes',
1798 adjust comment accordingly.
1799 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1800 to denote vector blocks. Adjust users (live_vector_p,
1801 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1802 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1803 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1804 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1805 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1806 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1807 (roundup_size): New constant.
1808 (struct vector_block): New data type.
1809 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1810 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1811 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1812 (sweep_vectors): New functions.
1813 (allocate_vectorlike): Return `zero_vector' as the only vector of
1814 0 items. Allocate new vector from block if vector size is less than
1815 or equal to VBLOCK_BYTES_MAX.
1816 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1817 (init_alloc_once): Add call to init_vectors.
1818
4f18a4ed
SM
18192012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1820
1821 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1822
86f158bc
PE
18232012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1824
1825 * doprnt.c (doprnt): Truncate multibyte char correctly.
1826 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1827 would mishandle a string argument "Xc" if X was a multibyte
1828 character of length 2: it would truncate after X's first byte
1829 rather than including all of X.
1830
c5cfcbe0
CY
18312012-06-06 Chong Yidong <cyd@gnu.org>
1832
1833 * buffer.c (word_wrap): Doc fix.
1834
c05cf390
PE
18352012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1836
1837 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1838
0c3461de
GM
18392012-06-03 Glenn Morris <rgm@gnu.org>
1840
1841 * xdisp.c (tool-bar-style): Doc fix.
1842
c71232db
UM
18432012-06-03 Ulrich Müller <ulm@gentoo.org>
1844
1845 * Makefile.in (PAXCTL): Define.
1846 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1847 binary via PaX flags if the paxctl utility is available.
1848 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1849 Restore PaX flags to their default. (Bug#11398)
1850
383f7350
CY
18512012-06-03 Chong Yidong <cyd@gnu.org>
1852
1853 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1854 buffer (Bug#11226).
1855
5f2c76c6
CY
18562012-06-03 Chong Yidong <cyd@gnu.org>
1857
1858 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1859 (note_mode_line_or_margin_highlight): If there is no help echo,
1860 use mode-line-default-help-echo. Handle the case where the mouse
1861 position is past the end of the mode line string.
1862
1863 * buffer.c (buffer_local_value_1): New function, split from
1864 Fbuffer_local_value; can return Qunbound.
1865 (Fbuffer_local_value): Use it.
1866 (Vmode_line_format): Docstring tweaks.
1867
773d47f6
PE
18682012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1869
1870 * sysdep.c (system_process_attributes): Improve comment.
1871
f2d6a3df
SM
18722012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1873
1874 * keyboard.c: Export real-this-command to Elisp.
1875 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1876 and DEFVAR it. Update all users.
1877
63810350
PE
18782012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1879
7bd5c1f4
PE
1880 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1881
63810350
PE
1882 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1883 Convert pctcpu and pctmem to Lisp float properly.
1884 Let the compiler fold better, as 100.0/0x8000 is exact.
1885
a2821611
AS
18862012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1887
1888 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1889 cons_block.
1890
5fceba1d
PE
18912012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1892
1893 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1894
c98ff5dd
DA
18952012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1896
1897 For a 'struct window', replace some Lisp_Object fields to
1898 bitfields where appropriate, remove unused fields.
1899 * window.h (struct window): Remove unused 'last_mark_x' and
1900 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1901 change it's type from Lisp_Object to bitfield.
1902 Change type of 'force_start', 'optional_new_start',
1903 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1904 fields from Lisp_Object to bitfield. Adjust users accordingly.
1905
ca34e0be
PE
19062012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1907
1908 Pacify gcc -Wdouble-precision when using Xaw.
1909 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1910 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1911 Use 'float' consistently, rather than 'float' in most places
1912 and 'double' in a couple of places.
1913
efc00ab1 19142012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1915
1916 * xdisp.c (handle_stop): Detect whether we have overlay strings
1917 loaded by testing it->current.overlay_string_index to be
1918 non-negative, instead of checking whether n_overlay_strings is
1919 positive. (Bug#11587)
1920
efc00ab1 19212012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1922
1923 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1924
1925 * doc.c (Fsubstitute_command_keys): Doc fix.
1926
efc00ab1 19272012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1928
1929 * search.c (search_buffer): Remove calls to
1930 r_alloc_inhibit_buffer_relocation, as it is now called by
1931 maybe_unify_char, which was the cause of relocation of buffer text
1932 in bug#11519.
1933
efc00ab1 19342012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1935
1936 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1937 for the duration of call to load_charset, to avoid problems with
1938 callers of maybe_unify_char that access buffer text through C
1939 pointers.
1940
1941 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1942 decrement the inhibition flag, instead of just setting or
1943 resetting it.
1944
ba93a187
PE
19452012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1946
1947 Remove obsolete '#define static' cruft.
1948 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1949 This #undef was "temporary" in 2000; it is no longer needed
1950 now that '#define static' has gone away.
1951 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1952 (gray_bitmap_bits): Remove; no longer needed.
1953 All uses replaced with definiens.
1954 * xterm.c: Include "bitmaps/gray.xbm".
1955
9e4bf381
PE
19562012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1957
1958 Clean up __executable_start, monstartup when --enable-profiling.
1959 The following changes affect the code only when profiling.
1960 * dispnew.c (__executable_start): Rename from safe_bcopy.
1961 Define only on platforms that need it.
1962 * emacs.c: Include <sys/gmon.h> when profiling.
1963 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1964 (__executable_start): Remove decl, since lisp.h does it now.
1965 (safe_bcopy): Remove decl; no longer has that name.
1966 (main): Coalesce #if into single bit of code, for simplicity.
1967 Cast pointers to uintptr_t, since standard libraries want integers
1968 and not pointers.
1969 * lisp.h (__executable_start): New decl.
1970
32d72c2f
GM
19712012-05-31 Glenn Morris <rgm@gnu.org>
1972
1973 * image.c (Fimagemagick_types): Doc fix.
1974
baac5bc7
JM
19752012-05-30 Jim Meyering <meyering@redhat.com>
1976
1977 * callproc.c (Fcall_process_region): Include directory component
1978 in mkstemp error message (Bug#11586).
1979
72cb32cf
PE
19802012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1981
1982 * alloc.c, lisp.h (make_pure_vector): Now static.
1983
61b108cc
SM
19842012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1985
1986 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1987 Move to byte-run.el.
1988 (Fautoload): Do the hash-doc more carefully.
1989 * data.c (Fdefalias): Purify definition, except for keymaps.
1990 (Qdefun): Move from eval.c.
1991 * lisp.h (Qdefun): Remove.
1992 * lread.c (read1): Tiny simplification.
1993
471fe23d
TN
19942012-05-29 Troels Nielsen <bn.troels@gmail.com>
1995
934f3f58 1996 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1997 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1998 Bug#9642, but explicitly check that the buffer the overlay would
1999 be moved to is live and rearrange lines to make sure that errors
2000 will not put the overlay in an inconsistent state.
2001 (Fdelete_overlay): Cosmetics.
2002
85d0efd1
EZ
20032012-05-28 Eli Zaretskii <eliz@gnu.org>
2004
2005 * w32term.c (my_bring_window_to_top): New function.
2006 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2007 could be different from the original one.
2008 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2009 (Bug#11513)
2010
2011 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2012 by calling BringWindowToTop.
2013
2014 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2015 (WM_EMACS_END): Increase by one.
2016
da92a98c
PE
20172012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2018
2019 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2020 This avoids undefined behavior that might cause the eassert
2021 to not catch an out-of-range value.
2022
74d1f848
JB
20232012-05-28 Juanma Barranquero <lekktu@gmail.com>
2024
2025 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2026 Update dependencies.
2027
9e1a06fc
EZ
20282012-05-27 Eli Zaretskii <eliz@gnu.org>
2029
2030 * bidi.c (bidi_mirror_char): Fix last change.
2031
f3dd7312
AS
20322012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2033
2034 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2035 when referring to sectname field in printf format.
2036
81899c91
PE
20372012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2038
57b81a9f
PE
2039 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2040 Only r_alloc_inhibit_buffer_relocation needed to be added;
2041 the others were already declared.
2042
81899c91
PE
2043 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2044 before checking whether it's out of range. Put the check inside
2045 eassert. See
2046 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2047
33017faf 20482012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2049
2050 * callproc.c (Fcall_process): Restore a line that was accidentally
2051 commented out in the 2011-02-13 change (bug#11547).
2052
33017faf 20532012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2054
2055 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2056 defined on ralloc.c.
2057
2058 * buffer.c [REL_ALLOC]: Remove prototypes of
2059 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2060 they are now on lisp.h.
2061
2062 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2063
2064 * search.c (search_buffer): Use it to inhibit relocation of buffer
2065 text while re_search_2 is doing its job, because re_search_2 is
2066 passed C pointers to buffer text. (Bug#11519)
2067
23415acf
EZ
2068 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2069 Update value to 24.
2070
44e27368
EZ
2071 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2072 state after an additional call to move_it_in_display_line_to, keep
2073 the values of it->max_ascent and it->max_descent found for the
2074 entire line.
2075 (pos_visible_p): Revert the comparison against bottom_y to what it
2076 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2077 (Bug#11464)
2078
c1892f11
PE
20792012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2080
2081 Fix coding-related core dumps with gcc -ftrapv.
2082 The code was computing A - B, where A and B are pointers, and B is
2083 random garbage. This can lead to core dumps on platforms that
2084 have special pointer registers, and it also leads to core dumps on
2085 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2086 A - B only when B is initialized properly.
2087 * coding.c (coding_set_source, coding_set_destination): Return void.
2088 (coding_change_source, coding_change_destinations): New functions,
2089 with the old behaviors of coding_set_source and coding_set_destination.
2090 All callers that need an offset changed to use these new functions.
2091
eb7afdad
GM
20922012-05-26 Glenn Morris <rgm@gnu.org>
2093
2094 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2095
f12fdf02
EZ
20962012-05-26 Eli Zaretskii <eliz@gnu.org>
2097
53a63be6 2098 Extend mouse support on W32 text-mode console.
61b108cc
SM
2099 * xdisp.c (draw_row_with_mouse_face):
2100 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2101
eb3f6f01 2102 * w32console.c: Include window.h.
61b108cc
SM
2103 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2104 New functions.
eb3f6f01
EZ
2105 (initialize_w32_display): Initialize mouse-highlight data.
2106
53a63be6
EZ
2107 * w32inevt.c: Include termchar.h and window.h.
2108 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2109 moves, call note_mouse_highlight. If help_echo changed, call
2110 gen_help_event to produce help-echo message in the echo area.
2111 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2112 highlight info.
2113
4cfd81f6
PE
21142012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2115
2116 * lread.c (read1): Simplify slightly to avoid an overflow warning
2117 with GCC 4.7.0 on x86-64.
2118
4446092a
EZ
21192012-05-26 Eli Zaretskii <eliz@gnu.org>
2120
2121 * bidi.c (bidi_mirror_char): Revert last change: an int is
2122 definitely wide enough here.
2123
42b2a986 21242012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2125
42b2a986 2126 Fix integer width and related bugs (Bug#9874).
eb106a49 2127 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2128 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2129 (string_bytes, check_sblock, allocate_string_data):
2130 (compact_small_strings, Fmake_bool_vector, make_string)
2131 (make_unibyte_string, make_multibyte_string)
2132 (make_string_from_bytes, make_specified_string)
2133 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2134 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2135 (mark_vectorlike):
2136 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2137 (allocate_pseudovector):
2138 Use int, not EMACS_INT, where int is wide enough.
2139 (inhibit_garbage_collection, Fgarbage_collect):
2140 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2141 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2142 int might not be wide enough.
2143 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2144 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2145 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2146 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2147 (bidi_level_of_next_char, bidi_move_to_visually_next):
2148 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2149 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2150 (Fkill_buffer, Fset_buffer_major_mode)
2151 (advance_to_char_boundary, Fbuffer_swap_text)
2152 (Fset_buffer_multibyte, overlays_at, overlays_in)
2153 (overlay_touches_p, struct sortvec, record_overlay_string)
2154 (overlay_strings, recenter_overlay_lists)
2155 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2156 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2157 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2158 (Foverlay_recenter, last_overlay_modification_hooks_used)
2159 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2160 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2161 (validate_region): Omit unnecessary test for b <= e,
2162 since that's guaranteed by the previous test.
d311d28c
PE
2163 (adjust_overlays_for_delete): Avoid pos + length overflow.
2164 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2165 (report_overlay_modification):
2166 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2167 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2168 Omit pointer cast, which isn't needed anyway, and doesn't work
2169 after the EMACS_INT -> ptrdiff_t change.
02481186 2170 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2171 * buffer.h: Adjust decls to match defn changes elsewhere.
2172 (struct buffer_text, struct buffer):
2173 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2174 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2175 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2176 not int, to avoid needless 32-bit limit on 64-bit hosts.
2177 (exec_byte_code): Use tighter memory-full test, one that checks
2178 for alloca overflow. Don't compute the address of the object just
2179 before an array, as that's not portable. Use EMACS_INT, not
2180 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2181 * callint.c (Fcall_interactively):
2182 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2183 * callproc.c (call_process_kill, Fcall_process):
2184 Don't assume pid_t fits into an Emacs fixnum.
2185 (call_process_cleanup, Fcall_process, child_setup):
2186 Don't assume pid_t fits into int.
2187 (call_process_cleanup, Fcall_process, delete_temp_file)
2188 (Fcall_process_region):
2189 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2190 (Fcall_process): Simplify handling of volatile integers.
2191 Use int, not EMACS_INT, where int will do.
2192 * casefiddle.c (casify_object, casify_region, operate_on_word)
2193 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2194 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2195 (casify_object): Avoid integer overflow when overallocating buffer.
2196 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2197 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2198 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2199 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2200 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2201 integers are now checked earlier. All uses replaced with XINT.
2202 (ccl_driver):
2203 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2204 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2205 (ccl_driver, Fregister_code_conversion_map):
2206 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2207 (resolve_symbol_ccl_program): Check that vector header is in range.
2208 Always copy the vector, so that we can check its contents reliably
2209 now rather than having to recheck each instruction as it's being
2210 executed. Check that vector words fit in 'int'.
2211 (ccl_get_compiled_code, Fregister_ccl_program)
2212 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2213 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2214 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2215 contents are in range.
2216 (Fccl_execute_on_string): Check that status is in range.
2217 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2218 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2219 Accept and return EMACS_INT, not int, because callers can pass values
2220 out of 'int' range.
2221 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2222 (multibyte_chars_in_text, parse_str_as_multibyte)
2223 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2224 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2225 (string_escape_byte8, Fget_byte):
2226 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2227 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2228 avoid mishandling large integers.
2229 * character.h: Adjust decls to match defn changes elsewhere.
2230 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2231 (Ffind_charset_region):
2232 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2233 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2234 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2235 Don't assume fixnum fits in int.
d311d28c
PE
2236 (load_charset_map_from_vector, Fmap_charset_chars):
2237 Remove now-unnecessary CHECK_NATNUMs.
2238 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2239 Don't rely on undefined behavior with signed left shift overflow.
2240 Don't assume unsigned int fits into fixnum, or that fixnum fits
2241 into unsigned int. Don't require max_code to be a valid fixnum;
2242 that's not true for gb10830 4-byte on a 32-bit host. Allow
2243 invalid_code to be a cons, for the same reason. Require code_offset
2244 to be a character. Avoid int overflow if max_char is close
2245 to INT_MAX.
2246 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2247 this is intended anyway and avoids some undefined behavior.
2248 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2249 INDEX_TO_CODE_POINT, as that's what it expects.
2250 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2251 * charset.h (DECODE_CHAR): Return int, not unsigned;
2252 this is what was intended anyway, and it avoids undefined behavior.
2253 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2254 integer-overflow issues.
2255 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2256 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2257 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2258 * chartab.c (Fmake_char_table, Fset_char_table_range)
2259 (uniprop_get_decoder, uniprop_get_encoder):
2260 Don't assume fixnum fits in int.
2261 * cmds.c (move_point): New function, that does the gist of
2262 Fforward_char and Fbackward_char, but does so while checking
2263 for integer overflow more accurately.
c96e5d6a 2264 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2265 (Fforward_line, Fend_of_line, internal_self_insert)
2266 (internal_self_insert):
2267 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2268 Fix a FIXME, by checking for integer overflow when calculating
2269 target_clm and actual_clm.
2270 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2271 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2272 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2273 (coding_alloc_by_making_gap, alloc_destination)
2274 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2275 (encode_coding_utf_16, detect_coding_emacs_mule)
2276 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2277 (detect_coding_iso_2022, decode_coding_iso_2022)
2278 (encode_invocation_designation, encode_designation_at_bol)
2279 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2280 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2281 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2282 (encode_coding_ccl, encode_coding_raw_text)
2283 (detect_coding_charset, decode_coding_charset)
2284 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2285 (produce_composition, produce_charset, produce_annotation)
2286 (decode_coding, handle_composition_annotation)
2287 (handle_charset_annotation, consume_chars, decode_coding_gap)
2288 (decode_coding_object, encode_coding_object, detect_coding_system)
2289 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2290 (code_convert_region, code_convert_string)
8f50130c
PE
2291 (Fdefine_coding_system_internal)
2292 (coding_set_source, coding_set_destination):
d311d28c
PE
2293 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2294 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2295 (Fdefine_coding_system_internal):
2296 Don't assume fixnums fit in int.
2297 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2298 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2299 (Funencodable_char_position, Fcheck_coding_systems_region)
2300 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2301 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2302 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2303 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2304 Don't access memory outside of the args array.
d311d28c 2305 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2306 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2307 result of ENCODE_CHAR.
d311d28c
PE
2308 * coding.h: Adjust decls to match defn changes elsewhere.
2309 (struct coding_system):
2310 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2311 * composite.c (get_composition_id, find_composition)
2312 (run_composition_function, update_compositions)
2313 (compose_text, composition_gstring_put_cache)
2314 (composition_gstring_p, composition_gstring_width)
2315 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2316 (composition_compute_stop_pos, composition_reseat_it)
2317 (composition_update_it, struct position_record)
2318 (find_automatic_composition, composition_adjust_point)
2319 (Fcomposition_get_gstring, Ffind_composition_internal):
2320 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2321 (update_compositions):
2322 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2323 * composite.h: Adjust decls to match defn changes elsewhere.
2324 (struct composition):
2325 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2326 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2327 Do not attempt to compute the address of the object just before a
2328 buffer; this is not portable.
2329 (Faref, Faset):
2330 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2331 (Faset): Use int, not EMACS_INT, where int is wide enough.
2332 (Fstring_to_number): Don't assume fixnums fit in int.
2333 (Frem): Don't assume arg is nonnegative.
2334 * dbusbind.c (xd_append_arg): Check for integers out of range.
2335 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2336 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2337 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2338 (xd_get_connection_references): Return ptrdiff_t, not int.
2339 All uses changed.
2340 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2341 (xd_read_message_1):
2342 Use int, not unsigned, where the dbus API uses int.
2343 (Fdbus_message_internal): Don't overflow mtype.
2344 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2345 * dired.c (directory_files_internal, file_name_completion, scmp)
2346 (file_name_completion_stat):
2347 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2348 (file_name_completion): Don't overflow matchcount.
2349 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2350 * dispextern.h: Adjust decls to match defn changes elsewhere.
2351 (struct text_pos, struct glyph, struct bidi_saved_info)
2352 (struct bidi_string_data, struct bidi_it, struct composition_it)
2353 (struct it):
2354 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2355 (struct display_pos, struct composition_it, struct it):
2356 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2357 * dispnew.c (increment_matrix_positions)
2358 (increment_row_positions, mode_line_string)
2359 (marginal_area_string):
2360 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2361 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2362 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2363 (duration_to_sec_usec): New function, to check for overflow better.
2364 (Fsleep_for, sit_for): Use it.
2365 * doc.c (get_doc_string, store_function_docstring):
2366 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2367 (get_doc_string, Fsnarf_documentation):
2368 Use int, not EMACS_INT, where int is wide enough.
2369 (get_doc_string):
2370 Use SAFE_ALLOCA, not alloca.
2371 Check for overflow when converting EMACS_INT to off_t.
2372 * doprnt.c (doprnt):
2373 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2374 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2375 Don't assume uid_t fits into fixnum.
2376 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2377 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2378 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2379 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2380 (general_insert_function)
2381 (Finsert_char, make_buffer_string, make_buffer_string_both)
2382 (update_buffer_properties, Fbuffer_substring)
2383 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2384 (Fsubst_char_in_region, check_translation)
2385 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2386 (transpose_markers, Ftranspose_regions):
2387 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2388 (clip_to_bounds): Move to lisp.h as an inline function).
2389 (Fconstrain_to_field): Don't assume integers are nonnegative.
2390 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2391 (Fsubst_char_in_region, Fsave_restriction):
2392 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2393 (Femacs_pid): Don't assume pid_t fits into fixnum.
2394 (lo_time): Use int, not EMACS_INT, when int suffices.
2395 (lisp_time_argument): Check for usec out of range.
2396 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2397 (Fuser_login_name, Fuser_full_name): Signal an error
2398 if a uid argument is out of range, rather than relying on
2399 undefined behavior.
c8d5c857
PE
2400 (Fformat_time_string): Remove now-unnecessary check.
2401 lisp_time_argument checks for out-of-range usec now.
243e0530 2402 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2403 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2404 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2405 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2406 (init_cmdargs, Fdump_emacs):
2407 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2408 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2409 the bottom (typically) 32 bits of the fixnum.
2410 * eval.c (specpdl_size, call_debugger):
2411 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2412 (when_entered_debugger, Fbacktrace_debug):
2413 Don't assume fixnum can fit in int.
2414 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2415 the object just before a buffer; this is not portable.
2416 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2417 (grow_specpdl, unbind_to):
2418 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2419 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2420 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2421 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2422 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2423 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2424 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2425 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2426 (a_write, e_write):
2427 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2428 (Fcopy_file, non_regular_nbytes, read_non_regular)
2429 (Finsert_file_contents):
2430 Use int, not EMACS_INT, where int is wide enough.
2431 (READ_BUF_SIZE): Verify that it fits in int.
2432 (Finsert_file_contents): Check that counts are in proper range,
2433 rather than assuming fixnums fit into ptrdiff_t etc.
2434 Don't assume fixnums fit into int.
125b3835 2435 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2436 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2437 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2438 (string_char_to_byte, string_byte_to_char)
2439 (string_make_multibyte, string_to_multibyte)
2440 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2441 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2442 (substring_both, Fdelete, internal_equal, Ffillarray)
2443 (Fclear_string, mapcar1)
2444 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2445 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2446 (larger_vector, make_hash_table, maybe_resize_hash_table)
2447 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2448 (Fmaphash, secure_hash):
2449 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2450 (concat): Check for string index and length overflow.
2451 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2452 (Frequire):
2453 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2454 (larger_vector): New API (vec, incr_min, size_max) replaces old
2455 one (vec, new_size, init). This catches size overflow.
2456 INIT was removed because it was always Qnil.
2457 All callers changed.
2458 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2459 the upper bound on a hash table index size.
2460 (make_hash_table, maybe_resize_hash_table): Use it.
2461 (secure_hash): Computer start_byte and end_byte only after
2462 they're known to be in ptrdiff_t range.
2463 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2464 (Ffont_get_glyphs, Ffont_at):
2465 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2466 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2467 (Flist_fonts, Fopen_font):
2468 Don't assume fixnum can fit in int.
2469 (check_gstring): Don't assume index can fit in int.
2470 (font_match_p): Check that fixnum is a character, not a nonnegative
2471 fixnum, since the later code needs to stuff it into an int.
2472 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2473 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2474 conversion overflow issues.
2475 (Fopen_font): Check for integer out of range.
2476 (Ffont_get_glyphs): Don't assume index can fit in int.
2477 * font.h: Adjust decls to match defn changes elsewhere.
2478 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2479 integer overflow.
2480 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2481 printmax_t, where ptrdiff_t is wide enough.
2482 (Finternal_char_font):
2483 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2484 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2485 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2486 (Fset_frame_position, x_set_frame_parameters)
2487 (x_set_line_spacing, x_set_border_width)
2488 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2489 Check that fixnums are in proper range for system types.
2490 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2491 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2492 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2493 Use SAFE_ALLOCA_LISP, not alloca.
2494 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2495 intptr_t is wide enough.
2496 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2497 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2498 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2499 Check for fixnum out of range.
2500 * ftfont.c (ftfont_list): Don't assume index fits in int.
2501 Check that fixnums are in proper range for system types.
2502 (ftfont_shape_by_flt):
2503 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2504 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2505 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2506 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2507 Check that fixnums are in proper range for system types.
2508 * gnutls.h: Adjust decls to match defn changes elsewhere.
2509 * gtkutil.c (xg_dialog_run):
2510 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2511 (update_frame_tool_bar):
2512 Check that fixnums are in proper range for system types.
2513 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2514 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2515 * indent.c (last_known_column, last_known_column_point):
2516 (current_column_bol_cache):
2517 (skip_invisible, current_column, check_display_width):
2518 (check_display_width, scan_for_column, current_column_1)
2519 (Findent_to, Fcurrent_indentation, position_indentation)
2520 (indented_beyond_p, Fmove_to_column, compute_motion):
2521 (Fcompute_motion, Fvertical_motion):
2522 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2523 (last_known_column_modified): Use EMACS_INT, not int.
2524 (check_display_width):
2525 (Fcompute_motion):
2526 Check that fixnums and floats are in proper range for system types.
2527 (compute_motion): Don't assume index or fixnum fits in int.
2528 (compute_motion, Fcompute_motion):
2529 Use int, not EMACS_INT, when it is wide enough.
2530 (vmotion): Omit local var start_hpos that is always 0; that way
2531 we don't need to worry about overflow in expressions involving it.
2532 * indent.h: Adjust decls to match defn changes elsewhere.
2533 (struct position):
2534 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2535 Use int, not EMACS_INT, where int is wide enough.
2536 Remove unused members ovstring_chars_done and tab_offset;
2537 all uses removed.
2538 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2539 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2540 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2541 (make_gap, copy_text, insert, insert_and_inherit)
2542 (insert_before_markers, insert_before_markers_and_inherit)
2543 (insert_1, count_combining_before, count_combining_after)
2544 (insert_1_both, insert_from_string)
2545 (insert_from_string_before_markers, insert_from_string_1)
2546 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2547 (adjust_after_replace, adjust_after_insert, replace_range)
2548 (replace_range_2, del_range, del_range_1, del_range_byte)
2549 (del_range_both, del_range_2, modify_region)
2550 (prepare_to_modify_buffer, signal_before_change)
2551 (signal_after_change, Fcombine_after_change_execute):
2552 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2553 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2554 (balance_an_interval, split_interval_right, split_interval_left)
2555 (find_interval, next_interval, update_interval)
2556 (adjust_intervals_for_insertion, delete_node, delete_interval)
2557 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2558 (static_offset_intervals, offset_intervals)
2559 (merge_interval_right, merge_interval_left, make_new_interval)
2560 (graft_intervals_into_buffer, temp_set_point_both)
2561 (temp_set_point, set_point, adjust_for_invis_intang)
2562 (set_point_both, move_if_not_intangible, get_property_and_range)
2563 (get_local_map, copy_intervals, copy_intervals_to_string)
2564 (compare_string_intervals, set_intervals_multibyte_1):
2565 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2566 * intervals.h: Adjust decls to match defn changes elsewhere.
2567 (struct interval):
2568 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2569 * keyboard.c (this_command_key_count, this_single_command_key_start)
2570 (before_command_key_count, before_command_echo_length, echo_now)
2571 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2572 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2573 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2574 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2575 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2576 (last_non_minibuf_size, last_point_position, echo_truncate)
2577 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2578 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2579 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2580 (stuff_buffered_input):
2581 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2582 (last_auto_save, command_loop_1, read_char):
2583 Use EMACS_INT, not int, to avoid integer overflow.
2584 (record_char): Avoid overflow in total_keys computation.
2585 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2586 * keyboard.h: Adjust decls to match defn changes elsewhere.
2587 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2588 (Fkey_description, Fdescribe_vector, Flookup_key):
2589 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2590 (click_position): New function, to check that positions are in range.
2591 (Fcurrent_active_maps):
2592 (describe_command):
2593 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2594 (Faccessible_keymaps, Fkey_description):
2595 (preferred_sequence_p):
2596 Don't assume fixnum can fit into int.
2597 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2598 Check for integer overflow in size calculations.
2599 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2600 avoid mishandling large integers.
2601 * lisp.h: Adjust decls to match defn changes elsewhere.
2602 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2603 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2604 (struct Lisp_Marker):
2605 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2606 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2607 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2608 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2609 All callers changed.
2610 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2611 Assume the arg has valid form, since it always does.
2612 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2613 unsigned integer system type.
2614 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2615 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2616 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2617 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2618 (duration_to_sec_usec): New decl.
2619 * lread.c (read_from_string_index, read_from_string_index_byte)
2620 (read_from_string_limit, readchar, unreadchar, openp)
2621 (read_internal_start, read1, oblookup):
2622 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2623 (Fload, readevalloop, Feval_buffer, Feval_region):
2624 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2625 (openp): Check for out-of-range argument to 'access'.
2626 (read1): Use int, not EMACS_INT, where int is wide enough.
2627 Don't assume fixnum fits into int.
6efdadfd 2628 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2629 (read_filtered_event): Use duration_to_sec_usec
2630 to do proper overflow checking on durations.
d311d28c
PE
2631 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2632 in size calculation.
2633 (Fexecute_kbd_macro):
2634 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2635 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2636 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2637 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2638 (set_marker_both, set_marker_restricted_both, marker_position)
2639 (marker_byte_position, Fbuffer_has_markers_at):
2640 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2641 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2642 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2643 It now merely ensures that the menu is large enough, without
2644 necessarily growing it, as this avoids some integer overflow issues.
2645 All callers changed.
2646 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2647 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2648 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2649 Use SAFE_ALLOCA_LISP, not alloca.
2650 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2651 to EMACS_INT. Check that fixnums are in proper range for system types.
2652 * minibuf.c (minibuf_prompt_width, string_to_object)
2653 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2654 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2655 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2656 (get_minibuffer, read_minibuf_unwind):
2657 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2658 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2659 this simplifies overflow checking. All callers changed.
2660 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2661 (Ftest_completion):
2662 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2663 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2664 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2665 Check that fixnums are in proper range for system types.
2666 (Fx_create_frame, Fx_show_tip):
2667 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2668 * nsfont.m (ns_findfonts, nsfont_list_family):
2669 Don't assume fixnum fits in long.
2670 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2671 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2672 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2673 wide enough.
17fdb222 2674 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2675 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2676 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2677 (PRINTDECLARE, PRINTPREPARE):
2678 (strout, print_string):
2679 (print, print_preprocess, print_check_string_charset_prop)
2680 (print_object):
2681 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2682 (PRINTDECLARE):
2683 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2684 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2685 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2686 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2687 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2688 (print_error_message): Use SAFE_ALLOCA, not alloca.
2689 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2690 (print_depth, new_backquote_output, print_number_index):
2691 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2692 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2693 (Fset_process_window_size, Fformat_network_address)
2694 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2695 (sigchld_handler):
d311d28c 2696 Check that fixnums are in proper range for system types.
d44287d4 2697 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2698 Check for process-ids out of pid_t range rather than relying on
2699 undefined behavior.
e4d81efc 2700 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2701 (Fformat_network_address, read_process_output, send_process)
2702 (Fprocess_send_region, status_notify):
2703 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2704 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2705 (wait_reading_process_output, read_process_output, exec_sentinel):
2706 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2707 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2708 (Faccept_process_output): Use duration_to_sec_usec to do proper
2709 overflow checking on durations.
dde14581
PE
2710 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2711 Don't assume pid_t fits in int.
02481186
PE
2712 * process.h (struct Lisp_Process): Members tick and update_tick
2713 are now of type EMACS_INT, not int.
b62b53e8
PE
2714 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2715 configured --with-wide-int.
d311d28c
PE
2716 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2717 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2718 * search.c (looking_at_1, string_match_1):
2719 (fast_string_match, fast_c_string_match_ignore_case)
2720 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2721 (scan_newline, find_before_next_newline, search_command)
2722 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2723 (set_search_regs, wordify):
2724 (Freplace_match):
2725 (Fmatch_data):
2726 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2727 (string_match_1, search_buffer, set_search_regs):
2728 (Fmatch_data):
2729 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2730 (wordify): Check for overflow in size calculation.
2731 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2732 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2733 Check that fixnums are in proper range for system types.
2734 * sound.c (struct sound_device)
2735 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2736 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2737 (Fplay_sound_internal):
2738 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2739 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2740 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2741 (Fparse_partial_sexp):
2742 Don't assume fixnums can fit in int.
2743 (struct lisp_parse_state, find_start_pos, find_start_value)
2744 (find_start_value_byte, find_start_begv)
2745 (update_syntax_table, char_quoted, dec_bytepos)
2746 (find_defun_start, prev_char_comend_first, back_comment):
2747 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2748 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2749 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2750 (Finternal_describe_syntax_value): Check that match_lisp is a
2751 character, not an integer, since the code stuffs it into int.
2752 (scan_words, scan_sexps_forward):
2753 Check that fixnums are in proper range for system types.
2754 (Fforward_word):
2755 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2756 (scan_sexps_forward):
2757 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2758 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2759 * syntax.h: Adjust decls to match defn changes elsewhere.
2760 (struct gl_state_s):
2761 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2762 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2763 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2764 * sysdep.c (wait_for_termination_1, wait_for_termination)
2765 (interruptible_wait_for_termination, mkdir):
2766 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2767 (emacs_read, emacs_write):
2768 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2769 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2770 and double all fit in int.
d311d28c
PE
2771 * term.c (set_tty_color_mode):
2772 Check that fixnums are in proper range for system types.
2773 * termhooks.h (struct input_event):
2774 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2775 * textprop.c (validate_interval_range, interval_of)
2776 (Fadd_text_properties, set_text_properties_1)
2777 (Fremove_text_properties, Fremove_list_of_text_properties)
2778 (Ftext_property_any, Ftext_property_not_all)
2779 (copy_text_properties, text_property_list, extend_property_ranges)
2780 (verify_interval_modification):
2781 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2782 (Fnext_single_char_property_change)
2783 (Fprevious_single_char_property_change):
2784 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2785 (copy_text_properties):
2786 Check for integer overflow in index calculation.
d311d28c
PE
2787 * undo.c (last_boundary_position, record_point, record_insert)
2788 (record_delete, record_marker_adjustment, record_change)
2789 (record_property_change):
2790 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2791 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2792 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2793 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2794 (Fx_hide_tip, Fx_file_dialog):
2795 * w32menu.c (set_frame_menubar):
2796 Use ptrdiff_t, not int, for consistency with rest of code.
2797 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2798 (select_window, Fdelete_other_windows_internal)
2799 (window_scroll_pixel_based, window_scroll_line_based)
2800 (Frecenter, Fset_window_configuration):
2801 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2802 (Fset_window_hscroll, run_window_configuration_change_hook)
2803 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2804 (Fscroll_other_window, Frecenter):
d311d28c
PE
2805 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2806 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2807 Don't assume fixnum fits in int.
2808 (Fset_window_scroll_bars):
2809 Check that fixnums are in proper range for system types.
2810 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2811 (string_pos, c_string_pos, number_of_chars, init_iterator)
2812 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2813 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2814 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2815 (face_before_or_after_it_pos, handle_invisible_prop)
2816 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2817 (display_prop_intangible_p, string_buffer_position_lim)
2818 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2819 (get_overlay_strings_1, get_overlay_strings)
2820 (iterate_out_of_display_property, forward_to_next_line_start)
2821 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2822 (get_next_display_element, set_iterator_to_next)
2823 (get_visually_first_element, compute_stop_pos_backwards)
2824 (handle_stop_backwards, next_element_from_buffer)
2825 (move_it_in_display_line_to, move_it_in_display_line)
2826 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2827 (add_to_log, message_dolog, message_log_check_duplicate)
2828 (message2, message2_nolog, message3, message3_nolog
2829 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2830 (current_message_1, truncate_echo_area, truncate_message_1)
2831 (set_message, set_message_1, store_mode_line_noprop)
2832 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2833 (text_outside_line_unchanged_p, check_point_in_composition)
2834 (reconsider_clip_changes)
2835 (redisplay_internal, set_cursor_from_row, try_scrolling)
2836 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2837 (redisplay_window, find_last_unchanged_at_beg_row)
2838 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2839 (trailing_whitespace_p, find_row_edges, display_line)
2840 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2841 (display_mode_element, store_mode_line_string)
2842 (pint2str, pint2hrstr, decode_mode_spec)
2843 (display_count_lines, display_string, draw_glyphs)
2844 (x_produce_glyphs, x_insert_glyphs)
2845 (rows_from_pos_range, mouse_face_from_buffer_pos)
2846 (fast_find_string_pos, mouse_face_from_string_pos)
2847 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2848 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2849 (safe_call, init_from_display_pos, handle_fontified_prop)
2850 (handle_single_display_spec, load_overlay_strings)
2851 (with_echo_area_buffer, setup_echo_area_for_printing)
2852 (display_echo_area, echo_area_display)
2853 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2854 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2855 (redisplay_window, dump_glyph_row, display_mode_line)
2856 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2857 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2858 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2859 (handle_single_display_spec, build_desired_tool_bar_string)
2860 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2861 (get_specified_cursor_type):
2862 Check that fixnums are in proper range for system types.
2863 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2864 (Flookup_image_map):
2865 Don't assume fixnums fit in int.
2866 (compare_overlay_entries):
2867 Avoid mishandling comparisons due to subtraction overflow.
2868 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2869 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2870 (handle_tool_bar_click):
2871 Use int, not unsigned, since we prefer signed and the signedness
2872 doesn't matter here.
2873 (get_next_display_element, next_element_from_display_vector):
2874 Use int, not EMACS_INT, when int is wide enough.
2875 (start_hourglass): Use duration_to_sec_usec to do proper
2876 overflow checking on durations.
2877 * xfaces.c (Fbitmap_spec_p):
2878 Check that fixnums are in proper range for system types.
2879 (compare_fonts_by_sort_order):
2880 Avoid mishandling comparisons due to subtraction overflow.
2881 (Fx_family_fonts, realize_basic_faces):
2882 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2883 (Fx_family_fonts):
2884 Don't assume fixnum fits in int.
2885 Use SAFE_ALLOCA_LISP, not alloca.
2886 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2887 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2888 (face_at_buffer_position, face_for_overlay_string)
2889 (face_at_string_position):
2890 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2891 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2892 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2893 (Fx_show_tip):
2894 Check that fixnums are in proper range for system types.
2895 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2896 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2897 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2898 (Fx_change_window_property): Don't assume fixnums fit in int.
2899 * xfont.c (xfont_chars_supported):
2900 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2901 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2902 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2903 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2904 * xml.c (parse_region):
2905 * xrdb.c (magic_file_p):
2906 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2907 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2908 (x_get_local_selection, x_reply_selection_request)
2909 (x_handle_selection_request, wait_for_property_change):
2910 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2911 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2912 short is wide enough.
2913 (x_send_client_event): Don't assume fixnum fits in int.
2914 * xterm.c (x_x_to_emacs_modifiers):
2915 Don't assume EMACS_INT overflows nicely into int.
2916 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2917 may come from Lisp.
2918 (handle_one_xevent): NATNUMP can eval its arg twice.
2919 (x_connection_closed):
2920 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2921 * xterm.h: Adjust decls to match defn changes elsewhere.
2922 (struct scroll_bar): Use struct vectorlike_header
2923 rather than rolling our own approximation.
2924 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2925
c6574eb5
GM
29262012-05-25 Glenn Morris <rgm@gnu.org>
2927
2928 * lisp.mk (lisp): Update for more files being compiled now.
2929
e8d32c7e
SM
29302012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2931
48def666
SM
2932 * lread.c: Remove `read_pure' which makes no difference.
2933 (read_pure): Remove var.
2934 (unreadpure): Remove function.
2935 (readevalloop): Don't call read_list with -1 flag.
2936 (read1, read_vector): Don't test read_pure any more.
2937 (read_list): Simplify.
2938
e8d32c7e
SM
2939 * fileio.c, character.h: Minor style tweaks.
2940
4b2addb7
DA
29412012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2942
2943 * window.h (clip_changed): Remove useless declaration.
2944
584461b2
JB
29452012-05-22 Juanma Barranquero <lekktu@gmail.com>
2946
2947 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2948 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2949
34374650
PE
29502012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2951
2952 Remove src/m/*.
2953 This directory predates autoconf and is no longer needed nowadays.
2954 Move its few remaining bits of functionality to where they're needed.
2955 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2956 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2957 * m/template.h: Remove.
2958 * Makefile.in (M_FILE): Remove. All uses removed.
2959 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2960 * lisp.h (USE_LSB_TAG):
2961 * mem-limits.h (EXCEEDS_LISP_PTR):
2962 Use VAL_MAX, not VALBITS, in #if.
2963 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2964 (EMACS_UINT): Define unconditionally now.
2965 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2966 (BITS_PER_EMACS_INT): New constants, replacing
2967 what used to be in config.h, but not useful in #if.
2968 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2969 define them any more.
2970 (VAL_MAX): New macro.
2971 (VALMASK): Use it.
2972 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2973 BITS_PER_EMACS_INT, in #if.
2974 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2975 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2976 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2977 * s/ms-w32.h (DATA_START):
2978 Move here from removed file m/intel386.h.
2979 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2980 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2981
261cb4bb
PE
29822012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2983
2984 Assume C89 or later.
2985 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2986 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2987 (xrealloc):
2988 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2989 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2990 * textprop.c, tparam.c (NULL): Remove.
2991 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2992 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2993 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2994 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2995 * xterm.c (input_signal_count): Assume volatile works.
2996
ff23cd9f
KB
29972012-05-21 Ken Brown <kbrown@cornell.edu>
2998
2999 * xgselect.c (xg_select): Fix first argument in call to 'select'
3000 (bug#11508).
3001
1b170bc6
KB
30022012-05-20 Ken Brown <kbrown@cornell.edu>
3003
3004 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3005 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3006
b2f4d39f
KB
30072012-05-19 Ken Brown <kbrown@cornell.edu>
3008
3009 * xfns.c (x_in_use): Remove `static' qualifier.
3010 * xterm.h (x_in_use): Declare.
3011 * xgselect.c: Include xterm.h.
3012 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3013 and `display_arg' (bug#9754).
3014
003fdae2
PE
30152012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3016
9232a6d9
PE
3017 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3018
003fdae2
PE
3019 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3020 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3021
784b56e2
EZ
30222012-05-18 Eli Zaretskii <eliz@gnu.org>
3023
3024 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3025
3026 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3027 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3028
3029 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3030 reference to image_cache->refcount.
3031 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3032
a0a79cde
JL
30332012-05-17 Juri Linkov <juri@jurta.org>
3034
3035 * search.c (Fword_search_regexp, Fword_search_backward)
3036 (Fword_search_forward, Fword_search_backward_lax)
3037 (Fword_search_forward_lax): Move functions to isearch.el
3038 (bug#10145, bug#11381).
3039
b0572523
PE
30402012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3041
3042 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3043
9660f5fc
SM
30442012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3045
3046 * lread.c (init_obarray): Declare Qt and Qnil as special.
3047
4374de83
GM
30482012-05-14 Glenn Morris <rgm@gnu.org>
3049
3050 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3051 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3052
dc44c39a
PE
30532012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3054
078c97cb
PE
3055 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3056
dc44c39a
PE
3057 * unexaix.c: Port to more-recent AIX compilers.
3058 (report_error, report_error_1, make_hdr, copy_sym)
3059 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3060 Make arguments const char *, not char *, to avoid violations of C
3061 standard and to fix some AIX warnings reported by Gilles Pion.
3062
e18afed7 30632012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3064
3065 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3066 already have overlays loaded.
3067 (handle_single_display_spec): Before returning without displaying
3068 fringe bitmap, synchronize the bidi iterator with the main display
3069 iterator, by calling iterate_out_of_display_property.
3070 (iterate_out_of_display_property): Detect buffer iteration by
3071 testing that it->string is a Lisp string.
3072 (get_next_display_element): When the current object is exhausted,
3073 and there's something on it->stack, call set_iterator_to_next to
3074 proceed with what's on the stack, instead of returning zero.
3075 (set_iterator_to_next): If called at the end of a Lisp string,
3076 proceed to consider_string_end without incrementing string
3077 position. Don't increment display vector index past the end of
3078 the display vector. (Bug#11417)
c8fb9dc6
EZ
3079 (pos_visible_p): Don't report a position visible when move_it_to
3080 stopped at the last line of window, which happens to be scanned
3081 backwards by the bidi iteration. (Bug#11464)
ac268e67 3082
e18afed7 30832012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3084
3085 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3086 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3087 are on a TTY, and thus unable to display on the fringes.
3088 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3089 so we need to signal to the caller that this is a "replacing"
3090 display spec. This fixes display when the spec is invalid or we
3091 are on a TTY.
3092
e18afed7 30932012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3094
3095 * unexaix.c (make_hdr): Fix typo in prototype.
3096 This bug broke the build on AIX. Problem reported by Gilles Pion.
3097
9d0a235a
MA
30982012-05-14 Michael Albinus <michael.albinus@gmx.de>
3099
3100 * keyboard.c (kbd_buffer_get_event): Read special events also in
3101 batch mode. (Bug#11415)
3102
9e6b06ed
GM
31032012-05-12 Glenn Morris <rgm@gnu.org>
3104
3105 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3106
c1a1d7a3
EZ
31072012-05-12 Eli Zaretskii <eliz@gnu.org>
3108
3109 * lisp.mk (lisp): Add newcomment.elc.
3110
3fe7cdc8
GM
31112012-05-12 Glenn Morris <rgm@gnu.org>
3112
3113 * Makefile.in (MKDIR_P): New, set by configure.
3114 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3115
53f7d2c0
PE
31162012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3117
3118 Remove unused function hourglass_started.
3119 * dispextern.h (hourglass_started):
3120 * w32fns.c (hourglass_started):
3121 * xdisp.c (hourglass_started): Remove.
3122
75aafb17
JB
31232012-05-10 Juanma Barranquero <lekktu@gmail.com>
3124
3125 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3126 Update dependencies.
3127
12959e8e
PE
31282012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3129
97107e2e
PE
3130 * xgselect.c (xg_select): Put maxfds+1 into a var.
3131 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3132
12959e8e
PE
3133 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3134
836d29b3
DA
31352012-05-10 Dave Abrahams <dave@boostpro.com>
3136
3137 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3138 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3139
5cb67954
MA
31402012-05-09 Michael Albinus <michael.albinus@gmx.de>
3141
3142 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3143 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3144 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3145 Initialize xd_registered_buses.
3146
3478ec45
PE
31472012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3148
b263a6b0
PE
3149 Untag more efficiently if USE_LSB_TAG.
3150 This is based on a proposal by YAMAMOTO Mitsuharu in
3151 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3152 For an admittedly artificial (nth 8000 longlist) benchmark on
3153 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3154 Emacs's overall text size by 1%.
3155 * lisp.h (XUNTAG): New macro.
3156 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3157 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3158 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3159 * eval.c (Fautoload):
3160 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3161 * frame.h (XFRAME): Use XUNTAG.
3162
3478ec45
PE
3163 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3164 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3165 Remove unportable assumptions about print widths of types like
3166 dbus_uint32_t.
3167 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3168 intptr_t when converting between pointer and integer, to avoid GCC
3169 warnings about wrong width.
3170
666b903b 31712012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3172
3173 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3174 stack for each reader_thread, instead of defaulting to 8MB
3175 determined by the linker. This avoids failures in creating
3176 subprocesses on Windows 7, see the discussion in this thread:
3177 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3178
b120cc17
JC
31792012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3180
3181 Fix up display of the *Minibuf-0* buffer in the mini window.
3182 * keyboard.c (read_char): Don't clear the echo area if there's no
3183 message to clear.
3184 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3185 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3186
9a4b36f8
MA
31872012-05-07 Michael Albinus <michael.albinus@gmx.de>
3188
3189 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3190 batch mode.
3191
e5f9458f
CY
31922012-05-06 Chong Yidong <cyd@gnu.org>
3193
3194 * lisp.mk (lisp): Update.
3195
eceeb5fc 31962012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3197
3198 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3199
71873e2b
SM
32002012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3201
3202 * data.c (PUT_ERROR): New macro.
3203 (syms_of_data): Use it. Add new error type `user-error'.
3204 * undo.c (user_error): New function.
3205 (Fprimitive_undo): Use it.
3206 * print.c (print_error_message): Adjust print style for `user-error'.
3207 * keyboard.c (user_error): New function.
3208 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3209
ab0fa4e4
PE
32102012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3211
3212 Do not limit current-time-string to years 1000..9999.
3213 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3214 (Fcurrent_time_string): Support any year that is supported by the
3215 underlying localtime representation. Don't use asctime, as it
3216 has undefined behavior for years outside the range -999..9999.
3217
7ed806a7
PE
32182012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3219
3220 Fix race conditions involving setenv, gmtime, localtime, asctime.
3221 Without this fix, interrupts could mess up code that uses these
3222 nonreentrant functions, since setting TZ invalidates existing
3223 tm_zone or tzname values, and since most of these functions return
3224 pointers to static storage.
3225 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3226 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3227 Grow the critical sections to include not just invoking
3228 localtime/gmtime, but also accessing these functions' results
3229 including their tm_zone values if any, and any related TZ setting.
3230 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3231 so that the struct tm is saved in the critical section.
3232 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3233 motivated by the fact that memory allocation needs to be outside
3234 the critical section.
3235
0c16dfed
DA
32362012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3237
3238 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3239 with RESET_INTERVAL.
3240
3241 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3242 Remove duplicated buffer name initialization.
3243
3f83ace8
JM
32442012-05-02 Jim Meyering <jim@meyering.net>
3245
3246 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3247
c7b8541e
JM
3248 * xfns.c (x_window): Use xstrdup (Bug#11375).
3249
90207a15 32502012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3251
3252 * xdisp.c (pos_visible_p): If already at a newline from the
3253 display string before the 'while' loop, don't walk back the glyphs
3254 from it3.glyph_row. Solves assertion violation when the display
3255 string begins with a newline (egg.el). (Bug#11367)
3256
b593d6a9
AH
32572012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3258
3259 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3260 Move to simple.el.
3261
4737362e
GM
32622012-05-01 Glenn Morris <rgm@gnu.org>
3263
99cf43f9
GM
3264 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3265 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3266 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3267 All were removed before 23.1.
3268
9311dcff
GM
3269 * dispnew.c: Remove HAVE_LIBNCURSES test;
3270 it is always true on relevant platforms.
3271
4d5c6349
GM
3272 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3273 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3274
4737362e
GM
3275 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3276
74dd3a6b
AS
32772012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3278
3279 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3280 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3281 Remove.
3282
13c379ee
PE
32832012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3284
3285 Do not avoid creating empty evaporating overlays (Bug#9642).
3286 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3287 That is, do not delete an evaporating overlay if it becomes
3288 empty after its bounds are adjusted to fit within its buffer.
3289 This fix caused other problems, and I'm reverting it until we get
3290 to the bottom of them.
3291
a8e7d6d7 32922012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3293
3294 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3295
a8e7d6d7 32962012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3297
3298 * xdisp.c (pos_visible_p): If the window start position is beyond
3299 ZV, start the display from buffer beginning. Prevents assertion
3300 violation in init_iterator when the minibuffer window is scrolled
3301 via the scroll bar.
3302
3303 * window.c (window_scroll_pixel_based): Likewise.
3304
a8e7d6d7 33052012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3306
3307 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3308
a8e7d6d7 33092012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3310
3311 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3312 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3313
a8e7d6d7 33142012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3315
b593d6a9
AH
3316 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3317 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3318
1c6900d9
EZ
33192012-04-26 Eli Zaretskii <eliz@gnu.org>
3320
4c3fa1d9
EZ
3321 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3322 display element, check also the underlying string or buffer
3323 character. (Bug#11341)
3324
1c6900d9
EZ
3325 * w32menu.c: Include w32heap.h.
3326 (add_menu_item): If the call to AppendMenuW (via
3327 unicode_append_menu) fails, disable Unicode menus only if we are
3328 running on Windows 9X/Me.
3329
42bf8205
AS
33302012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3331
3332 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3333 (xgetint): Add missing shift for LSB tags.
3334
b1bac16e
MR
33352012-04-24 Martin Rudalics <rudalics@gmx.at>
3336
3337 * keyboard.c (read_char): Don't wipe echo area for select window
3338 events: These might get delayed via `mouse-autoselect-window'
3339 (Bug#11304).
3340
d69621cc
JB
33412012-04-24 Juanma Barranquero <lekktu@gmail.com>
3342
3343 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3344 manipulation of :loaded-from data.
3345
02fd101b
JB
33462012-04-23 Juanma Barranquero <lekktu@gmail.com>
3347
3348 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3349 now a cons (bug#11311).
3350
888bec30
PE
33512012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3352
89a438bd
PE
3353 Do not create empty overlays with the evaporate property (Bug#9642).
3354 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3355 if it becomes empty after its bounds are adjusted to fit within
3356 its buffer. Without this fix, in a nonempty buffer (let ((o
3357 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3358 yields an empty overlay that has the evaporate property, which is
3359 not supposed to happen.
3360
1068fe4d
PE
3361 Fix minor GTK3 problems found by static checking.
3362 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3363 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3364 (struct _EmacsFixedClass, emacs_fixed_get_type):
3365 Move decls here from emacsgtkfixed.h, since they needn't be public.
3366 (emacs_fixed_get_type): Now static.
3367 (emacs_fixed_class_init): Omit unused local.
3368 (emacs_fixed_child_type): Remove; unused.
3369 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3370 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3371 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3372 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3373 (EMACS_FIXED_GET_CLASS): Remove; unused.
3374 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3375
888bec30
PE
3376 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3377 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3378
de85e130
PE
33792012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3380
d0baac98 3381 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3382 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3383 (__malloc_size_t, __malloc_ptrdiff_t):
3384 Remove. All uses removed, replaced by the definiens if needed,
3385 since we can assume C89 or better now.
3386 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3387 (protect_malloc_state, align, get_contiguous_space)
3388 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3389 (malloc_atfork_handler_child, malloc_enable_thread)
3390 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3391 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3392 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3393 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3394 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3395 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3396 Define using prototypes, not old style.
3397 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3398 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3399 (align): Don't assume that signed integer overflow wraps around.
3400 Omit unused local var.
3401 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3402 (_free_internal_nolock, memalign, mallochook, reallochook):
3403 Omit no-longer-needed casts.
3404 (valloc): Use getpagesize, not __getpagesize.
3405 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3406 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3407
de85e130
PE
3408 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3409
dcbf5805
MA
34102012-04-22 Michael Albinus <michael.albinus@gmx.de>
3411
3412 Move functions from C to Lisp. Make non-blocking method calls
3413 the default. Implement further D-Bus standard interfaces.
3414
3415 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3416 (QCdbus_request_name_allow_replacement)
3417 (QCdbus_request_name_replace_existing)
3418 (QCdbus_request_name_do_not_queue)
3419 (QCdbus_request_name_reply_primary_owner)
3420 (QCdbus_request_name_reply_in_queue)
3421 (QCdbus_request_name_reply_exists)
3422 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3423 (QCdbus_registered_serial, QCdbus_registered_method)
3424 (QCdbus_registered_signal): New Lisp objects.
3425 (XD_DEBUG_MESSAGE): Use sizeof.
3426 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3427 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3428 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3429 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3430 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3431 (xd_signature, xd_append_arg): Allow float for integer types.
3432 (xd_get_connection_references): New function.
b593d6a9
AH
3433 (xd_get_connection_address): Rename from xd_initialize.
3434 Return cached address.
dcbf5805
MA
3435 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3436 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3437 level.
3438 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3439 Return number of refcounts.
dcbf5805
MA
3440 (Fdbus_get_unique_name): Make stronger parameter check.
3441 (Fdbus_message_internal): New defun.
3442 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3443 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3444 (Fdbus_send_signal, Fdbus_register_service)
3445 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3446 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3447 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3448 (Vdbus_compiled_version, Vdbus_runtime_version)
3449 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3450 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3451 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3452 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3453 Adapt docstring.
dcbf5805 3454
52828e02
PE
34552012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3456
da05bc4c
PE
3457 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3458 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3459 Do not assume ptrdiff_t is the same width as 'int'.
3460
52828e02
PE
3461 * alloc.c: Handle unusual debugging option combinations.
3462 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3463 since the two debugging options are incompatible.
3464 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3465 is defined.
3466 (mem_init, mem_insert, mem_insert_fixup):
3467 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3468 (NEED_MEM_INSERT): Remove; no longer needed.
3469
f01769f9
LL
34702012-04-22 Leo Liu <sdl.web@gmail.com>
3471
3472 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3473
5790543d
PE
34742012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3475
3476 * sysdep.c [__FreeBSD__]: Minor cleanups.
3477 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3478 Use Emacs indenting style more consistently. Avoid some casts.
3479 Use 'double' consistently rather than mixing 'float' and 'double'.
3480
b91b7e4d
EW
34812012-04-21 Eduard Wiebe <usenet@pusto.de>
3482
b593d6a9
AH
3483 * sysdep.c (list_system_processes, system_process_attributes):
3484 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3485
6114eb15
AS
34862012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3487
3488 * lisp.mk (lisp): Update.
3489
2f38dff7
PE
34902012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3491
3492 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3493 It is never used otherwise.
3494
4ae29f89
SM
34952012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3496
3497 * print.c (print_preprocess): Only check print_depth if print-circle
3498 is nil.
3499 (print_object): Check for cycles even when print-circle is nil and
3500 print-gensym is t, but only check print_depth if print-circle is nil.
3501
f30d612a
CY
35022012-04-20 Chong Yidong <cyd@gnu.org>
3503
3504 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3505 set the status to "failed" and ensure that sentinel is run.
3506
c07a4c0b 35072012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3508
3509 * process.c (Fset_process_inherit_coding_system_flag)
3510 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3511 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3512
c07a4c0b 35132012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3514
3515 * xdisp.c (string_buffer_position_lim): Limit starting position to
3516 BEGV.
3517 (set_cursor_from_row): If called for a mode-line or header-line
3518 row, return zero immediately.
3519 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3520 farther than the first row after the header line, if any.
3521 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3522 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3523
c07a4c0b 35242012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3525
4ae29f89
SM
3526 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3527 (bug#11238).
ad3a2b41 3528
c07a4c0b 35292012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 35302012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3531
3532 configure: new option --enable-gcc-warnings (Bug#11207)
3533 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3534 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3535 (ALL_CFLAGS): Use new macros rather than old.
3536 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3537 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3538 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3539 -Wunused-result, -Wunused-variable. This should go away once
3540 the Emacs and Gnulib regex code is merged.
3541 (xmalloc, xrealloc): Now static.
3542
aba027e8
PE
35432012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3544
3545 * dired.c (Fsystem_groups): Remove unused local.
3546
e5a36063
GM
35472012-04-17 Glenn Morris <rgm@gnu.org>
3548
3549 * dired.c (Fsystem_users): Doc fix.
3550
316411f0
DA
35512012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3552
3553 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3554 (syms_of_dired): Add them.
3555
9426aba4
PE
35562012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3557
b62a57be
PE
3558 Fix minor alloc.c problems found by static checking.
3559 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3560 New extern decls, to avoid calling undeclared functions.
3561 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3562 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3563 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3564 (NEED_MEM_INSERT): New macro.
3565 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3566 Remove one incorrect comment and fix another.
b62a57be 3567
3539f31f
PE
3568 Fix minor ralloc.c problems found by static checking.
3569 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3570 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3571 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3572 (r_alloc_sbrk): Now static.
3573
a041960a
PE
3574 Improve ralloc.c interface checking.
3575 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3576 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3577 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3578 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3579 [REL_ALLOC]: ... to here, to check interface.
3580 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3581 Remove decls. This fixes an "It stinks!".
3582
9426aba4
PE
3583 * alloc.c (which_symbols): Fix alignment issue / type clash.
3584
d55c12ed
AS
35852012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3586
3587 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3588 (struct Lisp_Misc_Any): Likewise.
3589 (struct Lisp_Free): Likewise.
3590 * alloc.c (union aligned_Lisp_Symbol): Define.
3591 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3592 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3593 (union aligned_Lisp_Misc): Define.
3594 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3595 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3596 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3597
b948ce8b
PE
35982012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3599
3600 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3601 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3602 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3603 * s/netbsd.h, s/sol2-6.h:
3604 Remove definition of GC_MARK_STACK, since the default now works.
3605 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3606 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3607 no longer the default.
3608 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3609
35dc09a1 36102012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3611
35dc09a1
GM
3612 * lread.c (lisp_file_lexically_bound_p):
3613 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3614
35dc09a1
GM
36152012-04-14 Eli Zaretskii <eliz@gnu.org>
3616
3617 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3618 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3619
36202012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3621
3622 * nsterm.m (constrainFrameRect): Always constrain when there is only
3623 one screen (Bug#10962).
3624
bcd86815
KB
36252012-04-13 Ken Brown <kbrown@cornell.edu>
3626
3627 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3628
c25df26e
RT
36292012-04-13 Reuben Thomas <rrt@sc3d.org>
3630
3631 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3632
0fc59f1e
DC
36332012-04-11 Daniel Colascione <dancol@dancol.org>
3634
3635 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3636 against is gone. It's better to use vfork now so that when Cygwin
3637 gains a new, working vfork, we use it automatically (bug#10398).
3638
de8c03dc
SM
36392012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3640
3641 * window.c (save_window_save): Obey window-point-insertion-type.
3642
2f097256
GM
36432012-04-11 Glenn Morris <rgm@gnu.org>
3644
3645 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3646
453b951e
SM
36472012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3648
3649 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3650
75f1671a 36512012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3652
3653 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3654 (force_quit_count): New var.
3655 (handle_interrupt): Use it.
3656
2a8ce227
JB
36572012-04-10 Juanma Barranquero <lekktu@gmail.com>
3658
3659 * w32.c (w32_delayed_load): Record the full path of the library
3660 being loaded (bug#10424).
3661
935396c0
GM
36622012-04-09 Glenn Morris <rgm@gnu.org>
3663
05920a43
GM
3664 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3665 not just in the obarray, before snarfing them. (Bug#11036)
3666
935396c0
GM
3667 * Makefile.in ($(leimdir)/leim-list.el):
3668 Pass EMACS rather than BUILT_EMACS.
3669
a18ecafa
TZ
36702012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3671
3672 * process.c (make_process):
3673 * process.h: Add integer `gnutls_handshakes_tried' member to
3674 process struct.
3675
6bbef4e5
JC
3676 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3677 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3678
3679 * gnutls.c (gnutls_log_function2i): Convenience log function.
3680 (emacs_gnutls_read): Use new log functions,
3681 `gnutls_handshakes_tried' process member, and
3682 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3683 attempts per process (connection).
3684
b4d3bc10
CY
36852012-04-09 Chong Yidong <cyd@gnu.org>
3686
3687 * eval.c (Fuser_variable_p, user_variable_p_eh)
3688 (lisp_indirect_variable): Functions deleted.
3689 (Fdefvar): Caller changed.
3690
3691 * callint.c (Finteractive, Fcall_interactively):
3692 * minibuf.c (Fread_variable): Callers changed.
3693
70f4d973
EZ
36942012-04-09 Eli Zaretskii <eliz@gnu.org>
3695
3696 * xdisp.c (set_cursor_from_row): If the display string appears in
3697 the buffer at position that is closer to point than the position
3698 after the display string, display the cursor on the first glyph of
3699 the display string. Fixes cursor display when a 'display' text
3700 property immediately follows invisible text. (Bug#11094)
3701
cb3c2e3e
PE
37022012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3703
3704 composite.c: use 'double' consistently
3705 * composite.c (get_composition_id): Use 'double' consistently
3706 instead of converting 'float' to 'double' and vice versa; this is
3707 easier to understand and avoids a GCC warning.
3708
fd06db5d
GM
37092012-04-09 Glenn Morris <rgm@gnu.org>
3710
50fe702a
GM
3711 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3712 preparation for dumping it with emacs. (Bug#4789)
3713 (leimdir): New variable.
3714 ($(leimdir)/leim-list.el): New rule.
3715 (emacs$(EXEEXT)): Depend on leim-list.el.
3716
fd06db5d
GM
3717 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3718 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3719 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3720
55c131ee
AS
37212012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3722
3723 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3724 proper alignment.
3725
9209588f
JB
37262012-04-07 Juanma Barranquero <lekktu@gmail.com>
3727
3728 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3729 Remove unused local variable.
3730
e3fb2efb
PE
37312012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3732
3733 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3734 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3735 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3736 objects, as mark_maybe_pointer will catch them otherwise.
3737 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3738 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3739
b5385551
PE
37402012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3741
3742 Fix typo that broke non-Windows builds.
3743 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3744
9078ead6
EZ
37452012-04-07 Eli Zaretskii <eliz@gnu.org>
3746
3747 Support building on MS-Windows with libxml2.
3748
3749 * makefile.w32-in (OBJ2): Add xml.$(O).
3750 (GLOBAL_SOURCES): Add xml.c.
3751 ($(BLD)/xml.$(O)): New dependency list.
3752
3753 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3754 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3755 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3756 [!WINDOWSNT]: New macros.
3757 (init_libxml2_functions, libxml2_loaded_p): New functions.
3758 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3759 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3760 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3761 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3762 linked in).
6bbef4e5
JC
3763 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3764 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3765 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3766
3767 * emacs.c: Don't include libxml/parser.h.
3768 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3769 xmlCleanupParser directly.
3770
3771 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3772
3811fdf3
EZ
37732012-04-07 Eli Zaretskii <eliz@gnu.org>
3774
3775 * indent.c (Fvertical_motion): If there is a display string at
3776 point, use it.vpos to compute how many lines to backtrack after
3777 move_it_to point. (Bug#11133)
3778
2f8e16b2
EZ
37792012-04-06 Eli Zaretskii <eliz@gnu.org>
3780
3781 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3782 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3783 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3784 macros related to unification of CJK characters. For the details,
3785 see the discussion following the message here:
3786 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3787
3d439cd1
CY
37882012-04-04 Chong Yidong <cyd@gnu.org>
3789
3790 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3791
8bc53d00
EZ
37922012-04-01 Eli Zaretskii <eliz@gnu.org>
3793
3794 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3795 instead of alloca. (Bug#11138)
3796
3b0512a3
AS
37972012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3798
3799 * w32menu.c (is_simple_dialog): Properly check lisp types.
3800 (Bug#11141)
3801
8427ddd2
EZ
38022012-03-31 Eli Zaretskii <eliz@gnu.org>
3803
979022ef
EZ
3804 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3805 position we get to after a call to move_it_to fails the
3806 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3807 only if we wind up in a string from display property. (Bug#11063)
3808
a6b1c7cc
EZ
3809 * window.c (Fdelete_other_windows_internal): Invalidate the row
3810 and column information about mouse highlight, so that redisplay
3811 restores it after reallocating the glyph matrices. (Bug#7464)
3812
8427ddd2
EZ
3813 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3814 string comes from a `display' text property, use the buffer
3815 position of that property as if we actually saw that position in
3816 the row's glyphs.
697ba24b
EZ
3817 (move_it_by_lines): Remove the assertion that
3818 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3819 violated when there's a before-string at the beginning of a line.
3820 (Bug#11063)
8427ddd2 3821
65a0a738
EZ
38222012-03-30 Eli Zaretskii <eliz@gnu.org>
3823
3824 * xdisp.c (append_space_for_newline): If the default face was
3825 remapped, use the remapped face for the appended newline.
3826 (extend_face_to_end_of_line): Use the remapped default face for
3827 extending the face to the end of the line.
3828 (display_line): Call extend_face_to_end_of_line when the default
3829 face was remapped. (Bug#11068)
3830
581355cc
EZ
38312012-03-29 Eli Zaretskii <eliz@gnu.org>
3832
3833 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3834
e8fc049f
SM
38352012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3836
3837 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3838
4fb9a543
GM
38392012-03-27 Glenn Morris <rgm@gnu.org>
3840
3841 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3842 Doc fixes.
3843
679910f1
KH
38442012-03-26 Kenichi Handa <handa@m17n.org>
3845
3846 * dispextern.h (struct glyph): Fix previous change. Change the
3847 bit length of glyphless.ch to 25 (Bug#11082).
3848
90d49b7f
CY
38492012-03-26 Chong Yidong <cyd@gnu.org>
3850
3851 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3852 (command_loop_1): Use it; inhibit selection update for
3853 handle-select-window too (Bug#8996).
3854
f514f6f0
FP
38552012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3856
e8fc049f 3857 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3858
bf43fa51
KH
38592012-03-25 Kenichi Handa <handa@m17n.org>
3860
3861 * dispextern.h (struct glyph): Change the bit length of
3862 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3863
8a0c01dd
EZ
38642012-03-24 Eli Zaretskii <eliz@gnu.org>
3865
3866 * s/ms-w32.h (tzname): Include time.h before redirecting to
3867 _tzname. Fixes the MSVC build. (Bug#9960)
3868
7d1c3a76
AS
38692012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3870
8ed79523
AS
3871 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3872 characters.
3873
7d1c3a76
AS
3874 * xterm.c (XTread_socket): Only modify handling_signal if
3875 !SYNC_INPUT. (Bug#11080)
3876
e99a9b8b
EZ
38772012-03-23 Eli Zaretskii <eliz@gnu.org>
3878
3879 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3880 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3881 when fetching a multibyte character consumes more bytes than
3882 CHAR_BYTES returns, due to unification of CJK characters in
3883 string_char. (Bug#11073)
3884
5063c0e1
TN
38852012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3886
3887 * process.c (wait_reading_process_output): Handle pty disconnect
3888 by refraining from sending oneself a SIGCHLD (bug#10933).
3889
9f851fbd
CY
38902012-03-22 Chong Yidong <cyd@gnu.org>
3891
3892 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3893
5063c0e1 3894 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3895 Mark string as coming from a prefix property.
3896 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3897 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3898
fb5b8aca
CY
38992012-03-21 Chong Yidong <cyd@gnu.org>
3900
3901 * xfaces.c (Vface_remapping_alist): Doc fix.
3902
62356a1b
EZ
39032012-03-20 Eli Zaretskii <eliz@gnu.org>
3904
3905 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3906 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3907 Doc fixes.
62356a1b 3908
025de85b
CY
39092012-03-20 Chong Yidong <cyd@gnu.org>
3910
3911 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3912 to reflect default non-nil value of redisplay-dont-pause.
3913
4827f94e
KH
39142012-03-19 Kenichi Handa <handa@m17n.org>
3915
3916 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3917 it fit in a valid range (Bug#11003).
3918
e50a24a2
EZ
39192012-03-18 Eli Zaretskii <eliz@gnu.org>
3920
3921 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3922 that is not from display property, accept the row as a "cursor
3923 row" if one of the string's character has a non-nil `cursor'
3924 property. Fixes cursor positioning when there are newlines in
3925 overlay strings, e.g. in icomplete.el. (Bug#11035)
3926
9af5ed87
PE
39272012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3928
3929 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3930
d1f55f16
CY
39312012-03-12 Chong Yidong <cyd@gnu.org>
3932
3933 * eval.c (inhibit_lisp_code): Rename from
3934 inhibit_window_configuration_change_hook; move from window.c.
3935
3936 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3937 * window.c (run_window_configuration_change_hook)
3938 (syms_of_window): Callers changed.
3939
66c5eebd
CY
39402012-03-11 Chong Yidong <cyd@gnu.org>
3941
413df973
CY
3942 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3943
66c5eebd
CY
3944 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3945
1de11f56
CY
39462012-03-10 Chong Yidong <cyd@gnu.org>
3947
3948 * frame.c (other_visible_frames): Don't assume the selected frame
3949 is visible (Bug#10955).
3950
cae07000
SM
39512012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3952
3953 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3954
89c94350
JD
39552012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3956
3957 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3958 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3959 zero (Bug#10954).
3960
999dd333
GM
39612012-03-03 Glenn Morris <rgm@gnu.org>
3962
01a6dcc8 3963 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3964
de0100f2
EZ
39652012-03-02 Eli Zaretskii <eliz@gnu.org>
3966
3967 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3968 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3969 (redisplay_window, next_element_from_string): Fix typos in
3970 comments.
3e441275
EZ
3971 (redisplay_window): Pass to move_it_vertically the margin in
3972 pixels, not in screen lines.
de0100f2 3973
96a72ee9
GM
39742012-03-02 Glenn Morris <rgm@gnu.org>
3975
3976 * buffer.c (buffer-list-update-hook): Doc fix.
3977
312508d7
EZ
39782012-02-29 Eli Zaretskii <eliz@gnu.org>
3979
3980 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3981 push_it before setting up the iterator for the first overlay
3982 string, even if we have an empty string loaded.
3983 (next_overlay_string): If there's an empty string on the iterator
3984 stack, pop the stack. (Bug#10903)
3985
27f3c637
PE
39862012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3987
3988 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3989 Suggested by Stefan Monnier in
3990 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3991 * alloc.c (widen_to_Lisp_Object): New static function.
3992 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3993 and widening them to Lisp_Objects. This would work even if
3994 USE_LSB_TAG is defined and wide integers are used, which might
3995 happen in a future version of Emacs.
3996
3c9dfce6
CY
39972012-02-25 Chong Yidong <cyd@gnu.org>
3998
fa74b241
CY
3999 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4000 Doc fix.
4001
3c9dfce6
CY
4002 * xselect.c (Fx_selection_exists_p): Doc fix.
4003 (x_clipboard_manager_save_all): Print an informative message
4004 before saving to clipboard manager.
4005
9486df08
CY
40062012-02-24 Chong Yidong <cyd@gnu.org>
4007
4008 * keyboard.c (process_special_events): Handle all X selection
4009 requests in kbd_buffer, not just the next one (Bug#8869).
4010
f01d3321
CY
40112012-02-23 Chong Yidong <cyd@gnu.org>
4012
4013 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4014 call when setting menu-bar-lines and tool-bar-lines parameters.
4015 (unwind_create_frame_1): New helper function.
4016
4017 * window.c (inhibit_window_configuration_change_hook): New var.
4018 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4019 (syms_of_window): Initialize it.
f01d3321 4020
86b847b6
CY
40212012-02-22 Chong Yidong <cyd@gnu.org>
4022
4023 * xterm.c (x_draw_image_relief): Add missing type check for
4024 Vtool_bar_button_margin (Bug#10743).
4025
a59225b1
CY
40262012-02-21 Chong Yidong <cyd@gnu.org>
4027
4028 * fileio.c (Vfile_name_handler_alist): Doc fix.
4029
4030 * buffer.c (Fget_file_buffer): Protect against invalid file
4031 handler return value.
4032
310f5bd4
PE
40332012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4034
cb3a28cc
PE
4035 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4036 when computing $valmask.
4037
310f5bd4
PE
4038 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4039 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4040 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4041 It's useless in that case, and it can cause problems on hosts
4042 that allocate halves of EMACS_INT values separately.
4043 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4044 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4045 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4046 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4047 it avoids undefined behavior on hosts where shifting right by more
4048 than the word width has undefined behavior.
4049
2375c96a
CY
40502012-02-19 Chong Yidong <cyd@gnu.org>
4051
4052 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4053 (Funhandled_file_name_directory, Ffile_name_as_directory)
4054 (Fdirectory_file_name, Fexpand_file_name)
4055 (Fsubstitute_in_file_name): Protect against invalid file handler
4056 return values (Bug#10845).
4057
3eb49e71
EZ
40582012-02-18 Eli Zaretskii <eliz@gnu.org>
4059
4060 * .gdbinit (pitx): Fix incorrect references to fields of the
4061 iterator stack.
4062
7b926f3f
CY
40632012-02-17 Chong Yidong <cyd@gnu.org>
4064
4065 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4066
11273115
PE
40672012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4068
4069 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4070 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4071
c3a70e2b
CY
40722012-02-15 Chong Yidong <cyd@gnu.org>
4073
4074 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4075 marked as special. Also, starting docstrings with * is obsolete.
4076
0ca43699
AS
40772012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4078
4079 * gnutls.c (emacs_gnutls_write): Fix last change.
4080
2e8f3c56
LI
40812012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4082
4083 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4084 send_process.
4085
af70074f
SM
40862012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4087
4088 * keymap.c (Fsingle_key_description): Handle char ranges.
4089
95986d52
CY
40902012-02-12 Chong Yidong <cyd@gnu.org>
4091
afd83bd1
CY
4092 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4093 as that creates a dangerous corner case.
4094
95986d52
CY
4095 * window.c (Fdelete_window_internal): Invalidate the mouse
4096 highlight (Bug#9904).
4097
bd7da63e
GM
40982012-02-12 Glenn Morris <rgm@gnu.org>
4099
4100 * xselect.c (Fx_own_selection_internal)
4101 (Fx_get_selection_internal, Fx_disown_selection_internal)
4102 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4103 * nsselect.m (Fx_own_selection_internal)
4104 (Fx_disown_selection_internal, Fx_selection_exists_p)
4105 (Fx_selection_owner_p, Fx_get_selection_internal):
4106 Sync docs and argument specs with the xselect.c versions.
4107
77abcbc2
LI
41082012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4109
4110 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4111
90b671e2
EZ
41122012-02-11 Eli Zaretskii <eliz@gnu.org>
4113
1c0ca0b7
EZ
4114 * w32select.c (Fx_selection_exists_p): Sync doc string and
4115 argument list with xselect.c. (Bug#10783)
4116
4117 * w16select.c (Fx_selection_exists_p): Sync doc string and
4118 argument list with xselect.c. (Bug#10783)
90b671e2 4119
49241268
GM
41202012-02-10 Glenn Morris <rgm@gnu.org>
4121
4122 * fns.c (Fsecure_hash): Doc fix.
4123
f998bbe7 41242012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4125
4126 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4127
0992bd9c
CY
41282012-02-07 Chong Yidong <cyd@gnu.org>
4129
4130 * buffer.c (Fbuffer_local_variables)
4131 (buffer_lisp_local_variables): Handle unbound vars correctly;
4132 don't let Qunbound leak into Lisp.
4133
af008560
GM
41342012-02-07 Glenn Morris <rgm@gnu.org>
4135
dd605cc4
GM
4136 * image.c (Fimagemagick_types): Doc fix.
4137
af008560
GM
4138 * image.c (imagemagick-render-type): Change it from a lisp object
4139 to an integer. Move the doc here from the lisp manual.
4140 Treat all values not equal to 0 the same.
4141
1449fa1d
CY
41422012-02-06 Chong Yidong <cyd@gnu.org>
4143
4144 * doc.c (store_function_docstring): Avoid applying docstring of
4145 alias to base function (Bug#2603).
4146
3723ec07
AS
41472012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4148
4149 * .gdbinit (pp1, pv1): Remove redundant defines.
4150 (pr): Use pp.
4151
79c1cc1e
CY
41522012-02-04 Chong Yidong <cyd@gnu.org>
4153
4154 * nsterm.m: Declare a global (Bug#10694).
4155
d7f29f8e
EZ
41562012-02-04 Eli Zaretskii <eliz@gnu.org>
4157
cae07000
SM
4158 * w32.c (get_emacs_configuration_options):
4159 Include --enable-checking, if specified, in the return value.
d7f29f8e 4160
3b95a6f9
MR
41612012-02-04 Martin Rudalics <rudalics@gmx.at>
4162
4163 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4164 after rounding frame sizes. (Bug#9723)
4165
d6fa96a6
EZ
41662012-02-04 Eli Zaretskii <eliz@gnu.org>
4167
4168 * keyboard.c (adjust_point_for_property): Don't position point
4169 before BEGV. (Bug#10696)
4170
df0b2940
PE
41712012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4172
4173 Handle overflow when computing char display width (Bug#9496).
4174 * character.c (char_width): Return EMACS_INT, not int.
4175 (char_width, c_string_width): Check for overflow when
4176 computing the width; this is possible now that individual
4177 characters can have unbounded width. Problem introduced
4178 by merge from Emacs 23 on 2012-01-19.
4179
6bee44d6
MA
41802012-02-02 Michael Albinus <michael.albinus@gmx.de>
4181
4182 * dbusbind.c (Fdbus_register_method): Mention the return value
4183 :ignore in the docstring.
4184
44f92739
GM
41852012-02-02 Glenn Morris <rgm@gnu.org>
4186
1b9f60cc
GM
4187 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4188
44f92739
GM
4189 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4190 Unconditionally set to t. (Bug#10673)
4191 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4192 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4193 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4194
c5d3843c
KH
41952012-02-02 Kenichi Handa <handa@m17n.org>
4196
4197 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4198 0, do not call append_composite_glyph.
4199
159462d4 42002012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4201
4202 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4203 NULL (Bug#6988).
4204 (x_produce_glyphs): If the component of a composition is a null
4205 string, set it->pixel_width to 1 to avoid zero-width glyph.
4206
78cef877
EZ
42072012-02-01 Eli Zaretskii <eliz@gnu.org>
4208
4209 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4210 first 2 arguments are identical. This makes inserting large
4211 output from a subprocess an order of magnitude faster on
4212 MS-Windows, where all sbrk'ed memory is always contiguous.
4213
97897668
GM
42142012-01-31 Glenn Morris <rgm@gnu.org>
4215
4216 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4217 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4218 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4219
31fd3586
GM
42202012-01-29 Glenn Morris <rgm@gnu.org>
4221
4222 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4223
0e24a8b2
CY
42242012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4225
4226 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4227
cc0adcb0
CY
42282012-01-28 Chong Yidong <cyd@gnu.org>
4229
4230 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4231
acc28cb9
CY
42322012-01-26 Chong Yidong <cyd@gnu.org>
4233
9c69cfb7
CY
4234 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4235
acc28cb9
CY
4236 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4237 repeat counts (Bug#10507).
4238
48da7392
GM
42392012-01-26 Glenn Morris <rgm@gnu.org>
4240
4241 * lread.c (syms_of_lread): Doc fix.
4242
14af5f7f
CY
42432012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4244
4245 * coding.c (encode_designation_at_bol): Change return value to
4246 EMACS_INT.
4247
0b21c100
CY
42482012-01-25 Chong Yidong <cyd@gnu.org>
4249
4250 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4251
3c2907f7
CY
42522012-01-21 Chong Yidong <cyd@gnu.org>
4253
4254 * floatfns.c (Fcopysign): Make the second argument non-optional,
4255 since nil is not allowed anyway.
4256
959ad23f
AS
42572012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4258
4259 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4260 (send_process): Likewise.
4261
34a02f46
MR
42622012-01-19 Martin Rudalics <rudalics@gmx.at>
4263
4264 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4265 (Vwindow_persistent_parameters): Do not use Qstate.
4266 Rewrite doc-strings.
34a02f46 4267
1259009a 42682012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4269
4270 * character.c (char_width): New function.
70d4fdf6
GM
4271 (Fchar_width, c_string_width, lisp_string_width):
4272 Use char_width (Bug#9496).
25ed9e61 4273
6a6ee00d
MR
42742012-01-16 Martin Rudalics <rudalics@gmx.at>
4275
4276 * window.c (Vwindow_persistent_parameters): New variable.
4277 (Fset_window_configuration, save_window_save): Handle persistent
4278 window parameters.
4279
c85efaf7
EZ
42802012-01-14 Eli Zaretskii <eliz@gnu.org>
4281
4282 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4283 thrashing the stack of the thread. (Bug#9087)
4284
5944709e
PE
42852012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4286
4287 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4288
e71f5d99
EZ
42892012-01-11 Eli Zaretskii <eliz@gnu.org>
4290
4291 * xdisp.c (rows_from_pos_range): Handle the case where the
4292 highlight ends on a newline. (Bug#10464)
4293 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4294 he end column for display of highlight that ends on a newline
4295 before a R2L line.
4296
ce316182
GM
42972012-01-11 Glenn Morris <rgm@gnu.org>
4298
4299 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4300 from load-path also when installation-directory is nil. (Bug#10208)
4301
5b43da69
GM
43022012-01-10 Glenn Morris <rgm@gnu.org>
4303
74cc8ff9
GM
4304 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4305
7d8d6e4e
GM
4306 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4307 Update template values to be closer to their typical values these days.
5b43da69 4308
a0db8d43
EZ
43092012-01-09 Eli Zaretskii <eliz@gnu.org>
4310
4311 * xdisp.c (rows_from_pos_range): Accept additional argument
4312 DISP_STRING, and accept any glyph in a row whose object is that
4313 string as eligible for mouse highlight. Fixes mouse highlight of
4314 display strings from overlays. (Bug#10464)
4315
9a0115ab 43162012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4317
b9110d6a 4318 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4319 * fileio.c (auto_saving_dir_umask): New static var.
4320 (Fmake_directory_internal): Use it.
4321 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4322 creating the directory. The old code temporarily assigns
4323 too-generous permissions to the directory.
4324 (do_auto_save_eh): Clear it.
b9110d6a 4325 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4326 that the var is always cleared.
4327
6c1bd3f3
EZ
43282012-01-07 Eli Zaretskii <eliz@gnu.org>
4329
4330 * search.c (scan_buffer): Pass character positions to
4331 know_region_cache, not byte positions. (Bug#6540)
4332
069d2b50
L
43332012-01-07 LynX <_LynX@bk.ru> (tiny change)
4334
4335 * w32.c (sys_rename): Report EXDEV when rename of a directory
4336 fails because the target is on another logical disk. (Bug#10284)
4337
75bf0d33
DB
43382012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4339
4340 * xterm.c (x_embed_request_focus): New function.
4341
4342 * xterm.h: Add prototype.
4343
4344 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4345
1c6e5a32
GM
43462012-01-05 Glenn Morris <rgm@gnu.org>
4347
4348 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4349
651e947e
EZ
43502012-01-01 Eli Zaretskii <eliz@gnu.org>
4351
4352 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4353 Load gnutls_transport_set_lowat only if GnuTLS version is below
4354 2.11.1.
4355 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4356 GnuTLS versions below 2.11.1.
4357
3778cdd8
AL
43582011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4359
4360 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4361 to the doc string advising against its use for altering the way
4362 windows are scrolled.
4363
0e5317f7
KH
43642011-12-28 Kenichi Handa <handa@m17n.org>
4365
4366 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4367 coding-system ASCII compatible only when it does not produce BOM
4368 on encoding (Bug#10383).
4369
93d5ca1f
JD
43702011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4371
4372 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4373 can scroll.
4374 (create_and_show_popup_menu): Always use menu_position_func for
4375 Gtk3 (Bug#10361).
4376
ca22b785
AS
43772011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4378
4379 * callint.c (Fcall_interactively): Don't truncate prompt string.
4380
d048e1e6
EZ
43812011-12-23 Eli Zaretskii <eliz@gnu.org>
4382
4383 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4384 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4385 resumed from there (after widening). (Bug#10360)
d048e1e6 4386
5ccaba1f
JD
43872011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4388
4389 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4390
204ee57f
JD
43912011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4392
b81d40f0
JB
4393 * nsterm.m (x_free_frame_resources):
4394 Release f->output_data.ns->miniimage.
204ee57f
JD
4395 (ns_index_color): Fix indentation. Do not retain
4396 color_table->colors[i].
4397
4398 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4399 before returning.
4400
4401 * nsfns.m (x_set_background_color): Assign return value from
4402 ns_index_color to face-background instead of NSColor*.
4403 (ns_implicitly_set_icon_type): Fix indentation.
4404 Change assignment in for loop to comparison.
4405
4406 * emacs.c (ns_pool): New variable.
4407 (main): Assign ns_pool.
4408 (Fkill_emacs): Call ns_release_autorelease_pool.
4409
4410 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4411 autorelease fdesc, release fdAttrs and tdict.
4412 (ns_get_covering_families): Release charset.
4413 (ns_findfonts): Release NSFontDescriptor created with new.
4414 (ns_uni_to_glyphs): Fix indentation.
4415 (setString): Release attrStr before assigning new value.
4416
c803b2b7
JD
44172011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4418
678f4426
JD
4419 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4420 and NS_IMPL_COCOA.
4421 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4422 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4423
cd394be1 44242011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4425
5fecd5fc
JD
4426 * nsterm.m (ns_term_init): Subscribe for notifications
4427 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4428 to method trackingNotification in EmacsMenu.
4429
4430 * nsmenu.m (trackingMenu): New variable.
3771cb17 4431 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4432 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4433 from Aquamacs (Bug#7030).
678f4426
JD
4434
44352011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4436
c803b2b7
JD
4437 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4438 (symbol_to_nsstring): Fix indentation.
4439 (ns_symbol_to_pb): New function.
cae07000
SM
4440 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4441 (Fns_rotate_cut_buffers_internal): Remove.
4442 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4443 Fns_store_cut_buffer_internal.
4444 (ns_get_foreign_selection, Fx_own_selection_internal)
4445 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4446 (Fns_get_selection_internal, Fns_store_selection_internal):
4447 Use ns_symbol_to_pb and check if return value is nil.
4448 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4449 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4450 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4451 renamed to Sns_store_selection_internal.
4452 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4453 and remove this function.
4454 (ns_handle_selection_clear): Remove, never used.
4455 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4456 here.
4457
e1b01a3a
KB
44582011-12-17 Ken Brown <kbrown@cornell.edu>
4459
4460 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4461 GID is unknown (Bug#10257).
4462
2adb6e85
PE
44632011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4464
4465 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4466 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4467 which caused a build failure on GNU/Linux IA-64. This problem was
4468 introduced by my 2011-10-07 patch.
4469
d1d7b339
JL
44702011-12-15 Juri Linkov <juri@jurta.org>
4471
4472 * image.c (imagemagick_error): New function. (Bug#10112)
4473 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4474 Use `imagemagick_error' where ImageMagick functions return
4475 `MagickFalse'.
4476 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4477 proper order.
4478
100d5755
KH
44792011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4480
4481 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4482 fill background (Bug#8992).
4483
454592a6
MR
44842011-12-13 Martin Rudalics <rudalics@gmx.at>
4485
4486 * window.c (Vwindow_combination_resize)
4487 (Vwindow_combination_limit): Use t instead of non-nil in
4488 doc-strings.
61d4b438
MR
4489 (Vrecenter_redisplay): Add first sentence of doc-string on
4490 separate line.
53524d93 4491 (Frecenter): Fix doc-string typo.
454592a6 4492
3633e3aa
KH
44932011-12-11 Kenichi Handa <handa@m17n.org>
4494
4495 * coding.c (Funencodable_char_position): Pay attention to the
4496 buffer text relocation (Bug#9389).
4497
7b9d523a 44982011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4499
7b9d523a
JD
4500 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4501 gtk_init (Bug#10100).
4502
b73189c6
EZ
45032011-12-10 Eli Zaretskii <eliz@gnu.org>
4504
4505 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4506 IT->string is nil. (Bug#10263)
4507
f7dfe5d6
JD
45082011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4509
83faebb4
JD
4510 * nsterm.h (x_free_frame_resources): Declare.
4511
f7dfe5d6
JD
4512 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4513 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4514
4515 * nsterm.h (ns_get_defaults_value): Declare.
4516
4517 * nsterm.m (ns_default): Call ns_get_defaults_value.
4518
7cd4e72c
EZ
45192011-12-09 Eli Zaretskii <eliz@gnu.org>
4520
4521 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4522 (Bug#10170)
4523
b34d7317
YM
45242011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4525
4526 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4527 that where the value of an _OBJC_* symbol points to is in the .bss
4528 section (Bug#10240).
4529
76470ad1
KH
45302011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4531
4532 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4533 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4534
745fff94
KH
45352011-12-08 Kenichi Handa <handa@m17n.org>
4536
4537 * ftfont.c (get_adstyle_property): Fix previous change
4538 (Bug#10233).
4539
6e44397c
JB
45402011-12-07 Juanma Barranquero <lekktu@gmail.com>
4541
4542 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4543 dirs from the default value of EMACSLOADPATH (bug#10208).
4544
7efa6272
GM
45452011-12-07 Glenn Morris <rgm@gnu.org>
4546
4547 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4548 installation and source directories as well. (Bug#10208)
4549
f6fc4d87
CY
45502011-12-06 Chong Yidong <cyd@gnu.org>
4551
4552 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4553
2bf26180
GM
45542011-12-06 Glenn Morris <rgm@gnu.org>
4555
4556 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4557 as an error, not just -1. (Bug#10217)
4558
3a6ad4f0
CY
45592011-12-05 Chong Yidong <cyd@gnu.org>
4560
4561 * keyboard.c (process_special_events): New function.
4562 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4563
75a3b399
PE
45642011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4565
4566 * coding.c (encode_designation_at_bol): Don't use uninitialized
4567 local variable (Bug#9318).
4568
c3c9e25e
KH
45692011-12-05 Kenichi Handa <handa@m17n.org>
4570
4571 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4572 return Qnil (Bug#8046, Bug#10193).
4573
5eb05ea3
KH
45742011-12-05 Kenichi Handa <handa@m17n.org>
4575
4576 * coding.c (encode_designation_at_bol): New args charbuf_end and
4577 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4578 (coding_set_source): Return how many bytes coding->source was
4579 relocated.
4580 (coding_set_destination): Return how many bytes
4581 coding->destination was relocated.
4582 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4583 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4584
45852011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4586
4587 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4588 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4589 macro (Bug#9318).
4590
45912011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4592
4593 The following changes are to fix Bug#9318.
4594
a79703f5 4595 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4596 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4597 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4598 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4599
7dbda6df
JB
46002011-12-05 Juanma Barranquero <lekktu@gmail.com>
4601
4602 * lisp.h (process_quit_flag): Fix external declaration.
4603
6d5eb5b0
SM
46042011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4605
4606 Don't macro-inline non-performance-critical code.
4607 * eval.c (process_quit_flag): New function.
4608 * lisp.h (QUIT): Use it.
4609
a0c3fad0
JD
46102011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4611
4612 * nsfns.m (get_geometry_from_preferences): New function.
4613 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4614
6c07aac2
AS
46152011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4616
4617 * emacs.c (Qkill_emacs): Define.
4618 (syms_of_emacs): Initialize it.
4619 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4620 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4621 (quit_throw_to_read_char): Add parameter `from_signal'.
4622 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4623 * lisp.h (QUIT): Call Fkill_emacs if requested.
4624
c052ead4
JD
46252011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4626
4627 * widget.c (update_wm_hints): Return if wmshell is null.
4628 (widget_update_wm_size_hints): New function.
4629
4630 * widget.h (widget_update_wm_size_hints): Declare.
4631
4632 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4633 widget_update_wm_size_hints (Bug#10104).
4634
9e49252b
EZ
46352011-12-03 Eli Zaretskii <eliz@gnu.org>
4636
4637 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4638 before a newline, prepare the bidi iterator for consuming the
4639 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4640 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4641
02b16839
JL
46422011-12-02 Juri Linkov <juri@jurta.org>
4643
4644 * search.c (Fword_search_regexp): New Lisp function created from
4645 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4646 (Fword_search_backward, Fword_search_forward)
4647 (Fword_search_backward_lax, Fword_search_forward_lax):
4648 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4649 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4650
0068070e
SM
46512011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4652
4653 * fileio.c (Finsert_file_contents): Move after-change-function call
4654 to before the "handled:" label, since all "goto handled" appear in
4655 cases where the *-change-functions have already been properly called
4656 (bug#10117).
4657
3360a3fc
AS
46582011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4659
4660 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4661 waiting for input. (Bug#10169)
4662
73d6c093
EZ
46632011-11-30 Eli Zaretskii <eliz@gnu.org>
4664
4665 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4666 verifies glyph row's hash code--we have just reallocated the
4667 glyphs, so their contents can be complete garbage. (Bug#10164)
4668
febe6bea
JB
46692011-11-30 Juanma Barranquero <lekktu@gmail.com>
4670
4671 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4672
801a4313
EZ
46732011-11-30 Eli Zaretskii <eliz@gnu.org>
4674
4675 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4676 attributes are tested _before_ calling verify_row_hash, to protect
4677 against GCC re-ordering of the tests. (Bug#10164)
4678
2b56b87e
JD
46792011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4680
4681 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4682
4683 * xterm.c (handle_one_xevent): Only set async_visible and friends
4684 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4685 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4686 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4687
dbf31225
PE
46882011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4689
4690 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4691 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4692 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4693 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4694 All uses changed to use GCPRO1 etc.
4695 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4696 Revert to old implementation (i.e., before 2011-03-11).
4697
1305621b
YM
46982011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4699
4700 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4701 of scroll runs so as to avoid assigning disabled bogus rows and
4702 unnecessary graphics copy operations.
4703
8c9afb46
EZ
47042011-11-27 Eli Zaretskii <eliz@gnu.org>
4705
4706 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4707 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4708 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4709 (malloc, free, realloc, calloc): Redirect to e_* only when
4710 compiling Emacs.
4711
4712 * lisp.h (GCTYPEBITS): Move before first use.
4713 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4714 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4715 this macro definition.
4716
4717 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4718 _MSC_VER.
4719
54e9e3bf
JD
47202011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4721
6d5eb5b0
SM
4722 * gtkutil.c (xg_create_frame_widgets):
4723 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4724 present with Gtk+ 2.0.
4725
83aca1cb
PE
47262011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4727
4728 * fileio.c (Finsert_file_contents): Undo previous change; see
4729 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4730
5b76caa4
PE
47312011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4732
4733 Rename locals to avoid shadowing.
4734 * fileio.c (Finsert_file_contents):
4735 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4736 * process.c (wait_reading_process_output):
4737 Rename inner 'proc' to 'p' to avoid shadowing.
4738 Indent for consistency with usual Emacs style.
4739
8c535114
EZ
47402011-11-25 Eli Zaretskii <eliz@gnu.org>
4741
4742 * xdisp.c (redisplay_window): If cursor row is not fully visible
4743 after recentering, and scroll-conservatively is set to a large
4744 number, scroll window by a few more lines to make the cursor fully
4745 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4746 (start_display): Don't move to the next line if the display should
4747 start at a newline that is part of a display vector or an overlay
4748 string. (Bug#10119)
8c535114 4749
fa4fdb5c
JL
47502011-11-24 Juri Linkov <juri@jurta.org>
4751
4752 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4753 after the `MagickPingImage' call. (Bug#10112)
4754
90ec88df
CY
47552011-11-23 Chong Yidong <cyd@gnu.org>
4756
4757 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4758
56e2e794
MR
47592011-11-23 Martin Rudalics <rudalics@gmx.at>
4760
4761 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4762 making another buffer current. (Bug#10114)
4763
b6e64c41
GM
47642011-11-23 Glenn Morris <rgm@gnu.org>
4765
4766 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4767
6b21de18
CY
47682011-11-23 Chong Yidong <cyd@gnu.org>
4769
4770 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4771 using it (Bug#5984).
4772
b12cd789
EZ
47732011-11-22 Eli Zaretskii <eliz@gnu.org>
4774
4775 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4776 and header-lines, as they don't have one computed for them.
4777 (Bug#10098)
4778
4779 * .gdbinit (prow): Make displayed values more self-explaining.
4780 Add row's hash code.
4781
261b6fd4
LMI
47822011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4783
4784 * process.c (wait_reading_process_output): Fix asynchrounous
4785 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4786 (wait_reading_process_output): Add comment and URL.
261b6fd4 4787
e7cfd277
JD
47882011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4789
4790 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4791
a9b9b7f5
CY
47922011-11-21 Chong Yidong <cyd@gnu.org>
4793
4794 * window.c (Fnext_window, Fprevious_window): Doc fix.
4795
b0d15b4f
SM
47962011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4797
4798 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4799
fe7a3057
JB
48002011-11-20 Juanma Barranquero <lekktu@gmail.com>
4801
4802 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4803
d2999b1a
MR
48042011-11-20 Martin Rudalics <rudalics@gmx.at>
4805
4806 * window.c (Fset_window_combination_limit): Rename argument
4807 STATUS to LIMIT.
4808 (Vwindow_combination_limit): Remove "status" from doc-string.
4809
d5ff9cd0
AS
48102011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4811
4812 * m/ibms390.h: Remove.
4813 * m/ibms390x.h: Don't include "ibms390.h".
4814
a5bb9bd3
SM
48152011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4816
4817 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4818 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4819
cd1181db
JB
48202011-11-20 Juanma Barranquero <lekktu@gmail.com>
4821
4822 * casetab.c (Fset_case_table):
4823 * charset.c (Fcharset_after): Fix typos.
4824
615a3b8d 48252011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4826
17e845af
PE
4827 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4828 Otherwise, valgrind does not work on some platforms.
4829 Problem reported by Andreas Schwab in
6a0bf43d
PE
4830 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4831 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4832 is set, removing the need for VIRT_ADDRESS_VARIES.
4833 (PURE_P): Use a more-efficient implementation that needs just one
4834 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4835 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4836 to 4 (xorl, subq, cmpq, setbe).
4837 * alloc.c (pure): Always extern now, since that's the
4838 VIRT_ADDR_VARIES behavior.
4839 (PURE_POINTER_P): Use a single comparison, not two, for
4840 consistency with the new puresize.h.
4841 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4842 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4843 Remove VIRT_ADDR_VARIES no longer needed.
4844
f8fe6f96
EZ
48452011-11-19 Eli Zaretskii <eliz@gnu.org>
4846
4847 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4848 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4849 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4850 behave as if the cursor position were at the window margin.
4851
4852 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4853 and the cursor position is out of bounds, behave as if the cursor
4854 position were at the window margin. (Bug#10075)
4855
df05a53c
CY
48562011-11-18 Chong Yidong <cyd@gnu.org>
4857
4858 * window.c (Fwindow_combination_limit): Make first argument
4859 non-optional, since it is meaningless for live windows like the
4860 selected window.
61ccba97 4861
2071918e
DA
48622011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4863
4864 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4865
b50a28de
SM
48662011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4867
4868 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4869 (graft_intervals_into_buffer): Simplify.
4870
015137db
EZ
48712011-11-18 Eli Zaretskii <eliz@gnu.org>
4872
4873 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4874 hash values of the two rows.
4875 (copy_row_except_pointers): Preserve the used[] arrays and the
4876 hash values of the two rows. (Bug#10035)
68c95424 4877 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4878
4879 * xdisp.c (row_hash): New function, body extracted from
4880 compute_line_metrics.
4881 (compute_line_metrics): Call row_hash, instead of computing the
4882 hash code inline.
4883
4884 * dispnew.c (verify_row_hash): Call row_hash for computing the
4885 hash code of a row, instead of duplicating code from xdisp.c.
4886
4887 * dispextern.h (row_hash): Add prototype.
4888
a2addb04
TH
48892011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4890
4891 * frame.c (delete_frame): Don't delete the terminal when the last
4892 X frame is closed if emacs is built with GTK toolkit.
4893
df85d315
JB
48942011-11-17 Juanma Barranquero <lekktu@gmail.com>
4895
4896 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4897
a0c2d0ae
MR
48982011-11-17 Martin Rudalics <rudalics@gmx.at>
4899
4900 * window.c (Vwindow_splits): Rename to
4901 Vwindow_combination_resize. Suggested by Juri Linkov.
4902 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4903 of Vwindow_splits.
4904
58179cce
JB
49052011-11-16 Juanma Barranquero <lekktu@gmail.com>
4906
7877f373
JB
4907 * nsfns.m (Fns_font_name):
4908 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4909
b6f67890
MR
49102011-11-16 Martin Rudalics <rudalics@gmx.at>
4911
4912 * window.h (window): Rename slot "nest" to "combination_limit".
4913 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4914 (Fset_window_nest): Rename to Fset_window_combination_limit.
4915 (Vwindow_nest): Rename to Vwindow_combination_limit.
4916 (recombine_windows, make_parent_window, make_window)
4917 (Fsplit_window_internal, saved_window)
4918 (Fset_window_configuration, save_window_save): Rename all
4919 occurrences of window_nest to window_combination_limit.
4920
c7015153
JB
49212011-11-15 Juanma Barranquero <lekktu@gmail.com>
4922
4923 * image.c (imagemagick_load_image): Fix typo.
4924
322ad6ec
EZ
49252011-11-14 Eli Zaretskii <eliz@gnu.org>
4926
4927 * xdisp.c (display_line): Move the call to
4928 highlight_trailing_whitespace before the call to
4929 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4930 faces of all the glyphs to compute ROW's hash value.
4931 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4932
f067b8ec
JB
49332011-11-14 Juanma Barranquero <lekktu@gmail.com>
4934
4935 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4936 just return (bug#10044).
4937
1e5b2111
EZ
49382011-11-12 Eli Zaretskii <eliz@gnu.org>
4939
7ef3cbd5
EZ
4940 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4941 with user-defined heap size. Bump the default size of the temacs
4942 heap to 27MB, to avoid memory warning when running temacs.
4943 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4944
1e5b2111
EZ
4945 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4946 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4947 (verify_row_hash) [XASSERTS]: New function.
4948 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4949 that the hash value of glyph rows is correct.
1e5b2111 4950
89d61221
MR
49512011-11-12 Martin Rudalics <rudalics@gmx.at>
4952
4953 * window.h (window): Remove splits slot.
4954 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4955 (Fdelete_other_windows_internal, make_parent_window)
4956 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4957 (Fset_window_configuration, save_window_save): Don't deal with
4958 split status of windows.
4959 (saved_window): Remove splits slot.
4960 (Vwindow_splits): Rewrite doc-string.
4961
97f18cc8
JD
49622011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4963
4964 * xfns.c (unwind_create_frame):
4965 * nsfns.m (unwind_create_frame):
4966 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4967 Vframe_list (Bug#9999).
4968
22a648b4
DA
49692011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4970
0b381c7e 4971 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4972
659afede
KH
49732011-11-11 Kenichi Handa <handa@m17n.org>
4974
4975 * callproc.c (Fcall_process): Set the member dst_multibyte of
4976 process_coding.
4977
9ac0394b
KH
49782011-11-11 Johan Bockgård <bojohan@gnu.org>
4979
4980 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4981 avoid a crash (bug#9496).
4982
2fbdc249
CY
49832011-11-09 Chong Yidong <cyd@gnu.org>
4984
4985 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4986 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4987
ac6b1f81
PE
49882011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4989
4990 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4991
09db192c
PE
49922011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4993
4994 Avoid some portability problems by eschewing 'extern inline' functions.
4995 The trivial performance wins aren't worth the portability hassles; see
4996 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4997 et seq.
4998 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4999 (window_box_width, window_box_left, window_box_left_offset)
5000 (window_box_right, window_box_right_offset): Undo previous change,
5001 by removing the "extern"s.
5002 * intervals.c (adjust_intervals_for_insertion)
5003 (adjust_intervals_for_deletion): Undo previous change,
5004 making these static again.
5005 (offset_intervals, temp_set_point_both, temp_set_point)
5006 (copy_intervals_to_string): No longer inline.
5007 * xdisp.c (window_text_bottom_y, window_box_width)
5008 (window_box_height, window_box_left_offset)
5009 (window_box_right_offset, window_box_left, window_box_right)
5010 (window_box): No longer inline.
5011
105216ed
CY
50122011-11-08 Chong Yidong <cyd@gnu.org>
5013
5014 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5015 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5016 Signal an error if not a live window.
105216ed
CY
5017 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5018 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5019
ae9e237f
JB
50202011-11-07 Juanma Barranquero <lekktu@gmail.com>
5021
5022 * lisp.h (syms_of_abbrev): Remove declaration.
5023 Reported by CHENG Gao <chenggao@royau.me>.
5024
c7aa8333
EZ
50252011-11-07 Eli Zaretskii <eliz@gnu.org>
5026
5027 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5028 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5029 of temacs in GUI mode.
5030
be7f5545
MR
50312011-11-07 Martin Rudalics <rudalics@gmx.at>
5032
5033 * window.h: Declare delete_all_child_windows instead of
5034 delete_all_subwindows.
5035 * window.c (Fwindow_nest, Fset_window_nest)
5036 (Fset_window_new_total, Fset_window_new_normal)
5037 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5038 (delete_all_subwindows): Rename to delete_all_child_windows.
5039 (Fdelete_other_windows_internal, Fset_window_configuration):
5040 Call delete_all_child_windows instead of delete_all_subwindows.
5041 * frame.c (delete_frame): Call delete_all_child_windows instead
5042 of delete_all_subwindows.
5043
ca78dc43
PE
50442011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5045
5046 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5047 This is also needed for porting to any host where GC_MARK_STACK is
5048 not GC_MAKE_GCPROS_NOOPS.
5049 (which_symbols): Use it.
5050
a0241d01
KH
50512011-11-07 Kenichi Handa <handa@m17n.org>
5052
5053 * coding.c (coding_set_destination): Check coding->src_pos only
5054 when coding->src_object is a buffer (bug#9910).
5055
5056 * process.c (send_process): Set the member src_multibyte of coding
5057 to 0 (bug#9911) when sending a unibyte text.
5058
5059 * callproc.c (Fcall_process): Set the member src_multibyte of
5060 process_coding to 0 (bug#9912).
5061
a64bfdfa 50622011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5063
5064 * xmenu.c (cleanup_widget_value_tree): New function.
5065 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5066 calling free_menubar_widget_value_tree directly (Bug#9830).
5067
cb41b32a
PE
50682011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5069
5070 Fix some portability problems with 'inline'.
5071 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5072 (window_box_width, window_box_left, window_box_left_offset)
5073 (window_box_right, window_box_right_offset): Declare extern.
5074 Otherwise, these inline functions do not conform to C99 and
5075 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5076 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5077 * intervals.c (adjust_intervals_for_insertion)
5078 (adjust_intervals_for_deletion): Now extern, because otherwise the
5079 extern inline functions 'offset_intervals' couldn't refer to it.
5080 (static_offset_intervals): Remove.
5081 (offset_intervals): Rewrite using the old contents of
5082 static_offset_intervals. The old version didn't conform to C99
5083 because an extern inline function contained a reference to an
5084 identifier with static linkage.
5085
b7041366
AS
50862011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5087
5088 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5089 GC.
5090
88a37c4d
EZ
50912011-11-06 Eli Zaretskii <eliz@gnu.org>
5092
5093 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5094 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5095 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5096 return Qleft_to_right.
5097
49745b39
CY
50982011-11-06 Chong Yidong <cyd@gnu.org>
5099
5100 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5101 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5102 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5103 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5104 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5105 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5106 (Fwindow_vscroll): Doc fix.
5107 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5108 argument, since it makes no sense to pass a live window and for
5109 consistency with window-child.
5110
1f05cd82
CS
51112011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5112
5113 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5114 support MSVC.
5115
22610910
JR
51162011-11-05 Jason Rumney <jasonr@gnu.org>
5117
5118 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5119 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5120 fonts (Bug#6029).
5121 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5122 bitwise arithmetic preventing use of unicode-sip and non-truetype
5123 opentype fonts.
5124
a06776b2
EZ
51252011-11-05 Eli Zaretskii <eliz@gnu.org>
5126
3ad924ba
EZ
5127 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5128 "emacs"-only part.
5129
a06776b2
EZ
5130 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5131 initialization code to keep similarity to xfns.c after changes
5132 from 2011-11-05.
5133
c9e7db78
JD
51342011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5135
a97f8f3f
JD
5136 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5137 (unwind_create_frame): New function (Bug#9943).
5138 (Fx_create_frame): Restructure code to be more similar to the one in
5139 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5140 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5141 Move terminal->reference_count++ just before making the frame official
5142 (Bug#9943).
5143
5144 * nsterm.m (x_free_frame_resources): New function.
5145 (x_destroy_window): Move code to x_free_frame_resources.
5146
c9e7db78 5147 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5148 (Fx_create_frame, x_create_tip_frame):
5149 Move terminal->reference_count++ just before making the frame
75f1671a 5150 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5151 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5152
a6fc3b5c
EZ
51532011-11-05 Eli Zaretskii <eliz@gnu.org>
5154
5155 Support MSVC build with newer versions of Visual Studio.
5156 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5157 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5158 nt/gmake.defs.
5159
5160 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5161 which are not supported by MSVC.
5162 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5163 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5164 bitfields.
5165 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5166 types in bitfields.
5167 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5168
5169 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5170
58179cce 51712011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5172
5173 Support MSVC build with newer versions of Visual Studio.
5174 * w32.c: Don't include w32api.h for MSVC.
5175 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5176
5177 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5178 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5179 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5180 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5181 e_* cousins.
5182 (alloca) [_MSC_VER]: Define to _alloca.
5183
5184 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5185
5186 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5187
a58c13ed
EZ
51882011-11-04 Eli Zaretskii <eliz@gnu.org>
5189
5190 * xdisp.c (note_mouse_highlight): If either of
5191 previous/next-single-property-change returns nil, treat that as
5192 the beginning or the end of the buffer. (Bug#9955)
5193
fe0b6370
JD
51942011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5195
a58c13ed 5196 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5197 label is not null (Bug#9951).
5198 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5199 may be NULL.
5200
89bd5ee1
EZ
52012011-11-04 Eli Zaretskii <eliz@gnu.org>
5202
5203 * window.c (Fwindow_body_size): Mention in the doc string that the
5204 return value is in frame's canonical units. (Bug#9949)
5205
84c3edb9
EZ
52062011-11-03 Eli Zaretskii <eliz@gnu.org>
5207
4e2fb5c7
EZ
5208 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5209
84c3edb9 5210 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5211 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5212 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5213
bc17a887
EZ
52142011-11-01 Eli Zaretskii <eliz@gnu.org>
5215
5216 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5217 Don't stop backward scan on the continuation glyph, even though
5218 its CHARPOS is positive.
6d5eb5b0
SM
5219 (mouse_face_from_buffer_pos, note_mouse_highlight):
5220 Rename cover_string to disp_string.
bc17a887 5221
4ee88440
MR
52222011-11-01 Martin Rudalics <rudalics@gmx.at>
5223
5224 * window.c (temp_output_buffer_show): Don't use
5225 Vtemp_buffer_show_specifiers.
5226 (Vtemp_buffer_show_specifiers): Remove unused variable.
5227
c2ff3c02
EZ
52282011-10-30 Eli Zaretskii <eliz@gnu.org>
5229
5230 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5231 past the beginning of the current glyph matrix.
5232
58179cce 52332011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5234
5235 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5236 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5237 HAVE_GTK3 (Bug#9869).
b77a6a7f 5238
3b574623
JD
5239 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5240 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5241
b77a6a7f
JD
5242 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5243
5244 * xterm.c: Declare x_handle_net_wm_state to return int.
5245 (handle_one_xevent): Check if we are iconified but don't have
5246 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5247 (get_current_wm_state): Return non-zero if not hidden,
5248 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5249 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5250 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5251 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5252
196e41e4
PE
52532011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5254
5255 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5256 so that this new function doesn't get optimized away by a
5257 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5258
021f2e1a
AS
52592011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5260
5261 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5262
8b058d44
EZ
52632011-10-29 Eli Zaretskii <eliz@gnu.org>
5264
5265 Fix the `xbytecode' command.
5266 * .gdbinit (xprintbytestr): New command.
b50a28de 5267 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5268 (xbytecode): Print the byte-code string as well.
5269
4452fb80
EZ
52702011-10-29 Kim Storm <storm@cua.dk>
5271
8b058d44
EZ
5272 * alloc.c (which_symbols): New function.
5273
21b72067
AS
52742011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5275
5276 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5277 line. (Bug#9903)
5278
83ed7b5c
GM
52792011-10-29 Glenn Morris <rgm@gnu.org>
5280
5281 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5282 Not clear what it was for, and it causes various bugs. (Bug#9839)
5283
5a7a728b
EZ
52842011-10-28 Eli Zaretskii <eliz@gnu.org>
5285
5286 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5287 possible random value that matches one of those tested as
5288 condition to clear the mouse face.
5289
d3d0842f
CY
52902011-10-28 Chong Yidong <cyd@gnu.org>
5291
5292 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5293
31b39d13
DN
52942011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5295
5296 * window.c (make_window): Initialize phys_cursor_on_p.
5297
9aba6043
SM
52982011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5299
5300 * lisp.h (struct Lisp_Symbol): Update comments.
5301
c20992f4
JB
53022011-10-28 Juanma Barranquero <lekktu@gmail.com>
5303
5304 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5305
db4f02f2
EZ
53062011-10-28 Eli Zaretskii <eliz@gnu.org>
5307
5308 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5309 <oslsachem@gmail.com> for helping to debug this.
5310
5311 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5312 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5313 (g_b_init_get_glyph_outline_w): New static variables.
5314 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5315 (GetGlyphOutlineW_Proc): New typedefs.
5316 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5317 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5318 New functions.
5319 (w32font_open_internal, compute_metrics):
5320 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5321 instead of calling the "wide" APIs directly.
5322
5323 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5324
5325 * w32.h (syms_of_w32font): Add prototype.
5326
87e68db4
JB
53272011-10-27 Juanma Barranquero <lekktu@gmail.com>
5328
5329 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5330 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5331 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5332 (Fmove_to_window_line): Doc fix.
5333
435c1d67
CY
53342011-10-27 Chong Yidong <cyd@gnu.org>
5335
5336 * process.c (make_process): Set gnutls_state to NULL.
5337
5338 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5339 non-NULL, regardless of GNUTLS_INITSTAGE.
5340 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5341 an error. Set process slots as soon as we allocate them.
5342
5343 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5344
9c6c6f49
CY
53452011-10-27 Chong Yidong <cyd@gnu.org>
5346
9aba6043
SM
5347 * gnutls.c (emacs_gnutls_deinit): New function.
5348 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5349 (Fgnutls_deinit, Fgnutls_boot): Use it.
5350
5351 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5352 (deactivate_process): Call emacs_gnutls_deinit.
5353
657d08d3
JB
53542011-10-27 Juanma Barranquero <lekktu@gmail.com>
5355
5356 * image.c (x_create_x_image_and_pixmap):
5357 * w32.c (sys_rename, w32_delayed_load):
5358 * w32font.c (fill_in_logfont):
5359 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5360
5430d399
JB
53612011-10-26 Juanma Barranquero <lekktu@gmail.com>
5362
5363 * w32fns.c (w32_default_color_map): New function,
5364 extracted from Fw32_default_color_map.
a7ef684b 5365 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5366
fe0055fa
PE
53672011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5368
5369 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5370
e6346438
SM
53712011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5372
5373 * keyboard.c (test_undefined): New function (bug#9751).
5374 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5375
e112cc37
ET
53762011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5377
5378 * sysdep.c (init_sys_modes): Fix the check for the controlling
5379 terminal (Bug#6649).
5380
7b5d6677
EZ
53812011-10-20 Eli Zaretskii <eliz@gnu.org>
5382
5383 * dispextern.h (struct bidi_it): New member next_en_type.
5384
5385 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5386 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5387 current character, check also for next_en_type being WEAK_EN.
5388 (bidi_resolve_weak): Don't enter the expensive loop if the current
5389 position is before next_en_pos. Record the bidi type of the first
5390 non-ET, non-BN character we find, in addition to its position.
5391 (bidi_level_of_next_char): Invalidate next_en_type when
5392 next_en_pos is over-stepped.
5393
7da0b018
PE
53942011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5395
5396 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5397 * editfns.c: Rewrite current-time-zone so that it invokes
5398 the equivalent of (format-time-string "%Z") to get the time zone name.
5399 This fixes a bug when the time zone name contains characters that
5400 need converting from the system time locale to Emacs internal format.
5401 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5402 that patch fixed format-time-string to do the conversion, but
5403 I forgot to fix current-time-zone.
5404 (format_time_string): New function, containing most of
5405 what Fformat_time_string used to contain.
5406 (Fformat_time_string): Rewrite in terms of format_time_string.
5407 This doesn't change this function's behavior.
5408 (current-time-zone): Rewrite to use format_time_string.
5409 This fixes the bug reported by Michael Schierl in
5410 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5411 Jason Rumney's 2007-06-07 change worked around this bug, but
5412 didn't fix it.
5413 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5414
8547b010
EZ
54152011-10-19 Eli Zaretskii <eliz@gnu.org>
5416
5417 * xdisp.c (start_display): If the character at POS is displayed
5418 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5419 (try_window_reusing_current_matrix): If a line ends in a display
5420 vector or the next line starts in a display vector, continue
5421 redrawing the window even though the character position of
5422 start_row was reached.
8547b010
EZ
5423 (Bug#9771, part 2)
5424
4e948d15
CY
54252011-10-18 Chong Yidong <cyd@gnu.org>
5426
5427 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5428 with nobreak-char-display too.
5429
4787455f
EZ
54302011-10-18 Eli Zaretskii <eliz@gnu.org>
5431
5432 Fix part 3 of bug#9771.
5433 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5434 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5435 non-neutral characters if the current character is a paragraph
5436 separator (a.k.a. Newline). This avoids running the same
5437 expensive loop twice, once when we consume the preceding newline
5438 and the other time when the line actually needs to be displayed.
5439 Avoid the loop when we see neutrals on the base embedding level
5440 following a character whose directionality is the same as the
5441 paragraph's. This avoids running the expensive loop when a line
5442 ends in a long sequence of neutrals, like control characters.
5443 Add assertion against STRONG_AL type. Slightly rearrange code
5444 that determines the type of a neutral given the first non-neutral
5445 that follows it.
5446 (bidi_level_of_next_char): Set next_en_pos to zero when
5447 invalidating its info.
5448
2c91f553
EZ
54492011-10-17 Eli Zaretskii <eliz@gnu.org>
5450
5451 * xdisp.c (push_display_prop): Determine whether to record string
5452 or buffer position by IT->string, not by IT->method. Allow
5453 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5454 (move_it_vertically_backward): Don't look for character position
5455 immediately after the newline when in a continuation line.
5456 (Bug#9771, part 1)
2c91f553 5457
c7b08b0d
MR
54582011-10-15 Martin Rudalics <rudalics@gmx.at>
5459
5460 * window.c (coordinates_in_window): Rewrite and delabelize
5461 vertical border check. (Bug#5357) (Bug#9618)
5462
6b02f655
SM
54632011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5464
5465 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5466 errors in XSetWindowBorder (bug#9310).
5467
81d40c92
DA
54682011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5469
5470 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5471 avoid crash when xmalloc overrun checking is enabled.
5472
d4172c3b
EZ
54732011-10-13 Eli Zaretskii <eliz@gnu.org>
5474
5475 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5476 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5477 cursor motion with <left> and <right> arrow keys.
5478
5479 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5480 some callers set that themselves.
5481
b00eea75
EZ
54822011-10-12 Eli Zaretskii <eliz@gnu.org>
5483
5484 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5485 display string and the previous row comes from the same string and
5486 is empty. (Bug#9739) (Bug#9738)
5487
8fe012c4
SM
54882011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5489
5490 * doc.c (get_doc_string): Encode file name (bug#9735).
5491
0074aef2
EZ
54922011-10-12 Eli Zaretskii <eliz@gnu.org>
5493
79beb178
EZ
5494 * bidi.c (bidi_level_of_next_char):
5495 * xdisp.c (get_visually_first_element): Remove old incorrect
5496 comments regarding the Unicode Line Separator character.
5497
0074aef2
EZ
5498 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5499
6e4b3fbe
DA
55002011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5501
5502 * alloc.c (Fgc_status): Do not access beyond zombies array
5503 boundary if nzombies > MAX_ZOMBIES.
5504 * alloc.c (dump_zombies): Add missing format specifier.
5505
0324f3af
PE
55062011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5507
b5525cac
PE
5508 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5509 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5510
0324f3af
PE
5511 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5512 Some packages use them to denote characters with modifiers.
5513
e9b5f888
AS
55142011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5515
5516 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5517 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5518 matching a pp-number. Rename parameter var to var1.
5519
127827c0
SM
55202011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5521
5522 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5523
c8fd3bd0
GM
55242011-10-08 Glenn Morris <rgm@gnu.org>
5525
5526 * callint.c (Fcall_interactively): Give a more explicit error for the
5527 'c' case with a non-character input. (Bug#8479)
5528
352ec8ff
EZ
55292011-10-08 Eli Zaretskii <eliz@gnu.org>
5530
03669ccb
EZ
5531 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5532 lines.
7061c986
EZ
5533 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5534 lines that are hscrolled on the left.
03669ccb 5535
352ec8ff
EZ
5536 * dispnew.c (buffer_posn_from_coords): Account for a possible
5537 presence of header-line. (Bug#4426)
5538
a66cfb1c
SM
55392011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5540
6b02f655
SM
5541 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5542 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5543
7c5ee88e
PE
55442011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5545
5546 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5547 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5548 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5549 this makes Emacs dump core during garbage collection on rare
5550 occasions. sizeof is obviously inferior to offsetof here, so
5551 stick with offsetof.
5552 (GC_POINTER_ALIGNMENT): New macro.
5553 (mark_memory): Omit 3rd (offset) arg; caller changed.
5554 Don't assume EMACS_INT alignment is the same as pointer alignment.
5555
df1bbe5b
SM
55562011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5557
5558 * keyboard.c (read_key_sequence_remapped): New var.
5559 (read_key_sequence): Compute remapping in the right buffer.
5560 (command_loop_1): Use read_key_sequence's remapping directly.
5561
51553db6
SM
55622011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5563
32c1fffd
SM
5564 * dired.c (file_name_completion): Don't expand file name.
5565 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5566 before checking file name handler.
5567
51553db6
SM
5568 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5569 they've been requested explicitly (bug#9591).
5570
b6bd1599 55712011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5572
5573 * keymap.c (Fsingle_key_description): Use make_specified_string
5574 instead of build_string to build string from push_key_description.
5575 (Bug#5193)
5576
f701dc2a
PE
55772011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5578
4222c55d
PE
5579 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5580 This fixes a Y2038 bug on 64-bit hosts.
5581 * buffer.c (reset_buffer):
5582 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5583 (Fclear_buffer_auto_save_failure):
5584 Use 0, not -1, to represent an unset failure time, since time_t
5585 might not be signed.
5586
f701dc2a
PE
5587 Remove dependency on glibc malloc internals.
5588 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5589 Move back here from lisp.h, but with their new implementations.
5590 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5591 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5592 * charset.c (charset_table_init): New static var.
5593 (syms_of_charset): Use it instead of xmalloc. This removes a
5594 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5595 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5596 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5597 Move back to alloc.c.
5598 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5599 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5600
9ceebf39
JD
56012011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5602
5603 * nsterm.m (windowDidResize): Call x_set_window_size only when
5604 ns_in_resize is true. Otherwise set pixelwidth/height and
5605 call change_frame_size (Bug#9628).
5606
cb993c58
PE
56072011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5608
3930c88b
PE
5609 Port --enable-checking=all to Fedora 14 x86-64.
5610 * charset.c (syms_of_charset): Also account for glibc malloc's
5611 internal overhead when calculating the initial malloc maximum.
5612
cb993c58
PE
5613 Port --enable-checking=all to Fedora 14 x86.
5614 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5615 Move to lisp.h.
5616 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5617 (overrun_check_realloc, overrun_check_free):
5618 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5619 That way, xmalloc returns a properly-aligned pointer even if
5620 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5621 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5622 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5623 into account when calculating the initial malloc maximum.
5624 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5625 Move here from alloc.c, so that charset.c can use it too.
5626 Properly align; the old code wasn't right for common 32-bit hosts
5627 when configured with --enable-checking=all.
5628 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5629 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5630
31bed486
EZ
56312011-09-29 Eli Zaretskii <eliz@gnu.org>
5632
04c70788 5633 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5634 use EDOM.
5635
fbcaa2f3
EZ
56362011-09-28 Eli Zaretskii <eliz@gnu.org>
5637
5638 * xdisp.c (compute_display_string_end): If there's no display
5639 string at CHARPOS, return -1.
5640
5641 * bidi.c (bidi_fetch_char): When compute_display_string_end
5642 returns a negative value, treat the character as a normal
5643 character not covered by a display string. (Bug#9624)
5644
a239d4e9
JB
56452011-09-28 Juanma Barranquero <lekktu@gmail.com>
5646
5647 * lread.c (Fread_from_string): Fix typo in docstring.
5648
88652fd5
EZ
56492011-09-27 Eli Zaretskii <eliz@gnu.org>
5650
5651 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5652 newline, reseat the iterator instead of bidi-iterating there one
5653 character at a time. (Bug#9610)
32c1fffd
SM
5654 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5655 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5656
ed497dd4
AS
56572011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5658
5659 * lread.c (readevalloop): Use correct code for NBSP.
5660 (read1): Likewise. (Bug#9608)
5661
b2bf61aa
MA
56622011-09-25 Michael Albinus <michael.albinus@gmx.de>
5663
5664 * dbusbind.c (Fdbus_register_signal): When service is not
5665 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5666
32bbb17c
GM
56672011-09-25 Glenn Morris <rgm@gnu.org>
5668
5669 * buffer.c (truncate-lines): Doc fix.
5670
94e0933e
CY
56712011-09-24 Chong Yidong <cyd@stupidchicken.com>
5672
5673 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5674 (Fset_window_next_buffers): Doc fix.
5675
cddde921
GM
56762011-09-24 Glenn Morris <rgm@gnu.org>
5677
5678 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5679
1260aef1
PE
56802011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5681
25b4bfa0
PE
5682 Fix minor problems found by static checking.
5683 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5684 * indent.c (Fvertical_motion): Fix == vs = typo.
5685
e3cbd34b
EZ
56862011-09-24 Eli Zaretskii <eliz@gnu.org>
5687
a66cfb1c
SM
5688 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5689 Default value is now t. Doc fix.
6bf7006f 5690
e3cbd34b 5691 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5692 logic when moving up, not only when moving down. Fix the
e3cbd34b 5693 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5694 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5695
5696 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5697 CHARPOS is covered by a display string which includes newlines.
5698 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5699 is covered by a display string with embedded newlines.
5700
a3de0cbd
MA
57012011-09-24 Michael Albinus <michael.albinus@gmx.de>
5702
5703 * dbusbind.c (Fdbus_register_signal): Add match rule to
5704 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5705 (Fdbus_register_method, Vdbus_registered_objects_table):
5706 Fix docstring.
a3de0cbd 5707
b260039d
JM
57082011-09-24 Jim Meyering <meyering@redhat.com>
5709
32c1fffd 5710 do not ignore write error for any output size
b260039d
JM
5711 The previous change was incomplete.
5712 While it makes emacs --batch detect the vast majority of stdout
5713 write failures, errors were still ignored whenever the output size is
5714 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5715 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5716 && echo FAIL: ignored write error
5717 FAIL: ignored write error
5718 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5719 && echo FAIL: ignored write error
5720 FAIL: ignored write error
5721 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5722
8eca8a7c
AS
57232011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5724
5725 * emacs.c (Fkill_emacs): In noninteractive mode exit
5726 non-successfully if a write error occurred on stdout. (Bug#9574)
5727
3341db62
EZ
57282011-09-21 Eli Zaretskii <eliz@gnu.org>
5729
5730 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5731 the xassert test.
5732
5733 * dispextern.h (struct it): Update the comment documenting what
5734 can it->OBJECT be.
5735
8c203dbf
EZ
57362011-09-20 Eli Zaretskii <eliz@gnu.org>
5737
5738 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5739 a display string, extend search for cursor position to end of row.
5740 (find_row_edges): If the row ends in a newline from a display
5741 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5742 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5743 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5744 non-empty line. Fixes confusing cursor motion with arrow keys at
5745 the beginning of a line that starts with whitespace.
8c203dbf 5746
a4824228
LMI
57472011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5748
5749 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5750 (bug#9493).
5751
33ed493b
CY
57522011-09-18 Chong Yidong <cyd@stupidchicken.com>
5753
5754 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5755 boolean (Bug#9154).
5756
56cd55c8
EZ
57572011-09-18 Eli Zaretskii <eliz@gnu.org>
5758
5759 * xdisp.c (display_line): Record maximum and minimum buffer
5760 positions even if no glyphs were produced (e.g., by a zero-width
5761 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5762 buffer positions that will be removed from the glyph row because
5763 they don't fit.
c02dcedf
EZ
5764 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5765 column is beyond frame width: don't subtract 1 "pixel" when
5766 computing width of the stretch.
3e62b7e0
EZ
5767 (reseat_at_next_visible_line_start): Undo the change made on
5768 2011-09-17 that saved paragraph information and restored it after
5769 the call to `reseat'. (Bug#9545)
56cd55c8 5770
5ed99d36 57712011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5772
5773 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5774 and turn window cursor on if cleared (Bug#9415).
5775
5ed99d36 57762011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5777
5778 * search.c (boyer_moore): Take unibyte characters from pattern
5779 literally. (Bug#9458)
5780
9bade7b2
EZ
57812011-09-18 Eli Zaretskii <eliz@gnu.org>
5782
5783 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5784
e5e9d610
PE
57852011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5786
87e4427a
PE
5787 Fix minor problem found by static checking.
5788 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5789 initialized, to pacify gcc -Wuninitialized.
5790
e5e9d610
PE
5791 * fileio.c: Report proper errno when syscall falls.
5792 (Finsert_file_contents): Save and restore errno,
5793 so that report_file_error outputs the correct diagnostic.
5794 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5795
a1674f0b
EZ
57962011-09-18 Eli Zaretskii <eliz@gnu.org>
5797
5798 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5799
fbfb6dd4
EZ
58002011-09-17 Eli Zaretskii <eliz@gnu.org>
5801
5802 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5803 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5804
bb187662
EZ
58052011-09-17 Eli Zaretskii <eliz@gnu.org>
5806
1137e8b8 5807 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5808 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5809
5810 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5811 (bidi_find_paragraph_start): Search back for paragraph beginning
5812 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5813 (bidi_move_to_visually_next): Only trigger paragraph-related
5814 computations when the last character is a newline or at EOB, not
5815 just any NEUTRAL_B. (Bug#9470)
5816
bb187662
EZ
5817 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5818 truncated lines if point is covered by a display string. (Bug#9524)
5819
2e621251
PE
58202011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5821
5822 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5823 (cons_to_x_long): New function.
5824 (lisp_data_to_selection_data): Use it. Correct the test for
5825 short-versus-long data; it was negated. Break out of vector
5826 loop, for efficiency, when a long datum is discovered.
5827
91a15bc6
SM
58282011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5829
5830 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5831
b41c3a35
EZ
58322011-09-16 Eli Zaretskii <eliz@gnu.org>
5833
5834 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5835 GCC PR/17406) by declaring this function with external scope.
5836
7812ba2d
PE
58372011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5838
5839 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5840 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5841
cf7edc2a
AS
58422011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5843
5844 * editfns.c (Fformat): Correctly handle text properties on "%%".
5845
bd01620e
EZ
58462011-09-15 Eli Zaretskii <eliz@gnu.org>
5847
5848 * xterm.c (x_draw_composite_glyph_string_foreground):
5849 * w32term.c (x_draw_composite_glyph_string_foreground):
5850 * term.c (encode_terminal_code):
5851 * composite.c (composition_update_it, get_composition_id):
5852 * xdisp.c (get_next_display_element)
5853 (fill_composite_glyph_string): Add comments about special meaning
5854 of TAB characters in a composition.
5855
a02719a3
PE
58562011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5857
5858 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5859 This occurs when processing a multibyte format.
5860 Problem reported by Wolfgang Jenker.
a02719a3 5861
72589a3c
JB
58622011-09-15 Johan Bockgård <bojohan@gnu.org>
5863
5864 * xdisp.c (try_cursor_movement): Only check for exact match if
5865 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5866
1c14176c
PE
58672011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5868
5869 Remove unused external symbols.
5870 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5871 * xdisp.c (calc_pixel_width_or_height): Now static.
5872 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5873 * indent.c (check_display_width):
5874 * w32term.c: Fix comment to match code.
5875 * xterm.c, xterm.h (x_catching_errors): Remove.
5876
d2eea5b5
PE
58772011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5878
5879 * xselect.c: Use signed conversions more consistently (Bug#9498).
5880 (selection_data_to_lisp_data): Assume incoming selection data are
5881 signed integers, not unsigned. This is to be consistent with
5882 outgoing selection data, which was modified to use signed integers
5883 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5884 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5885 expects long, not unsigned long.
5886
46888499
EZ
58872011-09-14 Eli Zaretskii <eliz@gnu.org>
5888
5889 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5890 computation of loop end. Reported by Johan Bockgård
5891 <bojohan@gnu.org>.
5892
ef8ef9fb
CY
58932011-09-13 Chong Yidong <cyd@stupidchicken.com>
5894
5895 * frame.c (Fother_visible_frames_p): Function deleted.
5896
fa819fed
EZ
58972011-09-12 Eli Zaretskii <eliz@gnu.org>
5898
5899 * indent.c (compute_motion): Process display vector front to back
5900 rather than the other way around. (Bug#2496)
5901
2ba8e008
SM
59022011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5903
5904 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5905
20f53c69
CY
59062011-09-11 Chong Yidong <cyd@stupidchicken.com>
5907
5908 * minibuf.c (Fread_from_minibuffer): Doc fix.
5909
d562d7a4
EZ
59102011-09-11 Eli Zaretskii <eliz@gnu.org>
5911
5912 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5913 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5914
1c4d7f3d
LMI
59152011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5916
5917 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5918 value for non-existent files.
5919
b885bf36
EZ
59202011-09-11 Eli Zaretskii <eliz@gnu.org>
5921
5922 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5923 set its "size" to -1. This will set the modtime_size field of
5924 the corresponding buffer to -1, which is what
5925 verify-visited-file-modtime expects for files that do not exist.
5926 (Bug#9139)
5927
6612f0bf
PE
59282011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5929
5930 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5931 here ...
5932 * lisp.h: ... from here. push_key_description is no longer
5933 defined in keyboard.c, so its declaration should not be in
5934 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5935 logically belongs with push_key_description.
5936
dfb3f755
PE
59372011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5938
5939 * buffer.h: Include <sys/types.h> instead of <time.h>.
5940 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5941 Problem reported by Herbert J. Skuhra.
5942
3134906c
LMI
59432011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5944
5945 * xml.c (parse_region): Make the parsing work for
5946 non-comment-starting XML files again (bug#9144).
5947
8d903f4e
AS
59482011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5949
5950 * image.c (gif_load): Fix calculation of bottom and right corner.
5951 (Bug#9468)
5952
80ad64f4
EZ
59532011-09-10 Eli Zaretskii <eliz@gnu.org>
5954
5955 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5956 redisplay in small windows.
5957
208a048d
EZ
59582011-09-09 Eli Zaretskii <eliz@gnu.org>
5959
5960 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5961
9b1c252e
MR
59622011-09-08 Martin Rudalics <rudalics@gmx.at>
5963
5964 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5965 Operate on live windows only.
5966
2949f33b
JB
59672011-09-08 Juanma Barranquero <lekktu@gmail.com>
5968
5969 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5970
e08dcafd
EZ
59712011-09-07 Eli Zaretskii <eliz@gnu.org>
5972
5973 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5974 only under bidi iteration.
5975
115b96bd
JD
59762011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5977
5978 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5979
c8199d0f
PE
59802011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5981
5982 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5983 Without this fix, the command to link temacs failed due to an
5984 undefined symbol __builtin_isnan. This is because
5985 /usr/include/iso/math_c99.h #defines isnan(x) to
5986 __builtin_isnan(x), but the bundled gcc, which identifies itself
5987 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5988 a __builtin_isnan.
5989 * floatfns.c (isnan): #undef, and then #define to a clone of
5990 what's in data.c.
5991 (Fisnan): Always define, since it's always available now.
5992 (syms_of_floatfns): Always define isnan at the Lisp level.
5993
e39b275c 59942011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5995
5996 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5997
b2db44d9 59982011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5999
f4af5137 6000 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6001 The previous code assumed that file offsets (off_t values) fit in
6002 EMACS_INT variables, which is not true on typical 32-bit hosts.
6003 The code messed up by falsely reporting buffer overflow in cases
6004 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6005 when "big" contains more than 2**29 bytes, even though this
6006 inserts just one byte and does not overflow the buffer.
6007 (Finsert_file_contents): Store file offsets as off_t
6008 values, not as EMACS_INT values. Check for overflow when
6009 converting between EMACS_INT and off_t. When checking for
6010 buffer overflow or for overlap, take the offsets into account.
6011 Don't use EMACS_INT for small values where int suffices.
6012 When checking for overlap, fix a typo: ZV was used where
6013 ZV_BYTE was intended.
6014 (Fwrite_region): Don't assume off_t fits into 'long'.
6015 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6016
ecfc0a49
MA
60172011-09-05 Michael Albinus <michael.albinus@gmx.de>
6018
6019 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6020
6511acf2 60212011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6022
0999621a 6023 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6024
6025 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6026 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6027 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6028 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6029 (modify_event_symbol): Do not assume that the length of
6030 name_alist_or_stem is safe to alloca and fits in int.
6031 (Fexecute_extended_command): Likewise for function name and binding.
6032 (Frecursion_depth): Wrap around reliably on integer overflow.
6033 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6034 since some callers pass EMACS_INT values.
6035 (Fsingle_key_description): Don't crash if symbol name contains more
6036 than MAX_ALLOCA bytes.
6037 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6038 (get_minibuffer): Arg is now EMACS_INT, not int.
6039 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6040 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6041 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6042
2be7d702
PE
6043 * dbusbind.c (signature_cat): New function.
6044 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6045 Do not overrun buffer; instead, report string overflow.
6046
9d1df220
PE
6047 * dispnew.c (add_window_display_history): Don't overrun buffer.
6048 Truncate instead; this is OK since it's just a log.
6049
33ef5c64
PE
6050 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6051 even if the time zone offset is outlandishly large.
6052 Don't mishandle offset == INT_MIN.
6053
66c6fdd5
PE
6054 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6055 when creating daemon; the previous buffer-overflow check was incorrect.
6056
d749b01b
PE
6057 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6058 which has the guts of the old verror function.
6059
b5cd1905
PE
6060 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6061 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6062
6e1a67fb
PE
6063 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6064 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6065 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6066 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6067 length of string rather than counting it via multiple sprintfs;
6068 that's simpler and more reliable.
c21721cc
PE
6069 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6070 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6071 sprintf, in case result does not fit in int.
6072
c57b67fc
PE
6073 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6074 (fontset_from_font): Print it.
6075
8a401434
PE
6076 * frame.c (tty_frame_count): Now printmax_t, not int.
6077 (make_terminal_frame, set_term_frame_name): Print it.
6078 (x_report_frame_params): In X, window IDs are unsigned long,
6079 not signed long, so print them as unsigned.
6080 (validate_x_resource_name): Check for implausibly long names,
6081 and don't assume name length fits in 'int'.
6082 (x_get_resource_string): Don't blindly alloca invocation name;
6083 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6084 not fit in int.
6085
6e1a67fb
PE
6086 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6087 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6088 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6089
0df02bf3
PE
6090 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6091 Use esprintf, not sprintf, in case result does not fit in int.
6092
48e30793
PE
6093 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6094 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6095 it as a large positive number.
6096 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6097 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6098
a66ff6d8
PE
6099 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6100 in case result does not fit in int.
6101
aca216ff
PE
6102 * print.c (float_to_string): Detect width overflow more reliably.
6103 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6104 buffer overrun. Don't assume list length fits in 'int'. Treat
6105 print length of 0 as 0, not as infinity; to be consistent with other
6106 uses of print length in this function. Don't overflow print length
6107 index. Don't assume hash table size fits in 'long', or that
6108 vectorlike size fits in 'unsigned long'.
6109
31c286f7
PE
6110 * process.c (make_process): Use printmax_t, not int, to format
6111 process-name gensyms.
6112
55e5faa1
PE
6113 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6114
80f2e268
PE
6115 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6116 to avoid potential buffer overrun.
6117
670741ab
PE
6118 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6119 if X resource line is longer than 512 bytes.
6120
b7163a50
PE
6121 * xfns.c (x_window): Make sprintf buffer a bit bigger
6122 to avoid potential buffer overrun.
6123
ae58ff1f
PE
6124 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6125
c43c8a6a
PE
6126 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6127
3f8236f4
PE
61282011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6129
53e9fe90 6130 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6131 Without these, Emacs silently mishandles large integers sometimes.
6132 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6133 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6134
6511acf2
PE
6135 * xdisp.c (try_window_id): Check Emacs fixnum range before
6136 converting to 'int'.
806add1d 6137
6511acf2 6138 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6139 Check that an Emacs fixnum is in range before assigning it to 'int'.
6140 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6141 values converted from Emacs fixnums.
6142 (Frecenter): Don't wrap around a line count if it is out of 'int'
6143 range; instead, treat it as an extreme value.
6144 (Fset_window_configuration, compare_window_configurations):
6145 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6146
6511acf2
PE
6147 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6148 that can exceed INT_MAX. Check that EMACS_INT value is in range
6149 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6150 (match_limit): Don't assume that a fixnum can fit in 'int'.
6151
6511acf2 6152 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6153 exceed INT_MAX.
6154
6511acf2 6155 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6156 (Fvertical_motion): Don't wrap around LINES values that don't fit
6157 in 'int'. Instead, treat them as extreme values. This is good
6158 enough for windows, which can't have more than INT_MAX lines anyway.
6159
fcb901a7
LMI
61602011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6161
0f2f6b6d
LMI
6162 * Require libxml/parser.h to avoid compilation warning.
6163
fcb901a7
LMI
6164 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6165
6166 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6167 since this reportedly can destroy thread storage.
6168
6e20a0d4
CY
61692011-08-30 Chong Yidong <cyd@stupidchicken.com>
6170
6171 * syntax.c (find_defun_start): Update all cache variables if
6172 exiting early (Bug#9401).
6173
148ae00e
EZ
61742011-08-30 Eli Zaretskii <eliz@gnu.org>
6175
f6cfbd8f
EZ
6176 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6177
148ae00e
EZ
6178 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6179 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6180 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6181
6182 * term.c (tty_append_glyph): New function.
6183 (produce_stretch_glyph): Static function and its prototype deleted.
6184
a66cfb1c
SM
6185 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6186 Add prototypes.
148ae00e 6187
c4a07a4c
PE
61882011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6189
6190 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6191 when checking :margin (Bug#9390).
6192 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6193 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6194 so that the name doesn't mislead. All uses changed.
6195
6bc8cd65
JB
61962011-08-28 Johan Bockgård <bojohan@gnu.org>
6197
6198 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6199 set_tty_hooks.
6200
dca4927e
EZ
62012011-08-27 Eli Zaretskii <eliz@gnu.org>
6202
6203 * xdisp.c (move_it_to): Don't bail out early when reaching
6204 position beyond to_charpos, if we are scanning backwards.
6205 (move_it_vertically_backward): When DY == 0, make sure we get to
6206 the first character in the line after the newline.
6207
f2cad773
PE
62082011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6209
6210 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6211 (ccl_driver): Do not generate an out-of-range pointer.
6212 (Fccl_execute_on_string): Remove unnecessary check for
6213 integer overflow, noted by Stefan Monnier in
6214 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6215 Remove a FIXME that didn't need fixing.
6216 Simplify the newly-introduced buffer reallocation code.
6217
0cae2cdb
JB
62182011-08-27 Juanma Barranquero <lekktu@gmail.com>
6219
6220 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6221
5fc295a4 62222011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6223
70c60eb2 6224 Integer and memory overflow issues (Bug#9196).
726e0ab1 6225
d31850da
PE
6226 * doc.c (get_doc_string): Rework so that
6227 get_doc_string_buffer_size is the actual buffer size, rather than
6228 being 1 less than the actual buffer size; this makes xpalloc more
6229 convenient.
6230
a69fbedb
PE
6231 * image.c (x_allocate_bitmap_record, cache_image):
6232 * xselect.c (Fx_register_dnd_atom):
6233 Simplify previous changes by using xpalloc.
6234
fe5c5d37
PE
6235 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6236 since either will do and ptrdiff_t is convenient with xpalloc.
6237
0065d054
PE
6238 * charset.c (charset_table_size)
6239 (struct charset_sort_data.priority): Now ptrdiff_t.
6240 (charset_compare): Don't overflow if priorities differ greatly.
6241 (Fsort_charsets): Don't assume list length fits in int.
6242 Check for size-calculation overflow when allocating sort data.
6243 (syms_of_charset): Allocate an initial charset table that is
6244 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6245
6246 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6247
6248 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6249 The actual value is always <= INT_MAX, and leaving it unsigned made
6250 overflow checking harder.
6251
6252 * dispextern.h (struct glyph_matrix.rows_allocated)
6253 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6254 with xpalloc. The values are still always <= INT_MAX.
6255
6256 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6257
6258 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6259 (SAFE_NALLOCA): New macro.
6260
6261 * region-cache.c (struct boundary.pos, find_cache_boundary)
6262 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6263 (set_cache_region, invalidate_region_cache)
6264 (revalidate_region_cache, know_region_cache, region_cache_forward)
6265 (region_cache_backward, pp_cache):
6266 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6267 so that ptrdiff_t * can be passed to xpalloc.
6268 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6269 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6270 (pp_cache): Don't assume cache_len fits in int.
6271 * region-cache.h: Adjust extern decls to match.
6272
6273 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6274 EMACS_INT, since either will do, for xpalloc.
6275
6276 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6277 (xnmalloc, xnrealloc, xpalloc): New functions.
6278
726e0ab1
PE
6279 * bidi.c (bidi_shelve_header_size): New constant.
6280 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6281 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6282
51f30bc5 6283 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6284 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6285 (overlay_strings):
6286 Don't update size of array until after memory allocation succeeds,
6287 because xmalloc/xrealloc may not return.
0065d054
PE
6288 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6289 now that we have proper integer overflow checking.
6290 (record_overlay_string, overlay_strings): Catch overflows when
6291 calculating size of overlay_str_buf.
726e0ab1 6292
0065d054
PE
6293 * callproc.c (Fcall_process): Check for size overflow when
6294 calculating size of args2.
6295 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6296 Normally we prefer signed values, but sticking with ptrdiff_t would
6297 require adding more-complicated checks.
726e0ab1
PE
6298
6299 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6300 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6301 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6302 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6303
6304 * character.c (Fstring): Check for size-calculation overflow.
6305
6306 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6307 unnecessary integer overflow. Check for size overflow.
6308 (encode_coding_object): Don't update size until xmalloc succeeds.
6309
6310 * composite.c (get_composition_id): Check for overflow in glyph
6311 length calculations.
6312
6313 Integer and memory overflow fixes for display code.
6314 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6315 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6316 (scrolling_window): Check for overflow in size calculations.
6317 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6318 Don't assume glyph table len fits in int.
6319 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6320 (row_table_size): Now ptrdiff_t, not int.
6321 (scrolling_window): Avoid overflow in size calculations.
6322 Don't update size until allocation succeeds.
6323 * fns.c (concat): Check for overflow in size calculations.
6324 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6325 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6326 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6327
6328 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6329 (get_doc_string): Check for size calculation overflow.
6330 Don't update size until allocation succeeds.
6331 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6332 EMACS_INT, where ptrdiff_t will do.
6333 (Fsubstitute_command_keys): Check for string overflow.
6334
6335 * editfns.c (set_time_zone_rule): Don't assume environment length
6336 fits in int.
6337 (message_length): Now ptrdiff_t, not int.
6338 (Fmessage_box): Don't update size until allocation succeeds.
6339 Don't assume message length fits in int.
6340 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6341
0065d054
PE
6342 * emacs.c (main): Do not reallocate argv, since there is a null at
6343 the end that can be overwritten, and this way there's no need to
6344 worry about size-calculation overflow.
6345 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6346
6347 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6348 alloc succeeds.
6349 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6350
6351 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6352 (x_set_scroll_bar_width, x_figure_window_size):
6353 Check for integer overflow.
6354 (x_set_alpha): Do not assume XINT fits in int.
6355
6356 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6357 This is for the members text_lines, text_cols, total_lines, total_cols,
6358 where the system imposes an 'int' limit.
6359
6360 * fringe.c (Fdefine_fringe_bitmap):
6361 Don't update size until alloc works.
6362
6363 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6364 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6365
6366 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6367 Check for size-calculation overflow.
6368 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6369 do, as we prefer signed integers.
6370 (id_to_widget.max_size, id_to_widget.used)
6371 (xg_store_widget_in_map, xg_remove_widget_from_map)
6372 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6373 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6374 Use and return ptrdiff_t, not int.
6375 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6376 * gtkutil.h: Change prototypes to match the above.
6377
6378 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6379 are duplicate now that they've been promoted to lisp.h.
6380 (x_allocate_bitmap_record, x_alloc_image_color)
6381 (make_image_cache, cache_image, xpm_load):
6382 Don't update size until alloc is done.
6383 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6384 (x_detect_edges):
3256efce 6385 Check for size calculation overflow.
726e0ab1
PE
6386 (ct_colors_allocated_max): New constant.
6387 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6388 overflow.
3256efce 6389
726e0ab1
PE
6390 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6391 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6392 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6393 Use ptrdiff_t, not int, to count maps.
6394 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6395 calculations. Don't update size until allocation succeeds.
6396 Redo calculations to avoid overflow.
726e0ab1
PE
6397 * keyboard.h: Change prototypes to match the above.
6398
6399 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6400 to count maps.
6401 (current_minor_maps): Check for size calculation overflow.
6402 * keymap.h: Change prototypes to match the above.
6403
6404 * lread.c (read1, init_obarray): Don't update size until alloc done.
6405
6406 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6407 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6408
726e0ab1
PE
6409 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6410 Now ptrdiff_t, not int.
6411 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6412 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6413
6414 * process.c (Fnetwork_interface_list): Check for overflow
6415 in size calculation.
6416
6417 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6418
6419 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6420 overflow. Don't bother calling xmalloc when xrealloc will do.
6421
6422 * search.c (Freplace_match): Check for size calculation overflow.
6423 (Fset_match_data): Don't assume list lengths fit in 'int'.
6424
6425 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6426 for command line length. Do not attempt to address one before the
6427 beginning of an array, as that's not portable.
6428
6429 * term.c (max_frame_lines): Remove; unused.
6430 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6431 not int.
6432 (encode_terminal_code, calculate_costs): Check for size
6433 calculation overflow.
6434 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6435 table lengths and related sizes. Don't update size until alloc
6436 done. Redo calculations to avoid overflow.
6437 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6438
6439 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6440 subtracting pointers.
6441 (gobble_line): Check for overflow more carefully. Don't update size
6442 until alloc done.
6443
6444 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6445 Don't update size until alloc done.
6446 Redo size calculations to avoid overflow.
6447 Check for size calculation overflow.
0065d054 6448 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6449
6450 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6451 Use ptrdiff_t, not int, for sizes.
6452 (store_mode_line_noprop_char): Don't update size until alloc done.
6453
0065d054
PE
6454 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6455 Use ptrdiff_t, not int, for sizes.
6456 (Finternal_make_lisp_face, cache_face):
6457 Check for size calculation overflow.
6458 (cache_face): Treat size calculation overflows as if they were
6459 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6460
6461 * xfns.c (x_encode_text, x_set_name_internal)
6462 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6463 sizes, since they can exceed INT_MAX in size. Check for size
6464 calculation overflow.
6465
0065d054
PE
6466 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6467 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6468 Don't update size until alloc done.
6469
0065d054 6470 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6471 as sprintf is limited to int lengths.
1d526e2f 6472
252c5ee1
PE
6473 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6474 (X_LONG_MIN): New macros.
864d7ce7
PE
6475 Use them to make the following changes clearer.
6476 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6477 This change doesn't affect the value now, but it may help remind
6478 future maintainers not to raise the value too much later.
6479 (SELECTION_QUANTUM): Remove, replacing with ...
6480 (selection_quantum): ... new function, which avoids overflow.
6481 All uses changed.
6482 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6483 assumption that selection length fits in 'int'.
6484 (x_reply_selection_request, x_handle_selection_request)
6485 (x_get_window_property, receive_incremental_selection)
6486 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6487 (lisp_data_to_selection_data, clean_local_selection_data):
6488 Use ptrdiff_t, not int, to record length of selection.
6489 (x_reply_selection_request, x_get_window_property)
6490 (receive_incremental_selection, x_property_data_to_lisp):
6491 Redo calculations to avoid overflow.
6492 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6493 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6494 something.
6495 (x_get_window_property, receive_incremental_selection)
6496 (lisp_data_to_selection_data, x_property_data_to_lisp):
6497 Check for size-calculation overflow.
6498 (x_get_window_property, receive_incremental_selection)
6499 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6500 Don't store size until memory allocation succeeds.
6501 (x_get_window_property): Plug memory leak on memory exhaustion.
6502 Don't double-block input; malloc is safe here. Don't assume 2**34
6503 - 4 fits in unsigned long. Add an xassert to check
6504 XGetWindowProperty overflow. Be more careful about overflow
6505 calculations, and distinguish size from memory overflow better.
6506 (receive_incremental_selection): When tracing, don't assume
6507 unsigned int is less than INT_MAX.
6508 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6509 harmful) conversions of unsigned short to int.
6510 (lisp_data_to_selection_data): Don't assume that integers
6511 in the range -65535 through -1 fit in an X unsigned short.
6512 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6513 result parameters unless successful. Rely on cons_to_unsigned
6514 to report problems with elements; the old code wasn't right anyway.
6515 (x_check_property_data): Check for int overflow; we cannot use
6516 a wider type due to X limits.
6517 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6518
726e0ab1 6519 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6520
0065d054
PE
6521 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6522 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6523 (x_color_cells): Don't store size until memory allocation succeeds.
6524 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6525 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6526 (x_term_init): Don't assume length fits in int (sprintf is limited
6527 to int size).
bc18e09d 6528
ebfa62c0
PE
6529 Use ptrdiff_t for composition IDs.
6530 * character.c (lisp_string_width):
6531 * composite.c (composition_table_size, n_compositions)
6532 (get_composition_id, composition_gstring_from_id):
6533 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6534 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6535 * window.c (Frecenter):
6536 Use ptrdiff_t, not int, for composition IDs.
6537 * composite.c (get_composition_id): Check for integer overflow.
6538 * composite.h: Adjust prototypes to match the above changes.
6539
d3411f89
PE
6540 Use ptrdiff_t for hash table indexes.
6541 * category.c (hash_get_category_set):
6542 * ccl.c (ccl_driver):
6543 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6544 * coding.c (coding_system_charset_list, detect_coding_system):
6545 * coding.h (struct coding_system.id):
6546 * composite.c (get_composition_id, gstring_lookup_cache):
6547 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6548 * image.c (xpm_get_color_table_h):
6549 * lisp.h (hash_lookup, hash_put):
6550 * minibuf.c (Ftest_completion):
6551 Use ptrdiff_t for hash table indexes, not int (which is too
6552 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6553 32-bit --with-wide-int hosts).
6554
e097a6fa
PE
6555 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6556 Add a FIXME comment about memory leaks.
6557 (syms_of_charset): Don't assume xmalloc returns.
6558
5637687f
PE
6559 Don't assume that stated character widths fit in int.
6560 * character.c (Fchar_width, c_string_width, lisp_string_width):
6561 * character.h (CHAR_WIDTH):
6562 * indent.c (MULTIBYTE_BYTES_WIDTH):
6563 Use sanitize_char_width to avoid undefined and/or bad behavior
6564 with outlandish widths.
a66cfb1c 6565 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6566 now that we have two such functions. All uses changed.
6567 (sanitize_char_width): New inline function.
6568
a2271ba2
PE
6569 Don't assume that tab-width fits in int.
6570 * character.h (sanitize_width): New inline function.
6571 (SANE_TAB_WIDTH): New macro.
6572 (ASCII_CHAR_WIDTH): Use it.
6573 * indent.c (sane_tab_width): Remove. All uses replaced by
6574 SANE_TAB_WIDTH (current_buffer).
6575 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6576
18c52557
PE
6577 * fileio.c: Integer overflow issues with file modes.
6578 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6579
caeeedc1
PE
6580 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6581 Remove unreachable code.
6582 (read_hex, load_charset_map_from_file): Check for integer overflow.
6583
6df6ae42 6584 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6585 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6586 (x_send_scroll_bar_event): Likewise. Check that the size does not
6587 exceed limits imposed by XClientMessageEvent, as well as the usual
6588 ptrdiff_t and size_t limits.
6589
b13995db
PE
6590 * keyboard.c: Overflow, signedness and related fixes.
6591 (make_lispy_movement): Use same integer type in forward decl
6592 that is used in the definition.
6593 (read_key_sequence, keyremap_step):
6594 Change bufsize argument back to int, undoing my 2011-03-30 change.
6595 We prefer signed types, and int is wide enough here.
6596 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6597 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6598 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6599 length, not size_t. Use ptrdiff_t for index, not int.
6600 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6601 possibility of integer overflow.
6602
13464394
PE
6603 Overflow, signedness and related fixes for images.
6604
6605 * dispextern.h (struct it.stack[0].u.image.image_id)
6606 (struct_it.image_id, struct image.id, struct image_cache.size)
6607 (struct image_cache.used, struct image_cache.ref_count):
6608 * gtkutil.c (update_frame_tool_bar):
6609 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6610 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6611 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6612 * nsmenu.m (update_frame_tool_bar):
6613 * xdisp.c (calc_pixel_width_or_height):
6614 * xfns.c (image_cache_refcount):
6615 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6616 on typical 64-bit hosts.
6617
6618 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6619 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6620 Omit unnecessary casts to int.
6621 (parse_image_spec): Check that integers fall into 'int' range
6622 when the callers expect that.
6623 (image_ascent): Redo ascent calculation to avoid int overflow.
6624 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6625 (lookup_image): Remove unnecessary tests.
6626 (xbm_image_p): Locals are now of int, not EMACS_INT,
6627 since parse_image_check makes sure they fit into int.
6628 (png_load, gif_load, svg_load_image):
6629 Prefer int to unsigned where either will do.
6630 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6631 old tiff_error_handler and tiff_warning_handler.
6632 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6633 stack buffer overflows. It uses only the features of vsnprintf
6634 that are common to both POSIX and native Microsoft.
6635 (tiff_error_handler, tiff_warning_handler): Use it.
6636 (tiff_load, gif_load, imagemagick_load_image):
6637 Don't assume :index value fits in 'int'.
6638 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6639 (imagemagick_load_image): Check that crop parameters fit into
6640 the integer types that MagickCropImage accepts. Don't assume
6641 Vimagemagick_render_type has a nonnegative value. Don't assume
6642 size_t fits in 'long'.
6643 (gs_load): Use printmax_t to print the widest integers possible.
6644 Check for integer overflow when computing image height and width.
6645
c11821d4
EZ
66462011-08-26 Eli Zaretskii <eliz@gnu.org>
6647
6648 * xdisp.c (redisplay_window): Don't force window start if point
6649 will be invisible in the resulting window. (Bug#9324)
6650
0c95fcf7
EZ
66512011-08-25 Eli Zaretskii <eliz@gnu.org>
6652
6653 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6654 the display spec is of the form `(space ...)'.
6655 (handle_display_spec): Return the value returned by
6656 handle_single_display_spec, not just 1 or zero.
6657 (handle_single_display_spec): If the display spec is of the form
6658 `(space ...)', and specifies display in the text area, return 2
6659 rather than 1.
fee65a97 6660 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6661 accurately, and prefer exact match for point under bidi.
6662 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6663
6664 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6665 into disp_prop; all users changed.
6666
6667 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6668 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6669 for the text covered by the display property.
6670
e4ed06f1
CY
66712011-08-25 Chong Yidong <cyd@stupidchicken.com>
6672
6673 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6674 Change return value to nil.
6675 (Frecord_buffer): Delete unused function.
6676
f67cdd7f
EZ
66772011-08-24 Eli Zaretskii <eliz@gnu.org>
6678
5980d4c6
EZ
6679 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6680 buffers, return left-to-right.
8610fe8b
EZ
6681 (set_cursor_from_row): Consider candidate row a win if its glyph
6682 represents a newline and point is on that newline. Fixes cursor
6683 positioning on the newline at EOL of R2L text within L2R
6684 paragraph, and vice versa.
6685 (try_cursor_movement): Check continued rows, in addition to
6686 continuation rows. Fixes unwarranted scroll when point enters a
6687 continued line of R2L text within an L2R paragraph, or vice versa.
6688 (cursor_row_p): Consider the case of point being equal to
6689 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6690 from the end of a short line to the beginning of a continued line
6691 of R2L text within L2R paragraph.
6692 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6693 composed characters.
5980d4c6 6694
f67cdd7f
EZ
6695 * bidi.c (bidi_check_type): Use xassert.
6696 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6697 members.
6698
bca633fb
EZ
66992011-08-23 Eli Zaretskii <eliz@gnu.org>
6700
6701 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6702 a character.
6703
4a5885a7
CY
67042011-08-23 Chong Yidong <cyd@stupidchicken.com>
6705
6706 * nsfont.m (ns_otf_to_script): Fix typo.
6707
0902a04e
KH
67082011-08-22 Kenichi Handa <handa@m17n.org>
6709
6710 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6711 extra slot even if the purpose is char-code-property-table.
6712
1a2e6670
EZ
67132011-08-23 Eli Zaretskii <eliz@gnu.org>
6714
8ddde651
EZ
6715 * xdisp.c (redisplay_window): When computing centering_position,
6716 account for the height of the header line. (Bug#8874)
6717
425cc014
EZ
6718 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6719 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6720 candidate is selected by the mouse, and that candidate has a
6721 composed character under the mouse.
6722
1a2e6670
EZ
6723 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6724 coordinates reported by pos-visible-in-window-p for a composed
6725 character in column zero.
6726
8b76d6f8
SM
67272011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6728
6729 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6730
dac347dd
EZ
67312011-08-22 Eli Zaretskii <eliz@gnu.org>
6732
6733 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6734 consider it a hit if to_charpos is anywhere in the range of the
6735 composed buffer positions.
6736
e013fb34
CY
67372011-08-22 Chong Yidong <cyd@stupidchicken.com>
6738
6739 * image.c (gif_load): Don't assume that each subimage has the same
6740 dimensions as the base image. Handle disposal method that is
6741 "undefined" by the gif spec (Bug#9335).
6742
bd1ba3e8
CY
67432011-08-20 Chong Yidong <cyd@stupidchicken.com>
6744
6745 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6746 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6747
54a1215b
EZ
67482011-08-19 Eli Zaretskii <eliz@gnu.org>
6749
823564e5
EZ
6750 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6751 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6752 from an Org mode buffer to a Speedbar frame.
6753
54a1215b
EZ
6754 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6755 a composition, take its buffer position from IT->cmp_it.charpos.
6756 Fixes cursor positioning at the beginning of a line that begins
6757 with a composed character.
6758
9778ebcc
EZ
67592011-08-18 Eli Zaretskii <eliz@gnu.org>
6760
0be6ee06
EZ
6761 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6762 character bidirectional type, use STRONG_L instead. Fixes crashes
6763 in a buffer produced by `describe-categories'.
6764
9778ebcc
EZ
6765 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6766 members before the level stack, so they would be saved and
6767 restored when copying iterator state. Fixes incorrect reordering
6768 around TABs covered by display properties.
6769
156bffbe
AS
67702011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6771
6b02f655 6772 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6773
72ad093b
CY
67742011-08-17 Chong Yidong <cyd@stupidchicken.com>
6775
6776 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6777 (internal_condition_case_2, internal_condition_case_n):
6778 Remove unnecessary aborts (Bug#9081).
72ad093b 6779
35774242
EZ
67802011-08-17 Eli Zaretskii <eliz@gnu.org>
6781
6782 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6783 has no `load' handler, try opening the file locally. (Bug#9311)
6784
db76dd85
KB
67852011-08-16 Ken Brown <kbrown@cornell.edu>
6786
6787 * gmalloc.c: Expand comment.
6788
b215eee5
EZ
67892011-08-16 Eli Zaretskii <eliz@gnu.org>
6790
6791 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6792 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6793
a4579d33
KB
67942011-08-16 Ken Brown <kbrown@cornell.edu>
6795
6796 Fix memory allocation problems in Cygwin build (Bug#9273).
6797
6798 * unexcw.c ( __malloc_initialized): Declare external variable.
6799 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6800
8b76d6f8
SM
6801 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6802 New variables.
a4579d33
KB
6803 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6804 dumped emacs.
6805 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6806 in the static heap.
6807 [CYGWIN] (special_realloc): New function.
6808 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6809 requests to realloc storage in the static heap.
6810
3ebec551
PE
68112011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6812
6813 * bidi.c (bidi_initialize): Remove unused local.
6814
9fd8be00
EZ
68152011-08-15 Eli Zaretskii <eliz@gnu.org>
6816
6b02f655
SM
6817 * bidimirror.h:
6818 * biditype.h: Remove file.
6819 * makefile.w32-in ($(BLD)/bidi.$(O)):
6820 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6821
6822 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6823
6824 * chartab.c: Improve commentary for the uniprop_table API.
6825
32413314
EZ
6826 * bidi.c (bidi_paragraph_init): Support zero value of
6827 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6828 (bidi_initialize): Use uniprop_table instead of including
6829 biditype.h and bidimirror.h.
32413314 6830
9fd8be00
EZ
6831 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6832 coordinates of the iterator when restoring from ppos_it.
6833 (Bug#9296)
6834
5cf2b69b
KH
68352011-08-14 Kenichi Handa <handa@m17n.org>
6836
6837 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6838 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6839
daf17d00
EZ
68402011-08-14 Eli Zaretskii <eliz@gnu.org>
6841
6842 * xdisp.c (move_it_in_display_line_to): Don't invoke
6843 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6844 ppos_it. Fixes vertical cursor motion when line beginning is
6845 covered by an image. (Bug#9296)
6846
08e3161a
JD
68472011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6848
6849 * nsterm.h (ns_run_ascript): Declare.
6850 (NSAPP_DATA2_RUNASSCRIPT): Define.
6851
6852 * nsfns.m (as_script, as_result, as_status): New static variables.
6853 (ns_run_ascript): New function.
5e617bc2 6854 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6855 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6856 the event loop. Get status from as_status (Bug#7276).
6857
6858 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6859 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6860 the event loop (Bug#7276).
6861
a3720aa2
AS
68622011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6863
6864 * gnutls.c (QCgnutls_bootprop_priority)
6865 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6866 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6867 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6868 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6869 (QCgnutls_bootprop_verify_hostname_error)
6870 (QCgnutls_bootprop_callbacks_verify): Rename from
6871 Qgnutls_bootprop_..., all uses changed.
6872
6873 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6874 uses changed.
6875
0a0d27fb
PE
68762011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6877
19d5c50c
PE
6878 * xfaces.c (Qframe_set_background_mode): Now static.
6879 * dispextern.h (Qframe_set_background_mode): Remove decl.
6880
0a0d27fb
PE
6881 * process.c (Fnetwork_interface_info): Declare local only if needed.
6882
377538cb
JD
68832011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6884
6885 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6886 (Fnetwork_interface_list): Allocate in increments of bytes instead
6887 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6888 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6889 sockaddr.
6890 (struct ifflag_def): notrailers is smart on OSX.
6891 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6892 Get hardware address with getifaddrs if available.
6893
08fff70c
EZ
68942011-08-12 Eli Zaretskii <eliz@gnu.org>
6895
6896 * xdisp.c (iterate_out_of_display_property): xassert that
6897 IT->position is set to within IT->object's boundaries. Break from
6898 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6899 when IT->position is set up wrongly due to some bug.
6900 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6901 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6902 entry. Force push_it to save on the stack the current
6903 buffer/string position, to be restored by pop_it. Fix flags in
6904 the iterator structure wrt the object coming from a display
6905 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6906 properties. (Bug#9284)
6907
7be1c708 69082011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6909
7be1c708
CY
6910 * fontset.c (fontset_get_font_group): Add proper type checks.
6911 (Bug#9172)
aac0c6e3 6912
7be1c708 69132011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6914
7be1c708
CY
6915 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6916 and LC_VERSION_MIN_MACOSX.
6917 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6918 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6919
97bb72a6
EZ
69202011-08-08 Eli Zaretskii <eliz@gnu.org>
6921
6922 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6923 no-display-properties-and-no-overlays under bidi display.
6924 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6925 properties and overlays.
97bb72a6 6926
d5617611
CY
69272011-08-08 Chong Yidong <cyd@stupidchicken.com>
6928
37e11a63
CY
6929 * editfns.c (Fset_time_zone_rule): Document relationship with the
6930 setenv function.
6931
d5617611
CY
6932 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6933 the font entity extracted from the cache (Bug#8109).
6934
58872834
CY
69352011-08-07 Chong Yidong <cyd@stupidchicken.com>
6936
6937 * composite.c (autocmp_chars): Don't reset point. That is done by
6938 restore_point_unwind (Bug#5984).
6939
75bfc667
JL
69402011-08-07 Juri Linkov <juri@jurta.org>
6941
6942 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6943 to show the arg `TIME' instead of `TIMEVAL'.
6944
d1410150
EZ
69452011-08-06 Eli Zaretskii <eliz@gnu.org>
6946
6947 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6948 display property strides EOL and includes a newline, as in
6949 longlines-mode. (Bug#9254)
75b771e4
EZ
6950 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6951 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6952
6953 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6954 is non-zero, even if the data buffer is NULL. Fixes a crash in
6955 vertical-motion with longlines-mode. (Bug#9254)
6956
35928349
EZ
69572011-08-05 Eli Zaretskii <eliz@gnu.org>
6958
ec7cc85b
EZ
6959 * bidi.c <bidi_cache_total_alloc>: Now static.
6960 (bidi_initialize): Initialize bidi_cache_total_alloc.
6961
8b76d6f8 6962 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6963 cache. (Bug#9221)
6964
6965 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6966 amount allocated this far in `bidi_cache_total_alloc'.
6967 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6968 non-zero, only free the data buffer without restoring the cache
6969 contents. All callers changed.
6970
6971 * dispextern.h (bidi_unshelve_cache): Update prototype.
6972
6973 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6974 (move_it_in_display_line, move_it_to)
6975 (move_it_vertically_backward, move_it_by_lines): Replace the call
6976 to xfree to an equivalent call to bidi_unshelve_cache.
6977 (move_it_in_display_line_to): Fix logic of returning
412b6358 6978 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6979
e2e2423b
EZ
69802011-08-05 Eli Zaretskii <eliz@gnu.org>
6981
6982 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6983 came from a string character with a `cursor' property. (Bug#9229)
6984
ae9e757a
JD
69852011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6986
6987 * Makefile.in (LIB_PTHREAD): New variable.
6988 (LIBES): Add LIB_PTHREAD (Bug#9216).
6989
6990 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6991 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6992
213bd7f2
AS
69932011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6994
6b02f655 6995 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6996
99aaf75f
JD
69972011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6998
6999 * xterm.c (x_find_topmost_parent): New function.
7000 (x_set_frame_alpha): Find topmost parent window with
7001 x_find_topmost_parent and set the property there also (bug#9181).
7002 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7003
c74e9d86
PE
70042011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7005
7006 * callproc.c (Fcall_process): Avoid vfork clobbering
7007 the local vars buffer, coding_systems, current_dir.
7008
640c8776
SM
70092011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7010
7011 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7012
f26d0e4c
PE
70132011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7014
8a10d76c
PE
7015 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7016 so that it is not optimized away.
7017
f26d0e4c
PE
7018 * xdisp.c (compute_display_string_pos): Remove unused local.
7019
55439c61
EZ
70202011-08-02 Eli Zaretskii <eliz@gnu.org>
7021
7022 Fix slow cursor motion and scrolling in large buffers with
7023 selective display, like Org Mode buffers. (Bug#9218)
7024
7025 * dispextern.h (struct bidi_it): New member disp_prop_p.
7026
7027 * xdisp.c: Remove one-slot cache of display string positions.
7028 (compute_display_string_pos): Accept an additional argument
5e617bc2 7029 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7030 for a display string or property. If found, set DISP_PROP_P
7031 non-zero.
7032
7033 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7034 DISP_PROP_P, and pass it to compute_display_string_pos.
7035 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7036 non-zero. All callers of bidi_fetch_char changed.
7037
fb33fa43
SM
70382011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7039
7040 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7041
b099e063
DM
70422010-12-03 Don March <don@ohspite.net>
7043
7044 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7045 last character M-[char] is translated to ESC [char] (bug#7541).
7046
5cc7f7af
KH
70472011-08-02 Kenichi Handa <handa@m17n.org>
7048
d0fffa3f 7049 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7050
7051 * chartab.c (uniprop_table): Make it non-static.
7052
525d5e6e
EZ
70532011-08-01 Eli Zaretskii <eliz@gnu.org>
7054
7055 * xdisp.c (forward_to_next_line_start): Accept additional argument
7056 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7057 on the newline.
7058 (reseat_at_next_visible_line_start): Use the bidi iterator state
7059 returned by forward_to_next_line_start to restore the state of
7060 it->bidi_it after backing up to previous newline. (Bug#9212)
7061
31011111
AS
70622011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7063
7064 * regex.c (re_comp): Protoize.
7065 (re_exec): Fix return type.
7066 (regexec): Fix type of `ret'. (Bug#9203)
7067
476371c4
PE
70682011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7069
e5d76069
PE
7070 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7071 This is needed if max-image-size is a floating-point number.
7072
9a79b20c
AS
70732011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7074
7075 * print.c (print_object): Print empty symbol as ##.
7076
7077 * lread.c (read1): Read ## as empty symbol.
7078
d8c2fa78
AA
70792011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7080
7081 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7082 setting frame foreground color (Bug#9175).
7083 (x_set_background_color): Likewise.
7084
ffe57a7a
AA
7085 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7086 contents (Bug#9176).
7087 (EmacsTooltip -init): Remove bezels and add shadows to
7088 tooltip windows.
7089
bf3492a5
AA
7090 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7091 or scroll bar (Bug#8470).
7092
d55e9c53
AA
7093 * nsfont.m (nsfont_open): Remove assignment to voffset and
7094 unnecessary vars hshink, expand, hd, full_height, min_height.
7095 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7096
7097 * nsterm.h (nsfont_info): Remove voffset field.
7098
d8c2fa78 70992011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7100
7101 Implement strike-through and overline on NextStep (Bug#8863).
7102
7103 * nsfont.m (nsfont_open): Use underline position provided by font,
7104 instead of hard-coded value of 2.
7105 (nsfont_draw): Call ns_draw_text_decoration instead.
7106
7107 * nsterm.h: Add declaration for ns_draw_text_decoration.
7108
7109 * nsterm.m (ns_draw_text_decoration): New function for drawing
7110 underline, overline, and strike-through.
7111 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7112 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7113 accommodate underlining, etc.
4843aac3 7114
4cc60b9b
EZ
71152011-07-28 Eli Zaretskii <eliz@gnu.org>
7116
bc7ece87
EZ
7117 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7118 default.
4cc60b9b 7119
476371c4
PE
71202011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7121
66606eea
PE
7122 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7123 Without this fix, if a signal arrives just after memory fills up,
7124 'malloc' might be invoked reentrantly.
7125
476371c4
PE
7126 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7127 In other words, assume that every image size is allowed, on non-X
7128 hosts. This assumption is probably wrong, but it lets Emacs compile.
7129
f3fcc40d
AS
71302011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7131
7132 * regex.c (re_iswctype): Convert return values to boolean.
7133
350c992f
EZ
71342011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7135
7136 * xdisp.c (compute_display_string_pos): Don't use cached display
7137 string position if the buffer had its restriction changed.
7138 (Bug#9184)
7139
5266b4bb
PE
71402011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7141
7142 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7143
2573a837 71442011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7145
41f55ccd 7146 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7147
39e378da
PE
7148 * bidi.c: Integer size and overflow fixes.
7149 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7150 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7151 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7152 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7153 (bidi_find_other_level_edge):
7154 Use ptrdiff_t instead of EMACS_INT where either will do.
7155 This works better on 32-bit hosts configured --with-wide-int.
7156 (bidi_cache_ensure_space): Check for size-calculation overflow.
7157 Use % rather than repeated addition, for better worst-case speed.
7158 Don't set bidi_cache_size until after xrealloc returns, because it
7159 might not return.
7160 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7161 (bidi_cache_ensure_space): Also check that the bidi cache size
7162 does not exceed that of the largest Lisp string or buffer. See Eli
7163 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7164
5e927815
PE
7165 * alloc.c (__malloc_size_t): Remove.
7166 All uses replaced by size_t. See Andreas Schwab's note
7167 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7168
ca4aa935
PE
7169 * image.c: Improve checking for integer overflow.
7170 (check_image_size): Assume that f is nonnull, since
7171 it is always nonnull in practice. This is one less thing to
7172 worry about when checking for integer overflow later.
7173 (x_check_image_size): New function, which checks for integer
7174 overflow issues inside X.
7175 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7176 This removes the need for a memory_full check.
7177 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7178 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7179 (xbm_read_bitmap_data): Change locals back to 'int', since
7180 their values must fit in 'int'.
7181 (xpm_load_image, png_load, tiff_load):
7182 Invoke x_create_x_image_and_pixmap earlier,
7183 to avoid much needless work if the image is too large.
7184 (tiff_load): Treat overly large images as if
7185 x_create_x_image_and_pixmap failed, not as malloc failures.
7186 (gs_load): Use x_check_image_size.
7187
5f8f9cc2
PE
7188 * gtkutil.c: Omit integer casts.
7189 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7190 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7191
5adf60bc
PE
7192 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7193
c8907a93
PE
7194 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7195 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7196 would wrongly return t on a 64-bit host.
7197
e3c25c68
PE
7198 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7199 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7200 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7201 and therefore cause GCC to emit a bogus diagnostic in some cases.
7202
3f791afe
PE
7203 * image.c: Integer signedness and overflow and related fixes.
7204 This is not an exhaustive set of fixes, but it's time to
7205 record what I've got.
7206 (lookup_pixel_color, check_image_size): Remove redundant decls.
7207 (check_image_size): Don't assume that arbitrary EMACS_INT values
7208 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7209 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7210 (tiff_load, imagemagick_load_image):
7211 Check for overflow in size calculations.
7212 (x_create_x_image_and_pixmap): Remove unnecessary test for
7213 xmalloc returning NULL; that can't happen.
7214 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7215 (xpm_color_bucket): Use better integer hashing function.
7216 (xpm_cache_color): Don't possibly over-allocate memory.
7217 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7218 (gif_memory_source):
7219 Use ptrdiff_t, not int or size_t, to record sizes.
7220 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7221 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7222 either works, as we prefer signed integers.
7223 (tiff_read_from_memory, tiff_write_from_memory):
7224 Return tsize_t, not size_t, since that's what the TIFF API wants.
7225 (tiff_read_from_memory): Don't fail simply because the read would
7226 go past EOF; instead, return a short read.
7227 (tiff_load): Omit no-longer-needed casts.
7228 (Fimagemagick_types): Don't assume size fits into 'int'.
7229
3cc5a532
PE
7230 Improve hashing quality when configured --with-wide-int.
7231 * fns.c (hash_string): New function, taken from sxhash_string.
7232 Do not discard information about ASCII character case; this
7233 discarding is no longer needed.
7234 (sxhash-string): Use it. Change sig to match it. Caller changed.
7235 * lisp.h: Declare it.
7236 * lread.c (hash_string): Remove, since we now use fns.c's version.
7237 The fns.c version returns a wider integer if --with-wide-int is
7238 specified, so this should help the quality of the hashing a bit.
7239
b312a492
PE
7240 * emacs.c: Integer overflow minor fix.
7241 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7242 Define only if GNU_LINUX.
7243 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7244
dfd153ae
PE
7245 * dispnew.c: Integer signedness and overflow fixes.
7246 Remove unnecessary forward decls, that were a maintenance hassle.
7247 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7248 All uses changed.
7249 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7250 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7251 (prepare_desired_row, line_draw_cost):
7252 Use int, not unsigned, where either works.
7253 (save_current_matrix, restore_current_matrix):
7254 Use ptrdiff_t, not size_t, where either works.
7255 (init_display): Check for overflow more accurately, and without
7256 relying on undefined behavior.
7257
a81d11a3
PE
7258 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7259 Remove, replacing with the new symbols in lisp.h. All uses changed.
7260 * fileio.c (make_temp_name):
7261 * filelock.c (lock_file_1, lock_file):
7262 * xdisp.c (message_dolog):
7263 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7264 Use pMd etc. instead.
7265 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7266 replacing the pWIDE etc. symbols removed from editfns.c.
7267
3300e6fd
PE
7268 * keyboard.h (num_input_events): Now uintmax_t.
7269 This is (very slightly) less likely to mess up due to wraparound.
7270 All uses changed.
7271
fd05c7e9
PE
7272 * buffer.c: Integer signedness fixes.
7273 (alloc_buffer_text, enlarge_buffer_text):
7274 Use ptrdiff_t rather than size_t when either will do, as we prefer
7275 signed integers.
7276
903fe15d
PE
7277 * alloc.c: Integer signedness and overflow fixes.
7278 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7279 (__malloc_size_t): Default to size_t, not to int.
7280 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7281 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7282 Prefer ptrdiff_t to size_t when either would do, as we prefer
7283 signed integers.
7284 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7285 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7286 Now const. Initialize with values that are in range even if char
7287 is signed.
7288 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7289 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7290 These functions do the right thing with sizes > 2**32.
7291 (check_depth): Now ptrdiff_t, not int.
7292 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7293 Adjust to new way of storing sizes. Check for size overflow bugs
7294 in rest of code.
7295 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7296 slightly wrong anyway, as it missed one instance of
7297 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7298 (refill_memory_reserve): Omit needless cast to size_t.
7299 (mark_object_loop_halt): Mark as externally visible.
7300
ac82cc6a
PE
7301 * xselect.c: Integer signedness and overflow fixes.
7302 (Fx_register_dnd_atom, x_handle_dnd_message):
7303 Use ptrdiff_t, not size_t, since we prefer signed.
7304 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7305 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7306 x_dnd_atoms_size and x_dnd_atoms_length.
7307
c2d1e36d
PE
7308 * doprnt.c: Prefer signed to unsigned when either works.
7309 * eval.c (verror):
7310 * doprnt.c (doprnt):
7311 * lisp.h (doprnt):
7312 * xdisp.c (vmessage):
7313 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7314 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7315 prefer signed arithmetic to avoid comparison confusion.
7316 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7317 but is a bit tricky.
7318
0e926e56
PE
7319 Assume freestanding C89 headers, string.h, stdlib.h.
7320 * data.c, doprnt.c, floatfns.c, print.c:
7321 Include float.h unconditionally.
7322 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7323 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7324 * regex.c: Likewise for stddef.h, string.h.
7325 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7326 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7327 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7328 (STDC_HEADERS): Remove obsolete defines.
7329 * sysdep.c: Include limits.h unconditionally.
7330
9cfdb3ec
PE
7331 Assume support for memcmp, memcpy, memmove, memset.
7332 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7333 * regex.c (memcmp, memcpy):
7334 Remove; we assume C89 now.
7335
7336 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7337 (__malloc_safe_bcopy): Remove; no longer needed.
7338
cf950e6b 7339 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7340 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7341 well either way, and we prefer signed to unsigned.
7342
dbf38e02
LMI
73432011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7344
7345 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7346 closes the connection while we're reading (bug#9182).
7347
d6f0886c 73482011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7349
d6f0886c
JD
7350 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7351 are specified (Bug#9168).
24e0f6b1 7352
2eb1f9e6
PE
73532011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7354
7355 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7356 Found by GCC static checking and --with-wide-int on a 32-bit host.
7357
22381272 73582011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7359
7360 * xdisp.c (compute_display_string_pos): Fix logic of caching
7361 previous display string position. Initialize cached_prev_pos to
7362 -1. Fixes slow-down at the beginning of a buffer.
7363
f25e39b4
EZ
73642011-07-24 Eli Zaretskii <eliz@gnu.org>
7365
7366 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7367 for attrs[LFACE_FONTSET_INDEX].
7368
04c4b52e
PE
73692011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7370
7371 * xml.c (parse_region): Remove unused local
7372 that was recently introduced.
7373
c1734fbd
EZ
73742011-07-23 Eli Zaretskii <eliz@gnu.org>
7375
be18c5a5
EZ
7376 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7377 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7378
c1734fbd
EZ
7379 * xdisp.c (move_it_in_display_line_to): Record the best matching
7380 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7381 exit if none of the characters scanned was an exact match.
7382 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7383 when exact match is impossible due to invisible text, and the
7384 lines are truncated.
7385
a258d627
JD
73862011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7387
7388 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7389 for OSX >= 10.7.
7390
b6d5a689
EZ
73912011-07-22 Eli Zaretskii <eliz@gnu.org>
7392
0f74f785
EZ
7393 Fix a significant slow-down of cursor motion with C-n, C-p,
7394 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7395 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7396 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7397 (next_element_from_buffer): Call compute_stop_pos_backwards to
7398 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7399 base_level_stop.
7400 (reseat): Don't look for prev_stop, as that could mean a very long
7401 run.
7402 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7403 <cached_disp_overlay_modiff>: Cache for last found display string
7404 position.
551918c1 7405 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7406 about the same buffer in the same area of character positions, and
7407 the buffer wasn't changed since the time the display string
7408 position was cached.
551918c1 7409
b2d0c91a
EZ
74102011-07-22 Eli Zaretskii <eliz@gnu.org>
7411
7412 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7413 is an integer, which is important for empty lines. (Bug#9149)
7414
043604ee
CY
74152011-07-22 Chong Yidong <cyd@stupidchicken.com>
7416
7417 * frame.c (Fmodify_frame_parameters): In tty case, update the
7418 default face if necessary (Bug#4238).
7419
da4adb04
CY
74202011-07-21 Chong Yidong <cyd@stupidchicken.com>
7421
7422 * editfns.c (Fstring_to_char): No need to explain what a character
7423 is in the docstring (Bug#6576).
7424
9abd0532
LMI
74252011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7426
7427 * xml.c (parse_region): Make sure we always return a tree.
7428
36881d16
HK
74292011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7430
7431 * xml.c (parse_region): If a document contains only comments,
7432 return that, too.
7433
1e98674d
LMI
74342011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7435
7436 * xml.c (make_dom): Return comments, too.
7437
590bd467
PE
74382011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7439
7440 Port to OpenBSD.
7441 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7442 and the surrounding thread.
7443 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7444 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7445 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7446 timer goes off.
7447 * s/openbsd.h (BROKEN_SIGIO): Define.
7448 * unexelf.c (unexec) [__OpenBSD__]:
7449 Don't update the .mdebug section of the Alpha COFF symbol table.
7450
f41628b2
LMI
74512011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7452
7453 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7454 (bug#8460).
7455
b59b67c5
PE
74562011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7457
15e3a074
PE
7458 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7459 This fixes some race conditions on the permissions of any newly
7460 created file.
7461
41bed37d
PE
7462 * alloc.c (valid_pointer_p): Use pipe, not open.
7463 This fixes some permissions issues when debugging.
7464
b59b67c5
PE
7465 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7466 If fchown fails to set both uid and gid, try to set just gid,
7467 as that is sometimes allowed. Adjust the file's mode to eliminate
7468 setuid or setgid bits that are inappropriate if fchown fails.
7469
925a6be7
SM
74702011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7471
7472 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7473 to compare Lisp_Objects.
7474 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7475 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7476 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7477
52968808
AS
74782011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7479
0a6a104b
AS
7480 * lread.c (read_integer): Unread even EOF character.
7481 (read1): Likewise. Properly record start position of symbol.
7482
52968808
AS
7483 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7484 symbol character follows.
7485
9e381cdd
PE
74862011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7487
7488 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7489 This works around a problem with the previous change to Fcopy_file.
7490 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7491 and without this change, GCC might complain about discarding
7492 fchown's return value.
7493
b5641435
JB
74942011-07-16 Juanma Barranquero <lekktu@gmail.com>
7495
7496 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7497
a8031457
PE
74982011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7499
7500 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7501
dd889327
LMI
75022011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7503
750c33f7
LMI
7504 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7505 it's used from the C level.
7506
dd889327
LMI
7507 * process.c: Use the same condition for POLL_FOR_INPUT in both
7508 keyboard.c and process.c (bug#1858).
7509
87e86684
LM
75102011-07-09 Lawrence Mitchell <wence@gmx.li>
7511
7512 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7513 (Fgnutls_boot): Use it.
7514
64348f40
AS
75152011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7516
7517 * doc.c (Fsubstitute_command_keys): Revert last change.
7518
1d698799
LMI
75192011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7520
f863868c
LMI
7521 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7522 quotes the next character, and doesn't affect other longer
7523 sequences (bug#8935).
7524
1d698799
LMI
7525 * lread.c (syms_of_lread): Clarify that is isn't only
7526 `eval-buffer' and `eval-defun' that's affected by
7527 `lexical-binding' (bug#8460).
7528
aa4b6df6
EZ
75292011-07-15 Eli Zaretskii <eliz@gnu.org>
7530
7531 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7532 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7533
5d856da6
PE
75342011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7535
ad6042bb
PE
7536 Fix minor problems found by static checking.
7537 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7538 (elsz): Now a signed constant, not a size_t var. We prefer signed
7539 types to unsigned, to avoid integer comparison confusion. Without
7540 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7541 "cannot optimize loop, the loop counter may overflow", a symptom
7542 of the confusion.
f00bbb22 7543 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7544 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7545
6468f31c
LMI
75462011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7547
49080b10
LMI
7548 * search.c (Fre_search_backward): Mention `case-fold-search' in
7549 all the re_search_* functions (bug#8138).
7550
6468f31c
LMI
7551 * keyboard.c (Fopen_dribble_file): Document when the file is
7552 closed (bug#8056).
7553
c965adc5
EZ
75542011-07-14 Eli Zaretskii <eliz@gnu.org>
7555
df9733bf
EZ
7556 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7557 bidi_cache_idx.
7558
0bb23927
EZ
7559 Support bidi reordering of display and overlay strings.
7560 * xdisp.c (compute_display_string_pos)
7561 (compute_display_string_end): Accept additional argument STRING.
7562 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7563 (reseat_to_string): Initialize bidi_it->string.s and
7564 bidi_it->string.schars.
7565 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7566 NULL (avoids a crash in bidi_paragraph_init).
7567 Initialize itb.string.lstring.
0bb23927
EZ
7568 (init_iterator): Call bidi_init_it only of a valid
7569 buffer position was specified. Initialize paragraph_embedding to
7570 L2R.
7571 (reseat_to_string): Initialize the bidi iterator.
7572 (display_string): If we need to ignore text properties of
7573 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7574 original value of -1 will not work with bidi.)
7575 (compute_display_string_pos): First arg is now struct
7576 `text_pos *'; all callers changed. Support display properties on
7577 Lisp strings.
7578 (compute_display_string_end): Support display properties on Lisp
7579 strings.
7580 (init_iterator, reseat_1, reseat_to_string): Initialize the
7581 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7582 when iterating on a string not from display properties).
640c8776
SM
7583 (compute_display_string_pos, compute_display_string_end):
7584 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7585 arrow keys.
7586 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7587 base_level_stop; instead, set base_level_stop to BEGV.
7588 Fixes crashes in vertical-motion.
0bb23927
EZ
7589 (next_element_from_buffer): Improve commentary for when
7590 the iterator is before prev_stop.
7591 (init_iterator): Initialize bidi_p from the default value of
7592 bidi-display-reordering, not from buffer-local value. Use the
7593 buffer-local value only if initializing for buffer iteration.
7594 (handle_invisible_prop): Support invisible properties on strings
7595 that are being bidi-reordered.
7596 (set_iterator_to_next): Support bidi reordering of C strings and
7597 Lisp strings.
7598 (next_element_from_string): Support bidi reordering of Lisp
7599 strings.
7600 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7601 (display_string): Support display of R2L glyph rows.
7602 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7603 (init_iterator): Don't initialize it->bidi_p for strings
7604 here.
7605 (reseat_to_string): Initialize it->bidi_p for strings here.
7606 (next_element_from_string, next_element_from_c_string)
7607 (next_element_from_buffer): Add xassert's for correspondence
7608 between IT's object being iterated and it->bidi_it.string
7609 structure.
7610 (face_before_or_after_it_pos): Support bidi iteration.
7611 (next_element_from_c_string): Handle the case of the first string
7612 character that is not the first one in the visual order.
7613 (get_visually_first_element): New function, refactored from common
7614 parts of next_element_from_buffer, next_element_from_string, and
7615 next_element_from_c_string.
7616 (tool_bar_lines_needed, redisplay_tool_bar)
7617 (display_menu_bar): Force left-to-right direction. Add a FIXME
7618 comment for making that be controlled by a user option.
7619 (push_it, pop_it): Save and restore the state of the
7620 bidi iterator. Save and restore the bidi_p flag.
7621 (pop_it): Iterate out of display property for string iteration as
7622 well.
7623 (iterate_out_of_display_property): Support iteration over strings.
7624 (handle_single_display_spec): Set up it->bidi_it for iteration
7625 over a display string, and call bidi_init_it.
7626 (handle_single_display_spec, next_overlay_string)
7627 (get_overlay_strings_1, push_display_prop): Set up the bidi
7628 iterator for displaying display or overlay strings.
7629 (forward_to_next_line_start): Don't use the shortcut if
7630 bidi-iterating.
7631 (back_to_previous_visible_line_start): If handle_display_prop
7632 pushed the iterator stack, restore the internal state of the bidi
7633 iterator by calling bidi_pop_it same number of times.
7634 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7635 and we are bidi-iterating, don't decrement the iterator position;
7636 instead, set the first_elt flag in the bidi iterator, to produce
7637 the same effect.
7638 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7639 (push_display_prop): xassert that we are iterating a buffer.
7640 (push_it, pop_it): Save and restore paragraph_embedding member.
7641 (handle_single_display_spec, next_overlay_string)
7642 (get_overlay_strings_1, reseat_1, reseat_to_string)
7643 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7644 correctly. Don't assume unibyte strings are not bidi-reordered.
7645 (compute_display_string_pos)
7646 (compute_display_string_end): Fix handling the case of C string.
7647 (push_it, pop_it): Save and restore from_disp_prop_p.
7648 (handle_single_display_spec, push_display_prop): Set the
7649 from_disp_prop_p flag.
7650 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7651 (pop_it): Call iterate_out_of_display_property only if we are
7652 popping after iteration over a string that came from a display
7653 property. Fix a typo in popping stretch info. Add an assertion
7654 for verifying that the iterator position is in sync with the bidi
7655 iterator.
7656 (handle_single_display_spec, get_overlay_strings_1)
7657 (push_display_prop): Fix initialization of paragraph direction for
7658 string when that of the parent object is not yet determined.
7659 (reseat_1): Call bidi_init_it to resync the bidi
7660 iterator with IT's position. (Bug#7616)
7661 (find_row_edges): If ROW->start.pos gives position
7662 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7663 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7664 Reset the from_disp_prop_p flag.
7665 (SAVE_IT, RESTORE_IT): New macros.
7666 (pos_visible_p, face_before_or_after_it_pos)
7667 (back_to_previous_visible_line_start)
7668 (move_it_in_display_line_to, move_it_in_display_line)
7669 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7670 (try_scrolling, redisplay_window, display_line): Use them when
7671 saving a temporary copy of the iterator and restoring it back.
7672 (back_to_previous_visible_line_start, reseat_1)
7673 (init_iterator): Empty the bidi cache "stack".
7674 (move_it_in_display_line_to): If iterator ended up at
7675 EOL, but we never saw any buffer positions smaller than
7676 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7677 motion in bidi-reordered lines.
7678 (move_it_in_display_line_to): Record prev_method and prev_pos
7679 immediately before the call to set_iterator_to_next. Fixes cursor
7680 motion in bidi-reordered lines with stretch glyphs and strings
7681 displayed in margins. (Bug#8133) (Bug#8867)
7682 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7683 TO_CHARPOS.
640c8776
SM
7684 (pos_visible_p): Support positions in bidi-reordered lines.
7685 Save and restore bidi cache.
0bb23927
EZ
7686
7687 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7688 (bidi_paragraph_info): Delete unused struct.
7689 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7690 (bidi_cache_start): New variable.
7691 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7692 to zero.
7693 (bidi_cache_fetch_state, bidi_cache_search)
7694 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7695 (bidi_cache_find, bidi_peek_at_next_level)
7696 (bidi_level_of_next_char, bidi_find_other_level_edge)
7697 (bidi_move_to_visually_next): Compare cache index with
7698 bidi_cache_start rather than with zero.
7699 (bidi_fetch_char): Accept new argument STRING; all callers
7700 changed. Support iteration over a string. Support strings with
7701 display properties. Support unibyte strings. Fix the type of
7702 `len' according to what STRING_CHAR_AND_LENGTH expects.
7703 (bidi_paragraph_init, bidi_resolve_explicit_1)
7704 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7705 (bidi_level_of_next_char, bidi_move_to_visually_next):
7706 Support iteration over a string.
0bb23927
EZ
7707 (bidi_set_sor_type, bidi_resolve_explicit_1)
7708 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7709 can now be zero (for strings); special values 0 and -1 were
7710 changed to -1 and -2, respectively.
7711 (bidi_char_at_pos): New function.
7712 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7713 Call it instead of FETCH_MULTIBYTE_CHAR.
7714 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7715 initialized to valid values.
7716 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7717 values.
7718 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7719 the test for valid cached positions. Fix the logic for looking up
7720 the sentinel state in the cache. GCPRO the Lisp string we are
7721 iterating.
7722 (bidi_push_it, bidi_pop_it): New functions.
7723 (bidi_initialize): Initialize the bidi cache start stack pointer.
7724 (bidi_cache_ensure_space): New function, refactored from part of
7725 bidi_cache_iterator_state. Don't assume the required size is just
7726 one BIDI_CACHE_CHUNK away.
7727 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7728 (bidi_count_bytes, bidi_char_at_pos): New functions.
7729 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7730 always valid if bidi_cache_idx is valid.
7731 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7732 is valid if it's going to be used.
7733 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7734 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7735 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7736 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7737 (bidi_find_other_level_edge, bidi_cache_start_stack):
7738 All variables related to cache indices are now EMACS_INT.
c965adc5 7739
0bb23927
EZ
7740 * dispextern.h (struct bidi_string_data): New structure.
7741 (struct bidi_it): New member `string'. Make flag members be 1-bit
7742 fields, and put them last in the struct.
640c8776
SM
7743 (compute_display_string_pos, compute_display_string_end):
7744 Update prototypes.
0bb23927
EZ
7745 (bidi_push_it, bidi_pop_it): Add prototypes.
7746 (struct iterator_stack_entry): New members bidi_p,
7747 paragraph_embedding, and from_disp_prop_p.
7748 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7749 (bidi_shelve_cache, bidi_unshelve_cache):
7750 Declare prototypes.
0bb23927
EZ
7751
7752 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7753 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7754 and vector-like objects.
7755
7756 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7757 cache around display iteration.
7758
7759 * window.c (Fwindow_end, window_scroll_pixel_based)
7760 (displayed_window_lines, Frecenter): Save and restore the bidi
7761 cache around display iteration.
7762
3bbd2265
LMI
77632011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7764
7765 * editfns.c (Fdelete_region): Clarify the use of the named
7766 parameters (bug#6788).
7767
adc47434
MR
77682011-07-14 Martin Rudalics <rudalics@gmx.at>
7769
7770 * indent.c (Fvertical_motion): Set and restore w->pointm when
7771 saving and restoring the window's buffer (Bug#9006).
7772
837c31f8
LMI
77732011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7774
7775 * editfns.c (Fstring_to_char): Clarify just what is returned
7776 (bug#6576). Text by Eli Zaretskii.
7777
ac389d0c
JB
77782011-07-13 Juanma Barranquero <lekktu@gmail.com>
7779
7780 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7781
0be0ce47
EZ
77822011-07-13 Eli Zaretskii <eliz@gnu.org>
7783
7784 * buffer.c (mmap_find): Fix a typo.
7785
cd18e7e3
JB
77862011-07-13 Johan Bockgård <bojohan@gnu.org>
7787
7788 Fix execution of x selection hooks.
7789 * xselect.c (Qx_lost_selection_functions)
7790 (Qx_sent_selection_functions): New vars.
7791 (syms_of_xselect): DEFSYM them.
7792 (x_handle_selection_request): Pass Qx_sent_selection_functions
7793 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7794 (x_handle_selection_clear,x_clear_frame_selections):
7795 Pass Qx_lost_selection_functions rather than
7796 Vx_lost_selection_functions to Frun_hook_with_args.
7797
47ea7f44
PE
77982011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7799
ac389d0c 7800 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7801 The old code sometimes used this field without initializing it.
7802
47ea7f44
PE
7803 * alloc.c (gc_sweep): Don't read past end of array.
7804 In theory, the old code could also have corrupted Emacs internals,
7805 though it'd be very unlikely.
7806
bc985c87
AS
78072011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7808
7809 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7810 argument. (Bug#4026)
bc985c87 7811
0cf34688
LMI
78122011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7813
b3dadd76
LMI
7814 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7815 key" (bug#4257).
7816
0cf34688
LMI
7817 * window.c (Fset_window_start): Doc fix (bug#4199).
7818 (Fset_window_hscroll): Ditto.
7819
270768cd
PE
78202011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7821
077e3dda 7822 Fix minor new problems caught by GCC 4.6.1.
270768cd 7823 * term.c (init_tty): Remove unused local.
490011a6 7824 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7825 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7826 not used otherwise.
270768cd 7827
b1f58454
CY
78282011-07-12 Chong Yidong <cyd@stupidchicken.com>
7829
7830 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7831
22b9578d
LMI
78322011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7833
6e70ab07
LMI
7834 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7835 are the mini-buffer and the echo area (bug#3320).
7836
22b9578d
LMI
7837 * term.c (init_tty): Remove support for supdup, c10 and perq
7838 terminals, which are no longer supported (bug#1482).
7839
8974cc9f
JB
78402011-07-10 Johan Bockgård <bojohan@gnu.org>
7841
7842 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7843
a560d974
JD
78442011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7845
7846 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7847 for non-popups (Bug#3642).
7848
1dae0f0a
AS
78492011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7850
268c2c36 7851 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7852 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7853 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7854 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7855 * data.c (fmod): Likewise.
7856 * dispnew.c (swap_glyphs_in_rows): Likewise.
7857 * emacs.c (memory_warning_signal): Likewise.
7858 * floatfns.c (float_error): Likewise.
7859 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7860 (otf_open, font_otf_capability, generate_otf_features)
7861 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7862 Likewise.
7863 * image.c (pbm_read_file): Likewise.
7864 * indent.c (string_display_width): Likewise.
7865 * intervals.c (check_for_interval, search_for_interval)
7866 (inc_interval_count, count_intervals, root_interval)
7867 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7868 * lread.c (defalias): Likewise.
268c2c36 7869 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7870 * regex.c (set_image_of_range_1, set_image_of_range)
7871 (regex_grow_registers): Likewise.
7872 * sysdep.c (strerror): Likewise.
7873 * termcap.c (valid_filename_p, tprint, main): Likewise.
7874 * tparam.c (main): Likewise.
7875 * unexhp9k800.c (run_time_remap, save_data_space)
7876 (update_file_ptrs, read_header, write_header, calculate_checksum)
7877 (copy_file, copy_rest, display_header): Likewise.
7878 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7879 Likewise.
7880 * xdisp.c (check_it): Likewise.
7881 * xfaces.c (register_color, unregister_color, unregister_colors):
7882 Likewise.
7883 * xfns.c (print_fontset_result): Likewise.
7884 * xrdb.c (member, fatal, main): Likewise.
7885
99033785
PE
78862011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7887
7888 Fix minor problems found by static checking (Bug#9031).
7889 * chartab.c (char_table_set_range, map_sub_char_table):
7890 Remove unused locals.
7891 (uniprop_table): Now static.
7892 * composite.c (_work_char): Remove unused static var.
7893
9cb2ac56
JB
78942011-07-09 Juanma Barranquero <lekktu@gmail.com>
7895
7896 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7897
f25661f0
JD
78982011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7899
7900 * gtkutil.c (qttip_cb): Remove code without function.
7901
8278c4fe
EZ
79022011-07-09 Eli Zaretskii <eliz@gnu.org>
7903
7904 * w32.c (pthread_sigmask): New stub.
7905
1692ae2d 79062011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7907
8a6ebd58 7908 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7909 sigprocmask is portable only for single-threaded applications, and
7910 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7911 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7912 (LIBES): Use it.
7913 * callproc.c (Fcall_process):
7914 * process.c (create_process):
7915 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7916 Use pthread_sigmask, not sigprocmask.
123403e4 7917
1b854618
JD
79182011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7919
7920 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7921 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7922 wrong (Bug#8591).
7923
3fe4b549
JD
79242011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7925
0ce7e563
JD
7926 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7927 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7928 (xg_hide_tooltip): Fix comment.
7929
3fe4b549
JD
7930 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7931 in registerServicesMenuSendTypes.
7932 (validRequestorForSendType): Don't check ns_return_types.
7933
7934 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7935 ns_return_type.
7936
5df75e47
JR
79372011-07-08 Jason Rumney <jasonr@gnu.org>
7938
22610910
JR
7939 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7940 SH_SHOW for hidden windows (Bug#5482).
7941
5df75e47
JR
7942 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7943 frame struct members of non-existent frames (Bug#6284).
7944
699c10bd
JD
79452011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7946
4393663b
JD
7947 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7948 variable firstTime not needed on OSX >= 10.6.
7949 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7950 >= 10.5. Use setKnobProportion, setDoubleValue.
7951
7952 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7953 (MAC_OS_X_VERSION_10_5): Define if not defined.
7954 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7955 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7956 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7957
7958 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 7959 cString and lossyCString on OSX >= 10.4.
4393663b 7960
58179cce 7961 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7962 sizeToFit on OSX >= 10.2.
7963
7964 * nsimage.m (allocInitFromFile): Don't use deprecated method
7965 bestRepresentationForDevice on OSX >= 10.6.
7966
7967 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7968 to avoid warning.
7969
7970 * emacs.c: Declare unexec_init_emacs_zone.
7971
a63e0781
JD
7972 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7973
699c10bd
JD
7974 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7975
7976 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7977 on svcsMenu (Bug#8842).
7978
7979 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7980 ns_return_types.
7981 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7982
7983 * nsterm.m (QUTF8_STRING): Declare.
7984 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7985 (validRequestorForSendType): Return type is (id).
7986 Change indexOfObjectIdenticalTo to indexOfObject.
7987 Check if we have local selection before returning self (Bug#8842).
7988 (writeSelectionToPasteboard): Put local selection into paste board
7989 if we have a local selection (Bug#8842).
7990 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7991
7992 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7993 (ns_get_local_selection): Declare.
7994
54e10184
LMI
79952011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7996
9888ff71
LMI
7997 * keymap.c (describe_map_tree): Don't insert a double newline at
7998 the end of the buffer (bug#1169) and return whether we inserted
7999 something.
8000
54e10184
LMI
8001 * callint.c (Fcall_interactively): Change "reading args" to
8002 "providing args" to try to clarify what it does (bug#1010).
8003
15fa4783
KH
80042011-07-07 Kenichi Handa <handa@m17n.org>
8005
8006 * composite.c (composition_compute_stop_pos): Ignore a static
8007 composition starting before CHARPOS (Bug#8915).
8008
8009 * xdisp.c (handle_composition_prop): Likewise.
8010
a8815b00
EZ
80112011-07-07 Eli Zaretskii <eliz@gnu.org>
8012
8013 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8014 (Bug#9015)
8015
ef7b981d 80162011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8017
8018 * character.h (unicode_category_t): New enum type.
8019
8020 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8021 (Qchar_code_property_table): New variable.
8022 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8023 (UNIPROP_COMPRESSED_FORM_P): New macros.
8024 (char_table_ascii): Uncompress the compressed values.
8025 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8026 Uncompress the compressed values.
ac389d0c 8027 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8028 (char_table_ref_and_range): Uncompress the compressed values.
8029 (sub_char_table_set): New arg is_uniprop. Callers changed.
8030 Uncompress the compressed values.
8031 (sub_char_table_set_range): Args changed. Callers changed.
8032 (char_table_set_range): Adjuted for the above change.
8033 (map_sub_char_table): Delete args default_val and parent. Add arg
8034 top. Give decoded values to a Lisp function.
640c8776 8035 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8036 values to a Lisp function. Gcpro more variables.
8037 (uniprop_table_uncompress)
8038 (uniprop_decode_value_run_length): New functions.
8039 (uniprop_decoder, uniprop_decoder_count): New variables.
8040 (uniprop_get_decoder, uniprop_encode_value_character)
8041 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8042 New functions.
8043 (uniprop_encoder, uniprop_encoder_count): New variables.
8044 (uniprop_get_encoder, uniprop_table)
8045 (Funicode_property_table_internal, Fget_unicode_property_internal)
8046 (Fput_unicode_property_internal): New functions.
8047 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8048 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8049 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8050 char-code-property-alist.
8051
640c8776 8052 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8053 Vunicode_category_table.
8054
640c8776 8055 * font.c (font_range): Adjust for the change of
c805dec0
KH
8056 Vunicode_category_table.
8057
76b397fb
DN
80582011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8059
8060 * m/iris4d.h: Remove file, move contents ...
8061 * s/irix6-5.h: ... here.
8062
22b4128e
PE
80632011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8064
8065 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8066 * alloc.c (mark_buffer):
8067 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8068 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8069 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8070 This isn't true in general, and it's particularly not true
8071 if Emacs is configured with --with-wide-int.
8072 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8073 New macros, used in the buffer.c change.
8074
869795d6
JD
80752011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8076
8077 * xsettings.c: Use both GConf and GSettings if both are available.
8078 (store_config_changed_event): Add comment.
8079 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8080 (store_tool_bar_style_changed): New functions.
5e617bc2 8081 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8082 (struct xsettings): Move font inside HAVE_XFT.
8083 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8084 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8085 Move inside HAVE_XFT.
640c8776 8086 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8087 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8088 also.
8089 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8090 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8091 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8092 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8093 (parse_settings): Move check for font inside HAVE_XFT.
8094 (read_settings, apply_xft_settings): Add comment.
8095 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8096 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8097 call store_font_name_changed.
8098 (xft_settings_event): Add comment.
8099 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8100 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8101 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8102 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8103 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8104 (xsettings_get_system_font, xsettings_get_system_normal_font):
8105 Add comment.
869795d6 8106
d8ed26bd
PE
81072011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8108
8109 Random fixes. E.g., (random) never returned negative values.
8110 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8111 subseconds part to the entropy, as that's a bit more random.
8112 Prefer signed to unsigned, since the signedness doesn't matter and
8113 in general we prefer signed. When given a limit, use a
8114 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8115 latter isn't right if USE_2_TAGS_FOR_INTS.
8116 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8117 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8118
cabf1cac
SM
81192011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8120
8121 * textprop.c (text_property_stickiness):
8122 Obey Vtext_property_default_nonsticky.
8123 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8124 * w32fns.c (syms_of_w32fns):
8125 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8126
6e9b2be9
PE
81272011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8128
8129 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8130 This is more efficient than Ffile_directory_p and avoids a minor race.
8131
90186c68
LMI
81322011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8133
7c301272
LMI
8134 * buffer.c (Foverlay_put): Say what the return value is
8135 (bug#7835).
8136
c4f2d8d4
LMI
8137 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8138 is a directory before asking whether to use the file name
8139 (bug#7564).
ad637907
LMI
8140 (barf_or_query_if_file_exists): Make the "File is a directory"
8141 error be more correct.
c4f2d8d4 8142
90186c68
LMI
8143 * fns.c (Frequire): Remove the mention of the .gz files, since
8144 that's installation-specific, but keep the mention of
8145 `get-load-suffixes'.
8146
da64016e
PE
81472011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8148
8149 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8150 Report string overflow if the output is too long.
8151
7d47b580
JB
81522011-07-04 Juanma Barranquero <lekktu@gmail.com>
8153
a555cb87
JB
8154 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8155 (syms_of_gnutls): Remove duplicate DEFSYM for
8156 Qgnutls_bootprop_verify_hostname_error, an error for
8157 Qgnutls_bootprop_verify_error (which is no longer used).
8158
7d47b580
JB
8159 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8160 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8161 Also (re)move comments that are misplaced or no longer relevant.
8162
1e49bfab
LMI
81632011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8164
8165 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8166
1485f4c0
CY
81672011-07-03 Chong Yidong <cyd@stupidchicken.com>
8168
8169 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8170 and background color parameters if they have been changed.
8171
a9ab721e
LMI
81722011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8173
8174 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8175
cf7cff57
PE
81762011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8177
2e13213d
PE
8178 * xsettings.c (SYSTEM_FONT): Define only when used.
8179 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8180
cf7cff57
PE
8181 * keymap.c (access_keymap_1): Now static.
8182
7a8e04f7
CY
81832011-07-02 Chong Yidong <cyd@stupidchicken.com>
8184
8185 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8186 leave any prefix arg for the up event (Bug#1586).
8187
61352f62
LMI
81882011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8189
69bb1ef7
LMI
8190 * lread.c (syms_of_lread): Mention single symbols defined by
8191 `defvar' or `defconst' (bug#7154).
8192
61352f62 8193 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8194 (Frequire): Mention get-load-suffixes.
61352f62 8195
28545e04
MR
81962011-07-02 Martin Rudalics <rudalics@gmx.at>
8197
8198 * window.h (window): Remove clone_number slot.
8199 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8200 Remove.
8201 (make_parent_window, make_window, saved_window)
8202 (Fset_window_configuration, save_window_save): Don't deal with
8203 clone numbers.
8204 * buffer.c (Qclone_number): Remove declaration.
8205 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8206
3349e122
SM
82072011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8208
8209 Add multiple inheritance to keymaps.
8210 * keymap.c (Fmake_composed_keymap): New function.
8211 (Fset_keymap_parent): Simplify.
8212 (fix_submap_inheritance): Remove.
8213 (access_keymap_1): New function extracted from access_keymap to handle
8214 embedded parents and handle lists of maps.
8215 (access_keymap): Use it.
8216 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8217 (Fcopy_keymap): Handle embedded parents.
8218 (Fcommand_remapping, define_as_prefix): Simplify.
8219 (Fkey_binding): Simplify.
8220 (syms_of_keymap): Move minibuffer-local-completion-map,
8221 minibuffer-local-filename-completion-map,
8222 minibuffer-local-must-match-map, and
8223 minibuffer-local-filename-must-match-map to Elisp.
8224 (syms_of_keymap): Defsubr make-composed-keymap.
8225 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8226 (parse_menu_item): Trivial simplification.
8227
3279eb87
GM
82282011-07-01 Glenn Morris <rgm@gnu.org>
8229
8230 * Makefile.in (SETTINGS_LIBS): Fix typo.
8231
4550efdf
KI
82322011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8233
8234 * coding.c (Fencode_coding_string): Record the last coding system
8235 used, as the function doc string says (bug#8738).
8236
0949d2b6
JD
82372011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8238
8239 * xsettings.c (store_monospaced_changed): Take new font as arg and
8240 check for change against current_mono_font.
8241 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8242 (emacs_settings_constructor, emacs_settings_get_property)
8243 (emacs_settings_set_property, emacs_settings_class_init)
8244 (emacs_settings_init, gsettings_obj): Remove.
8245 (something_changedCB): New function for HAVE_GSETTINGS.
8246 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8247 with value as argument.
8248 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8249 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8250 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8251 "changed".
8252
8253 * xgselect.c: Add defined (HAVE_GSETTINGS).
8254 (xgselect_initialize): Ditto.
8255
8256 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8257 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8258 xg_select.
8259
bbc6b304
PE
82602011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8261
8262 * eval.c (struct backtrace): Simplify and port the data structure.
8263 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8264 signed bit field, as this assumption is not portable and it makes
8265 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8266 "char debug_on_exit : 1" as this is not portable either; instead,
8267 use the portable "unsigned int debug_on_exit : 1". Remove unused
8268 member evalargs. Remove obsolete comments about cc bombing out.
8269
9851bfc5
JD
82702011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8271
51bb811f 8272 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8273 Let HAVE_GSETTINGS override HAVE_GCONF.
8274 (store_monospaced_changed): New function.
8275 (EMACS_SETTINGS): A new type derived from GObject to handle
8276 GSettings notifications.
8277 (emacs_settings_constructor, emacs_settings_get_property)
8278 (emacs_settings_set_property, emacs_settings_class_init):
8279 New functions.
8280 (gsettings_client, gsettings_obj): New variables.
8281 (GSETTINGS_SCHEMA): New define.
8282 (something_changedCB): Call store_monospaced_changed.
8283 (init_gsettings): New function.
8284 (xsettings_initialize): Call init_gsettings.
8285 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8286 to NULL.
8287
640c8776 8288 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8289 GCONF_CFLAGS/LIBS.
8290
5386012d
MR
82912011-06-29 Martin Rudalics <rudalics@gmx.at>
8292
8293 * window.c (resize_root_window, grow_mini_window)
8294 (shrink_mini_window): Rename Qresize_root_window to
8295 Qwindow_resize_root_window and Qresize_root_window_vertically to
8296 Qwindow_resize_root_window_vertically.
8297
f13e0b08
PE
82982011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8299
8300 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8301
94515237
JB
83022011-06-27 Juanma Barranquero <lekktu@gmail.com>
8303
8304 * makefile.w32-in: Redesign dependencies so they reflect more
8305 clearly which files are directly included by each source file,
8306 and not through other includes.
8307
e43b6e43
MR
83082011-06-27 Martin Rudalics <rudalics@gmx.at>
8309
8310 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8311 (sort_overlays, overlay_strings): When an overlay's clone number
8312 matches the window's clone number process the overlay even if
8313 the overlay's window property doesn't match the current window.
8314
d68443dc
MR
8315 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8316 (Fwindow_hchild): Rename to Fwindow_left_child.
8317 (Fwindow_next): Rename to Fwindow_next_sibling.
8318 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8319 (resize_window_check): Rename to window_resize_check.
8320 (resize_window_apply): Rename to window_resize_apply.
8321 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8322 (Fdelete_other_windows_internal, resize_frame_windows)
8323 (Fsplit_window_internal, Fdelete_window_internal)
8324 (grow_mini_window, shrink_mini_window)
8325 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8326
c7e73be5
JD
83272011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8328
8329 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8330 (emacs_fixed_set_min_size): Remove.
8331 (emacs_fixed_new): Take frame as argument.
8332
8333 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8334 (_EmacsFixedPrivate): Remove minwidth/height.
8335 Add struct frame *f.
8336 (emacs_fixed_init): Initialize priv->f.
8337 (get_parent_class, emacs_fixed_set_min_size): Remove.
8338 (emacs_fixed_new): Set priv->f to argument.
8339 (emacs_fixed_get_preferred_width)
8340 (emacs_fixed_get_preferred_height): Use min_width/height from
8341 frames size_hint to set minimum and natural (Bug#8919).
8342 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8343 and use min_width/height from frames size_hint to set
8344 min_width/height (Bug#8919).
8345
8346 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8347 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8348 Fix indentation.
c7e73be5 8349
cf99dcf8
EZ
83502011-06-26 Eli Zaretskii <eliz@gnu.org>
8351
8352 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8353 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8354 called at ZV.
8355
029529ac
CY
83562011-06-26 Chong Yidong <cyd@stupidchicken.com>
8357
8358 * process.c (wait_reading_process_output): Bypass select if
8359 waiting for a cell while ignoring keyboard input, and input is
8360 pending. Suggested by Jan Djärv (Bug#8869).
8361
7a7ef429
PE
83622011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8363
8364 Use gnulib's dup2 module instead of rolling our own.
8365 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8366
11fdef7d 83672011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8368
8369 * dispnew.c (scrolling_window): Before scrolling, turn off a
8370 mouse-highlight in the window being scrolled.
8371
cd3520a4
JB
83722011-06-24 Juanma Barranquero <lekktu@gmail.com>
8373
8374 Move DEFSYM to lisp.h and use everywhere.
8375
8376 * character.h (DEFSYM): Move declaration...
8377 * lisp.h (DEFSYM): ...here.
8378
8379 * gnutls.c:
8380 * minibuf.c:
8381 * w32menu.c:
8382 * w32proc.c:
8383 * w32select.c: Don't include character.h.
8384
8385 * alloc.c (syms_of_alloc):
8386 * buffer.c (syms_of_buffer):
8387 * bytecode.c (syms_of_bytecode):
8388 * callint.c (syms_of_callint):
8389 * casefiddle.c (syms_of_casefiddle):
8390 * casetab.c (init_casetab_once):
8391 * category.c (init_category_once, syms_of_category):
8392 * ccl.c (syms_of_ccl):
8393 * cmds.c (syms_of_cmds):
8394 * composite.c (syms_of_composite):
8395 * dbusbind.c (syms_of_dbusbind):
8396 * dired.c (syms_of_dired):
8397 * dispnew.c (syms_of_display):
8398 * doc.c (syms_of_doc):
8399 * editfns.c (syms_of_editfns):
8400 * emacs.c (syms_of_emacs):
8401 * eval.c (syms_of_eval):
8402 * fileio.c (syms_of_fileio):
8403 * fns.c (syms_of_fns):
8404 * frame.c (syms_of_frame):
8405 * fringe.c (syms_of_fringe):
8406 * insdel.c (syms_of_insdel):
8407 * keymap.c (syms_of_keymap):
8408 * lread.c (init_obarray, syms_of_lread):
8409 * macros.c (syms_of_macros):
8410 * msdos.c (syms_of_msdos):
8411 * print.c (syms_of_print):
8412 * process.c (syms_of_process):
8413 * search.c (syms_of_search):
8414 * sound.c (syms_of_sound):
8415 * syntax.c (init_syntax_once, syms_of_syntax):
8416 * terminal.c (syms_of_terminal):
8417 * textprop.c (syms_of_textprop):
8418 * undo.c (syms_of_undo):
8419 * w32.c (globals_of_w32):
8420 * window.c (syms_of_window):
8421 * xdisp.c (syms_of_xdisp):
8422 * xfaces.c (syms_of_xfaces):
8423 * xfns.c (syms_of_xfns):
8424 * xmenu.c (syms_of_xmenu):
8425 * xsettings.c (syms_of_xsettings):
8426 * xterm.c (syms_of_xterm): Use DEFSYM.
8427
4228cf16
TZ
84282011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8429
cd3520a4 8430 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8431
7fcccf1e
PE
84322011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8433
7efb4e0e
PE
8434 Integer and buffer overflow fixes (Bug#8873).
8435
ff5844ad
PE
8436 * print.c (printchar, strout): Check for string overflow.
8437 (PRINTPREPARE, printchar, strout):
8438 Don't set size unless allocation succeeds.
8439
90532f02
PE
8440 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8441 for sizes. Check for string overflow more accurately.
8442 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8443
6d84508d
PE
8444 * macros.c: Integer and buffer overflow fixes.
8445 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8446 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8447 Use ptrdiff_t, not int, for sizes.
8448 Don't increment bufsize until after realloc succeeds.
8449 Check for size-calculation overflow.
8450 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8451
437b2cb4
PE
8452 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8453
8b9ac8b4
PE
8454 * lread.c: Integer overflow fixes.
8455 (read_integer): Radix is now EMACS_INT, not int,
8456 to improve quality of diagnostics for out-of-range radices.
8457 Calculate buffer size correctly for out-of-range radices.
8458 (read1): Check for integer overflow in radices, and in
8459 read-circle numbers.
82cb60d3
PE
8460 (read_escape): Avoid int overflow.
8461 (Fload, openp, read_buffer_size, read1)
8462 (substitute_object_recurse, read_vector, read_list, map_obarray):
8463 Use ptrdiff_t, not int, for sizes.
8464 (read1): Use EMACS_INT, not int, for sizes.
20270765 8465 Check for size overflow.
8b9ac8b4 8466
7fcccf1e
PE
8467 * image.c (cache_image): Check for size arithmetic overflow.
8468
bfbbd7e7
PE
8469 * lread.c: Integer overflow issues.
8470 (saved_doc_string_size, saved_doc_string_length)
8471 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8472 Now ptrdiff_t, not int.
8473 (read1): Don't assume doc string length fits in int. Check for
8474 out-of-range doc string lengths.
8475 (read_list): Don't assume file position fits in int.
39019e54 8476 (read_escape): Check for hex character overflow.
bfbbd7e7 8477
4e323265
LL
84782011-06-22 Leo Liu <sdl.web@gmail.com>
8479
8480 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8481 Move to minibuffer.el.
8482
85fece3e
PE
84832011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8484
20b84ce9 8485 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8486 The following patches are for when GLYPH_DEBUG && !XASSERT.
8487 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8488 * dispnew.c (flush_stdout):
8489 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8490 Mark as externally visible.
8491 * dispnew.c (check_window_matrix_pointers): Now static.
8492 * dispnew.c (window_to_frame_vpos):
8493 * xfns.c (unwind_create_frame):
8494 * xterm.c (x_check_font): Remove unused local.
8495 * scroll.c (CHECK_BOUNDS):
8496 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8497 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8498 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8499 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8500 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8501 Now static.
8502 (debug_method_add): Use va_list and vsprintf rather than relying
8503 on undefined behavior with wrong number of arguments.
8504 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8505 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8506 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8507 since we're not interested in debugging glyphs with old libraries.
8508 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8509 GCC 4.6.0's static checking.
8510
0766b489
PE
85112011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8512
31fd4b32
PE
8513 Integer overflow and signedness fixes (Bug#8873).
8514 A few related buffer overrun fixes, too.
8515
b79e8648
PE
8516 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8517
0766b489
PE
8518 * dispextern.h (struct face.stipple):
8519 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8520 (x_bitmap_mask, x_allocate_bitmap_record)
8521 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8522 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8523 (x_create_bitmap_from_xpm_data):
8524 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8525 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8526 (.bitmaps_last):
8527 * xfaces.c (load_pixmap):
8528 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8529 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8530 (.bitmaps_last, struct x_output.icon_bitmap):
8531 Use ptrdiff_t, not int, for bitmap indexes.
8532 (x_allocate_bitmap_record): Check for size overflow.
8533 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8534
b081724f
PE
8535 Use ptrdiff_t, not int, for overlay counts.
8536 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8537 * editfns.c (overlays_around, get_pos_property):
8538 * textprop.c (get_char_property_and_overlay):
8539 * xdisp.c (next_overlay_change, note_mouse_highlight):
8540 * xfaces.c (face_at_buffer_position):
21514da7
PE
8541 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8542 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8543 (Fnext_overlay_change, Fprevious_overlay_change)
8544 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8545 Use ptrdiff_t, not int, for sizes.
21514da7 8546 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8547
3de73e5e
PE
8548 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8549
2606c57b
PE
8550 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8551 (x_session_initialize): Do not assume string length fits in int.
8552
aaafe47a
PE
8553 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8554 This is unlikely, but can occur if DPI is outlandish.
8555
2674ddc8 8556 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8557 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8558
28154962
PE
8559 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8560 * xrdb.c (magic_file_p, search_magic_path):
8561 Omit last arg SUFFIX; it was always 0. All callers changed.
8562 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8563
7de51af5
PE
8564 * xfont.c (xfont_match): Avoid need for strlen.
8565
25ed6cc3
PE
8566 * xfns.c: Don't assume strlen fits in int.
8567 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8568
4eab31dd
PE
8569 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8570 not unsigned long, as we prefer signed integers. All callers changed.
8571 Detect integer overflow in repeat count.
8572 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8573 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8574
171e2a58
PE
8575 * termcap.c: Don't assume sizes fit in int and never overflow.
8576 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8577 (gobble_line): Check for size-calculation overflow.
8578
ad39faca 8579 * minibuf.c (Fread_buffer):
6e5bb2dc 8580 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8581 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8582 Don't assume string length fits in int.
8583
52c61c22 8584 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8585 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8586
b5b8c9e5
PE
8587 * font.c: Don't assume string length fits in int.
8588 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8589 Use ptrdiff_t, not int.
ccd6111c
PE
8590 (font_intern_prop): Don't assume string length fits in int.
8591 Don't assume integer property fits in fixnum.
8592 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8593
882f0d81 8594 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8595 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8596 Reformulate so as not to need the command string.
8597 Invoke gzip -cd rather than gunzip, as it's more portable.
8598 (lock_info_type, lock_file_1, lock_file):
8599 Don't assume pid_t and time_t fit in unsigned long.
8600 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8601 (current_lock_owner): Prefer signed type for sizes.
8602 Use memcpy, not strncpy, where memcpy is what is really wanted.
8603 Don't assume (via atoi) that time_t and pid_t fit in int.
8604 Check for time_t and/or pid_t out of range, e.g., via a network share.
8605 Don't alloca where an auto var works fine.
8606
93f4cf88
PE
8607 * fileio.c: Fix some integer overflow issues.
8608 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8609 Don't assume string length fits in int.
8610 (directory_file_name): Don't assume string length fits in long.
8611 (make_temp_name): Don't assume pid fits in int, or that its print
8612 length is less than 20.
8613
f3e92b69
PE
8614 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8615
1bfdaf10
PE
8616 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8617
35016e9a
PE
8618 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8619
3d1e65a1
PE
8620 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8621 We prefer signed integers, even for size calculations.
8622
0b963a93
PE
8623 * emacs.c: Don't assume string length fits in 'int'.
8624 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8625 (main): Don't invoke strlen when not needed.
8626
573f4b54
PE
8627 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8628 (XD_DEBUG_MESSAGE): Don't waste a byte.
8629
989f33ba
PE
8630 * callproc.c (getenv_internal_1, getenv_internal)
8631 (Fgetenv_internal):
965d34eb
PE
8632 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8633
e4d29b33
PE
8634 * lread.c (invalid_syntax): Omit length argument.
8635 All uses changed. This doesn't fix a bug, but it simplifies the
8636 code away from its former Hollerith-constant appearance, and it's
8637 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8638 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8639
eb49b136
PE
8640 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8641 This didn't break anything, but it didn't help either.
8642 It's confusing to put a bogus integer in a place where the actual
8643 value does not matter.
9f62aeb1 8644 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8645 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8646
15375a22
PE
8647 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8648 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8649 implementation.
b61cc01c
PE
8650 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8651 We prefer signed types, and the value cannot exceed the EMACS_INT
8652 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8653 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8654 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8655 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8656
53b2623d
PE
8657 * indent.c (sane_tab_width): New function.
8658 (current_column, scan_for_column, Findent_to, position_indentation)
8659 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8660 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8661
51cab52b 8662 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8663
f2ed8a70
PE
8664 * lisp.h (lint_assume): New macro.
8665 * composite.c (composition_gstring_put_cache):
8666 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8667
abe80cc6
PE
8668 * editfns.c, insdel.c:
8669 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8670
b02c740e
PE
8671 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8672
ebc96716
PE
8673 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8674
b4e50fa0 8675 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8676 Use much-faster test for byte-length change.
311d5d7c 8677 Don't assume string byte-length fits in 'int'.
a4cf38e4 8678 Check that character arg fits in 'int'.
85461888 8679 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8680
c0c1ee9f
PE
8681 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8682
a498d7f4
PE
8683 * fns.c (concat): Catch string overflow earlier.
8684 Do not rely on integer wraparound.
8685
51cab52b
PE
8686 * dispextern.h (struct it.overlay_strings_charpos)
8687 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8688 * xdisp.c (forward_to_next_line_start)
8689 (back_to_previous_visible_line_start)
8690 (reseat_at_next_visible_line_start, next_element_from_buffer):
8691 Don't arbitrarily truncate the value of 'selective' to int.
8692
76031fad
PE
8693 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8694
5eb55db9
PE
8695 * composite.c: Don't truncate sizes to 'int'.
8696 (composition_gstring_p, composition_reseat_it)
8697 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8698 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8699 not EMACS_UINT, for indexes.
5eb55db9 8700
0703a717
PE
8701 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8702
d6202519
PE
8703 * buffer.c: Include <verify.h>.
8704 (struct sortvec.priority, struct sortstr.priority):
8961a454 8705 Now EMACS_INT, not int.
c20998a7 8706 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8707 (struct sortstr.size, record_overlay_string)
8708 (struct sortstrlist.size, struct sortlist.used):
8709 Don't truncate size to int.
8710 (record_overlay_string): Check for size-calculation overflow.
d6202519 8711 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8712
d5a19415
JM
87132011-06-22 Jim Meyering <meyering@redhat.com>
8714
029529ac 8715 Don't leak an XBM-image-sized buffer
d5a19415
JM
8716 * image.c (xbm_load): Free the image buffer after using it.
8717
a9041e6c
PE
87182011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8719
8720 Port to Sun C.
8721 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8722 that Sun C diagnosed.
8723 * fns.c (secure_hash): Fix pointer signedness issue.
8724 * intervals.c (static_offset_intervals): New function.
8725 (offset_intervals): Use it.
8726
7f3f739f
LL
87272011-06-21 Leo Liu <sdl.web@gmail.com>
8728
8729 * deps.mk (fns.o):
8730 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8731 sha512.h.
8732
8733 * fns.c (secure_hash): Rename from crypto_hash_function and change
8734 the first arg to accept symbols.
5b66d427 8735 (Fsecure_hash): New primitive.
7f3f739f
LL
8736 (syms_of_fns): New symbols.
8737
76147d94
DD
87382011-06-20 Deniz Dogan <deniz@dogan.se>
8739
8740 * process.c (Fset_process_buffer): Clarify return value in
8741 docstring.
8742
7d7d0045
CY
87432011-06-18 Chong Yidong <cyd@stupidchicken.com>
8744
8745 * dispnew.c (add_window_display_history): Use BVAR.
8746
8747 * xdisp.c (debug_method_add): Use BVAR.
8748 (check_window_end, dump_glyph_matrix, dump_glyph)
8749 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8750
8751 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8752 Likewise.
8753
8754 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8755 check till after the cache is created in init_frame_faces.
8756
ff2bc410
SM
87572011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8758
8759 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8760
28177add
PE
87612011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8762
dd3482fe
PE
8763 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8764 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8765 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8766
393d71f3 8767 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8768 * fileio.c (Finsert_file_contents):
8769 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8770 Remove the old (too-loose) buffer overflow checks.
8771 They weren't needed, since make_gap checks for buffer overflow.
8772 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8773 The old code merely checked for Emacs fixnum overflow, and relied
8774 on undefined (wraparound) behavior. The new code avoids undefined
8775 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8776
2e6813b0 8777 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8778 Tune. Don't use wider integers than needed. Don't use alloca.
8779 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8780
599a9e4f
PE
8781 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8782
99561444
PE
8783 * insdel.c, lisp.h (buffer_overflow): New function.
8784 (insert_from_buffer_1, replace_range, replace_range_2):
8785 * insdel.c (make_gap_larger):
8786 * editfns.c (Finsert_char):
8787 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8788
28177add
PE
8789 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8790
e69dafad
PE
87912011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8792
4baa020d 8793 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8794
b1c46f02
PE
8795 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8796 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8797
e69dafad
PE
8798 * fileio.c: Don't assume EMACS_INT fits in off_t.
8799 (emacs_lseek): New static function.
8800 (Finsert_file_contents, Fwrite_region): Use it.
8801 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8802
566684ea
PE
8803 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8804
e6966cd6
PE
8805 * fns.c: Don't overflow int when computing a list length.
8806 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8807 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8808 truncation on 64-bit hosts. Check for QUIT every
8809 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8810 faster and is responsive enough.
8811 (Flength): Report an error instead of overflowing an integer.
8812 (Fsafe_length): Return a float if the value is not representable
8813 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8814 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8815 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8816
dd0b0efb
PE
8817 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8818 (header_size, word_size): New constants.
8819 (allocate_vectorlike): Don't check size overflow here.
8820 (allocate_vector): Check it here instead, since this is the only
8821 caller of allocate_vectorlike that could cause overflow.
8822 Check that the new vector's length is representable as a fixnum.
8823
86fe5cfe
PE
8824 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8825 The previous code was bogus. For example, next_almost_prime (32)
8826 returned 39, which is undesirable as it is a multiple of 3; and
8827 next_almost_prime (24) returned 25, which is a multiple of 5 so
8828 why was the code bothering to check for multiples of 7?
8829
80e88859
PE
8830 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8831
4a2f0ad6
PE
8832 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8833
f66c7cf8
PE
8834 Variadic C functions now count arguments with ptrdiff_t.
8835 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8836 Back then I didn't know that the Emacs coding style prefers signed int.
8837 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8838 were being counted with int, which may truncate counts on 64-bit
8839 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8840 * lisp.h (struct Lisp_Subr.function.aMANY)
8841 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8842 Arg counts are now ptrdiff_t, not size_t.
8843 All variadic functions and their callers changed accordingly.
8844 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8845 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8846 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8847 * callint.c (Fcall_interactively): Check arg count for overflow,
8848 to avoid potential buffer overrun. Use signed char, not 'int',
8849 for 'varies' array, so that we needn't bother to check its size
8850 calculation for overflow.
8851 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8852 * eval.c (apply_lambda):
8853 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8854 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8855 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8856
a1759b76
PE
8857 * callint.c (Fcall_interactively): Don't use index var as event count.
8858
d96be9fc
PE
8859 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8860 * mem-limits.h (SIZE): Remove; no longer used.
8861
a690a978 8862 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8863
578c21e6
PE
8864 Remove unnecessary casts.
8865 * xterm.c (x_term_init):
8866 * xfns.c (x_set_border_pixel):
8867 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8868 These aren't needed now that we assume ANSI C.
8869
96f53c6c
PE
8870 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8871 It's more likely to cause problems (due to unsigned overflow)
8872 than to cure them.
8873
83c77d31
PE
8874 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8875
ee2079f1
PE
8876 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8877
6da65536
PE
8878 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8879
7147c4a4
PE
8880 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8881
193e32d9
PE
8882 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8883
e5533da6
PE
8884 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8885
9910e595
PE
8886 GLYPH_CODE_FACE returns EMACS_INT, not int.
8887 * dispextern.h (merge_faces):
8888 * xfaces.c (merge_faces):
01103c44
PE
8889 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8890 Don't assume EMACS_INT fits in int.
9910e595 8891
2638320e
PE
8892 * character.h (CHAR_VALID_P): Remove unused parameter.
8893 * fontset.c, lisp.h, xdisp.c: All uses changed.
8894
045eb8d9
PE
8895 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8896
c1f134b5
PE
8897 * fns.c (concat): Minor tuning based on overflow analysis.
8898 This doesn't fix any bugs. Use int to hold character, instead
8899 of constantly refetching from Emacs object. Use XFASTINT, not
8900 XINT, for value known to be a character. Don't bother comparing
8901 a single byte to 0400, as it's always less.
8902
395fcb93 8903 * floatfns.c (Fexpt):
327eeec8
PE
8904 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8905
abbd3d23
PE
8906 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8907 for characters.
8908
684a03ef
PE
8909 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8910
0fed43f3
PE
8911 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8912 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8913 incorrectly succeed when S was a string, because 4294967386 was
8914 truncated before it was used.
8915
8fd02eb7
PE
8916 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8917 Otherwise, an out-of-range integer could cause undefined behavior
8918 on a 64-bit host.
8919
f8c86b69
PE
8920 * composite.c: Use int, not EMACS_INT, for characters.
8921 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8922 EMACS_INT, for values that are known to be in character range.
8923 This doesn't fix any bugs but is the usual style inside Emacs and
8924 may generate better code on 32-bit machines.
8925
34206dd2
PE
8926 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8927 This is for reasons similar to the recent CHAR_STRING fix.
8928 * charset.c (Fencode_char): Check that character arg is actually
8929 a character. Pass an int to ENCODE_CHAR.
8930 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8931 wider than 'int', as a compile-time check to prevent future regressions
8932 in this area.
8933
c5958d4c 8934 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8935
8936 Make sure a 64-bit char is never passed to CHAR_STRING.
8937 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8938 by silently ignoring the top 32 bits, allowing some values
8939 that were far too large to be valid characters.
8940 * character.h: Include <verify.h>.
8941 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8942 arguments are no wider than unsigned, as a compile-time check
8943 to prevent future regressions in this area.
8944 * data.c (Faset):
01103c44 8945 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8946 (Fsubst_char_in_region):
8947 * fns.c (concat):
8948 * xdisp.c (decode_mode_spec_coding):
8949 Adjust to CHAR_STRING's new requirement.
8950 * editfns.c (Finsert_char, Fsubst_char_in_region):
8951 * fns.c (concat): Check that character args are actually
8952 characters. Without this test, these functions did the wrong
8953 thing with wildly out-of-range values on 64-bit hosts.
8954
d37ca623
PE
8955 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8956 These casts should not be needed on 32-bit hosts, either.
8957 * keyboard.c (read_char):
8958 * lread.c (Fload): Remove casts to unsigned.
8959
ea204efb
PE
8960 * lisp.h (UNSIGNED_CMP): New macro.
8961 This fixes comparison bugs on 64-bit hosts.
8962 (ASCII_CHAR_P): Use it.
8963 * casefiddle.c (casify_object):
01103c44 8964 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8965 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8966 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8967 * dispextern.h (FACE_FROM_ID):
8968 * keyboard.c (read_char): Use UNSIGNED_CMP.
8969
41cb286c
PE
8970 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8971 not to EMACS_INT, to avoid GCC warning.
8972
4a1b9832
PE
8973 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8974
55daad71
PE
8975 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8976 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8977 isn't needed on 32-bit machines.
8f95c75c 8978
01103c44
PE
8979 * buffer.c (Fgenerate_new_buffer_name):
8980 Use EMACS_INT for count, not int.
0ceccced 8981 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8982
8983 * data.c (Qcompiled_function): Now static.
8984
c6f072e7
PE
8985 * window.c (window_body_lines): Now static.
8986
20ce5912
PE
8987 * image.c (gif_load): Rename local to avoid shadowing.
8988
9c4c5f81
PE
8989 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8990 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8991 * alloc.c (make_save_value): Integer argument is now of type
8992 ptrdiff_t, not int.
8993 (mark_object): Use ptrdiff_t, not int.
8994 * lisp.h (pD): New macro.
8995 * print.c (print_object): Use it.
8996
c0c5c8ae
PE
8997 * alloc.c: Use EMACS_INT, not int, to count objects.
8998 (total_conses, total_markers, total_symbols, total_vector_size)
8999 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9000 (total_free_floats, total_floats, total_free_intervals)
9001 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9002 Now EMACS_INT, not int. All uses changed.
9003 (Fgarbage_collect): Compute overall total using a double, so that
9004 integer overflow is less likely to be a problem. Check for overflow
9005 when converting back to an integer.
5a25e253
PE
9006 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9007 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9008 These were 'int' variables that could overflow on 64-bit hosts;
9009 they were never used, so remove them instead of repairing them.
211a0b2a 9010 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9011 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9012 Previously, this ceilinged at INT_MAX, but that doesn't work on
9013 64-bit machines.
e46bb31a 9014 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9015
c78baabf 9016 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9017 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9018 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9019 when a (possibly-narrower) signed value would do just as well.
9020 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9021
c9d624c6
PE
9022 * alloc.c: Catch some string size overflows that we were missing.
9023 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9024 for convenience in STRING_BYTES_MAX.
9025 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9026 The definition here is exact; the one in lisp.h was approximate.
9027 (allocate_string_data): Check for string overflow. This catches
9028 some instances we weren't catching before. Also, it catches
9029 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9030 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9031 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9032
c9d624c6
PE
9033 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9034 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9035 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9036
353032ce
PE
9037 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9038
2bccce07
PE
9039 * alloc.c (Fmake_string): Check for out-of-range init.
9040
0ac30604
SM
90412011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9042
9043 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9044
c195f2de
JD
90452011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9046
9047 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9048 xg_get_default_scrollbar_width.
9049
9050 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9051 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9052 (style_changed_cb): Call update_theme_scrollbar_width and call
9053 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9054 all frames (Bug#8505).
9055 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9056 Call gtk_window_set_resizable if HAVE_GTK3.
9057 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9058 and height if HAVE_GTK3 (Bug#8505).
9059 (scroll_bar_width_for_theme): New variable.
9060 (update_theme_scrollbar_width): New function.
9061 (xg_get_default_scrollbar_width): Move code to
9062 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9063 (xg_initialize): Call update_theme_scrollbar_width.
9064
9065 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9066
9067 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9068
e10ac9f1
MR
90692011-06-12 Martin Rudalics <rudalics@gmx.at>
9070
9071 * frame.c (make_frame): Call other_buffer_safely instead of
9072 other_buffer.
9073
9074 * window.c (temp_output_buffer_show): Call display_buffer with
9075 second argument Vtemp_buffer_show_specifiers and reset latter
9076 immediately after the call.
9077 (Vtemp_buffer_show_specifiers): New variable.
9078 (auto_window_vscroll_p, next_screen_context_lines)
9079 (Vscroll_preserve_screen_position): Remove leading asterisks from
9080 doc-strings.
9081
2d3c217e 90822011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9083
7b7f97e8 9084 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9085 * buffer.c (Qclone_number): Remove for now, as it's unused.
9086 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9087 (record_buffer): Remove unused local.
9088 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9089 (set_frame_buffer_list): Remove; unused.
9090 * frame.h (other_visible_frames): Remove decl.
9091 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9092 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9093 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9094 if HAVE_GPM.
9095 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9096 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9097 Define only if HAVE_GPM.
9098 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9099 (update_hints_inhibit): Remove; never set. All uses removed.
9100 * widgetprv.h (emacsFrameClassRec): Remove decl.
9101 * window.c (delete_deletable_window): Now returns void, since it
9102 wasn't returning anything.
9103 (compare_window_configurations): Remove unused locals.
9104 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9105 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9106 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9107 the same widths as pointers. This follows up on the 2011-05-06 patch.
9108 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9109 * xterm.h: Likewise.
9110 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9111
1384b89e
JB
91122011-06-12 Juanma Barranquero <lekktu@gmail.com>
9113
9114 * makefile.w32-in: Update dependencies.
9115 (LISP_H): Add lib/intprops.h.
9116
1100a63c
CY
91172011-06-11 Chong Yidong <cyd@stupidchicken.com>
9118
9119 * image.c (gif_load): Add animation frame delay to the metadata.
9120 (syms_of_image): Use DEFSYM. New symbol `delay'.
9121
6198ccd0
MR
91222011-06-11 Martin Rudalics <rudalics@gmx.at>
9123
9124 * window.c (delete_deletable_window): Re-add.
9125 (Fset_window_configuration): Rewrite to handle dead buffers and
9126 consequently deletable windows.
9127 (window_tree, Fwindow_tree): Remove. Supply functionality in
9128 window.el.
9129 (compare_window_configurations): Simplify code.
9130
b6e3633c
AS
91312011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9132
1ab0dee5
AS
9133 * image.c (imagemagick_load_image): Fix type mismatch.
9134 (Fimagemagick_types): Likewise.
9135
b6e3633c
AS
9136 * window.h (replace_buffer_in_windows): Declare.
9137
9397e56f
MR
91382011-06-11 Martin Rudalics <rudalics@gmx.at>
9139
9140 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9141 Qclone_number. Remove external declaration of Qdelete_window.
9142 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9143 code.
640c8776
SM
9144 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9145 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9146 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9147 buffer list implementation.
9148 (other_buffer_safely): New function.
9149 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9150 calls to replace_buffer_in_windows and
9151 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9152 if allowed.
9153 (record_buffer): Inhibit quitting and rewrite using quittable
9154 functions. Run Qbuffer_list_update_hook if allowed.
9155 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9156 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9157 Move switch-to-buffer to window.el.
9397e56f
MR
9158 (bury-buffer): Move to window.el.
9159 (Vbuffer_list_update_hook): New variable.
9160
9161 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9162 section.
9163
9164 * window.h (resize_frame_windows): Move up in code.
9165 (Fwindow_frame): Remove EXFUN.
9166 (replace_buffer_in_all_windows): Remove prototype.
9167 (replace_buffer_in_windows_safely): Add prototype.
9168
9169 * window.c: Declare Qdelete_window static again. Move down
9170 declaration of select_count.
9171 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9172 (Fother_window): Move to window.el.
9173 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9174 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9175 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9176 window.el.
9177 (replace_buffer_in_windows): Implement by calling
9178 Qreplace_buffer_in_windows.
9179 (replace_buffer_in_all_windows): Remove with some functionality
9180 moved into replace_buffer_in_windows_safely.
9181 (replace_buffer_in_windows_safely): New function.
9182 (select_window_norecord, select_frame_norecord): Move in front
9183 of run_window_configuration_change_hook. Remove now obsolete
9184 declarations.
640c8776
SM
9185 (Fset_window_buffer): Rewrite doc-string.
9186 Call Qrecord_window_buffer.
9397e56f
MR
9187 (keys_of_window): Move binding for other-window to window.el.
9188
b50691aa
CY
91892011-06-11 Chong Yidong <cyd@stupidchicken.com>
9190
9191 * dispextern.h (struct image): Replace data member, whose int_val
9192 and ptr_val fields were not used by anything, with a single
9193 lisp_val object.
9194
9195 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9196 (gif_clear_image, gif_load, imagemagick_load_image)
9197 (gs_clear_image, gs_load): Callers changed.
9198
3f754b86
PE
91992011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9200
cca69397
PE
9201 * buffer.h: Include <time.h>, for time_t.
9202 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9203
109e28d0
PE
9204 Fix minor problems found by static checking.
9205
60737f02
PE
9206 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9207
4b66faf3
PE
9208 Make identifiers static if they are not used in other modules.
9209 * data.c (Qcompiled_function, Qframe, Qvector):
9210 * image.c (QimageMagick, Qsvg):
9211 * minibuf.c (Qmetadata):
9212 * window.c (resize_window_check, resize_root_window): Now static.
9213 * window.h (resize_window_check, resize_root_window): Remove decls.
9214
109e28d0
PE
9215 * window.c (window_deletion_count, delete_deletable_window):
9216 Remove; unused.
46a4ce9e
PE
9217 (window_body_lines): Now static.
9218 (Fdelete_other_windows_internal): Mark vars as initialized.
9219 Make sure 'resize_failed' is initialized.
9220 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9221 (resize_window_apply): Remove unused local.
9222 * window.h (delete_deletable_window): Remove decl.
9223
109e28d0 9224 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9225 (imagemagick_load_image): Fix pointer signedness problem by changing
9226 last arg from unsigned char * to char *. All uses changed.
9227 Also, fix a local for similar reasons.
9228 Remove unused locals. Remove locals to avoid shadowing.
9229 (fn_rsvg_handle_free): Remove; unused.
9230 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9231 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9232
3f754b86
PE
9233 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9234
2547adb1
CY
92352011-06-10 Chong Yidong <cyd@stupidchicken.com>
9236
9237 * image.c (gif_load): Fix omitted cast error introduced by
9238 2011-06-06 change.
9239
2c8e37d4
MR
92402011-06-10 Martin Rudalics <rudalics@gmx.at>
9241
9242 * window.h (resize_proportionally, orig_total_lines)
9243 (orig_top_line): Remove from window structure.
9244 (set_window_height, set_window_width, change_window_heights)
9245 (Fdelete_window): Remove prototypes.
9246 (resize_frame_windows): Remove duplicate declaration.
9247
440a42e3
EZ
92482011-06-10 Eli Zaretskii <eliz@gnu.org>
9249
9250 * window.h (resize_frame_windows, resize_window_check)
9251 (delete_deletable_window, resize_root_window)
9252 (resize_frame_windows): Declare prototypes.
9253
9254 * window.c (resize_window_apply): Make definition be "static" to
9255 match the prototype.
9256
562dd5e9
MR
92572011-06-10 Martin Rudalics <rudalics@gmx.at>
9258
9259 * window.c: Remove declarations of Qwindow_size_fixed,
9260 window_min_size_1, window_min_size_2, window_min_size,
9261 size_window, window_fixed_size_p, enlarge_window, delete_window.
9262 Remove static from declaration of Qdelete_window, it's
9263 temporarily needed by Fbury_buffer.
9264 (replace_window): Don't assign orig_top_line and
9265 orig_total_lines.
9266 (Fdelete_window, delete_window): Remove. Window deletion is
9267 handled by window.el.
640c8776
SM
9268 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9269 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9270 (Fdelete_other_windows): Remove. Deleting other windows is
9271 handled by window.el.
9272 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9273 handled in window.el.
9274 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9275 Window minimum sizes are handled in window.el.
9276 (shrink_windows, size_window, set_window_height)
9277 (set_window_width, change_window_heights, window_height)
9278 (window_width, CURBEG, CURSIZE, enlarge_window)
9279 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9280 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9281 handled in window.el.
9282 (make_dummy_parent): Rename to make_parent_window and give it a
9283 second argument horflag.
9284 (make_window): Don't set resize_proportionally any more.
9285 (Fsplit_window): Remove. Windows are split in window.el.
9286 (save_restore_action, save_restore_orig_size)
9287 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9288 Resize mini windows in window.el.
9289 (grow_mini_window, shrink_mini_window): Implement by calling
9290 Qresize_root_window_vertically, resize_window_check and
9291 resize_window_apply.
640c8776
SM
9292 (saved_window, Fset_window_configuration, save_window_save):
9293 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9294 resize_proportionally.
9295 (window_min_height, window_min_width): Move to window.el.
9296 (keys_of_window): Move bindings for delete-other-windows,
9297 split-window, delete-window and enlarge-window to window.el.
9298
9299 * buffer.c: Temporarily extern Qdelete_window.
9300 (Fbury_buffer): Temporarily call Qdelete_window instead of
9301 Fdelete_window (Fbury_buffer will move to window.el soon).
9302
9303 * frame.c (set_menu_bar_lines_1): Remove code handling
9304 orig_top_line and orig_total_lines.
9305
9306 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9307 set_window_height but set heights directly.
9308 (change_frame_size_1): Use resize_frame_windows.
9309
9310 * xdisp.c (init_xdisp): Don't use set_window_height but set
9311 heights directly.
9312
640c8776
SM
9313 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9314 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9315 run_window_configuration_change_hook.
9316
9317 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9318 instead of change_window_heights and run
9319 run_window_configuration_change_hook.
9320
1a13852e
MR
93212011-06-09 Martin Rudalics <rudalics@gmx.at>
9322
9323 * window.c (replace_window): Rename second argument REPLACEMENT to
9324 NEW. New third argument SETFLAG. Rewrite.
9325 (delete_window, make_dummy_parent): Call replace_window with
9326 third argument 1.
9327 (window_list_1): Move down in code.
9328 (run_window_configuration_change_hook): Move set_buffer part
9329 before select_frame_norecord part in order to unwind correctly.
9330 Rename count1 to count.
9331 (recombine_windows, delete_deletable_window, resize_root_window)
9332 (Fdelete_other_windows_internal)
9333 (Frun_window_configuration_change_hook, make_parent_window)
9334 (resize_window_check, resize_window_apply, Fresize_window_apply)
9335 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9336 (Fdelete_window_internal, Fresize_mini_window_internal):
9337 New functions.
1a13852e
MR
9338 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9339
f3d1777e
MR
93402011-06-08 Martin Rudalics <rudalics@gmx.at>
9341
496e208e
MR
9342 * window.h (window): Add some new members to window structure -
9343 normal_lines, normal_cols, new_total, new_normal, clone_number,
9344 splits, nest, prev_buffers, next_buffers.
9345 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9346 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9347
f3d1777e
MR
9348 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9349 Remove.
496e208e
MR
9350 (make_dummy_parent): Set new members of windows structure.
9351 (make_window): Move down in code. Handle new members of window
9352 structure.
9353 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9354 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9355 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9356 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9357 (Fset_window_next_buffers, Fset_window_clone_number):
9358 New functions.
496e208e
MR
9359 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9360 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9361 Doc-string fixes.
9362 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9363 Argument WINDOW can be now internal window too.
9364 (Fwindow_use_time): Move up in code.
9365 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9366 Rewrite doc-string.
9367 (Fset_window_configuration, saved_window)
9368 (Fcurrent_window_configuration, save_window_save): Handle new
9369 members of window structure.
b9e809c2
MR
9370 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9371 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9372 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9373 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9374 Qget_mru_window, Qresize_root_window,
9375 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9376 Qauto_buffer_name; staticpro them.
f3d1777e 9377
abde8f8c
MR
93782011-06-07 Martin Rudalics <rudalics@gmx.at>
9379
9380 * window.c (Fwindow_total_size, Fwindow_left_column)
9381 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9382 (Fwindow_list_1): New functions.
9383 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9384 (Fwindow_width, Fscroll_left, Fscroll_right):
9385 Use window_body_cols instead of window_box_text_cols.
9386 (delete_window, Fset_window_configuration):
9387 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9388 (delete_all_subwindows): Take a window as argument and not a
9389 structure. Rewrite.
190b47e6
MR
9390 (window_loop): Remove handling of GET_LRU_WINDOW and
9391 GET_LARGEST_WINDOW.
9392 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9393
9394 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9395 window_box_text_cols. delete_all_subwindows now takes a
9396 Lisp_Object as argument.
abde8f8c 9397
640c8776
SM
9398 * indent.c (compute_motion, Fcompute_motion):
9399 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9400
fa8a67e6
MR
9401 * frame.c (delete_frame): Call delete_all_subwindows with root
9402 window as argument.
9403
a54e3482
DC
94042011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9405
9406 * fns.c (Fputhash): Document return value.
9407
60002bf5
CY
94082011-06-06 Chong Yidong <cyd@stupidchicken.com>
9409
9410 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9411
0c671da6 94122011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9413
b862a52a 9414 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9415
be44ca6c
PE
9416 Check for overflow when converting integer to cons and back.
9417 * charset.c (Fdefine_charset_internal, Fdecode_char):
9418 Use cons_to_unsigned to catch overflow.
9419 (Fencode_char): Use INTEGER_TO_CONS.
9420 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9421 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9422 * data.c (long_to_cons, cons_to_long): Remove.
9423 (cons_to_unsigned, cons_to_signed): New functions.
9424 These signal an error for invalid or out-of-range values.
9425 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9426 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9427 * font.c (Ffont_variation_glyphs):
9428 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9429 * lisp.h: Include <intprops.h>.
9430 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9431 (cons_to_signed, cons_to_unsigned): New decls.
9432 (long_to_cons, cons_to_long): Remove decls.
9433 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9434 (Fprimitive_undo): Use CONS_TO_INTEGER.
9435 * xfns.c (Fx_window_property): Likewise.
9436 * xselect.c: Include <limits.h>.
9437 (x_own_selection, selection_data_to_lisp_data):
9438 Use INTEGER_TO_CONS.
9439 (x_handle_selection_request, x_handle_selection_clear)
9440 (x_get_foreign_selection, Fx_disown_selection_internal)
9441 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9442 (lisp_data_to_selection_data): Use cons_to_unsigned.
9443 (x_fill_property_data): Use cons_to_signed.
9444 Report values out of range.
9445
d1f3d2af
PE
9446 Check for buffer and string overflow more precisely.
9447 * buffer.h (BUF_BYTES_MAX): New macro.
9448 * lisp.h (STRING_BYTES_MAX): New macro.
9449 * alloc.c (Fmake_string):
9450 * character.c (string_escape_byte8):
9451 * coding.c (coding_alloc_by_realloc):
9452 * doprnt.c (doprnt):
9453 * editfns.c (Fformat):
9454 * eval.c (verror):
9455 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9456 since they may not be the same number.
9457 * editfns.c (Finsert_char):
9458 * fileio.c (Finsert_file_contents):
9459 Likewise for BUF_BYTES_MAX.
9460
dd52fcea
PE
9461 * image.c: Use ptrdiff_t, not int, for sizes.
9462 (slurp_file): Switch from int to ptrdiff_t.
9463 All uses changed.
9464 (slurp_file): Check that file size fits in both size_t (for
9465 malloc) and ptrdiff_t (for sanity and safety).
9466
7f9bbdbb
PE
9467 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9468 if b->modtime has its maximal value.
9469
dfe18f82
PE
9470 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9471
84acfcf0
PE
9472 Don't assume time_t can fit into int.
9473 * buffer.h (struct buffer.modtime): Now time_t, not int.
9474 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9475 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9476
ccd9a01a
PE
9477 Minor fixes for signed vs unsigned integers.
9478 * character.h (MAYBE_UNIFY_CHAR):
9479 * charset.c (maybe_unify_char):
9480 * keyboard.c (read_char, reorder_modifiers):
9481 XINT -> XFASTINT, since the integer must be nonnegative.
9482 * ftfont.c (ftfont_spec_pattern):
9483 * keymap.c (access_keymap, silly_event_symbol_error):
9484 XUINT -> XFASTINT, since the integer must be nonnegative.
9485 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9486 since it makes no difference and we prefer signed.
9487 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9488 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9489 nonnegative.
9490
d6d100dd
SM
94912011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9492
9493 * window.h (Fwindow_frame): Declare.
9494
2b6148e4
PE
94952011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9496
9497 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9498 (SPARE_MEMORY): Always define.
9499 (LARGE_REQUEST): Remove.
9500 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9501
f230ecc9
MR
95022011-06-06 Martin Rudalics <rudalics@gmx.at>
9503
727e958e
MR
9504 * lisp.h: Move EXFUNS for Fframe_root_window,
9505 Fframe_first_window and Fset_frame_selected_window to window.h.
9506
9507 * window.h: Move EXFUNS for Fframe_root_window,
9508 Fframe_first_window and Fset_frame_selected_window here from
9509 lisp.h.
9510
9511 * frame.c (Fwindow_frame, Fframe_first_window)
9512 (Fframe_root_window, Fframe_selected_window)
9513 (Fset_frame_selected_window): Move to window.c.
9514 (Factive_minibuffer_window): Move to minibuf.c.
9515 (Fother_visible_frames_p): New function.
9516
9517 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9518
f230ecc9
MR
9519 * window.c (decode_window, decode_any_window): Move up in code.
9520 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9521 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9522 (Fwindow_buffer): Move up and rewrite doc-string.
9523 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9524 (Fwindow_prev): New functions.
727e958e
MR
9525 (Fwindow_frame): Move here from frame.c. Accept any window as
9526 argument.
9527 (Fframe_root_window, Fframe_first_window)
9528 (Fframe_selected_window): Move here from frame.c. Accept frame
9529 or arbitrary window as argument. Update doc-strings.
9530 (Fminibuffer_window): Move up in code.
9531 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9532 (Fset_frame_selected_window): Move here from frame.c.
9533 Marginal rewrite.
727e958e
MR
9534 (Fselected_window, select_window, Fselect_window): Move up in
9535 code. Minor doc-string fixes.
f230ecc9 9536
4d09bcf6
PE
95372011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9538
9539 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9540 Do not assume that spare memory exists; that assumption is valid
9541 only if SYSTEM_MALLOC.
9542 (LARGE_REQUEST): New macro, so that the issue of large requests
9543 is separated from the issue of spare memory.
9544
810928a2
AS
95452011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9546
172418ad
AS
9547 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9548 format. (Bug#8806)
9549
43f862f7
AS
9550 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9551
810928a2
AS
9552 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9553 before statements.
9554
a059fe24
JD
95552011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9556
9557 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9558
9559 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9560
9561 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9562 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9563
989bf368
JB
95642011-06-05 Juanma Barranquero <lekktu@gmail.com>
9565
9566 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9567
4b80f674
CY
95682011-06-04 Chong Yidong <cyd@stupidchicken.com>
9569
9570 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9571 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9572 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9573 New error handlers.
4b80f674
CY
9574 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9575 Obey Vx_select_enable_clipboard_manager. Catch errors in
9576 x_clipboard_manager_save (Bug#8779).
9577 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9578 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9579
99a33b77 95802011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9581
9582 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9583
99a33b77 95842011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9585
9586 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9587 in the current matrix if keep_current_p is non-zero.
9588
8264569d
EZ
95892011-06-04 Eli Zaretskii <eliz@gnu.org>
9590
9591 * bidi.c (bidi_level_of_next_char): Fix last change.
9592
57f97249
EZ
95932011-06-03 Eli Zaretskii <eliz@gnu.org>
9594
fec2107c 9595 Support bidi reordering of text covered by display properties.
57f97249 9596
fec2107c
EZ
9597 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9598 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9599 (bidi_cache_search, bidi_cache_iterator_state)
9600 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9601 (bidi_level_of_next_char, bidi_move_to_visually_next):
9602 Support character positions inside a run of characters covered by a
fec2107c
EZ
9603 display string.
9604 (bidi_paragraph_init, bidi_resolve_explicit_1)
9605 (bidi_level_of_next_char): Call bidi_fetch_char and
9606 bidi_fetch_char_advance instead of FETCH_CHAR and
9607 FETCH_CHAR_ADVANCE.
9608 (bidi_init_it): Initialize new members.
9609 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9610 definitions.
9611 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9612 instead of using explicit *_CHAR codes.
d6d100dd
SM
9613 (bidi_resolve_explicit, bidi_resolve_weak):
9614 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9615 bidirectional text is supported only in multibyte buffers.
9616 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9617 it to initialize the frame_window_p member of struct bidi_it.
9618 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9619 (bidi_resolve_explicit, bidi_resolve_weak)
9620 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9621 bidi_it->nchars is non-positive.
9622 (bidi_level_of_next_char): Don't try to lookup the cache for the
9623 next/previous character if nothing is cached there yet, or if we
9624 were just reseat()'ed to a new position.
c40e2fb2 9625
0e14fe90
EZ
9626 * xdisp.c (set_cursor_from_row): Set start and stop points
9627 according to the row's direction when priming the loop that looks
9628 for the glyph on which to display cursor.
9629 (single_display_spec_intangible_p): Function deleted.
9630 (display_prop_intangible_p): Reimplement to call
9631 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9632 Accept 3 additional arguments needed by handle_display_spec.
9633 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9634 values: lists, `(when COND...)' forms, etc.
9635 (single_display_spec_string_p): Support property values that are
9636 lists with the argument STRING its top-level element.
9637 (display_prop_string_p): Fix the condition for processing a
9638 property that is a list to be consistent with handle_display_spec.
fec2107c 9639 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9640 last portion of handle_display_prop.
9641 (compute_display_string_pos): Accept additional argument
9642 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9643 value of a `display' property is a "replacing spec".
9644 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9645 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9646 the display property, but just return a value indicating whether
9647 the display property will replace the characters it covers.
9648 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9649 frame_window_p members of struct bidi_it.
d6d100dd
SM
9650 (compute_display_string_pos, compute_display_string_end):
9651 New functions.
fec2107c
EZ
9652 (push_it): Accept second argument POSITION, where pop_it should
9653 jump to continue iteration.
9654 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9655
fec2107c
EZ
9656 * keyboard.c (adjust_point_for_property): Adjust the call to
9657 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9658
9659 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9660 (bidi_init_it): Update prototypes.
9661 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9662 (compute_display_string_pos, compute_display_string_end):
9663 Declare prototypes.
fec2107c
EZ
9664 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9665 EMACS_INT.
fc6f18ce 9666
40087514 96672011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9668
57f53182
PE
9669 Malloc failure behavior now depends on size of allocation.
9670 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9671 * lisp.h: Change signatures accordingly.
9672 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9673 All callers changed. (Bug#8762)
9674
9675 * gnutls.c: Use Emacs's memory allocators.
9676 Without this change, the gnutls library would invoke malloc etc.
9677 directly, which causes problems on non-SYNC_INPUT hosts, and which
9678 runs afoul of improving memory_full behavior. (Bug#8761)
9679 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9680 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9681 xfree instead of the default malloc, realloc, free.
9682 (Fgnutls_boot): No need to check for memory allocation failure,
9683 since xmalloc does that for us.
9684
ac32cd99 9685 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9686 * category.c (hash_get_category_set):
9687 * ccl.c (ccl_driver):
9688 * charset.c (Fdefine_charset_internal):
9689 * charset.h (struct charset.hash_index):
9690 * composite.c (get_composition_id, gstring_lookup_cache)
9691 (composition_gstring_put_cache):
9692 * composite.h (struct composition.hash_index):
9693 * dispextern.h (struct image.hash):
9694 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9695 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9696 (hashfn_equal, hashfn_user_defined, make_hash_table)
9697 (maybe_resize_hash_table, hash_lookup, hash_put)
9698 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9699 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9700 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9701 * image.c (make_image, search_image_cache, lookup_image)
9702 (xpm_put_color_table_h):
9703 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9704 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9705 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9706 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9707 * alloc.c (allocate_vectorlike):
9708 Check for overflow in vector size calculations.
9709 * ccl.c (ccl_driver):
9710 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9711 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9712 need to be updated by these changes.
40087514
PE
9713 * fns.c (make_hash_table, maybe_resize_hash_table):
9714 Check for integer overflow with large hash tables.
0de4bb68
PE
9715 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9716 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9717 (SXHASH_REDUCE): New macro.
9718 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9719 Use it instead of discarding useful hash info with large hash values.
9720 (sxhash_float): New function.
9721 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9722 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9723 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9724 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9725 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9726 Adjust signatures to match updated version of code.
9727 (consing_since_gc): Now EMACS_INT, since a single hash table can
9728 use more than INT_MAX bytes.
9729
698d32e2
DN
97302011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9731
9732 Make it possible to build with GCC-4.6+ -O2 -flto.
9733
9734 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9735
fd6fa53f
SM
97362011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9737
9738 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9739 Call minibuffer-inactive-mode.
9740
864db017
JB
97412011-05-31 Juanma Barranquero <lekktu@gmail.com>
9742
9743 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9744 Update dependencies.
9745
2ad0baf4
DN
97462011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9747
9748 * data.c (init_data): Remove code for UTS, this system is not
9749 supported anymore.
9750
4fcc2638
DN
97512011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9752
9753 Don't force ./temacs to start in terminal mode.
9754
9755 * frame.c (make_initial_frame): Initialize faces in all cases, not
9756 only when CANNOT_DUMP is defined.
9757 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9758
c56e0fd5
DN
97592011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9760
9761 * dispnew.c (add_window_display_history): Use const for the string
9762 pointer. Remove declaration, not needed.
9763
333d54da 97642011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9765
55d4c1b2 9766 Use 'inline', not 'INLINE'.
333d54da 9767 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9768 * alloc.c, fontset.c (INLINE): Remove.
9769 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9770 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9771 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9772 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9773 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9774
738db178
DN
97752011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9776
9777 Make it possible to run ./temacs.
9778
9779 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9780 syms_of_callproc does the same thing. Remove test for
9781 "initialized", do it in the caller.
9782 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9783
620c53a6
SM
97842011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9785
9786 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9787 (read_minibuf): Use get_minibuffer.
9788 (syms_of_minibuf): Use DEFSYM.
9789 (Qmetadata): New var.
9790 * data.c (Qbuffer): Don't make it static.
9791 (syms_of_data): Use DEFSYM.
9792
e003a292
PE
97932011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9794
9795 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9796 (CCL_CODE_MIN): New macro.
9797
ed008a6d
PE
97982011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9799
3687c2ef
PE
9800 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9801
ed008a6d
PE
9802 * eval.c (Qdebug): Now static.
9803 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9804 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9805 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9806
d66c4c7c
CY
98072011-05-29 Chong Yidong <cyd@stupidchicken.com>
9808
9809 * image.c: Various fixes to ImageMagick code comments.
9810 (Fimagemagick_types): Doc fix.
9811
5fbc2025
PE
98122011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9813
0196f88a
PE
9814 Minor fixes prompted by GCC 4.6.0 warnings.
9815
9816 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9817
5fbc2025
PE
9818 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9819 (x_clipboard_manager_save_all): Move extern decl to ...
9820 * xterm.h: ... here, so that it can be checked for consistency.
9821
1dd3c2d9
CY
98222011-05-29 Chong Yidong <cyd@stupidchicken.com>
9823
9824 * xselect.c (x_clipboard_manager_save_frame)
9825 (x_clipboard_manager_save_all): New functions.
9826 (Fx_clipboard_manager_save): Lisp function deleted.
9827
9828 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9829 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9830
9831 * xterm.h: Update prototype.
9832
5ba6571d
WX
98332011-05-28 William Xu <william.xwl@gmail.com>
9834
9835 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9836 exiting (Bug#8239).
9837
3eaff834
JM
98382011-05-28 Jim Meyering <meyering@redhat.com>
9839
e1900994 9840 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9841 * fns.c (to_uchar): Define.
9842 (crypto_hash_function): Use it to convert some newly-signed
9843 variables to unsigned, to avoid sign-extension bugs. For example,
9844 without this change, (md5 "truc") would evaluate to
9845 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9846 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9847 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9848
0f6990a7
PE
98492011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9850
9851 Integer overflow fixes.
c8a9ca5a 9852
08686060
PE
9853 * dbusbind.c: Serial number integer overflow fixes.
9854 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9855 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9856 to hold a serial number that is too large for a fixnum.
9857 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9858 Check for serial numbers out of range. Decode any serial number
59568bf0 9859 that was so large that it became a float. (Bug#8722)
08686060 9860
2d1fc3c7
PE
9861 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9862 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9863 Use XFASTINT rather than XUINT when numbers are nonnegative.
9864 (xd_append_arg, Fdbus_method_return_internal):
9865 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9866 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9867 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9868 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9869 (Bug#8722)
2d1fc3c7 9870
c8a9ca5a
PE
9871 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9872
519e1d69
PE
9873 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9874
6df6ae42 9875 ccl: Add integer overflow checks.
30569699
PE
9876 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9877 (IN_INT_RANGE): New macros.
9878 (ccl_driver): Use them to check for integer overflow when
9879 decoding a CCL program. Many of the new checks are whether XINT (x)
9880 fits in int; it doesn't always, on 64-bit hosts. The new version
9881 doesn't catch all possible integer overflows, but it's an
847044ea 9882 improvement. (Bug#8719)
30569699 9883
c11285dc
PE
9884 * alloc.c (make_event_array): Use XINT, not XUINT.
9885 There's no need for unsigned here.
9886
fdccd48e
PE
9887 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9888 This follows up to the 2011-05-06 change that substituted uintptr_t
9889 for EMACS_INT. This case wasn't caught back then.
9890
37910ab2
PE
9891 Rework Fformat to avoid integer overflow issues.
9892 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9893 now (part of C89). Include <verify.h>.
9894 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9895 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9896 (Fformat): Avoid the prepass trying to compute sizes; it was only
9897 approximate and thus did not catch overflow reliably. Instead, walk
9898 through the format just once, formatting and computing sizes as we go,
9899 checking for integer overflow at every step, and allocating a larger
9900 buffer as needed. Keep track separately whether the format is
9901 multibyte. Keep only the most-recently calculated precision, rather
9902 than them all. Record whether each argument has been converted to
9903 string. Use EMACS_INT, not int, for byte and char and arg counts.
9904 Support field widths and precisions larger than INT_MAX. Avoid
9905 sprintf's undefined behavior with conversion specifications such as %#d
9906 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9907 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9908 formatting out-of-range floating point numbers with int
9173deec 9909 formats. (Bug#8668)
37910ab2 9910
2e6578fb
PE
9911 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9912
0ae6bdee
PE
9913 * data.c: Avoid integer truncation in expressions involving floats.
9914 * data.c: Include <intprops.h>.
9915 (arith_driver): When there's an integer overflow in an expression
9916 involving floating point, convert the integers to floating point
9917 so that the resulting value does not suffer from catastrophic
9918 integer truncation. For example, on a 64-bit host (* 4
9919 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9920 Do not rely on undefined behavior after integer overflow.
9921
de883a70
PE
9922 merge count_size_as_multibyte, parse_str_to_multibyte
9923 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9924 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9925 Check for integer overflow.
9926 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9927 since it's now a duplicate of the other. This is more of
9928 a character than a buffer op, so better that it's in character.c.
9929 * fns.c, print.c: Adjust to above changes.
9930
2ff916cb
PE
99312011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9932
9933 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9934
f1b54466
PE
99352011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9936
fb1ac845
PE
9937 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9938 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9939 (x_clipboard_manager_save): Now static.
9940 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9941
f1b54466
PE
9942 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9943 (crypto_hash_function): Now static.
9944 Fix pointer signedness problems. Avoid unnecessary initializations.
9945
a9f737ee
CY
99462011-05-27 Chong Yidong <cyd@stupidchicken.com>
9947
9948 * termhooks.h (Vselection_alist): Make it terminal-local.
9949
9950 * terminal.c (create_terminal): Initialize it.
9951
9952 * xselect.c: Support for clipboard managers.
9953 (Vselection_alist): Move to termhooks.h as terminal-local var.
9954 (LOCAL_SELECTION): New macro.
9955 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9956 (symbol_to_x_atom): Remove gratuitous arg.
9957 (x_handle_selection_request, lisp_data_to_selection_data)
9958 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9959 (x_own_selection, x_get_local_selection, x_convert_selection):
9960 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9961 (some_frame_on_display): Delete unused function.
9962 (Fx_own_selection_internal, Fx_get_selection_internal)
9963 (Fx_disown_selection_internal, Fx_selection_owner_p)
9964 (Fx_selection_exists_p): New optional frame arg.
9965 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9966 (x_handle_selection_clear): Don't treat other terminals with the
9967 same keyboard specially. Use the terminal-local Vselection_alist.
9968 (x_clear_frame_selections): Use Frun_hook_with_args.
9969
9970 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9971
9972 * xterm.h: Add support for those atoms.
9973
e067f0c1
CY
99742011-05-26 Chong Yidong <cyd@stupidchicken.com>
9975
9976 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9977 (converted_selections, conversion_fail_tag): New global variables.
9978 (x_selection_request_lisp_error): Free the above.
9979 (x_get_local_selection): Remove unnecessary code.
9980 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9981 of converted selections stored in converted_selections.
9982 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9983 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9984 (x_convert_selection): New function.
9985 (x_handle_selection_event): Simplify.
9986 (x_get_foreign_selection): Don't ignore incoming requests while
9987 waiting for an answer; this will fail when we implement
9988 SAVE_TARGETS, and seems unnecessary anyway.
9989 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9990 (Vx_sent_selection_functions): Doc fix.
9991
0f4aebc0
LL
99922011-05-26 Leo Liu <sdl.web@gmail.com>
9993
9994 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9995
e61124cd
YM
99962011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9997
9998 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9999
10000 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10001 for fringe update if it has periodic bitmap.
ac389d0c 10002 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10003 and fringe_bitmap_periodic_p.
10004
10005 * fringe.c (get_fringe_bitmap_data): New function.
10006 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10007 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10008 row. Mark glyph row for fringe update if periodicity changed.
10009
10010 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10011 for fringe update unless it has periodic bitmap.
10012
f16d9837
KH
100132011-05-25 Kenichi Handa <handa@m17n.org>
10014
10015 * xdisp.c (get_next_display_element): Set correct it->face_id for
10016 a static composition.
10017
e1b90ef6
LL
100182011-05-24 Leo Liu <sdl.web@gmail.com>
10019
10020 * deps.mk (fns.o):
10021 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10022
10023 * fns.c (crypto_hash_function, Fsha1): New function.
10024 (Fmd5): Use crypto_hash_function.
10025 (syms_of_fns): Add Ssha1.
10026
7400048f
PE
100272011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10028
10029 * gnutls.c: Remove unused macros.
10030 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10031 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10032 Remove macros that are defined and never used.
10033 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10034
abb71cf4
CY
100352011-05-22 Chong Yidong <cyd@stupidchicken.com>
10036
10037 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10038 (Fx_get_selection_internal): Minor cleanup.
10039 (Fx_own_selection_internal): Rename arguments for consistency with
10040 select.el.
10041
6307db39
PE
100422011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10043
10044 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10045
f3d4e0a4
CY
100462011-05-22 Chong Yidong <cyd@stupidchicken.com>
10047
10048 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10049
4d8ade89
YM
100502011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10051
10052 * dispnew.c (scrolling_window): Don't exclude the case that the
10053 last enabled row in the desired matrix touches the bottom boundary.
10054
32078c8d
GM
100552011-05-21 Glenn Morris <rgm@gnu.org>
10056
10057 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10058 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10059 and add some more files.
32078c8d 10060
7285dc67
EZ
100612011-05-20 Eli Zaretskii <eliz@gnu.org>
10062
10063 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10064 report_file_error introduced by the change from 2011-05-07.
10065
89d1bd22
PE
100662011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10067
10068 * systime.h (Time): Define only if emacs is defined.
10069 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10070 where the include path doesn't have X11/X.h by default. See
10071 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10072
cd394be1 100732011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10074
10075 * composite.c (find_automatic_composition): Fix previous change.
10076
b9704ad9
GM
100772011-05-20 Glenn Morris <rgm@gnu.org>
10078
10079 * lisp.mk: New file, split from Makefile.in.
10080 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10081 (shortlisp): Remove.
10082 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10083
4a720484
GM
100842011-05-19 Glenn Morris <rgm@gnu.org>
10085
10086 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10087 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10088 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10089 (lisp): Set the order to that of loadup.el.
10090 (shortlisp): Make it a copy of $lisp.
10091 (SOME_MACHINE_LISP): Remove.
10092 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10093 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10094
a28d4396
KH
100952011-05-18 Kenichi Handa <handa@m17n.org>
10096
10097 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10098 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10099 (find_automatic_composition): Mostly rewrite for efficiency.
10100
a2b1fa8e
JB
101012011-05-18 Juanma Barranquero <lekktu@gmail.com>
10102
10103 * makefile.w32-in: Update dependencies.
10104
8e1f5610
CS
101052011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10106
10107 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10108 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10109
7025ee00 101102011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10111
cdfa6eab
PE
10112 Fix some integer overflow issues, such as string length overflow.
10113
06d6db33
PE
10114 * insdel.c (count_size_as_multibyte): Check for string overflow.
10115
2b4560a8
PE
10116 * character.c (lisp_string_width): Check for string overflow.
10117 Use EMACS_INT, not int, for string indexes and lengths; in
10118 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10119 the resulting string length overflows an EMACS_INT; instead,
10120 report a string overflow if no precision given. When checking for
10121 precision exhaustion, use a check that cannot possibly have
10122 integer overflow. (Bug#8675)
10123 * character.h (lisp_string_width): Adjust to new signature.
10124
cb93f9be
PE
10125 * alloc.c (string_overflow): New function.
10126 (Fmake_string): Use it. This doesn't change behavior, but saves
10127 a few bytes and will simplify future changes.
10128 * character.c (string_escape_byte8): Likewise.
10129 * lisp.h (string_overflow): New decl.
10130
1a1f3366
PE
10131 Fixups, following up to the user-interface timestamp change.
10132 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10133 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10134 * msdos.c (mouse_get_pos): Likewise.
10135 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10136 * w32gui.h (Time): Define by including "systime.h" rather than by
10137 declaring it ourselves. (Bug#8664)
10138
d4e3e4d3
PE
10139 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10140 * image.c (clear_image_cache): Likewise.
10141
f6a24d19
PE
10142 * term.c (term_mouse_position): Don't assume time_t wraparound.
10143
08dc5ae6
PE
10144 Be more systematic about user-interface timestamps.
10145 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10146 and sometimes 'EMACS_UINT', to represent these timestamps.
10147 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10148 This makes the code easier to follow, and makes it easier to catch
10149 integer overflow bugs such as Bug#8664.
10150 * frame.c (Fmouse_position, Fmouse_pixel_position):
10151 Use Time, not unsigned long, for user-interface timestamps.
10152 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10153 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10154 * keyboard.h (last_event_timestamp): Likewise.
10155 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10156 * menu.h (xmenu_show): Likewise.
10157 * term.c (term_mouse_position): Likewise.
10158 * termhooks.h (struct input_event.timestamp): Likewise.
10159 (struct terminal.mouse_position_hook): Likewise.
10160 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10161 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10162 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10163 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10164 what it was before.
10165 * menu.h, termhooks.h: Include "systime.h", for Time.
10166
8e55734a
PE
10167 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10168 Don't assume that the difference between two unsigned long values
10169 can fit into an integer. At this point, we know button_down_time
10170 <= event->timestamp, so the difference must be nonnegative, so
10171 there's no need to cast the result if double-click-time is
10172 nonnegative, as it should be; check that it's nonnegative, just in
10173 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10174 apart (about 25 days). (Bug#8664)
8e55734a 10175
841f1b75 10176 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10177 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10178
3e26f69c
PE
10179 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10180 that always fit in int. Use a sentinel instead of a counter, to
10181 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10182 * frame.h (struct frame): Use int for menu_bar_items_used
10183 instead of EMACS_INT, since it always fits in int.
3e26f69c 10184
5cc152c0
PE
10185 * menu.c (grow_menu_items): Check for int overflow.
10186
d89eb65e
PE
10187 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10188
5235bd3e
PE
10189 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10190 Before, the code was not consistent. These values cannot exceed
10191 2**31 - 1 so there's no need to make them unsigned.
10192 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10193 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10194 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10195 as modifiers.
10196 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10197
bc827e23
PE
10198 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10199 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10200 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10201 presumably because the widths might not match.
10202
78eb494e
PE
10203 * window.c (size_window): Avoid needless test at loop start.
10204
04f2d78b
CB
102052011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10206
10207 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10208
d2fc7e3d 102092011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10210
10211 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10212
d2fc7e3d 102132011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10214
10215 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10216 `width' to `bar_area_x' and `bar_area_width', respectively.
10217 (x_scroll_run): Take account of fringe background extension.
10218
04f2d78b
CB
10219 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10220 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10221 `bar_area_width', respectively.
10222 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10223 background extension.
10224
79b70037
GM
102252011-05-10 Jim Meyering <meyering@redhat.com>
10226
10227 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10228
2f142cc5
JB
102292011-05-10 Juanma Barranquero <lekktu@gmail.com>
10230
10231 * image.c (Finit_image_library): Return t for built-in image types,
10232 like pbm and xbm. (Bug#8640)
10233
57679c86
AS
102342011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10235
10236 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10237
888c9e86
EZ
102382011-05-07 Eli Zaretskii <eliz@gnu.org>
10239
b0512a1d
EZ
10240 * w32console.c (Fset_screen_color): Doc fix.
10241 (Fget_screen_color): New function.
10242 (syms_of_ntterm): Defsubr it.
10243
7285dc67
EZ
10244 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10245 unlink the temporary file if Fcall_process didn't create it in the
10246 first place.
10247 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10248 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10249 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10250 cue to call_process_cleanup not to close that handle.
10251
4d3fcc8e
BK
102522011-05-07 Ben Key <bkey76@gmail.com>
10253
10254 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10255 one of two shell specific rules, either bootstrap-temacs-CMD or
10256 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10257 to the previous implementation of the bootstrap-temacs rule.
10258 The bootstrap-temacs-CMD rule is similar to the previous
10259 implementation of the bootstrap-temacs rule except that it
10260 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10261 variable.
10262
10263 These changes, along with some changes to nt/configure.bat,
10264 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10265 earlier fix to add support for --cflags and --ldflags options
10266 that include quotes so that it works whether make uses cmd or
10267 sh as the shell.
10268
b4289b64
MA
102692011-05-06 Michael Albinus <michael.albinus@gmx.de>
10270
10271 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10272 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10273 is a constant.
10274 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10275 a string. Handle both cases.
10276 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10277 (Fdbus_register_method): Use Qinvalid_function.
10278
af4c0e28
JB
102792011-05-06 Juanma Barranquero <lekktu@gmail.com>
10280
10281 * makefile.w32-in: Update dependencies.
10282 (LISP_H): Add inttypes.h and stdin.h.
10283 (PROCESS_H): Add unistd.h.
10284
c51453d9
EZ
102852011-05-06 Eli Zaretskii <eliz@gnu.org>
10286
10287 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10288 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10289
8ff0ac3c 102902011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10291
4c4b566b
PE
10292 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10293
aab2b9b5
PE
10294 * term.c (vfatal): Remove stray call to va_end.
10295 It's not needed and the C Standard doesn't allow it here anyway.
10296
c378da0b
PE
10297 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10298 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10299
288b08c7
PE
10300 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10301 bytes.
10302
e3601888
PE
10303 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10304
db6c0e74
PE
10305 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10306
dd5963ea
PE
10307 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10308
88c9450f
PE
10309 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10310
2f9442b8
PE
10311 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10312
c032b5f8
PE
10313 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10314 * charset.c (Fdefine_charset_internal): Don't initialize
10315 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10316 32-bit int (Bug#8600).
a108c10b
PE
10317
10318 * lread.c (read_integer): Be more consistent with string-to-number.
10319 Use string_to_number to do the actual conversion; this avoids
10320 rounding errors and fixes some other screwups. Without this fix,
10321 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10322 (digit_to_number): Move earlier, for benefit of read_integer.
10323 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10324 not a digit in any supported base. (Bug#8602)
a108c10b 10325
ad5f9eea
PE
10326 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10327
aec1708a
PE
10328 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10329 to match comment at start of function. This also removes a
10330 GCC warning about overflow in a 32+64-bit port.
10331
47be4ab5
PE
10332 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10333
371cac43
PE
10334 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10335 Reported by Stefan Monnier in
10336 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10337 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10338 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10339
d01a7826
PE
10340 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10341 (EMACS_UINTPTR): Likewise, with uintptr_t.
10342
7fd47d5c
PE
10343 * lisp.h: Prefer 64-bit EMACS_INT if available.
10344 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10345 on 32-bit hosts that have 64-bit int, so that they can access
10346 large files.
122b0c86
PE
10347 However, temporarily disable this change unless the temporary
10348 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10349
8727937b
PE
10350 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10351
8ac068ac
PE
10352 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10353 This removes an assumption that EMACS_INT and long are the same
10354 width as pointers. The assumption is true for Emacs porting targets
10355 now, but we want to make other targets possible.
10356 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10357 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10358 In the rest of the code, change types of integers that hold casted
10359 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10360 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10361 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10362 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10363 No need to cast type when ORing.
10364 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10365 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10366 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10367 assume EMACS_INT is the same width as char *.
10368 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10369 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10370 Remove no-longer-needed casts.
10371 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10372 (xg_tool_bar_help_callback, xg_make_tool_item):
10373 Use EMACS_INTPTR to hold an integer
10374 that will be cast to void *; this can avoid a GCC warning
10375 if EMACS_INT is not the same width as void *.
10376 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10377 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10378 (current_message_1, set_message_1):
10379 Use a local to convert to proper width without a cast.
10380 * xmenu.c (dialog_selection_callback): Likewise.
10381
ede49d71
PE
10382 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10383 Also, don't assume VALBITS / RAND_BITS is less than 5,
10384 and don't rely on undefined behavior when shifting a 1 left into
10385 the sign bit.
10386 * lisp.h (get_random): Change signature to match.
10387
2f30ecd0
PE
10388 * lread.c (hash_string): Use size_t, not int, for hash computation.
10389 Normally we prefer signed values; but hashing is special, because
10390 it's better to use unsigned division on hash table sizes so that
10391 the remainder is nonnegative. Also, size_t is the natural width
10392 for hashing into memory. The previous code used 'int', which doesn't
10393 retain enough info to hash well into very large tables.
10394 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10395
2a866e7b
PE
10396 * dbusbind.c: Don't possibly lose pointer info when converting.
10397 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10398 Use XPNTR rather than XHASH, so that the high-order bits of
10399 the pointer aren't lost when converting through void *.
10400
51639eac
PE
10401 * eval.c (Fautoload): Don't double-shift a pointer.
10402
92394119
PE
10403 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10404
dbdb9a7c
JB
104052011-05-06 Juanma Barranquero <lekktu@gmail.com>
10406
10407 * gnutls.c (DEF_GNUTLS_FN):
10408 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10409
db7a0b4f
AS
104102011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10411
10412 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10413 marker. (Bug#8610)
10414
cd394be1 104152011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10416
10417 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10418 New version that can reserve upto 2GB of heap space.
10419
f7ff1b0f 104202011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10421
10422 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10423
639c109b
TZ
104242011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10425
10426 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10427 `gnutls_certificate_set_x509_key_file'.
10428
d2127135
JB
104292011-05-05 Juanma Barranquero <lekktu@gmail.com>
10430
10431 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10432 Update dependencies.
10433
e968f4f3
JB
104342011-05-04 Juanma Barranquero <lekktu@gmail.com>
10435
10436 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10437 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10438 Remove unused parameter `fildes'.
10439 * process.c (read_process_output, send_process): Don't pass it.
10440
84d358f0
JB
104412011-05-04 Juanma Barranquero <lekktu@gmail.com>
10442
10443 Fix previous change: the library cache is defined in w32.c.
10444 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10445 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10446
0898ca10
JB
104472011-05-04 Juanma Barranquero <lekktu@gmail.com>
10448
10449 Implement dynamic loading of GnuTLS on Windows.
10450
10451 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10452 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10453 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10454 Declare.
10455
10456 * gnutls.c (Qgnutls_dll): Define.
10457 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10458 (gnutls_*): Declare function pointers.
10459 (init_gnutls_functions): New function to initialize function pointers.
10460 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10461 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10462 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10463 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10464 (emacs_gnutls_write, emacs_gnutls_read)
10465 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10466 (Fgnutls_available_p): New function.
10467 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10468 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10469 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10470
10471 * image.c: Include w32.h.
10472 (Vimage_type_cache): Delete.
10473 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10474 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10475 (w32_delayed_load): Move to w32.c.
10476
10477 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10478
10479 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10480 (w32_delayed_load): Move from image.c. When loading a library, record
10481 its filename in the :loaded-from property of the library id.
10482 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10483 Initialize and staticpro them.
10484 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10485
10486 * process.c: Include lisp.h before w32.h, not after.
10487 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10488 instead of gnutls_record_check_pending.
10489
10490 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10491
ff4de4aa
TZ
104922011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10493
10494 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10495 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10496 as passed in.
10497
abe95abb
JD
104982011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10499
10500 * xterm.c (x_set_frame_alpha): Do not set property on anything
10501 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10502
e16e55d4
JB
105032011-05-02 Juanma Barranquero <lekktu@gmail.com>
10504
10505 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10506
bafcf6a5
JB
105072011-05-02 Juanma Barranquero <lekktu@gmail.com>
10508
10509 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10510 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10511 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10512 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10513 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10514 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10515 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10516 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10517 (Qgnutls_bootprop_callbacks_verify): Make static.
10518
e7a6747f
AS
105192011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10520
19ed11ba
AS
10521 * callproc.c: Indentation fixup.
10522
e7a6747f 10523 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10524 (wait_for_termination, interruptible_wait_for_termination):
10525 Move after wait_for_termination_1.
e7a6747f 10526
1ef14cb4
LMI
105272011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10528
10529 * sysdep.c (interruptible_wait_for_termination): New function
10530 which is like wait_for_termination, but allows keyboard
10531 interruptions.
10532
10533 * callproc.c (Fcall_process): Add (:file "file") as an option for
10534 the STDOUT buffer.
10535 (Fcall_process_region): Ditto.
10536
330d880c
EZ
105372011-04-30 Eli Zaretskii <eliz@gnu.org>
10538
8db90b73
EZ
10539 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10540 rather than `XVECTOR (FOO)->size'.
10541
330d880c
EZ
10542 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10543 inttypes.h, as a gnulib replacement is used if it not available in
10544 system headers.
10545
15cbd324
EZ
105462011-04-21 Eli Zaretskii <eliz@gnu.org>
10547
10548 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10549 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10550 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10551
10552 * coding.c (coding_alloc_by_realloc): Error out if destination
10553 will grow beyond MOST_POSITIVE_FIXNUM.
10554 (decode_coding_emacs_mule): Abort if there isn't enough place in
10555 charbuf for the composition carryover bytes. Reserve an extra
10556 space for up to 2 characters produced in a loop.
10557 (decode_coding_iso_2022): Abort if there isn't enough place in
10558 charbuf for the composition carryover bytes.
10559
105602011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10561
ae940cca
EZ
10562 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10563 aborting when %lld or %lll format is passed.
10564 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10565 %llo or %llx format is passed. (Bug#8545)
10566
03ab8921
EZ
10567 * window.c (window_scroll_line_based): Use a marker instead of
10568 simple variables to record original value of point. (Bug#7952)
10569
afda1437
EZ
10570 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10571 produced by %s or %c overflows available buffer space. (Bug#8545)
10572
f76dee0c
PE
105732011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10574
10575 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10576 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10577
fdc5744d
JB
105782011-04-28 Juanma Barranquero <lekktu@gmail.com>
10579
10580 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10581
638f053a
JB
105822011-04-28 Juanma Barranquero <lekktu@gmail.com>
10583
10584 * keyboard.c (Qdelayed_warnings_hook): Define.
10585 (command_loop_1): Run `delayed-warnings-hook'
10586 if Vdelayed_warnings_list is non-nil.
10587 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10588 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10589
d178f871
EZ
105902011-04-28 Eli Zaretskii <eliz@gnu.org>
10591
10592 * doprnt.c (doprnt): Don't return value smaller than the buffer
10593 size if the message was truncated. (Bug#8545).
10594
b124fd93
JB
105952011-04-28 Juanma Barranquero <lekktu@gmail.com>
10596
10597 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10598 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10599
e810457d
PE
106002011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10601
10602 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10603
ea51cceb
JB
106042011-04-27 Juanma Barranquero <lekktu@gmail.com>
10605
10606 * makefile.w32-in: Update dependencies.
10607
94dcfacf
EZ
106082011-04-27 Eli Zaretskii <eliz@gnu.org>
10609
10610 Improve `doprnt' and its usage. (Bug#8545)
10611 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10612 `format_end'. Remove support for %l as a conversion specifier.
10613 Don't use xrealloc. Improve diagnostics when the %l size modifier
10614 is used. Update the commentary.
10615
10616 * eval.c (verror): Simplify calculation of size_t.
10617
10618 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10619 messages.
10620
f61f41d7
PE
106212011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10622
10623 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10624 change.
10625
96fb4434
PE
106262011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10627
10628 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10629 This makes this file independent of the recent pseudovector change.
10630
671875da 106312011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10632
69e9b5a3
PE
10633 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10634
b5f869a7 10635 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10636 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10637 Remove unused local.
c8926152 10638 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10639
841a1577 10640 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10641 GCC 4.6.0 optimizes based on type-based alias analysis.
10642 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10643 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10644 != &v->size, and therefore "v->size = 1; b->size = 2; return
10645 v->size;" must therefore return 1. This assumption is incorrect
10646 for Emacs, since it type-puns struct Lisp_Vector * with many other
10647 types. To fix this problem, this patch adds a new type struct
f904488f 10648 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10649 and pseudovectors, and helps optimizing compilers not get fooled
10650 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10651 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10652 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10653 the size member.
eab3844f
PE
10654 (XSETPVECTYPE): Rewrite in terms of new macro.
10655 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10656 This is a bit clearer, and further avoids the possibility of
10657 undesirable aliasing.
10658 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10659 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10660 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10661 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10662 (ASIZE): Now uses header.size rather than size.
10663 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10664 to avoid the hassle of writing XVECTOR (foo)->header.size.
10665 (struct vectorlike_header): New type.
eab3844f
PE
10666 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10667 object, to help avoid aliasing.
10668 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10669 (SUBRP): Likewise, since Lisp_Subr is a special case.
10670 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10671 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10672 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10673 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10674 changed to be "header.size" and "header.next".
10675 * buffer.h (struct buffer): Likewise.
10676 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10677 * frame.h (struct frame): Likewise.
10678 * process.h (struct Lisp_Process): Likewise.
10679 * termhooks.h (struct terminal): Likewise.
10680 * window.c (struct save_window_data, struct saved_window): Likewise.
10681 * window.h (struct window): Likewise.
10682 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10683 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10684 * buffer.c (init_buffer_once): Likewise.
10685 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10686 special case.
10687 * process.c (Fformat_network_address): Use local var for size,
10688 for brevity.
10689
0df1eac5
PE
10690 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10691
847ab9d1 10692 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10693 * data.c (atof): Remove decl; no longer used or needed.
10694 (digit_to_number): Move to lread.c.
10695 (Fstring_to_number): Use new string_to_number function, to be
10696 consistent with how the Lisp reader treats infinities and NaNs.
10697 Do not assume that floating-point numbers represent EMACS_INT
10698 without losing information; this is not true on most 64-bit hosts.
10699 Avoid double-rounding errors, by insisting on integers when
10700 parsing non-base-10 numbers, as the documentation specifies.
10701 * lisp.h (string_to_number): New decl, replacing ...
10702 (isfloat_string): Remove.
bc0a5c13 10703 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10704 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10705 appears to have been a coding error. Similarly, do not accept
10706 strings like +-1e0 as floating point numbers. Do not report
10707 overflow for integer overflows unless the base is not 10 which
10708 means we have no simple and reliable way to continue.
10709 Break out the floating-point parsing into a new
10710 function string_to_number, so that Fstring_to_number parses
10711 floating point numbers consistently with the Lisp reader.
04f2d78b 10712 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10713 (E_CHAR, EXP_INT): Remove, replacing with ...
10714 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10715 (string_to_number): New function, replacing isfloat_string.
10716 This function checks for valid syntax and produces the resulting
10717 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10718 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10719 so that overflow for non-base-10 numbers is reported only when
10720 there's no portable and simple way to convert to floating point.
452f4150 10721
67769ffc
PE
10722 * textprop.c (set_text_properties_1): Rewrite for clarity,
10723 and to avoid GCC warning about integer overflow.
10724
c20db43f
PE
10725 * intervals.h (struct interval): Use EMACS_INT for members
10726 where EMACS_UINT might cause problems. See
10727 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10728 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10729 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10730 All uses changed.
37aa2f85
PE
10731 (offset_intervals): Tell GCC not to worry about length overflow
10732 when negating a negative length.
c20db43f 10733
2538aa2f
PE
10734 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10735 (overrun_check_free): Likewise.
10736
f2d3008d
PE
10737 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10738 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10739 word size.
10740
ec8df744
PE
10741 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10742 (gnutls_make_error): Rename local to avoid shadowing.
10743 (gnutls_emacs_global_deinit): ifdef out; not used.
10744 (Fgnutls_boot): Use const for pointer to readonly storage.
10745 Comment out unused local. Fix pointer signedness problems.
10746
640ee02d
PE
10747 * lread.c (openp): Don't stuff size_t into an 'int'.
10748 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10749 about possible signed overflow.
10750
6048fb2a
PE
10751 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10752 (GDK_KEY_g): Don't define if already defined.
10753 (xg_prepare_tooltip): Avoid pointer signedness problem.
10754 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10755
fa3c87e1
PE
10756 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10757 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10758
2172544b
PE
10759 * xfns.c (Fx_window_property): Simplify a bit,
10760 to make a bit faster and to avoid GCC 4.6.0 warning.
10761 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10762
9b821a21
PE
10763 * fns.c (internal_equal): Don't assume size_t fits in int.
10764
3c616cfa
PE
10765 * alloc.c (compact_small_strings): Tighten assertion a little.
10766
c2982e87
PE
10767 Replace pEd with more-general pI, and fix some printf arg casts.
10768 * lisp.h (pI): New macro, generalizing old pEd macro to other
10769 conversion specifiers. For example, use "...%"pI"d..." rather
10770 than "...%"pEd"...".
10771 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10772 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10773 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10774 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10775 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10776 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10777 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10778 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10779 64-bit hosts.
10780 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10781 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10782 * print.c (safe_debug_print, print_object): Likewise.
10783 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10784 to int.
6f04d126
PE
10785 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10786 avoiding the 0 flag, which is not portable.
c2982e87
PE
10787 * process.c (Fmake_network_process): Use pI to avoid cast.
10788 * region-cache.c (pp_cache): Likewise.
10789 * xdisp.c (decode_mode_spec): Likewise.
10790 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10791 behavior on 64-bit hosts with printf arg.
6f04d126 10792 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10793 (x_stop_queuing_selection_requests): Likewise.
10794 (x_get_window_property): Don't truncate byte count to an 'int'
10795 when tracing.
0b432f21 10796
5e073ec7
PE
10797 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10798 here, since it parses constructs like leading '-' and spaces,
10799 which are not wanted; and it overflows with large numbers.
10800 Instead, simply match F[0-9]+, which is what is wanted anyway.
10801
36372bf9
PE
10802 * alloc.c: Remove unportable assumptions about struct layout.
10803 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10804 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10805 (allocate_vectorlike, make_pure_vector): Use the new macros,
10806 plus offsetof, to remove unportable assumptions about struct layout.
10807 These assumptions hold on all porting targets that I know of, but
10808 they are not guaranteed, they're easy to remove, and removing them
10809 makes further changes easier.
10810
0b432f21
PE
10811 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10812 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10813 (string_overrun_cookie): Now const. Use initializers that
10814 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10815 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10816 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10817 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10818 multiple of sizeof (EMACS_INT); it need not be, if
10819 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10820 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10821
895009e1
JB
108222011-04-26 Juanma Barranquero <lekktu@gmail.com>
10823
10824 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10825
6a7a1b0b
TZ
108262011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10827
10828 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10829 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10830 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10831
841a1577 108322011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10833
10834 * lisp.h (Qdebug): List symbol.
895009e1 10835 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10836 * keyboard.c (debug-on-event): New variable.
10837 (handle_user_signal): Break into debugger when debug-on-event
10838 matches the current signal symbol.
10839
f2d3ba6f
DN
108402011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10841
10842 * alloc.c (check_sblock, check_string_bytes)
10843 (check_string_free_list): Convert to standard C.
10844
42ce4c63
TZ
108452011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10846
10847 * w32.c (emacs_gnutls_push): Fix typo.
10848
825cd63c
EZ
108492011-04-25 Eli Zaretskii <eliz@gnu.org>
10850
fb11d64d
EZ
10851 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10852 "cast to pointer from integer of different size".
10853
825cd63c
EZ
10854 Improve doprnt and its use in verror. (Bug#8545)
10855 * doprnt.c (doprnt): Document the set of format control sequences
10856 supported by the function. Use SAFE_ALLOCA instead of always
10857 using `alloca'.
10858
10859 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10860 is one byte too soon. Don't use xrealloc; instead xfree and
10861 xmalloc anew.
10862
e061a11b
TZ
108632011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10864
10865 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10866 callbacks stage.
10867
10868 * gnutls.c: Renamed global_initialized to
10869 gnutls_global_initialized. Added internals for the
10870 :verify-hostname-error, :verify-error, and :verify-flags
10871 parameters of `gnutls-boot' and documented those parameters in the
10872 docstring. Start callback support.
9173deec
JB
10873 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10874 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10875 on error. Return error code.
e061a11b
TZ
10876 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10877 (emacs_gnutls_read): Likewise.
10878 (Fgnutls_boot): Return handshake error code.
10879 (emacs_gnutls_handle_error): New function.
10880 (wsaerror_to_errno): Likewise.
10881
10882 * w32.h (emacs_gnutls_pull): Add prototype.
10883 (emacs_gnutls_push): Likewise.
10884
10885 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10886 (emacs_gnutls_push): Likewise.
10887
108882011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10889
10890 * process.c (wait_reading_process_output): Check if GnuTLS
10891 buffered some data internally if no FDs are set for TLS
10892 connections.
10893
10894 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10895 (LIBS): Link to USER_LIBS.
10896 ($(BLD)/gnutls.$(0)): New target.
10897
fa6996bc
EZ
108982011-04-24 Eli Zaretskii <eliz@gnu.org>
10899
eb35682e
EZ
10900 * xdisp.c (handle_single_display_spec): Rename the
10901 display_replaced_before_p argument into display_replaced_p, to
10902 make it consistent with the commentary. Fix typos in the
10903 commentary.
10904
e2ad650c
EZ
10905 * textprop.c (syms_of_textprop): Remove dead code.
10906 (copy_text_properties): Delete obsolete commentary about an
10907 interface that was deleted long ago. Fix typos in the description
10908 of arguments.
10909
1b2de274
EZ
10910 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10911 to changes in oldXMenu/XMenu.h from 2011-04-16.
10912 <menu_help_message, prev_menu_help_message>: Constify.
10913 (IT_menu_make_room): menu->help_text is now `const char **';
10914 adjust.
10915
10916 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10917 to changes in oldXMenu/XMenu.h from 2011-04-16.
10918 (struct XMenu): Declare `help_text' `const char **'.
10919
10920 * xfaces.c <Qunspecified>: Make extern again.
10921
10922 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10923 required by POSIX.
1b2de274 10924
762b15be
EZ
10925 * doc.c (get_doc_string): Improve the format passed to `error'.
10926
10927 * doprnt.c (doprnt): Improve commentary.
10928
10929 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10930
10931 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10932 them with etags.
10933
f1052e5d
EZ
10934 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10935 changes in globals.h immediately force recompilation.
762b15be
EZ
10936 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10937 $(CURDIR)/s/ms-w32.h.
10938 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10939
fa6996bc
EZ
10940 * character.c (Fchar_direction): Function deleted.
10941 (syms_of_character): Don't defsubr it.
10942 <char-direction-table>: Deleted.
10943
e6c3da20
EZ
109442011-04-23 Eli Zaretskii <eliz@gnu.org>
10945
10946 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10947 * doprnt.c: Include limits.h.
10948 (SIZE_MAX): New macro.
04f2d78b
CB
10949 (doprnt): Return a size_t value. 2nd arg is now size_t.
10950 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10951 Improve overflow protection. Support `l' modifier for integer
10952 conversions. Support %l conversion. Don't assume an EMACS_INT
10953 argument for integer conversions and for %c.
10954
10955 * lisp.h (doprnt): Restore prototype.
10956
10957 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10958 $(SRC)/character.h.
10959
10960 * Makefile.in (base_obj): Add back doprnt.o.
10961
10962 * deps.mk (doprnt.o): Add back prerequisites.
10963 (callint.o): Depend on character.h.
10964
10965 * eval.c (internal_lisp_condition_case): Include the handler
10966 representation in the error message.
10967 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10968 when breaking from the loop.
10969
10970 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10971
10972 * callint.c (Fcall_interactively): When displaying error message
10973 about invalid control letter, pass the character's codepoint, not
10974 a pointer to its multibyte form. Improve display of the character
10975 in octal and display also its hex code.
10976
10977 * character.c (char_string): Use %x to display the (unsigned)
10978 codepoint of an invalid character, to avoid displaying a bogus
10979 negative value.
10980
10981 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10982 `error', not SYMBOL_NAME itself.
10983
10984 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10985 character arguments to `error'.
10986
10987 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10988 to `error' in error message about FINAL_CHAR argument. Make sure
10989 FINAL_CHAR is a character, and use %c when it is passed as
10990 argument to `error'.
10991
4ffd0d6b 109922011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10993
10994 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10995
10996 * w32.c: Include <time.h>.
10997 (sys_localtime): New function.
10998
4ffd0d6b 109992011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11000
11001 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11002
4ffd0d6b 11003 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11004
4ffd0d6b 110052011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11006
4ffd0d6b
GM
11007 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11008 zombies (Bug#8467).
aac0c6e3 11009
04c56954
EZ
110102011-04-19 Eli Zaretskii <eliz@gnu.org>
11011
11012 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11013 gl_state.e_property when gl_state.object is Qt.
11014
11015 * insdel.c (make_gap_larger): Remove limitation of buffer size
11016 to <= INT_MAX.
11017
16a43933
CY
110182011-04-18 Chong Yidong <cyd@stupidchicken.com>
11019
11020 * xdisp.c (lookup_glyphless_char_display)
11021 (produce_glyphless_glyph): Handle cons cell entry in
11022 glyphless-char-display.
11023 (Vglyphless_char_display): Document it.
11024
11025 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11026 glyphless-char-display.
11027
4581706e
CY
110282011-04-17 Chong Yidong <cyd@stupidchicken.com>
11029
11030 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11031
11032 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11033
11034 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11035 definition for no-X builds.
11036
4887c6e2 110372011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11038
fd35b6f9
PE
11039 Static checks with GCC 4.6.0 and non-default toolkits.
11040
5c1ccb01
PE
11041 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11042
006c5daa
PE
11043 * process.c (keyboard_bit_set): Define only if SIGIO.
11044 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11045 (send_process): Repair possible setjmp clobbering.
11046
efc736d3
PE
11047 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11048
4e2fe2e6
PE
11049 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11050
f97334a2
PE
11051 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11052
4e75f29d
PE
11053 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11054 Define only if needed.
11055
90efadd1
PE
11056 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11057 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11058 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11059
3c647824
PE
11060 * dispextern.h (struct redisplay_interface): Rename param
11061 to avoid shadowing.
e264f262 11062 * termhooks.h (struct terminal): Likewise.
761383f4 11063 * xterm.c (xembed_send_message): Likewise.
3c647824 11064
b58c5c4a
PE
11065 * insdel.c (make_gap_smaller): Define only if
11066 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11067
cad59032
PE
11068 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11069 it.
11070
c339dc2e
PE
11071 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11072 so that we aren't warned about unused symbols.
11073
91a3e27b
PE
11074 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11075
399c71d3 11076 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11077
8ffc96f5
PE
11078 * xfns.c (x_real_positions): Mark locals as initialized.
11079
eef9bc79
PE
11080 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11081
098db9dd
PE
11082 * xterm.c: Fix problems found by static analysis with other toolkits.
11083 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11084 (x_dispatch_event): Declare static if USE_GTK, and
11085 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11086 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11087 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11088 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11089 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11090
eb18f6cc
PE
11091 * xmenu.c (menu_help_callback): Pointer type fixes.
11092 Use const pointers when pointing at readonly data. Avoid pointer
11093 signedness clashes.
11094 (FALSE): Remove unused macro.
11095 (update_frame_menubar): Remove unused decl.
11096
1fe72bf8
PE
11097 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11098
60d9e1db
PE
11099 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11100 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11101 (single_menu_item): Rename local to avoid shadowing.
11102
39261c26
PE
11103 * keyboard.c (make_lispy_event): Remove unused local var.
11104
018c5e19
PE
11105 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11106 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11107
63d2b86e
PE
11108 * bitmaps: Change bitmaps from unsigned char back to the X11
11109 compatible char. Avoid the old compiler warnings about
11110 out-of-range initializers by using, for example, '\xab' rather
11111 than 0xab.
11112
aefd87e1
PE
11113 * xgselect.c (xgselect_initialize): Check vs interface
11114 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11115
bf501fb9
PE
11116 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11117
e9829fdf
PE
11118 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11119 to read-only memory.
11120
1086c095
PE
11121 * fns.c (vector): Remove; this old hack is no longer needed.
11122
2baccd04 11123 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11124 Remove unused var.
dde42981 11125 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11126
72391843 11127 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11128
436c16df 11129 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11130 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11131 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11132
92bb796d 11133 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11134 (x_term_init): Remove local to avoid shadowing.
92bb796d 11135
764430a3 11136 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11137
11138 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11139 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11140
d1dfb56c
EZ
111412011-04-16 Eli Zaretskii <eliz@gnu.org>
11142
c4354cb4
EZ
11143 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11144
d1dfb56c
EZ
11145 Fix regex.c, syntax.c and friends for buffers > 2GB.
11146 * syntax.h (struct gl_state_s): Declare character position members
11147 EMACS_INT.
11148
11149 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11150
04f2d78b
CB
11151 * textprop.c (verify_interval_modification, interval_of):
11152 Declare arguments EMACS_INT.
d1dfb56c
EZ
11153
11154 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11155 EMACS_INT.
11156
11157 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11158
11159 * indent.c (Fvertical_motion): Local variable it_start is now
11160 EMACS_INT.
11161
11162 * regex.c (re_match, re_match_2, re_match_2_internal)
11163 (bcmp_translate, regcomp, regexec, print_double_string)
11164 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11165 (re_compile_pattern, re_exec): Declare arguments and local
11166 variables `size_t' and `ssize_t' and return values `regoff_t', as
11167 appropriate.
11168 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11169 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11170 <compile_stack_type>: `size' and `avail' are now `size_t'.
11171
11172 * regex.h <regoff_t>: Use ssize_t, not int.
11173 (re_search, re_search_2, re_match, re_match_2): Arguments that
11174 specify buffer/string position and length are now ssize_t and
11175 size_t. Return type is regoff_t.
11176
613052cd
BK
111772011-04-16 Ben Key <bkey76@gmail.com>
11178
11179 * nsfont.m: Fixed bugs in ns_get_family and
11180 ns_descriptor_to_entity that were caused by using free to
11181 deallocate memory blocks that were allocated by xmalloc (via
11182 xstrdup). This caused Emacs to crash when compiled with
11183 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11184 --enable-checking=xmallocoverrun). xfree is now used to
11185 deallocate these memory blocks.
11186
4170f62f 111872011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11188
71b41406
PE
11189 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11190
9587a89d
PE
11191 emacs_write: Accept and return EMACS_INT for sizes.
11192 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11193 et seq.
11194 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11195 Accept and return EMACS_INT.
11196 (emacs_gnutls_write): Return the number of bytes written on
11197 partial writes.
11198 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11199 (emacs_read, emacs_write): Remove check for negative size, as the
11200 Emacs source code has been audited now.
9587a89d
PE
11201 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11202 (emacs_read, emacs_write): Use it.
273a5f82
PE
11203 * process.c (send_process): Adjust to the new signatures of
11204 emacs_write and emacs_gnutls_write. Do not attempt to store
11205 a byte offset into an 'int'; it might overflow.
9587a89d 11206 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11207
3e047f51
PE
11208 * sound.c: Don't assume sizes fit in 'int'.
11209 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11210 Return EMACS_INT, not int.
3e047f51 11211 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11212 Accept EMACS_INT, not int.
11213 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11214 record read return values.
11215
cc39a9db
BK
112162011-04-15 Ben Key <bkey76@gmail.com>
11217
c9d0ec6d
JB
11218 * keyboard.c (Qundefined): Don't declare static since it is used
11219 in nsfns.m.
11220 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11221 static since they are used in nsfont.m.
cc39a9db 11222
6c60eb9f
SM
112232011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11224
11225 * process.c (Qprocessp): Don't declare static.
11226 * lisp.h (Qprocessp): Declare again.
11227
7990b61a
JB
112282011-04-15 Juanma Barranquero <lekktu@gmail.com>
11229
11230 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11231
5d4cb038
PE
112322011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11233
8bd7b830 11234 Improve C-level modularity by making more things 'static'.
cd64ea1d 11235
e3b27b31
PE
11236 Don't publish debugger-only interfaces to other modules.
11237 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11238 (verify_bytepos, count_markers): Move decls to the only modules
11239 that need them.
11240 * region-cache.h (pp_cache): Likewise.
11241 * window.h (check_all_windows): Likewise.
11242 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11243
5d4cb038
PE
11244 * sysdep.c (croak): Now static, if
11245 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11246 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11247
11248 * alloc.c (refill_memory_reserve): Now static if
11249 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11250 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11251
e87b6180
PE
11252 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11253 Define only if USE_LUCID.
11254
ac64929e
PE
11255 * xrdb.c (x_customization_string, x_rm_string): Now static.
11256
6f37259d
PE
11257 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11258 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11259
1683e3ab
PE
11260 * xdisp.c (draw_row_with_mouse_face): Now static.
11261 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11262
de9c2632
PE
11263 * window.h (check_all_windows): Mark externally visible.
11264
2b96acb7
PE
11265 * window.c (window_deletion_count): Now static.
11266
11267 * undo.c: Make symbols static if they're not exported.
11268 (last_undo_buffer, last_boundary_position, pending_boundary):
11269 Now static.
11270
50436f33
PE
11271 * textprop.c (interval_insert_behind_hooks): Now static.
11272 (interval_insert_in_front_hooks): Likewise.
11273
64520e5c
PE
11274 * term.c: Make symbols static if they're not exported.
11275 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11276 (max_frame_lines, tty_set_terminal_modes):
11277 (tty_reset_terminal_modes, tty_turn_off_highlight):
11278 (get_tty_terminal): Now static.
11279 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11280 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11281 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11282 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11283 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11284
1fa53021
PE
11285 * sysdep.c: Make symbols static if they're not exported.
11286 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11287 Now static.
11288 (sigprocmask_set, full_mask): Remove; unused.
11289 (wait_debugging): Mark as visible.
11290 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11291 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11292
d4b43b22
PE
11293 * syntax.c (syntax_temp): Define only if !__GNUC__.
11294
b7c513d0
PE
11295 * sound.c (current_sound_device, current_sound): Now static.
11296
989b29ad
PE
11297 * search.c (searchbufs, searchbuf_head): Now static.
11298
13a55a78
PE
11299 * scroll.c (scroll_cost): Remove; unused.
11300 * dispextern.h (scroll_cost): Remove decl.
11301
de68a1fc
PE
11302 * region-cache.h (pp_cache): Mark as externally visible.
11303
40ccffa6
PE
11304 * process.c: Make symbols static if they're not exported.
11305 (process_tick, update_tick, create_process, chan_process):
11306 (Vprocess_alist, proc_buffered_char, datagram_access):
11307 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11308 (deactivate_process): Mark defn as static, as well as decl.
11309 * lisp.h (create_process): Remove decl.
11310 * process.h (chan_process, Vprocess_alist): Remove decls.
11311
ad64fc97
PE
11312 * print.c: Make symbols static if they're not exported.
11313 (print_depth, new_backquote_output, being_printed, print_buffer):
11314 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11315 (print_interval, print_number_index, initial_stderr_stream):
11316 Now static.
11317 * lisp.h (Fprinc): Remove decl.
11318 (debug_output_compilation_hack): Mark as externally visible.
11319
adddb265
PE
11320 * sysdep.c (croak): Move decl from here to syssignal.h.
11321 * syssignal.h (croak): Put it here, so the API can be checked when
11322 'croak' is called from dissociate_if_controlling_tty.
11323
1717ede2
PE
11324 * minibuf.c: Make symbols static if they're not exported.
11325 (minibuf_save_list, choose_minibuf_frame): Now static.
11326 * lisp.h (choose_minibuf_frame): Remove decl.
11327
fa5fb2bc
PE
11328 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11329
1e3890d1
PE
11330 * lread.c: Make symbols static if they're not exported.
11331 (read_objects, initial_obarray, oblookup_last_bucket_number):
11332 Now static.
11333 (make_symbol): Remove; unused.
11334 * lisp.h (initial_obarray, make_symbol): Remove decls.
11335
8a1414fa
PE
11336 * keyboard.c: Make symbols static if they're not exported.
11337 (single_kboard, recent_keys_index, total_keys, recent_keys):
11338 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11339 (this_single_command_key_start, echoing, last_auto_save):
11340 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11341 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11342 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11343 (Vlispy_mouse_stem, double_click_count):
11344 Now static.
11345 (force_auto_save_soon): Define only if SIGDANGER.
11346 (ignore_mouse_drag_p): Now static if
11347 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11348 (print_help): Remove; unused.
11349 (stop_character, last_timer_event): Mark as externally visible.
11350 * keyboard.h (ignore_mouse_drag_p): Declare only if
11351 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11352 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11353 * lisp.h (echoing): Remove decl.
11354 (force_auto_save_soon): Declare only if SIGDANGER.
11355 * xdisp.c (redisplay_window): Simplify code, to make it more
11356 obvious that ignore_mouse_drag_p is not accessed if !defined
11357 USE_GTK && !defined HAVE_NS.
11358
93ea6e8f
PE
11359 * intervals.c: Make symbols static if they're not exported.
11360 (merge_properties_sticky, merge_interval_right, delete_interval):
11361 Now static.
11362 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11363
77382fcc
PE
11364 * insdel.c: Make symbols static if they're not exported.
11365 However, leave prepare_to_modify_buffer alone. It's never
11366 called from outside this function, but that appears to be a bug.
11367 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11368 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11369 (adjust_after_replace_noundo): Remove; unused.
11370 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11371 (signal_before_change): Remove decls.
77382fcc 11372
9306c32e
PE
11373 * indent.c (val_compute_motion, val_vmotion): Now static.
11374
cd44d2eb
PE
11375 * image.c: Make symbols static if they're not exported.
11376 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11377 if USE_GTK.
11378 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11379 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11380
ad9a7a06
PE
11381 * fringe.c (standard_bitmaps): Now static.
11382 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11383
81626931
PE
11384 * frame.c: Make symbols static if they're not exported.
11385 (x_report_frame_params, make_terminal_frame): Now static.
11386 (get_frame_param): Now static, unless HAVE_NS.
11387 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11388 (x_get_resource_string): Remove; not used.
11389 * frame.h (make_terminal_frame, x_report_frame_params):
11390 (x_get_resource_string); Remove decls.
11391 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11392 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11393
239f9db9
PE
11394 * font.c, fontset.c: Make symbols static if they're not exported.
11395 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11396 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11397 * font.c (font_close_object): Now static.
11398 * font.h (font_close_object): Remove.
11399 * fontset.c (FONTSET_OBJLIST): Remove.
11400 (free_realized_fontset) #if-0 the body, which does nothing.
11401 (face_suitable_for_char_p): #if-0, as it's never called.
11402 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11403 * xfaces.c (face_at_string_position):
11404 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11405 since 0 is always ASCII.
11406
dfcf3579
PE
11407 * fns.c (weak_hash_tables): Now static.
11408
5045092b
PE
11409 * fileio.c: Make symbols static if they're not exported.
11410 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11411 (Vwrite_region_annotation_buffers): Now static.
11412
57a96f5c
PE
11413 * eval.c: Make symbols static if they're not exported.
11414 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11415 * lisp.h (backtrace_list): Remove decl.
11416
35f08c38
PE
11417 * emacs.c: Make symbols static if they're not exported.
11418 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11419 (fatal_error_code, fatal_error_signal_hook, standard_args):
11420 Now static.
11421 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11422 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11423 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11424 * lisp.h (fatal_error_signal_hook): Remove decl.
11425 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11426
f44bd759
PE
11427 * editfns.c: Move a (normally-unused) function to its only use.
11428 * editfns.c, lisp.h (get_operating_system_release): Remove.
11429 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11430 worth the hassle of breaking this out.
11431
b532497d
PE
11432 * xterm.c: Make symbols static if they're not exported.
11433 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11434 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11435 (x_destroy_window, x_delete_display):
11436 Now static.
11437 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11438 (x_mouse_leave): Remove; unused.
11439 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11440 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11441 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11442 Remove decls.
11443 (x_mouse_leave): Declare only if WINDOWSNT.
11444 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11445 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11446 USE_X_TOOLKIT.
11447
1675728f
PE
11448 * ftxfont.c: Make symbols static if they're not exported.
11449 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11450 HAVE_FREETYPE.
11451 * font.h (ftxfont_driver): Likewise.
11452
e4cebfca
PE
11453 * xfns.c: Make symbols static if they're not exported.
11454 (x_last_font_name, x_display_info_for_name):
11455 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11456 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11457 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11458 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11459 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11460 (last_show_tip_args): Now static.
11461 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11462 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11463 (x_screen_planes): Remove; unused.
11464 * dispextern.h (x_screen_planes): Remove decl.
11465
5bf46f05
PE
11466 * dispnew.c: Make symbols static if they're not exported.
11467 * dispextern.h (redraw_garbaged_frames, scrolling):
11468 (increment_row_positions): Remove.
11469 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11470 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11471 Now static.
11472 (redraw_garbaged_frames): Remove; unused.
11473
435f4c28
PE
11474 * xfaces.c: Make symbols static if they're not exported.
11475 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11476 Remove decls.
11477 * xterm.h (defined_color): Remove decls.
11478 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11479 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11480 (menu_face_changed_default, defined_color, free_realized_face):
11481 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11482 (ascii_face_of_lisp_face): Remove; unused.
11483
8524aef3
PE
11484 * xdisp.c: Make symbols static if they're not exported.
11485 * dispextern.h (scratch_glyph_row, window_box_edges):
11486 (glyph_to_pixel_coords, set_cursor_from_row):
11487 (get_next_display_element, set_iterator_to_next):
11488 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11489 (show_mouse_face): Remove decls
11490 * frame.h (message_buf_print): Likewise.
11491 * lisp.h (pop_message, set_message, check_point_in_composition):
11492 Likewise.
11493 * xterm.h (set_vertical_scroll_bar): Likewise.
11494 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11495 (message_buf_print, scratch_glyph_row, displayed_buffer):
11496 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11497 (get_next_display_element, show_mouse_face, window_box_edges):
11498 (frame_to_window_pixel_xy, check_point_in_composition):
11499 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11500 (glyph_to_pixel_coords): Remove; unused.
11501
16390cd2
PE
11502 * dired.c (file_name_completion): Now static.
11503
11504 * dbusbind.c (xd_in_read_queued_messages): Now static.
11505
a25f4dfa
PE
11506 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11507 * data.c (circular_list_error): Remove.
11508
14a9c8df
PE
11509 * commands.h (last_point_position, last_point_position_buffer):
11510 (last_point_position_window): Remove decls.
11511 * keyboard.c: Make these variables static.
11512
04f2d78b
CB
11513 * coding.h (coding, code_convert_region, encode_coding_gap):
11514 Remove decls.
74ab6df5
PE
11515 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11516 (iso_code_class, detect_coding, code_convert_region): Now static.
11517 (encode_coding_gap): Remove; unused.
11518
38dfbee1
PE
11519 * chartab.c (chartab_chars, chartab_bits): Now static.
11520
a2cb4e63
PE
11521 * charset.h (charset_iso_8859_1): Remove decl.
11522 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11523 Now static.
11524
127198fd
PE
11525 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11526 * ccl.c (Vccl_program_table): Now static.
11527 (check_ccl_update): Remove; unused.
11528
d85b608f
PE
11529 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11530 * category.h: ... from here.
11531 * category.c (check_category_table, set_category_set): Now static.
11532
31cd66f3
PE
11533 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11534 * lisp.h: Remove these decls.
11535
c358e587
PE
11536 * buffer.c (buffer_count): Remove unused var.
11537
e78aecca
PE
11538 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11539 so that it's not optimized away.
11540 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11541 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11542 exported only to the debugger.
11543
e192d7d3 11544 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11545 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11546
92470028
PE
11547 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11548 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11549 was inaccessible from Lisp.
11550 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11551 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11552
244ed907
PE
11553 alloc.c: Import and export fewer symbols, and remove unused items.
11554 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11555 is defined.
11556 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11557 it's not optimized away by whole-program optimization.
11558 (message_enable_multibyte, free_misc): Remove.
11559 (catchlist, handlerlist, mark_backtrace):
11560 Declare only if BYTE_MARK_STACK.
11561 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11562 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11563 (message_enable_multibyte): Remove decl.
11564 (free_misc, interval_free_list, float_block, float_block_index):
11565 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11566 (cons_free_list, last_marked_index):
11567 Now static.
11568 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11569 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11570 (mark_backtrace): Define only if BYTE_MARK_STACK.
11571 * xdisp.c (message_enable_multibyte): Now static.
11572
61c2b50e 11573 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11574 This makes it easier for human readers (and static analyzers)
11575 to see whether these variables are used from other modules.
11576 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11577 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11578 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11579 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11580 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11581 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11582 * xmenu.c, xselect.c:
11583 Declare Q* vars static if they are not used in other modules.
11584 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11585 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11586 Remove decls of unexported vars.
11587 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11588
95c82688
PE
11589 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11590
16a97296
PE
11591 Make Emacs functions such as Fatom 'static' by default.
11592 This makes it easier for human readers (and static analyzers)
11593 to see whether these functions can be called from other modules.
11594 DEFUN now defines a static function. To make the function external
11595 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11596 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11597 (Finit_image_library):
16a97296
PE
11598 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11599 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11600 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11601 Remove decls, since these functions are now static.
11602 (Funintern, Fget_internal_run_time): New decls, since these functions
11603 were already external.
95c82688 11604
16a97296
PE
11605 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11606 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11607 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11608 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11609 * keyboard.c, keymap.c, lread.c:
11610 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11611 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11612 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11613 Mark functions with DEFUE instead of DEFUN,
11614 if they are used in other modules.
11615 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11616 decls for now-static functions.
11617 * buffer.h (Fdelete_overlay): Remove decl.
11618 * callproc.c (Fgetenv_internal): Mark as internal.
11619 * composite.c (Fremove_list_of_text_properties): Remove decl.
11620 (Fcomposition_get_gstring): New forward static decl.
11621 * composite.h (Fcomposite_get_gstring): Remove decl.
11622 * dired.c (Ffile_attributes): New forward static decl.
11623 * doc.c (Fdocumntation_property): New forward static decl.
11624 * eval.c (Ffetch_bytecode): New forward static decl.
11625 (Funintern): Remove extern decl; now in .h file where it belongs.
11626 * fileio.c (Fmake_symbolic_link): New forward static decl.
11627 * image.c (Finit_image_library): New forward static decl.
11628 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11629 * intervals.h (Fprevious_property_change):
11630 (Fremove_list_of_text_properties): Remove decls.
11631 * keyboard.c (Fthis_command_keys): Remove decl.
11632 (Fcommand_execute): New forward static decl.
11633 * keymap.c (Flookup_key): New forward static decl.
11634 (Fcopy_keymap): Now static.
11635 * keymap.h (Flookup_key): Remove decl.
11636 * process.c (Fget_process): New forward static decl.
11637 (Fprocess_datagram_address): Mark as internal.
11638 * syntax.c (Fsyntax_table_p): New forward static decl.
11639 (skip_chars): Remove duplicate decl.
11640 * textprop.c (Fprevious_property_change): New forward static decl.
11641 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11642 Now internal.
11643 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11644 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11645
785bbd42
PE
11646 * editfns.c (Fformat): Remove unreachable code.
11647
8b913b57
AS
116482011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11649
11650 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11651 change. (Bug#8496)
11652
a6744a35
EZ
116532011-04-13 Eli Zaretskii <eliz@gnu.org>
11654
11655 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11656 when at ZV. (Bug#8487)
11657
e7974947
AS
116582011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11659
baad03f0
AS
11660 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11661 (Bug#8437)
11662 * keyboard.c (parse_tool_bar_item): Likewise.
11663 * sound.c (sound_cleanup, alsa_close): Likewise.
11664 * termcap.c (tgetent): Likewise.
11665 * xfns.c (x_default_font_parameter): Likewise.
11666 * xsettings.c (read_and_apply_settings): Likewise.
11667
e7974947
AS
11668 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11669 (overrun_check_free): Protoize.
11670
28272684
PE
116712011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11672
11673 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11674 since callers should never pass a negative size.
11675 Change the signature to match that of plain 'read' and 'write'; see
11676 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11677 * lisp.h: Update prototypes of emacs_write and emacs_read.
11678
11997c76
EZ
116792011-04-11 Eli Zaretskii <eliz@gnu.org>
11680
11681 * xdisp.c (redisplay_window): Don't try to determine the character
11682 position of the scroll margin if the window start point w->startp
e896f03c 11683 is outside the buffer's accessible region. (Bug#8468)
11997c76 11684
8a2cbd72
EZ
116852011-04-10 Eli Zaretskii <eliz@gnu.org>
11686
11687 Fix write-region and its subroutines for buffers > 2GB.
11688 * fileio.c (a_write, e_write): Modify declaration of arguments and
11689 local variables to support buffers larger than 2GB.
11690 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11691
11692 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11693 argument, local variables, and return value.
11694
11695 * lisp.h: Update prototypes of emacs_write and emacs_read.
11696
11697 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11698
4073e537 116992011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11700
1ebfdcb6
PE
11701 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11702
b2ded58d
PE
11703 Fix more problems found by GCC 4.6.0's static checks.
11704
7d66342c
PE
11705 * xdisp.c (vmessage): Use a better test for character truncation.
11706
bbf47d44
PE
11707 * charset.c (load_charset_map): <, not <=, for optimization,
11708 and to avoid potential problems with integer overflow.
9248994d 11709 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11710 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11711 * editfns.c (Fformat): Likewise.
1e69125e 11712 * syntax.c (skip_chars): Likewise.
3befa583 11713
e3019616
PE
11714 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11715 This also lets GCC 4.6.0 generate slightly better loop code.
11716
becfa255
PE
11717 * callint.c (Fcall_interactively): <, not <=, for optimization.
11718 (Fcall_interactively): Count the number of arguments produced,
11719 not the number of arguments given. This is simpler and lets GCC
11720 4.6.0 generate slightly better code.
11721
dae0cd48
PE
11722 * ftfont.c: Distingish more carefully between FcChar8 and char.
11723 The previous code passed unsigned char * to a functions like
11724 strlen and xstrcasecmp that expect char *, which does not
11725 conform to the C standard.
11726 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11727 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11728 char * when the C standard requires it.
11729
76032d70
PE
11730 * keyboard.c (read_char): Remove unused var.
11731
eb3f1cc8
PE
11732 * eval.c: Port to Windows vsnprintf (Bug#8435).
11733 Include <limits.h>.
11734 (SIZE_MAX): Define if the headers do not.
11735 (verror): Do not give up if vsnprintf returns a negative count.
11736 Instead, grow the buffer. This ports to Windows vsnprintf, which
11737 does not conform to C99. Problem reported by Eli Zaretskii.
11738 Also, simplify the allocation scheme, by avoiding the need for
11739 calling realloc, and removing the ALLOCATED variable.
11740
70476b54
PE
11741 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11742
12020a9e
PE
11743 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11744 But keep the doprint source code for now, as we might revamp it
11745 and use it again (Bug#8435).
ea6c7ae6
PE
11746 * lisp.h (doprnt): Remove.
11747 * Makefile.in (base_obj): Remove doprnt.o.
11748 * deps.mk (doprnt.o): Remove.
11749
5fdb398c
PE
11750 error: Print 32- and 64-bit integers portably (Bug#8435).
11751 Without this change, on typical 64-bit hosts error ("...%d...", N)
11752 was used to print both 32- and 64-bit integers N, which relied on
11753 undefined behavior.
61bdb816 11754 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11755 * lisp.h (error, verror): Mark as printf-like functions.
11756 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11757 Report overflow in size calculations when allocating printf buffer.
11758 Do not truncate output string at its first null byte.
11759 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11760 Truncate the output at a character boundary, since vsnprintf does not
11761 do that.
11762 * charset.c (check_iso_charset_parameter): Convert internal
11763 character to string before calling 'error', since %c now has the
11764 printf meaning.
11765 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11766 overflow when computing char to be passed to 'error'. Do not
11767 pass Lisp_Object to 'error'; pass the integer instead.
11768 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11769 formatted with plain %d.
11770
b189fa66
PE
11771 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11772
bff87ef0
PE
11773 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11774
7e2cac20
PE
11775 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11776
ce4d90b5
PE
11777 * xterm.c (x_catch_errors): Remove duplicate declaration.
11778
266c9547
PE
11779 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11780
79c49ad2
PE
11781 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11782
368f4090
JM
117832011-04-10 Jim Meyering <meyering@redhat.com>
11784
11785 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11786 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11787 return ssize_t not "int", and use size_t as the buffer length.
11788 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11789 * gnutls.h: Update declarations.
11790 * process.c (read_process_output): Use ssize_t, to match.
11791 (send_process): Likewise.
11792
a32d4040
CY
117932011-04-09 Chong Yidong <cyd@stupidchicken.com>
11794
11795 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11796
8546720e 117972011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11798
04f2d78b
CB
11799 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11800 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11801
8546720e
GM
11802 * xterm.c (handle_one_xevent):
11803 * xmenu.c (create_and_show_popup_menu):
11804 * xselect.c (x_decline_selection_request)
11805 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11806
0a2f5c1a 118072011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11808
11809 Fix some uses of `int' instead of EMACS_INT.
11810 * search.c (string_match_1, fast_string_match)
11811 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11812 (scan_buffer, find_next_newline_no_quit)
11813 (find_before_next_newline, search_command, Freplace_match)
11814 (Fmatch_data): Make some `int' variables be EMACS_INT.
11815
11816 * xdisp.c (display_count_lines): 3rd argument and return value now
11817 EMACS_INT. All callers changed.
11818 (pint2hrstr): Last argument is now EMACS_INT.
11819
11820 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11821 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11822 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11823 (decode_coding_utf_16, decode_coding_emacs_mule)
11824 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11825 (decode_coding_ccl, decode_coding_charset)
11826 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11827 (decode_coding_iso_2022, decode_coding_emacs_mule)
11828 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11829 <char_offset, last_offset>: Declare EMACS_INT.
11830 (encode_coding_utf_8, encode_coding_utf_16)
11831 (encode_coding_emacs_mule, encode_invocation_designation)
11832 (encode_designation_at_bol, encode_coding_iso_2022)
11833 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11834 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11835 Declare EMACS_INT.
11836 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11837 (encode_invocation_designation): Last argument P_NCHARS is now
11838 EMACS_INT.
11839 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11840 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11841
11842 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11843 All users changed.
11844
11845 * ccl.c (Fccl_execute_on_string): Declare some variables
11846 EMACS_INT.
11847
8546720e 118482011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11849
11850 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11851
4e19a977
CS
118522011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11853
11854 * process.c (Fformat_network_address): Doc fix.
11855
87302331
R
118562011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11857
ee7683eb 11858 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11859
cbb59342
CY
118602011-04-08 Chong Yidong <cyd@stupidchicken.com>
11861
11862 * keyboard.c (read_char): Call Lisp function help-form-show,
11863 instead of using internal_with_output_to_temp_buffer.
11864 (Qhelp_form_show): New var.
e0d38eeb 11865 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11866
11867 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11868
11869 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11870
e67a13ab
CY
118712011-04-06 Chong Yidong <cyd@stupidchicken.com>
11872
04f2d78b
CB
11873 * process.c (Flist_processes): Remove to Lisp.
11874 (list_processes_1): Delete.
e67a13ab 11875
973f782d
EZ
118762011-04-06 Eli Zaretskii <eliz@gnu.org>
11877
7c106b1e
EZ
11878 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11879
973f782d
EZ
11880 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11881
41cf7d1a 118822011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11883
ca23cc88
PE
11884 Fix more problems found by GCC 4.6.0's static checks.
11885
f390e2d5
PE
11886 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11887
42eea0d0
PE
11888 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11889
b69769da 11890 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11891
f9541e84
PE
11892 * xdisp.c (vmessage): Mark as a printf-like function.
11893
13841b55
PE
11894 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11895
c136c10f
PE
11896 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11897
5e2d4a30
PE
11898 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11899 printf-like functions.
11900 (tiff_load): Add casts to remove these marks before passing them
11901 to system-supplied API.
11902
583f48b9
PE
11903 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11904
b25d760e
PE
11905 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11906 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11907 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11908 directly, rather than having caller test rule sign. This avoids
11909 some unnecessary tests.
11910 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11911 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11912 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11913
bc7b6697 11914 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11915 (xfont_open): Avoid unnecessary tests.
bc7b6697 11916
27ccc379
PE
11917 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11918
dcd5c89a
PE
11919 * composite.h, composite.c (composition_gstring_put_cache):
11920 Use EMACS_INT, not int, for length.
11921
b13a45c6
PE
11922 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11923 breaking out part of COMPOSITION_DECODE_RULE.
11924 (COMPOSITION_DECODE_RULE): Use it.
11925 * composite.c (get_composition_id): Remove unused local vars,
11926 by using the new macro.
11927
1e792e4d
PE
11928 * textprop.c (set_text_properties_1): Change while to do-while,
11929 since the condition is always true at first.
11930
dc6c6455 11931 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11932 (interval_deletion_adjustment): Return unsigned value.
11933 All uses changed.
dc6c6455 11934
aba7731a
PE
11935 * process.c (list_processes_1, create_pty, read_process_output):
11936 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11937 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11938 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11939 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11940 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11941
fdfc4bf3
PE
11942 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11943
fca8fe46 11944 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11945 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11946
06a0259a 11947 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11948 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11949 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11950
e7b9e80f
PE
11951 * print.c (print_error_message): Avoid int overflow.
11952
56201685
PE
11953 * font.c (font_list_entities): Redo for clarity,
11954 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11955
78834453 11956 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11957 (font_score): Avoid potential overflow in diff calculation.
78834453 11958
0bc0b309 11959 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11960 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11961
e610eaca
PE
11962 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11963
b895abce
PE
11964 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11965 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11966 can always succeed if overflow has undefined behavior.
11967
1f1d9321 11968 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11969 (wordify): Omit three unnecessary tests.
1f1d9321 11970
c59478bc
PE
11971 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11972 All callers changed. This avoids the need for an unused var.
11973
79b73827
PE
11974 * casefiddle.c (casify_region): Remove var that is set but not used.
11975
a4db5dfe
PE
11976 * dired.c (file_name_completion): Remove var that is set but not used.
11977
43aae36e
PE
11978 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11979
2a47c44d 11980 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11981 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11982
a37c69bf
PE
11983 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11984 Check for integer overflow on size calculations.
11985
328ab8e7
PE
11986 * buffer.c (Fprevious_overlay_change): Remove var that is set
11987 but not used.
11988
e5a2a5cb
PE
11989 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11990 Remove vars that are set but not used.
8d84a6eb 11991 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11992 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11993
a60e5f68
PE
11994 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11995
f661cb61 11996 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11997 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11998
f0397f5a
PE
11999 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12000 that are set but not used.
12001
8664db06 12002 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12003 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12004
6abdaa4a
PE
12005 * xselect.c (x_get_local_selection, x_handle_property_notify):
12006 Remove vars that are set but not used.
12007
0ce7538d 12008 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12009 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12010
9ae848fc
PE
12011 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12012 Remove var that is set but not used.
0b918413
PE
12013 (scroll_bar_windows_size): Now size_t, not int.
12014 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12015 Check for overflow.
9ae848fc 12016
a5a62657
PE
12017 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12018 (map_tty_color) [!defined MSDOS]: Likewise.
12019
5c5cdd39
PE
12020 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12021
66ebf983
PE
12022 * coding.c: Remove vars that are set but not used.
12023 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12024 All callers changed.
12025 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12026 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12027 (decode_coding_charset): Remove vars that are set but not used.
12028
1be4d761
PE
12029 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12030 that is set but not used.
12031
47553fa8
PE
12032 * print.c (print_object): Remove var that is set but not used.
12033
1f7196bf 12034 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12035 The gnulib version avoids calling malloc in the usual case,
12036 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12037 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12038 * filelock.c (current_lock_owner): Likewise.
12039 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12040 * sysdep.c: Include allocator.h, careadlinkat.h.
12041 (emacs_no_realloc_allocator): New static constant.
12042 (emacs_readlink): New function.
fdb61804
PE
12043 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12044 ../lib/careadlinkat.h.
d1fdcab7 12045
f84c17c7
SM
120462011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12047
12048 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12049 first non-nil return value).
12050
ef3862ad
JD
120512011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12052
12053 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12054 if not defined (Bug#8403).
12055
376a7006
JB
120562011-04-02 Juanma Barranquero <lekktu@gmail.com>
12057
12058 * xdisp.c (display_count_lines): Remove parameter `start',
12059 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12060 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12061 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12062 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12063 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12064 and thereabouts. All callers changed.
12065 (get_per_char_metric): Remove parameter `f', unused since
12066 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12067
6ca3801d
JM
120682011-04-02 Jim Meyering <meyering@redhat.com>
12069
12070 do not dereference NULL upon failed strdup
12071 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12072 (ns_get_family): Likewise.
12073
d8e2b5ba
JB
120742011-04-02 Juanma Barranquero <lekktu@gmail.com>
12075
12076 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12077
8c74fcbd
JD
120782011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12079
12080 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12081 later (Bug#8403).
12082
7200d79c
SM
120832011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12084
03408648 12085 Add lexical binding.
7200d79c 12086
03408648
SM
12087 * window.c (Ftemp_output_buffer_show): New fun.
12088 (Fsave_window_excursion):
12089 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12090
12091 * lread.c (lisp_file_lexically_bound_p): New function.
12092 (Fload): Bind Qlexical_binding.
12093 (readevalloop): Remove `evalfun' arg.
12094 Bind Qinternal_interpreter_environment.
12095 (Feval_buffer): Bind Qlexical_binding.
12096 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12097 Mark as dynamic.
12098 (syms_of_lread): Declare `lexical-binding'.
12099
12100 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12101
12102 * keyboard.c (eval_dyn): New fun.
12103 (menu_item_eval_property): Use it.
ca105506
SM
12104
12105 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12106
03408648
SM
12107 * fns.c (concat, mapcar1): Accept byte-code-functions.
12108
12109 * eval.c (Fsetq): Handle lexical vars.
12110 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12111 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12112 (FletX, Flet): Obey lexical binding.
12113 (Fcommandp): Handle closures.
12114 (Feval): New `lexical' arg.
12115 (eval_sub): New function extracted from Feval. Use it almost
12116 everywhere where Feval was used. Look up vars in lexical env.
12117 Handle closures.
12118 (Ffunctionp): Move from subr.el.
12119 (Ffuncall): Handle closures.
12120 (apply_lambda): Remove `eval_flags'.
12121 (funcall_lambda): Handle closures and new byte-code-functions.
12122 (Fspecial_variable_p): New function.
12123 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12124 but without exporting it to Lisp.
23aba0ea 12125
23aba0ea 12126 * doc.c (Fdocumentation, store_function_docstring):
03408648 12127 * data.c (Finteractive_form): Handle closures.
23aba0ea 12128
03408648
SM
12129 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12130 interactive spec.
ba83908c 12131
04f2d78b
CB
12132 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12133 New byte-codes.
03408648
SM
12134 (exec_byte_code): New function extracted from Fbyte_code to handle new
12135 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12136
03408648 12137 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12138
03408648 12139 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12140
e2abce01
JB
121412011-03-31 Juanma Barranquero <lekktu@gmail.com>
12142
12143 * xdisp.c (redisplay_internal): Fix prototype.
12144
63696a73 121452011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12146
63696a73 12147 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12148 (try_scrolling): Use it when setting scroll_limit.
12149 Limit scrolling to 100 screen lines.
63696a73
EZ
12150 (redisplay_window): Even when falling back on "recentering",
12151 position point in the window according to scroll-conservatively,
12152 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12153
12154 (try_scrolling): When point is above the window, allow searching
12155 as far as scroll_max, or one screenful, to compute vertical
12156 distance from PT to the scroll margin position. This prevents
12157 try_scrolling from unnecessarily failing when
12158 scroll-conservatively is set to a value slightly larger than the
12159 window height. Clean up the case of PT below the margin at bottom
12160 of window: scroll_max can no longer be INT_MAX. When aggressive
12161 scrolling is in use, don't let point enter the opposite scroll
12162 margin as result of the scroll.
12163 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12164 threshold of 100 lines for never-recentering scrolling.
12165
e4cc2dfc
JB
121662011-03-31 Juanma Barranquero <lekktu@gmail.com>
12167
12168 * dispextern.h (move_it_by_lines):
12169 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12170 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12171 (message_log_check_duplicate): Remove parameters `prev_bol' and
12172 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12173 (redisplay_internal): Remove parameter `preserve_echo_area',
12174 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12175
12176 * indent.c (Fvertical_motion):
12177 * window.c (window_scroll_pixel_based, Frecenter):
12178 Don't pass `need_y_p' to `move_it_by_lines'.
12179
1c470562
SM
121802011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12181
44f230aa
SM
12182 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12183 steal a few bits to be more compact.
12184 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12185 Remove unneeded casts.
12186
1c470562
SM
12187 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12188
888adce9
ZK
121892011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12190
12191 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12192 binding" message (bug#7967).
12193
f838ed7b
PE
121942011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12195
77861b95
PE
12196 Fix more problems found by GCC 4.6.0's static checks.
12197
de6dbc14
PE
12198 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12199 Remove unused local var.
12200
f838ed7b
PE
12201 * editfns.c (Fmessage_box): Remove unused local var.
12202
792c7b2b
PE
12203 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12204 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12205 Omit unused local vars.
c499e557 12206 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12207 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12208 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12209 Omit unused local var.
12210
ba0165e1
PE
12211 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12212 Don't assume string length fits in int.
32ad8845 12213 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12214 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12215
3c59b4c9
PE
12216 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12217 instead of alloca (Bug#8344).
12218
a3eed478 12219 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12220 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12221
eb4d412d
PE
12222 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12223
1658b401
PE
12224 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12225 concerns.
12226
12227 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12228
12229 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12230
9a2c6e05
PE
12231 * keyboard.c (syms_of_keyboard): Use the same style as later
12232 in this function when indexing through an array. This also
12233 works around GCC bug 48267.
12234
03d0a109
PE
12235 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12236
44f730c8
PE
12237 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12238
fe75f926
PE
12239 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12240 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12241
ffa8c828
PE
12242 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12243 This avoids undefined behavior on integer overflow, and is a bit
12244 more convenient anyway since it is compared to a size_t variable.
12245
c5101a77
PE
12246 Variadic C functions now count arguments with size_t, not int.
12247 This avoids an unnecessary limitation on 64-bit machines, which
12248 caused (substring ...) to crash on large vectors (Bug#8344).
12249 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12250 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12251 All variadic functions and their callers changed accordingly.
c5101a77
PE
12252 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12253 * data.c (arith_driver, float_arith_driver): Likewise.
12254 * editfns.c (general_insert_function): Likewise.
12255 * eval.c (struct backtrace.nargs, interactive_p)
12256 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12257 (funcall_lambda, mark_backtrace): Likewise.
12258 * fns.c (concat): Likewise.
12259 * frame.c (x_set_frame_parameters): Likewise.
12260 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12261 0 if not found, not -1. All callers changed.
12262
dd3f25f7
PE
12263 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12264 (stack_copy_size): Now size_t, not int.
12265 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12266
461c2ab9
JB
122672011-03-28 Juanma Barranquero <lekktu@gmail.com>
12268
12269 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12270 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12271 All callers changed.
12272
12273 * lisp.h (multibyte_char_to_unibyte):
12274 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12275 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12276 * character.h (CHAR_TO_BYTE8):
12277 * cmds.c (internal_self_insert):
12278 * editfns.c (general_insert_function):
12279 * keymap.c (push_key_description):
12280 * search.c (Freplace_match):
12281 * xdisp.c (message_dolog, set_message_1): All callers changed.
12282
f6d62986
SM
122832011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12284
12285 * keyboard.c (safe_run_hook_funcall): New function.
12286 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12287 don't set the hook to nil, but remove the offending function instead.
12288 (Qcommand_hook_internal): Remove, unused.
12289 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12290 Vcommand_hook_internal.
12291
12292 * eval.c (enum run_hooks_condition): Remove.
12293 (funcall_nil, funcall_not): New functions.
12294 (run_hook_with_args): Call each function through a `funcall' argument.
12295 Remove `cond' argument, now redundant.
12296 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12297 (Frun_hook_with_args_until_failure): Adjust accordingly.
12298 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12299
1db5b1ad
JB
123002011-03-28 Juanma Barranquero <lekktu@gmail.com>
12301
12302 * dispextern.h (string_buffer_position): Remove declaration.
12303
12304 * print.c (strout): Remove parameter `multibyte', unused since
12305 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12306
12307 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12308 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12309 All callers changed.
12310
12311 * w32.c (_wsa_errlist): Use braces for struct initializers.
12312
12313 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12314 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12315 All callers changed.
12316 (string_buffer_position): Likewise. Also, make static (it's never
12317 used outside xdisp.c).
12318 (cursor_row_p): Remove parameter `w', unused since
12319 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12320 (decode_mode_spec): Remove parameter `precision', introduced during
12321 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12322 All callers changed.
12323
5ffb62aa
JD
123242011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12325
12326 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12327
461c2ab9 123282011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12329
12330 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12331 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12332 (ns_update_auto_hide_menu_bar): New functions.
12333 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12334 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12335 ns_constrain_all_frames.
12336 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12337 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12338
5c380ffb
JD
123392011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12340
12341 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12342
9af30bdf
GM
123432011-03-27 Glenn Morris <rgm@gnu.org>
12344
12345 * syssignal.h: Replace RETSIGTYPE with void.
12346 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12347 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12348 Replace SIGTYPE with void everywhere.
12349 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12350 * s/template.h (SIGTYPE): Remove commented out definition.
12351
e2abce01
JB
123522011-03-26 Eli Zaretskii <eliz@gnu.org>
12353
12354 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12355 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12356
f868cd8a
JB
123572011-03-26 Juanma Barranquero <lekktu@gmail.com>
12358
59eb0929
JB
12359 * w32.c (read_unc_volume): Use parameter `henum', instead of
12360 global variable `wget_enum_handle'.
12361
12362 * keymap.c (describe_vector): Remove parameters `indices' and
12363 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12364 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12365
f868cd8a
JB
12366 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12367
12368 * keyboard.c (timer_check): Remove parameter `do_it_now',
12369 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12370 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12371 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12372
12373 * keyboard.c (read_char):
12374 * w32menu.c (w32_menu_display_help):
12375 * xmenu.c (show_help_event, menu_help_callback):
12376 Adjust calls to `show_help_echo'.
12377
12378 * gtkutil.c (xg_maybe_add_timer):
12379 * keyboard.c (readable_events):
12380 * process.c (wait_reading_process_output):
12381 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12382
12383 * insdel.c (adjust_markers_gap_motion):
12384 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12385 (gap_left, gap_right): Don't call it.
12386
2ecf6fdb
CY
123872011-03-25 Chong Yidong <cyd@stupidchicken.com>
12388
12389 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12390 incurred during fontification.
12391
6b1f9ba4
JB
123922011-03-25 Juanma Barranquero <lekktu@gmail.com>
12393
12394 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12395 (DEFVAR_PER_BUFFER): Don't pass it.
12396
12397 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12398 (scrolling_window): Don't pass it.
12399
0f4a96b5
JB
124002011-03-25 Juanma Barranquero <lekktu@gmail.com>
12401
12402 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12403
12404 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12405 and `suffix'.
12406 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12407 of variables specific to SELinux and computation of `encoded_absname'.
12408
12409 * image.c (XPutPixel): Remove unused variable `height'.
12410
12411 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12412
12413 * unexw32.c (get_section_info): Remove unused variable `section'.
12414
12415 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12416 (system_process_attributes): Remove unused variable `sess'.
12417 (sys_read): Remove unused variable `err'.
12418
12419 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12420 (w32_wnd_proc): Remove unused variable `isdead'.
12421 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12422 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12423 (x_create_tip_frame): Remove unused variable `tem'.
12424
12425 * w32inevt.c (w32_console_read_socket):
12426 Remove unused variable `no_events'.
12427
12428 * w32term.c (x_draw_composite_glyph_string_foreground):
12429 Remove unused variable `width'.
12430
1149507c
JB
124312011-03-24 Juanma Barranquero <lekktu@gmail.com>
12432
12433 * w32term.c (x_set_glyph_string_clipping):
12434 Don't pass uninitialized region to CombineRgn.
12435
9c88f339
JB
124362011-03-23 Juanma Barranquero <lekktu@gmail.com>
12437
12438 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12439 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12440 (Fx_close_connection): Remove unused variable `i'.
12441
12442 * w32font.c (w32font_draw): Return number of glyphs.
12443 (w32font_open_internal): Remove unused variable `i'.
12444 (w32font_driver): Add missing initializer.
12445
12446 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12447 (fill_in_menu): Remove unused variable `items_added'.
12448
12449 * w32term.c (last_mouse_press_frame): Remove static global variable.
12450 (w32_clip_to_row): Remove unused variable `f'.
12451 (x_delete_terminal): Remove unused variable `i'.
12452
12453 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12454 (NOTHING): Remove unused static global variable.
12455 (uniscribe_check_otf): Remove unused variable `table'.
12456 (uniscribe_font_driver): Add missing initializers.
12457
dee091a3
JD
124582011-03-23 Julien Danjou <julien@danjou.info>
12459
12460 * term.c (Fsuspend_tty, Fresume_tty):
12461 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12462 * window.c (temp_output_buffer_show):
12463 * insdel.c (signal_before_change):
12464 * frame.c (Fhandle_switch_frame):
12465 * fileio.c (Fdo_auto_save):
12466 * emacs.c (Fkill_emacs):
12467 * editfns.c (save_excursion_restore):
12468 * cmds.c (internal_self_insert):
12469 * callint.c (Fcall_interactively):
12470 * buffer.c (Fkill_all_local_variables):
12471 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12472 Use Frun_hooks.
0f4a96b5 12473 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12474 unconditionally since it does the check itself.
dee091a3 12475
2c520ab5 124762011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12477
c9c49752
PE
12478 Fix more problems found by GCC 4.5.2's static checks.
12479
8abc3f12
PE
12480 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12481 the first time through the loop, since we know p0 < p1 then.
12482 This also avoids a gcc -Wstrict-overflow warning.
12483
a2d26660
PE
12484 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12485 leading to a memory leak, possible in functions like
12486 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12487 of objects (Bug#8318).
a2d26660 12488
916c72e9
PE
12489 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12490 that could (at least in theory) be that large.
12491
19ab8a18
PE
12492 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12493 This is less likely to overflow, and avoids undefined behavior if
12494 overflow does occur. All callers changed. Use strtoul to scan
12495 for the unsigned long integer.
b7cbbd6f
PE
12496 (pint2hrstr): Simplify and tune code slightly.
12497 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12498
f0641eff
PE
12499 * scroll.c (do_scrolling): Work around GCC bug 48228.
12500 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12501
7f650bb9
PE
12502 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12503 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12504 (validate_x_resource_name): Simplify count usage.
12505 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12506
37dd57d1
PE
12507 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12508 fail (Bug#8306).
81e56e61 12509
699979fc 12510 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12511
401bf9b4
PE
12512 * process.c (Fmake_network_process): Use socklen_t, not int,
12513 where POSIX says socklen_t is required in portable programs.
12514 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12515 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12516 (Fmake_network_process, server_accept_connection):
12517 (wait_reading_process_output, read_process_output):
12518 Likewise.
12519
b93aacde
PE
12520 * process.c: Rename or move locals to avoid shadowing.
12521 (list_processes_1, Fmake_network_process):
12522 (read_process_output_error_handler, exec_sentinel_error_handler):
12523 Rename or move locals.
4dc343ee 12524 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12525 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12526 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12527 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12528 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12529
af8a867c 12530 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12531 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12532 Include tparam.h instead, since it declares them.
af8a867c
PE
12533 * cm.h (PC): Remove extern decl; tparam.h now does this.
12534 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12535 * terminfo.c: Include tparam.h, to check interfaces.
12536 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12537 (tparam): Adjust signature to match interface in tparam.h;
12538 this removes some undefined behavior. Check that outstring and len
12539 are zero, which they always are with Emacs.
12540 * tparam.h (PC, BC, UP): New extern decls.
12541
0248044d 12542 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12543 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12544
8ff096c1 12545 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12546 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12547 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12548 (ftfont_list): Remove unused local.
49eaafba
PE
12549 (get_adstyle_property, ftfont_pattern_entity):
12550 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12551 Rename locals to avoid shadowing.
8ff096c1 12552
e2be39f6
PE
12553 * xfont.c (xfont_list_family): Mark var as initialized.
12554
c9735e30
PE
12555 * xml.c (make_dom): Now static.
12556
8f5201ae
PE
12557 * composite.c (composition_compute_stop_pos): Rename local to
12558 avoid shadowing.
b246f932
PE
12559 (composition_reseat_it): Remove unused locals.
12560 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12561 (composition_update_it): Mark var as initialized.
11b61122
PE
12562 (find_automatic_composition): Mark vars as initialized,
12563 with a FIXME (Bug#8290).
8f5201ae 12564
760fbc2c
PE
12565 character.h: Rename locals to avoid shadowing.
12566 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12567 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12568 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12569 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12570 to avoid shadowing.
12571
ff08eb85
PE
12572 * textprop.c (property_change_between_p): Remove; unused.
12573
fc7bf025
PE
12574 * intervals.c (interval_start_pos): Now static.
12575
235d7abc
PE
12576 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12577
44f230aa
SM
12578 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12579 Rename locals to avoid shadowing.
3e7d6594 12580
50060332
PE
12581 * sound.c (wav_play, au_play, Fplay_sound_internal):
12582 Fix pointer signedness.
d01f234b 12583 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12584 (wav_play): Initialize a variable to 0, to prevent undefined
12585 behavior (Bug#8278).
50060332 12586
c4fc4e30
PE
12587 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12588
918436ed
PE
12589 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12590
c939f91b
PE
12591 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12592 clobbering (Bug#8298).
b9c7f648
PE
12593 * sysdep.c (sys_subshell): Likewise.
12594 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12595
6bd8c144
PE
12596 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12597 This should get cleaned up, so that child_setup has the
12598 same signature on all platforms.
12599
7710357c 12600 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12601 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12602
c59da222
CY
126032011-03-22 Chong Yidong <cyd@stupidchicken.com>
12604
12605 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12606 not to be necessary, and produces flickering.
12607
66b87493
GM
126082011-03-20 Glenn Morris <rgm@gnu.org>
12609
12610 * config.in: Remove file.
12611
45b6f6d5
JB
126122011-03-20 Juanma Barranquero <lekktu@gmail.com>
12613
12614 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12615 are now in src/globals.h.
12616 (syms_of_minibuf): Remove spurious & from previous change.
12617
cd394be1 126182011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12619
12620 * minibuf.c (completing-read-function): New variable.
12621 (completing-read-default): Rename from completing-read.
12622 (completing-read): Call completing-read-function.
12623
b14e3e21
CY
126242011-03-19 Juanma Barranquero <lekktu@gmail.com>
12625
12626 * xfaces.c (Fx_load_color_file):
12627 Read color file from absolute filename (bug#8250).
12628
f2b726e6
JB
126292011-03-19 Juanma Barranquero <lekktu@gmail.com>
12630
12631 * makefile.w32-in: Update dependencies.
12632
09f6ff02
EZ
126332011-03-17 Eli Zaretskii <eliz@gnu.org>
12634
12635 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12636
29a6015a
PE
126372011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12638
a3a6c54e
PE
12639 Fix more problems found by GCC 4.5.2's static checks.
12640
b766f867
PE
12641 * process.c (make_serial_process_unwind, send_process_trap):
12642 (sigchld_handler): Now static.
12643
be02381c
PE
12644 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12645 That way, the code declares only the vars that it needs.
12646 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12647 * s/cygwin.h (PTY_ITERATION): Likewise.
12648 * s/darwin.h (PTY_ITERATION): Likewise.
12649 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12650
57048744
PE
12651 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12652 * process.c (allocate_pty): Don't declare stb unless it's needed.
12653
7914961c 12654 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12655 (CONSTANTLIM): Remove; unused.
12656 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12657 Define only if needed.
7914961c 12658
b3967b18
PE
12659 * unexelf.c (unexec): Name an expression,
12660 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12661 Use a different way to cause a compilation error if anyone uses
12662 n rather than nn, a way that does not involve shadowing.
73366a00 12663 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12664
29a6015a
PE
12665 * deps.mk (unexalpha.o): Remove; unused.
12666
43cfc33e 12667 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12668 * unexec.h: New file.
ce701a33
PE
12669 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12670 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12671 Depend on unexec.h.
12672 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12673 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12674 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12675 Change as necessary to match prototype in unexec.h.
ce701a33 12676
01f44d5a
PE
12677 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12678 shadowing.
4f63c6bb 12679 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12680
a6670b0b
PE
12681 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12682 Rename locals to avoid shadowing.
12683
cef2010d 12684 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12685 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12686
d4d7173a
PE
12687 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12688
f08b802a
PE
12689 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12690 warning when compiling print.c.
12691
3ddb0639
PE
12692 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12693 instead of using an uninitialized var.
5ad03b97 12694 (font_sort_entities): Mark var as initialized.
3ddb0639 12695
170a2692
PE
12696 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12697
e663c700
PE
12698 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12699 pointers to constants.
89bc529a 12700 (font_parse_fcname): Remove unused vars.
7b81e2d0 12701 (font_delete_unmatched): Now static.
ea838e10 12702 (font_get_spec): Remove; unused.
13a547c6
PE
12703 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12704 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12705 Rename or move locals to avoid shadowing.
e663c700 12706
2a80c887 12707 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12708 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12709
1384fa33 12710 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12711 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12712
8b2c52e9
PE
12713 * alloc.c (mark_backtrace): Move decl from here ...
12714 * lisp.h: ... to here, so that it can be checked.
12715
475545b5 12716 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12717 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12718 (lisp_indirect_variable): Name an expression,
12719 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12720 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12721
b1349114 12722 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12723 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12724 Use const pointer when appropriate.
b1349114 12725
a2928364
PE
12726 * lisp.h (get_system_name, get_operating_system_release):
12727 Move decls here, to check interfaces.
12728 * process.c (get_operating_system_release): Move decl to lisp.h.
12729 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12730 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12731 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12732 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12733 (Fformat_time_string, Fencode_time, Finsert_char):
12734 (Ftranslate_region_internal, Fformat):
12735 Rename or remove local vars to avoid shadowing.
9710023e 12736 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12737
a415e694
PE
12738 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12739 avoid shadowing.
12740
8ef4622d
PE
12741 * lisp.h (eassert): Check that the argument compiles, even if
12742 ENABLE_CHECKING is not defined.
12743
946f9a5b
PE
12744 * data.c (Findirect_variable): Name an expression, to avoid
12745 gcc -Wbad-function-cast warning.
112396d6 12746 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12747 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12748 (Fmake_variable_buffer_local, Fmake_local_variable):
12749 Mark variables as initialized.
52746918 12750 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12751
e5aab7e7 12752 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12753 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12754 Rename locals to avoid shadowing.
dff45157
PE
12755 (mark_stack): Move local variables into the #ifdef region where
12756 they're used.
7bc26fdb
PE
12757 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12758 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12759 needed otherwise.
12760 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12761 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12762 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12763
e5aab7e7
PE
12764 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12765 avoids undefined behavior in theory.
12766
4da60324
PE
12767 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12768
88043301
PE
12769 Use functions, not macros, for up- and down-casing (Bug#8254).
12770 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12771 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12772 to use the following functions instead of these macros.
12773 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12774 EMACS_INT, since callers assume the returned value fits in int.
12775 (upcase1): Likewise, for UPCASE_TABLE.
12776 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12777 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12778 the race-condition problem in the old DOWNCASE.
88043301 12779
19ed5445
PE
12780 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12781 Rename locals to avoid shadowing.
12782 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12783 (regex_compile, re_search_2, re_match_2_internal):
12784 Remove unused local vars.
952db0d7
PE
12785 (FREE_VAR): Rewrite so as not to use empty "else",
12786 which gcc can warn about.
da053e48 12787 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12788 (RETALLOC_IF): Define only if needed.
12789 (WORDCHAR_P): Likewise. This one is never needed, but is used
12790 only in a comment talking about a compiler bug, so put inside
12791 the #if 0 of that comment.
12792 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12793 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12794 Remove; unused.
19ed5445 12795
1f3561e4 12796 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12797 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12798 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12799
ded6f8f7
PE
12800 * search.c (simple_search): Remove unused var.
12801
dbd37a95
PE
12802 * dired.c (compile_pattern): Move decl from here ...
12803 * lisp.h: ... to here, so that it can be checked.
12804 (struct re_registers): New forward decl.
12805
7e47afad
PE
12806 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12807
85f24f61
PE
12808 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12809 All uses changed.
12810 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12811 Rename locals to avoid shadowing.
5671df8f 12812 (Fvertical_motion): Mark locals as initialized.
85f24f61 12813
181aa2be 12814 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12815 (casify_region): Mark local as initialized.
181aa2be 12816
930d429c
PE
12817 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12818
7082eac6
PE
12819 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12820 New macros, so that the caller can use some names other than
12821 gcpro1, gcpro2, etc.
12822 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12823 of the new macros.
12824 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12825 argument, for consistency with GCPRO2_VAR, etc: it is now the
12826 prefix of the variable, not the variable itself. All uses
12827 changed.
38b2c076
PE
12828 * dired.c (directory_files_internal, file_name_completion):
12829 Rename locals to avoid shadowing.
12830
15206ed9
PE
12831 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12832 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12833 dired.c's scmp function, had undefined behavior.
12834 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12835 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12836 * buffer.h: ... to here, because these macros use current_buffer,
12837 and the new implementation with inline functions needs to have
12838 current_buffer in scope now, rather than later when the macros
12839 are used.
12840 (downcase, upcase1): New static inline functions.
12841 (DOWNCASE, UPCASE1): Reimplement using these functions.
12842 This avoids undefined behavior in expressions like
12843 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12844 from race conditions in accessing the global variables
12845 case_temp1 and case_temp2.
12846 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12847 * lisp.h (case_temp1, case_temp2): Remove their decls.
12848 * character.h (ASCII_CHAR_P): Move from here ...
12849 * lisp.h: ... to here, so that the inline functions mentioned
12850 above can use them.
12851
4a6bea26
PE
12852 * dired.c (directory_files_internal_unwind): Now static.
12853
f14b7e14
PE
12854 * fileio.c (file_name_as_directory, directory_file_name):
12855 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12856 Now static.
2893f146
PE
12857 (file_name_as_directory): Use const pointers when appropriate.
12858 (Fexpand_file_name): Likewise. In particular, newdir might
12859 point at constant storage, so make it a const pointer.
fd4ead52 12860 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12861 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12862 signedness issues.
f839df0c
PE
12863 (Fset_file_times, Finsert_file_contents, auto_save_error):
12864 Rename locals to avoid shadowing.
f14b7e14 12865
5716756e 12866 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12867 (Ftry_completion, Fall_completions): Rename or remove locals
12868 to avoid shadowing.
5716756e 12869
b4c3046a
PE
12870 * marker.c (bytepos_to_charpos): Remove; unused.
12871
b45db522
PE
12872 * lisp.h (verify_bytepos, count_markers): New decls,
12873 so that gcc does not warn that these functions aren't declared.
12874
85876d07
PE
12875 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12876 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12877 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12878 (copy_text): Remove unused local var.
85876d07 12879
03d78a21 12880 * filelock.c (within_one_second): Now static.
b3dd38ab 12881 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12882
5df8f01b
PE
12883 * buffer.c (fix_overlays_before): Mark locals as initialized.
12884 (fix_start_end_in_overlays): Likewise. This function should be
12885 simplified by using pointers-to-pointers, but that's a different
12886 matter.
b1d876f1 12887 (switch_to_buffer_1): Now static.
8f54f30a
PE
12888 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12889 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12890
a70072c9 12891 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12892 Fix pointer signedness issue.
edced198
PE
12893 (sys_subshell): Mark local as volatile if checking for lint,
12894 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12895 (MAXPATHLEN): Define only if needed.
a70072c9 12896
a0977c44
PE
12897 * process.c (serial_open, serial_configure): Move decls from here ...
12898 * systty.h: ... to here, so that they can be checked.
12899
a884fdcc
PE
12900 * fns.c (get_random, seed_random): Move extern decls from here ...
12901 * lisp.h: ... to here, so that they can be checked.
12902
604efe86 12903 * sysdep.c (reset_io): Now static.
b8950c94 12904 (wait_for_termination_signal): Remove; unused.
604efe86 12905
38fc62d9
PE
12906 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12907 (copy_keymap_item, append_key, push_text_char_description):
12908 Now static.
1004a21a 12909 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12910 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12911 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12912 (describe_map_tree):
12913 Rename locals to avoid shadowing.
38fc62d9 12914
2f2650da
PE
12915 * keyboard.c: Declare functions static if they are not used elsewhere.
12916 (echo_char, echo_dash, cmd_error, top_level_2):
12917 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12918 (read_char, kbd_buffer_get_event, make_lispy_position):
12919 (make_lispy_event, make_lispy_movement, apply_modifiers):
12920 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12921 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12922 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12923 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12924 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12925
a053e86c 12926 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12927 (mark_kboards): Move decl here ...
12928 * alloc.c (mark_kboards): ... from here.
a053e86c 12929
4752793e
PE
12930 * lisp.h (force_auto_save_soon): New decl.
12931
74f10ca7 12932 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12933 (DEFINE_DUMMY_FUNCTION): New macro.
12934 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12935 Use it.
c03cd23f
PE
12936 (main): Add casts to avoid warnings
12937 if GCC considers string literals to be constants.
74f10ca7 12938
022e70d4
PE
12939 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12940
59d6fe83
PE
12941 * dbusbind.c: Pointer signedness fixes.
12942 (xd_signature, xd_append_arg, xd_initialize):
12943 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12944 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12945 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12946 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12947
78320123
PE
12948 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12949 if GCC considers string literals to be constants.
49cebcca 12950 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12951
35ac2a97
SM
129522011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12953
fb103ca9
SM
12954 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12955 (print_preprocess, print_object): New macro to fix last change.
12956
35ac2a97
SM
12957 * print.c (print_preprocess): Don't forget font objects.
12958
62973b41
JB
129592011-03-16 Juanma Barranquero <lekktu@gmail.com>
12960
12961 * emacs.c (USAGE3): Doc fixes.
12962
0e48bb22
AS
129632011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12964
12965 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12966 structure.
12967
7684e57b
JB
129682011-03-14 Juanma Barranquero <lekktu@gmail.com>
12969
12970 * lisp.h (VWindow_system, Qfile_name_history):
12971 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12972 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12973 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12974
12975 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12976 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12977
12978 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12979 * w32console.c (detect_input_pending, read_input_pending)
12980 (encode_terminal_code):
12981 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12982 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12983 (w32_system_caret_y, Qfile_name_history):
12984 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12985 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12986 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12987 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12988 * w32proc.c (Qlocal, report_file_error):
12989 * w32term.c (Vwindow_system, updating_frame):
12990 * w32uniscribe.c (initialized, uniscribe_font_driver):
12991 Remove unneeded extern declarations.
12992
2aa46d6c
CY
129932011-03-14 Chong Yidong <cyd@stupidchicken.com>
12994
c96bbc66 12995 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12996
cffc6f3b
CY
129972011-03-13 Chong Yidong <cyd@stupidchicken.com>
12998
12999 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13000 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13001 These macros can no longer be used for assignment.
13002
44f230aa
SM
13003 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13004 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13005 (record_buffer_markers, fetch_buffer_markers): New functions for
13006 recording and fetching special buffer markers.
13007 (set_buffer_internal_1, set_buffer_temp): Use them.
13008
13009 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13010
13011 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13012
13013 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13014 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13015
13016 * xdisp.c (hscroll_window_tree):
13017 (reconsider_clip_changes): Use PT instead of BUF_PT.
13018
d251f04b
EZ
130192011-03-13 Eli Zaretskii <eliz@gnu.org>
13020
13021 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13022 $(EMACS_ROOT)/lib/intprops.h.
13023
f0c77cd1
PE
130242011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13025
3eca4629
PE
13026 Fix more problems found by GCC 4.5.2's static checks.
13027
7c86ee98
PE
13028 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13029 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13030 (xg_free_frame_widgets): Make it clear that a local variable is
13031 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13032 (gdk_window_get_screen): Make it clear that this macro is needed
13033 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13034 (int_gtk_range_get_value): New function, which avoids a diagnostic
13035 from gcc -Wbad-function-cast.
13036 (xg_set_toolkit_scroll_bar_thumb): Use it.
13037 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13038 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13039 (get_utf8_string, xg_get_file_with_chooser):
13040 Rename locals to avoid shadowing.
13041 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13042
41729b81
PE
13043 * xgselect.c (xg_select): Remove unused var.
13044
f0c77cd1
PE
13045 * image.c (four_corners_best): Mark locals as initialized.
13046 (gif_load): Initialize transparent_p to zero (Bug#8238).
13047 Mark another local as initialized.
ec6cf4c6 13048 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13049
ce0ad53d 13050 * image.c (clear_image_cache): Now static.
d5d5a617 13051 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13052 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13053 (x_edge_detection): Remove unnecessary cast that
13054 gcc -Wbad-function-cast diagnoses.
2037898d 13055 (gif_load): Fix pointer signedness.
6ae141d6
PE
13056 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13057 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13058
33383987 130592011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13060
d32df629
PE
13061 Improve quality of tests for time stamp overflow.
13062 For example, without this patch (encode-time 0 0 0 1 1
13063 1152921504606846976) returns the obviously-bogus value (-948597
13064 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13065 reports time overflow. See
13066 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13067 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13068 * editfns.c: Include limits.h and intprops.h.
13069 (TIME_T_MIN, TIME_T_MAX): New macros.
13070 (time_overflow): Move earlier, to before first use.
13071 (hi_time, lo_time): New functions, for an accurate test for
13072 out-of-range times.
13073 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13074 (Fget_internal_run_time): Don't assume time_t fits in int.
13075 (make_time): Use list2 instead of Fcons twice.
13076 (Fdecode_time): More accurate test for out-of-range times.
13077 (check_tm_member): New function.
13078 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13079 (lisp_time_argument): Don't rely on undefined left-shift and
13080 right-shift behavior when checking for time stamp overflow.
8be6f318 13081
fe31d94c
PE
13082 * editfns.c (time_overflow): New function, refactoring common code.
13083 (Fformat_time_string, Fdecode_time, Fencode_time):
13084 (Fcurrent_time_string): Use it.
13085
8be6f318
PE
13086 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13087 * dired.c (make_time): Move to ...
13088 * editfns.c (make_time): ... here.
13089 * systime.h: Note the move.
13090
09d9db2c 130912011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13092
126bc0dc
YM
13093 * fringe.c (update_window_fringes): Remove unused variables.
13094
c47cbdfd
YM
13095 * unexmacosx.c (copy_data_segment): Also copy __got section.
13096 (Bug#8223)
13097
7ac80be9
EZ
130982011-03-12 Eli Zaretskii <eliz@gnu.org>
13099
c96bbc66 13100 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13101 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13102 Constify `char *' arguments and their references according to
13103 prototypes in tparam.h.
13104
ecb0f94d 13105 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13106
7ac80be9
EZ
13107 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13108 Adapt all references accordingly.
13109
13110 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13111
ef1fd07e
TT
131122011-03-11 Tom Tromey <tromey@redhat.com>
13113
13114 * buffer.c (syms_of_buffer): Remove obsolete comment.
13115
7ef4b50c
EZ
131162011-03-11 Eli Zaretskii <eliz@gnu.org>
13117
13118 * termhooks.h (encode_terminal_code): Declare prototype.
13119
13120 * msdos.c (encode_terminal_code): Don't declare prototype.
13121
13122 * term.c (encode_terminal_code): Now external again, used by
13123 w32console.c and msdos.c.
13124
44f230aa
SM
13125 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13126 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13127
4b1ec863 131282011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13129
1714f52b 13130 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13131
4b1ec863
PE
13132 * fringe.c (update_window_fringes): Mark locals as initialized
13133 (Bug#8227).
13134 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13135
524c7aa6
PE
13136 * alloc.c (mark_fringe_data): Move decl from here ...
13137 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13138 to check its interface.
13139 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13140
a5c0af81 13141 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13142 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13143 (fontset_font): Mark local as initialized.
a9a06e0b 13144 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13145
b4716021
PE
13146 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13147
811e9bac 13148 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13149 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13150 (x_own_selection, Fx_disown_selection_internal): Rename locals
13151 to avoid shadowing.
13152 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13153
7e3ab302
PE
13154 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13155 so that the caller can use some name other than gcpro1.
13156 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13157 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13158 (Fx_backspace_delete_keys_p):
13159 Use them to avoid shadowing, and rename vars to avoid shadowing.
13160 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13161 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13162 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13163 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13164 Remove unused locals.
7e3ab302
PE
13165 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13166 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13167 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13168 macros.
f78faa98 13169
e2b13473
PE
13170 * xterm.h (x_mouse_leave): New decl.
13171
77f23912
PE
13172 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13173 Remove unused functions.
cdf4ba58
PE
13174 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13175 (x_calc_absolute_position): Now static.
7411c686 13176 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13177 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13178 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13179 unless they are used.
38d0b34a
PE
13180 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13181 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13182 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13183 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13184 (x_error_catcher, x_connection_closed, x_error_handler):
13185 (x_error_quitter, xembed_send_message, x_iconify_frame):
13186 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13187 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13188 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13189
44f230aa
SM
13190 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13191 Rename or move locals to avoid shadowing.
6b463e58 13192 (tty_defined_color, merge_face_heights): Now static.
5967d051 13193 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13194 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13195 does not deduce is never used uninitialized.
73719eba
PE
13196 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13197 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13198
426994c3 13199 * terminal.c (store_terminal_param): Now static.
5489860b 13200
032f1620 13201 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13202 (set_frame_menubar): Remove unused local.
d4323972 13203 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13204 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13205 since they might point to immutable storage.
281585b0
PE
13206 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13207 since it's unused otherwise.
032f1620 13208
367c19e5 13209 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13210 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13211 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13212 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13213 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13214 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13215 does not deduce are never used uninitialized.
70739cbe 13216
07b48fa9
PE
13217 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13218
8868a238 13219 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13220 * window.c (window_loop, size_window):
13221 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13222
7e5cf297 13223 * window.c (display_buffer): Now static.
d6550a9f
PE
13224 (size_window): Mark variables that gcc -Wuninitialized
13225 does not deduce are never used uninitialized.
a586633d
PE
13226 * window.h (check_all_windows): New decl, to forestall
13227 gcc -Wmissing-prototypes diagnostic.
5b555da1 13228 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13229
f6095868
PE
13230 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13231 shadowing.
13232 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13233 Include <limits.h>.
13234 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13235 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13236 (load_charset_map): Mark variables that gcc -Wuninitialized
13237 does not deduce are never used uninitialized.
53df7c11 13238 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13239
f38b440c
PE
13240 * coding.c (coding_set_source, coding_set_destination):
13241 Use "else { /* comment */ }" rather than "else /* comment */;"
13242 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13243 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13244 a block, when the outer 'i' will do.
13245 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13246 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13247 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13248 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13249 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13250 Rename locals to avoid shadowing.
13251 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13252 * coding.c (emacs_mule_char, encode_invocation_designation):
13253 Now static, since they're not used elsewhere.
413bb2db 13254 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13255 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13256 (decode_coding_emacs_mule): Mark variables that gcc
13257 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13258 (detect_coding_iso_2022): Initialize a local variable that might
13259 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13260 this initialization is needed. (Bug#8211)
5f58e762
PE
13261 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13262 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13263 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13264 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13265 Remove unused macros.
f38b440c 13266
232b38b9 13267 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13268 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13269 * character.c (string_count_byte8): Likewise.
232b38b9 13270
fb90da1b
PE
13271 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13272 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13273
fb93dbc2
PE
13274 * chartab.c (copy_sub_char_table): Now static, since it's not used
13275 elsewhere.
5c156ace
PE
13276 (sub_char_table_ref_and_range, char_table_ref_and_range):
13277 Rename locals to avoid shadowing.
bbcd0949 13278 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13279
7d3b3862 13280 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13281 (BIDI_BOB): Remove unused macro.
7d3b3862 13282
6be7d3da
PE
13283 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13284 deduce are never used uninitialized.
c2ed9c8b 13285 * term.c (encode_terminal_code): Likewise.
6be7d3da 13286
75f8807f 13287 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13288
50938595
PE
13289 * tparam.h: New file.
13290 * term.c, tparam.h: Include it.
13291 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13292 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13293 Move these decls to tparam.h, and make them agree with what
13294 is actually in tparam.c. The previous trick of using incompatible
13295 decls in different modules does not conform to the C standard.
13296 All callers of tparam changed to use tparam's actual API.
13297 * tparam.c (tparam1, tparam, tgoto):
13298 Use const pointers where appropriate.
13299
fbceeba2
PE
13300 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13301 * cm.h (struct cm): Likewise.
13302 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13303 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13304 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13305 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13306 (turn_on_face, init_tty): Likewise.
13307 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13308
7f3f1250
PE
13309 * term.c (term_mouse_position): Rename local to avoid shadowing.
13310
e6ca6543
PE
13311 * alloc.c (mark_ttys): Move decl from here ...
13312 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13313
c40f8d15
AS
133142011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13315
13316 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13317
cfe0661d
JB
133182011-03-09 Juanma Barranquero <lekktu@gmail.com>
13319
13320 * search.c (compile_pattern_1): Remove argument regp, unused since
13321 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13322 (compile_pattern): Don't pass it.
13323
0afb4571
J
133242011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13325
13326 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13327 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13328 for ! HAVE_GTK3.
13329 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13330
13331 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13332
13333 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13334 gdk_window_get_screen, gdk_window_get_geometry,
13335 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13336 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13337 (xg_get_pixbuf_from_pixmap): New function.
13338 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13339 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13340 Call xg_get_pixbuf_from_pixmap instead of
13341 gdk_pixbuf_get_from_drawable.
13342 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13343 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13344 (xg_check_special_colors): Use GtkStyleContext and its functions
13345 for HAVE_GTK3.
13346 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13347 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13348 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13349 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13350 Call gtk_widget_get_preferred_size.
0afb4571
J
13351 (xg_frame_resized): gdk_window_get_geometry only takes 5
13352 parameters.
44f230aa
SM
13353 (xg_win_to_widget, xg_event_is_for_menubar):
13354 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13355 (xg_set_widget_bg): New function.
13356 (delete_cb): New function.
895009e1 13357 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13358 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13359 (xg_set_background_color): Call xg_set_widget_bg.
13360 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13361 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13362 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13363 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13364 if ! HAVE_GTK3.
13365 (update_frame_tool_bar): Call gtk_widget_hide.
13366 (xg_initialize): Use GDK_KEY_g.
13367
13368 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13369 if ! HAVE_GTK3
13370 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13371
13372 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13373 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13374 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13375
1c2cc4ef
JB
133762011-03-08 Juanma Barranquero <lekktu@gmail.com>
13377
13378 * w32xfns.c (select_palette): Check success of RealizePalette against
13379 GDI_ERROR, not zero.
13380
33383987 13381See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13382
13383;; Local Variables:
13384;; coding: utf-8
aac0c6e3
MR
13385;; End:
13386
2f097256 13387 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13388
13389 This file is part of GNU Emacs.
13390
13391 GNU Emacs is free software: you can redistribute it and/or modify
13392 it under the terms of the GNU General Public License as published by
13393 the Free Software Foundation, either version 3 of the License, or
13394 (at your option) any later version.
13395
13396 GNU Emacs is distributed in the hope that it will be useful,
13397 but WITHOUT ANY WARRANTY; without even the implied warranty of
13398 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13399 GNU General Public License for more details.
13400
13401 You should have received a copy of the GNU General Public License
13402 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.