Minor smtpmail.el fixes.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
f67cdd7f
EZ
12011-08-24 Eli Zaretskii <eliz@gnu.org>
2
5980d4c6
EZ
3 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4 buffers, return left-to-right.
8610fe8b
EZ
5 (set_cursor_from_row): Consider candidate row a win if its glyph
6 represents a newline and point is on that newline. Fixes cursor
7 positioning on the newline at EOL of R2L text within L2R
8 paragraph, and vice versa.
9 (try_cursor_movement): Check continued rows, in addition to
10 continuation rows. Fixes unwarranted scroll when point enters a
11 continued line of R2L text within an L2R paragraph, or vice versa.
12 (cursor_row_p): Consider the case of point being equal to
13 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
14 from the end of a short line to the beginning of a continued line
15 of R2L text within L2R paragraph.
16 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
17 composed characters.
5980d4c6 18
f67cdd7f
EZ
19 * bidi.c (bidi_check_type): Use xassert.
20 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
21 members.
22
bca633fb
EZ
232011-08-23 Eli Zaretskii <eliz@gnu.org>
24
25 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
26 a character.
27
4a5885a7
CY
282011-08-23 Chong Yidong <cyd@stupidchicken.com>
29
30 * nsfont.m (ns_otf_to_script): Fix typo.
31
0902a04e
KH
322011-08-22 Kenichi Handa <handa@m17n.org>
33
34 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
35 extra slot even if the purpose is char-code-property-table.
36
1a2e6670
EZ
372011-08-23 Eli Zaretskii <eliz@gnu.org>
38
8ddde651
EZ
39 * xdisp.c (redisplay_window): When computing centering_position,
40 account for the height of the header line. (Bug#8874)
41
425cc014
EZ
42 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
43 instead of CHAR_TO_BYTE. Fixes a crash when a completion
44 candidate is selected by the mouse, and that candidate has a
45 composed character under the mouse.
46
1a2e6670
EZ
47 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
48 coordinates reported by pos-visible-in-window-p for a composed
49 character in column zero.
50
8b76d6f8
SM
512011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
52
53 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
54
dac347dd
EZ
552011-08-22 Eli Zaretskii <eliz@gnu.org>
56
57 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
58 consider it a hit if to_charpos is anywhere in the range of the
59 composed buffer positions.
60
e013fb34
CY
612011-08-22 Chong Yidong <cyd@stupidchicken.com>
62
63 * image.c (gif_load): Don't assume that each subimage has the same
64 dimensions as the base image. Handle disposal method that is
65 "undefined" by the gif spec (Bug#9335).
66
bd1ba3e8
CY
672011-08-20 Chong Yidong <cyd@stupidchicken.com>
68
69 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 70 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 71
54a1215b
EZ
722011-08-19 Eli Zaretskii <eliz@gnu.org>
73
823564e5
EZ
74 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
75 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
76 from an Org mode buffer to a Speedbar frame.
77
54a1215b
EZ
78 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
79 a composition, take its buffer position from IT->cmp_it.charpos.
80 Fixes cursor positioning at the beginning of a line that begins
81 with a composed character.
82
9778ebcc
EZ
832011-08-18 Eli Zaretskii <eliz@gnu.org>
84
0be6ee06
EZ
85 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
86 character bidirectional type, use STRONG_L instead. Fixes crashes
87 in a buffer produced by `describe-categories'.
88
9778ebcc
EZ
89 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
90 members before the level stack, so they would be saved and
91 restored when copying iterator state. Fixes incorrect reordering
92 around TABs covered by display properties.
93
156bffbe
AS
942011-08-18 Andreas Schwab <schwab@linux-m68k.org>
95
96 * process.c (Fnetwork_interface_list): Correctly determine buffer
97 size.
98
72ad093b
CY
992011-08-17 Chong Yidong <cyd@stupidchicken.com>
100
101 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
102 (internal_condition_case_2, internal_condition_case_n):
103 Remove unnecessary aborts (Bug#9081).
72ad093b 104
35774242
EZ
1052011-08-17 Eli Zaretskii <eliz@gnu.org>
106
107 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
108 has no `load' handler, try opening the file locally. (Bug#9311)
109
db76dd85
KB
1102011-08-16 Ken Brown <kbrown@cornell.edu>
111
112 * gmalloc.c: Expand comment.
113
b215eee5
EZ
1142011-08-16 Eli Zaretskii <eliz@gnu.org>
115
116 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
117 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
118
a4579d33
KB
1192011-08-16 Ken Brown <kbrown@cornell.edu>
120
121 Fix memory allocation problems in Cygwin build (Bug#9273).
122
123 * unexcw.c ( __malloc_initialized): Declare external variable.
124 (fixup_executable): Force the dumped emacs to reinitialize malloc.
125
8b76d6f8
SM
126 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
127 New variables.
a4579d33
KB
128 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
129 dumped emacs.
130 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
131 in the static heap.
132 [CYGWIN] (special_realloc): New function.
133 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
134 requests to realloc storage in the static heap.
135
3ebec551
PE
1362011-08-15 Paul Eggert <eggert@cs.ucla.edu>
137
138 * bidi.c (bidi_initialize): Remove unused local.
139
9fd8be00
EZ
1402011-08-15 Eli Zaretskii <eliz@gnu.org>
141
474a8465
EZ
142 * biditype.h: File removed.
143
144 * bidimirror.h: File removed.
145
146 * deps.mk (bidi.o): Remove biditype.h and
147 bidimirror.h.
148
149 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
150 bidimirror.h.
151
152 * dispextern.h: Fix a typo in the comment to bidi_type_t.
153
154 * chartab.c: Improve commentary for the uniprop_table API.
155
32413314
EZ
156 * bidi.c (bidi_paragraph_init): Support zero value of
157 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
158 (bidi_initialize): Use uniprop_table instead of including
159 biditype.h and bidimirror.h.
32413314 160
9fd8be00
EZ
161 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
162 coordinates of the iterator when restoring from ppos_it.
163 (Bug#9296)
164
5cf2b69b
KH
1652011-08-14 Kenichi Handa <handa@m17n.org>
166
167 * process.c (create_process): Call setup_process_coding_systems
72ad093b 168 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 169
daf17d00
EZ
1702011-08-14 Eli Zaretskii <eliz@gnu.org>
171
172 * xdisp.c (move_it_in_display_line_to): Don't invoke
173 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
174 ppos_it. Fixes vertical cursor motion when line beginning is
175 covered by an image. (Bug#9296)
176
08e3161a
JD
1772011-08-14 Jan Djärv <jan.h.d@swipnet.se>
178
179 * nsterm.h (ns_run_ascript): Declare.
180 (NSAPP_DATA2_RUNASSCRIPT): Define.
181
182 * nsfns.m (as_script, as_result, as_status): New static variables.
183 (ns_run_ascript): New function.
184 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
185 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
186 the event loop. Get status from as_status (Bug#7276).
187
188 * nsterm.m (sendEvent): If event is NSApplicationDefined and
189 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
190 the event loop (Bug#7276).
191
a3720aa2
AS
1922011-08-14 Andreas Schwab <schwab@linux-m68k.org>
193
194 * gnutls.c (QCgnutls_bootprop_priority)
195 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
196 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
197 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
198 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
199 (QCgnutls_bootprop_verify_hostname_error)
200 (QCgnutls_bootprop_callbacks_verify): Rename from
201 Qgnutls_bootprop_..., all uses changed.
202
203 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
204 uses changed.
205
0a0d27fb
PE
2062011-08-14 Paul Eggert <eggert@cs.ucla.edu>
207
19d5c50c
PE
208 * xfaces.c (Qframe_set_background_mode): Now static.
209 * dispextern.h (Qframe_set_background_mode): Remove decl.
210
0a0d27fb
PE
211 * process.c (Fnetwork_interface_info): Declare local only if needed.
212
377538cb
JD
2132011-08-13 Jan Djärv <jan.h.d@swipnet.se>
214
215 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
216 (Fnetwork_interface_list): Allocate in increments of bytes instead
217 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
218 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
219 sockaddr.
220 (struct ifflag_def): notrailers is smart on OSX.
221 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
222 Get hardware address with getifaddrs if available.
223
08fff70c
EZ
2242011-08-12 Eli Zaretskii <eliz@gnu.org>
225
226 * xdisp.c (iterate_out_of_display_property): xassert that
227 IT->position is set to within IT->object's boundaries. Break from
228 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
229 when IT->position is set up wrongly due to some bug.
230 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
231 (push_display_prop): Allow GET_FROM_STRING as IT->method on
232 entry. Force push_it to save on the stack the current
233 buffer/string position, to be restored by pop_it. Fix flags in
234 the iterator structure wrt the object coming from a display
235 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
236 properties. (Bug#9284)
237
7be1c708 2382011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 239
7be1c708
CY
240 * fontset.c (fontset_get_font_group): Add proper type checks.
241 (Bug#9172)
aac0c6e3 242
7be1c708 2432011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 244
7be1c708
CY
245 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
246 and LC_VERSION_MIN_MACOSX.
247 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
248 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 249
97bb72a6
EZ
2502011-08-08 Eli Zaretskii <eliz@gnu.org>
251
252 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
253 no-display-properties-and-no-overlays under bidi display.
254 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 255 properties and overlays.
97bb72a6 256
d5617611
CY
2572011-08-08 Chong Yidong <cyd@stupidchicken.com>
258
37e11a63
CY
259 * editfns.c (Fset_time_zone_rule): Document relationship with the
260 setenv function.
261
d5617611
CY
262 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
263 the font entity extracted from the cache (Bug#8109).
264
58872834
CY
2652011-08-07 Chong Yidong <cyd@stupidchicken.com>
266
267 * composite.c (autocmp_chars): Don't reset point. That is done by
268 restore_point_unwind (Bug#5984).
269
75bfc667
JL
2702011-08-07 Juri Linkov <juri@jurta.org>
271
272 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
273 to show the arg `TIME' instead of `TIMEVAL'.
274
d1410150
EZ
2752011-08-06 Eli Zaretskii <eliz@gnu.org>
276
277 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
278 display property strides EOL and includes a newline, as in
279 longlines-mode. (Bug#9254)
75b771e4
EZ
280 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
281 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
282
283 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
284 is non-zero, even if the data buffer is NULL. Fixes a crash in
285 vertical-motion with longlines-mode. (Bug#9254)
286
35928349
EZ
2872011-08-05 Eli Zaretskii <eliz@gnu.org>
288
ec7cc85b
EZ
289 * bidi.c <bidi_cache_total_alloc>: Now static.
290 (bidi_initialize): Initialize bidi_cache_total_alloc.
291
8b76d6f8 292 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
293 cache. (Bug#9221)
294
295 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
296 amount allocated this far in `bidi_cache_total_alloc'.
297 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
298 non-zero, only free the data buffer without restoring the cache
299 contents. All callers changed.
300
301 * dispextern.h (bidi_unshelve_cache): Update prototype.
302
303 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
304 (move_it_in_display_line, move_it_to)
305 (move_it_vertically_backward, move_it_by_lines): Replace the call
306 to xfree to an equivalent call to bidi_unshelve_cache.
307 (move_it_in_display_line_to): Fix logic of returning
412b6358 308 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 309
e2e2423b
EZ
3102011-08-05 Eli Zaretskii <eliz@gnu.org>
311
312 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
313 came from a string character with a `cursor' property. (Bug#9229)
314
ae9e757a
JD
3152011-08-04 Jan Djärv <jan.h.d@swipnet.se>
316
317 * Makefile.in (LIB_PTHREAD): New variable.
318 (LIBES): Add LIB_PTHREAD (Bug#9216).
319
320 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
321 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
322
213bd7f2
AS
3232011-08-04 Andreas Schwab <schwab@linux-m68k.org>
324
325 * regex.c (re_iswctype): Remove some redundant boolean
326 conversions.
327
99aaf75f
JD
3282011-08-04 Jan Djärv <jan.h.d@swipnet.se>
329
330 * xterm.c (x_find_topmost_parent): New function.
331 (x_set_frame_alpha): Find topmost parent window with
332 x_find_topmost_parent and set the property there also (bug#9181).
333 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
334
c74e9d86
PE
3352011-08-04 Paul Eggert <eggert@cs.ucla.edu>
336
337 * callproc.c (Fcall_process): Avoid vfork clobbering
338 the local vars buffer, coding_systems, current_dir.
339
640c8776
SM
3402011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
341
342 * keymap.c (Fmake_composed_keymap): Move to subr.el.
343
f26d0e4c
PE
3442011-08-03 Paul Eggert <eggert@cs.ucla.edu>
345
8a10d76c
PE
346 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
347 so that it is not optimized away.
348
f26d0e4c
PE
349 * xdisp.c (compute_display_string_pos): Remove unused local.
350
55439c61
EZ
3512011-08-02 Eli Zaretskii <eliz@gnu.org>
352
353 Fix slow cursor motion and scrolling in large buffers with
354 selective display, like Org Mode buffers. (Bug#9218)
355
356 * dispextern.h (struct bidi_it): New member disp_prop_p.
357
358 * xdisp.c: Remove one-slot cache of display string positions.
359 (compute_display_string_pos): Accept an additional argument
360 DISP_PROP_P; callers changed. Scan at most 5K characters forward
361 for a display string or property. If found, set DISP_PROP_P
362 non-zero.
363
364 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
365 DISP_PROP_P, and pass it to compute_display_string_pos.
366 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
367 non-zero. All callers of bidi_fetch_char changed.
368
fb33fa43
SM
3692011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
370
371 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
372
b099e063
DM
3732010-12-03 Don March <don@ohspite.net>
374
375 * keymap.c (Fdefine_key): Fix non-prefix key error message when
376 last character M-[char] is translated to ESC [char] (bug#7541).
377
5cc7f7af
KH
3782011-08-02 Kenichi Handa <handa@m17n.org>
379
d0fffa3f 380 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
381
382 * chartab.c (uniprop_table): Make it non-static.
383
525d5e6e
EZ
3842011-08-01 Eli Zaretskii <eliz@gnu.org>
385
386 * xdisp.c (forward_to_next_line_start): Accept additional argument
387 BIDI_IT_PREV, and store into it the state of the bidi iterator had
388 on the newline.
389 (reseat_at_next_visible_line_start): Use the bidi iterator state
390 returned by forward_to_next_line_start to restore the state of
391 it->bidi_it after backing up to previous newline. (Bug#9212)
392
31011111
AS
3932011-07-30 Andreas Schwab <schwab@linux-m68k.org>
394
395 * regex.c (re_comp): Protoize.
396 (re_exec): Fix return type.
397 (regexec): Fix type of `ret'. (Bug#9203)
398
e5d76069
PE
3992011-07-29 Paul Eggert <eggert@cs.ucla.edu>
400
401 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
402 This is needed if max-image-size is a floating-point number.
403
9a79b20c
AS
4042011-07-28 Andreas Schwab <schwab@linux-m68k.org>
405
406 * print.c (print_object): Print empty symbol as ##.
407
408 * lread.c (read1): Read ## as empty symbol.
409
d8c2fa78
AA
4102011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
411
412 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
413 setting frame foreground color (Bug#9175).
414 (x_set_background_color): Likewise.
415
ffe57a7a
AA
416 * nsmenu.m (-setText): Size tooltip dimensions precisely to
417 contents (Bug#9176).
418 (EmacsTooltip -init): Remove bezels and add shadows to
419 tooltip windows.
420
bf3492a5
AA
421 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
422 or scroll bar (Bug#8470).
423
d55e9c53
AA
424 * nsfont.m (nsfont_open): Remove assignment to voffset and
425 unnecessary vars hshink, expand, hd, full_height, min_height.
426 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
427
428 * nsterm.h (nsfont_info): Remove voffset field.
429
d8c2fa78 4302011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
431
432 Implement strike-through and overline on NextStep (Bug#8863).
433
434 * nsfont.m (nsfont_open): Use underline position provided by font,
435 instead of hard-coded value of 2.
436 (nsfont_draw): Call ns_draw_text_decoration instead.
437
438 * nsterm.h: Add declaration for ns_draw_text_decoration.
439
440 * nsterm.m (ns_draw_text_decoration): New function for drawing
441 underline, overline, and strike-through.
442 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
443 ns_draw_text_decoration. Change treatment of cursor drawing to
444 accomodate underlining, etc.
445
4cc60b9b
EZ
4462011-07-28 Eli Zaretskii <eliz@gnu.org>
447
bc7ece87
EZ
448 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
449 default.
4cc60b9b 450
476371c4
PE
4512011-07-28 Paul Eggert <eggert@cs.ucla.edu>
452
66606eea
PE
453 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
454 Without this fix, if a signal arrives just after memory fills up,
455 'malloc' might be invoked reentrantly.
456
476371c4
PE
457 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
458 In other words, assume that every image size is allowed, on non-X
459 hosts. This assumption is probably wrong, but it lets Emacs compile.
460
f3fcc40d
AS
4612011-07-28 Andreas Schwab <schwab@linux-m68k.org>
462
463 * regex.c (re_iswctype): Convert return values to boolean.
464
350c992f
EZ
4652011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
466
467 * xdisp.c (compute_display_string_pos): Don't use cached display
468 string position if the buffer had its restriction changed.
469 (Bug#9184)
470
5266b4bb
PE
4712011-07-28 Paul Eggert <eggert@cs.ucla.edu>
472
473 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
474
2573a837 4752011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 476
41f55ccd 477 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 478
39e378da
PE
479 * bidi.c: Integer size and overflow fixes.
480 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
481 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
482 (bidi_cache_find_level_change, bidi_cache_ensure_space)
483 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
484 (bidi_find_other_level_edge):
485 Use ptrdiff_t instead of EMACS_INT where either will do.
486 This works better on 32-bit hosts configured --with-wide-int.
487 (bidi_cache_ensure_space): Check for size-calculation overflow.
488 Use % rather than repeated addition, for better worst-case speed.
489 Don't set bidi_cache_size until after xrealloc returns, because it
490 might not return.
491 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
492 (bidi_cache_ensure_space): Also check that the bidi cache size
493 does not exceed that of the largest Lisp string or buffer. See Eli
494 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 495
5e927815
PE
496 * alloc.c (__malloc_size_t): Remove.
497 All uses replaced by size_t. See Andreas Schwab's note
498 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
499
ca4aa935
PE
500 * image.c: Improve checking for integer overflow.
501 (check_image_size): Assume that f is nonnull, since
502 it is always nonnull in practice. This is one less thing to
503 worry about when checking for integer overflow later.
504 (x_check_image_size): New function, which checks for integer
505 overflow issues inside X.
506 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
507 This removes the need for a memory_full check.
508 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
509 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
510 (xbm_read_bitmap_data): Change locals back to 'int', since
511 their values must fit in 'int'.
512 (xpm_load_image, png_load, tiff_load):
513 Invoke x_create_x_image_and_pixmap earlier,
514 to avoid much needless work if the image is too large.
515 (tiff_load): Treat overly large images as if
516 x_create_x_image_and_pixmap failed, not as malloc failures.
517 (gs_load): Use x_check_image_size.
518
5f8f9cc2
PE
519 * gtkutil.c: Omit integer casts.
520 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
521 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
522
5adf60bc
PE
523 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
524
c8907a93
PE
525 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
526 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
527 would wrongly return t on a 64-bit host.
528
e3c25c68
PE
529 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
530 The plain *_OVERFLOW macros run afoul of GCC bug 49705
531 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
532 and therefore cause GCC to emit a bogus diagnostic in some cases.
533
3f791afe
PE
534 * image.c: Integer signedness and overflow and related fixes.
535 This is not an exhaustive set of fixes, but it's time to
536 record what I've got.
537 (lookup_pixel_color, check_image_size): Remove redundant decls.
538 (check_image_size): Don't assume that arbitrary EMACS_INT values
539 fit in 'int', or that arbitrary 'double' values fit in 'int'.
540 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
541 (tiff_load, imagemagick_load_image):
542 Check for overflow in size calculations.
543 (x_create_x_image_and_pixmap): Remove unnecessary test for
544 xmalloc returning NULL; that can't happen.
545 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
546 (xpm_color_bucket): Use better integer hashing function.
547 (xpm_cache_color): Don't possibly over-allocate memory.
548 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
549 (gif_memory_source):
550 Use ptrdiff_t, not int or size_t, to record sizes.
551 (png_load): Don't assume values greater than 2**31 fit in 'int'.
552 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
553 either works, as we prefer signed integers.
554 (tiff_read_from_memory, tiff_write_from_memory):
555 Return tsize_t, not size_t, since that's what the TIFF API wants.
556 (tiff_read_from_memory): Don't fail simply because the read would
557 go past EOF; instead, return a short read.
558 (tiff_load): Omit no-longer-needed casts.
559 (Fimagemagick_types): Don't assume size fits into 'int'.
560
3cc5a532
PE
561 Improve hashing quality when configured --with-wide-int.
562 * fns.c (hash_string): New function, taken from sxhash_string.
563 Do not discard information about ASCII character case; this
564 discarding is no longer needed.
565 (sxhash-string): Use it. Change sig to match it. Caller changed.
566 * lisp.h: Declare it.
567 * lread.c (hash_string): Remove, since we now use fns.c's version.
568 The fns.c version returns a wider integer if --with-wide-int is
569 specified, so this should help the quality of the hashing a bit.
570
b312a492
PE
571 * emacs.c: Integer overflow minor fix.
572 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
573 Define only if GNU_LINUX.
574 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
575
dfd153ae
PE
576 * dispnew.c: Integer signedness and overflow fixes.
577 Remove unnecessary forward decls, that were a maintenance hassle.
578 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
579 All uses changed.
580 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
581 (scrolling_window): Use ptrdiff_t, not int, for byte count.
582 (prepare_desired_row, line_draw_cost):
583 Use int, not unsigned, where either works.
584 (save_current_matrix, restore_current_matrix):
585 Use ptrdiff_t, not size_t, where either works.
586 (init_display): Check for overflow more accurately, and without
587 relying on undefined behavior.
588
a81d11a3
PE
589 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
590 Remove, replacing with the new symbols in lisp.h. All uses changed.
591 * fileio.c (make_temp_name):
592 * filelock.c (lock_file_1, lock_file):
593 * xdisp.c (message_dolog):
594 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
595 Use pMd etc. instead.
596 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
597 replacing the pWIDE etc. symbols removed from editfns.c.
598
3300e6fd
PE
599 * keyboard.h (num_input_events): Now uintmax_t.
600 This is (very slightly) less likely to mess up due to wraparound.
601 All uses changed.
602
fd05c7e9
PE
603 * buffer.c: Integer signedness fixes.
604 (alloc_buffer_text, enlarge_buffer_text):
605 Use ptrdiff_t rather than size_t when either will do, as we prefer
606 signed integers.
607
903fe15d
PE
608 * alloc.c: Integer signedness and overflow fixes.
609 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
610 (__malloc_size_t): Default to size_t, not to int.
611 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
612 (Fgarbage_collect, mark_object_loop_halt, mark_object):
613 Prefer ptrdiff_t to size_t when either would do, as we prefer
614 signed integers.
615 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
616 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
617 Now const. Initialize with values that are in range even if char
618 is signed.
619 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
620 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
621 These functions do the right thing with sizes > 2**32.
622 (check_depth): Now ptrdiff_t, not int.
623 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
624 Adjust to new way of storing sizes. Check for size overflow bugs
625 in rest of code.
626 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
627 slightly wrong anyway, as it missed one instance of
628 XMALLOC_OVERRUN_CHECK_OVERHEAD.
629 (refill_memory_reserve): Omit needless cast to size_t.
630 (mark_object_loop_halt): Mark as externally visible.
631
ac82cc6a
PE
632 * xselect.c: Integer signedness and overflow fixes.
633 (Fx_register_dnd_atom, x_handle_dnd_message):
634 Use ptrdiff_t, not size_t, since we prefer signed.
635 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
636 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
637 x_dnd_atoms_size and x_dnd_atoms_length.
638
c2d1e36d
PE
639 * doprnt.c: Prefer signed to unsigned when either works.
640 * eval.c (verror):
641 * doprnt.c (doprnt):
642 * lisp.h (doprnt):
643 * xdisp.c (vmessage):
644 Use ptrdiff_t, not size_t, when using or implementing doprnt,
645 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
646 prefer signed arithmetic to avoid comparison confusion.
647 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
648 but is a bit tricky.
649
0e926e56
PE
650 Assume freestanding C89 headers, string.h, stdlib.h.
651 * data.c, doprnt.c, floatfns.c, print.c:
652 Include float.h unconditionally.
653 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
654 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
655 * regex.c: Likewise for stddef.h, string.h.
656 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
657 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
658 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
659 (STDC_HEADERS): Remove obsolete defines.
660 * sysdep.c: Include limits.h unconditionally.
661
9cfdb3ec
PE
662 Assume support for memcmp, memcpy, memmove, memset.
663 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
664 * regex.c (memcmp, memcpy):
665 Remove; we assume C89 now.
666
667 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
668 (__malloc_safe_bcopy): Remove; no longer needed.
669
cf950e6b 670 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
671 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
672 well either way, and we prefer signed to unsigned.
673
dbf38e02
LMI
6742011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
675
676 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
677 closes the connection while we're reading (bug#9182).
678
d6f0886c
JD
6792011-07-25 Jan Djärv <jan.h.d@swipnet.se>
680
681 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
682 are specified (Bug#9168).
683
2eb1f9e6
PE
6842011-07-25 Paul Eggert <eggert@cs.ucla.edu>
685
686 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
687 Found by GCC static checking and --with-wide-int on a 32-bit host.
688
22381272 6892011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
690
691 * xdisp.c (compute_display_string_pos): Fix logic of caching
692 previous display string position. Initialize cached_prev_pos to
693 -1. Fixes slow-down at the beginning of a buffer.
694
f25e39b4
EZ
6952011-07-24 Eli Zaretskii <eliz@gnu.org>
696
697 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
698 for attrs[LFACE_FONTSET_INDEX].
699
04c4b52e
PE
7002011-07-23 Paul Eggert <eggert@cs.ucla.edu>
701
702 * xml.c (parse_region): Remove unused local
703 that was recently introduced.
704
c1734fbd
EZ
7052011-07-23 Eli Zaretskii <eliz@gnu.org>
706
be18c5a5
EZ
707 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
708 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
709
c1734fbd
EZ
710 * xdisp.c (move_it_in_display_line_to): Record the best matching
711 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
712 exit if none of the characters scanned was an exact match.
713 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
714 when exact match is impossible due to invisible text, and the
715 lines are truncated.
716
a258d627
JD
7172011-07-23 Jan Djärv <jan.h.d@swipnet.se>
718
719 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
720 for OSX >= 10.7.
721
b6d5a689
EZ
7222011-07-22 Eli Zaretskii <eliz@gnu.org>
723
0f74f785
EZ
724 Fix a significant slow-down of cursor motion with C-n, C-p,
725 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
726 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 727 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
728 (next_element_from_buffer): Call compute_stop_pos_backwards to
729 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
730 base_level_stop.
731 (reseat): Don't look for prev_stop, as that could mean a very long
732 run.
733 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
734 <cached_disp_overlay_modiff>: Cache for last found display string
735 position.
551918c1 736 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
737 about the same buffer in the same area of character positions, and
738 the buffer wasn't changed since the time the display string
739 position was cached.
551918c1 740
b2d0c91a
EZ
7412011-07-22 Eli Zaretskii <eliz@gnu.org>
742
743 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
744 is an integer, which is important for empty lines. (Bug#9149)
745
043604ee
CY
7462011-07-22 Chong Yidong <cyd@stupidchicken.com>
747
748 * frame.c (Fmodify_frame_parameters): In tty case, update the
749 default face if necessary (Bug#4238).
750
da4adb04
CY
7512011-07-21 Chong Yidong <cyd@stupidchicken.com>
752
753 * editfns.c (Fstring_to_char): No need to explain what a character
754 is in the docstring (Bug#6576).
755
9abd0532
LMI
7562011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
757
758 * xml.c (parse_region): Make sure we always return a tree.
759
36881d16
HK
7602011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
761
762 * xml.c (parse_region): If a document contains only comments,
763 return that, too.
764
1e98674d
LMI
7652011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
766
767 * xml.c (make_dom): Return comments, too.
768
590bd467
PE
7692011-07-19 Paul Eggert <eggert@cs.ucla.edu>
770
771 Port to OpenBSD.
772 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
773 and the surrounding thread.
774 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
775 rather than fgets, and retry after EINTR. Otherwise, 'emacs
776 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
777 timer goes off.
778 * s/openbsd.h (BROKEN_SIGIO): Define.
779 * unexelf.c (unexec) [__OpenBSD__]:
780 Don't update the .mdebug section of the Alpha COFF symbol table.
781
f41628b2
LMI
7822011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
783
784 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
785 (bug#8460).
786
b59b67c5
PE
7872011-07-18 Paul Eggert <eggert@cs.ucla.edu>
788
15e3a074
PE
789 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
790 This fixes some race conditions on the permissions of any newly
791 created file.
792
41bed37d
PE
793 * alloc.c (valid_pointer_p): Use pipe, not open.
794 This fixes some permissions issues when debugging.
795
b59b67c5
PE
796 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
797 If fchown fails to set both uid and gid, try to set just gid,
798 as that is sometimes allowed. Adjust the file's mode to eliminate
799 setuid or setgid bits that are inappropriate if fchown fails.
800
925a6be7
SM
8012011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
802
803 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
804 to compare Lisp_Objects.
805 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
806 global_gnutls_log_level, don't mistake it for a Lisp_Object.
807 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
808
52968808
AS
8092011-07-17 Andreas Schwab <schwab@linux-m68k.org>
810
0a6a104b
AS
811 * lread.c (read_integer): Unread even EOF character.
812 (read1): Likewise. Properly record start position of symbol.
813
52968808
AS
814 * lread.c (read1): Read `#:' as empty uninterned symbol if no
815 symbol character follows.
816
9e381cdd
PE
8172011-07-17 Paul Eggert <eggert@cs.ucla.edu>
818
819 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
820 This works around a problem with the previous change to Fcopy_file.
821 Recent glibc declares fchown with __attribute__((warn_unused_result)),
822 and without this change, GCC might complain about discarding
823 fchown's return value.
824
b5641435
JB
8252011-07-16 Juanma Barranquero <lekktu@gmail.com>
826
827 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
828
a8031457
PE
8292011-07-16 Paul Eggert <eggert@cs.ucla.edu>
830
831 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
832
dd889327
LMI
8332011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
834
750c33f7
LMI
835 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
836 it's used from the C level.
837
dd889327
LMI
838 * process.c: Use the same condition for POLL_FOR_INPUT in both
839 keyboard.c and process.c (bug#1858).
840
87e86684
LM
8412011-07-09 Lawrence Mitchell <wence@gmx.li>
842
843 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
844 (Fgnutls_boot): Use it.
845
64348f40
AS
8462011-07-15 Andreas Schwab <schwab@linux-m68k.org>
847
848 * doc.c (Fsubstitute_command_keys): Revert last change.
849
1d698799
LMI
8502011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
851
f863868c
LMI
852 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
853 quotes the next character, and doesn't affect other longer
854 sequences (bug#8935).
855
1d698799
LMI
856 * lread.c (syms_of_lread): Clarify that is isn't only
857 `eval-buffer' and `eval-defun' that's affected by
858 `lexical-binding' (bug#8460).
859
aa4b6df6
EZ
8602011-07-15 Eli Zaretskii <eliz@gnu.org>
861
862 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
863 bidi redisplay when a line includes both an image and is
864 truncated.
865
5d856da6
PE
8662011-07-14 Paul Eggert <eggert@cs.ucla.edu>
867
ad6042bb
PE
868 Fix minor problems found by static checking.
869 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
870 (elsz): Now a signed constant, not a size_t var. We prefer signed
871 types to unsigned, to avoid integer comparison confusion. Without
872 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
873 "cannot optimize loop, the loop counter may overflow", a symptom
874 of the confusion.
f00bbb22 875 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
876 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
877
6468f31c
LMI
8782011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
879
49080b10
LMI
880 * search.c (Fre_search_backward): Mention `case-fold-search' in
881 all the re_search_* functions (bug#8138).
882
6468f31c
LMI
883 * keyboard.c (Fopen_dribble_file): Document when the file is
884 closed (bug#8056).
885
c965adc5
EZ
8862011-07-14 Eli Zaretskii <eliz@gnu.org>
887
df9733bf
EZ
888 * bidi.c (bidi_dump_cached_states): Fix format of displaying
889 bidi_cache_idx.
890
0bb23927
EZ
891 Support bidi reordering of display and overlay strings.
892 * xdisp.c (compute_display_string_pos)
893 (compute_display_string_end): Accept additional argument STRING.
894 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
895 (reseat_to_string): Initialize bidi_it->string.s and
896 bidi_it->string.schars.
897 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
898 NULL (avoids a crash in bidi_paragraph_init).
899 Initialize itb.string.lstring.
0bb23927
EZ
900 (init_iterator): Call bidi_init_it only of a valid
901 buffer position was specified. Initialize paragraph_embedding to
902 L2R.
903 (reseat_to_string): Initialize the bidi iterator.
904 (display_string): If we need to ignore text properties of
905 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
906 original value of -1 will not work with bidi.)
907 (compute_display_string_pos): First arg is now struct
908 `text_pos *'; all callers changed. Support display properties on
909 Lisp strings.
910 (compute_display_string_end): Support display properties on Lisp
911 strings.
912 (init_iterator, reseat_1, reseat_to_string): Initialize the
913 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
914 when iterating on a string not from display properties).
640c8776
SM
915 (compute_display_string_pos, compute_display_string_end):
916 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
917 arrow keys.
918 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
919 base_level_stop; instead, set base_level_stop to BEGV.
920 Fixes crashes in vertical-motion.
0bb23927
EZ
921 (next_element_from_buffer): Improve commentary for when
922 the iterator is before prev_stop.
923 (init_iterator): Initialize bidi_p from the default value of
924 bidi-display-reordering, not from buffer-local value. Use the
925 buffer-local value only if initializing for buffer iteration.
926 (handle_invisible_prop): Support invisible properties on strings
927 that are being bidi-reordered.
928 (set_iterator_to_next): Support bidi reordering of C strings and
929 Lisp strings.
930 (next_element_from_string): Support bidi reordering of Lisp
931 strings.
932 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
933 (display_string): Support display of R2L glyph rows.
934 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
935 (init_iterator): Don't initialize it->bidi_p for strings
936 here.
937 (reseat_to_string): Initialize it->bidi_p for strings here.
938 (next_element_from_string, next_element_from_c_string)
939 (next_element_from_buffer): Add xassert's for correspondence
940 between IT's object being iterated and it->bidi_it.string
941 structure.
942 (face_before_or_after_it_pos): Support bidi iteration.
943 (next_element_from_c_string): Handle the case of the first string
944 character that is not the first one in the visual order.
945 (get_visually_first_element): New function, refactored from common
946 parts of next_element_from_buffer, next_element_from_string, and
947 next_element_from_c_string.
948 (tool_bar_lines_needed, redisplay_tool_bar)
949 (display_menu_bar): Force left-to-right direction. Add a FIXME
950 comment for making that be controlled by a user option.
951 (push_it, pop_it): Save and restore the state of the
952 bidi iterator. Save and restore the bidi_p flag.
953 (pop_it): Iterate out of display property for string iteration as
954 well.
955 (iterate_out_of_display_property): Support iteration over strings.
956 (handle_single_display_spec): Set up it->bidi_it for iteration
957 over a display string, and call bidi_init_it.
958 (handle_single_display_spec, next_overlay_string)
959 (get_overlay_strings_1, push_display_prop): Set up the bidi
960 iterator for displaying display or overlay strings.
961 (forward_to_next_line_start): Don't use the shortcut if
962 bidi-iterating.
963 (back_to_previous_visible_line_start): If handle_display_prop
964 pushed the iterator stack, restore the internal state of the bidi
965 iterator by calling bidi_pop_it same number of times.
966 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
967 and we are bidi-iterating, don't decrement the iterator position;
968 instead, set the first_elt flag in the bidi iterator, to produce
969 the same effect.
970 (reseat_1): Remove redundant setting of string_from_display_prop_p.
971 (push_display_prop): xassert that we are iterating a buffer.
972 (push_it, pop_it): Save and restore paragraph_embedding member.
973 (handle_single_display_spec, next_overlay_string)
974 (get_overlay_strings_1, reseat_1, reseat_to_string)
975 (push_display_prop): Set up the `unibyte' member of bidi_it.string
976 correctly. Don't assume unibyte strings are not bidi-reordered.
977 (compute_display_string_pos)
978 (compute_display_string_end): Fix handling the case of C string.
979 (push_it, pop_it): Save and restore from_disp_prop_p.
980 (handle_single_display_spec, push_display_prop): Set the
981 from_disp_prop_p flag.
982 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
983 (pop_it): Call iterate_out_of_display_property only if we are
984 popping after iteration over a string that came from a display
985 property. Fix a typo in popping stretch info. Add an assertion
986 for verifying that the iterator position is in sync with the bidi
987 iterator.
988 (handle_single_display_spec, get_overlay_strings_1)
989 (push_display_prop): Fix initialization of paragraph direction for
990 string when that of the parent object is not yet determined.
991 (reseat_1): Call bidi_init_it to resync the bidi
992 iterator with IT's position. (Bug#7616)
993 (find_row_edges): If ROW->start.pos gives position
994 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
995 (handle_stop, back_to_previous_visible_line_start, reseat_1):
996 Reset the from_disp_prop_p flag.
997 (SAVE_IT, RESTORE_IT): New macros.
998 (pos_visible_p, face_before_or_after_it_pos)
999 (back_to_previous_visible_line_start)
1000 (move_it_in_display_line_to, move_it_in_display_line)
1001 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1002 (try_scrolling, redisplay_window, display_line): Use them when
1003 saving a temporary copy of the iterator and restoring it back.
1004 (back_to_previous_visible_line_start, reseat_1)
1005 (init_iterator): Empty the bidi cache "stack".
1006 (move_it_in_display_line_to): If iterator ended up at
1007 EOL, but we never saw any buffer positions smaller than
1008 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1009 motion in bidi-reordered lines.
1010 (move_it_in_display_line_to): Record prev_method and prev_pos
1011 immediately before the call to set_iterator_to_next. Fixes cursor
1012 motion in bidi-reordered lines with stretch glyphs and strings
1013 displayed in margins. (Bug#8133) (Bug#8867)
1014 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1015 TO_CHARPOS.
640c8776
SM
1016 (pos_visible_p): Support positions in bidi-reordered lines.
1017 Save and restore bidi cache.
0bb23927
EZ
1018
1019 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1020 (bidi_paragraph_info): Delete unused struct.
1021 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1022 (bidi_cache_start): New variable.
1023 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1024 to zero.
1025 (bidi_cache_fetch_state, bidi_cache_search)
1026 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1027 (bidi_cache_find, bidi_peek_at_next_level)
1028 (bidi_level_of_next_char, bidi_find_other_level_edge)
1029 (bidi_move_to_visually_next): Compare cache index with
1030 bidi_cache_start rather than with zero.
1031 (bidi_fetch_char): Accept new argument STRING; all callers
1032 changed. Support iteration over a string. Support strings with
1033 display properties. Support unibyte strings. Fix the type of
1034 `len' according to what STRING_CHAR_AND_LENGTH expects.
1035 (bidi_paragraph_init, bidi_resolve_explicit_1)
1036 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1037 (bidi_level_of_next_char, bidi_move_to_visually_next):
1038 Support iteration over a string.
0bb23927
EZ
1039 (bidi_set_sor_type, bidi_resolve_explicit_1)
1040 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1041 can now be zero (for strings); special values 0 and -1 were
1042 changed to -1 and -2, respectively.
1043 (bidi_char_at_pos): New function.
1044 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1045 Call it instead of FETCH_MULTIBYTE_CHAR.
1046 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1047 initialized to valid values.
1048 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1049 values.
1050 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1051 the test for valid cached positions. Fix the logic for looking up
1052 the sentinel state in the cache. GCPRO the Lisp string we are
1053 iterating.
1054 (bidi_push_it, bidi_pop_it): New functions.
1055 (bidi_initialize): Initialize the bidi cache start stack pointer.
1056 (bidi_cache_ensure_space): New function, refactored from part of
1057 bidi_cache_iterator_state. Don't assume the required size is just
1058 one BIDI_CACHE_CHUNK away.
1059 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1060 (bidi_count_bytes, bidi_char_at_pos): New functions.
1061 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1062 always valid if bidi_cache_idx is valid.
1063 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1064 is valid if it's going to be used.
1065 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1066 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1067 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1068 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1069 (bidi_find_other_level_edge, bidi_cache_start_stack):
1070 All variables related to cache indices are now EMACS_INT.
c965adc5 1071
0bb23927
EZ
1072 * dispextern.h (struct bidi_string_data): New structure.
1073 (struct bidi_it): New member `string'. Make flag members be 1-bit
1074 fields, and put them last in the struct.
640c8776
SM
1075 (compute_display_string_pos, compute_display_string_end):
1076 Update prototypes.
0bb23927
EZ
1077 (bidi_push_it, bidi_pop_it): Add prototypes.
1078 (struct iterator_stack_entry): New members bidi_p,
1079 paragraph_embedding, and from_disp_prop_p.
1080 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1081 (bidi_shelve_cache, bidi_unshelve_cache):
1082 Declare prototypes.
0bb23927
EZ
1083
1084 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1085 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1086 and vector-like objects.
1087
1088 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1089 cache around display iteration.
1090
1091 * window.c (Fwindow_end, window_scroll_pixel_based)
1092 (displayed_window_lines, Frecenter): Save and restore the bidi
1093 cache around display iteration.
1094
3bbd2265
LMI
10952011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1096
1097 * editfns.c (Fdelete_region): Clarify the use of the named
1098 parameters (bug#6788).
1099
adc47434
MR
11002011-07-14 Martin Rudalics <rudalics@gmx.at>
1101
1102 * indent.c (Fvertical_motion): Set and restore w->pointm when
1103 saving and restoring the window's buffer (Bug#9006).
1104
837c31f8
LMI
11052011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1106
1107 * editfns.c (Fstring_to_char): Clarify just what is returned
1108 (bug#6576). Text by Eli Zaretskii.
1109
ac389d0c
JB
11102011-07-13 Juanma Barranquero <lekktu@gmail.com>
1111
1112 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1113
0be0ce47
EZ
11142011-07-13 Eli Zaretskii <eliz@gnu.org>
1115
1116 * buffer.c (mmap_find): Fix a typo.
1117
cd18e7e3
JB
11182011-07-13 Johan Bockgård <bojohan@gnu.org>
1119
1120 Fix execution of x selection hooks.
1121 * xselect.c (Qx_lost_selection_functions)
1122 (Qx_sent_selection_functions): New vars.
1123 (syms_of_xselect): DEFSYM them.
1124 (x_handle_selection_request): Pass Qx_sent_selection_functions
1125 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1126 (x_handle_selection_clear,x_clear_frame_selections):
1127 Pass Qx_lost_selection_functions rather than
1128 Vx_lost_selection_functions to Frun_hook_with_args.
1129
47ea7f44
PE
11302011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1131
ac389d0c 1132 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1133 The old code sometimes used this field without initializing it.
1134
47ea7f44
PE
1135 * alloc.c (gc_sweep): Don't read past end of array.
1136 In theory, the old code could also have corrupted Emacs internals,
1137 though it'd be very unlikely.
1138
bc985c87
AS
11392011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1140
1141 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1142 argument. (Bug#4026)
bc985c87 1143
0cf34688
LMI
11442011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1145
b3dadd76
LMI
1146 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1147 key" (bug#4257).
1148
0cf34688
LMI
1149 * window.c (Fset_window_start): Doc fix (bug#4199).
1150 (Fset_window_hscroll): Ditto.
1151
270768cd
PE
11522011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1153
077e3dda 1154 Fix minor new problems caught by GCC 4.6.1.
270768cd 1155 * term.c (init_tty): Remove unused local.
490011a6 1156 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1157 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1158 not used otherwise.
270768cd 1159
b1f58454
CY
11602011-07-12 Chong Yidong <cyd@stupidchicken.com>
1161
1162 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1163
22b9578d
LMI
11642011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1165
6e70ab07
LMI
1166 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1167 are the mini-buffer and the echo area (bug#3320).
1168
22b9578d
LMI
1169 * term.c (init_tty): Remove support for supdup, c10 and perq
1170 terminals, which are no longer supported (bug#1482).
1171
8974cc9f
JB
11722011-07-10 Johan Bockgård <bojohan@gnu.org>
1173
1174 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1175
a560d974
JD
11762011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1177
1178 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1179 for non-popups (Bug#3642).
1180
1dae0f0a
AS
11812011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1182
268c2c36 1183 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1184 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1185 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1186 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1187 * data.c (fmod): Likewise.
1188 * dispnew.c (swap_glyphs_in_rows): Likewise.
1189 * emacs.c (memory_warning_signal): Likewise.
1190 * floatfns.c (float_error): Likewise.
1191 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1192 (otf_open, font_otf_capability, generate_otf_features)
1193 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1194 Likewise.
1195 * image.c (pbm_read_file): Likewise.
1196 * indent.c (string_display_width): Likewise.
1197 * intervals.c (check_for_interval, search_for_interval)
1198 (inc_interval_count, count_intervals, root_interval)
1199 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1200 * lread.c (defalias): Likewise.
268c2c36 1201 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1202 * regex.c (set_image_of_range_1, set_image_of_range)
1203 (regex_grow_registers): Likewise.
1204 * sysdep.c (strerror): Likewise.
1205 * termcap.c (valid_filename_p, tprint, main): Likewise.
1206 * tparam.c (main): Likewise.
1207 * unexhp9k800.c (run_time_remap, save_data_space)
1208 (update_file_ptrs, read_header, write_header, calculate_checksum)
1209 (copy_file, copy_rest, display_header): Likewise.
1210 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1211 Likewise.
1212 * xdisp.c (check_it): Likewise.
1213 * xfaces.c (register_color, unregister_color, unregister_colors):
1214 Likewise.
1215 * xfns.c (print_fontset_result): Likewise.
1216 * xrdb.c (member, fatal, main): Likewise.
1217
99033785
PE
12182011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1219
1220 Fix minor problems found by static checking (Bug#9031).
1221 * chartab.c (char_table_set_range, map_sub_char_table):
1222 Remove unused locals.
1223 (uniprop_table): Now static.
1224 * composite.c (_work_char): Remove unused static var.
1225
9cb2ac56
JB
12262011-07-09 Juanma Barranquero <lekktu@gmail.com>
1227
1228 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1229
f25661f0
JD
12302011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1231
1232 * gtkutil.c (qttip_cb): Remove code without function.
1233
8278c4fe
EZ
12342011-07-09 Eli Zaretskii <eliz@gnu.org>
1235
1236 * w32.c (pthread_sigmask): New stub.
1237
1692ae2d 12382011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1239
8a6ebd58 1240 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1241 sigprocmask is portable only for single-threaded applications, and
1242 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1243 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1244 (LIBES): Use it.
1245 * callproc.c (Fcall_process):
1246 * process.c (create_process):
1247 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1248 Use pthread_sigmask, not sigprocmask.
123403e4 1249
1b854618
JD
12502011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1251
1252 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1253 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1254 wrong (Bug#8591).
1255
3fe4b549
JD
12562011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1257
0ce7e563
JD
1258 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1259 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1260 (xg_hide_tooltip): Fix comment.
1261
3fe4b549
JD
1262 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1263 in registerServicesMenuSendTypes.
1264 (validRequestorForSendType): Don't check ns_return_types.
1265
1266 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1267 ns_return_type.
1268
5df75e47
JR
12692011-07-08 Jason Rumney <jasonr@gnu.org>
1270
1271 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1272 frame struct members of non-existent frames (Bug#6284).
1273
699c10bd
JD
12742011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1275
4393663b
JD
1276 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1277 variable firstTime not needed on OSX >= 10.6.
1278 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1279 >= 10.5. Use setKnobProportion, setDoubleValue.
1280
1281 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1282 (MAC_OS_X_VERSION_10_5): Define if not defined.
1283 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1284 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1285 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1286
1287 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1288 cString and lossyCString on OSX >= 10.4
1289
1290 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1291 sizeToFit on OSX >= 10.2.
1292
1293 * nsimage.m (allocInitFromFile): Don't use deprecated method
1294 bestRepresentationForDevice on OSX >= 10.6.
1295
1296 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1297 to avoid warning.
1298
1299 * emacs.c: Declare unexec_init_emacs_zone.
1300
a63e0781
JD
1301 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1302
699c10bd
JD
1303 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1304
1305 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1306 on svcsMenu (Bug#8842).
1307
1308 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1309 ns_return_types.
1310 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1311
1312 * nsterm.m (QUTF8_STRING): Declare.
1313 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1314 (validRequestorForSendType): Return type is (id).
1315 Change indexOfObjectIdenticalTo to indexOfObject.
1316 Check if we have local selection before returning self (Bug#8842).
1317 (writeSelectionToPasteboard): Put local selection into paste board
1318 if we have a local selection (Bug#8842).
1319 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1320
1321 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1322 (ns_get_local_selection): Declare.
1323
54e10184
LMI
13242011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1325
9888ff71
LMI
1326 * keymap.c (describe_map_tree): Don't insert a double newline at
1327 the end of the buffer (bug#1169) and return whether we inserted
1328 something.
1329
54e10184
LMI
1330 * callint.c (Fcall_interactively): Change "reading args" to
1331 "providing args" to try to clarify what it does (bug#1010).
1332
15fa4783
KH
13332011-07-07 Kenichi Handa <handa@m17n.org>
1334
1335 * composite.c (composition_compute_stop_pos): Ignore a static
1336 composition starting before CHARPOS (Bug#8915).
1337
1338 * xdisp.c (handle_composition_prop): Likewise.
1339
a8815b00
EZ
13402011-07-07 Eli Zaretskii <eliz@gnu.org>
1341
1342 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1343 (Bug#9015)
1344
ef7b981d 13452011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1346
1347 * character.h (unicode_category_t): New enum type.
1348
1349 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1350 (Qchar_code_property_table): New variable.
1351 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1352 (UNIPROP_COMPRESSED_FORM_P): New macros.
1353 (char_table_ascii): Uncompress the compressed values.
1354 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1355 Uncompress the compressed values.
ac389d0c 1356 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1357 (char_table_ref_and_range): Uncompress the compressed values.
1358 (sub_char_table_set): New arg is_uniprop. Callers changed.
1359 Uncompress the compressed values.
1360 (sub_char_table_set_range): Args changed. Callers changed.
1361 (char_table_set_range): Adjuted for the above change.
1362 (map_sub_char_table): Delete args default_val and parent. Add arg
1363 top. Give decoded values to a Lisp function.
640c8776 1364 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1365 values to a Lisp function. Gcpro more variables.
1366 (uniprop_table_uncompress)
1367 (uniprop_decode_value_run_length): New functions.
1368 (uniprop_decoder, uniprop_decoder_count): New variables.
1369 (uniprop_get_decoder, uniprop_encode_value_character)
1370 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1371 New functions.
1372 (uniprop_encoder, uniprop_encoder_count): New variables.
1373 (uniprop_get_encoder, uniprop_table)
1374 (Funicode_property_table_internal, Fget_unicode_property_internal)
1375 (Fput_unicode_property_internal): New functions.
1376 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1377 Sunicode_property_table_internal, Sget_unicode_property_internal,
1378 and Sput_unicode_property_internal. Defvar_lisp
1379 char-code-property-alist.
1380
640c8776 1381 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1382 Vunicode_category_table.
1383
640c8776 1384 * font.c (font_range): Adjust for the change of
c805dec0
KH
1385 Vunicode_category_table.
1386
76b397fb
DN
13872011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1388
1389 * m/iris4d.h: Remove file, move contents ...
1390 * s/irix6-5.h: ... here.
1391
22b4128e
PE
13922011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1393
1394 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1395 * alloc.c (mark_buffer):
1396 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1397 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1398 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1399 This isn't true in general, and it's particularly not true
1400 if Emacs is configured with --with-wide-int.
1401 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1402 New macros, used in the buffer.c change.
1403
869795d6
JD
14042011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1405
1406 * xsettings.c: Use both GConf and GSettings if both are available.
1407 (store_config_changed_event): Add comment.
1408 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1409 (store_tool_bar_style_changed): New functions.
1410 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1411 (struct xsettings): Move font inside HAVE_XFT.
1412 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 1413 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 1414 Move inside HAVE_XFT.
640c8776 1415 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
1416 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1417 also.
1418 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
1419 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1420 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
1421 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1422 (parse_settings): Move check for font inside HAVE_XFT.
1423 (read_settings, apply_xft_settings): Add comment.
1424 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1425 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1426 call store_font_name_changed.
1427 (xft_settings_event): Add comment.
1428 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1429 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1430 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1431 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1432 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
1433 (xsettings_get_system_font, xsettings_get_system_normal_font):
1434 Add comment.
869795d6 1435
d8ed26bd
PE
14362011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1437
1438 Random fixes. E.g., (random) never returned negative values.
1439 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1440 subseconds part to the entropy, as that's a bit more random.
1441 Prefer signed to unsigned, since the signedness doesn't matter and
1442 in general we prefer signed. When given a limit, use a
1443 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1444 latter isn't right if USE_2_TAGS_FOR_INTS.
1445 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1446 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1447
cabf1cac
SM
14482011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1449
1450 * textprop.c (text_property_stickiness):
1451 Obey Vtext_property_default_nonsticky.
1452 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1453 * w32fns.c (syms_of_w32fns):
1454 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1455
6e9b2be9
PE
14562011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1457
1458 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1459 This is more efficient than Ffile_directory_p and avoids a minor race.
1460
90186c68
LMI
14612011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1462
7c301272
LMI
1463 * buffer.c (Foverlay_put): Say what the return value is
1464 (bug#7835).
1465
c4f2d8d4
LMI
1466 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1467 is a directory before asking whether to use the file name
1468 (bug#7564).
ad637907
LMI
1469 (barf_or_query_if_file_exists): Make the "File is a directory"
1470 error be more correct.
c4f2d8d4 1471
90186c68
LMI
1472 * fns.c (Frequire): Remove the mention of the .gz files, since
1473 that's installation-specific, but keep the mention of
1474 `get-load-suffixes'.
1475
da64016e
PE
14762011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1477
1478 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1479 Report string overflow if the output is too long.
1480
7d47b580
JB
14812011-07-04 Juanma Barranquero <lekktu@gmail.com>
1482
a555cb87
JB
1483 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1484 (syms_of_gnutls): Remove duplicate DEFSYM for
1485 Qgnutls_bootprop_verify_hostname_error, an error for
1486 Qgnutls_bootprop_verify_error (which is no longer used).
1487
7d47b580
JB
1488 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1489 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1490 Also (re)move comments that are misplaced or no longer relevant.
1491
1e49bfab
LMI
14922011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1493
1494 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1495
1485f4c0
CY
14962011-07-03 Chong Yidong <cyd@stupidchicken.com>
1497
1498 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1499 and background color parameters if they have been changed.
1500
a9ab721e
LMI
15012011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1502
1503 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1504
cf7cff57
PE
15052011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1506
2e13213d
PE
1507 * xsettings.c (SYSTEM_FONT): Define only when used.
1508 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1509
cf7cff57
PE
1510 * keymap.c (access_keymap_1): Now static.
1511
7a8e04f7
CY
15122011-07-02 Chong Yidong <cyd@stupidchicken.com>
1513
1514 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1515 leave any prefix arg for the up event (Bug#1586).
1516
61352f62
LMI
15172011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1518
69bb1ef7
LMI
1519 * lread.c (syms_of_lread): Mention single symbols defined by
1520 `defvar' or `defconst' (bug#7154).
1521
61352f62 1522 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1523 (Frequire): Mention get-load-suffixes.
61352f62 1524
28545e04
MR
15252011-07-02 Martin Rudalics <rudalics@gmx.at>
1526
1527 * window.h (window): Remove clone_number slot.
1528 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1529 Remove.
1530 (make_parent_window, make_window, saved_window)
1531 (Fset_window_configuration, save_window_save): Don't deal with
1532 clone numbers.
1533 * buffer.c (Qclone_number): Remove declaration.
1534 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1535
3349e122
SM
15362011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1537
1538 Add multiple inheritance to keymaps.
1539 * keymap.c (Fmake_composed_keymap): New function.
1540 (Fset_keymap_parent): Simplify.
1541 (fix_submap_inheritance): Remove.
1542 (access_keymap_1): New function extracted from access_keymap to handle
1543 embedded parents and handle lists of maps.
1544 (access_keymap): Use it.
1545 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1546 (Fcopy_keymap): Handle embedded parents.
1547 (Fcommand_remapping, define_as_prefix): Simplify.
1548 (Fkey_binding): Simplify.
1549 (syms_of_keymap): Move minibuffer-local-completion-map,
1550 minibuffer-local-filename-completion-map,
1551 minibuffer-local-must-match-map, and
1552 minibuffer-local-filename-must-match-map to Elisp.
1553 (syms_of_keymap): Defsubr make-composed-keymap.
1554 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1555 (parse_menu_item): Trivial simplification.
1556
3279eb87
GM
15572011-07-01 Glenn Morris <rgm@gnu.org>
1558
1559 * Makefile.in (SETTINGS_LIBS): Fix typo.
1560
4550efdf
KI
15612011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1562
1563 * coding.c (Fencode_coding_string): Record the last coding system
1564 used, as the function doc string says (bug#8738).
1565
0949d2b6
JD
15662011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1567
1568 * xsettings.c (store_monospaced_changed): Take new font as arg and
1569 check for change against current_mono_font.
1570 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1571 (emacs_settings_constructor, emacs_settings_get_property)
1572 (emacs_settings_set_property, emacs_settings_class_init)
1573 (emacs_settings_init, gsettings_obj): Remove.
1574 (something_changedCB): New function for HAVE_GSETTINGS.
1575 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1576 with value as argument.
1577 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1578 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1579 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1580 "changed".
1581
1582 * xgselect.c: Add defined (HAVE_GSETTINGS).
1583 (xgselect_initialize): Ditto.
1584
1585 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1586 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1587 xg_select.
1588
bbc6b304
PE
15892011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1590
1591 * eval.c (struct backtrace): Simplify and port the data structure.
1592 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1593 signed bit field, as this assumption is not portable and it makes
1594 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1595 "char debug_on_exit : 1" as this is not portable either; instead,
1596 use the portable "unsigned int debug_on_exit : 1". Remove unused
1597 member evalargs. Remove obsolete comments about cc bombing out.
1598
9851bfc5
JD
15992011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1600
51bb811f 1601 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1602 Let HAVE_GSETTINGS override HAVE_GCONF.
1603 (store_monospaced_changed): New function.
1604 (EMACS_SETTINGS): A new type derived from GObject to handle
1605 GSettings notifications.
1606 (emacs_settings_constructor, emacs_settings_get_property)
1607 (emacs_settings_set_property, emacs_settings_class_init):
1608 New functions.
1609 (gsettings_client, gsettings_obj): New variables.
1610 (GSETTINGS_SCHEMA): New define.
1611 (something_changedCB): Call store_monospaced_changed.
1612 (init_gsettings): New function.
1613 (xsettings_initialize): Call init_gsettings.
1614 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1615 to NULL.
1616
640c8776 1617 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
1618 GCONF_CFLAGS/LIBS.
1619
5386012d
MR
16202011-06-29 Martin Rudalics <rudalics@gmx.at>
1621
1622 * window.c (resize_root_window, grow_mini_window)
1623 (shrink_mini_window): Rename Qresize_root_window to
1624 Qwindow_resize_root_window and Qresize_root_window_vertically to
1625 Qwindow_resize_root_window_vertically.
1626
f13e0b08
PE
16272011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1628
1629 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1630
94515237
JB
16312011-06-27 Juanma Barranquero <lekktu@gmail.com>
1632
1633 * makefile.w32-in: Redesign dependencies so they reflect more
1634 clearly which files are directly included by each source file,
1635 and not through other includes.
1636
e43b6e43
MR
16372011-06-27 Martin Rudalics <rudalics@gmx.at>
1638
1639 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1640 (sort_overlays, overlay_strings): When an overlay's clone number
1641 matches the window's clone number process the overlay even if
1642 the overlay's window property doesn't match the current window.
1643
d68443dc
MR
1644 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1645 (Fwindow_hchild): Rename to Fwindow_left_child.
1646 (Fwindow_next): Rename to Fwindow_next_sibling.
1647 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1648 (resize_window_check): Rename to window_resize_check.
1649 (resize_window_apply): Rename to window_resize_apply.
1650 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1651 (Fdelete_other_windows_internal, resize_frame_windows)
1652 (Fsplit_window_internal, Fdelete_window_internal)
1653 (grow_mini_window, shrink_mini_window)
1654 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1655
c7e73be5
JD
16562011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1657
1658 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1659 (emacs_fixed_set_min_size): Remove.
1660 (emacs_fixed_new): Take frame as argument.
1661
1662 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1663 (_EmacsFixedPrivate): Remove minwidth/height.
1664 Add struct frame *f.
1665 (emacs_fixed_init): Initialize priv->f.
1666 (get_parent_class, emacs_fixed_set_min_size): Remove.
1667 (emacs_fixed_new): Set priv->f to argument.
1668 (emacs_fixed_get_preferred_width)
1669 (emacs_fixed_get_preferred_height): Use min_width/height from
1670 frames size_hint to set minimum and natural (Bug#8919).
1671 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1672 and use min_width/height from frames size_hint to set
1673 min_width/height (Bug#8919).
1674
1675 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1676 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1677 Fix indentation.
c7e73be5 1678
cf99dcf8
EZ
16792011-06-26 Eli Zaretskii <eliz@gnu.org>
1680
1681 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1682 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1683 called at ZV.
1684
029529ac
CY
16852011-06-26 Chong Yidong <cyd@stupidchicken.com>
1686
1687 * process.c (wait_reading_process_output): Bypass select if
1688 waiting for a cell while ignoring keyboard input, and input is
1689 pending. Suggested by Jan Djärv (Bug#8869).
1690
7a7ef429
PE
16912011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1692
1693 Use gnulib's dup2 module instead of rolling our own.
1694 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1695
11fdef7d 16962011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1697
1698 * dispnew.c (scrolling_window): Before scrolling, turn off a
1699 mouse-highlight in the window being scrolled.
1700
cd3520a4
JB
17012011-06-24 Juanma Barranquero <lekktu@gmail.com>
1702
1703 Move DEFSYM to lisp.h and use everywhere.
1704
1705 * character.h (DEFSYM): Move declaration...
1706 * lisp.h (DEFSYM): ...here.
1707
1708 * gnutls.c:
1709 * minibuf.c:
1710 * w32menu.c:
1711 * w32proc.c:
1712 * w32select.c: Don't include character.h.
1713
1714 * alloc.c (syms_of_alloc):
1715 * buffer.c (syms_of_buffer):
1716 * bytecode.c (syms_of_bytecode):
1717 * callint.c (syms_of_callint):
1718 * casefiddle.c (syms_of_casefiddle):
1719 * casetab.c (init_casetab_once):
1720 * category.c (init_category_once, syms_of_category):
1721 * ccl.c (syms_of_ccl):
1722 * cmds.c (syms_of_cmds):
1723 * composite.c (syms_of_composite):
1724 * dbusbind.c (syms_of_dbusbind):
1725 * dired.c (syms_of_dired):
1726 * dispnew.c (syms_of_display):
1727 * doc.c (syms_of_doc):
1728 * editfns.c (syms_of_editfns):
1729 * emacs.c (syms_of_emacs):
1730 * eval.c (syms_of_eval):
1731 * fileio.c (syms_of_fileio):
1732 * fns.c (syms_of_fns):
1733 * frame.c (syms_of_frame):
1734 * fringe.c (syms_of_fringe):
1735 * insdel.c (syms_of_insdel):
1736 * keymap.c (syms_of_keymap):
1737 * lread.c (init_obarray, syms_of_lread):
1738 * macros.c (syms_of_macros):
1739 * msdos.c (syms_of_msdos):
1740 * print.c (syms_of_print):
1741 * process.c (syms_of_process):
1742 * search.c (syms_of_search):
1743 * sound.c (syms_of_sound):
1744 * syntax.c (init_syntax_once, syms_of_syntax):
1745 * terminal.c (syms_of_terminal):
1746 * textprop.c (syms_of_textprop):
1747 * undo.c (syms_of_undo):
1748 * w32.c (globals_of_w32):
1749 * window.c (syms_of_window):
1750 * xdisp.c (syms_of_xdisp):
1751 * xfaces.c (syms_of_xfaces):
1752 * xfns.c (syms_of_xfns):
1753 * xmenu.c (syms_of_xmenu):
1754 * xsettings.c (syms_of_xsettings):
1755 * xterm.c (syms_of_xterm): Use DEFSYM.
1756
4228cf16
TZ
17572011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1758
cd3520a4 1759 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1760
7fcccf1e
PE
17612011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1762
7efb4e0e
PE
1763 Integer and buffer overflow fixes (Bug#8873).
1764
ff5844ad
PE
1765 * print.c (printchar, strout): Check for string overflow.
1766 (PRINTPREPARE, printchar, strout):
1767 Don't set size unless allocation succeeds.
1768
90532f02
PE
1769 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1770 for sizes. Check for string overflow more accurately.
1771 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1772
6d84508d
PE
1773 * macros.c: Integer and buffer overflow fixes.
1774 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1775 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1776 Use ptrdiff_t, not int, for sizes.
1777 Don't increment bufsize until after realloc succeeds.
1778 Check for size-calculation overflow.
1779 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1780
437b2cb4
PE
1781 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1782
8b9ac8b4
PE
1783 * lread.c: Integer overflow fixes.
1784 (read_integer): Radix is now EMACS_INT, not int,
1785 to improve quality of diagnostics for out-of-range radices.
1786 Calculate buffer size correctly for out-of-range radices.
1787 (read1): Check for integer overflow in radices, and in
1788 read-circle numbers.
82cb60d3
PE
1789 (read_escape): Avoid int overflow.
1790 (Fload, openp, read_buffer_size, read1)
1791 (substitute_object_recurse, read_vector, read_list, map_obarray):
1792 Use ptrdiff_t, not int, for sizes.
1793 (read1): Use EMACS_INT, not int, for sizes.
20270765 1794 Check for size overflow.
8b9ac8b4 1795
7fcccf1e
PE
1796 * image.c (cache_image): Check for size arithmetic overflow.
1797
bfbbd7e7
PE
1798 * lread.c: Integer overflow issues.
1799 (saved_doc_string_size, saved_doc_string_length)
1800 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1801 Now ptrdiff_t, not int.
1802 (read1): Don't assume doc string length fits in int. Check for
1803 out-of-range doc string lengths.
1804 (read_list): Don't assume file position fits in int.
39019e54 1805 (read_escape): Check for hex character overflow.
bfbbd7e7 1806
4e323265
LL
18072011-06-22 Leo Liu <sdl.web@gmail.com>
1808
1809 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1810 Move to minibuffer.el.
1811
85fece3e
PE
18122011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1813
20b84ce9 1814 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1815 The following patches are for when GLYPH_DEBUG && !XASSERT.
1816 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1817 * dispnew.c (flush_stdout):
1818 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1819 Mark as externally visible.
1820 * dispnew.c (check_window_matrix_pointers): Now static.
1821 * dispnew.c (window_to_frame_vpos):
1822 * xfns.c (unwind_create_frame):
1823 * xterm.c (x_check_font): Remove unused local.
1824 * scroll.c (CHECK_BOUNDS):
1825 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1826 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1827 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1828 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1829 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1830 Now static.
1831 (debug_method_add): Use va_list and vsprintf rather than relying
1832 on undefined behavior with wrong number of arguments.
1833 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1834 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1835 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1836 since we're not interested in debugging glyphs with old libraries.
1837 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1838 GCC 4.6.0's static checking.
1839
0766b489
PE
18402011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1841
31fd4b32
PE
1842 Integer overflow and signedness fixes (Bug#8873).
1843 A few related buffer overrun fixes, too.
1844
b79e8648
PE
1845 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1846
0766b489
PE
1847 * dispextern.h (struct face.stipple):
1848 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1849 (x_bitmap_mask, x_allocate_bitmap_record)
1850 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1851 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1852 (x_create_bitmap_from_xpm_data):
1853 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1854 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1855 (.bitmaps_last):
1856 * xfaces.c (load_pixmap):
1857 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1858 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1859 (.bitmaps_last, struct x_output.icon_bitmap):
1860 Use ptrdiff_t, not int, for bitmap indexes.
1861 (x_allocate_bitmap_record): Check for size overflow.
1862 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1863
b081724f
PE
1864 Use ptrdiff_t, not int, for overlay counts.
1865 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1866 * editfns.c (overlays_around, get_pos_property):
1867 * textprop.c (get_char_property_and_overlay):
1868 * xdisp.c (next_overlay_change, note_mouse_highlight):
1869 * xfaces.c (face_at_buffer_position):
21514da7
PE
1870 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1871 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1872 (Fnext_overlay_change, Fprevious_overlay_change)
1873 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1874 Use ptrdiff_t, not int, for sizes.
21514da7 1875 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1876
3de73e5e
PE
1877 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1878
2606c57b
PE
1879 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1880 (x_session_initialize): Do not assume string length fits in int.
1881
aaafe47a
PE
1882 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1883 This is unlikely, but can occur if DPI is outlandish.
1884
2674ddc8 1885 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1886 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1887
28154962
PE
1888 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1889 * xrdb.c (magic_file_p, search_magic_path):
1890 Omit last arg SUFFIX; it was always 0. All callers changed.
1891 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1892
7de51af5
PE
1893 * xfont.c (xfont_match): Avoid need for strlen.
1894
25ed6cc3
PE
1895 * xfns.c: Don't assume strlen fits in int.
1896 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1897
4eab31dd
PE
1898 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1899 not unsigned long, as we prefer signed integers. All callers changed.
1900 Detect integer overflow in repeat count.
1901 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1902 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1903
171e2a58
PE
1904 * termcap.c: Don't assume sizes fit in int and never overflow.
1905 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1906 (gobble_line): Check for size-calculation overflow.
1907
ad39faca 1908 * minibuf.c (Fread_buffer):
6e5bb2dc 1909 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1910 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1911 Don't assume string length fits in int.
1912
52c61c22 1913 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1914 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1915
b5b8c9e5
PE
1916 * font.c: Don't assume string length fits in int.
1917 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1918 Use ptrdiff_t, not int.
ccd6111c
PE
1919 (font_intern_prop): Don't assume string length fits in int.
1920 Don't assume integer property fits in fixnum.
1921 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1922
882f0d81 1923 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1924 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1925 Reformulate so as not to need the command string.
1926 Invoke gzip -cd rather than gunzip, as it's more portable.
1927 (lock_info_type, lock_file_1, lock_file):
1928 Don't assume pid_t and time_t fit in unsigned long.
1929 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1930 (current_lock_owner): Prefer signed type for sizes.
1931 Use memcpy, not strncpy, where memcpy is what is really wanted.
1932 Don't assume (via atoi) that time_t and pid_t fit in int.
1933 Check for time_t and/or pid_t out of range, e.g., via a network share.
1934 Don't alloca where an auto var works fine.
1935
93f4cf88
PE
1936 * fileio.c: Fix some integer overflow issues.
1937 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1938 Don't assume string length fits in int.
1939 (directory_file_name): Don't assume string length fits in long.
1940 (make_temp_name): Don't assume pid fits in int, or that its print
1941 length is less than 20.
1942
f3e92b69
PE
1943 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1944
1bfdaf10
PE
1945 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1946
35016e9a
PE
1947 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1948
3d1e65a1
PE
1949 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1950 We prefer signed integers, even for size calculations.
1951
0b963a93
PE
1952 * emacs.c: Don't assume string length fits in 'int'.
1953 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1954 (main): Don't invoke strlen when not needed.
1955
573f4b54
PE
1956 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1957 (XD_DEBUG_MESSAGE): Don't waste a byte.
1958
989f33ba
PE
1959 * callproc.c (getenv_internal_1, getenv_internal)
1960 (Fgetenv_internal):
965d34eb
PE
1961 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1962
e4d29b33
PE
1963 * lread.c (invalid_syntax): Omit length argument.
1964 All uses changed. This doesn't fix a bug, but it simplifies the
1965 code away from its former Hollerith-constant appearance, and it's
1966 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1967 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1968
eb49b136
PE
1969 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1970 This didn't break anything, but it didn't help either.
1971 It's confusing to put a bogus integer in a place where the actual
1972 value does not matter.
9f62aeb1 1973 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1974 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1975
15375a22
PE
1976 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1977 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1978 implementation.
b61cc01c
PE
1979 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1980 We prefer signed types, and the value cannot exceed the EMACS_INT
1981 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1982 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1983 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1984 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1985
53b2623d
PE
1986 * indent.c (sane_tab_width): New function.
1987 (current_column, scan_for_column, Findent_to, position_indentation)
1988 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1989 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1990
51cab52b 1991 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1992
f2ed8a70
PE
1993 * lisp.h (lint_assume): New macro.
1994 * composite.c (composition_gstring_put_cache):
1995 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1996
abe80cc6
PE
1997 * editfns.c, insdel.c:
1998 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1999
b02c740e
PE
2000 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2001
ebc96716
PE
2002 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2003
b4e50fa0 2004 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2005 Use much-faster test for byte-length change.
311d5d7c 2006 Don't assume string byte-length fits in 'int'.
a4cf38e4 2007 Check that character arg fits in 'int'.
85461888 2008 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2009
c0c1ee9f
PE
2010 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2011
a498d7f4
PE
2012 * fns.c (concat): Catch string overflow earlier.
2013 Do not rely on integer wraparound.
2014
51cab52b
PE
2015 * dispextern.h (struct it.overlay_strings_charpos)
2016 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2017 * xdisp.c (forward_to_next_line_start)
2018 (back_to_previous_visible_line_start)
2019 (reseat_at_next_visible_line_start, next_element_from_buffer):
2020 Don't arbitrarily truncate the value of 'selective' to int.
2021
76031fad
PE
2022 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2023
5eb55db9
PE
2024 * composite.c: Don't truncate sizes to 'int'.
2025 (composition_gstring_p, composition_reseat_it)
2026 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2027 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2028 not EMACS_UINT, for indexes.
5eb55db9 2029
0703a717
PE
2030 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2031
d6202519
PE
2032 * buffer.c: Include <verify.h>.
2033 (struct sortvec.priority, struct sortstr.priority):
8961a454 2034 Now EMACS_INT, not int.
c20998a7 2035 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2036 (struct sortstr.size, record_overlay_string)
2037 (struct sortstrlist.size, struct sortlist.used):
2038 Don't truncate size to int.
2039 (record_overlay_string): Check for size-calculation overflow.
d6202519 2040 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2041
d5a19415
JM
20422011-06-22 Jim Meyering <meyering@redhat.com>
2043
029529ac 2044 Don't leak an XBM-image-sized buffer
d5a19415
JM
2045 * image.c (xbm_load): Free the image buffer after using it.
2046
a9041e6c
PE
20472011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2048
2049 Port to Sun C.
2050 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2051 that Sun C diagnosed.
2052 * fns.c (secure_hash): Fix pointer signedness issue.
2053 * intervals.c (static_offset_intervals): New function.
2054 (offset_intervals): Use it.
2055
7f3f739f
LL
20562011-06-21 Leo Liu <sdl.web@gmail.com>
2057
2058 * deps.mk (fns.o):
2059 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2060 sha512.h.
2061
2062 * fns.c (secure_hash): Rename from crypto_hash_function and change
2063 the first arg to accept symbols.
5b66d427 2064 (Fsecure_hash): New primitive.
7f3f739f
LL
2065 (syms_of_fns): New symbols.
2066
76147d94
DD
20672011-06-20 Deniz Dogan <deniz@dogan.se>
2068
2069 * process.c (Fset_process_buffer): Clarify return value in
2070 docstring.
2071
7d7d0045
CY
20722011-06-18 Chong Yidong <cyd@stupidchicken.com>
2073
2074 * dispnew.c (add_window_display_history): Use BVAR.
2075
2076 * xdisp.c (debug_method_add): Use BVAR.
2077 (check_window_end, dump_glyph_matrix, dump_glyph)
2078 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2079
2080 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2081 Likewise.
2082
2083 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2084 check till after the cache is created in init_frame_faces.
2085
ff2bc410
SM
20862011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2087
2088 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2089
28177add
PE
20902011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2091
dd3482fe
PE
2092 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2093 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2094 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2095
393d71f3 2096 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2097 * fileio.c (Finsert_file_contents):
2098 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2099 Remove the old (too-loose) buffer overflow checks.
2100 They weren't needed, since make_gap checks for buffer overflow.
2101 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2102 The old code merely checked for Emacs fixnum overflow, and relied
2103 on undefined (wraparound) behavior. The new code avoids undefined
2104 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2105
2e6813b0 2106 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2107 Tune. Don't use wider integers than needed. Don't use alloca.
2108 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2109
599a9e4f
PE
2110 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2111
99561444
PE
2112 * insdel.c, lisp.h (buffer_overflow): New function.
2113 (insert_from_buffer_1, replace_range, replace_range_2):
2114 * insdel.c (make_gap_larger):
2115 * editfns.c (Finsert_char):
2116 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2117
28177add
PE
2118 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2119
e69dafad
PE
21202011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2121
a7af7fde 2122 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2123
b1c46f02
PE
2124 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2125 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2126
e69dafad
PE
2127 * fileio.c: Don't assume EMACS_INT fits in off_t.
2128 (emacs_lseek): New static function.
2129 (Finsert_file_contents, Fwrite_region): Use it.
2130 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2131
566684ea
PE
2132 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2133
e6966cd6
PE
2134 * fns.c: Don't overflow int when computing a list length.
2135 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2136 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2137 truncation on 64-bit hosts. Check for QUIT every
2138 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2139 faster and is responsive enough.
2140 (Flength): Report an error instead of overflowing an integer.
2141 (Fsafe_length): Return a float if the value is not representable
2142 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2143 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2144 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2145
dd0b0efb
PE
2146 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2147 (header_size, word_size): New constants.
2148 (allocate_vectorlike): Don't check size overflow here.
2149 (allocate_vector): Check it here instead, since this is the only
2150 caller of allocate_vectorlike that could cause overflow.
2151 Check that the new vector's length is representable as a fixnum.
2152
86fe5cfe
PE
2153 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2154 The previous code was bogus. For example, next_almost_prime (32)
2155 returned 39, which is undesirable as it is a multiple of 3; and
2156 next_almost_prime (24) returned 25, which is a multiple of 5 so
2157 why was the code bothering to check for multiples of 7?
2158
80e88859
PE
2159 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2160
4a2f0ad6
PE
2161 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2162
f66c7cf8
PE
2163 Variadic C functions now count arguments with ptrdiff_t.
2164 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2165 Back then I didn't know that the Emacs coding style prefers signed int.
2166 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2167 were being counted with int, which may truncate counts on 64-bit
2168 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2169 * lisp.h (struct Lisp_Subr.function.aMANY)
2170 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2171 Arg counts are now ptrdiff_t, not size_t.
2172 All variadic functions and their callers changed accordingly.
2173 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2174 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2175 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2176 * callint.c (Fcall_interactively): Check arg count for overflow,
2177 to avoid potential buffer overrun. Use signed char, not 'int',
2178 for 'varies' array, so that we needn't bother to check its size
2179 calculation for overflow.
2180 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2181 * eval.c (apply_lambda):
2182 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2183 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2184 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2185
a1759b76
PE
2186 * callint.c (Fcall_interactively): Don't use index var as event count.
2187
d96be9fc
PE
2188 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2189 * mem-limits.h (SIZE): Remove; no longer used.
2190
a690a978 2191 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2192
578c21e6
PE
2193 Remove unnecessary casts.
2194 * xterm.c (x_term_init):
2195 * xfns.c (x_set_border_pixel):
2196 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2197 These aren't needed now that we assume ANSI C.
2198
96f53c6c
PE
2199 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2200 It's more likely to cause problems (due to unsigned overflow)
2201 than to cure them.
2202
83c77d31
PE
2203 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2204
ee2079f1
PE
2205 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2206
6da65536
PE
2207 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2208
7147c4a4
PE
2209 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2210
193e32d9
PE
2211 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2212
e5533da6
PE
2213 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2214
9910e595
PE
2215 GLYPH_CODE_FACE returns EMACS_INT, not int.
2216 * dispextern.h (merge_faces):
2217 * xfaces.c (merge_faces):
01103c44
PE
2218 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2219 Don't assume EMACS_INT fits in int.
9910e595 2220
2638320e
PE
2221 * character.h (CHAR_VALID_P): Remove unused parameter.
2222 * fontset.c, lisp.h, xdisp.c: All uses changed.
2223
045eb8d9
PE
2224 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2225
c1f134b5
PE
2226 * fns.c (concat): Minor tuning based on overflow analysis.
2227 This doesn't fix any bugs. Use int to hold character, instead
2228 of constantly refetching from Emacs object. Use XFASTINT, not
2229 XINT, for value known to be a character. Don't bother comparing
2230 a single byte to 0400, as it's always less.
2231
395fcb93 2232 * floatfns.c (Fexpt):
327eeec8
PE
2233 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2234
abbd3d23
PE
2235 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2236 for characters.
2237
684a03ef
PE
2238 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2239
0fed43f3
PE
2240 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2241 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2242 incorrectly succeed when S was a string, because 4294967386 was
2243 truncated before it was used.
2244
8fd02eb7
PE
2245 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2246 Otherwise, an out-of-range integer could cause undefined behavior
2247 on a 64-bit host.
2248
f8c86b69
PE
2249 * composite.c: Use int, not EMACS_INT, for characters.
2250 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2251 EMACS_INT, for values that are known to be in character range.
2252 This doesn't fix any bugs but is the usual style inside Emacs and
2253 may generate better code on 32-bit machines.
2254
34206dd2
PE
2255 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2256 This is for reasons similar to the recent CHAR_STRING fix.
2257 * charset.c (Fencode_char): Check that character arg is actually
2258 a character. Pass an int to ENCODE_CHAR.
2259 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2260 wider than 'int', as a compile-time check to prevent future regressions
2261 in this area.
2262
c5958d4c 2263 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2264
2265 Make sure a 64-bit char is never passed to CHAR_STRING.
2266 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2267 by silently ignoring the top 32 bits, allowing some values
2268 that were far too large to be valid characters.
2269 * character.h: Include <verify.h>.
2270 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2271 arguments are no wider than unsigned, as a compile-time check
2272 to prevent future regressions in this area.
2273 * data.c (Faset):
01103c44 2274 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2275 (Fsubst_char_in_region):
2276 * fns.c (concat):
2277 * xdisp.c (decode_mode_spec_coding):
2278 Adjust to CHAR_STRING's new requirement.
2279 * editfns.c (Finsert_char, Fsubst_char_in_region):
2280 * fns.c (concat): Check that character args are actually
2281 characters. Without this test, these functions did the wrong
2282 thing with wildly out-of-range values on 64-bit hosts.
2283
d37ca623
PE
2284 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2285 These casts should not be needed on 32-bit hosts, either.
2286 * keyboard.c (read_char):
2287 * lread.c (Fload): Remove casts to unsigned.
2288
ea204efb
PE
2289 * lisp.h (UNSIGNED_CMP): New macro.
2290 This fixes comparison bugs on 64-bit hosts.
2291 (ASCII_CHAR_P): Use it.
2292 * casefiddle.c (casify_object):
01103c44 2293 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2294 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2295 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2296 * dispextern.h (FACE_FROM_ID):
2297 * keyboard.c (read_char): Use UNSIGNED_CMP.
2298
41cb286c
PE
2299 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2300 not to EMACS_INT, to avoid GCC warning.
2301
4a1b9832
PE
2302 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2303
55daad71
PE
2304 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2305 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2306 isn't needed on 32-bit machines.
8f95c75c 2307
01103c44
PE
2308 * buffer.c (Fgenerate_new_buffer_name):
2309 Use EMACS_INT for count, not int.
0ceccced 2310 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2311
2312 * data.c (Qcompiled_function): Now static.
2313
c6f072e7
PE
2314 * window.c (window_body_lines): Now static.
2315
20ce5912
PE
2316 * image.c (gif_load): Rename local to avoid shadowing.
2317
9c4c5f81
PE
2318 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2319 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2320 * alloc.c (make_save_value): Integer argument is now of type
2321 ptrdiff_t, not int.
2322 (mark_object): Use ptrdiff_t, not int.
2323 * lisp.h (pD): New macro.
2324 * print.c (print_object): Use it.
2325
c0c5c8ae
PE
2326 * alloc.c: Use EMACS_INT, not int, to count objects.
2327 (total_conses, total_markers, total_symbols, total_vector_size)
2328 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2329 (total_free_floats, total_floats, total_free_intervals)
2330 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2331 Now EMACS_INT, not int. All uses changed.
2332 (Fgarbage_collect): Compute overall total using a double, so that
2333 integer overflow is less likely to be a problem. Check for overflow
2334 when converting back to an integer.
5a25e253
PE
2335 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2336 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2337 These were 'int' variables that could overflow on 64-bit hosts;
2338 they were never used, so remove them instead of repairing them.
211a0b2a 2339 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2340 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2341 Previously, this ceilinged at INT_MAX, but that doesn't work on
2342 64-bit machines.
e46bb31a 2343 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2344
c78baabf 2345 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2346 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2347 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2348 when a (possibly-narrower) signed value would do just as well.
2349 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2350
c9d624c6
PE
2351 * alloc.c: Catch some string size overflows that we were missing.
2352 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2353 for convenience in STRING_BYTES_MAX.
2354 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2355 The definition here is exact; the one in lisp.h was approximate.
2356 (allocate_string_data): Check for string overflow. This catches
2357 some instances we weren't catching before. Also, it catches
2358 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2359 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2360 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2361
c9d624c6
PE
2362 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2363 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2364 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2365
353032ce
PE
2366 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2367
2bccce07
PE
2368 * alloc.c (Fmake_string): Check for out-of-range init.
2369
0ac30604
SM
23702011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2371
2372 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2373
c195f2de
JD
23742011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2375
2376 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2377 xg_get_default_scrollbar_width.
2378
2379 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2380 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2381 (style_changed_cb): Call update_theme_scrollbar_width and call
2382 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2383 all frames (Bug#8505).
2384 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2385 Call gtk_window_set_resizable if HAVE_GTK3.
2386 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2387 and height if HAVE_GTK3 (Bug#8505).
2388 (scroll_bar_width_for_theme): New variable.
2389 (update_theme_scrollbar_width): New function.
2390 (xg_get_default_scrollbar_width): Move code to
2391 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2392 (xg_initialize): Call update_theme_scrollbar_width.
2393
2394 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2395
2396 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2397
e10ac9f1
MR
23982011-06-12 Martin Rudalics <rudalics@gmx.at>
2399
2400 * frame.c (make_frame): Call other_buffer_safely instead of
2401 other_buffer.
2402
2403 * window.c (temp_output_buffer_show): Call display_buffer with
2404 second argument Vtemp_buffer_show_specifiers and reset latter
2405 immediately after the call.
2406 (Vtemp_buffer_show_specifiers): New variable.
2407 (auto_window_vscroll_p, next_screen_context_lines)
2408 (Vscroll_preserve_screen_position): Remove leading asterisks from
2409 doc-strings.
2410
2d3c217e 24112011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2412
7b7f97e8 2413 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2414 * buffer.c (Qclone_number): Remove for now, as it's unused.
2415 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2416 (record_buffer): Remove unused local.
2417 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2418 (set_frame_buffer_list): Remove; unused.
2419 * frame.h (other_visible_frames): Remove decl.
2420 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2421 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2422 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2423 if HAVE_GPM.
2424 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2425 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2426 Define only if HAVE_GPM.
2427 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2428 (update_hints_inhibit): Remove; never set. All uses removed.
2429 * widgetprv.h (emacsFrameClassRec): Remove decl.
2430 * window.c (delete_deletable_window): Now returns void, since it
2431 wasn't returning anything.
2432 (compare_window_configurations): Remove unused locals.
2433 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2434 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2435 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2436 the same widths as pointers. This follows up on the 2011-05-06 patch.
2437 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2438 * xterm.h: Likewise.
2439 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2440
1384b89e
JB
24412011-06-12 Juanma Barranquero <lekktu@gmail.com>
2442
2443 * makefile.w32-in: Update dependencies.
2444 (LISP_H): Add lib/intprops.h.
2445
1100a63c
CY
24462011-06-11 Chong Yidong <cyd@stupidchicken.com>
2447
2448 * image.c (gif_load): Add animation frame delay to the metadata.
2449 (syms_of_image): Use DEFSYM. New symbol `delay'.
2450
6198ccd0
MR
24512011-06-11 Martin Rudalics <rudalics@gmx.at>
2452
2453 * window.c (delete_deletable_window): Re-add.
2454 (Fset_window_configuration): Rewrite to handle dead buffers and
2455 consequently deletable windows.
2456 (window_tree, Fwindow_tree): Remove. Supply functionality in
2457 window.el.
2458 (compare_window_configurations): Simplify code.
2459
b6e3633c
AS
24602011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2461
1ab0dee5
AS
2462 * image.c (imagemagick_load_image): Fix type mismatch.
2463 (Fimagemagick_types): Likewise.
2464
b6e3633c
AS
2465 * window.h (replace_buffer_in_windows): Declare.
2466
9397e56f
MR
24672011-06-11 Martin Rudalics <rudalics@gmx.at>
2468
2469 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2470 Qclone_number. Remove external declaration of Qdelete_window.
2471 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2472 code.
640c8776
SM
2473 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2474 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
2475 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2476 buffer list implementation.
2477 (other_buffer_safely): New function.
2478 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2479 calls to replace_buffer_in_windows and
2480 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2481 if allowed.
2482 (record_buffer): Inhibit quitting and rewrite using quittable
2483 functions. Run Qbuffer_list_update_hook if allowed.
2484 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
2485 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2486 Move switch-to-buffer to window.el.
9397e56f
MR
2487 (bury-buffer): Move to window.el.
2488 (Vbuffer_list_update_hook): New variable.
2489
2490 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2491 section.
2492
2493 * window.h (resize_frame_windows): Move up in code.
2494 (Fwindow_frame): Remove EXFUN.
2495 (replace_buffer_in_all_windows): Remove prototype.
2496 (replace_buffer_in_windows_safely): Add prototype.
2497
2498 * window.c: Declare Qdelete_window static again. Move down
2499 declaration of select_count.
2500 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2501 (Fother_window): Move to window.el.
2502 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2503 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2504 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2505 window.el.
2506 (replace_buffer_in_windows): Implement by calling
2507 Qreplace_buffer_in_windows.
2508 (replace_buffer_in_all_windows): Remove with some functionality
2509 moved into replace_buffer_in_windows_safely.
2510 (replace_buffer_in_windows_safely): New function.
2511 (select_window_norecord, select_frame_norecord): Move in front
2512 of run_window_configuration_change_hook. Remove now obsolete
2513 declarations.
640c8776
SM
2514 (Fset_window_buffer): Rewrite doc-string.
2515 Call Qrecord_window_buffer.
9397e56f
MR
2516 (keys_of_window): Move binding for other-window to window.el.
2517
b50691aa
CY
25182011-06-11 Chong Yidong <cyd@stupidchicken.com>
2519
2520 * dispextern.h (struct image): Replace data member, whose int_val
2521 and ptr_val fields were not used by anything, with a single
2522 lisp_val object.
2523
2524 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2525 (gif_clear_image, gif_load, imagemagick_load_image)
2526 (gs_clear_image, gs_load): Callers changed.
2527
3f754b86
PE
25282011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2529
cca69397
PE
2530 * buffer.h: Include <time.h>, for time_t.
2531 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2532
109e28d0
PE
2533 Fix minor problems found by static checking.
2534
60737f02
PE
2535 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2536
4b66faf3
PE
2537 Make identifiers static if they are not used in other modules.
2538 * data.c (Qcompiled_function, Qframe, Qvector):
2539 * image.c (QimageMagick, Qsvg):
2540 * minibuf.c (Qmetadata):
2541 * window.c (resize_window_check, resize_root_window): Now static.
2542 * window.h (resize_window_check, resize_root_window): Remove decls.
2543
109e28d0
PE
2544 * window.c (window_deletion_count, delete_deletable_window):
2545 Remove; unused.
46a4ce9e
PE
2546 (window_body_lines): Now static.
2547 (Fdelete_other_windows_internal): Mark vars as initialized.
2548 Make sure 'resize_failed' is initialized.
2549 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2550 (resize_window_apply): Remove unused local.
2551 * window.h (delete_deletable_window): Remove decl.
2552
109e28d0 2553 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2554 (imagemagick_load_image): Fix pointer signedness problem by changing
2555 last arg from unsigned char * to char *. All uses changed.
2556 Also, fix a local for similar reasons.
2557 Remove unused locals. Remove locals to avoid shadowing.
2558 (fn_rsvg_handle_free): Remove; unused.
2559 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2560 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2561
3f754b86
PE
2562 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2563
2547adb1
CY
25642011-06-10 Chong Yidong <cyd@stupidchicken.com>
2565
2566 * image.c (gif_load): Fix omitted cast error introduced by
2567 2011-06-06 change.
2568
2c8e37d4
MR
25692011-06-10 Martin Rudalics <rudalics@gmx.at>
2570
2571 * window.h (resize_proportionally, orig_total_lines)
2572 (orig_top_line): Remove from window structure.
2573 (set_window_height, set_window_width, change_window_heights)
2574 (Fdelete_window): Remove prototypes.
2575 (resize_frame_windows): Remove duplicate declaration.
2576
440a42e3
EZ
25772011-06-10 Eli Zaretskii <eliz@gnu.org>
2578
2579 * window.h (resize_frame_windows, resize_window_check)
2580 (delete_deletable_window, resize_root_window)
2581 (resize_frame_windows): Declare prototypes.
2582
2583 * window.c (resize_window_apply): Make definition be "static" to
2584 match the prototype.
2585
562dd5e9
MR
25862011-06-10 Martin Rudalics <rudalics@gmx.at>
2587
2588 * window.c: Remove declarations of Qwindow_size_fixed,
2589 window_min_size_1, window_min_size_2, window_min_size,
2590 size_window, window_fixed_size_p, enlarge_window, delete_window.
2591 Remove static from declaration of Qdelete_window, it's
2592 temporarily needed by Fbury_buffer.
2593 (replace_window): Don't assign orig_top_line and
2594 orig_total_lines.
2595 (Fdelete_window, delete_window): Remove. Window deletion is
2596 handled by window.el.
640c8776
SM
2597 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2598 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
2599 (Fdelete_other_windows): Remove. Deleting other windows is
2600 handled by window.el.
2601 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2602 handled in window.el.
2603 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2604 Window minimum sizes are handled in window.el.
2605 (shrink_windows, size_window, set_window_height)
2606 (set_window_width, change_window_heights, window_height)
2607 (window_width, CURBEG, CURSIZE, enlarge_window)
2608 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2609 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2610 handled in window.el.
2611 (make_dummy_parent): Rename to make_parent_window and give it a
2612 second argument horflag.
2613 (make_window): Don't set resize_proportionally any more.
2614 (Fsplit_window): Remove. Windows are split in window.el.
2615 (save_restore_action, save_restore_orig_size)
2616 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2617 Resize mini windows in window.el.
2618 (grow_mini_window, shrink_mini_window): Implement by calling
2619 Qresize_root_window_vertically, resize_window_check and
2620 resize_window_apply.
640c8776
SM
2621 (saved_window, Fset_window_configuration, save_window_save):
2622 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
2623 resize_proportionally.
2624 (window_min_height, window_min_width): Move to window.el.
2625 (keys_of_window): Move bindings for delete-other-windows,
2626 split-window, delete-window and enlarge-window to window.el.
2627
2628 * buffer.c: Temporarily extern Qdelete_window.
2629 (Fbury_buffer): Temporarily call Qdelete_window instead of
2630 Fdelete_window (Fbury_buffer will move to window.el soon).
2631
2632 * frame.c (set_menu_bar_lines_1): Remove code handling
2633 orig_top_line and orig_total_lines.
2634
2635 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2636 set_window_height but set heights directly.
2637 (change_frame_size_1): Use resize_frame_windows.
2638
2639 * xdisp.c (init_xdisp): Don't use set_window_height but set
2640 heights directly.
2641
640c8776
SM
2642 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2643 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
2644 run_window_configuration_change_hook.
2645
2646 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2647 instead of change_window_heights and run
2648 run_window_configuration_change_hook.
2649
1a13852e
MR
26502011-06-09 Martin Rudalics <rudalics@gmx.at>
2651
2652 * window.c (replace_window): Rename second argument REPLACEMENT to
2653 NEW. New third argument SETFLAG. Rewrite.
2654 (delete_window, make_dummy_parent): Call replace_window with
2655 third argument 1.
2656 (window_list_1): Move down in code.
2657 (run_window_configuration_change_hook): Move set_buffer part
2658 before select_frame_norecord part in order to unwind correctly.
2659 Rename count1 to count.
2660 (recombine_windows, delete_deletable_window, resize_root_window)
2661 (Fdelete_other_windows_internal)
2662 (Frun_window_configuration_change_hook, make_parent_window)
2663 (resize_window_check, resize_window_apply, Fresize_window_apply)
2664 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
2665 (Fdelete_window_internal, Fresize_mini_window_internal):
2666 New functions.
1a13852e
MR
2667 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2668
f3d1777e
MR
26692011-06-08 Martin Rudalics <rudalics@gmx.at>
2670
496e208e
MR
2671 * window.h (window): Add some new members to window structure -
2672 normal_lines, normal_cols, new_total, new_normal, clone_number,
2673 splits, nest, prev_buffers, next_buffers.
2674 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2675 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2676
f3d1777e
MR
2677 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2678 Remove.
496e208e
MR
2679 (make_dummy_parent): Set new members of windows structure.
2680 (make_window): Move down in code. Handle new members of window
2681 structure.
2682 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2683 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2684 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2685 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
2686 (Fset_window_next_buffers, Fset_window_clone_number):
2687 New functions.
496e208e
MR
2688 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2689 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2690 Doc-string fixes.
2691 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2692 Argument WINDOW can be now internal window too.
2693 (Fwindow_use_time): Move up in code.
2694 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2695 Rewrite doc-string.
2696 (Fset_window_configuration, saved_window)
2697 (Fcurrent_window_configuration, save_window_save): Handle new
2698 members of window structure.
b9e809c2
MR
2699 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2700 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2701 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2702 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2703 Qget_mru_window, Qresize_root_window,
2704 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2705 Qauto_buffer_name; staticpro them.
f3d1777e 2706
abde8f8c
MR
27072011-06-07 Martin Rudalics <rudalics@gmx.at>
2708
2709 * window.c (Fwindow_total_size, Fwindow_left_column)
2710 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2711 (Fwindow_list_1): New functions.
2712 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
2713 (Fwindow_width, Fscroll_left, Fscroll_right):
2714 Use window_body_cols instead of window_box_text_cols.
2715 (delete_window, Fset_window_configuration):
2716 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
2717 (delete_all_subwindows): Take a window as argument and not a
2718 structure. Rewrite.
190b47e6
MR
2719 (window_loop): Remove handling of GET_LRU_WINDOW and
2720 GET_LARGEST_WINDOW.
2721 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2722
2723 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2724 window_box_text_cols. delete_all_subwindows now takes a
2725 Lisp_Object as argument.
abde8f8c 2726
640c8776
SM
2727 * indent.c (compute_motion, Fcompute_motion):
2728 Use window_body_cols instead of window_box_text_cols.
abde8f8c 2729
fa8a67e6
MR
2730 * frame.c (delete_frame): Call delete_all_subwindows with root
2731 window as argument.
2732
a54e3482
DC
27332011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2734
2735 * fns.c (Fputhash): Document return value.
2736
60002bf5
CY
27372011-06-06 Chong Yidong <cyd@stupidchicken.com>
2738
2739 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2740
0c671da6 27412011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2742
b862a52a 2743 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2744
be44ca6c
PE
2745 Check for overflow when converting integer to cons and back.
2746 * charset.c (Fdefine_charset_internal, Fdecode_char):
2747 Use cons_to_unsigned to catch overflow.
2748 (Fencode_char): Use INTEGER_TO_CONS.
2749 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2750 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2751 * data.c (long_to_cons, cons_to_long): Remove.
2752 (cons_to_unsigned, cons_to_signed): New functions.
2753 These signal an error for invalid or out-of-range values.
2754 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2755 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2756 * font.c (Ffont_variation_glyphs):
2757 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2758 * lisp.h: Include <intprops.h>.
2759 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2760 (cons_to_signed, cons_to_unsigned): New decls.
2761 (long_to_cons, cons_to_long): Remove decls.
2762 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2763 (Fprimitive_undo): Use CONS_TO_INTEGER.
2764 * xfns.c (Fx_window_property): Likewise.
2765 * xselect.c: Include <limits.h>.
2766 (x_own_selection, selection_data_to_lisp_data):
2767 Use INTEGER_TO_CONS.
2768 (x_handle_selection_request, x_handle_selection_clear)
2769 (x_get_foreign_selection, Fx_disown_selection_internal)
2770 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2771 (lisp_data_to_selection_data): Use cons_to_unsigned.
2772 (x_fill_property_data): Use cons_to_signed.
2773 Report values out of range.
2774
d1f3d2af
PE
2775 Check for buffer and string overflow more precisely.
2776 * buffer.h (BUF_BYTES_MAX): New macro.
2777 * lisp.h (STRING_BYTES_MAX): New macro.
2778 * alloc.c (Fmake_string):
2779 * character.c (string_escape_byte8):
2780 * coding.c (coding_alloc_by_realloc):
2781 * doprnt.c (doprnt):
2782 * editfns.c (Fformat):
2783 * eval.c (verror):
2784 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2785 since they may not be the same number.
2786 * editfns.c (Finsert_char):
2787 * fileio.c (Finsert_file_contents):
2788 Likewise for BUF_BYTES_MAX.
2789
dd52fcea
PE
2790 * image.c: Use ptrdiff_t, not int, for sizes.
2791 (slurp_file): Switch from int to ptrdiff_t.
2792 All uses changed.
2793 (slurp_file): Check that file size fits in both size_t (for
2794 malloc) and ptrdiff_t (for sanity and safety).
2795
7f9bbdbb
PE
2796 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2797 if b->modtime has its maximal value.
2798
dfe18f82
PE
2799 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2800
84acfcf0
PE
2801 Don't assume time_t can fit into int.
2802 * buffer.h (struct buffer.modtime): Now time_t, not int.
2803 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2804 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2805
ccd9a01a
PE
2806 Minor fixes for signed vs unsigned integers.
2807 * character.h (MAYBE_UNIFY_CHAR):
2808 * charset.c (maybe_unify_char):
2809 * keyboard.c (read_char, reorder_modifiers):
2810 XINT -> XFASTINT, since the integer must be nonnegative.
2811 * ftfont.c (ftfont_spec_pattern):
2812 * keymap.c (access_keymap, silly_event_symbol_error):
2813 XUINT -> XFASTINT, since the integer must be nonnegative.
2814 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2815 since it makes no difference and we prefer signed.
2816 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2817 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2818 nonnegative.
2819
d6d100dd
SM
28202011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2821
2822 * window.h (Fwindow_frame): Declare.
2823
2b6148e4
PE
28242011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2825
2826 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2827 (SPARE_MEMORY): Always define.
2828 (LARGE_REQUEST): Remove.
2829 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2830
f230ecc9
MR
28312011-06-06 Martin Rudalics <rudalics@gmx.at>
2832
727e958e
MR
2833 * lisp.h: Move EXFUNS for Fframe_root_window,
2834 Fframe_first_window and Fset_frame_selected_window to window.h.
2835
2836 * window.h: Move EXFUNS for Fframe_root_window,
2837 Fframe_first_window and Fset_frame_selected_window here from
2838 lisp.h.
2839
2840 * frame.c (Fwindow_frame, Fframe_first_window)
2841 (Fframe_root_window, Fframe_selected_window)
2842 (Fset_frame_selected_window): Move to window.c.
2843 (Factive_minibuffer_window): Move to minibuf.c.
2844 (Fother_visible_frames_p): New function.
2845
2846 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2847
f230ecc9
MR
2848 * window.c (decode_window, decode_any_window): Move up in code.
2849 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2850 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2851 (Fwindow_buffer): Move up and rewrite doc-string.
2852 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2853 (Fwindow_prev): New functions.
727e958e
MR
2854 (Fwindow_frame): Move here from frame.c. Accept any window as
2855 argument.
2856 (Fframe_root_window, Fframe_first_window)
2857 (Fframe_selected_window): Move here from frame.c. Accept frame
2858 or arbitrary window as argument. Update doc-strings.
2859 (Fminibuffer_window): Move up in code.
2860 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2861 (Fset_frame_selected_window): Move here from frame.c.
2862 Marginal rewrite.
727e958e
MR
2863 (Fselected_window, select_window, Fselect_window): Move up in
2864 code. Minor doc-string fixes.
f230ecc9 2865
4d09bcf6
PE
28662011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2867
2868 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2869 Do not assume that spare memory exists; that assumption is valid
2870 only if SYSTEM_MALLOC.
2871 (LARGE_REQUEST): New macro, so that the issue of large requests
2872 is separated from the issue of spare memory.
2873
810928a2
AS
28742011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2875
172418ad
AS
2876 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2877 format. (Bug#8806)
2878
43f862f7
AS
2879 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2880
810928a2
AS
2881 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2882 before statements.
2883
a059fe24
JD
28842011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2885
2886 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2887
2888 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2889
2890 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2891 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2892
989bf368
JB
28932011-06-05 Juanma Barranquero <lekktu@gmail.com>
2894
2895 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2896
4b80f674
CY
28972011-06-04 Chong Yidong <cyd@stupidchicken.com>
2898
2899 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2900 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2901 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2902 New error handlers.
4b80f674
CY
2903 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2904 Obey Vx_select_enable_clipboard_manager. Catch errors in
2905 x_clipboard_manager_save (Bug#8779).
2906 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2907 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2908
99a33b77 29092011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2910
2911 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2912
99a33b77 29132011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2914
2915 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2916 in the current matrix if keep_current_p is non-zero.
2917
8264569d
EZ
29182011-06-04 Eli Zaretskii <eliz@gnu.org>
2919
2920 * bidi.c (bidi_level_of_next_char): Fix last change.
2921
57f97249
EZ
29222011-06-03 Eli Zaretskii <eliz@gnu.org>
2923
fec2107c 2924 Support bidi reordering of text covered by display properties.
57f97249 2925
fec2107c
EZ
2926 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2927 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2928 (bidi_cache_search, bidi_cache_iterator_state)
2929 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2930 (bidi_level_of_next_char, bidi_move_to_visually_next):
2931 Support character positions inside a run of characters covered by a
fec2107c
EZ
2932 display string.
2933 (bidi_paragraph_init, bidi_resolve_explicit_1)
2934 (bidi_level_of_next_char): Call bidi_fetch_char and
2935 bidi_fetch_char_advance instead of FETCH_CHAR and
2936 FETCH_CHAR_ADVANCE.
2937 (bidi_init_it): Initialize new members.
2938 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2939 definitions.
2940 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2941 instead of using explicit *_CHAR codes.
d6d100dd
SM
2942 (bidi_resolve_explicit, bidi_resolve_weak):
2943 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2944 bidirectional text is supported only in multibyte buffers.
2945 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2946 it to initialize the frame_window_p member of struct bidi_it.
2947 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2948 (bidi_resolve_explicit, bidi_resolve_weak)
2949 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2950 bidi_it->nchars is non-positive.
2951 (bidi_level_of_next_char): Don't try to lookup the cache for the
2952 next/previous character if nothing is cached there yet, or if we
2953 were just reseat()'ed to a new position.
c40e2fb2 2954
0e14fe90
EZ
2955 * xdisp.c (set_cursor_from_row): Set start and stop points
2956 according to the row's direction when priming the loop that looks
2957 for the glyph on which to display cursor.
2958 (single_display_spec_intangible_p): Function deleted.
2959 (display_prop_intangible_p): Reimplement to call
2960 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2961 Accept 3 additional arguments needed by handle_display_spec.
2962 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2963 values: lists, `(when COND...)' forms, etc.
2964 (single_display_spec_string_p): Support property values that are
2965 lists with the argument STRING its top-level element.
2966 (display_prop_string_p): Fix the condition for processing a
2967 property that is a list to be consistent with handle_display_spec.
fec2107c 2968 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2969 last portion of handle_display_prop.
2970 (compute_display_string_pos): Accept additional argument
2971 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2972 value of a `display' property is a "replacing spec".
2973 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2974 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2975 the display property, but just return a value indicating whether
2976 the display property will replace the characters it covers.
2977 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2978 frame_window_p members of struct bidi_it.
d6d100dd
SM
2979 (compute_display_string_pos, compute_display_string_end):
2980 New functions.
fec2107c
EZ
2981 (push_it): Accept second argument POSITION, where pop_it should
2982 jump to continue iteration.
2983 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2984
fec2107c
EZ
2985 * keyboard.c (adjust_point_for_property): Adjust the call to
2986 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2987
2988 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2989 (bidi_init_it): Update prototypes.
2990 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2991 (compute_display_string_pos, compute_display_string_end):
2992 Declare prototypes.
fec2107c
EZ
2993 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2994 EMACS_INT.
fc6f18ce 2995
40087514 29962011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2997
57f53182
PE
2998 Malloc failure behavior now depends on size of allocation.
2999 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3000 * lisp.h: Change signatures accordingly.
3001 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3002 All callers changed. (Bug#8762)
3003
3004 * gnutls.c: Use Emacs's memory allocators.
3005 Without this change, the gnutls library would invoke malloc etc.
3006 directly, which causes problems on non-SYNC_INPUT hosts, and which
3007 runs afoul of improving memory_full behavior. (Bug#8761)
3008 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3009 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3010 xfree instead of the default malloc, realloc, free.
3011 (Fgnutls_boot): No need to check for memory allocation failure,
3012 since xmalloc does that for us.
3013
ac32cd99 3014 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3015 * category.c (hash_get_category_set):
3016 * ccl.c (ccl_driver):
3017 * charset.c (Fdefine_charset_internal):
3018 * charset.h (struct charset.hash_index):
3019 * composite.c (get_composition_id, gstring_lookup_cache)
3020 (composition_gstring_put_cache):
3021 * composite.h (struct composition.hash_index):
3022 * dispextern.h (struct image.hash):
3023 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3024 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3025 (hashfn_equal, hashfn_user_defined, make_hash_table)
3026 (maybe_resize_hash_table, hash_lookup, hash_put)
3027 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3028 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3029 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3030 * image.c (make_image, search_image_cache, lookup_image)
3031 (xpm_put_color_table_h):
3032 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3033 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3034 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3035 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3036 * alloc.c (allocate_vectorlike):
3037 Check for overflow in vector size calculations.
3038 * ccl.c (ccl_driver):
3039 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3040 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3041 need to be updated by these changes.
40087514
PE
3042 * fns.c (make_hash_table, maybe_resize_hash_table):
3043 Check for integer overflow with large hash tables.
0de4bb68
PE
3044 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3045 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3046 (SXHASH_REDUCE): New macro.
3047 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3048 Use it instead of discarding useful hash info with large hash values.
3049 (sxhash_float): New function.
3050 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3051 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3052 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3053 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3054 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3055 Adjust signatures to match updated version of code.
3056 (consing_since_gc): Now EMACS_INT, since a single hash table can
3057 use more than INT_MAX bytes.
3058
698d32e2
DN
30592011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3060
3061 Make it possible to build with GCC-4.6+ -O2 -flto.
3062
3063 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3064
fd6fa53f
SM
30652011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3066
3067 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3068 Call minibuffer-inactive-mode.
3069
864db017
JB
30702011-05-31 Juanma Barranquero <lekktu@gmail.com>
3071
3072 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3073 Update dependencies.
3074
2ad0baf4
DN
30752011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3076
3077 * data.c (init_data): Remove code for UTS, this system is not
3078 supported anymore.
3079
4fcc2638
DN
30802011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3081
3082 Don't force ./temacs to start in terminal mode.
3083
3084 * frame.c (make_initial_frame): Initialize faces in all cases, not
3085 only when CANNOT_DUMP is defined.
3086 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3087
c56e0fd5
DN
30882011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3089
3090 * dispnew.c (add_window_display_history): Use const for the string
3091 pointer. Remove declaration, not needed.
3092
333d54da 30932011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3094
55d4c1b2 3095 Use 'inline', not 'INLINE'.
333d54da 3096 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3097 * alloc.c, fontset.c (INLINE): Remove.
3098 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3099 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3100 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3101 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3102 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3103
738db178
DN
31042011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3105
3106 Make it possible to run ./temacs.
3107
3108 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3109 syms_of_callproc does the same thing. Remove test for
3110 "initialized", do it in the caller.
3111 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3112
620c53a6
SM
31132011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3114
3115 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3116 (read_minibuf): Use get_minibuffer.
3117 (syms_of_minibuf): Use DEFSYM.
3118 (Qmetadata): New var.
3119 * data.c (Qbuffer): Don't make it static.
3120 (syms_of_data): Use DEFSYM.
3121
e003a292
PE
31222011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3123
3124 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3125 (CCL_CODE_MIN): New macro.
3126
ed008a6d
PE
31272011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3128
3687c2ef
PE
3129 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3130
ed008a6d
PE
3131 * eval.c (Qdebug): Now static.
3132 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3133 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3134 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3135
d66c4c7c
CY
31362011-05-29 Chong Yidong <cyd@stupidchicken.com>
3137
3138 * image.c: Various fixes to ImageMagick code comments.
3139 (Fimagemagick_types): Doc fix.
3140
5fbc2025
PE
31412011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3142
0196f88a
PE
3143 Minor fixes prompted by GCC 4.6.0 warnings.
3144
3145 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3146
5fbc2025
PE
3147 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3148 (x_clipboard_manager_save_all): Move extern decl to ...
3149 * xterm.h: ... here, so that it can be checked for consistency.
3150
1dd3c2d9
CY
31512011-05-29 Chong Yidong <cyd@stupidchicken.com>
3152
3153 * xselect.c (x_clipboard_manager_save_frame)
3154 (x_clipboard_manager_save_all): New functions.
3155 (Fx_clipboard_manager_save): Lisp function deleted.
3156
3157 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3158 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3159
3160 * xterm.h: Update prototype.
3161
5ba6571d
WX
31622011-05-28 William Xu <william.xwl@gmail.com>
3163
3164 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3165 exiting (Bug#8239).
3166
3eaff834
JM
31672011-05-28 Jim Meyering <meyering@redhat.com>
3168
e1900994 3169 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3170 * fns.c (to_uchar): Define.
3171 (crypto_hash_function): Use it to convert some newly-signed
3172 variables to unsigned, to avoid sign-extension bugs. For example,
3173 without this change, (md5 "truc") would evaluate to
3174 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3175 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3176 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3177
0f6990a7
PE
31782011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3179
3180 Integer overflow fixes.
c8a9ca5a 3181
08686060
PE
3182 * dbusbind.c: Serial number integer overflow fixes.
3183 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3184 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3185 to hold a serial number that is too large for a fixnum.
3186 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3187 Check for serial numbers out of range. Decode any serial number
59568bf0 3188 that was so large that it became a float. (Bug#8722)
08686060 3189
2d1fc3c7
PE
3190 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3191 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3192 Use XFASTINT rather than XUINT when numbers are nonnegative.
3193 (xd_append_arg, Fdbus_method_return_internal):
3194 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3195 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3196 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3197 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3198 (Bug#8722)
2d1fc3c7 3199
c8a9ca5a
PE
3200 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3201
519e1d69
PE
3202 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3203
30569699
PE
3204 ccl: add integer overflow checks
3205 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3206 (IN_INT_RANGE): New macros.
3207 (ccl_driver): Use them to check for integer overflow when
3208 decoding a CCL program. Many of the new checks are whether XINT (x)
3209 fits in int; it doesn't always, on 64-bit hosts. The new version
3210 doesn't catch all possible integer overflows, but it's an
847044ea 3211 improvement. (Bug#8719)
30569699 3212
c11285dc
PE
3213 * alloc.c (make_event_array): Use XINT, not XUINT.
3214 There's no need for unsigned here.
3215
fdccd48e
PE
3216 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3217 This follows up to the 2011-05-06 change that substituted uintptr_t
3218 for EMACS_INT. This case wasn't caught back then.
3219
37910ab2
PE
3220 Rework Fformat to avoid integer overflow issues.
3221 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3222 now (part of C89). Include <verify.h>.
3223 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3224 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3225 (Fformat): Avoid the prepass trying to compute sizes; it was only
3226 approximate and thus did not catch overflow reliably. Instead, walk
3227 through the format just once, formatting and computing sizes as we go,
3228 checking for integer overflow at every step, and allocating a larger
3229 buffer as needed. Keep track separately whether the format is
3230 multibyte. Keep only the most-recently calculated precision, rather
3231 than them all. Record whether each argument has been converted to
3232 string. Use EMACS_INT, not int, for byte and char and arg counts.
3233 Support field widths and precisions larger than INT_MAX. Avoid
3234 sprintf's undefined behavior with conversion specifications such as %#d
3235 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3236 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3237 formatting out-of-range floating point numbers with int
9173deec 3238 formats. (Bug#8668)
37910ab2 3239
2e6578fb
PE
3240 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3241
0ae6bdee
PE
3242 * data.c: Avoid integer truncation in expressions involving floats.
3243 * data.c: Include <intprops.h>.
3244 (arith_driver): When there's an integer overflow in an expression
3245 involving floating point, convert the integers to floating point
3246 so that the resulting value does not suffer from catastrophic
3247 integer truncation. For example, on a 64-bit host (* 4
3248 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3249 Do not rely on undefined behavior after integer overflow.
3250
de883a70
PE
3251 merge count_size_as_multibyte, parse_str_to_multibyte
3252 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3253 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3254 Check for integer overflow.
3255 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3256 since it's now a duplicate of the other. This is more of
3257 a character than a buffer op, so better that it's in character.c.
3258 * fns.c, print.c: Adjust to above changes.
3259
2ff916cb
PE
32602011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3261
3262 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3263
f1b54466
PE
32642011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3265
fb1ac845
PE
3266 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3267 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3268 (x_clipboard_manager_save): Now static.
3269 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3270
f1b54466
PE
3271 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3272 (crypto_hash_function): Now static.
3273 Fix pointer signedness problems. Avoid unnecessary initializations.
3274
a9f737ee
CY
32752011-05-27 Chong Yidong <cyd@stupidchicken.com>
3276
3277 * termhooks.h (Vselection_alist): Make it terminal-local.
3278
3279 * terminal.c (create_terminal): Initialize it.
3280
3281 * xselect.c: Support for clipboard managers.
3282 (Vselection_alist): Move to termhooks.h as terminal-local var.
3283 (LOCAL_SELECTION): New macro.
3284 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3285 (symbol_to_x_atom): Remove gratuitous arg.
3286 (x_handle_selection_request, lisp_data_to_selection_data)
3287 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3288 (x_own_selection, x_get_local_selection, x_convert_selection):
3289 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3290 (some_frame_on_display): Delete unused function.
3291 (Fx_own_selection_internal, Fx_get_selection_internal)
3292 (Fx_disown_selection_internal, Fx_selection_owner_p)
3293 (Fx_selection_exists_p): New optional frame arg.
3294 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3295 (x_handle_selection_clear): Don't treat other terminals with the
3296 same keyboard specially. Use the terminal-local Vselection_alist.
3297 (x_clear_frame_selections): Use Frun_hook_with_args.
3298
3299 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3300
3301 * xterm.h: Add support for those atoms.
3302
e067f0c1
CY
33032011-05-26 Chong Yidong <cyd@stupidchicken.com>
3304
3305 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3306 (converted_selections, conversion_fail_tag): New global variables.
3307 (x_selection_request_lisp_error): Free the above.
3308 (x_get_local_selection): Remove unnecessary code.
3309 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3310 of converted selections stored in converted_selections.
3311 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3312 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3313 (x_convert_selection): New function.
3314 (x_handle_selection_event): Simplify.
3315 (x_get_foreign_selection): Don't ignore incoming requests while
3316 waiting for an answer; this will fail when we implement
3317 SAVE_TARGETS, and seems unnecessary anyway.
3318 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3319 (Vx_sent_selection_functions): Doc fix.
3320
0f4aebc0
LL
33212011-05-26 Leo Liu <sdl.web@gmail.com>
3322
3323 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3324
e61124cd
YM
33252011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3326
3327 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3328
3329 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3330 for fringe update if it has periodic bitmap.
ac389d0c 3331 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3332 and fringe_bitmap_periodic_p.
3333
3334 * fringe.c (get_fringe_bitmap_data): New function.
3335 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3336 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3337 row. Mark glyph row for fringe update if periodicity changed.
3338
3339 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3340 for fringe update unless it has periodic bitmap.
3341
f16d9837
KH
33422011-05-25 Kenichi Handa <handa@m17n.org>
3343
3344 * xdisp.c (get_next_display_element): Set correct it->face_id for
3345 a static composition.
3346
e1b90ef6
LL
33472011-05-24 Leo Liu <sdl.web@gmail.com>
3348
3349 * deps.mk (fns.o):
3350 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3351
3352 * fns.c (crypto_hash_function, Fsha1): New function.
3353 (Fmd5): Use crypto_hash_function.
3354 (syms_of_fns): Add Ssha1.
3355
7400048f
PE
33562011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3357
3358 * gnutls.c: Remove unused macros.
3359 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3360 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3361 Remove macros that are defined and never used.
3362 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3363
abb71cf4
CY
33642011-05-22 Chong Yidong <cyd@stupidchicken.com>
3365
3366 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3367 (Fx_get_selection_internal): Minor cleanup.
3368 (Fx_own_selection_internal): Rename arguments for consistency with
3369 select.el.
3370
6307db39
PE
33712011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3372
3373 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3374
f3d4e0a4
CY
33752011-05-22 Chong Yidong <cyd@stupidchicken.com>
3376
3377 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3378
4d8ade89
YM
33792011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3380
3381 * dispnew.c (scrolling_window): Don't exclude the case that the
3382 last enabled row in the desired matrix touches the bottom boundary.
3383
32078c8d
GM
33842011-05-21 Glenn Morris <rgm@gnu.org>
3385
3386 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3387 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3388 and add some more files.
32078c8d 3389
7285dc67
EZ
33902011-05-20 Eli Zaretskii <eliz@gnu.org>
3391
3392 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3393 report_file_error introduced by the change from 2011-05-07.
3394
89d1bd22
PE
33952011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3396
3397 * systime.h (Time): Define only if emacs is defined.
3398 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3399 where the include path doesn't have X11/X.h by default. See
3400 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3401
e23640bb 34022011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3403
3404 * composite.c (find_automatic_composition): Fix previous change.
3405
b9704ad9
GM
34062011-05-20 Glenn Morris <rgm@gnu.org>
3407
3408 * lisp.mk: New file, split from Makefile.in.
3409 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3410 (shortlisp): Remove.
3411 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3412
4a720484
GM
34132011-05-19 Glenn Morris <rgm@gnu.org>
3414
3415 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3416 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3417 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3418 (lisp): Set the order to that of loadup.el.
3419 (shortlisp): Make it a copy of $lisp.
3420 (SOME_MACHINE_LISP): Remove.
3421 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3422 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3423
a28d4396
KH
34242011-05-18 Kenichi Handa <handa@m17n.org>
3425
3426 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3427 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3428 (find_automatic_composition): Mostly rewrite for efficiency.
3429
a2b1fa8e
JB
34302011-05-18 Juanma Barranquero <lekktu@gmail.com>
3431
3432 * makefile.w32-in: Update dependencies.
3433
8e1f5610
CS
34342011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3435
3436 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3437 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3438
7025ee00 34392011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3440
cdfa6eab
PE
3441 Fix some integer overflow issues, such as string length overflow.
3442
06d6db33
PE
3443 * insdel.c (count_size_as_multibyte): Check for string overflow.
3444
2b4560a8
PE
3445 * character.c (lisp_string_width): Check for string overflow.
3446 Use EMACS_INT, not int, for string indexes and lengths; in
3447 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3448 the resulting string length overflows an EMACS_INT; instead,
3449 report a string overflow if no precision given. When checking for
3450 precision exhaustion, use a check that cannot possibly have
3451 integer overflow. (Bug#8675)
3452 * character.h (lisp_string_width): Adjust to new signature.
3453
cb93f9be
PE
3454 * alloc.c (string_overflow): New function.
3455 (Fmake_string): Use it. This doesn't change behavior, but saves
3456 a few bytes and will simplify future changes.
3457 * character.c (string_escape_byte8): Likewise.
3458 * lisp.h (string_overflow): New decl.
3459
1a1f3366
PE
3460 Fixups, following up to the user-interface timestamp change.
3461 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3462 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3463 * msdos.c (mouse_get_pos): Likewise.
3464 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3465 * w32gui.h (Time): Define by including "systime.h" rather than by
3466 declaring it ourselves. (Bug#8664)
3467
d4e3e4d3
PE
3468 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3469 * image.c (clear_image_cache): Likewise.
3470
f6a24d19
PE
3471 * term.c (term_mouse_position): Don't assume time_t wraparound.
3472
08dc5ae6
PE
3473 Be more systematic about user-interface timestamps.
3474 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3475 and sometimes 'EMACS_UINT', to represent these timestamps.
3476 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3477 This makes the code easier to follow, and makes it easier to catch
3478 integer overflow bugs such as Bug#8664.
3479 * frame.c (Fmouse_position, Fmouse_pixel_position):
3480 Use Time, not unsigned long, for user-interface timestamps.
3481 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3482 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3483 * keyboard.h (last_event_timestamp): Likewise.
3484 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3485 * menu.h (xmenu_show): Likewise.
3486 * term.c (term_mouse_position): Likewise.
3487 * termhooks.h (struct input_event.timestamp): Likewise.
3488 (struct terminal.mouse_position_hook): Likewise.
3489 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3490 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3491 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3492 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3493 what it was before.
3494 * menu.h, termhooks.h: Include "systime.h", for Time.
3495
8e55734a
PE
3496 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3497 Don't assume that the difference between two unsigned long values
3498 can fit into an integer. At this point, we know button_down_time
3499 <= event->timestamp, so the difference must be nonnegative, so
3500 there's no need to cast the result if double-click-time is
3501 nonnegative, as it should be; check that it's nonnegative, just in
3502 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3503 apart (about 25 days). (Bug#8664)
8e55734a 3504
841f1b75 3505 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3506 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3507
3e26f69c
PE
3508 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3509 that always fit in int. Use a sentinel instead of a counter, to
3510 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3511 * frame.h (struct frame): Use int for menu_bar_items_used
3512 instead of EMACS_INT, since it always fits in int.
3e26f69c 3513
5cc152c0
PE
3514 * menu.c (grow_menu_items): Check for int overflow.
3515
d89eb65e
PE
3516 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3517
5235bd3e
PE
3518 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3519 Before, the code was not consistent. These values cannot exceed
3520 2**31 - 1 so there's no need to make them unsigned.
3521 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3522 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3523 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3524 as modifiers.
3525 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3526
bc827e23
PE
3527 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3528 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3529 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3530 presumably because the widths might not match.
3531
78eb494e
PE
3532 * window.c (size_window): Avoid needless test at loop start.
3533
04f2d78b
CB
35342011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3535
3536 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3537
d2fc7e3d 35382011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3539
3540 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3541
d2fc7e3d 35422011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3543
3544 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3545 `width' to `bar_area_x' and `bar_area_width', respectively.
3546 (x_scroll_run): Take account of fringe background extension.
3547
04f2d78b
CB
3548 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3549 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3550 `bar_area_width', respectively.
3551 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3552 background extension.
3553
79b70037
GM
35542011-05-10 Jim Meyering <meyering@redhat.com>
3555
3556 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3557
2f142cc5
JB
35582011-05-10 Juanma Barranquero <lekktu@gmail.com>
3559
3560 * image.c (Finit_image_library): Return t for built-in image types,
3561 like pbm and xbm. (Bug#8640)
3562
57679c86
AS
35632011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3564
3565 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3566
888c9e86
EZ
35672011-05-07 Eli Zaretskii <eliz@gnu.org>
3568
b0512a1d
EZ
3569 * w32console.c (Fset_screen_color): Doc fix.
3570 (Fget_screen_color): New function.
3571 (syms_of_ntterm): Defsubr it.
3572
7285dc67
EZ
3573 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3574 unlink the temporary file if Fcall_process didn't create it in the
3575 first place.
3576 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3577 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3578 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3579 cue to call_process_cleanup not to close that handle.
3580
4d3fcc8e
BK
35812011-05-07 Ben Key <bkey76@gmail.com>
3582
3583 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3584 one of two shell specific rules, either bootstrap-temacs-CMD or
3585 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3586 to the previous implementation of the bootstrap-temacs rule.
3587 The bootstrap-temacs-CMD rule is similar to the previous
3588 implementation of the bootstrap-temacs rule except that it
3589 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3590 variable.
3591
3592 These changes, along with some changes to nt/configure.bat,
3593 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3594 earlier fix to add support for --cflags and --ldflags options
3595 that include quotes so that it works whether make uses cmd or
3596 sh as the shell.
3597
b4289b64
MA
35982011-05-06 Michael Albinus <michael.albinus@gmx.de>
3599
3600 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3601 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3602 is a constant.
3603 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3604 a string. Handle both cases.
3605 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3606 (Fdbus_register_method): Use Qinvalid_function.
3607
af4c0e28
JB
36082011-05-06 Juanma Barranquero <lekktu@gmail.com>
3609
3610 * makefile.w32-in: Update dependencies.
3611 (LISP_H): Add inttypes.h and stdin.h.
3612 (PROCESS_H): Add unistd.h.
3613
c51453d9
EZ
36142011-05-06 Eli Zaretskii <eliz@gnu.org>
3615
3616 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3617 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3618
8ff0ac3c 36192011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3620
4c4b566b
PE
3621 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3622
aab2b9b5
PE
3623 * term.c (vfatal): Remove stray call to va_end.
3624 It's not needed and the C Standard doesn't allow it here anyway.
3625
c378da0b
PE
3626 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3627 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3628
288b08c7
PE
3629 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3630 bytes.
3631
e3601888
PE
3632 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3633
db6c0e74
PE
3634 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3635
dd5963ea
PE
3636 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3637
88c9450f
PE
3638 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3639
2f9442b8
PE
3640 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3641
c032b5f8
PE
3642 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3643 * charset.c (Fdefine_charset_internal): Don't initialize
3644 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3645 32-bit int (Bug#8600).
a108c10b
PE
3646
3647 * lread.c (read_integer): Be more consistent with string-to-number.
3648 Use string_to_number to do the actual conversion; this avoids
3649 rounding errors and fixes some other screwups. Without this fix,
3650 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3651 (digit_to_number): Move earlier, for benefit of read_integer.
3652 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3653 not a digit in any supported base. (Bug#8602)
a108c10b 3654
ad5f9eea
PE
3655 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3656
aec1708a
PE
3657 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3658 to match comment at start of function. This also removes a
3659 GCC warning about overflow in a 32+64-bit port.
3660
47be4ab5
PE
3661 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3662
371cac43
PE
3663 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3664 Reported by Stefan Monnier in
3665 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3666 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3667 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3668
d01a7826
PE
3669 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3670 (EMACS_UINTPTR): Likewise, with uintptr_t.
3671
7fd47d5c
PE
3672 * lisp.h: Prefer 64-bit EMACS_INT if available.
3673 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3674 on 32-bit hosts that have 64-bit int, so that they can access
3675 large files.
122b0c86
PE
3676 However, temporarily disable this change unless the temporary
3677 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3678
8727937b
PE
3679 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3680
8ac068ac
PE
3681 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3682 This removes an assumption that EMACS_INT and long are the same
3683 width as pointers. The assumption is true for Emacs porting targets
3684 now, but we want to make other targets possible.
3685 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3686 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3687 In the rest of the code, change types of integers that hold casted
3688 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3689 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3690 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3691 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3692 No need to cast type when ORing.
3693 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3694 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3695 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3696 assume EMACS_INT is the same width as char *.
3697 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3698 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3699 Remove no-longer-needed casts.
3700 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3701 (xg_tool_bar_help_callback, xg_make_tool_item):
3702 Use EMACS_INTPTR to hold an integer
3703 that will be cast to void *; this can avoid a GCC warning
3704 if EMACS_INT is not the same width as void *.
3705 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3706 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3707 (current_message_1, set_message_1):
3708 Use a local to convert to proper width without a cast.
3709 * xmenu.c (dialog_selection_callback): Likewise.
3710
ede49d71
PE
3711 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3712 Also, don't assume VALBITS / RAND_BITS is less than 5,
3713 and don't rely on undefined behavior when shifting a 1 left into
3714 the sign bit.
3715 * lisp.h (get_random): Change signature to match.
3716
2f30ecd0
PE
3717 * lread.c (hash_string): Use size_t, not int, for hash computation.
3718 Normally we prefer signed values; but hashing is special, because
3719 it's better to use unsigned division on hash table sizes so that
3720 the remainder is nonnegative. Also, size_t is the natural width
3721 for hashing into memory. The previous code used 'int', which doesn't
3722 retain enough info to hash well into very large tables.
3723 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3724
2a866e7b
PE
3725 * dbusbind.c: Don't possibly lose pointer info when converting.
3726 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3727 Use XPNTR rather than XHASH, so that the high-order bits of
3728 the pointer aren't lost when converting through void *.
3729
51639eac
PE
3730 * eval.c (Fautoload): Don't double-shift a pointer.
3731
92394119
PE
3732 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3733
dbdb9a7c
JB
37342011-05-06 Juanma Barranquero <lekktu@gmail.com>
3735
3736 * gnutls.c (DEF_GNUTLS_FN):
3737 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3738
db7a0b4f
AS
37392011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3740
3741 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3742 marker. (Bug#8610)
3743
f7ff1b0f 37442011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3745
3746 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3747 New version that can reserve upto 2GB of heap space.
3748
f7ff1b0f 37492011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3750
3751 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3752
639c109b
TZ
37532011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3754
3755 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3756 `gnutls_certificate_set_x509_key_file'.
3757
d2127135
JB
37582011-05-05 Juanma Barranquero <lekktu@gmail.com>
3759
3760 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3761 Update dependencies.
3762
e968f4f3
JB
37632011-05-04 Juanma Barranquero <lekktu@gmail.com>
3764
3765 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3766 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3767 Remove unused parameter `fildes'.
3768 * process.c (read_process_output, send_process): Don't pass it.
3769
84d358f0
JB
37702011-05-04 Juanma Barranquero <lekktu@gmail.com>
3771
3772 Fix previous change: the library cache is defined in w32.c.
3773 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3774 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3775
0898ca10
JB
37762011-05-04 Juanma Barranquero <lekktu@gmail.com>
3777
3778 Implement dynamic loading of GnuTLS on Windows.
3779
3780 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3781 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3782 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3783 Declare.
3784
3785 * gnutls.c (Qgnutls_dll): Define.
3786 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3787 (gnutls_*): Declare function pointers.
3788 (init_gnutls_functions): New function to initialize function pointers.
3789 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3790 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3791 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3792 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3793 (emacs_gnutls_write, emacs_gnutls_read)
3794 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3795 (Fgnutls_available_p): New function.
3796 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3797 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3798 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3799
3800 * image.c: Include w32.h.
3801 (Vimage_type_cache): Delete.
3802 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3803 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3804 (w32_delayed_load): Move to w32.c.
3805
3806 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3807
3808 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3809 (w32_delayed_load): Move from image.c. When loading a library, record
3810 its filename in the :loaded-from property of the library id.
3811 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3812 Initialize and staticpro them.
3813 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3814
3815 * process.c: Include lisp.h before w32.h, not after.
3816 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3817 instead of gnutls_record_check_pending.
3818
3819 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3820
ff4de4aa
TZ
38212011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3822
3823 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3824 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3825 as passed in.
3826
abe95abb
JD
38272011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3828
3829 * xterm.c (x_set_frame_alpha): Do not set property on anything
3830 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3831
e16e55d4
JB
38322011-05-02 Juanma Barranquero <lekktu@gmail.com>
3833
3834 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3835
bafcf6a5
JB
38362011-05-02 Juanma Barranquero <lekktu@gmail.com>
3837
3838 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3839 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3840 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3841 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3842 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3843 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3844 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3845 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3846 (Qgnutls_bootprop_callbacks_verify): Make static.
3847
e7a6747f
AS
38482011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3849
19ed11ba
AS
3850 * callproc.c: Indentation fixup.
3851
e7a6747f 3852 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3853 (wait_for_termination, interruptible_wait_for_termination):
3854 Move after wait_for_termination_1.
e7a6747f 3855
1ef14cb4
LMI
38562011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3857
3858 * sysdep.c (interruptible_wait_for_termination): New function
3859 which is like wait_for_termination, but allows keyboard
3860 interruptions.
3861
3862 * callproc.c (Fcall_process): Add (:file "file") as an option for
3863 the STDOUT buffer.
3864 (Fcall_process_region): Ditto.
3865
330d880c
EZ
38662011-04-30 Eli Zaretskii <eliz@gnu.org>
3867
8db90b73
EZ
3868 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3869 rather than `XVECTOR (FOO)->size'.
3870
330d880c
EZ
3871 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3872 inttypes.h, as a gnulib replacement is used if it not available in
3873 system headers.
3874
15cbd324
EZ
38752011-04-21 Eli Zaretskii <eliz@gnu.org>
3876
3877 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3878 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3879 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3880
3881 * coding.c (coding_alloc_by_realloc): Error out if destination
3882 will grow beyond MOST_POSITIVE_FIXNUM.
3883 (decode_coding_emacs_mule): Abort if there isn't enough place in
3884 charbuf for the composition carryover bytes. Reserve an extra
3885 space for up to 2 characters produced in a loop.
3886 (decode_coding_iso_2022): Abort if there isn't enough place in
3887 charbuf for the composition carryover bytes.
3888
38892011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3890
ae940cca
EZ
3891 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3892 aborting when %lld or %lll format is passed.
3893 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3894 %llo or %llx format is passed. (Bug#8545)
3895
03ab8921
EZ
3896 * window.c (window_scroll_line_based): Use a marker instead of
3897 simple variables to record original value of point. (Bug#7952)
3898
afda1437
EZ
3899 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3900 produced by %s or %c overflows available buffer space. (Bug#8545)
3901
f76dee0c
PE
39022011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3903
3904 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3905 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3906
fdc5744d
JB
39072011-04-28 Juanma Barranquero <lekktu@gmail.com>
3908
3909 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3910
638f053a
JB
39112011-04-28 Juanma Barranquero <lekktu@gmail.com>
3912
3913 * keyboard.c (Qdelayed_warnings_hook): Define.
3914 (command_loop_1): Run `delayed-warnings-hook'
3915 if Vdelayed_warnings_list is non-nil.
3916 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3917 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3918
d178f871
EZ
39192011-04-28 Eli Zaretskii <eliz@gnu.org>
3920
3921 * doprnt.c (doprnt): Don't return value smaller than the buffer
3922 size if the message was truncated. (Bug#8545).
3923
b124fd93
JB
39242011-04-28 Juanma Barranquero <lekktu@gmail.com>
3925
3926 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3927 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3928
e810457d
PE
39292011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3930
3931 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3932
ea51cceb
JB
39332011-04-27 Juanma Barranquero <lekktu@gmail.com>
3934
3935 * makefile.w32-in: Update dependencies.
3936
94dcfacf
EZ
39372011-04-27 Eli Zaretskii <eliz@gnu.org>
3938
3939 Improve `doprnt' and its usage. (Bug#8545)
3940 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3941 `format_end'. Remove support for %l as a conversion specifier.
3942 Don't use xrealloc. Improve diagnostics when the %l size modifier
3943 is used. Update the commentary.
3944
3945 * eval.c (verror): Simplify calculation of size_t.
3946
3947 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3948 messages.
3949
f61f41d7
PE
39502011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3951
3952 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3953 change.
3954
96fb4434
PE
39552011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3956
3957 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3958 This makes this file independent of the recent pseudovector change.
3959
671875da 39602011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3961
69e9b5a3
PE
3962 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3963
b5f869a7 3964 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3965 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3966 Remove unused local.
c8926152 3967 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3968
841a1577 3969 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3970 GCC 4.6.0 optimizes based on type-based alias analysis.
3971 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3972 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3973 != &v->size, and therefore "v->size = 1; b->size = 2; return
3974 v->size;" must therefore return 1. This assumption is incorrect
3975 for Emacs, since it type-puns struct Lisp_Vector * with many other
3976 types. To fix this problem, this patch adds a new type struct
f904488f 3977 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3978 and pseudovectors, and helps optimizing compilers not get fooled
3979 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3980 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3981 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3982 the size member.
eab3844f
PE
3983 (XSETPVECTYPE): Rewrite in terms of new macro.
3984 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3985 This is a bit clearer, and further avoids the possibility of
3986 undesirable aliasing.
3987 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3988 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3989 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3990 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3991 (ASIZE): Now uses header.size rather than size.
3992 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3993 to avoid the hassle of writing XVECTOR (foo)->header.size.
3994 (struct vectorlike_header): New type.
eab3844f
PE
3995 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3996 object, to help avoid aliasing.
3997 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3998 (SUBRP): Likewise, since Lisp_Subr is a special case.
3999 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4000 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4001 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4002 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4003 changed to be "header.size" and "header.next".
4004 * buffer.h (struct buffer): Likewise.
4005 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4006 * frame.h (struct frame): Likewise.
4007 * process.h (struct Lisp_Process): Likewise.
4008 * termhooks.h (struct terminal): Likewise.
4009 * window.c (struct save_window_data, struct saved_window): Likewise.
4010 * window.h (struct window): Likewise.
4011 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4012 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4013 * buffer.c (init_buffer_once): Likewise.
4014 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4015 special case.
4016 * process.c (Fformat_network_address): Use local var for size,
4017 for brevity.
4018
0df1eac5
PE
4019 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4020
847ab9d1 4021 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4022 * data.c (atof): Remove decl; no longer used or needed.
4023 (digit_to_number): Move to lread.c.
4024 (Fstring_to_number): Use new string_to_number function, to be
4025 consistent with how the Lisp reader treats infinities and NaNs.
4026 Do not assume that floating-point numbers represent EMACS_INT
4027 without losing information; this is not true on most 64-bit hosts.
4028 Avoid double-rounding errors, by insisting on integers when
4029 parsing non-base-10 numbers, as the documentation specifies.
4030 * lisp.h (string_to_number): New decl, replacing ...
4031 (isfloat_string): Remove.
bc0a5c13 4032 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4033 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4034 appears to have been a coding error. Similarly, do not accept
4035 strings like +-1e0 as floating point numbers. Do not report
4036 overflow for integer overflows unless the base is not 10 which
4037 means we have no simple and reliable way to continue.
4038 Break out the floating-point parsing into a new
4039 function string_to_number, so that Fstring_to_number parses
4040 floating point numbers consistently with the Lisp reader.
04f2d78b 4041 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4042 (E_CHAR, EXP_INT): Remove, replacing with ...
4043 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4044 (string_to_number): New function, replacing isfloat_string.
4045 This function checks for valid syntax and produces the resulting
4046 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4047 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4048 so that overflow for non-base-10 numbers is reported only when
4049 there's no portable and simple way to convert to floating point.
452f4150 4050
67769ffc
PE
4051 * textprop.c (set_text_properties_1): Rewrite for clarity,
4052 and to avoid GCC warning about integer overflow.
4053
c20db43f
PE
4054 * intervals.h (struct interval): Use EMACS_INT for members
4055 where EMACS_UINT might cause problems. See
4056 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4057 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4058 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4059 All uses changed.
37aa2f85
PE
4060 (offset_intervals): Tell GCC not to worry about length overflow
4061 when negating a negative length.
c20db43f 4062
2538aa2f
PE
4063 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4064 (overrun_check_free): Likewise.
4065
f2d3008d
PE
4066 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4067 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4068 word size.
4069
ec8df744
PE
4070 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4071 (gnutls_make_error): Rename local to avoid shadowing.
4072 (gnutls_emacs_global_deinit): ifdef out; not used.
4073 (Fgnutls_boot): Use const for pointer to readonly storage.
4074 Comment out unused local. Fix pointer signedness problems.
4075
640ee02d
PE
4076 * lread.c (openp): Don't stuff size_t into an 'int'.
4077 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4078 about possible signed overflow.
4079
6048fb2a
PE
4080 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4081 (GDK_KEY_g): Don't define if already defined.
4082 (xg_prepare_tooltip): Avoid pointer signedness problem.
4083 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4084
fa3c87e1
PE
4085 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4086 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4087
2172544b
PE
4088 * xfns.c (Fx_window_property): Simplify a bit,
4089 to make a bit faster and to avoid GCC 4.6.0 warning.
4090 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4091
9b821a21
PE
4092 * fns.c (internal_equal): Don't assume size_t fits in int.
4093
3c616cfa
PE
4094 * alloc.c (compact_small_strings): Tighten assertion a little.
4095
c2982e87
PE
4096 Replace pEd with more-general pI, and fix some printf arg casts.
4097 * lisp.h (pI): New macro, generalizing old pEd macro to other
4098 conversion specifiers. For example, use "...%"pI"d..." rather
4099 than "...%"pEd"...".
4100 (pEd): Remove. All uses replaced with similar uses of pI.
4101 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4102 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4103 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4104 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4105 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4106 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4107 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4108 64-bit hosts.
4109 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4110 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4111 * print.c (safe_debug_print, print_object): Likewise.
4112 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4113 to int.
6f04d126
PE
4114 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4115 avoiding the 0 flag, which is not portable.
c2982e87
PE
4116 * process.c (Fmake_network_process): Use pI to avoid cast.
4117 * region-cache.c (pp_cache): Likewise.
4118 * xdisp.c (decode_mode_spec): Likewise.
4119 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4120 behavior on 64-bit hosts with printf arg.
6f04d126 4121 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4122 (x_stop_queuing_selection_requests): Likewise.
4123 (x_get_window_property): Don't truncate byte count to an 'int'
4124 when tracing.
0b432f21 4125
5e073ec7
PE
4126 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4127 here, since it parses constructs like leading '-' and spaces,
4128 which are not wanted; and it overflows with large numbers.
4129 Instead, simply match F[0-9]+, which is what is wanted anyway.
4130
36372bf9
PE
4131 * alloc.c: Remove unportable assumptions about struct layout.
4132 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4133 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4134 (allocate_vectorlike, make_pure_vector): Use the new macros,
4135 plus offsetof, to remove unportable assumptions about struct layout.
4136 These assumptions hold on all porting targets that I know of, but
4137 they are not guaranteed, they're easy to remove, and removing them
4138 makes further changes easier.
4139
0b432f21
PE
4140 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4141 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4142 (string_overrun_cookie): Now const. Use initializers that
4143 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4144 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4145 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4146 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4147 multiple of sizeof (EMACS_INT); it need not be, if
4148 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4149 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4150
895009e1
JB
41512011-04-26 Juanma Barranquero <lekktu@gmail.com>
4152
4153 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4154
6a7a1b0b
TZ
41552011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4156
4157 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4158 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4159 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4160
841a1577 41612011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4162
4163 * lisp.h (Qdebug): List symbol.
895009e1 4164 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4165 * keyboard.c (debug-on-event): New variable.
4166 (handle_user_signal): Break into debugger when debug-on-event
4167 matches the current signal symbol.
4168
f2d3ba6f
DN
41692011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4170
4171 * alloc.c (check_sblock, check_string_bytes)
4172 (check_string_free_list): Convert to standard C.
4173
42ce4c63
TZ
41742011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4175
4176 * w32.c (emacs_gnutls_push): Fix typo.
4177
825cd63c
EZ
41782011-04-25 Eli Zaretskii <eliz@gnu.org>
4179
fb11d64d
EZ
4180 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4181 "cast to pointer from integer of different size".
4182
825cd63c
EZ
4183 Improve doprnt and its use in verror. (Bug#8545)
4184 * doprnt.c (doprnt): Document the set of format control sequences
4185 supported by the function. Use SAFE_ALLOCA instead of always
4186 using `alloca'.
4187
4188 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4189 is one byte too soon. Don't use xrealloc; instead xfree and
4190 xmalloc anew.
4191
e061a11b
TZ
41922011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4193
4194 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4195 callbacks stage.
4196
4197 * gnutls.c: Renamed global_initialized to
4198 gnutls_global_initialized. Added internals for the
4199 :verify-hostname-error, :verify-error, and :verify-flags
4200 parameters of `gnutls-boot' and documented those parameters in the
4201 docstring. Start callback support.
9173deec
JB
4202 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4203 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4204 on error. Return error code.
e061a11b
TZ
4205 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4206 (emacs_gnutls_read): Likewise.
4207 (Fgnutls_boot): Return handshake error code.
4208 (emacs_gnutls_handle_error): New function.
4209 (wsaerror_to_errno): Likewise.
4210
4211 * w32.h (emacs_gnutls_pull): Add prototype.
4212 (emacs_gnutls_push): Likewise.
4213
4214 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4215 (emacs_gnutls_push): Likewise.
4216
42172011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4218
4219 * process.c (wait_reading_process_output): Check if GnuTLS
4220 buffered some data internally if no FDs are set for TLS
4221 connections.
4222
4223 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4224 (LIBS): Link to USER_LIBS.
4225 ($(BLD)/gnutls.$(0)): New target.
4226
fa6996bc
EZ
42272011-04-24 Eli Zaretskii <eliz@gnu.org>
4228
eb35682e
EZ
4229 * xdisp.c (handle_single_display_spec): Rename the
4230 display_replaced_before_p argument into display_replaced_p, to
4231 make it consistent with the commentary. Fix typos in the
4232 commentary.
4233
e2ad650c
EZ
4234 * textprop.c (syms_of_textprop): Remove dead code.
4235 (copy_text_properties): Delete obsolete commentary about an
4236 interface that was deleted long ago. Fix typos in the description
4237 of arguments.
4238
1b2de274
EZ
4239 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4240 to changes in oldXMenu/XMenu.h from 2011-04-16.
4241 <menu_help_message, prev_menu_help_message>: Constify.
4242 (IT_menu_make_room): menu->help_text is now `const char **';
4243 adjust.
4244
4245 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4246 to changes in oldXMenu/XMenu.h from 2011-04-16.
4247 (struct XMenu): Declare `help_text' `const char **'.
4248
4249 * xfaces.c <Qunspecified>: Make extern again.
4250
4251 * syntax.c: Include sys/types.h before including regex.h, as
4252 required by Posix.
4253
762b15be
EZ
4254 * doc.c (get_doc_string): Improve the format passed to `error'.
4255
4256 * doprnt.c (doprnt): Improve commentary.
4257
4258 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4259
4260 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4261 them with etags.
4262
f1052e5d
EZ
4263 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4264 changes in globals.h immediately force recompilation.
762b15be
EZ
4265 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4266 $(CURDIR)/s/ms-w32.h.
4267 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4268
fa6996bc
EZ
4269 * character.c (Fchar_direction): Function deleted.
4270 (syms_of_character): Don't defsubr it.
4271 <char-direction-table>: Deleted.
4272
e6c3da20
EZ
42732011-04-23 Eli Zaretskii <eliz@gnu.org>
4274
4275 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4276 * doprnt.c: Include limits.h.
4277 (SIZE_MAX): New macro.
04f2d78b
CB
4278 (doprnt): Return a size_t value. 2nd arg is now size_t.
4279 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4280 Improve overflow protection. Support `l' modifier for integer
4281 conversions. Support %l conversion. Don't assume an EMACS_INT
4282 argument for integer conversions and for %c.
4283
4284 * lisp.h (doprnt): Restore prototype.
4285
4286 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4287 $(SRC)/character.h.
4288
4289 * Makefile.in (base_obj): Add back doprnt.o.
4290
4291 * deps.mk (doprnt.o): Add back prerequisites.
4292 (callint.o): Depend on character.h.
4293
4294 * eval.c (internal_lisp_condition_case): Include the handler
4295 representation in the error message.
4296 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4297 when breaking from the loop.
4298
4299 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4300
4301 * callint.c (Fcall_interactively): When displaying error message
4302 about invalid control letter, pass the character's codepoint, not
4303 a pointer to its multibyte form. Improve display of the character
4304 in octal and display also its hex code.
4305
4306 * character.c (char_string): Use %x to display the (unsigned)
4307 codepoint of an invalid character, to avoid displaying a bogus
4308 negative value.
4309
4310 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4311 `error', not SYMBOL_NAME itself.
4312
4313 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4314 character arguments to `error'.
4315
4316 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4317 to `error' in error message about FINAL_CHAR argument. Make sure
4318 FINAL_CHAR is a character, and use %c when it is passed as
4319 argument to `error'.
4320
4ffd0d6b 43212011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4322
4323 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4324
4325 * w32.c: Include <time.h>.
4326 (sys_localtime): New function.
4327
4ffd0d6b 43282011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4329
4330 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4331
4ffd0d6b 4332 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4333
4ffd0d6b 43342011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4335
4ffd0d6b
GM
4336 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4337 zombies (Bug#8467).
aac0c6e3 4338
04c56954
EZ
43392011-04-19 Eli Zaretskii <eliz@gnu.org>
4340
4341 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4342 gl_state.e_property when gl_state.object is Qt.
4343
4344 * insdel.c (make_gap_larger): Remove limitation of buffer size
4345 to <= INT_MAX.
4346
16a43933
CY
43472011-04-18 Chong Yidong <cyd@stupidchicken.com>
4348
4349 * xdisp.c (lookup_glyphless_char_display)
4350 (produce_glyphless_glyph): Handle cons cell entry in
4351 glyphless-char-display.
4352 (Vglyphless_char_display): Document it.
4353
4354 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4355 glyphless-char-display.
4356
4581706e
CY
43572011-04-17 Chong Yidong <cyd@stupidchicken.com>
4358
4359 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4360
4361 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4362
4363 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4364 definition for no-X builds.
4365
4887c6e2 43662011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4367
fd35b6f9
PE
4368 Static checks with GCC 4.6.0 and non-default toolkits.
4369
5c1ccb01
PE
4370 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4371
006c5daa
PE
4372 * process.c (keyboard_bit_set): Define only if SIGIO.
4373 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4374 (send_process): Repair possible setjmp clobbering.
4375
efc736d3
PE
4376 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4377
4e2fe2e6
PE
4378 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4379
f97334a2
PE
4380 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4381
4e75f29d
PE
4382 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4383 Define only if needed.
4384
90efadd1
PE
4385 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4386 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4387 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4388
3c647824
PE
4389 * dispextern.h (struct redisplay_interface): Rename param
4390 to avoid shadowing.
e264f262 4391 * termhooks.h (struct terminal): Likewise.
761383f4 4392 * xterm.c (xembed_send_message): Likewise.
3c647824 4393
b58c5c4a
PE
4394 * insdel.c (make_gap_smaller): Define only if
4395 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4396
cad59032
PE
4397 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4398 it.
4399
c339dc2e
PE
4400 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4401 so that we aren't warned about unused symbols.
4402
91a3e27b
PE
4403 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4404
399c71d3 4405 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4406
8ffc96f5
PE
4407 * xfns.c (x_real_positions): Mark locals as initialized.
4408
eef9bc79
PE
4409 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4410
098db9dd
PE
4411 * xterm.c: Fix problems found by static analysis with other toolkits.
4412 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4413 (x_dispatch_event): Declare static if USE_GTK, and
4414 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4415 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4416 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4417 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4418 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4419
eb18f6cc
PE
4420 * xmenu.c (menu_help_callback): Pointer type fixes.
4421 Use const pointers when pointing at readonly data. Avoid pointer
4422 signedness clashes.
4423 (FALSE): Remove unused macro.
4424 (update_frame_menubar): Remove unused decl.
4425
1fe72bf8
PE
4426 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4427
60d9e1db
PE
4428 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4429 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4430 (single_menu_item): Rename local to avoid shadowing.
4431
39261c26
PE
4432 * keyboard.c (make_lispy_event): Remove unused local var.
4433
018c5e19
PE
4434 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4435 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4436
63d2b86e
PE
4437 * bitmaps: Change bitmaps from unsigned char back to the X11
4438 compatible char. Avoid the old compiler warnings about
4439 out-of-range initializers by using, for example, '\xab' rather
4440 than 0xab.
4441
aefd87e1
PE
4442 * xgselect.c (xgselect_initialize): Check vs interface
4443 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4444
bf501fb9
PE
4445 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4446
e9829fdf
PE
4447 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4448 to read-only memory.
4449
1086c095
PE
4450 * fns.c (vector): Remove; this old hack is no longer needed.
4451
2baccd04 4452 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4453 Remove unused var.
dde42981 4454 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4455
72391843 4456 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4457
436c16df 4458 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4459 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4460 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4461
92bb796d 4462 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4463 (x_term_init): Remove local to avoid shadowing.
92bb796d 4464
764430a3 4465 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4466
4467 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4468 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4469
d1dfb56c
EZ
44702011-04-16 Eli Zaretskii <eliz@gnu.org>
4471
c4354cb4
EZ
4472 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4473
d1dfb56c
EZ
4474 Fix regex.c, syntax.c and friends for buffers > 2GB.
4475 * syntax.h (struct gl_state_s): Declare character position members
4476 EMACS_INT.
4477
4478 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4479
04f2d78b
CB
4480 * textprop.c (verify_interval_modification, interval_of):
4481 Declare arguments EMACS_INT.
d1dfb56c
EZ
4482
4483 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4484 EMACS_INT.
4485
4486 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4487
4488 * indent.c (Fvertical_motion): Local variable it_start is now
4489 EMACS_INT.
4490
4491 * regex.c (re_match, re_match_2, re_match_2_internal)
4492 (bcmp_translate, regcomp, regexec, print_double_string)
4493 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4494 (re_compile_pattern, re_exec): Declare arguments and local
4495 variables `size_t' and `ssize_t' and return values `regoff_t', as
4496 appropriate.
4497 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4498 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4499 <compile_stack_type>: `size' and `avail' are now `size_t'.
4500
4501 * regex.h <regoff_t>: Use ssize_t, not int.
4502 (re_search, re_search_2, re_match, re_match_2): Arguments that
4503 specify buffer/string position and length are now ssize_t and
4504 size_t. Return type is regoff_t.
4505
613052cd
BK
45062011-04-16 Ben Key <bkey76@gmail.com>
4507
4508 * nsfont.m: Fixed bugs in ns_get_family and
4509 ns_descriptor_to_entity that were caused by using free to
4510 deallocate memory blocks that were allocated by xmalloc (via
4511 xstrdup). This caused Emacs to crash when compiled with
4512 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4513 --enable-checking=xmallocoverrun). xfree is now used to
4514 deallocate these memory blocks.
4515
4170f62f 45162011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4517
71b41406
PE
4518 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4519
9587a89d
PE
4520 emacs_write: Accept and return EMACS_INT for sizes.
4521 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4522 et seq.
4523 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4524 Accept and return EMACS_INT.
4525 (emacs_gnutls_write): Return the number of bytes written on
4526 partial writes.
4527 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4528 (emacs_read, emacs_write): Remove check for negative size, as the
4529 Emacs source code has been audited now.
9587a89d
PE
4530 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4531 (emacs_read, emacs_write): Use it.
273a5f82
PE
4532 * process.c (send_process): Adjust to the new signatures of
4533 emacs_write and emacs_gnutls_write. Do not attempt to store
4534 a byte offset into an 'int'; it might overflow.
9587a89d 4535 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4536
3e047f51
PE
4537 * sound.c: Don't assume sizes fit in 'int'.
4538 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4539 Return EMACS_INT, not int.
3e047f51 4540 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4541 Accept EMACS_INT, not int.
4542 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4543 record read return values.
4544
cc39a9db
BK
45452011-04-15 Ben Key <bkey76@gmail.com>
4546
c9d0ec6d
JB
4547 * keyboard.c (Qundefined): Don't declare static since it is used
4548 in nsfns.m.
4549 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4550 static since they are used in nsfont.m.
cc39a9db 4551
6c60eb9f
SM
45522011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4553
4554 * process.c (Qprocessp): Don't declare static.
4555 * lisp.h (Qprocessp): Declare again.
4556
7990b61a
JB
45572011-04-15 Juanma Barranquero <lekktu@gmail.com>
4558
4559 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4560
5d4cb038
PE
45612011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4562
8bd7b830 4563 Improve C-level modularity by making more things 'static'.
cd64ea1d 4564
e3b27b31
PE
4565 Don't publish debugger-only interfaces to other modules.
4566 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4567 (verify_bytepos, count_markers): Move decls to the only modules
4568 that need them.
4569 * region-cache.h (pp_cache): Likewise.
4570 * window.h (check_all_windows): Likewise.
4571 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4572
5d4cb038
PE
4573 * sysdep.c (croak): Now static, if
4574 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4575 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4576
4577 * alloc.c (refill_memory_reserve): Now static if
4578 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4579 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4580
e87b6180
PE
4581 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4582 Define only if USE_LUCID.
4583
ac64929e
PE
4584 * xrdb.c (x_customization_string, x_rm_string): Now static.
4585
6f37259d
PE
4586 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4587 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4588
1683e3ab
PE
4589 * xdisp.c (draw_row_with_mouse_face): Now static.
4590 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4591
de9c2632
PE
4592 * window.h (check_all_windows): Mark externally visible.
4593
2b96acb7
PE
4594 * window.c (window_deletion_count): Now static.
4595
4596 * undo.c: Make symbols static if they're not exported.
4597 (last_undo_buffer, last_boundary_position, pending_boundary):
4598 Now static.
4599
50436f33
PE
4600 * textprop.c (interval_insert_behind_hooks): Now static.
4601 (interval_insert_in_front_hooks): Likewise.
4602
64520e5c
PE
4603 * term.c: Make symbols static if they're not exported.
4604 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4605 (max_frame_lines, tty_set_terminal_modes):
4606 (tty_reset_terminal_modes, tty_turn_off_highlight):
4607 (get_tty_terminal): Now static.
4608 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4609 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4610 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4611 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4612 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4613
1fa53021
PE
4614 * sysdep.c: Make symbols static if they're not exported.
4615 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4616 Now static.
4617 (sigprocmask_set, full_mask): Remove; unused.
4618 (wait_debugging): Mark as visible.
4619 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4620 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4621
d4b43b22
PE
4622 * syntax.c (syntax_temp): Define only if !__GNUC__.
4623
b7c513d0
PE
4624 * sound.c (current_sound_device, current_sound): Now static.
4625
989b29ad
PE
4626 * search.c (searchbufs, searchbuf_head): Now static.
4627
13a55a78
PE
4628 * scroll.c (scroll_cost): Remove; unused.
4629 * dispextern.h (scroll_cost): Remove decl.
4630
de68a1fc
PE
4631 * region-cache.h (pp_cache): Mark as externally visible.
4632
40ccffa6
PE
4633 * process.c: Make symbols static if they're not exported.
4634 (process_tick, update_tick, create_process, chan_process):
4635 (Vprocess_alist, proc_buffered_char, datagram_access):
4636 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4637 (deactivate_process): Mark defn as static, as well as decl.
4638 * lisp.h (create_process): Remove decl.
4639 * process.h (chan_process, Vprocess_alist): Remove decls.
4640
ad64fc97
PE
4641 * print.c: Make symbols static if they're not exported.
4642 (print_depth, new_backquote_output, being_printed, print_buffer):
4643 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4644 (print_interval, print_number_index, initial_stderr_stream):
4645 Now static.
4646 * lisp.h (Fprinc): Remove decl.
4647 (debug_output_compilation_hack): Mark as externally visible.
4648
adddb265
PE
4649 * sysdep.c (croak): Move decl from here to syssignal.h.
4650 * syssignal.h (croak): Put it here, so the API can be checked when
4651 'croak' is called from dissociate_if_controlling_tty.
4652
1717ede2
PE
4653 * minibuf.c: Make symbols static if they're not exported.
4654 (minibuf_save_list, choose_minibuf_frame): Now static.
4655 * lisp.h (choose_minibuf_frame): Remove decl.
4656
fa5fb2bc
PE
4657 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4658
1e3890d1
PE
4659 * lread.c: Make symbols static if they're not exported.
4660 (read_objects, initial_obarray, oblookup_last_bucket_number):
4661 Now static.
4662 (make_symbol): Remove; unused.
4663 * lisp.h (initial_obarray, make_symbol): Remove decls.
4664
8a1414fa
PE
4665 * keyboard.c: Make symbols static if they're not exported.
4666 (single_kboard, recent_keys_index, total_keys, recent_keys):
4667 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4668 (this_single_command_key_start, echoing, last_auto_save):
4669 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4670 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4671 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4672 (Vlispy_mouse_stem, double_click_count):
4673 Now static.
4674 (force_auto_save_soon): Define only if SIGDANGER.
4675 (ignore_mouse_drag_p): Now static if
4676 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4677 (print_help): Remove; unused.
4678 (stop_character, last_timer_event): Mark as externally visible.
4679 * keyboard.h (ignore_mouse_drag_p): Declare only if
4680 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4681 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4682 * lisp.h (echoing): Remove decl.
4683 (force_auto_save_soon): Declare only if SIGDANGER.
4684 * xdisp.c (redisplay_window): Simplify code, to make it more
4685 obvious that ignore_mouse_drag_p is not accessed if !defined
4686 USE_GTK && !defined HAVE_NS.
4687
93ea6e8f
PE
4688 * intervals.c: Make symbols static if they're not exported.
4689 (merge_properties_sticky, merge_interval_right, delete_interval):
4690 Now static.
4691 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4692
77382fcc
PE
4693 * insdel.c: Make symbols static if they're not exported.
4694 However, leave prepare_to_modify_buffer alone. It's never
4695 called from outside this function, but that appears to be a bug.
4696 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4697 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4698 (adjust_after_replace_noundo): Remove; unused.
4699 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4700 (signal_before_change): Remove decls.
77382fcc 4701
9306c32e
PE
4702 * indent.c (val_compute_motion, val_vmotion): Now static.
4703
cd44d2eb
PE
4704 * image.c: Make symbols static if they're not exported.
4705 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4706 if USE_GTK.
4707 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4708 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4709
ad9a7a06
PE
4710 * fringe.c (standard_bitmaps): Now static.
4711 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4712
81626931
PE
4713 * frame.c: Make symbols static if they're not exported.
4714 (x_report_frame_params, make_terminal_frame): Now static.
4715 (get_frame_param): Now static, unless HAVE_NS.
4716 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4717 (x_get_resource_string): Remove; not used.
4718 * frame.h (make_terminal_frame, x_report_frame_params):
4719 (x_get_resource_string); Remove decls.
4720 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4721 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4722
239f9db9
PE
4723 * font.c, fontset.c: Make symbols static if they're not exported.
4724 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4725 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4726 * font.c (font_close_object): Now static.
4727 * font.h (font_close_object): Remove.
4728 * fontset.c (FONTSET_OBJLIST): Remove.
4729 (free_realized_fontset) #if-0 the body, which does nothing.
4730 (face_suitable_for_char_p): #if-0, as it's never called.
4731 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4732 * xfaces.c (face_at_string_position):
4733 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4734 since 0 is always ASCII.
4735
dfcf3579
PE
4736 * fns.c (weak_hash_tables): Now static.
4737
5045092b
PE
4738 * fileio.c: Make symbols static if they're not exported.
4739 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4740 (Vwrite_region_annotation_buffers): Now static.
4741
57a96f5c
PE
4742 * eval.c: Make symbols static if they're not exported.
4743 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4744 * lisp.h (backtrace_list): Remove decl.
4745
35f08c38
PE
4746 * emacs.c: Make symbols static if they're not exported.
4747 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4748 (fatal_error_code, fatal_error_signal_hook, standard_args):
4749 Now static.
4750 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4751 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4752 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4753 * lisp.h (fatal_error_signal_hook): Remove decl.
4754 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4755
f44bd759
PE
4756 * editfns.c: Move a (normally-unused) function to its only use.
4757 * editfns.c, lisp.h (get_operating_system_release): Remove.
4758 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4759 worth the hassle of breaking this out.
4760
b532497d
PE
4761 * xterm.c: Make symbols static if they're not exported.
4762 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4763 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4764 (x_destroy_window, x_delete_display):
4765 Now static.
4766 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4767 (x_mouse_leave): Remove; unused.
4768 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4769 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4770 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4771 Remove decls.
4772 (x_mouse_leave): Declare only if WINDOWSNT.
4773 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4774 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4775 USE_X_TOOLKIT.
4776
1675728f
PE
4777 * ftxfont.c: Make symbols static if they're not exported.
4778 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4779 HAVE_FREETYPE.
4780 * font.h (ftxfont_driver): Likewise.
4781
e4cebfca
PE
4782 * xfns.c: Make symbols static if they're not exported.
4783 (x_last_font_name, x_display_info_for_name):
4784 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4785 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4786 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4787 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4788 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4789 (last_show_tip_args): Now static.
4790 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4791 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4792 (x_screen_planes): Remove; unused.
4793 * dispextern.h (x_screen_planes): Remove decl.
4794
5bf46f05
PE
4795 * dispnew.c: Make symbols static if they're not exported.
4796 * dispextern.h (redraw_garbaged_frames, scrolling):
4797 (increment_row_positions): Remove.
4798 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4799 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4800 Now static.
4801 (redraw_garbaged_frames): Remove; unused.
4802
435f4c28
PE
4803 * xfaces.c: Make symbols static if they're not exported.
4804 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4805 Remove decls.
4806 * xterm.h (defined_color): Remove decls.
4807 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4808 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4809 (menu_face_changed_default, defined_color, free_realized_face):
4810 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4811 (ascii_face_of_lisp_face): Remove; unused.
4812
8524aef3
PE
4813 * xdisp.c: Make symbols static if they're not exported.
4814 * dispextern.h (scratch_glyph_row, window_box_edges):
4815 (glyph_to_pixel_coords, set_cursor_from_row):
4816 (get_next_display_element, set_iterator_to_next):
4817 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4818 (show_mouse_face): Remove decls
4819 * frame.h (message_buf_print): Likewise.
4820 * lisp.h (pop_message, set_message, check_point_in_composition):
4821 Likewise.
4822 * xterm.h (set_vertical_scroll_bar): Likewise.
4823 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4824 (message_buf_print, scratch_glyph_row, displayed_buffer):
4825 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4826 (get_next_display_element, show_mouse_face, window_box_edges):
4827 (frame_to_window_pixel_xy, check_point_in_composition):
4828 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4829 (glyph_to_pixel_coords): Remove; unused.
4830
16390cd2
PE
4831 * dired.c (file_name_completion): Now static.
4832
4833 * dbusbind.c (xd_in_read_queued_messages): Now static.
4834
a25f4dfa
PE
4835 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4836 * data.c (circular_list_error): Remove.
4837
14a9c8df
PE
4838 * commands.h (last_point_position, last_point_position_buffer):
4839 (last_point_position_window): Remove decls.
4840 * keyboard.c: Make these variables static.
4841
04f2d78b
CB
4842 * coding.h (coding, code_convert_region, encode_coding_gap):
4843 Remove decls.
74ab6df5
PE
4844 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4845 (iso_code_class, detect_coding, code_convert_region): Now static.
4846 (encode_coding_gap): Remove; unused.
4847
38dfbee1
PE
4848 * chartab.c (chartab_chars, chartab_bits): Now static.
4849
a2cb4e63
PE
4850 * charset.h (charset_iso_8859_1): Remove decl.
4851 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4852 Now static.
4853
127198fd
PE
4854 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4855 * ccl.c (Vccl_program_table): Now static.
4856 (check_ccl_update): Remove; unused.
4857
d85b608f
PE
4858 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4859 * category.h: ... from here.
4860 * category.c (check_category_table, set_category_set): Now static.
4861
31cd66f3
PE
4862 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4863 * lisp.h: Remove these decls.
4864
c358e587
PE
4865 * buffer.c (buffer_count): Remove unused var.
4866
e78aecca
PE
4867 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4868 so that it's not optimized away.
4869 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4870 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4871 exported only to the debugger.
4872
e192d7d3 4873 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4874 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4875
92470028
PE
4876 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4877 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4878 was inaccessible from Lisp.
4879 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4880 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4881
244ed907
PE
4882 alloc.c: Import and export fewer symbols, and remove unused items.
4883 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4884 is defined.
4885 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4886 it's not optimized away by whole-program optimization.
4887 (message_enable_multibyte, free_misc): Remove.
4888 (catchlist, handlerlist, mark_backtrace):
4889 Declare only if BYTE_MARK_STACK.
4890 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4891 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4892 (message_enable_multibyte): Remove decl.
4893 (free_misc, interval_free_list, float_block, float_block_index):
4894 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4895 (cons_free_list, last_marked_index):
4896 Now static.
4897 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4898 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4899 (mark_backtrace): Define only if BYTE_MARK_STACK.
4900 * xdisp.c (message_enable_multibyte): Now static.
4901
61c2b50e 4902 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4903 This makes it easier for human readers (and static analyzers)
4904 to see whether these variables are used from other modules.
4905 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4906 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4907 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4908 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4909 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4910 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4911 * xmenu.c, xselect.c:
4912 Declare Q* vars static if they are not used in other modules.
4913 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4914 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4915 Remove decls of unexported vars.
4916 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4917
95c82688
PE
4918 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4919
16a97296
PE
4920 Make Emacs functions such as Fatom 'static' by default.
4921 This makes it easier for human readers (and static analyzers)
4922 to see whether these functions can be called from other modules.
4923 DEFUN now defines a static function. To make the function external
4924 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4925 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4926 (Finit_image_library):
16a97296
PE
4927 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4928 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4929 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4930 Remove decls, since these functions are now static.
4931 (Funintern, Fget_internal_run_time): New decls, since these functions
4932 were already external.
95c82688 4933
16a97296
PE
4934 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4935 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4936 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4937 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4938 * keyboard.c, keymap.c, lread.c:
4939 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4940 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4941 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4942 Mark functions with DEFUE instead of DEFUN,
4943 if they are used in other modules.
4944 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4945 decls for now-static functions.
4946 * buffer.h (Fdelete_overlay): Remove decl.
4947 * callproc.c (Fgetenv_internal): Mark as internal.
4948 * composite.c (Fremove_list_of_text_properties): Remove decl.
4949 (Fcomposition_get_gstring): New forward static decl.
4950 * composite.h (Fcomposite_get_gstring): Remove decl.
4951 * dired.c (Ffile_attributes): New forward static decl.
4952 * doc.c (Fdocumntation_property): New forward static decl.
4953 * eval.c (Ffetch_bytecode): New forward static decl.
4954 (Funintern): Remove extern decl; now in .h file where it belongs.
4955 * fileio.c (Fmake_symbolic_link): New forward static decl.
4956 * image.c (Finit_image_library): New forward static decl.
4957 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4958 * intervals.h (Fprevious_property_change):
4959 (Fremove_list_of_text_properties): Remove decls.
4960 * keyboard.c (Fthis_command_keys): Remove decl.
4961 (Fcommand_execute): New forward static decl.
4962 * keymap.c (Flookup_key): New forward static decl.
4963 (Fcopy_keymap): Now static.
4964 * keymap.h (Flookup_key): Remove decl.
4965 * process.c (Fget_process): New forward static decl.
4966 (Fprocess_datagram_address): Mark as internal.
4967 * syntax.c (Fsyntax_table_p): New forward static decl.
4968 (skip_chars): Remove duplicate decl.
4969 * textprop.c (Fprevious_property_change): New forward static decl.
4970 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4971 Now internal.
4972 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4973 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4974
785bbd42
PE
4975 * editfns.c (Fformat): Remove unreachable code.
4976
8b913b57
AS
49772011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4978
4979 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4980 change. (Bug#8496)
4981
a6744a35
EZ
49822011-04-13 Eli Zaretskii <eliz@gnu.org>
4983
4984 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4985 when at ZV. (Bug#8487)
4986
e7974947
AS
49872011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4988
baad03f0
AS
4989 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4990 (Bug#8437)
4991 * keyboard.c (parse_tool_bar_item): Likewise.
4992 * sound.c (sound_cleanup, alsa_close): Likewise.
4993 * termcap.c (tgetent): Likewise.
4994 * xfns.c (x_default_font_parameter): Likewise.
4995 * xsettings.c (read_and_apply_settings): Likewise.
4996
e7974947
AS
4997 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4998 (overrun_check_free): Protoize.
4999
28272684
PE
50002011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5001
5002 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5003 since callers should never pass a negative size.
5004 Change the signature to match that of plain 'read' and 'write'; see
5005 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5006 * lisp.h: Update prototypes of emacs_write and emacs_read.
5007
11997c76
EZ
50082011-04-11 Eli Zaretskii <eliz@gnu.org>
5009
5010 * xdisp.c (redisplay_window): Don't try to determine the character
5011 position of the scroll margin if the window start point w->startp
e896f03c 5012 is outside the buffer's accessible region. (Bug#8468)
11997c76 5013
8a2cbd72
EZ
50142011-04-10 Eli Zaretskii <eliz@gnu.org>
5015
5016 Fix write-region and its subroutines for buffers > 2GB.
5017 * fileio.c (a_write, e_write): Modify declaration of arguments and
5018 local variables to support buffers larger than 2GB.
5019 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5020
5021 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5022 argument, local variables, and return value.
5023
5024 * lisp.h: Update prototypes of emacs_write and emacs_read.
5025
5026 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5027
4073e537 50282011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5029
1ebfdcb6
PE
5030 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5031
b2ded58d
PE
5032 Fix more problems found by GCC 4.6.0's static checks.
5033
7d66342c
PE
5034 * xdisp.c (vmessage): Use a better test for character truncation.
5035
bbf47d44
PE
5036 * charset.c (load_charset_map): <, not <=, for optimization,
5037 and to avoid potential problems with integer overflow.
9248994d 5038 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5039 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5040 * editfns.c (Fformat): Likewise.
1e69125e 5041 * syntax.c (skip_chars): Likewise.
3befa583 5042
e3019616
PE
5043 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5044 This also lets GCC 4.6.0 generate slightly better loop code.
5045
becfa255
PE
5046 * callint.c (Fcall_interactively): <, not <=, for optimization.
5047 (Fcall_interactively): Count the number of arguments produced,
5048 not the number of arguments given. This is simpler and lets GCC
5049 4.6.0 generate slightly better code.
5050
dae0cd48
PE
5051 * ftfont.c: Distingish more carefully between FcChar8 and char.
5052 The previous code passed unsigned char * to a functions like
5053 strlen and xstrcasecmp that expect char *, which does not
5054 conform to the C standard.
5055 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5056 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5057 char * when the C standard requires it.
5058
76032d70
PE
5059 * keyboard.c (read_char): Remove unused var.
5060
eb3f1cc8
PE
5061 * eval.c: Port to Windows vsnprintf (Bug#8435).
5062 Include <limits.h>.
5063 (SIZE_MAX): Define if the headers do not.
5064 (verror): Do not give up if vsnprintf returns a negative count.
5065 Instead, grow the buffer. This ports to Windows vsnprintf, which
5066 does not conform to C99. Problem reported by Eli Zaretskii.
5067 Also, simplify the allocation scheme, by avoiding the need for
5068 calling realloc, and removing the ALLOCATED variable.
5069
70476b54
PE
5070 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5071
12020a9e
PE
5072 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5073 But keep the doprint source code for now, as we might revamp it
5074 and use it again (Bug#8435).
ea6c7ae6
PE
5075 * lisp.h (doprnt): Remove.
5076 * Makefile.in (base_obj): Remove doprnt.o.
5077 * deps.mk (doprnt.o): Remove.
5078
5fdb398c
PE
5079 error: Print 32- and 64-bit integers portably (Bug#8435).
5080 Without this change, on typical 64-bit hosts error ("...%d...", N)
5081 was used to print both 32- and 64-bit integers N, which relied on
5082 undefined behavior.
5083 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5084 New macro.
5085 * lisp.h (error, verror): Mark as printf-like functions.
5086 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5087 Report overflow in size calculations when allocating printf buffer.
5088 Do not truncate output string at its first null byte.
5089 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5090 Truncate the output at a character boundary, since vsnprintf does not
5091 do that.
5092 * charset.c (check_iso_charset_parameter): Convert internal
5093 character to string before calling 'error', since %c now has the
5094 printf meaning.
5095 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5096 overflow when computing char to be passed to 'error'. Do not
5097 pass Lisp_Object to 'error'; pass the integer instead.
5098 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5099 formatted with plain %d.
5100
b189fa66
PE
5101 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5102
bff87ef0
PE
5103 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5104
7e2cac20
PE
5105 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5106
ce4d90b5
PE
5107 * xterm.c (x_catch_errors): Remove duplicate declaration.
5108
266c9547
PE
5109 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5110
79c49ad2
PE
5111 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5112
368f4090
JM
51132011-04-10 Jim Meyering <meyering@redhat.com>
5114
5115 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5116 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5117 return ssize_t not "int", and use size_t as the buffer length.
5118 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5119 * gnutls.h: Update declarations.
5120 * process.c (read_process_output): Use ssize_t, to match.
5121 (send_process): Likewise.
5122
a32d4040
CY
51232011-04-09 Chong Yidong <cyd@stupidchicken.com>
5124
5125 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5126
8546720e 51272011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5128
04f2d78b
CB
5129 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5130 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5131
8546720e
GM
5132 * xterm.c (handle_one_xevent):
5133 * xmenu.c (create_and_show_popup_menu):
5134 * xselect.c (x_decline_selection_request)
5135 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5136
0a2f5c1a 51372011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5138
5139 Fix some uses of `int' instead of EMACS_INT.
5140 * search.c (string_match_1, fast_string_match)
5141 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5142 (scan_buffer, find_next_newline_no_quit)
5143 (find_before_next_newline, search_command, Freplace_match)
5144 (Fmatch_data): Make some `int' variables be EMACS_INT.
5145
5146 * xdisp.c (display_count_lines): 3rd argument and return value now
5147 EMACS_INT. All callers changed.
5148 (pint2hrstr): Last argument is now EMACS_INT.
5149
5150 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5151 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5152 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5153 (decode_coding_utf_16, decode_coding_emacs_mule)
5154 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5155 (decode_coding_ccl, decode_coding_charset)
5156 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5157 (decode_coding_iso_2022, decode_coding_emacs_mule)
5158 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5159 <char_offset, last_offset>: Declare EMACS_INT.
5160 (encode_coding_utf_8, encode_coding_utf_16)
5161 (encode_coding_emacs_mule, encode_invocation_designation)
5162 (encode_designation_at_bol, encode_coding_iso_2022)
5163 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5164 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5165 Declare EMACS_INT.
5166 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5167 (encode_invocation_designation): Last argument P_NCHARS is now
5168 EMACS_INT.
5169 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5170 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5171
5172 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5173 All users changed.
5174
5175 * ccl.c (Fccl_execute_on_string): Declare some variables
5176 EMACS_INT.
5177
8546720e 51782011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5179
5180 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5181
4e19a977
CS
51822011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5183
5184 * process.c (Fformat_network_address): Doc fix.
5185
87302331
R
51862011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5187
5188 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5189
cbb59342
CY
51902011-04-08 Chong Yidong <cyd@stupidchicken.com>
5191
5192 * keyboard.c (read_char): Call Lisp function help-form-show,
5193 instead of using internal_with_output_to_temp_buffer.
5194 (Qhelp_form_show): New var.
e0d38eeb 5195 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5196
5197 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5198
5199 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5200
e67a13ab
CY
52012011-04-06 Chong Yidong <cyd@stupidchicken.com>
5202
04f2d78b
CB
5203 * process.c (Flist_processes): Remove to Lisp.
5204 (list_processes_1): Delete.
e67a13ab 5205
973f782d
EZ
52062011-04-06 Eli Zaretskii <eliz@gnu.org>
5207
7c106b1e
EZ
5208 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5209
973f782d
EZ
5210 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5211
41cf7d1a 52122011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5213
ca23cc88
PE
5214 Fix more problems found by GCC 4.6.0's static checks.
5215
f390e2d5
PE
5216 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5217
42eea0d0
PE
5218 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5219
b69769da 5220 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5221
f9541e84
PE
5222 * xdisp.c (vmessage): Mark as a printf-like function.
5223
13841b55
PE
5224 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5225
c136c10f
PE
5226 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5227
5e2d4a30
PE
5228 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5229 printf-like functions.
5230 (tiff_load): Add casts to remove these marks before passing them
5231 to system-supplied API.
5232
583f48b9
PE
5233 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5234
b25d760e
PE
5235 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5236 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5237 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5238 directly, rather than having caller test rule sign. This avoids
5239 some unnecessary tests.
5240 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5241 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5242 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5243
bc7b6697 5244 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5245 (xfont_open): Avoid unnecessary tests.
bc7b6697 5246
27ccc379
PE
5247 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5248
dcd5c89a
PE
5249 * composite.h, composite.c (composition_gstring_put_cache):
5250 Use EMACS_INT, not int, for length.
5251
b13a45c6
PE
5252 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5253 breaking out part of COMPOSITION_DECODE_RULE.
5254 (COMPOSITION_DECODE_RULE): Use it.
5255 * composite.c (get_composition_id): Remove unused local vars,
5256 by using the new macro.
5257
1e792e4d
PE
5258 * textprop.c (set_text_properties_1): Change while to do-while,
5259 since the condition is always true at first.
5260
dc6c6455 5261 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5262 (interval_deletion_adjustment): Return unsigned value.
5263 All uses changed.
dc6c6455 5264
aba7731a
PE
5265 * process.c (list_processes_1, create_pty, read_process_output):
5266 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5267 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5268 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5269 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5270 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5271
fdfc4bf3
PE
5272 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5273
fca8fe46 5274 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5275 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5276
06a0259a 5277 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5278 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5279 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5280
e7b9e80f
PE
5281 * print.c (print_error_message): Avoid int overflow.
5282
56201685
PE
5283 * font.c (font_list_entities): Redo for clarity,
5284 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5285
78834453 5286 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5287 (font_score): Avoid potential overflow in diff calculation.
78834453 5288
0bc0b309 5289 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5290 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5291
e610eaca
PE
5292 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5293
b895abce
PE
5294 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5295 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5296 can always succeed if overflow has undefined behavior.
5297
1f1d9321 5298 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5299 (wordify): Omit three unnecessary tests.
1f1d9321 5300
c59478bc
PE
5301 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5302 All callers changed. This avoids the need for an unused var.
5303
79b73827
PE
5304 * casefiddle.c (casify_region): Remove var that is set but not used.
5305
a4db5dfe
PE
5306 * dired.c (file_name_completion): Remove var that is set but not used.
5307
43aae36e
PE
5308 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5309
2a47c44d 5310 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5311 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5312
a37c69bf
PE
5313 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5314 Check for integer overflow on size calculations.
5315
328ab8e7
PE
5316 * buffer.c (Fprevious_overlay_change): Remove var that is set
5317 but not used.
5318
e5a2a5cb
PE
5319 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5320 Remove vars that are set but not used.
8d84a6eb 5321 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5322 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5323
a60e5f68
PE
5324 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5325
f661cb61 5326 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5327 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5328
f0397f5a
PE
5329 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5330 that are set but not used.
5331
8664db06 5332 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5333 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5334
6abdaa4a
PE
5335 * xselect.c (x_get_local_selection, x_handle_property_notify):
5336 Remove vars that are set but not used.
5337
0ce7538d 5338 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5339 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5340
9ae848fc
PE
5341 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5342 Remove var that is set but not used.
0b918413
PE
5343 (scroll_bar_windows_size): Now size_t, not int.
5344 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5345 Check for overflow.
9ae848fc 5346
a5a62657
PE
5347 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5348 (map_tty_color) [!defined MSDOS]: Likewise.
5349
5c5cdd39
PE
5350 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5351
66ebf983
PE
5352 * coding.c: Remove vars that are set but not used.
5353 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5354 All callers changed.
5355 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5356 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5357 (decode_coding_charset): Remove vars that are set but not used.
5358
1be4d761
PE
5359 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5360 that is set but not used.
5361
47553fa8
PE
5362 * print.c (print_object): Remove var that is set but not used.
5363
1f7196bf 5364 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5365 The gnulib version avoids calling malloc in the usual case,
5366 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5367 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5368 * filelock.c (current_lock_owner): Likewise.
5369 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5370 * sysdep.c: Include allocator.h, careadlinkat.h.
5371 (emacs_no_realloc_allocator): New static constant.
5372 (emacs_readlink): New function.
fdb61804
PE
5373 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5374 ../lib/careadlinkat.h.
d1fdcab7 5375
f84c17c7
SM
53762011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5377
5378 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5379 first non-nil return value).
5380
ef3862ad
JD
53812011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5382
5383 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5384 if not defined (Bug#8403).
5385
376a7006
JB
53862011-04-02 Juanma Barranquero <lekktu@gmail.com>
5387
5388 * xdisp.c (display_count_lines): Remove parameter `start',
5389 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5390 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5391 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5392 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5393 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5394 and thereabouts. All callers changed.
5395 (get_per_char_metric): Remove parameter `f', unused since
5396 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5397
6ca3801d
JM
53982011-04-02 Jim Meyering <meyering@redhat.com>
5399
5400 do not dereference NULL upon failed strdup
5401 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5402 (ns_get_family): Likewise.
5403
d8e2b5ba
JB
54042011-04-02 Juanma Barranquero <lekktu@gmail.com>
5405
5406 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5407
8c74fcbd
JD
54082011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5409
5410 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5411 later (Bug#8403).
5412
7200d79c
SM
54132011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5414
03408648 5415 Add lexical binding.
7200d79c 5416
03408648
SM
5417 * window.c (Ftemp_output_buffer_show): New fun.
5418 (Fsave_window_excursion):
5419 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5420
5421 * lread.c (lisp_file_lexically_bound_p): New function.
5422 (Fload): Bind Qlexical_binding.
5423 (readevalloop): Remove `evalfun' arg.
5424 Bind Qinternal_interpreter_environment.
5425 (Feval_buffer): Bind Qlexical_binding.
5426 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5427 Mark as dynamic.
5428 (syms_of_lread): Declare `lexical-binding'.
5429
5430 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5431
5432 * keyboard.c (eval_dyn): New fun.
5433 (menu_item_eval_property): Use it.
ca105506
SM
5434
5435 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5436
03408648
SM
5437 * fns.c (concat, mapcar1): Accept byte-code-functions.
5438
5439 * eval.c (Fsetq): Handle lexical vars.
5440 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5441 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5442 (FletX, Flet): Obey lexical binding.
5443 (Fcommandp): Handle closures.
5444 (Feval): New `lexical' arg.
5445 (eval_sub): New function extracted from Feval. Use it almost
5446 everywhere where Feval was used. Look up vars in lexical env.
5447 Handle closures.
5448 (Ffunctionp): Move from subr.el.
5449 (Ffuncall): Handle closures.
5450 (apply_lambda): Remove `eval_flags'.
5451 (funcall_lambda): Handle closures and new byte-code-functions.
5452 (Fspecial_variable_p): New function.
5453 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5454 but without exporting it to Lisp.
23aba0ea 5455
23aba0ea 5456 * doc.c (Fdocumentation, store_function_docstring):
03408648 5457 * data.c (Finteractive_form): Handle closures.
23aba0ea 5458
03408648
SM
5459 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5460 interactive spec.
ba83908c 5461
04f2d78b
CB
5462 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5463 New byte-codes.
03408648
SM
5464 (exec_byte_code): New function extracted from Fbyte_code to handle new
5465 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5466
03408648 5467 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5468
03408648 5469 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5470
e2abce01
JB
54712011-03-31 Juanma Barranquero <lekktu@gmail.com>
5472
5473 * xdisp.c (redisplay_internal): Fix prototype.
5474
63696a73 54752011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5476
63696a73 5477 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5478 (try_scrolling): Use it when setting scroll_limit.
5479 Limit scrolling to 100 screen lines.
63696a73
EZ
5480 (redisplay_window): Even when falling back on "recentering",
5481 position point in the window according to scroll-conservatively,
5482 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5483
5484 (try_scrolling): When point is above the window, allow searching
5485 as far as scroll_max, or one screenful, to compute vertical
5486 distance from PT to the scroll margin position. This prevents
5487 try_scrolling from unnecessarily failing when
5488 scroll-conservatively is set to a value slightly larger than the
5489 window height. Clean up the case of PT below the margin at bottom
5490 of window: scroll_max can no longer be INT_MAX. When aggressive
5491 scrolling is in use, don't let point enter the opposite scroll
5492 margin as result of the scroll.
5493 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5494 threshold of 100 lines for never-recentering scrolling.
5495
e4cc2dfc
JB
54962011-03-31 Juanma Barranquero <lekktu@gmail.com>
5497
5498 * dispextern.h (move_it_by_lines):
5499 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5500 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5501 (message_log_check_duplicate): Remove parameters `prev_bol' and
5502 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5503 (redisplay_internal): Remove parameter `preserve_echo_area',
5504 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5505
5506 * indent.c (Fvertical_motion):
5507 * window.c (window_scroll_pixel_based, Frecenter):
5508 Don't pass `need_y_p' to `move_it_by_lines'.
5509
1c470562
SM
55102011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5511
44f230aa
SM
5512 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5513 steal a few bits to be more compact.
5514 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5515 Remove unneeded casts.
5516
1c470562
SM
5517 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5518
888adce9
ZK
55192011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5520
5521 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5522 binding" message (bug#7967).
5523
f838ed7b
PE
55242011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5525
77861b95
PE
5526 Fix more problems found by GCC 4.6.0's static checks.
5527
de6dbc14
PE
5528 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5529 Remove unused local var.
5530
f838ed7b
PE
5531 * editfns.c (Fmessage_box): Remove unused local var.
5532
792c7b2b
PE
5533 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5534 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5535 Omit unused local vars.
c499e557 5536 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5537 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5538 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5539 Omit unused local var.
5540
ba0165e1
PE
5541 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5542 Don't assume string length fits in int.
32ad8845 5543 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5544 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5545
3c59b4c9
PE
5546 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5547 instead of alloca (Bug#8344).
5548
a3eed478 5549 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5550 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5551
eb4d412d
PE
5552 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5553
1658b401
PE
5554 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5555 concerns.
5556
5557 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5558
5559 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5560
9a2c6e05
PE
5561 * keyboard.c (syms_of_keyboard): Use the same style as later
5562 in this function when indexing through an array. This also
5563 works around GCC bug 48267.
5564
03d0a109
PE
5565 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5566
44f730c8
PE
5567 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5568
fe75f926
PE
5569 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5570 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5571
ffa8c828
PE
5572 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5573 This avoids undefined behavior on integer overflow, and is a bit
5574 more convenient anyway since it is compared to a size_t variable.
5575
c5101a77
PE
5576 Variadic C functions now count arguments with size_t, not int.
5577 This avoids an unnecessary limitation on 64-bit machines, which
5578 caused (substring ...) to crash on large vectors (Bug#8344).
5579 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5580 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5581 All variadic functions and their callers changed accordingly.
c5101a77
PE
5582 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5583 * data.c (arith_driver, float_arith_driver): Likewise.
5584 * editfns.c (general_insert_function): Likewise.
5585 * eval.c (struct backtrace.nargs, interactive_p)
5586 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5587 (funcall_lambda, mark_backtrace): Likewise.
5588 * fns.c (concat): Likewise.
5589 * frame.c (x_set_frame_parameters): Likewise.
5590 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5591 0 if not found, not -1. All callers changed.
5592
dd3f25f7
PE
5593 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5594 (stack_copy_size): Now size_t, not int.
5595 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5596
461c2ab9
JB
55972011-03-28 Juanma Barranquero <lekktu@gmail.com>
5598
5599 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5600 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5601 All callers changed.
5602
5603 * lisp.h (multibyte_char_to_unibyte):
5604 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5605 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5606 * character.h (CHAR_TO_BYTE8):
5607 * cmds.c (internal_self_insert):
5608 * editfns.c (general_insert_function):
5609 * keymap.c (push_key_description):
5610 * search.c (Freplace_match):
5611 * xdisp.c (message_dolog, set_message_1): All callers changed.
5612
f6d62986
SM
56132011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5614
5615 * keyboard.c (safe_run_hook_funcall): New function.
5616 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5617 don't set the hook to nil, but remove the offending function instead.
5618 (Qcommand_hook_internal): Remove, unused.
5619 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5620 Vcommand_hook_internal.
5621
5622 * eval.c (enum run_hooks_condition): Remove.
5623 (funcall_nil, funcall_not): New functions.
5624 (run_hook_with_args): Call each function through a `funcall' argument.
5625 Remove `cond' argument, now redundant.
5626 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5627 (Frun_hook_with_args_until_failure): Adjust accordingly.
5628 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5629
1db5b1ad
JB
56302011-03-28 Juanma Barranquero <lekktu@gmail.com>
5631
5632 * dispextern.h (string_buffer_position): Remove declaration.
5633
5634 * print.c (strout): Remove parameter `multibyte', unused since
5635 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5636
5637 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5638 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5639 All callers changed.
5640
5641 * w32.c (_wsa_errlist): Use braces for struct initializers.
5642
5643 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5644 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5645 All callers changed.
5646 (string_buffer_position): Likewise. Also, make static (it's never
5647 used outside xdisp.c).
5648 (cursor_row_p): Remove parameter `w', unused since
5649 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5650 (decode_mode_spec): Remove parameter `precision', introduced during
5651 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5652 All callers changed.
5653
5ffb62aa
JD
56542011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5655
5656 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5657
461c2ab9 56582011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5659
5660 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5661 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5662 (ns_update_auto_hide_menu_bar): New functions.
5663 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5664 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5665 ns_constrain_all_frames.
5666 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5667 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5668
5c380ffb
JD
56692011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5670
5671 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5672
9af30bdf
GM
56732011-03-27 Glenn Morris <rgm@gnu.org>
5674
5675 * syssignal.h: Replace RETSIGTYPE with void.
5676 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5677 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5678 Replace SIGTYPE with void everywhere.
5679 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5680 * s/template.h (SIGTYPE): Remove commented out definition.
5681
e2abce01
JB
56822011-03-26 Eli Zaretskii <eliz@gnu.org>
5683
5684 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5685 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5686
f868cd8a
JB
56872011-03-26 Juanma Barranquero <lekktu@gmail.com>
5688
59eb0929
JB
5689 * w32.c (read_unc_volume): Use parameter `henum', instead of
5690 global variable `wget_enum_handle'.
5691
5692 * keymap.c (describe_vector): Remove parameters `indices' and
5693 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5694 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5695
f868cd8a
JB
5696 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5697
5698 * keyboard.c (timer_check): Remove parameter `do_it_now',
5699 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5700 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5701 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5702
5703 * keyboard.c (read_char):
5704 * w32menu.c (w32_menu_display_help):
5705 * xmenu.c (show_help_event, menu_help_callback):
5706 Adjust calls to `show_help_echo'.
5707
5708 * gtkutil.c (xg_maybe_add_timer):
5709 * keyboard.c (readable_events):
5710 * process.c (wait_reading_process_output):
5711 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5712
5713 * insdel.c (adjust_markers_gap_motion):
5714 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5715 (gap_left, gap_right): Don't call it.
5716
2ecf6fdb
CY
57172011-03-25 Chong Yidong <cyd@stupidchicken.com>
5718
5719 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5720 incurred during fontification.
5721
6b1f9ba4
JB
57222011-03-25 Juanma Barranquero <lekktu@gmail.com>
5723
5724 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5725 (DEFVAR_PER_BUFFER): Don't pass it.
5726
5727 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5728 (scrolling_window): Don't pass it.
5729
0f4a96b5
JB
57302011-03-25 Juanma Barranquero <lekktu@gmail.com>
5731
5732 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5733
5734 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5735 and `suffix'.
5736 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5737 of variables specific to SELinux and computation of `encoded_absname'.
5738
5739 * image.c (XPutPixel): Remove unused variable `height'.
5740
5741 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5742
5743 * unexw32.c (get_section_info): Remove unused variable `section'.
5744
5745 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5746 (system_process_attributes): Remove unused variable `sess'.
5747 (sys_read): Remove unused variable `err'.
5748
5749 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5750 (w32_wnd_proc): Remove unused variable `isdead'.
5751 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5752 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5753 (x_create_tip_frame): Remove unused variable `tem'.
5754
5755 * w32inevt.c (w32_console_read_socket):
5756 Remove unused variable `no_events'.
5757
5758 * w32term.c (x_draw_composite_glyph_string_foreground):
5759 Remove unused variable `width'.
5760
1149507c
JB
57612011-03-24 Juanma Barranquero <lekktu@gmail.com>
5762
5763 * w32term.c (x_set_glyph_string_clipping):
5764 Don't pass uninitialized region to CombineRgn.
5765
9c88f339
JB
57662011-03-23 Juanma Barranquero <lekktu@gmail.com>
5767
5768 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5769 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5770 (Fx_close_connection): Remove unused variable `i'.
5771
5772 * w32font.c (w32font_draw): Return number of glyphs.
5773 (w32font_open_internal): Remove unused variable `i'.
5774 (w32font_driver): Add missing initializer.
5775
5776 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5777 (fill_in_menu): Remove unused variable `items_added'.
5778
5779 * w32term.c (last_mouse_press_frame): Remove static global variable.
5780 (w32_clip_to_row): Remove unused variable `f'.
5781 (x_delete_terminal): Remove unused variable `i'.
5782
5783 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5784 (NOTHING): Remove unused static global variable.
5785 (uniscribe_check_otf): Remove unused variable `table'.
5786 (uniscribe_font_driver): Add missing initializers.
5787
dee091a3
JD
57882011-03-23 Julien Danjou <julien@danjou.info>
5789
5790 * term.c (Fsuspend_tty, Fresume_tty):
5791 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5792 * window.c (temp_output_buffer_show):
5793 * insdel.c (signal_before_change):
5794 * frame.c (Fhandle_switch_frame):
5795 * fileio.c (Fdo_auto_save):
5796 * emacs.c (Fkill_emacs):
5797 * editfns.c (save_excursion_restore):
5798 * cmds.c (internal_self_insert):
5799 * callint.c (Fcall_interactively):
5800 * buffer.c (Fkill_all_local_variables):
5801 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5802 Use Frun_hooks.
0f4a96b5 5803 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5804 unconditionnaly since it does the check itself.
5805
2c520ab5 58062011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5807
c9c49752
PE
5808 Fix more problems found by GCC 4.5.2's static checks.
5809
8abc3f12
PE
5810 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5811 the first time through the loop, since we know p0 < p1 then.
5812 This also avoids a gcc -Wstrict-overflow warning.
5813
a2d26660
PE
5814 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5815 leading to a memory leak, possible in functions like
5816 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5817 of objects (Bug#8318).
a2d26660 5818
916c72e9
PE
5819 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5820 that could (at least in theory) be that large.
5821
19ab8a18
PE
5822 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5823 This is less likely to overflow, and avoids undefined behavior if
5824 overflow does occur. All callers changed. Use strtoul to scan
5825 for the unsigned long integer.
b7cbbd6f
PE
5826 (pint2hrstr): Simplify and tune code slightly.
5827 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5828
f0641eff
PE
5829 * scroll.c (do_scrolling): Work around GCC bug 48228.
5830 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5831
7f650bb9
PE
5832 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5833 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5834 (validate_x_resource_name): Simplify count usage.
5835 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5836
37dd57d1
PE
5837 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5838 fail (Bug#8306).
81e56e61 5839
699979fc 5840 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5841
401bf9b4
PE
5842 * process.c (Fmake_network_process): Use socklen_t, not int,
5843 where POSIX says socklen_t is required in portable programs.
5844 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5845 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5846 (Fmake_network_process, server_accept_connection):
5847 (wait_reading_process_output, read_process_output):
5848 Likewise.
5849
b93aacde
PE
5850 * process.c: Rename or move locals to avoid shadowing.
5851 (list_processes_1, Fmake_network_process):
5852 (read_process_output_error_handler, exec_sentinel_error_handler):
5853 Rename or move locals.
4dc343ee 5854 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5855 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5856 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5857 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5858 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5859
af8a867c 5860 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5861 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5862 Include tparam.h instead, since it declares them.
af8a867c
PE
5863 * cm.h (PC): Remove extern decl; tparam.h now does this.
5864 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5865 * terminfo.c: Include tparam.h, to check interfaces.
5866 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5867 (tparam): Adjust signature to match interface in tparam.h;
5868 this removes some undefined behavior. Check that outstring and len
5869 are zero, which they always are with Emacs.
5870 * tparam.h (PC, BC, UP): New extern decls.
5871
0248044d 5872 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5873 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5874
8ff096c1 5875 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5876 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5877 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5878 (ftfont_list): Remove unused local.
49eaafba
PE
5879 (get_adstyle_property, ftfont_pattern_entity):
5880 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5881 Rename locals to avoid shadowing.
8ff096c1 5882
e2be39f6
PE
5883 * xfont.c (xfont_list_family): Mark var as initialized.
5884
c9735e30
PE
5885 * xml.c (make_dom): Now static.
5886
8f5201ae
PE
5887 * composite.c (composition_compute_stop_pos): Rename local to
5888 avoid shadowing.
b246f932
PE
5889 (composition_reseat_it): Remove unused locals.
5890 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5891 (composition_update_it): Mark var as initialized.
11b61122
PE
5892 (find_automatic_composition): Mark vars as initialized,
5893 with a FIXME (Bug#8290).
8f5201ae 5894
760fbc2c
PE
5895 character.h: Rename locals to avoid shadowing.
5896 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5897 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5898 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5899 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5900 to avoid shadowing.
5901
ff08eb85
PE
5902 * textprop.c (property_change_between_p): Remove; unused.
5903
fc7bf025
PE
5904 * intervals.c (interval_start_pos): Now static.
5905
235d7abc
PE
5906 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5907
44f230aa
SM
5908 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5909 Rename locals to avoid shadowing.
3e7d6594 5910
50060332
PE
5911 * sound.c (wav_play, au_play, Fplay_sound_internal):
5912 Fix pointer signedness.
d01f234b 5913 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5914 (wav_play): Initialize a variable to 0, to prevent undefined
5915 behavior (Bug#8278).
50060332 5916
c4fc4e30
PE
5917 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5918
918436ed
PE
5919 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5920
c939f91b
PE
5921 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5922 clobbering (Bug#8298).
b9c7f648
PE
5923 * sysdep.c (sys_subshell): Likewise.
5924 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5925
6bd8c144
PE
5926 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5927 This should get cleaned up, so that child_setup has the
5928 same signature on all platforms.
5929
7710357c 5930 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5931 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5932
c59da222
CY
59332011-03-22 Chong Yidong <cyd@stupidchicken.com>
5934
5935 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5936 not to be necessary, and produces flickering.
5937
66b87493
GM
59382011-03-20 Glenn Morris <rgm@gnu.org>
5939
5940 * config.in: Remove file.
5941
45b6f6d5
JB
59422011-03-20 Juanma Barranquero <lekktu@gmail.com>
5943
5944 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5945 are now in src/globals.h.
5946 (syms_of_minibuf): Remove spurious & from previous change.
5947
3ec03f7e
LL
59482011-03-20 Leo <sdl.web@gmail.com>
5949
5950 * minibuf.c (completing-read-function): New variable.
5951 (completing-read-default): Rename from completing-read.
5952 (completing-read): Call completing-read-function.
5953
b14e3e21
CY
59542011-03-19 Juanma Barranquero <lekktu@gmail.com>
5955
5956 * xfaces.c (Fx_load_color_file):
5957 Read color file from absolute filename (bug#8250).
5958
f2b726e6
JB
59592011-03-19 Juanma Barranquero <lekktu@gmail.com>
5960
5961 * makefile.w32-in: Update dependencies.
5962
09f6ff02
EZ
59632011-03-17 Eli Zaretskii <eliz@gnu.org>
5964
5965 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5966
29a6015a
PE
59672011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5968
a3a6c54e
PE
5969 Fix more problems found by GCC 4.5.2's static checks.
5970
b766f867
PE
5971 * process.c (make_serial_process_unwind, send_process_trap):
5972 (sigchld_handler): Now static.
5973
be02381c
PE
5974 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5975 That way, the code declares only the vars that it needs.
5976 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5977 * s/cygwin.h (PTY_ITERATION): Likewise.
5978 * s/darwin.h (PTY_ITERATION): Likewise.
5979 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5980
57048744
PE
5981 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5982 * process.c (allocate_pty): Don't declare stb unless it's needed.
5983
7914961c 5984 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5985 (CONSTANTLIM): Remove; unused.
5986 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5987 Define only if needed.
7914961c 5988
b3967b18
PE
5989 * unexelf.c (unexec): Name an expression,
5990 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5991 Use a different way to cause a compilation error if anyone uses
5992 n rather than nn, a way that does not involve shadowing.
73366a00 5993 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5994
29a6015a
PE
5995 * deps.mk (unexalpha.o): Remove; unused.
5996
43cfc33e 5997 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5998 * unexec.h: New file.
ce701a33
PE
5999 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6000 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6001 Depend on unexec.h.
6002 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6003 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6004 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6005 Change as necessary to match prototype in unexec.h.
ce701a33 6006
01f44d5a
PE
6007 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6008 shadowing.
4f63c6bb 6009 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6010
a6670b0b
PE
6011 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6012 Rename locals to avoid shadowing.
6013
cef2010d 6014 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6015 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6016
d4d7173a
PE
6017 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6018
f08b802a
PE
6019 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6020 warning when compiling print.c.
6021
3ddb0639
PE
6022 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6023 instead of using an uninitialized var.
5ad03b97 6024 (font_sort_entities): Mark var as initialized.
3ddb0639 6025
170a2692
PE
6026 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6027
e663c700
PE
6028 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6029 pointers to constants.
89bc529a 6030 (font_parse_fcname): Remove unused vars.
7b81e2d0 6031 (font_delete_unmatched): Now static.
ea838e10 6032 (font_get_spec): Remove; unused.
13a547c6
PE
6033 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6034 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6035 Rename or move locals to avoid shadowing.
e663c700 6036
2a80c887 6037 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6038 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6039
1384fa33 6040 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6041 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6042
8b2c52e9
PE
6043 * alloc.c (mark_backtrace): Move decl from here ...
6044 * lisp.h: ... to here, so that it can be checked.
6045
475545b5 6046 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6047 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6048 (lisp_indirect_variable): Name an expression,
6049 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6050 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6051
b1349114 6052 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6053 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6054 Use const pointer when appropriate.
b1349114 6055
a2928364
PE
6056 * lisp.h (get_system_name, get_operating_system_release):
6057 Move decls here, to check interfaces.
6058 * process.c (get_operating_system_release): Move decl to lisp.h.
6059 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6060 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6061 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6062 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6063 (Fformat_time_string, Fencode_time, Finsert_char):
6064 (Ftranslate_region_internal, Fformat):
6065 Rename or remove local vars to avoid shadowing.
9710023e 6066 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6067
a415e694
PE
6068 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6069 avoid shadowing.
6070
8ef4622d
PE
6071 * lisp.h (eassert): Check that the argument compiles, even if
6072 ENABLE_CHECKING is not defined.
6073
946f9a5b
PE
6074 * data.c (Findirect_variable): Name an expression, to avoid
6075 gcc -Wbad-function-cast warning.
112396d6 6076 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6077 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6078 (Fmake_variable_buffer_local, Fmake_local_variable):
6079 Mark variables as initialized.
52746918 6080 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6081
e5aab7e7 6082 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6083 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6084 Rename locals to avoid shadowing.
dff45157
PE
6085 (mark_stack): Move local variables into the #ifdef region where
6086 they're used.
7bc26fdb
PE
6087 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6088 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6089 needed otherwise.
6090 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6091 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6092 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6093
e5aab7e7
PE
6094 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6095 avoids undefined behavior in theory.
6096
4da60324
PE
6097 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6098
88043301
PE
6099 Use functions, not macros, for up- and down-casing (Bug#8254).
6100 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6101 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6102 to use the following functions instead of these macros.
6103 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6104 EMACS_INT, since callers assume the returned value fits in int.
6105 (upcase1): Likewise, for UPCASE_TABLE.
6106 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6107 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6108 the race-condition problem in the old DOWNCASE.
88043301 6109
19ed5445
PE
6110 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6111 Rename locals to avoid shadowing.
6112 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6113 (regex_compile, re_search_2, re_match_2_internal):
6114 Remove unused local vars.
952db0d7
PE
6115 (FREE_VAR): Rewrite so as not to use empty "else",
6116 which gcc can warn about.
da053e48 6117 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6118 (RETALLOC_IF): Define only if needed.
6119 (WORDCHAR_P): Likewise. This one is never needed, but is used
6120 only in a comment talking about a compiler bug, so put inside
6121 the #if 0 of that comment.
6122 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6123 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6124 Remove; unused.
19ed5445 6125
1f3561e4 6126 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6127 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6128 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6129
ded6f8f7
PE
6130 * search.c (simple_search): Remove unused var.
6131
dbd37a95
PE
6132 * dired.c (compile_pattern): Move decl from here ...
6133 * lisp.h: ... to here, so that it can be checked.
6134 (struct re_registers): New forward decl.
6135
7e47afad
PE
6136 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6137
85f24f61
PE
6138 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6139 All uses changed.
6140 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6141 Rename locals to avoid shadowing.
5671df8f 6142 (Fvertical_motion): Mark locals as initialized.
85f24f61 6143
181aa2be 6144 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6145 (casify_region): Mark local as initialized.
181aa2be 6146
930d429c
PE
6147 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6148
7082eac6
PE
6149 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6150 New macros, so that the caller can use some names other than
6151 gcpro1, gcpro2, etc.
6152 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6153 of the new macros.
6154 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6155 argument, for consistency with GCPRO2_VAR, etc: it is now the
6156 prefix of the variable, not the variable itself. All uses
6157 changed.
38b2c076
PE
6158 * dired.c (directory_files_internal, file_name_completion):
6159 Rename locals to avoid shadowing.
6160
15206ed9
PE
6161 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6162 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6163 dired.c's scmp function, had undefined behavior.
6164 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6165 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6166 * buffer.h: ... to here, because these macros use current_buffer,
6167 and the new implementation with inline functions needs to have
6168 current_buffer in scope now, rather than later when the macros
6169 are used.
6170 (downcase, upcase1): New static inline functions.
6171 (DOWNCASE, UPCASE1): Reimplement using these functions.
6172 This avoids undefined behavior in expressions like
6173 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6174 from race conditions in accessing the global variables
6175 case_temp1 and case_temp2.
6176 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6177 * lisp.h (case_temp1, case_temp2): Remove their decls.
6178 * character.h (ASCII_CHAR_P): Move from here ...
6179 * lisp.h: ... to here, so that the inline functions mentioned
6180 above can use them.
6181
4a6bea26
PE
6182 * dired.c (directory_files_internal_unwind): Now static.
6183
f14b7e14
PE
6184 * fileio.c (file_name_as_directory, directory_file_name):
6185 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6186 Now static.
2893f146
PE
6187 (file_name_as_directory): Use const pointers when appropriate.
6188 (Fexpand_file_name): Likewise. In particular, newdir might
6189 point at constant storage, so make it a const pointer.
fd4ead52 6190 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6191 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6192 signedness issues.
f839df0c
PE
6193 (Fset_file_times, Finsert_file_contents, auto_save_error):
6194 Rename locals to avoid shadowing.
f14b7e14 6195
5716756e 6196 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6197 (Ftry_completion, Fall_completions): Rename or remove locals
6198 to avoid shadowing.
5716756e 6199
b4c3046a
PE
6200 * marker.c (bytepos_to_charpos): Remove; unused.
6201
b45db522
PE
6202 * lisp.h (verify_bytepos, count_markers): New decls,
6203 so that gcc does not warn that these functions aren't declared.
6204
85876d07
PE
6205 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6206 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6207 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6208 (copy_text): Remove unused local var.
85876d07 6209
03d78a21 6210 * filelock.c (within_one_second): Now static.
b3dd38ab 6211 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6212
5df8f01b
PE
6213 * buffer.c (fix_overlays_before): Mark locals as initialized.
6214 (fix_start_end_in_overlays): Likewise. This function should be
6215 simplified by using pointers-to-pointers, but that's a different
6216 matter.
b1d876f1 6217 (switch_to_buffer_1): Now static.
8f54f30a
PE
6218 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6219 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6220
a70072c9 6221 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6222 Fix pointer signedness issue.
edced198
PE
6223 (sys_subshell): Mark local as volatile if checking for lint,
6224 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6225 (MAXPATHLEN): Define only if needed.
a70072c9 6226
a0977c44
PE
6227 * process.c (serial_open, serial_configure): Move decls from here ...
6228 * systty.h: ... to here, so that they can be checked.
6229
a884fdcc
PE
6230 * fns.c (get_random, seed_random): Move extern decls from here ...
6231 * lisp.h: ... to here, so that they can be checked.
6232
604efe86 6233 * sysdep.c (reset_io): Now static.
b8950c94 6234 (wait_for_termination_signal): Remove; unused.
604efe86 6235
38fc62d9
PE
6236 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6237 (copy_keymap_item, append_key, push_text_char_description):
6238 Now static.
1004a21a 6239 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6240 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6241 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6242 (describe_map_tree):
6243 Rename locals to avoid shadowing.
38fc62d9 6244
2f2650da
PE
6245 * keyboard.c: Declare functions static if they are not used elsewhere.
6246 (echo_char, echo_dash, cmd_error, top_level_2):
6247 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6248 (read_char, kbd_buffer_get_event, make_lispy_position):
6249 (make_lispy_event, make_lispy_movement, apply_modifiers):
6250 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6251 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6252 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6253 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6254 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6255
a053e86c 6256 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6257 (mark_kboards): Move decl here ...
6258 * alloc.c (mark_kboards): ... from here.
a053e86c 6259
4752793e
PE
6260 * lisp.h (force_auto_save_soon): New decl.
6261
74f10ca7 6262 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6263 (DEFINE_DUMMY_FUNCTION): New macro.
6264 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6265 Use it.
c03cd23f
PE
6266 (main): Add casts to avoid warnings
6267 if GCC considers string literals to be constants.
74f10ca7 6268
022e70d4
PE
6269 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6270
59d6fe83
PE
6271 * dbusbind.c: Pointer signedness fixes.
6272 (xd_signature, xd_append_arg, xd_initialize):
6273 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6274 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6275 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6276 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6277
78320123
PE
6278 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6279 if GCC considers string literals to be constants.
49cebcca 6280 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6281
35ac2a97
SM
62822011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6283
fb103ca9
SM
6284 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6285 (print_preprocess, print_object): New macro to fix last change.
6286
35ac2a97
SM
6287 * print.c (print_preprocess): Don't forget font objects.
6288
62973b41
JB
62892011-03-16 Juanma Barranquero <lekktu@gmail.com>
6290
6291 * emacs.c (USAGE3): Doc fixes.
6292
0e48bb22
AS
62932011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6294
6295 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6296 structure.
6297
7684e57b
JB
62982011-03-14 Juanma Barranquero <lekktu@gmail.com>
6299
6300 * lisp.h (VWindow_system, Qfile_name_history):
6301 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6302 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6303 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6304
6305 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6306 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6307
6308 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6309 * w32console.c (detect_input_pending, read_input_pending)
6310 (encode_terminal_code):
6311 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6312 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6313 (w32_system_caret_y, Qfile_name_history):
6314 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6315 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6316 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6317 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6318 * w32proc.c (Qlocal, report_file_error):
6319 * w32term.c (Vwindow_system, updating_frame):
6320 * w32uniscribe.c (initialized, uniscribe_font_driver):
6321 Remove unneeded extern declarations.
6322
2aa46d6c
CY
63232011-03-14 Chong Yidong <cyd@stupidchicken.com>
6324
c96bbc66 6325 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6326
cffc6f3b
CY
63272011-03-13 Chong Yidong <cyd@stupidchicken.com>
6328
6329 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6330 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6331 These macros can no longer be used for assignment.
6332
44f230aa
SM
6333 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6334 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6335 (record_buffer_markers, fetch_buffer_markers): New functions for
6336 recording and fetching special buffer markers.
6337 (set_buffer_internal_1, set_buffer_temp): Use them.
6338
6339 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6340
6341 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6342
6343 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6344 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6345
6346 * xdisp.c (hscroll_window_tree):
6347 (reconsider_clip_changes): Use PT instead of BUF_PT.
6348
d251f04b
EZ
63492011-03-13 Eli Zaretskii <eliz@gnu.org>
6350
6351 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6352 $(EMACS_ROOT)/lib/intprops.h.
6353
f0c77cd1
PE
63542011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6355
3eca4629
PE
6356 Fix more problems found by GCC 4.5.2's static checks.
6357
7c86ee98
PE
6358 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6359 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6360 (xg_free_frame_widgets): Make it clear that a local variable is
6361 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6362 (gdk_window_get_screen): Make it clear that this macro is needed
6363 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6364 (int_gtk_range_get_value): New function, which avoids a diagnostic
6365 from gcc -Wbad-function-cast.
6366 (xg_set_toolkit_scroll_bar_thumb): Use it.
6367 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6368 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6369 (get_utf8_string, xg_get_file_with_chooser):
6370 Rename locals to avoid shadowing.
6371 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6372
41729b81
PE
6373 * xgselect.c (xg_select): Remove unused var.
6374
f0c77cd1
PE
6375 * image.c (four_corners_best): Mark locals as initialized.
6376 (gif_load): Initialize transparent_p to zero (Bug#8238).
6377 Mark another local as initialized.
ec6cf4c6 6378 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6379
ce0ad53d 6380 * image.c (clear_image_cache): Now static.
d5d5a617 6381 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6382 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6383 (x_edge_detection): Remove unnecessary cast that
6384 gcc -Wbad-function-cast diagnoses.
2037898d 6385 (gif_load): Fix pointer signedness.
6ae141d6
PE
6386 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6387 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6388
33383987 63892011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6390
d32df629
PE
6391 Improve quality of tests for time stamp overflow.
6392 For example, without this patch (encode-time 0 0 0 1 1
6393 1152921504606846976) returns the obviously-bogus value (-948597
6394 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6395 reports time overflow. See
6396 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6397 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6398 * editfns.c: Include limits.h and intprops.h.
6399 (TIME_T_MIN, TIME_T_MAX): New macros.
6400 (time_overflow): Move earlier, to before first use.
6401 (hi_time, lo_time): New functions, for an accurate test for
6402 out-of-range times.
6403 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6404 (Fget_internal_run_time): Don't assume time_t fits in int.
6405 (make_time): Use list2 instead of Fcons twice.
6406 (Fdecode_time): More accurate test for out-of-range times.
6407 (check_tm_member): New function.
6408 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6409 (lisp_time_argument): Don't rely on undefined left-shift and
6410 right-shift behavior when checking for time stamp overflow.
8be6f318 6411
fe31d94c
PE
6412 * editfns.c (time_overflow): New function, refactoring common code.
6413 (Fformat_time_string, Fdecode_time, Fencode_time):
6414 (Fcurrent_time_string): Use it.
6415
8be6f318
PE
6416 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6417 * dired.c (make_time): Move to ...
6418 * editfns.c (make_time): ... here.
6419 * systime.h: Note the move.
6420
09d9db2c 64212011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6422
126bc0dc
YM
6423 * fringe.c (update_window_fringes): Remove unused variables.
6424
c47cbdfd
YM
6425 * unexmacosx.c (copy_data_segment): Also copy __got section.
6426 (Bug#8223)
6427
7ac80be9
EZ
64282011-03-12 Eli Zaretskii <eliz@gnu.org>
6429
c96bbc66 6430 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6431 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6432 Constify `char *' arguments and their references according to
6433 prototypes in tparam.h.
6434
ecb0f94d 6435 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6436
7ac80be9
EZ
6437 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6438 Adapt all references accordingly.
6439
6440 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6441
ef1fd07e
TT
64422011-03-11 Tom Tromey <tromey@redhat.com>
6443
6444 * buffer.c (syms_of_buffer): Remove obsolete comment.
6445
7ef4b50c
EZ
64462011-03-11 Eli Zaretskii <eliz@gnu.org>
6447
6448 * termhooks.h (encode_terminal_code): Declare prototype.
6449
6450 * msdos.c (encode_terminal_code): Don't declare prototype.
6451
6452 * term.c (encode_terminal_code): Now external again, used by
6453 w32console.c and msdos.c.
6454
44f230aa
SM
6455 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6456 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6457
4b1ec863 64582011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6459
1714f52b 6460 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6461
4b1ec863
PE
6462 * fringe.c (update_window_fringes): Mark locals as initialized
6463 (Bug#8227).
6464 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6465
524c7aa6
PE
6466 * alloc.c (mark_fringe_data): Move decl from here ...
6467 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6468 to check its interface.
6469 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6470
a5c0af81 6471 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6472 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6473 (fontset_font): Mark local as initialized.
a9a06e0b 6474 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6475
b4716021
PE
6476 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6477
811e9bac 6478 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6479 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6480 (x_own_selection, Fx_disown_selection_internal): Rename locals
6481 to avoid shadowing.
6482 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6483
7e3ab302
PE
6484 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6485 so that the caller can use some name other than gcpro1.
6486 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6487 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6488 (Fx_backspace_delete_keys_p):
6489 Use them to avoid shadowing, and rename vars to avoid shadowing.
6490 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6491 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6492 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6493 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6494 Remove unused locals.
7e3ab302
PE
6495 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6496 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6497 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6498 macros.
f78faa98 6499
e2b13473
PE
6500 * xterm.h (x_mouse_leave): New decl.
6501
77f23912
PE
6502 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6503 Remove unused functions.
cdf4ba58
PE
6504 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6505 (x_calc_absolute_position): Now static.
7411c686 6506 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6507 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6508 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6509 unless they are used.
38d0b34a
PE
6510 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6511 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6512 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6513 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6514 (x_error_catcher, x_connection_closed, x_error_handler):
6515 (x_error_quitter, xembed_send_message, x_iconify_frame):
6516 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6517 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6518 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6519
44f230aa
SM
6520 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6521 Rename or move locals to avoid shadowing.
6b463e58 6522 (tty_defined_color, merge_face_heights): Now static.
5967d051 6523 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6524 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6525 does not deduce is never used uninitialized.
73719eba
PE
6526 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6527 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6528
426994c3 6529 * terminal.c (store_terminal_param): Now static.
5489860b 6530
032f1620 6531 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6532 (set_frame_menubar): Remove unused local.
d4323972 6533 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6534 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6535 since they might point to immutable storage.
281585b0
PE
6536 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6537 since it's unused otherwise.
032f1620 6538
367c19e5 6539 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6540 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6541 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6542 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6543 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6544 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6545 does not deduce are never used uninitialized.
70739cbe 6546
07b48fa9
PE
6547 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6548
8868a238 6549 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6550 * window.c (window_loop, size_window):
6551 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6552
7e5cf297 6553 * window.c (display_buffer): Now static.
d6550a9f
PE
6554 (size_window): Mark variables that gcc -Wuninitialized
6555 does not deduce are never used uninitialized.
a586633d
PE
6556 * window.h (check_all_windows): New decl, to forestall
6557 gcc -Wmissing-prototypes diagnostic.
5b555da1 6558 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6559
f6095868
PE
6560 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6561 shadowing.
6562 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6563 Include <limits.h>.
6564 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6565 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6566 (load_charset_map): Mark variables that gcc -Wuninitialized
6567 does not deduce are never used uninitialized.
53df7c11 6568 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6569
f38b440c
PE
6570 * coding.c (coding_set_source, coding_set_destination):
6571 Use "else { /* comment */ }" rather than "else /* comment */;"
6572 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6573 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6574 a block, when the outer 'i' will do.
6575 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6576 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6577 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6578 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6579 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6580 Rename locals to avoid shadowing.
6581 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6582 * coding.c (emacs_mule_char, encode_invocation_designation):
6583 Now static, since they're not used elsewhere.
413bb2db 6584 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6585 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6586 (decode_coding_emacs_mule): Mark variables that gcc
6587 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6588 (detect_coding_iso_2022): Initialize a local variable that might
6589 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6590 this initialization is needed. (Bug#8211)
5f58e762
PE
6591 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6592 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6593 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6594 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6595 Remove unused macros.
f38b440c 6596
232b38b9 6597 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6598 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6599 * character.c (string_count_byte8): Likewise.
232b38b9 6600
fb90da1b
PE
6601 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6602 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6603
fb93dbc2
PE
6604 * chartab.c (copy_sub_char_table): Now static, since it's not used
6605 elsewhere.
5c156ace
PE
6606 (sub_char_table_ref_and_range, char_table_ref_and_range):
6607 Rename locals to avoid shadowing.
bbcd0949 6608 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6609
7d3b3862 6610 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6611 (BIDI_BOB): Remove unused macro.
7d3b3862 6612
6be7d3da
PE
6613 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6614 deduce are never used uninitialized.
c2ed9c8b 6615 * term.c (encode_terminal_code): Likewise.
6be7d3da 6616
75f8807f 6617 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6618
50938595
PE
6619 * tparam.h: New file.
6620 * term.c, tparam.h: Include it.
6621 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6622 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6623 Move these decls to tparam.h, and make them agree with what
6624 is actually in tparam.c. The previous trick of using incompatible
6625 decls in different modules does not conform to the C standard.
6626 All callers of tparam changed to use tparam's actual API.
6627 * tparam.c (tparam1, tparam, tgoto):
6628 Use const pointers where appropriate.
6629
fbceeba2
PE
6630 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6631 * cm.h (struct cm): Likewise.
6632 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6633 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6634 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6635 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6636 (turn_on_face, init_tty): Likewise.
6637 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6638
7f3f1250
PE
6639 * term.c (term_mouse_position): Rename local to avoid shadowing.
6640
e6ca6543
PE
6641 * alloc.c (mark_ttys): Move decl from here ...
6642 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6643
c40f8d15
AS
66442011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6645
6646 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6647
cfe0661d
JB
66482011-03-09 Juanma Barranquero <lekktu@gmail.com>
6649
6650 * search.c (compile_pattern_1): Remove argument regp, unused since
6651 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6652 (compile_pattern): Don't pass it.
6653
0afb4571
J
66542011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6655
6656 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6657 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6658 for ! HAVE_GTK3.
6659 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6660
6661 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6662
6663 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6664 gdk_window_get_screen, gdk_window_get_geometry,
6665 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6666 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6667 (xg_get_pixbuf_from_pixmap): New function.
6668 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6669 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6670 Call xg_get_pixbuf_from_pixmap instead of
6671 gdk_pixbuf_get_from_drawable.
6672 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6673 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6674 (xg_check_special_colors): Use GtkStyleContext and its functions
6675 for HAVE_GTK3.
6676 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6677 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6678 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6679 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6680 Call gtk_widget_get_preferred_size.
0afb4571
J
6681 (xg_frame_resized): gdk_window_get_geometry only takes 5
6682 parameters.
44f230aa
SM
6683 (xg_win_to_widget, xg_event_is_for_menubar):
6684 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6685 (xg_set_widget_bg): New function.
6686 (delete_cb): New function.
895009e1 6687 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6688 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6689 (xg_set_background_color): Call xg_set_widget_bg.
6690 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6691 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6692 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6693 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6694 if ! HAVE_GTK3.
6695 (update_frame_tool_bar): Call gtk_widget_hide.
6696 (xg_initialize): Use GDK_KEY_g.
6697
6698 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6699 if ! HAVE_GTK3
6700 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6701
6702 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6703 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6704 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6705
1c2cc4ef
JB
67062011-03-08 Juanma Barranquero <lekktu@gmail.com>
6707
6708 * w32xfns.c (select_palette): Check success of RealizePalette against
6709 GDI_ERROR, not zero.
6710
33383987 6711See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6712
6713;; Local Variables:
6714;; coding: utf-8
aac0c6e3
MR
6715;; End:
6716
33383987 6717 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6718
6719 This file is part of GNU Emacs.
6720
6721 GNU Emacs is free software: you can redistribute it and/or modify
6722 it under the terms of the GNU General Public License as published by
6723 the Free Software Foundation, either version 3 of the License, or
6724 (at your option) any later version.
6725
6726 GNU Emacs is distributed in the hope that it will be useful,
6727 but WITHOUT ANY WARRANTY; without even the implied warranty of
6728 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6729 GNU General Public License for more details.
6730
6731 You should have received a copy of the GNU General Public License
6732 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.