* fileio.c (Fverify_visited_file_modtime): Avoid time overflow
[bpt/emacs.git] / src / ChangeLog
CommitLineData
0c671da6 12011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2
7f9bbdbb
PE
3 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4 if b->modtime has its maximal value.
5
dfe18f82
PE
6 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7
84acfcf0
PE
8 Don't assume time_t can fit into int.
9 * buffer.h (struct buffer.modtime): Now time_t, not int.
10 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
11 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
12
ccd9a01a
PE
13 Minor fixes for signed vs unsigned integers.
14 * character.h (MAYBE_UNIFY_CHAR):
15 * charset.c (maybe_unify_char):
16 * keyboard.c (read_char, reorder_modifiers):
17 XINT -> XFASTINT, since the integer must be nonnegative.
18 * ftfont.c (ftfont_spec_pattern):
19 * keymap.c (access_keymap, silly_event_symbol_error):
20 XUINT -> XFASTINT, since the integer must be nonnegative.
21 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
22 since it makes no difference and we prefer signed.
23 * keyboard.c (record_char): Use XUINT when all the neighbors do.
24 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
25 nonnegative.
26
4d09bcf6
PE
272011-06-06 Paul Eggert <eggert@cs.ucla.edu>
28
29 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
30 Do not assume that spare memory exists; that assumption is valid
31 only if SYSTEM_MALLOC.
32 (LARGE_REQUEST): New macro, so that the issue of large requests
33 is separated from the issue of spare memory.
34
810928a2
AS
352011-06-05 Andreas Schwab <schwab@linux-m68k.org>
36
172418ad
AS
37 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
38 format. (Bug#8806)
39
43f862f7
AS
40 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
41
810928a2
AS
42 * xfns.c (x_set_scroll_bar_default_width): Move declarations
43 before statements.
44
a059fe24
JD
452011-06-05 Jan Djärv <jan.h.d@swipnet.se>
46
47 * gtkutil.c (xg_get_default_scrollbar_width): New function.
48
49 * gtkutil.h: Declare xg_get_default_scrollbar_width.
50
51 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
52 min width by calling x_set_scroll_bar_default_width (Bug#8505).
53
989bf368
JB
542011-06-05 Juanma Barranquero <lekktu@gmail.com>
55
56 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
57
4b80f674
CY
582011-06-04 Chong Yidong <cyd@stupidchicken.com>
59
60 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
61 (x_clipboard_manager_save): Add return value.
62 (x_clipboard_manager_error_1, x_clipboard_manager_error_2): New
63 error handlers.
64 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
65 Obey Vx_select_enable_clipboard_manager. Catch errors in
66 x_clipboard_manager_save (Bug#8779).
67 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 68 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 69
99a33b77 702011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
71
72 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
73
99a33b77 742011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
75
76 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
77 in the current matrix if keep_current_p is non-zero.
78
8264569d
EZ
792011-06-04 Eli Zaretskii <eliz@gnu.org>
80
81 * bidi.c (bidi_level_of_next_char): Fix last change.
82
57f97249
EZ
832011-06-03 Eli Zaretskii <eliz@gnu.org>
84
fec2107c 85 Support bidi reordering of text covered by display properties.
57f97249 86
fec2107c
EZ
87 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
88 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
89 (bidi_cache_search, bidi_cache_iterator_state)
90 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
91 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
92 character positions inside a run of characters covered by a
93 display string.
94 (bidi_paragraph_init, bidi_resolve_explicit_1)
95 (bidi_level_of_next_char): Call bidi_fetch_char and
96 bidi_fetch_char_advance instead of FETCH_CHAR and
97 FETCH_CHAR_ADVANCE.
98 (bidi_init_it): Initialize new members.
99 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
100 definitions.
101 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
102 instead of using explicit *_CHAR codes.
103 (bidi_resolve_explicit, bidi_resolve_weak): Use
104 FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
105 bidirectional text is supported only in multibyte buffers.
106 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
107 it to initialize the frame_window_p member of struct bidi_it.
108 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
109 (bidi_resolve_explicit, bidi_resolve_weak)
110 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
111 bidi_it->nchars is non-positive.
112 (bidi_level_of_next_char): Don't try to lookup the cache for the
113 next/previous character if nothing is cached there yet, or if we
114 were just reseat()'ed to a new position.
c40e2fb2 115
0e14fe90
EZ
116 * xdisp.c (set_cursor_from_row): Set start and stop points
117 according to the row's direction when priming the loop that looks
118 for the glyph on which to display cursor.
119 (single_display_spec_intangible_p): Function deleted.
120 (display_prop_intangible_p): Reimplement to call
121 handle_display_spec instead of single_display_spec_intangible_p.
122 Accept 3 additional arguments needed by handle_display_spec. This
123 fixes incorrect cursor motion across display property with complex
124 values: lists, `(when COND...)' forms, etc.
125 (single_display_spec_string_p): Support property values that are
126 lists with the argument STRING its top-level element.
127 (display_prop_string_p): Fix the condition for processing a
128 property that is a list to be consistent with handle_display_spec.
fec2107c 129 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
130 last portion of handle_display_prop.
131 (compute_display_string_pos): Accept additional argument
132 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
133 value of a `display' property is a "replacing spec".
134 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
135 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
136 the display property, but just return a value indicating whether
137 the display property will replace the characters it covers.
138 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
139 frame_window_p members of struct bidi_it.
fec2107c
EZ
140 (compute_display_string_pos, compute_display_string_end): New
141 functions.
142 (push_it): Accept second argument POSITION, where pop_it should
143 jump to continue iteration.
144 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 145
fec2107c
EZ
146 * keyboard.c (adjust_point_for_property): Adjust the call to
147 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
148
149 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
150 (bidi_init_it): Update prototypes.
151 (display_prop_intangible_p): Update prototype.
152 (compute_display_string_pos, compute_display_string_end): Declare
153 prototypes.
154 (struct bidi_it): New members nchars and disp_pos. ch_len is now
155 EMACS_INT.
fc6f18ce 156
40087514 1572011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 158
57f53182
PE
159 Malloc failure behavior now depends on size of allocation.
160 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
161 * lisp.h: Change signatures accordingly.
162 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
163 All callers changed. (Bug#8762)
164
165 * gnutls.c: Use Emacs's memory allocators.
166 Without this change, the gnutls library would invoke malloc etc.
167 directly, which causes problems on non-SYNC_INPUT hosts, and which
168 runs afoul of improving memory_full behavior. (Bug#8761)
169 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
170 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
171 xfree instead of the default malloc, realloc, free.
172 (Fgnutls_boot): No need to check for memory allocation failure,
173 since xmalloc does that for us.
174
ac32cd99 175 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
176 * category.c (hash_get_category_set):
177 * ccl.c (ccl_driver):
178 * charset.c (Fdefine_charset_internal):
179 * charset.h (struct charset.hash_index):
180 * composite.c (get_composition_id, gstring_lookup_cache)
181 (composition_gstring_put_cache):
182 * composite.h (struct composition.hash_index):
183 * dispextern.h (struct image.hash):
184 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
185 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
186 (hashfn_equal, hashfn_user_defined, make_hash_table)
187 (maybe_resize_hash_table, hash_lookup, hash_put)
188 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
189 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
190 (Fsxhash, Fgethash, Fputhash, Fmaphash):
191 * image.c (make_image, search_image_cache, lookup_image)
192 (xpm_put_color_table_h):
193 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 194 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
195 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
196 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
197 * alloc.c (allocate_vectorlike):
198 Check for overflow in vector size calculations.
199 * ccl.c (ccl_driver):
200 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
201 * fns.c, image.c: Remove unnecessary static decls that would otherwise
202 need to be updated by these changes.
40087514
PE
203 * fns.c (make_hash_table, maybe_resize_hash_table):
204 Check for integer overflow with large hash tables.
0de4bb68
PE
205 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
206 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
207 (SXHASH_REDUCE): New macro.
208 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
209 Use it instead of discarding useful hash info with large hash values.
210 (sxhash_float): New function.
211 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
212 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
213 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
214 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
215 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
216 Adjust signatures to match updated version of code.
217 (consing_since_gc): Now EMACS_INT, since a single hash table can
218 use more than INT_MAX bytes.
219
698d32e2
DN
2202011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
221
222 Make it possible to build with GCC-4.6+ -O2 -flto.
223
224 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
225
fd6fa53f
SM
2262011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
227
228 * minibuf.c (get_minibuffer, read_minibuf_unwind):
229 Call minibuffer-inactive-mode.
230
864db017
JB
2312011-05-31 Juanma Barranquero <lekktu@gmail.com>
232
233 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
234 Update dependencies.
235
2ad0baf4
DN
2362011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
237
238 * data.c (init_data): Remove code for UTS, this system is not
239 supported anymore.
240
4fcc2638
DN
2412011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
242
243 Don't force ./temacs to start in terminal mode.
244
245 * frame.c (make_initial_frame): Initialize faces in all cases, not
246 only when CANNOT_DUMP is defined.
247 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
248
c56e0fd5
DN
2492011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
250
251 * dispnew.c (add_window_display_history): Use const for the string
252 pointer. Remove declaration, not needed.
253
333d54da 2542011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 255
55d4c1b2 256 Use 'inline', not 'INLINE'.
333d54da 257 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
258 * alloc.c, fontset.c (INLINE): Remove.
259 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
260 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
261 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
262 * gmalloc.c (register_heapinfo): Use inline unconditionally.
263 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
264
738db178
DN
2652011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
266
267 Make it possible to run ./temacs.
268
269 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
270 syms_of_callproc does the same thing. Remove test for
271 "initialized", do it in the caller.
272 * emacs.c (main): Avoid calling set_initial_environment when dumping.
273
620c53a6
SM
2742011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
275
276 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
277 (read_minibuf): Use get_minibuffer.
278 (syms_of_minibuf): Use DEFSYM.
279 (Qmetadata): New var.
280 * data.c (Qbuffer): Don't make it static.
281 (syms_of_data): Use DEFSYM.
282
e003a292
PE
2832011-05-31 Paul Eggert <eggert@cs.ucla.edu>
284
285 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
286 (CCL_CODE_MIN): New macro.
287
ed008a6d
PE
2882011-05-30 Paul Eggert <eggert@cs.ucla.edu>
289
3687c2ef
PE
290 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
291
ed008a6d
PE
292 * eval.c (Qdebug): Now static.
293 * lisp.h (Qdebug): Remove decl. This reverts a part of the
294 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
295 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
296
d66c4c7c
CY
2972011-05-29 Chong Yidong <cyd@stupidchicken.com>
298
299 * image.c: Various fixes to ImageMagick code comments.
300 (Fimagemagick_types): Doc fix.
301
5fbc2025
PE
3022011-05-29 Paul Eggert <eggert@cs.ucla.edu>
303
0196f88a
PE
304 Minor fixes prompted by GCC 4.6.0 warnings.
305
306 * xselect.c (converted_selections, conversion_fail_tag): Now static.
307
5fbc2025
PE
308 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
309 (x_clipboard_manager_save_all): Move extern decl to ...
310 * xterm.h: ... here, so that it can be checked for consistency.
311
1dd3c2d9
CY
3122011-05-29 Chong Yidong <cyd@stupidchicken.com>
313
314 * xselect.c (x_clipboard_manager_save_frame)
315 (x_clipboard_manager_save_all): New functions.
316 (Fx_clipboard_manager_save): Lisp function deleted.
317
318 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
319 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
320
321 * xterm.h: Update prototype.
322
5ba6571d
WX
3232011-05-28 William Xu <william.xwl@gmail.com>
324
325 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
326 exiting (Bug#8239).
327
3eaff834
JM
3282011-05-28 Jim Meyering <meyering@redhat.com>
329
e1900994 330 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
331 * fns.c (to_uchar): Define.
332 (crypto_hash_function): Use it to convert some newly-signed
333 variables to unsigned, to avoid sign-extension bugs. For example,
334 without this change, (md5 "truc") would evaluate to
335 45723a2aff78ff4fff7fff1114760e62 rather than the expected
336 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 337 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 338
0f6990a7
PE
3392011-05-27 Paul Eggert <eggert@cs.ucla.edu>
340
341 Integer overflow fixes.
c8a9ca5a 342
08686060
PE
343 * dbusbind.c: Serial number integer overflow fixes.
344 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
345 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
346 to hold a serial number that is too large for a fixnum.
347 (Fdbus_method_return_internal, Fdbus_method_error_internal):
348 Check for serial numbers out of range. Decode any serial number
59568bf0 349 that was so large that it became a float. (Bug#8722)
08686060 350
2d1fc3c7
PE
351 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
352 (Fdbus_call_method, Fdbus_call_method_asynchronously):
353 Use XFASTINT rather than XUINT when numbers are nonnegative.
354 (xd_append_arg, Fdbus_method_return_internal):
355 (Fdbus_method_error_internal): Likewise. Also, for unsigned
356 arguments, check that Lisp number is nonnegative, rather than
59568bf0 357 silently wrapping negative numbers around. (Bug#8722)
30217ff0 358 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 359 (Bug#8722)
2d1fc3c7 360
c8a9ca5a
PE
361 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
362
519e1d69
PE
363 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
364
30569699
PE
365 ccl: add integer overflow checks
366 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
367 (IN_INT_RANGE): New macros.
368 (ccl_driver): Use them to check for integer overflow when
369 decoding a CCL program. Many of the new checks are whether XINT (x)
370 fits in int; it doesn't always, on 64-bit hosts. The new version
371 doesn't catch all possible integer overflows, but it's an
847044ea 372 improvement. (Bug#8719)
30569699 373
c11285dc
PE
374 * alloc.c (make_event_array): Use XINT, not XUINT.
375 There's no need for unsigned here.
376
fdccd48e
PE
377 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
378 This follows up to the 2011-05-06 change that substituted uintptr_t
379 for EMACS_INT. This case wasn't caught back then.
380
37910ab2
PE
381 Rework Fformat to avoid integer overflow issues.
382 * editfns.c: Include <float.h> unconditionally, as it's everywhere
383 now (part of C89). Include <verify.h>.
384 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
385 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
386 (Fformat): Avoid the prepass trying to compute sizes; it was only
387 approximate and thus did not catch overflow reliably. Instead, walk
388 through the format just once, formatting and computing sizes as we go,
389 checking for integer overflow at every step, and allocating a larger
390 buffer as needed. Keep track separately whether the format is
391 multibyte. Keep only the most-recently calculated precision, rather
392 than them all. Record whether each argument has been converted to
393 string. Use EMACS_INT, not int, for byte and char and arg counts.
394 Support field widths and precisions larger than INT_MAX. Avoid
395 sprintf's undefined behavior with conversion specifications such as %#d
396 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
397 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
398 formatting out-of-range floating point numbers with int
399 formats. (Bug#8668)
400
2e6578fb
PE
401 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
402
0ae6bdee
PE
403 * data.c: Avoid integer truncation in expressions involving floats.
404 * data.c: Include <intprops.h>.
405 (arith_driver): When there's an integer overflow in an expression
406 involving floating point, convert the integers to floating point
407 so that the resulting value does not suffer from catastrophic
408 integer truncation. For example, on a 64-bit host (* 4
409 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
410 Do not rely on undefined behavior after integer overflow.
411
de883a70
PE
412 merge count_size_as_multibyte, parse_str_to_multibyte
413 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 414 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
415 Check for integer overflow.
416 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
417 since it's now a duplicate of the other. This is more of
418 a character than a buffer op, so better that it's in character.c.
419 * fns.c, print.c: Adjust to above changes.
420
2ff916cb
PE
4212011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
422
423 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
424
f1b54466
PE
4252011-05-27 Paul Eggert <eggert@cs.ucla.edu>
426
fb1ac845
PE
427 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
428 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
429 (x_clipboard_manager_save): Now static.
430 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
431
f1b54466
PE
432 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
433 (crypto_hash_function): Now static.
434 Fix pointer signedness problems. Avoid unnecessary initializations.
435
a9f737ee
CY
4362011-05-27 Chong Yidong <cyd@stupidchicken.com>
437
438 * termhooks.h (Vselection_alist): Make it terminal-local.
439
440 * terminal.c (create_terminal): Initialize it.
441
442 * xselect.c: Support for clipboard managers.
443 (Vselection_alist): Move to termhooks.h as terminal-local var.
444 (LOCAL_SELECTION): New macro.
445 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
446 (symbol_to_x_atom): Remove gratuitous arg.
447 (x_handle_selection_request, lisp_data_to_selection_data)
448 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
449 (x_own_selection, x_get_local_selection, x_convert_selection):
450 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
451 (some_frame_on_display): Delete unused function.
452 (Fx_own_selection_internal, Fx_get_selection_internal)
453 (Fx_disown_selection_internal, Fx_selection_owner_p)
454 (Fx_selection_exists_p): New optional frame arg.
455 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
456 (x_handle_selection_clear): Don't treat other terminals with the
457 same keyboard specially. Use the terminal-local Vselection_alist.
458 (x_clear_frame_selections): Use Frun_hook_with_args.
459
460 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
461
462 * xterm.h: Add support for those atoms.
463
e067f0c1
CY
4642011-05-26 Chong Yidong <cyd@stupidchicken.com>
465
466 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
467 (converted_selections, conversion_fail_tag): New global variables.
468 (x_selection_request_lisp_error): Free the above.
469 (x_get_local_selection): Remove unnecessary code.
470 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
471 of converted selections stored in converted_selections.
472 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
473 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
474 (x_convert_selection): New function.
475 (x_handle_selection_event): Simplify.
476 (x_get_foreign_selection): Don't ignore incoming requests while
477 waiting for an answer; this will fail when we implement
478 SAVE_TARGETS, and seems unnecessary anyway.
479 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
480 (Vx_sent_selection_functions): Doc fix.
481
0f4aebc0
LL
4822011-05-26 Leo Liu <sdl.web@gmail.com>
483
484 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
485
e61124cd
YM
4862011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
487
488 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
489
490 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
491 for fringe update if it has periodic bitmap.
492 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
493 and fringe_bitmap_periodic_p.
494
495 * fringe.c (get_fringe_bitmap_data): New function.
496 (draw_fringe_bitmap_1, update_window_fringes): Use it.
497 (update_window_fringes): Record periodicity of fringe bitmap in glyph
498 row. Mark glyph row for fringe update if periodicity changed.
499
500 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
501 for fringe update unless it has periodic bitmap.
502
f16d9837
KH
5032011-05-25 Kenichi Handa <handa@m17n.org>
504
505 * xdisp.c (get_next_display_element): Set correct it->face_id for
506 a static composition.
507
e1b90ef6
LL
5082011-05-24 Leo Liu <sdl.web@gmail.com>
509
510 * deps.mk (fns.o):
511 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
512
513 * fns.c (crypto_hash_function, Fsha1): New function.
514 (Fmd5): Use crypto_hash_function.
515 (syms_of_fns): Add Ssha1.
516
7400048f
PE
5172011-05-22 Paul Eggert <eggert@cs.ucla.edu>
518
519 * gnutls.c: Remove unused macros.
520 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
521 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
522 Remove macros that are defined and never used.
523 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
524
abb71cf4
CY
5252011-05-22 Chong Yidong <cyd@stupidchicken.com>
526
527 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
528 (Fx_get_selection_internal): Minor cleanup.
529 (Fx_own_selection_internal): Rename arguments for consistency with
530 select.el.
531
6307db39
PE
5322011-05-22 Paul Eggert <eggert@cs.ucla.edu>
533
534 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
535
f3d4e0a4
CY
5362011-05-22 Chong Yidong <cyd@stupidchicken.com>
537
538 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
539
4d8ade89
YM
5402011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
541
542 * dispnew.c (scrolling_window): Don't exclude the case that the
543 last enabled row in the desired matrix touches the bottom boundary.
544
32078c8d
GM
5452011-05-21 Glenn Morris <rgm@gnu.org>
546
547 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
548 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
549 and add some more files.
32078c8d 550
7285dc67
EZ
5512011-05-20 Eli Zaretskii <eliz@gnu.org>
552
553 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
554 report_file_error introduced by the change from 2011-05-07.
555
89d1bd22
PE
5562011-05-20 Paul Eggert <eggert@cs.ucla.edu>
557
558 * systime.h (Time): Define only if emacs is defined.
559 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
560 where the include path doesn't have X11/X.h by default. See
561 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
562
e23640bb 5632011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
564
565 * composite.c (find_automatic_composition): Fix previous change.
566
b9704ad9
GM
5672011-05-20 Glenn Morris <rgm@gnu.org>
568
569 * lisp.mk: New file, split from Makefile.in.
570 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
571 (shortlisp): Remove.
572 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
573
4a720484
GM
5742011-05-19 Glenn Morris <rgm@gnu.org>
575
576 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
577 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
578 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
579 (lisp): Set the order to that of loadup.el.
580 (shortlisp): Make it a copy of $lisp.
581 (SOME_MACHINE_LISP): Remove.
582 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
583 Use just $shortlisp, not $SOME_MACHINE_LISP too.
584
a28d4396
KH
5852011-05-18 Kenichi Handa <handa@m17n.org>
586
587 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
588 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
589 (find_automatic_composition): Mostly rewrite for efficiency.
590
a2b1fa8e
JB
5912011-05-18 Juanma Barranquero <lekktu@gmail.com>
592
593 * makefile.w32-in: Update dependencies.
594
8e1f5610
CS
5952011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
596
597 * menu.c: Include limits.h (fixes the MS-Windows build broken by
598 revision 104625).
599
7025ee00 6002011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 601
cdfa6eab
PE
602 Fix some integer overflow issues, such as string length overflow.
603
06d6db33
PE
604 * insdel.c (count_size_as_multibyte): Check for string overflow.
605
2b4560a8
PE
606 * character.c (lisp_string_width): Check for string overflow.
607 Use EMACS_INT, not int, for string indexes and lengths; in
608 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
609 the resulting string length overflows an EMACS_INT; instead,
610 report a string overflow if no precision given. When checking for
611 precision exhaustion, use a check that cannot possibly have
612 integer overflow. (Bug#8675)
613 * character.h (lisp_string_width): Adjust to new signature.
614
cb93f9be
PE
615 * alloc.c (string_overflow): New function.
616 (Fmake_string): Use it. This doesn't change behavior, but saves
617 a few bytes and will simplify future changes.
618 * character.c (string_escape_byte8): Likewise.
619 * lisp.h (string_overflow): New decl.
620
1a1f3366
PE
621 Fixups, following up to the user-interface timestamp change.
622 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
623 for UI timestamps, instead of unsigned long.
9fbd6841
PE
624 * msdos.c (mouse_get_pos): Likewise.
625 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
626 * w32gui.h (Time): Define by including "systime.h" rather than by
627 declaring it ourselves. (Bug#8664)
628
d4e3e4d3
PE
629 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
630 * image.c (clear_image_cache): Likewise.
631
f6a24d19
PE
632 * term.c (term_mouse_position): Don't assume time_t wraparound.
633
08dc5ae6
PE
634 Be more systematic about user-interface timestamps.
635 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
636 and sometimes 'EMACS_UINT', to represent these timestamps.
637 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
638 This makes the code easier to follow, and makes it easier to catch
639 integer overflow bugs such as Bug#8664.
640 * frame.c (Fmouse_position, Fmouse_pixel_position):
641 Use Time, not unsigned long, for user-interface timestamps.
642 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
643 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
644 * keyboard.h (last_event_timestamp): Likewise.
645 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
646 * menu.h (xmenu_show): Likewise.
647 * term.c (term_mouse_position): Likewise.
648 * termhooks.h (struct input_event.timestamp): Likewise.
649 (struct terminal.mouse_position_hook): Likewise.
650 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
651 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
652 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
653 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
654 what it was before.
655 * menu.h, termhooks.h: Include "systime.h", for Time.
656
8e55734a
PE
657 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
658 Don't assume that the difference between two unsigned long values
659 can fit into an integer. At this point, we know button_down_time
660 <= event->timestamp, so the difference must be nonnegative, so
661 there's no need to cast the result if double-click-time is
662 nonnegative, as it should be; check that it's nonnegative, just in
663 case. This bug is triggered when events are more than 2**31 ms
86db42d2 664 apart (about 25 days). (Bug#8664)
8e55734a 665
841f1b75 666 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 667 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 668
3e26f69c
PE
669 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
670 that always fit in int. Use a sentinel instead of a counter, to
671 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
672 * frame.h (struct frame): Use int for menu_bar_items_used
673 instead of EMACS_INT, since it always fits in int.
3e26f69c 674
5cc152c0
PE
675 * menu.c (grow_menu_items): Check for int overflow.
676
d89eb65e
PE
677 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
678
5235bd3e
PE
679 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
680 Before, the code was not consistent. These values cannot exceed
681 2**31 - 1 so there's no need to make them unsigned.
682 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
683 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
684 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
685 as modifiers.
686 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
687
bc827e23
PE
688 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
689 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
690 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
691 presumably because the widths might not match.
692
78eb494e
PE
693 * window.c (size_window): Avoid needless test at loop start.
694
04f2d78b
CB
6952011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
696
697 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
698
d2fc7e3d 6992011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
700
701 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
702
d2fc7e3d 7032011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
704
705 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
706 `width' to `bar_area_x' and `bar_area_width', respectively.
707 (x_scroll_run): Take account of fringe background extension.
708
04f2d78b
CB
709 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
710 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
711 `bar_area_width', respectively.
712 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
713 background extension.
714
79b70037
GM
7152011-05-10 Jim Meyering <meyering@redhat.com>
716
717 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
718
2f142cc5
JB
7192011-05-10 Juanma Barranquero <lekktu@gmail.com>
720
721 * image.c (Finit_image_library): Return t for built-in image types,
722 like pbm and xbm. (Bug#8640)
723
57679c86
AS
7242011-05-09 Andreas Schwab <schwab@linux-m68k.org>
725
726 * w32menu.c (set_frame_menubar): Fix submenu allocation.
727
888c9e86
EZ
7282011-05-07 Eli Zaretskii <eliz@gnu.org>
729
b0512a1d
EZ
730 * w32console.c (Fset_screen_color): Doc fix.
731 (Fget_screen_color): New function.
732 (syms_of_ntterm): Defsubr it.
733
7285dc67
EZ
734 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
735 unlink the temporary file if Fcall_process didn't create it in the
736 first place.
737 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
738 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
739 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
740 cue to call_process_cleanup not to close that handle.
741
4d3fcc8e
BK
7422011-05-07 Ben Key <bkey76@gmail.com>
743
744 * makefile.w32-in: The bootstrap-temacs rule now makes use of
745 one of two shell specific rules, either bootstrap-temacs-CMD or
746 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
747 to the previous implementation of the bootstrap-temacs rule.
748 The bootstrap-temacs-CMD rule is similar to the previous
749 implementation of the bootstrap-temacs rule except that it
750 makes use of the ESC_CFLAGS variable instead of the CFLAGS
751 variable.
752
753 These changes, along with some changes to nt/configure.bat,
754 nt/gmake.defs, and nt/nmake.defs, are required to extend my
755 earlier fix to add support for --cflags and --ldflags options
756 that include quotes so that it works whether make uses cmd or
757 sh as the shell.
758
b4289b64
MA
7592011-05-06 Michael Albinus <michael.albinus@gmx.de>
760
761 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
762 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
763 is a constant.
764 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
765 a string. Handle both cases.
766 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
767 (Fdbus_register_method): Use Qinvalid_function.
768
af4c0e28
JB
7692011-05-06 Juanma Barranquero <lekktu@gmail.com>
770
771 * makefile.w32-in: Update dependencies.
772 (LISP_H): Add inttypes.h and stdin.h.
773 (PROCESS_H): Add unistd.h.
774
c51453d9
EZ
7752011-05-06 Eli Zaretskii <eliz@gnu.org>
776
777 * lread.c: Include limits.h (fixes the MS-Windows build broken by
778 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
779
8ff0ac3c 7802011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 781
4c4b566b
PE
782 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
783
aab2b9b5
PE
784 * term.c (vfatal): Remove stray call to va_end.
785 It's not needed and the C Standard doesn't allow it here anyway.
786
c378da0b
PE
787 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
788 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
789
288b08c7
PE
790 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
791 bytes.
792
e3601888
PE
793 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
794
db6c0e74
PE
795 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
796
dd5963ea
PE
797 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
798
88c9450f
PE
799 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
800
2f9442b8
PE
801 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
802
c032b5f8
PE
803 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
804 * charset.c (Fdefine_charset_internal): Don't initialize
805 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 806 32-bit int (Bug#8600).
a108c10b
PE
807
808 * lread.c (read_integer): Be more consistent with string-to-number.
809 Use string_to_number to do the actual conversion; this avoids
810 rounding errors and fixes some other screwups. Without this fix,
811 for example, #x1fffffffffffffff was misread as -2305843009213693952.
812 (digit_to_number): Move earlier, for benefit of read_integer.
813 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 814 not a digit in any supported base. (Bug#8602)
a108c10b 815
ad5f9eea
PE
816 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
817
aec1708a
PE
818 * dispnew.c (scrolling_window): Return 1 if we scrolled,
819 to match comment at start of function. This also removes a
820 GCC warning about overflow in a 32+64-bit port.
821
47be4ab5
PE
822 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
823
371cac43
PE
824 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
825 Reported by Stefan Monnier in
826 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
827 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
828 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 829
d01a7826
PE
830 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
831 (EMACS_UINTPTR): Likewise, with uintptr_t.
832
7fd47d5c
PE
833 * lisp.h: Prefer 64-bit EMACS_INT if available.
834 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
835 on 32-bit hosts that have 64-bit int, so that they can access
836 large files.
122b0c86
PE
837 However, temporarily disable this change unless the temporary
838 symbol WIDE_EMACS_INT is defined.
7fd47d5c 839
8727937b
PE
840 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
841
8ac068ac
PE
842 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
843 This removes an assumption that EMACS_INT and long are the same
844 width as pointers. The assumption is true for Emacs porting targets
845 now, but we want to make other targets possible.
846 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
847 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
848 In the rest of the code, change types of integers that hold casted
849 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
850 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
851 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
852 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
853 No need to cast type when ORing.
854 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
855 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
856 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
857 assume EMACS_INT is the same width as char *.
858 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
859 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
860 Remove no-longer-needed casts.
861 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
862 (xg_tool_bar_help_callback, xg_make_tool_item):
863 Use EMACS_INTPTR to hold an integer
864 that will be cast to void *; this can avoid a GCC warning
865 if EMACS_INT is not the same width as void *.
866 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
867 * xdisp.c (display_echo_area_1, resize_mini_window_1):
868 (current_message_1, set_message_1):
869 Use a local to convert to proper width without a cast.
870 * xmenu.c (dialog_selection_callback): Likewise.
871
ede49d71
PE
872 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
873 Also, don't assume VALBITS / RAND_BITS is less than 5,
874 and don't rely on undefined behavior when shifting a 1 left into
875 the sign bit.
876 * lisp.h (get_random): Change signature to match.
877
2f30ecd0
PE
878 * lread.c (hash_string): Use size_t, not int, for hash computation.
879 Normally we prefer signed values; but hashing is special, because
880 it's better to use unsigned division on hash table sizes so that
881 the remainder is nonnegative. Also, size_t is the natural width
882 for hashing into memory. The previous code used 'int', which doesn't
883 retain enough info to hash well into very large tables.
884 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
885
2a866e7b
PE
886 * dbusbind.c: Don't possibly lose pointer info when converting.
887 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
888 Use XPNTR rather than XHASH, so that the high-order bits of
889 the pointer aren't lost when converting through void *.
890
51639eac
PE
891 * eval.c (Fautoload): Don't double-shift a pointer.
892
92394119
PE
893 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
894
dbdb9a7c
JB
8952011-05-06 Juanma Barranquero <lekktu@gmail.com>
896
897 * gnutls.c (DEF_GNUTLS_FN):
898 * image.c (DEF_IMGLIB_FN): Make function pointers static.
899
db7a0b4f
AS
9002011-05-05 Andreas Schwab <schwab@linux-m68k.org>
901
902 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
903 marker. (Bug#8610)
904
f7ff1b0f 9052011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
906
907 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
908 New version that can reserve upto 2GB of heap space.
909
f7ff1b0f 9102011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
911
912 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
913
639c109b
TZ
9142011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
915
916 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
917 `gnutls_certificate_set_x509_key_file'.
918
d2127135
JB
9192011-05-05 Juanma Barranquero <lekktu@gmail.com>
920
921 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
922 Update dependencies.
923
e968f4f3
JB
9242011-05-04 Juanma Barranquero <lekktu@gmail.com>
925
926 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
927 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
928 Remove unused parameter `fildes'.
929 * process.c (read_process_output, send_process): Don't pass it.
930
84d358f0
JB
9312011-05-04 Juanma Barranquero <lekktu@gmail.com>
932
933 Fix previous change: the library cache is defined in w32.c.
934 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
935 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
936
0898ca10
JB
9372011-05-04 Juanma Barranquero <lekktu@gmail.com>
938
939 Implement dynamic loading of GnuTLS on Windows.
940
941 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
942 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
943 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
944 Declare.
945
946 * gnutls.c (Qgnutls_dll): Define.
947 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
948 (gnutls_*): Declare function pointers.
949 (init_gnutls_functions): New function to initialize function pointers.
950 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
951 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
952 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
953 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
954 (emacs_gnutls_write, emacs_gnutls_read)
955 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
956 (Fgnutls_available_p): New function.
957 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
958 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
959 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
960
961 * image.c: Include w32.h.
962 (Vimage_type_cache): Delete.
963 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
964 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
965 (w32_delayed_load): Move to w32.c.
966
967 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
968
969 * w32.c (QCloaded_from, Vlibrary_cache): Define.
970 (w32_delayed_load): Move from image.c. When loading a library, record
971 its filename in the :loaded-from property of the library id.
972 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
973 Initialize and staticpro them.
974 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
975
976 * process.c: Include lisp.h before w32.h, not after.
977 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
978 instead of gnutls_record_check_pending.
979
980 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
981
ff4de4aa
TZ
9822011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
983
984 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
985 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
986 as passed in.
987
abe95abb
JD
9882011-05-03 Jan Djärv <jan.h.d@swipnet.se>
989
990 * xterm.c (x_set_frame_alpha): Do not set property on anything
991 else than FRAME_X_OUTER_WINDOW (Bug#8608).
992
e16e55d4
JB
9932011-05-02 Juanma Barranquero <lekktu@gmail.com>
994
995 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
996
bafcf6a5
JB
9972011-05-02 Juanma Barranquero <lekktu@gmail.com>
998
999 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1000 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1001 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1002 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1003 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1004 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1005 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1006 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1007 (Qgnutls_bootprop_callbacks_verify): Make static.
1008
e7a6747f
AS
10092011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1010
19ed11ba
AS
1011 * callproc.c: Indentation fixup.
1012
e7a6747f 1013 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1014 (wait_for_termination, interruptible_wait_for_termination):
1015 Move after wait_for_termination_1.
e7a6747f 1016
1ef14cb4
LMI
10172011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1018
1019 * sysdep.c (interruptible_wait_for_termination): New function
1020 which is like wait_for_termination, but allows keyboard
1021 interruptions.
1022
1023 * callproc.c (Fcall_process): Add (:file "file") as an option for
1024 the STDOUT buffer.
1025 (Fcall_process_region): Ditto.
1026
330d880c
EZ
10272011-04-30 Eli Zaretskii <eliz@gnu.org>
1028
8db90b73
EZ
1029 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1030 rather than `XVECTOR (FOO)->size'.
1031
330d880c
EZ
1032 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1033 inttypes.h, as a gnulib replacement is used if it not available in
1034 system headers.
1035
15cbd324
EZ
10362011-04-21 Eli Zaretskii <eliz@gnu.org>
1037
1038 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1039 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1040 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1041
1042 * coding.c (coding_alloc_by_realloc): Error out if destination
1043 will grow beyond MOST_POSITIVE_FIXNUM.
1044 (decode_coding_emacs_mule): Abort if there isn't enough place in
1045 charbuf for the composition carryover bytes. Reserve an extra
1046 space for up to 2 characters produced in a loop.
1047 (decode_coding_iso_2022): Abort if there isn't enough place in
1048 charbuf for the composition carryover bytes.
1049
10502011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1051
ae940cca
EZ
1052 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1053 aborting when %lld or %lll format is passed.
1054 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1055 %llo or %llx format is passed. (Bug#8545)
1056
03ab8921
EZ
1057 * window.c (window_scroll_line_based): Use a marker instead of
1058 simple variables to record original value of point. (Bug#7952)
1059
afda1437
EZ
1060 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1061 produced by %s or %c overflows available buffer space. (Bug#8545)
1062
f76dee0c
PE
10632011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1064
1065 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1066 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1067
fdc5744d
JB
10682011-04-28 Juanma Barranquero <lekktu@gmail.com>
1069
1070 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1071
638f053a
JB
10722011-04-28 Juanma Barranquero <lekktu@gmail.com>
1073
1074 * keyboard.c (Qdelayed_warnings_hook): Define.
1075 (command_loop_1): Run `delayed-warnings-hook'
1076 if Vdelayed_warnings_list is non-nil.
1077 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1078 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1079
d178f871
EZ
10802011-04-28 Eli Zaretskii <eliz@gnu.org>
1081
1082 * doprnt.c (doprnt): Don't return value smaller than the buffer
1083 size if the message was truncated. (Bug#8545).
1084
b124fd93
JB
10852011-04-28 Juanma Barranquero <lekktu@gmail.com>
1086
1087 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1088 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1089
e810457d
PE
10902011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1091
1092 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1093
ea51cceb
JB
10942011-04-27 Juanma Barranquero <lekktu@gmail.com>
1095
1096 * makefile.w32-in: Update dependencies.
1097
94dcfacf
EZ
10982011-04-27 Eli Zaretskii <eliz@gnu.org>
1099
1100 Improve `doprnt' and its usage. (Bug#8545)
1101 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1102 `format_end'. Remove support for %l as a conversion specifier.
1103 Don't use xrealloc. Improve diagnostics when the %l size modifier
1104 is used. Update the commentary.
1105
1106 * eval.c (verror): Simplify calculation of size_t.
1107
1108 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1109 messages.
1110
f61f41d7
PE
11112011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1112
1113 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1114 change.
1115
96fb4434
PE
11162011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1117
1118 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1119 This makes this file independent of the recent pseudovector change.
1120
671875da 11212011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1122
69e9b5a3
PE
1123 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1124
b5f869a7 1125 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1126 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1127 Remove unused local.
c8926152 1128 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1129
841a1577 1130 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1131 GCC 4.6.0 optimizes based on type-based alias analysis.
1132 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1133 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1134 != &v->size, and therefore "v->size = 1; b->size = 2; return
1135 v->size;" must therefore return 1. This assumption is incorrect
1136 for Emacs, since it type-puns struct Lisp_Vector * with many other
1137 types. To fix this problem, this patch adds a new type struct
f904488f 1138 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1139 and pseudovectors, and helps optimizing compilers not get fooled
1140 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1141 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1142 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1143 the size member.
eab3844f
PE
1144 (XSETPVECTYPE): Rewrite in terms of new macro.
1145 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1146 This is a bit clearer, and further avoids the possibility of
1147 undesirable aliasing.
1148 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1149 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1150 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1151 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1152 (ASIZE): Now uses header.size rather than size.
1153 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1154 to avoid the hassle of writing XVECTOR (foo)->header.size.
1155 (struct vectorlike_header): New type.
eab3844f
PE
1156 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1157 object, to help avoid aliasing.
1158 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1159 (SUBRP): Likewise, since Lisp_Subr is a special case.
1160 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1161 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1162 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1163 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1164 changed to be "header.size" and "header.next".
1165 * buffer.h (struct buffer): Likewise.
1166 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1167 * frame.h (struct frame): Likewise.
1168 * process.h (struct Lisp_Process): Likewise.
1169 * termhooks.h (struct terminal): Likewise.
1170 * window.c (struct save_window_data, struct saved_window): Likewise.
1171 * window.h (struct window): Likewise.
1172 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1173 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1174 * buffer.c (init_buffer_once): Likewise.
1175 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1176 special case.
1177 * process.c (Fformat_network_address): Use local var for size,
1178 for brevity.
1179
0df1eac5
PE
1180 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1181
847ab9d1 1182 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1183 * data.c (atof): Remove decl; no longer used or needed.
1184 (digit_to_number): Move to lread.c.
1185 (Fstring_to_number): Use new string_to_number function, to be
1186 consistent with how the Lisp reader treats infinities and NaNs.
1187 Do not assume that floating-point numbers represent EMACS_INT
1188 without losing information; this is not true on most 64-bit hosts.
1189 Avoid double-rounding errors, by insisting on integers when
1190 parsing non-base-10 numbers, as the documentation specifies.
1191 * lisp.h (string_to_number): New decl, replacing ...
1192 (isfloat_string): Remove.
bc0a5c13 1193 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1194 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1195 appears to have been a coding error. Similarly, do not accept
1196 strings like +-1e0 as floating point numbers. Do not report
1197 overflow for integer overflows unless the base is not 10 which
1198 means we have no simple and reliable way to continue.
1199 Break out the floating-point parsing into a new
1200 function string_to_number, so that Fstring_to_number parses
1201 floating point numbers consistently with the Lisp reader.
04f2d78b 1202 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1203 (E_CHAR, EXP_INT): Remove, replacing with ...
1204 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1205 (string_to_number): New function, replacing isfloat_string.
1206 This function checks for valid syntax and produces the resulting
1207 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1208 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1209 so that overflow for non-base-10 numbers is reported only when
1210 there's no portable and simple way to convert to floating point.
452f4150 1211
67769ffc
PE
1212 * textprop.c (set_text_properties_1): Rewrite for clarity,
1213 and to avoid GCC warning about integer overflow.
1214
c20db43f
PE
1215 * intervals.h (struct interval): Use EMACS_INT for members
1216 where EMACS_UINT might cause problems. See
1217 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1218 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1219 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1220 All uses changed.
37aa2f85
PE
1221 (offset_intervals): Tell GCC not to worry about length overflow
1222 when negating a negative length.
c20db43f 1223
2538aa2f
PE
1224 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1225 (overrun_check_free): Likewise.
1226
f2d3008d
PE
1227 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1228 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1229 word size.
1230
ec8df744
PE
1231 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1232 (gnutls_make_error): Rename local to avoid shadowing.
1233 (gnutls_emacs_global_deinit): ifdef out; not used.
1234 (Fgnutls_boot): Use const for pointer to readonly storage.
1235 Comment out unused local. Fix pointer signedness problems.
1236
640ee02d
PE
1237 * lread.c (openp): Don't stuff size_t into an 'int'.
1238 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1239 about possible signed overflow.
1240
6048fb2a
PE
1241 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1242 (GDK_KEY_g): Don't define if already defined.
1243 (xg_prepare_tooltip): Avoid pointer signedness problem.
1244 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1245
fa3c87e1
PE
1246 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1247 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1248
2172544b
PE
1249 * xfns.c (Fx_window_property): Simplify a bit,
1250 to make a bit faster and to avoid GCC 4.6.0 warning.
1251 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1252
9b821a21
PE
1253 * fns.c (internal_equal): Don't assume size_t fits in int.
1254
3c616cfa
PE
1255 * alloc.c (compact_small_strings): Tighten assertion a little.
1256
c2982e87
PE
1257 Replace pEd with more-general pI, and fix some printf arg casts.
1258 * lisp.h (pI): New macro, generalizing old pEd macro to other
1259 conversion specifiers. For example, use "...%"pI"d..." rather
1260 than "...%"pEd"...".
1261 (pEd): Remove. All uses replaced with similar uses of pI.
1262 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1263 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1264 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1265 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1266 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1267 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1268 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1269 64-bit hosts.
1270 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1271 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1272 * print.c (safe_debug_print, print_object): Likewise.
1273 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1274 to int.
6f04d126
PE
1275 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1276 avoiding the 0 flag, which is not portable.
c2982e87
PE
1277 * process.c (Fmake_network_process): Use pI to avoid cast.
1278 * region-cache.c (pp_cache): Likewise.
1279 * xdisp.c (decode_mode_spec): Likewise.
1280 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1281 behavior on 64-bit hosts with printf arg.
6f04d126 1282 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1283 (x_stop_queuing_selection_requests): Likewise.
1284 (x_get_window_property): Don't truncate byte count to an 'int'
1285 when tracing.
0b432f21 1286
5e073ec7
PE
1287 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1288 here, since it parses constructs like leading '-' and spaces,
1289 which are not wanted; and it overflows with large numbers.
1290 Instead, simply match F[0-9]+, which is what is wanted anyway.
1291
36372bf9
PE
1292 * alloc.c: Remove unportable assumptions about struct layout.
1293 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1294 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1295 (allocate_vectorlike, make_pure_vector): Use the new macros,
1296 plus offsetof, to remove unportable assumptions about struct layout.
1297 These assumptions hold on all porting targets that I know of, but
1298 they are not guaranteed, they're easy to remove, and removing them
1299 makes further changes easier.
1300
0b432f21
PE
1301 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1302 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1303 (string_overrun_cookie): Now const. Use initializers that
1304 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1305 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1306 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1307 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1308 multiple of sizeof (EMACS_INT); it need not be, if
1309 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1310 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1311
895009e1
JB
13122011-04-26 Juanma Barranquero <lekktu@gmail.com>
1313
1314 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1315
6a7a1b0b
TZ
13162011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1317
1318 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1319 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1320 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1321
841a1577 13222011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1323
1324 * lisp.h (Qdebug): List symbol.
895009e1 1325 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1326 * keyboard.c (debug-on-event): New variable.
1327 (handle_user_signal): Break into debugger when debug-on-event
1328 matches the current signal symbol.
1329
f2d3ba6f
DN
13302011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1331
1332 * alloc.c (check_sblock, check_string_bytes)
1333 (check_string_free_list): Convert to standard C.
1334
42ce4c63
TZ
13352011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1336
1337 * w32.c (emacs_gnutls_push): Fix typo.
1338
825cd63c
EZ
13392011-04-25 Eli Zaretskii <eliz@gnu.org>
1340
fb11d64d
EZ
1341 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1342 "cast to pointer from integer of different size".
1343
825cd63c
EZ
1344 Improve doprnt and its use in verror. (Bug#8545)
1345 * doprnt.c (doprnt): Document the set of format control sequences
1346 supported by the function. Use SAFE_ALLOCA instead of always
1347 using `alloca'.
1348
1349 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1350 is one byte too soon. Don't use xrealloc; instead xfree and
1351 xmalloc anew.
1352
e061a11b
TZ
13532011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1354
1355 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1356 callbacks stage.
1357
1358 * gnutls.c: Renamed global_initialized to
1359 gnutls_global_initialized. Added internals for the
1360 :verify-hostname-error, :verify-error, and :verify-flags
1361 parameters of `gnutls-boot' and documented those parameters in the
1362 docstring. Start callback support.
1363 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1364 unless a fatal error occured. Call gnutls_alert_send_appropriate
1365 on error. Return error code.
1366 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1367 (emacs_gnutls_read): Likewise.
1368 (Fgnutls_boot): Return handshake error code.
1369 (emacs_gnutls_handle_error): New function.
1370 (wsaerror_to_errno): Likewise.
1371
1372 * w32.h (emacs_gnutls_pull): Add prototype.
1373 (emacs_gnutls_push): Likewise.
1374
1375 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1376 (emacs_gnutls_push): Likewise.
1377
13782011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1379
1380 * process.c (wait_reading_process_output): Check if GnuTLS
1381 buffered some data internally if no FDs are set for TLS
1382 connections.
1383
1384 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1385 (LIBS): Link to USER_LIBS.
1386 ($(BLD)/gnutls.$(0)): New target.
1387
fa6996bc
EZ
13882011-04-24 Eli Zaretskii <eliz@gnu.org>
1389
eb35682e
EZ
1390 * xdisp.c (handle_single_display_spec): Rename the
1391 display_replaced_before_p argument into display_replaced_p, to
1392 make it consistent with the commentary. Fix typos in the
1393 commentary.
1394
e2ad650c
EZ
1395 * textprop.c (syms_of_textprop): Remove dead code.
1396 (copy_text_properties): Delete obsolete commentary about an
1397 interface that was deleted long ago. Fix typos in the description
1398 of arguments.
1399
1b2de274
EZ
1400 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1401 to changes in oldXMenu/XMenu.h from 2011-04-16.
1402 <menu_help_message, prev_menu_help_message>: Constify.
1403 (IT_menu_make_room): menu->help_text is now `const char **';
1404 adjust.
1405
1406 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1407 to changes in oldXMenu/XMenu.h from 2011-04-16.
1408 (struct XMenu): Declare `help_text' `const char **'.
1409
1410 * xfaces.c <Qunspecified>: Make extern again.
1411
1412 * syntax.c: Include sys/types.h before including regex.h, as
1413 required by Posix.
1414
762b15be
EZ
1415 * doc.c (get_doc_string): Improve the format passed to `error'.
1416
1417 * doprnt.c (doprnt): Improve commentary.
1418
1419 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1420
1421 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1422 them with etags.
1423
f1052e5d
EZ
1424 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1425 changes in globals.h immediately force recompilation.
762b15be
EZ
1426 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1427 $(CURDIR)/s/ms-w32.h.
1428 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1429
fa6996bc
EZ
1430 * character.c (Fchar_direction): Function deleted.
1431 (syms_of_character): Don't defsubr it.
1432 <char-direction-table>: Deleted.
1433
e6c3da20
EZ
14342011-04-23 Eli Zaretskii <eliz@gnu.org>
1435
1436 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1437 * doprnt.c: Include limits.h.
1438 (SIZE_MAX): New macro.
04f2d78b
CB
1439 (doprnt): Return a size_t value. 2nd arg is now size_t.
1440 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1441 Improve overflow protection. Support `l' modifier for integer
1442 conversions. Support %l conversion. Don't assume an EMACS_INT
1443 argument for integer conversions and for %c.
1444
1445 * lisp.h (doprnt): Restore prototype.
1446
1447 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1448 $(SRC)/character.h.
1449
1450 * Makefile.in (base_obj): Add back doprnt.o.
1451
1452 * deps.mk (doprnt.o): Add back prerequisites.
1453 (callint.o): Depend on character.h.
1454
1455 * eval.c (internal_lisp_condition_case): Include the handler
1456 representation in the error message.
1457 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1458 when breaking from the loop.
1459
1460 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1461
1462 * callint.c (Fcall_interactively): When displaying error message
1463 about invalid control letter, pass the character's codepoint, not
1464 a pointer to its multibyte form. Improve display of the character
1465 in octal and display also its hex code.
1466
1467 * character.c (char_string): Use %x to display the (unsigned)
1468 codepoint of an invalid character, to avoid displaying a bogus
1469 negative value.
1470
1471 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1472 `error', not SYMBOL_NAME itself.
1473
1474 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1475 character arguments to `error'.
1476
1477 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1478 to `error' in error message about FINAL_CHAR argument. Make sure
1479 FINAL_CHAR is a character, and use %c when it is passed as
1480 argument to `error'.
1481
4ffd0d6b 14822011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1483
1484 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1485
1486 * w32.c: Include <time.h>.
1487 (sys_localtime): New function.
1488
4ffd0d6b 14892011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1490
1491 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1492
4ffd0d6b 1493 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1494
4ffd0d6b 14952011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1496
4ffd0d6b
GM
1497 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1498 zombies (Bug#8467).
aac0c6e3 1499
04c56954
EZ
15002011-04-19 Eli Zaretskii <eliz@gnu.org>
1501
1502 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1503 gl_state.e_property when gl_state.object is Qt.
1504
1505 * insdel.c (make_gap_larger): Remove limitation of buffer size
1506 to <= INT_MAX.
1507
16a43933
CY
15082011-04-18 Chong Yidong <cyd@stupidchicken.com>
1509
1510 * xdisp.c (lookup_glyphless_char_display)
1511 (produce_glyphless_glyph): Handle cons cell entry in
1512 glyphless-char-display.
1513 (Vglyphless_char_display): Document it.
1514
1515 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1516 glyphless-char-display.
1517
4581706e
CY
15182011-04-17 Chong Yidong <cyd@stupidchicken.com>
1519
1520 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1521
1522 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1523
1524 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1525 definition for no-X builds.
1526
4887c6e2 15272011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1528
fd35b6f9
PE
1529 Static checks with GCC 4.6.0 and non-default toolkits.
1530
5c1ccb01
PE
1531 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1532
006c5daa
PE
1533 * process.c (keyboard_bit_set): Define only if SIGIO.
1534 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1535 (send_process): Repair possible setjmp clobbering.
1536
efc736d3
PE
1537 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1538
4e2fe2e6
PE
1539 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1540
f97334a2
PE
1541 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1542
4e75f29d
PE
1543 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1544 Define only if needed.
1545
90efadd1
PE
1546 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1547 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1548 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1549
3c647824
PE
1550 * dispextern.h (struct redisplay_interface): Rename param
1551 to avoid shadowing.
e264f262 1552 * termhooks.h (struct terminal): Likewise.
761383f4 1553 * xterm.c (xembed_send_message): Likewise.
3c647824 1554
b58c5c4a
PE
1555 * insdel.c (make_gap_smaller): Define only if
1556 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1557
cad59032
PE
1558 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1559 it.
1560
c339dc2e
PE
1561 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1562 so that we aren't warned about unused symbols.
1563
91a3e27b
PE
1564 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1565
399c71d3 1566 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1567
8ffc96f5
PE
1568 * xfns.c (x_real_positions): Mark locals as initialized.
1569
eef9bc79
PE
1570 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1571
098db9dd
PE
1572 * xterm.c: Fix problems found by static analysis with other toolkits.
1573 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1574 (x_dispatch_event): Declare static if USE_GTK, and
1575 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1576 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1577 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1578 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1579 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1580
eb18f6cc
PE
1581 * xmenu.c (menu_help_callback): Pointer type fixes.
1582 Use const pointers when pointing at readonly data. Avoid pointer
1583 signedness clashes.
1584 (FALSE): Remove unused macro.
1585 (update_frame_menubar): Remove unused decl.
1586
1fe72bf8
PE
1587 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1588
60d9e1db
PE
1589 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1590 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1591 (single_menu_item): Rename local to avoid shadowing.
1592
39261c26
PE
1593 * keyboard.c (make_lispy_event): Remove unused local var.
1594
018c5e19
PE
1595 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1596 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1597
63d2b86e
PE
1598 * bitmaps: Change bitmaps from unsigned char back to the X11
1599 compatible char. Avoid the old compiler warnings about
1600 out-of-range initializers by using, for example, '\xab' rather
1601 than 0xab.
1602
aefd87e1
PE
1603 * xgselect.c (xgselect_initialize): Check vs interface
1604 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1605
bf501fb9
PE
1606 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1607
e9829fdf
PE
1608 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1609 to read-only memory.
1610
1086c095
PE
1611 * fns.c (vector): Remove; this old hack is no longer needed.
1612
2baccd04 1613 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1614 Remove unused var.
dde42981 1615 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1616
72391843 1617 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1618
436c16df 1619 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1620 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1621 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1622
92bb796d 1623 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1624 (x_term_init): Remove local to avoid shadowing.
92bb796d 1625
764430a3 1626 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1627
1628 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1629 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1630
d1dfb56c
EZ
16312011-04-16 Eli Zaretskii <eliz@gnu.org>
1632
c4354cb4
EZ
1633 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1634
d1dfb56c
EZ
1635 Fix regex.c, syntax.c and friends for buffers > 2GB.
1636 * syntax.h (struct gl_state_s): Declare character position members
1637 EMACS_INT.
1638
1639 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1640
04f2d78b
CB
1641 * textprop.c (verify_interval_modification, interval_of):
1642 Declare arguments EMACS_INT.
d1dfb56c
EZ
1643
1644 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1645 EMACS_INT.
1646
1647 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1648
1649 * indent.c (Fvertical_motion): Local variable it_start is now
1650 EMACS_INT.
1651
1652 * regex.c (re_match, re_match_2, re_match_2_internal)
1653 (bcmp_translate, regcomp, regexec, print_double_string)
1654 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1655 (re_compile_pattern, re_exec): Declare arguments and local
1656 variables `size_t' and `ssize_t' and return values `regoff_t', as
1657 appropriate.
1658 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1659 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1660 <compile_stack_type>: `size' and `avail' are now `size_t'.
1661
1662 * regex.h <regoff_t>: Use ssize_t, not int.
1663 (re_search, re_search_2, re_match, re_match_2): Arguments that
1664 specify buffer/string position and length are now ssize_t and
1665 size_t. Return type is regoff_t.
1666
613052cd
BK
16672011-04-16 Ben Key <bkey76@gmail.com>
1668
1669 * nsfont.m: Fixed bugs in ns_get_family and
1670 ns_descriptor_to_entity that were caused by using free to
1671 deallocate memory blocks that were allocated by xmalloc (via
1672 xstrdup). This caused Emacs to crash when compiled with
1673 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1674 --enable-checking=xmallocoverrun). xfree is now used to
1675 deallocate these memory blocks.
1676
4170f62f 16772011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1678
71b41406
PE
1679 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1680
9587a89d
PE
1681 emacs_write: Accept and return EMACS_INT for sizes.
1682 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1683 et seq.
1684 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1685 Accept and return EMACS_INT.
1686 (emacs_gnutls_write): Return the number of bytes written on
1687 partial writes.
1688 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1689 (emacs_read, emacs_write): Remove check for negative size, as the
1690 Emacs source code has been audited now.
9587a89d
PE
1691 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1692 (emacs_read, emacs_write): Use it.
273a5f82
PE
1693 * process.c (send_process): Adjust to the new signatures of
1694 emacs_write and emacs_gnutls_write. Do not attempt to store
1695 a byte offset into an 'int'; it might overflow.
9587a89d 1696 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1697
3e047f51
PE
1698 * sound.c: Don't assume sizes fit in 'int'.
1699 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1700 Return EMACS_INT, not int.
3e047f51 1701 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1702 Accept EMACS_INT, not int.
1703 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1704 record read return values.
1705
cc39a9db
BK
17062011-04-15 Ben Key <bkey76@gmail.com>
1707
c9d0ec6d
JB
1708 * keyboard.c (Qundefined): Don't declare static since it is used
1709 in nsfns.m.
1710 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1711 static since they are used in nsfont.m.
cc39a9db 1712
6c60eb9f
SM
17132011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1714
1715 * process.c (Qprocessp): Don't declare static.
1716 * lisp.h (Qprocessp): Declare again.
1717
7990b61a
JB
17182011-04-15 Juanma Barranquero <lekktu@gmail.com>
1719
1720 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1721
5d4cb038
PE
17222011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1723
8bd7b830 1724 Improve C-level modularity by making more things 'static'.
cd64ea1d 1725
e3b27b31
PE
1726 Don't publish debugger-only interfaces to other modules.
1727 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1728 (verify_bytepos, count_markers): Move decls to the only modules
1729 that need them.
1730 * region-cache.h (pp_cache): Likewise.
1731 * window.h (check_all_windows): Likewise.
1732 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1733
5d4cb038
PE
1734 * sysdep.c (croak): Now static, if
1735 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1736 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1737
1738 * alloc.c (refill_memory_reserve): Now static if
1739 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1740 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1741
e87b6180
PE
1742 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1743 Define only if USE_LUCID.
1744
ac64929e
PE
1745 * xrdb.c (x_customization_string, x_rm_string): Now static.
1746
6f37259d
PE
1747 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1748 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1749
1683e3ab
PE
1750 * xdisp.c (draw_row_with_mouse_face): Now static.
1751 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1752
de9c2632
PE
1753 * window.h (check_all_windows): Mark externally visible.
1754
2b96acb7
PE
1755 * window.c (window_deletion_count): Now static.
1756
1757 * undo.c: Make symbols static if they're not exported.
1758 (last_undo_buffer, last_boundary_position, pending_boundary):
1759 Now static.
1760
50436f33
PE
1761 * textprop.c (interval_insert_behind_hooks): Now static.
1762 (interval_insert_in_front_hooks): Likewise.
1763
64520e5c
PE
1764 * term.c: Make symbols static if they're not exported.
1765 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1766 (max_frame_lines, tty_set_terminal_modes):
1767 (tty_reset_terminal_modes, tty_turn_off_highlight):
1768 (get_tty_terminal): Now static.
1769 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1770 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1771 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1772 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1773 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1774
1fa53021
PE
1775 * sysdep.c: Make symbols static if they're not exported.
1776 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1777 Now static.
1778 (sigprocmask_set, full_mask): Remove; unused.
1779 (wait_debugging): Mark as visible.
1780 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1781 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1782
d4b43b22
PE
1783 * syntax.c (syntax_temp): Define only if !__GNUC__.
1784
b7c513d0
PE
1785 * sound.c (current_sound_device, current_sound): Now static.
1786
989b29ad
PE
1787 * search.c (searchbufs, searchbuf_head): Now static.
1788
13a55a78
PE
1789 * scroll.c (scroll_cost): Remove; unused.
1790 * dispextern.h (scroll_cost): Remove decl.
1791
de68a1fc
PE
1792 * region-cache.h (pp_cache): Mark as externally visible.
1793
40ccffa6
PE
1794 * process.c: Make symbols static if they're not exported.
1795 (process_tick, update_tick, create_process, chan_process):
1796 (Vprocess_alist, proc_buffered_char, datagram_access):
1797 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1798 (deactivate_process): Mark defn as static, as well as decl.
1799 * lisp.h (create_process): Remove decl.
1800 * process.h (chan_process, Vprocess_alist): Remove decls.
1801
ad64fc97
PE
1802 * print.c: Make symbols static if they're not exported.
1803 (print_depth, new_backquote_output, being_printed, print_buffer):
1804 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1805 (print_interval, print_number_index, initial_stderr_stream):
1806 Now static.
1807 * lisp.h (Fprinc): Remove decl.
1808 (debug_output_compilation_hack): Mark as externally visible.
1809
adddb265
PE
1810 * sysdep.c (croak): Move decl from here to syssignal.h.
1811 * syssignal.h (croak): Put it here, so the API can be checked when
1812 'croak' is called from dissociate_if_controlling_tty.
1813
1717ede2
PE
1814 * minibuf.c: Make symbols static if they're not exported.
1815 (minibuf_save_list, choose_minibuf_frame): Now static.
1816 * lisp.h (choose_minibuf_frame): Remove decl.
1817
fa5fb2bc
PE
1818 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1819
1e3890d1
PE
1820 * lread.c: Make symbols static if they're not exported.
1821 (read_objects, initial_obarray, oblookup_last_bucket_number):
1822 Now static.
1823 (make_symbol): Remove; unused.
1824 * lisp.h (initial_obarray, make_symbol): Remove decls.
1825
8a1414fa
PE
1826 * keyboard.c: Make symbols static if they're not exported.
1827 (single_kboard, recent_keys_index, total_keys, recent_keys):
1828 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1829 (this_single_command_key_start, echoing, last_auto_save):
1830 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1831 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1832 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1833 (Vlispy_mouse_stem, double_click_count):
1834 Now static.
1835 (force_auto_save_soon): Define only if SIGDANGER.
1836 (ignore_mouse_drag_p): Now static if
1837 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1838 (print_help): Remove; unused.
1839 (stop_character, last_timer_event): Mark as externally visible.
1840 * keyboard.h (ignore_mouse_drag_p): Declare only if
1841 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1842 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1843 * lisp.h (echoing): Remove decl.
1844 (force_auto_save_soon): Declare only if SIGDANGER.
1845 * xdisp.c (redisplay_window): Simplify code, to make it more
1846 obvious that ignore_mouse_drag_p is not accessed if !defined
1847 USE_GTK && !defined HAVE_NS.
1848
93ea6e8f
PE
1849 * intervals.c: Make symbols static if they're not exported.
1850 (merge_properties_sticky, merge_interval_right, delete_interval):
1851 Now static.
1852 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1853
77382fcc
PE
1854 * insdel.c: Make symbols static if they're not exported.
1855 However, leave prepare_to_modify_buffer alone. It's never
1856 called from outside this function, but that appears to be a bug.
1857 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1858 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1859 (adjust_after_replace_noundo): Remove; unused.
1860 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1861 (signal_before_change): Remove decls.
77382fcc 1862
9306c32e
PE
1863 * indent.c (val_compute_motion, val_vmotion): Now static.
1864
cd44d2eb
PE
1865 * image.c: Make symbols static if they're not exported.
1866 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1867 if USE_GTK.
1868 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1869 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1870
ad9a7a06
PE
1871 * fringe.c (standard_bitmaps): Now static.
1872 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1873
81626931
PE
1874 * frame.c: Make symbols static if they're not exported.
1875 (x_report_frame_params, make_terminal_frame): Now static.
1876 (get_frame_param): Now static, unless HAVE_NS.
1877 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1878 (x_get_resource_string): Remove; not used.
1879 * frame.h (make_terminal_frame, x_report_frame_params):
1880 (x_get_resource_string); Remove decls.
1881 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1882 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1883
239f9db9
PE
1884 * font.c, fontset.c: Make symbols static if they're not exported.
1885 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1886 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1887 * font.c (font_close_object): Now static.
1888 * font.h (font_close_object): Remove.
1889 * fontset.c (FONTSET_OBJLIST): Remove.
1890 (free_realized_fontset) #if-0 the body, which does nothing.
1891 (face_suitable_for_char_p): #if-0, as it's never called.
1892 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
1893 * xfaces.c (face_at_string_position):
1894 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
1895 since 0 is always ASCII.
1896
dfcf3579
PE
1897 * fns.c (weak_hash_tables): Now static.
1898
5045092b
PE
1899 * fileio.c: Make symbols static if they're not exported.
1900 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1901 (Vwrite_region_annotation_buffers): Now static.
1902
57a96f5c
PE
1903 * eval.c: Make symbols static if they're not exported.
1904 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1905 * lisp.h (backtrace_list): Remove decl.
1906
35f08c38
PE
1907 * emacs.c: Make symbols static if they're not exported.
1908 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1909 (fatal_error_code, fatal_error_signal_hook, standard_args):
1910 Now static.
1911 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1912 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1913 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1914 * lisp.h (fatal_error_signal_hook): Remove decl.
1915 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1916
f44bd759
PE
1917 * editfns.c: Move a (normally-unused) function to its only use.
1918 * editfns.c, lisp.h (get_operating_system_release): Remove.
1919 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1920 worth the hassle of breaking this out.
1921
b532497d
PE
1922 * xterm.c: Make symbols static if they're not exported.
1923 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1924 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1925 (x_destroy_window, x_delete_display):
1926 Now static.
1927 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1928 (x_mouse_leave): Remove; unused.
1929 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1930 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1931 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1932 Remove decls.
1933 (x_mouse_leave): Declare only if WINDOWSNT.
1934 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1935 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1936 USE_X_TOOLKIT.
1937
1675728f
PE
1938 * ftxfont.c: Make symbols static if they're not exported.
1939 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1940 HAVE_FREETYPE.
1941 * font.h (ftxfont_driver): Likewise.
1942
e4cebfca
PE
1943 * xfns.c: Make symbols static if they're not exported.
1944 (x_last_font_name, x_display_info_for_name):
1945 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1946 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1947 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1948 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1949 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1950 (last_show_tip_args): Now static.
1951 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1952 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1953 (x_screen_planes): Remove; unused.
1954 * dispextern.h (x_screen_planes): Remove decl.
1955
5bf46f05
PE
1956 * dispnew.c: Make symbols static if they're not exported.
1957 * dispextern.h (redraw_garbaged_frames, scrolling):
1958 (increment_row_positions): Remove.
1959 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1960 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1961 Now static.
1962 (redraw_garbaged_frames): Remove; unused.
1963
435f4c28
PE
1964 * xfaces.c: Make symbols static if they're not exported.
1965 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1966 Remove decls.
1967 * xterm.h (defined_color): Remove decls.
1968 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1969 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1970 (menu_face_changed_default, defined_color, free_realized_face):
1971 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1972 (ascii_face_of_lisp_face): Remove; unused.
1973
8524aef3
PE
1974 * xdisp.c: Make symbols static if they're not exported.
1975 * dispextern.h (scratch_glyph_row, window_box_edges):
1976 (glyph_to_pixel_coords, set_cursor_from_row):
1977 (get_next_display_element, set_iterator_to_next):
1978 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1979 (show_mouse_face): Remove decls
1980 * frame.h (message_buf_print): Likewise.
1981 * lisp.h (pop_message, set_message, check_point_in_composition):
1982 Likewise.
1983 * xterm.h (set_vertical_scroll_bar): Likewise.
1984 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1985 (message_buf_print, scratch_glyph_row, displayed_buffer):
1986 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1987 (get_next_display_element, show_mouse_face, window_box_edges):
1988 (frame_to_window_pixel_xy, check_point_in_composition):
1989 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1990 (glyph_to_pixel_coords): Remove; unused.
1991
16390cd2
PE
1992 * dired.c (file_name_completion): Now static.
1993
1994 * dbusbind.c (xd_in_read_queued_messages): Now static.
1995
a25f4dfa
PE
1996 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1997 * data.c (circular_list_error): Remove.
1998
14a9c8df
PE
1999 * commands.h (last_point_position, last_point_position_buffer):
2000 (last_point_position_window): Remove decls.
2001 * keyboard.c: Make these variables static.
2002
04f2d78b
CB
2003 * coding.h (coding, code_convert_region, encode_coding_gap):
2004 Remove decls.
74ab6df5
PE
2005 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2006 (iso_code_class, detect_coding, code_convert_region): Now static.
2007 (encode_coding_gap): Remove; unused.
2008
38dfbee1
PE
2009 * chartab.c (chartab_chars, chartab_bits): Now static.
2010
a2cb4e63
PE
2011 * charset.h (charset_iso_8859_1): Remove decl.
2012 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2013 Now static.
2014
127198fd
PE
2015 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2016 * ccl.c (Vccl_program_table): Now static.
2017 (check_ccl_update): Remove; unused.
2018
d85b608f
PE
2019 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2020 * category.h: ... from here.
2021 * category.c (check_category_table, set_category_set): Now static.
2022
31cd66f3
PE
2023 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2024 * lisp.h: Remove these decls.
2025
c358e587
PE
2026 * buffer.c (buffer_count): Remove unused var.
2027
e78aecca
PE
2028 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2029 so that it's not optimized away.
2030 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2031 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2032 exported only to the debugger.
2033
e192d7d3 2034 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2035 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2036
92470028
PE
2037 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2038 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2039 was inaccessible from Lisp.
2040 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2041 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2042
244ed907
PE
2043 alloc.c: Import and export fewer symbols, and remove unused items.
2044 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2045 is defined.
2046 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2047 it's not optimized away by whole-program optimization.
2048 (message_enable_multibyte, free_misc): Remove.
2049 (catchlist, handlerlist, mark_backtrace):
2050 Declare only if BYTE_MARK_STACK.
2051 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2052 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2053 (message_enable_multibyte): Remove decl.
2054 (free_misc, interval_free_list, float_block, float_block_index):
2055 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2056 (cons_free_list, last_marked_index):
2057 Now static.
2058 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2059 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2060 (mark_backtrace): Define only if BYTE_MARK_STACK.
2061 * xdisp.c (message_enable_multibyte): Now static.
2062
61c2b50e 2063 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2064 This makes it easier for human readers (and static analyzers)
2065 to see whether these variables are used from other modules.
2066 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2067 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2068 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2069 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2070 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2071 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2072 * xmenu.c, xselect.c:
2073 Declare Q* vars static if they are not used in other modules.
2074 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2075 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2076 Remove decls of unexported vars.
2077 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2078
95c82688
PE
2079 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2080
16a97296
PE
2081 Make Emacs functions such as Fatom 'static' by default.
2082 This makes it easier for human readers (and static analyzers)
2083 to see whether these functions can be called from other modules.
2084 DEFUN now defines a static function. To make the function external
2085 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2086 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2087 (Finit_image_library):
16a97296
PE
2088 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2089 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2090 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2091 Remove decls, since these functions are now static.
2092 (Funintern, Fget_internal_run_time): New decls, since these functions
2093 were already external.
95c82688 2094
16a97296
PE
2095 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2096 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2097 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2098 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2099 * keyboard.c, keymap.c, lread.c:
2100 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2101 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2102 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2103 Mark functions with DEFUE instead of DEFUN,
2104 if they are used in other modules.
2105 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2106 decls for now-static functions.
2107 * buffer.h (Fdelete_overlay): Remove decl.
2108 * callproc.c (Fgetenv_internal): Mark as internal.
2109 * composite.c (Fremove_list_of_text_properties): Remove decl.
2110 (Fcomposition_get_gstring): New forward static decl.
2111 * composite.h (Fcomposite_get_gstring): Remove decl.
2112 * dired.c (Ffile_attributes): New forward static decl.
2113 * doc.c (Fdocumntation_property): New forward static decl.
2114 * eval.c (Ffetch_bytecode): New forward static decl.
2115 (Funintern): Remove extern decl; now in .h file where it belongs.
2116 * fileio.c (Fmake_symbolic_link): New forward static decl.
2117 * image.c (Finit_image_library): New forward static decl.
2118 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2119 * intervals.h (Fprevious_property_change):
2120 (Fremove_list_of_text_properties): Remove decls.
2121 * keyboard.c (Fthis_command_keys): Remove decl.
2122 (Fcommand_execute): New forward static decl.
2123 * keymap.c (Flookup_key): New forward static decl.
2124 (Fcopy_keymap): Now static.
2125 * keymap.h (Flookup_key): Remove decl.
2126 * process.c (Fget_process): New forward static decl.
2127 (Fprocess_datagram_address): Mark as internal.
2128 * syntax.c (Fsyntax_table_p): New forward static decl.
2129 (skip_chars): Remove duplicate decl.
2130 * textprop.c (Fprevious_property_change): New forward static decl.
2131 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2132 Now internal.
2133 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2134 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2135
785bbd42
PE
2136 * editfns.c (Fformat): Remove unreachable code.
2137
8b913b57
AS
21382011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2139
2140 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2141 change. (Bug#8496)
2142
a6744a35
EZ
21432011-04-13 Eli Zaretskii <eliz@gnu.org>
2144
2145 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2146 when at ZV. (Bug#8487)
2147
e7974947
AS
21482011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2149
baad03f0
AS
2150 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2151 (Bug#8437)
2152 * keyboard.c (parse_tool_bar_item): Likewise.
2153 * sound.c (sound_cleanup, alsa_close): Likewise.
2154 * termcap.c (tgetent): Likewise.
2155 * xfns.c (x_default_font_parameter): Likewise.
2156 * xsettings.c (read_and_apply_settings): Likewise.
2157
e7974947
AS
2158 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2159 (overrun_check_free): Protoize.
2160
28272684
PE
21612011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2162
2163 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2164 since callers should never pass a negative size.
2165 Change the signature to match that of plain 'read' and 'write'; see
2166 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2167 * lisp.h: Update prototypes of emacs_write and emacs_read.
2168
11997c76
EZ
21692011-04-11 Eli Zaretskii <eliz@gnu.org>
2170
2171 * xdisp.c (redisplay_window): Don't try to determine the character
2172 position of the scroll margin if the window start point w->startp
e896f03c 2173 is outside the buffer's accessible region. (Bug#8468)
11997c76 2174
8a2cbd72
EZ
21752011-04-10 Eli Zaretskii <eliz@gnu.org>
2176
2177 Fix write-region and its subroutines for buffers > 2GB.
2178 * fileio.c (a_write, e_write): Modify declaration of arguments and
2179 local variables to support buffers larger than 2GB.
2180 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2181
2182 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2183 argument, local variables, and return value.
2184
2185 * lisp.h: Update prototypes of emacs_write and emacs_read.
2186
2187 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2188
4073e537 21892011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2190
1ebfdcb6
PE
2191 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2192
b2ded58d
PE
2193 Fix more problems found by GCC 4.6.0's static checks.
2194
7d66342c
PE
2195 * xdisp.c (vmessage): Use a better test for character truncation.
2196
bbf47d44
PE
2197 * charset.c (load_charset_map): <, not <=, for optimization,
2198 and to avoid potential problems with integer overflow.
9248994d 2199 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2200 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2201 * editfns.c (Fformat): Likewise.
1e69125e 2202 * syntax.c (skip_chars): Likewise.
3befa583 2203
e3019616
PE
2204 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2205 This also lets GCC 4.6.0 generate slightly better loop code.
2206
becfa255
PE
2207 * callint.c (Fcall_interactively): <, not <=, for optimization.
2208 (Fcall_interactively): Count the number of arguments produced,
2209 not the number of arguments given. This is simpler and lets GCC
2210 4.6.0 generate slightly better code.
2211
dae0cd48
PE
2212 * ftfont.c: Distingish more carefully between FcChar8 and char.
2213 The previous code passed unsigned char * to a functions like
2214 strlen and xstrcasecmp that expect char *, which does not
2215 conform to the C standard.
2216 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2217 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2218 char * when the C standard requires it.
2219
76032d70
PE
2220 * keyboard.c (read_char): Remove unused var.
2221
eb3f1cc8
PE
2222 * eval.c: Port to Windows vsnprintf (Bug#8435).
2223 Include <limits.h>.
2224 (SIZE_MAX): Define if the headers do not.
2225 (verror): Do not give up if vsnprintf returns a negative count.
2226 Instead, grow the buffer. This ports to Windows vsnprintf, which
2227 does not conform to C99. Problem reported by Eli Zaretskii.
2228 Also, simplify the allocation scheme, by avoiding the need for
2229 calling realloc, and removing the ALLOCATED variable.
2230
70476b54
PE
2231 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2232
12020a9e
PE
2233 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2234 But keep the doprint source code for now, as we might revamp it
2235 and use it again (Bug#8435).
ea6c7ae6
PE
2236 * lisp.h (doprnt): Remove.
2237 * Makefile.in (base_obj): Remove doprnt.o.
2238 * deps.mk (doprnt.o): Remove.
2239
5fdb398c
PE
2240 error: Print 32- and 64-bit integers portably (Bug#8435).
2241 Without this change, on typical 64-bit hosts error ("...%d...", N)
2242 was used to print both 32- and 64-bit integers N, which relied on
2243 undefined behavior.
2244 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2245 New macro.
2246 * lisp.h (error, verror): Mark as printf-like functions.
2247 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2248 Report overflow in size calculations when allocating printf buffer.
2249 Do not truncate output string at its first null byte.
2250 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2251 Truncate the output at a character boundary, since vsnprintf does not
2252 do that.
2253 * charset.c (check_iso_charset_parameter): Convert internal
2254 character to string before calling 'error', since %c now has the
2255 printf meaning.
2256 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2257 overflow when computing char to be passed to 'error'. Do not
2258 pass Lisp_Object to 'error'; pass the integer instead.
2259 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2260 formatted with plain %d.
2261
b189fa66
PE
2262 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2263
bff87ef0
PE
2264 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2265
7e2cac20
PE
2266 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2267
ce4d90b5
PE
2268 * xterm.c (x_catch_errors): Remove duplicate declaration.
2269
266c9547
PE
2270 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2271
79c49ad2
PE
2272 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2273
368f4090
JM
22742011-04-10 Jim Meyering <meyering@redhat.com>
2275
2276 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2277 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2278 return ssize_t not "int", and use size_t as the buffer length.
2279 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2280 * gnutls.h: Update declarations.
2281 * process.c (read_process_output): Use ssize_t, to match.
2282 (send_process): Likewise.
2283
a32d4040
CY
22842011-04-09 Chong Yidong <cyd@stupidchicken.com>
2285
2286 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2287
8546720e 22882011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2289
04f2d78b
CB
2290 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2291 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2292
8546720e
GM
2293 * xterm.c (handle_one_xevent):
2294 * xmenu.c (create_and_show_popup_menu):
2295 * xselect.c (x_decline_selection_request)
2296 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2297
0a2f5c1a 22982011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2299
2300 Fix some uses of `int' instead of EMACS_INT.
2301 * search.c (string_match_1, fast_string_match)
2302 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2303 (scan_buffer, find_next_newline_no_quit)
2304 (find_before_next_newline, search_command, Freplace_match)
2305 (Fmatch_data): Make some `int' variables be EMACS_INT.
2306
2307 * xdisp.c (display_count_lines): 3rd argument and return value now
2308 EMACS_INT. All callers changed.
2309 (pint2hrstr): Last argument is now EMACS_INT.
2310
2311 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2312 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2313 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2314 (decode_coding_utf_16, decode_coding_emacs_mule)
2315 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2316 (decode_coding_ccl, decode_coding_charset)
2317 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2318 (decode_coding_iso_2022, decode_coding_emacs_mule)
2319 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2320 <char_offset, last_offset>: Declare EMACS_INT.
2321 (encode_coding_utf_8, encode_coding_utf_16)
2322 (encode_coding_emacs_mule, encode_invocation_designation)
2323 (encode_designation_at_bol, encode_coding_iso_2022)
2324 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2325 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2326 Declare EMACS_INT.
2327 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2328 (encode_invocation_designation): Last argument P_NCHARS is now
2329 EMACS_INT.
2330 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2331 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2332
2333 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2334 All users changed.
2335
2336 * ccl.c (Fccl_execute_on_string): Declare some variables
2337 EMACS_INT.
2338
8546720e 23392011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2340
2341 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2342
4e19a977
CS
23432011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2344
2345 * process.c (Fformat_network_address): Doc fix.
2346
87302331
R
23472011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2348
2349 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2350
cbb59342
CY
23512011-04-08 Chong Yidong <cyd@stupidchicken.com>
2352
2353 * keyboard.c (read_char): Call Lisp function help-form-show,
2354 instead of using internal_with_output_to_temp_buffer.
2355 (Qhelp_form_show): New var.
e0d38eeb 2356 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2357
2358 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2359
2360 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2361
e67a13ab
CY
23622011-04-06 Chong Yidong <cyd@stupidchicken.com>
2363
04f2d78b
CB
2364 * process.c (Flist_processes): Remove to Lisp.
2365 (list_processes_1): Delete.
e67a13ab 2366
973f782d
EZ
23672011-04-06 Eli Zaretskii <eliz@gnu.org>
2368
7c106b1e
EZ
2369 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2370
973f782d
EZ
2371 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2372
41cf7d1a 23732011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2374
ca23cc88
PE
2375 Fix more problems found by GCC 4.6.0's static checks.
2376
f390e2d5
PE
2377 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2378
42eea0d0
PE
2379 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2380
b69769da 2381 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2382
f9541e84
PE
2383 * xdisp.c (vmessage): Mark as a printf-like function.
2384
13841b55
PE
2385 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2386
c136c10f
PE
2387 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2388
5e2d4a30
PE
2389 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2390 printf-like functions.
2391 (tiff_load): Add casts to remove these marks before passing them
2392 to system-supplied API.
2393
583f48b9
PE
2394 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2395
b25d760e
PE
2396 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2397 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2398 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2399 directly, rather than having caller test rule sign. This avoids
2400 some unnecessary tests.
2401 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2402 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2403 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2404
bc7b6697 2405 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2406 (xfont_open): Avoid unnecessary tests.
bc7b6697 2407
27ccc379
PE
2408 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2409
dcd5c89a
PE
2410 * composite.h, composite.c (composition_gstring_put_cache):
2411 Use EMACS_INT, not int, for length.
2412
b13a45c6
PE
2413 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2414 breaking out part of COMPOSITION_DECODE_RULE.
2415 (COMPOSITION_DECODE_RULE): Use it.
2416 * composite.c (get_composition_id): Remove unused local vars,
2417 by using the new macro.
2418
1e792e4d
PE
2419 * textprop.c (set_text_properties_1): Change while to do-while,
2420 since the condition is always true at first.
2421
dc6c6455 2422 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2423 (interval_deletion_adjustment): Return unsigned value.
2424 All uses changed.
dc6c6455 2425
aba7731a
PE
2426 * process.c (list_processes_1, create_pty, read_process_output):
2427 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2428 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2429 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2430 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2431 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2432
fdfc4bf3
PE
2433 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2434
fca8fe46 2435 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2436 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2437
06a0259a 2438 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2439 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2440 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2441
e7b9e80f
PE
2442 * print.c (print_error_message): Avoid int overflow.
2443
56201685
PE
2444 * font.c (font_list_entities): Redo for clarity,
2445 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2446
78834453 2447 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2448 (font_score): Avoid potential overflow in diff calculation.
78834453 2449
0bc0b309 2450 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2451 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2452
e610eaca
PE
2453 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2454
b895abce
PE
2455 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2456 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2457 can always succeed if overflow has undefined behavior.
2458
1f1d9321 2459 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2460 (wordify): Omit three unnecessary tests.
1f1d9321 2461
c59478bc
PE
2462 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2463 All callers changed. This avoids the need for an unused var.
2464
79b73827
PE
2465 * casefiddle.c (casify_region): Remove var that is set but not used.
2466
a4db5dfe
PE
2467 * dired.c (file_name_completion): Remove var that is set but not used.
2468
43aae36e
PE
2469 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2470
2a47c44d 2471 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2472 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2473
a37c69bf
PE
2474 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2475 Check for integer overflow on size calculations.
2476
328ab8e7
PE
2477 * buffer.c (Fprevious_overlay_change): Remove var that is set
2478 but not used.
2479
e5a2a5cb
PE
2480 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2481 Remove vars that are set but not used.
8d84a6eb 2482 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2483 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2484
a60e5f68
PE
2485 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2486
f661cb61 2487 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2488 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2489
f0397f5a
PE
2490 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2491 that are set but not used.
2492
8664db06 2493 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2494 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2495
6abdaa4a
PE
2496 * xselect.c (x_get_local_selection, x_handle_property_notify):
2497 Remove vars that are set but not used.
2498
0ce7538d 2499 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2500 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2501
9ae848fc
PE
2502 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2503 Remove var that is set but not used.
0b918413
PE
2504 (scroll_bar_windows_size): Now size_t, not int.
2505 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2506 Check for overflow.
9ae848fc 2507
a5a62657
PE
2508 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2509 (map_tty_color) [!defined MSDOS]: Likewise.
2510
5c5cdd39
PE
2511 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2512
66ebf983
PE
2513 * coding.c: Remove vars that are set but not used.
2514 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2515 All callers changed.
2516 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2517 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2518 (decode_coding_charset): Remove vars that are set but not used.
2519
1be4d761
PE
2520 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2521 that is set but not used.
2522
47553fa8
PE
2523 * print.c (print_object): Remove var that is set but not used.
2524
1f7196bf 2525 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2526 The gnulib version avoids calling malloc in the usual case,
2527 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2528 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2529 * filelock.c (current_lock_owner): Likewise.
2530 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2531 * sysdep.c: Include allocator.h, careadlinkat.h.
2532 (emacs_no_realloc_allocator): New static constant.
2533 (emacs_readlink): New function.
fdb61804
PE
2534 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2535 ../lib/careadlinkat.h.
d1fdcab7 2536
f84c17c7
SM
25372011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2538
2539 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2540 first non-nil return value).
2541
ef3862ad
JD
25422011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2543
2544 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2545 if not defined (Bug#8403).
2546
376a7006
JB
25472011-04-02 Juanma Barranquero <lekktu@gmail.com>
2548
2549 * xdisp.c (display_count_lines): Remove parameter `start',
2550 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2551 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2552 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2553 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2554 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2555 and thereabouts. All callers changed.
2556 (get_per_char_metric): Remove parameter `f', unused since
2557 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2558
6ca3801d
JM
25592011-04-02 Jim Meyering <meyering@redhat.com>
2560
2561 do not dereference NULL upon failed strdup
2562 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2563 (ns_get_family): Likewise.
2564
d8e2b5ba
JB
25652011-04-02 Juanma Barranquero <lekktu@gmail.com>
2566
2567 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2568
8c74fcbd
JD
25692011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2570
2571 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2572 later (Bug#8403).
2573
7200d79c
SM
25742011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2575
03408648 2576 Add lexical binding.
7200d79c 2577
03408648
SM
2578 * window.c (Ftemp_output_buffer_show): New fun.
2579 (Fsave_window_excursion):
2580 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2581
2582 * lread.c (lisp_file_lexically_bound_p): New function.
2583 (Fload): Bind Qlexical_binding.
2584 (readevalloop): Remove `evalfun' arg.
2585 Bind Qinternal_interpreter_environment.
2586 (Feval_buffer): Bind Qlexical_binding.
2587 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2588 Mark as dynamic.
2589 (syms_of_lread): Declare `lexical-binding'.
2590
2591 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2592
2593 * keyboard.c (eval_dyn): New fun.
2594 (menu_item_eval_property): Use it.
ca105506
SM
2595
2596 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2597
03408648
SM
2598 * fns.c (concat, mapcar1): Accept byte-code-functions.
2599
2600 * eval.c (Fsetq): Handle lexical vars.
2601 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2602 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2603 (FletX, Flet): Obey lexical binding.
2604 (Fcommandp): Handle closures.
2605 (Feval): New `lexical' arg.
2606 (eval_sub): New function extracted from Feval. Use it almost
2607 everywhere where Feval was used. Look up vars in lexical env.
2608 Handle closures.
2609 (Ffunctionp): Move from subr.el.
2610 (Ffuncall): Handle closures.
2611 (apply_lambda): Remove `eval_flags'.
2612 (funcall_lambda): Handle closures and new byte-code-functions.
2613 (Fspecial_variable_p): New function.
2614 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2615 but without exporting it to Lisp.
23aba0ea 2616
23aba0ea 2617 * doc.c (Fdocumentation, store_function_docstring):
03408648 2618 * data.c (Finteractive_form): Handle closures.
23aba0ea 2619
03408648
SM
2620 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2621 interactive spec.
ba83908c 2622
04f2d78b
CB
2623 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2624 New byte-codes.
03408648
SM
2625 (exec_byte_code): New function extracted from Fbyte_code to handle new
2626 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2627
03408648 2628 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2629
03408648 2630 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2631
e2abce01
JB
26322011-03-31 Juanma Barranquero <lekktu@gmail.com>
2633
2634 * xdisp.c (redisplay_internal): Fix prototype.
2635
63696a73 26362011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2637
63696a73 2638 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2639 (try_scrolling): Use it when setting scroll_limit.
2640 Limit scrolling to 100 screen lines.
63696a73
EZ
2641 (redisplay_window): Even when falling back on "recentering",
2642 position point in the window according to scroll-conservatively,
2643 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2644
2645 (try_scrolling): When point is above the window, allow searching
2646 as far as scroll_max, or one screenful, to compute vertical
2647 distance from PT to the scroll margin position. This prevents
2648 try_scrolling from unnecessarily failing when
2649 scroll-conservatively is set to a value slightly larger than the
2650 window height. Clean up the case of PT below the margin at bottom
2651 of window: scroll_max can no longer be INT_MAX. When aggressive
2652 scrolling is in use, don't let point enter the opposite scroll
2653 margin as result of the scroll.
2654 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2655 threshold of 100 lines for never-recentering scrolling.
2656
e4cc2dfc
JB
26572011-03-31 Juanma Barranquero <lekktu@gmail.com>
2658
2659 * dispextern.h (move_it_by_lines):
2660 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2661 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2662 (message_log_check_duplicate): Remove parameters `prev_bol' and
2663 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2664 (redisplay_internal): Remove parameter `preserve_echo_area',
2665 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2666
2667 * indent.c (Fvertical_motion):
2668 * window.c (window_scroll_pixel_based, Frecenter):
2669 Don't pass `need_y_p' to `move_it_by_lines'.
2670
1c470562
SM
26712011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2672
44f230aa
SM
2673 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2674 steal a few bits to be more compact.
2675 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2676 Remove unneeded casts.
2677
1c470562
SM
2678 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2679
888adce9
ZK
26802011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2681
2682 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2683 binding" message (bug#7967).
2684
f838ed7b
PE
26852011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2686
77861b95
PE
2687 Fix more problems found by GCC 4.6.0's static checks.
2688
de6dbc14
PE
2689 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2690 Remove unused local var.
2691
f838ed7b
PE
2692 * editfns.c (Fmessage_box): Remove unused local var.
2693
792c7b2b
PE
2694 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2695 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2696 Omit unused local vars.
c499e557 2697 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2698 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2699 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2700 Omit unused local var.
2701
ba0165e1
PE
2702 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2703 Don't assume string length fits in int.
32ad8845 2704 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2705 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2706
3c59b4c9
PE
2707 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2708 instead of alloca (Bug#8344).
2709
a3eed478 2710 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2711 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2712
eb4d412d
PE
2713 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2714
1658b401
PE
2715 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2716 concerns.
2717
2718 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2719
2720 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2721
9a2c6e05
PE
2722 * keyboard.c (syms_of_keyboard): Use the same style as later
2723 in this function when indexing through an array. This also
2724 works around GCC bug 48267.
2725
03d0a109
PE
2726 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2727
44f730c8
PE
2728 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2729
fe75f926
PE
2730 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2731 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2732
ffa8c828
PE
2733 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2734 This avoids undefined behavior on integer overflow, and is a bit
2735 more convenient anyway since it is compared to a size_t variable.
2736
c5101a77
PE
2737 Variadic C functions now count arguments with size_t, not int.
2738 This avoids an unnecessary limitation on 64-bit machines, which
2739 caused (substring ...) to crash on large vectors (Bug#8344).
2740 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2741 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2742 All variadic functions and their callers changed accordingly.
c5101a77
PE
2743 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2744 * data.c (arith_driver, float_arith_driver): Likewise.
2745 * editfns.c (general_insert_function): Likewise.
2746 * eval.c (struct backtrace.nargs, interactive_p)
2747 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2748 (funcall_lambda, mark_backtrace): Likewise.
2749 * fns.c (concat): Likewise.
2750 * frame.c (x_set_frame_parameters): Likewise.
2751 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2752 0 if not found, not -1. All callers changed.
2753
dd3f25f7
PE
2754 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2755 (stack_copy_size): Now size_t, not int.
2756 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2757
461c2ab9
JB
27582011-03-28 Juanma Barranquero <lekktu@gmail.com>
2759
2760 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2761 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2762 All callers changed.
2763
2764 * lisp.h (multibyte_char_to_unibyte):
2765 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2766 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2767 * character.h (CHAR_TO_BYTE8):
2768 * cmds.c (internal_self_insert):
2769 * editfns.c (general_insert_function):
2770 * keymap.c (push_key_description):
2771 * search.c (Freplace_match):
2772 * xdisp.c (message_dolog, set_message_1): All callers changed.
2773
f6d62986
SM
27742011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2775
2776 * keyboard.c (safe_run_hook_funcall): New function.
2777 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2778 don't set the hook to nil, but remove the offending function instead.
2779 (Qcommand_hook_internal): Remove, unused.
2780 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2781 Vcommand_hook_internal.
2782
2783 * eval.c (enum run_hooks_condition): Remove.
2784 (funcall_nil, funcall_not): New functions.
2785 (run_hook_with_args): Call each function through a `funcall' argument.
2786 Remove `cond' argument, now redundant.
2787 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2788 (Frun_hook_with_args_until_failure): Adjust accordingly.
2789 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2790
1db5b1ad
JB
27912011-03-28 Juanma Barranquero <lekktu@gmail.com>
2792
2793 * dispextern.h (string_buffer_position): Remove declaration.
2794
2795 * print.c (strout): Remove parameter `multibyte', unused since
2796 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2797
2798 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2799 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2800 All callers changed.
2801
2802 * w32.c (_wsa_errlist): Use braces for struct initializers.
2803
2804 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2805 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2806 All callers changed.
2807 (string_buffer_position): Likewise. Also, make static (it's never
2808 used outside xdisp.c).
2809 (cursor_row_p): Remove parameter `w', unused since
2810 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2811 (decode_mode_spec): Remove parameter `precision', introduced during
2812 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2813 All callers changed.
2814
5ffb62aa
JD
28152011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2816
2817 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2818
461c2ab9 28192011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2820
2821 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2822 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2823 (ns_update_auto_hide_menu_bar): New functions.
2824 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2825 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2826 ns_constrain_all_frames.
2827 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2828 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2829
5c380ffb
JD
28302011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2831
2832 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2833
9af30bdf
GM
28342011-03-27 Glenn Morris <rgm@gnu.org>
2835
2836 * syssignal.h: Replace RETSIGTYPE with void.
2837 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2838 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2839 Replace SIGTYPE with void everywhere.
2840 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2841 * s/template.h (SIGTYPE): Remove commented out definition.
2842
e2abce01
JB
28432011-03-26 Eli Zaretskii <eliz@gnu.org>
2844
2845 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2846 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2847
f868cd8a
JB
28482011-03-26 Juanma Barranquero <lekktu@gmail.com>
2849
59eb0929
JB
2850 * w32.c (read_unc_volume): Use parameter `henum', instead of
2851 global variable `wget_enum_handle'.
2852
2853 * keymap.c (describe_vector): Remove parameters `indices' and
2854 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2855 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2856
f868cd8a
JB
2857 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2858
2859 * keyboard.c (timer_check): Remove parameter `do_it_now',
2860 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2861 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2862 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2863
2864 * keyboard.c (read_char):
2865 * w32menu.c (w32_menu_display_help):
2866 * xmenu.c (show_help_event, menu_help_callback):
2867 Adjust calls to `show_help_echo'.
2868
2869 * gtkutil.c (xg_maybe_add_timer):
2870 * keyboard.c (readable_events):
2871 * process.c (wait_reading_process_output):
2872 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2873
2874 * insdel.c (adjust_markers_gap_motion):
2875 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2876 (gap_left, gap_right): Don't call it.
2877
2ecf6fdb
CY
28782011-03-25 Chong Yidong <cyd@stupidchicken.com>
2879
2880 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2881 incurred during fontification.
2882
6b1f9ba4
JB
28832011-03-25 Juanma Barranquero <lekktu@gmail.com>
2884
2885 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2886 (DEFVAR_PER_BUFFER): Don't pass it.
2887
2888 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2889 (scrolling_window): Don't pass it.
2890
0f4a96b5
JB
28912011-03-25 Juanma Barranquero <lekktu@gmail.com>
2892
2893 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2894
2895 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2896 and `suffix'.
2897 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2898 of variables specific to SELinux and computation of `encoded_absname'.
2899
2900 * image.c (XPutPixel): Remove unused variable `height'.
2901
2902 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2903
2904 * unexw32.c (get_section_info): Remove unused variable `section'.
2905
2906 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2907 (system_process_attributes): Remove unused variable `sess'.
2908 (sys_read): Remove unused variable `err'.
2909
2910 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2911 (w32_wnd_proc): Remove unused variable `isdead'.
2912 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2913 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2914 (x_create_tip_frame): Remove unused variable `tem'.
2915
2916 * w32inevt.c (w32_console_read_socket):
2917 Remove unused variable `no_events'.
2918
2919 * w32term.c (x_draw_composite_glyph_string_foreground):
2920 Remove unused variable `width'.
2921
1149507c
JB
29222011-03-24 Juanma Barranquero <lekktu@gmail.com>
2923
2924 * w32term.c (x_set_glyph_string_clipping):
2925 Don't pass uninitialized region to CombineRgn.
2926
9c88f339
JB
29272011-03-23 Juanma Barranquero <lekktu@gmail.com>
2928
2929 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2930 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2931 (Fx_close_connection): Remove unused variable `i'.
2932
2933 * w32font.c (w32font_draw): Return number of glyphs.
2934 (w32font_open_internal): Remove unused variable `i'.
2935 (w32font_driver): Add missing initializer.
2936
2937 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2938 (fill_in_menu): Remove unused variable `items_added'.
2939
2940 * w32term.c (last_mouse_press_frame): Remove static global variable.
2941 (w32_clip_to_row): Remove unused variable `f'.
2942 (x_delete_terminal): Remove unused variable `i'.
2943
2944 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2945 (NOTHING): Remove unused static global variable.
2946 (uniscribe_check_otf): Remove unused variable `table'.
2947 (uniscribe_font_driver): Add missing initializers.
2948
dee091a3
JD
29492011-03-23 Julien Danjou <julien@danjou.info>
2950
2951 * term.c (Fsuspend_tty, Fresume_tty):
2952 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2953 * window.c (temp_output_buffer_show):
2954 * insdel.c (signal_before_change):
2955 * frame.c (Fhandle_switch_frame):
2956 * fileio.c (Fdo_auto_save):
2957 * emacs.c (Fkill_emacs):
2958 * editfns.c (save_excursion_restore):
2959 * cmds.c (internal_self_insert):
2960 * callint.c (Fcall_interactively):
2961 * buffer.c (Fkill_all_local_variables):
2962 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2963 Use Frun_hooks.
0f4a96b5 2964 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2965 unconditionnaly since it does the check itself.
2966
2c520ab5 29672011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2968
c9c49752
PE
2969 Fix more problems found by GCC 4.5.2's static checks.
2970
8abc3f12
PE
2971 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2972 the first time through the loop, since we know p0 < p1 then.
2973 This also avoids a gcc -Wstrict-overflow warning.
2974
a2d26660
PE
2975 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2976 leading to a memory leak, possible in functions like
2977 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2978 of objects (Bug#8318).
a2d26660 2979
916c72e9
PE
2980 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2981 that could (at least in theory) be that large.
2982
19ab8a18
PE
2983 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2984 This is less likely to overflow, and avoids undefined behavior if
2985 overflow does occur. All callers changed. Use strtoul to scan
2986 for the unsigned long integer.
b7cbbd6f
PE
2987 (pint2hrstr): Simplify and tune code slightly.
2988 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2989
f0641eff
PE
2990 * scroll.c (do_scrolling): Work around GCC bug 48228.
2991 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2992
7f650bb9
PE
2993 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2994 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2995 (validate_x_resource_name): Simplify count usage.
2996 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2997
37dd57d1
PE
2998 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2999 fail (Bug#8306).
81e56e61 3000
699979fc 3001 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3002
401bf9b4
PE
3003 * process.c (Fmake_network_process): Use socklen_t, not int,
3004 where POSIX says socklen_t is required in portable programs.
3005 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3006 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3007 (Fmake_network_process, server_accept_connection):
3008 (wait_reading_process_output, read_process_output):
3009 Likewise.
3010
b93aacde
PE
3011 * process.c: Rename or move locals to avoid shadowing.
3012 (list_processes_1, Fmake_network_process):
3013 (read_process_output_error_handler, exec_sentinel_error_handler):
3014 Rename or move locals.
4dc343ee 3015 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3016 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3017 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3018 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3019 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3020
af8a867c 3021 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3022 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3023 Include tparam.h instead, since it declares them.
af8a867c
PE
3024 * cm.h (PC): Remove extern decl; tparam.h now does this.
3025 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3026 * terminfo.c: Include tparam.h, to check interfaces.
3027 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3028 (tparam): Adjust signature to match interface in tparam.h;
3029 this removes some undefined behavior. Check that outstring and len
3030 are zero, which they always are with Emacs.
3031 * tparam.h (PC, BC, UP): New extern decls.
3032
0248044d 3033 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3034 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3035
8ff096c1 3036 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3037 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3038 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3039 (ftfont_list): Remove unused local.
49eaafba
PE
3040 (get_adstyle_property, ftfont_pattern_entity):
3041 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3042 Rename locals to avoid shadowing.
8ff096c1 3043
e2be39f6
PE
3044 * xfont.c (xfont_list_family): Mark var as initialized.
3045
c9735e30
PE
3046 * xml.c (make_dom): Now static.
3047
8f5201ae
PE
3048 * composite.c (composition_compute_stop_pos): Rename local to
3049 avoid shadowing.
b246f932
PE
3050 (composition_reseat_it): Remove unused locals.
3051 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3052 (composition_update_it): Mark var as initialized.
11b61122
PE
3053 (find_automatic_composition): Mark vars as initialized,
3054 with a FIXME (Bug#8290).
8f5201ae 3055
760fbc2c
PE
3056 character.h: Rename locals to avoid shadowing.
3057 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3058 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3059 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3060 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3061 to avoid shadowing.
3062
ff08eb85
PE
3063 * textprop.c (property_change_between_p): Remove; unused.
3064
fc7bf025
PE
3065 * intervals.c (interval_start_pos): Now static.
3066
235d7abc
PE
3067 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3068
44f230aa
SM
3069 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3070 Rename locals to avoid shadowing.
3e7d6594 3071
50060332
PE
3072 * sound.c (wav_play, au_play, Fplay_sound_internal):
3073 Fix pointer signedness.
d01f234b 3074 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3075 (wav_play): Initialize a variable to 0, to prevent undefined
3076 behavior (Bug#8278).
50060332 3077
c4fc4e30
PE
3078 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3079
918436ed
PE
3080 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3081
c939f91b
PE
3082 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3083 clobbering (Bug#8298).
b9c7f648
PE
3084 * sysdep.c (sys_subshell): Likewise.
3085 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3086
6bd8c144
PE
3087 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3088 This should get cleaned up, so that child_setup has the
3089 same signature on all platforms.
3090
7710357c 3091 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3092 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3093
c59da222
CY
30942011-03-22 Chong Yidong <cyd@stupidchicken.com>
3095
3096 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3097 not to be necessary, and produces flickering.
3098
66b87493
GM
30992011-03-20 Glenn Morris <rgm@gnu.org>
3100
3101 * config.in: Remove file.
3102
45b6f6d5
JB
31032011-03-20 Juanma Barranquero <lekktu@gmail.com>
3104
3105 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3106 are now in src/globals.h.
3107 (syms_of_minibuf): Remove spurious & from previous change.
3108
3ec03f7e
LL
31092011-03-20 Leo <sdl.web@gmail.com>
3110
3111 * minibuf.c (completing-read-function): New variable.
3112 (completing-read-default): Rename from completing-read.
3113 (completing-read): Call completing-read-function.
3114
b14e3e21
CY
31152011-03-19 Juanma Barranquero <lekktu@gmail.com>
3116
3117 * xfaces.c (Fx_load_color_file):
3118 Read color file from absolute filename (bug#8250).
3119
f2b726e6
JB
31202011-03-19 Juanma Barranquero <lekktu@gmail.com>
3121
3122 * makefile.w32-in: Update dependencies.
3123
09f6ff02
EZ
31242011-03-17 Eli Zaretskii <eliz@gnu.org>
3125
3126 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3127
29a6015a
PE
31282011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3129
a3a6c54e
PE
3130 Fix more problems found by GCC 4.5.2's static checks.
3131
b766f867
PE
3132 * process.c (make_serial_process_unwind, send_process_trap):
3133 (sigchld_handler): Now static.
3134
be02381c
PE
3135 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3136 That way, the code declares only the vars that it needs.
3137 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3138 * s/cygwin.h (PTY_ITERATION): Likewise.
3139 * s/darwin.h (PTY_ITERATION): Likewise.
3140 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3141
57048744
PE
3142 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3143 * process.c (allocate_pty): Don't declare stb unless it's needed.
3144
7914961c 3145 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3146 (CONSTANTLIM): Remove; unused.
3147 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3148 Define only if needed.
7914961c 3149
b3967b18
PE
3150 * unexelf.c (unexec): Name an expression,
3151 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3152 Use a different way to cause a compilation error if anyone uses
3153 n rather than nn, a way that does not involve shadowing.
73366a00 3154 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3155
29a6015a
PE
3156 * deps.mk (unexalpha.o): Remove; unused.
3157
43cfc33e 3158 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3159 * unexec.h: New file.
ce701a33
PE
3160 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3161 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3162 Depend on unexec.h.
3163 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3164 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3165 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3166 Change as necessary to match prototype in unexec.h.
ce701a33 3167
01f44d5a
PE
3168 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3169 shadowing.
4f63c6bb 3170 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3171
a6670b0b
PE
3172 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3173 Rename locals to avoid shadowing.
3174
cef2010d 3175 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3176 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3177
d4d7173a
PE
3178 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3179
f08b802a
PE
3180 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3181 warning when compiling print.c.
3182
3ddb0639
PE
3183 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3184 instead of using an uninitialized var.
5ad03b97 3185 (font_sort_entities): Mark var as initialized.
3ddb0639 3186
170a2692
PE
3187 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3188
e663c700
PE
3189 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3190 pointers to constants.
89bc529a 3191 (font_parse_fcname): Remove unused vars.
7b81e2d0 3192 (font_delete_unmatched): Now static.
ea838e10 3193 (font_get_spec): Remove; unused.
13a547c6
PE
3194 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3195 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3196 Rename or move locals to avoid shadowing.
e663c700 3197
2a80c887 3198 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3199 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3200
1384fa33 3201 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3202 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3203
8b2c52e9
PE
3204 * alloc.c (mark_backtrace): Move decl from here ...
3205 * lisp.h: ... to here, so that it can be checked.
3206
475545b5 3207 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3208 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3209 (lisp_indirect_variable): Name an expression,
3210 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3211 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3212
b1349114 3213 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3214 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3215 Use const pointer when appropriate.
b1349114 3216
a2928364
PE
3217 * lisp.h (get_system_name, get_operating_system_release):
3218 Move decls here, to check interfaces.
3219 * process.c (get_operating_system_release): Move decl to lisp.h.
3220 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3221 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3222 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3223 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3224 (Fformat_time_string, Fencode_time, Finsert_char):
3225 (Ftranslate_region_internal, Fformat):
3226 Rename or remove local vars to avoid shadowing.
9710023e 3227 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3228
a415e694
PE
3229 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3230 avoid shadowing.
3231
8ef4622d
PE
3232 * lisp.h (eassert): Check that the argument compiles, even if
3233 ENABLE_CHECKING is not defined.
3234
946f9a5b
PE
3235 * data.c (Findirect_variable): Name an expression, to avoid
3236 gcc -Wbad-function-cast warning.
112396d6 3237 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3238 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3239 (Fmake_variable_buffer_local, Fmake_local_variable):
3240 Mark variables as initialized.
52746918 3241 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3242
e5aab7e7 3243 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3244 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3245 Rename locals to avoid shadowing.
dff45157
PE
3246 (mark_stack): Move local variables into the #ifdef region where
3247 they're used.
7bc26fdb
PE
3248 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3249 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3250 needed otherwise.
3251 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3252 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3253 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3254
e5aab7e7
PE
3255 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3256 avoids undefined behavior in theory.
3257
4da60324
PE
3258 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3259
88043301
PE
3260 Use functions, not macros, for up- and down-casing (Bug#8254).
3261 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3262 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3263 to use the following functions instead of these macros.
3264 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3265 EMACS_INT, since callers assume the returned value fits in int.
3266 (upcase1): Likewise, for UPCASE_TABLE.
3267 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3268 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3269 the race-condition problem in the old DOWNCASE.
88043301 3270
19ed5445
PE
3271 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3272 Rename locals to avoid shadowing.
3273 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3274 (regex_compile, re_search_2, re_match_2_internal):
3275 Remove unused local vars.
952db0d7
PE
3276 (FREE_VAR): Rewrite so as not to use empty "else",
3277 which gcc can warn about.
da053e48 3278 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3279 (RETALLOC_IF): Define only if needed.
3280 (WORDCHAR_P): Likewise. This one is never needed, but is used
3281 only in a comment talking about a compiler bug, so put inside
3282 the #if 0 of that comment.
3283 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3284 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3285 Remove; unused.
19ed5445 3286
1f3561e4 3287 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3288 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3289 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3290
ded6f8f7
PE
3291 * search.c (simple_search): Remove unused var.
3292
dbd37a95
PE
3293 * dired.c (compile_pattern): Move decl from here ...
3294 * lisp.h: ... to here, so that it can be checked.
3295 (struct re_registers): New forward decl.
3296
7e47afad
PE
3297 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3298
85f24f61
PE
3299 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3300 All uses changed.
3301 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3302 Rename locals to avoid shadowing.
5671df8f 3303 (Fvertical_motion): Mark locals as initialized.
85f24f61 3304
181aa2be 3305 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3306 (casify_region): Mark local as initialized.
181aa2be 3307
930d429c
PE
3308 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3309
7082eac6
PE
3310 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3311 New macros, so that the caller can use some names other than
3312 gcpro1, gcpro2, etc.
3313 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3314 of the new macros.
3315 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3316 argument, for consistency with GCPRO2_VAR, etc: it is now the
3317 prefix of the variable, not the variable itself. All uses
3318 changed.
38b2c076
PE
3319 * dired.c (directory_files_internal, file_name_completion):
3320 Rename locals to avoid shadowing.
3321
15206ed9
PE
3322 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3323 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3324 dired.c's scmp function, had undefined behavior.
3325 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3326 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3327 * buffer.h: ... to here, because these macros use current_buffer,
3328 and the new implementation with inline functions needs to have
3329 current_buffer in scope now, rather than later when the macros
3330 are used.
3331 (downcase, upcase1): New static inline functions.
3332 (DOWNCASE, UPCASE1): Reimplement using these functions.
3333 This avoids undefined behavior in expressions like
3334 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3335 from race conditions in accessing the global variables
3336 case_temp1 and case_temp2.
3337 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3338 * lisp.h (case_temp1, case_temp2): Remove their decls.
3339 * character.h (ASCII_CHAR_P): Move from here ...
3340 * lisp.h: ... to here, so that the inline functions mentioned
3341 above can use them.
3342
4a6bea26
PE
3343 * dired.c (directory_files_internal_unwind): Now static.
3344
f14b7e14
PE
3345 * fileio.c (file_name_as_directory, directory_file_name):
3346 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3347 Now static.
2893f146
PE
3348 (file_name_as_directory): Use const pointers when appropriate.
3349 (Fexpand_file_name): Likewise. In particular, newdir might
3350 point at constant storage, so make it a const pointer.
fd4ead52 3351 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3352 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3353 signedness issues.
f839df0c
PE
3354 (Fset_file_times, Finsert_file_contents, auto_save_error):
3355 Rename locals to avoid shadowing.
f14b7e14 3356
5716756e 3357 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3358 (Ftry_completion, Fall_completions): Rename or remove locals
3359 to avoid shadowing.
5716756e 3360
b4c3046a
PE
3361 * marker.c (bytepos_to_charpos): Remove; unused.
3362
b45db522
PE
3363 * lisp.h (verify_bytepos, count_markers): New decls,
3364 so that gcc does not warn that these functions aren't declared.
3365
85876d07
PE
3366 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3367 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3368 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3369 (copy_text): Remove unused local var.
85876d07 3370
03d78a21 3371 * filelock.c (within_one_second): Now static.
b3dd38ab 3372 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3373
5df8f01b
PE
3374 * buffer.c (fix_overlays_before): Mark locals as initialized.
3375 (fix_start_end_in_overlays): Likewise. This function should be
3376 simplified by using pointers-to-pointers, but that's a different
3377 matter.
b1d876f1 3378 (switch_to_buffer_1): Now static.
8f54f30a
PE
3379 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3380 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3381
a70072c9 3382 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3383 Fix pointer signedness issue.
edced198
PE
3384 (sys_subshell): Mark local as volatile if checking for lint,
3385 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3386 (MAXPATHLEN): Define only if needed.
a70072c9 3387
a0977c44
PE
3388 * process.c (serial_open, serial_configure): Move decls from here ...
3389 * systty.h: ... to here, so that they can be checked.
3390
a884fdcc
PE
3391 * fns.c (get_random, seed_random): Move extern decls from here ...
3392 * lisp.h: ... to here, so that they can be checked.
3393
604efe86 3394 * sysdep.c (reset_io): Now static.
b8950c94 3395 (wait_for_termination_signal): Remove; unused.
604efe86 3396
38fc62d9
PE
3397 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3398 (copy_keymap_item, append_key, push_text_char_description):
3399 Now static.
1004a21a 3400 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3401 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3402 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3403 (describe_map_tree):
3404 Rename locals to avoid shadowing.
38fc62d9 3405
2f2650da
PE
3406 * keyboard.c: Declare functions static if they are not used elsewhere.
3407 (echo_char, echo_dash, cmd_error, top_level_2):
3408 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3409 (read_char, kbd_buffer_get_event, make_lispy_position):
3410 (make_lispy_event, make_lispy_movement, apply_modifiers):
3411 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3412 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3413 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3414 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3415 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3416
a053e86c 3417 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3418 (mark_kboards): Move decl here ...
3419 * alloc.c (mark_kboards): ... from here.
a053e86c 3420
4752793e
PE
3421 * lisp.h (force_auto_save_soon): New decl.
3422
74f10ca7 3423 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3424 (DEFINE_DUMMY_FUNCTION): New macro.
3425 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3426 Use it.
c03cd23f
PE
3427 (main): Add casts to avoid warnings
3428 if GCC considers string literals to be constants.
74f10ca7 3429
022e70d4
PE
3430 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3431
59d6fe83
PE
3432 * dbusbind.c: Pointer signedness fixes.
3433 (xd_signature, xd_append_arg, xd_initialize):
3434 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3435 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3436 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3437 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3438
78320123
PE
3439 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3440 if GCC considers string literals to be constants.
49cebcca 3441 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3442
35ac2a97
SM
34432011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3444
fb103ca9
SM
3445 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3446 (print_preprocess, print_object): New macro to fix last change.
3447
35ac2a97
SM
3448 * print.c (print_preprocess): Don't forget font objects.
3449
62973b41
JB
34502011-03-16 Juanma Barranquero <lekktu@gmail.com>
3451
3452 * emacs.c (USAGE3): Doc fixes.
3453
0e48bb22
AS
34542011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3455
3456 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3457 structure.
3458
7684e57b
JB
34592011-03-14 Juanma Barranquero <lekktu@gmail.com>
3460
3461 * lisp.h (VWindow_system, Qfile_name_history):
3462 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3463 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3464 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3465
3466 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3467 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3468
3469 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3470 * w32console.c (detect_input_pending, read_input_pending)
3471 (encode_terminal_code):
3472 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3473 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3474 (w32_system_caret_y, Qfile_name_history):
3475 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3476 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3477 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3478 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3479 * w32proc.c (Qlocal, report_file_error):
3480 * w32term.c (Vwindow_system, updating_frame):
3481 * w32uniscribe.c (initialized, uniscribe_font_driver):
3482 Remove unneeded extern declarations.
3483
2aa46d6c
CY
34842011-03-14 Chong Yidong <cyd@stupidchicken.com>
3485
c96bbc66 3486 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3487
cffc6f3b
CY
34882011-03-13 Chong Yidong <cyd@stupidchicken.com>
3489
3490 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3491 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3492 These macros can no longer be used for assignment.
3493
44f230aa
SM
3494 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3495 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3496 (record_buffer_markers, fetch_buffer_markers): New functions for
3497 recording and fetching special buffer markers.
3498 (set_buffer_internal_1, set_buffer_temp): Use them.
3499
3500 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3501
3502 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3503
3504 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3505 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3506
3507 * xdisp.c (hscroll_window_tree):
3508 (reconsider_clip_changes): Use PT instead of BUF_PT.
3509
d251f04b
EZ
35102011-03-13 Eli Zaretskii <eliz@gnu.org>
3511
3512 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3513 $(EMACS_ROOT)/lib/intprops.h.
3514
f0c77cd1
PE
35152011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3516
3eca4629
PE
3517 Fix more problems found by GCC 4.5.2's static checks.
3518
7c86ee98
PE
3519 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3520 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3521 (xg_free_frame_widgets): Make it clear that a local variable is
3522 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3523 (gdk_window_get_screen): Make it clear that this macro is needed
3524 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3525 (int_gtk_range_get_value): New function, which avoids a diagnostic
3526 from gcc -Wbad-function-cast.
3527 (xg_set_toolkit_scroll_bar_thumb): Use it.
3528 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3529 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3530 (get_utf8_string, xg_get_file_with_chooser):
3531 Rename locals to avoid shadowing.
3532 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3533
41729b81
PE
3534 * xgselect.c (xg_select): Remove unused var.
3535
f0c77cd1
PE
3536 * image.c (four_corners_best): Mark locals as initialized.
3537 (gif_load): Initialize transparent_p to zero (Bug#8238).
3538 Mark another local as initialized.
ec6cf4c6 3539 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3540
ce0ad53d 3541 * image.c (clear_image_cache): Now static.
d5d5a617 3542 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3543 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3544 (x_edge_detection): Remove unnecessary cast that
3545 gcc -Wbad-function-cast diagnoses.
2037898d 3546 (gif_load): Fix pointer signedness.
6ae141d6
PE
3547 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3548 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3549
33383987 35502011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3551
d32df629
PE
3552 Improve quality of tests for time stamp overflow.
3553 For example, without this patch (encode-time 0 0 0 1 1
3554 1152921504606846976) returns the obviously-bogus value (-948597
3555 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3556 reports time overflow. See
3557 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3558 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3559 * editfns.c: Include limits.h and intprops.h.
3560 (TIME_T_MIN, TIME_T_MAX): New macros.
3561 (time_overflow): Move earlier, to before first use.
3562 (hi_time, lo_time): New functions, for an accurate test for
3563 out-of-range times.
3564 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3565 (Fget_internal_run_time): Don't assume time_t fits in int.
3566 (make_time): Use list2 instead of Fcons twice.
3567 (Fdecode_time): More accurate test for out-of-range times.
3568 (check_tm_member): New function.
3569 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3570 (lisp_time_argument): Don't rely on undefined left-shift and
3571 right-shift behavior when checking for time stamp overflow.
8be6f318 3572
fe31d94c
PE
3573 * editfns.c (time_overflow): New function, refactoring common code.
3574 (Fformat_time_string, Fdecode_time, Fencode_time):
3575 (Fcurrent_time_string): Use it.
3576
8be6f318
PE
3577 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3578 * dired.c (make_time): Move to ...
3579 * editfns.c (make_time): ... here.
3580 * systime.h: Note the move.
3581
09d9db2c 35822011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3583
126bc0dc
YM
3584 * fringe.c (update_window_fringes): Remove unused variables.
3585
c47cbdfd
YM
3586 * unexmacosx.c (copy_data_segment): Also copy __got section.
3587 (Bug#8223)
3588
7ac80be9
EZ
35892011-03-12 Eli Zaretskii <eliz@gnu.org>
3590
c96bbc66 3591 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3592 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3593 Constify `char *' arguments and their references according to
3594 prototypes in tparam.h.
3595
ecb0f94d 3596 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3597
7ac80be9
EZ
3598 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3599 Adapt all references accordingly.
3600
3601 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3602
ef1fd07e
TT
36032011-03-11 Tom Tromey <tromey@redhat.com>
3604
3605 * buffer.c (syms_of_buffer): Remove obsolete comment.
3606
7ef4b50c
EZ
36072011-03-11 Eli Zaretskii <eliz@gnu.org>
3608
3609 * termhooks.h (encode_terminal_code): Declare prototype.
3610
3611 * msdos.c (encode_terminal_code): Don't declare prototype.
3612
3613 * term.c (encode_terminal_code): Now external again, used by
3614 w32console.c and msdos.c.
3615
44f230aa
SM
3616 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3617 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3618
4b1ec863 36192011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3620
1714f52b 3621 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3622
4b1ec863
PE
3623 * fringe.c (update_window_fringes): Mark locals as initialized
3624 (Bug#8227).
3625 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3626
524c7aa6
PE
3627 * alloc.c (mark_fringe_data): Move decl from here ...
3628 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3629 to check its interface.
3630 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3631
a5c0af81 3632 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3633 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3634 (fontset_font): Mark local as initialized.
a9a06e0b 3635 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3636
b4716021
PE
3637 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3638
811e9bac 3639 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3640 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3641 (x_own_selection, Fx_disown_selection_internal): Rename locals
3642 to avoid shadowing.
3643 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3644
7e3ab302
PE
3645 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3646 so that the caller can use some name other than gcpro1.
3647 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3648 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3649 (Fx_backspace_delete_keys_p):
3650 Use them to avoid shadowing, and rename vars to avoid shadowing.
3651 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3652 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3653 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3654 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3655 Remove unused locals.
7e3ab302
PE
3656 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3657 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3658 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3659 macros.
f78faa98 3660
e2b13473
PE
3661 * xterm.h (x_mouse_leave): New decl.
3662
77f23912
PE
3663 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3664 Remove unused functions.
cdf4ba58
PE
3665 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3666 (x_calc_absolute_position): Now static.
7411c686 3667 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3668 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3669 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3670 unless they are used.
38d0b34a
PE
3671 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3672 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3673 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3674 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3675 (x_error_catcher, x_connection_closed, x_error_handler):
3676 (x_error_quitter, xembed_send_message, x_iconify_frame):
3677 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3678 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3679 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3680
44f230aa
SM
3681 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3682 Rename or move locals to avoid shadowing.
6b463e58 3683 (tty_defined_color, merge_face_heights): Now static.
5967d051 3684 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3685 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3686 does not deduce is never used uninitialized.
73719eba
PE
3687 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3688 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3689
426994c3 3690 * terminal.c (store_terminal_param): Now static.
5489860b 3691
032f1620 3692 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3693 (set_frame_menubar): Remove unused local.
d4323972 3694 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3695 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3696 since they might point to immutable storage.
281585b0
PE
3697 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3698 since it's unused otherwise.
032f1620 3699
367c19e5 3700 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3701 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3702 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3703 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3704 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3705 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3706 does not deduce are never used uninitialized.
70739cbe 3707
07b48fa9
PE
3708 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3709
8868a238 3710 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3711 * window.c (window_loop, size_window):
3712 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3713
7e5cf297 3714 * window.c (display_buffer): Now static.
d6550a9f
PE
3715 (size_window): Mark variables that gcc -Wuninitialized
3716 does not deduce are never used uninitialized.
a586633d
PE
3717 * window.h (check_all_windows): New decl, to forestall
3718 gcc -Wmissing-prototypes diagnostic.
5b555da1 3719 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3720
f6095868
PE
3721 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3722 shadowing.
3723 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3724 Include <limits.h>.
3725 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3726 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3727 (load_charset_map): Mark variables that gcc -Wuninitialized
3728 does not deduce are never used uninitialized.
53df7c11 3729 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3730
f38b440c
PE
3731 * coding.c (coding_set_source, coding_set_destination):
3732 Use "else { /* comment */ }" rather than "else /* comment */;"
3733 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3734 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3735 a block, when the outer 'i' will do.
3736 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3737 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3738 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3739 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3740 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3741 Rename locals to avoid shadowing.
3742 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3743 * coding.c (emacs_mule_char, encode_invocation_designation):
3744 Now static, since they're not used elsewhere.
413bb2db 3745 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3746 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3747 (decode_coding_emacs_mule): Mark variables that gcc
3748 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3749 (detect_coding_iso_2022): Initialize a local variable that might
3750 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3751 this initialization is needed. (Bug#8211)
5f58e762
PE
3752 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3753 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3754 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3755 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3756 Remove unused macros.
f38b440c 3757
232b38b9 3758 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3759 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3760 * character.c (string_count_byte8): Likewise.
232b38b9 3761
fb90da1b
PE
3762 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3763 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3764
fb93dbc2
PE
3765 * chartab.c (copy_sub_char_table): Now static, since it's not used
3766 elsewhere.
5c156ace
PE
3767 (sub_char_table_ref_and_range, char_table_ref_and_range):
3768 Rename locals to avoid shadowing.
bbcd0949 3769 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3770
7d3b3862 3771 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3772 (BIDI_BOB): Remove unused macro.
7d3b3862 3773
6be7d3da
PE
3774 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3775 deduce are never used uninitialized.
c2ed9c8b 3776 * term.c (encode_terminal_code): Likewise.
6be7d3da 3777
75f8807f 3778 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3779
50938595
PE
3780 * tparam.h: New file.
3781 * term.c, tparam.h: Include it.
3782 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3783 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3784 Move these decls to tparam.h, and make them agree with what
3785 is actually in tparam.c. The previous trick of using incompatible
3786 decls in different modules does not conform to the C standard.
3787 All callers of tparam changed to use tparam's actual API.
3788 * tparam.c (tparam1, tparam, tgoto):
3789 Use const pointers where appropriate.
3790
fbceeba2
PE
3791 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3792 * cm.h (struct cm): Likewise.
3793 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3794 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3795 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3796 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3797 (turn_on_face, init_tty): Likewise.
3798 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3799
7f3f1250
PE
3800 * term.c (term_mouse_position): Rename local to avoid shadowing.
3801
e6ca6543
PE
3802 * alloc.c (mark_ttys): Move decl from here ...
3803 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3804
c40f8d15
AS
38052011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3806
3807 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3808
cfe0661d
JB
38092011-03-09 Juanma Barranquero <lekktu@gmail.com>
3810
3811 * search.c (compile_pattern_1): Remove argument regp, unused since
3812 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3813 (compile_pattern): Don't pass it.
3814
0afb4571
J
38152011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3816
3817 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3818 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3819 for ! HAVE_GTK3.
3820 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3821
3822 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3823
3824 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3825 gdk_window_get_screen, gdk_window_get_geometry,
3826 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3827 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3828 (xg_get_pixbuf_from_pixmap): New function.
3829 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3830 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3831 Call xg_get_pixbuf_from_pixmap instead of
3832 gdk_pixbuf_get_from_drawable.
3833 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3834 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3835 (xg_check_special_colors): Use GtkStyleContext and its functions
3836 for HAVE_GTK3.
3837 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3838 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3839 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3840 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3841 Call gtk_widget_get_preferred_size.
0afb4571
J
3842 (xg_frame_resized): gdk_window_get_geometry only takes 5
3843 parameters.
44f230aa
SM
3844 (xg_win_to_widget, xg_event_is_for_menubar):
3845 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3846 (xg_set_widget_bg): New function.
3847 (delete_cb): New function.
895009e1 3848 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3849 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3850 (xg_set_background_color): Call xg_set_widget_bg.
3851 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3852 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3853 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3854 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3855 if ! HAVE_GTK3.
3856 (update_frame_tool_bar): Call gtk_widget_hide.
3857 (xg_initialize): Use GDK_KEY_g.
3858
3859 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3860 if ! HAVE_GTK3
3861 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3862
3863 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3864 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3865 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3866
1c2cc4ef
JB
38672011-03-08 Juanma Barranquero <lekktu@gmail.com>
3868
3869 * w32xfns.c (select_palette): Check success of RealizePalette against
3870 GDI_ERROR, not zero.
3871
33383987 3872See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3873
3874;; Local Variables:
3875;; coding: utf-8
aac0c6e3
MR
3876;; End:
3877
33383987 3878 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3879
3880 This file is part of GNU Emacs.
3881
3882 GNU Emacs is free software: you can redistribute it and/or modify
3883 it under the terms of the GNU General Public License as published by
3884 the Free Software Foundation, either version 3 of the License, or
3885 (at your option) any later version.
3886
3887 GNU Emacs is distributed in the hope that it will be useful,
3888 but WITHOUT ANY WARRANTY; without even the implied warranty of
3889 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3890 GNU General Public License for more details.
3891
3892 You should have received a copy of the GNU General Public License
3893 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.