* lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
13bdea59
PE
12011-06-13 Paul Eggert <eggert@cs.ucla.edu>
2
193e32d9
PE
3 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4
e5533da6
PE
5 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
6
9910e595
PE
7 GLYPH_CODE_FACE returns EMACS_INT, not int.
8 * dispextern.h (merge_faces):
9 * xfaces.c (merge_faces):
10 * xdisp.c (get_next_display_element):
11 (next_element_from_display_vector): Don't assume EMACS_INT fits in int.
12
2638320e
PE
13 * character.h (CHAR_VALID_P): Remove unused parameter.
14 * fontset.c, lisp.h, xdisp.c: All uses changed.
15
045eb8d9
PE
16 * editfns.c (Ftranslate_region_internal): Omit redundant test.
17
c1f134b5
PE
18 * fns.c (concat): Minor tuning based on overflow analysis.
19 This doesn't fix any bugs. Use int to hold character, instead
20 of constantly refetching from Emacs object. Use XFASTINT, not
21 XINT, for value known to be a character. Don't bother comparing
22 a single byte to 0400, as it's always less.
23
395fcb93 24 * floatfns.c (Fexpt):
327eeec8
PE
25 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
26
abbd3d23
PE
27 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
28 for characters.
29
684a03ef
PE
30 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
31
0fed43f3
PE
32 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
33 Without this fix, on a 64-bit host (aset S 0 4294967386) would
34 incorrectly succeed when S was a string, because 4294967386 was
35 truncated before it was used.
36
8fd02eb7
PE
37 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
38 Otherwise, an out-of-range integer could cause undefined behavior
39 on a 64-bit host.
40
f8c86b69
PE
41 * composite.c: Use int, not EMACS_INT, for characters.
42 (fill_gstring_body, composition_compute_stop_pos): Use int, not
43 EMACS_INT, for values that are known to be in character range.
44 This doesn't fix any bugs but is the usual style inside Emacs and
45 may generate better code on 32-bit machines.
46
34206dd2
PE
47 Make sure a 64-bit char is never passed to ENCODE_CHAR.
48 This is for reasons similar to the recent CHAR_STRING fix.
49 * charset.c (Fencode_char): Check that character arg is actually
50 a character. Pass an int to ENCODE_CHAR.
51 * charset.h (ENCODE_CHAR): Verify that the character argument is no
52 wider than 'int', as a compile-time check to prevent future regressions
53 in this area.
54
c5958d4c 55 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
56
57 Make sure a 64-bit char is never passed to CHAR_STRING.
58 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
59 by silently ignoring the top 32 bits, allowing some values
60 that were far too large to be valid characters.
61 * character.h: Include <verify.h>.
62 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
63 arguments are no wider than unsigned, as a compile-time check
64 to prevent future regressions in this area.
65 * data.c (Faset):
66 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char):
67 (Fsubst_char_in_region):
68 * fns.c (concat):
69 * xdisp.c (decode_mode_spec_coding):
70 Adjust to CHAR_STRING's new requirement.
71 * editfns.c (Finsert_char, Fsubst_char_in_region):
72 * fns.c (concat): Check that character args are actually
73 characters. Without this test, these functions did the wrong
74 thing with wildly out-of-range values on 64-bit hosts.
75
ea204efb
PE
762011-06-12 Paul Eggert <eggert@cs.ucla.edu>
77
d37ca623
PE
78 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
79 These casts should not be needed on 32-bit hosts, either.
80 * keyboard.c (read_char):
81 * lread.c (Fload): Remove casts to unsigned.
82
ea204efb
PE
83 * lisp.h (UNSIGNED_CMP): New macro.
84 This fixes comparison bugs on 64-bit hosts.
85 (ASCII_CHAR_P): Use it.
86 * casefiddle.c (casify_object):
87 * character.h (ASCII_BYTE_P, CHAR_VALID_P):
88 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
89 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
90 * dispextern.h (FACE_FROM_ID):
91 * keyboard.c (read_char): Use UNSIGNED_CMP.
92
fc83f7d3 932011-06-11 Paul Eggert <eggert@cs.ucla.edu>
666398f3 94
41cb286c
PE
95 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
96 not to EMACS_INT, to avoid GCC warning.
97
4a1b9832
PE
98 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
99
55daad71
PE
100 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
101 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
102 isn't needed on 32-bit machines.
8f95c75c 103
666398f3 104 * buffer.c (Fgenerate_new_buffer_name): Use EMACS_INT for count, not int.
0ceccced 105 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
106
107 * data.c (Qcompiled_function): Now static.
108
c6f072e7
PE
109 * window.c (window_body_lines): Now static.
110
20ce5912
PE
111 * image.c (gif_load): Rename local to avoid shadowing.
112
9c4c5f81
PE
113 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
114 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
115 * alloc.c (make_save_value): Integer argument is now of type
116 ptrdiff_t, not int.
117 (mark_object): Use ptrdiff_t, not int.
118 * lisp.h (pD): New macro.
119 * print.c (print_object): Use it.
120
c0c5c8ae
PE
121 * alloc.c: Use EMACS_INT, not int, to count objects.
122 (total_conses, total_markers, total_symbols, total_vector_size)
123 (total_free_conses, total_free_markers, total_free_symbols)
124 (total_free_floats, total_floats, total_free_intervals, total_intervals)
125 (total_strings, total_free_strings):
126 Now EMACS_INT, not int. All uses changed.
127 (Fgarbage_collect): Compute overall total using a double, so that
128 integer overflow is less likely to be a problem. Check for overflow
129 when converting back to an integer.
5a25e253
PE
130 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
131 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
132 These were 'int' variables that could overflow on 64-bit hosts;
133 they were never used, so remove them instead of repairing them.
211a0b2a 134 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
135 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
136 Previously, this ceilinged at INT_MAX, but that doesn't work on
137 64-bit machines.
e46bb31a 138 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 139
c78baabf 140 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 141 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
142 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
143 when a (possibly-narrower) signed value would do just as well.
144 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 145
c9d624c6
PE
146 * alloc.c: Catch some string size overflows that we were missing.
147 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
148 for convenience in STRING_BYTES_MAX.
149 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
150 The definition here is exact; the one in lisp.h was approximate.
151 (allocate_string_data): Check for string overflow. This catches
152 some instances we weren't catching before. Also, it catches
153 size_t overflow on (unusual) hosts where SIZE_MAX <= min
154 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
155 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 156
c9d624c6
PE
157 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
158 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
159 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
160
353032ce
PE
161 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
162
2bccce07
PE
163 * alloc.c (Fmake_string): Check for out-of-range init.
164
b50691aa
CY
1652011-06-11 Chong Yidong <cyd@stupidchicken.com>
166
167 * dispextern.h (struct image): Replace data member, whose int_val
168 and ptr_val fields were not used by anything, with a single
169 lisp_val object.
170
171 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
172 (gif_clear_image, gif_load, imagemagick_load_image)
173 (gs_clear_image, gs_load): Callers changed.
174
3f754b86
PE
1752011-06-10 Paul Eggert <eggert@cs.ucla.edu>
176
cca69397
PE
177 * buffer.h: Include <time.h>, for time_t.
178 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
179
109e28d0
PE
180 Fix minor problems found by static checking.
181
60737f02
PE
182 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
183
4b66faf3
PE
184 Make identifiers static if they are not used in other modules.
185 * data.c (Qcompiled_function, Qframe, Qvector):
186 * image.c (QimageMagick, Qsvg):
187 * minibuf.c (Qmetadata):
188 * window.c (resize_window_check, resize_root_window): Now static.
189 * window.h (resize_window_check, resize_root_window): Remove decls.
190
109e28d0
PE
191 * window.c (window_deletion_count, delete_deletable_window):
192 Remove; unused.
46a4ce9e
PE
193 (window_body_lines): Now static.
194 (Fdelete_other_windows_internal): Mark vars as initialized.
195 Make sure 'resize_failed' is initialized.
196 (run_window_configuration_change_hook): Rename local to avoid shadowing.
197 (resize_window_apply): Remove unused local.
198 * window.h (delete_deletable_window): Remove decl.
199
109e28d0 200 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
201 (imagemagick_load_image): Fix pointer signedness problem by changing
202 last arg from unsigned char * to char *. All uses changed.
203 Also, fix a local for similar reasons.
204 Remove unused locals. Remove locals to avoid shadowing.
205 (fn_rsvg_handle_free): Remove; unused.
206 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 207 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 208
3f754b86
PE
209 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
210
2547adb1
CY
2112011-06-10 Chong Yidong <cyd@stupidchicken.com>
212
213 * image.c (gif_load): Fix omitted cast error introduced by
214 2011-06-06 change.
215
2c8e37d4
MR
2162011-06-10 Martin Rudalics <rudalics@gmx.at>
217
218 * window.h (resize_proportionally, orig_total_lines)
219 (orig_top_line): Remove from window structure.
220 (set_window_height, set_window_width, change_window_heights)
221 (Fdelete_window): Remove prototypes.
222 (resize_frame_windows): Remove duplicate declaration.
223
440a42e3
EZ
2242011-06-10 Eli Zaretskii <eliz@gnu.org>
225
226 * window.h (resize_frame_windows, resize_window_check)
227 (delete_deletable_window, resize_root_window)
228 (resize_frame_windows): Declare prototypes.
229
230 * window.c (resize_window_apply): Make definition be "static" to
231 match the prototype.
232
562dd5e9
MR
2332011-06-10 Martin Rudalics <rudalics@gmx.at>
234
235 * window.c: Remove declarations of Qwindow_size_fixed,
236 window_min_size_1, window_min_size_2, window_min_size,
237 size_window, window_fixed_size_p, enlarge_window, delete_window.
238 Remove static from declaration of Qdelete_window, it's
239 temporarily needed by Fbury_buffer.
240 (replace_window): Don't assign orig_top_line and
241 orig_total_lines.
242 (Fdelete_window, delete_window): Remove. Window deletion is
243 handled by window.el.
244 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
245 Fdelete_window calls with calls to Qdelete_window.
246 (Fdelete_other_windows): Remove. Deleting other windows is
247 handled by window.el.
248 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
249 handled in window.el.
250 (window_min_size_2, window_min_size_1, window_min_size): Remove.
251 Window minimum sizes are handled in window.el.
252 (shrink_windows, size_window, set_window_height)
253 (set_window_width, change_window_heights, window_height)
254 (window_width, CURBEG, CURSIZE, enlarge_window)
255 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
256 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
257 handled in window.el.
258 (make_dummy_parent): Rename to make_parent_window and give it a
259 second argument horflag.
260 (make_window): Don't set resize_proportionally any more.
261 (Fsplit_window): Remove. Windows are split in window.el.
262 (save_restore_action, save_restore_orig_size)
263 (shrink_window_lowest_first, save_restore_orig_size): Remove.
264 Resize mini windows in window.el.
265 (grow_mini_window, shrink_mini_window): Implement by calling
266 Qresize_root_window_vertically, resize_window_check and
267 resize_window_apply.
268 (saved_window, Fset_window_configuration, save_window_save): Do
269 not handle orig_top_line, orig_total_lines, and
270 resize_proportionally.
271 (window_min_height, window_min_width): Move to window.el.
272 (keys_of_window): Move bindings for delete-other-windows,
273 split-window, delete-window and enlarge-window to window.el.
274
275 * buffer.c: Temporarily extern Qdelete_window.
276 (Fbury_buffer): Temporarily call Qdelete_window instead of
277 Fdelete_window (Fbury_buffer will move to window.el soon).
278
279 * frame.c (set_menu_bar_lines_1): Remove code handling
280 orig_top_line and orig_total_lines.
281
282 * dispnew.c (adjust_frame_glyphs_initially): Don't use
283 set_window_height but set heights directly.
284 (change_frame_size_1): Use resize_frame_windows.
285
286 * xdisp.c (init_xdisp): Don't use set_window_height but set
287 heights directly.
288
289 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
290 resize_frame_windows instead of change_window_heights and run
291 run_window_configuration_change_hook.
292
293 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
294 instead of change_window_heights and run
295 run_window_configuration_change_hook.
296
1a13852e
MR
2972011-06-09 Martin Rudalics <rudalics@gmx.at>
298
299 * window.c (replace_window): Rename second argument REPLACEMENT to
300 NEW. New third argument SETFLAG. Rewrite.
301 (delete_window, make_dummy_parent): Call replace_window with
302 third argument 1.
303 (window_list_1): Move down in code.
304 (run_window_configuration_change_hook): Move set_buffer part
305 before select_frame_norecord part in order to unwind correctly.
306 Rename count1 to count.
307 (recombine_windows, delete_deletable_window, resize_root_window)
308 (Fdelete_other_windows_internal)
309 (Frun_window_configuration_change_hook, make_parent_window)
310 (resize_window_check, resize_window_apply, Fresize_window_apply)
311 (resize_frame_windows, Fsplit_window_internal)
312 (Fdelete_window_internal, Fresize_mini_window_internal): New
313 functions.
314 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
315
f3d1777e
MR
3162011-06-08 Martin Rudalics <rudalics@gmx.at>
317
496e208e
MR
318 * window.h (window): Add some new members to window structure -
319 normal_lines, normal_cols, new_total, new_normal, clone_number,
320 splits, nest, prev_buffers, next_buffers.
321 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 322 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 323
f3d1777e
MR
324 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
325 Remove.
496e208e
MR
326 (make_dummy_parent): Set new members of windows structure.
327 (make_window): Move down in code. Handle new members of window
328 structure.
329 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
330 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
331 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
332 (Fset_window_prev_buffers, Fwindow_next_buffers)
333 (Fset_window_next_buffers, Fset_window_clone_number): New
334 functions.
335 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
336 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
337 Doc-string fixes.
338 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
339 Argument WINDOW can be now internal window too.
340 (Fwindow_use_time): Move up in code.
341 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
342 Rewrite doc-string.
343 (Fset_window_configuration, saved_window)
344 (Fcurrent_window_configuration, save_window_save): Handle new
345 members of window structure.
b9e809c2
MR
346 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
347 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
348 (syms_of_window): New Lisp objects Qrecord_window_buffer,
349 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
350 Qget_mru_window, Qresize_root_window,
351 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
352 Qauto_buffer_name; staticpro them.
f3d1777e 353
abde8f8c
MR
3542011-06-07 Martin Rudalics <rudalics@gmx.at>
355
356 * window.c (Fwindow_total_size, Fwindow_left_column)
357 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
358 (Fwindow_list_1): New functions.
359 (window_box_text_cols): Replace with window_body_cols.
360 (Fwindow_width, Fscroll_left, Fscroll_right): Use
361 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
362 (delete_window, Fset_window_configuration): Call
363 delete_all_subwindows with window as argument.
364 (delete_all_subwindows): Take a window as argument and not a
365 structure. Rewrite.
190b47e6
MR
366 (window_loop): Remove handling of GET_LRU_WINDOW and
367 GET_LARGEST_WINDOW.
368 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
369
370 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
371 window_box_text_cols. delete_all_subwindows now takes a
372 Lisp_Object as argument.
abde8f8c
MR
373
374 * indent.c (compute_motion, Fcompute_motion): Use
375 window_body_cols instead of window_box_text_cols.
376
fa8a67e6
MR
377 * frame.c (delete_frame): Call delete_all_subwindows with root
378 window as argument.
379
a54e3482
DC
3802011-06-07 Daniel Colascione <dan.colascione@gmail.com>
381
382 * fns.c (Fputhash): Document return value.
383
60002bf5
CY
3842011-06-06 Chong Yidong <cyd@stupidchicken.com>
385
386 * image.c (gif_load): Implement gif89a spec "no disposal" method.
387
0c671da6 3882011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 389
b862a52a 390 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 391
be44ca6c
PE
392 Check for overflow when converting integer to cons and back.
393 * charset.c (Fdefine_charset_internal, Fdecode_char):
394 Use cons_to_unsigned to catch overflow.
395 (Fencode_char): Use INTEGER_TO_CONS.
396 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
397 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
398 * data.c (long_to_cons, cons_to_long): Remove.
399 (cons_to_unsigned, cons_to_signed): New functions.
400 These signal an error for invalid or out-of-range values.
401 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
402 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
403 * font.c (Ffont_variation_glyphs):
404 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
405 * lisp.h: Include <intprops.h>.
406 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
407 (cons_to_signed, cons_to_unsigned): New decls.
408 (long_to_cons, cons_to_long): Remove decls.
409 * undo.c (record_first_change): Use INTEGER_TO_CONS.
410 (Fprimitive_undo): Use CONS_TO_INTEGER.
411 * xfns.c (Fx_window_property): Likewise.
412 * xselect.c: Include <limits.h>.
413 (x_own_selection, selection_data_to_lisp_data):
414 Use INTEGER_TO_CONS.
415 (x_handle_selection_request, x_handle_selection_clear)
416 (x_get_foreign_selection, Fx_disown_selection_internal)
417 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
418 (lisp_data_to_selection_data): Use cons_to_unsigned.
419 (x_fill_property_data): Use cons_to_signed.
420 Report values out of range.
421
d1f3d2af
PE
422 Check for buffer and string overflow more precisely.
423 * buffer.h (BUF_BYTES_MAX): New macro.
424 * lisp.h (STRING_BYTES_MAX): New macro.
425 * alloc.c (Fmake_string):
426 * character.c (string_escape_byte8):
427 * coding.c (coding_alloc_by_realloc):
428 * doprnt.c (doprnt):
429 * editfns.c (Fformat):
430 * eval.c (verror):
431 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
432 since they may not be the same number.
433 * editfns.c (Finsert_char):
434 * fileio.c (Finsert_file_contents):
435 Likewise for BUF_BYTES_MAX.
436
dd52fcea
PE
437 * image.c: Use ptrdiff_t, not int, for sizes.
438 (slurp_file): Switch from int to ptrdiff_t.
439 All uses changed.
440 (slurp_file): Check that file size fits in both size_t (for
441 malloc) and ptrdiff_t (for sanity and safety).
442
7f9bbdbb
PE
443 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
444 if b->modtime has its maximal value.
445
dfe18f82
PE
446 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
447
84acfcf0
PE
448 Don't assume time_t can fit into int.
449 * buffer.h (struct buffer.modtime): Now time_t, not int.
450 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
451 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
452
ccd9a01a
PE
453 Minor fixes for signed vs unsigned integers.
454 * character.h (MAYBE_UNIFY_CHAR):
455 * charset.c (maybe_unify_char):
456 * keyboard.c (read_char, reorder_modifiers):
457 XINT -> XFASTINT, since the integer must be nonnegative.
458 * ftfont.c (ftfont_spec_pattern):
459 * keymap.c (access_keymap, silly_event_symbol_error):
460 XUINT -> XFASTINT, since the integer must be nonnegative.
461 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
462 since it makes no difference and we prefer signed.
463 * keyboard.c (record_char): Use XUINT when all the neighbors do.
464 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
465 nonnegative.
466
d6d100dd
SM
4672011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
468
469 * window.h (Fwindow_frame): Declare.
470
2b6148e4
PE
4712011-06-06 Paul Eggert <eggert@cs.ucla.edu>
472
473 * alloc.c: Simplify handling of large-request failures (Bug#8800).
474 (SPARE_MEMORY): Always define.
475 (LARGE_REQUEST): Remove.
476 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
477
f230ecc9
MR
4782011-06-06 Martin Rudalics <rudalics@gmx.at>
479
727e958e
MR
480 * lisp.h: Move EXFUNS for Fframe_root_window,
481 Fframe_first_window and Fset_frame_selected_window to window.h.
482
483 * window.h: Move EXFUNS for Fframe_root_window,
484 Fframe_first_window and Fset_frame_selected_window here from
485 lisp.h.
486
487 * frame.c (Fwindow_frame, Fframe_first_window)
488 (Fframe_root_window, Fframe_selected_window)
489 (Fset_frame_selected_window): Move to window.c.
490 (Factive_minibuffer_window): Move to minibuf.c.
491 (Fother_visible_frames_p): New function.
492
493 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
494
f230ecc9
MR
495 * window.c (decode_window, decode_any_window): Move up in code.
496 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
497 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
498 (Fwindow_buffer): Move up and rewrite doc-string.
499 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
500 (Fwindow_prev): New functions.
727e958e
MR
501 (Fwindow_frame): Move here from frame.c. Accept any window as
502 argument.
503 (Fframe_root_window, Fframe_first_window)
504 (Fframe_selected_window): Move here from frame.c. Accept frame
505 or arbitrary window as argument. Update doc-strings.
506 (Fminibuffer_window): Move up in code.
507 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
508 (Fset_frame_selected_window): Move here from frame.c.
509 Marginal rewrite.
727e958e
MR
510 (Fselected_window, select_window, Fselect_window): Move up in
511 code. Minor doc-string fixes.
f230ecc9 512
4d09bcf6
PE
5132011-06-06 Paul Eggert <eggert@cs.ucla.edu>
514
515 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
516 Do not assume that spare memory exists; that assumption is valid
517 only if SYSTEM_MALLOC.
518 (LARGE_REQUEST): New macro, so that the issue of large requests
519 is separated from the issue of spare memory.
520
810928a2
AS
5212011-06-05 Andreas Schwab <schwab@linux-m68k.org>
522
172418ad
AS
523 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
524 format. (Bug#8806)
525
43f862f7
AS
526 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
527
810928a2
AS
528 * xfns.c (x_set_scroll_bar_default_width): Move declarations
529 before statements.
530
a059fe24
JD
5312011-06-05 Jan Djärv <jan.h.d@swipnet.se>
532
533 * gtkutil.c (xg_get_default_scrollbar_width): New function.
534
535 * gtkutil.h: Declare xg_get_default_scrollbar_width.
536
537 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
538 min width by calling x_set_scroll_bar_default_width (Bug#8505).
539
989bf368
JB
5402011-06-05 Juanma Barranquero <lekktu@gmail.com>
541
542 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
543
4b80f674
CY
5442011-06-04 Chong Yidong <cyd@stupidchicken.com>
545
546 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
547 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
548 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
549 New error handlers.
4b80f674
CY
550 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
551 Obey Vx_select_enable_clipboard_manager. Catch errors in
552 x_clipboard_manager_save (Bug#8779).
553 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 554 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 555
99a33b77 5562011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
557
558 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
559
99a33b77 5602011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
561
562 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
563 in the current matrix if keep_current_p is non-zero.
564
8264569d
EZ
5652011-06-04 Eli Zaretskii <eliz@gnu.org>
566
567 * bidi.c (bidi_level_of_next_char): Fix last change.
568
57f97249
EZ
5692011-06-03 Eli Zaretskii <eliz@gnu.org>
570
fec2107c 571 Support bidi reordering of text covered by display properties.
57f97249 572
fec2107c
EZ
573 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
574 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
575 (bidi_cache_search, bidi_cache_iterator_state)
576 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
577 (bidi_level_of_next_char, bidi_move_to_visually_next):
578 Support character positions inside a run of characters covered by a
fec2107c
EZ
579 display string.
580 (bidi_paragraph_init, bidi_resolve_explicit_1)
581 (bidi_level_of_next_char): Call bidi_fetch_char and
582 bidi_fetch_char_advance instead of FETCH_CHAR and
583 FETCH_CHAR_ADVANCE.
584 (bidi_init_it): Initialize new members.
585 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
586 definitions.
587 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
588 instead of using explicit *_CHAR codes.
d6d100dd
SM
589 (bidi_resolve_explicit, bidi_resolve_weak):
590 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
591 bidirectional text is supported only in multibyte buffers.
592 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
593 it to initialize the frame_window_p member of struct bidi_it.
594 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
595 (bidi_resolve_explicit, bidi_resolve_weak)
596 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
597 bidi_it->nchars is non-positive.
598 (bidi_level_of_next_char): Don't try to lookup the cache for the
599 next/previous character if nothing is cached there yet, or if we
600 were just reseat()'ed to a new position.
c40e2fb2 601
0e14fe90
EZ
602 * xdisp.c (set_cursor_from_row): Set start and stop points
603 according to the row's direction when priming the loop that looks
604 for the glyph on which to display cursor.
605 (single_display_spec_intangible_p): Function deleted.
606 (display_prop_intangible_p): Reimplement to call
607 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
608 Accept 3 additional arguments needed by handle_display_spec.
609 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
610 values: lists, `(when COND...)' forms, etc.
611 (single_display_spec_string_p): Support property values that are
612 lists with the argument STRING its top-level element.
613 (display_prop_string_p): Fix the condition for processing a
614 property that is a list to be consistent with handle_display_spec.
fec2107c 615 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
616 last portion of handle_display_prop.
617 (compute_display_string_pos): Accept additional argument
618 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
619 value of a `display' property is a "replacing spec".
620 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
621 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
622 the display property, but just return a value indicating whether
623 the display property will replace the characters it covers.
624 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
625 frame_window_p members of struct bidi_it.
d6d100dd
SM
626 (compute_display_string_pos, compute_display_string_end):
627 New functions.
fec2107c
EZ
628 (push_it): Accept second argument POSITION, where pop_it should
629 jump to continue iteration.
630 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 631
fec2107c
EZ
632 * keyboard.c (adjust_point_for_property): Adjust the call to
633 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
634
635 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
636 (bidi_init_it): Update prototypes.
637 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
638 (compute_display_string_pos, compute_display_string_end):
639 Declare prototypes.
fec2107c
EZ
640 (struct bidi_it): New members nchars and disp_pos. ch_len is now
641 EMACS_INT.
fc6f18ce 642
40087514 6432011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 644
57f53182
PE
645 Malloc failure behavior now depends on size of allocation.
646 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
647 * lisp.h: Change signatures accordingly.
648 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
649 All callers changed. (Bug#8762)
650
651 * gnutls.c: Use Emacs's memory allocators.
652 Without this change, the gnutls library would invoke malloc etc.
653 directly, which causes problems on non-SYNC_INPUT hosts, and which
654 runs afoul of improving memory_full behavior. (Bug#8761)
655 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
656 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
657 xfree instead of the default malloc, realloc, free.
658 (Fgnutls_boot): No need to check for memory allocation failure,
659 since xmalloc does that for us.
660
ac32cd99 661 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
662 * category.c (hash_get_category_set):
663 * ccl.c (ccl_driver):
664 * charset.c (Fdefine_charset_internal):
665 * charset.h (struct charset.hash_index):
666 * composite.c (get_composition_id, gstring_lookup_cache)
667 (composition_gstring_put_cache):
668 * composite.h (struct composition.hash_index):
669 * dispextern.h (struct image.hash):
670 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
671 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
672 (hashfn_equal, hashfn_user_defined, make_hash_table)
673 (maybe_resize_hash_table, hash_lookup, hash_put)
674 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
675 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
676 (Fsxhash, Fgethash, Fputhash, Fmaphash):
677 * image.c (make_image, search_image_cache, lookup_image)
678 (xpm_put_color_table_h):
679 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 680 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
681 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
682 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
683 * alloc.c (allocate_vectorlike):
684 Check for overflow in vector size calculations.
685 * ccl.c (ccl_driver):
686 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
687 * fns.c, image.c: Remove unnecessary static decls that would otherwise
688 need to be updated by these changes.
40087514
PE
689 * fns.c (make_hash_table, maybe_resize_hash_table):
690 Check for integer overflow with large hash tables.
0de4bb68
PE
691 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
692 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
693 (SXHASH_REDUCE): New macro.
694 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
695 Use it instead of discarding useful hash info with large hash values.
696 (sxhash_float): New function.
697 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
698 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
699 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
700 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
701 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
702 Adjust signatures to match updated version of code.
703 (consing_since_gc): Now EMACS_INT, since a single hash table can
704 use more than INT_MAX bytes.
705
698d32e2
DN
7062011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
707
708 Make it possible to build with GCC-4.6+ -O2 -flto.
709
710 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
711
fd6fa53f
SM
7122011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
713
714 * minibuf.c (get_minibuffer, read_minibuf_unwind):
715 Call minibuffer-inactive-mode.
716
864db017
JB
7172011-05-31 Juanma Barranquero <lekktu@gmail.com>
718
719 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
720 Update dependencies.
721
2ad0baf4
DN
7222011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
723
724 * data.c (init_data): Remove code for UTS, this system is not
725 supported anymore.
726
4fcc2638
DN
7272011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
728
729 Don't force ./temacs to start in terminal mode.
730
731 * frame.c (make_initial_frame): Initialize faces in all cases, not
732 only when CANNOT_DUMP is defined.
733 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
734
c56e0fd5
DN
7352011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
736
737 * dispnew.c (add_window_display_history): Use const for the string
738 pointer. Remove declaration, not needed.
739
333d54da 7402011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 741
55d4c1b2 742 Use 'inline', not 'INLINE'.
333d54da 743 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
744 * alloc.c, fontset.c (INLINE): Remove.
745 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
746 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
747 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
748 * gmalloc.c (register_heapinfo): Use inline unconditionally.
749 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
750
738db178
DN
7512011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
752
753 Make it possible to run ./temacs.
754
755 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
756 syms_of_callproc does the same thing. Remove test for
757 "initialized", do it in the caller.
758 * emacs.c (main): Avoid calling set_initial_environment when dumping.
759
620c53a6
SM
7602011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
761
762 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
763 (read_minibuf): Use get_minibuffer.
764 (syms_of_minibuf): Use DEFSYM.
765 (Qmetadata): New var.
766 * data.c (Qbuffer): Don't make it static.
767 (syms_of_data): Use DEFSYM.
768
e003a292
PE
7692011-05-31 Paul Eggert <eggert@cs.ucla.edu>
770
771 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
772 (CCL_CODE_MIN): New macro.
773
ed008a6d
PE
7742011-05-30 Paul Eggert <eggert@cs.ucla.edu>
775
3687c2ef
PE
776 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
777
ed008a6d
PE
778 * eval.c (Qdebug): Now static.
779 * lisp.h (Qdebug): Remove decl. This reverts a part of the
780 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
781 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
782
d66c4c7c
CY
7832011-05-29 Chong Yidong <cyd@stupidchicken.com>
784
785 * image.c: Various fixes to ImageMagick code comments.
786 (Fimagemagick_types): Doc fix.
787
5fbc2025
PE
7882011-05-29 Paul Eggert <eggert@cs.ucla.edu>
789
0196f88a
PE
790 Minor fixes prompted by GCC 4.6.0 warnings.
791
792 * xselect.c (converted_selections, conversion_fail_tag): Now static.
793
5fbc2025
PE
794 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
795 (x_clipboard_manager_save_all): Move extern decl to ...
796 * xterm.h: ... here, so that it can be checked for consistency.
797
1dd3c2d9
CY
7982011-05-29 Chong Yidong <cyd@stupidchicken.com>
799
800 * xselect.c (x_clipboard_manager_save_frame)
801 (x_clipboard_manager_save_all): New functions.
802 (Fx_clipboard_manager_save): Lisp function deleted.
803
804 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
805 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
806
807 * xterm.h: Update prototype.
808
5ba6571d
WX
8092011-05-28 William Xu <william.xwl@gmail.com>
810
811 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
812 exiting (Bug#8239).
813
3eaff834
JM
8142011-05-28 Jim Meyering <meyering@redhat.com>
815
e1900994 816 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
817 * fns.c (to_uchar): Define.
818 (crypto_hash_function): Use it to convert some newly-signed
819 variables to unsigned, to avoid sign-extension bugs. For example,
820 without this change, (md5 "truc") would evaluate to
821 45723a2aff78ff4fff7fff1114760e62 rather than the expected
822 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 823 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 824
0f6990a7
PE
8252011-05-27 Paul Eggert <eggert@cs.ucla.edu>
826
827 Integer overflow fixes.
c8a9ca5a 828
08686060
PE
829 * dbusbind.c: Serial number integer overflow fixes.
830 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
831 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
832 to hold a serial number that is too large for a fixnum.
833 (Fdbus_method_return_internal, Fdbus_method_error_internal):
834 Check for serial numbers out of range. Decode any serial number
59568bf0 835 that was so large that it became a float. (Bug#8722)
08686060 836
2d1fc3c7
PE
837 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
838 (Fdbus_call_method, Fdbus_call_method_asynchronously):
839 Use XFASTINT rather than XUINT when numbers are nonnegative.
840 (xd_append_arg, Fdbus_method_return_internal):
841 (Fdbus_method_error_internal): Likewise. Also, for unsigned
842 arguments, check that Lisp number is nonnegative, rather than
59568bf0 843 silently wrapping negative numbers around. (Bug#8722)
30217ff0 844 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 845 (Bug#8722)
2d1fc3c7 846
c8a9ca5a
PE
847 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
848
519e1d69
PE
849 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
850
30569699
PE
851 ccl: add integer overflow checks
852 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
853 (IN_INT_RANGE): New macros.
854 (ccl_driver): Use them to check for integer overflow when
855 decoding a CCL program. Many of the new checks are whether XINT (x)
856 fits in int; it doesn't always, on 64-bit hosts. The new version
857 doesn't catch all possible integer overflows, but it's an
847044ea 858 improvement. (Bug#8719)
30569699 859
c11285dc
PE
860 * alloc.c (make_event_array): Use XINT, not XUINT.
861 There's no need for unsigned here.
862
fdccd48e
PE
863 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
864 This follows up to the 2011-05-06 change that substituted uintptr_t
865 for EMACS_INT. This case wasn't caught back then.
866
37910ab2
PE
867 Rework Fformat to avoid integer overflow issues.
868 * editfns.c: Include <float.h> unconditionally, as it's everywhere
869 now (part of C89). Include <verify.h>.
870 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
871 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
872 (Fformat): Avoid the prepass trying to compute sizes; it was only
873 approximate and thus did not catch overflow reliably. Instead, walk
874 through the format just once, formatting and computing sizes as we go,
875 checking for integer overflow at every step, and allocating a larger
876 buffer as needed. Keep track separately whether the format is
877 multibyte. Keep only the most-recently calculated precision, rather
878 than them all. Record whether each argument has been converted to
879 string. Use EMACS_INT, not int, for byte and char and arg counts.
880 Support field widths and precisions larger than INT_MAX. Avoid
881 sprintf's undefined behavior with conversion specifications such as %#d
882 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
883 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
884 formatting out-of-range floating point numbers with int
885 formats. (Bug#8668)
886
2e6578fb
PE
887 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
888
0ae6bdee
PE
889 * data.c: Avoid integer truncation in expressions involving floats.
890 * data.c: Include <intprops.h>.
891 (arith_driver): When there's an integer overflow in an expression
892 involving floating point, convert the integers to floating point
893 so that the resulting value does not suffer from catastrophic
894 integer truncation. For example, on a 64-bit host (* 4
895 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
896 Do not rely on undefined behavior after integer overflow.
897
de883a70
PE
898 merge count_size_as_multibyte, parse_str_to_multibyte
899 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 900 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
901 Check for integer overflow.
902 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
903 since it's now a duplicate of the other. This is more of
904 a character than a buffer op, so better that it's in character.c.
905 * fns.c, print.c: Adjust to above changes.
906
2ff916cb
PE
9072011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
908
909 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
910
f1b54466
PE
9112011-05-27 Paul Eggert <eggert@cs.ucla.edu>
912
fb1ac845
PE
913 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
914 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
915 (x_clipboard_manager_save): Now static.
916 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
917
f1b54466
PE
918 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
919 (crypto_hash_function): Now static.
920 Fix pointer signedness problems. Avoid unnecessary initializations.
921
a9f737ee
CY
9222011-05-27 Chong Yidong <cyd@stupidchicken.com>
923
924 * termhooks.h (Vselection_alist): Make it terminal-local.
925
926 * terminal.c (create_terminal): Initialize it.
927
928 * xselect.c: Support for clipboard managers.
929 (Vselection_alist): Move to termhooks.h as terminal-local var.
930 (LOCAL_SELECTION): New macro.
931 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
932 (symbol_to_x_atom): Remove gratuitous arg.
933 (x_handle_selection_request, lisp_data_to_selection_data)
934 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
935 (x_own_selection, x_get_local_selection, x_convert_selection):
936 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
937 (some_frame_on_display): Delete unused function.
938 (Fx_own_selection_internal, Fx_get_selection_internal)
939 (Fx_disown_selection_internal, Fx_selection_owner_p)
940 (Fx_selection_exists_p): New optional frame arg.
941 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
942 (x_handle_selection_clear): Don't treat other terminals with the
943 same keyboard specially. Use the terminal-local Vselection_alist.
944 (x_clear_frame_selections): Use Frun_hook_with_args.
945
946 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
947
948 * xterm.h: Add support for those atoms.
949
e067f0c1
CY
9502011-05-26 Chong Yidong <cyd@stupidchicken.com>
951
952 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
953 (converted_selections, conversion_fail_tag): New global variables.
954 (x_selection_request_lisp_error): Free the above.
955 (x_get_local_selection): Remove unnecessary code.
956 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
957 of converted selections stored in converted_selections.
958 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
959 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
960 (x_convert_selection): New function.
961 (x_handle_selection_event): Simplify.
962 (x_get_foreign_selection): Don't ignore incoming requests while
963 waiting for an answer; this will fail when we implement
964 SAVE_TARGETS, and seems unnecessary anyway.
965 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
966 (Vx_sent_selection_functions): Doc fix.
967
0f4aebc0
LL
9682011-05-26 Leo Liu <sdl.web@gmail.com>
969
970 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
971
e61124cd
YM
9722011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
973
974 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
975
976 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
977 for fringe update if it has periodic bitmap.
978 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
979 and fringe_bitmap_periodic_p.
980
981 * fringe.c (get_fringe_bitmap_data): New function.
982 (draw_fringe_bitmap_1, update_window_fringes): Use it.
983 (update_window_fringes): Record periodicity of fringe bitmap in glyph
984 row. Mark glyph row for fringe update if periodicity changed.
985
986 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
987 for fringe update unless it has periodic bitmap.
988
f16d9837
KH
9892011-05-25 Kenichi Handa <handa@m17n.org>
990
991 * xdisp.c (get_next_display_element): Set correct it->face_id for
992 a static composition.
993
e1b90ef6
LL
9942011-05-24 Leo Liu <sdl.web@gmail.com>
995
996 * deps.mk (fns.o):
997 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
998
999 * fns.c (crypto_hash_function, Fsha1): New function.
1000 (Fmd5): Use crypto_hash_function.
1001 (syms_of_fns): Add Ssha1.
1002
7400048f
PE
10032011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1004
1005 * gnutls.c: Remove unused macros.
1006 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1007 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1008 Remove macros that are defined and never used.
1009 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1010
abb71cf4
CY
10112011-05-22 Chong Yidong <cyd@stupidchicken.com>
1012
1013 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1014 (Fx_get_selection_internal): Minor cleanup.
1015 (Fx_own_selection_internal): Rename arguments for consistency with
1016 select.el.
1017
6307db39
PE
10182011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1019
1020 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1021
f3d4e0a4
CY
10222011-05-22 Chong Yidong <cyd@stupidchicken.com>
1023
1024 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1025
4d8ade89
YM
10262011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1027
1028 * dispnew.c (scrolling_window): Don't exclude the case that the
1029 last enabled row in the desired matrix touches the bottom boundary.
1030
32078c8d
GM
10312011-05-21 Glenn Morris <rgm@gnu.org>
1032
1033 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1034 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1035 and add some more files.
32078c8d 1036
7285dc67
EZ
10372011-05-20 Eli Zaretskii <eliz@gnu.org>
1038
1039 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1040 report_file_error introduced by the change from 2011-05-07.
1041
89d1bd22
PE
10422011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1043
1044 * systime.h (Time): Define only if emacs is defined.
1045 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1046 where the include path doesn't have X11/X.h by default. See
1047 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1048
e23640bb 10492011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1050
1051 * composite.c (find_automatic_composition): Fix previous change.
1052
b9704ad9
GM
10532011-05-20 Glenn Morris <rgm@gnu.org>
1054
1055 * lisp.mk: New file, split from Makefile.in.
1056 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1057 (shortlisp): Remove.
1058 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1059
4a720484
GM
10602011-05-19 Glenn Morris <rgm@gnu.org>
1061
1062 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1063 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1064 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1065 (lisp): Set the order to that of loadup.el.
1066 (shortlisp): Make it a copy of $lisp.
1067 (SOME_MACHINE_LISP): Remove.
1068 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1069 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1070
a28d4396
KH
10712011-05-18 Kenichi Handa <handa@m17n.org>
1072
1073 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1074 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1075 (find_automatic_composition): Mostly rewrite for efficiency.
1076
a2b1fa8e
JB
10772011-05-18 Juanma Barranquero <lekktu@gmail.com>
1078
1079 * makefile.w32-in: Update dependencies.
1080
8e1f5610
CS
10812011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1082
1083 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1084 revision 104625).
1085
7025ee00 10862011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1087
cdfa6eab
PE
1088 Fix some integer overflow issues, such as string length overflow.
1089
06d6db33
PE
1090 * insdel.c (count_size_as_multibyte): Check for string overflow.
1091
2b4560a8
PE
1092 * character.c (lisp_string_width): Check for string overflow.
1093 Use EMACS_INT, not int, for string indexes and lengths; in
1094 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1095 the resulting string length overflows an EMACS_INT; instead,
1096 report a string overflow if no precision given. When checking for
1097 precision exhaustion, use a check that cannot possibly have
1098 integer overflow. (Bug#8675)
1099 * character.h (lisp_string_width): Adjust to new signature.
1100
cb93f9be
PE
1101 * alloc.c (string_overflow): New function.
1102 (Fmake_string): Use it. This doesn't change behavior, but saves
1103 a few bytes and will simplify future changes.
1104 * character.c (string_escape_byte8): Likewise.
1105 * lisp.h (string_overflow): New decl.
1106
1a1f3366
PE
1107 Fixups, following up to the user-interface timestamp change.
1108 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1109 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1110 * msdos.c (mouse_get_pos): Likewise.
1111 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1112 * w32gui.h (Time): Define by including "systime.h" rather than by
1113 declaring it ourselves. (Bug#8664)
1114
d4e3e4d3
PE
1115 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1116 * image.c (clear_image_cache): Likewise.
1117
f6a24d19
PE
1118 * term.c (term_mouse_position): Don't assume time_t wraparound.
1119
08dc5ae6
PE
1120 Be more systematic about user-interface timestamps.
1121 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1122 and sometimes 'EMACS_UINT', to represent these timestamps.
1123 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1124 This makes the code easier to follow, and makes it easier to catch
1125 integer overflow bugs such as Bug#8664.
1126 * frame.c (Fmouse_position, Fmouse_pixel_position):
1127 Use Time, not unsigned long, for user-interface timestamps.
1128 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1129 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1130 * keyboard.h (last_event_timestamp): Likewise.
1131 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1132 * menu.h (xmenu_show): Likewise.
1133 * term.c (term_mouse_position): Likewise.
1134 * termhooks.h (struct input_event.timestamp): Likewise.
1135 (struct terminal.mouse_position_hook): Likewise.
1136 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1137 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1138 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1139 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1140 what it was before.
1141 * menu.h, termhooks.h: Include "systime.h", for Time.
1142
8e55734a
PE
1143 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1144 Don't assume that the difference between two unsigned long values
1145 can fit into an integer. At this point, we know button_down_time
1146 <= event->timestamp, so the difference must be nonnegative, so
1147 there's no need to cast the result if double-click-time is
1148 nonnegative, as it should be; check that it's nonnegative, just in
1149 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1150 apart (about 25 days). (Bug#8664)
8e55734a 1151
841f1b75 1152 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1153 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1154
3e26f69c
PE
1155 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1156 that always fit in int. Use a sentinel instead of a counter, to
1157 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1158 * frame.h (struct frame): Use int for menu_bar_items_used
1159 instead of EMACS_INT, since it always fits in int.
3e26f69c 1160
5cc152c0
PE
1161 * menu.c (grow_menu_items): Check for int overflow.
1162
d89eb65e
PE
1163 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1164
5235bd3e
PE
1165 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1166 Before, the code was not consistent. These values cannot exceed
1167 2**31 - 1 so there's no need to make them unsigned.
1168 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1169 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1170 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1171 as modifiers.
1172 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1173
bc827e23
PE
1174 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1175 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1176 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1177 presumably because the widths might not match.
1178
78eb494e
PE
1179 * window.c (size_window): Avoid needless test at loop start.
1180
04f2d78b
CB
11812011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1182
1183 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1184
d2fc7e3d 11852011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1186
1187 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1188
d2fc7e3d 11892011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1190
1191 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1192 `width' to `bar_area_x' and `bar_area_width', respectively.
1193 (x_scroll_run): Take account of fringe background extension.
1194
04f2d78b
CB
1195 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1196 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1197 `bar_area_width', respectively.
1198 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1199 background extension.
1200
79b70037
GM
12012011-05-10 Jim Meyering <meyering@redhat.com>
1202
1203 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1204
2f142cc5
JB
12052011-05-10 Juanma Barranquero <lekktu@gmail.com>
1206
1207 * image.c (Finit_image_library): Return t for built-in image types,
1208 like pbm and xbm. (Bug#8640)
1209
57679c86
AS
12102011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1211
1212 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1213
888c9e86
EZ
12142011-05-07 Eli Zaretskii <eliz@gnu.org>
1215
b0512a1d
EZ
1216 * w32console.c (Fset_screen_color): Doc fix.
1217 (Fget_screen_color): New function.
1218 (syms_of_ntterm): Defsubr it.
1219
7285dc67
EZ
1220 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1221 unlink the temporary file if Fcall_process didn't create it in the
1222 first place.
1223 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1224 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1225 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1226 cue to call_process_cleanup not to close that handle.
1227
4d3fcc8e
BK
12282011-05-07 Ben Key <bkey76@gmail.com>
1229
1230 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1231 one of two shell specific rules, either bootstrap-temacs-CMD or
1232 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1233 to the previous implementation of the bootstrap-temacs rule.
1234 The bootstrap-temacs-CMD rule is similar to the previous
1235 implementation of the bootstrap-temacs rule except that it
1236 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1237 variable.
1238
1239 These changes, along with some changes to nt/configure.bat,
1240 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1241 earlier fix to add support for --cflags and --ldflags options
1242 that include quotes so that it works whether make uses cmd or
1243 sh as the shell.
1244
b4289b64
MA
12452011-05-06 Michael Albinus <michael.albinus@gmx.de>
1246
1247 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1248 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1249 is a constant.
1250 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1251 a string. Handle both cases.
1252 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1253 (Fdbus_register_method): Use Qinvalid_function.
1254
af4c0e28
JB
12552011-05-06 Juanma Barranquero <lekktu@gmail.com>
1256
1257 * makefile.w32-in: Update dependencies.
1258 (LISP_H): Add inttypes.h and stdin.h.
1259 (PROCESS_H): Add unistd.h.
1260
c51453d9
EZ
12612011-05-06 Eli Zaretskii <eliz@gnu.org>
1262
1263 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1264 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1265
8ff0ac3c 12662011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1267
4c4b566b
PE
1268 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1269
aab2b9b5
PE
1270 * term.c (vfatal): Remove stray call to va_end.
1271 It's not needed and the C Standard doesn't allow it here anyway.
1272
c378da0b
PE
1273 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1274 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1275
288b08c7
PE
1276 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1277 bytes.
1278
e3601888
PE
1279 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1280
db6c0e74
PE
1281 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1282
dd5963ea
PE
1283 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1284
88c9450f
PE
1285 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1286
2f9442b8
PE
1287 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1288
c032b5f8
PE
1289 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1290 * charset.c (Fdefine_charset_internal): Don't initialize
1291 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1292 32-bit int (Bug#8600).
a108c10b
PE
1293
1294 * lread.c (read_integer): Be more consistent with string-to-number.
1295 Use string_to_number to do the actual conversion; this avoids
1296 rounding errors and fixes some other screwups. Without this fix,
1297 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1298 (digit_to_number): Move earlier, for benefit of read_integer.
1299 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1300 not a digit in any supported base. (Bug#8602)
a108c10b 1301
ad5f9eea
PE
1302 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1303
aec1708a
PE
1304 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1305 to match comment at start of function. This also removes a
1306 GCC warning about overflow in a 32+64-bit port.
1307
47be4ab5
PE
1308 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1309
371cac43
PE
1310 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1311 Reported by Stefan Monnier in
1312 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1313 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1314 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1315
d01a7826
PE
1316 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1317 (EMACS_UINTPTR): Likewise, with uintptr_t.
1318
7fd47d5c
PE
1319 * lisp.h: Prefer 64-bit EMACS_INT if available.
1320 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1321 on 32-bit hosts that have 64-bit int, so that they can access
1322 large files.
122b0c86
PE
1323 However, temporarily disable this change unless the temporary
1324 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1325
8727937b
PE
1326 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1327
8ac068ac
PE
1328 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1329 This removes an assumption that EMACS_INT and long are the same
1330 width as pointers. The assumption is true for Emacs porting targets
1331 now, but we want to make other targets possible.
1332 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1333 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1334 In the rest of the code, change types of integers that hold casted
1335 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1336 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1337 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1338 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1339 No need to cast type when ORing.
1340 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1341 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1342 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1343 assume EMACS_INT is the same width as char *.
1344 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1345 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1346 Remove no-longer-needed casts.
1347 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1348 (xg_tool_bar_help_callback, xg_make_tool_item):
1349 Use EMACS_INTPTR to hold an integer
1350 that will be cast to void *; this can avoid a GCC warning
1351 if EMACS_INT is not the same width as void *.
1352 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1353 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1354 (current_message_1, set_message_1):
1355 Use a local to convert to proper width without a cast.
1356 * xmenu.c (dialog_selection_callback): Likewise.
1357
ede49d71
PE
1358 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1359 Also, don't assume VALBITS / RAND_BITS is less than 5,
1360 and don't rely on undefined behavior when shifting a 1 left into
1361 the sign bit.
1362 * lisp.h (get_random): Change signature to match.
1363
2f30ecd0
PE
1364 * lread.c (hash_string): Use size_t, not int, for hash computation.
1365 Normally we prefer signed values; but hashing is special, because
1366 it's better to use unsigned division on hash table sizes so that
1367 the remainder is nonnegative. Also, size_t is the natural width
1368 for hashing into memory. The previous code used 'int', which doesn't
1369 retain enough info to hash well into very large tables.
1370 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1371
2a866e7b
PE
1372 * dbusbind.c: Don't possibly lose pointer info when converting.
1373 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1374 Use XPNTR rather than XHASH, so that the high-order bits of
1375 the pointer aren't lost when converting through void *.
1376
51639eac
PE
1377 * eval.c (Fautoload): Don't double-shift a pointer.
1378
92394119
PE
1379 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1380
dbdb9a7c
JB
13812011-05-06 Juanma Barranquero <lekktu@gmail.com>
1382
1383 * gnutls.c (DEF_GNUTLS_FN):
1384 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1385
db7a0b4f
AS
13862011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1387
1388 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1389 marker. (Bug#8610)
1390
f7ff1b0f 13912011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1392
1393 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1394 New version that can reserve upto 2GB of heap space.
1395
f7ff1b0f 13962011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1397
1398 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1399
639c109b
TZ
14002011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1401
1402 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1403 `gnutls_certificate_set_x509_key_file'.
1404
d2127135
JB
14052011-05-05 Juanma Barranquero <lekktu@gmail.com>
1406
1407 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1408 Update dependencies.
1409
e968f4f3
JB
14102011-05-04 Juanma Barranquero <lekktu@gmail.com>
1411
1412 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1413 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1414 Remove unused parameter `fildes'.
1415 * process.c (read_process_output, send_process): Don't pass it.
1416
84d358f0
JB
14172011-05-04 Juanma Barranquero <lekktu@gmail.com>
1418
1419 Fix previous change: the library cache is defined in w32.c.
1420 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1421 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1422
0898ca10
JB
14232011-05-04 Juanma Barranquero <lekktu@gmail.com>
1424
1425 Implement dynamic loading of GnuTLS on Windows.
1426
1427 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1428 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1429 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1430 Declare.
1431
1432 * gnutls.c (Qgnutls_dll): Define.
1433 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1434 (gnutls_*): Declare function pointers.
1435 (init_gnutls_functions): New function to initialize function pointers.
1436 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1437 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1438 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1439 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1440 (emacs_gnutls_write, emacs_gnutls_read)
1441 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1442 (Fgnutls_available_p): New function.
1443 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1444 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1445 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1446
1447 * image.c: Include w32.h.
1448 (Vimage_type_cache): Delete.
1449 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1450 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1451 (w32_delayed_load): Move to w32.c.
1452
1453 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1454
1455 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1456 (w32_delayed_load): Move from image.c. When loading a library, record
1457 its filename in the :loaded-from property of the library id.
1458 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1459 Initialize and staticpro them.
1460 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1461
1462 * process.c: Include lisp.h before w32.h, not after.
1463 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1464 instead of gnutls_record_check_pending.
1465
1466 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1467
ff4de4aa
TZ
14682011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1469
1470 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1471 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1472 as passed in.
1473
abe95abb
JD
14742011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1475
1476 * xterm.c (x_set_frame_alpha): Do not set property on anything
1477 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1478
e16e55d4
JB
14792011-05-02 Juanma Barranquero <lekktu@gmail.com>
1480
1481 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1482
bafcf6a5
JB
14832011-05-02 Juanma Barranquero <lekktu@gmail.com>
1484
1485 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1486 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1487 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1488 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1489 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1490 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1491 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1492 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1493 (Qgnutls_bootprop_callbacks_verify): Make static.
1494
e7a6747f
AS
14952011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1496
19ed11ba
AS
1497 * callproc.c: Indentation fixup.
1498
e7a6747f 1499 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1500 (wait_for_termination, interruptible_wait_for_termination):
1501 Move after wait_for_termination_1.
e7a6747f 1502
1ef14cb4
LMI
15032011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1504
1505 * sysdep.c (interruptible_wait_for_termination): New function
1506 which is like wait_for_termination, but allows keyboard
1507 interruptions.
1508
1509 * callproc.c (Fcall_process): Add (:file "file") as an option for
1510 the STDOUT buffer.
1511 (Fcall_process_region): Ditto.
1512
330d880c
EZ
15132011-04-30 Eli Zaretskii <eliz@gnu.org>
1514
8db90b73
EZ
1515 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1516 rather than `XVECTOR (FOO)->size'.
1517
330d880c
EZ
1518 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1519 inttypes.h, as a gnulib replacement is used if it not available in
1520 system headers.
1521
15cbd324
EZ
15222011-04-21 Eli Zaretskii <eliz@gnu.org>
1523
1524 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1525 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1526 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1527
1528 * coding.c (coding_alloc_by_realloc): Error out if destination
1529 will grow beyond MOST_POSITIVE_FIXNUM.
1530 (decode_coding_emacs_mule): Abort if there isn't enough place in
1531 charbuf for the composition carryover bytes. Reserve an extra
1532 space for up to 2 characters produced in a loop.
1533 (decode_coding_iso_2022): Abort if there isn't enough place in
1534 charbuf for the composition carryover bytes.
1535
15362011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1537
ae940cca
EZ
1538 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1539 aborting when %lld or %lll format is passed.
1540 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1541 %llo or %llx format is passed. (Bug#8545)
1542
03ab8921
EZ
1543 * window.c (window_scroll_line_based): Use a marker instead of
1544 simple variables to record original value of point. (Bug#7952)
1545
afda1437
EZ
1546 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1547 produced by %s or %c overflows available buffer space. (Bug#8545)
1548
f76dee0c
PE
15492011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1550
1551 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1552 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1553
fdc5744d
JB
15542011-04-28 Juanma Barranquero <lekktu@gmail.com>
1555
1556 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1557
638f053a
JB
15582011-04-28 Juanma Barranquero <lekktu@gmail.com>
1559
1560 * keyboard.c (Qdelayed_warnings_hook): Define.
1561 (command_loop_1): Run `delayed-warnings-hook'
1562 if Vdelayed_warnings_list is non-nil.
1563 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1564 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1565
d178f871
EZ
15662011-04-28 Eli Zaretskii <eliz@gnu.org>
1567
1568 * doprnt.c (doprnt): Don't return value smaller than the buffer
1569 size if the message was truncated. (Bug#8545).
1570
b124fd93
JB
15712011-04-28 Juanma Barranquero <lekktu@gmail.com>
1572
1573 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1574 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1575
e810457d
PE
15762011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1577
1578 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1579
ea51cceb
JB
15802011-04-27 Juanma Barranquero <lekktu@gmail.com>
1581
1582 * makefile.w32-in: Update dependencies.
1583
94dcfacf
EZ
15842011-04-27 Eli Zaretskii <eliz@gnu.org>
1585
1586 Improve `doprnt' and its usage. (Bug#8545)
1587 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1588 `format_end'. Remove support for %l as a conversion specifier.
1589 Don't use xrealloc. Improve diagnostics when the %l size modifier
1590 is used. Update the commentary.
1591
1592 * eval.c (verror): Simplify calculation of size_t.
1593
1594 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1595 messages.
1596
f61f41d7
PE
15972011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1598
1599 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1600 change.
1601
96fb4434
PE
16022011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1603
1604 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1605 This makes this file independent of the recent pseudovector change.
1606
671875da 16072011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1608
69e9b5a3
PE
1609 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1610
b5f869a7 1611 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1612 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1613 Remove unused local.
c8926152 1614 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1615
841a1577 1616 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1617 GCC 4.6.0 optimizes based on type-based alias analysis.
1618 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1619 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1620 != &v->size, and therefore "v->size = 1; b->size = 2; return
1621 v->size;" must therefore return 1. This assumption is incorrect
1622 for Emacs, since it type-puns struct Lisp_Vector * with many other
1623 types. To fix this problem, this patch adds a new type struct
f904488f 1624 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1625 and pseudovectors, and helps optimizing compilers not get fooled
1626 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1627 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1628 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1629 the size member.
eab3844f
PE
1630 (XSETPVECTYPE): Rewrite in terms of new macro.
1631 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1632 This is a bit clearer, and further avoids the possibility of
1633 undesirable aliasing.
1634 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1635 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1636 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1637 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1638 (ASIZE): Now uses header.size rather than size.
1639 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1640 to avoid the hassle of writing XVECTOR (foo)->header.size.
1641 (struct vectorlike_header): New type.
eab3844f
PE
1642 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1643 object, to help avoid aliasing.
1644 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1645 (SUBRP): Likewise, since Lisp_Subr is a special case.
1646 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1647 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1648 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1649 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1650 changed to be "header.size" and "header.next".
1651 * buffer.h (struct buffer): Likewise.
1652 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1653 * frame.h (struct frame): Likewise.
1654 * process.h (struct Lisp_Process): Likewise.
1655 * termhooks.h (struct terminal): Likewise.
1656 * window.c (struct save_window_data, struct saved_window): Likewise.
1657 * window.h (struct window): Likewise.
1658 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1659 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1660 * buffer.c (init_buffer_once): Likewise.
1661 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1662 special case.
1663 * process.c (Fformat_network_address): Use local var for size,
1664 for brevity.
1665
0df1eac5
PE
1666 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1667
847ab9d1 1668 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1669 * data.c (atof): Remove decl; no longer used or needed.
1670 (digit_to_number): Move to lread.c.
1671 (Fstring_to_number): Use new string_to_number function, to be
1672 consistent with how the Lisp reader treats infinities and NaNs.
1673 Do not assume that floating-point numbers represent EMACS_INT
1674 without losing information; this is not true on most 64-bit hosts.
1675 Avoid double-rounding errors, by insisting on integers when
1676 parsing non-base-10 numbers, as the documentation specifies.
1677 * lisp.h (string_to_number): New decl, replacing ...
1678 (isfloat_string): Remove.
bc0a5c13 1679 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1680 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1681 appears to have been a coding error. Similarly, do not accept
1682 strings like +-1e0 as floating point numbers. Do not report
1683 overflow for integer overflows unless the base is not 10 which
1684 means we have no simple and reliable way to continue.
1685 Break out the floating-point parsing into a new
1686 function string_to_number, so that Fstring_to_number parses
1687 floating point numbers consistently with the Lisp reader.
04f2d78b 1688 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1689 (E_CHAR, EXP_INT): Remove, replacing with ...
1690 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1691 (string_to_number): New function, replacing isfloat_string.
1692 This function checks for valid syntax and produces the resulting
1693 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1694 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1695 so that overflow for non-base-10 numbers is reported only when
1696 there's no portable and simple way to convert to floating point.
452f4150 1697
67769ffc
PE
1698 * textprop.c (set_text_properties_1): Rewrite for clarity,
1699 and to avoid GCC warning about integer overflow.
1700
c20db43f
PE
1701 * intervals.h (struct interval): Use EMACS_INT for members
1702 where EMACS_UINT might cause problems. See
1703 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1704 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1705 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1706 All uses changed.
37aa2f85
PE
1707 (offset_intervals): Tell GCC not to worry about length overflow
1708 when negating a negative length.
c20db43f 1709
2538aa2f
PE
1710 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1711 (overrun_check_free): Likewise.
1712
f2d3008d
PE
1713 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1714 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1715 word size.
1716
ec8df744
PE
1717 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1718 (gnutls_make_error): Rename local to avoid shadowing.
1719 (gnutls_emacs_global_deinit): ifdef out; not used.
1720 (Fgnutls_boot): Use const for pointer to readonly storage.
1721 Comment out unused local. Fix pointer signedness problems.
1722
640ee02d
PE
1723 * lread.c (openp): Don't stuff size_t into an 'int'.
1724 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1725 about possible signed overflow.
1726
6048fb2a
PE
1727 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1728 (GDK_KEY_g): Don't define if already defined.
1729 (xg_prepare_tooltip): Avoid pointer signedness problem.
1730 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1731
fa3c87e1
PE
1732 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1733 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1734
2172544b
PE
1735 * xfns.c (Fx_window_property): Simplify a bit,
1736 to make a bit faster and to avoid GCC 4.6.0 warning.
1737 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1738
9b821a21
PE
1739 * fns.c (internal_equal): Don't assume size_t fits in int.
1740
3c616cfa
PE
1741 * alloc.c (compact_small_strings): Tighten assertion a little.
1742
c2982e87
PE
1743 Replace pEd with more-general pI, and fix some printf arg casts.
1744 * lisp.h (pI): New macro, generalizing old pEd macro to other
1745 conversion specifiers. For example, use "...%"pI"d..." rather
1746 than "...%"pEd"...".
1747 (pEd): Remove. All uses replaced with similar uses of pI.
1748 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1749 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1750 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1751 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1752 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1753 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1754 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1755 64-bit hosts.
1756 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1757 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1758 * print.c (safe_debug_print, print_object): Likewise.
1759 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1760 to int.
6f04d126
PE
1761 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1762 avoiding the 0 flag, which is not portable.
c2982e87
PE
1763 * process.c (Fmake_network_process): Use pI to avoid cast.
1764 * region-cache.c (pp_cache): Likewise.
1765 * xdisp.c (decode_mode_spec): Likewise.
1766 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1767 behavior on 64-bit hosts with printf arg.
6f04d126 1768 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1769 (x_stop_queuing_selection_requests): Likewise.
1770 (x_get_window_property): Don't truncate byte count to an 'int'
1771 when tracing.
0b432f21 1772
5e073ec7
PE
1773 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1774 here, since it parses constructs like leading '-' and spaces,
1775 which are not wanted; and it overflows with large numbers.
1776 Instead, simply match F[0-9]+, which is what is wanted anyway.
1777
36372bf9
PE
1778 * alloc.c: Remove unportable assumptions about struct layout.
1779 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1780 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1781 (allocate_vectorlike, make_pure_vector): Use the new macros,
1782 plus offsetof, to remove unportable assumptions about struct layout.
1783 These assumptions hold on all porting targets that I know of, but
1784 they are not guaranteed, they're easy to remove, and removing them
1785 makes further changes easier.
1786
0b432f21
PE
1787 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1788 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1789 (string_overrun_cookie): Now const. Use initializers that
1790 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1791 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1792 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1793 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1794 multiple of sizeof (EMACS_INT); it need not be, if
1795 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1796 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1797
895009e1
JB
17982011-04-26 Juanma Barranquero <lekktu@gmail.com>
1799
1800 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1801
6a7a1b0b
TZ
18022011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1803
1804 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1805 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1806 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1807
841a1577 18082011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1809
1810 * lisp.h (Qdebug): List symbol.
895009e1 1811 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1812 * keyboard.c (debug-on-event): New variable.
1813 (handle_user_signal): Break into debugger when debug-on-event
1814 matches the current signal symbol.
1815
f2d3ba6f
DN
18162011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1817
1818 * alloc.c (check_sblock, check_string_bytes)
1819 (check_string_free_list): Convert to standard C.
1820
42ce4c63
TZ
18212011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1822
1823 * w32.c (emacs_gnutls_push): Fix typo.
1824
825cd63c
EZ
18252011-04-25 Eli Zaretskii <eliz@gnu.org>
1826
fb11d64d
EZ
1827 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1828 "cast to pointer from integer of different size".
1829
825cd63c
EZ
1830 Improve doprnt and its use in verror. (Bug#8545)
1831 * doprnt.c (doprnt): Document the set of format control sequences
1832 supported by the function. Use SAFE_ALLOCA instead of always
1833 using `alloca'.
1834
1835 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1836 is one byte too soon. Don't use xrealloc; instead xfree and
1837 xmalloc anew.
1838
e061a11b
TZ
18392011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1840
1841 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1842 callbacks stage.
1843
1844 * gnutls.c: Renamed global_initialized to
1845 gnutls_global_initialized. Added internals for the
1846 :verify-hostname-error, :verify-error, and :verify-flags
1847 parameters of `gnutls-boot' and documented those parameters in the
1848 docstring. Start callback support.
1849 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1850 unless a fatal error occured. Call gnutls_alert_send_appropriate
1851 on error. Return error code.
1852 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1853 (emacs_gnutls_read): Likewise.
1854 (Fgnutls_boot): Return handshake error code.
1855 (emacs_gnutls_handle_error): New function.
1856 (wsaerror_to_errno): Likewise.
1857
1858 * w32.h (emacs_gnutls_pull): Add prototype.
1859 (emacs_gnutls_push): Likewise.
1860
1861 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1862 (emacs_gnutls_push): Likewise.
1863
18642011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1865
1866 * process.c (wait_reading_process_output): Check if GnuTLS
1867 buffered some data internally if no FDs are set for TLS
1868 connections.
1869
1870 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1871 (LIBS): Link to USER_LIBS.
1872 ($(BLD)/gnutls.$(0)): New target.
1873
fa6996bc
EZ
18742011-04-24 Eli Zaretskii <eliz@gnu.org>
1875
eb35682e
EZ
1876 * xdisp.c (handle_single_display_spec): Rename the
1877 display_replaced_before_p argument into display_replaced_p, to
1878 make it consistent with the commentary. Fix typos in the
1879 commentary.
1880
e2ad650c
EZ
1881 * textprop.c (syms_of_textprop): Remove dead code.
1882 (copy_text_properties): Delete obsolete commentary about an
1883 interface that was deleted long ago. Fix typos in the description
1884 of arguments.
1885
1b2de274
EZ
1886 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1887 to changes in oldXMenu/XMenu.h from 2011-04-16.
1888 <menu_help_message, prev_menu_help_message>: Constify.
1889 (IT_menu_make_room): menu->help_text is now `const char **';
1890 adjust.
1891
1892 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1893 to changes in oldXMenu/XMenu.h from 2011-04-16.
1894 (struct XMenu): Declare `help_text' `const char **'.
1895
1896 * xfaces.c <Qunspecified>: Make extern again.
1897
1898 * syntax.c: Include sys/types.h before including regex.h, as
1899 required by Posix.
1900
762b15be
EZ
1901 * doc.c (get_doc_string): Improve the format passed to `error'.
1902
1903 * doprnt.c (doprnt): Improve commentary.
1904
1905 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1906
1907 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1908 them with etags.
1909
f1052e5d
EZ
1910 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1911 changes in globals.h immediately force recompilation.
762b15be
EZ
1912 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1913 $(CURDIR)/s/ms-w32.h.
1914 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1915
fa6996bc
EZ
1916 * character.c (Fchar_direction): Function deleted.
1917 (syms_of_character): Don't defsubr it.
1918 <char-direction-table>: Deleted.
1919
e6c3da20
EZ
19202011-04-23 Eli Zaretskii <eliz@gnu.org>
1921
1922 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1923 * doprnt.c: Include limits.h.
1924 (SIZE_MAX): New macro.
04f2d78b
CB
1925 (doprnt): Return a size_t value. 2nd arg is now size_t.
1926 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1927 Improve overflow protection. Support `l' modifier for integer
1928 conversions. Support %l conversion. Don't assume an EMACS_INT
1929 argument for integer conversions and for %c.
1930
1931 * lisp.h (doprnt): Restore prototype.
1932
1933 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1934 $(SRC)/character.h.
1935
1936 * Makefile.in (base_obj): Add back doprnt.o.
1937
1938 * deps.mk (doprnt.o): Add back prerequisites.
1939 (callint.o): Depend on character.h.
1940
1941 * eval.c (internal_lisp_condition_case): Include the handler
1942 representation in the error message.
1943 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1944 when breaking from the loop.
1945
1946 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1947
1948 * callint.c (Fcall_interactively): When displaying error message
1949 about invalid control letter, pass the character's codepoint, not
1950 a pointer to its multibyte form. Improve display of the character
1951 in octal and display also its hex code.
1952
1953 * character.c (char_string): Use %x to display the (unsigned)
1954 codepoint of an invalid character, to avoid displaying a bogus
1955 negative value.
1956
1957 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1958 `error', not SYMBOL_NAME itself.
1959
1960 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1961 character arguments to `error'.
1962
1963 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1964 to `error' in error message about FINAL_CHAR argument. Make sure
1965 FINAL_CHAR is a character, and use %c when it is passed as
1966 argument to `error'.
1967
4ffd0d6b 19682011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1969
1970 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1971
1972 * w32.c: Include <time.h>.
1973 (sys_localtime): New function.
1974
4ffd0d6b 19752011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1976
1977 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1978
4ffd0d6b 1979 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1980
4ffd0d6b 19812011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1982
4ffd0d6b
GM
1983 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1984 zombies (Bug#8467).
aac0c6e3 1985
04c56954
EZ
19862011-04-19 Eli Zaretskii <eliz@gnu.org>
1987
1988 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1989 gl_state.e_property when gl_state.object is Qt.
1990
1991 * insdel.c (make_gap_larger): Remove limitation of buffer size
1992 to <= INT_MAX.
1993
16a43933
CY
19942011-04-18 Chong Yidong <cyd@stupidchicken.com>
1995
1996 * xdisp.c (lookup_glyphless_char_display)
1997 (produce_glyphless_glyph): Handle cons cell entry in
1998 glyphless-char-display.
1999 (Vglyphless_char_display): Document it.
2000
2001 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2002 glyphless-char-display.
2003
4581706e
CY
20042011-04-17 Chong Yidong <cyd@stupidchicken.com>
2005
2006 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2007
2008 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2009
2010 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2011 definition for no-X builds.
2012
4887c6e2 20132011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2014
fd35b6f9
PE
2015 Static checks with GCC 4.6.0 and non-default toolkits.
2016
5c1ccb01
PE
2017 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2018
006c5daa
PE
2019 * process.c (keyboard_bit_set): Define only if SIGIO.
2020 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2021 (send_process): Repair possible setjmp clobbering.
2022
efc736d3
PE
2023 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2024
4e2fe2e6
PE
2025 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2026
f97334a2
PE
2027 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2028
4e75f29d
PE
2029 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2030 Define only if needed.
2031
90efadd1
PE
2032 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2033 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2034 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2035
3c647824
PE
2036 * dispextern.h (struct redisplay_interface): Rename param
2037 to avoid shadowing.
e264f262 2038 * termhooks.h (struct terminal): Likewise.
761383f4 2039 * xterm.c (xembed_send_message): Likewise.
3c647824 2040
b58c5c4a
PE
2041 * insdel.c (make_gap_smaller): Define only if
2042 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2043
cad59032
PE
2044 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2045 it.
2046
c339dc2e
PE
2047 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2048 so that we aren't warned about unused symbols.
2049
91a3e27b
PE
2050 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2051
399c71d3 2052 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2053
8ffc96f5
PE
2054 * xfns.c (x_real_positions): Mark locals as initialized.
2055
eef9bc79
PE
2056 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2057
098db9dd
PE
2058 * xterm.c: Fix problems found by static analysis with other toolkits.
2059 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2060 (x_dispatch_event): Declare static if USE_GTK, and
2061 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2062 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2063 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2064 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2065 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2066
eb18f6cc
PE
2067 * xmenu.c (menu_help_callback): Pointer type fixes.
2068 Use const pointers when pointing at readonly data. Avoid pointer
2069 signedness clashes.
2070 (FALSE): Remove unused macro.
2071 (update_frame_menubar): Remove unused decl.
2072
1fe72bf8
PE
2073 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2074
60d9e1db
PE
2075 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2076 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2077 (single_menu_item): Rename local to avoid shadowing.
2078
39261c26
PE
2079 * keyboard.c (make_lispy_event): Remove unused local var.
2080
018c5e19
PE
2081 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2082 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2083
63d2b86e
PE
2084 * bitmaps: Change bitmaps from unsigned char back to the X11
2085 compatible char. Avoid the old compiler warnings about
2086 out-of-range initializers by using, for example, '\xab' rather
2087 than 0xab.
2088
aefd87e1
PE
2089 * xgselect.c (xgselect_initialize): Check vs interface
2090 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2091
bf501fb9
PE
2092 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2093
e9829fdf
PE
2094 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2095 to read-only memory.
2096
1086c095
PE
2097 * fns.c (vector): Remove; this old hack is no longer needed.
2098
2baccd04 2099 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2100 Remove unused var.
dde42981 2101 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2102
72391843 2103 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2104
436c16df 2105 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2106 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2107 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2108
92bb796d 2109 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2110 (x_term_init): Remove local to avoid shadowing.
92bb796d 2111
764430a3 2112 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2113
2114 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2115 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2116
d1dfb56c
EZ
21172011-04-16 Eli Zaretskii <eliz@gnu.org>
2118
c4354cb4
EZ
2119 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2120
d1dfb56c
EZ
2121 Fix regex.c, syntax.c and friends for buffers > 2GB.
2122 * syntax.h (struct gl_state_s): Declare character position members
2123 EMACS_INT.
2124
2125 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2126
04f2d78b
CB
2127 * textprop.c (verify_interval_modification, interval_of):
2128 Declare arguments EMACS_INT.
d1dfb56c
EZ
2129
2130 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2131 EMACS_INT.
2132
2133 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2134
2135 * indent.c (Fvertical_motion): Local variable it_start is now
2136 EMACS_INT.
2137
2138 * regex.c (re_match, re_match_2, re_match_2_internal)
2139 (bcmp_translate, regcomp, regexec, print_double_string)
2140 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2141 (re_compile_pattern, re_exec): Declare arguments and local
2142 variables `size_t' and `ssize_t' and return values `regoff_t', as
2143 appropriate.
2144 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2145 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2146 <compile_stack_type>: `size' and `avail' are now `size_t'.
2147
2148 * regex.h <regoff_t>: Use ssize_t, not int.
2149 (re_search, re_search_2, re_match, re_match_2): Arguments that
2150 specify buffer/string position and length are now ssize_t and
2151 size_t. Return type is regoff_t.
2152
613052cd
BK
21532011-04-16 Ben Key <bkey76@gmail.com>
2154
2155 * nsfont.m: Fixed bugs in ns_get_family and
2156 ns_descriptor_to_entity that were caused by using free to
2157 deallocate memory blocks that were allocated by xmalloc (via
2158 xstrdup). This caused Emacs to crash when compiled with
2159 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2160 --enable-checking=xmallocoverrun). xfree is now used to
2161 deallocate these memory blocks.
2162
4170f62f 21632011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2164
71b41406
PE
2165 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2166
9587a89d
PE
2167 emacs_write: Accept and return EMACS_INT for sizes.
2168 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2169 et seq.
2170 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2171 Accept and return EMACS_INT.
2172 (emacs_gnutls_write): Return the number of bytes written on
2173 partial writes.
2174 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2175 (emacs_read, emacs_write): Remove check for negative size, as the
2176 Emacs source code has been audited now.
9587a89d
PE
2177 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2178 (emacs_read, emacs_write): Use it.
273a5f82
PE
2179 * process.c (send_process): Adjust to the new signatures of
2180 emacs_write and emacs_gnutls_write. Do not attempt to store
2181 a byte offset into an 'int'; it might overflow.
9587a89d 2182 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2183
3e047f51
PE
2184 * sound.c: Don't assume sizes fit in 'int'.
2185 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2186 Return EMACS_INT, not int.
3e047f51 2187 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2188 Accept EMACS_INT, not int.
2189 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2190 record read return values.
2191
cc39a9db
BK
21922011-04-15 Ben Key <bkey76@gmail.com>
2193
c9d0ec6d
JB
2194 * keyboard.c (Qundefined): Don't declare static since it is used
2195 in nsfns.m.
2196 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2197 static since they are used in nsfont.m.
cc39a9db 2198
6c60eb9f
SM
21992011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2200
2201 * process.c (Qprocessp): Don't declare static.
2202 * lisp.h (Qprocessp): Declare again.
2203
7990b61a
JB
22042011-04-15 Juanma Barranquero <lekktu@gmail.com>
2205
2206 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2207
5d4cb038
PE
22082011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2209
8bd7b830 2210 Improve C-level modularity by making more things 'static'.
cd64ea1d 2211
e3b27b31
PE
2212 Don't publish debugger-only interfaces to other modules.
2213 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2214 (verify_bytepos, count_markers): Move decls to the only modules
2215 that need them.
2216 * region-cache.h (pp_cache): Likewise.
2217 * window.h (check_all_windows): Likewise.
2218 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2219
5d4cb038
PE
2220 * sysdep.c (croak): Now static, if
2221 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2222 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2223
2224 * alloc.c (refill_memory_reserve): Now static if
2225 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2226 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2227
e87b6180
PE
2228 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2229 Define only if USE_LUCID.
2230
ac64929e
PE
2231 * xrdb.c (x_customization_string, x_rm_string): Now static.
2232
6f37259d
PE
2233 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2234 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2235
1683e3ab
PE
2236 * xdisp.c (draw_row_with_mouse_face): Now static.
2237 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2238
de9c2632
PE
2239 * window.h (check_all_windows): Mark externally visible.
2240
2b96acb7
PE
2241 * window.c (window_deletion_count): Now static.
2242
2243 * undo.c: Make symbols static if they're not exported.
2244 (last_undo_buffer, last_boundary_position, pending_boundary):
2245 Now static.
2246
50436f33
PE
2247 * textprop.c (interval_insert_behind_hooks): Now static.
2248 (interval_insert_in_front_hooks): Likewise.
2249
64520e5c
PE
2250 * term.c: Make symbols static if they're not exported.
2251 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2252 (max_frame_lines, tty_set_terminal_modes):
2253 (tty_reset_terminal_modes, tty_turn_off_highlight):
2254 (get_tty_terminal): Now static.
2255 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2256 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2257 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2258 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2259 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2260
1fa53021
PE
2261 * sysdep.c: Make symbols static if they're not exported.
2262 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2263 Now static.
2264 (sigprocmask_set, full_mask): Remove; unused.
2265 (wait_debugging): Mark as visible.
2266 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2267 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2268
d4b43b22
PE
2269 * syntax.c (syntax_temp): Define only if !__GNUC__.
2270
b7c513d0
PE
2271 * sound.c (current_sound_device, current_sound): Now static.
2272
989b29ad
PE
2273 * search.c (searchbufs, searchbuf_head): Now static.
2274
13a55a78
PE
2275 * scroll.c (scroll_cost): Remove; unused.
2276 * dispextern.h (scroll_cost): Remove decl.
2277
de68a1fc
PE
2278 * region-cache.h (pp_cache): Mark as externally visible.
2279
40ccffa6
PE
2280 * process.c: Make symbols static if they're not exported.
2281 (process_tick, update_tick, create_process, chan_process):
2282 (Vprocess_alist, proc_buffered_char, datagram_access):
2283 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2284 (deactivate_process): Mark defn as static, as well as decl.
2285 * lisp.h (create_process): Remove decl.
2286 * process.h (chan_process, Vprocess_alist): Remove decls.
2287
ad64fc97
PE
2288 * print.c: Make symbols static if they're not exported.
2289 (print_depth, new_backquote_output, being_printed, print_buffer):
2290 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2291 (print_interval, print_number_index, initial_stderr_stream):
2292 Now static.
2293 * lisp.h (Fprinc): Remove decl.
2294 (debug_output_compilation_hack): Mark as externally visible.
2295
adddb265
PE
2296 * sysdep.c (croak): Move decl from here to syssignal.h.
2297 * syssignal.h (croak): Put it here, so the API can be checked when
2298 'croak' is called from dissociate_if_controlling_tty.
2299
1717ede2
PE
2300 * minibuf.c: Make symbols static if they're not exported.
2301 (minibuf_save_list, choose_minibuf_frame): Now static.
2302 * lisp.h (choose_minibuf_frame): Remove decl.
2303
fa5fb2bc
PE
2304 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2305
1e3890d1
PE
2306 * lread.c: Make symbols static if they're not exported.
2307 (read_objects, initial_obarray, oblookup_last_bucket_number):
2308 Now static.
2309 (make_symbol): Remove; unused.
2310 * lisp.h (initial_obarray, make_symbol): Remove decls.
2311
8a1414fa
PE
2312 * keyboard.c: Make symbols static if they're not exported.
2313 (single_kboard, recent_keys_index, total_keys, recent_keys):
2314 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2315 (this_single_command_key_start, echoing, last_auto_save):
2316 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2317 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2318 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2319 (Vlispy_mouse_stem, double_click_count):
2320 Now static.
2321 (force_auto_save_soon): Define only if SIGDANGER.
2322 (ignore_mouse_drag_p): Now static if
2323 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2324 (print_help): Remove; unused.
2325 (stop_character, last_timer_event): Mark as externally visible.
2326 * keyboard.h (ignore_mouse_drag_p): Declare only if
2327 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2328 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2329 * lisp.h (echoing): Remove decl.
2330 (force_auto_save_soon): Declare only if SIGDANGER.
2331 * xdisp.c (redisplay_window): Simplify code, to make it more
2332 obvious that ignore_mouse_drag_p is not accessed if !defined
2333 USE_GTK && !defined HAVE_NS.
2334
93ea6e8f
PE
2335 * intervals.c: Make symbols static if they're not exported.
2336 (merge_properties_sticky, merge_interval_right, delete_interval):
2337 Now static.
2338 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2339
77382fcc
PE
2340 * insdel.c: Make symbols static if they're not exported.
2341 However, leave prepare_to_modify_buffer alone. It's never
2342 called from outside this function, but that appears to be a bug.
2343 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2344 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2345 (adjust_after_replace_noundo): Remove; unused.
2346 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2347 (signal_before_change): Remove decls.
77382fcc 2348
9306c32e
PE
2349 * indent.c (val_compute_motion, val_vmotion): Now static.
2350
cd44d2eb
PE
2351 * image.c: Make symbols static if they're not exported.
2352 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2353 if USE_GTK.
2354 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2355 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2356
ad9a7a06
PE
2357 * fringe.c (standard_bitmaps): Now static.
2358 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2359
81626931
PE
2360 * frame.c: Make symbols static if they're not exported.
2361 (x_report_frame_params, make_terminal_frame): Now static.
2362 (get_frame_param): Now static, unless HAVE_NS.
2363 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2364 (x_get_resource_string): Remove; not used.
2365 * frame.h (make_terminal_frame, x_report_frame_params):
2366 (x_get_resource_string); Remove decls.
2367 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2368 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2369
239f9db9
PE
2370 * font.c, fontset.c: Make symbols static if they're not exported.
2371 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2372 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2373 * font.c (font_close_object): Now static.
2374 * font.h (font_close_object): Remove.
2375 * fontset.c (FONTSET_OBJLIST): Remove.
2376 (free_realized_fontset) #if-0 the body, which does nothing.
2377 (face_suitable_for_char_p): #if-0, as it's never called.
2378 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2379 * xfaces.c (face_at_string_position):
2380 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2381 since 0 is always ASCII.
2382
dfcf3579
PE
2383 * fns.c (weak_hash_tables): Now static.
2384
5045092b
PE
2385 * fileio.c: Make symbols static if they're not exported.
2386 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2387 (Vwrite_region_annotation_buffers): Now static.
2388
57a96f5c
PE
2389 * eval.c: Make symbols static if they're not exported.
2390 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2391 * lisp.h (backtrace_list): Remove decl.
2392
35f08c38
PE
2393 * emacs.c: Make symbols static if they're not exported.
2394 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2395 (fatal_error_code, fatal_error_signal_hook, standard_args):
2396 Now static.
2397 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2398 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2399 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2400 * lisp.h (fatal_error_signal_hook): Remove decl.
2401 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2402
f44bd759
PE
2403 * editfns.c: Move a (normally-unused) function to its only use.
2404 * editfns.c, lisp.h (get_operating_system_release): Remove.
2405 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2406 worth the hassle of breaking this out.
2407
b532497d
PE
2408 * xterm.c: Make symbols static if they're not exported.
2409 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2410 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2411 (x_destroy_window, x_delete_display):
2412 Now static.
2413 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2414 (x_mouse_leave): Remove; unused.
2415 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2416 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2417 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2418 Remove decls.
2419 (x_mouse_leave): Declare only if WINDOWSNT.
2420 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2421 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2422 USE_X_TOOLKIT.
2423
1675728f
PE
2424 * ftxfont.c: Make symbols static if they're not exported.
2425 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2426 HAVE_FREETYPE.
2427 * font.h (ftxfont_driver): Likewise.
2428
e4cebfca
PE
2429 * xfns.c: Make symbols static if they're not exported.
2430 (x_last_font_name, x_display_info_for_name):
2431 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2432 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2433 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2434 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2435 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2436 (last_show_tip_args): Now static.
2437 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2438 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2439 (x_screen_planes): Remove; unused.
2440 * dispextern.h (x_screen_planes): Remove decl.
2441
5bf46f05
PE
2442 * dispnew.c: Make symbols static if they're not exported.
2443 * dispextern.h (redraw_garbaged_frames, scrolling):
2444 (increment_row_positions): Remove.
2445 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2446 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2447 Now static.
2448 (redraw_garbaged_frames): Remove; unused.
2449
435f4c28
PE
2450 * xfaces.c: Make symbols static if they're not exported.
2451 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2452 Remove decls.
2453 * xterm.h (defined_color): Remove decls.
2454 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2455 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2456 (menu_face_changed_default, defined_color, free_realized_face):
2457 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2458 (ascii_face_of_lisp_face): Remove; unused.
2459
8524aef3
PE
2460 * xdisp.c: Make symbols static if they're not exported.
2461 * dispextern.h (scratch_glyph_row, window_box_edges):
2462 (glyph_to_pixel_coords, set_cursor_from_row):
2463 (get_next_display_element, set_iterator_to_next):
2464 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2465 (show_mouse_face): Remove decls
2466 * frame.h (message_buf_print): Likewise.
2467 * lisp.h (pop_message, set_message, check_point_in_composition):
2468 Likewise.
2469 * xterm.h (set_vertical_scroll_bar): Likewise.
2470 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2471 (message_buf_print, scratch_glyph_row, displayed_buffer):
2472 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2473 (get_next_display_element, show_mouse_face, window_box_edges):
2474 (frame_to_window_pixel_xy, check_point_in_composition):
2475 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2476 (glyph_to_pixel_coords): Remove; unused.
2477
16390cd2
PE
2478 * dired.c (file_name_completion): Now static.
2479
2480 * dbusbind.c (xd_in_read_queued_messages): Now static.
2481
a25f4dfa
PE
2482 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2483 * data.c (circular_list_error): Remove.
2484
14a9c8df
PE
2485 * commands.h (last_point_position, last_point_position_buffer):
2486 (last_point_position_window): Remove decls.
2487 * keyboard.c: Make these variables static.
2488
04f2d78b
CB
2489 * coding.h (coding, code_convert_region, encode_coding_gap):
2490 Remove decls.
74ab6df5
PE
2491 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2492 (iso_code_class, detect_coding, code_convert_region): Now static.
2493 (encode_coding_gap): Remove; unused.
2494
38dfbee1
PE
2495 * chartab.c (chartab_chars, chartab_bits): Now static.
2496
a2cb4e63
PE
2497 * charset.h (charset_iso_8859_1): Remove decl.
2498 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2499 Now static.
2500
127198fd
PE
2501 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2502 * ccl.c (Vccl_program_table): Now static.
2503 (check_ccl_update): Remove; unused.
2504
d85b608f
PE
2505 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2506 * category.h: ... from here.
2507 * category.c (check_category_table, set_category_set): Now static.
2508
31cd66f3
PE
2509 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2510 * lisp.h: Remove these decls.
2511
c358e587
PE
2512 * buffer.c (buffer_count): Remove unused var.
2513
e78aecca
PE
2514 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2515 so that it's not optimized away.
2516 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2517 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2518 exported only to the debugger.
2519
e192d7d3 2520 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2521 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2522
92470028
PE
2523 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2524 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2525 was inaccessible from Lisp.
2526 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2527 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2528
244ed907
PE
2529 alloc.c: Import and export fewer symbols, and remove unused items.
2530 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2531 is defined.
2532 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2533 it's not optimized away by whole-program optimization.
2534 (message_enable_multibyte, free_misc): Remove.
2535 (catchlist, handlerlist, mark_backtrace):
2536 Declare only if BYTE_MARK_STACK.
2537 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2538 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2539 (message_enable_multibyte): Remove decl.
2540 (free_misc, interval_free_list, float_block, float_block_index):
2541 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2542 (cons_free_list, last_marked_index):
2543 Now static.
2544 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2545 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2546 (mark_backtrace): Define only if BYTE_MARK_STACK.
2547 * xdisp.c (message_enable_multibyte): Now static.
2548
61c2b50e 2549 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2550 This makes it easier for human readers (and static analyzers)
2551 to see whether these variables are used from other modules.
2552 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2553 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2554 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2555 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2556 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2557 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2558 * xmenu.c, xselect.c:
2559 Declare Q* vars static if they are not used in other modules.
2560 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2561 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2562 Remove decls of unexported vars.
2563 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2564
95c82688
PE
2565 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2566
16a97296
PE
2567 Make Emacs functions such as Fatom 'static' by default.
2568 This makes it easier for human readers (and static analyzers)
2569 to see whether these functions can be called from other modules.
2570 DEFUN now defines a static function. To make the function external
2571 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2572 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2573 (Finit_image_library):
16a97296
PE
2574 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2575 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2576 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2577 Remove decls, since these functions are now static.
2578 (Funintern, Fget_internal_run_time): New decls, since these functions
2579 were already external.
95c82688 2580
16a97296
PE
2581 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2582 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2583 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2584 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2585 * keyboard.c, keymap.c, lread.c:
2586 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2587 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2588 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2589 Mark functions with DEFUE instead of DEFUN,
2590 if they are used in other modules.
2591 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2592 decls for now-static functions.
2593 * buffer.h (Fdelete_overlay): Remove decl.
2594 * callproc.c (Fgetenv_internal): Mark as internal.
2595 * composite.c (Fremove_list_of_text_properties): Remove decl.
2596 (Fcomposition_get_gstring): New forward static decl.
2597 * composite.h (Fcomposite_get_gstring): Remove decl.
2598 * dired.c (Ffile_attributes): New forward static decl.
2599 * doc.c (Fdocumntation_property): New forward static decl.
2600 * eval.c (Ffetch_bytecode): New forward static decl.
2601 (Funintern): Remove extern decl; now in .h file where it belongs.
2602 * fileio.c (Fmake_symbolic_link): New forward static decl.
2603 * image.c (Finit_image_library): New forward static decl.
2604 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2605 * intervals.h (Fprevious_property_change):
2606 (Fremove_list_of_text_properties): Remove decls.
2607 * keyboard.c (Fthis_command_keys): Remove decl.
2608 (Fcommand_execute): New forward static decl.
2609 * keymap.c (Flookup_key): New forward static decl.
2610 (Fcopy_keymap): Now static.
2611 * keymap.h (Flookup_key): Remove decl.
2612 * process.c (Fget_process): New forward static decl.
2613 (Fprocess_datagram_address): Mark as internal.
2614 * syntax.c (Fsyntax_table_p): New forward static decl.
2615 (skip_chars): Remove duplicate decl.
2616 * textprop.c (Fprevious_property_change): New forward static decl.
2617 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2618 Now internal.
2619 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2620 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2621
785bbd42
PE
2622 * editfns.c (Fformat): Remove unreachable code.
2623
8b913b57
AS
26242011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2625
2626 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2627 change. (Bug#8496)
2628
a6744a35
EZ
26292011-04-13 Eli Zaretskii <eliz@gnu.org>
2630
2631 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2632 when at ZV. (Bug#8487)
2633
e7974947
AS
26342011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2635
baad03f0
AS
2636 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2637 (Bug#8437)
2638 * keyboard.c (parse_tool_bar_item): Likewise.
2639 * sound.c (sound_cleanup, alsa_close): Likewise.
2640 * termcap.c (tgetent): Likewise.
2641 * xfns.c (x_default_font_parameter): Likewise.
2642 * xsettings.c (read_and_apply_settings): Likewise.
2643
e7974947
AS
2644 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2645 (overrun_check_free): Protoize.
2646
28272684
PE
26472011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2648
2649 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2650 since callers should never pass a negative size.
2651 Change the signature to match that of plain 'read' and 'write'; see
2652 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2653 * lisp.h: Update prototypes of emacs_write and emacs_read.
2654
11997c76
EZ
26552011-04-11 Eli Zaretskii <eliz@gnu.org>
2656
2657 * xdisp.c (redisplay_window): Don't try to determine the character
2658 position of the scroll margin if the window start point w->startp
e896f03c 2659 is outside the buffer's accessible region. (Bug#8468)
11997c76 2660
8a2cbd72
EZ
26612011-04-10 Eli Zaretskii <eliz@gnu.org>
2662
2663 Fix write-region and its subroutines for buffers > 2GB.
2664 * fileio.c (a_write, e_write): Modify declaration of arguments and
2665 local variables to support buffers larger than 2GB.
2666 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2667
2668 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2669 argument, local variables, and return value.
2670
2671 * lisp.h: Update prototypes of emacs_write and emacs_read.
2672
2673 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2674
4073e537 26752011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2676
1ebfdcb6
PE
2677 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2678
b2ded58d
PE
2679 Fix more problems found by GCC 4.6.0's static checks.
2680
7d66342c
PE
2681 * xdisp.c (vmessage): Use a better test for character truncation.
2682
bbf47d44
PE
2683 * charset.c (load_charset_map): <, not <=, for optimization,
2684 and to avoid potential problems with integer overflow.
9248994d 2685 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2686 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2687 * editfns.c (Fformat): Likewise.
1e69125e 2688 * syntax.c (skip_chars): Likewise.
3befa583 2689
e3019616
PE
2690 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2691 This also lets GCC 4.6.0 generate slightly better loop code.
2692
becfa255
PE
2693 * callint.c (Fcall_interactively): <, not <=, for optimization.
2694 (Fcall_interactively): Count the number of arguments produced,
2695 not the number of arguments given. This is simpler and lets GCC
2696 4.6.0 generate slightly better code.
2697
dae0cd48
PE
2698 * ftfont.c: Distingish more carefully between FcChar8 and char.
2699 The previous code passed unsigned char * to a functions like
2700 strlen and xstrcasecmp that expect char *, which does not
2701 conform to the C standard.
2702 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2703 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2704 char * when the C standard requires it.
2705
76032d70
PE
2706 * keyboard.c (read_char): Remove unused var.
2707
eb3f1cc8
PE
2708 * eval.c: Port to Windows vsnprintf (Bug#8435).
2709 Include <limits.h>.
2710 (SIZE_MAX): Define if the headers do not.
2711 (verror): Do not give up if vsnprintf returns a negative count.
2712 Instead, grow the buffer. This ports to Windows vsnprintf, which
2713 does not conform to C99. Problem reported by Eli Zaretskii.
2714 Also, simplify the allocation scheme, by avoiding the need for
2715 calling realloc, and removing the ALLOCATED variable.
2716
70476b54
PE
2717 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2718
12020a9e
PE
2719 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2720 But keep the doprint source code for now, as we might revamp it
2721 and use it again (Bug#8435).
ea6c7ae6
PE
2722 * lisp.h (doprnt): Remove.
2723 * Makefile.in (base_obj): Remove doprnt.o.
2724 * deps.mk (doprnt.o): Remove.
2725
5fdb398c
PE
2726 error: Print 32- and 64-bit integers portably (Bug#8435).
2727 Without this change, on typical 64-bit hosts error ("...%d...", N)
2728 was used to print both 32- and 64-bit integers N, which relied on
2729 undefined behavior.
2730 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2731 New macro.
2732 * lisp.h (error, verror): Mark as printf-like functions.
2733 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2734 Report overflow in size calculations when allocating printf buffer.
2735 Do not truncate output string at its first null byte.
2736 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2737 Truncate the output at a character boundary, since vsnprintf does not
2738 do that.
2739 * charset.c (check_iso_charset_parameter): Convert internal
2740 character to string before calling 'error', since %c now has the
2741 printf meaning.
2742 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2743 overflow when computing char to be passed to 'error'. Do not
2744 pass Lisp_Object to 'error'; pass the integer instead.
2745 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2746 formatted with plain %d.
2747
b189fa66
PE
2748 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2749
bff87ef0
PE
2750 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2751
7e2cac20
PE
2752 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2753
ce4d90b5
PE
2754 * xterm.c (x_catch_errors): Remove duplicate declaration.
2755
266c9547
PE
2756 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2757
79c49ad2
PE
2758 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2759
368f4090
JM
27602011-04-10 Jim Meyering <meyering@redhat.com>
2761
2762 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2763 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2764 return ssize_t not "int", and use size_t as the buffer length.
2765 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2766 * gnutls.h: Update declarations.
2767 * process.c (read_process_output): Use ssize_t, to match.
2768 (send_process): Likewise.
2769
a32d4040
CY
27702011-04-09 Chong Yidong <cyd@stupidchicken.com>
2771
2772 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2773
8546720e 27742011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2775
04f2d78b
CB
2776 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2777 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2778
8546720e
GM
2779 * xterm.c (handle_one_xevent):
2780 * xmenu.c (create_and_show_popup_menu):
2781 * xselect.c (x_decline_selection_request)
2782 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2783
0a2f5c1a 27842011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2785
2786 Fix some uses of `int' instead of EMACS_INT.
2787 * search.c (string_match_1, fast_string_match)
2788 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2789 (scan_buffer, find_next_newline_no_quit)
2790 (find_before_next_newline, search_command, Freplace_match)
2791 (Fmatch_data): Make some `int' variables be EMACS_INT.
2792
2793 * xdisp.c (display_count_lines): 3rd argument and return value now
2794 EMACS_INT. All callers changed.
2795 (pint2hrstr): Last argument is now EMACS_INT.
2796
2797 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2798 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2799 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2800 (decode_coding_utf_16, decode_coding_emacs_mule)
2801 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2802 (decode_coding_ccl, decode_coding_charset)
2803 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2804 (decode_coding_iso_2022, decode_coding_emacs_mule)
2805 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2806 <char_offset, last_offset>: Declare EMACS_INT.
2807 (encode_coding_utf_8, encode_coding_utf_16)
2808 (encode_coding_emacs_mule, encode_invocation_designation)
2809 (encode_designation_at_bol, encode_coding_iso_2022)
2810 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2811 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2812 Declare EMACS_INT.
2813 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2814 (encode_invocation_designation): Last argument P_NCHARS is now
2815 EMACS_INT.
2816 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2817 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2818
2819 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2820 All users changed.
2821
2822 * ccl.c (Fccl_execute_on_string): Declare some variables
2823 EMACS_INT.
2824
8546720e 28252011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2826
2827 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2828
4e19a977
CS
28292011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2830
2831 * process.c (Fformat_network_address): Doc fix.
2832
87302331
R
28332011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2834
2835 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2836
cbb59342
CY
28372011-04-08 Chong Yidong <cyd@stupidchicken.com>
2838
2839 * keyboard.c (read_char): Call Lisp function help-form-show,
2840 instead of using internal_with_output_to_temp_buffer.
2841 (Qhelp_form_show): New var.
e0d38eeb 2842 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2843
2844 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2845
2846 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2847
e67a13ab
CY
28482011-04-06 Chong Yidong <cyd@stupidchicken.com>
2849
04f2d78b
CB
2850 * process.c (Flist_processes): Remove to Lisp.
2851 (list_processes_1): Delete.
e67a13ab 2852
973f782d
EZ
28532011-04-06 Eli Zaretskii <eliz@gnu.org>
2854
7c106b1e
EZ
2855 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2856
973f782d
EZ
2857 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2858
41cf7d1a 28592011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2860
ca23cc88
PE
2861 Fix more problems found by GCC 4.6.0's static checks.
2862
f390e2d5
PE
2863 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2864
42eea0d0
PE
2865 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2866
b69769da 2867 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2868
f9541e84
PE
2869 * xdisp.c (vmessage): Mark as a printf-like function.
2870
13841b55
PE
2871 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2872
c136c10f
PE
2873 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2874
5e2d4a30
PE
2875 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2876 printf-like functions.
2877 (tiff_load): Add casts to remove these marks before passing them
2878 to system-supplied API.
2879
583f48b9
PE
2880 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2881
b25d760e
PE
2882 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2883 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2884 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2885 directly, rather than having caller test rule sign. This avoids
2886 some unnecessary tests.
2887 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2888 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2889 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2890
bc7b6697 2891 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2892 (xfont_open): Avoid unnecessary tests.
bc7b6697 2893
27ccc379
PE
2894 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2895
dcd5c89a
PE
2896 * composite.h, composite.c (composition_gstring_put_cache):
2897 Use EMACS_INT, not int, for length.
2898
b13a45c6
PE
2899 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2900 breaking out part of COMPOSITION_DECODE_RULE.
2901 (COMPOSITION_DECODE_RULE): Use it.
2902 * composite.c (get_composition_id): Remove unused local vars,
2903 by using the new macro.
2904
1e792e4d
PE
2905 * textprop.c (set_text_properties_1): Change while to do-while,
2906 since the condition is always true at first.
2907
dc6c6455 2908 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2909 (interval_deletion_adjustment): Return unsigned value.
2910 All uses changed.
dc6c6455 2911
aba7731a
PE
2912 * process.c (list_processes_1, create_pty, read_process_output):
2913 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2914 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2915 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2916 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2917 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2918
fdfc4bf3
PE
2919 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2920
fca8fe46 2921 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2922 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2923
06a0259a 2924 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2925 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2926 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2927
e7b9e80f
PE
2928 * print.c (print_error_message): Avoid int overflow.
2929
56201685
PE
2930 * font.c (font_list_entities): Redo for clarity,
2931 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2932
78834453 2933 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2934 (font_score): Avoid potential overflow in diff calculation.
78834453 2935
0bc0b309 2936 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2937 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2938
e610eaca
PE
2939 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2940
b895abce
PE
2941 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2942 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2943 can always succeed if overflow has undefined behavior.
2944
1f1d9321 2945 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2946 (wordify): Omit three unnecessary tests.
1f1d9321 2947
c59478bc
PE
2948 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2949 All callers changed. This avoids the need for an unused var.
2950
79b73827
PE
2951 * casefiddle.c (casify_region): Remove var that is set but not used.
2952
a4db5dfe
PE
2953 * dired.c (file_name_completion): Remove var that is set but not used.
2954
43aae36e
PE
2955 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2956
2a47c44d 2957 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2958 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2959
a37c69bf
PE
2960 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2961 Check for integer overflow on size calculations.
2962
328ab8e7
PE
2963 * buffer.c (Fprevious_overlay_change): Remove var that is set
2964 but not used.
2965
e5a2a5cb
PE
2966 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2967 Remove vars that are set but not used.
8d84a6eb 2968 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2969 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2970
a60e5f68
PE
2971 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2972
f661cb61 2973 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2974 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2975
f0397f5a
PE
2976 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2977 that are set but not used.
2978
8664db06 2979 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2980 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2981
6abdaa4a
PE
2982 * xselect.c (x_get_local_selection, x_handle_property_notify):
2983 Remove vars that are set but not used.
2984
0ce7538d 2985 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2986 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2987
9ae848fc
PE
2988 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2989 Remove var that is set but not used.
0b918413
PE
2990 (scroll_bar_windows_size): Now size_t, not int.
2991 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2992 Check for overflow.
9ae848fc 2993
a5a62657
PE
2994 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2995 (map_tty_color) [!defined MSDOS]: Likewise.
2996
5c5cdd39
PE
2997 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2998
66ebf983
PE
2999 * coding.c: Remove vars that are set but not used.
3000 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3001 All callers changed.
3002 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3003 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3004 (decode_coding_charset): Remove vars that are set but not used.
3005
1be4d761
PE
3006 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3007 that is set but not used.
3008
47553fa8
PE
3009 * print.c (print_object): Remove var that is set but not used.
3010
1f7196bf 3011 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3012 The gnulib version avoids calling malloc in the usual case,
3013 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3014 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3015 * filelock.c (current_lock_owner): Likewise.
3016 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3017 * sysdep.c: Include allocator.h, careadlinkat.h.
3018 (emacs_no_realloc_allocator): New static constant.
3019 (emacs_readlink): New function.
fdb61804
PE
3020 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3021 ../lib/careadlinkat.h.
d1fdcab7 3022
f84c17c7
SM
30232011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3024
3025 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3026 first non-nil return value).
3027
ef3862ad
JD
30282011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3029
3030 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3031 if not defined (Bug#8403).
3032
376a7006
JB
30332011-04-02 Juanma Barranquero <lekktu@gmail.com>
3034
3035 * xdisp.c (display_count_lines): Remove parameter `start',
3036 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3037 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3038 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3039 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3040 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3041 and thereabouts. All callers changed.
3042 (get_per_char_metric): Remove parameter `f', unused since
3043 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3044
6ca3801d
JM
30452011-04-02 Jim Meyering <meyering@redhat.com>
3046
3047 do not dereference NULL upon failed strdup
3048 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3049 (ns_get_family): Likewise.
3050
d8e2b5ba
JB
30512011-04-02 Juanma Barranquero <lekktu@gmail.com>
3052
3053 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3054
8c74fcbd
JD
30552011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3056
3057 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3058 later (Bug#8403).
3059
7200d79c
SM
30602011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3061
03408648 3062 Add lexical binding.
7200d79c 3063
03408648
SM
3064 * window.c (Ftemp_output_buffer_show): New fun.
3065 (Fsave_window_excursion):
3066 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3067
3068 * lread.c (lisp_file_lexically_bound_p): New function.
3069 (Fload): Bind Qlexical_binding.
3070 (readevalloop): Remove `evalfun' arg.
3071 Bind Qinternal_interpreter_environment.
3072 (Feval_buffer): Bind Qlexical_binding.
3073 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3074 Mark as dynamic.
3075 (syms_of_lread): Declare `lexical-binding'.
3076
3077 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3078
3079 * keyboard.c (eval_dyn): New fun.
3080 (menu_item_eval_property): Use it.
ca105506
SM
3081
3082 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3083
03408648
SM
3084 * fns.c (concat, mapcar1): Accept byte-code-functions.
3085
3086 * eval.c (Fsetq): Handle lexical vars.
3087 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3088 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3089 (FletX, Flet): Obey lexical binding.
3090 (Fcommandp): Handle closures.
3091 (Feval): New `lexical' arg.
3092 (eval_sub): New function extracted from Feval. Use it almost
3093 everywhere where Feval was used. Look up vars in lexical env.
3094 Handle closures.
3095 (Ffunctionp): Move from subr.el.
3096 (Ffuncall): Handle closures.
3097 (apply_lambda): Remove `eval_flags'.
3098 (funcall_lambda): Handle closures and new byte-code-functions.
3099 (Fspecial_variable_p): New function.
3100 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3101 but without exporting it to Lisp.
23aba0ea 3102
23aba0ea 3103 * doc.c (Fdocumentation, store_function_docstring):
03408648 3104 * data.c (Finteractive_form): Handle closures.
23aba0ea 3105
03408648
SM
3106 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3107 interactive spec.
ba83908c 3108
04f2d78b
CB
3109 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3110 New byte-codes.
03408648
SM
3111 (exec_byte_code): New function extracted from Fbyte_code to handle new
3112 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3113
03408648 3114 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3115
03408648 3116 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3117
e2abce01
JB
31182011-03-31 Juanma Barranquero <lekktu@gmail.com>
3119
3120 * xdisp.c (redisplay_internal): Fix prototype.
3121
63696a73 31222011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3123
63696a73 3124 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3125 (try_scrolling): Use it when setting scroll_limit.
3126 Limit scrolling to 100 screen lines.
63696a73
EZ
3127 (redisplay_window): Even when falling back on "recentering",
3128 position point in the window according to scroll-conservatively,
3129 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3130
3131 (try_scrolling): When point is above the window, allow searching
3132 as far as scroll_max, or one screenful, to compute vertical
3133 distance from PT to the scroll margin position. This prevents
3134 try_scrolling from unnecessarily failing when
3135 scroll-conservatively is set to a value slightly larger than the
3136 window height. Clean up the case of PT below the margin at bottom
3137 of window: scroll_max can no longer be INT_MAX. When aggressive
3138 scrolling is in use, don't let point enter the opposite scroll
3139 margin as result of the scroll.
3140 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3141 threshold of 100 lines for never-recentering scrolling.
3142
e4cc2dfc
JB
31432011-03-31 Juanma Barranquero <lekktu@gmail.com>
3144
3145 * dispextern.h (move_it_by_lines):
3146 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3147 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3148 (message_log_check_duplicate): Remove parameters `prev_bol' and
3149 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3150 (redisplay_internal): Remove parameter `preserve_echo_area',
3151 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3152
3153 * indent.c (Fvertical_motion):
3154 * window.c (window_scroll_pixel_based, Frecenter):
3155 Don't pass `need_y_p' to `move_it_by_lines'.
3156
1c470562
SM
31572011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3158
44f230aa
SM
3159 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3160 steal a few bits to be more compact.
3161 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3162 Remove unneeded casts.
3163
1c470562
SM
3164 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3165
888adce9
ZK
31662011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3167
3168 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3169 binding" message (bug#7967).
3170
f838ed7b
PE
31712011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3172
77861b95
PE
3173 Fix more problems found by GCC 4.6.0's static checks.
3174
de6dbc14
PE
3175 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3176 Remove unused local var.
3177
f838ed7b
PE
3178 * editfns.c (Fmessage_box): Remove unused local var.
3179
792c7b2b
PE
3180 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3181 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3182 Omit unused local vars.
c499e557 3183 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3184 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3185 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3186 Omit unused local var.
3187
ba0165e1
PE
3188 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3189 Don't assume string length fits in int.
32ad8845 3190 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3191 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3192
3c59b4c9
PE
3193 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3194 instead of alloca (Bug#8344).
3195
a3eed478 3196 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3197 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3198
eb4d412d
PE
3199 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3200
1658b401
PE
3201 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3202 concerns.
3203
3204 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3205
3206 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3207
9a2c6e05
PE
3208 * keyboard.c (syms_of_keyboard): Use the same style as later
3209 in this function when indexing through an array. This also
3210 works around GCC bug 48267.
3211
03d0a109
PE
3212 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3213
44f730c8
PE
3214 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3215
fe75f926
PE
3216 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3217 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3218
ffa8c828
PE
3219 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3220 This avoids undefined behavior on integer overflow, and is a bit
3221 more convenient anyway since it is compared to a size_t variable.
3222
c5101a77
PE
3223 Variadic C functions now count arguments with size_t, not int.
3224 This avoids an unnecessary limitation on 64-bit machines, which
3225 caused (substring ...) to crash on large vectors (Bug#8344).
3226 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3227 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3228 All variadic functions and their callers changed accordingly.
c5101a77
PE
3229 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3230 * data.c (arith_driver, float_arith_driver): Likewise.
3231 * editfns.c (general_insert_function): Likewise.
3232 * eval.c (struct backtrace.nargs, interactive_p)
3233 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3234 (funcall_lambda, mark_backtrace): Likewise.
3235 * fns.c (concat): Likewise.
3236 * frame.c (x_set_frame_parameters): Likewise.
3237 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3238 0 if not found, not -1. All callers changed.
3239
dd3f25f7
PE
3240 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3241 (stack_copy_size): Now size_t, not int.
3242 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3243
461c2ab9
JB
32442011-03-28 Juanma Barranquero <lekktu@gmail.com>
3245
3246 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3247 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3248 All callers changed.
3249
3250 * lisp.h (multibyte_char_to_unibyte):
3251 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3252 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3253 * character.h (CHAR_TO_BYTE8):
3254 * cmds.c (internal_self_insert):
3255 * editfns.c (general_insert_function):
3256 * keymap.c (push_key_description):
3257 * search.c (Freplace_match):
3258 * xdisp.c (message_dolog, set_message_1): All callers changed.
3259
f6d62986
SM
32602011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3261
3262 * keyboard.c (safe_run_hook_funcall): New function.
3263 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3264 don't set the hook to nil, but remove the offending function instead.
3265 (Qcommand_hook_internal): Remove, unused.
3266 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3267 Vcommand_hook_internal.
3268
3269 * eval.c (enum run_hooks_condition): Remove.
3270 (funcall_nil, funcall_not): New functions.
3271 (run_hook_with_args): Call each function through a `funcall' argument.
3272 Remove `cond' argument, now redundant.
3273 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3274 (Frun_hook_with_args_until_failure): Adjust accordingly.
3275 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3276
1db5b1ad
JB
32772011-03-28 Juanma Barranquero <lekktu@gmail.com>
3278
3279 * dispextern.h (string_buffer_position): Remove declaration.
3280
3281 * print.c (strout): Remove parameter `multibyte', unused since
3282 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3283
3284 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3285 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3286 All callers changed.
3287
3288 * w32.c (_wsa_errlist): Use braces for struct initializers.
3289
3290 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3291 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3292 All callers changed.
3293 (string_buffer_position): Likewise. Also, make static (it's never
3294 used outside xdisp.c).
3295 (cursor_row_p): Remove parameter `w', unused since
3296 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3297 (decode_mode_spec): Remove parameter `precision', introduced during
3298 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3299 All callers changed.
3300
5ffb62aa
JD
33012011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3302
3303 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3304
461c2ab9 33052011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3306
3307 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3308 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3309 (ns_update_auto_hide_menu_bar): New functions.
3310 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3311 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3312 ns_constrain_all_frames.
3313 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3314 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3315
5c380ffb
JD
33162011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3317
3318 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3319
9af30bdf
GM
33202011-03-27 Glenn Morris <rgm@gnu.org>
3321
3322 * syssignal.h: Replace RETSIGTYPE with void.
3323 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3324 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3325 Replace SIGTYPE with void everywhere.
3326 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3327 * s/template.h (SIGTYPE): Remove commented out definition.
3328
e2abce01
JB
33292011-03-26 Eli Zaretskii <eliz@gnu.org>
3330
3331 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3332 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3333
f868cd8a
JB
33342011-03-26 Juanma Barranquero <lekktu@gmail.com>
3335
59eb0929
JB
3336 * w32.c (read_unc_volume): Use parameter `henum', instead of
3337 global variable `wget_enum_handle'.
3338
3339 * keymap.c (describe_vector): Remove parameters `indices' and
3340 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3341 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3342
f868cd8a
JB
3343 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3344
3345 * keyboard.c (timer_check): Remove parameter `do_it_now',
3346 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3347 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3348 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3349
3350 * keyboard.c (read_char):
3351 * w32menu.c (w32_menu_display_help):
3352 * xmenu.c (show_help_event, menu_help_callback):
3353 Adjust calls to `show_help_echo'.
3354
3355 * gtkutil.c (xg_maybe_add_timer):
3356 * keyboard.c (readable_events):
3357 * process.c (wait_reading_process_output):
3358 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3359
3360 * insdel.c (adjust_markers_gap_motion):
3361 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3362 (gap_left, gap_right): Don't call it.
3363
2ecf6fdb
CY
33642011-03-25 Chong Yidong <cyd@stupidchicken.com>
3365
3366 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3367 incurred during fontification.
3368
6b1f9ba4
JB
33692011-03-25 Juanma Barranquero <lekktu@gmail.com>
3370
3371 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3372 (DEFVAR_PER_BUFFER): Don't pass it.
3373
3374 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3375 (scrolling_window): Don't pass it.
3376
0f4a96b5
JB
33772011-03-25 Juanma Barranquero <lekktu@gmail.com>
3378
3379 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3380
3381 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3382 and `suffix'.
3383 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3384 of variables specific to SELinux and computation of `encoded_absname'.
3385
3386 * image.c (XPutPixel): Remove unused variable `height'.
3387
3388 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3389
3390 * unexw32.c (get_section_info): Remove unused variable `section'.
3391
3392 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3393 (system_process_attributes): Remove unused variable `sess'.
3394 (sys_read): Remove unused variable `err'.
3395
3396 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3397 (w32_wnd_proc): Remove unused variable `isdead'.
3398 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3399 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3400 (x_create_tip_frame): Remove unused variable `tem'.
3401
3402 * w32inevt.c (w32_console_read_socket):
3403 Remove unused variable `no_events'.
3404
3405 * w32term.c (x_draw_composite_glyph_string_foreground):
3406 Remove unused variable `width'.
3407
1149507c
JB
34082011-03-24 Juanma Barranquero <lekktu@gmail.com>
3409
3410 * w32term.c (x_set_glyph_string_clipping):
3411 Don't pass uninitialized region to CombineRgn.
3412
9c88f339
JB
34132011-03-23 Juanma Barranquero <lekktu@gmail.com>
3414
3415 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3416 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3417 (Fx_close_connection): Remove unused variable `i'.
3418
3419 * w32font.c (w32font_draw): Return number of glyphs.
3420 (w32font_open_internal): Remove unused variable `i'.
3421 (w32font_driver): Add missing initializer.
3422
3423 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3424 (fill_in_menu): Remove unused variable `items_added'.
3425
3426 * w32term.c (last_mouse_press_frame): Remove static global variable.
3427 (w32_clip_to_row): Remove unused variable `f'.
3428 (x_delete_terminal): Remove unused variable `i'.
3429
3430 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3431 (NOTHING): Remove unused static global variable.
3432 (uniscribe_check_otf): Remove unused variable `table'.
3433 (uniscribe_font_driver): Add missing initializers.
3434
dee091a3
JD
34352011-03-23 Julien Danjou <julien@danjou.info>
3436
3437 * term.c (Fsuspend_tty, Fresume_tty):
3438 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3439 * window.c (temp_output_buffer_show):
3440 * insdel.c (signal_before_change):
3441 * frame.c (Fhandle_switch_frame):
3442 * fileio.c (Fdo_auto_save):
3443 * emacs.c (Fkill_emacs):
3444 * editfns.c (save_excursion_restore):
3445 * cmds.c (internal_self_insert):
3446 * callint.c (Fcall_interactively):
3447 * buffer.c (Fkill_all_local_variables):
3448 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3449 Use Frun_hooks.
0f4a96b5 3450 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3451 unconditionnaly since it does the check itself.
3452
2c520ab5 34532011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3454
c9c49752
PE
3455 Fix more problems found by GCC 4.5.2's static checks.
3456
8abc3f12
PE
3457 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3458 the first time through the loop, since we know p0 < p1 then.
3459 This also avoids a gcc -Wstrict-overflow warning.
3460
a2d26660
PE
3461 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3462 leading to a memory leak, possible in functions like
3463 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3464 of objects (Bug#8318).
a2d26660 3465
916c72e9
PE
3466 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3467 that could (at least in theory) be that large.
3468
19ab8a18
PE
3469 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3470 This is less likely to overflow, and avoids undefined behavior if
3471 overflow does occur. All callers changed. Use strtoul to scan
3472 for the unsigned long integer.
b7cbbd6f
PE
3473 (pint2hrstr): Simplify and tune code slightly.
3474 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3475
f0641eff
PE
3476 * scroll.c (do_scrolling): Work around GCC bug 48228.
3477 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3478
7f650bb9
PE
3479 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3480 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3481 (validate_x_resource_name): Simplify count usage.
3482 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3483
37dd57d1
PE
3484 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3485 fail (Bug#8306).
81e56e61 3486
699979fc 3487 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3488
401bf9b4
PE
3489 * process.c (Fmake_network_process): Use socklen_t, not int,
3490 where POSIX says socklen_t is required in portable programs.
3491 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3492 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3493 (Fmake_network_process, server_accept_connection):
3494 (wait_reading_process_output, read_process_output):
3495 Likewise.
3496
b93aacde
PE
3497 * process.c: Rename or move locals to avoid shadowing.
3498 (list_processes_1, Fmake_network_process):
3499 (read_process_output_error_handler, exec_sentinel_error_handler):
3500 Rename or move locals.
4dc343ee 3501 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3502 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3503 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3504 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3505 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3506
af8a867c 3507 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3508 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3509 Include tparam.h instead, since it declares them.
af8a867c
PE
3510 * cm.h (PC): Remove extern decl; tparam.h now does this.
3511 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3512 * terminfo.c: Include tparam.h, to check interfaces.
3513 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3514 (tparam): Adjust signature to match interface in tparam.h;
3515 this removes some undefined behavior. Check that outstring and len
3516 are zero, which they always are with Emacs.
3517 * tparam.h (PC, BC, UP): New extern decls.
3518
0248044d 3519 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3520 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3521
8ff096c1 3522 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3523 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3524 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3525 (ftfont_list): Remove unused local.
49eaafba
PE
3526 (get_adstyle_property, ftfont_pattern_entity):
3527 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3528 Rename locals to avoid shadowing.
8ff096c1 3529
e2be39f6
PE
3530 * xfont.c (xfont_list_family): Mark var as initialized.
3531
c9735e30
PE
3532 * xml.c (make_dom): Now static.
3533
8f5201ae
PE
3534 * composite.c (composition_compute_stop_pos): Rename local to
3535 avoid shadowing.
b246f932
PE
3536 (composition_reseat_it): Remove unused locals.
3537 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3538 (composition_update_it): Mark var as initialized.
11b61122
PE
3539 (find_automatic_composition): Mark vars as initialized,
3540 with a FIXME (Bug#8290).
8f5201ae 3541
760fbc2c
PE
3542 character.h: Rename locals to avoid shadowing.
3543 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3544 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3545 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3546 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3547 to avoid shadowing.
3548
ff08eb85
PE
3549 * textprop.c (property_change_between_p): Remove; unused.
3550
fc7bf025
PE
3551 * intervals.c (interval_start_pos): Now static.
3552
235d7abc
PE
3553 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3554
44f230aa
SM
3555 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3556 Rename locals to avoid shadowing.
3e7d6594 3557
50060332
PE
3558 * sound.c (wav_play, au_play, Fplay_sound_internal):
3559 Fix pointer signedness.
d01f234b 3560 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3561 (wav_play): Initialize a variable to 0, to prevent undefined
3562 behavior (Bug#8278).
50060332 3563
c4fc4e30
PE
3564 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3565
918436ed
PE
3566 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3567
c939f91b
PE
3568 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3569 clobbering (Bug#8298).
b9c7f648
PE
3570 * sysdep.c (sys_subshell): Likewise.
3571 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3572
6bd8c144
PE
3573 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3574 This should get cleaned up, so that child_setup has the
3575 same signature on all platforms.
3576
7710357c 3577 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3578 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3579
c59da222
CY
35802011-03-22 Chong Yidong <cyd@stupidchicken.com>
3581
3582 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3583 not to be necessary, and produces flickering.
3584
66b87493
GM
35852011-03-20 Glenn Morris <rgm@gnu.org>
3586
3587 * config.in: Remove file.
3588
45b6f6d5
JB
35892011-03-20 Juanma Barranquero <lekktu@gmail.com>
3590
3591 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3592 are now in src/globals.h.
3593 (syms_of_minibuf): Remove spurious & from previous change.
3594
3ec03f7e
LL
35952011-03-20 Leo <sdl.web@gmail.com>
3596
3597 * minibuf.c (completing-read-function): New variable.
3598 (completing-read-default): Rename from completing-read.
3599 (completing-read): Call completing-read-function.
3600
b14e3e21
CY
36012011-03-19 Juanma Barranquero <lekktu@gmail.com>
3602
3603 * xfaces.c (Fx_load_color_file):
3604 Read color file from absolute filename (bug#8250).
3605
f2b726e6
JB
36062011-03-19 Juanma Barranquero <lekktu@gmail.com>
3607
3608 * makefile.w32-in: Update dependencies.
3609
09f6ff02
EZ
36102011-03-17 Eli Zaretskii <eliz@gnu.org>
3611
3612 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3613
29a6015a
PE
36142011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3615
a3a6c54e
PE
3616 Fix more problems found by GCC 4.5.2's static checks.
3617
b766f867
PE
3618 * process.c (make_serial_process_unwind, send_process_trap):
3619 (sigchld_handler): Now static.
3620
be02381c
PE
3621 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3622 That way, the code declares only the vars that it needs.
3623 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3624 * s/cygwin.h (PTY_ITERATION): Likewise.
3625 * s/darwin.h (PTY_ITERATION): Likewise.
3626 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3627
57048744
PE
3628 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3629 * process.c (allocate_pty): Don't declare stb unless it's needed.
3630
7914961c 3631 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3632 (CONSTANTLIM): Remove; unused.
3633 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3634 Define only if needed.
7914961c 3635
b3967b18
PE
3636 * unexelf.c (unexec): Name an expression,
3637 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3638 Use a different way to cause a compilation error if anyone uses
3639 n rather than nn, a way that does not involve shadowing.
73366a00 3640 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3641
29a6015a
PE
3642 * deps.mk (unexalpha.o): Remove; unused.
3643
43cfc33e 3644 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3645 * unexec.h: New file.
ce701a33
PE
3646 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3647 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3648 Depend on unexec.h.
3649 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3650 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3651 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3652 Change as necessary to match prototype in unexec.h.
ce701a33 3653
01f44d5a
PE
3654 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3655 shadowing.
4f63c6bb 3656 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3657
a6670b0b
PE
3658 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3659 Rename locals to avoid shadowing.
3660
cef2010d 3661 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3662 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3663
d4d7173a
PE
3664 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3665
f08b802a
PE
3666 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3667 warning when compiling print.c.
3668
3ddb0639
PE
3669 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3670 instead of using an uninitialized var.
5ad03b97 3671 (font_sort_entities): Mark var as initialized.
3ddb0639 3672
170a2692
PE
3673 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3674
e663c700
PE
3675 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3676 pointers to constants.
89bc529a 3677 (font_parse_fcname): Remove unused vars.
7b81e2d0 3678 (font_delete_unmatched): Now static.
ea838e10 3679 (font_get_spec): Remove; unused.
13a547c6
PE
3680 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3681 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3682 Rename or move locals to avoid shadowing.
e663c700 3683
2a80c887 3684 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3685 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3686
1384fa33 3687 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3688 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3689
8b2c52e9
PE
3690 * alloc.c (mark_backtrace): Move decl from here ...
3691 * lisp.h: ... to here, so that it can be checked.
3692
475545b5 3693 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3694 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3695 (lisp_indirect_variable): Name an expression,
3696 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3697 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3698
b1349114 3699 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3700 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3701 Use const pointer when appropriate.
b1349114 3702
a2928364
PE
3703 * lisp.h (get_system_name, get_operating_system_release):
3704 Move decls here, to check interfaces.
3705 * process.c (get_operating_system_release): Move decl to lisp.h.
3706 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3707 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3708 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3709 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3710 (Fformat_time_string, Fencode_time, Finsert_char):
3711 (Ftranslate_region_internal, Fformat):
3712 Rename or remove local vars to avoid shadowing.
9710023e 3713 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3714
a415e694
PE
3715 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3716 avoid shadowing.
3717
8ef4622d
PE
3718 * lisp.h (eassert): Check that the argument compiles, even if
3719 ENABLE_CHECKING is not defined.
3720
946f9a5b
PE
3721 * data.c (Findirect_variable): Name an expression, to avoid
3722 gcc -Wbad-function-cast warning.
112396d6 3723 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3724 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3725 (Fmake_variable_buffer_local, Fmake_local_variable):
3726 Mark variables as initialized.
52746918 3727 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3728
e5aab7e7 3729 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3730 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3731 Rename locals to avoid shadowing.
dff45157
PE
3732 (mark_stack): Move local variables into the #ifdef region where
3733 they're used.
7bc26fdb
PE
3734 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3735 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3736 needed otherwise.
3737 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3738 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3739 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3740
e5aab7e7
PE
3741 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3742 avoids undefined behavior in theory.
3743
4da60324
PE
3744 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3745
88043301
PE
3746 Use functions, not macros, for up- and down-casing (Bug#8254).
3747 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3748 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3749 to use the following functions instead of these macros.
3750 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3751 EMACS_INT, since callers assume the returned value fits in int.
3752 (upcase1): Likewise, for UPCASE_TABLE.
3753 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3754 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3755 the race-condition problem in the old DOWNCASE.
88043301 3756
19ed5445
PE
3757 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3758 Rename locals to avoid shadowing.
3759 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3760 (regex_compile, re_search_2, re_match_2_internal):
3761 Remove unused local vars.
952db0d7
PE
3762 (FREE_VAR): Rewrite so as not to use empty "else",
3763 which gcc can warn about.
da053e48 3764 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3765 (RETALLOC_IF): Define only if needed.
3766 (WORDCHAR_P): Likewise. This one is never needed, but is used
3767 only in a comment talking about a compiler bug, so put inside
3768 the #if 0 of that comment.
3769 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3770 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3771 Remove; unused.
19ed5445 3772
1f3561e4 3773 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3774 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3775 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3776
ded6f8f7
PE
3777 * search.c (simple_search): Remove unused var.
3778
dbd37a95
PE
3779 * dired.c (compile_pattern): Move decl from here ...
3780 * lisp.h: ... to here, so that it can be checked.
3781 (struct re_registers): New forward decl.
3782
7e47afad
PE
3783 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3784
85f24f61
PE
3785 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3786 All uses changed.
3787 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3788 Rename locals to avoid shadowing.
5671df8f 3789 (Fvertical_motion): Mark locals as initialized.
85f24f61 3790
181aa2be 3791 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3792 (casify_region): Mark local as initialized.
181aa2be 3793
930d429c
PE
3794 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3795
7082eac6
PE
3796 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3797 New macros, so that the caller can use some names other than
3798 gcpro1, gcpro2, etc.
3799 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3800 of the new macros.
3801 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3802 argument, for consistency with GCPRO2_VAR, etc: it is now the
3803 prefix of the variable, not the variable itself. All uses
3804 changed.
38b2c076
PE
3805 * dired.c (directory_files_internal, file_name_completion):
3806 Rename locals to avoid shadowing.
3807
15206ed9
PE
3808 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3809 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3810 dired.c's scmp function, had undefined behavior.
3811 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3812 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3813 * buffer.h: ... to here, because these macros use current_buffer,
3814 and the new implementation with inline functions needs to have
3815 current_buffer in scope now, rather than later when the macros
3816 are used.
3817 (downcase, upcase1): New static inline functions.
3818 (DOWNCASE, UPCASE1): Reimplement using these functions.
3819 This avoids undefined behavior in expressions like
3820 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3821 from race conditions in accessing the global variables
3822 case_temp1 and case_temp2.
3823 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3824 * lisp.h (case_temp1, case_temp2): Remove their decls.
3825 * character.h (ASCII_CHAR_P): Move from here ...
3826 * lisp.h: ... to here, so that the inline functions mentioned
3827 above can use them.
3828
4a6bea26
PE
3829 * dired.c (directory_files_internal_unwind): Now static.
3830
f14b7e14
PE
3831 * fileio.c (file_name_as_directory, directory_file_name):
3832 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3833 Now static.
2893f146
PE
3834 (file_name_as_directory): Use const pointers when appropriate.
3835 (Fexpand_file_name): Likewise. In particular, newdir might
3836 point at constant storage, so make it a const pointer.
fd4ead52 3837 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3838 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3839 signedness issues.
f839df0c
PE
3840 (Fset_file_times, Finsert_file_contents, auto_save_error):
3841 Rename locals to avoid shadowing.
f14b7e14 3842
5716756e 3843 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3844 (Ftry_completion, Fall_completions): Rename or remove locals
3845 to avoid shadowing.
5716756e 3846
b4c3046a
PE
3847 * marker.c (bytepos_to_charpos): Remove; unused.
3848
b45db522
PE
3849 * lisp.h (verify_bytepos, count_markers): New decls,
3850 so that gcc does not warn that these functions aren't declared.
3851
85876d07
PE
3852 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3853 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3854 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3855 (copy_text): Remove unused local var.
85876d07 3856
03d78a21 3857 * filelock.c (within_one_second): Now static.
b3dd38ab 3858 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3859
5df8f01b
PE
3860 * buffer.c (fix_overlays_before): Mark locals as initialized.
3861 (fix_start_end_in_overlays): Likewise. This function should be
3862 simplified by using pointers-to-pointers, but that's a different
3863 matter.
b1d876f1 3864 (switch_to_buffer_1): Now static.
8f54f30a
PE
3865 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3866 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3867
a70072c9 3868 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3869 Fix pointer signedness issue.
edced198
PE
3870 (sys_subshell): Mark local as volatile if checking for lint,
3871 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3872 (MAXPATHLEN): Define only if needed.
a70072c9 3873
a0977c44
PE
3874 * process.c (serial_open, serial_configure): Move decls from here ...
3875 * systty.h: ... to here, so that they can be checked.
3876
a884fdcc
PE
3877 * fns.c (get_random, seed_random): Move extern decls from here ...
3878 * lisp.h: ... to here, so that they can be checked.
3879
604efe86 3880 * sysdep.c (reset_io): Now static.
b8950c94 3881 (wait_for_termination_signal): Remove; unused.
604efe86 3882
38fc62d9
PE
3883 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3884 (copy_keymap_item, append_key, push_text_char_description):
3885 Now static.
1004a21a 3886 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3887 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3888 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3889 (describe_map_tree):
3890 Rename locals to avoid shadowing.
38fc62d9 3891
2f2650da
PE
3892 * keyboard.c: Declare functions static if they are not used elsewhere.
3893 (echo_char, echo_dash, cmd_error, top_level_2):
3894 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3895 (read_char, kbd_buffer_get_event, make_lispy_position):
3896 (make_lispy_event, make_lispy_movement, apply_modifiers):
3897 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3898 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3899 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3900 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3901 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3902
a053e86c 3903 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3904 (mark_kboards): Move decl here ...
3905 * alloc.c (mark_kboards): ... from here.
a053e86c 3906
4752793e
PE
3907 * lisp.h (force_auto_save_soon): New decl.
3908
74f10ca7 3909 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3910 (DEFINE_DUMMY_FUNCTION): New macro.
3911 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3912 Use it.
c03cd23f
PE
3913 (main): Add casts to avoid warnings
3914 if GCC considers string literals to be constants.
74f10ca7 3915
022e70d4
PE
3916 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3917
59d6fe83
PE
3918 * dbusbind.c: Pointer signedness fixes.
3919 (xd_signature, xd_append_arg, xd_initialize):
3920 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3921 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3922 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3923 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3924
78320123
PE
3925 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3926 if GCC considers string literals to be constants.
49cebcca 3927 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3928
35ac2a97
SM
39292011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3930
fb103ca9
SM
3931 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3932 (print_preprocess, print_object): New macro to fix last change.
3933
35ac2a97
SM
3934 * print.c (print_preprocess): Don't forget font objects.
3935
62973b41
JB
39362011-03-16 Juanma Barranquero <lekktu@gmail.com>
3937
3938 * emacs.c (USAGE3): Doc fixes.
3939
0e48bb22
AS
39402011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3941
3942 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3943 structure.
3944
7684e57b
JB
39452011-03-14 Juanma Barranquero <lekktu@gmail.com>
3946
3947 * lisp.h (VWindow_system, Qfile_name_history):
3948 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3949 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3950 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3951
3952 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3953 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3954
3955 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3956 * w32console.c (detect_input_pending, read_input_pending)
3957 (encode_terminal_code):
3958 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3959 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3960 (w32_system_caret_y, Qfile_name_history):
3961 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3962 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3963 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3964 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3965 * w32proc.c (Qlocal, report_file_error):
3966 * w32term.c (Vwindow_system, updating_frame):
3967 * w32uniscribe.c (initialized, uniscribe_font_driver):
3968 Remove unneeded extern declarations.
3969
2aa46d6c
CY
39702011-03-14 Chong Yidong <cyd@stupidchicken.com>
3971
c96bbc66 3972 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3973
cffc6f3b
CY
39742011-03-13 Chong Yidong <cyd@stupidchicken.com>
3975
3976 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3977 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3978 These macros can no longer be used for assignment.
3979
44f230aa
SM
3980 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3981 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3982 (record_buffer_markers, fetch_buffer_markers): New functions for
3983 recording and fetching special buffer markers.
3984 (set_buffer_internal_1, set_buffer_temp): Use them.
3985
3986 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3987
3988 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3989
3990 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3991 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3992
3993 * xdisp.c (hscroll_window_tree):
3994 (reconsider_clip_changes): Use PT instead of BUF_PT.
3995
d251f04b
EZ
39962011-03-13 Eli Zaretskii <eliz@gnu.org>
3997
3998 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3999 $(EMACS_ROOT)/lib/intprops.h.
4000
f0c77cd1
PE
40012011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4002
3eca4629
PE
4003 Fix more problems found by GCC 4.5.2's static checks.
4004
7c86ee98
PE
4005 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4006 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4007 (xg_free_frame_widgets): Make it clear that a local variable is
4008 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4009 (gdk_window_get_screen): Make it clear that this macro is needed
4010 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4011 (int_gtk_range_get_value): New function, which avoids a diagnostic
4012 from gcc -Wbad-function-cast.
4013 (xg_set_toolkit_scroll_bar_thumb): Use it.
4014 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4015 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4016 (get_utf8_string, xg_get_file_with_chooser):
4017 Rename locals to avoid shadowing.
4018 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4019
41729b81
PE
4020 * xgselect.c (xg_select): Remove unused var.
4021
f0c77cd1
PE
4022 * image.c (four_corners_best): Mark locals as initialized.
4023 (gif_load): Initialize transparent_p to zero (Bug#8238).
4024 Mark another local as initialized.
ec6cf4c6 4025 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4026
ce0ad53d 4027 * image.c (clear_image_cache): Now static.
d5d5a617 4028 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4029 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4030 (x_edge_detection): Remove unnecessary cast that
4031 gcc -Wbad-function-cast diagnoses.
2037898d 4032 (gif_load): Fix pointer signedness.
6ae141d6
PE
4033 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4034 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4035
33383987 40362011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4037
d32df629
PE
4038 Improve quality of tests for time stamp overflow.
4039 For example, without this patch (encode-time 0 0 0 1 1
4040 1152921504606846976) returns the obviously-bogus value (-948597
4041 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4042 reports time overflow. See
4043 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4044 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4045 * editfns.c: Include limits.h and intprops.h.
4046 (TIME_T_MIN, TIME_T_MAX): New macros.
4047 (time_overflow): Move earlier, to before first use.
4048 (hi_time, lo_time): New functions, for an accurate test for
4049 out-of-range times.
4050 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4051 (Fget_internal_run_time): Don't assume time_t fits in int.
4052 (make_time): Use list2 instead of Fcons twice.
4053 (Fdecode_time): More accurate test for out-of-range times.
4054 (check_tm_member): New function.
4055 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4056 (lisp_time_argument): Don't rely on undefined left-shift and
4057 right-shift behavior when checking for time stamp overflow.
8be6f318 4058
fe31d94c
PE
4059 * editfns.c (time_overflow): New function, refactoring common code.
4060 (Fformat_time_string, Fdecode_time, Fencode_time):
4061 (Fcurrent_time_string): Use it.
4062
8be6f318
PE
4063 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4064 * dired.c (make_time): Move to ...
4065 * editfns.c (make_time): ... here.
4066 * systime.h: Note the move.
4067
09d9db2c 40682011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4069
126bc0dc
YM
4070 * fringe.c (update_window_fringes): Remove unused variables.
4071
c47cbdfd
YM
4072 * unexmacosx.c (copy_data_segment): Also copy __got section.
4073 (Bug#8223)
4074
7ac80be9
EZ
40752011-03-12 Eli Zaretskii <eliz@gnu.org>
4076
c96bbc66 4077 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4078 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4079 Constify `char *' arguments and their references according to
4080 prototypes in tparam.h.
4081
ecb0f94d 4082 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4083
7ac80be9
EZ
4084 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4085 Adapt all references accordingly.
4086
4087 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4088
ef1fd07e
TT
40892011-03-11 Tom Tromey <tromey@redhat.com>
4090
4091 * buffer.c (syms_of_buffer): Remove obsolete comment.
4092
7ef4b50c
EZ
40932011-03-11 Eli Zaretskii <eliz@gnu.org>
4094
4095 * termhooks.h (encode_terminal_code): Declare prototype.
4096
4097 * msdos.c (encode_terminal_code): Don't declare prototype.
4098
4099 * term.c (encode_terminal_code): Now external again, used by
4100 w32console.c and msdos.c.
4101
44f230aa
SM
4102 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4103 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4104
4b1ec863 41052011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4106
1714f52b 4107 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4108
4b1ec863
PE
4109 * fringe.c (update_window_fringes): Mark locals as initialized
4110 (Bug#8227).
4111 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4112
524c7aa6
PE
4113 * alloc.c (mark_fringe_data): Move decl from here ...
4114 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4115 to check its interface.
4116 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4117
a5c0af81 4118 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4119 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4120 (fontset_font): Mark local as initialized.
a9a06e0b 4121 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4122
b4716021
PE
4123 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4124
811e9bac 4125 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4126 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4127 (x_own_selection, Fx_disown_selection_internal): Rename locals
4128 to avoid shadowing.
4129 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4130
7e3ab302
PE
4131 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4132 so that the caller can use some name other than gcpro1.
4133 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4134 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4135 (Fx_backspace_delete_keys_p):
4136 Use them to avoid shadowing, and rename vars to avoid shadowing.
4137 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4138 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4139 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4140 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4141 Remove unused locals.
7e3ab302
PE
4142 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4143 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4144 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4145 macros.
f78faa98 4146
e2b13473
PE
4147 * xterm.h (x_mouse_leave): New decl.
4148
77f23912
PE
4149 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4150 Remove unused functions.
cdf4ba58
PE
4151 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4152 (x_calc_absolute_position): Now static.
7411c686 4153 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4154 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4155 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4156 unless they are used.
38d0b34a
PE
4157 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4158 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4159 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4160 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4161 (x_error_catcher, x_connection_closed, x_error_handler):
4162 (x_error_quitter, xembed_send_message, x_iconify_frame):
4163 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4164 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4165 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4166
44f230aa
SM
4167 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4168 Rename or move locals to avoid shadowing.
6b463e58 4169 (tty_defined_color, merge_face_heights): Now static.
5967d051 4170 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4171 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4172 does not deduce is never used uninitialized.
73719eba
PE
4173 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4174 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4175
426994c3 4176 * terminal.c (store_terminal_param): Now static.
5489860b 4177
032f1620 4178 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4179 (set_frame_menubar): Remove unused local.
d4323972 4180 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4181 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4182 since they might point to immutable storage.
281585b0
PE
4183 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4184 since it's unused otherwise.
032f1620 4185
367c19e5 4186 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4187 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4188 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4189 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4190 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4191 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4192 does not deduce are never used uninitialized.
70739cbe 4193
07b48fa9
PE
4194 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4195
8868a238 4196 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4197 * window.c (window_loop, size_window):
4198 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4199
7e5cf297 4200 * window.c (display_buffer): Now static.
d6550a9f
PE
4201 (size_window): Mark variables that gcc -Wuninitialized
4202 does not deduce are never used uninitialized.
a586633d
PE
4203 * window.h (check_all_windows): New decl, to forestall
4204 gcc -Wmissing-prototypes diagnostic.
5b555da1 4205 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4206
f6095868
PE
4207 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4208 shadowing.
4209 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4210 Include <limits.h>.
4211 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4212 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4213 (load_charset_map): Mark variables that gcc -Wuninitialized
4214 does not deduce are never used uninitialized.
53df7c11 4215 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4216
f38b440c
PE
4217 * coding.c (coding_set_source, coding_set_destination):
4218 Use "else { /* comment */ }" rather than "else /* comment */;"
4219 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4220 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4221 a block, when the outer 'i' will do.
4222 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4223 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4224 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4225 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4226 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4227 Rename locals to avoid shadowing.
4228 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4229 * coding.c (emacs_mule_char, encode_invocation_designation):
4230 Now static, since they're not used elsewhere.
413bb2db 4231 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4232 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4233 (decode_coding_emacs_mule): Mark variables that gcc
4234 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4235 (detect_coding_iso_2022): Initialize a local variable that might
4236 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4237 this initialization is needed. (Bug#8211)
5f58e762
PE
4238 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4239 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4240 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4241 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4242 Remove unused macros.
f38b440c 4243
232b38b9 4244 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4245 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4246 * character.c (string_count_byte8): Likewise.
232b38b9 4247
fb90da1b
PE
4248 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4249 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4250
fb93dbc2
PE
4251 * chartab.c (copy_sub_char_table): Now static, since it's not used
4252 elsewhere.
5c156ace
PE
4253 (sub_char_table_ref_and_range, char_table_ref_and_range):
4254 Rename locals to avoid shadowing.
bbcd0949 4255 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4256
7d3b3862 4257 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4258 (BIDI_BOB): Remove unused macro.
7d3b3862 4259
6be7d3da
PE
4260 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4261 deduce are never used uninitialized.
c2ed9c8b 4262 * term.c (encode_terminal_code): Likewise.
6be7d3da 4263
75f8807f 4264 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4265
50938595
PE
4266 * tparam.h: New file.
4267 * term.c, tparam.h: Include it.
4268 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4269 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4270 Move these decls to tparam.h, and make them agree with what
4271 is actually in tparam.c. The previous trick of using incompatible
4272 decls in different modules does not conform to the C standard.
4273 All callers of tparam changed to use tparam's actual API.
4274 * tparam.c (tparam1, tparam, tgoto):
4275 Use const pointers where appropriate.
4276
fbceeba2
PE
4277 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4278 * cm.h (struct cm): Likewise.
4279 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4280 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4281 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4282 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4283 (turn_on_face, init_tty): Likewise.
4284 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4285
7f3f1250
PE
4286 * term.c (term_mouse_position): Rename local to avoid shadowing.
4287
e6ca6543
PE
4288 * alloc.c (mark_ttys): Move decl from here ...
4289 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4290
c40f8d15
AS
42912011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4292
4293 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4294
cfe0661d
JB
42952011-03-09 Juanma Barranquero <lekktu@gmail.com>
4296
4297 * search.c (compile_pattern_1): Remove argument regp, unused since
4298 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4299 (compile_pattern): Don't pass it.
4300
0afb4571
J
43012011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4302
4303 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4304 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4305 for ! HAVE_GTK3.
4306 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4307
4308 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4309
4310 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4311 gdk_window_get_screen, gdk_window_get_geometry,
4312 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4313 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4314 (xg_get_pixbuf_from_pixmap): New function.
4315 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4316 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4317 Call xg_get_pixbuf_from_pixmap instead of
4318 gdk_pixbuf_get_from_drawable.
4319 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4320 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4321 (xg_check_special_colors): Use GtkStyleContext and its functions
4322 for HAVE_GTK3.
4323 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4324 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4325 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4326 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4327 Call gtk_widget_get_preferred_size.
0afb4571
J
4328 (xg_frame_resized): gdk_window_get_geometry only takes 5
4329 parameters.
44f230aa
SM
4330 (xg_win_to_widget, xg_event_is_for_menubar):
4331 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4332 (xg_set_widget_bg): New function.
4333 (delete_cb): New function.
895009e1 4334 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4335 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4336 (xg_set_background_color): Call xg_set_widget_bg.
4337 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4338 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4339 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4340 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4341 if ! HAVE_GTK3.
4342 (update_frame_tool_bar): Call gtk_widget_hide.
4343 (xg_initialize): Use GDK_KEY_g.
4344
4345 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4346 if ! HAVE_GTK3
4347 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4348
4349 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4350 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4351 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4352
1c2cc4ef
JB
43532011-03-08 Juanma Barranquero <lekktu@gmail.com>
4354
4355 * w32xfns.c (select_palette): Check success of RealizePalette against
4356 GDI_ERROR, not zero.
4357
33383987 4358See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4359
4360;; Local Variables:
4361;; coding: utf-8
aac0c6e3
MR
4362;; End:
4363
33383987 4364 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4365
4366 This file is part of GNU Emacs.
4367
4368 GNU Emacs is free software: you can redistribute it and/or modify
4369 it under the terms of the GNU General Public License as published by
4370 the Free Software Foundation, either version 3 of the License, or
4371 (at your option) any later version.
4372
4373 GNU Emacs is distributed in the hope that it will be useful,
4374 but WITHOUT ANY WARRANTY; without even the implied warranty of
4375 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4376 GNU General Public License for more details.
4377
4378 You should have received a copy of the GNU General Public License
4379 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.