Tiny NEWS edit
[bpt/emacs.git] / src / ChangeLog
CommitLineData
7c4e8ec0
GM
12012-07-09 Glenn Morris <rgm@gnu.org>
2
d4f600ff
GM
3 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
4 since the included bsd-common.h does so.
5
cbb31951
GM
6 Stop ns builds setting the EMACSPATH environment variable.
7 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
8 (ns_init_paths): Do not set EMACSPATH.
9 * nsterm.h (ns_exec_path): Add it.
10 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
11 Use ns_exec_path.
12
7c4e8ec0
GM
13 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
14
26bccfae
PE
152012-07-09 Paul Eggert <eggert@cs.ucla.edu>
16
a0bee46f
PE
17 * process.c (wait_reading_process_output): 'waitchannels' was unset
18 when read_kbd || !NILP (wait_for_cell); fix this.
19
5994c183
PE
20 Add GCC-style 'const' attribute to functions that can use it.
21 * character.h (char_resolve_modifier_mask):
22 * keyboard.h (make_ctrl_char):
23 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
24 (init_character_once, next_almost_prime, init_fns, init_image)
25 (flush_pending_output, init_sound):
26 * mem-limits.h (start_of_data):
27 * menu.h (finish_menu_items):
28 Add ATTRIBUTE_CONST.
29 * emacs.c (DEFINE_DUMMY_FUNCTION):
30 Declare the dummy function with ATTRIBUTE_CONST.
31 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
32 Add decls with ATTRIBUTE_CONST.
33
26bccfae
PE
34 Minor improvements to make_formatted_string.
35 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
36 where int is good enough, as vsprintf returns an int.
37 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
38
a8290ec3
DA
392012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
40
41 Use make_formatted_string to avoid double length calculation.
42 * lisp.h (make_formatted_string): New prototype.
43 * alloc.c (make_formatted_string): New function.
44 * buffer.c (Fgenerate_new_buffer_name): Use it.
45 * dbus.c (syms_of_dbusbind): Likewise.
46 * editfns.c (Fcurrent_time_zone): Likewise.
47 * filelock.c (get_boot_time): Likewise.
48 * frame.c (make_terminal_frame, set_term_frame_name)
49 (x_report_frame_params): Likewise.
50 * image.c (gs_load): Likewise.
51 * minibuf.c (get_minibuffer): Likewise.
52 * msdos.c (dos_set_window_size): Likewise.
53 * process.c (make_process): Likewise.
54 * xdisp.c (ensure_echo_area_buffers): Likewise.
55 * xsettings.c (apply_xft_settings): Likewise.
56
d01ba2f1
GM
572012-07-09 Glenn Morris <rgm@gnu.org>
58
59 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
60 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
61 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
62 * nsterm.h (ns_etc_directory): Add it.
63 * callproc.c [HAVE_NS]: Include nsterm.h.
64 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
65
f1f924b6
DA
662012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
67
68 Move marker debugging code under MARKER_DEBUG.
69 * marker.c (MARKER_DEBUG): Move marker debugging code under
70 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
71 for bootstrap with --enable-checking (~3x slowdown reported
72 by Juanma Barranquero <lekktu@gmail.com>).
73 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
74
ab531b66
PE
752012-07-08 Paul Eggert <eggert@cs.ucla.edu>
76
77 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
78 See <http://bugs.gnu.org/11825#29>.
79
c4b3bc8a
EZ
802012-07-08 Eli Zaretskii <eliz@gnu.org>
81
82 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
83 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
84 (display_line): Add commentary about displaying truncation glyphs
85 on GUI frames.
86 (produce_special_glyphs): Move here from term.c.
87
88 * term.c (produce_special_glyphs): Move to xdisp.c.
89
90 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
91 section.
c4b3bc8a 92
b676b881
AS
932012-07-07 Andreas Schwab <schwab@linux-m68k.org>
94
f17c5273
AS
95 * xdisp.c (display_line): Avoid warning about implicit declaration
96 of FRAME_FONT.
97
298819b9
AS
98 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
99
b676b881
AS
100 * lisp.h: Remove empty conditional.
101
6045c4fd
PE
1022012-07-07 Paul Eggert <eggert@cs.ucla.edu>
103
b3350bf9
PE
104 * lread.c (load_path_check): Now static.
105
6045c4fd
PE
106 Fix some minor --with-ns problems found by static checking.
107 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
108 (x_set_font) [!HAVE_X_WINDOWS]:
109 * image.c (xpm_load_image) [HAVE_NS]:
110 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
111 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
112 Remove unused local.
113 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
114 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
115 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
116 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
117 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
118 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
119 Fix pointer signedness problem.
120 * xfaces.c (FRAME_X_FONT_TABLE):
121 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
122
929e7845
GM
1232012-07-07 Glenn Morris <rgm@gnu.org>
124
125 * lread.c (load_path_check): New function, split from init_lread.
126 (init_lread): Reorganize. Motivation:
127 If EMACSLOADPATH is set, check/warn about that rather than the
128 defaults, which we are not going to use. Hence we can remove
129 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
130 Don't warn if site-lisp directories are missing.
131 If not installed, start from a blank load-path, since
132 PATH_LOADSEARCH refers to the eventual installation directories.
133
58dd0aa4
EZ
1342012-07-07 Eli Zaretskii <eliz@gnu.org>
135
136 Support truncation and continuation glyphs on GUI frames, when
137 fringes are disabled. (Bug#11832)
138 * xdisp.c (init_iterator): Get dimensions of truncation and
139 continuation glyphs even if on GUI frames. Adjust
140 it->last_visible_x on GUI frames when the left or right fringes,
141 or both, are absent.
142 (start_display, move_it_in_display_line_to): Handle the case of a
143 GUI frame without a fringe to display continuation or truncation
144 glyphs.
145 (insert_left_trunc_glyphs): Support GUI frames: make sure
146 truncation glyphs overwrite enough glyphs from the current line to
147 have sufficient space in pixels.
148 (display_line): Support truncation and continuation glyphs on GUI
149 frames. If some spare pixels are left on the line after inserting
150 the truncation glyphs, fill that space with a stretch glyph of a
151 suitably computed width.
152
153 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
154 produce_glyphs, to support GUI sessions.
155
31571fd7
PE
1562012-07-07 Paul Eggert <eggert@cs.ucla.edu>
157
5a16b9bc
PE
158 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
159
f3047c75
PE
160 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
161
31571fd7
PE
162 Do not require float-time's arg to fit in time_t (Bug#11825).
163 This works better on hosts where time_t is unsigned, and where
164 float-time is applied to the (negative) difference between two times.
165 * editfns.c (decode_time_components): Last arg is now double *,
166 not int *, and means to store all the result as a double, without
167 worrying about whether the seconds part fits in time_t.
168 All callers changed.
169 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
170 All callers changed.
171 (Ffloat_time): Do not fail merely because the specified time falls
172 outside of time_t range.
173
4516fbef
GM
1742012-07-07 Glenn Morris <rgm@gnu.org>
175
176 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
177 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
178 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
179
07adc2c6
JB
1802012-07-07 Juanma Barranquero <lekktu@gmail.com>
181
182 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
183 Update dependencies.
184
185 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
186
fd573f31
PE
1872012-07-06 Paul Eggert <eggert@cs.ucla.edu>
188
fee5959d
PE
189 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
190 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
191 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
192 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
193 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
194 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
195
fd573f31
PE
196 * xfont.c (compare_font_names): Redo to omit the need for casts.
197
ddadbc0e
AS
1982012-07-06 Andreas Schwab <schwab@linux-m68k.org>
199
fca8d6b6
AS
200 * xfns.c (Fx_change_window_property): Doc fix.
201 * w32fns.c (Fx_change_window_property): Doc fix.
202
ddadbc0e
AS
203 * w32fns.c (Fx_window_property): Accept the same arguments as the
204 X Windows version. Doc fix.
205 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
206
f247498e
JB
2072012-07-06 Juanma Barranquero <lekktu@gmail.com>
208 Eli Zaretskii <eliz@gnu.org>
209
210 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
211 Windows-specific code from nt/config.nt moved here.
212 Obsolete settings removed.
213
216ee680
PE
2142012-07-06 Paul Eggert <eggert@cs.ucla.edu>
215
216 * process.c: Avoid unnecessary calls to gettime.
217 (wait_reading_process_output): Don't get the time of day
218 when gobbling data immediately and not waiting, as there's no need
219 for it in that case. This removes a FIXME.
220
bdd091e4
JD
2212012-07-06 Jan Djärv <jan.h.d@swipnet.se>
222
223 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
224 is defined (Bug#11768).
225
9d44f8ce
DA
2262012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
227
228 Fix marker debugging code.
229 * marker.c (byte_char_debug_check): Do not perform the check
230 if buffer is not multibyte.
090bd7cb
JB
231 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
232 Call byte_char_debug_check with correct arguments.
9d44f8ce 233
90fc4786
DA
2342012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
235
236 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
237 * marker.c (byte_char_debug_check, count_markers):
238 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
239 (byte_debug_flag): Remove.
240 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
241 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
242
7b7ae965
DA
2432012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
244
4e57b342
DA
245 Avoid code repetition in marker-related functions.
246 * marker.c (attach_marker): New function.
247 (Fset_marker, set_marker_restricted, set_marker_both)
248 (set_marker_restricted_both): Use it.
249 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
250 Consistently rename charno to charpos.
251 (marker_position): Add eassert.
252 (marker_byte_position): Convert to eassert.
253
2542012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
255
256 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 257 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 258 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 259
657924ff
DA
2602012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
261
262 Introduce fast path for the widely used marker operation.
263 * alloc.c (build_marker): New function.
264 * lisp.h (build_marker): New prototype.
265 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
266 * composite.c (autocmp_chars): Likewise.
267 * editfns.c (buildmark): Remove.
268 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
269 (save_restriction_save): Use build_marker.
270 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
271 * window.c (save_window_save): Likewise.
272
041a49a6
DA
2732012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
274
275 Do not use Fdelete_overlay in delete_all_overlays
276 to avoid redundant calls to unchain_overlay.
277 * buffer.c (drop_overlay): New function.
278 (delete_all_overlays, Fdelete_overlay): Use it.
279 * minibuf.c (get_minibuffer): Fix comment.
280
7dca65a4
PE
2812012-07-06 Paul Eggert <eggert@cs.ucla.edu>
282
283 Port to OpenBSD 5.1 amd64.
284 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
285 This is needed for OpenBSD, and should be harmless on all BSD systems.
286 Also, include <sys/sysctl.h>, as it should be available on all
287 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
288 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
289 use p_pid member, not kp_proc.pid.
290
8eb876e2
GM
2912012-07-06 Glenn Morris <rgm@gnu.org>
292
293 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
294
38182d90
PE
2952012-07-05 Paul Eggert <eggert@cs.ucla.edu>
296
297 More xmalloc and related cleanup.
298 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
299 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
300 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
301 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
302 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
303 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
304 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
305 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
306 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
307 * xterm.c:
308 Omit needless casts involving void * pointers and allocation.
309 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
310 as the former is more robust if P's type is changed.
311 Prefer xzalloc to xmalloc + memset 0.
312 Simplify malloc-or-realloc to realloc.
313 Don't worry about xmalloc returning a null pointer.
314 Prefer xstrdup to xmalloc + strcpy.
315 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
316 growing it.
317 * keyboard.c (apply_modifiers_uncached): Prefer local array to
318 alloca of a constant.
319
6dd5a677
EZ
3202012-07-05 Eli Zaretskii <eliz@gnu.org>
321
322 * xdisp.c (display_line): Fix horizontal pixel coordinates when
323 hscroll is larger than the line width. Fixes long and futile
324 looping inside extend_face_to_end_of_line (on a TTY) producing
325 glyphs that are not needed and thrown away.
326
6b312f0f
DA
3272012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
328
329 * marker.c (set_marker_restricted_both): Simplify by using
330 clip_to_bounds.
331
f520ef9b
PE
3322012-07-05 Paul Eggert <eggert@cs.ucla.edu>
333
334 * editfns.c (region_limit): Simplify by using clip_to_bounds.
335
383b7c95
JD
3362012-07-05 Jan Djärv <jan.h.d@swipnet.se>
337
338 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
339 not defined (Bug#11768).
340 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
341 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
342 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
343 followed by gtk_box_set_homogeneous (Bug#11768).
344 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
345 (update_theme_scrollbar_width, xg_create_scroll_bar):
346 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
347 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
348 (is_box_type): New function (Bug#11768).
349 (xg_tool_item_stale_p): Call is_box_type.
5293d758 350 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
351 with default display (Bug#11768).
352
d6e7bf45
EZ
3532012-07-05 Eli Zaretskii <eliz@gnu.org>
354
355 * xdisp.c (window_hscroll_limited): New function.
356 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
357 coordinates when window's hscroll is set to insanely large
358 values. (Bug#11857)
359
431391ec
JB
3602012-07-05 Juanma Barranquero <lekktu@gmail.com>
361
362 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
363 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
364
23f86fce
DA
3652012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
366
367 Cleanup xmalloc.
368 * lisp.h (xzalloc): New prototype. Omit needless casts.
369 * alloc.c (xzalloc): New function. Omit needless casts.
370 * charset.c: Omit needless casts. Convert all calls to
371 xmalloc with following memset to xzalloc.
372 * dispnew.c: Likewise.
373 * fringe.c: Likewise.
374 * image.c: Likewise.
375 * sound.c: Likewise.
376 * term.c: Likewise.
377 * w32fns.c: Likewise.
378 * w32font.c: Likewise.
379 * w32term.c: Likewise.
380 * xfaces.c: Likewise.
381 * xfns.c: Likewise.
382 * xterm.c: Likewise.
383 * atimer.c: Omit needless casts.
384 * buffer.c: Likewise.
385 * callproc.c: Likewise.
386 * ccl.c: Likewise.
387 * coding.c: Likewise.
388 * composite.c: Likewise.
389 * doc.c: Likewise.
390 * doprnt.c: Likewise.
391 * editfns.c: Likewise.
392 * emacs.c: Likewise.
393 * eval.c: Likewise.
394 * filelock.c: Likewise.
395 * fns.c: Likewise.
396 * gtkutil.c: Likewise.
397 * keyboard.c: Likewise.
398 * lisp.h: Likewise.
399 * lread.c: Likewise.
400 * minibuf.c: Likewise.
401 * msdos.c: Likewise.
402 * print.c: Likewise.
403 * process.c: Likewise.
404 * region-cache.c: Likewise.
405 * search.c: Likewise.
406 * sysdep.c: Likewise.
407 * termcap.c: Likewise.
408 * terminal.c: Likewise.
409 * tparam.c: Likewise.
410 * w16select.c: Likewise.
411 * w32.c: Likewise.
412 * w32reg.c: Likewise.
413 * w32select.c: Likewise.
414 * w32uniscribe.c: Likewise.
415 * widget.c: Likewise.
416 * xdisp.c: Likewise.
417 * xmenu.c: Likewise.
418 * xrdb.c: Likewise.
419 * xselect.c: Likewise.
420
0497dc44
PE
4212012-07-05 Paul Eggert <eggert@cs.ucla.edu>
422
423 * fileio.c (time_error_value): Check the right error number.
424 Problem reported by Troels Nielsen in
425 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
426
356e7178
PE
4272012-07-04 Paul Eggert <eggert@cs.ucla.edu>
428
4e71fd89
PE
429 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
430 This should be fixed in a better way; see Eli Zaretskii in
431 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
432 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
433
f0941253
PE
434 * fileio.c (time_error_value): Rename from special_mtime.
435 The old name's problems were noted by Eli Zaretskii in
436 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
437
065c9eb4
PE
438 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
439 This variable's comment says Emacs needs at least one GDB-visible
440 symbol of type enum pvec_type, to work around GDB problems.
441 The symbol's value doesn't matter.
442
356e7178
PE
443 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
444 that causes compilation to fail on pre-C99 compilers.
445
95f61aa2
JB
4462012-07-04 Juanma Barranquero <lekktu@gmail.com>
447
448 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
449 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
450
3884d954
DA
4512012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
452
d209e2fb 453 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
454 headers for buffer_defaults and buffer_local_symbols.
455 Reported by Juanma Barranquero <lekktu@gmail.com>.
456
ee28be33
SM
4572012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
458
459 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
460 * lisp.h (enum pvec_type): Use fewer bits.
461 (PSEUDOVECTOR_SIZE_BITS): New constant.
462 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
463 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
464 change in pvec_type.
465 (PSEUDOVECTOR_TYPEP): New macro.
466 (TYPED_PSEUDOVECTORP): Use it.
467 * fns.c (internal_equal): Adapt code to extract pvectype.
468 * emacs.c (gdb_pvec_type): Update type.
469 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
470 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
471 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
472 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
473 (sweep_vectors): Use it. Use local var `total_bytes' instead of
474 abusing vector->header.next.nbytes.
475 (live_vector_p): Use PVEC_TYPE.
476 (mark_object): Adapt code to extract pvectype. Use switch.
477
c7f2cd7f
PE
4782012-07-04 Paul Eggert <eggert@cs.ucla.edu>
479
480 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
481 Tighten new eassert a bit.
482
8ce70ed2
DA
4832012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
484
485 Fix compilation with --enable-gcc-warnings and -O1
486 optimization level.
487 * doprnt.c (doprnt): Change type of tem to int, initialize
488 to avoid compiler warning. Add eassert.
489 * search.c (simple_search): Initialize match_byte to avoid
490 compiler warning. Add eassert.
491
dea7f1e5
PE
4922012-07-04 Paul Eggert <eggert@cs.ucla.edu>
493
24a212eb
PE
494 Avoid weird behavior with large horizontal scrolls.
495 Without this change, for example, large hscroll values would
496 mess up Emacs's display on Fedora 15 x86, presumably due to
497 overflows in int calculations in the display code.
498 Also, if buffers had long lines, Emacs would freeze.
499 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
500 (set_window_hscroll): New function, containing the old guts of
501 Fset_window_hscroll. Return the clipped value.
502 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
503 This avoids the need to check against PTRDIFF_MAX.
504
dea7f1e5
PE
505 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
506
76046526
DA
5072012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
508
509 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
510
39adff0d
PE
5112012-07-04 Paul Eggert <eggert@cs.ucla.edu>
512
63807d47
PE
513 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
514 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
515 since GCC 4.4.6 issues a bogus warning for them.
516
39adff0d
PE
517 Fix bugs in file timestamp newness comparisons.
518 * fileio.c (Ffile_newer_than_file_p):
519 * lread.c (Fload): Use full timestamp resolution of files,
520 not just the 1-second resolution, so that files that are only
521 slightly newer still count as newer.
522 * fileio.c (Ffile_newer_than_file_p): Don't assume file
523 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
524
dbeed9a6
PE
5252012-07-03 Paul Eggert <eggert@cs.ucla.edu>
526
527 * fileio.c: Improve handling of file time marker. (Bug#11852)
528 (special_mtime): New function.
529 (Finsert_file_contents, Fverify_visited_file_modtime):
530 Use it to set special mtime values consistently.
531
636334d6
AS
5322012-07-03 Andreas Schwab <schwab@linux-m68k.org>
533
534 * fileio.c (Finsert_file_contents): Properly handle st_mtime
535 marker for non-existing file. (Bug#11852)
536
e2017fe2
GM
5372012-07-03 Glenn Morris <rgm@gnu.org>
538
539 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
540 and did not make it into globals.h).
541
404dbd37
TT
5422012-07-03 Tom Tromey <tromey@redhat.com>
543
544 * window.c (Fset_window_margins, Fset_window_fringes)
545 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
546 * textprop.c (Fprevious_property_change): No longer static.
547 * syntax.c (Fsyntax_table_p): No longer static.
548 * process.c (Fget_process, Fprocess_datagram_address): No longer
549 static.
550 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
551 * keyboard.c (Fcommand_execute): No longer static.
552 Remove EXFUN.
553 * insdel.c (Fcombine_after_change_execute): No longer static.
554 * image.c (Finit_image_library): No longer static.
555 * fileio.c (Fmake_symbolic_link): No longer static.
556 * eval.c (Ffetch_bytecode): No longer static.
557 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
558 * doc.c (Fdocumentation_property, Fsnarf_documentation):
559 No longer static.
404dbd37
TT
560 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
561 static.
562 * dired.c (Ffile_attributes): No longer static.
563 * composite.c (Fcomposition_get_gstring): No longer static.
564 * callproc.c (Fgetenv_internal): No longer static.
565
566 * ccl.h: Remove EXFUNs.
567 * buffer.h: Remove EXFUNs.
568 * dispextern.h: Remove EXFUNs.
569 * intervals.h: Remove EXFUNs.
570 * fontset.h: Remove EXFUN.
571 * font.h: Remove EXFUNs.
572 * dosfns.c (system_process_attributes): Remove EXFUN.
573 * keymap.h: Remove EXFUNs.
574 * lisp.h: Remove EXFUNs.
575 * w32term.h: Remove EXFUNs.
576 * window.h: Remove EXFUNs.
577 * xsettings.h: Remove EXFUN.
578 * xterm.h: Remove EXFUN.
579
8e4fd1e1
GM
5802012-07-03 Glenn Morris <rgm@gnu.org>
581
582 * lisp.h (Frandom): Make it visible to C.
583 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
584 buffer for invisible buffers. (Bug#1229)
585
ca95b3eb
DA
5862012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
587
588 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
589 values which aren't power of 2.
590 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
591 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
592 accordingly.
593
7555c33f
SM
5942012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
595
596 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
597
598 * alloc.c (mark_object): Revert part of last patch to use `switch'.
599
d12e8f5a
DA
6002012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
601
602 * alloc.c (allocate_vector_block): Remove redundant
603 calls to mallopt if DOUG_LEA_MALLOC is defined.
604 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
605 avoid calls to mallopt if zero_vector is returned.
606
296094c3
DA
6072012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
608
609 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
610 is enabled, avoid dereferencing NULL current_sblock if
611 running undumped.
612
36429c89
DA
6132012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
614
615 Cleanup basic buffer management.
616 * buffer.h (struct buffer): Change layout to use generic vector
617 marking code. Fix some comments. Change type of 'clip_changed'
618 to bitfield. Remove unused #ifndef old.
619 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
620 (GET_OVERLAYS_AT): Fix indentation.
621 (for_each_per_buffer_object_at): New macro.
622 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
623 (Fbuffer_local_variables): Use it.
624 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
625 * alloc.c (allocate_buffer): Adjust to match new layout of
626 struct buffer. Fix comment.
627 (mark_overlay): New function.
628 (mark_buffer): Use it. Use mark_vectorlike to mark normal
629 Lisp area of struct buffer.
630 (mark_object): Use it. Adjust marking of misc objects
631 and related comments.
632
3b3e4cac
PE
6332012-07-02 Paul Eggert <eggert@cs.ucla.edu>
634
635 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
636 wrapper that is not needed because the wrapped code is a no-op (zero
637 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
638 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
639
cf5c0175
DA
6402012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
641
642 * alloc.c (mark_buffer): Simplify. Remove prototype.
643 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 644 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
645 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
646 redundant calls to mark_vectorlike for bool vectors.
647
ca26824c
GM
6482012-06-30 Glenn Morris <rgm@gnu.org>
649
2e4c5312
GM
650 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
651
ca26824c
GM
652 * epaths.in (PATH_SITELOADSEARCH): New.
653 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
654 This is rather than relying on --enable-locallisppath elements
655 having "site-lisp" in their names. (Bug#10208#25, 11658)
656
0d23c240
EZ
6572012-06-30 Eli Zaretskii <eliz@gnu.org>
658
c9240d7a
EZ
659 * w32proc.c (sys_select): Accept and ignore one more argument.
660
661 * w32.c (emacs_gnutls_pull): Call select with one more argument.
662
0d23c240 663 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 664 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
665
666 * sysdep.c: Don't include dos.h and dosfns.h.
667
668 * process.c (sys_select):
669 * msdos.c (sys_select): Accept one more argument and ignore it.
670
671 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
672 adapt data types and code to that.
673
674 * dosfns.c:
675 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
676 which clashes with the gnulib function of the same name.
677
af5a5a98
AS
6782012-06-30 Andreas Schwab <schwab@linux-m68k.org>
679
c5e4379c
AS
680 * font.c (font_style_to_value, font_style_symbolic)
681 (font_prop_validate_style): Add type checks for values in
682 font_style_table.
683
af5a5a98
AS
684 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
685 argument.
686 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
687 uses.
688
8d38f461
EZ
6892012-06-29 Eli Zaretskii <eliz@gnu.org>
690
2e5a6631
EZ
691 * xdisp.c (try_window_id): Undo last change.
692
8d38f461
EZ
693 * w32.c (getwd): Adjust commentary about startup_dir.
694 (init_environment): Always call sys_access, even in non-MSVC
695 builds. Don't chdir to the directory of the Emacs executable.
696 This undoes code from 1997 which was justified by the need to
697 "avoid conflicts when removing and renaming directories". But its
698 downside was that every relative file name was being interpreted
699 relative to the directory of the Emacs executable, which can never
700 be TRT. In particular, it broke sys_access when called with
701 relative file names.
702 (sys_access): Map GetLastError to errno.
703
2af3565e
DA
7042012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
705
706 * window.h (struct window): Change type of 'fringes_outside_margins'
707 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 708 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
709 Adjust comment.
710 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
711 to ptrdiff_t.
712
c8d3a25c 7132012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 714
c8d3a25c
GM
715 * gnutls.c (emacs_gnutls_handshake):
716 Add QUIT to make the loop interruptible.
57570cd3 717
c8d3a25c 7182012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 719
c8d3a25c
GM
720 * charset.c (init_charset): Make lack of etc/charsets fatal.
721
3e984ee8
DA
7222012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
723
724 * editfns.c (region_limit): Fix type mismatch.
725
ef884f23
DA
7262012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
727
728 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
729 undefined. Convert from xassert to eassert.
730 * nsmenu.m: Convert from xassert to eassert.
731 * nsterm.m: Likewise.
732
7d7e0027
SM
7332012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
734
735 * editfns.c (region_limit): Clip to narrowing (bug#11770).
736
aa754e6a
PE
7372012-06-28 Paul Eggert <eggert@cs.ucla.edu>
738
739 Avoid integer overflow on scroll-left and scroll-right.
740 * window.c (HSCROLL_MAX): New macro.
741 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
742 overflow when requested scroll falls outside ptrdiff_t range.
743
80b00b08
DA
7442012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
745
746 * window.h (struct window): Change type of 'hscroll',
747 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
748 'last_modified' and 'last_overlay_modified' to EMACS_INT.
749 Adjust users accordingly.
750 * xdisp.c (try_cursor_movement): Replace type check with eassert.
751 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
752 from EMACS_INT to ptrdiff_t.
753 (make_window): Omit redundant initialization.
754
62b2bcf6
JB
7552012-06-28 Juanma Barranquero <lekktu@gmail.com>
756
757 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
758
45942c7d
DA
7592012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
760
761 * window.h (struct window): Change type of 'use_time' and
762 'sequence_number' from Lisp_Object to int.
763 * frame.c (make_frame): Adjust users accordingly.
764 * print.c (print_object): Likewise.
765 * window.c (select_window, Fwindow_use_time, make_parent_window)
766 (make_window): Likewise.
767
e509cfa6
DA
7682012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
769
770 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
771 enabled with --enable-checking=[all,glyphs] configure option.
772 Fix GLYPH_DEBUG usage assuming that it may be undefined,
773 adjust comments accordingly.
774 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
775 undefined, adjust comments accordingly.
776 * image.c: Likewise.
777 * scroll.c: Likewise.
778 * w32fns.c: Likewise.
779 * w32term.c: Likewise.
780 * xdisp.c: Likewise.
781 * xfaces.c: Likewise.
782 * xfns.c: Likewise.
783 * xterm.c: Likewise.
784
a54e2c05
DA
7852012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
786
787 Generalize run-time debugging checks.
788 * dispextern.h (XASSERTS): Remove.
789 * fontset.c (xassert): Remove.
790 Convert from xassert to eassert.
791 * alloc.c: Convert from xassert to eassert.
792 * bidi.c: Likewise.
793 * dispnew.c: Likewise.
794 * fns.c: Likewise.
795 * fringe.c: Likewise.
796 * ftfont.c: Likewise.
797 * gtkutil.c: Likewise.
798 * image.c: Likewise.
799 * keyboard.c: Likewise.
800 * menu.c: Likewise.
801 * process.c: Likewise.
802 * scroll.c: Likewise.
803 * sound.c: Likewise.
804 * term.c: Likewise.
805 * w32console.c: Likewise.
806 * w32fns.c: Likewise.
807 * w32term.c: Likewise.
808 * window.c: Likewise.
809 * xdisp.c: Likewise.
810 * xfaces.c: Likewise.
811 * xfns.c: Likewise.
812 * xselect.c: Likewise.
813 * xterm.c: Likewise.
814
1ec4b7b2
SM
8152012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
816
817 * fns.c (maybe_resize_hash_table): Output message when growing the
818 purify-hashtable.
819
2014308a
DA
8202012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
821
822 * alloc.c (allocate_string_data): Remove dead code.
823 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
824 avoid GCC warning about unused macro.
825
246155eb
DA
8262012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
827
828 * alloc.c (allocate_string): Omit intervals initialization.
829 * alloc.c (make_uninit_multibyte_string): Initialize intervals
830 as in make_pure_string and make_pure_c_string.
831
43184b7b
DA
8322012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
833
d209e2fb 834 * alloc.c (allocate_string): Fix last change.
43184b7b 835
3fe6dd74
DA
8362012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
837
d209e2fb 838 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
839 to memset, add explicit initialization where appropriate.
840
1ba6038a
GM
8412012-06-27 Glenn Morris <rgm@gnu.org>
842
843 * lisp.mk (lisp): Remove paths.elc.
844
c89926a5
CY
8452012-06-27 Chong Yidong <cyd@gnu.org>
846
847 * doc.c (Fsubstitute_command_keys): Fix punctuation.
848
ed6b3510
JW
8492012-06-26 John Wiegley <johnw@newartisans.com>
850
1ec4b7b2 851 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
852 on Mac OS X Lion: __mod_init_func and __mod_term_func.
853
ed6b3510
JW
854 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
855 when building with Clang.
856
8edd4a2b
SM
8572012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
858
859 * eval.c (Fapply): Allow calling it with a single argument.
860
f6f62d1b
EZ
8612012-06-26 Eli Zaretskii <eliz@gnu.org>
862
863 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
864 _stricmp and _strnicmp.
865 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
866
62efea5e
DA
8672012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
868
869 * alloc.c (allocate_window): Zero out non-Lisp part of newly
870 allocated window.
871 (allocate_process): Likewise for new process.
8edd4a2b 872 (allocate_terminal): Change to use offsetof.
62efea5e
DA
873 (allocate_frame): Likewise.
874 * frame.c (make_frame): Omit redundant initialization.
875 * window.c (make_parent_window): Use memset.
876 (make_window): Omit redundant initialization.
877 * process.c (make_process): Omit redundant initialization.
878 * terminal.c (create_terminal): Likewise.
879
42997f4d
DA
8802012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
881
882 * term.c (delete_tty): Remove redundant call to memset.
883
1130ecfc
DA
8842012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
885
886 * alloc.c: Remove build_string.
887 * lisp.h: Define build_string as static inline. This provides
888 a better opportunity to optimize away calls to strlen when the
889 function is called with compile-time constant argument.
890 * image.c (imagemagick_error): Convert to build_string.
891 * w32proc.c (sys_spawnve): Likewise.
892 * xterm.c (x_term_init): Likewise.
893
cf38a720
PE
8942012-06-26 Paul Eggert <eggert@cs.ucla.edu>
895
99027bdd
PE
896 Use sprintf return value instead of invoking strlen on result.
897 In the old days this wasn't portable, since some sprintf
898 implementations returned char *. But they died out years ago and
899 Emacs already assumes sprintf returns int.
900 Similarly for float_to_string.
901 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
902 * ccl.c (ccl_driver):
903 * character.c (string_escape_byte8):
904 * data.c (Fnumber_to_string):
905 * doprnt.c (doprnt):
906 * print.c (print_object):
907 * xdisp.c (message_dolog):
908 * xfns.c (syms_of_xfns):
909 Use sprintf or float_to_string result to avoid need to call strlen.
910 * data.c (Fnumber_to_string):
911 Use make_unibyte_string, since the string must be ASCII.
912 * lisp.h, print.c (float_to_string): Now returns int length.
913 * term.c (produce_glyphless_glyph):
914 Use sprintf result rather than recomputing it.
915
cf38a720
PE
916 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
917 * Makefile.in (ALL_CFLAGS):
918 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
919 * gmalloc.c, regex.c: Include <config.h> unconditionally.
920
3511c784
DA
9212012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
922
0a08eb21 923 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
924 strcasecmp if available.
925 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
926
fb7da12e
AS
9272012-06-25 Andreas Schwab <schwab@linux-m68k.org>
928
929 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
930 Avoid comma operator.
931 * menu.c (push_submenu_start, push_submenu_end)
932 (push_left_right_boundary, push_menu_pane): Likewise.
933 * msdos.c (dos_rawgetc): Likewise.
934
afa2ffd8
DA
9352012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
936
937 * xfns.c (xic_create_fontsetname): Remove redundant calls
938 to memset.
939
b3b4476b
PE
9402012-06-25 Paul Eggert <eggert@cs.ucla.edu>
941
4495ff38
PE
942 * gtkutil.c (get_utf8_string): Remove redundant assignment.
943 sprintf already null-terminates its output.
944
b3b4476b
PE
945 * xfns.c (x_window): Remove redundant cast.
946
b00876c9
DA
9472012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
948
949 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
950 `const char *' to `char *' to avoid compiler warning.
951
d188e26b
PE
9522012-06-24 Paul Eggert <eggert@cs.ucla.edu>
953
885d1d74
PE
954 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
955 instead of truncating it to 63 (admittedly a generous limit).
956
d188e26b
PE
957 * process.c: Fix spelling and caps in comments.
958
e2f560b1
DN
9592012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
960
e86db54b 961 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
962 * sysdep.c (setpgrp): Remove definition, not used in this file.
963
7583a3a1
JB
9642012-06-24 Juanma Barranquero <lekktu@gmail.com>
965
966 * makefile.w32-in: Update dependencies.
967
696056c2
EZ
9682012-06-24 Eli Zaretskii <eliz@gnu.org>
969
970 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
971 (SYSTIME_H): Add nt/inc/sys/time.h.
972
973 * systime.h [WINDOWSNT]: Include sys/time.h.
974
975 * s/ms-w32.h (struct timespec): Definition moved from
976 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
977
845ca893
PE
9782012-06-24 Paul Eggert <eggert@cs.ucla.edu>
979
980 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
981 * buffer.h (buffer_slot_type_mismatch):
982 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
983 * eval.c (unwind_to_catch):
984 * image.c (my_png_error, my_error_exit):
985 * keyboard.c (quit_throw_to_read_char, user_error)
986 (Fexit_recursive_edit, Fabort_recursive_edit):
987 * lisp.h (die, args_out_of_range, args_out_of_range_3)
988 (wrong_type_argument, buffer_overflow, __executable_start)
989 (memory_full, buffer_memory_full, string_overflow, Fthrow)
990 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
991 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
992 (fatal):
993 (child_setup) [!DOS_NT]:
994 * lread.c (end_of_file_error, invalid_syntax):
995 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
996 * puresize.h (pure_write_error):
997 * search.c (matcher_overflow):
998 * sound.c (sound_perror, alsa_sound_perror):
999 * sysdep.c, syssignal.h (croak):
1000 * term.c (maybe_fatal, vfatal):
1001 * textprop.c (text_read_only):
1002 * undo.c (user_error):
1003 * unexmacosx.c (unexec_error):
1004 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1005 Use _Noreturn rather than NO_RETURN.
1006 No need for separate decl merely because of _Noreturn.
1007 * sound.c (sound_warning, parse_sound):
1008 Remove unnecessary forward decls.
1009
f1dd8073
PE
10102012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1011
1012 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1013 * lisp.h (WAIT_READING_MAX): New macro.
1014 * dispnew.c (Fsleep_for, sit_for):
1015 * keyboard.c (kbd_buffer_get_event):
1016 * process.c (Faccept_process_output):
1017 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1018 This improves on the previous patch, which introduced a bug
1019 when time_t is unsigned and as wide as intmax_t.
1020 See <http://bugs.gnu.org/9000#51>.
1021
b82c1755
EZ
10222012-06-23 Eli Zaretskii <eliz@gnu.org>
1023
1024 * dispnew.c (sit_for, Fsleep_for):
1025 * keyboard.c (kbd_buffer_get_event):
1026 * process.c (Faccept_process_output): Avoid compiler warnings when
1027 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1028
ca300656
JB
10292012-06-23 Juanma Barranquero <lekktu@gmail.com>
1030
049ec95b
JB
1031 * makefile.w32-in: Update dependencies.
1032
ca300656
JB
1033 * w32.c (ltime): Add return type and declare static.
1034 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1035
db7b8d06
PE
10362012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1037
1038 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1039 Privately reported by Herbert J. Skuhra.
1040 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1041 All uses changed.
1042 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1043 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1044
0bd8297f
EZ
10452012-06-23 Eli Zaretskii <eliz@gnu.org>
1046
96512555
EZ
1047 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1048 last argument of make_unibyte_string.
1049
0bd8297f
EZ
1050 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1051 language ID in the event parameters.
1052
1053 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1054 event.code, not the obscure "character set ID".
1055
63def6b6
CY
10562012-06-23 Chong Yidong <cyd@gnu.org>
1057
1058 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1059
e8a02204
EZ
10602012-06-23 Eli Zaretskii <eliz@gnu.org>
1061
388cdec0
EZ
1062 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1063 * w32.c (fdutimens): New function.
1064
1065 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1066
1067 * s/ms-w32.h (pselect): Redirect to sys_select.
1068
1069 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1070
e8a02204
EZ
1071 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1072 in the logic of incrementing and decrementing the value of
1073 use_relocatable_buffers.
1074
d054f3fb
PE
10752012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1076
1077 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1078 Privately reported by Herbert J. Skuhra.
1079 [__FreeBSD__]: Remove "*/" typo after "#include".
1080 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1081 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1082 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1083 Don't assume EMACS_TIME and struct timeval are the same type.
1084
d35af63c
PE
10852012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1086
1087 Support higher-resolution time stamps (Bug#9000).
1088 The time stamps are only nanosecond-resolution at the C level,
1089 since that's the best that any real-world system supports now.
1090 But they are picosecond-resolution at the Lisp level, as that's
1091 easy, and leaves room for future OS improvements.
1092
1093 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1094 (LIBES): Use it.
1095
1096 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1097 Don't get current time unless it's needed.
1098
1099 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1100 now provides it if it's absent.
1101 (start_atimer): Port to higher-res time stamps.
1102 Check for time stamp overflow. Don't get current time more
1103 often than is needed.
1104
1105 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1106 Include systime.h, not time.h.
1107 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1108
1109 * dired.c: Include stat-time.h.
1110 (Ffile-attributes): File times now have higher resolution.
1111
1112 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1113 (struct image): Timestamp now has higher resolution.
1114
1115 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1116 has at least microseconds now. All uses removed.
1117 (update_frame, update_single_window, update_window, update_frame_1)
1118 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1119
1120 * editfns.c (time_overflow): Now extern.
1121 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1122 (float-time, Fformat_time_string, Fcurrent_time_string)
1123 (Fcurrent_time_zone): Accept and generate higher-resolution
1124 time stamps.
1125 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1126 (decode_time_components, lisp_seconds_argument): New functions.
1127 (make_time): Now static.
1128 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1129 Report an error if the time is invalid, rather than having the caller
1130 do that.
1131
1132 * fileio.c: Include <stat-time.h>
1133 (Fcopy_file): Copy higher-resolution time stamps.
1134 Prefer to set the time stamp via a file descriptor if that works.
1135 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1136 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1137 (Fvisited_file_modtime, Fset_visited_file_modtime):
1138 Support higher-resolution time stamps.
1139
1140 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1141
1142 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1143
1144 * image.c (prepare_image_for_display, clear_image_cache)
1145 (lookup_image): Port to higer-resolution time stamps.
1146
1147 * keyboard.c (start_polling, bind_polling_period):
1148 Check for time stamp overflow.
1149 (read_char, kbd_buffer_get_event, timer_start_idle)
1150 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1151 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1152 Port to higher-resolution time stamps. Do not assume time_t is signed.
1153 (decode_timer): New function. Timers are now vectors of length 9,
1154 not 8, to accommodate the picosecond component.
1155 (timer_check_2): Use it.
1156
1157 * nsterm.m (select_timeout, timeval_subtract): Remove.
1158 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1159 as they're a bit more accurate and handle overflow better.
1160 (ns_select): Change prototype to be compatible with pselect.
1161 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1162 * nsterm.h (ns_select): Adjust prototype.
1163
1164 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1165 us-resolution time stamps.
1166 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1167
1168 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1169
1170 * lisp.h (time_overflow): New decl.
1171 (wait_reading_process_output): First arg is now intmax_t, not int,
1172 to accommodate larger waits.
1173
1174 * process.h (struct Lisp_Process.read_output_delay):
1175 Now counts nanoseconds, not microseconds.
1176 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1177 EMACS_HAS_USECS.
1178 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1179 (wait_reading_process_output):
1180 Port to ns-resolution time stamps.
1181 (Faccept_process_output, wait_reading_process_output):
1182 Check for time stamp overflow. Do not assume time_t is signed.
1183 (select_wrapper): Remove; we now use pselect.
1184 (Fprocess_attributes): Now generates ns-resolution time stamps.
1185
1186 * sysdep.c: Include utimens.h. Don't include utime.h
1187 or worry about struct utimbuf; gnulib does that for us now.
1188 (gettimeofday): Remove; gnulib provides a substitute.
1189 (make_timeval): New function.
1190 (set_file_times): Now sets ns-resolution time stamps.
1191 New arg FD; all uses changed.
1192 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1193 (system_process_attributes):
1194 Now returns ns-resolution time stamp. All uses changed.
1195 Check for time stamp overflow.
1196
1197 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1198 provides a substitute now.
1199
1200 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1201 since it guarantees struct timespec.
1202 (EMACS_TIME): Now struct timespec, so that we can support
1203 ns-resolution time stamps.
1204 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1205 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1206 (EMACS_USECS): Remove.
1207 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1208 so multiply the arg by 1000 before storing it.
1209 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1210 New macros.
1211 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1212 Port to ns-resolution time stamps.
1213 (EMACS_TIME_NEG_P): Remove; replaced by....
1214 (EMACS_TIME_SIGN): New macro.
1215 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1216 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1217 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1218 (make_timeval, make_lisp_time, decode_time_components): New decls.
1219 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1220 that it mishandled time_t overflow. You can't compare by subtracting!
1221 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1222 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1223
1224 * term.c: Include <sys/time.h>.
1225 (timeval_to_Time): New function, for proper overflow wraparound.
1226 (term_mouse_position, term_mouse_click): Use it.
1227
1228 * undo.c (record_first_change): Support higher-resolution time stamps
1229 in the undo buffer.
1230 (Fprimitive_undo): Use them when restoring time stamps.
1231
1232 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1233 (w32_get_internal_run_time):
1234 Port to higher-resolution Emacs time stamps.
1235 (ltime): Now accepts single 64-bit integer, as that's more convenient
1236 for callers.
1237
1238 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1239
1240 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1241 for compatibility with pselect. Support ns-resolution time stamps.
1242
1243 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1244
1245 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1246 Check for time stamp overflow, and support ns-resolution time stamps.
1247
1248 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1249 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1250 (timeval_subtract): Remove; no longer needed.
1251 (XTflash, XTring_bell, x_wait_for_event):
1252 Port to ns-resolution time stamps. Don't assume time_t is signed.
1253
b6a92dfe
CY
12542012-06-22 Chong Yidong <cyd@gnu.org>
1255
1256 * xdisp.c (x_consider_frame_title): Revert last change.
1257
d251c37c
EZ
12582012-06-22 Eli Zaretskii <eliz@gnu.org>
1259
1260 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1261 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1262 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1263 staticidx goes up to 1597 out of 1600 = 0x640.)
1264
f10deafb
PE
12652012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1266
1267 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1268 Otherwise, the umask might be mistakenly 0 while handling input signals.
1269
ec6de1e2
SM
12702012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1271
1272 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1273
28be1ada
DA
12742012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1275
1276 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1277 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1278 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1279 access to `contents' member of Lisp_Vector objects with AREF and ASET
1280 where appropriate.
1281
c6bf3022
CY
12822012-06-19 Chong Yidong <cyd@gnu.org>
1283
1284 * frame.c (delete_frame): When selecting a frame on a different
1285 text terminal, do not alter the terminal's top-frame.
1286
1287 * xdisp.c (format_mode_line_unwind_data): Record the target
1288 frame's selected window and its terminal's top-frame.
1289 (unwind_format_mode_line): Restore them.
1290 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1291 Callers changed.
1292 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1293 since tty frames can be explicitly named.
1294 (prepare_menu_bars): Likewise.
1295
1296 * term.c (Ftty_top_frame): New function.
1297
defd4196
PE
12982012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1299
1300 Port byte-code-meter to modern targets.
1301 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1302 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1303 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1304 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1305 (METER_1, METER_2): Simplify.
1306
1053a871
SM
13072012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1308
1309 * data.c (Fdefalias): Return `symbol' (bug#11686).
1310
b7e8d081
MR
13112012-06-18 Martin Rudalics <rudalics@gmx.at>
1312
1313 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1314 gets killed during executing of this function (Bug#11665).
1315 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1316 (Vkill_buffer_query_functions): In doc-string say that functions
1317 run by this hook should not change the current buffer.
1318
7ea2b339
PE
13192012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1320
1321 Fix recently-introduced process.c problems found by static checking.
1322 * process.c (write_queue_push, write_queue_pop, send_process):
1323 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1324 (write_queue_pop): Fix pointer signedness problem.
1325 (send_process): Remove unused local.
1326
96a313a1
CY
13272012-06-17 Chong Yidong <cyd@gnu.org>
1328
1329 * xdisp.c (redisplay_internal): No need to redisplay terminal
1330 frames that are not on top.
1331
20ca2e94
TN
13322012-06-17 Troels Nielsen <bn.troels@gmail.com>
1333
1334 * process.c (make_process): Initialize write_queue.
1335 (write_queue_push, write_queue_pop): New functions.
1336 (send_process): Use them to maintain correct ordering of process
1337 writes (Bug#10815).
1338
9a900ca9
PE
13392012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1340
310fbfa8
PE
1341 * lisp.h (eassert): Assume C89 or later.
1342 This removes the need for CHECK.
1343 (CHECK): Remove. Its comments about always evaluating its
1344 argument were confusing, as 'eassert' typically does not evaluate
1345 its argument.
1346
27bb1ca4
PE
1347 * coding.c (produce_chars): Use ptrdiff_t, not int.
1348
9a900ca9
PE
1349 * xterm.c (x_draw_underwave): Check for integer overflow.
1350 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1351
41b7f8bc 13522012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1353
1354 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1355 referenced (Bug#11583).
1356
9b0e3eba
AA
13572012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1358
1359 Implement wave-style variant of underlining.
1360 * dispextern.h (face_underline_type): New enum.
1361 (face): Add field for underline type.
1362 * nsterm.m (ns_draw_underwave): New function.
1363 (ns_draw_text_decoration): Use it.
1364 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1365 New functions.
1366 (x_draw_glyph_string): Use them.
1367 * xfaces.c (Qline, Qwave): New Lisp objects.
1368 (check_lface_attrs, merge_face_ref)
1053a871
SM
1369 (Finternal_set_lisp_face_attribute, realize_x_face):
1370 Handle wave-style underline face attributes.
9b0e3eba
AA
1371 * xterm.c (x_draw_underwave): New function.
1372 (x_draw_glyph_string): Use it.
1373
0fb52f11
JB
13742012-06-16 Juanma Barranquero <lekktu@gmail.com>
1375
1376 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1377 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1378 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1379 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1380 ($(BLD)/w32select.$(O)): Update dependencies.
1381
e5560ff7
AS
13822012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1383
1384 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1385 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1386 * character.c (_fetch_multibyte_char_p): Remove.
1387 * alloc.c: Include "character.h" before "buffer.h".
1388 * bidi.c: Likewise.
1389 * buffer.c: Likewise.
1390 * bytecode.c: Likewise.
1391 * callint.c: Likewise.
1392 * callproc.c: Likewise.
1393 * casefiddle.c: Likewise.
1394 * casetab.c: Likewise.
1395 * category.c: Likewise.
1396 * cmds.c: Likewise.
1397 * coding.c: Likewise.
1398 * composite.c: Likewise.
1399 * dired.c: Likewise.
1400 * dispnew.c: Likewise.
1401 * doc.c: Likewise.
1402 * dosfns.c: Likewise.
1403 * editfns.c: Likewise.
1404 * emacs.c: Likewise.
1405 * fileio.c: Likewise.
1406 * filelock.c: Likewise.
1407 * font.c: Likewise.
1408 * fontset.c: Likewise.
1409 * fringe.c: Likewise.
1410 * indent.c: Likewise.
1411 * insdel.c: Likewise.
1412 * intervals.c: Likewise.
1413 * keyboard.c: Likewise.
1414 * keymap.c: Likewise.
1415 * lread.c: Likewise.
1416 * macros.c: Likewise.
1417 * marker.c: Likewise.
1418 * minibuf.c: Likewise.
1419 * nsfns.m: Likewise.
1420 * nsmenu.m: Likewise.
1421 * print.c: Likewise.
1422 * process.c: Likewise.
1423 * regex.c: Likewise.
1424 * region-cache.c: Likewise.
1425 * search.c: Likewise.
1426 * syntax.c: Likewise.
1427 * term.c: Likewise.
1428 * textprop.c: Likewise.
1429 * undo.c: Likewise.
1430 * unexsol.c: Likewise.
1431 * w16select.c: Likewise.
1432 * w32fns.c: Likewise.
1433 * w32menu.c: Likewise.
1434 * window.c: Likewise.
1435 * xdisp.c: Likewise.
1436 * xfns.c: Likewise.
1437 * xmenu.c: Likewise.
1438 * xml.c: Likewise.
1439 * xselect.c: Likewise.
1440
2f07e6af
EZ
14412012-06-16 Eli Zaretskii <eliz@gnu.org>
1442
1053a871
SM
1443 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1444 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1445 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1446 row.
1447 (handle_face_prop): Use chunk-relative overlay string index when
1448 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1449 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1450 the rightmost. (Bug#11720)
2f07e6af 1451
29b83cec
AS
14522012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1453
1454 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1455 (CATEGORY_MEMBER): Enforce 1/0 value.
1456 * category.c (_temp_category_set): Remove.
1457
4c5501e9
EZ
14582012-06-16 Eli Zaretskii <eliz@gnu.org>
1459
1460 * window.c (Fdelete_other_windows_internal)
1461 (Fdelete_window_internal): Don't access frame's mouse highlight
1462 info of the initial frame. (Bug#11677)
1463
2b570124
PE
14642012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1465
e93864f9
PE
1466 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1467 Assume USE_2_TAGS_FOR_INTS.
1468 (xreload): Adjust $tagmask width to match recent lisp.h change.
1469
2b570124
PE
1470 Simplify lisp.h in minor ways that should not affect code.
1471 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1472 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1473 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1474 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1475 (INTTYPEBITS): New macro, for clarity.
1476 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1477 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1478 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1479 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1480 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1481
81755f69
JB
14822012-06-13 Juanma Barranquero <lekktu@gmail.com>
1483
1484 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1485
16192a57
GM
14862012-06-13 Glenn Morris <rgm@gnu.org>
1487
1488 * s/bsd-common.h (BSD4_3):
1489 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1490
646b5f55
AS
14912012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1492
1493 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1494 instead of union.
1495 (XLI, XIL): Define.
1053a871
SM
1496 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1497 Use them.
1498 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1499 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1500 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1501 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1502 * frame.c (delete_frame): Remove outdated comment.
1503 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1504 USE_LISP_UNION_TYPE.
1505 (Fw32_unregister_hot_key): Likewise.
1506 (Fw32_toggle_lock_key): Likewise.
1507 * w32menu.c (add_menu_item): Likewise.
1508 (w32_menu_display_help): Use XIL instead of checking
1509 USE_LISP_UNION_TYPE.
1510 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1511 (init_heap): Likewise.
1512 * w32term.c (w32_read_socket): Update comment.
1513
1d3823c9
GM
15142012-06-13 Glenn Morris <rgm@gnu.org>
1515
c62ff706
GM
1516 * s/usg5-4-common.h, src/s/unixware.h:
1517 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1518
1d3823c9
GM
1519 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1520
bfe3e0a2
PE
15212012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1522
1523 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1524 * alloc.c (make_number) [!defined make_number]:
1525 Remove, as lisp.h always defines this now.
1526 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1527 (roundup_size): Verify that it is a power of 2.
1528 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1529 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1530 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1531 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1532 USE_LSB_TAG now is always defined to be either 0 or 1.
1533 All uses changed.
1534 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1535 code works fine either way, and efficiency is not a concern here,
1536 as the union type is for debugging, not for production.
1537 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1538 Use an inline function on all platforms when using the union type,
1539 since this is simpler and 'static inline' can be used portably
1540 within Emacs now.
1541 (LISP_INITIALLY_ZERO): New macro.
1542 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1543 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1544
45fa9c0f
GM
15452012-06-12 Glenn Morris <rgm@gnu.org>
1546
b4492cba
GM
1547 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1548
1549 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1550
45fa9c0f
GM
1551 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1552 Move BROKEN_SIGIO to configure.
1553
1554 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1555 Move NO_TERMIO to configure.
1556
0e25d334
CY
15572012-06-12 Chong Yidong <cyd@gnu.org>
1558
1559 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1560 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1561 MagickExportImagePixels is undefined.
1562
43682bb6
PE
15632012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1564
1565 * image.c (imagemagick_load_image): Remove unused label.
1566
a9be7d2b
GM
15672012-06-11 Glenn Morris <rgm@gnu.org>
1568
1569 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1570 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1571 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1572 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1573
3017f87f
SM
15742012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1575
1576 * alloc.c (make_byte_code): New function.
1577 (Fmake_byte_code): Use it. Don't purify here.
1578 * lread.c (read1): Use it as well to avoid extra allocation.
1579
1b9b4cf4
CY
15802012-06-11 Chong Yidong <cyd@gnu.org>
1581
1582 * image.c (imagemagick_load_image): Implement transparency.
1583
95988fcf
AS
15842012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1585
1586 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1587 account for preceding backslashes. (Bug#11663)
1588
cd4eb164
CY
15892012-06-09 Chong Yidong <cyd@gnu.org>
1590
1591 * term.c: Support italics in capable terminals (Bug#9652).
1592 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1593 (turn_on_face): Output using TS_enter_italic_mode if available.
1594 Don't handle unused blinking and alt-charset cases.
1595 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1596 and tty_alt_charset_p cases.
1597 (tty_capable_p, init_tty): Support italics.
1598
1599 * termchar.h (struct tty_display_info): Add field for italics.
1600 Remove unused blink field.
1601
1602 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1603 Handle slant.
1604
1605 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1606 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1607 tty_alt_charset_p. Add tty_italic_p.
1608
ff88beb8
MA
16092012-06-09 Michael Albinus <michael.albinus@gmx.de>
1610
1611 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1612 dbus_type_is_basic if available.
1613 (xd_extract_signed, xd_extract_unsigned): Rename from
1614 extract_signed and extract_unsigned, respectively. Adapt callers.
1615
44286096
CY
16162012-06-09 Chong Yidong <cyd@gnu.org>
1617
1682701f
CY
1618 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1619
44286096
CY
1620 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1621 case (Bug#9752).
1622
d86feb17
PE
16232012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1624
1625 * xdisp.c (vmessage): Treat frame message as multibyte.
1626 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1627 would generate the diagnostic "Making \302\247 buffer-local while
1628 let-bound!".
1629
d5c20fe8
EZ
16302012-06-08 Eli Zaretskii <eliz@gnu.org>
1631
1632 * dispnew.c (showing_window_margins_p): Undo last change, which
1633 was done due to an inadvertent commit.
1634 (adjust_frame_glyphs_for_frame_redisplay): Do call
1635 showing_window_margins_p.
1636
513749ee
SM
16372012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1638
1639 * eval.c (Fmake_var_non_special): New primitive.
1640 (syms_of_eval): Defsubr it.
1641 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1642
d4a8f5c1
JB
16432012-06-08 Juanma Barranquero <lekktu@gmail.com>
1644
1645 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1646 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1647
8bbbc977
EZ
16482012-06-08 Eli Zaretskii <eliz@gnu.org>
1649
1650 * alloc.c (allocate_vectorlike): Fix last change.
1651
f3372c87
DA
16522012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1653
1654 Block-based vector allocation of small vectors.
1655 * lisp.h (struct vectorlike_header): New field `nbytes',
1656 adjust comment accordingly.
1657 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1658 to denote vector blocks. Adjust users (live_vector_p,
1659 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1660 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1661 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1662 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1663 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1664 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1665 (roundup_size): New constant.
1666 (struct vector_block): New data type.
1667 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1668 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1669 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1670 (sweep_vectors): New functions.
1671 (allocate_vectorlike): Return `zero_vector' as the only vector of
1672 0 items. Allocate new vector from block if vector size is less than
1673 or equal to VBLOCK_BYTES_MAX.
1674 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1675 (init_alloc_once): Add call to init_vectors.
1676
4f18a4ed
SM
16772012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1678
1679 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1680
86f158bc
PE
16812012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1682
1683 * doprnt.c (doprnt): Truncate multibyte char correctly.
1684 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1685 would mishandle a string argument "Xc" if X was a multibyte
1686 character of length 2: it would truncate after X's first byte
1687 rather than including all of X.
1688
c5cfcbe0
CY
16892012-06-06 Chong Yidong <cyd@gnu.org>
1690
1691 * buffer.c (word_wrap): Doc fix.
1692
c05cf390
PE
16932012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1694
1695 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1696
0c3461de
GM
16972012-06-03 Glenn Morris <rgm@gnu.org>
1698
1699 * xdisp.c (tool-bar-style): Doc fix.
1700
c71232db
UM
17012012-06-03 Ulrich Müller <ulm@gentoo.org>
1702
1703 * Makefile.in (PAXCTL): Define.
1704 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1705 binary via PaX flags if the paxctl utility is available.
1706 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1707 Restore PaX flags to their default. (Bug#11398)
1708
383f7350
CY
17092012-06-03 Chong Yidong <cyd@gnu.org>
1710
1711 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1712 buffer (Bug#11226).
1713
5f2c76c6
CY
17142012-06-03 Chong Yidong <cyd@gnu.org>
1715
1716 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1717 (note_mode_line_or_margin_highlight): If there is no help echo,
1718 use mode-line-default-help-echo. Handle the case where the mouse
1719 position is past the end of the mode line string.
1720
1721 * buffer.c (buffer_local_value_1): New function, split from
1722 Fbuffer_local_value; can return Qunbound.
1723 (Fbuffer_local_value): Use it.
1724 (Vmode_line_format): Docstring tweaks.
1725
773d47f6
PE
17262012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1727
1728 * sysdep.c (system_process_attributes): Improve comment.
1729
f2d6a3df
SM
17302012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1731
1732 * keyboard.c: Export real-this-command to Elisp.
1733 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1734 and DEFVAR it. Update all users.
1735
63810350
PE
17362012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1737
7bd5c1f4
PE
1738 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1739
63810350
PE
1740 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1741 Convert pctcpu and pctmem to Lisp float properly.
1742 Let the compiler fold better, as 100.0/0x8000 is exact.
1743
a2821611
AS
17442012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1745
1746 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1747 cons_block.
1748
5fceba1d
PE
17492012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1750
1751 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1752
c98ff5dd
DA
17532012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1754
1755 For a 'struct window', replace some Lisp_Object fields to
1756 bitfields where appropriate, remove unused fields.
1757 * window.h (struct window): Remove unused 'last_mark_x' and
1758 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1759 change it's type from Lisp_Object to bitfield.
1760 Change type of 'force_start', 'optional_new_start',
1761 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1762 fields from Lisp_Object to bitfield. Adjust users accordingly.
1763
ca34e0be
PE
17642012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1765
1766 Pacify gcc -Wdouble-precision when using Xaw.
1767 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1768 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1769 Use 'float' consistently, rather than 'float' in most places
1770 and 'double' in a couple of places.
1771
efc00ab1 17722012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1773
1774 * xdisp.c (handle_stop): Detect whether we have overlay strings
1775 loaded by testing it->current.overlay_string_index to be
1776 non-negative, instead of checking whether n_overlay_strings is
1777 positive. (Bug#11587)
1778
efc00ab1 17792012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1780
1781 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1782
1783 * doc.c (Fsubstitute_command_keys): Doc fix.
1784
efc00ab1 17852012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1786
1787 * search.c (search_buffer): Remove calls to
1788 r_alloc_inhibit_buffer_relocation, as it is now called by
1789 maybe_unify_char, which was the cause of relocation of buffer text
1790 in bug#11519.
1791
efc00ab1 17922012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1793
1794 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1795 for the duration of call to load_charset, to avoid problems with
1796 callers of maybe_unify_char that access buffer text through C
1797 pointers.
1798
1799 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1800 decrement the inhibition flag, instead of just setting or
1801 resetting it.
1802
ba93a187
PE
18032012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1804
1805 Remove obsolete '#define static' cruft.
1806 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1807 This #undef was "temporary" in 2000; it is no longer needed
1808 now that '#define static' has gone away.
1809 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1810 (gray_bitmap_bits): Remove; no longer needed.
1811 All uses replaced with definiens.
1812 * xterm.c: Include "bitmaps/gray.xbm".
1813
9e4bf381
PE
18142012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1815
1816 Clean up __executable_start, monstartup when --enable-profiling.
1817 The following changes affect the code only when profiling.
1818 * dispnew.c (__executable_start): Rename from safe_bcopy.
1819 Define only on platforms that need it.
1820 * emacs.c: Include <sys/gmon.h> when profiling.
1821 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1822 (__executable_start): Remove decl, since lisp.h does it now.
1823 (safe_bcopy): Remove decl; no longer has that name.
1824 (main): Coalesce #if into single bit of code, for simplicity.
1825 Cast pointers to uintptr_t, since standard libraries want integers
1826 and not pointers.
1827 * lisp.h (__executable_start): New decl.
1828
32d72c2f
GM
18292012-05-31 Glenn Morris <rgm@gnu.org>
1830
1831 * image.c (Fimagemagick_types): Doc fix.
1832
baac5bc7
JM
18332012-05-30 Jim Meyering <meyering@redhat.com>
1834
1835 * callproc.c (Fcall_process_region): Include directory component
1836 in mkstemp error message (Bug#11586).
1837
72cb32cf
PE
18382012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1839
1840 * alloc.c, lisp.h (make_pure_vector): Now static.
1841
61b108cc
SM
18422012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1843
1844 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1845 Move to byte-run.el.
1846 (Fautoload): Do the hash-doc more carefully.
1847 * data.c (Fdefalias): Purify definition, except for keymaps.
1848 (Qdefun): Move from eval.c.
1849 * lisp.h (Qdefun): Remove.
1850 * lread.c (read1): Tiny simplification.
1851
471fe23d
TN
18522012-05-29 Troels Nielsen <bn.troels@gmail.com>
1853
934f3f58 1854 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1855 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1856 Bug#9642, but explicitly check that the buffer the overlay would
1857 be moved to is live and rearrange lines to make sure that errors
1858 will not put the overlay in an inconsistent state.
1859 (Fdelete_overlay): Cosmetics.
1860
85d0efd1
EZ
18612012-05-28 Eli Zaretskii <eliz@gnu.org>
1862
1863 * w32term.c (my_bring_window_to_top): New function.
1864 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1865 could be different from the original one.
1866 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1867 (Bug#11513)
1868
1869 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1870 by calling BringWindowToTop.
1871
1872 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1873 (WM_EMACS_END): Increase by one.
1874
da92a98c
PE
18752012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1876
1877 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1878 This avoids undefined behavior that might cause the eassert
1879 to not catch an out-of-range value.
1880
74d1f848
JB
18812012-05-28 Juanma Barranquero <lekktu@gmail.com>
1882
1883 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1884 Update dependencies.
1885
9e1a06fc
EZ
18862012-05-27 Eli Zaretskii <eliz@gnu.org>
1887
1888 * bidi.c (bidi_mirror_char): Fix last change.
1889
f3dd7312
AS
18902012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1891
1892 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1893 when referring to sectname field in printf format.
1894
81899c91
PE
18952012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1896
57b81a9f
PE
1897 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1898 Only r_alloc_inhibit_buffer_relocation needed to be added;
1899 the others were already declared.
1900
81899c91
PE
1901 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1902 before checking whether it's out of range. Put the check inside
1903 eassert. See
1904 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1905
33017faf 19062012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1907
1908 * callproc.c (Fcall_process): Restore a line that was accidentally
1909 commented out in the 2011-02-13 change (bug#11547).
1910
33017faf 19112012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1912
1913 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1914 defined on ralloc.c.
1915
1916 * buffer.c [REL_ALLOC]: Remove prototypes of
1917 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1918 they are now on lisp.h.
1919
1920 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1921
1922 * search.c (search_buffer): Use it to inhibit relocation of buffer
1923 text while re_search_2 is doing its job, because re_search_2 is
1924 passed C pointers to buffer text. (Bug#11519)
1925
23415acf
EZ
1926 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1927 Update value to 24.
1928
44e27368
EZ
1929 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1930 state after an additional call to move_it_in_display_line_to, keep
1931 the values of it->max_ascent and it->max_descent found for the
1932 entire line.
1933 (pos_visible_p): Revert the comparison against bottom_y to what it
1934 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1935 (Bug#11464)
1936
c1892f11
PE
19372012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1938
1939 Fix coding-related core dumps with gcc -ftrapv.
1940 The code was computing A - B, where A and B are pointers, and B is
1941 random garbage. This can lead to core dumps on platforms that
1942 have special pointer registers, and it also leads to core dumps on
1943 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1944 A - B only when B is initialized properly.
1945 * coding.c (coding_set_source, coding_set_destination): Return void.
1946 (coding_change_source, coding_change_destinations): New functions,
1947 with the old behaviors of coding_set_source and coding_set_destination.
1948 All callers that need an offset changed to use these new functions.
1949
eb7afdad
GM
19502012-05-26 Glenn Morris <rgm@gnu.org>
1951
1952 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1953
f12fdf02
EZ
19542012-05-26 Eli Zaretskii <eliz@gnu.org>
1955
53a63be6 1956 Extend mouse support on W32 text-mode console.
61b108cc
SM
1957 * xdisp.c (draw_row_with_mouse_face):
1958 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1959
eb3f6f01 1960 * w32console.c: Include window.h.
61b108cc
SM
1961 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1962 New functions.
eb3f6f01
EZ
1963 (initialize_w32_display): Initialize mouse-highlight data.
1964
53a63be6
EZ
1965 * w32inevt.c: Include termchar.h and window.h.
1966 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1967 moves, call note_mouse_highlight. If help_echo changed, call
1968 gen_help_event to produce help-echo message in the echo area.
1969 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1970 highlight info.
1971
4cfd81f6
PE
19722012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1973
1974 * lread.c (read1): Simplify slightly to avoid an overflow warning
1975 with GCC 4.7.0 on x86-64.
1976
4446092a
EZ
19772012-05-26 Eli Zaretskii <eliz@gnu.org>
1978
1979 * bidi.c (bidi_mirror_char): Revert last change: an int is
1980 definitely wide enough here.
1981
42b2a986 19822012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1983
42b2a986 1984 Fix integer width and related bugs (Bug#9874).
eb106a49 1985 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1986 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1987 (string_bytes, check_sblock, allocate_string_data):
1988 (compact_small_strings, Fmake_bool_vector, make_string)
1989 (make_unibyte_string, make_multibyte_string)
1990 (make_string_from_bytes, make_specified_string)
1991 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1992 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1993 (mark_vectorlike):
1994 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1995 (allocate_pseudovector):
1996 Use int, not EMACS_INT, where int is wide enough.
1997 (inhibit_garbage_collection, Fgarbage_collect):
1998 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1999 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2000 int might not be wide enough.
2001 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2002 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2003 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2004 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2005 (bidi_level_of_next_char, bidi_move_to_visually_next):
2006 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2007 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2008 (Fkill_buffer, Fset_buffer_major_mode)
2009 (advance_to_char_boundary, Fbuffer_swap_text)
2010 (Fset_buffer_multibyte, overlays_at, overlays_in)
2011 (overlay_touches_p, struct sortvec, record_overlay_string)
2012 (overlay_strings, recenter_overlay_lists)
2013 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2014 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2015 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2016 (Foverlay_recenter, last_overlay_modification_hooks_used)
2017 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2018 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2019 (validate_region): Omit unnecessary test for b <= e,
2020 since that's guaranteed by the previous test.
d311d28c
PE
2021 (adjust_overlays_for_delete): Avoid pos + length overflow.
2022 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2023 (report_overlay_modification):
2024 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2025 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2026 Omit pointer cast, which isn't needed anyway, and doesn't work
2027 after the EMACS_INT -> ptrdiff_t change.
02481186 2028 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2029 * buffer.h: Adjust decls to match defn changes elsewhere.
2030 (struct buffer_text, struct buffer):
2031 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2032 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2033 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2034 not int, to avoid needless 32-bit limit on 64-bit hosts.
2035 (exec_byte_code): Use tighter memory-full test, one that checks
2036 for alloca overflow. Don't compute the address of the object just
2037 before an array, as that's not portable. Use EMACS_INT, not
2038 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2039 * callint.c (Fcall_interactively):
2040 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2041 * callproc.c (call_process_kill, Fcall_process):
2042 Don't assume pid_t fits into an Emacs fixnum.
2043 (call_process_cleanup, Fcall_process, child_setup):
2044 Don't assume pid_t fits into int.
2045 (call_process_cleanup, Fcall_process, delete_temp_file)
2046 (Fcall_process_region):
2047 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2048 (Fcall_process): Simplify handling of volatile integers.
2049 Use int, not EMACS_INT, where int will do.
2050 * casefiddle.c (casify_object, casify_region, operate_on_word)
2051 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2052 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2053 (casify_object): Avoid integer overflow when overallocating buffer.
2054 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2055 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2056 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2057 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2058 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2059 integers are now checked earlier. All uses replaced with XINT.
2060 (ccl_driver):
2061 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2062 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2063 (ccl_driver, Fregister_code_conversion_map):
2064 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2065 (resolve_symbol_ccl_program): Check that vector header is in range.
2066 Always copy the vector, so that we can check its contents reliably
2067 now rather than having to recheck each instruction as it's being
2068 executed. Check that vector words fit in 'int'.
2069 (ccl_get_compiled_code, Fregister_ccl_program)
2070 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2071 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2072 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2073 contents are in range.
2074 (Fccl_execute_on_string): Check that status is in range.
2075 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2076 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2077 Accept and return EMACS_INT, not int, because callers can pass values
2078 out of 'int' range.
2079 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2080 (multibyte_chars_in_text, parse_str_as_multibyte)
2081 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2082 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2083 (string_escape_byte8, Fget_byte):
2084 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2085 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2086 avoid mishandling large integers.
2087 * character.h: Adjust decls to match defn changes elsewhere.
2088 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2089 (Ffind_charset_region):
2090 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2091 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2092 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2093 Don't assume fixnum fits in int.
d311d28c
PE
2094 (load_charset_map_from_vector, Fmap_charset_chars):
2095 Remove now-unnecessary CHECK_NATNUMs.
2096 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2097 Don't rely on undefined behavior with signed left shift overflow.
2098 Don't assume unsigned int fits into fixnum, or that fixnum fits
2099 into unsigned int. Don't require max_code to be a valid fixnum;
2100 that's not true for gb10830 4-byte on a 32-bit host. Allow
2101 invalid_code to be a cons, for the same reason. Require code_offset
2102 to be a character. Avoid int overflow if max_char is close
2103 to INT_MAX.
2104 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2105 this is intended anyway and avoids some undefined behavior.
2106 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2107 INDEX_TO_CODE_POINT, as that's what it expects.
2108 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2109 * charset.h (DECODE_CHAR): Return int, not unsigned;
2110 this is what was intended anyway, and it avoids undefined behavior.
2111 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2112 integer-overflow issues.
2113 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2114 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2115 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2116 * chartab.c (Fmake_char_table, Fset_char_table_range)
2117 (uniprop_get_decoder, uniprop_get_encoder):
2118 Don't assume fixnum fits in int.
2119 * cmds.c (move_point): New function, that does the gist of
2120 Fforward_char and Fbackward_char, but does so while checking
2121 for integer overflow more accurately.
c96e5d6a 2122 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2123 (Fforward_line, Fend_of_line, internal_self_insert)
2124 (internal_self_insert):
2125 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2126 Fix a FIXME, by checking for integer overflow when calculating
2127 target_clm and actual_clm.
2128 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2129 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2130 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2131 (coding_alloc_by_making_gap, alloc_destination)
2132 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2133 (encode_coding_utf_16, detect_coding_emacs_mule)
2134 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2135 (detect_coding_iso_2022, decode_coding_iso_2022)
2136 (encode_invocation_designation, encode_designation_at_bol)
2137 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2138 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2139 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2140 (encode_coding_ccl, encode_coding_raw_text)
2141 (detect_coding_charset, decode_coding_charset)
2142 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2143 (produce_composition, produce_charset, produce_annotation)
2144 (decode_coding, handle_composition_annotation)
2145 (handle_charset_annotation, consume_chars, decode_coding_gap)
2146 (decode_coding_object, encode_coding_object, detect_coding_system)
2147 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2148 (code_convert_region, code_convert_string)
8f50130c
PE
2149 (Fdefine_coding_system_internal)
2150 (coding_set_source, coding_set_destination):
d311d28c
PE
2151 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2152 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2153 (Fdefine_coding_system_internal):
2154 Don't assume fixnums fit in int.
2155 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2156 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2157 (Funencodable_char_position, Fcheck_coding_systems_region)
2158 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2159 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2160 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2161 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2162 Don't access memory outside of the args array.
d311d28c 2163 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2164 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2165 result of ENCODE_CHAR.
d311d28c
PE
2166 * coding.h: Adjust decls to match defn changes elsewhere.
2167 (struct coding_system):
2168 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2169 * composite.c (get_composition_id, find_composition)
2170 (run_composition_function, update_compositions)
2171 (compose_text, composition_gstring_put_cache)
2172 (composition_gstring_p, composition_gstring_width)
2173 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2174 (composition_compute_stop_pos, composition_reseat_it)
2175 (composition_update_it, struct position_record)
2176 (find_automatic_composition, composition_adjust_point)
2177 (Fcomposition_get_gstring, Ffind_composition_internal):
2178 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2179 (update_compositions):
2180 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2181 * composite.h: Adjust decls to match defn changes elsewhere.
2182 (struct composition):
2183 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2184 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2185 Do not attempt to compute the address of the object just before a
2186 buffer; this is not portable.
2187 (Faref, Faset):
2188 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2189 (Faset): Use int, not EMACS_INT, where int is wide enough.
2190 (Fstring_to_number): Don't assume fixnums fit in int.
2191 (Frem): Don't assume arg is nonnegative.
2192 * dbusbind.c (xd_append_arg): Check for integers out of range.
2193 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2194 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2195 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2196 (xd_get_connection_references): Return ptrdiff_t, not int.
2197 All uses changed.
2198 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2199 (xd_read_message_1):
2200 Use int, not unsigned, where the dbus API uses int.
2201 (Fdbus_message_internal): Don't overflow mtype.
2202 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2203 * dired.c (directory_files_internal, file_name_completion, scmp)
2204 (file_name_completion_stat):
2205 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2206 (file_name_completion): Don't overflow matchcount.
2207 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2208 * dispextern.h: Adjust decls to match defn changes elsewhere.
2209 (struct text_pos, struct glyph, struct bidi_saved_info)
2210 (struct bidi_string_data, struct bidi_it, struct composition_it)
2211 (struct it):
2212 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2213 (struct display_pos, struct composition_it, struct it):
2214 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2215 * dispnew.c (increment_matrix_positions)
2216 (increment_row_positions, mode_line_string)
2217 (marginal_area_string):
2218 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2219 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2220 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2221 (duration_to_sec_usec): New function, to check for overflow better.
2222 (Fsleep_for, sit_for): Use it.
2223 * doc.c (get_doc_string, store_function_docstring):
2224 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2225 (get_doc_string, Fsnarf_documentation):
2226 Use int, not EMACS_INT, where int is wide enough.
2227 (get_doc_string):
2228 Use SAFE_ALLOCA, not alloca.
2229 Check for overflow when converting EMACS_INT to off_t.
2230 * doprnt.c (doprnt):
2231 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2232 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2233 Don't assume uid_t fits into fixnum.
2234 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2235 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2236 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2237 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2238 (general_insert_function)
2239 (Finsert_char, make_buffer_string, make_buffer_string_both)
2240 (update_buffer_properties, Fbuffer_substring)
2241 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2242 (Fsubst_char_in_region, check_translation)
2243 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2244 (transpose_markers, Ftranspose_regions):
2245 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2246 (clip_to_bounds): Move to lisp.h as an inline function).
2247 (Fconstrain_to_field): Don't assume integers are nonnegative.
2248 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2249 (Fsubst_char_in_region, Fsave_restriction):
2250 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2251 (Femacs_pid): Don't assume pid_t fits into fixnum.
2252 (lo_time): Use int, not EMACS_INT, when int suffices.
2253 (lisp_time_argument): Check for usec out of range.
2254 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2255 (Fuser_login_name, Fuser_full_name): Signal an error
2256 if a uid argument is out of range, rather than relying on
2257 undefined behavior.
c8d5c857
PE
2258 (Fformat_time_string): Remove now-unnecessary check.
2259 lisp_time_argument checks for out-of-range usec now.
243e0530 2260 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2261 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2262 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2263 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2264 (init_cmdargs, Fdump_emacs):
2265 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2266 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2267 the bottom (typically) 32 bits of the fixnum.
2268 * eval.c (specpdl_size, call_debugger):
2269 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2270 (when_entered_debugger, Fbacktrace_debug):
2271 Don't assume fixnum can fit in int.
2272 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2273 the object just before a buffer; this is not portable.
2274 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2275 (grow_specpdl, unbind_to):
2276 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2277 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2278 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2279 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2280 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2281 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2282 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2283 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2284 (a_write, e_write):
2285 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2286 (Fcopy_file, non_regular_nbytes, read_non_regular)
2287 (Finsert_file_contents):
2288 Use int, not EMACS_INT, where int is wide enough.
2289 (READ_BUF_SIZE): Verify that it fits in int.
2290 (Finsert_file_contents): Check that counts are in proper range,
2291 rather than assuming fixnums fit into ptrdiff_t etc.
2292 Don't assume fixnums fit into int.
125b3835 2293 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2294 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2295 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2296 (string_char_to_byte, string_byte_to_char)
2297 (string_make_multibyte, string_to_multibyte)
2298 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2299 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2300 (substring_both, Fdelete, internal_equal, Ffillarray)
2301 (Fclear_string, mapcar1)
2302 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2303 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2304 (larger_vector, make_hash_table, maybe_resize_hash_table)
2305 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2306 (Fmaphash, secure_hash):
2307 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2308 (concat): Check for string index and length overflow.
2309 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2310 (Frequire):
2311 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2312 (larger_vector): New API (vec, incr_min, size_max) replaces old
2313 one (vec, new_size, init). This catches size overflow.
2314 INIT was removed because it was always Qnil.
2315 All callers changed.
2316 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2317 the upper bound on a hash table index size.
2318 (make_hash_table, maybe_resize_hash_table): Use it.
2319 (secure_hash): Computer start_byte and end_byte only after
2320 they're known to be in ptrdiff_t range.
2321 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2322 (Ffont_get_glyphs, Ffont_at):
2323 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2324 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2325 (Flist_fonts, Fopen_font):
2326 Don't assume fixnum can fit in int.
2327 (check_gstring): Don't assume index can fit in int.
2328 (font_match_p): Check that fixnum is a character, not a nonnegative
2329 fixnum, since the later code needs to stuff it into an int.
2330 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2331 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2332 conversion overflow issues.
2333 (Fopen_font): Check for integer out of range.
2334 (Ffont_get_glyphs): Don't assume index can fit in int.
2335 * font.h: Adjust decls to match defn changes elsewhere.
2336 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2337 integer overflow.
2338 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2339 printmax_t, where ptrdiff_t is wide enough.
2340 (Finternal_char_font):
2341 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2342 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2343 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2344 (Fset_frame_position, x_set_frame_parameters)
2345 (x_set_line_spacing, x_set_border_width)
2346 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2347 Check that fixnums are in proper range for system types.
2348 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2349 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2350 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2351 Use SAFE_ALLOCA_LISP, not alloca.
2352 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2353 intptr_t is wide enough.
2354 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2355 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2356 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2357 Check for fixnum out of range.
2358 * ftfont.c (ftfont_list): Don't assume index fits in int.
2359 Check that fixnums are in proper range for system types.
2360 (ftfont_shape_by_flt):
2361 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2362 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2363 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2364 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2365 Check that fixnums are in proper range for system types.
2366 * gnutls.h: Adjust decls to match defn changes elsewhere.
2367 * gtkutil.c (xg_dialog_run):
2368 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2369 (update_frame_tool_bar):
2370 Check that fixnums are in proper range for system types.
2371 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2372 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2373 * indent.c (last_known_column, last_known_column_point):
2374 (current_column_bol_cache):
2375 (skip_invisible, current_column, check_display_width):
2376 (check_display_width, scan_for_column, current_column_1)
2377 (Findent_to, Fcurrent_indentation, position_indentation)
2378 (indented_beyond_p, Fmove_to_column, compute_motion):
2379 (Fcompute_motion, Fvertical_motion):
2380 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2381 (last_known_column_modified): Use EMACS_INT, not int.
2382 (check_display_width):
2383 (Fcompute_motion):
2384 Check that fixnums and floats are in proper range for system types.
2385 (compute_motion): Don't assume index or fixnum fits in int.
2386 (compute_motion, Fcompute_motion):
2387 Use int, not EMACS_INT, when it is wide enough.
2388 (vmotion): Omit local var start_hpos that is always 0; that way
2389 we don't need to worry about overflow in expressions involving it.
2390 * indent.h: Adjust decls to match defn changes elsewhere.
2391 (struct position):
2392 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2393 Use int, not EMACS_INT, where int is wide enough.
2394 Remove unused members ovstring_chars_done and tab_offset;
2395 all uses removed.
2396 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2397 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2398 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2399 (make_gap, copy_text, insert, insert_and_inherit)
2400 (insert_before_markers, insert_before_markers_and_inherit)
2401 (insert_1, count_combining_before, count_combining_after)
2402 (insert_1_both, insert_from_string)
2403 (insert_from_string_before_markers, insert_from_string_1)
2404 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2405 (adjust_after_replace, adjust_after_insert, replace_range)
2406 (replace_range_2, del_range, del_range_1, del_range_byte)
2407 (del_range_both, del_range_2, modify_region)
2408 (prepare_to_modify_buffer, signal_before_change)
2409 (signal_after_change, Fcombine_after_change_execute):
2410 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2411 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2412 (balance_an_interval, split_interval_right, split_interval_left)
2413 (find_interval, next_interval, update_interval)
2414 (adjust_intervals_for_insertion, delete_node, delete_interval)
2415 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2416 (static_offset_intervals, offset_intervals)
2417 (merge_interval_right, merge_interval_left, make_new_interval)
2418 (graft_intervals_into_buffer, temp_set_point_both)
2419 (temp_set_point, set_point, adjust_for_invis_intang)
2420 (set_point_both, move_if_not_intangible, get_property_and_range)
2421 (get_local_map, copy_intervals, copy_intervals_to_string)
2422 (compare_string_intervals, set_intervals_multibyte_1):
2423 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2424 * intervals.h: Adjust decls to match defn changes elsewhere.
2425 (struct interval):
2426 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2427 * keyboard.c (this_command_key_count, this_single_command_key_start)
2428 (before_command_key_count, before_command_echo_length, echo_now)
2429 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2430 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2431 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2432 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2433 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2434 (last_non_minibuf_size, last_point_position, echo_truncate)
2435 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2436 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2437 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2438 (stuff_buffered_input):
2439 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2440 (last_auto_save, command_loop_1, read_char):
2441 Use EMACS_INT, not int, to avoid integer overflow.
2442 (record_char): Avoid overflow in total_keys computation.
2443 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2444 * keyboard.h: Adjust decls to match defn changes elsewhere.
2445 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2446 (Fkey_description, Fdescribe_vector, Flookup_key):
2447 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2448 (click_position): New function, to check that positions are in range.
2449 (Fcurrent_active_maps):
2450 (describe_command):
2451 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2452 (Faccessible_keymaps, Fkey_description):
2453 (preferred_sequence_p):
2454 Don't assume fixnum can fit into int.
2455 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2456 Check for integer overflow in size calculations.
2457 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2458 avoid mishandling large integers.
2459 * lisp.h: Adjust decls to match defn changes elsewhere.
2460 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2461 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2462 (struct Lisp_Marker):
2463 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2464 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2465 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2466 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2467 All callers changed.
2468 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2469 Assume the arg has valid form, since it always does.
2470 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2471 unsigned integer system type.
2472 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2473 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2474 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2475 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2476 (duration_to_sec_usec): New decl.
2477 * lread.c (read_from_string_index, read_from_string_index_byte)
2478 (read_from_string_limit, readchar, unreadchar, openp)
2479 (read_internal_start, read1, oblookup):
2480 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2481 (Fload, readevalloop, Feval_buffer, Feval_region):
2482 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2483 (openp): Check for out-of-range argument to 'access'.
2484 (read1): Use int, not EMACS_INT, where int is wide enough.
2485 Don't assume fixnum fits into int.
6efdadfd 2486 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2487 (read_filtered_event): Use duration_to_sec_usec
2488 to do proper overflow checking on durations.
d311d28c
PE
2489 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2490 in size calculation.
2491 (Fexecute_kbd_macro):
2492 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2493 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2494 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2495 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2496 (set_marker_both, set_marker_restricted_both, marker_position)
2497 (marker_byte_position, Fbuffer_has_markers_at):
2498 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2499 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2500 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2501 It now merely ensures that the menu is large enough, without
2502 necessarily growing it, as this avoids some integer overflow issues.
2503 All callers changed.
2504 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2505 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2506 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2507 Use SAFE_ALLOCA_LISP, not alloca.
2508 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2509 to EMACS_INT. Check that fixnums are in proper range for system types.
2510 * minibuf.c (minibuf_prompt_width, string_to_object)
2511 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2512 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2513 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2514 (get_minibuffer, read_minibuf_unwind):
2515 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2516 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2517 this simplifies overflow checking. All callers changed.
2518 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2519 (Ftest_completion):
2520 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2521 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2522 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2523 Check that fixnums are in proper range for system types.
2524 (Fx_create_frame, Fx_show_tip):
2525 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2526 * nsfont.m (ns_findfonts, nsfont_list_family):
2527 Don't assume fixnum fits in long.
2528 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2529 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2530 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2531 wide enough.
17fdb222 2532 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2533 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2534 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2535 (PRINTDECLARE, PRINTPREPARE):
2536 (strout, print_string):
2537 (print, print_preprocess, print_check_string_charset_prop)
2538 (print_object):
2539 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2540 (PRINTDECLARE):
2541 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2542 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2543 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2544 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2545 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2546 (print_error_message): Use SAFE_ALLOCA, not alloca.
2547 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2548 (print_depth, new_backquote_output, print_number_index):
2549 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2550 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2551 (Fset_process_window_size, Fformat_network_address)
2552 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2553 (sigchld_handler):
d311d28c 2554 Check that fixnums are in proper range for system types.
d44287d4 2555 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2556 Check for process-ids out of pid_t range rather than relying on
2557 undefined behavior.
e4d81efc 2558 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2559 (Fformat_network_address, read_process_output, send_process)
2560 (Fprocess_send_region, status_notify):
2561 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2562 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2563 (wait_reading_process_output, read_process_output, exec_sentinel):
2564 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2565 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2566 (Faccept_process_output): Use duration_to_sec_usec to do proper
2567 overflow checking on durations.
dde14581
PE
2568 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2569 Don't assume pid_t fits in int.
02481186
PE
2570 * process.h (struct Lisp_Process): Members tick and update_tick
2571 are now of type EMACS_INT, not int.
b62b53e8
PE
2572 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2573 configured --with-wide-int.
d311d28c
PE
2574 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2575 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2576 * search.c (looking_at_1, string_match_1):
2577 (fast_string_match, fast_c_string_match_ignore_case)
2578 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2579 (scan_newline, find_before_next_newline, search_command)
2580 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2581 (set_search_regs, wordify):
2582 (Freplace_match):
2583 (Fmatch_data):
2584 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2585 (string_match_1, search_buffer, set_search_regs):
2586 (Fmatch_data):
2587 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2588 (wordify): Check for overflow in size calculation.
2589 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2590 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2591 Check that fixnums are in proper range for system types.
2592 * sound.c (struct sound_device)
2593 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2594 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2595 (Fplay_sound_internal):
2596 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2597 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2598 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2599 (Fparse_partial_sexp):
2600 Don't assume fixnums can fit in int.
2601 (struct lisp_parse_state, find_start_pos, find_start_value)
2602 (find_start_value_byte, find_start_begv)
2603 (update_syntax_table, char_quoted, dec_bytepos)
2604 (find_defun_start, prev_char_comend_first, back_comment):
2605 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2606 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2607 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2608 (Finternal_describe_syntax_value): Check that match_lisp is a
2609 character, not an integer, since the code stuffs it into int.
2610 (scan_words, scan_sexps_forward):
2611 Check that fixnums are in proper range for system types.
2612 (Fforward_word):
2613 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2614 (scan_sexps_forward):
2615 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2616 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2617 * syntax.h: Adjust decls to match defn changes elsewhere.
2618 (struct gl_state_s):
2619 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2620 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2621 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2622 * sysdep.c (wait_for_termination_1, wait_for_termination)
2623 (interruptible_wait_for_termination, mkdir):
2624 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2625 (emacs_read, emacs_write):
2626 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2627 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2628 and double all fit in int.
d311d28c
PE
2629 * term.c (set_tty_color_mode):
2630 Check that fixnums are in proper range for system types.
2631 * termhooks.h (struct input_event):
2632 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2633 * textprop.c (validate_interval_range, interval_of)
2634 (Fadd_text_properties, set_text_properties_1)
2635 (Fremove_text_properties, Fremove_list_of_text_properties)
2636 (Ftext_property_any, Ftext_property_not_all)
2637 (copy_text_properties, text_property_list, extend_property_ranges)
2638 (verify_interval_modification):
2639 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2640 (Fnext_single_char_property_change)
2641 (Fprevious_single_char_property_change):
2642 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2643 (copy_text_properties):
2644 Check for integer overflow in index calculation.
d311d28c
PE
2645 * undo.c (last_boundary_position, record_point, record_insert)
2646 (record_delete, record_marker_adjustment, record_change)
2647 (record_property_change):
2648 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2649 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2650 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2651 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2652 (Fx_hide_tip, Fx_file_dialog):
2653 * w32menu.c (set_frame_menubar):
2654 Use ptrdiff_t, not int, for consistency with rest of code.
2655 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2656 (select_window, Fdelete_other_windows_internal)
2657 (window_scroll_pixel_based, window_scroll_line_based)
2658 (Frecenter, Fset_window_configuration):
2659 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2660 (Fset_window_hscroll, run_window_configuration_change_hook)
2661 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2662 (Fscroll_other_window, Frecenter):
d311d28c
PE
2663 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2664 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2665 Don't assume fixnum fits in int.
2666 (Fset_window_scroll_bars):
2667 Check that fixnums are in proper range for system types.
2668 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2669 (string_pos, c_string_pos, number_of_chars, init_iterator)
2670 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2671 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2672 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2673 (face_before_or_after_it_pos, handle_invisible_prop)
2674 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2675 (display_prop_intangible_p, string_buffer_position_lim)
2676 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2677 (get_overlay_strings_1, get_overlay_strings)
2678 (iterate_out_of_display_property, forward_to_next_line_start)
2679 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2680 (get_next_display_element, set_iterator_to_next)
2681 (get_visually_first_element, compute_stop_pos_backwards)
2682 (handle_stop_backwards, next_element_from_buffer)
2683 (move_it_in_display_line_to, move_it_in_display_line)
2684 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2685 (add_to_log, message_dolog, message_log_check_duplicate)
2686 (message2, message2_nolog, message3, message3_nolog
2687 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2688 (current_message_1, truncate_echo_area, truncate_message_1)
2689 (set_message, set_message_1, store_mode_line_noprop)
2690 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2691 (text_outside_line_unchanged_p, check_point_in_composition)
2692 (reconsider_clip_changes)
2693 (redisplay_internal, set_cursor_from_row, try_scrolling)
2694 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2695 (redisplay_window, find_last_unchanged_at_beg_row)
2696 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2697 (trailing_whitespace_p, find_row_edges, display_line)
2698 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2699 (display_mode_element, store_mode_line_string)
2700 (pint2str, pint2hrstr, decode_mode_spec)
2701 (display_count_lines, display_string, draw_glyphs)
2702 (x_produce_glyphs, x_insert_glyphs)
2703 (rows_from_pos_range, mouse_face_from_buffer_pos)
2704 (fast_find_string_pos, mouse_face_from_string_pos)
2705 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2706 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2707 (safe_call, init_from_display_pos, handle_fontified_prop)
2708 (handle_single_display_spec, load_overlay_strings)
2709 (with_echo_area_buffer, setup_echo_area_for_printing)
2710 (display_echo_area, echo_area_display)
2711 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2712 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2713 (redisplay_window, dump_glyph_row, display_mode_line)
2714 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2715 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2716 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2717 (handle_single_display_spec, build_desired_tool_bar_string)
2718 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2719 (get_specified_cursor_type):
2720 Check that fixnums are in proper range for system types.
2721 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2722 (Flookup_image_map):
2723 Don't assume fixnums fit in int.
2724 (compare_overlay_entries):
2725 Avoid mishandling comparisons due to subtraction overflow.
2726 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2727 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2728 (handle_tool_bar_click):
2729 Use int, not unsigned, since we prefer signed and the signedness
2730 doesn't matter here.
2731 (get_next_display_element, next_element_from_display_vector):
2732 Use int, not EMACS_INT, when int is wide enough.
2733 (start_hourglass): Use duration_to_sec_usec to do proper
2734 overflow checking on durations.
2735 * xfaces.c (Fbitmap_spec_p):
2736 Check that fixnums are in proper range for system types.
2737 (compare_fonts_by_sort_order):
2738 Avoid mishandling comparisons due to subtraction overflow.
2739 (Fx_family_fonts, realize_basic_faces):
2740 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2741 (Fx_family_fonts):
2742 Don't assume fixnum fits in int.
2743 Use SAFE_ALLOCA_LISP, not alloca.
2744 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2745 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2746 (face_at_buffer_position, face_for_overlay_string)
2747 (face_at_string_position):
2748 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2749 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2750 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2751 (Fx_show_tip):
2752 Check that fixnums are in proper range for system types.
2753 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2754 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2755 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2756 (Fx_change_window_property): Don't assume fixnums fit in int.
2757 * xfont.c (xfont_chars_supported):
2758 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2759 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2760 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2761 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2762 * xml.c (parse_region):
2763 * xrdb.c (magic_file_p):
2764 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2765 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2766 (x_get_local_selection, x_reply_selection_request)
2767 (x_handle_selection_request, wait_for_property_change):
2768 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2769 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2770 short is wide enough.
2771 (x_send_client_event): Don't assume fixnum fits in int.
2772 * xterm.c (x_x_to_emacs_modifiers):
2773 Don't assume EMACS_INT overflows nicely into int.
2774 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2775 may come from Lisp.
2776 (handle_one_xevent): NATNUMP can eval its arg twice.
2777 (x_connection_closed):
2778 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2779 * xterm.h: Adjust decls to match defn changes elsewhere.
2780 (struct scroll_bar): Use struct vectorlike_header
2781 rather than rolling our own approximation.
2782 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2783
c6574eb5
GM
27842012-05-25 Glenn Morris <rgm@gnu.org>
2785
2786 * lisp.mk (lisp): Update for more files being compiled now.
2787
e8d32c7e
SM
27882012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2789
48def666
SM
2790 * lread.c: Remove `read_pure' which makes no difference.
2791 (read_pure): Remove var.
2792 (unreadpure): Remove function.
2793 (readevalloop): Don't call read_list with -1 flag.
2794 (read1, read_vector): Don't test read_pure any more.
2795 (read_list): Simplify.
2796
e8d32c7e
SM
2797 * fileio.c, character.h: Minor style tweaks.
2798
4b2addb7
DA
27992012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2800
2801 * window.h (clip_changed): Remove useless declaration.
2802
584461b2
JB
28032012-05-22 Juanma Barranquero <lekktu@gmail.com>
2804
2805 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2806 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2807
34374650
PE
28082012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2809
2810 Remove src/m/*.
2811 This directory predates autoconf and is no longer needed nowadays.
2812 Move its few remaining bits of functionality to where they're needed.
2813 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2814 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2815 * m/template.h: Remove.
2816 * Makefile.in (M_FILE): Remove. All uses removed.
2817 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2818 * lisp.h (USE_LSB_TAG):
2819 * mem-limits.h (EXCEEDS_LISP_PTR):
2820 Use VAL_MAX, not VALBITS, in #if.
2821 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2822 (EMACS_UINT): Define unconditionally now.
2823 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2824 (BITS_PER_EMACS_INT): New constants, replacing
2825 what used to be in config.h, but not useful in #if.
2826 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2827 define them any more.
2828 (VAL_MAX): New macro.
2829 (VALMASK): Use it.
2830 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2831 BITS_PER_EMACS_INT, in #if.
2832 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2833 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2834 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2835 * s/ms-w32.h (DATA_START):
2836 Move here from removed file m/intel386.h.
2837 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2838 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2839
261cb4bb
PE
28402012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2841
2842 Assume C89 or later.
2843 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2844 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2845 (xrealloc):
2846 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2847 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2848 * textprop.c, tparam.c (NULL): Remove.
2849 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2850 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2851 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2852 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2853 * xterm.c (input_signal_count): Assume volatile works.
2854
ff23cd9f
KB
28552012-05-21 Ken Brown <kbrown@cornell.edu>
2856
2857 * xgselect.c (xg_select): Fix first argument in call to 'select'
2858 (bug#11508).
2859
1b170bc6
KB
28602012-05-20 Ken Brown <kbrown@cornell.edu>
2861
2862 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2863 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2864
b2f4d39f
KB
28652012-05-19 Ken Brown <kbrown@cornell.edu>
2866
2867 * xfns.c (x_in_use): Remove `static' qualifier.
2868 * xterm.h (x_in_use): Declare.
2869 * xgselect.c: Include xterm.h.
2870 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2871 and `display_arg' (bug#9754).
2872
003fdae2
PE
28732012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2874
9232a6d9
PE
2875 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2876
003fdae2
PE
2877 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2878 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2879
784b56e2
EZ
28802012-05-18 Eli Zaretskii <eliz@gnu.org>
2881
2882 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2883
2884 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 2885 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
2886
2887 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2888 reference to image_cache->refcount.
2889 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2890
a0a79cde
JL
28912012-05-17 Juri Linkov <juri@jurta.org>
2892
2893 * search.c (Fword_search_regexp, Fword_search_backward)
2894 (Fword_search_forward, Fword_search_backward_lax)
2895 (Fword_search_forward_lax): Move functions to isearch.el
2896 (bug#10145, bug#11381).
2897
b0572523
PE
28982012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2899
2900 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2901
9660f5fc
SM
29022012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2903
2904 * lread.c (init_obarray): Declare Qt and Qnil as special.
2905
4374de83
GM
29062012-05-14 Glenn Morris <rgm@gnu.org>
2907
2908 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2909 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2910
dc44c39a
PE
29112012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2912
078c97cb
PE
2913 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2914
dc44c39a
PE
2915 * unexaix.c: Port to more-recent AIX compilers.
2916 (report_error, report_error_1, make_hdr, copy_sym)
2917 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2918 Make arguments const char *, not char *, to avoid violations of C
2919 standard and to fix some AIX warnings reported by Gilles Pion.
2920
e18afed7 29212012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2922
2923 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2924 already have overlays loaded.
2925 (handle_single_display_spec): Before returning without displaying
2926 fringe bitmap, synchronize the bidi iterator with the main display
2927 iterator, by calling iterate_out_of_display_property.
2928 (iterate_out_of_display_property): Detect buffer iteration by
2929 testing that it->string is a Lisp string.
2930 (get_next_display_element): When the current object is exhausted,
2931 and there's something on it->stack, call set_iterator_to_next to
2932 proceed with what's on the stack, instead of returning zero.
2933 (set_iterator_to_next): If called at the end of a Lisp string,
2934 proceed to consider_string_end without incrementing string
2935 position. Don't increment display vector index past the end of
2936 the display vector. (Bug#11417)
c8fb9dc6
EZ
2937 (pos_visible_p): Don't report a position visible when move_it_to
2938 stopped at the last line of window, which happens to be scanned
2939 backwards by the bidi iteration. (Bug#11464)
ac268e67 2940
e18afed7 29412012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2942
2943 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2944 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2945 are on a TTY, and thus unable to display on the fringes.
2946 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2947 so we need to signal to the caller that this is a "replacing"
2948 display spec. This fixes display when the spec is invalid or we
2949 are on a TTY.
2950
e18afed7 29512012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2952
2953 * unexaix.c (make_hdr): Fix typo in prototype.
2954 This bug broke the build on AIX. Problem reported by Gilles Pion.
2955
9d0a235a
MA
29562012-05-14 Michael Albinus <michael.albinus@gmx.de>
2957
2958 * keyboard.c (kbd_buffer_get_event): Read special events also in
2959 batch mode. (Bug#11415)
2960
9e6b06ed
GM
29612012-05-12 Glenn Morris <rgm@gnu.org>
2962
2963 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2964
c1a1d7a3
EZ
29652012-05-12 Eli Zaretskii <eliz@gnu.org>
2966
2967 * lisp.mk (lisp): Add newcomment.elc.
2968
3fe7cdc8
GM
29692012-05-12 Glenn Morris <rgm@gnu.org>
2970
2971 * Makefile.in (MKDIR_P): New, set by configure.
2972 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2973
53f7d2c0
PE
29742012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2975
2976 Remove unused function hourglass_started.
2977 * dispextern.h (hourglass_started):
2978 * w32fns.c (hourglass_started):
2979 * xdisp.c (hourglass_started): Remove.
2980
75aafb17
JB
29812012-05-10 Juanma Barranquero <lekktu@gmail.com>
2982
2983 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2984 Update dependencies.
2985
12959e8e
PE
29862012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2987
97107e2e
PE
2988 * xgselect.c (xg_select): Put maxfds+1 into a var.
2989 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2990
12959e8e
PE
2991 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2992
836d29b3
DA
29932012-05-10 Dave Abrahams <dave@boostpro.com>
2994
2995 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2996 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2997
5cb67954
MA
29982012-05-09 Michael Albinus <michael.albinus@gmx.de>
2999
3000 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3001 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3002 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3003 Initialize xd_registered_buses.
3004
3478ec45
PE
30052012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3006
b263a6b0
PE
3007 Untag more efficiently if USE_LSB_TAG.
3008 This is based on a proposal by YAMAMOTO Mitsuharu in
3009 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3010 For an admittedly artificial (nth 8000 longlist) benchmark on
3011 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3012 Emacs's overall text size by 1%.
3013 * lisp.h (XUNTAG): New macro.
3014 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3015 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3016 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3017 * eval.c (Fautoload):
3018 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3019 * frame.h (XFRAME): Use XUNTAG.
3020
3478ec45
PE
3021 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3022 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3023 Remove unportable assumptions about print widths of types like
3024 dbus_uint32_t.
3025 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3026 intptr_t when converting between pointer and integer, to avoid GCC
3027 warnings about wrong width.
3028
666b903b 30292012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3030
3031 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3032 stack for each reader_thread, instead of defaulting to 8MB
3033 determined by the linker. This avoids failures in creating
3034 subprocesses on Windows 7, see the discussion in this thread:
3035 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3036
b120cc17
JC
30372012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3038
3039 Fix up display of the *Minibuf-0* buffer in the mini window.
3040 * keyboard.c (read_char): Don't clear the echo area if there's no
3041 message to clear.
3042 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3043 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3044
9a4b36f8
MA
30452012-05-07 Michael Albinus <michael.albinus@gmx.de>
3046
3047 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3048 batch mode.
3049
e5f9458f
CY
30502012-05-06 Chong Yidong <cyd@gnu.org>
3051
3052 * lisp.mk (lisp): Update.
3053
eceeb5fc 30542012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3055
3056 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3057
71873e2b
SM
30582012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3059
3060 * data.c (PUT_ERROR): New macro.
3061 (syms_of_data): Use it. Add new error type `user-error'.
3062 * undo.c (user_error): New function.
3063 (Fprimitive_undo): Use it.
3064 * print.c (print_error_message): Adjust print style for `user-error'.
3065 * keyboard.c (user_error): New function.
3066 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3067
ab0fa4e4
PE
30682012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3069
3070 Do not limit current-time-string to years 1000..9999.
3071 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3072 (Fcurrent_time_string): Support any year that is supported by the
3073 underlying localtime representation. Don't use asctime, as it
3074 has undefined behavior for years outside the range -999..9999.
3075
7ed806a7
PE
30762012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3077
3078 Fix race conditions involving setenv, gmtime, localtime, asctime.
3079 Without this fix, interrupts could mess up code that uses these
3080 nonreentrant functions, since setting TZ invalidates existing
3081 tm_zone or tzname values, and since most of these functions return
3082 pointers to static storage.
3083 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3084 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3085 Grow the critical sections to include not just invoking
3086 localtime/gmtime, but also accessing these functions' results
3087 including their tm_zone values if any, and any related TZ setting.
3088 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3089 so that the struct tm is saved in the critical section.
3090 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3091 motivated by the fact that memory allocation needs to be outside
3092 the critical section.
3093
0c16dfed
DA
30942012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3095
3096 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3097 with RESET_INTERVAL.
3098
3099 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3100 Remove duplicated buffer name initialization.
3101
3f83ace8
JM
31022012-05-02 Jim Meyering <jim@meyering.net>
3103
3104 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3105
c7b8541e
JM
3106 * xfns.c (x_window): Use xstrdup (Bug#11375).
3107
90207a15 31082012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3109
3110 * xdisp.c (pos_visible_p): If already at a newline from the
3111 display string before the 'while' loop, don't walk back the glyphs
3112 from it3.glyph_row. Solves assertion violation when the display
3113 string begins with a newline (egg.el). (Bug#11367)
3114
b593d6a9
AH
31152012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3116
3117 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3118 Move to simple.el.
3119
4737362e
GM
31202012-05-01 Glenn Morris <rgm@gnu.org>
3121
99cf43f9
GM
3122 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3123 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3124 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3125 All were removed before 23.1.
3126
9311dcff
GM
3127 * dispnew.c: Remove HAVE_LIBNCURSES test;
3128 it is always true on relevant platforms.
3129
4d5c6349
GM
3130 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3131 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3132
4737362e
GM
3133 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3134
74dd3a6b
AS
31352012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3136
3137 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3138 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3139 Remove.
3140
13c379ee
PE
31412012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3142
3143 Do not avoid creating empty evaporating overlays (Bug#9642).
3144 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3145 That is, do not delete an evaporating overlay if it becomes
3146 empty after its bounds are adjusted to fit within its buffer.
3147 This fix caused other problems, and I'm reverting it until we get
3148 to the bottom of them.
3149
a8e7d6d7 31502012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3151
3152 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3153
a8e7d6d7 31542012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3155
3156 * xdisp.c (pos_visible_p): If the window start position is beyond
3157 ZV, start the display from buffer beginning. Prevents assertion
3158 violation in init_iterator when the minibuffer window is scrolled
3159 via the scroll bar.
3160
3161 * window.c (window_scroll_pixel_based): Likewise.
3162
a8e7d6d7 31632012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3164
3165 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3166
a8e7d6d7 31672012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3168
3169 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3170 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3171
a8e7d6d7 31722012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3173
b593d6a9
AH
3174 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3175 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3176
1c6900d9
EZ
31772012-04-26 Eli Zaretskii <eliz@gnu.org>
3178
4c3fa1d9
EZ
3179 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3180 display element, check also the underlying string or buffer
3181 character. (Bug#11341)
3182
1c6900d9
EZ
3183 * w32menu.c: Include w32heap.h.
3184 (add_menu_item): If the call to AppendMenuW (via
3185 unicode_append_menu) fails, disable Unicode menus only if we are
3186 running on Windows 9X/Me.
3187
42bf8205
AS
31882012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3189
3190 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3191 (xgetint): Add missing shift for LSB tags.
3192
b1bac16e
MR
31932012-04-24 Martin Rudalics <rudalics@gmx.at>
3194
3195 * keyboard.c (read_char): Don't wipe echo area for select window
3196 events: These might get delayed via `mouse-autoselect-window'
3197 (Bug#11304).
3198
d69621cc
JB
31992012-04-24 Juanma Barranquero <lekktu@gmail.com>
3200
3201 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3202 manipulation of :loaded-from data.
3203
02fd101b
JB
32042012-04-23 Juanma Barranquero <lekktu@gmail.com>
3205
3206 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3207 now a cons (bug#11311).
3208
888bec30
PE
32092012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3210
89a438bd
PE
3211 Do not create empty overlays with the evaporate property (Bug#9642).
3212 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3213 if it becomes empty after its bounds are adjusted to fit within
3214 its buffer. Without this fix, in a nonempty buffer (let ((o
3215 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3216 yields an empty overlay that has the evaporate property, which is
3217 not supposed to happen.
3218
1068fe4d
PE
3219 Fix minor GTK3 problems found by static checking.
3220 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3221 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3222 (struct _EmacsFixedClass, emacs_fixed_get_type):
3223 Move decls here from emacsgtkfixed.h, since they needn't be public.
3224 (emacs_fixed_get_type): Now static.
3225 (emacs_fixed_class_init): Omit unused local.
3226 (emacs_fixed_child_type): Remove; unused.
3227 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3228 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3229 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3230 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3231 (EMACS_FIXED_GET_CLASS): Remove; unused.
3232 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3233
888bec30
PE
3234 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3235 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3236
de85e130
PE
32372012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3238
d0baac98 3239 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3240 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3241 (__malloc_size_t, __malloc_ptrdiff_t):
3242 Remove. All uses removed, replaced by the definiens if needed,
3243 since we can assume C89 or better now.
3244 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3245 (protect_malloc_state, align, get_contiguous_space)
3246 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3247 (malloc_atfork_handler_child, malloc_enable_thread)
3248 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3249 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3250 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3251 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3252 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3253 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3254 Define using prototypes, not old style.
3255 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3256 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3257 (align): Don't assume that signed integer overflow wraps around.
3258 Omit unused local var.
3259 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3260 (_free_internal_nolock, memalign, mallochook, reallochook):
3261 Omit no-longer-needed casts.
3262 (valloc): Use getpagesize, not __getpagesize.
3263 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3264 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3265
de85e130
PE
3266 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3267
dcbf5805
MA
32682012-04-22 Michael Albinus <michael.albinus@gmx.de>
3269
3270 Move functions from C to Lisp. Make non-blocking method calls
3271 the default. Implement further D-Bus standard interfaces.
3272
3273 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3274 (QCdbus_request_name_allow_replacement)
3275 (QCdbus_request_name_replace_existing)
3276 (QCdbus_request_name_do_not_queue)
3277 (QCdbus_request_name_reply_primary_owner)
3278 (QCdbus_request_name_reply_in_queue)
3279 (QCdbus_request_name_reply_exists)
3280 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3281 (QCdbus_registered_serial, QCdbus_registered_method)
3282 (QCdbus_registered_signal): New Lisp objects.
3283 (XD_DEBUG_MESSAGE): Use sizeof.
3284 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3285 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3286 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3287 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3288 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3289 (xd_signature, xd_append_arg): Allow float for integer types.
3290 (xd_get_connection_references): New function.
b593d6a9
AH
3291 (xd_get_connection_address): Rename from xd_initialize.
3292 Return cached address.
dcbf5805
MA
3293 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3294 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3295 level.
3296 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3297 Return number of refcounts.
dcbf5805
MA
3298 (Fdbus_get_unique_name): Make stronger parameter check.
3299 (Fdbus_message_internal): New defun.
3300 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3301 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3302 (Fdbus_send_signal, Fdbus_register_service)
3303 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3304 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3305 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3306 (Vdbus_compiled_version, Vdbus_runtime_version)
3307 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3308 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3309 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3310 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3311 Adapt docstring.
dcbf5805 3312
52828e02
PE
33132012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3314
da05bc4c
PE
3315 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3316 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3317 Do not assume ptrdiff_t is the same width as 'int'.
3318
52828e02
PE
3319 * alloc.c: Handle unusual debugging option combinations.
3320 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3321 since the two debugging options are incompatible.
3322 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3323 is defined.
3324 (mem_init, mem_insert, mem_insert_fixup):
3325 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3326 (NEED_MEM_INSERT): Remove; no longer needed.
3327
f01769f9
LL
33282012-04-22 Leo Liu <sdl.web@gmail.com>
3329
3330 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3331
5790543d
PE
33322012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3333
3334 * sysdep.c [__FreeBSD__]: Minor cleanups.
3335 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3336 Use Emacs indenting style more consistently. Avoid some casts.
3337 Use 'double' consistently rather than mixing 'float' and 'double'.
3338
b91b7e4d
EW
33392012-04-21 Eduard Wiebe <usenet@pusto.de>
3340
b593d6a9
AH
3341 * sysdep.c (list_system_processes, system_process_attributes):
3342 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3343
6114eb15
AS
33442012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3345
3346 * lisp.mk (lisp): Update.
3347
2f38dff7
PE
33482012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3349
3350 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3351 It is never used otherwise.
3352
4ae29f89
SM
33532012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3354
3355 * print.c (print_preprocess): Only check print_depth if print-circle
3356 is nil.
3357 (print_object): Check for cycles even when print-circle is nil and
3358 print-gensym is t, but only check print_depth if print-circle is nil.
3359
f30d612a
CY
33602012-04-20 Chong Yidong <cyd@gnu.org>
3361
3362 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3363 set the status to "failed" and ensure that sentinel is run.
3364
c07a4c0b 33652012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3366
3367 * process.c (Fset_process_inherit_coding_system_flag)
3368 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3369 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3370
c07a4c0b 33712012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3372
3373 * xdisp.c (string_buffer_position_lim): Limit starting position to
3374 BEGV.
3375 (set_cursor_from_row): If called for a mode-line or header-line
3376 row, return zero immediately.
3377 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3378 farther than the first row after the header line, if any.
3379 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3380 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3381
c07a4c0b 33822012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3383
4ae29f89
SM
3384 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3385 (bug#11238).
ad3a2b41 3386
c07a4c0b 33872012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 33882012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3389
3390 configure: new option --enable-gcc-warnings (Bug#11207)
3391 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3392 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3393 (ALL_CFLAGS): Use new macros rather than old.
3394 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3395 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3396 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3397 -Wunused-result, -Wunused-variable. This should go away once
3398 the Emacs and Gnulib regex code is merged.
3399 (xmalloc, xrealloc): Now static.
3400
aba027e8
PE
34012012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3402
3403 * dired.c (Fsystem_groups): Remove unused local.
3404
e5a36063
GM
34052012-04-17 Glenn Morris <rgm@gnu.org>
3406
3407 * dired.c (Fsystem_users): Doc fix.
3408
316411f0
DA
34092012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3410
3411 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3412 (syms_of_dired): Add them.
3413
9426aba4
PE
34142012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3415
b62a57be
PE
3416 Fix minor alloc.c problems found by static checking.
3417 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3418 New extern decls, to avoid calling undeclared functions.
3419 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3420 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3421 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3422 (NEED_MEM_INSERT): New macro.
3423 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3424 Remove one incorrect comment and fix another.
b62a57be 3425
3539f31f
PE
3426 Fix minor ralloc.c problems found by static checking.
3427 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3428 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3429 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3430 (r_alloc_sbrk): Now static.
3431
a041960a
PE
3432 Improve ralloc.c interface checking.
3433 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3434 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3435 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3436 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3437 [REL_ALLOC]: ... to here, to check interface.
3438 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3439 Remove decls. This fixes an "It stinks!".
3440
9426aba4
PE
3441 * alloc.c (which_symbols): Fix alignment issue / type clash.
3442
d55c12ed
AS
34432012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3444
3445 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3446 (struct Lisp_Misc_Any): Likewise.
3447 (struct Lisp_Free): Likewise.
3448 * alloc.c (union aligned_Lisp_Symbol): Define.
3449 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3450 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3451 (union aligned_Lisp_Misc): Define.
3452 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3453 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3454 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3455
b948ce8b
PE
34562012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3457
3458 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3459 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3460 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3461 * s/netbsd.h, s/sol2-6.h:
3462 Remove definition of GC_MARK_STACK, since the default now works.
3463 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3464 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3465 no longer the default.
3466 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3467
35dc09a1 34682012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3469
35dc09a1
GM
3470 * lread.c (lisp_file_lexically_bound_p):
3471 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3472
35dc09a1
GM
34732012-04-14 Eli Zaretskii <eliz@gnu.org>
3474
3475 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3476 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3477
34782012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3479
3480 * nsterm.m (constrainFrameRect): Always constrain when there is only
3481 one screen (Bug#10962).
3482
bcd86815
KB
34832012-04-13 Ken Brown <kbrown@cornell.edu>
3484
3485 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3486
c25df26e
RT
34872012-04-13 Reuben Thomas <rrt@sc3d.org>
3488
3489 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3490
0fc59f1e
DC
34912012-04-11 Daniel Colascione <dancol@dancol.org>
3492
3493 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3494 against is gone. It's better to use vfork now so that when Cygwin
3495 gains a new, working vfork, we use it automatically (bug#10398).
3496
de8c03dc
SM
34972012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3498
3499 * window.c (save_window_save): Obey window-point-insertion-type.
3500
2f097256
GM
35012012-04-11 Glenn Morris <rgm@gnu.org>
3502
3503 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3504
453b951e
SM
35052012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3506
3507 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3508
75f1671a 35092012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3510
3511 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3512 (force_quit_count): New var.
3513 (handle_interrupt): Use it.
3514
2a8ce227
JB
35152012-04-10 Juanma Barranquero <lekktu@gmail.com>
3516
3517 * w32.c (w32_delayed_load): Record the full path of the library
3518 being loaded (bug#10424).
3519
935396c0
GM
35202012-04-09 Glenn Morris <rgm@gnu.org>
3521
05920a43
GM
3522 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3523 not just in the obarray, before snarfing them. (Bug#11036)
3524
935396c0
GM
3525 * Makefile.in ($(leimdir)/leim-list.el):
3526 Pass EMACS rather than BUILT_EMACS.
3527
a18ecafa
TZ
35282012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3529
3530 * process.c (make_process):
3531 * process.h: Add integer `gnutls_handshakes_tried' member to
3532 process struct.
3533
6bbef4e5
JC
3534 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3535 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3536
3537 * gnutls.c (gnutls_log_function2i): Convenience log function.
3538 (emacs_gnutls_read): Use new log functions,
3539 `gnutls_handshakes_tried' process member, and
3540 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3541 attempts per process (connection).
3542
b4d3bc10
CY
35432012-04-09 Chong Yidong <cyd@gnu.org>
3544
3545 * eval.c (Fuser_variable_p, user_variable_p_eh)
3546 (lisp_indirect_variable): Functions deleted.
3547 (Fdefvar): Caller changed.
3548
3549 * callint.c (Finteractive, Fcall_interactively):
3550 * minibuf.c (Fread_variable): Callers changed.
3551
70f4d973
EZ
35522012-04-09 Eli Zaretskii <eliz@gnu.org>
3553
3554 * xdisp.c (set_cursor_from_row): If the display string appears in
3555 the buffer at position that is closer to point than the position
3556 after the display string, display the cursor on the first glyph of
3557 the display string. Fixes cursor display when a 'display' text
3558 property immediately follows invisible text. (Bug#11094)
3559
cb3c2e3e
PE
35602012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3561
3562 composite.c: use 'double' consistently
3563 * composite.c (get_composition_id): Use 'double' consistently
3564 instead of converting 'float' to 'double' and vice versa; this is
3565 easier to understand and avoids a GCC warning.
3566
fd06db5d
GM
35672012-04-09 Glenn Morris <rgm@gnu.org>
3568
50fe702a
GM
3569 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3570 preparation for dumping it with emacs. (Bug#4789)
3571 (leimdir): New variable.
3572 ($(leimdir)/leim-list.el): New rule.
3573 (emacs$(EXEEXT)): Depend on leim-list.el.
3574
fd06db5d
GM
3575 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3576 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3577 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3578
55c131ee
AS
35792012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3580
3581 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3582 proper alignment.
3583
9209588f
JB
35842012-04-07 Juanma Barranquero <lekktu@gmail.com>
3585
3586 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3587 Remove unused local variable.
3588
e3fb2efb
PE
35892012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3590
3591 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3592 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3593 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3594 objects, as mark_maybe_pointer will catch them otherwise.
3595 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3596 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3597
b5385551
PE
35982012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3599
3600 Fix typo that broke non-Windows builds.
3601 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3602
9078ead6
EZ
36032012-04-07 Eli Zaretskii <eliz@gnu.org>
3604
3605 Support building on MS-Windows with libxml2.
3606
3607 * makefile.w32-in (OBJ2): Add xml.$(O).
3608 (GLOBAL_SOURCES): Add xml.c.
3609 ($(BLD)/xml.$(O)): New dependency list.
3610
3611 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3612 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3613 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3614 [!WINDOWSNT]: New macros.
3615 (init_libxml2_functions, libxml2_loaded_p): New functions.
3616 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3617 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3618 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3619 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3620 linked in).
6bbef4e5
JC
3621 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3622 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3623 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3624
3625 * emacs.c: Don't include libxml/parser.h.
3626 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3627 xmlCleanupParser directly.
3628
3629 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3630
3811fdf3
EZ
36312012-04-07 Eli Zaretskii <eliz@gnu.org>
3632
3633 * indent.c (Fvertical_motion): If there is a display string at
3634 point, use it.vpos to compute how many lines to backtrack after
3635 move_it_to point. (Bug#11133)
3636
2f8e16b2
EZ
36372012-04-06 Eli Zaretskii <eliz@gnu.org>
3638
3639 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3640 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3641 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3642 macros related to unification of CJK characters. For the details,
3643 see the discussion following the message here:
3644 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3645
3d439cd1
CY
36462012-04-04 Chong Yidong <cyd@gnu.org>
3647
3648 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3649
8bc53d00
EZ
36502012-04-01 Eli Zaretskii <eliz@gnu.org>
3651
3652 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3653 instead of alloca. (Bug#11138)
3654
3b0512a3
AS
36552012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3656
3657 * w32menu.c (is_simple_dialog): Properly check lisp types.
3658 (Bug#11141)
3659
8427ddd2
EZ
36602012-03-31 Eli Zaretskii <eliz@gnu.org>
3661
979022ef
EZ
3662 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3663 position we get to after a call to move_it_to fails the
3664 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3665 only if we wind up in a string from display property. (Bug#11063)
3666
a6b1c7cc
EZ
3667 * window.c (Fdelete_other_windows_internal): Invalidate the row
3668 and column information about mouse highlight, so that redisplay
3669 restores it after reallocating the glyph matrices. (Bug#7464)
3670
8427ddd2
EZ
3671 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3672 string comes from a `display' text property, use the buffer
3673 position of that property as if we actually saw that position in
3674 the row's glyphs.
697ba24b
EZ
3675 (move_it_by_lines): Remove the assertion that
3676 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3677 violated when there's a before-string at the beginning of a line.
3678 (Bug#11063)
8427ddd2 3679
65a0a738
EZ
36802012-03-30 Eli Zaretskii <eliz@gnu.org>
3681
3682 * xdisp.c (append_space_for_newline): If the default face was
3683 remapped, use the remapped face for the appended newline.
3684 (extend_face_to_end_of_line): Use the remapped default face for
3685 extending the face to the end of the line.
3686 (display_line): Call extend_face_to_end_of_line when the default
3687 face was remapped. (Bug#11068)
3688
581355cc
EZ
36892012-03-29 Eli Zaretskii <eliz@gnu.org>
3690
3691 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3692
e8fc049f
SM
36932012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3694
3695 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3696
4fb9a543
GM
36972012-03-27 Glenn Morris <rgm@gnu.org>
3698
3699 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3700 Doc fixes.
3701
679910f1
KH
37022012-03-26 Kenichi Handa <handa@m17n.org>
3703
3704 * dispextern.h (struct glyph): Fix previous change. Change the
3705 bit length of glyphless.ch to 25 (Bug#11082).
3706
90d49b7f
CY
37072012-03-26 Chong Yidong <cyd@gnu.org>
3708
3709 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3710 (command_loop_1): Use it; inhibit selection update for
3711 handle-select-window too (Bug#8996).
3712
f514f6f0
FP
37132012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3714
e8fc049f 3715 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3716
bf43fa51
KH
37172012-03-25 Kenichi Handa <handa@m17n.org>
3718
3719 * dispextern.h (struct glyph): Change the bit length of
3720 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3721
8a0c01dd
EZ
37222012-03-24 Eli Zaretskii <eliz@gnu.org>
3723
3724 * s/ms-w32.h (tzname): Include time.h before redirecting to
3725 _tzname. Fixes the MSVC build. (Bug#9960)
3726
7d1c3a76
AS
37272012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3728
8ed79523
AS
3729 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3730 characters.
3731
7d1c3a76
AS
3732 * xterm.c (XTread_socket): Only modify handling_signal if
3733 !SYNC_INPUT. (Bug#11080)
3734
e99a9b8b
EZ
37352012-03-23 Eli Zaretskii <eliz@gnu.org>
3736
3737 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3738 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3739 when fetching a multibyte character consumes more bytes than
3740 CHAR_BYTES returns, due to unification of CJK characters in
3741 string_char. (Bug#11073)
3742
5063c0e1
TN
37432012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3744
3745 * process.c (wait_reading_process_output): Handle pty disconnect
3746 by refraining from sending oneself a SIGCHLD (bug#10933).
3747
9f851fbd
CY
37482012-03-22 Chong Yidong <cyd@gnu.org>
3749
3750 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3751
5063c0e1 3752 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3753 Mark string as coming from a prefix property.
3754 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3755 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3756
fb5b8aca
CY
37572012-03-21 Chong Yidong <cyd@gnu.org>
3758
3759 * xfaces.c (Vface_remapping_alist): Doc fix.
3760
62356a1b
EZ
37612012-03-20 Eli Zaretskii <eliz@gnu.org>
3762
3763 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3764 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3765 Doc fixes.
62356a1b 3766
025de85b
CY
37672012-03-20 Chong Yidong <cyd@gnu.org>
3768
3769 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3770 to reflect default non-nil value of redisplay-dont-pause.
3771
4827f94e
KH
37722012-03-19 Kenichi Handa <handa@m17n.org>
3773
3774 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3775 it fit in a valid range (Bug#11003).
3776
e50a24a2
EZ
37772012-03-18 Eli Zaretskii <eliz@gnu.org>
3778
3779 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3780 that is not from display property, accept the row as a "cursor
3781 row" if one of the string's character has a non-nil `cursor'
3782 property. Fixes cursor positioning when there are newlines in
3783 overlay strings, e.g. in icomplete.el. (Bug#11035)
3784
9af5ed87
PE
37852012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3786
3787 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3788
d1f55f16
CY
37892012-03-12 Chong Yidong <cyd@gnu.org>
3790
3791 * eval.c (inhibit_lisp_code): Rename from
3792 inhibit_window_configuration_change_hook; move from window.c.
3793
3794 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3795 * window.c (run_window_configuration_change_hook)
3796 (syms_of_window): Callers changed.
3797
66c5eebd
CY
37982012-03-11 Chong Yidong <cyd@gnu.org>
3799
413df973
CY
3800 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3801
66c5eebd
CY
3802 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3803
1de11f56
CY
38042012-03-10 Chong Yidong <cyd@gnu.org>
3805
3806 * frame.c (other_visible_frames): Don't assume the selected frame
3807 is visible (Bug#10955).
3808
cae07000
SM
38092012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3810
3811 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3812
89c94350
JD
38132012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3814
3815 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3816 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3817 zero (Bug#10954).
3818
999dd333
GM
38192012-03-03 Glenn Morris <rgm@gnu.org>
3820
01a6dcc8 3821 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3822
de0100f2
EZ
38232012-03-02 Eli Zaretskii <eliz@gnu.org>
3824
3825 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3826 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3827 (redisplay_window, next_element_from_string): Fix typos in
3828 comments.
3e441275
EZ
3829 (redisplay_window): Pass to move_it_vertically the margin in
3830 pixels, not in screen lines.
de0100f2 3831
96a72ee9
GM
38322012-03-02 Glenn Morris <rgm@gnu.org>
3833
3834 * buffer.c (buffer-list-update-hook): Doc fix.
3835
312508d7
EZ
38362012-02-29 Eli Zaretskii <eliz@gnu.org>
3837
3838 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3839 push_it before setting up the iterator for the first overlay
3840 string, even if we have an empty string loaded.
3841 (next_overlay_string): If there's an empty string on the iterator
3842 stack, pop the stack. (Bug#10903)
3843
27f3c637
PE
38442012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3845
3846 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3847 Suggested by Stefan Monnier in
3848 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3849 * alloc.c (widen_to_Lisp_Object): New static function.
3850 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3851 and widening them to Lisp_Objects. This would work even if
3852 USE_LSB_TAG is defined and wide integers are used, which might
3853 happen in a future version of Emacs.
3854
3c9dfce6
CY
38552012-02-25 Chong Yidong <cyd@gnu.org>
3856
fa74b241
CY
3857 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3858 Doc fix.
3859
3c9dfce6
CY
3860 * xselect.c (Fx_selection_exists_p): Doc fix.
3861 (x_clipboard_manager_save_all): Print an informative message
3862 before saving to clipboard manager.
3863
9486df08
CY
38642012-02-24 Chong Yidong <cyd@gnu.org>
3865
3866 * keyboard.c (process_special_events): Handle all X selection
3867 requests in kbd_buffer, not just the next one (Bug#8869).
3868
f01d3321
CY
38692012-02-23 Chong Yidong <cyd@gnu.org>
3870
3871 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3872 call when setting menu-bar-lines and tool-bar-lines parameters.
3873 (unwind_create_frame_1): New helper function.
3874
3875 * window.c (inhibit_window_configuration_change_hook): New var.
3876 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3877 (syms_of_window): Initialize it.
f01d3321 3878
86b847b6
CY
38792012-02-22 Chong Yidong <cyd@gnu.org>
3880
3881 * xterm.c (x_draw_image_relief): Add missing type check for
3882 Vtool_bar_button_margin (Bug#10743).
3883
a59225b1
CY
38842012-02-21 Chong Yidong <cyd@gnu.org>
3885
3886 * fileio.c (Vfile_name_handler_alist): Doc fix.
3887
3888 * buffer.c (Fget_file_buffer): Protect against invalid file
3889 handler return value.
3890
310f5bd4
PE
38912012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3892
cb3a28cc
PE
3893 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3894 when computing $valmask.
3895
310f5bd4
PE
3896 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3897 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3898 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3899 It's useless in that case, and it can cause problems on hosts
3900 that allocate halves of EMACS_INT values separately.
3901 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3902 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3903 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3904 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3905 it avoids undefined behavior on hosts where shifting right by more
3906 than the word width has undefined behavior.
3907
2375c96a
CY
39082012-02-19 Chong Yidong <cyd@gnu.org>
3909
3910 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3911 (Funhandled_file_name_directory, Ffile_name_as_directory)
3912 (Fdirectory_file_name, Fexpand_file_name)
3913 (Fsubstitute_in_file_name): Protect against invalid file handler
3914 return values (Bug#10845).
3915
3eb49e71
EZ
39162012-02-18 Eli Zaretskii <eliz@gnu.org>
3917
3918 * .gdbinit (pitx): Fix incorrect references to fields of the
3919 iterator stack.
3920
7b926f3f
CY
39212012-02-17 Chong Yidong <cyd@gnu.org>
3922
3923 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3924
11273115
PE
39252012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3926
3927 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3928 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3929
c3a70e2b
CY
39302012-02-15 Chong Yidong <cyd@gnu.org>
3931
3932 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3933 marked as special. Also, starting docstrings with * is obsolete.
3934
0ca43699
AS
39352012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3936
3937 * gnutls.c (emacs_gnutls_write): Fix last change.
3938
2e8f3c56
LI
39392012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3940
3941 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3942 send_process.
3943
af70074f
SM
39442012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3945
3946 * keymap.c (Fsingle_key_description): Handle char ranges.
3947
95986d52
CY
39482012-02-12 Chong Yidong <cyd@gnu.org>
3949
afd83bd1
CY
3950 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3951 as that creates a dangerous corner case.
3952
95986d52
CY
3953 * window.c (Fdelete_window_internal): Invalidate the mouse
3954 highlight (Bug#9904).
3955
bd7da63e
GM
39562012-02-12 Glenn Morris <rgm@gnu.org>
3957
3958 * xselect.c (Fx_own_selection_internal)
3959 (Fx_get_selection_internal, Fx_disown_selection_internal)
3960 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3961 * nsselect.m (Fx_own_selection_internal)
3962 (Fx_disown_selection_internal, Fx_selection_exists_p)
3963 (Fx_selection_owner_p, Fx_get_selection_internal):
3964 Sync docs and argument specs with the xselect.c versions.
3965
77abcbc2
LI
39662012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3967
3968 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3969
90b671e2
EZ
39702012-02-11 Eli Zaretskii <eliz@gnu.org>
3971
1c0ca0b7
EZ
3972 * w32select.c (Fx_selection_exists_p): Sync doc string and
3973 argument list with xselect.c. (Bug#10783)
3974
3975 * w16select.c (Fx_selection_exists_p): Sync doc string and
3976 argument list with xselect.c. (Bug#10783)
90b671e2 3977
49241268
GM
39782012-02-10 Glenn Morris <rgm@gnu.org>
3979
3980 * fns.c (Fsecure_hash): Doc fix.
3981
f998bbe7 39822012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3983
3984 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3985
0992bd9c
CY
39862012-02-07 Chong Yidong <cyd@gnu.org>
3987
3988 * buffer.c (Fbuffer_local_variables)
3989 (buffer_lisp_local_variables): Handle unbound vars correctly;
3990 don't let Qunbound leak into Lisp.
3991
af008560
GM
39922012-02-07 Glenn Morris <rgm@gnu.org>
3993
dd605cc4
GM
3994 * image.c (Fimagemagick_types): Doc fix.
3995
af008560
GM
3996 * image.c (imagemagick-render-type): Change it from a lisp object
3997 to an integer. Move the doc here from the lisp manual.
3998 Treat all values not equal to 0 the same.
3999
1449fa1d
CY
40002012-02-06 Chong Yidong <cyd@gnu.org>
4001
4002 * doc.c (store_function_docstring): Avoid applying docstring of
4003 alias to base function (Bug#2603).
4004
3723ec07
AS
40052012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4006
4007 * .gdbinit (pp1, pv1): Remove redundant defines.
4008 (pr): Use pp.
4009
79c1cc1e
CY
40102012-02-04 Chong Yidong <cyd@gnu.org>
4011
4012 * nsterm.m: Declare a global (Bug#10694).
4013
d7f29f8e
EZ
40142012-02-04 Eli Zaretskii <eliz@gnu.org>
4015
cae07000
SM
4016 * w32.c (get_emacs_configuration_options):
4017 Include --enable-checking, if specified, in the return value.
d7f29f8e 4018
3b95a6f9
MR
40192012-02-04 Martin Rudalics <rudalics@gmx.at>
4020
4021 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4022 after rounding frame sizes. (Bug#9723)
4023
d6fa96a6
EZ
40242012-02-04 Eli Zaretskii <eliz@gnu.org>
4025
4026 * keyboard.c (adjust_point_for_property): Don't position point
4027 before BEGV. (Bug#10696)
4028
df0b2940
PE
40292012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4030
4031 Handle overflow when computing char display width (Bug#9496).
4032 * character.c (char_width): Return EMACS_INT, not int.
4033 (char_width, c_string_width): Check for overflow when
4034 computing the width; this is possible now that individual
4035 characters can have unbounded width. Problem introduced
4036 by merge from Emacs 23 on 2012-01-19.
4037
6bee44d6
MA
40382012-02-02 Michael Albinus <michael.albinus@gmx.de>
4039
4040 * dbusbind.c (Fdbus_register_method): Mention the return value
4041 :ignore in the docstring.
4042
44f92739
GM
40432012-02-02 Glenn Morris <rgm@gnu.org>
4044
1b9f60cc
GM
4045 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4046
44f92739
GM
4047 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4048 Unconditionally set to t. (Bug#10673)
4049 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4050 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4051 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4052
c5d3843c
KH
40532012-02-02 Kenichi Handa <handa@m17n.org>
4054
4055 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4056 0, do not call append_composite_glyph.
4057
159462d4 40582012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4059
4060 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4061 NULL (Bug#6988).
4062 (x_produce_glyphs): If the component of a composition is a null
4063 string, set it->pixel_width to 1 to avoid zero-width glyph.
4064
78cef877
EZ
40652012-02-01 Eli Zaretskii <eliz@gnu.org>
4066
4067 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4068 first 2 arguments are identical. This makes inserting large
4069 output from a subprocess an order of magnitude faster on
4070 MS-Windows, where all sbrk'ed memory is always contiguous.
4071
97897668
GM
40722012-01-31 Glenn Morris <rgm@gnu.org>
4073
4074 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4075 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4076 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4077
31fd3586
GM
40782012-01-29 Glenn Morris <rgm@gnu.org>
4079
4080 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4081
0e24a8b2
CY
40822012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4083
4084 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4085
cc0adcb0
CY
40862012-01-28 Chong Yidong <cyd@gnu.org>
4087
4088 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4089
acc28cb9
CY
40902012-01-26 Chong Yidong <cyd@gnu.org>
4091
9c69cfb7
CY
4092 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4093
acc28cb9
CY
4094 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4095 repeat counts (Bug#10507).
4096
48da7392
GM
40972012-01-26 Glenn Morris <rgm@gnu.org>
4098
4099 * lread.c (syms_of_lread): Doc fix.
4100
14af5f7f
CY
41012012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4102
4103 * coding.c (encode_designation_at_bol): Change return value to
4104 EMACS_INT.
4105
0b21c100
CY
41062012-01-25 Chong Yidong <cyd@gnu.org>
4107
4108 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4109
3c2907f7
CY
41102012-01-21 Chong Yidong <cyd@gnu.org>
4111
4112 * floatfns.c (Fcopysign): Make the second argument non-optional,
4113 since nil is not allowed anyway.
4114
959ad23f
AS
41152012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4116
4117 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4118 (send_process): Likewise.
4119
34a02f46
MR
41202012-01-19 Martin Rudalics <rudalics@gmx.at>
4121
4122 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4123 (Vwindow_persistent_parameters): Do not use Qstate.
4124 Rewrite doc-strings.
34a02f46 4125
1259009a 41262012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4127
4128 * character.c (char_width): New function.
70d4fdf6
GM
4129 (Fchar_width, c_string_width, lisp_string_width):
4130 Use char_width (Bug#9496).
25ed9e61 4131
6a6ee00d
MR
41322012-01-16 Martin Rudalics <rudalics@gmx.at>
4133
4134 * window.c (Vwindow_persistent_parameters): New variable.
4135 (Fset_window_configuration, save_window_save): Handle persistent
4136 window parameters.
4137
c85efaf7
EZ
41382012-01-14 Eli Zaretskii <eliz@gnu.org>
4139
4140 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4141 thrashing the stack of the thread. (Bug#9087)
4142
5944709e
PE
41432012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4144
4145 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4146
e71f5d99
EZ
41472012-01-11 Eli Zaretskii <eliz@gnu.org>
4148
4149 * xdisp.c (rows_from_pos_range): Handle the case where the
4150 highlight ends on a newline. (Bug#10464)
4151 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4152 he end column for display of highlight that ends on a newline
4153 before a R2L line.
4154
ce316182
GM
41552012-01-11 Glenn Morris <rgm@gnu.org>
4156
4157 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4158 from load-path also when installation-directory is nil. (Bug#10208)
4159
5b43da69
GM
41602012-01-10 Glenn Morris <rgm@gnu.org>
4161
74cc8ff9
GM
4162 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4163
7d8d6e4e
GM
4164 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4165 Update template values to be closer to their typical values these days.
5b43da69 4166
a0db8d43
EZ
41672012-01-09 Eli Zaretskii <eliz@gnu.org>
4168
4169 * xdisp.c (rows_from_pos_range): Accept additional argument
4170 DISP_STRING, and accept any glyph in a row whose object is that
4171 string as eligible for mouse highlight. Fixes mouse highlight of
4172 display strings from overlays. (Bug#10464)
4173
9a0115ab 41742012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4175
b9110d6a 4176 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4177 * fileio.c (auto_saving_dir_umask): New static var.
4178 (Fmake_directory_internal): Use it.
4179 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4180 creating the directory. The old code temporarily assigns
4181 too-generous permissions to the directory.
4182 (do_auto_save_eh): Clear it.
b9110d6a 4183 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4184 that the var is always cleared.
4185
6c1bd3f3
EZ
41862012-01-07 Eli Zaretskii <eliz@gnu.org>
4187
4188 * search.c (scan_buffer): Pass character positions to
4189 know_region_cache, not byte positions. (Bug#6540)
4190
069d2b50
L
41912012-01-07 LynX <_LynX@bk.ru> (tiny change)
4192
4193 * w32.c (sys_rename): Report EXDEV when rename of a directory
4194 fails because the target is on another logical disk. (Bug#10284)
4195
75bf0d33
DB
41962012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4197
4198 * xterm.c (x_embed_request_focus): New function.
4199
4200 * xterm.h: Add prototype.
4201
4202 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4203
1c6e5a32
GM
42042012-01-05 Glenn Morris <rgm@gnu.org>
4205
4206 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4207
651e947e
EZ
42082012-01-01 Eli Zaretskii <eliz@gnu.org>
4209
4210 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4211 Load gnutls_transport_set_lowat only if GnuTLS version is below
4212 2.11.1.
4213 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4214 GnuTLS versions below 2.11.1.
4215
3778cdd8
AL
42162011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4217
4218 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4219 to the doc string advising against its use for altering the way
4220 windows are scrolled.
4221
0e5317f7
KH
42222011-12-28 Kenichi Handa <handa@m17n.org>
4223
4224 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4225 coding-system ASCII compatible only when it does not produce BOM
4226 on encoding (Bug#10383).
4227
93d5ca1f
JD
42282011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4229
4230 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4231 can scroll.
4232 (create_and_show_popup_menu): Always use menu_position_func for
4233 Gtk3 (Bug#10361).
4234
ca22b785
AS
42352011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4236
4237 * callint.c (Fcall_interactively): Don't truncate prompt string.
4238
d048e1e6
EZ
42392011-12-23 Eli Zaretskii <eliz@gnu.org>
4240
4241 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4242 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4243 resumed from there (after widening). (Bug#10360)
d048e1e6 4244
5ccaba1f
JD
42452011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4246
4247 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4248
204ee57f
JD
42492011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4250
b81d40f0
JB
4251 * nsterm.m (x_free_frame_resources):
4252 Release f->output_data.ns->miniimage.
204ee57f
JD
4253 (ns_index_color): Fix indentation. Do not retain
4254 color_table->colors[i].
4255
4256 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4257 before returning.
4258
4259 * nsfns.m (x_set_background_color): Assign return value from
4260 ns_index_color to face-background instead of NSColor*.
4261 (ns_implicitly_set_icon_type): Fix indentation.
4262 Change assignment in for loop to comparison.
4263
4264 * emacs.c (ns_pool): New variable.
4265 (main): Assign ns_pool.
4266 (Fkill_emacs): Call ns_release_autorelease_pool.
4267
4268 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4269 autorelease fdesc, release fdAttrs and tdict.
4270 (ns_get_covering_families): Release charset.
4271 (ns_findfonts): Release NSFontDescriptor created with new.
4272 (ns_uni_to_glyphs): Fix indentation.
4273 (setString): Release attrStr before assigning new value.
4274
c803b2b7
JD
42752011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4276
678f4426
JD
4277 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4278 and NS_IMPL_COCOA.
4279 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4280 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4281
cd394be1 42822011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4283
5fecd5fc
JD
4284 * nsterm.m (ns_term_init): Subscribe for notifications
4285 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4286 to method trackingNotification in EmacsMenu.
4287
4288 * nsmenu.m (trackingMenu): New variable.
3771cb17 4289 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4290 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4291 from Aquamacs (Bug#7030).
678f4426
JD
4292
42932011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4294
c803b2b7
JD
4295 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4296 (symbol_to_nsstring): Fix indentation.
4297 (ns_symbol_to_pb): New function.
cae07000
SM
4298 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4299 (Fns_rotate_cut_buffers_internal): Remove.
4300 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4301 Fns_store_cut_buffer_internal.
4302 (ns_get_foreign_selection, Fx_own_selection_internal)
4303 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4304 (Fns_get_selection_internal, Fns_store_selection_internal):
4305 Use ns_symbol_to_pb and check if return value is nil.
4306 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4307 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4308 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4309 renamed to Sns_store_selection_internal.
4310 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4311 and remove this function.
4312 (ns_handle_selection_clear): Remove, never used.
4313 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4314 here.
4315
e1b01a3a
KB
43162011-12-17 Ken Brown <kbrown@cornell.edu>
4317
4318 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4319 GID is unknown (Bug#10257).
4320
2adb6e85
PE
43212011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4322
4323 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4324 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4325 which caused a build failure on GNU/Linux IA-64. This problem was
4326 introduced by my 2011-10-07 patch.
4327
d1d7b339
JL
43282011-12-15 Juri Linkov <juri@jurta.org>
4329
4330 * image.c (imagemagick_error): New function. (Bug#10112)
4331 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4332 Use `imagemagick_error' where ImageMagick functions return
4333 `MagickFalse'.
4334 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4335 proper order.
4336
100d5755
KH
43372011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4338
4339 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4340 fill background (Bug#8992).
4341
454592a6
MR
43422011-12-13 Martin Rudalics <rudalics@gmx.at>
4343
4344 * window.c (Vwindow_combination_resize)
4345 (Vwindow_combination_limit): Use t instead of non-nil in
4346 doc-strings.
61d4b438
MR
4347 (Vrecenter_redisplay): Add first sentence of doc-string on
4348 separate line.
53524d93 4349 (Frecenter): Fix doc-string typo.
454592a6 4350
3633e3aa
KH
43512011-12-11 Kenichi Handa <handa@m17n.org>
4352
4353 * coding.c (Funencodable_char_position): Pay attention to the
4354 buffer text relocation (Bug#9389).
4355
7b9d523a 43562011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4357
7b9d523a
JD
4358 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4359 gtk_init (Bug#10100).
4360
b73189c6
EZ
43612011-12-10 Eli Zaretskii <eliz@gnu.org>
4362
4363 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4364 IT->string is nil. (Bug#10263)
4365
f7dfe5d6
JD
43662011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4367
83faebb4
JD
4368 * nsterm.h (x_free_frame_resources): Declare.
4369
f7dfe5d6
JD
4370 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4371 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4372
4373 * nsterm.h (ns_get_defaults_value): Declare.
4374
4375 * nsterm.m (ns_default): Call ns_get_defaults_value.
4376
7cd4e72c
EZ
43772011-12-09 Eli Zaretskii <eliz@gnu.org>
4378
4379 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4380 (Bug#10170)
4381
b34d7317
YM
43822011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4383
4384 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4385 that where the value of an _OBJC_* symbol points to is in the .bss
4386 section (Bug#10240).
4387
76470ad1
KH
43882011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4389
4390 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4391 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4392
745fff94
KH
43932011-12-08 Kenichi Handa <handa@m17n.org>
4394
4395 * ftfont.c (get_adstyle_property): Fix previous change
4396 (Bug#10233).
4397
6e44397c
JB
43982011-12-07 Juanma Barranquero <lekktu@gmail.com>
4399
4400 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4401 dirs from the default value of EMACSLOADPATH (bug#10208).
4402
7efa6272
GM
44032011-12-07 Glenn Morris <rgm@gnu.org>
4404
4405 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4406 installation and source directories as well. (Bug#10208)
4407
f6fc4d87
CY
44082011-12-06 Chong Yidong <cyd@gnu.org>
4409
4410 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4411
2bf26180
GM
44122011-12-06 Glenn Morris <rgm@gnu.org>
4413
4414 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4415 as an error, not just -1. (Bug#10217)
4416
3a6ad4f0
CY
44172011-12-05 Chong Yidong <cyd@gnu.org>
4418
4419 * keyboard.c (process_special_events): New function.
4420 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4421
75a3b399
PE
44222011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4423
4424 * coding.c (encode_designation_at_bol): Don't use uninitialized
4425 local variable (Bug#9318).
4426
c3c9e25e
KH
44272011-12-05 Kenichi Handa <handa@m17n.org>
4428
4429 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4430 return Qnil (Bug#8046, Bug#10193).
4431
5eb05ea3
KH
44322011-12-05 Kenichi Handa <handa@m17n.org>
4433
4434 * coding.c (encode_designation_at_bol): New args charbuf_end and
4435 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4436 (coding_set_source): Return how many bytes coding->source was
4437 relocated.
4438 (coding_set_destination): Return how many bytes
4439 coding->destination was relocated.
4440 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4441 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4442
44432011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4444
4445 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4446 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4447 macro (Bug#9318).
4448
44492011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4450
4451 The following changes are to fix Bug#9318.
4452
a79703f5 4453 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4454 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4455 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4456 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4457
7dbda6df
JB
44582011-12-05 Juanma Barranquero <lekktu@gmail.com>
4459
4460 * lisp.h (process_quit_flag): Fix external declaration.
4461
6d5eb5b0
SM
44622011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4463
4464 Don't macro-inline non-performance-critical code.
4465 * eval.c (process_quit_flag): New function.
4466 * lisp.h (QUIT): Use it.
4467
a0c3fad0
JD
44682011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4469
4470 * nsfns.m (get_geometry_from_preferences): New function.
4471 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4472
6c07aac2
AS
44732011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4474
4475 * emacs.c (Qkill_emacs): Define.
4476 (syms_of_emacs): Initialize it.
4477 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4478 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4479 (quit_throw_to_read_char): Add parameter `from_signal'.
4480 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4481 * lisp.h (QUIT): Call Fkill_emacs if requested.
4482
c052ead4
JD
44832011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4484
4485 * widget.c (update_wm_hints): Return if wmshell is null.
4486 (widget_update_wm_size_hints): New function.
4487
4488 * widget.h (widget_update_wm_size_hints): Declare.
4489
4490 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4491 widget_update_wm_size_hints (Bug#10104).
4492
9e49252b
EZ
44932011-12-03 Eli Zaretskii <eliz@gnu.org>
4494
4495 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4496 before a newline, prepare the bidi iterator for consuming the
4497 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4498 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4499
02b16839
JL
45002011-12-02 Juri Linkov <juri@jurta.org>
4501
4502 * search.c (Fword_search_regexp): New Lisp function created from
4503 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4504 (Fword_search_backward, Fword_search_forward)
4505 (Fword_search_backward_lax, Fword_search_forward_lax):
4506 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4507 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4508
0068070e
SM
45092011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4510
4511 * fileio.c (Finsert_file_contents): Move after-change-function call
4512 to before the "handled:" label, since all "goto handled" appear in
4513 cases where the *-change-functions have already been properly called
4514 (bug#10117).
4515
3360a3fc
AS
45162011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4517
4518 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4519 waiting for input. (Bug#10169)
4520
73d6c093
EZ
45212011-11-30 Eli Zaretskii <eliz@gnu.org>
4522
4523 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4524 verifies glyph row's hash code--we have just reallocated the
4525 glyphs, so their contents can be complete garbage. (Bug#10164)
4526
febe6bea
JB
45272011-11-30 Juanma Barranquero <lekktu@gmail.com>
4528
4529 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4530
801a4313
EZ
45312011-11-30 Eli Zaretskii <eliz@gnu.org>
4532
4533 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4534 attributes are tested _before_ calling verify_row_hash, to protect
4535 against GCC re-ordering of the tests. (Bug#10164)
4536
2b56b87e
JD
45372011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4538
4539 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4540
4541 * xterm.c (handle_one_xevent): Only set async_visible and friends
4542 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4543 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4544 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4545
dbf31225
PE
45462011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4547
4548 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4549 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4550 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4551 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4552 All uses changed to use GCPRO1 etc.
4553 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4554 Revert to old implementation (i.e., before 2011-03-11).
4555
1305621b
YM
45562011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4557
4558 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4559 of scroll runs so as to avoid assigning disabled bogus rows and
4560 unnecessary graphics copy operations.
4561
8c9afb46
EZ
45622011-11-27 Eli Zaretskii <eliz@gnu.org>
4563
4564 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4565 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4566 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4567 (malloc, free, realloc, calloc): Redirect to e_* only when
4568 compiling Emacs.
4569
4570 * lisp.h (GCTYPEBITS): Move before first use.
4571 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4572 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4573 this macro definition.
4574
4575 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4576 _MSC_VER.
4577
54e9e3bf
JD
45782011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4579
6d5eb5b0
SM
4580 * gtkutil.c (xg_create_frame_widgets):
4581 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4582 present with Gtk+ 2.0.
4583
83aca1cb
PE
45842011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4585
4586 * fileio.c (Finsert_file_contents): Undo previous change; see
4587 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4588
5b76caa4
PE
45892011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4590
4591 Rename locals to avoid shadowing.
4592 * fileio.c (Finsert_file_contents):
4593 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4594 * process.c (wait_reading_process_output):
4595 Rename inner 'proc' to 'p' to avoid shadowing.
4596 Indent for consistency with usual Emacs style.
4597
8c535114
EZ
45982011-11-25 Eli Zaretskii <eliz@gnu.org>
4599
4600 * xdisp.c (redisplay_window): If cursor row is not fully visible
4601 after recentering, and scroll-conservatively is set to a large
4602 number, scroll window by a few more lines to make the cursor fully
4603 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4604 (start_display): Don't move to the next line if the display should
4605 start at a newline that is part of a display vector or an overlay
4606 string. (Bug#10119)
8c535114 4607
fa4fdb5c
JL
46082011-11-24 Juri Linkov <juri@jurta.org>
4609
4610 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4611 after the `MagickPingImage' call. (Bug#10112)
4612
90ec88df
CY
46132011-11-23 Chong Yidong <cyd@gnu.org>
4614
4615 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4616
56e2e794
MR
46172011-11-23 Martin Rudalics <rudalics@gmx.at>
4618
4619 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4620 making another buffer current. (Bug#10114)
4621
b6e64c41
GM
46222011-11-23 Glenn Morris <rgm@gnu.org>
4623
4624 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4625
6b21de18
CY
46262011-11-23 Chong Yidong <cyd@gnu.org>
4627
4628 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4629 using it (Bug#5984).
4630
b12cd789
EZ
46312011-11-22 Eli Zaretskii <eliz@gnu.org>
4632
4633 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4634 and header-lines, as they don't have one computed for them.
4635 (Bug#10098)
4636
4637 * .gdbinit (prow): Make displayed values more self-explaining.
4638 Add row's hash code.
4639
261b6fd4
LMI
46402011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4641
4642 * process.c (wait_reading_process_output): Fix asynchrounous
4643 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4644 (wait_reading_process_output): Add comment and URL.
261b6fd4 4645
e7cfd277
JD
46462011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4647
4648 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4649
a9b9b7f5
CY
46502011-11-21 Chong Yidong <cyd@gnu.org>
4651
4652 * window.c (Fnext_window, Fprevious_window): Doc fix.
4653
b0d15b4f
SM
46542011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4655
4656 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4657
fe7a3057
JB
46582011-11-20 Juanma Barranquero <lekktu@gmail.com>
4659
4660 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4661
d2999b1a
MR
46622011-11-20 Martin Rudalics <rudalics@gmx.at>
4663
4664 * window.c (Fset_window_combination_limit): Rename argument
4665 STATUS to LIMIT.
4666 (Vwindow_combination_limit): Remove "status" from doc-string.
4667
d5ff9cd0
AS
46682011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4669
4670 * m/ibms390.h: Remove.
4671 * m/ibms390x.h: Don't include "ibms390.h".
4672
a5bb9bd3
SM
46732011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4674
4675 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4676 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4677
cd1181db
JB
46782011-11-20 Juanma Barranquero <lekktu@gmail.com>
4679
4680 * casetab.c (Fset_case_table):
4681 * charset.c (Fcharset_after): Fix typos.
4682
615a3b8d 46832011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4684
17e845af
PE
4685 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4686 Otherwise, valgrind does not work on some platforms.
4687 Problem reported by Andreas Schwab in
6a0bf43d
PE
4688 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4689 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4690 is set, removing the need for VIRT_ADDRESS_VARIES.
4691 (PURE_P): Use a more-efficient implementation that needs just one
4692 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4693 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4694 to 4 (xorl, subq, cmpq, setbe).
4695 * alloc.c (pure): Always extern now, since that's the
4696 VIRT_ADDR_VARIES behavior.
4697 (PURE_POINTER_P): Use a single comparison, not two, for
4698 consistency with the new puresize.h.
4699 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4700 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4701 Remove VIRT_ADDR_VARIES no longer needed.
4702
f8fe6f96
EZ
47032011-11-19 Eli Zaretskii <eliz@gnu.org>
4704
4705 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4706 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4707 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4708 behave as if the cursor position were at the window margin.
4709
4710 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4711 and the cursor position is out of bounds, behave as if the cursor
4712 position were at the window margin. (Bug#10075)
4713
df05a53c
CY
47142011-11-18 Chong Yidong <cyd@gnu.org>
4715
4716 * window.c (Fwindow_combination_limit): Make first argument
4717 non-optional, since it is meaningless for live windows like the
4718 selected window.
61ccba97 4719
2071918e
DA
47202011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4721
4722 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4723
b50a28de
SM
47242011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4725
4726 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4727 (graft_intervals_into_buffer): Simplify.
4728
015137db
EZ
47292011-11-18 Eli Zaretskii <eliz@gnu.org>
4730
4731 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4732 hash values of the two rows.
4733 (copy_row_except_pointers): Preserve the used[] arrays and the
4734 hash values of the two rows. (Bug#10035)
68c95424 4735 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4736
4737 * xdisp.c (row_hash): New function, body extracted from
4738 compute_line_metrics.
4739 (compute_line_metrics): Call row_hash, instead of computing the
4740 hash code inline.
4741
4742 * dispnew.c (verify_row_hash): Call row_hash for computing the
4743 hash code of a row, instead of duplicating code from xdisp.c.
4744
4745 * dispextern.h (row_hash): Add prototype.
4746
a2addb04
TH
47472011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4748
4749 * frame.c (delete_frame): Don't delete the terminal when the last
4750 X frame is closed if emacs is built with GTK toolkit.
4751
df85d315
JB
47522011-11-17 Juanma Barranquero <lekktu@gmail.com>
4753
4754 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4755
a0c2d0ae
MR
47562011-11-17 Martin Rudalics <rudalics@gmx.at>
4757
4758 * window.c (Vwindow_splits): Rename to
4759 Vwindow_combination_resize. Suggested by Juri Linkov.
4760 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4761 of Vwindow_splits.
4762
58179cce
JB
47632011-11-16 Juanma Barranquero <lekktu@gmail.com>
4764
7877f373
JB
4765 * nsfns.m (Fns_font_name):
4766 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4767
b6f67890
MR
47682011-11-16 Martin Rudalics <rudalics@gmx.at>
4769
4770 * window.h (window): Rename slot "nest" to "combination_limit".
4771 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4772 (Fset_window_nest): Rename to Fset_window_combination_limit.
4773 (Vwindow_nest): Rename to Vwindow_combination_limit.
4774 (recombine_windows, make_parent_window, make_window)
4775 (Fsplit_window_internal, saved_window)
4776 (Fset_window_configuration, save_window_save): Rename all
4777 occurrences of window_nest to window_combination_limit.
4778
c7015153
JB
47792011-11-15 Juanma Barranquero <lekktu@gmail.com>
4780
4781 * image.c (imagemagick_load_image): Fix typo.
4782
322ad6ec
EZ
47832011-11-14 Eli Zaretskii <eliz@gnu.org>
4784
4785 * xdisp.c (display_line): Move the call to
4786 highlight_trailing_whitespace before the call to
4787 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4788 faces of all the glyphs to compute ROW's hash value.
4789 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4790
f067b8ec
JB
47912011-11-14 Juanma Barranquero <lekktu@gmail.com>
4792
4793 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4794 just return (bug#10044).
4795
1e5b2111
EZ
47962011-11-12 Eli Zaretskii <eliz@gnu.org>
4797
7ef3cbd5
EZ
4798 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4799 with user-defined heap size. Bump the default size of the temacs
4800 heap to 27MB, to avoid memory warning when running temacs.
4801 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4802
1e5b2111
EZ
4803 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4804 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4805 (verify_row_hash) [XASSERTS]: New function.
4806 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4807 that the hash value of glyph rows is correct.
1e5b2111 4808
89d61221
MR
48092011-11-12 Martin Rudalics <rudalics@gmx.at>
4810
4811 * window.h (window): Remove splits slot.
4812 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4813 (Fdelete_other_windows_internal, make_parent_window)
4814 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4815 (Fset_window_configuration, save_window_save): Don't deal with
4816 split status of windows.
4817 (saved_window): Remove splits slot.
4818 (Vwindow_splits): Rewrite doc-string.
4819
97f18cc8
JD
48202011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4821
4822 * xfns.c (unwind_create_frame):
4823 * nsfns.m (unwind_create_frame):
4824 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4825 Vframe_list (Bug#9999).
4826
22a648b4
DA
48272011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4828
0b381c7e 4829 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4830
659afede
KH
48312011-11-11 Kenichi Handa <handa@m17n.org>
4832
4833 * callproc.c (Fcall_process): Set the member dst_multibyte of
4834 process_coding.
4835
9ac0394b
KH
48362011-11-11 Johan Bockgård <bojohan@gnu.org>
4837
4838 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4839 avoid a crash (bug#9496).
4840
2fbdc249
CY
48412011-11-09 Chong Yidong <cyd@gnu.org>
4842
4843 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4844 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4845
ac6b1f81
PE
48462011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4847
4848 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4849
09db192c
PE
48502011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4851
4852 Avoid some portability problems by eschewing 'extern inline' functions.
4853 The trivial performance wins aren't worth the portability hassles; see
4854 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4855 et seq.
4856 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4857 (window_box_width, window_box_left, window_box_left_offset)
4858 (window_box_right, window_box_right_offset): Undo previous change,
4859 by removing the "extern"s.
4860 * intervals.c (adjust_intervals_for_insertion)
4861 (adjust_intervals_for_deletion): Undo previous change,
4862 making these static again.
4863 (offset_intervals, temp_set_point_both, temp_set_point)
4864 (copy_intervals_to_string): No longer inline.
4865 * xdisp.c (window_text_bottom_y, window_box_width)
4866 (window_box_height, window_box_left_offset)
4867 (window_box_right_offset, window_box_left, window_box_right)
4868 (window_box): No longer inline.
4869
105216ed
CY
48702011-11-08 Chong Yidong <cyd@gnu.org>
4871
4872 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4873 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4874 Signal an error if not a live window.
105216ed
CY
4875 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4876 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4877
ae9e237f
JB
48782011-11-07 Juanma Barranquero <lekktu@gmail.com>
4879
4880 * lisp.h (syms_of_abbrev): Remove declaration.
4881 Reported by CHENG Gao <chenggao@royau.me>.
4882
c7aa8333
EZ
48832011-11-07 Eli Zaretskii <eliz@gnu.org>
4884
4885 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4886 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4887 of temacs in GUI mode.
4888
be7f5545
MR
48892011-11-07 Martin Rudalics <rudalics@gmx.at>
4890
4891 * window.h: Declare delete_all_child_windows instead of
4892 delete_all_subwindows.
4893 * window.c (Fwindow_nest, Fset_window_nest)
4894 (Fset_window_new_total, Fset_window_new_normal)
4895 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4896 (delete_all_subwindows): Rename to delete_all_child_windows.
4897 (Fdelete_other_windows_internal, Fset_window_configuration):
4898 Call delete_all_child_windows instead of delete_all_subwindows.
4899 * frame.c (delete_frame): Call delete_all_child_windows instead
4900 of delete_all_subwindows.
4901
ca78dc43
PE
49022011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4903
4904 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4905 This is also needed for porting to any host where GC_MARK_STACK is
4906 not GC_MAKE_GCPROS_NOOPS.
4907 (which_symbols): Use it.
4908
a0241d01
KH
49092011-11-07 Kenichi Handa <handa@m17n.org>
4910
4911 * coding.c (coding_set_destination): Check coding->src_pos only
4912 when coding->src_object is a buffer (bug#9910).
4913
4914 * process.c (send_process): Set the member src_multibyte of coding
4915 to 0 (bug#9911) when sending a unibyte text.
4916
4917 * callproc.c (Fcall_process): Set the member src_multibyte of
4918 process_coding to 0 (bug#9912).
4919
a64bfdfa 49202011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4921
4922 * xmenu.c (cleanup_widget_value_tree): New function.
4923 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4924 calling free_menubar_widget_value_tree directly (Bug#9830).
4925
cb41b32a
PE
49262011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4927
4928 Fix some portability problems with 'inline'.
4929 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4930 (window_box_width, window_box_left, window_box_left_offset)
4931 (window_box_right, window_box_right_offset): Declare extern.
4932 Otherwise, these inline functions do not conform to C99 and
4933 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4934 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4935 * intervals.c (adjust_intervals_for_insertion)
4936 (adjust_intervals_for_deletion): Now extern, because otherwise the
4937 extern inline functions 'offset_intervals' couldn't refer to it.
4938 (static_offset_intervals): Remove.
4939 (offset_intervals): Rewrite using the old contents of
4940 static_offset_intervals. The old version didn't conform to C99
4941 because an extern inline function contained a reference to an
4942 identifier with static linkage.
4943
b7041366
AS
49442011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4945
4946 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4947 GC.
4948
88a37c4d
EZ
49492011-11-06 Eli Zaretskii <eliz@gnu.org>
4950
4951 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4952 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4953 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4954 return Qleft_to_right.
4955
49745b39
CY
49562011-11-06 Chong Yidong <cyd@gnu.org>
4957
4958 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4959 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4960 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4961 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4962 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4963 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4964 (Fwindow_vscroll): Doc fix.
4965 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4966 argument, since it makes no sense to pass a live window and for
4967 consistency with window-child.
4968
1f05cd82
CS
49692011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4970
4971 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4972 support MSVC.
4973
22610910
JR
49742011-11-05 Jason Rumney <jasonr@gnu.org>
4975
4976 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4977 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4978 fonts (Bug#6029).
4979 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4980 bitwise arithmetic preventing use of unicode-sip and non-truetype
4981 opentype fonts.
4982
a06776b2
EZ
49832011-11-05 Eli Zaretskii <eliz@gnu.org>
4984
3ad924ba
EZ
4985 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4986 "emacs"-only part.
4987
a06776b2
EZ
4988 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4989 initialization code to keep similarity to xfns.c after changes
4990 from 2011-11-05.
4991
c9e7db78
JD
49922011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4993
a97f8f3f
JD
4994 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4995 (unwind_create_frame): New function (Bug#9943).
4996 (Fx_create_frame): Restructure code to be more similar to the one in
4997 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4998 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4999 Move terminal->reference_count++ just before making the frame official
5000 (Bug#9943).
5001
5002 * nsterm.m (x_free_frame_resources): New function.
5003 (x_destroy_window): Move code to x_free_frame_resources.
5004
c9e7db78 5005 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5006 (Fx_create_frame, x_create_tip_frame):
5007 Move terminal->reference_count++ just before making the frame
75f1671a 5008 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5009 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5010
a6fc3b5c
EZ
50112011-11-05 Eli Zaretskii <eliz@gnu.org>
5012
5013 Support MSVC build with newer versions of Visual Studio.
5014 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5015 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5016 nt/gmake.defs.
5017
5018 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5019 which are not supported by MSVC.
5020 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5021 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5022 bitfields.
5023 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5024 types in bitfields.
5025 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5026
5027 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5028
58179cce 50292011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5030
5031 Support MSVC build with newer versions of Visual Studio.
5032 * w32.c: Don't include w32api.h for MSVC.
5033 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5034
5035 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5036 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5037 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5038 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5039 e_* cousins.
5040 (alloca) [_MSC_VER]: Define to _alloca.
5041
5042 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5043
5044 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5045
a58c13ed
EZ
50462011-11-04 Eli Zaretskii <eliz@gnu.org>
5047
5048 * xdisp.c (note_mouse_highlight): If either of
5049 previous/next-single-property-change returns nil, treat that as
5050 the beginning or the end of the buffer. (Bug#9955)
5051
fe0b6370
JD
50522011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5053
a58c13ed 5054 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5055 label is not null (Bug#9951).
5056 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5057 may be NULL.
5058
89bd5ee1
EZ
50592011-11-04 Eli Zaretskii <eliz@gnu.org>
5060
5061 * window.c (Fwindow_body_size): Mention in the doc string that the
5062 return value is in frame's canonical units. (Bug#9949)
5063
84c3edb9
EZ
50642011-11-03 Eli Zaretskii <eliz@gnu.org>
5065
4e2fb5c7
EZ
5066 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5067
84c3edb9 5068 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5069 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5070 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5071
bc17a887
EZ
50722011-11-01 Eli Zaretskii <eliz@gnu.org>
5073
5074 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5075 Don't stop backward scan on the continuation glyph, even though
5076 its CHARPOS is positive.
6d5eb5b0
SM
5077 (mouse_face_from_buffer_pos, note_mouse_highlight):
5078 Rename cover_string to disp_string.
bc17a887 5079
4ee88440
MR
50802011-11-01 Martin Rudalics <rudalics@gmx.at>
5081
5082 * window.c (temp_output_buffer_show): Don't use
5083 Vtemp_buffer_show_specifiers.
5084 (Vtemp_buffer_show_specifiers): Remove unused variable.
5085
c2ff3c02
EZ
50862011-10-30 Eli Zaretskii <eliz@gnu.org>
5087
5088 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5089 past the beginning of the current glyph matrix.
5090
58179cce 50912011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5092
5093 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5094 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5095 HAVE_GTK3 (Bug#9869).
b77a6a7f 5096
3b574623
JD
5097 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5098 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5099
b77a6a7f
JD
5100 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5101
5102 * xterm.c: Declare x_handle_net_wm_state to return int.
5103 (handle_one_xevent): Check if we are iconified but don't have
5104 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5105 (get_current_wm_state): Return non-zero if not hidden,
5106 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5107 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5108 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5109 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5110
196e41e4
PE
51112011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5112
5113 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5114 so that this new function doesn't get optimized away by a
5115 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5116
021f2e1a
AS
51172011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5118
5119 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5120
8b058d44
EZ
51212011-10-29 Eli Zaretskii <eliz@gnu.org>
5122
5123 Fix the `xbytecode' command.
5124 * .gdbinit (xprintbytestr): New command.
b50a28de 5125 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5126 (xbytecode): Print the byte-code string as well.
5127
4452fb80
EZ
51282011-10-29 Kim Storm <storm@cua.dk>
5129
8b058d44
EZ
5130 * alloc.c (which_symbols): New function.
5131
21b72067
AS
51322011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5133
5134 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5135 line. (Bug#9903)
5136
83ed7b5c
GM
51372011-10-29 Glenn Morris <rgm@gnu.org>
5138
5139 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5140 Not clear what it was for, and it causes various bugs. (Bug#9839)
5141
5a7a728b
EZ
51422011-10-28 Eli Zaretskii <eliz@gnu.org>
5143
5144 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5145 possible random value that matches one of those tested as
5146 condition to clear the mouse face.
5147
d3d0842f
CY
51482011-10-28 Chong Yidong <cyd@gnu.org>
5149
5150 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5151
31b39d13
DN
51522011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5153
5154 * window.c (make_window): Initialize phys_cursor_on_p.
5155
9aba6043
SM
51562011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5157
5158 * lisp.h (struct Lisp_Symbol): Update comments.
5159
c20992f4
JB
51602011-10-28 Juanma Barranquero <lekktu@gmail.com>
5161
5162 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5163
db4f02f2
EZ
51642011-10-28 Eli Zaretskii <eliz@gnu.org>
5165
5166 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5167 <oslsachem@gmail.com> for helping to debug this.
5168
5169 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5170 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5171 (g_b_init_get_glyph_outline_w): New static variables.
5172 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5173 (GetGlyphOutlineW_Proc): New typedefs.
5174 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5175 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5176 New functions.
5177 (w32font_open_internal, compute_metrics):
5178 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5179 instead of calling the "wide" APIs directly.
5180
5181 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5182
5183 * w32.h (syms_of_w32font): Add prototype.
5184
87e68db4
JB
51852011-10-27 Juanma Barranquero <lekktu@gmail.com>
5186
5187 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5188 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5189 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5190 (Fmove_to_window_line): Doc fix.
5191
435c1d67
CY
51922011-10-27 Chong Yidong <cyd@gnu.org>
5193
5194 * process.c (make_process): Set gnutls_state to NULL.
5195
5196 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5197 non-NULL, regardless of GNUTLS_INITSTAGE.
5198 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5199 an error. Set process slots as soon as we allocate them.
5200
5201 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5202
9c6c6f49
CY
52032011-10-27 Chong Yidong <cyd@gnu.org>
5204
9aba6043
SM
5205 * gnutls.c (emacs_gnutls_deinit): New function.
5206 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5207 (Fgnutls_deinit, Fgnutls_boot): Use it.
5208
5209 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5210 (deactivate_process): Call emacs_gnutls_deinit.
5211
657d08d3
JB
52122011-10-27 Juanma Barranquero <lekktu@gmail.com>
5213
5214 * image.c (x_create_x_image_and_pixmap):
5215 * w32.c (sys_rename, w32_delayed_load):
5216 * w32font.c (fill_in_logfont):
5217 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5218
5430d399
JB
52192011-10-26 Juanma Barranquero <lekktu@gmail.com>
5220
5221 * w32fns.c (w32_default_color_map): New function,
5222 extracted from Fw32_default_color_map.
a7ef684b 5223 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5224
fe0055fa
PE
52252011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5226
5227 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5228
e6346438
SM
52292011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5230
5231 * keyboard.c (test_undefined): New function (bug#9751).
5232 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5233
e112cc37
ET
52342011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5235
5236 * sysdep.c (init_sys_modes): Fix the check for the controlling
5237 terminal (Bug#6649).
5238
7b5d6677
EZ
52392011-10-20 Eli Zaretskii <eliz@gnu.org>
5240
5241 * dispextern.h (struct bidi_it): New member next_en_type.
5242
5243 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5244 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5245 current character, check also for next_en_type being WEAK_EN.
5246 (bidi_resolve_weak): Don't enter the expensive loop if the current
5247 position is before next_en_pos. Record the bidi type of the first
5248 non-ET, non-BN character we find, in addition to its position.
5249 (bidi_level_of_next_char): Invalidate next_en_type when
5250 next_en_pos is over-stepped.
5251
7da0b018
PE
52522011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5253
5254 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5255 * editfns.c: Rewrite current-time-zone so that it invokes
5256 the equivalent of (format-time-string "%Z") to get the time zone name.
5257 This fixes a bug when the time zone name contains characters that
5258 need converting from the system time locale to Emacs internal format.
5259 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5260 that patch fixed format-time-string to do the conversion, but
5261 I forgot to fix current-time-zone.
5262 (format_time_string): New function, containing most of
5263 what Fformat_time_string used to contain.
5264 (Fformat_time_string): Rewrite in terms of format_time_string.
5265 This doesn't change this function's behavior.
5266 (current-time-zone): Rewrite to use format_time_string.
5267 This fixes the bug reported by Michael Schierl in
5268 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5269 Jason Rumney's 2007-06-07 change worked around this bug, but
5270 didn't fix it.
5271 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5272
8547b010
EZ
52732011-10-19 Eli Zaretskii <eliz@gnu.org>
5274
5275 * xdisp.c (start_display): If the character at POS is displayed
5276 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5277 (try_window_reusing_current_matrix): If a line ends in a display
5278 vector or the next line starts in a display vector, continue
5279 redrawing the window even though the character position of
5280 start_row was reached.
8547b010
EZ
5281 (Bug#9771, part 2)
5282
4e948d15
CY
52832011-10-18 Chong Yidong <cyd@gnu.org>
5284
5285 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5286 with nobreak-char-display too.
5287
4787455f
EZ
52882011-10-18 Eli Zaretskii <eliz@gnu.org>
5289
5290 Fix part 3 of bug#9771.
5291 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5292 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5293 non-neutral characters if the current character is a paragraph
5294 separator (a.k.a. Newline). This avoids running the same
5295 expensive loop twice, once when we consume the preceding newline
5296 and the other time when the line actually needs to be displayed.
5297 Avoid the loop when we see neutrals on the base embedding level
5298 following a character whose directionality is the same as the
5299 paragraph's. This avoids running the expensive loop when a line
5300 ends in a long sequence of neutrals, like control characters.
5301 Add assertion against STRONG_AL type. Slightly rearrange code
5302 that determines the type of a neutral given the first non-neutral
5303 that follows it.
5304 (bidi_level_of_next_char): Set next_en_pos to zero when
5305 invalidating its info.
5306
2c91f553
EZ
53072011-10-17 Eli Zaretskii <eliz@gnu.org>
5308
5309 * xdisp.c (push_display_prop): Determine whether to record string
5310 or buffer position by IT->string, not by IT->method. Allow
5311 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5312 (move_it_vertically_backward): Don't look for character position
5313 immediately after the newline when in a continuation line.
5314 (Bug#9771, part 1)
2c91f553 5315
c7b08b0d
MR
53162011-10-15 Martin Rudalics <rudalics@gmx.at>
5317
5318 * window.c (coordinates_in_window): Rewrite and delabelize
5319 vertical border check. (Bug#5357) (Bug#9618)
5320
6b02f655
SM
53212011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5322
5323 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5324 errors in XSetWindowBorder (bug#9310).
5325
81d40c92
DA
53262011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5327
5328 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5329 avoid crash when xmalloc overrun checking is enabled.
5330
d4172c3b
EZ
53312011-10-13 Eli Zaretskii <eliz@gnu.org>
5332
5333 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5334 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5335 cursor motion with <left> and <right> arrow keys.
5336
5337 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5338 some callers set that themselves.
5339
b00eea75
EZ
53402011-10-12 Eli Zaretskii <eliz@gnu.org>
5341
5342 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5343 display string and the previous row comes from the same string and
5344 is empty. (Bug#9739) (Bug#9738)
5345
8fe012c4
SM
53462011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5347
5348 * doc.c (get_doc_string): Encode file name (bug#9735).
5349
0074aef2
EZ
53502011-10-12 Eli Zaretskii <eliz@gnu.org>
5351
79beb178
EZ
5352 * bidi.c (bidi_level_of_next_char):
5353 * xdisp.c (get_visually_first_element): Remove old incorrect
5354 comments regarding the Unicode Line Separator character.
5355
0074aef2
EZ
5356 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5357
6e4b3fbe
DA
53582011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5359
5360 * alloc.c (Fgc_status): Do not access beyond zombies array
5361 boundary if nzombies > MAX_ZOMBIES.
5362 * alloc.c (dump_zombies): Add missing format specifier.
5363
0324f3af
PE
53642011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5365
b5525cac
PE
5366 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5367 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5368
0324f3af
PE
5369 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5370 Some packages use them to denote characters with modifiers.
5371
e9b5f888
AS
53722011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5373
5374 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5375 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5376 matching a pp-number. Rename parameter var to var1.
5377
127827c0
SM
53782011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5379
5380 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5381
c8fd3bd0
GM
53822011-10-08 Glenn Morris <rgm@gnu.org>
5383
5384 * callint.c (Fcall_interactively): Give a more explicit error for the
5385 'c' case with a non-character input. (Bug#8479)
5386
352ec8ff
EZ
53872011-10-08 Eli Zaretskii <eliz@gnu.org>
5388
03669ccb
EZ
5389 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5390 lines.
7061c986
EZ
5391 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5392 lines that are hscrolled on the left.
03669ccb 5393
352ec8ff
EZ
5394 * dispnew.c (buffer_posn_from_coords): Account for a possible
5395 presence of header-line. (Bug#4426)
5396
a66cfb1c
SM
53972011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5398
6b02f655
SM
5399 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5400 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5401
7c5ee88e
PE
54022011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5403
5404 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5405 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5406 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5407 this makes Emacs dump core during garbage collection on rare
5408 occasions. sizeof is obviously inferior to offsetof here, so
5409 stick with offsetof.
5410 (GC_POINTER_ALIGNMENT): New macro.
5411 (mark_memory): Omit 3rd (offset) arg; caller changed.
5412 Don't assume EMACS_INT alignment is the same as pointer alignment.
5413
df1bbe5b
SM
54142011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5415
5416 * keyboard.c (read_key_sequence_remapped): New var.
5417 (read_key_sequence): Compute remapping in the right buffer.
5418 (command_loop_1): Use read_key_sequence's remapping directly.
5419
51553db6
SM
54202011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5421
32c1fffd
SM
5422 * dired.c (file_name_completion): Don't expand file name.
5423 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5424 before checking file name handler.
5425
51553db6
SM
5426 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5427 they've been requested explicitly (bug#9591).
5428
b6bd1599 54292011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5430
5431 * keymap.c (Fsingle_key_description): Use make_specified_string
5432 instead of build_string to build string from push_key_description.
5433 (Bug#5193)
5434
f701dc2a
PE
54352011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5436
4222c55d
PE
5437 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5438 This fixes a Y2038 bug on 64-bit hosts.
5439 * buffer.c (reset_buffer):
5440 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5441 (Fclear_buffer_auto_save_failure):
5442 Use 0, not -1, to represent an unset failure time, since time_t
5443 might not be signed.
5444
f701dc2a
PE
5445 Remove dependency on glibc malloc internals.
5446 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5447 Move back here from lisp.h, but with their new implementations.
5448 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5449 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5450 * charset.c (charset_table_init): New static var.
5451 (syms_of_charset): Use it instead of xmalloc. This removes a
5452 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5453 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5454 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5455 Move back to alloc.c.
5456 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5457 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5458
9ceebf39
JD
54592011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5460
5461 * nsterm.m (windowDidResize): Call x_set_window_size only when
5462 ns_in_resize is true. Otherwise set pixelwidth/height and
5463 call change_frame_size (Bug#9628).
5464
cb993c58
PE
54652011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5466
3930c88b
PE
5467 Port --enable-checking=all to Fedora 14 x86-64.
5468 * charset.c (syms_of_charset): Also account for glibc malloc's
5469 internal overhead when calculating the initial malloc maximum.
5470
cb993c58
PE
5471 Port --enable-checking=all to Fedora 14 x86.
5472 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5473 Move to lisp.h.
5474 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5475 (overrun_check_realloc, overrun_check_free):
5476 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5477 That way, xmalloc returns a properly-aligned pointer even if
5478 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5479 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5480 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5481 into account when calculating the initial malloc maximum.
5482 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5483 Move here from alloc.c, so that charset.c can use it too.
5484 Properly align; the old code wasn't right for common 32-bit hosts
5485 when configured with --enable-checking=all.
5486 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5487 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5488
31bed486
EZ
54892011-09-29 Eli Zaretskii <eliz@gnu.org>
5490
04c70788 5491 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5492 use EDOM.
5493
fbcaa2f3
EZ
54942011-09-28 Eli Zaretskii <eliz@gnu.org>
5495
5496 * xdisp.c (compute_display_string_end): If there's no display
5497 string at CHARPOS, return -1.
5498
5499 * bidi.c (bidi_fetch_char): When compute_display_string_end
5500 returns a negative value, treat the character as a normal
5501 character not covered by a display string. (Bug#9624)
5502
a239d4e9
JB
55032011-09-28 Juanma Barranquero <lekktu@gmail.com>
5504
5505 * lread.c (Fread_from_string): Fix typo in docstring.
5506
88652fd5
EZ
55072011-09-27 Eli Zaretskii <eliz@gnu.org>
5508
5509 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5510 newline, reseat the iterator instead of bidi-iterating there one
5511 character at a time. (Bug#9610)
32c1fffd
SM
5512 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5513 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5514
ed497dd4
AS
55152011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5516
5517 * lread.c (readevalloop): Use correct code for NBSP.
5518 (read1): Likewise. (Bug#9608)
5519
b2bf61aa
MA
55202011-09-25 Michael Albinus <michael.albinus@gmx.de>
5521
5522 * dbusbind.c (Fdbus_register_signal): When service is not
5523 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5524
32bbb17c
GM
55252011-09-25 Glenn Morris <rgm@gnu.org>
5526
5527 * buffer.c (truncate-lines): Doc fix.
5528
94e0933e
CY
55292011-09-24 Chong Yidong <cyd@stupidchicken.com>
5530
5531 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5532 (Fset_window_next_buffers): Doc fix.
5533
cddde921
GM
55342011-09-24 Glenn Morris <rgm@gnu.org>
5535
5536 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5537
1260aef1
PE
55382011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5539
25b4bfa0
PE
5540 Fix minor problems found by static checking.
5541 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5542 * indent.c (Fvertical_motion): Fix == vs = typo.
5543
e3cbd34b
EZ
55442011-09-24 Eli Zaretskii <eliz@gnu.org>
5545
a66cfb1c
SM
5546 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5547 Default value is now t. Doc fix.
6bf7006f 5548
e3cbd34b 5549 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5550 logic when moving up, not only when moving down. Fix the
e3cbd34b 5551 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5552 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5553
5554 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5555 CHARPOS is covered by a display string which includes newlines.
5556 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5557 is covered by a display string with embedded newlines.
5558
a3de0cbd
MA
55592011-09-24 Michael Albinus <michael.albinus@gmx.de>
5560
5561 * dbusbind.c (Fdbus_register_signal): Add match rule to
5562 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5563 (Fdbus_register_method, Vdbus_registered_objects_table):
5564 Fix docstring.
a3de0cbd 5565
b260039d
JM
55662011-09-24 Jim Meyering <meyering@redhat.com>
5567
32c1fffd 5568 do not ignore write error for any output size
b260039d
JM
5569 The previous change was incomplete.
5570 While it makes emacs --batch detect the vast majority of stdout
5571 write failures, errors were still ignored whenever the output size is
5572 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5573 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5574 && echo FAIL: ignored write error
5575 FAIL: ignored write error
5576 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5577 && echo FAIL: ignored write error
5578 FAIL: ignored write error
5579 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5580
8eca8a7c
AS
55812011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5582
5583 * emacs.c (Fkill_emacs): In noninteractive mode exit
5584 non-successfully if a write error occurred on stdout. (Bug#9574)
5585
3341db62
EZ
55862011-09-21 Eli Zaretskii <eliz@gnu.org>
5587
5588 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5589 the xassert test.
5590
5591 * dispextern.h (struct it): Update the comment documenting what
5592 can it->OBJECT be.
5593
8c203dbf
EZ
55942011-09-20 Eli Zaretskii <eliz@gnu.org>
5595
5596 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5597 a display string, extend search for cursor position to end of row.
5598 (find_row_edges): If the row ends in a newline from a display
5599 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5600 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5601 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5602 non-empty line. Fixes confusing cursor motion with arrow keys at
5603 the beginning of a line that starts with whitespace.
8c203dbf 5604
a4824228
LMI
56052011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5606
5607 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5608 (bug#9493).
5609
33ed493b
CY
56102011-09-18 Chong Yidong <cyd@stupidchicken.com>
5611
5612 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5613 boolean (Bug#9154).
5614
56cd55c8
EZ
56152011-09-18 Eli Zaretskii <eliz@gnu.org>
5616
5617 * xdisp.c (display_line): Record maximum and minimum buffer
5618 positions even if no glyphs were produced (e.g., by a zero-width
5619 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5620 buffer positions that will be removed from the glyph row because
5621 they don't fit.
c02dcedf
EZ
5622 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5623 column is beyond frame width: don't subtract 1 "pixel" when
5624 computing width of the stretch.
3e62b7e0
EZ
5625 (reseat_at_next_visible_line_start): Undo the change made on
5626 2011-09-17 that saved paragraph information and restored it after
5627 the call to `reseat'. (Bug#9545)
56cd55c8 5628
5ed99d36 56292011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5630
5631 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5632 and turn window cursor on if cleared (Bug#9415).
5633
5ed99d36 56342011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5635
5636 * search.c (boyer_moore): Take unibyte characters from pattern
5637 literally. (Bug#9458)
5638
9bade7b2
EZ
56392011-09-18 Eli Zaretskii <eliz@gnu.org>
5640
5641 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5642
e5e9d610
PE
56432011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5644
87e4427a
PE
5645 Fix minor problem found by static checking.
5646 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5647 initialized, to pacify gcc -Wuninitialized.
5648
e5e9d610
PE
5649 * fileio.c: Report proper errno when syscall falls.
5650 (Finsert_file_contents): Save and restore errno,
5651 so that report_file_error outputs the correct diagnostic.
5652 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5653
a1674f0b
EZ
56542011-09-18 Eli Zaretskii <eliz@gnu.org>
5655
5656 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5657
fbfb6dd4
EZ
56582011-09-17 Eli Zaretskii <eliz@gnu.org>
5659
5660 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5661 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5662
bb187662
EZ
56632011-09-17 Eli Zaretskii <eliz@gnu.org>
5664
1137e8b8 5665 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5666 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5667
5668 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5669 (bidi_find_paragraph_start): Search back for paragraph beginning
5670 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5671 (bidi_move_to_visually_next): Only trigger paragraph-related
5672 computations when the last character is a newline or at EOB, not
5673 just any NEUTRAL_B. (Bug#9470)
5674
bb187662
EZ
5675 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5676 truncated lines if point is covered by a display string. (Bug#9524)
5677
2e621251
PE
56782011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5679
5680 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5681 (cons_to_x_long): New function.
5682 (lisp_data_to_selection_data): Use it. Correct the test for
5683 short-versus-long data; it was negated. Break out of vector
5684 loop, for efficiency, when a long datum is discovered.
5685
91a15bc6
SM
56862011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5687
5688 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5689
b41c3a35
EZ
56902011-09-16 Eli Zaretskii <eliz@gnu.org>
5691
5692 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5693 GCC PR/17406) by declaring this function with external scope.
5694
7812ba2d
PE
56952011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5696
5697 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5698 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5699
cf7edc2a
AS
57002011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5701
5702 * editfns.c (Fformat): Correctly handle text properties on "%%".
5703
bd01620e
EZ
57042011-09-15 Eli Zaretskii <eliz@gnu.org>
5705
5706 * xterm.c (x_draw_composite_glyph_string_foreground):
5707 * w32term.c (x_draw_composite_glyph_string_foreground):
5708 * term.c (encode_terminal_code):
5709 * composite.c (composition_update_it, get_composition_id):
5710 * xdisp.c (get_next_display_element)
5711 (fill_composite_glyph_string): Add comments about special meaning
5712 of TAB characters in a composition.
5713
a02719a3
PE
57142011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5715
5716 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5717 This occurs when processing a multibyte format.
5718 Problem reported by Wolfgang Jenker.
a02719a3 5719
72589a3c
JB
57202011-09-15 Johan Bockgård <bojohan@gnu.org>
5721
5722 * xdisp.c (try_cursor_movement): Only check for exact match if
5723 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5724
1c14176c
PE
57252011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5726
5727 Remove unused external symbols.
5728 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5729 * xdisp.c (calc_pixel_width_or_height): Now static.
5730 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5731 * indent.c (check_display_width):
5732 * w32term.c: Fix comment to match code.
5733 * xterm.c, xterm.h (x_catching_errors): Remove.
5734
d2eea5b5
PE
57352011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5736
5737 * xselect.c: Use signed conversions more consistently (Bug#9498).
5738 (selection_data_to_lisp_data): Assume incoming selection data are
5739 signed integers, not unsigned. This is to be consistent with
5740 outgoing selection data, which was modified to use signed integers
5741 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5742 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5743 expects long, not unsigned long.
5744
46888499
EZ
57452011-09-14 Eli Zaretskii <eliz@gnu.org>
5746
5747 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5748 computation of loop end. Reported by Johan Bockgård
5749 <bojohan@gnu.org>.
5750
ef8ef9fb
CY
57512011-09-13 Chong Yidong <cyd@stupidchicken.com>
5752
5753 * frame.c (Fother_visible_frames_p): Function deleted.
5754
fa819fed
EZ
57552011-09-12 Eli Zaretskii <eliz@gnu.org>
5756
5757 * indent.c (compute_motion): Process display vector front to back
5758 rather than the other way around. (Bug#2496)
5759
2ba8e008
SM
57602011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5761
5762 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5763
20f53c69
CY
57642011-09-11 Chong Yidong <cyd@stupidchicken.com>
5765
5766 * minibuf.c (Fread_from_minibuffer): Doc fix.
5767
d562d7a4
EZ
57682011-09-11 Eli Zaretskii <eliz@gnu.org>
5769
5770 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5771 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5772
1c4d7f3d
LMI
57732011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5774
5775 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5776 value for non-existent files.
5777
b885bf36
EZ
57782011-09-11 Eli Zaretskii <eliz@gnu.org>
5779
5780 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5781 set its "size" to -1. This will set the modtime_size field of
5782 the corresponding buffer to -1, which is what
5783 verify-visited-file-modtime expects for files that do not exist.
5784 (Bug#9139)
5785
6612f0bf
PE
57862011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5787
5788 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5789 here ...
5790 * lisp.h: ... from here. push_key_description is no longer
5791 defined in keyboard.c, so its declaration should not be in
5792 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5793 logically belongs with push_key_description.
5794
dfb3f755
PE
57952011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5796
5797 * buffer.h: Include <sys/types.h> instead of <time.h>.
5798 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5799 Problem reported by Herbert J. Skuhra.
5800
3134906c
LMI
58012011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5802
5803 * xml.c (parse_region): Make the parsing work for
5804 non-comment-starting XML files again (bug#9144).
5805
8d903f4e
AS
58062011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5807
5808 * image.c (gif_load): Fix calculation of bottom and right corner.
5809 (Bug#9468)
5810
80ad64f4
EZ
58112011-09-10 Eli Zaretskii <eliz@gnu.org>
5812
5813 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5814 redisplay in small windows.
5815
208a048d
EZ
58162011-09-09 Eli Zaretskii <eliz@gnu.org>
5817
5818 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5819
9b1c252e
MR
58202011-09-08 Martin Rudalics <rudalics@gmx.at>
5821
5822 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5823 Operate on live windows only.
5824
2949f33b
JB
58252011-09-08 Juanma Barranquero <lekktu@gmail.com>
5826
5827 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5828
e08dcafd
EZ
58292011-09-07 Eli Zaretskii <eliz@gnu.org>
5830
5831 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5832 only under bidi iteration.
5833
115b96bd
JD
58342011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5835
5836 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5837
c8199d0f
PE
58382011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5839
5840 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5841 Without this fix, the command to link temacs failed due to an
5842 undefined symbol __builtin_isnan. This is because
5843 /usr/include/iso/math_c99.h #defines isnan(x) to
5844 __builtin_isnan(x), but the bundled gcc, which identifies itself
5845 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5846 a __builtin_isnan.
5847 * floatfns.c (isnan): #undef, and then #define to a clone of
5848 what's in data.c.
5849 (Fisnan): Always define, since it's always available now.
5850 (syms_of_floatfns): Always define isnan at the Lisp level.
5851
e39b275c 58522011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5853
5854 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5855
b2db44d9 58562011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5857
f4af5137 5858 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5859 The previous code assumed that file offsets (off_t values) fit in
5860 EMACS_INT variables, which is not true on typical 32-bit hosts.
5861 The code messed up by falsely reporting buffer overflow in cases
5862 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5863 when "big" contains more than 2**29 bytes, even though this
5864 inserts just one byte and does not overflow the buffer.
5865 (Finsert_file_contents): Store file offsets as off_t
5866 values, not as EMACS_INT values. Check for overflow when
5867 converting between EMACS_INT and off_t. When checking for
5868 buffer overflow or for overlap, take the offsets into account.
5869 Don't use EMACS_INT for small values where int suffices.
5870 When checking for overlap, fix a typo: ZV was used where
5871 ZV_BYTE was intended.
5872 (Fwrite_region): Don't assume off_t fits into 'long'.
5873 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5874
ecfc0a49
MA
58752011-09-05 Michael Albinus <michael.albinus@gmx.de>
5876
5877 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5878
6511acf2 58792011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5880
0999621a 5881 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5882
5883 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5884 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5885 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5886 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5887 (modify_event_symbol): Do not assume that the length of
5888 name_alist_or_stem is safe to alloca and fits in int.
5889 (Fexecute_extended_command): Likewise for function name and binding.
5890 (Frecursion_depth): Wrap around reliably on integer overflow.
5891 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5892 since some callers pass EMACS_INT values.
5893 (Fsingle_key_description): Don't crash if symbol name contains more
5894 than MAX_ALLOCA bytes.
5895 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5896 (get_minibuffer): Arg is now EMACS_INT, not int.
5897 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5898 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5899 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5900
2be7d702
PE
5901 * dbusbind.c (signature_cat): New function.
5902 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5903 Do not overrun buffer; instead, report string overflow.
5904
9d1df220
PE
5905 * dispnew.c (add_window_display_history): Don't overrun buffer.
5906 Truncate instead; this is OK since it's just a log.
5907
33ef5c64
PE
5908 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5909 even if the time zone offset is outlandishly large.
5910 Don't mishandle offset == INT_MIN.
5911
66c6fdd5
PE
5912 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5913 when creating daemon; the previous buffer-overflow check was incorrect.
5914
d749b01b
PE
5915 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5916 which has the guts of the old verror function.
5917
b5cd1905
PE
5918 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5919 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5920
6e1a67fb
PE
5921 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5922 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5923 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5924 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5925 length of string rather than counting it via multiple sprintfs;
5926 that's simpler and more reliable.
c21721cc
PE
5927 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5928 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5929 sprintf, in case result does not fit in int.
5930
c57b67fc
PE
5931 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5932 (fontset_from_font): Print it.
5933
8a401434
PE
5934 * frame.c (tty_frame_count): Now printmax_t, not int.
5935 (make_terminal_frame, set_term_frame_name): Print it.
5936 (x_report_frame_params): In X, window IDs are unsigned long,
5937 not signed long, so print them as unsigned.
5938 (validate_x_resource_name): Check for implausibly long names,
5939 and don't assume name length fits in 'int'.
5940 (x_get_resource_string): Don't blindly alloca invocation name;
5941 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5942 not fit in int.
5943
6e1a67fb
PE
5944 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5945 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5946 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5947
0df02bf3
PE
5948 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5949 Use esprintf, not sprintf, in case result does not fit in int.
5950
48e30793
PE
5951 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5952 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5953 it as a large positive number.
5954 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5955 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5956
a66ff6d8
PE
5957 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5958 in case result does not fit in int.
5959
aca216ff
PE
5960 * print.c (float_to_string): Detect width overflow more reliably.
5961 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5962 buffer overrun. Don't assume list length fits in 'int'. Treat
5963 print length of 0 as 0, not as infinity; to be consistent with other
5964 uses of print length in this function. Don't overflow print length
5965 index. Don't assume hash table size fits in 'long', or that
5966 vectorlike size fits in 'unsigned long'.
5967
31c286f7
PE
5968 * process.c (make_process): Use printmax_t, not int, to format
5969 process-name gensyms.
5970
55e5faa1
PE
5971 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5972
80f2e268
PE
5973 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5974 to avoid potential buffer overrun.
5975
670741ab
PE
5976 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5977 if X resource line is longer than 512 bytes.
5978
b7163a50
PE
5979 * xfns.c (x_window): Make sprintf buffer a bit bigger
5980 to avoid potential buffer overrun.
5981
ae58ff1f
PE
5982 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5983
c43c8a6a
PE
5984 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5985
3f8236f4
PE
59862011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5987
53e9fe90 5988 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5989 Without these, Emacs silently mishandles large integers sometimes.
5990 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5991 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5992
6511acf2
PE
5993 * xdisp.c (try_window_id): Check Emacs fixnum range before
5994 converting to 'int'.
806add1d 5995
6511acf2 5996 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5997 Check that an Emacs fixnum is in range before assigning it to 'int'.
5998 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5999 values converted from Emacs fixnums.
6000 (Frecenter): Don't wrap around a line count if it is out of 'int'
6001 range; instead, treat it as an extreme value.
6002 (Fset_window_configuration, compare_window_configurations):
6003 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6004
6511acf2
PE
6005 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6006 that can exceed INT_MAX. Check that EMACS_INT value is in range
6007 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6008 (match_limit): Don't assume that a fixnum can fit in 'int'.
6009
6511acf2 6010 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6011 exceed INT_MAX.
6012
6511acf2 6013 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6014 (Fvertical_motion): Don't wrap around LINES values that don't fit
6015 in 'int'. Instead, treat them as extreme values. This is good
6016 enough for windows, which can't have more than INT_MAX lines anyway.
6017
fcb901a7
LMI
60182011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6019
0f2f6b6d
LMI
6020 * Require libxml/parser.h to avoid compilation warning.
6021
fcb901a7
LMI
6022 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6023
6024 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6025 since this reportedly can destroy thread storage.
6026
6e20a0d4
CY
60272011-08-30 Chong Yidong <cyd@stupidchicken.com>
6028
6029 * syntax.c (find_defun_start): Update all cache variables if
6030 exiting early (Bug#9401).
6031
148ae00e
EZ
60322011-08-30 Eli Zaretskii <eliz@gnu.org>
6033
f6cfbd8f
EZ
6034 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6035
148ae00e
EZ
6036 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6037 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6038 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6039
6040 * term.c (tty_append_glyph): New function.
6041 (produce_stretch_glyph): Static function and its prototype deleted.
6042
a66cfb1c
SM
6043 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6044 Add prototypes.
148ae00e 6045
c4a07a4c
PE
60462011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6047
6048 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6049 when checking :margin (Bug#9390).
6050 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6051 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6052 so that the name doesn't mislead. All uses changed.
6053
6bc8cd65
JB
60542011-08-28 Johan Bockgård <bojohan@gnu.org>
6055
6056 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6057 set_tty_hooks.
6058
dca4927e
EZ
60592011-08-27 Eli Zaretskii <eliz@gnu.org>
6060
6061 * xdisp.c (move_it_to): Don't bail out early when reaching
6062 position beyond to_charpos, if we are scanning backwards.
6063 (move_it_vertically_backward): When DY == 0, make sure we get to
6064 the first character in the line after the newline.
6065
f2cad773
PE
60662011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6067
6068 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6069 (ccl_driver): Do not generate an out-of-range pointer.
6070 (Fccl_execute_on_string): Remove unnecessary check for
6071 integer overflow, noted by Stefan Monnier in
6072 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6073 Remove a FIXME that didn't need fixing.
6074 Simplify the newly-introduced buffer reallocation code.
6075
0cae2cdb
JB
60762011-08-27 Juanma Barranquero <lekktu@gmail.com>
6077
6078 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6079
5fc295a4 60802011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6081
70c60eb2 6082 Integer and memory overflow issues (Bug#9196).
726e0ab1 6083
d31850da
PE
6084 * doc.c (get_doc_string): Rework so that
6085 get_doc_string_buffer_size is the actual buffer size, rather than
6086 being 1 less than the actual buffer size; this makes xpalloc more
6087 convenient.
6088
a69fbedb
PE
6089 * image.c (x_allocate_bitmap_record, cache_image):
6090 * xselect.c (Fx_register_dnd_atom):
6091 Simplify previous changes by using xpalloc.
6092
fe5c5d37
PE
6093 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6094 since either will do and ptrdiff_t is convenient with xpalloc.
6095
0065d054
PE
6096 * charset.c (charset_table_size)
6097 (struct charset_sort_data.priority): Now ptrdiff_t.
6098 (charset_compare): Don't overflow if priorities differ greatly.
6099 (Fsort_charsets): Don't assume list length fits in int.
6100 Check for size-calculation overflow when allocating sort data.
6101 (syms_of_charset): Allocate an initial charset table that is
6102 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6103
6104 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6105
6106 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6107 The actual value is always <= INT_MAX, and leaving it unsigned made
6108 overflow checking harder.
6109
6110 * dispextern.h (struct glyph_matrix.rows_allocated)
6111 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6112 with xpalloc. The values are still always <= INT_MAX.
6113
6114 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6115
6116 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6117 (SAFE_NALLOCA): New macro.
6118
6119 * region-cache.c (struct boundary.pos, find_cache_boundary)
6120 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6121 (set_cache_region, invalidate_region_cache)
6122 (revalidate_region_cache, know_region_cache, region_cache_forward)
6123 (region_cache_backward, pp_cache):
6124 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6125 so that ptrdiff_t * can be passed to xpalloc.
6126 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6127 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6128 (pp_cache): Don't assume cache_len fits in int.
6129 * region-cache.h: Adjust extern decls to match.
6130
6131 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6132 EMACS_INT, since either will do, for xpalloc.
6133
6134 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6135 (xnmalloc, xnrealloc, xpalloc): New functions.
6136
726e0ab1
PE
6137 * bidi.c (bidi_shelve_header_size): New constant.
6138 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6139 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6140
51f30bc5 6141 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6142 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6143 (overlay_strings):
6144 Don't update size of array until after memory allocation succeeds,
6145 because xmalloc/xrealloc may not return.
0065d054
PE
6146 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6147 now that we have proper integer overflow checking.
6148 (record_overlay_string, overlay_strings): Catch overflows when
6149 calculating size of overlay_str_buf.
726e0ab1 6150
0065d054
PE
6151 * callproc.c (Fcall_process): Check for size overflow when
6152 calculating size of args2.
6153 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6154 Normally we prefer signed values, but sticking with ptrdiff_t would
6155 require adding more-complicated checks.
726e0ab1
PE
6156
6157 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6158 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6159 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6160 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6161
6162 * character.c (Fstring): Check for size-calculation overflow.
6163
6164 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6165 unnecessary integer overflow. Check for size overflow.
6166 (encode_coding_object): Don't update size until xmalloc succeeds.
6167
6168 * composite.c (get_composition_id): Check for overflow in glyph
6169 length calculations.
6170
6171 Integer and memory overflow fixes for display code.
6172 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6173 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6174 (scrolling_window): Check for overflow in size calculations.
6175 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6176 Don't assume glyph table len fits in int.
6177 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6178 (row_table_size): Now ptrdiff_t, not int.
6179 (scrolling_window): Avoid overflow in size calculations.
6180 Don't update size until allocation succeeds.
6181 * fns.c (concat): Check for overflow in size calculations.
6182 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6183 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6184 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6185
6186 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6187 (get_doc_string): Check for size calculation overflow.
6188 Don't update size until allocation succeeds.
6189 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6190 EMACS_INT, where ptrdiff_t will do.
6191 (Fsubstitute_command_keys): Check for string overflow.
6192
6193 * editfns.c (set_time_zone_rule): Don't assume environment length
6194 fits in int.
6195 (message_length): Now ptrdiff_t, not int.
6196 (Fmessage_box): Don't update size until allocation succeeds.
6197 Don't assume message length fits in int.
6198 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6199
0065d054
PE
6200 * emacs.c (main): Do not reallocate argv, since there is a null at
6201 the end that can be overwritten, and this way there's no need to
6202 worry about size-calculation overflow.
6203 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6204
6205 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6206 alloc succeeds.
6207 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6208
6209 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6210 (x_set_scroll_bar_width, x_figure_window_size):
6211 Check for integer overflow.
6212 (x_set_alpha): Do not assume XINT fits in int.
6213
6214 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6215 This is for the members text_lines, text_cols, total_lines, total_cols,
6216 where the system imposes an 'int' limit.
6217
6218 * fringe.c (Fdefine_fringe_bitmap):
6219 Don't update size until alloc works.
6220
6221 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6222 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6223
6224 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6225 Check for size-calculation overflow.
6226 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6227 do, as we prefer signed integers.
6228 (id_to_widget.max_size, id_to_widget.used)
6229 (xg_store_widget_in_map, xg_remove_widget_from_map)
6230 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6231 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6232 Use and return ptrdiff_t, not int.
6233 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6234 * gtkutil.h: Change prototypes to match the above.
6235
6236 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6237 are duplicate now that they've been promoted to lisp.h.
6238 (x_allocate_bitmap_record, x_alloc_image_color)
6239 (make_image_cache, cache_image, xpm_load):
6240 Don't update size until alloc is done.
6241 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6242 (x_detect_edges):
3256efce 6243 Check for size calculation overflow.
726e0ab1
PE
6244 (ct_colors_allocated_max): New constant.
6245 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6246 overflow.
3256efce 6247
726e0ab1
PE
6248 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6249 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6250 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6251 Use ptrdiff_t, not int, to count maps.
6252 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6253 calculations. Don't update size until allocation succeeds.
6254 Redo calculations to avoid overflow.
726e0ab1
PE
6255 * keyboard.h: Change prototypes to match the above.
6256
6257 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6258 to count maps.
6259 (current_minor_maps): Check for size calculation overflow.
6260 * keymap.h: Change prototypes to match the above.
6261
6262 * lread.c (read1, init_obarray): Don't update size until alloc done.
6263
6264 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6265 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6266
726e0ab1
PE
6267 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6268 Now ptrdiff_t, not int.
6269 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6270 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6271
6272 * process.c (Fnetwork_interface_list): Check for overflow
6273 in size calculation.
6274
6275 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6276
6277 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6278 overflow. Don't bother calling xmalloc when xrealloc will do.
6279
6280 * search.c (Freplace_match): Check for size calculation overflow.
6281 (Fset_match_data): Don't assume list lengths fit in 'int'.
6282
6283 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6284 for command line length. Do not attempt to address one before the
6285 beginning of an array, as that's not portable.
6286
6287 * term.c (max_frame_lines): Remove; unused.
6288 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6289 not int.
6290 (encode_terminal_code, calculate_costs): Check for size
6291 calculation overflow.
6292 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6293 table lengths and related sizes. Don't update size until alloc
6294 done. Redo calculations to avoid overflow.
6295 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6296
6297 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6298 subtracting pointers.
6299 (gobble_line): Check for overflow more carefully. Don't update size
6300 until alloc done.
6301
6302 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6303 Don't update size until alloc done.
6304 Redo size calculations to avoid overflow.
6305 Check for size calculation overflow.
0065d054 6306 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6307
6308 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6309 Use ptrdiff_t, not int, for sizes.
6310 (store_mode_line_noprop_char): Don't update size until alloc done.
6311
0065d054
PE
6312 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6313 Use ptrdiff_t, not int, for sizes.
6314 (Finternal_make_lisp_face, cache_face):
6315 Check for size calculation overflow.
6316 (cache_face): Treat size calculation overflows as if they were
6317 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6318
6319 * xfns.c (x_encode_text, x_set_name_internal)
6320 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6321 sizes, since they can exceed INT_MAX in size. Check for size
6322 calculation overflow.
6323
0065d054
PE
6324 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6325 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6326 Don't update size until alloc done.
6327
0065d054 6328 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6329 as sprintf is limited to int lengths.
1d526e2f 6330
252c5ee1
PE
6331 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6332 (X_LONG_MIN): New macros.
864d7ce7
PE
6333 Use them to make the following changes clearer.
6334 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6335 This change doesn't affect the value now, but it may help remind
6336 future maintainers not to raise the value too much later.
6337 (SELECTION_QUANTUM): Remove, replacing with ...
6338 (selection_quantum): ... new function, which avoids overflow.
6339 All uses changed.
6340 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6341 assumption that selection length fits in 'int'.
6342 (x_reply_selection_request, x_handle_selection_request)
6343 (x_get_window_property, receive_incremental_selection)
6344 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6345 (lisp_data_to_selection_data, clean_local_selection_data):
6346 Use ptrdiff_t, not int, to record length of selection.
6347 (x_reply_selection_request, x_get_window_property)
6348 (receive_incremental_selection, x_property_data_to_lisp):
6349 Redo calculations to avoid overflow.
6350 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6351 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6352 something.
6353 (x_get_window_property, receive_incremental_selection)
6354 (lisp_data_to_selection_data, x_property_data_to_lisp):
6355 Check for size-calculation overflow.
6356 (x_get_window_property, receive_incremental_selection)
6357 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6358 Don't store size until memory allocation succeeds.
6359 (x_get_window_property): Plug memory leak on memory exhaustion.
6360 Don't double-block input; malloc is safe here. Don't assume 2**34
6361 - 4 fits in unsigned long. Add an xassert to check
6362 XGetWindowProperty overflow. Be more careful about overflow
6363 calculations, and distinguish size from memory overflow better.
6364 (receive_incremental_selection): When tracing, don't assume
6365 unsigned int is less than INT_MAX.
6366 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6367 harmful) conversions of unsigned short to int.
6368 (lisp_data_to_selection_data): Don't assume that integers
6369 in the range -65535 through -1 fit in an X unsigned short.
6370 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6371 result parameters unless successful. Rely on cons_to_unsigned
6372 to report problems with elements; the old code wasn't right anyway.
6373 (x_check_property_data): Check for int overflow; we cannot use
6374 a wider type due to X limits.
6375 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6376
726e0ab1 6377 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6378
0065d054
PE
6379 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6380 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6381 (x_color_cells): Don't store size until memory allocation succeeds.
6382 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6383 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6384 (x_term_init): Don't assume length fits in int (sprintf is limited
6385 to int size).
bc18e09d 6386
ebfa62c0
PE
6387 Use ptrdiff_t for composition IDs.
6388 * character.c (lisp_string_width):
6389 * composite.c (composition_table_size, n_compositions)
6390 (get_composition_id, composition_gstring_from_id):
6391 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6392 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6393 * window.c (Frecenter):
6394 Use ptrdiff_t, not int, for composition IDs.
6395 * composite.c (get_composition_id): Check for integer overflow.
6396 * composite.h: Adjust prototypes to match the above changes.
6397
d3411f89
PE
6398 Use ptrdiff_t for hash table indexes.
6399 * category.c (hash_get_category_set):
6400 * ccl.c (ccl_driver):
6401 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6402 * coding.c (coding_system_charset_list, detect_coding_system):
6403 * coding.h (struct coding_system.id):
6404 * composite.c (get_composition_id, gstring_lookup_cache):
6405 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6406 * image.c (xpm_get_color_table_h):
6407 * lisp.h (hash_lookup, hash_put):
6408 * minibuf.c (Ftest_completion):
6409 Use ptrdiff_t for hash table indexes, not int (which is too
6410 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6411 32-bit --with-wide-int hosts).
6412
e097a6fa
PE
6413 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6414 Add a FIXME comment about memory leaks.
6415 (syms_of_charset): Don't assume xmalloc returns.
6416
5637687f
PE
6417 Don't assume that stated character widths fit in int.
6418 * character.c (Fchar_width, c_string_width, lisp_string_width):
6419 * character.h (CHAR_WIDTH):
6420 * indent.c (MULTIBYTE_BYTES_WIDTH):
6421 Use sanitize_char_width to avoid undefined and/or bad behavior
6422 with outlandish widths.
a66cfb1c 6423 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6424 now that we have two such functions. All uses changed.
6425 (sanitize_char_width): New inline function.
6426
a2271ba2
PE
6427 Don't assume that tab-width fits in int.
6428 * character.h (sanitize_width): New inline function.
6429 (SANE_TAB_WIDTH): New macro.
6430 (ASCII_CHAR_WIDTH): Use it.
6431 * indent.c (sane_tab_width): Remove. All uses replaced by
6432 SANE_TAB_WIDTH (current_buffer).
6433 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6434
18c52557
PE
6435 * fileio.c: Integer overflow issues with file modes.
6436 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6437
caeeedc1
PE
6438 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6439 Remove unreachable code.
6440 (read_hex, load_charset_map_from_file): Check for integer overflow.
6441
6df6ae42 6442 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6443 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6444 (x_send_scroll_bar_event): Likewise. Check that the size does not
6445 exceed limits imposed by XClientMessageEvent, as well as the usual
6446 ptrdiff_t and size_t limits.
6447
b13995db
PE
6448 * keyboard.c: Overflow, signedness and related fixes.
6449 (make_lispy_movement): Use same integer type in forward decl
6450 that is used in the definition.
6451 (read_key_sequence, keyremap_step):
6452 Change bufsize argument back to int, undoing my 2011-03-30 change.
6453 We prefer signed types, and int is wide enough here.
6454 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6455 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6456 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6457 length, not size_t. Use ptrdiff_t for index, not int.
6458 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6459 possibility of integer overflow.
6460
13464394
PE
6461 Overflow, signedness and related fixes for images.
6462
6463 * dispextern.h (struct it.stack[0].u.image.image_id)
6464 (struct_it.image_id, struct image.id, struct image_cache.size)
6465 (struct image_cache.used, struct image_cache.ref_count):
6466 * gtkutil.c (update_frame_tool_bar):
6467 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6468 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6469 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6470 * nsmenu.m (update_frame_tool_bar):
6471 * xdisp.c (calc_pixel_width_or_height):
6472 * xfns.c (image_cache_refcount):
6473 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6474 on typical 64-bit hosts.
6475
6476 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6477 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6478 Omit unnecessary casts to int.
6479 (parse_image_spec): Check that integers fall into 'int' range
6480 when the callers expect that.
6481 (image_ascent): Redo ascent calculation to avoid int overflow.
6482 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6483 (lookup_image): Remove unnecessary tests.
6484 (xbm_image_p): Locals are now of int, not EMACS_INT,
6485 since parse_image_check makes sure they fit into int.
6486 (png_load, gif_load, svg_load_image):
6487 Prefer int to unsigned where either will do.
6488 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6489 old tiff_error_handler and tiff_warning_handler.
6490 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6491 stack buffer overflows. It uses only the features of vsnprintf
6492 that are common to both POSIX and native Microsoft.
6493 (tiff_error_handler, tiff_warning_handler): Use it.
6494 (tiff_load, gif_load, imagemagick_load_image):
6495 Don't assume :index value fits in 'int'.
6496 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6497 (imagemagick_load_image): Check that crop parameters fit into
6498 the integer types that MagickCropImage accepts. Don't assume
6499 Vimagemagick_render_type has a nonnegative value. Don't assume
6500 size_t fits in 'long'.
6501 (gs_load): Use printmax_t to print the widest integers possible.
6502 Check for integer overflow when computing image height and width.
6503
c11821d4
EZ
65042011-08-26 Eli Zaretskii <eliz@gnu.org>
6505
6506 * xdisp.c (redisplay_window): Don't force window start if point
6507 will be invisible in the resulting window. (Bug#9324)
6508
0c95fcf7
EZ
65092011-08-25 Eli Zaretskii <eliz@gnu.org>
6510
6511 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6512 the display spec is of the form `(space ...)'.
6513 (handle_display_spec): Return the value returned by
6514 handle_single_display_spec, not just 1 or zero.
6515 (handle_single_display_spec): If the display spec is of the form
6516 `(space ...)', and specifies display in the text area, return 2
6517 rather than 1.
fee65a97 6518 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6519 accurately, and prefer exact match for point under bidi.
6520 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6521
6522 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6523 into disp_prop; all users changed.
6524
6525 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6526 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6527 for the text covered by the display property.
6528
e4ed06f1
CY
65292011-08-25 Chong Yidong <cyd@stupidchicken.com>
6530
6531 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6532 Change return value to nil.
6533 (Frecord_buffer): Delete unused function.
6534
f67cdd7f
EZ
65352011-08-24 Eli Zaretskii <eliz@gnu.org>
6536
5980d4c6
EZ
6537 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6538 buffers, return left-to-right.
8610fe8b
EZ
6539 (set_cursor_from_row): Consider candidate row a win if its glyph
6540 represents a newline and point is on that newline. Fixes cursor
6541 positioning on the newline at EOL of R2L text within L2R
6542 paragraph, and vice versa.
6543 (try_cursor_movement): Check continued rows, in addition to
6544 continuation rows. Fixes unwarranted scroll when point enters a
6545 continued line of R2L text within an L2R paragraph, or vice versa.
6546 (cursor_row_p): Consider the case of point being equal to
6547 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6548 from the end of a short line to the beginning of a continued line
6549 of R2L text within L2R paragraph.
6550 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6551 composed characters.
5980d4c6 6552
f67cdd7f
EZ
6553 * bidi.c (bidi_check_type): Use xassert.
6554 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6555 members.
6556
bca633fb
EZ
65572011-08-23 Eli Zaretskii <eliz@gnu.org>
6558
6559 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6560 a character.
6561
4a5885a7
CY
65622011-08-23 Chong Yidong <cyd@stupidchicken.com>
6563
6564 * nsfont.m (ns_otf_to_script): Fix typo.
6565
0902a04e
KH
65662011-08-22 Kenichi Handa <handa@m17n.org>
6567
6568 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6569 extra slot even if the purpose is char-code-property-table.
6570
1a2e6670
EZ
65712011-08-23 Eli Zaretskii <eliz@gnu.org>
6572
8ddde651
EZ
6573 * xdisp.c (redisplay_window): When computing centering_position,
6574 account for the height of the header line. (Bug#8874)
6575
425cc014
EZ
6576 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6577 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6578 candidate is selected by the mouse, and that candidate has a
6579 composed character under the mouse.
6580
1a2e6670
EZ
6581 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6582 coordinates reported by pos-visible-in-window-p for a composed
6583 character in column zero.
6584
8b76d6f8
SM
65852011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6586
6587 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6588
dac347dd
EZ
65892011-08-22 Eli Zaretskii <eliz@gnu.org>
6590
6591 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6592 consider it a hit if to_charpos is anywhere in the range of the
6593 composed buffer positions.
6594
e013fb34
CY
65952011-08-22 Chong Yidong <cyd@stupidchicken.com>
6596
6597 * image.c (gif_load): Don't assume that each subimage has the same
6598 dimensions as the base image. Handle disposal method that is
6599 "undefined" by the gif spec (Bug#9335).
6600
bd1ba3e8
CY
66012011-08-20 Chong Yidong <cyd@stupidchicken.com>
6602
6603 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6604 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6605
54a1215b
EZ
66062011-08-19 Eli Zaretskii <eliz@gnu.org>
6607
823564e5
EZ
6608 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6609 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6610 from an Org mode buffer to a Speedbar frame.
6611
54a1215b
EZ
6612 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6613 a composition, take its buffer position from IT->cmp_it.charpos.
6614 Fixes cursor positioning at the beginning of a line that begins
6615 with a composed character.
6616
9778ebcc
EZ
66172011-08-18 Eli Zaretskii <eliz@gnu.org>
6618
0be6ee06
EZ
6619 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6620 character bidirectional type, use STRONG_L instead. Fixes crashes
6621 in a buffer produced by `describe-categories'.
6622
9778ebcc
EZ
6623 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6624 members before the level stack, so they would be saved and
6625 restored when copying iterator state. Fixes incorrect reordering
6626 around TABs covered by display properties.
6627
156bffbe
AS
66282011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6629
6b02f655 6630 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6631
72ad093b
CY
66322011-08-17 Chong Yidong <cyd@stupidchicken.com>
6633
6634 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6635 (internal_condition_case_2, internal_condition_case_n):
6636 Remove unnecessary aborts (Bug#9081).
72ad093b 6637
35774242
EZ
66382011-08-17 Eli Zaretskii <eliz@gnu.org>
6639
6640 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6641 has no `load' handler, try opening the file locally. (Bug#9311)
6642
db76dd85
KB
66432011-08-16 Ken Brown <kbrown@cornell.edu>
6644
6645 * gmalloc.c: Expand comment.
6646
b215eee5
EZ
66472011-08-16 Eli Zaretskii <eliz@gnu.org>
6648
6649 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6650 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6651
a4579d33
KB
66522011-08-16 Ken Brown <kbrown@cornell.edu>
6653
6654 Fix memory allocation problems in Cygwin build (Bug#9273).
6655
6656 * unexcw.c ( __malloc_initialized): Declare external variable.
6657 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6658
8b76d6f8
SM
6659 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6660 New variables.
a4579d33
KB
6661 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6662 dumped emacs.
6663 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6664 in the static heap.
6665 [CYGWIN] (special_realloc): New function.
6666 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6667 requests to realloc storage in the static heap.
6668
3ebec551
PE
66692011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6670
6671 * bidi.c (bidi_initialize): Remove unused local.
6672
9fd8be00
EZ
66732011-08-15 Eli Zaretskii <eliz@gnu.org>
6674
6b02f655
SM
6675 * bidimirror.h:
6676 * biditype.h: Remove file.
6677 * makefile.w32-in ($(BLD)/bidi.$(O)):
6678 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6679
6680 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6681
6682 * chartab.c: Improve commentary for the uniprop_table API.
6683
32413314
EZ
6684 * bidi.c (bidi_paragraph_init): Support zero value of
6685 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6686 (bidi_initialize): Use uniprop_table instead of including
6687 biditype.h and bidimirror.h.
32413314 6688
9fd8be00
EZ
6689 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6690 coordinates of the iterator when restoring from ppos_it.
6691 (Bug#9296)
6692
5cf2b69b
KH
66932011-08-14 Kenichi Handa <handa@m17n.org>
6694
6695 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6696 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6697
daf17d00
EZ
66982011-08-14 Eli Zaretskii <eliz@gnu.org>
6699
6700 * xdisp.c (move_it_in_display_line_to): Don't invoke
6701 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6702 ppos_it. Fixes vertical cursor motion when line beginning is
6703 covered by an image. (Bug#9296)
6704
08e3161a
JD
67052011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6706
6707 * nsterm.h (ns_run_ascript): Declare.
6708 (NSAPP_DATA2_RUNASSCRIPT): Define.
6709
6710 * nsfns.m (as_script, as_result, as_status): New static variables.
6711 (ns_run_ascript): New function.
5e617bc2 6712 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6713 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6714 the event loop. Get status from as_status (Bug#7276).
6715
6716 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6717 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6718 the event loop (Bug#7276).
6719
a3720aa2
AS
67202011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6721
6722 * gnutls.c (QCgnutls_bootprop_priority)
6723 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6724 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6725 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6726 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6727 (QCgnutls_bootprop_verify_hostname_error)
6728 (QCgnutls_bootprop_callbacks_verify): Rename from
6729 Qgnutls_bootprop_..., all uses changed.
6730
6731 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6732 uses changed.
6733
0a0d27fb
PE
67342011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6735
19d5c50c
PE
6736 * xfaces.c (Qframe_set_background_mode): Now static.
6737 * dispextern.h (Qframe_set_background_mode): Remove decl.
6738
0a0d27fb
PE
6739 * process.c (Fnetwork_interface_info): Declare local only if needed.
6740
377538cb
JD
67412011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6742
6743 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6744 (Fnetwork_interface_list): Allocate in increments of bytes instead
6745 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6746 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6747 sockaddr.
6748 (struct ifflag_def): notrailers is smart on OSX.
6749 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6750 Get hardware address with getifaddrs if available.
6751
08fff70c
EZ
67522011-08-12 Eli Zaretskii <eliz@gnu.org>
6753
6754 * xdisp.c (iterate_out_of_display_property): xassert that
6755 IT->position is set to within IT->object's boundaries. Break from
6756 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6757 when IT->position is set up wrongly due to some bug.
6758 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6759 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6760 entry. Force push_it to save on the stack the current
6761 buffer/string position, to be restored by pop_it. Fix flags in
6762 the iterator structure wrt the object coming from a display
6763 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6764 properties. (Bug#9284)
6765
7be1c708 67662011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6767
7be1c708
CY
6768 * fontset.c (fontset_get_font_group): Add proper type checks.
6769 (Bug#9172)
aac0c6e3 6770
7be1c708 67712011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6772
7be1c708
CY
6773 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6774 and LC_VERSION_MIN_MACOSX.
6775 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6776 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6777
97bb72a6
EZ
67782011-08-08 Eli Zaretskii <eliz@gnu.org>
6779
6780 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6781 no-display-properties-and-no-overlays under bidi display.
6782 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6783 properties and overlays.
97bb72a6 6784
d5617611
CY
67852011-08-08 Chong Yidong <cyd@stupidchicken.com>
6786
37e11a63
CY
6787 * editfns.c (Fset_time_zone_rule): Document relationship with the
6788 setenv function.
6789
d5617611
CY
6790 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6791 the font entity extracted from the cache (Bug#8109).
6792
58872834
CY
67932011-08-07 Chong Yidong <cyd@stupidchicken.com>
6794
6795 * composite.c (autocmp_chars): Don't reset point. That is done by
6796 restore_point_unwind (Bug#5984).
6797
75bfc667
JL
67982011-08-07 Juri Linkov <juri@jurta.org>
6799
6800 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6801 to show the arg `TIME' instead of `TIMEVAL'.
6802
d1410150
EZ
68032011-08-06 Eli Zaretskii <eliz@gnu.org>
6804
6805 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6806 display property strides EOL and includes a newline, as in
6807 longlines-mode. (Bug#9254)
75b771e4
EZ
6808 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6809 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6810
6811 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6812 is non-zero, even if the data buffer is NULL. Fixes a crash in
6813 vertical-motion with longlines-mode. (Bug#9254)
6814
35928349
EZ
68152011-08-05 Eli Zaretskii <eliz@gnu.org>
6816
ec7cc85b
EZ
6817 * bidi.c <bidi_cache_total_alloc>: Now static.
6818 (bidi_initialize): Initialize bidi_cache_total_alloc.
6819
8b76d6f8 6820 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6821 cache. (Bug#9221)
6822
6823 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6824 amount allocated this far in `bidi_cache_total_alloc'.
6825 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6826 non-zero, only free the data buffer without restoring the cache
6827 contents. All callers changed.
6828
6829 * dispextern.h (bidi_unshelve_cache): Update prototype.
6830
6831 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6832 (move_it_in_display_line, move_it_to)
6833 (move_it_vertically_backward, move_it_by_lines): Replace the call
6834 to xfree to an equivalent call to bidi_unshelve_cache.
6835 (move_it_in_display_line_to): Fix logic of returning
412b6358 6836 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6837
e2e2423b
EZ
68382011-08-05 Eli Zaretskii <eliz@gnu.org>
6839
6840 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6841 came from a string character with a `cursor' property. (Bug#9229)
6842
ae9e757a
JD
68432011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6844
6845 * Makefile.in (LIB_PTHREAD): New variable.
6846 (LIBES): Add LIB_PTHREAD (Bug#9216).
6847
6848 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6849 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6850
213bd7f2
AS
68512011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6852
6b02f655 6853 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6854
99aaf75f
JD
68552011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6856
6857 * xterm.c (x_find_topmost_parent): New function.
6858 (x_set_frame_alpha): Find topmost parent window with
6859 x_find_topmost_parent and set the property there also (bug#9181).
6860 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6861
c74e9d86
PE
68622011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6863
6864 * callproc.c (Fcall_process): Avoid vfork clobbering
6865 the local vars buffer, coding_systems, current_dir.
6866
640c8776
SM
68672011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6868
6869 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6870
f26d0e4c
PE
68712011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6872
8a10d76c
PE
6873 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6874 so that it is not optimized away.
6875
f26d0e4c
PE
6876 * xdisp.c (compute_display_string_pos): Remove unused local.
6877
55439c61
EZ
68782011-08-02 Eli Zaretskii <eliz@gnu.org>
6879
6880 Fix slow cursor motion and scrolling in large buffers with
6881 selective display, like Org Mode buffers. (Bug#9218)
6882
6883 * dispextern.h (struct bidi_it): New member disp_prop_p.
6884
6885 * xdisp.c: Remove one-slot cache of display string positions.
6886 (compute_display_string_pos): Accept an additional argument
5e617bc2 6887 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6888 for a display string or property. If found, set DISP_PROP_P
6889 non-zero.
6890
6891 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6892 DISP_PROP_P, and pass it to compute_display_string_pos.
6893 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6894 non-zero. All callers of bidi_fetch_char changed.
6895
fb33fa43
SM
68962011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6897
6898 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6899
b099e063
DM
69002010-12-03 Don March <don@ohspite.net>
6901
6902 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6903 last character M-[char] is translated to ESC [char] (bug#7541).
6904
5cc7f7af
KH
69052011-08-02 Kenichi Handa <handa@m17n.org>
6906
d0fffa3f 6907 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6908
6909 * chartab.c (uniprop_table): Make it non-static.
6910
525d5e6e
EZ
69112011-08-01 Eli Zaretskii <eliz@gnu.org>
6912
6913 * xdisp.c (forward_to_next_line_start): Accept additional argument
6914 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6915 on the newline.
6916 (reseat_at_next_visible_line_start): Use the bidi iterator state
6917 returned by forward_to_next_line_start to restore the state of
6918 it->bidi_it after backing up to previous newline. (Bug#9212)
6919
31011111
AS
69202011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6921
6922 * regex.c (re_comp): Protoize.
6923 (re_exec): Fix return type.
6924 (regexec): Fix type of `ret'. (Bug#9203)
6925
476371c4
PE
69262011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6927
e5d76069
PE
6928 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6929 This is needed if max-image-size is a floating-point number.
6930
9a79b20c
AS
69312011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6932
6933 * print.c (print_object): Print empty symbol as ##.
6934
6935 * lread.c (read1): Read ## as empty symbol.
6936
d8c2fa78
AA
69372011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6938
6939 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6940 setting frame foreground color (Bug#9175).
6941 (x_set_background_color): Likewise.
6942
ffe57a7a
AA
6943 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6944 contents (Bug#9176).
6945 (EmacsTooltip -init): Remove bezels and add shadows to
6946 tooltip windows.
6947
bf3492a5
AA
6948 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6949 or scroll bar (Bug#8470).
6950
d55e9c53
AA
6951 * nsfont.m (nsfont_open): Remove assignment to voffset and
6952 unnecessary vars hshink, expand, hd, full_height, min_height.
6953 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6954
6955 * nsterm.h (nsfont_info): Remove voffset field.
6956
d8c2fa78 69572011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6958
6959 Implement strike-through and overline on NextStep (Bug#8863).
6960
6961 * nsfont.m (nsfont_open): Use underline position provided by font,
6962 instead of hard-coded value of 2.
6963 (nsfont_draw): Call ns_draw_text_decoration instead.
6964
6965 * nsterm.h: Add declaration for ns_draw_text_decoration.
6966
6967 * nsterm.m (ns_draw_text_decoration): New function for drawing
6968 underline, overline, and strike-through.
6969 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6970 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6971 accommodate underlining, etc.
4843aac3 6972
4cc60b9b
EZ
69732011-07-28 Eli Zaretskii <eliz@gnu.org>
6974
bc7ece87
EZ
6975 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6976 default.
4cc60b9b 6977
476371c4
PE
69782011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6979
66606eea
PE
6980 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6981 Without this fix, if a signal arrives just after memory fills up,
6982 'malloc' might be invoked reentrantly.
6983
476371c4
PE
6984 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6985 In other words, assume that every image size is allowed, on non-X
6986 hosts. This assumption is probably wrong, but it lets Emacs compile.
6987
f3fcc40d
AS
69882011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6989
6990 * regex.c (re_iswctype): Convert return values to boolean.
6991
350c992f
EZ
69922011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6993
6994 * xdisp.c (compute_display_string_pos): Don't use cached display
6995 string position if the buffer had its restriction changed.
6996 (Bug#9184)
6997
5266b4bb
PE
69982011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6999
7000 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7001
2573a837 70022011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7003
41f55ccd 7004 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7005
39e378da
PE
7006 * bidi.c: Integer size and overflow fixes.
7007 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7008 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7009 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7010 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7011 (bidi_find_other_level_edge):
7012 Use ptrdiff_t instead of EMACS_INT where either will do.
7013 This works better on 32-bit hosts configured --with-wide-int.
7014 (bidi_cache_ensure_space): Check for size-calculation overflow.
7015 Use % rather than repeated addition, for better worst-case speed.
7016 Don't set bidi_cache_size until after xrealloc returns, because it
7017 might not return.
7018 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7019 (bidi_cache_ensure_space): Also check that the bidi cache size
7020 does not exceed that of the largest Lisp string or buffer. See Eli
7021 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7022
5e927815
PE
7023 * alloc.c (__malloc_size_t): Remove.
7024 All uses replaced by size_t. See Andreas Schwab's note
7025 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7026
ca4aa935
PE
7027 * image.c: Improve checking for integer overflow.
7028 (check_image_size): Assume that f is nonnull, since
7029 it is always nonnull in practice. This is one less thing to
7030 worry about when checking for integer overflow later.
7031 (x_check_image_size): New function, which checks for integer
7032 overflow issues inside X.
7033 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7034 This removes the need for a memory_full check.
7035 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7036 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7037 (xbm_read_bitmap_data): Change locals back to 'int', since
7038 their values must fit in 'int'.
7039 (xpm_load_image, png_load, tiff_load):
7040 Invoke x_create_x_image_and_pixmap earlier,
7041 to avoid much needless work if the image is too large.
7042 (tiff_load): Treat overly large images as if
7043 x_create_x_image_and_pixmap failed, not as malloc failures.
7044 (gs_load): Use x_check_image_size.
7045
5f8f9cc2
PE
7046 * gtkutil.c: Omit integer casts.
7047 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7048 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7049
5adf60bc
PE
7050 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7051
c8907a93
PE
7052 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7053 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7054 would wrongly return t on a 64-bit host.
7055
e3c25c68
PE
7056 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7057 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7058 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7059 and therefore cause GCC to emit a bogus diagnostic in some cases.
7060
3f791afe
PE
7061 * image.c: Integer signedness and overflow and related fixes.
7062 This is not an exhaustive set of fixes, but it's time to
7063 record what I've got.
7064 (lookup_pixel_color, check_image_size): Remove redundant decls.
7065 (check_image_size): Don't assume that arbitrary EMACS_INT values
7066 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7067 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7068 (tiff_load, imagemagick_load_image):
7069 Check for overflow in size calculations.
7070 (x_create_x_image_and_pixmap): Remove unnecessary test for
7071 xmalloc returning NULL; that can't happen.
7072 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7073 (xpm_color_bucket): Use better integer hashing function.
7074 (xpm_cache_color): Don't possibly over-allocate memory.
7075 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7076 (gif_memory_source):
7077 Use ptrdiff_t, not int or size_t, to record sizes.
7078 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7079 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7080 either works, as we prefer signed integers.
7081 (tiff_read_from_memory, tiff_write_from_memory):
7082 Return tsize_t, not size_t, since that's what the TIFF API wants.
7083 (tiff_read_from_memory): Don't fail simply because the read would
7084 go past EOF; instead, return a short read.
7085 (tiff_load): Omit no-longer-needed casts.
7086 (Fimagemagick_types): Don't assume size fits into 'int'.
7087
3cc5a532
PE
7088 Improve hashing quality when configured --with-wide-int.
7089 * fns.c (hash_string): New function, taken from sxhash_string.
7090 Do not discard information about ASCII character case; this
7091 discarding is no longer needed.
7092 (sxhash-string): Use it. Change sig to match it. Caller changed.
7093 * lisp.h: Declare it.
7094 * lread.c (hash_string): Remove, since we now use fns.c's version.
7095 The fns.c version returns a wider integer if --with-wide-int is
7096 specified, so this should help the quality of the hashing a bit.
7097
b312a492
PE
7098 * emacs.c: Integer overflow minor fix.
7099 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7100 Define only if GNU_LINUX.
7101 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7102
dfd153ae
PE
7103 * dispnew.c: Integer signedness and overflow fixes.
7104 Remove unnecessary forward decls, that were a maintenance hassle.
7105 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7106 All uses changed.
7107 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7108 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7109 (prepare_desired_row, line_draw_cost):
7110 Use int, not unsigned, where either works.
7111 (save_current_matrix, restore_current_matrix):
7112 Use ptrdiff_t, not size_t, where either works.
7113 (init_display): Check for overflow more accurately, and without
7114 relying on undefined behavior.
7115
a81d11a3
PE
7116 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7117 Remove, replacing with the new symbols in lisp.h. All uses changed.
7118 * fileio.c (make_temp_name):
7119 * filelock.c (lock_file_1, lock_file):
7120 * xdisp.c (message_dolog):
7121 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7122 Use pMd etc. instead.
7123 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7124 replacing the pWIDE etc. symbols removed from editfns.c.
7125
3300e6fd
PE
7126 * keyboard.h (num_input_events): Now uintmax_t.
7127 This is (very slightly) less likely to mess up due to wraparound.
7128 All uses changed.
7129
fd05c7e9
PE
7130 * buffer.c: Integer signedness fixes.
7131 (alloc_buffer_text, enlarge_buffer_text):
7132 Use ptrdiff_t rather than size_t when either will do, as we prefer
7133 signed integers.
7134
903fe15d
PE
7135 * alloc.c: Integer signedness and overflow fixes.
7136 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7137 (__malloc_size_t): Default to size_t, not to int.
7138 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7139 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7140 Prefer ptrdiff_t to size_t when either would do, as we prefer
7141 signed integers.
7142 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7143 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7144 Now const. Initialize with values that are in range even if char
7145 is signed.
7146 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7147 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7148 These functions do the right thing with sizes > 2**32.
7149 (check_depth): Now ptrdiff_t, not int.
7150 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7151 Adjust to new way of storing sizes. Check for size overflow bugs
7152 in rest of code.
7153 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7154 slightly wrong anyway, as it missed one instance of
7155 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7156 (refill_memory_reserve): Omit needless cast to size_t.
7157 (mark_object_loop_halt): Mark as externally visible.
7158
ac82cc6a
PE
7159 * xselect.c: Integer signedness and overflow fixes.
7160 (Fx_register_dnd_atom, x_handle_dnd_message):
7161 Use ptrdiff_t, not size_t, since we prefer signed.
7162 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7163 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7164 x_dnd_atoms_size and x_dnd_atoms_length.
7165
c2d1e36d
PE
7166 * doprnt.c: Prefer signed to unsigned when either works.
7167 * eval.c (verror):
7168 * doprnt.c (doprnt):
7169 * lisp.h (doprnt):
7170 * xdisp.c (vmessage):
7171 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7172 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7173 prefer signed arithmetic to avoid comparison confusion.
7174 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7175 but is a bit tricky.
7176
0e926e56
PE
7177 Assume freestanding C89 headers, string.h, stdlib.h.
7178 * data.c, doprnt.c, floatfns.c, print.c:
7179 Include float.h unconditionally.
7180 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7181 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7182 * regex.c: Likewise for stddef.h, string.h.
7183 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7184 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7185 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7186 (STDC_HEADERS): Remove obsolete defines.
7187 * sysdep.c: Include limits.h unconditionally.
7188
9cfdb3ec
PE
7189 Assume support for memcmp, memcpy, memmove, memset.
7190 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7191 * regex.c (memcmp, memcpy):
7192 Remove; we assume C89 now.
7193
7194 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7195 (__malloc_safe_bcopy): Remove; no longer needed.
7196
cf950e6b 7197 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7198 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7199 well either way, and we prefer signed to unsigned.
7200
dbf38e02
LMI
72012011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7202
7203 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7204 closes the connection while we're reading (bug#9182).
7205
d6f0886c 72062011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7207
d6f0886c
JD
7208 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7209 are specified (Bug#9168).
24e0f6b1 7210
2eb1f9e6
PE
72112011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7212
7213 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7214 Found by GCC static checking and --with-wide-int on a 32-bit host.
7215
22381272 72162011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7217
7218 * xdisp.c (compute_display_string_pos): Fix logic of caching
7219 previous display string position. Initialize cached_prev_pos to
7220 -1. Fixes slow-down at the beginning of a buffer.
7221
f25e39b4
EZ
72222011-07-24 Eli Zaretskii <eliz@gnu.org>
7223
7224 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7225 for attrs[LFACE_FONTSET_INDEX].
7226
04c4b52e
PE
72272011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7228
7229 * xml.c (parse_region): Remove unused local
7230 that was recently introduced.
7231
c1734fbd
EZ
72322011-07-23 Eli Zaretskii <eliz@gnu.org>
7233
be18c5a5
EZ
7234 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7235 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7236
c1734fbd
EZ
7237 * xdisp.c (move_it_in_display_line_to): Record the best matching
7238 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7239 exit if none of the characters scanned was an exact match.
7240 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7241 when exact match is impossible due to invisible text, and the
7242 lines are truncated.
7243
a258d627
JD
72442011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7245
7246 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7247 for OSX >= 10.7.
7248
b6d5a689
EZ
72492011-07-22 Eli Zaretskii <eliz@gnu.org>
7250
0f74f785
EZ
7251 Fix a significant slow-down of cursor motion with C-n, C-p,
7252 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7253 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7254 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7255 (next_element_from_buffer): Call compute_stop_pos_backwards to
7256 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7257 base_level_stop.
7258 (reseat): Don't look for prev_stop, as that could mean a very long
7259 run.
7260 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7261 <cached_disp_overlay_modiff>: Cache for last found display string
7262 position.
551918c1 7263 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7264 about the same buffer in the same area of character positions, and
7265 the buffer wasn't changed since the time the display string
7266 position was cached.
551918c1 7267
b2d0c91a
EZ
72682011-07-22 Eli Zaretskii <eliz@gnu.org>
7269
7270 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7271 is an integer, which is important for empty lines. (Bug#9149)
7272
043604ee
CY
72732011-07-22 Chong Yidong <cyd@stupidchicken.com>
7274
7275 * frame.c (Fmodify_frame_parameters): In tty case, update the
7276 default face if necessary (Bug#4238).
7277
da4adb04
CY
72782011-07-21 Chong Yidong <cyd@stupidchicken.com>
7279
7280 * editfns.c (Fstring_to_char): No need to explain what a character
7281 is in the docstring (Bug#6576).
7282
9abd0532
LMI
72832011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7284
7285 * xml.c (parse_region): Make sure we always return a tree.
7286
36881d16
HK
72872011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7288
7289 * xml.c (parse_region): If a document contains only comments,
7290 return that, too.
7291
1e98674d
LMI
72922011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7293
7294 * xml.c (make_dom): Return comments, too.
7295
590bd467
PE
72962011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7297
7298 Port to OpenBSD.
7299 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7300 and the surrounding thread.
7301 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7302 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7303 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7304 timer goes off.
7305 * s/openbsd.h (BROKEN_SIGIO): Define.
7306 * unexelf.c (unexec) [__OpenBSD__]:
7307 Don't update the .mdebug section of the Alpha COFF symbol table.
7308
f41628b2
LMI
73092011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7310
7311 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7312 (bug#8460).
7313
b59b67c5
PE
73142011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7315
15e3a074
PE
7316 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7317 This fixes some race conditions on the permissions of any newly
7318 created file.
7319
41bed37d
PE
7320 * alloc.c (valid_pointer_p): Use pipe, not open.
7321 This fixes some permissions issues when debugging.
7322
b59b67c5
PE
7323 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7324 If fchown fails to set both uid and gid, try to set just gid,
7325 as that is sometimes allowed. Adjust the file's mode to eliminate
7326 setuid or setgid bits that are inappropriate if fchown fails.
7327
925a6be7
SM
73282011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7329
7330 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7331 to compare Lisp_Objects.
7332 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7333 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7334 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7335
52968808
AS
73362011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7337
0a6a104b
AS
7338 * lread.c (read_integer): Unread even EOF character.
7339 (read1): Likewise. Properly record start position of symbol.
7340
52968808
AS
7341 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7342 symbol character follows.
7343
9e381cdd
PE
73442011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7345
7346 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7347 This works around a problem with the previous change to Fcopy_file.
7348 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7349 and without this change, GCC might complain about discarding
7350 fchown's return value.
7351
b5641435
JB
73522011-07-16 Juanma Barranquero <lekktu@gmail.com>
7353
7354 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7355
a8031457
PE
73562011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7357
7358 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7359
dd889327
LMI
73602011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7361
750c33f7
LMI
7362 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7363 it's used from the C level.
7364
dd889327
LMI
7365 * process.c: Use the same condition for POLL_FOR_INPUT in both
7366 keyboard.c and process.c (bug#1858).
7367
87e86684
LM
73682011-07-09 Lawrence Mitchell <wence@gmx.li>
7369
7370 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7371 (Fgnutls_boot): Use it.
7372
64348f40
AS
73732011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7374
7375 * doc.c (Fsubstitute_command_keys): Revert last change.
7376
1d698799
LMI
73772011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7378
f863868c
LMI
7379 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7380 quotes the next character, and doesn't affect other longer
7381 sequences (bug#8935).
7382
1d698799
LMI
7383 * lread.c (syms_of_lread): Clarify that is isn't only
7384 `eval-buffer' and `eval-defun' that's affected by
7385 `lexical-binding' (bug#8460).
7386
aa4b6df6
EZ
73872011-07-15 Eli Zaretskii <eliz@gnu.org>
7388
7389 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7390 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7391
5d856da6
PE
73922011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7393
ad6042bb
PE
7394 Fix minor problems found by static checking.
7395 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7396 (elsz): Now a signed constant, not a size_t var. We prefer signed
7397 types to unsigned, to avoid integer comparison confusion. Without
7398 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7399 "cannot optimize loop, the loop counter may overflow", a symptom
7400 of the confusion.
f00bbb22 7401 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7402 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7403
6468f31c
LMI
74042011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7405
49080b10
LMI
7406 * search.c (Fre_search_backward): Mention `case-fold-search' in
7407 all the re_search_* functions (bug#8138).
7408
6468f31c
LMI
7409 * keyboard.c (Fopen_dribble_file): Document when the file is
7410 closed (bug#8056).
7411
c965adc5
EZ
74122011-07-14 Eli Zaretskii <eliz@gnu.org>
7413
df9733bf
EZ
7414 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7415 bidi_cache_idx.
7416
0bb23927
EZ
7417 Support bidi reordering of display and overlay strings.
7418 * xdisp.c (compute_display_string_pos)
7419 (compute_display_string_end): Accept additional argument STRING.
7420 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7421 (reseat_to_string): Initialize bidi_it->string.s and
7422 bidi_it->string.schars.
7423 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7424 NULL (avoids a crash in bidi_paragraph_init).
7425 Initialize itb.string.lstring.
0bb23927
EZ
7426 (init_iterator): Call bidi_init_it only of a valid
7427 buffer position was specified. Initialize paragraph_embedding to
7428 L2R.
7429 (reseat_to_string): Initialize the bidi iterator.
7430 (display_string): If we need to ignore text properties of
7431 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7432 original value of -1 will not work with bidi.)
7433 (compute_display_string_pos): First arg is now struct
7434 `text_pos *'; all callers changed. Support display properties on
7435 Lisp strings.
7436 (compute_display_string_end): Support display properties on Lisp
7437 strings.
7438 (init_iterator, reseat_1, reseat_to_string): Initialize the
7439 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7440 when iterating on a string not from display properties).
640c8776
SM
7441 (compute_display_string_pos, compute_display_string_end):
7442 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7443 arrow keys.
7444 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7445 base_level_stop; instead, set base_level_stop to BEGV.
7446 Fixes crashes in vertical-motion.
0bb23927
EZ
7447 (next_element_from_buffer): Improve commentary for when
7448 the iterator is before prev_stop.
7449 (init_iterator): Initialize bidi_p from the default value of
7450 bidi-display-reordering, not from buffer-local value. Use the
7451 buffer-local value only if initializing for buffer iteration.
7452 (handle_invisible_prop): Support invisible properties on strings
7453 that are being bidi-reordered.
7454 (set_iterator_to_next): Support bidi reordering of C strings and
7455 Lisp strings.
7456 (next_element_from_string): Support bidi reordering of Lisp
7457 strings.
7458 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7459 (display_string): Support display of R2L glyph rows.
7460 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7461 (init_iterator): Don't initialize it->bidi_p for strings
7462 here.
7463 (reseat_to_string): Initialize it->bidi_p for strings here.
7464 (next_element_from_string, next_element_from_c_string)
7465 (next_element_from_buffer): Add xassert's for correspondence
7466 between IT's object being iterated and it->bidi_it.string
7467 structure.
7468 (face_before_or_after_it_pos): Support bidi iteration.
7469 (next_element_from_c_string): Handle the case of the first string
7470 character that is not the first one in the visual order.
7471 (get_visually_first_element): New function, refactored from common
7472 parts of next_element_from_buffer, next_element_from_string, and
7473 next_element_from_c_string.
7474 (tool_bar_lines_needed, redisplay_tool_bar)
7475 (display_menu_bar): Force left-to-right direction. Add a FIXME
7476 comment for making that be controlled by a user option.
7477 (push_it, pop_it): Save and restore the state of the
7478 bidi iterator. Save and restore the bidi_p flag.
7479 (pop_it): Iterate out of display property for string iteration as
7480 well.
7481 (iterate_out_of_display_property): Support iteration over strings.
7482 (handle_single_display_spec): Set up it->bidi_it for iteration
7483 over a display string, and call bidi_init_it.
7484 (handle_single_display_spec, next_overlay_string)
7485 (get_overlay_strings_1, push_display_prop): Set up the bidi
7486 iterator for displaying display or overlay strings.
7487 (forward_to_next_line_start): Don't use the shortcut if
7488 bidi-iterating.
7489 (back_to_previous_visible_line_start): If handle_display_prop
7490 pushed the iterator stack, restore the internal state of the bidi
7491 iterator by calling bidi_pop_it same number of times.
7492 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7493 and we are bidi-iterating, don't decrement the iterator position;
7494 instead, set the first_elt flag in the bidi iterator, to produce
7495 the same effect.
7496 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7497 (push_display_prop): xassert that we are iterating a buffer.
7498 (push_it, pop_it): Save and restore paragraph_embedding member.
7499 (handle_single_display_spec, next_overlay_string)
7500 (get_overlay_strings_1, reseat_1, reseat_to_string)
7501 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7502 correctly. Don't assume unibyte strings are not bidi-reordered.
7503 (compute_display_string_pos)
7504 (compute_display_string_end): Fix handling the case of C string.
7505 (push_it, pop_it): Save and restore from_disp_prop_p.
7506 (handle_single_display_spec, push_display_prop): Set the
7507 from_disp_prop_p flag.
7508 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7509 (pop_it): Call iterate_out_of_display_property only if we are
7510 popping after iteration over a string that came from a display
7511 property. Fix a typo in popping stretch info. Add an assertion
7512 for verifying that the iterator position is in sync with the bidi
7513 iterator.
7514 (handle_single_display_spec, get_overlay_strings_1)
7515 (push_display_prop): Fix initialization of paragraph direction for
7516 string when that of the parent object is not yet determined.
7517 (reseat_1): Call bidi_init_it to resync the bidi
7518 iterator with IT's position. (Bug#7616)
7519 (find_row_edges): If ROW->start.pos gives position
7520 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7521 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7522 Reset the from_disp_prop_p flag.
7523 (SAVE_IT, RESTORE_IT): New macros.
7524 (pos_visible_p, face_before_or_after_it_pos)
7525 (back_to_previous_visible_line_start)
7526 (move_it_in_display_line_to, move_it_in_display_line)
7527 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7528 (try_scrolling, redisplay_window, display_line): Use them when
7529 saving a temporary copy of the iterator and restoring it back.
7530 (back_to_previous_visible_line_start, reseat_1)
7531 (init_iterator): Empty the bidi cache "stack".
7532 (move_it_in_display_line_to): If iterator ended up at
7533 EOL, but we never saw any buffer positions smaller than
7534 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7535 motion in bidi-reordered lines.
7536 (move_it_in_display_line_to): Record prev_method and prev_pos
7537 immediately before the call to set_iterator_to_next. Fixes cursor
7538 motion in bidi-reordered lines with stretch glyphs and strings
7539 displayed in margins. (Bug#8133) (Bug#8867)
7540 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7541 TO_CHARPOS.
640c8776
SM
7542 (pos_visible_p): Support positions in bidi-reordered lines.
7543 Save and restore bidi cache.
0bb23927
EZ
7544
7545 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7546 (bidi_paragraph_info): Delete unused struct.
7547 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7548 (bidi_cache_start): New variable.
7549 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7550 to zero.
7551 (bidi_cache_fetch_state, bidi_cache_search)
7552 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7553 (bidi_cache_find, bidi_peek_at_next_level)
7554 (bidi_level_of_next_char, bidi_find_other_level_edge)
7555 (bidi_move_to_visually_next): Compare cache index with
7556 bidi_cache_start rather than with zero.
7557 (bidi_fetch_char): Accept new argument STRING; all callers
7558 changed. Support iteration over a string. Support strings with
7559 display properties. Support unibyte strings. Fix the type of
7560 `len' according to what STRING_CHAR_AND_LENGTH expects.
7561 (bidi_paragraph_init, bidi_resolve_explicit_1)
7562 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7563 (bidi_level_of_next_char, bidi_move_to_visually_next):
7564 Support iteration over a string.
0bb23927
EZ
7565 (bidi_set_sor_type, bidi_resolve_explicit_1)
7566 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7567 can now be zero (for strings); special values 0 and -1 were
7568 changed to -1 and -2, respectively.
7569 (bidi_char_at_pos): New function.
7570 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7571 Call it instead of FETCH_MULTIBYTE_CHAR.
7572 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7573 initialized to valid values.
7574 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7575 values.
7576 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7577 the test for valid cached positions. Fix the logic for looking up
7578 the sentinel state in the cache. GCPRO the Lisp string we are
7579 iterating.
7580 (bidi_push_it, bidi_pop_it): New functions.
7581 (bidi_initialize): Initialize the bidi cache start stack pointer.
7582 (bidi_cache_ensure_space): New function, refactored from part of
7583 bidi_cache_iterator_state. Don't assume the required size is just
7584 one BIDI_CACHE_CHUNK away.
7585 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7586 (bidi_count_bytes, bidi_char_at_pos): New functions.
7587 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7588 always valid if bidi_cache_idx is valid.
7589 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7590 is valid if it's going to be used.
7591 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7592 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7593 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7594 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7595 (bidi_find_other_level_edge, bidi_cache_start_stack):
7596 All variables related to cache indices are now EMACS_INT.
c965adc5 7597
0bb23927
EZ
7598 * dispextern.h (struct bidi_string_data): New structure.
7599 (struct bidi_it): New member `string'. Make flag members be 1-bit
7600 fields, and put them last in the struct.
640c8776
SM
7601 (compute_display_string_pos, compute_display_string_end):
7602 Update prototypes.
0bb23927
EZ
7603 (bidi_push_it, bidi_pop_it): Add prototypes.
7604 (struct iterator_stack_entry): New members bidi_p,
7605 paragraph_embedding, and from_disp_prop_p.
7606 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7607 (bidi_shelve_cache, bidi_unshelve_cache):
7608 Declare prototypes.
0bb23927
EZ
7609
7610 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7611 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7612 and vector-like objects.
7613
7614 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7615 cache around display iteration.
7616
7617 * window.c (Fwindow_end, window_scroll_pixel_based)
7618 (displayed_window_lines, Frecenter): Save and restore the bidi
7619 cache around display iteration.
7620
3bbd2265
LMI
76212011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7622
7623 * editfns.c (Fdelete_region): Clarify the use of the named
7624 parameters (bug#6788).
7625
adc47434
MR
76262011-07-14 Martin Rudalics <rudalics@gmx.at>
7627
7628 * indent.c (Fvertical_motion): Set and restore w->pointm when
7629 saving and restoring the window's buffer (Bug#9006).
7630
837c31f8
LMI
76312011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7632
7633 * editfns.c (Fstring_to_char): Clarify just what is returned
7634 (bug#6576). Text by Eli Zaretskii.
7635
ac389d0c
JB
76362011-07-13 Juanma Barranquero <lekktu@gmail.com>
7637
7638 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7639
0be0ce47
EZ
76402011-07-13 Eli Zaretskii <eliz@gnu.org>
7641
7642 * buffer.c (mmap_find): Fix a typo.
7643
cd18e7e3
JB
76442011-07-13 Johan Bockgård <bojohan@gnu.org>
7645
7646 Fix execution of x selection hooks.
7647 * xselect.c (Qx_lost_selection_functions)
7648 (Qx_sent_selection_functions): New vars.
7649 (syms_of_xselect): DEFSYM them.
7650 (x_handle_selection_request): Pass Qx_sent_selection_functions
7651 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7652 (x_handle_selection_clear,x_clear_frame_selections):
7653 Pass Qx_lost_selection_functions rather than
7654 Vx_lost_selection_functions to Frun_hook_with_args.
7655
47ea7f44
PE
76562011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7657
ac389d0c 7658 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7659 The old code sometimes used this field without initializing it.
7660
47ea7f44
PE
7661 * alloc.c (gc_sweep): Don't read past end of array.
7662 In theory, the old code could also have corrupted Emacs internals,
7663 though it'd be very unlikely.
7664
bc985c87
AS
76652011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7666
7667 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7668 argument. (Bug#4026)
bc985c87 7669
0cf34688
LMI
76702011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7671
b3dadd76
LMI
7672 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7673 key" (bug#4257).
7674
0cf34688
LMI
7675 * window.c (Fset_window_start): Doc fix (bug#4199).
7676 (Fset_window_hscroll): Ditto.
7677
270768cd
PE
76782011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7679
077e3dda 7680 Fix minor new problems caught by GCC 4.6.1.
270768cd 7681 * term.c (init_tty): Remove unused local.
490011a6 7682 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7683 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7684 not used otherwise.
270768cd 7685
b1f58454
CY
76862011-07-12 Chong Yidong <cyd@stupidchicken.com>
7687
7688 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7689
22b9578d
LMI
76902011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7691
6e70ab07
LMI
7692 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7693 are the mini-buffer and the echo area (bug#3320).
7694
22b9578d
LMI
7695 * term.c (init_tty): Remove support for supdup, c10 and perq
7696 terminals, which are no longer supported (bug#1482).
7697
8974cc9f
JB
76982011-07-10 Johan Bockgård <bojohan@gnu.org>
7699
7700 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7701
a560d974
JD
77022011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7703
7704 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7705 for non-popups (Bug#3642).
7706
1dae0f0a
AS
77072011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7708
268c2c36 7709 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7710 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7711 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7712 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7713 * data.c (fmod): Likewise.
7714 * dispnew.c (swap_glyphs_in_rows): Likewise.
7715 * emacs.c (memory_warning_signal): Likewise.
7716 * floatfns.c (float_error): Likewise.
7717 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7718 (otf_open, font_otf_capability, generate_otf_features)
7719 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7720 Likewise.
7721 * image.c (pbm_read_file): Likewise.
7722 * indent.c (string_display_width): Likewise.
7723 * intervals.c (check_for_interval, search_for_interval)
7724 (inc_interval_count, count_intervals, root_interval)
7725 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7726 * lread.c (defalias): Likewise.
268c2c36 7727 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7728 * regex.c (set_image_of_range_1, set_image_of_range)
7729 (regex_grow_registers): Likewise.
7730 * sysdep.c (strerror): Likewise.
7731 * termcap.c (valid_filename_p, tprint, main): Likewise.
7732 * tparam.c (main): Likewise.
7733 * unexhp9k800.c (run_time_remap, save_data_space)
7734 (update_file_ptrs, read_header, write_header, calculate_checksum)
7735 (copy_file, copy_rest, display_header): Likewise.
7736 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7737 Likewise.
7738 * xdisp.c (check_it): Likewise.
7739 * xfaces.c (register_color, unregister_color, unregister_colors):
7740 Likewise.
7741 * xfns.c (print_fontset_result): Likewise.
7742 * xrdb.c (member, fatal, main): Likewise.
7743
99033785
PE
77442011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7745
7746 Fix minor problems found by static checking (Bug#9031).
7747 * chartab.c (char_table_set_range, map_sub_char_table):
7748 Remove unused locals.
7749 (uniprop_table): Now static.
7750 * composite.c (_work_char): Remove unused static var.
7751
9cb2ac56
JB
77522011-07-09 Juanma Barranquero <lekktu@gmail.com>
7753
7754 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7755
f25661f0
JD
77562011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7757
7758 * gtkutil.c (qttip_cb): Remove code without function.
7759
8278c4fe
EZ
77602011-07-09 Eli Zaretskii <eliz@gnu.org>
7761
7762 * w32.c (pthread_sigmask): New stub.
7763
1692ae2d 77642011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7765
8a6ebd58 7766 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7767 sigprocmask is portable only for single-threaded applications, and
7768 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7769 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7770 (LIBES): Use it.
7771 * callproc.c (Fcall_process):
7772 * process.c (create_process):
7773 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7774 Use pthread_sigmask, not sigprocmask.
123403e4 7775
1b854618
JD
77762011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7777
7778 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7779 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7780 wrong (Bug#8591).
7781
3fe4b549
JD
77822011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7783
0ce7e563
JD
7784 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7785 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7786 (xg_hide_tooltip): Fix comment.
7787
3fe4b549
JD
7788 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7789 in registerServicesMenuSendTypes.
7790 (validRequestorForSendType): Don't check ns_return_types.
7791
7792 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7793 ns_return_type.
7794
5df75e47
JR
77952011-07-08 Jason Rumney <jasonr@gnu.org>
7796
22610910
JR
7797 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7798 SH_SHOW for hidden windows (Bug#5482).
7799
5df75e47
JR
7800 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7801 frame struct members of non-existent frames (Bug#6284).
7802
699c10bd
JD
78032011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7804
4393663b
JD
7805 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7806 variable firstTime not needed on OSX >= 10.6.
7807 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7808 >= 10.5. Use setKnobProportion, setDoubleValue.
7809
7810 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7811 (MAC_OS_X_VERSION_10_5): Define if not defined.
7812 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7813 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7814 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7815
7816 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 7817 cString and lossyCString on OSX >= 10.4.
4393663b 7818
58179cce 7819 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7820 sizeToFit on OSX >= 10.2.
7821
7822 * nsimage.m (allocInitFromFile): Don't use deprecated method
7823 bestRepresentationForDevice on OSX >= 10.6.
7824
7825 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7826 to avoid warning.
7827
7828 * emacs.c: Declare unexec_init_emacs_zone.
7829
a63e0781
JD
7830 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7831
699c10bd
JD
7832 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7833
7834 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7835 on svcsMenu (Bug#8842).
7836
7837 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7838 ns_return_types.
7839 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7840
7841 * nsterm.m (QUTF8_STRING): Declare.
7842 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7843 (validRequestorForSendType): Return type is (id).
7844 Change indexOfObjectIdenticalTo to indexOfObject.
7845 Check if we have local selection before returning self (Bug#8842).
7846 (writeSelectionToPasteboard): Put local selection into paste board
7847 if we have a local selection (Bug#8842).
7848 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7849
7850 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7851 (ns_get_local_selection): Declare.
7852
54e10184
LMI
78532011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7854
9888ff71
LMI
7855 * keymap.c (describe_map_tree): Don't insert a double newline at
7856 the end of the buffer (bug#1169) and return whether we inserted
7857 something.
7858
54e10184
LMI
7859 * callint.c (Fcall_interactively): Change "reading args" to
7860 "providing args" to try to clarify what it does (bug#1010).
7861
15fa4783
KH
78622011-07-07 Kenichi Handa <handa@m17n.org>
7863
7864 * composite.c (composition_compute_stop_pos): Ignore a static
7865 composition starting before CHARPOS (Bug#8915).
7866
7867 * xdisp.c (handle_composition_prop): Likewise.
7868
a8815b00
EZ
78692011-07-07 Eli Zaretskii <eliz@gnu.org>
7870
7871 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7872 (Bug#9015)
7873
ef7b981d 78742011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7875
7876 * character.h (unicode_category_t): New enum type.
7877
7878 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7879 (Qchar_code_property_table): New variable.
7880 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7881 (UNIPROP_COMPRESSED_FORM_P): New macros.
7882 (char_table_ascii): Uncompress the compressed values.
7883 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7884 Uncompress the compressed values.
ac389d0c 7885 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7886 (char_table_ref_and_range): Uncompress the compressed values.
7887 (sub_char_table_set): New arg is_uniprop. Callers changed.
7888 Uncompress the compressed values.
7889 (sub_char_table_set_range): Args changed. Callers changed.
7890 (char_table_set_range): Adjuted for the above change.
7891 (map_sub_char_table): Delete args default_val and parent. Add arg
7892 top. Give decoded values to a Lisp function.
640c8776 7893 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7894 values to a Lisp function. Gcpro more variables.
7895 (uniprop_table_uncompress)
7896 (uniprop_decode_value_run_length): New functions.
7897 (uniprop_decoder, uniprop_decoder_count): New variables.
7898 (uniprop_get_decoder, uniprop_encode_value_character)
7899 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7900 New functions.
7901 (uniprop_encoder, uniprop_encoder_count): New variables.
7902 (uniprop_get_encoder, uniprop_table)
7903 (Funicode_property_table_internal, Fget_unicode_property_internal)
7904 (Fput_unicode_property_internal): New functions.
7905 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7906 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7907 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7908 char-code-property-alist.
7909
640c8776 7910 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7911 Vunicode_category_table.
7912
640c8776 7913 * font.c (font_range): Adjust for the change of
c805dec0
KH
7914 Vunicode_category_table.
7915
76b397fb
DN
79162011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7917
7918 * m/iris4d.h: Remove file, move contents ...
7919 * s/irix6-5.h: ... here.
7920
22b4128e
PE
79212011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7922
7923 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7924 * alloc.c (mark_buffer):
7925 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7926 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7927 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7928 This isn't true in general, and it's particularly not true
7929 if Emacs is configured with --with-wide-int.
7930 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7931 New macros, used in the buffer.c change.
7932
869795d6
JD
79332011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7934
7935 * xsettings.c: Use both GConf and GSettings if both are available.
7936 (store_config_changed_event): Add comment.
7937 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7938 (store_tool_bar_style_changed): New functions.
5e617bc2 7939 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7940 (struct xsettings): Move font inside HAVE_XFT.
7941 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7942 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7943 Move inside HAVE_XFT.
640c8776 7944 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7945 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7946 also.
7947 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7948 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7949 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7950 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7951 (parse_settings): Move check for font inside HAVE_XFT.
7952 (read_settings, apply_xft_settings): Add comment.
7953 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7954 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7955 call store_font_name_changed.
7956 (xft_settings_event): Add comment.
7957 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7958 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7959 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7960 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7961 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7962 (xsettings_get_system_font, xsettings_get_system_normal_font):
7963 Add comment.
869795d6 7964
d8ed26bd
PE
79652011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7966
7967 Random fixes. E.g., (random) never returned negative values.
7968 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7969 subseconds part to the entropy, as that's a bit more random.
7970 Prefer signed to unsigned, since the signedness doesn't matter and
7971 in general we prefer signed. When given a limit, use a
7972 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7973 latter isn't right if USE_2_TAGS_FOR_INTS.
7974 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7975 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7976
cabf1cac
SM
79772011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7978
7979 * textprop.c (text_property_stickiness):
7980 Obey Vtext_property_default_nonsticky.
7981 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7982 * w32fns.c (syms_of_w32fns):
7983 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7984
6e9b2be9
PE
79852011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7986
7987 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7988 This is more efficient than Ffile_directory_p and avoids a minor race.
7989
90186c68
LMI
79902011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7991
7c301272
LMI
7992 * buffer.c (Foverlay_put): Say what the return value is
7993 (bug#7835).
7994
c4f2d8d4
LMI
7995 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7996 is a directory before asking whether to use the file name
7997 (bug#7564).
ad637907
LMI
7998 (barf_or_query_if_file_exists): Make the "File is a directory"
7999 error be more correct.
c4f2d8d4 8000
90186c68
LMI
8001 * fns.c (Frequire): Remove the mention of the .gz files, since
8002 that's installation-specific, but keep the mention of
8003 `get-load-suffixes'.
8004
da64016e
PE
80052011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8006
8007 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8008 Report string overflow if the output is too long.
8009
7d47b580
JB
80102011-07-04 Juanma Barranquero <lekktu@gmail.com>
8011
a555cb87
JB
8012 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8013 (syms_of_gnutls): Remove duplicate DEFSYM for
8014 Qgnutls_bootprop_verify_hostname_error, an error for
8015 Qgnutls_bootprop_verify_error (which is no longer used).
8016
7d47b580
JB
8017 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8018 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8019 Also (re)move comments that are misplaced or no longer relevant.
8020
1e49bfab
LMI
80212011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8022
8023 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8024
1485f4c0
CY
80252011-07-03 Chong Yidong <cyd@stupidchicken.com>
8026
8027 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8028 and background color parameters if they have been changed.
8029
a9ab721e
LMI
80302011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8031
8032 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8033
cf7cff57
PE
80342011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8035
2e13213d
PE
8036 * xsettings.c (SYSTEM_FONT): Define only when used.
8037 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8038
cf7cff57
PE
8039 * keymap.c (access_keymap_1): Now static.
8040
7a8e04f7
CY
80412011-07-02 Chong Yidong <cyd@stupidchicken.com>
8042
8043 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8044 leave any prefix arg for the up event (Bug#1586).
8045
61352f62
LMI
80462011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8047
69bb1ef7
LMI
8048 * lread.c (syms_of_lread): Mention single symbols defined by
8049 `defvar' or `defconst' (bug#7154).
8050
61352f62 8051 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8052 (Frequire): Mention get-load-suffixes.
61352f62 8053
28545e04
MR
80542011-07-02 Martin Rudalics <rudalics@gmx.at>
8055
8056 * window.h (window): Remove clone_number slot.
8057 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8058 Remove.
8059 (make_parent_window, make_window, saved_window)
8060 (Fset_window_configuration, save_window_save): Don't deal with
8061 clone numbers.
8062 * buffer.c (Qclone_number): Remove declaration.
8063 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8064
3349e122
SM
80652011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8066
8067 Add multiple inheritance to keymaps.
8068 * keymap.c (Fmake_composed_keymap): New function.
8069 (Fset_keymap_parent): Simplify.
8070 (fix_submap_inheritance): Remove.
8071 (access_keymap_1): New function extracted from access_keymap to handle
8072 embedded parents and handle lists of maps.
8073 (access_keymap): Use it.
8074 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8075 (Fcopy_keymap): Handle embedded parents.
8076 (Fcommand_remapping, define_as_prefix): Simplify.
8077 (Fkey_binding): Simplify.
8078 (syms_of_keymap): Move minibuffer-local-completion-map,
8079 minibuffer-local-filename-completion-map,
8080 minibuffer-local-must-match-map, and
8081 minibuffer-local-filename-must-match-map to Elisp.
8082 (syms_of_keymap): Defsubr make-composed-keymap.
8083 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8084 (parse_menu_item): Trivial simplification.
8085
3279eb87
GM
80862011-07-01 Glenn Morris <rgm@gnu.org>
8087
8088 * Makefile.in (SETTINGS_LIBS): Fix typo.
8089
4550efdf
KI
80902011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8091
8092 * coding.c (Fencode_coding_string): Record the last coding system
8093 used, as the function doc string says (bug#8738).
8094
0949d2b6
JD
80952011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8096
8097 * xsettings.c (store_monospaced_changed): Take new font as arg and
8098 check for change against current_mono_font.
8099 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8100 (emacs_settings_constructor, emacs_settings_get_property)
8101 (emacs_settings_set_property, emacs_settings_class_init)
8102 (emacs_settings_init, gsettings_obj): Remove.
8103 (something_changedCB): New function for HAVE_GSETTINGS.
8104 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8105 with value as argument.
8106 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8107 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8108 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8109 "changed".
8110
8111 * xgselect.c: Add defined (HAVE_GSETTINGS).
8112 (xgselect_initialize): Ditto.
8113
8114 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8115 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8116 xg_select.
8117
bbc6b304
PE
81182011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8119
8120 * eval.c (struct backtrace): Simplify and port the data structure.
8121 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8122 signed bit field, as this assumption is not portable and it makes
8123 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8124 "char debug_on_exit : 1" as this is not portable either; instead,
8125 use the portable "unsigned int debug_on_exit : 1". Remove unused
8126 member evalargs. Remove obsolete comments about cc bombing out.
8127
9851bfc5
JD
81282011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8129
51bb811f 8130 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8131 Let HAVE_GSETTINGS override HAVE_GCONF.
8132 (store_monospaced_changed): New function.
8133 (EMACS_SETTINGS): A new type derived from GObject to handle
8134 GSettings notifications.
8135 (emacs_settings_constructor, emacs_settings_get_property)
8136 (emacs_settings_set_property, emacs_settings_class_init):
8137 New functions.
8138 (gsettings_client, gsettings_obj): New variables.
8139 (GSETTINGS_SCHEMA): New define.
8140 (something_changedCB): Call store_monospaced_changed.
8141 (init_gsettings): New function.
8142 (xsettings_initialize): Call init_gsettings.
8143 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8144 to NULL.
8145
640c8776 8146 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8147 GCONF_CFLAGS/LIBS.
8148
5386012d
MR
81492011-06-29 Martin Rudalics <rudalics@gmx.at>
8150
8151 * window.c (resize_root_window, grow_mini_window)
8152 (shrink_mini_window): Rename Qresize_root_window to
8153 Qwindow_resize_root_window and Qresize_root_window_vertically to
8154 Qwindow_resize_root_window_vertically.
8155
f13e0b08
PE
81562011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8157
8158 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8159
94515237
JB
81602011-06-27 Juanma Barranquero <lekktu@gmail.com>
8161
8162 * makefile.w32-in: Redesign dependencies so they reflect more
8163 clearly which files are directly included by each source file,
8164 and not through other includes.
8165
e43b6e43
MR
81662011-06-27 Martin Rudalics <rudalics@gmx.at>
8167
8168 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8169 (sort_overlays, overlay_strings): When an overlay's clone number
8170 matches the window's clone number process the overlay even if
8171 the overlay's window property doesn't match the current window.
8172
d68443dc
MR
8173 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8174 (Fwindow_hchild): Rename to Fwindow_left_child.
8175 (Fwindow_next): Rename to Fwindow_next_sibling.
8176 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8177 (resize_window_check): Rename to window_resize_check.
8178 (resize_window_apply): Rename to window_resize_apply.
8179 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8180 (Fdelete_other_windows_internal, resize_frame_windows)
8181 (Fsplit_window_internal, Fdelete_window_internal)
8182 (grow_mini_window, shrink_mini_window)
8183 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8184
c7e73be5
JD
81852011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8186
8187 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8188 (emacs_fixed_set_min_size): Remove.
8189 (emacs_fixed_new): Take frame as argument.
8190
8191 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8192 (_EmacsFixedPrivate): Remove minwidth/height.
8193 Add struct frame *f.
8194 (emacs_fixed_init): Initialize priv->f.
8195 (get_parent_class, emacs_fixed_set_min_size): Remove.
8196 (emacs_fixed_new): Set priv->f to argument.
8197 (emacs_fixed_get_preferred_width)
8198 (emacs_fixed_get_preferred_height): Use min_width/height from
8199 frames size_hint to set minimum and natural (Bug#8919).
8200 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8201 and use min_width/height from frames size_hint to set
8202 min_width/height (Bug#8919).
8203
8204 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8205 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8206 Fix indentation.
c7e73be5 8207
cf99dcf8
EZ
82082011-06-26 Eli Zaretskii <eliz@gnu.org>
8209
8210 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8211 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8212 called at ZV.
8213
029529ac
CY
82142011-06-26 Chong Yidong <cyd@stupidchicken.com>
8215
8216 * process.c (wait_reading_process_output): Bypass select if
8217 waiting for a cell while ignoring keyboard input, and input is
8218 pending. Suggested by Jan Djärv (Bug#8869).
8219
7a7ef429
PE
82202011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8221
8222 Use gnulib's dup2 module instead of rolling our own.
8223 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8224
11fdef7d 82252011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8226
8227 * dispnew.c (scrolling_window): Before scrolling, turn off a
8228 mouse-highlight in the window being scrolled.
8229
cd3520a4
JB
82302011-06-24 Juanma Barranquero <lekktu@gmail.com>
8231
8232 Move DEFSYM to lisp.h and use everywhere.
8233
8234 * character.h (DEFSYM): Move declaration...
8235 * lisp.h (DEFSYM): ...here.
8236
8237 * gnutls.c:
8238 * minibuf.c:
8239 * w32menu.c:
8240 * w32proc.c:
8241 * w32select.c: Don't include character.h.
8242
8243 * alloc.c (syms_of_alloc):
8244 * buffer.c (syms_of_buffer):
8245 * bytecode.c (syms_of_bytecode):
8246 * callint.c (syms_of_callint):
8247 * casefiddle.c (syms_of_casefiddle):
8248 * casetab.c (init_casetab_once):
8249 * category.c (init_category_once, syms_of_category):
8250 * ccl.c (syms_of_ccl):
8251 * cmds.c (syms_of_cmds):
8252 * composite.c (syms_of_composite):
8253 * dbusbind.c (syms_of_dbusbind):
8254 * dired.c (syms_of_dired):
8255 * dispnew.c (syms_of_display):
8256 * doc.c (syms_of_doc):
8257 * editfns.c (syms_of_editfns):
8258 * emacs.c (syms_of_emacs):
8259 * eval.c (syms_of_eval):
8260 * fileio.c (syms_of_fileio):
8261 * fns.c (syms_of_fns):
8262 * frame.c (syms_of_frame):
8263 * fringe.c (syms_of_fringe):
8264 * insdel.c (syms_of_insdel):
8265 * keymap.c (syms_of_keymap):
8266 * lread.c (init_obarray, syms_of_lread):
8267 * macros.c (syms_of_macros):
8268 * msdos.c (syms_of_msdos):
8269 * print.c (syms_of_print):
8270 * process.c (syms_of_process):
8271 * search.c (syms_of_search):
8272 * sound.c (syms_of_sound):
8273 * syntax.c (init_syntax_once, syms_of_syntax):
8274 * terminal.c (syms_of_terminal):
8275 * textprop.c (syms_of_textprop):
8276 * undo.c (syms_of_undo):
8277 * w32.c (globals_of_w32):
8278 * window.c (syms_of_window):
8279 * xdisp.c (syms_of_xdisp):
8280 * xfaces.c (syms_of_xfaces):
8281 * xfns.c (syms_of_xfns):
8282 * xmenu.c (syms_of_xmenu):
8283 * xsettings.c (syms_of_xsettings):
8284 * xterm.c (syms_of_xterm): Use DEFSYM.
8285
4228cf16
TZ
82862011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8287
cd3520a4 8288 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8289
7fcccf1e
PE
82902011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8291
7efb4e0e
PE
8292 Integer and buffer overflow fixes (Bug#8873).
8293
ff5844ad
PE
8294 * print.c (printchar, strout): Check for string overflow.
8295 (PRINTPREPARE, printchar, strout):
8296 Don't set size unless allocation succeeds.
8297
90532f02
PE
8298 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8299 for sizes. Check for string overflow more accurately.
8300 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8301
6d84508d
PE
8302 * macros.c: Integer and buffer overflow fixes.
8303 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8304 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8305 Use ptrdiff_t, not int, for sizes.
8306 Don't increment bufsize until after realloc succeeds.
8307 Check for size-calculation overflow.
8308 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8309
437b2cb4
PE
8310 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8311
8b9ac8b4
PE
8312 * lread.c: Integer overflow fixes.
8313 (read_integer): Radix is now EMACS_INT, not int,
8314 to improve quality of diagnostics for out-of-range radices.
8315 Calculate buffer size correctly for out-of-range radices.
8316 (read1): Check for integer overflow in radices, and in
8317 read-circle numbers.
82cb60d3
PE
8318 (read_escape): Avoid int overflow.
8319 (Fload, openp, read_buffer_size, read1)
8320 (substitute_object_recurse, read_vector, read_list, map_obarray):
8321 Use ptrdiff_t, not int, for sizes.
8322 (read1): Use EMACS_INT, not int, for sizes.
20270765 8323 Check for size overflow.
8b9ac8b4 8324
7fcccf1e
PE
8325 * image.c (cache_image): Check for size arithmetic overflow.
8326
bfbbd7e7
PE
8327 * lread.c: Integer overflow issues.
8328 (saved_doc_string_size, saved_doc_string_length)
8329 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8330 Now ptrdiff_t, not int.
8331 (read1): Don't assume doc string length fits in int. Check for
8332 out-of-range doc string lengths.
8333 (read_list): Don't assume file position fits in int.
39019e54 8334 (read_escape): Check for hex character overflow.
bfbbd7e7 8335
4e323265
LL
83362011-06-22 Leo Liu <sdl.web@gmail.com>
8337
8338 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8339 Move to minibuffer.el.
8340
85fece3e
PE
83412011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8342
20b84ce9 8343 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8344 The following patches are for when GLYPH_DEBUG && !XASSERT.
8345 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8346 * dispnew.c (flush_stdout):
8347 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8348 Mark as externally visible.
8349 * dispnew.c (check_window_matrix_pointers): Now static.
8350 * dispnew.c (window_to_frame_vpos):
8351 * xfns.c (unwind_create_frame):
8352 * xterm.c (x_check_font): Remove unused local.
8353 * scroll.c (CHECK_BOUNDS):
8354 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8355 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8356 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8357 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8358 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8359 Now static.
8360 (debug_method_add): Use va_list and vsprintf rather than relying
8361 on undefined behavior with wrong number of arguments.
8362 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8363 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8364 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8365 since we're not interested in debugging glyphs with old libraries.
8366 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8367 GCC 4.6.0's static checking.
8368
0766b489
PE
83692011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8370
31fd4b32
PE
8371 Integer overflow and signedness fixes (Bug#8873).
8372 A few related buffer overrun fixes, too.
8373
b79e8648
PE
8374 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8375
0766b489
PE
8376 * dispextern.h (struct face.stipple):
8377 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8378 (x_bitmap_mask, x_allocate_bitmap_record)
8379 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8380 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8381 (x_create_bitmap_from_xpm_data):
8382 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8383 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8384 (.bitmaps_last):
8385 * xfaces.c (load_pixmap):
8386 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8387 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8388 (.bitmaps_last, struct x_output.icon_bitmap):
8389 Use ptrdiff_t, not int, for bitmap indexes.
8390 (x_allocate_bitmap_record): Check for size overflow.
8391 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8392
b081724f
PE
8393 Use ptrdiff_t, not int, for overlay counts.
8394 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8395 * editfns.c (overlays_around, get_pos_property):
8396 * textprop.c (get_char_property_and_overlay):
8397 * xdisp.c (next_overlay_change, note_mouse_highlight):
8398 * xfaces.c (face_at_buffer_position):
21514da7
PE
8399 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8400 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8401 (Fnext_overlay_change, Fprevious_overlay_change)
8402 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8403 Use ptrdiff_t, not int, for sizes.
21514da7 8404 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8405
3de73e5e
PE
8406 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8407
2606c57b
PE
8408 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8409 (x_session_initialize): Do not assume string length fits in int.
8410
aaafe47a
PE
8411 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8412 This is unlikely, but can occur if DPI is outlandish.
8413
2674ddc8 8414 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8415 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8416
28154962
PE
8417 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8418 * xrdb.c (magic_file_p, search_magic_path):
8419 Omit last arg SUFFIX; it was always 0. All callers changed.
8420 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8421
7de51af5
PE
8422 * xfont.c (xfont_match): Avoid need for strlen.
8423
25ed6cc3
PE
8424 * xfns.c: Don't assume strlen fits in int.
8425 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8426
4eab31dd
PE
8427 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8428 not unsigned long, as we prefer signed integers. All callers changed.
8429 Detect integer overflow in repeat count.
8430 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8431 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8432
171e2a58
PE
8433 * termcap.c: Don't assume sizes fit in int and never overflow.
8434 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8435 (gobble_line): Check for size-calculation overflow.
8436
ad39faca 8437 * minibuf.c (Fread_buffer):
6e5bb2dc 8438 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8439 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8440 Don't assume string length fits in int.
8441
52c61c22 8442 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8443 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8444
b5b8c9e5
PE
8445 * font.c: Don't assume string length fits in int.
8446 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8447 Use ptrdiff_t, not int.
ccd6111c
PE
8448 (font_intern_prop): Don't assume string length fits in int.
8449 Don't assume integer property fits in fixnum.
8450 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8451
882f0d81 8452 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8453 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8454 Reformulate so as not to need the command string.
8455 Invoke gzip -cd rather than gunzip, as it's more portable.
8456 (lock_info_type, lock_file_1, lock_file):
8457 Don't assume pid_t and time_t fit in unsigned long.
8458 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8459 (current_lock_owner): Prefer signed type for sizes.
8460 Use memcpy, not strncpy, where memcpy is what is really wanted.
8461 Don't assume (via atoi) that time_t and pid_t fit in int.
8462 Check for time_t and/or pid_t out of range, e.g., via a network share.
8463 Don't alloca where an auto var works fine.
8464
93f4cf88
PE
8465 * fileio.c: Fix some integer overflow issues.
8466 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8467 Don't assume string length fits in int.
8468 (directory_file_name): Don't assume string length fits in long.
8469 (make_temp_name): Don't assume pid fits in int, or that its print
8470 length is less than 20.
8471
f3e92b69
PE
8472 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8473
1bfdaf10
PE
8474 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8475
35016e9a
PE
8476 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8477
3d1e65a1
PE
8478 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8479 We prefer signed integers, even for size calculations.
8480
0b963a93
PE
8481 * emacs.c: Don't assume string length fits in 'int'.
8482 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8483 (main): Don't invoke strlen when not needed.
8484
573f4b54
PE
8485 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8486 (XD_DEBUG_MESSAGE): Don't waste a byte.
8487
989f33ba
PE
8488 * callproc.c (getenv_internal_1, getenv_internal)
8489 (Fgetenv_internal):
965d34eb
PE
8490 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8491
e4d29b33
PE
8492 * lread.c (invalid_syntax): Omit length argument.
8493 All uses changed. This doesn't fix a bug, but it simplifies the
8494 code away from its former Hollerith-constant appearance, and it's
8495 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8496 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8497
eb49b136
PE
8498 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8499 This didn't break anything, but it didn't help either.
8500 It's confusing to put a bogus integer in a place where the actual
8501 value does not matter.
9f62aeb1 8502 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8503 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8504
15375a22
PE
8505 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8506 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8507 implementation.
b61cc01c
PE
8508 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8509 We prefer signed types, and the value cannot exceed the EMACS_INT
8510 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8511 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8512 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8513 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8514
53b2623d
PE
8515 * indent.c (sane_tab_width): New function.
8516 (current_column, scan_for_column, Findent_to, position_indentation)
8517 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8518 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8519
51cab52b 8520 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8521
f2ed8a70
PE
8522 * lisp.h (lint_assume): New macro.
8523 * composite.c (composition_gstring_put_cache):
8524 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8525
abe80cc6
PE
8526 * editfns.c, insdel.c:
8527 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8528
b02c740e
PE
8529 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8530
ebc96716
PE
8531 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8532
b4e50fa0 8533 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8534 Use much-faster test for byte-length change.
311d5d7c 8535 Don't assume string byte-length fits in 'int'.
a4cf38e4 8536 Check that character arg fits in 'int'.
85461888 8537 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8538
c0c1ee9f
PE
8539 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8540
a498d7f4
PE
8541 * fns.c (concat): Catch string overflow earlier.
8542 Do not rely on integer wraparound.
8543
51cab52b
PE
8544 * dispextern.h (struct it.overlay_strings_charpos)
8545 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8546 * xdisp.c (forward_to_next_line_start)
8547 (back_to_previous_visible_line_start)
8548 (reseat_at_next_visible_line_start, next_element_from_buffer):
8549 Don't arbitrarily truncate the value of 'selective' to int.
8550
76031fad
PE
8551 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8552
5eb55db9
PE
8553 * composite.c: Don't truncate sizes to 'int'.
8554 (composition_gstring_p, composition_reseat_it)
8555 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8556 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8557 not EMACS_UINT, for indexes.
5eb55db9 8558
0703a717
PE
8559 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8560
d6202519
PE
8561 * buffer.c: Include <verify.h>.
8562 (struct sortvec.priority, struct sortstr.priority):
8961a454 8563 Now EMACS_INT, not int.
c20998a7 8564 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8565 (struct sortstr.size, record_overlay_string)
8566 (struct sortstrlist.size, struct sortlist.used):
8567 Don't truncate size to int.
8568 (record_overlay_string): Check for size-calculation overflow.
d6202519 8569 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8570
d5a19415
JM
85712011-06-22 Jim Meyering <meyering@redhat.com>
8572
029529ac 8573 Don't leak an XBM-image-sized buffer
d5a19415
JM
8574 * image.c (xbm_load): Free the image buffer after using it.
8575
a9041e6c
PE
85762011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8577
8578 Port to Sun C.
8579 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8580 that Sun C diagnosed.
8581 * fns.c (secure_hash): Fix pointer signedness issue.
8582 * intervals.c (static_offset_intervals): New function.
8583 (offset_intervals): Use it.
8584
7f3f739f
LL
85852011-06-21 Leo Liu <sdl.web@gmail.com>
8586
8587 * deps.mk (fns.o):
8588 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8589 sha512.h.
8590
8591 * fns.c (secure_hash): Rename from crypto_hash_function and change
8592 the first arg to accept symbols.
5b66d427 8593 (Fsecure_hash): New primitive.
7f3f739f
LL
8594 (syms_of_fns): New symbols.
8595
76147d94
DD
85962011-06-20 Deniz Dogan <deniz@dogan.se>
8597
8598 * process.c (Fset_process_buffer): Clarify return value in
8599 docstring.
8600
7d7d0045
CY
86012011-06-18 Chong Yidong <cyd@stupidchicken.com>
8602
8603 * dispnew.c (add_window_display_history): Use BVAR.
8604
8605 * xdisp.c (debug_method_add): Use BVAR.
8606 (check_window_end, dump_glyph_matrix, dump_glyph)
8607 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8608
8609 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8610 Likewise.
8611
8612 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8613 check till after the cache is created in init_frame_faces.
8614
ff2bc410
SM
86152011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8616
8617 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8618
28177add
PE
86192011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8620
dd3482fe
PE
8621 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8622 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8623 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8624
393d71f3 8625 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8626 * fileio.c (Finsert_file_contents):
8627 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8628 Remove the old (too-loose) buffer overflow checks.
8629 They weren't needed, since make_gap checks for buffer overflow.
8630 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8631 The old code merely checked for Emacs fixnum overflow, and relied
8632 on undefined (wraparound) behavior. The new code avoids undefined
8633 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8634
2e6813b0 8635 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8636 Tune. Don't use wider integers than needed. Don't use alloca.
8637 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8638
599a9e4f
PE
8639 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8640
99561444
PE
8641 * insdel.c, lisp.h (buffer_overflow): New function.
8642 (insert_from_buffer_1, replace_range, replace_range_2):
8643 * insdel.c (make_gap_larger):
8644 * editfns.c (Finsert_char):
8645 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8646
28177add
PE
8647 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8648
e69dafad
PE
86492011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8650
4baa020d 8651 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8652
b1c46f02
PE
8653 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8654 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8655
e69dafad
PE
8656 * fileio.c: Don't assume EMACS_INT fits in off_t.
8657 (emacs_lseek): New static function.
8658 (Finsert_file_contents, Fwrite_region): Use it.
8659 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8660
566684ea
PE
8661 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8662
e6966cd6
PE
8663 * fns.c: Don't overflow int when computing a list length.
8664 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8665 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8666 truncation on 64-bit hosts. Check for QUIT every
8667 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8668 faster and is responsive enough.
8669 (Flength): Report an error instead of overflowing an integer.
8670 (Fsafe_length): Return a float if the value is not representable
8671 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8672 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8673 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8674
dd0b0efb
PE
8675 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8676 (header_size, word_size): New constants.
8677 (allocate_vectorlike): Don't check size overflow here.
8678 (allocate_vector): Check it here instead, since this is the only
8679 caller of allocate_vectorlike that could cause overflow.
8680 Check that the new vector's length is representable as a fixnum.
8681
86fe5cfe
PE
8682 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8683 The previous code was bogus. For example, next_almost_prime (32)
8684 returned 39, which is undesirable as it is a multiple of 3; and
8685 next_almost_prime (24) returned 25, which is a multiple of 5 so
8686 why was the code bothering to check for multiples of 7?
8687
80e88859
PE
8688 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8689
4a2f0ad6
PE
8690 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8691
f66c7cf8
PE
8692 Variadic C functions now count arguments with ptrdiff_t.
8693 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8694 Back then I didn't know that the Emacs coding style prefers signed int.
8695 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8696 were being counted with int, which may truncate counts on 64-bit
8697 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8698 * lisp.h (struct Lisp_Subr.function.aMANY)
8699 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8700 Arg counts are now ptrdiff_t, not size_t.
8701 All variadic functions and their callers changed accordingly.
8702 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8703 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8704 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8705 * callint.c (Fcall_interactively): Check arg count for overflow,
8706 to avoid potential buffer overrun. Use signed char, not 'int',
8707 for 'varies' array, so that we needn't bother to check its size
8708 calculation for overflow.
8709 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8710 * eval.c (apply_lambda):
8711 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8712 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8713 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8714
a1759b76
PE
8715 * callint.c (Fcall_interactively): Don't use index var as event count.
8716
d96be9fc
PE
8717 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8718 * mem-limits.h (SIZE): Remove; no longer used.
8719
a690a978 8720 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8721
578c21e6
PE
8722 Remove unnecessary casts.
8723 * xterm.c (x_term_init):
8724 * xfns.c (x_set_border_pixel):
8725 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8726 These aren't needed now that we assume ANSI C.
8727
96f53c6c
PE
8728 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8729 It's more likely to cause problems (due to unsigned overflow)
8730 than to cure them.
8731
83c77d31
PE
8732 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8733
ee2079f1
PE
8734 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8735
6da65536
PE
8736 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8737
7147c4a4
PE
8738 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8739
193e32d9
PE
8740 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8741
e5533da6
PE
8742 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8743
9910e595
PE
8744 GLYPH_CODE_FACE returns EMACS_INT, not int.
8745 * dispextern.h (merge_faces):
8746 * xfaces.c (merge_faces):
01103c44
PE
8747 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8748 Don't assume EMACS_INT fits in int.
9910e595 8749
2638320e
PE
8750 * character.h (CHAR_VALID_P): Remove unused parameter.
8751 * fontset.c, lisp.h, xdisp.c: All uses changed.
8752
045eb8d9
PE
8753 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8754
c1f134b5
PE
8755 * fns.c (concat): Minor tuning based on overflow analysis.
8756 This doesn't fix any bugs. Use int to hold character, instead
8757 of constantly refetching from Emacs object. Use XFASTINT, not
8758 XINT, for value known to be a character. Don't bother comparing
8759 a single byte to 0400, as it's always less.
8760
395fcb93 8761 * floatfns.c (Fexpt):
327eeec8
PE
8762 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8763
abbd3d23
PE
8764 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8765 for characters.
8766
684a03ef
PE
8767 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8768
0fed43f3
PE
8769 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8770 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8771 incorrectly succeed when S was a string, because 4294967386 was
8772 truncated before it was used.
8773
8fd02eb7
PE
8774 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8775 Otherwise, an out-of-range integer could cause undefined behavior
8776 on a 64-bit host.
8777
f8c86b69
PE
8778 * composite.c: Use int, not EMACS_INT, for characters.
8779 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8780 EMACS_INT, for values that are known to be in character range.
8781 This doesn't fix any bugs but is the usual style inside Emacs and
8782 may generate better code on 32-bit machines.
8783
34206dd2
PE
8784 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8785 This is for reasons similar to the recent CHAR_STRING fix.
8786 * charset.c (Fencode_char): Check that character arg is actually
8787 a character. Pass an int to ENCODE_CHAR.
8788 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8789 wider than 'int', as a compile-time check to prevent future regressions
8790 in this area.
8791
c5958d4c 8792 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8793
8794 Make sure a 64-bit char is never passed to CHAR_STRING.
8795 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8796 by silently ignoring the top 32 bits, allowing some values
8797 that were far too large to be valid characters.
8798 * character.h: Include <verify.h>.
8799 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8800 arguments are no wider than unsigned, as a compile-time check
8801 to prevent future regressions in this area.
8802 * data.c (Faset):
01103c44 8803 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8804 (Fsubst_char_in_region):
8805 * fns.c (concat):
8806 * xdisp.c (decode_mode_spec_coding):
8807 Adjust to CHAR_STRING's new requirement.
8808 * editfns.c (Finsert_char, Fsubst_char_in_region):
8809 * fns.c (concat): Check that character args are actually
8810 characters. Without this test, these functions did the wrong
8811 thing with wildly out-of-range values on 64-bit hosts.
8812
d37ca623
PE
8813 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8814 These casts should not be needed on 32-bit hosts, either.
8815 * keyboard.c (read_char):
8816 * lread.c (Fload): Remove casts to unsigned.
8817
ea204efb
PE
8818 * lisp.h (UNSIGNED_CMP): New macro.
8819 This fixes comparison bugs on 64-bit hosts.
8820 (ASCII_CHAR_P): Use it.
8821 * casefiddle.c (casify_object):
01103c44 8822 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8823 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8824 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8825 * dispextern.h (FACE_FROM_ID):
8826 * keyboard.c (read_char): Use UNSIGNED_CMP.
8827
41cb286c
PE
8828 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8829 not to EMACS_INT, to avoid GCC warning.
8830
4a1b9832
PE
8831 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8832
55daad71
PE
8833 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8834 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8835 isn't needed on 32-bit machines.
8f95c75c 8836
01103c44
PE
8837 * buffer.c (Fgenerate_new_buffer_name):
8838 Use EMACS_INT for count, not int.
0ceccced 8839 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8840
8841 * data.c (Qcompiled_function): Now static.
8842
c6f072e7
PE
8843 * window.c (window_body_lines): Now static.
8844
20ce5912
PE
8845 * image.c (gif_load): Rename local to avoid shadowing.
8846
9c4c5f81
PE
8847 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8848 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8849 * alloc.c (make_save_value): Integer argument is now of type
8850 ptrdiff_t, not int.
8851 (mark_object): Use ptrdiff_t, not int.
8852 * lisp.h (pD): New macro.
8853 * print.c (print_object): Use it.
8854
c0c5c8ae
PE
8855 * alloc.c: Use EMACS_INT, not int, to count objects.
8856 (total_conses, total_markers, total_symbols, total_vector_size)
8857 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8858 (total_free_floats, total_floats, total_free_intervals)
8859 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8860 Now EMACS_INT, not int. All uses changed.
8861 (Fgarbage_collect): Compute overall total using a double, so that
8862 integer overflow is less likely to be a problem. Check for overflow
8863 when converting back to an integer.
5a25e253
PE
8864 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8865 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8866 These were 'int' variables that could overflow on 64-bit hosts;
8867 they were never used, so remove them instead of repairing them.
211a0b2a 8868 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8869 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8870 Previously, this ceilinged at INT_MAX, but that doesn't work on
8871 64-bit machines.
e46bb31a 8872 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8873
c78baabf 8874 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8875 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8876 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8877 when a (possibly-narrower) signed value would do just as well.
8878 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8879
c9d624c6
PE
8880 * alloc.c: Catch some string size overflows that we were missing.
8881 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8882 for convenience in STRING_BYTES_MAX.
8883 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8884 The definition here is exact; the one in lisp.h was approximate.
8885 (allocate_string_data): Check for string overflow. This catches
8886 some instances we weren't catching before. Also, it catches
8887 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8888 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8889 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8890
c9d624c6
PE
8891 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8892 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8893 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8894
353032ce
PE
8895 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8896
2bccce07
PE
8897 * alloc.c (Fmake_string): Check for out-of-range init.
8898
0ac30604
SM
88992011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8900
8901 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8902
c195f2de
JD
89032011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8904
8905 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8906 xg_get_default_scrollbar_width.
8907
8908 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8909 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8910 (style_changed_cb): Call update_theme_scrollbar_width and call
8911 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8912 all frames (Bug#8505).
8913 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8914 Call gtk_window_set_resizable if HAVE_GTK3.
8915 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8916 and height if HAVE_GTK3 (Bug#8505).
8917 (scroll_bar_width_for_theme): New variable.
8918 (update_theme_scrollbar_width): New function.
8919 (xg_get_default_scrollbar_width): Move code to
8920 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8921 (xg_initialize): Call update_theme_scrollbar_width.
8922
8923 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8924
8925 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8926
e10ac9f1
MR
89272011-06-12 Martin Rudalics <rudalics@gmx.at>
8928
8929 * frame.c (make_frame): Call other_buffer_safely instead of
8930 other_buffer.
8931
8932 * window.c (temp_output_buffer_show): Call display_buffer with
8933 second argument Vtemp_buffer_show_specifiers and reset latter
8934 immediately after the call.
8935 (Vtemp_buffer_show_specifiers): New variable.
8936 (auto_window_vscroll_p, next_screen_context_lines)
8937 (Vscroll_preserve_screen_position): Remove leading asterisks from
8938 doc-strings.
8939
2d3c217e 89402011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8941
7b7f97e8 8942 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8943 * buffer.c (Qclone_number): Remove for now, as it's unused.
8944 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8945 (record_buffer): Remove unused local.
8946 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8947 (set_frame_buffer_list): Remove; unused.
8948 * frame.h (other_visible_frames): Remove decl.
8949 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8950 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8951 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8952 if HAVE_GPM.
8953 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8954 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8955 Define only if HAVE_GPM.
8956 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8957 (update_hints_inhibit): Remove; never set. All uses removed.
8958 * widgetprv.h (emacsFrameClassRec): Remove decl.
8959 * window.c (delete_deletable_window): Now returns void, since it
8960 wasn't returning anything.
8961 (compare_window_configurations): Remove unused locals.
8962 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8963 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8964 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8965 the same widths as pointers. This follows up on the 2011-05-06 patch.
8966 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8967 * xterm.h: Likewise.
8968 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8969
1384b89e
JB
89702011-06-12 Juanma Barranquero <lekktu@gmail.com>
8971
8972 * makefile.w32-in: Update dependencies.
8973 (LISP_H): Add lib/intprops.h.
8974
1100a63c
CY
89752011-06-11 Chong Yidong <cyd@stupidchicken.com>
8976
8977 * image.c (gif_load): Add animation frame delay to the metadata.
8978 (syms_of_image): Use DEFSYM. New symbol `delay'.
8979
6198ccd0
MR
89802011-06-11 Martin Rudalics <rudalics@gmx.at>
8981
8982 * window.c (delete_deletable_window): Re-add.
8983 (Fset_window_configuration): Rewrite to handle dead buffers and
8984 consequently deletable windows.
8985 (window_tree, Fwindow_tree): Remove. Supply functionality in
8986 window.el.
8987 (compare_window_configurations): Simplify code.
8988
b6e3633c
AS
89892011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8990
1ab0dee5
AS
8991 * image.c (imagemagick_load_image): Fix type mismatch.
8992 (Fimagemagick_types): Likewise.
8993
b6e3633c
AS
8994 * window.h (replace_buffer_in_windows): Declare.
8995
9397e56f
MR
89962011-06-11 Martin Rudalics <rudalics@gmx.at>
8997
8998 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8999 Qclone_number. Remove external declaration of Qdelete_window.
9000 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9001 code.
640c8776
SM
9002 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9003 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9004 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9005 buffer list implementation.
9006 (other_buffer_safely): New function.
9007 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9008 calls to replace_buffer_in_windows and
9009 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9010 if allowed.
9011 (record_buffer): Inhibit quitting and rewrite using quittable
9012 functions. Run Qbuffer_list_update_hook if allowed.
9013 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9014 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9015 Move switch-to-buffer to window.el.
9397e56f
MR
9016 (bury-buffer): Move to window.el.
9017 (Vbuffer_list_update_hook): New variable.
9018
9019 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9020 section.
9021
9022 * window.h (resize_frame_windows): Move up in code.
9023 (Fwindow_frame): Remove EXFUN.
9024 (replace_buffer_in_all_windows): Remove prototype.
9025 (replace_buffer_in_windows_safely): Add prototype.
9026
9027 * window.c: Declare Qdelete_window static again. Move down
9028 declaration of select_count.
9029 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9030 (Fother_window): Move to window.el.
9031 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9032 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9033 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9034 window.el.
9035 (replace_buffer_in_windows): Implement by calling
9036 Qreplace_buffer_in_windows.
9037 (replace_buffer_in_all_windows): Remove with some functionality
9038 moved into replace_buffer_in_windows_safely.
9039 (replace_buffer_in_windows_safely): New function.
9040 (select_window_norecord, select_frame_norecord): Move in front
9041 of run_window_configuration_change_hook. Remove now obsolete
9042 declarations.
640c8776
SM
9043 (Fset_window_buffer): Rewrite doc-string.
9044 Call Qrecord_window_buffer.
9397e56f
MR
9045 (keys_of_window): Move binding for other-window to window.el.
9046
b50691aa
CY
90472011-06-11 Chong Yidong <cyd@stupidchicken.com>
9048
9049 * dispextern.h (struct image): Replace data member, whose int_val
9050 and ptr_val fields were not used by anything, with a single
9051 lisp_val object.
9052
9053 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9054 (gif_clear_image, gif_load, imagemagick_load_image)
9055 (gs_clear_image, gs_load): Callers changed.
9056
3f754b86
PE
90572011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9058
cca69397
PE
9059 * buffer.h: Include <time.h>, for time_t.
9060 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9061
109e28d0
PE
9062 Fix minor problems found by static checking.
9063
60737f02
PE
9064 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9065
4b66faf3
PE
9066 Make identifiers static if they are not used in other modules.
9067 * data.c (Qcompiled_function, Qframe, Qvector):
9068 * image.c (QimageMagick, Qsvg):
9069 * minibuf.c (Qmetadata):
9070 * window.c (resize_window_check, resize_root_window): Now static.
9071 * window.h (resize_window_check, resize_root_window): Remove decls.
9072
109e28d0
PE
9073 * window.c (window_deletion_count, delete_deletable_window):
9074 Remove; unused.
46a4ce9e
PE
9075 (window_body_lines): Now static.
9076 (Fdelete_other_windows_internal): Mark vars as initialized.
9077 Make sure 'resize_failed' is initialized.
9078 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9079 (resize_window_apply): Remove unused local.
9080 * window.h (delete_deletable_window): Remove decl.
9081
109e28d0 9082 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9083 (imagemagick_load_image): Fix pointer signedness problem by changing
9084 last arg from unsigned char * to char *. All uses changed.
9085 Also, fix a local for similar reasons.
9086 Remove unused locals. Remove locals to avoid shadowing.
9087 (fn_rsvg_handle_free): Remove; unused.
9088 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9089 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9090
3f754b86
PE
9091 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9092
2547adb1
CY
90932011-06-10 Chong Yidong <cyd@stupidchicken.com>
9094
9095 * image.c (gif_load): Fix omitted cast error introduced by
9096 2011-06-06 change.
9097
2c8e37d4
MR
90982011-06-10 Martin Rudalics <rudalics@gmx.at>
9099
9100 * window.h (resize_proportionally, orig_total_lines)
9101 (orig_top_line): Remove from window structure.
9102 (set_window_height, set_window_width, change_window_heights)
9103 (Fdelete_window): Remove prototypes.
9104 (resize_frame_windows): Remove duplicate declaration.
9105
440a42e3
EZ
91062011-06-10 Eli Zaretskii <eliz@gnu.org>
9107
9108 * window.h (resize_frame_windows, resize_window_check)
9109 (delete_deletable_window, resize_root_window)
9110 (resize_frame_windows): Declare prototypes.
9111
9112 * window.c (resize_window_apply): Make definition be "static" to
9113 match the prototype.
9114
562dd5e9
MR
91152011-06-10 Martin Rudalics <rudalics@gmx.at>
9116
9117 * window.c: Remove declarations of Qwindow_size_fixed,
9118 window_min_size_1, window_min_size_2, window_min_size,
9119 size_window, window_fixed_size_p, enlarge_window, delete_window.
9120 Remove static from declaration of Qdelete_window, it's
9121 temporarily needed by Fbury_buffer.
9122 (replace_window): Don't assign orig_top_line and
9123 orig_total_lines.
9124 (Fdelete_window, delete_window): Remove. Window deletion is
9125 handled by window.el.
640c8776
SM
9126 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9127 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9128 (Fdelete_other_windows): Remove. Deleting other windows is
9129 handled by window.el.
9130 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9131 handled in window.el.
9132 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9133 Window minimum sizes are handled in window.el.
9134 (shrink_windows, size_window, set_window_height)
9135 (set_window_width, change_window_heights, window_height)
9136 (window_width, CURBEG, CURSIZE, enlarge_window)
9137 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9138 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9139 handled in window.el.
9140 (make_dummy_parent): Rename to make_parent_window and give it a
9141 second argument horflag.
9142 (make_window): Don't set resize_proportionally any more.
9143 (Fsplit_window): Remove. Windows are split in window.el.
9144 (save_restore_action, save_restore_orig_size)
9145 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9146 Resize mini windows in window.el.
9147 (grow_mini_window, shrink_mini_window): Implement by calling
9148 Qresize_root_window_vertically, resize_window_check and
9149 resize_window_apply.
640c8776
SM
9150 (saved_window, Fset_window_configuration, save_window_save):
9151 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9152 resize_proportionally.
9153 (window_min_height, window_min_width): Move to window.el.
9154 (keys_of_window): Move bindings for delete-other-windows,
9155 split-window, delete-window and enlarge-window to window.el.
9156
9157 * buffer.c: Temporarily extern Qdelete_window.
9158 (Fbury_buffer): Temporarily call Qdelete_window instead of
9159 Fdelete_window (Fbury_buffer will move to window.el soon).
9160
9161 * frame.c (set_menu_bar_lines_1): Remove code handling
9162 orig_top_line and orig_total_lines.
9163
9164 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9165 set_window_height but set heights directly.
9166 (change_frame_size_1): Use resize_frame_windows.
9167
9168 * xdisp.c (init_xdisp): Don't use set_window_height but set
9169 heights directly.
9170
640c8776
SM
9171 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9172 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9173 run_window_configuration_change_hook.
9174
9175 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9176 instead of change_window_heights and run
9177 run_window_configuration_change_hook.
9178
1a13852e
MR
91792011-06-09 Martin Rudalics <rudalics@gmx.at>
9180
9181 * window.c (replace_window): Rename second argument REPLACEMENT to
9182 NEW. New third argument SETFLAG. Rewrite.
9183 (delete_window, make_dummy_parent): Call replace_window with
9184 third argument 1.
9185 (window_list_1): Move down in code.
9186 (run_window_configuration_change_hook): Move set_buffer part
9187 before select_frame_norecord part in order to unwind correctly.
9188 Rename count1 to count.
9189 (recombine_windows, delete_deletable_window, resize_root_window)
9190 (Fdelete_other_windows_internal)
9191 (Frun_window_configuration_change_hook, make_parent_window)
9192 (resize_window_check, resize_window_apply, Fresize_window_apply)
9193 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9194 (Fdelete_window_internal, Fresize_mini_window_internal):
9195 New functions.
1a13852e
MR
9196 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9197
f3d1777e
MR
91982011-06-08 Martin Rudalics <rudalics@gmx.at>
9199
496e208e
MR
9200 * window.h (window): Add some new members to window structure -
9201 normal_lines, normal_cols, new_total, new_normal, clone_number,
9202 splits, nest, prev_buffers, next_buffers.
9203 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9204 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9205
f3d1777e
MR
9206 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9207 Remove.
496e208e
MR
9208 (make_dummy_parent): Set new members of windows structure.
9209 (make_window): Move down in code. Handle new members of window
9210 structure.
9211 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9212 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9213 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9214 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9215 (Fset_window_next_buffers, Fset_window_clone_number):
9216 New functions.
496e208e
MR
9217 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9218 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9219 Doc-string fixes.
9220 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9221 Argument WINDOW can be now internal window too.
9222 (Fwindow_use_time): Move up in code.
9223 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9224 Rewrite doc-string.
9225 (Fset_window_configuration, saved_window)
9226 (Fcurrent_window_configuration, save_window_save): Handle new
9227 members of window structure.
b9e809c2
MR
9228 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9229 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9230 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9231 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9232 Qget_mru_window, Qresize_root_window,
9233 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9234 Qauto_buffer_name; staticpro them.
f3d1777e 9235
abde8f8c
MR
92362011-06-07 Martin Rudalics <rudalics@gmx.at>
9237
9238 * window.c (Fwindow_total_size, Fwindow_left_column)
9239 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9240 (Fwindow_list_1): New functions.
9241 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9242 (Fwindow_width, Fscroll_left, Fscroll_right):
9243 Use window_body_cols instead of window_box_text_cols.
9244 (delete_window, Fset_window_configuration):
9245 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9246 (delete_all_subwindows): Take a window as argument and not a
9247 structure. Rewrite.
190b47e6
MR
9248 (window_loop): Remove handling of GET_LRU_WINDOW and
9249 GET_LARGEST_WINDOW.
9250 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9251
9252 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9253 window_box_text_cols. delete_all_subwindows now takes a
9254 Lisp_Object as argument.
abde8f8c 9255
640c8776
SM
9256 * indent.c (compute_motion, Fcompute_motion):
9257 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9258
fa8a67e6
MR
9259 * frame.c (delete_frame): Call delete_all_subwindows with root
9260 window as argument.
9261
a54e3482
DC
92622011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9263
9264 * fns.c (Fputhash): Document return value.
9265
60002bf5
CY
92662011-06-06 Chong Yidong <cyd@stupidchicken.com>
9267
9268 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9269
0c671da6 92702011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9271
b862a52a 9272 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9273
be44ca6c
PE
9274 Check for overflow when converting integer to cons and back.
9275 * charset.c (Fdefine_charset_internal, Fdecode_char):
9276 Use cons_to_unsigned to catch overflow.
9277 (Fencode_char): Use INTEGER_TO_CONS.
9278 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9279 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9280 * data.c (long_to_cons, cons_to_long): Remove.
9281 (cons_to_unsigned, cons_to_signed): New functions.
9282 These signal an error for invalid or out-of-range values.
9283 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9284 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9285 * font.c (Ffont_variation_glyphs):
9286 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9287 * lisp.h: Include <intprops.h>.
9288 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9289 (cons_to_signed, cons_to_unsigned): New decls.
9290 (long_to_cons, cons_to_long): Remove decls.
9291 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9292 (Fprimitive_undo): Use CONS_TO_INTEGER.
9293 * xfns.c (Fx_window_property): Likewise.
9294 * xselect.c: Include <limits.h>.
9295 (x_own_selection, selection_data_to_lisp_data):
9296 Use INTEGER_TO_CONS.
9297 (x_handle_selection_request, x_handle_selection_clear)
9298 (x_get_foreign_selection, Fx_disown_selection_internal)
9299 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9300 (lisp_data_to_selection_data): Use cons_to_unsigned.
9301 (x_fill_property_data): Use cons_to_signed.
9302 Report values out of range.
9303
d1f3d2af
PE
9304 Check for buffer and string overflow more precisely.
9305 * buffer.h (BUF_BYTES_MAX): New macro.
9306 * lisp.h (STRING_BYTES_MAX): New macro.
9307 * alloc.c (Fmake_string):
9308 * character.c (string_escape_byte8):
9309 * coding.c (coding_alloc_by_realloc):
9310 * doprnt.c (doprnt):
9311 * editfns.c (Fformat):
9312 * eval.c (verror):
9313 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9314 since they may not be the same number.
9315 * editfns.c (Finsert_char):
9316 * fileio.c (Finsert_file_contents):
9317 Likewise for BUF_BYTES_MAX.
9318
dd52fcea
PE
9319 * image.c: Use ptrdiff_t, not int, for sizes.
9320 (slurp_file): Switch from int to ptrdiff_t.
9321 All uses changed.
9322 (slurp_file): Check that file size fits in both size_t (for
9323 malloc) and ptrdiff_t (for sanity and safety).
9324
7f9bbdbb
PE
9325 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9326 if b->modtime has its maximal value.
9327
dfe18f82
PE
9328 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9329
84acfcf0
PE
9330 Don't assume time_t can fit into int.
9331 * buffer.h (struct buffer.modtime): Now time_t, not int.
9332 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9333 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9334
ccd9a01a
PE
9335 Minor fixes for signed vs unsigned integers.
9336 * character.h (MAYBE_UNIFY_CHAR):
9337 * charset.c (maybe_unify_char):
9338 * keyboard.c (read_char, reorder_modifiers):
9339 XINT -> XFASTINT, since the integer must be nonnegative.
9340 * ftfont.c (ftfont_spec_pattern):
9341 * keymap.c (access_keymap, silly_event_symbol_error):
9342 XUINT -> XFASTINT, since the integer must be nonnegative.
9343 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9344 since it makes no difference and we prefer signed.
9345 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9346 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9347 nonnegative.
9348
d6d100dd
SM
93492011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9350
9351 * window.h (Fwindow_frame): Declare.
9352
2b6148e4
PE
93532011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9354
9355 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9356 (SPARE_MEMORY): Always define.
9357 (LARGE_REQUEST): Remove.
9358 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9359
f230ecc9
MR
93602011-06-06 Martin Rudalics <rudalics@gmx.at>
9361
727e958e
MR
9362 * lisp.h: Move EXFUNS for Fframe_root_window,
9363 Fframe_first_window and Fset_frame_selected_window to window.h.
9364
9365 * window.h: Move EXFUNS for Fframe_root_window,
9366 Fframe_first_window and Fset_frame_selected_window here from
9367 lisp.h.
9368
9369 * frame.c (Fwindow_frame, Fframe_first_window)
9370 (Fframe_root_window, Fframe_selected_window)
9371 (Fset_frame_selected_window): Move to window.c.
9372 (Factive_minibuffer_window): Move to minibuf.c.
9373 (Fother_visible_frames_p): New function.
9374
9375 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9376
f230ecc9
MR
9377 * window.c (decode_window, decode_any_window): Move up in code.
9378 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9379 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9380 (Fwindow_buffer): Move up and rewrite doc-string.
9381 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9382 (Fwindow_prev): New functions.
727e958e
MR
9383 (Fwindow_frame): Move here from frame.c. Accept any window as
9384 argument.
9385 (Fframe_root_window, Fframe_first_window)
9386 (Fframe_selected_window): Move here from frame.c. Accept frame
9387 or arbitrary window as argument. Update doc-strings.
9388 (Fminibuffer_window): Move up in code.
9389 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9390 (Fset_frame_selected_window): Move here from frame.c.
9391 Marginal rewrite.
727e958e
MR
9392 (Fselected_window, select_window, Fselect_window): Move up in
9393 code. Minor doc-string fixes.
f230ecc9 9394
4d09bcf6
PE
93952011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9396
9397 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9398 Do not assume that spare memory exists; that assumption is valid
9399 only if SYSTEM_MALLOC.
9400 (LARGE_REQUEST): New macro, so that the issue of large requests
9401 is separated from the issue of spare memory.
9402
810928a2
AS
94032011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9404
172418ad
AS
9405 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9406 format. (Bug#8806)
9407
43f862f7
AS
9408 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9409
810928a2
AS
9410 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9411 before statements.
9412
a059fe24
JD
94132011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9414
9415 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9416
9417 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9418
9419 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9420 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9421
989bf368
JB
94222011-06-05 Juanma Barranquero <lekktu@gmail.com>
9423
9424 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9425
4b80f674
CY
94262011-06-04 Chong Yidong <cyd@stupidchicken.com>
9427
9428 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9429 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9430 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9431 New error handlers.
4b80f674
CY
9432 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9433 Obey Vx_select_enable_clipboard_manager. Catch errors in
9434 x_clipboard_manager_save (Bug#8779).
9435 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9436 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9437
99a33b77 94382011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9439
9440 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9441
99a33b77 94422011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9443
9444 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9445 in the current matrix if keep_current_p is non-zero.
9446
8264569d
EZ
94472011-06-04 Eli Zaretskii <eliz@gnu.org>
9448
9449 * bidi.c (bidi_level_of_next_char): Fix last change.
9450
57f97249
EZ
94512011-06-03 Eli Zaretskii <eliz@gnu.org>
9452
fec2107c 9453 Support bidi reordering of text covered by display properties.
57f97249 9454
fec2107c
EZ
9455 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9456 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9457 (bidi_cache_search, bidi_cache_iterator_state)
9458 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9459 (bidi_level_of_next_char, bidi_move_to_visually_next):
9460 Support character positions inside a run of characters covered by a
fec2107c
EZ
9461 display string.
9462 (bidi_paragraph_init, bidi_resolve_explicit_1)
9463 (bidi_level_of_next_char): Call bidi_fetch_char and
9464 bidi_fetch_char_advance instead of FETCH_CHAR and
9465 FETCH_CHAR_ADVANCE.
9466 (bidi_init_it): Initialize new members.
9467 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9468 definitions.
9469 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9470 instead of using explicit *_CHAR codes.
d6d100dd
SM
9471 (bidi_resolve_explicit, bidi_resolve_weak):
9472 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9473 bidirectional text is supported only in multibyte buffers.
9474 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9475 it to initialize the frame_window_p member of struct bidi_it.
9476 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9477 (bidi_resolve_explicit, bidi_resolve_weak)
9478 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9479 bidi_it->nchars is non-positive.
9480 (bidi_level_of_next_char): Don't try to lookup the cache for the
9481 next/previous character if nothing is cached there yet, or if we
9482 were just reseat()'ed to a new position.
c40e2fb2 9483
0e14fe90
EZ
9484 * xdisp.c (set_cursor_from_row): Set start and stop points
9485 according to the row's direction when priming the loop that looks
9486 for the glyph on which to display cursor.
9487 (single_display_spec_intangible_p): Function deleted.
9488 (display_prop_intangible_p): Reimplement to call
9489 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9490 Accept 3 additional arguments needed by handle_display_spec.
9491 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9492 values: lists, `(when COND...)' forms, etc.
9493 (single_display_spec_string_p): Support property values that are
9494 lists with the argument STRING its top-level element.
9495 (display_prop_string_p): Fix the condition for processing a
9496 property that is a list to be consistent with handle_display_spec.
fec2107c 9497 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9498 last portion of handle_display_prop.
9499 (compute_display_string_pos): Accept additional argument
9500 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9501 value of a `display' property is a "replacing spec".
9502 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9503 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9504 the display property, but just return a value indicating whether
9505 the display property will replace the characters it covers.
9506 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9507 frame_window_p members of struct bidi_it.
d6d100dd
SM
9508 (compute_display_string_pos, compute_display_string_end):
9509 New functions.
fec2107c
EZ
9510 (push_it): Accept second argument POSITION, where pop_it should
9511 jump to continue iteration.
9512 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9513
fec2107c
EZ
9514 * keyboard.c (adjust_point_for_property): Adjust the call to
9515 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9516
9517 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9518 (bidi_init_it): Update prototypes.
9519 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9520 (compute_display_string_pos, compute_display_string_end):
9521 Declare prototypes.
fec2107c
EZ
9522 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9523 EMACS_INT.
fc6f18ce 9524
40087514 95252011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9526
57f53182
PE
9527 Malloc failure behavior now depends on size of allocation.
9528 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9529 * lisp.h: Change signatures accordingly.
9530 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9531 All callers changed. (Bug#8762)
9532
9533 * gnutls.c: Use Emacs's memory allocators.
9534 Without this change, the gnutls library would invoke malloc etc.
9535 directly, which causes problems on non-SYNC_INPUT hosts, and which
9536 runs afoul of improving memory_full behavior. (Bug#8761)
9537 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9538 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9539 xfree instead of the default malloc, realloc, free.
9540 (Fgnutls_boot): No need to check for memory allocation failure,
9541 since xmalloc does that for us.
9542
ac32cd99 9543 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9544 * category.c (hash_get_category_set):
9545 * ccl.c (ccl_driver):
9546 * charset.c (Fdefine_charset_internal):
9547 * charset.h (struct charset.hash_index):
9548 * composite.c (get_composition_id, gstring_lookup_cache)
9549 (composition_gstring_put_cache):
9550 * composite.h (struct composition.hash_index):
9551 * dispextern.h (struct image.hash):
9552 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9553 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9554 (hashfn_equal, hashfn_user_defined, make_hash_table)
9555 (maybe_resize_hash_table, hash_lookup, hash_put)
9556 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9557 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9558 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9559 * image.c (make_image, search_image_cache, lookup_image)
9560 (xpm_put_color_table_h):
9561 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9562 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9563 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9564 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9565 * alloc.c (allocate_vectorlike):
9566 Check for overflow in vector size calculations.
9567 * ccl.c (ccl_driver):
9568 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9569 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9570 need to be updated by these changes.
40087514
PE
9571 * fns.c (make_hash_table, maybe_resize_hash_table):
9572 Check for integer overflow with large hash tables.
0de4bb68
PE
9573 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9574 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9575 (SXHASH_REDUCE): New macro.
9576 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9577 Use it instead of discarding useful hash info with large hash values.
9578 (sxhash_float): New function.
9579 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9580 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9581 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9582 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9583 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9584 Adjust signatures to match updated version of code.
9585 (consing_since_gc): Now EMACS_INT, since a single hash table can
9586 use more than INT_MAX bytes.
9587
698d32e2
DN
95882011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9589
9590 Make it possible to build with GCC-4.6+ -O2 -flto.
9591
9592 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9593
fd6fa53f
SM
95942011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9595
9596 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9597 Call minibuffer-inactive-mode.
9598
864db017
JB
95992011-05-31 Juanma Barranquero <lekktu@gmail.com>
9600
9601 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9602 Update dependencies.
9603
2ad0baf4
DN
96042011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9605
9606 * data.c (init_data): Remove code for UTS, this system is not
9607 supported anymore.
9608
4fcc2638
DN
96092011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9610
9611 Don't force ./temacs to start in terminal mode.
9612
9613 * frame.c (make_initial_frame): Initialize faces in all cases, not
9614 only when CANNOT_DUMP is defined.
9615 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9616
c56e0fd5
DN
96172011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9618
9619 * dispnew.c (add_window_display_history): Use const for the string
9620 pointer. Remove declaration, not needed.
9621
333d54da 96222011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9623
55d4c1b2 9624 Use 'inline', not 'INLINE'.
333d54da 9625 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9626 * alloc.c, fontset.c (INLINE): Remove.
9627 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9628 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9629 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9630 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9631 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9632
738db178
DN
96332011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9634
9635 Make it possible to run ./temacs.
9636
9637 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9638 syms_of_callproc does the same thing. Remove test for
9639 "initialized", do it in the caller.
9640 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9641
620c53a6
SM
96422011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9643
9644 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9645 (read_minibuf): Use get_minibuffer.
9646 (syms_of_minibuf): Use DEFSYM.
9647 (Qmetadata): New var.
9648 * data.c (Qbuffer): Don't make it static.
9649 (syms_of_data): Use DEFSYM.
9650
e003a292
PE
96512011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9652
9653 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9654 (CCL_CODE_MIN): New macro.
9655
ed008a6d
PE
96562011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9657
3687c2ef
PE
9658 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9659
ed008a6d
PE
9660 * eval.c (Qdebug): Now static.
9661 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9662 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9663 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9664
d66c4c7c
CY
96652011-05-29 Chong Yidong <cyd@stupidchicken.com>
9666
9667 * image.c: Various fixes to ImageMagick code comments.
9668 (Fimagemagick_types): Doc fix.
9669
5fbc2025
PE
96702011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9671
0196f88a
PE
9672 Minor fixes prompted by GCC 4.6.0 warnings.
9673
9674 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9675
5fbc2025
PE
9676 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9677 (x_clipboard_manager_save_all): Move extern decl to ...
9678 * xterm.h: ... here, so that it can be checked for consistency.
9679
1dd3c2d9
CY
96802011-05-29 Chong Yidong <cyd@stupidchicken.com>
9681
9682 * xselect.c (x_clipboard_manager_save_frame)
9683 (x_clipboard_manager_save_all): New functions.
9684 (Fx_clipboard_manager_save): Lisp function deleted.
9685
9686 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9687 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9688
9689 * xterm.h: Update prototype.
9690
5ba6571d
WX
96912011-05-28 William Xu <william.xwl@gmail.com>
9692
9693 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9694 exiting (Bug#8239).
9695
3eaff834
JM
96962011-05-28 Jim Meyering <meyering@redhat.com>
9697
e1900994 9698 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9699 * fns.c (to_uchar): Define.
9700 (crypto_hash_function): Use it to convert some newly-signed
9701 variables to unsigned, to avoid sign-extension bugs. For example,
9702 without this change, (md5 "truc") would evaluate to
9703 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9704 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9705 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9706
0f6990a7
PE
97072011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9708
9709 Integer overflow fixes.
c8a9ca5a 9710
08686060
PE
9711 * dbusbind.c: Serial number integer overflow fixes.
9712 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9713 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9714 to hold a serial number that is too large for a fixnum.
9715 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9716 Check for serial numbers out of range. Decode any serial number
59568bf0 9717 that was so large that it became a float. (Bug#8722)
08686060 9718
2d1fc3c7
PE
9719 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9720 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9721 Use XFASTINT rather than XUINT when numbers are nonnegative.
9722 (xd_append_arg, Fdbus_method_return_internal):
9723 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9724 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9725 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9726 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9727 (Bug#8722)
2d1fc3c7 9728
c8a9ca5a
PE
9729 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9730
519e1d69
PE
9731 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9732
6df6ae42 9733 ccl: Add integer overflow checks.
30569699
PE
9734 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9735 (IN_INT_RANGE): New macros.
9736 (ccl_driver): Use them to check for integer overflow when
9737 decoding a CCL program. Many of the new checks are whether XINT (x)
9738 fits in int; it doesn't always, on 64-bit hosts. The new version
9739 doesn't catch all possible integer overflows, but it's an
847044ea 9740 improvement. (Bug#8719)
30569699 9741
c11285dc
PE
9742 * alloc.c (make_event_array): Use XINT, not XUINT.
9743 There's no need for unsigned here.
9744
fdccd48e
PE
9745 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9746 This follows up to the 2011-05-06 change that substituted uintptr_t
9747 for EMACS_INT. This case wasn't caught back then.
9748
37910ab2
PE
9749 Rework Fformat to avoid integer overflow issues.
9750 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9751 now (part of C89). Include <verify.h>.
9752 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9753 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9754 (Fformat): Avoid the prepass trying to compute sizes; it was only
9755 approximate and thus did not catch overflow reliably. Instead, walk
9756 through the format just once, formatting and computing sizes as we go,
9757 checking for integer overflow at every step, and allocating a larger
9758 buffer as needed. Keep track separately whether the format is
9759 multibyte. Keep only the most-recently calculated precision, rather
9760 than them all. Record whether each argument has been converted to
9761 string. Use EMACS_INT, not int, for byte and char and arg counts.
9762 Support field widths and precisions larger than INT_MAX. Avoid
9763 sprintf's undefined behavior with conversion specifications such as %#d
9764 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9765 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9766 formatting out-of-range floating point numbers with int
9173deec 9767 formats. (Bug#8668)
37910ab2 9768
2e6578fb
PE
9769 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9770
0ae6bdee
PE
9771 * data.c: Avoid integer truncation in expressions involving floats.
9772 * data.c: Include <intprops.h>.
9773 (arith_driver): When there's an integer overflow in an expression
9774 involving floating point, convert the integers to floating point
9775 so that the resulting value does not suffer from catastrophic
9776 integer truncation. For example, on a 64-bit host (* 4
9777 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9778 Do not rely on undefined behavior after integer overflow.
9779
de883a70
PE
9780 merge count_size_as_multibyte, parse_str_to_multibyte
9781 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9782 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9783 Check for integer overflow.
9784 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9785 since it's now a duplicate of the other. This is more of
9786 a character than a buffer op, so better that it's in character.c.
9787 * fns.c, print.c: Adjust to above changes.
9788
2ff916cb
PE
97892011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9790
9791 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9792
f1b54466
PE
97932011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9794
fb1ac845
PE
9795 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9796 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9797 (x_clipboard_manager_save): Now static.
9798 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9799
f1b54466
PE
9800 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9801 (crypto_hash_function): Now static.
9802 Fix pointer signedness problems. Avoid unnecessary initializations.
9803
a9f737ee
CY
98042011-05-27 Chong Yidong <cyd@stupidchicken.com>
9805
9806 * termhooks.h (Vselection_alist): Make it terminal-local.
9807
9808 * terminal.c (create_terminal): Initialize it.
9809
9810 * xselect.c: Support for clipboard managers.
9811 (Vselection_alist): Move to termhooks.h as terminal-local var.
9812 (LOCAL_SELECTION): New macro.
9813 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9814 (symbol_to_x_atom): Remove gratuitous arg.
9815 (x_handle_selection_request, lisp_data_to_selection_data)
9816 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9817 (x_own_selection, x_get_local_selection, x_convert_selection):
9818 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9819 (some_frame_on_display): Delete unused function.
9820 (Fx_own_selection_internal, Fx_get_selection_internal)
9821 (Fx_disown_selection_internal, Fx_selection_owner_p)
9822 (Fx_selection_exists_p): New optional frame arg.
9823 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9824 (x_handle_selection_clear): Don't treat other terminals with the
9825 same keyboard specially. Use the terminal-local Vselection_alist.
9826 (x_clear_frame_selections): Use Frun_hook_with_args.
9827
9828 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9829
9830 * xterm.h: Add support for those atoms.
9831
e067f0c1
CY
98322011-05-26 Chong Yidong <cyd@stupidchicken.com>
9833
9834 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9835 (converted_selections, conversion_fail_tag): New global variables.
9836 (x_selection_request_lisp_error): Free the above.
9837 (x_get_local_selection): Remove unnecessary code.
9838 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9839 of converted selections stored in converted_selections.
9840 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9841 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9842 (x_convert_selection): New function.
9843 (x_handle_selection_event): Simplify.
9844 (x_get_foreign_selection): Don't ignore incoming requests while
9845 waiting for an answer; this will fail when we implement
9846 SAVE_TARGETS, and seems unnecessary anyway.
9847 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9848 (Vx_sent_selection_functions): Doc fix.
9849
0f4aebc0
LL
98502011-05-26 Leo Liu <sdl.web@gmail.com>
9851
9852 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9853
e61124cd
YM
98542011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9855
9856 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9857
9858 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9859 for fringe update if it has periodic bitmap.
ac389d0c 9860 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9861 and fringe_bitmap_periodic_p.
9862
9863 * fringe.c (get_fringe_bitmap_data): New function.
9864 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9865 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9866 row. Mark glyph row for fringe update if periodicity changed.
9867
9868 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9869 for fringe update unless it has periodic bitmap.
9870
f16d9837
KH
98712011-05-25 Kenichi Handa <handa@m17n.org>
9872
9873 * xdisp.c (get_next_display_element): Set correct it->face_id for
9874 a static composition.
9875
e1b90ef6
LL
98762011-05-24 Leo Liu <sdl.web@gmail.com>
9877
9878 * deps.mk (fns.o):
9879 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9880
9881 * fns.c (crypto_hash_function, Fsha1): New function.
9882 (Fmd5): Use crypto_hash_function.
9883 (syms_of_fns): Add Ssha1.
9884
7400048f
PE
98852011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9886
9887 * gnutls.c: Remove unused macros.
9888 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9889 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9890 Remove macros that are defined and never used.
9891 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9892
abb71cf4
CY
98932011-05-22 Chong Yidong <cyd@stupidchicken.com>
9894
9895 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9896 (Fx_get_selection_internal): Minor cleanup.
9897 (Fx_own_selection_internal): Rename arguments for consistency with
9898 select.el.
9899
6307db39
PE
99002011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9901
9902 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9903
f3d4e0a4
CY
99042011-05-22 Chong Yidong <cyd@stupidchicken.com>
9905
9906 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9907
4d8ade89
YM
99082011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9909
9910 * dispnew.c (scrolling_window): Don't exclude the case that the
9911 last enabled row in the desired matrix touches the bottom boundary.
9912
32078c8d
GM
99132011-05-21 Glenn Morris <rgm@gnu.org>
9914
9915 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9916 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9917 and add some more files.
32078c8d 9918
7285dc67
EZ
99192011-05-20 Eli Zaretskii <eliz@gnu.org>
9920
9921 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9922 report_file_error introduced by the change from 2011-05-07.
9923
89d1bd22
PE
99242011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9925
9926 * systime.h (Time): Define only if emacs is defined.
9927 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9928 where the include path doesn't have X11/X.h by default. See
9929 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9930
cd394be1 99312011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9932
9933 * composite.c (find_automatic_composition): Fix previous change.
9934
b9704ad9
GM
99352011-05-20 Glenn Morris <rgm@gnu.org>
9936
9937 * lisp.mk: New file, split from Makefile.in.
9938 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9939 (shortlisp): Remove.
9940 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9941
4a720484
GM
99422011-05-19 Glenn Morris <rgm@gnu.org>
9943
9944 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9945 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9946 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9947 (lisp): Set the order to that of loadup.el.
9948 (shortlisp): Make it a copy of $lisp.
9949 (SOME_MACHINE_LISP): Remove.
9950 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9951 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9952
a28d4396
KH
99532011-05-18 Kenichi Handa <handa@m17n.org>
9954
9955 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9956 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9957 (find_automatic_composition): Mostly rewrite for efficiency.
9958
a2b1fa8e
JB
99592011-05-18 Juanma Barranquero <lekktu@gmail.com>
9960
9961 * makefile.w32-in: Update dependencies.
9962
8e1f5610
CS
99632011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9964
9965 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9966 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9967
7025ee00 99682011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9969
cdfa6eab
PE
9970 Fix some integer overflow issues, such as string length overflow.
9971
06d6db33
PE
9972 * insdel.c (count_size_as_multibyte): Check for string overflow.
9973
2b4560a8
PE
9974 * character.c (lisp_string_width): Check for string overflow.
9975 Use EMACS_INT, not int, for string indexes and lengths; in
9976 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9977 the resulting string length overflows an EMACS_INT; instead,
9978 report a string overflow if no precision given. When checking for
9979 precision exhaustion, use a check that cannot possibly have
9980 integer overflow. (Bug#8675)
9981 * character.h (lisp_string_width): Adjust to new signature.
9982
cb93f9be
PE
9983 * alloc.c (string_overflow): New function.
9984 (Fmake_string): Use it. This doesn't change behavior, but saves
9985 a few bytes and will simplify future changes.
9986 * character.c (string_escape_byte8): Likewise.
9987 * lisp.h (string_overflow): New decl.
9988
1a1f3366
PE
9989 Fixups, following up to the user-interface timestamp change.
9990 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9991 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9992 * msdos.c (mouse_get_pos): Likewise.
9993 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9994 * w32gui.h (Time): Define by including "systime.h" rather than by
9995 declaring it ourselves. (Bug#8664)
9996
d4e3e4d3
PE
9997 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9998 * image.c (clear_image_cache): Likewise.
9999
f6a24d19
PE
10000 * term.c (term_mouse_position): Don't assume time_t wraparound.
10001
08dc5ae6
PE
10002 Be more systematic about user-interface timestamps.
10003 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10004 and sometimes 'EMACS_UINT', to represent these timestamps.
10005 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10006 This makes the code easier to follow, and makes it easier to catch
10007 integer overflow bugs such as Bug#8664.
10008 * frame.c (Fmouse_position, Fmouse_pixel_position):
10009 Use Time, not unsigned long, for user-interface timestamps.
10010 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10011 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10012 * keyboard.h (last_event_timestamp): Likewise.
10013 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10014 * menu.h (xmenu_show): Likewise.
10015 * term.c (term_mouse_position): Likewise.
10016 * termhooks.h (struct input_event.timestamp): Likewise.
10017 (struct terminal.mouse_position_hook): Likewise.
10018 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10019 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10020 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10021 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10022 what it was before.
10023 * menu.h, termhooks.h: Include "systime.h", for Time.
10024
8e55734a
PE
10025 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10026 Don't assume that the difference between two unsigned long values
10027 can fit into an integer. At this point, we know button_down_time
10028 <= event->timestamp, so the difference must be nonnegative, so
10029 there's no need to cast the result if double-click-time is
10030 nonnegative, as it should be; check that it's nonnegative, just in
10031 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10032 apart (about 25 days). (Bug#8664)
8e55734a 10033
841f1b75 10034 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10035 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10036
3e26f69c
PE
10037 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10038 that always fit in int. Use a sentinel instead of a counter, to
10039 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10040 * frame.h (struct frame): Use int for menu_bar_items_used
10041 instead of EMACS_INT, since it always fits in int.
3e26f69c 10042
5cc152c0
PE
10043 * menu.c (grow_menu_items): Check for int overflow.
10044
d89eb65e
PE
10045 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10046
5235bd3e
PE
10047 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10048 Before, the code was not consistent. These values cannot exceed
10049 2**31 - 1 so there's no need to make them unsigned.
10050 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10051 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10052 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10053 as modifiers.
10054 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10055
bc827e23
PE
10056 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10057 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10058 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10059 presumably because the widths might not match.
10060
78eb494e
PE
10061 * window.c (size_window): Avoid needless test at loop start.
10062
04f2d78b
CB
100632011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10064
10065 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10066
d2fc7e3d 100672011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10068
10069 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10070
d2fc7e3d 100712011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10072
10073 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10074 `width' to `bar_area_x' and `bar_area_width', respectively.
10075 (x_scroll_run): Take account of fringe background extension.
10076
04f2d78b
CB
10077 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10078 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10079 `bar_area_width', respectively.
10080 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10081 background extension.
10082
79b70037
GM
100832011-05-10 Jim Meyering <meyering@redhat.com>
10084
10085 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10086
2f142cc5
JB
100872011-05-10 Juanma Barranquero <lekktu@gmail.com>
10088
10089 * image.c (Finit_image_library): Return t for built-in image types,
10090 like pbm and xbm. (Bug#8640)
10091
57679c86
AS
100922011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10093
10094 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10095
888c9e86
EZ
100962011-05-07 Eli Zaretskii <eliz@gnu.org>
10097
b0512a1d
EZ
10098 * w32console.c (Fset_screen_color): Doc fix.
10099 (Fget_screen_color): New function.
10100 (syms_of_ntterm): Defsubr it.
10101
7285dc67
EZ
10102 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10103 unlink the temporary file if Fcall_process didn't create it in the
10104 first place.
10105 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10106 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10107 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10108 cue to call_process_cleanup not to close that handle.
10109
4d3fcc8e
BK
101102011-05-07 Ben Key <bkey76@gmail.com>
10111
10112 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10113 one of two shell specific rules, either bootstrap-temacs-CMD or
10114 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10115 to the previous implementation of the bootstrap-temacs rule.
10116 The bootstrap-temacs-CMD rule is similar to the previous
10117 implementation of the bootstrap-temacs rule except that it
10118 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10119 variable.
10120
10121 These changes, along with some changes to nt/configure.bat,
10122 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10123 earlier fix to add support for --cflags and --ldflags options
10124 that include quotes so that it works whether make uses cmd or
10125 sh as the shell.
10126
b4289b64
MA
101272011-05-06 Michael Albinus <michael.albinus@gmx.de>
10128
10129 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10130 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10131 is a constant.
10132 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10133 a string. Handle both cases.
10134 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10135 (Fdbus_register_method): Use Qinvalid_function.
10136
af4c0e28
JB
101372011-05-06 Juanma Barranquero <lekktu@gmail.com>
10138
10139 * makefile.w32-in: Update dependencies.
10140 (LISP_H): Add inttypes.h and stdin.h.
10141 (PROCESS_H): Add unistd.h.
10142
c51453d9
EZ
101432011-05-06 Eli Zaretskii <eliz@gnu.org>
10144
10145 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10146 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10147
8ff0ac3c 101482011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10149
4c4b566b
PE
10150 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10151
aab2b9b5
PE
10152 * term.c (vfatal): Remove stray call to va_end.
10153 It's not needed and the C Standard doesn't allow it here anyway.
10154
c378da0b
PE
10155 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10156 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10157
288b08c7
PE
10158 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10159 bytes.
10160
e3601888
PE
10161 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10162
db6c0e74
PE
10163 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10164
dd5963ea
PE
10165 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10166
88c9450f
PE
10167 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10168
2f9442b8
PE
10169 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10170
c032b5f8
PE
10171 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10172 * charset.c (Fdefine_charset_internal): Don't initialize
10173 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10174 32-bit int (Bug#8600).
a108c10b
PE
10175
10176 * lread.c (read_integer): Be more consistent with string-to-number.
10177 Use string_to_number to do the actual conversion; this avoids
10178 rounding errors and fixes some other screwups. Without this fix,
10179 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10180 (digit_to_number): Move earlier, for benefit of read_integer.
10181 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10182 not a digit in any supported base. (Bug#8602)
a108c10b 10183
ad5f9eea
PE
10184 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10185
aec1708a
PE
10186 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10187 to match comment at start of function. This also removes a
10188 GCC warning about overflow in a 32+64-bit port.
10189
47be4ab5
PE
10190 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10191
371cac43
PE
10192 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10193 Reported by Stefan Monnier in
10194 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10195 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10196 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10197
d01a7826
PE
10198 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10199 (EMACS_UINTPTR): Likewise, with uintptr_t.
10200
7fd47d5c
PE
10201 * lisp.h: Prefer 64-bit EMACS_INT if available.
10202 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10203 on 32-bit hosts that have 64-bit int, so that they can access
10204 large files.
122b0c86
PE
10205 However, temporarily disable this change unless the temporary
10206 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10207
8727937b
PE
10208 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10209
8ac068ac
PE
10210 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10211 This removes an assumption that EMACS_INT and long are the same
10212 width as pointers. The assumption is true for Emacs porting targets
10213 now, but we want to make other targets possible.
10214 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10215 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10216 In the rest of the code, change types of integers that hold casted
10217 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10218 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10219 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10220 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10221 No need to cast type when ORing.
10222 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10223 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10224 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10225 assume EMACS_INT is the same width as char *.
10226 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10227 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10228 Remove no-longer-needed casts.
10229 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10230 (xg_tool_bar_help_callback, xg_make_tool_item):
10231 Use EMACS_INTPTR to hold an integer
10232 that will be cast to void *; this can avoid a GCC warning
10233 if EMACS_INT is not the same width as void *.
10234 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10235 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10236 (current_message_1, set_message_1):
10237 Use a local to convert to proper width without a cast.
10238 * xmenu.c (dialog_selection_callback): Likewise.
10239
ede49d71
PE
10240 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10241 Also, don't assume VALBITS / RAND_BITS is less than 5,
10242 and don't rely on undefined behavior when shifting a 1 left into
10243 the sign bit.
10244 * lisp.h (get_random): Change signature to match.
10245
2f30ecd0
PE
10246 * lread.c (hash_string): Use size_t, not int, for hash computation.
10247 Normally we prefer signed values; but hashing is special, because
10248 it's better to use unsigned division on hash table sizes so that
10249 the remainder is nonnegative. Also, size_t is the natural width
10250 for hashing into memory. The previous code used 'int', which doesn't
10251 retain enough info to hash well into very large tables.
10252 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10253
2a866e7b
PE
10254 * dbusbind.c: Don't possibly lose pointer info when converting.
10255 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10256 Use XPNTR rather than XHASH, so that the high-order bits of
10257 the pointer aren't lost when converting through void *.
10258
51639eac
PE
10259 * eval.c (Fautoload): Don't double-shift a pointer.
10260
92394119
PE
10261 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10262
dbdb9a7c
JB
102632011-05-06 Juanma Barranquero <lekktu@gmail.com>
10264
10265 * gnutls.c (DEF_GNUTLS_FN):
10266 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10267
db7a0b4f
AS
102682011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10269
10270 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10271 marker. (Bug#8610)
10272
cd394be1 102732011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10274
10275 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10276 New version that can reserve upto 2GB of heap space.
10277
f7ff1b0f 102782011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10279
10280 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10281
639c109b
TZ
102822011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10283
10284 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10285 `gnutls_certificate_set_x509_key_file'.
10286
d2127135
JB
102872011-05-05 Juanma Barranquero <lekktu@gmail.com>
10288
10289 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10290 Update dependencies.
10291
e968f4f3
JB
102922011-05-04 Juanma Barranquero <lekktu@gmail.com>
10293
10294 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10295 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10296 Remove unused parameter `fildes'.
10297 * process.c (read_process_output, send_process): Don't pass it.
10298
84d358f0
JB
102992011-05-04 Juanma Barranquero <lekktu@gmail.com>
10300
10301 Fix previous change: the library cache is defined in w32.c.
10302 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10303 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10304
0898ca10
JB
103052011-05-04 Juanma Barranquero <lekktu@gmail.com>
10306
10307 Implement dynamic loading of GnuTLS on Windows.
10308
10309 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10310 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10311 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10312 Declare.
10313
10314 * gnutls.c (Qgnutls_dll): Define.
10315 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10316 (gnutls_*): Declare function pointers.
10317 (init_gnutls_functions): New function to initialize function pointers.
10318 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10319 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10320 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10321 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10322 (emacs_gnutls_write, emacs_gnutls_read)
10323 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10324 (Fgnutls_available_p): New function.
10325 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10326 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10327 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10328
10329 * image.c: Include w32.h.
10330 (Vimage_type_cache): Delete.
10331 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10332 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10333 (w32_delayed_load): Move to w32.c.
10334
10335 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10336
10337 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10338 (w32_delayed_load): Move from image.c. When loading a library, record
10339 its filename in the :loaded-from property of the library id.
10340 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10341 Initialize and staticpro them.
10342 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10343
10344 * process.c: Include lisp.h before w32.h, not after.
10345 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10346 instead of gnutls_record_check_pending.
10347
10348 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10349
ff4de4aa
TZ
103502011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10351
10352 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10353 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10354 as passed in.
10355
abe95abb
JD
103562011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10357
10358 * xterm.c (x_set_frame_alpha): Do not set property on anything
10359 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10360
e16e55d4
JB
103612011-05-02 Juanma Barranquero <lekktu@gmail.com>
10362
10363 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10364
bafcf6a5
JB
103652011-05-02 Juanma Barranquero <lekktu@gmail.com>
10366
10367 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10368 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10369 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10370 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10371 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10372 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10373 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10374 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10375 (Qgnutls_bootprop_callbacks_verify): Make static.
10376
e7a6747f
AS
103772011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10378
19ed11ba
AS
10379 * callproc.c: Indentation fixup.
10380
e7a6747f 10381 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10382 (wait_for_termination, interruptible_wait_for_termination):
10383 Move after wait_for_termination_1.
e7a6747f 10384
1ef14cb4
LMI
103852011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10386
10387 * sysdep.c (interruptible_wait_for_termination): New function
10388 which is like wait_for_termination, but allows keyboard
10389 interruptions.
10390
10391 * callproc.c (Fcall_process): Add (:file "file") as an option for
10392 the STDOUT buffer.
10393 (Fcall_process_region): Ditto.
10394
330d880c
EZ
103952011-04-30 Eli Zaretskii <eliz@gnu.org>
10396
8db90b73
EZ
10397 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10398 rather than `XVECTOR (FOO)->size'.
10399
330d880c
EZ
10400 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10401 inttypes.h, as a gnulib replacement is used if it not available in
10402 system headers.
10403
15cbd324
EZ
104042011-04-21 Eli Zaretskii <eliz@gnu.org>
10405
10406 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10407 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10408 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10409
10410 * coding.c (coding_alloc_by_realloc): Error out if destination
10411 will grow beyond MOST_POSITIVE_FIXNUM.
10412 (decode_coding_emacs_mule): Abort if there isn't enough place in
10413 charbuf for the composition carryover bytes. Reserve an extra
10414 space for up to 2 characters produced in a loop.
10415 (decode_coding_iso_2022): Abort if there isn't enough place in
10416 charbuf for the composition carryover bytes.
10417
104182011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10419
ae940cca
EZ
10420 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10421 aborting when %lld or %lll format is passed.
10422 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10423 %llo or %llx format is passed. (Bug#8545)
10424
03ab8921
EZ
10425 * window.c (window_scroll_line_based): Use a marker instead of
10426 simple variables to record original value of point. (Bug#7952)
10427
afda1437
EZ
10428 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10429 produced by %s or %c overflows available buffer space. (Bug#8545)
10430
f76dee0c
PE
104312011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10432
10433 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10434 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10435
fdc5744d
JB
104362011-04-28 Juanma Barranquero <lekktu@gmail.com>
10437
10438 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10439
638f053a
JB
104402011-04-28 Juanma Barranquero <lekktu@gmail.com>
10441
10442 * keyboard.c (Qdelayed_warnings_hook): Define.
10443 (command_loop_1): Run `delayed-warnings-hook'
10444 if Vdelayed_warnings_list is non-nil.
10445 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10446 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10447
d178f871
EZ
104482011-04-28 Eli Zaretskii <eliz@gnu.org>
10449
10450 * doprnt.c (doprnt): Don't return value smaller than the buffer
10451 size if the message was truncated. (Bug#8545).
10452
b124fd93
JB
104532011-04-28 Juanma Barranquero <lekktu@gmail.com>
10454
10455 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10456 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10457
e810457d
PE
104582011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10459
10460 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10461
ea51cceb
JB
104622011-04-27 Juanma Barranquero <lekktu@gmail.com>
10463
10464 * makefile.w32-in: Update dependencies.
10465
94dcfacf
EZ
104662011-04-27 Eli Zaretskii <eliz@gnu.org>
10467
10468 Improve `doprnt' and its usage. (Bug#8545)
10469 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10470 `format_end'. Remove support for %l as a conversion specifier.
10471 Don't use xrealloc. Improve diagnostics when the %l size modifier
10472 is used. Update the commentary.
10473
10474 * eval.c (verror): Simplify calculation of size_t.
10475
10476 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10477 messages.
10478
f61f41d7
PE
104792011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10480
10481 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10482 change.
10483
96fb4434
PE
104842011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10485
10486 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10487 This makes this file independent of the recent pseudovector change.
10488
671875da 104892011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10490
69e9b5a3
PE
10491 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10492
b5f869a7 10493 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10494 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10495 Remove unused local.
c8926152 10496 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10497
841a1577 10498 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10499 GCC 4.6.0 optimizes based on type-based alias analysis.
10500 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10501 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10502 != &v->size, and therefore "v->size = 1; b->size = 2; return
10503 v->size;" must therefore return 1. This assumption is incorrect
10504 for Emacs, since it type-puns struct Lisp_Vector * with many other
10505 types. To fix this problem, this patch adds a new type struct
f904488f 10506 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10507 and pseudovectors, and helps optimizing compilers not get fooled
10508 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10509 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10510 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10511 the size member.
eab3844f
PE
10512 (XSETPVECTYPE): Rewrite in terms of new macro.
10513 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10514 This is a bit clearer, and further avoids the possibility of
10515 undesirable aliasing.
10516 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10517 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10518 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10519 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10520 (ASIZE): Now uses header.size rather than size.
10521 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10522 to avoid the hassle of writing XVECTOR (foo)->header.size.
10523 (struct vectorlike_header): New type.
eab3844f
PE
10524 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10525 object, to help avoid aliasing.
10526 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10527 (SUBRP): Likewise, since Lisp_Subr is a special case.
10528 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10529 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10530 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10531 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10532 changed to be "header.size" and "header.next".
10533 * buffer.h (struct buffer): Likewise.
10534 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10535 * frame.h (struct frame): Likewise.
10536 * process.h (struct Lisp_Process): Likewise.
10537 * termhooks.h (struct terminal): Likewise.
10538 * window.c (struct save_window_data, struct saved_window): Likewise.
10539 * window.h (struct window): Likewise.
10540 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10541 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10542 * buffer.c (init_buffer_once): Likewise.
10543 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10544 special case.
10545 * process.c (Fformat_network_address): Use local var for size,
10546 for brevity.
10547
0df1eac5
PE
10548 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10549
847ab9d1 10550 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10551 * data.c (atof): Remove decl; no longer used or needed.
10552 (digit_to_number): Move to lread.c.
10553 (Fstring_to_number): Use new string_to_number function, to be
10554 consistent with how the Lisp reader treats infinities and NaNs.
10555 Do not assume that floating-point numbers represent EMACS_INT
10556 without losing information; this is not true on most 64-bit hosts.
10557 Avoid double-rounding errors, by insisting on integers when
10558 parsing non-base-10 numbers, as the documentation specifies.
10559 * lisp.h (string_to_number): New decl, replacing ...
10560 (isfloat_string): Remove.
bc0a5c13 10561 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10562 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10563 appears to have been a coding error. Similarly, do not accept
10564 strings like +-1e0 as floating point numbers. Do not report
10565 overflow for integer overflows unless the base is not 10 which
10566 means we have no simple and reliable way to continue.
10567 Break out the floating-point parsing into a new
10568 function string_to_number, so that Fstring_to_number parses
10569 floating point numbers consistently with the Lisp reader.
04f2d78b 10570 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10571 (E_CHAR, EXP_INT): Remove, replacing with ...
10572 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10573 (string_to_number): New function, replacing isfloat_string.
10574 This function checks for valid syntax and produces the resulting
10575 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10576 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10577 so that overflow for non-base-10 numbers is reported only when
10578 there's no portable and simple way to convert to floating point.
452f4150 10579
67769ffc
PE
10580 * textprop.c (set_text_properties_1): Rewrite for clarity,
10581 and to avoid GCC warning about integer overflow.
10582
c20db43f
PE
10583 * intervals.h (struct interval): Use EMACS_INT for members
10584 where EMACS_UINT might cause problems. See
10585 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10586 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10587 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10588 All uses changed.
37aa2f85
PE
10589 (offset_intervals): Tell GCC not to worry about length overflow
10590 when negating a negative length.
c20db43f 10591
2538aa2f
PE
10592 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10593 (overrun_check_free): Likewise.
10594
f2d3008d
PE
10595 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10596 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10597 word size.
10598
ec8df744
PE
10599 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10600 (gnutls_make_error): Rename local to avoid shadowing.
10601 (gnutls_emacs_global_deinit): ifdef out; not used.
10602 (Fgnutls_boot): Use const for pointer to readonly storage.
10603 Comment out unused local. Fix pointer signedness problems.
10604
640ee02d
PE
10605 * lread.c (openp): Don't stuff size_t into an 'int'.
10606 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10607 about possible signed overflow.
10608
6048fb2a
PE
10609 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10610 (GDK_KEY_g): Don't define if already defined.
10611 (xg_prepare_tooltip): Avoid pointer signedness problem.
10612 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10613
fa3c87e1
PE
10614 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10615 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10616
2172544b
PE
10617 * xfns.c (Fx_window_property): Simplify a bit,
10618 to make a bit faster and to avoid GCC 4.6.0 warning.
10619 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10620
9b821a21
PE
10621 * fns.c (internal_equal): Don't assume size_t fits in int.
10622
3c616cfa
PE
10623 * alloc.c (compact_small_strings): Tighten assertion a little.
10624
c2982e87
PE
10625 Replace pEd with more-general pI, and fix some printf arg casts.
10626 * lisp.h (pI): New macro, generalizing old pEd macro to other
10627 conversion specifiers. For example, use "...%"pI"d..." rather
10628 than "...%"pEd"...".
10629 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10630 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10631 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10632 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10633 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10634 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10635 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10636 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10637 64-bit hosts.
10638 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10639 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10640 * print.c (safe_debug_print, print_object): Likewise.
10641 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10642 to int.
6f04d126
PE
10643 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10644 avoiding the 0 flag, which is not portable.
c2982e87
PE
10645 * process.c (Fmake_network_process): Use pI to avoid cast.
10646 * region-cache.c (pp_cache): Likewise.
10647 * xdisp.c (decode_mode_spec): Likewise.
10648 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10649 behavior on 64-bit hosts with printf arg.
6f04d126 10650 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10651 (x_stop_queuing_selection_requests): Likewise.
10652 (x_get_window_property): Don't truncate byte count to an 'int'
10653 when tracing.
0b432f21 10654
5e073ec7
PE
10655 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10656 here, since it parses constructs like leading '-' and spaces,
10657 which are not wanted; and it overflows with large numbers.
10658 Instead, simply match F[0-9]+, which is what is wanted anyway.
10659
36372bf9
PE
10660 * alloc.c: Remove unportable assumptions about struct layout.
10661 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10662 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10663 (allocate_vectorlike, make_pure_vector): Use the new macros,
10664 plus offsetof, to remove unportable assumptions about struct layout.
10665 These assumptions hold on all porting targets that I know of, but
10666 they are not guaranteed, they're easy to remove, and removing them
10667 makes further changes easier.
10668
0b432f21
PE
10669 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10670 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10671 (string_overrun_cookie): Now const. Use initializers that
10672 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10673 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10674 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10675 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10676 multiple of sizeof (EMACS_INT); it need not be, if
10677 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10678 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10679
895009e1
JB
106802011-04-26 Juanma Barranquero <lekktu@gmail.com>
10681
10682 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10683
6a7a1b0b
TZ
106842011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10685
10686 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10687 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10688 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10689
841a1577 106902011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10691
10692 * lisp.h (Qdebug): List symbol.
895009e1 10693 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10694 * keyboard.c (debug-on-event): New variable.
10695 (handle_user_signal): Break into debugger when debug-on-event
10696 matches the current signal symbol.
10697
f2d3ba6f
DN
106982011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10699
10700 * alloc.c (check_sblock, check_string_bytes)
10701 (check_string_free_list): Convert to standard C.
10702
42ce4c63
TZ
107032011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10704
10705 * w32.c (emacs_gnutls_push): Fix typo.
10706
825cd63c
EZ
107072011-04-25 Eli Zaretskii <eliz@gnu.org>
10708
fb11d64d
EZ
10709 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10710 "cast to pointer from integer of different size".
10711
825cd63c
EZ
10712 Improve doprnt and its use in verror. (Bug#8545)
10713 * doprnt.c (doprnt): Document the set of format control sequences
10714 supported by the function. Use SAFE_ALLOCA instead of always
10715 using `alloca'.
10716
10717 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10718 is one byte too soon. Don't use xrealloc; instead xfree and
10719 xmalloc anew.
10720
e061a11b
TZ
107212011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10722
10723 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10724 callbacks stage.
10725
10726 * gnutls.c: Renamed global_initialized to
10727 gnutls_global_initialized. Added internals for the
10728 :verify-hostname-error, :verify-error, and :verify-flags
10729 parameters of `gnutls-boot' and documented those parameters in the
10730 docstring. Start callback support.
9173deec
JB
10731 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10732 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10733 on error. Return error code.
e061a11b
TZ
10734 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10735 (emacs_gnutls_read): Likewise.
10736 (Fgnutls_boot): Return handshake error code.
10737 (emacs_gnutls_handle_error): New function.
10738 (wsaerror_to_errno): Likewise.
10739
10740 * w32.h (emacs_gnutls_pull): Add prototype.
10741 (emacs_gnutls_push): Likewise.
10742
10743 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10744 (emacs_gnutls_push): Likewise.
10745
107462011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10747
10748 * process.c (wait_reading_process_output): Check if GnuTLS
10749 buffered some data internally if no FDs are set for TLS
10750 connections.
10751
10752 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10753 (LIBS): Link to USER_LIBS.
10754 ($(BLD)/gnutls.$(0)): New target.
10755
fa6996bc
EZ
107562011-04-24 Eli Zaretskii <eliz@gnu.org>
10757
eb35682e
EZ
10758 * xdisp.c (handle_single_display_spec): Rename the
10759 display_replaced_before_p argument into display_replaced_p, to
10760 make it consistent with the commentary. Fix typos in the
10761 commentary.
10762
e2ad650c
EZ
10763 * textprop.c (syms_of_textprop): Remove dead code.
10764 (copy_text_properties): Delete obsolete commentary about an
10765 interface that was deleted long ago. Fix typos in the description
10766 of arguments.
10767
1b2de274
EZ
10768 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10769 to changes in oldXMenu/XMenu.h from 2011-04-16.
10770 <menu_help_message, prev_menu_help_message>: Constify.
10771 (IT_menu_make_room): menu->help_text is now `const char **';
10772 adjust.
10773
10774 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10775 to changes in oldXMenu/XMenu.h from 2011-04-16.
10776 (struct XMenu): Declare `help_text' `const char **'.
10777
10778 * xfaces.c <Qunspecified>: Make extern again.
10779
10780 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10781 required by POSIX.
1b2de274 10782
762b15be
EZ
10783 * doc.c (get_doc_string): Improve the format passed to `error'.
10784
10785 * doprnt.c (doprnt): Improve commentary.
10786
10787 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10788
10789 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10790 them with etags.
10791
f1052e5d
EZ
10792 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10793 changes in globals.h immediately force recompilation.
762b15be
EZ
10794 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10795 $(CURDIR)/s/ms-w32.h.
10796 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10797
fa6996bc
EZ
10798 * character.c (Fchar_direction): Function deleted.
10799 (syms_of_character): Don't defsubr it.
10800 <char-direction-table>: Deleted.
10801
e6c3da20
EZ
108022011-04-23 Eli Zaretskii <eliz@gnu.org>
10803
10804 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10805 * doprnt.c: Include limits.h.
10806 (SIZE_MAX): New macro.
04f2d78b
CB
10807 (doprnt): Return a size_t value. 2nd arg is now size_t.
10808 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10809 Improve overflow protection. Support `l' modifier for integer
10810 conversions. Support %l conversion. Don't assume an EMACS_INT
10811 argument for integer conversions and for %c.
10812
10813 * lisp.h (doprnt): Restore prototype.
10814
10815 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10816 $(SRC)/character.h.
10817
10818 * Makefile.in (base_obj): Add back doprnt.o.
10819
10820 * deps.mk (doprnt.o): Add back prerequisites.
10821 (callint.o): Depend on character.h.
10822
10823 * eval.c (internal_lisp_condition_case): Include the handler
10824 representation in the error message.
10825 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10826 when breaking from the loop.
10827
10828 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10829
10830 * callint.c (Fcall_interactively): When displaying error message
10831 about invalid control letter, pass the character's codepoint, not
10832 a pointer to its multibyte form. Improve display of the character
10833 in octal and display also its hex code.
10834
10835 * character.c (char_string): Use %x to display the (unsigned)
10836 codepoint of an invalid character, to avoid displaying a bogus
10837 negative value.
10838
10839 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10840 `error', not SYMBOL_NAME itself.
10841
10842 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10843 character arguments to `error'.
10844
10845 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10846 to `error' in error message about FINAL_CHAR argument. Make sure
10847 FINAL_CHAR is a character, and use %c when it is passed as
10848 argument to `error'.
10849
4ffd0d6b 108502011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10851
10852 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10853
10854 * w32.c: Include <time.h>.
10855 (sys_localtime): New function.
10856
4ffd0d6b 108572011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10858
10859 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10860
4ffd0d6b 10861 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10862
4ffd0d6b 108632011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10864
4ffd0d6b
GM
10865 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10866 zombies (Bug#8467).
aac0c6e3 10867
04c56954
EZ
108682011-04-19 Eli Zaretskii <eliz@gnu.org>
10869
10870 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10871 gl_state.e_property when gl_state.object is Qt.
10872
10873 * insdel.c (make_gap_larger): Remove limitation of buffer size
10874 to <= INT_MAX.
10875
16a43933
CY
108762011-04-18 Chong Yidong <cyd@stupidchicken.com>
10877
10878 * xdisp.c (lookup_glyphless_char_display)
10879 (produce_glyphless_glyph): Handle cons cell entry in
10880 glyphless-char-display.
10881 (Vglyphless_char_display): Document it.
10882
10883 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10884 glyphless-char-display.
10885
4581706e
CY
108862011-04-17 Chong Yidong <cyd@stupidchicken.com>
10887
10888 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10889
10890 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10891
10892 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10893 definition for no-X builds.
10894
4887c6e2 108952011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10896
fd35b6f9
PE
10897 Static checks with GCC 4.6.0 and non-default toolkits.
10898
5c1ccb01
PE
10899 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10900
006c5daa
PE
10901 * process.c (keyboard_bit_set): Define only if SIGIO.
10902 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10903 (send_process): Repair possible setjmp clobbering.
10904
efc736d3
PE
10905 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10906
4e2fe2e6
PE
10907 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10908
f97334a2
PE
10909 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10910
4e75f29d
PE
10911 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10912 Define only if needed.
10913
90efadd1
PE
10914 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10915 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10916 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10917
3c647824
PE
10918 * dispextern.h (struct redisplay_interface): Rename param
10919 to avoid shadowing.
e264f262 10920 * termhooks.h (struct terminal): Likewise.
761383f4 10921 * xterm.c (xembed_send_message): Likewise.
3c647824 10922
b58c5c4a
PE
10923 * insdel.c (make_gap_smaller): Define only if
10924 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10925
cad59032
PE
10926 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10927 it.
10928
c339dc2e
PE
10929 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10930 so that we aren't warned about unused symbols.
10931
91a3e27b
PE
10932 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10933
399c71d3 10934 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10935
8ffc96f5
PE
10936 * xfns.c (x_real_positions): Mark locals as initialized.
10937
eef9bc79
PE
10938 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10939
098db9dd
PE
10940 * xterm.c: Fix problems found by static analysis with other toolkits.
10941 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10942 (x_dispatch_event): Declare static if USE_GTK, and
10943 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10944 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10945 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10946 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10947 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10948
eb18f6cc
PE
10949 * xmenu.c (menu_help_callback): Pointer type fixes.
10950 Use const pointers when pointing at readonly data. Avoid pointer
10951 signedness clashes.
10952 (FALSE): Remove unused macro.
10953 (update_frame_menubar): Remove unused decl.
10954
1fe72bf8
PE
10955 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10956
60d9e1db
PE
10957 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10958 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10959 (single_menu_item): Rename local to avoid shadowing.
10960
39261c26
PE
10961 * keyboard.c (make_lispy_event): Remove unused local var.
10962
018c5e19
PE
10963 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10964 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10965
63d2b86e
PE
10966 * bitmaps: Change bitmaps from unsigned char back to the X11
10967 compatible char. Avoid the old compiler warnings about
10968 out-of-range initializers by using, for example, '\xab' rather
10969 than 0xab.
10970
aefd87e1
PE
10971 * xgselect.c (xgselect_initialize): Check vs interface
10972 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10973
bf501fb9
PE
10974 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10975
e9829fdf
PE
10976 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10977 to read-only memory.
10978
1086c095
PE
10979 * fns.c (vector): Remove; this old hack is no longer needed.
10980
2baccd04 10981 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10982 Remove unused var.
dde42981 10983 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10984
72391843 10985 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10986
436c16df 10987 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10988 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10989 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10990
92bb796d 10991 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10992 (x_term_init): Remove local to avoid shadowing.
92bb796d 10993
764430a3 10994 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10995
10996 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10997 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10998
d1dfb56c
EZ
109992011-04-16 Eli Zaretskii <eliz@gnu.org>
11000
c4354cb4
EZ
11001 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11002
d1dfb56c
EZ
11003 Fix regex.c, syntax.c and friends for buffers > 2GB.
11004 * syntax.h (struct gl_state_s): Declare character position members
11005 EMACS_INT.
11006
11007 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11008
04f2d78b
CB
11009 * textprop.c (verify_interval_modification, interval_of):
11010 Declare arguments EMACS_INT.
d1dfb56c
EZ
11011
11012 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11013 EMACS_INT.
11014
11015 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11016
11017 * indent.c (Fvertical_motion): Local variable it_start is now
11018 EMACS_INT.
11019
11020 * regex.c (re_match, re_match_2, re_match_2_internal)
11021 (bcmp_translate, regcomp, regexec, print_double_string)
11022 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11023 (re_compile_pattern, re_exec): Declare arguments and local
11024 variables `size_t' and `ssize_t' and return values `regoff_t', as
11025 appropriate.
11026 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11027 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11028 <compile_stack_type>: `size' and `avail' are now `size_t'.
11029
11030 * regex.h <regoff_t>: Use ssize_t, not int.
11031 (re_search, re_search_2, re_match, re_match_2): Arguments that
11032 specify buffer/string position and length are now ssize_t and
11033 size_t. Return type is regoff_t.
11034
613052cd
BK
110352011-04-16 Ben Key <bkey76@gmail.com>
11036
11037 * nsfont.m: Fixed bugs in ns_get_family and
11038 ns_descriptor_to_entity that were caused by using free to
11039 deallocate memory blocks that were allocated by xmalloc (via
11040 xstrdup). This caused Emacs to crash when compiled with
11041 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11042 --enable-checking=xmallocoverrun). xfree is now used to
11043 deallocate these memory blocks.
11044
4170f62f 110452011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11046
71b41406
PE
11047 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11048
9587a89d
PE
11049 emacs_write: Accept and return EMACS_INT for sizes.
11050 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11051 et seq.
11052 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11053 Accept and return EMACS_INT.
11054 (emacs_gnutls_write): Return the number of bytes written on
11055 partial writes.
11056 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11057 (emacs_read, emacs_write): Remove check for negative size, as the
11058 Emacs source code has been audited now.
9587a89d
PE
11059 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11060 (emacs_read, emacs_write): Use it.
273a5f82
PE
11061 * process.c (send_process): Adjust to the new signatures of
11062 emacs_write and emacs_gnutls_write. Do not attempt to store
11063 a byte offset into an 'int'; it might overflow.
9587a89d 11064 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11065
3e047f51
PE
11066 * sound.c: Don't assume sizes fit in 'int'.
11067 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11068 Return EMACS_INT, not int.
3e047f51 11069 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11070 Accept EMACS_INT, not int.
11071 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11072 record read return values.
11073
cc39a9db
BK
110742011-04-15 Ben Key <bkey76@gmail.com>
11075
c9d0ec6d
JB
11076 * keyboard.c (Qundefined): Don't declare static since it is used
11077 in nsfns.m.
11078 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11079 static since they are used in nsfont.m.
cc39a9db 11080
6c60eb9f
SM
110812011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11082
11083 * process.c (Qprocessp): Don't declare static.
11084 * lisp.h (Qprocessp): Declare again.
11085
7990b61a
JB
110862011-04-15 Juanma Barranquero <lekktu@gmail.com>
11087
11088 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11089
5d4cb038
PE
110902011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11091
8bd7b830 11092 Improve C-level modularity by making more things 'static'.
cd64ea1d 11093
e3b27b31
PE
11094 Don't publish debugger-only interfaces to other modules.
11095 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11096 (verify_bytepos, count_markers): Move decls to the only modules
11097 that need them.
11098 * region-cache.h (pp_cache): Likewise.
11099 * window.h (check_all_windows): Likewise.
11100 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11101
5d4cb038
PE
11102 * sysdep.c (croak): Now static, if
11103 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11104 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11105
11106 * alloc.c (refill_memory_reserve): Now static if
11107 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11108 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11109
e87b6180
PE
11110 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11111 Define only if USE_LUCID.
11112
ac64929e
PE
11113 * xrdb.c (x_customization_string, x_rm_string): Now static.
11114
6f37259d
PE
11115 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11116 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11117
1683e3ab
PE
11118 * xdisp.c (draw_row_with_mouse_face): Now static.
11119 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11120
de9c2632
PE
11121 * window.h (check_all_windows): Mark externally visible.
11122
2b96acb7
PE
11123 * window.c (window_deletion_count): Now static.
11124
11125 * undo.c: Make symbols static if they're not exported.
11126 (last_undo_buffer, last_boundary_position, pending_boundary):
11127 Now static.
11128
50436f33
PE
11129 * textprop.c (interval_insert_behind_hooks): Now static.
11130 (interval_insert_in_front_hooks): Likewise.
11131
64520e5c
PE
11132 * term.c: Make symbols static if they're not exported.
11133 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11134 (max_frame_lines, tty_set_terminal_modes):
11135 (tty_reset_terminal_modes, tty_turn_off_highlight):
11136 (get_tty_terminal): Now static.
11137 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11138 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11139 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11140 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11141 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11142
1fa53021
PE
11143 * sysdep.c: Make symbols static if they're not exported.
11144 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11145 Now static.
11146 (sigprocmask_set, full_mask): Remove; unused.
11147 (wait_debugging): Mark as visible.
11148 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11149 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11150
d4b43b22
PE
11151 * syntax.c (syntax_temp): Define only if !__GNUC__.
11152
b7c513d0
PE
11153 * sound.c (current_sound_device, current_sound): Now static.
11154
989b29ad
PE
11155 * search.c (searchbufs, searchbuf_head): Now static.
11156
13a55a78
PE
11157 * scroll.c (scroll_cost): Remove; unused.
11158 * dispextern.h (scroll_cost): Remove decl.
11159
de68a1fc
PE
11160 * region-cache.h (pp_cache): Mark as externally visible.
11161
40ccffa6
PE
11162 * process.c: Make symbols static if they're not exported.
11163 (process_tick, update_tick, create_process, chan_process):
11164 (Vprocess_alist, proc_buffered_char, datagram_access):
11165 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11166 (deactivate_process): Mark defn as static, as well as decl.
11167 * lisp.h (create_process): Remove decl.
11168 * process.h (chan_process, Vprocess_alist): Remove decls.
11169
ad64fc97
PE
11170 * print.c: Make symbols static if they're not exported.
11171 (print_depth, new_backquote_output, being_printed, print_buffer):
11172 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11173 (print_interval, print_number_index, initial_stderr_stream):
11174 Now static.
11175 * lisp.h (Fprinc): Remove decl.
11176 (debug_output_compilation_hack): Mark as externally visible.
11177
adddb265
PE
11178 * sysdep.c (croak): Move decl from here to syssignal.h.
11179 * syssignal.h (croak): Put it here, so the API can be checked when
11180 'croak' is called from dissociate_if_controlling_tty.
11181
1717ede2
PE
11182 * minibuf.c: Make symbols static if they're not exported.
11183 (minibuf_save_list, choose_minibuf_frame): Now static.
11184 * lisp.h (choose_minibuf_frame): Remove decl.
11185
fa5fb2bc
PE
11186 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11187
1e3890d1
PE
11188 * lread.c: Make symbols static if they're not exported.
11189 (read_objects, initial_obarray, oblookup_last_bucket_number):
11190 Now static.
11191 (make_symbol): Remove; unused.
11192 * lisp.h (initial_obarray, make_symbol): Remove decls.
11193
8a1414fa
PE
11194 * keyboard.c: Make symbols static if they're not exported.
11195 (single_kboard, recent_keys_index, total_keys, recent_keys):
11196 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11197 (this_single_command_key_start, echoing, last_auto_save):
11198 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11199 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11200 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11201 (Vlispy_mouse_stem, double_click_count):
11202 Now static.
11203 (force_auto_save_soon): Define only if SIGDANGER.
11204 (ignore_mouse_drag_p): Now static if
11205 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11206 (print_help): Remove; unused.
11207 (stop_character, last_timer_event): Mark as externally visible.
11208 * keyboard.h (ignore_mouse_drag_p): Declare only if
11209 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11210 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11211 * lisp.h (echoing): Remove decl.
11212 (force_auto_save_soon): Declare only if SIGDANGER.
11213 * xdisp.c (redisplay_window): Simplify code, to make it more
11214 obvious that ignore_mouse_drag_p is not accessed if !defined
11215 USE_GTK && !defined HAVE_NS.
11216
93ea6e8f
PE
11217 * intervals.c: Make symbols static if they're not exported.
11218 (merge_properties_sticky, merge_interval_right, delete_interval):
11219 Now static.
11220 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11221
77382fcc
PE
11222 * insdel.c: Make symbols static if they're not exported.
11223 However, leave prepare_to_modify_buffer alone. It's never
11224 called from outside this function, but that appears to be a bug.
11225 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11226 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11227 (adjust_after_replace_noundo): Remove; unused.
11228 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11229 (signal_before_change): Remove decls.
77382fcc 11230
9306c32e
PE
11231 * indent.c (val_compute_motion, val_vmotion): Now static.
11232
cd44d2eb
PE
11233 * image.c: Make symbols static if they're not exported.
11234 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11235 if USE_GTK.
11236 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11237 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11238
ad9a7a06
PE
11239 * fringe.c (standard_bitmaps): Now static.
11240 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11241
81626931
PE
11242 * frame.c: Make symbols static if they're not exported.
11243 (x_report_frame_params, make_terminal_frame): Now static.
11244 (get_frame_param): Now static, unless HAVE_NS.
11245 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11246 (x_get_resource_string): Remove; not used.
11247 * frame.h (make_terminal_frame, x_report_frame_params):
11248 (x_get_resource_string); Remove decls.
11249 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11250 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11251
239f9db9
PE
11252 * font.c, fontset.c: Make symbols static if they're not exported.
11253 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11254 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11255 * font.c (font_close_object): Now static.
11256 * font.h (font_close_object): Remove.
11257 * fontset.c (FONTSET_OBJLIST): Remove.
11258 (free_realized_fontset) #if-0 the body, which does nothing.
11259 (face_suitable_for_char_p): #if-0, as it's never called.
11260 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11261 * xfaces.c (face_at_string_position):
11262 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11263 since 0 is always ASCII.
11264
dfcf3579
PE
11265 * fns.c (weak_hash_tables): Now static.
11266
5045092b
PE
11267 * fileio.c: Make symbols static if they're not exported.
11268 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11269 (Vwrite_region_annotation_buffers): Now static.
11270
57a96f5c
PE
11271 * eval.c: Make symbols static if they're not exported.
11272 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11273 * lisp.h (backtrace_list): Remove decl.
11274
35f08c38
PE
11275 * emacs.c: Make symbols static if they're not exported.
11276 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11277 (fatal_error_code, fatal_error_signal_hook, standard_args):
11278 Now static.
11279 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11280 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11281 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11282 * lisp.h (fatal_error_signal_hook): Remove decl.
11283 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11284
f44bd759
PE
11285 * editfns.c: Move a (normally-unused) function to its only use.
11286 * editfns.c, lisp.h (get_operating_system_release): Remove.
11287 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11288 worth the hassle of breaking this out.
11289
b532497d
PE
11290 * xterm.c: Make symbols static if they're not exported.
11291 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11292 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11293 (x_destroy_window, x_delete_display):
11294 Now static.
11295 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11296 (x_mouse_leave): Remove; unused.
11297 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11298 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11299 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11300 Remove decls.
11301 (x_mouse_leave): Declare only if WINDOWSNT.
11302 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11303 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11304 USE_X_TOOLKIT.
11305
1675728f
PE
11306 * ftxfont.c: Make symbols static if they're not exported.
11307 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11308 HAVE_FREETYPE.
11309 * font.h (ftxfont_driver): Likewise.
11310
e4cebfca
PE
11311 * xfns.c: Make symbols static if they're not exported.
11312 (x_last_font_name, x_display_info_for_name):
11313 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11314 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11315 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11316 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11317 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11318 (last_show_tip_args): Now static.
11319 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11320 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11321 (x_screen_planes): Remove; unused.
11322 * dispextern.h (x_screen_planes): Remove decl.
11323
5bf46f05
PE
11324 * dispnew.c: Make symbols static if they're not exported.
11325 * dispextern.h (redraw_garbaged_frames, scrolling):
11326 (increment_row_positions): Remove.
11327 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11328 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11329 Now static.
11330 (redraw_garbaged_frames): Remove; unused.
11331
435f4c28
PE
11332 * xfaces.c: Make symbols static if they're not exported.
11333 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11334 Remove decls.
11335 * xterm.h (defined_color): Remove decls.
11336 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11337 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11338 (menu_face_changed_default, defined_color, free_realized_face):
11339 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11340 (ascii_face_of_lisp_face): Remove; unused.
11341
8524aef3
PE
11342 * xdisp.c: Make symbols static if they're not exported.
11343 * dispextern.h (scratch_glyph_row, window_box_edges):
11344 (glyph_to_pixel_coords, set_cursor_from_row):
11345 (get_next_display_element, set_iterator_to_next):
11346 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11347 (show_mouse_face): Remove decls
11348 * frame.h (message_buf_print): Likewise.
11349 * lisp.h (pop_message, set_message, check_point_in_composition):
11350 Likewise.
11351 * xterm.h (set_vertical_scroll_bar): Likewise.
11352 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11353 (message_buf_print, scratch_glyph_row, displayed_buffer):
11354 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11355 (get_next_display_element, show_mouse_face, window_box_edges):
11356 (frame_to_window_pixel_xy, check_point_in_composition):
11357 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11358 (glyph_to_pixel_coords): Remove; unused.
11359
16390cd2
PE
11360 * dired.c (file_name_completion): Now static.
11361
11362 * dbusbind.c (xd_in_read_queued_messages): Now static.
11363
a25f4dfa
PE
11364 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11365 * data.c (circular_list_error): Remove.
11366
14a9c8df
PE
11367 * commands.h (last_point_position, last_point_position_buffer):
11368 (last_point_position_window): Remove decls.
11369 * keyboard.c: Make these variables static.
11370
04f2d78b
CB
11371 * coding.h (coding, code_convert_region, encode_coding_gap):
11372 Remove decls.
74ab6df5
PE
11373 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11374 (iso_code_class, detect_coding, code_convert_region): Now static.
11375 (encode_coding_gap): Remove; unused.
11376
38dfbee1
PE
11377 * chartab.c (chartab_chars, chartab_bits): Now static.
11378
a2cb4e63
PE
11379 * charset.h (charset_iso_8859_1): Remove decl.
11380 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11381 Now static.
11382
127198fd
PE
11383 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11384 * ccl.c (Vccl_program_table): Now static.
11385 (check_ccl_update): Remove; unused.
11386
d85b608f
PE
11387 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11388 * category.h: ... from here.
11389 * category.c (check_category_table, set_category_set): Now static.
11390
31cd66f3
PE
11391 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11392 * lisp.h: Remove these decls.
11393
c358e587
PE
11394 * buffer.c (buffer_count): Remove unused var.
11395
e78aecca
PE
11396 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11397 so that it's not optimized away.
11398 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11399 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11400 exported only to the debugger.
11401
e192d7d3 11402 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11403 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11404
92470028
PE
11405 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11406 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11407 was inaccessible from Lisp.
11408 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11409 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11410
244ed907
PE
11411 alloc.c: Import and export fewer symbols, and remove unused items.
11412 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11413 is defined.
11414 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11415 it's not optimized away by whole-program optimization.
11416 (message_enable_multibyte, free_misc): Remove.
11417 (catchlist, handlerlist, mark_backtrace):
11418 Declare only if BYTE_MARK_STACK.
11419 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11420 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11421 (message_enable_multibyte): Remove decl.
11422 (free_misc, interval_free_list, float_block, float_block_index):
11423 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11424 (cons_free_list, last_marked_index):
11425 Now static.
11426 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11427 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11428 (mark_backtrace): Define only if BYTE_MARK_STACK.
11429 * xdisp.c (message_enable_multibyte): Now static.
11430
61c2b50e 11431 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11432 This makes it easier for human readers (and static analyzers)
11433 to see whether these variables are used from other modules.
11434 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11435 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11436 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11437 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11438 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11439 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11440 * xmenu.c, xselect.c:
11441 Declare Q* vars static if they are not used in other modules.
11442 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11443 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11444 Remove decls of unexported vars.
11445 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11446
95c82688
PE
11447 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11448
16a97296
PE
11449 Make Emacs functions such as Fatom 'static' by default.
11450 This makes it easier for human readers (and static analyzers)
11451 to see whether these functions can be called from other modules.
11452 DEFUN now defines a static function. To make the function external
11453 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11454 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11455 (Finit_image_library):
16a97296
PE
11456 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11457 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11458 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11459 Remove decls, since these functions are now static.
11460 (Funintern, Fget_internal_run_time): New decls, since these functions
11461 were already external.
95c82688 11462
16a97296
PE
11463 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11464 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11465 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11466 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11467 * keyboard.c, keymap.c, lread.c:
11468 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11469 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11470 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11471 Mark functions with DEFUE instead of DEFUN,
11472 if they are used in other modules.
11473 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11474 decls for now-static functions.
11475 * buffer.h (Fdelete_overlay): Remove decl.
11476 * callproc.c (Fgetenv_internal): Mark as internal.
11477 * composite.c (Fremove_list_of_text_properties): Remove decl.
11478 (Fcomposition_get_gstring): New forward static decl.
11479 * composite.h (Fcomposite_get_gstring): Remove decl.
11480 * dired.c (Ffile_attributes): New forward static decl.
11481 * doc.c (Fdocumntation_property): New forward static decl.
11482 * eval.c (Ffetch_bytecode): New forward static decl.
11483 (Funintern): Remove extern decl; now in .h file where it belongs.
11484 * fileio.c (Fmake_symbolic_link): New forward static decl.
11485 * image.c (Finit_image_library): New forward static decl.
11486 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11487 * intervals.h (Fprevious_property_change):
11488 (Fremove_list_of_text_properties): Remove decls.
11489 * keyboard.c (Fthis_command_keys): Remove decl.
11490 (Fcommand_execute): New forward static decl.
11491 * keymap.c (Flookup_key): New forward static decl.
11492 (Fcopy_keymap): Now static.
11493 * keymap.h (Flookup_key): Remove decl.
11494 * process.c (Fget_process): New forward static decl.
11495 (Fprocess_datagram_address): Mark as internal.
11496 * syntax.c (Fsyntax_table_p): New forward static decl.
11497 (skip_chars): Remove duplicate decl.
11498 * textprop.c (Fprevious_property_change): New forward static decl.
11499 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11500 Now internal.
11501 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11502 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11503
785bbd42
PE
11504 * editfns.c (Fformat): Remove unreachable code.
11505
8b913b57
AS
115062011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11507
11508 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11509 change. (Bug#8496)
11510
a6744a35
EZ
115112011-04-13 Eli Zaretskii <eliz@gnu.org>
11512
11513 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11514 when at ZV. (Bug#8487)
11515
e7974947
AS
115162011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11517
baad03f0
AS
11518 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11519 (Bug#8437)
11520 * keyboard.c (parse_tool_bar_item): Likewise.
11521 * sound.c (sound_cleanup, alsa_close): Likewise.
11522 * termcap.c (tgetent): Likewise.
11523 * xfns.c (x_default_font_parameter): Likewise.
11524 * xsettings.c (read_and_apply_settings): Likewise.
11525
e7974947
AS
11526 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11527 (overrun_check_free): Protoize.
11528
28272684
PE
115292011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11530
11531 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11532 since callers should never pass a negative size.
11533 Change the signature to match that of plain 'read' and 'write'; see
11534 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11535 * lisp.h: Update prototypes of emacs_write and emacs_read.
11536
11997c76
EZ
115372011-04-11 Eli Zaretskii <eliz@gnu.org>
11538
11539 * xdisp.c (redisplay_window): Don't try to determine the character
11540 position of the scroll margin if the window start point w->startp
e896f03c 11541 is outside the buffer's accessible region. (Bug#8468)
11997c76 11542
8a2cbd72
EZ
115432011-04-10 Eli Zaretskii <eliz@gnu.org>
11544
11545 Fix write-region and its subroutines for buffers > 2GB.
11546 * fileio.c (a_write, e_write): Modify declaration of arguments and
11547 local variables to support buffers larger than 2GB.
11548 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11549
11550 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11551 argument, local variables, and return value.
11552
11553 * lisp.h: Update prototypes of emacs_write and emacs_read.
11554
11555 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11556
4073e537 115572011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11558
1ebfdcb6
PE
11559 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11560
b2ded58d
PE
11561 Fix more problems found by GCC 4.6.0's static checks.
11562
7d66342c
PE
11563 * xdisp.c (vmessage): Use a better test for character truncation.
11564
bbf47d44
PE
11565 * charset.c (load_charset_map): <, not <=, for optimization,
11566 and to avoid potential problems with integer overflow.
9248994d 11567 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11568 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11569 * editfns.c (Fformat): Likewise.
1e69125e 11570 * syntax.c (skip_chars): Likewise.
3befa583 11571
e3019616
PE
11572 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11573 This also lets GCC 4.6.0 generate slightly better loop code.
11574
becfa255
PE
11575 * callint.c (Fcall_interactively): <, not <=, for optimization.
11576 (Fcall_interactively): Count the number of arguments produced,
11577 not the number of arguments given. This is simpler and lets GCC
11578 4.6.0 generate slightly better code.
11579
dae0cd48
PE
11580 * ftfont.c: Distingish more carefully between FcChar8 and char.
11581 The previous code passed unsigned char * to a functions like
11582 strlen and xstrcasecmp that expect char *, which does not
11583 conform to the C standard.
11584 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11585 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11586 char * when the C standard requires it.
11587
76032d70
PE
11588 * keyboard.c (read_char): Remove unused var.
11589
eb3f1cc8
PE
11590 * eval.c: Port to Windows vsnprintf (Bug#8435).
11591 Include <limits.h>.
11592 (SIZE_MAX): Define if the headers do not.
11593 (verror): Do not give up if vsnprintf returns a negative count.
11594 Instead, grow the buffer. This ports to Windows vsnprintf, which
11595 does not conform to C99. Problem reported by Eli Zaretskii.
11596 Also, simplify the allocation scheme, by avoiding the need for
11597 calling realloc, and removing the ALLOCATED variable.
11598
70476b54
PE
11599 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11600
12020a9e
PE
11601 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11602 But keep the doprint source code for now, as we might revamp it
11603 and use it again (Bug#8435).
ea6c7ae6
PE
11604 * lisp.h (doprnt): Remove.
11605 * Makefile.in (base_obj): Remove doprnt.o.
11606 * deps.mk (doprnt.o): Remove.
11607
5fdb398c
PE
11608 error: Print 32- and 64-bit integers portably (Bug#8435).
11609 Without this change, on typical 64-bit hosts error ("...%d...", N)
11610 was used to print both 32- and 64-bit integers N, which relied on
11611 undefined behavior.
61bdb816 11612 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11613 * lisp.h (error, verror): Mark as printf-like functions.
11614 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11615 Report overflow in size calculations when allocating printf buffer.
11616 Do not truncate output string at its first null byte.
11617 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11618 Truncate the output at a character boundary, since vsnprintf does not
11619 do that.
11620 * charset.c (check_iso_charset_parameter): Convert internal
11621 character to string before calling 'error', since %c now has the
11622 printf meaning.
11623 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11624 overflow when computing char to be passed to 'error'. Do not
11625 pass Lisp_Object to 'error'; pass the integer instead.
11626 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11627 formatted with plain %d.
11628
b189fa66
PE
11629 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11630
bff87ef0
PE
11631 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11632
7e2cac20
PE
11633 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11634
ce4d90b5
PE
11635 * xterm.c (x_catch_errors): Remove duplicate declaration.
11636
266c9547
PE
11637 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11638
79c49ad2
PE
11639 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11640
368f4090
JM
116412011-04-10 Jim Meyering <meyering@redhat.com>
11642
11643 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11644 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11645 return ssize_t not "int", and use size_t as the buffer length.
11646 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11647 * gnutls.h: Update declarations.
11648 * process.c (read_process_output): Use ssize_t, to match.
11649 (send_process): Likewise.
11650
a32d4040
CY
116512011-04-09 Chong Yidong <cyd@stupidchicken.com>
11652
11653 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11654
8546720e 116552011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11656
04f2d78b
CB
11657 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11658 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11659
8546720e
GM
11660 * xterm.c (handle_one_xevent):
11661 * xmenu.c (create_and_show_popup_menu):
11662 * xselect.c (x_decline_selection_request)
11663 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11664
0a2f5c1a 116652011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11666
11667 Fix some uses of `int' instead of EMACS_INT.
11668 * search.c (string_match_1, fast_string_match)
11669 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11670 (scan_buffer, find_next_newline_no_quit)
11671 (find_before_next_newline, search_command, Freplace_match)
11672 (Fmatch_data): Make some `int' variables be EMACS_INT.
11673
11674 * xdisp.c (display_count_lines): 3rd argument and return value now
11675 EMACS_INT. All callers changed.
11676 (pint2hrstr): Last argument is now EMACS_INT.
11677
11678 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11679 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11680 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11681 (decode_coding_utf_16, decode_coding_emacs_mule)
11682 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11683 (decode_coding_ccl, decode_coding_charset)
11684 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11685 (decode_coding_iso_2022, decode_coding_emacs_mule)
11686 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11687 <char_offset, last_offset>: Declare EMACS_INT.
11688 (encode_coding_utf_8, encode_coding_utf_16)
11689 (encode_coding_emacs_mule, encode_invocation_designation)
11690 (encode_designation_at_bol, encode_coding_iso_2022)
11691 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11692 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11693 Declare EMACS_INT.
11694 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11695 (encode_invocation_designation): Last argument P_NCHARS is now
11696 EMACS_INT.
11697 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11698 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11699
11700 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11701 All users changed.
11702
11703 * ccl.c (Fccl_execute_on_string): Declare some variables
11704 EMACS_INT.
11705
8546720e 117062011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11707
11708 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11709
4e19a977
CS
117102011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11711
11712 * process.c (Fformat_network_address): Doc fix.
11713
87302331
R
117142011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11715
ee7683eb 11716 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11717
cbb59342
CY
117182011-04-08 Chong Yidong <cyd@stupidchicken.com>
11719
11720 * keyboard.c (read_char): Call Lisp function help-form-show,
11721 instead of using internal_with_output_to_temp_buffer.
11722 (Qhelp_form_show): New var.
e0d38eeb 11723 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11724
11725 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11726
11727 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11728
e67a13ab
CY
117292011-04-06 Chong Yidong <cyd@stupidchicken.com>
11730
04f2d78b
CB
11731 * process.c (Flist_processes): Remove to Lisp.
11732 (list_processes_1): Delete.
e67a13ab 11733
973f782d
EZ
117342011-04-06 Eli Zaretskii <eliz@gnu.org>
11735
7c106b1e
EZ
11736 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11737
973f782d
EZ
11738 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11739
41cf7d1a 117402011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11741
ca23cc88
PE
11742 Fix more problems found by GCC 4.6.0's static checks.
11743
f390e2d5
PE
11744 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11745
42eea0d0
PE
11746 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11747
b69769da 11748 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11749
f9541e84
PE
11750 * xdisp.c (vmessage): Mark as a printf-like function.
11751
13841b55
PE
11752 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11753
c136c10f
PE
11754 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11755
5e2d4a30
PE
11756 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11757 printf-like functions.
11758 (tiff_load): Add casts to remove these marks before passing them
11759 to system-supplied API.
11760
583f48b9
PE
11761 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11762
b25d760e
PE
11763 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11764 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11765 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11766 directly, rather than having caller test rule sign. This avoids
11767 some unnecessary tests.
11768 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11769 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11770 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11771
bc7b6697 11772 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11773 (xfont_open): Avoid unnecessary tests.
bc7b6697 11774
27ccc379
PE
11775 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11776
dcd5c89a
PE
11777 * composite.h, composite.c (composition_gstring_put_cache):
11778 Use EMACS_INT, not int, for length.
11779
b13a45c6
PE
11780 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11781 breaking out part of COMPOSITION_DECODE_RULE.
11782 (COMPOSITION_DECODE_RULE): Use it.
11783 * composite.c (get_composition_id): Remove unused local vars,
11784 by using the new macro.
11785
1e792e4d
PE
11786 * textprop.c (set_text_properties_1): Change while to do-while,
11787 since the condition is always true at first.
11788
dc6c6455 11789 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11790 (interval_deletion_adjustment): Return unsigned value.
11791 All uses changed.
dc6c6455 11792
aba7731a
PE
11793 * process.c (list_processes_1, create_pty, read_process_output):
11794 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11795 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11796 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11797 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11798 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11799
fdfc4bf3
PE
11800 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11801
fca8fe46 11802 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11803 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11804
06a0259a 11805 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11806 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11807 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11808
e7b9e80f
PE
11809 * print.c (print_error_message): Avoid int overflow.
11810
56201685
PE
11811 * font.c (font_list_entities): Redo for clarity,
11812 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11813
78834453 11814 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11815 (font_score): Avoid potential overflow in diff calculation.
78834453 11816
0bc0b309 11817 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11818 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11819
e610eaca
PE
11820 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11821
b895abce
PE
11822 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11823 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11824 can always succeed if overflow has undefined behavior.
11825
1f1d9321 11826 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11827 (wordify): Omit three unnecessary tests.
1f1d9321 11828
c59478bc
PE
11829 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11830 All callers changed. This avoids the need for an unused var.
11831
79b73827
PE
11832 * casefiddle.c (casify_region): Remove var that is set but not used.
11833
a4db5dfe
PE
11834 * dired.c (file_name_completion): Remove var that is set but not used.
11835
43aae36e
PE
11836 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11837
2a47c44d 11838 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11839 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11840
a37c69bf
PE
11841 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11842 Check for integer overflow on size calculations.
11843
328ab8e7
PE
11844 * buffer.c (Fprevious_overlay_change): Remove var that is set
11845 but not used.
11846
e5a2a5cb
PE
11847 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11848 Remove vars that are set but not used.
8d84a6eb 11849 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11850 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11851
a60e5f68
PE
11852 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11853
f661cb61 11854 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11855 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11856
f0397f5a
PE
11857 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11858 that are set but not used.
11859
8664db06 11860 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11861 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11862
6abdaa4a
PE
11863 * xselect.c (x_get_local_selection, x_handle_property_notify):
11864 Remove vars that are set but not used.
11865
0ce7538d 11866 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11867 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11868
9ae848fc
PE
11869 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11870 Remove var that is set but not used.
0b918413
PE
11871 (scroll_bar_windows_size): Now size_t, not int.
11872 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11873 Check for overflow.
9ae848fc 11874
a5a62657
PE
11875 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11876 (map_tty_color) [!defined MSDOS]: Likewise.
11877
5c5cdd39
PE
11878 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11879
66ebf983
PE
11880 * coding.c: Remove vars that are set but not used.
11881 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11882 All callers changed.
11883 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11884 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11885 (decode_coding_charset): Remove vars that are set but not used.
11886
1be4d761
PE
11887 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11888 that is set but not used.
11889
47553fa8
PE
11890 * print.c (print_object): Remove var that is set but not used.
11891
1f7196bf 11892 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11893 The gnulib version avoids calling malloc in the usual case,
11894 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11895 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11896 * filelock.c (current_lock_owner): Likewise.
11897 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11898 * sysdep.c: Include allocator.h, careadlinkat.h.
11899 (emacs_no_realloc_allocator): New static constant.
11900 (emacs_readlink): New function.
fdb61804
PE
11901 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11902 ../lib/careadlinkat.h.
d1fdcab7 11903
f84c17c7
SM
119042011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11905
11906 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11907 first non-nil return value).
11908
ef3862ad
JD
119092011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11910
11911 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11912 if not defined (Bug#8403).
11913
376a7006
JB
119142011-04-02 Juanma Barranquero <lekktu@gmail.com>
11915
11916 * xdisp.c (display_count_lines): Remove parameter `start',
11917 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11918 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11919 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11920 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11921 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11922 and thereabouts. All callers changed.
11923 (get_per_char_metric): Remove parameter `f', unused since
11924 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11925
6ca3801d
JM
119262011-04-02 Jim Meyering <meyering@redhat.com>
11927
11928 do not dereference NULL upon failed strdup
11929 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11930 (ns_get_family): Likewise.
11931
d8e2b5ba
JB
119322011-04-02 Juanma Barranquero <lekktu@gmail.com>
11933
11934 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11935
8c74fcbd
JD
119362011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11937
11938 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11939 later (Bug#8403).
11940
7200d79c
SM
119412011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11942
03408648 11943 Add lexical binding.
7200d79c 11944
03408648
SM
11945 * window.c (Ftemp_output_buffer_show): New fun.
11946 (Fsave_window_excursion):
11947 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11948
11949 * lread.c (lisp_file_lexically_bound_p): New function.
11950 (Fload): Bind Qlexical_binding.
11951 (readevalloop): Remove `evalfun' arg.
11952 Bind Qinternal_interpreter_environment.
11953 (Feval_buffer): Bind Qlexical_binding.
11954 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11955 Mark as dynamic.
11956 (syms_of_lread): Declare `lexical-binding'.
11957
11958 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11959
11960 * keyboard.c (eval_dyn): New fun.
11961 (menu_item_eval_property): Use it.
ca105506
SM
11962
11963 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11964
03408648
SM
11965 * fns.c (concat, mapcar1): Accept byte-code-functions.
11966
11967 * eval.c (Fsetq): Handle lexical vars.
11968 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11969 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11970 (FletX, Flet): Obey lexical binding.
11971 (Fcommandp): Handle closures.
11972 (Feval): New `lexical' arg.
11973 (eval_sub): New function extracted from Feval. Use it almost
11974 everywhere where Feval was used. Look up vars in lexical env.
11975 Handle closures.
11976 (Ffunctionp): Move from subr.el.
11977 (Ffuncall): Handle closures.
11978 (apply_lambda): Remove `eval_flags'.
11979 (funcall_lambda): Handle closures and new byte-code-functions.
11980 (Fspecial_variable_p): New function.
11981 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11982 but without exporting it to Lisp.
23aba0ea 11983
23aba0ea 11984 * doc.c (Fdocumentation, store_function_docstring):
03408648 11985 * data.c (Finteractive_form): Handle closures.
23aba0ea 11986
03408648
SM
11987 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11988 interactive spec.
ba83908c 11989
04f2d78b
CB
11990 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11991 New byte-codes.
03408648
SM
11992 (exec_byte_code): New function extracted from Fbyte_code to handle new
11993 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11994
03408648 11995 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11996
03408648 11997 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11998
e2abce01
JB
119992011-03-31 Juanma Barranquero <lekktu@gmail.com>
12000
12001 * xdisp.c (redisplay_internal): Fix prototype.
12002
63696a73 120032011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12004
63696a73 12005 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12006 (try_scrolling): Use it when setting scroll_limit.
12007 Limit scrolling to 100 screen lines.
63696a73
EZ
12008 (redisplay_window): Even when falling back on "recentering",
12009 position point in the window according to scroll-conservatively,
12010 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12011
12012 (try_scrolling): When point is above the window, allow searching
12013 as far as scroll_max, or one screenful, to compute vertical
12014 distance from PT to the scroll margin position. This prevents
12015 try_scrolling from unnecessarily failing when
12016 scroll-conservatively is set to a value slightly larger than the
12017 window height. Clean up the case of PT below the margin at bottom
12018 of window: scroll_max can no longer be INT_MAX. When aggressive
12019 scrolling is in use, don't let point enter the opposite scroll
12020 margin as result of the scroll.
12021 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12022 threshold of 100 lines for never-recentering scrolling.
12023
e4cc2dfc
JB
120242011-03-31 Juanma Barranquero <lekktu@gmail.com>
12025
12026 * dispextern.h (move_it_by_lines):
12027 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12028 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12029 (message_log_check_duplicate): Remove parameters `prev_bol' and
12030 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12031 (redisplay_internal): Remove parameter `preserve_echo_area',
12032 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12033
12034 * indent.c (Fvertical_motion):
12035 * window.c (window_scroll_pixel_based, Frecenter):
12036 Don't pass `need_y_p' to `move_it_by_lines'.
12037
1c470562
SM
120382011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12039
44f230aa
SM
12040 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12041 steal a few bits to be more compact.
12042 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12043 Remove unneeded casts.
12044
1c470562
SM
12045 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12046
888adce9
ZK
120472011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12048
12049 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12050 binding" message (bug#7967).
12051
f838ed7b
PE
120522011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12053
77861b95
PE
12054 Fix more problems found by GCC 4.6.0's static checks.
12055
de6dbc14
PE
12056 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12057 Remove unused local var.
12058
f838ed7b
PE
12059 * editfns.c (Fmessage_box): Remove unused local var.
12060
792c7b2b
PE
12061 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12062 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12063 Omit unused local vars.
c499e557 12064 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12065 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12066 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12067 Omit unused local var.
12068
ba0165e1
PE
12069 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12070 Don't assume string length fits in int.
32ad8845 12071 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12072 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12073
3c59b4c9
PE
12074 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12075 instead of alloca (Bug#8344).
12076
a3eed478 12077 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12078 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12079
eb4d412d
PE
12080 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12081
1658b401
PE
12082 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12083 concerns.
12084
12085 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12086
12087 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12088
9a2c6e05
PE
12089 * keyboard.c (syms_of_keyboard): Use the same style as later
12090 in this function when indexing through an array. This also
12091 works around GCC bug 48267.
12092
03d0a109
PE
12093 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12094
44f730c8
PE
12095 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12096
fe75f926
PE
12097 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12098 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12099
ffa8c828
PE
12100 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12101 This avoids undefined behavior on integer overflow, and is a bit
12102 more convenient anyway since it is compared to a size_t variable.
12103
c5101a77
PE
12104 Variadic C functions now count arguments with size_t, not int.
12105 This avoids an unnecessary limitation on 64-bit machines, which
12106 caused (substring ...) to crash on large vectors (Bug#8344).
12107 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12108 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12109 All variadic functions and their callers changed accordingly.
c5101a77
PE
12110 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12111 * data.c (arith_driver, float_arith_driver): Likewise.
12112 * editfns.c (general_insert_function): Likewise.
12113 * eval.c (struct backtrace.nargs, interactive_p)
12114 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12115 (funcall_lambda, mark_backtrace): Likewise.
12116 * fns.c (concat): Likewise.
12117 * frame.c (x_set_frame_parameters): Likewise.
12118 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12119 0 if not found, not -1. All callers changed.
12120
dd3f25f7
PE
12121 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12122 (stack_copy_size): Now size_t, not int.
12123 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12124
461c2ab9
JB
121252011-03-28 Juanma Barranquero <lekktu@gmail.com>
12126
12127 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12128 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12129 All callers changed.
12130
12131 * lisp.h (multibyte_char_to_unibyte):
12132 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12133 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12134 * character.h (CHAR_TO_BYTE8):
12135 * cmds.c (internal_self_insert):
12136 * editfns.c (general_insert_function):
12137 * keymap.c (push_key_description):
12138 * search.c (Freplace_match):
12139 * xdisp.c (message_dolog, set_message_1): All callers changed.
12140
f6d62986
SM
121412011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12142
12143 * keyboard.c (safe_run_hook_funcall): New function.
12144 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12145 don't set the hook to nil, but remove the offending function instead.
12146 (Qcommand_hook_internal): Remove, unused.
12147 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12148 Vcommand_hook_internal.
12149
12150 * eval.c (enum run_hooks_condition): Remove.
12151 (funcall_nil, funcall_not): New functions.
12152 (run_hook_with_args): Call each function through a `funcall' argument.
12153 Remove `cond' argument, now redundant.
12154 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12155 (Frun_hook_with_args_until_failure): Adjust accordingly.
12156 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12157
1db5b1ad
JB
121582011-03-28 Juanma Barranquero <lekktu@gmail.com>
12159
12160 * dispextern.h (string_buffer_position): Remove declaration.
12161
12162 * print.c (strout): Remove parameter `multibyte', unused since
12163 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12164
12165 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12166 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12167 All callers changed.
12168
12169 * w32.c (_wsa_errlist): Use braces for struct initializers.
12170
12171 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12172 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12173 All callers changed.
12174 (string_buffer_position): Likewise. Also, make static (it's never
12175 used outside xdisp.c).
12176 (cursor_row_p): Remove parameter `w', unused since
12177 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12178 (decode_mode_spec): Remove parameter `precision', introduced during
12179 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12180 All callers changed.
12181
5ffb62aa
JD
121822011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12183
12184 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12185
461c2ab9 121862011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12187
12188 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12189 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12190 (ns_update_auto_hide_menu_bar): New functions.
12191 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12192 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12193 ns_constrain_all_frames.
12194 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12195 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12196
5c380ffb
JD
121972011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12198
12199 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12200
9af30bdf
GM
122012011-03-27 Glenn Morris <rgm@gnu.org>
12202
12203 * syssignal.h: Replace RETSIGTYPE with void.
12204 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12205 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12206 Replace SIGTYPE with void everywhere.
12207 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12208 * s/template.h (SIGTYPE): Remove commented out definition.
12209
e2abce01
JB
122102011-03-26 Eli Zaretskii <eliz@gnu.org>
12211
12212 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12213 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12214
f868cd8a
JB
122152011-03-26 Juanma Barranquero <lekktu@gmail.com>
12216
59eb0929
JB
12217 * w32.c (read_unc_volume): Use parameter `henum', instead of
12218 global variable `wget_enum_handle'.
12219
12220 * keymap.c (describe_vector): Remove parameters `indices' and
12221 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12222 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12223
f868cd8a
JB
12224 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12225
12226 * keyboard.c (timer_check): Remove parameter `do_it_now',
12227 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12228 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12229 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12230
12231 * keyboard.c (read_char):
12232 * w32menu.c (w32_menu_display_help):
12233 * xmenu.c (show_help_event, menu_help_callback):
12234 Adjust calls to `show_help_echo'.
12235
12236 * gtkutil.c (xg_maybe_add_timer):
12237 * keyboard.c (readable_events):
12238 * process.c (wait_reading_process_output):
12239 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12240
12241 * insdel.c (adjust_markers_gap_motion):
12242 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12243 (gap_left, gap_right): Don't call it.
12244
2ecf6fdb
CY
122452011-03-25 Chong Yidong <cyd@stupidchicken.com>
12246
12247 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12248 incurred during fontification.
12249
6b1f9ba4
JB
122502011-03-25 Juanma Barranquero <lekktu@gmail.com>
12251
12252 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12253 (DEFVAR_PER_BUFFER): Don't pass it.
12254
12255 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12256 (scrolling_window): Don't pass it.
12257
0f4a96b5
JB
122582011-03-25 Juanma Barranquero <lekktu@gmail.com>
12259
12260 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12261
12262 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12263 and `suffix'.
12264 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12265 of variables specific to SELinux and computation of `encoded_absname'.
12266
12267 * image.c (XPutPixel): Remove unused variable `height'.
12268
12269 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12270
12271 * unexw32.c (get_section_info): Remove unused variable `section'.
12272
12273 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12274 (system_process_attributes): Remove unused variable `sess'.
12275 (sys_read): Remove unused variable `err'.
12276
12277 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12278 (w32_wnd_proc): Remove unused variable `isdead'.
12279 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12280 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12281 (x_create_tip_frame): Remove unused variable `tem'.
12282
12283 * w32inevt.c (w32_console_read_socket):
12284 Remove unused variable `no_events'.
12285
12286 * w32term.c (x_draw_composite_glyph_string_foreground):
12287 Remove unused variable `width'.
12288
1149507c
JB
122892011-03-24 Juanma Barranquero <lekktu@gmail.com>
12290
12291 * w32term.c (x_set_glyph_string_clipping):
12292 Don't pass uninitialized region to CombineRgn.
12293
9c88f339
JB
122942011-03-23 Juanma Barranquero <lekktu@gmail.com>
12295
12296 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12297 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12298 (Fx_close_connection): Remove unused variable `i'.
12299
12300 * w32font.c (w32font_draw): Return number of glyphs.
12301 (w32font_open_internal): Remove unused variable `i'.
12302 (w32font_driver): Add missing initializer.
12303
12304 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12305 (fill_in_menu): Remove unused variable `items_added'.
12306
12307 * w32term.c (last_mouse_press_frame): Remove static global variable.
12308 (w32_clip_to_row): Remove unused variable `f'.
12309 (x_delete_terminal): Remove unused variable `i'.
12310
12311 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12312 (NOTHING): Remove unused static global variable.
12313 (uniscribe_check_otf): Remove unused variable `table'.
12314 (uniscribe_font_driver): Add missing initializers.
12315
dee091a3
JD
123162011-03-23 Julien Danjou <julien@danjou.info>
12317
12318 * term.c (Fsuspend_tty, Fresume_tty):
12319 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12320 * window.c (temp_output_buffer_show):
12321 * insdel.c (signal_before_change):
12322 * frame.c (Fhandle_switch_frame):
12323 * fileio.c (Fdo_auto_save):
12324 * emacs.c (Fkill_emacs):
12325 * editfns.c (save_excursion_restore):
12326 * cmds.c (internal_self_insert):
12327 * callint.c (Fcall_interactively):
12328 * buffer.c (Fkill_all_local_variables):
12329 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12330 Use Frun_hooks.
0f4a96b5 12331 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12332 unconditionally since it does the check itself.
dee091a3 12333
2c520ab5 123342011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12335
c9c49752
PE
12336 Fix more problems found by GCC 4.5.2's static checks.
12337
8abc3f12
PE
12338 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12339 the first time through the loop, since we know p0 < p1 then.
12340 This also avoids a gcc -Wstrict-overflow warning.
12341
a2d26660
PE
12342 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12343 leading to a memory leak, possible in functions like
12344 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12345 of objects (Bug#8318).
a2d26660 12346
916c72e9
PE
12347 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12348 that could (at least in theory) be that large.
12349
19ab8a18
PE
12350 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12351 This is less likely to overflow, and avoids undefined behavior if
12352 overflow does occur. All callers changed. Use strtoul to scan
12353 for the unsigned long integer.
b7cbbd6f
PE
12354 (pint2hrstr): Simplify and tune code slightly.
12355 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12356
f0641eff
PE
12357 * scroll.c (do_scrolling): Work around GCC bug 48228.
12358 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12359
7f650bb9
PE
12360 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12361 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12362 (validate_x_resource_name): Simplify count usage.
12363 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12364
37dd57d1
PE
12365 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12366 fail (Bug#8306).
81e56e61 12367
699979fc 12368 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12369
401bf9b4
PE
12370 * process.c (Fmake_network_process): Use socklen_t, not int,
12371 where POSIX says socklen_t is required in portable programs.
12372 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12373 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12374 (Fmake_network_process, server_accept_connection):
12375 (wait_reading_process_output, read_process_output):
12376 Likewise.
12377
b93aacde
PE
12378 * process.c: Rename or move locals to avoid shadowing.
12379 (list_processes_1, Fmake_network_process):
12380 (read_process_output_error_handler, exec_sentinel_error_handler):
12381 Rename or move locals.
4dc343ee 12382 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12383 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12384 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12385 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12386 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12387
af8a867c 12388 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12389 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12390 Include tparam.h instead, since it declares them.
af8a867c
PE
12391 * cm.h (PC): Remove extern decl; tparam.h now does this.
12392 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12393 * terminfo.c: Include tparam.h, to check interfaces.
12394 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12395 (tparam): Adjust signature to match interface in tparam.h;
12396 this removes some undefined behavior. Check that outstring and len
12397 are zero, which they always are with Emacs.
12398 * tparam.h (PC, BC, UP): New extern decls.
12399
0248044d 12400 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12401 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12402
8ff096c1 12403 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12404 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12405 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12406 (ftfont_list): Remove unused local.
49eaafba
PE
12407 (get_adstyle_property, ftfont_pattern_entity):
12408 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12409 Rename locals to avoid shadowing.
8ff096c1 12410
e2be39f6
PE
12411 * xfont.c (xfont_list_family): Mark var as initialized.
12412
c9735e30
PE
12413 * xml.c (make_dom): Now static.
12414
8f5201ae
PE
12415 * composite.c (composition_compute_stop_pos): Rename local to
12416 avoid shadowing.
b246f932
PE
12417 (composition_reseat_it): Remove unused locals.
12418 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12419 (composition_update_it): Mark var as initialized.
11b61122
PE
12420 (find_automatic_composition): Mark vars as initialized,
12421 with a FIXME (Bug#8290).
8f5201ae 12422
760fbc2c
PE
12423 character.h: Rename locals to avoid shadowing.
12424 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12425 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12426 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12427 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12428 to avoid shadowing.
12429
ff08eb85
PE
12430 * textprop.c (property_change_between_p): Remove; unused.
12431
fc7bf025
PE
12432 * intervals.c (interval_start_pos): Now static.
12433
235d7abc
PE
12434 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12435
44f230aa
SM
12436 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12437 Rename locals to avoid shadowing.
3e7d6594 12438
50060332
PE
12439 * sound.c (wav_play, au_play, Fplay_sound_internal):
12440 Fix pointer signedness.
d01f234b 12441 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12442 (wav_play): Initialize a variable to 0, to prevent undefined
12443 behavior (Bug#8278).
50060332 12444
c4fc4e30
PE
12445 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12446
918436ed
PE
12447 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12448
c939f91b
PE
12449 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12450 clobbering (Bug#8298).
b9c7f648
PE
12451 * sysdep.c (sys_subshell): Likewise.
12452 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12453
6bd8c144
PE
12454 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12455 This should get cleaned up, so that child_setup has the
12456 same signature on all platforms.
12457
7710357c 12458 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12459 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12460
c59da222
CY
124612011-03-22 Chong Yidong <cyd@stupidchicken.com>
12462
12463 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12464 not to be necessary, and produces flickering.
12465
66b87493
GM
124662011-03-20 Glenn Morris <rgm@gnu.org>
12467
12468 * config.in: Remove file.
12469
45b6f6d5
JB
124702011-03-20 Juanma Barranquero <lekktu@gmail.com>
12471
12472 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12473 are now in src/globals.h.
12474 (syms_of_minibuf): Remove spurious & from previous change.
12475
cd394be1 124762011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12477
12478 * minibuf.c (completing-read-function): New variable.
12479 (completing-read-default): Rename from completing-read.
12480 (completing-read): Call completing-read-function.
12481
b14e3e21
CY
124822011-03-19 Juanma Barranquero <lekktu@gmail.com>
12483
12484 * xfaces.c (Fx_load_color_file):
12485 Read color file from absolute filename (bug#8250).
12486
f2b726e6
JB
124872011-03-19 Juanma Barranquero <lekktu@gmail.com>
12488
12489 * makefile.w32-in: Update dependencies.
12490
09f6ff02
EZ
124912011-03-17 Eli Zaretskii <eliz@gnu.org>
12492
12493 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12494
29a6015a
PE
124952011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12496
a3a6c54e
PE
12497 Fix more problems found by GCC 4.5.2's static checks.
12498
b766f867
PE
12499 * process.c (make_serial_process_unwind, send_process_trap):
12500 (sigchld_handler): Now static.
12501
be02381c
PE
12502 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12503 That way, the code declares only the vars that it needs.
12504 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12505 * s/cygwin.h (PTY_ITERATION): Likewise.
12506 * s/darwin.h (PTY_ITERATION): Likewise.
12507 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12508
57048744
PE
12509 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12510 * process.c (allocate_pty): Don't declare stb unless it's needed.
12511
7914961c 12512 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12513 (CONSTANTLIM): Remove; unused.
12514 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12515 Define only if needed.
7914961c 12516
b3967b18
PE
12517 * unexelf.c (unexec): Name an expression,
12518 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12519 Use a different way to cause a compilation error if anyone uses
12520 n rather than nn, a way that does not involve shadowing.
73366a00 12521 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12522
29a6015a
PE
12523 * deps.mk (unexalpha.o): Remove; unused.
12524
43cfc33e 12525 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12526 * unexec.h: New file.
ce701a33
PE
12527 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12528 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12529 Depend on unexec.h.
12530 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12531 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12532 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12533 Change as necessary to match prototype in unexec.h.
ce701a33 12534
01f44d5a
PE
12535 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12536 shadowing.
4f63c6bb 12537 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12538
a6670b0b
PE
12539 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12540 Rename locals to avoid shadowing.
12541
cef2010d 12542 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12543 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12544
d4d7173a
PE
12545 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12546
f08b802a
PE
12547 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12548 warning when compiling print.c.
12549
3ddb0639
PE
12550 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12551 instead of using an uninitialized var.
5ad03b97 12552 (font_sort_entities): Mark var as initialized.
3ddb0639 12553
170a2692
PE
12554 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12555
e663c700
PE
12556 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12557 pointers to constants.
89bc529a 12558 (font_parse_fcname): Remove unused vars.
7b81e2d0 12559 (font_delete_unmatched): Now static.
ea838e10 12560 (font_get_spec): Remove; unused.
13a547c6
PE
12561 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12562 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12563 Rename or move locals to avoid shadowing.
e663c700 12564
2a80c887 12565 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12566 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12567
1384fa33 12568 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12569 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12570
8b2c52e9
PE
12571 * alloc.c (mark_backtrace): Move decl from here ...
12572 * lisp.h: ... to here, so that it can be checked.
12573
475545b5 12574 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12575 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12576 (lisp_indirect_variable): Name an expression,
12577 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12578 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12579
b1349114 12580 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12581 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12582 Use const pointer when appropriate.
b1349114 12583
a2928364
PE
12584 * lisp.h (get_system_name, get_operating_system_release):
12585 Move decls here, to check interfaces.
12586 * process.c (get_operating_system_release): Move decl to lisp.h.
12587 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12588 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12589 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12590 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12591 (Fformat_time_string, Fencode_time, Finsert_char):
12592 (Ftranslate_region_internal, Fformat):
12593 Rename or remove local vars to avoid shadowing.
9710023e 12594 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12595
a415e694
PE
12596 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12597 avoid shadowing.
12598
8ef4622d
PE
12599 * lisp.h (eassert): Check that the argument compiles, even if
12600 ENABLE_CHECKING is not defined.
12601
946f9a5b
PE
12602 * data.c (Findirect_variable): Name an expression, to avoid
12603 gcc -Wbad-function-cast warning.
112396d6 12604 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12605 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12606 (Fmake_variable_buffer_local, Fmake_local_variable):
12607 Mark variables as initialized.
52746918 12608 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12609
e5aab7e7 12610 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12611 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12612 Rename locals to avoid shadowing.
dff45157
PE
12613 (mark_stack): Move local variables into the #ifdef region where
12614 they're used.
7bc26fdb
PE
12615 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12616 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12617 needed otherwise.
12618 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12619 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12620 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12621
e5aab7e7
PE
12622 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12623 avoids undefined behavior in theory.
12624
4da60324
PE
12625 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12626
88043301
PE
12627 Use functions, not macros, for up- and down-casing (Bug#8254).
12628 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12629 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12630 to use the following functions instead of these macros.
12631 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12632 EMACS_INT, since callers assume the returned value fits in int.
12633 (upcase1): Likewise, for UPCASE_TABLE.
12634 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12635 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12636 the race-condition problem in the old DOWNCASE.
88043301 12637
19ed5445
PE
12638 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12639 Rename locals to avoid shadowing.
12640 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12641 (regex_compile, re_search_2, re_match_2_internal):
12642 Remove unused local vars.
952db0d7
PE
12643 (FREE_VAR): Rewrite so as not to use empty "else",
12644 which gcc can warn about.
da053e48 12645 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12646 (RETALLOC_IF): Define only if needed.
12647 (WORDCHAR_P): Likewise. This one is never needed, but is used
12648 only in a comment talking about a compiler bug, so put inside
12649 the #if 0 of that comment.
12650 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12651 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12652 Remove; unused.
19ed5445 12653
1f3561e4 12654 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12655 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12656 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12657
ded6f8f7
PE
12658 * search.c (simple_search): Remove unused var.
12659
dbd37a95
PE
12660 * dired.c (compile_pattern): Move decl from here ...
12661 * lisp.h: ... to here, so that it can be checked.
12662 (struct re_registers): New forward decl.
12663
7e47afad
PE
12664 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12665
85f24f61
PE
12666 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12667 All uses changed.
12668 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12669 Rename locals to avoid shadowing.
5671df8f 12670 (Fvertical_motion): Mark locals as initialized.
85f24f61 12671
181aa2be 12672 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12673 (casify_region): Mark local as initialized.
181aa2be 12674
930d429c
PE
12675 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12676
7082eac6
PE
12677 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12678 New macros, so that the caller can use some names other than
12679 gcpro1, gcpro2, etc.
12680 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12681 of the new macros.
12682 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12683 argument, for consistency with GCPRO2_VAR, etc: it is now the
12684 prefix of the variable, not the variable itself. All uses
12685 changed.
38b2c076
PE
12686 * dired.c (directory_files_internal, file_name_completion):
12687 Rename locals to avoid shadowing.
12688
15206ed9
PE
12689 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12690 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12691 dired.c's scmp function, had undefined behavior.
12692 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12693 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12694 * buffer.h: ... to here, because these macros use current_buffer,
12695 and the new implementation with inline functions needs to have
12696 current_buffer in scope now, rather than later when the macros
12697 are used.
12698 (downcase, upcase1): New static inline functions.
12699 (DOWNCASE, UPCASE1): Reimplement using these functions.
12700 This avoids undefined behavior in expressions like
12701 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12702 from race conditions in accessing the global variables
12703 case_temp1 and case_temp2.
12704 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12705 * lisp.h (case_temp1, case_temp2): Remove their decls.
12706 * character.h (ASCII_CHAR_P): Move from here ...
12707 * lisp.h: ... to here, so that the inline functions mentioned
12708 above can use them.
12709
4a6bea26
PE
12710 * dired.c (directory_files_internal_unwind): Now static.
12711
f14b7e14
PE
12712 * fileio.c (file_name_as_directory, directory_file_name):
12713 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12714 Now static.
2893f146
PE
12715 (file_name_as_directory): Use const pointers when appropriate.
12716 (Fexpand_file_name): Likewise. In particular, newdir might
12717 point at constant storage, so make it a const pointer.
fd4ead52 12718 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12719 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12720 signedness issues.
f839df0c
PE
12721 (Fset_file_times, Finsert_file_contents, auto_save_error):
12722 Rename locals to avoid shadowing.
f14b7e14 12723
5716756e 12724 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12725 (Ftry_completion, Fall_completions): Rename or remove locals
12726 to avoid shadowing.
5716756e 12727
b4c3046a
PE
12728 * marker.c (bytepos_to_charpos): Remove; unused.
12729
b45db522
PE
12730 * lisp.h (verify_bytepos, count_markers): New decls,
12731 so that gcc does not warn that these functions aren't declared.
12732
85876d07
PE
12733 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12734 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12735 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12736 (copy_text): Remove unused local var.
85876d07 12737
03d78a21 12738 * filelock.c (within_one_second): Now static.
b3dd38ab 12739 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12740
5df8f01b
PE
12741 * buffer.c (fix_overlays_before): Mark locals as initialized.
12742 (fix_start_end_in_overlays): Likewise. This function should be
12743 simplified by using pointers-to-pointers, but that's a different
12744 matter.
b1d876f1 12745 (switch_to_buffer_1): Now static.
8f54f30a
PE
12746 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12747 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12748
a70072c9 12749 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12750 Fix pointer signedness issue.
edced198
PE
12751 (sys_subshell): Mark local as volatile if checking for lint,
12752 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12753 (MAXPATHLEN): Define only if needed.
a70072c9 12754
a0977c44
PE
12755 * process.c (serial_open, serial_configure): Move decls from here ...
12756 * systty.h: ... to here, so that they can be checked.
12757
a884fdcc
PE
12758 * fns.c (get_random, seed_random): Move extern decls from here ...
12759 * lisp.h: ... to here, so that they can be checked.
12760
604efe86 12761 * sysdep.c (reset_io): Now static.
b8950c94 12762 (wait_for_termination_signal): Remove; unused.
604efe86 12763
38fc62d9
PE
12764 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12765 (copy_keymap_item, append_key, push_text_char_description):
12766 Now static.
1004a21a 12767 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12768 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12769 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12770 (describe_map_tree):
12771 Rename locals to avoid shadowing.
38fc62d9 12772
2f2650da
PE
12773 * keyboard.c: Declare functions static if they are not used elsewhere.
12774 (echo_char, echo_dash, cmd_error, top_level_2):
12775 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12776 (read_char, kbd_buffer_get_event, make_lispy_position):
12777 (make_lispy_event, make_lispy_movement, apply_modifiers):
12778 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12779 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12780 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12781 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12782 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12783
a053e86c 12784 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12785 (mark_kboards): Move decl here ...
12786 * alloc.c (mark_kboards): ... from here.
a053e86c 12787
4752793e
PE
12788 * lisp.h (force_auto_save_soon): New decl.
12789
74f10ca7 12790 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12791 (DEFINE_DUMMY_FUNCTION): New macro.
12792 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12793 Use it.
c03cd23f
PE
12794 (main): Add casts to avoid warnings
12795 if GCC considers string literals to be constants.
74f10ca7 12796
022e70d4
PE
12797 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12798
59d6fe83
PE
12799 * dbusbind.c: Pointer signedness fixes.
12800 (xd_signature, xd_append_arg, xd_initialize):
12801 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12802 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12803 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12804 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12805
78320123
PE
12806 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12807 if GCC considers string literals to be constants.
49cebcca 12808 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12809
35ac2a97
SM
128102011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12811
fb103ca9
SM
12812 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12813 (print_preprocess, print_object): New macro to fix last change.
12814
35ac2a97
SM
12815 * print.c (print_preprocess): Don't forget font objects.
12816
62973b41
JB
128172011-03-16 Juanma Barranquero <lekktu@gmail.com>
12818
12819 * emacs.c (USAGE3): Doc fixes.
12820
0e48bb22
AS
128212011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12822
12823 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12824 structure.
12825
7684e57b
JB
128262011-03-14 Juanma Barranquero <lekktu@gmail.com>
12827
12828 * lisp.h (VWindow_system, Qfile_name_history):
12829 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12830 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12831 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12832
12833 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12834 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12835
12836 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12837 * w32console.c (detect_input_pending, read_input_pending)
12838 (encode_terminal_code):
12839 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12840 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12841 (w32_system_caret_y, Qfile_name_history):
12842 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12843 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12844 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12845 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12846 * w32proc.c (Qlocal, report_file_error):
12847 * w32term.c (Vwindow_system, updating_frame):
12848 * w32uniscribe.c (initialized, uniscribe_font_driver):
12849 Remove unneeded extern declarations.
12850
2aa46d6c
CY
128512011-03-14 Chong Yidong <cyd@stupidchicken.com>
12852
c96bbc66 12853 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12854
cffc6f3b
CY
128552011-03-13 Chong Yidong <cyd@stupidchicken.com>
12856
12857 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12858 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12859 These macros can no longer be used for assignment.
12860
44f230aa
SM
12861 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12862 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12863 (record_buffer_markers, fetch_buffer_markers): New functions for
12864 recording and fetching special buffer markers.
12865 (set_buffer_internal_1, set_buffer_temp): Use them.
12866
12867 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12868
12869 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12870
12871 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12872 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12873
12874 * xdisp.c (hscroll_window_tree):
12875 (reconsider_clip_changes): Use PT instead of BUF_PT.
12876
d251f04b
EZ
128772011-03-13 Eli Zaretskii <eliz@gnu.org>
12878
12879 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12880 $(EMACS_ROOT)/lib/intprops.h.
12881
f0c77cd1
PE
128822011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12883
3eca4629
PE
12884 Fix more problems found by GCC 4.5.2's static checks.
12885
7c86ee98
PE
12886 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12887 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12888 (xg_free_frame_widgets): Make it clear that a local variable is
12889 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12890 (gdk_window_get_screen): Make it clear that this macro is needed
12891 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12892 (int_gtk_range_get_value): New function, which avoids a diagnostic
12893 from gcc -Wbad-function-cast.
12894 (xg_set_toolkit_scroll_bar_thumb): Use it.
12895 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12896 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12897 (get_utf8_string, xg_get_file_with_chooser):
12898 Rename locals to avoid shadowing.
12899 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12900
41729b81
PE
12901 * xgselect.c (xg_select): Remove unused var.
12902
f0c77cd1
PE
12903 * image.c (four_corners_best): Mark locals as initialized.
12904 (gif_load): Initialize transparent_p to zero (Bug#8238).
12905 Mark another local as initialized.
ec6cf4c6 12906 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12907
ce0ad53d 12908 * image.c (clear_image_cache): Now static.
d5d5a617 12909 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12910 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12911 (x_edge_detection): Remove unnecessary cast that
12912 gcc -Wbad-function-cast diagnoses.
2037898d 12913 (gif_load): Fix pointer signedness.
6ae141d6
PE
12914 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12915 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12916
33383987 129172011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12918
d32df629
PE
12919 Improve quality of tests for time stamp overflow.
12920 For example, without this patch (encode-time 0 0 0 1 1
12921 1152921504606846976) returns the obviously-bogus value (-948597
12922 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12923 reports time overflow. See
12924 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12925 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12926 * editfns.c: Include limits.h and intprops.h.
12927 (TIME_T_MIN, TIME_T_MAX): New macros.
12928 (time_overflow): Move earlier, to before first use.
12929 (hi_time, lo_time): New functions, for an accurate test for
12930 out-of-range times.
12931 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12932 (Fget_internal_run_time): Don't assume time_t fits in int.
12933 (make_time): Use list2 instead of Fcons twice.
12934 (Fdecode_time): More accurate test for out-of-range times.
12935 (check_tm_member): New function.
12936 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12937 (lisp_time_argument): Don't rely on undefined left-shift and
12938 right-shift behavior when checking for time stamp overflow.
8be6f318 12939
fe31d94c
PE
12940 * editfns.c (time_overflow): New function, refactoring common code.
12941 (Fformat_time_string, Fdecode_time, Fencode_time):
12942 (Fcurrent_time_string): Use it.
12943
8be6f318
PE
12944 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12945 * dired.c (make_time): Move to ...
12946 * editfns.c (make_time): ... here.
12947 * systime.h: Note the move.
12948
09d9db2c 129492011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12950
126bc0dc
YM
12951 * fringe.c (update_window_fringes): Remove unused variables.
12952
c47cbdfd
YM
12953 * unexmacosx.c (copy_data_segment): Also copy __got section.
12954 (Bug#8223)
12955
7ac80be9
EZ
129562011-03-12 Eli Zaretskii <eliz@gnu.org>
12957
c96bbc66 12958 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12959 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12960 Constify `char *' arguments and their references according to
12961 prototypes in tparam.h.
12962
ecb0f94d 12963 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12964
7ac80be9
EZ
12965 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12966 Adapt all references accordingly.
12967
12968 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12969
ef1fd07e
TT
129702011-03-11 Tom Tromey <tromey@redhat.com>
12971
12972 * buffer.c (syms_of_buffer): Remove obsolete comment.
12973
7ef4b50c
EZ
129742011-03-11 Eli Zaretskii <eliz@gnu.org>
12975
12976 * termhooks.h (encode_terminal_code): Declare prototype.
12977
12978 * msdos.c (encode_terminal_code): Don't declare prototype.
12979
12980 * term.c (encode_terminal_code): Now external again, used by
12981 w32console.c and msdos.c.
12982
44f230aa
SM
12983 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12984 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12985
4b1ec863 129862011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12987
1714f52b 12988 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12989
4b1ec863
PE
12990 * fringe.c (update_window_fringes): Mark locals as initialized
12991 (Bug#8227).
12992 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12993
524c7aa6
PE
12994 * alloc.c (mark_fringe_data): Move decl from here ...
12995 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12996 to check its interface.
12997 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12998
a5c0af81 12999 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13000 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13001 (fontset_font): Mark local as initialized.
a9a06e0b 13002 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13003
b4716021
PE
13004 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13005
811e9bac 13006 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13007 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13008 (x_own_selection, Fx_disown_selection_internal): Rename locals
13009 to avoid shadowing.
13010 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13011
7e3ab302
PE
13012 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13013 so that the caller can use some name other than gcpro1.
13014 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13015 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13016 (Fx_backspace_delete_keys_p):
13017 Use them to avoid shadowing, and rename vars to avoid shadowing.
13018 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13019 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13020 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13021 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13022 Remove unused locals.
7e3ab302
PE
13023 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13024 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13025 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13026 macros.
f78faa98 13027
e2b13473
PE
13028 * xterm.h (x_mouse_leave): New decl.
13029
77f23912
PE
13030 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13031 Remove unused functions.
cdf4ba58
PE
13032 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13033 (x_calc_absolute_position): Now static.
7411c686 13034 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13035 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13036 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13037 unless they are used.
38d0b34a
PE
13038 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13039 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13040 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13041 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13042 (x_error_catcher, x_connection_closed, x_error_handler):
13043 (x_error_quitter, xembed_send_message, x_iconify_frame):
13044 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13045 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13046 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13047
44f230aa
SM
13048 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13049 Rename or move locals to avoid shadowing.
6b463e58 13050 (tty_defined_color, merge_face_heights): Now static.
5967d051 13051 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13052 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13053 does not deduce is never used uninitialized.
73719eba
PE
13054 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13055 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13056
426994c3 13057 * terminal.c (store_terminal_param): Now static.
5489860b 13058
032f1620 13059 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13060 (set_frame_menubar): Remove unused local.
d4323972 13061 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13062 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13063 since they might point to immutable storage.
281585b0
PE
13064 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13065 since it's unused otherwise.
032f1620 13066
367c19e5 13067 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13068 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13069 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13070 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13071 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13072 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13073 does not deduce are never used uninitialized.
70739cbe 13074
07b48fa9
PE
13075 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13076
8868a238 13077 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13078 * window.c (window_loop, size_window):
13079 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13080
7e5cf297 13081 * window.c (display_buffer): Now static.
d6550a9f
PE
13082 (size_window): Mark variables that gcc -Wuninitialized
13083 does not deduce are never used uninitialized.
a586633d
PE
13084 * window.h (check_all_windows): New decl, to forestall
13085 gcc -Wmissing-prototypes diagnostic.
5b555da1 13086 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13087
f6095868
PE
13088 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13089 shadowing.
13090 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13091 Include <limits.h>.
13092 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13093 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13094 (load_charset_map): Mark variables that gcc -Wuninitialized
13095 does not deduce are never used uninitialized.
53df7c11 13096 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13097
f38b440c
PE
13098 * coding.c (coding_set_source, coding_set_destination):
13099 Use "else { /* comment */ }" rather than "else /* comment */;"
13100 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13101 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13102 a block, when the outer 'i' will do.
13103 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13104 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13105 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13106 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13107 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13108 Rename locals to avoid shadowing.
13109 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13110 * coding.c (emacs_mule_char, encode_invocation_designation):
13111 Now static, since they're not used elsewhere.
413bb2db 13112 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13113 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13114 (decode_coding_emacs_mule): Mark variables that gcc
13115 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13116 (detect_coding_iso_2022): Initialize a local variable that might
13117 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13118 this initialization is needed. (Bug#8211)
5f58e762
PE
13119 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13120 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13121 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13122 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13123 Remove unused macros.
f38b440c 13124
232b38b9 13125 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13126 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13127 * character.c (string_count_byte8): Likewise.
232b38b9 13128
fb90da1b
PE
13129 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13130 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13131
fb93dbc2
PE
13132 * chartab.c (copy_sub_char_table): Now static, since it's not used
13133 elsewhere.
5c156ace
PE
13134 (sub_char_table_ref_and_range, char_table_ref_and_range):
13135 Rename locals to avoid shadowing.
bbcd0949 13136 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13137
7d3b3862 13138 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13139 (BIDI_BOB): Remove unused macro.
7d3b3862 13140
6be7d3da
PE
13141 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13142 deduce are never used uninitialized.
c2ed9c8b 13143 * term.c (encode_terminal_code): Likewise.
6be7d3da 13144
75f8807f 13145 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13146
50938595
PE
13147 * tparam.h: New file.
13148 * term.c, tparam.h: Include it.
13149 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13150 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13151 Move these decls to tparam.h, and make them agree with what
13152 is actually in tparam.c. The previous trick of using incompatible
13153 decls in different modules does not conform to the C standard.
13154 All callers of tparam changed to use tparam's actual API.
13155 * tparam.c (tparam1, tparam, tgoto):
13156 Use const pointers where appropriate.
13157
fbceeba2
PE
13158 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13159 * cm.h (struct cm): Likewise.
13160 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13161 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13162 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13163 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13164 (turn_on_face, init_tty): Likewise.
13165 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13166
7f3f1250
PE
13167 * term.c (term_mouse_position): Rename local to avoid shadowing.
13168
e6ca6543
PE
13169 * alloc.c (mark_ttys): Move decl from here ...
13170 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13171
c40f8d15
AS
131722011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13173
13174 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13175
cfe0661d
JB
131762011-03-09 Juanma Barranquero <lekktu@gmail.com>
13177
13178 * search.c (compile_pattern_1): Remove argument regp, unused since
13179 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13180 (compile_pattern): Don't pass it.
13181
0afb4571
J
131822011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13183
13184 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13185 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13186 for ! HAVE_GTK3.
13187 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13188
13189 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13190
13191 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13192 gdk_window_get_screen, gdk_window_get_geometry,
13193 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13194 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13195 (xg_get_pixbuf_from_pixmap): New function.
13196 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13197 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13198 Call xg_get_pixbuf_from_pixmap instead of
13199 gdk_pixbuf_get_from_drawable.
13200 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13201 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13202 (xg_check_special_colors): Use GtkStyleContext and its functions
13203 for HAVE_GTK3.
13204 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13205 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13206 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13207 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13208 Call gtk_widget_get_preferred_size.
0afb4571
J
13209 (xg_frame_resized): gdk_window_get_geometry only takes 5
13210 parameters.
44f230aa
SM
13211 (xg_win_to_widget, xg_event_is_for_menubar):
13212 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13213 (xg_set_widget_bg): New function.
13214 (delete_cb): New function.
895009e1 13215 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13216 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13217 (xg_set_background_color): Call xg_set_widget_bg.
13218 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13219 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13220 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13221 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13222 if ! HAVE_GTK3.
13223 (update_frame_tool_bar): Call gtk_widget_hide.
13224 (xg_initialize): Use GDK_KEY_g.
13225
13226 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13227 if ! HAVE_GTK3
13228 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13229
13230 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13231 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13232 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13233
1c2cc4ef
JB
132342011-03-08 Juanma Barranquero <lekktu@gmail.com>
13235
13236 * w32xfns.c (select_palette): Check success of RealizePalette against
13237 GDI_ERROR, not zero.
13238
33383987 13239See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13240
13241;; Local Variables:
13242;; coding: utf-8
aac0c6e3
MR
13243;; End:
13244
2f097256 13245 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13246
13247 This file is part of GNU Emacs.
13248
13249 GNU Emacs is free software: you can redistribute it and/or modify
13250 it under the terms of the GNU General Public License as published by
13251 the Free Software Foundation, either version 3 of the License, or
13252 (at your option) any later version.
13253
13254 GNU Emacs is distributed in the hope that it will be useful,
13255 but WITHOUT ANY WARRANTY; without even the implied warranty of
13256 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13257 GNU General Public License for more details.
13258
13259 You should have received a copy of the GNU General Public License
13260 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.