* lisp/pcmpl-unix.el (pcomplete/ssh): SSH does allow ganging.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
6b02f655
SM
12011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2
3 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4 errors in XSetWindowBorder (bug#9310).
5
81d40c92
DA
62011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
7
8 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
9 avoid crash when xmalloc overrun checking is enabled.
10
d4172c3b
EZ
112011-10-13 Eli Zaretskii <eliz@gnu.org>
12
13 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
14 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
15 cursor motion with <left> and <right> arrow keys.
16
17 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
18 some callers set that themselves.
19
b00eea75
EZ
202011-10-12 Eli Zaretskii <eliz@gnu.org>
21
22 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
23 display string and the previous row comes from the same string and
24 is empty. (Bug#9739) (Bug#9738)
25
8fe012c4
SM
262011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
27
28 * doc.c (get_doc_string): Encode file name (bug#9735).
29
0074aef2
EZ
302011-10-12 Eli Zaretskii <eliz@gnu.org>
31
79beb178
EZ
32 * bidi.c (bidi_level_of_next_char):
33 * xdisp.c (get_visually_first_element): Remove old incorrect
34 comments regarding the Unicode Line Separator character.
35
0074aef2
EZ
36 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
37
6e4b3fbe
DA
382011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
39
40 * alloc.c (Fgc_status): Do not access beyond zombies array
41 boundary if nzombies > MAX_ZOMBIES.
42 * alloc.c (dump_zombies): Add missing format specifier.
43
0324f3af
PE
442011-10-12 Paul Eggert <eggert@cs.ucla.edu>
45
b5525cac
PE
46 * xdisp.c (set_cursor_from_row): Simplify conditionals,
47 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
48
0324f3af
PE
49 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
50 Some packages use them to denote characters with modifiers.
51
e9b5f888
AS
522011-10-11 Andreas Schwab <schwab@linux-m68k.org>
53
54 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
55 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
56 matching a pp-number. Rename parameter var to var1.
57
127827c0
SM
582011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
59
60 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
61
c8fd3bd0
GM
622011-10-08 Glenn Morris <rgm@gnu.org>
63
64 * callint.c (Fcall_interactively): Give a more explicit error for the
65 'c' case with a non-character input. (Bug#8479)
66
352ec8ff
EZ
672011-10-08 Eli Zaretskii <eliz@gnu.org>
68
03669ccb
EZ
69 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
70 lines.
7061c986
EZ
71 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
72 lines that are hscrolled on the left.
03669ccb 73
352ec8ff
EZ
74 * dispnew.c (buffer_posn_from_coords): Account for a possible
75 presence of header-line. (Bug#4426)
76
a66cfb1c
SM
772011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
78
6b02f655
SM
79 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
80 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 81
7c5ee88e
PE
822011-10-07 Paul Eggert <eggert@cs.ucla.edu>
83
84 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
85 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
86 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
87 this makes Emacs dump core during garbage collection on rare
88 occasions. sizeof is obviously inferior to offsetof here, so
89 stick with offsetof.
90 (GC_POINTER_ALIGNMENT): New macro.
91 (mark_memory): Omit 3rd (offset) arg; caller changed.
92 Don't assume EMACS_INT alignment is the same as pointer alignment.
93
df1bbe5b
SM
942011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
95
96 * keyboard.c (read_key_sequence_remapped): New var.
97 (read_key_sequence): Compute remapping in the right buffer.
98 (command_loop_1): Use read_key_sequence's remapping directly.
99
51553db6
SM
1002011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
101
32c1fffd
SM
102 * dired.c (file_name_completion): Don't expand file name.
103 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
104 before checking file name handler.
105
51553db6
SM
106 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
107 they've been requested explicitly (bug#9591).
108
b6bd1599 1092011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
110
111 * keymap.c (Fsingle_key_description): Use make_specified_string
112 instead of build_string to build string from push_key_description.
113 (Bug#5193)
114
f701dc2a
PE
1152011-09-30 Paul Eggert <eggert@cs.ucla.edu>
116
4222c55d
PE
117 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
118 This fixes a Y2038 bug on 64-bit hosts.
119 * buffer.c (reset_buffer):
120 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
121 (Fclear_buffer_auto_save_failure):
122 Use 0, not -1, to represent an unset failure time, since time_t
123 might not be signed.
124
f701dc2a
PE
125 Remove dependency on glibc malloc internals.
126 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
127 Move back here from lisp.h, but with their new implementations.
128 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
129 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
130 * charset.c (charset_table_init): New static var.
131 (syms_of_charset): Use it instead of xmalloc. This removes a
132 dependency on glibc malloc internals. See Eli Zaretskii's comment in
133 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
134 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
135 Move back to alloc.c.
136 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
137 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
138
9ceebf39
JD
1392011-09-30 Jan Djärv <jan.h.d@swipnet.se>
140
141 * nsterm.m (windowDidResize): Call x_set_window_size only when
142 ns_in_resize is true. Otherwise set pixelwidth/height and
143 call change_frame_size (Bug#9628).
144
cb993c58
PE
1452011-09-30 Paul Eggert <eggert@cs.ucla.edu>
146
3930c88b
PE
147 Port --enable-checking=all to Fedora 14 x86-64.
148 * charset.c (syms_of_charset): Also account for glibc malloc's
149 internal overhead when calculating the initial malloc maximum.
150
cb993c58
PE
151 Port --enable-checking=all to Fedora 14 x86.
152 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
153 Move to lisp.h.
154 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
155 (overrun_check_realloc, overrun_check_free):
156 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
157 That way, xmalloc returns a properly-aligned pointer even if
158 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
159 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
160 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
161 into account when calculating the initial malloc maximum.
162 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
163 Move here from alloc.c, so that charset.c can use it too.
164 Properly align; the old code wasn't right for common 32-bit hosts
165 when configured with --enable-checking=all.
166 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
167 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
168
31bed486
EZ
1692011-09-29 Eli Zaretskii <eliz@gnu.org>
170
04c70788 171 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
172 use EDOM.
173
fbcaa2f3
EZ
1742011-09-28 Eli Zaretskii <eliz@gnu.org>
175
176 * xdisp.c (compute_display_string_end): If there's no display
177 string at CHARPOS, return -1.
178
179 * bidi.c (bidi_fetch_char): When compute_display_string_end
180 returns a negative value, treat the character as a normal
181 character not covered by a display string. (Bug#9624)
182
a239d4e9
JB
1832011-09-28 Juanma Barranquero <lekktu@gmail.com>
184
185 * lread.c (Fread_from_string): Fix typo in docstring.
186
88652fd5
EZ
1872011-09-27 Eli Zaretskii <eliz@gnu.org>
188
189 * xdisp.c (handle_invisible_prop): If invisible text ends on a
190 newline, reseat the iterator instead of bidi-iterating there one
191 character at a time. (Bug#9610)
32c1fffd
SM
192 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
193 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 194
ed497dd4
AS
1952011-09-27 Andreas Schwab <schwab@linux-m68k.org>
196
197 * lread.c (readevalloop): Use correct code for NBSP.
198 (read1): Likewise. (Bug#9608)
199
b2bf61aa
MA
2002011-09-25 Michael Albinus <michael.albinus@gmx.de>
201
202 * dbusbind.c (Fdbus_register_signal): When service is not
203 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
204
32bbb17c
GM
2052011-09-25 Glenn Morris <rgm@gnu.org>
206
207 * buffer.c (truncate-lines): Doc fix.
208
94e0933e
CY
2092011-09-24 Chong Yidong <cyd@stupidchicken.com>
210
211 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
212 (Fset_window_next_buffers): Doc fix.
213
cddde921
GM
2142011-09-24 Glenn Morris <rgm@gnu.org>
215
216 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
217
1260aef1
PE
2182011-09-24 Paul Eggert <eggert@cs.ucla.edu>
219
25b4bfa0
PE
220 Fix minor problems found by static checking.
221 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
222 * indent.c (Fvertical_motion): Fix == vs = typo.
223
e3cbd34b
EZ
2242011-09-24 Eli Zaretskii <eliz@gnu.org>
225
a66cfb1c
SM
226 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
227 Default value is now t. Doc fix.
6bf7006f 228
e3cbd34b 229 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 230 logic when moving up, not only when moving down. Fix the
e3cbd34b 231 confusing name and values of the it_overshoot_expected variable;
32c1fffd 232 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
233
234 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
235 CHARPOS is covered by a display string which includes newlines.
236 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
237 is covered by a display string with embedded newlines.
238
a3de0cbd
MA
2392011-09-24 Michael Albinus <michael.albinus@gmx.de>
240
241 * dbusbind.c (Fdbus_register_signal): Add match rule to
242 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
243 (Fdbus_register_method, Vdbus_registered_objects_table):
244 Fix docstring.
a3de0cbd 245
b260039d
JM
2462011-09-24 Jim Meyering <meyering@redhat.com>
247
32c1fffd 248 do not ignore write error for any output size
b260039d
JM
249 The previous change was incomplete.
250 While it makes emacs --batch detect the vast majority of stdout
251 write failures, errors were still ignored whenever the output size is
252 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
253 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
254 && echo FAIL: ignored write error
255 FAIL: ignored write error
256 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
257 && echo FAIL: ignored write error
258 FAIL: ignored write error
259 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
260
8eca8a7c
AS
2612011-09-23 Andreas Schwab <schwab@linux-m68k.org>
262
263 * emacs.c (Fkill_emacs): In noninteractive mode exit
264 non-successfully if a write error occurred on stdout. (Bug#9574)
265
3341db62
EZ
2662011-09-21 Eli Zaretskii <eliz@gnu.org>
267
268 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
269 the xassert test.
270
271 * dispextern.h (struct it): Update the comment documenting what
272 can it->OBJECT be.
273
8c203dbf
EZ
2742011-09-20 Eli Zaretskii <eliz@gnu.org>
275
276 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
277 a display string, extend search for cursor position to end of row.
278 (find_row_edges): If the row ends in a newline from a display
279 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
280 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
281 (Fcurrent_bidi_paragraph_direction): Fix search for previous
282 non-empty line. Fixes confusing cursor motion with arrow keys at
283 the beginning of a line that starts with whitespace.
8c203dbf 284
a4824228
LMI
2852011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
286
287 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
288 (bug#9493).
289
33ed493b
CY
2902011-09-18 Chong Yidong <cyd@stupidchicken.com>
291
292 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
293 boolean (Bug#9154).
294
56cd55c8
EZ
2952011-09-18 Eli Zaretskii <eliz@gnu.org>
296
297 * xdisp.c (display_line): Record maximum and minimum buffer
298 positions even if no glyphs were produced (e.g., by a zero-width
299 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
300 buffer positions that will be removed from the glyph row because
301 they don't fit.
c02dcedf
EZ
302 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
303 column is beyond frame width: don't subtract 1 "pixel" when
304 computing width of the stretch.
3e62b7e0
EZ
305 (reseat_at_next_visible_line_start): Undo the change made on
306 2011-09-17 that saved paragraph information and restored it after
307 the call to `reseat'. (Bug#9545)
56cd55c8 308
5ed99d36 3092011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
310
311 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
312 and turn window cursor on if cleared (Bug#9415).
313
5ed99d36 3142011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
315
316 * search.c (boyer_moore): Take unibyte characters from pattern
317 literally. (Bug#9458)
318
9bade7b2
EZ
3192011-09-18 Eli Zaretskii <eliz@gnu.org>
320
321 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
322
e5e9d610
PE
3232011-09-18 Paul Eggert <eggert@cs.ucla.edu>
324
87e4427a
PE
325 Fix minor problem found by static checking.
326 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
327 initialized, to pacify gcc -Wuninitialized.
328
e5e9d610
PE
329 * fileio.c: Report proper errno when syscall falls.
330 (Finsert_file_contents): Save and restore errno,
331 so that report_file_error outputs the correct diagnostic.
332 (Fwrite_region) [CLASH_DETECTION]: Likewise.
333
a1674f0b
EZ
3342011-09-18 Eli Zaretskii <eliz@gnu.org>
335
336 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
337
fbfb6dd4
EZ
3382011-09-17 Eli Zaretskii <eliz@gnu.org>
339
340 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
341 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
342
bb187662
EZ
3432011-09-17 Eli Zaretskii <eliz@gnu.org>
344
1137e8b8 345 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 346 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
347
348 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
349 (bidi_find_paragraph_start): Search back for paragraph beginning
350 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
351 (bidi_move_to_visually_next): Only trigger paragraph-related
352 computations when the last character is a newline or at EOB, not
353 just any NEUTRAL_B. (Bug#9470)
354
bb187662
EZ
355 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
356 truncated lines if point is covered by a display string. (Bug#9524)
357
2e621251
PE
3582011-09-16 Paul Eggert <eggert@cs.ucla.edu>
359
360 * xselect.c: Relax test for outgoing X longs (Bug#9498).
361 (cons_to_x_long): New function.
362 (lisp_data_to_selection_data): Use it. Correct the test for
363 short-versus-long data; it was negated. Break out of vector
364 loop, for efficiency, when a long datum is discovered.
365
91a15bc6
SM
3662011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
367
368 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
369
b41c3a35
EZ
3702011-09-16 Eli Zaretskii <eliz@gnu.org>
371
372 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
373 GCC PR/17406) by declaring this function with external scope.
374
7812ba2d
PE
3752011-09-15 Paul Eggert <eggert@cs.ucla.edu>
376
377 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
378 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
379
cf7edc2a
AS
3802011-09-15 Andreas Schwab <schwab@linux-m68k.org>
381
382 * editfns.c (Fformat): Correctly handle text properties on "%%".
383
bd01620e
EZ
3842011-09-15 Eli Zaretskii <eliz@gnu.org>
385
386 * xterm.c (x_draw_composite_glyph_string_foreground):
387 * w32term.c (x_draw_composite_glyph_string_foreground):
388 * term.c (encode_terminal_code):
389 * composite.c (composition_update_it, get_composition_id):
390 * xdisp.c (get_next_display_element)
391 (fill_composite_glyph_string): Add comments about special meaning
392 of TAB characters in a composition.
393
a02719a3
PE
3942011-09-15 Paul Eggert <eggert@cs.ucla.edu>
395
396 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
397 This occurs when processing a multibyte format.
398 Problem reported by Wolfgang Jenker.
a02719a3 399
72589a3c
JB
4002011-09-15 Johan Bockgård <bojohan@gnu.org>
401
402 * xdisp.c (try_cursor_movement): Only check for exact match if
403 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
404
1c14176c
PE
4052011-09-14 Paul Eggert <eggert@cs.ucla.edu>
406
407 Remove unused external symbols.
408 * dispextern.h (calc_pixel_width_or_height): Remove decl.
409 * xdisp.c (calc_pixel_width_or_height): Now static.
410 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
411 * indent.c (check_display_width):
412 * w32term.c: Fix comment to match code.
413 * xterm.c, xterm.h (x_catching_errors): Remove.
414
d2eea5b5
PE
4152011-09-14 Paul Eggert <eggert@cs.ucla.edu>
416
417 * xselect.c: Use signed conversions more consistently (Bug#9498).
418 (selection_data_to_lisp_data): Assume incoming selection data are
419 signed integers, not unsigned. This is to be consistent with
420 outgoing selection data, which was modified to use signed integers
421 in as part of the fix to Bug#9196 in response to Jan D.'s comment
422 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
423 expects long, not unsigned long.
424
46888499
EZ
4252011-09-14 Eli Zaretskii <eliz@gnu.org>
426
427 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
428 computation of loop end. Reported by Johan Bockgård
429 <bojohan@gnu.org>.
430
ef8ef9fb
CY
4312011-09-13 Chong Yidong <cyd@stupidchicken.com>
432
433 * frame.c (Fother_visible_frames_p): Function deleted.
434
fa819fed
EZ
4352011-09-12 Eli Zaretskii <eliz@gnu.org>
436
437 * indent.c (compute_motion): Process display vector front to back
438 rather than the other way around. (Bug#2496)
439
2ba8e008
SM
4402011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
441
442 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
443
20f53c69
CY
4442011-09-11 Chong Yidong <cyd@stupidchicken.com>
445
446 * minibuf.c (Fread_from_minibuffer): Doc fix.
447
d562d7a4
EZ
4482011-09-11 Eli Zaretskii <eliz@gnu.org>
449
450 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
451 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
452
1c4d7f3d
LMI
4532011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
454
455 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
456 value for non-existent files.
457
b885bf36
EZ
4582011-09-11 Eli Zaretskii <eliz@gnu.org>
459
460 * fileio.c (Finsert_file_contents): If the file cannot be opened,
461 set its "size" to -1. This will set the modtime_size field of
462 the corresponding buffer to -1, which is what
463 verify-visited-file-modtime expects for files that do not exist.
464 (Bug#9139)
465
6612f0bf
PE
4662011-09-11 Paul Eggert <eggert@cs.ucla.edu>
467
468 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
469 here ...
470 * lisp.h: ... from here. push_key_description is no longer
471 defined in keyboard.c, so its declaration should not be in
472 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
473 logically belongs with push_key_description.
474
dfb3f755
PE
4752011-09-10 Paul Eggert <eggert@cs.ucla.edu>
476
477 * buffer.h: Include <sys/types.h> instead of <time.h>.
478 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
479 Problem reported by Herbert J. Skuhra.
480
3134906c
LMI
4812011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
482
483 * xml.c (parse_region): Make the parsing work for
484 non-comment-starting XML files again (bug#9144).
485
8d903f4e
AS
4862011-09-10 Andreas Schwab <schwab@linux-m68k.org>
487
488 * image.c (gif_load): Fix calculation of bottom and right corner.
489 (Bug#9468)
490
80ad64f4
EZ
4912011-09-10 Eli Zaretskii <eliz@gnu.org>
492
493 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
494 redisplay in small windows.
495
208a048d
EZ
4962011-09-09 Eli Zaretskii <eliz@gnu.org>
497
498 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
499
9b1c252e
MR
5002011-09-08 Martin Rudalics <rudalics@gmx.at>
501
502 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
503 Operate on live windows only.
504
2949f33b
JB
5052011-09-08 Juanma Barranquero <lekktu@gmail.com>
506
507 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
508
e08dcafd
EZ
5092011-09-07 Eli Zaretskii <eliz@gnu.org>
510
511 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
512 only under bidi iteration.
513
115b96bd
JD
5142011-09-07 Jan Djärv <jan.h.d@swipnet.se>
515
516 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
517
c8199d0f
PE
5182011-09-06 Paul Eggert <eggert@cs.ucla.edu>
519
520 isnan: Fix porting problem to Solaris 10 with bundled gcc.
521 Without this fix, the command to link temacs failed due to an
522 undefined symbol __builtin_isnan. This is because
523 /usr/include/iso/math_c99.h #defines isnan(x) to
524 __builtin_isnan(x), but the bundled gcc, which identifies itself
525 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
526 a __builtin_isnan.
527 * floatfns.c (isnan): #undef, and then #define to a clone of
528 what's in data.c.
529 (Fisnan): Always define, since it's always available now.
530 (syms_of_floatfns): Always define isnan at the Lisp level.
531
e39b275c 5322011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
533
534 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
535
b2db44d9 5362011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 537
f4af5137 538 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
539 The previous code assumed that file offsets (off_t values) fit in
540 EMACS_INT variables, which is not true on typical 32-bit hosts.
541 The code messed up by falsely reporting buffer overflow in cases
542 such as (insert-file-contents "big" nil 1 2) into an empty buffer
543 when "big" contains more than 2**29 bytes, even though this
544 inserts just one byte and does not overflow the buffer.
545 (Finsert_file_contents): Store file offsets as off_t
546 values, not as EMACS_INT values. Check for overflow when
547 converting between EMACS_INT and off_t. When checking for
548 buffer overflow or for overlap, take the offsets into account.
549 Don't use EMACS_INT for small values where int suffices.
550 When checking for overlap, fix a typo: ZV was used where
551 ZV_BYTE was intended.
552 (Fwrite_region): Don't assume off_t fits into 'long'.
553 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
554
ecfc0a49
MA
5552011-09-05 Michael Albinus <michael.albinus@gmx.de>
556
557 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
558
6511acf2 5592011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 560
0999621a 561 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
562
563 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 564 (esprintf, exprintf, evxprintf): New functions.
62f19c19 565 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 566 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
567 (modify_event_symbol): Do not assume that the length of
568 name_alist_or_stem is safe to alloca and fits in int.
569 (Fexecute_extended_command): Likewise for function name and binding.
570 (Frecursion_depth): Wrap around reliably on integer overflow.
571 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
572 since some callers pass EMACS_INT values.
573 (Fsingle_key_description): Don't crash if symbol name contains more
574 than MAX_ALLOCA bytes.
575 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
576 (get_minibuffer): Arg is now EMACS_INT, not int.
577 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 578 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
579 * window.h (command_loop_level, minibuf_level): Reflect API changes.
580
2be7d702
PE
581 * dbusbind.c (signature_cat): New function.
582 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
583 Do not overrun buffer; instead, report string overflow.
584
9d1df220
PE
585 * dispnew.c (add_window_display_history): Don't overrun buffer.
586 Truncate instead; this is OK since it's just a log.
587
33ef5c64
PE
588 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
589 even if the time zone offset is outlandishly large.
590 Don't mishandle offset == INT_MIN.
591
66c6fdd5
PE
592 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
593 when creating daemon; the previous buffer-overflow check was incorrect.
594
d749b01b
PE
595 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
596 which has the guts of the old verror function.
597
b5cd1905
PE
598 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
599 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
600
6e1a67fb
PE
601 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
602 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 603 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 604 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
605 length of string rather than counting it via multiple sprintfs;
606 that's simpler and more reliable.
c21721cc
PE
607 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
608 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
609 sprintf, in case result does not fit in int.
610
c57b67fc
PE
611 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
612 (fontset_from_font): Print it.
613
8a401434
PE
614 * frame.c (tty_frame_count): Now printmax_t, not int.
615 (make_terminal_frame, set_term_frame_name): Print it.
616 (x_report_frame_params): In X, window IDs are unsigned long,
617 not signed long, so print them as unsigned.
618 (validate_x_resource_name): Check for implausibly long names,
619 and don't assume name length fits in 'int'.
620 (x_get_resource_string): Don't blindly alloca invocation name;
621 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
622 not fit in int.
623
6e1a67fb
PE
624 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
625 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
626 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
627
0df02bf3
PE
628 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
629 Use esprintf, not sprintf, in case result does not fit in int.
630
48e30793
PE
631 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
632 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
633 it as a large positive number.
634 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
635 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
636
a66ff6d8
PE
637 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
638 in case result does not fit in int.
639
aca216ff
PE
640 * print.c (float_to_string): Detect width overflow more reliably.
641 (print_object): Make sprintf buffer a bit bigger, to avoid potential
642 buffer overrun. Don't assume list length fits in 'int'. Treat
643 print length of 0 as 0, not as infinity; to be consistent with other
644 uses of print length in this function. Don't overflow print length
645 index. Don't assume hash table size fits in 'long', or that
646 vectorlike size fits in 'unsigned long'.
647
31c286f7
PE
648 * process.c (make_process): Use printmax_t, not int, to format
649 process-name gensyms.
650
55e5faa1
PE
651 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
652
80f2e268
PE
653 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
654 to avoid potential buffer overrun.
655
670741ab
PE
656 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
657 if X resource line is longer than 512 bytes.
658
b7163a50
PE
659 * xfns.c (x_window): Make sprintf buffer a bit bigger
660 to avoid potential buffer overrun.
661
ae58ff1f
PE
662 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
663
c43c8a6a
PE
664 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
665
3f8236f4
PE
6662011-09-04 Paul Eggert <eggert@cs.ucla.edu>
667
53e9fe90 668 Integer overflow fixes for scrolling, etc.
6511acf2
PE
669 Without these, Emacs silently mishandles large integers sometimes.
670 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
671 it were "C-u 1 M-x recenter" on a typical 64-bit host.
672
6511acf2
PE
673 * xdisp.c (try_window_id): Check Emacs fixnum range before
674 converting to 'int'.
806add1d 675
6511acf2 676 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
677 Check that an Emacs fixnum is in range before assigning it to 'int'.
678 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
679 values converted from Emacs fixnums.
680 (Frecenter): Don't wrap around a line count if it is out of 'int'
681 range; instead, treat it as an extreme value.
682 (Fset_window_configuration, compare_window_configurations):
683 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
684
6511acf2
PE
685 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
686 that can exceed INT_MAX. Check that EMACS_INT value is in range
687 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
688 (match_limit): Don't assume that a fixnum can fit in 'int'.
689
6511acf2 690 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
691 exceed INT_MAX.
692
6511acf2 693 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
694 (Fvertical_motion): Don't wrap around LINES values that don't fit
695 in 'int'. Instead, treat them as extreme values. This is good
696 enough for windows, which can't have more than INT_MAX lines anyway.
697
fcb901a7
LMI
6982011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
699
0f2f6b6d
LMI
700 * Require libxml/parser.h to avoid compilation warning.
701
fcb901a7
LMI
702 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
703
704 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
705 since this reportedly can destroy thread storage.
706
6e20a0d4
CY
7072011-08-30 Chong Yidong <cyd@stupidchicken.com>
708
709 * syntax.c (find_defun_start): Update all cache variables if
710 exiting early (Bug#9401).
711
148ae00e
EZ
7122011-08-30 Eli Zaretskii <eliz@gnu.org>
713
f6cfbd8f
EZ
714 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
715
148ae00e
EZ
716 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
717 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
718 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
719
720 * term.c (tty_append_glyph): New function.
721 (produce_stretch_glyph): Static function and its prototype deleted.
722
a66cfb1c
SM
723 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
724 Add prototypes.
148ae00e 725
c4a07a4c
PE
7262011-08-29 Paul Eggert <eggert@cs.ucla.edu>
727
728 * image.c (parse_image_spec): Check for nonnegative, not for positive,
729 when checking :margin (Bug#9390).
730 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 731 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
732 so that the name doesn't mislead. All uses changed.
733
6bc8cd65
JB
7342011-08-28 Johan Bockgård <bojohan@gnu.org>
735
736 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
737 set_tty_hooks.
738
dca4927e
EZ
7392011-08-27 Eli Zaretskii <eliz@gnu.org>
740
741 * xdisp.c (move_it_to): Don't bail out early when reaching
742 position beyond to_charpos, if we are scanning backwards.
743 (move_it_vertically_backward): When DY == 0, make sure we get to
744 the first character in the line after the newline.
745
f2cad773
PE
7462011-08-27 Paul Eggert <eggert@cs.ucla.edu>
747
748 * ccl.c: Improve and simplify overflow checking (Bug#9196).
749 (ccl_driver): Do not generate an out-of-range pointer.
750 (Fccl_execute_on_string): Remove unnecessary check for
751 integer overflow, noted by Stefan Monnier in
752 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
753 Remove a FIXME that didn't need fixing.
754 Simplify the newly-introduced buffer reallocation code.
755
0cae2cdb
JB
7562011-08-27 Juanma Barranquero <lekktu@gmail.com>
757
758 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
759
5fc295a4 7602011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 761
70c60eb2 762 Integer and memory overflow issues (Bug#9196).
726e0ab1 763
d31850da
PE
764 * doc.c (get_doc_string): Rework so that
765 get_doc_string_buffer_size is the actual buffer size, rather than
766 being 1 less than the actual buffer size; this makes xpalloc more
767 convenient.
768
a69fbedb
PE
769 * image.c (x_allocate_bitmap_record, cache_image):
770 * xselect.c (Fx_register_dnd_atom):
771 Simplify previous changes by using xpalloc.
772
fe5c5d37
PE
773 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
774 since either will do and ptrdiff_t is convenient with xpalloc.
775
0065d054
PE
776 * charset.c (charset_table_size)
777 (struct charset_sort_data.priority): Now ptrdiff_t.
778 (charset_compare): Don't overflow if priorities differ greatly.
779 (Fsort_charsets): Don't assume list length fits in int.
780 Check for size-calculation overflow when allocating sort data.
781 (syms_of_charset): Allocate an initial charset table that is
782 just under 64 KiB, to avoid problems with glibc malloc and mmap.
783
784 * cmds.c (internal_self_insert): Check for size-calculation overflow.
785
786 * composite.h (struct composition.glyph_len): Now int, not unsigned.
787 The actual value is always <= INT_MAX, and leaving it unsigned made
788 overflow checking harder.
789
790 * dispextern.h (struct glyph_matrix.rows_allocated)
791 (struct face_cache.size): Now ptrdiff_t, for convenience in use
792 with xpalloc. The values are still always <= INT_MAX.
793
794 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
795
796 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
797 (SAFE_NALLOCA): New macro.
798
799 * region-cache.c (struct boundary.pos, find_cache_boundary)
800 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
801 (set_cache_region, invalidate_region_cache)
802 (revalidate_region_cache, know_region_cache, region_cache_forward)
803 (region_cache_backward, pp_cache):
804 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
805 so that ptrdiff_t * can be passed to xpalloc.
806 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
807 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
808 (pp_cache): Don't assume cache_len fits in int.
809 * region-cache.h: Adjust extern decls to match.
810
811 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
812 EMACS_INT, since either will do, for xpalloc.
813
814 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
815 (xnmalloc, xnrealloc, xpalloc): New functions.
816
726e0ab1
PE
817 * bidi.c (bidi_shelve_header_size): New constant.
818 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
819 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
820
51f30bc5 821 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
822 * buffer.c (overlays_at, overlays_in, record_overlay_string)
823 (overlay_strings):
824 Don't update size of array until after memory allocation succeeds,
825 because xmalloc/xrealloc may not return.
0065d054
PE
826 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
827 now that we have proper integer overflow checking.
828 (record_overlay_string, overlay_strings): Catch overflows when
829 calculating size of overlay_str_buf.
726e0ab1 830
0065d054
PE
831 * callproc.c (Fcall_process): Check for size overflow when
832 calculating size of args2.
833 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
834 Normally we prefer signed values, but sticking with ptrdiff_t would
835 require adding more-complicated checks.
726e0ab1
PE
836
837 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
838 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
839 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 840 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
841
842 * character.c (Fstring): Check for size-calculation overflow.
843
844 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
845 unnecessary integer overflow. Check for size overflow.
846 (encode_coding_object): Don't update size until xmalloc succeeds.
847
848 * composite.c (get_composition_id): Check for overflow in glyph
849 length calculations.
850
851 Integer and memory overflow fixes for display code.
852 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
853 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
854 (scrolling_window): Check for overflow in size calculations.
855 (line_draw_cost, realloc_glyph_pool, add_row_entry):
856 Don't assume glyph table len fits in int.
857 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
858 (row_table_size): Now ptrdiff_t, not int.
859 (scrolling_window): Avoid overflow in size calculations.
860 Don't update size until allocation succeeds.
861 * fns.c (concat): Check for overflow in size calculations.
862 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
863 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
864 (NEXT_ALMOST_PRIME_LIMIT): New constant.
865
866 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
867 (get_doc_string): Check for size calculation overflow.
868 Don't update size until allocation succeeds.
869 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
870 EMACS_INT, where ptrdiff_t will do.
871 (Fsubstitute_command_keys): Check for string overflow.
872
873 * editfns.c (set_time_zone_rule): Don't assume environment length
874 fits in int.
875 (message_length): Now ptrdiff_t, not int.
876 (Fmessage_box): Don't update size until allocation succeeds.
877 Don't assume message length fits in int.
878 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
879
0065d054
PE
880 * emacs.c (main): Do not reallocate argv, since there is a null at
881 the end that can be overwritten, and this way there's no need to
882 worry about size-calculation overflow.
883 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
884
885 * eval.c (init_eval_once, grow_specpdl): Don't update size until
886 alloc succeeds.
887 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
888
889 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
890 (x_set_scroll_bar_width, x_figure_window_size):
891 Check for integer overflow.
892 (x_set_alpha): Do not assume XINT fits in int.
893
894 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
895 This is for the members text_lines, text_cols, total_lines, total_cols,
896 where the system imposes an 'int' limit.
897
898 * fringe.c (Fdefine_fringe_bitmap):
899 Don't update size until alloc works.
900
901 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
902 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
903
904 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
905 Check for size-calculation overflow.
906 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
907 do, as we prefer signed integers.
908 (id_to_widget.max_size, id_to_widget.used)
909 (xg_store_widget_in_map, xg_remove_widget_from_map)
910 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
911 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
912 Use and return ptrdiff_t, not int.
913 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
914 * gtkutil.h: Change prototypes to match the above.
915
916 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
917 are duplicate now that they've been promoted to lisp.h.
918 (x_allocate_bitmap_record, x_alloc_image_color)
919 (make_image_cache, cache_image, xpm_load):
920 Don't update size until alloc is done.
921 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
922 (x_detect_edges):
3256efce 923 Check for size calculation overflow.
726e0ab1
PE
924 (ct_colors_allocated_max): New constant.
925 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
926 overflow.
3256efce 927
726e0ab1
PE
928 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
929 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
930 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
931 Use ptrdiff_t, not int, to count maps.
932 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
933 calculations. Don't update size until allocation succeeds.
934 Redo calculations to avoid overflow.
726e0ab1
PE
935 * keyboard.h: Change prototypes to match the above.
936
937 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
938 to count maps.
939 (current_minor_maps): Check for size calculation overflow.
940 * keymap.h: Change prototypes to match the above.
941
942 * lread.c (read1, init_obarray): Don't update size until alloc done.
943
944 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
945 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
946
726e0ab1
PE
947 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
948 Now ptrdiff_t, not int.
949 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
950 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
951
952 * process.c (Fnetwork_interface_list): Check for overflow
953 in size calculation.
954
955 * region-cache.c (move_cache_gap): Check for size calculation overflow.
956
957 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
958 overflow. Don't bother calling xmalloc when xrealloc will do.
959
960 * search.c (Freplace_match): Check for size calculation overflow.
961 (Fset_match_data): Don't assume list lengths fit in 'int'.
962
963 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
964 for command line length. Do not attempt to address one before the
965 beginning of an array, as that's not portable.
966
967 * term.c (max_frame_lines): Remove; unused.
968 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
969 not int.
970 (encode_terminal_code, calculate_costs): Check for size
971 calculation overflow.
972 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
973 table lengths and related sizes. Don't update size until alloc
974 done. Redo calculations to avoid overflow.
975 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
976
977 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
978 subtracting pointers.
979 (gobble_line): Check for overflow more carefully. Don't update size
980 until alloc done.
981
982 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
983 Don't update size until alloc done.
984 Redo size calculations to avoid overflow.
985 Check for size calculation overflow.
0065d054 986 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
987
988 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
989 Use ptrdiff_t, not int, for sizes.
990 (store_mode_line_noprop_char): Don't update size until alloc done.
991
0065d054
PE
992 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
993 Use ptrdiff_t, not int, for sizes.
994 (Finternal_make_lisp_face, cache_face):
995 Check for size calculation overflow.
996 (cache_face): Treat size calculation overflows as if they were
997 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
998
999 * xfns.c (x_encode_text, x_set_name_internal)
1000 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1001 sizes, since they can exceed INT_MAX in size. Check for size
1002 calculation overflow.
1003
0065d054
PE
1004 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1005 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1006 Don't update size until alloc done.
1007
0065d054 1008 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1009 as sprintf is limited to int lengths.
1d526e2f 1010
252c5ee1
PE
1011 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1012 (X_LONG_MIN): New macros.
864d7ce7
PE
1013 Use them to make the following changes clearer.
1014 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1015 This change doesn't affect the value now, but it may help remind
1016 future maintainers not to raise the value too much later.
1017 (SELECTION_QUANTUM): Remove, replacing with ...
1018 (selection_quantum): ... new function, which avoids overflow.
1019 All uses changed.
1020 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1021 assumption that selection length fits in 'int'.
1022 (x_reply_selection_request, x_handle_selection_request)
1023 (x_get_window_property, receive_incremental_selection)
1024 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1025 (lisp_data_to_selection_data, clean_local_selection_data):
1026 Use ptrdiff_t, not int, to record length of selection.
1027 (x_reply_selection_request, x_get_window_property)
1028 (receive_incremental_selection, x_property_data_to_lisp):
1029 Redo calculations to avoid overflow.
1030 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1031 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1032 something.
1033 (x_get_window_property, receive_incremental_selection)
1034 (lisp_data_to_selection_data, x_property_data_to_lisp):
1035 Check for size-calculation overflow.
1036 (x_get_window_property, receive_incremental_selection)
1037 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1038 Don't store size until memory allocation succeeds.
1039 (x_get_window_property): Plug memory leak on memory exhaustion.
1040 Don't double-block input; malloc is safe here. Don't assume 2**34
1041 - 4 fits in unsigned long. Add an xassert to check
1042 XGetWindowProperty overflow. Be more careful about overflow
1043 calculations, and distinguish size from memory overflow better.
1044 (receive_incremental_selection): When tracing, don't assume
1045 unsigned int is less than INT_MAX.
1046 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1047 harmful) conversions of unsigned short to int.
1048 (lisp_data_to_selection_data): Don't assume that integers
1049 in the range -65535 through -1 fit in an X unsigned short.
1050 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1051 result parameters unless successful. Rely on cons_to_unsigned
1052 to report problems with elements; the old code wasn't right anyway.
1053 (x_check_property_data): Check for int overflow; we cannot use
1054 a wider type due to X limits.
1055 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1056
726e0ab1 1057 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1058
0065d054
PE
1059 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1060 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1061 (x_color_cells): Don't store size until memory allocation succeeds.
1062 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1063 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1064 (x_term_init): Don't assume length fits in int (sprintf is limited
1065 to int size).
bc18e09d 1066
ebfa62c0
PE
1067 Use ptrdiff_t for composition IDs.
1068 * character.c (lisp_string_width):
1069 * composite.c (composition_table_size, n_compositions)
1070 (get_composition_id, composition_gstring_from_id):
1071 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1072 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1073 * window.c (Frecenter):
1074 Use ptrdiff_t, not int, for composition IDs.
1075 * composite.c (get_composition_id): Check for integer overflow.
1076 * composite.h: Adjust prototypes to match the above changes.
1077
d3411f89
PE
1078 Use ptrdiff_t for hash table indexes.
1079 * category.c (hash_get_category_set):
1080 * ccl.c (ccl_driver):
1081 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1082 * coding.c (coding_system_charset_list, detect_coding_system):
1083 * coding.h (struct coding_system.id):
1084 * composite.c (get_composition_id, gstring_lookup_cache):
1085 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1086 * image.c (xpm_get_color_table_h):
1087 * lisp.h (hash_lookup, hash_put):
1088 * minibuf.c (Ftest_completion):
1089 Use ptrdiff_t for hash table indexes, not int (which is too
1090 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1091 32-bit --with-wide-int hosts).
1092
e097a6fa
PE
1093 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1094 Add a FIXME comment about memory leaks.
1095 (syms_of_charset): Don't assume xmalloc returns.
1096
5637687f
PE
1097 Don't assume that stated character widths fit in int.
1098 * character.c (Fchar_width, c_string_width, lisp_string_width):
1099 * character.h (CHAR_WIDTH):
1100 * indent.c (MULTIBYTE_BYTES_WIDTH):
1101 Use sanitize_char_width to avoid undefined and/or bad behavior
1102 with outlandish widths.
a66cfb1c 1103 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1104 now that we have two such functions. All uses changed.
1105 (sanitize_char_width): New inline function.
1106
a2271ba2
PE
1107 Don't assume that tab-width fits in int.
1108 * character.h (sanitize_width): New inline function.
1109 (SANE_TAB_WIDTH): New macro.
1110 (ASCII_CHAR_WIDTH): Use it.
1111 * indent.c (sane_tab_width): Remove. All uses replaced by
1112 SANE_TAB_WIDTH (current_buffer).
1113 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1114
18c52557
PE
1115 * fileio.c: Integer overflow issues with file modes.
1116 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1117
caeeedc1
PE
1118 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1119 Remove unreachable code.
1120 (read_hex, load_charset_map_from_file): Check for integer overflow.
1121
50849c52
PE
1122 * xterm.c: don't go over XClientMessageEvent limit
1123 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1124 (x_send_scroll_bar_event): Likewise. Check that the size does not
1125 exceed limits imposed by XClientMessageEvent, as well as the usual
1126 ptrdiff_t and size_t limits.
1127
b13995db
PE
1128 * keyboard.c: Overflow, signedness and related fixes.
1129 (make_lispy_movement): Use same integer type in forward decl
1130 that is used in the definition.
1131 (read_key_sequence, keyremap_step):
1132 Change bufsize argument back to int, undoing my 2011-03-30 change.
1133 We prefer signed types, and int is wide enough here.
1134 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1135 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1136 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1137 length, not size_t. Use ptrdiff_t for index, not int.
1138 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1139 possibility of integer overflow.
1140
13464394
PE
1141 Overflow, signedness and related fixes for images.
1142
1143 * dispextern.h (struct it.stack[0].u.image.image_id)
1144 (struct_it.image_id, struct image.id, struct image_cache.size)
1145 (struct image_cache.used, struct image_cache.ref_count):
1146 * gtkutil.c (update_frame_tool_bar):
1147 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1148 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1149 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1150 * nsmenu.m (update_frame_tool_bar):
1151 * xdisp.c (calc_pixel_width_or_height):
1152 * xfns.c (image_cache_refcount):
1153 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1154 on typical 64-bit hosts.
1155
1156 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1157 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1158 Omit unnecessary casts to int.
1159 (parse_image_spec): Check that integers fall into 'int' range
1160 when the callers expect that.
1161 (image_ascent): Redo ascent calculation to avoid int overflow.
1162 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1163 (lookup_image): Remove unnecessary tests.
1164 (xbm_image_p): Locals are now of int, not EMACS_INT,
1165 since parse_image_check makes sure they fit into int.
1166 (png_load, gif_load, svg_load_image):
1167 Prefer int to unsigned where either will do.
1168 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1169 old tiff_error_handler and tiff_warning_handler.
1170 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1171 stack buffer overflows. It uses only the features of vsnprintf
1172 that are common to both POSIX and native Microsoft.
1173 (tiff_error_handler, tiff_warning_handler): Use it.
1174 (tiff_load, gif_load, imagemagick_load_image):
1175 Don't assume :index value fits in 'int'.
1176 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1177 (imagemagick_load_image): Check that crop parameters fit into
1178 the integer types that MagickCropImage accepts. Don't assume
1179 Vimagemagick_render_type has a nonnegative value. Don't assume
1180 size_t fits in 'long'.
1181 (gs_load): Use printmax_t to print the widest integers possible.
1182 Check for integer overflow when computing image height and width.
1183
c11821d4
EZ
11842011-08-26 Eli Zaretskii <eliz@gnu.org>
1185
1186 * xdisp.c (redisplay_window): Don't force window start if point
1187 will be invisible in the resulting window. (Bug#9324)
1188
0c95fcf7
EZ
11892011-08-25 Eli Zaretskii <eliz@gnu.org>
1190
1191 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1192 the display spec is of the form `(space ...)'.
1193 (handle_display_spec): Return the value returned by
1194 handle_single_display_spec, not just 1 or zero.
1195 (handle_single_display_spec): If the display spec is of the form
1196 `(space ...)', and specifies display in the text area, return 2
1197 rather than 1.
fee65a97 1198 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1199 accurately, and prefer exact match for point under bidi.
1200 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1201
1202 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1203 into disp_prop; all users changed.
1204
1205 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1206 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1207 for the text covered by the display property.
1208
e4ed06f1
CY
12092011-08-25 Chong Yidong <cyd@stupidchicken.com>
1210
1211 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1212 Change return value to nil.
1213 (Frecord_buffer): Delete unused function.
1214
f67cdd7f
EZ
12152011-08-24 Eli Zaretskii <eliz@gnu.org>
1216
5980d4c6
EZ
1217 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1218 buffers, return left-to-right.
8610fe8b
EZ
1219 (set_cursor_from_row): Consider candidate row a win if its glyph
1220 represents a newline and point is on that newline. Fixes cursor
1221 positioning on the newline at EOL of R2L text within L2R
1222 paragraph, and vice versa.
1223 (try_cursor_movement): Check continued rows, in addition to
1224 continuation rows. Fixes unwarranted scroll when point enters a
1225 continued line of R2L text within an L2R paragraph, or vice versa.
1226 (cursor_row_p): Consider the case of point being equal to
1227 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1228 from the end of a short line to the beginning of a continued line
1229 of R2L text within L2R paragraph.
1230 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1231 composed characters.
5980d4c6 1232
f67cdd7f
EZ
1233 * bidi.c (bidi_check_type): Use xassert.
1234 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1235 members.
1236
bca633fb
EZ
12372011-08-23 Eli Zaretskii <eliz@gnu.org>
1238
1239 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1240 a character.
1241
4a5885a7
CY
12422011-08-23 Chong Yidong <cyd@stupidchicken.com>
1243
1244 * nsfont.m (ns_otf_to_script): Fix typo.
1245
0902a04e
KH
12462011-08-22 Kenichi Handa <handa@m17n.org>
1247
1248 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1249 extra slot even if the purpose is char-code-property-table.
1250
1a2e6670
EZ
12512011-08-23 Eli Zaretskii <eliz@gnu.org>
1252
8ddde651
EZ
1253 * xdisp.c (redisplay_window): When computing centering_position,
1254 account for the height of the header line. (Bug#8874)
1255
425cc014
EZ
1256 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1257 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1258 candidate is selected by the mouse, and that candidate has a
1259 composed character under the mouse.
1260
1a2e6670
EZ
1261 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1262 coordinates reported by pos-visible-in-window-p for a composed
1263 character in column zero.
1264
8b76d6f8
SM
12652011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1266
1267 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1268
dac347dd
EZ
12692011-08-22 Eli Zaretskii <eliz@gnu.org>
1270
1271 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1272 consider it a hit if to_charpos is anywhere in the range of the
1273 composed buffer positions.
1274
e013fb34
CY
12752011-08-22 Chong Yidong <cyd@stupidchicken.com>
1276
1277 * image.c (gif_load): Don't assume that each subimage has the same
1278 dimensions as the base image. Handle disposal method that is
1279 "undefined" by the gif spec (Bug#9335).
1280
bd1ba3e8
CY
12812011-08-20 Chong Yidong <cyd@stupidchicken.com>
1282
1283 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1284 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1285
54a1215b
EZ
12862011-08-19 Eli Zaretskii <eliz@gnu.org>
1287
823564e5
EZ
1288 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1289 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1290 from an Org mode buffer to a Speedbar frame.
1291
54a1215b
EZ
1292 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1293 a composition, take its buffer position from IT->cmp_it.charpos.
1294 Fixes cursor positioning at the beginning of a line that begins
1295 with a composed character.
1296
9778ebcc
EZ
12972011-08-18 Eli Zaretskii <eliz@gnu.org>
1298
0be6ee06
EZ
1299 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1300 character bidirectional type, use STRONG_L instead. Fixes crashes
1301 in a buffer produced by `describe-categories'.
1302
9778ebcc
EZ
1303 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1304 members before the level stack, so they would be saved and
1305 restored when copying iterator state. Fixes incorrect reordering
1306 around TABs covered by display properties.
1307
156bffbe
AS
13082011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1309
6b02f655 1310 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1311
72ad093b
CY
13122011-08-17 Chong Yidong <cyd@stupidchicken.com>
1313
1314 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1315 (internal_condition_case_2, internal_condition_case_n):
1316 Remove unnecessary aborts (Bug#9081).
72ad093b 1317
35774242
EZ
13182011-08-17 Eli Zaretskii <eliz@gnu.org>
1319
1320 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1321 has no `load' handler, try opening the file locally. (Bug#9311)
1322
db76dd85
KB
13232011-08-16 Ken Brown <kbrown@cornell.edu>
1324
1325 * gmalloc.c: Expand comment.
1326
b215eee5
EZ
13272011-08-16 Eli Zaretskii <eliz@gnu.org>
1328
1329 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1330 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1331
a4579d33
KB
13322011-08-16 Ken Brown <kbrown@cornell.edu>
1333
1334 Fix memory allocation problems in Cygwin build (Bug#9273).
1335
1336 * unexcw.c ( __malloc_initialized): Declare external variable.
1337 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1338
8b76d6f8
SM
1339 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1340 New variables.
a4579d33
KB
1341 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1342 dumped emacs.
1343 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1344 in the static heap.
1345 [CYGWIN] (special_realloc): New function.
1346 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1347 requests to realloc storage in the static heap.
1348
3ebec551
PE
13492011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1350
1351 * bidi.c (bidi_initialize): Remove unused local.
1352
9fd8be00
EZ
13532011-08-15 Eli Zaretskii <eliz@gnu.org>
1354
6b02f655
SM
1355 * bidimirror.h:
1356 * biditype.h: Remove file.
1357 * makefile.w32-in ($(BLD)/bidi.$(O)):
1358 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1359
1360 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1361
1362 * chartab.c: Improve commentary for the uniprop_table API.
1363
32413314
EZ
1364 * bidi.c (bidi_paragraph_init): Support zero value of
1365 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1366 (bidi_initialize): Use uniprop_table instead of including
1367 biditype.h and bidimirror.h.
32413314 1368
9fd8be00
EZ
1369 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1370 coordinates of the iterator when restoring from ppos_it.
1371 (Bug#9296)
1372
5cf2b69b
KH
13732011-08-14 Kenichi Handa <handa@m17n.org>
1374
1375 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1376 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1377
daf17d00
EZ
13782011-08-14 Eli Zaretskii <eliz@gnu.org>
1379
1380 * xdisp.c (move_it_in_display_line_to): Don't invoke
1381 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1382 ppos_it. Fixes vertical cursor motion when line beginning is
1383 covered by an image. (Bug#9296)
1384
08e3161a
JD
13852011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1386
1387 * nsterm.h (ns_run_ascript): Declare.
1388 (NSAPP_DATA2_RUNASSCRIPT): Define.
1389
1390 * nsfns.m (as_script, as_result, as_status): New static variables.
1391 (ns_run_ascript): New function.
5e617bc2 1392 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1393 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1394 the event loop. Get status from as_status (Bug#7276).
1395
1396 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1397 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1398 the event loop (Bug#7276).
1399
a3720aa2
AS
14002011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1401
1402 * gnutls.c (QCgnutls_bootprop_priority)
1403 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1404 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1405 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1406 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1407 (QCgnutls_bootprop_verify_hostname_error)
1408 (QCgnutls_bootprop_callbacks_verify): Rename from
1409 Qgnutls_bootprop_..., all uses changed.
1410
1411 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1412 uses changed.
1413
0a0d27fb
PE
14142011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1415
19d5c50c
PE
1416 * xfaces.c (Qframe_set_background_mode): Now static.
1417 * dispextern.h (Qframe_set_background_mode): Remove decl.
1418
0a0d27fb
PE
1419 * process.c (Fnetwork_interface_info): Declare local only if needed.
1420
377538cb
JD
14212011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1422
1423 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1424 (Fnetwork_interface_list): Allocate in increments of bytes instead
1425 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1426 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1427 sockaddr.
1428 (struct ifflag_def): notrailers is smart on OSX.
1429 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1430 Get hardware address with getifaddrs if available.
1431
08fff70c
EZ
14322011-08-12 Eli Zaretskii <eliz@gnu.org>
1433
1434 * xdisp.c (iterate_out_of_display_property): xassert that
1435 IT->position is set to within IT->object's boundaries. Break from
1436 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1437 when IT->position is set up wrongly due to some bug.
1438 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1439 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1440 entry. Force push_it to save on the stack the current
1441 buffer/string position, to be restored by pop_it. Fix flags in
1442 the iterator structure wrt the object coming from a display
1443 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1444 properties. (Bug#9284)
1445
7be1c708 14462011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1447
7be1c708
CY
1448 * fontset.c (fontset_get_font_group): Add proper type checks.
1449 (Bug#9172)
aac0c6e3 1450
7be1c708 14512011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1452
7be1c708
CY
1453 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1454 and LC_VERSION_MIN_MACOSX.
1455 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1456 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1457
97bb72a6
EZ
14582011-08-08 Eli Zaretskii <eliz@gnu.org>
1459
1460 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1461 no-display-properties-and-no-overlays under bidi display.
1462 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1463 properties and overlays.
97bb72a6 1464
d5617611
CY
14652011-08-08 Chong Yidong <cyd@stupidchicken.com>
1466
37e11a63
CY
1467 * editfns.c (Fset_time_zone_rule): Document relationship with the
1468 setenv function.
1469
d5617611
CY
1470 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1471 the font entity extracted from the cache (Bug#8109).
1472
58872834
CY
14732011-08-07 Chong Yidong <cyd@stupidchicken.com>
1474
1475 * composite.c (autocmp_chars): Don't reset point. That is done by
1476 restore_point_unwind (Bug#5984).
1477
75bfc667
JL
14782011-08-07 Juri Linkov <juri@jurta.org>
1479
1480 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1481 to show the arg `TIME' instead of `TIMEVAL'.
1482
d1410150
EZ
14832011-08-06 Eli Zaretskii <eliz@gnu.org>
1484
1485 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1486 display property strides EOL and includes a newline, as in
1487 longlines-mode. (Bug#9254)
75b771e4
EZ
1488 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1489 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1490
1491 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1492 is non-zero, even if the data buffer is NULL. Fixes a crash in
1493 vertical-motion with longlines-mode. (Bug#9254)
1494
35928349
EZ
14952011-08-05 Eli Zaretskii <eliz@gnu.org>
1496
ec7cc85b
EZ
1497 * bidi.c <bidi_cache_total_alloc>: Now static.
1498 (bidi_initialize): Initialize bidi_cache_total_alloc.
1499
8b76d6f8 1500 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1501 cache. (Bug#9221)
1502
1503 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1504 amount allocated this far in `bidi_cache_total_alloc'.
1505 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1506 non-zero, only free the data buffer without restoring the cache
1507 contents. All callers changed.
1508
1509 * dispextern.h (bidi_unshelve_cache): Update prototype.
1510
1511 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1512 (move_it_in_display_line, move_it_to)
1513 (move_it_vertically_backward, move_it_by_lines): Replace the call
1514 to xfree to an equivalent call to bidi_unshelve_cache.
1515 (move_it_in_display_line_to): Fix logic of returning
412b6358 1516 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1517
e2e2423b
EZ
15182011-08-05 Eli Zaretskii <eliz@gnu.org>
1519
1520 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1521 came from a string character with a `cursor' property. (Bug#9229)
1522
ae9e757a
JD
15232011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1524
1525 * Makefile.in (LIB_PTHREAD): New variable.
1526 (LIBES): Add LIB_PTHREAD (Bug#9216).
1527
1528 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1529 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1530
213bd7f2
AS
15312011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1532
6b02f655 1533 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 1534
99aaf75f
JD
15352011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1536
1537 * xterm.c (x_find_topmost_parent): New function.
1538 (x_set_frame_alpha): Find topmost parent window with
1539 x_find_topmost_parent and set the property there also (bug#9181).
1540 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1541
c74e9d86
PE
15422011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1543
1544 * callproc.c (Fcall_process): Avoid vfork clobbering
1545 the local vars buffer, coding_systems, current_dir.
1546
640c8776
SM
15472011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1548
1549 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1550
f26d0e4c
PE
15512011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1552
8a10d76c
PE
1553 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1554 so that it is not optimized away.
1555
f26d0e4c
PE
1556 * xdisp.c (compute_display_string_pos): Remove unused local.
1557
55439c61
EZ
15582011-08-02 Eli Zaretskii <eliz@gnu.org>
1559
1560 Fix slow cursor motion and scrolling in large buffers with
1561 selective display, like Org Mode buffers. (Bug#9218)
1562
1563 * dispextern.h (struct bidi_it): New member disp_prop_p.
1564
1565 * xdisp.c: Remove one-slot cache of display string positions.
1566 (compute_display_string_pos): Accept an additional argument
5e617bc2 1567 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1568 for a display string or property. If found, set DISP_PROP_P
1569 non-zero.
1570
1571 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1572 DISP_PROP_P, and pass it to compute_display_string_pos.
1573 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1574 non-zero. All callers of bidi_fetch_char changed.
1575
fb33fa43
SM
15762011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1577
1578 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1579
b099e063
DM
15802010-12-03 Don March <don@ohspite.net>
1581
1582 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1583 last character M-[char] is translated to ESC [char] (bug#7541).
1584
5cc7f7af
KH
15852011-08-02 Kenichi Handa <handa@m17n.org>
1586
d0fffa3f 1587 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1588
1589 * chartab.c (uniprop_table): Make it non-static.
1590
525d5e6e
EZ
15912011-08-01 Eli Zaretskii <eliz@gnu.org>
1592
1593 * xdisp.c (forward_to_next_line_start): Accept additional argument
1594 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1595 on the newline.
1596 (reseat_at_next_visible_line_start): Use the bidi iterator state
1597 returned by forward_to_next_line_start to restore the state of
1598 it->bidi_it after backing up to previous newline. (Bug#9212)
1599
31011111
AS
16002011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1601
1602 * regex.c (re_comp): Protoize.
1603 (re_exec): Fix return type.
1604 (regexec): Fix type of `ret'. (Bug#9203)
1605
476371c4
PE
16062011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1607
e5d76069
PE
1608 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1609 This is needed if max-image-size is a floating-point number.
1610
9a79b20c
AS
16112011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1612
1613 * print.c (print_object): Print empty symbol as ##.
1614
1615 * lread.c (read1): Read ## as empty symbol.
1616
d8c2fa78
AA
16172011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1618
1619 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1620 setting frame foreground color (Bug#9175).
1621 (x_set_background_color): Likewise.
1622
ffe57a7a
AA
1623 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1624 contents (Bug#9176).
1625 (EmacsTooltip -init): Remove bezels and add shadows to
1626 tooltip windows.
1627
bf3492a5
AA
1628 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1629 or scroll bar (Bug#8470).
1630
d55e9c53
AA
1631 * nsfont.m (nsfont_open): Remove assignment to voffset and
1632 unnecessary vars hshink, expand, hd, full_height, min_height.
1633 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1634
1635 * nsterm.h (nsfont_info): Remove voffset field.
1636
d8c2fa78 16372011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1638
1639 Implement strike-through and overline on NextStep (Bug#8863).
1640
1641 * nsfont.m (nsfont_open): Use underline position provided by font,
1642 instead of hard-coded value of 2.
1643 (nsfont_draw): Call ns_draw_text_decoration instead.
1644
1645 * nsterm.h: Add declaration for ns_draw_text_decoration.
1646
1647 * nsterm.m (ns_draw_text_decoration): New function for drawing
1648 underline, overline, and strike-through.
1649 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1650 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1651 accommodate underlining, etc.
4843aac3 1652
4cc60b9b
EZ
16532011-07-28 Eli Zaretskii <eliz@gnu.org>
1654
bc7ece87
EZ
1655 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1656 default.
4cc60b9b 1657
476371c4
PE
16582011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1659
66606eea
PE
1660 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1661 Without this fix, if a signal arrives just after memory fills up,
1662 'malloc' might be invoked reentrantly.
1663
476371c4
PE
1664 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1665 In other words, assume that every image size is allowed, on non-X
1666 hosts. This assumption is probably wrong, but it lets Emacs compile.
1667
f3fcc40d
AS
16682011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1669
1670 * regex.c (re_iswctype): Convert return values to boolean.
1671
350c992f
EZ
16722011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1673
1674 * xdisp.c (compute_display_string_pos): Don't use cached display
1675 string position if the buffer had its restriction changed.
1676 (Bug#9184)
1677
5266b4bb
PE
16782011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1679
1680 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1681
2573a837 16822011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1683
41f55ccd 1684 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1685
39e378da
PE
1686 * bidi.c: Integer size and overflow fixes.
1687 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1688 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1689 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1690 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1691 (bidi_find_other_level_edge):
1692 Use ptrdiff_t instead of EMACS_INT where either will do.
1693 This works better on 32-bit hosts configured --with-wide-int.
1694 (bidi_cache_ensure_space): Check for size-calculation overflow.
1695 Use % rather than repeated addition, for better worst-case speed.
1696 Don't set bidi_cache_size until after xrealloc returns, because it
1697 might not return.
1698 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1699 (bidi_cache_ensure_space): Also check that the bidi cache size
1700 does not exceed that of the largest Lisp string or buffer. See Eli
1701 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1702
5e927815
PE
1703 * alloc.c (__malloc_size_t): Remove.
1704 All uses replaced by size_t. See Andreas Schwab's note
1705 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1706
ca4aa935
PE
1707 * image.c: Improve checking for integer overflow.
1708 (check_image_size): Assume that f is nonnull, since
1709 it is always nonnull in practice. This is one less thing to
1710 worry about when checking for integer overflow later.
1711 (x_check_image_size): New function, which checks for integer
1712 overflow issues inside X.
1713 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1714 This removes the need for a memory_full check.
1715 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1716 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1717 (xbm_read_bitmap_data): Change locals back to 'int', since
1718 their values must fit in 'int'.
1719 (xpm_load_image, png_load, tiff_load):
1720 Invoke x_create_x_image_and_pixmap earlier,
1721 to avoid much needless work if the image is too large.
1722 (tiff_load): Treat overly large images as if
1723 x_create_x_image_and_pixmap failed, not as malloc failures.
1724 (gs_load): Use x_check_image_size.
1725
5f8f9cc2
PE
1726 * gtkutil.c: Omit integer casts.
1727 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1728 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1729
5adf60bc
PE
1730 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1731
c8907a93
PE
1732 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1733 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1734 would wrongly return t on a 64-bit host.
1735
e3c25c68
PE
1736 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1737 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1738 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1739 and therefore cause GCC to emit a bogus diagnostic in some cases.
1740
3f791afe
PE
1741 * image.c: Integer signedness and overflow and related fixes.
1742 This is not an exhaustive set of fixes, but it's time to
1743 record what I've got.
1744 (lookup_pixel_color, check_image_size): Remove redundant decls.
1745 (check_image_size): Don't assume that arbitrary EMACS_INT values
1746 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1747 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1748 (tiff_load, imagemagick_load_image):
1749 Check for overflow in size calculations.
1750 (x_create_x_image_and_pixmap): Remove unnecessary test for
1751 xmalloc returning NULL; that can't happen.
1752 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1753 (xpm_color_bucket): Use better integer hashing function.
1754 (xpm_cache_color): Don't possibly over-allocate memory.
1755 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1756 (gif_memory_source):
1757 Use ptrdiff_t, not int or size_t, to record sizes.
1758 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1759 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1760 either works, as we prefer signed integers.
1761 (tiff_read_from_memory, tiff_write_from_memory):
1762 Return tsize_t, not size_t, since that's what the TIFF API wants.
1763 (tiff_read_from_memory): Don't fail simply because the read would
1764 go past EOF; instead, return a short read.
1765 (tiff_load): Omit no-longer-needed casts.
1766 (Fimagemagick_types): Don't assume size fits into 'int'.
1767
3cc5a532
PE
1768 Improve hashing quality when configured --with-wide-int.
1769 * fns.c (hash_string): New function, taken from sxhash_string.
1770 Do not discard information about ASCII character case; this
1771 discarding is no longer needed.
1772 (sxhash-string): Use it. Change sig to match it. Caller changed.
1773 * lisp.h: Declare it.
1774 * lread.c (hash_string): Remove, since we now use fns.c's version.
1775 The fns.c version returns a wider integer if --with-wide-int is
1776 specified, so this should help the quality of the hashing a bit.
1777
b312a492
PE
1778 * emacs.c: Integer overflow minor fix.
1779 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1780 Define only if GNU_LINUX.
1781 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1782
dfd153ae
PE
1783 * dispnew.c: Integer signedness and overflow fixes.
1784 Remove unnecessary forward decls, that were a maintenance hassle.
1785 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1786 All uses changed.
1787 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1788 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1789 (prepare_desired_row, line_draw_cost):
1790 Use int, not unsigned, where either works.
1791 (save_current_matrix, restore_current_matrix):
1792 Use ptrdiff_t, not size_t, where either works.
1793 (init_display): Check for overflow more accurately, and without
1794 relying on undefined behavior.
1795
a81d11a3
PE
1796 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1797 Remove, replacing with the new symbols in lisp.h. All uses changed.
1798 * fileio.c (make_temp_name):
1799 * filelock.c (lock_file_1, lock_file):
1800 * xdisp.c (message_dolog):
1801 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1802 Use pMd etc. instead.
1803 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1804 replacing the pWIDE etc. symbols removed from editfns.c.
1805
3300e6fd
PE
1806 * keyboard.h (num_input_events): Now uintmax_t.
1807 This is (very slightly) less likely to mess up due to wraparound.
1808 All uses changed.
1809
fd05c7e9
PE
1810 * buffer.c: Integer signedness fixes.
1811 (alloc_buffer_text, enlarge_buffer_text):
1812 Use ptrdiff_t rather than size_t when either will do, as we prefer
1813 signed integers.
1814
903fe15d
PE
1815 * alloc.c: Integer signedness and overflow fixes.
1816 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1817 (__malloc_size_t): Default to size_t, not to int.
1818 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1819 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1820 Prefer ptrdiff_t to size_t when either would do, as we prefer
1821 signed integers.
1822 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1823 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1824 Now const. Initialize with values that are in range even if char
1825 is signed.
1826 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1827 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1828 These functions do the right thing with sizes > 2**32.
1829 (check_depth): Now ptrdiff_t, not int.
1830 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1831 Adjust to new way of storing sizes. Check for size overflow bugs
1832 in rest of code.
1833 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1834 slightly wrong anyway, as it missed one instance of
1835 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1836 (refill_memory_reserve): Omit needless cast to size_t.
1837 (mark_object_loop_halt): Mark as externally visible.
1838
ac82cc6a
PE
1839 * xselect.c: Integer signedness and overflow fixes.
1840 (Fx_register_dnd_atom, x_handle_dnd_message):
1841 Use ptrdiff_t, not size_t, since we prefer signed.
1842 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1843 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1844 x_dnd_atoms_size and x_dnd_atoms_length.
1845
c2d1e36d
PE
1846 * doprnt.c: Prefer signed to unsigned when either works.
1847 * eval.c (verror):
1848 * doprnt.c (doprnt):
1849 * lisp.h (doprnt):
1850 * xdisp.c (vmessage):
1851 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1852 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1853 prefer signed arithmetic to avoid comparison confusion.
1854 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1855 but is a bit tricky.
1856
0e926e56
PE
1857 Assume freestanding C89 headers, string.h, stdlib.h.
1858 * data.c, doprnt.c, floatfns.c, print.c:
1859 Include float.h unconditionally.
1860 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1861 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1862 * regex.c: Likewise for stddef.h, string.h.
1863 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1864 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1865 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1866 (STDC_HEADERS): Remove obsolete defines.
1867 * sysdep.c: Include limits.h unconditionally.
1868
9cfdb3ec
PE
1869 Assume support for memcmp, memcpy, memmove, memset.
1870 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1871 * regex.c (memcmp, memcpy):
1872 Remove; we assume C89 now.
1873
1874 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1875 (__malloc_safe_bcopy): Remove; no longer needed.
1876
cf950e6b 1877 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1878 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1879 well either way, and we prefer signed to unsigned.
1880
dbf38e02
LMI
18812011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1882
1883 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1884 closes the connection while we're reading (bug#9182).
1885
d6f0886c 18862011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 1887
d6f0886c
JD
1888 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1889 are specified (Bug#9168).
24e0f6b1 1890
2eb1f9e6
PE
18912011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1892
1893 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1894 Found by GCC static checking and --with-wide-int on a 32-bit host.
1895
22381272 18962011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1897
1898 * xdisp.c (compute_display_string_pos): Fix logic of caching
1899 previous display string position. Initialize cached_prev_pos to
1900 -1. Fixes slow-down at the beginning of a buffer.
1901
f25e39b4
EZ
19022011-07-24 Eli Zaretskii <eliz@gnu.org>
1903
1904 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1905 for attrs[LFACE_FONTSET_INDEX].
1906
04c4b52e
PE
19072011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1908
1909 * xml.c (parse_region): Remove unused local
1910 that was recently introduced.
1911
c1734fbd
EZ
19122011-07-23 Eli Zaretskii <eliz@gnu.org>
1913
be18c5a5
EZ
1914 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1915 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1916
c1734fbd
EZ
1917 * xdisp.c (move_it_in_display_line_to): Record the best matching
1918 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1919 exit if none of the characters scanned was an exact match.
1920 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1921 when exact match is impossible due to invisible text, and the
1922 lines are truncated.
1923
a258d627
JD
19242011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1925
1926 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1927 for OSX >= 10.7.
1928
b6d5a689
EZ
19292011-07-22 Eli Zaretskii <eliz@gnu.org>
1930
0f74f785
EZ
1931 Fix a significant slow-down of cursor motion with C-n, C-p,
1932 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1933 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1934 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1935 (next_element_from_buffer): Call compute_stop_pos_backwards to
1936 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1937 base_level_stop.
1938 (reseat): Don't look for prev_stop, as that could mean a very long
1939 run.
1940 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1941 <cached_disp_overlay_modiff>: Cache for last found display string
1942 position.
551918c1 1943 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1944 about the same buffer in the same area of character positions, and
1945 the buffer wasn't changed since the time the display string
1946 position was cached.
551918c1 1947
b2d0c91a
EZ
19482011-07-22 Eli Zaretskii <eliz@gnu.org>
1949
1950 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1951 is an integer, which is important for empty lines. (Bug#9149)
1952
043604ee
CY
19532011-07-22 Chong Yidong <cyd@stupidchicken.com>
1954
1955 * frame.c (Fmodify_frame_parameters): In tty case, update the
1956 default face if necessary (Bug#4238).
1957
da4adb04
CY
19582011-07-21 Chong Yidong <cyd@stupidchicken.com>
1959
1960 * editfns.c (Fstring_to_char): No need to explain what a character
1961 is in the docstring (Bug#6576).
1962
9abd0532
LMI
19632011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1964
1965 * xml.c (parse_region): Make sure we always return a tree.
1966
36881d16
HK
19672011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1968
1969 * xml.c (parse_region): If a document contains only comments,
1970 return that, too.
1971
1e98674d
LMI
19722011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1973
1974 * xml.c (make_dom): Return comments, too.
1975
590bd467
PE
19762011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1977
1978 Port to OpenBSD.
1979 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1980 and the surrounding thread.
1981 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1982 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1983 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1984 timer goes off.
1985 * s/openbsd.h (BROKEN_SIGIO): Define.
1986 * unexelf.c (unexec) [__OpenBSD__]:
1987 Don't update the .mdebug section of the Alpha COFF symbol table.
1988
f41628b2
LMI
19892011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1990
1991 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1992 (bug#8460).
1993
b59b67c5
PE
19942011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1995
15e3a074
PE
1996 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1997 This fixes some race conditions on the permissions of any newly
1998 created file.
1999
41bed37d
PE
2000 * alloc.c (valid_pointer_p): Use pipe, not open.
2001 This fixes some permissions issues when debugging.
2002
b59b67c5
PE
2003 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2004 If fchown fails to set both uid and gid, try to set just gid,
2005 as that is sometimes allowed. Adjust the file's mode to eliminate
2006 setuid or setgid bits that are inappropriate if fchown fails.
2007
925a6be7
SM
20082011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2009
2010 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2011 to compare Lisp_Objects.
2012 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2013 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2014 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2015
52968808
AS
20162011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2017
0a6a104b
AS
2018 * lread.c (read_integer): Unread even EOF character.
2019 (read1): Likewise. Properly record start position of symbol.
2020
52968808
AS
2021 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2022 symbol character follows.
2023
9e381cdd
PE
20242011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2025
2026 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2027 This works around a problem with the previous change to Fcopy_file.
2028 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2029 and without this change, GCC might complain about discarding
2030 fchown's return value.
2031
b5641435
JB
20322011-07-16 Juanma Barranquero <lekktu@gmail.com>
2033
2034 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2035
a8031457
PE
20362011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2037
2038 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2039
dd889327
LMI
20402011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2041
750c33f7
LMI
2042 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2043 it's used from the C level.
2044
dd889327
LMI
2045 * process.c: Use the same condition for POLL_FOR_INPUT in both
2046 keyboard.c and process.c (bug#1858).
2047
87e86684
LM
20482011-07-09 Lawrence Mitchell <wence@gmx.li>
2049
2050 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2051 (Fgnutls_boot): Use it.
2052
64348f40
AS
20532011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2054
2055 * doc.c (Fsubstitute_command_keys): Revert last change.
2056
1d698799
LMI
20572011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2058
f863868c
LMI
2059 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2060 quotes the next character, and doesn't affect other longer
2061 sequences (bug#8935).
2062
1d698799
LMI
2063 * lread.c (syms_of_lread): Clarify that is isn't only
2064 `eval-buffer' and `eval-defun' that's affected by
2065 `lexical-binding' (bug#8460).
2066
aa4b6df6
EZ
20672011-07-15 Eli Zaretskii <eliz@gnu.org>
2068
2069 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2070 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2071
5d856da6
PE
20722011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2073
ad6042bb
PE
2074 Fix minor problems found by static checking.
2075 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2076 (elsz): Now a signed constant, not a size_t var. We prefer signed
2077 types to unsigned, to avoid integer comparison confusion. Without
2078 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2079 "cannot optimize loop, the loop counter may overflow", a symptom
2080 of the confusion.
f00bbb22 2081 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2082 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2083
6468f31c
LMI
20842011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2085
49080b10
LMI
2086 * search.c (Fre_search_backward): Mention `case-fold-search' in
2087 all the re_search_* functions (bug#8138).
2088
6468f31c
LMI
2089 * keyboard.c (Fopen_dribble_file): Document when the file is
2090 closed (bug#8056).
2091
c965adc5
EZ
20922011-07-14 Eli Zaretskii <eliz@gnu.org>
2093
df9733bf
EZ
2094 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2095 bidi_cache_idx.
2096
0bb23927
EZ
2097 Support bidi reordering of display and overlay strings.
2098 * xdisp.c (compute_display_string_pos)
2099 (compute_display_string_end): Accept additional argument STRING.
2100 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2101 (reseat_to_string): Initialize bidi_it->string.s and
2102 bidi_it->string.schars.
2103 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2104 NULL (avoids a crash in bidi_paragraph_init).
2105 Initialize itb.string.lstring.
0bb23927
EZ
2106 (init_iterator): Call bidi_init_it only of a valid
2107 buffer position was specified. Initialize paragraph_embedding to
2108 L2R.
2109 (reseat_to_string): Initialize the bidi iterator.
2110 (display_string): If we need to ignore text properties of
2111 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2112 original value of -1 will not work with bidi.)
2113 (compute_display_string_pos): First arg is now struct
2114 `text_pos *'; all callers changed. Support display properties on
2115 Lisp strings.
2116 (compute_display_string_end): Support display properties on Lisp
2117 strings.
2118 (init_iterator, reseat_1, reseat_to_string): Initialize the
2119 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2120 when iterating on a string not from display properties).
640c8776
SM
2121 (compute_display_string_pos, compute_display_string_end):
2122 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2123 arrow keys.
2124 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2125 base_level_stop; instead, set base_level_stop to BEGV.
2126 Fixes crashes in vertical-motion.
0bb23927
EZ
2127 (next_element_from_buffer): Improve commentary for when
2128 the iterator is before prev_stop.
2129 (init_iterator): Initialize bidi_p from the default value of
2130 bidi-display-reordering, not from buffer-local value. Use the
2131 buffer-local value only if initializing for buffer iteration.
2132 (handle_invisible_prop): Support invisible properties on strings
2133 that are being bidi-reordered.
2134 (set_iterator_to_next): Support bidi reordering of C strings and
2135 Lisp strings.
2136 (next_element_from_string): Support bidi reordering of Lisp
2137 strings.
2138 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2139 (display_string): Support display of R2L glyph rows.
2140 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2141 (init_iterator): Don't initialize it->bidi_p for strings
2142 here.
2143 (reseat_to_string): Initialize it->bidi_p for strings here.
2144 (next_element_from_string, next_element_from_c_string)
2145 (next_element_from_buffer): Add xassert's for correspondence
2146 between IT's object being iterated and it->bidi_it.string
2147 structure.
2148 (face_before_or_after_it_pos): Support bidi iteration.
2149 (next_element_from_c_string): Handle the case of the first string
2150 character that is not the first one in the visual order.
2151 (get_visually_first_element): New function, refactored from common
2152 parts of next_element_from_buffer, next_element_from_string, and
2153 next_element_from_c_string.
2154 (tool_bar_lines_needed, redisplay_tool_bar)
2155 (display_menu_bar): Force left-to-right direction. Add a FIXME
2156 comment for making that be controlled by a user option.
2157 (push_it, pop_it): Save and restore the state of the
2158 bidi iterator. Save and restore the bidi_p flag.
2159 (pop_it): Iterate out of display property for string iteration as
2160 well.
2161 (iterate_out_of_display_property): Support iteration over strings.
2162 (handle_single_display_spec): Set up it->bidi_it for iteration
2163 over a display string, and call bidi_init_it.
2164 (handle_single_display_spec, next_overlay_string)
2165 (get_overlay_strings_1, push_display_prop): Set up the bidi
2166 iterator for displaying display or overlay strings.
2167 (forward_to_next_line_start): Don't use the shortcut if
2168 bidi-iterating.
2169 (back_to_previous_visible_line_start): If handle_display_prop
2170 pushed the iterator stack, restore the internal state of the bidi
2171 iterator by calling bidi_pop_it same number of times.
2172 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2173 and we are bidi-iterating, don't decrement the iterator position;
2174 instead, set the first_elt flag in the bidi iterator, to produce
2175 the same effect.
2176 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2177 (push_display_prop): xassert that we are iterating a buffer.
2178 (push_it, pop_it): Save and restore paragraph_embedding member.
2179 (handle_single_display_spec, next_overlay_string)
2180 (get_overlay_strings_1, reseat_1, reseat_to_string)
2181 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2182 correctly. Don't assume unibyte strings are not bidi-reordered.
2183 (compute_display_string_pos)
2184 (compute_display_string_end): Fix handling the case of C string.
2185 (push_it, pop_it): Save and restore from_disp_prop_p.
2186 (handle_single_display_spec, push_display_prop): Set the
2187 from_disp_prop_p flag.
2188 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2189 (pop_it): Call iterate_out_of_display_property only if we are
2190 popping after iteration over a string that came from a display
2191 property. Fix a typo in popping stretch info. Add an assertion
2192 for verifying that the iterator position is in sync with the bidi
2193 iterator.
2194 (handle_single_display_spec, get_overlay_strings_1)
2195 (push_display_prop): Fix initialization of paragraph direction for
2196 string when that of the parent object is not yet determined.
2197 (reseat_1): Call bidi_init_it to resync the bidi
2198 iterator with IT's position. (Bug#7616)
2199 (find_row_edges): If ROW->start.pos gives position
2200 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2201 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2202 Reset the from_disp_prop_p flag.
2203 (SAVE_IT, RESTORE_IT): New macros.
2204 (pos_visible_p, face_before_or_after_it_pos)
2205 (back_to_previous_visible_line_start)
2206 (move_it_in_display_line_to, move_it_in_display_line)
2207 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2208 (try_scrolling, redisplay_window, display_line): Use them when
2209 saving a temporary copy of the iterator and restoring it back.
2210 (back_to_previous_visible_line_start, reseat_1)
2211 (init_iterator): Empty the bidi cache "stack".
2212 (move_it_in_display_line_to): If iterator ended up at
2213 EOL, but we never saw any buffer positions smaller than
2214 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2215 motion in bidi-reordered lines.
2216 (move_it_in_display_line_to): Record prev_method and prev_pos
2217 immediately before the call to set_iterator_to_next. Fixes cursor
2218 motion in bidi-reordered lines with stretch glyphs and strings
2219 displayed in margins. (Bug#8133) (Bug#8867)
2220 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2221 TO_CHARPOS.
640c8776
SM
2222 (pos_visible_p): Support positions in bidi-reordered lines.
2223 Save and restore bidi cache.
0bb23927
EZ
2224
2225 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2226 (bidi_paragraph_info): Delete unused struct.
2227 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2228 (bidi_cache_start): New variable.
2229 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2230 to zero.
2231 (bidi_cache_fetch_state, bidi_cache_search)
2232 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2233 (bidi_cache_find, bidi_peek_at_next_level)
2234 (bidi_level_of_next_char, bidi_find_other_level_edge)
2235 (bidi_move_to_visually_next): Compare cache index with
2236 bidi_cache_start rather than with zero.
2237 (bidi_fetch_char): Accept new argument STRING; all callers
2238 changed. Support iteration over a string. Support strings with
2239 display properties. Support unibyte strings. Fix the type of
2240 `len' according to what STRING_CHAR_AND_LENGTH expects.
2241 (bidi_paragraph_init, bidi_resolve_explicit_1)
2242 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2243 (bidi_level_of_next_char, bidi_move_to_visually_next):
2244 Support iteration over a string.
0bb23927
EZ
2245 (bidi_set_sor_type, bidi_resolve_explicit_1)
2246 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2247 can now be zero (for strings); special values 0 and -1 were
2248 changed to -1 and -2, respectively.
2249 (bidi_char_at_pos): New function.
2250 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2251 Call it instead of FETCH_MULTIBYTE_CHAR.
2252 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2253 initialized to valid values.
2254 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2255 values.
2256 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2257 the test for valid cached positions. Fix the logic for looking up
2258 the sentinel state in the cache. GCPRO the Lisp string we are
2259 iterating.
2260 (bidi_push_it, bidi_pop_it): New functions.
2261 (bidi_initialize): Initialize the bidi cache start stack pointer.
2262 (bidi_cache_ensure_space): New function, refactored from part of
2263 bidi_cache_iterator_state. Don't assume the required size is just
2264 one BIDI_CACHE_CHUNK away.
2265 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2266 (bidi_count_bytes, bidi_char_at_pos): New functions.
2267 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2268 always valid if bidi_cache_idx is valid.
2269 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2270 is valid if it's going to be used.
2271 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2272 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2273 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2274 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2275 (bidi_find_other_level_edge, bidi_cache_start_stack):
2276 All variables related to cache indices are now EMACS_INT.
c965adc5 2277
0bb23927
EZ
2278 * dispextern.h (struct bidi_string_data): New structure.
2279 (struct bidi_it): New member `string'. Make flag members be 1-bit
2280 fields, and put them last in the struct.
640c8776
SM
2281 (compute_display_string_pos, compute_display_string_end):
2282 Update prototypes.
0bb23927
EZ
2283 (bidi_push_it, bidi_pop_it): Add prototypes.
2284 (struct iterator_stack_entry): New members bidi_p,
2285 paragraph_embedding, and from_disp_prop_p.
2286 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2287 (bidi_shelve_cache, bidi_unshelve_cache):
2288 Declare prototypes.
0bb23927
EZ
2289
2290 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2291 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2292 and vector-like objects.
2293
2294 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2295 cache around display iteration.
2296
2297 * window.c (Fwindow_end, window_scroll_pixel_based)
2298 (displayed_window_lines, Frecenter): Save and restore the bidi
2299 cache around display iteration.
2300
3bbd2265
LMI
23012011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2302
2303 * editfns.c (Fdelete_region): Clarify the use of the named
2304 parameters (bug#6788).
2305
adc47434
MR
23062011-07-14 Martin Rudalics <rudalics@gmx.at>
2307
2308 * indent.c (Fvertical_motion): Set and restore w->pointm when
2309 saving and restoring the window's buffer (Bug#9006).
2310
837c31f8
LMI
23112011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2312
2313 * editfns.c (Fstring_to_char): Clarify just what is returned
2314 (bug#6576). Text by Eli Zaretskii.
2315
ac389d0c
JB
23162011-07-13 Juanma Barranquero <lekktu@gmail.com>
2317
2318 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2319
0be0ce47
EZ
23202011-07-13 Eli Zaretskii <eliz@gnu.org>
2321
2322 * buffer.c (mmap_find): Fix a typo.
2323
cd18e7e3
JB
23242011-07-13 Johan Bockgård <bojohan@gnu.org>
2325
2326 Fix execution of x selection hooks.
2327 * xselect.c (Qx_lost_selection_functions)
2328 (Qx_sent_selection_functions): New vars.
2329 (syms_of_xselect): DEFSYM them.
2330 (x_handle_selection_request): Pass Qx_sent_selection_functions
2331 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2332 (x_handle_selection_clear,x_clear_frame_selections):
2333 Pass Qx_lost_selection_functions rather than
2334 Vx_lost_selection_functions to Frun_hook_with_args.
2335
47ea7f44
PE
23362011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2337
ac389d0c 2338 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2339 The old code sometimes used this field without initializing it.
2340
47ea7f44
PE
2341 * alloc.c (gc_sweep): Don't read past end of array.
2342 In theory, the old code could also have corrupted Emacs internals,
2343 though it'd be very unlikely.
2344
bc985c87
AS
23452011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2346
2347 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2348 argument. (Bug#4026)
bc985c87 2349
0cf34688
LMI
23502011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2351
b3dadd76
LMI
2352 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2353 key" (bug#4257).
2354
0cf34688
LMI
2355 * window.c (Fset_window_start): Doc fix (bug#4199).
2356 (Fset_window_hscroll): Ditto.
2357
270768cd
PE
23582011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2359
077e3dda 2360 Fix minor new problems caught by GCC 4.6.1.
270768cd 2361 * term.c (init_tty): Remove unused local.
490011a6 2362 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2363 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2364 not used otherwise.
270768cd 2365
b1f58454
CY
23662011-07-12 Chong Yidong <cyd@stupidchicken.com>
2367
2368 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2369
22b9578d
LMI
23702011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2371
6e70ab07
LMI
2372 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2373 are the mini-buffer and the echo area (bug#3320).
2374
22b9578d
LMI
2375 * term.c (init_tty): Remove support for supdup, c10 and perq
2376 terminals, which are no longer supported (bug#1482).
2377
8974cc9f
JB
23782011-07-10 Johan Bockgård <bojohan@gnu.org>
2379
2380 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2381
a560d974
JD
23822011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2383
2384 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2385 for non-popups (Bug#3642).
2386
1dae0f0a
AS
23872011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2388
268c2c36 2389 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2390 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2391 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2392 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2393 * data.c (fmod): Likewise.
2394 * dispnew.c (swap_glyphs_in_rows): Likewise.
2395 * emacs.c (memory_warning_signal): Likewise.
2396 * floatfns.c (float_error): Likewise.
2397 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2398 (otf_open, font_otf_capability, generate_otf_features)
2399 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2400 Likewise.
2401 * image.c (pbm_read_file): Likewise.
2402 * indent.c (string_display_width): Likewise.
2403 * intervals.c (check_for_interval, search_for_interval)
2404 (inc_interval_count, count_intervals, root_interval)
2405 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2406 * lread.c (defalias): Likewise.
268c2c36 2407 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2408 * regex.c (set_image_of_range_1, set_image_of_range)
2409 (regex_grow_registers): Likewise.
2410 * sysdep.c (strerror): Likewise.
2411 * termcap.c (valid_filename_p, tprint, main): Likewise.
2412 * tparam.c (main): Likewise.
2413 * unexhp9k800.c (run_time_remap, save_data_space)
2414 (update_file_ptrs, read_header, write_header, calculate_checksum)
2415 (copy_file, copy_rest, display_header): Likewise.
2416 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2417 Likewise.
2418 * xdisp.c (check_it): Likewise.
2419 * xfaces.c (register_color, unregister_color, unregister_colors):
2420 Likewise.
2421 * xfns.c (print_fontset_result): Likewise.
2422 * xrdb.c (member, fatal, main): Likewise.
2423
99033785
PE
24242011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2425
2426 Fix minor problems found by static checking (Bug#9031).
2427 * chartab.c (char_table_set_range, map_sub_char_table):
2428 Remove unused locals.
2429 (uniprop_table): Now static.
2430 * composite.c (_work_char): Remove unused static var.
2431
9cb2ac56
JB
24322011-07-09 Juanma Barranquero <lekktu@gmail.com>
2433
2434 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2435
f25661f0
JD
24362011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2437
2438 * gtkutil.c (qttip_cb): Remove code without function.
2439
8278c4fe
EZ
24402011-07-09 Eli Zaretskii <eliz@gnu.org>
2441
2442 * w32.c (pthread_sigmask): New stub.
2443
1692ae2d 24442011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2445
8a6ebd58 2446 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2447 sigprocmask is portable only for single-threaded applications, and
2448 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2449 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2450 (LIBES): Use it.
2451 * callproc.c (Fcall_process):
2452 * process.c (create_process):
2453 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2454 Use pthread_sigmask, not sigprocmask.
123403e4 2455
1b854618
JD
24562011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2457
2458 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2459 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2460 wrong (Bug#8591).
2461
3fe4b549
JD
24622011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2463
0ce7e563
JD
2464 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2465 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2466 (xg_hide_tooltip): Fix comment.
2467
3fe4b549
JD
2468 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2469 in registerServicesMenuSendTypes.
2470 (validRequestorForSendType): Don't check ns_return_types.
2471
2472 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2473 ns_return_type.
2474
5df75e47
JR
24752011-07-08 Jason Rumney <jasonr@gnu.org>
2476
2477 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2478 frame struct members of non-existent frames (Bug#6284).
2479
699c10bd
JD
24802011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2481
4393663b
JD
2482 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2483 variable firstTime not needed on OSX >= 10.6.
2484 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2485 >= 10.5. Use setKnobProportion, setDoubleValue.
2486
2487 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2488 (MAC_OS_X_VERSION_10_5): Define if not defined.
2489 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2490 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2491 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2492
2493 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2494 cString and lossyCString on OSX >= 10.4
2495
2496 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2497 sizeToFit on OSX >= 10.2.
2498
2499 * nsimage.m (allocInitFromFile): Don't use deprecated method
2500 bestRepresentationForDevice on OSX >= 10.6.
2501
2502 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2503 to avoid warning.
2504
2505 * emacs.c: Declare unexec_init_emacs_zone.
2506
a63e0781
JD
2507 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2508
699c10bd
JD
2509 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2510
2511 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2512 on svcsMenu (Bug#8842).
2513
2514 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2515 ns_return_types.
2516 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2517
2518 * nsterm.m (QUTF8_STRING): Declare.
2519 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2520 (validRequestorForSendType): Return type is (id).
2521 Change indexOfObjectIdenticalTo to indexOfObject.
2522 Check if we have local selection before returning self (Bug#8842).
2523 (writeSelectionToPasteboard): Put local selection into paste board
2524 if we have a local selection (Bug#8842).
2525 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2526
2527 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2528 (ns_get_local_selection): Declare.
2529
54e10184
LMI
25302011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2531
9888ff71
LMI
2532 * keymap.c (describe_map_tree): Don't insert a double newline at
2533 the end of the buffer (bug#1169) and return whether we inserted
2534 something.
2535
54e10184
LMI
2536 * callint.c (Fcall_interactively): Change "reading args" to
2537 "providing args" to try to clarify what it does (bug#1010).
2538
15fa4783
KH
25392011-07-07 Kenichi Handa <handa@m17n.org>
2540
2541 * composite.c (composition_compute_stop_pos): Ignore a static
2542 composition starting before CHARPOS (Bug#8915).
2543
2544 * xdisp.c (handle_composition_prop): Likewise.
2545
a8815b00
EZ
25462011-07-07 Eli Zaretskii <eliz@gnu.org>
2547
2548 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2549 (Bug#9015)
2550
ef7b981d 25512011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2552
2553 * character.h (unicode_category_t): New enum type.
2554
2555 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2556 (Qchar_code_property_table): New variable.
2557 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2558 (UNIPROP_COMPRESSED_FORM_P): New macros.
2559 (char_table_ascii): Uncompress the compressed values.
2560 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2561 Uncompress the compressed values.
ac389d0c 2562 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2563 (char_table_ref_and_range): Uncompress the compressed values.
2564 (sub_char_table_set): New arg is_uniprop. Callers changed.
2565 Uncompress the compressed values.
2566 (sub_char_table_set_range): Args changed. Callers changed.
2567 (char_table_set_range): Adjuted for the above change.
2568 (map_sub_char_table): Delete args default_val and parent. Add arg
2569 top. Give decoded values to a Lisp function.
640c8776 2570 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2571 values to a Lisp function. Gcpro more variables.
2572 (uniprop_table_uncompress)
2573 (uniprop_decode_value_run_length): New functions.
2574 (uniprop_decoder, uniprop_decoder_count): New variables.
2575 (uniprop_get_decoder, uniprop_encode_value_character)
2576 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2577 New functions.
2578 (uniprop_encoder, uniprop_encoder_count): New variables.
2579 (uniprop_get_encoder, uniprop_table)
2580 (Funicode_property_table_internal, Fget_unicode_property_internal)
2581 (Fput_unicode_property_internal): New functions.
2582 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2583 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2584 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2585 char-code-property-alist.
2586
640c8776 2587 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2588 Vunicode_category_table.
2589
640c8776 2590 * font.c (font_range): Adjust for the change of
c805dec0
KH
2591 Vunicode_category_table.
2592
76b397fb
DN
25932011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2594
2595 * m/iris4d.h: Remove file, move contents ...
2596 * s/irix6-5.h: ... here.
2597
22b4128e
PE
25982011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2599
2600 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2601 * alloc.c (mark_buffer):
2602 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2603 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2604 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2605 This isn't true in general, and it's particularly not true
2606 if Emacs is configured with --with-wide-int.
2607 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2608 New macros, used in the buffer.c change.
2609
869795d6
JD
26102011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2611
2612 * xsettings.c: Use both GConf and GSettings if both are available.
2613 (store_config_changed_event): Add comment.
2614 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2615 (store_tool_bar_style_changed): New functions.
5e617bc2 2616 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2617 (struct xsettings): Move font inside HAVE_XFT.
2618 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2619 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2620 Move inside HAVE_XFT.
640c8776 2621 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2622 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2623 also.
2624 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2625 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2626 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2627 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2628 (parse_settings): Move check for font inside HAVE_XFT.
2629 (read_settings, apply_xft_settings): Add comment.
2630 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2631 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2632 call store_font_name_changed.
2633 (xft_settings_event): Add comment.
2634 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2635 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2636 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2637 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2638 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2639 (xsettings_get_system_font, xsettings_get_system_normal_font):
2640 Add comment.
869795d6 2641
d8ed26bd
PE
26422011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2643
2644 Random fixes. E.g., (random) never returned negative values.
2645 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2646 subseconds part to the entropy, as that's a bit more random.
2647 Prefer signed to unsigned, since the signedness doesn't matter and
2648 in general we prefer signed. When given a limit, use a
2649 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2650 latter isn't right if USE_2_TAGS_FOR_INTS.
2651 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2652 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2653
cabf1cac
SM
26542011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2655
2656 * textprop.c (text_property_stickiness):
2657 Obey Vtext_property_default_nonsticky.
2658 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2659 * w32fns.c (syms_of_w32fns):
2660 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2661
6e9b2be9
PE
26622011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2663
2664 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2665 This is more efficient than Ffile_directory_p and avoids a minor race.
2666
90186c68
LMI
26672011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2668
7c301272
LMI
2669 * buffer.c (Foverlay_put): Say what the return value is
2670 (bug#7835).
2671
c4f2d8d4
LMI
2672 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2673 is a directory before asking whether to use the file name
2674 (bug#7564).
ad637907
LMI
2675 (barf_or_query_if_file_exists): Make the "File is a directory"
2676 error be more correct.
c4f2d8d4 2677
90186c68
LMI
2678 * fns.c (Frequire): Remove the mention of the .gz files, since
2679 that's installation-specific, but keep the mention of
2680 `get-load-suffixes'.
2681
da64016e
PE
26822011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2683
2684 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2685 Report string overflow if the output is too long.
2686
7d47b580
JB
26872011-07-04 Juanma Barranquero <lekktu@gmail.com>
2688
a555cb87
JB
2689 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2690 (syms_of_gnutls): Remove duplicate DEFSYM for
2691 Qgnutls_bootprop_verify_hostname_error, an error for
2692 Qgnutls_bootprop_verify_error (which is no longer used).
2693
7d47b580
JB
2694 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2695 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2696 Also (re)move comments that are misplaced or no longer relevant.
2697
1e49bfab
LMI
26982011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2699
2700 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2701
1485f4c0
CY
27022011-07-03 Chong Yidong <cyd@stupidchicken.com>
2703
2704 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2705 and background color parameters if they have been changed.
2706
a9ab721e
LMI
27072011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2708
2709 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2710
cf7cff57
PE
27112011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2712
2e13213d
PE
2713 * xsettings.c (SYSTEM_FONT): Define only when used.
2714 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2715
cf7cff57
PE
2716 * keymap.c (access_keymap_1): Now static.
2717
7a8e04f7
CY
27182011-07-02 Chong Yidong <cyd@stupidchicken.com>
2719
2720 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2721 leave any prefix arg for the up event (Bug#1586).
2722
61352f62
LMI
27232011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2724
69bb1ef7
LMI
2725 * lread.c (syms_of_lread): Mention single symbols defined by
2726 `defvar' or `defconst' (bug#7154).
2727
61352f62 2728 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2729 (Frequire): Mention get-load-suffixes.
61352f62 2730
28545e04
MR
27312011-07-02 Martin Rudalics <rudalics@gmx.at>
2732
2733 * window.h (window): Remove clone_number slot.
2734 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2735 Remove.
2736 (make_parent_window, make_window, saved_window)
2737 (Fset_window_configuration, save_window_save): Don't deal with
2738 clone numbers.
2739 * buffer.c (Qclone_number): Remove declaration.
2740 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2741
3349e122
SM
27422011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2743
2744 Add multiple inheritance to keymaps.
2745 * keymap.c (Fmake_composed_keymap): New function.
2746 (Fset_keymap_parent): Simplify.
2747 (fix_submap_inheritance): Remove.
2748 (access_keymap_1): New function extracted from access_keymap to handle
2749 embedded parents and handle lists of maps.
2750 (access_keymap): Use it.
2751 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2752 (Fcopy_keymap): Handle embedded parents.
2753 (Fcommand_remapping, define_as_prefix): Simplify.
2754 (Fkey_binding): Simplify.
2755 (syms_of_keymap): Move minibuffer-local-completion-map,
2756 minibuffer-local-filename-completion-map,
2757 minibuffer-local-must-match-map, and
2758 minibuffer-local-filename-must-match-map to Elisp.
2759 (syms_of_keymap): Defsubr make-composed-keymap.
2760 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2761 (parse_menu_item): Trivial simplification.
2762
3279eb87
GM
27632011-07-01 Glenn Morris <rgm@gnu.org>
2764
2765 * Makefile.in (SETTINGS_LIBS): Fix typo.
2766
4550efdf
KI
27672011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2768
2769 * coding.c (Fencode_coding_string): Record the last coding system
2770 used, as the function doc string says (bug#8738).
2771
0949d2b6
JD
27722011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2773
2774 * xsettings.c (store_monospaced_changed): Take new font as arg and
2775 check for change against current_mono_font.
2776 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2777 (emacs_settings_constructor, emacs_settings_get_property)
2778 (emacs_settings_set_property, emacs_settings_class_init)
2779 (emacs_settings_init, gsettings_obj): Remove.
2780 (something_changedCB): New function for HAVE_GSETTINGS.
2781 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2782 with value as argument.
2783 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2784 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2785 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2786 "changed".
2787
2788 * xgselect.c: Add defined (HAVE_GSETTINGS).
2789 (xgselect_initialize): Ditto.
2790
2791 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2792 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2793 xg_select.
2794
bbc6b304
PE
27952011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2796
2797 * eval.c (struct backtrace): Simplify and port the data structure.
2798 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2799 signed bit field, as this assumption is not portable and it makes
2800 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2801 "char debug_on_exit : 1" as this is not portable either; instead,
2802 use the portable "unsigned int debug_on_exit : 1". Remove unused
2803 member evalargs. Remove obsolete comments about cc bombing out.
2804
9851bfc5
JD
28052011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2806
51bb811f 2807 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2808 Let HAVE_GSETTINGS override HAVE_GCONF.
2809 (store_monospaced_changed): New function.
2810 (EMACS_SETTINGS): A new type derived from GObject to handle
2811 GSettings notifications.
2812 (emacs_settings_constructor, emacs_settings_get_property)
2813 (emacs_settings_set_property, emacs_settings_class_init):
2814 New functions.
2815 (gsettings_client, gsettings_obj): New variables.
2816 (GSETTINGS_SCHEMA): New define.
2817 (something_changedCB): Call store_monospaced_changed.
2818 (init_gsettings): New function.
2819 (xsettings_initialize): Call init_gsettings.
2820 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2821 to NULL.
2822
640c8776 2823 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2824 GCONF_CFLAGS/LIBS.
2825
5386012d
MR
28262011-06-29 Martin Rudalics <rudalics@gmx.at>
2827
2828 * window.c (resize_root_window, grow_mini_window)
2829 (shrink_mini_window): Rename Qresize_root_window to
2830 Qwindow_resize_root_window and Qresize_root_window_vertically to
2831 Qwindow_resize_root_window_vertically.
2832
f13e0b08
PE
28332011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2834
2835 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2836
94515237
JB
28372011-06-27 Juanma Barranquero <lekktu@gmail.com>
2838
2839 * makefile.w32-in: Redesign dependencies so they reflect more
2840 clearly which files are directly included by each source file,
2841 and not through other includes.
2842
e43b6e43
MR
28432011-06-27 Martin Rudalics <rudalics@gmx.at>
2844
2845 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2846 (sort_overlays, overlay_strings): When an overlay's clone number
2847 matches the window's clone number process the overlay even if
2848 the overlay's window property doesn't match the current window.
2849
d68443dc
MR
2850 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2851 (Fwindow_hchild): Rename to Fwindow_left_child.
2852 (Fwindow_next): Rename to Fwindow_next_sibling.
2853 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2854 (resize_window_check): Rename to window_resize_check.
2855 (resize_window_apply): Rename to window_resize_apply.
2856 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2857 (Fdelete_other_windows_internal, resize_frame_windows)
2858 (Fsplit_window_internal, Fdelete_window_internal)
2859 (grow_mini_window, shrink_mini_window)
2860 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2861
c7e73be5
JD
28622011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2863
2864 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2865 (emacs_fixed_set_min_size): Remove.
2866 (emacs_fixed_new): Take frame as argument.
2867
2868 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2869 (_EmacsFixedPrivate): Remove minwidth/height.
2870 Add struct frame *f.
2871 (emacs_fixed_init): Initialize priv->f.
2872 (get_parent_class, emacs_fixed_set_min_size): Remove.
2873 (emacs_fixed_new): Set priv->f to argument.
2874 (emacs_fixed_get_preferred_width)
2875 (emacs_fixed_get_preferred_height): Use min_width/height from
2876 frames size_hint to set minimum and natural (Bug#8919).
2877 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2878 and use min_width/height from frames size_hint to set
2879 min_width/height (Bug#8919).
2880
2881 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2882 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2883 Fix indentation.
c7e73be5 2884
cf99dcf8
EZ
28852011-06-26 Eli Zaretskii <eliz@gnu.org>
2886
2887 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2888 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2889 called at ZV.
2890
029529ac
CY
28912011-06-26 Chong Yidong <cyd@stupidchicken.com>
2892
2893 * process.c (wait_reading_process_output): Bypass select if
2894 waiting for a cell while ignoring keyboard input, and input is
2895 pending. Suggested by Jan Djärv (Bug#8869).
2896
7a7ef429
PE
28972011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2898
2899 Use gnulib's dup2 module instead of rolling our own.
2900 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2901
11fdef7d 29022011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2903
2904 * dispnew.c (scrolling_window): Before scrolling, turn off a
2905 mouse-highlight in the window being scrolled.
2906
cd3520a4
JB
29072011-06-24 Juanma Barranquero <lekktu@gmail.com>
2908
2909 Move DEFSYM to lisp.h and use everywhere.
2910
2911 * character.h (DEFSYM): Move declaration...
2912 * lisp.h (DEFSYM): ...here.
2913
2914 * gnutls.c:
2915 * minibuf.c:
2916 * w32menu.c:
2917 * w32proc.c:
2918 * w32select.c: Don't include character.h.
2919
2920 * alloc.c (syms_of_alloc):
2921 * buffer.c (syms_of_buffer):
2922 * bytecode.c (syms_of_bytecode):
2923 * callint.c (syms_of_callint):
2924 * casefiddle.c (syms_of_casefiddle):
2925 * casetab.c (init_casetab_once):
2926 * category.c (init_category_once, syms_of_category):
2927 * ccl.c (syms_of_ccl):
2928 * cmds.c (syms_of_cmds):
2929 * composite.c (syms_of_composite):
2930 * dbusbind.c (syms_of_dbusbind):
2931 * dired.c (syms_of_dired):
2932 * dispnew.c (syms_of_display):
2933 * doc.c (syms_of_doc):
2934 * editfns.c (syms_of_editfns):
2935 * emacs.c (syms_of_emacs):
2936 * eval.c (syms_of_eval):
2937 * fileio.c (syms_of_fileio):
2938 * fns.c (syms_of_fns):
2939 * frame.c (syms_of_frame):
2940 * fringe.c (syms_of_fringe):
2941 * insdel.c (syms_of_insdel):
2942 * keymap.c (syms_of_keymap):
2943 * lread.c (init_obarray, syms_of_lread):
2944 * macros.c (syms_of_macros):
2945 * msdos.c (syms_of_msdos):
2946 * print.c (syms_of_print):
2947 * process.c (syms_of_process):
2948 * search.c (syms_of_search):
2949 * sound.c (syms_of_sound):
2950 * syntax.c (init_syntax_once, syms_of_syntax):
2951 * terminal.c (syms_of_terminal):
2952 * textprop.c (syms_of_textprop):
2953 * undo.c (syms_of_undo):
2954 * w32.c (globals_of_w32):
2955 * window.c (syms_of_window):
2956 * xdisp.c (syms_of_xdisp):
2957 * xfaces.c (syms_of_xfaces):
2958 * xfns.c (syms_of_xfns):
2959 * xmenu.c (syms_of_xmenu):
2960 * xsettings.c (syms_of_xsettings):
2961 * xterm.c (syms_of_xterm): Use DEFSYM.
2962
4228cf16
TZ
29632011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2964
cd3520a4 2965 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2966
7fcccf1e
PE
29672011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2968
7efb4e0e
PE
2969 Integer and buffer overflow fixes (Bug#8873).
2970
ff5844ad
PE
2971 * print.c (printchar, strout): Check for string overflow.
2972 (PRINTPREPARE, printchar, strout):
2973 Don't set size unless allocation succeeds.
2974
90532f02
PE
2975 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2976 for sizes. Check for string overflow more accurately.
2977 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2978
6d84508d
PE
2979 * macros.c: Integer and buffer overflow fixes.
2980 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2981 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2982 Use ptrdiff_t, not int, for sizes.
2983 Don't increment bufsize until after realloc succeeds.
2984 Check for size-calculation overflow.
2985 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2986
437b2cb4
PE
2987 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2988
8b9ac8b4
PE
2989 * lread.c: Integer overflow fixes.
2990 (read_integer): Radix is now EMACS_INT, not int,
2991 to improve quality of diagnostics for out-of-range radices.
2992 Calculate buffer size correctly for out-of-range radices.
2993 (read1): Check for integer overflow in radices, and in
2994 read-circle numbers.
82cb60d3
PE
2995 (read_escape): Avoid int overflow.
2996 (Fload, openp, read_buffer_size, read1)
2997 (substitute_object_recurse, read_vector, read_list, map_obarray):
2998 Use ptrdiff_t, not int, for sizes.
2999 (read1): Use EMACS_INT, not int, for sizes.
20270765 3000 Check for size overflow.
8b9ac8b4 3001
7fcccf1e
PE
3002 * image.c (cache_image): Check for size arithmetic overflow.
3003
bfbbd7e7
PE
3004 * lread.c: Integer overflow issues.
3005 (saved_doc_string_size, saved_doc_string_length)
3006 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3007 Now ptrdiff_t, not int.
3008 (read1): Don't assume doc string length fits in int. Check for
3009 out-of-range doc string lengths.
3010 (read_list): Don't assume file position fits in int.
39019e54 3011 (read_escape): Check for hex character overflow.
bfbbd7e7 3012
4e323265
LL
30132011-06-22 Leo Liu <sdl.web@gmail.com>
3014
3015 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3016 Move to minibuffer.el.
3017
85fece3e
PE
30182011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3019
20b84ce9 3020 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3021 The following patches are for when GLYPH_DEBUG && !XASSERT.
3022 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3023 * dispnew.c (flush_stdout):
3024 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3025 Mark as externally visible.
3026 * dispnew.c (check_window_matrix_pointers): Now static.
3027 * dispnew.c (window_to_frame_vpos):
3028 * xfns.c (unwind_create_frame):
3029 * xterm.c (x_check_font): Remove unused local.
3030 * scroll.c (CHECK_BOUNDS):
3031 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3032 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3033 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3034 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3035 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3036 Now static.
3037 (debug_method_add): Use va_list and vsprintf rather than relying
3038 on undefined behavior with wrong number of arguments.
3039 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3040 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3041 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3042 since we're not interested in debugging glyphs with old libraries.
3043 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3044 GCC 4.6.0's static checking.
3045
0766b489
PE
30462011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3047
31fd4b32
PE
3048 Integer overflow and signedness fixes (Bug#8873).
3049 A few related buffer overrun fixes, too.
3050
b79e8648
PE
3051 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3052
0766b489
PE
3053 * dispextern.h (struct face.stipple):
3054 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3055 (x_bitmap_mask, x_allocate_bitmap_record)
3056 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3057 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3058 (x_create_bitmap_from_xpm_data):
3059 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3060 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3061 (.bitmaps_last):
3062 * xfaces.c (load_pixmap):
3063 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3064 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3065 (.bitmaps_last, struct x_output.icon_bitmap):
3066 Use ptrdiff_t, not int, for bitmap indexes.
3067 (x_allocate_bitmap_record): Check for size overflow.
3068 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3069
b081724f
PE
3070 Use ptrdiff_t, not int, for overlay counts.
3071 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3072 * editfns.c (overlays_around, get_pos_property):
3073 * textprop.c (get_char_property_and_overlay):
3074 * xdisp.c (next_overlay_change, note_mouse_highlight):
3075 * xfaces.c (face_at_buffer_position):
21514da7
PE
3076 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3077 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3078 (Fnext_overlay_change, Fprevious_overlay_change)
3079 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3080 Use ptrdiff_t, not int, for sizes.
21514da7 3081 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3082
3de73e5e
PE
3083 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3084
2606c57b
PE
3085 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3086 (x_session_initialize): Do not assume string length fits in int.
3087
aaafe47a
PE
3088 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3089 This is unlikely, but can occur if DPI is outlandish.
3090
2674ddc8 3091 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3092 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3093
28154962
PE
3094 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3095 * xrdb.c (magic_file_p, search_magic_path):
3096 Omit last arg SUFFIX; it was always 0. All callers changed.
3097 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3098
7de51af5
PE
3099 * xfont.c (xfont_match): Avoid need for strlen.
3100
25ed6cc3
PE
3101 * xfns.c: Don't assume strlen fits in int.
3102 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3103
4eab31dd
PE
3104 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3105 not unsigned long, as we prefer signed integers. All callers changed.
3106 Detect integer overflow in repeat count.
3107 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3108 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3109
171e2a58
PE
3110 * termcap.c: Don't assume sizes fit in int and never overflow.
3111 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3112 (gobble_line): Check for size-calculation overflow.
3113
ad39faca 3114 * minibuf.c (Fread_buffer):
6e5bb2dc 3115 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3116 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3117 Don't assume string length fits in int.
3118
52c61c22 3119 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3120 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3121
b5b8c9e5
PE
3122 * font.c: Don't assume string length fits in int.
3123 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3124 Use ptrdiff_t, not int.
ccd6111c
PE
3125 (font_intern_prop): Don't assume string length fits in int.
3126 Don't assume integer property fits in fixnum.
3127 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3128
882f0d81 3129 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3130 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3131 Reformulate so as not to need the command string.
3132 Invoke gzip -cd rather than gunzip, as it's more portable.
3133 (lock_info_type, lock_file_1, lock_file):
3134 Don't assume pid_t and time_t fit in unsigned long.
3135 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3136 (current_lock_owner): Prefer signed type for sizes.
3137 Use memcpy, not strncpy, where memcpy is what is really wanted.
3138 Don't assume (via atoi) that time_t and pid_t fit in int.
3139 Check for time_t and/or pid_t out of range, e.g., via a network share.
3140 Don't alloca where an auto var works fine.
3141
93f4cf88
PE
3142 * fileio.c: Fix some integer overflow issues.
3143 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3144 Don't assume string length fits in int.
3145 (directory_file_name): Don't assume string length fits in long.
3146 (make_temp_name): Don't assume pid fits in int, or that its print
3147 length is less than 20.
3148
f3e92b69
PE
3149 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3150
1bfdaf10
PE
3151 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3152
35016e9a
PE
3153 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3154
3d1e65a1
PE
3155 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3156 We prefer signed integers, even for size calculations.
3157
0b963a93
PE
3158 * emacs.c: Don't assume string length fits in 'int'.
3159 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3160 (main): Don't invoke strlen when not needed.
3161
573f4b54
PE
3162 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3163 (XD_DEBUG_MESSAGE): Don't waste a byte.
3164
989f33ba
PE
3165 * callproc.c (getenv_internal_1, getenv_internal)
3166 (Fgetenv_internal):
965d34eb
PE
3167 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3168
e4d29b33
PE
3169 * lread.c (invalid_syntax): Omit length argument.
3170 All uses changed. This doesn't fix a bug, but it simplifies the
3171 code away from its former Hollerith-constant appearance, and it's
3172 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3173 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3174
eb49b136
PE
3175 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3176 This didn't break anything, but it didn't help either.
3177 It's confusing to put a bogus integer in a place where the actual
3178 value does not matter.
9f62aeb1 3179 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3180 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3181
15375a22
PE
3182 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3183 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3184 implementation.
b61cc01c
PE
3185 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3186 We prefer signed types, and the value cannot exceed the EMACS_INT
3187 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3188 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3189 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3190 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3191
53b2623d
PE
3192 * indent.c (sane_tab_width): New function.
3193 (current_column, scan_for_column, Findent_to, position_indentation)
3194 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3195 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3196
51cab52b 3197 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3198
f2ed8a70
PE
3199 * lisp.h (lint_assume): New macro.
3200 * composite.c (composition_gstring_put_cache):
3201 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3202
abe80cc6
PE
3203 * editfns.c, insdel.c:
3204 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3205
b02c740e
PE
3206 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3207
ebc96716
PE
3208 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3209
b4e50fa0 3210 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3211 Use much-faster test for byte-length change.
311d5d7c 3212 Don't assume string byte-length fits in 'int'.
a4cf38e4 3213 Check that character arg fits in 'int'.
85461888 3214 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3215
c0c1ee9f
PE
3216 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3217
a498d7f4
PE
3218 * fns.c (concat): Catch string overflow earlier.
3219 Do not rely on integer wraparound.
3220
51cab52b
PE
3221 * dispextern.h (struct it.overlay_strings_charpos)
3222 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3223 * xdisp.c (forward_to_next_line_start)
3224 (back_to_previous_visible_line_start)
3225 (reseat_at_next_visible_line_start, next_element_from_buffer):
3226 Don't arbitrarily truncate the value of 'selective' to int.
3227
76031fad
PE
3228 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3229
5eb55db9
PE
3230 * composite.c: Don't truncate sizes to 'int'.
3231 (composition_gstring_p, composition_reseat_it)
3232 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3233 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3234 not EMACS_UINT, for indexes.
5eb55db9 3235
0703a717
PE
3236 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3237
d6202519
PE
3238 * buffer.c: Include <verify.h>.
3239 (struct sortvec.priority, struct sortstr.priority):
8961a454 3240 Now EMACS_INT, not int.
c20998a7 3241 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3242 (struct sortstr.size, record_overlay_string)
3243 (struct sortstrlist.size, struct sortlist.used):
3244 Don't truncate size to int.
3245 (record_overlay_string): Check for size-calculation overflow.
d6202519 3246 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3247
d5a19415
JM
32482011-06-22 Jim Meyering <meyering@redhat.com>
3249
029529ac 3250 Don't leak an XBM-image-sized buffer
d5a19415
JM
3251 * image.c (xbm_load): Free the image buffer after using it.
3252
a9041e6c
PE
32532011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3254
3255 Port to Sun C.
3256 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3257 that Sun C diagnosed.
3258 * fns.c (secure_hash): Fix pointer signedness issue.
3259 * intervals.c (static_offset_intervals): New function.
3260 (offset_intervals): Use it.
3261
7f3f739f
LL
32622011-06-21 Leo Liu <sdl.web@gmail.com>
3263
3264 * deps.mk (fns.o):
3265 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3266 sha512.h.
3267
3268 * fns.c (secure_hash): Rename from crypto_hash_function and change
3269 the first arg to accept symbols.
5b66d427 3270 (Fsecure_hash): New primitive.
7f3f739f
LL
3271 (syms_of_fns): New symbols.
3272
76147d94
DD
32732011-06-20 Deniz Dogan <deniz@dogan.se>
3274
3275 * process.c (Fset_process_buffer): Clarify return value in
3276 docstring.
3277
7d7d0045
CY
32782011-06-18 Chong Yidong <cyd@stupidchicken.com>
3279
3280 * dispnew.c (add_window_display_history): Use BVAR.
3281
3282 * xdisp.c (debug_method_add): Use BVAR.
3283 (check_window_end, dump_glyph_matrix, dump_glyph)
3284 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3285
3286 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3287 Likewise.
3288
3289 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3290 check till after the cache is created in init_frame_faces.
3291
ff2bc410
SM
32922011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3293
3294 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3295
28177add
PE
32962011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3297
dd3482fe
PE
3298 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3299 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3300 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3301
393d71f3 3302 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3303 * fileio.c (Finsert_file_contents):
3304 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3305 Remove the old (too-loose) buffer overflow checks.
3306 They weren't needed, since make_gap checks for buffer overflow.
3307 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3308 The old code merely checked for Emacs fixnum overflow, and relied
3309 on undefined (wraparound) behavior. The new code avoids undefined
3310 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3311
2e6813b0 3312 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3313 Tune. Don't use wider integers than needed. Don't use alloca.
3314 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3315
599a9e4f
PE
3316 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3317
99561444
PE
3318 * insdel.c, lisp.h (buffer_overflow): New function.
3319 (insert_from_buffer_1, replace_range, replace_range_2):
3320 * insdel.c (make_gap_larger):
3321 * editfns.c (Finsert_char):
3322 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3323
28177add
PE
3324 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3325
e69dafad
PE
33262011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3327
a7af7fde 3328 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3329
b1c46f02
PE
3330 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3331 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3332
e69dafad
PE
3333 * fileio.c: Don't assume EMACS_INT fits in off_t.
3334 (emacs_lseek): New static function.
3335 (Finsert_file_contents, Fwrite_region): Use it.
3336 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3337
566684ea
PE
3338 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3339
e6966cd6
PE
3340 * fns.c: Don't overflow int when computing a list length.
3341 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3342 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3343 truncation on 64-bit hosts. Check for QUIT every
3344 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3345 faster and is responsive enough.
3346 (Flength): Report an error instead of overflowing an integer.
3347 (Fsafe_length): Return a float if the value is not representable
3348 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3349 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3350 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3351
dd0b0efb
PE
3352 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3353 (header_size, word_size): New constants.
3354 (allocate_vectorlike): Don't check size overflow here.
3355 (allocate_vector): Check it here instead, since this is the only
3356 caller of allocate_vectorlike that could cause overflow.
3357 Check that the new vector's length is representable as a fixnum.
3358
86fe5cfe
PE
3359 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3360 The previous code was bogus. For example, next_almost_prime (32)
3361 returned 39, which is undesirable as it is a multiple of 3; and
3362 next_almost_prime (24) returned 25, which is a multiple of 5 so
3363 why was the code bothering to check for multiples of 7?
3364
80e88859
PE
3365 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3366
4a2f0ad6
PE
3367 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3368
f66c7cf8
PE
3369 Variadic C functions now count arguments with ptrdiff_t.
3370 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3371 Back then I didn't know that the Emacs coding style prefers signed int.
3372 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3373 were being counted with int, which may truncate counts on 64-bit
3374 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3375 * lisp.h (struct Lisp_Subr.function.aMANY)
3376 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3377 Arg counts are now ptrdiff_t, not size_t.
3378 All variadic functions and their callers changed accordingly.
3379 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3380 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3381 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3382 * callint.c (Fcall_interactively): Check arg count for overflow,
3383 to avoid potential buffer overrun. Use signed char, not 'int',
3384 for 'varies' array, so that we needn't bother to check its size
3385 calculation for overflow.
3386 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3387 * eval.c (apply_lambda):
3388 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3389 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3390 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3391
a1759b76
PE
3392 * callint.c (Fcall_interactively): Don't use index var as event count.
3393
d96be9fc
PE
3394 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3395 * mem-limits.h (SIZE): Remove; no longer used.
3396
a690a978 3397 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3398
578c21e6
PE
3399 Remove unnecessary casts.
3400 * xterm.c (x_term_init):
3401 * xfns.c (x_set_border_pixel):
3402 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3403 These aren't needed now that we assume ANSI C.
3404
96f53c6c
PE
3405 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3406 It's more likely to cause problems (due to unsigned overflow)
3407 than to cure them.
3408
83c77d31
PE
3409 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3410
ee2079f1
PE
3411 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3412
6da65536
PE
3413 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3414
7147c4a4
PE
3415 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3416
193e32d9
PE
3417 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3418
e5533da6
PE
3419 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3420
9910e595
PE
3421 GLYPH_CODE_FACE returns EMACS_INT, not int.
3422 * dispextern.h (merge_faces):
3423 * xfaces.c (merge_faces):
01103c44
PE
3424 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3425 Don't assume EMACS_INT fits in int.
9910e595 3426
2638320e
PE
3427 * character.h (CHAR_VALID_P): Remove unused parameter.
3428 * fontset.c, lisp.h, xdisp.c: All uses changed.
3429
045eb8d9
PE
3430 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3431
c1f134b5
PE
3432 * fns.c (concat): Minor tuning based on overflow analysis.
3433 This doesn't fix any bugs. Use int to hold character, instead
3434 of constantly refetching from Emacs object. Use XFASTINT, not
3435 XINT, for value known to be a character. Don't bother comparing
3436 a single byte to 0400, as it's always less.
3437
395fcb93 3438 * floatfns.c (Fexpt):
327eeec8
PE
3439 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3440
abbd3d23
PE
3441 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3442 for characters.
3443
684a03ef
PE
3444 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3445
0fed43f3
PE
3446 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3447 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3448 incorrectly succeed when S was a string, because 4294967386 was
3449 truncated before it was used.
3450
8fd02eb7
PE
3451 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3452 Otherwise, an out-of-range integer could cause undefined behavior
3453 on a 64-bit host.
3454
f8c86b69
PE
3455 * composite.c: Use int, not EMACS_INT, for characters.
3456 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3457 EMACS_INT, for values that are known to be in character range.
3458 This doesn't fix any bugs but is the usual style inside Emacs and
3459 may generate better code on 32-bit machines.
3460
34206dd2
PE
3461 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3462 This is for reasons similar to the recent CHAR_STRING fix.
3463 * charset.c (Fencode_char): Check that character arg is actually
3464 a character. Pass an int to ENCODE_CHAR.
3465 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3466 wider than 'int', as a compile-time check to prevent future regressions
3467 in this area.
3468
c5958d4c 3469 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3470
3471 Make sure a 64-bit char is never passed to CHAR_STRING.
3472 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3473 by silently ignoring the top 32 bits, allowing some values
3474 that were far too large to be valid characters.
3475 * character.h: Include <verify.h>.
3476 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3477 arguments are no wider than unsigned, as a compile-time check
3478 to prevent future regressions in this area.
3479 * data.c (Faset):
01103c44 3480 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3481 (Fsubst_char_in_region):
3482 * fns.c (concat):
3483 * xdisp.c (decode_mode_spec_coding):
3484 Adjust to CHAR_STRING's new requirement.
3485 * editfns.c (Finsert_char, Fsubst_char_in_region):
3486 * fns.c (concat): Check that character args are actually
3487 characters. Without this test, these functions did the wrong
3488 thing with wildly out-of-range values on 64-bit hosts.
3489
d37ca623
PE
3490 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3491 These casts should not be needed on 32-bit hosts, either.
3492 * keyboard.c (read_char):
3493 * lread.c (Fload): Remove casts to unsigned.
3494
ea204efb
PE
3495 * lisp.h (UNSIGNED_CMP): New macro.
3496 This fixes comparison bugs on 64-bit hosts.
3497 (ASCII_CHAR_P): Use it.
3498 * casefiddle.c (casify_object):
01103c44 3499 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3500 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3501 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3502 * dispextern.h (FACE_FROM_ID):
3503 * keyboard.c (read_char): Use UNSIGNED_CMP.
3504
41cb286c
PE
3505 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3506 not to EMACS_INT, to avoid GCC warning.
3507
4a1b9832
PE
3508 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3509
55daad71
PE
3510 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3511 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3512 isn't needed on 32-bit machines.
8f95c75c 3513
01103c44
PE
3514 * buffer.c (Fgenerate_new_buffer_name):
3515 Use EMACS_INT for count, not int.
0ceccced 3516 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3517
3518 * data.c (Qcompiled_function): Now static.
3519
c6f072e7
PE
3520 * window.c (window_body_lines): Now static.
3521
20ce5912
PE
3522 * image.c (gif_load): Rename local to avoid shadowing.
3523
9c4c5f81
PE
3524 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3525 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3526 * alloc.c (make_save_value): Integer argument is now of type
3527 ptrdiff_t, not int.
3528 (mark_object): Use ptrdiff_t, not int.
3529 * lisp.h (pD): New macro.
3530 * print.c (print_object): Use it.
3531
c0c5c8ae
PE
3532 * alloc.c: Use EMACS_INT, not int, to count objects.
3533 (total_conses, total_markers, total_symbols, total_vector_size)
3534 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3535 (total_free_floats, total_floats, total_free_intervals)
3536 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3537 Now EMACS_INT, not int. All uses changed.
3538 (Fgarbage_collect): Compute overall total using a double, so that
3539 integer overflow is less likely to be a problem. Check for overflow
3540 when converting back to an integer.
5a25e253
PE
3541 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3542 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3543 These were 'int' variables that could overflow on 64-bit hosts;
3544 they were never used, so remove them instead of repairing them.
211a0b2a 3545 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3546 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3547 Previously, this ceilinged at INT_MAX, but that doesn't work on
3548 64-bit machines.
e46bb31a 3549 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3550
c78baabf 3551 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3552 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3553 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3554 when a (possibly-narrower) signed value would do just as well.
3555 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3556
c9d624c6
PE
3557 * alloc.c: Catch some string size overflows that we were missing.
3558 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3559 for convenience in STRING_BYTES_MAX.
3560 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3561 The definition here is exact; the one in lisp.h was approximate.
3562 (allocate_string_data): Check for string overflow. This catches
3563 some instances we weren't catching before. Also, it catches
3564 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3565 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3566 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3567
c9d624c6
PE
3568 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3569 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3570 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3571
353032ce
PE
3572 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3573
2bccce07
PE
3574 * alloc.c (Fmake_string): Check for out-of-range init.
3575
0ac30604
SM
35762011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3577
3578 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3579
c195f2de
JD
35802011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3581
3582 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3583 xg_get_default_scrollbar_width.
3584
3585 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3586 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3587 (style_changed_cb): Call update_theme_scrollbar_width and call
3588 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3589 all frames (Bug#8505).
3590 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3591 Call gtk_window_set_resizable if HAVE_GTK3.
3592 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3593 and height if HAVE_GTK3 (Bug#8505).
3594 (scroll_bar_width_for_theme): New variable.
3595 (update_theme_scrollbar_width): New function.
3596 (xg_get_default_scrollbar_width): Move code to
3597 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3598 (xg_initialize): Call update_theme_scrollbar_width.
3599
3600 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3601
3602 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3603
e10ac9f1
MR
36042011-06-12 Martin Rudalics <rudalics@gmx.at>
3605
3606 * frame.c (make_frame): Call other_buffer_safely instead of
3607 other_buffer.
3608
3609 * window.c (temp_output_buffer_show): Call display_buffer with
3610 second argument Vtemp_buffer_show_specifiers and reset latter
3611 immediately after the call.
3612 (Vtemp_buffer_show_specifiers): New variable.
3613 (auto_window_vscroll_p, next_screen_context_lines)
3614 (Vscroll_preserve_screen_position): Remove leading asterisks from
3615 doc-strings.
3616
2d3c217e 36172011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3618
7b7f97e8 3619 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3620 * buffer.c (Qclone_number): Remove for now, as it's unused.
3621 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3622 (record_buffer): Remove unused local.
3623 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3624 (set_frame_buffer_list): Remove; unused.
3625 * frame.h (other_visible_frames): Remove decl.
3626 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3627 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3628 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3629 if HAVE_GPM.
3630 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3631 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3632 Define only if HAVE_GPM.
3633 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3634 (update_hints_inhibit): Remove; never set. All uses removed.
3635 * widgetprv.h (emacsFrameClassRec): Remove decl.
3636 * window.c (delete_deletable_window): Now returns void, since it
3637 wasn't returning anything.
3638 (compare_window_configurations): Remove unused locals.
3639 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3640 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3641 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3642 the same widths as pointers. This follows up on the 2011-05-06 patch.
3643 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3644 * xterm.h: Likewise.
3645 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3646
1384b89e
JB
36472011-06-12 Juanma Barranquero <lekktu@gmail.com>
3648
3649 * makefile.w32-in: Update dependencies.
3650 (LISP_H): Add lib/intprops.h.
3651
1100a63c
CY
36522011-06-11 Chong Yidong <cyd@stupidchicken.com>
3653
3654 * image.c (gif_load): Add animation frame delay to the metadata.
3655 (syms_of_image): Use DEFSYM. New symbol `delay'.
3656
6198ccd0
MR
36572011-06-11 Martin Rudalics <rudalics@gmx.at>
3658
3659 * window.c (delete_deletable_window): Re-add.
3660 (Fset_window_configuration): Rewrite to handle dead buffers and
3661 consequently deletable windows.
3662 (window_tree, Fwindow_tree): Remove. Supply functionality in
3663 window.el.
3664 (compare_window_configurations): Simplify code.
3665
b6e3633c
AS
36662011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3667
1ab0dee5
AS
3668 * image.c (imagemagick_load_image): Fix type mismatch.
3669 (Fimagemagick_types): Likewise.
3670
b6e3633c
AS
3671 * window.h (replace_buffer_in_windows): Declare.
3672
9397e56f
MR
36732011-06-11 Martin Rudalics <rudalics@gmx.at>
3674
3675 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3676 Qclone_number. Remove external declaration of Qdelete_window.
3677 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3678 code.
640c8776
SM
3679 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3680 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3681 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3682 buffer list implementation.
3683 (other_buffer_safely): New function.
3684 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3685 calls to replace_buffer_in_windows and
3686 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3687 if allowed.
3688 (record_buffer): Inhibit quitting and rewrite using quittable
3689 functions. Run Qbuffer_list_update_hook if allowed.
3690 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3691 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3692 Move switch-to-buffer to window.el.
9397e56f
MR
3693 (bury-buffer): Move to window.el.
3694 (Vbuffer_list_update_hook): New variable.
3695
3696 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3697 section.
3698
3699 * window.h (resize_frame_windows): Move up in code.
3700 (Fwindow_frame): Remove EXFUN.
3701 (replace_buffer_in_all_windows): Remove prototype.
3702 (replace_buffer_in_windows_safely): Add prototype.
3703
3704 * window.c: Declare Qdelete_window static again. Move down
3705 declaration of select_count.
3706 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3707 (Fother_window): Move to window.el.
3708 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3709 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3710 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3711 window.el.
3712 (replace_buffer_in_windows): Implement by calling
3713 Qreplace_buffer_in_windows.
3714 (replace_buffer_in_all_windows): Remove with some functionality
3715 moved into replace_buffer_in_windows_safely.
3716 (replace_buffer_in_windows_safely): New function.
3717 (select_window_norecord, select_frame_norecord): Move in front
3718 of run_window_configuration_change_hook. Remove now obsolete
3719 declarations.
640c8776
SM
3720 (Fset_window_buffer): Rewrite doc-string.
3721 Call Qrecord_window_buffer.
9397e56f
MR
3722 (keys_of_window): Move binding for other-window to window.el.
3723
b50691aa
CY
37242011-06-11 Chong Yidong <cyd@stupidchicken.com>
3725
3726 * dispextern.h (struct image): Replace data member, whose int_val
3727 and ptr_val fields were not used by anything, with a single
3728 lisp_val object.
3729
3730 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3731 (gif_clear_image, gif_load, imagemagick_load_image)
3732 (gs_clear_image, gs_load): Callers changed.
3733
3f754b86
PE
37342011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3735
cca69397
PE
3736 * buffer.h: Include <time.h>, for time_t.
3737 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3738
109e28d0
PE
3739 Fix minor problems found by static checking.
3740
60737f02
PE
3741 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3742
4b66faf3
PE
3743 Make identifiers static if they are not used in other modules.
3744 * data.c (Qcompiled_function, Qframe, Qvector):
3745 * image.c (QimageMagick, Qsvg):
3746 * minibuf.c (Qmetadata):
3747 * window.c (resize_window_check, resize_root_window): Now static.
3748 * window.h (resize_window_check, resize_root_window): Remove decls.
3749
109e28d0
PE
3750 * window.c (window_deletion_count, delete_deletable_window):
3751 Remove; unused.
46a4ce9e
PE
3752 (window_body_lines): Now static.
3753 (Fdelete_other_windows_internal): Mark vars as initialized.
3754 Make sure 'resize_failed' is initialized.
3755 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3756 (resize_window_apply): Remove unused local.
3757 * window.h (delete_deletable_window): Remove decl.
3758
109e28d0 3759 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3760 (imagemagick_load_image): Fix pointer signedness problem by changing
3761 last arg from unsigned char * to char *. All uses changed.
3762 Also, fix a local for similar reasons.
3763 Remove unused locals. Remove locals to avoid shadowing.
3764 (fn_rsvg_handle_free): Remove; unused.
3765 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3766 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3767
3f754b86
PE
3768 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3769
2547adb1
CY
37702011-06-10 Chong Yidong <cyd@stupidchicken.com>
3771
3772 * image.c (gif_load): Fix omitted cast error introduced by
3773 2011-06-06 change.
3774
2c8e37d4
MR
37752011-06-10 Martin Rudalics <rudalics@gmx.at>
3776
3777 * window.h (resize_proportionally, orig_total_lines)
3778 (orig_top_line): Remove from window structure.
3779 (set_window_height, set_window_width, change_window_heights)
3780 (Fdelete_window): Remove prototypes.
3781 (resize_frame_windows): Remove duplicate declaration.
3782
440a42e3
EZ
37832011-06-10 Eli Zaretskii <eliz@gnu.org>
3784
3785 * window.h (resize_frame_windows, resize_window_check)
3786 (delete_deletable_window, resize_root_window)
3787 (resize_frame_windows): Declare prototypes.
3788
3789 * window.c (resize_window_apply): Make definition be "static" to
3790 match the prototype.
3791
562dd5e9
MR
37922011-06-10 Martin Rudalics <rudalics@gmx.at>
3793
3794 * window.c: Remove declarations of Qwindow_size_fixed,
3795 window_min_size_1, window_min_size_2, window_min_size,
3796 size_window, window_fixed_size_p, enlarge_window, delete_window.
3797 Remove static from declaration of Qdelete_window, it's
3798 temporarily needed by Fbury_buffer.
3799 (replace_window): Don't assign orig_top_line and
3800 orig_total_lines.
3801 (Fdelete_window, delete_window): Remove. Window deletion is
3802 handled by window.el.
640c8776
SM
3803 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3804 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3805 (Fdelete_other_windows): Remove. Deleting other windows is
3806 handled by window.el.
3807 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3808 handled in window.el.
3809 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3810 Window minimum sizes are handled in window.el.
3811 (shrink_windows, size_window, set_window_height)
3812 (set_window_width, change_window_heights, window_height)
3813 (window_width, CURBEG, CURSIZE, enlarge_window)
3814 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3815 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3816 handled in window.el.
3817 (make_dummy_parent): Rename to make_parent_window and give it a
3818 second argument horflag.
3819 (make_window): Don't set resize_proportionally any more.
3820 (Fsplit_window): Remove. Windows are split in window.el.
3821 (save_restore_action, save_restore_orig_size)
3822 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3823 Resize mini windows in window.el.
3824 (grow_mini_window, shrink_mini_window): Implement by calling
3825 Qresize_root_window_vertically, resize_window_check and
3826 resize_window_apply.
640c8776
SM
3827 (saved_window, Fset_window_configuration, save_window_save):
3828 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3829 resize_proportionally.
3830 (window_min_height, window_min_width): Move to window.el.
3831 (keys_of_window): Move bindings for delete-other-windows,
3832 split-window, delete-window and enlarge-window to window.el.
3833
3834 * buffer.c: Temporarily extern Qdelete_window.
3835 (Fbury_buffer): Temporarily call Qdelete_window instead of
3836 Fdelete_window (Fbury_buffer will move to window.el soon).
3837
3838 * frame.c (set_menu_bar_lines_1): Remove code handling
3839 orig_top_line and orig_total_lines.
3840
3841 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3842 set_window_height but set heights directly.
3843 (change_frame_size_1): Use resize_frame_windows.
3844
3845 * xdisp.c (init_xdisp): Don't use set_window_height but set
3846 heights directly.
3847
640c8776
SM
3848 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3849 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3850 run_window_configuration_change_hook.
3851
3852 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3853 instead of change_window_heights and run
3854 run_window_configuration_change_hook.
3855
1a13852e
MR
38562011-06-09 Martin Rudalics <rudalics@gmx.at>
3857
3858 * window.c (replace_window): Rename second argument REPLACEMENT to
3859 NEW. New third argument SETFLAG. Rewrite.
3860 (delete_window, make_dummy_parent): Call replace_window with
3861 third argument 1.
3862 (window_list_1): Move down in code.
3863 (run_window_configuration_change_hook): Move set_buffer part
3864 before select_frame_norecord part in order to unwind correctly.
3865 Rename count1 to count.
3866 (recombine_windows, delete_deletable_window, resize_root_window)
3867 (Fdelete_other_windows_internal)
3868 (Frun_window_configuration_change_hook, make_parent_window)
3869 (resize_window_check, resize_window_apply, Fresize_window_apply)
3870 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3871 (Fdelete_window_internal, Fresize_mini_window_internal):
3872 New functions.
1a13852e
MR
3873 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3874
f3d1777e
MR
38752011-06-08 Martin Rudalics <rudalics@gmx.at>
3876
496e208e
MR
3877 * window.h (window): Add some new members to window structure -
3878 normal_lines, normal_cols, new_total, new_normal, clone_number,
3879 splits, nest, prev_buffers, next_buffers.
3880 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3881 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3882
f3d1777e
MR
3883 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3884 Remove.
496e208e
MR
3885 (make_dummy_parent): Set new members of windows structure.
3886 (make_window): Move down in code. Handle new members of window
3887 structure.
3888 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3889 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3890 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3891 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3892 (Fset_window_next_buffers, Fset_window_clone_number):
3893 New functions.
496e208e
MR
3894 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3895 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3896 Doc-string fixes.
3897 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3898 Argument WINDOW can be now internal window too.
3899 (Fwindow_use_time): Move up in code.
3900 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3901 Rewrite doc-string.
3902 (Fset_window_configuration, saved_window)
3903 (Fcurrent_window_configuration, save_window_save): Handle new
3904 members of window structure.
b9e809c2
MR
3905 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3906 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3907 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3908 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3909 Qget_mru_window, Qresize_root_window,
3910 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3911 Qauto_buffer_name; staticpro them.
f3d1777e 3912
abde8f8c
MR
39132011-06-07 Martin Rudalics <rudalics@gmx.at>
3914
3915 * window.c (Fwindow_total_size, Fwindow_left_column)
3916 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3917 (Fwindow_list_1): New functions.
3918 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3919 (Fwindow_width, Fscroll_left, Fscroll_right):
3920 Use window_body_cols instead of window_box_text_cols.
3921 (delete_window, Fset_window_configuration):
3922 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3923 (delete_all_subwindows): Take a window as argument and not a
3924 structure. Rewrite.
190b47e6
MR
3925 (window_loop): Remove handling of GET_LRU_WINDOW and
3926 GET_LARGEST_WINDOW.
3927 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3928
3929 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3930 window_box_text_cols. delete_all_subwindows now takes a
3931 Lisp_Object as argument.
abde8f8c 3932
640c8776
SM
3933 * indent.c (compute_motion, Fcompute_motion):
3934 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3935
fa8a67e6
MR
3936 * frame.c (delete_frame): Call delete_all_subwindows with root
3937 window as argument.
3938
a54e3482
DC
39392011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3940
3941 * fns.c (Fputhash): Document return value.
3942
60002bf5
CY
39432011-06-06 Chong Yidong <cyd@stupidchicken.com>
3944
3945 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3946
0c671da6 39472011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3948
b862a52a 3949 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3950
be44ca6c
PE
3951 Check for overflow when converting integer to cons and back.
3952 * charset.c (Fdefine_charset_internal, Fdecode_char):
3953 Use cons_to_unsigned to catch overflow.
3954 (Fencode_char): Use INTEGER_TO_CONS.
3955 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3956 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3957 * data.c (long_to_cons, cons_to_long): Remove.
3958 (cons_to_unsigned, cons_to_signed): New functions.
3959 These signal an error for invalid or out-of-range values.
3960 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3961 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3962 * font.c (Ffont_variation_glyphs):
3963 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3964 * lisp.h: Include <intprops.h>.
3965 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3966 (cons_to_signed, cons_to_unsigned): New decls.
3967 (long_to_cons, cons_to_long): Remove decls.
3968 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3969 (Fprimitive_undo): Use CONS_TO_INTEGER.
3970 * xfns.c (Fx_window_property): Likewise.
3971 * xselect.c: Include <limits.h>.
3972 (x_own_selection, selection_data_to_lisp_data):
3973 Use INTEGER_TO_CONS.
3974 (x_handle_selection_request, x_handle_selection_clear)
3975 (x_get_foreign_selection, Fx_disown_selection_internal)
3976 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3977 (lisp_data_to_selection_data): Use cons_to_unsigned.
3978 (x_fill_property_data): Use cons_to_signed.
3979 Report values out of range.
3980
d1f3d2af
PE
3981 Check for buffer and string overflow more precisely.
3982 * buffer.h (BUF_BYTES_MAX): New macro.
3983 * lisp.h (STRING_BYTES_MAX): New macro.
3984 * alloc.c (Fmake_string):
3985 * character.c (string_escape_byte8):
3986 * coding.c (coding_alloc_by_realloc):
3987 * doprnt.c (doprnt):
3988 * editfns.c (Fformat):
3989 * eval.c (verror):
3990 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3991 since they may not be the same number.
3992 * editfns.c (Finsert_char):
3993 * fileio.c (Finsert_file_contents):
3994 Likewise for BUF_BYTES_MAX.
3995
dd52fcea
PE
3996 * image.c: Use ptrdiff_t, not int, for sizes.
3997 (slurp_file): Switch from int to ptrdiff_t.
3998 All uses changed.
3999 (slurp_file): Check that file size fits in both size_t (for
4000 malloc) and ptrdiff_t (for sanity and safety).
4001
7f9bbdbb
PE
4002 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4003 if b->modtime has its maximal value.
4004
dfe18f82
PE
4005 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4006
84acfcf0
PE
4007 Don't assume time_t can fit into int.
4008 * buffer.h (struct buffer.modtime): Now time_t, not int.
4009 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4010 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4011
ccd9a01a
PE
4012 Minor fixes for signed vs unsigned integers.
4013 * character.h (MAYBE_UNIFY_CHAR):
4014 * charset.c (maybe_unify_char):
4015 * keyboard.c (read_char, reorder_modifiers):
4016 XINT -> XFASTINT, since the integer must be nonnegative.
4017 * ftfont.c (ftfont_spec_pattern):
4018 * keymap.c (access_keymap, silly_event_symbol_error):
4019 XUINT -> XFASTINT, since the integer must be nonnegative.
4020 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4021 since it makes no difference and we prefer signed.
4022 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4023 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4024 nonnegative.
4025
d6d100dd
SM
40262011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4027
4028 * window.h (Fwindow_frame): Declare.
4029
2b6148e4
PE
40302011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4031
4032 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4033 (SPARE_MEMORY): Always define.
4034 (LARGE_REQUEST): Remove.
4035 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4036
f230ecc9
MR
40372011-06-06 Martin Rudalics <rudalics@gmx.at>
4038
727e958e
MR
4039 * lisp.h: Move EXFUNS for Fframe_root_window,
4040 Fframe_first_window and Fset_frame_selected_window to window.h.
4041
4042 * window.h: Move EXFUNS for Fframe_root_window,
4043 Fframe_first_window and Fset_frame_selected_window here from
4044 lisp.h.
4045
4046 * frame.c (Fwindow_frame, Fframe_first_window)
4047 (Fframe_root_window, Fframe_selected_window)
4048 (Fset_frame_selected_window): Move to window.c.
4049 (Factive_minibuffer_window): Move to minibuf.c.
4050 (Fother_visible_frames_p): New function.
4051
4052 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4053
f230ecc9
MR
4054 * window.c (decode_window, decode_any_window): Move up in code.
4055 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4056 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4057 (Fwindow_buffer): Move up and rewrite doc-string.
4058 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4059 (Fwindow_prev): New functions.
727e958e
MR
4060 (Fwindow_frame): Move here from frame.c. Accept any window as
4061 argument.
4062 (Fframe_root_window, Fframe_first_window)
4063 (Fframe_selected_window): Move here from frame.c. Accept frame
4064 or arbitrary window as argument. Update doc-strings.
4065 (Fminibuffer_window): Move up in code.
4066 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4067 (Fset_frame_selected_window): Move here from frame.c.
4068 Marginal rewrite.
727e958e
MR
4069 (Fselected_window, select_window, Fselect_window): Move up in
4070 code. Minor doc-string fixes.
f230ecc9 4071
4d09bcf6
PE
40722011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4073
4074 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4075 Do not assume that spare memory exists; that assumption is valid
4076 only if SYSTEM_MALLOC.
4077 (LARGE_REQUEST): New macro, so that the issue of large requests
4078 is separated from the issue of spare memory.
4079
810928a2
AS
40802011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4081
172418ad
AS
4082 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4083 format. (Bug#8806)
4084
43f862f7
AS
4085 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4086
810928a2
AS
4087 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4088 before statements.
4089
a059fe24
JD
40902011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4091
4092 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4093
4094 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4095
4096 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4097 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4098
989bf368
JB
40992011-06-05 Juanma Barranquero <lekktu@gmail.com>
4100
4101 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4102
4b80f674
CY
41032011-06-04 Chong Yidong <cyd@stupidchicken.com>
4104
4105 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4106 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4107 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4108 New error handlers.
4b80f674
CY
4109 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4110 Obey Vx_select_enable_clipboard_manager. Catch errors in
4111 x_clipboard_manager_save (Bug#8779).
4112 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4113 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4114
99a33b77 41152011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4116
4117 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4118
99a33b77 41192011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4120
4121 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4122 in the current matrix if keep_current_p is non-zero.
4123
8264569d
EZ
41242011-06-04 Eli Zaretskii <eliz@gnu.org>
4125
4126 * bidi.c (bidi_level_of_next_char): Fix last change.
4127
57f97249
EZ
41282011-06-03 Eli Zaretskii <eliz@gnu.org>
4129
fec2107c 4130 Support bidi reordering of text covered by display properties.
57f97249 4131
fec2107c
EZ
4132 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4133 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4134 (bidi_cache_search, bidi_cache_iterator_state)
4135 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4136 (bidi_level_of_next_char, bidi_move_to_visually_next):
4137 Support character positions inside a run of characters covered by a
fec2107c
EZ
4138 display string.
4139 (bidi_paragraph_init, bidi_resolve_explicit_1)
4140 (bidi_level_of_next_char): Call bidi_fetch_char and
4141 bidi_fetch_char_advance instead of FETCH_CHAR and
4142 FETCH_CHAR_ADVANCE.
4143 (bidi_init_it): Initialize new members.
4144 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4145 definitions.
4146 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4147 instead of using explicit *_CHAR codes.
d6d100dd
SM
4148 (bidi_resolve_explicit, bidi_resolve_weak):
4149 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4150 bidirectional text is supported only in multibyte buffers.
4151 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4152 it to initialize the frame_window_p member of struct bidi_it.
4153 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4154 (bidi_resolve_explicit, bidi_resolve_weak)
4155 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4156 bidi_it->nchars is non-positive.
4157 (bidi_level_of_next_char): Don't try to lookup the cache for the
4158 next/previous character if nothing is cached there yet, or if we
4159 were just reseat()'ed to a new position.
c40e2fb2 4160
0e14fe90
EZ
4161 * xdisp.c (set_cursor_from_row): Set start and stop points
4162 according to the row's direction when priming the loop that looks
4163 for the glyph on which to display cursor.
4164 (single_display_spec_intangible_p): Function deleted.
4165 (display_prop_intangible_p): Reimplement to call
4166 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4167 Accept 3 additional arguments needed by handle_display_spec.
4168 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4169 values: lists, `(when COND...)' forms, etc.
4170 (single_display_spec_string_p): Support property values that are
4171 lists with the argument STRING its top-level element.
4172 (display_prop_string_p): Fix the condition for processing a
4173 property that is a list to be consistent with handle_display_spec.
fec2107c 4174 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4175 last portion of handle_display_prop.
4176 (compute_display_string_pos): Accept additional argument
4177 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4178 value of a `display' property is a "replacing spec".
4179 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4180 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4181 the display property, but just return a value indicating whether
4182 the display property will replace the characters it covers.
4183 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4184 frame_window_p members of struct bidi_it.
d6d100dd
SM
4185 (compute_display_string_pos, compute_display_string_end):
4186 New functions.
fec2107c
EZ
4187 (push_it): Accept second argument POSITION, where pop_it should
4188 jump to continue iteration.
4189 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4190
fec2107c
EZ
4191 * keyboard.c (adjust_point_for_property): Adjust the call to
4192 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4193
4194 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4195 (bidi_init_it): Update prototypes.
4196 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4197 (compute_display_string_pos, compute_display_string_end):
4198 Declare prototypes.
fec2107c
EZ
4199 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4200 EMACS_INT.
fc6f18ce 4201
40087514 42022011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4203
57f53182
PE
4204 Malloc failure behavior now depends on size of allocation.
4205 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4206 * lisp.h: Change signatures accordingly.
4207 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4208 All callers changed. (Bug#8762)
4209
4210 * gnutls.c: Use Emacs's memory allocators.
4211 Without this change, the gnutls library would invoke malloc etc.
4212 directly, which causes problems on non-SYNC_INPUT hosts, and which
4213 runs afoul of improving memory_full behavior. (Bug#8761)
4214 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4215 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4216 xfree instead of the default malloc, realloc, free.
4217 (Fgnutls_boot): No need to check for memory allocation failure,
4218 since xmalloc does that for us.
4219
ac32cd99 4220 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4221 * category.c (hash_get_category_set):
4222 * ccl.c (ccl_driver):
4223 * charset.c (Fdefine_charset_internal):
4224 * charset.h (struct charset.hash_index):
4225 * composite.c (get_composition_id, gstring_lookup_cache)
4226 (composition_gstring_put_cache):
4227 * composite.h (struct composition.hash_index):
4228 * dispextern.h (struct image.hash):
4229 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4230 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4231 (hashfn_equal, hashfn_user_defined, make_hash_table)
4232 (maybe_resize_hash_table, hash_lookup, hash_put)
4233 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4234 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4235 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4236 * image.c (make_image, search_image_cache, lookup_image)
4237 (xpm_put_color_table_h):
4238 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4239 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4240 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4241 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4242 * alloc.c (allocate_vectorlike):
4243 Check for overflow in vector size calculations.
4244 * ccl.c (ccl_driver):
4245 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4246 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4247 need to be updated by these changes.
40087514
PE
4248 * fns.c (make_hash_table, maybe_resize_hash_table):
4249 Check for integer overflow with large hash tables.
0de4bb68
PE
4250 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4251 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4252 (SXHASH_REDUCE): New macro.
4253 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4254 Use it instead of discarding useful hash info with large hash values.
4255 (sxhash_float): New function.
4256 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4257 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4258 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4259 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4260 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4261 Adjust signatures to match updated version of code.
4262 (consing_since_gc): Now EMACS_INT, since a single hash table can
4263 use more than INT_MAX bytes.
4264
698d32e2
DN
42652011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4266
4267 Make it possible to build with GCC-4.6+ -O2 -flto.
4268
4269 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4270
fd6fa53f
SM
42712011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4272
4273 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4274 Call minibuffer-inactive-mode.
4275
864db017
JB
42762011-05-31 Juanma Barranquero <lekktu@gmail.com>
4277
4278 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4279 Update dependencies.
4280
2ad0baf4
DN
42812011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4282
4283 * data.c (init_data): Remove code for UTS, this system is not
4284 supported anymore.
4285
4fcc2638
DN
42862011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4287
4288 Don't force ./temacs to start in terminal mode.
4289
4290 * frame.c (make_initial_frame): Initialize faces in all cases, not
4291 only when CANNOT_DUMP is defined.
4292 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4293
c56e0fd5
DN
42942011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4295
4296 * dispnew.c (add_window_display_history): Use const for the string
4297 pointer. Remove declaration, not needed.
4298
333d54da 42992011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4300
55d4c1b2 4301 Use 'inline', not 'INLINE'.
333d54da 4302 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4303 * alloc.c, fontset.c (INLINE): Remove.
4304 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4305 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4306 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4307 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4308 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4309
738db178
DN
43102011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4311
4312 Make it possible to run ./temacs.
4313
4314 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4315 syms_of_callproc does the same thing. Remove test for
4316 "initialized", do it in the caller.
4317 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4318
620c53a6
SM
43192011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4320
4321 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4322 (read_minibuf): Use get_minibuffer.
4323 (syms_of_minibuf): Use DEFSYM.
4324 (Qmetadata): New var.
4325 * data.c (Qbuffer): Don't make it static.
4326 (syms_of_data): Use DEFSYM.
4327
e003a292
PE
43282011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4329
4330 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4331 (CCL_CODE_MIN): New macro.
4332
ed008a6d
PE
43332011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4334
3687c2ef
PE
4335 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4336
ed008a6d
PE
4337 * eval.c (Qdebug): Now static.
4338 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4339 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4340 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4341
d66c4c7c
CY
43422011-05-29 Chong Yidong <cyd@stupidchicken.com>
4343
4344 * image.c: Various fixes to ImageMagick code comments.
4345 (Fimagemagick_types): Doc fix.
4346
5fbc2025
PE
43472011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4348
0196f88a
PE
4349 Minor fixes prompted by GCC 4.6.0 warnings.
4350
4351 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4352
5fbc2025
PE
4353 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4354 (x_clipboard_manager_save_all): Move extern decl to ...
4355 * xterm.h: ... here, so that it can be checked for consistency.
4356
1dd3c2d9
CY
43572011-05-29 Chong Yidong <cyd@stupidchicken.com>
4358
4359 * xselect.c (x_clipboard_manager_save_frame)
4360 (x_clipboard_manager_save_all): New functions.
4361 (Fx_clipboard_manager_save): Lisp function deleted.
4362
4363 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4364 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4365
4366 * xterm.h: Update prototype.
4367
5ba6571d
WX
43682011-05-28 William Xu <william.xwl@gmail.com>
4369
4370 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4371 exiting (Bug#8239).
4372
3eaff834
JM
43732011-05-28 Jim Meyering <meyering@redhat.com>
4374
e1900994 4375 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4376 * fns.c (to_uchar): Define.
4377 (crypto_hash_function): Use it to convert some newly-signed
4378 variables to unsigned, to avoid sign-extension bugs. For example,
4379 without this change, (md5 "truc") would evaluate to
4380 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4381 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4382 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4383
0f6990a7
PE
43842011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4385
4386 Integer overflow fixes.
c8a9ca5a 4387
08686060
PE
4388 * dbusbind.c: Serial number integer overflow fixes.
4389 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4390 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4391 to hold a serial number that is too large for a fixnum.
4392 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4393 Check for serial numbers out of range. Decode any serial number
59568bf0 4394 that was so large that it became a float. (Bug#8722)
08686060 4395
2d1fc3c7
PE
4396 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4397 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4398 Use XFASTINT rather than XUINT when numbers are nonnegative.
4399 (xd_append_arg, Fdbus_method_return_internal):
4400 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4401 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4402 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4403 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4404 (Bug#8722)
2d1fc3c7 4405
c8a9ca5a
PE
4406 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4407
519e1d69
PE
4408 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4409
30569699
PE
4410 ccl: add integer overflow checks
4411 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4412 (IN_INT_RANGE): New macros.
4413 (ccl_driver): Use them to check for integer overflow when
4414 decoding a CCL program. Many of the new checks are whether XINT (x)
4415 fits in int; it doesn't always, on 64-bit hosts. The new version
4416 doesn't catch all possible integer overflows, but it's an
847044ea 4417 improvement. (Bug#8719)
30569699 4418
c11285dc
PE
4419 * alloc.c (make_event_array): Use XINT, not XUINT.
4420 There's no need for unsigned here.
4421
fdccd48e
PE
4422 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4423 This follows up to the 2011-05-06 change that substituted uintptr_t
4424 for EMACS_INT. This case wasn't caught back then.
4425
37910ab2
PE
4426 Rework Fformat to avoid integer overflow issues.
4427 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4428 now (part of C89). Include <verify.h>.
4429 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4430 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4431 (Fformat): Avoid the prepass trying to compute sizes; it was only
4432 approximate and thus did not catch overflow reliably. Instead, walk
4433 through the format just once, formatting and computing sizes as we go,
4434 checking for integer overflow at every step, and allocating a larger
4435 buffer as needed. Keep track separately whether the format is
4436 multibyte. Keep only the most-recently calculated precision, rather
4437 than them all. Record whether each argument has been converted to
4438 string. Use EMACS_INT, not int, for byte and char and arg counts.
4439 Support field widths and precisions larger than INT_MAX. Avoid
4440 sprintf's undefined behavior with conversion specifications such as %#d
4441 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4442 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4443 formatting out-of-range floating point numbers with int
9173deec 4444 formats. (Bug#8668)
37910ab2 4445
2e6578fb
PE
4446 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4447
0ae6bdee
PE
4448 * data.c: Avoid integer truncation in expressions involving floats.
4449 * data.c: Include <intprops.h>.
4450 (arith_driver): When there's an integer overflow in an expression
4451 involving floating point, convert the integers to floating point
4452 so that the resulting value does not suffer from catastrophic
4453 integer truncation. For example, on a 64-bit host (* 4
4454 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4455 Do not rely on undefined behavior after integer overflow.
4456
de883a70
PE
4457 merge count_size_as_multibyte, parse_str_to_multibyte
4458 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4459 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4460 Check for integer overflow.
4461 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4462 since it's now a duplicate of the other. This is more of
4463 a character than a buffer op, so better that it's in character.c.
4464 * fns.c, print.c: Adjust to above changes.
4465
2ff916cb
PE
44662011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4467
4468 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4469
f1b54466
PE
44702011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4471
fb1ac845
PE
4472 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4473 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4474 (x_clipboard_manager_save): Now static.
4475 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4476
f1b54466
PE
4477 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4478 (crypto_hash_function): Now static.
4479 Fix pointer signedness problems. Avoid unnecessary initializations.
4480
a9f737ee
CY
44812011-05-27 Chong Yidong <cyd@stupidchicken.com>
4482
4483 * termhooks.h (Vselection_alist): Make it terminal-local.
4484
4485 * terminal.c (create_terminal): Initialize it.
4486
4487 * xselect.c: Support for clipboard managers.
4488 (Vselection_alist): Move to termhooks.h as terminal-local var.
4489 (LOCAL_SELECTION): New macro.
4490 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4491 (symbol_to_x_atom): Remove gratuitous arg.
4492 (x_handle_selection_request, lisp_data_to_selection_data)
4493 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4494 (x_own_selection, x_get_local_selection, x_convert_selection):
4495 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4496 (some_frame_on_display): Delete unused function.
4497 (Fx_own_selection_internal, Fx_get_selection_internal)
4498 (Fx_disown_selection_internal, Fx_selection_owner_p)
4499 (Fx_selection_exists_p): New optional frame arg.
4500 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4501 (x_handle_selection_clear): Don't treat other terminals with the
4502 same keyboard specially. Use the terminal-local Vselection_alist.
4503 (x_clear_frame_selections): Use Frun_hook_with_args.
4504
4505 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4506
4507 * xterm.h: Add support for those atoms.
4508
e067f0c1
CY
45092011-05-26 Chong Yidong <cyd@stupidchicken.com>
4510
4511 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4512 (converted_selections, conversion_fail_tag): New global variables.
4513 (x_selection_request_lisp_error): Free the above.
4514 (x_get_local_selection): Remove unnecessary code.
4515 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4516 of converted selections stored in converted_selections.
4517 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4518 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4519 (x_convert_selection): New function.
4520 (x_handle_selection_event): Simplify.
4521 (x_get_foreign_selection): Don't ignore incoming requests while
4522 waiting for an answer; this will fail when we implement
4523 SAVE_TARGETS, and seems unnecessary anyway.
4524 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4525 (Vx_sent_selection_functions): Doc fix.
4526
0f4aebc0
LL
45272011-05-26 Leo Liu <sdl.web@gmail.com>
4528
4529 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4530
e61124cd
YM
45312011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4532
4533 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4534
4535 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4536 for fringe update if it has periodic bitmap.
ac389d0c 4537 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4538 and fringe_bitmap_periodic_p.
4539
4540 * fringe.c (get_fringe_bitmap_data): New function.
4541 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4542 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4543 row. Mark glyph row for fringe update if periodicity changed.
4544
4545 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4546 for fringe update unless it has periodic bitmap.
4547
f16d9837
KH
45482011-05-25 Kenichi Handa <handa@m17n.org>
4549
4550 * xdisp.c (get_next_display_element): Set correct it->face_id for
4551 a static composition.
4552
e1b90ef6
LL
45532011-05-24 Leo Liu <sdl.web@gmail.com>
4554
4555 * deps.mk (fns.o):
4556 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4557
4558 * fns.c (crypto_hash_function, Fsha1): New function.
4559 (Fmd5): Use crypto_hash_function.
4560 (syms_of_fns): Add Ssha1.
4561
7400048f
PE
45622011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4563
4564 * gnutls.c: Remove unused macros.
4565 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4566 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4567 Remove macros that are defined and never used.
4568 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4569
abb71cf4
CY
45702011-05-22 Chong Yidong <cyd@stupidchicken.com>
4571
4572 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4573 (Fx_get_selection_internal): Minor cleanup.
4574 (Fx_own_selection_internal): Rename arguments for consistency with
4575 select.el.
4576
6307db39
PE
45772011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4578
4579 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4580
f3d4e0a4
CY
45812011-05-22 Chong Yidong <cyd@stupidchicken.com>
4582
4583 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4584
4d8ade89
YM
45852011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4586
4587 * dispnew.c (scrolling_window): Don't exclude the case that the
4588 last enabled row in the desired matrix touches the bottom boundary.
4589
32078c8d
GM
45902011-05-21 Glenn Morris <rgm@gnu.org>
4591
4592 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4593 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4594 and add some more files.
32078c8d 4595
7285dc67
EZ
45962011-05-20 Eli Zaretskii <eliz@gnu.org>
4597
4598 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4599 report_file_error introduced by the change from 2011-05-07.
4600
89d1bd22
PE
46012011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4602
4603 * systime.h (Time): Define only if emacs is defined.
4604 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4605 where the include path doesn't have X11/X.h by default. See
4606 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4607
e23640bb 46082011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4609
4610 * composite.c (find_automatic_composition): Fix previous change.
4611
b9704ad9
GM
46122011-05-20 Glenn Morris <rgm@gnu.org>
4613
4614 * lisp.mk: New file, split from Makefile.in.
4615 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4616 (shortlisp): Remove.
4617 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4618
4a720484
GM
46192011-05-19 Glenn Morris <rgm@gnu.org>
4620
4621 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4622 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4623 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4624 (lisp): Set the order to that of loadup.el.
4625 (shortlisp): Make it a copy of $lisp.
4626 (SOME_MACHINE_LISP): Remove.
4627 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4628 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4629
a28d4396
KH
46302011-05-18 Kenichi Handa <handa@m17n.org>
4631
4632 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4633 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4634 (find_automatic_composition): Mostly rewrite for efficiency.
4635
a2b1fa8e
JB
46362011-05-18 Juanma Barranquero <lekktu@gmail.com>
4637
4638 * makefile.w32-in: Update dependencies.
4639
8e1f5610
CS
46402011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4641
4642 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4643 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4644
7025ee00 46452011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4646
cdfa6eab
PE
4647 Fix some integer overflow issues, such as string length overflow.
4648
06d6db33
PE
4649 * insdel.c (count_size_as_multibyte): Check for string overflow.
4650
2b4560a8
PE
4651 * character.c (lisp_string_width): Check for string overflow.
4652 Use EMACS_INT, not int, for string indexes and lengths; in
4653 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4654 the resulting string length overflows an EMACS_INT; instead,
4655 report a string overflow if no precision given. When checking for
4656 precision exhaustion, use a check that cannot possibly have
4657 integer overflow. (Bug#8675)
4658 * character.h (lisp_string_width): Adjust to new signature.
4659
cb93f9be
PE
4660 * alloc.c (string_overflow): New function.
4661 (Fmake_string): Use it. This doesn't change behavior, but saves
4662 a few bytes and will simplify future changes.
4663 * character.c (string_escape_byte8): Likewise.
4664 * lisp.h (string_overflow): New decl.
4665
1a1f3366
PE
4666 Fixups, following up to the user-interface timestamp change.
4667 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4668 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4669 * msdos.c (mouse_get_pos): Likewise.
4670 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4671 * w32gui.h (Time): Define by including "systime.h" rather than by
4672 declaring it ourselves. (Bug#8664)
4673
d4e3e4d3
PE
4674 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4675 * image.c (clear_image_cache): Likewise.
4676
f6a24d19
PE
4677 * term.c (term_mouse_position): Don't assume time_t wraparound.
4678
08dc5ae6
PE
4679 Be more systematic about user-interface timestamps.
4680 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4681 and sometimes 'EMACS_UINT', to represent these timestamps.
4682 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4683 This makes the code easier to follow, and makes it easier to catch
4684 integer overflow bugs such as Bug#8664.
4685 * frame.c (Fmouse_position, Fmouse_pixel_position):
4686 Use Time, not unsigned long, for user-interface timestamps.
4687 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4688 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4689 * keyboard.h (last_event_timestamp): Likewise.
4690 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4691 * menu.h (xmenu_show): Likewise.
4692 * term.c (term_mouse_position): Likewise.
4693 * termhooks.h (struct input_event.timestamp): Likewise.
4694 (struct terminal.mouse_position_hook): Likewise.
4695 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4696 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4697 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4698 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4699 what it was before.
4700 * menu.h, termhooks.h: Include "systime.h", for Time.
4701
8e55734a
PE
4702 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4703 Don't assume that the difference between two unsigned long values
4704 can fit into an integer. At this point, we know button_down_time
4705 <= event->timestamp, so the difference must be nonnegative, so
4706 there's no need to cast the result if double-click-time is
4707 nonnegative, as it should be; check that it's nonnegative, just in
4708 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4709 apart (about 25 days). (Bug#8664)
8e55734a 4710
841f1b75 4711 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4712 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4713
3e26f69c
PE
4714 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4715 that always fit in int. Use a sentinel instead of a counter, to
4716 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4717 * frame.h (struct frame): Use int for menu_bar_items_used
4718 instead of EMACS_INT, since it always fits in int.
3e26f69c 4719
5cc152c0
PE
4720 * menu.c (grow_menu_items): Check for int overflow.
4721
d89eb65e
PE
4722 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4723
5235bd3e
PE
4724 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4725 Before, the code was not consistent. These values cannot exceed
4726 2**31 - 1 so there's no need to make them unsigned.
4727 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4728 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4729 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4730 as modifiers.
4731 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4732
bc827e23
PE
4733 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4734 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4735 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4736 presumably because the widths might not match.
4737
78eb494e
PE
4738 * window.c (size_window): Avoid needless test at loop start.
4739
04f2d78b
CB
47402011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4741
4742 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4743
d2fc7e3d 47442011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4745
4746 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4747
d2fc7e3d 47482011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4749
4750 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4751 `width' to `bar_area_x' and `bar_area_width', respectively.
4752 (x_scroll_run): Take account of fringe background extension.
4753
04f2d78b
CB
4754 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4755 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4756 `bar_area_width', respectively.
4757 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4758 background extension.
4759
79b70037
GM
47602011-05-10 Jim Meyering <meyering@redhat.com>
4761
4762 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4763
2f142cc5
JB
47642011-05-10 Juanma Barranquero <lekktu@gmail.com>
4765
4766 * image.c (Finit_image_library): Return t for built-in image types,
4767 like pbm and xbm. (Bug#8640)
4768
57679c86
AS
47692011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4770
4771 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4772
888c9e86
EZ
47732011-05-07 Eli Zaretskii <eliz@gnu.org>
4774
b0512a1d
EZ
4775 * w32console.c (Fset_screen_color): Doc fix.
4776 (Fget_screen_color): New function.
4777 (syms_of_ntterm): Defsubr it.
4778
7285dc67
EZ
4779 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4780 unlink the temporary file if Fcall_process didn't create it in the
4781 first place.
4782 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4783 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4784 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4785 cue to call_process_cleanup not to close that handle.
4786
4d3fcc8e
BK
47872011-05-07 Ben Key <bkey76@gmail.com>
4788
4789 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4790 one of two shell specific rules, either bootstrap-temacs-CMD or
4791 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4792 to the previous implementation of the bootstrap-temacs rule.
4793 The bootstrap-temacs-CMD rule is similar to the previous
4794 implementation of the bootstrap-temacs rule except that it
4795 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4796 variable.
4797
4798 These changes, along with some changes to nt/configure.bat,
4799 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4800 earlier fix to add support for --cflags and --ldflags options
4801 that include quotes so that it works whether make uses cmd or
4802 sh as the shell.
4803
b4289b64
MA
48042011-05-06 Michael Albinus <michael.albinus@gmx.de>
4805
4806 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4807 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4808 is a constant.
4809 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4810 a string. Handle both cases.
4811 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4812 (Fdbus_register_method): Use Qinvalid_function.
4813
af4c0e28
JB
48142011-05-06 Juanma Barranquero <lekktu@gmail.com>
4815
4816 * makefile.w32-in: Update dependencies.
4817 (LISP_H): Add inttypes.h and stdin.h.
4818 (PROCESS_H): Add unistd.h.
4819
c51453d9
EZ
48202011-05-06 Eli Zaretskii <eliz@gnu.org>
4821
4822 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4823 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4824
8ff0ac3c 48252011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4826
4c4b566b
PE
4827 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4828
aab2b9b5
PE
4829 * term.c (vfatal): Remove stray call to va_end.
4830 It's not needed and the C Standard doesn't allow it here anyway.
4831
c378da0b
PE
4832 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4833 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4834
288b08c7
PE
4835 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4836 bytes.
4837
e3601888
PE
4838 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4839
db6c0e74
PE
4840 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4841
dd5963ea
PE
4842 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4843
88c9450f
PE
4844 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4845
2f9442b8
PE
4846 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4847
c032b5f8
PE
4848 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4849 * charset.c (Fdefine_charset_internal): Don't initialize
4850 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4851 32-bit int (Bug#8600).
a108c10b
PE
4852
4853 * lread.c (read_integer): Be more consistent with string-to-number.
4854 Use string_to_number to do the actual conversion; this avoids
4855 rounding errors and fixes some other screwups. Without this fix,
4856 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4857 (digit_to_number): Move earlier, for benefit of read_integer.
4858 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4859 not a digit in any supported base. (Bug#8602)
a108c10b 4860
ad5f9eea
PE
4861 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4862
aec1708a
PE
4863 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4864 to match comment at start of function. This also removes a
4865 GCC warning about overflow in a 32+64-bit port.
4866
47be4ab5
PE
4867 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4868
371cac43
PE
4869 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4870 Reported by Stefan Monnier in
4871 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4872 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4873 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4874
d01a7826
PE
4875 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4876 (EMACS_UINTPTR): Likewise, with uintptr_t.
4877
7fd47d5c
PE
4878 * lisp.h: Prefer 64-bit EMACS_INT if available.
4879 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4880 on 32-bit hosts that have 64-bit int, so that they can access
4881 large files.
122b0c86
PE
4882 However, temporarily disable this change unless the temporary
4883 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4884
8727937b
PE
4885 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4886
8ac068ac
PE
4887 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4888 This removes an assumption that EMACS_INT and long are the same
4889 width as pointers. The assumption is true for Emacs porting targets
4890 now, but we want to make other targets possible.
4891 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4892 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4893 In the rest of the code, change types of integers that hold casted
4894 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4895 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4896 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4897 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4898 No need to cast type when ORing.
4899 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4900 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4901 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4902 assume EMACS_INT is the same width as char *.
4903 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4904 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4905 Remove no-longer-needed casts.
4906 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4907 (xg_tool_bar_help_callback, xg_make_tool_item):
4908 Use EMACS_INTPTR to hold an integer
4909 that will be cast to void *; this can avoid a GCC warning
4910 if EMACS_INT is not the same width as void *.
4911 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4912 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4913 (current_message_1, set_message_1):
4914 Use a local to convert to proper width without a cast.
4915 * xmenu.c (dialog_selection_callback): Likewise.
4916
ede49d71
PE
4917 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4918 Also, don't assume VALBITS / RAND_BITS is less than 5,
4919 and don't rely on undefined behavior when shifting a 1 left into
4920 the sign bit.
4921 * lisp.h (get_random): Change signature to match.
4922
2f30ecd0
PE
4923 * lread.c (hash_string): Use size_t, not int, for hash computation.
4924 Normally we prefer signed values; but hashing is special, because
4925 it's better to use unsigned division on hash table sizes so that
4926 the remainder is nonnegative. Also, size_t is the natural width
4927 for hashing into memory. The previous code used 'int', which doesn't
4928 retain enough info to hash well into very large tables.
4929 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4930
2a866e7b
PE
4931 * dbusbind.c: Don't possibly lose pointer info when converting.
4932 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4933 Use XPNTR rather than XHASH, so that the high-order bits of
4934 the pointer aren't lost when converting through void *.
4935
51639eac
PE
4936 * eval.c (Fautoload): Don't double-shift a pointer.
4937
92394119
PE
4938 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4939
dbdb9a7c
JB
49402011-05-06 Juanma Barranquero <lekktu@gmail.com>
4941
4942 * gnutls.c (DEF_GNUTLS_FN):
4943 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4944
db7a0b4f
AS
49452011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4946
4947 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4948 marker. (Bug#8610)
4949
f7ff1b0f 49502011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4951
4952 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4953 New version that can reserve upto 2GB of heap space.
4954
f7ff1b0f 49552011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4956
4957 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4958
639c109b
TZ
49592011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4960
4961 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4962 `gnutls_certificate_set_x509_key_file'.
4963
d2127135
JB
49642011-05-05 Juanma Barranquero <lekktu@gmail.com>
4965
4966 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4967 Update dependencies.
4968
e968f4f3
JB
49692011-05-04 Juanma Barranquero <lekktu@gmail.com>
4970
4971 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4972 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4973 Remove unused parameter `fildes'.
4974 * process.c (read_process_output, send_process): Don't pass it.
4975
84d358f0
JB
49762011-05-04 Juanma Barranquero <lekktu@gmail.com>
4977
4978 Fix previous change: the library cache is defined in w32.c.
4979 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4980 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4981
0898ca10
JB
49822011-05-04 Juanma Barranquero <lekktu@gmail.com>
4983
4984 Implement dynamic loading of GnuTLS on Windows.
4985
4986 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4987 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4988 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4989 Declare.
4990
4991 * gnutls.c (Qgnutls_dll): Define.
4992 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4993 (gnutls_*): Declare function pointers.
4994 (init_gnutls_functions): New function to initialize function pointers.
4995 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4996 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4997 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4998 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4999 (emacs_gnutls_write, emacs_gnutls_read)
5000 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5001 (Fgnutls_available_p): New function.
5002 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5003 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5004 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5005
5006 * image.c: Include w32.h.
5007 (Vimage_type_cache): Delete.
5008 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5009 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5010 (w32_delayed_load): Move to w32.c.
5011
5012 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5013
5014 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5015 (w32_delayed_load): Move from image.c. When loading a library, record
5016 its filename in the :loaded-from property of the library id.
5017 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5018 Initialize and staticpro them.
5019 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5020
5021 * process.c: Include lisp.h before w32.h, not after.
5022 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5023 instead of gnutls_record_check_pending.
5024
5025 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5026
ff4de4aa
TZ
50272011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5028
5029 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5030 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5031 as passed in.
5032
abe95abb
JD
50332011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5034
5035 * xterm.c (x_set_frame_alpha): Do not set property on anything
5036 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5037
e16e55d4
JB
50382011-05-02 Juanma Barranquero <lekktu@gmail.com>
5039
5040 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5041
bafcf6a5
JB
50422011-05-02 Juanma Barranquero <lekktu@gmail.com>
5043
5044 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5045 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5046 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5047 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5048 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5049 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5050 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5051 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5052 (Qgnutls_bootprop_callbacks_verify): Make static.
5053
e7a6747f
AS
50542011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5055
19ed11ba
AS
5056 * callproc.c: Indentation fixup.
5057
e7a6747f 5058 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5059 (wait_for_termination, interruptible_wait_for_termination):
5060 Move after wait_for_termination_1.
e7a6747f 5061
1ef14cb4
LMI
50622011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5063
5064 * sysdep.c (interruptible_wait_for_termination): New function
5065 which is like wait_for_termination, but allows keyboard
5066 interruptions.
5067
5068 * callproc.c (Fcall_process): Add (:file "file") as an option for
5069 the STDOUT buffer.
5070 (Fcall_process_region): Ditto.
5071
330d880c
EZ
50722011-04-30 Eli Zaretskii <eliz@gnu.org>
5073
8db90b73
EZ
5074 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5075 rather than `XVECTOR (FOO)->size'.
5076
330d880c
EZ
5077 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5078 inttypes.h, as a gnulib replacement is used if it not available in
5079 system headers.
5080
15cbd324
EZ
50812011-04-21 Eli Zaretskii <eliz@gnu.org>
5082
5083 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5084 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5085 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5086
5087 * coding.c (coding_alloc_by_realloc): Error out if destination
5088 will grow beyond MOST_POSITIVE_FIXNUM.
5089 (decode_coding_emacs_mule): Abort if there isn't enough place in
5090 charbuf for the composition carryover bytes. Reserve an extra
5091 space for up to 2 characters produced in a loop.
5092 (decode_coding_iso_2022): Abort if there isn't enough place in
5093 charbuf for the composition carryover bytes.
5094
50952011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5096
ae940cca
EZ
5097 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5098 aborting when %lld or %lll format is passed.
5099 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5100 %llo or %llx format is passed. (Bug#8545)
5101
03ab8921
EZ
5102 * window.c (window_scroll_line_based): Use a marker instead of
5103 simple variables to record original value of point. (Bug#7952)
5104
afda1437
EZ
5105 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5106 produced by %s or %c overflows available buffer space. (Bug#8545)
5107
f76dee0c
PE
51082011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5109
5110 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5111 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5112
fdc5744d
JB
51132011-04-28 Juanma Barranquero <lekktu@gmail.com>
5114
5115 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5116
638f053a
JB
51172011-04-28 Juanma Barranquero <lekktu@gmail.com>
5118
5119 * keyboard.c (Qdelayed_warnings_hook): Define.
5120 (command_loop_1): Run `delayed-warnings-hook'
5121 if Vdelayed_warnings_list is non-nil.
5122 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5123 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5124
d178f871
EZ
51252011-04-28 Eli Zaretskii <eliz@gnu.org>
5126
5127 * doprnt.c (doprnt): Don't return value smaller than the buffer
5128 size if the message was truncated. (Bug#8545).
5129
b124fd93
JB
51302011-04-28 Juanma Barranquero <lekktu@gmail.com>
5131
5132 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5133 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5134
e810457d
PE
51352011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5136
5137 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5138
ea51cceb
JB
51392011-04-27 Juanma Barranquero <lekktu@gmail.com>
5140
5141 * makefile.w32-in: Update dependencies.
5142
94dcfacf
EZ
51432011-04-27 Eli Zaretskii <eliz@gnu.org>
5144
5145 Improve `doprnt' and its usage. (Bug#8545)
5146 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5147 `format_end'. Remove support for %l as a conversion specifier.
5148 Don't use xrealloc. Improve diagnostics when the %l size modifier
5149 is used. Update the commentary.
5150
5151 * eval.c (verror): Simplify calculation of size_t.
5152
5153 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5154 messages.
5155
f61f41d7
PE
51562011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5157
5158 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5159 change.
5160
96fb4434
PE
51612011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5162
5163 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5164 This makes this file independent of the recent pseudovector change.
5165
671875da 51662011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5167
69e9b5a3
PE
5168 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5169
b5f869a7 5170 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5171 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5172 Remove unused local.
c8926152 5173 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5174
841a1577 5175 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5176 GCC 4.6.0 optimizes based on type-based alias analysis.
5177 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5178 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5179 != &v->size, and therefore "v->size = 1; b->size = 2; return
5180 v->size;" must therefore return 1. This assumption is incorrect
5181 for Emacs, since it type-puns struct Lisp_Vector * with many other
5182 types. To fix this problem, this patch adds a new type struct
f904488f 5183 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5184 and pseudovectors, and helps optimizing compilers not get fooled
5185 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5186 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5187 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5188 the size member.
eab3844f
PE
5189 (XSETPVECTYPE): Rewrite in terms of new macro.
5190 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5191 This is a bit clearer, and further avoids the possibility of
5192 undesirable aliasing.
5193 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5194 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5195 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5196 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5197 (ASIZE): Now uses header.size rather than size.
5198 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5199 to avoid the hassle of writing XVECTOR (foo)->header.size.
5200 (struct vectorlike_header): New type.
eab3844f
PE
5201 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5202 object, to help avoid aliasing.
5203 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5204 (SUBRP): Likewise, since Lisp_Subr is a special case.
5205 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5206 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5207 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5208 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5209 changed to be "header.size" and "header.next".
5210 * buffer.h (struct buffer): Likewise.
5211 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5212 * frame.h (struct frame): Likewise.
5213 * process.h (struct Lisp_Process): Likewise.
5214 * termhooks.h (struct terminal): Likewise.
5215 * window.c (struct save_window_data, struct saved_window): Likewise.
5216 * window.h (struct window): Likewise.
5217 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5218 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5219 * buffer.c (init_buffer_once): Likewise.
5220 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5221 special case.
5222 * process.c (Fformat_network_address): Use local var for size,
5223 for brevity.
5224
0df1eac5
PE
5225 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5226
847ab9d1 5227 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5228 * data.c (atof): Remove decl; no longer used or needed.
5229 (digit_to_number): Move to lread.c.
5230 (Fstring_to_number): Use new string_to_number function, to be
5231 consistent with how the Lisp reader treats infinities and NaNs.
5232 Do not assume that floating-point numbers represent EMACS_INT
5233 without losing information; this is not true on most 64-bit hosts.
5234 Avoid double-rounding errors, by insisting on integers when
5235 parsing non-base-10 numbers, as the documentation specifies.
5236 * lisp.h (string_to_number): New decl, replacing ...
5237 (isfloat_string): Remove.
bc0a5c13 5238 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5239 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5240 appears to have been a coding error. Similarly, do not accept
5241 strings like +-1e0 as floating point numbers. Do not report
5242 overflow for integer overflows unless the base is not 10 which
5243 means we have no simple and reliable way to continue.
5244 Break out the floating-point parsing into a new
5245 function string_to_number, so that Fstring_to_number parses
5246 floating point numbers consistently with the Lisp reader.
04f2d78b 5247 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5248 (E_CHAR, EXP_INT): Remove, replacing with ...
5249 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5250 (string_to_number): New function, replacing isfloat_string.
5251 This function checks for valid syntax and produces the resulting
5252 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5253 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5254 so that overflow for non-base-10 numbers is reported only when
5255 there's no portable and simple way to convert to floating point.
452f4150 5256
67769ffc
PE
5257 * textprop.c (set_text_properties_1): Rewrite for clarity,
5258 and to avoid GCC warning about integer overflow.
5259
c20db43f
PE
5260 * intervals.h (struct interval): Use EMACS_INT for members
5261 where EMACS_UINT might cause problems. See
5262 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5263 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5264 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5265 All uses changed.
37aa2f85
PE
5266 (offset_intervals): Tell GCC not to worry about length overflow
5267 when negating a negative length.
c20db43f 5268
2538aa2f
PE
5269 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5270 (overrun_check_free): Likewise.
5271
f2d3008d
PE
5272 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5273 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5274 word size.
5275
ec8df744
PE
5276 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5277 (gnutls_make_error): Rename local to avoid shadowing.
5278 (gnutls_emacs_global_deinit): ifdef out; not used.
5279 (Fgnutls_boot): Use const for pointer to readonly storage.
5280 Comment out unused local. Fix pointer signedness problems.
5281
640ee02d
PE
5282 * lread.c (openp): Don't stuff size_t into an 'int'.
5283 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5284 about possible signed overflow.
5285
6048fb2a
PE
5286 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5287 (GDK_KEY_g): Don't define if already defined.
5288 (xg_prepare_tooltip): Avoid pointer signedness problem.
5289 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5290
fa3c87e1
PE
5291 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5292 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5293
2172544b
PE
5294 * xfns.c (Fx_window_property): Simplify a bit,
5295 to make a bit faster and to avoid GCC 4.6.0 warning.
5296 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5297
9b821a21
PE
5298 * fns.c (internal_equal): Don't assume size_t fits in int.
5299
3c616cfa
PE
5300 * alloc.c (compact_small_strings): Tighten assertion a little.
5301
c2982e87
PE
5302 Replace pEd with more-general pI, and fix some printf arg casts.
5303 * lisp.h (pI): New macro, generalizing old pEd macro to other
5304 conversion specifiers. For example, use "...%"pI"d..." rather
5305 than "...%"pEd"...".
5306 (pEd): Remove. All uses replaced with similar uses of pI.
5307 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5308 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5309 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5310 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5311 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5312 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5313 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5314 64-bit hosts.
5315 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5316 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5317 * print.c (safe_debug_print, print_object): Likewise.
5318 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5319 to int.
6f04d126
PE
5320 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5321 avoiding the 0 flag, which is not portable.
c2982e87
PE
5322 * process.c (Fmake_network_process): Use pI to avoid cast.
5323 * region-cache.c (pp_cache): Likewise.
5324 * xdisp.c (decode_mode_spec): Likewise.
5325 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5326 behavior on 64-bit hosts with printf arg.
6f04d126 5327 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5328 (x_stop_queuing_selection_requests): Likewise.
5329 (x_get_window_property): Don't truncate byte count to an 'int'
5330 when tracing.
0b432f21 5331
5e073ec7
PE
5332 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5333 here, since it parses constructs like leading '-' and spaces,
5334 which are not wanted; and it overflows with large numbers.
5335 Instead, simply match F[0-9]+, which is what is wanted anyway.
5336
36372bf9
PE
5337 * alloc.c: Remove unportable assumptions about struct layout.
5338 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5339 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5340 (allocate_vectorlike, make_pure_vector): Use the new macros,
5341 plus offsetof, to remove unportable assumptions about struct layout.
5342 These assumptions hold on all porting targets that I know of, but
5343 they are not guaranteed, they're easy to remove, and removing them
5344 makes further changes easier.
5345
0b432f21
PE
5346 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5347 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5348 (string_overrun_cookie): Now const. Use initializers that
5349 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5350 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5351 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5352 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5353 multiple of sizeof (EMACS_INT); it need not be, if
5354 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5355 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5356
895009e1
JB
53572011-04-26 Juanma Barranquero <lekktu@gmail.com>
5358
5359 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5360
6a7a1b0b
TZ
53612011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5362
5363 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5364 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5365 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5366
841a1577 53672011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5368
5369 * lisp.h (Qdebug): List symbol.
895009e1 5370 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5371 * keyboard.c (debug-on-event): New variable.
5372 (handle_user_signal): Break into debugger when debug-on-event
5373 matches the current signal symbol.
5374
f2d3ba6f
DN
53752011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5376
5377 * alloc.c (check_sblock, check_string_bytes)
5378 (check_string_free_list): Convert to standard C.
5379
42ce4c63
TZ
53802011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5381
5382 * w32.c (emacs_gnutls_push): Fix typo.
5383
825cd63c
EZ
53842011-04-25 Eli Zaretskii <eliz@gnu.org>
5385
fb11d64d
EZ
5386 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5387 "cast to pointer from integer of different size".
5388
825cd63c
EZ
5389 Improve doprnt and its use in verror. (Bug#8545)
5390 * doprnt.c (doprnt): Document the set of format control sequences
5391 supported by the function. Use SAFE_ALLOCA instead of always
5392 using `alloca'.
5393
5394 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5395 is one byte too soon. Don't use xrealloc; instead xfree and
5396 xmalloc anew.
5397
e061a11b
TZ
53982011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5399
5400 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5401 callbacks stage.
5402
5403 * gnutls.c: Renamed global_initialized to
5404 gnutls_global_initialized. Added internals for the
5405 :verify-hostname-error, :verify-error, and :verify-flags
5406 parameters of `gnutls-boot' and documented those parameters in the
5407 docstring. Start callback support.
9173deec
JB
5408 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5409 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5410 on error. Return error code.
e061a11b
TZ
5411 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5412 (emacs_gnutls_read): Likewise.
5413 (Fgnutls_boot): Return handshake error code.
5414 (emacs_gnutls_handle_error): New function.
5415 (wsaerror_to_errno): Likewise.
5416
5417 * w32.h (emacs_gnutls_pull): Add prototype.
5418 (emacs_gnutls_push): Likewise.
5419
5420 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5421 (emacs_gnutls_push): Likewise.
5422
54232011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5424
5425 * process.c (wait_reading_process_output): Check if GnuTLS
5426 buffered some data internally if no FDs are set for TLS
5427 connections.
5428
5429 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5430 (LIBS): Link to USER_LIBS.
5431 ($(BLD)/gnutls.$(0)): New target.
5432
fa6996bc
EZ
54332011-04-24 Eli Zaretskii <eliz@gnu.org>
5434
eb35682e
EZ
5435 * xdisp.c (handle_single_display_spec): Rename the
5436 display_replaced_before_p argument into display_replaced_p, to
5437 make it consistent with the commentary. Fix typos in the
5438 commentary.
5439
e2ad650c
EZ
5440 * textprop.c (syms_of_textprop): Remove dead code.
5441 (copy_text_properties): Delete obsolete commentary about an
5442 interface that was deleted long ago. Fix typos in the description
5443 of arguments.
5444
1b2de274
EZ
5445 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5446 to changes in oldXMenu/XMenu.h from 2011-04-16.
5447 <menu_help_message, prev_menu_help_message>: Constify.
5448 (IT_menu_make_room): menu->help_text is now `const char **';
5449 adjust.
5450
5451 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5452 to changes in oldXMenu/XMenu.h from 2011-04-16.
5453 (struct XMenu): Declare `help_text' `const char **'.
5454
5455 * xfaces.c <Qunspecified>: Make extern again.
5456
5457 * syntax.c: Include sys/types.h before including regex.h, as
5458 required by Posix.
5459
762b15be
EZ
5460 * doc.c (get_doc_string): Improve the format passed to `error'.
5461
5462 * doprnt.c (doprnt): Improve commentary.
5463
5464 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5465
5466 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5467 them with etags.
5468
f1052e5d
EZ
5469 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5470 changes in globals.h immediately force recompilation.
762b15be
EZ
5471 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5472 $(CURDIR)/s/ms-w32.h.
5473 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5474
fa6996bc
EZ
5475 * character.c (Fchar_direction): Function deleted.
5476 (syms_of_character): Don't defsubr it.
5477 <char-direction-table>: Deleted.
5478
e6c3da20
EZ
54792011-04-23 Eli Zaretskii <eliz@gnu.org>
5480
5481 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5482 * doprnt.c: Include limits.h.
5483 (SIZE_MAX): New macro.
04f2d78b
CB
5484 (doprnt): Return a size_t value. 2nd arg is now size_t.
5485 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5486 Improve overflow protection. Support `l' modifier for integer
5487 conversions. Support %l conversion. Don't assume an EMACS_INT
5488 argument for integer conversions and for %c.
5489
5490 * lisp.h (doprnt): Restore prototype.
5491
5492 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5493 $(SRC)/character.h.
5494
5495 * Makefile.in (base_obj): Add back doprnt.o.
5496
5497 * deps.mk (doprnt.o): Add back prerequisites.
5498 (callint.o): Depend on character.h.
5499
5500 * eval.c (internal_lisp_condition_case): Include the handler
5501 representation in the error message.
5502 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5503 when breaking from the loop.
5504
5505 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5506
5507 * callint.c (Fcall_interactively): When displaying error message
5508 about invalid control letter, pass the character's codepoint, not
5509 a pointer to its multibyte form. Improve display of the character
5510 in octal and display also its hex code.
5511
5512 * character.c (char_string): Use %x to display the (unsigned)
5513 codepoint of an invalid character, to avoid displaying a bogus
5514 negative value.
5515
5516 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5517 `error', not SYMBOL_NAME itself.
5518
5519 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5520 character arguments to `error'.
5521
5522 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5523 to `error' in error message about FINAL_CHAR argument. Make sure
5524 FINAL_CHAR is a character, and use %c when it is passed as
5525 argument to `error'.
5526
4ffd0d6b 55272011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5528
5529 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5530
5531 * w32.c: Include <time.h>.
5532 (sys_localtime): New function.
5533
4ffd0d6b 55342011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5535
5536 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5537
4ffd0d6b 5538 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5539
4ffd0d6b 55402011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5541
4ffd0d6b
GM
5542 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5543 zombies (Bug#8467).
aac0c6e3 5544
04c56954
EZ
55452011-04-19 Eli Zaretskii <eliz@gnu.org>
5546
5547 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5548 gl_state.e_property when gl_state.object is Qt.
5549
5550 * insdel.c (make_gap_larger): Remove limitation of buffer size
5551 to <= INT_MAX.
5552
16a43933
CY
55532011-04-18 Chong Yidong <cyd@stupidchicken.com>
5554
5555 * xdisp.c (lookup_glyphless_char_display)
5556 (produce_glyphless_glyph): Handle cons cell entry in
5557 glyphless-char-display.
5558 (Vglyphless_char_display): Document it.
5559
5560 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5561 glyphless-char-display.
5562
4581706e
CY
55632011-04-17 Chong Yidong <cyd@stupidchicken.com>
5564
5565 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5566
5567 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5568
5569 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5570 definition for no-X builds.
5571
4887c6e2 55722011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5573
fd35b6f9
PE
5574 Static checks with GCC 4.6.0 and non-default toolkits.
5575
5c1ccb01
PE
5576 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5577
006c5daa
PE
5578 * process.c (keyboard_bit_set): Define only if SIGIO.
5579 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5580 (send_process): Repair possible setjmp clobbering.
5581
efc736d3
PE
5582 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5583
4e2fe2e6
PE
5584 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5585
f97334a2
PE
5586 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5587
4e75f29d
PE
5588 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5589 Define only if needed.
5590
90efadd1
PE
5591 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5592 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5593 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5594
3c647824
PE
5595 * dispextern.h (struct redisplay_interface): Rename param
5596 to avoid shadowing.
e264f262 5597 * termhooks.h (struct terminal): Likewise.
761383f4 5598 * xterm.c (xembed_send_message): Likewise.
3c647824 5599
b58c5c4a
PE
5600 * insdel.c (make_gap_smaller): Define only if
5601 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5602
cad59032
PE
5603 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5604 it.
5605
c339dc2e
PE
5606 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5607 so that we aren't warned about unused symbols.
5608
91a3e27b
PE
5609 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5610
399c71d3 5611 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5612
8ffc96f5
PE
5613 * xfns.c (x_real_positions): Mark locals as initialized.
5614
eef9bc79
PE
5615 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5616
098db9dd
PE
5617 * xterm.c: Fix problems found by static analysis with other toolkits.
5618 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5619 (x_dispatch_event): Declare static if USE_GTK, and
5620 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5621 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5622 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5623 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5624 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5625
eb18f6cc
PE
5626 * xmenu.c (menu_help_callback): Pointer type fixes.
5627 Use const pointers when pointing at readonly data. Avoid pointer
5628 signedness clashes.
5629 (FALSE): Remove unused macro.
5630 (update_frame_menubar): Remove unused decl.
5631
1fe72bf8
PE
5632 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5633
60d9e1db
PE
5634 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5635 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5636 (single_menu_item): Rename local to avoid shadowing.
5637
39261c26
PE
5638 * keyboard.c (make_lispy_event): Remove unused local var.
5639
018c5e19
PE
5640 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5641 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5642
63d2b86e
PE
5643 * bitmaps: Change bitmaps from unsigned char back to the X11
5644 compatible char. Avoid the old compiler warnings about
5645 out-of-range initializers by using, for example, '\xab' rather
5646 than 0xab.
5647
aefd87e1
PE
5648 * xgselect.c (xgselect_initialize): Check vs interface
5649 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5650
bf501fb9
PE
5651 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5652
e9829fdf
PE
5653 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5654 to read-only memory.
5655
1086c095
PE
5656 * fns.c (vector): Remove; this old hack is no longer needed.
5657
2baccd04 5658 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5659 Remove unused var.
dde42981 5660 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5661
72391843 5662 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5663
436c16df 5664 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5665 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5666 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5667
92bb796d 5668 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5669 (x_term_init): Remove local to avoid shadowing.
92bb796d 5670
764430a3 5671 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5672
5673 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5674 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5675
d1dfb56c
EZ
56762011-04-16 Eli Zaretskii <eliz@gnu.org>
5677
c4354cb4
EZ
5678 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5679
d1dfb56c
EZ
5680 Fix regex.c, syntax.c and friends for buffers > 2GB.
5681 * syntax.h (struct gl_state_s): Declare character position members
5682 EMACS_INT.
5683
5684 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5685
04f2d78b
CB
5686 * textprop.c (verify_interval_modification, interval_of):
5687 Declare arguments EMACS_INT.
d1dfb56c
EZ
5688
5689 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5690 EMACS_INT.
5691
5692 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5693
5694 * indent.c (Fvertical_motion): Local variable it_start is now
5695 EMACS_INT.
5696
5697 * regex.c (re_match, re_match_2, re_match_2_internal)
5698 (bcmp_translate, regcomp, regexec, print_double_string)
5699 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5700 (re_compile_pattern, re_exec): Declare arguments and local
5701 variables `size_t' and `ssize_t' and return values `regoff_t', as
5702 appropriate.
5703 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5704 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5705 <compile_stack_type>: `size' and `avail' are now `size_t'.
5706
5707 * regex.h <regoff_t>: Use ssize_t, not int.
5708 (re_search, re_search_2, re_match, re_match_2): Arguments that
5709 specify buffer/string position and length are now ssize_t and
5710 size_t. Return type is regoff_t.
5711
613052cd
BK
57122011-04-16 Ben Key <bkey76@gmail.com>
5713
5714 * nsfont.m: Fixed bugs in ns_get_family and
5715 ns_descriptor_to_entity that were caused by using free to
5716 deallocate memory blocks that were allocated by xmalloc (via
5717 xstrdup). This caused Emacs to crash when compiled with
5718 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5719 --enable-checking=xmallocoverrun). xfree is now used to
5720 deallocate these memory blocks.
5721
4170f62f 57222011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5723
71b41406
PE
5724 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5725
9587a89d
PE
5726 emacs_write: Accept and return EMACS_INT for sizes.
5727 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5728 et seq.
5729 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5730 Accept and return EMACS_INT.
5731 (emacs_gnutls_write): Return the number of bytes written on
5732 partial writes.
5733 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5734 (emacs_read, emacs_write): Remove check for negative size, as the
5735 Emacs source code has been audited now.
9587a89d
PE
5736 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5737 (emacs_read, emacs_write): Use it.
273a5f82
PE
5738 * process.c (send_process): Adjust to the new signatures of
5739 emacs_write and emacs_gnutls_write. Do not attempt to store
5740 a byte offset into an 'int'; it might overflow.
9587a89d 5741 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5742
3e047f51
PE
5743 * sound.c: Don't assume sizes fit in 'int'.
5744 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5745 Return EMACS_INT, not int.
3e047f51 5746 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5747 Accept EMACS_INT, not int.
5748 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5749 record read return values.
5750
cc39a9db
BK
57512011-04-15 Ben Key <bkey76@gmail.com>
5752
c9d0ec6d
JB
5753 * keyboard.c (Qundefined): Don't declare static since it is used
5754 in nsfns.m.
5755 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5756 static since they are used in nsfont.m.
cc39a9db 5757
6c60eb9f
SM
57582011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5759
5760 * process.c (Qprocessp): Don't declare static.
5761 * lisp.h (Qprocessp): Declare again.
5762
7990b61a
JB
57632011-04-15 Juanma Barranquero <lekktu@gmail.com>
5764
5765 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5766
5d4cb038
PE
57672011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5768
8bd7b830 5769 Improve C-level modularity by making more things 'static'.
cd64ea1d 5770
e3b27b31
PE
5771 Don't publish debugger-only interfaces to other modules.
5772 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5773 (verify_bytepos, count_markers): Move decls to the only modules
5774 that need them.
5775 * region-cache.h (pp_cache): Likewise.
5776 * window.h (check_all_windows): Likewise.
5777 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5778
5d4cb038
PE
5779 * sysdep.c (croak): Now static, if
5780 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5781 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5782
5783 * alloc.c (refill_memory_reserve): Now static if
5784 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5785 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5786
e87b6180
PE
5787 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5788 Define only if USE_LUCID.
5789
ac64929e
PE
5790 * xrdb.c (x_customization_string, x_rm_string): Now static.
5791
6f37259d
PE
5792 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5793 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5794
1683e3ab
PE
5795 * xdisp.c (draw_row_with_mouse_face): Now static.
5796 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5797
de9c2632
PE
5798 * window.h (check_all_windows): Mark externally visible.
5799
2b96acb7
PE
5800 * window.c (window_deletion_count): Now static.
5801
5802 * undo.c: Make symbols static if they're not exported.
5803 (last_undo_buffer, last_boundary_position, pending_boundary):
5804 Now static.
5805
50436f33
PE
5806 * textprop.c (interval_insert_behind_hooks): Now static.
5807 (interval_insert_in_front_hooks): Likewise.
5808
64520e5c
PE
5809 * term.c: Make symbols static if they're not exported.
5810 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5811 (max_frame_lines, tty_set_terminal_modes):
5812 (tty_reset_terminal_modes, tty_turn_off_highlight):
5813 (get_tty_terminal): Now static.
5814 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5815 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5816 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5817 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5818 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5819
1fa53021
PE
5820 * sysdep.c: Make symbols static if they're not exported.
5821 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5822 Now static.
5823 (sigprocmask_set, full_mask): Remove; unused.
5824 (wait_debugging): Mark as visible.
5825 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5826 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5827
d4b43b22
PE
5828 * syntax.c (syntax_temp): Define only if !__GNUC__.
5829
b7c513d0
PE
5830 * sound.c (current_sound_device, current_sound): Now static.
5831
989b29ad
PE
5832 * search.c (searchbufs, searchbuf_head): Now static.
5833
13a55a78
PE
5834 * scroll.c (scroll_cost): Remove; unused.
5835 * dispextern.h (scroll_cost): Remove decl.
5836
de68a1fc
PE
5837 * region-cache.h (pp_cache): Mark as externally visible.
5838
40ccffa6
PE
5839 * process.c: Make symbols static if they're not exported.
5840 (process_tick, update_tick, create_process, chan_process):
5841 (Vprocess_alist, proc_buffered_char, datagram_access):
5842 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5843 (deactivate_process): Mark defn as static, as well as decl.
5844 * lisp.h (create_process): Remove decl.
5845 * process.h (chan_process, Vprocess_alist): Remove decls.
5846
ad64fc97
PE
5847 * print.c: Make symbols static if they're not exported.
5848 (print_depth, new_backquote_output, being_printed, print_buffer):
5849 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5850 (print_interval, print_number_index, initial_stderr_stream):
5851 Now static.
5852 * lisp.h (Fprinc): Remove decl.
5853 (debug_output_compilation_hack): Mark as externally visible.
5854
adddb265
PE
5855 * sysdep.c (croak): Move decl from here to syssignal.h.
5856 * syssignal.h (croak): Put it here, so the API can be checked when
5857 'croak' is called from dissociate_if_controlling_tty.
5858
1717ede2
PE
5859 * minibuf.c: Make symbols static if they're not exported.
5860 (minibuf_save_list, choose_minibuf_frame): Now static.
5861 * lisp.h (choose_minibuf_frame): Remove decl.
5862
fa5fb2bc
PE
5863 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5864
1e3890d1
PE
5865 * lread.c: Make symbols static if they're not exported.
5866 (read_objects, initial_obarray, oblookup_last_bucket_number):
5867 Now static.
5868 (make_symbol): Remove; unused.
5869 * lisp.h (initial_obarray, make_symbol): Remove decls.
5870
8a1414fa
PE
5871 * keyboard.c: Make symbols static if they're not exported.
5872 (single_kboard, recent_keys_index, total_keys, recent_keys):
5873 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5874 (this_single_command_key_start, echoing, last_auto_save):
5875 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5876 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5877 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5878 (Vlispy_mouse_stem, double_click_count):
5879 Now static.
5880 (force_auto_save_soon): Define only if SIGDANGER.
5881 (ignore_mouse_drag_p): Now static if
5882 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5883 (print_help): Remove; unused.
5884 (stop_character, last_timer_event): Mark as externally visible.
5885 * keyboard.h (ignore_mouse_drag_p): Declare only if
5886 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5887 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5888 * lisp.h (echoing): Remove decl.
5889 (force_auto_save_soon): Declare only if SIGDANGER.
5890 * xdisp.c (redisplay_window): Simplify code, to make it more
5891 obvious that ignore_mouse_drag_p is not accessed if !defined
5892 USE_GTK && !defined HAVE_NS.
5893
93ea6e8f
PE
5894 * intervals.c: Make symbols static if they're not exported.
5895 (merge_properties_sticky, merge_interval_right, delete_interval):
5896 Now static.
5897 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5898
77382fcc
PE
5899 * insdel.c: Make symbols static if they're not exported.
5900 However, leave prepare_to_modify_buffer alone. It's never
5901 called from outside this function, but that appears to be a bug.
5902 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5903 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5904 (adjust_after_replace_noundo): Remove; unused.
5905 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5906 (signal_before_change): Remove decls.
77382fcc 5907
9306c32e
PE
5908 * indent.c (val_compute_motion, val_vmotion): Now static.
5909
cd44d2eb
PE
5910 * image.c: Make symbols static if they're not exported.
5911 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5912 if USE_GTK.
5913 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5914 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5915
ad9a7a06
PE
5916 * fringe.c (standard_bitmaps): Now static.
5917 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5918
81626931
PE
5919 * frame.c: Make symbols static if they're not exported.
5920 (x_report_frame_params, make_terminal_frame): Now static.
5921 (get_frame_param): Now static, unless HAVE_NS.
5922 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5923 (x_get_resource_string): Remove; not used.
5924 * frame.h (make_terminal_frame, x_report_frame_params):
5925 (x_get_resource_string); Remove decls.
5926 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5927 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5928
239f9db9
PE
5929 * font.c, fontset.c: Make symbols static if they're not exported.
5930 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5931 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5932 * font.c (font_close_object): Now static.
5933 * font.h (font_close_object): Remove.
5934 * fontset.c (FONTSET_OBJLIST): Remove.
5935 (free_realized_fontset) #if-0 the body, which does nothing.
5936 (face_suitable_for_char_p): #if-0, as it's never called.
5937 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5938 * xfaces.c (face_at_string_position):
5939 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5940 since 0 is always ASCII.
5941
dfcf3579
PE
5942 * fns.c (weak_hash_tables): Now static.
5943
5045092b
PE
5944 * fileio.c: Make symbols static if they're not exported.
5945 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5946 (Vwrite_region_annotation_buffers): Now static.
5947
57a96f5c
PE
5948 * eval.c: Make symbols static if they're not exported.
5949 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5950 * lisp.h (backtrace_list): Remove decl.
5951
35f08c38
PE
5952 * emacs.c: Make symbols static if they're not exported.
5953 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5954 (fatal_error_code, fatal_error_signal_hook, standard_args):
5955 Now static.
5956 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5957 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5958 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5959 * lisp.h (fatal_error_signal_hook): Remove decl.
5960 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5961
f44bd759
PE
5962 * editfns.c: Move a (normally-unused) function to its only use.
5963 * editfns.c, lisp.h (get_operating_system_release): Remove.
5964 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5965 worth the hassle of breaking this out.
5966
b532497d
PE
5967 * xterm.c: Make symbols static if they're not exported.
5968 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5969 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5970 (x_destroy_window, x_delete_display):
5971 Now static.
5972 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5973 (x_mouse_leave): Remove; unused.
5974 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5975 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5976 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5977 Remove decls.
5978 (x_mouse_leave): Declare only if WINDOWSNT.
5979 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5980 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5981 USE_X_TOOLKIT.
5982
1675728f
PE
5983 * ftxfont.c: Make symbols static if they're not exported.
5984 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5985 HAVE_FREETYPE.
5986 * font.h (ftxfont_driver): Likewise.
5987
e4cebfca
PE
5988 * xfns.c: Make symbols static if they're not exported.
5989 (x_last_font_name, x_display_info_for_name):
5990 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5991 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5992 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5993 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5994 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5995 (last_show_tip_args): Now static.
5996 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5997 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5998 (x_screen_planes): Remove; unused.
5999 * dispextern.h (x_screen_planes): Remove decl.
6000
5bf46f05
PE
6001 * dispnew.c: Make symbols static if they're not exported.
6002 * dispextern.h (redraw_garbaged_frames, scrolling):
6003 (increment_row_positions): Remove.
6004 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6005 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6006 Now static.
6007 (redraw_garbaged_frames): Remove; unused.
6008
435f4c28
PE
6009 * xfaces.c: Make symbols static if they're not exported.
6010 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6011 Remove decls.
6012 * xterm.h (defined_color): Remove decls.
6013 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6014 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6015 (menu_face_changed_default, defined_color, free_realized_face):
6016 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6017 (ascii_face_of_lisp_face): Remove; unused.
6018
8524aef3
PE
6019 * xdisp.c: Make symbols static if they're not exported.
6020 * dispextern.h (scratch_glyph_row, window_box_edges):
6021 (glyph_to_pixel_coords, set_cursor_from_row):
6022 (get_next_display_element, set_iterator_to_next):
6023 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6024 (show_mouse_face): Remove decls
6025 * frame.h (message_buf_print): Likewise.
6026 * lisp.h (pop_message, set_message, check_point_in_composition):
6027 Likewise.
6028 * xterm.h (set_vertical_scroll_bar): Likewise.
6029 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6030 (message_buf_print, scratch_glyph_row, displayed_buffer):
6031 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6032 (get_next_display_element, show_mouse_face, window_box_edges):
6033 (frame_to_window_pixel_xy, check_point_in_composition):
6034 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6035 (glyph_to_pixel_coords): Remove; unused.
6036
16390cd2
PE
6037 * dired.c (file_name_completion): Now static.
6038
6039 * dbusbind.c (xd_in_read_queued_messages): Now static.
6040
a25f4dfa
PE
6041 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6042 * data.c (circular_list_error): Remove.
6043
14a9c8df
PE
6044 * commands.h (last_point_position, last_point_position_buffer):
6045 (last_point_position_window): Remove decls.
6046 * keyboard.c: Make these variables static.
6047
04f2d78b
CB
6048 * coding.h (coding, code_convert_region, encode_coding_gap):
6049 Remove decls.
74ab6df5
PE
6050 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6051 (iso_code_class, detect_coding, code_convert_region): Now static.
6052 (encode_coding_gap): Remove; unused.
6053
38dfbee1
PE
6054 * chartab.c (chartab_chars, chartab_bits): Now static.
6055
a2cb4e63
PE
6056 * charset.h (charset_iso_8859_1): Remove decl.
6057 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6058 Now static.
6059
127198fd
PE
6060 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6061 * ccl.c (Vccl_program_table): Now static.
6062 (check_ccl_update): Remove; unused.
6063
d85b608f
PE
6064 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6065 * category.h: ... from here.
6066 * category.c (check_category_table, set_category_set): Now static.
6067
31cd66f3
PE
6068 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6069 * lisp.h: Remove these decls.
6070
c358e587
PE
6071 * buffer.c (buffer_count): Remove unused var.
6072
e78aecca
PE
6073 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6074 so that it's not optimized away.
6075 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6076 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6077 exported only to the debugger.
6078
e192d7d3 6079 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6080 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6081
92470028
PE
6082 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6083 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6084 was inaccessible from Lisp.
6085 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6086 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6087
244ed907
PE
6088 alloc.c: Import and export fewer symbols, and remove unused items.
6089 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6090 is defined.
6091 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6092 it's not optimized away by whole-program optimization.
6093 (message_enable_multibyte, free_misc): Remove.
6094 (catchlist, handlerlist, mark_backtrace):
6095 Declare only if BYTE_MARK_STACK.
6096 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6097 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6098 (message_enable_multibyte): Remove decl.
6099 (free_misc, interval_free_list, float_block, float_block_index):
6100 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6101 (cons_free_list, last_marked_index):
6102 Now static.
6103 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6104 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6105 (mark_backtrace): Define only if BYTE_MARK_STACK.
6106 * xdisp.c (message_enable_multibyte): Now static.
6107
61c2b50e 6108 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6109 This makes it easier for human readers (and static analyzers)
6110 to see whether these variables are used from other modules.
6111 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6112 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6113 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6114 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6115 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6116 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6117 * xmenu.c, xselect.c:
6118 Declare Q* vars static if they are not used in other modules.
6119 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6120 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6121 Remove decls of unexported vars.
6122 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6123
95c82688
PE
6124 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6125
16a97296
PE
6126 Make Emacs functions such as Fatom 'static' by default.
6127 This makes it easier for human readers (and static analyzers)
6128 to see whether these functions can be called from other modules.
6129 DEFUN now defines a static function. To make the function external
6130 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6131 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6132 (Finit_image_library):
16a97296
PE
6133 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6134 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6135 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6136 Remove decls, since these functions are now static.
6137 (Funintern, Fget_internal_run_time): New decls, since these functions
6138 were already external.
95c82688 6139
16a97296
PE
6140 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6141 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6142 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6143 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6144 * keyboard.c, keymap.c, lread.c:
6145 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6146 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6147 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6148 Mark functions with DEFUE instead of DEFUN,
6149 if they are used in other modules.
6150 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6151 decls for now-static functions.
6152 * buffer.h (Fdelete_overlay): Remove decl.
6153 * callproc.c (Fgetenv_internal): Mark as internal.
6154 * composite.c (Fremove_list_of_text_properties): Remove decl.
6155 (Fcomposition_get_gstring): New forward static decl.
6156 * composite.h (Fcomposite_get_gstring): Remove decl.
6157 * dired.c (Ffile_attributes): New forward static decl.
6158 * doc.c (Fdocumntation_property): New forward static decl.
6159 * eval.c (Ffetch_bytecode): New forward static decl.
6160 (Funintern): Remove extern decl; now in .h file where it belongs.
6161 * fileio.c (Fmake_symbolic_link): New forward static decl.
6162 * image.c (Finit_image_library): New forward static decl.
6163 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6164 * intervals.h (Fprevious_property_change):
6165 (Fremove_list_of_text_properties): Remove decls.
6166 * keyboard.c (Fthis_command_keys): Remove decl.
6167 (Fcommand_execute): New forward static decl.
6168 * keymap.c (Flookup_key): New forward static decl.
6169 (Fcopy_keymap): Now static.
6170 * keymap.h (Flookup_key): Remove decl.
6171 * process.c (Fget_process): New forward static decl.
6172 (Fprocess_datagram_address): Mark as internal.
6173 * syntax.c (Fsyntax_table_p): New forward static decl.
6174 (skip_chars): Remove duplicate decl.
6175 * textprop.c (Fprevious_property_change): New forward static decl.
6176 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6177 Now internal.
6178 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6179 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6180
785bbd42
PE
6181 * editfns.c (Fformat): Remove unreachable code.
6182
8b913b57
AS
61832011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6184
6185 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6186 change. (Bug#8496)
6187
a6744a35
EZ
61882011-04-13 Eli Zaretskii <eliz@gnu.org>
6189
6190 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6191 when at ZV. (Bug#8487)
6192
e7974947
AS
61932011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6194
baad03f0
AS
6195 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6196 (Bug#8437)
6197 * keyboard.c (parse_tool_bar_item): Likewise.
6198 * sound.c (sound_cleanup, alsa_close): Likewise.
6199 * termcap.c (tgetent): Likewise.
6200 * xfns.c (x_default_font_parameter): Likewise.
6201 * xsettings.c (read_and_apply_settings): Likewise.
6202
e7974947
AS
6203 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6204 (overrun_check_free): Protoize.
6205
28272684
PE
62062011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6207
6208 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6209 since callers should never pass a negative size.
6210 Change the signature to match that of plain 'read' and 'write'; see
6211 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6212 * lisp.h: Update prototypes of emacs_write and emacs_read.
6213
11997c76
EZ
62142011-04-11 Eli Zaretskii <eliz@gnu.org>
6215
6216 * xdisp.c (redisplay_window): Don't try to determine the character
6217 position of the scroll margin if the window start point w->startp
e896f03c 6218 is outside the buffer's accessible region. (Bug#8468)
11997c76 6219
8a2cbd72
EZ
62202011-04-10 Eli Zaretskii <eliz@gnu.org>
6221
6222 Fix write-region and its subroutines for buffers > 2GB.
6223 * fileio.c (a_write, e_write): Modify declaration of arguments and
6224 local variables to support buffers larger than 2GB.
6225 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6226
6227 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6228 argument, local variables, and return value.
6229
6230 * lisp.h: Update prototypes of emacs_write and emacs_read.
6231
6232 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6233
4073e537 62342011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6235
1ebfdcb6
PE
6236 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6237
b2ded58d
PE
6238 Fix more problems found by GCC 4.6.0's static checks.
6239
7d66342c
PE
6240 * xdisp.c (vmessage): Use a better test for character truncation.
6241
bbf47d44
PE
6242 * charset.c (load_charset_map): <, not <=, for optimization,
6243 and to avoid potential problems with integer overflow.
9248994d 6244 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6245 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6246 * editfns.c (Fformat): Likewise.
1e69125e 6247 * syntax.c (skip_chars): Likewise.
3befa583 6248
e3019616
PE
6249 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6250 This also lets GCC 4.6.0 generate slightly better loop code.
6251
becfa255
PE
6252 * callint.c (Fcall_interactively): <, not <=, for optimization.
6253 (Fcall_interactively): Count the number of arguments produced,
6254 not the number of arguments given. This is simpler and lets GCC
6255 4.6.0 generate slightly better code.
6256
dae0cd48
PE
6257 * ftfont.c: Distingish more carefully between FcChar8 and char.
6258 The previous code passed unsigned char * to a functions like
6259 strlen and xstrcasecmp that expect char *, which does not
6260 conform to the C standard.
6261 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6262 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6263 char * when the C standard requires it.
6264
76032d70
PE
6265 * keyboard.c (read_char): Remove unused var.
6266
eb3f1cc8
PE
6267 * eval.c: Port to Windows vsnprintf (Bug#8435).
6268 Include <limits.h>.
6269 (SIZE_MAX): Define if the headers do not.
6270 (verror): Do not give up if vsnprintf returns a negative count.
6271 Instead, grow the buffer. This ports to Windows vsnprintf, which
6272 does not conform to C99. Problem reported by Eli Zaretskii.
6273 Also, simplify the allocation scheme, by avoiding the need for
6274 calling realloc, and removing the ALLOCATED variable.
6275
70476b54
PE
6276 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6277
12020a9e
PE
6278 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6279 But keep the doprint source code for now, as we might revamp it
6280 and use it again (Bug#8435).
ea6c7ae6
PE
6281 * lisp.h (doprnt): Remove.
6282 * Makefile.in (base_obj): Remove doprnt.o.
6283 * deps.mk (doprnt.o): Remove.
6284
5fdb398c
PE
6285 error: Print 32- and 64-bit integers portably (Bug#8435).
6286 Without this change, on typical 64-bit hosts error ("...%d...", N)
6287 was used to print both 32- and 64-bit integers N, which relied on
6288 undefined behavior.
6289 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6290 New macro.
6291 * lisp.h (error, verror): Mark as printf-like functions.
6292 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6293 Report overflow in size calculations when allocating printf buffer.
6294 Do not truncate output string at its first null byte.
6295 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6296 Truncate the output at a character boundary, since vsnprintf does not
6297 do that.
6298 * charset.c (check_iso_charset_parameter): Convert internal
6299 character to string before calling 'error', since %c now has the
6300 printf meaning.
6301 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6302 overflow when computing char to be passed to 'error'. Do not
6303 pass Lisp_Object to 'error'; pass the integer instead.
6304 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6305 formatted with plain %d.
6306
b189fa66
PE
6307 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6308
bff87ef0
PE
6309 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6310
7e2cac20
PE
6311 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6312
ce4d90b5
PE
6313 * xterm.c (x_catch_errors): Remove duplicate declaration.
6314
266c9547
PE
6315 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6316
79c49ad2
PE
6317 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6318
368f4090
JM
63192011-04-10 Jim Meyering <meyering@redhat.com>
6320
6321 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6322 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6323 return ssize_t not "int", and use size_t as the buffer length.
6324 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6325 * gnutls.h: Update declarations.
6326 * process.c (read_process_output): Use ssize_t, to match.
6327 (send_process): Likewise.
6328
a32d4040
CY
63292011-04-09 Chong Yidong <cyd@stupidchicken.com>
6330
6331 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6332
8546720e 63332011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6334
04f2d78b
CB
6335 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6336 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6337
8546720e
GM
6338 * xterm.c (handle_one_xevent):
6339 * xmenu.c (create_and_show_popup_menu):
6340 * xselect.c (x_decline_selection_request)
6341 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6342
0a2f5c1a 63432011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6344
6345 Fix some uses of `int' instead of EMACS_INT.
6346 * search.c (string_match_1, fast_string_match)
6347 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6348 (scan_buffer, find_next_newline_no_quit)
6349 (find_before_next_newline, search_command, Freplace_match)
6350 (Fmatch_data): Make some `int' variables be EMACS_INT.
6351
6352 * xdisp.c (display_count_lines): 3rd argument and return value now
6353 EMACS_INT. All callers changed.
6354 (pint2hrstr): Last argument is now EMACS_INT.
6355
6356 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6357 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6358 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6359 (decode_coding_utf_16, decode_coding_emacs_mule)
6360 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6361 (decode_coding_ccl, decode_coding_charset)
6362 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6363 (decode_coding_iso_2022, decode_coding_emacs_mule)
6364 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6365 <char_offset, last_offset>: Declare EMACS_INT.
6366 (encode_coding_utf_8, encode_coding_utf_16)
6367 (encode_coding_emacs_mule, encode_invocation_designation)
6368 (encode_designation_at_bol, encode_coding_iso_2022)
6369 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6370 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6371 Declare EMACS_INT.
6372 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6373 (encode_invocation_designation): Last argument P_NCHARS is now
6374 EMACS_INT.
6375 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6376 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6377
6378 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6379 All users changed.
6380
6381 * ccl.c (Fccl_execute_on_string): Declare some variables
6382 EMACS_INT.
6383
8546720e 63842011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6385
6386 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6387
4e19a977
CS
63882011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6389
6390 * process.c (Fformat_network_address): Doc fix.
6391
87302331
R
63922011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6393
6394 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6395
cbb59342
CY
63962011-04-08 Chong Yidong <cyd@stupidchicken.com>
6397
6398 * keyboard.c (read_char): Call Lisp function help-form-show,
6399 instead of using internal_with_output_to_temp_buffer.
6400 (Qhelp_form_show): New var.
e0d38eeb 6401 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6402
6403 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6404
6405 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6406
e67a13ab
CY
64072011-04-06 Chong Yidong <cyd@stupidchicken.com>
6408
04f2d78b
CB
6409 * process.c (Flist_processes): Remove to Lisp.
6410 (list_processes_1): Delete.
e67a13ab 6411
973f782d
EZ
64122011-04-06 Eli Zaretskii <eliz@gnu.org>
6413
7c106b1e
EZ
6414 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6415
973f782d
EZ
6416 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6417
41cf7d1a 64182011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6419
ca23cc88
PE
6420 Fix more problems found by GCC 4.6.0's static checks.
6421
f390e2d5
PE
6422 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6423
42eea0d0
PE
6424 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6425
b69769da 6426 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6427
f9541e84
PE
6428 * xdisp.c (vmessage): Mark as a printf-like function.
6429
13841b55
PE
6430 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6431
c136c10f
PE
6432 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6433
5e2d4a30
PE
6434 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6435 printf-like functions.
6436 (tiff_load): Add casts to remove these marks before passing them
6437 to system-supplied API.
6438
583f48b9
PE
6439 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6440
b25d760e
PE
6441 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6442 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6443 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6444 directly, rather than having caller test rule sign. This avoids
6445 some unnecessary tests.
6446 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6447 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6448 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6449
bc7b6697 6450 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6451 (xfont_open): Avoid unnecessary tests.
bc7b6697 6452
27ccc379
PE
6453 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6454
dcd5c89a
PE
6455 * composite.h, composite.c (composition_gstring_put_cache):
6456 Use EMACS_INT, not int, for length.
6457
b13a45c6
PE
6458 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6459 breaking out part of COMPOSITION_DECODE_RULE.
6460 (COMPOSITION_DECODE_RULE): Use it.
6461 * composite.c (get_composition_id): Remove unused local vars,
6462 by using the new macro.
6463
1e792e4d
PE
6464 * textprop.c (set_text_properties_1): Change while to do-while,
6465 since the condition is always true at first.
6466
dc6c6455 6467 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6468 (interval_deletion_adjustment): Return unsigned value.
6469 All uses changed.
dc6c6455 6470
aba7731a
PE
6471 * process.c (list_processes_1, create_pty, read_process_output):
6472 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6473 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6474 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6475 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6476 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6477
fdfc4bf3
PE
6478 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6479
fca8fe46 6480 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6481 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6482
06a0259a 6483 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6484 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6485 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6486
e7b9e80f
PE
6487 * print.c (print_error_message): Avoid int overflow.
6488
56201685
PE
6489 * font.c (font_list_entities): Redo for clarity,
6490 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6491
78834453 6492 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6493 (font_score): Avoid potential overflow in diff calculation.
78834453 6494
0bc0b309 6495 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6496 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6497
e610eaca
PE
6498 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6499
b895abce
PE
6500 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6501 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6502 can always succeed if overflow has undefined behavior.
6503
1f1d9321 6504 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6505 (wordify): Omit three unnecessary tests.
1f1d9321 6506
c59478bc
PE
6507 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6508 All callers changed. This avoids the need for an unused var.
6509
79b73827
PE
6510 * casefiddle.c (casify_region): Remove var that is set but not used.
6511
a4db5dfe
PE
6512 * dired.c (file_name_completion): Remove var that is set but not used.
6513
43aae36e
PE
6514 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6515
2a47c44d 6516 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6517 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6518
a37c69bf
PE
6519 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6520 Check for integer overflow on size calculations.
6521
328ab8e7
PE
6522 * buffer.c (Fprevious_overlay_change): Remove var that is set
6523 but not used.
6524
e5a2a5cb
PE
6525 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6526 Remove vars that are set but not used.
8d84a6eb 6527 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6528 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6529
a60e5f68
PE
6530 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6531
f661cb61 6532 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6533 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6534
f0397f5a
PE
6535 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6536 that are set but not used.
6537
8664db06 6538 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6539 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6540
6abdaa4a
PE
6541 * xselect.c (x_get_local_selection, x_handle_property_notify):
6542 Remove vars that are set but not used.
6543
0ce7538d 6544 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6545 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6546
9ae848fc
PE
6547 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6548 Remove var that is set but not used.
0b918413
PE
6549 (scroll_bar_windows_size): Now size_t, not int.
6550 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6551 Check for overflow.
9ae848fc 6552
a5a62657
PE
6553 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6554 (map_tty_color) [!defined MSDOS]: Likewise.
6555
5c5cdd39
PE
6556 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6557
66ebf983
PE
6558 * coding.c: Remove vars that are set but not used.
6559 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6560 All callers changed.
6561 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6562 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6563 (decode_coding_charset): Remove vars that are set but not used.
6564
1be4d761
PE
6565 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6566 that is set but not used.
6567
47553fa8
PE
6568 * print.c (print_object): Remove var that is set but not used.
6569
1f7196bf 6570 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6571 The gnulib version avoids calling malloc in the usual case,
6572 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6573 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6574 * filelock.c (current_lock_owner): Likewise.
6575 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6576 * sysdep.c: Include allocator.h, careadlinkat.h.
6577 (emacs_no_realloc_allocator): New static constant.
6578 (emacs_readlink): New function.
fdb61804
PE
6579 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6580 ../lib/careadlinkat.h.
d1fdcab7 6581
f84c17c7
SM
65822011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6583
6584 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6585 first non-nil return value).
6586
ef3862ad
JD
65872011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6588
6589 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6590 if not defined (Bug#8403).
6591
376a7006
JB
65922011-04-02 Juanma Barranquero <lekktu@gmail.com>
6593
6594 * xdisp.c (display_count_lines): Remove parameter `start',
6595 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6596 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6597 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6598 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6599 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6600 and thereabouts. All callers changed.
6601 (get_per_char_metric): Remove parameter `f', unused since
6602 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6603
6ca3801d
JM
66042011-04-02 Jim Meyering <meyering@redhat.com>
6605
6606 do not dereference NULL upon failed strdup
6607 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6608 (ns_get_family): Likewise.
6609
d8e2b5ba
JB
66102011-04-02 Juanma Barranquero <lekktu@gmail.com>
6611
6612 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6613
8c74fcbd
JD
66142011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6615
6616 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6617 later (Bug#8403).
6618
7200d79c
SM
66192011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6620
03408648 6621 Add lexical binding.
7200d79c 6622
03408648
SM
6623 * window.c (Ftemp_output_buffer_show): New fun.
6624 (Fsave_window_excursion):
6625 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6626
6627 * lread.c (lisp_file_lexically_bound_p): New function.
6628 (Fload): Bind Qlexical_binding.
6629 (readevalloop): Remove `evalfun' arg.
6630 Bind Qinternal_interpreter_environment.
6631 (Feval_buffer): Bind Qlexical_binding.
6632 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6633 Mark as dynamic.
6634 (syms_of_lread): Declare `lexical-binding'.
6635
6636 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6637
6638 * keyboard.c (eval_dyn): New fun.
6639 (menu_item_eval_property): Use it.
ca105506
SM
6640
6641 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6642
03408648
SM
6643 * fns.c (concat, mapcar1): Accept byte-code-functions.
6644
6645 * eval.c (Fsetq): Handle lexical vars.
6646 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6647 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6648 (FletX, Flet): Obey lexical binding.
6649 (Fcommandp): Handle closures.
6650 (Feval): New `lexical' arg.
6651 (eval_sub): New function extracted from Feval. Use it almost
6652 everywhere where Feval was used. Look up vars in lexical env.
6653 Handle closures.
6654 (Ffunctionp): Move from subr.el.
6655 (Ffuncall): Handle closures.
6656 (apply_lambda): Remove `eval_flags'.
6657 (funcall_lambda): Handle closures and new byte-code-functions.
6658 (Fspecial_variable_p): New function.
6659 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6660 but without exporting it to Lisp.
23aba0ea 6661
23aba0ea 6662 * doc.c (Fdocumentation, store_function_docstring):
03408648 6663 * data.c (Finteractive_form): Handle closures.
23aba0ea 6664
03408648
SM
6665 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6666 interactive spec.
ba83908c 6667
04f2d78b
CB
6668 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6669 New byte-codes.
03408648
SM
6670 (exec_byte_code): New function extracted from Fbyte_code to handle new
6671 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6672
03408648 6673 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6674
03408648 6675 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6676
e2abce01
JB
66772011-03-31 Juanma Barranquero <lekktu@gmail.com>
6678
6679 * xdisp.c (redisplay_internal): Fix prototype.
6680
63696a73 66812011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6682
63696a73 6683 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6684 (try_scrolling): Use it when setting scroll_limit.
6685 Limit scrolling to 100 screen lines.
63696a73
EZ
6686 (redisplay_window): Even when falling back on "recentering",
6687 position point in the window according to scroll-conservatively,
6688 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6689
6690 (try_scrolling): When point is above the window, allow searching
6691 as far as scroll_max, or one screenful, to compute vertical
6692 distance from PT to the scroll margin position. This prevents
6693 try_scrolling from unnecessarily failing when
6694 scroll-conservatively is set to a value slightly larger than the
6695 window height. Clean up the case of PT below the margin at bottom
6696 of window: scroll_max can no longer be INT_MAX. When aggressive
6697 scrolling is in use, don't let point enter the opposite scroll
6698 margin as result of the scroll.
6699 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6700 threshold of 100 lines for never-recentering scrolling.
6701
e4cc2dfc
JB
67022011-03-31 Juanma Barranquero <lekktu@gmail.com>
6703
6704 * dispextern.h (move_it_by_lines):
6705 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6706 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6707 (message_log_check_duplicate): Remove parameters `prev_bol' and
6708 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6709 (redisplay_internal): Remove parameter `preserve_echo_area',
6710 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6711
6712 * indent.c (Fvertical_motion):
6713 * window.c (window_scroll_pixel_based, Frecenter):
6714 Don't pass `need_y_p' to `move_it_by_lines'.
6715
1c470562
SM
67162011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6717
44f230aa
SM
6718 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6719 steal a few bits to be more compact.
6720 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6721 Remove unneeded casts.
6722
1c470562
SM
6723 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6724
888adce9
ZK
67252011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6726
6727 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6728 binding" message (bug#7967).
6729
f838ed7b
PE
67302011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6731
77861b95
PE
6732 Fix more problems found by GCC 4.6.0's static checks.
6733
de6dbc14
PE
6734 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6735 Remove unused local var.
6736
f838ed7b
PE
6737 * editfns.c (Fmessage_box): Remove unused local var.
6738
792c7b2b
PE
6739 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6740 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6741 Omit unused local vars.
c499e557 6742 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6743 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6744 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6745 Omit unused local var.
6746
ba0165e1
PE
6747 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6748 Don't assume string length fits in int.
32ad8845 6749 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6750 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6751
3c59b4c9
PE
6752 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6753 instead of alloca (Bug#8344).
6754
a3eed478 6755 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6756 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6757
eb4d412d
PE
6758 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6759
1658b401
PE
6760 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6761 concerns.
6762
6763 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6764
6765 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6766
9a2c6e05
PE
6767 * keyboard.c (syms_of_keyboard): Use the same style as later
6768 in this function when indexing through an array. This also
6769 works around GCC bug 48267.
6770
03d0a109
PE
6771 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6772
44f730c8
PE
6773 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6774
fe75f926
PE
6775 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6776 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6777
ffa8c828
PE
6778 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6779 This avoids undefined behavior on integer overflow, and is a bit
6780 more convenient anyway since it is compared to a size_t variable.
6781
c5101a77
PE
6782 Variadic C functions now count arguments with size_t, not int.
6783 This avoids an unnecessary limitation on 64-bit machines, which
6784 caused (substring ...) to crash on large vectors (Bug#8344).
6785 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6786 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6787 All variadic functions and their callers changed accordingly.
c5101a77
PE
6788 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6789 * data.c (arith_driver, float_arith_driver): Likewise.
6790 * editfns.c (general_insert_function): Likewise.
6791 * eval.c (struct backtrace.nargs, interactive_p)
6792 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6793 (funcall_lambda, mark_backtrace): Likewise.
6794 * fns.c (concat): Likewise.
6795 * frame.c (x_set_frame_parameters): Likewise.
6796 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6797 0 if not found, not -1. All callers changed.
6798
dd3f25f7
PE
6799 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6800 (stack_copy_size): Now size_t, not int.
6801 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6802
461c2ab9
JB
68032011-03-28 Juanma Barranquero <lekktu@gmail.com>
6804
6805 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6806 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6807 All callers changed.
6808
6809 * lisp.h (multibyte_char_to_unibyte):
6810 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6811 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6812 * character.h (CHAR_TO_BYTE8):
6813 * cmds.c (internal_self_insert):
6814 * editfns.c (general_insert_function):
6815 * keymap.c (push_key_description):
6816 * search.c (Freplace_match):
6817 * xdisp.c (message_dolog, set_message_1): All callers changed.
6818
f6d62986
SM
68192011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6820
6821 * keyboard.c (safe_run_hook_funcall): New function.
6822 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6823 don't set the hook to nil, but remove the offending function instead.
6824 (Qcommand_hook_internal): Remove, unused.
6825 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6826 Vcommand_hook_internal.
6827
6828 * eval.c (enum run_hooks_condition): Remove.
6829 (funcall_nil, funcall_not): New functions.
6830 (run_hook_with_args): Call each function through a `funcall' argument.
6831 Remove `cond' argument, now redundant.
6832 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6833 (Frun_hook_with_args_until_failure): Adjust accordingly.
6834 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6835
1db5b1ad
JB
68362011-03-28 Juanma Barranquero <lekktu@gmail.com>
6837
6838 * dispextern.h (string_buffer_position): Remove declaration.
6839
6840 * print.c (strout): Remove parameter `multibyte', unused since
6841 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6842
6843 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6844 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6845 All callers changed.
6846
6847 * w32.c (_wsa_errlist): Use braces for struct initializers.
6848
6849 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6850 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6851 All callers changed.
6852 (string_buffer_position): Likewise. Also, make static (it's never
6853 used outside xdisp.c).
6854 (cursor_row_p): Remove parameter `w', unused since
6855 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6856 (decode_mode_spec): Remove parameter `precision', introduced during
6857 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6858 All callers changed.
6859
5ffb62aa
JD
68602011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6861
6862 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6863
461c2ab9 68642011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6865
6866 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6867 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6868 (ns_update_auto_hide_menu_bar): New functions.
6869 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6870 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6871 ns_constrain_all_frames.
6872 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6873 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6874
5c380ffb
JD
68752011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6876
6877 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6878
9af30bdf
GM
68792011-03-27 Glenn Morris <rgm@gnu.org>
6880
6881 * syssignal.h: Replace RETSIGTYPE with void.
6882 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6883 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6884 Replace SIGTYPE with void everywhere.
6885 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6886 * s/template.h (SIGTYPE): Remove commented out definition.
6887
e2abce01
JB
68882011-03-26 Eli Zaretskii <eliz@gnu.org>
6889
6890 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6891 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6892
f868cd8a
JB
68932011-03-26 Juanma Barranquero <lekktu@gmail.com>
6894
59eb0929
JB
6895 * w32.c (read_unc_volume): Use parameter `henum', instead of
6896 global variable `wget_enum_handle'.
6897
6898 * keymap.c (describe_vector): Remove parameters `indices' and
6899 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6900 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6901
f868cd8a
JB
6902 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6903
6904 * keyboard.c (timer_check): Remove parameter `do_it_now',
6905 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6906 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6907 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6908
6909 * keyboard.c (read_char):
6910 * w32menu.c (w32_menu_display_help):
6911 * xmenu.c (show_help_event, menu_help_callback):
6912 Adjust calls to `show_help_echo'.
6913
6914 * gtkutil.c (xg_maybe_add_timer):
6915 * keyboard.c (readable_events):
6916 * process.c (wait_reading_process_output):
6917 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6918
6919 * insdel.c (adjust_markers_gap_motion):
6920 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6921 (gap_left, gap_right): Don't call it.
6922
2ecf6fdb
CY
69232011-03-25 Chong Yidong <cyd@stupidchicken.com>
6924
6925 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6926 incurred during fontification.
6927
6b1f9ba4
JB
69282011-03-25 Juanma Barranquero <lekktu@gmail.com>
6929
6930 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6931 (DEFVAR_PER_BUFFER): Don't pass it.
6932
6933 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6934 (scrolling_window): Don't pass it.
6935
0f4a96b5
JB
69362011-03-25 Juanma Barranquero <lekktu@gmail.com>
6937
6938 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6939
6940 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6941 and `suffix'.
6942 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6943 of variables specific to SELinux and computation of `encoded_absname'.
6944
6945 * image.c (XPutPixel): Remove unused variable `height'.
6946
6947 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6948
6949 * unexw32.c (get_section_info): Remove unused variable `section'.
6950
6951 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6952 (system_process_attributes): Remove unused variable `sess'.
6953 (sys_read): Remove unused variable `err'.
6954
6955 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6956 (w32_wnd_proc): Remove unused variable `isdead'.
6957 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6958 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6959 (x_create_tip_frame): Remove unused variable `tem'.
6960
6961 * w32inevt.c (w32_console_read_socket):
6962 Remove unused variable `no_events'.
6963
6964 * w32term.c (x_draw_composite_glyph_string_foreground):
6965 Remove unused variable `width'.
6966
1149507c
JB
69672011-03-24 Juanma Barranquero <lekktu@gmail.com>
6968
6969 * w32term.c (x_set_glyph_string_clipping):
6970 Don't pass uninitialized region to CombineRgn.
6971
9c88f339
JB
69722011-03-23 Juanma Barranquero <lekktu@gmail.com>
6973
6974 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6975 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6976 (Fx_close_connection): Remove unused variable `i'.
6977
6978 * w32font.c (w32font_draw): Return number of glyphs.
6979 (w32font_open_internal): Remove unused variable `i'.
6980 (w32font_driver): Add missing initializer.
6981
6982 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6983 (fill_in_menu): Remove unused variable `items_added'.
6984
6985 * w32term.c (last_mouse_press_frame): Remove static global variable.
6986 (w32_clip_to_row): Remove unused variable `f'.
6987 (x_delete_terminal): Remove unused variable `i'.
6988
6989 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6990 (NOTHING): Remove unused static global variable.
6991 (uniscribe_check_otf): Remove unused variable `table'.
6992 (uniscribe_font_driver): Add missing initializers.
6993
dee091a3
JD
69942011-03-23 Julien Danjou <julien@danjou.info>
6995
6996 * term.c (Fsuspend_tty, Fresume_tty):
6997 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6998 * window.c (temp_output_buffer_show):
6999 * insdel.c (signal_before_change):
7000 * frame.c (Fhandle_switch_frame):
7001 * fileio.c (Fdo_auto_save):
7002 * emacs.c (Fkill_emacs):
7003 * editfns.c (save_excursion_restore):
7004 * cmds.c (internal_self_insert):
7005 * callint.c (Fcall_interactively):
7006 * buffer.c (Fkill_all_local_variables):
7007 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7008 Use Frun_hooks.
0f4a96b5 7009 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7010 unconditionnaly since it does the check itself.
7011
2c520ab5 70122011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7013
c9c49752
PE
7014 Fix more problems found by GCC 4.5.2's static checks.
7015
8abc3f12
PE
7016 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7017 the first time through the loop, since we know p0 < p1 then.
7018 This also avoids a gcc -Wstrict-overflow warning.
7019
a2d26660
PE
7020 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7021 leading to a memory leak, possible in functions like
7022 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7023 of objects (Bug#8318).
a2d26660 7024
916c72e9
PE
7025 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7026 that could (at least in theory) be that large.
7027
19ab8a18
PE
7028 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7029 This is less likely to overflow, and avoids undefined behavior if
7030 overflow does occur. All callers changed. Use strtoul to scan
7031 for the unsigned long integer.
b7cbbd6f
PE
7032 (pint2hrstr): Simplify and tune code slightly.
7033 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7034
f0641eff
PE
7035 * scroll.c (do_scrolling): Work around GCC bug 48228.
7036 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7037
7f650bb9
PE
7038 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7039 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7040 (validate_x_resource_name): Simplify count usage.
7041 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7042
37dd57d1
PE
7043 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7044 fail (Bug#8306).
81e56e61 7045
699979fc 7046 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7047
401bf9b4
PE
7048 * process.c (Fmake_network_process): Use socklen_t, not int,
7049 where POSIX says socklen_t is required in portable programs.
7050 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7051 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7052 (Fmake_network_process, server_accept_connection):
7053 (wait_reading_process_output, read_process_output):
7054 Likewise.
7055
b93aacde
PE
7056 * process.c: Rename or move locals to avoid shadowing.
7057 (list_processes_1, Fmake_network_process):
7058 (read_process_output_error_handler, exec_sentinel_error_handler):
7059 Rename or move locals.
4dc343ee 7060 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7061 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7062 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7063 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7064 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7065
af8a867c 7066 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7067 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7068 Include tparam.h instead, since it declares them.
af8a867c
PE
7069 * cm.h (PC): Remove extern decl; tparam.h now does this.
7070 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7071 * terminfo.c: Include tparam.h, to check interfaces.
7072 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7073 (tparam): Adjust signature to match interface in tparam.h;
7074 this removes some undefined behavior. Check that outstring and len
7075 are zero, which they always are with Emacs.
7076 * tparam.h (PC, BC, UP): New extern decls.
7077
0248044d 7078 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7079 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7080
8ff096c1 7081 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7082 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7083 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7084 (ftfont_list): Remove unused local.
49eaafba
PE
7085 (get_adstyle_property, ftfont_pattern_entity):
7086 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7087 Rename locals to avoid shadowing.
8ff096c1 7088
e2be39f6
PE
7089 * xfont.c (xfont_list_family): Mark var as initialized.
7090
c9735e30
PE
7091 * xml.c (make_dom): Now static.
7092
8f5201ae
PE
7093 * composite.c (composition_compute_stop_pos): Rename local to
7094 avoid shadowing.
b246f932
PE
7095 (composition_reseat_it): Remove unused locals.
7096 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7097 (composition_update_it): Mark var as initialized.
11b61122
PE
7098 (find_automatic_composition): Mark vars as initialized,
7099 with a FIXME (Bug#8290).
8f5201ae 7100
760fbc2c
PE
7101 character.h: Rename locals to avoid shadowing.
7102 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7103 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7104 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7105 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7106 to avoid shadowing.
7107
ff08eb85
PE
7108 * textprop.c (property_change_between_p): Remove; unused.
7109
fc7bf025
PE
7110 * intervals.c (interval_start_pos): Now static.
7111
235d7abc
PE
7112 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7113
44f230aa
SM
7114 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7115 Rename locals to avoid shadowing.
3e7d6594 7116
50060332
PE
7117 * sound.c (wav_play, au_play, Fplay_sound_internal):
7118 Fix pointer signedness.
d01f234b 7119 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7120 (wav_play): Initialize a variable to 0, to prevent undefined
7121 behavior (Bug#8278).
50060332 7122
c4fc4e30
PE
7123 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7124
918436ed
PE
7125 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7126
c939f91b
PE
7127 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7128 clobbering (Bug#8298).
b9c7f648
PE
7129 * sysdep.c (sys_subshell): Likewise.
7130 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7131
6bd8c144
PE
7132 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7133 This should get cleaned up, so that child_setup has the
7134 same signature on all platforms.
7135
7710357c 7136 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7137 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7138
c59da222
CY
71392011-03-22 Chong Yidong <cyd@stupidchicken.com>
7140
7141 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7142 not to be necessary, and produces flickering.
7143
66b87493
GM
71442011-03-20 Glenn Morris <rgm@gnu.org>
7145
7146 * config.in: Remove file.
7147
45b6f6d5
JB
71482011-03-20 Juanma Barranquero <lekktu@gmail.com>
7149
7150 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7151 are now in src/globals.h.
7152 (syms_of_minibuf): Remove spurious & from previous change.
7153
3ec03f7e
LL
71542011-03-20 Leo <sdl.web@gmail.com>
7155
7156 * minibuf.c (completing-read-function): New variable.
7157 (completing-read-default): Rename from completing-read.
7158 (completing-read): Call completing-read-function.
7159
b14e3e21
CY
71602011-03-19 Juanma Barranquero <lekktu@gmail.com>
7161
7162 * xfaces.c (Fx_load_color_file):
7163 Read color file from absolute filename (bug#8250).
7164
f2b726e6
JB
71652011-03-19 Juanma Barranquero <lekktu@gmail.com>
7166
7167 * makefile.w32-in: Update dependencies.
7168
09f6ff02
EZ
71692011-03-17 Eli Zaretskii <eliz@gnu.org>
7170
7171 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7172
29a6015a
PE
71732011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7174
a3a6c54e
PE
7175 Fix more problems found by GCC 4.5.2's static checks.
7176
b766f867
PE
7177 * process.c (make_serial_process_unwind, send_process_trap):
7178 (sigchld_handler): Now static.
7179
be02381c
PE
7180 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7181 That way, the code declares only the vars that it needs.
7182 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7183 * s/cygwin.h (PTY_ITERATION): Likewise.
7184 * s/darwin.h (PTY_ITERATION): Likewise.
7185 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7186
57048744
PE
7187 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7188 * process.c (allocate_pty): Don't declare stb unless it's needed.
7189
7914961c 7190 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7191 (CONSTANTLIM): Remove; unused.
7192 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7193 Define only if needed.
7914961c 7194
b3967b18
PE
7195 * unexelf.c (unexec): Name an expression,
7196 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7197 Use a different way to cause a compilation error if anyone uses
7198 n rather than nn, a way that does not involve shadowing.
73366a00 7199 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7200
29a6015a
PE
7201 * deps.mk (unexalpha.o): Remove; unused.
7202
43cfc33e 7203 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7204 * unexec.h: New file.
ce701a33
PE
7205 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7206 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7207 Depend on unexec.h.
7208 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7209 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7210 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7211 Change as necessary to match prototype in unexec.h.
ce701a33 7212
01f44d5a
PE
7213 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7214 shadowing.
4f63c6bb 7215 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7216
a6670b0b
PE
7217 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7218 Rename locals to avoid shadowing.
7219
cef2010d 7220 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7221 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7222
d4d7173a
PE
7223 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7224
f08b802a
PE
7225 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7226 warning when compiling print.c.
7227
3ddb0639
PE
7228 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7229 instead of using an uninitialized var.
5ad03b97 7230 (font_sort_entities): Mark var as initialized.
3ddb0639 7231
170a2692
PE
7232 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7233
e663c700
PE
7234 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7235 pointers to constants.
89bc529a 7236 (font_parse_fcname): Remove unused vars.
7b81e2d0 7237 (font_delete_unmatched): Now static.
ea838e10 7238 (font_get_spec): Remove; unused.
13a547c6
PE
7239 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7240 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7241 Rename or move locals to avoid shadowing.
e663c700 7242
2a80c887 7243 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7244 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7245
1384fa33 7246 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7247 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7248
8b2c52e9
PE
7249 * alloc.c (mark_backtrace): Move decl from here ...
7250 * lisp.h: ... to here, so that it can be checked.
7251
475545b5 7252 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7253 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7254 (lisp_indirect_variable): Name an expression,
7255 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7256 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7257
b1349114 7258 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7259 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7260 Use const pointer when appropriate.
b1349114 7261
a2928364
PE
7262 * lisp.h (get_system_name, get_operating_system_release):
7263 Move decls here, to check interfaces.
7264 * process.c (get_operating_system_release): Move decl to lisp.h.
7265 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7266 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7267 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7268 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7269 (Fformat_time_string, Fencode_time, Finsert_char):
7270 (Ftranslate_region_internal, Fformat):
7271 Rename or remove local vars to avoid shadowing.
9710023e 7272 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7273
a415e694
PE
7274 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7275 avoid shadowing.
7276
8ef4622d
PE
7277 * lisp.h (eassert): Check that the argument compiles, even if
7278 ENABLE_CHECKING is not defined.
7279
946f9a5b
PE
7280 * data.c (Findirect_variable): Name an expression, to avoid
7281 gcc -Wbad-function-cast warning.
112396d6 7282 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7283 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7284 (Fmake_variable_buffer_local, Fmake_local_variable):
7285 Mark variables as initialized.
52746918 7286 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7287
e5aab7e7 7288 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7289 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7290 Rename locals to avoid shadowing.
dff45157
PE
7291 (mark_stack): Move local variables into the #ifdef region where
7292 they're used.
7bc26fdb
PE
7293 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7294 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7295 needed otherwise.
7296 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7297 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7298 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7299
e5aab7e7
PE
7300 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7301 avoids undefined behavior in theory.
7302
4da60324
PE
7303 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7304
88043301
PE
7305 Use functions, not macros, for up- and down-casing (Bug#8254).
7306 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7307 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7308 to use the following functions instead of these macros.
7309 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7310 EMACS_INT, since callers assume the returned value fits in int.
7311 (upcase1): Likewise, for UPCASE_TABLE.
7312 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7313 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7314 the race-condition problem in the old DOWNCASE.
88043301 7315
19ed5445
PE
7316 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7317 Rename locals to avoid shadowing.
7318 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7319 (regex_compile, re_search_2, re_match_2_internal):
7320 Remove unused local vars.
952db0d7
PE
7321 (FREE_VAR): Rewrite so as not to use empty "else",
7322 which gcc can warn about.
da053e48 7323 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7324 (RETALLOC_IF): Define only if needed.
7325 (WORDCHAR_P): Likewise. This one is never needed, but is used
7326 only in a comment talking about a compiler bug, so put inside
7327 the #if 0 of that comment.
7328 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7329 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7330 Remove; unused.
19ed5445 7331
1f3561e4 7332 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7333 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7334 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7335
ded6f8f7
PE
7336 * search.c (simple_search): Remove unused var.
7337
dbd37a95
PE
7338 * dired.c (compile_pattern): Move decl from here ...
7339 * lisp.h: ... to here, so that it can be checked.
7340 (struct re_registers): New forward decl.
7341
7e47afad
PE
7342 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7343
85f24f61
PE
7344 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7345 All uses changed.
7346 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7347 Rename locals to avoid shadowing.
5671df8f 7348 (Fvertical_motion): Mark locals as initialized.
85f24f61 7349
181aa2be 7350 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7351 (casify_region): Mark local as initialized.
181aa2be 7352
930d429c
PE
7353 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7354
7082eac6
PE
7355 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7356 New macros, so that the caller can use some names other than
7357 gcpro1, gcpro2, etc.
7358 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7359 of the new macros.
7360 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7361 argument, for consistency with GCPRO2_VAR, etc: it is now the
7362 prefix of the variable, not the variable itself. All uses
7363 changed.
38b2c076
PE
7364 * dired.c (directory_files_internal, file_name_completion):
7365 Rename locals to avoid shadowing.
7366
15206ed9
PE
7367 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7368 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7369 dired.c's scmp function, had undefined behavior.
7370 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7371 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7372 * buffer.h: ... to here, because these macros use current_buffer,
7373 and the new implementation with inline functions needs to have
7374 current_buffer in scope now, rather than later when the macros
7375 are used.
7376 (downcase, upcase1): New static inline functions.
7377 (DOWNCASE, UPCASE1): Reimplement using these functions.
7378 This avoids undefined behavior in expressions like
7379 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7380 from race conditions in accessing the global variables
7381 case_temp1 and case_temp2.
7382 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7383 * lisp.h (case_temp1, case_temp2): Remove their decls.
7384 * character.h (ASCII_CHAR_P): Move from here ...
7385 * lisp.h: ... to here, so that the inline functions mentioned
7386 above can use them.
7387
4a6bea26
PE
7388 * dired.c (directory_files_internal_unwind): Now static.
7389
f14b7e14
PE
7390 * fileio.c (file_name_as_directory, directory_file_name):
7391 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7392 Now static.
2893f146
PE
7393 (file_name_as_directory): Use const pointers when appropriate.
7394 (Fexpand_file_name): Likewise. In particular, newdir might
7395 point at constant storage, so make it a const pointer.
fd4ead52 7396 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7397 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7398 signedness issues.
f839df0c
PE
7399 (Fset_file_times, Finsert_file_contents, auto_save_error):
7400 Rename locals to avoid shadowing.
f14b7e14 7401
5716756e 7402 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7403 (Ftry_completion, Fall_completions): Rename or remove locals
7404 to avoid shadowing.
5716756e 7405
b4c3046a
PE
7406 * marker.c (bytepos_to_charpos): Remove; unused.
7407
b45db522
PE
7408 * lisp.h (verify_bytepos, count_markers): New decls,
7409 so that gcc does not warn that these functions aren't declared.
7410
85876d07
PE
7411 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7412 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7413 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7414 (copy_text): Remove unused local var.
85876d07 7415
03d78a21 7416 * filelock.c (within_one_second): Now static.
b3dd38ab 7417 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7418
5df8f01b
PE
7419 * buffer.c (fix_overlays_before): Mark locals as initialized.
7420 (fix_start_end_in_overlays): Likewise. This function should be
7421 simplified by using pointers-to-pointers, but that's a different
7422 matter.
b1d876f1 7423 (switch_to_buffer_1): Now static.
8f54f30a
PE
7424 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7425 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7426
a70072c9 7427 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7428 Fix pointer signedness issue.
edced198
PE
7429 (sys_subshell): Mark local as volatile if checking for lint,
7430 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7431 (MAXPATHLEN): Define only if needed.
a70072c9 7432
a0977c44
PE
7433 * process.c (serial_open, serial_configure): Move decls from here ...
7434 * systty.h: ... to here, so that they can be checked.
7435
a884fdcc
PE
7436 * fns.c (get_random, seed_random): Move extern decls from here ...
7437 * lisp.h: ... to here, so that they can be checked.
7438
604efe86 7439 * sysdep.c (reset_io): Now static.
b8950c94 7440 (wait_for_termination_signal): Remove; unused.
604efe86 7441
38fc62d9
PE
7442 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7443 (copy_keymap_item, append_key, push_text_char_description):
7444 Now static.
1004a21a 7445 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7446 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7447 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7448 (describe_map_tree):
7449 Rename locals to avoid shadowing.
38fc62d9 7450
2f2650da
PE
7451 * keyboard.c: Declare functions static if they are not used elsewhere.
7452 (echo_char, echo_dash, cmd_error, top_level_2):
7453 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7454 (read_char, kbd_buffer_get_event, make_lispy_position):
7455 (make_lispy_event, make_lispy_movement, apply_modifiers):
7456 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7457 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7458 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7459 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7460 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7461
a053e86c 7462 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7463 (mark_kboards): Move decl here ...
7464 * alloc.c (mark_kboards): ... from here.
a053e86c 7465
4752793e
PE
7466 * lisp.h (force_auto_save_soon): New decl.
7467
74f10ca7 7468 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7469 (DEFINE_DUMMY_FUNCTION): New macro.
7470 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7471 Use it.
c03cd23f
PE
7472 (main): Add casts to avoid warnings
7473 if GCC considers string literals to be constants.
74f10ca7 7474
022e70d4
PE
7475 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7476
59d6fe83
PE
7477 * dbusbind.c: Pointer signedness fixes.
7478 (xd_signature, xd_append_arg, xd_initialize):
7479 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7480 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7481 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7482 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7483
78320123
PE
7484 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7485 if GCC considers string literals to be constants.
49cebcca 7486 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7487
35ac2a97
SM
74882011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7489
fb103ca9
SM
7490 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7491 (print_preprocess, print_object): New macro to fix last change.
7492
35ac2a97
SM
7493 * print.c (print_preprocess): Don't forget font objects.
7494
62973b41
JB
74952011-03-16 Juanma Barranquero <lekktu@gmail.com>
7496
7497 * emacs.c (USAGE3): Doc fixes.
7498
0e48bb22
AS
74992011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7500
7501 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7502 structure.
7503
7684e57b
JB
75042011-03-14 Juanma Barranquero <lekktu@gmail.com>
7505
7506 * lisp.h (VWindow_system, Qfile_name_history):
7507 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7508 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7509 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7510
7511 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7512 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7513
7514 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7515 * w32console.c (detect_input_pending, read_input_pending)
7516 (encode_terminal_code):
7517 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7518 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7519 (w32_system_caret_y, Qfile_name_history):
7520 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7521 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7522 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7523 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7524 * w32proc.c (Qlocal, report_file_error):
7525 * w32term.c (Vwindow_system, updating_frame):
7526 * w32uniscribe.c (initialized, uniscribe_font_driver):
7527 Remove unneeded extern declarations.
7528
2aa46d6c
CY
75292011-03-14 Chong Yidong <cyd@stupidchicken.com>
7530
c96bbc66 7531 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7532
cffc6f3b
CY
75332011-03-13 Chong Yidong <cyd@stupidchicken.com>
7534
7535 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7536 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7537 These macros can no longer be used for assignment.
7538
44f230aa
SM
7539 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7540 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7541 (record_buffer_markers, fetch_buffer_markers): New functions for
7542 recording and fetching special buffer markers.
7543 (set_buffer_internal_1, set_buffer_temp): Use them.
7544
7545 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7546
7547 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7548
7549 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7550 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7551
7552 * xdisp.c (hscroll_window_tree):
7553 (reconsider_clip_changes): Use PT instead of BUF_PT.
7554
d251f04b
EZ
75552011-03-13 Eli Zaretskii <eliz@gnu.org>
7556
7557 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7558 $(EMACS_ROOT)/lib/intprops.h.
7559
f0c77cd1
PE
75602011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7561
3eca4629
PE
7562 Fix more problems found by GCC 4.5.2's static checks.
7563
7c86ee98
PE
7564 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7565 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7566 (xg_free_frame_widgets): Make it clear that a local variable is
7567 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7568 (gdk_window_get_screen): Make it clear that this macro is needed
7569 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7570 (int_gtk_range_get_value): New function, which avoids a diagnostic
7571 from gcc -Wbad-function-cast.
7572 (xg_set_toolkit_scroll_bar_thumb): Use it.
7573 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7574 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7575 (get_utf8_string, xg_get_file_with_chooser):
7576 Rename locals to avoid shadowing.
7577 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7578
41729b81
PE
7579 * xgselect.c (xg_select): Remove unused var.
7580
f0c77cd1
PE
7581 * image.c (four_corners_best): Mark locals as initialized.
7582 (gif_load): Initialize transparent_p to zero (Bug#8238).
7583 Mark another local as initialized.
ec6cf4c6 7584 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7585
ce0ad53d 7586 * image.c (clear_image_cache): Now static.
d5d5a617 7587 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7588 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7589 (x_edge_detection): Remove unnecessary cast that
7590 gcc -Wbad-function-cast diagnoses.
2037898d 7591 (gif_load): Fix pointer signedness.
6ae141d6
PE
7592 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7593 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7594
33383987 75952011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7596
d32df629
PE
7597 Improve quality of tests for time stamp overflow.
7598 For example, without this patch (encode-time 0 0 0 1 1
7599 1152921504606846976) returns the obviously-bogus value (-948597
7600 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7601 reports time overflow. See
7602 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7603 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7604 * editfns.c: Include limits.h and intprops.h.
7605 (TIME_T_MIN, TIME_T_MAX): New macros.
7606 (time_overflow): Move earlier, to before first use.
7607 (hi_time, lo_time): New functions, for an accurate test for
7608 out-of-range times.
7609 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7610 (Fget_internal_run_time): Don't assume time_t fits in int.
7611 (make_time): Use list2 instead of Fcons twice.
7612 (Fdecode_time): More accurate test for out-of-range times.
7613 (check_tm_member): New function.
7614 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7615 (lisp_time_argument): Don't rely on undefined left-shift and
7616 right-shift behavior when checking for time stamp overflow.
8be6f318 7617
fe31d94c
PE
7618 * editfns.c (time_overflow): New function, refactoring common code.
7619 (Fformat_time_string, Fdecode_time, Fencode_time):
7620 (Fcurrent_time_string): Use it.
7621
8be6f318
PE
7622 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7623 * dired.c (make_time): Move to ...
7624 * editfns.c (make_time): ... here.
7625 * systime.h: Note the move.
7626
09d9db2c 76272011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7628
126bc0dc
YM
7629 * fringe.c (update_window_fringes): Remove unused variables.
7630
c47cbdfd
YM
7631 * unexmacosx.c (copy_data_segment): Also copy __got section.
7632 (Bug#8223)
7633
7ac80be9
EZ
76342011-03-12 Eli Zaretskii <eliz@gnu.org>
7635
c96bbc66 7636 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7637 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7638 Constify `char *' arguments and their references according to
7639 prototypes in tparam.h.
7640
ecb0f94d 7641 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7642
7ac80be9
EZ
7643 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7644 Adapt all references accordingly.
7645
7646 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7647
ef1fd07e
TT
76482011-03-11 Tom Tromey <tromey@redhat.com>
7649
7650 * buffer.c (syms_of_buffer): Remove obsolete comment.
7651
7ef4b50c
EZ
76522011-03-11 Eli Zaretskii <eliz@gnu.org>
7653
7654 * termhooks.h (encode_terminal_code): Declare prototype.
7655
7656 * msdos.c (encode_terminal_code): Don't declare prototype.
7657
7658 * term.c (encode_terminal_code): Now external again, used by
7659 w32console.c and msdos.c.
7660
44f230aa
SM
7661 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7662 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7663
4b1ec863 76642011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7665
1714f52b 7666 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7667
4b1ec863
PE
7668 * fringe.c (update_window_fringes): Mark locals as initialized
7669 (Bug#8227).
7670 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7671
524c7aa6
PE
7672 * alloc.c (mark_fringe_data): Move decl from here ...
7673 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7674 to check its interface.
7675 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7676
a5c0af81 7677 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7678 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7679 (fontset_font): Mark local as initialized.
a9a06e0b 7680 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7681
b4716021
PE
7682 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7683
811e9bac 7684 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7685 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7686 (x_own_selection, Fx_disown_selection_internal): Rename locals
7687 to avoid shadowing.
7688 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7689
7e3ab302
PE
7690 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7691 so that the caller can use some name other than gcpro1.
7692 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7693 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7694 (Fx_backspace_delete_keys_p):
7695 Use them to avoid shadowing, and rename vars to avoid shadowing.
7696 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7697 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7698 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7699 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7700 Remove unused locals.
7e3ab302
PE
7701 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7702 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7703 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7704 macros.
f78faa98 7705
e2b13473
PE
7706 * xterm.h (x_mouse_leave): New decl.
7707
77f23912
PE
7708 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7709 Remove unused functions.
cdf4ba58
PE
7710 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7711 (x_calc_absolute_position): Now static.
7411c686 7712 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7713 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7714 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7715 unless they are used.
38d0b34a
PE
7716 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7717 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7718 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7719 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7720 (x_error_catcher, x_connection_closed, x_error_handler):
7721 (x_error_quitter, xembed_send_message, x_iconify_frame):
7722 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7723 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7724 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7725
44f230aa
SM
7726 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7727 Rename or move locals to avoid shadowing.
6b463e58 7728 (tty_defined_color, merge_face_heights): Now static.
5967d051 7729 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7730 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7731 does not deduce is never used uninitialized.
73719eba
PE
7732 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7733 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7734
426994c3 7735 * terminal.c (store_terminal_param): Now static.
5489860b 7736
032f1620 7737 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7738 (set_frame_menubar): Remove unused local.
d4323972 7739 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7740 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7741 since they might point to immutable storage.
281585b0
PE
7742 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7743 since it's unused otherwise.
032f1620 7744
367c19e5 7745 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7746 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7747 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7748 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7749 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7750 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7751 does not deduce are never used uninitialized.
70739cbe 7752
07b48fa9
PE
7753 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7754
8868a238 7755 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7756 * window.c (window_loop, size_window):
7757 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7758
7e5cf297 7759 * window.c (display_buffer): Now static.
d6550a9f
PE
7760 (size_window): Mark variables that gcc -Wuninitialized
7761 does not deduce are never used uninitialized.
a586633d
PE
7762 * window.h (check_all_windows): New decl, to forestall
7763 gcc -Wmissing-prototypes diagnostic.
5b555da1 7764 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7765
f6095868
PE
7766 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7767 shadowing.
7768 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7769 Include <limits.h>.
7770 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7771 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7772 (load_charset_map): Mark variables that gcc -Wuninitialized
7773 does not deduce are never used uninitialized.
53df7c11 7774 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7775
f38b440c
PE
7776 * coding.c (coding_set_source, coding_set_destination):
7777 Use "else { /* comment */ }" rather than "else /* comment */;"
7778 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7779 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7780 a block, when the outer 'i' will do.
7781 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7782 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7783 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7784 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7785 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7786 Rename locals to avoid shadowing.
7787 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7788 * coding.c (emacs_mule_char, encode_invocation_designation):
7789 Now static, since they're not used elsewhere.
413bb2db 7790 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7791 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7792 (decode_coding_emacs_mule): Mark variables that gcc
7793 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7794 (detect_coding_iso_2022): Initialize a local variable that might
7795 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7796 this initialization is needed. (Bug#8211)
5f58e762
PE
7797 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7798 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7799 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7800 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7801 Remove unused macros.
f38b440c 7802
232b38b9 7803 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7804 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7805 * character.c (string_count_byte8): Likewise.
232b38b9 7806
fb90da1b
PE
7807 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7808 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7809
fb93dbc2
PE
7810 * chartab.c (copy_sub_char_table): Now static, since it's not used
7811 elsewhere.
5c156ace
PE
7812 (sub_char_table_ref_and_range, char_table_ref_and_range):
7813 Rename locals to avoid shadowing.
bbcd0949 7814 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7815
7d3b3862 7816 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7817 (BIDI_BOB): Remove unused macro.
7d3b3862 7818
6be7d3da
PE
7819 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7820 deduce are never used uninitialized.
c2ed9c8b 7821 * term.c (encode_terminal_code): Likewise.
6be7d3da 7822
75f8807f 7823 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7824
50938595
PE
7825 * tparam.h: New file.
7826 * term.c, tparam.h: Include it.
7827 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7828 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7829 Move these decls to tparam.h, and make them agree with what
7830 is actually in tparam.c. The previous trick of using incompatible
7831 decls in different modules does not conform to the C standard.
7832 All callers of tparam changed to use tparam's actual API.
7833 * tparam.c (tparam1, tparam, tgoto):
7834 Use const pointers where appropriate.
7835
fbceeba2
PE
7836 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7837 * cm.h (struct cm): Likewise.
7838 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7839 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7840 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7841 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7842 (turn_on_face, init_tty): Likewise.
7843 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7844
7f3f1250
PE
7845 * term.c (term_mouse_position): Rename local to avoid shadowing.
7846
e6ca6543
PE
7847 * alloc.c (mark_ttys): Move decl from here ...
7848 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7849
c40f8d15
AS
78502011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7851
7852 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7853
cfe0661d
JB
78542011-03-09 Juanma Barranquero <lekktu@gmail.com>
7855
7856 * search.c (compile_pattern_1): Remove argument regp, unused since
7857 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7858 (compile_pattern): Don't pass it.
7859
0afb4571
J
78602011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7861
7862 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7863 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7864 for ! HAVE_GTK3.
7865 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7866
7867 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7868
7869 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7870 gdk_window_get_screen, gdk_window_get_geometry,
7871 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7872 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7873 (xg_get_pixbuf_from_pixmap): New function.
7874 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7875 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7876 Call xg_get_pixbuf_from_pixmap instead of
7877 gdk_pixbuf_get_from_drawable.
7878 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7879 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7880 (xg_check_special_colors): Use GtkStyleContext and its functions
7881 for HAVE_GTK3.
7882 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7883 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7884 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7885 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7886 Call gtk_widget_get_preferred_size.
0afb4571
J
7887 (xg_frame_resized): gdk_window_get_geometry only takes 5
7888 parameters.
44f230aa
SM
7889 (xg_win_to_widget, xg_event_is_for_menubar):
7890 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7891 (xg_set_widget_bg): New function.
7892 (delete_cb): New function.
895009e1 7893 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7894 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7895 (xg_set_background_color): Call xg_set_widget_bg.
7896 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7897 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7898 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7899 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7900 if ! HAVE_GTK3.
7901 (update_frame_tool_bar): Call gtk_widget_hide.
7902 (xg_initialize): Use GDK_KEY_g.
7903
7904 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7905 if ! HAVE_GTK3
7906 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7907
7908 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7909 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7910 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7911
1c2cc4ef
JB
79122011-03-08 Juanma Barranquero <lekktu@gmail.com>
7913
7914 * w32xfns.c (select_palette): Check success of RealizePalette against
7915 GDI_ERROR, not zero.
7916
33383987 7917See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7918
7919;; Local Variables:
7920;; coding: utf-8
aac0c6e3
MR
7921;; End:
7922
33383987 7923 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7924
7925 This file is part of GNU Emacs.
7926
7927 GNU Emacs is free software: you can redistribute it and/or modify
7928 it under the terms of the GNU General Public License as published by
7929 the Free Software Foundation, either version 3 of the License, or
7930 (at your option) any later version.
7931
7932 GNU Emacs is distributed in the hope that it will be useful,
7933 but WITHOUT ANY WARRANTY; without even the implied warranty of
7934 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7935 GNU General Public License for more details.
7936
7937 You should have received a copy of the GNU General Public License
7938 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.