* composite.c: Use int, not EMACS_INT, for characters.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
13bdea59
PE
12011-06-13 Paul Eggert <eggert@cs.ucla.edu>
2
f8c86b69
PE
3 * composite.c: Use int, not EMACS_INT, for characters.
4 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5 EMACS_INT, for values that are known to be in character range.
6 This doesn't fix any bugs but is the usual style inside Emacs and
7 may generate better code on 32-bit machines.
8
34206dd2
PE
9 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10 This is for reasons similar to the recent CHAR_STRING fix.
11 * charset.c (Fencode_char): Check that character arg is actually
12 a character. Pass an int to ENCODE_CHAR.
13 * charset.h (ENCODE_CHAR): Verify that the character argument is no
14 wider than 'int', as a compile-time check to prevent future regressions
15 in this area.
16
c5958d4c 17 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
18
19 Make sure a 64-bit char is never passed to CHAR_STRING.
20 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
21 by silently ignoring the top 32 bits, allowing some values
22 that were far too large to be valid characters.
23 * character.h: Include <verify.h>.
24 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
25 arguments are no wider than unsigned, as a compile-time check
26 to prevent future regressions in this area.
27 * data.c (Faset):
28 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char):
29 (Fsubst_char_in_region):
30 * fns.c (concat):
31 * xdisp.c (decode_mode_spec_coding):
32 Adjust to CHAR_STRING's new requirement.
33 * editfns.c (Finsert_char, Fsubst_char_in_region):
34 * fns.c (concat): Check that character args are actually
35 characters. Without this test, these functions did the wrong
36 thing with wildly out-of-range values on 64-bit hosts.
37
ea204efb
PE
382011-06-12 Paul Eggert <eggert@cs.ucla.edu>
39
d37ca623
PE
40 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
41 These casts should not be needed on 32-bit hosts, either.
42 * keyboard.c (read_char):
43 * lread.c (Fload): Remove casts to unsigned.
44
ea204efb
PE
45 * lisp.h (UNSIGNED_CMP): New macro.
46 This fixes comparison bugs on 64-bit hosts.
47 (ASCII_CHAR_P): Use it.
48 * casefiddle.c (casify_object):
49 * character.h (ASCII_BYTE_P, CHAR_VALID_P):
50 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
51 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
52 * dispextern.h (FACE_FROM_ID):
53 * keyboard.c (read_char): Use UNSIGNED_CMP.
54
fc83f7d3 552011-06-11 Paul Eggert <eggert@cs.ucla.edu>
666398f3 56
41cb286c
PE
57 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
58 not to EMACS_INT, to avoid GCC warning.
59
4a1b9832
PE
60 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
61
55daad71
PE
62 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
63 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
64 isn't needed on 32-bit machines.
8f95c75c 65
666398f3 66 * buffer.c (Fgenerate_new_buffer_name): Use EMACS_INT for count, not int.
0ceccced 67 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
68
69 * data.c (Qcompiled_function): Now static.
70
c6f072e7
PE
71 * window.c (window_body_lines): Now static.
72
20ce5912
PE
73 * image.c (gif_load): Rename local to avoid shadowing.
74
9c4c5f81
PE
75 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
76 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
77 * alloc.c (make_save_value): Integer argument is now of type
78 ptrdiff_t, not int.
79 (mark_object): Use ptrdiff_t, not int.
80 * lisp.h (pD): New macro.
81 * print.c (print_object): Use it.
82
c0c5c8ae
PE
83 * alloc.c: Use EMACS_INT, not int, to count objects.
84 (total_conses, total_markers, total_symbols, total_vector_size)
85 (total_free_conses, total_free_markers, total_free_symbols)
86 (total_free_floats, total_floats, total_free_intervals, total_intervals)
87 (total_strings, total_free_strings):
88 Now EMACS_INT, not int. All uses changed.
89 (Fgarbage_collect): Compute overall total using a double, so that
90 integer overflow is less likely to be a problem. Check for overflow
91 when converting back to an integer.
5a25e253
PE
92 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
93 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
94 These were 'int' variables that could overflow on 64-bit hosts;
95 they were never used, so remove them instead of repairing them.
211a0b2a 96 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
97 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
98 Previously, this ceilinged at INT_MAX, but that doesn't work on
99 64-bit machines.
e46bb31a 100 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 101
c78baabf 102 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 103 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
104 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
105 when a (possibly-narrower) signed value would do just as well.
106 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 107
c9d624c6
PE
108 * alloc.c: Catch some string size overflows that we were missing.
109 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
110 for convenience in STRING_BYTES_MAX.
111 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
112 The definition here is exact; the one in lisp.h was approximate.
113 (allocate_string_data): Check for string overflow. This catches
114 some instances we weren't catching before. Also, it catches
115 size_t overflow on (unusual) hosts where SIZE_MAX <= min
116 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
117 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 118
c9d624c6
PE
119 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
120 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
121 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
122
353032ce
PE
123 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
124
2bccce07
PE
125 * alloc.c (Fmake_string): Check for out-of-range init.
126
b50691aa
CY
1272011-06-11 Chong Yidong <cyd@stupidchicken.com>
128
129 * dispextern.h (struct image): Replace data member, whose int_val
130 and ptr_val fields were not used by anything, with a single
131 lisp_val object.
132
133 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
134 (gif_clear_image, gif_load, imagemagick_load_image)
135 (gs_clear_image, gs_load): Callers changed.
136
3f754b86
PE
1372011-06-10 Paul Eggert <eggert@cs.ucla.edu>
138
cca69397
PE
139 * buffer.h: Include <time.h>, for time_t.
140 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
141
109e28d0
PE
142 Fix minor problems found by static checking.
143
60737f02
PE
144 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
145
4b66faf3
PE
146 Make identifiers static if they are not used in other modules.
147 * data.c (Qcompiled_function, Qframe, Qvector):
148 * image.c (QimageMagick, Qsvg):
149 * minibuf.c (Qmetadata):
150 * window.c (resize_window_check, resize_root_window): Now static.
151 * window.h (resize_window_check, resize_root_window): Remove decls.
152
109e28d0
PE
153 * window.c (window_deletion_count, delete_deletable_window):
154 Remove; unused.
46a4ce9e
PE
155 (window_body_lines): Now static.
156 (Fdelete_other_windows_internal): Mark vars as initialized.
157 Make sure 'resize_failed' is initialized.
158 (run_window_configuration_change_hook): Rename local to avoid shadowing.
159 (resize_window_apply): Remove unused local.
160 * window.h (delete_deletable_window): Remove decl.
161
109e28d0 162 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
163 (imagemagick_load_image): Fix pointer signedness problem by changing
164 last arg from unsigned char * to char *. All uses changed.
165 Also, fix a local for similar reasons.
166 Remove unused locals. Remove locals to avoid shadowing.
167 (fn_rsvg_handle_free): Remove; unused.
168 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 169 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 170
3f754b86
PE
171 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
172
2547adb1
CY
1732011-06-10 Chong Yidong <cyd@stupidchicken.com>
174
175 * image.c (gif_load): Fix omitted cast error introduced by
176 2011-06-06 change.
177
2c8e37d4
MR
1782011-06-10 Martin Rudalics <rudalics@gmx.at>
179
180 * window.h (resize_proportionally, orig_total_lines)
181 (orig_top_line): Remove from window structure.
182 (set_window_height, set_window_width, change_window_heights)
183 (Fdelete_window): Remove prototypes.
184 (resize_frame_windows): Remove duplicate declaration.
185
440a42e3
EZ
1862011-06-10 Eli Zaretskii <eliz@gnu.org>
187
188 * window.h (resize_frame_windows, resize_window_check)
189 (delete_deletable_window, resize_root_window)
190 (resize_frame_windows): Declare prototypes.
191
192 * window.c (resize_window_apply): Make definition be "static" to
193 match the prototype.
194
562dd5e9
MR
1952011-06-10 Martin Rudalics <rudalics@gmx.at>
196
197 * window.c: Remove declarations of Qwindow_size_fixed,
198 window_min_size_1, window_min_size_2, window_min_size,
199 size_window, window_fixed_size_p, enlarge_window, delete_window.
200 Remove static from declaration of Qdelete_window, it's
201 temporarily needed by Fbury_buffer.
202 (replace_window): Don't assign orig_top_line and
203 orig_total_lines.
204 (Fdelete_window, delete_window): Remove. Window deletion is
205 handled by window.el.
206 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
207 Fdelete_window calls with calls to Qdelete_window.
208 (Fdelete_other_windows): Remove. Deleting other windows is
209 handled by window.el.
210 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
211 handled in window.el.
212 (window_min_size_2, window_min_size_1, window_min_size): Remove.
213 Window minimum sizes are handled in window.el.
214 (shrink_windows, size_window, set_window_height)
215 (set_window_width, change_window_heights, window_height)
216 (window_width, CURBEG, CURSIZE, enlarge_window)
217 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
218 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
219 handled in window.el.
220 (make_dummy_parent): Rename to make_parent_window and give it a
221 second argument horflag.
222 (make_window): Don't set resize_proportionally any more.
223 (Fsplit_window): Remove. Windows are split in window.el.
224 (save_restore_action, save_restore_orig_size)
225 (shrink_window_lowest_first, save_restore_orig_size): Remove.
226 Resize mini windows in window.el.
227 (grow_mini_window, shrink_mini_window): Implement by calling
228 Qresize_root_window_vertically, resize_window_check and
229 resize_window_apply.
230 (saved_window, Fset_window_configuration, save_window_save): Do
231 not handle orig_top_line, orig_total_lines, and
232 resize_proportionally.
233 (window_min_height, window_min_width): Move to window.el.
234 (keys_of_window): Move bindings for delete-other-windows,
235 split-window, delete-window and enlarge-window to window.el.
236
237 * buffer.c: Temporarily extern Qdelete_window.
238 (Fbury_buffer): Temporarily call Qdelete_window instead of
239 Fdelete_window (Fbury_buffer will move to window.el soon).
240
241 * frame.c (set_menu_bar_lines_1): Remove code handling
242 orig_top_line and orig_total_lines.
243
244 * dispnew.c (adjust_frame_glyphs_initially): Don't use
245 set_window_height but set heights directly.
246 (change_frame_size_1): Use resize_frame_windows.
247
248 * xdisp.c (init_xdisp): Don't use set_window_height but set
249 heights directly.
250
251 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
252 resize_frame_windows instead of change_window_heights and run
253 run_window_configuration_change_hook.
254
255 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
256 instead of change_window_heights and run
257 run_window_configuration_change_hook.
258
1a13852e
MR
2592011-06-09 Martin Rudalics <rudalics@gmx.at>
260
261 * window.c (replace_window): Rename second argument REPLACEMENT to
262 NEW. New third argument SETFLAG. Rewrite.
263 (delete_window, make_dummy_parent): Call replace_window with
264 third argument 1.
265 (window_list_1): Move down in code.
266 (run_window_configuration_change_hook): Move set_buffer part
267 before select_frame_norecord part in order to unwind correctly.
268 Rename count1 to count.
269 (recombine_windows, delete_deletable_window, resize_root_window)
270 (Fdelete_other_windows_internal)
271 (Frun_window_configuration_change_hook, make_parent_window)
272 (resize_window_check, resize_window_apply, Fresize_window_apply)
273 (resize_frame_windows, Fsplit_window_internal)
274 (Fdelete_window_internal, Fresize_mini_window_internal): New
275 functions.
276 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
277
f3d1777e
MR
2782011-06-08 Martin Rudalics <rudalics@gmx.at>
279
496e208e
MR
280 * window.h (window): Add some new members to window structure -
281 normal_lines, normal_cols, new_total, new_normal, clone_number,
282 splits, nest, prev_buffers, next_buffers.
283 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 284 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 285
f3d1777e
MR
286 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
287 Remove.
496e208e
MR
288 (make_dummy_parent): Set new members of windows structure.
289 (make_window): Move down in code. Handle new members of window
290 structure.
291 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
292 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
293 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
294 (Fset_window_prev_buffers, Fwindow_next_buffers)
295 (Fset_window_next_buffers, Fset_window_clone_number): New
296 functions.
297 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
298 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
299 Doc-string fixes.
300 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
301 Argument WINDOW can be now internal window too.
302 (Fwindow_use_time): Move up in code.
303 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
304 Rewrite doc-string.
305 (Fset_window_configuration, saved_window)
306 (Fcurrent_window_configuration, save_window_save): Handle new
307 members of window structure.
b9e809c2
MR
308 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
309 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
310 (syms_of_window): New Lisp objects Qrecord_window_buffer,
311 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
312 Qget_mru_window, Qresize_root_window,
313 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
314 Qauto_buffer_name; staticpro them.
f3d1777e 315
abde8f8c
MR
3162011-06-07 Martin Rudalics <rudalics@gmx.at>
317
318 * window.c (Fwindow_total_size, Fwindow_left_column)
319 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
320 (Fwindow_list_1): New functions.
321 (window_box_text_cols): Replace with window_body_cols.
322 (Fwindow_width, Fscroll_left, Fscroll_right): Use
323 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
324 (delete_window, Fset_window_configuration): Call
325 delete_all_subwindows with window as argument.
326 (delete_all_subwindows): Take a window as argument and not a
327 structure. Rewrite.
190b47e6
MR
328 (window_loop): Remove handling of GET_LRU_WINDOW and
329 GET_LARGEST_WINDOW.
330 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
331
332 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
333 window_box_text_cols. delete_all_subwindows now takes a
334 Lisp_Object as argument.
abde8f8c
MR
335
336 * indent.c (compute_motion, Fcompute_motion): Use
337 window_body_cols instead of window_box_text_cols.
338
fa8a67e6
MR
339 * frame.c (delete_frame): Call delete_all_subwindows with root
340 window as argument.
341
a54e3482
DC
3422011-06-07 Daniel Colascione <dan.colascione@gmail.com>
343
344 * fns.c (Fputhash): Document return value.
345
60002bf5
CY
3462011-06-06 Chong Yidong <cyd@stupidchicken.com>
347
348 * image.c (gif_load): Implement gif89a spec "no disposal" method.
349
0c671da6 3502011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 351
b862a52a 352 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 353
be44ca6c
PE
354 Check for overflow when converting integer to cons and back.
355 * charset.c (Fdefine_charset_internal, Fdecode_char):
356 Use cons_to_unsigned to catch overflow.
357 (Fencode_char): Use INTEGER_TO_CONS.
358 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
359 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
360 * data.c (long_to_cons, cons_to_long): Remove.
361 (cons_to_unsigned, cons_to_signed): New functions.
362 These signal an error for invalid or out-of-range values.
363 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
364 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
365 * font.c (Ffont_variation_glyphs):
366 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
367 * lisp.h: Include <intprops.h>.
368 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
369 (cons_to_signed, cons_to_unsigned): New decls.
370 (long_to_cons, cons_to_long): Remove decls.
371 * undo.c (record_first_change): Use INTEGER_TO_CONS.
372 (Fprimitive_undo): Use CONS_TO_INTEGER.
373 * xfns.c (Fx_window_property): Likewise.
374 * xselect.c: Include <limits.h>.
375 (x_own_selection, selection_data_to_lisp_data):
376 Use INTEGER_TO_CONS.
377 (x_handle_selection_request, x_handle_selection_clear)
378 (x_get_foreign_selection, Fx_disown_selection_internal)
379 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
380 (lisp_data_to_selection_data): Use cons_to_unsigned.
381 (x_fill_property_data): Use cons_to_signed.
382 Report values out of range.
383
d1f3d2af
PE
384 Check for buffer and string overflow more precisely.
385 * buffer.h (BUF_BYTES_MAX): New macro.
386 * lisp.h (STRING_BYTES_MAX): New macro.
387 * alloc.c (Fmake_string):
388 * character.c (string_escape_byte8):
389 * coding.c (coding_alloc_by_realloc):
390 * doprnt.c (doprnt):
391 * editfns.c (Fformat):
392 * eval.c (verror):
393 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
394 since they may not be the same number.
395 * editfns.c (Finsert_char):
396 * fileio.c (Finsert_file_contents):
397 Likewise for BUF_BYTES_MAX.
398
dd52fcea
PE
399 * image.c: Use ptrdiff_t, not int, for sizes.
400 (slurp_file): Switch from int to ptrdiff_t.
401 All uses changed.
402 (slurp_file): Check that file size fits in both size_t (for
403 malloc) and ptrdiff_t (for sanity and safety).
404
7f9bbdbb
PE
405 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
406 if b->modtime has its maximal value.
407
dfe18f82
PE
408 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
409
84acfcf0
PE
410 Don't assume time_t can fit into int.
411 * buffer.h (struct buffer.modtime): Now time_t, not int.
412 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
413 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
414
ccd9a01a
PE
415 Minor fixes for signed vs unsigned integers.
416 * character.h (MAYBE_UNIFY_CHAR):
417 * charset.c (maybe_unify_char):
418 * keyboard.c (read_char, reorder_modifiers):
419 XINT -> XFASTINT, since the integer must be nonnegative.
420 * ftfont.c (ftfont_spec_pattern):
421 * keymap.c (access_keymap, silly_event_symbol_error):
422 XUINT -> XFASTINT, since the integer must be nonnegative.
423 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
424 since it makes no difference and we prefer signed.
425 * keyboard.c (record_char): Use XUINT when all the neighbors do.
426 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
427 nonnegative.
428
d6d100dd
SM
4292011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
430
431 * window.h (Fwindow_frame): Declare.
432
2b6148e4
PE
4332011-06-06 Paul Eggert <eggert@cs.ucla.edu>
434
435 * alloc.c: Simplify handling of large-request failures (Bug#8800).
436 (SPARE_MEMORY): Always define.
437 (LARGE_REQUEST): Remove.
438 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
439
f230ecc9
MR
4402011-06-06 Martin Rudalics <rudalics@gmx.at>
441
727e958e
MR
442 * lisp.h: Move EXFUNS for Fframe_root_window,
443 Fframe_first_window and Fset_frame_selected_window to window.h.
444
445 * window.h: Move EXFUNS for Fframe_root_window,
446 Fframe_first_window and Fset_frame_selected_window here from
447 lisp.h.
448
449 * frame.c (Fwindow_frame, Fframe_first_window)
450 (Fframe_root_window, Fframe_selected_window)
451 (Fset_frame_selected_window): Move to window.c.
452 (Factive_minibuffer_window): Move to minibuf.c.
453 (Fother_visible_frames_p): New function.
454
455 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
456
f230ecc9
MR
457 * window.c (decode_window, decode_any_window): Move up in code.
458 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
459 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
460 (Fwindow_buffer): Move up and rewrite doc-string.
461 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
462 (Fwindow_prev): New functions.
727e958e
MR
463 (Fwindow_frame): Move here from frame.c. Accept any window as
464 argument.
465 (Fframe_root_window, Fframe_first_window)
466 (Fframe_selected_window): Move here from frame.c. Accept frame
467 or arbitrary window as argument. Update doc-strings.
468 (Fminibuffer_window): Move up in code.
469 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
470 (Fset_frame_selected_window): Move here from frame.c.
471 Marginal rewrite.
727e958e
MR
472 (Fselected_window, select_window, Fselect_window): Move up in
473 code. Minor doc-string fixes.
f230ecc9 474
4d09bcf6
PE
4752011-06-06 Paul Eggert <eggert@cs.ucla.edu>
476
477 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
478 Do not assume that spare memory exists; that assumption is valid
479 only if SYSTEM_MALLOC.
480 (LARGE_REQUEST): New macro, so that the issue of large requests
481 is separated from the issue of spare memory.
482
810928a2
AS
4832011-06-05 Andreas Schwab <schwab@linux-m68k.org>
484
172418ad
AS
485 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
486 format. (Bug#8806)
487
43f862f7
AS
488 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
489
810928a2
AS
490 * xfns.c (x_set_scroll_bar_default_width): Move declarations
491 before statements.
492
a059fe24
JD
4932011-06-05 Jan Djärv <jan.h.d@swipnet.se>
494
495 * gtkutil.c (xg_get_default_scrollbar_width): New function.
496
497 * gtkutil.h: Declare xg_get_default_scrollbar_width.
498
499 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
500 min width by calling x_set_scroll_bar_default_width (Bug#8505).
501
989bf368
JB
5022011-06-05 Juanma Barranquero <lekktu@gmail.com>
503
504 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
505
4b80f674
CY
5062011-06-04 Chong Yidong <cyd@stupidchicken.com>
507
508 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
509 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
510 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
511 New error handlers.
4b80f674
CY
512 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
513 Obey Vx_select_enable_clipboard_manager. Catch errors in
514 x_clipboard_manager_save (Bug#8779).
515 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 516 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 517
99a33b77 5182011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
519
520 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
521
99a33b77 5222011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
523
524 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
525 in the current matrix if keep_current_p is non-zero.
526
8264569d
EZ
5272011-06-04 Eli Zaretskii <eliz@gnu.org>
528
529 * bidi.c (bidi_level_of_next_char): Fix last change.
530
57f97249
EZ
5312011-06-03 Eli Zaretskii <eliz@gnu.org>
532
fec2107c 533 Support bidi reordering of text covered by display properties.
57f97249 534
fec2107c
EZ
535 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
536 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
537 (bidi_cache_search, bidi_cache_iterator_state)
538 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
539 (bidi_level_of_next_char, bidi_move_to_visually_next):
540 Support character positions inside a run of characters covered by a
fec2107c
EZ
541 display string.
542 (bidi_paragraph_init, bidi_resolve_explicit_1)
543 (bidi_level_of_next_char): Call bidi_fetch_char and
544 bidi_fetch_char_advance instead of FETCH_CHAR and
545 FETCH_CHAR_ADVANCE.
546 (bidi_init_it): Initialize new members.
547 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
548 definitions.
549 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
550 instead of using explicit *_CHAR codes.
d6d100dd
SM
551 (bidi_resolve_explicit, bidi_resolve_weak):
552 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
553 bidirectional text is supported only in multibyte buffers.
554 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
555 it to initialize the frame_window_p member of struct bidi_it.
556 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
557 (bidi_resolve_explicit, bidi_resolve_weak)
558 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
559 bidi_it->nchars is non-positive.
560 (bidi_level_of_next_char): Don't try to lookup the cache for the
561 next/previous character if nothing is cached there yet, or if we
562 were just reseat()'ed to a new position.
c40e2fb2 563
0e14fe90
EZ
564 * xdisp.c (set_cursor_from_row): Set start and stop points
565 according to the row's direction when priming the loop that looks
566 for the glyph on which to display cursor.
567 (single_display_spec_intangible_p): Function deleted.
568 (display_prop_intangible_p): Reimplement to call
569 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
570 Accept 3 additional arguments needed by handle_display_spec.
571 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
572 values: lists, `(when COND...)' forms, etc.
573 (single_display_spec_string_p): Support property values that are
574 lists with the argument STRING its top-level element.
575 (display_prop_string_p): Fix the condition for processing a
576 property that is a list to be consistent with handle_display_spec.
fec2107c 577 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
578 last portion of handle_display_prop.
579 (compute_display_string_pos): Accept additional argument
580 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
581 value of a `display' property is a "replacing spec".
582 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
583 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
584 the display property, but just return a value indicating whether
585 the display property will replace the characters it covers.
586 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
587 frame_window_p members of struct bidi_it.
d6d100dd
SM
588 (compute_display_string_pos, compute_display_string_end):
589 New functions.
fec2107c
EZ
590 (push_it): Accept second argument POSITION, where pop_it should
591 jump to continue iteration.
592 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 593
fec2107c
EZ
594 * keyboard.c (adjust_point_for_property): Adjust the call to
595 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
596
597 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
598 (bidi_init_it): Update prototypes.
599 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
600 (compute_display_string_pos, compute_display_string_end):
601 Declare prototypes.
fec2107c
EZ
602 (struct bidi_it): New members nchars and disp_pos. ch_len is now
603 EMACS_INT.
fc6f18ce 604
40087514 6052011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 606
57f53182
PE
607 Malloc failure behavior now depends on size of allocation.
608 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
609 * lisp.h: Change signatures accordingly.
610 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
611 All callers changed. (Bug#8762)
612
613 * gnutls.c: Use Emacs's memory allocators.
614 Without this change, the gnutls library would invoke malloc etc.
615 directly, which causes problems on non-SYNC_INPUT hosts, and which
616 runs afoul of improving memory_full behavior. (Bug#8761)
617 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
618 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
619 xfree instead of the default malloc, realloc, free.
620 (Fgnutls_boot): No need to check for memory allocation failure,
621 since xmalloc does that for us.
622
ac32cd99 623 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
624 * category.c (hash_get_category_set):
625 * ccl.c (ccl_driver):
626 * charset.c (Fdefine_charset_internal):
627 * charset.h (struct charset.hash_index):
628 * composite.c (get_composition_id, gstring_lookup_cache)
629 (composition_gstring_put_cache):
630 * composite.h (struct composition.hash_index):
631 * dispextern.h (struct image.hash):
632 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
633 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
634 (hashfn_equal, hashfn_user_defined, make_hash_table)
635 (maybe_resize_hash_table, hash_lookup, hash_put)
636 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
637 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
638 (Fsxhash, Fgethash, Fputhash, Fmaphash):
639 * image.c (make_image, search_image_cache, lookup_image)
640 (xpm_put_color_table_h):
641 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 642 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
643 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
644 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
645 * alloc.c (allocate_vectorlike):
646 Check for overflow in vector size calculations.
647 * ccl.c (ccl_driver):
648 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
649 * fns.c, image.c: Remove unnecessary static decls that would otherwise
650 need to be updated by these changes.
40087514
PE
651 * fns.c (make_hash_table, maybe_resize_hash_table):
652 Check for integer overflow with large hash tables.
0de4bb68
PE
653 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
654 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
655 (SXHASH_REDUCE): New macro.
656 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
657 Use it instead of discarding useful hash info with large hash values.
658 (sxhash_float): New function.
659 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
660 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
661 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
662 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
663 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
664 Adjust signatures to match updated version of code.
665 (consing_since_gc): Now EMACS_INT, since a single hash table can
666 use more than INT_MAX bytes.
667
698d32e2
DN
6682011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
669
670 Make it possible to build with GCC-4.6+ -O2 -flto.
671
672 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
673
fd6fa53f
SM
6742011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
675
676 * minibuf.c (get_minibuffer, read_minibuf_unwind):
677 Call minibuffer-inactive-mode.
678
864db017
JB
6792011-05-31 Juanma Barranquero <lekktu@gmail.com>
680
681 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
682 Update dependencies.
683
2ad0baf4
DN
6842011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
685
686 * data.c (init_data): Remove code for UTS, this system is not
687 supported anymore.
688
4fcc2638
DN
6892011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
690
691 Don't force ./temacs to start in terminal mode.
692
693 * frame.c (make_initial_frame): Initialize faces in all cases, not
694 only when CANNOT_DUMP is defined.
695 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
696
c56e0fd5
DN
6972011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
698
699 * dispnew.c (add_window_display_history): Use const for the string
700 pointer. Remove declaration, not needed.
701
333d54da 7022011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 703
55d4c1b2 704 Use 'inline', not 'INLINE'.
333d54da 705 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
706 * alloc.c, fontset.c (INLINE): Remove.
707 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
708 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
709 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
710 * gmalloc.c (register_heapinfo): Use inline unconditionally.
711 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
712
738db178
DN
7132011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
714
715 Make it possible to run ./temacs.
716
717 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
718 syms_of_callproc does the same thing. Remove test for
719 "initialized", do it in the caller.
720 * emacs.c (main): Avoid calling set_initial_environment when dumping.
721
620c53a6
SM
7222011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
723
724 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
725 (read_minibuf): Use get_minibuffer.
726 (syms_of_minibuf): Use DEFSYM.
727 (Qmetadata): New var.
728 * data.c (Qbuffer): Don't make it static.
729 (syms_of_data): Use DEFSYM.
730
e003a292
PE
7312011-05-31 Paul Eggert <eggert@cs.ucla.edu>
732
733 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
734 (CCL_CODE_MIN): New macro.
735
ed008a6d
PE
7362011-05-30 Paul Eggert <eggert@cs.ucla.edu>
737
3687c2ef
PE
738 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
739
ed008a6d
PE
740 * eval.c (Qdebug): Now static.
741 * lisp.h (Qdebug): Remove decl. This reverts a part of the
742 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
743 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
744
d66c4c7c
CY
7452011-05-29 Chong Yidong <cyd@stupidchicken.com>
746
747 * image.c: Various fixes to ImageMagick code comments.
748 (Fimagemagick_types): Doc fix.
749
5fbc2025
PE
7502011-05-29 Paul Eggert <eggert@cs.ucla.edu>
751
0196f88a
PE
752 Minor fixes prompted by GCC 4.6.0 warnings.
753
754 * xselect.c (converted_selections, conversion_fail_tag): Now static.
755
5fbc2025
PE
756 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
757 (x_clipboard_manager_save_all): Move extern decl to ...
758 * xterm.h: ... here, so that it can be checked for consistency.
759
1dd3c2d9
CY
7602011-05-29 Chong Yidong <cyd@stupidchicken.com>
761
762 * xselect.c (x_clipboard_manager_save_frame)
763 (x_clipboard_manager_save_all): New functions.
764 (Fx_clipboard_manager_save): Lisp function deleted.
765
766 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
767 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
768
769 * xterm.h: Update prototype.
770
5ba6571d
WX
7712011-05-28 William Xu <william.xwl@gmail.com>
772
773 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
774 exiting (Bug#8239).
775
3eaff834
JM
7762011-05-28 Jim Meyering <meyering@redhat.com>
777
e1900994 778 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
779 * fns.c (to_uchar): Define.
780 (crypto_hash_function): Use it to convert some newly-signed
781 variables to unsigned, to avoid sign-extension bugs. For example,
782 without this change, (md5 "truc") would evaluate to
783 45723a2aff78ff4fff7fff1114760e62 rather than the expected
784 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 785 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 786
0f6990a7
PE
7872011-05-27 Paul Eggert <eggert@cs.ucla.edu>
788
789 Integer overflow fixes.
c8a9ca5a 790
08686060
PE
791 * dbusbind.c: Serial number integer overflow fixes.
792 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
793 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
794 to hold a serial number that is too large for a fixnum.
795 (Fdbus_method_return_internal, Fdbus_method_error_internal):
796 Check for serial numbers out of range. Decode any serial number
59568bf0 797 that was so large that it became a float. (Bug#8722)
08686060 798
2d1fc3c7
PE
799 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
800 (Fdbus_call_method, Fdbus_call_method_asynchronously):
801 Use XFASTINT rather than XUINT when numbers are nonnegative.
802 (xd_append_arg, Fdbus_method_return_internal):
803 (Fdbus_method_error_internal): Likewise. Also, for unsigned
804 arguments, check that Lisp number is nonnegative, rather than
59568bf0 805 silently wrapping negative numbers around. (Bug#8722)
30217ff0 806 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 807 (Bug#8722)
2d1fc3c7 808
c8a9ca5a
PE
809 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
810
519e1d69
PE
811 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
812
30569699
PE
813 ccl: add integer overflow checks
814 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
815 (IN_INT_RANGE): New macros.
816 (ccl_driver): Use them to check for integer overflow when
817 decoding a CCL program. Many of the new checks are whether XINT (x)
818 fits in int; it doesn't always, on 64-bit hosts. The new version
819 doesn't catch all possible integer overflows, but it's an
847044ea 820 improvement. (Bug#8719)
30569699 821
c11285dc
PE
822 * alloc.c (make_event_array): Use XINT, not XUINT.
823 There's no need for unsigned here.
824
fdccd48e
PE
825 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
826 This follows up to the 2011-05-06 change that substituted uintptr_t
827 for EMACS_INT. This case wasn't caught back then.
828
37910ab2
PE
829 Rework Fformat to avoid integer overflow issues.
830 * editfns.c: Include <float.h> unconditionally, as it's everywhere
831 now (part of C89). Include <verify.h>.
832 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
833 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
834 (Fformat): Avoid the prepass trying to compute sizes; it was only
835 approximate and thus did not catch overflow reliably. Instead, walk
836 through the format just once, formatting and computing sizes as we go,
837 checking for integer overflow at every step, and allocating a larger
838 buffer as needed. Keep track separately whether the format is
839 multibyte. Keep only the most-recently calculated precision, rather
840 than them all. Record whether each argument has been converted to
841 string. Use EMACS_INT, not int, for byte and char and arg counts.
842 Support field widths and precisions larger than INT_MAX. Avoid
843 sprintf's undefined behavior with conversion specifications such as %#d
844 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
845 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
846 formatting out-of-range floating point numbers with int
847 formats. (Bug#8668)
848
2e6578fb
PE
849 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
850
0ae6bdee
PE
851 * data.c: Avoid integer truncation in expressions involving floats.
852 * data.c: Include <intprops.h>.
853 (arith_driver): When there's an integer overflow in an expression
854 involving floating point, convert the integers to floating point
855 so that the resulting value does not suffer from catastrophic
856 integer truncation. For example, on a 64-bit host (* 4
857 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
858 Do not rely on undefined behavior after integer overflow.
859
de883a70
PE
860 merge count_size_as_multibyte, parse_str_to_multibyte
861 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 862 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
863 Check for integer overflow.
864 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
865 since it's now a duplicate of the other. This is more of
866 a character than a buffer op, so better that it's in character.c.
867 * fns.c, print.c: Adjust to above changes.
868
2ff916cb
PE
8692011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
870
871 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
872
f1b54466
PE
8732011-05-27 Paul Eggert <eggert@cs.ucla.edu>
874
fb1ac845
PE
875 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
876 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
877 (x_clipboard_manager_save): Now static.
878 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
879
f1b54466
PE
880 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
881 (crypto_hash_function): Now static.
882 Fix pointer signedness problems. Avoid unnecessary initializations.
883
a9f737ee
CY
8842011-05-27 Chong Yidong <cyd@stupidchicken.com>
885
886 * termhooks.h (Vselection_alist): Make it terminal-local.
887
888 * terminal.c (create_terminal): Initialize it.
889
890 * xselect.c: Support for clipboard managers.
891 (Vselection_alist): Move to termhooks.h as terminal-local var.
892 (LOCAL_SELECTION): New macro.
893 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
894 (symbol_to_x_atom): Remove gratuitous arg.
895 (x_handle_selection_request, lisp_data_to_selection_data)
896 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
897 (x_own_selection, x_get_local_selection, x_convert_selection):
898 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
899 (some_frame_on_display): Delete unused function.
900 (Fx_own_selection_internal, Fx_get_selection_internal)
901 (Fx_disown_selection_internal, Fx_selection_owner_p)
902 (Fx_selection_exists_p): New optional frame arg.
903 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
904 (x_handle_selection_clear): Don't treat other terminals with the
905 same keyboard specially. Use the terminal-local Vselection_alist.
906 (x_clear_frame_selections): Use Frun_hook_with_args.
907
908 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
909
910 * xterm.h: Add support for those atoms.
911
e067f0c1
CY
9122011-05-26 Chong Yidong <cyd@stupidchicken.com>
913
914 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
915 (converted_selections, conversion_fail_tag): New global variables.
916 (x_selection_request_lisp_error): Free the above.
917 (x_get_local_selection): Remove unnecessary code.
918 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
919 of converted selections stored in converted_selections.
920 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
921 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
922 (x_convert_selection): New function.
923 (x_handle_selection_event): Simplify.
924 (x_get_foreign_selection): Don't ignore incoming requests while
925 waiting for an answer; this will fail when we implement
926 SAVE_TARGETS, and seems unnecessary anyway.
927 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
928 (Vx_sent_selection_functions): Doc fix.
929
0f4aebc0
LL
9302011-05-26 Leo Liu <sdl.web@gmail.com>
931
932 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
933
e61124cd
YM
9342011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
935
936 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
937
938 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
939 for fringe update if it has periodic bitmap.
940 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
941 and fringe_bitmap_periodic_p.
942
943 * fringe.c (get_fringe_bitmap_data): New function.
944 (draw_fringe_bitmap_1, update_window_fringes): Use it.
945 (update_window_fringes): Record periodicity of fringe bitmap in glyph
946 row. Mark glyph row for fringe update if periodicity changed.
947
948 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
949 for fringe update unless it has periodic bitmap.
950
f16d9837
KH
9512011-05-25 Kenichi Handa <handa@m17n.org>
952
953 * xdisp.c (get_next_display_element): Set correct it->face_id for
954 a static composition.
955
e1b90ef6
LL
9562011-05-24 Leo Liu <sdl.web@gmail.com>
957
958 * deps.mk (fns.o):
959 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
960
961 * fns.c (crypto_hash_function, Fsha1): New function.
962 (Fmd5): Use crypto_hash_function.
963 (syms_of_fns): Add Ssha1.
964
7400048f
PE
9652011-05-22 Paul Eggert <eggert@cs.ucla.edu>
966
967 * gnutls.c: Remove unused macros.
968 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
969 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
970 Remove macros that are defined and never used.
971 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
972
abb71cf4
CY
9732011-05-22 Chong Yidong <cyd@stupidchicken.com>
974
975 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
976 (Fx_get_selection_internal): Minor cleanup.
977 (Fx_own_selection_internal): Rename arguments for consistency with
978 select.el.
979
6307db39
PE
9802011-05-22 Paul Eggert <eggert@cs.ucla.edu>
981
982 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
983
f3d4e0a4
CY
9842011-05-22 Chong Yidong <cyd@stupidchicken.com>
985
986 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
987
4d8ade89
YM
9882011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989
990 * dispnew.c (scrolling_window): Don't exclude the case that the
991 last enabled row in the desired matrix touches the bottom boundary.
992
32078c8d
GM
9932011-05-21 Glenn Morris <rgm@gnu.org>
994
995 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
996 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
997 and add some more files.
32078c8d 998
7285dc67
EZ
9992011-05-20 Eli Zaretskii <eliz@gnu.org>
1000
1001 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1002 report_file_error introduced by the change from 2011-05-07.
1003
89d1bd22
PE
10042011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1005
1006 * systime.h (Time): Define only if emacs is defined.
1007 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1008 where the include path doesn't have X11/X.h by default. See
1009 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1010
e23640bb 10112011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1012
1013 * composite.c (find_automatic_composition): Fix previous change.
1014
b9704ad9
GM
10152011-05-20 Glenn Morris <rgm@gnu.org>
1016
1017 * lisp.mk: New file, split from Makefile.in.
1018 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1019 (shortlisp): Remove.
1020 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1021
4a720484
GM
10222011-05-19 Glenn Morris <rgm@gnu.org>
1023
1024 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1025 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1026 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1027 (lisp): Set the order to that of loadup.el.
1028 (shortlisp): Make it a copy of $lisp.
1029 (SOME_MACHINE_LISP): Remove.
1030 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1031 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1032
a28d4396
KH
10332011-05-18 Kenichi Handa <handa@m17n.org>
1034
1035 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1036 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1037 (find_automatic_composition): Mostly rewrite for efficiency.
1038
a2b1fa8e
JB
10392011-05-18 Juanma Barranquero <lekktu@gmail.com>
1040
1041 * makefile.w32-in: Update dependencies.
1042
8e1f5610
CS
10432011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1044
1045 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1046 revision 104625).
1047
7025ee00 10482011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1049
cdfa6eab
PE
1050 Fix some integer overflow issues, such as string length overflow.
1051
06d6db33
PE
1052 * insdel.c (count_size_as_multibyte): Check for string overflow.
1053
2b4560a8
PE
1054 * character.c (lisp_string_width): Check for string overflow.
1055 Use EMACS_INT, not int, for string indexes and lengths; in
1056 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1057 the resulting string length overflows an EMACS_INT; instead,
1058 report a string overflow if no precision given. When checking for
1059 precision exhaustion, use a check that cannot possibly have
1060 integer overflow. (Bug#8675)
1061 * character.h (lisp_string_width): Adjust to new signature.
1062
cb93f9be
PE
1063 * alloc.c (string_overflow): New function.
1064 (Fmake_string): Use it. This doesn't change behavior, but saves
1065 a few bytes and will simplify future changes.
1066 * character.c (string_escape_byte8): Likewise.
1067 * lisp.h (string_overflow): New decl.
1068
1a1f3366
PE
1069 Fixups, following up to the user-interface timestamp change.
1070 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1071 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1072 * msdos.c (mouse_get_pos): Likewise.
1073 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1074 * w32gui.h (Time): Define by including "systime.h" rather than by
1075 declaring it ourselves. (Bug#8664)
1076
d4e3e4d3
PE
1077 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1078 * image.c (clear_image_cache): Likewise.
1079
f6a24d19
PE
1080 * term.c (term_mouse_position): Don't assume time_t wraparound.
1081
08dc5ae6
PE
1082 Be more systematic about user-interface timestamps.
1083 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1084 and sometimes 'EMACS_UINT', to represent these timestamps.
1085 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1086 This makes the code easier to follow, and makes it easier to catch
1087 integer overflow bugs such as Bug#8664.
1088 * frame.c (Fmouse_position, Fmouse_pixel_position):
1089 Use Time, not unsigned long, for user-interface timestamps.
1090 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1091 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1092 * keyboard.h (last_event_timestamp): Likewise.
1093 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1094 * menu.h (xmenu_show): Likewise.
1095 * term.c (term_mouse_position): Likewise.
1096 * termhooks.h (struct input_event.timestamp): Likewise.
1097 (struct terminal.mouse_position_hook): Likewise.
1098 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1099 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1100 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1101 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1102 what it was before.
1103 * menu.h, termhooks.h: Include "systime.h", for Time.
1104
8e55734a
PE
1105 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1106 Don't assume that the difference between two unsigned long values
1107 can fit into an integer. At this point, we know button_down_time
1108 <= event->timestamp, so the difference must be nonnegative, so
1109 there's no need to cast the result if double-click-time is
1110 nonnegative, as it should be; check that it's nonnegative, just in
1111 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1112 apart (about 25 days). (Bug#8664)
8e55734a 1113
841f1b75 1114 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1115 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1116
3e26f69c
PE
1117 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1118 that always fit in int. Use a sentinel instead of a counter, to
1119 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1120 * frame.h (struct frame): Use int for menu_bar_items_used
1121 instead of EMACS_INT, since it always fits in int.
3e26f69c 1122
5cc152c0
PE
1123 * menu.c (grow_menu_items): Check for int overflow.
1124
d89eb65e
PE
1125 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1126
5235bd3e
PE
1127 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1128 Before, the code was not consistent. These values cannot exceed
1129 2**31 - 1 so there's no need to make them unsigned.
1130 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1131 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1132 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1133 as modifiers.
1134 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1135
bc827e23
PE
1136 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1137 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1138 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1139 presumably because the widths might not match.
1140
78eb494e
PE
1141 * window.c (size_window): Avoid needless test at loop start.
1142
04f2d78b
CB
11432011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1144
1145 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1146
d2fc7e3d 11472011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1148
1149 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1150
d2fc7e3d 11512011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1152
1153 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1154 `width' to `bar_area_x' and `bar_area_width', respectively.
1155 (x_scroll_run): Take account of fringe background extension.
1156
04f2d78b
CB
1157 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1158 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1159 `bar_area_width', respectively.
1160 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1161 background extension.
1162
79b70037
GM
11632011-05-10 Jim Meyering <meyering@redhat.com>
1164
1165 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1166
2f142cc5
JB
11672011-05-10 Juanma Barranquero <lekktu@gmail.com>
1168
1169 * image.c (Finit_image_library): Return t for built-in image types,
1170 like pbm and xbm. (Bug#8640)
1171
57679c86
AS
11722011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1173
1174 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1175
888c9e86
EZ
11762011-05-07 Eli Zaretskii <eliz@gnu.org>
1177
b0512a1d
EZ
1178 * w32console.c (Fset_screen_color): Doc fix.
1179 (Fget_screen_color): New function.
1180 (syms_of_ntterm): Defsubr it.
1181
7285dc67
EZ
1182 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1183 unlink the temporary file if Fcall_process didn't create it in the
1184 first place.
1185 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1186 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1187 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1188 cue to call_process_cleanup not to close that handle.
1189
4d3fcc8e
BK
11902011-05-07 Ben Key <bkey76@gmail.com>
1191
1192 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1193 one of two shell specific rules, either bootstrap-temacs-CMD or
1194 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1195 to the previous implementation of the bootstrap-temacs rule.
1196 The bootstrap-temacs-CMD rule is similar to the previous
1197 implementation of the bootstrap-temacs rule except that it
1198 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1199 variable.
1200
1201 These changes, along with some changes to nt/configure.bat,
1202 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1203 earlier fix to add support for --cflags and --ldflags options
1204 that include quotes so that it works whether make uses cmd or
1205 sh as the shell.
1206
b4289b64
MA
12072011-05-06 Michael Albinus <michael.albinus@gmx.de>
1208
1209 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1210 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1211 is a constant.
1212 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1213 a string. Handle both cases.
1214 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1215 (Fdbus_register_method): Use Qinvalid_function.
1216
af4c0e28
JB
12172011-05-06 Juanma Barranquero <lekktu@gmail.com>
1218
1219 * makefile.w32-in: Update dependencies.
1220 (LISP_H): Add inttypes.h and stdin.h.
1221 (PROCESS_H): Add unistd.h.
1222
c51453d9
EZ
12232011-05-06 Eli Zaretskii <eliz@gnu.org>
1224
1225 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1226 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1227
8ff0ac3c 12282011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1229
4c4b566b
PE
1230 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1231
aab2b9b5
PE
1232 * term.c (vfatal): Remove stray call to va_end.
1233 It's not needed and the C Standard doesn't allow it here anyway.
1234
c378da0b
PE
1235 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1236 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1237
288b08c7
PE
1238 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1239 bytes.
1240
e3601888
PE
1241 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1242
db6c0e74
PE
1243 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1244
dd5963ea
PE
1245 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1246
88c9450f
PE
1247 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1248
2f9442b8
PE
1249 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1250
c032b5f8
PE
1251 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1252 * charset.c (Fdefine_charset_internal): Don't initialize
1253 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1254 32-bit int (Bug#8600).
a108c10b
PE
1255
1256 * lread.c (read_integer): Be more consistent with string-to-number.
1257 Use string_to_number to do the actual conversion; this avoids
1258 rounding errors and fixes some other screwups. Without this fix,
1259 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1260 (digit_to_number): Move earlier, for benefit of read_integer.
1261 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1262 not a digit in any supported base. (Bug#8602)
a108c10b 1263
ad5f9eea
PE
1264 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1265
aec1708a
PE
1266 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1267 to match comment at start of function. This also removes a
1268 GCC warning about overflow in a 32+64-bit port.
1269
47be4ab5
PE
1270 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1271
371cac43
PE
1272 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1273 Reported by Stefan Monnier in
1274 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1275 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1276 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1277
d01a7826
PE
1278 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1279 (EMACS_UINTPTR): Likewise, with uintptr_t.
1280
7fd47d5c
PE
1281 * lisp.h: Prefer 64-bit EMACS_INT if available.
1282 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1283 on 32-bit hosts that have 64-bit int, so that they can access
1284 large files.
122b0c86
PE
1285 However, temporarily disable this change unless the temporary
1286 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1287
8727937b
PE
1288 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1289
8ac068ac
PE
1290 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1291 This removes an assumption that EMACS_INT and long are the same
1292 width as pointers. The assumption is true for Emacs porting targets
1293 now, but we want to make other targets possible.
1294 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1295 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1296 In the rest of the code, change types of integers that hold casted
1297 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1298 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1299 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1300 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1301 No need to cast type when ORing.
1302 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1303 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1304 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1305 assume EMACS_INT is the same width as char *.
1306 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1307 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1308 Remove no-longer-needed casts.
1309 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1310 (xg_tool_bar_help_callback, xg_make_tool_item):
1311 Use EMACS_INTPTR to hold an integer
1312 that will be cast to void *; this can avoid a GCC warning
1313 if EMACS_INT is not the same width as void *.
1314 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1315 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1316 (current_message_1, set_message_1):
1317 Use a local to convert to proper width without a cast.
1318 * xmenu.c (dialog_selection_callback): Likewise.
1319
ede49d71
PE
1320 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1321 Also, don't assume VALBITS / RAND_BITS is less than 5,
1322 and don't rely on undefined behavior when shifting a 1 left into
1323 the sign bit.
1324 * lisp.h (get_random): Change signature to match.
1325
2f30ecd0
PE
1326 * lread.c (hash_string): Use size_t, not int, for hash computation.
1327 Normally we prefer signed values; but hashing is special, because
1328 it's better to use unsigned division on hash table sizes so that
1329 the remainder is nonnegative. Also, size_t is the natural width
1330 for hashing into memory. The previous code used 'int', which doesn't
1331 retain enough info to hash well into very large tables.
1332 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1333
2a866e7b
PE
1334 * dbusbind.c: Don't possibly lose pointer info when converting.
1335 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1336 Use XPNTR rather than XHASH, so that the high-order bits of
1337 the pointer aren't lost when converting through void *.
1338
51639eac
PE
1339 * eval.c (Fautoload): Don't double-shift a pointer.
1340
92394119
PE
1341 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1342
dbdb9a7c
JB
13432011-05-06 Juanma Barranquero <lekktu@gmail.com>
1344
1345 * gnutls.c (DEF_GNUTLS_FN):
1346 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1347
db7a0b4f
AS
13482011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1349
1350 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1351 marker. (Bug#8610)
1352
f7ff1b0f 13532011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1354
1355 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1356 New version that can reserve upto 2GB of heap space.
1357
f7ff1b0f 13582011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1359
1360 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1361
639c109b
TZ
13622011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1363
1364 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1365 `gnutls_certificate_set_x509_key_file'.
1366
d2127135
JB
13672011-05-05 Juanma Barranquero <lekktu@gmail.com>
1368
1369 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1370 Update dependencies.
1371
e968f4f3
JB
13722011-05-04 Juanma Barranquero <lekktu@gmail.com>
1373
1374 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1375 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1376 Remove unused parameter `fildes'.
1377 * process.c (read_process_output, send_process): Don't pass it.
1378
84d358f0
JB
13792011-05-04 Juanma Barranquero <lekktu@gmail.com>
1380
1381 Fix previous change: the library cache is defined in w32.c.
1382 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1383 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1384
0898ca10
JB
13852011-05-04 Juanma Barranquero <lekktu@gmail.com>
1386
1387 Implement dynamic loading of GnuTLS on Windows.
1388
1389 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1390 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1391 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1392 Declare.
1393
1394 * gnutls.c (Qgnutls_dll): Define.
1395 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1396 (gnutls_*): Declare function pointers.
1397 (init_gnutls_functions): New function to initialize function pointers.
1398 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1399 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1400 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1401 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1402 (emacs_gnutls_write, emacs_gnutls_read)
1403 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1404 (Fgnutls_available_p): New function.
1405 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1406 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1407 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1408
1409 * image.c: Include w32.h.
1410 (Vimage_type_cache): Delete.
1411 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1412 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1413 (w32_delayed_load): Move to w32.c.
1414
1415 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1416
1417 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1418 (w32_delayed_load): Move from image.c. When loading a library, record
1419 its filename in the :loaded-from property of the library id.
1420 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1421 Initialize and staticpro them.
1422 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1423
1424 * process.c: Include lisp.h before w32.h, not after.
1425 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1426 instead of gnutls_record_check_pending.
1427
1428 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1429
ff4de4aa
TZ
14302011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1431
1432 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1433 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1434 as passed in.
1435
abe95abb
JD
14362011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1437
1438 * xterm.c (x_set_frame_alpha): Do not set property on anything
1439 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1440
e16e55d4
JB
14412011-05-02 Juanma Barranquero <lekktu@gmail.com>
1442
1443 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1444
bafcf6a5
JB
14452011-05-02 Juanma Barranquero <lekktu@gmail.com>
1446
1447 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1448 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1449 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1450 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1451 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1452 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1453 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1454 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1455 (Qgnutls_bootprop_callbacks_verify): Make static.
1456
e7a6747f
AS
14572011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1458
19ed11ba
AS
1459 * callproc.c: Indentation fixup.
1460
e7a6747f 1461 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1462 (wait_for_termination, interruptible_wait_for_termination):
1463 Move after wait_for_termination_1.
e7a6747f 1464
1ef14cb4
LMI
14652011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1466
1467 * sysdep.c (interruptible_wait_for_termination): New function
1468 which is like wait_for_termination, but allows keyboard
1469 interruptions.
1470
1471 * callproc.c (Fcall_process): Add (:file "file") as an option for
1472 the STDOUT buffer.
1473 (Fcall_process_region): Ditto.
1474
330d880c
EZ
14752011-04-30 Eli Zaretskii <eliz@gnu.org>
1476
8db90b73
EZ
1477 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1478 rather than `XVECTOR (FOO)->size'.
1479
330d880c
EZ
1480 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1481 inttypes.h, as a gnulib replacement is used if it not available in
1482 system headers.
1483
15cbd324
EZ
14842011-04-21 Eli Zaretskii <eliz@gnu.org>
1485
1486 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1487 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1488 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1489
1490 * coding.c (coding_alloc_by_realloc): Error out if destination
1491 will grow beyond MOST_POSITIVE_FIXNUM.
1492 (decode_coding_emacs_mule): Abort if there isn't enough place in
1493 charbuf for the composition carryover bytes. Reserve an extra
1494 space for up to 2 characters produced in a loop.
1495 (decode_coding_iso_2022): Abort if there isn't enough place in
1496 charbuf for the composition carryover bytes.
1497
14982011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1499
ae940cca
EZ
1500 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1501 aborting when %lld or %lll format is passed.
1502 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1503 %llo or %llx format is passed. (Bug#8545)
1504
03ab8921
EZ
1505 * window.c (window_scroll_line_based): Use a marker instead of
1506 simple variables to record original value of point. (Bug#7952)
1507
afda1437
EZ
1508 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1509 produced by %s or %c overflows available buffer space. (Bug#8545)
1510
f76dee0c
PE
15112011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1512
1513 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1514 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1515
fdc5744d
JB
15162011-04-28 Juanma Barranquero <lekktu@gmail.com>
1517
1518 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1519
638f053a
JB
15202011-04-28 Juanma Barranquero <lekktu@gmail.com>
1521
1522 * keyboard.c (Qdelayed_warnings_hook): Define.
1523 (command_loop_1): Run `delayed-warnings-hook'
1524 if Vdelayed_warnings_list is non-nil.
1525 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1526 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1527
d178f871
EZ
15282011-04-28 Eli Zaretskii <eliz@gnu.org>
1529
1530 * doprnt.c (doprnt): Don't return value smaller than the buffer
1531 size if the message was truncated. (Bug#8545).
1532
b124fd93
JB
15332011-04-28 Juanma Barranquero <lekktu@gmail.com>
1534
1535 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1536 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1537
e810457d
PE
15382011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1539
1540 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1541
ea51cceb
JB
15422011-04-27 Juanma Barranquero <lekktu@gmail.com>
1543
1544 * makefile.w32-in: Update dependencies.
1545
94dcfacf
EZ
15462011-04-27 Eli Zaretskii <eliz@gnu.org>
1547
1548 Improve `doprnt' and its usage. (Bug#8545)
1549 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1550 `format_end'. Remove support for %l as a conversion specifier.
1551 Don't use xrealloc. Improve diagnostics when the %l size modifier
1552 is used. Update the commentary.
1553
1554 * eval.c (verror): Simplify calculation of size_t.
1555
1556 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1557 messages.
1558
f61f41d7
PE
15592011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1560
1561 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1562 change.
1563
96fb4434
PE
15642011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1565
1566 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1567 This makes this file independent of the recent pseudovector change.
1568
671875da 15692011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1570
69e9b5a3
PE
1571 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1572
b5f869a7 1573 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1574 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1575 Remove unused local.
c8926152 1576 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1577
841a1577 1578 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1579 GCC 4.6.0 optimizes based on type-based alias analysis.
1580 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1581 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1582 != &v->size, and therefore "v->size = 1; b->size = 2; return
1583 v->size;" must therefore return 1. This assumption is incorrect
1584 for Emacs, since it type-puns struct Lisp_Vector * with many other
1585 types. To fix this problem, this patch adds a new type struct
f904488f 1586 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1587 and pseudovectors, and helps optimizing compilers not get fooled
1588 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1589 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1590 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1591 the size member.
eab3844f
PE
1592 (XSETPVECTYPE): Rewrite in terms of new macro.
1593 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1594 This is a bit clearer, and further avoids the possibility of
1595 undesirable aliasing.
1596 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1597 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1598 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1599 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1600 (ASIZE): Now uses header.size rather than size.
1601 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1602 to avoid the hassle of writing XVECTOR (foo)->header.size.
1603 (struct vectorlike_header): New type.
eab3844f
PE
1604 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1605 object, to help avoid aliasing.
1606 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1607 (SUBRP): Likewise, since Lisp_Subr is a special case.
1608 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1609 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1610 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1611 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1612 changed to be "header.size" and "header.next".
1613 * buffer.h (struct buffer): Likewise.
1614 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1615 * frame.h (struct frame): Likewise.
1616 * process.h (struct Lisp_Process): Likewise.
1617 * termhooks.h (struct terminal): Likewise.
1618 * window.c (struct save_window_data, struct saved_window): Likewise.
1619 * window.h (struct window): Likewise.
1620 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1621 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1622 * buffer.c (init_buffer_once): Likewise.
1623 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1624 special case.
1625 * process.c (Fformat_network_address): Use local var for size,
1626 for brevity.
1627
0df1eac5
PE
1628 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1629
847ab9d1 1630 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1631 * data.c (atof): Remove decl; no longer used or needed.
1632 (digit_to_number): Move to lread.c.
1633 (Fstring_to_number): Use new string_to_number function, to be
1634 consistent with how the Lisp reader treats infinities and NaNs.
1635 Do not assume that floating-point numbers represent EMACS_INT
1636 without losing information; this is not true on most 64-bit hosts.
1637 Avoid double-rounding errors, by insisting on integers when
1638 parsing non-base-10 numbers, as the documentation specifies.
1639 * lisp.h (string_to_number): New decl, replacing ...
1640 (isfloat_string): Remove.
bc0a5c13 1641 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1642 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1643 appears to have been a coding error. Similarly, do not accept
1644 strings like +-1e0 as floating point numbers. Do not report
1645 overflow for integer overflows unless the base is not 10 which
1646 means we have no simple and reliable way to continue.
1647 Break out the floating-point parsing into a new
1648 function string_to_number, so that Fstring_to_number parses
1649 floating point numbers consistently with the Lisp reader.
04f2d78b 1650 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1651 (E_CHAR, EXP_INT): Remove, replacing with ...
1652 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1653 (string_to_number): New function, replacing isfloat_string.
1654 This function checks for valid syntax and produces the resulting
1655 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1656 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1657 so that overflow for non-base-10 numbers is reported only when
1658 there's no portable and simple way to convert to floating point.
452f4150 1659
67769ffc
PE
1660 * textprop.c (set_text_properties_1): Rewrite for clarity,
1661 and to avoid GCC warning about integer overflow.
1662
c20db43f
PE
1663 * intervals.h (struct interval): Use EMACS_INT for members
1664 where EMACS_UINT might cause problems. See
1665 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1666 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1667 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1668 All uses changed.
37aa2f85
PE
1669 (offset_intervals): Tell GCC not to worry about length overflow
1670 when negating a negative length.
c20db43f 1671
2538aa2f
PE
1672 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1673 (overrun_check_free): Likewise.
1674
f2d3008d
PE
1675 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1676 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1677 word size.
1678
ec8df744
PE
1679 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1680 (gnutls_make_error): Rename local to avoid shadowing.
1681 (gnutls_emacs_global_deinit): ifdef out; not used.
1682 (Fgnutls_boot): Use const for pointer to readonly storage.
1683 Comment out unused local. Fix pointer signedness problems.
1684
640ee02d
PE
1685 * lread.c (openp): Don't stuff size_t into an 'int'.
1686 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1687 about possible signed overflow.
1688
6048fb2a
PE
1689 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1690 (GDK_KEY_g): Don't define if already defined.
1691 (xg_prepare_tooltip): Avoid pointer signedness problem.
1692 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1693
fa3c87e1
PE
1694 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1695 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1696
2172544b
PE
1697 * xfns.c (Fx_window_property): Simplify a bit,
1698 to make a bit faster and to avoid GCC 4.6.0 warning.
1699 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1700
9b821a21
PE
1701 * fns.c (internal_equal): Don't assume size_t fits in int.
1702
3c616cfa
PE
1703 * alloc.c (compact_small_strings): Tighten assertion a little.
1704
c2982e87
PE
1705 Replace pEd with more-general pI, and fix some printf arg casts.
1706 * lisp.h (pI): New macro, generalizing old pEd macro to other
1707 conversion specifiers. For example, use "...%"pI"d..." rather
1708 than "...%"pEd"...".
1709 (pEd): Remove. All uses replaced with similar uses of pI.
1710 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1711 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1712 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1713 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1714 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1715 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1716 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1717 64-bit hosts.
1718 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1719 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1720 * print.c (safe_debug_print, print_object): Likewise.
1721 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1722 to int.
6f04d126
PE
1723 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1724 avoiding the 0 flag, which is not portable.
c2982e87
PE
1725 * process.c (Fmake_network_process): Use pI to avoid cast.
1726 * region-cache.c (pp_cache): Likewise.
1727 * xdisp.c (decode_mode_spec): Likewise.
1728 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1729 behavior on 64-bit hosts with printf arg.
6f04d126 1730 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1731 (x_stop_queuing_selection_requests): Likewise.
1732 (x_get_window_property): Don't truncate byte count to an 'int'
1733 when tracing.
0b432f21 1734
5e073ec7
PE
1735 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1736 here, since it parses constructs like leading '-' and spaces,
1737 which are not wanted; and it overflows with large numbers.
1738 Instead, simply match F[0-9]+, which is what is wanted anyway.
1739
36372bf9
PE
1740 * alloc.c: Remove unportable assumptions about struct layout.
1741 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1742 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1743 (allocate_vectorlike, make_pure_vector): Use the new macros,
1744 plus offsetof, to remove unportable assumptions about struct layout.
1745 These assumptions hold on all porting targets that I know of, but
1746 they are not guaranteed, they're easy to remove, and removing them
1747 makes further changes easier.
1748
0b432f21
PE
1749 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1750 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1751 (string_overrun_cookie): Now const. Use initializers that
1752 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1753 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1754 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1755 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1756 multiple of sizeof (EMACS_INT); it need not be, if
1757 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1758 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1759
895009e1
JB
17602011-04-26 Juanma Barranquero <lekktu@gmail.com>
1761
1762 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1763
6a7a1b0b
TZ
17642011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1765
1766 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1767 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1768 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1769
841a1577 17702011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1771
1772 * lisp.h (Qdebug): List symbol.
895009e1 1773 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1774 * keyboard.c (debug-on-event): New variable.
1775 (handle_user_signal): Break into debugger when debug-on-event
1776 matches the current signal symbol.
1777
f2d3ba6f
DN
17782011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1779
1780 * alloc.c (check_sblock, check_string_bytes)
1781 (check_string_free_list): Convert to standard C.
1782
42ce4c63
TZ
17832011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1784
1785 * w32.c (emacs_gnutls_push): Fix typo.
1786
825cd63c
EZ
17872011-04-25 Eli Zaretskii <eliz@gnu.org>
1788
fb11d64d
EZ
1789 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1790 "cast to pointer from integer of different size".
1791
825cd63c
EZ
1792 Improve doprnt and its use in verror. (Bug#8545)
1793 * doprnt.c (doprnt): Document the set of format control sequences
1794 supported by the function. Use SAFE_ALLOCA instead of always
1795 using `alloca'.
1796
1797 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1798 is one byte too soon. Don't use xrealloc; instead xfree and
1799 xmalloc anew.
1800
e061a11b
TZ
18012011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1802
1803 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1804 callbacks stage.
1805
1806 * gnutls.c: Renamed global_initialized to
1807 gnutls_global_initialized. Added internals for the
1808 :verify-hostname-error, :verify-error, and :verify-flags
1809 parameters of `gnutls-boot' and documented those parameters in the
1810 docstring. Start callback support.
1811 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1812 unless a fatal error occured. Call gnutls_alert_send_appropriate
1813 on error. Return error code.
1814 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1815 (emacs_gnutls_read): Likewise.
1816 (Fgnutls_boot): Return handshake error code.
1817 (emacs_gnutls_handle_error): New function.
1818 (wsaerror_to_errno): Likewise.
1819
1820 * w32.h (emacs_gnutls_pull): Add prototype.
1821 (emacs_gnutls_push): Likewise.
1822
1823 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1824 (emacs_gnutls_push): Likewise.
1825
18262011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1827
1828 * process.c (wait_reading_process_output): Check if GnuTLS
1829 buffered some data internally if no FDs are set for TLS
1830 connections.
1831
1832 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1833 (LIBS): Link to USER_LIBS.
1834 ($(BLD)/gnutls.$(0)): New target.
1835
fa6996bc
EZ
18362011-04-24 Eli Zaretskii <eliz@gnu.org>
1837
eb35682e
EZ
1838 * xdisp.c (handle_single_display_spec): Rename the
1839 display_replaced_before_p argument into display_replaced_p, to
1840 make it consistent with the commentary. Fix typos in the
1841 commentary.
1842
e2ad650c
EZ
1843 * textprop.c (syms_of_textprop): Remove dead code.
1844 (copy_text_properties): Delete obsolete commentary about an
1845 interface that was deleted long ago. Fix typos in the description
1846 of arguments.
1847
1b2de274
EZ
1848 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1849 to changes in oldXMenu/XMenu.h from 2011-04-16.
1850 <menu_help_message, prev_menu_help_message>: Constify.
1851 (IT_menu_make_room): menu->help_text is now `const char **';
1852 adjust.
1853
1854 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1855 to changes in oldXMenu/XMenu.h from 2011-04-16.
1856 (struct XMenu): Declare `help_text' `const char **'.
1857
1858 * xfaces.c <Qunspecified>: Make extern again.
1859
1860 * syntax.c: Include sys/types.h before including regex.h, as
1861 required by Posix.
1862
762b15be
EZ
1863 * doc.c (get_doc_string): Improve the format passed to `error'.
1864
1865 * doprnt.c (doprnt): Improve commentary.
1866
1867 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1868
1869 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1870 them with etags.
1871
f1052e5d
EZ
1872 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1873 changes in globals.h immediately force recompilation.
762b15be
EZ
1874 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1875 $(CURDIR)/s/ms-w32.h.
1876 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1877
fa6996bc
EZ
1878 * character.c (Fchar_direction): Function deleted.
1879 (syms_of_character): Don't defsubr it.
1880 <char-direction-table>: Deleted.
1881
e6c3da20
EZ
18822011-04-23 Eli Zaretskii <eliz@gnu.org>
1883
1884 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1885 * doprnt.c: Include limits.h.
1886 (SIZE_MAX): New macro.
04f2d78b
CB
1887 (doprnt): Return a size_t value. 2nd arg is now size_t.
1888 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1889 Improve overflow protection. Support `l' modifier for integer
1890 conversions. Support %l conversion. Don't assume an EMACS_INT
1891 argument for integer conversions and for %c.
1892
1893 * lisp.h (doprnt): Restore prototype.
1894
1895 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1896 $(SRC)/character.h.
1897
1898 * Makefile.in (base_obj): Add back doprnt.o.
1899
1900 * deps.mk (doprnt.o): Add back prerequisites.
1901 (callint.o): Depend on character.h.
1902
1903 * eval.c (internal_lisp_condition_case): Include the handler
1904 representation in the error message.
1905 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1906 when breaking from the loop.
1907
1908 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1909
1910 * callint.c (Fcall_interactively): When displaying error message
1911 about invalid control letter, pass the character's codepoint, not
1912 a pointer to its multibyte form. Improve display of the character
1913 in octal and display also its hex code.
1914
1915 * character.c (char_string): Use %x to display the (unsigned)
1916 codepoint of an invalid character, to avoid displaying a bogus
1917 negative value.
1918
1919 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1920 `error', not SYMBOL_NAME itself.
1921
1922 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1923 character arguments to `error'.
1924
1925 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1926 to `error' in error message about FINAL_CHAR argument. Make sure
1927 FINAL_CHAR is a character, and use %c when it is passed as
1928 argument to `error'.
1929
4ffd0d6b 19302011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1931
1932 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1933
1934 * w32.c: Include <time.h>.
1935 (sys_localtime): New function.
1936
4ffd0d6b 19372011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1938
1939 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1940
4ffd0d6b 1941 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1942
4ffd0d6b 19432011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1944
4ffd0d6b
GM
1945 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1946 zombies (Bug#8467).
aac0c6e3 1947
04c56954
EZ
19482011-04-19 Eli Zaretskii <eliz@gnu.org>
1949
1950 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1951 gl_state.e_property when gl_state.object is Qt.
1952
1953 * insdel.c (make_gap_larger): Remove limitation of buffer size
1954 to <= INT_MAX.
1955
16a43933
CY
19562011-04-18 Chong Yidong <cyd@stupidchicken.com>
1957
1958 * xdisp.c (lookup_glyphless_char_display)
1959 (produce_glyphless_glyph): Handle cons cell entry in
1960 glyphless-char-display.
1961 (Vglyphless_char_display): Document it.
1962
1963 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1964 glyphless-char-display.
1965
4581706e
CY
19662011-04-17 Chong Yidong <cyd@stupidchicken.com>
1967
1968 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1969
1970 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1971
1972 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1973 definition for no-X builds.
1974
4887c6e2 19752011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1976
fd35b6f9
PE
1977 Static checks with GCC 4.6.0 and non-default toolkits.
1978
5c1ccb01
PE
1979 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1980
006c5daa
PE
1981 * process.c (keyboard_bit_set): Define only if SIGIO.
1982 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1983 (send_process): Repair possible setjmp clobbering.
1984
efc736d3
PE
1985 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1986
4e2fe2e6
PE
1987 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1988
f97334a2
PE
1989 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1990
4e75f29d
PE
1991 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1992 Define only if needed.
1993
90efadd1
PE
1994 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1995 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1996 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1997
3c647824
PE
1998 * dispextern.h (struct redisplay_interface): Rename param
1999 to avoid shadowing.
e264f262 2000 * termhooks.h (struct terminal): Likewise.
761383f4 2001 * xterm.c (xembed_send_message): Likewise.
3c647824 2002
b58c5c4a
PE
2003 * insdel.c (make_gap_smaller): Define only if
2004 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2005
cad59032
PE
2006 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2007 it.
2008
c339dc2e
PE
2009 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2010 so that we aren't warned about unused symbols.
2011
91a3e27b
PE
2012 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2013
399c71d3 2014 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2015
8ffc96f5
PE
2016 * xfns.c (x_real_positions): Mark locals as initialized.
2017
eef9bc79
PE
2018 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2019
098db9dd
PE
2020 * xterm.c: Fix problems found by static analysis with other toolkits.
2021 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2022 (x_dispatch_event): Declare static if USE_GTK, and
2023 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2024 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2025 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2026 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2027 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2028
eb18f6cc
PE
2029 * xmenu.c (menu_help_callback): Pointer type fixes.
2030 Use const pointers when pointing at readonly data. Avoid pointer
2031 signedness clashes.
2032 (FALSE): Remove unused macro.
2033 (update_frame_menubar): Remove unused decl.
2034
1fe72bf8
PE
2035 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2036
60d9e1db
PE
2037 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2038 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2039 (single_menu_item): Rename local to avoid shadowing.
2040
39261c26
PE
2041 * keyboard.c (make_lispy_event): Remove unused local var.
2042
018c5e19
PE
2043 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2044 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2045
63d2b86e
PE
2046 * bitmaps: Change bitmaps from unsigned char back to the X11
2047 compatible char. Avoid the old compiler warnings about
2048 out-of-range initializers by using, for example, '\xab' rather
2049 than 0xab.
2050
aefd87e1
PE
2051 * xgselect.c (xgselect_initialize): Check vs interface
2052 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2053
bf501fb9
PE
2054 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2055
e9829fdf
PE
2056 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2057 to read-only memory.
2058
1086c095
PE
2059 * fns.c (vector): Remove; this old hack is no longer needed.
2060
2baccd04 2061 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2062 Remove unused var.
dde42981 2063 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2064
72391843 2065 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2066
436c16df 2067 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2068 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2069 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2070
92bb796d 2071 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2072 (x_term_init): Remove local to avoid shadowing.
92bb796d 2073
764430a3 2074 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2075
2076 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2077 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2078
d1dfb56c
EZ
20792011-04-16 Eli Zaretskii <eliz@gnu.org>
2080
c4354cb4
EZ
2081 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2082
d1dfb56c
EZ
2083 Fix regex.c, syntax.c and friends for buffers > 2GB.
2084 * syntax.h (struct gl_state_s): Declare character position members
2085 EMACS_INT.
2086
2087 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2088
04f2d78b
CB
2089 * textprop.c (verify_interval_modification, interval_of):
2090 Declare arguments EMACS_INT.
d1dfb56c
EZ
2091
2092 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2093 EMACS_INT.
2094
2095 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2096
2097 * indent.c (Fvertical_motion): Local variable it_start is now
2098 EMACS_INT.
2099
2100 * regex.c (re_match, re_match_2, re_match_2_internal)
2101 (bcmp_translate, regcomp, regexec, print_double_string)
2102 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2103 (re_compile_pattern, re_exec): Declare arguments and local
2104 variables `size_t' and `ssize_t' and return values `regoff_t', as
2105 appropriate.
2106 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2107 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2108 <compile_stack_type>: `size' and `avail' are now `size_t'.
2109
2110 * regex.h <regoff_t>: Use ssize_t, not int.
2111 (re_search, re_search_2, re_match, re_match_2): Arguments that
2112 specify buffer/string position and length are now ssize_t and
2113 size_t. Return type is regoff_t.
2114
613052cd
BK
21152011-04-16 Ben Key <bkey76@gmail.com>
2116
2117 * nsfont.m: Fixed bugs in ns_get_family and
2118 ns_descriptor_to_entity that were caused by using free to
2119 deallocate memory blocks that were allocated by xmalloc (via
2120 xstrdup). This caused Emacs to crash when compiled with
2121 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2122 --enable-checking=xmallocoverrun). xfree is now used to
2123 deallocate these memory blocks.
2124
4170f62f 21252011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2126
71b41406
PE
2127 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2128
9587a89d
PE
2129 emacs_write: Accept and return EMACS_INT for sizes.
2130 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2131 et seq.
2132 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2133 Accept and return EMACS_INT.
2134 (emacs_gnutls_write): Return the number of bytes written on
2135 partial writes.
2136 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2137 (emacs_read, emacs_write): Remove check for negative size, as the
2138 Emacs source code has been audited now.
9587a89d
PE
2139 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2140 (emacs_read, emacs_write): Use it.
273a5f82
PE
2141 * process.c (send_process): Adjust to the new signatures of
2142 emacs_write and emacs_gnutls_write. Do not attempt to store
2143 a byte offset into an 'int'; it might overflow.
9587a89d 2144 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2145
3e047f51
PE
2146 * sound.c: Don't assume sizes fit in 'int'.
2147 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2148 Return EMACS_INT, not int.
3e047f51 2149 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2150 Accept EMACS_INT, not int.
2151 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2152 record read return values.
2153
cc39a9db
BK
21542011-04-15 Ben Key <bkey76@gmail.com>
2155
c9d0ec6d
JB
2156 * keyboard.c (Qundefined): Don't declare static since it is used
2157 in nsfns.m.
2158 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2159 static since they are used in nsfont.m.
cc39a9db 2160
6c60eb9f
SM
21612011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2162
2163 * process.c (Qprocessp): Don't declare static.
2164 * lisp.h (Qprocessp): Declare again.
2165
7990b61a
JB
21662011-04-15 Juanma Barranquero <lekktu@gmail.com>
2167
2168 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2169
5d4cb038
PE
21702011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2171
8bd7b830 2172 Improve C-level modularity by making more things 'static'.
cd64ea1d 2173
e3b27b31
PE
2174 Don't publish debugger-only interfaces to other modules.
2175 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2176 (verify_bytepos, count_markers): Move decls to the only modules
2177 that need them.
2178 * region-cache.h (pp_cache): Likewise.
2179 * window.h (check_all_windows): Likewise.
2180 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2181
5d4cb038
PE
2182 * sysdep.c (croak): Now static, if
2183 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2184 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2185
2186 * alloc.c (refill_memory_reserve): Now static if
2187 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2188 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2189
e87b6180
PE
2190 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2191 Define only if USE_LUCID.
2192
ac64929e
PE
2193 * xrdb.c (x_customization_string, x_rm_string): Now static.
2194
6f37259d
PE
2195 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2196 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2197
1683e3ab
PE
2198 * xdisp.c (draw_row_with_mouse_face): Now static.
2199 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2200
de9c2632
PE
2201 * window.h (check_all_windows): Mark externally visible.
2202
2b96acb7
PE
2203 * window.c (window_deletion_count): Now static.
2204
2205 * undo.c: Make symbols static if they're not exported.
2206 (last_undo_buffer, last_boundary_position, pending_boundary):
2207 Now static.
2208
50436f33
PE
2209 * textprop.c (interval_insert_behind_hooks): Now static.
2210 (interval_insert_in_front_hooks): Likewise.
2211
64520e5c
PE
2212 * term.c: Make symbols static if they're not exported.
2213 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2214 (max_frame_lines, tty_set_terminal_modes):
2215 (tty_reset_terminal_modes, tty_turn_off_highlight):
2216 (get_tty_terminal): Now static.
2217 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2218 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2219 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2220 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2221 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2222
1fa53021
PE
2223 * sysdep.c: Make symbols static if they're not exported.
2224 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2225 Now static.
2226 (sigprocmask_set, full_mask): Remove; unused.
2227 (wait_debugging): Mark as visible.
2228 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2229 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2230
d4b43b22
PE
2231 * syntax.c (syntax_temp): Define only if !__GNUC__.
2232
b7c513d0
PE
2233 * sound.c (current_sound_device, current_sound): Now static.
2234
989b29ad
PE
2235 * search.c (searchbufs, searchbuf_head): Now static.
2236
13a55a78
PE
2237 * scroll.c (scroll_cost): Remove; unused.
2238 * dispextern.h (scroll_cost): Remove decl.
2239
de68a1fc
PE
2240 * region-cache.h (pp_cache): Mark as externally visible.
2241
40ccffa6
PE
2242 * process.c: Make symbols static if they're not exported.
2243 (process_tick, update_tick, create_process, chan_process):
2244 (Vprocess_alist, proc_buffered_char, datagram_access):
2245 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2246 (deactivate_process): Mark defn as static, as well as decl.
2247 * lisp.h (create_process): Remove decl.
2248 * process.h (chan_process, Vprocess_alist): Remove decls.
2249
ad64fc97
PE
2250 * print.c: Make symbols static if they're not exported.
2251 (print_depth, new_backquote_output, being_printed, print_buffer):
2252 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2253 (print_interval, print_number_index, initial_stderr_stream):
2254 Now static.
2255 * lisp.h (Fprinc): Remove decl.
2256 (debug_output_compilation_hack): Mark as externally visible.
2257
adddb265
PE
2258 * sysdep.c (croak): Move decl from here to syssignal.h.
2259 * syssignal.h (croak): Put it here, so the API can be checked when
2260 'croak' is called from dissociate_if_controlling_tty.
2261
1717ede2
PE
2262 * minibuf.c: Make symbols static if they're not exported.
2263 (minibuf_save_list, choose_minibuf_frame): Now static.
2264 * lisp.h (choose_minibuf_frame): Remove decl.
2265
fa5fb2bc
PE
2266 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2267
1e3890d1
PE
2268 * lread.c: Make symbols static if they're not exported.
2269 (read_objects, initial_obarray, oblookup_last_bucket_number):
2270 Now static.
2271 (make_symbol): Remove; unused.
2272 * lisp.h (initial_obarray, make_symbol): Remove decls.
2273
8a1414fa
PE
2274 * keyboard.c: Make symbols static if they're not exported.
2275 (single_kboard, recent_keys_index, total_keys, recent_keys):
2276 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2277 (this_single_command_key_start, echoing, last_auto_save):
2278 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2279 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2280 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2281 (Vlispy_mouse_stem, double_click_count):
2282 Now static.
2283 (force_auto_save_soon): Define only if SIGDANGER.
2284 (ignore_mouse_drag_p): Now static if
2285 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2286 (print_help): Remove; unused.
2287 (stop_character, last_timer_event): Mark as externally visible.
2288 * keyboard.h (ignore_mouse_drag_p): Declare only if
2289 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2290 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2291 * lisp.h (echoing): Remove decl.
2292 (force_auto_save_soon): Declare only if SIGDANGER.
2293 * xdisp.c (redisplay_window): Simplify code, to make it more
2294 obvious that ignore_mouse_drag_p is not accessed if !defined
2295 USE_GTK && !defined HAVE_NS.
2296
93ea6e8f
PE
2297 * intervals.c: Make symbols static if they're not exported.
2298 (merge_properties_sticky, merge_interval_right, delete_interval):
2299 Now static.
2300 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2301
77382fcc
PE
2302 * insdel.c: Make symbols static if they're not exported.
2303 However, leave prepare_to_modify_buffer alone. It's never
2304 called from outside this function, but that appears to be a bug.
2305 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2306 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2307 (adjust_after_replace_noundo): Remove; unused.
2308 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2309 (signal_before_change): Remove decls.
77382fcc 2310
9306c32e
PE
2311 * indent.c (val_compute_motion, val_vmotion): Now static.
2312
cd44d2eb
PE
2313 * image.c: Make symbols static if they're not exported.
2314 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2315 if USE_GTK.
2316 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2317 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2318
ad9a7a06
PE
2319 * fringe.c (standard_bitmaps): Now static.
2320 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2321
81626931
PE
2322 * frame.c: Make symbols static if they're not exported.
2323 (x_report_frame_params, make_terminal_frame): Now static.
2324 (get_frame_param): Now static, unless HAVE_NS.
2325 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2326 (x_get_resource_string): Remove; not used.
2327 * frame.h (make_terminal_frame, x_report_frame_params):
2328 (x_get_resource_string); Remove decls.
2329 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2330 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2331
239f9db9
PE
2332 * font.c, fontset.c: Make symbols static if they're not exported.
2333 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2334 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2335 * font.c (font_close_object): Now static.
2336 * font.h (font_close_object): Remove.
2337 * fontset.c (FONTSET_OBJLIST): Remove.
2338 (free_realized_fontset) #if-0 the body, which does nothing.
2339 (face_suitable_for_char_p): #if-0, as it's never called.
2340 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2341 * xfaces.c (face_at_string_position):
2342 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2343 since 0 is always ASCII.
2344
dfcf3579
PE
2345 * fns.c (weak_hash_tables): Now static.
2346
5045092b
PE
2347 * fileio.c: Make symbols static if they're not exported.
2348 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2349 (Vwrite_region_annotation_buffers): Now static.
2350
57a96f5c
PE
2351 * eval.c: Make symbols static if they're not exported.
2352 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2353 * lisp.h (backtrace_list): Remove decl.
2354
35f08c38
PE
2355 * emacs.c: Make symbols static if they're not exported.
2356 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2357 (fatal_error_code, fatal_error_signal_hook, standard_args):
2358 Now static.
2359 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2360 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2361 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2362 * lisp.h (fatal_error_signal_hook): Remove decl.
2363 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2364
f44bd759
PE
2365 * editfns.c: Move a (normally-unused) function to its only use.
2366 * editfns.c, lisp.h (get_operating_system_release): Remove.
2367 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2368 worth the hassle of breaking this out.
2369
b532497d
PE
2370 * xterm.c: Make symbols static if they're not exported.
2371 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2372 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2373 (x_destroy_window, x_delete_display):
2374 Now static.
2375 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2376 (x_mouse_leave): Remove; unused.
2377 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2378 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2379 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2380 Remove decls.
2381 (x_mouse_leave): Declare only if WINDOWSNT.
2382 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2383 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2384 USE_X_TOOLKIT.
2385
1675728f
PE
2386 * ftxfont.c: Make symbols static if they're not exported.
2387 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2388 HAVE_FREETYPE.
2389 * font.h (ftxfont_driver): Likewise.
2390
e4cebfca
PE
2391 * xfns.c: Make symbols static if they're not exported.
2392 (x_last_font_name, x_display_info_for_name):
2393 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2394 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2395 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2396 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2397 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2398 (last_show_tip_args): Now static.
2399 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2400 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2401 (x_screen_planes): Remove; unused.
2402 * dispextern.h (x_screen_planes): Remove decl.
2403
5bf46f05
PE
2404 * dispnew.c: Make symbols static if they're not exported.
2405 * dispextern.h (redraw_garbaged_frames, scrolling):
2406 (increment_row_positions): Remove.
2407 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2408 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2409 Now static.
2410 (redraw_garbaged_frames): Remove; unused.
2411
435f4c28
PE
2412 * xfaces.c: Make symbols static if they're not exported.
2413 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2414 Remove decls.
2415 * xterm.h (defined_color): Remove decls.
2416 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2417 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2418 (menu_face_changed_default, defined_color, free_realized_face):
2419 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2420 (ascii_face_of_lisp_face): Remove; unused.
2421
8524aef3
PE
2422 * xdisp.c: Make symbols static if they're not exported.
2423 * dispextern.h (scratch_glyph_row, window_box_edges):
2424 (glyph_to_pixel_coords, set_cursor_from_row):
2425 (get_next_display_element, set_iterator_to_next):
2426 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2427 (show_mouse_face): Remove decls
2428 * frame.h (message_buf_print): Likewise.
2429 * lisp.h (pop_message, set_message, check_point_in_composition):
2430 Likewise.
2431 * xterm.h (set_vertical_scroll_bar): Likewise.
2432 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2433 (message_buf_print, scratch_glyph_row, displayed_buffer):
2434 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2435 (get_next_display_element, show_mouse_face, window_box_edges):
2436 (frame_to_window_pixel_xy, check_point_in_composition):
2437 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2438 (glyph_to_pixel_coords): Remove; unused.
2439
16390cd2
PE
2440 * dired.c (file_name_completion): Now static.
2441
2442 * dbusbind.c (xd_in_read_queued_messages): Now static.
2443
a25f4dfa
PE
2444 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2445 * data.c (circular_list_error): Remove.
2446
14a9c8df
PE
2447 * commands.h (last_point_position, last_point_position_buffer):
2448 (last_point_position_window): Remove decls.
2449 * keyboard.c: Make these variables static.
2450
04f2d78b
CB
2451 * coding.h (coding, code_convert_region, encode_coding_gap):
2452 Remove decls.
74ab6df5
PE
2453 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2454 (iso_code_class, detect_coding, code_convert_region): Now static.
2455 (encode_coding_gap): Remove; unused.
2456
38dfbee1
PE
2457 * chartab.c (chartab_chars, chartab_bits): Now static.
2458
a2cb4e63
PE
2459 * charset.h (charset_iso_8859_1): Remove decl.
2460 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2461 Now static.
2462
127198fd
PE
2463 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2464 * ccl.c (Vccl_program_table): Now static.
2465 (check_ccl_update): Remove; unused.
2466
d85b608f
PE
2467 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2468 * category.h: ... from here.
2469 * category.c (check_category_table, set_category_set): Now static.
2470
31cd66f3
PE
2471 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2472 * lisp.h: Remove these decls.
2473
c358e587
PE
2474 * buffer.c (buffer_count): Remove unused var.
2475
e78aecca
PE
2476 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2477 so that it's not optimized away.
2478 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2479 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2480 exported only to the debugger.
2481
e192d7d3 2482 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2483 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2484
92470028
PE
2485 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2486 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2487 was inaccessible from Lisp.
2488 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2489 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2490
244ed907
PE
2491 alloc.c: Import and export fewer symbols, and remove unused items.
2492 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2493 is defined.
2494 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2495 it's not optimized away by whole-program optimization.
2496 (message_enable_multibyte, free_misc): Remove.
2497 (catchlist, handlerlist, mark_backtrace):
2498 Declare only if BYTE_MARK_STACK.
2499 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2500 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2501 (message_enable_multibyte): Remove decl.
2502 (free_misc, interval_free_list, float_block, float_block_index):
2503 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2504 (cons_free_list, last_marked_index):
2505 Now static.
2506 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2507 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2508 (mark_backtrace): Define only if BYTE_MARK_STACK.
2509 * xdisp.c (message_enable_multibyte): Now static.
2510
61c2b50e 2511 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2512 This makes it easier for human readers (and static analyzers)
2513 to see whether these variables are used from other modules.
2514 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2515 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2516 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2517 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2518 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2519 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2520 * xmenu.c, xselect.c:
2521 Declare Q* vars static if they are not used in other modules.
2522 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2523 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2524 Remove decls of unexported vars.
2525 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2526
95c82688
PE
2527 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2528
16a97296
PE
2529 Make Emacs functions such as Fatom 'static' by default.
2530 This makes it easier for human readers (and static analyzers)
2531 to see whether these functions can be called from other modules.
2532 DEFUN now defines a static function. To make the function external
2533 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2534 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2535 (Finit_image_library):
16a97296
PE
2536 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2537 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2538 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2539 Remove decls, since these functions are now static.
2540 (Funintern, Fget_internal_run_time): New decls, since these functions
2541 were already external.
95c82688 2542
16a97296
PE
2543 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2544 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2545 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2546 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2547 * keyboard.c, keymap.c, lread.c:
2548 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2549 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2550 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2551 Mark functions with DEFUE instead of DEFUN,
2552 if they are used in other modules.
2553 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2554 decls for now-static functions.
2555 * buffer.h (Fdelete_overlay): Remove decl.
2556 * callproc.c (Fgetenv_internal): Mark as internal.
2557 * composite.c (Fremove_list_of_text_properties): Remove decl.
2558 (Fcomposition_get_gstring): New forward static decl.
2559 * composite.h (Fcomposite_get_gstring): Remove decl.
2560 * dired.c (Ffile_attributes): New forward static decl.
2561 * doc.c (Fdocumntation_property): New forward static decl.
2562 * eval.c (Ffetch_bytecode): New forward static decl.
2563 (Funintern): Remove extern decl; now in .h file where it belongs.
2564 * fileio.c (Fmake_symbolic_link): New forward static decl.
2565 * image.c (Finit_image_library): New forward static decl.
2566 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2567 * intervals.h (Fprevious_property_change):
2568 (Fremove_list_of_text_properties): Remove decls.
2569 * keyboard.c (Fthis_command_keys): Remove decl.
2570 (Fcommand_execute): New forward static decl.
2571 * keymap.c (Flookup_key): New forward static decl.
2572 (Fcopy_keymap): Now static.
2573 * keymap.h (Flookup_key): Remove decl.
2574 * process.c (Fget_process): New forward static decl.
2575 (Fprocess_datagram_address): Mark as internal.
2576 * syntax.c (Fsyntax_table_p): New forward static decl.
2577 (skip_chars): Remove duplicate decl.
2578 * textprop.c (Fprevious_property_change): New forward static decl.
2579 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2580 Now internal.
2581 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2582 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2583
785bbd42
PE
2584 * editfns.c (Fformat): Remove unreachable code.
2585
8b913b57
AS
25862011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2587
2588 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2589 change. (Bug#8496)
2590
a6744a35
EZ
25912011-04-13 Eli Zaretskii <eliz@gnu.org>
2592
2593 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2594 when at ZV. (Bug#8487)
2595
e7974947
AS
25962011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2597
baad03f0
AS
2598 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2599 (Bug#8437)
2600 * keyboard.c (parse_tool_bar_item): Likewise.
2601 * sound.c (sound_cleanup, alsa_close): Likewise.
2602 * termcap.c (tgetent): Likewise.
2603 * xfns.c (x_default_font_parameter): Likewise.
2604 * xsettings.c (read_and_apply_settings): Likewise.
2605
e7974947
AS
2606 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2607 (overrun_check_free): Protoize.
2608
28272684
PE
26092011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2610
2611 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2612 since callers should never pass a negative size.
2613 Change the signature to match that of plain 'read' and 'write'; see
2614 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2615 * lisp.h: Update prototypes of emacs_write and emacs_read.
2616
11997c76
EZ
26172011-04-11 Eli Zaretskii <eliz@gnu.org>
2618
2619 * xdisp.c (redisplay_window): Don't try to determine the character
2620 position of the scroll margin if the window start point w->startp
e896f03c 2621 is outside the buffer's accessible region. (Bug#8468)
11997c76 2622
8a2cbd72
EZ
26232011-04-10 Eli Zaretskii <eliz@gnu.org>
2624
2625 Fix write-region and its subroutines for buffers > 2GB.
2626 * fileio.c (a_write, e_write): Modify declaration of arguments and
2627 local variables to support buffers larger than 2GB.
2628 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2629
2630 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2631 argument, local variables, and return value.
2632
2633 * lisp.h: Update prototypes of emacs_write and emacs_read.
2634
2635 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2636
4073e537 26372011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2638
1ebfdcb6
PE
2639 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2640
b2ded58d
PE
2641 Fix more problems found by GCC 4.6.0's static checks.
2642
7d66342c
PE
2643 * xdisp.c (vmessage): Use a better test for character truncation.
2644
bbf47d44
PE
2645 * charset.c (load_charset_map): <, not <=, for optimization,
2646 and to avoid potential problems with integer overflow.
9248994d 2647 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2648 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2649 * editfns.c (Fformat): Likewise.
1e69125e 2650 * syntax.c (skip_chars): Likewise.
3befa583 2651
e3019616
PE
2652 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2653 This also lets GCC 4.6.0 generate slightly better loop code.
2654
becfa255
PE
2655 * callint.c (Fcall_interactively): <, not <=, for optimization.
2656 (Fcall_interactively): Count the number of arguments produced,
2657 not the number of arguments given. This is simpler and lets GCC
2658 4.6.0 generate slightly better code.
2659
dae0cd48
PE
2660 * ftfont.c: Distingish more carefully between FcChar8 and char.
2661 The previous code passed unsigned char * to a functions like
2662 strlen and xstrcasecmp that expect char *, which does not
2663 conform to the C standard.
2664 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2665 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2666 char * when the C standard requires it.
2667
76032d70
PE
2668 * keyboard.c (read_char): Remove unused var.
2669
eb3f1cc8
PE
2670 * eval.c: Port to Windows vsnprintf (Bug#8435).
2671 Include <limits.h>.
2672 (SIZE_MAX): Define if the headers do not.
2673 (verror): Do not give up if vsnprintf returns a negative count.
2674 Instead, grow the buffer. This ports to Windows vsnprintf, which
2675 does not conform to C99. Problem reported by Eli Zaretskii.
2676 Also, simplify the allocation scheme, by avoiding the need for
2677 calling realloc, and removing the ALLOCATED variable.
2678
70476b54
PE
2679 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2680
12020a9e
PE
2681 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2682 But keep the doprint source code for now, as we might revamp it
2683 and use it again (Bug#8435).
ea6c7ae6
PE
2684 * lisp.h (doprnt): Remove.
2685 * Makefile.in (base_obj): Remove doprnt.o.
2686 * deps.mk (doprnt.o): Remove.
2687
5fdb398c
PE
2688 error: Print 32- and 64-bit integers portably (Bug#8435).
2689 Without this change, on typical 64-bit hosts error ("...%d...", N)
2690 was used to print both 32- and 64-bit integers N, which relied on
2691 undefined behavior.
2692 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2693 New macro.
2694 * lisp.h (error, verror): Mark as printf-like functions.
2695 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2696 Report overflow in size calculations when allocating printf buffer.
2697 Do not truncate output string at its first null byte.
2698 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2699 Truncate the output at a character boundary, since vsnprintf does not
2700 do that.
2701 * charset.c (check_iso_charset_parameter): Convert internal
2702 character to string before calling 'error', since %c now has the
2703 printf meaning.
2704 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2705 overflow when computing char to be passed to 'error'. Do not
2706 pass Lisp_Object to 'error'; pass the integer instead.
2707 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2708 formatted with plain %d.
2709
b189fa66
PE
2710 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2711
bff87ef0
PE
2712 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2713
7e2cac20
PE
2714 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2715
ce4d90b5
PE
2716 * xterm.c (x_catch_errors): Remove duplicate declaration.
2717
266c9547
PE
2718 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2719
79c49ad2
PE
2720 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2721
368f4090
JM
27222011-04-10 Jim Meyering <meyering@redhat.com>
2723
2724 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2725 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2726 return ssize_t not "int", and use size_t as the buffer length.
2727 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2728 * gnutls.h: Update declarations.
2729 * process.c (read_process_output): Use ssize_t, to match.
2730 (send_process): Likewise.
2731
a32d4040
CY
27322011-04-09 Chong Yidong <cyd@stupidchicken.com>
2733
2734 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2735
8546720e 27362011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2737
04f2d78b
CB
2738 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2739 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2740
8546720e
GM
2741 * xterm.c (handle_one_xevent):
2742 * xmenu.c (create_and_show_popup_menu):
2743 * xselect.c (x_decline_selection_request)
2744 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2745
0a2f5c1a 27462011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2747
2748 Fix some uses of `int' instead of EMACS_INT.
2749 * search.c (string_match_1, fast_string_match)
2750 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2751 (scan_buffer, find_next_newline_no_quit)
2752 (find_before_next_newline, search_command, Freplace_match)
2753 (Fmatch_data): Make some `int' variables be EMACS_INT.
2754
2755 * xdisp.c (display_count_lines): 3rd argument and return value now
2756 EMACS_INT. All callers changed.
2757 (pint2hrstr): Last argument is now EMACS_INT.
2758
2759 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2760 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2761 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2762 (decode_coding_utf_16, decode_coding_emacs_mule)
2763 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2764 (decode_coding_ccl, decode_coding_charset)
2765 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2766 (decode_coding_iso_2022, decode_coding_emacs_mule)
2767 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2768 <char_offset, last_offset>: Declare EMACS_INT.
2769 (encode_coding_utf_8, encode_coding_utf_16)
2770 (encode_coding_emacs_mule, encode_invocation_designation)
2771 (encode_designation_at_bol, encode_coding_iso_2022)
2772 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2773 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2774 Declare EMACS_INT.
2775 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2776 (encode_invocation_designation): Last argument P_NCHARS is now
2777 EMACS_INT.
2778 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2779 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2780
2781 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2782 All users changed.
2783
2784 * ccl.c (Fccl_execute_on_string): Declare some variables
2785 EMACS_INT.
2786
8546720e 27872011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2788
2789 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2790
4e19a977
CS
27912011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2792
2793 * process.c (Fformat_network_address): Doc fix.
2794
87302331
R
27952011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2796
2797 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2798
cbb59342
CY
27992011-04-08 Chong Yidong <cyd@stupidchicken.com>
2800
2801 * keyboard.c (read_char): Call Lisp function help-form-show,
2802 instead of using internal_with_output_to_temp_buffer.
2803 (Qhelp_form_show): New var.
e0d38eeb 2804 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2805
2806 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2807
2808 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2809
e67a13ab
CY
28102011-04-06 Chong Yidong <cyd@stupidchicken.com>
2811
04f2d78b
CB
2812 * process.c (Flist_processes): Remove to Lisp.
2813 (list_processes_1): Delete.
e67a13ab 2814
973f782d
EZ
28152011-04-06 Eli Zaretskii <eliz@gnu.org>
2816
7c106b1e
EZ
2817 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2818
973f782d
EZ
2819 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2820
41cf7d1a 28212011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2822
ca23cc88
PE
2823 Fix more problems found by GCC 4.6.0's static checks.
2824
f390e2d5
PE
2825 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2826
42eea0d0
PE
2827 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2828
b69769da 2829 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2830
f9541e84
PE
2831 * xdisp.c (vmessage): Mark as a printf-like function.
2832
13841b55
PE
2833 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2834
c136c10f
PE
2835 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2836
5e2d4a30
PE
2837 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2838 printf-like functions.
2839 (tiff_load): Add casts to remove these marks before passing them
2840 to system-supplied API.
2841
583f48b9
PE
2842 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2843
b25d760e
PE
2844 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2845 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2846 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2847 directly, rather than having caller test rule sign. This avoids
2848 some unnecessary tests.
2849 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2850 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2851 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2852
bc7b6697 2853 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2854 (xfont_open): Avoid unnecessary tests.
bc7b6697 2855
27ccc379
PE
2856 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2857
dcd5c89a
PE
2858 * composite.h, composite.c (composition_gstring_put_cache):
2859 Use EMACS_INT, not int, for length.
2860
b13a45c6
PE
2861 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2862 breaking out part of COMPOSITION_DECODE_RULE.
2863 (COMPOSITION_DECODE_RULE): Use it.
2864 * composite.c (get_composition_id): Remove unused local vars,
2865 by using the new macro.
2866
1e792e4d
PE
2867 * textprop.c (set_text_properties_1): Change while to do-while,
2868 since the condition is always true at first.
2869
dc6c6455 2870 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2871 (interval_deletion_adjustment): Return unsigned value.
2872 All uses changed.
dc6c6455 2873
aba7731a
PE
2874 * process.c (list_processes_1, create_pty, read_process_output):
2875 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2876 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2877 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2878 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2879 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2880
fdfc4bf3
PE
2881 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2882
fca8fe46 2883 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2884 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2885
06a0259a 2886 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2887 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2888 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2889
e7b9e80f
PE
2890 * print.c (print_error_message): Avoid int overflow.
2891
56201685
PE
2892 * font.c (font_list_entities): Redo for clarity,
2893 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2894
78834453 2895 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2896 (font_score): Avoid potential overflow in diff calculation.
78834453 2897
0bc0b309 2898 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2899 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2900
e610eaca
PE
2901 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2902
b895abce
PE
2903 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2904 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2905 can always succeed if overflow has undefined behavior.
2906
1f1d9321 2907 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2908 (wordify): Omit three unnecessary tests.
1f1d9321 2909
c59478bc
PE
2910 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2911 All callers changed. This avoids the need for an unused var.
2912
79b73827
PE
2913 * casefiddle.c (casify_region): Remove var that is set but not used.
2914
a4db5dfe
PE
2915 * dired.c (file_name_completion): Remove var that is set but not used.
2916
43aae36e
PE
2917 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2918
2a47c44d 2919 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2920 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2921
a37c69bf
PE
2922 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2923 Check for integer overflow on size calculations.
2924
328ab8e7
PE
2925 * buffer.c (Fprevious_overlay_change): Remove var that is set
2926 but not used.
2927
e5a2a5cb
PE
2928 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2929 Remove vars that are set but not used.
8d84a6eb 2930 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2931 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2932
a60e5f68
PE
2933 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2934
f661cb61 2935 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2936 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2937
f0397f5a
PE
2938 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2939 that are set but not used.
2940
8664db06 2941 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2942 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2943
6abdaa4a
PE
2944 * xselect.c (x_get_local_selection, x_handle_property_notify):
2945 Remove vars that are set but not used.
2946
0ce7538d 2947 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2948 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2949
9ae848fc
PE
2950 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2951 Remove var that is set but not used.
0b918413
PE
2952 (scroll_bar_windows_size): Now size_t, not int.
2953 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2954 Check for overflow.
9ae848fc 2955
a5a62657
PE
2956 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2957 (map_tty_color) [!defined MSDOS]: Likewise.
2958
5c5cdd39
PE
2959 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2960
66ebf983
PE
2961 * coding.c: Remove vars that are set but not used.
2962 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2963 All callers changed.
2964 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2965 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2966 (decode_coding_charset): Remove vars that are set but not used.
2967
1be4d761
PE
2968 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2969 that is set but not used.
2970
47553fa8
PE
2971 * print.c (print_object): Remove var that is set but not used.
2972
1f7196bf 2973 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2974 The gnulib version avoids calling malloc in the usual case,
2975 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2976 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2977 * filelock.c (current_lock_owner): Likewise.
2978 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2979 * sysdep.c: Include allocator.h, careadlinkat.h.
2980 (emacs_no_realloc_allocator): New static constant.
2981 (emacs_readlink): New function.
fdb61804
PE
2982 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2983 ../lib/careadlinkat.h.
d1fdcab7 2984
f84c17c7
SM
29852011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2986
2987 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2988 first non-nil return value).
2989
ef3862ad
JD
29902011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2991
2992 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2993 if not defined (Bug#8403).
2994
376a7006
JB
29952011-04-02 Juanma Barranquero <lekktu@gmail.com>
2996
2997 * xdisp.c (display_count_lines): Remove parameter `start',
2998 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2999 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3000 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3001 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3002 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3003 and thereabouts. All callers changed.
3004 (get_per_char_metric): Remove parameter `f', unused since
3005 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3006
6ca3801d
JM
30072011-04-02 Jim Meyering <meyering@redhat.com>
3008
3009 do not dereference NULL upon failed strdup
3010 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3011 (ns_get_family): Likewise.
3012
d8e2b5ba
JB
30132011-04-02 Juanma Barranquero <lekktu@gmail.com>
3014
3015 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3016
8c74fcbd
JD
30172011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3018
3019 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3020 later (Bug#8403).
3021
7200d79c
SM
30222011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3023
03408648 3024 Add lexical binding.
7200d79c 3025
03408648
SM
3026 * window.c (Ftemp_output_buffer_show): New fun.
3027 (Fsave_window_excursion):
3028 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3029
3030 * lread.c (lisp_file_lexically_bound_p): New function.
3031 (Fload): Bind Qlexical_binding.
3032 (readevalloop): Remove `evalfun' arg.
3033 Bind Qinternal_interpreter_environment.
3034 (Feval_buffer): Bind Qlexical_binding.
3035 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3036 Mark as dynamic.
3037 (syms_of_lread): Declare `lexical-binding'.
3038
3039 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3040
3041 * keyboard.c (eval_dyn): New fun.
3042 (menu_item_eval_property): Use it.
ca105506
SM
3043
3044 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3045
03408648
SM
3046 * fns.c (concat, mapcar1): Accept byte-code-functions.
3047
3048 * eval.c (Fsetq): Handle lexical vars.
3049 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3050 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3051 (FletX, Flet): Obey lexical binding.
3052 (Fcommandp): Handle closures.
3053 (Feval): New `lexical' arg.
3054 (eval_sub): New function extracted from Feval. Use it almost
3055 everywhere where Feval was used. Look up vars in lexical env.
3056 Handle closures.
3057 (Ffunctionp): Move from subr.el.
3058 (Ffuncall): Handle closures.
3059 (apply_lambda): Remove `eval_flags'.
3060 (funcall_lambda): Handle closures and new byte-code-functions.
3061 (Fspecial_variable_p): New function.
3062 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3063 but without exporting it to Lisp.
23aba0ea 3064
23aba0ea 3065 * doc.c (Fdocumentation, store_function_docstring):
03408648 3066 * data.c (Finteractive_form): Handle closures.
23aba0ea 3067
03408648
SM
3068 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3069 interactive spec.
ba83908c 3070
04f2d78b
CB
3071 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3072 New byte-codes.
03408648
SM
3073 (exec_byte_code): New function extracted from Fbyte_code to handle new
3074 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3075
03408648 3076 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3077
03408648 3078 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3079
e2abce01
JB
30802011-03-31 Juanma Barranquero <lekktu@gmail.com>
3081
3082 * xdisp.c (redisplay_internal): Fix prototype.
3083
63696a73 30842011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3085
63696a73 3086 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3087 (try_scrolling): Use it when setting scroll_limit.
3088 Limit scrolling to 100 screen lines.
63696a73
EZ
3089 (redisplay_window): Even when falling back on "recentering",
3090 position point in the window according to scroll-conservatively,
3091 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3092
3093 (try_scrolling): When point is above the window, allow searching
3094 as far as scroll_max, or one screenful, to compute vertical
3095 distance from PT to the scroll margin position. This prevents
3096 try_scrolling from unnecessarily failing when
3097 scroll-conservatively is set to a value slightly larger than the
3098 window height. Clean up the case of PT below the margin at bottom
3099 of window: scroll_max can no longer be INT_MAX. When aggressive
3100 scrolling is in use, don't let point enter the opposite scroll
3101 margin as result of the scroll.
3102 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3103 threshold of 100 lines for never-recentering scrolling.
3104
e4cc2dfc
JB
31052011-03-31 Juanma Barranquero <lekktu@gmail.com>
3106
3107 * dispextern.h (move_it_by_lines):
3108 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3109 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3110 (message_log_check_duplicate): Remove parameters `prev_bol' and
3111 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3112 (redisplay_internal): Remove parameter `preserve_echo_area',
3113 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3114
3115 * indent.c (Fvertical_motion):
3116 * window.c (window_scroll_pixel_based, Frecenter):
3117 Don't pass `need_y_p' to `move_it_by_lines'.
3118
1c470562
SM
31192011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3120
44f230aa
SM
3121 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3122 steal a few bits to be more compact.
3123 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3124 Remove unneeded casts.
3125
1c470562
SM
3126 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3127
888adce9
ZK
31282011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3129
3130 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3131 binding" message (bug#7967).
3132
f838ed7b
PE
31332011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3134
77861b95
PE
3135 Fix more problems found by GCC 4.6.0's static checks.
3136
de6dbc14
PE
3137 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3138 Remove unused local var.
3139
f838ed7b
PE
3140 * editfns.c (Fmessage_box): Remove unused local var.
3141
792c7b2b
PE
3142 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3143 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3144 Omit unused local vars.
c499e557 3145 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3146 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3147 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3148 Omit unused local var.
3149
ba0165e1
PE
3150 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3151 Don't assume string length fits in int.
32ad8845 3152 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3153 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3154
3c59b4c9
PE
3155 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3156 instead of alloca (Bug#8344).
3157
a3eed478 3158 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3159 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3160
eb4d412d
PE
3161 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3162
1658b401
PE
3163 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3164 concerns.
3165
3166 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3167
3168 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3169
9a2c6e05
PE
3170 * keyboard.c (syms_of_keyboard): Use the same style as later
3171 in this function when indexing through an array. This also
3172 works around GCC bug 48267.
3173
03d0a109
PE
3174 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3175
44f730c8
PE
3176 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3177
fe75f926
PE
3178 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3179 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3180
ffa8c828
PE
3181 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3182 This avoids undefined behavior on integer overflow, and is a bit
3183 more convenient anyway since it is compared to a size_t variable.
3184
c5101a77
PE
3185 Variadic C functions now count arguments with size_t, not int.
3186 This avoids an unnecessary limitation on 64-bit machines, which
3187 caused (substring ...) to crash on large vectors (Bug#8344).
3188 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3189 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3190 All variadic functions and their callers changed accordingly.
c5101a77
PE
3191 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3192 * data.c (arith_driver, float_arith_driver): Likewise.
3193 * editfns.c (general_insert_function): Likewise.
3194 * eval.c (struct backtrace.nargs, interactive_p)
3195 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3196 (funcall_lambda, mark_backtrace): Likewise.
3197 * fns.c (concat): Likewise.
3198 * frame.c (x_set_frame_parameters): Likewise.
3199 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3200 0 if not found, not -1. All callers changed.
3201
dd3f25f7
PE
3202 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3203 (stack_copy_size): Now size_t, not int.
3204 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3205
461c2ab9
JB
32062011-03-28 Juanma Barranquero <lekktu@gmail.com>
3207
3208 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3209 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3210 All callers changed.
3211
3212 * lisp.h (multibyte_char_to_unibyte):
3213 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3214 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3215 * character.h (CHAR_TO_BYTE8):
3216 * cmds.c (internal_self_insert):
3217 * editfns.c (general_insert_function):
3218 * keymap.c (push_key_description):
3219 * search.c (Freplace_match):
3220 * xdisp.c (message_dolog, set_message_1): All callers changed.
3221
f6d62986
SM
32222011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3223
3224 * keyboard.c (safe_run_hook_funcall): New function.
3225 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3226 don't set the hook to nil, but remove the offending function instead.
3227 (Qcommand_hook_internal): Remove, unused.
3228 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3229 Vcommand_hook_internal.
3230
3231 * eval.c (enum run_hooks_condition): Remove.
3232 (funcall_nil, funcall_not): New functions.
3233 (run_hook_with_args): Call each function through a `funcall' argument.
3234 Remove `cond' argument, now redundant.
3235 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3236 (Frun_hook_with_args_until_failure): Adjust accordingly.
3237 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3238
1db5b1ad
JB
32392011-03-28 Juanma Barranquero <lekktu@gmail.com>
3240
3241 * dispextern.h (string_buffer_position): Remove declaration.
3242
3243 * print.c (strout): Remove parameter `multibyte', unused since
3244 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3245
3246 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3247 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3248 All callers changed.
3249
3250 * w32.c (_wsa_errlist): Use braces for struct initializers.
3251
3252 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3253 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3254 All callers changed.
3255 (string_buffer_position): Likewise. Also, make static (it's never
3256 used outside xdisp.c).
3257 (cursor_row_p): Remove parameter `w', unused since
3258 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3259 (decode_mode_spec): Remove parameter `precision', introduced during
3260 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3261 All callers changed.
3262
5ffb62aa
JD
32632011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3264
3265 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3266
461c2ab9 32672011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3268
3269 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3270 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3271 (ns_update_auto_hide_menu_bar): New functions.
3272 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3273 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3274 ns_constrain_all_frames.
3275 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3276 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3277
5c380ffb
JD
32782011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3279
3280 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3281
9af30bdf
GM
32822011-03-27 Glenn Morris <rgm@gnu.org>
3283
3284 * syssignal.h: Replace RETSIGTYPE with void.
3285 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3286 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3287 Replace SIGTYPE with void everywhere.
3288 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3289 * s/template.h (SIGTYPE): Remove commented out definition.
3290
e2abce01
JB
32912011-03-26 Eli Zaretskii <eliz@gnu.org>
3292
3293 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3294 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3295
f868cd8a
JB
32962011-03-26 Juanma Barranquero <lekktu@gmail.com>
3297
59eb0929
JB
3298 * w32.c (read_unc_volume): Use parameter `henum', instead of
3299 global variable `wget_enum_handle'.
3300
3301 * keymap.c (describe_vector): Remove parameters `indices' and
3302 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3303 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3304
f868cd8a
JB
3305 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3306
3307 * keyboard.c (timer_check): Remove parameter `do_it_now',
3308 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3309 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3310 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3311
3312 * keyboard.c (read_char):
3313 * w32menu.c (w32_menu_display_help):
3314 * xmenu.c (show_help_event, menu_help_callback):
3315 Adjust calls to `show_help_echo'.
3316
3317 * gtkutil.c (xg_maybe_add_timer):
3318 * keyboard.c (readable_events):
3319 * process.c (wait_reading_process_output):
3320 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3321
3322 * insdel.c (adjust_markers_gap_motion):
3323 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3324 (gap_left, gap_right): Don't call it.
3325
2ecf6fdb
CY
33262011-03-25 Chong Yidong <cyd@stupidchicken.com>
3327
3328 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3329 incurred during fontification.
3330
6b1f9ba4
JB
33312011-03-25 Juanma Barranquero <lekktu@gmail.com>
3332
3333 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3334 (DEFVAR_PER_BUFFER): Don't pass it.
3335
3336 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3337 (scrolling_window): Don't pass it.
3338
0f4a96b5
JB
33392011-03-25 Juanma Barranquero <lekktu@gmail.com>
3340
3341 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3342
3343 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3344 and `suffix'.
3345 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3346 of variables specific to SELinux and computation of `encoded_absname'.
3347
3348 * image.c (XPutPixel): Remove unused variable `height'.
3349
3350 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3351
3352 * unexw32.c (get_section_info): Remove unused variable `section'.
3353
3354 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3355 (system_process_attributes): Remove unused variable `sess'.
3356 (sys_read): Remove unused variable `err'.
3357
3358 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3359 (w32_wnd_proc): Remove unused variable `isdead'.
3360 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3361 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3362 (x_create_tip_frame): Remove unused variable `tem'.
3363
3364 * w32inevt.c (w32_console_read_socket):
3365 Remove unused variable `no_events'.
3366
3367 * w32term.c (x_draw_composite_glyph_string_foreground):
3368 Remove unused variable `width'.
3369
1149507c
JB
33702011-03-24 Juanma Barranquero <lekktu@gmail.com>
3371
3372 * w32term.c (x_set_glyph_string_clipping):
3373 Don't pass uninitialized region to CombineRgn.
3374
9c88f339
JB
33752011-03-23 Juanma Barranquero <lekktu@gmail.com>
3376
3377 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3378 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3379 (Fx_close_connection): Remove unused variable `i'.
3380
3381 * w32font.c (w32font_draw): Return number of glyphs.
3382 (w32font_open_internal): Remove unused variable `i'.
3383 (w32font_driver): Add missing initializer.
3384
3385 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3386 (fill_in_menu): Remove unused variable `items_added'.
3387
3388 * w32term.c (last_mouse_press_frame): Remove static global variable.
3389 (w32_clip_to_row): Remove unused variable `f'.
3390 (x_delete_terminal): Remove unused variable `i'.
3391
3392 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3393 (NOTHING): Remove unused static global variable.
3394 (uniscribe_check_otf): Remove unused variable `table'.
3395 (uniscribe_font_driver): Add missing initializers.
3396
dee091a3
JD
33972011-03-23 Julien Danjou <julien@danjou.info>
3398
3399 * term.c (Fsuspend_tty, Fresume_tty):
3400 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3401 * window.c (temp_output_buffer_show):
3402 * insdel.c (signal_before_change):
3403 * frame.c (Fhandle_switch_frame):
3404 * fileio.c (Fdo_auto_save):
3405 * emacs.c (Fkill_emacs):
3406 * editfns.c (save_excursion_restore):
3407 * cmds.c (internal_self_insert):
3408 * callint.c (Fcall_interactively):
3409 * buffer.c (Fkill_all_local_variables):
3410 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3411 Use Frun_hooks.
0f4a96b5 3412 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3413 unconditionnaly since it does the check itself.
3414
2c520ab5 34152011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3416
c9c49752
PE
3417 Fix more problems found by GCC 4.5.2's static checks.
3418
8abc3f12
PE
3419 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3420 the first time through the loop, since we know p0 < p1 then.
3421 This also avoids a gcc -Wstrict-overflow warning.
3422
a2d26660
PE
3423 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3424 leading to a memory leak, possible in functions like
3425 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3426 of objects (Bug#8318).
a2d26660 3427
916c72e9
PE
3428 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3429 that could (at least in theory) be that large.
3430
19ab8a18
PE
3431 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3432 This is less likely to overflow, and avoids undefined behavior if
3433 overflow does occur. All callers changed. Use strtoul to scan
3434 for the unsigned long integer.
b7cbbd6f
PE
3435 (pint2hrstr): Simplify and tune code slightly.
3436 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3437
f0641eff
PE
3438 * scroll.c (do_scrolling): Work around GCC bug 48228.
3439 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3440
7f650bb9
PE
3441 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3442 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3443 (validate_x_resource_name): Simplify count usage.
3444 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3445
37dd57d1
PE
3446 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3447 fail (Bug#8306).
81e56e61 3448
699979fc 3449 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3450
401bf9b4
PE
3451 * process.c (Fmake_network_process): Use socklen_t, not int,
3452 where POSIX says socklen_t is required in portable programs.
3453 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3454 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3455 (Fmake_network_process, server_accept_connection):
3456 (wait_reading_process_output, read_process_output):
3457 Likewise.
3458
b93aacde
PE
3459 * process.c: Rename or move locals to avoid shadowing.
3460 (list_processes_1, Fmake_network_process):
3461 (read_process_output_error_handler, exec_sentinel_error_handler):
3462 Rename or move locals.
4dc343ee 3463 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3464 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3465 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3466 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3467 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3468
af8a867c 3469 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3470 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3471 Include tparam.h instead, since it declares them.
af8a867c
PE
3472 * cm.h (PC): Remove extern decl; tparam.h now does this.
3473 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3474 * terminfo.c: Include tparam.h, to check interfaces.
3475 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3476 (tparam): Adjust signature to match interface in tparam.h;
3477 this removes some undefined behavior. Check that outstring and len
3478 are zero, which they always are with Emacs.
3479 * tparam.h (PC, BC, UP): New extern decls.
3480
0248044d 3481 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3482 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3483
8ff096c1 3484 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3485 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3486 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3487 (ftfont_list): Remove unused local.
49eaafba
PE
3488 (get_adstyle_property, ftfont_pattern_entity):
3489 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3490 Rename locals to avoid shadowing.
8ff096c1 3491
e2be39f6
PE
3492 * xfont.c (xfont_list_family): Mark var as initialized.
3493
c9735e30
PE
3494 * xml.c (make_dom): Now static.
3495
8f5201ae
PE
3496 * composite.c (composition_compute_stop_pos): Rename local to
3497 avoid shadowing.
b246f932
PE
3498 (composition_reseat_it): Remove unused locals.
3499 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3500 (composition_update_it): Mark var as initialized.
11b61122
PE
3501 (find_automatic_composition): Mark vars as initialized,
3502 with a FIXME (Bug#8290).
8f5201ae 3503
760fbc2c
PE
3504 character.h: Rename locals to avoid shadowing.
3505 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3506 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3507 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3508 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3509 to avoid shadowing.
3510
ff08eb85
PE
3511 * textprop.c (property_change_between_p): Remove; unused.
3512
fc7bf025
PE
3513 * intervals.c (interval_start_pos): Now static.
3514
235d7abc
PE
3515 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3516
44f230aa
SM
3517 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3518 Rename locals to avoid shadowing.
3e7d6594 3519
50060332
PE
3520 * sound.c (wav_play, au_play, Fplay_sound_internal):
3521 Fix pointer signedness.
d01f234b 3522 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3523 (wav_play): Initialize a variable to 0, to prevent undefined
3524 behavior (Bug#8278).
50060332 3525
c4fc4e30
PE
3526 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3527
918436ed
PE
3528 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3529
c939f91b
PE
3530 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3531 clobbering (Bug#8298).
b9c7f648
PE
3532 * sysdep.c (sys_subshell): Likewise.
3533 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3534
6bd8c144
PE
3535 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3536 This should get cleaned up, so that child_setup has the
3537 same signature on all platforms.
3538
7710357c 3539 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3540 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3541
c59da222
CY
35422011-03-22 Chong Yidong <cyd@stupidchicken.com>
3543
3544 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3545 not to be necessary, and produces flickering.
3546
66b87493
GM
35472011-03-20 Glenn Morris <rgm@gnu.org>
3548
3549 * config.in: Remove file.
3550
45b6f6d5
JB
35512011-03-20 Juanma Barranquero <lekktu@gmail.com>
3552
3553 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3554 are now in src/globals.h.
3555 (syms_of_minibuf): Remove spurious & from previous change.
3556
3ec03f7e
LL
35572011-03-20 Leo <sdl.web@gmail.com>
3558
3559 * minibuf.c (completing-read-function): New variable.
3560 (completing-read-default): Rename from completing-read.
3561 (completing-read): Call completing-read-function.
3562
b14e3e21
CY
35632011-03-19 Juanma Barranquero <lekktu@gmail.com>
3564
3565 * xfaces.c (Fx_load_color_file):
3566 Read color file from absolute filename (bug#8250).
3567
f2b726e6
JB
35682011-03-19 Juanma Barranquero <lekktu@gmail.com>
3569
3570 * makefile.w32-in: Update dependencies.
3571
09f6ff02
EZ
35722011-03-17 Eli Zaretskii <eliz@gnu.org>
3573
3574 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3575
29a6015a
PE
35762011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3577
a3a6c54e
PE
3578 Fix more problems found by GCC 4.5.2's static checks.
3579
b766f867
PE
3580 * process.c (make_serial_process_unwind, send_process_trap):
3581 (sigchld_handler): Now static.
3582
be02381c
PE
3583 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3584 That way, the code declares only the vars that it needs.
3585 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3586 * s/cygwin.h (PTY_ITERATION): Likewise.
3587 * s/darwin.h (PTY_ITERATION): Likewise.
3588 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3589
57048744
PE
3590 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3591 * process.c (allocate_pty): Don't declare stb unless it's needed.
3592
7914961c 3593 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3594 (CONSTANTLIM): Remove; unused.
3595 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3596 Define only if needed.
7914961c 3597
b3967b18
PE
3598 * unexelf.c (unexec): Name an expression,
3599 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3600 Use a different way to cause a compilation error if anyone uses
3601 n rather than nn, a way that does not involve shadowing.
73366a00 3602 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3603
29a6015a
PE
3604 * deps.mk (unexalpha.o): Remove; unused.
3605
43cfc33e 3606 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3607 * unexec.h: New file.
ce701a33
PE
3608 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3609 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3610 Depend on unexec.h.
3611 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3612 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3613 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3614 Change as necessary to match prototype in unexec.h.
ce701a33 3615
01f44d5a
PE
3616 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3617 shadowing.
4f63c6bb 3618 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3619
a6670b0b
PE
3620 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3621 Rename locals to avoid shadowing.
3622
cef2010d 3623 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3624 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3625
d4d7173a
PE
3626 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3627
f08b802a
PE
3628 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3629 warning when compiling print.c.
3630
3ddb0639
PE
3631 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3632 instead of using an uninitialized var.
5ad03b97 3633 (font_sort_entities): Mark var as initialized.
3ddb0639 3634
170a2692
PE
3635 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3636
e663c700
PE
3637 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3638 pointers to constants.
89bc529a 3639 (font_parse_fcname): Remove unused vars.
7b81e2d0 3640 (font_delete_unmatched): Now static.
ea838e10 3641 (font_get_spec): Remove; unused.
13a547c6
PE
3642 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3643 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3644 Rename or move locals to avoid shadowing.
e663c700 3645
2a80c887 3646 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3647 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3648
1384fa33 3649 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3650 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3651
8b2c52e9
PE
3652 * alloc.c (mark_backtrace): Move decl from here ...
3653 * lisp.h: ... to here, so that it can be checked.
3654
475545b5 3655 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3656 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3657 (lisp_indirect_variable): Name an expression,
3658 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3659 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3660
b1349114 3661 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3662 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3663 Use const pointer when appropriate.
b1349114 3664
a2928364
PE
3665 * lisp.h (get_system_name, get_operating_system_release):
3666 Move decls here, to check interfaces.
3667 * process.c (get_operating_system_release): Move decl to lisp.h.
3668 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3669 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3670 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3671 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3672 (Fformat_time_string, Fencode_time, Finsert_char):
3673 (Ftranslate_region_internal, Fformat):
3674 Rename or remove local vars to avoid shadowing.
9710023e 3675 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3676
a415e694
PE
3677 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3678 avoid shadowing.
3679
8ef4622d
PE
3680 * lisp.h (eassert): Check that the argument compiles, even if
3681 ENABLE_CHECKING is not defined.
3682
946f9a5b
PE
3683 * data.c (Findirect_variable): Name an expression, to avoid
3684 gcc -Wbad-function-cast warning.
112396d6 3685 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3686 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3687 (Fmake_variable_buffer_local, Fmake_local_variable):
3688 Mark variables as initialized.
52746918 3689 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3690
e5aab7e7 3691 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3692 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3693 Rename locals to avoid shadowing.
dff45157
PE
3694 (mark_stack): Move local variables into the #ifdef region where
3695 they're used.
7bc26fdb
PE
3696 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3697 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3698 needed otherwise.
3699 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3700 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3701 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3702
e5aab7e7
PE
3703 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3704 avoids undefined behavior in theory.
3705
4da60324
PE
3706 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3707
88043301
PE
3708 Use functions, not macros, for up- and down-casing (Bug#8254).
3709 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3710 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3711 to use the following functions instead of these macros.
3712 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3713 EMACS_INT, since callers assume the returned value fits in int.
3714 (upcase1): Likewise, for UPCASE_TABLE.
3715 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3716 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3717 the race-condition problem in the old DOWNCASE.
88043301 3718
19ed5445
PE
3719 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3720 Rename locals to avoid shadowing.
3721 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3722 (regex_compile, re_search_2, re_match_2_internal):
3723 Remove unused local vars.
952db0d7
PE
3724 (FREE_VAR): Rewrite so as not to use empty "else",
3725 which gcc can warn about.
da053e48 3726 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3727 (RETALLOC_IF): Define only if needed.
3728 (WORDCHAR_P): Likewise. This one is never needed, but is used
3729 only in a comment talking about a compiler bug, so put inside
3730 the #if 0 of that comment.
3731 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3732 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3733 Remove; unused.
19ed5445 3734
1f3561e4 3735 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3736 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3737 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3738
ded6f8f7
PE
3739 * search.c (simple_search): Remove unused var.
3740
dbd37a95
PE
3741 * dired.c (compile_pattern): Move decl from here ...
3742 * lisp.h: ... to here, so that it can be checked.
3743 (struct re_registers): New forward decl.
3744
7e47afad
PE
3745 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3746
85f24f61
PE
3747 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3748 All uses changed.
3749 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3750 Rename locals to avoid shadowing.
5671df8f 3751 (Fvertical_motion): Mark locals as initialized.
85f24f61 3752
181aa2be 3753 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3754 (casify_region): Mark local as initialized.
181aa2be 3755
930d429c
PE
3756 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3757
7082eac6
PE
3758 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3759 New macros, so that the caller can use some names other than
3760 gcpro1, gcpro2, etc.
3761 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3762 of the new macros.
3763 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3764 argument, for consistency with GCPRO2_VAR, etc: it is now the
3765 prefix of the variable, not the variable itself. All uses
3766 changed.
38b2c076
PE
3767 * dired.c (directory_files_internal, file_name_completion):
3768 Rename locals to avoid shadowing.
3769
15206ed9
PE
3770 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3771 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3772 dired.c's scmp function, had undefined behavior.
3773 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3774 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3775 * buffer.h: ... to here, because these macros use current_buffer,
3776 and the new implementation with inline functions needs to have
3777 current_buffer in scope now, rather than later when the macros
3778 are used.
3779 (downcase, upcase1): New static inline functions.
3780 (DOWNCASE, UPCASE1): Reimplement using these functions.
3781 This avoids undefined behavior in expressions like
3782 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3783 from race conditions in accessing the global variables
3784 case_temp1 and case_temp2.
3785 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3786 * lisp.h (case_temp1, case_temp2): Remove their decls.
3787 * character.h (ASCII_CHAR_P): Move from here ...
3788 * lisp.h: ... to here, so that the inline functions mentioned
3789 above can use them.
3790
4a6bea26
PE
3791 * dired.c (directory_files_internal_unwind): Now static.
3792
f14b7e14
PE
3793 * fileio.c (file_name_as_directory, directory_file_name):
3794 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3795 Now static.
2893f146
PE
3796 (file_name_as_directory): Use const pointers when appropriate.
3797 (Fexpand_file_name): Likewise. In particular, newdir might
3798 point at constant storage, so make it a const pointer.
fd4ead52 3799 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3800 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3801 signedness issues.
f839df0c
PE
3802 (Fset_file_times, Finsert_file_contents, auto_save_error):
3803 Rename locals to avoid shadowing.
f14b7e14 3804
5716756e 3805 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3806 (Ftry_completion, Fall_completions): Rename or remove locals
3807 to avoid shadowing.
5716756e 3808
b4c3046a
PE
3809 * marker.c (bytepos_to_charpos): Remove; unused.
3810
b45db522
PE
3811 * lisp.h (verify_bytepos, count_markers): New decls,
3812 so that gcc does not warn that these functions aren't declared.
3813
85876d07
PE
3814 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3815 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3816 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3817 (copy_text): Remove unused local var.
85876d07 3818
03d78a21 3819 * filelock.c (within_one_second): Now static.
b3dd38ab 3820 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3821
5df8f01b
PE
3822 * buffer.c (fix_overlays_before): Mark locals as initialized.
3823 (fix_start_end_in_overlays): Likewise. This function should be
3824 simplified by using pointers-to-pointers, but that's a different
3825 matter.
b1d876f1 3826 (switch_to_buffer_1): Now static.
8f54f30a
PE
3827 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3828 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3829
a70072c9 3830 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3831 Fix pointer signedness issue.
edced198
PE
3832 (sys_subshell): Mark local as volatile if checking for lint,
3833 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3834 (MAXPATHLEN): Define only if needed.
a70072c9 3835
a0977c44
PE
3836 * process.c (serial_open, serial_configure): Move decls from here ...
3837 * systty.h: ... to here, so that they can be checked.
3838
a884fdcc
PE
3839 * fns.c (get_random, seed_random): Move extern decls from here ...
3840 * lisp.h: ... to here, so that they can be checked.
3841
604efe86 3842 * sysdep.c (reset_io): Now static.
b8950c94 3843 (wait_for_termination_signal): Remove; unused.
604efe86 3844
38fc62d9
PE
3845 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3846 (copy_keymap_item, append_key, push_text_char_description):
3847 Now static.
1004a21a 3848 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3849 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3850 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3851 (describe_map_tree):
3852 Rename locals to avoid shadowing.
38fc62d9 3853
2f2650da
PE
3854 * keyboard.c: Declare functions static if they are not used elsewhere.
3855 (echo_char, echo_dash, cmd_error, top_level_2):
3856 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3857 (read_char, kbd_buffer_get_event, make_lispy_position):
3858 (make_lispy_event, make_lispy_movement, apply_modifiers):
3859 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3860 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3861 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3862 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3863 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3864
a053e86c 3865 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3866 (mark_kboards): Move decl here ...
3867 * alloc.c (mark_kboards): ... from here.
a053e86c 3868
4752793e
PE
3869 * lisp.h (force_auto_save_soon): New decl.
3870
74f10ca7 3871 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3872 (DEFINE_DUMMY_FUNCTION): New macro.
3873 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3874 Use it.
c03cd23f
PE
3875 (main): Add casts to avoid warnings
3876 if GCC considers string literals to be constants.
74f10ca7 3877
022e70d4
PE
3878 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3879
59d6fe83
PE
3880 * dbusbind.c: Pointer signedness fixes.
3881 (xd_signature, xd_append_arg, xd_initialize):
3882 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3883 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3884 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3885 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3886
78320123
PE
3887 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3888 if GCC considers string literals to be constants.
49cebcca 3889 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3890
35ac2a97
SM
38912011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3892
fb103ca9
SM
3893 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3894 (print_preprocess, print_object): New macro to fix last change.
3895
35ac2a97
SM
3896 * print.c (print_preprocess): Don't forget font objects.
3897
62973b41
JB
38982011-03-16 Juanma Barranquero <lekktu@gmail.com>
3899
3900 * emacs.c (USAGE3): Doc fixes.
3901
0e48bb22
AS
39022011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3903
3904 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3905 structure.
3906
7684e57b
JB
39072011-03-14 Juanma Barranquero <lekktu@gmail.com>
3908
3909 * lisp.h (VWindow_system, Qfile_name_history):
3910 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3911 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3912 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3913
3914 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3915 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3916
3917 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3918 * w32console.c (detect_input_pending, read_input_pending)
3919 (encode_terminal_code):
3920 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3921 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3922 (w32_system_caret_y, Qfile_name_history):
3923 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3924 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3925 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3926 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3927 * w32proc.c (Qlocal, report_file_error):
3928 * w32term.c (Vwindow_system, updating_frame):
3929 * w32uniscribe.c (initialized, uniscribe_font_driver):
3930 Remove unneeded extern declarations.
3931
2aa46d6c
CY
39322011-03-14 Chong Yidong <cyd@stupidchicken.com>
3933
c96bbc66 3934 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3935
cffc6f3b
CY
39362011-03-13 Chong Yidong <cyd@stupidchicken.com>
3937
3938 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3939 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3940 These macros can no longer be used for assignment.
3941
44f230aa
SM
3942 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3943 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3944 (record_buffer_markers, fetch_buffer_markers): New functions for
3945 recording and fetching special buffer markers.
3946 (set_buffer_internal_1, set_buffer_temp): Use them.
3947
3948 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3949
3950 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3951
3952 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3953 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3954
3955 * xdisp.c (hscroll_window_tree):
3956 (reconsider_clip_changes): Use PT instead of BUF_PT.
3957
d251f04b
EZ
39582011-03-13 Eli Zaretskii <eliz@gnu.org>
3959
3960 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3961 $(EMACS_ROOT)/lib/intprops.h.
3962
f0c77cd1
PE
39632011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3964
3eca4629
PE
3965 Fix more problems found by GCC 4.5.2's static checks.
3966
7c86ee98
PE
3967 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3968 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3969 (xg_free_frame_widgets): Make it clear that a local variable is
3970 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3971 (gdk_window_get_screen): Make it clear that this macro is needed
3972 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3973 (int_gtk_range_get_value): New function, which avoids a diagnostic
3974 from gcc -Wbad-function-cast.
3975 (xg_set_toolkit_scroll_bar_thumb): Use it.
3976 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3977 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3978 (get_utf8_string, xg_get_file_with_chooser):
3979 Rename locals to avoid shadowing.
3980 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3981
41729b81
PE
3982 * xgselect.c (xg_select): Remove unused var.
3983
f0c77cd1
PE
3984 * image.c (four_corners_best): Mark locals as initialized.
3985 (gif_load): Initialize transparent_p to zero (Bug#8238).
3986 Mark another local as initialized.
ec6cf4c6 3987 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3988
ce0ad53d 3989 * image.c (clear_image_cache): Now static.
d5d5a617 3990 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3991 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3992 (x_edge_detection): Remove unnecessary cast that
3993 gcc -Wbad-function-cast diagnoses.
2037898d 3994 (gif_load): Fix pointer signedness.
6ae141d6
PE
3995 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3996 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3997
33383987 39982011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3999
d32df629
PE
4000 Improve quality of tests for time stamp overflow.
4001 For example, without this patch (encode-time 0 0 0 1 1
4002 1152921504606846976) returns the obviously-bogus value (-948597
4003 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4004 reports time overflow. See
4005 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4006 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4007 * editfns.c: Include limits.h and intprops.h.
4008 (TIME_T_MIN, TIME_T_MAX): New macros.
4009 (time_overflow): Move earlier, to before first use.
4010 (hi_time, lo_time): New functions, for an accurate test for
4011 out-of-range times.
4012 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4013 (Fget_internal_run_time): Don't assume time_t fits in int.
4014 (make_time): Use list2 instead of Fcons twice.
4015 (Fdecode_time): More accurate test for out-of-range times.
4016 (check_tm_member): New function.
4017 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4018 (lisp_time_argument): Don't rely on undefined left-shift and
4019 right-shift behavior when checking for time stamp overflow.
8be6f318 4020
fe31d94c
PE
4021 * editfns.c (time_overflow): New function, refactoring common code.
4022 (Fformat_time_string, Fdecode_time, Fencode_time):
4023 (Fcurrent_time_string): Use it.
4024
8be6f318
PE
4025 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4026 * dired.c (make_time): Move to ...
4027 * editfns.c (make_time): ... here.
4028 * systime.h: Note the move.
4029
09d9db2c 40302011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4031
126bc0dc
YM
4032 * fringe.c (update_window_fringes): Remove unused variables.
4033
c47cbdfd
YM
4034 * unexmacosx.c (copy_data_segment): Also copy __got section.
4035 (Bug#8223)
4036
7ac80be9
EZ
40372011-03-12 Eli Zaretskii <eliz@gnu.org>
4038
c96bbc66 4039 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4040 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4041 Constify `char *' arguments and their references according to
4042 prototypes in tparam.h.
4043
ecb0f94d 4044 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4045
7ac80be9
EZ
4046 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4047 Adapt all references accordingly.
4048
4049 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4050
ef1fd07e
TT
40512011-03-11 Tom Tromey <tromey@redhat.com>
4052
4053 * buffer.c (syms_of_buffer): Remove obsolete comment.
4054
7ef4b50c
EZ
40552011-03-11 Eli Zaretskii <eliz@gnu.org>
4056
4057 * termhooks.h (encode_terminal_code): Declare prototype.
4058
4059 * msdos.c (encode_terminal_code): Don't declare prototype.
4060
4061 * term.c (encode_terminal_code): Now external again, used by
4062 w32console.c and msdos.c.
4063
44f230aa
SM
4064 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4065 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4066
4b1ec863 40672011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4068
1714f52b 4069 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4070
4b1ec863
PE
4071 * fringe.c (update_window_fringes): Mark locals as initialized
4072 (Bug#8227).
4073 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4074
524c7aa6
PE
4075 * alloc.c (mark_fringe_data): Move decl from here ...
4076 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4077 to check its interface.
4078 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4079
a5c0af81 4080 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4081 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4082 (fontset_font): Mark local as initialized.
a9a06e0b 4083 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4084
b4716021
PE
4085 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4086
811e9bac 4087 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4088 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4089 (x_own_selection, Fx_disown_selection_internal): Rename locals
4090 to avoid shadowing.
4091 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4092
7e3ab302
PE
4093 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4094 so that the caller can use some name other than gcpro1.
4095 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4096 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4097 (Fx_backspace_delete_keys_p):
4098 Use them to avoid shadowing, and rename vars to avoid shadowing.
4099 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4100 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4101 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4102 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4103 Remove unused locals.
7e3ab302
PE
4104 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4105 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4106 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4107 macros.
f78faa98 4108
e2b13473
PE
4109 * xterm.h (x_mouse_leave): New decl.
4110
77f23912
PE
4111 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4112 Remove unused functions.
cdf4ba58
PE
4113 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4114 (x_calc_absolute_position): Now static.
7411c686 4115 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4116 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4117 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4118 unless they are used.
38d0b34a
PE
4119 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4120 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4121 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4122 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4123 (x_error_catcher, x_connection_closed, x_error_handler):
4124 (x_error_quitter, xembed_send_message, x_iconify_frame):
4125 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4126 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4127 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4128
44f230aa
SM
4129 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4130 Rename or move locals to avoid shadowing.
6b463e58 4131 (tty_defined_color, merge_face_heights): Now static.
5967d051 4132 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4133 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4134 does not deduce is never used uninitialized.
73719eba
PE
4135 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4136 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4137
426994c3 4138 * terminal.c (store_terminal_param): Now static.
5489860b 4139
032f1620 4140 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4141 (set_frame_menubar): Remove unused local.
d4323972 4142 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4143 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4144 since they might point to immutable storage.
281585b0
PE
4145 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4146 since it's unused otherwise.
032f1620 4147
367c19e5 4148 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4149 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4150 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4151 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4152 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4153 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4154 does not deduce are never used uninitialized.
70739cbe 4155
07b48fa9
PE
4156 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4157
8868a238 4158 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4159 * window.c (window_loop, size_window):
4160 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4161
7e5cf297 4162 * window.c (display_buffer): Now static.
d6550a9f
PE
4163 (size_window): Mark variables that gcc -Wuninitialized
4164 does not deduce are never used uninitialized.
a586633d
PE
4165 * window.h (check_all_windows): New decl, to forestall
4166 gcc -Wmissing-prototypes diagnostic.
5b555da1 4167 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4168
f6095868
PE
4169 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4170 shadowing.
4171 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4172 Include <limits.h>.
4173 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4174 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4175 (load_charset_map): Mark variables that gcc -Wuninitialized
4176 does not deduce are never used uninitialized.
53df7c11 4177 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4178
f38b440c
PE
4179 * coding.c (coding_set_source, coding_set_destination):
4180 Use "else { /* comment */ }" rather than "else /* comment */;"
4181 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4182 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4183 a block, when the outer 'i' will do.
4184 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4185 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4186 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4187 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4188 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4189 Rename locals to avoid shadowing.
4190 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4191 * coding.c (emacs_mule_char, encode_invocation_designation):
4192 Now static, since they're not used elsewhere.
413bb2db 4193 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4194 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4195 (decode_coding_emacs_mule): Mark variables that gcc
4196 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4197 (detect_coding_iso_2022): Initialize a local variable that might
4198 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4199 this initialization is needed. (Bug#8211)
5f58e762
PE
4200 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4201 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4202 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4203 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4204 Remove unused macros.
f38b440c 4205
232b38b9 4206 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4207 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4208 * character.c (string_count_byte8): Likewise.
232b38b9 4209
fb90da1b
PE
4210 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4211 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4212
fb93dbc2
PE
4213 * chartab.c (copy_sub_char_table): Now static, since it's not used
4214 elsewhere.
5c156ace
PE
4215 (sub_char_table_ref_and_range, char_table_ref_and_range):
4216 Rename locals to avoid shadowing.
bbcd0949 4217 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4218
7d3b3862 4219 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4220 (BIDI_BOB): Remove unused macro.
7d3b3862 4221
6be7d3da
PE
4222 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4223 deduce are never used uninitialized.
c2ed9c8b 4224 * term.c (encode_terminal_code): Likewise.
6be7d3da 4225
75f8807f 4226 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4227
50938595
PE
4228 * tparam.h: New file.
4229 * term.c, tparam.h: Include it.
4230 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4231 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4232 Move these decls to tparam.h, and make them agree with what
4233 is actually in tparam.c. The previous trick of using incompatible
4234 decls in different modules does not conform to the C standard.
4235 All callers of tparam changed to use tparam's actual API.
4236 * tparam.c (tparam1, tparam, tgoto):
4237 Use const pointers where appropriate.
4238
fbceeba2
PE
4239 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4240 * cm.h (struct cm): Likewise.
4241 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4242 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4243 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4244 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4245 (turn_on_face, init_tty): Likewise.
4246 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4247
7f3f1250
PE
4248 * term.c (term_mouse_position): Rename local to avoid shadowing.
4249
e6ca6543
PE
4250 * alloc.c (mark_ttys): Move decl from here ...
4251 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4252
c40f8d15
AS
42532011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4254
4255 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4256
cfe0661d
JB
42572011-03-09 Juanma Barranquero <lekktu@gmail.com>
4258
4259 * search.c (compile_pattern_1): Remove argument regp, unused since
4260 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4261 (compile_pattern): Don't pass it.
4262
0afb4571
J
42632011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4264
4265 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4266 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4267 for ! HAVE_GTK3.
4268 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4269
4270 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4271
4272 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4273 gdk_window_get_screen, gdk_window_get_geometry,
4274 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4275 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4276 (xg_get_pixbuf_from_pixmap): New function.
4277 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4278 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4279 Call xg_get_pixbuf_from_pixmap instead of
4280 gdk_pixbuf_get_from_drawable.
4281 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4282 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4283 (xg_check_special_colors): Use GtkStyleContext and its functions
4284 for HAVE_GTK3.
4285 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4286 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4287 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4288 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4289 Call gtk_widget_get_preferred_size.
0afb4571
J
4290 (xg_frame_resized): gdk_window_get_geometry only takes 5
4291 parameters.
44f230aa
SM
4292 (xg_win_to_widget, xg_event_is_for_menubar):
4293 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4294 (xg_set_widget_bg): New function.
4295 (delete_cb): New function.
895009e1 4296 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4297 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4298 (xg_set_background_color): Call xg_set_widget_bg.
4299 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4300 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4301 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4302 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4303 if ! HAVE_GTK3.
4304 (update_frame_tool_bar): Call gtk_widget_hide.
4305 (xg_initialize): Use GDK_KEY_g.
4306
4307 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4308 if ! HAVE_GTK3
4309 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4310
4311 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4312 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4313 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4314
1c2cc4ef
JB
43152011-03-08 Juanma Barranquero <lekktu@gmail.com>
4316
4317 * w32xfns.c (select_palette): Check success of RealizePalette against
4318 GDI_ERROR, not zero.
4319
33383987 4320See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4321
4322;; Local Variables:
4323;; coding: utf-8
aac0c6e3
MR
4324;; End:
4325
33383987 4326 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4327
4328 This file is part of GNU Emacs.
4329
4330 GNU Emacs is free software: you can redistribute it and/or modify
4331 it under the terms of the GNU General Public License as published by
4332 the Free Software Foundation, either version 3 of the License, or
4333 (at your option) any later version.
4334
4335 GNU Emacs is distributed in the hope that it will be useful,
4336 but WITHOUT ANY WARRANTY; without even the implied warranty of
4337 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4338 GNU General Public License for more details.
4339
4340 You should have received a copy of the GNU General Public License
4341 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.